004c22c8cf7c42032121fc6ddb5cd43081a77696
[WebKit-https.git] / Tools / ChangeLog
1 2011-09-30  Daniel Bates  <dbates@rim.com>
2
3         Cleanup: Extract code to launch a Mac WebKit application into a common function
4         https://bugs.webkit.org/show_bug.cgi?id=68662
5
6         Reviewed by Adam Roben.
7
8         Extracts common code to launch a WebKit application on Mac OS X into a function
9         so that we can remove duplicate code.
10
11         * Scripts/run-webkit-app: Modified to use webkitdirs::runMacWebKitApp().
12         * Scripts/webkitdirs.pm: Sorted @EXPORT list and added constant USE_OPEN_COMMAND.
13         (runMacWebKitApp): Added.
14         (runSafari): Modified to use webkitdirs::runMacWebKitApp().
15         (runMiniBrowser): Ditto.
16         (runWebKitTestRunner): Ditto.
17         (runTestWebKitAPI): Ditto.
18
19 2011-09-29  David Levin  <levin@chromium.org>
20
21         watchlist: Add webkit-patch command to run watchlist.
22         https://bugs.webkit.org/show_bug.cgi?id=68973
23
24         Reviewed by Eric Seidel.
25
26         * Scripts/webkitpy/common/host.py: Exposed the watch_list.
27         * Scripts/webkitpy/common/watchlist/watchlist.py: Changed to return
28         the cc and messages as sorted lists. To allow for deterministic ordering.
29         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Ditto.
30         * Scripts/webkitpy/tool/commands/__init__.py: Add ApplyWatchListLocal so
31         that it will be exposed as a command by webkit-patch.
32         * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Added.
33         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Added.
34         * Scripts/webkitpy/tool/commands/download.py: Added ApplyWatchList which mimics CheckStyle.
35         * Scripts/webkitpy/tool/commands/download_unittest.py: Added an appropriate test.
36         * Scripts/webkitpy/tool/mocktool.py: Mock out the watch list.
37         * Scripts/webkitpy/tool/steps/__init__.py: Added ApplyWatchList.
38         * Scripts/webkitpy/tool/steps/applywatchlist.py: Added.
39         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Added.
40
41 2011-09-30  David Levin  <levin@chromium.org>
42
43         watchlist: Add a way to detect a net increase or decrease of a pattern (in a file).
44         https://bugs.webkit.org/show_bug.cgi?id=69031
45
46         Reviewed by Adam Barth.
47
48         * Scripts/webkitpy/common/config/watchlist: Added usage of the new pattern,
49         a comment to explain something important about the email addresses, and
50         a comment to let emacs know to treat the file as a python file.
51         * Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Added.
52         Detects increases or decreases in a pattern.
53         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Added.
54         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
55         Added unit tests for watchlist which has "more" or "less".
56         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
57         Added support for "more" or "less".
58
59 2011-09-30  Sam Weinig  <sam@webkit.org>
60
61         Add support for eventSender.mouseScrollBy in WTR
62         https://bugs.webkit.org/show_bug.cgi?id=69189
63
64         Add implementation of eventSender.mouseScrollBy for the mac.
65
66         Reviewed by Simon Fraser.
67
68         * WebKitTestRunner/EventSenderProxy.h:
69         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
70         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
71         (WTR::EventSendingController::keyDown):
72         (WTR::EventSendingController::mouseScrollBy):
73         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
74         * WebKitTestRunner/TestController.cpp:
75         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
76         * WebKitTestRunner/mac/EventSenderProxy.mm:
77         (WTR::EventSenderProxy::mouseScrollBy):
78
79 2011-09-30  Simon Fraser  <simon.fraser@apple.com>
80
81         fast/forms/text-control-intrinsic-widths.html fails on Mac if Word/Office fonts are installed
82         https://bugs.webkit.org/show_bug.cgi?id=35273
83
84         Reviewed by Dan Bernstein.
85         
86         There are two types of font issue that can cause layout test failure.
87         First, the user may have non-standard fonts installed that affect the layout
88         of some tests. For example, some tests use the MS Gothic font if installed.
89         
90         Secondly, the user may have duplicate fonts installed in ~/Library/Fonts,
91         which override the system fonts (e.g. a copy of Arial from MS Office). For
92         some tests, this can affect font metrics or fallback behavior.
93         
94         This change addresses the first problem only. It limits the set of fonts
95         available through NSFontManager, by swizzling some methods to return
96         a list of fonts or font families which only include fonts from a hardcoded
97         whitelist.
98         
99         * DumpRenderTree/mac/DumpRenderTree.mm:
100         (allowedFontFamilySet):
101         (drt_NSFontManager_availableFontFamilies):
102         (drt_NSFontManager_availableFonts):
103         (swizzleNSFontManagerMethods):
104         (activateTestingFonts):
105         (adjustFonts):
106         (createWebViewAndOffscreenWindow):
107         (prepareConsistentTestingEnvironment):
108         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
109         (WTR::allowedFontFamilySet):
110         (WTR::drt_NSFontManager_availableFontFamilies):
111         (WTR::drt_NSFontManager_availableFonts):
112         (WTR::swizzleNSFontManagerMethods):
113         (WTR::InjectedBundle::platformInitialize):
114
115 2011-09-30  David Levin  <levin@chromium.org>
116
117         Need to skip webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest on Windows..
118         https://bugs.webkit.org/show_bug.cgi?id=69039
119
120         Reviewed by Adam Barth.
121
122         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
123         Actually skip only one specific test that is failing on Windows.
124
125 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
126
127         [Qt] Prevent qDebug() output from DRT and WTR unless --verbose
128
129         For DRT we didn't install the message handler early enough to
130         catch output while constructing the QApplication. For WTR we
131         didn't even install a message handler.
132
133         Since the UI process will forward any output from the web process
134         we set an environment variable QT_WEBKIT_SUPPRESS_WEB_PROCESS_OUTPUT
135         in WTR before the web process is started. This is picked up by the
136         web process which installs its own message handler.
137
138         The environment variable can be overriden on the command line if you
139         want to see output from the web process, or you can pass --verbose to
140         WTR to see output from both processes.
141
142         https://bugs.webkit.org/show_bug.cgi?id=69132
143
144         Reviewed by Andreas Kling.
145
146         * DumpRenderTree/qt/main.cpp:
147         * WebKitTestRunner/qt/main.cpp:
148
149 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
150
151         [Qt] Make sure WTR sizes the window and item correctly
152
153         Revision 96345 changed the logic for how the view and
154         window was created, but missed a vital part, setting
155         the size.
156
157         We now use a QSGView for the window, that has a simple
158         item as its root object that is always resized to fit
159         within the window. The webview is then parented to the
160         root object and set to anchors.fill: parent. That way
161         any window geometry changes will propagate to the web
162         view.
163
164         https://bugs.webkit.org/show_bug.cgi?id=69134
165
166         Reviewed by Andreas Kling.
167
168         * WebKitTestRunner/PlatformWebView.h:
169         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
170
171 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
172
173         [EFL] Only save the current viewport in PixelDumpSupportEfl.
174         https://bugs.webkit.org/show_bug.cgi?id=68450
175
176         Reviewed by Antonio Gomes.
177
178         The previous implementation saved the whole page contents in the final
179         PNG, however the baselines and expectations in the tree only want the
180         current viewport (with a scrollbar, if needed), so we now only save the
181         currently visible contents.
182
183         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
184         (createBitmapContextFromWebView): Use
185         ewk_frame_visible_content_geometry_get instead of
186         ewk_frame_contents_size_get.
187
188 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
189
190         [EFL] Support and keep track of extra windows (views).
191         https://bugs.webkit.org/show_bug.cgi?id=68454
192
193         Reviewed by Antonio Gomes.
194
195         So far, window.open and related JavaScript code would not work, as
196         DRTView did not implementation
197         Ewk_View_Smart_Class::window_{open,close}. The default implementation
198         in ewk just returns the current window/view, which broke any
199         layouttest which relied on window.open.
200
201         We now properly create and remove these new views. Unfortunately, the
202         current way ewk works (and due to the fact that we cannot pass class
203         methods as function pointers to the EFL functions), DRTView needs to
204         know that DRTChrome exists and call `browser' directly in some points.
205
206         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
207         (onWindowCreate):
208         (onWindowCloseDelayed):
209         (onWindowClose):
210         (drtViewTiledAdd):
211
212 2011-09-30  Qi Zhang  <qi.2.zhang@nokia.com>
213
214         WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
215         https://bugs.webkit.org/show_bug.cgi?id=42698
216
217         Reviewed by Andreas Kling.
218
219         Implemented layoutTestController.setAppCacheMaximumSize and layoutTestController.clearApplicationCache,
220         and call clearApplicationCache when layoutTest start up.
221
222         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
223         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
224         (WTR::InjectedBundle::beginTesting):
225         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
226         (WTR::LayoutTestController::clearAllApplicationCaches):
227         (WTR::LayoutTestController::setAppCacheMaximumSize):
228         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
229
230 2011-09-30  Zeno Albisser  <zeno.albisser@nokia.com>
231
232         [Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSceneMouseEvents
233         https://bugs.webkit.org/show_bug.cgi?id=69145
234
235         This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=69105
236         Due to refactorings in Qt5, QMouseEvent now supports floating point coordinates
237         and is perfectly suitable for SceneGraph as well. GraphicsScene events
238         will not be available in QtGui anymore in future. Therefore we also have to change
239         QtWebKit to use QMouseEvents instead of QGraphicsSceneMouseEvents.
240
241         Reviewed by Chang Shu.
242
243         * WebKitTestRunner/EventSenderProxy.h:
244         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
245         (WTR::EventSenderProxy::createMouseEvent):
246         (WTR::EventSenderProxy::mouseDown):
247         (WTR::EventSenderProxy::mouseUp):
248         (WTR::EventSenderProxy::mouseMoveTo):
249
250 2011-09-30  James Robinson  <jamesr@chromium.org>
251
252         [chromium] Add WebKit API for sending input events to the compositor thread
253         https://bugs.webkit.org/show_bug.cgi?id=69117
254
255         Reviewed by Darin Fisher.
256
257         Adds support for creating and setting a compositor thread in DRT.
258
259         * DumpRenderTree/chromium/WebViewHost.cpp:
260         (WebViewHost::WebViewHost):
261         * DumpRenderTree/chromium/WebViewHost.h:
262
263 2011-09-29  David Levin  <levin@chromium.org>
264
265         watchlist: Add cross-checks for WatchList once it is filled.
266         https://bugs.webkit.org/show_bug.cgi?id=68975
267
268         Reviewed by Eric Seidel.
269
270         * Scripts/webkitpy/common/watchlist/watchlist.py: Made the data members public
271         instead of having trivial getter and setters.
272         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Fix the unit tests to
273         pass the validation checks.
274         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add validation checks
275         and fix a few style nits.
276         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests for the
277         validation checks.
278         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Make definitions_to_match public.
279
280 2011-09-29  Xianzhu Wang  <wangxianzhu@chromium.org>
281
282         run-api-tests fails on chromium-win bot
283         https://bugs.webkit.org/show_bug.cgi?id=69121
284
285         On Windows running a perl script needs the interpreter.
286
287         Reviewed by Adam Barth.
288
289         * Scripts/run-api-tests:
290         (buildTestTool):
291
292 2011-09-29  Adam Barth  <abarth@webkit.org>
293
294         Attempt to make this tool work on Windows.
295
296         * Scripts/run-api-tests:
297         (buildTestTool):
298
299 2011-09-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
300
301         [Qt] Try to fix the minial build
302
303         * QtTestBrowser/launcherwindow.cpp:
304         * QtTestBrowser/webpage.cpp:
305
306 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
307
308         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
309
310         QWidget and friends now live in the QtWidgets library. We update
311         includes in implementation files and private headers to us the
312         non-module-prefixed path, and leave the lookup for the include
313         path. For public headers we have to ifdef the includes as the
314         user might now have the modules we need in his QT config.
315
316         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
317         have to update our code and use windowHandle() for setting the
318         parent relationships.
319
320         https://bugs.webkit.org/show_bug.cgi?id=68687
321
322         Reviewed by Andreas Kling.
323
324         * DumpRenderTree/qt/DumpRenderTree.pro:
325         * DumpRenderTree/qt/ImageDiff.pro:
326         * MiniBrowser/qt/BrowserView.cpp:
327         * MiniBrowser/qt/BrowserView.h:
328         * MiniBrowser/qt/BrowserWindow.cpp:
329         * MiniBrowser/qt/BrowserWindow.h:
330         * MiniBrowser/qt/MiniBrowser.pro:
331         * MiniBrowser/qt/MiniBrowserApplication.h:
332         * MiniBrowser/qt/main.cpp:
333         * QtTestBrowser/QtTestBrowser.pro:
334         * QtTestBrowser/launcherwindow.cpp:
335         * QtTestBrowser/launcherwindow.h:
336         * QtTestBrowser/locationedit.h:
337         * QtTestBrowser/main.cpp:
338         * QtTestBrowser/mainwindow.cpp:
339         * QtTestBrowser/mainwindow.h:
340         * QtTestBrowser/webinspector.h:
341         * QtTestBrowser/webpage.cpp:
342         * QtTestBrowser/webview.cpp:
343         * WebKitTestRunner/PlatformWebView.h:
344         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
345
346 2011-09-29  Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com>
347
348         Initial implementation of WebInspector for WebKit2 GTK port.
349         https://bugs.webkit.org/show_bug.cgi?id=68235
350
351         Reviewed by Martin Robinson.
352
353         * MiniBrowser/gtk/BrowserWindow.c:
354         (browserWindowConstructed): Set the developer extra flags to true to enable inspect element.
355
356 2011-09-29  Adam Barth  <abarth@webkit.org>
357
358         Unbreak the "update expectatations" button by using the existing
359         machinery to create the failureInfo objects.
360
361         Unbreak the "close" button on the progress dialog by using |this|
362         instead of the old name of the object.
363
364         Teach the controllers unit test not to talk to the actual network.
365
366         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
367         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
368         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
369
370 2011-09-29  Hans Wennborg  <hans@chromium.org>
371
372         IndexedDB: Use LevelDB also for in-memory databases
373         https://bugs.webkit.org/show_bug.cgi?id=68903
374
375         Reviewed by Steve Block.
376
377         Remove the temporary dir that was necessary before LevelDB supported
378         in-memory databases.
379
380         * DumpRenderTree/chromium/TestShell.cpp:
381         (TestShell::TestShell):
382         * DumpRenderTree/chromium/TestShell.h:
383
384 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
385
386         Run TestWebKitAPI on Chromium buildbots
387         https://bugs.webkit.org/show_bug.cgi?id=68678
388
389         Reviewed by Tony Chang.
390
391         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
392
393 2011-09-28  Dimitri Glazkov  <dglazkov@chromium.org>
394
395         garden-o-matic results should anticipate 0 unexpected failures.
396         https://bugs.webkit.org/show_bug.cgi?id=69036
397
398         Also fixes controllers: UnexpectedFailures test.
399
400         Reviewed by Adam Barth.
401
402         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Tweaked.
403
404 2011-09-28  Dirk Pranke  <dpranke@chromium.org>
405
406         Modify new-run-webkit-tests to return the percentage difference in image diffs where possible.
407
408         https://bugs.webkit.org/show_bug.cgi?id=67253
409
410         Reviewed by Eric Seidel.
411
412         Nearly all of the work in this was done by Simon Fraser; I'm
413         just repackaging it and cleaning it up a bit. This change
414         modifies port.diff_image() to return a tuple of (pass/fail,
415         %age), adds the value to the FailureImageHashMismatch, and
416         writes the value into the full_results.json files to be
417         displayed in the results page.
418
419         * Scripts/webkitpy/layout_tests/controllers/manager.py:
420         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
421         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
422         * Scripts/webkitpy/layout_tests/models/test_failures.py:
423         * Scripts/webkitpy/layout_tests/port/base.py:
424         * Scripts/webkitpy/layout_tests/port/chromium.py:
425         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
426         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
427         * Scripts/webkitpy/layout_tests/port/test.py:
428         * Scripts/webkitpy/layout_tests/port/webkit.py:
429         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
430
431 2011-09-25  Kentaro Hara  <haraken@chromium.org>
432
433         Unreviewed. Adding myself to committers.py.
434
435         * Scripts/webkitpy/common/config/committers.py:
436
437 2011-09-28  Adam Barth  <abarth@webkit.org>
438
439         garden-o-matic shouldn't depend on test-results.appspot.com
440         https://bugs.webkit.org/show_bug.cgi?id=69019
441
442         Reviewed by Dimitri Glazkov.
443
444         This patch moves garden-o-matic from getting full_results.json from
445         test-results.appspot.com to getting that information directly from the
446         buildbot.  This patch improve the load time and accuracy of
447         garden-o-matic because test-results.appspot.com is slow and is dropping
448         a significant number of writes (see
449         https://bugs.webkit.org/show_bug.cgi?id=68748).
450
451         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
452         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
453         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
454
455 2011-09-28  David Levin  <levin@chromium.org>
456
457         watchlist: Add a way to load the watchlist from config.
458         https://bugs.webkit.org/show_bug.cgi?id=68991
459
460         Reviewed by Eric Seidel.
461
462         * Scripts/webkitpy/common/config/watchlist: Added.
463         * Scripts/webkitpy/common/watchlist/watchlistloader.py: Added.
464         Support for loading the watch list.
465         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Added.
466         Tests for the loading.
467         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
468         Adjusted to use the common base class.
469         * Scripts/webkitpy/common/webkitunittest.py: Added.
470         Made a common base class for functionality used in more than one.
471
472 2011-09-28  David Levin  <levin@chromium.org>
473
474         Attempt fix for Leopard python unit test run.
475
476         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
477
478 2011-09-27  Dimitri Glazkov  <dglazkov@chromium.org>
479
480         REGRESSION(r95573): Crash when loading SVG documents in a flattened frame or any SVG document in Chromium/Mac.
481         https://bugs.webkit.org/show_bug.cgi?id=68938
482
483         Made Chromium/Mac DRT better match how Chromium/Mac queries WebKit.
484
485         Reviewed by David Hyatt.
486
487         * DumpRenderTree/chromium/WebViewHost.cpp:
488         (WebViewHost::didUpdateLayout): Added width/height queries.
489         * DumpRenderTree/chromium/WebViewHost.h: Updated defs.
490
491 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
492
493         Get rebaseline server running again
494         https://bugs.webkit.org/show_bug.cgi?id=69020
495
496         Reviewed by Adam Barth.
497
498         Make rebaseline server run again after r90337 (missing format_date_time
499         import, results_json wasn't outputting anything).
500
501         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
502         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
503
504 2011-09-28  David Grogan  <dgrogan@chromium.org>
505
506         Move dgrogan from contributor to committer
507         https://bugs.webkit.org/show_bug.cgi?id=69021
508
509         * Scripts/webkitpy/common/config/committers.py:
510
511 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
512
513         Add Mac Skia GPU bots to builders.py
514         https://bugs.webkit.org/show_bug.cgi?id=69016
515
516         Reviewed by Eric Seidel.
517
518         This allows wwebkit-patch rebaseline-expectations to work with Mac Skia
519         GPU tests.
520
521         * Scripts/webkitpy/layout_tests/port/builders.py:
522         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
523
524 2011-09-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
525
526         Second try at fixing the GTK+ build.
527
528         * GNUmakefile.am:
529
530 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
531
532         Let TestWebKitAPI and webkit_unit_tests work for chromium-win
533         https://bugs.webkit.org/show_bug.cgi?id=68680
534
535         Reviewed by Tony Chang.
536
537         * Scripts/run-chromium-webkit-unit-tests:
538         * Scripts/webkitdirs.pm:
539         (determineBaseProductDir):
540
541 2011-09-28  Kaustubh Atrawalkar  <kaustubh@motorola.com>
542
543         [Gtk] Implement textInputController.doCommand
544         https://bugs.webkit.org/show_bug.cgi?id=66496
545
546         Reviewed by Martin Robinson.
547
548         * DumpRenderTree/gtk/TextInputController.cpp:
549         (doCommandCallback): Callback function for textInputController.doCommand
550
551 2011-09-28  David Levin  <levin@chromium.org>
552
553         watchlist: Suggest corrections for typos and improve error message consistency.
554         https://bugs.webkit.org/show_bug.cgi?id=68976
555
556         Reviewed by Adam Barth.
557
558         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add suggestions
559         for typos and improve consistency of the error messages.
560         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests
561         and improve the regex that were already present.
562
563 2011-09-28  David Levin  <levin@chromium.org>
564
565         watchlist: Add support for matching added or deleted lines.
566         https://bugs.webkit.org/show_bug.cgi?id=68972
567
568         Reviewed by Adam Barth.
569
570         * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Added.
571         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Added.
572         * Scripts/webkitpy/common/watchlist/watchlist.py: Comment fix up and fix input
573         to the pattern match to only have the diff lines instead of the DiffFile.
574         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
575         Add tests for the new patterns and combinations of the patterns.
576         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
577         Sort imports. Add changeline support.
578
579 2011-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
580
581         [GTK] Add WebKitError to GTK+ WebKit2 API
582         https://bugs.webkit.org/show_bug.cgi?id=68508
583
584         Reviewed by Martin Robinson.
585
586         * GNUmakefile.am: Add path to webkitgtk derived sources to the
587         include path.
588
589 2011-09-28  Philippe Normand  <pnormand@igalia.com>
590
591         [GTK] missing WebKit2 support in run-gtk-tests
592         https://bugs.webkit.org/show_bug.cgi?id=68992
593
594         Rubber-stamped by Andreas Kling.
595
596         * Scripts/run-gtk-tests: Get the WebKit2 tests to run from the
597         webkit2 directory.
598
599 2011-09-27  Philippe Normand  <pnormand@igalia.com>
600
601         [GTK] build-webkit --no-webkit2 still builds WebKit2
602         https://bugs.webkit.org/show_bug.cgi?id=68892
603
604         Reviewed by Martin Robinson.
605
606         Take the --no-webkit2 option in account when building WebKitGTK+.
607
608         * Scripts/build-webkit:
609         * Scripts/webkitdirs.pm:
610         (buildAutotoolsProject):
611         (buildGtkProject):
612
613 2011-09-28  Ryosuke Niwa  <rniwa@webkit.org>
614
615         Make Chromium Win Release (Tests) a core builder
616         https://bugs.webkit.org/show_bug.cgi?id=68906
617
618         Reviewed by Adam Barth.
619
620         Add Chromium Win Release (Tests) to the list of core builders.
621
622         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
623         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
624
625 2011-09-27  Adam Barth  <abarth@webkit.org>
626
627         garden-o-matic should load faster and inform the user what is happening
628         https://bugs.webkit.org/show_bug.cgi?id=68954
629
630         Reviewed by Dimitri Glazkov.
631
632         This test disables the expected failures tab.  The web inspector showed
633         that loading the data for this tab was slowing down the loading time
634         for the whole app.  We need to find a way to load that data lazily.
635
636         This patch also improves the update message to better describe the
637         progress the app is making analyzing data from the buildbot.
638
639         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
640         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
641         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
642
643 2011-09-27  Adam Barth  <abarth@webkit.org>
644
645         garden-o-matic should show the first result when examining results
646         https://bugs.webkit.org/show_bug.cgi?id=68960
647
648         Reviewed by Dimitri Glazkov.
649
650         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
651
652 2011-09-27  David Levin  <levin@chromium.org>
653
654         watchlist: Add support for cc and message rules.
655         https://bugs.webkit.org/show_bug.cgi?id=68950
656
657         Reviewed by Adam Barth.
658
659         * Scripts/webkitpy/common/watchlist/watchlist.py: Added support to get
660         the cc's and messages for a patch.
661         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Tests for the above.
662         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Parsing support
663         for the rules.
664         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
665         A generic encapsulation of either a message list or a cc list.
666         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
667
668 2011-09-27  Tom Zakrajsek  <tomz@codeaurora.org>
669
670         webkit-patch doesn't like UTF-8 characters in reviewers names
671         https://bugs.webkit.org/show_bug.cgi?id=63452
672
673         Reviewed by Eric Seidel.
674
675         * Scripts/webkit-patch:
676
677 2011-09-27  Adam Barth  <abarth@webkit.org>
678
679         garden-o-matic examine buttons shows both expected and unexpected failures
680         https://bugs.webkit.org/show_bug.cgi?id=68918
681
682         Reviewed by Dimitri Glazkov.
683
684         This was a copy/paste error when I refactored this classes to share
685         more code.
686
687         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
688
689 2011-09-27  Ryosuke Niwa  <rniwa@webkit.org>
690
691         Add Kaustubh Atrawalkar to the list of contributors.
692
693         * Scripts/webkitpy/common/config/committers.py:
694
695 2011-09-27  Mihai Parparita  <mihaip@chromium.org>
696
697         [Chromium] Fixed layout mode tests break subsequent tests
698         https://bugs.webkit.org/show_bug.cgi?id=68923
699         
700         Reviewed by Adam Barth.        
701
702         Reset fixed layout mode between tests, so that tests that run after
703         platform/chromium/fast/repaint/fixed-layout-360x240.html still have the
704         regular 800x600 non-fixed layout.
705
706         * DumpRenderTree/chromium/TestShell.cpp:
707         (TestShell::resetTestController):
708
709 2011-09-27  David Levin  <levin@chromium.org>
710
711         watchlist: Add the filename pattern for definitions.
712         https://bugs.webkit.org/show_bug.cgi?id=68917
713
714         Reviewed by Adam Barth.
715
716         * Scripts/webkitpy/common/watchlist/filenamepattern.py: Added.
717         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Added.
718         * Scripts/webkitpy/common/watchlist/watchlist.py: Added the filename pattern
719         for definitions.
720         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Added tests.
721         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Typo fix.
722
723 2011-09-27  Adam Barth  <abarth@webkit.org>
724
725         garden-o-matic results view should sort test and builder names
726         https://bugs.webkit.org/show_bug.cgi?id=68488
727
728         Reviewed by Andy Estes.
729
730         Previously, the test and builder names were displayed in an arbitrary
731         order that changed from time to time.  That confused one user study
732         participant.  This patch sorts the lists so that they occur in a
733         predictable order.
734
735         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
736
737 2011-09-27  Sheriff Bot  <webkit.review.bot@gmail.com>
738
739         Unreviewed, rolling out r96108, r96111, r96113, and r96116.
740         http://trac.webkit.org/changeset/96108
741         http://trac.webkit.org/changeset/96111
742         http://trac.webkit.org/changeset/96113
743         http://trac.webkit.org/changeset/96116
744         https://bugs.webkit.org/show_bug.cgi?id=68913
745
746         Wait for working Qt5 (Requested by ossy on #webkit).
747
748         * DumpRenderTree/qt/DumpRenderTree.pro:
749         * DumpRenderTree/qt/ImageDiff.pro:
750         * MiniBrowser/qt/BrowserView.cpp:
751         (BrowserView::BrowserView):
752         * MiniBrowser/qt/BrowserView.h:
753         * MiniBrowser/qt/BrowserWindow.cpp:
754         (BrowserWindow::BrowserWindow):
755         (BrowserWindow::urlChanged):
756         (BrowserWindow::~BrowserWindow):
757         * MiniBrowser/qt/BrowserWindow.h:
758         * MiniBrowser/qt/MiniBrowser.pro:
759         * MiniBrowser/qt/MiniBrowserApplication.h:
760         * MiniBrowser/qt/main.cpp:
761         * QtTestBrowser/QtTestBrowser.pro:
762         * QtTestBrowser/launcherwindow.cpp:
763         * QtTestBrowser/launcherwindow.h:
764         * QtTestBrowser/locationedit.h:
765         * QtTestBrowser/main.cpp:
766         * QtTestBrowser/mainwindow.cpp:
767         * QtTestBrowser/mainwindow.h:
768         * QtTestBrowser/webinspector.h:
769         * QtTestBrowser/webpage.cpp:
770         * QtTestBrowser/webview.cpp:
771         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
772         * WebKitTestRunner/PlatformWebView.h:
773         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
774         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
775         (WTR::WebView::wkView):
776         (WTR::WebView::pageRef):
777         (WTR::WebView::~WebView):
778         (WTR::WebView::WebView):
779         (WTR::PlatformWebView::PlatformWebView):
780         (WTR::PlatformWebView::sendEvent):
781         (WTR::PlatformWebView::postEvent):
782         * WebKitTestRunner/qt/WebKitTestRunner.pro:
783
784 2011-09-27  Carlos Garcia Campos  <cgarcia@igalia.com>
785
786         [GTK] Rename WebKit2 GTK+ API main header as webkit2.h
787         https://bugs.webkit.org/show_bug.cgi?id=65178
788
789         Reviewed by Martin Robinson.
790
791         * GNUmakefile.am:
792         * GtkLauncher/main.c: Include <webkit2/webkit2.h>.
793
794 2011-09-27  Csaba Osztrogonác  <ossy@webkit.org>
795
796         [Qt][WK2] Buildfix after r96108.
797
798         Rubber-stamped by Andreas Kling.
799
800         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
801         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
802         * WebKitTestRunner/qt/WebKitTestRunner.pro:
803
804 2011-09-27  David Levin  <levin@chromium.org>
805
806         watchlist: Change watchlistparser.py to be class based.
807         https://bugs.webkit.org/show_bug.cgi?id=68869
808
809         Reviewed by Eric Seidel.
810
811         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
812         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
813
814 2011-09-27  David Levin  <levin@chromium.org>
815
816         watchlist: Break out the diff boilerplate to allow for re-use.
817         https://bugs.webkit.org/show_bug.cgi?id=68871
818
819         Reviewed by Eric Seidel.
820
821         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
822         Break out the diff into a new file.
823         * Scripts/webkitpy/common/checkout/diff_test_data.py: Added.
824
825 2011-09-27  Ilya Tikhonovsky  <loislo@chromium.org>
826
827         Web Inspector: UI performance: introduce heap size tracking stats.
828         https://bugs.webkit.org/show_bug.cgi?id=68901
829
830         It is interesting how much the heap memory is used by Inspector in order of running the test.
831
832         Reviewed by Yury Semikhatsky.
833
834         * DumpRenderTree/chromium/TestShell.cpp:
835         (TestShell::showDevTools):
836         (TestShell::closeDevTools):
837
838 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
839
840         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
841
842         QWidget and friends now live in the QtWidgets library. We update
843         includes in implementation files and private headers to us the
844         non-module-prefixed path, and leave the lookup for the include
845         path. For public headers we have to ifdef the includes as the
846         user might now have the modules we need in his QT config.
847
848         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
849         have to update our code and use windowHandle() for setting the
850         parent relationships.
851
852         https://bugs.webkit.org/show_bug.cgi?id=68687
853
854         Reviewed by Andreas Kling.
855
856         * DumpRenderTree/qt/DumpRenderTree.pro:
857         * DumpRenderTree/qt/ImageDiff.pro:
858         * MiniBrowser/qt/BrowserView.cpp:
859         * MiniBrowser/qt/BrowserView.h:
860         * MiniBrowser/qt/BrowserWindow.cpp:
861         * MiniBrowser/qt/BrowserWindow.h:
862         * MiniBrowser/qt/MiniBrowser.pro:
863         * MiniBrowser/qt/MiniBrowserApplication.h:
864         * MiniBrowser/qt/main.cpp:
865         * QtTestBrowser/QtTestBrowser.pro:
866         * QtTestBrowser/launcherwindow.cpp:
867         * QtTestBrowser/launcherwindow.h:
868         * QtTestBrowser/locationedit.h:
869         * QtTestBrowser/main.cpp:
870         * QtTestBrowser/mainwindow.cpp:
871         * QtTestBrowser/mainwindow.h:
872         * QtTestBrowser/webinspector.h:
873         * QtTestBrowser/webpage.cpp:
874         * QtTestBrowser/webview.cpp:
875         * WebKitTestRunner/PlatformWebView.h:
876         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
877
878 2011-09-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
879
880         [Qt][WK2] Add support for hover API in Qt WebKit2
881         https://bugs.webkit.org/show_bug.cgi?id=68369
882
883         Reviewed by Andreas Kling.
884
885         Change the statusbar to show the link URL when hovering links in
886         MiniBrowser using QDesktopWebView.
887
888         * MiniBrowser/qt/BrowserWindow.cpp:
889         (BrowserWindow::BrowserWindow):
890         (BrowserWindow::onLinkHovered):
891         * MiniBrowser/qt/BrowserWindow.h:
892
893 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
894
895         garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
896         https://bugs.webkit.org/show_bug.cgi?id=68864
897
898         Reviewed by Adam Barth.
899
900         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
901         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
902         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
903         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
904
905 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
906
907         [Qt][WK2] One more unreviewed buildfix after r96005.
908
909         * WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.
910
911 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
912
913         [Qt][WK2] Unreviewed buildfix after r96005.
914
915         * WebKitTestRunner/qt/TestInvocationQt.cpp:
916         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
917
918 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
919
920         garden-o-matic should be pretty in Open Sans.
921         https://bugs.webkit.org/show_bug.cgi?id=68845
922
923         Reviewed by Adam Barth.
924
925         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked to bring back teh fonts.
926
927 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
928
929         garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
930         https://bugs.webkit.org/show_bug.cgi?id=68841
931
932         Reviewed by Adam Barth.
933
934         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
935         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
936         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.
937
938 2011-09-26  David Levin  <levin@chromium.org>
939
940         watchlist: Add parsing for definition section.
941         https://bugs.webkit.org/show_bug.cgi?id=68850
942
943         Reviewed by Adam Barth.
944
945         * Scripts/webkitpy/common/watchlist/watchlist.py:
946         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
947         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
948
949 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
950
951         Fix WebKitTestRunner builds for Cairo, Windows and Qt.
952
953         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
954         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
955         * WebKitTestRunner/win/TestInvocationWin.cpp:
956         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
957
958 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
959
960         Repaint tests don't work in WebKit2
961         https://bugs.webkit.org/show_bug.cgi?id=68453
962
963         Reviewed by Sam Weinig.
964         
965         Convert DumpRenderTree to use use the repaint rects
966         exposed via WebKit API when generating the repaint test
967         overlay.
968         
969         Fix WebKitTestRunner to work with repaint tests, again
970         using the repaint rects exposed from WK2.
971         
972         In both cases, layoutTestController.display() now just
973         forces a display of the web view, and turns on repaint
974         rect tracking on the main FrameView.
975         
976         Later, when pixel results are requested, the alpha overlay
977         that shows the repaint rects is generated using the list
978         of rects supplied by WebCore.
979
980         * DumpRenderTree/mac/DumpRenderTree.mm:
981         (resetDefaultsToConsistentValues):
982         (resetWebViewToConsistentStateBeforeTesting):
983         (displayWebView):
984         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
985         (paintRepaintRectOverlay):
986         (createBitmapContextFromWebView):
987         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
988         (WTR::InjectedBundle::beginTesting):
989         (WTR::InjectedBundle::done):
990         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
991         (WTR::InjectedBundle::setRepaintRects):
992         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
993         (WTR::InjectedBundlePage::reset):
994         (WTR::InjectedBundlePage::dump):
995         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
996         (WTR::LayoutTestController::display):
997         * WebKitTestRunner/TestInvocation.cpp:
998         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
999         * WebKitTestRunner/TestInvocation.h:
1000         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1001         (WTR::paintRepaintRectOverlay):
1002         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1003
1004 2011-09-26  Nayan Kumar K  <nayankk@motorola.com>
1005
1006         Get hover'ed element URL from HitTest.
1007
1008         mouseDidMoveOverElement now gets the hover'ed element link using
1009         WKHitTestResult API's.
1010         https://bugs.webkit.org/show_bug.cgi?id=68426 
1011
1012         Reviewed by Anders Carlsson.
1013
1014         * MiniBrowser/gtk/BrowserWindow.c:
1015         (mouseDidMoveOverElement):
1016
1017 2011-09-26  David Levin  <levin@chromium.org>
1018
1019         Add skeleton parsing for a WatchList.
1020         https://bugs.webkit.org/show_bug.cgi?id=68823
1021
1022         Reviewed by Adam Barth.
1023
1024         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Added.
1025         Parses the top level watch list sections -- none are defined yet -- and
1026         throws an exception if an invalid one is listed.
1027         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Added.
1028         Verify the exception for an invalid section in a watch list.
1029         * Scripts/webkitpy/common/watchlist/watchlist.py: Added.
1030
1031 2011-09-26  Adam Roben  <aroben@apple.com>
1032
1033         Clean up code imported from WebKitAPITest
1034
1035         Fixes <http://webkit.org/b/68799> WebViewDestruction tests and related code don't match
1036         TestWebKitAPI conventions
1037
1038         Reviewed by David Levin.
1039
1040         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Changed tests to use gtest macros
1041         and to share functionality via test fixtures. Prefixed Win32 API calls with ::. Updated
1042         namespace name.
1043
1044         (TestWebKitAPI::WebViewDestruction::SetUp):
1045         (TestWebKitAPI::WebViewDestruction::webViewCount):
1046         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
1047         (TestWebKitAPI::WebViewDestruction::runMessagePump):
1048         (TestWebKitAPI::WebViewDestruction::TearDown):
1049         (TestWebKitAPI::WebViewDestructionWithHostWindow::TearDown):
1050         Moved functionality from free functions into these new test fixtures.
1051
1052         * TestWebKitAPI/win/HostWindow.cpp:
1053         * TestWebKitAPI/win/HostWindow.h:
1054         Prefixed Win32 API calls with ::. Updated namespace name.
1055
1056 2011-09-23  Adam Roben  <aroben@apple.com>
1057
1058         Merge WebKitAPITest into TestWebKitAPI
1059
1060         This also means that our formerly-WebKitAPITest tests will be run on the bots!
1061
1062         I made the minimal changes necessary to get the tests to run in TestWebKitAPI. I'll make
1063         them more idiomatic in a separate pass.
1064
1065         Fixes <http://webkit.org/b/66560> WebKitAPITest and TestWebKitAPI have duplicate
1066         functionality (and names!)
1067
1068         Reviewed by Anders Carlsson.
1069
1070         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Renamed from Tools/WebKitAPITest/tests/WebViewDestruction.cpp.
1071         * TestWebKitAPI/win/HostWindow.cpp: Renamed from Tools/WebKitAPITest/HostWindow.cpp.
1072         * TestWebKitAPI/win/HostWindow.h: Renamed from Tools/WebKitAPITest/HostWindow.h.
1073
1074         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new files.
1075
1076         * TestWebKitAPI/win/main.cpp:
1077         (main): Added a call to ::OleInitialize to make WebKit1 work. This came from WebKitAPITest.
1078
1079         * WebKitAPITest: Removed this directory and its contents.
1080
1081 2011-09-23  Adam Roben  <aroben@apple.com>
1082
1083         Remove two failing WebKitAPITest tests
1084
1085         The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.
1086
1087         Reviewed by Anders Carlsson.
1088
1089         * WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and
1090         MainFrameAfterClose tests.
1091
1092 2011-09-25  Adam Barth  <abarth@webkit.org>
1093
1094         Finish removing PLATFORM(BREWMP) by removing associated code
1095         https://bugs.webkit.org/show_bug.cgi?id=68779
1096
1097         Reviewed by Sam Weinig.
1098
1099         * Scripts/webkitpy/common/config/build.py:
1100         * waf/build/settings.py:
1101
1102 2011-09-21  Ai Makabi  <makabi@google.com>
1103
1104         Provides a simple LRU cache class in Python.
1105
1106         https://bugs.webkit.org/show_bug.cgi?id=67823
1107
1108         Reviewed by Tony Chang.
1109
1110         * Scripts/webkitpy/common/lru_cache.py:
1111         * Scripts/webkitpy/common/lru_cache_unittest.py:
1112
1113 2011-09-25  Adam Barth  <abarth@webkit.org>
1114
1115         Remove PLATFORM(HAIKU) and associated code
1116         https://bugs.webkit.org/show_bug.cgi?id=68774
1117
1118         Reviewed by Sam Weinig.
1119
1120         * Scripts/webkitpy/common/config/build.py:
1121         * waf/build/settings.py:
1122
1123 2011-09-24  Adam Barth  <abarth@webkit.org>
1124
1125         Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
1126         https://bugs.webkit.org/show_bug.cgi?id=68767
1127
1128         Reviewed by Eric Seidel.
1129
1130         * Scripts/build-webkit:
1131
1132 2011-09-24  Adam Barth  <abarth@webkit.org>
1133
1134         Remove ENABLE(WCSS) and associated code
1135         https://bugs.webkit.org/show_bug.cgi?id=68759
1136
1137         Reviewed by Darin Adler.
1138
1139         * Scripts/build-webkit:
1140         * Scripts/old-run-webkit-tests:
1141         * Scripts/webkitperl/features.pm:
1142         (hasFeature):
1143         * Scripts/webkitpy/layout_tests/port/webkit.py:
1144         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1145
1146 2011-09-24  Alejandro G. Castro  <alex@igalia.com>
1147
1148         Fixed GTK compilation after r95878, the operator== was defined
1149         twice when USE_WEBPROCESS_EVENT_SIMULATION is defined.
1150
1151         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1152
1153 2011-09-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
1154
1155         [DRT] Include the right config file for EFL's DRT.
1156         https://bugs.webkit.org/show_bug.cgi?id=67042
1157
1158         Reviewed by Martin Robinson.
1159
1160         Ports which use CMake as their buildsystem (such as the EFL one) also
1161         have config.h files, but they are named differently, so include the
1162         right one depending on the buildsystem being used.
1163
1164         * DumpRenderTree/config.h:
1165
1166 2011-09-23  Adam Klein  <adamk@chromium.org>
1167
1168         Add ENABLE_MUTATION_OBSERVERS feature flag
1169         https://bugs.webkit.org/show_bug.cgi?id=68732
1170
1171         Reviewed by Ojan Vafai.
1172
1173         This flag will guard an implementation of the "Mutation Observers" proposed in
1174         http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html
1175
1176         * Scripts/build-webkit:
1177
1178 2011-09-23  Chang Shu  <cshu@webkit.org>
1179
1180         [WK2] [Qt] Implement MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
1181         https://bugs.webkit.org/show_bug.cgi?id=68556
1182
1183         Implement the MouseDown/MouseUp/MouseMoveTo functions on Qt platform.
1184
1185         Reviewed by Darin Adler.
1186
1187         * WebKitTestRunner/EventSenderProxy.h:
1188         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1189         * WebKitTestRunner/PlatformWebView.h:
1190         * WebKitTestRunner/mac/EventSenderProxy.mm:
1191         (WTR::EventSenderProxy::EventSenderProxy):
1192         (WTR::EventSenderProxy::leapForward):
1193         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1194         (WTR::EventSenderProxy::EventSenderProxy):
1195         (WTR::getMouseButton):
1196         (WTR::getModifiers):
1197         (WTR::EventSenderProxy::updateClickCountForButton):
1198         (WTR::EventSenderProxy::createGraphicsSceneMouseEvent):
1199         (WTR::EventSenderProxy::mouseDown):
1200         (WTR::EventSenderProxy::mouseUp):
1201         (WTR::EventSenderProxy::mouseMoveTo):
1202         (WTR::EventSenderProxy::leapForward):
1203         (WTR::EventSenderProxy::sendOrQueueEvent):
1204         (WTR::EventSenderProxy::replaySavedEvents):
1205         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1206         (WTR::PlatformWebView::postEvent):
1207         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1208
1209 2011-09-23  Lei Zhang  <thestig@chromium.org>
1210
1211         [chromium] Make the layout test script's kill timeout proportional to --time-out-ms
1212         https://bugs.webkit.org/show_bug.cgi?id=68026
1213
1214         Reviewed by Dirk Pranke.
1215
1216         * Scripts/webkitpy/layout_tests/port/chromium.py:
1217
1218 2011-09-23  Elliot Poger  <epoger@google.com>
1219
1220         update layout_tests to account for new default of use_skia=1
1221         https://bugs.webkit.org/show_bug.cgi?id=68698
1222
1223         Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
1224         from http://src.chromium.org/viewvc/chrome?view=rev&revision=102532
1225         (Chromium-on-Mac now uses the Skia graphics library instead of
1226         Core Graphics).
1227
1228         Also updates layout_test code to work with that change.
1229
1230         Reviewed by Mihai Parparita.
1231
1232         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1233         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1234
1235 2011-09-23  Mark Rowe  <mrowe@apple.com>
1236
1237         Fix the build.
1238         
1239         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Define operator<<(std::ostream&, const WTF::String&) inside
1240         the WTF namespace.
1241
1242 2011-09-22  Dirk Pranke  <dpranke@chromium.org>
1243
1244         enable NRWT for run-webkit-tests on Lion
1245         https://bugs.webkit.org/show_bug.cgi?id=68673
1246
1247         Reviewed by Eric Seidel.
1248
1249         * Scripts/run-webkit-tests:
1250         (useNewRunWebKitTests):
1251
1252 2011-09-22  Xianzhu Wang  <wangxianzhu@chromium.org>
1253
1254         Add unit test for existing StringBuilder
1255         https://bugs.webkit.org/show_bug.cgi?id=67080
1256
1257         Reviewed by Darin Adler.
1258
1259         * TestWebKitAPI/TestWebKitAPI.gypi:
1260         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1261         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Added.
1262         (operator<<):
1263         (TestWebKitAPI::expectBuilderContent):
1264         (TestWebKitAPI::expectEmpty):
1265         (TestWebKitAPI::TEST):
1266
1267 2011-09-22  Raphael Kubo da Costa  <kubo@profusion.mobi>
1268
1269         [EFL] Use ewk_view to navigate in history instead of ewk_history.
1270         https://bugs.webkit.org/show_bug.cgi?id=68455
1271
1272         Reviewed by Antonio Gomes.
1273
1274         BackForwardItem::invoke() was using ewk_history functions to navigate
1275         in history; however, this will only call WebCore::BackForwardListImpl
1276         and not move between pages at all. We now call ewk_view_navigate and
1277         its siblings to make sure the navigation actually happens.
1278
1279         This should make tests like fast/dom/navigation-type-back-forward.html
1280         stop timing out.
1281
1282         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
1283         (BackForwardItem::invoke):
1284
1285 2011-09-22  Dean Jackson  <dino@apple.com>
1286
1287         Add ENABLE_CSS_FILTERS
1288         https://bugs.webkit.org/show_bug.cgi?id=68652
1289
1290         Reviewed by Simon Fraser.
1291
1292         * Scripts/build-webkit:
1293
1294 2011-09-22  Anders Carlsson  <andersca@apple.com>
1295
1296         EventSenderProxy::mouseUp should call -[WKView mouseUp:] instead of -[WKView mouseDown:]
1297         https://bugs.webkit.org/show_bug.cgi?id=68660
1298
1299         Reviewed by Adam Barth.
1300
1301         * WebKitTestRunner/mac/EventSenderProxy.mm:
1302         (WTR::EventSenderProxy::mouseUp):
1303
1304 2011-09-22  Adam Roben  <aroben@apple.com>
1305
1306         Remove FindSafari
1307
1308         It isn't used or built anymore.
1309
1310         Fixes <http://webkit.org/b/68628>
1311
1312         Reviewed by Darin Adler.
1313
1314         * FindSafari: Removed this directory and its contents.
1315
1316 2011-09-22  Adam Roben  <aroben@apple.com>
1317
1318         Remove FindSafari from all our .sln files
1319
1320         It isn't used anymore, so there's no point in building it.
1321
1322         Part of <http://webkit.org/b/68628> Remove FindSafari
1323
1324         Reviewed by Steve Falkenburg.
1325
1326         * DumpRenderTree/DumpRenderTree.sln:
1327         * WebKitTestRunner/WebKitTestRunner.sln:
1328
1329 2011-09-22  Adam Roben  <aroben@apple.com>
1330
1331         Remove all uses of FindSafari
1332
1333         It isn't really needed anymore.
1334
1335         Fixes <http://webkit.org/b/68626>.
1336
1337         Reviewed by Darin Adler.
1338
1339         * Scripts/old-run-webkit-tests: Moved read/writeRegistryString from here to webkitdirs.pm.
1340
1341         * Scripts/run-webkit-nightly.cmd: Removed. This used to be used to launch nightly builds of
1342         WebKit, but now we use WebKit.exe for that.
1343
1344         * Scripts/webkitdirs.pm:
1345         (installedSafariPath): Changed to use readRegistryString instead of invoking FindSafari to
1346         do the same thing.
1347
1348         (readRegistryString):
1349         (writeRegistryString):
1350         Moved here from old-run-webkit-tests.
1351
1352 2011-09-22  Adam Roben  <aroben@apple.com>
1353
1354         Use the "direct object" form of system() to run WebKit.exe
1355
1356         This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
1357         path to WebKit.exe.
1358
1359         Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
1360         %WEBKITOUTPUTDIR%
1361
1362         Reviewed by Steve Falkenburg.
1363
1364         * Scripts/webkitdirs.pm:
1365         (runSafari):
1366
1367 2011-09-22  Adam Roben  <aroben@apple.com>
1368
1369         Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath
1370
1371         Fixes <http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
1372         spaces in the path to the WebKit source tree
1373
1374         Reviewed by John Sullivan.
1375
1376         * Scripts/webkitdirs.pm:
1377         (setupCygwinEnv):
1378
1379 2011-09-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1380
1381         [Qt] Use same DPI for application font as rest of app in DRT and WTR
1382
1383         QApplication will initialize the default application font based
1384         on the application DPI at construction time, but we then override
1385         the application DPI using QX11Info (hard-coding it to 96 for
1386         consistency). This hard-coding is not reflected in the application
1387         font, so we explicitly have update the font ourselves.
1388
1389         The 6 test results that are updated were originally produced with
1390         a DPI of 75, as this is the default fallback DPI when a QFont is
1391         constructed before QApplication. This was wrong, and the results
1392         are updated to match a DPI of 96.
1393
1394         Reviewed by Csaba Osztrogonác.
1395
1396         * DumpRenderTree/qt/main.cpp:
1397         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1398
1399 2011-09-21  Anna Cavender  <annacc@chromium.org>
1400
1401         Update committers.py with a new contributor contact        
1402         https://bugs.webkit.org/show_bug.cgi?id=68565
1403
1404         Reviewed by Eric Carlson.
1405
1406         * Scripts/webkitpy/common/config/committers.py:
1407
1408 2011-09-21  Chang Shu  <cshu@webkit.org>
1409
1410         [WK2] [Mac] Implement a more-complete MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
1411         https://bugs.webkit.org/show_bug.cgi?id=68108
1412
1413         This patch implements the event sender mouse events through WebKit2 UIProcess which is
1414         closer to the real simulation than a WebProcess-only approach. The patch only supports Mac
1415         platform as the first step so the existing code is still kept for other platforms.
1416
1417         Reviewed by Darin Adler.
1418
1419         * WebKitTestRunner/EventSenderProxy.h:
1420         (WTR::EventSenderProxy::EventSenderProxy):
1421         (WTR::EventSenderProxy::leapForward):
1422         (WTR::EventSenderProxy::currentEventTime):
1423         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1424         (WTR::EventSendingController::EventSendingController):
1425         (WTR::EventSendingController::mouseDown):
1426         (WTR::EventSendingController::mouseUp):
1427         (WTR::EventSendingController::mouseMoveTo):
1428         (WTR::EventSendingController::leapForward):
1429         (WTR::EventSendingController::keyDown):
1430         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1431         * WebKitTestRunner/TestController.cpp:
1432         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1433         * WebKitTestRunner/mac/EventSenderProxy.mm:
1434         (WTR::eventTypeForMouseButtonAndAction):
1435         (WTR::operator==):
1436         (WTR::EventSenderProxy::updateClickCountForButton):
1437         (WTR::EventSenderProxy::mouseDown):
1438         (WTR::EventSenderProxy::mouseUp):
1439         (WTR::EventSenderProxy::mouseMoveTo):
1440         (WTR::EventSenderProxy::keyDown):
1441         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1442         (WTR::EventSenderProxy::keyDown):
1443         (WTR::EventSenderProxy::mouseDown):
1444         (WTR::EventSenderProxy::mouseUp):
1445         (WTR::EventSenderProxy::mouseMoveTo):
1446
1447 2011-09-21  Dan Bernstein  <mitz@apple.com>
1448
1449         Tools part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
1450         https://bugs.webkit.org/show_bug.cgi?id=68451
1451
1452         Reviewed by Darin Adler.
1453
1454         * Scripts/check-for-inappropriate-objc-class-names: Added. Checks for
1455         Objective-C classes with names not having one of a list of prefixes
1456         passed on the command line.
1457
1458 2011-09-21  Xianzhu Wang  <wangxianzhu@chromium.org>
1459
1460         Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
1461         https://bugs.webkit.org/show_bug.cgi?id=68206
1462
1463         Reviewed by Tony Chang.
1464
1465         * Scripts/webkitdirs.pm:
1466         (determineBaseProductDir): add support for chromium-mac
1467         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1468         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1469
1470 2011-09-21  Adam Barth  <abarth@webkit.org>
1471
1472         garden-o-matic command should explain that it is starting a local server
1473         https://bugs.webkit.org/show_bug.cgi?id=68486
1474
1475         Reviewed by Dimitri Glazkov.
1476
1477         In the user study, both participants didn't understand why the
1478         garden-o-matic command appeared to hang.  This patch adds an
1479         explaination of what's going on.  It also adds a confirmation prompt
1480         before launching the browser to give the user a chance to read the
1481         text.  If that's too much of a speed bump, we can iterate.
1482
1483         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1484
1485 2011-09-21  Chang Shu  <cshu@webkit.org>
1486
1487         [Qt] Implement KeyDown function for WebKit2 EventSender.
1488         https://bugs.webkit.org/show_bug.cgi?id=56485
1489
1490         Implement the KeyDown function on Qt platform.
1491
1492         Reviewed by Andreas Kling.
1493
1494         * WebKitTestRunner/PlatformWebView.h:
1495         * WebKitTestRunner/TestController.cpp:
1496         (WTR::TestController::TestController):
1497         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1498         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Added.
1499         (WTR::getModifiers):
1500         (WTR::EventSenderProxy::keyDown):
1501         (buildModifierFlags):
1502         (EventSenderProxy::keyDown):
1503         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1504         (WTR::PlatformWebView::sendEvent):
1505         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1506
1507 2011-09-20  Adam Barth  <abarth@webkit.org>
1508
1509         garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
1510         https://bugs.webkit.org/show_bug.cgi?id=68496
1511
1512         Reviewed by Dimitri Glazkov.
1513
1514         This patch adds a bunch of sorting to make sure things happen in a
1515         predictable order in both JavaScriptCore and V8.  We've talked before
1516         about whether these two JavaScript engines should enumerate
1517         dictionaries in the same order, but the consensus has been that they
1518         shouldn't.  Personally, I disagree with that consensus, but such is life.
1519
1520         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1521         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1522         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1523         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1524
1525 2011-09-20  Adam Barth  <abarth@webkit.org>
1526
1527         garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
1528         https://bugs.webkit.org/show_bug.cgi?id=68495
1529
1530         Reviewed by Dimitri Glazkov.
1531
1532         This patch adds an implementation of Function.prototype.bind if the browser lacks one.
1533
1534         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1535
1536 2011-09-20  Eric Seidel  <eric@webkit.org>
1537
1538         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
1539         https://bugs.webkit.org/show_bug.cgi?id=65781
1540
1541         Reviewed by Ryosuke Niwa.
1542
1543         Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
1544         to resolve the passed in url relative to the absolute url for the test.
1545         For http tests, since the test url is an http url, we can't resolve relative
1546         to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
1547         for resolving.
1548
1549         I believe this is a better approach than the on used in the Qt and Chromium DRT's
1550         (which resolves the path relative to the built location of the DRT executable)
1551         and we should move this new code into a shared location in a follow-up patch.
1552
1553         It turns out that there was a second use for pathToLocalResource, used by one
1554         test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
1555         To support this test I made the new pathToLocalResource smart enough to map
1556         /tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).
1557
1558         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1559         (LayoutTestController::pathToLocalResource):
1560         * Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.
1561
1562 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
1563
1564         Need to specify a django version, instead of using default
1565         https://bugs.webkit.org/show_bug.cgi?id=68398
1566
1567         Reviewed by Eric Seidel.
1568
1569         * QueueStatusServer/__init__.py:
1570         * QueueStatusServer/main.py:
1571
1572 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
1573
1574         Update committers.py with a few more contributor contacts
1575         https://bugs.webkit.org/show_bug.cgi?id=68487
1576
1577         Reviewed by Eric Seidel.
1578
1579         * Scripts/webkitpy/common/config/committers.py:
1580
1581 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
1582
1583         Fix webkitpy unit tests after 95547 and 95549
1584         https://bugs.webkit.org/show_bug.cgi?id=68483
1585
1586         Reviewed by Adam Barth.
1587         
1588         Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().
1589
1590         * Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing
1591         parse_entries_from_file(), use StringIO and entry.reviewer_text().
1592         While testing parse_latest_entry_from_file(), expect the correct
1593         touched_files() list.
1594
1595 2011-09-20  Adam Barth  <abarth@webkit.org>
1596
1597         garden-o-matic makes it hard to compare images when scroll bars appear
1598         https://bugs.webkit.org/show_bug.cgi?id=68482
1599
1600         Reviewed by Eric Seidel.
1601
1602         Because we autoscale image width, the images rescale if we overflow
1603         vertically and get a scrollbar.  That makes it hard to compare two sets
1604         of images.  This patch reserves space for the scrollbar so we won't
1605         have the layout change.
1606
1607         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
1608
1609 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1610
1611         Unreviewed, rolling out r95565.
1612         http://trac.webkit.org/changeset/95565
1613         https://bugs.webkit.org/show_bug.cgi?id=68470
1614
1615         Broke builds (Requested by andersca on #webkit).
1616
1617         * MiniBrowser/gtk/BrowserWindow.c:
1618         (mouseDidMoveOverElement):
1619
1620 2011-09-20  Nayan Kumar K  <nayankk@motorola.com>
1621
1622         Get hover'ed element URL from HitTest.
1623         
1624         mouseDidMoveOverElement now gets the hover'ed element link using
1625         WKHitTestResult API's.
1626         https://bugs.webkit.org/show_bug.cgi?id=68426
1627
1628         Reviewed by Anders Carlsson.
1629
1630         * MiniBrowser/gtk/BrowserWindow.c:
1631         (mouseDidMoveOverElement):
1632
1633 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
1634
1635         Changelog class should have a method to return all entries
1636         https://bugs.webkit.org/show_bug.cgi?id=68399
1637         
1638         Implement ChangeLog.parse_entries_from_file(). This method returns a generator
1639         of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
1640
1641         Reviewed by Ryosuke Niwa.
1642
1643         * Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
1644         and adapt it to become a generator.
1645         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
1646
1647 2011-09-20  Jarred Nicholls  <jarred@sencha.com>
1648
1649         [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
1650         https://bugs.webkit.org/show_bug.cgi?id=51159
1651
1652         Permit any URL with a local scheme to set a user style sheet. Allow qrc
1653         resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
1654         
1655         Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.
1656
1657         Reviewed by Kenneth Rohde Christiansen.
1658
1659         * DumpRenderTree/qt/DumpRenderTree.pro:
1660         * DumpRenderTree/qt/DumpRenderTree.qrc: Added.
1661         * DumpRenderTree/qt/resources/user.css: Added.
1662         (body):
1663         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1664         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
1665         * WebKitTestRunner/qt/resources/user.css: Added.
1666         (body):
1667
1668 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
1669
1670         ChangeLogEntry class should contain a list of touched files
1671         https://bugs.webkit.org/show_bug.cgi?id=68115
1672
1673         Reviewed by Eric Seidel.
1674         
1675         Add method to return the list of files touched in a ChangeLog entry.
1676
1677         * Scripts/webkitpy/common/checkout/changelog.py: Add
1678         touched_files_regexp and touched_files() method.
1679         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement
1680         unit tests for touched_files() method.
1681
1682 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1683
1684         Unreviewed, rolling out r95526 and r95541.
1685         http://trac.webkit.org/changeset/95526
1686         http://trac.webkit.org/changeset/95541
1687         https://bugs.webkit.org/show_bug.cgi?id=68443
1688
1689         It broke 6 tests (Requested by ossy_ on #webkit).
1690
1691         * DumpRenderTree/qt/main.cpp:
1692         (main):
1693         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1694         (WTR::activateFonts):
1695
1696 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
1697
1698         Fix patch and bug numbering in the mocktool simulation code
1699         https://bugs.webkit.org/show_bug.cgi?id=68374
1700
1701         Reviewed by Adam Barth.
1702
1703         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1704         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1705         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1706         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1707         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1708         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1709         * Scripts/webkitpy/tool/commands/download_unittest.py:
1710         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1711         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1712         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1713         * Scripts/webkitpy/tool/commands/queuestest.py:
1714         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1715         * Scripts/webkitpy/tool/mocktool.py:
1716         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1717         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1718
1719 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1720
1721         [Qt] Don't override default QApplication font for DRT and WTR
1722
1723         Revision 95526 moved the relevant code below the QApplication
1724         constructor, to fix a potential crash, and that made the code
1725         take effect, breaking 6 tests.
1726
1727         We should rely on the QWebSettings to set default fonts, and
1728         this QApplication::setFont() is a relic from when we didn't
1729         have that option, so we remove the code.
1730
1731         Reviewed by Csaba Osztrogonác.
1732
1733         * DumpRenderTree/qt/main.cpp:
1734         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1735
1736 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1737
1738         WebKitTestRunner: Provide usage if run without arguments
1739
1740         If WTR is run without either one or more filenames, or
1741         a '-' to indicate server mode, we don't need to start
1742         up the test machinery. Doing so might actually crash,
1743         as we'll exit the application immedeatly after anyways.
1744
1745         Reviewed by Simon Hausmann.
1746
1747         * WebKitTestRunner/TestController.cpp:
1748         (WTR::TestController::initialize):
1749
1750 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1751
1752         [Qt] Don't use QFont before initializing QApplication
1753
1754         Could potentially result in crash.
1755
1756         Reviewed by Simon Hausmann.
1757
1758         * DumpRenderTree/qt/main.cpp:
1759         (main):
1760
1761 2011-09-19  Adam Barth  <abarth@webkit.org>
1762
1763         Always enable ENABLE(EVENTSOURCE)
1764         https://bugs.webkit.org/show_bug.cgi?id=68414
1765
1766         Reviewed by Eric Seidel.
1767
1768         * Scripts/build-webkit:
1769
1770 2011-09-19  David Levin  <levin@chromium.org>
1771
1772         Sheriffbot rollout should be more intuitive.
1773         https://bugs.webkit.org/show_bug.cgi?id=68415
1774
1775         Reviewed by Adam Barth.
1776
1777         * Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
1778         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args
1779           and a few others cases.
1780         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
1781
1782 2011-09-19  David Levin  <levin@chromium.org>
1783
1784         check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
1785         https://bugs.webkit.org/show_bug.cgi?id=68391
1786
1787         Reviewed by Darin Adler.
1788
1789         * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
1790         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
1791
1792 2011-09-19  Alexis Menard  <alexis.menard@openbossa.org>
1793
1794         Style checker should not check public Qt WK2 API for parameter_name.
1795         https://bugs.webkit.org/show_bug.cgi?id=68359
1796
1797         Reviewed by Andreas Kling.
1798
1799         The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
1800         Add an exception in the style checker to disable the check. Also added the test for it.
1801
1802         * Scripts/webkitpy/style/checker.py:
1803         * Scripts/webkitpy/style/checker_unittest.py:
1804
1805 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
1806
1807         GTK DRT leaks memory while comparing history items
1808         https://bugs.webkit.org/show_bug.cgi?id=68086
1809
1810         Reviewed by Martin Robinson.
1811         
1812         webkit_web_history_item_get_target() returns a g_strdup()'d string,
1813         so memory must be freed before compareHistoryItems() returns.
1814
1815         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1816         (compareHistoryItems): Use GOwnPtr to manage memory automatically.
1817
1818 2011-09-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1819
1820         Buildbot marks a nrwt bot red when tests are missing results
1821         https://bugs.webkit.org/show_bug.cgi?id=64812
1822
1823         Reviewed by Ryosuke Niwa.
1824
1825         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1826         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1827
1828 2011-09-19  Jessie Berlin  <jberlin@apple.com>
1829
1830         Sites that use history pushState or replaceState are recorded in history in Private Browsing
1831         mode.
1832         https://bugs.webkit.org/show_bug.cgi?id=68208
1833
1834         Reviewed by Brady Eidson.
1835
1836         Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
1837         updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.
1838
1839         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.
1840         (TestWebKitAPI::didNavigateWithNavigationData):
1841         This is a context history client callback, so it should not be called when in Private
1842         Browsing. Add a call to FAIL().
1843         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1844         This is a page load client callback that happens after the didNavigateWithNavigationData
1845         callback. End the test.
1846         (TestWebKitAPI::TEST):
1847         Enable Private Browsing and load a page that uses history.pushState.
1848
1849         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1850         Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.
1851         * TestWebKitAPI/Tests/WebKit2/push-state.html: Added.
1852         Ditto.
1853         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1854         Ditto.
1855         * TestWebKitAPI/win/copy-resources.cmd:
1856         Ditto.
1857
1858 2011-09-16  Elliot Poger  <epoger@google.com>
1859
1860         add non-CG Webkit-Mac builds to flakiness dashboard
1861         https://bugs.webkit.org/show_bug.cgi?id=68265
1862
1863         Reviewed by Adam Barth.
1864
1865         As Chromium-on-Mac approaches the switchover from Core Graphics to
1866         Skia, we need to add the Skia version to the flakiness dashboard.
1867
1868         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1869         * TestResultServer/static-dashboards/builders.js:
1870         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1871
1872 2011-09-16  Jochen Eisinger  <jochen@chromium.org>
1873
1874         Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
1875         https://bugs.webkit.org/show_bug.cgi?id=68071
1876
1877         Reviewed by Adam Barth.
1878
1879         * DumpRenderTree/chromium/WebPermissions.cpp:
1880         (WebPermissions::allowImage):
1881         * DumpRenderTree/chromium/WebPermissions.h:
1882
1883 2011-09-16  Tom Zakrajsek  <tomz@codeaurora.org>
1884
1885         update-webkit-chromium should retry the gclient call if it fails once
1886         https://bugs.webkit.org/show_bug.cgi?id=68252
1887
1888         Reviewed by Adam Barth.
1889
1890         * Scripts/update-webkit-chromium:
1891
1892 2011-09-16  Rob Buis  <rbuis@rim.com>
1893
1894         Add Eli's rim address and change the nick.
1895
1896         * Scripts/webkitpy/common/config/committers.py:
1897
1898 2011-09-16  Anders Carlsson  <andersca@apple.com>
1899
1900         Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
1901         https://bugs.webkit.org/show_bug.cgi?id=68269
1902
1903         Reviewed by Geoffrey Garen.
1904
1905         Update client function signatures.
1906
1907         * MiniBrowser/gtk/BrowserWindow.c:
1908         (browserWindowUIClientInit):
1909         * MiniBrowser/mac/BrowserWindowController.m:
1910         (mouseDidMoveOverElement):
1911         (-[BrowserWindowController awakeFromNib]):
1912         * MiniBrowser/win/BrowserView.cpp:
1913         (BrowserView::create):
1914         * WebKitTestRunner/TestController.cpp:
1915         (WTR::TestController::createOtherPage):
1916         (WTR::TestController::initialize):
1917
1918 2011-09-16  Anders Carlsson  <andersca@apple.com>
1919
1920         Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
1921         https://bugs.webkit.org/show_bug.cgi?id=68266
1922
1923         Reviewed by John Sullivan.
1924
1925         * MiniBrowser/mac/BrowserWindowController.m:
1926         (mouseDidMoveOverElement):
1927
1928 2011-09-16  Vincent Scheib  <scheib@chromium.org>
1929
1930         Add Vincent Scheib to the committers list.
1931
1932         * Scripts/webkitpy/common/config/committers.py:
1933
1934 2011-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1935
1936         Unreviewed, rolling out r95285.
1937         http://trac.webkit.org/changeset/95285
1938         https://bugs.webkit.org/show_bug.cgi?id=68247
1939
1940         It broke a webkitpy test (Requested by ossy on #webkit).
1941
1942         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1943
1944 2011-09-16  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1945
1946         Buildbot marks a nrwt bot red when tests are missing results
1947         https://bugs.webkit.org/show_bug.cgi?id=64812
1948
1949         Reviewed by Dirk Pranke.
1950
1951         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1952
1953 2011-09-16  Martin Robinson  <mrobinson@igalia.com>
1954
1955         [GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
1956         https://bugs.webkit.org/show_bug.cgi?id=68178
1957
1958         Reviewed by Xan Lopez.
1959
1960         Add a work-around to enable WebKit2 when using build-webkit.
1961
1962         * Scripts/webkitdirs.pm:
1963         (buildAutotoolsProject): 
1964
1965 2011-09-15  James Robinson  <jamesr@chromium.org>
1966
1967         Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.
1968
1969         * Scripts/webkitpy/common/config/committers.py:
1970
1971 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
1972
1973         UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
1974         https://bugs.webkit.org/show_bug.cgi?id=68003
1975
1976         Reviewed by Adam Barth.
1977
1978         * Scripts/webkitpy/tool/mocktool.py:
1979         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1980         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1981
1982 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
1983
1984         Python version check is confusing in test-webkitpy
1985         https://bugs.webkit.org/show_bug.cgi?id=68004
1986
1987         Reviewed by Adam Barth.
1988
1989         * Scripts/test-webkitpy:
1990
1991 2011-09-15  Eric Seidel  <eric@webkit.org>
1992
1993         Reviewed by Adam Barth.
1994
1995         webkit-patch should be able to find users and add them to bugzilla groups
1996         https://bugs.webkit.org/show_bug.cgi?id=63351
1997
1998         These are both very basic commands.  But it's now possible to find
1999         all users matching a regexp, as well as add all users matching a regexp
2000         to a set of groups.
2001
2002         bugzilla.py already knew how to find users (for validate-committer-lists)
2003         but now it has the ability to modify the user records.
2004
2005         I split some of the logic out into a new EditUsersParser class
2006         to try and reduce the amount of code in Bugzilla/BugzillaQueries.
2007
2008         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2009         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2010         * Scripts/webkitpy/tool/commands/__init__.py:
2011         * Scripts/webkitpy/tool/commands/adduserstogroups.py: Added.
2012         * Scripts/webkitpy/tool/commands/findusers.py: Added.
2013
2014 2011-09-15  Eric Seidel  <eric@webkit.org>
2015
2016         Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
2017         https://bugs.webkit.org/show_bug.cgi?id=68182
2018
2019         Reviewed by Adam Barth.
2020
2021         * Scripts/build-webkit:
2022         * waf/build/settings.py:
2023
2024 2011-09-15  Eric Seidel  <eric@webkit.org>
2025
2026         Unreviewed.  Make contributor email look-up case-insensitive.
2027
2028         validate-committer-list was incorrectly reporting that "chang.shu@nokia.com"
2029         was missing from committers.py due to case sensitivity.
2030
2031         This also includes a test expectations update to committers_unittest.py
2032         after my previous change.
2033
2034         * Scripts/webkitpy/common/config/committers.py:
2035         * Scripts/webkitpy/common/config/committers_unittest.py:
2036         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2037
2038 2011-09-15  Eric Seidel  <eric@webkit.org>
2039
2040         Unreviewed.  Updated this based on webkit-patch suggest-nominations and validate-committer-list output.
2041
2042         Add a bunch of email aliases to committers.py for regular contributors
2043         who are committing using other email addresses than they have listed in the file.
2044
2045         * Scripts/webkitpy/common/config/committers.py:
2046
2047 2011-09-15  Eric Seidel  <eric@webkit.org>
2048
2049         Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
2050         https://bugs.webkit.org/show_bug.cgi?id=68022
2051
2052         Reviewed by Ryosuke Niwa.
2053
2054         * Scripts/build-webkit:
2055         * waf/build/settings.py:
2056
2057 2011-09-15  Anders Carlsson  <andersca@apple.com>
2058
2059         Fix Mac build by including config.h where needed.
2060
2061         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
2062         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2063         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2064         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2065         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
2066         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
2067         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2068         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2069         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
2070         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
2071         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
2072         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2073         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2074         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
2075         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2076         * TestWebKitAPI/mac/main.mm:
2077
2078 2011-09-15  Xianzhu Wang  <wangxianzhu@chromium.org>
2079
2080         Let TestWebKitAPI work for chromium
2081         https://bugs.webkit.org/show_bug.cgi?id=67756
2082
2083         Reviewed by Sam Weinig.
2084
2085         * Scripts/build-api-tests:
2086         * Scripts/run-api-tests:
2087         (isSupportedPlatform):
2088         (runTest):
2089         (populateTests):
2090         * Scripts/webkitdirs.pm:
2091         (determineBaseProductDir):
2092         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2093         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2094         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2095         * TestWebKitAPI/InjectedBundleController.cpp:
2096         * TestWebKitAPI/InjectedBundleMain.cpp:
2097         * TestWebKitAPI/JavaScriptTest.cpp:
2098         * TestWebKitAPI/PlatformUtilities.cpp:
2099         * TestWebKitAPI/TestWebKitAPI.gypi: Added.
2100         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2101         * TestWebKitAPI/TestWebKitAPIPrefix.h: Removed.
2102         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2103         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2104         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2105         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
2106         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2107         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2108         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
2109         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2110         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2111         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2112         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2113         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2114         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2115         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2116         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2117         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2118         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2119         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2120         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2121         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2122         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
2123         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
2124         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
2125         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2126         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
2127         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2128         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2129         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2130         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2131         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
2132         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2133         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2134         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2135         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2136         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2137         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
2138         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2139         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
2140         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
2141         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
2142         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
2143         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
2144         * TestWebKitAPI/TestsController.cpp:
2145         * TestWebKitAPI/config.h: Copied from TestWebKitAPI/TestWebKitAPIPrefix.h.
2146         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp:
2147         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2148         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2149         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2150         * TestWebKitAPI/win/main.cpp:
2151
2152 2011-09-15  Jochen Eisinger  <jochen@chromium.org>
2153
2154         [chromium] extract normalization of LayoutTests URLs to a method of TestShell
2155         https://bugs.webkit.org/show_bug.cgi?id=68145
2156
2157         This will allow for other classes in DumpRenderTree to reuse this functionality
2158
2159         Reviewed by David Levin.
2160
2161         * DumpRenderTree/chromium/TestShell.cpp:
2162         (normalizeLayoutTestURLInternal):
2163         (dumpHistoryItem):
2164         (TestShell::normalizeLayoutTestURL):
2165         * DumpRenderTree/chromium/TestShell.h:
2166
2167 2011-09-14  Ada Chan  <adachan@apple.com>
2168
2169         Add test for WKBundleFrameCopyWebArchive().
2170         https://bugs.webkit.org/show_bug.cgi?id=67857
2171
2172         Reviewed by Anders Carlsson.
2173
2174         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
2175         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
2176         the returned data is a valid webarchive.
2177         (TestWebKitAPI::setInjectedBundleClient):
2178         (TestWebKitAPI::didFinishLoadForFrame):
2179         (TestWebKitAPI::TEST): Load simple.html in a WebView.  Wait for it to finish loading, and then ask the
2180         injected bundle for the webarchive and check the returned webarchive.
2181         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
2182         (TestWebKitAPI::WebArchiveTest::WebArchiveTest):
2183         (TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
2184         the web archive.
2185
2186         Add files to project.
2187         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
2188         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2189         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2190
2191 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
2192
2193         committers.py should support multiple IRC nicknames
2194         https://bugs.webkit.org/show_bug.cgi?id=68110
2195
2196         Reviewed by Eric Seidel.
2197
2198         Add multiple IRC nickname support to committers.py
2199
2200         * Scripts/webkitpy/common/config/committers.py:
2201         * Scripts/webkitpy/common/config/committers_unittest.py:
2202         * Scripts/webkitpy/tool/bot/irc_command.py:
2203         * Scripts/webkitpy/tool/bot/sheriff.py:
2204
2205 2011-09-14  Jon Lee  <jonlee@apple.com>
2206
2207         Implement globalFlag for WebKitTestRunner
2208         https://bugs.webkit.org/show_bug.cgi?id=68033
2209         <rdar://problem/10119204>
2210
2211         Reviewed by Sam Weinig.
2212
2213         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
2214         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2215         (WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
2216         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
2217         (WTR::LayoutTestController::globalFlag): simple getter
2218         (WTR::LayoutTestController::setGlobalFlag): simple setter
2219
2220 2011-09-13  Eric Seidel  <eric@webkit.org>
2221
2222         Remove ENABLE_SVG_USE as <use> is required by HTML5
2223         https://bugs.webkit.org/show_bug.cgi?id=68019
2224
2225         Reviewed by Ryosuke Niwa.
2226
2227         * Scripts/build-webkit:
2228         * waf/build/settings.py:
2229
2230 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
2231
2232         Remove Jan Erik Hanssen (added in my r95078) from the list for now
2233         since I can't confirm acceptable his committership.
2234
2235         * Scripts/webkitpy/common/config/committers.py:
2236
2237 2011-09-14  Jochen Eisinger  <jochen@chromium.org>
2238
2239         [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
2240         https://bugs.webkit.org/show_bug.cgi?id=68066
2241
2242         Reviewed by Adam Barth.
2243
2244         * DumpRenderTree/chromium/WebViewHost.cpp:
2245         * DumpRenderTree/chromium/WebViewHost.h:
2246
2247 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2248
2249         committers.py is missing some contributors
2250         https://bugs.webkit.org/show_bug.cgi?id=68059
2251
2252         Reviewed by Adam Barth.
2253
2254         Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
2255
2256         Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
2257
2258         * Scripts/webkitpy/common/config/committers.py:
2259
2260 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2261
2262         Fix webkit python test after r95061.
2263
2264         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2265
2266 2011-09-13  Xianzhu Wang  <wangxianzhu@chromium.org>
2267
2268         Add myself as a contributor. No review needed.
2269
2270         * Scripts/webkitpy/common/config/committers.py:
2271
2272 2011-09-13  Adam Barth  <abarth@webkit.org>
2273
2274         garden-o-matic has unfriendly error messages when the local server is not available
2275         https://bugs.webkit.org/show_bug.cgi?id=68042
2276
2277         Reviewed by Dimitri Glazkov.
2278
2279         This patch moves us from using alert to showing the error inline in the
2280         progress dialog.
2281
2282         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2283         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2284         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2285         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2286         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2287
2288 2011-09-13  Adam Barth  <abarth@webkit.org>
2289
2290         FailureGrid in garden-o-matic should link to the builder's waterfall page
2291         https://bugs.webkit.org/show_bug.cgi?id=68036
2292
2293         Reviewed by Dimitri Glazkov.
2294
2295         One of the users in the user study thought the configurations names in
2296         the failure grid would link to the underlying bots.  That makes sense,
2297         so this patch adds the behavior.
2298
2299         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2300         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2301         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2302         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2303
2304 2011-09-13  Adam Barth  <abarth@webkit.org>
2305
2306         garden-o-matic should be able to mark failures as expected
2307         https://bugs.webkit.org/show_bug.cgi?id=68027
2308
2309         Reviewed by Dimitri Glazkov.
2310
2311         All the back-end infrastructure exists for this operation.  This patch
2312         just adds some UI to the front-end and wires that UI up to the back
2313         end.  This exact UI will likely need some more polish, but this should
2314         be a reasonable first cut.
2315
2316         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2317         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2318         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2319         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2320         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2321
2322 2011-09-13  Adam Barth  <abarth@webkit.org>
2323
2324         garden-o-matic should tell you about the progress of your rebaseline
2325         https://bugs.webkit.org/show_bug.cgi?id=67967
2326
2327         Reviewed by Dimitri Glazkov.
2328
2329         This patch adds ui.MessageBox, which is a light wrapper around jQuery
2330         UI's dialog widget.  We then use ui.MessageBox to show status messages
2331         about in-progress rebaselines.  As each baseline is downloaded, the
2332         MessageBox updates.  This UI replaces our temporary "alert"-based UI.
2333
2334         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2335         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2336         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2337         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2338         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2339         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2340
2341 2011-09-13  Leandro Pereira  <leandro@profusion.mobi>
2342
2343         GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
2344         https://bugs.webkit.org/show_bug.cgi?id=68024
2345
2346         Reviewed by Gustavo Noronha Silva.
2347         
2348         Using g_list_count() and g_list_nth_data() together on a loop is
2349         inneficient since they're both O(n). Iterate over lists in a saner
2350         way.
2351
2352         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2353         (dumpHistoryItem): Reduce the scope for the 'kids' variable, and
2354         iterate on it using g_list_next(). Free the list after done with it.
2355         (dumpBackForwardListForWebView): Instead of appending (which is
2356         expensive in GLists) history items and then iterating from the tail
2357         of the itemsToPrint list, prepend items and walk forwards as usual.
2358         (dumpBackForwardListForAllWebViews): Walk the list in a saner way,
2359         remove the (unneeded) viewList variable.
2360
2361 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2362
2363         Add Eric's IRC nick.
2364
2365         * Scripts/webkitpy/common/config/committers.py:
2366
2367 2011-09-13  Anders Carlsson  <andersca@apple.com>
2368
2369         Disable C++ exceptions when building with clang
2370         https://bugs.webkit.org/show_bug.cgi?id=68031
2371         <rdar://problem/9556880>
2372
2373         Reviewed by Mark Rowe.
2374
2375         * MiniBrowser/Configurations/Base.xcconfig:
2376         * TestWebKitAPI/Configurations/Base.xcconfig:
2377         * WebKitTestRunner/Configurations/Base.xcconfig:
2378
2379 2011-09-13  Ojan Vafai  <ojan@chromium.org>
2380
2381         [chromium] fix flakiness dashboard for chromium interactive tests
2382         https://bugs.webkit.org/show_bug.cgi?id=68029
2383
2384         Reviewed by Tony Chang.
2385
2386         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2387         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2388
2389 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2390
2391         Add Alice and Aryeh to the list of contributors.
2392
2393         * Scripts/webkitpy/common/config/committers.py:
2394
2395 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2396
2397         sheriffbot whois should also tell us email addresses
2398         https://bugs.webkit.org/show_bug.cgi?id=67975
2399
2400         Reviewed by Eric Seidel and David Levin.
2401
2402         Taught sheriffbot how to tell us contributor's email addresses.
2403
2404         * Scripts/webkitpy/tool/bot/irc_command.py:
2405         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2406
2407 2011-09-13  Eric Seidel  <eric@webkit.org>
2408
2409         Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
2410         https://bugs.webkit.org/show_bug.cgi?id=68018
2411
2412         Reviewed by Ryosuke Niwa.
2413
2414         * Scripts/build-webkit:
2415         * waf/build/settings.py:
2416
2417 2011-09-13  Chang Shu  <cshu@webkit.org>
2418
2419         [WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
2420         https://bugs.webkit.org/show_bug.cgi?id=57515
2421
2422         The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
2423         TestController synchronously. The latter then sends simulated event to WebKit2 module,
2424         which is synchronous, too.
2425
2426         Reviewed by Darin Adler.
2427
2428         * WebKitTestRunner/EventSenderProxy.h: Added.
2429         (WTR::EventSenderProxy::EventSenderProxy):
2430         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2431         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2432         (WTR::EventSendingController::keyDown):
2433         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2434         * WebKitTestRunner/PlatformWebView.h:
2435         (WTR::PlatformWebView::platformWindow):
2436         * WebKitTestRunner/TestController.cpp:
2437         (WTR::TestController::TestController):
2438         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2439         * WebKitTestRunner/TestController.h:
2440         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2441         * WebKitTestRunner/mac/EventSenderProxy.mm: Added.
2442         (WTR::buildModifierFlags):
2443         (WTR::EventSenderProxy::keyDown):
2444
2445 2011-09-12  Leandro Pereira  <leandro@profusion.mobi>
2446
2447         [EFL] DRT: Add DumpRenderTreeEfl.h
2448         https://bugs.webkit.org/show_bug.cgi?id=63993
2449
2450         Reviewed by Eric Seidel.
2451         
2452         This header contains some global variables used by EFL's
2453         DumpRenderTree implementation.
2454
2455         * DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when
2456         appropriate.
2457         * DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.
2458
2459 2011-09-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
2460
2461         [EFL] Send the right key names for PageUp and PageDown.
2462         https://bugs.webkit.org/show_bug.cgi?id=67044
2463
2464         Reviewed by Kenneth Rohde Christiansen.
2465
2466         PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
2467         PageDown (which is close to the defines in WindowsKeyboardCodes.h).
2468         However, EventSender was sending "Page_Up" and "Page_Down", so tests
2469         such as editing/input/page-up-down-scrolls.html were timing out due to
2470         the right key down events not being sent.
2471
2472         * DumpRenderTree/efl/EventSender.cpp:
2473         (keyPadNameFromJSValue):
2474         (keyNameFromJSValue):
2475
2476 2011-09-12  Eric Seidel  <eric@webkit.org>
2477
2478         sheriffbot whois is case sensitive
2479         https://bugs.webkit.org/show_bug.cgi?id=67972
2480
2481         Reviewed by Adam Barth.
2482
2483         I also fixed a typo in the "More than 5 contributors" message
2484         from my previous commit.
2485
2486         * Scripts/webkitpy/common/config/committers.py:
2487         * Scripts/webkitpy/common/config/committers_unittest.py:
2488         * Scripts/webkitpy/tool/bot/irc_command.py:
2489         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2490
2491 2011-09-12  Eric Seidel  <eric@webkit.org>
2492
2493         sheriffbot whois should be smarter
2494         https://bugs.webkit.org/show_bug.cgi?id=67971
2495
2496         Reviewed by Adam Barth.
2497
2498         This makes sheriffbot whois basically grep the committers list
2499         making it much easier to find a contributor by name.
2500
2501         Unfortunately the current unittests depend on the real committers.py
2502         file, so as we add more eric's to the project, this unittest result will
2503         change.  I think that's OK for now.  We'll fix it when it breaks.
2504
2505         * Scripts/webkitpy/common/config/committers.py:
2506         * Scripts/webkitpy/tool/bot/irc_command.py:
2507         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2508
2509 2011-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2510
2511         Unreviewed, rolling out r94976.
2512         http://trac.webkit.org/changeset/94976
2513         https://bugs.webkit.org/show_bug.cgi?id=67953
2514
2515         Broke a bunch of security/load& tests (Requested by rniwa on
2516         #webkit).
2517
2518         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2519         (LayoutTestController::pathToLocalResource):
2520
2521 2011-09-12  Eric Seidel  <eric@webkit.org>
2522
2523         Rubber-stamped by Adam Barth.
2524
2525         Remove the "the tree is burning!" warning previously shown
2526         when landing patches.  It was a dream.  But it's just noise now.
2527
2528         Some bots will require a restart to notice the removal of the option
2529         so I've left the --ignore-builders option in for now.
2530
2531         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2532         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2533         * Scripts/webkitpy/tool/commands/download.py:
2534         * Scripts/webkitpy/tool/commands/download_unittest.py:
2535         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2536         * Scripts/webkitpy/tool/steps/__init__.py:
2537         * Scripts/webkitpy/tool/steps/commit.py:
2538         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
2539         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2540
2541 2011-09-12  Eric Seidel  <eric@webkit.org>
2542
2543         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
2544         https://bugs.webkit.org/show_bug.cgi?id=65781
2545
2546         Reviewed by Ryosuke Niwa.
2547
2548         Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
2549         to resolve the passed in url relative to the absolute url for the test.
2550
2551         I believe this is a better approach than the on used in the Qt and Chromium DRT's
2552         (which resolves the path relative to the built location of the DRT executable)
2553         and we should move this new code into a shared location in a follow-up patch.
2554
2555         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2556         (LayoutTestController::pathToLocalResource):
2557
2558 2011-09-12  Eric Seidel  <eric@webkit.org>
2559
2560         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
2561         https://bugs.webkit.org/show_bug.cgi?id=67530
2562
2563         Reviewed by Adam Barth.
2564
2565         I believe I've fixed the bug in the original patch which prompted the rollout.
2566         The previous patch was using the wrong deadline for the initial read,
2567         subtracting time.time() twice from the deadline value.
2568
2569         * Scripts/webkitpy/layout_tests/port/webkit.py:
2570         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2571
2572 2011-09-12  Balazs Kelemen  <kbalazs@webkit.org>
2573
2574         [Qt][WK2] WebKitTestRunner does not produce crash logs
2575         https://bugs.webkit.org/show_bug.cgi?id=67714
2576
2577         Reviewed by Chang Shu.
2578
2579         Added a simple way of generating backtrace on crash
2580         to the web process. The implementation is similar what
2581         we have in DRT. It depends on GNU libc functionality
2582         so it is only enabled where we are running in such an environment.
2583
2584         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2585         (WTR::printBacktrace):
2586         (WTR::crashHandler):
2587         (WTR::InjectedBundle::platformInitialize):
2588
2589 2011-09-11  Filip Pizlo  <fpizlo@apple.com>
2590
2591         Added my IRC nick to the committers file.
2592
2593         * Scripts/webkitpy/common/config/committers.py:
2594
2595 2011-09-01  Filip Pizlo  <fpizlo@apple.com>
2596
2597         The executable allocator makes it difficult to free individual
2598         chunks of executable memory
2599         https://bugs.webkit.org/show_bug.cgi?id=66363
2600
2601         Reviewed by Oliver Hunt.
2602         
2603         Introduced a best-fit, balanced-tree based allocator. The allocator
2604         required a balanced tree that does not allocate memory and that
2605         permits the removal of individual nodes directly (as opposed to by
2606         key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
2607         Changed all references to executable code to use a reference counted
2608         handle.
2609
2610         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2611         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: Added.
2612         (TestWebKitAPI::TEST_F):
2613         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: Added.
2614         (TestWebKitAPI::Pair::findExact):
2615         (TestWebKitAPI::Pair::remove):
2616         (TestWebKitAPI::Pair::findLeastGreaterThanOrEqual):
2617         (TestWebKitAPI::Pair::assertFoundAndRemove):
2618         (TestWebKitAPI::Pair::assertEqual):
2619         (TestWebKitAPI::Pair::assertSameValuesForKey):
2620         (TestWebKitAPI::Pair::testDriver):
2621         (TestWebKitAPI::TEST_F):
2622
2623 2011-09-10  Andy Estes  <aestes@apple.com>
2624
2625         Move myself from committers_unable_to_review to reviewers_list.
2626
2627         * Scripts/webkitpy/common/config/committers.py:
2628
2629 2011-09-10  Kevin Ollivier  <kevino@theolliviers.com>
2630
2631         [wx] Unreviewed build fix. MSW build fixes.
2632
2633         * DumpRenderTree/config.h:
2634         * waf/build/wxpresets.py:
2635
2636 2011-09-10  Andreas Kling  <kling@webkit.org>
2637
2638         Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
2639         https://bugs.webkit.org/show_bug.cgi?id=59328
2640
2641         Reviewed by Kenneth Rohde Christiansen.
2642
2643         * MiniBrowser/mac/BrowserWindowController.m:
2644         (-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.
2645
2646 2011-09-10  Adam Barth  <abarth@webkit.org>
2647
2648         Build fix for Android.  DumpRenderTree is a client of the WebKit API
2649         and does not have access to notImplemented().
2650
2651         * DumpRenderTree/chromium/TestShellAndroid.cpp:
2652         (openStartupDialog):
2653
2654 2011-09-09  Alexey Proskuryakov  <ap@apple.com>
2655
2656         Add a script to create a monolithic script-test
2657         https://bugs.webkit.org/show_bug.cgi?id=67747
2658
2659         Reviewed by Darin Adler.
2660
2661         * Scripts/make-new-script-test: Added.
2662
2663 2011-09-09  Luiz Agostini  <luiz@webkit.org>
2664
2665         Adding myself to the reviewers list.
2666
2667         * Scripts/webkitpy/common/config/committers.py:
2668
2669 2011-09-09  Ryosuke Niwa  <rniwa@webkit.org>
2670
2671         Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
2672         https://bugs.webkit.org/show_bug.cgi?id=67855
2673
2674         Reviewed by Dirk Pranke.
2675
2676         The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
2677         and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
2678
2679         Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.
2680
2681         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2682
2683 2011-09-09  Mark Hahnenberg  <mhahnenberg@apple.com>
2684
2685         Add myself to committers.py
2686         https://bugs.webkit.org/show_bug.cgi?id=67853
2687
2688         Reviewed by Darin Adler.
2689
2690         * Scripts/webkitpy/common/config/committers.py:
2691
2692 2011-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2693
2694         [Qt] Remove common.pri
2695         https://bugs.webkit.org/show_bug.cgi?id=67814
2696
2697         Reviewed by Andreas Kling.
2698
2699         * Tools.pro:
2700
2701 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2702
2703         [NRWT] the nrwt check httpd with --no-http option
2704         https://bugs.webkit.org/show_bug.cgi?id=67835
2705
2706         Reviewed by Tony Chang.
2707
2708         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2709         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2710
2711 2011-09-09  Hao Zheng  <zhenghao@chromium.org>
2712
2713         [chromium] Implement DRT support for Android.
2714         https://bugs.webkit.org/show_bug.cgi?id=67590
2715
2716         Reviewed by Tony Chang.
2717
2718         Add 2 mechanism to make DRT interaction more robust on Android:
2719         - Send 'QUIT' to DRT to make it stop.
2720         - Wait until receiving '#READY' from DRT, so that DRT won't miss any
2721         input commands before it starts.
2722         And LayoutTestController.cpp needs to include <cctype> for 'tolower'
2723         and <clocale> for 'LC_ALL' to compile on Android.
2724
2725         Also change to use sigaction instead of signal for TestShellGtk.cpp,
2726         as signal() man page recommends using sigaction().
2727
2728         * DumpRenderTree/DumpRenderTree.gypi:
2729         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2730         (main):
2731         * DumpRenderTree/chromium/LayoutTestController.cpp:
2732         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added.
2733         (AlarmHandler):
2734         (TestShell::waitTestFinished):
2735         (platformInit):
2736         (openStartupDialog):
2737         (checkLayoutTestSystemDependencies):
2738         * DumpRenderTree/chromium/TestShellGtk.cpp:
2739         (AlarmHandler):
2740         (TestShell::waitTestFinished):
2741
2742 2011-09-09  Kevin Ollivier  <kevino@theolliviers.com>
2743
2744         [wx] Unreviewed build fix. Add Source/JavaScriptCore/dfg directory to the build.
2745
2746         * waf/build/settings.py:
2747
2748 2011-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2749
2750         Unreviewed, rolling out r94851.
2751         http://trac.webkit.org/changeset/94851
2752         https://bugs.webkit.org/show_bug.cgi?id=67847
2753
2754         It broke a webkitpy test (Requested by ossy on #webkit).
2755
2756         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2757
2758 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2759
2760         [NRWT] the nrwt check httpd with --no-http option
2761         https://bugs.webkit.org/show_bug.cgi?id=67835
2762
2763         Reviewed by Csaba Osztrogonác.
2764
2765         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2766
2767 2011-09-08  Brian Weinstein  <bweinstein@apple.com>
2768
2769         WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
2770         https://bugs.webkit.org/show_bug.cgi?id=67794
2771         <rdar://problem/9892024>
2772         
2773         Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.
2774
2775         Reviewed by Brady Eidson.
2776
2777         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.
2778         (TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both.
2779         (TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect.
2780         (TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html.
2781             Once both frames have loaded (main frame and blocked iframe), make sure that we have never called
2782             didPerformServerRedirect.
2783
2784         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added.
2785         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize
2786             our InjectedBundleTest.
2787         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request
2788             from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block
2789             the request.
2790         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient.
2791
2792         * TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added.
2793         
2794         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2795         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
2796         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto.
2797         * TestWebKitAPI/win/copy-resources.cmd: Ditto.
2798
2799 2011-09-08  David Levin  <levin@chromium.org>
2800
2801         check-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
2802         https://bugs.webkit.org/show_bug.cgi?id=67797
2803
2804         Reviewed by Eric Seidel.
2805
2806         * Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with &.
2807         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.
2808
2809 2011-09-08  Fady Samuel  <fsamuel@chromium.org>
2810
2811         Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
2812         https://bugs.webkit.org/show_bug.cgi?id=67723
2813
2814         Reviewed by Adam Barth.
2815
2816         * DumpRenderTree/chromium/EventSender.h:
2817         * DumpRenderTree/chromium/LayoutTestController.cpp:
2818         (LayoutTestController::LayoutTestController):
2819         (LayoutTestController::enableFixedLayoutMode):
2820         (LayoutTestController::setFixedLayoutSize):
2821         * DumpRenderTree/chromium/LayoutTestController.h:
2822
2823 2011-09-07  Matthew Delaney  <mdelaney@apple.com>
2824
2825         Add standalone script that filters the output of build-webkit to be more human-readable
2826         https://bugs.webkit.org/show_bug.cgi?id=44081
2827
2828         Reviewed by Daniel Bates.
2829
2830         * Scripts/filter-build-webkit: Added. Just need to feed it the output of
2831         a build script (e.g. build-webkit) and it spits out a prettier version.
2832         * Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
2833         * Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"
2834
2835 2011-09-07  Noel Gordon  <noel.gordon@gmail.com>
2836
2837         Add myself to committers.py                 
2838         https://bugs.webkit.org/show_bug.cgi?id=67696
2839
2840         Reviewed by Kent Tamura.
2841
2842         * Scripts/webkitpy/common/config/committers.py:
2843
2844 2011-09-07  Adam Barth  <abarth@webkit.org>
2845
2846         rebaseline button in garden-o-matic details view should work
2847         https://bugs.webkit.org/show_bug.cgi?id=67738
2848
2849         Reviewed by Dimitri Glazkov.
2850
2851         This patch wires up the rebaseline button in garden-o-matic results
2852         details view.  The button is current per-test, so there isn't a way to
2853         rebaseline individual bots.  This is a place to start.  If we decide we
2854         want per-bot rebaselining, we'll need to think of some better UI.
2855
2856         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2857         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2858         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2859         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2860
2861 2011-09-07  Eric Seidel  <eric@webkit.org>
2862
2863         Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
2864         https://bugs.webkit.org/show_bug.cgi?id=67737
2865
2866         Reviewed by Adam Barth.
2867
2868         I got a little over-eager when deprecating host.port_factory in the previous commit.
2869         Turns out that Host.port_factory was already the "modern" port/factory.py
2870         it was just the Module object.  I un-deprecated the variable, and changed it from
2871         being the module to being an actual PortFactory, passing it a host object.
2872         I also taught PortFactory how to set user/executive/filesystem in the kwargs
2873         when instantiating a new Port object.
2874         This magically fixed the test_rebaseline test, since its now no longer talking
2875         to the real filesystem.
2876
2877         * Scripts/webkitpy/common/host.py:
2878         * Scripts/webkitpy/layout_tests/port/factory.py:
2879         * Scripts/webkitpy/tool/commands/queries.py:
2880         * Scripts/webkitpy/tool/mocktool.py:
2881
2882 2011-09-07  Eric Seidel  <eric@webkit.org>
2883
2884         Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
2885         https://bugs.webkit.org/show_bug.cgi?id=67734
2886
2887         Reviewed by Adam Barth.
2888
2889         Right now every place that creates a Port object has to be very careful
2890         to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
2891         The correct fix is for port/factory.py (which creates most port objects)
2892         to know how to pass these in automatically.  However, currently all port/factory.py
2893         functions are free functions instead of being on an object.  This patch
2894         adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
2895
2896         In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
2897         pass along the proper scm/user/filesystem to the Port object.
2898
2899         * Scripts/webkitpy/common/host.py:
2900         * Scripts/webkitpy/layout_tests/port/factory.py:
2901         * Scripts/webkitpy/tool/commands/queries.py:
2902         * Scripts/webkitpy/tool/mocktool.py:
2903
2904 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2905
2906         Unreviewed, rolling out r94441.
2907         http://trac.webkit.org/changeset/94441
2908         https://bugs.webkit.org/show_bug.cgi?id=67731
2909
2910         "MacEWSes are backed up due to new machines not able to reach
2911         git.webkit.org.  Disabling tests for now" (Requested by
2912         eseidel2 on #webkit).
2913
2914         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2915
2916 2011-09-07  Elliot Poger  <epoger@google.com>
2917
2918         filter test_expectations properly for chromium-mac vs chromium-cg-mac
2919         https://bugs.webkit.org/show_bug.cgi?id=67324
2920
2921         Reviewed by Dirk Pranke.
2922
2923         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2924         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2925         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2926         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2927         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2928
2929 2011-09-07  Eric Boren  <borenet@gmail.com>
2930
2931         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
2932         https://bugs.webkit.org/show_bug.cgi?id=66800
2933
2934         Reviewed by Darin Fisher.
2935
2936         * DumpRenderTree/chromium/EventSender.cpp:
2937         (EventSender::sendCurrentTouchEvent):
2938
2939 2011-09-07  Jarred Nicholls  <jarred@sencha.com>
2940
2941         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
2942         https://bugs.webkit.org/show_bug.cgi?id=67254
2943
2944         Reviewed by Csaba Osztrogonác.
2945
2946         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
2947         derived from the running location of DumpRenderTree binary.
2948
2949         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2950         (LayoutTestController::pathToLocalResource):
2951         (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
2952
2953 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2954
2955         REGRESSION(r94288) build-webkit doesn't work on Symbian
2956         https://bugs.webkit.org/show_bug.cgi?id=67706
2957
2958         * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
2959         (buildQMakeProject):
2960
2961 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2962
2963         REGRESSION(r94288) build-webkit doesn't work on Windows
2964         https://bugs.webkit.org/show_bug.cgi?id=67646
2965
2966         Roll back r94655 with a small fix.
2967
2968         * Scripts/webkitdirs.pm:
2969         (buildQMakeProject):
2970
2971 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2972
2973         Unreviewed, rolling out r94635.
2974         http://trac.webkit.org/changeset/94635
2975         https://bugs.webkit.org/show_bug.cgi?id=67704
2976
2977         Linux Touch build is failing to compile this change.
2978         (Requested by loislo on #webkit).
2979
2980         * DumpRenderTree/chromium/EventSender.cpp:
2981         (EventSender::sendCurrentTouchEvent):
2982
2983 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2984
2985         Unreviewed, rolling out r94655.
2986         http://trac.webkit.org/changeset/94655
2987         https://bugs.webkit.org/show_bug.cgi?id=67703
2988
2989         It broke Leopard debug bot (Requested by ossy on #webkit).
2990
2991         * Scripts/webkitdirs.pm:
2992
2993 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2994
2995         REGRESSION(r94288) build-webkit doesn't work on Windows
2996         https://bugs.webkit.org/show_bug.cgi?id=67646
2997
2998         Reviewed by Csaba Osztrogonác.
2999
3000         * Scripts/webkitdirs.pm:
3001
3002 2011-09-06  Eric Boren  <borenet@gmail.com>
3003
3004         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
3005         https://bugs.webkit.org/show_bug.cgi?id=66800
3006
3007         Reviewed by Darin Fisher.
3008
3009         * DumpRenderTree/chromium/EventSender.cpp:
3010         (EventSender::sendCurrentTouchEvent):
3011
3012 2011-09-06  Adam Barth  <abarth@webkit.org>
3013
3014         garden-o-matic details view should having working rebaseline and next/previous buttons
3015         https://bugs.webkit.org/show_bug.cgi?id=67659
3016
3017         Reviewed by Dimitri Glazkov.
3018
3019         This patch wires up basic back/forward buttons that let you traverse
3020         through the results we're examining in the details view.  This ended up
3021         being more code than I expected, but I wanted to keep all the state
3022         information in the DOM itself.
3023
3024         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3025         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3026         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3027
3028 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
3029
3030         fix MockFileSystem.glob(), refactor filesystem tests
3031         https://bugs.webkit.org/show_bug.cgi?id=67462
3032
3033         Reviewed by Eric Seidel.
3034
3035         In debugging why my proposed change for MockFileSystem.glob()
3036         in bug 66228 didn't work, I stumbled across two real bugs
3037         that cancelled each other out for the unit tests. I fixed those
3038         (glob shouldn't recurse into subdirs, and we weren't populating
3039         self.dirs from self.files properly).
3040
3041         I have also created a "mixin" class for tests that can be shared
3042         between the real filesystem and the mock filesystem - MockFileSystem
3043         is being used enough it needs its own tests.
3044
3045         * Scripts/webkitpy/common/system/filesystem_mock.py:
3046         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
3047         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3048
3049 2011-09-06  Anders Carlsson  <andersca@apple.com>
3050
3051         Move NPAPI headers in bridge to plugins
3052         https://bugs.webkit.org/show_bug.cgi?id=67661
3053
3054         Update forwarding headers.
3055
3056         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
3057         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
3058
3059 2011-09-06  Tony Chang  <tony@chromium.org>
3060
3061         [chromium] Check in 'build' for compiled binaries first
3062         https://bugs.webkit.org/show_bug.cgi?id=67549
3063
3064         Reviewed by Dirk Pranke.
3065
3066         I'm working on moving the windows build output to a common location
3067         rather than relative to the sln file.  Because of that, we need to
3068         check those build locations first for DumpRenderTree.exe.
3069
3070         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3071
3072 2011-09-06  Adam Barth  <abarth@webkit.org>
3073
3074         Use a hierarchial structure for the garden-o-matic results view
3075         https://bugs.webkit.org/show_bug.cgi?id=67620
3076
3077         Reviewed by Dimitri Glazkov.
3078
3079         This patch re-organizes the results view to use a hierachial structure
3080         for selection.  At the top-level are sections for each test.  Expanding
3081         the test section shows a tab selector for builders.
3082
3083         This structure prepares us for wiring up various actions to this view.
3084
3085         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3086         (.):
3087         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3088         ():
3089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3090         (.):
3091         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3092         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3093         (.results-view>.toolbar):
3094         (.results-view>.toolbar ul.actions):
3095         (.results-view>.toolbar ul.actions li):
3096         (.results-grid table):
3097         (.results-grid table td, .results-view table th):
3098         (.results-grid table th):
3099         (.results-grid .text-result):
3100         (.results-grid .image-result):
3101
3102 2011-09-06  Adam Barth  <abarth@webkit.org>
3103
3104         garden-o-matic's base.probe generates spam in the JavaScript console
3105         https://bugs.webkit.org/show_bug.cgi?id=67622
3106
3107         Reviewed by Dimitri Glazkov.
3108
3109         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
3110         instead of HTMLScriptElement to test whether results exist.  This
3111         reduces the console.log spam and saves bandwidth because we can use a
3112         HEAD request instead of a GET request.
3113
3114         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
3115
3116 2011-09-05  Adam Barth  <abarth@webkit.org>
3117
3118         Add a tab to garden-o-matic for viewing expected failures
3119         https://bugs.webkit.org/show_bug.cgi?id=67619
3120
3121         Reviewed by Dimitri Glazkov.
3122
3123         This patch adds a basic tab to garden-o-matic that shows all the tests
3124         failing on the bots, including the expected failures.  This patch
3125         mostly involves refactoring existing classes to allow new subclasses.
3126
3127         This view is useful for when gardeners mark tests as expected to fail
3128         and then rebaseline them later.
3129
3130         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3131         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3132         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3133         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
3134         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3135         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3136         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3137
3138 2011-09-05  Adam Barth  <abarth@webkit.org>
3139
3140         Fix global variable leak in garden-o-matic
3141         https://bugs.webkit.org/show_bug.cgi?id=67617
3142
3143         Reviewed by Dimitri Glazkov.
3144
3145         Caught by running the unit tests with noglobals turned on.
3146
3147         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3148
3149 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
3150
3151         [Qt][WK2] Add pixel test support
3152         https://bugs.webkit.org/show_bug.cgi?id=66283
3153
3154         Reviewed by Andreas Kling.
3155
3156         Implemented pixel result generation by reusing the logic
3157         that we have in DumpRenderTree.
3158         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3159         (WTR::dumpImage):
3160         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3161
3162 2011-09-04  Robin Dunn  <robin@alldunn.com>
3163
3164         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
3165         https://bugs.webkit.org/show_bug.cgi?id=67577
3166
3167         Reviewed by Kevin Ollivier.
3168
3169         * waf/build/settings.py:
3170
3171 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
3172
3173         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
3174
3175         * waf/build/settings.py:
3176
3177 2011-09-03  Dan Bernstein  <mitz@apple.com>
3178
3179         32-bit build fix.
3180
3181         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3182         (TestWebKitAPI::Util::toSTD):
3183
3184 2011-09-03  Dan Bernstein  <mitz@apple.com>
3185
3186         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
3187         https://bugs.webkit.org/show_bug.cgi?id=67559
3188
3189         Reviewed by Darin Adler.
3190
3191         * DumpRenderTree/mac/DumpRenderTree.mm:
3192         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
3193         the call to it.
3194         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
3195         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
3196         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
3197         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
3198         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3199         (TestWebKitAPI::Util::toSTD): Added.
3200
3201 2011-09-03  Adam Barth  <abarth@webkit.org>
3202
3203         garden-o-matic results view should have a better results selector
3204         https://bugs.webkit.org/show_bug.cgi?id=67542
3205
3206         Reviewed by Dimitri Glazkov.
3207
3208         This patch adds a basic grid-based results selector to the results
3209         view.  Currently, this grid just shows how the tests fail on the
3210         various bots.  A future patch will let you select which failure to view
3211         and to mark the failures for rebaselining.
3212
3213         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3214         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3215           - Add some more basic functions for manipulating dictionaries.
3216         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3217         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3218         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3219
3220 2011-09-03  Adam Barth  <abarth@webkit.org>
3221
3222         garden-o-matic results view should show Actual and Expected results for text failures
3223         https://bugs.webkit.org/show_bug.cgi?id=67536
3224
3225         Reviewed by Eric Seidel.
3226
3227         In the past, we didn't show actual and expected text results (we just
3228         showed the diff) because we didn't have the awesome six-by-two results
3229         grid.  Now that we do, we can move show these results.
3230
3231         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3232         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3233           - Fixed some typos that were preventing these unit tests from running.
3234         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3235         (.):
3236         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3237           - Report -actual.txt and -expected.txt as possible results URLs.
3238
3239 2011-09-03  Adam Barth  <abarth@webkit.org>
3240
3241         garden-o-matic shows "ghost" failures that are already fixed
3242         https://bugs.webkit.org/show_bug.cgi?id=67535
3243
3244         Reviewed by Eric Seidel.
3245
3246         About 10% of writes fail to stick on test-results.appspot.com.  This
3247         patch causes us to fetch the full_results.json blob directly from
3248         build.chromium.org rather than relying upon AppEngine.
3249
3250         Unforuntately, we still need to get historical information from
3251         AppEngine.  That will take several patches to fix becuase I need to
3252         change the bots to write the full_results.json file to the
3253         build-specific directory in addition to the zip file.
3254
3255         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3256         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3257         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3258
3259 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3260
3261         Unreviewed, rolling out r94458.
3262         http://trac.webkit.org/changeset/94458
3263         https://bugs.webkit.org/show_bug.cgi?id=67558
3264
3265         Caused appcache test to fail on various bots (Requested by
3266         rniwa on #webkit).
3267
3268         * Scripts/webkitpy/layout_tests/port/webkit.py:
3269         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3270
3271 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3272
3273         Unreviewed, rolling out r94453.
3274         http://trac.webkit.org/changeset/94453
3275         https://bugs.webkit.org/show_bug.cgi?id=67557
3276
3277         Caused appcache test to fail on various bots (Requested by
3278         rniwa on #webkit).
3279
3280         * Scripts/webkitpy/layout_tests/port/webkit.py:
3281
3282 2011-09-02  Michael Saboff  <msaboff@apple.com>
3283
3284         Add JSC:RegExp functional tests
3285         https://bugs.webkit.org/show_bug.cgi?id=67339
3286
3287         New perl script to build JavaScriptCore and run the RegExp tests.
3288
3289         Reviewed by Gavin Barraclough.
3290
3291         * Scripts/run-regexp-tests: Added.
3292
3293 2011-09-02  Michael Saboff  <msaboff@apple.com>
3294
3295         Add JSC:RegExp functional tests
3296         https://bugs.webkit.org/show_bug.cgi?id=67339
3297
3298         New perl script to build JavaScriptCore and run the RegExp tests.
3299
3300         Reviewed by Gavin Barraclough.
3301
3302         * Scripts/run-regexp-tests: Added.
3303
3304 2011-09-02  Eric Seidel  <eric@webkit.org>
3305
3306         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
3307         https://bugs.webkit.org/show_bug.cgi?id=67530
3308
3309         Unreviewed.  Fixing typo from previous commit.
3310
3311         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
3312         which exercises the code I previously made a typo in.
3313
3314         * Scripts/webkitpy/layout_tests/port/webkit.py:
3315         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3316
3317 2011-09-02  Eric Seidel  <eric@webkit.org>
3318
3319         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
3320         https://bugs.webkit.org/show_bug.cgi?id=67530
3321
3322         Reviewed by Adam Barth.
3323
3324         No functional change, just reshuffling code.
3325
3326         * Scripts/webkitpy/layout_tests/port/webkit.py:
3327
3328 2011-09-02  Darin Adler  <darin@apple.com>
3329
3330         Added Subversion ignore for .pyc generated files.
3331
3332         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
3333         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
3334         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
3335
3336 2011-09-02  Adam Barth  <abarth@webkit.org>
3337
3338         Enable testing on mac-ews
3339         https://bugs.webkit.org/show_bug.cgi?id=67505
3340
3341         Reviewed by Eric Seidel.
3342
3343         This patch enables testing on the Mac EWS, which should help
3344         contributors not turn the Mac bots red.
3345
3346         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3347
3348 2011-09-01  Beth Dakin  <bdakin@apple.com>
3349
3350         https://bugs.webkit.org/show_bug.cgi?id=67451
3351         Add a test for going back to a cached page after changing the device scale factor
3352
3353         Reviewed by Adam Roben.
3354
3355         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
3356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3357         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
3358         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
3359         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
3360         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
3361         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
3362         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
3363         (TestWebKitAPI::TEST_F):
3364
3365         Added new function to WebKitAgnosticTest to goBack. Separated 
3366         waitForLoadToFinish() into its own function (instead of being a part of 
3367         loadAndWaitUntilFinished()) so that it can be called from goBack as 
3368         well. Also added initializeView() so we can set the cache model.
3369         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
3370         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
3371         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3372         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
3373         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
3374         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3375         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
3376         (TestWebKitAPI::WebKitAgnosticTest::goBack):
3377         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
3378
3379 2011-09-02  Anders Carlsson  <andersca@apple.com>
3380
3381         Build fix.
3382
3383         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
3384         (PrivateBrowsing::ScriptableObject::pluginTest):
3385
3386 2011-09-02  Anders Carlsson  <andersca@apple.com>
3387
3388         Move private browsing test to a PluginTest subclass
3389         https://bugs.webkit.org/show_bug.cgi?id=67498
3390
3391         Reviewed by Darin Adler.
3392
3393         * DumpRenderTree/DumpRenderTree.gypi:
3394         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3395         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3396         (pluginGetProperty):
3397         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3398         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3399         (PluginTest::NPP_SetValue):
3400         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3401         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
3402         (PrivateBrowsing::PrivateBrowsing):
3403         (PrivateBrowsing::privateBrowsingEnabled):
3404         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
3405         (PrivateBrowsing::ScriptableObject::hasProperty):
3406         (PrivateBrowsing::ScriptableObject::getProperty):
3407         (PrivateBrowsing::ScriptableObject::pluginTest):
3408         (PrivateBrowsing::NPP_New):
3409         (PrivateBrowsing::NPP_GetValue):
3410         (PrivateBrowsing::NPP_SetValue):
3411         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3412         (NPP_New):
3413         (NPP_SetValue):
3414         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3415         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3416         * GNUmakefile.am:
3417
3418 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
3419
3420         [Qt] Build dependency problems
3421         https://bugs.webkit.org/show_bug.cgi?id=38054
3422
3423         Trivial fix after r94288.
3424
3425         Rubber-stamped by Andras Becsi.
3426
3427         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
3428         (buildQMakeProject):
3429
3430 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
3431
3432         Remove my old e-mail address and add my new one.
3433
3434         Rubber-stamped by Tor Arne Vestbø.
3435
3436         * Scripts/webkitpy/common/config/committers.py:
3437
3438 2011-09-02  Philippe Normand  <pnormand@igalia.com>
3439
3440         [GTK] run-gtk-tests leaves a zombie Xvfb process
3441         https://bugs.webkit.org/show_bug.cgi?id=67389
3442
3443         Reviewed by Martin Robinson.
3444
3445         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
3446         child process instead of doing shell redirection.
3447
3448 2011-09-01  Mark Rowe  <mrowe@apple.com>
3449
3450         Fix the build by adding some more missing return types.
3451
3452         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3453         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3454
3455 2011-09-01  Eric Seidel  <eric@webkit.org>
3456
3457         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
3458         https://bugs.webkit.org/show_bug.cgi?id=66228
3459
3460         Reviewed by Dirk Pranke.
3461
3462         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
3463         The LeaksViewer tool globs for all *-leaks.txt files.
3464         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
3465
3466         In order to test this I had to fix a limitation in our MockFileSystem.glob
3467         method.  However, doing so uncovered a typo and bug in the integration tests.
3468         I've disabled the offending integration tests.
3469
3470         * Scripts/webkitpy/common/system/filesystem_mock.py:
3471         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
3472         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
3473
3474 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
3475
3476         Adds a LayoutTestController method to make it possible to test
3477         starting speech input via an API call.
3478         https://bugs.webkit.org/show_bug.cgi?id=60170
3479
3480         Reviewed by Dimitri Glazkov.
3481
3482         * DumpRenderTree/LayoutTestController.h:
3483         * DumpRenderTree/chromium/LayoutTestController.cpp:
3484         (LayoutTestController::LayoutTestController):
3485         (LayoutTestController::startSpeechInput):
3486         * DumpRenderTree/chromium/LayoutTestController.h:
3487         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3488         (LayoutTestController::startSpeechInput):
3489         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3490         (LayoutTestController::startSpeechInput):
3491         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3492         (LayoutTestController::startSpeechInput):
3493         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3494         (LayoutTestController::startSpeechInput):
3495         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3496         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3497         (LayoutTestController::startSpeechInput):
3498         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3499         (LayoutTestController::startSpeechInput):
3500
3501 2011-09-01  Tim Horton  <hortont424@gmail.com>
3502
3503         Fix TestWebKitAPI build on clang-2.0
3504
3505         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3506
3507 2011-09-01  Adam Barth  <abarth@webkit.org>
3508
3509         Remove unused "extension" parameter from rebaseline gardeningserver handler
3510         https://bugs.webkit.org/show_bug.cgi?id=67384
3511
3512         Reviewed by James Robinson.
3513
3514         This parameter hasn't done anything in a while.
3515
3516         * Scripts/webkitpy/tool/commands/rebaseline.py:
3517         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3518         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3519
3520 2011-09-01  Eric Seidel  <eric@webkit.org>
3521
3522         Unreviewed.
3523
3524         Fix a typo in unittests.  Unfortunately fixing it
3525         caused several assertions.  Just disabling the test
3526         instead, since it was providing no value before due to the typo.
3527
3528         * Scripts/webkitpy/layout_tests/port/test.py:
3529
3530 2011-09-01  Adam Barth  <abarth@webkit.org>
3531
3532         Add a "rebaseline" button to the garden-o-matic summary page
3533         https://bugs.webkit.org/show_bug.cgi?id=67382
3534
3535         Reviewed by Dimitri Glazkov.
3536
3537         As much as we might wish folks to not rebaseline entire test groups at
3538         once, the truth is that doing so is a common operation.  Adding a
3539         button for this operation is likely to make folks happy.
3540
3541         This patch also cleans up a bunch of plumbing surrounding failureInfo
3542         objects.
3543
3544         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3545         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3546         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3547         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
3548         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3549         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3550         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3551         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3552         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3553         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3554
3555 2011-09-01  Adam Barth  <abarth@webkit.org>
3556
3557         garden-o-matic should let the gardener assign blame for a group of test failures
3558         https://bugs.webkit.org/show_bug.cgi?id=67379
3559
3560         Reviewed by Dimitri Glazkov.
3561
3562         If a group of test failures has a large revision range, the gardener
3563         might wish to blame a specific revision for the failure.  Currently,
3564         this only effect of assigning blame in this way is to hide the other
3565         suspect commits.
3566
3567         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3568         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3569         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3570
3571 2011-09-01  Adam Barth  <abarth@webkit.org>
3572
3573         Hide garden-o-matic failure table until hover
3574         https://bugs.webkit.org/show_bug.cgi?id=67376
3575
3576         Reviewed by Dimitri Glazkov.
3577
3578         This patch removes the failure table for build failures (because it
3579         does not make sense) and hides the failure table for test groups until
3580         the user hovers over the test failure block, reducing visual noise.
3581
3582         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3583         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3584         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
3585
3586 2011-09-01  Adam Barth  <abarth@webkit.org>
3587
3588         Switch garden-o-matic from commitData.title to commitData.summary
3589         https://bugs.webkit.org/show_bug.cgi?id=67375
3590
3591         Reviewed by Dimitri Glazkov.
3592
3593         commitData.title is a string provided by Trac, which isn't great in all
3594         cases.  commitData.summary is my attempt to find the most important
3595         one-line summary of the commit.  This patch switches garden-o-matic
3596         over to summary.
3597
3598         Also, this patch tweaks a bunch of CSS to tighten up the summary page
3599         and reduce visual noise.
3600
3601         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3602         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3603         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
3604
3605 2011-09-01  Adam Barth  <abarth@webkit.org>
3606
3607         Group failing tests in garden-o-matic if there are more than three in a folder
3608         https://bugs.webkit.org/show_bug.cgi?id=67373
3609
3610         Reviewed by Dimitri Glazkov.
3611
3612         Sometimes a failure will cause many tests in a given directory to fail.
3613         When that happens, it's better to list the directory as a single item
3614         (with a count) rather than spamming all the test names.
3615
3616         (This patch also updates a bunch of unit test expected results after my last commit.)
3617
3618         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3619         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3620         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
3621         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3622         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3623
3624 2011-09-01  Adam Barth  <abarth@webkit.org>
3625
3626         Lower the visual noise from the failing builders display
3627         https://bugs.webkit.org/show_bug.cgi?id=67369
3628
3629         Reviewed by Dimitri Glazkov.
3630
3631         This patch ensures that the "Building" row in the failing builders
3632         display is always last and dims it by 50% to reduce visual noise.  This
3633         lets the gardener focus on the actual failures.
3634
3635         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3636         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3637         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
3638
3639 2011-09-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3640
3641         [Qt] Build dependency problems
3642         https://bugs.webkit.org/show_bug.cgi?id=38054
3643
3644         Make clean build after the defines are changed.
3645
3646         Reviewed by Csaba Osztrogonác.
3647
3648         * Scripts/webkitdirs.pm:
3649         (buildQMakeProject):
3650
3651 2011-08-31  Adam Barth  <abarth@webkit.org>
3652
3653         Move DumpRenderTree to WebKitPlatformSupport
3654         https://bugs.webkit.org/show_bug.cgi?id=67331
3655
3656         Reviewed by Darin Fisher.
3657
3658         This patch update DumpRenderTree to account for the WebKitClient =>
3659         WebKitPlatformSupport rename.
3660
3661         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3662         (NotificationPresenter::show):
3663         * DumpRenderTree/chromium/Task.cpp:
3664         (postTask):
3665
3666 2011-08-31  Eric Seidel  <eric@webkit.org>
3667
3668         Add queues.webkit.org/active-bots page to make it easy to see which bots are down
3669         https://bugs.webkit.org/show_bug.cgi?id=67314
3670
3671         Reviewed by Adam Barth.
3672
3673         Very simple page.  Just lists all the bots, what queue they belong to and what we last heard from them.
3674         If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
3675         This makes it very easy for me to see which of my cr-jail bots might be down at any one time.
3676
3677         I also moved a bunch of code into dashboard.css which belonged there.
3678
3679         * QueueStatusServer/handlers/activebots.py: Added.
3680         * QueueStatusServer/main.py:
3681         * QueueStatusServer/stylesheets/dashboard.css:
3682         (.queue_bubble):
3683         (.queue_name):
3684         (.last_heard_from):
3685         (.status_text):
3686         (.alive):
3687         (.behind):
3688         (.dead):
3689         * QueueStatusServer/templates/activebots.html: Added.
3690         * QueueStatusServer/templates/dashboard.html:
3691         * QueueStatusServer/templates/recentstatus.html:
3692
3693 2011-08-31  Oliver Hunt  <oliver@apple.com>
3694
3695         Move CheckedArithmeticOperations.cpp to the intended location
3696
3697         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3698         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp.
3699
3700 2011-08-31  Elliot Poger  <epoger@google.com>
3701
3702         add unittest to validate the complete set of Chromium configurations
3703         https://bugs.webkit.org/show_bug.cgi?id=67211
3704
3705         Reviewed by Adam Barth.
3706
3707         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3708
3709 2011-08-31  Nico Weber  <thakis@chromium.org>
3710
3711         Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
3712         https://bugs.webkit.org/show_bug.cgi?id=67297
3713
3714         Reviewed by Tony Chang.
3715
3716         Explicitly disable smooth scrolling in chromium's DRT.
3717
3718         * DumpRenderTree/chromium/WebPreferences.cpp:
3719         (WebPreferences::applyTo):
3720
3721 2011-08-31  Oliver Hunt  <oliver@apple.com>
3722
3723         Add Checked<> tests to windows build
3724
3725         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3726
3727 2011-08-30  Oliver Hunt  <oliver@apple.com>
3728
3729         Add support for checked arithmetic
3730         https://bugs.webkit.org/show_bug.cgi?id=67095
3731
3732         Reviewed by Sam Weinig.
3733
3734         Add test cases for Checked<>
3735
3736         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3737         * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
3738
3739 2011-08-31  Adam Barth  <abarth@webkit.org>
3740
3741         Move summary.html to garden-o-matic.html.
3742
3743         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
3744         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
3745         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
3746         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
3747
3748 2011-08-31  Noel Gordon  <noel.gordon@gmail.com>
3749
3750         [chromium] DRT linux should pass nativeKeyCode to plugins
3751         https://bugs.webkit.org/show_bug.cgi?id=66679
3752
3753         Reviewed by Tony Chang.
3754
3755         * DumpRenderTree/chromium/EventSender.cpp:
3756         (EventSender::keyDown):  Call a Chromium Linux GTK helper routine that returns the
3757         (simulated) nativeKeyCode for the given input keyboard code.
3758
3759 2011-08-31  Adam Barth  <abarth@webkit.org>
3760
3761         Tighen up UI for garden-o-matic tab strip
3762         https://bugs.webkit.org/show_bug.cgi?id=67266
3763
3764         Reviewed by Dimitri Glazkov.
3765
3766         This patch add CSS to move the tab strip to the edges of the page and
3767         to remove some gratuitous border-radius.
3768
3769         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
3770         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3771
3772 2011-08-31  Adam Barth  <abarth@webkit.org>
3773
3774         garden-o-matic results view shouldn't be horrifically ugly
3775         https://bugs.webkit.org/show_bug.cgi?id=67264
3776
3777         Reviewed by Dimitri Glazkov.
3778
3779         Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
3780
3781         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3782         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3783         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3784
3785 2011-08-31  Adam Barth  <abarth@webkit.org>
3786
3787         garden-o-matic needs a tabstrip
3788         https://bugs.webkit.org/show_bug.cgi?id=67263
3789
3790         Reviewed by Dimitri Glazkov.
3791
3792         This patch adds a basic tabstrip to garden-o-matic.  The results
3793         details view now opens in the "Results" tab, and the user can flip back
3794         and forth between the Summary and the Results tab quickly.  There's
3795         also a stub for a "Commits" tab, which is disabled.
3796
3797         This patch isn't the most beautiful in the world, but it gets the ball
3798         rolling on a multi-modal UI.
3799
3800         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3801         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
3802         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3803         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
3804         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3805
3806 2011-08-31  Ai Makabi  <makabi@google.com>
3807
3808         Extract reference links from reftest test file.
3809         https://bugs.webkit.org/show_bug.cgi?id=66838
3810
3811         Reviewed by Shinichiro Hamaji.
3812
3813         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Added.
3814         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
3815         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.
3816
3817 2011-08-03  Philippe Normand  <pnormand@igalia.com>
3818
3819         [webkitpy] missing log import in common/net/resultsjsonparser.py
3820         https://bugs.webkit.org/show_bug.cgi?id=65606
3821
3822         Reviewed by Martin Robinson.
3823
3824         * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
3825
3826 2011-08-30  Philippe Normand  <pnormand@igalia.com>
3827
3828         [stylechecker] complains about NULL usage in some gst_structure_ calls
3829         https://bugs.webkit.org/show_bug.cgi?id=67194
3830
3831         Reviewed by Martin Robinson.
3832
3833         Don't warn about NULL in some gst_structure_ calls. 0 can't be
3834         used for these, a proper sentinel is required.
3835
3836         * Scripts/webkitpy/style/checkers/cpp.py:
3837         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3838
3839 2011-08-30  Adam Barth  <abarth@webkit.org>
3840
3841         Remove old-style UI from garden-o-matic
3842         https://bugs.webkit.org/show_bug.cgi?id=67257
3843
3844         Reviewed by Dimitri Glazkov.
3845
3846         This code is nowhere near as awesome as the new hotness.  Let's remove
3847         it so it doesn't weigh us down.
3848
3849         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
3850         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
3851         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3852         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
3853         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
3854         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
3855
3856 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
3857
3858         [WebSocket] update pywebsocket to 0.6b5.
3859         https://bugs.webkit.org/show_bug.cgi?id=66924
3860
3861         Reviewed by Kent Tamura.
3862
3863         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
3864         Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
3865         0.6b3 or later supports a closing handshake handler and it is useful to
3866         verify client's closing handshake implementation.
3867         0.6b4 supports AbortedByUserException. It is useful to eliminate
3868         unnecessary server warning messages on intended abnormal closures.
3869         0.6b5 supports Python 2.5.1 or Mac 10.5.
3870
3871         * Scripts/webkitpy/thirdparty/__init__.py:
3872         Update download URL and directory path.
3873
3874 2011-08-30  Dan Bernstein  <mitz@apple.com>
3875
3876         Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
3877         https://bugs.webkit.org/show_bug.cgi?id=67230
3878
3879         Reviewed by Darin Adler.
3880
3881         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3882         * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
3883         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
3884         (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
3885         (TestWebKitAPI::TEST):
3886
3887 2011-08-30  Aaron Colwell  <acolwell@chromium.org>
3888
3889         Add MediaSource API to HTMLMediaElement
3890         https://bugs.webkit.org/show_bug.cgi?id=64731
3891
3892         Reviewed by Eric Carlson.
3893
3894         * Scripts/build-webkit:
3895
3896 2011-08-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3897
3898         Emit last progress notification before calling dispatchDidFinishLoad
3899         https://bugs.webkit.org/show_bug.cgi?id=28851
3900
3901         Reviewed by Adam Barth.
3902
3903         Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
3904         Chromium and GTK ports. The first two were simple changes.
3905
3906         Some refactoring was needed in GTK port to assure that the dumps are emitted
3907         correctly and the processing after the page load finished is in the right place.
3908
3909         To detect the load finished, we use the callback for the "load-status" notifier
3910         signal of the top loading frame. And we use the deprecated "load-finished" signal
3911         for dumping (if enabled) the progress finished expected output.
3912
3913         * DumpRenderTree/LayoutTestController.cpp:
3914         (LayoutTestController::LayoutTestController):
3915         (dumpProgressFinishedCallbackCallback):
3916         (LayoutTestController::staticFunctions):
3917         * DumpRenderTree/LayoutTestController.h:
3918         (LayoutTestController::dumpProgressFinishedCallback):
3919         (LayoutTestController::setDumpProgressFinishedCallback):
3920         * DumpRenderTree/chromium/LayoutTestController.cpp:
3921         (LayoutTestController::LayoutTestController):
3922         (LayoutTestController::dumpProgressFinishedCallback):
3923         (LayoutTestController::reset):
3924         * DumpRenderTree/chromium/LayoutTestController.h:
3925         (LayoutTestController::shouldDumpProgressFinishedCallback):
3926         (LayoutTestController::setShouldDumpProgressFinishedCallback):
3927         * DumpRenderTree/chromium/WebViewHost.cpp:
3928         (WebViewHost::didStopLoading):
3929         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3930         (webViewLoadFinished):
3931         (topLoadingFrameLoadFinished):
3932         (webFrameLoadStatusNotified):
3933         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3934         (LayoutTestController::reset):
3935         (LayoutTestController::dumpProgressFinishedCallback):
3936         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3937
3938 2011-08-30  Filip Pizlo  <fpizlo@apple.com>
3939
3940         JavaScriptCore does not have a good mechanism for performance
3941         regression testing
3942         https://bugs.webkit.org/show_bug.cgi?id=67177
3943
3944         Reviewed by Darin Adler.
3945         
3946         Added a new script, which allows for testing one, two, or more VMs
3947         at once on SunSpider, V8, and Kraken benchmarks.  Benchmark/VM runs
3948         are interleaved at random to minimize systematics.  The results
3949         that bencher prints includes all possible relevant information about
3950         how bencher was invoked.  Bencher can be easily used to measure
3951         performance changes down to fractions of a percent.
3952         
3953         Bencher also includes experimental support for running benchmarks in
3954         a DumpRenderTree release build.  This works in SunSpider and V8, but
3955         not yet in Kraken.  Running benchmarks in DumpRenderTree more
3956         closely mimics the performance when running in browser.
3957
3958         * Scripts/bencher: Added.
3959
3960 2011-08-29  Alexey Proskuryakov  <ap@apple.com>
3961
3962         DumpRenderTree should begin each test with an empty cookie store
3963         https://bugs.webkit.org/show_bug.cgi?id=63545
3964         <rdar://problem/5666907>
3965
3966         Reviewed by Darin Adler.
3967
3968         * DumpRenderTree/mac/DumpRenderTree.mm:
3969         (resetDefaultsToConsistentValues):
3970         (setDefaultsToConsistentValuesForTesting):
3971         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3972         (LayoutTestController::setAlwaysAcceptCookies):
3973         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3974         (WTR::InjectedBundle::beginTesting):
3975         Use new SPIs to manipulate sessions.
3976
3977 2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3978
3979         Unreviewed, rolling out r94055 and r94057.
3980         http://trac.webkit.org/changeset/94055
3981         http://trac.webkit.org/changeset/94057
3982         https://bugs.webkit.org/show_bug.cgi?id=67191
3983
3984         Many failures on Mac 10.5 (Requested by toyoshim on #webkit).
3985
3986         * Scripts/webkitpy/thirdparty/__init__.py:
3987
3988 2011-08-30  Adam Barth  <abarth@webkit.org>
3989
3990         Chromium Android should not be a core builder
3991         https://bugs.webkit.org/show_bug.cgi?id=67184
3992
3993         Reviewed by Ryosuke Niwa.
3994
3995         This bot hasn't been consistently green yet because it has never actually run!
3996
3997         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3998         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3999
4000 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
4001
4002         [WebSocket] update pywebsocket to 0.6b4.
4003         https://bugs.webkit.org/show_bug.cgi?id=66924
4004
4005         Reviewed by Kent Tamura.
4006
4007         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
4008         Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
4009         0.6b3 or later supports a closing handshake handler and it is useful to
4010         verify client's closing handshake implementation.
4011         0.6b4 supports AbortedByUserException. It is useful to eliminate
4012         unnecessary server warning messages on intended abnormal closures.
4013
4014         * Scripts/webkitpy/thirdparty/__init__.py:
4015         Update download URL and directory path.
4016
4017 2011-08-29  Tom Zakrajsek  <tomz@codeaurora.org>
4018
4019         sheriffbot "usage" help statements are wrong
4020         https://bugs.webkit.org/show_bug.cgi?id=67170
4021
4022         Reviewed by Adam Barth.
4023
4024         * Scripts/webkitpy/tool/bot/irc_command.py:
4025         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
4026         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
4027
4028 2011-08-29  Adam Barth  <abarth@webkit.org>
4029
4030         Add support for chomium-mac (non-CoreGraphics) baselines
4031         https://bugs.webkit.org/show_bug.cgi?id=67163
4032
4033         Reviewed by Eric Seidel.
4034
4035         This patch teaches the non-CG chromium-mac bots to look at non-CG
4036         baselines.  However, the patch still leaves CG as the default set of
4037         baselines.
4038
4039         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
4040         * Scripts/webkitpy/common/config/build.py:
4041         * Scripts/webkitpy/common/config/build_unittest.py:
4042         * Scripts/webkitpy/layout_tests/port/builders.py:
4043         * Scripts/webkitpy/layout_tests/port/chromium.py:
4044         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4045         * Scripts/webkitpy/layout_tests/port/factory.py:
4046         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
4047         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
4048         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
4049         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4050
4051 2011-08-29  Shawn Singh  <shawnsingh@chromium.org>
4052
4053         Small fix in chromium port of new-run-webkit-tests.
4054         https://bugs.webkit.org/show_bug.cgi?id=67078
4055
4056         Reviewed by Dirk Pranke.
4057
4058         * Scripts/webkitpy/layout_tests/port/chromium.py:
4059
4060 2011-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
4061
4062         Unreviewed, rolling out r93987, r93992, r93995, r93998, and
4063         r93999.
4064         http://trac.webkit.org/changeset/93987
4065         http://trac.webkit.org/changeset/93992
4066         http://trac.webkit.org/changeset/93995
4067         http://trac.webkit.org/changeset/93998
4068         http://trac.webkit.org/changeset/93999
4069         https://bugs.webkit.org/show_bug.cgi?id=67147
4070
4071         Many failing tests (Requested by ap on #webkit).
4072
4073         * DumpRenderTree/mac/DumpRenderTree.mm:
4074         (setDefaultsToConsistentValuesForTesting):
4075         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4076         (WTR::InjectedBundle::beginTesting):
4077
4078 2011-08-26  Alexey Proskuryakov  <ap@apple.com>
4079
4080         DumpRenderTree should begin each test with an empty cookie store
4081         https://bugs.webkit.org/show_bug.cgi?id=63545
4082         <rdar://problem/5666907>
4083
4084         Reviewed by Darin Adler.
4085
4086         * DumpRenderTree/mac/DumpRenderTree.mm:
4087         (setDefaultsToConsistentValuesForTesting):
4088         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4089         (WTR::InjectedBundle::beginTesting):
4090         Tell WebCore to use a temporary session, starting with a clean cookie store.
4091
4092 2011-08-23  Chris Marrin  <cmarrin@apple.com>
4093
4094         [mac] requestAnimationFrame support for mac port
4095         https://bugs.webkit.org/show_bug.cgi?id=59146
4096
4097         Reviewed by Simon Fraser.
4098
4099         Add support for request-animation-callback flag
4100
4101         * Scripts/build-webkit:
4102
4103 2011-08-27  Peter Beverloo  <peter@chromium.org>
4104
4105         Add a build bot for Chromium with OS(ANDROID)
4106         https://bugs.webkit.org/show_bug.cgi?id=66687
4107
4108         Reviewed by Adam Barth.
4109
4110         * BuildSlaveSupport/build.webkit.org-config/config.json:
4111
4112 2011-08-27  Peter Beverloo  <peter@chromium.org>
4113
4114         Update the master build bot configuration script to properly
4115         deal with the --chromium-android switch.
4116         https://bugs.webkit.org/show_bug.cgi?id=66687
4117
4118         The --chromium-android switch is needed when running
4119         update-webkit-chromium and build-webkit, as it'll tell the
4120         scripts to pull in the right dependencies and cross-compile
4121         WebKit using the Android NDK.
4122
4123         Reviewed by Adam Barth.
4124
4125         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4126
4127 2011-08-27  Peter Beverloo  <peter@chromium.org>
4128
4129         Teach the update and build scripts how to handle dependencies
4130         and cross-compiling rules for the Chromium port on OS(ANDROID).
4131         https://bugs.webkit.org/show_bug.cgi?id=66687
4132
4133         Reviewed by Adam Barth.
4134
4135         * Scripts/build-webkit:
4136         * Scripts/update-webkit:
4137         * Scripts/update-webkit-chromium:
4138         * Scripts/webkitdirs.pm:
4139         (argumentsForConfiguration):
4140         (isChromium):
4141         (isChromiumAndroid):
4142         (determineIsChromiumAndroid):
4143         (buildChromium):
4144
4145 2011-08-26  Adam Barth  <abarth@webkit.org>
4146
4147         garden-o-matic should let me know that I need to run the local server
4148         https://bugs.webkit.org/show_bug.cgi?id=66985
4149
4150         Reviewed by Dimitri Glazkov.
4151
4152         The patch triggers an alert dialog whenever the user tries to use a
4153         feature that requires the local server.
4154
4155         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
4156         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
4157         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
4158
4159 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
4160
4161         garden-o-matic summary view should have pretty commit data information.
4162         https://bugs.webkit.org/show_bug.cgi?id=67069
4163
4164         Reviewed by Adam Barth.
4165
4166         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
4167         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
4168         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
4169         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
4170
4171 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
4172
4173         Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
4174         https://bugs.webkit.org/show_bug.cgi?id=67066
4175
4176         Reviewed by Adam Barth.
4177
4178         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
4179         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
4180
4181 2011-08-26  Raphael Kubo da Costa  <kubo@profusion.mobi>
4182
4183         [DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
4184         https://bugs.webkit.org/show_bug.cgi?id=67041
4185
4186         Reviewed by Martin Robinson.
4187
4188         This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
4189         PixelDumpSupportCairo.h, but the latter was #including cairo.h only
4190         when the GTK+ port was being built.
4191
4192         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
4193
4194 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
4195
4196         Clean up and line up layout in garden-o-matic summary view.
4197         https://bugs.webkit.org/show_bug.cgi?id=67057
4198
4199         1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
4200         2) Rearranged DOM structure a bit to accommodate recent changes;
4201         3) Added minimal CSS to line things up.
4202
4203         Reviewed by Adam Barth.
4204
4205         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
4206         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
4207         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
4208         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
4209         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
4210         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
4211         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
4212         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
4213         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
4214         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
4215
4216 2011-08-26  Alice Liu  <alice.liu@apple.com>
4217
4218         https://bugs.webkit.org/show_bug.cgi?id=66823
4219         Add the request info to the WebPageProxy::CreateNewPage message
4220
4221         Reviewed by Anders Carlsson.
4222
4223         Update function declarations with additional parameter:
4224         * MiniBrowser/gtk/BrowserWindow.c:
4225         (createNewPage):
4226         * MiniBrowser/mac/BrowserWindowController.m:
4227         (createNewPage):
4228         * MiniBrowser/win/BrowserView.cpp:
4229         (createNewPage):
4230         * WebKitTestRunner/TestController.cpp:
4231         (WTR::TestController::createOtherPage):
4232         * WebKitTestRunner/TestController.h:
4233
4234 2011-08-26  Noel Gordon  <noel.gordon@gmail.com>
4235
4236         Make show-pretty-diff work on linux
4237         https://bugs.webkit.org/show_bug.cgi?id=67017
4238
4239         Reviewed by Adam Barth.
4240
4241         * Scripts/show-pretty-diff:
4242
4243 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
4244
4245         Reorganize garden-o-matic CSS files to match JS-built views.
4246         https://bugs.webkit.org/show_bug.cgi?id=66998
4247
4248         Reviewed by Adam Barth.
4249
4250         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
4251         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
4252         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
4253         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
4254         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
4255         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
4256
4257 2011-08-25  Adam Barth  <abarth@webkit.org>
4258
4259         garden-o-matic should be able to roll out patches
4260         https://bugs.webkit.org/show_bug.cgi?id=66982
4261
4262         Reviewed by Dimitri Glazkov.
4263
4264         This patch just wires the rollout event through the controller to the
4265         local server, which is already set up to perform rollouts.
4266
4267         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
4268         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
4269         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
4270         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
4271
4272 2011-08-25  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
4273
4274         [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
4275         https://bugs.webkit.org/show_bug.cgi?id=66951
4276
4277         Reviewed by Andreas Kling.
4278
4279         Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
4280         width and height one by one and setWidth cause geometryChange event in QTouchWebView. 
4281
4282         * MiniBrowser/qt/BrowserView.cpp:
4283         (BrowserView::resizeEvent):
4284
4285 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
4286
4287         garden-o-matic summary view should provide information on builders still in flight.
4288         https://bugs.webkit.org/show_bug.cgi?id=66992
4289
4290         Reviewed by Adam Barth.
4291
4292         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
4293         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
4294         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
4295         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
4296         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
4297
4298 2011-08-25  Adam Barth  <abarth@webkit.org>
4299
4300         webkit-patch rebaseline-expectations don't work when run outside the root
4301         https://bugs.webkit.org/show_bug.cgi?id=66966
4302
4303         Reviewed by Eric Seidel.
4304
4305         Turns out tool.path() used to be relative, which caused problems when
4306         running webkit-patch outside the root directory.  This patch makes it
4307         absolute.  I checked all callers, and they all appear to want this
4308         behavior.
4309
4310         It was unclear to me how to test this change because we only really
4311         have a testing strategy for webkitpy, not for the main script.
4312
4313         * Scripts/webkit-patch:
4314
4315 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
4316
4317         garden-o-matic summary needs a mock view that could be used for working on styling
4318         https://bugs.webkit.org/show_bug.cgi?id=66971
4319
4320         Reviewed by Adam Barth.
4321
4322         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
4323         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
4324
4325 2011-08-25  Anders Carlsson  <andersca@apple.com>
4326
4327         Return the correct value for NPNVsupportsCarbonBool
4328         https://bugs.webkit.org/show_bug.cgi?id=66964
4329
4330         Add a t