Unreviewed build fix after r221017.
[WebKit-https.git] / Source / WebKitLegacy / win / ChangeLog
1 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
2
3         Unreviewed build fix after r221017.
4
5         Correct copy/paste error.
6
7         * WebCoreSupport/WebPlatformStrategies.cpp:
8         (WebPlatformStrategies::cookiesForDOM):
9
10 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
11
12         Unreviewed build fix after r221017.
13
14         * WebCoreSupport/WebPlatformStrategies.cpp:
15         (WebPlatformStrategies::cookiesForDOM): Update for new signature.
16         * WebCoreSupport/WebPlatformStrategies.h:
17
18 2017-08-22  Alex Christensen  <achristensen@webkit.org>
19
20         Remove ChromeClient::scrollbarsModeDidChange
21         https://bugs.webkit.org/show_bug.cgi?id=175805
22
23         Reviewed by Daniel Bates.
24
25         * WebCoreSupport/WebChromeClient.h:
26
27 2017-08-22  Alex Christensen  <achristensen@webkit.org>
28
29         Remove ChromeClient::hasOpenedPopup
30         https://bugs.webkit.org/show_bug.cgi?id=175804
31
32         Reviewed by Sam Weinig.
33
34         * WebCoreSupport/WebChromeClient.cpp:
35         (WebChromeClient::hasOpenedPopup const): Deleted.
36         * WebCoreSupport/WebChromeClient.h:
37
38 2017-08-18  Per Arne Vollan  <pvollan@apple.com>
39
40         [Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
41         https://bugs.webkit.org/show_bug.cgi?id=173536
42
43         Reviewed by Brent Fulgham.
44
45         If the tree state is dirty, accessible objects are deleted while iterating over children
46         under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
47         style is updated before this method is called.
48
49         * AccessibleBase.cpp:
50         (AccessibleBase::getAccessibilityObjectForChild):
51
52 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
53
54         [PAL] Move SessionID into PAL
55         https://bugs.webkit.org/show_bug.cgi?id=174192
56
57         Reviewed by Antti Koivisto.
58
59         * WebCoreSupport/WebFrameLoaderClient.cpp:
60         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
61         * WebCoreSupport/WebFrameLoaderClient.h:
62         * WebCoreSupport/WebFrameNetworkingContext.cpp:
63         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
64         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
65         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
66         (WebFrameNetworkingContext::storageSession const):
67         * WebCoreSupport/WebPlatformStrategies.cpp:
68         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
69         * WebCoreSupport/WebPlatformStrategies.h:
70
71 2017-08-15  Youenn Fablet  <youenn@apple.com>
72
73         [Cache API] Adding generic support for CacheStorage and Cache methods
74         https://bugs.webkit.org/show_bug.cgi?id=175455
75
76         Reviewed by Chris Dumez.
77
78         * WebView.cpp:
79         (WebView::initWithFrame):
80
81 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
82
83         Composition underline color is always black
84         https://bugs.webkit.org/show_bug.cgi?id=174675
85
86         Reviewed by Ryosuke Niwa.
87
88         * WebView.cpp:
89         (WebView::setCompositionForTesting): Use text color for
90         composition underline.
91
92 2017-08-09  Daniel Bates  <dabates@apple.com>
93
94         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
95         https://bugs.webkit.org/show_bug.cgi?id=175247
96         <rdar://problem/33679804>
97
98         Reviewed by Brady Eidson.
99
100         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
101         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
102         clients that need to make use of this information at this time. If such a needs comes up
103         then we can expose API/SPI similar to what we do for WebKit.
104
105         * WebCoreSupport/WebFrameLoaderClient.cpp:
106         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
107         * WebCoreSupport/WebFrameLoaderClient.h:
108
109 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
110
111         Async image decoding for large images should be disabled after the first time a tile is painted
112         https://bugs.webkit.org/show_bug.cgi?id=174451
113         <rdar://problem/31246421>
114
115         Reviewed by Simon Fraser.
116
117         * FullscreenVideoController.cpp:
118         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
119         * WebCoreSupport/AcceleratedCompositingContext.cpp:
120         (AcceleratedCompositingContext::paintContents):
121         * WebCoreSupport/AcceleratedCompositingContext.h:
122
123 2017-07-23  Darin Adler  <darin@apple.com>
124
125         More NeverDestroyed and related cleanup
126         https://bugs.webkit.org/show_bug.cgi?id=174745
127
128         Reviewed by Alex Christensen.
129
130         * Plugins/PluginDatabase.cpp:
131         (WebCore::persistentPluginMetadataCachePath): Use NeverDestroyed
132         instead of DEPRECATED_DEFINE_STATIC_LOCAL.
133         * Plugins/PluginMainThreadScheduler.cpp:
134         (WebCore::PluginMainThreadScheduler::scheduler): Ditto.
135         * Plugins/PluginMainThreadScheduler.h: Ditto.
136         * WebCoreSupport/WebPlatformStrategies.cpp:
137         (WebPlatformStrategies::initialize): Ditto.
138         * WebCoreSupport/WebPlatformStrategies.h: Ditto.
139         * WebHistory.cpp:
140         (sharedHistoryStorage): Ditto.
141         * WebLocalizableStrings.cpp:
142         (mainBundleLocStrings): Ditto.
143         (frameworkLocStringsMutex): Ditto.
144         (frameworkLocStrings): Ditto.
145         * WebView.cpp:
146         (WebView::standardUserAgentWithApplicationName): Ditto.
147         Also changed to keep one global string with the prefix of the user agent string
148         instead of keeping two globals with pieces of that prefix.
149
150 2017-07-24  Chris Dumez  <cdumez@apple.com>
151
152         Make ExceptionCode a proper enumeration
153         https://bugs.webkit.org/show_bug.cgi?id=174771
154
155         Reviewed by Sam Weinig.
156
157         Make ExceptionCode a proper enumeration instead of a typedef to uint8_t.
158
159         * DOMCoreClasses.cpp:
160         (DOMDocument::createEvent):
161         * WebView.cpp:
162         (WebView::prepareCandidateWindow):
163
164 2017-07-21  Andreas Kling  <akling@apple.com>
165
166         Use more references in event dispatch code
167         https://bugs.webkit.org/show_bug.cgi?id=174681
168
169         Reviewed by Geoffrey Garen.
170
171         * DOMEventsClasses.cpp:
172         (WebEventListener::handleEvent):
173         * DOMEventsClasses.h:
174         * Plugins/PluginView.cpp:
175         (WebCore::PluginView::handleEvent):
176         * Plugins/PluginView.h:
177
178 2017-07-20  Brady Eidson  <beidson@apple.com>
179
180         Remove WebIconDatabase from WebKitLegacy/win.
181         https://bugs.webkit.org/show_bug.cgi?id=174608
182
183         Reviewed by Alex Christensen.
184
185         It is unused.
186         
187         * ForEachCoClass.h:
188
189         * Interfaces/IWebIconDatabase.idl: Removed.
190
191         * Interfaces/WebKit.idl:
192
193         * WebCoreStatistics.cpp:
194         (WebCoreStatistics::iconPageURLMappingCount):
195         (WebCoreStatistics::iconRetainedPageURLCount):
196         (WebCoreStatistics::iconRecordCount):
197         (WebCoreStatistics::iconsWithDataCount):
198
199         * WebIconDatabase.cpp: Removed.
200         * WebIconDatabase.h: Removed.
201         * WebKitClassFactory.cpp:
202
203         * WebKitDLL.cpp:
204         (shutDownWebKit):
205
206         * WebKitLogging.h:
207
208         * WebView.cpp:
209         (WebView::close):
210         (WebView::notifyDidAddIcon):
211         (WebView::registerForIconNotification):
212         (WebView::dispatchDidReceiveIconFromWebFrame):
213         (WebView::onNotify):
214
215 2017-07-18  Matt Lewis  <jlewis3@apple.com>
216
217         Unreviewed, rolling out r219610.
218
219         This caused an api failure on all platforms for the test
220         SnapshotImageLargeAsyncDecoding
221
222         Reverted changeset:
223
224         "Async image decoding for large images should be disabled
225         after the first time a tile is painted"
226         https://bugs.webkit.org/show_bug.cgi?id=174451
227         http://trac.webkit.org/changeset/219610
228
229 2017-07-18  Said Abou-Hallawa  <sabouhallawa@apple.com>
230
231         Async image decoding for large images should be disabled after the first time a tile is painted
232         https://bugs.webkit.org/show_bug.cgi?id=174451
233
234         Reviewed by Simon Fraser.
235
236         * FullscreenVideoController.cpp:
237         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
238         * WebCoreSupport/AcceleratedCompositingContext.cpp:
239         (AcceleratedCompositingContext::paintContents):
240         * WebCoreSupport/AcceleratedCompositingContext.h:
241
242 2017-07-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
243
244         [Curl] Don't start downloading more than once for same request
245         https://bugs.webkit.org/show_bug.cgi?id=174172
246
247         Reviewed by Alex Christensen.
248
249         * WebDownloadCurl.cpp:
250         (WebDownload::init):
251
252 2017-07-12  Daniel Bates  <dabates@apple.com>
253
254         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
255         https://bugs.webkit.org/show_bug.cgi?id=174427
256
257         Rubber-stamped by Brady Eidson.
258
259         * Plugins/PluginView.cpp:
260         (WebCore::PluginView::start):
261         (WebCore::PluginView::getURLNotify):
262         (WebCore::PluginView::getURL):
263         (WebCore::PluginView::handlePost):
264
265 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
266
267         [WTF] Move SoftLinking.h into WTF
268         https://bugs.webkit.org/show_bug.cgi?id=174000
269
270         Reviewed by Alex Christensen.
271
272         * WebKitClassFactory.cpp:
273         * WebView.cpp:
274
275 2017-07-05  Brady Eidson  <beidson@apple.com>
276
277         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
278         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
279
280         Reviewed by Alex Christensen.
281
282         Adopt to the new constructor for FrameLoadRequest.
283
284         * Plugins/PluginView.cpp:
285         (WebCore::PluginView::start):
286         (WebCore::PluginView::getURLNotify):
287         (WebCore::PluginView::getURL):
288         (WebCore::PluginView::handlePost):
289
290 2017-07-03  Brady Eidson  <beidson@apple.com>
291
292         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
293         https://bugs.webkit.org/show_bug.cgi?id=174073
294
295         Reviewed by Andy Estes.
296
297         * WebCoreSupport/WebFrameLoaderClient.cpp:
298         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
299         (WebFrameLoaderClient::registerForIconNotification): Deleted.
300         * WebCoreSupport/WebFrameLoaderClient.h:
301
302 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
303
304         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
305         https://bugs.webkit.org/show_bug.cgi?id=174004
306
307         Reviewed by Simon Fraser.
308
309         * WebCoreSupport/WebFrameLoaderClient.cpp:
310         (WebFrameLoaderClient::transitionToCommittedForNewPage):
311
312 2017-06-30  Daniel Bates  <dabates@apple.com>
313
314         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
315         https://bugs.webkit.org/show_bug.cgi?id=165160
316         <rdar://problem/29451999>
317
318         Reviewed by Brady Eidson.
319
320         Pass the document that is requesting the load to the loader.
321
322         * Plugins/PluginView.cpp:
323         (WebCore::PluginView::start):
324         (WebCore::PluginView::getURLNotify):
325         (WebCore::PluginView::getURL):
326         (WebCore::PluginView::handlePost):
327
328 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
329
330         Refactor drag start codepaths to plumb a DragItem to client layers
331         https://bugs.webkit.org/show_bug.cgi?id=173832
332         Work towards <rdar://problem/32236827>
333
334         Reviewed by Ryosuke Niwa and Tim Horton.
335
336         Adjust for changes to WebDragClient::startDrag by pulling information out of DragItem.
337
338         * WebCoreSupport/WebDragClient.cpp:
339         (WebDragClient::startDrag):
340         * WebCoreSupport/WebDragClient.h:
341
342 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
343
344         Remove excessive headers from JavaScriptCore
345         https://bugs.webkit.org/show_bug.cgi?id=173812
346
347         Reviewed by Darin Adler.
348
349         * Plugins/PluginPackage.cpp:
350
351 2017-06-22  Daniel Bates  <dabates@apple.com>
352
353         Make FrameLoadRequest a move-only type
354         https://bugs.webkit.org/show_bug.cgi?id=173682
355
356         Reviewed by Alex Christensen and Darin Adler.
357
358         A FrameLoadRequest groups together the information to perform a load into a single object
359         that is more manageable to pass around than its constituent parts. Code that receives a
360         FrameLoadRequest is expected to extract out the information it needs to complete its task.
361         And it does not make sense to re-use the same FrameLoadRequest object for more than one
362         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
363
364         * Plugins/PluginView.cpp:
365         (WebCore::PluginView::start):
366         (WebCore::PluginView::performRequest):
367         (WebCore::PluginView::load):
368         (WebCore::PluginView::getURLNotify):
369         (WebCore::PluginView::getURL):
370         (WebCore::PluginView::handlePost):
371         * Plugins/PluginView.h:
372         (WebCore::PluginRequest::PluginRequest):
373
374 2017-06-22  Daniel Bates  <dabates@apple.com>
375
376         [Win] Cleanup: Remove unnecessary include of header FrameLoadRequest.h
377         https://bugs.webkit.org/show_bug.cgi?id=173683
378
379         Reviewed by Alex Christensen.
380
381         Neither file PluginViewWin.cpp nor WebContextMenuClient.cpp need to include
382         header FrameLoadRequest.h. The former includes FrameLoadRequest.h indirectly
383         by including PluginView.h. The latter does not make use of the functionality
384         provided by FrameLoadRequest.h.
385
386         * Plugins/PluginViewWin.cpp:
387         * WebCoreSupport/WebContextMenuClient.cpp:
388
389 2017-06-21  Daniel Bates  <dabates@apple.com>
390
391         Cleanup FrameLoadRequest
392         https://bugs.webkit.org/show_bug.cgi?id=173564
393         <rdar://problem/32903570>
394
395         Reviewed by Brent Fulgham.
396
397         * Plugins/PluginView.cpp:
398         (WebCore::PluginView::start): Explicitly pass an empty ResourceRequest (we populate it after
399         we instantiate the FrameLoadRequest) and pass the null-string for the target frame name as
400         we do not have one. Use C++11 brace initialization syntax.
401         (WebCore::PluginView::getURLNotify): Explicitly pass the null-string for the target frame
402         name as we do not have one. Use C++11 brace initialization syntax.
403         (WebCore::PluginView::getURL): Ditto.
404         (WebCore::PluginView::handlePost): Move instantiation of FrameLoadRequest from the top of the
405         function to closer to where it is actually used. Explicitly pass the null-string for the target
406         frame name as we do not have one. Use C++11 brace initialization syntax.
407
408 2017-06-20  Daniel Bates  <dabates@apple.com>
409
410         Have FrameLoadRequest takes a Frame& instead of a Frame*
411         https://bugs.webkit.org/show_bug.cgi?id=173614
412         <rdar://problem/32884890>
413
414         Reviewed by Brent Fulgham.
415
416         * Plugins/PluginView.cpp:
417         (WebCore::PluginView::performRequest):
418         * WebFrame.cpp:
419         (WebFrame::loadRequest):
420
421 2017-06-19  Chris Dumez  <cdumez@apple.com>
422
423         Use WTF::Function instead of std::function in more places in WebCore/
424         https://bugs.webkit.org/show_bug.cgi?id=173535
425
426         Reviewed by Antti Koivisto.
427
428         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
429
430         * WebCoreSupport/WebFrameLoaderClient.cpp:
431         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
432         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
433         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
434         (WebFrameLoaderClient::dispatchWillSubmitForm):
435         (WebFrameLoaderClient::setUpPolicyListener):
436         (WebFrameLoaderClient::receivedPolicyDecision):
437         * WebCoreSupport/WebFrameLoaderClient.h:
438
439 2017-05-14 Frederic Wang  <fwang@igalia.com>
440
441         Add heuristic to avoid flattening "fullscreen" iframes
442         https://bugs.webkit.org/show_bug.cgi?id=171914
443
444         Reviewed by Simon Fraser.
445
446         This commit ajusts the window port to internally use the new preference type for frame flattening.
447         However, the "partial frame flattening" value is not exposed yet.
448
449         * WebView.cpp:
450         (WebView::notifyPreferencesChanged): Use the new type for frame flattening.
451
452 2017-06-17  Chris Dumez  <cdumez@apple.com>
453
454         Use WTF::Function instead of std::function in WebKit2/
455         https://bugs.webkit.org/show_bug.cgi?id=173504
456
457         Reviewed by Darin Adler.
458
459         Use WTF::Function instead of std::function in WebKit2/ to avoid
460         unnecessary copying.
461
462         * Plugins/PluginStream.cpp:
463         (WebCore::PluginStream::willSendRequest):
464         * Plugins/PluginStream.h:
465
466 2017-06-16  Sam Weinig  <sam@webkit.org>
467
468         [WebIDL] Remove custom bindings for HTMLDocument
469         https://bugs.webkit.org/show_bug.cgi?id=173444
470
471         Reviewed by Darin Adler.
472
473         * DOMHTMLClasses.cpp:
474         (DOMHTMLDocument::write):
475         (DOMHTMLDocument::writeln):
476         Update for new signature of write/writeln.
477
478 2017-06-16  Daniel Bates  <dabates@apple.com>
479
480         Cleanup: WebContextMenuClient::searchWithGoogle() should parse URL using URL { URL { }, ... }
481         instead of URL { ParsedURLString, ... }
482         https://bugs.webkit.org/show_bug.cgi?id=173495
483         <rdar://problem/32827445>
484
485         Reviewed by Alex Christensen.
486
487         URL(ParsedURLString, ...) should only be used with a string that was the result of URL::string().
488         Otherwise, it will cause an assertion failure if the canonicalized URL differs from the string.
489         Although it is unlikely that the hardcoded string in WebContextMenuClient::searchWithGoogle()
490         would differ from the canonicalized URL it is best practice to use URL(URL(), ...) to
491         parse an arbitrary string that looks like a URL.
492
493         Also modernize the code using C++14 idioms.
494
495         * WebCoreSupport/WebContextMenuClient.cpp:
496         (WebContextMenuClient::searchWithGoogle):
497
498 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
499
500         [Win] WebKit shouldn't include the forwarding header of WebKit itself
501         https://bugs.webkit.org/show_bug.cgi?id=173352
502
503         Reviewed by Alex Christensen.
504
505         * WebKitPrefix.h: Include WebKit.h of DerivedSources/WebKit instead of DerivedSources/ForwardingHeaders.
506
507 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
508
509         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
510         https://bugs.webkit.org/show_bug.cgi?id=173318
511
512         Reviewed by Darin Adler.
513
514         The logical frame size is currently calculated by scaling the frame size in pixels,
515         and rounding the coordinates to the nearest integers. The computed logical frame
516         size will in some cases be smaller than the scaled frame size in pixels, since it is
517         represented as an IntSize. In these cases, the bottom line will not be painted.
518         Instead of calculating the logical frame size by rounding the scaled frame in
519         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
520
521         * WebCoreSupport/WebFrameLoaderClient.cpp:
522         (WebFrameLoaderClient::transitionToCommittedForNewPage):
523
524 2017-06-13  Daniel Bates  <dabates@apple.com>
525
526         Implement W3C Secure Contexts Draft Specification
527         https://bugs.webkit.org/show_bug.cgi?id=158121
528         <rdar://problem/26012994>
529
530         Reviewed by Brent Fulgham.
531
532         Part 4
533
534         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
535
536         * Interfaces/IWebPreferencesPrivate.idl: Bump the version.
537         * WebPreferenceKeysPrivate.h:
538         * WebPreferences.cpp:
539         (WebPreferences::initializeDefaultSettings):
540         (WebPreferences::QueryInterface):
541         (WebPreferences::setIsSecureContextAttributeEnabled):
542         (WebPreferences::isSecureContextAttributeEnabled):
543         * WebPreferences.h:
544         * WebView.cpp:
545         (WebView::notifyPreferencesChanged):
546
547 2017-06-13  Per Arne Vollan  <pvollan@apple.com>
548
549         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
550         https://bugs.webkit.org/show_bug.cgi?id=173318
551
552         Reviewed by Alex Christensen.
553
554         The logical frame size is currently calculated by scaling the frame size in pixels,
555         and rounding the coordinates to the nearest integers. The computed logical frame
556         size will in some cases be smaller than the scaled frame size in pixels, since it is
557         represented as an IntSize. In these cases, the bottom line will not be painted.
558         Instead of calculating the logical frame size by rounding the scaled frame in
559         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
560  
561         * WebView.cpp:
562         (WebView::sizeChanged):
563
564 2017-06-13  Sam Weinig  <sam@webkit.org>
565
566         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
567         https://bugs.webkit.org/show_bug.cgi?id=80733
568
569         Reviewed by Chris Dumez.
570
571         * WebFrame.cpp:
572         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
573
574 2017-06-12  Daewoong Jang  <daewoong.jang@navercorp.com>
575
576         Remove WebCore::unloadModule and related data types
577         https://bugs.webkit.org/show_bug.cgi?id=173231
578
579         Reviewed by Darin Adler.
580
581         * Plugins/PlatformModule.h: Added.
582         (WebCore::PlatformModuleVersion::PlatformModuleVersion):
583         * Plugins/PluginPackage.cpp:
584         (WebCore::PluginPackage::freeLibraryTimerFired):
585         * Plugins/PluginPackage.h:
586
587 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
588
589         [iOS DnD] Add a hook to perform two-step drops in editable content
590         https://bugs.webkit.org/show_bug.cgi?id=172992
591         <rdar://problem/32590174>
592
593         Reviewed by Tim Horton.
594
595         Add a stub implementation for performTwoStepDrop on Windows.
596
597         * WebCoreSupport/WebEditorClient.h:
598
599 2017-06-04  Konstantin Tokarev  <annulen@yandex.ru>
600
601         Fix build of Windows-specific code with ICU 59.1
602         https://bugs.webkit.org/show_bug.cgi?id=172729
603
604         Reviewed by Darin Adler.
605
606         Fix conversions from WTF::String to wchar_t* and vice versa.
607
608         * Plugins/PluginDatabaseWin.cpp:
609         (WebCore::addPluginPathsFromRegistry):
610         (WebCore::PluginDatabase::getPluginPathsInDirectories):
611         (WebCore::addMozillaPluginDirectories):
612         (WebCore::addWindowsMediaPlayerPluginDirectory):
613         (WebCore::addAdobeAcrobatPluginDirectory):
614         (WebCore::addJavaPluginDirectory):
615         (WebCore::safariPluginsDirectory):
616         (WebCore::addMacromediaPluginDirectories):
617         * Plugins/PluginPackageWin.cpp:
618         (WebCore::getVersionInfo):
619         (WebCore::PluginPackage::fetchInfo):
620         (WebCore::PluginPackage::load):
621         * Plugins/PluginViewWin.cpp:
622         (WebCore::PluginView::handlePostReadFile):
623
624 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
625
626         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
627         https://bugs.webkit.org/show_bug.cgi?id=172709
628
629         Reviewed by Brent Fulgham.
630
631         Add method to exit fullscreen mode.
632
633         * Interfaces/IWebViewPrivate.idl:
634         * WebView.cpp:
635         (WebView::exitFullscreenIfNeeded):
636         * WebView.h:
637
638 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
639
640         [Win] Create unique network storage session for each DRT.
641         https://bugs.webkit.org/show_bug.cgi?id=172540
642
643         Reviewed by Brent Fulgham.
644
645         During layout testing, each DRT instance should have its own network storage session.
646
647         * Interfaces/IWebPreferencesPrivate.idl:
648         * WebPreferences.cpp:
649         (WebPreferences::switchNetworkLoaderToNewTestingSession):
650         * WebPreferences.h:
651
652 2017-05-24  Fujii Hironori  <Hironori.Fujii@sony.com>
653
654         [WinCairo] AcceleratedCompositingContext.h: error C3668: 'AcceleratedCompositingContext::paintContents': method with override specifier 'override' did not override any base class methods
655         https://bugs.webkit.org/show_bug.cgi?id=172535
656
657         Reviewed by Konstantin Tokarev.
658
659         * WebCoreSupport/AcceleratedCompositingContext.cpp:
660         (AcceleratedCompositingContext::paintContents): Append the fifth argument.
661         * WebCoreSupport/AcceleratedCompositingContext.h: Ditto.
662
663 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
664
665         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
666         https://bugs.webkit.org/show_bug.cgi?id=172071
667
668         Reviewed by Alexey Proskuryakov.
669
670         We need to delete all cookies after each test.
671
672         * Interfaces/IWebPreferencesPrivate.idl:
673         * WebPreferences.cpp:
674         (WebPreferences::linkPreloadEnabled):
675         (WebPreferences::clearNetworkLoaderSession):
676         * WebPreferences.h:
677
678 2017-05-13  Chris Dumez  <cdumez@apple.com>
679
680         Stop using RefPtr::release()
681         https://bugs.webkit.org/show_bug.cgi?id=172074
682
683         Reviewed by Geoffrey Garen.
684
685         * WebFrame.cpp:
686         (WebFrame::loadPlainTextString):
687         (WebFrame::loadHTMLString):
688         * WebFramePolicyListener.cpp:
689         (WebFramePolicyListener::receivedPolicyDecision):
690
691 2017-05-13  Chris Dumez  <cdumez@apple.com>
692
693         Drop uses of PassRefPtr in WebKit/win
694         https://bugs.webkit.org/show_bug.cgi?id=172067
695
696         Reviewed by Yusuke Suzuki.
697
698         * DOMEventsClasses.cpp:
699         (DOMEvent::DOMEvent):
700         (DOMEvent::createInstance):
701         * DOMEventsClasses.h:
702         (DOMUIEvent::DOMUIEvent):
703         (DOMKeyboardEvent::DOMKeyboardEvent):
704         (DOMMouseEvent::DOMMouseEvent):
705         (DOMMutationEvent::DOMMutationEvent):
706         (DOMOverflowEvent::DOMOverflowEvent):
707         (DOMWheelEvent::DOMWheelEvent):
708         * MemoryStream.cpp:
709         (MemoryStream::MemoryStream):
710         (MemoryStream::createInstance):
711         * MemoryStream.h:
712         * Plugins/PluginDatabase.cpp:
713         (WebCore::PluginDatabase::refresh):
714         (WebCore::PluginDatabase::add):
715         (WebCore::PluginDatabase::loadPersistentMetadataCache):
716         * Plugins/PluginDatabase.h:
717         * Plugins/PluginPackage.cpp:
718         (WebCore::PluginPackage::createPackage):
719         (WebCore::PluginPackage::createPackageFromCache):
720         * Plugins/PluginPackage.h:
721         * Plugins/PluginStream.h:
722         (WebCore::PluginStream::create):
723         * WebActionPropertyBag.cpp:
724         (WebActionPropertyBag::WebActionPropertyBag):
725         (WebActionPropertyBag::createInstance):
726         * WebActionPropertyBag.h:
727         * WebArchive.cpp:
728         (WebArchive::createInstance):
729         (WebArchive::WebArchive):
730         * WebArchive.h:
731         * WebBackForwardList.cpp:
732         (WebBackForwardList::WebBackForwardList):
733         (WebBackForwardList::createInstance):
734         * WebBackForwardList.h:
735         * WebCoreSupport/EmbeddedWidget.cpp:
736         (EmbeddedWidget::create):
737         * WebCoreSupport/EmbeddedWidget.h:
738         * WebCoreSupport/WebChromeClient.h:
739         * WebFrame.cpp:
740         (WebFrame::loadData):
741         (WebFrame::createSubframeWithOwnerElement):
742         * WebFrame.h:
743         * WebFramePolicyListener.cpp:
744         (WebFramePolicyListener::WebFramePolicyListener):
745         (WebFramePolicyListener::createInstance):
746         * WebFramePolicyListener.h:
747         * WebGeolocationPolicyListener.cpp:
748         (WebGeolocationPolicyListener::createInstance):
749         (WebGeolocationPolicyListener::WebGeolocationPolicyListener):
750         * WebGeolocationPolicyListener.h:
751         * WebHistoryItem.cpp:
752         (WebHistoryItem::WebHistoryItem):
753         (WebHistoryItem::createInstance):
754         * WebHistoryItem.h:
755         * WebMutableURLRequest.cpp:
756         (WebMutableURLRequest::setFormData):
757         (WebMutableURLRequest::formData):
758         * WebMutableURLRequest.h:
759         * WebResource.cpp:
760         (WebResource::createInstance):
761         * WebResource.h:
762         * WebScriptWorld.cpp:
763         (WebScriptWorld::WebScriptWorld):
764         (WebScriptWorld::createInstance):
765         * WebScriptWorld.h:
766         * WebURLAuthenticationChallengeSender.cpp:
767         (WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
768         (WebURLAuthenticationChallengeSender::createInstance):
769         * WebURLAuthenticationChallengeSender.h:
770         * WebView.cpp:
771         (WebView::setFullScreenElement):
772         * WebView.h:
773
774 2017-05-11  Chris Dumez  <cdumez@apple.com>
775
776         Drop remaining uses of PassRefPtr in WebCore
777         https://bugs.webkit.org/show_bug.cgi?id=172013
778
779         Reviewed by Yusuke Suzuki.
780
781         * Plugins/PluginView.cpp:
782         (WebCore::PluginView::bindingInstance):
783
784 2017-05-11  Chris Dumez  <cdumez@apple.com>
785
786         Stop using PassRefPtr in platform/graphics
787         https://bugs.webkit.org/show_bug.cgi?id=171977
788
789         Reviewed by Alex Christensen.
790
791         Build fix.
792
793         * FullscreenVideoController.cpp:
794         (FullscreenVideoController::enterFullscreen):
795         * WebKitDLL.cpp:
796         (loadResourceIntoBuffer):
797
798 2017-05-09  Sam Weinig  <sam@webkit.org>
799
800         Remove support for legacy Notifications
801         https://bugs.webkit.org/show_bug.cgi?id=171487
802
803         Reviewed by Jon Lee.
804
805         * WebCoreSupport/WebChromeClient.cpp:
806         (WebChromeClient::WebChromeClient):
807         * WebCoreSupport/WebChromeClient.h:
808         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
809         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
810         Remove legacy notification specific code.
811
812 2017-05-09  Dean Jackson  <dino@apple.com>
813
814         Fix Windows build.
815
816         * Plugins/PluginView.h:
817         * Plugins/PluginViewWin.cpp:
818         (WebCore::PluginView::paint):
819
820 2017-05-06  Alexey Proskuryakov  <ap@apple.com>
821
822         REGRESSION (r216294): The new test fails on WebKit1
823         https://bugs.webkit.org/show_bug.cgi?id=171780
824
825         Rolling back https://trac.webkit.org/r216294, https://trac.webkit.org/r216296,
826         https://trac.webkit.org/216299, https://trac.webkit.org/216330
827
828         * Plugins/PluginView.h:
829         * Plugins/PluginViewWin.cpp:
830         (WebCore::PluginView::paint):
831
832 2017-05-06  Simon Fraser  <simon.fraser@apple.com>
833
834         Fix Windows build after r216294.
835
836         * Plugins/PluginView.h:
837         * Plugins/PluginViewWin.cpp:
838         (WebCore::PluginView::paint):
839
840 2017-05-04  Commit Queue  <commit-queue@webkit.org>
841
842         Unreviewed, rolling out r216206.
843         https://bugs.webkit.org/show_bug.cgi?id=171714
844
845         Multiple LayoutTests crashing in Document::page() (Requested
846         by ap on #webkit).
847
848         Reverted changeset:
849
850         "Remove support for legacy Notifications"
851         https://bugs.webkit.org/show_bug.cgi?id=171487
852         http://trac.webkit.org/changeset/216206
853
854 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
855
856         [Win] Remove redundant macros that are set in the CMake config
857         https://bugs.webkit.org/show_bug.cgi?id=171571
858
859         Reviewed by Brent Fulgham.
860
861         * COMEnumVariant.h:
862         * COMPropertyBag.h:
863         * WebKitPrefix.h:
864
865 2017-05-04  Sam Weinig  <sam@webkit.org>
866
867         Remove support for legacy Notifications
868         https://bugs.webkit.org/show_bug.cgi?id=171487
869
870         Reviewed by Jon Lee.
871
872         * WebCoreSupport/WebChromeClient.cpp:
873         (WebChromeClient::WebChromeClient):
874         * WebCoreSupport/WebChromeClient.h:
875         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
876         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
877         Remove legacy notification specific code.
878
879 2017-04-27  Alex Christensen  <achristensen@webkit.org>
880
881         Modernize Frame.h
882         https://bugs.webkit.org/show_bug.cgi?id=171357
883
884         Reviewed by Andy Estes.
885
886         * WebCoreSupport/WebEditorClient.cpp:
887         (WebEditorClient::isSelectTrailingWhitespaceEnabled):
888         * WebCoreSupport/WebEditorClient.h:
889
890 2017-04-20  Fujii Hironori  <Hironori.Fujii@sony.com>
891
892         [WinCairo] Fix build break after updating ANGLE
893         https://bugs.webkit.org/show_bug.cgi?id=170980
894
895         Reviewed by Brent Fulgham.
896
897         * WebCoreSupport/AcceleratedCompositingContext.cpp: Define GL_GLEXT_PROTOTYPES.
898
899 2017-04-19  Brent Fulgham  <bfulgham@apple.com>
900
901         [Win] REGRESSION(r215486): Windows Release build is broken
902         https://bugs.webkit.org/show_bug.cgi?id=171024
903         <rdar://problem/31722618>
904
905         Reviewed by Mark Lam.
906
907         Windows WebKit refers to a handful of JSC methods that are always
908         inline. We need to include 'HeapInlines.h' to get the implementation
909         of these methods.
910
911         * Plugins/PluginPackage.cpp:
912         * WebFrame.cpp:
913         * WebView.cpp:
914
915 2017-04-15  Wenson Hsieh  <wenson_hsieh@apple.com>
916
917         Unreviewed, fix the Windows build after r215385
918
919         r215385 introduced a new virtual method on ChromeClient that needs to be implemented in WebChromeClient for
920         Windows in WebKit1.
921
922         * WebCoreSupport/WebChromeClient.cpp:
923         (WebChromeClient::createIconForFiles):
924         * WebCoreSupport/WebChromeClient.h:
925
926 2017-04-10  Chris Dumez  <cdumez@apple.com>
927
928         Drop Timer::startOneShot() overload taking a double
929         https://bugs.webkit.org/show_bug.cgi?id=170659
930
931         Reviewed by Yusuke Suzuki.
932
933         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
934
935         * Plugins/PluginMessageThrottlerWin.cpp:
936         (WebCore::PluginMessageThrottlerWin::appendMessage):
937         (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):
938         * Plugins/PluginViewWin.cpp:
939         (WebCore::PluginView::invalidateRect):
940         * WebCoreSupport/AcceleratedCompositingContext.cpp:
941         (AcceleratedCompositingContext::scheduleLayerFlush):
942
943 2017-04-09  Chris Dumez  <cdumez@apple.com>
944
945         Drop Timer::startRepeating() overload taking a double
946         https://bugs.webkit.org/show_bug.cgi?id=170656
947
948         Reviewed by Yusuke Suzuki.
949
950         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
951
952         * FullscreenVideoController.cpp:
953
954 2017-04-09  Chris Dumez  <cdumez@apple.com>
955
956         Start dropping Timer API dealing with double
957         https://bugs.webkit.org/show_bug.cgi?id=170649
958
959         Reviewed by Yusuke Suzuki.
960
961         Start dropping Timer API dealing with double as people should use Seconds now.
962
963         * Plugins/PluginPackage.cpp:
964         (WebCore::PluginPackage::freeLibrarySoon):
965         * Plugins/PluginStream.cpp:
966         (WebCore::PluginStream::deliverData):
967         * Plugins/PluginView.cpp:
968         (WebCore::PluginView::requestTimerFired):
969         (WebCore::PluginView::scheduleRequest):
970         (WebCore::PluginView::setJavaScriptPaused):
971         (WebCore::PluginView::keepAlive):
972         * Plugins/PluginViewWin.cpp:
973         (WebCore::PluginView::wndProc):
974         * WebView.cpp:
975         (WebView::closeWindowSoon):
976
977 2017-04-08  Chris Dumez  <cdumez@apple.com>
978
979         Drop std::chrono support from Timer class
980         https://bugs.webkit.org/show_bug.cgi?id=170645
981
982         Reviewed by Sam Weinig.
983
984         Drop std::chrono support from Timer class now that we prefer using Seconds type.
985
986         * WebView.cpp:
987         (WebView::setCacheModel):
988
989 2017-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
990
991         [WinCairo] WebCore::PlatformDisplay::terminateEGLDisplay causes a crash in libGLESv2.dll while processing atexit
992         https://bugs.webkit.org/show_bug.cgi?id=170331
993
994         Reviewed by Michael Catanzaro.
995
996         * WebKitDLL.cpp:
997         (shutDownWebKit): Call PlatformDisplay::shutDownEglDisplays in shutDownWebKit.
998
999 2017-03-30  James Craig  <jcraig@apple.com>
1000
1001         AX: Expose a new AXSubrole for explicit ARIA "group" role
1002         https://bugs.webkit.org/show_bug.cgi?id=169810
1003         <rdar://problem/31039693>
1004
1005         Reviewed by Chris Fleizach.
1006
1007         Account for Windows platform role mapping.
1008
1009         * AccessibleBase.cpp:
1010         (MSAARole):
1011
1012 2017-03-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1013
1014         [WK2] Add a UI delegate SPI hook to enable or disable navigation on drop
1015         https://bugs.webkit.org/show_bug.cgi?id=169168
1016         <rdar://problem/30688374>
1017
1018         Reviewed by Tim Horton.
1019
1020         Minor tweak to adjust for a changed interface. See WebKit and WebCore ChangeLogs for more information.
1021
1022         * WebCoreSupport/WebDragClient.cpp:
1023         (WebDragClient::actionMaskForDrag):
1024         * WebCoreSupport/WebDragClient.h:
1025
1026 2017-03-13  Per Arne Vollan  <pvollan@apple.com>
1027
1028         [Win] Compile fix.
1029         https://bugs.webkit.org/show_bug.cgi?id=169545
1030
1031         Reviewed by Brent Fulgham.
1032
1033         Fix inconsistent dll linkage warnings.
1034  
1035         * WebKitDLL.cpp:
1036         * WebKitDLL.h:
1037
1038 2017-03-13  Per Arne Vollan  <pvollan@apple.com>
1039
1040         Unreviewed Win build fix.
1041         
1042         WebCore::CookiesStrategy::addCookie has been removed, we should also remove the override.
1043
1044         * WebCoreSupport/WebPlatformStrategies.cpp:
1045         (WebPlatformStrategies::addCookie): Deleted.
1046         (WebPlatformStrategies::addCookie): Deleted.
1047         * WebCoreSupport/WebPlatformStrategies.h:
1048
1049 2017-03-10  Brent Fulgham  <bfulgham@apple.com>
1050
1051         [Win] Re-export a few symbols for backwards compatibility
1052         https://bugs.webkit.org/show_bug.cgi?id=169490
1053         <rdar://problem/30983623>
1054
1055         Reviewed by Dean Jackson.
1056
1057         Re-introduce a workaround that re-exports a few JavaScriptCore functions
1058         that had been erroneously exported by WebKit in older builds. This
1059         is needed so that we do not break certain old software still being used.
1060
1061         * WebKitDLL.cpp:
1062         (DllMain): Bind functions at startup.
1063         (bindJavaScriptTrampoline): Find JavaScriptCore library functions and
1064         re-export them from WebKit.dll.
1065         * WebKitDLL.h: Only advertise these functions when building WebKt itself.
1066
1067 2017-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
1068
1069         Expand font-weight and font-stretch to take any number
1070         https://bugs.webkit.org/show_bug.cgi?id=168889
1071
1072         Reviewed by Simon Fraser.
1073
1074         Migrate off old enum types.
1075
1076         * WebKitGraphics.cpp:
1077         (makeFont):
1078
1079 2017-03-02  Sam Weinig  <sam@webkit.org>
1080
1081         Rename htmlediting.h/cpp to Editing.h/cpp
1082         https://bugs.webkit.org/show_bug.cgi?id=169103
1083
1084         Reviewed by Alex Christensen.
1085
1086         * AccessibleTextImpl.cpp:
1087
1088 2017-03-01  Alex Christensen  <achristensen@webkit.org>
1089
1090         Actually fix Windows build.
1091
1092         * WebFrame.cpp:
1093         (WebFrame::invalidate):
1094         r213266 changed Style::Force to ResolveStyleType::Rebuild, so I did so here.
1095
1096 2017-03-01  Alex Christensen  <achristensen@webkit.org>
1097
1098         Fix Windows build after r213266
1099         https://bugs.webkit.org/show_bug.cgi?id=169049
1100
1101         * WebFrame.cpp:
1102         (WebFrame::invalidate):
1103
1104 2017-02-27  Per Arne Vollan  <pvollan@apple.com>
1105
1106         [Win] Http preload tests are failing.
1107         https://bugs.webkit.org/show_bug.cgi?id=168910
1108
1109         Reviewed by Alex Christensen.
1110
1111         The feature is not enabled.
1112
1113         * WebView.cpp:
1114         (WebView::notifyPreferencesChanged):
1115
1116 2017-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1117
1118         Better handle Thread and RunLoop initialization
1119         https://bugs.webkit.org/show_bug.cgi?id=167828
1120
1121         Reviewed by Yusuke Suzuki.
1122
1123         Remove unnecessary call to WTF::initializeMainThread().
1124
1125         * WebView.cpp:
1126         (WebView::WebView):
1127
1128 2017-02-20  Per Arne Vollan  <pvollan@apple.com>
1129
1130         [Win] Custom scale factor is not applied in all cases.
1131         https://bugs.webkit.org/show_bug.cgi?id=168117
1132
1133         Reviewed by Brent Fulgham.
1134
1135         We should not call the function deviceScaleFactorForWindow directly, since this
1136         will return the system scale factor, and ignore the custom scale factor.
1137
1138         * WebView.cpp:
1139         (WebView::handleContextMenuEvent):
1140         (WebView::handleMouseEvent):
1141         (WebView::setAcceleratedCompositing):
1142
1143 2017-02-16  Daniel Bates  <dabates@apple.com>
1144
1145         Remove Chromium-specific code to call FrameLoaderClient::redirectDataToPlugin(nullptr)
1146         https://bugs.webkit.org/show_bug.cgi?id=168417
1147         <rdar://problem/30541748>
1148
1149         Reviewed by Brent Fulgham.
1150
1151         Update override of FrameLoaderClient::redirectDataToPlugin() to take a Widget& instead of a
1152         Widget* as it is always called with a valid Widget.
1153
1154         * WebCoreSupport/WebFrameLoaderClient.cpp:
1155         (WebFrameLoaderClient::redirectDataToPlugin):
1156         * WebCoreSupport/WebFrameLoaderClient.h:
1157
1158 2017-02-15  Anders Carlsson  <andersca@apple.com>
1159
1160         Another attempt at fixing the Windows build.
1161
1162         * WebCoreSupport/WebDragClient.cpp:
1163         (WebDragClient::startDrag):
1164
1165 2017-02-15  Anders Carlsson  <andersca@apple.com>
1166
1167         Try to fix the Windows build.
1168
1169         * WebCoreSupport/WebDragClient.h:
1170
1171 2017-02-15  Anders Carlsson  <andersca@apple.com>
1172
1173         Modernize DragClient::startDrag somewhat
1174         https://bugs.webkit.org/show_bug.cgi?id=168379
1175
1176         Reviewed by Tim Horton.
1177
1178         Update for WebCore changes.
1179
1180         * WebCoreSupport/WebDragClient.cpp:
1181         (WebDragClient::startDrag):
1182
1183 2017-02-10  Daniel Bates  <dabates@apple.com>
1184
1185         Attempt to fix the WinCairo 64-Bit Release build following <https://trac.webkit.org/changeset/212173>
1186         (https://bugs.webkit.org/show_bug.cgi?id=166774)
1187
1188         Touch WebKit.idl in the hopes that it will cause CMake to regenerate the COM interface files.
1189
1190         * Interfaces/WebKit.idl:
1191
1192 2017-02-10  Daniel Bates  <dabates@apple.com>
1193
1194         Detach frame from document when entering page cache
1195         https://bugs.webkit.org/show_bug.cgi?id=166774
1196         <rdar://problem/29904368>
1197
1198         Reviewed by Chris Dumez.
1199
1200         * Interfaces/IWebPreferencesPrivate.idl:
1201         * WebPreferenceKeysPrivate.h:
1202         * WebPreferences.cpp:
1203         (WebPreferences::initializeDefaultSettings):
1204         (WebPreferences::setAllowsPageCacheWithWindowOpener): Deleted.
1205         (WebPreferences::allowsPageCacheWithWindowOpener): Deleted.
1206         * WebPreferences.h:
1207         * WebView.cpp:
1208         (WebView::notifyPreferencesChanged):
1209
1210 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
1211
1212         [Resource Timing] Enable Resource Timing by default in Tests
1213         https://bugs.webkit.org/show_bug.cgi?id=168145
1214
1215         Reviewed by Ryosuke Niwa.
1216
1217         * Interfaces/IWebPreferencesPrivate.idl:
1218         * WebPreferenceKeysPrivate.h:
1219         * WebPreferences.cpp:
1220         (WebPreferences::initializeDefaultSettings):
1221         (WebPreferences::setResourceTimingEnabled):
1222         (WebPreferences::resourceTimingEnabled):
1223         * WebPreferences.h:
1224         * WebView.cpp:
1225         (WebView::notifyPreferencesChanged):
1226
1227 2017-02-06  Alex Christensen  <achristensen@webkit.org>
1228
1229         More build fixes after r211751
1230         https://bugs.webkit.org/show_bug.cgi?id=166998
1231
1232         * WebDownloadCFNet.cpp:
1233         (WebDownload::didReceiveAuthenticationChallenge):
1234
1235 2017-02-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
1236
1237         Rename AnimationController to CSSAnimationController
1238         https://bugs.webkit.org/show_bug.cgi?id=167829
1239
1240         Reviewed by Simon Fraser.
1241
1242         * WebFrame.cpp:
1243
1244 2017-02-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1245
1246         Drag images should be anchored to the mouse location
1247         https://bugs.webkit.org/show_bug.cgi?id=167690
1248         <rdar://problem/30295261>
1249
1250         Reviewed by Enrica Casucci.
1251
1252         Adds some plumbing for the anchor point in the WK1 client layer.
1253
1254         * WebCoreSupport/WebDragClient.cpp:
1255         (WebDragClient::startDrag):
1256         * WebCoreSupport/WebDragClient.h:
1257
1258 2017-02-02  Per Arne Vollan  <pvollan@apple.com>
1259
1260         [Win][HiDPI] Scale factor is applied twice in accelerated compositing mode.
1261         https://bugs.webkit.org/show_bug.cgi?id=167732
1262
1263         Reviewed by Brent Fulgham.
1264
1265         Backing layer should not be scaled when CACFLayerSetContentsScale is used for scaling.
1266
1267         * WebView.cpp:
1268         (WebView::setAcceleratedCompositing):
1269
1270 2017-02-02  Chris Dumez  <cdumez@apple.com>
1271
1272         [Crash] com.apple.WebKit.WebContent at WebKit: WebKit::WebPage::fromCorePage()
1273         https://bugs.webkit.org/show_bug.cgi?id=167738
1274         <rdar://problem/30229990>
1275
1276         Reviewed by Andreas Kling.
1277
1278         The BackForwardClient no longer needs to worry about removing HistoryItems
1279         from the PageCache now that WebCore takes care of it.
1280
1281         * BackForwardList.cpp:
1282         (BackForwardList::close):
1283
1284 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
1285
1286         Add Link Preload as an off-by-default experimental feature menu item.
1287         https://bugs.webkit.org/show_bug.cgi?id=167201
1288
1289         Reviewed by Ryosuke Niwa.
1290
1291         * WebPreferenceKeysPrivate.h:
1292         * WebPreferences.cpp:
1293         (WebPreferences::initializeDefaultSettings):
1294         (WebPreferences::valueForKey):
1295         (WebPreferences::setLinkPreloadEnabled):
1296         (WebPreferences::linkPreloadEnabled):
1297         * WebPreferences.h:
1298         * Interfaces/IWebPreferencesPrivate.idl:
1299
1300 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1301
1302         Add User Timing Experimental Feature
1303         https://bugs.webkit.org/show_bug.cgi?id=167542
1304         <rdar://problem/22746307>
1305
1306         Reviewed by Ryosuke Niwa.
1307
1308         * Interfaces/IWebPreferencesPrivate.idl:
1309         * WebPreferenceKeysPrivate.h:
1310         * WebPreferences.cpp:
1311         (WebPreferences::initializeDefaultSettings):
1312         (WebPreferences::setUserTimingEnabled):
1313         (WebPreferences::userTimingEnabled):
1314         * WebPreferences.h:
1315         * WebView.cpp:
1316         (WebView::notifyPreferencesChanged):
1317         Add setting for User Timing runtime enabled feature.
1318
1319 2017-01-26  Chris Dumez  <cdumez@apple.com>
1320
1321         Crash when navigating back to a page in PacheCache when one of its frames has been removed
1322         https://bugs.webkit.org/show_bug.cgi?id=167421
1323         <rdar://problem/30188490>
1324
1325         Reviewed by Darin Adler.
1326
1327         Add a new setting allowing layout tests to enable PageCache in a window
1328         that has an opener, for convenience.
1329
1330         * WebPreferenceKeysPrivate.h:
1331         * WebPreferences.cpp:
1332         (WebPreferences::initializeDefaultSettings):
1333         * WebPreferences.h:
1334
1335 2017-01-26  Keith Miller  <keith_miller@apple.com>
1336
1337         classInfo should take a VM so it is not materialized from the object on each call
1338         https://bugs.webkit.org/show_bug.cgi?id=167424
1339
1340         Rubber Stamped by Michael Saboff.
1341
1342         Previously, classInfo() would get the VM from the target's
1343         MarkedBlock.  Most callers already have a VM on hand, so it is
1344         wasteful to compute the VM from the marked block every time. This
1345         patch refactors some of the most common callers of classInfo(),
1346         jsDynamicCast and inherits to take a VM as well.
1347
1348         * WebFrame.cpp:
1349         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
1350         * WebView.cpp:
1351         (WebView::elementFromJS):
1352
1353 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
1354
1355         Crash when setting custom scale factor.
1356         https://bugs.webkit.org/show_bug.cgi?id=167369
1357
1358         Reviewed by Sam Weinig.
1359
1360         Add null pointer check.
1361
1362         * WebView.cpp:
1363         (WebView::setCustomBackingScaleFactor):
1364
1365 2017-01-24  Youenn Fablet  <youennf@gmail.com>
1366
1367         [WebRTC] Introduce libwebrtc abstraction for WK1/WK2 implementations
1368         https://bugs.webkit.org/show_bug.cgi?id=167294
1369
1370         Reviewed by Alex Christensen.
1371
1372         * WebView.cpp:
1373         (WebView::initWithFrame):
1374
1375 2017-01-23  Chris Dumez  <cdumez@apple.com>
1376
1377         REGRESSION (r211033): ASSERTION FAILED: m_ptr in com.apple.WebCore: WTF::RefPtr<WebCore::Element>::operator* const + 70
1378         https://bugs.webkit.org/show_bug.cgi?id=167308
1379         <rdar://problem/30144964>
1380
1381         Unreviewed, do a partial revert of r211033 to fix assertion.
1382
1383         * WebCoreSupport/WebChromeClient.cpp:
1384         (WebChromeClient::exitFullScreenForElement):
1385
1386 2017-01-20  Darin Adler  <darin@apple.com>
1387
1388         Remove PassRefPtr from "page" directory of WebCore, also deploy references
1389         https://bugs.webkit.org/show_bug.cgi?id=167224
1390
1391         Reviewed by Chris Dumez.
1392
1393         * Plugins/PluginView.cpp:
1394         (WebCore::PluginView::status): Pass reference.
1395         (WebCore::PluginView::focusPluginElement): Ditto.
1396
1397         * WebCoreSupport/WebChromeClient.cpp:
1398         (WebChromeClient::createWindow): Updated for change to ChromeClient.
1399         (WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
1400         (WebChromeClient::runJavaScriptAlert): Ditto.
1401         (WebChromeClient::runJavaScriptConfirm): Ditto.
1402         (WebChromeClient::runJavaScriptPrompt): Ditto.
1403         (WebChromeClient::contentsSizeChanged): Ditto.
1404         (WebChromeClient::unavailablePluginButtonClicked): Ditto.
1405         (WebChromeClient::print): Ditto.
1406         (WebChromeClient::exceededDatabaseQuota): Ditto.
1407         (WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
1408         (WebChromeClient::attachRootGraphicsLayer): Ditto.
1409         (WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
1410         (WebChromeClient::enterVideoFullscreenForVideoElement): Ditto.
1411         (WebChromeClient::createPopupMenu): Ditto.
1412         (WebChromeClient::createSearchPopupMenu): Ditto.
1413         (WebChromeClient::supportsFullScreenForElement): Ditto.
1414         (WebChromeClient::enterFullScreenForElement): Ditto.
1415         (WebChromeClient::exitFullScreenForElement): Ditto.
1416         (WebChromeClient::shouldUseTiledBackingForFrameView): Ditto.
1417         * WebCoreSupport/WebChromeClient.h: Ditto.
1418
1419 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1420
1421         Remove never changing IndexedDB RuntimeEnabledFeature
1422         https://bugs.webkit.org/show_bug.cgi?id=167278
1423
1424         Reviewed by Darin Adler.
1425
1426         * WebView.cpp:
1427         (WebView::notifyPreferencesChanged):
1428
1429 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1430
1431         Cleanup RuntimeEnabledFeatures
1432         https://bugs.webkit.org/show_bug.cgi?id=167228
1433
1434         Reviewed by Simon Fraser.
1435
1436         * WebView.cpp:
1437         (WebView::notifyPreferencesChanged):
1438
1439 2017-01-20  Alex Christensen  <achristensen@webkit.org>
1440
1441         Build Fix for Windows DumpRenderTree after r210976
1442         https://bugs.webkit.org/show_bug.cgi?id=167115
1443
1444         * WebPreferences.h:
1445         Remove extra space.
1446         * IWebPreferencesPrivate.idl:
1447         Add new interface functions.
1448         * WebView.cpp:
1449         We use new functions that are only in IWebPreferencesPrivate4,
1450         so instantiate that COM object instead of version 3.
1451
1452 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1453
1454         Build Fix for Windows DumpRenderTree after r210976
1455
1456         * WebPreferenceKeysPrivate.h:
1457         * WebPreferences.cpp:
1458         (WebPreferences::initializeDefaultSettings):
1459         (WebPreferences::setWebAnimationsEnabled):
1460         (WebPreferences::webAnimationsEnabled):
1461         * WebPreferences.h:
1462         * WebView.cpp:
1463         Add toggle APIs for WebAnimations.
1464
1465 2017-01-19  Chris Dumez  <cdumez@apple.com>
1466
1467         iterable<> should be enabled on WK1
1468         https://bugs.webkit.org/show_bug.cgi?id=167221
1469         <rdar://problem/30108531>
1470
1471         Reviewed by Youenn Fablet.
1472
1473         * Interfaces/IWebPreferencesPrivate.idl:
1474         * WebPreferenceKeysPrivate.h:
1475         * WebPreferences.cpp:
1476         (WebPreferences::setDOMIteratorEnabled): Deleted.
1477         (WebPreferences::domIteratorEnabled): Deleted.
1478         * WebPreferences.h:
1479         * WebView.cpp:
1480         (WebView::notifyPreferencesChanged):
1481
1482 2017-01-18  Alex Christensen  <achristensen@webkit.org>
1483
1484         Fix WinCairo build after r210845.
1485         https://bugs.webkit.org/show_bug.cgi?id=167055
1486
1487         * WebCoreSupport/WebFrameLoaderClient.cpp:
1488         * WebCoreSupport/WebFrameLoaderClient.h:
1489         shouldCacheResponse isn't used when loading with libcurl.
1490         It was dead code before Darin added "override".
1491         WebCore/FrameLoaderClient.h has this inside of USE(CFURLCONNECTION) macros, now we have them here, too.
1492
1493 2017-01-18  Andreas Kling  <akling@apple.com>
1494
1495         Document::securityOrigin() should return a reference.
1496         <https://webkit.org/b/167124>
1497
1498         Reviewed by Sam Weinig.
1499
1500         * Plugins/PluginView.cpp:
1501         (WebCore::PluginView::load):
1502         * WebCoreSupport/WebChromeClient.cpp:
1503         (WebChromeClient::exceededDatabaseQuota):
1504         * WebCoreSupport/WebFrameLoaderClient.cpp:
1505         (WebFrameLoaderClient::didRunInsecureContent):
1506         * WebCoreSupport/WebFrameLoaderClient.h:
1507         * WebCoreSupport/WebGeolocationClient.cpp:
1508         (WebGeolocationClient::requestPermission):
1509         * WebFrame.cpp:
1510         (WebFrame::allowsFollowingLink):
1511
1512 2017-01-15  Darin Adler  <darin@apple.com>
1513
1514         Remove PassRefPtr from "loader" directory of WebCore
1515         https://bugs.webkit.org/show_bug.cgi?id=167055
1516
1517         Reviewed by Alex Christensen.
1518
1519         * Plugins/PluginView.cpp:
1520         (WebCore::PluginView::mediaCanStart): Fix call to dispatchDidFailToStartPlugin
1521         by calling it directly on WebFrameLoaderClient. If my theory is correct, the old
1522         call has been broken and doing nothing since r177941, two years ago, which made
1523         the argument types different between FrameLoaderClient and WebFrameLoaderClient,
1524         leaving WebFrameLoaderClient::dispatchDidFailToStartPlugin as dead code.
1525
1526         * WebCoreSupport/WebChromeClient.cpp:
1527         (WebChromeClient::runOpenPanel): Updated for change to ChromeClient.
1528         * WebCoreSupport/WebChromeClient.h: Ditto.
1529
1530         * WebCoreSupport/WebEditorClient.cpp:
1531         (WebEditorUndoCommand::WebEditorUndoCommand): Take a reference instead of
1532         a PassRefPtr. Also use Ref instead of RefPtr.
1533         (WebEditorClient::shouldChangeTypingStyle): Deleted. Empty function that was
1534         never called.
1535         (WebEditorClient::webViewDidChangeTypingStyle): Ditto.
1536         (WebEditorClient::webViewDidChangeSelection): Ditto.
1537         (WebEditorClient::registerUndoStep):  Take reference instead of PassRefPtr.
1538         (WebEditorClient::registerRedoStep): Ditto.
1539         * WebCoreSupport/WebEditorClient.h: Updated for the above. Also marked the
1540         class and member functions final and made them all private, which will
1541         help us catch if there are any that don't correctly match WebCore.
1542
1543         * WebCoreSupport/WebFrameLoaderClient.cpp:
1544         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Updated
1545         for change to ChromeClient.
1546         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
1547         (WebFrameLoaderClient::dispatchWillSendSubmitEvent): Ditto.
1548         (WebFrameLoaderClient::dispatchWillSubmitForm): Ditto.
1549         (WebFrameLoaderClient::createFrame): Ditto. Also merged two functions into
1550         one because one was private and only called by the other.
1551         (WebFrameLoaderClient::createPlugin): Ditto.
1552         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
1553         (WebFrameLoaderClient::createNetworkingContext): Ditto.
1554         * WebCoreSupport/WebFrameLoaderClient.h: Ditto.
1555
1556         * WebCoreSupport/WebFrameNetworkingContext.h:
1557         (WebFrameNetworkingContext::create): Return a Ref instead of a PassRefPtr.
1558
1559 2017-01-12  Joseph Pecoraro  <pecoraro@apple.com>
1560
1561         Remove unnecessary includes of Page.h
1562         https://bugs.webkit.org/show_bug.cgi?id=166996
1563
1564         Reviewed by Yusuke Suzuki.
1565
1566         * AccessibleTextImpl.cpp:
1567         * BackForwardList.cpp:
1568
1569 2017-01-06  Darin Adler  <darin@apple.com>
1570
1571         Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
1572         https://bugs.webkit.org/show_bug.cgi?id=166797
1573
1574         Reviewed by Alex Christensen.
1575
1576         * WebCoreSupport/WebEditorClient.h: Update argument to take a reference
1577         instead of a PassRefPtr.
1578
1579 2017-01-05  Andreas Kling  <akling@apple.com>
1580
1581         Remove ChromeClient::needTouchEvents().
1582         <https://webkit.org/b/166723>
1583
1584         Rubber-stamped by Antti Koivisto.
1585
1586         * WebCoreSupport/WebChromeClient.h:
1587
1588 2017-01-04  Darin Adler  <darin@apple.com>
1589
1590         Remove PassRefPtr use from the "html" directory, other improvements
1591         https://bugs.webkit.org/show_bug.cgi?id=166635
1592
1593         Reviewed by Alex Christensen.
1594
1595         * WebCoreSupport/WebChromeClient.cpp:
1596         (WebChromeClient::loadIconForFiles): Take a reference instead of a pointer.
1597         * WebCoreSupport/WebChromeClient.h: Updated for the above.
1598
1599 2016-12-30  Darin Adler  <darin@apple.com>
1600
1601         Remove PassRefPtr use from the "dom" directory, related cleanup
1602         https://bugs.webkit.org/show_bug.cgi?id=166569
1603
1604         Reviewed by Alex Christensen.
1605
1606         * WebCoreSupport/WebFrameLoaderClient.cpp:
1607         (WebFrameLoaderClient::dispatchDidReceiveTitle): Updated since StringWithDirection::title
1608         is now a data member, not a function member.
1609         (WebFrameLoaderClient::updateGlobalHistory): Ditto.
1610         (WebFrameLoaderClient::setTitle): Ditto.
1611         * WebDataSource.cpp:
1612         (WebDataSource::pageTitle): Ditto.
1613
1614 2016-12-25  Yusuke Suzuki  <utatane.tea@gmail.com>
1615
1616         Propagate the source origin as much as possible
1617         https://bugs.webkit.org/show_bug.cgi?id=166348
1618
1619         Reviewed by Darin Adler.
1620
1621         * Plugins/PluginPackage.cpp:
1622         (WebCore::NPN_Evaluate):
1623         (WebCore::makeSource): Deleted.
1624
1625 2016-12-22  Andy Estes  <aestes@apple.com>
1626
1627         Make WebCore::EditorInsertAction an enum class
1628         https://bugs.webkit.org/show_bug.cgi?id=166424
1629
1630         Reviewed by Brent Fulgham.
1631
1632         * WebCoreSupport/WebEditorClient.cpp:
1633         (kit):
1634         (WebEditorClient::shouldInsertNode):
1635         (WebEditorClient::shouldInsertText):
1636
1637 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1638
1639         [ES6] Enable ES6 Modules
1640         https://bugs.webkit.org/show_bug.cgi?id=165849
1641
1642         Reviewed by Geoffrey Garen.
1643
1644         * Interfaces/IWebPreferencesPrivate.idl:
1645         * WebPreferenceKeysPrivate.h:
1646         * WebPreferences.cpp:
1647         (WebPreferences::setES6ModulesEnabled): Deleted.
1648         (WebPreferences::es6ModulesEnabled): Deleted.
1649         * WebPreferences.h:
1650         * WebView.cpp:
1651         (WebView::notifyPreferencesChanged):
1652
1653 2016-12-10  Filip Pizlo  <fpizlo@apple.com>
1654
1655         The DOM should have an advancing wavefront opaque root barrier
1656         https://bugs.webkit.org/show_bug.cgi?id=165712
1657
1658         Reviewed by Yusuke Suzuki.
1659         
1660         Propagate the JSDOMWindowBase::commonVM() -> commonVM() change.
1661
1662         * Plugins/PluginView.cpp:
1663         (WebCore::PluginView::start):
1664         (WebCore::PluginView::stop):
1665         (WebCore::PluginView::performRequest):
1666         (WebCore::PluginView::npObject):
1667         (WebCore::PluginView::privateBrowsingStateChanged):
1668         * Plugins/PluginViewWin.cpp:
1669         (WebCore::PluginView::dispatchNPEvent):
1670         (WebCore::PluginView::handleKeyboardEvent):
1671         (WebCore::PluginView::handleMouseEvent):
1672         (WebCore::PluginView::setNPWindowRect):
1673         * WebCoreStatistics.cpp:
1674         (WebCoreStatistics::javaScriptObjectsCount):
1675         (WebCoreStatistics::javaScriptGlobalObjectsCount):
1676         (WebCoreStatistics::javaScriptProtectedObjectsCount):
1677         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
1678         (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
1679         (WebCoreStatistics::javaScriptObjectTypeCounts):
1680         (WebCoreStatistics::shouldPrintExceptions):
1681         (WebCoreStatistics::setShouldPrintExceptions):
1682         (WebCoreStatistics::memoryStatistics):
1683         * WebJavaScriptCollector.cpp:
1684         (WebJavaScriptCollector::objectCount):
1685
1686 2016-12-09  Geoffrey Garen  <ggaren@apple.com>
1687
1688         TextPosition and OrdinalNumber should be more like idiomatic numbers
1689         https://bugs.webkit.org/show_bug.cgi?id=165678
1690
1691         Reviewed by Filip Pizlo.
1692
1693         Adopt default constructor.
1694
1695         * Plugins/PluginPackage.cpp:
1696         (WebCore::makeSource):
1697
1698 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
1699
1700         Enable SharedArrayBuffer, remove the flag
1701         https://bugs.webkit.org/show_bug.cgi?id=165614
1702
1703         Rubber stamped by Geoffrey Garen.
1704
1705         * Interfaces/IWebPreferencesPrivate.idl:
1706
1707 2016-11-26  Yusuke Suzuki  <utatane.tea@gmail.com>
1708
1709         [WTF] Import std::optional reference implementation as WTF::Optional
1710         https://bugs.webkit.org/show_bug.cgi?id=164199
1711
1712         Reviewed by Saam Barati and Sam Weinig.
1713
1714         Use WTF::Optional::value_or.
1715
1716         * Plugins/PluginView.cpp:
1717         (WebCore::PluginView::performRequest):
1718         * WebCoreSupport/WebFrameLoaderClient.cpp:
1719         (WebFrameLoaderClient::dispatchDidCommitLoad):
1720         * WebCoreSupport/WebFrameLoaderClient.h:
1721         * WebSecurityOrigin.cpp:
1722         (WebSecurityOrigin::port):
1723
1724 2016-11-19  Simon Fraser  <simon.fraser@apple.com>
1725
1726         [iOS WK2] When zoomed in and panning on pages with fixed bars, parts of the bars are sometimes missing
1727         https://bugs.webkit.org/show_bug.cgi?id=164855
1728
1729         Reviewed by Sam Weinig.
1730         
1731         Remove the "inStableState" parameter from flushCompositingState() etc.
1732
1733         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1734         (AcceleratedCompositingContext::flushPendingLayerChanges):
1735         * WebView.cpp:
1736         (WebView::flushPendingGraphicsLayerChanges):
1737
1738 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1739
1740         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
1741         https://bugs.webkit.org/show_bug.cgi?id=164827
1742
1743         Reviewed by Ryosuke Niwa.
1744
1745         * Interfaces/IWebPreferencesPrivate.idl:
1746         * WebPreferenceKeysPrivate.h:
1747         * WebPreferences.cpp:
1748         (WebPreferences::setES6ModulesEnabled):
1749         (WebPreferences::es6ModulesEnabled):
1750         * WebPreferences.h:
1751         * WebView.cpp:
1752         (WebView::notifyPreferencesChanged):
1753
1754 2016-11-14  Alex Christensen  <achristensen@webkit.org>
1755
1756         Move SecurityOrigin::createFromDatabaseIdentifier to SecurityOriginData
1757         https://bugs.webkit.org/show_bug.cgi?id=164720
1758
1759         Reviewed by Brady Eidson.
1760
1761         * WebDatabaseManager.cpp:
1762         (DidModifyOriginData::dispatchToMainThread):
1763         (DidModifyOriginData::DidModifyOriginData):
1764         (WebDatabaseManager::dispatchDidModifyOrigin):
1765         (WebDatabaseManager::dispatchDidModifyDatabase):
1766         * WebDatabaseManager.h:
1767         * WebSecurityOrigin.cpp:
1768         (WebSecurityOrigin::usage):
1769         (WebSecurityOrigin::quota):
1770         (WebSecurityOrigin::setQuota):
1771
1772 2016-11-13  Darin Adler  <darin@apple.com>
1773
1774         Fix exception handling in SQL database code, streamline and update code
1775         https://bugs.webkit.org/show_bug.cgi?id=164685
1776
1777         Reviewed by Sam Weinig.
1778
1779         * WebDatabaseManager.cpp:
1780         (WebDatabaseManager::origins): Use DatabaseTracker.
1781         (WebDatabaseManager::databasesWithOrigin): Ditto.
1782         (WebDatabaseManager::detailsForDatabase): Use reference.
1783         (WebDatabaseManager::deleteAllDatabases): Use DatabaseTracker.
1784         (WebDatabaseManager::deleteOrigin): Ditto.
1785         (WebDatabaseManager::deleteDatabase): Ditto.
1786         (WebDatabaseManager::dispatchDidModifyOrigin): Use reference
1787         and DatabaseTracker.
1788         (WebDatabaseManager::setQuota): Ditto.
1789         (WebDatabaseManager::dispatchDidModifyDatabase): Ditto.
1790         * WebDatabaseManager.h: Updated client functions to take a reference.
1791
1792         * WebSecurityOrigin.cpp:
1793         (WebSecurityOrigin::usage): Update to use DatabaseTracker.
1794         (WebSecurityOrigin::quota): Ditto.
1795         (WebSecurityOrigin::setQuota): Ditto.
1796
1797 2016-11-11  Eric Carlson  <eric.carlson@apple.com>
1798
1799         [MediaStream] defer resolution of getUserMedia promise made in a background tab
1800         https://bugs.webkit.org/show_bug.cgi?id=164643
1801         <rdar://problem/29048317>
1802
1803         Unreviewed build fix after r208606.
1804
1805         * Plugins/PluginView.cpp:
1806         (WebCore::PluginView::mediaCanStart):
1807         * Plugins/PluginView.h:
1808
1809 2016-11-11  Darin Adler  <darin@apple.com>
1810
1811         Move Node from ExceptionCode to ExceptionOr
1812         https://bugs.webkit.org/show_bug.cgi?id=164515
1813
1814         Reviewed by Sam Weinig.
1815
1816         * DOMCoreClasses.cpp:
1817         (DOMNode::insertBefore): Update exception handling.
1818         (DOMNode::removeChild): Ditto.
1819
1820 2016-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1821
1822         MemoryPressureHandler shouldn't know how to release WebCore memory
1823         https://bugs.webkit.org/show_bug.cgi?id=160497
1824
1825         Reviewed by Michael Catanzaro.
1826
1827         Set the low memory handler before installing the memory pressure handler.
1828
1829         * WebView.cpp:
1830         (WebView::initWithFrame):
1831
1832 2016-11-09  Alex Christensen  <achristensen@webkit.org>
1833
1834         Fix Windows build after r208499
1835         https://bugs.webkit.org/show_bug.cgi?id=164562
1836
1837         * WebKitDLL.cpp:
1838         (shutDownWebKit):
1839
1840 2016-11-09  Darin Adler  <darin@apple.com>
1841
1842         Move Range from ExceptionCode to ExceptionOr
1843         https://bugs.webkit.org/show_bug.cgi?id=164457
1844
1845         Reviewed by Alex Christensen.
1846
1847         * WebView.cpp:
1848         (WebView::onIMERequestCharPosition): Updated for new exception handling.
1849
1850 2016-11-09  Darin Adler  <darin@apple.com>
1851
1852         Move EventTarget from ExceptionCode to ExceptionOr
1853         https://bugs.webkit.org/show_bug.cgi?id=164465
1854
1855         Reviewed by Youenn Fablet.
1856
1857         * DOMCoreClasses.cpp:
1858         (DOMNode::dispatchEvent): Updated exception handling.
1859         (DOMWindow::dispatchEvent): Ditto.
1860
1861 2016-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1862
1863         Safari does not emit composition end if blurred for dead key / Japanese IME
1864         https://bugs.webkit.org/show_bug.cgi?id=164369
1865         <rdar://problem/29050439>
1866
1867         Reviewed by Ryosuke Niwa.
1868
1869         Add a stub implementation of canceledComposition.
1870
1871         * WebCoreSupport/WebEditorClient.cpp:
1872         (WebEditorClient::canceledComposition):
1873         * WebCoreSupport/WebEditorClient.h:
1874
1875 2016-11-04  Per Arne Vollan  <pvollan@apple.com>
1876
1877         [Win] Page visibility tests are timing out.
1878         https://bugs.webkit.org/show_bug.cgi?id=164363
1879
1880         Reviewed by Brent Fulgham.
1881
1882         Add method to set page visibility.
1883
1884         * Interfaces/IWebViewPrivate.idl:
1885         * WebView.cpp:
1886         (WebView::QueryInterface):
1887         (WebView::findString):
1888         (WebView::setVisibilityState):
1889         * WebView.h:
1890
1891 2016-11-01  Ryosuke Niwa  <rniwa@webkit.org>
1892
1893         Remove CUSTOM_ELEMENTS build flag
1894         https://bugs.webkit.org/show_bug.cgi?id=164267
1895
1896         Reviewed by Antti Koivisto.
1897
1898         Removed the build flag.
1899
1900         * WebView.cpp:
1901         (WebView::notifyPreferencesChanged):
1902
1903 2016-10-29  Filip Pizlo  <fpizlo@apple.com>
1904
1905         JSC should support SharedArrayBuffer
1906         https://bugs.webkit.org/show_bug.cgi?id=163986
1907
1908         Reviewed by Keith Miller.
1909
1910         Support the RuntimeFlag.
1911
1912         * Interfaces/IWebPreferencesPrivate.idl:
1913
1914 2016-10-31  Joseph Pecoraro  <pecoraro@apple.com>
1915
1916         Use #pragma once in WebCore
1917         https://bugs.webkit.org/show_bug.cgi?id=164194
1918
1919         Rubber-stamped by Sam Weinig.
1920
1921         * WebCoreSupport/WebContextMenuClient.cpp:
1922         (WebContextMenuClient::isSpeaking):
1923         (WebContextMenuClient::shareMenuItem): Deleted.
1924         * WebCoreSupport/WebContextMenuClient.h:
1925         Remove this dead code since r192333.
1926
1927 2016-10-31  Darin Adler  <darin@apple.com>
1928
1929         Convert Document from ExceptionCode to Exception
1930         https://bugs.webkit.org/show_bug.cgi?id=164212
1931
1932         Reviewed by Alex Christensen.
1933
1934         * DOMCoreClasses.cpp:
1935         (DOMDocument::createElement): Updated exception handling.
1936         (DOMDocument::createEvent): Ditto.
1937
1938 2016-10-30  Darin Adler  <darin@apple.com>
1939
1940         Move Element, NamedNodeMap, and DOMStringMap from ExceptionCode to Exception
1941         https://bugs.webkit.org/show_bug.cgi?id=164206
1942
1943         Reviewed by Chris Dumez.
1944
1945         * DOMCoreClasses.cpp:
1946         (DOMElement::setAttribute): Updated exception handling.
1947         * DOMHTMLClasses.cpp:
1948         (DOMHTMLElement::setInnerHTML): Ditto.
1949
1950 2016-10-30  Brent Fulgham  <bfulgham@apple.com>
1951
1952         Unreviewed build fix (Direct2D)
1953
1954         * WebView.cpp:
1955         (WebView::paintWithDirect2D): Update for revised GraphicsContext
1956         begin/end draw behavior.
1957
1958 2016-10-28  Darin Adler  <darin@apple.com>
1959
1960         Move all classes in the HTML directory from ExceptionCode to Exception
1961         https://bugs.webkit.org/show_bug.cgi?id=163876
1962
1963         Reviewed by Sam Weinig.
1964
1965         * DOMHTMLClasses.cpp:
1966         (DOMHTMLElement::setInnerText): Update exception handling.
1967         * FullscreenVideoController.cpp:
1968         (FullscreenVideoController::setVolume): Ditto.
1969
1970 2016-10-27  Brent Fulgham  <bfulgham@apple.com>
1971
1972         Unreviewed build fix.
1973
1974         * WebView.cpp:
1975         (WebView::paintWithDirect2D): Correct merge error.
1976
1977 2016-10-25  Brent Fulgham  <bfulgham@apple.com>
1978
1979         [Win][Direct2D] Create a RAII Helper Class for the Render Target
1980         https://bugs.webkit.org/show_bug.cgi?id=164005
1981
1982         Reviewed by Alex Christensen.
1983
1984         * WebView.cpp:
1985         (WebView::sizeChanged): Construct RenderTarget with higher-resolution display timer.
1986         (WebView::paintWithDirect2D): Revise to use new RenderTargetHelper class.
1987
1988 2016-10-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1989
1990         Support "insertFromDrop" and "deleteByDrag" for the InputEvent spec
1991         https://bugs.webkit.org/show_bug.cgi?id=163948
1992         <rdar://problem/28921433>
1993
1994         Reviewed by Darin Adler.
1995
1996         Add support for new drag and drop-related EditAction enum values.
1997
1998         * WebCoreSupport/WebEditorClient.cpp:
1999         (undoNameForEditAction):
2000
2001 2016-10-26  Brian Burg  <bburg@apple.com>
2002
2003         Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
2004         https://bugs.webkit.org/show_bug.cgi?id=164046
2005
2006         Reviewed by Joseph Pecoraro.
2007
2008         * WebCoreSupport/WebInspectorClient.h:
2009
2010 2016-10-19  Alex Christensen  <achristensen@webkit.org>
2011
2012         Revert r207151
2013         https://bugs.webkit.org/show_bug.cgi?id=163675
2014
2015         Reviewed by Brent Fulgham.
2016
2017         * DefaultDownloadDelegate.h:
2018         * WebCoreSupport/WebFrameLoaderClient.cpp:
2019         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2020         * WebCoreSupport/WebFrameNetworkingContext.cpp:
2021         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2022         * WebCoreSupport/WebFrameNetworkingContext.h:
2023         * WebCoreSupport/WebPlatformStrategies.cpp:
2024         * WebDownload.h:
2025         * WebError.cpp:
2026         (WebError::localizedDescription):
2027         (WebError::sslPeerCertificate):
2028         * WebError.h:
2029         * WebMutableURLRequest.cpp:
2030         (WebMutableURLRequest::mutableCopy):
2031         * WebURLAuthenticationChallenge.cpp:
2032         (WebURLAuthenticationChallenge::initWithProtectionSpace):
2033         (WebURLAuthenticationChallenge::initWithAuthenticationChallenge):
2034         * WebURLResponse.cpp:
2035         (WebURLResponse::sslPeerCertificate):
2036         * WebURLResponse.h:
2037         * WebView.cpp:
2038         (WebView::setCacheModel):
2039         (WebView::canHandleRequest):
2040         (WebView::notifyPreferencesChanged):
2041         (updateSharedSettingsFromPreferencesIfNeeded):
2042
2043 2016-10-18  Darin Adler  <darin@apple.com>
2044
2045         Move many miscellaneous classes from ExceptionCode to Exception
2046         https://bugs.webkit.org/show_bug.cgi?id=163645
2047
2048         Reviewed by Ryosuke Niwa.
2049
2050         * DOMCoreClasses.cpp:
2051         (DOMDocument::getComputedStyle): Use ptr instead of get since the return
2052         value is now Ref instead of RefPtr.
2053
2054 2016-10-18  Anders Carlsson  <andersca@apple.com>
2055
2056         Try to fix the Windows build.
2057
2058         * WebHistoryItem.cpp:
2059         (WebHistoryItem::redirectURLs):
2060
2061 2016-10-18  Anders Carlsson  <andersca@apple.com>
2062
2063         Move some history specific HistoryItem code to WebHistoryItem
2064         https://bugs.webkit.org/show_bug.cgi?id=163567
2065
2066         Reviewed by Tim Horton.
2067
2068         Remove these, they aren't used.
2069
2070         * WebCoreSupport/WebFrameLoaderClient.cpp:
2071         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
2072         * WebHistory.cpp:
2073         (WebHistory::visitedURL):
2074         * WebHistoryItem.cpp:
2075         (WebHistoryItem::initFromDictionaryRepresentation):
2076         (WebHistoryItem::dictionaryRepresentation):
2077
2078 2016-10-16  Darin Adler  <darin@apple.com>
2079
2080         Move CSS classes from ExceptionCode to Exception
2081         https://bugs.webkit.org/show_bug.cgi?id=163494
2082
2083         Reviewed by Sam Weinig.
2084
2085         * DOMCSSClasses.cpp:
2086         (DOMCSSStyleDeclaration::setCssText): Remove ExceptionCode handling.
2087         (DOMCSSStyleDeclaration::setProperty): Ditto.
2088
2089 2016-10-12  Anders Carlsson  <andersca@apple.com>
2090
2091         Copy BackForwardList from WebCore to WebKit/win
2092         https://bugs.webkit.org/show_bug.cgi?id=163360
2093
2094         Reviewed by Alex Christensen.
2095
2096         Use our local BackForwardList class instead of WebCore::BackForwardList.
2097
2098         * BackForwardList.cpp: Added.
2099         * BackForwardList.h: Added.
2100         * WebBackForwardList.h:
2101         * WebView.cpp:
2102         (WebView::initWithFrame):
2103         (WebView::backForwardList):
2104
2105 2016-10-13  Anders Carlsson  <andersca@apple.com>
2106
2107         Get rid of the HistoryItemVector typedef
2108         https://bugs.webkit.org/show_bug.cgi?id=163398
2109
2110         Reviewed by Beth Dakin.
2111
2112         Expand the HistoryitemVector typedef instead to make it more clear what types we are dealing with.
2113
2114         * WebBackForwardList.cpp:
2115         (WebBackForwardList::backListWithLimit):
2116         (WebBackForwardList::forwardListWithLimit):
2117         * WebHistoryItem.cpp:
2118         (WebHistoryItem::children):
2119
2120 2016-10-12  Brent Fulgham  <bfulgham@apple.com>
2121
2122         [Win] Unreviewed build fix after r207218.
2123
2124         The CQ-landed patch used the old USE(CFNETWORK) compiler guard.
2125         It should be using USE(CFURLCONNECTION).
2126
2127         * WebCache.cpp: Missed one!
2128
2129 2016-10-12  Brent Fulgham  <bfulgham@apple.com>
2130
2131         [Win] Unreviewed build fix after r207218.
2132
2133         The CQ-landed patch used the old USE(CFNETWORK) compiler guard.
2134         It should be using USE(CFURLCONNECTION).
2135
2136         * WebCache.cpp:
2137         (WebCache::cacheFolder):
2138         (WebCache::setCacheFolder):
2139
2140 2016-10-12  Per Arne Vollan  <pvollan@apple.com>
2141
2142         [Win] Parallel DRTs are sharing preferences and cache.
2143         https://bugs.webkit.org/show_bug.cgi?id=163013
2144
2145         Reviewed by Brent Fulgham.
2146
2147         Make it possible for a WebKit client to use separate preferences and cache.
2148
2149         * Interfaces/IWebPreferencesPrivate.idl:
2150         * WebApplicationCache.cpp:
2151         (applicationCachePath):
2152         * WebCache.cpp:
2153         (WebCache::cacheFolder):
2154         (WebCache::setCacheFolder):
2155         * WebDatabaseManager.cpp:
2156         (databasesDirectory):
2157         * WebPreferences.cpp:
2158         (WebPreferences::applicationId):
2159         (WebPreferences::valueForKey):
2160         (WebPreferences::setValueForKey):
2161         (WebPreferences::save):
2162         (WebPreferences::QueryInterface):
2163         (WebPreferences::modernMediaControlsEnabled):
2164         (WebPreferences::setApplicationId):
2165         * WebPreferences.h:
2166         * WebView.cpp:
2167         (WebView::setCacheModel):
2168
2169 2016-10-11  Alex Christensen  <achristensen@webkit.org>
2170
2171         Remove dead networking code
2172         https://bugs.webkit.org/show_bug.cgi?id=163263
2173
2174         Reviewed by Daniel Bates.
2175
2176         * DefaultDownloadDelegate.h:
2177         * WebCoreSupport/WebFrameLoaderClient.cpp:
2178         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2179         * WebCoreSupport/WebFrameNetworkingContext.cpp:
2180         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2181         * WebCoreSupport/WebFrameNetworkingContext.h:
2182         * WebCoreSupport/WebPlatformStrategies.cpp:
2183         * WebDownload.h:
2184         * WebError.cpp:
2185         (WebError::localizedDescription):
2186         (WebError::sslPeerCertificate):
2187         * WebError.h:
2188         * WebMutableURLRequest.cpp:
2189         (WebMutableURLRequest::mutableCopy):
2190         * WebURLAuthenticationChallenge.cpp:
2191         (WebURLAuthenticationChallenge::initWithProtectionSpace):
2192         (WebURLAuthenticationChallenge::initWithAuthenticationChallenge):
2193         * WebURLResponse.cpp:
2194         (WebURLResponse::sslPeerCertificate):
2195         * WebURLResponse.h:
2196         * WebView.cpp:
2197         (WebView::setCacheModel):
2198         (WebView::canHandleRequest):
2199         (WebView::notifyPreferencesChanged):
2200         (updateSharedSettingsFromPreferencesIfNeeded):
2201
2202 2016-10-11  Ryan Haddad  <ryanhaddad@apple.com>
2203
2204         Unreviewed, rolling out r207067.
2205
2206         This change caused webkitpy test failures.
2207
2208         Reverted changeset:
2209
2210         "[Win] Parallel DRTs are sharing preferences and cache."
2211         https://bugs.webkit.org/show_bug.cgi?id=163013
2212         http://trac.webkit.org/changeset/207067
2213
2214 2016-10-11  Per Arne Vollan  <pvollan@apple.com>
2215
2216         [Win] Parallel DRTs are sharing preferences and cache.
2217         https://bugs.webkit.org/show_bug.cgi?id=163013
2218
2219         Reviewed by Brent Fulgham.
2220
2221         Make it possible for a WebKit client to use separate preferences and cache.
2222
2223         * Interfaces/IWebPreferencesPrivate.idl:
2224         * WebApplicationCache.cpp:
2225         (applicationCachePath):
2226         * WebCache.cpp:
2227         (WebCache::cacheFolder):
2228         (WebCache::setCacheFolder):
2229         * WebDatabaseManager.cpp:
2230         (databasesDirectory):
2231         * WebPreferences.cpp:
2232         (WebPreferences::applicationId):
2233         (WebPreferences::valueForKey):
2234         (WebPreferences::setValueForKey):
2235         (WebPreferences::save):
2236         (WebPreferences::QueryInterface):
2237         (WebPreferences::modernMediaControlsEnabled):
2238         (WebPreferences::setApplicationId):
2239         * WebPreferences.h:
2240         * WebView.cpp:
2241         (WebView::setCacheModel):
2242
2243 2016-10-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2244
2245         Support InputEvent.inputType for the new InputEvent spec
2246         https://bugs.webkit.org/show_bug.cgi?id=163025
2247         <rdar://problem/28658092>
2248
2249         Reviewed by Darin Adler.
2250
2251         * WebCoreSupport/WebEditorClient.cpp:
2252         (undoNameForEditAction):
2253
2254 2016-10-04  Brent Fulgham  <bfulgham@apple.com>
2255
2256         [Win][Direct2D] Connect WebCore/WebKit Drawing
2257         https://bugs.webkit.org/show_bug.cgi?id=162924
2258
2259         Reviewed by Alex Christensen.
2260
2261         Update the Windows WebKit layer to optionally use the Direct2D
2262         backend.
2263
2264         * FullscreenVideoController.cpp: Disable some CoreAnimation-based
2265         accelerated compositing logic.
2266         * FullscreenVideoController.h:
2267         * WebFrame.cpp:
2268         (WebFrame::spoolPages): Disable in Direct2D.
2269         * WebView.cpp:
2270         (WebView::ensureBackingStore): Add Direct2D logic.
2271         (WebView::scrollBackingStore): Ditto.
2272         (WebView::sizeChanged): Ditto.
2273         (WebView::paintWithDirect2D): Added.
2274         (WebView::WebViewWndProc): Call Direct2D paint routine.
2275         * WebView.h:
2276
2277 2016-10-02  Darin Adler  <darin@apple.com>
2278
2279         Rename ExceptionCode-based exception handling to "legacy"
2280         https://bugs.webkit.org/show_bug.cgi?id=162859
2281
2282         Reviewed by Chris Dumez.
2283
2284         * Interfaces/DOMEvents.idl: Let the script rename here (in a comment).
2285
2286 2016-09-29  Konstantin Tokarev  <annulen@yandex.ru>
2287
2288         Fixed compilation of PluginView when NETSCAPE_PLUGIN_API is disabled
2289         https://bugs.webkit.org/show_bug.cgi?id=162725
2290
2291         Reviewed by Alex Christensen.
2292
2293         Fix for r206460, streamDidFinishLoading() does not override anything
2294         when NETSCAPE_PLUGIN_API is disabled because PlugivView does not
2295         inherit PluginStreamClient in this case.
2296
2297         * Plugins/PluginView.h:
2298
2299 2016-09-27  Konstantin Tokarev  <annulen@yandex.ru>
2300
2301         Use override specifiers in PluginView
2302         https://bugs.webkit.org/show_bug.cgi?id=162628
2303
2304         Reviewed by Alex Christensen.
2305
2306         * Plugins/PluginView.h:
2307
2308 2016-09-23  Antoine Quint  <graouts@apple.com>
2309
2310         Add a new runtime flag for work on modern media controls (off by default)
2311         https://bugs.webkit.org/show_bug.cgi?id=162420
2312         <rdar://problem/27989489>
2313
2314         Reviewed by Eric Carlson.
2315
2316         * Interfaces/IWebPreferencesPrivate.idl:
2317         * WebPreferenceKeysPrivate.h:
2318         * WebPreferences.cpp:
2319         (WebPreferences::setModernMediaControlsEnabled):
2320         (WebPreferences::modernMediaControlsEnabled):
2321         (WebPreferences::setCustomElementsEnabled): Deleted.
2322         * WebPreferences.h:
2323         * WebView.cpp:
2324         (WebView::notifyPreferencesChanged):
2325
2326 2016-09-15  Brady Eidson  <beidson@apple.com>
2327
2328         WKWebView.hasOnlySecureContent always returns "YES" after going back to a CachedPage (even if it has http resources).
2329         <rdar://problem/27681261> and https://bugs.webkit.org/show_bug.cgi?id=162043
2330
2331         Reviewed by Brent Fulgham. 
2332
2333         * WebCoreSupport/WebFrameLoaderClient.cpp:
2334         (WebFrameLoaderClient::dispatchDidCommitLoad):
2335         * WebCoreSupport/WebFrameLoaderClient.h:
2336
2337 2016-09-07  Mark Lam  <mark.lam@apple.com>
2338
2339         Add CatchScope and force all exception checks to be via ThrowScope or CatchScope.
2340         https://bugs.webkit.org/show_bug.cgi?id=161498
2341
2342         Reviewed by Geoffrey Garen.
2343
2344         * Plugins/PluginPackage.cpp:
2345         (WebCore::NPN_Evaluate):
2346         (WebCore::NPN_Invoke):
2347
2348 2016-09-06  Per Arne Vollan  <pvollan@apple.com>
2349
2350         [Win] Null pointer crash under WebView::scrollOffset.
2351         https://bugs.webkit.org/show_bug.cgi?id=161620
2352
2353         Reviewed by Darin Adler.
2354
2355         Added null pointer checks.
2356
2357         * WebView.cpp:
2358         (WebView::scrollOffset):
2359         (WebView::scrollBy):
2360         (WebView::visibleContentRect):
2361
2362 2016-09-03  Darin Adler  <darin@apple.com>
2363
2364         Streamline DOMImplementation, and move it to our new DOM exception system
2365         https://bugs.webkit.org/show_bug.cgi?id=161295
2366
2367         Reviewed by Ryosuke Niwa.
2368
2369         * WebFrame.cpp:
2370         (WebFrame::canProvideDocumentSource): Updated to use isXMLMIMEType in its new
2371         location in MIMETypeRegistry instead of in DOMImplementation.
2372
2373 2016-09-02  Ryosuke Niwa  <rniwa@webkit.org>
2374
2375         Build fix attempt after r205381.
2376
2377         * WebCoreSupport/WebEditorClient.h:
2378
2379 2016-08-31  Keith Rollin  <krollin@apple.com>
2380
2381         WebKit should set a subsystem for os_log so it's easier to filter for WebKit log messages
2382         https://bugs.webkit.org/show_bug.cgi?id=160969
2383         <rdar://problem/26068734>
2384
2385         Reviewed by Simon Fraser.
2386
2387         Enable subsystem- and channel-related data and functions when using
2388         RELEASE_LOG macros. Use the DECLARE_LOG_CHANNEL, DEFINE_LOG_CHANNEL,
2389         and LOG_CHANNEL_ADDRESS macros that are now defined in WTF.
2390
2391         * WebKitLogging.cpp:
2392         * WebKitLogging.h:
2393         * WebView.cpp:
2394         (WebView::initWithFrame):
2395
2396 2016-08-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2397
2398         [GTK] Accelerated compositing does not work in Wayland
2399         https://bugs.webkit.org/show_bug.cgi?id=115803
2400
2401         Reviewed by Michael Catanzaro.
2402
2403         Update to the new GLContext API.
2404
2405         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2406         (AcceleratedCompositingContext::initialize):
2407         (AcceleratedCompositingContext::acceleratedCompositingAvailable):
2408
2409 2016-08-21  Alex Christensen  <achristensen@webkit.org>
2410
2411         Use Document& instead of Document* when getting cookies
2412         https://bugs.webkit.org/show_bug.cgi?id=161011
2413
2414         Reviewed by Darin Adler.
2415
2416         * Plugins/PluginView.cpp:
2417         (WebCore::PluginView::getValueForURL):
2418
2419 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
2420
2421         Rename didLayout(LayoutMilestones) to didReachLayoutMilestone(), and related WK2 functions
2422         https://bugs.webkit.org/show_bug.cgi?id=160923
2423
2424         Reviewed by Tim Horton.
2425
2426         didLayout(LayoutMilestones) -> didReachLayoutMilestone(LayoutMilestones)
2427         dispatchDidLayout(LayoutMilestones) -> dispatchDidReachLayoutMilestone(LayoutMilestones)
2428
2429         * WebCoreSupport/WebFrameLoaderClient.cpp:
2430         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2431         (WebFrameLoaderClient::dispatchDidLayout): Deleted.
2432         * WebCoreSupport/WebFrameLoaderClient.h:
2433
2434 2016-08-18  Anders Carlsson  <andersca@apple.com>
2435
2436         Move an NPAPI-only function from WebCore to WebKit
2437         https://bugs.webkit.org/show_bug.cgi?id=160967
2438
2439         Reviewed by Sam Weinig.
2440
2441         * Plugins/PluginView.cpp:
2442         (WebCore::PluginView::~PluginView):
2443         (WebCore::PluginView::PluginView):
2444         (WebCore::PluginView::getValue):
2445         * Plugins/PluginView.h:
2446
2447 2016-08-15  Joseph Pecoraro  <pecoraro@apple.com>
2448
2449         Remove unused includes of wtf headers
2450         https://bugs.webkit.org/show_bug.cgi?id=160839
2451
2452         Reviewed by Alex Christensen.
2453
2454         * WebFrame.h:
2455
2456 2016-08-09  Alex Christensen  <achristensen@webkit.org>
2457
2458         Move NetworkStorageSession management to WebCore
2459         https://bugs.webkit.org/show_bug.cgi?id=160173
2460
2461         Reviewed by Brady Eidson.
2462
2463         * WebCoreSupport/WebFrameNetworkingContext.cpp:
2464         (identifierBase):
2465         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
2466         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2467         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
2468         (WebFrameNetworkingContext::blockedError):
2469         (WebFrameNetworkingContext::storageSession):
2470         (privateSession): Deleted.
2471         * WebCoreSupport/WebPlatformStrategies.cpp:
2472         (WebPlatformStrategies::createPasteboardStrategy):
2473         (WebPlatformStrategies::createBlobRegistry):
2474
2475 2016-08-09  Anders Carlsson  <andersca@apple.com>
2476
2477         Instantiate WebKit plug-ins at layout time, instead of at style resolution time
2478         https://bugs.webkit.org/show_bug.cgi?id=160715
2479
2480         Reviewed by Tim Horton.
2481
2482         * WebCoreSupport/WebFrameLoaderClient.cpp:
2483         (WebFrameLoaderClient::objectContentType):
2484
2485 2016-08-09  Per Arne Vollan  <pvollan@apple.com>
2486
2487         [Win] Crash in MiniBrowser.
2488         https://bugs.webkit.org/show_bug.cgi?id=160686
2489
2490         Reviewed by Sam Weinig.
2491
2492         We need to specify a plugin info provider object in the page configuration.
2493
2494         * WebView.cpp:
2495         (WebView::initWithFrame):
2496
2497 2016-08-09  Anders Carlsson  <andersca@apple.com>
2498
2499         Fix build.
2500
2501         * WebCoreSupport/WebPlatformStrategies.h:
2502
2503 2016-08-09  Anders Carlsson  <andersca@apple.com>
2504
2505         Get rid of PluginStrategy
2506         https://bugs.webkit.org/show_bug.cgi?id=160696
2507
2508         Reviewed by Dan Bernstein.
2509
2510         * WebCoreSupport/WebPlatformStrategies.cpp:
2511         (WebPlatformStrategies::createPluginStrategy): Deleted.
2512
2513 2016-08-09  Anders Carlsson  <andersca@apple.com>
2514
2515         Move plug-in enumeration from WebPlatformStrategies to WebPluginInfoProvider
2516         https://bugs.webkit.org/show_bug.cgi?id=160694
2517
2518         Reviewed by Dan Bernstein.
2519
2520         * WebCoreSupport/WebPlatformStrategies.cpp:
2521         (WebPlatformStrategies::createPluginStrategy):
2522         (WebPlatformStrategies::refreshPlugins): Deleted.
2523         (WebPlatformStrategies::getPluginInfo): Deleted.
2524         (WebPlatformStrategies::getWebVisiblePluginInfo): Deleted.
2525         * WebCoreSupport/WebPlatformStrategies.h:
2526         * WebCoreSupport/WebPluginInfoProvider.cpp:
2527         (WebPluginInfoProvider::refreshPlugins):
2528         (WebPluginInfoProvider::getPluginInfo):
2529         (WebPluginInfoProvider::getWebVisiblePluginInfo):
2530
2531 2016-08-08  Anders Carlsson  <andersca@apple.com>
2532
2533         Add a new PluginInfoProvider class, to replace PluginStrategy
2534         https://bugs.webkit.org/show_bug.cgi?id=160670
2535
2536         Reviewed by Sam Weinig.
2537
2538         Add a new WebPluginInfoProvider - it just calls through to the plug-in strategy for now.
2539
2540         * WebCoreSupport/WebPluginInfoProvider.cpp: Added.
2541         (WebPluginInfoProvider::singleton):
2542         (WebPluginInfoProvider::WebPluginInfoProvider):
2543         (WebPluginInfoProvider::~WebPluginInfoProvider):
2544         (WebPluginInfoProvider::refreshPlugins):
2545         (WebPluginInfoProvider::getPluginInfo):
2546         (WebPluginInfoProvider::getWebVisiblePluginInfo):
2547         * WebCoreSupport/WebPluginInfoProvider.h: Added.
2548
2549 2016-07-29  Csaba Osztrogon√°c  <ossy@webkit.org>
2550
2551         Remove PassRef.h after r177259
2552         https://bugs.webkit.org/show_bug.cgi?id=160348
2553
2554         Reviewed by Andreas Kling.
2555
2556         * WebCoreSupport/WebVisitedLinkStore.h:
2557
2558 2016-07-27  Alex Christensen  <achristensen@webkit.org>
2559
2560         Fix Win debug build after r203749.
2561
2562         * WebView.cpp:
2563
2564 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
2565
2566         Allow LOG macros to be used outside the namespace, and other logging cleanup
2567         https://bugs.webkit.org/show_bug.cgi?id=160216
2568
2569         Reviewed by Anders Carlsson.
2570
2571         Fix some issues with the LOG macros.
2572         
2573         First, they were not usable outside the WebKit namespace in WebKit2 code. Fix by moving
2574         its log channels outside of the namespace (they are protected by a unique prefix anyway).
2575         
2576         Second, allow LOG_WITH_STREAM to be used in WebKit2 by moving that and a helper macro
2577         into LogMacros.h, which is exported from WebCore as a private header.
2578         
2579         Third, split the Logging.h header into two. Logging.h remains for framework-internal
2580         log channels and log macros. Add LogInitialization.h which is external, and used to
2581         initialize the channels.
2582         
2583         Finally unify "initializeLogChannels" and "initializeLoggingChannels" terminology everywhere.
2584
2585         * WebKitLogging.cpp:
2586         * WebKitLogging.h:
2587         * WebView.cpp:
2588         (WebView::initWithFrame):
2589
2590 2016-07-23  Chris Dumez  <cdumez@apple.com>
2591
2592         Unreviewed, fix Windows build after r203623.
2593
2594         * DOMCoreClasses.cpp:
2595         (DOMDocument::getComputedStyle):
2596
2597 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
2598
2599         IWebView::mainFrame crashes if called after IWebView::close
2600         https://bugs.webkit.org/show_bug.cgi?id=32868
2601
2602         Reviewed by Brent Fulgham.
2603
2604         After deleting the page in WebView::close the mainframe object may be deleted. 
2605          
2606         Test: Tools/TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp (CloseThenGetMainFrame).
2607
2608         * WebView.cpp:
2609         (WebView::close): set mainframe pointer member to null. 
2610
2611 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
2612
2613         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
2614         https://bugs.webkit.org/show_bug.cgi?id=159342
2615
2616         Reviewed by Darin Adler.
2617
2618         * WebFrame.h: Link fix. 
2619
2620 2016-07-17  Sam Weinig  <sam@webkit.org>
2621
2622         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
2623         <rdar://problem/26554137>
2624         https://bugs.webkit.org/show_bug.cgi?id=159856
2625
2626         Reviewed by Dan Bernstein.
2627
2628         * Plugins/PluginView.cpp:
2629         (WebCore::PluginView::performRequest):
2630         * WebCoreSupport/WebContextMenuClient.cpp:
2631         (WebContextMenuClient::searchWithGoogle):
2632         Update for new UserGestureIndicator interface.
2633
2634 2016-07-16  Ryosuke Niwa  <rniwa@webkit.org>
2635
2636         Rename fastGetAttribute to attributeWithoutSynchronization
2637         https://bugs.webkit.org/show_bug.cgi?id=159852
2638
2639         Reviewed by Darin Adler.
2640
2641         * DOMHTMLClasses.cpp:
2642         (DOMHTMLElement::idName):
2643
2644 2016-07-15  Chris Dumez  <cdumez@apple.com>
2645
2646         Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible
2647         https://bugs.webkit.org/show_bug.cgi?id=159793
2648
2649         Reviewed by Ryosuke Niwa.
2650
2651         Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible, for performance.
2652
2653         * DOMHTMLClasses.cpp:
2654         (DOMHTMLElement::idName):
2655
2656 2016-07-14  Chris Dumez  <cdumez@apple.com>
2657
2658         Use emptyString() instead of "" when possible
2659         https://bugs.webkit.org/show_bug.cgi?id=159789
2660
2661         Reviewed by Alex Christensen.
2662
2663         Use emptyString() instead of "" when possible to reduce String allocations.
2664
2665         * Plugins/PluginView.cpp:
2666         (WebCore::parseRFC822HeaderFields):
2667
2668 2016-07-14  Alex Christensen  <achristensen@webkit.org>
2669
2670         Use SocketProvider to create SocketStreamHandles
2671         https://bugs.webkit.org/show_bug.cgi?id=159774
2672
2673         Reviewed by Brady Eidson.
2674
2675         * WebSocketProvider.cpp: Removed.
2676         * WebSocketProvider.h: Removed.
2677         * WebView.cpp: Replaced WebSocketProvider with SocketProvider as we did in WebCore.
2678
2679 2016-07-14  Csaba Osztrogon√°c  <ossy@webkit.org>
2680
2681         Fix the !ENABLE(WEB_SOCKETS) build after r202930
2682         https://bugs.webkit.org/show_bug.cgi?id=159768
2683
2684         Reviewed by Alex Christensen.
2685
2686         * WebSocketProvider.h:
2687
2688 2016-07-11  Enrica Casucci  <enrica@apple.com>
2689
2690         Build fix.
2691
2692         Unreviewed.
2693
2694         * WebDropSource.cpp:
2695         (generateMouseEvent):
2696
2697 2016-07-11  Enrica Casucci  <enrica@apple.com>
2698
2699         Add synthetic click origin to WKNavigationAction.
2700         https://bugs.webkit.org/show_bug.cgi?id=159584
2701         rdar://problem/25610422
2702
2703         Reviewed by Tim Horton.
2704
2705         * WebDropSource.cpp:
2706         (generateMouseEvent):
2707
2708 2016-07-07  Alex Christensen  <achristensen@webkit.org>
2709
2710         Fix Windows build after r202930.
2711         https://bugs.webkit.org/show_bug.cgi?id=158776
2712
2713         * WebView.cpp:
2714         (WebView::initWithFrame):
2715
2716 2016-07-07  Alex Christensen  <achristensen@webkit.org>
2717
2718         Use SocketProvider to create WebSocketChannels
2719         https://bugs.webkit.org/show_bug.cgi?id=158776
2720
2721         Reviewed by Brent Fulgham.
2722
2723         * WebSocketProvider.cpp: Copied from Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp.
2724         (WebSocketProvider::createWebSocketChannel):
2725         (WebCore::ThreadableWebSocketChannel::create): Deleted.
2726         * WebSocketProvider.h:
2727
2728 2016-07-06  Per Arne Vollan  <pvollan@apple.com>
2729
2730         [Win] Add null pointer check in gesture handling.
2731         https://bugs.webkit.org/show_bug.cgi?id=159454
2732
2733         Reviewed by Brent Fulgham.
2734
2735         * WebView.cpp:
2736         (WebView::gesture):
2737
2738 2016-07-01  Per Arne Vollan  <pvollan@apple.com>
2739
2740         ASSERTION FAILED: info.bmBitsPixel == 32
2741         https://bugs.webkit.org/show_bug.cgi?id=17737
2742
2743         Reviewed by Brent Fulgham.
2744
2745         The ::SelectObject call will fail if m_backingStoreBitmap is already selected into a device context.
2746         This happens when this method is called indirectly from WebView::updateBackingStore during normal
2747         painting. There is no point continuing, since we would just be scrolling a 1x1 bitmap which is
2748         selected into the device context by default. We can just scroll by repainting the scroll rectangle.
2749
2750         * WebView.cpp:
2751         (WebView::scrollBackingStore): Invalidate the scroll rectangle if the ::SelectObject call fails.
2752
2753 2016-07-01  Youenn Fablet  <youennf@gmail.com>
2754
2755         Add a runtime flag for DOM iterators
2756         https://bugs.webkit.org/show_bug.cgi?id=159300
2757
2758         Reviewed by Alex Christensen.
2759
2760         * WebPreferenceKeysPrivate.h:
2761         * WebPreferences.cpp:
2762         (WebPreferences::domIteratorEnabled):
2763         (WebPreferences::setDOMIteratorEnabled):
2764         (WebView::notifyPreferencesChanged):
2765         * WebPreferencesreferences.h:
2766         * WebView.cpp:
2767         (WebView::notifyPreferencesChanged):
2768
2769 2016-06-28  Per Arne Vollan  <pvollan@apple.com>
2770
2771         [Win] Custom elements tests are failing.
2772         https://bugs.webkit.org/show_bug.cgi?id=159139
2773
2774         Reviewed by Alex Christensen.
2775
2776         Add preference for enabling custom element API.
2777
2778         * Interfaces/IWebPreferencesPrivate.idl:
2779         * WebPreferenceKeysPrivate.h:
2780         * WebPreferences.cpp:
2781         (WebPreferences::initializeDefaultSettings):
2782         (WebPreferences::customElementsEnabled):
2783         (WebPreferences::setCustomElementsEnabled):
2784         * WebPreferences.h:
2785         * WebView.cpp:
2786         (WebView::notifyPreferencesChanged):
2787
2788 2016-06-23  Per Arne Vollan  <pvollan@apple.com>
2789
2790         [Win] The test accessibility/aria-labelledby-overrides-label.html is failing.
2791         https://bugs.webkit.org/show_bug.cgi?id=159057
2792
2793         Reviewed by Brent Fulgham.
2794
2795         The test expects the label to have a static text role, but currently it has a
2796         group role.
2797  
2798         * AccessibleBase.cpp:
2799         (MSAARole): Change the role of labels to static text.
2800
2801 2016-06-23  Alex Christensen  <achristensen@webkit.org>
2802
2803         Remove unused didCancelAuthenticationChallenge
2804         https://bugs.webkit.org/show_bug.cgi?id=158819
2805
2806         Reviewed by David Kilzer.
2807
2808         * WebCoreSupport/WebFrameLoaderClient.cpp:
2809         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): Deleted.
2810         * WebCoreSupport/WebFrameLoaderClient.h:
2811
2812 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
2813
2814         [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
2815         https://bugs.webkit.org/show_bug.cgi?id=158934
2816
2817         Reviewed by Brent Fulgham.
2818
2819         Add a method to delete all indexed databases.
2820
2821         * Interfaces/IWebDatabaseManager.idl:
2822         * WebDatabaseManager.cpp:
2823         (WebDatabaseManager::QueryInterface):
2824         (WebDatabaseManager::deleteAllIndexedDatabases):
2825         * WebDatabaseManager.h:
2826
2827 2016-06-17  Per Arne Vollan  <pvollan@apple.com>
2828
2829         [Win] Rendering is not scaled correctly if process is DPI aware.
2830         https://bugs.webkit.org/show_bug.cgi?id=158781
2831
2832         Reviewed by Brent Fulgham.
2833
2834         Scale the root graphics layer with the device scale factor.
2835
2836         * WebView.cpp:
2837         (WebView::setAcceleratedCompositing):
2838
2839 2016-06-15  Chris Dumez  <cdumez@apple.com>
2840
2841         Drop some unnecessary header includes
2842         https://bugs.webkit.org/show_bug.cgi?id=158788
2843
2844         Reviewed by Alexey Proskuryakov.
2845
2846         Drop some unnecessary header includes in headers to speed up build time.
2847
2848         * Plugins/PluginView.cpp:
2849
2850 2016-06-15  Romain Bellessort  <romain.bellessort@crf.canon.fr>
2851
2852         Enabling Shadow DOM for all platforms
2853         https://bugs.webkit.org/show_bug.cgi?id=158738
2854
2855         Reviewed by Ryosuke Niwa.
2856
2857         Removed Shadow DOM from options (enabled by default)
2858         (comprises removal of corresponding preprocessor directives)
2859
2860         * WebView.cpp:
2861
2862 2016-06-13  Alex Christensen  <achristensen@webkit.org>
2863
2864         Add WebSocketProvider stub
2865         https://bugs.webkit.org/show_bug.cgi?id=158702
2866
2867         Reviewed by Brady Eidson.
2868
2869         * WebSocketProvider.h: Added.
2870         * WebView.cpp:
2871         (WebView::initWithFrame):
2872
2873 2016-06-10  Alex Christensen  <achristensen@webkit.org>
2874
2875         Introduce WTF::UniqueRef
2876         https://bugs.webkit.org/show_bug.cgi?id=158596
2877
2878         Reviewed by Brady Eidson.
2879
2880         * WebView.cpp:
2881         (WebView::initWithFrame):
2882
2883 2016-06-09  Alex Christensen  <achristensen@webkit.org>
2884
2885         Fix Windows build.
2886
2887         * WebKit.resources/resource.h: Removed.
2888         * resource.h: Copied from WebKit.resources/resource.h.
2889
2890 2016-06-09  Alex Christensen  <achristensen@webkit.org>
2891
2892         Actually fix Windows build after r201894
2893         https://bugs.webkit.org/show_bug.cgi?id=158588
2894
2895         * WebView.cpp:
2896         (WebView::initWithFrame):
2897
2898 2016-06-09  Alex Christensen  <achristensen@webkit.org>
2899
2900         Clean up WebKit.vcxproj directory after switching to CMake.
2901
2902         * WebKit.resources/resource.h: Copied from WebKit.vcxproj/WebKit/resource.h.
2903
2904 2016-06-09  Alex Christensen  <achristensen@webkit.org>
2905
2906         Unreviewed build fix after r201894
2907         https://bugs.webkit.org/show_bug.cgi?id=158588
2908
2909         * WebCoreSupport/WebEditorClient.cpp:
2910         (WebEditorClient::~WebEditorClient):
2911         (WebEditorClient::isContinuousSpellCheckingEnabled):
2912         (WebEditorClient::pageDestroyed): Deleted.
2913         * WebCoreSupport/WebEditorClient.h:
2914         * WebView.cpp:
2915         (WebView::initWithFrame):
2916
2917 2016-06-08  Per Arne Vollan  <pvollan@apple.com>
2918
2919         [Win] Shadow DOM tests are failing.
2920         https://bugs.webkit.org/show_bug.cgi?id=158524
2921
2922         Reviewed by Brent Fulgham.
2923
2924         Add preference for enabling Shadow DOM.
2925
2926         * Interfaces/IWebPreferencesPrivate.idl:
2927         * WebPreferenceKeysPrivate.h:
2928         * WebPreferences.cpp:
2929         (WebPreferences::initializeDefaultSettings):
2930         (WebPreferences::shadowDOMEnabled):
2931         (WebPreferences::setShadowDOMEnabled):
2932         * WebPreferences.h:
2933         * WebView.cpp:
2934         (WebView::notifyPreferencesChanged):
2935
2936 2016-06-07  Per Arne Vollan  <pvollan@apple.com>
2937
2938         [Win][IndexedDB] Crash when running worker test.
2939         https://bugs.webkit.org/show_bug.cgi?id=158434
2940
2941         Reviewed by Alex Christensen.
2942
2943         Initialize main runloop, otherwise RunLoop::main() will return nullptr.
2944
2945         * WebView.cpp:
2946         (WebView::WebView):
2947
2948 2016-06-03  Chris Dumez  <cdumez@apple.com>
2949
2950         Unreviewed, roll out r196633 as it broke PageCache on iOS for WebKit.org
2951         <rdar://problem/26521101>
2952
2953         * WebCoreSupport/WebVisitedLinkStore.cpp:
2954         (WebVisitedLinkStore::removeAllVisitedLinks):
2955         (WebVisitedLinkStore::addVisitedLinkHash):
2956
2957 2016-06-03  Per Arne Vollan  <pvollan@apple.com>
2958
2959         [Win] Implement WebView::removeAllUserContentFromGroup
2960         https://bugs.webkit.org/show_bug.cgi?id=158343
2961
2962         Reviewed by Brent Fulgham.
2963
2964         * WebView.cpp:
2965         (WebView::removeAllUserContentFromGroup):
2966
2967 2016-06-02  Per Arne Vollan  <pvollan@apple.com>
2968
2969         [Win] Fetch API tests are failing.
2970         https://bugs.webkit.org/show_bug.cgi?id=158296
2971
2972         Reviewed by Alex Christensen.
2973
2974         Add preference for enabling Fetch API.
2975
2976         * Interfaces/IWebPreferencesPrivate.idl:
2977         * WebPreferenceKeysPrivate.h:
2978         * WebPreferences.cpp:
2979         (WebPreferences::initializeDefaultSettings):
2980         (WebPreferences::fetchAPIEnabled):
2981         (WebPreferences::setFetchAPIEnabled):
2982         * WebPreferences.h:
2983         * WebView.cpp:
2984         (WebView::notifyPreferencesChanged):
2985
2986 2016-06-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2987
2988         Use more references in ResourceLoader related code
2989         https://bugs.webkit.org/show_bug.cgi?id=158222
2990
2991         Reviewed by Darin Adler.
2992
2993         * Plugins/PluginStream.cpp:
2994         (WebCore::PluginStream::start):
2995
2996 2016-06-01  Per Arne Vollan  <pvollan@apple.com>
2997
2998         [Win] Potential null pointer crash when setting cursor.
2999         https://bugs.webkit.org/show_bug.cgi?id=158225
3000
3001         Reviewed by Alex Christensen.
3002
3003         Check return value of Cursor::platformCursor().
3004
3005         * WebCoreSupport/WebChromeClient.cpp:
3006         (WebChromeClient::setCursor):
3007
3008 2016-05-31  Yusuke Suzuki  <utatane.tea@gmail.com>
3009
3010         Unreviewed, roll out r201481, r201523: 0.3% regression in Octane code-load
3011         https://bugs.webkit.org/show_bug.cgi?id=158249
3012
3013         * Interfaces/IWebPreferencesPrivate.idl:
3014
3015 2016-05-27  Caitlin Potter  <caitp@igalia.com>
3016
3017         [JSC] implement async functions proposal
3018         https://bugs.webkit.org/show_bug.cgi?id=156147
3019
3020         Reviewed by Yusuke Suzuki.
3021
3022         * Interfaces/IWebPreferencesPrivate.idl:
3023
3024 2016-05-23  Chris Dumez  <cdumez@apple.com>
3025
3026         Generate bindings code for EventTarget.addEventListener() / removeEventListener()
3027         https://bugs.webkit.org/show_bug.cgi?id=157882
3028
3029         Reviewed by Darin Adler.
3030
3031         Generate bindings code for EventTarget.addEventListener() / removeEventListener()
3032         instead of hardcoding them in the bindings generator.
3033
3034         * DOMEventsClasses.cpp:
3035         (WebEventListener::operator==):
3036         * DOMEventsClasses.h:
3037
3038 2016-05-20  Joseph Pecoraro  <pecoraro@apple.com>
3039
3040         Remove LegacyProfiler
3041         https://bugs.webkit.org/show_bug.cgi?id=153565
3042
3043         Reviewed by Saam Barati.
3044
3045         * Interfaces/IWebInspector.idl:
3046         * WebCoreStatistics.cpp:
3047         * WebInspector.cpp:
3048         (WebInspector::isJavaScriptProfilingEnabled): Deleted.
3049         (WebInspector::setJavaScriptProfilingEnabled): Deleted.
3050         * WebInspector.h:
3051         * WebView.cpp:
3052
3053 2016-05-16  Joseph Pecoraro  <pecoraro@apple.com>
3054
3055         Unreviewed rollout r200924. Caused js/regress/string-replace-generic.html to fail.
3056
3057         * Interfaces/IWebInspector.idl:
3058         * WebCoreStatistics.cpp:
3059         * WebInspector.cpp:
3060         (WebInspector::isJavaScriptProfilingEnabled):
3061         (WebInspector::setJavaScriptProfilingEnabled):
3062         * WebInspector.h:
3063         * WebView.cpp:
3064
3065 2016-05-14  Joseph Pecoraro  <pecoraro@apple.com>
3066
3067         Remove LegacyProfiler
3068         https://bugs.webkit.org/show_bug.cgi?id=153565
3069
3070         Reviewed by Mark Lam.
3071
3072         * Interfaces/IWebInspector.idl:
3073         * WebView.cpp:
3074         * WebInspector.cpp:
3075         (WebInspector::isJavaScriptProfilingEnabled): Deleted.
3076         (WebInspector::setJavaScriptProfilingEnabled): Deleted.
3077         * WebInspector.h:
3078
3079 2016-05-12  Konstantin Tokarev  <annulen@yandex.ru>
3080
3081         Use reference instead of pointer in FrameLoaderClient::saveViewStateToItem.
3082         https://bugs.webkit.org/show_bug.cgi?id=157624
3083
3084         Reviewed by Darin Adler.
3085
3086         * WebCoreSupport/WebFrameLoaderClient.cpp:
3087         (WebFrameLoaderClient::saveViewStateToItem):
3088         * WebCoreSupport/WebFrameLoaderClient.h:
3089
3090 2016-05-11  Chris Dumez  <cdumez@apple.com>
3091
3092         Update Node::appendChild() / replaceChild() / removeChild() / insertBefore() to take references instead of pointers
3093         https://bugs.webkit.org/show_bug.cgi?id=157556
3094
3095         Reviewed by Darin Adler.
3096
3097         * DOMCoreClasses.cpp:
3098         (DOMNode::insertBefore):
3099         (DOMNode::removeChild):
3100
3101 2016-05-11  Joanmarie Diggs  <jdiggs@igalia.com>
3102
3103         [GTK] accessibility/aria-readonly.html is failing
3104         https://bugs.webkit.org/show_bug.cgi?id=98357
3105
3106         Reviewed by Chris Fleizach.
3107
3108         Call AccessibilityNode::canSetValueAttribute() to determine if STATE_SYSTEM_READONLY
3109         should be added and if editable text should be supported.
3110
3111         * AccessibleBase.cpp:
3112         (AccessibleBase::state):
3113         * AccessibleTextImpl.cpp:
3114         (AccessibleText::deleteText):
3115         (AccessibleText::insertText):
3116         (AccessibleText::cutText):
3117         (AccessibleText::pasteText):
3118         (AccessibleText::replaceText):
3119
3120 2016-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3121
3122         [wincairo] web inspector failed to launch in MiniBrowser
3123         https://bugs.webkit.org/show_bug.cgi?id=156184
3124         <rdar://problem/25539297>
3125
3126         Reviewed by Alex Christensen.
3127
3128         * WebCoreSupport/WebInspectorClient.cpp:
3129         (WebInspectorClient::openLocalFrontend): Enable
3130         AllowFileAccessFromFileURLs and AllowUniversalAccessFromFileURLs
3131         of WebPreferences for Web Inspector.
3132
3133 2016-05-06  Joseph Pecoraro  <pecoraro@apple.com>
3134
3135         Rename HitTestRequest DisallowShadowContent to DisallowUserAgentShadowContent
3136         https://bugs.webkit.org/show_bug.cgi?id=157447
3137
3138         Reviewed by Ryosuke Niwa.
3139
3140         * WebView.cpp:
3141         (WebView::gestureNotify):
3142
3143 2016-05-04  Joanmarie Diggs  <jdiggs@igalia.com>
3144
3145         AX: ARIA 'region' role is now a landmark; HTML 'section' element should be a landmark only if named
3146         https://bugs.webkit.org/show_bug.cgi?id=157331
3147
3148         Reviewed by Chris Fleizach.
3149
3150         As part of this change, the WebCore DocumentRegionRole AccessibilityRole has
3151         been renamed to LandmarkRegionRole. Update MSAARole() to use the new name.
3152
3153         * AccessibleBase.cpp:
3154         (MSAARole):
3155
3156 2016-04-25  Per Arne Vollan  <peavo@outlook.com>
3157
3158         [Win][IndexedDB] Fix build errors.
3159         https://bugs.webkit.org/show_bug.cgi?id=156713
3160
3161         Reviewed by Alex Christensen.
3162
3163         Fix compile and link errors when building with IndexedDB enabled.
3164
3165         * WebView.cpp:
3166         (WebView::notifyPreferencesChanged):
3167         * storage: Added.
3168         * storage/WebDatabaseProvider.cpp: Added.
3169         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
3170
3171 2016-04-22  Brent Fulgham  <bfulgham@apple.com>
3172
3173         Unreviewed build fix after 4199841.
3174
3175         * WebApplicationCache.cpp:
3176         (WebApplicationCache::WebApplicationCache): Provide missing preference key definition.
3177
3178 2016-04-21  Anders Carlsson  <andersca@apple.com>
3179
3180         Add a missing space, as noticed by Darin.
3181
3182         * WebApplicationCache.cpp:
3183         (applicationCachePath):
3184
3185 2016-04-21  Anders Carlsson  <andersca@apple.com>
3186
3187         Stop using ApplicationCacheStorage::singleton() on Windows
3188         https://bugs.webkit.org/show_bug.cgi?id=156861
3189
3190         Reviewed by Darin Adler.
3191
3192         * WebApplicationCache.cpp:
3193         (applicationCachePath):
3194         (WebApplicationCache::storage):
3195         * WebApplicationCache.h:
3196         * WebCache.cpp:
3197         (WebCache::empty):
3198         * WebView.cpp:
3199         (WebView::initWithFrame):
3200         (WebKitSetApplicationCachePathIfNecessary): Deleted.
3201
3202 2016-04-15  Brent Fulgham  <bfulgham@apple.com>
3203
3204         CSP: Make dynamically-added favicons (via link rel="icon") obey Content-Security-Policy
3205         https://bugs.webkit.org/show_bug.cgi?id=153151
3206         <rdar://problem/24383176>
3207
3208         Reviewed by Darin Adler.
3209
3210         Remove the unused dynamic favicon code and tests.
3211
3212         * WebCoreSupport/WebFrameLoaderClient.cpp:
3213         (WebFrameLoaderClient::dispatchDidChangeIcons): Deleted.
3214         * WebCoreSupport/WebFrameLoaderClient.h:
3215
3216 2016-04-15  Darin Adler  <darin@apple.com>
3217
3218         Reduce use of Deprecated::ScriptXXX classes
3219         https://bugs.webkit.org/show_bug.cgi?id=156632
3220
3221         Reviewed by Alex Christensen.
3222
3223         * Plugins/PluginView.cpp:
3224         (WebCore::PluginView::performRequest): Use JSValue.
3225         * WebFrame.cpp:
3226         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld): Ditto.
3227         * WebView.cpp:
3228         (WebView::stringByEvaluatingJavaScriptFromString): Ditto.
3229
3230 2016-04-11  Darin Adler  <darin@apple.com>
3231
3232         Remove UsePointersEvenForNonNullableObjectArguments from HTMLSelectElement
3233         https://bugs.webkit.org/show_bug.cgi?id=156458
3234
3235         Reviewed by Chris Dumez.
3236
3237         * DOMCoreClasses.cpp: Added now-needed include.
3238
3239 2016-04-11  Gavin Barraclough  <barraclough@apple.com>
3240
3241         WebKit should adopt journal_mode=wal for all SQLite databases.
3242         https://bugs.webkit.org/show_bug.cgi?id=133496
3243
3244         Reviewed by Darin Adler.
3245
3246         * WebDatabaseManager.cpp:
3247         (WebDatabaseManager::deleteAllDatabases):
3248             - renamed deleteAllDatabases -> deleteAllDatabasesImmediately.
3249
3250 2016-04-08  Joanmarie Diggs  <jdiggs@igalia.com>
3251
3252         AX: "AXLandmarkApplication" is an inappropriate subrole for ARIA "application" since it's no longer a landmark
3253         https://bugs.webkit.org/show_bug.cgi?id=155403
3254
3255         Reviewed by Chris Fleizach.
3256
3257         The new subrole is AXWebApplication and the new role description is "web application".
3258         As part of the fix, the WebCore AccessibilityRole for ARIA's "application" role was
3259         renamed from LandmarkApplicationRole to WebApplicationRole.
3260
3261         The roles-exposed.html and aria-grouping-roles.html test expectations were also updated.
3262
3263         * AccessibleBase.cpp: Update the rolename
3264         (MSAARole):
3265
3266 2016-04-07  Brian Burg  <bburg@apple.com>
3267
3268         CookieJar should support adding synthetic cookies for developer tools
3269         https://bugs.webkit.org/show_bug.cgi?id=156091
3270         <rdar://problem/25581340>
3271
3272         Reviewed by Timothy Hatcher.
3273
3274         * WebCoreSupport/WebPlatformStrategies.h:
3275         * WebCoreSupport/WebPlatformStrategies.cpp:
3276         Add new method override.
3277
3278 2016-03-24  Said Abou-Hallawa  <sabouhallawa@apple,com>
3279
3280         Change NativeImagePtr for CG to be RetainPtr<CGImageRef>
3281         https://bugs.webkit.org/show_bug.cgi?id=155412
3282
3283         Reviewed by Darin Adler.
3284
3285         * Plugins/PluginView.h:
3286         * Plugins/PluginViewWin.cpp:
3287         (WebCore::PluginView::snapshot):
3288         Replace PassRefPtr with RefPtr.
3289
3290 2016-03-22  Per Arne Vollan  <peavo@outlook.com>
3291
3292         [Win] [64-bit] Remove MSVC 2013 FMA3 Bug Workaround
3293         https://bugs.webkit.org/show_bug.cgi?id=141499
3294
3295         Reviewed by Brent Fulgham.
3296
3297         As we have moved on to VS2015, this workaround is no longer needed.
3298
3299         * WebKitDLL.cpp:
3300         (DllMain):
3301
3302 2016-03-21  Hyungwook Lee  <hyungwook.lee@navercorp.com> 
3303
3304         [Win] Connect layoutTestController.findString() to support testing 
3305         https://bugs.webkit.org/show_bug.cgi?id=50234
3306
3307         Reviewed by Alex Christensen.
3308
3309         Implement WebView::findString to support testing efforts.
3310
3311         * Interfaces/IWebViewPrivate.idl: Add API declaration.
3312         * WebView.cpp:
3313         * WebView.h:
3314
3315 2016-03-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3316
3317         Unreviewed, rolling out r196951 and r197031.
3318
3319         Revert also WinCairo follow ups after r196803
3320
3321         Reverted changesets:
3322
3323         "[WinCairo] Compile fix."
3324         https://bugs.webkit.org/show_bug.cgi?id=154545
3325         http://trac.webkit.org/changeset/196951
3326
3327         "[WinCairo] Mark layer as non composited."
3328         https://bugs.webkit.org/show_bug.cgi?id=154640
3329         http://trac.webkit.org/changeset/197031
3330
3331 2016-03-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3332
3333         Unreviewed, rolling out r197693.
3334
3335         197031
3336
3337         Reverted changeset:
3338
3339         "[WinCairo][AcceleratedCompositing] Rendering issues on
3340         www.bbc.com."
3341         https://bugs.webkit.org/show_bug.cgi?id=154912
3342         http://trac.webkit.org/changeset/197693
3343
3344 2016-03-15  Brent Fulgham  <bfulgham@apple.com>
3345
3346         [Win] Correct double-release of CFURLConnectionRef
3347         https://bugs.webkit.org/show_bug.cgi?id=155515
3348         <rdar://problem/25159143>
3349
3350         Reviewed by Tim Horton.
3351
3352         Tested by http/tests/download suite.
3353
3354         * WebDownloadCFNet.cpp: Remove extra CFRelease.
3355
3356 2016-03-14  Per Arne Vollan  <peavo@outlook.com>
3357
3358         [WinCairo] Compile fix.
3359         https://bugs.webkit.org/show_bug.cgi?id=155463
3360
3361         Reviewed by Alex Christensen.
3362
3363         Get the NetworkStorageSession object from the document in the same way as other platforms do.
3364
3365         * WebCoreSupport/WebFrameNetworkingContext.cpp:
3366         (WebFrameNetworkingContext::storageSession):
3367         * WebCoreSupport/WebFrameNetworkingContext.h:
3368         (WebFrameNetworkingContext::storageSession):
3369
3370 2016-03-14  Joonghun Park  <jh718.park@samsung.com>
3371
3372         Purge PassRefPtr from ArrayBuffer, ArchiveResource, Pasteboard, LegacyWebArchive and DataObjectGtk
3373         https://bugs.webkit.org/show_bug.cgi?id=150497
3374
3375         Reviewed by Darin Adler.
3376
3377         * WebArchive.cpp:
3378         (WebArchive::initWithNode):
3379
3380 2016-03-12  Sam Weinig  <sam@webkit.org>
3381
3382         WebKit can easily crash below NetworkSession::dataTaskForIdentifier() with NSURLSession enabled
3383         <rdar://problem/25129946>
3384         https://bugs.webkit.org/show_bug.cgi?id=155401
3385
3386         Reviewed by Alex Christensen.
3387
3388         * WebCoreSupport/WebFrameNetworkingContext.cpp:
3389         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3390         Pass a SessionID to NetworkStorageSession::createPrivateBrowsingSession().
3391
3392 2016-03-10  Jer Noble  <jer.noble@apple.com>
3393
3394         Unreviewed build fix after r197953; correct the settings added in r197953.
3395
3396         * WebView.cpp:
3397         (WebView::notifyPreferencesChanged):
3398
3399 2016-03-10  Jer Noble  <jer.noble@apple.com>
3400
3401         Add separate WK and WK2 preferences for requiring user gestures for video media, distinct from user gestures for media generally
3402         https://bugs.webkit.org/show_bug.cgi?id=155141
3403
3404         Reviewed by Beth Dakin.
3405
3406         * WebView.cpp:
3407         (WebView::notifyPreferencesChanged):
3408
3409 2016-03-07  Per Arne Vollan  <peavo@outlook.com>
3410
3411         [WinCairo][AcceleratedCompositing] Rendering issues on www.bbc.com.
3412         https://bugs.webkit.org/show_bug.cgi?id=154912
3413
3414         Reviewed by Michael Catanzaro.
3415
3416         If we have a scroll layer, we should not include the scroll position in the visible rectangle,
3417         since the scroll position is already reflected in the position of the scroll layer.
3418
3419         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3420         (AcceleratedCompositingContext::flushPendingLayerChanges):
3421
3422 2016-03-06  Gavin Barraclough  <barraclough@apple.com>
3423
3424         Convert DOMTimer to std::chrono::milliseconds
3425         https://bugs.webkit.org/show_bug.cgi?id=155085
3426
3427         Reviewed by Andreas Kling.
3428
3429         DOMTimer currently uses a mix of millisecond (was int, now std::chrono) and second (as double)
3430         time values. Constant conversion back and forth is a complete mess. Stop that.
3431
3432         * WebView.cpp:
3433         (WebView::setMinimumTimerInterval):
3434             - Convert double argument into std::chrono::milliseconds.
3435
3436 2016-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3437
3438         [ES6] Support Reflect.construct
3439         https://bugs.webkit.org/show_bug.cgi?id=147330
3440
3441         Reviewed by Saam Barati.
3442
3443         * Plugins/PluginPackage.cpp:
3444         (WebCore::NPN_Invoke):
3445
3446 2016-02-24  Per Arne Vollan  <peavo@outlook.com>
3447
3448         [WinCairo] Mark layer as non composited.
3449         https://bugs.webkit.org/show_bug.cgi?id=154640
3450
3451         Reviewed by Alex Christensen.
3452
3453         We need to mark the non composited layer as being non composited.
3454
3455         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3456         (AcceleratedCompositingContext::initialize):
3457         (AcceleratedCompositingContext::flushPendingLayerChanges):
3458
3459 2016-02-22  Per Arne Vollan  <peavo@outlook.com>
3460
3461         [WinCairo] Compile fix.
3462         https://bugs.webkit.org/show_bug.cgi?id=154545
3463
3464         Reviewed by Alex Christensen.
3465
3466         Add missing parameter to GraphicsLayerTextureMapper::updateBackingStoreIncludingSubLayers().
3467
3468         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3469         (AcceleratedCompositingContext::flushPendingLayerChanges):
3470
3471 2016-02-21  Darin Adler  <darin@apple.com>
3472
3473         Refactor LazyEventListener creation to separate Element and Document cases
3474         https://bugs.webkit.org/show_bug.cgi?id=154231
3475
3476         Reviewed by Andreas Kling.
3477
3478         * WebView.h: Forward declare KeyboardEvent.
3479
3480 2016-02-16  Andreas Kling  <akling@apple.com>
3481
3482         Drop StyleResolver and SelectorQueryCache when entering PageCache.
3483         <https://webkit.org/b/154238>
3484
3485         Reviewed by Antti Koivisto.
3486
3487         * WebCoreSupport/WebVisitedLinkStore.cpp:
3488         (WebVisitedLinkStore::removeAllVisitedLinks): Deleted.
3489         (WebVisitedLinkStore::addVisitedLinkHash): Deleted.
3490
3491 2016-02-14  Chris Dumez  <cdumez@apple.com>
3492
3493         Unreviewed Window build fix.
3494
3495         * WebCoreStatistics.cpp:
3496         * WebJavaScriptCollector.cpp:
3497
3498 2016-02-12  Jiewen Tan  <jiewen_tan@apple.com>
3499
3500         WebKit should expose the DOM 4 Event.isTrusted property
3501         https://bugs.webkit.org/show_bug.cgi?id=76121
3502         <rdar://problem/22558494>
3503
3504         Reviewed by Darin Adler.
3505
3506         * DOMCoreClasses.cpp:
3507         (DOMNode::dispatchEvent):
3508         (DOMWindow::dispatchEvent):
3509
3510 2016-02-11  Antti Koivisto  <antti@apple.com>
3511
3512         Try to fix windows build.
3513
3514         * DOMCoreClasses.cpp:
3515         (DOMElement::style):
3516         (DOMElement::offsetLeft):
3517
3518 2016-02-06  Darin Adler  <darin@apple.com>
3519
3520         Finish auditing call sites of upper() and lower(), eliminate many, and rename the functions
3521         https://bugs.webkit.org/show_bug.cgi?id=153905
3522
3523         Reviewed by Sam Weinig.
3524
3525         * Plugins/PluginDatabase.cpp:
3526         (WebCore::PluginDatabase::pluginForMIMEType): Use ASCII case-insensitive map rather
3527         than lowercasing the MIME type.
3528         (WebCore::PluginDatabase::setPreferredPluginForMIMEType): Ditto.
3529
3530         * Plugins/PluginDatabase.h: Make m_preferredPlugins use an ASCII case-insensitive hash.
3531
3532         * Plugins/PluginPackage.h: Use ASCII case-insensitive hash for maps keyed by MIME type.
3533
3534         * Plugins/PluginPackageWin.cpp:
3535         (WebCore::PluginPackage::fetchInfo): Use convertToASCIILowercase to lowercase a MIME type.
3536
3537 2016-02-04  Joseph Pecoraro  <pecoraro@apple.com>
3538
3539         Web Inspector: InspectorTimelineAgent doesn't need to recompile functions because it now uses the sampling profiler
3540         https://bugs.webkit.org/show_bug.cgi?id=153500
3541         <rdar://problem/24352458>
3542
3543         Reviewed by Timothy Hatcher.
3544
3545         * WebInspector.cpp:
3546         (WebInspector::isJavaScriptProfilingEnabled):
3547         (WebInspector::setJavaScriptProfilingEnabled):
3548         Switch to the new API names.
3549
3550 2016-01-31  Darin Adler  <darin@apple.com>
3551
3552         Replace CaseFoldingHash with ASCIICaseInsensitiveHash
3553         https://bugs.webkit.org/show_bug.cgi?id=153639
3554
3555         Reviewed by Filip Pizlo.
3556
3557         * WebCoreStatistics.cpp:
3558         (WebCoreStatistics::memoryStatistics): Use ASCIICaseInsensitiveHash for field names.
3559         These names are all ASCII.
3560
3561         * WebURLResponse.cpp:
3562         (WebURLResponse::allHeaderFields): Use ASCIICaseInsensitiveHash for HTTP header
3563         field names. These names are all ASCII.
3564
3565 2016-01-30  Commit Queue  <commit-queue@webkit.org>
3566
3567         Unreviewed, rolling out r195911.
3568         https://bugs.webkit.org/show_bug.cgi?id=153723