Update FULLSCREEN_API feature defines.
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
2
3         Update FULLSCREEN_API feature defines.
4         https://bugs.webkit.org/show_bug.cgi?id=181015
5
6         Reviewed by Tim Horton.
7
8         Change enabled iphone sdk for FULLSCREEN_API.
9
10         * Configurations/FeatureDefines.xcconfig:
11
12 2017-12-21  Jer Noble  <jer.noble@apple.com>
13
14         Add initial DOM support for Media Capabilities
15         https://bugs.webkit.org/show_bug.cgi?id=181064
16
17         Reviewed by Eric Carlson.
18
19         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
20
21         * WebView/WebPreferenceKeysPrivate.h:
22         * WebView/WebPreferences.mm:
23         (+[WebPreferences initialize]):
24         (-[WebPreferences mediaCapabilitiesEnabled]):
25         (-[WebPreferences setMediaCapabilitiesEnabled:]):
26         * WebView/WebPreferencesPrivate.h:
27         * WebView/WebView.mm:
28         (-[WebView _preferencesChanged:]):
29
30 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
31
32         Enable picture-in-picture from inline element on suspend.
33         https://bugs.webkit.org/show_bug.cgi?id=180942
34         rdar://problem/34745234
35
36         Reviewed by Jer Noble.
37
38         Update signature of enterVideoFullscreenForVideoElement().
39
40         * WebCoreSupport/WebChromeClient.h:
41         * WebCoreSupport/WebChromeClient.mm:
42         (WebChromeClient::enterVideoFullscreenForVideoElement):
43
44 2017-12-20  Daniel Bates  <dabates@apple.com>
45
46         Remove Alternative Presentation Button
47         https://bugs.webkit.org/show_bug.cgi?id=180500
48         <rdar://problem/35891047>
49
50         Reviewed by Simon Fraser.
51
52         We no longer need the alternative presentation button.
53
54         * Configurations/FeatureDefines.xcconfig:
55
56 2017-12-19  Jer Noble  <jer.noble@apple.com>
57
58         Playing media elements which call "pause(); play()" will have the play promise rejected.
59         https://bugs.webkit.org/show_bug.cgi?id=180781
60         <rdar://problem/33191377>
61
62         Reviewed by Eric Carlson.
63
64         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
65
66         * WebView/WebView.mm:
67         (shouldRequireUserGestureToLoadVideo):
68
69 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
70
71         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
72         https://bugs.webkit.org/show_bug.cgi?id=180977
73
74         Reviewed by Tim Horton.
75
76         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
77         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
78         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
79
80         * WebCoreSupport/WebEditorClient.mm:
81         (attributesForAttributedStringConversion):
82         * WebView/WebHTMLView.mm:
83         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
84
85 2017-12-18  David Kilzer  <ddkilzer@apple.com>
86
87         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
88
89         Attempt to fix the following warnings:
90
91             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
92
93         For the following instance variables:
94
95             _borderView
96             _contentView
97             _frame
98             _wFlags
99
100         * Carbon/CarbonWindowAdapter.mm:
101         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
102         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
103         (-[CarbonWindowAdapter _termWindowIfOwner]):
104         (-[CarbonWindowAdapter _windowMovedToRect:]):
105         (-[CarbonWindowAdapter setContentView:]):
106         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
107         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
108
109 2017-12-16  Dan Bernstein  <mitz@apple.com>
110
111         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
112         https://bugs.webkit.org/show_bug.cgi?id=180613
113         <rdar://problem/35946124>
114
115         Reviewed by Geoff Garen.
116
117         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
118           clients.
119         * WebView/WebDynamicScrollBarsView.h: Ditto.
120         * WebView/WebDynamicScrollBarsView.mm: Ditto.
121
122 2017-12-14  David Kilzer  <ddkilzer@apple.com>
123
124         Enable -Wstrict-prototypes for WebKit
125         <https://webkit.org/b/180757>
126         <rdar://problem/36024132>
127
128         Rubber-stamped by Joseph Pecoraro.
129
130         * Configurations/Base.xcconfig:
131         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
132
133 2017-12-14  John Wilander  <wilander@apple.com>
134
135         Storage Access API: Implement frame-specific access in the document.cookie layer
136         https://bugs.webkit.org/show_bug.cgi?id=180682
137         <rdar://problem/35982257>
138
139         Reviewed by Alex Christensen.
140
141         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
142         CookiesStrategy::cookieRequestHeaderFieldValue(), and
143         CookiesStrategy::getRawCookies() now take optional parameters for
144         frameID and pageID to allow frame-specific scoping of cookies.
145
146         This change makes the return values of FrameLoaderClient::frameID()
147         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
148         WebCore can call those getters and get the right return values in
149         WebKit and std:nullopt in WebKitLegacy.
150
151         * WebCoreSupport/WebFrameLoaderClient.h:
152         * WebCoreSupport/WebFrameLoaderClient.mm:
153         (WebFrameLoaderClient::pageID const):
154         (WebFrameLoaderClient::frameID const):
155         * WebCoreSupport/WebPlatformStrategies.h:
156         * WebCoreSupport/WebPlatformStrategies.mm:
157         (WebPlatformStrategies::cookiesForDOM):
158         (WebPlatformStrategies::setCookiesFromDOM):
159         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
160         (WebPlatformStrategies::getRawCookies):
161
162 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
163
164         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
165         https://bugs.webkit.org/show_bug.cgi?id=180689
166
167         Reviewed by Tim Horton.
168
169         Use sRGBColorSpaceRef() from WebCore.
170
171         * WebView/WebHTMLView.mm:
172         (imageFromRect):
173
174 2017-12-11  Tim Horton  <timothy_horton@apple.com>
175
176         Stop using deprecated target conditional for simulator builds
177         https://bugs.webkit.org/show_bug.cgi?id=180662
178         <rdar://problem/35136156>
179
180         Reviewed by Simon Fraser.
181
182         * postprocess-headers.sh:
183
184 2017-12-11  David Quesada  <david_quesada@apple.com>
185
186         Turn on ENABLE_APPLICATION_MANIFEST
187         https://bugs.webkit.org/show_bug.cgi?id=180562
188         rdar://problem/35924737
189
190         Reviewed by Geoffrey Garen.
191
192         * Configurations/FeatureDefines.xcconfig:
193
194 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
195
196         Remove pthread_once in favor of dispatch_once
197         https://bugs.webkit.org/show_bug.cgi?id=180591
198
199         Reviewed by Saam Barati.
200
201         * Misc/WebKitErrors.m:
202         (+[NSError _registerWebKitErrors]):
203         (registerErrors): Deleted.
204         * Storage/WebStorageManager.mm:
205         (+[WebStorageManager _storageDirectoryPath]):
206         (initializeLocalStoragePath): Deleted.
207
208 2017-12-07  Darin Adler  <darin@apple.com>
209
210         Remove some unused code from WebKitLegacy
211         https://bugs.webkit.org/show_bug.cgi?id=180567
212
213         Reviewed by Anders Carlsson.
214
215         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
216         macOS (back a few versions) and iOS and removed unused
217         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
218         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
219         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
220         _webkit_stringByCollapsingNonPrintingCharacters,
221         _webkit_stringByCollapsingWhitespaceCharacters,
222         _web_stringWithData:textEncodingName:, and
223         _webkit_localStorageDirectoryWithBundleIdentifier:.
224
225         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
226         this source file.
227         (canUseFastRenderer): Made this faster by not calling u_charDirection for
228         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
229         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
230         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
231         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
232         handle font smoothing options.
233         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
234         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
235         from header and made it a little clearer.
236         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
237         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
238         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
239         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
240         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
241         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
242         implementation a bit and used whole words instead of abbreviations.
243         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
244
245         * Misc/WebNSFileManagerExtras.mm:
246         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
247         filenameByFixingIllegalCharacters function from WebCore directly instead of
248         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
249
250         * Plugins/WebBaseNetscapePluginView.mm:
251         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
252         string replacements instead of _web_stringByStrippingReturnCharacters
253         and to use NSString methods instead of CFString functions.
254
255 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
256
257         Ignore deprecation warnings.
258
259         * WebView/WebHTMLView.mm:
260         (-[NSWindow _web_borderView]):
261         (-[WebHTMLView _setAsideSubviews]):
262         * WebView/WebView.mm:
263         (-[WebView encodeWithCoder:]):
264
265 2017-12-02  Darin Adler  <darin@apple.com>
266
267         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
268         https://bugs.webkit.org/show_bug.cgi?id=180009
269
270         Reviewed by Alex Christensen.
271
272         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
273
274         * Plugins/WebBaseNetscapePluginView.mm:
275         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
276         of strcasecmp.
277
278         * WebView/WebPreferences.mm:
279         (contains): Ditto. Also made this a template so it's easier to call on an array.
280         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
281
282 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
283
284         Limit user agent versioning to an upper bound
285         https://bugs.webkit.org/show_bug.cgi?id=180365
286         <rdar://problem/34550617>
287
288         Reviewed by Joseph Pecoraro.
289
290         * WebView/WebView.mm:
291         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
292         creating the User Agent string.
293         (webKitBundleVersionString): Deleted.
294
295 2017-12-05  Andy Estes  <aestes@apple.com>
296
297         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
298         https://bugs.webkit.org/show_bug.cgi?id=180457
299         <rdar://problem/35143007>
300
301         Reviewed by Tim Horton.
302
303         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
304         check for this macro during post-processing.
305
306         * postprocess-headers.sh:
307
308 2017-12-04  David Quesada  <david_quesada@apple.com>
309
310         Add a class for parsing application manifests
311         https://bugs.webkit.org/show_bug.cgi?id=177973
312         rdar://problem/34747949
313
314         Reviewed by Geoffrey Garen.
315
316         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
317
318 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
319
320         Make LegacyCustomProtocolManager optional for network process
321         https://bugs.webkit.org/show_bug.cgi?id=176230
322
323         Reviewed by Alex Christensen.
324
325         * Configurations/FeatureDefines.xcconfig:
326
327 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
328
329         Fix some NSOperationQueue leaks
330         https://bugs.webkit.org/show_bug.cgi?id=180221
331
332         Reviewed by Wenson Hsieh.
333
334         * WebView/WebView.mm:
335         (-[WebView performDragOperation:]):
336
337 2017-11-30  Darin Adler  <darin@apple.com>
338
339         [Mac] remove unneeded RetainPtr use introduced in r225142
340         https://bugs.webkit.org/show_bug.cgi?id=180202
341
342         Reviewed by Tim Horton.
343
344         * WebView/WebImmediateActionController.mm:
345         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
346         RetainPtr.
347
348 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
349
350         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
351         https://bugs.webkit.org/show_bug.cgi?id=175595
352
353         Reviewed by Darin Adler.
354
355         * WebView/WebPreferences.mm:
356
357 2017-11-27  Tim Horton  <timothy_horton@apple.com>
358
359         One too many zeroes in macOS version number in FeatureDefines
360         https://bugs.webkit.org/show_bug.cgi?id=180011
361
362         Reviewed by Dan Bernstein.
363
364         * Configurations/FeatureDefines.xcconfig:
365
366 2017-11-23  Darin Adler  <darin@apple.com>
367
368         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
369         https://bugs.webkit.org/show_bug.cgi?id=179981
370
371         Reviewed by Sam Weinig.
372
373         * WebView/WebImmediateActionController.mm:
374         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
375         * WebView/WebView.mm:
376         (coreOptions): Use |= instead of | to build up FindOptions.
377
378 2017-11-23  Sam Weinig  <sam@webkit.org>
379
380         Remove unneeded ScriptController::processingUserGesture() forwarding functions
381         https://bugs.webkit.org/show_bug.cgi?id=179954
382
383         Reviewed by Darin Adler.
384
385         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
386         with direct calls to the corresponding UserGestureIndicator functions.
387
388         * Plugins/WebPluginController.mm:
389         (-[WebPluginController processingUserGesture]):
390         * WebView/WebView.mm:
391         (-[WebView _isProcessingUserGesture]):
392
393 2017-11-23  Darin Adler  <darin@apple.com>
394
395         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
396         https://bugs.webkit.org/show_bug.cgi?id=179907
397
398         Reviewed by Sam Weinig.
399
400         * History/BinaryPropertyList.cpp:
401         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
402         (BinaryPropertyListSerializer::appendStringObject): Ditto.
403         * WebView/WebHTMLRepresentation.mm:
404         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
405         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
406
407 2017-11-22  Ali Juma  <ajuma@chromium.org>
408
409         Implement VisualViewport API attributes
410         https://bugs.webkit.org/show_bug.cgi?id=179385
411
412         Reviewed by Frédéric Wang.
413
414         Add a VisualViewportAPI preference.
415
416         * WebView/WebPreferenceKeysPrivate.h:
417         * WebView/WebPreferences.mm:
418         (+[WebPreferences initialize]):
419         (-[WebPreferences visualViewportAPIEnabled]):
420         (-[WebPreferences setVisualViewportAPIEnabled:]):
421         * WebView/WebPreferencesPrivate.h:
422         * WebView/WebView.mm:
423         (-[WebView _preferencesChanged:]):
424
425 2017-11-22  Christopher Reid  <chris.reid@sony.com>
426
427         WebCoreObjCExtras.h is being included in too many places
428         https://bugs.webkit.org/show_bug.cgi?id=179931
429
430         Reviewed by Darin Adler.
431
432         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
433         * Plugins/WebBaseNetscapePluginView.mm:
434         * Plugins/WebBasePluginPackage.mm:
435         * Plugins/WebNetscapePluginStream.mm:
436         * Plugins/WebNetscapePluginView.mm:
437         * WebView/WebTextIterator.mm:
438         * WebView/WebViewData.mm:
439
440 2017-11-22  Commit Queue  <commit-queue@webkit.org>
441
442         Unreviewed, rolling out r225093.
443         https://bugs.webkit.org/show_bug.cgi?id=179938
444
445         Compilation failed on WinCairo 64-bit Release (Requested by
446         fredw on #webkit).
447
448         Reverted changeset:
449
450         "Implement VisualViewport API attributes"
451         https://bugs.webkit.org/show_bug.cgi?id=179385
452         https://trac.webkit.org/changeset/225093
453
454 2017-11-21  Ali Juma  <ajuma@chromium.org>
455
456         Implement VisualViewport API attributes
457         https://bugs.webkit.org/show_bug.cgi?id=179385
458
459         Reviewed by Frédéric Wang.
460
461         Add a VisualViewportAPI preference.
462
463         * WebView/WebPreferenceKeysPrivate.h:
464         * WebView/WebPreferences.mm:
465         (+[WebPreferences initialize]):
466         (-[WebPreferences visualViewportAPIEnabled]):
467         (-[WebPreferences setVisualViewportAPIEnabled:]):
468         * WebView/WebPreferencesPrivate.h:
469         * WebView/WebView.mm:
470         (-[WebView _preferencesChanged:]):
471
472 2017-11-21  Christopher Reid  <chris.reid@sony.com>
473
474         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
475         https://bugs.webkit.org/show_bug.cgi?id=179504
476
477         Reviewed by Darin Adler.
478
479         * Misc/WebKitNSStringExtras.mm:
480         * Plugins/Hosted/NetscapePluginHostManager.mm:
481         * Plugins/WebBasePluginPackage.mm:
482
483 2017-11-19  Tim Horton  <timothy_horton@apple.com>
484
485         Remove unused TOUCH_ICON_LOADING feature flag
486         https://bugs.webkit.org/show_bug.cgi?id=179873
487
488         Reviewed by Simon Fraser.
489
490         * Configurations/FeatureDefines.xcconfig:
491
492 2017-11-19  Tim Horton  <timothy_horton@apple.com>
493
494         Remove unused LEGACY_VENDOR_PREFIXES feature flag
495         https://bugs.webkit.org/show_bug.cgi?id=179872
496
497         Reviewed by Darin Adler.
498
499         * Configurations/FeatureDefines.xcconfig:
500
501 2017-11-16  Daniel Bates  <dabates@apple.com>
502
503         Add feature define for alternative presentation button element
504         https://bugs.webkit.org/show_bug.cgi?id=179692
505         Part of <rdar://problem/34917108>
506
507         Reviewed by Andy Estes.
508
509         Only enabled on Cocoa platforms by default.
510
511         * Configurations/FeatureDefines.xcconfig:
512
513 2017-11-14  Nan Wang  <n_wang@apple.com>
514
515         AX: AOM: Implement AccessibleNode class and support label and role attributes
516         https://bugs.webkit.org/show_bug.cgi?id=179494
517
518         Reviewed by Ryosuke Niwa.
519
520         * WebView/WebPreferenceKeysPrivate.h:
521         * WebView/WebPreferences.mm:
522         (+[WebPreferences initialize]):
523         (-[WebPreferences accessibilityObjectModelEnabled]):
524         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
525         * WebView/WebPreferencesPrivate.h:
526         * WebView/WebView.mm:
527         (-[WebView _preferencesChanged:]):
528
529 2017-11-14  Alex Christensen  <achristensen@webkit.org>
530
531         Remove Cocoa CFURLConnection loading code
532         https://bugs.webkit.org/show_bug.cgi?id=179688
533
534         Reviewed by Antti Koivisto.
535
536         * Misc/WebDownload.mm:
537         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
538         * Misc/WebDownloadInternal.h:
539         * Plugins/WebBaseNetscapePluginView.mm:
540         * WebCoreSupport/WebFrameLoaderClient.mm:
541         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
542         * WebView/WebView.mm:
543         (-[WebView scheduleInRunLoop:forMode:]):
544         (-[WebView unscheduleFromRunLoop:forMode:]):
545
546 2017-11-14  Daniel Bates  <dabates@apple.com>
547
548         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
549         for feature defines
550
551         Following r195498 and r201917 the Visual Studio property files for feature defines have
552         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
553         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
554         files.
555
556         * Configurations/FeatureDefines.xcconfig:
557
558 2017-11-14  Jer Noble  <jer.noble@apple.com>
559
560         Enable Modern EME tests in DumpRenderTree
561         https://bugs.webkit.org/show_bug.cgi?id=179544
562
563         Reviewed by Alex Christensen.
564
565         Add a WebPreferences property to enable the (modern) EME API.
566
567         * WebView/WebPreferenceKeysPrivate.h:
568         * WebView/WebPreferences.mm:
569         (+[WebPreferences initialize]):
570         (-[WebPreferences encryptedMediaAPIEnabled]):
571         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
572         * WebView/WebPreferencesPrivate.h:
573         * WebView/WebView.mm:
574         (-[WebView _preferencesChanged:]):
575
576 2017-11-14  Antti Koivisto  <antti@apple.com>
577
578         Enable display:contents by default
579         https://bugs.webkit.org/show_bug.cgi?id=179655
580
581         Reviewed by Sam Weinig.
582
583         * WebView/WebPreferences.mm:
584         (+[WebPreferences initialize]):
585
586 2017-11-13  Alex Christensen  <achristensen@webkit.org>
587
588         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
589         https://bugs.webkit.org/show_bug.cgi?id=178751
590
591         Reviewed by Brady Eidson.
592
593         * WebCoreSupport/WebFrameNetworkingContext.mm:
594         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
595
596 2017-11-08  Keith Miller  <keith_miller@apple.com>
597
598         Async iteration should only fetch the next method once and add feature flag
599         https://bugs.webkit.org/show_bug.cgi?id=179451
600
601         Reviewed by Geoffrey Garen.
602
603         Add feature flag for Async iteration.
604
605         * Configurations/FeatureDefines.xcconfig:
606
607 2017-11-13  Mark Lam  <mark.lam@apple.com>
608
609         Add more overflow check book-keeping for MarkedArgumentBuffer.
610         https://bugs.webkit.org/show_bug.cgi?id=179634
611         <rdar://problem/35492517>
612
613         Reviewed by Saam Barati.
614
615         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
616         (WebKit::NetscapePluginInstanceProxy::invoke):
617         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
618         (WebKit::NetscapePluginInstanceProxy::construct):
619
620 2017-11-12  Darin Adler  <darin@apple.com>
621
622         More is<> and downcast<>, less static_cast<>
623         https://bugs.webkit.org/show_bug.cgi?id=179600
624
625         Reviewed by Chris Dumez.
626
627         * DOM/DOM.mm:
628         (kit): Use is/downcast.
629         * WebCoreSupport/WebEditorClient.mm:
630         (WebEditorClient::handleKeyboardEvent): Ditto.
631         (WebEditorClient::handleInputMethodKeydown): Ditto.
632         * WebView/WebHTMLView.mm:
633         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
634
635 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
636
637         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
638         https://bugs.webkit.org/show_bug.cgi?id=179397
639
640         Reviewed by Wenson Hsieh.
641
642         * DOM/DOMHTMLInputElement.mm:
643         (-[DOMHTMLInputElement insertTextSuggestion:]):
644
645 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
646
647         HTMLMediaElement should not use element fullscreen on iOS
648         https://bugs.webkit.org/show_bug.cgi?id=179418
649         rdar://problem/35409277
650
651         Reviewed by Eric Carlson.
652
653         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
654
655         * Configurations/FeatureDefines.xcconfig:
656
657 2017-11-06  Alex Christensen  <achristensen@webkit.org>
658
659         Make ResourceLoader::willSendRequestInternal asynchronous
660         https://bugs.webkit.org/show_bug.cgi?id=179251
661
662         Reviewed by Andy Estes.
663
664         * Plugins/Hosted/HostedNetscapePluginStream.mm:
665         (WebKit::HostedNetscapePluginStream::start):
666         * Plugins/WebNetscapePluginStream.mm:
667         (WebNetscapePluginStream::start):
668
669 2017-11-01  Darin Adler  <darin@apple.com>
670
671         Simplify event dispatch code and make it a bit more consistent
672         https://bugs.webkit.org/show_bug.cgi?id=178991
673
674         Reviewed by Chris Dumez.
675
676         * DOM/DOMEvent.mm:
677         (-[DOMEvent srcElement]): Call target instead of srcElement.
678
679 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
680
681         [Touch Bar Web API] Add support for menuitem tag
682         https://bugs.webkit.org/show_bug.cgi?id=179020
683
684         Reviewed by Ryosuke Niwa.
685
686         Adds in properties and methods that allow the menuitem runtime feature
687         to be enabled or disabled.
688
689         * WebView/WebPreferenceKeysPrivate.h:
690         * WebView/WebPreferences.mm:
691         (-[WebPreferences menuItemElementEnabled]):
692         (-[WebPreferences setMenuItemElementEnabled:]):
693         * WebView/WebPreferencesPrivate.h:
694         * WebView/WebView.mm:
695         (-[WebView _preferencesChanged:]):
696
697 2017-11-02  Alex Christensen  <achristensen@webkit.org>
698
699         Use CompletionHandlers for redirects
700         https://bugs.webkit.org/show_bug.cgi?id=179163
701
702         Reviewed by Tim Horton.
703
704         * Plugins/Hosted/HostedNetscapePluginStream.h:
705         * Plugins/Hosted/HostedNetscapePluginStream.mm:
706         (WebKit::HostedNetscapePluginStream::willSendRequest):
707         * Plugins/WebNetscapePluginStream.h:
708         * Plugins/WebNetscapePluginStream.mm:
709         (WebNetscapePluginStream::willSendRequest):
710
711 2017-11-02  Christopher Reid  <chris.reid@sony.com>
712
713         Add a FileSystem namespace to FileSystem.cpp
714         https://bugs.webkit.org/show_bug.cgi?id=179063
715
716         Reviewed by Darin Adler.
717
718         * Misc/WebNSFileManagerExtras.mm:
719         * Storage/WebDatabaseProvider.mm:
720
721 2017-11-02  Frederic Wang  <fwang@igalia.com>
722
723         Add references to bug 179167 in FIXME comments
724         https://bugs.webkit.org/show_bug.cgi?id=179168
725
726         Reviewed by Daniel Bates.
727
728         * Configurations/FeatureDefines.xcconfig:
729
730 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
731
732         Implement WKFullscreenWindowController for iOS.
733         https://bugs.webkit.org/show_bug.cgi?id=178924
734         rdar://problem/34697120
735
736         Reviewed by Simon Fraser.
737
738         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
739
740         * Configurations/FeatureDefines.xcconfig:
741         * WebView/WebView.mm:
742         (-[WebView fullScreenPlaceholderView]):
743
744 2017-10-31  Tim Horton  <timothy_horton@apple.com>
745
746         Clean up some drag and drop feature flags
747         https://bugs.webkit.org/show_bug.cgi?id=179082
748
749         Reviewed by Simon Fraser.
750
751         * Configurations/FeatureDefines.xcconfig:
752
753 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
754
755         Make it possible to test rubber-banding in overflow scroll
756         https://bugs.webkit.org/show_bug.cgi?id=179078
757
758         Reviewed by Sam Weinig.
759
760         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
761         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
762
763         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
764         functions, since most callers want clamped.
765
766         * DOM/DOMHTML.mm:
767         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
768
769 2017-10-31  Tim Horton  <timothy_horton@apple.com>
770
771         Fix up some content filtering feature flags
772         https://bugs.webkit.org/show_bug.cgi?id=179079
773
774         Reviewed by Simon Fraser.
775
776         * Configurations/FeatureDefines.xcconfig:
777
778 2017-10-28  Zalan Bujtas  <zalan@apple.com>
779
780         [FrameView::layout cleanup] Move core layout logic to a separate class.
781         https://bugs.webkit.org/show_bug.cgi?id=178771
782         <rdar://problem/35166542>
783
784         Reviewed by Simon Fraser.
785
786         Move layout code out from FrameView to LayoutContext.
787
788         * WebView/WebClipView.mm:
789         (-[WebClipView _immediateScrollToPoint:]):
790         * WebView/WebFrame.mm:
791         (-[WebFrame layoutCount]):
792
793 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
794
795         Fix issues with WebView subframe painting
796         https://bugs.webkit.org/show_bug.cgi?id=178842
797         rdar://problem/34072253
798
799         Reviewed by Daniel Bates.
800         
801         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
802         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
803         High Sierra, so match the new signature.
804
805         Also rename the 'rect' param to 'displayRect' to match AppKit code.
806
807         * WebView/WebHTMLView.mm:
808         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
809         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
810
811 2017-10-25  Youenn Fablet  <youenn@apple.com>
812
813         Enable ServiceWorker to fetch resources
814         https://bugs.webkit.org/show_bug.cgi?id=178673
815
816         Reviewed by Brady Eidson.
817
818         * WebCoreSupport/WebFrameLoaderClient.mm:
819         (WebFrameLoaderClient::pageID const):
820         (WebFrameLoaderClient::frameID const):
821         (WebFrameLoaderClient::sessionID const):
822
823         Added implementation to the new getters.
824         They are noop in the context of WK1.
825
826 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
827
828         Web Inspector: Enable WebKit logging configuration and display
829         https://bugs.webkit.org/show_bug.cgi?id=177027
830         <rdar://problem/33964767>
831
832         Reviewed by Joseph Pecoraro.
833
834         * WebCoreSupport/WebChromeClient.mm:
835         (stringForMessageSource): Deal with Media and WebRTC message sources.
836
837 2017-10-20  Antoine Quint  <graouts@apple.com>
838
839         [Web Animations] Provide basic timeline and animation interfaces
840         https://bugs.webkit.org/show_bug.cgi?id=178526
841
842         Reviewed by Dean Jackson.
843
844         Remove the WEB_ANIMATIONS compile-time flag.
845
846         * Configurations/FeatureDefines.xcconfig:
847         * WebView/WebPreferences.mm:
848         (+[WebPreferences initialize]):
849         * WebView/WebView.mm:
850         (-[WebView _preferencesChanged:]):
851
852 2017-10-19  Sam Weinig  <sam@webkit.org>
853
854         [Settings] Move global settings into their own file
855         https://bugs.webkit.org/show_bug.cgi?id=178512
856
857         Reviewed by Darin Adler.
858
859         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
860
861         * WebCoreSupport/WebChromeClient.mm:
862         (WebChromeClient::supportsVideoFullscreen):
863         * WebView/WebDynamicScrollBarsView.mm:
864         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
865         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
866         * WebView/WebPreferences.mm:
867         (+[WebPreferences initialize]):
868         * WebView/WebView.mm:
869         (-[WebView _commonInitializationWithFrameName:groupName:]):
870         (-[WebView _preferencesChanged:]):
871         (+[WebView _doNotStartObservingNetworkReachability]):
872
873 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
874
875         Replace some stack raw pointers with RefPtrs within WebCore/html
876         https://bugs.webkit.org/show_bug.cgi?id=178201
877         <rdar://problem/34841692>
878
879         Reviewed by Ryosuke Niwa.
880
881         * DOM/DOM.mm:
882         (kit):
883         Change the type of node as toNode() is changed to return RefPtr.
884
885 2017-10-18  Chris Dumez  <cdumez@apple.com>
886
887         [Service Worker] Add stubs for Client / WindowClient / Clients
888         https://bugs.webkit.org/show_bug.cgi?id=178469
889
890         Reviewed by Youenn Fablet.
891
892         Rename PageVisiblityState to VisibilityState.
893
894         * WebView/WebView.mm:
895         (kit):
896
897 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
898
899         Unreviewed, rolling out r223291.
900
901         See WebCore ChangeLog for more detail.
902
903         Reverted changeset:
904
905         "Remove Editor::simplifyMarkup"
906         https://bugs.webkit.org/show_bug.cgi?id=178271
907         https://trac.webkit.org/changeset/223291
908
909 2017-10-17  Keith Miller  <keith_miller@apple.com>
910
911         Change WebCore sources to work with unified source builds
912         https://bugs.webkit.org/show_bug.cgi?id=178229
913
914         Rubber stamped by Tim Horton.
915
916         * Configurations/FeatureDefines.xcconfig:
917
918 2017-10-16  Sam Weinig  <sam@webkit.org>
919
920         [Settings] Remove all custom code from Settings.h/cpp
921         https://bugs.webkit.org/show_bug.cgi?id=178330
922
923         Reviewed by Simon Fraser.
924
925         * WebView/WebPreferences.mm:
926         (+[WebPreferences initialize]):
927         
928             Update for naming changes of FrameFlattening now that it is an enum class.
929
930 2017-10-13  Alex Christensen  <achristensen@webkit.org>
931
932         Remove Editor::simplifyMarkup
933         https://bugs.webkit.org/show_bug.cgi?id=178271
934
935         Reviewed by Wenson Hsieh.
936
937         * WebView/WebView.mm:
938         (-[WebView _simplifyMarkup:endNode:]):
939
940 2017-10-12  Chris Dumez  <cdumez@apple.com>
941
942         [Mac] Add support for MouseEvent.buttons
943         https://bugs.webkit.org/show_bug.cgi?id=178214
944
945         Reviewed by Ryosuke Niwa.
946
947         * WebView/WebPDFView.mm:
948         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
949
950 2017-10-11  Sam Weinig  <sam@webkit.org>
951
952         Remove out-parameter variants of copyToVector
953         https://bugs.webkit.org/show_bug.cgi?id=178155
954
955         Reviewed by Tim Horton.
956
957         * Plugins/WebNetscapePluginView.mm:
958         (-[WebNetscapePluginView destroyPlugin]):
959         * WebView/WebHTMLRepresentation.mm:
960         (newArrayWithStrings):
961
962             Replace out-parameter based copyToVector, with one that returns a Vector.
963
964 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
965
966         Sanitize URL in pasteboard for other applications and cross origin content
967         https://bugs.webkit.org/show_bug.cgi?id=178060
968         <rdar://problem/34874518>
969
970         Reviewed by Wenson Hsieh.
971
972         * WebCoreSupport/WebPlatformStrategies.h:
973         * WebCoreSupport/WebPlatformStrategies.mm:
974         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
975
976 2017-10-11  Chris Dumez  <cdumez@apple.com>
977
978         Modernize Geolocation code
979         https://bugs.webkit.org/show_bug.cgi?id=178148
980
981         Reviewed by Ryosuke Niwa.
982
983         * WebCoreSupport/WebGeolocationClient.h:
984         * WebCoreSupport/WebGeolocationClient.mm:
985         (WebGeolocationClient::lastPosition):
986         * WebView/WebGeolocationPosition.mm:
987         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
988         (core):
989         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
990         (-[WebGeolocationPosition initWithGeolocationPosition:]):
991         * WebView/WebGeolocationPositionInternal.h:
992
993 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
994
995         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
996         https://bugs.webkit.org/show_bug.cgi?id=178154
997
998         Reviewed by Wenson Hsieh.
999
1000         Enable custom pasteboard data by default.
1001
1002         * WebView/WebPreferenceKeysPrivate.h:
1003         * WebView/WebPreferences.mm:
1004         (+[WebPreferences initialize]):
1005         (-[WebPreferences customPasteboardDataEnabled]): Added.
1006         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
1007         * WebView/WebPreferencesPrivate.h:
1008         * WebView/WebView.mm:
1009         (-[WebView _preferencesChanged:]):
1010
1011 2017-10-10  Sam Weinig  <sam@webkit.org>
1012
1013         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
1014         https://bugs.webkit.org/show_bug.cgi?id=178102
1015
1016         Reviewed by Tim Horton.
1017
1018         * History/WebHistory.mm:
1019         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
1020         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1021         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
1022         * WebCoreSupport/WebUserMediaClient.mm:
1023         (WebUserMediaClient::pageDestroyed):
1024
1025 2017-10-09  Robin Morisset  <rmorisset@apple.com>
1026
1027         Make the names of the options consistent
1028         https://bugs.webkit.org/show_bug.cgi?id=177933
1029
1030         Reviewed by Saam Barati.
1031
1032         * WebView/WebFrame.h:
1033         * WebView/WebHTMLView.mm:
1034         (-[WebHTMLView setMarkedText:selectedRange:]):
1035         * WebView/WebView.h:
1036
1037 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1038
1039         [iOS] Tweak support for classifying form controls (followup to r222487)
1040         https://bugs.webkit.org/show_bug.cgi?id=177917
1041         <rdar://problem/34820122>
1042
1043         Reviewed by Dean Jackson.
1044
1045         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
1046
1047         * DOM/DOMHTMLInputElement.mm:
1048         (-[DOMHTMLInputElement _autofillContext]):
1049         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
1050         (-[DOMHTMLInputElement representingPageURL]): Deleted.
1051
1052 2017-10-05  Keith Miller  <keith_miller@apple.com>
1053
1054         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
1055
1056         * Configurations/WebKitLegacy.xcconfig:
1057
1058 2017-10-05  Jer Noble  <jer.noble@apple.com>
1059
1060         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
1061         https://bugs.webkit.org/show_bug.cgi?id=177261
1062
1063         Reviewed by Eric Carlson.
1064
1065         * Configurations/FeatureDefines.xcconfig:
1066
1067 2017-10-05  Chris Dumez  <cdumez@apple.com>
1068
1069         Drop unused parameters for CookiesStrategy::cookiesEnabled()
1070         https://bugs.webkit.org/show_bug.cgi?id=177957
1071
1072         Reviewed by Alex Christensen.
1073
1074         * WebCoreSupport/WebPlatformStrategies.h:
1075         * WebCoreSupport/WebPlatformStrategies.mm:
1076         (WebPlatformStrategies::cookiesEnabled):
1077
1078 2017-10-05  Youenn Fablet  <youenn@apple.com>
1079
1080         Make LibWebRTCProvider port agnostic
1081         https://bugs.webkit.org/show_bug.cgi?id=177747
1082
1083         Reviewed by Alex Christensen & Alex Garcia.
1084
1085         * WebView/WebView.mm:
1086         (-[WebView _commonInitializationWithFrameName:groupName:]):
1087         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1088
1089 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1090
1091         Stop linking with WebKitSystemInterface
1092         https://bugs.webkit.org/show_bug.cgi?id=177915
1093
1094         Reviewed by Antti Koivisto.
1095
1096         * Configurations/DebugRelease.xcconfig:
1097         * Configurations/WebKitLegacy.xcconfig:
1098
1099 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1100
1101         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
1102         https://bugs.webkit.org/show_bug.cgi?id=177912
1103
1104         Reviewed by Saam Barati.
1105
1106         * Carbon/CarbonUtils.m:
1107         * Carbon/CarbonWindowAdapter.mm:
1108         * Carbon/HIWebView.mm:
1109         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1110         * Misc/WebNSFileManagerExtras.mm:
1111         * Misc/WebNSPasteboardExtras.mm:
1112         * Misc/WebNSURLExtras.mm:
1113         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1114         * Plugins/Hosted/NetscapePluginHostManager.mm:
1115         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1116         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1117         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1118         * Plugins/Hosted/WebTextInputWindowController.m:
1119         * Plugins/WebBaseNetscapePluginView.mm:
1120         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1121         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1122         * Plugins/WebNetscapePluginStream.mm:
1123         * Plugins/WebNetscapePluginView.mm:
1124         * Plugins/WebPluginDatabase.mm:
1125         * WebCoreSupport/PopupMenuMac.mm:
1126         * WebCoreSupport/WebChromeClient.mm:
1127         * WebCoreSupport/WebFrameLoaderClient.mm:
1128         * WebCoreSupport/WebInspectorClient.mm:
1129         * WebCoreSupport/WebPlatformStrategies.mm:
1130         * WebCoreSupport/WebSystemInterface.mm:
1131         * WebView/WebDynamicScrollBarsView.mm:
1132         * WebView/WebFrame.mm:
1133         * WebView/WebFrameView.mm:
1134         * WebView/WebFullScreenController.mm:
1135         * WebView/WebHTMLView.mm:
1136         * WebView/WebPreferences.mm:
1137         * WebView/WebView.mm:
1138
1139 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
1140
1141         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
1142         rdar://problem/34705779
1143
1144         Addressing review comments that I somehow landed without.
1145
1146         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
1147
1148 2017-09-29  Chris Dumez  <cdumez@apple.com>
1149
1150         Split some logic out of VisitedLinkStore and make it reusable
1151         https://bugs.webkit.org/show_bug.cgi?id=177575
1152
1153         Reviewed by Alex Christensen.
1154
1155         * WebCoreSupport/WebVisitedLinkStore.h:
1156         * WebCoreSupport/WebVisitedLinkStore.mm:
1157         (WebVisitedLinkStore::addVisitedLink):
1158         (WebVisitedLinkStore::removeVisitedLink):
1159         (WebVisitedLinkStore::isLinkVisited):
1160         (WebVisitedLinkStore::addVisitedLinkHash):
1161
1162 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
1163
1164         Build fix for High Sierra 32 bit Mac
1165         https://bugs.webkit.org/show_bug.cgi?id=177551
1166         <rdar://problem/34690283>
1167
1168         Reviewed by Alexey Proskuryakov.
1169
1170         Some assertions have been removed from the SDK. Replace these assertions with equivalent
1171         WTF assert code.  Since the files in this patch are using tabs, some style changes were
1172         also made.
1173
1174         * Carbon/CarbonWindowAdapter.mm:
1175         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1176         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
1177         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1178         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1179         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
1180         (-[CarbonWindowAdapter dealloc]):
1181         (-[CarbonWindowAdapter windowRef]):
1182         (-[CarbonWindowAdapter _hasWindowRef]):
1183         (-[CarbonWindowAdapter _managesWindowRef]):
1184         (-[CarbonWindowAdapter _removeWindowRef]):
1185         (-[CarbonWindowAdapter _carbonWindowClass]):
1186         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1187         (-[CarbonWindowAdapter sendSuperEvent:]):
1188         (-[CarbonWindowAdapter relinquishFocus]):
1189         (-[CarbonWindowAdapter _cancelKey:]):
1190         (-[CarbonWindowAdapter _commonAwake]):
1191         (-[CarbonWindowAdapter _destroyRealWindow:]):
1192         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1193         (-[CarbonWindowAdapter _termWindowIfOwner]):
1194         (-[CarbonWindowAdapter _windowMovedToRect:]):
1195         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
1196         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
1197         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
1198         (-[CarbonWindowAdapter canBecomeKeyWindow]):
1199         (-[CarbonWindowAdapter canBecomeMainWindow]):
1200         (-[CarbonWindowAdapter encodeWithCoder:]):
1201         (-[CarbonWindowAdapter initWithCoder:]):
1202         (-[CarbonWindowAdapter setContentView:]):
1203         (-[CarbonWindowAdapter worksWhenModal]):
1204         (-[CarbonWindowAdapter _setModalWindowLevel]):
1205         (-[CarbonWindowAdapter _clearModalWindowLevel]):
1206         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
1207         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
1208         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
1209         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1210         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1211         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
1212         (NSCarbonWindowHandleEvent):
1213         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
1214         (-[CarbonWindowAdapter _growBoxRect]):
1215         * Carbon/HIWebView.mm:
1216         (HIWebViewGetWebView):
1217         (HIWebViewConstructor):
1218         (HIWebViewDestructor):
1219         (HIWebViewRegisterClass):
1220         (GetBehaviors):
1221         (Draw):
1222         (HitTest):
1223         (GetRegion):
1224         (GetWindowRef):
1225         (CreateNSEventAdoptingCGEvent):
1226         (CopyEventCGEvent):
1227         (CreateNSEventWithCarbonClickEvent):
1228         (Click):
1229         (CreateNSEventWithCarbonEvent):
1230         (MouseUp):
1231         (CreateNSEventWithCarbonMouseMoveEvent):
1232         (MouseMoved):
1233         (MouseDragged):
1234         (MouseWheelMoved):
1235         (ContextMenuClick):
1236         (GetKind):
1237         (BoundsChanged):
1238         (OwningWindowChanged):
1239         (WindowHandler):
1240         (SyncFrame):
1241         (SetFocusPart):
1242         (AdvanceFocus):
1243         (RelinquishFocus):
1244         (ActiveStateChanged):
1245         (ProcessCommand):
1246         (UpdateCommandStatus):
1247         (_NSSelectorForHICommand):
1248         (HIWebViewEventHandler):
1249         (StartUpdateObserver):
1250         (StopUpdateObserver):
1251         (UpdateObserver):
1252
1253 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1254
1255         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
1256         https://bugs.webkit.org/show_bug.cgi?id=172526
1257         <rdar://problem/32396081>
1258
1259         Reviewed by Ryosuke Niwa.
1260
1261         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
1262
1263         * WebCoreSupport/WebPlatformStrategies.h:
1264         * WebCoreSupport/WebPlatformStrategies.mm:
1265         (WebPlatformStrategies::webExposedTypes):
1266         (WebPlatformStrategies::writeCustomData):
1267
1268 2017-09-27  Matt Lewis  <jlewis3@apple.com>
1269
1270         Unreviewed, rolling out r222567.
1271
1272         This broke and internal build.
1273
1274         Reverted changeset:
1275
1276         "Build fix for High Sierra 32 bit Mac"
1277         https://bugs.webkit.org/show_bug.cgi?id=177551
1278         http://trac.webkit.org/changeset/222567
1279
1280 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
1281
1282         Build fix for High Sierra 32 bit Mac
1283         https://bugs.webkit.org/show_bug.cgi?id=177551
1284         <rdar://problem/34690283>
1285
1286         Reviewed by Alexey Proskuryakov.
1287
1288         Some assertions have been removed from the SDK. Replace these assertions with equivalent
1289         WTF assert code.  Since the files in this patch are using tabs, some style changes were
1290         also made.
1291
1292         * Carbon/CarbonWindowAdapter.mm:
1293         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1294         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
1295         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1296         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1297         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
1298         (-[CarbonWindowAdapter dealloc]):
1299         (-[CarbonWindowAdapter windowRef]):
1300         (-[CarbonWindowAdapter _hasWindowRef]):
1301         (-[CarbonWindowAdapter _managesWindowRef]):
1302         (-[CarbonWindowAdapter _removeWindowRef]):
1303         (-[CarbonWindowAdapter _carbonWindowClass]):
1304         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1305         (-[CarbonWindowAdapter sendSuperEvent:]):
1306         (-[CarbonWindowAdapter relinquishFocus]):
1307         (-[CarbonWindowAdapter _cancelKey:]):
1308         (-[CarbonWindowAdapter _commonAwake]):
1309         (-[CarbonWindowAdapter _destroyRealWindow:]):
1310         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1311         (-[CarbonWindowAdapter _termWindowIfOwner]):
1312         (-[CarbonWindowAdapter _windowMovedToRect:]):
1313         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
1314         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
1315         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
1316         (-[CarbonWindowAdapter canBecomeKeyWindow]):
1317         (-[CarbonWindowAdapter canBecomeMainWindow]):
1318         (-[CarbonWindowAdapter encodeWithCoder:]):
1319         (-[CarbonWindowAdapter initWithCoder:]):
1320         (-[CarbonWindowAdapter setContentView:]):
1321         (-[CarbonWindowAdapter worksWhenModal]):
1322         (-[CarbonWindowAdapter _setModalWindowLevel]):
1323         (-[CarbonWindowAdapter _clearModalWindowLevel]):
1324         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
1325         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
1326         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
1327         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1328         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1329         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
1330         (NSCarbonWindowHandleEvent):
1331         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
1332         (-[CarbonWindowAdapter _growBoxRect]):
1333         * Carbon/HIWebView.mm:
1334         (HIWebViewGetWebView):
1335         (HIWebViewConstructor):
1336         (HIWebViewDestructor):
1337         (HIWebViewRegisterClass):
1338         (GetBehaviors):
1339         (Draw):
1340         (HitTest):
1341         (GetRegion):
1342         (GetWindowRef):
1343         (CreateNSEventAdoptingCGEvent):
1344         (CopyEventCGEvent):
1345         (CreateNSEventWithCarbonClickEvent):
1346         (Click):
1347         (CreateNSEventWithCarbonEvent):
1348         (MouseUp):
1349         (CreateNSEventWithCarbonMouseMoveEvent):
1350         (MouseMoved):
1351         (MouseDragged):
1352         (MouseWheelMoved):
1353         (ContextMenuClick):
1354         (GetKind):
1355         (BoundsChanged):
1356         (OwningWindowChanged):
1357         (WindowHandler):
1358         (SyncFrame):
1359         (SetFocusPart):
1360         (AdvanceFocus):
1361         (RelinquishFocus):
1362         (ActiveStateChanged):
1363         (ProcessCommand):
1364         (UpdateCommandStatus):
1365         (_NSSelectorForHICommand):
1366         (HIWebViewEventHandler):
1367         (StartUpdateObserver):
1368         (StopUpdateObserver):
1369         (UpdateObserver):
1370
1371 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1372
1373         Make PolicyAction an encodable enum class
1374         https://bugs.webkit.org/show_bug.cgi?id=177480
1375
1376         Reviewed by Antti Koivisto.
1377
1378         * Plugins/WebPluginContainerCheck.mm:
1379         (-[WebPluginContainerCheck _continueWithPolicy:]):
1380         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
1381         * WebCoreSupport/WebFrameLoaderClient.mm:
1382         (-[WebFramePolicyListener invalidate]):
1383         (-[WebFramePolicyListener ignore]):
1384         (-[WebFramePolicyListener download]):
1385         (-[WebFramePolicyListener use]):
1386         (-[WebFramePolicyListener continue]):
1387         * WebView/WebPolicyDelegate.mm:
1388         (-[WebPolicyDecisionListener use]):
1389         (-[WebPolicyDecisionListener ignore]):
1390         (-[WebPolicyDecisionListener download]):
1391
1392 2017-09-25  Frederik Riedel  <riedel@apple.com>
1393
1394         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
1395         https://bugs.webkit.org/show_bug.cgi?id=174394
1396         <rdar://problem/33183504>
1397
1398         Reviewed by Ryosuke Niwa.
1399
1400         * DOM/DOMHTMLInputElement.h:
1401         * DOM/DOMHTMLInputElement.mm:
1402         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
1403         Determines if this HTMLInputElement is part of a login screen.
1404         (-[DOMHTMLInputElement representingPageUrl]):
1405         Returns the webpage's URL that is currently displayed in the Web View.
1406         (-[DOMHTMLInputElement insertTextSuggestion:]):
1407         Inserts login credentials into the Web View.
1408
1409 2017-09-25  Sam Weinig  <sam@webkit.org>
1410
1411         Remove unused EditorClient functions
1412         https://bugs.webkit.org/show_bug.cgi?id=177463
1413
1414         Reviewed by Alex Christensen.
1415
1416         Remove unused EditorClient functions.
1417
1418         * WebCoreSupport/WebEditorClient.h:
1419         * WebCoreSupport/WebEditorClient.mm:
1420         (WebEditorClient::canonicalizeURL): Deleted.
1421         (WebEditorClient::canonicalizeURLString): Deleted.
1422         (WebEditorClient::writeDataToPasteboard): Deleted.
1423         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
1424         (WebEditorClient::readDataFromPasteboard): Deleted.
1425         (WebEditorClient::pasteboardChangeCount): Deleted.
1426
1427 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1428
1429         Stop using PolicyCallback
1430         https://bugs.webkit.org/show_bug.cgi?id=176088
1431
1432         Reviewed by Andy Estes.
1433
1434         * WebCoreSupport/WebFrameLoaderClient.mm:
1435         (-[WebFramePolicyListener invalidate]):
1436         (-[WebFramePolicyListener receivedPolicyDecision:]):
1437
1438 2017-09-25  Sam Weinig  <sam@webkit.org>
1439
1440         Remove unnecessary userVisibleString EditorClient function
1441         https://bugs.webkit.org/show_bug.cgi?id=177456
1442
1443         Reviewed by Dan Bernstein.
1444
1445         * WebCoreSupport/WebEditorClient.h:
1446         * WebCoreSupport/WebEditorClient.mm:
1447         (WebEditorClient::userVisibleString): Deleted.
1448
1449             Remove userVisibleString client function.
1450
1451 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1452
1453         Separate form submission from PolicyChecker infrastructure
1454         https://bugs.webkit.org/show_bug.cgi?id=177396
1455
1456         Reviewed by Geoffrey Garen.
1457
1458         * WebCoreSupport/WebFrameLoaderClient.h:
1459         * WebCoreSupport/WebFrameLoaderClient.mm:
1460         (WebFrameLoaderClient::dispatchWillSubmitForm):
1461
1462 2017-09-22  Zalan Bujtas  <zalan@apple.com>
1463
1464         WeakPtrFactory should populate m_ref lazily.
1465         https://bugs.webkit.org/show_bug.cgi?id=177375
1466
1467         Reviewed by Geoffrey Garen.
1468
1469         * WebCoreSupport/WebEditorClient.mm:
1470         (WebEditorClient::WebEditorClient):
1471         (WebEditorClient::requestCandidatesForSelection):
1472
1473 2017-09-22  Chris Dumez  <cdumez@apple.com>
1474
1475         Use high resolution timestamp for event time
1476         https://bugs.webkit.org/show_bug.cgi?id=154246
1477         <rdar://problem/34333304>
1478
1479         Reviewed by Ryosuke Niwa.
1480
1481         Use WallTime / MonotonicTime instead of double type for clarity.
1482
1483         * DOM/DOMEvent.mm:
1484         (-[DOMEvent timeStamp]):
1485         * WebView/WebFrame.mm:
1486         (-[WebFrame _dragSourceEndedAt:operation:]):
1487         * WebView/WebPDFView.mm:
1488         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1489
1490 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
1491
1492         Enable dataTransfer.items on macOS and iOS
1493         https://bugs.webkit.org/show_bug.cgi?id=177335
1494
1495         Reviewed by Sam Weinig.
1496
1497         * WebView/WebPreferences.mm:
1498         (+[WebPreferences initialize]):
1499
1500 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
1501
1502         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
1503         https://bugs.webkit.org/show_bug.cgi?id=177101
1504         <rdar://problem/34500648>
1505
1506         Reviewed by Brian Burg.
1507
1508         * WebInspector/WebNodeHighlight.mm:
1509         Ensure we close the window that we have just removed.
1510
1511 2017-09-20  Antti Koivisto  <antti@apple.com>
1512
1513         Remove DOM and styling support for CSS Regions
1514         https://bugs.webkit.org/show_bug.cgi?id=177221
1515
1516         Reviewed by Andreas Kling.
1517
1518         * Configurations/FeatureDefines.xcconfig:
1519         * DOM/DOMCSS.mm:
1520         (kitClass):
1521         * DOM/DOMElement.mm:
1522         (-[DOMElement webkitRegionOverset]): Deleted.
1523
1524 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
1525
1526         Layering violation in Editor::createFragment
1527         https://bugs.webkit.org/show_bug.cgi?id=176123
1528
1529         Reviewed by Darin Adler.
1530
1531         * Misc/WebNSURLExtras.h:
1532         * Misc/WebNSURLExtras.mm:
1533         * WebView/WebFrame.mm:
1534         * WebView/WebHTMLView.mm:
1535         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
1536
1537         * WebCoreSupport/WebEditorClient.mm:
1538         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
1539         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
1540         way to avoid exporting the symbol just on newer OSes.
1541
1542 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
1543
1544         On iOS, getData can't get text set by setData during copy event
1545         https://bugs.webkit.org/show_bug.cgi?id=176980
1546         <rdar://problem/34453915>
1547
1548         Reviewed by Darin Adler.
1549
1550         * WebCoreSupport/WebPlatformStrategies.h:
1551         * WebCoreSupport/WebPlatformStrategies.mm:
1552         (WebPlatformStrategies::copy): Deleted.
1553
1554 2017-09-18  Andy Estes  <aestes@apple.com>
1555
1556         [Mac] Upstream miscellaneous WebKitSystemInterface functions
1557         https://bugs.webkit.org/show_bug.cgi?id=177029
1558
1559         Reviewed by Alex Christensen.
1560
1561         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1562         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
1563         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1564         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1565         * WebCoreSupport/PopupMenuMac.mm:
1566         (PopupMenuMac::show):
1567         * WebCoreSupport/WebSystemInterface.mm:
1568         (InitWebCoreSystemInterface):
1569         * WebView/WebHTMLView.mm:
1570         (-[WebHTMLView setDataSource:]):
1571         (-[WebHTMLView attachRootLayer:]):
1572         * WebView/WebView.mm:
1573         (-[WebView _needsAdobeFrameReloadingQuirk]):
1574         (-[WebView _needsLinkElementTextCSSQuirk]):
1575         (-[WebView _needsIsLoadingInAPISenseQuirk]):
1576         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
1577         (-[WebView _preferencesChanged:]):
1578
1579 2017-09-15  Andy Estes  <aestes@apple.com>
1580
1581         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
1582         https://bugs.webkit.org/show_bug.cgi?id=176953
1583
1584         Reviewed by Eric Carlson.
1585
1586         * WebCoreSupport/WebSystemInterface.mm:
1587         (InitWebCoreSystemInterface):
1588
1589 2017-09-14  Andy Estes  <aestes@apple.com>
1590
1591         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
1592         https://bugs.webkit.org/show_bug.cgi?id=176931
1593
1594         Reviewed by Joseph Pecoraro.
1595
1596         * WebCoreSupport/WebSystemInterface.mm:
1597         (InitWebCoreSystemInterface):
1598
1599 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1600
1601         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
1602         https://bugs.webkit.org/show_bug.cgi?id=176867
1603
1604         Reviewed by Sam Weinig.
1605
1606         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1607         (WebKit::NetscapePluginInstanceProxy::enumerate):
1608
1609 2017-09-13  Andy Estes  <aestes@apple.com>
1610
1611         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
1612         https://bugs.webkit.org/show_bug.cgi?id=176729
1613
1614         Reviewed by Alex Christensen.
1615
1616         * WebCoreSupport/WebSystemInterface.mm:
1617         (InitWebCoreSystemInterface):
1618         * WebView/WebView.mm:
1619         (+[WebView _setCacheModel:]):
1620
1621 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1622
1623         Refactor WebContentReader out of EditorMac and EditorIOS
1624         https://bugs.webkit.org/show_bug.cgi?id=176770
1625
1626         Reviewed by Sam Weinig.
1627
1628         * WebCoreSupport/WebEditorClient.mm:
1629
1630 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
1631
1632         Dragging & dropping a file creates an attachment element even when it's disabled
1633         https://bugs.webkit.org/show_bug.cgi?id=176769
1634
1635         Reviewed by Tim Horton.
1636
1637         * WebView/WebView.mm:
1638         (-[WebView _preferencesChanged:]):
1639
1640 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1641
1642         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
1643         https://bugs.webkit.org/show_bug.cgi?id=176721
1644         <rdar://problem/34373660>
1645
1646         Reviewed by Tim Horton.
1647
1648         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
1649         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
1650
1651         * WebView/WebView.mm:
1652         (-[WebView _startDrag:]):
1653         (-[WebView _draggedElementBounds]):
1654         (-[WebView _endedDataInteraction:global:]):
1655         * WebView/WebViewData.h:
1656
1657 2017-09-11  Andy Estes  <aestes@apple.com>
1658
1659         [Mac] Upstream QTKit-related WebKitSystemInterface functions
1660         https://bugs.webkit.org/show_bug.cgi?id=176472
1661
1662         Reviewed by Eric Carlson.
1663
1664         * WebCoreSupport/WebSystemInterface.mm:
1665         (InitWebCoreSystemInterface):
1666
1667 2017-09-09  Mark Lam  <mark.lam@apple.com>
1668
1669         Avoid duplicate computations of ExecState::vm().
1670         https://bugs.webkit.org/show_bug.cgi?id=176647
1671
1672         Reviewed by Saam Barati.
1673
1674         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1675         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1676         (WebKit::NetscapePluginInstanceProxy::construct):
1677         (WebKit::NetscapePluginInstanceProxy::setProperty):
1678         (WebKit::NetscapePluginInstanceProxy::removeProperty):
1679         (WebKit::NetscapePluginInstanceProxy::enumerate):
1680         * Plugins/Hosted/ProxyInstance.mm:
1681         (WebKit::ProxyRuntimeMethod::create):
1682
1683 2017-09-08  Commit Queue  <commit-queue@webkit.org>
1684
1685         Unreviewed, rolling out r221773.
1686         https://bugs.webkit.org/show_bug.cgi?id=176614
1687
1688         This caused build failures. (Requested by mlewis13 on
1689         #webkit).
1690
1691         Reverted changeset:
1692
1693         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
1694         https://bugs.webkit.org/show_bug.cgi?id=176472
1695         http://trac.webkit.org/changeset/221773
1696
1697 2017-09-07  Andy Estes  <aestes@apple.com>
1698
1699         [Mac] Upstream QTKit-related WebKitSystemInterface functions
1700         https://bugs.webkit.org/show_bug.cgi?id=176472
1701
1702         Reviewed by Eric Carlson.
1703
1704         * WebCoreSupport/WebSystemInterface.mm:
1705         (InitWebCoreSystemInterface):
1706
1707 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
1708
1709         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
1710         https://bugs.webkit.org/show_bug.cgi?id=176561
1711
1712         Reviewed by Brent Fulgham.
1713
1714         * Misc/WebNSUserDefaultsExtras.mm:
1715
1716 2017-09-07  Alex Christensen  <achristensen@webkit.org>
1717
1718         Modernize Geolocation code
1719         https://bugs.webkit.org/show_bug.cgi?id=176496
1720
1721         Reviewed by Andy Estes.
1722
1723         * WebCoreSupport/WebGeolocationClient.h:
1724         * WebCoreSupport/WebGeolocationClient.mm:
1725         (WebGeolocationClient::requestPermission):
1726         (-[WebGeolocationPolicyListener initWithGeolocation:]):
1727         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
1728         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
1729         * WebView/WebView.mm:
1730         (-[WebView _commonInitializationWithFrameName:groupName:]):
1731         (-[WebView _geolocationDidFailWithMessage:]):
1732
1733 2017-09-05  Tim Horton  <timothy_horton@apple.com>
1734
1735         Remove some unused bits of code and resources
1736         https://bugs.webkit.org/show_bug.cgi?id=176275
1737
1738         Reviewed by Dan Bernstein.
1739
1740         * Misc/WebNSFileManagerExtras.mm:
1741         Include FileSystem instead of FileSystemIOS.
1742
1743 2017-09-03  Darin Adler  <darin@apple.com>
1744
1745         [Cocoa] Tidy a few things in legacy WebHTMLView
1746         https://bugs.webkit.org/show_bug.cgi?id=176280
1747
1748         Reviewed by Dan Bernstein.
1749
1750         * WebCoreSupport/WebChromeClient.mm:
1751         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
1752         methods it calls on WebHTMLView were doing nothing on iOS.
1753
1754         * WebView/WebFrame.mm:
1755         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
1756         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
1757
1758         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
1759         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
1760         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
1761         order. Removed all sorts of unused things. Made more code and fields Mac-only where
1762         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
1763         Use RetainPtr instead of writing retain/release wherever possible.
1764         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
1765         initialization for it. Removed various unused methods and declarations of methods.
1766         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
1767         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
1768         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
1769         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
1770         and remove CFRetain no longer needed since we don't support garbage collection any more.
1771         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
1772         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
1773         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
1774         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
1775         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
1776         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
1777         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
1778         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1779         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
1780         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
1781         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
1782         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
1783         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
1784         debug flag; we haven't used it for years and it's not clearly helpful.
1785         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
1786         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
1787         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
1788         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
1789         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
1790         two additional methods in the WebPrivate category and still be called by the two
1791         methods in the WebInternal category that were already using it.
1792         (-[WebHTMLView didAddSubview:]): Deleted.
1793         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
1794         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
1795         place this was called, the close method.
1796         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
1797         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
1798         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
1799         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
1800         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
1801         Added helper method to make the one below simpler.
1802         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1803         Compared pasteboard type strings using isEqualToString: rather than using == since
1804         we want to actually compare the string contents. Also updated to use modern for loop,
1805         renamed a local variable from "s" to "localSubresources", and factored out the handling
1806         of three image types to use the helper method above.
1807         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
1808         _web_makePluginSubviewsPerformSelector:withObject: method.
1809         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
1810         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
1811         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
1812         not call the -[NSView subviews] method to make this identical on both platforms and used
1813         a modern for loop.
1814         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
1815         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
1816         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
1817         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
1818         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
1819         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
1820         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
1821         of it is Mac-only.
1822         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
1823         method did was call itself on the main thread, and do nothing if called on main thread.
1824         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
1825         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
1826         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
1827         half of this method.
1828         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
1829         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
1830         Simplified using a modern for loop and RetainPtr.
1831         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
1832         (-[WebHTMLView keyDown:]): Ditto.
1833         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
1834         (-[WebHTMLView performKeyEquivalent:]): Ditto.
1835         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
1836         (-[WebHTMLView complete:]): Ditto.
1837         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
1838         now macOS-only.
1839         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
1840         iOS since that is now macOS-only.
1841         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
1842         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
1843         a private one because it is not used or needed outside WebKit. Also made it macOS-only
1844         and reorganized to use early return.
1845         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
1846         on iOS, but kept there so we don't have to do #if at every call site.
1847         (-[WebHTMLView _pluginController]): Moved into internal category.
1848         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
1849         there only for GC, using C++ initialization, removing obsolete comment.
1850         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
1851         peculiar iOS-only comment.
1852         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
1853
1854         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
1855         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
1856         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
1857         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
1858         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
1859
1860         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
1861         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
1862         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
1863         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
1864         them at this time.
1865
1866 2017-09-03  Sam Weinig  <sam@webkit.org>
1867
1868         Remove CanvasProxy
1869         https://bugs.webkit.org/show_bug.cgi?id=176288
1870
1871         Reviewed by Yusuke Suzuki.
1872
1873         CanvasProxy does not appear to be in any current HTML spec
1874         and was disabled and unimplemented in our tree. Time to 
1875         get rid of it.
1876
1877         * Configurations/FeatureDefines.xcconfig:
1878
1879 2017-09-02  Andy Estes  <aestes@apple.com>
1880
1881         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
1882         https://bugs.webkit.org/show_bug.cgi?id=176270
1883
1884         Reviewed by Tim Horton.
1885
1886         * Plugins/Hosted/NetscapePluginHostManager.mm:
1887         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1888         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1889         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1890         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
1891         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
1892         (WebKit::SoftwareCARenderer::context const):
1893         (WebKit::SoftwareCARenderer::renderContext const):
1894         (WebKit::SoftwareCARenderer::render):
1895         (-[WebHostedNetscapePluginView createPlugin]):
1896         (-[WebHostedNetscapePluginView createPluginLayer]):
1897         (-[WebHostedNetscapePluginView destroyPlugin]):
1898         (-[WebHostedNetscapePluginView drawRect:]):
1899         * WebCoreSupport/WebSystemInterface.mm:
1900         (InitWebCoreSystemInterface):
1901
1902 2017-09-01  Andy Estes  <aestes@apple.com>
1903
1904         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
1905         https://bugs.webkit.org/show_bug.cgi?id=176200
1906
1907         Reviewed by Tim Horton.
1908
1909         * Carbon/HIWebView.mm:
1910         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
1911         (overrideCGContext):
1912         (restoreCGContext):
1913         (Draw):
1914         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1915         (+[WebHostedNetscapePluginView initialize]):
1916         * Plugins/WebBaseNetscapePluginView.h:
1917         * Plugins/WebBaseNetscapePluginView.mm:
1918         (WebKit::sendUserChangeNotifications):
1919         * Plugins/WebNetscapePluginView.mm:
1920         (+[WebNetscapePluginView initialize]):
1921         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1922         * WebCoreSupport/WebSystemInterface.mm:
1923         (InitWebCoreSystemInterface):
1924         * WebView/WebFrame.mm:
1925         (-[WebFrame _paintBehaviorForDestinationContext:]):
1926         * WebView/WebFullScreenController.mm:
1927         (setClipRectForWindow):
1928         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
1929         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
1930         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
1931         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
1932
1933 2017-08-31  Andy Estes  <aestes@apple.com>
1934
1935         [Mac] Upstream AppKit-related WebKitSystemInterface functions
1936         https://bugs.webkit.org/show_bug.cgi?id=176175
1937
1938         Reviewed by Brady Eidson.
1939
1940         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1941         (WebKit::NetscapePluginInstanceProxy::keyEvent):
1942         * Plugins/Hosted/WebTextInputWindowController.m:
1943         (-[WebTextInputPanel init]):
1944         * WebCoreSupport/WebSystemInterface.mm:
1945         (InitWebCoreSystemInterface):
1946         * WebView/WebDynamicScrollBarsView.mm:
1947         (-[WebDynamicScrollBarsView scrollWheel:]):
1948         * WebView/WebHTMLView.mm:
1949         (-[WebHTMLView _removeWindowObservers]):
1950         (-[WebHTMLView addWindowObservers]):
1951         * WebView/WebView.mm:
1952         (-[WebView addWindowObserversForWindow:]):
1953         (-[WebView removeWindowObservers]):
1954         (-[WebView viewWillMoveToWindow:]):
1955
1956 2017-08-31  Alex Christensen  <achristensen@webkit.org>
1957
1958         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
1959         https://bugs.webkit.org/show_bug.cgi?id=175779
1960         <rdar://problem/22367975>
1961
1962         Reviewed by Tim Horton.
1963
1964         * WebCoreSupport/WebFrameLoaderClient.h:
1965         * WebCoreSupport/WebFrameLoaderClient.mm:
1966         (WebFrameLoaderClient::webGLPolicyForURL const):
1967         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
1968
1969 2017-08-30  Andy Estes  <aestes@apple.com>
1970
1971         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
1972         https://bugs.webkit.org/show_bug.cgi?id=176093
1973
1974         Reviewed by Eric Carlson.
1975
1976         * WebCoreSupport/WebSystemInterface.mm:
1977         (InitWebCoreSystemInterface):
1978
1979 2017-08-30  Andy Estes  <aestes@apple.com>
1980
1981         [Mac] Upstream Carbon-related WebKitSystemInterface functions
1982         https://bugs.webkit.org/show_bug.cgi?id=176087
1983
1984         Reviewed by Alex Christensen.
1985
1986         * Carbon/CarbonUtils.m:
1987         (getNSAutoreleasePoolCount):
1988         (WebInitForCarbon):
1989         (PoolCleaner):
1990         * Carbon/CarbonWindowAdapter.mm:
1991         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1992         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1993         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1994         (-[CarbonWindowAdapter _windowMovedToRect:]):
1995         * Carbon/HIViewAdapter.m:
1996         * Carbon/HIWebView.mm:
1997         (Draw):
1998         (CreateNSEventAdoptingCGEvent):
1999         (CopyEventCGEvent):
2000         (CreateNSEventWithCarbonClickEvent):
2001         (Click):
2002         (CreateNSEventWithCarbonEvent):
2003         (MouseUp):
2004         (CreateNSEventWithCarbonMouseMoveEvent):
2005         (MouseMoved):
2006         (MouseDragged):
2007         (MouseWheelMoved):
2008         (WindowHandler):
2009         (HIWebViewEventHandler):
2010         * Misc/QuickDrawCompatibility.h: Removed.
2011         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2012         (getCarbonEvent):
2013         (WebNetscapePluginEventHandlerCarbon::keyDown):
2014         (WebNetscapePluginEventHandlerCarbon::keyUp):
2015         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2016         (WebNetscapePluginEventHandlerCocoa::keyDown):
2017         * Plugins/WebNetscapePluginView.mm:
2018         (-[WebNetscapePluginView tellQuickTimeToChill]):
2019
2020 2017-08-29  Andy Estes  <aestes@apple.com>
2021
2022         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
2023         https://bugs.webkit.org/show_bug.cgi?id=176046
2024
2025         Reviewed by Alex Christensen.
2026
2027         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
2028         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
2029
2030         * Misc/WebNSFileManagerExtras.mm:
2031         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
2032         (setMetaData): Deleted.
2033         * WebCoreSupport/WebSystemInterface.mm:
2034         (InitWebCoreSystemInterface):
2035
2036 2017-08-28  Andy Estes  <aestes@apple.com>
2037
2038         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
2039         https://bugs.webkit.org/show_bug.cgi?id=176039
2040
2041         Reviewed by Alex Christensen.
2042
2043         * WebCoreSupport/WebSystemInterface.mm:
2044         (InitWebCoreSystemInterface):
2045         * WebView/WebPreferences.mm:
2046         (+[WebPreferences _systemCFStringEncoding]):
2047
2048 2017-08-28  Andy Estes  <aestes@apple.com>
2049
2050         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
2051         https://bugs.webkit.org/show_bug.cgi?id=176032
2052
2053         Reviewed by Alex Christensen.
2054
2055         * WebCoreSupport/WebSystemInterface.mm:
2056         (InitWebCoreSystemInterface):
2057         * WebView/WebView.mm:
2058         (-[WebView _cachedResponseForURL:]):
2059
2060 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2061
2062         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
2063         https://bugs.webkit.org/show_bug.cgi?id=175992
2064         <rdar://problem/34086613>
2065
2066         Reviewed by Daniel Bates.
2067
2068         * WebCoreSupport/WebPlatformStrategies.h:
2069         * WebCoreSupport/WebPlatformStrategies.mm:
2070         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
2071         cookies should be included, and return a pair containing the resulting cookie string and a boolean
2072         indicating if secure cookies were accessed.
2073
2074 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2075
2076         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
2077         https://bugs.webkit.org/show_bug.cgi?id=170955
2078         <rdar://problem/31697653>
2079
2080         Reviewed by Ryosuke Niwa.
2081
2082         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
2083         text is being replaced.
2084
2085         * WebView/WebHTMLView.mm:
2086         (-[WebHTMLView insertText:]):
2087
2088 2017-08-24  Chris Dumez  <cdumez@apple.com>
2089
2090         [Directory Upload] Add basic support for input.webkitdirectory
2091         https://bugs.webkit.org/show_bug.cgi?id=175950
2092         <rdar://problem/33951915>
2093
2094         Reviewed by Geoffrey Garen.
2095
2096         Add private API to toggle Directory Upload support on Mac WebKit1.
2097
2098         * WebView/WebPreferenceKeysPrivate.h:
2099         * WebView/WebPreferences.mm:
2100         (+[WebPreferences initialize]):
2101         (-[WebPreferences setDirectoryUploadEnabled:]):
2102         (-[WebPreferences directoryUploadEnabled]):
2103         * WebView/WebPreferencesPrivate.h:
2104         * WebView/WebView.mm:
2105         (-[WebView _preferencesChanged:]):
2106
2107 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2108
2109         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
2110         https://bugs.webkit.org/show_bug.cgi?id=175370
2111         <rdar://problem/33799806>
2112
2113         Reviewed by Ryosuke Niwa.
2114
2115         Adjust WebEditorClient for interface changes.
2116
2117         * WebCoreSupport/WebEditorClient.h:
2118
2119 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2120
2121         Remove ChromeClient::scrollbarsModeDidChange
2122         https://bugs.webkit.org/show_bug.cgi?id=175805
2123
2124         Reviewed by Daniel Bates.
2125
2126         * WebCoreSupport/WebChromeClient.h:
2127
2128 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2129
2130         Remove ChromeClient::hasOpenedPopup
2131         https://bugs.webkit.org/show_bug.cgi?id=175804
2132
2133         Reviewed by Sam Weinig.
2134
2135         * WebCoreSupport/WebChromeClient.h:
2136         * WebCoreSupport/WebChromeClient.mm:
2137         (WebChromeClient::hasOpenedPopup const): Deleted.
2138
2139 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
2140
2141         Disable access to secure cookies if an HTTPS site loads mixed content
2142         https://bugs.webkit.org/show_bug.cgi?id=157053
2143         <rdar://problem/11290808>
2144
2145         Reviewed by Dan Bates.
2146
2147         * WebCoreSupport/WebPlatformStrategies.h:
2148         * WebCoreSupport/WebPlatformStrategies.mm:
2149         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
2150         indicating whether secure cookies should be included in the response.
2151
2152 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2153
2154         [PAL] Move spi/mac directory into PAL
2155         https://bugs.webkit.org/show_bug.cgi?id=175649
2156
2157         Reviewed by Myles C. Maxfield.
2158
2159         * Misc/WebSharingServicePickerController.h:
2160         * WebCoreSupport/WebContextMenuClient.mm:
2161         * WebCoreSupport/WebEditorClient.mm:
2162         * WebCoreSupport/WebSelectionServiceController.mm:
2163         * WebView/WebHTMLView.mm:
2164         * WebView/WebImmediateActionController.h:
2165         * WebView/WebImmediateActionController.mm:
2166         * WebView/WebView.mm:
2167
2168 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2169
2170         [PAL] Relocate SessionID to root
2171         https://bugs.webkit.org/show_bug.cgi?id=175684
2172
2173         Reviewed by Alex Christensen.
2174
2175         * WebCoreSupport/WebFrameNetworkingContext.mm:
2176
2177 2017-08-17  Andreas Kling  <akling@apple.com>
2178
2179         Disable CSS regions at compile time
2180         https://bugs.webkit.org/show_bug.cgi?id=175630
2181
2182         Reviewed by Antti Koivisto.
2183
2184         * Configurations/FeatureDefines.xcconfig:
2185
2186 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2187
2188         [PAL] Move SessionID into PAL
2189         https://bugs.webkit.org/show_bug.cgi?id=174192
2190
2191         Reviewed by Antti Koivisto.
2192
2193         * Misc/WebCache.mm:
2194         (+[WebCache imageForURL:]):
2195         * WebCoreSupport/WebFrameLoaderClient.h:
2196         * WebCoreSupport/WebFrameLoaderClient.mm:
2197         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2198         * WebCoreSupport/WebFrameNetworkingContext.mm:
2199         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2200         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
2201         (WebFrameNetworkingContext::storageSession const):
2202         * WebCoreSupport/WebPlatformStrategies.h:
2203         * WebCoreSupport/WebPlatformStrategies.mm:
2204         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2205         * WebKitPrefix.h:
2206
2207 2017-08-16  Andy Estes  <aestes@apple.com>
2208
2209         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
2210         https://bugs.webkit.org/show_bug.cgi?id=175648
2211
2212         Reviewed by Tim Horton.
2213
2214         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2215         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2216         (WebPaymentCoordinatorClient::showPaymentUI):
2217
2218 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2219
2220         [PAL] Move spi/ios and spi/win directories into PAL
2221         https://bugs.webkit.org/show_bug.cgi?id=175171
2222
2223         Reviewed by Antti Koivisto.
2224
2225         * WebCoreSupport/WebFrameLoaderClient.mm:
2226         * WebView/WebView.mm:
2227
2228 2017-08-16  Andy Estes  <aestes@apple.com>
2229
2230         [Payment Request] Add an ENABLE flag and an experimental feature preference
2231         https://bugs.webkit.org/show_bug.cgi?id=175622
2232
2233         Reviewed by Tim Horton.
2234
2235         * Configurations/FeatureDefines.xcconfig:
2236
2237 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
2238
2239         [PAL] Move Sleep classes into PAL
2240         https://bugs.webkit.org/show_bug.cgi?id=175456
2241
2242         Reviewed by Ryosuke Niwa.
2243
2244         * WebView/WebFullScreenController.h:
2245
2246 2017-08-15  Youenn Fablet  <youenn@apple.com>
2247
2248         [Cache API] Adding generic support for CacheStorage and Cache methods
2249         https://bugs.webkit.org/show_bug.cgi?id=175455
2250
2251         Reviewed by Chris Dumez.
2252
2253         * WebView/WebView.mm:
2254         (-[WebView _commonInitializationWithFrameName:groupName:]):
2255
2256 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2257
2258         Remove Proximity Events and related code
2259         https://bugs.webkit.org/show_bug.cgi?id=175545
2260
2261         Reviewed by Daniel Bates.
2262
2263         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
2264         and other related code.
2265
2266         * Configurations/FeatureDefines.xcconfig:
2267
2268 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2269
2270         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
2271         https://bugs.webkit.org/show_bug.cgi?id=175504
2272
2273         Reviewed by Sam Weinig.
2274
2275         * Configurations/FeatureDefines.xcconfig:
2276         * DOM/DOMHTMLFormElement.mm:
2277         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
2278         * WebCoreSupport/WebFrameLoaderClient.h:
2279
2280 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2281
2282         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
2283         https://bugs.webkit.org/show_bug.cgi?id=175557
2284
2285         Reviewed by Jon Lee.
2286
2287         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
2288
2289         * Configurations/FeatureDefines.xcconfig:
2290
2291 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
2292
2293         Composition underline color is always black
2294         https://bugs.webkit.org/show_bug.cgi?id=174675
2295
2296         Reviewed by Ryosuke Niwa.
2297
2298         * WebView/WebHTMLView.mm:
2299         (extractUnderlines): If NSUnderlineColorAttributeName
2300         is not present use text color for composition underline.
2301         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
2302         for composition underline in the plain text case.
2303
2304 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
2305
2306         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
2307         https://bugs.webkit.org/show_bug.cgi?id=175474
2308         <rdar://problem/33844628>
2309
2310         Reviewed by Wenson Hsieh.
2311
2312         Replaced the build flag by a runtime flag and disabled the feature by default.
2313
2314         * Configurations/FeatureDefines.xcconfig:
2315         * WebView/WebPreferenceKeysPrivate.h:
2316         * WebView/WebPreferences.mm:
2317         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
2318         (-[WebPreferences dataTransferItemsEnabled]): Added.
2319         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
2320         * WebView/WebPreferencesPrivate.h:
2321         * WebView/WebView.mm:
2322         (-[WebView _preferencesChanged:]):
2323
2324 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2325
2326         Remove ENABLE_GAMEPAD_DEPRECATED
2327         https://bugs.webkit.org/show_bug.cgi?id=175361
2328
2329         Reviewed by Carlos Garcia Campos.
2330
2331         * Configurations/FeatureDefines.xcconfig:
2332
2333 2017-08-09  Chris Dumez  <cdumez@apple.com>
2334
2335         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
2336         https://bugs.webkit.org/show_bug.cgi?id=175401
2337
2338         Reviewed by Brady Eidson.
2339
2340         * WebView/WebPreferenceKeysPrivate.h:
2341         * WebView/WebPreferences.mm:
2342         (+[WebPreferences initialize]):
2343         (-[WebPreferences beaconAPIEnabled]): Deleted.
2344         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
2345         * WebView/WebPreferencesPrivate.h:
2346         * WebView/WebView.mm:
2347         (-[WebView _preferencesChanged:]):
2348
2349 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2350
2351         [PAL] Move spi/cocoa and spi/cg directories into PAL
2352         https://bugs.webkit.org/show_bug.cgi?id=175175
2353
2354         Reviewed by Myles C. Maxfield.
2355
2356         * History/WebHistory.mm:
2357         * Misc/WebDownload.mm:
2358         * Misc/WebKitNSStringExtras.mm:
2359         * Plugins/Hosted/NetscapePluginHostManager.mm:
2360         * Plugins/WebPluginDatabase.mm:
2361         * WebCoreSupport/WebFrameLoaderClient.mm:
2362         * WebInspector/WebNodeHighlight.mm:
2363         * WebView/WebHTMLView.mm:
2364         * WebView/WebIndicateLayer.mm:
2365         * WebView/WebView.mm:
2366         * WebView/WebViewData.h:
2367
2368 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2369
2370         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
2371         https://bugs.webkit.org/show_bug.cgi?id=175392
2372         <rdar://problem/33783207>
2373
2374         Reviewed by Tim Horton and Megan Gardner.
2375
2376         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
2377
2378         * Configurations/FeatureDefines.xcconfig:
2379
2380 2017-08-09  Daniel Bates  <dabates@apple.com>
2381
2382         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
2383         https://bugs.webkit.org/show_bug.cgi?id=175247
2384         <rdar://problem/33679804>
2385
2386         Reviewed by Brady Eidson.
2387
2388         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
2389         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
2390         clients that need to make use of this information at this time. If such a needs comes up
2391         then we can expose API/SPI similar to what we do for WebKit.
2392
2393         * WebCoreSupport/WebFrameLoaderClient.h:
2394         * WebCoreSupport/WebFrameLoaderClient.mm:
2395         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2396
2397 2017-08-08  Brady Eidson  <beidson@apple.com>
2398
2399         Don't enable default icon loading in WK1 for apps linked against old SDKs.
2400         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
2401
2402         Reviewed by Andy Estes.
2403
2404         * Misc/WebKitVersionChecks.h:
2405         * WebCoreSupport/WebFrameLoaderClient.mm:
2406         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
2407           the app is linked against new WebKit with the new behavior.
2408
2409 2017-08-07  Devin Rousso  <drousso@apple.com>
2410
2411         Web Inspector: Preview Canvas path when viewing a recording
2412         https://bugs.webkit.org/show_bug.cgi?id=174967
2413
2414         Reviewed by Brian Burg.
2415
2416         * WebView/WebPreferenceKeysPrivate.h:
2417         * WebView/WebPreferences.mm:
2418         (+[WebPreferences initialize]):
2419         (-[WebPreferences inspectorAdditionsEnabled]):
2420         (-[WebPreferences setInspectorAdditionsEnabled:]):
2421         * WebView/WebPreferencesPrivate.h:
2422         * WebView/WebView.mm:
2423         (-[WebView _preferencesChanged:]):
2424         Add plumbing for new InspectorAdditions runtime flag.
2425
2426 2017-08-07  Brian Burg  <bburg@apple.com>
2427
2428         Remove CANVAS_PATH compilation guard
2429         https://bugs.webkit.org/show_bug.cgi?id=175207
2430
2431         Reviewed by Sam Weinig.
2432
2433         * Configurations/FeatureDefines.xcconfig:
2434
2435 2017-08-04  Youenn Fablet  <youenn@apple.com>
2436
2437         [Cache API] Add Cache and CacheStorage IDL definitions
2438         https://bugs.webkit.org/show_bug.cgi?id=175201
2439
2440         Reviewed by Brady Eidson.
2441
2442         * WebView/WebPreferenceKeysPrivate.h:
2443         * WebView/WebPreferences.mm:
2444         (+[WebPreferences initialize]):
2445         (-[WebPreferences cacheAPIEnabled]):
2446         (-[WebPreferences setCacheAPIEnabled:]):
2447         * WebView/WebPreferencesPrivate.h:
2448         * WebView/WebView.mm:
2449         (-[WebView _preferencesChanged:]):
2450
2451 2017-08-04  Matt Lewis  <jlewis3@apple.com>
2452
2453         Unreviewed, rolling out r220271.
2454
2455         Rolling out due to Layout Test failing on iOS Simulator.
2456
2457         Reverted changeset:
2458
2459         "Remove STREAMS_API compilation guard"
2460         https://bugs.webkit.org/show_bug.cgi?id=175165
2461         http://trac.webkit.org/changeset/220271
2462
2463 2017-08-04  Youenn Fablet  <youenn@apple.com>
2464
2465         Remove STREAMS_API compilation guard
2466         https://bugs.webkit.org/show_bug.cgi?id=175165
2467
2468         Reviewed by Darin Adler.
2469
2470         * Configurations/FeatureDefines.xcconfig:
2471         * WebView/WebPreferences.mm:
2472         (+[WebPreferences initialize]):
2473         * WebView/WebView.mm:
2474         (-[WebView _preferencesChanged:]):
2475
2476 2017-08-03  Brian Burg  <bburg@apple.com>
2477
2478         Remove ENABLE(WEB_SOCKET) guards
2479         https://bugs.webkit.org/show_bug.cgi?id=167044
2480
2481         Reviewed by Joseph Pecoraro.
2482
2483         * Configurations/FeatureDefines.xcconfig:
2484         * WebView/WebPreferencesPrivate.h:
2485
2486 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
2487
2488         [PAL] Move spi/cf directory into PAL
2489         https://bugs.webkit.org/show_bug.cgi?id=175057
2490
2491         Reviewed by Antti Koivisto.
2492
2493         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2494         * Plugins/WebNetscapePluginStream.mm:
2495         * WebCoreSupport/WebFrameNetworkingContext.mm:
2496         * WebView/WebPreferences.mm:
2497         * WebView/WebView.mm:
2498
2499 2017-08-03  Youenn Fablet  <youenn@apple.com>
2500
2501         Remove FETCH_API compilation guard
2502         https://bugs.webkit.org/show_bug.cgi?id=175154
2503
2504         Reviewed by Chris Dumez.
2505
2506         * Configurations/FeatureDefines.xcconfig:
2507         * WebView/WebPreferences.mm:
2508         (+[WebPreferences initialize]):
2509         * WebView/WebView.mm:
2510         (-[WebView _preferencesChanged:]):
2511
2512 2017-08-03  Brady Eidson  <beidson@apple.com>
2513
2514         Add SW IDLs and stub out basic functionality.
2515         https://bugs.webkit.org/show_bug.cgi?id=175115
2516
2517         Reviewed by Chris Dumez.
2518
2519         * Configurations/FeatureDefines.xcconfig:
2520
2521 2017-08-02  Sam Weinig  <sam@webkit.org>
2522
2523         [WebIDL] Convert MutationCallback to be a normal generated callback
2524         https://bugs.webkit.org/show_bug.cgi?id=174140
2525
2526         Reviewed by Darin Adler.
2527
2528         * DOM/DOMDocument.mm:
2529         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
2530         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
2531         Pass, now necessary, Document to NativeNodeFilter constructor.
2532
2533 2017-08-01  Chris Dumez  <cdumez@apple.com>
2534
2535         Add initial support for navigator.sendBeacon
2536         https://bugs.webkit.org/show_bug.cgi?id=175007
2537         <rdar://problem/33547728>
2538
2539         Reviewed by Sam Weinig.
2540
2541         Add setting to toggle support for the Beacon API (it is disabled by default).
2542
2543         * WebView/WebPreferenceKeysPrivate.h:
2544         * WebView/WebPreferences.mm:
2545         (+[WebPreferences initialize]):
2546         (-[WebPreferences beaconAPIEnabled]):
2547         (-[WebPreferences setBeaconAPIEnabled:]):
2548         * WebView/WebPreferencesPrivate.h:
2549         * WebView/WebView.mm:
2550         (-[WebView _preferencesChanged:]):
2551
2552 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
2553
2554         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
2555         https://bugs.webkit.org/show_bug.cgi?id=174437
2556
2557         Reviewed by Darin Adler.
2558
2559         Remove redundant Web- prefix from classes in WebKit namespace.
2560
2561         * WebView/WebView.mm:
2562         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
2563         * WebView/WebViewData.h:
2564         * WebView/WebViewData.mm:
2565
2566 2017-07-26  Brian Burg  <bburg@apple.com>
2567
2568         Remove WEB_TIMING feature flag
2569         https://bugs.webkit.org/show_bug.cgi?id=174795
2570
2571         Reviewed by Alex Christensen.
2572
2573         * Configurations/FeatureDefines.xcconfig:
2574
2575 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
2576
2577         Async image decoding for large images should be disabled after the first time a tile is painted
2578         https://bugs.webkit.org/show_bug.cgi?id=174451
2579         <rdar://problem/31246421>
2580
2581         Reviewed by Simon Fraser.
2582
2583         * WebView/WebFrame.mm:
2584         (-[WebFrame _paintBehaviorForDestinationContext:]):
2585         (-[WebFrame _drawRect:contentsOnly:]):
2586         * WebView/WebHTMLView.mm:
2587         (imageFromRect):
2588
2589 2017-07-23  Darin Adler  <darin@apple.com>
2590
2591         More NeverDestroyed and related cleanup
2592         https://bugs.webkit.org/show_bug.cgi?id=174745
2593
2594         Reviewed by Alex Christensen.
2595
2596         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
2597         for names that aren't even used in this file.
2598         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
2599         -[NSArray arrayWithObject:].
2600         (-[DOMNode absoluteQuads]): Ditto.
2601         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
2602         of writing out various types.
2603         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
2604         syntax instea of -[NSArray arrayWithObject:].
2605         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
2606         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
2607         of writing out various types.
2608         (-[DOMHTMLImageElement mimeType]): Ditto.
2609
2610 2017-07-24  Chris Dumez  <cdumez@apple.com>
2611
2612         ExceptionCode enumeration should use modern exception names
2613         https://bugs.webkit.org/show_bug.cgi?id=174794
2614
2615         Reviewed by Geoffrey Garen.
2616
2617         * DOM/ExceptionHandlers.mm:
2618         (raiseNotSupportedErrorException):
2619
2620 2017-07-23  Chris Dumez  <cdumez@apple.com>
2621
2622         Drop ExceptionCodeDescription class
2623         https://bugs.webkit.org/show_bug.cgi?id=174757
2624
2625         Reviewed by Darin Adler.
2626
2627         Stop using ExceptionCodeDescription.
2628
2629         * DOM/ExceptionHandlers.mm:
2630         (raiseDOMErrorException):
2631
2632 2017-07-21  Andreas Kling  <akling@apple.com>
2633
2634         Use more references in event dispatch code
2635         https://bugs.webkit.org/show_bug.cgi?id=174681
2636
2637         Reviewed by Geoffrey Garen.
2638
2639         * DOM/ObjCEventListener.h:
2640         * DOM/ObjCEventListener.mm:
2641         (WebCore::ObjCEventListener::handleEvent):
2642         * WebCoreSupport/WebFrameLoaderClient.mm:
2643         (NetscapePluginWidget::handleEvent):
2644
2645 2017-07-21  Brady Eidson  <beidson@apple.com>
2646
2647         Get rid of WebCore IconDatabase code.
2648         https://bugs.webkit.org/show_bug.cgi?id=174700
2649
2650         Reviewed by Tim Horton.
2651
2652         * Misc/WebCoreStatistics.mm:
2653         (+[WebCoreStatistics iconPageURLMappingCount]):
2654         (+[WebCoreStatistics iconRetainedPageURLCount]):
2655         (+[WebCoreStatistics iconRecordCount]):
2656         (+[WebCoreStatistics iconsWithDataCount]):
2657         * WebCoreSupport/WebFrameLoaderClient.h:
2658         * WebCoreSupport/WebFrameLoaderClient.mm:
2659         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
2660         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
2661         * WebView/WebView.mm:
2662         (-[WebView mainFrameIconURL]):
2663
2664 2017-07-20  Chris Dumez  <cdumez@apple.com>
2665
2666         Drop legacy XPathException type
2667         https://bugs.webkit.org/show_bug.cgi?id=174679
2668
2669         Reviewed by Sam Weinig.
2670
2671         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
2672         no longer expose XPathException.
2673
2674         * DOM/ExceptionHandlers.mm:
2675         (raiseDOMErrorException):
2676
2677 2017-07-20  Chris Dumez  <cdumez@apple.com>
2678
2679         Unreviewed, rolling out r219706.
2680
2681         Broke iOS build
2682
2683         Reverted changeset:
2684
2685         "Drop legacy XPathException type"
2686         https://bugs.webkit.org/show_bug.cgi?id=174679
2687         http://trac.webkit.org/changeset/219706
2688
2689 2017-07-20  Chris Dumez  <cdumez@apple.com>
2690
2691         Drop legacy XPathException type
2692         https://bugs.webkit.org/show_bug.cgi?id=174679
2693
2694         Reviewed by Sam Weinig.
2695
2696         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
2697         no longer expose XPathException.
2698
2699         * DOM/ExceptionHandlers.mm:
2700         (raiseDOMErrorException):
2701         * WebKit.exp:
2702
2703 2017-07-20  Chris Dumez  <cdumez@apple.com>
2704
2705         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
2706         https://bugs.webkit.org/show_bug.cgi?id=174660
2707
2708         Reviewed by Geoffrey Garen.
2709
2710         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
2711         This essentially replaces a branch to figure out if the new size is less or greater than the
2712         current size by an assertion.
2713
2714         * Plugins/WebNetscapePluginView.mm:
2715         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2716
2717 2017-07-20  Brady Eidson  <beidson@apple.com>
2718
2719         Deprecate WebIconDatabase in WebKitLegacy/mac.
2720         https://bugs.webkit.org/show_bug.cgi?id=174607
2721
2722         Reviewed by Alex Christensen.
2723
2724         This patch:
2725         1 - Formally deprecates WebIconDatabase (which was never API anyways)
2726         2 - Guts the class to where it can only return the default icon at the small size
2727         3 - Reworks other parts of WebKitLegacy that used it for anything to either
2728             use something else or to not do anything.
2729         
2730         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
2731         and that patch will remove all of the last remnants of WebIconDatabase.
2732         
2733         * History/WebHistoryItem.mm:
2734         (-[WebHistoryItem icon]):
2735
2736         * Misc/WebIconDatabase.h:
2737         * Misc/WebIconDatabase.mm:
2738         (-[WebIconDatabase init]):
2739         (-[WebIconDatabase iconForURL:withSize:cache:]):
2740         (-[WebIconDatabase iconForURL:withSize:]):
2741         (-[WebIconDatabase defaultIconWithSize:]):
2742         (-[WebIconDatabase defaultIconForURL:withSize:]):
2743         (-[WebIconDatabase iconURLForURL:]):
2744         (-[WebIconDatabase retainIconForURL:]):
2745         (-[WebIconDatabase releaseIconForURL:]):
2746         (+[WebIconDatabase delayDatabaseCleanup]):
2747         (+[WebIconDatabase allowDatabaseCleanup]):
2748         (-[WebIconDatabase setDelegate:]):
2749         (-[WebIconDatabase delegate]):
2750         (+[WebIconDatabase initialize]): Deleted.
2751         (-[WebIconDatabase isEnabled]): Deleted.
2752         (-[WebIconDatabase setEnabled:]): Deleted.
2753         (-[WebIconDatabase removeAllIcons]): Deleted.
2754         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
2755         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
2756         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
2757         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
2758         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
2759         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
2760         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
2761         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
2762         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
2763         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
2764         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
2765         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
2766         (-[WebIconDatabase _databaseDirectory]): Deleted.
2767         (webGetNSImage): Deleted.
2768
2769         * Misc/WebIconDatabaseDelegate.h: Removed.
2770         * Misc/WebIconDatabaseInternal.h: Removed.
2771         * Misc/WebIconDatabasePrivate.h: Removed.
2772
2773         * WebCoreSupport/WebFrameLoaderClient.mm:
2774         (webGetNSImage):
2775
2776         * WebCoreSupport/WebIconDatabaseClient.mm:
2777         (WebIconDatabaseClient::didRemoveAllIcons):
2778         (WebIconDatabaseClient::didImportIconURLForPageURL):
2779
2780         * WebView/WebView.mm:
2781         (-[WebView setFrameLoadDelegate:]):
2782         (-[WebView mainFrameIcon]):
2783
2784 2017-07-18  Andy Estes  <aestes@apple.com>
2785
2786         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
2787         https://bugs.webkit.org/show_bug.cgi?id=174631
2788
2789         Reviewed by Tim Horton.
2790
2791         * Configurations/Base.xcconfig:
2792
2793 2017-07-18  Andy Estes  <aestes@apple.com>
2794
2795         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
2796         https://bugs.webkit.org/show_bug.cgi?id=174631
2797
2798         Reviewed by Sam Weinig.
2799
2800         * Configurations/Base.xcconfig:
2801
2802 2017-07-18  Andy Estes  <aestes@apple.com>
2803
2804         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
2805         https://bugs.webkit.org/show_bug.cgi?id=174631
2806
2807         Reviewed by Dan Bernstein.
2808
2809         * Configurations/Base.xcconfig:
2810
2811 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2812
2813         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
2814         https://bugs.webkit.org/show_bug.cgi?id=174640
2815         <rdar://problem/33297400>
2816
2817         Reviewed by Tim Horton.
2818
2819         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
2820         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
2821         web thread here, to match the other WebView drag and drop SPI methods.
2822
2823         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
2824         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
2825         should make this robust against future UIKit changes that could make this no longer the case.
2826
2827         * WebView/WebView.mm:
2828         (-[WebView _requestStartDataInteraction:globalPosition:]):
2829         (-[WebView _dataInteractionCaretRect]):
2830
2831 2017-07-18  Andy Estes  <aestes@apple.com>
2832
2833         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
2834         https://bugs.webkit.org/show_bug.cgi?id=174631
2835
2836         Reviewed by Darin Adler.
2837
2838         * Configurations/Base.xcconfig:
2839
2840 2017-07-17  Sam Weinig  <sam@webkit.org>
2841
2842         [WebIDL] Remove custom bindings that require non-caching JS strings
2843         https://bugs.webkit.org/show_bug.cgi?id=174552
2844
2845         Reviewed by Darin Adler.
2846
2847         * DOM/DOMHTMLCanvasElement.mm:
2848         (-[DOMHTMLCanvasElement toDataURL:]):
2849         Update to account for implementation now returning an UncachedString.
2850
2851 2017-07-17  Darin Adler  <darin@apple.com>
2852
2853         Improve use of NeverDestroyed
2854         https://bugs.webkit.org/show_bug.cgi?id=174348
2855
2856         Reviewed by Sam Weinig.
2857
2858         * Misc/WebStringTruncator.mm:
2859         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
2860         NeverDestroyed<RetainPtr> with just an NSFont * global.
2861
2862         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
2863         NeverDestroyed.h.
2864         * Storage/WebDatabaseManager.mm: Ditto.
2865         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
2866         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
2867
2868         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
2869         (aeDescFromJSValue): Removed double hashing by using the return value from
2870         add rather than calling contains before calling add.
2871
2872 2017-07-14  Jer Noble  <jer.noble@apple.com>
2873
2874         Allow clients to override their own hardware media requirements where no fallback media exists.
2875         https://bugs.webkit.org/show_bug.cgi?id=174426
2876         <rdar://problem/32537704>
2877
2878         Reviewed by Eric Carlson.
2879
2880         Add a new WebPreferences property to control WebCore's new
2881         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
2882
2883         * WebView/WebPreferenceKeysPrivate.h:
2884         * WebView/WebPreferences.mm:
2885         (+[WebPreferences initialize]):
2886         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
2887         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
2888         * WebView/WebPreferencesPrivate.h:
2889         * WebView/WebView.mm:
2890         (-[WebView _preferencesChanged:]):
2891
2892 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
2893
2894         Async image decoding for large images should be disabled by default
2895         https://bugs.webkit.org/show_bug.cgi?id=174432
2896
2897         Reviewed by Simon Fraser.
2898
2899         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
2900         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
2901         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
2902            a child view instead of propagating PaintBehaviorSnapshotting.
2903         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
2904            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
2905
2906         * WebView/WebFrame.mm:
2907         (-[WebFrame _paintBehaviorForDestinationContext:]):
2908         (-[WebFrame _drawRect:contentsOnly:]):
2909         * WebView/WebHTMLView.mm:
2910         (imageFromRect):
2911
2912 2017-07-12  Daniel Bates  <dabates@apple.com>
2913
2914         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
2915         https://bugs.webkit.org/show_bug.cgi?id=174427
2916
2917         Rubber-stamped by Brady Eidson.
2918
2919         * WebView/WebPDFView.mm:
2920         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2921
2922 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2923
2924         Unreviewed, rolling out r219401.
2925
2926         This revision rolled out the previous patch, but after talking
2927         with reviewer, a rebaseline is what was needed.Rolling back in
2928         before rebaseline.
2929
2930         Reverted changeset:
2931
2932         "Unreviewed, rolling out r219379."
2933         https://bugs.webkit.org/show_bug.cgi?id=174400
2934         http://trac.webkit.org/changeset/219401
2935
2936 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2937
2938         Unreviewed, rolling out r219379.
2939
2940         This revision caused a consistent failure in the test
2941         fast/dom/Window/property-access-on-cached-window-after-frame-
2942         removed.html.
2943
2944         Reverted changeset:
2945
2946         "Remove NAVIGATOR_HWCONCURRENCY"
2947         https://bugs.webkit.org/show_bug.cgi?id=174400
2948         http://trac.webkit.org/changeset/219379
2949
2950 2017-07-11  Dean Jackson  <dino@apple.com>
2951
2952         Remove NAVIGATOR_HWCONCURRENCY
2953         https://bugs.webkit.org/show_bug.cgi?id=174400
2954
2955         * Configurations/FeatureDefines.xcconfig:
2956
2957 2017-07-11  Dean Jackson  <dino@apple.com>
2958
2959         Rolling out r219372.
2960
2961         * Configurations/FeatureDefines.xcconfig:
2962
2963 2017-07-11  Dean Jackson  <dino@apple.com>
2964
2965         Remove NAVIGATOR_HWCONCURRENCY
2966         https://bugs.webkit.org/show_bug.cgi?id=174400
2967
2968         * Configurations/FeatureDefines.xcconfig:
2969
2970 2017-07-03  Brian Burg  <bburg@apple.com>
2971
2972         Web Replay: remove some unused code
2973         https://bugs.webkit.org/show_bug.cgi?id=173903
2974
2975         Rubber-stamped by Joseph Pecoraro.
2976
2977         * Configurations/FeatureDefines.xcconfig:
2978
2979 2017-07-09  Brady Eidson  <beidson@apple.com>
2980
2981         Remove some obsolete WebKitVersionChecks.
2982         https://bugs.webkit.org/show_bug.cgi?id=174294
2983
2984         Reviewed by Dan Bernstein.
2985
2986         * Misc/WebKitVersionChecks.h:
2987
2988         * WebView/WebHTMLView.mm:
2989         (-[WebHTMLView hitTest:]):
2990
2991         * WebView/WebView.mm:
2992         (shouldRespectPriorityInCSSAttributeSetters):
2993         (-[WebView _commonInitializationWithFrameName:groupName:]):
2994         (-[WebView _preferencesChanged:]):
2995         (shouldTransformsAffectOverflow): Deleted.
2996         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
2997
2998 2017-07-08  Brady Eidson  <beidson@apple.com>
2999
3000         Remove some obsolete RuntimeApplicationChecks.
3001         https://bugs.webkit.org/show_bug.cgi?id=174293
3002
3003         Reviewed by Dan Bernstein.
3004
3005         * Misc/WebKitVersionChecks.h:
3006         * WebView/WebView.mm:
3007         (+[WebView enableWebThread]):
3008         (-[WebView _needsPreHTML5ParserQuirks]):
3009
3010 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3011
3012         Drop NOSNIFF compile flag
3013         https://bugs.webkit.org/show_bug.cgi?id=174289
3014
3015         Reviewed by Michael Catanzaro.
3016
3017         * Configurations/FeatureDefines.xcconfig:
3018
3019 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
3020
3021         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3022         https://bugs.webkit.org/show_bug.cgi?id=174150
3023
3024         Reviewed by Mark Lam.
3025
3026         * DOM/DOM.mm:
3027         (lookupElementClass):
3028
3029 2017-07-06  Brady Eidson  <beidson@apple.com>
3030
3031         Add logging to first attempt to use the WebIconDatabase class.
3032         https://bugs.webkit.org/show_bug.cgi?id=174190
3033
3034         Reviewed by Andy Estes.
3035
3036         * Misc/WebIconDatabase.mm:
3037         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
3038         * Misc/WebKitVersionChecks.h:
3039
3040 2017-07-06  Matt Lewis  <jlewis3@apple.com>
3041
3042         Unreviewed, rolling out r219178.
3043
3044         This caused a consistent failure with the API test
3045         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
3046
3047         Reverted changeset:
3048
3049         "[WTF] Clean up StringStatics.cpp by using
3050         LazyNeverDestroyed<> for Atoms"
3051         https://bugs.webkit.org/show_bug.cgi?id=174150
3052         http://trac.webkit.org/changeset/219178
3053
3054 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
3055
3056         [WTF] Move SoftLinking.h into WTF
3057         https://bugs.webkit.org/show_bug.cgi?id=174000
3058
3059         Reviewed by Alex Christensen.
3060
3061         * Plugins/WebNetscapePluginView.mm:
3062         * Plugins/WebPluginController.mm:
3063         * WebCoreSupport/WebInspectorClient.mm:
3064         * WebView/WebFullScreenController.mm:
3065         * WebView/WebImmediateActionController.mm:
3066         * WebView/WebView.mm:
3067
3068 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3069
3070         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3071         https://bugs.webkit.org/show_bug.cgi?id=174150
3072
3073         Reviewed by Mark Lam.
3074
3075         * DOM/DOM.mm:
3076         (lookupElementClass):
3077
3078 2017-07-05  Brady Eidson  <beidson@apple.com>
3079
3080         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
3081         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
3082
3083         Reviewed by Alex Christensen.
3084
3085         Adopt to the new constructor for FrameLoadRequest.
3086
3087         * WebView/WebPDFView.mm:
3088         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3089
3090 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
3091
3092         Make WebKit's public headers on Mac and iOS C++ module safe
3093         https://bugs.webkit.org/show_bug.cgi?id=174175
3094
3095         Reviewed by Alex Christensen.
3096
3097         Fixed the header files.
3098
3099         * Misc/WebDownload.h:
3100         * Misc/WebKitErrors.h:
3101         * Plugins/WebPluginContainer.h:
3102         * WebView/WebResourceLoadDelegate.h:
3103
3104 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3105
3106         Remove copy of ICU headers from WebKit
3107         https://bugs.webkit.org/show_bug.cgi?id=116407
3108
3109         Reviewed by Alex Christensen.
3110
3111         Use WTF's copy of ICU headers.
3112
3113         * Configurations/WebKitLegacy.xcconfig:
3114         * icu/unicode/localpointer.h: Removed.
3115         * icu/unicode/parseerr.h: Removed.
3116         * icu/unicode/platform.h: Removed.
3117         * icu/unicode/ptypes.h: Removed.
3118         * icu/unicode/putil.h: Removed.
3119         * icu/unicode/uchar.h: Removed.
3120         * icu/unicode/uconfig.h: Removed.
3121         * icu/unicode/ucurr.h: Removed.
3122         * icu/unicode/uidna.h: Removed.
3123         * icu/unicode/uiter.h: Removed.
3124         * icu/unicode/umachine.h: Removed.
3125         * icu/unicode/unorm.h: Removed.
3126         * icu/unicode/unorm2.h: Removed.
3127         * icu/unicode/urename.h: Removed.
3128         * icu/unicode/uscript.h: Removed.
3129         * icu/unicode/ustring.h: Removed.
3130         * icu/unicode/utf.h: Removed.
3131         * icu/unicode/utf16.h: Removed.
3132         * icu/unicode/utf8.h: Removed.
3133         * icu/unicode/utf_old.h: Removed.
3134         * icu/unicode/utypes.h: Removed.
3135         * icu/unicode/uvernum.h: Removed.
3136         * icu/unicode/uversion.h: Removed.
3137
3138 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
3139
3140         Add WebKitPrivateFrameworkStubs for iOS 11
3141         https://bugs.webkit.org/show_bug.cgi?id=173988
3142
3143         Reviewed by David Kilzer.
3144
3145         * Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
3146         use the same directory for private framework stubs.
3147
3148 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3149
3150         Unreviewed, rolling out r219103.
3151
3152         Caused multiple build failures.
3153
3154         Reverted changeset:
3155
3156         "Remove copy of ICU headers from WebKit"
3157         https://bugs.webkit.org/show_bug.cgi?id=116407
3158         http://trac.webkit.org/changeset/219103
3159
3160 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3161
3162         Remove copy of ICU headers from WebKit
3163         https://bugs.webkit.org/show_bug.cgi?id=116407
3164
3165         Reviewed by Alex Christensen.
3166
3167         Use WTF's copy of ICU headers.
3168
3169         * Configurations/WebKitLegacy.xcconfig:
3170         * icu/unicode/localpointer.h: Removed.
3171         * icu/unicode/parseerr.h: Removed.
3172         * icu/unicode/platform.h: Removed.
3173         * icu/unicode/ptypes.h: Removed.
3174         * icu/unicode/putil.h: Removed.
3175         * icu/unicode/uchar.h: Removed.
3176         * icu/unicode/uconfig.h: Removed.
3177         * icu/unicode/ucurr.h: Removed.
3178         * icu/unicode/uidna.h: Removed.
3179         * icu/unicode/uiter.h: Removed.
3180         * icu/unicode/umachine.h: Removed.
3181         * icu/unicode/unorm.h: Removed.
3182         * icu/unicode/unorm2.h: Removed.
3183         * icu/unicode/urename.h: Removed.
3184         * icu/unicode/uscript.h: Removed.
3185         * icu/unicode/ustring.h: Removed.
3186         * icu/unicode/utf.h: Removed.
3187         * icu/unicode/utf16.h: Removed.
3188         * icu/unicode/utf8.h: Removed.
3189         * icu/unicode/utf_old.h: Removed.
3190         * icu/unicode/utypes.h: Removed.
3191         * icu/unicode/uvernum.h: Removed.
3192         * icu/unicode/uversion.h: Removed.
3193
3194 2017-07-03  Brady Eidson  <beidson@apple.com>
3195
3196         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3197         https://bugs.webkit.org/show_bug.cgi?id=174073
3198
3199         Reviewed by Andy Estes.
3200
3201         WebView now keeps a direct copy of its main frame icon as a member variable.
3202         It populates that variable by finding exactly one Favicon LinkIcon from WebCore and loading it.
3203         
3204         This change causes a progression in KVO observation of the mainFrameIcon property as we now
3205         have both the old icon and new icon at the time it changes.
3206
3207         * WebCoreSupport/WebFrameLoaderClient.h:
3208         * WebCoreSupport/WebFrameLoaderClient.mm:
3209         (WebFrameLoaderClient::prepareForDataSourceReplacement):
3210         (WebFrameLoaderClient::getLoadDecisionForIcons):
3211         (WebFrameLoaderClient::finishedLoadingIcon):
3212         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
3213         (WebFrameLoaderClient::registerForIconNotification): Deleted.
3214
3215         * WebView/WebView.mm:
3216         (+[WebView _setIconLoadingEnabled:]):
3217         (+[WebView _isIconLoadingEnabled]):
3218         (-[WebView mainFrameIcon]):
3219         (-[WebView _setMainFrameIcon:]):
3220         (-[WebView _receivedIconChangedNotification:]): Deleted.
3221         (-[WebView _registerForIconNotification:]): Deleted.
3222         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Deleted.
3223         * WebView/WebViewData.h:
3224         * WebView/WebViewInternal.h:
3225         * WebView/WebViewPrivate.h:
3226
3227 2017-07-03  Sam Weinig  <sam@webkit.org>
3228
3229         [WebIDL] Remove more unnecessary uses of the preprocessor in idl files
3230         https://bugs.webkit.org/show_bug.cgi?id=174083
3231
3232         Reviewed by Alex Christensen.
3233
3234         * Configurations/FeatureDefines.xcconfig:
3235         Add ENABLE_NAVIGATOR_STANDALONE.
3236
3237 2017-07-03  Tim Horton  <timothy_horton@apple.com>
3238
3239         Expose unobscuredSafeAreaInsets on WebView
3240         https://bugs.webkit.org/show_bug.cgi?id=174075
3241         <rdar://problem/33096997>
3242
3243         Reviewed by Beth Dakin.
3244
3245         * WebView/WebView.mm:
3246         (-[WebView _setUnobscuredSafeAreaInsets:]):
3247         (-[WebView _unobscuredSafeAreaInsets]):
3248         * WebView/WebViewPrivate.h:
3249         Expose unobscuredSafeAreaInsets as a new private property on WebView,
3250         similar to how it is exposed in WebKit2.
3251
3252 2017-07-03  Andy Estes  <aestes@apple.com>
3253
3254         [Xcode] Add an experimental setting to build with ccache
3255         https://bugs.webkit.org/show_bug.cgi?id=173875
3256
3257         Reviewed by Tim Horton.
3258
3259         * Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
3260
3261 2017-07-03  Tim Horton  <timothy_horton@apple.com>
3262
3263         Expose WebPreferences for viewport-fit and constant() properties
3264         https://bugs.webkit.org/show_bug.cgi?id=174072
3265         <rdar://problem/33096639>
3266
3267         Reviewed by Ryosuke Niwa.
3268
3269         * WebView/WebPreferenceKeysPrivate.h:
3270         * WebView/WebPreferences.mm:
3271         (-[WebPreferences viewportFitEnabled]):
3272         (-[WebPreferences setViewportFitEnabled:]):
3273         (-[WebPreferences constantPropertiesEnabled]):
3274         (-[WebPreferences setConstantPropertiesEnabled:]):
3275         * WebView/WebPreferencesPrivate.h:
3276         * WebView/WebView.mm:
3277         (-[WebView _preferencesChanged:]):
3278
3279 2017-07-01  Tim Horton  <timothy_horton@apple.com>
3280
3281         Expose viewport-fit value to UIKit via viewport arguments dictionary
3282         https://bugs.webkit.org/show_bug.cgi?id=174071
3283         <rdar://problem/33096620>
3284
3285         Reviewed by Wenson Hsieh.
3286
3287         * History/WebHistoryItem.mm:
3288         * History/WebHistoryItemPrivate.h:
3289         Add another dictionary key and three values.
3290
3291 2017-07-01  Dan Bernstein  <mitz@apple.com>
3292
3293         [iOS] Remove code only needed when building for iOS 9.x
3294         https://bugs.webkit.org/show_bug.cgi?id=174068
3295
3296         Reviewed by Tim Horton.
3297
3298         * Configurations/FeatureDefines.xcconfig:
3299
3300 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
3301
3302         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
3303         https://bugs.webkit.org/show_bug.cgi?id=174004
3304
3305         Reviewed by Simon Fraser.
3306
3307         * WebCoreSupport/WebPluginInfoProvider.mm:
3308
3309 2017-07-01  Dan Bernstein  <mitz@apple.com>
3310
3311         [macOS] Remove code only needed when building for OS X Yosemite
3312         https://bugs.webkit.org/show_bug.cgi?id=174067
3313
3314         Reviewed by Tim Horton.
3315
3316         * Configurations/Base.xcconfig:
3317         * Configurations/DebugRelease.xcconfig:
3318         * Configurations/FeatureDefines.xcconfig:
3319         * Configurations/Version.xcconfig:
3320         * Plugins/WebBasePluginPackage.mm:
3321         (-[WebBasePluginPackage getPluginInfoFromPLists]):
3322         * WebCoreSupport/PopupMenuMac.mm:
3323         (PopupMenuMac::show):
3324         * WebCoreSupport/WebInspectorClient.mm:
3325         (WebInspectorFrontendClient::startWindowDrag):
3326         (-[WebInspectorWindowController window]):
3327         * WebView/WebView.mm:
3328         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
3329
3330 2017-06-30  Daniel Bates  <dabates@apple.com>
3331
3332         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3333         https://bugs.webkit.org/show_bug.cgi?id=165160
3334         <rdar://problem/29451999>
3335
3336         Reviewed by Brady Eidson.
3337
3338         Pass the document that is requesting the load to the loader.
3339
3340         * WebView/WebPDFView.mm:
3341         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3342
3343 2017-06-29  Jer Noble  <jer.noble@apple.com>
3344
3345         Make Legacy EME API controlled by RuntimeEnabled setting.
3346         https://bugs.webkit.org/show_bug.cgi?id=173994
3347
3348         Reviewed by Sam Weinig.
3349
3350         Add a new preference used to control WebCore's new RuntimeEnabledFeature setting.
3351
3352         * Configurations/FeatureDefines.xcconfig:
3353         * WebView/WebPreferenceKeysPrivate.h:
3354         * WebView/WebPreferences.mm:
3355         (+[WebPreferences initialize]):
3356         (-[WebPreferences legacyEncryptedMediaAPIEnabled]):
3357         (-[WebPreferences setLegacyEncryptedMediaAPIEnabled:]):
3358         * WebView/WebPreferencesPrivate.h:
3359         * WebView/WebView.mm:
3360         (-[WebView _preferencesChanged:]):
3361
3362 2017-06-30  Chris Dumez  <cdumez@apple.com>
3363
3364         ResourceLoadObserver does not need a ResourceLoadStatisticsStore
3365         https://bugs.webkit.org/show_bug.cgi?id=174013
3366
3367         Reviewed by Brent Fulgham.
3368
3369         ResourceLoadObserver does not need a ResourceLoadStatisticsStore. ResourceLoadStatisticsStore is too complicated for its needs.
3370         ResourceLoadStatisticsStore can then be moved to WebKit2/UIProcess in a follow-up.
3371
3372         * WebView/WebView.mm:
3373         (-[WebView _commonInitializationWithFrameName:groupName:]):
3374
3375 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3376
3377         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
3378         https://bugs.webkit.org/show_bug.cgi?id=174017
3379         <rdar://problem/32959782>
3380
3381         Reviewed by Simon Fraser.
3382
3383         Use root view coordinates when computing the drag caret rect.
3384
3385         * WebView/WebView.mm:
3386         (-[WebView _dataInteractionCaretRect]):
3387
3388 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
3389
3390         Mark the GraphicsContext as accelerated when the WebHTMLView's layer is drawing asynchronously
3391         https://bugs.webkit.org/show_bug.cgi?id=173899
3392         rdar://problem/32994474
3393
3394         Reviewed by Tim Horton.
3395
3396         When the WebHTMLView is layer-backed, and -drawsAsynchronously on its layer is YES,
3397         then mark the GraphicsContext that WebCore is using for drawing as accelerated, so
3398         that ImageBuffer::createCompatibleBuffer() creates appropriately matched buffers.
3399
3400         Also clean up WebFrame a little, sharing code that checks whether the WebFrame's
3401         documentView is a WebHTMLView.
3402
3403         * WebView/WebFrame.mm:
3404         (-[WebFrame _webHTMLDocumentView]):
3405         (-[WebFrame _paintBehaviorForDestinationContext:]):
3406         (-[WebFrame _drawRect:contentsOnly:]):
3407         (-[WebFrame setTimeoutsPaused:]):
3408         (-[WebFrame prepareForPause]):
3409         (-[WebFrame resumeFromPause]):
3410         (-[WebFrame resetTextAutosizingBeforeLayout]):
3411         * WebView/WebHTMLView.mm:
3412         (-[WebHTMLView drawLayer:inContext:]):
3413         (-[WebHTMLView _web_isDrawingIntoAcceleratedLayer]):
3414         * WebView/WebHTMLViewInternal.h:
3415
3416 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3417
3418         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
3419         https://bugs.webkit.org/show_bug.cgi?id=173854
3420         <rdar://problem/32236827>
3421
3422         Reviewed by Ryosuke Niwa and Tim Horton.
3423
3424         Vends some information from the DragItem passed into -[WebView _startDrag:] through the WebView as SPI for
3425         WebKit1 clients. No behavior change with these changes alone -- see <rdar://problem/32991062> for more detail.
3426
3427         * WebView/WebView.mm:
3428         (-[WebView _startDrag:]):
3429         (-[WebView _dragSourceAction]):
3430         (-[WebView _draggedLinkTitle]):
3431         (-[WebView _draggedLinkURL]):
3432         (-[WebView _draggedElementBounds]):
3433         (-[WebView _endedDataInteraction:global:]):
3434         * WebView/WebViewData.h:
3435         * WebView/WebViewPrivate.h:
3436
3437 2017-06-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3438
3439         Refactor drag start codepaths to plumb a DragItem to client layers
3440         https://bugs.webkit.org/show_bug.cgi?id=173832
3441         Work towards <rdar://problem/32236827>
3442
3443         Reviewed by Ryosuke Niwa and Tim Horton.
3444
3445         Refactor code used to start a drag in WebKit1 to plumb a single DragItem from DragController to the client layer
3446         in WebDragClient that contains all the information needed to begin a drag. Also renames _setDataInteractionData:
3447         to _startDrag: to match logic used to start a drag on other platforms.
3448
3449         No behavior change -- the same information should be propagated to AppKit and UIKit when beginning a drag, only
3450         through the DragItem struct.
3451
3452         * WebCoreSupport/WebDragClient.h:
3453         * WebCoreSupport/WebDragClient.mm:
3454         (WebDragClient::startDrag):
3455         (WebDragClient::dragSourceActionMaskForPoint):
3456         (WebDragClient::willPerformDragSourceAction):
3457         (WebDragClient::beginDrag):
3458         * WebView/WebView.mm:
3459         (-[WebView _startDrag:]):
3460         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]): Deleted.
3461         * WebView/WebViewInternal.h:
3462
3463 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
3464
3465         Remove excessive headers from JavaScriptCore
3466         https://bugs.webkit.org/show_bug.cgi?id=173812
3467
3468         Reviewed by Darin Adler.
3469
3470         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3471         * WebView/WebView.mm:
3472
3473 2017-06-23  Tim Horton  <timothy_horton@apple.com>
3474
3475         Remove an unused typedef from WebFrameLoaderClient
3476         https://bugs.webkit.org/show_bug.cgi?id=173795
3477
3478         Reviewed by Simon Fraser.
3479
3480         * WebCoreSupport/WebFrameLoaderClient.h:
3481         This unused typedef in the global namespace conflicts with one in a macOS system header.
3482         Also... it's unused.
3483         Remove it.
3484
3485 2017-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3486
3487         Remove excessive headers from WebCore/{bindings,css,dom}
3488         https://bugs.webkit.org/show_bug.cgi?id=173766
3489
3490         Reviewed by Simon Fraser.
3491
3492         * DOM/DOMInternal.mm:
3493
3494 2017-06-22  Daniel Bates  <dabates@apple.com>
3495
3496         Make FrameLoadRequest a move-only type
3497         https://bugs.webkit.org/show_bug.cgi?id=173682
3498
3499         Reviewed by Alex Christensen and Darin Adler.
3500
3501         A FrameLoadRequest groups together the information to perform a load into a single object
3502         that is more manageable to pass around than its constituent parts. Code that receives a
3503         FrameLoadRequest is expected to extract out the information it needs to complete its task.
3504         And it does not make sense to re-use the same FrameLoadRequest object for more than one
3505     &nb