Adjust geolocation feature flag
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-04-20  Tim Horton  <timothy_horton@apple.com>
2
3         Adjust geolocation feature flag
4         https://bugs.webkit.org/show_bug.cgi?id=184856
5
6         Reviewed by Wenson Hsieh.
7
8         * Configurations/FeatureDefines.xcconfig:
9
10 2018-04-18  Jer Noble  <jer.noble@apple.com>
11
12         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
13         https://bugs.webkit.org/show_bug.cgi?id=184762
14
15         Reviewed by Dan Bernstein.
16
17         * Configurations/WebKitLegacy.xcconfig:
18
19 2018-04-20  Youenn Fablet  <youenn@apple.com>
20
21         Make PluginData cache its web visible plugins
22         https://bugs.webkit.org/show_bug.cgi?id=184421
23
24         Reviewed by Chris Dumez.
25
26         * WebCoreSupport/WebPluginInfoProvider.h:
27         * WebCoreSupport/WebPluginInfoProvider.mm:
28         (WebPluginInfoProvider::pluginInfo):
29         (WebPluginInfoProvider::webVisiblePluginInfo):
30
31 2018-04-19  Chris Dumez  <cdumez@apple.com>
32
33         Rename JSDOMWindowProxy to JSWindowProxy
34         https://bugs.webkit.org/show_bug.cgi?id=184797
35
36         Reviewed by Sam Weinig.
37
38         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
39
40         * DOM/DOMUtility.mm:
41         (createDOMWrapper):
42         * WebView/WebFrame.mm:
43         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
44
45 2018-04-19  David Kilzer  <ddkilzer@apple.com>
46
47         Enable Objective-C weak references
48         <https://webkit.org/b/184789>
49         <rdar://problem/39571716>
50
51         Reviewed by Dan Bernstein.
52
53         * Configurations/Base.xcconfig:
54         (CLANG_ENABLE_OBJC_WEAK): Enable.
55
56 2018-04-18  Chris Dumez  <cdumez@apple.com>
57
58         Rename WindowProxyController to WindowProxy
59         https://bugs.webkit.org/show_bug.cgi?id=184756
60
61         Reviewed by Sam Weinig.
62
63         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
64         needed use WindowProxyController type, which was a bit confusing.
65
66         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
67         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
68         * WebView/WebFrame.mm:
69         (-[WebFrame _attachScriptDebugger]):
70
71 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
72
73         Unreviewed rollout of r230632. Regression in memory usage.
74
75         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
76
77         * WebView/WebPreferences.mm:
78         (+[WebPreferences initialize]):
79
80 2018-04-17  Chris Dumez  <cdumez@apple.com>
81
82         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
83         https://bugs.webkit.org/show_bug.cgi?id=184678
84         <rdar://problem/39422122>
85
86         Reviewed by Alex Christensen.
87
88         Add new parameter to dispatchDecidePolicyForNavigationAction.
89
90         * WebCoreSupport/WebFrameLoaderClient.h:
91         * WebCoreSupport/WebFrameLoaderClient.mm:
92         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
93
94 2018-04-13  Chris Dumez  <cdumez@apple.com>
95
96         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
97         https://bugs.webkit.org/show_bug.cgi?id=184591
98
99         Reviewed by Sam Weinig.
100
101         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
102         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
103         This is work towards fixing Bug 184515.
104
105         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
106         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
107         * WebView/WebFrame.mm:
108         (-[WebFrame _attachScriptDebugger]):
109
110 2018-04-12  Antoine Quint  <graouts@apple.com>
111
112         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
113         https://bugs.webkit.org/show_bug.cgi?id=184569
114         <rdar://problem/38671301>
115
116         Reviewed by Jon Lee.
117
118         * WebView/WebPreferences.mm:
119
120 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
121
122         [WTF] Remove StaticLock
123         https://bugs.webkit.org/show_bug.cgi?id=184332
124
125         Reviewed by Mark Lam.
126
127         * DOM/DOMInternal.mm:
128         (getDOMWrapper):
129         (addDOMWrapper):
130         (removeDOMWrapper):
131
132 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
133
134         Failures from mach port reference handling should be fatal
135         https://bugs.webkit.org/show_bug.cgi?id=184202
136         <rdar://problem/37771114>
137
138         Reviewed by Anders Carlsson.
139
140         * Plugins/Hosted/NetscapePluginHostManager.mm:
141         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
142
143 2018-04-03  Andy Estes  <aestes@apple.com>
144
145         [Mac] Prioritize file promises over filenames during drag and drop
146         https://bugs.webkit.org/show_bug.cgi?id=184237
147         <rdar://problem/38278076>
148
149         Reviewed by Wenson Hsieh.
150
151         * WebView/WebView.mm:
152         (-[WebView performDragOperation:]):
153
154 2018-04-03  Chris Dumez  <cdumez@apple.com>
155
156         Drop MainFrame class
157         https://bugs.webkit.org/show_bug.cgi?id=184191
158
159         Reviewed by Darin Adler.
160
161         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
162         relationship between the Page and the MainFrame.
163
164         This is ground work for introducing LocalFrame / RemoteFrame concepts.
165
166         * WebCoreSupport/WebDragClient.mm:
167         * WebCoreSupport/WebFrameLoaderClient.mm:
168         * WebCoreSupport/WebInspectorClient.mm:
169         * WebCoreSupport/WebPlatformStrategies.mm:
170         * WebCoreSupport/WebPluginInfoProvider.mm:
171         * WebView/WebFrame.mm:
172         * WebView/WebFrameView.mm:
173         * WebView/WebHTMLView.mm:
174         * WebView/WebView.mm:
175
176 2018-04-02  Jer Noble  <jer.noble@apple.com>
177
178         Enable Legacy EME for all WebKit & WebKitLegacy clients
179         https://bugs.webkit.org/show_bug.cgi?id=184018
180         <rdar://problem/34887387>
181
182         Reviewed by Eric Carlson.
183
184         * WebView/WebPreferences.mm:
185         (+[WebPreferences initialize]):
186
187 2018-03-29  JF Bastien  <jfbastien@apple.com>
188
189         Use Forward.h instead of forward-declaring WTF::String
190         https://bugs.webkit.org/show_bug.cgi?id=184172
191         <rdar://problem/39026146>
192
193         Reviewed by Yusuke Suzuki.
194
195         As part of #184164 I'm changing WTF::String, and the forward
196         declarations are just wrong because I'm making it templated. We
197         should use Forward.h anyways, so do that instead.
198
199         * WebView/WebScriptDebugger.h:
200
201 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
202
203         Protect against invalid mach ports returned by mach_port_request_notification
204         https://bugs.webkit.org/show_bug.cgi?id=184106
205         <rdar://problem/37865316>
206
207         Reviewed by Chris Dumez.
208
209         * Plugins/Hosted/NetscapePluginHostProxy.mm:
210         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
211         and clean up if it experienced an error.
212         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
213
214 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
215
216         Avoid uninitialized mach ports
217         https://bugs.webkit.org/show_bug.cgi?id=184090
218         <rdar://problem/37261129>
219
220         Reviewed by Chris Dumez.
221
222         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
223         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
224         there is a potential for us to try to use invalid ports.
225
226         We should always check return values, and ensure that the mach port variables we seek to initialize are
227         kept in a valid state.
228
229         Reviewed by Chris Dumez.
230
231         * Plugins/Hosted/NetscapePluginHostManager.h:
232         * Plugins/Hosted/NetscapePluginHostManager.mm:
233         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
234         port is passed to an API function.
235         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
236         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
237         * Plugins/Hosted/NetscapePluginHostProxy.h:
238         * Plugins/Hosted/NetscapePluginHostProxy.mm:
239         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
240         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
241         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
242         (WKPCStatusText): Ditto.
243         (WKPCLoadURL): Ditto.
244         (WKPCCancelLoadURL): Ditto.
245         (WKPCInvalidateRect): Ditto.
246         (WKPCGetScriptableNPObjectReply): Ditto.
247         (WKPCBooleanReply): Ditto.
248         (WKPCBooleanAndDataReply): Ditto.
249         (WKPCInstantiatePluginReply): Ditto.
250         (WKPCGetWindowNPObject): Ditto.
251         (WKPCGetPluginElementNPObject): Ditto.
252         (WKPCForgetBrowserObject): Ditto.
253         (WKPCEvaluate): Ditto.
254         (WKPCGetStringIdentifier): Ditto.
255         (WKPCGetIntIdentifier): Ditto.
256         (WKPCInvoke): Ditto.
257         (WKPCInvokeDefault): Ditto.
258         (WKPCConstruct): Ditto.
259         (WKPCGetProperty): Ditto.
260         (WKPCSetProperty): Ditto.
261         (WKPCRemoveProperty): Ditto.
262         (WKPCHasProperty): Ditto.
263         (WKPCHasMethod): Ditto.
264         (WKPCIdentifierInfo): Ditto.
265         (WKPCEnumerate): Ditto.
266         (WKPCSetMenuBarVisible): Ditto.
267         (WKPCSetFullscreenWindowIsShowing): Ditto.
268         (WKPCSetModal): Ditto.
269         (WKPCGetCookies): Ditto.
270         (WKPCGetProxy): Ditto.
271         (WKPCSetCookies): Ditto.
272         (WKPCGetAuthenticationInfo): Ditto.
273         (WKPCConvertPoint): Ditto.
274         (WKPCLayerHostingModeChanged): Ditto.
275         (WKPCSetException): Ditto.
276
277 2018-03-26  Tim Horton  <timothy_horton@apple.com>
278
279         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
280         https://bugs.webkit.org/show_bug.cgi?id=184030
281         <rdar://problem/38895281>
282
283         Reviewed by Dan Bernstein.
284
285         * Configurations/Base.xcconfig:
286
287 2018-03-26  Chris Dumez  <cdumez@apple.com>
288
289         Use SecurityOriginData more consistently in Service Worker code
290         https://bugs.webkit.org/show_bug.cgi?id=183969
291
292         Reviewed by Darin Adler.
293
294         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
295
296         * Storage/WebDatabaseManager.mm:
297         (-[WebDatabaseManager databasesWithOrigin:]):
298         (-[WebDatabaseManager deleteOrigin:]):
299         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
300         * Storage/WebDatabaseQuotaManager.mm:
301         (-[WebDatabaseQuotaManager usage]):
302         (-[WebDatabaseQuotaManager quota]):
303         (-[WebDatabaseQuotaManager setQuota:]):
304         * Storage/WebStorageManager.mm:
305         (-[WebStorageManager deleteOrigin:]):
306         * WebCoreSupport/WebSecurityOrigin.mm:
307         (-[WebSecurityOrigin databaseIdentifier]):
308         (-[WebSecurityOrigin usage]):
309         (-[WebSecurityOrigin quota]):
310         (-[WebSecurityOrigin setQuota:]):
311
312 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
313
314         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
315         https://bugs.webkit.org/show_bug.cgi?id=183911
316         <rdar://problem/38762306>
317
318         Reviewed by Youenn Fablet.
319
320         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
321
322         * WebView/WebView.mm:
323         (+[WebView initialize]):
324
325 2018-03-26  Alex Christensen  <achristensen@webkit.org>
326
327         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
328         https://bugs.webkit.org/show_bug.cgi?id=183965
329
330         Reviewed by Chris Dumez.
331
332         * WebCoreSupport/WebFrameLoaderClient.h:
333         * WebCoreSupport/WebFrameLoaderClient.mm:
334         (WebFrameLoaderClient::willCacheResponse const):
335
336 2018-03-25  Commit Queue  <commit-queue@webkit.org>
337
338         Unreviewed, rolling out r229954.
339         https://bugs.webkit.org/show_bug.cgi?id=184000
340
341         Caused many layout tests to crash on Apple High Sierra,
342         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
343         by dydz on #webkit).
344
345         Reverted changeset:
346
347         "Use SecurityOriginData more consistently in Service Worker
348         code"
349         https://bugs.webkit.org/show_bug.cgi?id=183969
350         https://trac.webkit.org/changeset/229954
351
352 2018-03-24  Chris Dumez  <cdumez@apple.com>
353
354         Use SecurityOriginData more consistently in Service Worker code
355         https://bugs.webkit.org/show_bug.cgi?id=183969
356
357         Reviewed by Darin Adler.
358
359         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
360
361         * Storage/WebDatabaseManager.mm:
362         (-[WebDatabaseManager databasesWithOrigin:]):
363         (-[WebDatabaseManager deleteOrigin:]):
364         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
365         * Storage/WebDatabaseQuotaManager.mm:
366         (-[WebDatabaseQuotaManager usage]):
367         (-[WebDatabaseQuotaManager quota]):
368         (-[WebDatabaseQuotaManager setQuota:]):
369         * Storage/WebStorageManager.mm:
370         (-[WebStorageManager deleteOrigin:]):
371         * WebCoreSupport/WebSecurityOrigin.mm:
372         (-[WebSecurityOrigin databaseIdentifier]):
373         (-[WebSecurityOrigin usage]):
374         (-[WebSecurityOrigin quota]):
375         (-[WebSecurityOrigin setQuota:]):
376
377 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
378
379         Fix the build
380
381         * WebView/WebView.mm:
382
383 2018-03-23  Tim Horton  <timothy_horton@apple.com>
384
385         Fix the build with no pasteboard
386         https://bugs.webkit.org/show_bug.cgi?id=183973
387
388         Reviewed by Dan Bernstein.
389
390         * Configurations/FeatureDefines.xcconfig:
391         * WebView/WebView.mm:
392         (-[WebView _requestStartDataInteraction:globalPosition:]):
393         (-[WebView _getDataInteractionData]):
394         (-[WebView _dataOperationTextIndicator]):
395         (-[WebView _dragSourceAction]):
396         (-[WebView _draggedLinkTitle]):
397         (-[WebView _draggedLinkURL]):
398         (-[WebView _draggedElementBounds]):
399         (-[WebView _enteredDataInteraction:client:global:operation:]):
400         (-[WebView _updatedDataInteraction:client:global:operation:]):
401         (-[WebView _exitedDataInteraction:client:global:operation:]):
402         (-[WebView _performDataInteraction:client:global:operation:]):
403         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
404         (-[WebView _endedDataInteraction:global:]):
405         (-[WebView _dataInteractionCaretRect]):
406         * WebView/WebViewPrivate.h:
407
408 2018-03-23  Tim Horton  <timothy_horton@apple.com>
409
410         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
411         https://bugs.webkit.org/show_bug.cgi?id=183960
412         <rdar://problem/38812356>
413
414         Reviewed by Dan Bernstein.
415
416         * Configurations/WebKitLegacy.xcconfig:
417
418 2018-03-23  Tim Horton  <timothy_horton@apple.com>
419
420         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
421         https://bugs.webkit.org/show_bug.cgi?id=183954
422         <rdar://problem/38808858>
423
424         Reviewed by Dan Bernstein.
425
426         * WebView/WebPreferences.mm:
427         (-[WebPreferences setAudioSessionCategoryOverride:]):
428
429 2018-03-23  Tim Horton  <timothy_horton@apple.com>
430
431         Adopt WK_PLATFORM_NAME in WebKitLegacy
432         https://bugs.webkit.org/show_bug.cgi?id=183948
433         <rdar://problem/38803908>
434
435         Reviewed by Dan Bernstein.
436
437         * Configurations/WebKitLegacy.xcconfig:
438         * MigrateHeaders.make:
439         * postprocess-headers.sh:
440
441 2018-03-23  Brady Eidson  <beidson@apple.com>
442
443         Go to back/forward list items after a process-swapped navigation.
444         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
445
446         Reviewed by Andy Estes.
447
448         * WebView/WebView.mm:
449         (-[WebView _loadBackForwardListFromOtherView:]):
450         (-[WebView goToBackForwardItem:]):
451
452 2018-03-22  Tim Horton  <timothy_horton@apple.com>
453
454         Improve readability of WebCore's OTHER_LDFLAGS
455         https://bugs.webkit.org/show_bug.cgi?id=183909
456         <rdar://problem/38760992>
457
458         Reviewed by Dan Bernstein.
459
460         * Configurations/Base.xcconfig:
461         * Configurations/FeatureDefines.xcconfig:
462
463 2018-03-20  Tim Horton  <timothy_horton@apple.com>
464
465         Enable the minimal simulator feature flag when appropriate
466         https://bugs.webkit.org/show_bug.cgi?id=183807
467
468         Reviewed by Dan Bernstein.
469
470         * Configurations/FeatureDefines.xcconfig:
471
472 2018-03-20  Tim Horton  <timothy_horton@apple.com>
473
474         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
475         https://bugs.webkit.org/show_bug.cgi?id=183758
476         <rdar://problem/38017644>
477
478         Reviewed by Dan Bernstein.
479
480         * Configurations/FeatureDefines.xcconfig:
481
482 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
483
484         Clear style colors when setting default appearance
485         https://bugs.webkit.org/show_bug.cgi?id=183759
486
487         Reviewed by Tim Horton.
488
489         Colors are cached and need to be cleared and recalculated.
490         Refactor to do all style recalcs together.
491
492         * WebView/WebView.mm:
493         (-[WebView _setDefaultAppearanceAndClearStyle]):
494         (-[WebView _setUseSystemAppearance:]):
495         (-[WebView effectiveAppearanceDidChange]):
496
497 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
498
499         Unreviewed, another quick fix for r229699
500
501         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
502
503         * Configurations/FeatureDefines.xcconfig:
504
505 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
506
507         Ensure that style is updated when the effective appearance changes
508         https://bugs.webkit.org/show_bug.cgi?id=183690
509         <rdar://problem/38385900>
510
511         Reviewed by Tim Horton and Wenson Hsieh.
512
513         Respond to and respect the effective appearance changing.
514
515         * WebView/WebView.mm:
516         (-[WebView _setUseSystemAppearance:]):
517         (-[WebView effectiveAppearanceDidChange]):
518
519 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
520
521         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
522         https://bugs.webkit.org/show_bug.cgi?id=183677
523
524         Reviewed by Tim Horton.
525
526         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
527
528         * DOM/DOM.mm:
529         (-[DOMHTMLLinkElement _mediaQueryMatches]):
530
531 2018-03-14  Tim Horton  <timothy_horton@apple.com>
532
533         Fix the build after r229567
534
535         * Configurations/FeatureDefines.xcconfig:
536
537 2018-03-12  Tim Horton  <timothy_horton@apple.com>
538
539         Stop using SDK conditionals to control feature definitions
540         https://bugs.webkit.org/show_bug.cgi?id=183430
541         <rdar://problem/38251619>
542
543         Reviewed by Dan Bernstein.
544
545         * Configurations/FeatureDefines.xcconfig:
546         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
547
548 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
549
550         Runtime flag for link prefetch and remove link subresource.
551         https://bugs.webkit.org/show_bug.cgi?id=183540
552
553         Reviewed by Chris Dumez.
554
555         Remove the LINK_PREFETCH build time flag.
556
557         * Configurations/FeatureDefines.xcconfig:
558
559 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
560
561         Remove GridLayout runtime flag
562         https://bugs.webkit.org/show_bug.cgi?id=183484
563
564         Reviewed by Myles C. Maxfield.
565
566         The Grid Layout feature has been enabled by default for almost a
567         year, so I think it's time to remove the runtime flag and the
568
569         * WebView/WebPreferenceKeysPrivate.h:
570         * WebView/WebPreferences.mm:
571         (+[WebPreferences initialize]):
572         * WebView/WebPreferencesPrivate.h:
573         * WebView/WebView.mm:
574         (-[WebView _preferencesChanged:]):
575
576 2018-03-12  Antoine Quint  <graouts@apple.com>
577
578         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
579         https://bugs.webkit.org/show_bug.cgi?id=183504
580         <rdar://problem/38372965>
581
582         Reviewed by Dean Jackson and Jon Lee.
583
584         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
585         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
586
587         * WebView/WebPreferenceKeysPrivate.h:
588         * WebView/WebPreferences.mm:
589         (+[WebPreferences initialize]):
590         (-[WebPreferences setModernMediaControlsEnabled:]):
591         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
592         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
593         * WebView/WebPreferencesPrivate.h:
594         * WebView/WebView.mm:
595         (-[WebView _preferencesChanged:]):
596
597 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
598
599         Media query for default appearance
600         https://bugs.webkit.org/show_bug.cgi?id=183539
601         <rdar://problem/38326388>
602
603         Reviewed by Tim Horton.
604
605         Write a media query to evaluate appearance.
606
607         * WebView/WebView.mm:
608         (-[WebView _commonInitializationWithFrameName:groupName:]):
609         (-[WebView _setUseSystemAppearance:]):
610
611 2018-03-09  Andy Estes  <aestes@apple.com>
612
613         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
614         https://bugs.webkit.org/show_bug.cgi?id=183489
615         <rdar://problem/38267517>
616
617         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
618         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
619         to issue a sandbox extension for this directory, but for security reasons App Sandbox
620         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
621         block with a nil error and a valid file URL, but no file will actually exist at that URL.
622
623         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
624         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
625         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
626         drop destination.
627
628         Reviewed by Wenson Hsieh.
629
630         * WebView/WebView.mm:
631         (-[WebView performDragOperation:]):
632
633 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
634
635         Allow WebViews to disable system appearance
636         https://bugs.webkit.org/show_bug.cgi?id=183418
637         <rdar://problem/36975642>
638
639         Reviewed by Tim Horton.
640
641         Allow webviews to choose whether or not to follow the default system appearance.
642
643         * WebView/WebView.mm:
644         (-[WebView _setUseSystemAppearance:]):
645         (-[WebView _useSystemAppearance]):
646         * WebView/WebViewPrivate.h:
647
648 2018-03-08  Youenn Fablet  <youenn@apple.com>
649
650         libwebrtc update broke internal builds
651         https://bugs.webkit.org/show_bug.cgi?id=183454
652
653         Reviewed by Eric Carlson.
654
655         * Configurations/WebKitLegacy.xcconfig:
656
657 2018-03-08  Chris Dumez  <cdumez@apple.com>
658
659         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
660         https://bugs.webkit.org/show_bug.cgi?id=183455
661         <rdar://problem/38191749>
662
663         Reviewed by Youenn Fablet.
664
665         Add a null check for the page as we have evidence from crashes that it can be null.
666         Other functions in WebFrameNetworkingContext already null check the page as well,
667         not just the frame so this is consistent.
668
669         * WebCoreSupport/WebFrameNetworkingContext.mm:
670         (WebFrameNetworkingContext::storageSession const):
671
672 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
673
674         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
675         https://bugs.webkit.org/show_bug.cgi?id=183429
676
677         Reviewed by Mark Lam.
678
679         * DOM/DOM.mm:
680         (+[DOMNode _nodeFromJSWrapper:]):
681         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
682         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
683         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
684         * Plugins/Hosted/ProxyInstance.mm:
685         (WebKit::ProxyInstance::invokeMethod):
686         * WebView/WebView.mm:
687         (aeDescFromJSValue):
688
689 2018-03-08  Tim Horton  <timothy_horton@apple.com>
690
691         Stop linking ApplicationServices directly
692         https://bugs.webkit.org/show_bug.cgi?id=182867
693         <rdar://problem/38252142>
694
695         Reviewed by Alex Christensen.
696
697         The frameworks that we use that live inside ApplicationServices
698         have mostly moved out, so import them directly.
699
700         * Carbon/CarbonUtils.h:
701         * WebKitPrefix.h:
702         * WebView/WebHTMLView.mm:
703         * WebView/WebPDFView.mm:
704
705 2018-03-07  Tim Horton  <timothy_horton@apple.com>
706
707         Sort and separate FeatureDefines.xcconfig
708         https://bugs.webkit.org/show_bug.cgi?id=183427
709
710         Reviewed by Dan Bernstein.
711
712         * Configurations/FeatureDefines.xcconfig:
713         Sort and split FeatureDefines into paragraphs
714         (to make it easier to sort later).
715
716 2018-03-07  Youenn Fablet  <youenn@apple.com>
717
718         Match unsupported plugins based on domains and not origin
719         https://bugs.webkit.org/show_bug.cgi?id=183384
720
721         Reviewed by Chris Dumez.
722
723         * WebCoreSupport/WebPluginInfoProvider.h:
724         * WebCoreSupport/WebPluginInfoProvider.mm:
725         (WebPluginInfoProvider::getPluginInfo):
726         (WebPluginInfoProvider::getWebVisiblePluginInfo):
727
728 2018-03-05  Andy Estes  <aestes@apple.com>
729
730         [Mac] Teach WebCore::Pasteboard about file promise drags
731         https://bugs.webkit.org/show_bug.cgi?id=183314
732         <rdar://problem/38105493>
733
734         Reviewed by Darin Adler.
735
736         Added a FIXME comment.
737
738         * WebView/WebView.mm:
739         (-[WebView performDragOperation:]):
740
741 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
742
743         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
744         https://bugs.webkit.org/show_bug.cgi?id=183312
745
746         Reviewed by Mark Lam.
747
748         Remove wtf/CurrentTime.h include pragma.
749
750         * WebView/WebFrame.mm:
751         * WebView/WebPDFView.mm:
752
753 2018-03-04  Tim Horton  <timothy_horton@apple.com>
754
755         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
756         https://bugs.webkit.org/show_bug.cgi?id=183283
757         <rdar://problem/38062148>
758
759         Reviewed by Sam Weinig.
760
761         * Configurations/FeatureDefines.xcconfig:
762
763 2018-02-28  Alex Christensen  <achristensen@webkit.org>
764
765         Reduce use of NetworkingContext in WebKit
766         https://bugs.webkit.org/show_bug.cgi?id=183213
767
768         Reviewed by Brady Eidson.
769
770         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
771         (WebKit::NetscapePluginInstanceProxy::getProxy):
772         * Plugins/WebNetscapePluginView.mm:
773         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
774
775 2018-02-17  Darin Adler  <darin@apple.com>
776
777         Prepare for ExtendedColor changes (first step)
778         https://bugs.webkit.org/show_bug.cgi?id=182904
779
780         Reviewed by Sam Weinig.
781
782         * Misc/WebKitNSStringExtras.mm:
783         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
784
785 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
786
787         Remove currentTime() / currentTimeMS()
788         https://bugs.webkit.org/show_bug.cgi?id=183052
789
790         Reviewed by Mark Lam.
791
792         * WebCoreSupport/WebFrameLoaderClient.h:
793         * WebCoreSupport/WebFrameLoaderClient.mm:
794         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
795
796 2018-02-16  Youenn Fablet  <youenn@apple.com>
797
798         Allow specifying which plug-ins are supported
799         https://bugs.webkit.org/show_bug.cgi?id=182748
800
801         Reviewed by Chris Dumez.
802
803         * WebCoreSupport/WebPluginInfoProvider.h:
804         * WebCoreSupport/WebPluginInfoProvider.mm:
805         (WebPluginInfoProvider::getPluginInfo):
806         (WebPluginInfoProvider::getWebVisiblePluginInfo):
807
808 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
809
810         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
811         https://bugs.webkit.org/show_bug.cgi?id=182882
812         <rdar://problem/35672661>
813
814         Reviewed by Dan Bernstein.
815
816         Make sure the smart pointer hold the collection of subviews lives at least as
817         long as the loop using it.
818
819         * WebView/WebHTMLView.mm:
820         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
821
822 2018-02-14  Daniel Bates  <dabates@apple.com>
823
824         Disallow cross-origin subresources from asking for credentials
825         https://bugs.webkit.org/show_bug.cgi?id=182579
826         <rdar://problem/36162271>
827
828         Reviewed by Andy Estes.
829
830         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
831         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
832
833         * WebView/WebPreferenceKeysPrivate.h:
834         * WebView/WebPreferences.mm:
835         (+[WebPreferences initialize]):
836         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
837         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
838         * WebView/WebPreferencesPrivate.h:
839         * WebView/WebView.mm:
840         (-[WebView _preferencesChanged:]):
841
842 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
843
844         Remove ForwardingHeaders directory from WebKitLegacy/mac.
845         https://bugs.webkit.org/show_bug.cgi?id=182738
846
847         Reviewed by Darin Adler.
848
849         * ForwardingHeaders/collector/handles/Global.h: Removed.
850         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
851         * ForwardingHeaders/runtime/Completion.h: Removed.
852         * ForwardingHeaders/runtime/Error.h: Removed.
853         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
854         * ForwardingHeaders/runtime/JSFunction.h: Removed.
855         * ForwardingHeaders/runtime/JSLock.h: Removed.
856         * ForwardingHeaders/runtime/JSObject.h: Removed.
857         * ForwardingHeaders/runtime/JSString.h: Removed.
858         * ForwardingHeaders/runtime/Protect.h: Removed.
859         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
860
861 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
862
863         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
864         https://bugs.webkit.org/show_bug.cgi?id=182641
865
866         Reviewed by Dan Bernstein.
867
868         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
869         https://trac.webkit.org/changeset/228308.
870
871         * WebView/WebVideoFullscreenController.h:
872         * WebView/WebVideoFullscreenHUDWindowController.mm:
873         * WebView/WebWindowAnimation.h:
874         * WebView/WebWindowAnimation.mm:
875         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
876         (WebCore::scaledRect): Deleted.
877         (WebCore::squaredDistance): Deleted.
878
879 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
880
881         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
882
883         * WebView/WebWindowAnimation.mm:
884         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
885
886 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
887
888         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
889         https://bugs.webkit.org/show_bug.cgi?id=182615
890
891         Reviewed by Eric Carlson.
892
893         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
894         Ideally, we should not reference NSApp in WebCore.
895
896         * WebView/WebFullScreenController.mm:
897         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
898         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
899         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
900         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
901         * WebView/WebView.mm:
902         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
903         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
904
905 2018-01-13  Darin Adler  <darin@apple.com>
906
907         Event improvements
908         https://bugs.webkit.org/show_bug.cgi?id=179591
909
910         Reviewed by Chris Dumez.
911
912         * DOM/DOMWheelEvent.mm:
913         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
914         Call initWebKitWheelEvent.
915
916         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
917         * WebCoreSupport/WebInspectorClient.mm: Ditto.
918         * WebView/WebFrame.mm: Ditto.
919
920         * WebView/WebHTMLView.mm:
921         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
922         underlyingPlatformEvent.
923         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
924
925         * WebView/WebScriptWorld.mm:
926         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
927
928         * WebView/WebView.mm: Removed include of ScriptValue.h.
929
930 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
931
932         Remove WebCore/ForwardingHeaders directory
933         https://bugs.webkit.org/show_bug.cgi?id=182347
934
935         Reviewed by Keith Miller.
936
937         * Carbon/CarbonWindowAdapter.mm:
938         * DOM/WebDOMOperations.mm:
939         * History/WebBackForwardList.mm:
940         * History/WebHistoryItem.mm:
941         * Misc/WebCache.mm:
942         * Misc/WebElementDictionary.mm:
943         * Misc/WebIconDatabase.mm:
944         * Misc/WebStringTruncator.mm:
945         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
946         * Plugins/Hosted/ProxyInstance.mm:
947         * Plugins/Hosted/ProxyRuntimeObject.mm:
948         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
949         * Plugins/WebBaseNetscapePluginView.mm:
950         * Plugins/WebBasePluginPackage.mm:
951         * Plugins/WebNetscapePluginStream.mm:
952         * Plugins/WebNetscapePluginView.mm:
953         * Plugins/WebPluginController.mm:
954         * WebCoreSupport/WebEditorClient.mm:
955         * WebCoreSupport/WebFrameLoaderClient.mm:
956         * WebCoreSupport/WebInspectorClient.h:
957         * WebCoreSupport/WebInspectorClient.mm:
958         * WebView/WebDataSource.mm:
959         * WebView/WebFrame.mm:
960         * WebView/WebHTMLRepresentation.mm:
961         * WebView/WebHTMLView.mm:
962         * WebView/WebPreferences.mm:
963         * WebView/WebScriptDebugDelegate.mm:
964         * WebView/WebScriptDebugger.h:
965         * WebView/WebTextIterator.mm:
966         * WebView/WebView.mm:
967         * WebView/WebViewData.mm:
968
969 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
970
971         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
972         https://bugs.webkit.org/show_bug.cgi?id=182312
973
974         Reviewed by Michael Catanzaro.
975
976         * WebKitPrefix.h:
977
978 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
979
980         [WebAuthN] Add a compile-time feature flag
981         https://bugs.webkit.org/show_bug.cgi?id=182211
982         <rdar://problem/36936365>
983
984         Reviewed by Brent Fulgham.
985
986         * Configurations/FeatureDefines.xcconfig:
987
988 2018-01-27  Dan Bernstein  <mitz@apple.com>
989
990         HaveInternalSDK includes should be "#include?"
991         https://bugs.webkit.org/show_bug.cgi?id=179670
992
993         * Configurations/Base.xcconfig:
994
995 2018-01-24  Alex Christensen  <achristensen@webkit.org>
996
997         Remove unused QTKit preference
998         https://bugs.webkit.org/show_bug.cgi?id=181968
999
1000         Reviewed by Alexey Proskuryakov.
1001
1002         * WebView/WebPreferenceKeysPrivate.h:
1003         * WebView/WebPreferences.mm:
1004         (+[WebPreferences initialize]):
1005         (-[WebPreferences setQTKitEnabled:]): Deleted.
1006         (-[WebPreferences isQTKitEnabled]): Deleted.
1007         * WebView/WebPreferencesPrivate.h:
1008         * WebView/WebView.mm:
1009         (-[WebView _preferencesChanged:]):
1010
1011 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1012
1013         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
1014         https://bugs.webkit.org/show_bug.cgi?id=182037
1015         <rdar://problem/36747812>
1016
1017         Reviewed by Ryosuke Niwa.
1018
1019         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
1020         for more details.
1021
1022         * WebView/WebHTMLRepresentation.mm:
1023         (-[WebHTMLRepresentation elementWithName:inForm:]):
1024         (-[WebHTMLRepresentation controlsInForm:]):
1025
1026 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1027
1028         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
1029         https://bugs.webkit.org/show_bug.cgi?id=181961
1030
1031         Reviewed by Michael Catanzaro.
1032
1033         * WebView/WebPreferences.mm:
1034
1035 2018-01-23  Commit Queue  <commit-queue@webkit.org>
1036
1037         Unreviewed, rolling out r227437.
1038         https://bugs.webkit.org/show_bug.cgi?id=182011
1039
1040         broke build (Requested by alexchristensen on #webkit).
1041
1042         Reverted changeset:
1043
1044         "Remove unused QTKit preference"
1045         https://bugs.webkit.org/show_bug.cgi?id=181968
1046         https://trac.webkit.org/changeset/227437
1047
1048 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1049
1050         Remove unused QTKit preference
1051         https://bugs.webkit.org/show_bug.cgi?id=181968
1052
1053         Reviewed by Alexey Proskuryakov.
1054
1055         * WebView/WebPreferenceKeysPrivate.h:
1056         * WebView/WebPreferences.mm:
1057         (+[WebPreferences initialize]):
1058         (-[WebPreferences setQTKitEnabled:]): Deleted.
1059         (-[WebPreferences isQTKitEnabled]): Deleted.
1060         * WebView/WebPreferencesPrivate.h:
1061         * WebView/WebView.mm:
1062         (-[WebView _preferencesChanged:]):
1063
1064 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1065
1066         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
1067         https://bugs.webkit.org/show_bug.cgi?id=181960
1068         <rdar://problem/36431678>
1069
1070         Reviewed by Tim Horton.
1071
1072         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
1073         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
1074         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
1075
1076         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
1077         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
1078         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
1079
1080         * WebView/WebView.mm:
1081         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1082
1083 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
1084
1085         Turning off custom pasteboard data doesn't actually turn it off in WK2
1086         https://bugs.webkit.org/show_bug.cgi?id=181920
1087         <rdar://problem/36686429>
1088
1089         Reviewed by Wenson Hsieh.
1090
1091         Always disable custom pasteboard data in WebKit1. See r226156 for details.
1092
1093         * WebView/WebPreferences.mm:
1094         (+[WebPreferences initialize]):
1095         * WebView/WebView.mm:
1096         (-[WebView _preferencesChanged:]):
1097
1098 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1099
1100         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
1101         https://bugs.webkit.org/show_bug.cgi?id=181918
1102
1103         Reviewed by Tim Horton.
1104
1105         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
1106
1107         * Configurations/FeatureDefines.xcconfig:
1108
1109 2018-01-20  Andy Estes  <aestes@apple.com>
1110
1111         [Apple Pay] Stop eagerly loading PassKit.framework
1112         https://bugs.webkit.org/show_bug.cgi?id=181911
1113         <rdar://problem/36555369>
1114
1115         Reviewed by Tim Horton.
1116
1117         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1118         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1119         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
1120
1121         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
1122
1123 2018-01-19  Dean Jackson  <dino@apple.com>
1124
1125         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
1126         https://bugs.webkit.org/show_bug.cgi?id=181817
1127         <rdar://problem/35274055>
1128
1129         Reviewed by Simon Fraser.
1130
1131         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
1132
1133         * Misc/WebKitVersionChecks.h:
1134         * WebView/WebView.mm:
1135         (-[WebView _commonInitializationWithFrameName:groupName:]):
1136
1137 2018-01-19  Alex Christensen  <achristensen@webkit.org>
1138
1139         Remove unused WebViewPrivate _allowCookies
1140         https://bugs.webkit.org/show_bug.cgi?id=181812
1141
1142         Reviewed by Tim Horton.
1143
1144         * WebView/WebView.mm:
1145         (+[WebView _setAllowCookies:]): Deleted.
1146         (+[WebView _allowCookies]): Deleted.
1147         * WebView/WebViewPrivate.h:
1148
1149 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
1150
1151         Build fix, remove a call to -[NSWindow setOneShot:]
1152         https://bugs.webkit.org/show_bug.cgi?id=181809
1153
1154         Reviewed by Tim Horton.
1155
1156         * WebView/WebTextCompletionController.mm:
1157         (-[WebTextCompletionController _buildUI]):
1158
1159 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1160
1161         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
1162
1163         * Carbon/HIWebView.mm:
1164         (overrideCGContext):
1165         (restoreCGContext):
1166
1167 2018-01-18  Dan Bernstein  <mitz@apple.com>
1168
1169         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
1170         https://bugs.webkit.org/show_bug.cgi?id=181803
1171
1172         Reviewed by Tim Horton.
1173
1174         * Configurations/Base.xcconfig: Updated.
1175         * Configurations/DebugRelease.xcconfig: Ditto.
1176         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
1177         * Configurations/Version.xcconfig: Updated.
1178         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
1179           useful for defining settings that depend on the target macOS version.
1180
1181 2018-01-17  Youenn Fablet  <youenn@apple.com>
1182
1183         Put fetch Request.keepalive behind a runtime flag
1184         https://bugs.webkit.org/show_bug.cgi?id=181592
1185
1186         Reviewed by Chris Dumez.
1187
1188         * WebView/WebPreferenceKeysPrivate.h:
1189         * WebView/WebPreferences.mm:
1190         (+[WebPreferences initialize]):
1191         (-[WebPreferences fetchAPIKeepAliveEnabled]):
1192         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
1193         * WebView/WebPreferencesPrivate.h:
1194         * WebView/WebView.mm:
1195         (-[WebView _preferencesChanged:]):
1196
1197 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1198
1199         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1200         https://bugs.webkit.org/show_bug.cgi?id=181637
1201         <rdar://problem/36508471>
1202
1203         Reviewed by Tim Horton.
1204
1205         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1206
1207         * WebCoreSupport/WebEditorClient.h:
1208         * WebCoreSupport/WebEditorClient.mm:
1209         (WebEditorClient::replacementURLForResource):
1210
1211 2018-01-11  Keith Miller  <keith_miller@apple.com>
1212
1213         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1214         https://bugs.webkit.org/show_bug.cgi?id=181573
1215
1216         Reviewed by Simon Fraser.
1217
1218         * Configurations/FeatureDefines.xcconfig:
1219
1220 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1221
1222         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
1223         https://bugs.webkit.org/show_bug.cgi?id=181497
1224
1225         Reviewed by Tim Horton.
1226
1227         See other ChangeLogs for more detail.
1228
1229         * WebCoreSupport/WebDragClient.h:
1230
1231 2018-01-11  Tim Horton  <timothy_horton@apple.com>
1232
1233         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
1234         https://bugs.webkit.org/show_bug.cgi?id=181523
1235         <rdar://problem/28959131>
1236
1237         Reviewed by Alex Christensen.
1238
1239         * WebView/WebImmediateActionController.mm:
1240         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1241         Apply the change made in r216652 to WebKit1's immediate action controller.
1242
1243         Speculative (but successful in WebKit2) fix for non-reproducible crash when
1244         the startContainer of the range is in an anonymous node.
1245
1246 2018-01-11  Youenn Fablet  <youenn@apple.com>
1247
1248         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
1249         https://bugs.webkit.org/show_bug.cgi?id=181480
1250
1251         Reviewed by Eric Carlson.
1252
1253         * WebView/WebPreferences.mm:
1254         (+[WebPreferences initialize]):
1255
1256 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1257
1258         Fix check-webkit-style issues with WebNSDataExtras.mm
1259         <https://webkit.org/b/181369>
1260
1261         Reviewed by Alex Christensen.
1262
1263         * Misc/WebNSDataExtras.mm:
1264         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1265         (-[NSData _webkit_guessedMIMETypeForXML]):
1266         (-[NSData _webkit_guessedMIMEType]):
1267         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1268         (_findEOL):
1269         (-[NSData _webkit_parseRFC822HeaderFields]):
1270         (-[NSData _web_locationAfterFirstBlankLine]):
1271         - Fix all the check-webkit-style warnings.
1272
1273 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1274
1275         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1276         <https://webkit.org/b/181256>
1277         <rdar://problem/36281730>
1278
1279         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1280         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
1281         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
1282           to avoid warnings from casting CFStringRef to NPNSString*.
1283           Note that CFMutableStringRef is the same as CFStringRef
1284           without the const modifier, hence its use in the const_cast<>
1285           above.
1286
1287 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1288
1289         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1290         <https://webkit.org/b/181256>
1291         <rdar://problem/36281730>
1292
1293         * Carbon/HIWebView.mm:
1294         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
1295         checked_cf_cast<CFRunLoopRef>() to fix warning.
1296
1297 2018-01-07  David Kilzer  <ddkilzer@apple.com>
1298
1299         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1300         <https://webkit.org/b/181256>
1301         <rdar://problem/36281730>
1302
1303         Reviewed by Darin Adler.
1304
1305         * Carbon/CarbonUtils.m:
1306         (PoolCleaner):
1307         - Use #pragmas to ignore -Wcast-qual warnings when using a
1308           C-style cast from CFTypeRef to CFRunloopRef.
1309         * Carbon/CarbonWindowFrame.m:
1310         (-[CarbonWindowFrame title]):
1311         - Use #pragmas to ignore -Wcast-qual warnings when using a
1312           C-style cast from CFStringRef to NSString *.
1313         * Carbon/HIViewAdapter.m:
1314         (+[HIViewAdapter getHIViewForNSView:]):
1315         - Use #pragmas to ignore -Wcast-qual warnings when using a
1316           C-style cast from CFTypeRef to HIViewRef.
1317         * Configurations/Base.xcconfig:
1318         (WARNING_CFLAGS): Add -Wcast-qual.
1319         * Misc/WebElementDictionary.mm:
1320         (-[WebElementDictionary objectForKey:]):
1321         - Use static_cast<SEL>(const_cast<void*>()) to fix
1322           warning.
1323         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
1324         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1325         (-[NSData _webkit_guessedMIMETypeForXML]):
1326         (-[NSData _webkit_guessedMIMEType]):
1327         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1328         (_findEOL):
1329         (-[NSData _webkit_parseRFC822HeaderFields]):
1330         (-[NSData _web_startsWithBlankLine]):
1331         (-[NSData _web_locationAfterFirstBlankLine]):
1332         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
1333           type to Objective-C++.  This fixes the warnings about
1334           discarding the `const` modifier when casing from CFStringRef
1335           to NSString * because in older clang versions, -Wcast-qual was
1336           completely broken when compiling C++ and Objective-C++ source
1337           files.  In newer clang versions, discarding the `const`
1338           modifier for toll-free bridged types is ignored when compiling
1339           Objective-C++ source.
1340         - Update copyright and license header.
1341         - Use reinterpret_cast<> and static_cast<> to fix warnings
1342           unrelated to (NSString *) C-style casts.
1343         - Replace use of MIN() macro with std::min<> template functions.
1344         - Fix location of `*` for local variables modified above.
1345         * Plugins/Hosted/NetscapePluginHostManager.mm:
1346         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1347         (WebKit::NetscapePluginHostManager::initializeVendorPort):
1348         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1349         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
1350           warnings.
1351         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1352         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1353         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
1354           to fix warning.
1355         * Plugins/Hosted/ProxyInstance.mm:
1356         (WebKit::ProxyInstance::invoke):
1357         - Use static_cast<char*>(const_cast<void*>()) to fix
1358           warning when using -[NSData bytes].
1359         (WebKit::ProxyInstance::fieldValue const):
1360         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
1361           to fix warning when using CFDataGetBytePtr().
1362         * Plugins/Hosted/WebTextInputWindowController.m:
1363         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1364         - Use #pragma to ignore -Wcast-qual warning since there
1365           is not a good way to avoid this warning in Objective-C.
1366         * Plugins/WebNetscapePluginStream.mm:
1367         (WebNetscapePluginStream::deliverData):
1368         - Use const_cast<void*>() to fix warning when using
1369           -[NSData bytes].
1370         * Plugins/WebNetscapePluginView.mm:
1371         (-[WebNetscapePluginView _createPlugin]):
1372         - Change C-style cast to const_cast<char*>() to fix
1373           warning.
1374         * WebCoreSupport/WebChromeClient.mm:
1375         (WebChromeClient::wrapCryptoKey const):
1376         (WebChromeClient::unwrapCryptoKey const):
1377         - Change C-style cast to
1378           static_cast<uint8_t*>(const_cast<void*>() to fix
1379           warning.
1380         * WebView/WebPDFView.mm:
1381         (_applicationInfoForMIMEType):
1382         - Change local variable type from 'NSURL *' to
1383           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
1384           when calling -[NSURL path].
1385
1386 2018-01-05  Dan Bernstein  <mitz@apple.com>
1387
1388         Fixed the build following AppKit API deprecations in a recent SDKs
1389
1390         * WebView/WebFullScreenController.mm:
1391         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
1392         (-[WebFullScreenController exitFullScreen]): Ditto.
1393         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
1394         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
1395         * WebView/WebHTMLView.mm:
1396         (-[WebHTMLView drawRect:]): Ditto.
1397         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
1398         (-[WebHTMLView knowsPageRange:]): Ditto.
1399         * WebView/WebView.mm:
1400         (LayerFlushController::flushLayers): Ditto.
1401
1402 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1403
1404         [Attachment Support] Create attachment elements when dropping files on iOS
1405         https://bugs.webkit.org/show_bug.cgi?id=181192
1406         <rdar://problem/36280945>
1407
1408         Reviewed by Tim Horton.
1409
1410         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
1411
1412         * WebCoreSupport/WebPlatformStrategies.h:
1413         * WebCoreSupport/WebPlatformStrategies.mm:
1414         (WebPlatformStrategies::informationForItemAtIndex):
1415         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
1416
1417 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1418
1419         [Attachment Support] Add plumbing for starting a drag with promised blob data
1420         https://bugs.webkit.org/show_bug.cgi?id=181201
1421
1422         Reviewed by Tim Horton.
1423
1424         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1425
1426         * WebCoreSupport/WebDragClient.h:
1427
1428 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1429
1430         Add a WebAuthentication runtime feature flag
1431         https://bugs.webkit.org/show_bug.cgi?id=181220
1432         <rdar://problem/36055305>
1433
1434         Reviewed by Brent Fulgham.
1435
1436         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1437
1438         * WebView/WebPreferenceKeysPrivate.h:
1439         * WebView/WebPreferences.mm:
1440         (+[WebPreferences initialize]):
1441         (-[WebPreferences webAuthenticationEnabled]):
1442         (-[WebPreferences setWebAuthenticationEnabled:]):
1443         (-[WebPreferences credentialManagementEnabled]): Deleted.
1444         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1445         * WebView/WebPreferencesPrivate.h:
1446         * WebView/WebView.mm:
1447         (-[WebView _preferencesChanged:]):
1448
1449 2017-12-22  Jeff Miller  <jeffm@apple.com>
1450
1451         Update user-visible copyright strings to include 2018
1452         https://bugs.webkit.org/show_bug.cgi?id=181141
1453
1454         Reviewed by Dan Bernstein.
1455
1456         * Info.plist:
1457
1458 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1459
1460         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1461         https://bugs.webkit.org/show_bug.cgi?id=181188
1462
1463         Reviewed by Dan Bernstein.
1464
1465         See WebCore/ChangeLog for more detail.
1466
1467         * WebCoreSupport/WebDragClient.h:
1468         * WebCoreSupport/WebDragClient.mm:
1469         (WebDragClient::declareAndWriteAttachment): Deleted.
1470         * WebView/WebHTMLView.mm:
1471         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1472
1473 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1474
1475         Unreviewed, continue to fix build failures due to AppKit API deprecation
1476
1477         Wraps more code in -Wdeprecated-declarations.
1478
1479         * Carbon/HIWebView.mm:
1480         (overrideCGContext):
1481
1482 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1483
1484         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1485
1486         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1487
1488         * Carbon/CarbonWindowAdapter.mm:
1489         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1490         * Plugins/WebNetscapePluginView.mm:
1491         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1492         (-[WebNetscapePluginView sendDrawRectEvent:]):
1493         (-[WebNetscapePluginView drawRect:]):
1494
1495 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1496
1497         Fix build failures due to using deprecated AppKit symbols
1498         https://bugs.webkit.org/show_bug.cgi?id=181110
1499         <rdar://problem/36162865>
1500
1501         Reviewed by Dan Bernstein and Tim Horton.
1502
1503         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1504
1505         * Misc/WebKitNSStringExtras.mm:
1506         (-[NSString _web_drawAtPoint:font:textColor:]):
1507         * Misc/WebNSPasteboardExtras.h:
1508         * Misc/WebNSPasteboardExtras.mm:
1509         (+[NSPasteboard _web_writableTypesForURL]):
1510         (_createWritableTypesForImageWithoutArchive):
1511         (_createWritableTypesForImageWithArchive):
1512         (+[NSPasteboard _web_dragTypesForURL]):
1513         (-[NSPasteboard _web_bestURL]):
1514         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1515         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1516         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1517         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1518         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1519         * Panels/WebAuthenticationPanel.m:
1520         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1521         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1522         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1523         (-[WebHostedNetscapePluginView drawRect:]):
1524         * WebInspector/WebNodeHighlightView.mm:
1525         (-[WebNodeHighlightView drawRect:]):
1526         * WebView/WebFrame.mm:
1527         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1528         (-[WebFrame _drawRect:contentsOnly:]):
1529         * WebView/WebHTMLView.mm:
1530         (kit):
1531         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1532         (-[WebHTMLView _plainTextFromPasteboard:]):
1533         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1534         (+[WebHTMLView _insertablePasteboardTypes]):
1535         (+[WebHTMLView _selectionPasteboardTypes]):
1536         (-[WebHTMLView pasteboard:provideDataForType:]):
1537         (-[WebHTMLView _writeSelectionToPasteboard:]):
1538         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1539         (-[WebHTMLView validRequestorForSendType:returnType:]):
1540         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1541         (createMenuItem):
1542         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1543         (-[WebHTMLView _colorAsString:]):
1544         (-[WebHTMLView copyFont:]):
1545         * WebView/WebPDFView.mm:
1546         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1547         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1548         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1549         (-[WebPDFView pasteboardTypesForSelection]):
1550         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1551         * WebView/WebView.h:
1552         * WebView/WebView.mm:
1553         (-[WebView performDragOperation:]):
1554         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1555         (-[WebView _searchWithGoogleFromMenu:]):
1556
1557 2017-12-21  Youenn Fablet  <youenn@apple.com>
1558
1559         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1560         https://bugs.webkit.org/show_bug.cgi?id=181000
1561
1562         Reviewed by Chris Dumez.
1563
1564         * Misc/WebCache.mm:
1565         (+[WebCache addImageToCache:forURL:forFrame:]):
1566
1567 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1568
1569         Update FULLSCREEN_API feature defines.
1570         https://bugs.webkit.org/show_bug.cgi?id=181015
1571
1572         Reviewed by Tim Horton.
1573
1574         Change enabled iphone sdk for FULLSCREEN_API.
1575
1576         * Configurations/FeatureDefines.xcconfig:
1577
1578 2017-12-21  Jer Noble  <jer.noble@apple.com>
1579
1580         Add initial DOM support for Media Capabilities
1581         https://bugs.webkit.org/show_bug.cgi?id=181064
1582
1583         Reviewed by Eric Carlson.
1584
1585         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1586
1587         * WebView/WebPreferenceKeysPrivate.h:
1588         * WebView/WebPreferences.mm:
1589         (+[WebPreferences initialize]):
1590         (-[WebPreferences mediaCapabilitiesEnabled]):
1591         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1592         * WebView/WebPreferencesPrivate.h:
1593         * WebView/WebView.mm:
1594         (-[WebView _preferencesChanged:]):
1595
1596 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1597
1598         Enable picture-in-picture from inline element on suspend.
1599         https://bugs.webkit.org/show_bug.cgi?id=180942
1600         rdar://problem/34745234
1601
1602         Reviewed by Jer Noble.
1603
1604         Update signature of enterVideoFullscreenForVideoElement().
1605
1606         * WebCoreSupport/WebChromeClient.h:
1607         * WebCoreSupport/WebChromeClient.mm:
1608         (WebChromeClient::enterVideoFullscreenForVideoElement):
1609
1610 2017-12-20  Daniel Bates  <dabates@apple.com>
1611
1612         Remove Alternative Presentation Button
1613         https://bugs.webkit.org/show_bug.cgi?id=180500
1614         <rdar://problem/35891047>
1615
1616         Reviewed by Simon Fraser.
1617
1618         We no longer need the alternative presentation button.
1619
1620         * Configurations/FeatureDefines.xcconfig:
1621
1622 2017-12-19  Jer Noble  <jer.noble@apple.com>
1623
1624         Playing media elements which call "pause(); play()" will have the play promise rejected.
1625         https://bugs.webkit.org/show_bug.cgi?id=180781
1626         <rdar://problem/33191377>
1627
1628         Reviewed by Eric Carlson.
1629
1630         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1631
1632         * WebView/WebView.mm:
1633         (shouldRequireUserGestureToLoadVideo):
1634
1635 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1636
1637         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1638         https://bugs.webkit.org/show_bug.cgi?id=180977
1639
1640         Reviewed by Tim Horton.
1641
1642         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1643         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1644         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1645
1646         * WebCoreSupport/WebEditorClient.mm:
1647         (attributesForAttributedStringConversion):
1648         * WebView/WebHTMLView.mm:
1649         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1650
1651 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1652
1653         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1654
1655         Attempt to fix the following warnings:
1656
1657             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1658
1659         For the following instance variables:
1660
1661             _borderView
1662             _contentView
1663             _frame
1664             _wFlags
1665
1666         * Carbon/CarbonWindowAdapter.mm:
1667         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1668         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1669         (-[CarbonWindowAdapter _termWindowIfOwner]):
1670         (-[CarbonWindowAdapter _windowMovedToRect:]):
1671         (-[CarbonWindowAdapter setContentView:]):
1672         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1673         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1674
1675 2017-12-16  Dan Bernstein  <mitz@apple.com>
1676
1677         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1678         https://bugs.webkit.org/show_bug.cgi?id=180613
1679         <rdar://problem/35946124>
1680
1681         Reviewed by Geoff Garen.
1682
1683         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1684           clients.
1685         * WebView/WebDynamicScrollBarsView.h: Ditto.
1686         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1687
1688 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1689
1690         Enable -Wstrict-prototypes for WebKit
1691         <https://webkit.org/b/180757>
1692         <rdar://problem/36024132>
1693
1694         Rubber-stamped by Joseph Pecoraro.
1695
1696         * Configurations/Base.xcconfig:
1697         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1698
1699 2017-12-14  John Wilander  <wilander@apple.com>
1700
1701         Storage Access API: Implement frame-specific access in the document.cookie layer
1702         https://bugs.webkit.org/show_bug.cgi?id=180682
1703         <rdar://problem/35982257>
1704
1705         Reviewed by Alex Christensen.
1706
1707         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1708         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1709         CookiesStrategy::getRawCookies() now take optional parameters for
1710         frameID and pageID to allow frame-specific scoping of cookies.
1711
1712         This change makes the return values of FrameLoaderClient::frameID()
1713         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1714         WebCore can call those getters and get the right return values in
1715         WebKit and std:nullopt in WebKitLegacy.
1716
1717         * WebCoreSupport/WebFrameLoaderClient.h:
1718         * WebCoreSupport/WebFrameLoaderClient.mm:
1719         (WebFrameLoaderClient::pageID const):
1720         (WebFrameLoaderClient::frameID const):
1721         * WebCoreSupport/WebPlatformStrategies.h:
1722         * WebCoreSupport/WebPlatformStrategies.mm:
1723         (WebPlatformStrategies::cookiesForDOM):
1724         (WebPlatformStrategies::setCookiesFromDOM):
1725         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1726         (WebPlatformStrategies::getRawCookies):
1727
1728 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1729
1730         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1731         https://bugs.webkit.org/show_bug.cgi?id=180689
1732
1733         Reviewed by Tim Horton.
1734
1735         Use sRGBColorSpaceRef() from WebCore.
1736
1737         * WebView/WebHTMLView.mm:
1738         (imageFromRect):
1739
1740 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1741
1742         Stop using deprecated target conditional for simulator builds
1743         https://bugs.webkit.org/show_bug.cgi?id=180662
1744         <rdar://problem/35136156>
1745
1746         Reviewed by Simon Fraser.
1747
1748         * postprocess-headers.sh:
1749
1750 2017-12-11  David Quesada  <david_quesada@apple.com>
1751
1752         Turn on ENABLE_APPLICATION_MANIFEST
1753         https://bugs.webkit.org/show_bug.cgi?id=180562
1754         rdar://problem/35924737
1755
1756         Reviewed by Geoffrey Garen.
1757
1758         * Configurations/FeatureDefines.xcconfig:
1759
1760 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1761
1762         Remove pthread_once in favor of dispatch_once
1763         https://bugs.webkit.org/show_bug.cgi?id=180591
1764
1765         Reviewed by Saam Barati.
1766
1767         * Misc/WebKitErrors.m:
1768         (+[NSError _registerWebKitErrors]):
1769         (registerErrors): Deleted.
1770         * Storage/WebStorageManager.mm:
1771         (+[WebStorageManager _storageDirectoryPath]):
1772         (initializeLocalStoragePath): Deleted.
1773
1774 2017-12-07  Darin Adler  <darin@apple.com>
1775
1776         Remove some unused code from WebKitLegacy
1777         https://bugs.webkit.org/show_bug.cgi?id=180567
1778
1779         Reviewed by Anders Carlsson.
1780
1781         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1782         macOS (back a few versions) and iOS and removed unused
1783         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1784         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1785         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1786         _webkit_stringByCollapsingNonPrintingCharacters,
1787         _webkit_stringByCollapsingWhitespaceCharacters,
1788         _web_stringWithData:textEncodingName:, and
1789         _webkit_localStorageDirectoryWithBundleIdentifier:.
1790
1791         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1792         this source file.
1793         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1794         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1795         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1796         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1797         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1798         handle font smoothing options.
1799         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1800         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1801         from header and made it a little clearer.
1802         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1803         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1804         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1805         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1806         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1807         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1808         implementation a bit and used whole words instead of abbreviations.
1809         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1810
1811         * Misc/WebNSFileManagerExtras.mm:
1812         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1813         filenameByFixingIllegalCharacters function from WebCore directly instead of
1814         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1815
1816         * Plugins/WebBaseNetscapePluginView.mm:
1817         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1818         string replacements instead of _web_stringByStrippingReturnCharacters
1819         and to use NSString methods instead of CFString functions.
1820
1821 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1822
1823         Ignore deprecation warnings.
1824
1825         * WebView/WebHTMLView.mm:
1826         (-[NSWindow _web_borderView]):
1827         (-[WebHTMLView _setAsideSubviews]):
1828         * WebView/WebView.mm:
1829         (-[WebView encodeWithCoder:]):
1830
1831 2017-12-02  Darin Adler  <darin@apple.com>
1832
1833         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1834         https://bugs.webkit.org/show_bug.cgi?id=180009
1835
1836         Reviewed by Alex Christensen.
1837
1838         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1839
1840         * Plugins/WebBaseNetscapePluginView.mm:
1841         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1842         of strcasecmp.
1843
1844         * WebView/WebPreferences.mm:
1845         (contains): Ditto. Also made this a template so it's easier to call on an array.
1846         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1847
1848 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1849
1850         Limit user agent versioning to an upper bound
1851         https://bugs.webkit.org/show_bug.cgi?id=180365
1852         <rdar://problem/34550617>
1853
1854         Reviewed by Joseph Pecoraro.
1855
1856         * WebView/WebView.mm:
1857         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1858         creating the User Agent string.
1859         (webKitBundleVersionString): Deleted.
1860
1861 2017-12-05  Andy Estes  <aestes@apple.com>
1862
1863         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1864         https://bugs.webkit.org/show_bug.cgi?id=180457
1865         <rdar://problem/35143007>
1866
1867         Reviewed by Tim Horton.
1868
1869         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1870         check for this macro during post-processing.
1871
1872         * postprocess-headers.sh:
1873
1874 2017-12-04  David Quesada  <david_quesada@apple.com>
1875
1876         Add a class for parsing application manifests
1877         https://bugs.webkit.org/show_bug.cgi?id=177973
1878         rdar://problem/34747949
1879
1880         Reviewed by Geoffrey Garen.
1881
1882         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1883
1884 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1885
1886         Make LegacyCustomProtocolManager optional for network process
1887         https://bugs.webkit.org/show_bug.cgi?id=176230
1888
1889         Reviewed by Alex Christensen.
1890
1891         * Configurations/FeatureDefines.xcconfig:
1892
1893 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1894
1895         Fix some NSOperationQueue leaks
1896         https://bugs.webkit.org/show_bug.cgi?id=180221
1897
1898         Reviewed by Wenson Hsieh.
1899
1900         * WebView/WebView.mm:
1901         (-[WebView performDragOperation:]):
1902
1903 2017-11-30  Darin Adler  <darin@apple.com>
1904
1905         [Mac] remove unneeded RetainPtr use introduced in r225142
1906         https://bugs.webkit.org/show_bug.cgi?id=180202
1907
1908         Reviewed by Tim Horton.
1909
1910         * WebView/WebImmediateActionController.mm:
1911         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1912         RetainPtr.
1913
1914 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1915
1916         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1917         https://bugs.webkit.org/show_bug.cgi?id=175595
1918
1919         Reviewed by Darin Adler.
1920
1921         * WebView/WebPreferences.mm:
1922
1923 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1924
1925         One too many zeroes in macOS version number in FeatureDefines
1926         https://bugs.webkit.org/show_bug.cgi?id=180011
1927
1928         Reviewed by Dan Bernstein.
1929
1930         * Configurations/FeatureDefines.xcconfig:
1931
1932 2017-11-23  Darin Adler  <darin@apple.com>
1933
1934         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1935         https://bugs.webkit.org/show_bug.cgi?id=179981
1936
1937         Reviewed by Sam Weinig.
1938
1939         * WebView/WebImmediateActionController.mm:
1940         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1941         * WebView/WebView.mm:
1942         (coreOptions): Use |= instead of | to build up FindOptions.
1943
1944 2017-11-23  Sam Weinig  <sam@webkit.org>
1945
1946         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1947         https://bugs.webkit.org/show_bug.cgi?id=179954
1948
1949         Reviewed by Darin Adler.
1950
1951         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1952         with direct calls to the corresponding UserGestureIndicator functions.
1953
1954         * Plugins/WebPluginController.mm:
1955         (-[WebPluginController processingUserGesture]):
1956         * WebView/WebView.mm:
1957         (-[WebView _isProcessingUserGesture]):
1958
1959 2017-11-23  Darin Adler  <darin@apple.com>
1960
1961         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1962         https://bugs.webkit.org/show_bug.cgi?id=179907
1963
1964         Reviewed by Sam Weinig.
1965
1966         * History/BinaryPropertyList.cpp:
1967         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1968         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1969         * WebView/WebHTMLRepresentation.mm:
1970         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1971         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1972
1973 2017-11-22  Ali Juma  <ajuma@chromium.org>
1974
1975         Implement VisualViewport API attributes
1976         https://bugs.webkit.org/show_bug.cgi?id=179385
1977
1978         Reviewed by Frédéric Wang.
1979
1980         Add a VisualViewportAPI preference.
1981
1982         * WebView/WebPreferenceKeysPrivate.h:
1983         * WebView/WebPreferences.mm:
1984         (+[WebPreferences initialize]):
1985         (-[WebPreferences visualViewportAPIEnabled]):
1986         (-[WebPreferences setVisualViewportAPIEnabled:]):
1987         * WebView/WebPreferencesPrivate.h:
1988         * WebView/WebView.mm:
1989         (-[WebView _preferencesChanged:]):
1990
1991 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1992
1993         WebCoreObjCExtras.h is being included in too many places
1994         https://bugs.webkit.org/show_bug.cgi?id=179931
1995
1996         Reviewed by Darin Adler.
1997
1998         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1999         * Plugins/WebBaseNetscapePluginView.mm:
2000         * Plugins/WebBasePluginPackage.mm:
2001         * Plugins/WebNetscapePluginStream.mm:
2002         * Plugins/WebNetscapePluginView.mm:
2003         * WebView/WebTextIterator.mm:
2004         * WebView/WebViewData.mm:
2005
2006 2017-11-22  Commit Queue  <commit-queue@webkit.org>
2007
2008         Unreviewed, rolling out r225093.
2009         https://bugs.webkit.org/show_bug.cgi?id=179938
2010
2011         Compilation failed on WinCairo 64-bit Release (Requested by
2012         fredw on #webkit).
2013
2014         Reverted changeset:
2015
2016         "Implement VisualViewport API attributes"
2017         https://bugs.webkit.org/show_bug.cgi?id=179385
2018         https://trac.webkit.org/changeset/225093
2019
2020 2017-11-21  Ali Juma  <ajuma@chromium.org>
2021
2022         Implement VisualViewport API attributes
2023         https://bugs.webkit.org/show_bug.cgi?id=179385
2024
2025         Reviewed by Frédéric Wang.
2026
2027         Add a VisualViewportAPI preference.
2028
2029         * WebView/WebPreferenceKeysPrivate.h:
2030         * WebView/WebPreferences.mm:
2031         (+[WebPreferences initialize]):
2032         (-[WebPreferences visualViewportAPIEnabled]):
2033         (-[WebPreferences setVisualViewportAPIEnabled:]):
2034         * WebView/WebPreferencesPrivate.h:
2035         * WebView/WebView.mm:
2036         (-[WebView _preferencesChanged:]):
2037
2038 2017-11-21  Christopher Reid  <chris.reid@sony.com>
2039
2040         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
2041         https://bugs.webkit.org/show_bug.cgi?id=179504
2042
2043         Reviewed by Darin Adler.
2044
2045         * Misc/WebKitNSStringExtras.mm:
2046         * Plugins/Hosted/NetscapePluginHostManager.mm:
2047         * Plugins/WebBasePluginPackage.mm:
2048
2049 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2050
2051         Remove unused TOUCH_ICON_LOADING feature flag
2052         https://bugs.webkit.org/show_bug.cgi?id=179873
2053
2054         Reviewed by Simon Fraser.
2055
2056         * Configurations/FeatureDefines.xcconfig:
2057
2058 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2059
2060         Remove unused LEGACY_VENDOR_PREFIXES feature flag
2061         https://bugs.webkit.org/show_bug.cgi?id=179872
2062
2063         Reviewed by Darin Adler.
2064
2065         * Configurations/FeatureDefines.xcconfig:
2066
2067 2017-11-16  Daniel Bates  <dabates@apple.com>
2068
2069         Add feature define for alternative presentation button element
2070         https://bugs.webkit.org/show_bug.cgi?id=179692
2071         Part of <rdar://problem/34917108>
2072
2073         Reviewed by Andy Estes.
2074
2075         Only enabled on Cocoa platforms by default.
2076
2077         * Configurations/FeatureDefines.xcconfig:
2078
2079 2017-11-14  Nan Wang  <n_wang@apple.com>
2080
2081         AX: AOM: Implement AccessibleNode class and support label and role attributes
2082         https://bugs.webkit.org/show_bug.cgi?id=179494
2083
2084         Reviewed by Ryosuke Niwa.
2085
2086         * WebView/WebPreferenceKeysPrivate.h:
2087         * WebView/WebPreferences.mm:
2088         (+[WebPreferences initialize]):
2089         (-[WebPreferences accessibilityObjectModelEnabled]):
2090         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
2091         * WebView/WebPreferencesPrivate.h:
2092         * WebView/WebView.mm:
2093         (-[WebView _preferencesChanged:]):
2094
2095 2017-11-14  Alex Christensen  <achristensen@webkit.org>
2096
2097         Remove Cocoa CFURLConnection loading code
2098         https://bugs.webkit.org/show_bug.cgi?id=179688
2099
2100         Reviewed by Antti Koivisto.
2101
2102         * Misc/WebDownload.mm:
2103         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
2104         * Misc/WebDownloadInternal.h:
2105         * Plugins/WebBaseNetscapePluginView.mm:
2106         * WebCoreSupport/WebFrameLoaderClient.mm:
2107         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2108         * WebView/WebView.mm:
2109         (-[WebView scheduleInRunLoop:forMode:]):
2110         (-[WebView unscheduleFromRunLoop:forMode:]):
2111
2112 2017-11-14  Daniel Bates  <dabates@apple.com>
2113
2114         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
2115         for feature defines
2116
2117         Following r195498 and r201917 the Visual Studio property files for feature defines have
2118         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
2119         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
2120         files.
2121
2122         * Configurations/FeatureDefines.xcconfig:
2123
2124 2017-11-14  Jer Noble  <jer.noble@apple.com>
2125
2126         Enable Modern EME tests in DumpRenderTree
2127         https://bugs.webkit.org/show_bug.cgi?id=179544
2128
2129         Reviewed by Alex Christensen.
2130
2131         Add a WebPreferences property to enable the (modern) EME API.
2132
2133         * WebView/WebPreferenceKeysPrivate.h:
2134         * WebView/WebPreferences.mm:
2135         (+[WebPreferences initialize]):
2136         (-[WebPreferences encryptedMediaAPIEnabled]):
2137         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
2138         * WebView/WebPreferencesPrivate.h:
2139         * WebView/WebView.mm:
2140         (-[WebView _preferencesChanged:]):
2141
2142 2017-11-14  Antti Koivisto  <antti@apple.com>
2143
2144         Enable display:contents by default
2145         https://bugs.webkit.org/show_bug.cgi?id=179655
2146
2147         Reviewed by Sam Weinig.
2148
2149         * WebView/WebPreferences.mm:
2150         (+[WebPreferences initialize]):
2151
2152 2017-11-13  Alex Christensen  <achristensen@webkit.org>
2153
2154         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
2155         https://bugs.webkit.org/show_bug.cgi?id=178751
2156
2157         Reviewed by Brady Eidson.
2158
2159         * WebCoreSupport/WebFrameNetworkingContext.mm:
2160         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2161
2162 2017-11-08  Keith Miller  <keith_miller@apple.com>
2163
2164         Async iteration should only fetch the next method once and add feature flag
2165         https://bugs.webkit.org/show_bug.cgi?id=179451
2166
2167         Reviewed by Geoffrey Garen.
2168
2169         Add feature flag for Async iteration.
2170
2171         * Configurations/FeatureDefines.xcconfig:
2172
2173 2017-11-13  Mark Lam  <mark.lam@apple.com>
2174
2175         Add more overflow check book-keeping for MarkedArgumentBuffer.
2176         https://bugs.webkit.org/show_bug.cgi?id=179634
2177         <rdar://problem/35492517>
2178
2179         Reviewed by Saam Barati.
2180
2181         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2182         (WebKit::NetscapePluginInstanceProxy::invoke):
2183         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2184         (WebKit::NetscapePluginInstanceProxy::construct):
2185
2186 2017-11-12  Darin Adler  <darin@apple.com>
2187
2188         More is<> and downcast<>, less static_cast<>
2189         https://bugs.webkit.org/show_bug.cgi?id=179600
2190
2191         Reviewed by Chris Dumez.
2192
2193         * DOM/DOM.mm:
2194         (kit): Use is/downcast.
2195         * WebCoreSupport/WebEditorClient.mm:
2196         (WebEditorClient::handleKeyboardEvent): Ditto.
2197         (WebEditorClient::handleInputMethodKeydown): Ditto.
2198         * WebView/WebHTMLView.mm:
2199         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
2200
2201 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
2202
2203         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
2204         https://bugs.webkit.org/show_bug.cgi?id=179397
2205
2206         Reviewed by Wenson Hsieh.
2207
2208         * DOM/DOMHTMLInputElement.mm:
2209         (-[DOMHTMLInputElement insertTextSuggestion:]):
2210
2211 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
2212
2213         HTMLMediaElement should not use element fullscreen on iOS
2214         https://bugs.webkit.org/show_bug.cgi?id=179418
2215         rdar://problem/35409277
2216
2217         Reviewed by Eric Carlson.
2218
2219         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
2220
2221         * Configurations/FeatureDefines.xcconfig:
2222
2223 2017-11-06  Alex Christensen  <achristensen@webkit.org>
2224
2225         Make ResourceLoader::willSendRequestInternal asynchronous
2226         https://bugs.webkit.org/show_bug.cgi?id=179251
2227
2228         Reviewed by Andy Estes.
2229
2230         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2231         (WebKit::HostedNetscapePluginStream::start):
2232         * Plugins/WebNetscapePluginStream.mm:
2233         (WebNetscapePluginStream::start):
2234
2235 2017-11-01  Darin Adler  <darin@apple.com>
2236
2237         Simplify event dispatch code and make it a bit more consistent
2238         https://bugs.webkit.org/show_bug.cgi?id=178991
2239
2240         Reviewed by Chris Dumez.
2241
2242         * DOM/DOMEvent.mm:
2243         (-[DOMEvent srcElement]): Call target instead of srcElement.
2244
2245 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
2246
2247         [Touch Bar Web API] Add support for menuitem tag
2248         https://bugs.webkit.org/show_bug.cgi?id=179020
2249
2250         Reviewed by Ryosuke Niwa.
2251
2252         Adds in properties and methods that allow the menuitem runtime feature
2253         to be enabled or disabled.
2254
2255         * WebView/WebPreferenceKeysPrivate.h:
2256         * WebView/WebPreferences.mm:
2257         (-[WebPreferences menuItemElementEnabled]):
2258         (-[WebPreferences setMenuItemElementEnabled:]):
2259         * WebView/WebPreferencesPrivate.h:
2260         * WebView/WebView.mm:
2261         (-[WebView _preferencesChanged:]):
2262
2263 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2264
2265         Use CompletionHandlers for redirects
2266         https://bugs.webkit.org/show_bug.cgi?id=179163
2267
2268         Reviewed by Tim Horton.
2269
2270         * Plugins/Hosted/HostedNetscapePluginStream.h:
2271         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2272         (WebKit::HostedNetscapePluginStream::willSendRequest):
2273         * Plugins/WebNetscapePluginStream.h:
2274         * Plugins/WebNetscapePluginStream.mm:
2275         (WebNetscapePluginStream::willSendRequest):
2276
2277 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2278
2279         Add a FileSystem namespace to FileSystem.cpp
2280         https://bugs.webkit.org/show_bug.cgi?id=179063
2281
2282         Reviewed by Darin Adler.
2283
2284         * Misc/WebNSFileManagerExtras.mm:
2285         * Storage/WebDatabaseProvider.mm:
2286
2287 2017-11-02  Frederic Wang  <fwang@igalia.com>
2288
2289         Add references to bug 179167 in FIXME comments
2290         https://bugs.webkit.org/show_bug.cgi?id=179168
2291
2292         Reviewed by Daniel Bates.
2293
2294         * Configurations/FeatureDefines.xcconfig:
2295
2296 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
2297
2298         Implement WKFullscreenWindowController for iOS.
2299         https://bugs.webkit.org/show_bug.cgi?id=178924
2300         rdar://problem/34697120
2301
2302         Reviewed by Simon Fraser.
2303
2304         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
2305
2306         * Configurations/FeatureDefines.xcconfig:
2307         * WebView/WebView.mm:
2308         (-[WebView fullScreenPlaceholderView]):
2309
2310 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2311
2312         Clean up some drag and drop feature flags
2313         https://bugs.webkit.org/show_bug.cgi?id=179082
2314
2315         Reviewed by Simon Fraser.
2316
2317         * Configurations/FeatureDefines.xcconfig:
2318
2319 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
2320
2321         Make it possible to test rubber-banding in overflow scroll
2322         https://bugs.webkit.org/show_bug.cgi?id=179078
2323
2324         Reviewed by Sam Weinig.
2325
2326         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
2327         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
2328
2329         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
2330         functions, since most callers want clamped.
2331
2332         * DOM/DOMHTML.mm:
2333         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
2334
2335 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2336
2337         Fix up some content filtering feature flags
2338         https://bugs.webkit.org/show_bug.cgi?id=179079
2339
2340         Reviewed by Simon Fraser.
2341
2342         * Configurations/FeatureDefines.xcconfig:
2343
2344 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2345
2346         [FrameView::layout cleanup] Move core layout logic to a separate class.
2347         https://bugs.webkit.org/show_bug.cgi?id=178771
2348         <rdar://problem/35166542>
2349
2350         Reviewed by Simon Fraser.
2351
2352         Move layout code out from FrameView to LayoutContext.
2353
2354         * WebView/WebClipView.mm:
2355         (-[WebClipView _immediateScrollToPoint:]):
2356         * WebView/WebFrame.mm:
2357         (-[WebFrame layoutCount]):
2358
2359 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
2360
2361         Fix issues with WebView subframe painting
2362         https://bugs.webkit.org/show_bug.cgi?id=178842
2363         rdar://problem/34072253
2364
2365         Reviewed by Daniel Bates.
2366         
2367         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
2368         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
2369         High Sierra, so match the new signature.
2370
2371         Also rename the 'rect' param to 'displayRect' to match AppKit code.
2372
2373         * WebView/WebHTMLView.mm:
2374         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2375         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2376
2377 2017-10-25  Youenn Fablet  <youenn@apple.com>
2378
2379         Enable ServiceWorker to fetch resources
2380         https://bugs.webkit.org/show_bug.cgi?id=178673
2381
2382         Reviewed by Brady Eidson.
2383
2384         * WebCoreSupport/WebFrameLoaderClient.mm:
2385         (WebFrameLoaderClient::pageID const):
2386         (WebFrameLoaderClient::frameID const):
2387         (WebFrameLoaderClient::sessionID const):
2388
2389         Added implementation to the new getters.
2390         They are noop in the context of WK1.
2391
2392 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2393
2394         Web Inspector: Enable WebKit logging configuration and display
2395         https://bugs.webkit.org/show_bug.cgi?id=177027
2396         <rdar://problem/33964767>
2397
2398         Reviewed by Joseph Pecoraro.
2399
2400         * WebCoreSupport/WebChromeClient.mm:
2401         (stringForMessageSource): Deal with Media and WebRTC message sources.
2402
2403 2017-10-20  Antoine Quint  <graouts@apple.com>
2404
2405         [Web Animations] Provide basic timeline and animation interfaces
2406         https://bugs.webkit.org/show_bug.cgi?id=178526
2407
2408         Reviewed by Dean Jackson.
2409
2410         Remove the WEB_ANIMATIONS compile-time flag.
2411
2412         * Configurations/FeatureDefines.xcconfig:
2413         * WebView/WebPreferences.mm:
2414         (+[WebPreferences initialize]):
2415         * WebView/WebView.mm:
2416         (-[WebView _preferencesChanged:]):
2417
2418 2017-10-19  Sam Weinig  <sam@webkit.org>
2419
2420         [Settings] Move global settings into their own file
2421         https://bugs.webkit.org/show_bug.cgi?id=178512
2422
2423         Reviewed by Darin Adler.
2424
2425         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2426
2427         * WebCoreSupport/WebChromeClient.mm:
2428         (WebChromeClient::supportsVideoFullscreen):
2429         * WebView/WebDynamicScrollBarsView.mm:
2430         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2431         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2432         * WebView/WebPreferences.mm:
2433         (+[WebPreferences initialize]):
2434         * WebView/WebView.mm:
2435         (-[WebView _commonInitializationWithFrameName:groupName:]):
2436         (-[WebView _preferencesChanged:]):
2437         (+[WebView _doNotStartObservingNetworkReachability]):
2438
2439 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2440
2441         Replace some stack raw pointers with RefPtrs within WebCore/html
2442         https://bugs.webkit.org/show_bug.cgi?id=178201
2443         <rdar://problem/34841692>
2444
2445         Reviewed by Ryosuke Niwa.
2446
2447         * DOM/DOM.mm:
2448         (kit):
2449         Change the type of node as toNode() is changed to return RefPtr.
2450
2451 2017-10-18  Chris Dumez  <cdumez@apple.com>
2452
2453         [Service Worker] Add stubs for Client / WindowClient / Clients
2454         https://bugs.webkit.org/show_bug.cgi?id=178469
2455
2456         Reviewed by Youenn Fablet.
2457
2458         Rename PageVisiblityState to VisibilityState.
2459
2460         * WebView/WebView.mm:
2461         (kit):
2462
2463 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2464
2465         Unreviewed, rolling out r223291.
2466
2467         See WebCore ChangeLog for more detail.
2468
2469         Reverted changeset:
2470
2471         "Remove Editor::simplifyMarkup"
2472         https://bugs.webkit.org/show_bug.cgi?id=178271
2473         https://trac.webkit.org/changeset/223291
2474
2475 2017-10-17  Keith Miller  <keith_miller@apple.com>
2476
2477         Change WebCore sources to work with unified source builds
2478         https://bugs.webkit.org/show_bug.cgi?id=178229
2479
2480         Rubber stamped by Tim Horton.
2481
2482         * Configurations/FeatureDefines.xcconfig:
2483
2484 2017-10-16  Sam Weinig  <sam@webkit.org>
2485
2486         [Settings] Remove all custom code from Settings.h/cpp
2487         https://bugs.webkit.org/show_bug.cgi?id=178330
2488
2489         Reviewed by Simon Fraser.
2490
2491         * WebView/WebPreferences.mm:
2492         (+[WebPreferences initialize]):
2493         
2494             Update for naming changes of FrameFlattening now that it is an enum class.
2495
2496 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2497
2498         Remove Editor::simplifyMarkup
2499         https://bugs.webkit.org/show_bug.cgi?id=178271
2500
2501         Reviewed by Wenson Hsieh.
2502
2503         * WebView/WebView.mm:
2504         (-[WebView _simplifyMarkup:endNode:]):
2505
2506 2017-10-12  Chris Dumez  <cdumez@apple.com>
2507
2508         [Mac] Add support for MouseEvent.buttons
2509         https://bugs.webkit.org/show_bug.cgi?id=178214
2510
2511         Reviewed by Ryosuke Niwa.
2512
2513         * WebView/WebPDFView.mm:
2514         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2515
2516 2017-10-11  Sam Weinig  <sam@webkit.org>
2517
2518         Remove out-parameter variants of copyToVector
2519         https://bugs.webkit.org/show_bug.cgi?id=178155
2520
2521         Reviewed by Tim Horton.
2522
2523         * Plugins/WebNetscapePluginView.mm:
2524         (-[WebNetscapePluginView destroyPlugin]):
2525         * WebView/WebHTMLRepresentation.mm:
2526         (newArrayWithStrings):
2527
2528             Replace out-parameter based copyToVector, with one that returns a Vector.
2529
2530 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2531
2532         Sanitize URL in pasteboard for other applications and cross origin content
2533         https://bugs.webkit.org/show_bug.cgi?id=178060
2534         <rdar://problem/34874518>
2535
2536         Reviewed by Wenson Hsieh.
2537
2538         * WebCoreSupport/WebPlatformStrategies.h:
2539         * WebCoreSupport/WebPlatformStrategies.mm:
2540         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2541
2542 2017-10-11  Chris Dumez  <cdumez@apple.com>
2543
2544         Modernize Geolocation code
2545         https://bugs.webkit.org/show_bug.cgi?id=178148
2546
2547         Reviewed by Ryosuke Niwa.
2548
2549         * WebCoreSupport/WebGeolocationClient.h:
2550         * WebCoreSupport/WebGeolocationClient.mm:
2551         (WebGeolocationClient::lastPosition):
2552         * WebView/WebGeolocationPosition.mm:
2553         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2554         (core):
2555         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2556         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2557         * WebView/WebGeolocationPositionInternal.h:
2558
2559 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2560
2561         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2562         https://bugs.webkit.org/show_bug.cgi?id=178154
2563
2564         Reviewed by Wenson Hsieh.
2565
2566         Enable custom pasteboard data by default.
2567
2568         * WebView/WebPreferenceKeysPrivate.h:
2569         * WebView/WebPreferences.mm:
2570         (+[WebPreferences initialize]):
2571         (-[WebPreferences customPasteboardDataEnabled]): Added.
2572         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2573         * WebView/WebPreferencesPrivate.h:
2574         * WebView/WebView.mm:
2575         (-[WebView _preferencesChanged:]):
2576
2577 2017-10-10  Sam Weinig  <sam@webkit.org>
2578
2579         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2580         https://bugs.webkit.org/show_bug.cgi?id=178102
2581
2582         Reviewed by Tim Horton.
2583
2584         * History/WebHistory.mm:
2585         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2586         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2587         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2588         * WebCoreSupport/WebUserMediaClient.mm:
2589         (WebUserMediaClient::pageDestroyed):
2590
2591 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2592
2593         Make the names of the options consistent
2594         https://bugs.webkit.org/show_bug.cgi?id=177933
2595
2596         Reviewed by Saam Barati.
2597
2598         * WebView/WebFrame.h:
2599         * WebView/WebHTMLView.mm:
2600         (-[WebHTMLView setMarkedText:selectedRange:]):
2601         * WebView/WebView.h:
2602
2603 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2604
2605         [iOS] Tweak support for classifying form controls (followup to r222487)
2606         https://bugs.webkit.org/show_bug.cgi?id=177917
2607         <rdar://problem/34820122>
2608
2609         Reviewed by Dean Jackson.
2610
2611         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2612
2613         * DOM/DOMHTMLInputElement.mm:
2614         (-[DOMHTMLInputElement _autofillContext]):
2615         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2616         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2617
2618 2017-10-05  Keith Miller  <keith_miller@apple.com>
2619
2620         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2621
2622         * Configurations/WebKitLegacy.xcconfig:
2623
2624 2017-10-05  Jer Noble  <jer.noble@apple.com>
2625
2626         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2627         https://bugs.webkit.org/show_bug.cgi?id=177261
2628
2629         Reviewed by Eric Carlson.
2630
2631         * Configurations/FeatureDefines.xcconfig:
2632
2633 2017-10-05  Chris Dumez  <cdumez@apple.com>
2634
2635         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2636         https://bugs.webkit.org/show_bug.cgi?id=177957
2637
2638         Reviewed by Alex Christensen.
2639
2640         * WebCoreSupport/WebPlatformStrategies.h:
2641         * WebCoreSupport/WebPlatformStrategies.mm:
2642         (WebPlatformStrategies::cookiesEnabled):
2643
2644 2017-10-05  Youenn Fablet  <youenn@apple.com>
2645
2646         Make LibWebRTCProvider port agnostic
2647         https://bugs.webkit.org/show_bug.cgi?id=177747
2648
2649         Reviewed by Alex Christensen & Alex Garcia.
2650
2651         * WebView/WebView.mm:
2652         (-[WebView _commonInitializationWithFrameName:groupName:]):
2653         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2654
2655 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2656
2657         Stop linking with WebKitSystemInterface
2658         https://bugs.webkit.org/show_bug.cgi?id=177915
2659
2660         Reviewed by Antti Koivisto.
2661
2662         * Configurations/DebugRelease.xcconfig:
2663         * Configurations/WebKitLegacy.xcconfig:
2664
2665 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2666
2667         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2668         https://bugs.webkit.org/show_bug.cgi?id=177912
2669
2670         Reviewed by Saam Barati.
2671
2672         * Carbon/CarbonUtils.m:
2673         * Carbon/CarbonWindowAdapter.mm:
2674         * Carbon/HIWebView.mm:
2675         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2676         * Misc/WebNSFileManagerExtras.mm:
2677         * Misc/WebNSPasteboardExtras.mm:
2678         * Misc/WebNSURLExtras.mm:
2679         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2680         * Plugins/Hosted/NetscapePluginHostManager.mm:
2681         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2682         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2683         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2684         * Plugins/Hosted/WebTextInputWindowController.m:
2685         * Plugins/WebBaseNetscapePluginView.mm:
2686         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2687         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2688         * Plugins/WebNetscapePluginStream.mm:
2689         * Plugins/WebNetscapePluginView.mm:
2690         * Plugins/WebPluginDatabase.mm:
2691         * WebCoreSupport/PopupMenuMac.mm:
2692         * WebCoreSupport/WebChromeClient.mm:
2693         * WebCoreSupport/WebFrameLoaderClient.mm:
2694         * WebCoreSupport/WebInspectorClient.mm:
2695         * WebCoreSupport/WebPlatformStrategies.mm:
2696         * WebCoreSupport/WebSystemInterface.mm:
2697         * WebView/WebDynamicScrollBarsView.mm:
2698         * WebView/WebFrame.mm:
2699         * WebView/WebFrameView.mm:
2700         * WebView/WebFullScreenController.mm:
2701         * WebView/WebHTMLView.mm:
2702         * WebView/WebPreferences.mm:
2703         * WebView/WebView.mm:
2704
2705 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2706
2707         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2708         rdar://problem/34705779
2709
2710         Addressing review comments that I somehow landed without.
2711
2712         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2713
2714 2017-09-29  Chris Dumez  <cdumez@apple.com>
2715
2716         Split some logic out of VisitedLinkStore and make it reusable
2717         https://bugs.webkit.org/show_bug.cgi?id=177575
2718
2719         Reviewed by Alex Christensen.
2720
2721         * WebCoreSupport/WebVisitedLinkStore.h:
2722         * WebCoreSupport/WebVisitedLinkStore.mm:
2723         (WebVisitedLinkStore::addVisitedLink):
2724         (WebVisitedLinkStore::removeVisitedLink):
2725         (WebVisitedLinkStore::isLinkVisited):
2726         (WebVisitedLinkStore::addVisitedLinkHash):
2727
2728 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2729
2730         Build fix for High Sierra 32 bit Mac
2731         https://bugs.webkit.org/show_bug.cgi?id=177551
2732         <rdar://problem/34690283>
2733
2734         Reviewed by Alexey Proskuryakov.
2735
2736         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2737         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2738         also made.
2739
2740         * Carbon/CarbonWindowAdapter.mm:
2741         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2742         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2743         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2744         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2745         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2746         (-[CarbonWindowAdapter dealloc]):
2747         (-[CarbonWindowAdapter windowRef]):
2748         (-[CarbonWindowAdapter _hasWindowRef]):
2749         (-[CarbonWindowAdapter _managesWindowRef]):
2750         (-[CarbonWindowAdapter _removeWindowRef]):
2751         (-[CarbonWindowAdapter _carbonWindowClass]):
2752         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2753         (-[CarbonWindowAdapter sendSuperEvent:]):
2754         (-[CarbonWindowAdapter relinquishFocus]):
2755         (-[CarbonWindowAdapter _cancelKey:]):
2756         (-[CarbonWindowAdapter _commonAwake]):
2757         (-[CarbonWindowAdapter _destroyRealWindow:]):
2758         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2759         (-[CarbonWindowAdapter _termWindowIfOwner]):
2760         (-[CarbonWindowAdapter _windowMovedToRect:]):
2761         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2762         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2763         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2764         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2765         (-[CarbonWindowAdapter canBecomeMainWindow]):
2766         (-[CarbonWindowAdapter encodeWithCoder:]):
2767         (-[CarbonWindowAdapter initWithCoder:]):
2768         (-[CarbonWindowAdapter setContentView:]):
2769         (-[CarbonWindowAdapter worksWhenModal]):
2770         (-[CarbonWindowAdapter _setModalWindowLevel]):
2771         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2772         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2773         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2774         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2775         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2776         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2777         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2778         (NSCarbonWindowHandleEvent):
2779         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2780         (-[CarbonWindowAdapter _growBoxRect]):
2781         * Carbon/HIWebView.mm:
2782         (HIWebViewGetWebView):
2783         (HIWebViewConstructor):
2784         (HIWebViewDestructor):
2785         (HIWebViewRegisterClass):
2786         (GetBehaviors):
2787         (Draw):
2788         (HitTest):
2789         (GetRegion):
2790         (GetWindowRef):
2791         (CreateNSEventAdoptingCGEvent):
2792         (CopyEventCGEvent):
2793         (CreateNSEventWithCarbonClickEvent):
2794         (Click):
2795         (CreateNSEventWithCarbonEvent):
2796         (MouseUp):
2797         (CreateNSEventWithCarbonMouseMoveEvent):
2798         (MouseMoved):
2799         (MouseDragged):
2800         (MouseWheelMoved):
2801         (ContextMenuClick):
2802         (GetKind):
2803         (BoundsChanged):
2804         (OwningWindowChanged):
2805         (WindowHandler):
2806         (SyncFrame):
2807         (SetFocusPart):
2808         (AdvanceFocus):
2809         (RelinquishFocus):
2810         (ActiveStateChanged):
2811         (ProcessCommand):
2812         (UpdateCommandStatus):
2813         (_NSSelectorForHICommand):
2814         (HIWebViewEventHandler):
2815         (StartUpdateObserver):
2816         (StopUpdateObserver):
2817         (UpdateObserver):
2818
2819 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2820
2821         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2822         https://bugs.webkit.org/show_bug.cgi?id=172526
2823         <rdar://problem/32396081>
2824
2825         Reviewed by Ryosuke Niwa.
2826
2827         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2828
2829         * WebCoreSupport/WebPlatformStrategies.h:
2830         * WebCoreSupport/WebPlatformStrategies.mm:
2831         (WebPlatformStrategies::webExposedTypes):
2832         (WebPlatformStrategies::writeCustomData):
2833
2834 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2835
2836         Unreviewed, rolling out r222567.
2837
2838         This broke and internal build.
2839
2840         Reverted changeset:
2841
2842         "Build fix for High Sierra 32 bit Mac"
2843         https://bugs.webkit.org/show_bug.cgi?id=177551
2844         http://trac.webkit.org/changeset/222567
2845
2846 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2847
2848         Build fix for High Sierra 32 bit Mac
2849         https://bugs.webkit.org/show_bug.cgi?id=177551
2850         <rdar://problem/34690283>
2851
2852         Reviewed by Alexey Proskuryakov.
2853
2854         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2855         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2856         also made.
2857
2858         * Carbon/CarbonWindowAdapter.mm:
2859         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2860         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2861         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2862         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2863         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2864         (-[CarbonWindowAdapter dealloc]):
2865         (-[CarbonWindowAdapter windowRef]):
2866         (-[CarbonWindowAdapter _hasWindowRef]):
2867         (-[CarbonWindowAdapter _managesWindowRef]):
2868         (-[CarbonWindowAdapter _removeWindowRef]):
2869         (-[CarbonWindowAdapter _carbonWindowClass]):
2870         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2871         (-[CarbonWindowAdapter sendSuperEvent:]):
2872         (-[CarbonWindowAdapter relinquishFocus]):
2873         (-[CarbonWindowAdapter _cancelKey:]):
2874         (-[CarbonWindowAdapter _commonAwake]):
2875         (-[CarbonWindowAdapter _destroyRealWindow:]):
2876         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2877         (-[CarbonWindowAdapter _termWindowIfOwner]):
2878         (-[CarbonWindowAdapter _windowMovedToRect:]):
2879         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2880         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2881         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2882         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2883         (-[CarbonWindowAdapter canBecomeMainWindow]):
2884         (-[CarbonWindowAdapter encodeWithCoder:]):
2885         (-[CarbonWindowAdapter initWithCoder:]):
2886         (-[CarbonWindowAdapter setContentView:]):
2887         (-[CarbonWindowAdapter worksWhenModal]):
2888         (-[CarbonWindowAdapter _setModalWindowLevel]):
2889         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2890         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2891         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2892         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2893         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2894         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2895         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2896         (NSCarbonWindowHandleEvent):
2897         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2898         (-[CarbonWindowAdapter _growBoxRect]):
2899         * Carbon/HIWebView.mm:
2900         (HIWebViewGetWebView):
2901         (HIWebViewConstructor):
2902         (HIWebViewDestructor):
2903         (HIWebViewRegisterClass):
2904         (GetBehaviors):
2905         (Draw):
2906         (HitTest):
2907         (GetRegion):
2908         (GetWindowRef):
2909         (CreateNSEventAdoptingCGEvent):
2910         (CopyEventCGEvent):
2911         (CreateNSEventWithCarbonClickEvent):
2912         (Click):
2913         (CreateNSEventWithCarbonEvent):
2914         (MouseUp):
2915         (CreateNSEventWithCarbonMouseMoveEvent):
2916         (MouseMoved):
2917         (MouseDragged):
2918         (MouseWheelMoved):
2919         (ContextMenuClick):
2920         (GetKind):
2921         (BoundsChanged):
2922         (OwningWindowChanged):
2923         (WindowHandler):
2924         (SyncFrame):
2925         (SetFocusPart):
2926         (AdvanceFocus):
2927         (RelinquishFocus):
2928         (ActiveStateChanged):
2929         (ProcessCommand):
2930         (UpdateCommandStatus):
2931         (_NSSelectorForHICommand):
2932         (HIWebViewEventHandler):
2933         (StartUpdateObserver):
2934         (StopUpdateObserver):
2935         (UpdateObserver):
2936
2937 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2938
2939         Make PolicyAction an encodable enum class
2940         https://bugs.webkit.org/show_bug.cgi?id=177480
2941
2942         Reviewed by Antti Koivisto.
2943
2944         * Plugins/WebPluginContainerCheck.mm:
2945         (-[WebPluginContainerCheck _continueWithPolicy:]):
2946         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2947         * WebCoreSupport/WebFrameLoaderClient.mm:
2948         (-[WebFramePolicyListener invalidate]):
2949         (-[WebFramePolicyListener ignore]):
2950         (-[WebFramePolicyListener download]):
2951         (-[WebFramePolicyListener use]):
2952         (-[WebFramePolicyListener continue]):
2953         * WebView/WebPolicyDelegate.mm:
2954         (-[WebPolicyDecisionListener use]):
2955         (-[WebPolicyDecisionListener ignore]):
2956         (-[WebPolicyDecisionListener download]):
2957
2958 2017-09-25  Frederik Riedel  <riedel@apple.com>
2959
2960         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2961         https://bugs.webkit.org/show_bug.cgi?id=174394
2962         <rdar://problem/33183504>
2963
2964         Reviewed by Ryosuke Niwa.
2965
2966         * DOM/DOMHTMLInputElement.h:
2967         * DOM/DOMHTMLInputElement.mm:
2968         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2969         Determines if this HTMLInputElement is part of a login screen.
2970         (-[DOMHTMLInputElement representingPageUrl]):
2971         Returns the webpage's URL that is currently displayed in the Web View.
2972         (-[DOMHTMLInputElement insertTextSuggestion:]):
2973         Inserts login credentials into the Web View.
2974
2975 2017-09-25  Sam Weinig  <sam@webkit.org>
2976
2977         Remove unused EditorClient functions
2978         https://bugs.webkit.org/show_bug.cgi?id=177463
2979
2980         Reviewed by Alex Christensen.
2981
2982         Remove unused EditorClient functions.
2983
2984         * WebCoreSupport/WebEditorClient.h:
2985         * WebCoreSupport/WebEditorClient.mm:
2986         (WebEditorClient::canonicalizeURL): Deleted.
2987         (WebEditorClient::canonicalizeURLString): Deleted.
2988         (WebEditorClient::writeDataToPasteboard): Deleted.
2989         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2990         (WebEditorClient::readDataFromPasteboard): Deleted.
2991         (WebEditorClient::pasteboardChangeCount): Deleted.
2992
2993 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2994
2995         Stop using PolicyCallback
2996         https://bugs.webkit.org/show_bug.cgi?id=176088
2997
2998         Reviewed by Andy Estes.
2999
3000         * WebCoreSupport/WebFrameLoaderClient.mm:
3001         (-[WebFramePolicyListener invalidate]):
3002         (-[WebFramePolicyListener receivedPolicyDecision:]):
3003
3004 2017-09-25  Sam Weinig  <sam@webkit.org>
3005
3006         Remove unnecessary userVisibleString EditorClient function
3007         https://bugs.webkit.org/show_bug.cgi?id=177456
3008
3009         Reviewed by Dan Bernstein.
3010
3011         * WebCoreSupport/WebEditorClient.h:
3012         * WebCoreSupport/WebEditorClient.mm:
3013         (WebEditorClient::userVisibleString): Deleted.
3014
3015             Remove userVisibleString client function.
3016
3017 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3018
3019         Separate form submission from PolicyChecker infrastructure
3020         https://bugs.webkit.org/show_bug.cgi?id=177396
3021
3022         Reviewed by Geoffrey Garen.
3023
3024         * WebCoreSupport/WebFrameLoaderClient.h:
3025         * WebCoreSupport/WebFrameLoaderClient.mm:
3026         (WebFrameLoaderClient::dispatchWillSubmitForm):
3027
3028 2017-09-22  Zalan Bujtas  <zalan@apple.com>
3029
3030         WeakPtrFactory should populate m_ref lazily.
3031         https://bugs.webkit.org/show_bug.cgi?id=177375
3032
3033         Reviewed by Geoffrey Garen.
3034
3035         * WebCoreSupport/WebEditorClient.mm:
3036         (WebEditorClient::WebEditorClient):
3037         (WebEditorClient::requestCandidatesForSelection):
3038
3039 2017-09-22  Chris Dumez  <cdumez@apple.com>
3040
3041         Use high resolution timestamp for event time
3042         https://bugs.webkit.org/show_bug.cgi?id=154246
3043         <rdar://problem/34333304>
3044
3045         Reviewed by Ryosuke Niwa.
3046
3047         Use WallTime / MonotonicTime instead of double type for clarity.
3048
3049         * DOM/DOMEvent.mm:
3050         (-[DOMEvent timeStamp]):
3051         * WebView/WebFrame.mm:
3052         (-[WebFrame _dragSourceEndedAt:operation:]):
3053         * WebView/WebPDFView.mm:
3054         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3055
3056 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
3057
3058         Enable dataTransfer.items on macOS and iOS
3059         https://bugs.webkit.org/show_bug.cgi?id=177335
3060
3061         Reviewed by Sam Weinig.
3062
3063         * WebView/WebPreferences.mm:
3064         (+[WebPreferences initialize]):
3065
3066 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
3067
3068         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
3069         https://bugs.webkit.org/show_bug.cgi?id=177101
3070         <rdar://problem/34500648>
3071
3072         Reviewed by Brian Burg.
3073
3074         * WebInspector/WebNodeHighlight.mm:
3075         Ensure we close the window that we have just removed.
3076
3077 2017-09-20  Antti Koivisto  <antti@apple.com>
3078
3079         Remove DOM and styling support for CSS Regions
3080         https://bugs.webkit.org/show_bug.cgi?id=177221
3081
3082         Reviewed by Andreas Kling.
3083
3084         * Configurations/FeatureDefines.xcconfig:
3085         * DOM/DOMCSS.mm:
3086         (kitClass):
3087         * DOM/DOMElement.mm:
3088         (-[DOMElement webkitRegionOverset]): Deleted.
3089
3090 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
3091
3092         Layering violation in Editor::createFragment
3093         https://bugs.webkit.org/show_bug.cgi?id=176123
3094
3095         Reviewed by Darin Adler.
3096
3097         * Misc/WebNSURLExtras.h:
3098         * Misc/WebNSURLExtras.mm:
3099         * WebView/WebFrame.mm:
3100         * WebView/WebHTMLView.mm:
3101         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
3102
3103         * WebCoreSupport/WebEditorClient.mm:
3104         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
3105         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
3106         way to avoid exporting the symbol just on newer OSes.
3107
3108 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
3109
3110         On iOS, getData can't get text set by setData during copy event
3111         https://bugs.webkit.org/show_bug.cgi?id=176980
3112         <rdar://problem/34453915>
3113
3114         Reviewed by Darin Adler.
3115
3116         * WebCoreSupport/WebPlatformStrategies.h:
3117         * WebCoreSupport/WebPlatformStrategies.mm:
3118         (WebPlatformStrategies::copy): Deleted.
3119
3120 2017-09-18  Andy Estes  <aestes@apple.com>
3121
3122         [Mac] Upstream miscellaneous WebKitSystemInterface functions
3123         https://bugs.webkit.org/show_bug.cgi?id=177029
3124
3125         Reviewed by Alex Christensen.
3126
3127         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3128         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
3129         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3130         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
3131         * WebCoreSupport/PopupMenuMac.mm:
3132         (PopupMenuMac::show):
3133         * WebCoreSupport/WebSystemInterface.mm:
3134         (InitWebCoreSystemInterface):
3135         * WebView/WebHTMLView.mm:
3136         (-[WebHTMLView setDataSource:]):
3137         (-[WebHTMLView attachRootLayer:]):
3138         * WebView/WebView.mm:
3139         (-[WebView _needsAdobeFrameReloadingQuirk]):
3140         (-[WebView _needsLinkElementTextCSSQuirk]):
3141         (-[WebView _needsIsLoadingInAPISenseQuirk]):
3142         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
3143         (-[WebView _preferencesChanged:]):
3144
3145 2017-09-15  Andy Estes  <aestes@apple.com>
3146
3147         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
3148         https://bugs.webkit.org/show_bug.cgi?id=176953
3149
3150         Reviewed by Eric Carlson.
3151
3152         * WebCoreSupport/WebSystemInterface.mm:
3153         (InitWebCoreSystemInterface):
3154
3155 2017-09-14  Andy Estes  <aestes@apple.com>
3156
3157         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
3158         https://bugs.webkit.org/show_bug.cgi?id=176931
3159
3160         Reviewed by Joseph Pecoraro.
3161
3162         * WebCoreSupport/WebSystemInterface.mm:
3163         (InitWebCoreSystemInterface):
3164
3165 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3166
3167         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
3168         https://bugs.webkit.org/show_bug.cgi?id=176867
3169
3170         Reviewed by Sam Weinig.
3171
3172         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3173         (WebKit::NetscapePluginInstanceProxy::enumerate):
3174
3175 2017-09-13  Andy Estes  <aestes@apple.com>
3176
3177         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
3178         https://bugs.webkit.org/show_bug.cgi?id=176729
3179
3180         Reviewed by Alex Christensen.
3181
3182         * WebCoreSupport/WebSystemInterface.mm:
3183         (InitWebCoreSystemInterface):
3184         * WebView/WebView.mm:
3185         (+[WebView _setCacheModel:]):
3186
3187 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3188
3189         Refactor WebContentReader out of EditorMac and EditorIOS
3190         https://bugs.webkit.org/show_bug.cgi?id=176770
3191
3192         Reviewed by Sam Weinig.
3193
3194         * WebCoreSupport/WebEditorClient.mm:
3195
3196 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3197
3198         Dragging & dropping a file creates an attachment element even when it's disabled
3199         https://bugs.webkit.org/show_bug.cgi?id=176769
3200
3201         Reviewed by Tim Horton.
3202
3203         * WebView/WebView.mm:
3204         (-[WebView _preferencesChanged:]):
3205
3206 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3207
3208         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
3209         https://bugs.webkit.org/show_bug.cgi?id=176721
3210         <rdar://problem/34373660>
3211
3212         Reviewed by Tim Horton.
3213
3214         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
3215         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
3216
3217         * WebView/WebView.mm:
3218         (-[WebView _startDrag:]):
3219         (-[WebView _draggedElementBounds]):
3220         (-[WebView _endedDataInteraction:global:]):
3221         * WebView/WebViewData.h:
3222
3223 2017-09-11  Andy Estes  <aestes@apple.com>
3224
3225         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3226         https://bugs.webkit.org/show_bug.cgi?id=176472
3227
3228         Reviewed by Eric Carlson.
3229
3230         * WebCoreSupport/WebSystemInterface.mm:
3231         (InitWebCoreSystemInterface):
3232
3233 2017-09-09  Mark Lam  <mark.lam@apple.com>
3234
3235         Avoid duplicate computations of ExecState::vm().
3236         https://bugs.webkit.org/show_bug.cgi?id=176647
3237
3238         Reviewed by Saam Barati.
3239
3240         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3241         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3242         (WebKit::NetscapePluginInstanceProxy::construct):
3243         (WebKit::NetscapePluginInstanceProxy::setProperty):
3244         (WebKit::NetscapePluginInstanceProxy::removeProperty):
3245         (WebKit::NetscapePluginInstanceProxy::enumerate):
3246         * Plugins/Hosted/ProxyInstance.mm:
3247         (WebKit::ProxyRuntimeMethod::create):
3248
3249 2017-09-08  Commit Queue  <commit-queue@webkit.org>
3250
3251         Unreviewed, rolling out r221773.
3252         https://bugs.webkit.org/show_bug.cgi?id=176614
3253
3254         This caused build failures. (Requested by mlewis13 on
3255         #webkit).
3256
3257         Reverted changeset:
3258
3259         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
3260         https://bugs.webkit.org/show_bug.cgi?id=176472
3261         http://trac.webkit.org/changeset/221773
3262
3263 2017-09-07  Andy Estes  <aestes@apple.com>
3264
3265         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3266         https://bugs.webkit.org/show_bug.cgi?id=176472
3267
3268         Reviewed by Eric Carlson.
3269
3270         * WebCoreSupport/WebSystemInterface.mm:
3271         (InitWebCoreSystemInterface):
3272
3273 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
3274
3275         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
3276         https://bugs.webkit.org/show_bug.cgi?id=176561
3277
3278         Reviewed by Brent Fulgham.
3279
3280         * Misc/WebNSUserDefaultsExtras.mm:
3281
3282 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3283
3284         Modernize Geolocation code
3285         https://bugs.webkit.org/show_bug.cgi?id=176496
3286
3287         Reviewed by Andy Estes.
3288
3289         * WebCoreSupport/WebGeolocationClient.h:
3290         * WebCoreSupport/WebGeolocationClient.mm:
3291         (WebGeolocationClient::requestPermission):
3292         (-[WebGeolocationPolicyListener initWithGeolocation:]):
3293         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
3294         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
3295         * WebView/WebView.mm:
3296         (-[WebView _commonInitializationWithFrameName:groupName:]):
3297         (-[WebView _geolocationDidFailWithMessage:]):
3298
3299 2017-09-05  Tim Horton  <timothy_horton@apple.com>
3300
3301         Remove some unused bits of code and resources
3302         https://bugs.webkit.org/show_bug.cgi?id=176275
3303
3304         Reviewed by Dan Bernstein.
3305
3306         * Misc/WebNSFileManagerExtras.mm:
3307         Include FileSystem instead of FileSystemIOS.
3308
3309 2017-09-03  Darin Adler  <darin@apple.com>
3310
3311         [Cocoa] Tidy a few things in legacy WebHTMLView
3312         https://bugs.webkit.org/show_bug.cgi?id=176280
3313
3314         Reviewed by Dan Bernstein.
3315
3316         * WebCoreSupport/WebChromeClient.mm:
3317         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
3318         methods it calls on WebHTMLView were doing nothing on iOS.
3319
3320         * WebView/WebFrame.mm:
3321         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
3322         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
3323
3324         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
3325         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
3326         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
3327         order. Removed all sorts of unused things. Made more code and fields Mac-only where
3328         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
3329         Use RetainPtr instead of writing retain/release wherever possible.
3330         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
3331         initialization for it. Removed various unused methods and declarations of methods.
3332         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
3333         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
3334         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
3335         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
3336         and remove CFRetain no longer needed since we don't support garbage collection any more.
3337         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
3338         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
3339         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3340         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3341         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
3342         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3343         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
3344         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3345         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
3346         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
3347         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
3348         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
3349         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
3350         debug flag; we haven't used it for years and it's not clearly helpful.
3351         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
3352         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
3353         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
3354         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
3355         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
3356         two additional methods in the WebPrivate category and still be called by the two
3357         methods in the WebInternal category that were already using it.
3358         (-[WebHTMLView didAddSubview:]): Deleted.
3359         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
3360         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
3361         place this was called, the close method.
3362         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
3363         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3364         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
3365         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
3366         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
3367         Added helper method to make the one below simpler.
3368         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3369         Compared pasteboard type strings using isEqualToString: rather than using == since
3370         we want to actually compare the string contents. Also updated to use modern for loop,
3371         renamed a local variable from "s" to "localSubresources", and factored out the handling
3372         of three image types to use the helper method above.
3373         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
3374         _web_makePluginSubviewsPerformSelector:withObject: method.
3375         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
3376         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
3377         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
3378         not call the -[NSView subviews] method to make this identical on both platforms and used
3379         a modern for loop.
3380         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
3381         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
3382         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
3383         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
3384         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3385         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
3386         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
3387         of it is Mac-only.
3388         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
3389         method did was call itself on the main thread, and do nothing if called on main thread.
3390         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
3391         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
3392         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
3393         half of this method.
3394         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
3395         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
3396         Simplified using a modern for loop and RetainPtr.
3397         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
3398         (-[WebHTMLView keyDown:]): Ditto.
3399         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
3400         (-[WebHTMLView performKeyEquivalent:]): Ditto.
3401         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
3402         (-[WebHTMLView complete:]): Ditto.
3403         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
3404         now macOS-only.
3405         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
3406         iOS since that is now macOS-only.
3407         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
3408         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
3409         a private one because it is not used or needed outside WebKit. Also made it macOS-only
3410         and reorganized to use early return.
3411         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
3412         on iOS, but kept there so we don't have to do #if at every call site.
3413         (-[WebHTMLView _pluginController]): Moved into internal category.
3414         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
3415         there only for GC, using C++ initialization, removing obsolete comment.
3416         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
3417         peculiar iOS-only comment.
3418         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
3419
3420         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
3421         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
3422         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
3423         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
3424         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
3425
3426         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
3427         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
3428         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
3429         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
3430         them at this time.
3431
3432 2017-09-03  Sam Weinig  <sam@webkit.org>
3433
3434         Remove CanvasProxy
3435         https://bugs.webkit.org/show_bug.cgi?id=176288
3436
3437         Reviewed by Yusuke Suzuki.
3438
3439         CanvasProxy does not appear to be in any current HTML spec
3440         and was disabled and unimplemented in our tree. Time to 
3441         get rid of it.
3442
3443         * Configurations/FeatureDefines.xcconfig:
3444
3445 2017-09-02  Andy Estes  <aestes@apple.com>
3446
3447         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
3448         https://bugs.webkit.org/show_bug.cgi?id=176270
3449
3450         Reviewed by Tim Horton.
3451
3452         * Plugins/Hosted/NetscapePluginHostManager.mm:
3453         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3454         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3455         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3456         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
3457         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
3458         (WebKit::SoftwareCARenderer::context const):
3459         (WebKit::SoftwareCARenderer::renderContext const):
3460         (WebKit::SoftwareCARenderer::render):
3461         (-[WebHostedNetscapePluginView createPlugin]):
3462         (-[WebHostedNetscapePluginView createPluginLayer]):
3463         (-[WebHostedNetscapePluginView destroyPlugin]):
3464         (-[WebHostedNetscapePluginView drawRect:]):
3465         * WebCoreSupport/WebSystemInterface.mm:
3466         (InitWebCoreSystemInterface):
3467
3468 2017-09-01  Andy Estes  <aestes@apple.com>
3469
3470         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
3471         https://bugs.webkit.org/show_bug.cgi?id=176200
3472
3473         Reviewed by Tim Horton.
3474
3475         * Carbon/HIWebView.mm:
3476         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
3477         (overrideCGContext):
3478         (restoreCGContext):
3479         (Draw):
3480         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3481         (+[WebHostedNetscapePluginView initialize]):
3482         * Plugins/WebBaseNetscapePluginView.h:
3483         * Plugins/WebBaseNetscapePluginView.mm:
3484         (WebKit::sendUserChangeNotifications):
3485         * Plugins/WebNetscapePluginView.mm:
3486         (+[WebNetscapePluginView initialize]):
3487         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3488         * WebCoreSupport/WebSystemInterface.mm:
3489         (InitWebCoreSystemInterface):
3490         * WebView/WebFrame.mm: