Make LegacyCustomProtocolManager optional for network process
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
2
3         Make LegacyCustomProtocolManager optional for network process
4         https://bugs.webkit.org/show_bug.cgi?id=176230
5
6         Reviewed by Alex Christensen.
7
8         * Configurations/FeatureDefines.xcconfig:
9
10 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
11
12         Fix some NSOperationQueue leaks
13         https://bugs.webkit.org/show_bug.cgi?id=180221
14
15         Reviewed by Wenson Hsieh.
16
17         * WebView/WebView.mm:
18         (-[WebView performDragOperation:]):
19
20 2017-11-30  Darin Adler  <darin@apple.com>
21
22         [Mac] remove unneeded RetainPtr use introduced in r225142
23         https://bugs.webkit.org/show_bug.cgi?id=180202
24
25         Reviewed by Tim Horton.
26
27         * WebView/WebImmediateActionController.mm:
28         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
29         RetainPtr.
30
31 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
32
33         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
34         https://bugs.webkit.org/show_bug.cgi?id=175595
35
36         Reviewed by Darin Adler.
37
38         * WebView/WebPreferences.mm:
39
40 2017-11-27  Tim Horton  <timothy_horton@apple.com>
41
42         One too many zeroes in macOS version number in FeatureDefines
43         https://bugs.webkit.org/show_bug.cgi?id=180011
44
45         Reviewed by Dan Bernstein.
46
47         * Configurations/FeatureDefines.xcconfig:
48
49 2017-11-23  Darin Adler  <darin@apple.com>
50
51         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
52         https://bugs.webkit.org/show_bug.cgi?id=179981
53
54         Reviewed by Sam Weinig.
55
56         * WebView/WebImmediateActionController.mm:
57         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
58         * WebView/WebView.mm:
59         (coreOptions): Use |= instead of | to build up FindOptions.
60
61 2017-11-23  Sam Weinig  <sam@webkit.org>
62
63         Remove unneeded ScriptController::processingUserGesture() forwarding functions
64         https://bugs.webkit.org/show_bug.cgi?id=179954
65
66         Reviewed by Darin Adler.
67
68         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
69         with direct calls to the corresponding UserGestureIndicator functions.
70
71         * Plugins/WebPluginController.mm:
72         (-[WebPluginController processingUserGesture]):
73         * WebView/WebView.mm:
74         (-[WebView _isProcessingUserGesture]):
75
76 2017-11-23  Darin Adler  <darin@apple.com>
77
78         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
79         https://bugs.webkit.org/show_bug.cgi?id=179907
80
81         Reviewed by Sam Weinig.
82
83         * History/BinaryPropertyList.cpp:
84         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
85         (BinaryPropertyListSerializer::appendStringObject): Ditto.
86         * WebView/WebHTMLRepresentation.mm:
87         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
88         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
89
90 2017-11-22  Ali Juma  <ajuma@chromium.org>
91
92         Implement VisualViewport API attributes
93         https://bugs.webkit.org/show_bug.cgi?id=179385
94
95         Reviewed by Frédéric Wang.
96
97         Add a VisualViewportAPI preference.
98
99         * WebView/WebPreferenceKeysPrivate.h:
100         * WebView/WebPreferences.mm:
101         (+[WebPreferences initialize]):
102         (-[WebPreferences visualViewportAPIEnabled]):
103         (-[WebPreferences setVisualViewportAPIEnabled:]):
104         * WebView/WebPreferencesPrivate.h:
105         * WebView/WebView.mm:
106         (-[WebView _preferencesChanged:]):
107
108 2017-11-22  Christopher Reid  <chris.reid@sony.com>
109
110         WebCoreObjCExtras.h is being included in too many places
111         https://bugs.webkit.org/show_bug.cgi?id=179931
112
113         Reviewed by Darin Adler.
114
115         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
116         * Plugins/WebBaseNetscapePluginView.mm:
117         * Plugins/WebBasePluginPackage.mm:
118         * Plugins/WebNetscapePluginStream.mm:
119         * Plugins/WebNetscapePluginView.mm:
120         * WebView/WebTextIterator.mm:
121         * WebView/WebViewData.mm:
122
123 2017-11-22  Commit Queue  <commit-queue@webkit.org>
124
125         Unreviewed, rolling out r225093.
126         https://bugs.webkit.org/show_bug.cgi?id=179938
127
128         Compilation failed on WinCairo 64-bit Release (Requested by
129         fredw on #webkit).
130
131         Reverted changeset:
132
133         "Implement VisualViewport API attributes"
134         https://bugs.webkit.org/show_bug.cgi?id=179385
135         https://trac.webkit.org/changeset/225093
136
137 2017-11-21  Ali Juma  <ajuma@chromium.org>
138
139         Implement VisualViewport API attributes
140         https://bugs.webkit.org/show_bug.cgi?id=179385
141
142         Reviewed by Frédéric Wang.
143
144         Add a VisualViewportAPI preference.
145
146         * WebView/WebPreferenceKeysPrivate.h:
147         * WebView/WebPreferences.mm:
148         (+[WebPreferences initialize]):
149         (-[WebPreferences visualViewportAPIEnabled]):
150         (-[WebPreferences setVisualViewportAPIEnabled:]):
151         * WebView/WebPreferencesPrivate.h:
152         * WebView/WebView.mm:
153         (-[WebView _preferencesChanged:]):
154
155 2017-11-21  Christopher Reid  <chris.reid@sony.com>
156
157         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
158         https://bugs.webkit.org/show_bug.cgi?id=179504
159
160         Reviewed by Darin Adler.
161
162         * Misc/WebKitNSStringExtras.mm:
163         * Plugins/Hosted/NetscapePluginHostManager.mm:
164         * Plugins/WebBasePluginPackage.mm:
165
166 2017-11-19  Tim Horton  <timothy_horton@apple.com>
167
168         Remove unused TOUCH_ICON_LOADING feature flag
169         https://bugs.webkit.org/show_bug.cgi?id=179873
170
171         Reviewed by Simon Fraser.
172
173         * Configurations/FeatureDefines.xcconfig:
174
175 2017-11-19  Tim Horton  <timothy_horton@apple.com>
176
177         Remove unused LEGACY_VENDOR_PREFIXES feature flag
178         https://bugs.webkit.org/show_bug.cgi?id=179872
179
180         Reviewed by Darin Adler.
181
182         * Configurations/FeatureDefines.xcconfig:
183
184 2017-11-16  Daniel Bates  <dabates@apple.com>
185
186         Add feature define for alternative presentation button element
187         https://bugs.webkit.org/show_bug.cgi?id=179692
188         Part of <rdar://problem/34917108>
189
190         Reviewed by Andy Estes.
191
192         Only enabled on Cocoa platforms by default.
193
194         * Configurations/FeatureDefines.xcconfig:
195
196 2017-11-14  Nan Wang  <n_wang@apple.com>
197
198         AX: AOM: Implement AccessibleNode class and support label and role attributes
199         https://bugs.webkit.org/show_bug.cgi?id=179494
200
201         Reviewed by Ryosuke Niwa.
202
203         * WebView/WebPreferenceKeysPrivate.h:
204         * WebView/WebPreferences.mm:
205         (+[WebPreferences initialize]):
206         (-[WebPreferences accessibilityObjectModelEnabled]):
207         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
208         * WebView/WebPreferencesPrivate.h:
209         * WebView/WebView.mm:
210         (-[WebView _preferencesChanged:]):
211
212 2017-11-14  Alex Christensen  <achristensen@webkit.org>
213
214         Remove Cocoa CFURLConnection loading code
215         https://bugs.webkit.org/show_bug.cgi?id=179688
216
217         Reviewed by Antti Koivisto.
218
219         * Misc/WebDownload.mm:
220         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
221         * Misc/WebDownloadInternal.h:
222         * Plugins/WebBaseNetscapePluginView.mm:
223         * WebCoreSupport/WebFrameLoaderClient.mm:
224         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
225         * WebView/WebView.mm:
226         (-[WebView scheduleInRunLoop:forMode:]):
227         (-[WebView unscheduleFromRunLoop:forMode:]):
228
229 2017-11-14  Daniel Bates  <dabates@apple.com>
230
231         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
232         for feature defines
233
234         Following r195498 and r201917 the Visual Studio property files for feature defines have
235         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
236         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
237         files.
238
239         * Configurations/FeatureDefines.xcconfig:
240
241 2017-11-14  Jer Noble  <jer.noble@apple.com>
242
243         Enable Modern EME tests in DumpRenderTree
244         https://bugs.webkit.org/show_bug.cgi?id=179544
245
246         Reviewed by Alex Christensen.
247
248         Add a WebPreferences property to enable the (modern) EME API.
249
250         * WebView/WebPreferenceKeysPrivate.h:
251         * WebView/WebPreferences.mm:
252         (+[WebPreferences initialize]):
253         (-[WebPreferences encryptedMediaAPIEnabled]):
254         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
255         * WebView/WebPreferencesPrivate.h:
256         * WebView/WebView.mm:
257         (-[WebView _preferencesChanged:]):
258
259 2017-11-14  Antti Koivisto  <antti@apple.com>
260
261         Enable display:contents by default
262         https://bugs.webkit.org/show_bug.cgi?id=179655
263
264         Reviewed by Sam Weinig.
265
266         * WebView/WebPreferences.mm:
267         (+[WebPreferences initialize]):
268
269 2017-11-13  Alex Christensen  <achristensen@webkit.org>
270
271         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
272         https://bugs.webkit.org/show_bug.cgi?id=178751
273
274         Reviewed by Brady Eidson.
275
276         * WebCoreSupport/WebFrameNetworkingContext.mm:
277         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
278
279 2017-11-08  Keith Miller  <keith_miller@apple.com>
280
281         Async iteration should only fetch the next method once and add feature flag
282         https://bugs.webkit.org/show_bug.cgi?id=179451
283
284         Reviewed by Geoffrey Garen.
285
286         Add feature flag for Async iteration.
287
288         * Configurations/FeatureDefines.xcconfig:
289
290 2017-11-13  Mark Lam  <mark.lam@apple.com>
291
292         Add more overflow check book-keeping for MarkedArgumentBuffer.
293         https://bugs.webkit.org/show_bug.cgi?id=179634
294         <rdar://problem/35492517>
295
296         Reviewed by Saam Barati.
297
298         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
299         (WebKit::NetscapePluginInstanceProxy::invoke):
300         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
301         (WebKit::NetscapePluginInstanceProxy::construct):
302
303 2017-11-12  Darin Adler  <darin@apple.com>
304
305         More is<> and downcast<>, less static_cast<>
306         https://bugs.webkit.org/show_bug.cgi?id=179600
307
308         Reviewed by Chris Dumez.
309
310         * DOM/DOM.mm:
311         (kit): Use is/downcast.
312         * WebCoreSupport/WebEditorClient.mm:
313         (WebEditorClient::handleKeyboardEvent): Ditto.
314         (WebEditorClient::handleInputMethodKeydown): Ditto.
315         * WebView/WebHTMLView.mm:
316         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
317
318 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
319
320         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
321         https://bugs.webkit.org/show_bug.cgi?id=179397
322
323         Reviewed by Wenson Hsieh.
324
325         * DOM/DOMHTMLInputElement.mm:
326         (-[DOMHTMLInputElement insertTextSuggestion:]):
327
328 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
329
330         HTMLMediaElement should not use element fullscreen on iOS
331         https://bugs.webkit.org/show_bug.cgi?id=179418
332         rdar://problem/35409277
333
334         Reviewed by Eric Carlson.
335
336         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
337
338         * Configurations/FeatureDefines.xcconfig:
339
340 2017-11-06  Alex Christensen  <achristensen@webkit.org>
341
342         Make ResourceLoader::willSendRequestInternal asynchronous
343         https://bugs.webkit.org/show_bug.cgi?id=179251
344
345         Reviewed by Andy Estes.
346
347         * Plugins/Hosted/HostedNetscapePluginStream.mm:
348         (WebKit::HostedNetscapePluginStream::start):
349         * Plugins/WebNetscapePluginStream.mm:
350         (WebNetscapePluginStream::start):
351
352 2017-11-01  Darin Adler  <darin@apple.com>
353
354         Simplify event dispatch code and make it a bit more consistent
355         https://bugs.webkit.org/show_bug.cgi?id=178991
356
357         Reviewed by Chris Dumez.
358
359         * DOM/DOMEvent.mm:
360         (-[DOMEvent srcElement]): Call target instead of srcElement.
361
362 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
363
364         [Touch Bar Web API] Add support for menuitem tag
365         https://bugs.webkit.org/show_bug.cgi?id=179020
366
367         Reviewed by Ryosuke Niwa.
368
369         Adds in properties and methods that allow the menuitem runtime feature
370         to be enabled or disabled.
371
372         * WebView/WebPreferenceKeysPrivate.h:
373         * WebView/WebPreferences.mm:
374         (-[WebPreferences menuItemElementEnabled]):
375         (-[WebPreferences setMenuItemElementEnabled:]):
376         * WebView/WebPreferencesPrivate.h:
377         * WebView/WebView.mm:
378         (-[WebView _preferencesChanged:]):
379
380 2017-11-02  Alex Christensen  <achristensen@webkit.org>
381
382         Use CompletionHandlers for redirects
383         https://bugs.webkit.org/show_bug.cgi?id=179163
384
385         Reviewed by Tim Horton.
386
387         * Plugins/Hosted/HostedNetscapePluginStream.h:
388         * Plugins/Hosted/HostedNetscapePluginStream.mm:
389         (WebKit::HostedNetscapePluginStream::willSendRequest):
390         * Plugins/WebNetscapePluginStream.h:
391         * Plugins/WebNetscapePluginStream.mm:
392         (WebNetscapePluginStream::willSendRequest):
393
394 2017-11-02  Christopher Reid  <chris.reid@sony.com>
395
396         Add a FileSystem namespace to FileSystem.cpp
397         https://bugs.webkit.org/show_bug.cgi?id=179063
398
399         Reviewed by Darin Adler.
400
401         * Misc/WebNSFileManagerExtras.mm:
402         * Storage/WebDatabaseProvider.mm:
403
404 2017-11-02  Frederic Wang  <fwang@igalia.com>
405
406         Add references to bug 179167 in FIXME comments
407         https://bugs.webkit.org/show_bug.cgi?id=179168
408
409         Reviewed by Daniel Bates.
410
411         * Configurations/FeatureDefines.xcconfig:
412
413 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
414
415         Implement WKFullscreenWindowController for iOS.
416         https://bugs.webkit.org/show_bug.cgi?id=178924
417         rdar://problem/34697120
418
419         Reviewed by Simon Fraser.
420
421         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
422
423         * Configurations/FeatureDefines.xcconfig:
424         * WebView/WebView.mm:
425         (-[WebView fullScreenPlaceholderView]):
426
427 2017-10-31  Tim Horton  <timothy_horton@apple.com>
428
429         Clean up some drag and drop feature flags
430         https://bugs.webkit.org/show_bug.cgi?id=179082
431
432         Reviewed by Simon Fraser.
433
434         * Configurations/FeatureDefines.xcconfig:
435
436 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
437
438         Make it possible to test rubber-banding in overflow scroll
439         https://bugs.webkit.org/show_bug.cgi?id=179078
440
441         Reviewed by Sam Weinig.
442
443         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
444         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
445
446         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
447         functions, since most callers want clamped.
448
449         * DOM/DOMHTML.mm:
450         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
451
452 2017-10-31  Tim Horton  <timothy_horton@apple.com>
453
454         Fix up some content filtering feature flags
455         https://bugs.webkit.org/show_bug.cgi?id=179079
456
457         Reviewed by Simon Fraser.
458
459         * Configurations/FeatureDefines.xcconfig:
460
461 2017-10-28  Zalan Bujtas  <zalan@apple.com>
462
463         [FrameView::layout cleanup] Move core layout logic to a separate class.
464         https://bugs.webkit.org/show_bug.cgi?id=178771
465         <rdar://problem/35166542>
466
467         Reviewed by Simon Fraser.
468
469         Move layout code out from FrameView to LayoutContext.
470
471         * WebView/WebClipView.mm:
472         (-[WebClipView _immediateScrollToPoint:]):
473         * WebView/WebFrame.mm:
474         (-[WebFrame layoutCount]):
475
476 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
477
478         Fix issues with WebView subframe painting
479         https://bugs.webkit.org/show_bug.cgi?id=178842
480         rdar://problem/34072253
481
482         Reviewed by Daniel Bates.
483         
484         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
485         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
486         High Sierra, so match the new signature.
487
488         Also rename the 'rect' param to 'displayRect' to match AppKit code.
489
490         * WebView/WebHTMLView.mm:
491         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
492         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
493
494 2017-10-25  Youenn Fablet  <youenn@apple.com>
495
496         Enable ServiceWorker to fetch resources
497         https://bugs.webkit.org/show_bug.cgi?id=178673
498
499         Reviewed by Brady Eidson.
500
501         * WebCoreSupport/WebFrameLoaderClient.mm:
502         (WebFrameLoaderClient::pageID const):
503         (WebFrameLoaderClient::frameID const):
504         (WebFrameLoaderClient::sessionID const):
505
506         Added implementation to the new getters.
507         They are noop in the context of WK1.
508
509 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
510
511         Web Inspector: Enable WebKit logging configuration and display
512         https://bugs.webkit.org/show_bug.cgi?id=177027
513         <rdar://problem/33964767>
514
515         Reviewed by Joseph Pecoraro.
516
517         * WebCoreSupport/WebChromeClient.mm:
518         (stringForMessageSource): Deal with Media and WebRTC message sources.
519
520 2017-10-20  Antoine Quint  <graouts@apple.com>
521
522         [Web Animations] Provide basic timeline and animation interfaces
523         https://bugs.webkit.org/show_bug.cgi?id=178526
524
525         Reviewed by Dean Jackson.
526
527         Remove the WEB_ANIMATIONS compile-time flag.
528
529         * Configurations/FeatureDefines.xcconfig:
530         * WebView/WebPreferences.mm:
531         (+[WebPreferences initialize]):
532         * WebView/WebView.mm:
533         (-[WebView _preferencesChanged:]):
534
535 2017-10-19  Sam Weinig  <sam@webkit.org>
536
537         [Settings] Move global settings into their own file
538         https://bugs.webkit.org/show_bug.cgi?id=178512
539
540         Reviewed by Darin Adler.
541
542         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
543
544         * WebCoreSupport/WebChromeClient.mm:
545         (WebChromeClient::supportsVideoFullscreen):
546         * WebView/WebDynamicScrollBarsView.mm:
547         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
548         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
549         * WebView/WebPreferences.mm:
550         (+[WebPreferences initialize]):
551         * WebView/WebView.mm:
552         (-[WebView _commonInitializationWithFrameName:groupName:]):
553         (-[WebView _preferencesChanged:]):
554         (+[WebView _doNotStartObservingNetworkReachability]):
555
556 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
557
558         Replace some stack raw pointers with RefPtrs within WebCore/html
559         https://bugs.webkit.org/show_bug.cgi?id=178201
560         <rdar://problem/34841692>
561
562         Reviewed by Ryosuke Niwa.
563
564         * DOM/DOM.mm:
565         (kit):
566         Change the type of node as toNode() is changed to return RefPtr.
567
568 2017-10-18  Chris Dumez  <cdumez@apple.com>
569
570         [Service Worker] Add stubs for Client / WindowClient / Clients
571         https://bugs.webkit.org/show_bug.cgi?id=178469
572
573         Reviewed by Youenn Fablet.
574
575         Rename PageVisiblityState to VisibilityState.
576
577         * WebView/WebView.mm:
578         (kit):
579
580 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
581
582         Unreviewed, rolling out r223291.
583
584         See WebCore ChangeLog for more detail.
585
586         Reverted changeset:
587
588         "Remove Editor::simplifyMarkup"
589         https://bugs.webkit.org/show_bug.cgi?id=178271
590         https://trac.webkit.org/changeset/223291
591
592 2017-10-17  Keith Miller  <keith_miller@apple.com>
593
594         Change WebCore sources to work with unified source builds
595         https://bugs.webkit.org/show_bug.cgi?id=178229
596
597         Rubber stamped by Tim Horton.
598
599         * Configurations/FeatureDefines.xcconfig:
600
601 2017-10-16  Sam Weinig  <sam@webkit.org>
602
603         [Settings] Remove all custom code from Settings.h/cpp
604         https://bugs.webkit.org/show_bug.cgi?id=178330
605
606         Reviewed by Simon Fraser.
607
608         * WebView/WebPreferences.mm:
609         (+[WebPreferences initialize]):
610         
611             Update for naming changes of FrameFlattening now that it is an enum class.
612
613 2017-10-13  Alex Christensen  <achristensen@webkit.org>
614
615         Remove Editor::simplifyMarkup
616         https://bugs.webkit.org/show_bug.cgi?id=178271
617
618         Reviewed by Wenson Hsieh.
619
620         * WebView/WebView.mm:
621         (-[WebView _simplifyMarkup:endNode:]):
622
623 2017-10-12  Chris Dumez  <cdumez@apple.com>
624
625         [Mac] Add support for MouseEvent.buttons
626         https://bugs.webkit.org/show_bug.cgi?id=178214
627
628         Reviewed by Ryosuke Niwa.
629
630         * WebView/WebPDFView.mm:
631         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
632
633 2017-10-11  Sam Weinig  <sam@webkit.org>
634
635         Remove out-parameter variants of copyToVector
636         https://bugs.webkit.org/show_bug.cgi?id=178155
637
638         Reviewed by Tim Horton.
639
640         * Plugins/WebNetscapePluginView.mm:
641         (-[WebNetscapePluginView destroyPlugin]):
642         * WebView/WebHTMLRepresentation.mm:
643         (newArrayWithStrings):
644
645             Replace out-parameter based copyToVector, with one that returns a Vector.
646
647 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
648
649         Sanitize URL in pasteboard for other applications and cross origin content
650         https://bugs.webkit.org/show_bug.cgi?id=178060
651         <rdar://problem/34874518>
652
653         Reviewed by Wenson Hsieh.
654
655         * WebCoreSupport/WebPlatformStrategies.h:
656         * WebCoreSupport/WebPlatformStrategies.mm:
657         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
658
659 2017-10-11  Chris Dumez  <cdumez@apple.com>
660
661         Modernize Geolocation code
662         https://bugs.webkit.org/show_bug.cgi?id=178148
663
664         Reviewed by Ryosuke Niwa.
665
666         * WebCoreSupport/WebGeolocationClient.h:
667         * WebCoreSupport/WebGeolocationClient.mm:
668         (WebGeolocationClient::lastPosition):
669         * WebView/WebGeolocationPosition.mm:
670         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
671         (core):
672         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
673         (-[WebGeolocationPosition initWithGeolocationPosition:]):
674         * WebView/WebGeolocationPositionInternal.h:
675
676 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
677
678         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
679         https://bugs.webkit.org/show_bug.cgi?id=178154
680
681         Reviewed by Wenson Hsieh.
682
683         Enable custom pasteboard data by default.
684
685         * WebView/WebPreferenceKeysPrivate.h:
686         * WebView/WebPreferences.mm:
687         (+[WebPreferences initialize]):
688         (-[WebPreferences customPasteboardDataEnabled]): Added.
689         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
690         * WebView/WebPreferencesPrivate.h:
691         * WebView/WebView.mm:
692         (-[WebView _preferencesChanged:]):
693
694 2017-10-10  Sam Weinig  <sam@webkit.org>
695
696         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
697         https://bugs.webkit.org/show_bug.cgi?id=178102
698
699         Reviewed by Tim Horton.
700
701         * History/WebHistory.mm:
702         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
703         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
704         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
705         * WebCoreSupport/WebUserMediaClient.mm:
706         (WebUserMediaClient::pageDestroyed):
707
708 2017-10-09  Robin Morisset  <rmorisset@apple.com>
709
710         Make the names of the options consistent
711         https://bugs.webkit.org/show_bug.cgi?id=177933
712
713         Reviewed by Saam Barati.
714
715         * WebView/WebFrame.h:
716         * WebView/WebHTMLView.mm:
717         (-[WebHTMLView setMarkedText:selectedRange:]):
718         * WebView/WebView.h:
719
720 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
721
722         [iOS] Tweak support for classifying form controls (followup to r222487)
723         https://bugs.webkit.org/show_bug.cgi?id=177917
724         <rdar://problem/34820122>
725
726         Reviewed by Dean Jackson.
727
728         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
729
730         * DOM/DOMHTMLInputElement.mm:
731         (-[DOMHTMLInputElement _autofillContext]):
732         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
733         (-[DOMHTMLInputElement representingPageURL]): Deleted.
734
735 2017-10-05  Keith Miller  <keith_miller@apple.com>
736
737         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
738
739         * Configurations/WebKitLegacy.xcconfig:
740
741 2017-10-05  Jer Noble  <jer.noble@apple.com>
742
743         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
744         https://bugs.webkit.org/show_bug.cgi?id=177261
745
746         Reviewed by Eric Carlson.
747
748         * Configurations/FeatureDefines.xcconfig:
749
750 2017-10-05  Chris Dumez  <cdumez@apple.com>
751
752         Drop unused parameters for CookiesStrategy::cookiesEnabled()
753         https://bugs.webkit.org/show_bug.cgi?id=177957
754
755         Reviewed by Alex Christensen.
756
757         * WebCoreSupport/WebPlatformStrategies.h:
758         * WebCoreSupport/WebPlatformStrategies.mm:
759         (WebPlatformStrategies::cookiesEnabled):
760
761 2017-10-05  Youenn Fablet  <youenn@apple.com>
762
763         Make LibWebRTCProvider port agnostic
764         https://bugs.webkit.org/show_bug.cgi?id=177747
765
766         Reviewed by Alex Christensen & Alex Garcia.
767
768         * WebView/WebView.mm:
769         (-[WebView _commonInitializationWithFrameName:groupName:]):
770         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
771
772 2017-10-04  Alex Christensen  <achristensen@webkit.org>
773
774         Stop linking with WebKitSystemInterface
775         https://bugs.webkit.org/show_bug.cgi?id=177915
776
777         Reviewed by Antti Koivisto.
778
779         * Configurations/DebugRelease.xcconfig:
780         * Configurations/WebKitLegacy.xcconfig:
781
782 2017-10-04  Alex Christensen  <achristensen@webkit.org>
783
784         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
785         https://bugs.webkit.org/show_bug.cgi?id=177912
786
787         Reviewed by Saam Barati.
788
789         * Carbon/CarbonUtils.m:
790         * Carbon/CarbonWindowAdapter.mm:
791         * Carbon/HIWebView.mm:
792         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
793         * Misc/WebNSFileManagerExtras.mm:
794         * Misc/WebNSPasteboardExtras.mm:
795         * Misc/WebNSURLExtras.mm:
796         * Plugins/Hosted/HostedNetscapePluginStream.mm:
797         * Plugins/Hosted/NetscapePluginHostManager.mm:
798         * Plugins/Hosted/NetscapePluginHostProxy.mm:
799         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
800         * Plugins/Hosted/WebHostedNetscapePluginView.h:
801         * Plugins/Hosted/WebTextInputWindowController.m:
802         * Plugins/WebBaseNetscapePluginView.mm:
803         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
804         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
805         * Plugins/WebNetscapePluginStream.mm:
806         * Plugins/WebNetscapePluginView.mm:
807         * Plugins/WebPluginDatabase.mm:
808         * WebCoreSupport/PopupMenuMac.mm:
809         * WebCoreSupport/WebChromeClient.mm:
810         * WebCoreSupport/WebFrameLoaderClient.mm:
811         * WebCoreSupport/WebInspectorClient.mm:
812         * WebCoreSupport/WebPlatformStrategies.mm:
813         * WebCoreSupport/WebSystemInterface.mm:
814         * WebView/WebDynamicScrollBarsView.mm:
815         * WebView/WebFrame.mm:
816         * WebView/WebFrameView.mm:
817         * WebView/WebFullScreenController.mm:
818         * WebView/WebHTMLView.mm:
819         * WebView/WebPreferences.mm:
820         * WebView/WebView.mm:
821
822 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
823
824         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
825         rdar://problem/34705779
826
827         Addressing review comments that I somehow landed without.
828
829         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
830
831 2017-09-29  Chris Dumez  <cdumez@apple.com>
832
833         Split some logic out of VisitedLinkStore and make it reusable
834         https://bugs.webkit.org/show_bug.cgi?id=177575
835
836         Reviewed by Alex Christensen.
837
838         * WebCoreSupport/WebVisitedLinkStore.h:
839         * WebCoreSupport/WebVisitedLinkStore.mm:
840         (WebVisitedLinkStore::addVisitedLink):
841         (WebVisitedLinkStore::removeVisitedLink):
842         (WebVisitedLinkStore::isLinkVisited):
843         (WebVisitedLinkStore::addVisitedLinkHash):
844
845 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
846
847         Build fix for High Sierra 32 bit Mac
848         https://bugs.webkit.org/show_bug.cgi?id=177551
849         <rdar://problem/34690283>
850
851         Reviewed by Alexey Proskuryakov.
852
853         Some assertions have been removed from the SDK. Replace these assertions with equivalent
854         WTF assert code.  Since the files in this patch are using tabs, some style changes were
855         also made.
856
857         * Carbon/CarbonWindowAdapter.mm:
858         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
859         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
860         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
861         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
862         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
863         (-[CarbonWindowAdapter dealloc]):
864         (-[CarbonWindowAdapter windowRef]):
865         (-[CarbonWindowAdapter _hasWindowRef]):
866         (-[CarbonWindowAdapter _managesWindowRef]):
867         (-[CarbonWindowAdapter _removeWindowRef]):
868         (-[CarbonWindowAdapter _carbonWindowClass]):
869         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
870         (-[CarbonWindowAdapter sendSuperEvent:]):
871         (-[CarbonWindowAdapter relinquishFocus]):
872         (-[CarbonWindowAdapter _cancelKey:]):
873         (-[CarbonWindowAdapter _commonAwake]):
874         (-[CarbonWindowAdapter _destroyRealWindow:]):
875         (-[CarbonWindowAdapter _oldPlaceWindow:]):
876         (-[CarbonWindowAdapter _termWindowIfOwner]):
877         (-[CarbonWindowAdapter _windowMovedToRect:]):
878         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
879         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
880         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
881         (-[CarbonWindowAdapter canBecomeKeyWindow]):
882         (-[CarbonWindowAdapter canBecomeMainWindow]):
883         (-[CarbonWindowAdapter encodeWithCoder:]):
884         (-[CarbonWindowAdapter initWithCoder:]):
885         (-[CarbonWindowAdapter setContentView:]):
886         (-[CarbonWindowAdapter worksWhenModal]):
887         (-[CarbonWindowAdapter _setModalWindowLevel]):
888         (-[CarbonWindowAdapter _clearModalWindowLevel]):
889         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
890         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
891         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
892         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
893         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
894         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
895         (NSCarbonWindowHandleEvent):
896         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
897         (-[CarbonWindowAdapter _growBoxRect]):
898         * Carbon/HIWebView.mm:
899         (HIWebViewGetWebView):
900         (HIWebViewConstructor):
901         (HIWebViewDestructor):
902         (HIWebViewRegisterClass):
903         (GetBehaviors):
904         (Draw):
905         (HitTest):
906         (GetRegion):
907         (GetWindowRef):
908         (CreateNSEventAdoptingCGEvent):
909         (CopyEventCGEvent):
910         (CreateNSEventWithCarbonClickEvent):
911         (Click):
912         (CreateNSEventWithCarbonEvent):
913         (MouseUp):
914         (CreateNSEventWithCarbonMouseMoveEvent):
915         (MouseMoved):
916         (MouseDragged):
917         (MouseWheelMoved):
918         (ContextMenuClick):
919         (GetKind):
920         (BoundsChanged):
921         (OwningWindowChanged):
922         (WindowHandler):
923         (SyncFrame):
924         (SetFocusPart):
925         (AdvanceFocus):
926         (RelinquishFocus):
927         (ActiveStateChanged):
928         (ProcessCommand):
929         (UpdateCommandStatus):
930         (_NSSelectorForHICommand):
931         (HIWebViewEventHandler):
932         (StartUpdateObserver):
933         (StopUpdateObserver):
934         (UpdateObserver):
935
936 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
937
938         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
939         https://bugs.webkit.org/show_bug.cgi?id=172526
940         <rdar://problem/32396081>
941
942         Reviewed by Ryosuke Niwa.
943
944         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
945
946         * WebCoreSupport/WebPlatformStrategies.h:
947         * WebCoreSupport/WebPlatformStrategies.mm:
948         (WebPlatformStrategies::webExposedTypes):
949         (WebPlatformStrategies::writeCustomData):
950
951 2017-09-27  Matt Lewis  <jlewis3@apple.com>
952
953         Unreviewed, rolling out r222567.
954
955         This broke and internal build.
956
957         Reverted changeset:
958
959         "Build fix for High Sierra 32 bit Mac"
960         https://bugs.webkit.org/show_bug.cgi?id=177551
961         http://trac.webkit.org/changeset/222567
962
963 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
964
965         Build fix for High Sierra 32 bit Mac
966         https://bugs.webkit.org/show_bug.cgi?id=177551
967         <rdar://problem/34690283>
968
969         Reviewed by Alexey Proskuryakov.
970
971         Some assertions have been removed from the SDK. Replace these assertions with equivalent
972         WTF assert code.  Since the files in this patch are using tabs, some style changes were
973         also made.
974
975         * Carbon/CarbonWindowAdapter.mm:
976         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
977         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
978         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
979         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
980         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
981         (-[CarbonWindowAdapter dealloc]):
982         (-[CarbonWindowAdapter windowRef]):
983         (-[CarbonWindowAdapter _hasWindowRef]):
984         (-[CarbonWindowAdapter _managesWindowRef]):
985         (-[CarbonWindowAdapter _removeWindowRef]):
986         (-[CarbonWindowAdapter _carbonWindowClass]):
987         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
988         (-[CarbonWindowAdapter sendSuperEvent:]):
989         (-[CarbonWindowAdapter relinquishFocus]):
990         (-[CarbonWindowAdapter _cancelKey:]):
991         (-[CarbonWindowAdapter _commonAwake]):
992         (-[CarbonWindowAdapter _destroyRealWindow:]):
993         (-[CarbonWindowAdapter _oldPlaceWindow:]):
994         (-[CarbonWindowAdapter _termWindowIfOwner]):
995         (-[CarbonWindowAdapter _windowMovedToRect:]):
996         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
997         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
998         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
999         (-[CarbonWindowAdapter canBecomeKeyWindow]):
1000         (-[CarbonWindowAdapter canBecomeMainWindow]):
1001         (-[CarbonWindowAdapter encodeWithCoder:]):
1002         (-[CarbonWindowAdapter initWithCoder:]):
1003         (-[CarbonWindowAdapter setContentView:]):
1004         (-[CarbonWindowAdapter worksWhenModal]):
1005         (-[CarbonWindowAdapter _setModalWindowLevel]):
1006         (-[CarbonWindowAdapter _clearModalWindowLevel]):
1007         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
1008         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
1009         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
1010         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1011         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1012         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
1013         (NSCarbonWindowHandleEvent):
1014         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
1015         (-[CarbonWindowAdapter _growBoxRect]):
1016         * Carbon/HIWebView.mm:
1017         (HIWebViewGetWebView):
1018         (HIWebViewConstructor):
1019         (HIWebViewDestructor):
1020         (HIWebViewRegisterClass):
1021         (GetBehaviors):
1022         (Draw):
1023         (HitTest):
1024         (GetRegion):
1025         (GetWindowRef):
1026         (CreateNSEventAdoptingCGEvent):
1027         (CopyEventCGEvent):
1028         (CreateNSEventWithCarbonClickEvent):
1029         (Click):
1030         (CreateNSEventWithCarbonEvent):
1031         (MouseUp):
1032         (CreateNSEventWithCarbonMouseMoveEvent):
1033         (MouseMoved):
1034         (MouseDragged):
1035         (MouseWheelMoved):
1036         (ContextMenuClick):
1037         (GetKind):
1038         (BoundsChanged):
1039         (OwningWindowChanged):
1040         (WindowHandler):
1041         (SyncFrame):
1042         (SetFocusPart):
1043         (AdvanceFocus):
1044         (RelinquishFocus):
1045         (ActiveStateChanged):
1046         (ProcessCommand):
1047         (UpdateCommandStatus):
1048         (_NSSelectorForHICommand):
1049         (HIWebViewEventHandler):
1050         (StartUpdateObserver):
1051         (StopUpdateObserver):
1052         (UpdateObserver):
1053
1054 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1055
1056         Make PolicyAction an encodable enum class
1057         https://bugs.webkit.org/show_bug.cgi?id=177480
1058
1059         Reviewed by Antti Koivisto.
1060
1061         * Plugins/WebPluginContainerCheck.mm:
1062         (-[WebPluginContainerCheck _continueWithPolicy:]):
1063         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
1064         * WebCoreSupport/WebFrameLoaderClient.mm:
1065         (-[WebFramePolicyListener invalidate]):
1066         (-[WebFramePolicyListener ignore]):
1067         (-[WebFramePolicyListener download]):
1068         (-[WebFramePolicyListener use]):
1069         (-[WebFramePolicyListener continue]):
1070         * WebView/WebPolicyDelegate.mm:
1071         (-[WebPolicyDecisionListener use]):
1072         (-[WebPolicyDecisionListener ignore]):
1073         (-[WebPolicyDecisionListener download]):
1074
1075 2017-09-25  Frederik Riedel  <riedel@apple.com>
1076
1077         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
1078         https://bugs.webkit.org/show_bug.cgi?id=174394
1079         <rdar://problem/33183504>
1080
1081         Reviewed by Ryosuke Niwa.
1082
1083         * DOM/DOMHTMLInputElement.h:
1084         * DOM/DOMHTMLInputElement.mm:
1085         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
1086         Determines if this HTMLInputElement is part of a login screen.
1087         (-[DOMHTMLInputElement representingPageUrl]):
1088         Returns the webpage's URL that is currently displayed in the Web View.
1089         (-[DOMHTMLInputElement insertTextSuggestion:]):
1090         Inserts login credentials into the Web View.
1091
1092 2017-09-25  Sam Weinig  <sam@webkit.org>
1093
1094         Remove unused EditorClient functions
1095         https://bugs.webkit.org/show_bug.cgi?id=177463
1096
1097         Reviewed by Alex Christensen.
1098
1099         Remove unused EditorClient functions.
1100
1101         * WebCoreSupport/WebEditorClient.h:
1102         * WebCoreSupport/WebEditorClient.mm:
1103         (WebEditorClient::canonicalizeURL): Deleted.
1104         (WebEditorClient::canonicalizeURLString): Deleted.
1105         (WebEditorClient::writeDataToPasteboard): Deleted.
1106         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
1107         (WebEditorClient::readDataFromPasteboard): Deleted.
1108         (WebEditorClient::pasteboardChangeCount): Deleted.
1109
1110 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1111
1112         Stop using PolicyCallback
1113         https://bugs.webkit.org/show_bug.cgi?id=176088
1114
1115         Reviewed by Andy Estes.
1116
1117         * WebCoreSupport/WebFrameLoaderClient.mm:
1118         (-[WebFramePolicyListener invalidate]):
1119         (-[WebFramePolicyListener receivedPolicyDecision:]):
1120
1121 2017-09-25  Sam Weinig  <sam@webkit.org>
1122
1123         Remove unnecessary userVisibleString EditorClient function
1124         https://bugs.webkit.org/show_bug.cgi?id=177456
1125
1126         Reviewed by Dan Bernstein.
1127
1128         * WebCoreSupport/WebEditorClient.h:
1129         * WebCoreSupport/WebEditorClient.mm:
1130         (WebEditorClient::userVisibleString): Deleted.
1131
1132             Remove userVisibleString client function.
1133
1134 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1135
1136         Separate form submission from PolicyChecker infrastructure
1137         https://bugs.webkit.org/show_bug.cgi?id=177396
1138
1139         Reviewed by Geoffrey Garen.
1140
1141         * WebCoreSupport/WebFrameLoaderClient.h:
1142         * WebCoreSupport/WebFrameLoaderClient.mm:
1143         (WebFrameLoaderClient::dispatchWillSubmitForm):
1144
1145 2017-09-22  Zalan Bujtas  <zalan@apple.com>
1146
1147         WeakPtrFactory should populate m_ref lazily.
1148         https://bugs.webkit.org/show_bug.cgi?id=177375
1149
1150         Reviewed by Geoffrey Garen.
1151
1152         * WebCoreSupport/WebEditorClient.mm:
1153         (WebEditorClient::WebEditorClient):
1154         (WebEditorClient::requestCandidatesForSelection):
1155
1156 2017-09-22  Chris Dumez  <cdumez@apple.com>
1157
1158         Use high resolution timestamp for event time
1159         https://bugs.webkit.org/show_bug.cgi?id=154246
1160         <rdar://problem/34333304>
1161
1162         Reviewed by Ryosuke Niwa.
1163
1164         Use WallTime / MonotonicTime instead of double type for clarity.
1165
1166         * DOM/DOMEvent.mm:
1167         (-[DOMEvent timeStamp]):
1168         * WebView/WebFrame.mm:
1169         (-[WebFrame _dragSourceEndedAt:operation:]):
1170         * WebView/WebPDFView.mm:
1171         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1172
1173 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
1174
1175         Enable dataTransfer.items on macOS and iOS
1176         https://bugs.webkit.org/show_bug.cgi?id=177335
1177
1178         Reviewed by Sam Weinig.
1179
1180         * WebView/WebPreferences.mm:
1181         (+[WebPreferences initialize]):
1182
1183 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
1184
1185         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
1186         https://bugs.webkit.org/show_bug.cgi?id=177101
1187         <rdar://problem/34500648>
1188
1189         Reviewed by Brian Burg.
1190
1191         * WebInspector/WebNodeHighlight.mm:
1192         Ensure we close the window that we have just removed.
1193
1194 2017-09-20  Antti Koivisto  <antti@apple.com>
1195
1196         Remove DOM and styling support for CSS Regions
1197         https://bugs.webkit.org/show_bug.cgi?id=177221
1198
1199         Reviewed by Andreas Kling.
1200
1201         * Configurations/FeatureDefines.xcconfig:
1202         * DOM/DOMCSS.mm:
1203         (kitClass):
1204         * DOM/DOMElement.mm:
1205         (-[DOMElement webkitRegionOverset]): Deleted.
1206
1207 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
1208
1209         Layering violation in Editor::createFragment
1210         https://bugs.webkit.org/show_bug.cgi?id=176123
1211
1212         Reviewed by Darin Adler.
1213
1214         * Misc/WebNSURLExtras.h:
1215         * Misc/WebNSURLExtras.mm:
1216         * WebView/WebFrame.mm:
1217         * WebView/WebHTMLView.mm:
1218         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
1219
1220         * WebCoreSupport/WebEditorClient.mm:
1221         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
1222         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
1223         way to avoid exporting the symbol just on newer OSes.
1224
1225 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
1226
1227         On iOS, getData can't get text set by setData during copy event
1228         https://bugs.webkit.org/show_bug.cgi?id=176980
1229         <rdar://problem/34453915>
1230
1231         Reviewed by Darin Adler.
1232
1233         * WebCoreSupport/WebPlatformStrategies.h:
1234         * WebCoreSupport/WebPlatformStrategies.mm:
1235         (WebPlatformStrategies::copy): Deleted.
1236
1237 2017-09-18  Andy Estes  <aestes@apple.com>
1238
1239         [Mac] Upstream miscellaneous WebKitSystemInterface functions
1240         https://bugs.webkit.org/show_bug.cgi?id=177029
1241
1242         Reviewed by Alex Christensen.
1243
1244         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1245         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
1246         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1247         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1248         * WebCoreSupport/PopupMenuMac.mm:
1249         (PopupMenuMac::show):
1250         * WebCoreSupport/WebSystemInterface.mm:
1251         (InitWebCoreSystemInterface):
1252         * WebView/WebHTMLView.mm:
1253         (-[WebHTMLView setDataSource:]):
1254         (-[WebHTMLView attachRootLayer:]):
1255         * WebView/WebView.mm:
1256         (-[WebView _needsAdobeFrameReloadingQuirk]):
1257         (-[WebView _needsLinkElementTextCSSQuirk]):
1258         (-[WebView _needsIsLoadingInAPISenseQuirk]):
1259         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
1260         (-[WebView _preferencesChanged:]):
1261
1262 2017-09-15  Andy Estes  <aestes@apple.com>
1263
1264         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
1265         https://bugs.webkit.org/show_bug.cgi?id=176953
1266
1267         Reviewed by Eric Carlson.
1268
1269         * WebCoreSupport/WebSystemInterface.mm:
1270         (InitWebCoreSystemInterface):
1271
1272 2017-09-14  Andy Estes  <aestes@apple.com>
1273
1274         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
1275         https://bugs.webkit.org/show_bug.cgi?id=176931
1276
1277         Reviewed by Joseph Pecoraro.
1278
1279         * WebCoreSupport/WebSystemInterface.mm:
1280         (InitWebCoreSystemInterface):
1281
1282 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1283
1284         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
1285         https://bugs.webkit.org/show_bug.cgi?id=176867
1286
1287         Reviewed by Sam Weinig.
1288
1289         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1290         (WebKit::NetscapePluginInstanceProxy::enumerate):
1291
1292 2017-09-13  Andy Estes  <aestes@apple.com>
1293
1294         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
1295         https://bugs.webkit.org/show_bug.cgi?id=176729
1296
1297         Reviewed by Alex Christensen.
1298
1299         * WebCoreSupport/WebSystemInterface.mm:
1300         (InitWebCoreSystemInterface):
1301         * WebView/WebView.mm:
1302         (+[WebView _setCacheModel:]):
1303
1304 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1305
1306         Refactor WebContentReader out of EditorMac and EditorIOS
1307         https://bugs.webkit.org/show_bug.cgi?id=176770
1308
1309         Reviewed by Sam Weinig.
1310
1311         * WebCoreSupport/WebEditorClient.mm:
1312
1313 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
1314
1315         Dragging & dropping a file creates an attachment element even when it's disabled
1316         https://bugs.webkit.org/show_bug.cgi?id=176769
1317
1318         Reviewed by Tim Horton.
1319
1320         * WebView/WebView.mm:
1321         (-[WebView _preferencesChanged:]):
1322
1323 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1324
1325         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
1326         https://bugs.webkit.org/show_bug.cgi?id=176721
1327         <rdar://problem/34373660>
1328
1329         Reviewed by Tim Horton.
1330
1331         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
1332         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
1333
1334         * WebView/WebView.mm:
1335         (-[WebView _startDrag:]):
1336         (-[WebView _draggedElementBounds]):
1337         (-[WebView _endedDataInteraction:global:]):
1338         * WebView/WebViewData.h:
1339
1340 2017-09-11  Andy Estes  <aestes@apple.com>
1341
1342         [Mac] Upstream QTKit-related WebKitSystemInterface functions
1343         https://bugs.webkit.org/show_bug.cgi?id=176472
1344
1345         Reviewed by Eric Carlson.
1346
1347         * WebCoreSupport/WebSystemInterface.mm:
1348         (InitWebCoreSystemInterface):
1349
1350 2017-09-09  Mark Lam  <mark.lam@apple.com>
1351
1352         Avoid duplicate computations of ExecState::vm().
1353         https://bugs.webkit.org/show_bug.cgi?id=176647
1354
1355         Reviewed by Saam Barati.
1356
1357         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1358         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1359         (WebKit::NetscapePluginInstanceProxy::construct):
1360         (WebKit::NetscapePluginInstanceProxy::setProperty):
1361         (WebKit::NetscapePluginInstanceProxy::removeProperty):
1362         (WebKit::NetscapePluginInstanceProxy::enumerate):
1363         * Plugins/Hosted/ProxyInstance.mm:
1364         (WebKit::ProxyRuntimeMethod::create):
1365
1366 2017-09-08  Commit Queue  <commit-queue@webkit.org>
1367
1368         Unreviewed, rolling out r221773.
1369         https://bugs.webkit.org/show_bug.cgi?id=176614
1370
1371         This caused build failures. (Requested by mlewis13 on
1372         #webkit).
1373
1374         Reverted changeset:
1375
1376         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
1377         https://bugs.webkit.org/show_bug.cgi?id=176472
1378         http://trac.webkit.org/changeset/221773
1379
1380 2017-09-07  Andy Estes  <aestes@apple.com>
1381
1382         [Mac] Upstream QTKit-related WebKitSystemInterface functions
1383         https://bugs.webkit.org/show_bug.cgi?id=176472
1384
1385         Reviewed by Eric Carlson.
1386
1387         * WebCoreSupport/WebSystemInterface.mm:
1388         (InitWebCoreSystemInterface):
1389
1390 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
1391
1392         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
1393         https://bugs.webkit.org/show_bug.cgi?id=176561
1394
1395         Reviewed by Brent Fulgham.
1396
1397         * Misc/WebNSUserDefaultsExtras.mm:
1398
1399 2017-09-07  Alex Christensen  <achristensen@webkit.org>
1400
1401         Modernize Geolocation code
1402         https://bugs.webkit.org/show_bug.cgi?id=176496
1403
1404         Reviewed by Andy Estes.
1405
1406         * WebCoreSupport/WebGeolocationClient.h:
1407         * WebCoreSupport/WebGeolocationClient.mm:
1408         (WebGeolocationClient::requestPermission):
1409         (-[WebGeolocationPolicyListener initWithGeolocation:]):
1410         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
1411         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
1412         * WebView/WebView.mm:
1413         (-[WebView _commonInitializationWithFrameName:groupName:]):
1414         (-[WebView _geolocationDidFailWithMessage:]):
1415
1416 2017-09-05  Tim Horton  <timothy_horton@apple.com>
1417
1418         Remove some unused bits of code and resources
1419         https://bugs.webkit.org/show_bug.cgi?id=176275
1420
1421         Reviewed by Dan Bernstein.
1422
1423         * Misc/WebNSFileManagerExtras.mm:
1424         Include FileSystem instead of FileSystemIOS.
1425
1426 2017-09-03  Darin Adler  <darin@apple.com>
1427
1428         [Cocoa] Tidy a few things in legacy WebHTMLView
1429         https://bugs.webkit.org/show_bug.cgi?id=176280
1430
1431         Reviewed by Dan Bernstein.
1432
1433         * WebCoreSupport/WebChromeClient.mm:
1434         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
1435         methods it calls on WebHTMLView were doing nothing on iOS.
1436
1437         * WebView/WebFrame.mm:
1438         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
1439         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
1440
1441         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
1442         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
1443         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
1444         order. Removed all sorts of unused things. Made more code and fields Mac-only where
1445         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
1446         Use RetainPtr instead of writing retain/release wherever possible.
1447         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
1448         initialization for it. Removed various unused methods and declarations of methods.
1449         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
1450         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
1451         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
1452         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
1453         and remove CFRetain no longer needed since we don't support garbage collection any more.
1454         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
1455         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
1456         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
1457         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
1458         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
1459         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
1460         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
1461         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1462         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
1463         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
1464         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
1465         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
1466         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
1467         debug flag; we haven't used it for years and it's not clearly helpful.
1468         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
1469         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
1470         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
1471         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
1472         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
1473         two additional methods in the WebPrivate category and still be called by the two
1474         methods in the WebInternal category that were already using it.
1475         (-[WebHTMLView didAddSubview:]): Deleted.
1476         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
1477         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
1478         place this was called, the close method.
1479         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
1480         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
1481         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
1482         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
1483         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
1484         Added helper method to make the one below simpler.
1485         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1486         Compared pasteboard type strings using isEqualToString: rather than using == since
1487         we want to actually compare the string contents. Also updated to use modern for loop,
1488         renamed a local variable from "s" to "localSubresources", and factored out the handling
1489         of three image types to use the helper method above.
1490         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
1491         _web_makePluginSubviewsPerformSelector:withObject: method.
1492         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
1493         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
1494         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
1495         not call the -[NSView subviews] method to make this identical on both platforms and used
1496         a modern for loop.
1497         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
1498         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
1499         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
1500         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
1501         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
1502         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
1503         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
1504         of it is Mac-only.
1505         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
1506         method did was call itself on the main thread, and do nothing if called on main thread.
1507         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
1508         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
1509         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
1510         half of this method.
1511         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
1512         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
1513         Simplified using a modern for loop and RetainPtr.
1514         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
1515         (-[WebHTMLView keyDown:]): Ditto.
1516         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
1517         (-[WebHTMLView performKeyEquivalent:]): Ditto.
1518         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
1519         (-[WebHTMLView complete:]): Ditto.
1520         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
1521         now macOS-only.
1522         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
1523         iOS since that is now macOS-only.
1524         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
1525         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
1526         a private one because it is not used or needed outside WebKit. Also made it macOS-only
1527         and reorganized to use early return.
1528         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
1529         on iOS, but kept there so we don't have to do #if at every call site.
1530         (-[WebHTMLView _pluginController]): Moved into internal category.
1531         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
1532         there only for GC, using C++ initialization, removing obsolete comment.
1533         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
1534         peculiar iOS-only comment.
1535         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
1536
1537         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
1538         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
1539         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
1540         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
1541         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
1542
1543         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
1544         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
1545         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
1546         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
1547         them at this time.
1548
1549 2017-09-03  Sam Weinig  <sam@webkit.org>
1550
1551         Remove CanvasProxy
1552         https://bugs.webkit.org/show_bug.cgi?id=176288
1553
1554         Reviewed by Yusuke Suzuki.
1555
1556         CanvasProxy does not appear to be in any current HTML spec
1557         and was disabled and unimplemented in our tree. Time to 
1558         get rid of it.
1559
1560         * Configurations/FeatureDefines.xcconfig:
1561
1562 2017-09-02  Andy Estes  <aestes@apple.com>
1563
1564         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
1565         https://bugs.webkit.org/show_bug.cgi?id=176270
1566
1567         Reviewed by Tim Horton.
1568
1569         * Plugins/Hosted/NetscapePluginHostManager.mm:
1570         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1571         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1572         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1573         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
1574         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
1575         (WebKit::SoftwareCARenderer::context const):
1576         (WebKit::SoftwareCARenderer::renderContext const):
1577         (WebKit::SoftwareCARenderer::render):
1578         (-[WebHostedNetscapePluginView createPlugin]):
1579         (-[WebHostedNetscapePluginView createPluginLayer]):
1580         (-[WebHostedNetscapePluginView destroyPlugin]):
1581         (-[WebHostedNetscapePluginView drawRect:]):
1582         * WebCoreSupport/WebSystemInterface.mm:
1583         (InitWebCoreSystemInterface):
1584
1585 2017-09-01  Andy Estes  <aestes@apple.com>
1586
1587         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
1588         https://bugs.webkit.org/show_bug.cgi?id=176200
1589
1590         Reviewed by Tim Horton.
1591
1592         * Carbon/HIWebView.mm:
1593         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
1594         (overrideCGContext):
1595         (restoreCGContext):
1596         (Draw):
1597         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1598         (+[WebHostedNetscapePluginView initialize]):
1599         * Plugins/WebBaseNetscapePluginView.h:
1600         * Plugins/WebBaseNetscapePluginView.mm:
1601         (WebKit::sendUserChangeNotifications):
1602         * Plugins/WebNetscapePluginView.mm:
1603         (+[WebNetscapePluginView initialize]):
1604         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1605         * WebCoreSupport/WebSystemInterface.mm:
1606         (InitWebCoreSystemInterface):
1607         * WebView/WebFrame.mm:
1608         (-[WebFrame _paintBehaviorForDestinationContext:]):
1609         * WebView/WebFullScreenController.mm:
1610         (setClipRectForWindow):
1611         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
1612         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
1613         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
1614         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
1615
1616 2017-08-31  Andy Estes  <aestes@apple.com>
1617
1618         [Mac] Upstream AppKit-related WebKitSystemInterface functions
1619         https://bugs.webkit.org/show_bug.cgi?id=176175
1620
1621         Reviewed by Brady Eidson.
1622
1623         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1624         (WebKit::NetscapePluginInstanceProxy::keyEvent):
1625         * Plugins/Hosted/WebTextInputWindowController.m:
1626         (-[WebTextInputPanel init]):
1627         * WebCoreSupport/WebSystemInterface.mm:
1628         (InitWebCoreSystemInterface):
1629         * WebView/WebDynamicScrollBarsView.mm:
1630         (-[WebDynamicScrollBarsView scrollWheel:]):
1631         * WebView/WebHTMLView.mm:
1632         (-[WebHTMLView _removeWindowObservers]):
1633         (-[WebHTMLView addWindowObservers]):
1634         * WebView/WebView.mm:
1635         (-[WebView addWindowObserversForWindow:]):
1636         (-[WebView removeWindowObservers]):
1637         (-[WebView viewWillMoveToWindow:]):
1638
1639 2017-08-31  Alex Christensen  <achristensen@webkit.org>
1640
1641         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
1642         https://bugs.webkit.org/show_bug.cgi?id=175779
1643         <rdar://problem/22367975>
1644
1645         Reviewed by Tim Horton.
1646
1647         * WebCoreSupport/WebFrameLoaderClient.h:
1648         * WebCoreSupport/WebFrameLoaderClient.mm:
1649         (WebFrameLoaderClient::webGLPolicyForURL const):
1650         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
1651
1652 2017-08-30  Andy Estes  <aestes@apple.com>
1653
1654         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
1655         https://bugs.webkit.org/show_bug.cgi?id=176093
1656
1657         Reviewed by Eric Carlson.
1658
1659         * WebCoreSupport/WebSystemInterface.mm:
1660         (InitWebCoreSystemInterface):
1661
1662 2017-08-30  Andy Estes  <aestes@apple.com>
1663
1664         [Mac] Upstream Carbon-related WebKitSystemInterface functions
1665         https://bugs.webkit.org/show_bug.cgi?id=176087
1666
1667         Reviewed by Alex Christensen.
1668
1669         * Carbon/CarbonUtils.m:
1670         (getNSAutoreleasePoolCount):
1671         (WebInitForCarbon):
1672         (PoolCleaner):
1673         * Carbon/CarbonWindowAdapter.mm:
1674         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1675         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1676         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1677         (-[CarbonWindowAdapter _windowMovedToRect:]):
1678         * Carbon/HIViewAdapter.m:
1679         * Carbon/HIWebView.mm:
1680         (Draw):
1681         (CreateNSEventAdoptingCGEvent):
1682         (CopyEventCGEvent):
1683         (CreateNSEventWithCarbonClickEvent):
1684         (Click):
1685         (CreateNSEventWithCarbonEvent):
1686         (MouseUp):
1687         (CreateNSEventWithCarbonMouseMoveEvent):
1688         (MouseMoved):
1689         (MouseDragged):
1690         (MouseWheelMoved):
1691         (WindowHandler):
1692         (HIWebViewEventHandler):
1693         * Misc/QuickDrawCompatibility.h: Removed.
1694         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1695         (getCarbonEvent):
1696         (WebNetscapePluginEventHandlerCarbon::keyDown):
1697         (WebNetscapePluginEventHandlerCarbon::keyUp):
1698         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1699         (WebNetscapePluginEventHandlerCocoa::keyDown):
1700         * Plugins/WebNetscapePluginView.mm:
1701         (-[WebNetscapePluginView tellQuickTimeToChill]):
1702
1703 2017-08-29  Andy Estes  <aestes@apple.com>
1704
1705         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
1706         https://bugs.webkit.org/show_bug.cgi?id=176046
1707
1708         Reviewed by Alex Christensen.
1709
1710         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
1711         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
1712
1713         * Misc/WebNSFileManagerExtras.mm:
1714         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
1715         (setMetaData): Deleted.
1716         * WebCoreSupport/WebSystemInterface.mm:
1717         (InitWebCoreSystemInterface):
1718
1719 2017-08-28  Andy Estes  <aestes@apple.com>
1720
1721         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
1722         https://bugs.webkit.org/show_bug.cgi?id=176039
1723
1724         Reviewed by Alex Christensen.
1725
1726         * WebCoreSupport/WebSystemInterface.mm:
1727         (InitWebCoreSystemInterface):
1728         * WebView/WebPreferences.mm:
1729         (+[WebPreferences _systemCFStringEncoding]):
1730
1731 2017-08-28  Andy Estes  <aestes@apple.com>
1732
1733         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
1734         https://bugs.webkit.org/show_bug.cgi?id=176032
1735
1736         Reviewed by Alex Christensen.
1737
1738         * WebCoreSupport/WebSystemInterface.mm:
1739         (InitWebCoreSystemInterface):
1740         * WebView/WebView.mm:
1741         (-[WebView _cachedResponseForURL:]):
1742
1743 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
1744
1745         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
1746         https://bugs.webkit.org/show_bug.cgi?id=175992
1747         <rdar://problem/34086613>
1748
1749         Reviewed by Daniel Bates.
1750
1751         * WebCoreSupport/WebPlatformStrategies.h:
1752         * WebCoreSupport/WebPlatformStrategies.mm:
1753         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
1754         cookies should be included, and return a pair containing the resulting cookie string and a boolean
1755         indicating if secure cookies were accessed.
1756
1757 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1758
1759         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
1760         https://bugs.webkit.org/show_bug.cgi?id=170955
1761         <rdar://problem/31697653>
1762
1763         Reviewed by Ryosuke Niwa.
1764
1765         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
1766         text is being replaced.
1767
1768         * WebView/WebHTMLView.mm:
1769         (-[WebHTMLView insertText:]):
1770
1771 2017-08-24  Chris Dumez  <cdumez@apple.com>
1772
1773         [Directory Upload] Add basic support for input.webkitdirectory
1774         https://bugs.webkit.org/show_bug.cgi?id=175950
1775         <rdar://problem/33951915>
1776
1777         Reviewed by Geoffrey Garen.
1778
1779         Add private API to toggle Directory Upload support on Mac WebKit1.
1780
1781         * WebView/WebPreferenceKeysPrivate.h:
1782         * WebView/WebPreferences.mm:
1783         (+[WebPreferences initialize]):
1784         (-[WebPreferences setDirectoryUploadEnabled:]):
1785         (-[WebPreferences directoryUploadEnabled]):
1786         * WebView/WebPreferencesPrivate.h:
1787         * WebView/WebView.mm:
1788         (-[WebView _preferencesChanged:]):
1789
1790 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1791
1792         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
1793         https://bugs.webkit.org/show_bug.cgi?id=175370
1794         <rdar://problem/33799806>
1795
1796         Reviewed by Ryosuke Niwa.
1797
1798         Adjust WebEditorClient for interface changes.
1799
1800         * WebCoreSupport/WebEditorClient.h:
1801
1802 2017-08-22  Alex Christensen  <achristensen@webkit.org>
1803
1804         Remove ChromeClient::scrollbarsModeDidChange
1805         https://bugs.webkit.org/show_bug.cgi?id=175805
1806
1807         Reviewed by Daniel Bates.
1808
1809         * WebCoreSupport/WebChromeClient.h:
1810
1811 2017-08-22  Alex Christensen  <achristensen@webkit.org>
1812
1813         Remove ChromeClient::hasOpenedPopup
1814         https://bugs.webkit.org/show_bug.cgi?id=175804
1815
1816         Reviewed by Sam Weinig.
1817
1818         * WebCoreSupport/WebChromeClient.h:
1819         * WebCoreSupport/WebChromeClient.mm:
1820         (WebChromeClient::hasOpenedPopup const): Deleted.
1821
1822 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
1823
1824         Disable access to secure cookies if an HTTPS site loads mixed content
1825         https://bugs.webkit.org/show_bug.cgi?id=157053
1826         <rdar://problem/11290808>
1827
1828         Reviewed by Dan Bates.
1829
1830         * WebCoreSupport/WebPlatformStrategies.h:
1831         * WebCoreSupport/WebPlatformStrategies.mm:
1832         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
1833         indicating whether secure cookies should be included in the response.
1834
1835 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1836
1837         [PAL] Move spi/mac directory into PAL
1838         https://bugs.webkit.org/show_bug.cgi?id=175649
1839
1840         Reviewed by Myles C. Maxfield.
1841
1842         * Misc/WebSharingServicePickerController.h:
1843         * WebCoreSupport/WebContextMenuClient.mm:
1844         * WebCoreSupport/WebEditorClient.mm:
1845         * WebCoreSupport/WebSelectionServiceController.mm:
1846         * WebView/WebHTMLView.mm:
1847         * WebView/WebImmediateActionController.h:
1848         * WebView/WebImmediateActionController.mm:
1849         * WebView/WebView.mm:
1850
1851 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
1852
1853         [PAL] Relocate SessionID to root
1854         https://bugs.webkit.org/show_bug.cgi?id=175684
1855
1856         Reviewed by Alex Christensen.
1857
1858         * WebCoreSupport/WebFrameNetworkingContext.mm:
1859
1860 2017-08-17  Andreas Kling  <akling@apple.com>
1861
1862         Disable CSS regions at compile time
1863         https://bugs.webkit.org/show_bug.cgi?id=175630
1864
1865         Reviewed by Antti Koivisto.
1866
1867         * Configurations/FeatureDefines.xcconfig:
1868
1869 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
1870
1871         [PAL] Move SessionID into PAL
1872         https://bugs.webkit.org/show_bug.cgi?id=174192
1873
1874         Reviewed by Antti Koivisto.
1875
1876         * Misc/WebCache.mm:
1877         (+[WebCache imageForURL:]):
1878         * WebCoreSupport/WebFrameLoaderClient.h:
1879         * WebCoreSupport/WebFrameLoaderClient.mm:
1880         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1881         * WebCoreSupport/WebFrameNetworkingContext.mm:
1882         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1883         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
1884         (WebFrameNetworkingContext::storageSession const):
1885         * WebCoreSupport/WebPlatformStrategies.h:
1886         * WebCoreSupport/WebPlatformStrategies.mm:
1887         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1888         * WebKitPrefix.h:
1889
1890 2017-08-16  Andy Estes  <aestes@apple.com>
1891
1892         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
1893         https://bugs.webkit.org/show_bug.cgi?id=175648
1894
1895         Reviewed by Tim Horton.
1896
1897         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1898         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1899         (WebPaymentCoordinatorClient::showPaymentUI):
1900
1901 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1902
1903         [PAL] Move spi/ios and spi/win directories into PAL
1904         https://bugs.webkit.org/show_bug.cgi?id=175171
1905
1906         Reviewed by Antti Koivisto.
1907
1908         * WebCoreSupport/WebFrameLoaderClient.mm:
1909         * WebView/WebView.mm:
1910
1911 2017-08-16  Andy Estes  <aestes@apple.com>
1912
1913         [Payment Request] Add an ENABLE flag and an experimental feature preference
1914         https://bugs.webkit.org/show_bug.cgi?id=175622
1915
1916         Reviewed by Tim Horton.
1917
1918         * Configurations/FeatureDefines.xcconfig:
1919
1920 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
1921
1922         [PAL] Move Sleep classes into PAL
1923         https://bugs.webkit.org/show_bug.cgi?id=175456
1924
1925         Reviewed by Ryosuke Niwa.
1926
1927         * WebView/WebFullScreenController.h:
1928
1929 2017-08-15  Youenn Fablet  <youenn@apple.com>
1930
1931         [Cache API] Adding generic support for CacheStorage and Cache methods
1932         https://bugs.webkit.org/show_bug.cgi?id=175455
1933
1934         Reviewed by Chris Dumez.
1935
1936         * WebView/WebView.mm:
1937         (-[WebView _commonInitializationWithFrameName:groupName:]):
1938
1939 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
1940
1941         Remove Proximity Events and related code
1942         https://bugs.webkit.org/show_bug.cgi?id=175545
1943
1944         Reviewed by Daniel Bates.
1945
1946         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
1947         and other related code.
1948
1949         * Configurations/FeatureDefines.xcconfig:
1950
1951 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
1952
1953         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
1954         https://bugs.webkit.org/show_bug.cgi?id=175504
1955
1956         Reviewed by Sam Weinig.
1957
1958         * Configurations/FeatureDefines.xcconfig:
1959         * DOM/DOMHTMLFormElement.mm:
1960         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
1961         * WebCoreSupport/WebFrameLoaderClient.h:
1962
1963 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
1964
1965         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
1966         https://bugs.webkit.org/show_bug.cgi?id=175557
1967
1968         Reviewed by Jon Lee.
1969
1970         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
1971
1972         * Configurations/FeatureDefines.xcconfig:
1973
1974 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
1975
1976         Composition underline color is always black
1977         https://bugs.webkit.org/show_bug.cgi?id=174675
1978
1979         Reviewed by Ryosuke Niwa.
1980
1981         * WebView/WebHTMLView.mm:
1982         (extractUnderlines): If NSUnderlineColorAttributeName
1983         is not present use text color for composition underline.
1984         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
1985         for composition underline in the plain text case.
1986
1987 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
1988
1989         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
1990         https://bugs.webkit.org/show_bug.cgi?id=175474
1991         <rdar://problem/33844628>
1992
1993         Reviewed by Wenson Hsieh.
1994
1995         Replaced the build flag by a runtime flag and disabled the feature by default.
1996
1997         * Configurations/FeatureDefines.xcconfig:
1998         * WebView/WebPreferenceKeysPrivate.h:
1999         * WebView/WebPreferences.mm:
2000         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
2001         (-[WebPreferences dataTransferItemsEnabled]): Added.
2002         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
2003         * WebView/WebPreferencesPrivate.h:
2004         * WebView/WebView.mm:
2005         (-[WebView _preferencesChanged:]):
2006
2007 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2008
2009         Remove ENABLE_GAMEPAD_DEPRECATED
2010         https://bugs.webkit.org/show_bug.cgi?id=175361
2011
2012         Reviewed by Carlos Garcia Campos.
2013
2014         * Configurations/FeatureDefines.xcconfig:
2015
2016 2017-08-09  Chris Dumez  <cdumez@apple.com>
2017
2018         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
2019         https://bugs.webkit.org/show_bug.cgi?id=175401
2020
2021         Reviewed by Brady Eidson.
2022
2023         * WebView/WebPreferenceKeysPrivate.h:
2024         * WebView/WebPreferences.mm:
2025         (+[WebPreferences initialize]):
2026         (-[WebPreferences beaconAPIEnabled]): Deleted.
2027         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
2028         * WebView/WebPreferencesPrivate.h:
2029         * WebView/WebView.mm:
2030         (-[WebView _preferencesChanged:]):
2031
2032 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2033
2034         [PAL] Move spi/cocoa and spi/cg directories into PAL
2035         https://bugs.webkit.org/show_bug.cgi?id=175175
2036
2037         Reviewed by Myles C. Maxfield.
2038
2039         * History/WebHistory.mm:
2040         * Misc/WebDownload.mm:
2041         * Misc/WebKitNSStringExtras.mm:
2042         * Plugins/Hosted/NetscapePluginHostManager.mm:
2043         * Plugins/WebPluginDatabase.mm:
2044         * WebCoreSupport/WebFrameLoaderClient.mm:
2045         * WebInspector/WebNodeHighlight.mm:
2046         * WebView/WebHTMLView.mm:
2047         * WebView/WebIndicateLayer.mm:
2048         * WebView/WebView.mm:
2049         * WebView/WebViewData.h:
2050
2051 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2052
2053         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
2054         https://bugs.webkit.org/show_bug.cgi?id=175392
2055         <rdar://problem/33783207>
2056
2057         Reviewed by Tim Horton and Megan Gardner.
2058
2059         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
2060
2061         * Configurations/FeatureDefines.xcconfig:
2062
2063 2017-08-09  Daniel Bates  <dabates@apple.com>
2064
2065         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
2066         https://bugs.webkit.org/show_bug.cgi?id=175247
2067         <rdar://problem/33679804>
2068
2069         Reviewed by Brady Eidson.
2070
2071         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
2072         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
2073         clients that need to make use of this information at this time. If such a needs comes up
2074         then we can expose API/SPI similar to what we do for WebKit.
2075
2076         * WebCoreSupport/WebFrameLoaderClient.h:
2077         * WebCoreSupport/WebFrameLoaderClient.mm:
2078         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2079
2080 2017-08-08  Brady Eidson  <beidson@apple.com>
2081
2082         Don't enable default icon loading in WK1 for apps linked against old SDKs.
2083         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
2084
2085         Reviewed by Andy Estes.
2086
2087         * Misc/WebKitVersionChecks.h:
2088         * WebCoreSupport/WebFrameLoaderClient.mm:
2089         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
2090           the app is linked against new WebKit with the new behavior.
2091
2092 2017-08-07  Devin Rousso  <drousso@apple.com>
2093
2094         Web Inspector: Preview Canvas path when viewing a recording
2095         https://bugs.webkit.org/show_bug.cgi?id=174967
2096
2097         Reviewed by Brian Burg.
2098
2099         * WebView/WebPreferenceKeysPrivate.h:
2100         * WebView/WebPreferences.mm:
2101         (+[WebPreferences initialize]):
2102         (-[WebPreferences inspectorAdditionsEnabled]):
2103         (-[WebPreferences setInspectorAdditionsEnabled:]):
2104         * WebView/WebPreferencesPrivate.h:
2105         * WebView/WebView.mm:
2106         (-[WebView _preferencesChanged:]):
2107         Add plumbing for new InspectorAdditions runtime flag.
2108
2109 2017-08-07  Brian Burg  <bburg@apple.com>
2110
2111         Remove CANVAS_PATH compilation guard
2112         https://bugs.webkit.org/show_bug.cgi?id=175207
2113
2114         Reviewed by Sam Weinig.
2115
2116         * Configurations/FeatureDefines.xcconfig:
2117
2118 2017-08-04  Youenn Fablet  <youenn@apple.com>
2119
2120         [Cache API] Add Cache and CacheStorage IDL definitions
2121         https://bugs.webkit.org/show_bug.cgi?id=175201
2122
2123         Reviewed by Brady Eidson.
2124
2125         * WebView/WebPreferenceKeysPrivate.h:
2126         * WebView/WebPreferences.mm:
2127         (+[WebPreferences initialize]):
2128         (-[WebPreferences cacheAPIEnabled]):
2129         (-[WebPreferences setCacheAPIEnabled:]):
2130         * WebView/WebPreferencesPrivate.h:
2131         * WebView/WebView.mm:
2132         (-[WebView _preferencesChanged:]):
2133
2134 2017-08-04  Matt Lewis  <jlewis3@apple.com>
2135
2136         Unreviewed, rolling out r220271.
2137
2138         Rolling out due to Layout Test failing on iOS Simulator.
2139
2140         Reverted changeset:
2141
2142         "Remove STREAMS_API compilation guard"
2143         https://bugs.webkit.org/show_bug.cgi?id=175165
2144         http://trac.webkit.org/changeset/220271
2145
2146 2017-08-04  Youenn Fablet  <youenn@apple.com>
2147
2148         Remove STREAMS_API compilation guard
2149         https://bugs.webkit.org/show_bug.cgi?id=175165
2150
2151         Reviewed by Darin Adler.
2152
2153         * Configurations/FeatureDefines.xcconfig:
2154         * WebView/WebPreferences.mm:
2155         (+[WebPreferences initialize]):
2156         * WebView/WebView.mm:
2157         (-[WebView _preferencesChanged:]):
2158
2159 2017-08-03  Brian Burg  <bburg@apple.com>
2160
2161         Remove ENABLE(WEB_SOCKET) guards
2162         https://bugs.webkit.org/show_bug.cgi?id=167044
2163
2164         Reviewed by Joseph Pecoraro.
2165
2166         * Configurations/FeatureDefines.xcconfig:
2167         * WebView/WebPreferencesPrivate.h:
2168
2169 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
2170
2171         [PAL] Move spi/cf directory into PAL
2172         https://bugs.webkit.org/show_bug.cgi?id=175057
2173
2174         Reviewed by Antti Koivisto.
2175
2176         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2177         * Plugins/WebNetscapePluginStream.mm:
2178         * WebCoreSupport/WebFrameNetworkingContext.mm:
2179         * WebView/WebPreferences.mm:
2180         * WebView/WebView.mm:
2181
2182 2017-08-03  Youenn Fablet  <youenn@apple.com>
2183
2184         Remove FETCH_API compilation guard
2185         https://bugs.webkit.org/show_bug.cgi?id=175154
2186
2187         Reviewed by Chris Dumez.
2188
2189         * Configurations/FeatureDefines.xcconfig:
2190         * WebView/WebPreferences.mm:
2191         (+[WebPreferences initialize]):
2192         * WebView/WebView.mm:
2193         (-[WebView _preferencesChanged:]):
2194
2195 2017-08-03  Brady Eidson  <beidson@apple.com>
2196
2197         Add SW IDLs and stub out basic functionality.
2198         https://bugs.webkit.org/show_bug.cgi?id=175115
2199
2200         Reviewed by Chris Dumez.
2201
2202         * Configurations/FeatureDefines.xcconfig:
2203
2204 2017-08-02  Sam Weinig  <sam@webkit.org>
2205
2206         [WebIDL] Convert MutationCallback to be a normal generated callback
2207         https://bugs.webkit.org/show_bug.cgi?id=174140
2208
2209         Reviewed by Darin Adler.
2210
2211         * DOM/DOMDocument.mm:
2212         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
2213         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
2214         Pass, now necessary, Document to NativeNodeFilter constructor.
2215
2216 2017-08-01  Chris Dumez  <cdumez@apple.com>
2217
2218         Add initial support for navigator.sendBeacon
2219         https://bugs.webkit.org/show_bug.cgi?id=175007
2220         <rdar://problem/33547728>
2221
2222         Reviewed by Sam Weinig.
2223
2224         Add setting to toggle support for the Beacon API (it is disabled by default).
2225
2226         * WebView/WebPreferenceKeysPrivate.h:
2227         * WebView/WebPreferences.mm:
2228         (+[WebPreferences initialize]):
2229         (-[WebPreferences beaconAPIEnabled]):
2230         (-[WebPreferences setBeaconAPIEnabled:]):
2231         * WebView/WebPreferencesPrivate.h:
2232         * WebView/WebView.mm:
2233         (-[WebView _preferencesChanged:]):
2234
2235 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
2236
2237         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
2238         https://bugs.webkit.org/show_bug.cgi?id=174437
2239
2240         Reviewed by Darin Adler.
2241
2242         Remove redundant Web- prefix from classes in WebKit namespace.
2243
2244         * WebView/WebView.mm:
2245         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
2246         * WebView/WebViewData.h:
2247         * WebView/WebViewData.mm:
2248
2249 2017-07-26  Brian Burg  <bburg@apple.com>
2250
2251         Remove WEB_TIMING feature flag
2252         https://bugs.webkit.org/show_bug.cgi?id=174795
2253
2254         Reviewed by Alex Christensen.
2255
2256         * Configurations/FeatureDefines.xcconfig:
2257
2258 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
2259
2260         Async image decoding for large images should be disabled after the first time a tile is painted
2261         https://bugs.webkit.org/show_bug.cgi?id=174451
2262         <rdar://problem/31246421>
2263
2264         Reviewed by Simon Fraser.
2265
2266         * WebView/WebFrame.mm:
2267         (-[WebFrame _paintBehaviorForDestinationContext:]):
2268         (-[WebFrame _drawRect:contentsOnly:]):
2269         * WebView/WebHTMLView.mm:
2270         (imageFromRect):
2271
2272 2017-07-23  Darin Adler  <darin@apple.com>
2273
2274         More NeverDestroyed and related cleanup
2275         https://bugs.webkit.org/show_bug.cgi?id=174745
2276
2277         Reviewed by Alex Christensen.
2278
2279         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
2280         for names that aren't even used in this file.
2281         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
2282         -[NSArray arrayWithObject:].
2283         (-[DOMNode absoluteQuads]): Ditto.
2284         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
2285         of writing out various types.
2286         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
2287         syntax instea of -[NSArray arrayWithObject:].
2288         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
2289         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
2290         of writing out various types.
2291         (-[DOMHTMLImageElement mimeType]): Ditto.
2292
2293 2017-07-24  Chris Dumez  <cdumez@apple.com>
2294
2295         ExceptionCode enumeration should use modern exception names
2296         https://bugs.webkit.org/show_bug.cgi?id=174794
2297
2298         Reviewed by Geoffrey Garen.
2299
2300         * DOM/ExceptionHandlers.mm:
2301         (raiseNotSupportedErrorException):
2302
2303 2017-07-23  Chris Dumez  <cdumez@apple.com>
2304
2305         Drop ExceptionCodeDescription class
2306         https://bugs.webkit.org/show_bug.cgi?id=174757
2307
2308         Reviewed by Darin Adler.
2309
2310         Stop using ExceptionCodeDescription.
2311
2312         * DOM/ExceptionHandlers.mm:
2313         (raiseDOMErrorException):
2314
2315 2017-07-21  Andreas Kling  <akling@apple.com>
2316
2317         Use more references in event dispatch code
2318         https://bugs.webkit.org/show_bug.cgi?id=174681
2319
2320         Reviewed by Geoffrey Garen.
2321
2322         * DOM/ObjCEventListener.h:
2323         * DOM/ObjCEventListener.mm:
2324         (WebCore::ObjCEventListener::handleEvent):
2325         * WebCoreSupport/WebFrameLoaderClient.mm:
2326         (NetscapePluginWidget::handleEvent):
2327
2328 2017-07-21  Brady Eidson  <beidson@apple.com>
2329
2330         Get rid of WebCore IconDatabase code.
2331         https://bugs.webkit.org/show_bug.cgi?id=174700
2332
2333         Reviewed by Tim Horton.
2334
2335         * Misc/WebCoreStatistics.mm:
2336         (+[WebCoreStatistics iconPageURLMappingCount]):
2337         (+[WebCoreStatistics iconRetainedPageURLCount]):
2338         (+[WebCoreStatistics iconRecordCount]):
2339         (+[WebCoreStatistics iconsWithDataCount]):
2340         * WebCoreSupport/WebFrameLoaderClient.h:
2341         * WebCoreSupport/WebFrameLoaderClient.mm:
2342         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
2343         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
2344         * WebView/WebView.mm:
2345         (-[WebView mainFrameIconURL]):
2346
2347 2017-07-20  Chris Dumez  <cdumez@apple.com>
2348
2349         Drop legacy XPathException type
2350         https://bugs.webkit.org/show_bug.cgi?id=174679
2351
2352         Reviewed by Sam Weinig.
2353
2354         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
2355         no longer expose XPathException.
2356
2357         * DOM/ExceptionHandlers.mm:
2358         (raiseDOMErrorException):
2359
2360 2017-07-20  Chris Dumez  <cdumez@apple.com>
2361
2362         Unreviewed, rolling out r219706.
2363
2364         Broke iOS build
2365
2366         Reverted changeset:
2367
2368         "Drop legacy XPathException type"
2369         https://bugs.webkit.org/show_bug.cgi?id=174679
2370         http://trac.webkit.org/changeset/219706
2371
2372 2017-07-20  Chris Dumez  <cdumez@apple.com>
2373
2374         Drop legacy XPathException type
2375         https://bugs.webkit.org/show_bug.cgi?id=174679
2376
2377         Reviewed by Sam Weinig.
2378
2379         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
2380         no longer expose XPathException.
2381
2382         * DOM/ExceptionHandlers.mm:
2383         (raiseDOMErrorException):
2384         * WebKit.exp:
2385
2386 2017-07-20  Chris Dumez  <cdumez@apple.com>
2387
2388         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
2389         https://bugs.webkit.org/show_bug.cgi?id=174660
2390
2391         Reviewed by Geoffrey Garen.
2392
2393         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
2394         This essentially replaces a branch to figure out if the new size is less or greater than the
2395         current size by an assertion.
2396
2397         * Plugins/WebNetscapePluginView.mm:
2398         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2399
2400 2017-07-20  Brady Eidson  <beidson@apple.com>
2401
2402         Deprecate WebIconDatabase in WebKitLegacy/mac.
2403         https://bugs.webkit.org/show_bug.cgi?id=174607
2404
2405         Reviewed by Alex Christensen.
2406
2407         This patch:
2408         1 - Formally deprecates WebIconDatabase (which was never API anyways)
2409         2 - Guts the class to where it can only return the default icon at the small size
2410         3 - Reworks other parts of WebKitLegacy that used it for anything to either
2411             use something else or to not do anything.
2412         
2413         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
2414         and that patch will remove all of the last remnants of WebIconDatabase.
2415         
2416         * History/WebHistoryItem.mm:
2417         (-[WebHistoryItem icon]):
2418
2419         * Misc/WebIconDatabase.h:
2420         * Misc/WebIconDatabase.mm:
2421         (-[WebIconDatabase init]):
2422         (-[WebIconDatabase iconForURL:withSize:cache:]):
2423         (-[WebIconDatabase iconForURL:withSize:]):
2424         (-[WebIconDatabase defaultIconWithSize:]):
2425         (-[WebIconDatabase defaultIconForURL:withSize:]):
2426         (-[WebIconDatabase iconURLForURL:]):
2427         (-[WebIconDatabase retainIconForURL:]):
2428         (-[WebIconDatabase releaseIconForURL:]):
2429         (+[WebIconDatabase delayDatabaseCleanup]):
2430         (+[WebIconDatabase allowDatabaseCleanup]):
2431         (-[WebIconDatabase setDelegate:]):
2432         (-[WebIconDatabase delegate]):
2433         (+[WebIconDatabase initialize]): Deleted.
2434         (-[WebIconDatabase isEnabled]): Deleted.
2435         (-[WebIconDatabase setEnabled:]): Deleted.
2436         (-[WebIconDatabase removeAllIcons]): Deleted.
2437         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
2438         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
2439         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
2440         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
2441         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
2442         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
2443         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
2444         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
2445         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
2446         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
2447         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
2448         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
2449         (-[WebIconDatabase _databaseDirectory]): Deleted.
2450         (webGetNSImage): Deleted.
2451
2452         * Misc/WebIconDatabaseDelegate.h: Removed.
2453         * Misc/WebIconDatabaseInternal.h: Removed.
2454         * Misc/WebIconDatabasePrivate.h: Removed.
2455
2456         * WebCoreSupport/WebFrameLoaderClient.mm:
2457         (webGetNSImage):
2458
2459         * WebCoreSupport/WebIconDatabaseClient.mm:
2460         (WebIconDatabaseClient::didRemoveAllIcons):
2461         (WebIconDatabaseClient::didImportIconURLForPageURL):
2462
2463         * WebView/WebView.mm:
2464         (-[WebView setFrameLoadDelegate:]):
2465         (-[WebView mainFrameIcon]):
2466
2467 2017-07-18  Andy Estes  <aestes@apple.com>
2468
2469         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
2470         https://bugs.webkit.org/show_bug.cgi?id=174631
2471
2472         Reviewed by Tim Horton.
2473
2474         * Configurations/Base.xcconfig:
2475
2476 2017-07-18  Andy Estes  <aestes@apple.com>
2477
2478         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
2479         https://bugs.webkit.org/show_bug.cgi?id=174631
2480
2481         Reviewed by Sam Weinig.
2482
2483         * Configurations/Base.xcconfig:
2484
2485 2017-07-18  Andy Estes  <aestes@apple.com>
2486
2487         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
2488         https://bugs.webkit.org/show_bug.cgi?id=174631
2489
2490         Reviewed by Dan Bernstein.
2491
2492         * Configurations/Base.xcconfig:
2493
2494 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2495
2496         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
2497         https://bugs.webkit.org/show_bug.cgi?id=174640
2498         <rdar://problem/33297400>
2499
2500         Reviewed by Tim Horton.
2501
2502         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
2503         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
2504         web thread here, to match the other WebView drag and drop SPI methods.
2505
2506         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
2507         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
2508         should make this robust against future UIKit changes that could make this no longer the case.
2509
2510         * WebView/WebView.mm:
2511         (-[WebView _requestStartDataInteraction:globalPosition:]):
2512         (-[WebView _dataInteractionCaretRect]):
2513
2514 2017-07-18  Andy Estes  <aestes@apple.com>
2515
2516         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
2517         https://bugs.webkit.org/show_bug.cgi?id=174631
2518
2519         Reviewed by Darin Adler.
2520
2521         * Configurations/Base.xcconfig:
2522
2523 2017-07-17  Sam Weinig  <sam@webkit.org>
2524
2525         [WebIDL] Remove custom bindings that require non-caching JS strings
2526         https://bugs.webkit.org/show_bug.cgi?id=174552
2527
2528         Reviewed by Darin Adler.
2529
2530         * DOM/DOMHTMLCanvasElement.mm:
2531         (-[DOMHTMLCanvasElement toDataURL:]):
2532         Update to account for implementation now returning an UncachedString.
2533
2534 2017-07-17  Darin Adler  <darin@apple.com>
2535
2536         Improve use of NeverDestroyed
2537         https://bugs.webkit.org/show_bug.cgi?id=174348
2538
2539         Reviewed by Sam Weinig.
2540
2541         * Misc/WebStringTruncator.mm:
2542         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
2543         NeverDestroyed<RetainPtr> with just an NSFont * global.
2544
2545         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
2546         NeverDestroyed.h.
2547         * Storage/WebDatabaseManager.mm: Ditto.
2548         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
2549         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
2550
2551         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
2552         (aeDescFromJSValue): Removed double hashing by using the return value from
2553         add rather than calling contains before calling add.
2554
2555 2017-07-14  Jer Noble  <jer.noble@apple.com>
2556
2557         Allow clients to override their own hardware media requirements where no fallback media exists.
2558         https://bugs.webkit.org/show_bug.cgi?id=174426
2559         <rdar://problem/32537704>
2560
2561         Reviewed by Eric Carlson.
2562
2563         Add a new WebPreferences property to control WebCore's new
2564         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
2565
2566         * WebView/WebPreferenceKeysPrivate.h:
2567         * WebView/WebPreferences.mm:
2568         (+[WebPreferences initialize]):
2569         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
2570         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
2571         * WebView/WebPreferencesPrivate.h:
2572         * WebView/WebView.mm:
2573         (-[WebView _preferencesChanged:]):
2574
2575 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
2576
2577         Async image decoding for large images should be disabled by default
2578         https://bugs.webkit.org/show_bug.cgi?id=174432
2579
2580         Reviewed by Simon Fraser.
2581
2582         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
2583         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
2584         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
2585            a child view instead of propagating PaintBehaviorSnapshotting.
2586         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
2587            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
2588
2589         * WebView/WebFrame.mm:
2590         (-[WebFrame _paintBehaviorForDestinationContext:]):
2591         (-[WebFrame _drawRect:contentsOnly:]):
2592         * WebView/WebHTMLView.mm:
2593         (imageFromRect):
2594
2595 2017-07-12  Daniel Bates  <dabates@apple.com>
2596
2597         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
2598         https://bugs.webkit.org/show_bug.cgi?id=174427
2599
2600         Rubber-stamped by Brady Eidson.
2601
2602         * WebView/WebPDFView.mm:
2603         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2604
2605 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2606
2607         Unreviewed, rolling out r219401.
2608
2609         This revision rolled out the previous patch, but after talking
2610         with reviewer, a rebaseline is what was needed.Rolling back in
2611         before rebaseline.
2612
2613         Reverted changeset:
2614
2615         "Unreviewed, rolling out r219379."
2616         https://bugs.webkit.org/show_bug.cgi?id=174400
2617         http://trac.webkit.org/changeset/219401
2618
2619 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2620
2621         Unreviewed, rolling out r219379.
2622
2623         This revision caused a consistent failure in the test
2624         fast/dom/Window/property-access-on-cached-window-after-frame-
2625         removed.html.
2626
2627         Reverted changeset:
2628
2629         "Remove NAVIGATOR_HWCONCURRENCY"
2630         https://bugs.webkit.org/show_bug.cgi?id=174400
2631         http://trac.webkit.org/changeset/219379
2632
2633 2017-07-11  Dean Jackson  <dino@apple.com>
2634
2635         Remove NAVIGATOR_HWCONCURRENCY
2636         https://bugs.webkit.org/show_bug.cgi?id=174400
2637
2638         * Configurations/FeatureDefines.xcconfig:
2639
2640 2017-07-11  Dean Jackson  <dino@apple.com>
2641
2642         Rolling out r219372.
2643
2644         * Configurations/FeatureDefines.xcconfig:
2645
2646 2017-07-11  Dean Jackson  <dino@apple.com>
2647
2648         Remove NAVIGATOR_HWCONCURRENCY
2649         https://bugs.webkit.org/show_bug.cgi?id=174400
2650
2651         * Configurations/FeatureDefines.xcconfig:
2652
2653 2017-07-03  Brian Burg  <bburg@apple.com>
2654
2655         Web Replay: remove some unused code
2656         https://bugs.webkit.org/show_bug.cgi?id=173903
2657
2658         Rubber-stamped by Joseph Pecoraro.
2659
2660         * Configurations/FeatureDefines.xcconfig:
2661
2662 2017-07-09  Brady Eidson  <beidson@apple.com>
2663
2664         Remove some obsolete WebKitVersionChecks.
2665         https://bugs.webkit.org/show_bug.cgi?id=174294
2666
2667         Reviewed by Dan Bernstein.
2668
2669         * Misc/WebKitVersionChecks.h:
2670
2671         * WebView/WebHTMLView.mm:
2672         (-[WebHTMLView hitTest:]):
2673
2674         * WebView/WebView.mm:
2675         (shouldRespectPriorityInCSSAttributeSetters):
2676         (-[WebView _commonInitializationWithFrameName:groupName:]):
2677         (-[WebView _preferencesChanged:]):
2678         (shouldTransformsAffectOverflow): Deleted.
2679         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
2680
2681 2017-07-08  Brady Eidson  <beidson@apple.com>
2682
2683         Remove some obsolete RuntimeApplicationChecks.
2684         https://bugs.webkit.org/show_bug.cgi?id=174293
2685
2686         Reviewed by Dan Bernstein.
2687
2688         * Misc/WebKitVersionChecks.h:
2689         * WebView/WebView.mm:
2690         (+[WebView enableWebThread]):
2691         (-[WebView _needsPreHTML5ParserQuirks]):
2692
2693 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2694
2695         Drop NOSNIFF compile flag
2696         https://bugs.webkit.org/show_bug.cgi?id=174289
2697
2698         Reviewed by Michael Catanzaro.
2699
2700         * Configurations/FeatureDefines.xcconfig:
2701
2702 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2703
2704         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2705         https://bugs.webkit.org/show_bug.cgi?id=174150
2706
2707         Reviewed by Mark Lam.
2708
2709         * DOM/DOM.mm:
2710         (lookupElementClass):
2711
2712 2017-07-06  Brady Eidson  <beidson@apple.com>
2713
2714         Add logging to first attempt to use the WebIconDatabase class.
2715         https://bugs.webkit.org/show_bug.cgi?id=174190
2716
2717         Reviewed by Andy Estes.
2718
2719         * Misc/WebIconDatabase.mm:
2720         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
2721         * Misc/WebKitVersionChecks.h:
2722
2723 2017-07-06  Matt Lewis  <jlewis3@apple.com>
2724
2725         Unreviewed, rolling out r219178.
2726
2727         This caused a consistent failure with the API test
2728         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
2729
2730         Reverted changeset:
2731
2732         "[WTF] Clean up StringStatics.cpp by using
2733         LazyNeverDestroyed<> for Atoms"
2734         https://bugs.webkit.org/show_bug.cgi?id=174150
2735         http://trac.webkit.org/changeset/219178
2736
2737 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
2738
2739         [WTF] Move SoftLinking.h into WTF
2740         https://bugs.webkit.org/show_bug.cgi?id=174000
2741
2742         Reviewed by Alex Christensen.
2743
2744         * Plugins/WebNetscapePluginView.mm:
2745         * Plugins/WebPluginController.mm:
2746         * WebCoreSupport/WebInspectorClient.mm:
2747         * WebView/WebFullScreenController.mm:
2748         * WebView/WebImmediateActionController.mm:
2749         * WebView/WebView.mm:
2750
2751 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2752
2753         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2754         https://bugs.webkit.org/show_bug.cgi?id=174150
2755
2756         Reviewed by Mark Lam.
2757
2758         * DOM/DOM.mm:
2759         (lookupElementClass):
2760
2761 2017-07-05  Brady Eidson  <beidson@apple.com>
2762
2763         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
2764         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
2765
2766         Reviewed by Alex Christensen.
2767
2768         Adopt to the new constructor for FrameLoadRequest.
2769
2770         * WebView/WebPDFView.mm:
2771         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2772
2773 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
2774
2775         Make WebKit's public headers on Mac and iOS C++ module safe
2776         https://bugs.webkit.org/show_bug.cgi?id=174175
2777
2778         Reviewed by Alex Christensen.
2779
2780         Fixed the header files.
2781
2782         * Misc/WebDownload.h:
2783         * Misc/WebKitErrors.h:
2784         * Plugins/WebPluginContainer.h:
2785         * WebView/WebResourceLoadDelegate.h:
2786
2787 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2788
2789         Remove copy of ICU headers from WebKit
2790         https://bugs.webkit.org/show_bug.cgi?id=116407
2791
2792         Reviewed by Alex Christensen.
2793
2794         Use WTF's copy of ICU headers.
2795
2796         * Configurations/WebKitLegacy.xcconfig:
2797         * icu/unicode/localpointer.h: Removed.
2798         * icu/unicode/parseerr.h: Removed.
2799         * icu/unicode/platform.h: Removed.
2800         * icu/unicode/ptypes.h: Removed.
2801         * icu/unicode/putil.h: Removed.
2802         * icu/unicode/uchar.h: Removed.
2803         * icu/unicode/uconfig.h: Removed.
2804         * icu/unicode/ucurr.h: Removed.
2805         * icu/unicode/uidna.h: Removed.
2806         * icu/unicode/uiter.h: Removed.
2807         * icu/unicode/umachine.h: Removed.
2808         * icu/unicode/unorm.h: Removed.
2809         * icu/unicode/unorm2.h: Removed.
2810         * icu/unicode/urename.h: Removed.
2811         * icu/unicode/uscript.h: Removed.
2812         * icu/unicode/ustring.h: Removed.
2813         * icu/unicode/utf.h: Removed.
2814         * icu/unicode/utf16.h: Removed.
2815         * icu/unicode/utf8.h: Removed.
2816         * icu/unicode/utf_old.h: Removed.
2817         * icu/unicode/utypes.h: Removed.
2818         * icu/unicode/uvernum.h: Removed.
2819         * icu/unicode/uversion.h: Removed.
2820
2821 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
2822
2823         Add WebKitPrivateFrameworkStubs for iOS 11
2824         https://bugs.webkit.org/show_bug.cgi?id=173988
2825
2826         Reviewed by David Kilzer.
2827
2828         * Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
2829         use the same directory for private framework stubs.
2830
2831 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2832
2833         Unreviewed, rolling out r219103.
2834
2835         Caused multiple build failures.
2836
2837         Reverted changeset:
2838
2839         "Remove copy of ICU headers from WebKit"
2840         https://bugs.webkit.org/show_bug.cgi?id=116407
2841         http://trac.webkit.org/changeset/219103
2842
2843 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2844
2845         Remove copy of ICU headers from WebKit
2846         https://bugs.webkit.org/show_bug.cgi?id=116407
2847
2848         Reviewed by Alex Christensen.
2849
2850         Use WTF's copy of ICU headers.
2851
2852         * Configurations/WebKitLegacy.xcconfig:
2853         * icu/unicode/localpointer.h: Removed.
2854         * icu/unicode/parseerr.h: Removed.
2855         * icu/unicode/platform.h: Removed.
2856         * icu/unicode/ptypes.h: Removed.
2857         * icu/unicode/putil.h: Removed.
2858         * icu/unicode/uchar.h: Removed.
2859         * icu/unicode/uconfig.h: Removed.
2860         * icu/unicode/ucurr.h: Removed.
2861         * icu/unicode/uidna.h: Removed.
2862         * icu/unicode/uiter.h: Removed.
2863         * icu/unicode/umachine.h: Removed.
2864         * icu/unicode/unorm.h: Removed.
2865         * icu/unicode/unorm2.h: Removed.
2866         * icu/unicode/urename.h: Removed.
2867         * icu/unicode/uscript.h: Removed.
2868         * icu/unicode/ustring.h: Removed.
2869         * icu/unicode/utf.h: Removed.
2870         * icu/unicode/utf16.h: Removed.
2871         * icu/unicode/utf8.h: Removed.
2872         * icu/unicode/utf_old.h: Removed.
2873         * icu/unicode/utypes.h: Removed.
2874         * icu/unicode/uvernum.h: Removed.
2875         * icu/unicode/uversion.h: Removed.
2876
2877 2017-07-03  Brady Eidson  <beidson@apple.com>
2878
2879         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
2880         https://bugs.webkit.org/show_bug.cgi?id=174073
2881
2882         Reviewed by Andy Estes.
2883
2884         WebView now keeps a direct copy of its main frame icon as a member variable.
2885         It populates that variable by finding exactly one Favicon LinkIcon from WebCore and loading it.
2886         
2887         This change causes a progression in KVO observation of the mainFrameIcon property as we now
2888         have both the old icon and new icon at the time it changes.
2889
2890         * WebCoreSupport/WebFrameLoaderClient.h:
2891         * WebCoreSupport/WebFrameLoaderClient.mm:
2892         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2893         (WebFrameLoaderClient::getLoadDecisionForIcons):
2894         (WebFrameLoaderClient::finishedLoadingIcon):
2895         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
2896         (WebFrameLoaderClient::registerForIconNotification): Deleted.
2897
2898         * WebView/WebView.mm:
2899         (+[WebView _setIconLoadingEnabled:]):
2900         (+[WebView _isIconLoadingEnabled]):
2901         (-[WebView mainFrameIcon]):
2902         (-[WebView _setMainFrameIcon:]):
2903         (-[WebView _receivedIconChangedNotification:]): Deleted.
2904         (-[WebView _registerForIconNotification:]): Deleted.
2905         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Deleted.
2906         * WebView/WebViewData.h:
2907         * WebView/WebViewInternal.h:
2908         * WebView/WebViewPrivate.h:
2909
2910 2017-07-03  Sam Weinig  <sam@webkit.org>
2911
2912         [WebIDL] Remove more unnecessary uses of the preprocessor in idl files
2913         https://bugs.webkit.org/show_bug.cgi?id=174083
2914
2915         Reviewed by Alex Christensen.
2916
2917         * Configurations/FeatureDefines.xcconfig:
2918         Add ENABLE_NAVIGATOR_STANDALONE.
2919
2920 2017-07-03  Tim Horton  <timothy_horton@apple.com>
2921
2922         Expose unobscuredSafeAreaInsets on WebView
2923         https://bugs.webkit.org/show_bug.cgi?id=174075
2924         <rdar://problem/33096997>
2925
2926         Reviewed by Beth Dakin.
2927
2928         * WebView/WebView.mm:
2929         (-[WebView _setUnobscuredSafeAreaInsets:]):
2930         (-[WebView _unobscuredSafeAreaInsets]):
2931         * WebView/WebViewPrivate.h:
2932         Expose unobscuredSafeAreaInsets as a new private property on WebView,
2933         similar to how it is exposed in WebKit2.
2934
2935 2017-07-03  Andy Estes  <aestes@apple.com>
2936
2937         [Xcode] Add an experimental setting to build with ccache
2938         https://bugs.webkit.org/show_bug.cgi?id=173875
2939
2940         Reviewed by Tim Horton.
2941
2942         * Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
2943
2944 2017-07-03  Tim Horton  <timothy_horton@apple.com>
2945
2946         Expose WebPreferences for viewport-fit and constant() properties
2947         https://bugs.webkit.org/show_bug.cgi?id=174072
2948         <rdar://problem/33096639>
2949
2950         Reviewed by Ryosuke Niwa.
2951
2952         * WebView/WebPreferenceKeysPrivate.h:
2953         * WebView/WebPreferences.mm:
2954         (-[WebPreferences viewportFitEnabled]):
2955         (-[WebPreferences setViewportFitEnabled:]):
2956         (-[WebPreferences constantPropertiesEnabled]):
2957         (-[WebPreferences setConstantPropertiesEnabled:]):
2958         * WebView/WebPreferencesPrivate.h:
2959         * WebView/WebView.mm:
2960         (-[WebView _preferencesChanged:]):
2961
2962 2017-07-01  Tim Horton  <timothy_horton@apple.com>
2963
2964         Expose viewport-fit value to UIKit via viewport arguments dictionary
2965         https://bugs.webkit.org/show_bug.cgi?id=174071
2966         <rdar://problem/33096620>
2967
2968         Reviewed by Wenson Hsieh.
2969
2970         * History/WebHistoryItem.mm:
2971         * History/WebHistoryItemPrivate.h:
2972         Add another dictionary key and three values.
2973
2974 2017-07-01  Dan Bernstein  <mitz@apple.com>
2975
2976         [iOS] Remove code only needed when building for iOS 9.x
2977         https://bugs.webkit.org/show_bug.cgi?id=174068
2978
2979         Reviewed by Tim Horton.
2980
2981         * Configurations/FeatureDefines.xcconfig:
2982
2983 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
2984
2985         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
2986         https://bugs.webkit.org/show_bug.cgi?id=174004
2987
2988         Reviewed by Simon Fraser.
2989
2990         * WebCoreSupport/WebPluginInfoProvider.mm:
2991
2992 2017-07-01  Dan Bernstein  <mitz@apple.com>
2993
2994         [macOS] Remove code only needed when building for OS X Yosemite
2995         https://bugs.webkit.org/show_bug.cgi?id=174067
2996
2997         Reviewed by Tim Horton.
2998
2999         * Configurations/Base.xcconfig:
3000         * Configurations/DebugRelease.xcconfig:
3001         * Configurations/FeatureDefines.xcconfig:
3002         * Configurations/Version.xcconfig:
3003         * Plugins/WebBasePluginPackage.mm:
3004         (-[WebBasePluginPackage getPluginInfoFromPLists]):
3005         * WebCoreSupport/PopupMenuMac.mm:
3006         (PopupMenuMac::show):
3007         * WebCoreSupport/WebInspectorClient.mm:
3008         (WebInspectorFrontendClient::startWindowDrag):
3009         (-[WebInspectorWindowController window]):
3010         * WebView/WebView.mm:
3011         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
3012
3013 2017-06-30  Daniel Bates  <dabates@apple.com>
3014
3015         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3016         https://bugs.webkit.org/show_bug.cgi?id=165160
3017         <rdar://problem/29451999>
3018
3019         Reviewed by Brady Eidson.
3020
3021         Pass the document that is requesting the load to the loader.
3022
3023         * WebView/WebPDFView.mm:
3024         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3025
3026 2017-06-29  Jer Noble  <jer.noble@apple.com>
3027
3028         Make Legacy EME API controlled by RuntimeEnabled setting.
3029         https://bugs.webkit.org/show_bug.cgi?id=173994
3030
3031         Reviewed by Sam Weinig.
3032
3033         Add a new preference used to control WebCore's new RuntimeEnabledFeature setting.
3034
3035         * Configurations/FeatureDefines.xcconfig:
3036         * WebView/WebPreferenceKeysPrivate.h:
3037         * WebView/WebPreferences.mm:
3038         (+[WebPreferences initialize]):
3039         (-[WebPreferences legacyEncryptedMediaAPIEnabled]):
3040         (-[WebPreferences setLegacyEncryptedMediaAPIEnabled:]):
3041         * WebView/WebPreferencesPrivate.h:
3042         * WebView/WebView.mm:
3043         (-[WebView _preferencesChanged:]):
3044
3045 2017-06-30  Chris Dumez  <cdumez@apple.com>
3046
3047         ResourceLoadObserver does not need a ResourceLoadStatisticsStore
3048         https://bugs.webkit.org/show_bug.cgi?id=174013
3049
3050         Reviewed by Brent Fulgham.
3051
3052         ResourceLoadObserver does not need a ResourceLoadStatisticsStore. ResourceLoadStatisticsStore is too complicated for its needs.
3053         ResourceLoadStatisticsStore can then be moved to WebKit2/UIProcess in a follow-up.
3054
3055         * WebView/WebView.mm:
3056         (-[WebView _commonInitializationWithFrameName:groupName:]):
3057
3058 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3059
3060         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
3061         https://bugs.webkit.org/show_bug.cgi?id=174017
3062         <rdar://problem/32959782>
3063
3064         Reviewed by Simon Fraser.
3065
3066         Use root view coordinates when computing the drag caret rect.
3067
3068         * WebView/WebView.mm:
3069         (-[WebView _dataInteractionCaretRect]):
3070
3071 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
3072
3073         Mark the GraphicsContext as accelerated when the WebHTMLView's layer is drawing asynchronously
3074         https://bugs.webkit.org/show_bug.cgi?id=173899
3075         rdar://problem/32994474
3076
3077         Reviewed by Tim Horton.
3078
3079         When the WebHTMLView is layer-backed, and -drawsAsynchronously on its layer is YES,
3080         then mark the GraphicsContext that WebCore is using for drawing as accelerated, so
3081         that ImageBuffer::createCompatibleBuffer() creates appropriately matched buffers.
3082
3083         Also clean up WebFrame a little, sharing code that checks whether the WebFrame's
3084         documentView is a WebHTMLView.
3085
3086         * WebView/WebFrame.mm:
3087         (-[WebFrame _webHTMLDocumentView]):
3088         (-[WebFrame _paintBehaviorForDestinationContext:]):
3089         (-[WebFrame _drawRect:contentsOnly:]):
3090         (-[WebFrame setTimeoutsPaused:]):
3091         (-[WebFrame prepareForPause]):
3092         (-[WebFrame resumeFromPause]):
3093         (-[WebFrame resetTextAutosizingBeforeLayout]):
3094         * WebView/WebHTMLView.mm:
3095         (-[WebHTMLView drawLayer:inContext:]):
3096         (-[WebHTMLView _web_isDrawingIntoAcceleratedLayer]):
3097         * WebView/WebHTMLViewInternal.h:
3098
3099 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3100
3101         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
3102         https://bugs.webkit.org/show_bug.cgi?id=173854
3103         <rdar://problem/32236827>
3104
3105         Reviewed by Ryosuke Niwa and Tim Horton.
3106
3107         Vends some information from the DragItem passed into -[WebView _startDrag:] through the WebView as SPI for
3108         WebKit1 clients. No behavior change with these changes alone -- see <rdar://problem/32991062> for more detail.
3109
3110         * WebView/WebView.mm:
3111         (-[WebView _startDrag:]):
3112         (-[WebView _dragSourceAction]):
3113         (-[WebView _draggedLinkTitle]):
3114         (-[WebView _draggedLinkURL]):
3115         (-[WebView _draggedElementBounds]):
3116         (-[WebView _endedDataInteraction:global:]):
3117         * WebView/WebViewData.h:
3118         * WebView/WebViewPrivate.h:
3119
3120 2017-06-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3121
3122         Refactor drag start codepaths to plumb a DragItem to client layers
3123         https://bugs.webkit.org/show_bug.cgi?id=173832
3124         Work towards <rdar://problem/32236827>
3125
3126         Reviewed by Ryosuke Niwa and Tim Horton.
3127
3128         Refactor code used to start a drag in WebKit1 to plumb a single DragItem from DragController to the client layer
3129         in WebDragClient that contains all the information needed to begin a drag. Also renames _setDataInteractionData:
3130         to _startDrag: to match logic used to start a drag on other platforms.
3131
3132         No behavior change -- the same information should be propagated to AppKit and UIKit when beginning a drag, only
3133         through the DragItem struct.
3134
3135         * WebCoreSupport/WebDragClient.h:
3136         * WebCoreSupport/WebDragClient.mm:
3137         (WebDragClient::startDrag):
3138         (WebDragClient::dragSourceActionMaskForPoint):
3139         (WebDragClient::willPerformDragSourceAction):
3140         (WebDragClient::beginDrag):
3141         * WebView/WebView.mm:
3142         (-[WebView _startDrag:]):
3143         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]): Deleted.
3144         * WebView/WebViewInternal.h:
3145
3146 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
3147
3148         Remove excessive headers from JavaScriptCore
3149         https://bugs.webkit.org/show_bug.cgi?id=173812
3150
3151         Reviewed by Darin Adler.
3152
3153         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3154         * WebView/WebView.mm:
3155
3156 2017-06-23  Tim Horton  <timothy_horton@apple.com>
3157
3158         Remove an unused typedef from WebFrameLoaderClient
3159         https://bugs.webkit.org/show_bug.cgi?id=173795
3160
3161         Reviewed by Simon Fraser.
3162
3163         * WebCoreSupport/WebFrameLoaderClient.h:
3164         This unused typedef in the global namespace conflicts with one in a macOS system header.
3165         Also... it's unused.
3166         Remove it.
3167
3168 2017-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3169
3170         Remove excessive headers from WebCore/{bindings,css,dom}
3171         https://bugs.webkit.org/show_bug.cgi?id=173766
3172
3173         Reviewed by Simon Fraser.
3174
3175         * DOM/DOMInternal.mm:
3176
3177 2017-06-22  Daniel Bates  <dabates@apple.com>
3178
3179         Make FrameLoadRequest a move-only type
3180         https://bugs.webkit.org/show_bug.cgi?id=173682
3181
3182         Reviewed by Alex Christensen and Darin Adler.
3183
3184         A FrameLoadRequest groups together the information to perform a load into a single object
3185         that is more manageable to pass around than its constituent parts. Code that receives a
3186         FrameLoadRequest is expected to extract out the information it needs to complete its task.
3187         And it does not make sense to re-use the same FrameLoadRequest object for more than one
3188         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
3189
3190         * Plugins/WebPluginController.mm:
3191         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
3192         * WebView/WebPDFView.mm:
3193         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3194
3195 2017-06-21  Antoine Quint  <graouts@apple.com>
3196
3197         Ensure DRT always logs rAF suspension debugging code
3198         https://bugs.webkit.org/show_bug.cgi?id=173681
3199
3200         Reviewed by Tim "Mr. T" Horton.
3201
3202         * WebView/WebPreferenceKeysPrivate.h:
3203         * WebView/WebPreferences.mm:
3204         (+[WebPreferences initialize]):
3205         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]): Deleted.
3206         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]): Deleted.
3207         * WebView/WebPreferencesPrivate.h:
3208         * WebView/WebView.mm:
3209         (-[WebView _preferencesChanged:]):
3210
3211 2017-06-21  Daniel Bates  <dabates@apple.com>
3212
3213         Cleanup FrameLoadRequest
3214         https://bugs.webkit.org/show_bug.cgi?id=173564
3215         <rdar://problem/32903570>
3216
3217         Reviewed by Brent Fulgham.
3218
3219         * WebView/WebPDFView.mm:
3220         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Move FrameLoadRequest instantiation
3221         into a local variable and use C++11 brace initialization syntax to make it easier to identify
3222         the arguments passed to FrameLoader::loadFrameRequest().
3223
3224 2017-06-21  Antoine Quint  <graouts@apple.com>
3225
3226         Add logging to identify when the Page suspends scripted animations
3227         https://bugs.webkit.org/show_bug.cgi?id=173626
3228
3229         Reviewed by Tim Horton.
3230
3231         Add a new preference to control the new shouldLogScriptedAnimationControllerSuspensionChange settings
3232         through WebKit. This is specific to WK1 since the issue we're trying to pinpoint only occurs on WK1 bots.
3233
3234         * WebView/WebPreferenceKeysPrivate.h:
3235         * WebView/WebPreferences.mm:
3236         (+[WebPreferences initialize]):
3237         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]):
3238         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]):
3239         * WebView/WebPreferencesPrivate.h:
3240         * WebView/WebView.mm:
3241         (-[WebView _preferencesChanged:]):
3242
3243 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
3244
3245         Disable font variations on macOS Sierra and iOS 10
3246         https://bugs.webkit.org/show_bug.cgi?id=173618
3247         <rdar://problem/32879164>
3248
3249         Reviewed by Jon Lee.
3250
3251         * Configurations/FeatureDefines.xcconfig:
3252
3253 2017-06-20  Daniel Bates  <dabates@apple.com>
3254
3255         Have FrameLoadRequest takes a Frame& instead of a Frame*
3256         https://bugs.webkit.org/show_bug.cgi?id=173614
3257         <rdar://problem/32884890>
3258
3259         Reviewed by Brent Fulgham.
3260
3261         * Plugins/WebPluginController.mm:
3262         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
3263         * WebView/WebFrame.mm:
3264         (-[WebFrame loadRequest:]):
3265         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
3266
3267 2017-06-19  Frederic Wang  <fwang@igalia.com>
3268
3269         [Mac] Add an experimental feature setting for async frame scrolling
3270         https://bugs.webkit.org/show_bug.cgi?id=173359
3271
3272         Reviewed by Simon Fraser.
3273
3274         * WebView/WebPreferenceKeysPrivate.h: Declare key for async frame scrolling preference.
3275         * WebView/WebPreferences.mm:
3276         (+[WebPreferences initialize]): Initialize async frame scrolling preference to false.
3277         (-[WebPreferences asyncFrameScrollingEnabled]): Define getter for async frame scrolling.
3278         (-[WebPreferences setAsyncFrameScrollingEnabled:]): Define setter for async frame scrolling.
3279         * WebView/WebPreferencesPrivate.h: Declare setter and getter.
3280         * WebView/WebView.mm:
3281         (-[WebView _preferencesChanged:]): Take into account preference update for async frame
3282         scrolling.
3283
3284 2017-06-19  Chris Dumez  <cdumez@apple.com>
3285
3286         Use WTF::Function instead of std::function in more places in WebCore/
3287         https://bugs.webkit.org/show_bug.cgi?id=173535
3288
3289         Reviewed by Antti Koivisto.
3290
3291         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
3292
3293         * WebCoreSupport/WebFrameLoaderClient.h:
3294         * WebCoreSupport/WebFrameLoaderClient.mm:
3295         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3296         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3297         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3298         (WebFrameLoaderClient::dispatchWillSubmitForm):
3299         (WebFrameLoaderClient::setUpPolicyListener):
3300         (-[WebFramePolicyListener initWithFrame:policyFunction:]):
3301         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]):
3302
3303 2017-05-14 Frederic Wang  <fwang@igalia.com>
3304
3305         Add heuristic to avoid flattening "fullscreen" iframes
3306         https://bugs.webkit.org/show_bug.cgi?id=171914
3307
3308         Reviewed by Simon Fraser.
3309
3310         This commit adjusts the mac/ios preference interface to treat frame flattening as an enum.
3311
3312         * WebView/WebPreferenceKeysPrivate.h: Rename the key.
3313         * WebView/WebPreferences.mm:
3314         (+[WebPreferences initialize]): Handle frame flattening as an enum.
3315         (-[WebPreferences isFrameFlatteningEnabled]): Ditto.
3316         (-[WebPreferences setFrameFlatteningEnabled:]): Ditto.
3317         (-[WebPreferences frameFlattening]): New function to get frame flattening as an enum.
3318         (-[WebPreferences setFrameFlattening:]): New function to set frame flattening as an enum.
3319         * WebView/WebPreferencesPrivate.h: Ditto.
3320         * WebView/WebView.mm:
3321         (-[WebView _preferencesChanged:]): Ditto.
3322         * WebView/WebPreferencesPrivate.h: Add new enum definition.
3323
3324 2017-06-17  Chris Dumez  <cdumez@apple.com>
3325
3326         Use WTF::Function instead of std::function in WebKit2/
3327         https://bugs.webkit.org/show_bug.cgi?id=173504
3328
3329         Reviewed by Darin Adler.
3330
3331         Use WTF::Function instead of std::function in WebKit2/ to avoid
3332         unnecessary copying.
3333
3334         * Plugins/Hosted/HostedNetscapePluginStream.h:
3335         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3336         (WebKit::HostedNetscapePluginStream::willSendRequest):
3337         * Plugins/WebNetscapePluginStream.h:
3338         * Plugins/WebNetscapePluginStream.mm:
3339         (WebNetscapePluginStream::willSendRequest):
3340         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3341         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3342         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
3343         (WebPaymentCoordinatorClient::openPaymentSetup):
3344
3345 2017-06-16  Sam Weinig  <sam@webkit.org>
3346
3347         [WebIDL] Remove custom bindings for HTMLDocument
3348         https://bugs.webkit.org/show_bug.cgi?id=173444
3349
3350         Reviewed by Darin Adler.
3351
3352         * DOM/DOMHTMLDocument.mm:
3353         (-[DOMHTMLDocument linkColor]):
3354         (-[DOMHTMLDocument setLinkColor:]):
3355         (-[DOMHTMLDocument write:]):
3356         (-[DOMHTMLDocument writeln:]):
3357         Update for new signature of write/writeln and rename of linkColor to linkColorForBindings.
3358
3359 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3360
3361         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
3362         https://bugs.webkit.org/show_bug.cgi?id=173366
3363         <rdar://problem/32767014>
3364
3365         Reviewed by Tim Horton.
3366
3367         Move pieces of iOS WebKit1 drag and drop implementation into OpenSource. No change in behavior.
3368
3369         * Configurations/FeatureDefines.xcconfig:
3370         * WebCoreSupport/WebDragClient.mm:
3371         (WebDragClient::useLegacyDragClient):
3372         (WebDragClient::willPerformDragDestinationAction):
3373         (WebDragClient::dragSourceActionMaskForPoint):
3374         (WebDragClient::willPerformDragSourceAction):
3375         (WebDragClient::startDrag):
3376         (WebDragClient::beginDrag):
3377         (WebDragClient::declareAndWriteDragImage):
3378         (WebDragClient::declareAndWriteAttachment):
3379         (WebDragClient::didConcludeEditDrag):
3380         * WebView/WebView.mm:
3381         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
3382         (-[WebView _getDataInteractionData]):
3383         (-[WebView dragDataForSession:client:global:operation:]):
3384         (-[WebView _enteredDataInteraction:client:global:operation:]):
3385         (-[WebView _updatedDataInteraction:client:global:operation:]):
3386         (-[WebView _exitedDataInteraction:client:global:operation:]):
3387         (-[WebView _performDataInteraction:client:global:operation:]):
3388         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
3389         (-[WebView _endedDataInteraction:global:]):
3390         (-[WebView _didConcludeEditDataInteraction]):
3391         (floatRectsForCGRectArray): Deleted.
3392         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]): Deleted.
3393         * WebView/WebViewData.h:
3394         * WebView/WebViewData.mm:
3395         (-[WebViewPrivate dealloc]):
3396         * WebView/WebViewPrivate.h:
3397
3398 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3399
3400         [iOS DnD] [WK1] Dropping links onto UIWebViews should not trigger navigation by default
3401         https://bugs.webkit.org/show_bug.cgi?id=173454
3402         <rdar://problem/31720671>
3403
3404         Reviewed by Tim Horton.
3405
3406         Adds -webView:dragDestinationActionMaskForSession: as SPI to WebUIDelegate.
3407         If unimplemented, the default UI delegate allows all actions except for URL loading.
3408
3409         * DefaultDelegates/WebDefaultUIDelegate.mm:
3410         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForSession:]):
3411         * WebView/WebUIDelegatePrivate.h:
3412         * WebView/WebView.mm:
3413         (-[WebView dragDestinationActionMaskForSession:]):
3414
3415 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3416
3417         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
3418         https://bugs.webkit.org/show_bug.cgi?id=173338
3419         <rdar://problem/32777720>
3420
3421         Reviewed by Tim Horton.
3422
3423         Rename updatePreferredTypeIdentifiers to updateSupportedTypeIdentifiers.
3424
3425         * WebCoreSupport/WebPlatformStrategies.h:
3426         * WebCoreSupport/WebPlatformStrategies.mm:
3427         (WebPlatformStrategies::updateSupportedTypeIdentifiers):
3428         (WebPlatformStrategies::updatePreferredTypeIdentifiers): Deleted.
3429
3430 2017-06-13  Daniel Bates  <dabates@apple.com>
3431
3432         Implement W3C Secure Contexts Draft Specification
3433         https://bugs.webkit.org/show_bug.cgi?id=158121
3434         <rdar://problem/26012994>
3435
3436         Reviewed by Brent Fulgham.
3437
3438         Part 4
3439
3440         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
3441
3442         * WebView/WebPreferenceKeysPrivate.h:
3443         * WebView/WebPreferences.mm:
3444         (+[WebPreferences initialize]):
3445         (-[WebPreferences isSecureContextAttributeEnabled]):
3446         (-[WebPreferences setIsSecureContextAttributeEnabled:]):
3447         * WebView/WebPreferencesPrivate.h:
3448         * WebView/WebView.mm:
3449         (-[WebView _preferencesChanged:]):
3450
3451 2017-06-13  Sam Weinig  <sam@webkit.org>
3452
3453         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
3454         https://bugs.webkit.org/show_bug.cgi?id=80733
3455
3456         Reviewed by Chris Dumez.
3457
3458         * DOM/DOMUtility.mm:
3459         (createDOMWrapper):
3460         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3461         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3462         * WebView/WebFrame.mm:
3463         (-[WebFrame _attachScriptDebugger]):
3464         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
3465
3466 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
3467
3468         [WebCrypto] Remove experimental feature flag of SubtleCrypto
3469         https://bugs.webkit.org/show_bug.cgi?id=173197
3470         <rdar://problem/32688148>
3471
3472         Reviewed by Brent Fulgham.
3473
3474         * WebView/WebPreferences.mm:
3475         (+[WebPreferences initialize]):
3476         (-[WebPreferences subtleCryptoEnabled]): Deleted.
3477         (-[WebPreferences setSubtleCryptoEnabled:]): Deleted.
3478         * WebView/WebPreferencesPrivate.h:
3479         * WebView/WebView.mm:
3480         (-[WebView _preferencesChanged:]):
3481
3482 2017-06-10  Dan Bernstein  <mitz@apple.com>
3483
3484         Reverted r218056 because it made the IDE reindex constantly.
3485
3486         * Configurations/DebugRelease.xcconfig:
3487
3488 2017-06-10  Dan Bernstein  <mitz@apple.com>
3489
3490         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
3491         https://bugs.webkit.org/show_bug.cgi?id=173223
3492
3493         Reviewed by Sam Weinig.
3494
3495         The rebuilds were happening due to a difference in the compiler options that the IDE and
3496         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
3497         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
3498         specify an appropriate path in CLANG_INDEX_STORE_PATH.
3499
3500         * Configurations/DebugRelease.xcconfig: