libwebrtc update broke internal builds
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-03-08  Youenn Fablet  <youenn@apple.com>
2
3         libwebrtc update broke internal builds
4         https://bugs.webkit.org/show_bug.cgi?id=183454
5
6         Reviewed by Eric Carlson.
7
8         * Configurations/WebKitLegacy.xcconfig:
9
10 2018-03-08  Chris Dumez  <cdumez@apple.com>
11
12         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
13         https://bugs.webkit.org/show_bug.cgi?id=183455
14         <rdar://problem/38191749>
15
16         Reviewed by Youenn Fablet.
17
18         Add a null check for the page as we have evidence from crashes that it can be null.
19         Other functions in WebFrameNetworkingContext already null check the page as well,
20         not just the frame so this is consistent.
21
22         * WebCoreSupport/WebFrameNetworkingContext.mm:
23         (WebFrameNetworkingContext::storageSession const):
24
25 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
26
27         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
28         https://bugs.webkit.org/show_bug.cgi?id=183429
29
30         Reviewed by Mark Lam.
31
32         * DOM/DOM.mm:
33         (+[DOMNode _nodeFromJSWrapper:]):
34         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
35         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
36         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
37         * Plugins/Hosted/ProxyInstance.mm:
38         (WebKit::ProxyInstance::invokeMethod):
39         * WebView/WebView.mm:
40         (aeDescFromJSValue):
41
42 2018-03-08  Tim Horton  <timothy_horton@apple.com>
43
44         Stop linking ApplicationServices directly
45         https://bugs.webkit.org/show_bug.cgi?id=182867
46         <rdar://problem/38252142>
47
48         Reviewed by Alex Christensen.
49
50         The frameworks that we use that live inside ApplicationServices
51         have mostly moved out, so import them directly.
52
53         * Carbon/CarbonUtils.h:
54         * WebKitPrefix.h:
55         * WebView/WebHTMLView.mm:
56         * WebView/WebPDFView.mm:
57
58 2018-03-07  Tim Horton  <timothy_horton@apple.com>
59
60         Sort and separate FeatureDefines.xcconfig
61         https://bugs.webkit.org/show_bug.cgi?id=183427
62
63         Reviewed by Dan Bernstein.
64
65         * Configurations/FeatureDefines.xcconfig:
66         Sort and split FeatureDefines into paragraphs
67         (to make it easier to sort later).
68
69 2018-03-07  Youenn Fablet  <youenn@apple.com>
70
71         Match unsupported plugins based on domains and not origin
72         https://bugs.webkit.org/show_bug.cgi?id=183384
73
74         Reviewed by Chris Dumez.
75
76         * WebCoreSupport/WebPluginInfoProvider.h:
77         * WebCoreSupport/WebPluginInfoProvider.mm:
78         (WebPluginInfoProvider::getPluginInfo):
79         (WebPluginInfoProvider::getWebVisiblePluginInfo):
80
81 2018-03-05  Andy Estes  <aestes@apple.com>
82
83         [Mac] Teach WebCore::Pasteboard about file promise drags
84         https://bugs.webkit.org/show_bug.cgi?id=183314
85         <rdar://problem/38105493>
86
87         Reviewed by Darin Adler.
88
89         Added a FIXME comment.
90
91         * WebView/WebView.mm:
92         (-[WebView performDragOperation:]):
93
94 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
95
96         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
97         https://bugs.webkit.org/show_bug.cgi?id=183312
98
99         Reviewed by Mark Lam.
100
101         Remove wtf/CurrentTime.h include pragma.
102
103         * WebView/WebFrame.mm:
104         * WebView/WebPDFView.mm:
105
106 2018-03-04  Tim Horton  <timothy_horton@apple.com>
107
108         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
109         https://bugs.webkit.org/show_bug.cgi?id=183283
110         <rdar://problem/38062148>
111
112         Reviewed by Sam Weinig.
113
114         * Configurations/FeatureDefines.xcconfig:
115
116 2018-02-28  Alex Christensen  <achristensen@webkit.org>
117
118         Reduce use of NetworkingContext in WebKit
119         https://bugs.webkit.org/show_bug.cgi?id=183213
120
121         Reviewed by Brady Eidson.
122
123         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
124         (WebKit::NetscapePluginInstanceProxy::getProxy):
125         * Plugins/WebNetscapePluginView.mm:
126         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
127
128 2018-02-17  Darin Adler  <darin@apple.com>
129
130         Prepare for ExtendedColor changes (first step)
131         https://bugs.webkit.org/show_bug.cgi?id=182904
132
133         Reviewed by Sam Weinig.
134
135         * Misc/WebKitNSStringExtras.mm:
136         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
137
138 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
139
140         Remove currentTime() / currentTimeMS()
141         https://bugs.webkit.org/show_bug.cgi?id=183052
142
143         Reviewed by Mark Lam.
144
145         * WebCoreSupport/WebFrameLoaderClient.h:
146         * WebCoreSupport/WebFrameLoaderClient.mm:
147         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
148
149 2018-02-16  Youenn Fablet  <youenn@apple.com>
150
151         Allow specifying which plug-ins are supported
152         https://bugs.webkit.org/show_bug.cgi?id=182748
153
154         Reviewed by Chris Dumez.
155
156         * WebCoreSupport/WebPluginInfoProvider.h:
157         * WebCoreSupport/WebPluginInfoProvider.mm:
158         (WebPluginInfoProvider::getPluginInfo):
159         (WebPluginInfoProvider::getWebVisiblePluginInfo):
160
161 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
162
163         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
164         https://bugs.webkit.org/show_bug.cgi?id=182882
165         <rdar://problem/35672661>
166
167         Reviewed by Dan Bernstein.
168
169         Make sure the smart pointer hold the collection of subviews lives at least as
170         long as the loop using it.
171
172         * WebView/WebHTMLView.mm:
173         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
174
175 2018-02-14  Daniel Bates  <dabates@apple.com>
176
177         Disallow cross-origin subresources from asking for credentials
178         https://bugs.webkit.org/show_bug.cgi?id=182579
179         <rdar://problem/36162271>
180
181         Reviewed by Andy Estes.
182
183         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
184         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
185
186         * WebView/WebPreferenceKeysPrivate.h:
187         * WebView/WebPreferences.mm:
188         (+[WebPreferences initialize]):
189         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
190         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
191         * WebView/WebPreferencesPrivate.h:
192         * WebView/WebView.mm:
193         (-[WebView _preferencesChanged:]):
194
195 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
196
197         Remove ForwardingHeaders directory from WebKitLegacy/mac.
198         https://bugs.webkit.org/show_bug.cgi?id=182738
199
200         Reviewed by Darin Adler.
201
202         * ForwardingHeaders/collector/handles/Global.h: Removed.
203         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
204         * ForwardingHeaders/runtime/Completion.h: Removed.
205         * ForwardingHeaders/runtime/Error.h: Removed.
206         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
207         * ForwardingHeaders/runtime/JSFunction.h: Removed.
208         * ForwardingHeaders/runtime/JSLock.h: Removed.
209         * ForwardingHeaders/runtime/JSObject.h: Removed.
210         * ForwardingHeaders/runtime/JSString.h: Removed.
211         * ForwardingHeaders/runtime/Protect.h: Removed.
212         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
213
214 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
215
216         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
217         https://bugs.webkit.org/show_bug.cgi?id=182641
218
219         Reviewed by Dan Bernstein.
220
221         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
222         https://trac.webkit.org/changeset/228308.
223
224         * WebView/WebVideoFullscreenController.h:
225         * WebView/WebVideoFullscreenHUDWindowController.mm:
226         * WebView/WebWindowAnimation.h:
227         * WebView/WebWindowAnimation.mm:
228         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
229         (WebCore::scaledRect): Deleted.
230         (WebCore::squaredDistance): Deleted.
231
232 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
233
234         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
235
236         * WebView/WebWindowAnimation.mm:
237         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
238
239 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
240
241         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
242         https://bugs.webkit.org/show_bug.cgi?id=182615
243
244         Reviewed by Eric Carlson.
245
246         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
247         Ideally, we should not reference NSApp in WebCore.
248
249         * WebView/WebFullScreenController.mm:
250         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
251         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
252         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
253         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
254         * WebView/WebView.mm:
255         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
256         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
257
258 2018-01-13  Darin Adler  <darin@apple.com>
259
260         Event improvements
261         https://bugs.webkit.org/show_bug.cgi?id=179591
262
263         Reviewed by Chris Dumez.
264
265         * DOM/DOMWheelEvent.mm:
266         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
267         Call initWebKitWheelEvent.
268
269         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
270         * WebCoreSupport/WebInspectorClient.mm: Ditto.
271         * WebView/WebFrame.mm: Ditto.
272
273         * WebView/WebHTMLView.mm:
274         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
275         underlyingPlatformEvent.
276         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
277
278         * WebView/WebScriptWorld.mm:
279         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
280
281         * WebView/WebView.mm: Removed include of ScriptValue.h.
282
283 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
284
285         Remove WebCore/ForwardingHeaders directory
286         https://bugs.webkit.org/show_bug.cgi?id=182347
287
288         Reviewed by Keith Miller.
289
290         * Carbon/CarbonWindowAdapter.mm:
291         * DOM/WebDOMOperations.mm:
292         * History/WebBackForwardList.mm:
293         * History/WebHistoryItem.mm:
294         * Misc/WebCache.mm:
295         * Misc/WebElementDictionary.mm:
296         * Misc/WebIconDatabase.mm:
297         * Misc/WebStringTruncator.mm:
298         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
299         * Plugins/Hosted/ProxyInstance.mm:
300         * Plugins/Hosted/ProxyRuntimeObject.mm:
301         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
302         * Plugins/WebBaseNetscapePluginView.mm:
303         * Plugins/WebBasePluginPackage.mm:
304         * Plugins/WebNetscapePluginStream.mm:
305         * Plugins/WebNetscapePluginView.mm:
306         * Plugins/WebPluginController.mm:
307         * WebCoreSupport/WebEditorClient.mm:
308         * WebCoreSupport/WebFrameLoaderClient.mm:
309         * WebCoreSupport/WebInspectorClient.h:
310         * WebCoreSupport/WebInspectorClient.mm:
311         * WebView/WebDataSource.mm:
312         * WebView/WebFrame.mm:
313         * WebView/WebHTMLRepresentation.mm:
314         * WebView/WebHTMLView.mm:
315         * WebView/WebPreferences.mm:
316         * WebView/WebScriptDebugDelegate.mm:
317         * WebView/WebScriptDebugger.h:
318         * WebView/WebTextIterator.mm:
319         * WebView/WebView.mm:
320         * WebView/WebViewData.mm:
321
322 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
323
324         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
325         https://bugs.webkit.org/show_bug.cgi?id=182312
326
327         Reviewed by Michael Catanzaro.
328
329         * WebKitPrefix.h:
330
331 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
332
333         [WebAuthN] Add a compile-time feature flag
334         https://bugs.webkit.org/show_bug.cgi?id=182211
335         <rdar://problem/36936365>
336
337         Reviewed by Brent Fulgham.
338
339         * Configurations/FeatureDefines.xcconfig:
340
341 2018-01-27  Dan Bernstein  <mitz@apple.com>
342
343         HaveInternalSDK includes should be "#include?"
344         https://bugs.webkit.org/show_bug.cgi?id=179670
345
346         * Configurations/Base.xcconfig:
347
348 2018-01-24  Alex Christensen  <achristensen@webkit.org>
349
350         Remove unused QTKit preference
351         https://bugs.webkit.org/show_bug.cgi?id=181968
352
353         Reviewed by Alexey Proskuryakov.
354
355         * WebView/WebPreferenceKeysPrivate.h:
356         * WebView/WebPreferences.mm:
357         (+[WebPreferences initialize]):
358         (-[WebPreferences setQTKitEnabled:]): Deleted.
359         (-[WebPreferences isQTKitEnabled]): Deleted.
360         * WebView/WebPreferencesPrivate.h:
361         * WebView/WebView.mm:
362         (-[WebView _preferencesChanged:]):
363
364 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
365
366         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
367         https://bugs.webkit.org/show_bug.cgi?id=182037
368         <rdar://problem/36747812>
369
370         Reviewed by Ryosuke Niwa.
371
372         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
373         for more details.
374
375         * WebView/WebHTMLRepresentation.mm:
376         (-[WebHTMLRepresentation elementWithName:inForm:]):
377         (-[WebHTMLRepresentation controlsInForm:]):
378
379 2018-01-23  Alex Christensen  <achristensen@webkit.org>
380
381         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
382         https://bugs.webkit.org/show_bug.cgi?id=181961
383
384         Reviewed by Michael Catanzaro.
385
386         * WebView/WebPreferences.mm:
387
388 2018-01-23  Commit Queue  <commit-queue@webkit.org>
389
390         Unreviewed, rolling out r227437.
391         https://bugs.webkit.org/show_bug.cgi?id=182011
392
393         broke build (Requested by alexchristensen on #webkit).
394
395         Reverted changeset:
396
397         "Remove unused QTKit preference"
398         https://bugs.webkit.org/show_bug.cgi?id=181968
399         https://trac.webkit.org/changeset/227437
400
401 2018-01-23  Alex Christensen  <achristensen@webkit.org>
402
403         Remove unused QTKit preference
404         https://bugs.webkit.org/show_bug.cgi?id=181968
405
406         Reviewed by Alexey Proskuryakov.
407
408         * WebView/WebPreferenceKeysPrivate.h:
409         * WebView/WebPreferences.mm:
410         (+[WebPreferences initialize]):
411         (-[WebPreferences setQTKitEnabled:]): Deleted.
412         (-[WebPreferences isQTKitEnabled]): Deleted.
413         * WebView/WebPreferencesPrivate.h:
414         * WebView/WebView.mm:
415         (-[WebView _preferencesChanged:]):
416
417 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
418
419         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
420         https://bugs.webkit.org/show_bug.cgi?id=181960
421         <rdar://problem/36431678>
422
423         Reviewed by Tim Horton.
424
425         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
426         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
427         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
428
429         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
430         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
431         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
432
433         * WebView/WebView.mm:
434         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
435
436 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
437
438         Turning off custom pasteboard data doesn't actually turn it off in WK2
439         https://bugs.webkit.org/show_bug.cgi?id=181920
440         <rdar://problem/36686429>
441
442         Reviewed by Wenson Hsieh.
443
444         Always disable custom pasteboard data in WebKit1. See r226156 for details.
445
446         * WebView/WebPreferences.mm:
447         (+[WebPreferences initialize]):
448         * WebView/WebView.mm:
449         (-[WebView _preferencesChanged:]):
450
451 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
452
453         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
454         https://bugs.webkit.org/show_bug.cgi?id=181918
455
456         Reviewed by Tim Horton.
457
458         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
459
460         * Configurations/FeatureDefines.xcconfig:
461
462 2018-01-20  Andy Estes  <aestes@apple.com>
463
464         [Apple Pay] Stop eagerly loading PassKit.framework
465         https://bugs.webkit.org/show_bug.cgi?id=181911
466         <rdar://problem/36555369>
467
468         Reviewed by Tim Horton.
469
470         * WebCoreSupport/WebPaymentCoordinatorClient.h:
471         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
472         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
473
474         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
475
476 2018-01-19  Dean Jackson  <dino@apple.com>
477
478         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
479         https://bugs.webkit.org/show_bug.cgi?id=181817
480         <rdar://problem/35274055>
481
482         Reviewed by Simon Fraser.
483
484         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
485
486         * Misc/WebKitVersionChecks.h:
487         * WebView/WebView.mm:
488         (-[WebView _commonInitializationWithFrameName:groupName:]):
489
490 2018-01-19  Alex Christensen  <achristensen@webkit.org>
491
492         Remove unused WebViewPrivate _allowCookies
493         https://bugs.webkit.org/show_bug.cgi?id=181812
494
495         Reviewed by Tim Horton.
496
497         * WebView/WebView.mm:
498         (+[WebView _setAllowCookies:]): Deleted.
499         (+[WebView _allowCookies]): Deleted.
500         * WebView/WebViewPrivate.h:
501
502 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
503
504         Build fix, remove a call to -[NSWindow setOneShot:]
505         https://bugs.webkit.org/show_bug.cgi?id=181809
506
507         Reviewed by Tim Horton.
508
509         * WebView/WebTextCompletionController.mm:
510         (-[WebTextCompletionController _buildUI]):
511
512 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
513
514         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
515
516         * Carbon/HIWebView.mm:
517         (overrideCGContext):
518         (restoreCGContext):
519
520 2018-01-18  Dan Bernstein  <mitz@apple.com>
521
522         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
523         https://bugs.webkit.org/show_bug.cgi?id=181803
524
525         Reviewed by Tim Horton.
526
527         * Configurations/Base.xcconfig: Updated.
528         * Configurations/DebugRelease.xcconfig: Ditto.
529         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
530         * Configurations/Version.xcconfig: Updated.
531         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
532           useful for defining settings that depend on the target macOS version.
533
534 2018-01-17  Youenn Fablet  <youenn@apple.com>
535
536         Put fetch Request.keepalive behind a runtime flag
537         https://bugs.webkit.org/show_bug.cgi?id=181592
538
539         Reviewed by Chris Dumez.
540
541         * WebView/WebPreferenceKeysPrivate.h:
542         * WebView/WebPreferences.mm:
543         (+[WebPreferences initialize]):
544         (-[WebPreferences fetchAPIKeepAliveEnabled]):
545         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
546         * WebView/WebPreferencesPrivate.h:
547         * WebView/WebView.mm:
548         (-[WebView _preferencesChanged:]):
549
550 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
551
552         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
553         https://bugs.webkit.org/show_bug.cgi?id=181637
554         <rdar://problem/36508471>
555
556         Reviewed by Tim Horton.
557
558         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
559
560         * WebCoreSupport/WebEditorClient.h:
561         * WebCoreSupport/WebEditorClient.mm:
562         (WebEditorClient::replacementURLForResource):
563
564 2018-01-11  Keith Miller  <keith_miller@apple.com>
565
566         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
567         https://bugs.webkit.org/show_bug.cgi?id=181573
568
569         Reviewed by Simon Fraser.
570
571         * Configurations/FeatureDefines.xcconfig:
572
573 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
574
575         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
576         https://bugs.webkit.org/show_bug.cgi?id=181497
577
578         Reviewed by Tim Horton.
579
580         See other ChangeLogs for more detail.
581
582         * WebCoreSupport/WebDragClient.h:
583
584 2018-01-11  Tim Horton  <timothy_horton@apple.com>
585
586         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
587         https://bugs.webkit.org/show_bug.cgi?id=181523
588         <rdar://problem/28959131>
589
590         Reviewed by Alex Christensen.
591
592         * WebView/WebImmediateActionController.mm:
593         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
594         Apply the change made in r216652 to WebKit1's immediate action controller.
595
596         Speculative (but successful in WebKit2) fix for non-reproducible crash when
597         the startContainer of the range is in an anonymous node.
598
599 2018-01-11  Youenn Fablet  <youenn@apple.com>
600
601         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
602         https://bugs.webkit.org/show_bug.cgi?id=181480
603
604         Reviewed by Eric Carlson.
605
606         * WebView/WebPreferences.mm:
607         (+[WebPreferences initialize]):
608
609 2018-01-08  David Kilzer  <ddkilzer@apple.com>
610
611         Fix check-webkit-style issues with WebNSDataExtras.mm
612         <https://webkit.org/b/181369>
613
614         Reviewed by Alex Christensen.
615
616         * Misc/WebNSDataExtras.mm:
617         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
618         (-[NSData _webkit_guessedMIMETypeForXML]):
619         (-[NSData _webkit_guessedMIMEType]):
620         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
621         (_findEOL):
622         (-[NSData _webkit_parseRFC822HeaderFields]):
623         (-[NSData _web_locationAfterFirstBlankLine]):
624         - Fix all the check-webkit-style warnings.
625
626 2018-01-08  David Kilzer  <ddkilzer@apple.com>
627
628         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
629         <https://webkit.org/b/181256>
630         <rdar://problem/36281730>
631
632         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
633         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
634         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
635           to avoid warnings from casting CFStringRef to NPNSString*.
636           Note that CFMutableStringRef is the same as CFStringRef
637           without the const modifier, hence its use in the const_cast<>
638           above.
639
640 2018-01-08  David Kilzer  <ddkilzer@apple.com>
641
642         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
643         <https://webkit.org/b/181256>
644         <rdar://problem/36281730>
645
646         * Carbon/HIWebView.mm:
647         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
648         checked_cf_cast<CFRunLoopRef>() to fix warning.
649
650 2018-01-07  David Kilzer  <ddkilzer@apple.com>
651
652         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
653         <https://webkit.org/b/181256>
654         <rdar://problem/36281730>
655
656         Reviewed by Darin Adler.
657
658         * Carbon/CarbonUtils.m:
659         (PoolCleaner):
660         - Use #pragmas to ignore -Wcast-qual warnings when using a
661           C-style cast from CFTypeRef to CFRunloopRef.
662         * Carbon/CarbonWindowFrame.m:
663         (-[CarbonWindowFrame title]):
664         - Use #pragmas to ignore -Wcast-qual warnings when using a
665           C-style cast from CFStringRef to NSString *.
666         * Carbon/HIViewAdapter.m:
667         (+[HIViewAdapter getHIViewForNSView:]):
668         - Use #pragmas to ignore -Wcast-qual warnings when using a
669           C-style cast from CFTypeRef to HIViewRef.
670         * Configurations/Base.xcconfig:
671         (WARNING_CFLAGS): Add -Wcast-qual.
672         * Misc/WebElementDictionary.mm:
673         (-[WebElementDictionary objectForKey:]):
674         - Use static_cast<SEL>(const_cast<void*>()) to fix
675           warning.
676         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
677         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
678         (-[NSData _webkit_guessedMIMETypeForXML]):
679         (-[NSData _webkit_guessedMIMEType]):
680         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
681         (_findEOL):
682         (-[NSData _webkit_parseRFC822HeaderFields]):
683         (-[NSData _web_startsWithBlankLine]):
684         (-[NSData _web_locationAfterFirstBlankLine]):
685         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
686           type to Objective-C++.  This fixes the warnings about
687           discarding the `const` modifier when casing from CFStringRef
688           to NSString * because in older clang versions, -Wcast-qual was
689           completely broken when compiling C++ and Objective-C++ source
690           files.  In newer clang versions, discarding the `const`
691           modifier for toll-free bridged types is ignored when compiling
692           Objective-C++ source.
693         - Update copyright and license header.
694         - Use reinterpret_cast<> and static_cast<> to fix warnings
695           unrelated to (NSString *) C-style casts.
696         - Replace use of MIN() macro with std::min<> template functions.
697         - Fix location of `*` for local variables modified above.
698         * Plugins/Hosted/NetscapePluginHostManager.mm:
699         (WebKit::NetscapePluginHostManager::spawnPluginHost):
700         (WebKit::NetscapePluginHostManager::initializeVendorPort):
701         (WebKit::NetscapePluginHostManager::instantiatePlugin):
702         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
703           warnings.
704         * Plugins/Hosted/NetscapePluginHostProxy.mm:
705         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
706         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
707           to fix warning.
708         * Plugins/Hosted/ProxyInstance.mm:
709         (WebKit::ProxyInstance::invoke):
710         - Use static_cast<char*>(const_cast<void*>()) to fix
711           warning when using -[NSData bytes].
712         (WebKit::ProxyInstance::fieldValue const):
713         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
714           to fix warning when using CFDataGetBytePtr().
715         * Plugins/Hosted/WebTextInputWindowController.m:
716         (-[WebTextInputPanel _interpretKeyEvent:string:]):
717         - Use #pragma to ignore -Wcast-qual warning since there
718           is not a good way to avoid this warning in Objective-C.
719         * Plugins/WebNetscapePluginStream.mm:
720         (WebNetscapePluginStream::deliverData):
721         - Use const_cast<void*>() to fix warning when using
722           -[NSData bytes].
723         * Plugins/WebNetscapePluginView.mm:
724         (-[WebNetscapePluginView _createPlugin]):
725         - Change C-style cast to const_cast<char*>() to fix
726           warning.
727         * WebCoreSupport/WebChromeClient.mm:
728         (WebChromeClient::wrapCryptoKey const):
729         (WebChromeClient::unwrapCryptoKey const):
730         - Change C-style cast to
731           static_cast<uint8_t*>(const_cast<void*>() to fix
732           warning.
733         * WebView/WebPDFView.mm:
734         (_applicationInfoForMIMEType):
735         - Change local variable type from 'NSURL *' to
736           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
737           when calling -[NSURL path].
738
739 2018-01-05  Dan Bernstein  <mitz@apple.com>
740
741         Fixed the build following AppKit API deprecations in a recent SDKs
742
743         * WebView/WebFullScreenController.mm:
744         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
745         (-[WebFullScreenController exitFullScreen]): Ditto.
746         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
747         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
748         * WebView/WebHTMLView.mm:
749         (-[WebHTMLView drawRect:]): Ditto.
750         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
751         (-[WebHTMLView knowsPageRange:]): Ditto.
752         * WebView/WebView.mm:
753         (LayerFlushController::flushLayers): Ditto.
754
755 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
756
757         [Attachment Support] Create attachment elements when dropping files on iOS
758         https://bugs.webkit.org/show_bug.cgi?id=181192
759         <rdar://problem/36280945>
760
761         Reviewed by Tim Horton.
762
763         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
764
765         * WebCoreSupport/WebPlatformStrategies.h:
766         * WebCoreSupport/WebPlatformStrategies.mm:
767         (WebPlatformStrategies::informationForItemAtIndex):
768         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
769
770 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
771
772         [Attachment Support] Add plumbing for starting a drag with promised blob data
773         https://bugs.webkit.org/show_bug.cgi?id=181201
774
775         Reviewed by Tim Horton.
776
777         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
778
779         * WebCoreSupport/WebDragClient.h:
780
781 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
782
783         Add a WebAuthentication runtime feature flag
784         https://bugs.webkit.org/show_bug.cgi?id=181220
785         <rdar://problem/36055305>
786
787         Reviewed by Brent Fulgham.
788
789         Renames the CredentialManagement runtime feature flag into WebAuthentication.
790
791         * WebView/WebPreferenceKeysPrivate.h:
792         * WebView/WebPreferences.mm:
793         (+[WebPreferences initialize]):
794         (-[WebPreferences webAuthenticationEnabled]):
795         (-[WebPreferences setWebAuthenticationEnabled:]):
796         (-[WebPreferences credentialManagementEnabled]): Deleted.
797         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
798         * WebView/WebPreferencesPrivate.h:
799         * WebView/WebView.mm:
800         (-[WebView _preferencesChanged:]):
801
802 2017-12-22  Jeff Miller  <jeffm@apple.com>
803
804         Update user-visible copyright strings to include 2018
805         https://bugs.webkit.org/show_bug.cgi?id=181141
806
807         Reviewed by Dan Bernstein.
808
809         * Info.plist:
810
811 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
812
813         [Attachment Support] Remove current macOS support for dragging file-backed attachments
814         https://bugs.webkit.org/show_bug.cgi?id=181188
815
816         Reviewed by Dan Bernstein.
817
818         See WebCore/ChangeLog for more detail.
819
820         * WebCoreSupport/WebDragClient.h:
821         * WebCoreSupport/WebDragClient.mm:
822         (WebDragClient::declareAndWriteAttachment): Deleted.
823         * WebView/WebHTMLView.mm:
824         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
825
826 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
827
828         Unreviewed, continue to fix build failures due to AppKit API deprecation
829
830         Wraps more code in -Wdeprecated-declarations.
831
832         * Carbon/HIWebView.mm:
833         (overrideCGContext):
834
835 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
836
837         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
838
839         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
840
841         * Carbon/CarbonWindowAdapter.mm:
842         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
843         * Plugins/WebNetscapePluginView.mm:
844         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
845         (-[WebNetscapePluginView sendDrawRectEvent:]):
846         (-[WebNetscapePluginView drawRect:]):
847
848 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
849
850         Fix build failures due to using deprecated AppKit symbols
851         https://bugs.webkit.org/show_bug.cgi?id=181110
852         <rdar://problem/36162865>
853
854         Reviewed by Dan Bernstein and Tim Horton.
855
856         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
857
858         * Misc/WebKitNSStringExtras.mm:
859         (-[NSString _web_drawAtPoint:font:textColor:]):
860         * Misc/WebNSPasteboardExtras.h:
861         * Misc/WebNSPasteboardExtras.mm:
862         (+[NSPasteboard _web_writableTypesForURL]):
863         (_createWritableTypesForImageWithoutArchive):
864         (_createWritableTypesForImageWithArchive):
865         (+[NSPasteboard _web_dragTypesForURL]):
866         (-[NSPasteboard _web_bestURL]):
867         (-[NSPasteboard _web_writeURL:andTitle:types:]):
868         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
869         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
870         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
871         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
872         * Panels/WebAuthenticationPanel.m:
873         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
874         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
875         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
876         (-[WebHostedNetscapePluginView drawRect:]):
877         * WebInspector/WebNodeHighlightView.mm:
878         (-[WebNodeHighlightView drawRect:]):
879         * WebView/WebFrame.mm:
880         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
881         (-[WebFrame _drawRect:contentsOnly:]):
882         * WebView/WebHTMLView.mm:
883         (kit):
884         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
885         (-[WebHTMLView _plainTextFromPasteboard:]):
886         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
887         (+[WebHTMLView _insertablePasteboardTypes]):
888         (+[WebHTMLView _selectionPasteboardTypes]):
889         (-[WebHTMLView pasteboard:provideDataForType:]):
890         (-[WebHTMLView _writeSelectionToPasteboard:]):
891         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
892         (-[WebHTMLView validRequestorForSendType:returnType:]):
893         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
894         (createMenuItem):
895         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
896         (-[WebHTMLView _colorAsString:]):
897         (-[WebHTMLView copyFont:]):
898         * WebView/WebPDFView.mm:
899         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
900         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
901         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
902         (-[WebPDFView pasteboardTypesForSelection]):
903         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
904         * WebView/WebView.h:
905         * WebView/WebView.mm:
906         (-[WebView performDragOperation:]):
907         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
908         (-[WebView _searchWithGoogleFromMenu:]):
909
910 2017-12-21  Youenn Fablet  <youenn@apple.com>
911
912         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
913         https://bugs.webkit.org/show_bug.cgi?id=181000
914
915         Reviewed by Chris Dumez.
916
917         * Misc/WebCache.mm:
918         (+[WebCache addImageToCache:forURL:forFrame:]):
919
920 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
921
922         Update FULLSCREEN_API feature defines.
923         https://bugs.webkit.org/show_bug.cgi?id=181015
924
925         Reviewed by Tim Horton.
926
927         Change enabled iphone sdk for FULLSCREEN_API.
928
929         * Configurations/FeatureDefines.xcconfig:
930
931 2017-12-21  Jer Noble  <jer.noble@apple.com>
932
933         Add initial DOM support for Media Capabilities
934         https://bugs.webkit.org/show_bug.cgi?id=181064
935
936         Reviewed by Eric Carlson.
937
938         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
939
940         * WebView/WebPreferenceKeysPrivate.h:
941         * WebView/WebPreferences.mm:
942         (+[WebPreferences initialize]):
943         (-[WebPreferences mediaCapabilitiesEnabled]):
944         (-[WebPreferences setMediaCapabilitiesEnabled:]):
945         * WebView/WebPreferencesPrivate.h:
946         * WebView/WebView.mm:
947         (-[WebView _preferencesChanged:]):
948
949 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
950
951         Enable picture-in-picture from inline element on suspend.
952         https://bugs.webkit.org/show_bug.cgi?id=180942
953         rdar://problem/34745234
954
955         Reviewed by Jer Noble.
956
957         Update signature of enterVideoFullscreenForVideoElement().
958
959         * WebCoreSupport/WebChromeClient.h:
960         * WebCoreSupport/WebChromeClient.mm:
961         (WebChromeClient::enterVideoFullscreenForVideoElement):
962
963 2017-12-20  Daniel Bates  <dabates@apple.com>
964
965         Remove Alternative Presentation Button
966         https://bugs.webkit.org/show_bug.cgi?id=180500
967         <rdar://problem/35891047>
968
969         Reviewed by Simon Fraser.
970
971         We no longer need the alternative presentation button.
972
973         * Configurations/FeatureDefines.xcconfig:
974
975 2017-12-19  Jer Noble  <jer.noble@apple.com>
976
977         Playing media elements which call "pause(); play()" will have the play promise rejected.
978         https://bugs.webkit.org/show_bug.cgi?id=180781
979         <rdar://problem/33191377>
980
981         Reviewed by Eric Carlson.
982
983         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
984
985         * WebView/WebView.mm:
986         (shouldRequireUserGestureToLoadVideo):
987
988 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
989
990         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
991         https://bugs.webkit.org/show_bug.cgi?id=180977
992
993         Reviewed by Tim Horton.
994
995         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
996         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
997         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
998
999         * WebCoreSupport/WebEditorClient.mm:
1000         (attributesForAttributedStringConversion):
1001         * WebView/WebHTMLView.mm:
1002         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1003
1004 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1005
1006         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1007
1008         Attempt to fix the following warnings:
1009
1010             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1011
1012         For the following instance variables:
1013
1014             _borderView
1015             _contentView
1016             _frame
1017             _wFlags
1018
1019         * Carbon/CarbonWindowAdapter.mm:
1020         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1021         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1022         (-[CarbonWindowAdapter _termWindowIfOwner]):
1023         (-[CarbonWindowAdapter _windowMovedToRect:]):
1024         (-[CarbonWindowAdapter setContentView:]):
1025         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1026         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1027
1028 2017-12-16  Dan Bernstein  <mitz@apple.com>
1029
1030         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1031         https://bugs.webkit.org/show_bug.cgi?id=180613
1032         <rdar://problem/35946124>
1033
1034         Reviewed by Geoff Garen.
1035
1036         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1037           clients.
1038         * WebView/WebDynamicScrollBarsView.h: Ditto.
1039         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1040
1041 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1042
1043         Enable -Wstrict-prototypes for WebKit
1044         <https://webkit.org/b/180757>
1045         <rdar://problem/36024132>
1046
1047         Rubber-stamped by Joseph Pecoraro.
1048
1049         * Configurations/Base.xcconfig:
1050         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1051
1052 2017-12-14  John Wilander  <wilander@apple.com>
1053
1054         Storage Access API: Implement frame-specific access in the document.cookie layer
1055         https://bugs.webkit.org/show_bug.cgi?id=180682
1056         <rdar://problem/35982257>
1057
1058         Reviewed by Alex Christensen.
1059
1060         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1061         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1062         CookiesStrategy::getRawCookies() now take optional parameters for
1063         frameID and pageID to allow frame-specific scoping of cookies.
1064
1065         This change makes the return values of FrameLoaderClient::frameID()
1066         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1067         WebCore can call those getters and get the right return values in
1068         WebKit and std:nullopt in WebKitLegacy.
1069
1070         * WebCoreSupport/WebFrameLoaderClient.h:
1071         * WebCoreSupport/WebFrameLoaderClient.mm:
1072         (WebFrameLoaderClient::pageID const):
1073         (WebFrameLoaderClient::frameID const):
1074         * WebCoreSupport/WebPlatformStrategies.h:
1075         * WebCoreSupport/WebPlatformStrategies.mm:
1076         (WebPlatformStrategies::cookiesForDOM):
1077         (WebPlatformStrategies::setCookiesFromDOM):
1078         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1079         (WebPlatformStrategies::getRawCookies):
1080
1081 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1082
1083         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1084         https://bugs.webkit.org/show_bug.cgi?id=180689
1085
1086         Reviewed by Tim Horton.
1087
1088         Use sRGBColorSpaceRef() from WebCore.
1089
1090         * WebView/WebHTMLView.mm:
1091         (imageFromRect):
1092
1093 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1094
1095         Stop using deprecated target conditional for simulator builds
1096         https://bugs.webkit.org/show_bug.cgi?id=180662
1097         <rdar://problem/35136156>
1098
1099         Reviewed by Simon Fraser.
1100
1101         * postprocess-headers.sh:
1102
1103 2017-12-11  David Quesada  <david_quesada@apple.com>
1104
1105         Turn on ENABLE_APPLICATION_MANIFEST
1106         https://bugs.webkit.org/show_bug.cgi?id=180562
1107         rdar://problem/35924737
1108
1109         Reviewed by Geoffrey Garen.
1110
1111         * Configurations/FeatureDefines.xcconfig:
1112
1113 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1114
1115         Remove pthread_once in favor of dispatch_once
1116         https://bugs.webkit.org/show_bug.cgi?id=180591
1117
1118         Reviewed by Saam Barati.
1119
1120         * Misc/WebKitErrors.m:
1121         (+[NSError _registerWebKitErrors]):
1122         (registerErrors): Deleted.
1123         * Storage/WebStorageManager.mm:
1124         (+[WebStorageManager _storageDirectoryPath]):
1125         (initializeLocalStoragePath): Deleted.
1126
1127 2017-12-07  Darin Adler  <darin@apple.com>
1128
1129         Remove some unused code from WebKitLegacy
1130         https://bugs.webkit.org/show_bug.cgi?id=180567
1131
1132         Reviewed by Anders Carlsson.
1133
1134         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1135         macOS (back a few versions) and iOS and removed unused
1136         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1137         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1138         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1139         _webkit_stringByCollapsingNonPrintingCharacters,
1140         _webkit_stringByCollapsingWhitespaceCharacters,
1141         _web_stringWithData:textEncodingName:, and
1142         _webkit_localStorageDirectoryWithBundleIdentifier:.
1143
1144         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1145         this source file.
1146         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1147         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1148         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1149         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1150         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1151         handle font smoothing options.
1152         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1153         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1154         from header and made it a little clearer.
1155         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1156         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1157         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1158         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1159         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1160         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1161         implementation a bit and used whole words instead of abbreviations.
1162         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1163
1164         * Misc/WebNSFileManagerExtras.mm:
1165         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1166         filenameByFixingIllegalCharacters function from WebCore directly instead of
1167         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1168
1169         * Plugins/WebBaseNetscapePluginView.mm:
1170         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1171         string replacements instead of _web_stringByStrippingReturnCharacters
1172         and to use NSString methods instead of CFString functions.
1173
1174 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1175
1176         Ignore deprecation warnings.
1177
1178         * WebView/WebHTMLView.mm:
1179         (-[NSWindow _web_borderView]):
1180         (-[WebHTMLView _setAsideSubviews]):
1181         * WebView/WebView.mm:
1182         (-[WebView encodeWithCoder:]):
1183
1184 2017-12-02  Darin Adler  <darin@apple.com>
1185
1186         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1187         https://bugs.webkit.org/show_bug.cgi?id=180009
1188
1189         Reviewed by Alex Christensen.
1190
1191         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1192
1193         * Plugins/WebBaseNetscapePluginView.mm:
1194         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1195         of strcasecmp.
1196
1197         * WebView/WebPreferences.mm:
1198         (contains): Ditto. Also made this a template so it's easier to call on an array.
1199         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1200
1201 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1202
1203         Limit user agent versioning to an upper bound
1204         https://bugs.webkit.org/show_bug.cgi?id=180365
1205         <rdar://problem/34550617>
1206
1207         Reviewed by Joseph Pecoraro.
1208
1209         * WebView/WebView.mm:
1210         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1211         creating the User Agent string.
1212         (webKitBundleVersionString): Deleted.
1213
1214 2017-12-05  Andy Estes  <aestes@apple.com>
1215
1216         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1217         https://bugs.webkit.org/show_bug.cgi?id=180457
1218         <rdar://problem/35143007>
1219
1220         Reviewed by Tim Horton.
1221
1222         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1223         check for this macro during post-processing.
1224
1225         * postprocess-headers.sh:
1226
1227 2017-12-04  David Quesada  <david_quesada@apple.com>
1228
1229         Add a class for parsing application manifests
1230         https://bugs.webkit.org/show_bug.cgi?id=177973
1231         rdar://problem/34747949
1232
1233         Reviewed by Geoffrey Garen.
1234
1235         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1236
1237 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1238
1239         Make LegacyCustomProtocolManager optional for network process
1240         https://bugs.webkit.org/show_bug.cgi?id=176230
1241
1242         Reviewed by Alex Christensen.
1243
1244         * Configurations/FeatureDefines.xcconfig:
1245
1246 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1247
1248         Fix some NSOperationQueue leaks
1249         https://bugs.webkit.org/show_bug.cgi?id=180221
1250
1251         Reviewed by Wenson Hsieh.
1252
1253         * WebView/WebView.mm:
1254         (-[WebView performDragOperation:]):
1255
1256 2017-11-30  Darin Adler  <darin@apple.com>
1257
1258         [Mac] remove unneeded RetainPtr use introduced in r225142
1259         https://bugs.webkit.org/show_bug.cgi?id=180202
1260
1261         Reviewed by Tim Horton.
1262
1263         * WebView/WebImmediateActionController.mm:
1264         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1265         RetainPtr.
1266
1267 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1268
1269         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1270         https://bugs.webkit.org/show_bug.cgi?id=175595
1271
1272         Reviewed by Darin Adler.
1273
1274         * WebView/WebPreferences.mm:
1275
1276 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1277
1278         One too many zeroes in macOS version number in FeatureDefines
1279         https://bugs.webkit.org/show_bug.cgi?id=180011
1280
1281         Reviewed by Dan Bernstein.
1282
1283         * Configurations/FeatureDefines.xcconfig:
1284
1285 2017-11-23  Darin Adler  <darin@apple.com>
1286
1287         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1288         https://bugs.webkit.org/show_bug.cgi?id=179981
1289
1290         Reviewed by Sam Weinig.
1291
1292         * WebView/WebImmediateActionController.mm:
1293         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1294         * WebView/WebView.mm:
1295         (coreOptions): Use |= instead of | to build up FindOptions.
1296
1297 2017-11-23  Sam Weinig  <sam@webkit.org>
1298
1299         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1300         https://bugs.webkit.org/show_bug.cgi?id=179954
1301
1302         Reviewed by Darin Adler.
1303
1304         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1305         with direct calls to the corresponding UserGestureIndicator functions.
1306
1307         * Plugins/WebPluginController.mm:
1308         (-[WebPluginController processingUserGesture]):
1309         * WebView/WebView.mm:
1310         (-[WebView _isProcessingUserGesture]):
1311
1312 2017-11-23  Darin Adler  <darin@apple.com>
1313
1314         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1315         https://bugs.webkit.org/show_bug.cgi?id=179907
1316
1317         Reviewed by Sam Weinig.
1318
1319         * History/BinaryPropertyList.cpp:
1320         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1321         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1322         * WebView/WebHTMLRepresentation.mm:
1323         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1324         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1325
1326 2017-11-22  Ali Juma  <ajuma@chromium.org>
1327
1328         Implement VisualViewport API attributes
1329         https://bugs.webkit.org/show_bug.cgi?id=179385
1330
1331         Reviewed by Frédéric Wang.
1332
1333         Add a VisualViewportAPI preference.
1334
1335         * WebView/WebPreferenceKeysPrivate.h:
1336         * WebView/WebPreferences.mm:
1337         (+[WebPreferences initialize]):
1338         (-[WebPreferences visualViewportAPIEnabled]):
1339         (-[WebPreferences setVisualViewportAPIEnabled:]):
1340         * WebView/WebPreferencesPrivate.h:
1341         * WebView/WebView.mm:
1342         (-[WebView _preferencesChanged:]):
1343
1344 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1345
1346         WebCoreObjCExtras.h is being included in too many places
1347         https://bugs.webkit.org/show_bug.cgi?id=179931
1348
1349         Reviewed by Darin Adler.
1350
1351         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1352         * Plugins/WebBaseNetscapePluginView.mm:
1353         * Plugins/WebBasePluginPackage.mm:
1354         * Plugins/WebNetscapePluginStream.mm:
1355         * Plugins/WebNetscapePluginView.mm:
1356         * WebView/WebTextIterator.mm:
1357         * WebView/WebViewData.mm:
1358
1359 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1360
1361         Unreviewed, rolling out r225093.
1362         https://bugs.webkit.org/show_bug.cgi?id=179938
1363
1364         Compilation failed on WinCairo 64-bit Release (Requested by
1365         fredw on #webkit).
1366
1367         Reverted changeset:
1368
1369         "Implement VisualViewport API attributes"
1370         https://bugs.webkit.org/show_bug.cgi?id=179385
1371         https://trac.webkit.org/changeset/225093
1372
1373 2017-11-21  Ali Juma  <ajuma@chromium.org>
1374
1375         Implement VisualViewport API attributes
1376         https://bugs.webkit.org/show_bug.cgi?id=179385
1377
1378         Reviewed by Frédéric Wang.
1379
1380         Add a VisualViewportAPI preference.
1381
1382         * WebView/WebPreferenceKeysPrivate.h:
1383         * WebView/WebPreferences.mm:
1384         (+[WebPreferences initialize]):
1385         (-[WebPreferences visualViewportAPIEnabled]):
1386         (-[WebPreferences setVisualViewportAPIEnabled:]):
1387         * WebView/WebPreferencesPrivate.h:
1388         * WebView/WebView.mm:
1389         (-[WebView _preferencesChanged:]):
1390
1391 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1392
1393         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1394         https://bugs.webkit.org/show_bug.cgi?id=179504
1395
1396         Reviewed by Darin Adler.
1397
1398         * Misc/WebKitNSStringExtras.mm:
1399         * Plugins/Hosted/NetscapePluginHostManager.mm:
1400         * Plugins/WebBasePluginPackage.mm:
1401
1402 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1403
1404         Remove unused TOUCH_ICON_LOADING feature flag
1405         https://bugs.webkit.org/show_bug.cgi?id=179873
1406
1407         Reviewed by Simon Fraser.
1408
1409         * Configurations/FeatureDefines.xcconfig:
1410
1411 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1412
1413         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1414         https://bugs.webkit.org/show_bug.cgi?id=179872
1415
1416         Reviewed by Darin Adler.
1417
1418         * Configurations/FeatureDefines.xcconfig:
1419
1420 2017-11-16  Daniel Bates  <dabates@apple.com>
1421
1422         Add feature define for alternative presentation button element
1423         https://bugs.webkit.org/show_bug.cgi?id=179692
1424         Part of <rdar://problem/34917108>
1425
1426         Reviewed by Andy Estes.
1427
1428         Only enabled on Cocoa platforms by default.
1429
1430         * Configurations/FeatureDefines.xcconfig:
1431
1432 2017-11-14  Nan Wang  <n_wang@apple.com>
1433
1434         AX: AOM: Implement AccessibleNode class and support label and role attributes
1435         https://bugs.webkit.org/show_bug.cgi?id=179494
1436
1437         Reviewed by Ryosuke Niwa.
1438
1439         * WebView/WebPreferenceKeysPrivate.h:
1440         * WebView/WebPreferences.mm:
1441         (+[WebPreferences initialize]):
1442         (-[WebPreferences accessibilityObjectModelEnabled]):
1443         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1444         * WebView/WebPreferencesPrivate.h:
1445         * WebView/WebView.mm:
1446         (-[WebView _preferencesChanged:]):
1447
1448 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1449
1450         Remove Cocoa CFURLConnection loading code
1451         https://bugs.webkit.org/show_bug.cgi?id=179688
1452
1453         Reviewed by Antti Koivisto.
1454
1455         * Misc/WebDownload.mm:
1456         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1457         * Misc/WebDownloadInternal.h:
1458         * Plugins/WebBaseNetscapePluginView.mm:
1459         * WebCoreSupport/WebFrameLoaderClient.mm:
1460         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1461         * WebView/WebView.mm:
1462         (-[WebView scheduleInRunLoop:forMode:]):
1463         (-[WebView unscheduleFromRunLoop:forMode:]):
1464
1465 2017-11-14  Daniel Bates  <dabates@apple.com>
1466
1467         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1468         for feature defines
1469
1470         Following r195498 and r201917 the Visual Studio property files for feature defines have
1471         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1472         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1473         files.
1474
1475         * Configurations/FeatureDefines.xcconfig:
1476
1477 2017-11-14  Jer Noble  <jer.noble@apple.com>
1478
1479         Enable Modern EME tests in DumpRenderTree
1480         https://bugs.webkit.org/show_bug.cgi?id=179544
1481
1482         Reviewed by Alex Christensen.
1483
1484         Add a WebPreferences property to enable the (modern) EME API.
1485
1486         * WebView/WebPreferenceKeysPrivate.h:
1487         * WebView/WebPreferences.mm:
1488         (+[WebPreferences initialize]):
1489         (-[WebPreferences encryptedMediaAPIEnabled]):
1490         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1491         * WebView/WebPreferencesPrivate.h:
1492         * WebView/WebView.mm:
1493         (-[WebView _preferencesChanged:]):
1494
1495 2017-11-14  Antti Koivisto  <antti@apple.com>
1496
1497         Enable display:contents by default
1498         https://bugs.webkit.org/show_bug.cgi?id=179655
1499
1500         Reviewed by Sam Weinig.
1501
1502         * WebView/WebPreferences.mm:
1503         (+[WebPreferences initialize]):
1504
1505 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1506
1507         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1508         https://bugs.webkit.org/show_bug.cgi?id=178751
1509
1510         Reviewed by Brady Eidson.
1511
1512         * WebCoreSupport/WebFrameNetworkingContext.mm:
1513         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1514
1515 2017-11-08  Keith Miller  <keith_miller@apple.com>
1516
1517         Async iteration should only fetch the next method once and add feature flag
1518         https://bugs.webkit.org/show_bug.cgi?id=179451
1519
1520         Reviewed by Geoffrey Garen.
1521
1522         Add feature flag for Async iteration.
1523
1524         * Configurations/FeatureDefines.xcconfig:
1525
1526 2017-11-13  Mark Lam  <mark.lam@apple.com>
1527
1528         Add more overflow check book-keeping for MarkedArgumentBuffer.
1529         https://bugs.webkit.org/show_bug.cgi?id=179634
1530         <rdar://problem/35492517>
1531
1532         Reviewed by Saam Barati.
1533
1534         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1535         (WebKit::NetscapePluginInstanceProxy::invoke):
1536         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1537         (WebKit::NetscapePluginInstanceProxy::construct):
1538
1539 2017-11-12  Darin Adler  <darin@apple.com>
1540
1541         More is<> and downcast<>, less static_cast<>
1542         https://bugs.webkit.org/show_bug.cgi?id=179600
1543
1544         Reviewed by Chris Dumez.
1545
1546         * DOM/DOM.mm:
1547         (kit): Use is/downcast.
1548         * WebCoreSupport/WebEditorClient.mm:
1549         (WebEditorClient::handleKeyboardEvent): Ditto.
1550         (WebEditorClient::handleInputMethodKeydown): Ditto.
1551         * WebView/WebHTMLView.mm:
1552         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
1553
1554 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
1555
1556         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
1557         https://bugs.webkit.org/show_bug.cgi?id=179397
1558
1559         Reviewed by Wenson Hsieh.
1560
1561         * DOM/DOMHTMLInputElement.mm:
1562         (-[DOMHTMLInputElement insertTextSuggestion:]):
1563
1564 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
1565
1566         HTMLMediaElement should not use element fullscreen on iOS
1567         https://bugs.webkit.org/show_bug.cgi?id=179418
1568         rdar://problem/35409277
1569
1570         Reviewed by Eric Carlson.
1571
1572         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
1573
1574         * Configurations/FeatureDefines.xcconfig:
1575
1576 2017-11-06  Alex Christensen  <achristensen@webkit.org>
1577
1578         Make ResourceLoader::willSendRequestInternal asynchronous
1579         https://bugs.webkit.org/show_bug.cgi?id=179251
1580
1581         Reviewed by Andy Estes.
1582
1583         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1584         (WebKit::HostedNetscapePluginStream::start):
1585         * Plugins/WebNetscapePluginStream.mm:
1586         (WebNetscapePluginStream::start):
1587
1588 2017-11-01  Darin Adler  <darin@apple.com>
1589
1590         Simplify event dispatch code and make it a bit more consistent
1591         https://bugs.webkit.org/show_bug.cgi?id=178991
1592
1593         Reviewed by Chris Dumez.
1594
1595         * DOM/DOMEvent.mm:
1596         (-[DOMEvent srcElement]): Call target instead of srcElement.
1597
1598 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
1599
1600         [Touch Bar Web API] Add support for menuitem tag
1601         https://bugs.webkit.org/show_bug.cgi?id=179020
1602
1603         Reviewed by Ryosuke Niwa.
1604
1605         Adds in properties and methods that allow the menuitem runtime feature
1606         to be enabled or disabled.
1607
1608         * WebView/WebPreferenceKeysPrivate.h:
1609         * WebView/WebPreferences.mm:
1610         (-[WebPreferences menuItemElementEnabled]):
1611         (-[WebPreferences setMenuItemElementEnabled:]):
1612         * WebView/WebPreferencesPrivate.h:
1613         * WebView/WebView.mm:
1614         (-[WebView _preferencesChanged:]):
1615
1616 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1617
1618         Use CompletionHandlers for redirects
1619         https://bugs.webkit.org/show_bug.cgi?id=179163
1620
1621         Reviewed by Tim Horton.
1622
1623         * Plugins/Hosted/HostedNetscapePluginStream.h:
1624         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1625         (WebKit::HostedNetscapePluginStream::willSendRequest):
1626         * Plugins/WebNetscapePluginStream.h:
1627         * Plugins/WebNetscapePluginStream.mm:
1628         (WebNetscapePluginStream::willSendRequest):
1629
1630 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1631
1632         Add a FileSystem namespace to FileSystem.cpp
1633         https://bugs.webkit.org/show_bug.cgi?id=179063
1634
1635         Reviewed by Darin Adler.
1636
1637         * Misc/WebNSFileManagerExtras.mm:
1638         * Storage/WebDatabaseProvider.mm:
1639
1640 2017-11-02  Frederic Wang  <fwang@igalia.com>
1641
1642         Add references to bug 179167 in FIXME comments
1643         https://bugs.webkit.org/show_bug.cgi?id=179168
1644
1645         Reviewed by Daniel Bates.
1646
1647         * Configurations/FeatureDefines.xcconfig:
1648
1649 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
1650
1651         Implement WKFullscreenWindowController for iOS.
1652         https://bugs.webkit.org/show_bug.cgi?id=178924
1653         rdar://problem/34697120
1654
1655         Reviewed by Simon Fraser.
1656
1657         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
1658
1659         * Configurations/FeatureDefines.xcconfig:
1660         * WebView/WebView.mm:
1661         (-[WebView fullScreenPlaceholderView]):
1662
1663 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1664
1665         Clean up some drag and drop feature flags
1666         https://bugs.webkit.org/show_bug.cgi?id=179082
1667
1668         Reviewed by Simon Fraser.
1669
1670         * Configurations/FeatureDefines.xcconfig:
1671
1672 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
1673
1674         Make it possible to test rubber-banding in overflow scroll
1675         https://bugs.webkit.org/show_bug.cgi?id=179078
1676
1677         Reviewed by Sam Weinig.
1678
1679         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
1680         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
1681
1682         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
1683         functions, since most callers want clamped.
1684
1685         * DOM/DOMHTML.mm:
1686         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
1687
1688 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1689
1690         Fix up some content filtering feature flags
1691         https://bugs.webkit.org/show_bug.cgi?id=179079
1692
1693         Reviewed by Simon Fraser.
1694
1695         * Configurations/FeatureDefines.xcconfig:
1696
1697 2017-10-28  Zalan Bujtas  <zalan@apple.com>
1698
1699         [FrameView::layout cleanup] Move core layout logic to a separate class.
1700         https://bugs.webkit.org/show_bug.cgi?id=178771
1701         <rdar://problem/35166542>
1702
1703         Reviewed by Simon Fraser.
1704
1705         Move layout code out from FrameView to LayoutContext.
1706
1707         * WebView/WebClipView.mm:
1708         (-[WebClipView _immediateScrollToPoint:]):
1709         * WebView/WebFrame.mm:
1710         (-[WebFrame layoutCount]):
1711
1712 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
1713
1714         Fix issues with WebView subframe painting
1715         https://bugs.webkit.org/show_bug.cgi?id=178842
1716         rdar://problem/34072253
1717
1718         Reviewed by Daniel Bates.
1719         
1720         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
1721         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
1722         High Sierra, so match the new signature.
1723
1724         Also rename the 'rect' param to 'displayRect' to match AppKit code.
1725
1726         * WebView/WebHTMLView.mm:
1727         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1728         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1729
1730 2017-10-25  Youenn Fablet  <youenn@apple.com>
1731
1732         Enable ServiceWorker to fetch resources
1733         https://bugs.webkit.org/show_bug.cgi?id=178673
1734
1735         Reviewed by Brady Eidson.
1736
1737         * WebCoreSupport/WebFrameLoaderClient.mm:
1738         (WebFrameLoaderClient::pageID const):
1739         (WebFrameLoaderClient::frameID const):
1740         (WebFrameLoaderClient::sessionID const):
1741
1742         Added implementation to the new getters.
1743         They are noop in the context of WK1.
1744
1745 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
1746
1747         Web Inspector: Enable WebKit logging configuration and display
1748         https://bugs.webkit.org/show_bug.cgi?id=177027
1749         <rdar://problem/33964767>
1750
1751         Reviewed by Joseph Pecoraro.
1752
1753         * WebCoreSupport/WebChromeClient.mm:
1754         (stringForMessageSource): Deal with Media and WebRTC message sources.
1755
1756 2017-10-20  Antoine Quint  <graouts@apple.com>
1757
1758         [Web Animations] Provide basic timeline and animation interfaces
1759         https://bugs.webkit.org/show_bug.cgi?id=178526
1760
1761         Reviewed by Dean Jackson.
1762
1763         Remove the WEB_ANIMATIONS compile-time flag.
1764
1765         * Configurations/FeatureDefines.xcconfig:
1766         * WebView/WebPreferences.mm:
1767         (+[WebPreferences initialize]):
1768         * WebView/WebView.mm:
1769         (-[WebView _preferencesChanged:]):
1770
1771 2017-10-19  Sam Weinig  <sam@webkit.org>
1772
1773         [Settings] Move global settings into their own file
1774         https://bugs.webkit.org/show_bug.cgi?id=178512
1775
1776         Reviewed by Darin Adler.
1777
1778         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
1779
1780         * WebCoreSupport/WebChromeClient.mm:
1781         (WebChromeClient::supportsVideoFullscreen):
1782         * WebView/WebDynamicScrollBarsView.mm:
1783         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
1784         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
1785         * WebView/WebPreferences.mm:
1786         (+[WebPreferences initialize]):
1787         * WebView/WebView.mm:
1788         (-[WebView _commonInitializationWithFrameName:groupName:]):
1789         (-[WebView _preferencesChanged:]):
1790         (+[WebView _doNotStartObservingNetworkReachability]):
1791
1792 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
1793
1794         Replace some stack raw pointers with RefPtrs within WebCore/html
1795         https://bugs.webkit.org/show_bug.cgi?id=178201
1796         <rdar://problem/34841692>
1797
1798         Reviewed by Ryosuke Niwa.
1799
1800         * DOM/DOM.mm:
1801         (kit):
1802         Change the type of node as toNode() is changed to return RefPtr.
1803
1804 2017-10-18  Chris Dumez  <cdumez@apple.com>
1805
1806         [Service Worker] Add stubs for Client / WindowClient / Clients
1807         https://bugs.webkit.org/show_bug.cgi?id=178469
1808
1809         Reviewed by Youenn Fablet.
1810
1811         Rename PageVisiblityState to VisibilityState.
1812
1813         * WebView/WebView.mm:
1814         (kit):
1815
1816 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1817
1818         Unreviewed, rolling out r223291.
1819
1820         See WebCore ChangeLog for more detail.
1821
1822         Reverted changeset:
1823
1824         "Remove Editor::simplifyMarkup"
1825         https://bugs.webkit.org/show_bug.cgi?id=178271
1826         https://trac.webkit.org/changeset/223291
1827
1828 2017-10-17  Keith Miller  <keith_miller@apple.com>
1829
1830         Change WebCore sources to work with unified source builds
1831         https://bugs.webkit.org/show_bug.cgi?id=178229
1832
1833         Rubber stamped by Tim Horton.
1834
1835         * Configurations/FeatureDefines.xcconfig:
1836
1837 2017-10-16  Sam Weinig  <sam@webkit.org>
1838
1839         [Settings] Remove all custom code from Settings.h/cpp
1840         https://bugs.webkit.org/show_bug.cgi?id=178330
1841
1842         Reviewed by Simon Fraser.
1843
1844         * WebView/WebPreferences.mm:
1845         (+[WebPreferences initialize]):
1846         
1847             Update for naming changes of FrameFlattening now that it is an enum class.
1848
1849 2017-10-13  Alex Christensen  <achristensen@webkit.org>
1850
1851         Remove Editor::simplifyMarkup
1852         https://bugs.webkit.org/show_bug.cgi?id=178271
1853
1854         Reviewed by Wenson Hsieh.
1855
1856         * WebView/WebView.mm:
1857         (-[WebView _simplifyMarkup:endNode:]):
1858
1859 2017-10-12  Chris Dumez  <cdumez@apple.com>
1860
1861         [Mac] Add support for MouseEvent.buttons
1862         https://bugs.webkit.org/show_bug.cgi?id=178214
1863
1864         Reviewed by Ryosuke Niwa.
1865
1866         * WebView/WebPDFView.mm:
1867         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1868
1869 2017-10-11  Sam Weinig  <sam@webkit.org>
1870
1871         Remove out-parameter variants of copyToVector
1872         https://bugs.webkit.org/show_bug.cgi?id=178155
1873
1874         Reviewed by Tim Horton.
1875
1876         * Plugins/WebNetscapePluginView.mm:
1877         (-[WebNetscapePluginView destroyPlugin]):
1878         * WebView/WebHTMLRepresentation.mm:
1879         (newArrayWithStrings):
1880
1881             Replace out-parameter based copyToVector, with one that returns a Vector.
1882
1883 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
1884
1885         Sanitize URL in pasteboard for other applications and cross origin content
1886         https://bugs.webkit.org/show_bug.cgi?id=178060
1887         <rdar://problem/34874518>
1888
1889         Reviewed by Wenson Hsieh.
1890
1891         * WebCoreSupport/WebPlatformStrategies.h:
1892         * WebCoreSupport/WebPlatformStrategies.mm:
1893         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
1894
1895 2017-10-11  Chris Dumez  <cdumez@apple.com>
1896
1897         Modernize Geolocation code
1898         https://bugs.webkit.org/show_bug.cgi?id=178148
1899
1900         Reviewed by Ryosuke Niwa.
1901
1902         * WebCoreSupport/WebGeolocationClient.h:
1903         * WebCoreSupport/WebGeolocationClient.mm:
1904         (WebGeolocationClient::lastPosition):
1905         * WebView/WebGeolocationPosition.mm:
1906         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
1907         (core):
1908         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
1909         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1910         * WebView/WebGeolocationPositionInternal.h:
1911
1912 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
1913
1914         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
1915         https://bugs.webkit.org/show_bug.cgi?id=178154
1916
1917         Reviewed by Wenson Hsieh.
1918
1919         Enable custom pasteboard data by default.
1920
1921         * WebView/WebPreferenceKeysPrivate.h:
1922         * WebView/WebPreferences.mm:
1923         (+[WebPreferences initialize]):
1924         (-[WebPreferences customPasteboardDataEnabled]): Added.
1925         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
1926         * WebView/WebPreferencesPrivate.h:
1927         * WebView/WebView.mm:
1928         (-[WebView _preferencesChanged:]):
1929
1930 2017-10-10  Sam Weinig  <sam@webkit.org>
1931
1932         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
1933         https://bugs.webkit.org/show_bug.cgi?id=178102
1934
1935         Reviewed by Tim Horton.
1936
1937         * History/WebHistory.mm:
1938         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
1939         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1940         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
1941         * WebCoreSupport/WebUserMediaClient.mm:
1942         (WebUserMediaClient::pageDestroyed):
1943
1944 2017-10-09  Robin Morisset  <rmorisset@apple.com>
1945
1946         Make the names of the options consistent
1947         https://bugs.webkit.org/show_bug.cgi?id=177933
1948
1949         Reviewed by Saam Barati.
1950
1951         * WebView/WebFrame.h:
1952         * WebView/WebHTMLView.mm:
1953         (-[WebHTMLView setMarkedText:selectedRange:]):
1954         * WebView/WebView.h:
1955
1956 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1957
1958         [iOS] Tweak support for classifying form controls (followup to r222487)
1959         https://bugs.webkit.org/show_bug.cgi?id=177917
1960         <rdar://problem/34820122>
1961
1962         Reviewed by Dean Jackson.
1963
1964         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
1965
1966         * DOM/DOMHTMLInputElement.mm:
1967         (-[DOMHTMLInputElement _autofillContext]):
1968         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
1969         (-[DOMHTMLInputElement representingPageURL]): Deleted.
1970
1971 2017-10-05  Keith Miller  <keith_miller@apple.com>
1972
1973         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
1974
1975         * Configurations/WebKitLegacy.xcconfig:
1976
1977 2017-10-05  Jer Noble  <jer.noble@apple.com>
1978
1979         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
1980         https://bugs.webkit.org/show_bug.cgi?id=177261
1981
1982         Reviewed by Eric Carlson.
1983
1984         * Configurations/FeatureDefines.xcconfig:
1985
1986 2017-10-05  Chris Dumez  <cdumez@apple.com>
1987
1988         Drop unused parameters for CookiesStrategy::cookiesEnabled()
1989         https://bugs.webkit.org/show_bug.cgi?id=177957
1990
1991         Reviewed by Alex Christensen.
1992
1993         * WebCoreSupport/WebPlatformStrategies.h:
1994         * WebCoreSupport/WebPlatformStrategies.mm:
1995         (WebPlatformStrategies::cookiesEnabled):
1996
1997 2017-10-05  Youenn Fablet  <youenn@apple.com>
1998
1999         Make LibWebRTCProvider port agnostic
2000         https://bugs.webkit.org/show_bug.cgi?id=177747
2001
2002         Reviewed by Alex Christensen & Alex Garcia.
2003
2004         * WebView/WebView.mm:
2005         (-[WebView _commonInitializationWithFrameName:groupName:]):
2006         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2007
2008 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2009
2010         Stop linking with WebKitSystemInterface
2011         https://bugs.webkit.org/show_bug.cgi?id=177915
2012
2013         Reviewed by Antti Koivisto.
2014
2015         * Configurations/DebugRelease.xcconfig:
2016         * Configurations/WebKitLegacy.xcconfig:
2017
2018 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2019
2020         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2021         https://bugs.webkit.org/show_bug.cgi?id=177912
2022
2023         Reviewed by Saam Barati.
2024
2025         * Carbon/CarbonUtils.m:
2026         * Carbon/CarbonWindowAdapter.mm:
2027         * Carbon/HIWebView.mm:
2028         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2029         * Misc/WebNSFileManagerExtras.mm:
2030         * Misc/WebNSPasteboardExtras.mm:
2031         * Misc/WebNSURLExtras.mm:
2032         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2033         * Plugins/Hosted/NetscapePluginHostManager.mm:
2034         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2035         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2036         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2037         * Plugins/Hosted/WebTextInputWindowController.m:
2038         * Plugins/WebBaseNetscapePluginView.mm:
2039         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2040         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2041         * Plugins/WebNetscapePluginStream.mm:
2042         * Plugins/WebNetscapePluginView.mm:
2043         * Plugins/WebPluginDatabase.mm:
2044         * WebCoreSupport/PopupMenuMac.mm:
2045         * WebCoreSupport/WebChromeClient.mm:
2046         * WebCoreSupport/WebFrameLoaderClient.mm:
2047         * WebCoreSupport/WebInspectorClient.mm:
2048         * WebCoreSupport/WebPlatformStrategies.mm:
2049         * WebCoreSupport/WebSystemInterface.mm:
2050         * WebView/WebDynamicScrollBarsView.mm:
2051         * WebView/WebFrame.mm:
2052         * WebView/WebFrameView.mm:
2053         * WebView/WebFullScreenController.mm:
2054         * WebView/WebHTMLView.mm:
2055         * WebView/WebPreferences.mm:
2056         * WebView/WebView.mm:
2057
2058 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2059
2060         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2061         rdar://problem/34705779
2062
2063         Addressing review comments that I somehow landed without.
2064
2065         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2066
2067 2017-09-29  Chris Dumez  <cdumez@apple.com>
2068
2069         Split some logic out of VisitedLinkStore and make it reusable
2070         https://bugs.webkit.org/show_bug.cgi?id=177575
2071
2072         Reviewed by Alex Christensen.
2073
2074         * WebCoreSupport/WebVisitedLinkStore.h:
2075         * WebCoreSupport/WebVisitedLinkStore.mm:
2076         (WebVisitedLinkStore::addVisitedLink):
2077         (WebVisitedLinkStore::removeVisitedLink):
2078         (WebVisitedLinkStore::isLinkVisited):
2079         (WebVisitedLinkStore::addVisitedLinkHash):
2080
2081 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2082
2083         Build fix for High Sierra 32 bit Mac
2084         https://bugs.webkit.org/show_bug.cgi?id=177551
2085         <rdar://problem/34690283>
2086
2087         Reviewed by Alexey Proskuryakov.
2088
2089         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2090         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2091         also made.
2092
2093         * Carbon/CarbonWindowAdapter.mm:
2094         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2095         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2096         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2097         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2098         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2099         (-[CarbonWindowAdapter dealloc]):
2100         (-[CarbonWindowAdapter windowRef]):
2101         (-[CarbonWindowAdapter _hasWindowRef]):
2102         (-[CarbonWindowAdapter _managesWindowRef]):
2103         (-[CarbonWindowAdapter _removeWindowRef]):
2104         (-[CarbonWindowAdapter _carbonWindowClass]):
2105         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2106         (-[CarbonWindowAdapter sendSuperEvent:]):
2107         (-[CarbonWindowAdapter relinquishFocus]):
2108         (-[CarbonWindowAdapter _cancelKey:]):
2109         (-[CarbonWindowAdapter _commonAwake]):
2110         (-[CarbonWindowAdapter _destroyRealWindow:]):
2111         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2112         (-[CarbonWindowAdapter _termWindowIfOwner]):
2113         (-[CarbonWindowAdapter _windowMovedToRect:]):
2114         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2115         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2116         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2117         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2118         (-[CarbonWindowAdapter canBecomeMainWindow]):
2119         (-[CarbonWindowAdapter encodeWithCoder:]):
2120         (-[CarbonWindowAdapter initWithCoder:]):
2121         (-[CarbonWindowAdapter setContentView:]):
2122         (-[CarbonWindowAdapter worksWhenModal]):
2123         (-[CarbonWindowAdapter _setModalWindowLevel]):
2124         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2125         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2126         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2127         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2128         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2129         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2130         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2131         (NSCarbonWindowHandleEvent):
2132         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2133         (-[CarbonWindowAdapter _growBoxRect]):
2134         * Carbon/HIWebView.mm:
2135         (HIWebViewGetWebView):
2136         (HIWebViewConstructor):
2137         (HIWebViewDestructor):
2138         (HIWebViewRegisterClass):
2139         (GetBehaviors):
2140         (Draw):
2141         (HitTest):
2142         (GetRegion):
2143         (GetWindowRef):
2144         (CreateNSEventAdoptingCGEvent):
2145         (CopyEventCGEvent):
2146         (CreateNSEventWithCarbonClickEvent):
2147         (Click):
2148         (CreateNSEventWithCarbonEvent):
2149         (MouseUp):
2150         (CreateNSEventWithCarbonMouseMoveEvent):
2151         (MouseMoved):
2152         (MouseDragged):
2153         (MouseWheelMoved):
2154         (ContextMenuClick):
2155         (GetKind):
2156         (BoundsChanged):
2157         (OwningWindowChanged):
2158         (WindowHandler):
2159         (SyncFrame):
2160         (SetFocusPart):
2161         (AdvanceFocus):
2162         (RelinquishFocus):
2163         (ActiveStateChanged):
2164         (ProcessCommand):
2165         (UpdateCommandStatus):
2166         (_NSSelectorForHICommand):
2167         (HIWebViewEventHandler):
2168         (StartUpdateObserver):
2169         (StopUpdateObserver):
2170         (UpdateObserver):
2171
2172 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2173
2174         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2175         https://bugs.webkit.org/show_bug.cgi?id=172526
2176         <rdar://problem/32396081>
2177
2178         Reviewed by Ryosuke Niwa.
2179
2180         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2181
2182         * WebCoreSupport/WebPlatformStrategies.h:
2183         * WebCoreSupport/WebPlatformStrategies.mm:
2184         (WebPlatformStrategies::webExposedTypes):
2185         (WebPlatformStrategies::writeCustomData):
2186
2187 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2188
2189         Unreviewed, rolling out r222567.
2190
2191         This broke and internal build.
2192
2193         Reverted changeset:
2194
2195         "Build fix for High Sierra 32 bit Mac"
2196         https://bugs.webkit.org/show_bug.cgi?id=177551
2197         http://trac.webkit.org/changeset/222567
2198
2199 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2200
2201         Build fix for High Sierra 32 bit Mac
2202         https://bugs.webkit.org/show_bug.cgi?id=177551
2203         <rdar://problem/34690283>
2204
2205         Reviewed by Alexey Proskuryakov.
2206
2207         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2208         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2209         also made.
2210
2211         * Carbon/CarbonWindowAdapter.mm:
2212         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2213         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2214         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2215         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2216         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2217         (-[CarbonWindowAdapter dealloc]):
2218         (-[CarbonWindowAdapter windowRef]):
2219         (-[CarbonWindowAdapter _hasWindowRef]):
2220         (-[CarbonWindowAdapter _managesWindowRef]):
2221         (-[CarbonWindowAdapter _removeWindowRef]):
2222         (-[CarbonWindowAdapter _carbonWindowClass]):
2223         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2224         (-[CarbonWindowAdapter sendSuperEvent:]):
2225         (-[CarbonWindowAdapter relinquishFocus]):
2226         (-[CarbonWindowAdapter _cancelKey:]):
2227         (-[CarbonWindowAdapter _commonAwake]):
2228         (-[CarbonWindowAdapter _destroyRealWindow:]):
2229         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2230         (-[CarbonWindowAdapter _termWindowIfOwner]):
2231         (-[CarbonWindowAdapter _windowMovedToRect:]):
2232         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2233         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2234         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2235         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2236         (-[CarbonWindowAdapter canBecomeMainWindow]):
2237         (-[CarbonWindowAdapter encodeWithCoder:]):
2238         (-[CarbonWindowAdapter initWithCoder:]):
2239         (-[CarbonWindowAdapter setContentView:]):
2240         (-[CarbonWindowAdapter worksWhenModal]):
2241         (-[CarbonWindowAdapter _setModalWindowLevel]):
2242         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2243         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2244         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2245         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2246         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2247         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2248         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2249         (NSCarbonWindowHandleEvent):
2250         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2251         (-[CarbonWindowAdapter _growBoxRect]):
2252         * Carbon/HIWebView.mm:
2253         (HIWebViewGetWebView):
2254         (HIWebViewConstructor):
2255         (HIWebViewDestructor):
2256         (HIWebViewRegisterClass):
2257         (GetBehaviors):
2258         (Draw):
2259         (HitTest):
2260         (GetRegion):
2261         (GetWindowRef):
2262         (CreateNSEventAdoptingCGEvent):
2263         (CopyEventCGEvent):
2264         (CreateNSEventWithCarbonClickEvent):
2265         (Click):
2266         (CreateNSEventWithCarbonEvent):
2267         (MouseUp):
2268         (CreateNSEventWithCarbonMouseMoveEvent):
2269         (MouseMoved):
2270         (MouseDragged):
2271         (MouseWheelMoved):
2272         (ContextMenuClick):
2273         (GetKind):
2274         (BoundsChanged):
2275         (OwningWindowChanged):
2276         (WindowHandler):
2277         (SyncFrame):
2278         (SetFocusPart):
2279         (AdvanceFocus):
2280         (RelinquishFocus):
2281         (ActiveStateChanged):
2282         (ProcessCommand):
2283         (UpdateCommandStatus):
2284         (_NSSelectorForHICommand):
2285         (HIWebViewEventHandler):
2286         (StartUpdateObserver):
2287         (StopUpdateObserver):
2288         (UpdateObserver):
2289
2290 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2291
2292         Make PolicyAction an encodable enum class
2293         https://bugs.webkit.org/show_bug.cgi?id=177480
2294
2295         Reviewed by Antti Koivisto.
2296
2297         * Plugins/WebPluginContainerCheck.mm:
2298         (-[WebPluginContainerCheck _continueWithPolicy:]):
2299         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2300         * WebCoreSupport/WebFrameLoaderClient.mm:
2301         (-[WebFramePolicyListener invalidate]):
2302         (-[WebFramePolicyListener ignore]):
2303         (-[WebFramePolicyListener download]):
2304         (-[WebFramePolicyListener use]):
2305         (-[WebFramePolicyListener continue]):
2306         * WebView/WebPolicyDelegate.mm:
2307         (-[WebPolicyDecisionListener use]):
2308         (-[WebPolicyDecisionListener ignore]):
2309         (-[WebPolicyDecisionListener download]):
2310
2311 2017-09-25  Frederik Riedel  <riedel@apple.com>
2312
2313         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2314         https://bugs.webkit.org/show_bug.cgi?id=174394
2315         <rdar://problem/33183504>
2316
2317         Reviewed by Ryosuke Niwa.
2318
2319         * DOM/DOMHTMLInputElement.h:
2320         * DOM/DOMHTMLInputElement.mm:
2321         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2322         Determines if this HTMLInputElement is part of a login screen.
2323         (-[DOMHTMLInputElement representingPageUrl]):
2324         Returns the webpage's URL that is currently displayed in the Web View.
2325         (-[DOMHTMLInputElement insertTextSuggestion:]):
2326         Inserts login credentials into the Web View.
2327
2328 2017-09-25  Sam Weinig  <sam@webkit.org>
2329
2330         Remove unused EditorClient functions
2331         https://bugs.webkit.org/show_bug.cgi?id=177463
2332
2333         Reviewed by Alex Christensen.
2334
2335         Remove unused EditorClient functions.
2336
2337         * WebCoreSupport/WebEditorClient.h:
2338         * WebCoreSupport/WebEditorClient.mm:
2339         (WebEditorClient::canonicalizeURL): Deleted.
2340         (WebEditorClient::canonicalizeURLString): Deleted.
2341         (WebEditorClient::writeDataToPasteboard): Deleted.
2342         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2343         (WebEditorClient::readDataFromPasteboard): Deleted.
2344         (WebEditorClient::pasteboardChangeCount): Deleted.
2345
2346 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2347
2348         Stop using PolicyCallback
2349         https://bugs.webkit.org/show_bug.cgi?id=176088
2350
2351         Reviewed by Andy Estes.
2352
2353         * WebCoreSupport/WebFrameLoaderClient.mm:
2354         (-[WebFramePolicyListener invalidate]):
2355         (-[WebFramePolicyListener receivedPolicyDecision:]):
2356
2357 2017-09-25  Sam Weinig  <sam@webkit.org>
2358
2359         Remove unnecessary userVisibleString EditorClient function
2360         https://bugs.webkit.org/show_bug.cgi?id=177456
2361
2362         Reviewed by Dan Bernstein.
2363
2364         * WebCoreSupport/WebEditorClient.h:
2365         * WebCoreSupport/WebEditorClient.mm:
2366         (WebEditorClient::userVisibleString): Deleted.
2367
2368             Remove userVisibleString client function.
2369
2370 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2371
2372         Separate form submission from PolicyChecker infrastructure
2373         https://bugs.webkit.org/show_bug.cgi?id=177396
2374
2375         Reviewed by Geoffrey Garen.
2376
2377         * WebCoreSupport/WebFrameLoaderClient.h:
2378         * WebCoreSupport/WebFrameLoaderClient.mm:
2379         (WebFrameLoaderClient::dispatchWillSubmitForm):
2380
2381 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2382
2383         WeakPtrFactory should populate m_ref lazily.
2384         https://bugs.webkit.org/show_bug.cgi?id=177375
2385
2386         Reviewed by Geoffrey Garen.
2387
2388         * WebCoreSupport/WebEditorClient.mm:
2389         (WebEditorClient::WebEditorClient):
2390         (WebEditorClient::requestCandidatesForSelection):
2391
2392 2017-09-22  Chris Dumez  <cdumez@apple.com>
2393
2394         Use high resolution timestamp for event time
2395         https://bugs.webkit.org/show_bug.cgi?id=154246
2396         <rdar://problem/34333304>
2397
2398         Reviewed by Ryosuke Niwa.
2399
2400         Use WallTime / MonotonicTime instead of double type for clarity.
2401
2402         * DOM/DOMEvent.mm:
2403         (-[DOMEvent timeStamp]):
2404         * WebView/WebFrame.mm:
2405         (-[WebFrame _dragSourceEndedAt:operation:]):
2406         * WebView/WebPDFView.mm:
2407         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2408
2409 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2410
2411         Enable dataTransfer.items on macOS and iOS
2412         https://bugs.webkit.org/show_bug.cgi?id=177335
2413
2414         Reviewed by Sam Weinig.
2415
2416         * WebView/WebPreferences.mm:
2417         (+[WebPreferences initialize]):
2418
2419 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2420
2421         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2422         https://bugs.webkit.org/show_bug.cgi?id=177101
2423         <rdar://problem/34500648>
2424
2425         Reviewed by Brian Burg.
2426
2427         * WebInspector/WebNodeHighlight.mm:
2428         Ensure we close the window that we have just removed.
2429
2430 2017-09-20  Antti Koivisto  <antti@apple.com>
2431
2432         Remove DOM and styling support for CSS Regions
2433         https://bugs.webkit.org/show_bug.cgi?id=177221
2434
2435         Reviewed by Andreas Kling.
2436
2437         * Configurations/FeatureDefines.xcconfig:
2438         * DOM/DOMCSS.mm:
2439         (kitClass):
2440         * DOM/DOMElement.mm:
2441         (-[DOMElement webkitRegionOverset]): Deleted.
2442
2443 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2444
2445         Layering violation in Editor::createFragment
2446         https://bugs.webkit.org/show_bug.cgi?id=176123
2447
2448         Reviewed by Darin Adler.
2449
2450         * Misc/WebNSURLExtras.h:
2451         * Misc/WebNSURLExtras.mm:
2452         * WebView/WebFrame.mm:
2453         * WebView/WebHTMLView.mm:
2454         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2455
2456         * WebCoreSupport/WebEditorClient.mm:
2457         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2458         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2459         way to avoid exporting the symbol just on newer OSes.
2460
2461 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2462
2463         On iOS, getData can't get text set by setData during copy event
2464         https://bugs.webkit.org/show_bug.cgi?id=176980
2465         <rdar://problem/34453915>
2466
2467         Reviewed by Darin Adler.
2468
2469         * WebCoreSupport/WebPlatformStrategies.h:
2470         * WebCoreSupport/WebPlatformStrategies.mm:
2471         (WebPlatformStrategies::copy): Deleted.
2472
2473 2017-09-18  Andy Estes  <aestes@apple.com>
2474
2475         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2476         https://bugs.webkit.org/show_bug.cgi?id=177029
2477
2478         Reviewed by Alex Christensen.
2479
2480         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2481         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2482         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2483         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2484         * WebCoreSupport/PopupMenuMac.mm:
2485         (PopupMenuMac::show):
2486         * WebCoreSupport/WebSystemInterface.mm:
2487         (InitWebCoreSystemInterface):
2488         * WebView/WebHTMLView.mm:
2489         (-[WebHTMLView setDataSource:]):
2490         (-[WebHTMLView attachRootLayer:]):
2491         * WebView/WebView.mm:
2492         (-[WebView _needsAdobeFrameReloadingQuirk]):
2493         (-[WebView _needsLinkElementTextCSSQuirk]):
2494         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2495         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2496         (-[WebView _preferencesChanged:]):
2497
2498 2017-09-15  Andy Estes  <aestes@apple.com>
2499
2500         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2501         https://bugs.webkit.org/show_bug.cgi?id=176953
2502
2503         Reviewed by Eric Carlson.
2504
2505         * WebCoreSupport/WebSystemInterface.mm:
2506         (InitWebCoreSystemInterface):
2507
2508 2017-09-14  Andy Estes  <aestes@apple.com>
2509
2510         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2511         https://bugs.webkit.org/show_bug.cgi?id=176931
2512
2513         Reviewed by Joseph Pecoraro.
2514
2515         * WebCoreSupport/WebSystemInterface.mm:
2516         (InitWebCoreSystemInterface):
2517
2518 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2519
2520         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2521         https://bugs.webkit.org/show_bug.cgi?id=176867
2522
2523         Reviewed by Sam Weinig.
2524
2525         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2526         (WebKit::NetscapePluginInstanceProxy::enumerate):
2527
2528 2017-09-13  Andy Estes  <aestes@apple.com>
2529
2530         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
2531         https://bugs.webkit.org/show_bug.cgi?id=176729
2532
2533         Reviewed by Alex Christensen.
2534
2535         * WebCoreSupport/WebSystemInterface.mm:
2536         (InitWebCoreSystemInterface):
2537         * WebView/WebView.mm:
2538         (+[WebView _setCacheModel:]):
2539
2540 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2541
2542         Refactor WebContentReader out of EditorMac and EditorIOS
2543         https://bugs.webkit.org/show_bug.cgi?id=176770
2544
2545         Reviewed by Sam Weinig.
2546
2547         * WebCoreSupport/WebEditorClient.mm:
2548
2549 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2550
2551         Dragging & dropping a file creates an attachment element even when it's disabled
2552         https://bugs.webkit.org/show_bug.cgi?id=176769
2553
2554         Reviewed by Tim Horton.
2555
2556         * WebView/WebView.mm:
2557         (-[WebView _preferencesChanged:]):
2558
2559 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2560
2561         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
2562         https://bugs.webkit.org/show_bug.cgi?id=176721
2563         <rdar://problem/34373660>
2564
2565         Reviewed by Tim Horton.
2566
2567         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
2568         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
2569
2570         * WebView/WebView.mm:
2571         (-[WebView _startDrag:]):
2572         (-[WebView _draggedElementBounds]):
2573         (-[WebView _endedDataInteraction:global:]):
2574         * WebView/WebViewData.h:
2575
2576 2017-09-11  Andy Estes  <aestes@apple.com>
2577
2578         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2579         https://bugs.webkit.org/show_bug.cgi?id=176472
2580
2581         Reviewed by Eric Carlson.
2582
2583         * WebCoreSupport/WebSystemInterface.mm:
2584         (InitWebCoreSystemInterface):
2585
2586 2017-09-09  Mark Lam  <mark.lam@apple.com>
2587
2588         Avoid duplicate computations of ExecState::vm().
2589         https://bugs.webkit.org/show_bug.cgi?id=176647
2590
2591         Reviewed by Saam Barati.
2592
2593         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2594         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2595         (WebKit::NetscapePluginInstanceProxy::construct):
2596         (WebKit::NetscapePluginInstanceProxy::setProperty):
2597         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2598         (WebKit::NetscapePluginInstanceProxy::enumerate):
2599         * Plugins/Hosted/ProxyInstance.mm:
2600         (WebKit::ProxyRuntimeMethod::create):
2601
2602 2017-09-08  Commit Queue  <commit-queue@webkit.org>
2603
2604         Unreviewed, rolling out r221773.
2605         https://bugs.webkit.org/show_bug.cgi?id=176614
2606
2607         This caused build failures. (Requested by mlewis13 on
2608         #webkit).
2609
2610         Reverted changeset:
2611
2612         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
2613         https://bugs.webkit.org/show_bug.cgi?id=176472
2614         http://trac.webkit.org/changeset/221773
2615
2616 2017-09-07  Andy Estes  <aestes@apple.com>
2617
2618         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2619         https://bugs.webkit.org/show_bug.cgi?id=176472
2620
2621         Reviewed by Eric Carlson.
2622
2623         * WebCoreSupport/WebSystemInterface.mm:
2624         (InitWebCoreSystemInterface):
2625
2626 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
2627
2628         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
2629         https://bugs.webkit.org/show_bug.cgi?id=176561
2630
2631         Reviewed by Brent Fulgham.
2632
2633         * Misc/WebNSUserDefaultsExtras.mm:
2634
2635 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2636
2637         Modernize Geolocation code
2638         https://bugs.webkit.org/show_bug.cgi?id=176496
2639
2640         Reviewed by Andy Estes.
2641
2642         * WebCoreSupport/WebGeolocationClient.h:
2643         * WebCoreSupport/WebGeolocationClient.mm:
2644         (WebGeolocationClient::requestPermission):
2645         (-[WebGeolocationPolicyListener initWithGeolocation:]):
2646         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
2647         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
2648         * WebView/WebView.mm:
2649         (-[WebView _commonInitializationWithFrameName:groupName:]):
2650         (-[WebView _geolocationDidFailWithMessage:]):
2651
2652 2017-09-05  Tim Horton  <timothy_horton@apple.com>
2653
2654         Remove some unused bits of code and resources
2655         https://bugs.webkit.org/show_bug.cgi?id=176275
2656
2657         Reviewed by Dan Bernstein.
2658
2659         * Misc/WebNSFileManagerExtras.mm:
2660         Include FileSystem instead of FileSystemIOS.
2661
2662 2017-09-03  Darin Adler  <darin@apple.com>
2663
2664         [Cocoa] Tidy a few things in legacy WebHTMLView
2665         https://bugs.webkit.org/show_bug.cgi?id=176280
2666
2667         Reviewed by Dan Bernstein.
2668
2669         * WebCoreSupport/WebChromeClient.mm:
2670         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
2671         methods it calls on WebHTMLView were doing nothing on iOS.
2672
2673         * WebView/WebFrame.mm:
2674         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
2675         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
2676
2677         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
2678         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
2679         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
2680         order. Removed all sorts of unused things. Made more code and fields Mac-only where
2681         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
2682         Use RetainPtr instead of writing retain/release wherever possible.
2683         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
2684         initialization for it. Removed various unused methods and declarations of methods.
2685         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
2686         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
2687         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
2688         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
2689         and remove CFRetain no longer needed since we don't support garbage collection any more.
2690         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
2691         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
2692         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
2693         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
2694         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
2695         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2696         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
2697         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2698         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
2699         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
2700         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
2701         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
2702         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
2703         debug flag; we haven't used it for years and it's not clearly helpful.
2704         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
2705         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
2706         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
2707         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
2708         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
2709         two additional methods in the WebPrivate category and still be called by the two
2710         methods in the WebInternal category that were already using it.
2711         (-[WebHTMLView didAddSubview:]): Deleted.
2712         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
2713         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
2714         place this was called, the close method.
2715         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
2716         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2717         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
2718         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
2719         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
2720         Added helper method to make the one below simpler.
2721         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2722         Compared pasteboard type strings using isEqualToString: rather than using == since
2723         we want to actually compare the string contents. Also updated to use modern for loop,
2724         renamed a local variable from "s" to "localSubresources", and factored out the handling
2725         of three image types to use the helper method above.
2726         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
2727         _web_makePluginSubviewsPerformSelector:withObject: method.
2728         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
2729         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
2730         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
2731         not call the -[NSView subviews] method to make this identical on both platforms and used
2732         a modern for loop.
2733         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
2734         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
2735         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
2736         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
2737         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2738         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
2739         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
2740         of it is Mac-only.
2741         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
2742         method did was call itself on the main thread, and do nothing if called on main thread.
2743         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
2744         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
2745         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
2746         half of this method.
2747         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
2748         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2749         Simplified using a modern for loop and RetainPtr.
2750         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
2751         (-[WebHTMLView keyDown:]): Ditto.
2752         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
2753         (-[WebHTMLView performKeyEquivalent:]): Ditto.
2754         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
2755         (-[WebHTMLView complete:]): Ditto.
2756         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
2757         now macOS-only.
2758         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
2759         iOS since that is now macOS-only.
2760         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
2761         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
2762         a private one because it is not used or needed outside WebKit. Also made it macOS-only
2763         and reorganized to use early return.
2764         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
2765         on iOS, but kept there so we don't have to do #if at every call site.
2766         (-[WebHTMLView _pluginController]): Moved into internal category.
2767         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
2768         there only for GC, using C++ initialization, removing obsolete comment.
2769         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
2770         peculiar iOS-only comment.
2771         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
2772
2773         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
2774         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
2775         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
2776         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
2777         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
2778
2779         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
2780         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
2781         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
2782         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
2783         them at this time.
2784
2785 2017-09-03  Sam Weinig  <sam@webkit.org>
2786
2787         Remove CanvasProxy
2788         https://bugs.webkit.org/show_bug.cgi?id=176288
2789
2790         Reviewed by Yusuke Suzuki.
2791
2792         CanvasProxy does not appear to be in any current HTML spec
2793         and was disabled and unimplemented in our tree. Time to 
2794         get rid of it.
2795
2796         * Configurations/FeatureDefines.xcconfig:
2797
2798 2017-09-02  Andy Estes  <aestes@apple.com>
2799
2800         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
2801         https://bugs.webkit.org/show_bug.cgi?id=176270
2802
2803         Reviewed by Tim Horton.
2804
2805         * Plugins/Hosted/NetscapePluginHostManager.mm:
2806         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2807         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2808         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2809         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
2810         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
2811         (WebKit::SoftwareCARenderer::context const):
2812         (WebKit::SoftwareCARenderer::renderContext const):
2813         (WebKit::SoftwareCARenderer::render):
2814         (-[WebHostedNetscapePluginView createPlugin]):
2815         (-[WebHostedNetscapePluginView createPluginLayer]):
2816         (-[WebHostedNetscapePluginView destroyPlugin]):
2817         (-[WebHostedNetscapePluginView drawRect:]):
2818         * WebCoreSupport/WebSystemInterface.mm:
2819         (InitWebCoreSystemInterface):
2820
2821 2017-09-01  Andy Estes  <aestes@apple.com>
2822
2823         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
2824         https://bugs.webkit.org/show_bug.cgi?id=176200
2825
2826         Reviewed by Tim Horton.
2827
2828         * Carbon/HIWebView.mm:
2829         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
2830         (overrideCGContext):
2831         (restoreCGContext):
2832         (Draw):
2833         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2834         (+[WebHostedNetscapePluginView initialize]):
2835         * Plugins/WebBaseNetscapePluginView.h:
2836         * Plugins/WebBaseNetscapePluginView.mm:
2837         (WebKit::sendUserChangeNotifications):
2838         * Plugins/WebNetscapePluginView.mm:
2839         (+[WebNetscapePluginView initialize]):
2840         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2841         * WebCoreSupport/WebSystemInterface.mm:
2842         (InitWebCoreSystemInterface):
2843         * WebView/WebFrame.mm:
2844         (-[WebFrame _paintBehaviorForDestinationContext:]):
2845         * WebView/WebFullScreenController.mm:
2846         (setClipRectForWindow):
2847         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2848         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2849         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2850         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2851
2852 2017-08-31  Andy Estes  <aestes@apple.com>
2853
2854         [Mac] Upstream AppKit-related WebKitSystemInterface functions
2855         https://bugs.webkit.org/show_bug.cgi?id=176175
2856
2857         Reviewed by Brady Eidson.
2858
2859         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2860         (WebKit::NetscapePluginInstanceProxy::keyEvent):
2861         * Plugins/Hosted/WebTextInputWindowController.m:
2862         (-[WebTextInputPanel init]):
2863         * WebCoreSupport/WebSystemInterface.mm:
2864         (InitWebCoreSystemInterface):
2865         * WebView/WebDynamicScrollBarsView.mm:
2866         (-[WebDynamicScrollBarsView scrollWheel:]):
2867         * WebView/WebHTMLView.mm:
2868         (-[WebHTMLView _removeWindowObservers]):
2869         (-[WebHTMLView addWindowObservers]):
2870         * WebView/WebView.mm:
2871         (-[WebView addWindowObserversForWindow:]):
2872         (-[WebView removeWindowObservers]):
2873         (-[WebView viewWillMoveToWindow:]):
2874
2875 2017-08-31  Alex Christensen  <achristensen@webkit.org>
2876
2877         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
2878         https://bugs.webkit.org/show_bug.cgi?id=175779
2879         <rdar://problem/22367975>
2880
2881         Reviewed by Tim Horton.
2882
2883         * WebCoreSupport/WebFrameLoaderClient.h:
2884         * WebCoreSupport/WebFrameLoaderClient.mm:
2885         (WebFrameLoaderClient::webGLPolicyForURL const):
2886         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
2887
2888 2017-08-30  Andy Estes  <aestes@apple.com>
2889
2890         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
2891         https://bugs.webkit.org/show_bug.cgi?id=176093
2892
2893         Reviewed by Eric Carlson.
2894
2895         * WebCoreSupport/WebSystemInterface.mm:
2896         (InitWebCoreSystemInterface):
2897
2898 2017-08-30  Andy Estes  <aestes@apple.com>
2899
2900         [Mac] Upstream Carbon-related WebKitSystemInterface functions
2901         https://bugs.webkit.org/show_bug.cgi?id=176087
2902
2903         Reviewed by Alex Christensen.
2904
2905         * Carbon/CarbonUtils.m:
2906         (getNSAutoreleasePoolCount):
2907         (WebInitForCarbon):
2908         (PoolCleaner):
2909         * Carbon/CarbonWindowAdapter.mm:
2910         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2911         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2912         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2913         (-[CarbonWindowAdapter _windowMovedToRect:]):
2914         * Carbon/HIViewAdapter.m:
2915         * Carbon/HIWebView.mm:
2916         (Draw):
2917         (CreateNSEventAdoptingCGEvent):
2918         (CopyEventCGEvent):
2919         (CreateNSEventWithCarbonClickEvent):
2920         (Click):
2921         (CreateNSEventWithCarbonEvent):
2922         (MouseUp):
2923         (CreateNSEventWithCarbonMouseMoveEvent):
2924         (MouseMoved):
2925         (MouseDragged):
2926         (MouseWheelMoved):
2927         (WindowHandler):
2928         (HIWebViewEventHandler):
2929         * Misc/QuickDrawCompatibility.h: Removed.
2930         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2931         (getCarbonEvent):
2932         (WebNetscapePluginEventHandlerCarbon::keyDown):
2933         (WebNetscapePluginEventHandlerCarbon::keyUp):
2934         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2935         (WebNetscapePluginEventHandlerCocoa::keyDown):
2936         * Plugins/WebNetscapePluginView.mm:
2937         (-[WebNetscapePluginView tellQuickTimeToChill]):
2938
2939 2017-08-29  Andy Estes  <aestes@apple.com>
2940
2941         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
2942         https://bugs.webkit.org/show_bug.cgi?id=176046
2943
2944         Reviewed by Alex Christensen.
2945
2946         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
2947         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
2948
2949         * Misc/WebNSFileManagerExtras.mm:
2950         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
2951         (setMetaData): Deleted.
2952         * WebCoreSupport/WebSystemInterface.mm:
2953         (InitWebCoreSystemInterface):
2954
2955 2017-08-28  Andy Estes  <aestes@apple.com>
2956
2957         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
2958         https://bugs.webkit.org/show_bug.cgi?id=176039
2959
2960         Reviewed by Alex Christensen.
2961
2962         * WebCoreSupport/WebSystemInterface.mm:
2963         (InitWebCoreSystemInterface):
2964         * WebView/WebPreferences.mm:
2965         (+[WebPreferences _systemCFStringEncoding]):
2966
2967 2017-08-28  Andy Estes  <aestes@apple.com>
2968
2969         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
2970         https://bugs.webkit.org/show_bug.cgi?id=176032
2971
2972         Reviewed by Alex Christensen.
2973
2974         * WebCoreSupport/WebSystemInterface.mm:
2975         (InitWebCoreSystemInterface):
2976         * WebView/WebView.mm:
2977         (-[WebView _cachedResponseForURL:]):
2978
2979 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2980
2981         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
2982         https://bugs.webkit.org/show_bug.cgi?id=175992
2983         <rdar://problem/34086613>
2984
2985         Reviewed by Daniel Bates.
2986
2987         * WebCoreSupport/WebPlatformStrategies.h:
2988         * WebCoreSupport/WebPlatformStrategies.mm:
2989         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
2990         cookies should be included, and return a pair containing the resulting cookie string and a boolean
2991         indicating if secure cookies were accessed.
2992
2993 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2994
2995         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
2996         https://bugs.webkit.org/show_bug.cgi?id=170955
2997         <rdar://problem/31697653>
2998
2999         Reviewed by Ryosuke Niwa.
3000
3001         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3002         text is being replaced.
3003
3004         * WebView/WebHTMLView.mm:
3005         (-[WebHTMLView insertText:]):
3006
3007 2017-08-24  Chris Dumez  <cdumez@apple.com>
3008
3009         [Directory Upload] Add basic support for input.webkitdirectory
3010         https://bugs.webkit.org/show_bug.cgi?id=175950
3011         <rdar://problem/33951915>
3012
3013         Reviewed by Geoffrey Garen.
3014
3015         Add private API to toggle Directory Upload support on Mac WebKit1.
3016
3017         * WebView/WebPreferenceKeysPrivate.h:
3018         * WebView/WebPreferences.mm:
3019         (+[WebPreferences initialize]):
3020         (-[WebPreferences setDirectoryUploadEnabled:]):
3021         (-[WebPreferences directoryUploadEnabled]):
3022         * WebView/WebPreferencesPrivate.h:
3023         * WebView/WebView.mm:
3024         (-[WebView _preferencesChanged:]):
3025
3026 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3027
3028         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3029         https://bugs.webkit.org/show_bug.cgi?id=175370
3030         <rdar://problem/33799806>
3031
3032         Reviewed by Ryosuke Niwa.
3033
3034         Adjust WebEditorClient for interface changes.
3035
3036         * WebCoreSupport/WebEditorClient.h:
3037
3038 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3039
3040         Remove ChromeClient::scrollbarsModeDidChange
3041         https://bugs.webkit.org/show_bug.cgi?id=175805
3042
3043         Reviewed by Daniel Bates.
3044
3045         * WebCoreSupport/WebChromeClient.h:
3046
3047 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3048
3049         Remove ChromeClient::hasOpenedPopup
3050         https://bugs.webkit.org/show_bug.cgi?id=175804
3051
3052         Reviewed by Sam Weinig.
3053
3054         * WebCoreSupport/WebChromeClient.h:
3055         * WebCoreSupport/WebChromeClient.mm:
3056         (WebChromeClient::hasOpenedPopup const): Deleted.
3057
3058 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3059
3060         Disable access to secure cookies if an HTTPS site loads mixed content
3061         https://bugs.webkit.org/show_bug.cgi?id=157053
3062         <rdar://problem/11290808>
3063
3064         Reviewed by Dan Bates.
3065
3066         * WebCoreSupport/WebPlatformStrategies.h:
3067         * WebCoreSupport/WebPlatformStrategies.mm:
3068         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3069         indicating whether secure cookies should be included in the response.
3070
3071 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3072
3073         [PAL] Move spi/mac directory into PAL
3074         https://bugs.webkit.org/show_bug.cgi?id=175649
3075
3076         Reviewed by Myles C. Maxfield.
3077
3078         * Misc/WebSharingServicePickerController.h:
3079         * WebCoreSupport/WebContextMenuClient.mm:
3080         * WebCoreSupport/WebEditorClient.mm:
3081         * WebCoreSupport/WebSelectionServiceController.mm:
3082         * WebView/WebHTMLView.mm:
3083         * WebView/WebImmediateActionController.h:
3084         * WebView/WebImmediateActionController.mm:
3085         * WebView/WebView.mm:
3086
3087 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3088
3089         [PAL] Relocate SessionID to root
3090         https://bugs.webkit.org/show_bug.cgi?id=175684
3091
3092         Reviewed by Alex Christensen.
3093
3094         * WebCoreSupport/WebFrameNetworkingContext.mm:
3095
3096 2017-08-17  Andreas Kling  <akling@apple.com>
3097
3098         Disable CSS regions at compile time
3099         https://bugs.webkit.org/show_bug.cgi?id=175630
3100
3101         Reviewed by Antti Koivisto.
3102
3103         * Configurations/FeatureDefines.xcconfig:
3104
3105 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3106
3107         [PAL] Move SessionID into PAL
3108         https://bugs.webkit.org/show_bug.cgi?id=174192
3109
3110         Reviewed by Antti Koivisto.
3111
3112         * Misc/WebCache.mm:
3113         (+[WebCache imageForURL:]):
3114         * WebCoreSupport/WebFrameLoaderClient.h:
3115         * WebCoreSupport/WebFrameLoaderClient.mm:
3116         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3117         * WebCoreSupport/WebFrameNetworkingContext.mm:
3118         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3119         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3120         (WebFrameNetworkingContext::storageSession const):
3121         * WebCoreSupport/WebPlatformStrategies.h:
3122         * WebCoreSupport/WebPlatformStrategies.mm:
3123         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3124         * WebKitPrefix.h:
3125
3126 2017-08-16  Andy Estes  <aestes@apple.com>
3127
3128         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3129         https://bugs.webkit.org/show_bug.cgi?id=175648
3130
3131         Reviewed by Tim Horton.
3132
3133         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3134         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3135         (WebPaymentCoordinatorClient::showPaymentUI):
3136
3137 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3138
3139         [PAL] Move spi/ios and spi/win directories into PAL
3140         https://bugs.webkit.org/show_bug.cgi?id=175171
3141
3142         Reviewed by Antti Koivisto.
3143
3144         * WebCoreSupport/WebFrameLoaderClient.mm:
3145         * WebView/WebView.mm:
3146
3147 2017-08-16  Andy Estes  <aestes@apple.com>
3148
3149         [Payment Request] Add an ENABLE flag and an experimental feature preference
3150         https://bugs.webkit.org/show_bug.cgi?id=175622
3151
3152         Reviewed by Tim Horton.
3153
3154         * Configurations/FeatureDefines.xcconfig:
3155
3156 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3157
3158         [PAL] Move Sleep classes into PAL
3159         https://bugs.webkit.org/show_bug.cgi?id=175456
3160
3161         Reviewed by Ryosuke Niwa.
3162
3163         * WebView/WebFullScreenController.h:
3164
3165 2017-08-15  Youenn Fablet  <youenn@apple.com>
3166
3167         [Cache API] Adding generic support for CacheStorage and Cache methods
3168         https://bugs.webkit.org/show_bug.cgi?id=175455
3169
3170         Reviewed by Chris Dumez.
3171
3172         * WebView/WebView.mm:
3173         (-[WebView _commonInitializationWithFrameName:groupName:]):
3174
3175 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3176
3177         Remove Proximity Events and related code
3178         https://bugs.webkit.org/show_bug.cgi?id=175545
3179
3180         Reviewed by Daniel Bates.
3181
3182         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3183         and other related code.
3184
3185         * Configurations/FeatureDefines.xcconfig:
3186
3187 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3188
3189         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3190         https://bugs.webkit.org/show_bug.cgi?id=175504
3191
3192         Reviewed by Sam Weinig.
3193
3194         * Configurations/FeatureDefines.xcconfig:
3195         * DOM/DOMHTMLFormElement.mm:
3196         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3197         * WebCoreSupport/WebFrameLoaderClient.h:
3198
3199 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3200
3201         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3202         https://bugs.webkit.org/show_bug.cgi?id=175557
3203
3204         Reviewed by Jon Lee.
3205
3206         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3207
3208         * Configurations/FeatureDefines.xcconfig:
3209
3210 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3211
3212         Composition underline color is always black
3213         https://bugs.webkit.org/show_bug.cgi?id=174675
3214
3215         Reviewed by Ryosuke Niwa.
3216
3217         * WebView/WebHTMLView.mm:
3218         (extractUnderlines): If NSUnderlineColorAttributeName
3219         is not present use text color for composition underline.
3220         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3221         for composition underline in the plain text case.
3222
3223 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3224
3225         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3226         https://bugs.webkit.org/show_bug.cgi?id=175474
3227         <rdar://problem/33844628>
3228
3229         Reviewed by Wenson Hsieh.
3230
3231         Replaced the build flag by a runtime flag and disabled the feature by default.
3232
3233         * Configurations/FeatureDefines.xcconfig:
3234         * WebView/WebPreferenceKeysPrivate.h:
3235         * WebView/WebPreferences.mm:
3236         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3237         (-[WebPreferences dataTransferItemsEnabled]): Added.
3238         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3239         * WebView/WebPreferencesPrivate.h:
3240         * WebView/WebView.mm:
3241         (-[WebView _preferencesChanged:]):
3242
3243 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3244
3245         Remove ENABLE_GAMEPAD_DEPRECATED
3246         https://bugs.webkit.org/show_bug.cgi?id=175361
3247
3248         Reviewed by Carlos Garcia Campos.
3249
3250         * Configurations/FeatureDefines.xcconfig:
3251
3252 2017-08-09  Chris Dumez  <cdumez@apple.com>
3253
3254         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3255         https://bugs.webkit.org/show_bug.cgi?id=175401
3256
3257         Reviewed by Brady Eidson.
3258
3259         * WebView/WebPreferenceKeysPrivate.h:
3260         * WebView/WebPreferences.mm:
3261         (+[WebPreferences initialize]):
3262         (-[WebPreferences beaconAPIEnabled]): Deleted.
3263         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3264         * WebView/WebPreferencesPrivate.h:
3265         * WebView/WebView.mm:
3266         (-[WebView _preferencesChanged:]):
3267
3268 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3269
3270         [PAL] Move spi/cocoa and spi/cg directories into PAL
3271         https://bugs.webkit.org/show_bug.cgi?id=175175
3272
3273         Reviewed by Myles C. Maxfield.
3274
3275         * History/WebHistory.mm:
3276         * Misc/WebDownload.mm:
3277         * Misc/WebKitNSStringExtras.mm:
3278         * Plugins/Hosted/NetscapePluginHostManager.mm:
3279         * Plugins/WebPluginDatabase.mm:
3280         * WebCoreSupport/WebFrameLoaderClient.mm:
3281         * WebInspector/WebNodeHighlight.mm:
3282         * WebView/WebHTMLView.mm:
3283         * WebView/WebIndicateLayer.mm:
3284         * WebView/WebView.mm:
3285         * WebView/WebViewData.h:
3286
3287 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3288
3289         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
3290         https://bugs.webkit.org/show_bug.cgi?id=175392
3291         <rdar://problem/33783207>
3292
3293         Reviewed by Tim Horton and Megan Gardner.
3294
3295         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
3296
3297         * Configurations/FeatureDefines.xcconfig:
3298
3299 2017-08-09  Daniel Bates  <dabates@apple.com>
3300
3301         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3302         https://bugs.webkit.org/show_bug.cgi?id=175247
3303         <rdar://problem/33679804>
3304
3305         Reviewed by Brady Eidson.
3306
3307         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3308         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3309         clients that need to make use of this information at this time. If such a needs comes up
3310         then we can expose API/SPI similar to what we do for WebKit.
3311
3312         * WebCoreSupport/WebFrameLoaderClient.h:
3313         * WebCoreSupport/WebFrameLoaderClient.mm:
3314         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3315
3316 2017-08-08  Brady Eidson  <beidson@apple.com>
3317
3318         Don't enable default icon loading in WK1 for apps linked against old SDKs.
3319         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
3320
3321         Reviewed by Andy Estes.
3322
3323         * Misc/WebKitVersionChecks.h:
3324         * WebCoreSupport/WebFrameLoaderClient.mm:
3325         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
3326           the app is linked against new WebKit with the new behavior.
3327
3328 2017-08-07  Devin Rousso  <drousso@apple.com>
3329
3330         Web Inspector: Preview Canvas path when viewing a recording
3331         https://bugs.webkit.org/show_bug.cgi?id=174967
3332
3333         Reviewed by Brian Burg.
3334
3335         * WebView/WebPreferenceKeysPrivate.h:
3336         * WebView/WebPreferences.mm:
3337         (+[WebPreferences initialize]):
3338         (-[WebPreferences inspectorAdditionsEnabled]):
3339         (-[WebPreferences setInspectorAdditionsEnabled:]):
3340         * WebView/WebPreferencesPrivate.h:
3341         * WebView/WebView.mm:
3342         (-[WebView _preferencesChanged:]):
3343         Add plumbing for new InspectorAdditions runtime flag.
3344
3345 2017-08-07  Brian Burg  <bburg@apple.com>
3346
3347         Remove CANVAS_PATH compilation guard
3348         https://bugs.webkit.org/show_bug.cgi?id=175207
3349
3350         Reviewed by Sam Weinig.
3351
3352         * Configurations/FeatureDefines.xcconfig:
3353
3354 2017-08-04  Youenn Fablet  <youenn@apple.com>
3355
3356         [Cache API] Add Cache and CacheStorage IDL definitions
3357         https://bugs.webkit.org/show_bug.cgi?id=175201
3358
3359         Reviewed by Brady Eidson.
3360
3361         * WebView/WebPreferenceKeysPrivate.h:
3362         * WebView/WebPreferences.mm:
3363         (+[WebPreferences initialize]):
3364         (-[WebPreferences cacheAPIEnabled]):
3365         (-[WebPreferences setCacheAPIEnabled:]):
3366         * WebView/WebPreferencesPrivate.h:
3367         * WebView/WebView.mm:
3368         (-[WebView _preferencesChanged:]):
3369
3370 2017-08-04  Matt Lewis  <jlewis3@apple.com>
3371
3372         Unreviewed, rolling out r220271.
3373
3374         Rolling out due to Layout Test failing on iOS Simulator.
3375
3376         Reverted changeset:
3377
3378         "Remove STREAMS_API compilation guard"
3379         https://bugs.webkit.org/show_bug.cgi?id=175165
3380         http://trac.webkit.org/changeset/220271
3381
3382 2017-08-04  Youenn Fablet  <youenn@apple.com>
3383
3384         Remove STREAMS_API compilation guard
3385         https://bugs.webkit.org/show_bug.cgi?id=175165
3386
3387         Reviewed by Darin Adler.
3388
3389         * Configurations/FeatureDefines.xcconfig:
3390         * WebView/WebPreferences.mm:
3391         (+[WebPreferences initialize]):
3392         * WebView/WebView.mm:
3393         (-[WebView _preferencesChanged:]):
3394
3395 2017-08-03  Brian Burg  <bburg@apple.com>
3396
3397         Remove ENABLE(WEB_SOCKET) guards
3398         https://bugs.webkit.org/show_bug.cgi?id=167044
3399
3400         Reviewed by Joseph Pecoraro.
3401
3402         * Configurations/FeatureDefines.xcconfig:
3403         * WebView/WebPreferencesPrivate.h:
3404
3405 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
3406
3407         [PAL] Move spi/cf directory into PAL
3408         https://bugs.webkit.org/show_bug.cgi?id=175057
3409
3410         Reviewed by Antti Koivisto.
3411
3412         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3413         * Plugins/WebNetscapePluginStream.mm:
3414         * WebCoreSupport/WebFrameNetworkingContext.mm:
3415         * WebView/WebPreferences.mm:
3416         * WebView/WebView.mm:
3417
3418 2017-08-03  Youenn Fablet  <youenn@apple.com>
3419
3420         Remove FETCH_API compilation guard
3421         https://bugs.webkit.org/show_bug.cgi?id=175154
3422
3423         Reviewed by Chris Dumez.
3424
3425         * Configurations/FeatureDefines.xcconfig:
3426         * WebView/WebPreferences.mm:
3427         (+[WebPreferences initialize]):
3428         * WebView/WebView.mm:
3429         (-[WebView _preferencesChanged:]):
3430
3431 2017-08-03  Brady Eidson  <beidson@apple.com>
3432
3433         Add SW IDLs and stub out basic functionality.
3434         https://bugs.webkit.org/show_bug.cgi?id=175115
3435
3436         Reviewed by Chris Dumez.
3437
3438         * Configurations/FeatureDefines.xcconfig:
3439
3440 2017-08-02  Sam Weinig  <sam@webkit.org>
3441
3442         [WebIDL] Convert MutationCallback to be a normal generated callback
3443         https://bugs.webkit.org/show_bug.cgi?id=174140
3444
3445         Reviewed by Darin Adler.
3446
3447         * DOM/DOMDocument.mm:
3448         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
3449         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3450         Pass, now necessary, Document to NativeNodeFilter constructor.
3451
3452 2017-08-01  Chris Dumez  <cdumez@apple.com>
3453
3454         Add initial support for navigator.sendBeacon
3455         https://bugs.webkit.org/show_bug.cgi?id=175007
3456         <rdar://problem/33547728>
3457
3458         Reviewed by Sam Weinig.
3459
3460         Add setting to toggle support for the Beacon API (it is disabled by default).
3461
3462         * WebView/WebPreferenceKeysPrivate.h:
3463         * WebView/WebPreferences.mm:
3464         (+[WebPreferences initialize]):
3465         (-[WebPreferences beaconAPIEnabled]):
3466         (-[WebPreferences setBeaconAPIEnabled:]):
3467         * WebView/WebPreferencesPrivate.h:
3468         * WebView/WebView.mm:
3469         (-[WebView _preferencesChanged:]):
3470
3471 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
3472
3473         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
3474         https://bugs.webkit.org/show_bug.cgi?id=174437
3475
3476         Reviewed by Darin Adler.
3477
3478         Remove redundant Web- prefix from classes in WebKit namespace.
3479
3480         * WebView/WebView.mm:
3481         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3482         * WebView/WebViewData.h:
3483         * WebView/WebViewData.mm:
3484
3485 2017-07-26  Brian Burg  <bburg@apple.com>
3486
3487         Remove WEB_TIMING feature flag
3488         https://bugs.webkit.org/show_bug.cgi?id=174795
3489
3490         Reviewed by Alex Christensen.
3491
3492         * Configurations/FeatureDefines.xcconfig:
3493
3494 2017-07-25  Said Abou-Hallawa  <sabouhal