57392b48ce7db5d8cf8b865527385db6bb8a7200
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-03-08  Chris Dumez  <cdumez@apple.com>
2
3         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
4         https://bugs.webkit.org/show_bug.cgi?id=183455
5         <rdar://problem/38191749>
6
7         Reviewed by Youenn Fablet.
8
9         Add a null check for the page as we have evidence from crashes that it can be null.
10         Other functions in WebFrameNetworkingContext already null check the page as well,
11         not just the frame so this is consistent.
12
13         * WebCoreSupport/WebFrameNetworkingContext.mm:
14         (WebFrameNetworkingContext::storageSession const):
15
16 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
17
18         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
19         https://bugs.webkit.org/show_bug.cgi?id=183429
20
21         Reviewed by Mark Lam.
22
23         * DOM/DOM.mm:
24         (+[DOMNode _nodeFromJSWrapper:]):
25         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
26         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
27         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
28         * Plugins/Hosted/ProxyInstance.mm:
29         (WebKit::ProxyInstance::invokeMethod):
30         * WebView/WebView.mm:
31         (aeDescFromJSValue):
32
33 2018-03-08  Tim Horton  <timothy_horton@apple.com>
34
35         Stop linking ApplicationServices directly
36         https://bugs.webkit.org/show_bug.cgi?id=182867
37         <rdar://problem/38252142>
38
39         Reviewed by Alex Christensen.
40
41         The frameworks that we use that live inside ApplicationServices
42         have mostly moved out, so import them directly.
43
44         * Carbon/CarbonUtils.h:
45         * WebKitPrefix.h:
46         * WebView/WebHTMLView.mm:
47         * WebView/WebPDFView.mm:
48
49 2018-03-07  Tim Horton  <timothy_horton@apple.com>
50
51         Sort and separate FeatureDefines.xcconfig
52         https://bugs.webkit.org/show_bug.cgi?id=183427
53
54         Reviewed by Dan Bernstein.
55
56         * Configurations/FeatureDefines.xcconfig:
57         Sort and split FeatureDefines into paragraphs
58         (to make it easier to sort later).
59
60 2018-03-07  Youenn Fablet  <youenn@apple.com>
61
62         Match unsupported plugins based on domains and not origin
63         https://bugs.webkit.org/show_bug.cgi?id=183384
64
65         Reviewed by Chris Dumez.
66
67         * WebCoreSupport/WebPluginInfoProvider.h:
68         * WebCoreSupport/WebPluginInfoProvider.mm:
69         (WebPluginInfoProvider::getPluginInfo):
70         (WebPluginInfoProvider::getWebVisiblePluginInfo):
71
72 2018-03-05  Andy Estes  <aestes@apple.com>
73
74         [Mac] Teach WebCore::Pasteboard about file promise drags
75         https://bugs.webkit.org/show_bug.cgi?id=183314
76         <rdar://problem/38105493>
77
78         Reviewed by Darin Adler.
79
80         Added a FIXME comment.
81
82         * WebView/WebView.mm:
83         (-[WebView performDragOperation:]):
84
85 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
86
87         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
88         https://bugs.webkit.org/show_bug.cgi?id=183312
89
90         Reviewed by Mark Lam.
91
92         Remove wtf/CurrentTime.h include pragma.
93
94         * WebView/WebFrame.mm:
95         * WebView/WebPDFView.mm:
96
97 2018-03-04  Tim Horton  <timothy_horton@apple.com>
98
99         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
100         https://bugs.webkit.org/show_bug.cgi?id=183283
101         <rdar://problem/38062148>
102
103         Reviewed by Sam Weinig.
104
105         * Configurations/FeatureDefines.xcconfig:
106
107 2018-02-28  Alex Christensen  <achristensen@webkit.org>
108
109         Reduce use of NetworkingContext in WebKit
110         https://bugs.webkit.org/show_bug.cgi?id=183213
111
112         Reviewed by Brady Eidson.
113
114         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
115         (WebKit::NetscapePluginInstanceProxy::getProxy):
116         * Plugins/WebNetscapePluginView.mm:
117         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
118
119 2018-02-17  Darin Adler  <darin@apple.com>
120
121         Prepare for ExtendedColor changes (first step)
122         https://bugs.webkit.org/show_bug.cgi?id=182904
123
124         Reviewed by Sam Weinig.
125
126         * Misc/WebKitNSStringExtras.mm:
127         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
128
129 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
130
131         Remove currentTime() / currentTimeMS()
132         https://bugs.webkit.org/show_bug.cgi?id=183052
133
134         Reviewed by Mark Lam.
135
136         * WebCoreSupport/WebFrameLoaderClient.h:
137         * WebCoreSupport/WebFrameLoaderClient.mm:
138         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
139
140 2018-02-16  Youenn Fablet  <youenn@apple.com>
141
142         Allow specifying which plug-ins are supported
143         https://bugs.webkit.org/show_bug.cgi?id=182748
144
145         Reviewed by Chris Dumez.
146
147         * WebCoreSupport/WebPluginInfoProvider.h:
148         * WebCoreSupport/WebPluginInfoProvider.mm:
149         (WebPluginInfoProvider::getPluginInfo):
150         (WebPluginInfoProvider::getWebVisiblePluginInfo):
151
152 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
153
154         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
155         https://bugs.webkit.org/show_bug.cgi?id=182882
156         <rdar://problem/35672661>
157
158         Reviewed by Dan Bernstein.
159
160         Make sure the smart pointer hold the collection of subviews lives at least as
161         long as the loop using it.
162
163         * WebView/WebHTMLView.mm:
164         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
165
166 2018-02-14  Daniel Bates  <dabates@apple.com>
167
168         Disallow cross-origin subresources from asking for credentials
169         https://bugs.webkit.org/show_bug.cgi?id=182579
170         <rdar://problem/36162271>
171
172         Reviewed by Andy Estes.
173
174         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
175         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
176
177         * WebView/WebPreferenceKeysPrivate.h:
178         * WebView/WebPreferences.mm:
179         (+[WebPreferences initialize]):
180         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
181         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
182         * WebView/WebPreferencesPrivate.h:
183         * WebView/WebView.mm:
184         (-[WebView _preferencesChanged:]):
185
186 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
187
188         Remove ForwardingHeaders directory from WebKitLegacy/mac.
189         https://bugs.webkit.org/show_bug.cgi?id=182738
190
191         Reviewed by Darin Adler.
192
193         * ForwardingHeaders/collector/handles/Global.h: Removed.
194         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
195         * ForwardingHeaders/runtime/Completion.h: Removed.
196         * ForwardingHeaders/runtime/Error.h: Removed.
197         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
198         * ForwardingHeaders/runtime/JSFunction.h: Removed.
199         * ForwardingHeaders/runtime/JSLock.h: Removed.
200         * ForwardingHeaders/runtime/JSObject.h: Removed.
201         * ForwardingHeaders/runtime/JSString.h: Removed.
202         * ForwardingHeaders/runtime/Protect.h: Removed.
203         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
204
205 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
206
207         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
208         https://bugs.webkit.org/show_bug.cgi?id=182641
209
210         Reviewed by Dan Bernstein.
211
212         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
213         https://trac.webkit.org/changeset/228308.
214
215         * WebView/WebVideoFullscreenController.h:
216         * WebView/WebVideoFullscreenHUDWindowController.mm:
217         * WebView/WebWindowAnimation.h:
218         * WebView/WebWindowAnimation.mm:
219         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
220         (WebCore::scaledRect): Deleted.
221         (WebCore::squaredDistance): Deleted.
222
223 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
224
225         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
226
227         * WebView/WebWindowAnimation.mm:
228         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
229
230 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
231
232         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
233         https://bugs.webkit.org/show_bug.cgi?id=182615
234
235         Reviewed by Eric Carlson.
236
237         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
238         Ideally, we should not reference NSApp in WebCore.
239
240         * WebView/WebFullScreenController.mm:
241         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
242         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
243         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
244         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
245         * WebView/WebView.mm:
246         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
247         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
248
249 2018-01-13  Darin Adler  <darin@apple.com>
250
251         Event improvements
252         https://bugs.webkit.org/show_bug.cgi?id=179591
253
254         Reviewed by Chris Dumez.
255
256         * DOM/DOMWheelEvent.mm:
257         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
258         Call initWebKitWheelEvent.
259
260         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
261         * WebCoreSupport/WebInspectorClient.mm: Ditto.
262         * WebView/WebFrame.mm: Ditto.
263
264         * WebView/WebHTMLView.mm:
265         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
266         underlyingPlatformEvent.
267         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
268
269         * WebView/WebScriptWorld.mm:
270         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
271
272         * WebView/WebView.mm: Removed include of ScriptValue.h.
273
274 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
275
276         Remove WebCore/ForwardingHeaders directory
277         https://bugs.webkit.org/show_bug.cgi?id=182347
278
279         Reviewed by Keith Miller.
280
281         * Carbon/CarbonWindowAdapter.mm:
282         * DOM/WebDOMOperations.mm:
283         * History/WebBackForwardList.mm:
284         * History/WebHistoryItem.mm:
285         * Misc/WebCache.mm:
286         * Misc/WebElementDictionary.mm:
287         * Misc/WebIconDatabase.mm:
288         * Misc/WebStringTruncator.mm:
289         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
290         * Plugins/Hosted/ProxyInstance.mm:
291         * Plugins/Hosted/ProxyRuntimeObject.mm:
292         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
293         * Plugins/WebBaseNetscapePluginView.mm:
294         * Plugins/WebBasePluginPackage.mm:
295         * Plugins/WebNetscapePluginStream.mm:
296         * Plugins/WebNetscapePluginView.mm:
297         * Plugins/WebPluginController.mm:
298         * WebCoreSupport/WebEditorClient.mm:
299         * WebCoreSupport/WebFrameLoaderClient.mm:
300         * WebCoreSupport/WebInspectorClient.h:
301         * WebCoreSupport/WebInspectorClient.mm:
302         * WebView/WebDataSource.mm:
303         * WebView/WebFrame.mm:
304         * WebView/WebHTMLRepresentation.mm:
305         * WebView/WebHTMLView.mm:
306         * WebView/WebPreferences.mm:
307         * WebView/WebScriptDebugDelegate.mm:
308         * WebView/WebScriptDebugger.h:
309         * WebView/WebTextIterator.mm:
310         * WebView/WebView.mm:
311         * WebView/WebViewData.mm:
312
313 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
314
315         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
316         https://bugs.webkit.org/show_bug.cgi?id=182312
317
318         Reviewed by Michael Catanzaro.
319
320         * WebKitPrefix.h:
321
322 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
323
324         [WebAuthN] Add a compile-time feature flag
325         https://bugs.webkit.org/show_bug.cgi?id=182211
326         <rdar://problem/36936365>
327
328         Reviewed by Brent Fulgham.
329
330         * Configurations/FeatureDefines.xcconfig:
331
332 2018-01-27  Dan Bernstein  <mitz@apple.com>
333
334         HaveInternalSDK includes should be "#include?"
335         https://bugs.webkit.org/show_bug.cgi?id=179670
336
337         * Configurations/Base.xcconfig:
338
339 2018-01-24  Alex Christensen  <achristensen@webkit.org>
340
341         Remove unused QTKit preference
342         https://bugs.webkit.org/show_bug.cgi?id=181968
343
344         Reviewed by Alexey Proskuryakov.
345
346         * WebView/WebPreferenceKeysPrivate.h:
347         * WebView/WebPreferences.mm:
348         (+[WebPreferences initialize]):
349         (-[WebPreferences setQTKitEnabled:]): Deleted.
350         (-[WebPreferences isQTKitEnabled]): Deleted.
351         * WebView/WebPreferencesPrivate.h:
352         * WebView/WebView.mm:
353         (-[WebView _preferencesChanged:]):
354
355 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
356
357         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
358         https://bugs.webkit.org/show_bug.cgi?id=182037
359         <rdar://problem/36747812>
360
361         Reviewed by Ryosuke Niwa.
362
363         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
364         for more details.
365
366         * WebView/WebHTMLRepresentation.mm:
367         (-[WebHTMLRepresentation elementWithName:inForm:]):
368         (-[WebHTMLRepresentation controlsInForm:]):
369
370 2018-01-23  Alex Christensen  <achristensen@webkit.org>
371
372         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
373         https://bugs.webkit.org/show_bug.cgi?id=181961
374
375         Reviewed by Michael Catanzaro.
376
377         * WebView/WebPreferences.mm:
378
379 2018-01-23  Commit Queue  <commit-queue@webkit.org>
380
381         Unreviewed, rolling out r227437.
382         https://bugs.webkit.org/show_bug.cgi?id=182011
383
384         broke build (Requested by alexchristensen on #webkit).
385
386         Reverted changeset:
387
388         "Remove unused QTKit preference"
389         https://bugs.webkit.org/show_bug.cgi?id=181968
390         https://trac.webkit.org/changeset/227437
391
392 2018-01-23  Alex Christensen  <achristensen@webkit.org>
393
394         Remove unused QTKit preference
395         https://bugs.webkit.org/show_bug.cgi?id=181968
396
397         Reviewed by Alexey Proskuryakov.
398
399         * WebView/WebPreferenceKeysPrivate.h:
400         * WebView/WebPreferences.mm:
401         (+[WebPreferences initialize]):
402         (-[WebPreferences setQTKitEnabled:]): Deleted.
403         (-[WebPreferences isQTKitEnabled]): Deleted.
404         * WebView/WebPreferencesPrivate.h:
405         * WebView/WebView.mm:
406         (-[WebView _preferencesChanged:]):
407
408 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
409
410         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
411         https://bugs.webkit.org/show_bug.cgi?id=181960
412         <rdar://problem/36431678>
413
414         Reviewed by Tim Horton.
415
416         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
417         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
418         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
419
420         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
421         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
422         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
423
424         * WebView/WebView.mm:
425         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
426
427 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
428
429         Turning off custom pasteboard data doesn't actually turn it off in WK2
430         https://bugs.webkit.org/show_bug.cgi?id=181920
431         <rdar://problem/36686429>
432
433         Reviewed by Wenson Hsieh.
434
435         Always disable custom pasteboard data in WebKit1. See r226156 for details.
436
437         * WebView/WebPreferences.mm:
438         (+[WebPreferences initialize]):
439         * WebView/WebView.mm:
440         (-[WebView _preferencesChanged:]):
441
442 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
443
444         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
445         https://bugs.webkit.org/show_bug.cgi?id=181918
446
447         Reviewed by Tim Horton.
448
449         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
450
451         * Configurations/FeatureDefines.xcconfig:
452
453 2018-01-20  Andy Estes  <aestes@apple.com>
454
455         [Apple Pay] Stop eagerly loading PassKit.framework
456         https://bugs.webkit.org/show_bug.cgi?id=181911
457         <rdar://problem/36555369>
458
459         Reviewed by Tim Horton.
460
461         * WebCoreSupport/WebPaymentCoordinatorClient.h:
462         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
463         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
464
465         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
466
467 2018-01-19  Dean Jackson  <dino@apple.com>
468
469         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
470         https://bugs.webkit.org/show_bug.cgi?id=181817
471         <rdar://problem/35274055>
472
473         Reviewed by Simon Fraser.
474
475         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
476
477         * Misc/WebKitVersionChecks.h:
478         * WebView/WebView.mm:
479         (-[WebView _commonInitializationWithFrameName:groupName:]):
480
481 2018-01-19  Alex Christensen  <achristensen@webkit.org>
482
483         Remove unused WebViewPrivate _allowCookies
484         https://bugs.webkit.org/show_bug.cgi?id=181812
485
486         Reviewed by Tim Horton.
487
488         * WebView/WebView.mm:
489         (+[WebView _setAllowCookies:]): Deleted.
490         (+[WebView _allowCookies]): Deleted.
491         * WebView/WebViewPrivate.h:
492
493 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
494
495         Build fix, remove a call to -[NSWindow setOneShot:]
496         https://bugs.webkit.org/show_bug.cgi?id=181809
497
498         Reviewed by Tim Horton.
499
500         * WebView/WebTextCompletionController.mm:
501         (-[WebTextCompletionController _buildUI]):
502
503 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
504
505         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
506
507         * Carbon/HIWebView.mm:
508         (overrideCGContext):
509         (restoreCGContext):
510
511 2018-01-18  Dan Bernstein  <mitz@apple.com>
512
513         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
514         https://bugs.webkit.org/show_bug.cgi?id=181803
515
516         Reviewed by Tim Horton.
517
518         * Configurations/Base.xcconfig: Updated.
519         * Configurations/DebugRelease.xcconfig: Ditto.
520         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
521         * Configurations/Version.xcconfig: Updated.
522         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
523           useful for defining settings that depend on the target macOS version.
524
525 2018-01-17  Youenn Fablet  <youenn@apple.com>
526
527         Put fetch Request.keepalive behind a runtime flag
528         https://bugs.webkit.org/show_bug.cgi?id=181592
529
530         Reviewed by Chris Dumez.
531
532         * WebView/WebPreferenceKeysPrivate.h:
533         * WebView/WebPreferences.mm:
534         (+[WebPreferences initialize]):
535         (-[WebPreferences fetchAPIKeepAliveEnabled]):
536         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
537         * WebView/WebPreferencesPrivate.h:
538         * WebView/WebView.mm:
539         (-[WebView _preferencesChanged:]):
540
541 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
542
543         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
544         https://bugs.webkit.org/show_bug.cgi?id=181637
545         <rdar://problem/36508471>
546
547         Reviewed by Tim Horton.
548
549         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
550
551         * WebCoreSupport/WebEditorClient.h:
552         * WebCoreSupport/WebEditorClient.mm:
553         (WebEditorClient::replacementURLForResource):
554
555 2018-01-11  Keith Miller  <keith_miller@apple.com>
556
557         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
558         https://bugs.webkit.org/show_bug.cgi?id=181573
559
560         Reviewed by Simon Fraser.
561
562         * Configurations/FeatureDefines.xcconfig:
563
564 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
565
566         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
567         https://bugs.webkit.org/show_bug.cgi?id=181497
568
569         Reviewed by Tim Horton.
570
571         See other ChangeLogs for more detail.
572
573         * WebCoreSupport/WebDragClient.h:
574
575 2018-01-11  Tim Horton  <timothy_horton@apple.com>
576
577         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
578         https://bugs.webkit.org/show_bug.cgi?id=181523
579         <rdar://problem/28959131>
580
581         Reviewed by Alex Christensen.
582
583         * WebView/WebImmediateActionController.mm:
584         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
585         Apply the change made in r216652 to WebKit1's immediate action controller.
586
587         Speculative (but successful in WebKit2) fix for non-reproducible crash when
588         the startContainer of the range is in an anonymous node.
589
590 2018-01-11  Youenn Fablet  <youenn@apple.com>
591
592         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
593         https://bugs.webkit.org/show_bug.cgi?id=181480
594
595         Reviewed by Eric Carlson.
596
597         * WebView/WebPreferences.mm:
598         (+[WebPreferences initialize]):
599
600 2018-01-08  David Kilzer  <ddkilzer@apple.com>
601
602         Fix check-webkit-style issues with WebNSDataExtras.mm
603         <https://webkit.org/b/181369>
604
605         Reviewed by Alex Christensen.
606
607         * Misc/WebNSDataExtras.mm:
608         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
609         (-[NSData _webkit_guessedMIMETypeForXML]):
610         (-[NSData _webkit_guessedMIMEType]):
611         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
612         (_findEOL):
613         (-[NSData _webkit_parseRFC822HeaderFields]):
614         (-[NSData _web_locationAfterFirstBlankLine]):
615         - Fix all the check-webkit-style warnings.
616
617 2018-01-08  David Kilzer  <ddkilzer@apple.com>
618
619         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
620         <https://webkit.org/b/181256>
621         <rdar://problem/36281730>
622
623         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
624         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
625         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
626           to avoid warnings from casting CFStringRef to NPNSString*.
627           Note that CFMutableStringRef is the same as CFStringRef
628           without the const modifier, hence its use in the const_cast<>
629           above.
630
631 2018-01-08  David Kilzer  <ddkilzer@apple.com>
632
633         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
634         <https://webkit.org/b/181256>
635         <rdar://problem/36281730>
636
637         * Carbon/HIWebView.mm:
638         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
639         checked_cf_cast<CFRunLoopRef>() to fix warning.
640
641 2018-01-07  David Kilzer  <ddkilzer@apple.com>
642
643         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
644         <https://webkit.org/b/181256>
645         <rdar://problem/36281730>
646
647         Reviewed by Darin Adler.
648
649         * Carbon/CarbonUtils.m:
650         (PoolCleaner):
651         - Use #pragmas to ignore -Wcast-qual warnings when using a
652           C-style cast from CFTypeRef to CFRunloopRef.
653         * Carbon/CarbonWindowFrame.m:
654         (-[CarbonWindowFrame title]):
655         - Use #pragmas to ignore -Wcast-qual warnings when using a
656           C-style cast from CFStringRef to NSString *.
657         * Carbon/HIViewAdapter.m:
658         (+[HIViewAdapter getHIViewForNSView:]):
659         - Use #pragmas to ignore -Wcast-qual warnings when using a
660           C-style cast from CFTypeRef to HIViewRef.
661         * Configurations/Base.xcconfig:
662         (WARNING_CFLAGS): Add -Wcast-qual.
663         * Misc/WebElementDictionary.mm:
664         (-[WebElementDictionary objectForKey:]):
665         - Use static_cast<SEL>(const_cast<void*>()) to fix
666           warning.
667         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
668         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
669         (-[NSData _webkit_guessedMIMETypeForXML]):
670         (-[NSData _webkit_guessedMIMEType]):
671         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
672         (_findEOL):
673         (-[NSData _webkit_parseRFC822HeaderFields]):
674         (-[NSData _web_startsWithBlankLine]):
675         (-[NSData _web_locationAfterFirstBlankLine]):
676         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
677           type to Objective-C++.  This fixes the warnings about
678           discarding the `const` modifier when casing from CFStringRef
679           to NSString * because in older clang versions, -Wcast-qual was
680           completely broken when compiling C++ and Objective-C++ source
681           files.  In newer clang versions, discarding the `const`
682           modifier for toll-free bridged types is ignored when compiling
683           Objective-C++ source.
684         - Update copyright and license header.
685         - Use reinterpret_cast<> and static_cast<> to fix warnings
686           unrelated to (NSString *) C-style casts.
687         - Replace use of MIN() macro with std::min<> template functions.
688         - Fix location of `*` for local variables modified above.
689         * Plugins/Hosted/NetscapePluginHostManager.mm:
690         (WebKit::NetscapePluginHostManager::spawnPluginHost):
691         (WebKit::NetscapePluginHostManager::initializeVendorPort):
692         (WebKit::NetscapePluginHostManager::instantiatePlugin):
693         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
694           warnings.
695         * Plugins/Hosted/NetscapePluginHostProxy.mm:
696         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
697         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
698           to fix warning.
699         * Plugins/Hosted/ProxyInstance.mm:
700         (WebKit::ProxyInstance::invoke):
701         - Use static_cast<char*>(const_cast<void*>()) to fix
702           warning when using -[NSData bytes].
703         (WebKit::ProxyInstance::fieldValue const):
704         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
705           to fix warning when using CFDataGetBytePtr().
706         * Plugins/Hosted/WebTextInputWindowController.m:
707         (-[WebTextInputPanel _interpretKeyEvent:string:]):
708         - Use #pragma to ignore -Wcast-qual warning since there
709           is not a good way to avoid this warning in Objective-C.
710         * Plugins/WebNetscapePluginStream.mm:
711         (WebNetscapePluginStream::deliverData):
712         - Use const_cast<void*>() to fix warning when using
713           -[NSData bytes].
714         * Plugins/WebNetscapePluginView.mm:
715         (-[WebNetscapePluginView _createPlugin]):
716         - Change C-style cast to const_cast<char*>() to fix
717           warning.
718         * WebCoreSupport/WebChromeClient.mm:
719         (WebChromeClient::wrapCryptoKey const):
720         (WebChromeClient::unwrapCryptoKey const):
721         - Change C-style cast to
722           static_cast<uint8_t*>(const_cast<void*>() to fix
723           warning.
724         * WebView/WebPDFView.mm:
725         (_applicationInfoForMIMEType):
726         - Change local variable type from 'NSURL *' to
727           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
728           when calling -[NSURL path].
729
730 2018-01-05  Dan Bernstein  <mitz@apple.com>
731
732         Fixed the build following AppKit API deprecations in a recent SDKs
733
734         * WebView/WebFullScreenController.mm:
735         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
736         (-[WebFullScreenController exitFullScreen]): Ditto.
737         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
738         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
739         * WebView/WebHTMLView.mm:
740         (-[WebHTMLView drawRect:]): Ditto.
741         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
742         (-[WebHTMLView knowsPageRange:]): Ditto.
743         * WebView/WebView.mm:
744         (LayerFlushController::flushLayers): Ditto.
745
746 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
747
748         [Attachment Support] Create attachment elements when dropping files on iOS
749         https://bugs.webkit.org/show_bug.cgi?id=181192
750         <rdar://problem/36280945>
751
752         Reviewed by Tim Horton.
753
754         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
755
756         * WebCoreSupport/WebPlatformStrategies.h:
757         * WebCoreSupport/WebPlatformStrategies.mm:
758         (WebPlatformStrategies::informationForItemAtIndex):
759         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
760
761 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
762
763         [Attachment Support] Add plumbing for starting a drag with promised blob data
764         https://bugs.webkit.org/show_bug.cgi?id=181201
765
766         Reviewed by Tim Horton.
767
768         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
769
770         * WebCoreSupport/WebDragClient.h:
771
772 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
773
774         Add a WebAuthentication runtime feature flag
775         https://bugs.webkit.org/show_bug.cgi?id=181220
776         <rdar://problem/36055305>
777
778         Reviewed by Brent Fulgham.
779
780         Renames the CredentialManagement runtime feature flag into WebAuthentication.
781
782         * WebView/WebPreferenceKeysPrivate.h:
783         * WebView/WebPreferences.mm:
784         (+[WebPreferences initialize]):
785         (-[WebPreferences webAuthenticationEnabled]):
786         (-[WebPreferences setWebAuthenticationEnabled:]):
787         (-[WebPreferences credentialManagementEnabled]): Deleted.
788         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
789         * WebView/WebPreferencesPrivate.h:
790         * WebView/WebView.mm:
791         (-[WebView _preferencesChanged:]):
792
793 2017-12-22  Jeff Miller  <jeffm@apple.com>
794
795         Update user-visible copyright strings to include 2018
796         https://bugs.webkit.org/show_bug.cgi?id=181141
797
798         Reviewed by Dan Bernstein.
799
800         * Info.plist:
801
802 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
803
804         [Attachment Support] Remove current macOS support for dragging file-backed attachments
805         https://bugs.webkit.org/show_bug.cgi?id=181188
806
807         Reviewed by Dan Bernstein.
808
809         See WebCore/ChangeLog for more detail.
810
811         * WebCoreSupport/WebDragClient.h:
812         * WebCoreSupport/WebDragClient.mm:
813         (WebDragClient::declareAndWriteAttachment): Deleted.
814         * WebView/WebHTMLView.mm:
815         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
816
817 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
818
819         Unreviewed, continue to fix build failures due to AppKit API deprecation
820
821         Wraps more code in -Wdeprecated-declarations.
822
823         * Carbon/HIWebView.mm:
824         (overrideCGContext):
825
826 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
827
828         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
829
830         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
831
832         * Carbon/CarbonWindowAdapter.mm:
833         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
834         * Plugins/WebNetscapePluginView.mm:
835         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
836         (-[WebNetscapePluginView sendDrawRectEvent:]):
837         (-[WebNetscapePluginView drawRect:]):
838
839 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
840
841         Fix build failures due to using deprecated AppKit symbols
842         https://bugs.webkit.org/show_bug.cgi?id=181110
843         <rdar://problem/36162865>
844
845         Reviewed by Dan Bernstein and Tim Horton.
846
847         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
848
849         * Misc/WebKitNSStringExtras.mm:
850         (-[NSString _web_drawAtPoint:font:textColor:]):
851         * Misc/WebNSPasteboardExtras.h:
852         * Misc/WebNSPasteboardExtras.mm:
853         (+[NSPasteboard _web_writableTypesForURL]):
854         (_createWritableTypesForImageWithoutArchive):
855         (_createWritableTypesForImageWithArchive):
856         (+[NSPasteboard _web_dragTypesForURL]):
857         (-[NSPasteboard _web_bestURL]):
858         (-[NSPasteboard _web_writeURL:andTitle:types:]):
859         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
860         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
861         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
862         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
863         * Panels/WebAuthenticationPanel.m:
864         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
865         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
866         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
867         (-[WebHostedNetscapePluginView drawRect:]):
868         * WebInspector/WebNodeHighlightView.mm:
869         (-[WebNodeHighlightView drawRect:]):
870         * WebView/WebFrame.mm:
871         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
872         (-[WebFrame _drawRect:contentsOnly:]):
873         * WebView/WebHTMLView.mm:
874         (kit):
875         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
876         (-[WebHTMLView _plainTextFromPasteboard:]):
877         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
878         (+[WebHTMLView _insertablePasteboardTypes]):
879         (+[WebHTMLView _selectionPasteboardTypes]):
880         (-[WebHTMLView pasteboard:provideDataForType:]):
881         (-[WebHTMLView _writeSelectionToPasteboard:]):
882         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
883         (-[WebHTMLView validRequestorForSendType:returnType:]):
884         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
885         (createMenuItem):
886         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
887         (-[WebHTMLView _colorAsString:]):
888         (-[WebHTMLView copyFont:]):
889         * WebView/WebPDFView.mm:
890         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
891         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
892         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
893         (-[WebPDFView pasteboardTypesForSelection]):
894         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
895         * WebView/WebView.h:
896         * WebView/WebView.mm:
897         (-[WebView performDragOperation:]):
898         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
899         (-[WebView _searchWithGoogleFromMenu:]):
900
901 2017-12-21  Youenn Fablet  <youenn@apple.com>
902
903         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
904         https://bugs.webkit.org/show_bug.cgi?id=181000
905
906         Reviewed by Chris Dumez.
907
908         * Misc/WebCache.mm:
909         (+[WebCache addImageToCache:forURL:forFrame:]):
910
911 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
912
913         Update FULLSCREEN_API feature defines.
914         https://bugs.webkit.org/show_bug.cgi?id=181015
915
916         Reviewed by Tim Horton.
917
918         Change enabled iphone sdk for FULLSCREEN_API.
919
920         * Configurations/FeatureDefines.xcconfig:
921
922 2017-12-21  Jer Noble  <jer.noble@apple.com>
923
924         Add initial DOM support for Media Capabilities
925         https://bugs.webkit.org/show_bug.cgi?id=181064
926
927         Reviewed by Eric Carlson.
928
929         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
930
931         * WebView/WebPreferenceKeysPrivate.h:
932         * WebView/WebPreferences.mm:
933         (+[WebPreferences initialize]):
934         (-[WebPreferences mediaCapabilitiesEnabled]):
935         (-[WebPreferences setMediaCapabilitiesEnabled:]):
936         * WebView/WebPreferencesPrivate.h:
937         * WebView/WebView.mm:
938         (-[WebView _preferencesChanged:]):
939
940 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
941
942         Enable picture-in-picture from inline element on suspend.
943         https://bugs.webkit.org/show_bug.cgi?id=180942
944         rdar://problem/34745234
945
946         Reviewed by Jer Noble.
947
948         Update signature of enterVideoFullscreenForVideoElement().
949
950         * WebCoreSupport/WebChromeClient.h:
951         * WebCoreSupport/WebChromeClient.mm:
952         (WebChromeClient::enterVideoFullscreenForVideoElement):
953
954 2017-12-20  Daniel Bates  <dabates@apple.com>
955
956         Remove Alternative Presentation Button
957         https://bugs.webkit.org/show_bug.cgi?id=180500
958         <rdar://problem/35891047>
959
960         Reviewed by Simon Fraser.
961
962         We no longer need the alternative presentation button.
963
964         * Configurations/FeatureDefines.xcconfig:
965
966 2017-12-19  Jer Noble  <jer.noble@apple.com>
967
968         Playing media elements which call "pause(); play()" will have the play promise rejected.
969         https://bugs.webkit.org/show_bug.cgi?id=180781
970         <rdar://problem/33191377>
971
972         Reviewed by Eric Carlson.
973
974         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
975
976         * WebView/WebView.mm:
977         (shouldRequireUserGestureToLoadVideo):
978
979 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
980
981         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
982         https://bugs.webkit.org/show_bug.cgi?id=180977
983
984         Reviewed by Tim Horton.
985
986         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
987         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
988         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
989
990         * WebCoreSupport/WebEditorClient.mm:
991         (attributesForAttributedStringConversion):
992         * WebView/WebHTMLView.mm:
993         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
994
995 2017-12-18  David Kilzer  <ddkilzer@apple.com>
996
997         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
998
999         Attempt to fix the following warnings:
1000
1001             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1002
1003         For the following instance variables:
1004
1005             _borderView
1006             _contentView
1007             _frame
1008             _wFlags
1009
1010         * Carbon/CarbonWindowAdapter.mm:
1011         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1012         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1013         (-[CarbonWindowAdapter _termWindowIfOwner]):
1014         (-[CarbonWindowAdapter _windowMovedToRect:]):
1015         (-[CarbonWindowAdapter setContentView:]):
1016         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1017         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1018
1019 2017-12-16  Dan Bernstein  <mitz@apple.com>
1020
1021         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1022         https://bugs.webkit.org/show_bug.cgi?id=180613
1023         <rdar://problem/35946124>
1024
1025         Reviewed by Geoff Garen.
1026
1027         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1028           clients.
1029         * WebView/WebDynamicScrollBarsView.h: Ditto.
1030         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1031
1032 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1033
1034         Enable -Wstrict-prototypes for WebKit
1035         <https://webkit.org/b/180757>
1036         <rdar://problem/36024132>
1037
1038         Rubber-stamped by Joseph Pecoraro.
1039
1040         * Configurations/Base.xcconfig:
1041         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1042
1043 2017-12-14  John Wilander  <wilander@apple.com>
1044
1045         Storage Access API: Implement frame-specific access in the document.cookie layer
1046         https://bugs.webkit.org/show_bug.cgi?id=180682
1047         <rdar://problem/35982257>
1048
1049         Reviewed by Alex Christensen.
1050
1051         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1052         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1053         CookiesStrategy::getRawCookies() now take optional parameters for
1054         frameID and pageID to allow frame-specific scoping of cookies.
1055
1056         This change makes the return values of FrameLoaderClient::frameID()
1057         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1058         WebCore can call those getters and get the right return values in
1059         WebKit and std:nullopt in WebKitLegacy.
1060
1061         * WebCoreSupport/WebFrameLoaderClient.h:
1062         * WebCoreSupport/WebFrameLoaderClient.mm:
1063         (WebFrameLoaderClient::pageID const):
1064         (WebFrameLoaderClient::frameID const):
1065         * WebCoreSupport/WebPlatformStrategies.h:
1066         * WebCoreSupport/WebPlatformStrategies.mm:
1067         (WebPlatformStrategies::cookiesForDOM):
1068         (WebPlatformStrategies::setCookiesFromDOM):
1069         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1070         (WebPlatformStrategies::getRawCookies):
1071
1072 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1073
1074         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1075         https://bugs.webkit.org/show_bug.cgi?id=180689
1076
1077         Reviewed by Tim Horton.
1078
1079         Use sRGBColorSpaceRef() from WebCore.
1080
1081         * WebView/WebHTMLView.mm:
1082         (imageFromRect):
1083
1084 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1085
1086         Stop using deprecated target conditional for simulator builds
1087         https://bugs.webkit.org/show_bug.cgi?id=180662
1088         <rdar://problem/35136156>
1089
1090         Reviewed by Simon Fraser.
1091
1092         * postprocess-headers.sh:
1093
1094 2017-12-11  David Quesada  <david_quesada@apple.com>
1095
1096         Turn on ENABLE_APPLICATION_MANIFEST
1097         https://bugs.webkit.org/show_bug.cgi?id=180562
1098         rdar://problem/35924737
1099
1100         Reviewed by Geoffrey Garen.
1101
1102         * Configurations/FeatureDefines.xcconfig:
1103
1104 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1105
1106         Remove pthread_once in favor of dispatch_once
1107         https://bugs.webkit.org/show_bug.cgi?id=180591
1108
1109         Reviewed by Saam Barati.
1110
1111         * Misc/WebKitErrors.m:
1112         (+[NSError _registerWebKitErrors]):
1113         (registerErrors): Deleted.
1114         * Storage/WebStorageManager.mm:
1115         (+[WebStorageManager _storageDirectoryPath]):
1116         (initializeLocalStoragePath): Deleted.
1117
1118 2017-12-07  Darin Adler  <darin@apple.com>
1119
1120         Remove some unused code from WebKitLegacy
1121         https://bugs.webkit.org/show_bug.cgi?id=180567
1122
1123         Reviewed by Anders Carlsson.
1124
1125         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1126         macOS (back a few versions) and iOS and removed unused
1127         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1128         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1129         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1130         _webkit_stringByCollapsingNonPrintingCharacters,
1131         _webkit_stringByCollapsingWhitespaceCharacters,
1132         _web_stringWithData:textEncodingName:, and
1133         _webkit_localStorageDirectoryWithBundleIdentifier:.
1134
1135         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1136         this source file.
1137         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1138         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1139         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1140         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1141         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1142         handle font smoothing options.
1143         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1144         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1145         from header and made it a little clearer.
1146         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1147         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1148         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1149         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1150         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1151         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1152         implementation a bit and used whole words instead of abbreviations.
1153         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1154
1155         * Misc/WebNSFileManagerExtras.mm:
1156         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1157         filenameByFixingIllegalCharacters function from WebCore directly instead of
1158         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1159
1160         * Plugins/WebBaseNetscapePluginView.mm:
1161         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1162         string replacements instead of _web_stringByStrippingReturnCharacters
1163         and to use NSString methods instead of CFString functions.
1164
1165 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1166
1167         Ignore deprecation warnings.
1168
1169         * WebView/WebHTMLView.mm:
1170         (-[NSWindow _web_borderView]):
1171         (-[WebHTMLView _setAsideSubviews]):
1172         * WebView/WebView.mm:
1173         (-[WebView encodeWithCoder:]):
1174
1175 2017-12-02  Darin Adler  <darin@apple.com>
1176
1177         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1178         https://bugs.webkit.org/show_bug.cgi?id=180009
1179
1180         Reviewed by Alex Christensen.
1181
1182         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1183
1184         * Plugins/WebBaseNetscapePluginView.mm:
1185         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1186         of strcasecmp.
1187
1188         * WebView/WebPreferences.mm:
1189         (contains): Ditto. Also made this a template so it's easier to call on an array.
1190         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1191
1192 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1193
1194         Limit user agent versioning to an upper bound
1195         https://bugs.webkit.org/show_bug.cgi?id=180365
1196         <rdar://problem/34550617>
1197
1198         Reviewed by Joseph Pecoraro.
1199
1200         * WebView/WebView.mm:
1201         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1202         creating the User Agent string.
1203         (webKitBundleVersionString): Deleted.
1204
1205 2017-12-05  Andy Estes  <aestes@apple.com>
1206
1207         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1208         https://bugs.webkit.org/show_bug.cgi?id=180457
1209         <rdar://problem/35143007>
1210
1211         Reviewed by Tim Horton.
1212
1213         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1214         check for this macro during post-processing.
1215
1216         * postprocess-headers.sh:
1217
1218 2017-12-04  David Quesada  <david_quesada@apple.com>
1219
1220         Add a class for parsing application manifests
1221         https://bugs.webkit.org/show_bug.cgi?id=177973
1222         rdar://problem/34747949
1223
1224         Reviewed by Geoffrey Garen.
1225
1226         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1227
1228 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1229
1230         Make LegacyCustomProtocolManager optional for network process
1231         https://bugs.webkit.org/show_bug.cgi?id=176230
1232
1233         Reviewed by Alex Christensen.
1234
1235         * Configurations/FeatureDefines.xcconfig:
1236
1237 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1238
1239         Fix some NSOperationQueue leaks
1240         https://bugs.webkit.org/show_bug.cgi?id=180221
1241
1242         Reviewed by Wenson Hsieh.
1243
1244         * WebView/WebView.mm:
1245         (-[WebView performDragOperation:]):
1246
1247 2017-11-30  Darin Adler  <darin@apple.com>
1248
1249         [Mac] remove unneeded RetainPtr use introduced in r225142
1250         https://bugs.webkit.org/show_bug.cgi?id=180202
1251
1252         Reviewed by Tim Horton.
1253
1254         * WebView/WebImmediateActionController.mm:
1255         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1256         RetainPtr.
1257
1258 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1259
1260         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1261         https://bugs.webkit.org/show_bug.cgi?id=175595
1262
1263         Reviewed by Darin Adler.
1264
1265         * WebView/WebPreferences.mm:
1266
1267 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1268
1269         One too many zeroes in macOS version number in FeatureDefines
1270         https://bugs.webkit.org/show_bug.cgi?id=180011
1271
1272         Reviewed by Dan Bernstein.
1273
1274         * Configurations/FeatureDefines.xcconfig:
1275
1276 2017-11-23  Darin Adler  <darin@apple.com>
1277
1278         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1279         https://bugs.webkit.org/show_bug.cgi?id=179981
1280
1281         Reviewed by Sam Weinig.
1282
1283         * WebView/WebImmediateActionController.mm:
1284         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1285         * WebView/WebView.mm:
1286         (coreOptions): Use |= instead of | to build up FindOptions.
1287
1288 2017-11-23  Sam Weinig  <sam@webkit.org>
1289
1290         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1291         https://bugs.webkit.org/show_bug.cgi?id=179954
1292
1293         Reviewed by Darin Adler.
1294
1295         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1296         with direct calls to the corresponding UserGestureIndicator functions.
1297
1298         * Plugins/WebPluginController.mm:
1299         (-[WebPluginController processingUserGesture]):
1300         * WebView/WebView.mm:
1301         (-[WebView _isProcessingUserGesture]):
1302
1303 2017-11-23  Darin Adler  <darin@apple.com>
1304
1305         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1306         https://bugs.webkit.org/show_bug.cgi?id=179907
1307
1308         Reviewed by Sam Weinig.
1309
1310         * History/BinaryPropertyList.cpp:
1311         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1312         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1313         * WebView/WebHTMLRepresentation.mm:
1314         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1315         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1316
1317 2017-11-22  Ali Juma  <ajuma@chromium.org>
1318
1319         Implement VisualViewport API attributes
1320         https://bugs.webkit.org/show_bug.cgi?id=179385
1321
1322         Reviewed by Frédéric Wang.
1323
1324         Add a VisualViewportAPI preference.
1325
1326         * WebView/WebPreferenceKeysPrivate.h:
1327         * WebView/WebPreferences.mm:
1328         (+[WebPreferences initialize]):
1329         (-[WebPreferences visualViewportAPIEnabled]):
1330         (-[WebPreferences setVisualViewportAPIEnabled:]):
1331         * WebView/WebPreferencesPrivate.h:
1332         * WebView/WebView.mm:
1333         (-[WebView _preferencesChanged:]):
1334
1335 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1336
1337         WebCoreObjCExtras.h is being included in too many places
1338         https://bugs.webkit.org/show_bug.cgi?id=179931
1339
1340         Reviewed by Darin Adler.
1341
1342         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1343         * Plugins/WebBaseNetscapePluginView.mm:
1344         * Plugins/WebBasePluginPackage.mm:
1345         * Plugins/WebNetscapePluginStream.mm:
1346         * Plugins/WebNetscapePluginView.mm:
1347         * WebView/WebTextIterator.mm:
1348         * WebView/WebViewData.mm:
1349
1350 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1351
1352         Unreviewed, rolling out r225093.
1353         https://bugs.webkit.org/show_bug.cgi?id=179938
1354
1355         Compilation failed on WinCairo 64-bit Release (Requested by
1356         fredw on #webkit).
1357
1358         Reverted changeset:
1359
1360         "Implement VisualViewport API attributes"
1361         https://bugs.webkit.org/show_bug.cgi?id=179385
1362         https://trac.webkit.org/changeset/225093
1363
1364 2017-11-21  Ali Juma  <ajuma@chromium.org>
1365
1366         Implement VisualViewport API attributes
1367         https://bugs.webkit.org/show_bug.cgi?id=179385
1368
1369         Reviewed by Frédéric Wang.
1370
1371         Add a VisualViewportAPI preference.
1372
1373         * WebView/WebPreferenceKeysPrivate.h:
1374         * WebView/WebPreferences.mm:
1375         (+[WebPreferences initialize]):
1376         (-[WebPreferences visualViewportAPIEnabled]):
1377         (-[WebPreferences setVisualViewportAPIEnabled:]):
1378         * WebView/WebPreferencesPrivate.h:
1379         * WebView/WebView.mm:
1380         (-[WebView _preferencesChanged:]):
1381
1382 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1383
1384         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1385         https://bugs.webkit.org/show_bug.cgi?id=179504
1386
1387         Reviewed by Darin Adler.
1388
1389         * Misc/WebKitNSStringExtras.mm:
1390         * Plugins/Hosted/NetscapePluginHostManager.mm:
1391         * Plugins/WebBasePluginPackage.mm:
1392
1393 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1394
1395         Remove unused TOUCH_ICON_LOADING feature flag
1396         https://bugs.webkit.org/show_bug.cgi?id=179873
1397
1398         Reviewed by Simon Fraser.
1399
1400         * Configurations/FeatureDefines.xcconfig:
1401
1402 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1403
1404         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1405         https://bugs.webkit.org/show_bug.cgi?id=179872
1406
1407         Reviewed by Darin Adler.
1408
1409         * Configurations/FeatureDefines.xcconfig:
1410
1411 2017-11-16  Daniel Bates  <dabates@apple.com>
1412
1413         Add feature define for alternative presentation button element
1414         https://bugs.webkit.org/show_bug.cgi?id=179692
1415         Part of <rdar://problem/34917108>
1416
1417         Reviewed by Andy Estes.
1418
1419         Only enabled on Cocoa platforms by default.
1420
1421         * Configurations/FeatureDefines.xcconfig:
1422
1423 2017-11-14  Nan Wang  <n_wang@apple.com>
1424
1425         AX: AOM: Implement AccessibleNode class and support label and role attributes
1426         https://bugs.webkit.org/show_bug.cgi?id=179494
1427
1428         Reviewed by Ryosuke Niwa.
1429
1430         * WebView/WebPreferenceKeysPrivate.h:
1431         * WebView/WebPreferences.mm:
1432         (+[WebPreferences initialize]):
1433         (-[WebPreferences accessibilityObjectModelEnabled]):
1434         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1435         * WebView/WebPreferencesPrivate.h:
1436         * WebView/WebView.mm:
1437         (-[WebView _preferencesChanged:]):
1438
1439 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1440
1441         Remove Cocoa CFURLConnection loading code
1442         https://bugs.webkit.org/show_bug.cgi?id=179688
1443
1444         Reviewed by Antti Koivisto.
1445
1446         * Misc/WebDownload.mm:
1447         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1448         * Misc/WebDownloadInternal.h:
1449         * Plugins/WebBaseNetscapePluginView.mm:
1450         * WebCoreSupport/WebFrameLoaderClient.mm:
1451         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1452         * WebView/WebView.mm:
1453         (-[WebView scheduleInRunLoop:forMode:]):
1454         (-[WebView unscheduleFromRunLoop:forMode:]):
1455
1456 2017-11-14  Daniel Bates  <dabates@apple.com>
1457
1458         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1459         for feature defines
1460
1461         Following r195498 and r201917 the Visual Studio property files for feature defines have
1462         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1463         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1464         files.
1465
1466         * Configurations/FeatureDefines.xcconfig:
1467
1468 2017-11-14  Jer Noble  <jer.noble@apple.com>
1469
1470         Enable Modern EME tests in DumpRenderTree
1471         https://bugs.webkit.org/show_bug.cgi?id=179544
1472
1473         Reviewed by Alex Christensen.
1474
1475         Add a WebPreferences property to enable the (modern) EME API.
1476
1477         * WebView/WebPreferenceKeysPrivate.h:
1478         * WebView/WebPreferences.mm:
1479         (+[WebPreferences initialize]):
1480         (-[WebPreferences encryptedMediaAPIEnabled]):
1481         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1482         * WebView/WebPreferencesPrivate.h:
1483         * WebView/WebView.mm:
1484         (-[WebView _preferencesChanged:]):
1485
1486 2017-11-14  Antti Koivisto  <antti@apple.com>
1487
1488         Enable display:contents by default
1489         https://bugs.webkit.org/show_bug.cgi?id=179655
1490
1491         Reviewed by Sam Weinig.
1492
1493         * WebView/WebPreferences.mm:
1494         (+[WebPreferences initialize]):
1495
1496 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1497
1498         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1499         https://bugs.webkit.org/show_bug.cgi?id=178751
1500
1501         Reviewed by Brady Eidson.
1502
1503         * WebCoreSupport/WebFrameNetworkingContext.mm:
1504         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1505
1506 2017-11-08  Keith Miller  <keith_miller@apple.com>
1507
1508         Async iteration should only fetch the next method once and add feature flag
1509         https://bugs.webkit.org/show_bug.cgi?id=179451
1510
1511         Reviewed by Geoffrey Garen.
1512
1513         Add feature flag for Async iteration.
1514
1515         * Configurations/FeatureDefines.xcconfig:
1516
1517 2017-11-13  Mark Lam  <mark.lam@apple.com>
1518
1519         Add more overflow check book-keeping for MarkedArgumentBuffer.
1520         https://bugs.webkit.org/show_bug.cgi?id=179634
1521         <rdar://problem/35492517>
1522
1523         Reviewed by Saam Barati.
1524
1525         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1526         (WebKit::NetscapePluginInstanceProxy::invoke):
1527         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1528         (WebKit::NetscapePluginInstanceProxy::construct):
1529
1530 2017-11-12  Darin Adler  <darin@apple.com>
1531
1532         More is<> and downcast<>, less static_cast<>
1533         https://bugs.webkit.org/show_bug.cgi?id=179600
1534
1535         Reviewed by Chris Dumez.
1536
1537         * DOM/DOM.mm:
1538         (kit): Use is/downcast.
1539         * WebCoreSupport/WebEditorClient.mm:
1540         (WebEditorClient::handleKeyboardEvent): Ditto.
1541         (WebEditorClient::handleInputMethodKeydown): Ditto.
1542         * WebView/WebHTMLView.mm:
1543         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
1544
1545 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
1546
1547         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
1548         https://bugs.webkit.org/show_bug.cgi?id=179397
1549
1550         Reviewed by Wenson Hsieh.
1551
1552         * DOM/DOMHTMLInputElement.mm:
1553         (-[DOMHTMLInputElement insertTextSuggestion:]):
1554
1555 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
1556
1557         HTMLMediaElement should not use element fullscreen on iOS
1558         https://bugs.webkit.org/show_bug.cgi?id=179418
1559         rdar://problem/35409277
1560
1561         Reviewed by Eric Carlson.
1562
1563         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
1564
1565         * Configurations/FeatureDefines.xcconfig:
1566
1567 2017-11-06  Alex Christensen  <achristensen@webkit.org>
1568
1569         Make ResourceLoader::willSendRequestInternal asynchronous
1570         https://bugs.webkit.org/show_bug.cgi?id=179251
1571
1572         Reviewed by Andy Estes.
1573
1574         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1575         (WebKit::HostedNetscapePluginStream::start):
1576         * Plugins/WebNetscapePluginStream.mm:
1577         (WebNetscapePluginStream::start):
1578
1579 2017-11-01  Darin Adler  <darin@apple.com>
1580
1581         Simplify event dispatch code and make it a bit more consistent
1582         https://bugs.webkit.org/show_bug.cgi?id=178991
1583
1584         Reviewed by Chris Dumez.
1585
1586         * DOM/DOMEvent.mm:
1587         (-[DOMEvent srcElement]): Call target instead of srcElement.
1588
1589 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
1590
1591         [Touch Bar Web API] Add support for menuitem tag
1592         https://bugs.webkit.org/show_bug.cgi?id=179020
1593
1594         Reviewed by Ryosuke Niwa.
1595
1596         Adds in properties and methods that allow the menuitem runtime feature
1597         to be enabled or disabled.
1598
1599         * WebView/WebPreferenceKeysPrivate.h:
1600         * WebView/WebPreferences.mm:
1601         (-[WebPreferences menuItemElementEnabled]):
1602         (-[WebPreferences setMenuItemElementEnabled:]):
1603         * WebView/WebPreferencesPrivate.h:
1604         * WebView/WebView.mm:
1605         (-[WebView _preferencesChanged:]):
1606
1607 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1608
1609         Use CompletionHandlers for redirects
1610         https://bugs.webkit.org/show_bug.cgi?id=179163
1611
1612         Reviewed by Tim Horton.
1613
1614         * Plugins/Hosted/HostedNetscapePluginStream.h:
1615         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1616         (WebKit::HostedNetscapePluginStream::willSendRequest):
1617         * Plugins/WebNetscapePluginStream.h:
1618         * Plugins/WebNetscapePluginStream.mm:
1619         (WebNetscapePluginStream::willSendRequest):
1620
1621 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1622
1623         Add a FileSystem namespace to FileSystem.cpp
1624         https://bugs.webkit.org/show_bug.cgi?id=179063
1625
1626         Reviewed by Darin Adler.
1627
1628         * Misc/WebNSFileManagerExtras.mm:
1629         * Storage/WebDatabaseProvider.mm:
1630
1631 2017-11-02  Frederic Wang  <fwang@igalia.com>
1632
1633         Add references to bug 179167 in FIXME comments
1634         https://bugs.webkit.org/show_bug.cgi?id=179168
1635
1636         Reviewed by Daniel Bates.
1637
1638         * Configurations/FeatureDefines.xcconfig:
1639
1640 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
1641
1642         Implement WKFullscreenWindowController for iOS.
1643         https://bugs.webkit.org/show_bug.cgi?id=178924
1644         rdar://problem/34697120
1645
1646         Reviewed by Simon Fraser.
1647
1648         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
1649
1650         * Configurations/FeatureDefines.xcconfig:
1651         * WebView/WebView.mm:
1652         (-[WebView fullScreenPlaceholderView]):
1653
1654 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1655
1656         Clean up some drag and drop feature flags
1657         https://bugs.webkit.org/show_bug.cgi?id=179082
1658
1659         Reviewed by Simon Fraser.
1660
1661         * Configurations/FeatureDefines.xcconfig:
1662
1663 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
1664
1665         Make it possible to test rubber-banding in overflow scroll
1666         https://bugs.webkit.org/show_bug.cgi?id=179078
1667
1668         Reviewed by Sam Weinig.
1669
1670         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
1671         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
1672
1673         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
1674         functions, since most callers want clamped.
1675
1676         * DOM/DOMHTML.mm:
1677         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
1678
1679 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1680
1681         Fix up some content filtering feature flags
1682         https://bugs.webkit.org/show_bug.cgi?id=179079
1683
1684         Reviewed by Simon Fraser.
1685
1686         * Configurations/FeatureDefines.xcconfig:
1687
1688 2017-10-28  Zalan Bujtas  <zalan@apple.com>
1689
1690         [FrameView::layout cleanup] Move core layout logic to a separate class.
1691         https://bugs.webkit.org/show_bug.cgi?id=178771
1692         <rdar://problem/35166542>
1693
1694         Reviewed by Simon Fraser.
1695
1696         Move layout code out from FrameView to LayoutContext.
1697
1698         * WebView/WebClipView.mm:
1699         (-[WebClipView _immediateScrollToPoint:]):
1700         * WebView/WebFrame.mm:
1701         (-[WebFrame layoutCount]):
1702
1703 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
1704
1705         Fix issues with WebView subframe painting
1706         https://bugs.webkit.org/show_bug.cgi?id=178842
1707         rdar://problem/34072253
1708
1709         Reviewed by Daniel Bates.
1710         
1711         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
1712         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
1713         High Sierra, so match the new signature.
1714
1715         Also rename the 'rect' param to 'displayRect' to match AppKit code.
1716
1717         * WebView/WebHTMLView.mm:
1718         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1719         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1720
1721 2017-10-25  Youenn Fablet  <youenn@apple.com>
1722
1723         Enable ServiceWorker to fetch resources
1724         https://bugs.webkit.org/show_bug.cgi?id=178673
1725
1726         Reviewed by Brady Eidson.
1727
1728         * WebCoreSupport/WebFrameLoaderClient.mm:
1729         (WebFrameLoaderClient::pageID const):
1730         (WebFrameLoaderClient::frameID const):
1731         (WebFrameLoaderClient::sessionID const):
1732
1733         Added implementation to the new getters.
1734         They are noop in the context of WK1.
1735
1736 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
1737
1738         Web Inspector: Enable WebKit logging configuration and display
1739         https://bugs.webkit.org/show_bug.cgi?id=177027
1740         <rdar://problem/33964767>
1741
1742         Reviewed by Joseph Pecoraro.
1743
1744         * WebCoreSupport/WebChromeClient.mm:
1745         (stringForMessageSource): Deal with Media and WebRTC message sources.
1746
1747 2017-10-20  Antoine Quint  <graouts@apple.com>
1748
1749         [Web Animations] Provide basic timeline and animation interfaces
1750         https://bugs.webkit.org/show_bug.cgi?id=178526
1751
1752         Reviewed by Dean Jackson.
1753
1754         Remove the WEB_ANIMATIONS compile-time flag.
1755
1756         * Configurations/FeatureDefines.xcconfig:
1757         * WebView/WebPreferences.mm:
1758         (+[WebPreferences initialize]):
1759         * WebView/WebView.mm:
1760         (-[WebView _preferencesChanged:]):
1761
1762 2017-10-19  Sam Weinig  <sam@webkit.org>
1763
1764         [Settings] Move global settings into their own file
1765         https://bugs.webkit.org/show_bug.cgi?id=178512
1766
1767         Reviewed by Darin Adler.
1768
1769         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
1770
1771         * WebCoreSupport/WebChromeClient.mm:
1772         (WebChromeClient::supportsVideoFullscreen):
1773         * WebView/WebDynamicScrollBarsView.mm:
1774         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
1775         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
1776         * WebView/WebPreferences.mm:
1777         (+[WebPreferences initialize]):
1778         * WebView/WebView.mm:
1779         (-[WebView _commonInitializationWithFrameName:groupName:]):
1780         (-[WebView _preferencesChanged:]):
1781         (+[WebView _doNotStartObservingNetworkReachability]):
1782
1783 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
1784
1785         Replace some stack raw pointers with RefPtrs within WebCore/html
1786         https://bugs.webkit.org/show_bug.cgi?id=178201
1787         <rdar://problem/34841692>
1788
1789         Reviewed by Ryosuke Niwa.
1790
1791         * DOM/DOM.mm:
1792         (kit):
1793         Change the type of node as toNode() is changed to return RefPtr.
1794
1795 2017-10-18  Chris Dumez  <cdumez@apple.com>
1796
1797         [Service Worker] Add stubs for Client / WindowClient / Clients
1798         https://bugs.webkit.org/show_bug.cgi?id=178469
1799
1800         Reviewed by Youenn Fablet.
1801
1802         Rename PageVisiblityState to VisibilityState.
1803
1804         * WebView/WebView.mm:
1805         (kit):
1806
1807 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1808
1809         Unreviewed, rolling out r223291.
1810
1811         See WebCore ChangeLog for more detail.
1812
1813         Reverted changeset:
1814
1815         "Remove Editor::simplifyMarkup"
1816         https://bugs.webkit.org/show_bug.cgi?id=178271
1817         https://trac.webkit.org/changeset/223291
1818
1819 2017-10-17  Keith Miller  <keith_miller@apple.com>
1820
1821         Change WebCore sources to work with unified source builds
1822         https://bugs.webkit.org/show_bug.cgi?id=178229
1823
1824         Rubber stamped by Tim Horton.
1825
1826         * Configurations/FeatureDefines.xcconfig:
1827
1828 2017-10-16  Sam Weinig  <sam@webkit.org>
1829
1830         [Settings] Remove all custom code from Settings.h/cpp
1831         https://bugs.webkit.org/show_bug.cgi?id=178330
1832
1833         Reviewed by Simon Fraser.
1834
1835         * WebView/WebPreferences.mm:
1836         (+[WebPreferences initialize]):
1837         
1838             Update for naming changes of FrameFlattening now that it is an enum class.
1839
1840 2017-10-13  Alex Christensen  <achristensen@webkit.org>
1841
1842         Remove Editor::simplifyMarkup
1843         https://bugs.webkit.org/show_bug.cgi?id=178271
1844
1845         Reviewed by Wenson Hsieh.
1846
1847         * WebView/WebView.mm:
1848         (-[WebView _simplifyMarkup:endNode:]):
1849
1850 2017-10-12  Chris Dumez  <cdumez@apple.com>
1851
1852         [Mac] Add support for MouseEvent.buttons
1853         https://bugs.webkit.org/show_bug.cgi?id=178214
1854
1855         Reviewed by Ryosuke Niwa.
1856
1857         * WebView/WebPDFView.mm:
1858         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1859
1860 2017-10-11  Sam Weinig  <sam@webkit.org>
1861
1862         Remove out-parameter variants of copyToVector
1863         https://bugs.webkit.org/show_bug.cgi?id=178155
1864
1865         Reviewed by Tim Horton.
1866
1867         * Plugins/WebNetscapePluginView.mm:
1868         (-[WebNetscapePluginView destroyPlugin]):
1869         * WebView/WebHTMLRepresentation.mm:
1870         (newArrayWithStrings):
1871
1872             Replace out-parameter based copyToVector, with one that returns a Vector.
1873
1874 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
1875
1876         Sanitize URL in pasteboard for other applications and cross origin content
1877         https://bugs.webkit.org/show_bug.cgi?id=178060
1878         <rdar://problem/34874518>
1879
1880         Reviewed by Wenson Hsieh.
1881
1882         * WebCoreSupport/WebPlatformStrategies.h:
1883         * WebCoreSupport/WebPlatformStrategies.mm:
1884         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
1885
1886 2017-10-11  Chris Dumez  <cdumez@apple.com>
1887
1888         Modernize Geolocation code
1889         https://bugs.webkit.org/show_bug.cgi?id=178148
1890
1891         Reviewed by Ryosuke Niwa.
1892
1893         * WebCoreSupport/WebGeolocationClient.h:
1894         * WebCoreSupport/WebGeolocationClient.mm:
1895         (WebGeolocationClient::lastPosition):
1896         * WebView/WebGeolocationPosition.mm:
1897         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
1898         (core):
1899         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
1900         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1901         * WebView/WebGeolocationPositionInternal.h:
1902
1903 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
1904
1905         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
1906         https://bugs.webkit.org/show_bug.cgi?id=178154
1907
1908         Reviewed by Wenson Hsieh.
1909
1910         Enable custom pasteboard data by default.
1911
1912         * WebView/WebPreferenceKeysPrivate.h:
1913         * WebView/WebPreferences.mm:
1914         (+[WebPreferences initialize]):
1915         (-[WebPreferences customPasteboardDataEnabled]): Added.
1916         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
1917         * WebView/WebPreferencesPrivate.h:
1918         * WebView/WebView.mm:
1919         (-[WebView _preferencesChanged:]):
1920
1921 2017-10-10  Sam Weinig  <sam@webkit.org>
1922
1923         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
1924         https://bugs.webkit.org/show_bug.cgi?id=178102
1925
1926         Reviewed by Tim Horton.
1927
1928         * History/WebHistory.mm:
1929         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
1930         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1931         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
1932         * WebCoreSupport/WebUserMediaClient.mm:
1933         (WebUserMediaClient::pageDestroyed):
1934
1935 2017-10-09  Robin Morisset  <rmorisset@apple.com>
1936
1937         Make the names of the options consistent
1938         https://bugs.webkit.org/show_bug.cgi?id=177933
1939
1940         Reviewed by Saam Barati.
1941
1942         * WebView/WebFrame.h:
1943         * WebView/WebHTMLView.mm:
1944         (-[WebHTMLView setMarkedText:selectedRange:]):
1945         * WebView/WebView.h:
1946
1947 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1948
1949         [iOS] Tweak support for classifying form controls (followup to r222487)
1950         https://bugs.webkit.org/show_bug.cgi?id=177917
1951         <rdar://problem/34820122>
1952
1953         Reviewed by Dean Jackson.
1954
1955         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
1956
1957         * DOM/DOMHTMLInputElement.mm:
1958         (-[DOMHTMLInputElement _autofillContext]):
1959         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
1960         (-[DOMHTMLInputElement representingPageURL]): Deleted.
1961
1962 2017-10-05  Keith Miller  <keith_miller@apple.com>
1963
1964         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
1965
1966         * Configurations/WebKitLegacy.xcconfig:
1967
1968 2017-10-05  Jer Noble  <jer.noble@apple.com>
1969
1970         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
1971         https://bugs.webkit.org/show_bug.cgi?id=177261
1972
1973         Reviewed by Eric Carlson.
1974
1975         * Configurations/FeatureDefines.xcconfig:
1976
1977 2017-10-05  Chris Dumez  <cdumez@apple.com>
1978
1979         Drop unused parameters for CookiesStrategy::cookiesEnabled()
1980         https://bugs.webkit.org/show_bug.cgi?id=177957
1981
1982         Reviewed by Alex Christensen.
1983
1984         * WebCoreSupport/WebPlatformStrategies.h:
1985         * WebCoreSupport/WebPlatformStrategies.mm:
1986         (WebPlatformStrategies::cookiesEnabled):
1987
1988 2017-10-05  Youenn Fablet  <youenn@apple.com>
1989
1990         Make LibWebRTCProvider port agnostic
1991         https://bugs.webkit.org/show_bug.cgi?id=177747
1992
1993         Reviewed by Alex Christensen & Alex Garcia.
1994
1995         * WebView/WebView.mm:
1996         (-[WebView _commonInitializationWithFrameName:groupName:]):
1997         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1998
1999 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2000
2001         Stop linking with WebKitSystemInterface
2002         https://bugs.webkit.org/show_bug.cgi?id=177915
2003
2004         Reviewed by Antti Koivisto.
2005
2006         * Configurations/DebugRelease.xcconfig:
2007         * Configurations/WebKitLegacy.xcconfig:
2008
2009 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2010
2011         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2012         https://bugs.webkit.org/show_bug.cgi?id=177912
2013
2014         Reviewed by Saam Barati.
2015
2016         * Carbon/CarbonUtils.m:
2017         * Carbon/CarbonWindowAdapter.mm:
2018         * Carbon/HIWebView.mm:
2019         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2020         * Misc/WebNSFileManagerExtras.mm:
2021         * Misc/WebNSPasteboardExtras.mm:
2022         * Misc/WebNSURLExtras.mm:
2023         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2024         * Plugins/Hosted/NetscapePluginHostManager.mm:
2025         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2026         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2027         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2028         * Plugins/Hosted/WebTextInputWindowController.m:
2029         * Plugins/WebBaseNetscapePluginView.mm:
2030         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2031         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2032         * Plugins/WebNetscapePluginStream.mm:
2033         * Plugins/WebNetscapePluginView.mm:
2034         * Plugins/WebPluginDatabase.mm:
2035         * WebCoreSupport/PopupMenuMac.mm:
2036         * WebCoreSupport/WebChromeClient.mm:
2037         * WebCoreSupport/WebFrameLoaderClient.mm:
2038         * WebCoreSupport/WebInspectorClient.mm:
2039         * WebCoreSupport/WebPlatformStrategies.mm:
2040         * WebCoreSupport/WebSystemInterface.mm:
2041         * WebView/WebDynamicScrollBarsView.mm:
2042         * WebView/WebFrame.mm:
2043         * WebView/WebFrameView.mm:
2044         * WebView/WebFullScreenController.mm:
2045         * WebView/WebHTMLView.mm:
2046         * WebView/WebPreferences.mm:
2047         * WebView/WebView.mm:
2048
2049 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2050
2051         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2052         rdar://problem/34705779
2053
2054         Addressing review comments that I somehow landed without.
2055
2056         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2057
2058 2017-09-29  Chris Dumez  <cdumez@apple.com>
2059
2060         Split some logic out of VisitedLinkStore and make it reusable
2061         https://bugs.webkit.org/show_bug.cgi?id=177575
2062
2063         Reviewed by Alex Christensen.
2064
2065         * WebCoreSupport/WebVisitedLinkStore.h:
2066         * WebCoreSupport/WebVisitedLinkStore.mm:
2067         (WebVisitedLinkStore::addVisitedLink):
2068         (WebVisitedLinkStore::removeVisitedLink):
2069         (WebVisitedLinkStore::isLinkVisited):
2070         (WebVisitedLinkStore::addVisitedLinkHash):
2071
2072 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2073
2074         Build fix for High Sierra 32 bit Mac
2075         https://bugs.webkit.org/show_bug.cgi?id=177551
2076         <rdar://problem/34690283>
2077
2078         Reviewed by Alexey Proskuryakov.
2079
2080         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2081         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2082         also made.
2083
2084         * Carbon/CarbonWindowAdapter.mm:
2085         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2086         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2087         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2088         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2089         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2090         (-[CarbonWindowAdapter dealloc]):
2091         (-[CarbonWindowAdapter windowRef]):
2092         (-[CarbonWindowAdapter _hasWindowRef]):
2093         (-[CarbonWindowAdapter _managesWindowRef]):
2094         (-[CarbonWindowAdapter _removeWindowRef]):
2095         (-[CarbonWindowAdapter _carbonWindowClass]):
2096         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2097         (-[CarbonWindowAdapter sendSuperEvent:]):
2098         (-[CarbonWindowAdapter relinquishFocus]):
2099         (-[CarbonWindowAdapter _cancelKey:]):
2100         (-[CarbonWindowAdapter _commonAwake]):
2101         (-[CarbonWindowAdapter _destroyRealWindow:]):
2102         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2103         (-[CarbonWindowAdapter _termWindowIfOwner]):
2104         (-[CarbonWindowAdapter _windowMovedToRect:]):
2105         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2106         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2107         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2108         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2109         (-[CarbonWindowAdapter canBecomeMainWindow]):
2110         (-[CarbonWindowAdapter encodeWithCoder:]):
2111         (-[CarbonWindowAdapter initWithCoder:]):
2112         (-[CarbonWindowAdapter setContentView:]):
2113         (-[CarbonWindowAdapter worksWhenModal]):
2114         (-[CarbonWindowAdapter _setModalWindowLevel]):
2115         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2116         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2117         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2118         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2119         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2120         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2121         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2122         (NSCarbonWindowHandleEvent):
2123         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2124         (-[CarbonWindowAdapter _growBoxRect]):
2125         * Carbon/HIWebView.mm:
2126         (HIWebViewGetWebView):
2127         (HIWebViewConstructor):
2128         (HIWebViewDestructor):
2129         (HIWebViewRegisterClass):
2130         (GetBehaviors):
2131         (Draw):
2132         (HitTest):
2133         (GetRegion):
2134         (GetWindowRef):
2135         (CreateNSEventAdoptingCGEvent):
2136         (CopyEventCGEvent):
2137         (CreateNSEventWithCarbonClickEvent):
2138         (Click):
2139         (CreateNSEventWithCarbonEvent):
2140         (MouseUp):
2141         (CreateNSEventWithCarbonMouseMoveEvent):
2142         (MouseMoved):
2143         (MouseDragged):
2144         (MouseWheelMoved):
2145         (ContextMenuClick):
2146         (GetKind):
2147         (BoundsChanged):
2148         (OwningWindowChanged):
2149         (WindowHandler):
2150         (SyncFrame):
2151         (SetFocusPart):
2152         (AdvanceFocus):
2153         (RelinquishFocus):
2154         (ActiveStateChanged):
2155         (ProcessCommand):
2156         (UpdateCommandStatus):
2157         (_NSSelectorForHICommand):
2158         (HIWebViewEventHandler):
2159         (StartUpdateObserver):
2160         (StopUpdateObserver):
2161         (UpdateObserver):
2162
2163 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2164
2165         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2166         https://bugs.webkit.org/show_bug.cgi?id=172526
2167         <rdar://problem/32396081>
2168
2169         Reviewed by Ryosuke Niwa.
2170
2171         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2172
2173         * WebCoreSupport/WebPlatformStrategies.h:
2174         * WebCoreSupport/WebPlatformStrategies.mm:
2175         (WebPlatformStrategies::webExposedTypes):
2176         (WebPlatformStrategies::writeCustomData):
2177
2178 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2179
2180         Unreviewed, rolling out r222567.
2181
2182         This broke and internal build.
2183
2184         Reverted changeset:
2185
2186         "Build fix for High Sierra 32 bit Mac"
2187         https://bugs.webkit.org/show_bug.cgi?id=177551
2188         http://trac.webkit.org/changeset/222567
2189
2190 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2191
2192         Build fix for High Sierra 32 bit Mac
2193         https://bugs.webkit.org/show_bug.cgi?id=177551
2194         <rdar://problem/34690283>
2195
2196         Reviewed by Alexey Proskuryakov.
2197
2198         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2199         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2200         also made.
2201
2202         * Carbon/CarbonWindowAdapter.mm:
2203         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2204         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2205         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2206         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2207         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2208         (-[CarbonWindowAdapter dealloc]):
2209         (-[CarbonWindowAdapter windowRef]):
2210         (-[CarbonWindowAdapter _hasWindowRef]):
2211         (-[CarbonWindowAdapter _managesWindowRef]):
2212         (-[CarbonWindowAdapter _removeWindowRef]):
2213         (-[CarbonWindowAdapter _carbonWindowClass]):
2214         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2215         (-[CarbonWindowAdapter sendSuperEvent:]):
2216         (-[CarbonWindowAdapter relinquishFocus]):
2217         (-[CarbonWindowAdapter _cancelKey:]):
2218         (-[CarbonWindowAdapter _commonAwake]):
2219         (-[CarbonWindowAdapter _destroyRealWindow:]):
2220         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2221         (-[CarbonWindowAdapter _termWindowIfOwner]):
2222         (-[CarbonWindowAdapter _windowMovedToRect:]):
2223         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2224         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2225         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2226         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2227         (-[CarbonWindowAdapter canBecomeMainWindow]):
2228         (-[CarbonWindowAdapter encodeWithCoder:]):
2229         (-[CarbonWindowAdapter initWithCoder:]):
2230         (-[CarbonWindowAdapter setContentView:]):
2231         (-[CarbonWindowAdapter worksWhenModal]):
2232         (-[CarbonWindowAdapter _setModalWindowLevel]):
2233         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2234         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2235         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2236         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2237         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2238         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2239         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2240         (NSCarbonWindowHandleEvent):
2241         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2242         (-[CarbonWindowAdapter _growBoxRect]):
2243         * Carbon/HIWebView.mm:
2244         (HIWebViewGetWebView):
2245         (HIWebViewConstructor):
2246         (HIWebViewDestructor):
2247         (HIWebViewRegisterClass):
2248         (GetBehaviors):
2249         (Draw):
2250         (HitTest):
2251         (GetRegion):
2252         (GetWindowRef):
2253         (CreateNSEventAdoptingCGEvent):
2254         (CopyEventCGEvent):
2255         (CreateNSEventWithCarbonClickEvent):
2256         (Click):
2257         (CreateNSEventWithCarbonEvent):
2258         (MouseUp):
2259         (CreateNSEventWithCarbonMouseMoveEvent):
2260         (MouseMoved):
2261         (MouseDragged):
2262         (MouseWheelMoved):
2263         (ContextMenuClick):
2264         (GetKind):
2265         (BoundsChanged):
2266         (OwningWindowChanged):
2267         (WindowHandler):
2268         (SyncFrame):
2269         (SetFocusPart):
2270         (AdvanceFocus):
2271         (RelinquishFocus):
2272         (ActiveStateChanged):
2273         (ProcessCommand):
2274         (UpdateCommandStatus):
2275         (_NSSelectorForHICommand):
2276         (HIWebViewEventHandler):
2277         (StartUpdateObserver):
2278         (StopUpdateObserver):
2279         (UpdateObserver):
2280
2281 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2282
2283         Make PolicyAction an encodable enum class
2284         https://bugs.webkit.org/show_bug.cgi?id=177480
2285
2286         Reviewed by Antti Koivisto.
2287
2288         * Plugins/WebPluginContainerCheck.mm:
2289         (-[WebPluginContainerCheck _continueWithPolicy:]):
2290         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2291         * WebCoreSupport/WebFrameLoaderClient.mm:
2292         (-[WebFramePolicyListener invalidate]):
2293         (-[WebFramePolicyListener ignore]):
2294         (-[WebFramePolicyListener download]):
2295         (-[WebFramePolicyListener use]):
2296         (-[WebFramePolicyListener continue]):
2297         * WebView/WebPolicyDelegate.mm:
2298         (-[WebPolicyDecisionListener use]):
2299         (-[WebPolicyDecisionListener ignore]):
2300         (-[WebPolicyDecisionListener download]):
2301
2302 2017-09-25  Frederik Riedel  <riedel@apple.com>
2303
2304         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2305         https://bugs.webkit.org/show_bug.cgi?id=174394
2306         <rdar://problem/33183504>
2307
2308         Reviewed by Ryosuke Niwa.
2309
2310         * DOM/DOMHTMLInputElement.h:
2311         * DOM/DOMHTMLInputElement.mm:
2312         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2313         Determines if this HTMLInputElement is part of a login screen.
2314         (-[DOMHTMLInputElement representingPageUrl]):
2315         Returns the webpage's URL that is currently displayed in the Web View.
2316         (-[DOMHTMLInputElement insertTextSuggestion:]):
2317         Inserts login credentials into the Web View.
2318
2319 2017-09-25  Sam Weinig  <sam@webkit.org>
2320
2321         Remove unused EditorClient functions
2322         https://bugs.webkit.org/show_bug.cgi?id=177463
2323
2324         Reviewed by Alex Christensen.
2325
2326         Remove unused EditorClient functions.
2327
2328         * WebCoreSupport/WebEditorClient.h:
2329         * WebCoreSupport/WebEditorClient.mm:
2330         (WebEditorClient::canonicalizeURL): Deleted.
2331         (WebEditorClient::canonicalizeURLString): Deleted.
2332         (WebEditorClient::writeDataToPasteboard): Deleted.
2333         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2334         (WebEditorClient::readDataFromPasteboard): Deleted.
2335         (WebEditorClient::pasteboardChangeCount): Deleted.
2336
2337 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2338
2339         Stop using PolicyCallback
2340         https://bugs.webkit.org/show_bug.cgi?id=176088
2341
2342         Reviewed by Andy Estes.
2343
2344         * WebCoreSupport/WebFrameLoaderClient.mm:
2345         (-[WebFramePolicyListener invalidate]):
2346         (-[WebFramePolicyListener receivedPolicyDecision:]):
2347
2348 2017-09-25  Sam Weinig  <sam@webkit.org>
2349
2350         Remove unnecessary userVisibleString EditorClient function
2351         https://bugs.webkit.org/show_bug.cgi?id=177456
2352
2353         Reviewed by Dan Bernstein.
2354
2355         * WebCoreSupport/WebEditorClient.h:
2356         * WebCoreSupport/WebEditorClient.mm:
2357         (WebEditorClient::userVisibleString): Deleted.
2358
2359             Remove userVisibleString client function.
2360
2361 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2362
2363         Separate form submission from PolicyChecker infrastructure
2364         https://bugs.webkit.org/show_bug.cgi?id=177396
2365
2366         Reviewed by Geoffrey Garen.
2367
2368         * WebCoreSupport/WebFrameLoaderClient.h:
2369         * WebCoreSupport/WebFrameLoaderClient.mm:
2370         (WebFrameLoaderClient::dispatchWillSubmitForm):
2371
2372 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2373
2374         WeakPtrFactory should populate m_ref lazily.
2375         https://bugs.webkit.org/show_bug.cgi?id=177375
2376
2377         Reviewed by Geoffrey Garen.
2378
2379         * WebCoreSupport/WebEditorClient.mm:
2380         (WebEditorClient::WebEditorClient):
2381         (WebEditorClient::requestCandidatesForSelection):
2382
2383 2017-09-22  Chris Dumez  <cdumez@apple.com>
2384
2385         Use high resolution timestamp for event time
2386         https://bugs.webkit.org/show_bug.cgi?id=154246
2387         <rdar://problem/34333304>
2388
2389         Reviewed by Ryosuke Niwa.
2390
2391         Use WallTime / MonotonicTime instead of double type for clarity.
2392
2393         * DOM/DOMEvent.mm:
2394         (-[DOMEvent timeStamp]):
2395         * WebView/WebFrame.mm:
2396         (-[WebFrame _dragSourceEndedAt:operation:]):
2397         * WebView/WebPDFView.mm:
2398         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2399
2400 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2401
2402         Enable dataTransfer.items on macOS and iOS
2403         https://bugs.webkit.org/show_bug.cgi?id=177335
2404
2405         Reviewed by Sam Weinig.
2406
2407         * WebView/WebPreferences.mm:
2408         (+[WebPreferences initialize]):
2409
2410 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2411
2412         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2413         https://bugs.webkit.org/show_bug.cgi?id=177101
2414         <rdar://problem/34500648>
2415
2416         Reviewed by Brian Burg.
2417
2418         * WebInspector/WebNodeHighlight.mm:
2419         Ensure we close the window that we have just removed.
2420
2421 2017-09-20  Antti Koivisto  <antti@apple.com>
2422
2423         Remove DOM and styling support for CSS Regions
2424         https://bugs.webkit.org/show_bug.cgi?id=177221
2425
2426         Reviewed by Andreas Kling.
2427
2428         * Configurations/FeatureDefines.xcconfig:
2429         * DOM/DOMCSS.mm:
2430         (kitClass):
2431         * DOM/DOMElement.mm:
2432         (-[DOMElement webkitRegionOverset]): Deleted.
2433
2434 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2435
2436         Layering violation in Editor::createFragment
2437         https://bugs.webkit.org/show_bug.cgi?id=176123
2438
2439         Reviewed by Darin Adler.
2440
2441         * Misc/WebNSURLExtras.h:
2442         * Misc/WebNSURLExtras.mm:
2443         * WebView/WebFrame.mm:
2444         * WebView/WebHTMLView.mm:
2445         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2446
2447         * WebCoreSupport/WebEditorClient.mm:
2448         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2449         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2450         way to avoid exporting the symbol just on newer OSes.
2451
2452 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2453
2454         On iOS, getData can't get text set by setData during copy event
2455         https://bugs.webkit.org/show_bug.cgi?id=176980
2456         <rdar://problem/34453915>
2457
2458         Reviewed by Darin Adler.
2459
2460         * WebCoreSupport/WebPlatformStrategies.h:
2461         * WebCoreSupport/WebPlatformStrategies.mm:
2462         (WebPlatformStrategies::copy): Deleted.
2463
2464 2017-09-18  Andy Estes  <aestes@apple.com>
2465
2466         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2467         https://bugs.webkit.org/show_bug.cgi?id=177029
2468
2469         Reviewed by Alex Christensen.
2470
2471         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2472         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2473         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2474         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2475         * WebCoreSupport/PopupMenuMac.mm:
2476         (PopupMenuMac::show):
2477         * WebCoreSupport/WebSystemInterface.mm:
2478         (InitWebCoreSystemInterface):
2479         * WebView/WebHTMLView.mm:
2480         (-[WebHTMLView setDataSource:]):
2481         (-[WebHTMLView attachRootLayer:]):
2482         * WebView/WebView.mm:
2483         (-[WebView _needsAdobeFrameReloadingQuirk]):
2484         (-[WebView _needsLinkElementTextCSSQuirk]):
2485         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2486         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2487         (-[WebView _preferencesChanged:]):
2488
2489 2017-09-15  Andy Estes  <aestes@apple.com>
2490
2491         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2492         https://bugs.webkit.org/show_bug.cgi?id=176953
2493
2494         Reviewed by Eric Carlson.
2495
2496         * WebCoreSupport/WebSystemInterface.mm:
2497         (InitWebCoreSystemInterface):
2498
2499 2017-09-14  Andy Estes  <aestes@apple.com>
2500
2501         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2502         https://bugs.webkit.org/show_bug.cgi?id=176931
2503
2504         Reviewed by Joseph Pecoraro.
2505
2506         * WebCoreSupport/WebSystemInterface.mm:
2507         (InitWebCoreSystemInterface):
2508
2509 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2510
2511         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2512         https://bugs.webkit.org/show_bug.cgi?id=176867
2513
2514         Reviewed by Sam Weinig.
2515
2516         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2517         (WebKit::NetscapePluginInstanceProxy::enumerate):
2518
2519 2017-09-13  Andy Estes  <aestes@apple.com>
2520
2521         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
2522         https://bugs.webkit.org/show_bug.cgi?id=176729
2523
2524         Reviewed by Alex Christensen.
2525
2526         * WebCoreSupport/WebSystemInterface.mm:
2527         (InitWebCoreSystemInterface):
2528         * WebView/WebView.mm:
2529         (+[WebView _setCacheModel:]):
2530
2531 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2532
2533         Refactor WebContentReader out of EditorMac and EditorIOS
2534         https://bugs.webkit.org/show_bug.cgi?id=176770
2535
2536         Reviewed by Sam Weinig.
2537
2538         * WebCoreSupport/WebEditorClient.mm:
2539
2540 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2541
2542         Dragging & dropping a file creates an attachment element even when it's disabled
2543         https://bugs.webkit.org/show_bug.cgi?id=176769
2544
2545         Reviewed by Tim Horton.
2546
2547         * WebView/WebView.mm:
2548         (-[WebView _preferencesChanged:]):
2549
2550 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2551
2552         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
2553         https://bugs.webkit.org/show_bug.cgi?id=176721
2554         <rdar://problem/34373660>
2555
2556         Reviewed by Tim Horton.
2557
2558         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
2559         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
2560
2561         * WebView/WebView.mm:
2562         (-[WebView _startDrag:]):
2563         (-[WebView _draggedElementBounds]):
2564         (-[WebView _endedDataInteraction:global:]):
2565         * WebView/WebViewData.h:
2566
2567 2017-09-11  Andy Estes  <aestes@apple.com>
2568
2569         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2570         https://bugs.webkit.org/show_bug.cgi?id=176472
2571
2572         Reviewed by Eric Carlson.
2573
2574         * WebCoreSupport/WebSystemInterface.mm:
2575         (InitWebCoreSystemInterface):
2576
2577 2017-09-09  Mark Lam  <mark.lam@apple.com>
2578
2579         Avoid duplicate computations of ExecState::vm().
2580         https://bugs.webkit.org/show_bug.cgi?id=176647
2581
2582         Reviewed by Saam Barati.
2583
2584         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2585         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2586         (WebKit::NetscapePluginInstanceProxy::construct):
2587         (WebKit::NetscapePluginInstanceProxy::setProperty):
2588         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2589         (WebKit::NetscapePluginInstanceProxy::enumerate):
2590         * Plugins/Hosted/ProxyInstance.mm:
2591         (WebKit::ProxyRuntimeMethod::create):
2592
2593 2017-09-08  Commit Queue  <commit-queue@webkit.org>
2594
2595         Unreviewed, rolling out r221773.
2596         https://bugs.webkit.org/show_bug.cgi?id=176614
2597
2598         This caused build failures. (Requested by mlewis13 on
2599         #webkit).
2600
2601         Reverted changeset:
2602
2603         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
2604         https://bugs.webkit.org/show_bug.cgi?id=176472
2605         http://trac.webkit.org/changeset/221773
2606
2607 2017-09-07  Andy Estes  <aestes@apple.com>
2608
2609         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2610         https://bugs.webkit.org/show_bug.cgi?id=176472
2611
2612         Reviewed by Eric Carlson.
2613
2614         * WebCoreSupport/WebSystemInterface.mm:
2615         (InitWebCoreSystemInterface):
2616
2617 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
2618
2619         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
2620         https://bugs.webkit.org/show_bug.cgi?id=176561
2621
2622         Reviewed by Brent Fulgham.
2623
2624         * Misc/WebNSUserDefaultsExtras.mm:
2625
2626 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2627
2628         Modernize Geolocation code
2629         https://bugs.webkit.org/show_bug.cgi?id=176496
2630
2631         Reviewed by Andy Estes.
2632
2633         * WebCoreSupport/WebGeolocationClient.h:
2634         * WebCoreSupport/WebGeolocationClient.mm:
2635         (WebGeolocationClient::requestPermission):
2636         (-[WebGeolocationPolicyListener initWithGeolocation:]):
2637         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
2638         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
2639         * WebView/WebView.mm:
2640         (-[WebView _commonInitializationWithFrameName:groupName:]):
2641         (-[WebView _geolocationDidFailWithMessage:]):
2642
2643 2017-09-05  Tim Horton  <timothy_horton@apple.com>
2644
2645         Remove some unused bits of code and resources
2646         https://bugs.webkit.org/show_bug.cgi?id=176275
2647
2648         Reviewed by Dan Bernstein.
2649
2650         * Misc/WebNSFileManagerExtras.mm:
2651         Include FileSystem instead of FileSystemIOS.
2652
2653 2017-09-03  Darin Adler  <darin@apple.com>
2654
2655         [Cocoa] Tidy a few things in legacy WebHTMLView
2656         https://bugs.webkit.org/show_bug.cgi?id=176280
2657
2658         Reviewed by Dan Bernstein.
2659
2660         * WebCoreSupport/WebChromeClient.mm:
2661         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
2662         methods it calls on WebHTMLView were doing nothing on iOS.
2663
2664         * WebView/WebFrame.mm:
2665         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
2666         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
2667
2668         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
2669         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
2670         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
2671         order. Removed all sorts of unused things. Made more code and fields Mac-only where
2672         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
2673         Use RetainPtr instead of writing retain/release wherever possible.
2674         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
2675         initialization for it. Removed various unused methods and declarations of methods.
2676         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
2677         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
2678         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
2679         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
2680         and remove CFRetain no longer needed since we don't support garbage collection any more.
2681         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
2682         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
2683         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
2684         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
2685         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
2686         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2687         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
2688         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2689         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
2690         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
2691         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
2692         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
2693         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
2694         debug flag; we haven't used it for years and it's not clearly helpful.
2695         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
2696         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
2697         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
2698         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
2699         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
2700         two additional methods in the WebPrivate category and still be called by the two
2701         methods in the WebInternal category that were already using it.
2702         (-[WebHTMLView didAddSubview:]): Deleted.
2703         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
2704         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
2705         place this was called, the close method.
2706         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
2707         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2708         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
2709         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
2710         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
2711         Added helper method to make the one below simpler.
2712         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2713         Compared pasteboard type strings using isEqualToString: rather than using == since
2714         we want to actually compare the string contents. Also updated to use modern for loop,
2715         renamed a local variable from "s" to "localSubresources", and factored out the handling
2716         of three image types to use the helper method above.
2717         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
2718         _web_makePluginSubviewsPerformSelector:withObject: method.
2719         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
2720         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
2721         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
2722         not call the -[NSView subviews] method to make this identical on both platforms and used
2723         a modern for loop.
2724         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
2725         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
2726         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
2727         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
2728         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2729         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
2730         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
2731         of it is Mac-only.
2732         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
2733         method did was call itself on the main thread, and do nothing if called on main thread.
2734         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
2735         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
2736         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
2737         half of this method.
2738         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
2739         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2740         Simplified using a modern for loop and RetainPtr.
2741         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
2742         (-[WebHTMLView keyDown:]): Ditto.
2743         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
2744         (-[WebHTMLView performKeyEquivalent:]): Ditto.
2745         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
2746         (-[WebHTMLView complete:]): Ditto.
2747         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
2748         now macOS-only.
2749         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
2750         iOS since that is now macOS-only.
2751         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
2752         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
2753         a private one because it is not used or needed outside WebKit. Also made it macOS-only
2754         and reorganized to use early return.
2755         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
2756         on iOS, but kept there so we don't have to do #if at every call site.
2757         (-[WebHTMLView _pluginController]): Moved into internal category.
2758         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
2759         there only for GC, using C++ initialization, removing obsolete comment.
2760         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
2761         peculiar iOS-only comment.
2762         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
2763
2764         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
2765         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
2766         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
2767         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
2768         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
2769
2770         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
2771         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
2772         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
2773         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
2774         them at this time.
2775
2776 2017-09-03  Sam Weinig  <sam@webkit.org>
2777
2778         Remove CanvasProxy
2779         https://bugs.webkit.org/show_bug.cgi?id=176288
2780
2781         Reviewed by Yusuke Suzuki.
2782
2783         CanvasProxy does not appear to be in any current HTML spec
2784         and was disabled and unimplemented in our tree. Time to 
2785         get rid of it.
2786
2787         * Configurations/FeatureDefines.xcconfig:
2788
2789 2017-09-02  Andy Estes  <aestes@apple.com>
2790
2791         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
2792         https://bugs.webkit.org/show_bug.cgi?id=176270
2793
2794         Reviewed by Tim Horton.
2795
2796         * Plugins/Hosted/NetscapePluginHostManager.mm:
2797         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2798         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2799         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2800         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
2801         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
2802         (WebKit::SoftwareCARenderer::context const):
2803         (WebKit::SoftwareCARenderer::renderContext const):
2804         (WebKit::SoftwareCARenderer::render):
2805         (-[WebHostedNetscapePluginView createPlugin]):
2806         (-[WebHostedNetscapePluginView createPluginLayer]):
2807         (-[WebHostedNetscapePluginView destroyPlugin]):
2808         (-[WebHostedNetscapePluginView drawRect:]):
2809         * WebCoreSupport/WebSystemInterface.mm:
2810         (InitWebCoreSystemInterface):
2811
2812 2017-09-01  Andy Estes  <aestes@apple.com>
2813
2814         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
2815         https://bugs.webkit.org/show_bug.cgi?id=176200
2816
2817         Reviewed by Tim Horton.
2818
2819         * Carbon/HIWebView.mm:
2820         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
2821         (overrideCGContext):
2822         (restoreCGContext):
2823         (Draw):
2824         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2825         (+[WebHostedNetscapePluginView initialize]):
2826         * Plugins/WebBaseNetscapePluginView.h:
2827         * Plugins/WebBaseNetscapePluginView.mm:
2828         (WebKit::sendUserChangeNotifications):
2829         * Plugins/WebNetscapePluginView.mm:
2830         (+[WebNetscapePluginView initialize]):
2831         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2832         * WebCoreSupport/WebSystemInterface.mm:
2833         (InitWebCoreSystemInterface):
2834         * WebView/WebFrame.mm:
2835         (-[WebFrame _paintBehaviorForDestinationContext:]):
2836         * WebView/WebFullScreenController.mm:
2837         (setClipRectForWindow):
2838         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2839         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2840         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2841         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2842
2843 2017-08-31  Andy Estes  <aestes@apple.com>
2844
2845         [Mac] Upstream AppKit-related WebKitSystemInterface functions
2846         https://bugs.webkit.org/show_bug.cgi?id=176175
2847
2848         Reviewed by Brady Eidson.
2849
2850         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2851         (WebKit::NetscapePluginInstanceProxy::keyEvent):
2852         * Plugins/Hosted/WebTextInputWindowController.m:
2853         (-[WebTextInputPanel init]):
2854         * WebCoreSupport/WebSystemInterface.mm:
2855         (InitWebCoreSystemInterface):
2856         * WebView/WebDynamicScrollBarsView.mm:
2857         (-[WebDynamicScrollBarsView scrollWheel:]):
2858         * WebView/WebHTMLView.mm:
2859         (-[WebHTMLView _removeWindowObservers]):
2860         (-[WebHTMLView addWindowObservers]):
2861         * WebView/WebView.mm:
2862         (-[WebView addWindowObserversForWindow:]):
2863         (-[WebView removeWindowObservers]):
2864         (-[WebView viewWillMoveToWindow:]):
2865
2866 2017-08-31  Alex Christensen  <achristensen@webkit.org>
2867
2868         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
2869         https://bugs.webkit.org/show_bug.cgi?id=175779
2870         <rdar://problem/22367975>
2871
2872         Reviewed by Tim Horton.
2873
2874         * WebCoreSupport/WebFrameLoaderClient.h:
2875         * WebCoreSupport/WebFrameLoaderClient.mm:
2876         (WebFrameLoaderClient::webGLPolicyForURL const):
2877         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
2878
2879 2017-08-30  Andy Estes  <aestes@apple.com>
2880
2881         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
2882         https://bugs.webkit.org/show_bug.cgi?id=176093
2883
2884         Reviewed by Eric Carlson.
2885
2886         * WebCoreSupport/WebSystemInterface.mm:
2887         (InitWebCoreSystemInterface):
2888
2889 2017-08-30  Andy Estes  <aestes@apple.com>
2890
2891         [Mac] Upstream Carbon-related WebKitSystemInterface functions
2892         https://bugs.webkit.org/show_bug.cgi?id=176087
2893
2894         Reviewed by Alex Christensen.
2895
2896         * Carbon/CarbonUtils.m:
2897         (getNSAutoreleasePoolCount):
2898         (WebInitForCarbon):
2899         (PoolCleaner):
2900         * Carbon/CarbonWindowAdapter.mm:
2901         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2902         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2903         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2904         (-[CarbonWindowAdapter _windowMovedToRect:]):
2905         * Carbon/HIViewAdapter.m:
2906         * Carbon/HIWebView.mm:
2907         (Draw):
2908         (CreateNSEventAdoptingCGEvent):
2909         (CopyEventCGEvent):
2910         (CreateNSEventWithCarbonClickEvent):
2911         (Click):
2912         (CreateNSEventWithCarbonEvent):
2913         (MouseUp):
2914         (CreateNSEventWithCarbonMouseMoveEvent):
2915         (MouseMoved):
2916         (MouseDragged):
2917         (MouseWheelMoved):
2918         (WindowHandler):
2919         (HIWebViewEventHandler):
2920         * Misc/QuickDrawCompatibility.h: Removed.
2921         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2922         (getCarbonEvent):
2923         (WebNetscapePluginEventHandlerCarbon::keyDown):
2924         (WebNetscapePluginEventHandlerCarbon::keyUp):
2925         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2926         (WebNetscapePluginEventHandlerCocoa::keyDown):
2927         * Plugins/WebNetscapePluginView.mm:
2928         (-[WebNetscapePluginView tellQuickTimeToChill]):
2929
2930 2017-08-29  Andy Estes  <aestes@apple.com>
2931
2932         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
2933         https://bugs.webkit.org/show_bug.cgi?id=176046
2934
2935         Reviewed by Alex Christensen.
2936
2937         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
2938         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
2939
2940         * Misc/WebNSFileManagerExtras.mm:
2941         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
2942         (setMetaData): Deleted.
2943         * WebCoreSupport/WebSystemInterface.mm:
2944         (InitWebCoreSystemInterface):
2945
2946 2017-08-28  Andy Estes  <aestes@apple.com>
2947
2948         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
2949         https://bugs.webkit.org/show_bug.cgi?id=176039
2950
2951         Reviewed by Alex Christensen.
2952
2953         * WebCoreSupport/WebSystemInterface.mm:
2954         (InitWebCoreSystemInterface):
2955         * WebView/WebPreferences.mm:
2956         (+[WebPreferences _systemCFStringEncoding]):
2957
2958 2017-08-28  Andy Estes  <aestes@apple.com>
2959
2960         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
2961         https://bugs.webkit.org/show_bug.cgi?id=176032
2962
2963         Reviewed by Alex Christensen.
2964
2965         * WebCoreSupport/WebSystemInterface.mm:
2966         (InitWebCoreSystemInterface):
2967         * WebView/WebView.mm:
2968         (-[WebView _cachedResponseForURL:]):
2969
2970 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2971
2972         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
2973         https://bugs.webkit.org/show_bug.cgi?id=175992
2974         <rdar://problem/34086613>
2975
2976         Reviewed by Daniel Bates.
2977
2978         * WebCoreSupport/WebPlatformStrategies.h:
2979         * WebCoreSupport/WebPlatformStrategies.mm:
2980         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
2981         cookies should be included, and return a pair containing the resulting cookie string and a boolean
2982         indicating if secure cookies were accessed.
2983
2984 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2985
2986         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
2987         https://bugs.webkit.org/show_bug.cgi?id=170955
2988         <rdar://problem/31697653>
2989
2990         Reviewed by Ryosuke Niwa.
2991
2992         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
2993         text is being replaced.
2994
2995         * WebView/WebHTMLView.mm:
2996         (-[WebHTMLView insertText:]):
2997
2998 2017-08-24  Chris Dumez  <cdumez@apple.com>
2999
3000         [Directory Upload] Add basic support for input.webkitdirectory
3001         https://bugs.webkit.org/show_bug.cgi?id=175950
3002         <rdar://problem/33951915>
3003
3004         Reviewed by Geoffrey Garen.
3005
3006         Add private API to toggle Directory Upload support on Mac WebKit1.
3007
3008         * WebView/WebPreferenceKeysPrivate.h:
3009         * WebView/WebPreferences.mm:
3010         (+[WebPreferences initialize]):
3011         (-[WebPreferences setDirectoryUploadEnabled:]):
3012         (-[WebPreferences directoryUploadEnabled]):
3013         * WebView/WebPreferencesPrivate.h:
3014         * WebView/WebView.mm:
3015         (-[WebView _preferencesChanged:]):
3016
3017 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3018
3019         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3020         https://bugs.webkit.org/show_bug.cgi?id=175370
3021         <rdar://problem/33799806>
3022
3023         Reviewed by Ryosuke Niwa.
3024
3025         Adjust WebEditorClient for interface changes.
3026
3027         * WebCoreSupport/WebEditorClient.h:
3028
3029 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3030
3031         Remove ChromeClient::scrollbarsModeDidChange
3032         https://bugs.webkit.org/show_bug.cgi?id=175805
3033
3034         Reviewed by Daniel Bates.
3035
3036         * WebCoreSupport/WebChromeClient.h:
3037
3038 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3039
3040         Remove ChromeClient::hasOpenedPopup
3041         https://bugs.webkit.org/show_bug.cgi?id=175804
3042
3043         Reviewed by Sam Weinig.
3044
3045         * WebCoreSupport/WebChromeClient.h:
3046         * WebCoreSupport/WebChromeClient.mm:
3047         (WebChromeClient::hasOpenedPopup const): Deleted.
3048
3049 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3050
3051         Disable access to secure cookies if an HTTPS site loads mixed content
3052         https://bugs.webkit.org/show_bug.cgi?id=157053
3053         <rdar://problem/11290808>
3054
3055         Reviewed by Dan Bates.
3056
3057         * WebCoreSupport/WebPlatformStrategies.h:
3058         * WebCoreSupport/WebPlatformStrategies.mm:
3059         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3060         indicating whether secure cookies should be included in the response.
3061
3062 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3063
3064         [PAL] Move spi/mac directory into PAL
3065         https://bugs.webkit.org/show_bug.cgi?id=175649
3066
3067         Reviewed by Myles C. Maxfield.
3068
3069         * Misc/WebSharingServicePickerController.h:
3070         * WebCoreSupport/WebContextMenuClient.mm:
3071         * WebCoreSupport/WebEditorClient.mm:
3072         * WebCoreSupport/WebSelectionServiceController.mm:
3073         * WebView/WebHTMLView.mm:
3074         * WebView/WebImmediateActionController.h:
3075         * WebView/WebImmediateActionController.mm:
3076         * WebView/WebView.mm:
3077
3078 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3079
3080         [PAL] Relocate SessionID to root
3081         https://bugs.webkit.org/show_bug.cgi?id=175684
3082
3083         Reviewed by Alex Christensen.
3084
3085         * WebCoreSupport/WebFrameNetworkingContext.mm:
3086
3087 2017-08-17  Andreas Kling  <akling@apple.com>
3088
3089         Disable CSS regions at compile time
3090         https://bugs.webkit.org/show_bug.cgi?id=175630
3091
3092         Reviewed by Antti Koivisto.
3093
3094         * Configurations/FeatureDefines.xcconfig:
3095
3096 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3097
3098         [PAL] Move SessionID into PAL
3099         https://bugs.webkit.org/show_bug.cgi?id=174192
3100
3101         Reviewed by Antti Koivisto.
3102
3103         * Misc/WebCache.mm:
3104         (+[WebCache imageForURL:]):
3105         * WebCoreSupport/WebFrameLoaderClient.h:
3106         * WebCoreSupport/WebFrameLoaderClient.mm:
3107         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3108         * WebCoreSupport/WebFrameNetworkingContext.mm:
3109         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3110         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3111         (WebFrameNetworkingContext::storageSession const):
3112         * WebCoreSupport/WebPlatformStrategies.h:
3113         * WebCoreSupport/WebPlatformStrategies.mm:
3114         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3115         * WebKitPrefix.h:
3116
3117 2017-08-16  Andy Estes  <aestes@apple.com>
3118
3119         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3120         https://bugs.webkit.org/show_bug.cgi?id=175648
3121
3122         Reviewed by Tim Horton.
3123
3124         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3125         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3126         (WebPaymentCoordinatorClient::showPaymentUI):
3127
3128 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3129
3130         [PAL] Move spi/ios and spi/win directories into PAL
3131         https://bugs.webkit.org/show_bug.cgi?id=175171
3132
3133         Reviewed by Antti Koivisto.
3134
3135         * WebCoreSupport/WebFrameLoaderClient.mm:
3136         * WebView/WebView.mm:
3137
3138 2017-08-16  Andy Estes  <aestes@apple.com>
3139
3140         [Payment Request] Add an ENABLE flag and an experimental feature preference
3141         https://bugs.webkit.org/show_bug.cgi?id=175622
3142
3143         Reviewed by Tim Horton.
3144
3145         * Configurations/FeatureDefines.xcconfig:
3146
3147 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3148
3149         [PAL] Move Sleep classes into PAL
3150         https://bugs.webkit.org/show_bug.cgi?id=175456
3151
3152         Reviewed by Ryosuke Niwa.
3153
3154         * WebView/WebFullScreenController.h:
3155
3156 2017-08-15  Youenn Fablet  <youenn@apple.com>
3157
3158         [Cache API] Adding generic support for CacheStorage and Cache methods
3159         https://bugs.webkit.org/show_bug.cgi?id=175455
3160
3161         Reviewed by Chris Dumez.
3162
3163         * WebView/WebView.mm:
3164         (-[WebView _commonInitializationWithFrameName:groupName:]):
3165
3166 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3167
3168         Remove Proximity Events and related code
3169         https://bugs.webkit.org/show_bug.cgi?id=175545
3170
3171         Reviewed by Daniel Bates.
3172
3173         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3174         and other related code.
3175
3176         * Configurations/FeatureDefines.xcconfig:
3177
3178 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3179
3180         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3181         https://bugs.webkit.org/show_bug.cgi?id=175504
3182
3183         Reviewed by Sam Weinig.
3184
3185         * Configurations/FeatureDefines.xcconfig:
3186         * DOM/DOMHTMLFormElement.mm:
3187         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3188         * WebCoreSupport/WebFrameLoaderClient.h:
3189
3190 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3191
3192         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3193         https://bugs.webkit.org/show_bug.cgi?id=175557
3194
3195         Reviewed by Jon Lee.
3196
3197         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3198
3199         * Configurations/FeatureDefines.xcconfig:
3200
3201 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3202
3203         Composition underline color is always black
3204         https://bugs.webkit.org/show_bug.cgi?id=174675
3205
3206         Reviewed by Ryosuke Niwa.
3207
3208         * WebView/WebHTMLView.mm:
3209         (extractUnderlines): If NSUnderlineColorAttributeName
3210         is not present use text color for composition underline.
3211         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3212         for composition underline in the plain text case.
3213
3214 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3215
3216         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3217         https://bugs.webkit.org/show_bug.cgi?id=175474
3218         <rdar://problem/33844628>
3219
3220         Reviewed by Wenson Hsieh.
3221
3222         Replaced the build flag by a runtime flag and disabled the feature by default.
3223
3224         * Configurations/FeatureDefines.xcconfig:
3225         * WebView/WebPreferenceKeysPrivate.h:
3226         * WebView/WebPreferences.mm:
3227         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3228         (-[WebPreferences dataTransferItemsEnabled]): Added.
3229         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3230         * WebView/WebPreferencesPrivate.h:
3231         * WebView/WebView.mm:
3232         (-[WebView _preferencesChanged:]):
3233
3234 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3235
3236         Remove ENABLE_GAMEPAD_DEPRECATED
3237         https://bugs.webkit.org/show_bug.cgi?id=175361
3238
3239         Reviewed by Carlos Garcia Campos.
3240
3241         * Configurations/FeatureDefines.xcconfig:
3242
3243 2017-08-09  Chris Dumez  <cdumez@apple.com>
3244
3245         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3246         https://bugs.webkit.org/show_bug.cgi?id=175401
3247
3248         Reviewed by Brady Eidson.
3249
3250         * WebView/WebPreferenceKeysPrivate.h:
3251         * WebView/WebPreferences.mm:
3252         (+[WebPreferences initialize]):
3253         (-[WebPreferences beaconAPIEnabled]): Deleted.
3254         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3255         * WebView/WebPreferencesPrivate.h:
3256         * WebView/WebView.mm:
3257         (-[WebView _preferencesChanged:]):
3258
3259 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3260
3261         [PAL] Move spi/cocoa and spi/cg directories into PAL
3262         https://bugs.webkit.org/show_bug.cgi?id=175175
3263
3264         Reviewed by Myles C. Maxfield.
3265
3266         * History/WebHistory.mm:
3267         * Misc/WebDownload.mm:
3268         * Misc/WebKitNSStringExtras.mm:
3269         * Plugins/Hosted/NetscapePluginHostManager.mm:
3270         * Plugins/WebPluginDatabase.mm:
3271         * WebCoreSupport/WebFrameLoaderClient.mm:
3272         * WebInspector/WebNodeHighlight.mm:
3273         * WebView/WebHTMLView.mm:
3274         * WebView/WebIndicateLayer.mm:
3275         * WebView/WebView.mm:
3276         * WebView/WebViewData.h:
3277
3278 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3279
3280         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
3281         https://bugs.webkit.org/show_bug.cgi?id=175392
3282         <rdar://problem/33783207>
3283
3284         Reviewed by Tim Horton and Megan Gardner.
3285
3286         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
3287
3288         * Configurations/FeatureDefines.xcconfig:
3289
3290 2017-08-09  Daniel Bates  <dabates@apple.com>
3291
3292         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3293         https://bugs.webkit.org/show_bug.cgi?id=175247
3294         <rdar://problem/33679804>
3295
3296         Reviewed by Brady Eidson.
3297
3298         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3299         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3300         clients that need to make use of this information at this time. If such a needs comes up
3301         then we can expose API/SPI similar to what we do for WebKit.
3302
3303         * WebCoreSupport/WebFrameLoaderClient.h:
3304         * WebCoreSupport/WebFrameLoaderClient.mm:
3305         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3306
3307 2017-08-08  Brady Eidson  <beidson@apple.com>
3308
3309         Don't enable default icon loading in WK1 for apps linked against old SDKs.
3310         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
3311
3312         Reviewed by Andy Estes.
3313
3314         * Misc/WebKitVersionChecks.h:
3315         * WebCoreSupport/WebFrameLoaderClient.mm:
3316         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
3317           the app is linked against new WebKit with the new behavior.
3318
3319 2017-08-07  Devin Rousso  <drousso@apple.com>
3320
3321         Web Inspector: Preview Canvas path when viewing a recording
3322         https://bugs.webkit.org/show_bug.cgi?id=174967
3323
3324         Reviewed by Brian Burg.
3325
3326         * WebView/WebPreferenceKeysPrivate.h:
3327         * WebView/WebPreferences.mm:
3328         (+[WebPreferences initialize]):
3329         (-[WebPreferences inspectorAdditionsEnabled]):
3330         (-[WebPreferences setInspectorAdditionsEnabled:]):
3331         * WebView/WebPreferencesPrivate.h:
3332         * WebView/WebView.mm:
3333         (-[WebView _preferencesChanged:]):
3334         Add plumbing for new InspectorAdditions runtime flag.
3335
3336 2017-08-07  Brian Burg  <bburg@apple.com>
3337
3338         Remove CANVAS_PATH compilation guard
3339         https://bugs.webkit.org/show_bug.cgi?id=175207
3340
3341         Reviewed by Sam Weinig.
3342
3343         * Configurations/FeatureDefines.xcconfig:
3344
3345 2017-08-04  Youenn Fablet  <youenn@apple.com>
3346
3347         [Cache API] Add Cache and CacheStorage IDL definitions
3348         https://bugs.webkit.org/show_bug.cgi?id=175201
3349
3350         Reviewed by Brady Eidson.
3351
3352         * WebView/WebPreferenceKeysPrivate.h:
3353         * WebView/WebPreferences.mm:
3354         (+[WebPreferences initialize]):
3355         (-[WebPreferences cacheAPIEnabled]):
3356         (-[WebPreferences setCacheAPIEnabled:]):
3357         * WebView/WebPreferencesPrivate.h:
3358         * WebView/WebView.mm:
3359         (-[WebView _preferencesChanged:]):
3360
3361 2017-08-04  Matt Lewis  <jlewis3@apple.com>
3362
3363         Unreviewed, rolling out r220271.
3364
3365         Rolling out due to Layout Test failing on iOS Simulator.
3366
3367         Reverted changeset:
3368
3369         "Remove STREAMS_API compilation guard"
3370         https://bugs.webkit.org/show_bug.cgi?id=175165
3371         http://trac.webkit.org/changeset/220271
3372
3373 2017-08-04  Youenn Fablet  <youenn@apple.com>
3374
3375         Remove STREAMS_API compilation guard
3376         https://bugs.webkit.org/show_bug.cgi?id=175165
3377
3378         Reviewed by Darin Adler.
3379
3380         * Configurations/FeatureDefines.xcconfig:
3381         * WebView/WebPreferences.mm:
3382         (+[WebPreferences initialize]):
3383         * WebView/WebView.mm:
3384         (-[WebView _preferencesChanged:]):
3385
3386 2017-08-03  Brian Burg  <bburg@apple.com>
3387
3388         Remove ENABLE(WEB_SOCKET) guards
3389         https://bugs.webkit.org/show_bug.cgi?id=167044
3390
3391         Reviewed by Joseph Pecoraro.
3392
3393         * Configurations/FeatureDefines.xcconfig:
3394         * WebView/WebPreferencesPrivate.h:
3395
3396 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
3397
3398         [PAL] Move spi/cf directory into PAL
3399         https://bugs.webkit.org/show_bug.cgi?id=175057
3400
3401         Reviewed by Antti Koivisto.
3402
3403         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3404         * Plugins/WebNetscapePluginStream.mm:
3405         * WebCoreSupport/WebFrameNetworkingContext.mm:
3406         * WebView/WebPreferences.mm:
3407         * WebView/WebView.mm:
3408
3409 2017-08-03  Youenn Fablet  <youenn@apple.com>
3410
3411         Remove FETCH_API compilation guard
3412         https://bugs.webkit.org/show_bug.cgi?id=175154
3413
3414         Reviewed by Chris Dumez.
3415
3416         * Configurations/FeatureDefines.xcconfig:
3417         * WebView/WebPreferences.mm:
3418         (+[WebPreferences initialize]):
3419         * WebView/WebView.mm:
3420         (-[WebView _preferencesChanged:]):
3421
3422 2017-08-03  Brady Eidson  <beidson@apple.com>
3423
3424         Add SW IDLs and stub out basic functionality.
3425         https://bugs.webkit.org/show_bug.cgi?id=175115
3426
3427         Reviewed by Chris Dumez.
3428
3429         * Configurations/FeatureDefines.xcconfig:
3430
3431 2017-08-02  Sam Weinig  <sam@webkit.org>
3432
3433         [WebIDL] Convert MutationCallback to be a normal generated callback
3434         https://bugs.webkit.org/show_bug.cgi?id=174140
3435
3436         Reviewed by Darin Adler.
3437
3438         * DOM/DOMDocument.mm:
3439         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
3440         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3441         Pass, now necessary, Document to NativeNodeFilter constructor.
3442
3443 2017-08-01  Chris Dumez  <cdumez@apple.com>
3444
3445         Add initial support for navigator.sendBeacon
3446         https://bugs.webkit.org/show_bug.cgi?id=175007
3447         <rdar://problem/33547728>
3448
3449         Reviewed by Sam Weinig.
3450
3451         Add setting to toggle support for the Beacon API (it is disabled by default).
3452
3453         * WebView/WebPreferenceKeysPrivate.h:
3454         * WebView/WebPreferences.mm:
3455         (+[WebPreferences initialize]):
3456         (-[WebPreferences beaconAPIEnabled]):
3457         (-[WebPreferences setBeaconAPIEnabled:]):
3458         * WebView/WebPreferencesPrivate.h:
3459         * WebView/WebView.mm:
3460         (-[WebView _preferencesChanged:]):
3461
3462 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
3463
3464         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
3465         https://bugs.webkit.org/show_bug.cgi?id=174437
3466
3467         Reviewed by Darin Adler.
3468
3469         Remove redundant Web- prefix from classes in WebKit namespace.
3470
3471         * WebView/WebView.mm:
3472         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3473         * WebView/WebViewData.h:
3474         * WebView/WebViewData.mm:
3475
3476 2017-07-26  Brian Burg  <bburg@apple.com>
3477
3478         Remove WEB_TIMING feature flag
3479         https://bugs.webkit.org/show_bug.cgi?id=174795
3480
3481         Reviewed by Alex Christensen.
3482
3483         * Configurations/FeatureDefines.xcconfig:
3484
3485 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3486
3487         Async image decoding for large images should be disabled after the first time a tile is painted
3488         https://bugs.webkit.org/show_bug.cgi?id=174451
3489         <rdar://problem/31246421>
3490
3491         Reviewed by Simon Fraser.
3492
3493         * WebView/WebFrame.mm:
3494         (-[WebFrame _paintBehaviorForDestinationContext:]):
3495         (-[WebFrame _drawRect:contentsOnly:]):
3496         * WebView/WebHTMLView.mm:
3497         (imageFromRect):
3498
3499 2017-07-23  Darin Adler  <darin@apple.com>
3500
3501         More NeverDestroyed and related cleanup
3502         https://bugs.webkit.org/show_bug.cgi?id=174745
3503
3504         Reviewed by Alex Christensen.
3505
3506         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
3507         for names that aren't even used in this file.
3508         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
3509         -[NSArray arrayWithObject:].
3510         (-[DOMNode absoluteQuads]): Ditto.
3511         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
3512         of writing out various types.
3513         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
3514         syntax instea of -[NSArray arrayWithObject:].
3515         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
3516         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
3517         of writing out various types.
3518         (-[DOMHTMLImageElement mimeType]): Ditto.
3519
3520 2017-07-24  Chris Dumez  <cdumez@apple.com>
3521
3522         ExceptionCode enumeration should use modern exception names
3523         https://bugs.webkit.org/show_bug.cgi?id=174794
3524
3525         Reviewed by Geoffrey Garen.
3526
3527         * DOM/ExceptionHandlers.mm:
3528         (raiseNotSupportedErrorException):
3529
3530 2017-07-23  Chris Dumez  <cdumez@apple.com>
3531
3532         Drop ExceptionCodeDescription class
3533         https://bugs.webkit.org/show_bug.cgi?id=174757
3534
3535         Reviewed by Darin Adler.
3536
3537         Stop using ExceptionCodeDescription.
3538
3539         * DOM/ExceptionHandlers.mm:
3540         (raiseDOMErrorException):
3541
3542 2017-07-21  Andreas Kling  <akling@apple.com>
3543
3544         Use more references in event dispatch code
3545         https://bugs.webkit.org/show_bug.cgi?id=174681
3546
3547         Reviewed by Geoffrey Garen.
3548
3549         * DOM/ObjCEventListener.h:
3550         * DOM/ObjCEventListener.mm:
3551         (WebCore::ObjCEventListener::handleEvent):
3552         * WebCoreSupport/WebFrameLoaderClient.mm:
3553         (NetscapePluginWidget::handleEvent):
3554
3555 2017-07-21  Brady Eidson  <beidson@apple.com>
3556
3557         Get rid of WebCore IconDatabase code.
3558         https://bugs.webkit.org/show_bug.cgi?id=174700
3559
3560         Reviewed by Tim Horton.
3561
3562         * Misc/WebCoreStatistics.mm:
3563         (+[WebCoreStatistics iconPageURLMappingCount]):
3564         (+[WebCoreStatistics iconRetainedPageURLCount]):
3565         (+[WebCoreStatistics iconRecordCount]):
3566         (+[WebCoreStatistics iconsWithDataCount]):
3567         * WebCoreSupport/WebFrameLoaderClient.h:
3568         * WebCoreSupport/WebFrameLoaderClient.mm:
3569         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
3570         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
3571         * WebView/WebView.mm:
3572         (-[WebView mainFrameIconURL]):
3573
3574 2017-07-20  Chris Dumez  <cdumez@apple.com>
3575
3576         Drop legacy XPathException type
3577         https://bugs.webkit.org/show_bug.cgi?id=174679
3578
3579         Reviewed by Sam Weinig.
3580
3581         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3582         no longer expose XPathException.
3583
3584         * DOM/ExceptionHandlers.mm:
3585         (raiseDOMErrorException):
3586
3587 2017-07-20  Chris Dumez  <cdumez@apple.com>
3588
3589         Unreviewed, rolling out r219706.
3590
3591         Broke iOS build
3592
3593         Reverted changeset:
3594
3595         "Drop legacy XPathException type"
3596         https://bugs.webkit.org/show_bug.cgi?id=174679
3597         http://trac.webkit.org/changeset/219706
3598
3599 2017-07-20  Chris Dumez  <cdumez@apple.com>
3600
3601         Drop legacy XPathException type
3602         https://bugs.webkit.org/show_bug.cgi?id=174679
3603
3604         Reviewed by Sam Weinig.
3605
3606         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3607         no longer expose XPathException.
3608
3609         * DOM/ExceptionHandlers.mm:
3610         (raiseDOMErrorException):
3611         * WebKit.exp:
3612
3613 2017-07-20  Chris Dumez  <cdumez@apple.com>
3614
3615         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
3616         https://bugs.webkit.org/show_bug.cgi?id=174660
3617
3618         Reviewed by Geoffrey Garen.
3619
3620         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
3621         This essentially replaces a branch to figure out if the new size is less or greater than the
3622         current size by an assertion.
3623
3624         * Plugins/WebNetscapePluginView.mm:
3625         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3626
3627 2017-07-20  Brady Eidson  <beidson@apple.com>
3628
3629         Deprecate WebIconDatabase in WebKitLegacy/mac.
3630         https://bugs.webkit.org/show_bug.cgi?id=174607
3631
3632         Reviewed by Alex Christensen.
3633
3634         This patch:
3635         1 - Formally deprecates WebIconDatabase (which was never API anyways)
3636         2 - Guts the class to where it can only return the default icon at the small size
3637         3 - Reworks other parts of WebKitLegacy that used it for anything to either
3638             use something else or to not do anything.
3639         
3640         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
3641         and that patch will remove all of the last remnants of WebIconDatabase.
3642         
3643         * History/WebHistoryItem.mm:
3644         (-[WebHistoryItem icon]):
3645
3646         * Misc/WebIconDatabase.h:
3647         * Misc/WebIconDatabase.mm:
3648         (-[WebIconDatabase init]):
3649         (-[WebIconDatabase iconForURL:withSize:cache:]):
3650         (-[WebIconDatabase iconForURL:withSize:]):
3651         (-[WebIconDatabase defaultIconWithSize:]):
3652         (-[WebIconDatabase defaultIconForURL:withSize:]):
3653         (-[WebIconDatabase iconURLForURL:]):
3654         (-[WebIconDatabase retainIconForURL:]):
3655         (-[WebIconDatabase releaseIconForURL:]):
3656         (+[WebIconDatabase delayDatabaseCleanup]):
3657         (+[WebIconDatabase allowDatabaseCleanup]):
3658         (-[WebIconDatabase setDelegate:]):
3659         (-[WebIconDatabase delegate]):
3660         (+[WebIconDatabase initialize]): Deleted.
3661         (-[WebIconDatabase isEnabled]): Deleted.
3662         (-[WebIconDatabase setEnabled:]): Deleted.
3663         (-[WebIconDatabase removeAllIcons]): Deleted.
3664         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
3665         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
3666         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
3667         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
3668         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
3669         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
3670         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
3671         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
3672         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
3673         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
3674         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
3675         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
3676         (-[WebIconDatabase _databaseDirectory]): Deleted.
3677         (webGetNSImage): Deleted.
3678
3679         * Misc/WebIconDatabaseDelegate.h: Removed.
3680         * Misc/WebIconDatabaseInternal.h: Removed.
3681         * Misc/WebIconDatabasePrivate.h: Removed.
3682
3683         * WebCoreSupport/WebFrameLoaderClient.mm:
3684         (webGetNSImage):
3685
3686         * WebCoreSupport/WebIconDatabaseClient.mm:
3687         (WebIconDatabaseClient::didRemoveAllIcons):
3688         (WebIconDatabaseClient::didImportIconURLForPageURL):
3689
3690         * WebView/WebView.mm:
3691         (-[WebView setFrameLoadDelegate:]):
3692         (-[WebView mainFrameIcon]):
3693
3694 2017-07-18  Andy Estes  <aestes@apple.com>
3695
3696         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
3697         https://bugs.webkit.org/show_bug.cgi?id=174631
3698
3699         Reviewed by Tim Horton.
3700
3701         * Configurations/Base.xcconfig:
3702
3703 2017-07-18  Andy Estes  <aestes@apple.com>
3704
3705         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
3706         https://bugs.webkit.org/show_bug.cgi?id=174631
3707
3708         Reviewed by Sam Weinig.
3709
3710         * Configurations/Base.xcconfig:
3711
3712 2017-07-18  Andy Estes  <aestes@apple.com>
3713
3714         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
3715         https://bugs.webkit.org/show_bug.cgi?id=174631
3716
3717         Reviewed by Dan Bernstein.
3718
3719         * Configurations/Base.xcconfig:
3720
3721 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3722
3723         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
3724         https://bugs.webkit.org/show_bug.cgi?id=174640
3725         <rdar://problem/33297400>
3726
3727         Reviewed by Tim Horton.
3728
3729         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
3730         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
3731         web thread here, to match the other WebView drag and drop SPI methods.
3732
3733         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
3734         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
3735         should make this robust against future UIKit changes that could make this no longer the case.
3736
3737         * WebView/WebView.mm:
3738         (-[WebView _requestStartDataInteraction:globalPosition:]):
3739         (-[WebView _dataInteractionCaretRect]):
3740
3741 2017-07-18  Andy Estes  <aestes@apple.com>
3742
3743         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
3744         https://bugs.webkit.org/show_bug.cgi?id=174631
3745
3746         Reviewed by Darin Adler.
3747
3748         * Configurations/Base.xcconfig:
3749
3750 2017-07-17  Sam Weinig  <sam@webkit.org>
3751
3752         [WebIDL] Remove custom bindings that require non-caching JS strings
3753         https://bugs.webkit.org/show_bug.cgi?id=174552
3754
3755         Reviewed by Darin Adler.
3756
3757         * DOM/DOMHTMLCanvasElement.mm:
3758         (-[DOMHTMLCanvasElement toDataURL:]):
3759         Update to account for implementation now returning an UncachedString.
3760
3761 2017-07-17  Darin Adler  <darin@apple.com>
3762
3763         Improve use of NeverDestroyed
3764         https://bugs.webkit.org/show_bug.cgi?id=174348
3765
3766         Reviewed by Sam Weinig.
3767
3768         * Misc/WebStringTruncator.mm:
3769         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
3770         NeverDestroyed<RetainPtr> with just an NSFont * global.
3771
3772         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
3773         NeverDestroyed.h.
3774         * Storage/WebDatabaseManager.mm: Ditto.
3775         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
3776         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
3777
3778         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
3779         (aeDescFromJSValue): Removed double hashing by using the return value from
3780         add rather than calling contains before calling add.
3781
3782 2017-07-14  Jer Noble  <jer.noble@apple.com>
3783
3784         Allow clients to override their own hardware media requirements where no fallback media exists.
3785         https://bugs.webkit.org/show_bug.cgi?id=174426
3786         <rdar://problem/32537704>
3787
3788         Reviewed by Eric Carlson.
3789
3790         Add a new WebPreferences property to control WebCore's new
3791         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
3792
3793         * WebView/WebPreferenceKeysPrivate.h:
3794         * WebView/WebPreferences.mm:
3795         (+[WebPreferences initialize]):
3796         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
3797         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
3798         * WebView/WebPreferencesPrivate.h:
3799         * WebView/WebView.mm:
3800         (-[WebView _preferencesChanged:]):
3801
3802 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
3803
3804         Async image decoding for large images should be disabled by default
3805         https://bugs.webkit.org/show_bug.cgi?id=174432
3806
3807         Reviewed by Simon Fraser.
3808
3809         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
3810         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
3811         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
3812            a child view instead of propagating PaintBehaviorSnapshotting.
3813         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
3814            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
3815
3816         * WebView/WebFrame.mm:
3817         (-[WebFrame _paintBehaviorForDestinationContext:]):
3818         (-[WebFrame _drawRect:contentsOnly:]):
3819         * WebView/WebHTMLView.mm:
3820         (imageFromRect):
3821
3822 2017-07-12  Daniel Bates  <dabates@apple.com>
3823
3824         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
3825         https://bugs.webkit.org/show_bug.cgi?id=174427
3826
3827         Rubber-stamped by Brady Eidson.
3828
3829         * WebView/WebPDFView.mm:
3830         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3831
3832 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3833
3834         Unreviewed, rolling out r219401.
3835
3836         This revision rolled out the previous patch, but after talking
3837         with reviewer, a rebaseline is what was needed.Rolling back in
3838         before rebaseline.
3839
3840         Reverted changeset:
3841
3842         "Unreviewed, rolling out r219379."
3843         https://bugs.webkit.org/show_bug.cgi?id=174400
3844         http://trac.webkit.org/changeset/219401
3845
3846 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3847
3848         Unreviewed, rolling out r219379.
3849
3850         This revision caused a consistent failure in the test
3851         fast/dom/Window/property-access-on-cached-window-after-frame-
3852         removed.html.
3853
3854         Reverted changeset:
3855
3856         "Remove NAVIGATOR_HWCONCURRENCY"
3857         https://bugs.webkit.org/show_bug.cgi?id=174400
3858         http://trac.webkit.org/changeset/219379
3859
3860 2017-07-11  Dean Jackson  <dino@apple.com>
3861
3862         Remove NAVIGATOR_HWCONCURRENCY
3863         https://bugs.webkit.org/show_bug.cgi?id=174400
3864
3865         * Configurations/FeatureDefines.xcconfig:
3866
3867 2017-07-11  Dean Jackson  <dino@apple.com>
3868
3869         Rolling out r219372.
3870
3871         * Configurations/FeatureDefines.xcconfig:
3872
3873 2017-07-11  Dean Jackson  <dino@apple.com>
3874
3875         Remove NAVIGATOR_HWCONCURRENCY
3876         https://bugs.webkit.org/show_bug.cgi?id=174400
3877
3878         * Configurations/FeatureDefines.xcconfig:
3879
3880 2017-07-03  Brian Burg  <bburg@apple.com>
3881
3882         Web Replay: remove some unused code
3883         https://bugs.webkit.org/show_bug.cgi?id=173903
3884
3885         Rubber-stamped by Joseph Pecoraro.
3886
3887         * Configurations/FeatureDefines.xcconfig:
3888
3889 2017-07-09  Brady Eidson  <beidson@apple.com>
3890
3891         Remove some obsolete WebKitVersionChecks.
3892         https://bugs.webkit.org/show_bug.cgi?id=174294
3893
3894         Reviewed by Dan Bernstein.
3895
3896         * Misc/WebKitVersionChecks.h:
3897
3898         * WebView/WebHTMLView.mm:
3899         (-[WebHTMLView hitTest:]):
3900
3901         * WebView/WebView.mm:
3902         (shouldRespectPriorityInCSSAttributeSetters):
3903         (-[WebView _commonInitializationWithFrameName:groupName:]):
3904         (-[WebView _preferencesChanged:]):
3905         (shouldTransformsAffectOverflow): Deleted.
3906         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
3907
3908 2017-07-08  Brady Eidson  <beidson@apple.com>
3909
3910         Remove some obsolete RuntimeApplicationChecks.
3911         https://bugs.webkit.org/show_bug.cgi?id=174293
3912
3913         Reviewed by Dan Bernstein.
3914
3915         * Misc/WebKitVersionChecks.h:
3916         * WebView/WebView.mm:
3917         (+[WebView enableWebThread]):
3918         (-[WebView _needsPreHTML5ParserQuirks]):
3919
3920 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3921
3922         Drop NOSNIFF compile flag
3923         https://bugs.webkit.org/show_bug.cgi?id=174289
3924
3925         Reviewed by Michael Catanzaro.
3926
3927         * Configurations/FeatureDefines.xcconfig:
3928
3929 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
3930
3931         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3932         https://bugs.webkit.org/show_bug.cgi?id=174150
3933
3934         Reviewed by Mark Lam.
3935
3936         * DOM/DOM.mm:
3937         (lookupElementClass):
3938
3939 2017-07-06  Brady Eidson  <beidson@apple.com>
3940
3941         Add logging to first attempt to use the WebIconDatabase class.
3942         https://bugs.webkit.org/show_bug.cgi?id=174190
3943
3944         Reviewed by Andy Estes.
3945
3946         * Misc/WebIconDatabase.mm:
3947         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
3948         * Misc/WebKitVersionChecks.h:
3949
3950 2017-07-06  Matt Lewis  <jlewis3@apple.com>
3951
3952         Unreviewed, rolling out r219178.
3953
3954         This caused a consistent failure with the API test
3955         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
3956
3957         Reverted changeset:
3958
3959         "[WTF] Clean up StringStatics.cpp by using
3960         LazyNeverDestroyed<> for Atoms"
3961         https://bugs.webkit.org/show_bug.cgi?id=174150
3962         http://trac.webkit.org/changeset/219178
3963
3964 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
3965
3966         [WTF] Move SoftLinking.h into WTF
3967         https://bugs.webkit.org/show_bug.cgi?id=174000
3968
3969         Reviewed by Alex Christensen.
3970
3971         * Plugins/WebNetscapePluginView.mm:
3972         * Plugins/WebPluginController.mm:
3973         * WebCoreSupport/WebInspectorClient.mm:
3974         * WebView/WebFullScreenController.mm:
3975         * WebView/WebImmediateActionController.mm:
3976         * WebView/WebView.mm:
3977
3978 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3979
3980         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3981         https://bugs.webkit.org/show_bug.cgi?id=174150
3982
3983         Reviewed by Mark Lam.
3984
3985         * DOM/DOM.mm:
3986         (lookupElementClass):
3987
3988 2017-07-05  Brady Eidson  <beidson@apple.com>
3989
3990         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
3991         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
3992
3993         Reviewed by Alex Christensen.
3994
3995         Adopt to the new constructor for FrameLoadRequest.
3996
3997         * WebView/WebPDFView.mm:
3998         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3999
4000 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
4001
4002         Make WebKit's public headers on Mac and iOS C++ module safe
4003         https://bugs.webkit.org/show_bug.cgi?id=174175
4004
4005         Reviewed by Alex Christensen.
4006
4007         Fixed the header files.
4008
4009         * Misc/WebDownload.h:
4010         * Misc/WebKitErrors.h:
4011         * Plugins/WebPluginContainer.h:
4012         * WebView/WebResourceLoadDelegate.h:
4013
4014 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
4015
4016         Remove copy of ICU headers from WebKit
4017         https://bugs.webkit.org/show_bug.cgi?id=116407
4018
4019         Reviewed by Alex Christensen.
4020
4021         Use WTF's copy of ICU headers.
4022
4023         * Configurations/WebKitLegacy.xcconfig:
4024         * icu/unicode/localpointer.h: Removed.
4025         * icu/unicode/parseerr.h: Removed.
4026         * icu/unicode/platform.h: Removed.
4027         * icu/unicode/ptypes.h: Removed.
4028         * icu/unicode/putil.h: Removed.
4029         * icu/unicode/uchar.h: Removed.
4030         * icu/unicode/uconfig.h: Removed.
4031         * icu/unicode/ucurr.h: Removed.
4032         * icu/unicode/uidna.h: Removed.
4033         * icu/unicode/uiter.h: Removed.
4034         * icu/unicode/umachine.h: Removed.
4035         * icu/unicode/unorm.h: Removed.
4036         * icu/unicode/unorm2.h: Removed.
4037         * icu/unicode/urename.h: Removed.
4038         * icu/unicode/uscript.h: Removed.
4039         * icu/unicode/ustring.h: Removed.
4040         * icu/unicode/utf.h: Removed.
4041         * icu/unicode/utf16.h: Removed.
4042         * icu/unicode/utf8.h: Removed.
4043         * icu/unicode/utf_old.h: Removed.
4044         * icu/unicode/utypes.h: Removed.
4045         * icu/unicode/uvernum.h: Removed.
4046         * icu/unicode/uversion.h: Removed.
4047
4048 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
4049
4050         Add WebKitPrivateFrameworkStubs for iOS 11
4051         https://bugs.webkit.org/show_bug.cgi?id=173988
4052
4053         Reviewed by David Kilzer.
4054
4055         * Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
4056         use the same directory for private framework stubs.
4057
4058 2017-07-03  Matt Lewis  <jlewis3@apple.com>
4059
4060         Unreviewed, rolling out r219103.
4061
4062         Caused multiple build failures.
4063
4064         Reverted changeset:
4065
4066         "Remove copy of ICU headers from WebKit"
4067         https://bugs.webkit.org/show_bug.cgi?id=116407
4068         http://trac.webkit.org/changeset/219103
4069
4070 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
4071
4072         Remove copy of ICU headers from WebKit
4073         https://bugs.webkit.org/show_bug.cgi?id=116407
4074
4075         Reviewed by Alex Christensen.
4076
4077         Use WTF's copy of ICU headers.
4078
4079         * Configurations/WebKitLegacy.xcconfig:
4080         * icu/unicode/localpointer.h: Removed.
4081         * icu/unicode/parseerr.h: Removed.
4082         * icu/unicode/platform.h: Removed.
4083         * icu/unicode/ptypes.h: Removed.
4084         * icu/unicode/putil.h: Removed.
4085         * icu/unicode/uchar.h: Removed.
4086         * icu/unicode/uconfig.h: Removed.
4087         * icu/unicode/ucurr.h: Removed.
4088         * icu/unicode/uidna.h: Removed.
4089         * icu/unicode/uiter.h: Removed.
4090         * icu/unicode/umachine.h: Removed.
4091         * icu/unicode/unorm.h: Removed.
4092         * icu/unicode/unorm2.h: Removed.
4093         * icu/unicode/urename.h: Removed.
4094         * icu/unicode/uscript.h: Removed.
4095         * icu/unicode/ustring.h: Removed.
4096         * icu/unicode/utf.h: Removed.
4097         * icu/unicode/utf16.h: Removed.
4098         * icu/unicode/utf8.h: Removed.
4099         * icu/unicode/utf_old.h: Removed.
4100         * icu/unicode/utypes.h: Removed.
4101         * icu/unicode/uvernum.h: Removed.
4102         * icu/unicode/uversion.h: Removed.
4103
4104 2017-07-03  Brady Eidson  <beidson@apple.com>
4105
4106         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
4107         https://bugs.webkit.org/show_bug.cgi?id=174073
4108