Disable FTP.
[WebKit-https.git] / Source / WebKitLegacy / ios / ChangeLog
1 2021-05-30  Darin Adler  <darin@apple.com>
2
3         Remove WTF::Optional synonym for std::optional, using that class template directly instead
4         https://bugs.webkit.org/show_bug.cgi?id=226433
5
6         Reviewed by Chris Dumez.
7
8         * WebCoreSupport/WebChromeClientIOS.h: Let the do-webcore-rename script rename
9         Optional<> to std::optional<>.
10
11 2021-05-21  Chris Dumez  <cdumez@apple.com>
12
13         Stop using holdLock() in WebKit/WebKitLegacy/Tools as it is not compatible with Clang thread safety analysis
14         https://bugs.webkit.org/show_bug.cgi?id=226127
15
16         Reviewed by Alex Christensen.
17
18         * WebCoreSupport/WebFixedPositionContent.mm:
19         (-[WebFixedPositionContent scrollOrZoomChanged:]):
20         (-[WebFixedPositionContent overflowScrollPositionForLayer:changedTo:]):
21         (-[WebFixedPositionContent setViewportConstrainedLayers:stickyContainerMap:]):
22         (-[WebFixedPositionContent hasFixedOrStickyPositionLayers]):
23
24 2021-05-10  Wenson Hsieh  <wenson_hsieh@apple.com>
25
26         Make WebCore::HitTestRequest::RequestType an enum class
27         https://bugs.webkit.org/show_bug.cgi?id=225597
28
29         Reviewed by Sam Weinig.
30
31         See WebCore/ChangeLog for more details.
32
33         * WebCoreSupport/WebFrameIOS.mm:
34         (-[WebFrame elementRectAtPoint:]):
35
36 2021-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
37
38         Rename WebCore::SelectionRect to WebCore::SelectionGeometry
39         https://bugs.webkit.org/show_bug.cgi?id=224820
40
41         Reviewed by Megan Gardner.
42
43         * WebCoreSupport/WebFrameIOS.mm:
44         (-[WebFrame selectionRectsForCoreRange:]):
45
46 2021-03-10  Chris Dumez  <cdumez@apple.com>
47
48         Use RetainPtr<> / OSObjectPtr<> more in WebKit
49         https://bugs.webkit.org/show_bug.cgi?id=223030
50
51         Reviewed by Darin Adler.
52
53         * WebView/WebPDFViewIOS.mm:
54         (createCGColorWithDeviceWhite):
55         (+[WebPDFView shadowColor]):
56         (+[WebPDFView backgroundColor]):
57
58 2021-03-05  Chris Dumez  <cdumez@apple.com>
59
60         Reduce use of CFRetain() / CFRelease() / CFAutoRelease() in WebKit
61         https://bugs.webkit.org/show_bug.cgi?id=222760
62
63         Reviewed by Darin Adler.
64
65         Reduce use of CFRetain() / CFRelease() / CFAutoRelease() in WebKit by using RetainPtr<>.
66
67         * Misc/WebUIKitSupport.mm:
68         (LoadWebLocalizedStrings):
69         * WebView/WebPDFViewIOS.mm:
70         (-[WebPDFView finishedLoadingWithDataSource:]):
71         * WebView/WebPDFViewPlaceholder.mm:
72         (-[WebPDFViewPlaceholder finishedLoadingWithDataSource:]):
73
74 2021-02-22  Chris Dumez  <cdumez@apple.com>
75
76         Use adoptNS() as soon as we [[ObjcClass alloc] init] to avoid leaks
77         https://bugs.webkit.org/show_bug.cgi?id=222237
78
79         Reviewed by Darin Adler.
80
81         * Misc/WebGeolocationProviderIOS.mm:
82         (+[WebGeolocationProviderIOS sharedGeolocationProvider]):
83
84 2021-02-17  Chris Dumez  <cdumez@apple.com>
85
86         Reduce explicit usage of [objC autorelease] in WebKit even further
87         https://bugs.webkit.org/show_bug.cgi?id=222060
88
89         Reviewed by Darin Adler.
90
91         Reduce explicit usage of [objC autorelease] in WebKit further by using RetainPtr.
92
93         * WebCoreSupport/WebSelectionRect.m:
94         (+[WebSelectionRect selectionRect]):
95         * WebCoreSupport/WebVisiblePosition.mm:
96         * WebView/WebPDFViewIOS.mm:
97         (-[WebPDFView _checkPDFTitle]):
98
99 2021-02-12  Chris Dumez  <cdumez@apple.com>
100
101         Reduce explicit usage of [objC release] in WebKit
102         https://bugs.webkit.org/show_bug.cgi?id=221780
103         <rdar://problem/74282389>
104
105         Reviewed by Darin Adler.
106
107         Apply review feedback from Darin Adler and Sam Weinig after r272789.
108
109         * WebView/WebPDFViewPlaceholder.mm:
110         (-[WebPDFViewPlaceholder _updateTitleForDocumentIfAvailable]):
111
112 2021-02-12  Chris Dumez  <cdumez@apple.com>
113
114         Reduce explicit usage of [objC release] in WebKit
115         https://bugs.webkit.org/show_bug.cgi?id=221780
116
117         Reviewed by Alex Christensen.
118
119         Reduce explicit usage of [objC release] in WebKit by using smart pointers.
120
121         * WebCoreSupport/WebChromeClientIOS.mm:
122         (WebChromeClientIOS::runOpenPanel):
123         * WebView/WebPDFViewIOS.mm:
124         (-[WebPDFView dealloc]):
125         (-[WebPDFView setDataSource:]):
126         (-[WebPDFView _checkPDFTitle]):
127         (-[WebPDFView title]):
128         * WebView/WebPDFViewPlaceholder.mm:
129         (-[WebPDFViewPlaceholder _updateTitleForDocumentIfAvailable]):
130
131 2021-01-19  Keith Rollin  <krollin@apple.com>
132
133         Modularize WebKitLegacy.framework
134         https://bugs.webkit.org/show_bug.cgi?id=220026
135         <rdar://57173237>
136
137         Reviewed by Darin Adler.
138
139         Add .modulemap files to WebKitLegacy to help speed up client builds.
140
141         For WebUIKitDelegate.h, ensure that ENABLE_ORIENTATION_EVENTS is
142         defined before checking its value, thereby avoiding a compiler
143         warning-turned-error that an uninitialized symbol is being used.
144
145         * WebView/WebUIKitDelegate.h:
146
147 2021-01-14  Geoffrey Garen  <ggaren@apple.com>
148
149         Removed most uses of dispatch_async(dispatch_get_main_queue(), ...)
150         https://bugs.webkit.org/show_bug.cgi?id=220066
151
152         Reviewed by Antti Koivisto.
153
154         dispatch_async has two downsides:
155
156         (1) Its order is undefined (and in practice highly variable) relative to
157         other WebKit operations. This sometimes causes flakiness.
158
159         (2) It doesn't honor the RunLoop first paint optimization.
160
161         We can use RunLoop::dispatch() instead.
162
163         * Misc/WebGeolocationProviderIOS.mm:
164         (-[WebGeolocationProviderIOS registerWebView:]):
165         (-[WebGeolocationProviderIOS unregisterWebView:]):
166         (-[WebGeolocationProviderIOS setEnableHighAccuracy:]):
167         (-[WebGeolocationProviderIOS initializeGeolocationForWebView:listener:]):
168         * WebCoreSupport/WebChromeClientIOS.mm:
169         (WebChromeClientIOS::runOpenPanel):
170         * WebCoreSupport/WebInspectorClientIOS.mm:
171         (WebInspectorClient::didSetSearchingForNode):
172
173 2020-11-06  Sam Weinig  <weinig@apple.com>
174
175         Further progress towards merging Settings.yaml into WebPreferences.yaml
176         https://bugs.webkit.org/show_bug.cgi?id=218663
177
178         Reviewed by Tim Horton.
179
180         * Misc/WebUIKitSupport.mm:
181         (WebKitGetMinimumZoomFontSize):
182         Use generated default value macro as the one in WebCore has now been removed.
183
184 2020-10-06  Devin Rousso  <drousso@apple.com>
185
186         Move platform logic for CSS `hover` and `pointer` media queries outside of WebCore
187         https://bugs.webkit.org/show_bug.cgi?id=217413
188
189         Reviewed by Tim Horton.
190
191         * WebCoreSupport/WebChromeClientIOS.h:
192         (WebChromeClientIOS::hoverSupportedByPrimaryPointingDevice const): Added.
193         (WebChromeClientIOS::pointerCharacteristicsOfPrimaryPointingDevice const): Added.
194         Mouse devices are not supported.
195
196 2020-10-06  Devin Rousso  <drousso@apple.com>
197
198         CSS hover and "pointer: fine" media queries do not evaluate to true with iOS 13.4 mouse support
199         https://bugs.webkit.org/show_bug.cgi?id=209292
200         <rdar://problem/60663124>
201
202         Reviewed by Tim Horton.
203
204         * WebCoreSupport/WebChromeClientIOS.h:
205         (WebChromeClientIOS::hoverSupportedByAnyAvailablePointingDevice const): Added.
206         (WebChromeClientIOS::pointerCharacteristicsOfAllAvailablePointingDevices const): Added.
207         Mouse devices are not supported.
208
209 2020-09-20  Darin Adler  <darin@apple.com>
210
211         Next step towards eliminating deprecated legacy positions
212         https://bugs.webkit.org/show_bug.cgi?id=216751
213
214         Reviewed by Sam Weinig.
215
216         * WebCoreSupport/WebVisiblePosition.mm:
217         (-[DOMNode startPosition]):
218         (-[DOMNode endPosition]):
219         Replaced calls to createLegacyEditingPosition with calls to
220         makeDeprecatedLegacyPosition or makeContainerOffsetPosition.
221
222 2020-09-02  Darin Adler  <darin@apple.com>
223
224         Remove EAffinity, UPSTREAM, DOWNSTREAM, SEL_DEFAULT_AFFINITY, and VisibleSelection::selectionType
225         https://bugs.webkit.org/show_bug.cgi?id=216102
226
227         Reviewed by Sam Weinig.
228
229         * WebCoreSupport/WebFrameIOS.mm:
230         (-[WebFrame closestCaretRectInMarkedTextRangeForPoint:]): Use Affinity.
231         (-[WebFrame smartExtendRangedSelection:]): Use visibleStart/End/Extent so we don't
232         need to write explicit code to handle affinity.
233
234         * WebCoreSupport/WebVisiblePosition.mm:
235         (-[WebVisiblePosition setAffinity:]): Use Affinity.
236
237 2020-09-02  Darin Adler  <darin@apple.com>
238
239         Change Affinity into an enum class
240         https://bugs.webkit.org/show_bug.cgi?id=216096
241
242         Reviewed by Wenson Hsieh.
243
244         * WebCoreSupport/WebVisiblePosition.mm:
245         (-[WebVisiblePosition positionByMovingInDirection:amount:withAffinityDownstream:]):
246         Use prefix.
247
248 2020-09-01  Darin Adler  <darin@apple.com>
249
250         Remove comparePositions and make VisiblePosition improvements
251         https://bugs.webkit.org/show_bug.cgi?id=215982
252
253         Reviewed by Sam Weinig.
254
255         * WebCoreSupport/WebVisiblePosition.mm:
256         (-[WebVisiblePosition positionByMovingInDirection:amount:withAffinityDownstream:]):
257         Use Upstream instead of VP_UPSTREAM_IF_POSSIBLE. Since we were calling
258         setAffinity here, VP_UPSTREAM_IF_POSSIBLE was misleading since that function
259         does not check the validity of the affinity.
260         (-[DOMNode startPosition]): Removed unnecessary explicit VP_DEFAULT_AFFINITY.
261         (-[DOMNode endPosition]): Ditto.
262
263 2020-08-17  Darin Adler  <darin@apple.com>
264
265         Create documentOrder function, start refactoring to use it instead of Range::compare functions
266         https://bugs.webkit.org/show_bug.cgi?id=215551
267
268         Reviewed by Chris Dumez.
269
270         * WebCoreSupport/WebVisiblePosition.mm:
271         (-[DOMRange startPosition]): Rewrote to not use Range::startPosition.
272         (-[DOMRange endPosition]): Rewrote to not use Range::endPosition.
273
274 2020-08-13  Tim Horton  <timothy_horton@apple.com>
275
276         macCatalyst: Granting location permission doesn't allow geolocation access
277         https://bugs.webkit.org/show_bug.cgi?id=215464
278         <rdar://problem/64719458>
279
280         Reviewed by Wenson Hsieh.
281
282         * Misc/WebGeolocationCoreLocationProvider.mm:
283         (-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):
284         Un-ifdef this code that was ifdeffed in r229963 during macCatalyst
285         bring-up and doesn't need to be anymore.
286
287 2020-08-10  Tim Horton  <timothy_horton@apple.com>
288
289         REGRESSION (r265176): Cannot make or extend selections in iOS WebKitLegacy 
290         https://bugs.webkit.org/show_bug.cgi?id=215319
291         <rdar://problem/66688560>
292
293         Reviewed by Devin Rousso.
294
295         * WebCoreSupport/WebVisiblePosition.mm:
296         (+[DOMRange rangeForFirstPosition:second:]):
297         We want to ensure that firstPosition is *before* secondPosition, so
298         the change in r265176 got the condition backwards. Swap it.
299
300 2020-08-04  Darin Adler  <darin@apple.com>
301
302         Try to fix Catalyst build
303         https://bugs.webkit.org/show_bug.cgi?id=215133
304         rdar://66534119
305
306         * WebCoreSupport/WebVisiblePosition.mm: Add include of SimpleRange.h.
307
308 2020-08-02  Darin Adler  <darin@apple.com>
309
310         Remove some member functions of Range and many calls to createLiveRange
311         https://bugs.webkit.org/show_bug.cgi?id=215070
312
313         Reviewed by Sam Weinig.
314
315         * WebCoreSupport/WebFrameIOS.mm:
316         (-[WebFrame selectionRectsForCoreRange:]): Remove createLiveRange.
317         (-[WebFrame selectionRectsForRange:]): Use makeSimpleRange.
318         * WebCoreSupport/WebVisiblePosition.mm:
319         (-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]): Ditto.
320         (-[WebVisiblePosition enclosingRangeWithCorrectionIndicator]): Ditto.
321         (+[DOMRange rangeForFirstPosition:second:]): Rename firstVP/secondVP
322         to firstPosition/secondPosition.
323
324 2020-08-01  Darin Adler  <darin@apple.com>
325
326         Remove Range::create and many more uses of live ranges
327         https://bugs.webkit.org/show_bug.cgi?id=215004
328
329         Reviewed by Sam Weinig.
330
331         * WebCoreSupport/WebFrameIOS.mm:
332         (-[WebFrame wordAtPoint:]): Use makeSimpleRange.
333
334         * WebCoreSupport/WebVisiblePosition.mm:
335         (-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]): Use document
336         marker range function.
337         (-[WebVisiblePosition enclosingRangeWithCorrectionIndicator]): Ditto.
338         (+[DOMRange rangeForFirstPosition:second:]): Use makeSimpleRange.
339
340 2020-07-30  Darin Adler  <darin@apple.com>
341
342         Further reduction in the use of live ranges, particularly in headers
343         https://bugs.webkit.org/show_bug.cgi?id=214793
344
345         Reviewed by Sam Weinig.
346
347         * WebCoreSupport/WebVisiblePosition.mm:
348         (-[WebVisiblePosition enclosingTextUnitOfGranularity:inDirectionIfAtBoundary:]):
349         Use SimpleRange.
350
351 2020-07-19  Darin Adler  <darin@apple.com>
352
353         Remove live ranges from Editor.h and EditorClient.h
354         https://bugs.webkit.org/show_bug.cgi?id=214261
355
356         Reviewed by Sam Weinig.
357
358         * WebCoreSupport/WebFrameIOS.mm:
359         (-[WebFrame closestCaretRectInMarkedTextRangeForPoint:]):
360         Updated since compositionRange is no longer a live range.
361
362 2020-07-03  Said Abou-Hallawa  <sabouhallawa@apple.com>
363
364         Change the names of MIMETypeRegistry methods to comply with webkit naming style
365         https://bugs.webkit.org/show_bug.cgi?id=213912
366
367         Reviewed by Youenn Fablet.
368
369         * WebCoreSupport/WebMIMETypeRegistry.mm:
370         (+[WebMIMETypeRegistry mimeTypeForExtension:]):
371         (+[WebMIMETypeRegistry preferredExtensionForMIMEType:]):
372
373 2020-05-15  Alex Christensen  <achristensen@webkit.org>
374
375         Use enum serialization instead of casting to/from uint32_t
376         https://bugs.webkit.org/show_bug.cgi?id=211885
377
378         Reviewed by Geoffrey Garen.
379
380         * WebCoreSupport/WebFrameIOS.mm:
381         (-[WebFrame aggressivelyExpandSelectionToWordContainingCaretSelection]):
382         (-[WebFrame setSelectionGranularity:]):
383         * WebCoreSupport/WebVisiblePosition.mm:
384         (toTextGranularity):
385         (toSelectionDirection):
386
387 2020-05-14  Daniel Bates  <dabates@apple.com>
388
389         [iOS] Remove dead dictation code
390         https://bugs.webkit.org/show_bug.cgi?id=211871
391
392         Reviewed by Wenson Hsieh.
393
394         * DefaultDelegates/WebDefaultUIKitDelegate.m:
395         (-[WebDefaultUIKitDelegate isUnperturbedDictationResultMarker:]): Deleted.
396         * WebCoreSupport/WebFrameIOS.h:
397         * WebCoreSupport/WebFrameIOS.mm:
398         (-[WebFrame previousUnperturbedDictationResultBoundaryFromPosition:]): Deleted.
399         (-[WebFrame nextUnperturbedDictationResultBoundaryFromPosition:]): Deleted.
400         * WebView/WebUIKitDelegate.h:
401
402 2020-05-10  Tim Horton  <timothy_horton@apple.com>
403
404         Clicking a tel:// link on iPad with a trackpad presents different UI than tapping on it
405         https://bugs.webkit.org/show_bug.cgi?id=211686
406         <rdar://problem/57941589>
407
408         Reviewed by Wenson Hsieh.
409
410         * WebCoreSupport/WebChromeClientIOS.h:
411
412 2020-04-11  Darin Adler  <darin@apple.com>
413
414         Stop using live ranges in functions that return range of the selection
415         https://bugs.webkit.org/show_bug.cgi?id=210396
416
417         Reviewed by Sam Weinig.
418
419         * WebCoreSupport/WebFrameIOS.mm:
420         (-[WebFrame selectionRectsForCoreRange:]): Changed argument type to
421         not require a live range. Internally, use createLiveRange and also
422         use a range-for loop.
423         (-[WebFrame selectionRectsForRange:]): Remove use of live range.
424         (-[WebFrame selectionRects]): Ditto.
425
426 2020-04-19  Darin Adler  <darin@apple.com>
427
428         [Cocoa] Use createNSArray in many more places that build NSArray objects from C++ collections
429         https://bugs.webkit.org/show_bug.cgi?id=210702
430
431         Reviewed by Alex Christensen.
432
433         * WebCoreSupport/WebFrameIOS.mm:
434         (-[WebFrame selectionRectsForCoreRange:]): Use createNSArray.
435
436 2020-04-20  Darin Adler  <darin@apple.com>
437
438         Use #import instead of #include in Objective-C and don't use #pragma once
439         https://bugs.webkit.org/show_bug.cgi?id=210724
440
441         Reviewed by David Kilzer.
442
443         * Misc/MemoryMeasure.h: Removed.
444         * Misc/MemoryMeasure.mm: Removed.
445         * WebKit.iOS.exp: Removed MemoryMeasure symbols.
446
447 2020-04-18  Rob Buis  <rbuis@igalia.com>
448
449         Reduce parameter list of the FrameLoadRequest constructor
450         https://bugs.webkit.org/show_bug.cgi?id=210668
451
452         Reviewed by Darin Adler.
453
454         Adapt to API change.
455
456         * WebView/WebPDFViewPlaceholder.mm:
457         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
458
459 2020-04-12  Darin Adler  <darin@apple.com>
460
461         Fix some strange uses of start/endOfDocument
462         https://bugs.webkit.org/show_bug.cgi?id=210408
463
464         Reviewed by Wenson Hsieh.
465
466         * WebCoreSupport/WebFrameIOS.mm:
467         (-[WebFrame moveSelectionToStart]): Call startOfDocument on the document;
468         there is no need to pass a particular VisiblePosition, since all it gets
469         from the VisiblePosition is the document.
470         (-[WebFrame moveSelectionToEnd]): Ditto, for endOfDocument.
471         (-[WebFrame startPosition]): Call startOfDocument on the document rather
472         than using code to find the document element, since the function works
473         on any node.
474         (-[WebFrame endPosition]): Ditto.
475
476 2020-04-10  Darin Adler  <darin@apple.com>
477
478         Move more from live range to SimpleRange: callers of absoluteTextRects
479         https://bugs.webkit.org/show_bug.cgi?id=210369
480
481         Reviewed by Anders Carlsson.
482
483         * WebCoreSupport/WebFrameIOS.mm:
484         (-[WebFrame closestCaretRectInMarkedTextRangeForPoint:]): Use
485         RenderObject::absoluteTextRects instead of Range::absoluteTextRects.
486         Also added some missing null checks and reorganized the function a
487         bit to make it more direct and slightly cleaerer.
488
489 2020-04-08  Darin Adler  <darin@apple.com>
490
491         [Cocoa] Simplify NSArray, NSDictionary, and NSNumber idioms throughout WebKit
492         https://bugs.webkit.org/show_bug.cgi?id=210138
493
494         Reviewed by Alex Christensen.
495
496         * WebCoreSupport/WebChromeClientIOS.mm:
497         (WebChromeClientIOS::runOpenPanel): Use createNSArray.
498
499         * WebCoreSupport/WebVisiblePosition.mm:
500         (-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]):
501         Use createNSArray.
502
503         * WebCoreSupport/WebVisiblePositionInternal.h:
504         Added #if so that this correctly doesn't compile anything on Mac.
505
506         * WebView/WebPDFViewIOS.mm:
507         (+[WebPDFView supportedMIMETypes]): Use @[].
508
509 2020-04-04  Darin Adler  <darin@apple.com>
510
511         Stop using live ranges in DocumentMarkerController
512         https://bugs.webkit.org/show_bug.cgi?id=209985
513
514         Reviewed by Antti Koivisto.
515
516         * WebCoreSupport/WebFrameIOS.mm:
517         (-[WebFrame previousUnperturbedDictationResultBoundaryFromPosition:]):
518         Update since DocumentMarker::metadata no longer exists.
519         (-[WebFrame nextUnperturbedDictationResultBoundaryFromPosition:]):
520         Ditto.
521
522         * WebCoreSupport/WebVisiblePosition.mm:
523         (-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]):
524         Update since DocumentMarker::alternatives no longer exists.
525         (-[WebVisiblePosition enclosingRangeWithCorrectionIndicator]):
526         Ditto.
527
528 2020-03-12  Alexey Proskuryakov  <ap@apple.com>
529
530         rdar://problem/60359230 Mark locationManager:didChangeAuthorizationStatus: as deprecated.
531
532         * Misc/WebGeolocationCoreLocationProvider.mm:
533         (-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]):
534
535 2020-03-07  Darin Adler  <darin@apple.com>
536
537         Begin moving off of live ranges for WebKit internals
538         https://bugs.webkit.org/show_bug.cgi?id=208432
539
540         Reviewed by Daniel Bates.
541
542         * WebCoreSupport/WebFrameIOS.mm: Added include.
543
544 2020-03-03  Devin Rousso  <drousso@apple.com>
545
546         Web Inspector: re-add `InspectorFrontendHost` support for moving the inspected window
547         https://bugs.webkit.org/show_bug.cgi?id=208555
548
549         Reviewed by Timothy Hatcher.
550
551         Partially revert r257759, as the design changed enough such that this code is still useful.
552
553         Allow the Web Inspector frontend to ask the containing app (via `InspectorFrontendClient`)
554         whether it supports the given docking configuration.
555
556         * WebCoreSupport/WebInspectorClientIOS.mm:
557         (WebInspectorFrontendClient::supportsDockSide): Added.
558         (WebInspectorFrontendClient::startWindowDrag): Added.
559
560 2020-03-03  Devin Rousso  <drousso@apple.com>
561
562         Web Inspector: setting the frontend appearance doesn't update the window when undocked
563         https://bugs.webkit.org/show_bug.cgi?id=208503
564
565         Reviewed by Timothy Hatcher.
566
567         Notify the UIProcess when setting the forced appearance so platforms that support dark mode
568         are able to run native code to adjust the appearance of the undocked window.
569
570         * WebCoreSupport/WebInspectorClientIOS.mm:
571         (WebInspectorFrontendClient::setForcedAppearance): Added.
572
573 2020-03-02  Devin Rousso  <drousso@apple.com>
574
575         Web Inspector: Items in the toolbar take up to much vertical space
576         https://bugs.webkit.org/show_bug.cgi?id=204627
577         <rdar://problem/59091905>
578
579         Reviewed by Timothy Hatcher.
580
581         Now that there is no toolbar area, there is nothing obstructing the ability for the window
582         to be moved around when dragging via the title bar area. As such, we can remove the unused
583         `InspectorFrontendHost` APIs.
584
585         * WebCoreSupport/WebInspectorClientIOS.mm:
586         (WebInspectorFrontendClient::startWindowDrag): Deleted.
587
588 2020-03-02  Rob Buis  <rbuis@igalia.com>
589
590         Add referrerpolicy attribute support for anchors
591         https://bugs.webkit.org/show_bug.cgi?id=208424
592
593         Reviewed by Darin Adler.
594
595         Adjust to FrameLoadRequest API change.
596
597         * WebView/WebPDFViewPlaceholder.mm:
598         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
599
600 2020-02-27  Daniel Bates  <dabates@apple.com>
601
602         Change HitTestRequestType to an OptionSet
603         https://bugs.webkit.org/show_bug.cgi?id=208334
604
605         Reviewed by Wenson Hsieh.
606
607         * WebCoreSupport/WebFrameIOS.mm:
608         (-[WebFrame elementRectAtPoint:]):
609
610 2020-02-19  Daniel Bates  <dabates@apple.com>
611
612         [iOS][LegacyWebKit] Override EditorClient::shouldRevealCurrentSelectionAfterInsertion()
613         https://bugs.webkit.org/show_bug.cgi?id=207955
614         <rdar://problem/59602916>
615
616         Reviewed by Wenson Hsieh.
617
618         Adds a stub function for -shouldRevealCurrentSelectionAfterInsertion that returns YES,
619         to keep our current behavior.
620
621         * DefaultDelegates/WebDefaultUIKitDelegate.m:
622         (-[WebDefaultUIKitDelegate shouldRevealCurrentSelectionAfterInsertion]): Added.
623         * WebView/WebUIKitDelegate.h:
624
625 2020-02-07  Jon Lee  <jonlee@apple.com>
626
627         Web Inspector: Revert slim toolbar
628         https://bugs.webkit.org/show_bug.cgi?id=207422
629
630         Reviewed by Timothy Hatcher.
631
632         The slim toolbar needs a little more work before landing.
633
634         This patch reverts r255547, r255557, r255890, r255892, r255893, r255901, r255980.
635
636         * WebCoreSupport/WebInspectorClientIOS.mm:
637
638 2020-02-01  Devin Rousso  <drousso@apple.com>
639
640         Web Inspector: move the items in the toolbar into the tab bar to save vertical space
641         https://bugs.webkit.org/show_bug.cgi?id=204627
642
643         Reviewed by Timothy Hatcher.
644
645         Now that there is no toolbar area, there is nothing obstructing the ability for the window
646         to be moved around when dragging via the title bar area. As such, we can remove the unused
647         `InspectorFrontendHost` APIs.
648
649         * WebCoreSupport/WebInspectorClientIOS.mm:
650         (WebInspectorFrontendClient::startWindowDrag): Deleted.
651
652 2020-01-15  Tim Horton  <timothy_horton@apple.com>
653
654         WebKit should not expose a unprefixed CGRectValue category method on NSValue
655         https://bugs.webkit.org/show_bug.cgi?id=206297
656         <rdar://problem/58592554>
657
658         Reviewed by Wenson Hsieh.
659
660         * WebView/WebPDFViewPlaceholder.mm:
661         (-[NSValue CGRectValue]): Deleted.
662
663 2020-01-03  Chris Dumez  <cdumez@apple.com>
664
665         Add support for DragEvent
666         https://bugs.webkit.org/show_bug.cgi?id=205758
667
668         Reviewed by Darin Adler.
669
670         * WebView/WebPDFViewPlaceholder.mm:
671         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
672
673 2019-12-20  Brian Burg  <bburg@apple.com>
674
675         Web Inspector: convert some InspectorFrontendHost methods to getters
676         https://bugs.webkit.org/show_bug.cgi?id=205475
677
678         Reviewed by Devin Rousso.
679
680         * WebCoreSupport/WebInspectorClientIOS.mm:
681         (WebInspectorFrontendClient::localizedStringsURL const):
682         (WebInspectorFrontendClient::localizedStringsURL): Deleted.
683
684 2019-12-17  Tim Horton  <timothy_horton@apple.com>
685
686         macCatalyst: Cursor should update on mouse movement and style change
687         https://bugs.webkit.org/show_bug.cgi?id=205317
688         <rdar://problem/46793696>
689
690         Reviewed by Anders Carlsson.
691
692         * WebCoreSupport/WebChromeClientIOS.h:
693         Provide a stub implementation of cursor-related ChromeClient methods.
694
695 2019-12-14  David Kilzer  <ddkilzer@apple.com>
696
697         Add release assert for selectedIndex in WebKit::WebPopupMenu::show()
698         <https://webkit.org/b/205223>
699         <rdar://problem/57929078>
700
701         Reviewed by Wenson Hsieh.
702
703         * WebCoreSupport/PopupMenuIOS.h:
704         (PopupMenuIOS::show):
705         - Rename `index` parameter to `selectedIndex`.
706         * WebCoreSupport/PopupMenuIOS.mm:
707         (PopupMenuIOS::show):
708         - Rename `index` parameter to `selectedIndex`.
709         (PopupMenuIOS::disconnectClient):
710         - Drive-by fix to change 0 to nullptr.
711
712 2019-10-16  Chris Dumez  <cdumez@apple.com>
713
714         Rename PageCache to BackForwardCache
715         https://bugs.webkit.org/show_bug.cgi?id=203048
716
717         Reviewed by Alex Christensen.
718
719         Rename PageCache to BackForwardCache for clarity and consistency with the UIProcess's WebBackForwardCache.
720
721         * WebView/WebUIKitDelegate.h:
722
723 2019-10-09  Andy Estes  <aestes@apple.com>
724
725         [iOS] Remove redundant uses of USE(UIKIT_EDITING)
726         https://bugs.webkit.org/show_bug.cgi?id=202717
727
728         Reviewed by Anders Carlsson.
729
730         * WebCoreSupport/WebVisiblePosition.mm:
731         (-[DOMNode startPosition]):
732         (-[DOMNode endPosition]):
733
734 2019-08-23  Chris Dumez  <cdumez@apple.com>
735
736         [geolocation] Rename interfaces and remove [NoInterfaceObject]
737         https://bugs.webkit.org/show_bug.cgi?id=200885
738
739         Reviewed by Alex Christensen.
740
741         * Misc/WebGeolocationCoreLocationProvider.h:
742         * Misc/WebGeolocationCoreLocationProvider.mm:
743         (-[WebGeolocationCoreLocationProvider sendLocation:]):
744         * Misc/WebGeolocationProviderIOS.mm:
745         (-[_WebCoreLocationUpdateThreadingProxy positionChanged:]):
746
747 2019-08-18  Yusuke Suzuki  <ysuzuki@apple.com>
748
749         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part
750         https://bugs.webkit.org/show_bug.cgi?id=200620
751
752         Reviewed by Geoffrey Garen.
753
754         * WebCoreSupport/WebFixedPositionContent.mm:
755         (-[WebFixedPositionContent setViewportConstrainedLayers:stickyContainerMap:]):
756
757 2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
758
759         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
760         https://bugs.webkit.org/show_bug.cgi?id=200620
761
762         Reviewed by Geoffrey Garen.
763
764         * WebCoreSupport/WebChromeClientIOS.h:
765         * WebCoreSupport/WebFixedPositionContent.mm:
766
767 2019-07-29  Zalan Bujtas  <zalan@apple.com>
768
769         [ContentChangeObserver] didFinishContentChangeObserving should include the type of content change.
770         https://bugs.webkit.org/show_bug.cgi?id=200247
771         <rdar://problem/53681149>
772
773         Reviewed by Simon Fraser.
774
775         * WebCoreSupport/WebChromeClientIOS.h:
776         * WebCoreSupport/WebChromeClientIOS.mm:
777         (WebChromeClientIOS::didFinishContentChangeObserving):
778
779 2019-07-29  Zalan Bujtas  <zalan@apple.com>
780
781         [ContentChangeObserver] ChromeClient::observedContentChange() name is misleading
782         https://bugs.webkit.org/show_bug.cgi?id=200238
783         <rdar://problem/53677038>
784
785         Reviewed by Simon Fraser.
786
787         * WebCoreSupport/WebChromeClientIOS.h:
788         * WebCoreSupport/WebChromeClientIOS.mm:
789         (WebChromeClientIOS::didFinishContentChangeObserving):
790         (WebChromeClientIOS::observedContentChange): Deleted.
791
792 2019-07-02  Devin Rousso  <drousso@apple.com>
793
794         Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side
795         https://bugs.webkit.org/show_bug.cgi?id=198956
796
797         Reviewed by Matt Baker.
798
799         * WebCoreSupport/WebInspectorClientIOS.mm:
800         (WebInspectorFrontendClient::resetWindowState): Added.
801
802 2019-06-27  Beth Dakin  <bdakin@apple.com>
803
804         Upstream use of MACCATALYST
805         https://bugs.webkit.org/show_bug.cgi?id=199245
806         rdar://problem/51687723
807
808         Reviewed by Tim Horton.
809
810         * Misc/WebGeolocationCoreLocationProvider.mm:
811         (-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):
812
813 2019-06-16  Darin Adler  <darin@apple.com>
814
815         Rename AtomicString to AtomString
816         https://bugs.webkit.org/show_bug.cgi?id=195276
817
818         Reviewed by Michael Catanzaro.
819
820         * many files: Let do-webcore-rename do the renaming.
821
822 2019-04-17  Brady Eidson  <beidson@apple.com>
823
824         Link clicks in PDFs shouldn't send referrer headers.
825         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
826
827         Reviewed by Tim Horton.
828
829         * WebView/WebPDFViewPlaceholder.mm:
830         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
831
832 2019-04-10  Devin Rousso  <drousso@apple.com>
833
834         Web Inspector: save sheet should be anchored underneath the tab bar when detached
835         https://bugs.webkit.org/show_bug.cgi?id=196722
836         <rdar://problem/49613280>
837
838         Reviewed by Timothy Hatcher.
839
840         * WebCoreSupport/WebInspectorClientIOS.mm:
841         (WebInspectorFrontendClient::setSheetRect): Added.
842
843 2019-03-03  Zalan Bujtas  <zalan@apple.com>
844
845         [ContentChangeObserver] Content observation should be limited to the current document.
846         https://bugs.webkit.org/show_bug.cgi?id=195256
847         <rdar://problem/48544402>
848
849         Reviewed by Simon Fraser.
850
851         * WebCoreSupport/WebChromeClientIOS.mm:
852         (WebChromeClientIOS::observedContentChange):
853
854 2019-02-26  Zalan Bujtas  <zalan@apple.com>
855
856         [ContentChangeObserver] clearContentChangeObservers should be internal to ContentChangeObserver class
857         https://bugs.webkit.org/show_bug.cgi?id=195066
858         <rdar://problem/48411682>
859
860         Reviewed by Tim Horton.
861
862         * WebCoreSupport/WebChromeClientIOS.h:
863         * WebCoreSupport/WebChromeClientIOS.mm:
864         (WebChromeClientIOS::clearContentChangeObservers): Deleted.
865
866 2019-02-24  Zalan Bujtas  <zalan@apple.com>
867
868         Introduce ContentChangeObserver class
869         https://bugs.webkit.org/show_bug.cgi?id=194977
870         <rdar://problem/48338115>
871
872         Reviewed by Simon Fraser.
873
874         * WebCoreSupport/WebChromeClientIOS.mm:
875         (WebChromeClientIOS::observedContentChange):
876         (WebChromeClientIOS::clearContentChangeObservers):
877
878 2019-02-17  David Kilzer  <ddkilzer@apple.com>
879
880         Unreviewed, rolling out r241620.
881
882         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
883         (Requested by ddkilzer on #webkit.)
884
885         Reverted changeset:
886
887         "[WTF] Add environment variable helpers"
888         https://bugs.webkit.org/show_bug.cgi?id=192405
889         https://trac.webkit.org/changeset/241620
890
891 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
892
893         [WTF] Add environment variable helpers
894         https://bugs.webkit.org/show_bug.cgi?id=192405
895
896         Reviewed by Michael Catanzaro.
897
898         * Misc/WebUIKitSupport.mm:
899         (WebKitPlatformSystemRootDirectory):
900         Utilize WTF::Environment where possible.
901
902 2019-02-15  Commit Queue  <commit-queue@webkit.org>
903
904         Unreviewed, rolling out r241559 and r241566.
905         https://bugs.webkit.org/show_bug.cgi?id=194710
906
907         Causes layout test crashes under GuardMalloc (Requested by
908         ryanhaddad on #webkit).
909
910         Reverted changesets:
911
912         "[WTF] Add environment variable helpers"
913         https://bugs.webkit.org/show_bug.cgi?id=192405
914         https://trac.webkit.org/changeset/241559
915
916         "Unreviewed build fix for WinCairo Debug after r241559."
917         https://trac.webkit.org/changeset/241566
918
919 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
920
921         [WTF] Add environment variable helpers
922         https://bugs.webkit.org/show_bug.cgi?id=192405
923
924         Reviewed by Michael Catanzaro.
925
926         * Misc/WebUIKitSupport.mm:
927         (WebKitPlatformSystemRootDirectory):
928         Utilize WTF::Environment where possible.
929
930 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
931
932         Clean up USE(WEB_THREAD)
933         https://bugs.webkit.org/show_bug.cgi?id=193698
934
935         Rubber-stamped by Tim Horton.
936
937         * Misc/WebGeolocationProviderIOS.mm:
938         (-[_WebCoreLocationUpdateThreadingProxy geolocationAuthorizationGranted]):
939         (-[_WebCoreLocationUpdateThreadingProxy geolocationAuthorizationDenied]):
940         (-[_WebCoreLocationUpdateThreadingProxy positionChanged:]):
941         (-[_WebCoreLocationUpdateThreadingProxy errorOccurred:]):
942         (-[_WebCoreLocationUpdateThreadingProxy resetGeolocation]):
943         * WebCoreSupport/WebFixedPositionContent.mm:
944         (-[WebFixedPositionContent didFinishScrollingOrZooming]):
945
946 2019-01-22  Daniel Bates  <dabates@apple.com>
947
948         [iOS] Interpret text key commands on keydown and app key commands on keypress
949         https://bugs.webkit.org/show_bug.cgi?id=192897
950         <rdar://problem/46857378>
951
952         Reviewed by Brent Fulgham.
953
954         Add stubs for SPI.
955
956         * DefaultDelegates/WebDefaultUIKitDelegate.m:
957         (-[WebDefaultUIKitDelegate handleKeyTextCommandForCurrentEvent]): Added.
958         (-[WebDefaultUIKitDelegate handleKeyAppCommandForCurrentEvent]): Added.
959         (-[WebDefaultUIKitDelegate handleKeyCommandForCurrentEvent]): Deleted.
960         * WebView/WebUIKitDelegate.h:
961
962 2019-01-04  Simon Fraser  <simon.fraser@apple.com>
963
964         Factor legacy WK1 code for fixed and scrolling layers into their own helper class
965         https://bugs.webkit.org/show_bug.cgi?id=193165
966
967         Reviewed by Frédéric Wang.
968
969         Make the stickyContainerMap argument const. We WTFMove() values out of the first
970         argument, so it can't be const.
971
972         * WebCoreSupport/WebChromeClientIOS.h:
973         * WebCoreSupport/WebChromeClientIOS.mm:
974         (WebChromeClientIOS::updateViewportConstrainedLayers):
975         * WebCoreSupport/WebFixedPositionContent.mm:
976         (-[WebFixedPositionContent setViewportConstrainedLayers:stickyContainerMap:]):
977         * WebCoreSupport/WebFixedPositionContentInternal.h:
978
979 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
980
981         Use Ref<> as much as possible
982         https://bugs.webkit.org/show_bug.cgi?id=192808
983
984         Reviewed by Alex Christensen.
985
986         * WebCoreSupport/SearchPopupMenuIOS.cpp:
987         (SearchPopupMenuIOS::SearchPopupMenuIOS):
988         (SearchPopupMenuIOS::popupMenu):
989         * WebCoreSupport/SearchPopupMenuIOS.h:
990         * WebCoreSupport/WebVisiblePosition.mm:
991         (-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]):
992         (-[WebVisiblePosition enclosingRangeWithCorrectionIndicator]):
993         * WebView/WebPDFViewPlaceholder.mm:
994         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
995
996 2018-12-17  Zalan Bujtas  <zalan@apple.com>
997
998         Unreviewed build fix.
999
1000         * WebCoreSupport/WebVisiblePosition.mm:
1001         (-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]):
1002         (-[WebVisiblePosition enclosingRangeWithCorrectionIndicator]):
1003
1004 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1005
1006         Turn WritingDirection into an enum class
1007         https://bugs.webkit.org/show_bug.cgi?id=192401
1008         Work towards <rdar://problem/42075638>
1009
1010         Reviewed by Dan Bernstein.
1011
1012         Change WritingDirection from an enum to an enum class. No change in behavior.
1013
1014         * WebCoreSupport/WebFrameIOS.mm:
1015         (-[WebFrame selectionBaseWritingDirection]):
1016         (-[WebFrame setBaseWritingDirection:]):
1017
1018 2018-12-03  Daniel Bates  <dabates@apple.com>
1019
1020         [iOS] Do not handle key events that are key commands
1021         https://bugs.webkit.org/show_bug.cgi?id=191608
1022         <rdar://problem/46046013>
1023
1024         Reviewed by Ryosuke Niwa.
1025
1026         Add default implementation of -handleKeyCommandForCurrentEvent that returns NO - the current
1027         event was not handled as a key command.
1028
1029         * DefaultDelegates/WebDefaultUIKitDelegate.m:
1030         (-[WebDefaultUIKitDelegate handleKeyCommandForCurrentEvent]):
1031         * WebView/WebUIKitDelegate.h:
1032
1033 2018-11-29  Zalan Bujtas  <zalan@apple.com>
1034
1035         Rename *ObservedContentModifier(s) to *ObservedDOMTimer(s)
1036         https://bugs.webkit.org/show_bug.cgi?id=192168
1037
1038         Reviewed by Simon Fraser.
1039
1040         There's only one type of content modifier (DOMTimer).
1041
1042         * WebCoreSupport/WebChromeClientIOS.mm:
1043         (WebChromeClientIOS::clearContentChangeObservers):
1044
1045 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1046
1047         Web Inspector: "Reload Web Inspector" button no longer partially works
1048         https://bugs.webkit.org/show_bug.cgi?id=191773
1049         <rdar://problem/46139932>
1050
1051         Reviewed by Devin Rousso.
1052
1053         * WebCoreSupport/WebInspectorClientIOS.mm:
1054         (WebInspectorFrontendClient::reopen):
1055
1056 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1057
1058         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1059         https://bugs.webkit.org/show_bug.cgi?id=190729
1060
1061         Reviewed by Tim Horton.
1062
1063         * DefaultDelegates/WebDefaultFormDelegate.m:
1064         * DefaultDelegates/WebDefaultFrameLoadDelegate.m:
1065         * DefaultDelegates/WebDefaultResourceLoadDelegate.m:
1066         * DefaultDelegates/WebDefaultUIKitDelegate.m:
1067         * Misc/MemoryMeasure.mm:
1068         * Misc/WebGeolocationCoreLocationProvider.mm:
1069         * Misc/WebGeolocationProviderIOS.mm:
1070         * Misc/WebNSStringExtrasIOS.m:
1071         * Misc/WebUIKitSupport.mm:
1072         (WebKitPlatformSystemRootDirectory):
1073         * WebCoreSupport/PopupMenuIOS.mm:
1074         * WebCoreSupport/SearchPopupMenuIOS.cpp:
1075         * WebCoreSupport/WebChromeClientIOS.h:
1076         * WebCoreSupport/WebChromeClientIOS.mm:
1077         * WebCoreSupport/WebFixedPositionContent.mm:
1078         * WebCoreSupport/WebFrameIOS.mm:
1079         * WebCoreSupport/WebGeolocation.mm:
1080         * WebCoreSupport/WebInspectorClientIOS.mm:
1081         * WebCoreSupport/WebMIMETypeRegistry.mm:
1082         * WebCoreSupport/WebSelectionRect.m:
1083         * WebCoreSupport/WebVisiblePosition.mm:
1084         * WebView/WebFrameViewWAKCompatibility.m:
1085         * WebView/WebPDFViewIOS.mm:
1086         * WebView/WebPDFViewPlaceholder.mm:
1087         * WebView/WebPlainWhiteView.h:
1088         * WebView/WebPlainWhiteView.mm:
1089
1090 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1091
1092         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
1093         https://bugs.webkit.org/show_bug.cgi?id=190429
1094
1095         Reviewed by Saam Barati.
1096
1097         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
1098
1099         * WebView/WebPDFViewIOS.mm:
1100         (-[WebPDFView finishedLoadingWithDataSource:]):
1101         * WebView/WebPDFViewPlaceholder.mm:
1102         (-[WebPDFViewPlaceholder _evaluateJSForDocument:]):
1103
1104 2018-10-02  Alex Christensen  <achristensen@webkit.org>
1105
1106         Remove unused linked-on-or-before-iOS5 check
1107         https://bugs.webkit.org/show_bug.cgi?id=190164
1108
1109         Reviewed by Michael Saboff.
1110
1111         * Misc/WebUIKitSupport.mm:
1112         (WebKitInitialize):
1113         (linkedOnOrAfterIOS5): Deleted.
1114
1115 2018-09-17  Darin Adler  <darin@apple.com>
1116
1117         Use OpaqueJSString rather than JSRetainPtr inside WebKit
1118         https://bugs.webkit.org/show_bug.cgi?id=189652
1119
1120         Reviewed by Saam Barati.
1121
1122         * WebView/WebPDFViewIOS.mm:
1123         (-[WebPDFView finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
1124         * WebView/WebPDFViewPlaceholder.mm:
1125         (-[WebPDFViewPlaceholder _evaluateJSForDocument:]): Ditto.
1126
1127 2018-08-29  Olivia Barnett  <obarnett@apple.com>
1128
1129         Implement the Web Share API
1130         https://bugs.webkit.org/show_bug.cgi?id=171100
1131         <rdar://problem/31751734>
1132
1133         Reviewed by Tim Horton.
1134
1135         * WebCoreSupport/WebChromeClientIOS.h:
1136         * WebCoreSupport/WebChromeClientIOS.mm:
1137         (WebChromeClientIOS::showShareSheet):
1138         Empty declaration of showShareSheet.
1139
1140 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
1141
1142         Pass in IsComposed flag to Event constructors
1143         https://bugs.webkit.org/show_bug.cgi?id=188720
1144         <rdar://problem/43580387>
1145
1146         Reviewed by Simon Fraser.
1147
1148         * WebView/WebPDFViewPlaceholder.mm:
1149         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]): A trusted click event is composed regardless
1150         of whether it's simulated or not.
1151
1152 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
1153
1154         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
1155         https://bugs.webkit.org/show_bug.cgi?id=188777
1156
1157         Reviewed by Simon Fraser.
1158
1159         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
1160         being "true" before the code change.
1161
1162         * WebView/WebPDFViewPlaceholder.mm:
1163         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
1164
1165 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
1166
1167         Replace canBubble and cancelable booleans in Event by enum classes
1168         https://bugs.webkit.org/show_bug.cgi?id=188692
1169
1170         Reviewed by Alex Christensen.
1171
1172         * WebView/WebPDFViewPlaceholder.mm:
1173         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
1174
1175 2018-08-13  Alex Christensen  <achristensen@webkit.org>
1176
1177         Use a 1-byte enum class for TextDirection
1178         https://bugs.webkit.org/show_bug.cgi?id=188350
1179
1180         Reviewed by Simon Fraser.
1181
1182         * WebCoreSupport/WebFrameIOS.mm:
1183         (-[WebFrame selectionRectsForCoreRange:]):
1184         * WebCoreSupport/WebVisiblePosition.mm:
1185         (-[WebVisiblePosition textDirection]):
1186         (-[WebVisiblePosition directionIsDownstream:]):
1187         * WebView/WebPDFViewIOS.mm:
1188         (-[WebPDFView _checkPDFTitle]):
1189
1190 2018-07-04  Tim Horton  <timothy_horton@apple.com>
1191
1192         Introduce PLATFORM(IOSMAC)
1193         https://bugs.webkit.org/show_bug.cgi?id=187315
1194
1195         Reviewed by Dan Bernstein.
1196
1197         * Misc/WebGeolocationCoreLocationProvider.mm:
1198         (-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):
1199
1200 2018-05-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1201
1202         [Extra zoom mode] Google search results are excessively zoomed in
1203         https://bugs.webkit.org/show_bug.cgi?id=185347
1204         <rdar://problem/39999778>
1205
1206         Reviewed by Tim Horton.
1207
1208         Adds a WebKitLegacy method stub for disabled adaptation plumbing.
1209
1210         * WebCoreSupport/WebChromeClientIOS.h:
1211         * WebCoreSupport/WebChromeClientIOS.mm:
1212         (WebChromeClientIOS::dispatchDisabledAdaptationsDidChange const):
1213
1214 2018-05-02  Eric Carlson  <eric.carlson@apple.com>
1215
1216         [iOS] Provide audio route information when invoking AirPlay picker
1217         https://bugs.webkit.org/show_bug.cgi?id=185199
1218         <rdar://problem/39853103>
1219
1220         Reviewed by Jer Noble.
1221
1222         * WebCoreSupport/WebChromeClientIOS.h:
1223         * WebCoreSupport/WebChromeClientIOS.mm:
1224         (WebChromeClientIOS::showPlaybackTargetPicker): Pass route sharing policy and routing context UID.
1225
1226 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1227
1228         [WTF] Remove StaticLock
1229         https://bugs.webkit.org/show_bug.cgi?id=184332
1230
1231         Reviewed by Mark Lam.
1232
1233         * WebCoreSupport/WebFixedPositionContent.mm:
1234
1235 2018-03-28  Zalan Bujtas  <zalan@apple.com>
1236
1237         Make it possible to override the screen size
1238         https://bugs.webkit.org/show_bug.cgi?id=184111
1239         <rdar://problem/38972181>
1240
1241         Reviewed by Tim Horton.
1242
1243         * WebCoreSupport/WebChromeClientIOS.h:
1244         * WebCoreSupport/WebChromeClientIOS.mm:
1245         (WebChromeClientIOS::overrideScreenSize const):
1246
1247 2018-03-25  Tim Horton  <timothy_horton@apple.com>
1248
1249         Disable geolocation prompt in minimal simulator mode
1250         https://bugs.webkit.org/show_bug.cgi?id=183991
1251         <rdar://problem/38845774>
1252
1253         Reviewed by Dan Bernstein.
1254
1255         * Misc/WebGeolocationCoreLocationProvider.mm:
1256         (-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):
1257         * Misc/WebGeolocationProviderIOS.mm:
1258         (-[WebGeolocationProviderIOS registerWebView:]):
1259         (-[WebGeolocationProviderIOS initializeGeolocationForWebView:listener:]):
1260         Also clean up some unnecessary nested #ifs.
1261
1262 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
1263
1264         Remove WebCore/ForwardingHeaders directory
1265         https://bugs.webkit.org/show_bug.cgi?id=182347
1266
1267         Reviewed by Keith Miller.
1268
1269         * Misc/WebUIKitSupport.mm:
1270
1271 2017-12-07  Yusuke Suzuki  <utatane.tea@gmail.com>
1272
1273         Use StaticLock instead of NeverDestroyed<Lock>
1274         https://bugs.webkit.org/show_bug.cgi?id=180507
1275
1276         Reviewed by Saam Barati.
1277
1278         * WebCoreSupport/WebFixedPositionContent.mm:
1279         (-[WebFixedPositionContent scrollOrZoomChanged:]):
1280         (-[WebFixedPositionContent overflowScrollPositionForLayer:changedTo:]):
1281         (-[WebFixedPositionContent setViewportConstrainedLayers:stickyContainerMap:]):
1282         (-[WebFixedPositionContent hasFixedOrStickyPositionLayers]):
1283         (WebFixedPositionContentDataLock): Deleted.
1284
1285 2017-11-11  Megan Gardner  <megan_gardner@apple.com>
1286
1287         Fix a FIXMEs in WebFrameIOS
1288         https://bugs.webkit.org/show_bug.cgi?id=179510
1289
1290         Reviewed by Darin Adler.
1291
1292         Removed a function that does nothing and is not needed or used anywhere, linked to a radar that is in verify.
1293         This is just some easy cleanup I found while investigating other things.
1294
1295         * WebCoreSupport/WebFrameIOS.h:
1296         * WebCoreSupport/WebFrameIOS.mm:
1297         (-[WebFrame imageForNode:allowDownsampling:drawContentBehindTransparentNodes:]): Deleted.
1298
1299 2017-10-11  Sam Weinig  <sam@webkit.org>
1300
1301         Remove out-parameter variants of copyToVector
1302         https://bugs.webkit.org/show_bug.cgi?id=178155
1303
1304         Reviewed by Tim Horton.
1305
1306         * Misc/WebGeolocationProviderIOS.mm:
1307         (-[WebGeolocationProviderIOS _handlePendingInitialPosition:]):
1308         (-[WebGeolocationProviderIOS positionChanged:]):
1309         (-[WebGeolocationProviderIOS errorOccurred:]):
1310         (-[WebGeolocationProviderIOS resetGeolocation]):
1311
1312             Replace out-parameter based copyToVector, with one that returns a Vector.
1313
1314 2017-10-11  Chris Dumez  <cdumez@apple.com>
1315
1316         Modernize Geolocation code
1317         https://bugs.webkit.org/show_bug.cgi?id=178148
1318
1319         Reviewed by Ryosuke Niwa.
1320
1321         * Misc/WebGeolocationCoreLocationProvider.h:
1322         * Misc/WebGeolocationCoreLocationProvider.mm:
1323         (-[WebGeolocationCoreLocationProvider sendLocation:]):
1324         * Misc/WebGeolocationProviderIOS.mm:
1325         (-[_WebCoreLocationUpdateThreadingProxy positionChanged:]):
1326
1327 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1328
1329         Remove WebCoreSystemInterface
1330         https://bugs.webkit.org/show_bug.cgi?id=177916
1331
1332         Reviewed by Antti Koivisto.
1333
1334         * Misc/WebUIKitSupport.mm:
1335
1336 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1337
1338         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
1339         https://bugs.webkit.org/show_bug.cgi?id=177912
1340
1341         Reviewed by Saam Barati.
1342
1343         * Misc/WebUIKitSupport.mm:
1344         * WebCoreSupport/WebChromeClientIOS.mm:
1345
1346 2017-09-22  Chris Dumez  <cdumez@apple.com>
1347
1348         Use high resolution timestamp for event time
1349         https://bugs.webkit.org/show_bug.cgi?id=154246
1350         <rdar://problem/34333304>
1351
1352         Reviewed by Ryosuke Niwa.
1353
1354         Use WallTime / MonotonicTime instead of double type for clarity.
1355
1356         * WebView/WebPDFViewPlaceholder.mm:
1357         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
1358
1359 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1360
1361         [PAL] Move spi/cocoa and spi/cg directories into PAL
1362         https://bugs.webkit.org/show_bug.cgi?id=175175
1363
1364         Reviewed by Myles C. Maxfield.
1365
1366         * Misc/WebNSStringExtrasIOS.m:
1367         * WebCoreSupport/WebFixedPositionContent.mm:
1368
1369 2017-07-17  Daniel Bates  <dabates@apple.com>
1370
1371         Cleanup: Use OptionSet to represent marker types
1372         https://bugs.webkit.org/show_bug.cgi?id=174594
1373
1374         Reviewed by Darin Adler.
1375
1376         Remove class DocumentMarker::MarkerTypes that duplicates most of functionality of OptionSet
1377         and use OptionSet directly to represent a set of marker types.
1378
1379         No functionality changed. So, no new tests.
1380
1381         * WebCoreSupport/WebVisiblePosition.mm:
1382         (-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]): Update code as needed.
1383         (-[WebVisiblePosition enclosingRangeWithCorrectionIndicator]): Ditto.
1384
1385 2017-07-12  Daniel Bates  <dabates@apple.com>
1386
1387         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
1388         https://bugs.webkit.org/show_bug.cgi?id=174427
1389
1390         Rubber-stamped by Brady Eidson.
1391
1392         * WebView/WebPDFViewPlaceholder.mm:
1393         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
1394
1395 2017-07-09  Brady Eidson  <beidson@apple.com>
1396
1397         Remove some obsolete WebKitVersionChecks.
1398         https://bugs.webkit.org/show_bug.cgi?id=174294
1399
1400         Reviewed by Dan Bernstein.
1401
1402         * WebView/WebPDFViewIOS.mm:
1403         (-[WebPDFView drawPage:]):
1404
1405 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
1406
1407         [WTF] Move SoftLinking.h into WTF
1408         https://bugs.webkit.org/show_bug.cgi?id=174000
1409
1410         Reviewed by Alex Christensen.
1411
1412         * Misc/WebGeolocationCoreLocationProvider.mm:
1413         * WebView/WebPDFViewPlaceholder.mm:
1414
1415 2017-07-05  Brady Eidson  <beidson@apple.com>
1416
1417         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
1418         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
1419
1420         Reviewed by Alex Christensen.
1421
1422         Adopt to the new constructor for FrameLoadRequest.
1423
1424         * WebView/WebPDFViewPlaceholder.mm:
1425         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
1426
1427 2017-07-01  Tim Horton  <timothy_horton@apple.com>
1428
1429         Expose viewport-fit value to UIKit via viewport arguments dictionary
1430         https://bugs.webkit.org/show_bug.cgi?id=174071
1431         <rdar://problem/33096620>
1432
1433         Reviewed by Wenson Hsieh.
1434
1435         * WebCoreSupport/WebChromeClientIOS.mm:
1436         (nameForViewportFitValue):
1437         (dictionaryForViewportArguments):
1438         Make use of the named constants we already have for these; the code
1439         that reads this dictionary uses them, so we might as well!
1440
1441         Add viewport-fit -> { auto, contain, cover } to the dictionary.
1442
1443         * WebKit.iOS.exp:
1444
1445 2017-06-30  Daniel Bates  <dabates@apple.com>
1446
1447         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
1448         https://bugs.webkit.org/show_bug.cgi?id=165160
1449         <rdar://problem/29451999>
1450
1451         Reviewed by Brady Eidson.
1452
1453         Pass the document that is requesting the load to the loader.
1454
1455         * WebView/WebPDFViewPlaceholder.mm:
1456         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
1457
1458 2017-06-22  Daniel Bates  <dabates@apple.com>
1459
1460         Make FrameLoadRequest a move-only type
1461         https://bugs.webkit.org/show_bug.cgi?id=173682
1462
1463         Reviewed by Alex Christensen and Darin Adler.
1464
1465         A FrameLoadRequest groups together the information to perform a load into a single object
1466         that is more manageable to pass around than its constituent parts. Code that receives a
1467         FrameLoadRequest is expected to extract out the information it needs to complete its task.
1468         And it does not make sense to re-use the same FrameLoadRequest object for more than one
1469         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
1470
1471         * WebView/WebPDFViewPlaceholder.mm:
1472         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
1473
1474 2017-06-21  Daniel Bates  <dabates@apple.com>
1475
1476         Cleanup FrameLoadRequest
1477         https://bugs.webkit.org/show_bug.cgi?id=173564
1478         <rdar://problem/32903570>
1479
1480         Reviewed by Brent Fulgham.
1481
1482         Move FrameLoadRequest instantiation into a local variable and use C++11 brace initialization
1483         syntax to make it easier to identify the arguments passed to FrameLoader::loadFrameRequest().
1484
1485         * WebView/WebPDFViewPlaceholder.mm:
1486         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
1487
1488 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1489
1490         [iOS DnD] Add a hook to perform two-step drops in editable content
1491         https://bugs.webkit.org/show_bug.cgi?id=172992
1492         <rdar://problem/32590174>
1493
1494         Reviewed by Tim Horton.
1495
1496         Add an empty implementation of performTwoStepDrop for WebDefaultUIKitDelegate. See WebCore ChangeLogs.
1497
1498         * DefaultDelegates/WebDefaultUIKitDelegate.m:
1499         (-[WebDefaultUIKitDelegate performTwoStepDrop:atDestination:isMove:]):
1500         * WebView/WebUIKitDelegate.h:
1501
1502 2017-06-07  Zalan Bujtas  <zalan@apple.com>
1503
1504         [iOS WK1 WebThread] Do not call out to the main thread for device orientation.
1505         https://bugs.webkit.org/show_bug.cgi?id=173044
1506         <rdar://problem/32449338>
1507
1508         Reviewed by Tim Horton.
1509
1510         On iOS WK1 we could end up with an inconsistent state, where the web thread is inside
1511         the Document's constructor waiting on a delegate callback on the main thread
1512         while the main thread executes a pending task that assumes a valid Document.
1513         This patch ensures that we don't call out to the main thread from the Document's constructor.
1514  
1515         * WebCoreSupport/WebChromeClientIOS.mm:
1516         (WebChromeClientIOS::deviceOrientation): Caches deviceOrientation on the WebView so that we
1517         don't have to lift the WebThread lock. 
1518
1519 2017-05-12  Chris Dumez  <cdumez@apple.com>
1520
1521         Drop uses of PassRefPtr in WebKit/mac
1522         https://bugs.webkit.org/show_bug.cgi?id=172066
1523
1524         Reviewed by Sam Weinig.
1525
1526         Build fix.
1527
1528         * Misc/WebGeolocationProviderIOS.mm:
1529
1530 2017-05-01  Chris Dumez  <cdumez@apple.com>
1531
1532         Remove some usage of PassRefPtr in editing code
1533         https://bugs.webkit.org/show_bug.cgi?id=171490
1534
1535         Reviewed by Darin Adler.
1536
1537         * WebCoreSupport/WebFrameIOS.mm:
1538         (-[WebFrame previousUnperturbedDictationResultBoundaryFromPosition:]):
1539         (-[WebFrame nextUnperturbedDictationResultBoundaryFromPosition:]):
1540
1541 2017-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1542
1543         [WK2] Support Icon creation from file URLs on iOS
1544         https://bugs.webkit.org/show_bug.cgi?id=170809
1545         <rdar://problem/31286130>
1546
1547         Reviewed by Tim Horton.
1548
1549         Adjust for changes in the ChromeClient in WebCore.
1550
1551         * WebCoreSupport/WebChromeClientIOS.h:
1552         * WebCoreSupport/WebChromeClientIOS.mm:
1553         (WebChromeClientIOS::createIconForFiles):
1554
1555 2017-03-02  Sam Weinig  <sam@webkit.org>
1556
1557         Rename htmlediting.h/cpp to Editing.h/cpp
1558         https://bugs.webkit.org/show_bug.cgi?id=169103
1559
1560         Reviewed by Alex Christensen.
1561
1562         * WebCoreSupport/WebFrameIOS.mm:
1563         * WebCoreSupport/WebVisiblePosition.mm:
1564
1565 2017-02-23  Aakash Jain  <aakash_jain@apple.com>
1566
1567         Move instance member from WebFixedPositionContent to implementation file
1568         https://bugs.webkit.org/show_bug.cgi?id=168766
1569
1570         Reviewed by Tim Horton.
1571
1572         * WebCoreSupport/WebFixedPositionContent.h: Moving instance member to implementation file.
1573         * WebCoreSupport/WebFixedPositionContent.mm: Ditto.
1574
1575 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
1576
1577         Move instance members from WebPDFView to implementation file
1578         https://bugs.webkit.org/show_bug.cgi?id=168765
1579
1580         Reviewed by Tim Horton.
1581
1582         * WebView/WebPDFViewIOS.h: Moving instance members to implementation file.
1583         * WebView/WebPDFViewIOS.mm: Ditto.
1584
1585 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
1586
1587         Export m_isLoggingEnabled symbol from MemoryMeasure.h
1588         https://bugs.webkit.org/show_bug.cgi?id=168760
1589
1590         Reviewed by Alexey Proskuryakov.
1591
1592         * WebKit.iOS.exp: Exporting m_isLoggingEnabled symbol.
1593
1594 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
1595
1596         Move instance members from WebPDFViewPlaceholder.h to implementation file
1597         https://bugs.webkit.org/show_bug.cgi?id=168705
1598
1599         Reviewed by Tim Horton.
1600
1601         * WebView/WebPDFViewPlaceholder.h: Moving instance members to implementation file.
1602         * WebView/WebPDFViewPlaceholder.mm: Ditto.
1603
1604 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
1605
1606         Move instance members from WebSelectionRect.h to implementation file
1607         https://bugs.webkit.org/show_bug.cgi?id=168732
1608
1609         Reviewed by Tim Horton.
1610
1611         * WebCoreSupport/WebSelectionRect.h: Moving instance members to implementation file.
1612         * WebCoreSupport/WebSelectionRect.m: Ditto.
1613
1614 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
1615
1616         Move iOS specific symbols to WebKit.ios.exp
1617         https://bugs.webkit.org/show_bug.cgi?id=168726
1618
1619         Reviewed by Alexey Proskuryakov.
1620
1621         * WebKit.iOS.exp:
1622
1623 2017-02-21  Commit Queue  <commit-queue@webkit.org>
1624
1625         Unreviewed, rolling out r212768.
1626         https://bugs.webkit.org/show_bug.cgi?id=168698
1627
1628         Rolling out since this would break other projects. (Requested
1629         by aakashjain on #webkit).
1630
1631         Reverted changeset:
1632
1633         "[iOS] Remove old WebKit1 MemoryMeasure helper."
1634         https://bugs.webkit.org/show_bug.cgi?id=168675
1635         http://trac.webkit.org/changeset/212768
1636
1637 2017-02-21  Andreas Kling  <akling@apple.com>
1638
1639         [iOS] Remove old WebKit1 MemoryMeasure helper.
1640         <https://webkit.org/b/168675>
1641
1642         Reviewed by Sam Weinig.
1643
1644         Remove the MemoryMeasure logging helper from the WebKit1 days. It was using an old way
1645         of measuring memory, and we were only using it in a single place anyway.
1646
1647         * Misc/MemoryMeasure.h: Removed.
1648         * Misc/MemoryMeasure.mm: Removed.
1649         * WebKit.iOS.exp:
1650
1651 2017-02-21  Andreas Kling  <akling@apple.com>
1652
1653         [iOS] WebKit1 should use shared memory pressure handler code.
1654         <https://webkit.org/b/168653>
1655
1656         Reviewed by Antti Koivisto.
1657
1658         * Misc/WebUIKitSupport.mm:
1659         (WebKitInitialize): Don't unconditionally install a memory warning handler just
1660         because the framework is loaded.
1661
1662 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
1663
1664         List of WebCore symbols to re-export from WebKitLegacy should be built automatically
1665         https://bugs.webkit.org/show_bug.cgi?id=168342
1666         rdar://problem/26182266
1667
1668         Reviewed by Tim Horton.
1669
1670         * WebKit.iOS.exp: Removed manually added symbols.
1671
1672 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
1673
1674         Stop exporting WebPluginController from WebKit
1675         https://bugs.webkit.org/show_bug.cgi?id=168603
1676
1677         Reviewed by Alexey Proskuryakov.
1678
1679         * WebKit.iOS.exp:
1680
1681 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
1682
1683         WebKitLegacy doesn't re-export various symbols from WebCore required by clients
1684         https://bugs.webkit.org/show_bug.cgi?id=168158
1685         <rdar://problem/24527933>
1686
1687         Reviewed by Dan Bernstein.
1688
1689         * WebKit.iOS.exp: Exporting various symbols which are required by clients. This 
1690         would enable clients to stop linking against WebCore and instead link against WebKit.
1691
1692 2017-02-02  Yongjun Zhang  <yongjun_zhang@apple.com>
1693
1694         In iOS, we should take background assertion when accessing localstorage databases.
1695         https://bugs.webkit.org/show_bug.cgi?id=165478
1696
1697         Move application background task handling code from WebKit to WebCore.
1698
1699         Reviewed by Brady Eidson.
1700
1701         * Misc/WebUIKitSupport.h: Remove several methods that only used internally for background
1702             task handling. They are not needed in WebKit any more since background task handling
1703             is moved to WebCore and wrapped in WebBackgroundTaskController class.
1704         * Misc/WebUIKitSupport.mm:
1705         (WebKitSetInvalidWebBackgroundTaskIdentifier): Instead of storing the value in a static global
1706             variable, save it in WebBackgroundTaskController.
1707         (WebKitSetStartBackgroundTaskBlock): Ditto.
1708         (WebKitSetEndBackgroundTaskBlock): Ditto.
1709
1710 2017-01-25  Aakash Jain  <aakash_jain@apple.com>
1711
1712         LoadWebLocalizedStrings method should be moved in correct file
1713         https://bugs.webkit.org/show_bug.cgi?id=167393
1714
1715         Reviewed by Alexey Proskuryakov.
1716
1717         * Misc/WebUIKitSupport.mm:
1718         (LoadWebLocalizedStringsTimerCallback): Moved from WebLocalizableStrings.mm
1719         (LoadWebLocalizedStrings): Moved from WebLocalizableStrings.mm
1720
1721 2017-01-21  Darin Adler  <darin@apple.com>
1722
1723         Remove PassRefPtr from "page" directory of WebCore, also deploy references
1724         https://bugs.webkit.org/show_bug.cgi?id=167224
1725
1726         Reviewed by Chris Dumez.
1727
1728         * WebCoreSupport/WebChromeClientIOS.h: Update for changes to ChromeClient.
1729         * WebCoreSupport/WebChromeClientIOS.mm:
1730         (WebChromeClientIOS::runJavaScriptAlert): Ditto.
1731         (WebChromeClientIOS::runJavaScriptConfirm): Ditto.
1732         (WebChromeClientIOS::runJavaScriptPrompt): Ditto.
1733         (WebChromeClientIOS::setNeedsScrollNotifications): Ditto.
1734         (WebChromeClientIOS::observedContentChange): Ditto.
1735         (WebChromeClientIOS::clearContentChangeObservers): Ditto.
1736         (WebChromeClientIOS::notifyRevealedSelectionByScrollingFrame): Ditto.
1737         (WebChromeClientIOS::elementDidFocus): Ditto.
1738         (WebChromeClientIOS::elementDidBlur): Ditto.
1739         (WebChromeClientIOS::createPopupMenu): Ditto.
1740         (WebChromeClientIOS::createSearchPopupMenu): Ditto.
1741         (WebChromeClientIOS::attachRootGraphicsLayer): Ditto.
1742
1743 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
1744
1745         Remove the unused -[WebFixedPositionContent minimumOffsetFromFixedPositionLayersToAnchorEdge:ofRect:inLayer:]
1746         https://bugs.webkit.org/show_bug.cgi?id=167273
1747
1748         Reviewed by Alex Christensen.
1749
1750         This function was added for an experiment, but is no longer used, so remove it.
1751
1752         * WebCoreSupport/WebFixedPositionContent.h:
1753         * WebCoreSupport/WebFixedPositionContent.mm:
1754         (anchorEdgeFlagsForAnchorEdge): Deleted.
1755         (-[WebFixedPositionContent minimumOffsetFromFixedPositionLayersToAnchorEdge:ofRect:inLayer:]): Deleted.
1756
1757 2017-01-15  Darin Adler  <darin@apple.com>
1758
1759         Remove PassRefPtr from "loader" directory of WebCore
1760         https://bugs.webkit.org/show_bug.cgi?id=167055
1761
1762         Reviewed by Alex Christensen.
1763
1764         * WebCoreSupport/WebChromeClientIOS.h: Updated runOpenPanel to take references.
1765         Made class final and most functions private and final.
1766         * WebCoreSupport/WebChromeClientIOS.mm:
1767         (WebChromeClientIOS::runOpenPanel): Updated to take references.
1768
1769 2016-12-30  Darin Adler  <darin@apple.com>
1770
1771         Remove PassRefPtr use from the "dom" directory, related cleanup
1772         https://bugs.webkit.org/show_bug.cgi?id=166569
1773
1774         Reviewed by Alex Christensen.
1775
1776         * WebView/WebPDFViewIOS.mm:
1777         (-[WebPDFView _checkPDFTitle]): Use aggregate-style syntax for StringWithDirection.
1778         Not needed now, but useful later if we ever can get rid of the explicit constructors.
1779
1780 2016-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
1781
1782         Stop reinterpret_casting UBreakIterators to the undefined type TextBreakIterator
1783         https://bugs.webkit.org/show_bug.cgi?id=165931
1784
1785         Reviewed by Alex Christensen.
1786
1787         * Misc/WebUIKitSupport.mm:
1788
1789 2016-11-01  Alex Christensen  <achristensen@webkit.org>
1790
1791         Remove PassRefPtr from DumpRenderTree
1792         https://bugs.webkit.org/show_bug.cgi?id=164307
1793
1794         Reviewed by Sam Weinig.
1795
1796         * Misc/WebGeolocationProviderIOS.mm:
1797
1798 2016-10-26  Dan Bernstein  <mitz@apple.com>
1799
1800         Tried to fix the iOS build after r207934.
1801
1802         * WebCoreSupport/WebFrameIOS.mm:
1803         (-[WebFrame closestCaretRectInMarkedTextRangeForPoint:]): Removed commented-out code and
1804           a comment that had a typo in it and looked like a bad Doxygen trailing comment.
1805
1806 2016-08-16  Myles C. Maxfield  <mmaxfield@apple.com>
1807
1808         Migrate line breaking code from ints to Optional<unsigned>s
1809         https://bugs.webkit.org/show_bug.cgi?id=160859
1810
1811         Reviewed by Darin Adler.
1812
1813         * Misc/WebUIKitSupport.mm:
1814         (WebKitGetLastLineBreakInBuffer):
1815
1816 2016-08-15  Joseph Pecoraro  <pecoraro@apple.com>
1817
1818         Remove unused includes of wtf headers
1819         https://bugs.webkit.org/show_bug.cgi?id=160839
1820
1821         Reviewed by Alex Christensen.
1822
1823         * Misc/WebGeolocationCoreLocationProvider.h:
1824         * WebView/WebPDFViewIOS.mm:
1825         * WebView/WebPlainWhiteView.mm:
1826
1827 2016-08-09  George Ruan  <gruan@apple.com>
1828
1829         Implement functionality of media capture on iOS
1830         https://bugs.webkit.org/show_bug.cgi?id=158945
1831         <rdar://problem/26893343>
1832
1833         Reviewed by Tim Horton.
1834
1835         * DefaultDelegates/WebDefaultUIKitDelegate.m:
1836         (-[WebDefaultUIKitDelegate
1837         webView:runOpenPanelForFileButtonWithResultListener:configuration:]):
1838         Use a dictionary instead of passing each parameter in separately.
1839         (-[WebDefaultUIKitDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:acceptMIMETypes:]): Deleted.
1840         * WebCoreSupport/WebChromeClientIOS.mm:
1841         (webMediaCaptureType): Converts from WebCore::MediaCaptureType to
1842         WebMediaCaptureType.
1843         (WebChromeClientIOS::runOpenPanel):
1844         * WebKit.iOS.exp: Expose NSDictionary keys for
1845         runOpenPanelForFileButtonWithResultListener.
1846         * WebView/WebUIKitDelegate.h: Add WebMediaCaptureType enum and
1847         NSDictionary keys for
1848         runOpenPanelForFileButtonWithResultListener.
1849
1850 2016-07-11  Enrica Casucci  <enrica@apple.com>
1851
1852         Add synthetic click origin to WKNavigationAction.
1853         https://bugs.webkit.org/show_bug.cgi?id=159584
1854         rdar://problem/25610422
1855
1856         Reviewed by Tim Horton.
1857
1858         * WebView/WebPDFViewPlaceholder.mm:
1859         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
1860
1861 2016-06-23  Alex Christensen  <achristensen@webkit.org>
1862
1863         Remove unused didCancelAuthenticationChallenge
1864         https://bugs.webkit.org/show_bug.cgi?id=158819
1865
1866         Reviewed by David Kilzer.
1867
1868         * DefaultDelegates/WebDefaultResourceLoadDelegate.m:
1869         (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1870         (-[WebDefaultResourceLoadDelegate webView:resource:canAuthenticateAgainstProtectionSpace:forDataSource:]):
1871         (-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]): Deleted.
1872
1873 2016-06-02  David Kilzer  <ddkilzer@apple.com>
1874
1875         Fix typo in -[WebDefaultUIKitDelegate deleteFromInputwithFlags:]
1876         <https://webkit.org/b/158323>
1877         <rdar://problem/26549165>
1878
1879         Reviewed by Andy Estes.
1880
1881         * DefaultDelegates/WebDefaultUIKitDelegate.m:
1882         (-[WebDefaultUIKitDelegate deleteFromInputwithFlags:]): Rename...
1883         (-[WebDefaultUIKitDelegate deleteFromInputWithFlags:]): ...to this.
1884
1885 2016-05-15  Darin Adler  <darin@apple.com>
1886
1887         More CTTE and other cleanups for HTML editing header
1888         https://bugs.webkit.org/show_bug.cgi?id=157722
1889
1890         Reviewed by Chris Dumez.
1891
1892         * WebCoreSupport/WebFrameIOS.mm:
1893         (-[WebFrame previousUnperturbedDictationResultBoundaryFromPosition:]): auto
1894         (-[WebFrame nextUnperturbedDictationResultBoundaryFromPosition:]): auto
1895
1896 2016-05-14  Darin Adler  <darin@apple.com>
1897
1898         CTTE for the HTML editing header
1899         https://bugs.webkit.org/show_bug.cgi?id=157676
1900
1901         Reviewed by Chris Dumez.
1902
1903         * WebCoreSupport/WebFrameIOS.mm:
1904         (-[WebFrame previousUnperturbedDictationResultBoundaryFromPosition:]): Update since
1905         lastOffsetForEditing takes a reference now. Seems like this code should be in WebCore.
1906         (-[WebFrame nextUnperturbedDictationResultBoundaryFromPosition:]): Ditto.
1907
1908 2016-05-13  Beth Dakin  <bdakin@apple.com>
1909
1910         Add dyldSPI.h for linked on or after checks, and add one for link preview
1911         https://bugs.webkit.org/show_bug.cgi?id=157401
1912         -and corresponding-
1913         rdar://problem/26253396
1914
1915         Reviewed by Darin Adler.
1916
1917         This patch removes DynamicLinkerSPI.h and replaces it with 
1918         wtf/spi/darwin/dyldSPI.h
1919
1920         * Misc/WebUIKitSupport.mm:
1921
1922 2016-05-06  Simon Fraser  <simon.fraser@apple.com>
1923
1924         Enable IOS_TEXT_AUTOSIZING on Mac and make it testable
1925         https://bugs.webkit.org/show_bug.cgi?id=157432
1926         rdar://problem/16406720
1927
1928         Reviewed by Dean Jackson.
1929
1930         Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested.
1931
1932         Make the setTextAutosizingEnabled() Setting work, and plumb it through WK1 and WK2
1933         preferences for WTR and DRT. Make textAutosizingWindowSizeOverride() work, for layout tests.
1934         These two settings are shared with TEXT_AUTOSIZING.
1935
1936         Add a TextAutosizing log channel, which is useful for generated -expected.html results.
1937
1938         Move adjustComputedFontSizesOnBlocks() and related code from RenderObject to RenderElement
1939         without changes.
1940
1941         An implication of this set of changes is that the way clients enable text autosizing
1942         has changed. Previously, they set the "MinimumZoomFontSize" preference to 0.
1943         Settings::defaultMinimumZoomFontSize() used to do this in order to enable text autosizing
1944         on iPhone only, not iPad.
1945
1946         Now the preferred technique is to leave minimumZoomFontSize alone, and to use textAutosizingEnabled()
1947         instead. Settings::defaultTextAutosizingEnabled() now does the check for iPhone.
1948
1949         UIWebView calls WebKitGetMinimumZoomFontSize() to setup the default minimum font zoom size,
1950         which will now always return 15, but had no other code that toggled this. So it's safe to just rely
1951         on Settings::defaultTextAutosizingEnabled() doing the right thing for iPhone/iPad.
1952
1953         * Misc/WebUIKitSupport.mm:
1954         (WebKitGetMinimumZoomFontSize):
1955
1956 2016-03-16  Jiewen Tan  <jiewen_tan@apple.com>
1957
1958         URL Parsing should signal failure for illegal IDN
1959         https://bugs.webkit.org/show_bug.cgi?id=154945
1960         <rdar://problem/8014795>
1961
1962         Reviewed by Brent Fulgham.
1963
1964         * Misc/WebNSStringExtrasIOS.m:
1965         (-[NSString _web_possibleURLsForForUserTypedString:]):
1966         * WebView/WebPDFViewPlaceholder.mm:
1967         (-[WebPDFViewPlaceholder _updateTitleForURL:]):
1968
1969 2016-03-15  Chris Dumez  <cdumez@apple.com>
1970
1971         Unreviewed, rolling out r198203.
1972
1973         Favorites view is no longer loading on iOS
1974
1975         Reverted changeset:
1976
1977         "URL Parsing should signal failure for illegal IDN"
1978         https://bugs.webkit.org/show_bug.cgi?id=154945
1979         http://trac.webkit.org/changeset/198203
1980
1981 2016-03-15  Jiewen Tan  <jiewen_tan@apple.com>
1982
1983         URL Parsing should signal failure for illegal IDN
1984         https://bugs.webkit.org/show_bug.cgi?id=154945
1985         <rdar://problem/8014795>
1986
1987         Reviewed by Brent Fulgham.
1988
1989         * Misc/WebNSStringExtrasIOS.m:
1990         (-[NSString _web_possibleURLsForForUserTypedString:]):
1991         * WebView/WebPDFViewPlaceholder.mm:
1992         (-[WebPDFViewPlaceholder _updateTitleForURL:]):
1993
1994 2016-03-05  Chris Dumez  <cdumez@apple.com>
1995
1996         Consolidate RuntimeApplicationChecks and RuntimeApplicationChecksIOS
1997         https://bugs.webkit.org/show_bug.cgi?id=155035
1998
1999         Reviewed by Darin Adler.
2000
2001         Update runtime application checks.
2002
2003         * WebCoreSupport/WebChromeClientIOS.mm:
2004
2005 2016-02-17  David Kilzer  <ddkilzer@apple.com>
2006
2007         [iOS WK1] NSTimer in WebGeolocationProviderIOS.mm fires on the main thread without the WebThreadLock
2008         <http://webkit.org/b/154347>
2009         <rdar://problem/19360382>
2010
2011         Reviewed by Andy Estes.
2012
2013         This isn't testable because the GeolocationClientMock in WebCore
2014         bypasses this code in WebKit1.
2015
2016         * Misc/WebGeolocationProviderIOS.mm:
2017         (-[WebGeolocationProviderIOS _handlePendingInitialPosition:]):
2018         Assert that this is always called on the WebThread.
2019         (-[WebGeolocationProviderIOS registerWebView:]): Register the
2020         NSTimer on the WebThread NSRunLoop.
2021
2022 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
2023
2024         Remove TextRun::allowsRoundingHacks()
2025         https://bugs.webkit.org/show_bug.cgi?id=153185
2026
2027         Reviewed by Simon Fraser.
2028
2029         * Misc/WebUIKitSupport.mm:
2030         (WebKitInitialize): Deleted.
2031
2032 2016-01-13  Chris Dumez  <cdumez@apple.com>
2033
2034         Unreviewed, rolling out r194900.
2035
2036         Roll back in as this did not actually regress PLT
2037
2038         Reverted changeset:
2039
2040         "Unreviewed, rolling out r194826."
2041         https://bugs.webkit.org/show_bug.cgi?id=153020
2042         http://trac.webkit.org/changeset/194900
2043
2044 2016-01-12  Commit Queue  <commit-queue@webkit.org>
2045
2046         Unreviewed, rolling out r194826.
2047         https://bugs.webkit.org/show_bug.cgi?id=153020
2048
2049         Appears to have regressed PLT (Requested by kling on #webkit).
2050
2051         Reverted changeset:
2052
2053         "Use NeverDestroyed instead of DEPRECATED_DEFINE_STATIC_LOCAL
2054         cont'd"
2055         https://bugs.webkit.org/show_bug.cgi?id=152902
2056         http://trac.webkit.org/changeset/194826
2057
2058 2016-01-10  Andreas Kling  <akling@apple.com>
2059
2060         Use NeverDestroyed instead of DEPRECATED_DEFINE_STATIC_LOCAL cont'd
2061         <https://webkit.org/b/152902>
2062
2063         Reviewed by Andy Estes.
2064
2065         * WebCoreSupport/WebFixedPositionContent.mm:
2066         (WebFixedPositionContentDataLock):
2067
2068 2015-12-31  Andy Estes  <aestes@apple.com>
2069
2070         Replace WTF::move with WTFMove
2071         https://bugs.webkit.org/show_bug.cgi?id=152601
2072
2073         Reviewed by Brady Eidson.
2074
2075         * WebCoreSupport/WebFixedPositionContent.mm:
2076         (-[WebFixedPositionContent setViewportConstrainedLayers:stickyContainerMap:]):
2077         * WebCoreSupport/WebInspectorClientIOS.mm:
2078         (WebInspectorFrontendClient::WebInspectorFrontendClient):
2079
2080 2015-12-20  Dan Bernstein  <mitz@apple.com>
2081
2082         Remove unused setToolbarHeight
2083         https://bugs.webkit.org/show_bug.cgi?id=152466
2084
2085         Reviewed by Darin Adler.
2086
2087         * WebCoreSupport/WebInspectorClientIOS.mm:
2088         (WebInspectorFrontendClient::setToolbarHeight): Deleted.
2089
2090 2015-12-18  Simon Fraser  <simon.fraser@apple.com>
2091
2092         Turn off "shrink-to-fit" viewport scaling in UIWebViews
2093         https://bugs.webkit.org/show_bug.cgi?id=152451
2094         rdar://problem/23960882
2095
2096         Reviewed by Tim Horton.
2097         
2098         Disable the "shrink to fit" behavior in UIWebViews. This disables it entirely,
2099         even when the page has "shrink-to-fit=yes" in the viewport meta tag.
2100         
2101         Not testable because we can't test actual UIWebView scaling behavior.
2102
2103         * WebCoreSupport/WebChromeClientIOS.mm:
2104         (dictionaryForViewportArguments):
2105
2106 2015-11-07  Simon Fraser  <simon.fraser@apple.com>
2107
2108         Remove ColorSpace argument to all the drawing calls
2109         https://bugs.webkit.org/show_bug.cgi?id=150967
2110
2111         Reviewed by Darin Adler.
2112
2113         Since the -webkit-color-correction CSS property was removed in r188202, and ColorSpaceDeviceRGB
2114         and ColorSpaceSRGB are functionally equivalent, we can remove all the ColorSpace arguments passed
2115         to drawing functions, and remove RenderStyle::colorSpace(), which was hardcoded to return ColorSpaceSRGB.
2116
2117         * WebView/WebPDFViewIOS.mm:
2118         (-[WebPDFView drawPage:]):
2119         * WebView/WebPlainWhiteView.mm:
2120
2121 2015-11-02  Andy Estes  <aestes@apple.com>
2122
2123         Fixed the iOS build after r191904.
2124
2125         * WebCoreSupport/WebChromeClientIOS.mm:
2126         (WebChromeClientIOS::screenSize):
2127
2128 2015-10-31  Andy Estes  <aestes@apple.com>
2129
2130         Replace iOS-only WebKitSystemInterface calls with SPI
2131         https://bugs.webkit.org/show_bug.cgi?id=150763
2132
2133         Reviewed by Darin Adler.
2134
2135         * Misc/WebUIKitSupport.mm:
2136         (linkedOnOrAfterIOS5): Used dyld_get_program_sdk_version() instead of iosExecutableWasLinkedOnOrAfterVersion().
2137         (WebKitGetMinimumZoomFontSize): Used Settings::defaultMinimumZoomFontSize() instead of WKGetMinimumZoomFontSize().
2138         * WebCoreSupport/WebChromeClientIOS.mm:
2139         (WebChromeClientIOS::screenSize): Used screenSize() instead of WKGetScreenSize().
2140
2141 2015-11-02  Commit Queue  <commit-queue@webkit.org>
2142
2143         Unreviewed, rolling out r191902.
2144         https://bugs.webkit.org/show_bug.cgi?id=150811
2145
2146         This change broke iOS builders (Requested by ryanhaddad on
2147         #webkit).
2148
2149         Reverted changeset:
2150
2151         "Replace iOS-only WebKitSystemInterface calls with SPI"
2152         https://bugs.webkit.org/show_bug.cgi?id=150763
2153         http://trac.webkit.org/changeset/191902
2154
2155 2015-10-31  Andy Estes  <aestes@apple.com>
2156
2157         Replace iOS-only WebKitSystemInterface calls with SPI
2158         https://bugs.webkit.org/show_bug.cgi?id=150763
2159
2160         Reviewed by Darin Adler.
2161
2162         * Misc/WebUIKitSupport.mm:
2163         (linkedOnOrAfterIOS5): Used dyld_get_program_sdk_version() instead of iosExecutableWasLinkedOnOrAfterVersion().
2164         (WebKitGetMinimumZoomFontSize): Used Settings::defaultMinimumZoomFontSize() instead of WKGetMinimumZoomFontSize().
2165         * WebCoreSupport/WebChromeClientIOS.mm:
2166         (WebChromeClientIOS::screenSize): Used screenSize() instead of WKGetScreenSize().
2167
2168 2015-10-14  Zhuo Li  <zachli@apple.com>
2169
2170         Augment <input type=search>’s recent search history with the time each entry was added,
2171         in order to allow time-based clearing of search history.
2172         https://bugs.webkit.org/show_bug.cgi?id=148388.
2173
2174         Reviewed by Darin Adler.
2175
2176         Replace Vector<String> with Vector<RecentSearch>, where RecentSearch is a struct
2177         that consists search string and time, for recent searches in order to store additional time information.
2178
2179         * WebCoreSupport/SearchPopupMenuIOS.cpp:
2180         (SearchPopupMenuIOS::saveRecentSearches):
2181         (SearchPopupMenuIOS::loadRecentSearches):
2182         * WebCoreSupport/SearchPopupMenuIOS.h:
2183
2184 2015-09-17  Brian Burg  <bburg@apple.com>
2185
2186         ASSERT(!m_frontendRouter->hasLocalFrontend()) when running Web Inspector tests
2187         https://bugs.webkit.org/show_bug.cgi?id=149006
2188
2189         Reviewed by Joseph Pecoraro.
2190
2191         * WebCoreSupport/WebInspectorClientIOS.mm:
2192         (WebInspectorClient::closeLocalFrontend): Deleted.
2193         (WebInspectorFrontendClient::disconnectFromBackend): Deleted.
2194
2195 2015-09-12  Brian Burg  <bburg@apple.com>
2196
2197         Web Inspector: disambiguate inspected/frontend controllers and pages in backend code
2198         https://bugs.webkit.org/show_bug.cgi?id=149071
2199
2200         Reviewed by Joseph Pecoraro.
2201
2202         * WebCoreSupport/WebInspectorClientIOS.mm:
2203         (WebInspectorClient::WebInspectorClient):
2204         (WebInspectorClient::inspectedPageDestroyed): Renamed.
2205         (WebInspectorClient::openLocalFrontend): Renamed.
2206         (WebInspectorClient::closeLocalFrontend): Renamed.
2207         (WebInspectorClient::inspectorDestroyed): Deleted.
2208         (WebInspectorClient::openInspectorFrontend): Deleted.
2209         (WebInspectorClient::closeInspectorFrontend): Deleted.
2210         (WebInspectorClient::showInspectorIndication):
2211         (WebInspectorClient::hideInspectorIndication):
2212         (WebInspectorClient::didSetSearchingForNode):
2213         (WebInspectorFrontendClient::WebInspectorFrontendClient):
2214
2215 2015-08-17  Filip Pizlo  <fpizlo@apple.com>
2216
2217         Replace all remaining uses of WTF::Mutex with WTF::Lock
2218         https://bugs.webkit.org/show_bug.cgi?id=148089
2219
2220         Reviewed by Geoffrey Garen.
2221
2222         * WebCoreSupport/WebFixedPositionContent.mm:
2223         (WebFixedPositionContentDataLock):
2224         (-[WebFixedPositionContent scrollOrZoomChanged:]):
2225         (-[WebFixedPositionContent overflowScrollPositionForLayer:changedTo:]):
2226         (-[WebFixedPositionContent setViewportConstrainedLayers:stickyContainerMap:]):
2227         (-[WebFixedPositionContent hasFixedOrStickyPositionLayers]):
2228         (-[WebFixedPositionContent minimumOffsetFromFixedPositionLayersToAnchorEdge:ofRect:inLayer:]):
2229
2230 2015-08-13  Tim Horton  <timothy_horton@apple.com>
2231
2232         Refactor and improve TextIndicator to prepare for tests
2233         https://bugs.webkit.org/show_bug.cgi?id=147622
2234
2235         Reviewed by Simon Fraser.
2236
2237         * WebCoreSupport/WebFrameIOS.mm:
2238         (-[WebFrame closestCaretRectInMarkedTextRangeForPoint:]):
2239         Adjust to Range method renames.
2240
2241 2015-08-05  Filip Pizlo  <fpizlo@apple.com>
2242
2243         Unreviewed, roll out http://trac.webkit.org/changeset/187972.
2244
2245         * WebCoreSupport/WebFixedPositionContent.mm:
2246         (WebFixedPositionContentDataLock):
2247         (-[WebFixedPositionContent scrollOrZoomChanged:]):
2248         (-[WebFixedPositionContent overflowScrollPositionForLayer:changedTo:]):
2249         (-[WebFixedPositionContent setViewportConstrainedLayers:stickyContainerMap:]):
2250         (-[WebFixedPositionContent hasFixedOrStickyPositionLayers]):
2251         (-[WebFixedPositionContent minimumOffsetFromFixedPositionLayersToAnchorEdge:ofRect:inLayer:]):
2252
2253 2015-08-04  Filip Pizlo  <fpizlo@apple.com>
2254
2255         Rename Mutex to DeprecatedMutex
2256         https://bugs.webkit.org/show_bug.cgi?id=147675
2257
2258         Reviewed by Geoffrey Garen.
2259
2260         * WebCoreSupport/WebFixedPositionContent.mm:
2261         (WebFixedPositionContentDataLock):
2262         (-[WebFixedPositionContent scrollOrZoomChanged:]):
2263         (-[WebFixedPositionContent overflowScrollPositionForLayer:changedTo:]):
2264         (-[WebFixedPositionContent setViewportConstrainedLayers:stickyContainerMap:]):
2265         (-[WebFixedPositionContent hasFixedOrStickyPositionLayers]):
2266         (-[WebFixedPositionContent minimumOffsetFromFixedPositionLayersToAnchorEdge:ofRect:inLayer:]):
2267
2268 2015-08-04  Anders Carlsson  <andersca@apple.com>
2269
2270         Remove database thread pause code
2271         https://bugs.webkit.org/show_bug.cgi?id=147669
2272
2273         Reviewed by Daniel Bates.
2274
2275         * Misc/WebUIKitSupport.mm:
2276         (WebKitSetBackgroundAndForegroundNotificationNames):
2277         (applicationDidEnterBackground): Deleted.
2278         (applicationWillEnterForeground): Deleted.
2279
2280 2015-07-21  Tim Horton  <timothy_horton@apple.com>
2281
2282         Expose shrink-wrapping as UIKit support SPI
2283         https://bugs.webkit.org/show_bug.cgi?id=147148
2284         <rdar://problem/21920008>
2285
2286         * WebKit.iOS.exp:
2287         Also export.
2288
2289 2015-07-21  Tim Horton  <timothy_horton@apple.com>
2290
2291         Expose shrink-wrapping as UIKit support SPI
2292         https://bugs.webkit.org/show_bug.cgi?id=147148
2293         <rdar://problem/21920008>
2294
2295         Reviewed by Simon Fraser.
2296
2297         * Misc/WebUIKitSupport.h:
2298         * Misc/WebUIKitSupport.mm:
2299         (WebKitCreatePathWithShrinkWrappedRects):
2300
2301 2015-07-02  Timothy Horton  <timothy_horton@apple.com>
2302
2303         iOS WebKitLegacy should match WebKit2's viewport behavior
2304         https://bugs.webkit.org/show_bug.cgi?id=146564
2305         <rdar://problem/20574017>
2306
2307         Reviewed by Brent Fulgham.
2308
2309         * WebCoreSupport/WebChromeClientIOS.mm:
2310         (dictionaryForViewportArguments):
2311
2312 2015-07-02  Timothy Horton  <timothy_horton@apple.com>
2313
2314         iOS WebKitLegacy should match WebKit2's viewport behavior
2315         https://bugs.webkit.org/show_bug.cgi?id=146540
2316         <rdar://problem/20574017>
2317
2318         Reviewed by Dan Bernstein.
2319
2320         * WebKit.iOS.exp:
2321
2322 2015-06-25  Joseph Pecoraro  <pecoraro@apple.com>
2323
2324         Unreviewed, attempt to fix the iOS build after r185968.
2325
2326         * WebCoreSupport/WebInspectorClientIOS.mm:
2327         (WebInspectorFrontendClient::startWindowDrag):
2328
2329 2015-06-02  Brady Eidson  <beidson@apple.com>
2330
2331         WebKit policy delegate should suggest if a navigation should be allowed to open URLs externally.
2332         rdar://problem/21025301 and https://bugs.webkit.org/show_bug.cgi?id=145280
2333
2334         Reviewed by Alex Christensen.
2335
2336         * WebView/WebPDFViewPlaceholder.mm:
2337         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
2338
2339 2015-05-25  Dan Bernstein  <mitz@apple.com>
2340
2341         ASSERT_MAIN_THREAD and DOM_ASSERT_MAIN_THREAD are unnecessary no-ops
2342         https://bugs.webkit.org/show_bug.cgi?id=145372
2343
2344         Reviewed by Sam Weinig.
2345
2346         * Misc/WebGeolocationCoreLocationProvider.mm:
2347         (-[WebGeolocationCoreLocationProvider initWithListener:]): Removed use of ASSERT_MAIN_THREAD.
2348         (-[WebGeolocationCoreLocationProvider dealloc]): Ditto.
2349         (-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]): Ditto.
2350         (-[WebGeolocationCoreLocationProvider start]): Ditto.
2351         (-[WebGeolocationCoreLocationProvider stop]): Ditto.
2352         (-[WebGeolocationCoreLocationProvider setEnableHighAccuracy:]): Ditto.
2353
2354 2015-04-28  Brady Eidson  <beidson@apple.com>
2355
2356         Consolidate most "frame load" arguments into FrameLoadRequest.
2357         https://bugs.webkit.org/show_bug.cgi?id=144276
2358
2359         Reviewed by Alexey Proskuryakov.
2360
2361         * WebView/WebPDFViewPlaceholder.mm:
2362         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
2363
2364 2015-04-13  Beth Dakin  <bdakin@apple.com>
2365
2366         Add force property to MouseEvents
2367         https://bugs.webkit.org/show_bug.cgi?id=143569
2368         -and corresponding-
2369         rdar://problem/20472954
2370
2371         Reviewed by Darin Adler.
2372
2373         Send the appropriate force with this simulated click event.
2374         * WebView/WebPDFViewPlaceholder.mm:
2375         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
2376
2377 2015-03-31  Myles C. Maxfield  <mmaxfield@apple.com>
2378
2379         Move ExpansionBehaviorFlags and TextDirection to their own file
2380         https://bugs.webkit.org/show_bug.cgi?id=143273
2381
2382         Reviewed by Simon Fraser.
2383
2384         This is a mechanical change. It just moves code around.
2385
2386         This is getting ready for https://bugs.webkit.org/show_bug.cgi?id=142608
2387
2388         * WebCoreSupport/WebFrameIOS.mm:
2389         * WebCoreSupport/WebVisiblePosition.mm:
2390
2391 2015-03-09  David Kilzer  <ddkilzer@apple.com>
2392
2393         [iOS] Fix build when compiling with dead code stripping disabled
2394         <http://webkit.org/b/142467>
2395
2396         Reviewed by Simon Fraser.
2397
2398         * WebCoreSupport/WebInspectorClientIOS.mm:
2399         (WebInspectorFrontendClient::save): Add missing method.
2400
2401 2015-02-14  Alexey Proskuryakov  <ap@apple.com>
2402
2403         rel="noreferrer" should make window.opener null
2404         https://bugs.webkit.org/show_bug.cgi?id=141579
2405
2406         Reviewed by Darin Adler.
2407
2408         * WebView/WebPDFViewPlaceholder.mm:
2409         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]): Updated for a new WebCore
2410         function signature. There is no rel="noreferrer" in PDF, so we can just always allow.
2411
2412 2015-02-03  Enrica Casucci  <enrica@apple.com>
2413
2414         [iOS] Add support for deleteFromInputWithFlags.
2415         https://bugs.webkit.org/show_bug.cgi?id=141216
2416         rdar://problem/19130081
2417
2418         Reviewed by Benjamin Poulain.
2419
2420         Adopts the new method as soon as it is available.
2421         The patch also removes some obsolete code used for staging.
2422
2423         * DefaultDelegates/WebDefaultUIKitDelegate.m:
2424         (-[WebDefaultUIKitDelegate addInputString:withFlags:]):
2425         (-[WebDefaultUIKitDelegate deleteFromInput]):
2426         (-[WebDefaultUIKitDelegate deleteFromInputwithFlags:]):
2427         (-[WebDefaultUIKitDelegate addInputString:fromVariantKey:]): Deleted.
2428         * WebView/WebUIKitDelegate.h:
2429
2430 2015-01-22  Andreas Kling  <akling@apple.com>
2431
2432         Remove unused class EmojiFallbackFontSelector.
2433         <https://webkit.org/b/140809>
2434
2435         Reviewed by Antti Koivisto.
2436
2437         This class no longer has any clients.
2438
2439         * Misc/EmojiFallbackFontSelector.cpp: Removed.
2440         * Misc/EmojiFallbackFontSelector.h: Removed.
2441
2442 2015-01-13  Chris Dumez  <cdumez@apple.com>
2443
2444         Unreviewed iOS build fix after r178375
2445
2446         Match FontSelector API changes.
2447
2448         * Misc/EmojiFallbackFontSelector.cpp:
2449         (EmojiFallbackFontSelector::fallbackFontDataAt):
2450         (EmojiFallbackFontSelector::getFallbackFontData): Deleted.
2451         * Misc/EmojiFallbackFontSelector.h:
2452
2453 2014-12-07  Dan Bernstein  <mitz@apple.com>
2454
2455         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
2456         https://bugs.webkit.org/show_bug.cgi?id=139348
2457
2458         Reviewed by Anders Carlsson.
2459
2460         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
2461         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
2462         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
2463         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
2464         avoiding the ambiguity.
2465
2466         * Misc/WebGeolocationCoreLocationProvider.mm:
2467         (-[WebGeolocationCoreLocationProvider createLocationManager]):
2468
2469 2014-12-06  Anders Carlsson  <andersca@apple.com>
2470
2471         Fix build with newer versions of clang.
2472         rdar://problem/18978687
2473
2474         Cast the result of +alloc to the right type.
2475
2476         * Misc/WebGeolocationCoreLocationProvider.mm:
2477         (-[WebGeolocationCoreLocationProvider createLocationManager]):
2478         * WebCoreSupport/WebSelectionRect.m:
2479         (+[WebSelectionRect selectionRect]):
2480
2481 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
2482
2483         Remove the remaining vestiges of minimal-ui
2484         https://bugs.webkit.org/show_bug.cgi?id=138890
2485
2486         Reviewed by Sam Weinig.
2487
2488         * WebCoreSupport/WebChromeClientIOS.mm:
2489         (dictionaryForViewportArguments):
2490         * WebKit.iOS.exp:
2491
2492 2014-11-19  Daniel Bates  <dabates@apple.com>
2493
2494         [iOS] Make WebKit build with public iOS SDK
2495         https://bugs.webkit.org/show_bug.cgi?id=136863
2496
2497         Reviewed by David Kilzer.
2498
2499         * Misc/WebGeolocationCoreLocationProvider.mm:  Remove unnecessary include of header <CoreLocation/CoreLocationPriv.h>.
2500         * Misc/WebNSStringExtrasIOS.m: Substitute header <WebCore/NSStringSPI.h> for <Foundation/NSString_NSURLExtras.h>.
2501         * Misc/WebUIKitSupport.mm: Remove unnecessary include of header CoreFoundation/CFPriv.h.
2502
2503 2014-11-14  Daniel Bates  <dabates@apple.com>
2504
2505         [iOS] CoreGraphics SPI not available in public SDK
2506         https://bugs.webkit.org/show_bug.cgi?id=138709
2507
2508         Reviewed by David Kilzer.
2509
2510         Include header CoreGraphicsSPI.h instead of the private header CGFloat.h.
2511
2512         * WebCoreSupport/WebFixedPositionContent.mm:
2513
2514 2014-10-20  Andy Estes  <aestes@apple.com>
2515
2516         Fix the iOS build.
2517
2518         * WebCoreSupport/WebFrameIOS.mm:
2519         (-[WebFrame previousUnperturbedDictationResultBoundaryFromPosition:]):
2520         (-[WebFrame nextUnperturbedDictationResultBoundaryFromPosition:]):
2521         * WebCoreSupport/WebVisiblePosition.mm:
2522         (-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]):
2523         (-[WebVisiblePosition enclosingRangeWithCorrectionIndicator]):
2524
2525 2014-10-15  Chris Dumez  <cdumez@apple.com>
2526
2527         Use is<>() / downcast<>() for RenderTextControl / RenderTextControlSingleLine
2528         https://bugs.webkit.org/show_bug.cgi?id=137727
2529
2530         Reviewed by Darin Adler.
2531
2532         Use is<>() / downcast<>() for RenderTextControl / RenderTextControlSingleLine.
2533
2534         * WebCoreSupport/WebVisiblePosition.mm:
2535         (-[DOMHTMLInputElement startPosition]):
2536         (-[DOMHTMLInputElement endPosition]):
2537         (-[DOMHTMLTextAreaElement startPosition]):
2538         (-[DOMHTMLTextAreaElement endPosition]):
2539
2540 2014-10-03  Tim Horton  <timothy_horton@apple.com>
2541
2542         REGRESSION (r165896): UIWebView PDFs have a forced black background
2543         https://bugs.webkit.org/show_bug.cgi?id=137387
2544         <rdar://problem/17948411>
2545
2546         Reviewed by David Kilzer.
2547
2548         * WebView/WebPDFViewPlaceholder.h:
2549         * WebView/WebPDFViewPlaceholder.mm:
2550         (-[WebPDFViewPlaceholder layout]):
2551         Remove an ill-advised attempt to force the PDF background color from WebKit.
2552         The idea was that we would maintain Safari's black background except if there
2553         were no pages in the PDF, in which case we would use white instead to avoid
2554         having an all-black view. However, this broke clients who didn't want a black
2555         background, because we were now forcing it to black. Also, we don't need to
2556         maintain the black color in Safari because it doesn't use WebPDFViewPlaceholder anymore.
2557         This wasn't an important part of the patch, in any case.
2558
2559 2014-10-03  Tim Horton  <timothy_horton@apple.com>
2560
2561         REGRESSION (r173265): UIWebView PDF loading is completely broken
2562         https://bugs.webkit.org/show_bug.cgi?id=137386
2563         <rdar://problem/18524717>
2564
2565         Reviewed by David Kilzer.
2566
2567         * WebView/WebPDFViewPlaceholder.h:
2568         * WebView/WebPDFViewPlaceholder.mm:
2569         (-[WebPDFViewPlaceholder layout]):
2570         (-[WebPDFViewPlaceholder finishedLoadingWithDataSource:]):
2571         Restore important code that creates the CGDataProvider and sets _didFinishLoad
2572         and calls _doPostLoadOrUnlockTasks after finishing a load, which was haphazardly
2573         removed in the aforementioned revision.
2574
2575 2014-10-01  Christophe Dumez  <cdumez@apple.com>
2576
2577         Have is<>(T*) function do a null check on the pointer argument
2578         https://bugs.webkit.org/show_bug.cgi?id=137333
2579
2580         Reviewed by Gavin Barraclough.
2581
2582         Have is<>(T*) function do a null check on the argument instead of a
2583         simple assertion. This makes sense for 2 reasons:
2584         1. It is more consistent with downcast<>(T*), which will succeed even
2585            if the argument is a nullptr.
2586         2. It simplifies the code a bit as it gets rid of a lot of explicit
2587            null checks.
2588
2589         * WebCoreSupport/WebChromeClientIOS.mm:
2590         (WebChromeClientIOS::focusedElementChanged):
2591
2592 2014-09-29  Daniel Bates  <dabates@apple.com>
2593
2594         [iOS] Remove CoreLocation workaround
2595         https://bugs.webkit.org/show_bug.cgi?id=137198
2596
2597         Reviewed by Dan Bernstein.
2598
2599         Following the fix for <rdar://problem/18448331>, we can revert the CoreLocation workaround
2600         committed in <http://trac.webkit.org/changeset/173946> and <http://trac.webkit.org/changeset/173940> (in order).
2601
2602         * Misc/WebGeolocationCoreLocationProvider.mm:
2603         (-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):
2604         (-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]):
2605
2606 2014-09-24  Daniel Bates  <dabates@apple.com>
2607
2608         [iOS] Another iOS build fix; workaround for CoreLocation
2609         https://bugs.webkit.org/show_bug.cgi?id=137104
2610         <rdar://problem/18450785>
2611
2612         Rubber-stamped by Benjamin Poulain.
2613
2614         Workaround CoreLocation issue by adding a default statement in -[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]
2615         and -[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:].
2616         We'll remove these default statements once we have the fix for <rdar://problem/18448331>.
2617
2618         * Misc/WebGeolocationCoreLocationProvider.mm:
2619         (-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):
2620         (-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]):
2621
2622 2014-09-24  Daniel Bates  <dabates@apple.com>
2623
2624         [iOS] Fix the iOS build; add case statements for kCLAuthorizationStatusAuthorized
2625         https://bugs.webkit.org/show_bug.cgi?id=137101
2626         <rdar://problem/18449815>
2627
2628         Reviewed by Mark Lam.
2629
2630         * Misc/WebGeolocationCoreLocationProvider.mm:
2631         (-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):
2632         (-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]):
2633
2634 2014-09-24  Christophe Dumez  <cdumez@apple.com>
2635
2636         Use is<HTML*Element>() instead of isHTML*Element() - Part 1
2637         https://bugs.webkit.org/show_bug.cgi?id=137068
2638
2639         Reviewed by Ryosuke Niwa.
2640
2641         Start using is<HTML*Element>() instead of isHTML*Element().
2642         Remaining usages will be updated in a follow-up patch to
2643         reduce the size of the change.
2644
2645         * WebCoreSupport/WebChromeClientIOS.mm:
2646         (WebChromeClientIOS::focusedElementChanged):
2647
2648 2014-09-21  Timothy Hatcher  <timothy@apple.com>
2649
2650         Make the Web Inspector use a separate web process.
2651
2652         https://bugs.webkit.org/show_bug.cgi?id=135120
2653
2654         Reviewed by Anders Carlsson.
2655
2656         * WebCoreSupport/WebInspectorClientIOS.mm:
2657         (WebInspectorClient::WebInspectorClient):
2658         Removed m_frontendClient initialization since it is
2659         now a std::unique_ptr that defaults to nullptr.
2660
2661 2014-09-23  Chris Dumez  <cdumez@apple.com>
2662
2663         Use downcast<HTML*Element>() instead of toHTML*Element()
2664         https://bugs.webkit.org/show_bug.cgi?id=137007
2665
2666         Reviewed by Benjamin Poulain.
2667
2668         Use downcast<HTML*Element>() instead of toHTML*Element().
2669
2670         * WebCoreSupport/WebChromeClientIOS.mm:
2671         (WebChromeClientIOS::focusedElementChanged):
2672
2673 2014-09-17  Daniel Bates  <dabates@apple.com>
2674
2675         Unreviewed, rolling out r173695.
2676
2677         Broke building third-party Legacy WebKit apps; will
2678         investigate offline
2679
2680         Reverted changeset:
2681
2682         "[iOS] Make WebCore build with public iOS SDK"
2683         https://bugs.webkit.org/show_bug.cgi?id=136487
2684         http://trac.webkit.org/changeset/173695
2685
2686 2014-09-17  Daniel Bates  <dabates@apple.com>
2687
2688         [iOS] Make WebCore build with public iOS SDK
2689         https://bugs.webkit.org/show_bug.cgi?id=136487
2690
2691         Reviewed by David Kilzer.
2692
2693         Substitute <WebCore/CGFloatSPI.h> for <CoreGraphics/CGFloat.h>.
2694
2695         * WebCoreSupport/WebFixedPositionContent.mm:
2696
2697 2014-09-05  Simon Fraser  <simon.fraser@apple.com>
2698
2699         Remove some PLATFORM(IOS) code in Color.h/cpp
2700         https://bugs.webkit.org/show_bug.cgi?id=136582
2701
2702         Reviewed by Dan Bates.
2703         
2704         createCGColorWithDeviceWhite() is only used here so make it a local static function.
2705
2706         * WebView/WebPDFViewIOS.mm:
2707         (createCGColorWithDeviceWhite):
2708
2709 2014-09-04  Pratik Solanki  <psolanki@apple.com>
2710
2711         Remove iOS specific disk image cache
2712         https://bugs.webkit.org/show_bug.cgi?id=136517
2713
2714         Reviewed by Antti Koivisto.
2715
2716         Disk image cache code unnecessarily complicates SharedBuffer implementation. We can remove
2717         this now since we don't enable it in WebKit2 on iOS.
2718
2719         * WebCoreSupport/WebDiskImageCacheClientIOS.h: Removed.
2720         * WebCoreSupport/WebDiskImageCacheClientIOS.mm: Removed.
2721         * WebView/WebPDFViewPlaceholder.mm:
2722         (-[WebPDFViewPlaceholder finishedLoadingWithDataSource:]):
2723         (-[WebPDFViewPlaceholder dataSourceMemoryMapped]): Deleted.
2724         (-[WebPDFViewPlaceholder dataSourceMemoryMapFailed]): Deleted.
2725
2726 2014-08-31  Tim Horton  <timothy_horton@apple.com>
2727
2728         Remove unnecessary (and unnecessarily iOS-specific) setStrokeAndFillColor
2729         https://bugs.webkit.org/show_bug.cgi?id=136416
2730
2731         Reviewed by Dan Bernstein.
2732
2733         * WebView/WebPDFViewIOS.mm:
2734         (-[WebPDFView drawPage:]):
2735         (-[WebPDFView drawRect:]):
2736         * WebView/WebPlainWhiteView.mm:
2737         We only end up filling, so only set the fill color.
2738
2739 2014-08-22  Simon Fraser  <simon.fraser@apple.com>
2740
2741         Implement paint flashing in the WK1 InspectorOverlay page
2742         https://bugs.webkit.org/show_bug.cgi?id=136138
2743
2744         Reviewed by Sam Weinig, Joseph Pecoraro.
2745
2746         Implement paint flashing for the WebKit1 InspectorOverlay via a second canvas in the overlay page.
2747         We avoid allocating backing store for this canvas until we have paint rects.
2748         
2749         Because this overlay page is weird and doesn't know how to paint itself, InspectorOverlay manages
2750         an array of rects, and pushes them to the page when they change, before forcing a paint.
2751         
2752         Because iOS doesn't use the InspectorOverlay page, stub out setShowPaintRects on its
2753         WebKit WebInspectorClient, but don't yet implement paint flashing there.
2754
2755         * WebCoreSupport/WebInspectorClientIOS.mm:
2756         (WebInspectorClient::setShowPaintRects):
2757         (WebInspectorClient::showPaintRect):
2758
2759 2014-08-18  Andy Estes  <aestes@apple.com>
2760
2761         Fix the iOS build after  r172709.
2762
2763         * WebView/WebPDFViewPlaceholder.mm:
2764         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
2765
2766 2014-07-03  Daniel Bates  <dabates@apple.com>
2767
2768         Add WTF::move()
2769         https://bugs.webkit.org/show_bug.cgi?id=134500
2770
2771         Rubber-stamped by Anders Carlsson.
2772
2773         Substitute WTF::move() for std::move().
2774
2775         * WebCoreSupport/WebFixedPositionContent.mm:
2776         (-[WebFixedPositionContent setViewportConstrainedLayers:stickyContainerMap:]):
2777         * WebCoreSupport/WebInspectorClientIOS.mm:
2778         (WebInspectorFrontendClient::WebInspectorFrontendClient):
2779
2780 2014-07-01  Alex Christensen  <achristensen@webkit.org>
2781
2782         [iOS] Compile fix with pointer lock enabled.
2783         https://bugs.webkit.org/show_bug.cgi?id=134472
2784
2785         Reviewed by Pratik Solanki.
2786
2787         * WebView/WebPDFViewPlaceholder.mm:
2788         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
2789         Add parameters required for pointer lock.
2790
2791 2014-06-05  Benjamin Poulain  <bpoulain@apple.com>
2792
2793         [iOS][WK2] Add device orientation
2794         https://bugs.webkit.org/show_bug.cgi?id=133530
2795
2796         Reviewed by Tim Horton.
2797
2798         Change WebKit1 to provide the deviceOrientation as pull instead of push.
2799
2800         * DefaultDelegates/WebDefaultUIKitDelegate.m:
2801         (-[WebDefaultUIKitDelegate deviceOrientation]):
2802         * WebCoreSupport/WebChromeClientIOS.h:
2803         * WebCoreSupport/WebChromeClientIOS.mm:
2804         (WebChromeClientIOS::deviceOrientation):
2805         * WebView/WebUIKitDelegate.h:
2806
2807 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
2808
2809         [iOS] Switch geolocation to an explicit authorization query model
2810         https://bugs.webkit.org/show_bug.cgi?id=132717
2811         <rdar://problem/16762390>
2812
2813         Reviewed by Sam Weinig.
2814
2815         WebGeolocationCoreLocationProvider is the general WebKit wrapper for CoreLocation.
2816
2817         The old model was to start WebGeolocationCoreLocationProvider and have the start fail or succeed.
2818         The new model is to explicitely ask for authorization through "requestGeolocationAuthorization", and
2819         listen to "geolocationAuthorizationGranted" and "geolocationAuthorizationDenied".
2820
2821         We assume the client of WebGeolocationCoreLocationProvider is well behaved and ask for authorization
2822         before invoking "start".
2823         If "start" is called and the authorization is not granted, we assume geolocation was reset since
2824         the last time authorization was requested, and we reset the client.
2825
2826
2827         WebGeolocationProviderIOS has been adapted to that model. Instead of doing the "warmup" sequence
2828         to get the authorization, it queries WebGeolocationCoreLocationProvider explicitly.
2829
2830         * Misc/WebGeolocationCoreLocationProvider.h:
2831         * Misc/WebGeolocationCoreLocationProvider.mm:
2832         (-[WebGeolocationCoreLocationProvider createLocationManager]):
2833         (-[WebGeolocationCoreLocationProvider dealloc]):
2834         (-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):
2835         (isAuthorizationGranted):
2836         (-[WebGeolocationCoreLocationProvider start]):
2837         (-[WebGeolocationCoreLocationProvider stop]):
2838         (-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]):
2839         (-[WebGeolocationCoreLocationProvider setEnableHighAccuracy:]):
2840         (-[WebGeolocationCoreLocationProvider handleExternalAuthorizationStatusChange:]): Deleted.
2841         * Misc/WebGeolocationProviderIOS.mm:
2842         (-[WebGeolocationProviderIOS suspend]):
2843         (-[WebGeolocationProviderIOS resume]):
2844         (-[WebGeolocationProviderIOS registerWebView:]):
2845         (-[WebGeolocationProviderIOS unregisterWebView:]):
2846         (-[WebGeolocationProviderIOS setEnableHighAccuracy:]):
2847         (-[WebGeolocationProviderIOS initializeGeolocationForWebView:listener:]):
2848         (-[WebGeolocationProviderIOS geolocationAuthorizationGranted]):
2849         (-[WebGeolocationProviderIOS geolocationAuthorizationDenied]):
2850         (-[WebGeolocationProviderIOS stopTrackingWebView:]):
2851         (-[WebGeolocationProviderIOS resetGeolocation]):
2852         (-[_WebCoreLocationUpdateThreadingProxy geolocationAuthorizationGranted]):
2853         (-[_WebCoreLocationUpdateThreadingProxy geolocationAuthorizationDenied]):
2854         (-[_WebCoreLocationUpdateThreadingProxy positionChanged:WebCore::]):
2855         (-[_WebCoreLocationUpdateThreadingProxy errorOccurred:]):
2856         (-[_WebCoreLocationUpdateThreadingProxy resetGeolocation]):
2857         (-[WebGeolocationProviderIOS _startCoreLocationDelegate]): Deleted.
2858         (-[WebGeolocationProviderIOS _stopCoreLocationDelegateIfNeeded]): Deleted.
2859         (-[WebGeolocationProviderIOS cancelWarmUpForWebView:]): Deleted.
2860         (-[WebGeolocationProviderIOS geolocationDelegateStarted]): Deleted.
2861         (-[WebGeolocationProviderIOS geolocationDelegateUnableToStart]): Deleted.
2862         (-[_WebCoreLocationUpdateThreadingProxy geolocationDelegateStarted]): Deleted.
2863         (-[_WebCoreLocationUpdateThreadingProxy geolocationDelegateUnableToStart]): Deleted.
2864
2865 2014-04-30  Anders Carlsson  <andersca@apple.com>
2866
2867         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
2868         https://bugs.webkit.org/show_bug.cgi?id=132399
2869         <rdar://problem/15920046>
2870
2871         Reviewed by Dan Bernstein.
2872
2873         Import WebKitLegacy headers instead of WebKit headers.
2874         
2875         * DefaultDelegates/WebDefaultFormDelegate.h:
2876         * DefaultDelegates/WebDefaultFrameLoadDelegate.m:
2877         * DefaultDelegates/WebDefaultResourceLoadDelegate.m:
2878         * DefaultDelegates/WebDefaultUIKitDelegate.h:
2879         * Misc/WebGeolocationProviderIOS.h:
2880         * Misc/WebNSStringExtrasIPhone.h:
2881         * WebCoreSupport/WebFrameIOS.h:
2882         * WebCoreSupport/WebFrameIOS.mm:
2883         * WebCoreSupport/WebFrameIPhone.h:
2884         * WebCoreSupport/WebSelectionRect.h:
2885         * WebCoreSupport/WebVisiblePosition.h:
2886         * WebView/WebPDFViewIOS.h:
2887         * WebView/WebPDFViewIOS.mm:
2888         * WebView/WebPDFViewIPhone.h:
2889         * WebView/WebPDFViewPlaceholder.h:
2890         * WebView/WebPDFViewPlaceholder.mm:
2891         * WebView/WebPlainWhiteView.h:
2892         * WebView/WebUIKitDelegate.h:
2893
2894 2014-04-24  Myles C. Maxfield  <mmaxfield@apple.com>
2895
2896         FontCache::fontCache() never returns nullptr so it can be made to return a reference instead
2897         https://bugs.webkit.org/show_bug.cgi?id=132110
2898
2899         Reviewed by Tim Horton.
2900
2901         Updates callers to use '.' instead of '->'.
2902
2903         No new tests are necessary because there should be no behavior change.
2904
2905         * Misc/EmojiFallbackFontSelector.cpp:
2906         (EmojiFallbackFontSelector::getFallbackFontData):
2907
2908 2014-04-17  Daniel Bates  <dabates@apple.com>
2909
2910         [iOS] Hook up screen.{availHeight, availWidth, height, width}
2911         https://bugs.webkit.org/show_bug.cgi?id=131821
2912         <rdar://problem/16413795>
2913
2914         Reviewed by Benjamin Poulain and Tim Horton.
2915
2916         Provide iOS-specific WebKit1 implementation for ChromeClient::availableScreenSize().
2917
2918         Additionally substitute "screenSize" for "viewporScreenSize" to make the code more understandable.
2919
2920         * WebCoreSupport/WebChromeClientIOS.h:
2921         * WebCoreSupport/WebChromeClientIOS.mm:
2922         (WebChromeClientIOS::screenSize): Renamed; formerly named viewportScreenSize.
2923         (WebChromeClientIOS::availableScreenSize): Added; ASSERT_NOT_REACHED() as a widget
2924         should consult it's associated WAKWindow for the available screen size.
2925
2926 2014-04-08  Alexey Proskuryakov  <ap@apple.com>
2927
2928         Rename Clipboard to DataTransfer
2929         https://bugs.webkit.org/show_bug.cgi?id=131371
2930
2931         Reviewed by Anders Carlsson.
2932
2933         * WebView/WebPDFViewPlaceholder.mm:
2934
2935 2014-04-02  Benjamin Poulain  <bpoulain@apple.com>
2936
2937         [iOS] Remove the legacy string drawing code
2938         https://bugs.webkit.org/show_bug.cgi?id=131088
2939
2940         Reviewed by Sam Weinig.
2941
2942         * Misc/WebNSStringDrawing.h: Removed.
2943         * Misc/WebNSStringDrawing.mm: Removed.
2944         * Misc/WebUIKitSupport.h:
2945
2946 2014-04-02  Mark Rowe  <mrowe@apple.com>
2947
2948         Build fix after r166684.
2949
2950         * WebView/WebPDFViewPlaceholder.mm:
2951         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
2952
2953 2014-03-31  Anders Carlsson  <andersca@apple.com>
2954
2955         Fix iOS build.
2956
2957         * WebCoreSupport/WebChromeClientIOS.h:
2958         * WebCoreSupport/WebChromeClientIOS.mm:
2959         * WebCoreSupport/WebFixedPositionContent.mm:
2960         * WebCoreSupport/WebFixedPositionContentInternal.h:
2961
2962 2014-03-30  Dan Bernstein  <mitz@apple.com>
2963
2964         Tried to fix the iOS build.
2965
2966         * Misc/WebGeolocationCoreLocationProvider.mm:
2967         (-[WebGeolocationCoreLocationProvider start]):
2968         (-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]):
2969
2970 2014-03-27  Enrica Casucci  <enrica@apple.com>
2971
2972         Add support for AirPlay picker for iOS.
2973         https://bugs.webkit.org/show_bug.cgi?id=130876
2974         <rdar://problem/15349859>
2975
2976         Reviewed by Benjamin Poulain.
2977
2978         Adds support for the AirPlay picker for WebKit.
2979         The actual picker is implemented in UIKit.
2980
2981         * DefaultDelegates/WebDefaultUIKitDelegate.m:
2982         (-[WebDefaultUIKitDelegate interactionLocation]):
2983         (-[WebDefaultUIKitDelegate showPlaybackTargetPicker:fromRect:]):
2984         * WebCoreSupport/WebChromeClientIOS.mm:
2985         (WebChromeClientIOS::showPlaybackTargetPicker):
2986         * WebCoreSupport/WebFrameIOS.h:
2987         * WebCoreSupport/WebFrameIOS.mm:
2988         (-[WebFrame elementRectAtPoint:]):
2989         * WebView/WebUIKitDelegate.h:
2990
2991 2014-03-27  Enrica Casucci  <enrica@apple.com>
2992
2993         Add support for AirPlay picker in WK2 for iOS.
2994         https://bugs.webkit.org/show_bug.cgi?id=130855
2995         <rdar://problem/15349859>
2996
2997         Reviewed by Eric Carlson, Joseph Pecoraro and Benjamin Poulain.
2998
2999         Adds stub for new WebKit chrome client method.
3000
3001         * WebCoreSupport/WebChromeClientIOS.h:
3002         * WebCoreSupport/WebChromeClientIOS.mm:
3003         (WebChromeClientIOS::showAirPlayRoutePicker):
3004
3005 2014-03-25  Joseph Pecoraro  <pecoraro@apple.com>
3006
3007         [iOS] Inspector View Indication Support
3008         https://bugs.webkit.org/show_bug.cgi?id=130709
3009
3010         Reviewed by Simon Fraser.
3011
3012         * WebCoreSupport/WebInspectorClientIOS.mm:
3013         (WebInspectorClient::showInspectorIndication):
3014         (WebInspectorClient::hideInspectorIndication):
3015         Renamed methods.
3016
3017 2014-03-22  Darin Adler  <darin@apple.com>
3018
3019         Remove String::deprecatedCharacters
3020         https://bugs.webkit.org/show_bug.cgi?id=126854
3021
3022         Reviewed by Sam Weinig.
3023
3024         * Misc/WebNSStringDrawing.h: Added a FIXME about deleting this file; we can probably do it soon.
3025         * Misc/WebNSStringDrawing.mm:
3026         (+[NSString _web_setWordRoundingEnabled:]):
3027         (+[NSString _web_wordRoundingEnabled]):
3028         (+[NSString _web_setWordRoundingAllowed:]):
3029         (+[NSString _web_wordRoundingAllowed]):
3030         (+[NSString _web_setAscentRoundingEnabled:]):
3031         (+[NSString _web_ascentRoundingEnabled]):
3032         (-[NSString _web_drawAtPoint:withFont:]):
3033         (-[NSString _web_sizeWithFont:]):
3034         (-[NSString _web_sizeWithFont:forWidth:ellipsis:]):
3035         (-[NSString _web_sizeWithFont:forWidth:ellipsis:letterSpacing:]):
3036         (-[NSString _web_sizeWithFont:forWidth:ellipsis:letterSpacing:resultRange:]):
3037         (-[NSString _web_drawAtPoint:forWidth:withFont:ellipsis:]):
3038         (-[NSString _web_drawAtPoint:forWidth:withFont:ellipsis:letterSpacing:]):
3039         (-[NSString _web_drawAtPoint:forWidth:withFont:ellipsis:letterSpacing:includeEmoji:]):
3040         (-[NSString _web_drawInRect:withFont:ellipsis:alignment:lineSpacing:includeEmoji:truncationRect:measureOnly:]):
3041         (-[NSString _web_drawInRect:withFont:ellipsis:alignment:lineSpacing:includeEmoji:truncationRect:]):
3042         (-[NSString _web_drawInRect:withFont:ellipsis:alignment:lineSpacing:]):
3043         (-[NSString _web_drawInRect:withFont:ellipsis:alignment:]):
3044         (-[NSString _web_sizeInRect:withFont:ellipsis:lineSpacing:]):
3045         (-[NSString _web_sizeInRect:withFont:ellipsis:]):
3046         (-[NSString _web_stringForWidth:withFont:ellipsis:letterSpacing:includeEmoji:]):
3047         (-[NSString _web_sizeForWidth:withAttributes:]):
3048         (-[NSString _web_drawAtPoint:forWidth:withAttributes:]):
3049         (-[NSString _web_sizeInRect:withAttributes:]):
3050         (-[NSString _web_drawInRect:withAttributes:]):
3051         Emptied out all these functions since callers aren't really using them any more.
3052
3053 2014-03-21  Tim Horton  <timothy_horton@apple.com>
3054
3055         Always retrieve the screen scale factor from WKSI
3056         <rdar://problem/16329679>
3057
3058         Reviewed by Sam Weinig.
3059
3060         * Misc/WebUIKitSupport.mm:
3061         (WebKitSetIsClassic): Empty this out; it's no longer needed, but will still be called.
3062
3063 2014-03-19  Tim Horton  <timothy_horton@apple.com>
3064
3065         [iOS] WebPDFViewPlaceholder divides-by-zero with an empty document
3066         https://bugs.webkit.org/show_bug.cgi?id=130444
3067         <rdar://problem/15580682>
3068
3069         Reviewed by Sam Weinig.
3070
3071         * WebView/WebPDFViewPlaceholder.h:
3072         * WebView/WebPDFViewPlaceholder.mm:
3073         (-[WebPDFViewPlaceholder layout]):
3074         Get rid of boundingSize, it's never assigned to anything but CGSizeZero,
3075         which is confusing.
3076
3077         Don't divide by zero if we have no pages, instead return an empty bounding size.
3078
3079         (-[WebPDFViewPlaceholder _computePageRects:]):
3080         If we have an empty document, set the background color to white.
3081         Otherwise, set it to black. It's not clear that black is the ideal
3082         background color, but this retains existing behavior.
3083
3084 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
3085
3086         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
3087         https://bugs.webkit.org/show_bug.cgi?id=130276
3088         <rdar://problem/16266927>
3089         
3090         Reviewed by Simon Fraser.
3091
3092         * WebCoreSupport/WebCaretChangeListener.h:
3093         * WebCoreSupport/WebInspectorClientIOS.mm:
3094         * WebView/WebPlainWhiteView.h:
3095         * WebView/WebPlainWhiteView.mm:
3096
3097 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
3098
3099         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
3100         https://bugs.webkit.org/show_bug.cgi?id=129612
3101
3102         Reviewed by Darin Adler.
3103
3104         For new code use static NeverDestroyed<T> instead.
3105
3106         * Misc/EmojiFallbackFontSelector.cpp:
3107         (EmojiFallbackFontSelector::getFallbackFontData):
3108         * WebCoreSupport/WebFixedPositionContent.mm:
3109         (WebFixedPositionContentDataLock):
3110
3111 2014-03-13  Benjamin Poulain  <bpoulain@apple.com>
3112
3113         The viewport code should not depend on WebKitSystemInterface
3114         https://bugs.webkit.org/show_bug.cgi?id=130218
3115
3116         Reviewed by Tim Horton.
3117
3118         * WebCoreSupport/WebChromeClientIOS.h:
3119         * WebCoreSupport/WebChromeClientIOS.mm:
3120         (WebChromeClientIOS::viewportScreenSize):
3121         Get the viewport size from WebKitSystemInterface.
3122
3123 2014-03-12  Enrica Casucci  <enrica@apple.com>
3124
3125         Incorrect reference counting of Range in WebFrame.
3126         https://bugs.webkit.org/show_bug.cgi?id=130160
3127         <rdar://problem/16282535>
3128
3129         Reviewed by Anders Carlsson.
3130
3131         * WebCoreSupport/WebFrameIOS.mm:
3132         (-[WebFrame selectionRects]):
3133
3134 2014-03-12  Simon Fraser  <simon.fraser@apple.com>
3135
3136         Spelling is hard
3137         https://bugs.webkit.org/show_bug.cgi?id=130146
3138
3139         Reviewed by Beth Dakin.
3140         
3141         Fix spelling (constained -> constrained).
3142
3143         * WebCoreSupport/WebFixedPositionContent.mm:
3144         (-[WebFixedPositionContent scrollOrZoomChanged:]):
3145         (-[WebFixedPositionContent overflowScrollPositionForLayer:changedTo:]):
3146         (-[WebFixedPositionContent setViewportConstrainedLayers:WTF::WebCore::stickyContainerMap:WTF::]):
3147         (-[WebFixedPositionContent hasFixedOrStickyPositionLayers]):
3148         (-[WebFixedPositionContent minimumOffsetFromFixedPositionLayersToAnchorEdge:ofRect:inLayer:]):
3149
3150 2014-02-17  Sergio Correia  <sergio.correia@openbossa.org>
3151
3152         Replace uses of PassOwnPtr/OwnPtr with std::unique_ptr in WebCore/inspector
3153         https://bugs.webkit.org/show_bug.cgi?id=128681
3154
3155         Reviewed by Timothy Hatcher.
3156
3157         Another step towards getting rid of PassOwnPtr/OwnPtr, now targeting
3158         WebCore/inspector/*. Besides files in there, a few other files in
3159         JavaScriptCore/inspector, WebKit/, WebKit2/WebProcess/WebCoreSupport/
3160         and WebCore/testing were touched.
3161
3162         * WebCoreSupport/WebInspectorClientIOS.mm:
3163
3164 2014-02-12  Benjamin Poulain  <bpoulain@apple.com>
3165
3166         [WK2][iOS] Add back the special viewport for the old xhtml mobile doctype
3167         https://bugs.webkit.org/show_bug.cgi?id=128639
3168
3169         Reviewed by Andreas Kling.
3170
3171         * WebCoreSupport/WebChromeClientIOS.h:
3172         * WebCoreSupport/WebChromeClientIOS.mm:
3173         (WebChromeClientIOS::didReceiveMobileDocType):
3174
3175 2014-02-08  Ryosuke Niwa  <rniwa@webkit.org>
3176
3177         Build fix after r163739.
3178
3179         * WebCoreSupport/WebFrameIOS.mm:
3180         (-[WebFrame collapseSelection]):
3181         (-[WebFrame aggressivelyExpandSelectionToWordContainingCaretSelection]):
3182
3183 2014-02-03  Dan Bernstein  <mitz@apple.com>
3184
3185         More iOS build fixing.
3186
3187         * Misc/WebNSStringDrawing.mm:
3188         (-[NSString __web_drawAtPoint:forWidth:withFont:ellipsis:letterSpacing:includeEmoji:measureOnly:renderedStringOut:drawUnderline:]):
3189         (-[NSString __web_drawInRect:withFont:ellipsis:alignment:letterSpacing:lineSpacing:includeEmoji:truncationRect:measureOnly:renderedStringOut:drawUnderline:]):
3190
3191 2014-01-31  Ryosuke Niwa  <rniwa@webkit.org>
3192
3193         Remove inline member functions of FrameSelection that access m_selection
3194         https://bugs.webkit.org/show_bug.cgi?id=127986
3195
3196         Reviewed by Enrica Casucci.
3197
3198         * WebCoreSupport/WebFrameIOS.mm:
3199         (-[WebFrame extendSelection:]):
3200         (-[WebFrame ensureRangedSelectionContainsInitialStartPoint:initialEndPoint:]):
3201         (-[WebFrame aggressivelyExpandSelectionToWordContainingCaretSelection]):
3202         (-[WebFrame expandSelectionToSentence]):
3203         (-[WebFrame setBaseWritingDirection:]):
3204         (-[WebFrame smartExtendRangedSelection:]):
3205
3206 2014-01-30  Andrei Bucur  <abucur@adobe.com>
3207
3208         Remove the ACCELERATED_COMPOSITING flag
3209         https://bugs.webkit.org/show_bug.cgi?id=127833
3210
3211         Reviewed by Antti Koivisto.
3212
3213         Remove the USE(ACCELERATED_COMPOSITING) conditionals from the code base and make AC
3214         mandatory.
3215
3216         * WebCoreSupport/WebChromeClientIOS.h:
3217         * WebCoreSupport/WebChromeClientIOS.mm:
3218         (WebChromeClientIOS::attachRootGraphicsLayer):
3219         * WebView/WebUIKitDelegate.h:
3220
3221 2014-01-27  Joseph Pecoraro  <pecoraro@apple.com>
3222
3223         Unreviewed iOS build fix. FALLTHROUGHs for iOS.
3224
3225         * Misc/WebNSStringDrawing.mm:
3226         (needsBidiLayout):
3227
3228 2014-01-27  Andy Estes  <aestes@apple.com>
3229
3230         Scrub WebKit API headers of WTF macros
3231         https://bugs.webkit.org/show_bug.cgi?id=127706
3232
3233         Reviewed by David Kilzer.
3234
3235         * WebCoreSupport/WebMIMETypeRegistry.h: Changed PLATFORM(IOS) to
3236         TARGET_OS_IPHONE.
3237
3238 2014-01-15  Sam Weinig  <sam@webkit.org>
3239
3240         TextBreakIterator's should support Latin-1 for all iterator types (Part 3)
3241         https://bugs.webkit.org/show_bug.cgi?id=126856
3242
3243         Reviewed by Ryosuke Niwa.
3244
3245         Change all the TextBreakIterator creation functions to take StringViews. Remove a few
3246         now unnecessary up-conversions to UTF-16 in the process.
3247
3248         * Misc/WebNSStringDrawing.mm:
3249
3250 2014-01-16  Anders Carlsson  <andersca@apple.com>
3251
3252         Change all uses of FINAL to final now that all our compilers support it
3253         https://bugs.webkit.org/show_bug.cgi?id=127142
3254
3255         Reviewed by Benjamin Poulain.
3256
3257         * WebCoreSupport/WebDiskImageCacheClientIOS.h:
3258
3259 2014-01-16  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3260
3261         Remove workaround for compilers not supporting explicit override control
3262         https://bugs.webkit.org/show_bug.cgi?id=127111
3263
3264         Reviewed by Anders Carlsson.
3265
3266         Now all compilers support explicit override control, this workaround can be removed.
3267
3268         * Misc/EmojiFallbackFontSelector.h:
3269         * Storage/WebSQLiteDatabaseTrackerClient.h:
3270         * WebCoreSupport/PopupMenuIOS.h:
3271         * WebCoreSupport/SearchPopupMenuIOS.h:
3272         * WebCoreSupport/WebChromeClientIOS.h:
3273         * WebCoreSupport/WebDiskImageCacheClientIOS.h:
3274
3275 2014-01-16  Andy Estes  <aestes@apple.com>
3276
3277         [iOS] Fix build issues with exported headers
3278
3279         * Misc/WebNSStringExtrasIOS.h: Changed PLATFORM(IOS) to
3280         TARGET_OS_IPHONE.
3281
3282 2014-01-14  Simon Fraser  <simon.fraser@apple.com>
3283
3284         Avoid PLATFORM() macros in exported headers.
3285
3286         * WebView/WebPDFViewPlaceholder.h:
3287
3288 2014-01-14  Simon Fraser  <simon.fraser@apple.com>
3289
3290         Clean up exports and headers for iOS.
3291
3292         * Misc/WebNSStringDrawing.h: Don't use PLATFORM() macro in an exported header.
3293         * WebCoreSupport/WebFrameIOS.h: Ditto.
3294         * WebCoreSupport/WebSelectionRect.h: Ditto.
3295
3296 2014-01-14  Dean Jackson  <dino@apple.com>
3297
3298         Remove .objc_class_name_WebInspectorXPCWrapper from export on iOS build.
3299
3300         * WebKit.iOS.exp:
3301
3302 2014-01-14  Simon Fraser  <simon.fraser@apple.com>
3303
3304         Fix WK1 iOS build: need implementations of these functions in WebInspectorClientIOS.
3305
3306         * WebCoreSupport/WebInspectorClientIOS.mm:
3307         (WebInspectorClient::indicate):
3308         (WebInspectorClient::hideIndication):
3309
3310 2014-01-13  Simon Fraser  <simon.fraser@apple.com>
3311
3312         More work towards getting iOS WK1 building.
3313
3314         * WebCoreSupport/WebFrameIOS.mm:
3315         (-[WebFrame imageForNode:allowDownsampling:drawContentBehindTransparentNodes:]): Stub out this
3316         function, since it should use recently-refactored node snapshotting code. Covered by <rdar://problem/15808709>.
3317
3318 2014-01-12  Darin Adler  <darin@apple.com>
3319
3320         Add type checking to isEqual methods
3321         https://bugs.webkit.org/show_bug.cgi?id=126862
3322
3323         Reviewed by Anders Carlsson.
3324
3325         * WebCoreSupport/WebVisiblePosition.mm:
3326         (-[WebVisiblePosition isEqual:]): Add type checking on the argument.
3327         Add a FIXME about the lack of a hash method override. Simplified by
3328         removing the unneeded local variables.
3329
3330 2014-01-02  Andy Estes  <aestes@apple.com>
3331
3332         [iOS] Upstream remainder of minimal-ui viewport changes
3333         https://bugs.webkit.org/show_bug.cgi?id=126410
3334
3335         Reviewed by Sam Weinig.
3336
3337         * WebCoreSupport/WebChromeClientIOS.mm:
3338         (dictionaryForViewportArguments):
3339         * WebKit.iOS.exp:
3340
3341 2013-12-31  Andy Estes  <aestes@apple.com>
3342
3343         [iOS] Upstream PLATFORM(IOS) changes to Source/WebKit/
3344         https://bugs.webkit.org/show_bug.cgi?id=125746
3345
3346         Reviewed by David Kilzer.
3347
3348         * WebCoreSupport/WebVisiblePosition.mm:
3349         (-[WebVisiblePosition positionAtStartOrEndOfWord]): Changed a comment
3350         to mention iOS rather than iPhone.
3351
3352 2013-12-27  Daniel Bates  <dabates@apple.com>
3353
3354         [iOS] Upstream WebCore/page changes
3355         https://bugs.webkit.org/show_bug.cgi?id=126180
3356
3357         Reviewed by Darin Adler.
3358
3359         * WebCoreSupport/WebChromeClientIOS.mm: Substitute ENABLE(IOS_TOUCH_EVENTS) for ENABLE(TOUCH_EVENTS).
3360
3361 2013-12-04  Brian J. Burg  <burg@cs.washington.edu>
3362
3363         Consolidate various frame snapshot capabilities.
3364         https://bugs.webkit.org/show_bug.cgi?id=124325
3365
3366         Reviewed by Darin Adler.
3367
3368         * WebCoreSupport/WebFrameIOS.mm: use new header file.
3369
3370 2013-12-04  Andy Estes  <aestes@apple.com>
3371
3372         [iOS] Upstream build fixes in Source/WebKit/ios/
3373         https://bugs.webkit.org/show_bug.cgi?id=125230
3374
3375         Reviewed by Sam Weinig.
3376
3377         * DefaultDelegates/WebDefaultUIKitDelegate.m:
3378         (-[WebDefaultUIKitDelegate webViewDidReceiveMobileDocType:]):
3379         * Misc/WebNSStringDrawing.mm:
3380         (needsBidiLayout):
3381         (-[NSString __web_drawAtPoint:forWidth:withFont:ellipsis:letterSpacing:includeEmoji:measureOnly:renderedStringOut:drawUnderline:]):
3382         (-[NSString __web_drawInRect:withFont:ellipsis:alignment:letterSpacing:lineSpacing:includeEmoji:truncationRect:measureOnly:renderedStringOut:drawUnderline:]):
3383         * Misc/WebUIKitSupport.mm:
3384         (WebKitInitialize):
3385         * WebCoreSupport/WebChromeClientIOS.h:
3386         * WebCoreSupport/WebChromeClientIOS.mm:
3387         (WebChromeClientIOS::didReceiveMobileDocType):
3388         (WebChromeClientIOS::focusedElementChanged):
3389         * WebCoreSupport/WebFrameIOS.mm:
3390         (-[WebFrame clearSelection]):
3391         (-[WebFrame selectionState]):
3392         (-[WebFrame collapseSelection]):
3393         (-[WebFrame extendSelection:]):
3394         (-[WebFrame selectionRects]):
3395         (-[WebFrame setRangedSelectionWithExtentPoint:]):
3396         (-[WebFrame setRangedSelectionExtentPoint:baseIsStart:allowFlipping:]):
3397         (-[WebFrame setSelectionWithBasePoint:extentPoint:baseIsStart:allowFlipping:]):
3398         (-[WebFrame setSelectionWithFirstPoint:secondPoint:]):
3399         (-[WebFrame ensureRangedSelectionContainsInitialStartPoint:initialEndPoint:]):
3400         (-[WebFrame aggressivelyExpandSelectionToWordContainingCaretSelection]):
3401         (-[WebFrame expandSelectionToSentence]):
3402         (-[WebFrame setBaseWritingDirection:]):
3403         (-[WebFrame moveSelectionToStart]):
3404         (-[WebFrame moveSelectionToEnd]):
3405         (-[WebFrame moveSelectionToPoint:]):
3406         (-[WebFrame setSelectionGranularity:]):
3407         (-[WebFrame smartExtendRangedSelection:]):
3408         (-[WebFrame previousUnperturbedDictationResultBoundaryFromPosition:]):
3409         (-[WebFrame nextUnperturbedDictationResultBoundaryFromPosition:]):
3410         * WebCoreSupport/WebInspectorClientIOS.mm:
3411         (WebInspectorClient::WebInspectorClient):
3412         (WebInspectorClient::didSetSearchingForNode):
3413         (WebInspectorClient::setupRemoteConnection):
3414         (WebInspectorClient::teardownRemoteConnection):
3415         * WebCoreSupport/WebVisiblePosition.mm:
3416         (-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]):
3417         (-[WebVisiblePosition enclosingRangeWithCorrectionIndicator]):
3418         (-[DOMHTMLInputElement startPosition]):
3419         (-[DOMHTMLInputElement endPosition]):
3420         (-[DOMHTMLTextAreaElement startPosition]):
3421         (-[DOMHTMLTextAreaElement endPosition]):
3422         * WebView/WebPDFViewIOS.mm:
3423         (+[WebPDFView shadowColor]):
3424         (+[WebPDFView backgroundColor]):
3425         (-[WebPDFView _checkPDFTitle]):
3426         * WebView/WebPDFViewPlaceholder.mm:
3427         (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
3428         * WebView/WebUIKitDelegate.h:
3429
3430 2013-12-03  Joseph Pecoraro  <pecoraro@apple.com>
3431
3432         Web Inspector: Push Remote Inspector debugging connection management into JavaScriptCore
3433         https://bugs.webkit.org/show_bug.cgi?id=124613
3434
3435         Reviewed by Timothy Hatcher.
3436
3437         * WebCoreSupport/WebInspectorClientIOS.mm:
3438         (WebInspectorClient::WebInspectorClient):
3439         (WebInspectorClient::inspectorDestroyed):
3440
3441 2013-12-03  Ralph Thomas  <ralpht@gmail.com>
3442
3443         Typo: FixedPositionConstaint -> FixedPositionConstraint
3444         https://bugs.webkit.org/show_bug.cgi?id=125171
3445
3446         Reviewed by Simon Fraser.
3447
3448         * WebCoreSupport/WebFixedPositionContent.mm:
3449         (-[WebFixedPositionContent scrollOrZoomChanged:]):
3450
3451 2013-11-18  Commit Queue  <commit-queue@webkit.org>
3452
3453         Unreviewed, rolling out r159455.
3454         http://trac.webkit.org/changeset/159455
3455         https://bugs.webkit.org/show_bug.cgi?id=124568
3456
3457         broke two api tests (see bug 124564) (Requested by thorton on
3458         #webkit).
3459
3460         * WebCoreSupport/WebFrameIOS.mm:
3461
3462 2013-11-18  Brian J. Burg  <burg@cs.washington.edu>
3463
3464         Consolidate various frame snapshot capabilities.
3465         https://bugs.webkit.org/show_bug.cgi?id=124325
3466
3467         Reviewed by Timothy Hatcher.
3468
3469         * WebCoreSupport/WebFrameIOS.mm: use new header file.
3470
3471 2013-11-07  Joseph Pecoraro  <pecoraro@apple.com>
3472
3473         Remove a PLATFORM(IOS) from WebKit Private Header
3474         https://bugs.webkit.org/show_bug.cgi?id=124014
3475
3476         Reviewed by Timothy Hatcher.
3477
3478         * WebKit.iOS.exp:
3479
3480 2013-10-29  Andy Estes  <aestes@apple.com>
3481
3482         [iOS] Upstream Source/WebKit/ios/
3483         https://bugs.webkit.org/show_bug.cgi?id=123470
3484
3485         Reviewed by Sam Weinig.
3486
3487         * DefaultDelegates/WebDefaultFormDelegate.h: Added.
3488         * DefaultDelegates/WebDefaultFormDelegate.m: Added.
3489         * DefaultDelegates/WebDefaultFrameLoadDelegate.h: Added.
3490         * DefaultDelegates/WebDefaultFrameLoadDelegate.m: Added.
3491         * DefaultDelegates/WebDefaultResourceLoadDelegate.h: Added.
3492         * DefaultDelegates/WebDefaultResourceLoadDelegate.m: Added.
3493         * DefaultDelegates/WebDefaultUIKitDelegate.h: Added.
3494         * DefaultDelegates/WebDefaultUIKitDelegate.m: Added.
3495         * Misc/EmojiFallbackFontSelector.cpp: Added.
3496         * Misc/EmojiFallbackFontSelector.h: Added.
3497         * Misc/MemoryMeasure.h: Added.
3498         * Misc/MemoryMeasure.mm: Added.
3499         * Misc/WebGeolocationCoreLocationProvider.h: Added.
3500         * Misc/WebGeolocationCoreLocationProvider.mm: Added.
3501         * Misc/WebGeolocationProviderIOS.h: Added.
3502         * Misc/WebGeolocationProviderIOS.mm: Added.
3503         * Misc/WebNSStringDrawing.h: Added.
3504         * Misc/WebNSStringDrawing.mm: Added.
3505         * Misc/WebNSStringExtrasIOS.h: Added.
3506         * Misc/WebNSStringExtrasIOS.m: Added.
3507         * Misc/WebNSStringExtrasIPhone.h: Added.
3508         * Misc/WebUIKitSupport.h: Added.
3509         * Misc/WebUIKitSupport.mm: Added.
3510         * Storage/WebSQLiteDatabaseTrackerClient.h: Added.
3511         * Storage/WebSQLiteDatabaseTrackerClient.mm: Added.
3512         * WebCoreSupport/PopupMenuIOS.h: Added.
3513         * WebCoreSupport/PopupMenuIOS.mm: Added.
3514         * WebCoreSupport/SearchPopupMenuIOS.cpp: Added.
3515         * WebCoreSupport/SearchPopupMenuIOS.h: Added.
3516         * WebCoreSupport/WebCaretChangeListener.h: Added.
3517         * WebCoreSupport/WebChromeClientIOS.h: Added.
3518         * WebCoreSupport/WebChromeClientIOS.mm: Added.
3519         * WebCoreSupport/WebFixedPositionContent.h: Added.
3520         * WebCoreSupport/WebFixedPositionContent.mm: Added.
3521         * WebCoreSupport/WebFixedPositionContentInternal.h: Added.
3522         * WebCoreSupport/WebFrameIOS.h: Added.
3523         * WebCoreSupport/WebFrameIOS.mm: Added.
3524         * WebCoreSupport/WebFrameIPhone.h: Added.
3525         * WebCoreSupport/WebGeolocation.mm: Added.
3526         * WebCoreSupport/WebGeolocationInternal.h: Added.
3527         * WebCoreSupport/WebGeolocationPrivate.h: Added.
3528         * WebCoreSupport/WebMIMETypeRegistry.h: Added.
3529         * WebCoreSupport/WebMIMETypeRegistry.mm: Added.
3530         * WebCoreSupport/WebSelectionRect.h: Added.
3531         * WebCoreSupport/WebSelectionRect.m: Added.
3532         * WebCoreSupport/WebVisiblePosition.h: Added.
3533         * WebCoreSupport/WebVisiblePosition.mm: Added.
3534         * WebCoreSupport/WebVisiblePositionInternal.h: Added.
3535         * WebKit.iOS.exp: Added.
3536         * WebView/WebFrameViewWAKCompatibility.m: Added.
3537         * WebView/WebMailDelegate.h: Added.
3538         * WebView/WebPDFViewIOS.h: Added.
3539         * WebView/WebPDFViewIOS.mm: Added.
3540         * WebView/WebPDFViewIPhone.h: Added.
3541         * WebView/WebPDFViewPlaceholder.h: Added.
3542         * WebView/WebPDFViewPlaceholder.mm: Added.
3543         * WebView/WebPlainWhiteView.h: Added.
3544         * WebView/WebPlainWhiteView.mm: Added.
3545         * WebView/WebUIKitDelegate.h: Added.
3546
3547 2013-10-25  Joseph Pecoraro  <pecoraro@apple.com>
3548
3549         Upstream ENABLE(REMOTE_INSPECTOR) and enable on iOS and Mac
3550         https://bugs.webkit.org/show_bug.cgi?id=123111
3551
3552         Reviewed by Timothy Hatcher.
3553
3554         iOS does not have a local inspector, only remote. So give it a custom
3555         implementation separate from the WebKit/mac WebInspectorClient
3556         implementation which handles an attaching/detaching local inspector.
3557
3558         * WebKit.xcodeproj/project.pbxproj:
3559         * ios/WebCoreSupport/WebInspectorClientIOS.mm: Added.
3560         (WebInspectorClient::WebInspectorClient):
3561         (WebInspectorClient::inspectorDestroyed):
3562         (WebInspectorClient::openInspectorFrontend):
3563         (WebInspectorClient::bringFrontendToFront):
3564         (WebInspectorClient::closeInspectorFrontend):
3565         (WebInspectorClient::didResizeMainFrame):
3566         (WebInspectorClient::highlight):
3567         (WebInspectorClient::hideHighlight):
3568         (WebInspectorClient::didSetSearchingForNode):
3569         (WebInspectorClient::sendMessageToFrontend):
3570         (WebInspectorClient::sendMessageToBackend):
3571         (WebInspectorClient::setupRemoteConnection):
3572         (WebInspectorClient::teardownRemoteConnection):
3573         (WebInspectorClient::hasLocalSession):
3574         (WebInspectorClient::canBeRemotelyInspected):
3575         (WebInspectorClient::inspectedWebView):
3576         (WebInspectorFrontendClient::WebInspectorFrontendClient):
3577         (WebInspectorFrontendClient::attachAvailabilityChanged):
3578         (WebInspectorFrontendClient::frontendLoaded):
3579         (WebInspectorFrontendClient::localizedStringsURL):
3580         (WebInspectorFrontendClient::bringToFront):
3581         (WebInspectorFrontendClient::closeWindow):
3582         (WebInspectorFrontendClient::disconnectFromBackend):
3583         (WebInspectorFrontendClient::attachWindow):
3584         (WebInspectorFrontendClient::detachWindow):
3585         (WebInspectorFrontendClient::setAttachedWindowHeight):
3586         (WebInspectorFrontendClient::setAttachedWindowWidth):
3587         (WebInspectorFrontendClient::setToolbarHeight):
3588         (WebInspectorFrontendClient::inspectedURLChanged):
3589         (WebInspectorFrontendClient::updateWindowTitle):
3590         (WebInspectorFrontendClient::save):
3591         (WebInspectorFrontendClient::append):