619521a68eb67ba7cb0ffe054a96a157e8352f46
[WebKit-https.git] / Source / WebKit2 / ChangeLog
1 2011-06-10  Sam Weinig  <sam@webkit.org>
2
3         Reviewed by Anders Carlsson.
4
5         Unresponsive cursor is shown when displaying a modal dialog
6         Part of <rdar://problem/9581492>
7         https://bugs.webkit.org/show_bug.cgi?id=62494
8
9         * UIProcess/WebPageProxy.cpp:
10         (WebKit::WebPageProxy::runModal):
11         * UIProcess/WebPageProxy.h:
12         Stop the responsiveness timer when calling out to show a modal dialog.
13
14 2011-06-10  Tony Chang  <tony@chromium.org>
15
16         Reviewed by Ojan Vafai.
17
18         add a compile guard ENABLE(FLEXBOX)
19         https://bugs.webkit.org/show_bug.cgi?id=62049
20
21         * Configurations/FeatureDefines.xcconfig:
22
23 2011-06-10  Ryuan Choi  <ryuan.choi@samsung.com>
24
25         Reviewed by Kenneth Rohde Christiansen.
26
27         [EFL][WK2] Add dummy files in WebProcess/WebCoreSupport/efl
28         https://bugs.webkit.org/show_bug.cgi?id=62346
29
30         Add WebProcess/WebCoreSupport/efl directory and files.
31
32         * WebProcess/WebCoreSupport/efl/WebContextMenuClientEfl.cpp: Added.
33         (WebKit::WebContextMenuClient::lookUpInDictionary):
34         (WebKit::WebContextMenuClient::isSpeaking):
35         (WebKit::WebContextMenuClient::speak):
36         (WebKit::WebContextMenuClient::stopSpeaking):
37         * WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp: Added.
38         (WebKit::WebEditorClient::handleKeyboardEvent):
39         (WebKit::WebEditorClient::handleInputMethodKeydown):
40         * WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp: Added.
41         (WebKit::cancelledError):
42         (WebKit::blockedError):
43         (WebKit::cannotShowURLError):
44         (WebKit::interruptForPolicyChangeError):
45         (WebKit::cannotShowMIMETypeError):
46         (WebKit::fileDoesNotExistError):
47         (WebKit::pluginWillHandleLoadError):
48         * WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h: Added.
49         (WebFrameNetworkingContext::create):
50         (WebFrameNetworkingContext::WebFrameNetworkingContext):
51         * WebProcess/WebCoreSupport/efl/WebPopupMenuEfl.cpp: Added.
52         (WebKit::WebPopupMenu::setUpPlatformData):
53
54 2011-06-09  Andreas Kling  <kling@webkit.org>
55
56         Reviewed by Darin Adler.
57
58         WebKit2: Remove unused function CoreIPC::Connection::deprecatedWaitFor().
59         https://bugs.webkit.org/show_bug.cgi?id=62386
60
61         * Platform/CoreIPC/Connection.h:
62
63 2011-06-09  Andreas Kling  <kling@webkit.org>
64
65         Reviewed by Anders Carlsson.
66
67         [Qt][WK2] Remove usage of deprecated CoreIPC functions.
68         https://bugs.webkit.org/show_bug.cgi?id=62290
69
70         Use the new DrawingArea{,Proxy}.messages.in approach to CoreIPC in TiledDrawingArea.
71         The TiledDrawingArea{,Proxy}-specific messages were moved up into DrawingArea{,Proxy}
72         and guarded by ENABLE(TILED_BACKING_STORE).
73
74         * Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: Removed.
75         * Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: Removed.
76
77         * GNUmakefile.am:
78         * WebKit2.pro:
79         * WebKit2.xcodeproj/project.pbxproj:
80         * win/WebKit2.vcproj: Prune deleted files from build system.
81
82         * Platform/CoreIPC/MessageID.h: Remove legacy DrawingArea message ID's.
83
84         * UIProcess/API/qt/qgraphicswkview.cpp:
85         (QGraphicsWKViewPrivate::commitScale): No longer waits for all tile updates to complete,
86         this will be addressed by the soon-to-be-upstreamed TileSet mechanism.
87
88         * UIProcess/DrawingAreaProxy.messages.in:
89         * UIProcess/DrawingAreaProxy.h:
90         (WebKit::DrawingAreaProxy::didSetSize):
91         (WebKit::DrawingAreaProxy::invalidate):
92         (WebKit::DrawingAreaProxy::snapshotTaken):
93         (WebKit::DrawingAreaProxy::tileUpdated):
94         (WebKit::DrawingAreaProxy::allTileUpdatesProcessed): Added IPC calls used by
95         TiledDrawingAreaProxy to DrawingAreaProxy.
96
97         * WebProcess/WebPage/DrawingArea.messages.in:
98         * WebProcess/WebPage/DrawingArea.h:
99         (WebKit::DrawingArea::setSize):
100         (WebKit::DrawingArea::cancelTileUpdate):
101         (WebKit::DrawingArea::requestTileUpdate):
102         (WebKit::DrawingArea::takeSnapshot): Added IPC calls used by TiledDrawingArea
103         to DrawingArea.
104
105         * UIProcess/DrawingAreaProxyImpl.h:
106         * UIProcess/DrawingAreaProxyImpl.cpp: Remove the now-unneeded didReceiveMessage()
107         and didReceiveSyncMessage().
108
109         * WebProcess/WebPage/DrawingAreaImpl.cpp:
110         * WebProcess/WebPage/DrawingAreaImpl.h: Remove the now-unneeded didReceiveMessage().
111
112         * UIProcess/TiledDrawingAreaProxy.h:
113         * UIProcess/TiledDrawingAreaProxy.cpp:
114         (WebKit::TiledDrawingAreaProxy::sizeDidChange):
115         (WebKit::TiledDrawingAreaProxy::tileUpdated):
116         (WebKit::TiledDrawingAreaProxy::allTileUpdatesProcessed): Split didReceiveMessage()
117         into functions.
118
119         (WebKit::TiledDrawingAreaProxy::removeTile):
120         (WebKit::TiledDrawingAreaProxy::requestTileUpdate):
121         (WebKit::TiledDrawingAreaProxy::setPageIsVisible):
122         (WebKit::TiledDrawingAreaProxy::takeSnapshot): Use new-style IPC.
123
124         * WebProcess/WebPage/TiledDrawingArea.cpp:
125         (WebKit::TiledDrawingArea::setSize):
126         (WebKit::TiledDrawingArea::cancelTileUpdate):
127         (WebKit::TiledDrawingArea::requestTileUpdate):
128         (WebKit::TiledDrawingArea::takeSnapshot): Split didReceiveMessage() into functions.
129
130         (WebKit::TiledDrawingArea::display):
131         (WebKit::TiledDrawingArea::updateTile):
132         (WebKit::TiledDrawingArea::tileUpdateTimerFired): Use new-style IPC.
133
134         * UIProcess/WebPageProxy.cpp:
135         (WebKit::WebPageProxy::didReceiveMessage): Remove handling of
136         CoreIPC::MessageClassDrawingAreaProxyLegacy.
137
138         * WebProcess/WebPage/WebPage.cpp:
139         (WebKit::WebPage::didReceiveMessage): Remove handling of
140         CoreIPC::MessageClassDrawingAreaLegacy.
141
142         * UIProcess/qt/TiledDrawingAreaProxyQt.cpp: Remove unneeded includes.
143
144         * WebProcess/WebPage/TiledDrawingArea.h: Remove didReceiveMessage() and make
145         CoreIPC message handlers explicitly virtual.
146
147 2011-06-09  Andreas Kling  <kling@webkit.org>
148
149         Reviewed by Anders Carlsson.
150
151         WebKit2: Generate correct header conditionals in message receivers.
152         https://bugs.webkit.org/show_bug.cgi?id=62379
153
154         Given a *.messages.in file like this:
155
156         Foo(AwesomeObject o)
157         #if ENABLE(ESOTERIC_FEATURE)
158         Bar(AwesomeObject o)
159         #endif
160
161         messages.py would include AwesomeObject.h only #if ENABLE(ESOTERIC_FEATURE).
162         This breaks the build on platforms without that defined.
163
164         Furthermore, if two messages guarded by different conditionals both pull in the same
165         header, only the last conditional will be applied, for example:
166
167         #if ENABLE(ESOTERIC_FEATURE)
168         Foo(AwesomeObject o)
169         #endif
170         #if ENABLE(MYSTERIOUS_FEATURE)
171         Bar(AwesomeObject o)
172         #endif
173
174         Would include AwesomeObject.h #if ENABLE(MYSTERIOUS_FEATURE) when it really should
175         check #if ENABLE(ESOTERIC_FEATURE) || ENABLE(MYSTERIOUS_FEATURE).
176
177         Change the generator to consider all conditionals for a given header file.
178         Also consider conditionals for reply parameters.
179
180         * Scripts/webkit2/messages.py:
181         * Scripts/webkit2/messages_unittest.py:
182
183 2011-06-09  Eunmi Lee  <eunmi15.lee@samsung.com>
184
185         Reviewed by Kenneth Rohde Christiansen.
186
187         [EFL][WK2] Add PageClientImpl and WebPageProxyEfl for efl port
188         https://bugs.webkit.org/show_bug.cgi?id=62363
189
190         * UIProcess/API/efl/PageClientImpl.cpp: Added.
191         (WebKit::PageClientImpl::PageClientImpl):
192         (WebKit::PageClientImpl::~PageClientImpl):
193         (WebKit::PageClientImpl::createDrawingAreaProxy):
194         (WebKit::PageClientImpl::setViewNeedsDisplay):
195         (WebKit::PageClientImpl::displayView):
196         (WebKit::PageClientImpl::scrollView):
197         (WebKit::PageClientImpl::viewSize):
198         (WebKit::PageClientImpl::isViewWindowActive):
199         (WebKit::PageClientImpl::isViewFocused):
200         (WebKit::PageClientImpl::isViewVisible):
201         (WebKit::PageClientImpl::isViewInWindow):
202         (WebKit::PageClientImpl::processDidCrash):
203         (WebKit::PageClientImpl::didRelaunchProcess):
204         (WebKit::PageClientImpl::pageClosed):
205         (WebKit::PageClientImpl::toolTipChanged):
206         (WebKit::PageClientImpl::setCursor):
207         (WebKit::PageClientImpl::setViewportArguments):
208         (WebKit::PageClientImpl::registerEditCommand):
209         (WebKit::PageClientImpl::clearAllEditCommands):
210         (WebKit::PageClientImpl::canUndoRedo):
211         (WebKit::PageClientImpl::executeUndoRedo):
212         (WebKit::PageClientImpl::convertToDeviceSpace):
213         (WebKit::PageClientImpl::convertToUserSpace):
214         (WebKit::PageClientImpl::windowToScreen):
215         (WebKit::PageClientImpl::doneWithKeyEvent):
216         (WebKit::PageClientImpl::createPopupMenuProxy):
217         (WebKit::PageClientImpl::createContextMenuProxy):
218         (WebKit::PageClientImpl::setFindIndicator):
219         (WebKit::PageClientImpl::didChangeScrollbarsForMainFrame):
220         (WebKit::PageClientImpl::didCommitLoadForMainFrame):
221         (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
222         (WebKit::PageClientImpl::customRepresentationZoomFactor):
223         (WebKit::PageClientImpl::setCustomRepresentationZoomFactor):
224         (WebKit::PageClientImpl::flashBackingStoreUpdates):
225         (WebKit::PageClientImpl::findStringInCustomRepresentation):
226         (WebKit::PageClientImpl::countStringMatchesInCustomRepresentation):
227         (WebKit::PageClientImpl::userSpaceScaleFactor):
228         * UIProcess/API/efl/PageClientImpl.h: Added.
229         (WebKit::PageClientImpl::create):
230         (WebKit::PageClientImpl::viewObject):
231         (WebKit::PageClientImpl::page):
232         * UIProcess/WebPageProxy.h:
233         * UIProcess/efl/WebPageProxyEfl.cpp: Added.
234         (WebKit::WebPageProxy::viewObject):
235         (WebKit::WebPageProxy::standardUserAgent):
236         (WebKit::WebPageProxy::getEditorCommandsForKeyEvent):
237         (WebKit::WebPageProxy::saveRecentSearches):
238         (WebKit::WebPageProxy::loadRecentSearches):
239
240 2011-06-08  John Sullivan  <sullivan@apple.com>
241
242         Reviewed by Darin Adler.
243
244         <https://bugs.webkit.org/show_bug.cgi?id=62332>
245         <rdar://problem/9355199>
246         [WKView _setDragImage:at:linkDrag:] can crash if WKView is dealloc'ed during drag
247
248         * UIProcess/API/mac/WKView.mm:
249         (-[WKView _resendKeyDownEvent:]):
250         Renamed self-protecting RetainPtr from "protect" to "protector" so it's a noun.
251         (-[WKView _setDragImage:at:linkDrag:]):
252         Added a self-protecting RetainPtr.
253
254 2011-06-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
255
256         Reviewed by Kenneth Rohde Christiansen.
257
258         WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
259         https://bugs.webkit.org/show_bug.cgi?id=61694
260
261         Add an ArgumentCoder for FloatPoint3D.
262
263         Together with Viatcheslav Ostapenko.
264
265         * Scripts/webkit2/messages.py:
266         * Shared/WebCoreArgumentCoders.h:
267
268 2011-06-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
269
270          Reviewed by Kenneth Rohde Christiansen.
271
272          WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
273          https://bugs.webkit.org/show_bug.cgi?id=61694
274
275          Add ArgumentCoders for TransformOperation, including all the subclasses,
276          and TransformOperations.
277
278          * Scripts/webkit2/messages.py:
279          * Shared/WebCoreArgumentCoders.h:
280
281 2011-06-08  Yael Aharon  <yael.aharon@nokia.com>
282
283         Reviewed by Andreas Kling.
284
285         [Qt] Build fix for building QtWebKit inside of Qt.
286         https://bugs.webkit.org/show_bug.cgi?id=62280
287
288         Remove CONFIG=staticlib, because it causes the configure script to add -lwebkit2
289         into QtWebKit.prl.
290
291         * WebKit2.pri:
292
293 2011-06-07  Tim Horton  <timothy_horton@apple.com>
294
295         Reviewed by Alexey Proskuryakov.
296
297         Use correct CFURLStorageSessionRef definition on Snow Leopard
298         https://bugs.webkit.org/show_bug.cgi?id=62223
299
300         * PluginProcess/mac/PluginProcessShim.mm:
301
302 2011-06-07  John Sullivan  <sullivan@apple.com>
303
304         Reviewed by Darin Adler.
305
306         <https://bugs.webkit.org/show_bug.cgi?id=62248>
307         <rdar://problem/9568516>
308         WKResponderChainSink mechanism isn't robust against some types of responder chain manipulation
309
310         * UIProcess/API/mac/WKView.mm:
311         (-[WKResponderChainSink detach]):
312         This method formerly blindly assumed that since -initWithResponderChain: put self at the
313         end of the responder chain, after _lastResponderInChain, then self is still at the end
314         of the responder chain and still immediately after _lastResponderInChain. Made this function
315         robust against some kinds of responder chain manipulations, though it can't be robust against
316         some other kinds (e.g., manipulations that removed self from this chain and put it into some
317         other chain).
318
319 2011-06-07  Sam Weinig  <sam@webkit.org>
320
321         Reviewed by Anders Carlsson.
322
323         Remove repeated IPC traffic from SetRenderTreeSize message
324         https://bugs.webkit.org/show_bug.cgi?id=62244
325
326         * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
327         Add didLayoutForFrame callback.
328
329         * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
330         (WKBundlePageGetRenderTreeSize):
331         * WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
332         Add render tree size getter in WebProcess.
333
334         * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
335         (WebKit::InjectedBundlePageLoaderClient::didLayoutForFrame):
336         * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
337         Added.
338
339         * WebProcess/WebCoreSupport/WebChromeClient.cpp:
340         * WebProcess/WebCoreSupport/WebChromeClient.h:
341         Removed setRenderTreeSize.
342
343         * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
344         (WebKit::WebFrameLoaderClient::dispatchDidLayout):
345         * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
346         Call the new didLayoutForFrame client function.
347
348         * WebProcess/WebPage/WebPage.cpp:
349         (WebKit::WebPage::renderTreeSize):
350         * WebProcess/WebPage/WebPage.h:
351         Add iterative implementation to compute the total size of the render tree
352         for a page.
353
354 2011-06-07  Zalan Bujtas  <zbujtas@gmail.com>
355
356         Reviewed by Andreas Kling.
357
358         TiledDrawingArea: Delay serving tile requests when the drawing area is suspended.
359
360         Do not paint tiles when painting is disabled (suspended) on the web process side.
361         Buffer up the tile requests and paint them, when the drawing area gets resumed.
362         On the UI process side, do not block on tile updates, when the tiled area is
363         not visible (painting is disabled on the web process side).
364
365         * UIProcess/TiledDrawingAreaProxy.cpp:
366         (WebKit::TiledDrawingAreaProxy::waitUntilUpdatesComplete):
367         * WebProcess/WebPage/TiledDrawingArea.cpp:
368         (WebKit::TiledDrawingArea::suspendPainting):
369         (WebKit::TiledDrawingArea::resumePainting):
370         (WebKit::TiledDrawingArea::scheduleTileUpdate):
371         (WebKit::TiledDrawingArea::tileUpdateTimerFired):
372         (WebKit::TiledDrawingArea::didReceiveMessage):
373         * WebProcess/WebPage/TiledDrawingArea.h:
374
375 2011-06-07  Sheriff Bot  <webkit.review.bot@gmail.com>
376
377         Unreviewed, rolling out r88259 and r88263.
378         http://trac.webkit.org/changeset/88259
379         http://trac.webkit.org/changeset/88263
380         https://bugs.webkit.org/show_bug.cgi?id=62228
381
382         broke builds (Requested by rniwa on #webkit).
383
384         * PluginProcess/mac/PluginProcessShim.mm:
385
386 2011-06-07  Tim Horton  <timothy_horton@apple.com>
387
388         Reviewed by Alexey Proskuryakov.
389
390         Use correct CFURLStorageSessionRef definition on Snow Leopard
391         https://bugs.webkit.org/show_bug.cgi?id=62223
392
393         * PluginProcess/mac/PluginProcessShim.mm:
394
395 2011-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
396
397         Reviewed by Martin Robinson.
398
399         [GTK] Move moduleMixesGtkSymbols() from PluginPackage to PluginView
400         https://bugs.webkit.org/show_bug.cgi?id=62200
401
402         In WebKit2 PluginPackage is used by the UI process to load plugins
403         in order to get information about them, but it doesn't use any GTK
404         symbol. So the UI process should be able to load plugins even when
405         building with GTK3, but we should not allow the plugin view to use
406         the plugin if it mixes GTK2 and GTK3 symbols.
407
408         * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
409         (WebKit::moduleMixesGtkSymbols):
410         (WebKit::NetscapePlugin::platformPostInitialize): Check whether
411         the module is mixing GTK+ 2 and GTK+ 3 symbols.
412
413 2011-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
414
415         Unreviewed, rolling out r88222.
416         http://trac.webkit.org/changeset/88222
417         https://bugs.webkit.org/show_bug.cgi?id=62192
418
419         Broke compile on Mac (Requested by abarth on #webkit).
420
421         * Scripts/webkit2/messages.py:
422         * Shared/WebCoreArgumentCoders.h:
423
424 2011-06-06  Noam Rosenthal  <noam.rosenthal@nokia.com>
425
426         Reviewed by Kenneth Rohde Christiansen.
427
428         WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
429         https://bugs.webkit.org/show_bug.cgi?id=61694
430
431         Add ArgumentCoders for TransformOperation, including all the subclasses,
432         and TransformOperations.
433
434         * Scripts/webkit2/messages.py:
435         * Shared/WebCoreArgumentCoders.h:
436
437 2011-06-06  John Sullivan  <sullivan@apple.com>
438
439         Reviewed by Dan Bernstein.
440
441         <https://bugs.webkit.org/show_bug.cgi?id=62165>
442         <rdar://problem/9555835>
443         WebKit2 find-on-page callback doesn’t handle kWKMoreThanMaximumMatchCount on PDF pages
444
445         * UIProcess/API/mac/PDFViewController.mm:
446         (WebKit::PDFViewController::findString):
447         Return kWKMoreThanMaximumMatchCount when appropriate, a la FindController::countStringMatches().
448         Also, skip counting all the matches if maxMatchCount is 0, to avoid (perhaps slowly) computing a
449         number that would be ignored.
450
451 2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
452
453         Reviewed by Anders Carlsson.
454
455         Do not use NPRuntimeObjectMap in NetscapePlugin::setException when plug-in is running out of process
456         https://bugs.webkit.org/show_bug.cgi?id=62124
457
458         * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
459         (WebKit::NetscapePlugin::setException):
460
461 2011-06-06  Dominic Cooney  <dominicc@chromium.org>
462
463         Unreviewed WinCairo build fix after r88159.
464
465         * win/WebKit2CFLite.def: Export symbols for WebCoreTestSupport.
466
467 2011-06-04  Dominic Cooney  <dominicc@chromium.org>
468
469         Reviewed by Dimitri Glazkov.
470
471         Re-export JSC and WebCore symbols required by WebCoreTestSupport.
472         https://bugs.webkit.org/show_bug.cgi?id=61076
473
474         * win/WebKit2.def:
475
476 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
477
478         Reviewed by Kent Tamura.
479
480         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
481         https://bugs.webkit.org/show_bug.cgi?id=61628
482
483         * Configurations/FeatureDefines.xcconfig:
484
485 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
486
487         Reviewed by Kent Tamura.
488
489         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
490         https://bugs.webkit.org/show_bug.cgi?id=61631
491
492         * Configurations/FeatureDefines.xcconfig:
493
494 2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
495
496         Reviewed by Anders Carlsson.
497
498         [UNIX] SOCK_DGRAM sockets are not notified when the other end closes the connection
499         https://bugs.webkit.org/show_bug.cgi?id=61538
500
501         Use SOCK_STREAM instead of SOCK_DGRAM sockets. Rework the message
502         receiver code to support stream sockets, since it requires to
503         handle message boundaries. The same code works for DGRAM sockets,
504         so this change shouldn't break other ports using DGRAM.
505
506         * Platform/CoreIPC/Connection.h:
507         * Platform/CoreIPC/unix/ConnectionUnix.cpp:
508         (CoreIPC::Connection::platformInitialize):
509         (CoreIPC::Connection::processMessage): Process messages from data
510         already received.
511         (CoreIPC::readBytesFromSocket): Read from socket using recvmsg().
512         (CoreIPC::Connection::readyReadHandler):
513         * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
514         (WebKit::ProcessLauncher::launchProcess): Use SOCK_DGRAM in
515         socketpair().
516
517 == Rolled over to ChangeLog-2011-06-04 ==