1 2011-06-10 Sam Weinig <sam@webkit.org>
3 Reviewed by Anders Carlsson.
5 Unresponsive cursor is shown when displaying a modal dialog
6 Part of <rdar://problem/9581492>
7 https://bugs.webkit.org/show_bug.cgi?id=62494
9 * UIProcess/WebPageProxy.cpp:
10 (WebKit::WebPageProxy::runModal):
11 * UIProcess/WebPageProxy.h:
12 Stop the responsiveness timer when calling out to show a modal dialog.
14 2011-06-10 Tony Chang <tony@chromium.org>
16 Reviewed by Ojan Vafai.
18 add a compile guard ENABLE(FLEXBOX)
19 https://bugs.webkit.org/show_bug.cgi?id=62049
21 * Configurations/FeatureDefines.xcconfig:
23 2011-06-10 Ryuan Choi <ryuan.choi@samsung.com>
25 Reviewed by Kenneth Rohde Christiansen.
27 [EFL][WK2] Add dummy files in WebProcess/WebCoreSupport/efl
28 https://bugs.webkit.org/show_bug.cgi?id=62346
30 Add WebProcess/WebCoreSupport/efl directory and files.
32 * WebProcess/WebCoreSupport/efl/WebContextMenuClientEfl.cpp: Added.
33 (WebKit::WebContextMenuClient::lookUpInDictionary):
34 (WebKit::WebContextMenuClient::isSpeaking):
35 (WebKit::WebContextMenuClient::speak):
36 (WebKit::WebContextMenuClient::stopSpeaking):
37 * WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp: Added.
38 (WebKit::WebEditorClient::handleKeyboardEvent):
39 (WebKit::WebEditorClient::handleInputMethodKeydown):
40 * WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp: Added.
41 (WebKit::cancelledError):
42 (WebKit::blockedError):
43 (WebKit::cannotShowURLError):
44 (WebKit::interruptForPolicyChangeError):
45 (WebKit::cannotShowMIMETypeError):
46 (WebKit::fileDoesNotExistError):
47 (WebKit::pluginWillHandleLoadError):
48 * WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h: Added.
49 (WebFrameNetworkingContext::create):
50 (WebFrameNetworkingContext::WebFrameNetworkingContext):
51 * WebProcess/WebCoreSupport/efl/WebPopupMenuEfl.cpp: Added.
52 (WebKit::WebPopupMenu::setUpPlatformData):
54 2011-06-09 Andreas Kling <kling@webkit.org>
56 Reviewed by Darin Adler.
58 WebKit2: Remove unused function CoreIPC::Connection::deprecatedWaitFor().
59 https://bugs.webkit.org/show_bug.cgi?id=62386
61 * Platform/CoreIPC/Connection.h:
63 2011-06-09 Andreas Kling <kling@webkit.org>
65 Reviewed by Anders Carlsson.
67 [Qt][WK2] Remove usage of deprecated CoreIPC functions.
68 https://bugs.webkit.org/show_bug.cgi?id=62290
70 Use the new DrawingArea{,Proxy}.messages.in approach to CoreIPC in TiledDrawingArea.
71 The TiledDrawingArea{,Proxy}-specific messages were moved up into DrawingArea{,Proxy}
72 and guarded by ENABLE(TILED_BACKING_STORE).
74 * Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: Removed.
75 * Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: Removed.
79 * WebKit2.xcodeproj/project.pbxproj:
80 * win/WebKit2.vcproj: Prune deleted files from build system.
82 * Platform/CoreIPC/MessageID.h: Remove legacy DrawingArea message ID's.
84 * UIProcess/API/qt/qgraphicswkview.cpp:
85 (QGraphicsWKViewPrivate::commitScale): No longer waits for all tile updates to complete,
86 this will be addressed by the soon-to-be-upstreamed TileSet mechanism.
88 * UIProcess/DrawingAreaProxy.messages.in:
89 * UIProcess/DrawingAreaProxy.h:
90 (WebKit::DrawingAreaProxy::didSetSize):
91 (WebKit::DrawingAreaProxy::invalidate):
92 (WebKit::DrawingAreaProxy::snapshotTaken):
93 (WebKit::DrawingAreaProxy::tileUpdated):
94 (WebKit::DrawingAreaProxy::allTileUpdatesProcessed): Added IPC calls used by
95 TiledDrawingAreaProxy to DrawingAreaProxy.
97 * WebProcess/WebPage/DrawingArea.messages.in:
98 * WebProcess/WebPage/DrawingArea.h:
99 (WebKit::DrawingArea::setSize):
100 (WebKit::DrawingArea::cancelTileUpdate):
101 (WebKit::DrawingArea::requestTileUpdate):
102 (WebKit::DrawingArea::takeSnapshot): Added IPC calls used by TiledDrawingArea
105 * UIProcess/DrawingAreaProxyImpl.h:
106 * UIProcess/DrawingAreaProxyImpl.cpp: Remove the now-unneeded didReceiveMessage()
107 and didReceiveSyncMessage().
109 * WebProcess/WebPage/DrawingAreaImpl.cpp:
110 * WebProcess/WebPage/DrawingAreaImpl.h: Remove the now-unneeded didReceiveMessage().
112 * UIProcess/TiledDrawingAreaProxy.h:
113 * UIProcess/TiledDrawingAreaProxy.cpp:
114 (WebKit::TiledDrawingAreaProxy::sizeDidChange):
115 (WebKit::TiledDrawingAreaProxy::tileUpdated):
116 (WebKit::TiledDrawingAreaProxy::allTileUpdatesProcessed): Split didReceiveMessage()
119 (WebKit::TiledDrawingAreaProxy::removeTile):
120 (WebKit::TiledDrawingAreaProxy::requestTileUpdate):
121 (WebKit::TiledDrawingAreaProxy::setPageIsVisible):
122 (WebKit::TiledDrawingAreaProxy::takeSnapshot): Use new-style IPC.
124 * WebProcess/WebPage/TiledDrawingArea.cpp:
125 (WebKit::TiledDrawingArea::setSize):
126 (WebKit::TiledDrawingArea::cancelTileUpdate):
127 (WebKit::TiledDrawingArea::requestTileUpdate):
128 (WebKit::TiledDrawingArea::takeSnapshot): Split didReceiveMessage() into functions.
130 (WebKit::TiledDrawingArea::display):
131 (WebKit::TiledDrawingArea::updateTile):
132 (WebKit::TiledDrawingArea::tileUpdateTimerFired): Use new-style IPC.
134 * UIProcess/WebPageProxy.cpp:
135 (WebKit::WebPageProxy::didReceiveMessage): Remove handling of
136 CoreIPC::MessageClassDrawingAreaProxyLegacy.
138 * WebProcess/WebPage/WebPage.cpp:
139 (WebKit::WebPage::didReceiveMessage): Remove handling of
140 CoreIPC::MessageClassDrawingAreaLegacy.
142 * UIProcess/qt/TiledDrawingAreaProxyQt.cpp: Remove unneeded includes.
144 * WebProcess/WebPage/TiledDrawingArea.h: Remove didReceiveMessage() and make
145 CoreIPC message handlers explicitly virtual.
147 2011-06-09 Andreas Kling <kling@webkit.org>
149 Reviewed by Anders Carlsson.
151 WebKit2: Generate correct header conditionals in message receivers.
152 https://bugs.webkit.org/show_bug.cgi?id=62379
154 Given a *.messages.in file like this:
157 #if ENABLE(ESOTERIC_FEATURE)
161 messages.py would include AwesomeObject.h only #if ENABLE(ESOTERIC_FEATURE).
162 This breaks the build on platforms without that defined.
164 Furthermore, if two messages guarded by different conditionals both pull in the same
165 header, only the last conditional will be applied, for example:
167 #if ENABLE(ESOTERIC_FEATURE)
170 #if ENABLE(MYSTERIOUS_FEATURE)
174 Would include AwesomeObject.h #if ENABLE(MYSTERIOUS_FEATURE) when it really should
175 check #if ENABLE(ESOTERIC_FEATURE) || ENABLE(MYSTERIOUS_FEATURE).
177 Change the generator to consider all conditionals for a given header file.
178 Also consider conditionals for reply parameters.
180 * Scripts/webkit2/messages.py:
181 * Scripts/webkit2/messages_unittest.py:
183 2011-06-09 Eunmi Lee <eunmi15.lee@samsung.com>
185 Reviewed by Kenneth Rohde Christiansen.
187 [EFL][WK2] Add PageClientImpl and WebPageProxyEfl for efl port
188 https://bugs.webkit.org/show_bug.cgi?id=62363
190 * UIProcess/API/efl/PageClientImpl.cpp: Added.
191 (WebKit::PageClientImpl::PageClientImpl):
192 (WebKit::PageClientImpl::~PageClientImpl):
193 (WebKit::PageClientImpl::createDrawingAreaProxy):
194 (WebKit::PageClientImpl::setViewNeedsDisplay):
195 (WebKit::PageClientImpl::displayView):
196 (WebKit::PageClientImpl::scrollView):
197 (WebKit::PageClientImpl::viewSize):
198 (WebKit::PageClientImpl::isViewWindowActive):
199 (WebKit::PageClientImpl::isViewFocused):
200 (WebKit::PageClientImpl::isViewVisible):
201 (WebKit::PageClientImpl::isViewInWindow):
202 (WebKit::PageClientImpl::processDidCrash):
203 (WebKit::PageClientImpl::didRelaunchProcess):
204 (WebKit::PageClientImpl::pageClosed):
205 (WebKit::PageClientImpl::toolTipChanged):
206 (WebKit::PageClientImpl::setCursor):
207 (WebKit::PageClientImpl::setViewportArguments):
208 (WebKit::PageClientImpl::registerEditCommand):
209 (WebKit::PageClientImpl::clearAllEditCommands):
210 (WebKit::PageClientImpl::canUndoRedo):
211 (WebKit::PageClientImpl::executeUndoRedo):
212 (WebKit::PageClientImpl::convertToDeviceSpace):
213 (WebKit::PageClientImpl::convertToUserSpace):
214 (WebKit::PageClientImpl::windowToScreen):
215 (WebKit::PageClientImpl::doneWithKeyEvent):
216 (WebKit::PageClientImpl::createPopupMenuProxy):
217 (WebKit::PageClientImpl::createContextMenuProxy):
218 (WebKit::PageClientImpl::setFindIndicator):
219 (WebKit::PageClientImpl::didChangeScrollbarsForMainFrame):
220 (WebKit::PageClientImpl::didCommitLoadForMainFrame):
221 (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
222 (WebKit::PageClientImpl::customRepresentationZoomFactor):
223 (WebKit::PageClientImpl::setCustomRepresentationZoomFactor):
224 (WebKit::PageClientImpl::flashBackingStoreUpdates):
225 (WebKit::PageClientImpl::findStringInCustomRepresentation):
226 (WebKit::PageClientImpl::countStringMatchesInCustomRepresentation):
227 (WebKit::PageClientImpl::userSpaceScaleFactor):
228 * UIProcess/API/efl/PageClientImpl.h: Added.
229 (WebKit::PageClientImpl::create):
230 (WebKit::PageClientImpl::viewObject):
231 (WebKit::PageClientImpl::page):
232 * UIProcess/WebPageProxy.h:
233 * UIProcess/efl/WebPageProxyEfl.cpp: Added.
234 (WebKit::WebPageProxy::viewObject):
235 (WebKit::WebPageProxy::standardUserAgent):
236 (WebKit::WebPageProxy::getEditorCommandsForKeyEvent):
237 (WebKit::WebPageProxy::saveRecentSearches):
238 (WebKit::WebPageProxy::loadRecentSearches):
240 2011-06-08 John Sullivan <sullivan@apple.com>
242 Reviewed by Darin Adler.
244 <https://bugs.webkit.org/show_bug.cgi?id=62332>
245 <rdar://problem/9355199>
246 [WKView _setDragImage:at:linkDrag:] can crash if WKView is dealloc'ed during drag
248 * UIProcess/API/mac/WKView.mm:
249 (-[WKView _resendKeyDownEvent:]):
250 Renamed self-protecting RetainPtr from "protect" to "protector" so it's a noun.
251 (-[WKView _setDragImage:at:linkDrag:]):
252 Added a self-protecting RetainPtr.
254 2011-06-08 No'am Rosenthal <noam.rosenthal@nokia.com>
256 Reviewed by Kenneth Rohde Christiansen.
258 WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
259 https://bugs.webkit.org/show_bug.cgi?id=61694
261 Add an ArgumentCoder for FloatPoint3D.
263 Together with Viatcheslav Ostapenko.
265 * Scripts/webkit2/messages.py:
266 * Shared/WebCoreArgumentCoders.h:
268 2011-06-08 No'am Rosenthal <noam.rosenthal@nokia.com>
270 Reviewed by Kenneth Rohde Christiansen.
272 WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
273 https://bugs.webkit.org/show_bug.cgi?id=61694
275 Add ArgumentCoders for TransformOperation, including all the subclasses,
276 and TransformOperations.
278 * Scripts/webkit2/messages.py:
279 * Shared/WebCoreArgumentCoders.h:
281 2011-06-08 Yael Aharon <yael.aharon@nokia.com>
283 Reviewed by Andreas Kling.
285 [Qt] Build fix for building QtWebKit inside of Qt.
286 https://bugs.webkit.org/show_bug.cgi?id=62280
288 Remove CONFIG=staticlib, because it causes the configure script to add -lwebkit2
293 2011-06-07 Tim Horton <timothy_horton@apple.com>
295 Reviewed by Alexey Proskuryakov.
297 Use correct CFURLStorageSessionRef definition on Snow Leopard
298 https://bugs.webkit.org/show_bug.cgi?id=62223
300 * PluginProcess/mac/PluginProcessShim.mm:
302 2011-06-07 John Sullivan <sullivan@apple.com>
304 Reviewed by Darin Adler.
306 <https://bugs.webkit.org/show_bug.cgi?id=62248>
307 <rdar://problem/9568516>
308 WKResponderChainSink mechanism isn't robust against some types of responder chain manipulation
310 * UIProcess/API/mac/WKView.mm:
311 (-[WKResponderChainSink detach]):
312 This method formerly blindly assumed that since -initWithResponderChain: put self at the
313 end of the responder chain, after _lastResponderInChain, then self is still at the end
314 of the responder chain and still immediately after _lastResponderInChain. Made this function
315 robust against some kinds of responder chain manipulations, though it can't be robust against
316 some other kinds (e.g., manipulations that removed self from this chain and put it into some
319 2011-06-07 Sam Weinig <sam@webkit.org>
321 Reviewed by Anders Carlsson.
323 Remove repeated IPC traffic from SetRenderTreeSize message
324 https://bugs.webkit.org/show_bug.cgi?id=62244
326 * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
327 Add didLayoutForFrame callback.
329 * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
330 (WKBundlePageGetRenderTreeSize):
331 * WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
332 Add render tree size getter in WebProcess.
334 * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
335 (WebKit::InjectedBundlePageLoaderClient::didLayoutForFrame):
336 * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
339 * WebProcess/WebCoreSupport/WebChromeClient.cpp:
340 * WebProcess/WebCoreSupport/WebChromeClient.h:
341 Removed setRenderTreeSize.
343 * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
344 (WebKit::WebFrameLoaderClient::dispatchDidLayout):
345 * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
346 Call the new didLayoutForFrame client function.
348 * WebProcess/WebPage/WebPage.cpp:
349 (WebKit::WebPage::renderTreeSize):
350 * WebProcess/WebPage/WebPage.h:
351 Add iterative implementation to compute the total size of the render tree
354 2011-06-07 Zalan Bujtas <zbujtas@gmail.com>
356 Reviewed by Andreas Kling.
358 TiledDrawingArea: Delay serving tile requests when the drawing area is suspended.
360 Do not paint tiles when painting is disabled (suspended) on the web process side.
361 Buffer up the tile requests and paint them, when the drawing area gets resumed.
362 On the UI process side, do not block on tile updates, when the tiled area is
363 not visible (painting is disabled on the web process side).
365 * UIProcess/TiledDrawingAreaProxy.cpp:
366 (WebKit::TiledDrawingAreaProxy::waitUntilUpdatesComplete):
367 * WebProcess/WebPage/TiledDrawingArea.cpp:
368 (WebKit::TiledDrawingArea::suspendPainting):
369 (WebKit::TiledDrawingArea::resumePainting):
370 (WebKit::TiledDrawingArea::scheduleTileUpdate):
371 (WebKit::TiledDrawingArea::tileUpdateTimerFired):
372 (WebKit::TiledDrawingArea::didReceiveMessage):
373 * WebProcess/WebPage/TiledDrawingArea.h:
375 2011-06-07 Sheriff Bot <webkit.review.bot@gmail.com>
377 Unreviewed, rolling out r88259 and r88263.
378 http://trac.webkit.org/changeset/88259
379 http://trac.webkit.org/changeset/88263
380 https://bugs.webkit.org/show_bug.cgi?id=62228
382 broke builds (Requested by rniwa on #webkit).
384 * PluginProcess/mac/PluginProcessShim.mm:
386 2011-06-07 Tim Horton <timothy_horton@apple.com>
388 Reviewed by Alexey Proskuryakov.
390 Use correct CFURLStorageSessionRef definition on Snow Leopard
391 https://bugs.webkit.org/show_bug.cgi?id=62223
393 * PluginProcess/mac/PluginProcessShim.mm:
395 2011-06-07 Carlos Garcia Campos <cgarcia@igalia.com>
397 Reviewed by Martin Robinson.
399 [GTK] Move moduleMixesGtkSymbols() from PluginPackage to PluginView
400 https://bugs.webkit.org/show_bug.cgi?id=62200
402 In WebKit2 PluginPackage is used by the UI process to load plugins
403 in order to get information about them, but it doesn't use any GTK
404 symbol. So the UI process should be able to load plugins even when
405 building with GTK3, but we should not allow the plugin view to use
406 the plugin if it mixes GTK2 and GTK3 symbols.
408 * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
409 (WebKit::moduleMixesGtkSymbols):
410 (WebKit::NetscapePlugin::platformPostInitialize): Check whether
411 the module is mixing GTK+ 2 and GTK+ 3 symbols.
413 2011-06-06 Sheriff Bot <webkit.review.bot@gmail.com>
415 Unreviewed, rolling out r88222.
416 http://trac.webkit.org/changeset/88222
417 https://bugs.webkit.org/show_bug.cgi?id=62192
419 Broke compile on Mac (Requested by abarth on #webkit).
421 * Scripts/webkit2/messages.py:
422 * Shared/WebCoreArgumentCoders.h:
424 2011-06-06 Noam Rosenthal <noam.rosenthal@nokia.com>
426 Reviewed by Kenneth Rohde Christiansen.
428 WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
429 https://bugs.webkit.org/show_bug.cgi?id=61694
431 Add ArgumentCoders for TransformOperation, including all the subclasses,
432 and TransformOperations.
434 * Scripts/webkit2/messages.py:
435 * Shared/WebCoreArgumentCoders.h:
437 2011-06-06 John Sullivan <sullivan@apple.com>
439 Reviewed by Dan Bernstein.
441 <https://bugs.webkit.org/show_bug.cgi?id=62165>
442 <rdar://problem/9555835>
443 WebKit2 find-on-page callback doesn’t handle kWKMoreThanMaximumMatchCount on PDF pages
445 * UIProcess/API/mac/PDFViewController.mm:
446 (WebKit::PDFViewController::findString):
447 Return kWKMoreThanMaximumMatchCount when appropriate, a la FindController::countStringMatches().
448 Also, skip counting all the matches if maxMatchCount is 0, to avoid (perhaps slowly) computing a
449 number that would be ignored.
451 2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>
453 Reviewed by Anders Carlsson.
455 Do not use NPRuntimeObjectMap in NetscapePlugin::setException when plug-in is running out of process
456 https://bugs.webkit.org/show_bug.cgi?id=62124
458 * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
459 (WebKit::NetscapePlugin::setException):
461 2011-06-06 Dominic Cooney <dominicc@chromium.org>
463 Unreviewed WinCairo build fix after r88159.
465 * win/WebKit2CFLite.def: Export symbols for WebCoreTestSupport.
467 2011-06-04 Dominic Cooney <dominicc@chromium.org>
469 Reviewed by Dimitri Glazkov.
471 Re-export JSC and WebCore symbols required by WebCoreTestSupport.
472 https://bugs.webkit.org/show_bug.cgi?id=61076
476 2011-06-06 Alexandru Chiculita <achicu@adobe.com>
478 Reviewed by Kent Tamura.
480 Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
481 https://bugs.webkit.org/show_bug.cgi?id=61628
483 * Configurations/FeatureDefines.xcconfig:
485 2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>
487 Reviewed by Kent Tamura.
489 Add ENABLE(CSS_REGIONS) guard for CSS Regions support
490 https://bugs.webkit.org/show_bug.cgi?id=61631
492 * Configurations/FeatureDefines.xcconfig:
494 2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>
496 Reviewed by Anders Carlsson.
498 [UNIX] SOCK_DGRAM sockets are not notified when the other end closes the connection
499 https://bugs.webkit.org/show_bug.cgi?id=61538
501 Use SOCK_STREAM instead of SOCK_DGRAM sockets. Rework the message
502 receiver code to support stream sockets, since it requires to
503 handle message boundaries. The same code works for DGRAM sockets,
504 so this change shouldn't break other ports using DGRAM.
506 * Platform/CoreIPC/Connection.h:
507 * Platform/CoreIPC/unix/ConnectionUnix.cpp:
508 (CoreIPC::Connection::platformInitialize):
509 (CoreIPC::Connection::processMessage): Process messages from data
511 (CoreIPC::readBytesFromSocket): Read from socket using recvmsg().
512 (CoreIPC::Connection::readyReadHandler):
513 * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
514 (WebKit::ProcessLauncher::launchProcess): Use SOCK_DGRAM in
517 == Rolled over to ChangeLog-2011-06-04 ==