1 2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
3 Reviewed by Sam Weinig.
5 Add Frame* to the argument lists of canCopyCut and canPaste
6 https://bugs.webkit.org/show_bug.cgi?id=59153
8 * WebCoreSupport/WebEditorClient.cpp:
9 (WebEditorClient::canCopyCut):
10 (WebEditorClient::canPaste):
11 * WebCoreSupport/WebEditorClient.h:
13 2011-04-20 Brent Fulgham <bfulgham@webkit.org>
15 Reviewed by Martin Robinson.
17 Provide missing implementation of WebMutableURLRequest::mutableCopy.
18 This was preventing DumpRenderTree from working properly under
20 https://bugs.webkit.org/show_bug.cgi?id=59034
22 * WebMutableURLRequest.cpp:
23 (WebMutableURLRequest::mutableCopy): Implement cURL version of the
26 2011-04-19 Vsevolod Vlasov <vsevik@chromium.org>
28 Reviewed by Pavel Feldman.
30 Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
31 https://bugs.webkit.org/show_bug.cgi?id=58883
33 * WebCoreSupport/WebFrameLoaderClient.h:
35 2011-04-18 Timothy Hatcher <timothy@apple.com>
37 Remove the two commands that make en.lproj and copy Localizable.strings.
39 Rubber-stamped by Adam Roben.
41 * WebKit.vcproj/WebKitLibPostBuild.cmd:
43 2011-04-18 Patrick Gansterer <paroga@webkit.org>
45 Reviewed by Adam Roben.
47 Include <WebCore/COMPtr.h> instead of "COMPtr.h"
48 https://bugs.webkit.org/show_bug.cgi?id=58744
52 * WebActionPropertyBag.cpp:
53 * WebBackForwardList.cpp:
54 * WebCoreSupport/WebGeolocationClient.h:
59 * WebIconDatabase.cpp:
60 * WebNavigationData.h:
63 * WebURLAuthenticationChallenge.cpp:
64 * WebURLAuthenticationChallengeSender.cpp:
65 * WebURLAuthenticationChallengeSenderCFNet.cpp:
66 * WebURLAuthenticationChallengeSenderCurl.cpp:
69 2011-04-17 Patrick Gansterer <paroga@webkit.org>
71 Reviewed by Adam Barth.
73 Rename PLATFORM(CG) to USE(CG)
74 https://bugs.webkit.org/show_bug.cgi?id=58729
77 (WebFrame::spoolPages):
80 (WebPreferences::setFontSmoothing):
81 (WebPreferences::setFontSmoothingContrast):
83 (systemParameterChanged):
85 2011-04-16 Sam Weinig <sam@webkit.org>
87 Reviewed by Simon Fraser.
89 Windows should use WebCore localized strings
90 <rdar://problem/9119405>
91 https://bugs.webkit.org/show_bug.cgi?id=58733
93 * WebCoreSupport/WebEditorClient.cpp:
94 (undoNameForEditAction):
95 (WebEditorClient::registerCommandForUndo):
97 (WebPreferences::initializeDefaultSettings):
99 (CFHTTPMessageCopyLocalizedShortDescriptionForStatusCode):
100 (WebURLResponse::localizedStringForStatusCode):
101 Change to use WEB_UI_STRING.
103 * WebCoreSupport/WebPlatformStrategies.cpp:
104 * WebCoreSupport/WebPlatformStrategies.h:
105 Remove the localization strategy in favor of using the default one.
107 2011-04-16 Patrick Gansterer <paroga@webkit.org>
109 Reviewed by Eric Seidel.
111 Rename PLATFORM(CAIRO) to USE(CAIRO)
112 https://bugs.webkit.org/show_bug.cgi?id=55192
115 (WebFrame::spoolPages):
118 2011-04-14 Adam Roben <aroben@apple.com>
120 Replace some known-to-fail assertions with FIXMEs
122 These assertions get hit during various layout tests. They indicate that we're sometimes
123 doing some extra work when a page goes into accelerated compositing mode, but otherwise
124 there's no bad effect.
126 See <http://webkit.org/b/58539> for more details.
128 Rubber-stamped by John Sullivan.
131 (WebView::paintIntoBackingStore):
132 (WebView::paintIntoWindow):
133 Replaced assertions with FIXMEs.
135 2011-04-13 James Robinson <jamesr@chromium.org>
137 Reviewed by Simon Fraser.
139 Allow setting composited backing stores for scrollbars and scroll corners
140 https://bugs.webkit.org/show_bug.cgi?id=57202
142 Update WebScrollBar to reflect ScrollableArea interface changes.
145 (WebScrollBar::invalidateScrollCornerRect):
146 (WebScrollBar::scrollCornerPresent):
147 (WebScrollBar::scrollCornerRect):
149 2011-04-12 Alice Liu <alice.liu@apple.com>
151 Reviewed by Sam Weinig.
153 https://bugs.webkit.org/show_bug.cgi?id=58292
154 Provide new setting to allow site icon loading despite disabling automatic image loading in general.
156 * Interfaces/IWebPreferencesPrivate.idl: Added prefs.
157 * Interfaces/WebKit.idl: Touch file to force autogeneration
158 * WebPreferenceKeysPrivate.h: Add preference key.
159 * WebPreferences.cpp:
160 (WebPreferences::initializeDefaultSettings): Initialize setting to false.
161 (WebPreferences::setLoadsSiteIconsIgnoringImageLoadingPreference): Added setter
162 (WebPreferences::loadsSiteIconsIgnoringImageLoadingPreference): Added getter
165 (WebView::notifyPreferencesChanged): Add to settings that get propagated upon changes.
167 2011-04-11 Alexey Proskuryakov <ap@apple.com>
169 Reviewed by Maciej Stachowiak.
171 WebKit2: Cannot use Ctrl-Delete as a custom keyboard shortcut
172 https://bugs.webkit.org/show_bug.cgi?id=58265
173 <rdar://problem/9221468>
175 * WebView.cpp: (WebView::keyDown): Removed special handling of Backspace, which is unnecessary
176 now that WebCore implements it.
178 2011-04-06 Brian Weinstein <bweinstein@apple.com>
180 Reviewed by Adam Roben.
182 WebKit2: Support Windows 7 Gestures
183 https://bugs.webkit.org/show_bug.cgi?id=49824
184 <rdar://problem/8689728>
186 Move WindowsTouch.h from WebKit/win to WebCore/platform/win, so it can be
187 used in both WebKit and WebKit2.
189 * WebKit.vcproj/WebKit.vcproj: Remove WindowsTouch.h.
190 * WebView.cpp: Include WindowsTouch.h from WebCore instead of WebKit.
191 * WindowsTouch.h: Removed.
193 2011-04-05 Martin Robinson <mrobinson@igalia.com>
195 Reviewed by Eric Seidel.
197 [Cairo] Better separate the concerns of GraphicsContextCairo
198 https://bugs.webkit.org/show_bug.cgi?id=55150
201 (hdcFromContext): Modify this method to take PlatformContextCairo
202 instead of a cairo_t.
203 (WebFrame::spoolPage): Update to reflect new platform context.
204 (WebFrame::spoolPages): Ditto.
207 2011-04-04 MORITA Hajime <morrita@google.com>
209 Reviewed by Ryosuke Niwa.
211 [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
212 https://bugs.webkit.org/show_bug.cgi?id=56085
214 * WebCoreSupport/WebEditorClient.h:
215 (WebEditorClient::requestCheckingOfString):
217 2011-04-04 Alexey Proskuryakov <ap@apple.com>
219 Reviewed by Dan Bernstein.
221 REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
222 https://bugs.webkit.org/show_bug.cgi?id=51230
223 <rdar://problem/8780989>
225 * WebView.cpp: (WebView::keyDown): Moved Caps Lock handling from WebKits to WebCore,
226 because WebKit shouldn't be smart.
228 2011-04-04 Steve Falkenburg <sfalken@apple.com>
230 Reviewed by Adam Roben.
232 Remove unused AnalyzeWithLargeStack code from Windows build files
233 https://bugs.webkit.org/show_bug.cgi?id=57771
235 This was used for us to build with prefast automatically,
236 but it is out-of-date and hasn't been used for some time.
237 Removing completely for now.
239 * WebKit.vcproj/WebKitLibPreBuild.cmd:
241 2011-04-01 Adam Roben <aroben@apple.com>
243 Remove the WebView's "this" pointer from its HWND when WM_DESTROY is received
245 This will ensure we don't try to process any window messages after the window has been
248 Covered by existing tests.
250 Fixes <http://webkit.org/b/55054>.
252 Reviewed by Steve Falkenburg and John Sullivan.
255 (WebView::setIsBeingDestroyed): Moved here from the header file, and added a call to clear
256 out the this pointer from the HWND.
257 (WebView::WebViewWndProc): Changed a runtime check into an assertion.
259 * WebView.h: Moved setIsBeingDestroyed from here to the .cpp file.
261 2011-03-31 Evan Martin <evan@chromium.org>
263 Reviewed by Eric Seidel.
265 <title> should support dir attribute
266 https://bugs.webkit.org/show_bug.cgi?id=50961
268 Update to new FrameLoaderClient interface.
270 * WebCoreSupport/WebFrameLoaderClient.cpp:
271 (WebFrameLoaderClient::dispatchDidReceiveTitle):
272 * WebCoreSupport/WebFrameLoaderClient.h:
274 2011-03-30 Steve Falkenburg <sfalken@apple.com>
276 Reviewed by Adam Roben.
278 Share most vsprops between Release and Production builds in releaseproduction.vsprops
279 https://bugs.webkit.org/show_bug.cgi?id=57508
281 * WebKit.vcproj/InterfacesProduction.vsprops:
282 * WebKit.vcproj/InterfacesRelease.vsprops:
283 * WebKit.vcproj/InterfacesReleaseCairoCFLite.vsprops:
284 * WebKit.vcproj/WebKitGUIDProduction.vsprops:
285 * WebKit.vcproj/WebKitGUIDRelease.vsprops:
286 * WebKit.vcproj/WebKitGUIDReleaseCairoCFLite.vsprops:
287 * WebKit.vcproj/WebKitLibProduction.vsprops:
288 * WebKit.vcproj/WebKitLibRelease.vsprops:
289 * WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops:
291 2011-03-30 Steve Falkenburg <sfalken@apple.com>
293 Reviewed by Adam Roben.
295 Update Windows production build logic for new production configurations
296 https://bugs.webkit.org/show_bug.cgi?id=57494
298 * WebKit.vcproj/InterfacesProduction.vsprops:
299 * WebKit.vcproj/WebKit.make:
300 * WebKit.vcproj/WebKitGUIDProduction.vsprops:
301 * WebKit.vcproj/WebKitLibProduction.vsprops:
303 2011-03-30 Steve Falkenburg <sfalken@apple.com>
305 Reviewed by Adam Roben.
307 Rename Windows configuration Release_LTCG to Production for clarity
308 https://bugs.webkit.org/show_bug.cgi?id=57465
310 * WebKit.vcproj/Interfaces.vcproj:
311 * WebKit.vcproj/InterfacesProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/InterfacesReleaseLTCG.vsprops.
312 * WebKit.vcproj/InterfacesReleaseLTCG.vsprops: Removed.
313 * WebKit.vcproj/WebKit.sln:
314 * WebKit.vcproj/WebKit.submit.sln:
315 * WebKit.vcproj/WebKit.vcproj:
316 * WebKit.vcproj/WebKitGUID.vcproj:
317 * WebKit.vcproj/WebKitGUIDProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops.
318 * WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops: Removed.
319 * WebKit.vcproj/WebKitLibProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/WebKitLibReleaseLTCG.vsprops.
320 * WebKit.vcproj/WebKitLibReleaseLTCG.vsprops: Removed.
322 2011-03-29 Patrick Gansterer <paroga@webkit.org>
324 Reviewed by Adam Roben.
326 [WIN] Remove unused GEN_DOMObject files
327 https://bugs.webkit.org/show_bug.cgi?id=57370
329 * GEN_DOMObject.cpp: Removed.
330 * GEN_DOMObject.h: Removed.
332 2011-03-29 Steve Falkenburg <sfalken@apple.com>
336 * WebCoreSupport/WebPlatformStrategies.h:
338 2011-03-29 Steve Falkenburg <sfalken@apple.com>
342 * WebCoreSupport/WebPlatformStrategies.cpp:
343 (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary):
345 2011-03-29 Patrick Gansterer <paroga@webkit.org>
347 Unreviewed. Try to fix Windows build.
349 * DOMEventsClasses.cpp: Added initguid.h again.
351 2011-03-29 Patrick Gansterer <paroga@webkit.org>
353 Reviewed by Adam Roben.
355 [WIN] Cleanup includes in WebKit files
356 https://bugs.webkit.org/show_bug.cgi?id=57381
358 Add missing includes to fix build without precompiled header.
359 Also fix paths in #include statements (e.g. WTF -> wtf).
362 * AccessibleDocument.h: Replace using statement with a qualified name.
363 * CFDictionaryPropertyBag.h:
364 * DOMEventsClasses.cpp:
366 * DefaultDownloadDelegate.cpp:
367 * DefaultDownloadDelegate.h:
368 * DefaultPolicyDelegate.cpp:
369 * DefaultPolicyDelegate.h:
370 * WebCoreSupport/EmbeddedWidget.h:
371 * WebCoreSupport/WebInspectorDelegate.h:
373 * WebDatabaseManager.h:
374 * WebElementPropertyBag.h:
375 * WebFramePolicyListener.h:
376 * WebGeolocationPolicyListener.h:
378 * WebKitClassFactory.h:
380 * WebSerializedJSValue.h:
381 * WebUserContentURLPattern.h:
383 2011-03-29 Steve Falkenburg <sfalken@apple.com>
385 Reviewed by Darin Adler.
387 Use per-configuration vsprops in WebKit to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
388 https://bugs.webkit.org/show_bug.cgi?id=57383
390 Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
391 InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
392 the IDE. To avoid this, add a separate vsprops file for each project configuration that
393 contains the required inherited property sheets.
395 * WebKit.vcproj/Interfaces.vcproj:
396 * WebKit.vcproj/InterfacesDebug.vsprops: Added.
397 * WebKit.vcproj/InterfacesDebugAll.vsprops: Added.
398 * WebKit.vcproj/InterfacesDebugCairoCFLite.vsprops: Added.
399 * WebKit.vcproj/InterfacesRelease.vsprops: Added.
400 * WebKit.vcproj/InterfacesReleaseCairoCFLite.vsprops: Added.
401 * WebKit.vcproj/InterfacesReleaseLTCG.vsprops: Added.
402 * WebKit.vcproj/WebKit.vcproj:
403 * WebKit.vcproj/WebKitGUID.vcproj:
404 * WebKit.vcproj/WebKitGUIDDebug.vsprops: Added.
405 * WebKit.vcproj/WebKitGUIDDebugAll.vsprops: Added.
406 * WebKit.vcproj/WebKitGUIDDebugCairoCFLite.vsprops: Added.
407 * WebKit.vcproj/WebKitGUIDRelease.vsprops: Added.
408 * WebKit.vcproj/WebKitGUIDReleaseCairoCFLite.vsprops: Added.
409 * WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops: Added.
410 * WebKit.vcproj/WebKitLibDebug.vsprops: Added.
411 * WebKit.vcproj/WebKitLibDebugAll.vsprops: Added.
412 * WebKit.vcproj/WebKitLibDebugCairoCFLite.vsprops: Added.
413 * WebKit.vcproj/WebKitLibRelease.vsprops: Added.
414 * WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops: Added.
415 * WebKit.vcproj/WebKitLibReleaseLTCG.vsprops: Added.
417 2011-03-29 Patrick Gansterer <paroga@webkit.org>
419 Reviewed by Adam Roben.
421 Remove #pragma warning push and pop statements
422 https://bugs.webkit.org/show_bug.cgi?id=57198
424 We do not need to disable warnings via #pragma since we started
425 compiling WebCore with the same compiler warnings flags as WebKit.
428 * DOMCoreClasses.cpp:
429 * DOMEventsClasses.cpp:
430 * DOMHTMLClasses.cpp:
431 * DefaultDownloadDelegate.cpp:
432 * DefaultPolicyDelegate.cpp:
433 * MarshallingHelpers.cpp:
434 * WebActionPropertyBag.cpp:
435 * WebActionPropertyBag.h:
437 * WebCoreSupport/WebDragClient.cpp:
438 * WebCoreSupport/WebEditorClient.cpp:
439 * WebCoreSupport/WebEditorClient.h:
440 * WebCoreSupport/WebFrameLoaderClient.cpp:
441 * WebCoreSupport/WebFrameLoaderClient.h:
442 * WebCoreSupport/WebInspectorClient.cpp:
443 * WebDocumentLoader.h:
445 * WebDownloadCFNet.cpp:
446 * WebDownloadCurl.cpp:
447 * WebElementPropertyBag.cpp:
452 * WebFramePolicyListener.cpp:
453 * WebFramePolicyListener.h:
455 * WebHistoryItem.cpp:
456 * WebIconDatabase.cpp:
459 * WebJavaScriptCollector.cpp:
460 * WebKitGraphics.cpp:
461 * WebKitSystemBits.cpp:
462 * WebLocalizableStrings.cpp:
463 * WebMutableURLRequest.cpp:
464 * WebMutableURLRequest.h:
465 * WebNodeHighlight.cpp:
466 * WebNodeHighlight.h:
467 * WebNotificationCenter.cpp:
472 * WebURLAuthenticationChallenge.cpp:
473 * WebURLAuthenticationChallenge.h:
474 * WebURLAuthenticationChallengeSender.cpp:
475 * WebURLAuthenticationChallengeSenderCFNet.cpp:
476 * WebURLAuthenticationChallengeSenderCurl.cpp:
477 * WebURLCredential.cpp:
478 * WebURLCredential.h:
479 * WebURLProtectionSpace.cpp:
480 * WebURLProtectionSpace.h:
481 * WebURLResponse.cpp:
484 2011-03-29 Brent Fulgham <bfulgham@webkit.org>
486 Unreviewed build fix after r82247.
488 * WebMutableURLRequest.cpp: The new CertificateCFWin routines
489 are not CFNetwork-specific. All CF-based ports can use them.
491 2011-03-29 Patrick Gansterer <paroga@webkit.org>
493 Reviewed by Adam Roben.
495 [WIN] Use WCHAR instead of TCHAR
496 https://bugs.webkit.org/show_bug.cgi?id=57191
498 We always use the UNICODE versions of windows functions, so
499 the usage of TCHAR makes no sense and mixing them is bad style.
501 * DefaultDownloadDelegate.cpp:
502 * WebCoreSupport/WebChromeClient.cpp:
503 * WebCoreSupport/WebContextMenuClient.cpp:
504 * WebCoreSupport/WebInspectorClient.cpp:
506 * WebNotificationCenter.cpp:
507 * WebPreferences.cpp:
508 * WebURLResponse.cpp:
511 2011-03-29 Jeff Miller <jeffm@apple.com>
513 Reviewed by Jon Honeycutt.
515 Add WebCore::copyCertificateToData() on Windows
516 https://bugs.webkit.org/show_bug.cgi?id=57296
518 Remove duplicate code that implemented this functionality in WebMutableURLRequest.cpp and use WebCore::copyCertificateToData() instead.
520 * WebMutableURLRequest.cpp:
521 (WebMutableURLRequest::setClientCertificate): Use WebCore::copyCertificateToData().
523 2011-03-28 Patrick Gansterer <paroga@webkit.org>
525 Reviewed by Adam Roben.
527 [WIN] Remove unused DOMCreateInstance files
528 https://bugs.webkit.org/show_bug.cgi?id=57193
530 * DOMCreateInstance.cpp: Removed.
531 * DOMCreateInstance.h: Removed.
533 2011-03-28 Adele Peterson <adele@apple.com>
537 * WebFrame.cpp: (WebFrame::hasSpellingMarker):
538 Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
540 2011-03-28 Jeff Miller <jeffm@apple.com>
542 Reviewed by Adam Roben.
544 Include certificate when sending a WebCore::ResourceError to UI process on Windows
545 https://bugs.webkit.org/show_bug.cgi?id=57195
547 Rename callers of wkGetSSLPeerCertificateData() to use wkGetSSLPeerCertificateDataBytePtr(), since it returns a void*.
550 (WebError::sslPeerCertificate):
551 * WebURLResponse.cpp:
552 (WebURLResponse::sslPeerCertificate):
554 2011-03-28 Darin Adler <darin@apple.com>
556 Set eol-style to native on more files. I noticed the last check-in had an entire file
557 changing because of an EOL style change, and setting this property prevents that from
558 happening in future. We may want to do this systematically for more of WebKit later.
560 * AccessibleBase.cpp: Added property svn:eol-style.
561 * AccessibleBase.h: Added property svn:eol-style.
562 * AccessibleDocument.cpp: Added property svn:eol-style.
563 * AccessibleDocument.h: Added property svn:eol-style.
564 * AccessibleImage.cpp: Added property svn:eol-style.
565 * AccessibleImage.h: Added property svn:eol-style.
566 * COMVariantSetter.h: Added property svn:eol-style.
567 * FullscreenVideoController.cpp: Added property svn:eol-style.
568 * FullscreenVideoController.h: Added property svn:eol-style.
569 * WebCoreSupport/EmbeddedWidget.cpp: Added property svn:eol-style.
570 * WebCoreSupport/EmbeddedWidget.h: Added property svn:eol-style.
571 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: Added property svn:eol-style.
572 * WebCoreSupport/WebDesktopNotificationsDelegate.h: Added property svn:eol-style.
573 * WebCoreSupport/WebFrameLoaderClient.cpp: Added property svn:eol-style.
574 * WebCoreSupport/WebInspectorDelegate.cpp: Added property svn:eol-style.
575 * WebCoreSupport/WebInspectorDelegate.h: Added property svn:eol-style.
576 * WebCoreSupport/WebPlatformStrategies.cpp: Added property svn:eol-style.
577 * WebCoreSupport/WebPlatformStrategies.h: Added property svn:eol-style.
578 * WebCoreSupport/WebPluginHalterClient.cpp: Added property svn:eol-style.
579 * WebCoreSupport/WebPluginHalterClient.h: Added property svn:eol-style.
581 2011-03-28 Patrick Gansterer <paroga@webkit.org>
583 Unreviewed build fix.
585 * COMPropertyBag.h: Added missing include.
586 * WebKitCOMAPI.h: Ditto.
587 * WebCoreSupport/WebFrameLoaderClient.h: Added missing forward declaration.
589 2011-03-25 Sam Weinig <sam@webkit.org>
591 Reviewed by Jon Honeycutt.
593 WebScrollBar not updating when calling WebScrollBar::setValue.
594 <rdar://problem/9143871>
597 (WebScrollBar::setValue):
598 Call scrollToOffsetWithoutAnimation to actually update the scroll position.
600 2011-03-25 Andy Estes <aestes@apple.com>
602 Reviewed by Adele Peterson.
604 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
605 https://bugs.webkit.org/show_bug.cgi?id=49016
607 Update objectContentType() implementation to handle the
608 shouldPreferPlugInsForImages flag.
611 (WebFrame::objectContentType):
614 2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
616 Unreviewed, rolling out r81916 and r81917.
617 http://trac.webkit.org/changeset/81916
618 http://trac.webkit.org/changeset/81917
619 https://bugs.webkit.org/show_bug.cgi?id=57071
621 broke a test on platforms that do not have QuickTime installed
622 (Requested by estes on #webkit).
625 (WebFrame::objectContentType):
628 2011-03-24 Andy Estes <aestes@apple.com>
630 Reviewed by Darin Adler.
632 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
633 https://bugs.webkit.org/show_bug.cgi?id=49016
635 Update objectContentType() implementation to handle the
636 shouldPreferPlugInsForImages flag.
639 (WebFrame::objectContentType):
642 2011-03-23 Brady Eidson <beidson@apple.com>
644 Reviewed by Sam Weinig.
646 Change IconDatabase opening to allow for arbitrary filenames
647 https://bugs.webkit.org/show_bug.cgi?id=56977
649 * WebIconDatabase.cpp:
650 (WebIconDatabase::startUpIconDatabase):
652 2011-03-22 Brady Eidson <beidson@apple.com>
654 Reviewed by Sam Weinig.
656 <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876
657 WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread
659 Note that while the new client calls always come through on the main thread, our mechanisms to
660 route dispatches to the main thread are still valid and will still work.
662 Update to the new IconDatabaseClient interface:
663 * WebIconDatabase.cpp:
664 (WebIconDatabase::performImport):
665 (WebIconDatabase::didRemoveAllIcons):
666 (WebIconDatabase::didImportIconURLForPageURL):
667 (WebIconDatabase::didImportIconDataForPageURL):
668 (WebIconDatabase::didChangeIconForPageURL):
669 (WebIconDatabase::didFinishURLImport):
672 2011-03-17 Brady Eidson <beidson@apple.com>
674 Reviewed by Sam Weinig.
676 https://bugs.webkit.org/show_bug.cgi?id=56425
677 More groundwork for WebKit2 IconDatabase
679 Update already-used function names:
680 * WebIconDatabase.cpp:
681 (WebIconDatabase::iconForURL):
682 (WebIconDatabase::iconURLForURL):
683 (WebIconDatabase::hasIconForURL):
685 2011-03-18 Pavel Podivilov <podivilov@chromium.org>
687 Reviewed by Yury Semikhatsky.
689 Web Inspector: implement inspector session storage.
690 https://bugs.webkit.org/show_bug.cgi?id=56643
692 * WebCoreSupport/WebInspectorClient.cpp:
693 (WebInspectorClient::saveSessionSetting):
694 (WebInspectorClient::loadSessionSetting):
695 (WebInspectorFrontendClient::saveSessionSetting):
696 (WebInspectorFrontendClient::loadSessionSetting):
697 * WebCoreSupport/WebInspectorClient.h:
699 2011-03-11 Brady Eidson <beidson@apple.com>
701 More Windows build fix for https://bugs.webkit.org/show_bug.cgi?id=56216
703 * WebCoreStatistics.cpp:
704 * WebIconDatabase.cpp:
706 2011-03-09 Peter Kasting <pkasting@google.com>
708 Reviewed by Mihai Parparita.
710 Unify Windows version checks.
711 https://bugs.webkit.org/show_bug.cgi?id=55979
714 (WebView::standardUserAgentWithApplicationName):
715 (webKitVersionString):
717 2011-03-07 Sam Weinig <sam@webkit.org>
719 Reviewed by Anders Carlsson.
721 Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
722 https://bugs.webkit.org/show_bug.cgi?id=55827
724 Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
725 and pass the entire response, instead of just the MIMEType.
728 (WebFrame::dispatchDecidePolicyForResponse):
731 2011-03-04 Steve Falkenburg <sfalken@apple.com>
733 Reviewed by Darin Adler.
735 Adopt VersionStamper tool for Windows WebKit DLLs
736 https://bugs.webkit.org/show_bug.cgi?id=55784
738 Calculate the WebKit version for the useragent via autoversion.h
739 instead of reading it back from the DLL.
741 We now use a tool to stamp the version number onto the Apple WebKit DLLs
742 during the post-build step.
744 * WebKit.vcproj/WebKit.rc: Removed. This file wasn't used.
745 * WebKit.vcproj/WebKitLibCommon.vsprops: Fetch version from a string resource.
747 (WebView::standardUserAgentWithApplicationName): Use __BUILD_NUMBER_SHORT__ for the version.
750 2011-03-03 Anders Carlsson <andersca@apple.com>
752 Reviewed by Sam Weinig.
754 Get rid of Page::globalHistoryItem
755 https://bugs.webkit.org/show_bug.cgi?id=55738
757 * WebCoreSupport/WebFrameLoaderClient.cpp:
758 (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
759 Get the current history item and update it using WebView::setGlobalHistoryItem.
761 * WebCoreSupport/WebFrameLoaderClient.h:
763 (WebView::globalHistoryItem):
764 (WebView::setGlobalHistoryItem):
767 2011-03-03 Brent Fulgham <bfulgham@webkit.org>
769 Unreviewed build correction.
772 (scaleFactor): Update after 77286 to replace right/bottom
773 with new maxX/maxY terminology.
775 2011-03-03 Brady Eidson <beidson@apple.com>
777 Reviewed by Darin Adler.
779 https://bugs.webkit.org/show_bug.cgi?id=55721
780 Global IconDatabase should be returned by reference, not as a pointer
782 * WebCoreStatistics.cpp:
783 (WebCoreStatistics::iconPageURLMappingCount):
784 (WebCoreStatistics::iconRetainedPageURLCount):
785 (WebCoreStatistics::iconRecordCount):
786 (WebCoreStatistics::iconsWithDataCount):
787 * WebIconDatabase.cpp:
788 (WebIconDatabase::init):
789 (WebIconDatabase::startUpIconDatabase):
790 (WebIconDatabase::iconForURL):
791 (WebIconDatabase::retainIconForURL):
792 (WebIconDatabase::releaseIconForURL):
793 (WebIconDatabase::removeAllIcons):
794 (WebIconDatabase::iconURLForURL):
795 (WebIconDatabase::isEnabled):
796 (WebIconDatabase::setEnabled):
797 (WebIconDatabase::hasIconForURL):
798 (WebIconDatabase::getOrCreateDefaultIconBitmap):
802 2011-03-03 Alexey Proskuryakov <ap@apple.com>
804 Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included
807 * WebCoreSupport/WebChromeClient.h:
809 2011-03-02 Alexey Proskuryakov <ap@apple.com>
811 Reviewed by Darin Adler.
813 REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
814 https://bugs.webkit.org/show_bug.cgi?id=55633
815 <rdar://problem/8963023>
817 * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::keyboardUIMode):
818 * WebCoreSupport/WebChromeClient.h:
819 Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since
820 this platform doesn't observe or have full keyboard access state.
822 2011-03-03 Peter Kasting <pkasting@google.com>
824 Reviewed by James Robinson.
826 Drop redundant "Windows; " from the Windows-specific User Agent string.
827 https://bugs.webkit.org/show_bug.cgi?id=54567
830 (WebView::standardUserAgentWithApplicationName):
832 2011-03-01 Brian Weinstein <bweinstein@apple.com>
834 Reviewed by Adam Roben.
836 Part of WebKit2: Need a way to send notifications to client when cookies change
837 https://bugs.webkit.org/show_bug.cgi?id=55427
838 <rdar://problem/9056027>
840 Add stubs for CookiesStrategy on Windows WebKit1.
842 * WebCoreSupport/WebPlatformStrategies.cpp:
843 (WebPlatformStrategies::createCookiesStrategy):
844 (WebPlatformStrategies::notifyCookiesChanged):
845 * WebCoreSupport/WebPlatformStrategies.h:
847 2011-02-28 Chang Shu <cshu@webkit.org>
849 Reviewed by Ryosuke Niwa.
851 Remove the support of Frame::isContentEditable and its dependencies.
852 https://bugs.webkit.org/show_bug.cgi?id=54292
854 Remove the WebKit side implementation.
856 * WebCoreSupport/WebEditorClient.cpp:
857 * WebCoreSupport/WebEditorClient.h:
859 2011-02-28 Adam Roben <aroben@apple.com>
861 Build TestWebKitAPIInjectedBundle on Windows
863 Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
865 Reviewed by Darin Adler.
867 * WebKit.vcproj/WebKit.sln: Added TestWebKitAPIInjectedBundle. Let VS simplify the paths to
870 2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
872 Unreviewed, rolling out r78789.
873 http://trac.webkit.org/changeset/78789
874 https://bugs.webkit.org/show_bug.cgi?id=55409
876 Incorrect canvas fallback implementation (Requested by
877 inferno-sec on #webkit).
879 * AccessibleBase.cpp:
882 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
884 Reviewed by Pavel Feldman.
886 DumpRenderTree should reset frame opener between tests.
887 https://bugs.webkit.org/show_bug.cgi?id=54874
889 Added clearOpener method to IWebFramePrivate.
890 Touched WebKit.idl to trigger build scripts.
892 * Interfaces/IWebFramePrivate.idl:
893 * Interfaces/WebKit.idl:
895 (WebFrame::clearOpener):
898 2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
900 Unreviewed, rolling out r79764.
901 http://trac.webkit.org/changeset/79764
902 https://bugs.webkit.org/show_bug.cgi?id=55295
904 "broke Chromium builds" (Requested by rniwa on #webkit).
906 * Interfaces/IWebFramePrivate.idl:
907 * Interfaces/WebKit.idl:
911 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
913 Reviewed by Pavel Feldman.
915 DumpRenderTree should reset frame opener between tests.
916 https://bugs.webkit.org/show_bug.cgi?id=54874
918 Added clearOpener method to IWebFramePrivate.
919 Touched WebKit.idl to trigger build scripts.
921 * Interfaces/IWebFramePrivate.idl:
922 * Interfaces/WebKit.idl:
924 (WebFrame::clearOpener):
927 2011-02-24 Peter Kasting <pkasting@google.com>
929 Reviewed by Eric Seidel.
931 Drop the "U; " encryption level from the User Agent string.
932 https://bugs.webkit.org/show_bug.cgi?id=54566
935 (WebView::standardUserAgentWithApplicationName):
937 2011-02-24 Andrew Wilson <atwilson@chromium.org>
939 Unreviewed, rolling out r79570.
940 http://trac.webkit.org/changeset/79570
941 https://bugs.webkit.org/show_bug.cgi?id=54874
943 Breaks chromium build because glue/mocks/mock_web_frame.h/cc
946 * Interfaces/IWebFramePrivate.idl:
947 * Interfaces/WebKit.idl:
951 2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
953 Reviewed by Alexey Proskuryakov.
955 DumpRenderTree should reset frame opener between tests.
956 https://bugs.webkit.org/show_bug.cgi?id=54874
958 Added clearOpener method to IWebFramePrivate.
959 Touched WebKit.idl to trigger build scripts.
961 * Interfaces/IWebFramePrivate.idl:
962 * Interfaces/WebKit.idl:
964 (WebFrame::clearOpener):
967 2011-02-23 Patrick Gansterer <paroga@webkit.org>
969 Reviewed by Darin Adler.
971 Rename PLATFORM(CF) to USE(CF)
972 https://bugs.webkit.org/show_bug.cgi?id=53540
976 2011-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
978 Reviewed by Alexey Proskuryakov.
980 Drop the language tag part from the User Agent string
981 https://bugs.webkit.org/show_bug.cgi?id=54560
984 (WebView::standardUserAgentWithApplicationName):
986 2011-02-19 Charlie Reis <creis@chromium.org>
988 Reviewed by Mihai Parparita.
990 Ensure loading has stopped in HistoryController::goToItem
991 https://bugs.webkit.org/show_bug.cgi?id=54517
993 Add a FrameLoaderClient callback for whether to stop loading before goToItem.
995 Test: http/tests/navigation/forward-to-fragment-fires-onload.html
997 * WebCoreSupport/WebFrameLoaderClient.cpp:
998 (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
999 * WebCoreSupport/WebFrameLoaderClient.h:
1001 2011-02-16 David Hyatt <hyatt@apple.com>
1003 Reviewed by Dan Bernstein.
1005 https://bugs.webkit.org/show_bug.cgi?id=54244
1007 Convert the line box tree to floating point and eliminate font rounding hacks. This patch removes all of the rounding
1008 hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
1010 The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
1011 been changed as well.
1013 In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
1015 Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
1017 Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
1018 still have a precise floating point position.
1020 Justification will now allow subpixel positioning to occur as well. Platforms that don't support subpixel positioning should already
1021 be rounding justification spacing in their font code.
1023 Many layout test results change on Mac, since rounding hacks were used there and are now gone.
1025 * WebKitGraphics.cpp:
1026 (CenterTruncateStringToWidth):
1027 (RightTruncateStringToWidth):
1029 2011-02-10 Luiz Agostini <luiz.agostini@openbossa.org>
1031 Reviewed by Adam Roben.
1033 HTML5 <details> and <summary>: localized text
1034 https://bugs.webkit.org/show_bug.cgi?id=54260
1036 The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
1037 provide the default label to be used by a <details> tag that has no <summary> child.
1039 * WebCoreSupport/WebPlatformStrategies.cpp:
1040 (WebPlatformStrategies::defaultDetailsSummaryText):
1041 * WebCoreSupport/WebPlatformStrategies.h:
1043 2011-02-16 Dominic Mazzoni <dmazzoni@google.com>
1045 Reviewed by Chris Fleizach.
1047 Add new role for canvas elements.
1049 https://bugs.webkit.org/show_bug.cgi?id=50126
1051 Test: accessibility/canvas-fallback-content.html
1053 * AccessibleBase.cpp:
1056 2011-02-15 Kenneth Russell <kbr@google.com>
1058 Unreviewed. Remove whitespace-only change from
1059 http://trac.webkit.org/changeset/78620 (https://bugs.webkit.org/show_bug.cgi?id=54312)
1060 now that the patch has passed the Windows build bots.
1062 * Interfaces/WebKit.idl:
1064 2011-02-15 Kenneth Russell <kbr@google.com>
1066 Reviewed by Darin Fisher.
1068 Allow controlling minimum DOMTimer interval on a per-page basis
1069 https://bugs.webkit.org/show_bug.cgi?id=54312
1071 Added needed methods to implement LayoutTestController's new
1072 setMinimumTimerInterval method. Includes whitespace-only change to
1073 WebKit.idl to trigger proper rebuild on bots; will be removed in
1076 * Interfaces/IWebViewPrivate.idl:
1077 * Interfaces/WebKit.idl:
1079 (WebView::initWithFrame):
1080 (WebView::defaultMinimumTimerInterval):
1081 (WebView::setMinimumTimerInterval):
1084 2011-01-26 MORITA Hajime <morrita@google.com>
1086 Reviewed by Ryosuke Niwa.
1088 Refactoring: Extract TextCheckerClient from EditorClient
1089 https://bugs.webkit.org/show_bug.cgi?id=53213
1091 * WebCoreSupport/WebEditorClient.h:
1092 (WebEditorClient::textChecker):
1094 2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
1096 Reviewed by Adam Barth.
1098 Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
1099 https://bugs.webkit.org/show_bug.cgi?id=52417
1101 Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
1104 * WebCoreSupport/WebEditorClient.cpp:
1105 (WebEditorClient::canCopyCut): Added.
1106 (WebEditorClient::canPaste): Added.
1107 * WebCoreSupport/WebEditorClient.h:
1109 2011-02-14 Brian Weinstein <bweinstein@apple.com>
1111 Reviewed by Brady Eidson.
1113 Need WebKit API to determine whether we have a site icon for a given URL
1114 https://bugs.webkit.org/show_bug.cgi?id=54400
1116 This patch implements IWebIconDatabase::hasIconForURL which tells us whether or not
1117 we have a site icon for the given URL.
1119 * Interfaces/IWebIconDatabase.idl: Added new function.
1120 * Interfaces/WebKit.idl: Touched to make sure Interfaces rebuilds.
1121 * WebIconDatabase.cpp:
1122 (WebIconDatabase::hasIconForURL): Call IconDatabase::iconForPageURL to make sure we
1123 load the icon from disk, and call iconURLForPageURL to determine whether or not
1124 we actually have an icon.
1125 * WebIconDatabase.h:
1127 2011-02-11 Geoffrey Garen <ggaren@apple.com>
1129 Reviewed by Oliver Hunt.
1131 A little more encapsulation for the heap: Removed CollectorHeapIterator
1132 https://bugs.webkit.org/show_bug.cgi?id=54298
1134 * WebCoreStatistics.cpp:
1135 (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
1137 2011-02-09 Pavel Feldman <pfeldman@chromium.org>
1139 Reviewed by Yury Semikhatsky.
1141 Web Inspector: follow up on InspectorAgent split -
1142 removing unnecessary methods from InspectorController.
1143 https://bugs.webkit.org/show_bug.cgi?id=54093
1146 (WebInspector::showConsole):
1147 (WebInspector::toggleProfilingJavaScript):
1149 2011-02-08 Adam Barth <abarth@webkit.org>
1151 Reviewed by Eric Seidel.
1153 Remove orphan code from old parser
1154 https://bugs.webkit.org/show_bug.cgi?id=53984
1156 * WebCoreSupport/WebChromeClient.h:
1158 2011-02-08 David Hyatt <hyatt@apple.com>
1160 Reviewed by Adam Roben.
1162 <rdar://problem/8932077> REGRESSION (5.0.3-ToT): United boarding pass has wrong layout when printed
1164 Windows never got patched to pass in the page height to WebCore, so when WebCore's pagination got re-written to depend on this
1165 value, Windows got broken. Patch setPrinting to be identical to WebKit1 on OS X and to have it take an extra minimum page height
1169 (WebFrame::setPrinting):
1170 (WebFrame::setInPrintingMode):
1173 2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
1175 Reviewed by Yury Semikhatsky.
1177 Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
1179 https://bugs.webkit.org/show_bug.cgi?id=53169
1181 Minor change enforced by major changes in WebCore/inspector/InspectorController.
1184 (WebInspector::isTimelineProfilingEnabled):
1186 2011-02-07 Enrica Casucci <enrica@apple.com>
1188 Reviewed Adam Roben and Darin Adler.
1190 WebKit2: drag and drop support on Windows.
1191 https://bugs.webkit.org/show_bug.cgi?id=52775
1193 Removed createDragImageForLink from DragClient.
1195 * WebCoreSupport/WebDragClient.cpp:
1196 (WebDragClient::startDrag):
1197 * WebCoreSupport/WebDragClient.h:
1199 2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
1201 Reviewed by Darin Adler.
1203 OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
1204 https://bugs.webkit.org/show_bug.cgi?id=52867
1207 (WebHistory::orderedLastVisitedDays): Calls adoptArrayPtr.
1208 * WebPreferences.cpp:
1209 (WebPreferences::copyWebKitPreferencesToCFPreferences): Ditto.
1211 2011-02-03 Yury Semikhatsky <yurys@chromium.org>
1213 Reviewed by Pavel Feldman.
1215 Web Inspector: remove settings related methods from InspectorClient
1216 https://bugs.webkit.org/show_bug.cgi?id=53686
1218 * WebCoreSupport/WebInspectorClient.cpp:
1219 (WebInspectorClient::openInspectorFrontend):
1220 (WebInspectorFrontendClient::WebInspectorFrontendClient):
1221 * WebCoreSupport/WebInspectorClient.h:
1223 2011-02-03 Adam Langley <agl@chromium.org>
1225 Reviewed by Adam Barth.
1227 Plumb mixed script URL to FrameLoaderClient
1228 https://bugs.webkit.org/show_bug.cgi?id=52384
1230 Regressions covered by http/tests/security/mixedContent/*
1232 * WebCoreSupport/WebFrameLoaderClient.cpp:
1233 (WebFrameLoaderClient::didRunInsecureContent):
1234 * WebCoreSupport/WebFrameLoaderClient.h:
1236 2011-02-02 David Hyatt <hyatt@apple.com>
1238 Reviewed by Darin Adler.
1240 Removal of right()/bottom(), converting to maxX()/maxY().
1242 * DOMHTMLClasses.cpp:
1243 (DOMHTMLInputElement::rectOnScreen):
1244 * WebCoreSupport/EmbeddedWidget.cpp:
1245 (EmbeddedWidget::frameRectsChanged):
1247 (WebFrame::computePageRects):
1249 (WebScrollBar::frameRect):
1251 (WebView::addToDirtyRegion):
1252 (WebView::visibleContentRect):
1253 (WebView::prepareCandidateWindow):
1255 2011-01-31 Brady Eidson <beidson@apple.com>
1257 Reviewed by Adam Roben.
1259 Fix the clean Windows build.
1261 * WebKitGraphics.cpp:
1264 2011-01-28 Jon Honeycutt <jhoneycutt@apple.com>
1266 Downloads in WK2 on Windows should write resume data to bundle
1267 https://bugs.webkit.org/show_bug.cgi?id=53282
1268 <rdar://problem/8753077>
1270 Reviewed by Alice Liu.
1273 (WebDownload::bundlePathForTargetPath):
1274 Use the new WebCore::DownloadBundle function.
1275 (WebDownload::request):
1278 Removed declarations for functions that were moved to a new location.
1280 * WebDownloadCFNet.cpp:
1281 (WebDownload::initToResumeWithBundle):
1282 Use the new WebCore::DownloadBundle function.
1283 (WebDownload::cancelForResume):
1284 Fix a leak of the resume data CFDataRef by using adoptCF(). Use the new
1285 WebCore::DownloadBundle function.
1287 2011-01-28 Dan Bernstein <mitz@apple.com>
1289 Reviewed by Sam Weinig.
1291 <select> can't display right-to-left (rtl) languages
1292 https://bugs.webkit.org/show_bug.cgi?id=19785
1294 * WebCoreSupport/WebChromeClient.cpp:
1295 (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.
1296 * WebCoreSupport/WebChromeClient.h:
1298 2011-01-27 Nate Chapin <japhet@chromium.org>
1300 Reviewed by Adam Barth.
1302 Use Document::url() instead of FrameLoader::url().
1303 https://bugs.webkit.org/show_bug.cgi?id=41165
1308 2011-01-27 Sam Weinig <sam@webkit.org>
1310 Reviewed by Adam Roben.
1312 Fix scrollbars in Safari's Downloads window and Bookmarks view by
1313 implementing two needed functions from ScrollableArea.
1316 (WebScrollBar::horizontalScrollbar): Return the WebCore::Scrollbar if
1317 we are a horizontal scrollbar.
1318 (WebScrollBar::verticalScrollbar): Return the WebCore::Scrollbar if we
1319 are a vertical scrollbar.
1322 2011-01-27 Adam Roben <aroben@apple.com>
1324 Trim down #includes in WebView.h
1326 Rubber-stamped by Steve Falkenburg.
1328 * WebView.cpp: Moved some #includes here from the header file.
1330 * WebView.h: Replaced some broader #includes with more specific ones, plus a
1331 forward-declaration.
1333 2011-01-25 Steve Falkenburg <sfalken@apple.com>
1335 Windows production build fix.
1336 Build correct configuration of Interfaces for Debug_All.
1338 * WebKit.vcproj/WebKit.submit.sln:
1340 2011-01-25 Steve Falkenburg <sfalken@apple.com>
1342 Rubber-stamped by Adam Roben.
1344 Windows production build fix.
1345 Use correct environment variable escaping
1347 * WebKit.vcproj/WebKit.make:
1349 2011-01-24 Chris Marrin <cmarrin@apple.com>
1351 Reviewed by Eric Seidel.
1353 Change ENABLE_3D_CANVAS to ENABLE_WEBGL
1354 https://bugs.webkit.org/show_bug.cgi?id=53041
1357 (WebView::notifyPreferencesChanged):
1359 2011-01-25 Yury Semikhatsky <yurys@chromium.org>
1361 Reviewed by Pavel Feldman.
1363 Web Inspector: remove "attached" state related methods from InspectorAgent
1364 https://bugs.webkit.org/show_bug.cgi?id=53086
1366 * WebCoreSupport/WebInspectorClient.cpp:
1367 (WebInspectorFrontendClient::attachWindow):
1368 (WebInspectorFrontendClient::detachWindow):
1369 (WebInspectorFrontendClient::showWindowWithoutNotifications):
1370 * WebCoreSupport/WebInspectorClient.h:
1372 2011-01-24 Adam Roben <aroben@apple.com>
1374 Windows Production build fix
1376 * WebKit.vcproj/WebKit.make: Update for move of WebKit into Source.
1378 2011-01-21 Nikolas Zimmermann <nzimmermann@rim.com>
1380 Reviewed by Dirk Schulze.
1382 Introduce FontMetrics abstraction
1383 https://bugs.webkit.org/show_bug.cgi?id=51456
1385 * FullscreenVideoController.cpp: Use FontMetrics instead of Font to access the metrics.
1386 (FullscreenVideoController::draw):
1387 * WebCoreSupport/WebDragClient.cpp: Ditto.
1388 (WebDragClient::createDragImageForLink):
1389 * WebKitGraphics.cpp: Ditto.
1392 2011-01-21 Chris Rogers <crogers@google.com>
1394 Reviewed by Darin Fisher.
1396 Add run-time enable support for the web audio API
1397 https://bugs.webkit.org/show_bug.cgi?id=52741
1399 * WebPreferenceKeysPrivate.h:
1401 (WebView::notifyPreferencesChanged):
1403 2011-01-21 Sam Weinig <sam@webkit.org>
1409 2011-01-21 Sam Weinig <sam@webkit.org>
1411 Reviewed by Anders Carlsson.
1413 Part 2 of "Cleanup Scrollbar/ScrollbarClient relationship"
1414 https://bugs.webkit.org/show_bug.cgi?id=52779
1416 Rename ScrollbarClient -> ScrollableArea.
1419 (WebScrollBar::scroll):
1422 2011-01-20 Adam Roben <aroben@apple.com>
1424 Update for CACFLayerTreeHost changes
1426 Fixes <http://webkit.org/b/52852> Flushing layer changes and rendering are intertwined in
1427 CACFLayerTreeHost, but shouldn't be
1429 Reviewed by Simon Fraser.
1432 (WebView::paint): Changed to flush layer changes via CACFLayerTreeHost, which will call back
1433 to our own flushing function if needed.
1435 * WebView.h: Removed shouldRender, which is no longer used or needed.
1437 2011-01-21 Adam Roben <aroben@apple.com>
1439 Update for WKCACFLayerRenderer -> CACFLayerTreeHost rename
1441 Also renamed WebView::m_layerRenderer to WebView::m_layerTreeHost to match.
1443 Fixes <http://webkit.org/b/52898> WKCACFLayerRenderer sounds like a render object, but isn't
1445 Reviewed by Simon Fraser.
1447 * WebPreferences.cpp:
1449 (WebView::setAcceleratedCompositing): Also made sure to remove our HWND from the layer tree
1450 host before we get rid of the layer tree host itself.
1453 2011-01-21 Adam Roben <aroben@apple.com>
1455 Replace some "sync compositing state" terminology with "flush pending GraphicsLayer changes"
1457 This seems to be the direction in which our code is moving. I chose "GraphicsLayer" as
1458 opposed to just "layer" because there are cases where we flush changes to CACFLayers that
1459 don't have a corresponding GraphicsLayer.
1461 Fixes <http://webkit.org/b/52894> "Sync compositing state" terminology in
1462 WKCACFLayerRenderer and friends is confusing
1464 Reviewed by Simon Fraser.
1466 * WebCoreSupport/WebChromeClient.cpp:
1467 (WebChromeClient::scheduleCompositingLayerSync): Updated for WebView changes.
1470 (WebView::paint): Updated for rename.
1471 (WebView::flushPendingGraphicsLayerChangesSoon): Renamed from scheduleCompositingLayerSync.
1472 (WebView::notifySyncRequired): Updated for rename.
1473 (WebView::flushPendingGraphicsLayerChanges): Renamed from syncCompositingState.
1475 * WebView.h: Did the renames.
1477 2011-01-20 Sam Weinig <sam@webkit.org>
1479 Reviewed by Dave Hyatt.
1481 Cleanup Scrollbar/ScrollbarClient relationship
1482 https://bugs.webkit.org/show_bug.cgi?id=52779
1485 (WebScrollBar::WebScrollBar):
1486 (WebScrollBar::setValue):
1487 (WebScrollBar::value):
1488 (WebScrollBar::scroll):
1489 (WebScrollBar::scrollPosition):
1490 (WebScrollBar::setScrollOffset):
1493 2011-01-19 Adam Roben <aroben@apple.com>
1495 Update for WKCACFLayerRenderer changes
1497 Fixes <http://webkit.org/b/52749> WKCACFLayerRenderer should be
1500 Reviewed by Simon Fraser.
1503 (WebView::~WebView): Added some assertions to make sure we've gotten rid of our
1504 compositing-related members. My biggest concern was making sure that m_layerRenderer was
1505 gone, which would also mean we had nulled out its client pointer.
1506 (WebView::setAcceleratedCompositing): Changed to call WKCACFLayerRenderer::setClient instead
1507 of passing the client into create(), and to clear out the client before nulling out
1510 * WebView.h: Changed m_layerRenderer from an OwnPtr to a RefPtr.
1512 2011-01-19 Adam Roben <aroben@apple.com>
1514 Teach WebView::scrollBackingStore about compositing mode
1517 compositing/scroll-painted-composited-content.html
1519 Fixes <http://webkit.org/b/52720> REGRESSION (r75987): Assertion failure in
1520 WebView::scrollBackingStore when scrolling page with composited content
1522 Reviewed by Anders Carlsson.
1525 (WebView::scrollBackingStore): Do something sensible (though naive) when in compositing
1526 mode, rather than incorrectly asserting that this function is never called in that case. For
1527 now we just repaint the entire scrolled region; someday hopefully we can avoid having to
1528 repaint the areas that have just been moved.
1530 2011-01-19 Simon Fraser <simon.fraser@apple.com>
1532 Reviewed by Sam Weinig.
1534 GraphicsLayers in subframes can get sync'd multiple times
1535 https://bugs.webkit.org/show_bug.cgi?id=52489
1538 (WebView::syncCompositingState): syncCompositingStateRecursive()
1539 was renamed to syncCompositingStateIncludingSubframes().
1541 2011-01-17 Adam Roben <aroben@apple.com>
1543 Update for WKCACFLayerRenderer changes
1545 Fixes <http://webkit.org/b/52587> WKCACFLayerRenderer is hard to use
1547 Reviewed by Chris Marrin.
1550 (WebView::WebViewWndProc): Removed call to layerRendererBecameVisible
1551 when handling WM_SHOWWINDOW. All this did was try to create the
1552 renderer, but it had already been created in setAcceleratedCompositing,
1554 (WebView::setAcceleratedCompositing): Removed call to createRenderer;
1555 setHostWindow does this for us now.
1557 * WebView.h: Removed animationsStarted and layerRendererBecameVisible.
1559 2011-01-17 Adam Roben <aroben@apple.com>
1561 Paint directly into a GraphicsLayer when using accelerated compositing
1563 Before this patch, we were painting into our normal backing store
1564 HBITMAP, wrapping it in a CGImage, and handing it off to Core
1565 Animation. This had at least two disadvantages:
1566 1) The bitmap could be modified while Core Animation was using it.
1567 2) It introduced extra complexity.
1569 When entering accelerated compositing mode, WebView now creates a
1570 GraphicsLayer to draw into. This GraphicsLayer sits between the root
1571 layer (owned by WKCACFLayerRenderer) and the RenderView's layer. When
1572 WebView invalidates, it just calls setNeedsDisplayInRect on its
1573 GraphicsLayer. When WebView paints, it just tells its
1574 WKCACFLayerRenderer to paint, which will call back to WebView to draw
1575 into the GraphicsLayer if it has a dirty region. This is very similar
1576 to the current implementation of LayerBackedDrawingArea in WebKit2.
1578 Fixes <http://webkit.org/b/52582> WebView should paint directly into a
1579 GraphicsLayer when in accelerated compositing mode
1581 Reviewed by Simon Fraser and Chris Marrin.
1583 * WebCoreSupport/WebChromeClient.cpp:
1584 (WebChromeClient::attachRootGraphicsLayer):
1585 (WebChromeClient::scheduleCompositingLayerSync):
1586 Updated for WebView changes.
1589 (WebView::repaint): When using accelerated compositing, just invalidate
1590 our backing layer. This matches the behavior of LayerBackedDrawingArea.
1591 (WebView::deleteBackingStore): Removed accelerated compositing code.
1592 The WKCACFLayerRenderer doesn't need to know about our backing store
1593 anymore; we don't use it at all when in accelerated compositing mode.
1594 (WebView::addToDirtyRegion): When using accelerated compositing, just
1595 invalidate our backing layer.
1596 (WebView::scrollBackingStore): Added an assertion that this isn't
1597 called in accelerated compositing mode.
1598 (WebView::sizeChanged): Update our backing layer's size, too, and
1600 (WebView::updateBackingStore): Added an assertion that this isn't
1601 called in accelerated compositing mode.
1602 (WebView::paint): If we're in accelerated compositing mode, sync our
1603 compositing state. If we're *still* in accelerated compositing mode,
1604 just tell our WKCACFLayerRenderer to paint and clear our dirty region.
1605 (The later changes in this function are just un-indenting code that
1606 used to be inside an if.)
1608 (WebView::paintIntoBackingStore):
1609 (WebView::paintIntoWindow):
1610 Added assertions that these aren't called in accelerated compositing
1613 (WebView::WebViewWndProc): Updated WM_XP_THEMECHANGED handling for
1614 removal of setRootLayerNeedsDisplay.
1615 (WebView::setRootChildLayer): Changed to take a GraphicsLayer. We now
1616 set the layer as a child of our own backing layer.
1617 (WebView::scheduleCompositingLayerSync): Just call through to
1618 WKCACFLayerRenderer.
1619 (WebView::setAcceleratedCompositing): Create our backing layer and set
1620 it as the child of WKCACFLayerRenderer's root layer.
1621 (WebView::notifyAnimationStarted): Added. We never expect this
1622 GraphicsLayerClient override to be called, as we don't use animations
1623 on our backing layer.
1624 (WebView::notifySyncRequired): Added. Just schedule a sync.
1625 (WebView::paintContents): Added. Just clip and paint!
1627 (WebView::showDebugBorders):
1628 (WebView::showRepaintCounter):
1629 Added. These just call through to Settings.
1631 (WebView::syncCompositingState): Changed to first update layout, then
1632 sync state for our backing layer, then sync WebCore's state. This
1633 matches LayerBackedDrawingArea.
1635 * WebView.h: WebView now implements the GraphicsLayerClient interface.
1636 Removed setRootLayerNeedsDisplay; it's been replaced by calling
1637 setNeedsDisplay on our backing layer and calling
1638 syncCompositingStateSoon on WKCACFLayerRenderer as needed. Removed
1639 updateRootLayerContents; that function was used to pass our backing
1640 store to Core Animation, which we no longer do. Added m_backingLayer.
1642 2011-01-17 Tony Gentilcore <tonyg@chromium.org>
1644 Reviewed by Alexey Proskuryakov.
1646 Fix some headers with missing or misspelled #ifndef guards
1647 https://bugs.webkit.org/show_bug.cgi?id=52545
1649 * WebKitStatistics.h:
1651 2011-01-17 Pavel Feldman <pfeldman@chromium.org>
1653 Reviewed by Yury Semikhatsky.
1655 Web Inspector: simplify debugger enabling routine.
1656 https://bugs.webkit.org/show_bug.cgi?id=52472
1659 (WebInspector::toggleDebuggingJavaScript):
1661 2011-01-16 Adam Barth <abarth@webkit.org>
1663 Rubber-stamped by Eric Seidel.
1665 Move WebKit into Source
1666 https://bugs.webkit.org/show_bug.cgi?id=52530
1668 * WebKit.vcproj/Interfaces.vcproj:
1669 * WebKit.vcproj/WebKit.sln:
1670 * WebKit.vcproj/WebKit.vcproj:
1671 * WebKit.vcproj/WebKitGUID.vcproj:
1673 2011-01-15 Adam Barth <abarth@webkit.org>
1675 Rubber-stamped by Eric Seidel.
1677 Move WebKit2 into Source
1678 https://bugs.webkit.org/show_bug.cgi?id=52438
1680 Update reference to WebKit2.
1682 * WebKit.vcproj/WebKit.sln:
1684 2011-01-14 Yuzo Fujishima <yuzo@google.com>
1686 Reviewed by Antti Koivisto.
1688 Rename cache() to memoryCache()
1689 https://bugs.webkit.org/show_bug.cgi?id=52433
1692 (WebCache::statistics):
1694 (WebCache::setDisabled):
1695 (WebCache::disabled):
1697 (WebView::setCacheModel):
1699 2011-01-10 Geoffrey Garen <ggaren@apple.com>
1701 Try to fix Windows build.
1703 * WebJavaScriptCollector.cpp: Updated for rename to Heap.*. (Didn't catch
1704 this one before because it was miscapitalized.)
1706 2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>
1708 Reviewed by Darin Fisher.
1710 https://bugs.webkit.org/show_bug.cgi?id=41441
1711 createWindow method should only do window-creating without URL navigation
1713 * WebCoreSupport/WebChromeClient.cpp:
1714 (WebChromeClient::createWindow):
1716 2011-01-07 Adam Barth <abarth@webkit.org>
1718 Rubber-stamped by Eric Seidel.
1720 Move WebCore to Source
1721 https://bugs.webkit.org/show_bug.cgi?id=52050
1723 * WebKit.vcproj/WebKit.sln:
1725 2011-01-06 Gavin Barraclough <barraclough@apple.com>
1727 Reviewed by Geoff Garen.
1729 Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
1731 The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
1732 destructor early, in order to release wrappers once we know we no longer intend to use them.
1733 Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
1734 lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
1735 A sequence of events that triggers the bug would look like this:
1737 (1) Create a DOMWrapperWorld.
1738 (2) Register a timer in the world.
1739 (3) Call unregisterWorld() on the world.
1740 (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
1741 (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
1742 called forgetWorld() none exists.
1743 (6) Attempt to add a wrapper to a NULL map.
1745 Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
1747 * WebScriptWorld.cpp:
1748 (WebScriptWorld::unregisterWorld):
1750 2011-01-07 Chris Marrin <cmarrin@apple.com>
1752 Rubber-stamped by Simon Fraser.
1754 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
1755 https://bugs.webkit.org/show_bug.cgi?id=49388
1757 Change client API for the fullscreen video controller. It now uses a
1758 PlatformCALayerClient so it can use a PlaformCALayer directly. Also
1759 updated how to connect the layer tree to the view to reflect the updated
1760 hardware compositing logic.
1762 * FullscreenVideoController.cpp:
1763 (FullscreenVideoController::LayerClient::LayerClient):
1764 (FullscreenVideoController::LayerClient::platformCALayerRespondsToLayoutChanges):
1765 (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
1766 (FullscreenVideoController::LayerClient::platformCALayerContentsOrientation):
1767 (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
1768 (FullscreenVideoController::LayerClient::platformCALayerShowDebugBorders):
1769 (FullscreenVideoController::LayerClient::platformCALayerShowRepaintCounter):
1770 (FullscreenVideoController::LayerClient::platformCALayerIncrementRepaintCount):
1771 (FullscreenVideoController::LayerClient::platformCALayerContentsOpaque):
1772 (FullscreenVideoController::LayerClient::platformCALayerDrawsContent):
1773 (FullscreenVideoController::LayerClient::platformCALayerLayerDidDisplay):
1774 (FullscreenVideoController::LayerClient::platformCALayerLayoutSublayersOfLayer):
1775 (FullscreenVideoController::FullscreenVideoController):
1776 (FullscreenVideoController::~FullscreenVideoController):
1777 (FullscreenVideoController::enterFullscreen):
1778 * FullscreenVideoController.h:
1779 * WebCoreSupport/WebChromeClient.cpp:
1780 (WebChromeClient::attachRootGraphicsLayer):
1781 (WebChromeClient::scheduleCompositingLayerSync):
1783 (WebView::setRootChildLayer):
1784 (WebView::animationsStarted):
1785 (WebView::syncCompositingState):
1787 (WebView::setRootLayerNeedsDisplay):
1789 2011-01-05 Steve Falkenburg <sfalken@apple.com>
1791 Reviewed by Darin Adler.
1793 Debug and Release builds on Windows clobber each other
1794 https://bugs.webkit.org/show_bug.cgi?id=49185
1796 Changes the structure of WebKitBuild build products directory so we
1797 completely separate each build configuration into independent directories.
1799 Although we previously had per-configuration directories for obj, this change adds
1800 per-configuration directories for bin, lib, obj, and include. Each configuration's
1801 build products are stored within a directory inside of WebKitBuild.
1803 Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1804 defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1806 * WebKit.vcproj/InterfacesCommon.vsprops:
1807 * WebKit.vcproj/InterfacesPostBuild.cmd:
1808 * WebKit.vcproj/InterfacesPreBuild.cmd:
1809 * WebKit.vcproj/WebKit.make:
1810 * WebKit.vcproj/WebKitGUID.vcproj:
1811 * WebKit.vcproj/WebKitGUIDCommon.vsprops:
1812 * WebKit.vcproj/WebKitGUIDPostBuild.cmd:
1813 * WebKit.vcproj/WebKitGUIDPreBuild.cmd:
1814 * WebKit.vcproj/WebKitLibCommon.vsprops:
1815 * WebKit.vcproj/WebKitLibPostBuild.cmd:
1816 * WebKit.vcproj/WebKitLibPreBuild.cmd:
1818 2011-01-04 Chris Fleizach <cfleizach@apple.com>
1820 Reviewed by Sam Weinig.
1822 WK2: Support Accessibility
1823 https://bugs.webkit.org/show_bug.cgi?id=51859
1825 Use rootObject() method to get the top of the AX tree.
1827 * AccessibleDocument.cpp:
1828 (AccessibleDocument::AccessibleDocument):
1830 2011-01-01 Adam Barth <abarth@webkit.org>
1832 Reviewed by Eric Seidel.
1834 Move JavaScriptCore to Source
1835 https://bugs.webkit.org/show_bug.cgi?id=51604
1837 * WebKit.vcproj/WebKit.sln:
1838 - Point to JavaScriptCore in its new location.
1840 2010-12-22 Sam Weinig <sam@webkit.org>
1842 Reviewed by Darin Adler.
1844 WebKit2 needs to mirror the frame tree in the UIProcess
1845 https://bugs.webkit.org/show_bug.cgi?id=51546
1847 - Add client functions to notify that a frame has been added or
1848 removed from the page cache.
1850 * WebCoreSupport/WebFrameLoaderClient.cpp:
1851 (WebFrameLoaderClient::didSaveToPageCache):
1852 (WebFrameLoaderClient::didRestoreFromPageCache):
1853 * WebCoreSupport/WebFrameLoaderClient.h:
1855 2010-12-22 Dan Bernstein <mitz@apple.com>
1857 Changed WebKitTools to Tools.
1859 * WebKit.vcproj/WebKit.sln:
1861 2010-12-14 Adam Roben <aroben@apple.com>
1863 Always record the last-set cursor, even when the UI delegate is
1864 setting the cursor for us
1866 Prior to r63339, the last-set cursor was recorded in Widget::setCursor.
1867 r63339 moved that code up to WebChromeClient, but failed to call it
1868 when the UI delegate was the one setting the cursor.
1870 Fixes <http://webkit.org/b/45692> <rdar://problem/8423464> REGRESSION
1871 (r63339): Mouse cursor disappears when holding mouse button down on
1874 Reviewed by Ada Chan.
1876 * WebCoreSupport/WebChromeClient.cpp:
1877 (WebChromeClient::setCursor): After the cursor is set, regardless of
1878 whether the UI delegate sets it or we set it, record the cursor that
1879 was just set. That way we'll be able to use the cursor later when
1880 responding to the WM_SETCURSOR message.
1882 2010-12-13 Alexey Proskuryakov <ap@apple.com>
1884 Reviewed by Adam Barth.
1886 https://bugs.webkit.org/show_bug.cgi?id=50953
1887 DNS Prefetch should be an opt-in feature
1889 * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Changed default to NO.
1891 2010-10-28 MORITA Hajime <morrita@google.com>
1893 Reviewed by Ojan Vafai.
1895 spellcheck does not check pasted text
1896 https://bugs.webkit.org/show_bug.cgi?id=40092
1898 Added a stub implememntation.
1900 * WebCoreSupport/WebEditorClient.h:
1901 (WebEditorClient::requestCheckingOfString):
1903 2010-12-10 Chris Fleizach <cfleizach@apple.com>
1905 Reviewed by Darin Adler.
1907 AX: refactor AccessibilityRenderObject::doAccessibilityHitTest
1908 https://bugs.webkit.org/show_bug.cgi?id=50574
1910 * AccessibleBase.cpp:
1911 (AccessibleBase::accHitTest):
1913 2010-12-09 Brian Weinstein <bweinstein@apple.com>
1915 Reviewed by Adam Roben.
1917 Prep for WebKit2: Context menu support on Windows
1918 https://bugs.webkit.org/show_bug.cgi?id=50514
1920 Update WebKit for the new CROSS_PLATFORM_CONTEXT_MENUS flag, and define customizeMenu
1921 instead of getCustomMenuFromDefaultItems.
1923 * WebCoreSupport/WebContextMenuClient.cpp:
1924 (WebContextMenuClient::customizeMenu): getCustomMenuFromDefaultItems was turned into
1925 this function, with refactoring using nativeMenu instead of platformDescription.
1926 (WebContextMenuClient::contextMenuItemSelected): Use nativeMenu instead of platformDescription.
1927 * WebCoreSupport/WebContextMenuClient.h:
1929 (WebView::handleContextMenuEvent): Call nativeMenu instead of platformDescription.
1930 (WebView::performContextMenuAction): Only call itemAtIndex with one argument, no need
1933 2010-12-07 Brian Weinstein <bweinstein@apple.com>
1935 Reviewed by John Sullivan.
1937 Layering Violation in ContextMenu - member variable of type HitTestResult
1938 https://bugs.webkit.org/show_bug.cgi?id=50586
1940 Update users of ContextMenu and ContextMenuController to match where the new functions
1943 * WebCoreSupport/WebContextMenuClient.cpp:
1944 (WebContextMenuClient::getCustomMenuFromDefaultItems): Get the HitTestResult and ContextMenu from the
1945 ContextMenuController (from the page).
1946 (WebContextMenuClient::contextMenuItemSelected): Get the HitTestResult from the ContextMenuController.
1948 (WebView::handleContextMenuEvent): Ditto.
1950 2010-12-07 Jessie Berlin <jberlin@apple.com>
1952 Build fix. Unreviewed.
1954 * WebCoreSupport/WebContextMenuClient.cpp:
1955 (WebContextMenuClient::searchWithGoogle):
1956 FrameLoader::urlSelected does not take a SecurityOrigin as a parameter.
1958 2010-12-06 Darin Adler <darin@apple.com>
1960 Reviewed by Sam Weinig.
1962 Pass security origin to make local file decision correctly
1963 https://bugs.webkit.org/show_bug.cgi?id=48603
1965 * WebCoreSupport/WebContextMenuClient.cpp:
1966 (WebContextMenuClient::searchWithGoogle): Pass security origin.
1968 2010-12-07 Kenichi Ishibashi <bashi@google.com>
1970 Reviewed by Kent Tamura.
1972 Let HTMLObjectElement be a form associated element
1973 https://bugs.webkit.org/show_bug.cgi?id=48821
1975 Modified to use FormAssociatedElement instead of HTMLFormControlElement.
1978 (WebFrame::elementWithName): Modified to use FormAssociatedElement
1979 instead of HTMLFormControlElement.
1980 (WebFrame::controlsInForm): Ditto.
1982 2010-12-05 Adam Roben <aroben@apple.com>
1984 Windows production build fix
1986 Put spaces after trailing backslashes when setting
1987 %WebKitVSPropsRedirectionDir%. According to MSDN
1988 <http://msdn.microsoft.com/en-us/library/2kzfk8c7(v=VS.80).aspx>:
1990 A backslash ( \ ) followed by a newline character is interpreted as
1991 a space in the command; use a backslash at the end of a line to
1992 continue a command onto the next line. NMAKE interprets the
1993 backslash literally if any other character, including a space or
1994 tab, follows the backslash.
1996 * WebKit.vcproj/WebKit.make:
1998 2010-12-03 Sam Weinig <sam@webkit.org>
2000 Reviewed by Maciej Stachowiak.
2002 Enable <a ping> for Mac/Windows/WebKit2 builds
2003 <rdar://problem/8504473>
2004 https://bugs.webkit.org/show_bug.cgi?id=50488
2006 * WebPreferences.cpp:
2007 (WebPreferences::initializeDefaultSettings): Enable "HyperlinkAuditing" by default.
2009 2010-12-03 Brian Weinstein <bweinstein@apple.com>
2011 Reviewed by Brady Eidson.
2013 WebContextMenuClient::fixMenuReceivedFromOldSafari is no longer needed on Windows
2014 https://bugs.webkit.org/show_bug.cgi?id=50486
2016 Remove the static fixMenuReceivedFromOldSafari and isPreInspectElementTagSafari methods
2017 from WebContextMenuClient. There were there for when WebKit had the Inspect Element context menu
2018 item, but Safari didn't support it. We don't support that old Safari, so that code can go.
2020 * WebCoreSupport/WebContextMenuClient.cpp:
2021 (WebContextMenuClient::getCustomMenuFromDefaultItems):
2023 2010-12-02 John Knottenbelt <jknotten@chromium.org>
2025 Reviewed by Steve Block.
2027 Move requestGeolocationPermissionForFrame to GeolocationClient
2028 https://bugs.webkit.org/show_bug.cgi?id=50061
2030 This change facilitates client-based geolocation implementation by
2031 bringing together permission control into the geolocation client
2034 Move method ChromeClient::requestGeolocationPermissionForFrame to
2035 GeolocationClient::requestPermission. The moved code is unchanged
2036 except that requestPermission now takes only one argument (Geolocation*),
2037 the Frame parameter is retrieved from the Geolocation object and we need to
2038 call m_webView.get() as it is a COMPtr in GeolocationClient.
2040 * WebCoreSupport/WebChromeClient.cpp:
2041 * WebCoreSupport/WebChromeClient.h:
2042 * WebCoreSupport/WebGeolocationClient.cpp:
2043 (WebGeolocationClient::requestPermission):
2044 * WebCoreSupport/WebGeolocationClient.h:
2045 (WebGeolocationClient::cancelPermissionRequest):
2047 2010-12-01 Jia Pu <jpu@apple.com>
2049 Reviewed by Darin Adler.
2051 Support multiple correction candidates panel for misspelled word on Mac OS X.
2052 https://bugs.webkit.org/show_bug.cgi?id=50137
2053 <rdar://problem/8568059>
2055 Adopted new function signature defined in base class.
2057 * WebCoreSupport/WebEditorClient.cpp:
2058 (WebEditorClient::getGuessesForWord):
2059 * WebCoreSupport/WebEditorClient.h:
2061 2010-12-01 Steve Falkenburg <sfalken@apple.com>
2063 Reviewed by Adam Roben.
2065 WinCairo build should not use link-time code generation (LTCG)
2066 https://bugs.webkit.org/show_bug.cgi?id=50353
2068 * WebKit.vcproj/Interfaces.vcproj:
2069 * WebKit.vcproj/WebKit.vcproj:
2070 * WebKit.vcproj/WebKitGUID.vcproj:
2072 2010-12-01 Steve Falkenburg <sfalken@apple.com>
2074 Reviewed by Adam Roben.
2076 vcproj changes can't be applied cleanly by the Windows EWS bot
2077 https://bugs.webkit.org/show_bug.cgi?id=50328
2079 * WebKit.vcproj/Interfaces.vcproj: Modified property svn:eol-style.
2080 * WebKit.vcproj/InterfacesCommon.vsprops: Added property svn:eol-style.
2081 * WebKit.vcproj/WebKit.sln: Modified property svn:eol-style.
2082 * WebKit.vcproj/WebKit.submit.sln: Modified property svn:eol-style.
2083 * WebKit.vcproj/WebKit.vcproj: Modified property svn:eol-style.
2084 * WebKit.vcproj/WebKitGUID.vcproj: Modified property svn:eol-style.
2085 * WebKit.vcproj/WebKitGUIDCommon.vsprops: Added property svn:eol-style.
2086 * WebKit.vcproj/WebKitLibCommon.vsprops: Added property svn:eol-style.
2088 2010-11-30 Steve Falkenburg <sfalken@apple.com>
2090 Reviewed by Adam Roben.
2092 All projects on Windows should use cmd files for build events
2093 https://bugs.webkit.org/show_bug.cgi?id=50213
2095 * WebKit.vcproj/InterfacesCommon.vsprops:
2096 * WebKit.vcproj/InterfacesPostBuild.cmd: Added.
2097 * WebKit.vcproj/InterfacesPreBuild.cmd: Added.
2098 * WebKit.vcproj/WebKitGUIDCommon.vsprops:
2099 * WebKit.vcproj/WebKitGUIDPostBuild.cmd: Added.
2100 * WebKit.vcproj/WebKitGUIDPreBuild.cmd: Added.
2101 * WebKit.vcproj/WebKitLibCommon.vsprops:
2102 * WebKit.vcproj/WebKitLibPostBuild.cmd: Added.
2103 * WebKit.vcproj/WebKitLibPreBuild.cmd: Added.
2105 2010-11-29 Brent Fulgham <bfulgham@webkit.org>
2107 Unreviewed build correction.
2109 * WebKit.vcproj/WebKit.vcproj: Update WebKit project to
2110 use WinCairo.vsprops definition for appropriate build targets.
2112 2010-11-22 Adam Roben <aroben@apple.com>
2114 Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
2116 Apple's Windows build allows placing header files and import libraries for WebKit's
2117 dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
2118 $WebKitLibrariesDir environment variable. This is both required for production builds and
2119 convenient for Apple-internal developer builds. Apple's production builds also require that
2120 WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
2121 builds, the files are copied into that directory tree by the
2122 WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
2124 JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
2126 This .vsprops copying is problematic in one very important case: when a developer updates
2127 their source tree and then tries to build. Visual Studio only reads .vsprops files when a
2128 project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
2129 updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
2130 build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
2131 $WebKitLibrariesDir, but Visual Studio will not pick up the changes. The rest of the build
2132 will proceed with out-of-date .vsprops files, which will likely result in a build failure.
2134 To fix this, we now use normal relative paths to access the .vsprops files in the source
2135 tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
2136 variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
2137 unset, so the normal relative paths are used to read the .vsprops files out of the source
2138 tree directly. In production builds, this environment variable is set to a fake directory
2139 that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
2142 For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
2144 $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
2146 In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
2147 files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
2148 JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
2149 "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
2150 FeatureDefines.vsprops becomes:
2152 $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
2156 $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
2158 (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
2159 actually exist since they are matched by an equal number of ".." path components.)
2161 Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
2162 Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
2164 Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
2167 Reviewed by Dave Hyatt.
2169 * WebKit.vcproj/WebKit.make: Set $WebKitVSPropsRedirectionDir so that production builds can
2170 find the .vsprops files.
2172 * WebKit.vcproj/WebKit.vcproj:
2173 * WebKit.vcproj/Interfaces.vcproj:
2174 * WebKit.vcproj/WebKitGUID.vcproj:
2175 Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
2178 2010-11-19 Steve Falkenburg <sfalken@apple.com>
2180 Reviewed by Adam Roben.
2182 Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
2183 https://bugs.webkit.org/show_bug.cgi?id=49819
2185 * WebKit.vcproj/Interfaces.vcproj:
2186 * WebKit.vcproj/WebKit.sln:
2187 * WebKit.vcproj/WebKit.vcproj:
2188 * WebKit.vcproj/WebKitGUID.vcproj:
2190 2010-11-19 Steve Falkenburg <sfalken@apple.com>
2192 Reviewed by Darin Adler.
2194 Normalize Cairo/CFLite project/solution configuration names
2195 https://bugs.webkit.org/show_bug.cgi?id=49818
2197 * WebKit.vcproj/WebKit.sln:
2198 * WebKit.vcproj/WebKit.vcproj:
2200 2010-11-18 Steve Falkenburg <sfalken@apple.com>
2202 Reviewed by Adam Roben.
2204 Windows vcproj configuration names should be normalized across projects
2205 https://bugs.webkit.org/show_bug.cgi?id=49776
2207 * WebKit.vcproj/Interfaces.vcproj:
2208 * WebKit.vcproj/WebKit.sln:
2210 2010-11-18 Steve Falkenburg <sfalken@apple.com>
2212 Reviewed by Adam Roben.
2214 Remove leftover Windows Debug_Internal configurations
2215 https://bugs.webkit.org/show_bug.cgi?id=49758
2217 * WebKit.vcproj/WebKit.vcproj:
2218 * WebKit.vcproj/WebKitGUID.vcproj:
2220 2010-11-18 Steve Falkenburg <sfalken@apple.com>
2222 Reviewed by Adam Roben.
2224 Debug_Internal Windows configuration is unnecessary, should be removed
2225 https://bugs.webkit.org/show_bug.cgi?id=49753
2229 2010-11-17 Steve Falkenburg <sfalken@apple.com>
2231 Reviewed by Adam Roben.
2233 WebKit Interfaces project should use vsprops file for common build settings
2234 https://bugs.webkit.org/show_bug.cgi?id=49713
2236 * WebKit.vcproj/Interfaces.vcproj:
2237 * WebKit.vcproj/InterfacesCommon.vsprops: Added.
2239 2010-11-16 Steve Falkenburg <sfalken@apple.com>
2241 Reviewed by Adam Roben.
2243 Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
2244 https://bugs.webkit.org/show_bug.cgi?id=49632
2246 * WebKit.vcproj/Interfaces.vcproj:
2247 * WebKit.vcproj/WebKit.make:
2248 * WebKit.vcproj/WebKit.sln:
2249 * WebKit.vcproj/WebKit.submit.sln:
2250 * WebKit.vcproj/WebKit.vcproj:
2251 * WebKit.vcproj/WebKitGUID.vcproj:
2253 2010-11-16 Dave Hyatt <hyatt@apple.com>
2255 Reviewed by Dan Bernstein.
2257 https://bugs.webkit.org/show_bug.cgi?id=11004
2259 font-size:0 is ignored. Remove the minimum font size of 1 in CSSStyleSelector.
2260 Change the pref value for minimum font size from 1 to 0. Make sure to never use the NSFont's size,
2261 since it doesn't honor a size of 0. Instead pass the size in to the FontPlatformData(NSFont*) version
2262 of the constructor rather than using [NSFont pointSize].
2264 https://bugs.webkit.org/show_bug.cgi?id=49582
2266 Negative leading is not handled correctly. There are two bugs here. The first is that
2267 maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
2268 set them before so that we can allow them to be < 0.
2270 The second issue is that we should understand where fonts will end up relative to
2271 our baseline (excluding line height), and only allow those boxes to impact ascent and
2272 descent if the actual font box (without factoring in line height) is above or below the
2273 root line box baseline.
2275 Added fast/css/negative-leading.html
2277 These two bug fixes have to land together to keep the Acid 3 test rendering correctly.
2279 * WebPreferences.cpp:
2280 (WebPreferences::initializeDefaultSettings):
2282 2010-11-16 Steve Falkenburg <sfalken@apple.com>
2284 Reviewed by Adam Roben.
2286 Use vsprops files for common settings in Windows WebKit
2287 https://bugs.webkit.org/show_bug.cgi?id=49622
2289 * WebKit.vcproj/WebKit.vcproj:
2290 * WebKit.vcproj/WebKitCommon.vsprops: Added.
2292 2010-11-16 Steve Falkenburg <sfalken@apple.com>
2294 Rubber stamped by Adam Roben.
2296 Remove unnecessary def file, remove outdated def files from vcproj.
2298 * WebKit.vcproj/WebKit.vcproj:
2299 * WebKit.vcproj/WebKit_debug.def: Removed.
2301 2010-11-12 John Knottenbelt <jknotten@chromium.org>
2303 Reviewed by Steve Block.
2305 Rename GeolocationControllerClient to GeolocationClient.
2306 https://bugs.webkit.org/show_bug.cgi?id=49259
2308 * WebCoreSupport/WebGeolocationClient.cpp: Renamed from WebKit/win/WebCoreSupport/WebGeolocationControllerClient.cpp.
2309 (WebGeolocationClient::WebGeolocationClient):
2310 (WebGeolocationClient::geolocationDestroyed):
2311 (WebGeolocationClient::startUpdating):
2312 (WebGeolocationClient::stopUpdating):
2313 (WebGeolocationClient::lastPosition):
2314 * WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/win/WebCoreSupport/WebGeolocationControllerClient.h.
2315 (WebGeolocationClient::setEnableHighAccuracy):
2316 * WebKit.vcproj/WebKit.vcproj:
2318 (WebView::initWithFrame):
2320 2010-11-10 Csaba Osztrogonác <ossy@webkit.org>
2322 Reviewed by David Hyatt.
2324 HTML5 Ruby support should be mandatory feature
2325 https://bugs.webkit.org/show_bug.cgi?id=49272
2327 * WebKitPrefix.h: Touch it to avoid incremental build failure on Windows.
2329 2010-11-08 Alexey Proskuryakov <ap@apple.com>
2333 * WebCoreSupport/WebChromeClient.h: Added namespace prefix.
2335 2010-11-08 Alexey Proskuryakov <ap@apple.com>
2337 Reviewed by Darin Adler.
2339 https://bugs.webkit.org/show_bug.cgi?id=48685
2340 Notify UI process about focused frame
2342 Added an empty implementation of the new ChromeClient method.
2344 * WebCoreSupport/WebChromeClient.cpp:
2345 (WebChromeClient::focusedFrameChanged):
2346 * WebCoreSupport/WebChromeClient.h:
2348 2010-11-07 Adam Barth <abarth@webkit.org>
2350 Reviewed by Eric Seidel.
2352 Rename Cache to MemoryCache
2353 https://bugs.webkit.org/show_bug.cgi?id=49159
2356 (WebCache::statistics):
2360 2010-11-05 Chris Marrin <cmarrin@apple.com>
2362 Reviewed by Simon Fraser.
2364 Move resumeAnimations/suspendAnimations from Frame to AnimationController.
2365 https://bugs.webkit.org/show_bug.cgi?id=49073
2368 (WebFrame::suspendAnimations):
2369 (WebFrame::resumeAnimations):
2371 2010-11-05 Brian Weinstein <bweinstein@apple.com>
2373 Reviewed by Anders Carlsson.
2375 Assertion failure in PluginStream::~PluginStream when running userscripts/user-script-plugin-document.html
2376 https://bugs.webkit.org/show_bug.cgi?id=48751
2377 <rdar://problem/8615536>
2379 Always call committedLoad in WebFrameLoaderClient::finishedLoading, even if we have a manual loader. We were
2380 running into a case where we were trying to load an empty plugin document, which uses a manual loader, and
2381 PluginStream::didFinishLoading was never being called. The stream was never being stopped, making us fire
2382 an assert in the PluginStream destructor.
2384 * WebCoreSupport/WebFrameLoaderClient.cpp:
2385 (WebFrameLoaderClient::finishedLoading):
2387 2010-11-05 Chris Marrin <cmarrin@apple.com>
2389 Reviewed by Simon Fraser.
2391 Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state
2392 https://bugs.webkit.org/show_bug.cgi?id=46945
2395 (WebFrame::suspendAnimations):
2396 (WebFrame::resumeAnimations):
2398 2010-11-05 Patrick Gansterer <paroga@webkit.org>
2400 Reviewed by David Kilzer.
2402 Replace ARRAYSIZE with WTF_ARRAY_LENGTH
2403 https://bugs.webkit.org/show_bug.cgi?id=48903
2405 * WebCoreSupport/WebChromeClient.cpp:
2406 (WebChromeClient::exceededDatabaseQuota):
2408 (DllGetClassObject):
2410 (WebView::mouseWheel):
2412 2010-11-02 Daniel Bates <dbates@rim.com>
2414 Reviewed by Adam Barth.
2416 For unnamed frames, window.name returns a generated name
2417 https://bugs.webkit.org/show_bug.cgi?id=6751
2421 Substitute FrameTree::uniqueName() for FrameTree::name() in the Apple Windows port.
2426 2010-11-02 Brady Eidson <beidson@apple.com>
2428 Reviewed by Anders Carlsson.
2430 <rdar://problem/8346191> and https://bugs.webkit.org/show_bug.cgi?id=48868
2431 Implement IMutableWebRequest::setTimeoutInterval
2433 * WebMutableURLRequest.cpp:
2434 (WebMutableURLRequest::setTimeoutInterval):
2436 2010-11-02 Daniel Bates <dbates@rim.com>
2438 Reviewed by Martin Robinson.
2440 Set frame name before appending it to the frame tree in the Apple Windows,
2442 https://bugs.webkit.org/show_bug.cgi?id=48806
2444 Make the frame creation process in the Apple Windows-port consistent
2445 with the Mac, Qt, and Haiku ports. In particular, set the name of
2446 the new frame before it's appended to the frame tree.
2448 At this time we cannot test this change since it is being masked by
2449 HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>.
2450 We'll be able to test this once we fix bug #6751.
2452 * WebCoreSupport/WebFrameLoaderClient.cpp:
2453 (WebFrameLoaderClient::createFrame):
2455 2010-11-01 Jenn Braithwaite <jennb@chromium.org>
2457 Reviewed by Adam Roben.
2459 Windows: Update resource tracking when moving a frame between documents
2460 https://bugs.webkit.org/show_bug.cgi?id=48364
2462 * Interfaces/IWebResourceLoadDelegatePrivate2.idl:Added
2463 Added removeIdentifierForRequest.
2464 * Interfaces/WebKit.idl:
2465 Added IWebResourceLoadDelegatePrivate2.idl.
2466 * WebCoreSupport/WebFrameLoaderClient.cpp:
2467 (WebFrameLoaderClient::transferLoadingResourceFromPage):
2469 2010-11-01 Brady Eidson <beidson@apple.com>
2471 Reviewed by Anders Carlsson.
2473 <rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699
2474 Context menu support for WebKit 2.
2476 * WebCoreSupport/WebChromeClient.h:
2477 (WebChromeClient::showContextMenu):
2479 2010-11-01 Adam Roben <aroben@apple.com>
2481 Cancel main resource loads after we hand them off to the media engine
2483 This is the Windows equivalent of r51104. Clearly this code should be
2484 moved to a cross-platform location someday.
2486 Fixes <http://webkit.org/b/48531> <rdar://problem/8606635> Assertion
2487 failure in DocumentLoader::commitData when loading a media document in
2490 Reviewed by Dan Bernstein.
2492 * WebCoreSupport/WebFrameLoaderClient.cpp:
2493 (WebFrameLoaderClient::committedLoad): Cancel the main resource load
2494 after handing off the load to the media engine. This code originally
2495 came from -[WebHTMLRepresentation receivedData:withDataSource:].
2498 (WebFrame::shouldFallBack): Don't fall back when handing the resource
2499 load off to the media engine or a plugin. Added error domain checking
2500 so that we don't rely on error codes being unique.
2502 2010-10-29 Daniel Bates <dbates@rim.com>
2504 No review, rolling out 70971.
2505 http://trac.webkit.org/changeset/70971
2506 https://bugs.webkit.org/show_bug.cgi?id=6751
2508 Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
2509 it caused layout test failures on all bots. In particular, the
2510 child count in a generated frame name differs after this patch. We need
2511 to look into this further.
2516 2010-10-28 Antonio Gomes <agomes@rim.com>
2518 Reviewed by Ojan Vafai.
2520 Needs a "LinuxEditingBehavior", perhaps with a better name
2521 https://bugs.webkit.org/show_bug.cgi?id=36627
2523 Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
2525 * Interfaces/IWebPreferences.idl:
2527 2010-10-29 Daniel Bates <dbates@rim.com>
2529 Reviewed by Adam Barth.
2531 For unnamed frames, window.name returns a generated name
2532 https://bugs.webkit.org/show_bug.cgi?id=6751
2534 Modified Apple Windows-port to use FrameTree::uniqueName().
2539 2010-10-29 Darin Adler <darin@apple.com>
2541 Reviewed by Sam Weinig.
2543 Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
2544 https://bugs.webkit.org/show_bug.cgi?id=48574
2546 * WebBackForwardList.cpp:
2547 (backForwardListWrappers):
2548 (WebBackForwardList::WebBackForwardList):
2549 (WebBackForwardList::createInstance):
2550 * WebBackForwardList.h:
2552 (WebView::backForwardList):
2553 Use BackForwardListImpl.
2555 2010-10-29 Adam Roben <aroben@apple.com>
2559 * WebKitPrefix.h: Touched to force a rebuild.
2561 2010-10-29 Alexey Proskuryakov <ap@apple.com>
2563 Reviewed by Darin Adler.
2565 https://bugs.webkit.org/show_bug.cgi?id=48576
2566 Let WebKit2 client know when a frame is a frameset
2568 Added a blank implementation of the new FrameLoaderClient method.
2570 * WebCoreSupport/WebFrameLoaderClient.h:
2571 * WebCoreSupport/WebFrameLoaderClient.cpp:
2572 (WebFrameLoaderClient::dispatchDidBecomeFrameset):
2574 2010-10-26 Brent Fulgham <bfulgham@webkit.org>
2576 Unreviewed build fix.
2578 * WebView.cpp: Conditionalize includes for CFNetwork-specific
2579 Cookie implementation.
2580 * WebView.h: Conditionalize includes for ACCELERATED_COMPOSITION.
2581 WinCairo doesn't use CoreAnimation.
2583 2010-10-26 Jenn Braithwaite <jennb@chromium.org>
2585 Reviewed by Dmitry Titov.
2587 Resource tracking failure when trying to move a frame between documents
2588 https://bugs.webkit.org/show_bug.cgi?id=44713
2590 * WebCoreSupport/WebFrameLoaderClient.cpp:
2591 (WebFrameLoaderClient::transferLoadingResourceFromPage):
2593 * WebCoreSupport/WebFrameLoaderClient.h:
2595 2010-10-25 Patrick Gansterer <paroga@webkit.org>
2597 Reviewed by David Kilzer.
2599 Replace _countof with WTF_ARRAY_LENGTH
2600 https://bugs.webkit.org/show_bug.cgi?id=48229
2602 * WebCoreSupport/WebContextMenuClient.cpp:
2603 (isPreInspectElementTagSafari):
2605 (WebView::interpretKeyEvent):
2607 2010-10-24 Dan Bernstein <mitz@apple.com>
2611 * Interfaces/WebKit.idl: Touched.
2613 2010-10-24 Dan Bernstein <mitz@apple.com>
2615 Reviewed by Anders Carlsson.
2617 Expose HitTestResult::absoluteMediaURL() via WebKit API
2618 https://bugs.webkit.org/show_bug.cgi?id=48219
2620 * Interfaces/IWebView.idl: Added WebElementMediaURLKey.
2621 * WebElementPropertyBag.cpp:
2622 (WebElementPropertyBag::Read): Map WebElementMediaURLKey to absoluteMediaURL().
2624 2010-10-22 Andy Estes <aestes@apple.com>
2626 Fix the Windows build.
2628 * WebCookieManagerCFNet.cpp: Rename CookieStorageWin.h to CookieStorageCFNet.h.
2629 * WebView.cpp: Ditto.
2631 2010-10-22 Jenn Braithwaite <jennb@chromium.org>
2633 Reviewed by Adam Roben.
2635 Windows client needs updating when live iframe element is moved between pages
2636 https://bugs.webkit.org/show_bug.cgi?id=46915
2638 * WebCoreSupport/WebFrameLoaderClient.cpp:
2639 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
2640 Update WebView in WebFrame to match that of the current page.
2642 (WebFrame::setWebView):
2646 2010-10-22 Sam Weinig <sam@webkit.org>
2650 * WebCoreSupport/WebChromeClient.h:
2652 2010-10-22 Sam Weinig <sam@webkit.org>
2654 Reviewed by Anders Carlsson.
2656 WebKit2 needs to pass the current event modifier flags when requesting a new window
2657 https://bugs.webkit.org/show_bug.cgi?id=48140
2659 * WebCoreSupport/WebChromeClient.cpp:
2660 (WebChromeClient::createWindow):
2661 * WebCoreSupport/WebFrameLoaderClient.cpp:
2662 (WebFrameLoaderClient::dispatchCreatePage):
2663 * WebCoreSupport/WebFrameLoaderClient.h:
2664 Add NavigationAction parameter.
2666 2010-10-21 MORITA Hajime <morrita@google.com>
2668 Unreviewed, touched it to fix the build.
2670 * Interfaces/WebKit.idl:
2672 2010-10-21 MORITA Hajime <morrita@google.com>
2674 Reviewed by Kent Tamura.
2676 [Win][DRT] should have LayoutTestController.hasSpellingMarker()
2677 https://bugs.webkit.org/show_bug.cgi?id=47885
2679 Added IWebFramePrivate::hasSpellingMarker() and impelmented it for
2680 LayoutTestController.
2682 * Interfaces/IWebFramePrivate.idl:
2684 (WebFrame::hasSpellingMarker):
2687 2010-10-20 Dumitru Daniliuc <dumi@chromium.org>
2689 Reviewed by David Levin.
2691 Repost the DatabaseTracker notifications to the main thread, if needed.
2692 https://bugs.webkit.org/show_bug.cgi?id=40655
2694 * WebDatabaseManager.cpp:
2695 (DidModifyOriginData::dispatchToMainThread):
2696 (DidModifyOriginData::DidModifyOriginData):
2697 (DidModifyOriginData::dispatchDidModifyOriginOnMainThread):
2698 (WebDatabaseManager::dispatchDidModifyOrigin):
2699 (WebDatabaseManager::dispatchDidModifyDatabase):
2701 2010-10-20 Dirk Schulze <krit@webkit.org>
2703 Reviewed by Nikolas Zimmermann.
2705 Merge ColorSpace and ImageColorSpace enums
2706 https://bugs.webkit.org/show_bug.cgi?id=47922
2708 Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
2709 to follow webkit style rules.
2711 * FullscreenVideoController.cpp:
2714 (FullscreenVideoController::draw):
2715 * WebCoreSupport/WebDragClient.cpp:
2716 (WebDragClient::createDragImageForLink):
2717 * WebKitGraphics.cpp:
2720 2010-10-18 Pavel Podivilov <podivilov@chromium.org>
2722 Reviewed by Timothy Hatcher.
2724 Web Inspector: disable private browsing for inspector
2725 https://bugs.webkit.org/show_bug.cgi?id=47827
2727 * WebCoreSupport/WebInspectorClient.cpp:
2728 (WebInspectorClient::openInspectorFrontend):
2730 2010-10-17 Adam Barth <abarth@webkit.org>
2732 Reviewed by Dimitri Glazkov.
2734 FrameLoader doesn't need an explicit userGesture parameter
2735 https://bugs.webkit.org/show_bug.cgi?id=47777
2737 Update for the new API.
2739 * WebCoreSupport/WebContextMenuClient.cpp:
2740 (WebContextMenuClient::searchWithGoogle):
2742 2010-10-15 Brian Weinstein <bweinstein@apple.com>
2744 Reviewed by Sam Weinig.
2746 REGRESSION(r69850) Loading apple.com/startpage in WebKit on Windows gets a bad request.
2747 https://bugs.webkit.org/show_bug.cgi?id=47753
2748 <rdar://problem/8558242>
2750 VerQueryValue returns a null terminated string, but we need to strip off the null terminating character
2751 when we turn it into a WebCore string, or else concatenation using this string will break.
2755 2010-10-15 Jessie Berlin <jberlin@apple.com>
2757 Windows build fix. Unreviewed.
2759 * WebCoreSupport/WebInspectorClient.cpp:
2760 Add a missing include.
2762 2010-10-15 Nikolas Zimmermann <nzimmermann@rim.com>
2764 Reviewed by Dirk Schulze.
2766 Replace some String::format() usages by StringConcatenate in WebKit
2767 https://bugs.webkit.org/show_bug.cgi?id=47714
2769 * WebCoreSupport/WebInspectorClient.cpp:
2770 (WebInspectorFrontendClient::updateWindowTitle):
2772 (WebView::standardUserAgentWithApplicationName):
2775 2010-10-14 Ilya Tikhonovsky <loislo@chromium.org>
2777 Reviewed by Pavel Feldman.
2779 Web Inspector: inspector settings/properties/states management
2780 should be extracted into separate class.
2782 We have a lot of flags/values in InspectorController.
2783 Some flags are persisting into profile.
2784 Others are part of inspector state for frontend.
2785 All these flags should keep their values after navigation.
2786 It'd be better to extract these flags/values into separate
2787 class which will care about theirs lifetime.
2789 https://bugs.webkit.org/show_bug.cgi?id=47275
2791 * WebCoreSupport/WebInspectorClient.cpp:
2792 (WebInspectorFrontendClient::attachWindow):
2793 (WebInspectorFrontendClient::detachWindow):
2794 (WebInspectorFrontendClient::showWindowWithoutNotifications):
2796 2010-10-13 Gavin Barraclough <barraclough@apple.com>
2798 Reviewed by Oliver Hunt.
2800 https://bugs.webkit.org/show_bug.cgi?id=43987
2801 Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder
2802 to construct their internal result string. Remove ScriptString (this is now
2805 * WebCoreSupport/WebFrameLoaderClient.cpp:
2807 2010-10-12 Adam Roben <aroben@apple.com>
2809 Build TestWebKitAPI on Windows
2811 Fixes <http://webkit.org/b/47552> <rdar://problem/8541708> Make
2812 TestWebKitAPI work on Windows
2814 Reviewed by Sam Weinig.
2816 * WebKit.vcproj/WebKit.sln: Added TestWebKitAPI and
2817 TestWebKitAPIGenerated and made them build just after
2820 2010-10-11 Shinichiro Hamaji <hamaji@chromium.org>
2822 Attempt to fix windows build failure.
2824 Remove WebIconFetcher from WebKit and IconFetcher from WebCore
2825 https://bugs.webkit.org/show_bug.cgi?id=47523
2827 * Interfaces/IWebFramePrivate.idl: s/unused1/unused2/
2828 * Interfaces/WebKit.idl: Touched.
2829 * WebFrame.cpp: s/unused1/unused2/
2830 (WebFrame::unused2):
2831 * WebFrame.h: s/unused1/unused2/
2833 2010-10-11 Anders Carlsson <andersca@apple.com>
2835 Reviewed by Darin Adler.
2837 Remove WebIconFetcher from WebKit and IconFetcher from WebCore
2838 https://bugs.webkit.org/show_bug.cgi?id=47523
2840 Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.
2842 * Interfaces/IWebFramePrivate.idl:
2843 * Interfaces/IWebIconFetcher.idl: Removed.
2844 * Interfaces/WebKit.idl:
2846 (WebFrame::unused1):
2848 * WebIconFetcher.cpp: Removed.
2849 * WebIconFetcher.h: Removed.
2850 * WebKit.vcproj/Interfaces.vcproj:
2851 * WebKit.vcproj/WebKit.vcproj:
2853 2010-10-11 Jessie Berlin <jberlin@apple.com>
2855 Reviewed by Darin Adler.
2857 Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal
2858 representation of a WebKit1 WebSerializedJSValue.
2859 https://bugs.webkit.org/show_bug.cgi?id=47439
2861 * Interfaces/IWebSerializedJSValuePrivate.idl:
2862 Because it is taking a void** parameter, getInternalRepresentation must be declared [local].
2864 * WebSerializedJSValue.cpp:
2865 (WebSerializedJSValue::getInternalRepresentation):
2866 * WebSerializedJSValue.h:
2868 2010-10-07 Jessie Berlin <jberlin@apple.com>
2870 Reviewed by Sam Weinig.
2872 Add Private API for creating a WebKit1 WebSerializedJSValue from the internal
2873 representation of a WebKit2 WebSerializedScriptValue.
2874 https://bugs.webkit.org/show_bug.cgi?id=47390
2876 * Interfaces/WebKit.idl:
2877 Generate IWebSerializedJSValuePrivate.
2879 * Interfaces/IWebSerializedJSValuePrivate.idl: Added.
2880 Because it is taking a void* parameter, setInternalRepresentation must be declared [local].
2882 * WebKit.vcproj/Interfaces.vcproj:
2883 Add IWebSerializedJSValue.idl and IWebSerializedJSValuePrivate.idl.
2885 * WebSerializedJSValue.cpp:
2886 (WebSerializedJSValue::QueryInterface):
2887 Since there are now two interfaces that inherit from IUnknown, do not try to cast to
2888 IUnknown* anymore. Cast to IWebSerializedJSValue* instead.
2889 (WebSerializedJSValue::setInternalRepresentation):
2890 Only set the internal representation if it hasn't already been set.
2891 * WebSerializedJSValue.h:
2893 2010-10-04 Jon Honeycutt <jhoneycutt@apple.com>
2895 Prevent an assertion failure when trying to create a protection space
2898 Reviewed by Sam Weinig.
2900 * WebURLProtectionSpace.cpp:
2901 (WebURLProtectionSpace::initWithHost):
2902 Remove the ASSERT_NOT_REACHED().
2904 2010-10-05 Brent Fulgham <bfulgham@webkit.org>
2906 Unreviewed build correction.
2908 * WebKit.vcproj/WebKit.sln: Turn the QTMovieWin project
2909 off for WinCairo release builds. Somehow this was
2910 incorrectly turned on.
2912 2010-10-01 Mark Rowe <mrowe@apple.com>
2916 Clear the executable bit from a number of source files.
2921 2010-09-30 Darin Adler <darin@apple.com>
2923 Reviewed by Sam Weinig.
2925 Remove remaining calls to deprecatedParseURL
2926 https://bugs.webkit.org/show_bug.cgi?id=26599
2928 * WebCoreSupport/WebFrameLoaderClient.cpp:
2929 (WebFrameLoaderClient::dispatchDidFailToStartPlugin):
2930 Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
2932 2010-09-28 Jenn Braithwaite <jennb@chromium.org>
2934 Reviewed by Dmitry Titov.
2936 Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
2937 https://bugs.webkit.org/show_bug.cgi?id=46663
2939 * WebCoreSupport/WebFrameLoaderClient.cpp:
2940 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
2941 * WebCoreSupport/WebFrameLoaderClient.h:
2943 2010-09-27 Andrey Kosyakov <caseq@chromium.org>
2945 Unreviewed build fix (win; broken in r68371)
2947 * WebFrame.cpp: remove include <WebCore/ResourceHandleWin.h>
2949 2010-09-23 Matthew Delaney <mdelaney@apple.com>
2951 Reviewed by Simon Fraser.
2953 Reduce minimum DOMTimer interval
2954 https://bugs.webkit.org/show_bug.cgi?id=45362
2957 Updating set interval call to use Settings' static version inside
2958 one time init block.
2960 2010-09-23 Nate Chapin <japhet@chromium.org>
2962 Unreviewed, build fix.
2964 Move hyperlinkAuditingEnabled to IWebPreferencesPrivate.idl
2965 and touch WebKit.idl
2967 * Interfaces/IWebPreferences.idl:
2968 * Interfaces/IWebPreferencesPrivate.idl:
2969 * Interfaces/WebKit.idl:
2971 (WebView::notifyPreferencesChanged):
2973 2010-09-23 Nate Chapin <japhet@chromium.org>
2975 Unreviewed, build fix.
2977 Look for hyperlinkAuditingEnabled in the right set of preferences.
2980 (WebView::notifyPreferencesChanged):
2982 2010-09-23 Nate Chapin <japhet@chromium.org>
2984 Reviewed by Darin Fisher.
2986 Add hyperlink auditing settings (i.e., <a ping>).
2987 https://bugs.webkit.org/show_bug.cgi?id=30458
2989 * Interfaces/IWebPreferences.idl:
2990 * WebPreferenceKeysPrivate.h:
2991 * WebPreferences.cpp:
2992 (WebPreferences::initializeDefaultSettings):
2993 (WebPreferences::hyperlinkAuditingEnabled):
2994 (WebPreferences::setHyperlinkAuditingEnabled):
2997 (WebView::notifyPreferencesChanged):
2999 2010-09-23 Matthew Delaney <mdelaney@apple.com>
3001 Reviewed by Adam Roben.
3003 Create one time initialization block for WebView's initWithFrame
3004 https://bugs.webkit.org/show_bug.cgi?id=46307
3006 * WebView.cpp: Added one time initialization block for webview code
3007 that needs only be run once and not for each webview. This is just as
3008 the mac version WebView.mm does.
3010 2010-09-22 Brent Fulgham <bfulgham@webkit.org>
3012 Reviewed by Martin Robinson.
3014 [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
3015 https://bugs.webkit.org/show_bug.cgi?id=46303.
3017 * WebKit.vcproj/WebKit.sln: Update overall Debug_Cairo and
3018 Release_Cairo configurations to select appropriate build
3019 targets for WebKitTestRunner and MiniBrowser.
3021 2010-09-22 Brent Fulgham <bfulgham@webkit.org>
3023 Reviewed by Martin Robinson.
3025 [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.rt
3026 https://bugs.webkit.org/show_bug.cgi?id=46303.
3028 * WebKit.vcproj/WebKit.sln: Update overall Debug_Cairo and
3029 Release_Cairo configurations to select appropriate build
3030 targets for InjectionBundle.
3032 2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>
3034 Reviewed by Kenneth Rohde Christiansen.
3036 PluginStrategy should satisfy the needs of Qt
3037 https://bugs.webkit.org/show_bug.cgi?id=45857
3038 No new functionality so no new tests.
3040 * WebCoreSupport/WebPlatformStrategies.cpp:
3041 (WebPlatformStrategies::getPluginInfo):
3042 * WebCoreSupport/WebPlatformStrategies.h:
3044 2010-09-20 Philippe Normand <pnormand@igalia.com>
3046 Reviewed by Eric Carlson.
3048 [GTK] enhanced context menu for media elements
3049 https://bugs.webkit.org/show_bug.cgi?id=45021
3051 New localized strings for the media element context-menu.
3053 * WebCoreSupport/WebPlatformStrategies.cpp:
3054 (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow):
3055 (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow):
3056 (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard):
3057 (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard):
3058 (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
3059 (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
3060 (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
3061 (WebPlatformStrategies::contextMenuItemTagMediaPlay):
3062 (WebPlatformStrategies::contextMenuItemTagMediaPause):
3063 (WebPlatformStrategies::contextMenuItemTagMediaMute):
3064 * WebCoreSupport/WebPlatformStrategies.h:
3066 2010-09-17 Darin Adler <darin@apple.com>
3068 Reviewed by Sam Weinig.
3070 REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
3071 https://bugs.webkit.org/show_bug.cgi?id=42863
3074 (WebView::setZoomMultiplier):
3075 Call functions on Frame instead of FrameView.
3077 2010-09-17 Matthew Delaney <mdelaney@apple.com>
3079 Reviewed by Simon Fraser.
3081 Reduce minimum DOMTimer interval
3082 https://bugs.webkit.org/show_bug.cgi?id=45362
3084 * WebView.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.
3086 2010-09-17 Simon Fraser <simon.fraser@apple.com>
3088 Reviewed by Chris Marrin.
3090 Remove scroll and clip layers for WKCACFLayerRenderer
3091 https://bugs.webkit.org/show_bug.cgi?id=45922
3093 WKCACFLayerRenderer no longer needs its own layers for managing scrolling
3094 and clipping, because RenderLayerCompositor provides this functionality.
3097 (WebView::sizeChanged): Moved code that handles the WM_SIZE message
3098 into this method. Use it to resize the layer renderer.
3099 (WebView::WebViewWndProc): Call sizeChanged().
3100 (WebView::updateRootLayerContents): No need to call setScrollFrame() any more.
3101 (WebView::layerRendererBecameVisible): Move this from the header (no need to be inline).
3104 2010-09-16 Darin Adler <darin@apple.com>
3106 Reviewed by Andreas Kling.
3108 Reduce use of HTMLInputElement::inputType so we can remove it later
3109 https://bugs.webkit.org/show_bug.cgi?id=45903
3112 (WebFrame::elementDoesAutoComplete): Use isPasswordField.
3113 (WebFrame::elementIsPassword): Use isPasswordField.
3115 2010-09-14 Ada Chan <adachan@apple.com>
3117 Reviewed by Adam Roben.
3119 Add an IWebFramePrivate API to load string as plain text into the WebFrame.
3120 https://bugs.webkit.org/show_bug.cgi?id=45782
3122 * Interfaces/IWebFramePrivate.idl:
3123 * Interfaces/WebKit.idl: Touch the file.
3125 (WebFrame::loadPlainTextString):
3128 2010-09-13 Enrica Casucci <enrica@apple.com>
3130 Reviewed by Sam Weinig.
3132 Paste should be implemented in WebCore like Copy and Cut for Mac also.
3133 https://bugs.webkit.org/show_bug.cgi?id=45494
3134 <rdar://problem/7660537>
3136 On the Mac platform, the implementation of the paste operation is all done
3137 at the WebKit level. In order to support it on WebKit2 it is necessary to
3138 refactor the code and move this functionality at the level of WebCore like
3139 we already have on Windows.
3140 The original code relies on some in AppKit functions that call back into
3141 WebKit causing problems in WebKit2. All this functionality has been moved
3142 at the level of the editor client where it can be dealt with appropriately.
3145 (WebFrame::canShowMIMETypeASHTML): Added.
3147 2010-09-11 Adam Barth <abarth@webkit.org>
3149 Reviewed by Sam Weinig.
3151 Make SecurityOrigin::canDisplay an instance function
3152 https://bugs.webkit.org/show_bug.cgi?id=45219
3155 (WebFrame::allowsFollowingLink):
3157 2010-09-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
3159 Reviewed by Darin Adler.
3161 Add NetworkingContext to avoid layer violations
3162 https://bugs.webkit.org/show_bug.cgi?id=42292
3164 * WebCoreSupport/WebFrameNetworkingContext.cpp:
3165 (WebFrameNetworkingContext::blockedError):
3166 * WebCoreSupport/WebFrameNetworkingContext.h:
3168 2010-09-10 Jer Noble <jer.noble@apple.com>
3170 Reviewed by Simon Fraser.
3172 Movies with track or movie matrices don't display in <video> elements (Safari 5/Windows)
3173 https://bugs.webkit.org/show_bug.cgi?id=45333
3175 The rootChild layer must be set as flipped, otherwise transformed movies will appear
3176 incorrectly rotated.
3178 * FullscreenVideoController.cpp:
3179 (FullscreenVideoController::enterFullscreen):
3181 2010-09-10 Sam Weinig <sam@webkit.org>
3183 Reviewed by Darin Adler.
3185 Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
3186 Precursor to <rdar://problem/7660657>
3187 https://bugs.webkit.org/show_bug.cgi?id=45522
3195 (WebView::setZoomMultiplier):
3196 (WebView::zoomMultiplier):
3197 (WebView::canMakeTextLarger):
3198 (WebView::makeTextLarger):
3199 (WebView::canMakeTextSmaller):
3200 (WebView::makeTextSmaller):
3201 (WebView::notifyPreferencesChanged):
3203 Move tracking of text only zoom here from WebCore.
3205 2010-09-10 Brian Weinstein <bweinstein@apple.com>
3207 Windows Build Fix. Fix some fallout from r67238, currentForm is now off of
3208 SelectionController instead of frame. Also fix a style issue.
3211 (WebFrame::currentForm):
3213 2010-09-10 Adam Barth <abarth@webkit.org>
3215 Reviewed by Darin Fisher.
3217 Move code from WebKit-layer to DocumentLoader
3218 https://bugs.webkit.org/show_bug.cgi?id=45569
3220 * WebCoreSupport/WebFrameLoaderClient.cpp:
3221 (WebFrameLoaderClient::committedLoad):
3222 * WebCoreSupport/WebFrameLoaderClient.h:
3224 2010-09-09 Darin Adler <darin@apple.com>
3226 Reviewed by Adam Barth.
3228 Move functions from Frame to SelectionController as planned
3229 https://bugs.webkit.org/show_bug.cgi?id=45508
3232 (WebView::selectionRect):
3233 (WebView::centerSelectionInVisibleArea):
3234 Call functions on selection().
3236 2010-09-10 Adam Barth <abarth@webkit.org>
3238 Reviewed by Eric Seidel.
3240 Main resource bytes shouldn't bounce through FrameLoader
3241 https://bugs.webkit.org/show_bug.cgi?id=45496
3243 Now return the bytes to the DocumentLoader.
3245 * WebCoreSupport/WebFrameLoaderClient.cpp:
3246 (WebFrameLoaderClient::receivedData):
3248 2010-09-09 Simon Fraser <simon.fraser@apple.com>
3250 Reviewed by Adam Roben.
3252 Scrollbars fail to render in composited iframes.
3253 https://bugs.webkit.org/show_bug.cgi?id=45335
3255 Use LocalWindowsContext when painting scrollbars.
3257 * WebCoreSupport/WebChromeClient.cpp:
3258 (WebChromeClient::paintCustomScrollbar):
3259 (WebChromeClient::paintCustomScrollCorner):
3261 2010-09-08 Darin Adler <darin@apple.com>
3263 Reviewed by Adam Barth.
3265 Move functions from Frame to Editor as planned
3266 https://bugs.webkit.org/show_bug.cgi?id=45218
3268 * WebCoreSupport/WebContextMenuClient.cpp:
3269 (WebContextMenuClient::searchWithGoogle):
3271 (WebFrame::selectedString):
3273 (WebView::selectedText):
3274 (WebView::prepareCandidateWindow):
3275 (WebView::onIMERequestCharPosition):
3276 Changed call sites to use editor().
3278 2010-09-08 Peter Kasting <pkasting@google.com>
3280 Not reviewed, build fix.
3283 (WebScrollBar::setScrollOffsetFromAnimation):
3285 2010-09-08 Peter Kasting <pkasting@google.com>
3287 Not reviewed, build fix.
3290 (WebScrollBar::scrollSize):
3291 (WebScrollBar::setScrollOffsetFromAnimation):
3293 2010-09-08 Peter Kasting <pkasting@google.com>
3295 Not reviewed, build fix.
3298 (WebScrollBar::setValue):
3299 (WebScrollBar::scrollSize):
3300 (WebScrollBar::setScrollOffsetFromAnimation):
3303 2010-09-08 Adam Barth <abarth@webkit.org>
3305 Attempted Window build fix.
3307 * WebDataSource.cpp:
3308 (WebDataSource::subresourceForURL):
3310 2010-09-08 Adam Barth <abarth@webkit.org>
3312 Rubber-stamped by Eric Seidel.
3314 Rename DocLoader to CachedResourceLoader because that's what it does.
3316 * WebDataSource.cpp:
3318 2010-09-07 Brent Fulgham <bfulgham@webkit.org>
3320 Reviewed by Adam Roben.
3322 Clean up a potential resource leak.
3323 https://bugs.webkit.org/show_bug.cgi?id=45198
3325 Several bitmap device context were being created and used,
3326 and destroyed without returning the context to its original
3327 state. This showed up as bitmap leaks in BoundsChecker.
3329 * FullscreenVideoController.cpp:
3331 (WebView::scrollBackingStore):
3334 2010-09-06 Adam Barth <abarth@webkit.org>
3336 Reviewed by Darin Adler.
3338 Rename SecurityOrigin::canLoad to canDisplay
3339 https://bugs.webkit.org/show_bug.cgi?id=45214
3341 Propagate name change.
3344 (WebFrame::allowsFollowingLink):
3346 2010-09-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
3348 Reviewed by Darin Adler.
3350 Add NetworkingContext to avoid layer violations
3351 https://bugs.webkit.org/show_bug.cgi?id=42292
3353 Add Win's specific implementation of NetworkingContext.
3355 * WebCoreSupport/WebFrameNetworkingContext.cpp:
3356 (WebFrameNetworkingContext::create):
3357 (WebFrameNetworkingContext::userAgent):
3358 (WebFrameNetworkingContext::referrer):
3360 (WebFrame::createNetworkingContext):
3363 2010-09-03 Adam Roben <aroben@apple.com>
3365 Attempt to fixing Windows nightlies again
3367 The fix in r66438 should be sufficient, but we have to touch
3368 WebKit.idl to force that change to be picked up by the build.
3370 * Interfaces/WebKit.idl: Touched this file to force a build.
3372 2010-09-02 Yury Semikhatsky <yurys@chromium.org>
3374 Reviewed by PavelFeldman.
3376 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
3377 https://bugs.webkit.org/show_bug.cgi?id=44230
3379 * WebCoreSupport/WebInspectorClient.cpp:
3380 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
3381 (WebInspectorFrontendClient::closeWindow):
3382 (WebInspectorFrontendClient::disconnectFromBackend):
3383 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
3384 (WebInspectorFrontendClient::destroyInspectorView):
3385 * WebCoreSupport/WebInspectorClient.h:
3387 2010-09-01 Jessie Berlin <jberlin@apple.com>
3389 Reviewed by Adam Roben.
3391 WebViews should allow their parent windows to handle WM_MOUSEACTIVATE messages.
3392 https://bugs.webkit.org/show_bug.cgi?id=45047
3395 (WebView::WebViewWndProc):
3397 2010-08-31 Dave Hyatt <hyatt@apple.com>
3399 Reviewed by Sam Weinig.
3401 https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
3402 the former can occur in more places without having to do the latter.
3405 (WebFrame::paintDocumentRectToContext):
3407 (WebView::updateBackingStore):
3409 2010-08-30 Adam Roben <aroben@apple.com>
3411 Fix crash on launch on Windows due to changing IWebFramePrivate's
3414 This regressed in r65107.
3416 Fixes <http://webkit.org/b/44755>.
3418 Rubber-stamped by Jon Honeycutt.
3420 * Interfaces/IWebFramePrivate.idl: Moved suspendAnimations and
3421 resumeAnimations to the end of the interface so that the vtable will
3422 match what Safari expects.
3424 2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
3426 Unreviewed, rolling out r66198.
3427 http://trac.webkit.org/changeset/66198
3428 https://bugs.webkit.org/show_bug.cgi?id=44856
3430 It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
3432 * WebCoreSupport/WebInspectorClient.cpp:
3433 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
3434 (WebInspectorFrontendClient::closeWindow):
3435 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
3436 (WebInspectorFrontendClient::destroyInspectorView):
3437 * WebCoreSupport/WebInspectorClient.h:
3439 2010-08-27 Yury Semikhatsky <yurys@chromium.org>
3441 Reviewed by Pavel Feldman.
3443 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
3444 https://bugs.webkit.org/show_bug.cgi?id=44230
3446 * WebCoreSupport/WebInspectorClient.cpp:
3447 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
3448 (WebInspectorFrontendClient::closeWindow):
3449 (WebInspectorFrontendClient::disconnectFromBackend):
3450 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
3451 (WebInspectorFrontendClient::destroyInspectorView):
3452 * WebCoreSupport/WebInspectorClient.h:
3454 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
3456 Unreviewed. Revert r66103 since Qt tests are failing.
3458 * WebCoreSupport/WebInspectorClient.cpp:
3459 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
3460 (WebInspectorFrontendClient::closeWindow):
3461 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
3462 (WebInspectorFrontendClient::destroyInspectorView):
3463 * WebCoreSupport/WebInspectorClient.h:
3465 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
3467 Reviewed by Pavel Feldman.
3469 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
3470 https://bugs.webkit.org/show_bug.cgi?id=44230
3472 * WebCoreSupport/WebInspectorClient.cpp:
3473 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
3474 (WebInspectorFrontendClient::closeWindow):
3475 (WebInspectorFrontendClient::disconnectFromBackend):
3476 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
3477 (WebInspectorFrontendClient::destroyInspectorView):
3478 * WebCoreSupport/WebInspectorClient.h:
3480 2010-08-24 Ada Chan <adachan@apple.com>
3482 Reviewed by Steve Falkenburg.
3484 <rdar://problem/8185379> Possible null dereference in WebView::canShowMIMEType.
3485 https://bugs.webkit.org/show_bug.cgi?id=44564
3488 (WebView::canShowMIMEType): Null check m_page->pluginData() since that can return NULL
3489 if plugins are disabled.
3491 2010-08-22 Daniel Bates <dbates@rim.com>
3493 Reviewed by Eric Seidel.
3495 Encapsulate document marker management into DocumentMarkerController
3496 https://bugs.webkit.org/show_bug.cgi?id=44383
3498 Modify call sites in the Apple Windows port to use DocumentMarkerController.
3500 No functionality was changed, so no new tests.
3503 (WebFrame::unmarkAllMisspellings):
3504 (WebFrame::unmarkAllBadGrammar):
3506 (WebView::rectsForTextMatches):
3508 2010-08-18 Jessie Berlin <jberlin@apple.com>
3510 Reviewed by Adam Roben.
3512 Bug 44180 - WebView::paint fails to paint a child WebView of a Layered Window.
3513 https://bugs.webkit.org/show_bug.cgi?id=44180
3515 Decide to end painting if the m_backingStoreBitmap is null after the call to
3516 ensureBackingStore() instead of when the rcPaint rect filled by BeginPaint is empty.
3517 The rcPaint rect filled by BeginPaint is always empty for a child WebView of a Layered
3518 Window, even if GetUpdateRect and GetUpdateRgn report a non-empty region that needs
3524 2010-08-17 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
3526 Reviewed by Darin Adler.
3528 Add NetworkingContext to avoid layer violations
3529 https://bugs.webkit.org/show_bug.cgi?id=42292
3531 Preparation: Just add the files to the build system.
3533 * WebCoreSupport/WebFrameNetworkingContext.cpp: Added.
3534 Empty placeholder for now.
3535 * WebCoreSupport/WebFrameNetworkingContext.h: Added.
3536 Placeholder with tentative code that might be changed when landing
3538 * WebKit.vcproj/WebKit.vcproj: Added new files.
3540 2010-08-17 Brady Eidson <beidson@apple.com>
3542 Reviewed by Sam Weinig.
3544 Navigating back/forward during a modal dialog causes a crash when the modal dialog is dismissed.
3545 <rdar://problem/8313579> and https://bugs.webkit.org/show_bug.cgi?id=44131
3548 (WebView::canGoBack): Return false if loads are deferred.
3549 (WebView::canGoForward): Ditto.
3551 2010-08-16 Kinuko Yasuda <kinuko@chromium.org>
3553 Unreviewed; build fix attempt for Windows.
3555 * DefaultDownloadDelegate.cpp:
3557 2010-08-12 Jeremy Orlow <jorlow@chromium.org>
3560 https://bugs.webkit.org/show_bug.cgi?id=43794
3563 (WebView::initWithFrame):
3565 2010-08-12 Jeremy Orlow <jorlow@chromium.org>
3567 Build fix. Matches solutions in qt and mac ports for
3568 https://bugs.webkit.org/show_bug.cgi?id=43794
3571 (WebView::initWithFrame):
3573 2010-08-10 Gavin Barraclough <barraclough@apple.com>
3575 Build fix (update more includes)
3578 * WebLocalizableStrings.cpp:
3579 * WebNotificationCenter.cpp:
3580 * WebPreferences.cpp:
3582 2010-08-10 Chris Marrin <cmarrin@apple.com>
3584 Reviewed by Oliver Hunt.
3586 Add suspendAnimations/resumeAnimation API to DRT
3587 https://bugs.webkit.org/show_bug.cgi?id=43733
3591 * Interfaces/IWebFramePrivate.idl: