1 2011-01-21 Adam Roben <aroben@apple.com>
3 Update for WKCACFLayerRenderer -> CACFLayerTreeHost rename
5 Also renamed WebView::m_layerRenderer to WebView::m_layerTreeHost to match.
7 Fixes <http://webkit.org/b/52898> WKCACFLayerRenderer sounds like a render object, but isn't
9 Reviewed by Simon Fraser.
13 (WebView::setAcceleratedCompositing): Also made sure to remove our HWND from the layer tree
14 host before we get rid of the layer tree host itself.
17 2011-01-21 Adam Roben <aroben@apple.com>
19 Replace some "sync compositing state" terminology with "flush pending GraphicsLayer changes"
21 This seems to be the direction in which our code is moving. I chose "GraphicsLayer" as
22 opposed to just "layer" because there are cases where we flush changes to CACFLayers that
23 don't have a corresponding GraphicsLayer.
25 Fixes <http://webkit.org/b/52894> "Sync compositing state" terminology in
26 WKCACFLayerRenderer and friends is confusing
28 Reviewed by Simon Fraser.
30 * WebCoreSupport/WebChromeClient.cpp:
31 (WebChromeClient::scheduleCompositingLayerSync): Updated for WebView changes.
34 (WebView::paint): Updated for rename.
35 (WebView::flushPendingGraphicsLayerChangesSoon): Renamed from scheduleCompositingLayerSync.
36 (WebView::notifySyncRequired): Updated for rename.
37 (WebView::flushPendingGraphicsLayerChanges): Renamed from syncCompositingState.
39 * WebView.h: Did the renames.
41 2011-01-20 Sam Weinig <sam@webkit.org>
43 Reviewed by Dave Hyatt.
45 Cleanup Scrollbar/ScrollbarClient relationship
46 https://bugs.webkit.org/show_bug.cgi?id=52779
49 (WebScrollBar::WebScrollBar):
50 (WebScrollBar::setValue):
51 (WebScrollBar::value):
52 (WebScrollBar::scroll):
53 (WebScrollBar::scrollPosition):
54 (WebScrollBar::setScrollOffset):
57 2011-01-19 Adam Roben <aroben@apple.com>
59 Update for WKCACFLayerRenderer changes
61 Fixes <http://webkit.org/b/52749> WKCACFLayerRenderer should be
64 Reviewed by Simon Fraser.
67 (WebView::~WebView): Added some assertions to make sure we've gotten rid of our
68 compositing-related members. My biggest concern was making sure that m_layerRenderer was
69 gone, which would also mean we had nulled out its client pointer.
70 (WebView::setAcceleratedCompositing): Changed to call WKCACFLayerRenderer::setClient instead
71 of passing the client into create(), and to clear out the client before nulling out
74 * WebView.h: Changed m_layerRenderer from an OwnPtr to a RefPtr.
76 2011-01-19 Adam Roben <aroben@apple.com>
78 Teach WebView::scrollBackingStore about compositing mode
81 compositing/scroll-painted-composited-content.html
83 Fixes <http://webkit.org/b/52720> REGRESSION (r75987): Assertion failure in
84 WebView::scrollBackingStore when scrolling page with composited content
86 Reviewed by Anders Carlsson.
89 (WebView::scrollBackingStore): Do something sensible (though naive) when in compositing
90 mode, rather than incorrectly asserting that this function is never called in that case. For
91 now we just repaint the entire scrolled region; someday hopefully we can avoid having to
92 repaint the areas that have just been moved.
94 2011-01-19 Simon Fraser <simon.fraser@apple.com>
96 Reviewed by Sam Weinig.
98 GraphicsLayers in subframes can get sync'd multiple times
99 https://bugs.webkit.org/show_bug.cgi?id=52489
102 (WebView::syncCompositingState): syncCompositingStateRecursive()
103 was renamed to syncCompositingStateIncludingSubframes().
105 2011-01-17 Adam Roben <aroben@apple.com>
107 Update for WKCACFLayerRenderer changes
109 Fixes <http://webkit.org/b/52587> WKCACFLayerRenderer is hard to use
111 Reviewed by Chris Marrin.
114 (WebView::WebViewWndProc): Removed call to layerRendererBecameVisible
115 when handling WM_SHOWWINDOW. All this did was try to create the
116 renderer, but it had already been created in setAcceleratedCompositing,
118 (WebView::setAcceleratedCompositing): Removed call to createRenderer;
119 setHostWindow does this for us now.
121 * WebView.h: Removed animationsStarted and layerRendererBecameVisible.
123 2011-01-17 Adam Roben <aroben@apple.com>
125 Paint directly into a GraphicsLayer when using accelerated compositing
127 Before this patch, we were painting into our normal backing store
128 HBITMAP, wrapping it in a CGImage, and handing it off to Core
129 Animation. This had at least two disadvantages:
130 1) The bitmap could be modified while Core Animation was using it.
131 2) It introduced extra complexity.
133 When entering accelerated compositing mode, WebView now creates a
134 GraphicsLayer to draw into. This GraphicsLayer sits between the root
135 layer (owned by WKCACFLayerRenderer) and the RenderView's layer. When
136 WebView invalidates, it just calls setNeedsDisplayInRect on its
137 GraphicsLayer. When WebView paints, it just tells its
138 WKCACFLayerRenderer to paint, which will call back to WebView to draw
139 into the GraphicsLayer if it has a dirty region. This is very similar
140 to the current implementation of LayerBackedDrawingArea in WebKit2.
142 Fixes <http://webkit.org/b/52582> WebView should paint directly into a
143 GraphicsLayer when in accelerated compositing mode
145 Reviewed by Simon Fraser and Chris Marrin.
147 * WebCoreSupport/WebChromeClient.cpp:
148 (WebChromeClient::attachRootGraphicsLayer):
149 (WebChromeClient::scheduleCompositingLayerSync):
150 Updated for WebView changes.
153 (WebView::repaint): When using accelerated compositing, just invalidate
154 our backing layer. This matches the behavior of LayerBackedDrawingArea.
155 (WebView::deleteBackingStore): Removed accelerated compositing code.
156 The WKCACFLayerRenderer doesn't need to know about our backing store
157 anymore; we don't use it at all when in accelerated compositing mode.
158 (WebView::addToDirtyRegion): When using accelerated compositing, just
159 invalidate our backing layer.
160 (WebView::scrollBackingStore): Added an assertion that this isn't
161 called in accelerated compositing mode.
162 (WebView::sizeChanged): Update our backing layer's size, too, and
164 (WebView::updateBackingStore): Added an assertion that this isn't
165 called in accelerated compositing mode.
166 (WebView::paint): If we're in accelerated compositing mode, sync our
167 compositing state. If we're *still* in accelerated compositing mode,
168 just tell our WKCACFLayerRenderer to paint and clear our dirty region.
169 (The later changes in this function are just un-indenting code that
170 used to be inside an if.)
172 (WebView::paintIntoBackingStore):
173 (WebView::paintIntoWindow):
174 Added assertions that these aren't called in accelerated compositing
177 (WebView::WebViewWndProc): Updated WM_XP_THEMECHANGED handling for
178 removal of setRootLayerNeedsDisplay.
179 (WebView::setRootChildLayer): Changed to take a GraphicsLayer. We now
180 set the layer as a child of our own backing layer.
181 (WebView::scheduleCompositingLayerSync): Just call through to
183 (WebView::setAcceleratedCompositing): Create our backing layer and set
184 it as the child of WKCACFLayerRenderer's root layer.
185 (WebView::notifyAnimationStarted): Added. We never expect this
186 GraphicsLayerClient override to be called, as we don't use animations
187 on our backing layer.
188 (WebView::notifySyncRequired): Added. Just schedule a sync.
189 (WebView::paintContents): Added. Just clip and paint!
191 (WebView::showDebugBorders):
192 (WebView::showRepaintCounter):
193 Added. These just call through to Settings.
195 (WebView::syncCompositingState): Changed to first update layout, then
196 sync state for our backing layer, then sync WebCore's state. This
197 matches LayerBackedDrawingArea.
199 * WebView.h: WebView now implements the GraphicsLayerClient interface.
200 Removed setRootLayerNeedsDisplay; it's been replaced by calling
201 setNeedsDisplay on our backing layer and calling
202 syncCompositingStateSoon on WKCACFLayerRenderer as needed. Removed
203 updateRootLayerContents; that function was used to pass our backing
204 store to Core Animation, which we no longer do. Added m_backingLayer.
206 2011-01-17 Tony Gentilcore <tonyg@chromium.org>
208 Reviewed by Alexey Proskuryakov.
210 Fix some headers with missing or misspelled #ifndef guards
211 https://bugs.webkit.org/show_bug.cgi?id=52545
213 * WebKitStatistics.h:
215 2011-01-17 Pavel Feldman <pfeldman@chromium.org>
217 Reviewed by Yury Semikhatsky.
219 Web Inspector: simplify debugger enabling routine.
220 https://bugs.webkit.org/show_bug.cgi?id=52472
223 (WebInspector::toggleDebuggingJavaScript):
225 2011-01-16 Adam Barth <abarth@webkit.org>
227 Rubber-stamped by Eric Seidel.
229 Move WebKit into Source
230 https://bugs.webkit.org/show_bug.cgi?id=52530
232 * WebKit.vcproj/Interfaces.vcproj:
233 * WebKit.vcproj/WebKit.sln:
234 * WebKit.vcproj/WebKit.vcproj:
235 * WebKit.vcproj/WebKitGUID.vcproj:
237 2011-01-15 Adam Barth <abarth@webkit.org>
239 Rubber-stamped by Eric Seidel.
241 Move WebKit2 into Source
242 https://bugs.webkit.org/show_bug.cgi?id=52438
244 Update reference to WebKit2.
246 * WebKit.vcproj/WebKit.sln:
248 2011-01-14 Yuzo Fujishima <yuzo@google.com>
250 Reviewed by Antti Koivisto.
252 Rename cache() to memoryCache()
253 https://bugs.webkit.org/show_bug.cgi?id=52433
256 (WebCache::statistics):
258 (WebCache::setDisabled):
259 (WebCache::disabled):
261 (WebView::setCacheModel):
263 2011-01-10 Geoffrey Garen <ggaren@apple.com>
265 Try to fix Windows build.
267 * WebJavaScriptCollector.cpp: Updated for rename to Heap.*. (Didn't catch
268 this one before because it was miscapitalized.)
270 2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>
272 Reviewed by Darin Fisher.
274 https://bugs.webkit.org/show_bug.cgi?id=41441
275 createWindow method should only do window-creating without URL navigation
277 * WebCoreSupport/WebChromeClient.cpp:
278 (WebChromeClient::createWindow):
280 2011-01-07 Adam Barth <abarth@webkit.org>
282 Rubber-stamped by Eric Seidel.
284 Move WebCore to Source
285 https://bugs.webkit.org/show_bug.cgi?id=52050
287 * WebKit.vcproj/WebKit.sln:
289 2011-01-06 Gavin Barraclough <barraclough@apple.com>
291 Reviewed by Geoff Garen.
293 Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
295 The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
296 destructor early, in order to release wrappers once we know we no longer intend to use them.
297 Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
298 lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
299 A sequence of events that triggers the bug would look like this:
301 (1) Create a DOMWrapperWorld.
302 (2) Register a timer in the world.
303 (3) Call unregisterWorld() on the world.
304 (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
305 (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
306 called forgetWorld() none exists.
307 (6) Attempt to add a wrapper to a NULL map.
309 Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
311 * WebScriptWorld.cpp:
312 (WebScriptWorld::unregisterWorld):
314 2011-01-07 Chris Marrin <cmarrin@apple.com>
316 Rubber-stamped by Simon Fraser.
318 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
319 https://bugs.webkit.org/show_bug.cgi?id=49388
321 Change client API for the fullscreen video controller. It now uses a
322 PlatformCALayerClient so it can use a PlaformCALayer directly. Also
323 updated how to connect the layer tree to the view to reflect the updated
324 hardware compositing logic.
326 * FullscreenVideoController.cpp:
327 (FullscreenVideoController::LayerClient::LayerClient):
328 (FullscreenVideoController::LayerClient::platformCALayerRespondsToLayoutChanges):
329 (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
330 (FullscreenVideoController::LayerClient::platformCALayerContentsOrientation):
331 (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
332 (FullscreenVideoController::LayerClient::platformCALayerShowDebugBorders):
333 (FullscreenVideoController::LayerClient::platformCALayerShowRepaintCounter):
334 (FullscreenVideoController::LayerClient::platformCALayerIncrementRepaintCount):
335 (FullscreenVideoController::LayerClient::platformCALayerContentsOpaque):
336 (FullscreenVideoController::LayerClient::platformCALayerDrawsContent):
337 (FullscreenVideoController::LayerClient::platformCALayerLayerDidDisplay):
338 (FullscreenVideoController::LayerClient::platformCALayerLayoutSublayersOfLayer):
339 (FullscreenVideoController::FullscreenVideoController):
340 (FullscreenVideoController::~FullscreenVideoController):
341 (FullscreenVideoController::enterFullscreen):
342 * FullscreenVideoController.h:
343 * WebCoreSupport/WebChromeClient.cpp:
344 (WebChromeClient::attachRootGraphicsLayer):
345 (WebChromeClient::scheduleCompositingLayerSync):
347 (WebView::setRootChildLayer):
348 (WebView::animationsStarted):
349 (WebView::syncCompositingState):
351 (WebView::setRootLayerNeedsDisplay):
353 2011-01-05 Steve Falkenburg <sfalken@apple.com>
355 Reviewed by Darin Adler.
357 Debug and Release builds on Windows clobber each other
358 https://bugs.webkit.org/show_bug.cgi?id=49185
360 Changes the structure of WebKitBuild build products directory so we
361 completely separate each build configuration into independent directories.
363 Although we previously had per-configuration directories for obj, this change adds
364 per-configuration directories for bin, lib, obj, and include. Each configuration's
365 build products are stored within a directory inside of WebKitBuild.
367 Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
368 defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
370 * WebKit.vcproj/InterfacesCommon.vsprops:
371 * WebKit.vcproj/InterfacesPostBuild.cmd:
372 * WebKit.vcproj/InterfacesPreBuild.cmd:
373 * WebKit.vcproj/WebKit.make:
374 * WebKit.vcproj/WebKitGUID.vcproj:
375 * WebKit.vcproj/WebKitGUIDCommon.vsprops:
376 * WebKit.vcproj/WebKitGUIDPostBuild.cmd:
377 * WebKit.vcproj/WebKitGUIDPreBuild.cmd:
378 * WebKit.vcproj/WebKitLibCommon.vsprops:
379 * WebKit.vcproj/WebKitLibPostBuild.cmd:
380 * WebKit.vcproj/WebKitLibPreBuild.cmd:
382 2011-01-04 Chris Fleizach <cfleizach@apple.com>
384 Reviewed by Sam Weinig.
386 WK2: Support Accessibility
387 https://bugs.webkit.org/show_bug.cgi?id=51859
389 Use rootObject() method to get the top of the AX tree.
391 * AccessibleDocument.cpp:
392 (AccessibleDocument::AccessibleDocument):
394 2011-01-01 Adam Barth <abarth@webkit.org>
396 Reviewed by Eric Seidel.
398 Move JavaScriptCore to Source
399 https://bugs.webkit.org/show_bug.cgi?id=51604
401 * WebKit.vcproj/WebKit.sln:
402 - Point to JavaScriptCore in its new location.
404 2010-12-22 Sam Weinig <sam@webkit.org>
406 Reviewed by Darin Adler.
408 WebKit2 needs to mirror the frame tree in the UIProcess
409 https://bugs.webkit.org/show_bug.cgi?id=51546
411 - Add client functions to notify that a frame has been added or
412 removed from the page cache.
414 * WebCoreSupport/WebFrameLoaderClient.cpp:
415 (WebFrameLoaderClient::didSaveToPageCache):
416 (WebFrameLoaderClient::didRestoreFromPageCache):
417 * WebCoreSupport/WebFrameLoaderClient.h:
419 2010-12-22 Dan Bernstein <mitz@apple.com>
421 Changed WebKitTools to Tools.
423 * WebKit.vcproj/WebKit.sln:
425 2010-12-14 Adam Roben <aroben@apple.com>
427 Always record the last-set cursor, even when the UI delegate is
428 setting the cursor for us
430 Prior to r63339, the last-set cursor was recorded in Widget::setCursor.
431 r63339 moved that code up to WebChromeClient, but failed to call it
432 when the UI delegate was the one setting the cursor.
434 Fixes <http://webkit.org/b/45692> <rdar://problem/8423464> REGRESSION
435 (r63339): Mouse cursor disappears when holding mouse button down on
438 Reviewed by Ada Chan.
440 * WebCoreSupport/WebChromeClient.cpp:
441 (WebChromeClient::setCursor): After the cursor is set, regardless of
442 whether the UI delegate sets it or we set it, record the cursor that
443 was just set. That way we'll be able to use the cursor later when
444 responding to the WM_SETCURSOR message.
446 2010-12-13 Alexey Proskuryakov <ap@apple.com>
448 Reviewed by Adam Barth.
450 https://bugs.webkit.org/show_bug.cgi?id=50953
451 DNS Prefetch should be an opt-in feature
453 * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Changed default to NO.
455 2010-10-28 MORITA Hajime <morrita@google.com>
457 Reviewed by Ojan Vafai.
459 spellcheck does not check pasted text
460 https://bugs.webkit.org/show_bug.cgi?id=40092
462 Added a stub implememntation.
464 * WebCoreSupport/WebEditorClient.h:
465 (WebEditorClient::requestCheckingOfString):
467 2010-12-10 Chris Fleizach <cfleizach@apple.com>
469 Reviewed by Darin Adler.
471 AX: refactor AccessibilityRenderObject::doAccessibilityHitTest
472 https://bugs.webkit.org/show_bug.cgi?id=50574
474 * AccessibleBase.cpp:
475 (AccessibleBase::accHitTest):
477 2010-12-09 Brian Weinstein <bweinstein@apple.com>
479 Reviewed by Adam Roben.
481 Prep for WebKit2: Context menu support on Windows
482 https://bugs.webkit.org/show_bug.cgi?id=50514
484 Update WebKit for the new CROSS_PLATFORM_CONTEXT_MENUS flag, and define customizeMenu
485 instead of getCustomMenuFromDefaultItems.
487 * WebCoreSupport/WebContextMenuClient.cpp:
488 (WebContextMenuClient::customizeMenu): getCustomMenuFromDefaultItems was turned into
489 this function, with refactoring using nativeMenu instead of platformDescription.
490 (WebContextMenuClient::contextMenuItemSelected): Use nativeMenu instead of platformDescription.
491 * WebCoreSupport/WebContextMenuClient.h:
493 (WebView::handleContextMenuEvent): Call nativeMenu instead of platformDescription.
494 (WebView::performContextMenuAction): Only call itemAtIndex with one argument, no need
497 2010-12-07 Brian Weinstein <bweinstein@apple.com>
499 Reviewed by John Sullivan.
501 Layering Violation in ContextMenu - member variable of type HitTestResult
502 https://bugs.webkit.org/show_bug.cgi?id=50586
504 Update users of ContextMenu and ContextMenuController to match where the new functions
507 * WebCoreSupport/WebContextMenuClient.cpp:
508 (WebContextMenuClient::getCustomMenuFromDefaultItems): Get the HitTestResult and ContextMenu from the
509 ContextMenuController (from the page).
510 (WebContextMenuClient::contextMenuItemSelected): Get the HitTestResult from the ContextMenuController.
512 (WebView::handleContextMenuEvent): Ditto.
514 2010-12-07 Jessie Berlin <jberlin@apple.com>
516 Build fix. Unreviewed.
518 * WebCoreSupport/WebContextMenuClient.cpp:
519 (WebContextMenuClient::searchWithGoogle):
520 FrameLoader::urlSelected does not take a SecurityOrigin as a parameter.
522 2010-12-06 Darin Adler <darin@apple.com>
524 Reviewed by Sam Weinig.
526 Pass security origin to make local file decision correctly
527 https://bugs.webkit.org/show_bug.cgi?id=48603
529 * WebCoreSupport/WebContextMenuClient.cpp:
530 (WebContextMenuClient::searchWithGoogle): Pass security origin.
532 2010-12-07 Kenichi Ishibashi <bashi@google.com>
534 Reviewed by Kent Tamura.
536 Let HTMLObjectElement be a form associated element
537 https://bugs.webkit.org/show_bug.cgi?id=48821
539 Modified to use FormAssociatedElement instead of HTMLFormControlElement.
542 (WebFrame::elementWithName): Modified to use FormAssociatedElement
543 instead of HTMLFormControlElement.
544 (WebFrame::controlsInForm): Ditto.
546 2010-12-05 Adam Roben <aroben@apple.com>
548 Windows production build fix
550 Put spaces after trailing backslashes when setting
551 %WebKitVSPropsRedirectionDir%. According to MSDN
552 <http://msdn.microsoft.com/en-us/library/2kzfk8c7(v=VS.80).aspx>:
554 A backslash ( \ ) followed by a newline character is interpreted as
555 a space in the command; use a backslash at the end of a line to
556 continue a command onto the next line. NMAKE interprets the
557 backslash literally if any other character, including a space or
558 tab, follows the backslash.
560 * WebKit.vcproj/WebKit.make:
562 2010-12-03 Sam Weinig <sam@webkit.org>
564 Reviewed by Maciej Stachowiak.
566 Enable <a ping> for Mac/Windows/WebKit2 builds
567 <rdar://problem/8504473>
568 https://bugs.webkit.org/show_bug.cgi?id=50488
570 * WebPreferences.cpp:
571 (WebPreferences::initializeDefaultSettings): Enable "HyperlinkAuditing" by default.
573 2010-12-03 Brian Weinstein <bweinstein@apple.com>
575 Reviewed by Brady Eidson.
577 WebContextMenuClient::fixMenuReceivedFromOldSafari is no longer needed on Windows
578 https://bugs.webkit.org/show_bug.cgi?id=50486
580 Remove the static fixMenuReceivedFromOldSafari and isPreInspectElementTagSafari methods
581 from WebContextMenuClient. There were there for when WebKit had the Inspect Element context menu
582 item, but Safari didn't support it. We don't support that old Safari, so that code can go.
584 * WebCoreSupport/WebContextMenuClient.cpp:
585 (WebContextMenuClient::getCustomMenuFromDefaultItems):
587 2010-12-02 John Knottenbelt <jknotten@chromium.org>
589 Reviewed by Steve Block.
591 Move requestGeolocationPermissionForFrame to GeolocationClient
592 https://bugs.webkit.org/show_bug.cgi?id=50061
594 This change facilitates client-based geolocation implementation by
595 bringing together permission control into the geolocation client
598 Move method ChromeClient::requestGeolocationPermissionForFrame to
599 GeolocationClient::requestPermission. The moved code is unchanged
600 except that requestPermission now takes only one argument (Geolocation*),
601 the Frame parameter is retrieved from the Geolocation object and we need to
602 call m_webView.get() as it is a COMPtr in GeolocationClient.
604 * WebCoreSupport/WebChromeClient.cpp:
605 * WebCoreSupport/WebChromeClient.h:
606 * WebCoreSupport/WebGeolocationClient.cpp:
607 (WebGeolocationClient::requestPermission):
608 * WebCoreSupport/WebGeolocationClient.h:
609 (WebGeolocationClient::cancelPermissionRequest):
611 2010-12-01 Jia Pu <jpu@apple.com>
613 Reviewed by Darin Adler.
615 Support multiple correction candidates panel for misspelled word on Mac OS X.
616 https://bugs.webkit.org/show_bug.cgi?id=50137
617 <rdar://problem/8568059>
619 Adopted new function signature defined in base class.
621 * WebCoreSupport/WebEditorClient.cpp:
622 (WebEditorClient::getGuessesForWord):
623 * WebCoreSupport/WebEditorClient.h:
625 2010-12-01 Steve Falkenburg <sfalken@apple.com>
627 Reviewed by Adam Roben.
629 WinCairo build should not use link-time code generation (LTCG)
630 https://bugs.webkit.org/show_bug.cgi?id=50353
632 * WebKit.vcproj/Interfaces.vcproj:
633 * WebKit.vcproj/WebKit.vcproj:
634 * WebKit.vcproj/WebKitGUID.vcproj:
636 2010-12-01 Steve Falkenburg <sfalken@apple.com>
638 Reviewed by Adam Roben.
640 vcproj changes can't be applied cleanly by the Windows EWS bot
641 https://bugs.webkit.org/show_bug.cgi?id=50328
643 * WebKit.vcproj/Interfaces.vcproj: Modified property svn:eol-style.
644 * WebKit.vcproj/InterfacesCommon.vsprops: Added property svn:eol-style.
645 * WebKit.vcproj/WebKit.sln: Modified property svn:eol-style.
646 * WebKit.vcproj/WebKit.submit.sln: Modified property svn:eol-style.
647 * WebKit.vcproj/WebKit.vcproj: Modified property svn:eol-style.
648 * WebKit.vcproj/WebKitGUID.vcproj: Modified property svn:eol-style.
649 * WebKit.vcproj/WebKitGUIDCommon.vsprops: Added property svn:eol-style.
650 * WebKit.vcproj/WebKitLibCommon.vsprops: Added property svn:eol-style.
652 2010-11-30 Steve Falkenburg <sfalken@apple.com>
654 Reviewed by Adam Roben.
656 All projects on Windows should use cmd files for build events
657 https://bugs.webkit.org/show_bug.cgi?id=50213
659 * WebKit.vcproj/InterfacesCommon.vsprops:
660 * WebKit.vcproj/InterfacesPostBuild.cmd: Added.
661 * WebKit.vcproj/InterfacesPreBuild.cmd: Added.
662 * WebKit.vcproj/WebKitGUIDCommon.vsprops:
663 * WebKit.vcproj/WebKitGUIDPostBuild.cmd: Added.
664 * WebKit.vcproj/WebKitGUIDPreBuild.cmd: Added.
665 * WebKit.vcproj/WebKitLibCommon.vsprops:
666 * WebKit.vcproj/WebKitLibPostBuild.cmd: Added.
667 * WebKit.vcproj/WebKitLibPreBuild.cmd: Added.
669 2010-11-29 Brent Fulgham <bfulgham@webkit.org>
671 Unreviewed build correction.
673 * WebKit.vcproj/WebKit.vcproj: Update WebKit project to
674 use WinCairo.vsprops definition for appropriate build targets.
676 2010-11-22 Adam Roben <aroben@apple.com>
678 Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
680 Apple's Windows build allows placing header files and import libraries for WebKit's
681 dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
682 $WebKitLibrariesDir environment variable. This is both required for production builds and
683 convenient for Apple-internal developer builds. Apple's production builds also require that
684 WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
685 builds, the files are copied into that directory tree by the
686 WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
688 JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
690 This .vsprops copying is problematic in one very important case: when a developer updates
691 their source tree and then tries to build. Visual Studio only reads .vsprops files when a
692 project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
693 updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
694 build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
695 $WebKitLibrariesDir, but Visual Studio will not pick up the changes. The rest of the build
696 will proceed with out-of-date .vsprops files, which will likely result in a build failure.
698 To fix this, we now use normal relative paths to access the .vsprops files in the source
699 tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
700 variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
701 unset, so the normal relative paths are used to read the .vsprops files out of the source
702 tree directly. In production builds, this environment variable is set to a fake directory
703 that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
706 For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
708 $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
710 In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
711 files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
712 JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
713 "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
714 FeatureDefines.vsprops becomes:
716 $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
720 $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
722 (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
723 actually exist since they are matched by an equal number of ".." path components.)
725 Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
726 Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
728 Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
731 Reviewed by Dave Hyatt.
733 * WebKit.vcproj/WebKit.make: Set $WebKitVSPropsRedirectionDir so that production builds can
734 find the .vsprops files.
736 * WebKit.vcproj/WebKit.vcproj:
737 * WebKit.vcproj/Interfaces.vcproj:
738 * WebKit.vcproj/WebKitGUID.vcproj:
739 Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
742 2010-11-19 Steve Falkenburg <sfalken@apple.com>
744 Reviewed by Adam Roben.
746 Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
747 https://bugs.webkit.org/show_bug.cgi?id=49819
749 * WebKit.vcproj/Interfaces.vcproj:
750 * WebKit.vcproj/WebKit.sln:
751 * WebKit.vcproj/WebKit.vcproj:
752 * WebKit.vcproj/WebKitGUID.vcproj:
754 2010-11-19 Steve Falkenburg <sfalken@apple.com>
756 Reviewed by Darin Adler.
758 Normalize Cairo/CFLite project/solution configuration names
759 https://bugs.webkit.org/show_bug.cgi?id=49818
761 * WebKit.vcproj/WebKit.sln:
762 * WebKit.vcproj/WebKit.vcproj:
764 2010-11-18 Steve Falkenburg <sfalken@apple.com>
766 Reviewed by Adam Roben.
768 Windows vcproj configuration names should be normalized across projects
769 https://bugs.webkit.org/show_bug.cgi?id=49776
771 * WebKit.vcproj/Interfaces.vcproj:
772 * WebKit.vcproj/WebKit.sln:
774 2010-11-18 Steve Falkenburg <sfalken@apple.com>
776 Reviewed by Adam Roben.
778 Remove leftover Windows Debug_Internal configurations
779 https://bugs.webkit.org/show_bug.cgi?id=49758
781 * WebKit.vcproj/WebKit.vcproj:
782 * WebKit.vcproj/WebKitGUID.vcproj:
784 2010-11-18 Steve Falkenburg <sfalken@apple.com>
786 Reviewed by Adam Roben.
788 Debug_Internal Windows configuration is unnecessary, should be removed
789 https://bugs.webkit.org/show_bug.cgi?id=49753
793 2010-11-17 Steve Falkenburg <sfalken@apple.com>
795 Reviewed by Adam Roben.
797 WebKit Interfaces project should use vsprops file for common build settings
798 https://bugs.webkit.org/show_bug.cgi?id=49713
800 * WebKit.vcproj/Interfaces.vcproj:
801 * WebKit.vcproj/InterfacesCommon.vsprops: Added.
803 2010-11-16 Steve Falkenburg <sfalken@apple.com>
805 Reviewed by Adam Roben.
807 Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
808 https://bugs.webkit.org/show_bug.cgi?id=49632
810 * WebKit.vcproj/Interfaces.vcproj:
811 * WebKit.vcproj/WebKit.make:
812 * WebKit.vcproj/WebKit.sln:
813 * WebKit.vcproj/WebKit.submit.sln:
814 * WebKit.vcproj/WebKit.vcproj:
815 * WebKit.vcproj/WebKitGUID.vcproj:
817 2010-11-16 Dave Hyatt <hyatt@apple.com>
819 Reviewed by Dan Bernstein.
821 https://bugs.webkit.org/show_bug.cgi?id=11004
823 font-size:0 is ignored. Remove the minimum font size of 1 in CSSStyleSelector.
824 Change the pref value for minimum font size from 1 to 0. Make sure to never use the NSFont's size,
825 since it doesn't honor a size of 0. Instead pass the size in to the FontPlatformData(NSFont*) version
826 of the constructor rather than using [NSFont pointSize].
828 https://bugs.webkit.org/show_bug.cgi?id=49582
830 Negative leading is not handled correctly. There are two bugs here. The first is that
831 maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
832 set them before so that we can allow them to be < 0.
834 The second issue is that we should understand where fonts will end up relative to
835 our baseline (excluding line height), and only allow those boxes to impact ascent and
836 descent if the actual font box (without factoring in line height) is above or below the
837 root line box baseline.
839 Added fast/css/negative-leading.html
841 These two bug fixes have to land together to keep the Acid 3 test rendering correctly.
843 * WebPreferences.cpp:
844 (WebPreferences::initializeDefaultSettings):
846 2010-11-16 Steve Falkenburg <sfalken@apple.com>
848 Reviewed by Adam Roben.
850 Use vsprops files for common settings in Windows WebKit
851 https://bugs.webkit.org/show_bug.cgi?id=49622
853 * WebKit.vcproj/WebKit.vcproj:
854 * WebKit.vcproj/WebKitCommon.vsprops: Added.
856 2010-11-16 Steve Falkenburg <sfalken@apple.com>
858 Rubber stamped by Adam Roben.
860 Remove unnecessary def file, remove outdated def files from vcproj.
862 * WebKit.vcproj/WebKit.vcproj:
863 * WebKit.vcproj/WebKit_debug.def: Removed.
865 2010-11-12 John Knottenbelt <jknotten@chromium.org>
867 Reviewed by Steve Block.
869 Rename GeolocationControllerClient to GeolocationClient.
870 https://bugs.webkit.org/show_bug.cgi?id=49259
872 * WebCoreSupport/WebGeolocationClient.cpp: Renamed from WebKit/win/WebCoreSupport/WebGeolocationControllerClient.cpp.
873 (WebGeolocationClient::WebGeolocationClient):
874 (WebGeolocationClient::geolocationDestroyed):
875 (WebGeolocationClient::startUpdating):
876 (WebGeolocationClient::stopUpdating):
877 (WebGeolocationClient::lastPosition):
878 * WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/win/WebCoreSupport/WebGeolocationControllerClient.h.
879 (WebGeolocationClient::setEnableHighAccuracy):
880 * WebKit.vcproj/WebKit.vcproj:
882 (WebView::initWithFrame):
884 2010-11-10 Csaba Osztrogonác <ossy@webkit.org>
886 Reviewed by David Hyatt.
888 HTML5 Ruby support should be mandatory feature
889 https://bugs.webkit.org/show_bug.cgi?id=49272
891 * WebKitPrefix.h: Touch it to avoid incremental build failure on Windows.
893 2010-11-08 Alexey Proskuryakov <ap@apple.com>
897 * WebCoreSupport/WebChromeClient.h: Added namespace prefix.
899 2010-11-08 Alexey Proskuryakov <ap@apple.com>
901 Reviewed by Darin Adler.
903 https://bugs.webkit.org/show_bug.cgi?id=48685
904 Notify UI process about focused frame
906 Added an empty implementation of the new ChromeClient method.
908 * WebCoreSupport/WebChromeClient.cpp:
909 (WebChromeClient::focusedFrameChanged):
910 * WebCoreSupport/WebChromeClient.h:
912 2010-11-07 Adam Barth <abarth@webkit.org>
914 Reviewed by Eric Seidel.
916 Rename Cache to MemoryCache
917 https://bugs.webkit.org/show_bug.cgi?id=49159
920 (WebCache::statistics):
924 2010-11-05 Chris Marrin <cmarrin@apple.com>
926 Reviewed by Simon Fraser.
928 Move resumeAnimations/suspendAnimations from Frame to AnimationController.
929 https://bugs.webkit.org/show_bug.cgi?id=49073
932 (WebFrame::suspendAnimations):
933 (WebFrame::resumeAnimations):
935 2010-11-05 Brian Weinstein <bweinstein@apple.com>
937 Reviewed by Anders Carlsson.
939 Assertion failure in PluginStream::~PluginStream when running userscripts/user-script-plugin-document.html
940 https://bugs.webkit.org/show_bug.cgi?id=48751
941 <rdar://problem/8615536>
943 Always call committedLoad in WebFrameLoaderClient::finishedLoading, even if we have a manual loader. We were
944 running into a case where we were trying to load an empty plugin document, which uses a manual loader, and
945 PluginStream::didFinishLoading was never being called. The stream was never being stopped, making us fire
946 an assert in the PluginStream destructor.
948 * WebCoreSupport/WebFrameLoaderClient.cpp:
949 (WebFrameLoaderClient::finishedLoading):
951 2010-11-05 Chris Marrin <cmarrin@apple.com>
953 Reviewed by Simon Fraser.
955 Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state
956 https://bugs.webkit.org/show_bug.cgi?id=46945
959 (WebFrame::suspendAnimations):
960 (WebFrame::resumeAnimations):
962 2010-11-05 Patrick Gansterer <paroga@webkit.org>
964 Reviewed by David Kilzer.
966 Replace ARRAYSIZE with WTF_ARRAY_LENGTH
967 https://bugs.webkit.org/show_bug.cgi?id=48903
969 * WebCoreSupport/WebChromeClient.cpp:
970 (WebChromeClient::exceededDatabaseQuota):
974 (WebView::mouseWheel):
976 2010-11-02 Daniel Bates <dbates@rim.com>
978 Reviewed by Adam Barth.
980 For unnamed frames, window.name returns a generated name
981 https://bugs.webkit.org/show_bug.cgi?id=6751
985 Substitute FrameTree::uniqueName() for FrameTree::name() in the Apple Windows port.
990 2010-11-02 Brady Eidson <beidson@apple.com>
992 Reviewed by Anders Carlsson.
994 <rdar://problem/8346191> and https://bugs.webkit.org/show_bug.cgi?id=48868
995 Implement IMutableWebRequest::setTimeoutInterval
997 * WebMutableURLRequest.cpp:
998 (WebMutableURLRequest::setTimeoutInterval):
1000 2010-11-02 Daniel Bates <dbates@rim.com>
1002 Reviewed by Martin Robinson.
1004 Set frame name before appending it to the frame tree in the Apple Windows,
1006 https://bugs.webkit.org/show_bug.cgi?id=48806
1008 Make the frame creation process in the Apple Windows-port consistent
1009 with the Mac, Qt, and Haiku ports. In particular, set the name of
1010 the new frame before it's appended to the frame tree.
1012 At this time we cannot test this change since it is being masked by
1013 HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>.
1014 We'll be able to test this once we fix bug #6751.
1016 * WebCoreSupport/WebFrameLoaderClient.cpp:
1017 (WebFrameLoaderClient::createFrame):
1019 2010-11-01 Jenn Braithwaite <jennb@chromium.org>
1021 Reviewed by Adam Roben.
1023 Windows: Update resource tracking when moving a frame between documents
1024 https://bugs.webkit.org/show_bug.cgi?id=48364
1026 * Interfaces/IWebResourceLoadDelegatePrivate2.idl:Added
1027 Added removeIdentifierForRequest.
1028 * Interfaces/WebKit.idl:
1029 Added IWebResourceLoadDelegatePrivate2.idl.
1030 * WebCoreSupport/WebFrameLoaderClient.cpp:
1031 (WebFrameLoaderClient::transferLoadingResourceFromPage):
1033 2010-11-01 Brady Eidson <beidson@apple.com>
1035 Reviewed by Anders Carlsson.
1037 <rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699
1038 Context menu support for WebKit 2.
1040 * WebCoreSupport/WebChromeClient.h:
1041 (WebChromeClient::showContextMenu):
1043 2010-11-01 Adam Roben <aroben@apple.com>
1045 Cancel main resource loads after we hand them off to the media engine
1047 This is the Windows equivalent of r51104. Clearly this code should be
1048 moved to a cross-platform location someday.
1050 Fixes <http://webkit.org/b/48531> <rdar://problem/8606635> Assertion
1051 failure in DocumentLoader::commitData when loading a media document in
1054 Reviewed by Dan Bernstein.
1056 * WebCoreSupport/WebFrameLoaderClient.cpp:
1057 (WebFrameLoaderClient::committedLoad): Cancel the main resource load
1058 after handing off the load to the media engine. This code originally
1059 came from -[WebHTMLRepresentation receivedData:withDataSource:].
1062 (WebFrame::shouldFallBack): Don't fall back when handing the resource
1063 load off to the media engine or a plugin. Added error domain checking
1064 so that we don't rely on error codes being unique.
1066 2010-10-29 Daniel Bates <dbates@rim.com>
1068 No review, rolling out 70971.
1069 http://trac.webkit.org/changeset/70971
1070 https://bugs.webkit.org/show_bug.cgi?id=6751
1072 Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
1073 it caused layout test failures on all bots. In particular, the
1074 child count in a generated frame name differs after this patch. We need
1075 to look into this further.
1080 2010-10-28 Antonio Gomes <agomes@rim.com>
1082 Reviewed by Ojan Vafai.
1084 Needs a "LinuxEditingBehavior", perhaps with a better name
1085 https://bugs.webkit.org/show_bug.cgi?id=36627
1087 Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
1089 * Interfaces/IWebPreferences.idl:
1091 2010-10-29 Daniel Bates <dbates@rim.com>
1093 Reviewed by Adam Barth.
1095 For unnamed frames, window.name returns a generated name
1096 https://bugs.webkit.org/show_bug.cgi?id=6751
1098 Modified Apple Windows-port to use FrameTree::uniqueName().
1103 2010-10-29 Darin Adler <darin@apple.com>
1105 Reviewed by Sam Weinig.
1107 Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
1108 https://bugs.webkit.org/show_bug.cgi?id=48574
1110 * WebBackForwardList.cpp:
1111 (backForwardListWrappers):
1112 (WebBackForwardList::WebBackForwardList):
1113 (WebBackForwardList::createInstance):
1114 * WebBackForwardList.h:
1116 (WebView::backForwardList):
1117 Use BackForwardListImpl.
1119 2010-10-29 Adam Roben <aroben@apple.com>
1123 * WebKitPrefix.h: Touched to force a rebuild.
1125 2010-10-29 Alexey Proskuryakov <ap@apple.com>
1127 Reviewed by Darin Adler.
1129 https://bugs.webkit.org/show_bug.cgi?id=48576
1130 Let WebKit2 client know when a frame is a frameset
1132 Added a blank implementation of the new FrameLoaderClient method.
1134 * WebCoreSupport/WebFrameLoaderClient.h:
1135 * WebCoreSupport/WebFrameLoaderClient.cpp:
1136 (WebFrameLoaderClient::dispatchDidBecomeFrameset):
1138 2010-10-26 Brent Fulgham <bfulgham@webkit.org>
1140 Unreviewed build fix.
1142 * WebView.cpp: Conditionalize includes for CFNetwork-specific
1143 Cookie implementation.
1144 * WebView.h: Conditionalize includes for ACCELERATED_COMPOSITION.
1145 WinCairo doesn't use CoreAnimation.
1147 2010-10-26 Jenn Braithwaite <jennb@chromium.org>
1149 Reviewed by Dmitry Titov.
1151 Resource tracking failure when trying to move a frame between documents
1152 https://bugs.webkit.org/show_bug.cgi?id=44713
1154 * WebCoreSupport/WebFrameLoaderClient.cpp:
1155 (WebFrameLoaderClient::transferLoadingResourceFromPage):
1157 * WebCoreSupport/WebFrameLoaderClient.h:
1159 2010-10-25 Patrick Gansterer <paroga@webkit.org>
1161 Reviewed by David Kilzer.
1163 Replace _countof with WTF_ARRAY_LENGTH
1164 https://bugs.webkit.org/show_bug.cgi?id=48229
1166 * WebCoreSupport/WebContextMenuClient.cpp:
1167 (isPreInspectElementTagSafari):
1169 (WebView::interpretKeyEvent):
1171 2010-10-24 Dan Bernstein <mitz@apple.com>
1175 * Interfaces/WebKit.idl: Touched.
1177 2010-10-24 Dan Bernstein <mitz@apple.com>
1179 Reviewed by Anders Carlsson.
1181 Expose HitTestResult::absoluteMediaURL() via WebKit API
1182 https://bugs.webkit.org/show_bug.cgi?id=48219
1184 * Interfaces/IWebView.idl: Added WebElementMediaURLKey.
1185 * WebElementPropertyBag.cpp:
1186 (WebElementPropertyBag::Read): Map WebElementMediaURLKey to absoluteMediaURL().
1188 2010-10-22 Andy Estes <aestes@apple.com>
1190 Fix the Windows build.
1192 * WebCookieManagerCFNet.cpp: Rename CookieStorageWin.h to CookieStorageCFNet.h.
1193 * WebView.cpp: Ditto.
1195 2010-10-22 Jenn Braithwaite <jennb@chromium.org>
1197 Reviewed by Adam Roben.
1199 Windows client needs updating when live iframe element is moved between pages
1200 https://bugs.webkit.org/show_bug.cgi?id=46915
1202 * WebCoreSupport/WebFrameLoaderClient.cpp:
1203 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
1204 Update WebView in WebFrame to match that of the current page.
1206 (WebFrame::setWebView):
1210 2010-10-22 Sam Weinig <sam@webkit.org>
1214 * WebCoreSupport/WebChromeClient.h:
1216 2010-10-22 Sam Weinig <sam@webkit.org>
1218 Reviewed by Anders Carlsson.
1220 WebKit2 needs to pass the current event modifier flags when requesting a new window
1221 https://bugs.webkit.org/show_bug.cgi?id=48140
1223 * WebCoreSupport/WebChromeClient.cpp:
1224 (WebChromeClient::createWindow):
1225 * WebCoreSupport/WebFrameLoaderClient.cpp:
1226 (WebFrameLoaderClient::dispatchCreatePage):
1227 * WebCoreSupport/WebFrameLoaderClient.h:
1228 Add NavigationAction parameter.
1230 2010-10-21 MORITA Hajime <morrita@google.com>
1232 Unreviewed, touched it to fix the build.
1234 * Interfaces/WebKit.idl:
1236 2010-10-21 MORITA Hajime <morrita@google.com>
1238 Reviewed by Kent Tamura.
1240 [Win][DRT] should have LayoutTestController.hasSpellingMarker()
1241 https://bugs.webkit.org/show_bug.cgi?id=47885
1243 Added IWebFramePrivate::hasSpellingMarker() and impelmented it for
1244 LayoutTestController.
1246 * Interfaces/IWebFramePrivate.idl:
1248 (WebFrame::hasSpellingMarker):
1251 2010-10-20 Dumitru Daniliuc <dumi@chromium.org>
1253 Reviewed by David Levin.
1255 Repost the DatabaseTracker notifications to the main thread, if needed.
1256 https://bugs.webkit.org/show_bug.cgi?id=40655
1258 * WebDatabaseManager.cpp:
1259 (DidModifyOriginData::dispatchToMainThread):
1260 (DidModifyOriginData::DidModifyOriginData):
1261 (DidModifyOriginData::dispatchDidModifyOriginOnMainThread):
1262 (WebDatabaseManager::dispatchDidModifyOrigin):
1263 (WebDatabaseManager::dispatchDidModifyDatabase):
1265 2010-10-20 Dirk Schulze <krit@webkit.org>
1267 Reviewed by Nikolas Zimmermann.
1269 Merge ColorSpace and ImageColorSpace enums
1270 https://bugs.webkit.org/show_bug.cgi?id=47922
1272 Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
1273 to follow webkit style rules.
1275 * FullscreenVideoController.cpp:
1278 (FullscreenVideoController::draw):
1279 * WebCoreSupport/WebDragClient.cpp:
1280 (WebDragClient::createDragImageForLink):
1281 * WebKitGraphics.cpp:
1284 2010-10-18 Pavel Podivilov <podivilov@chromium.org>
1286 Reviewed by Timothy Hatcher.
1288 Web Inspector: disable private browsing for inspector
1289 https://bugs.webkit.org/show_bug.cgi?id=47827
1291 * WebCoreSupport/WebInspectorClient.cpp:
1292 (WebInspectorClient::openInspectorFrontend):
1294 2010-10-17 Adam Barth <abarth@webkit.org>
1296 Reviewed by Dimitri Glazkov.
1298 FrameLoader doesn't need an explicit userGesture parameter
1299 https://bugs.webkit.org/show_bug.cgi?id=47777
1301 Update for the new API.
1303 * WebCoreSupport/WebContextMenuClient.cpp:
1304 (WebContextMenuClient::searchWithGoogle):
1306 2010-10-15 Brian Weinstein <bweinstein@apple.com>
1308 Reviewed by Sam Weinig.
1310 REGRESSION(r69850) Loading apple.com/startpage in WebKit on Windows gets a bad request.
1311 https://bugs.webkit.org/show_bug.cgi?id=47753
1312 <rdar://problem/8558242>
1314 VerQueryValue returns a null terminated string, but we need to strip off the null terminating character
1315 when we turn it into a WebCore string, or else concatenation using this string will break.
1319 2010-10-15 Jessie Berlin <jberlin@apple.com>
1321 Windows build fix. Unreviewed.
1323 * WebCoreSupport/WebInspectorClient.cpp:
1324 Add a missing include.
1326 2010-10-15 Nikolas Zimmermann <nzimmermann@rim.com>
1328 Reviewed by Dirk Schulze.
1330 Replace some String::format() usages by StringConcatenate in WebKit
1331 https://bugs.webkit.org/show_bug.cgi?id=47714
1333 * WebCoreSupport/WebInspectorClient.cpp:
1334 (WebInspectorFrontendClient::updateWindowTitle):
1336 (WebView::standardUserAgentWithApplicationName):
1339 2010-10-14 Ilya Tikhonovsky <loislo@chromium.org>
1341 Reviewed by Pavel Feldman.
1343 Web Inspector: inspector settings/properties/states management
1344 should be extracted into separate class.
1346 We have a lot of flags/values in InspectorController.
1347 Some flags are persisting into profile.
1348 Others are part of inspector state for frontend.
1349 All these flags should keep their values after navigation.
1350 It'd be better to extract these flags/values into separate
1351 class which will care about theirs lifetime.
1353 https://bugs.webkit.org/show_bug.cgi?id=47275
1355 * WebCoreSupport/WebInspectorClient.cpp:
1356 (WebInspectorFrontendClient::attachWindow):
1357 (WebInspectorFrontendClient::detachWindow):
1358 (WebInspectorFrontendClient::showWindowWithoutNotifications):
1360 2010-10-13 Gavin Barraclough <barraclough@apple.com>
1362 Reviewed by Oliver Hunt.
1364 https://bugs.webkit.org/show_bug.cgi?id=43987
1365 Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder
1366 to construct their internal result string. Remove ScriptString (this is now
1369 * WebCoreSupport/WebFrameLoaderClient.cpp:
1371 2010-10-12 Adam Roben <aroben@apple.com>
1373 Build TestWebKitAPI on Windows
1375 Fixes <http://webkit.org/b/47552> <rdar://problem/8541708> Make
1376 TestWebKitAPI work on Windows
1378 Reviewed by Sam Weinig.
1380 * WebKit.vcproj/WebKit.sln: Added TestWebKitAPI and
1381 TestWebKitAPIGenerated and made them build just after
1384 2010-10-11 Shinichiro Hamaji <hamaji@chromium.org>
1386 Attempt to fix windows build failure.
1388 Remove WebIconFetcher from WebKit and IconFetcher from WebCore
1389 https://bugs.webkit.org/show_bug.cgi?id=47523
1391 * Interfaces/IWebFramePrivate.idl: s/unused1/unused2/
1392 * Interfaces/WebKit.idl: Touched.
1393 * WebFrame.cpp: s/unused1/unused2/
1394 (WebFrame::unused2):
1395 * WebFrame.h: s/unused1/unused2/
1397 2010-10-11 Anders Carlsson <andersca@apple.com>
1399 Reviewed by Darin Adler.
1401 Remove WebIconFetcher from WebKit and IconFetcher from WebCore
1402 https://bugs.webkit.org/show_bug.cgi?id=47523
1404 Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.
1406 * Interfaces/IWebFramePrivate.idl:
1407 * Interfaces/IWebIconFetcher.idl: Removed.
1408 * Interfaces/WebKit.idl:
1410 (WebFrame::unused1):
1412 * WebIconFetcher.cpp: Removed.
1413 * WebIconFetcher.h: Removed.
1414 * WebKit.vcproj/Interfaces.vcproj:
1415 * WebKit.vcproj/WebKit.vcproj:
1417 2010-10-11 Jessie Berlin <jberlin@apple.com>
1419 Reviewed by Darin Adler.
1421 Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal
1422 representation of a WebKit1 WebSerializedJSValue.
1423 https://bugs.webkit.org/show_bug.cgi?id=47439
1425 * Interfaces/IWebSerializedJSValuePrivate.idl:
1426 Because it is taking a void** parameter, getInternalRepresentation must be declared [local].
1428 * WebSerializedJSValue.cpp:
1429 (WebSerializedJSValue::getInternalRepresentation):
1430 * WebSerializedJSValue.h:
1432 2010-10-07 Jessie Berlin <jberlin@apple.com>
1434 Reviewed by Sam Weinig.
1436 Add Private API for creating a WebKit1 WebSerializedJSValue from the internal
1437 representation of a WebKit2 WebSerializedScriptValue.
1438 https://bugs.webkit.org/show_bug.cgi?id=47390
1440 * Interfaces/WebKit.idl:
1441 Generate IWebSerializedJSValuePrivate.
1443 * Interfaces/IWebSerializedJSValuePrivate.idl: Added.
1444 Because it is taking a void* parameter, setInternalRepresentation must be declared [local].
1446 * WebKit.vcproj/Interfaces.vcproj:
1447 Add IWebSerializedJSValue.idl and IWebSerializedJSValuePrivate.idl.
1449 * WebSerializedJSValue.cpp:
1450 (WebSerializedJSValue::QueryInterface):
1451 Since there are now two interfaces that inherit from IUnknown, do not try to cast to
1452 IUnknown* anymore. Cast to IWebSerializedJSValue* instead.
1453 (WebSerializedJSValue::setInternalRepresentation):
1454 Only set the internal representation if it hasn't already been set.
1455 * WebSerializedJSValue.h:
1457 2010-10-04 Jon Honeycutt <jhoneycutt@apple.com>
1459 Prevent an assertion failure when trying to create a protection space
1462 Reviewed by Sam Weinig.
1464 * WebURLProtectionSpace.cpp:
1465 (WebURLProtectionSpace::initWithHost):
1466 Remove the ASSERT_NOT_REACHED().
1468 2010-10-05 Brent Fulgham <bfulgham@webkit.org>
1470 Unreviewed build correction.
1472 * WebKit.vcproj/WebKit.sln: Turn the QTMovieWin project
1473 off for WinCairo release builds. Somehow this was
1474 incorrectly turned on.
1476 2010-10-01 Mark Rowe <mrowe@apple.com>
1480 Clear the executable bit from a number of source files.
1485 2010-09-30 Darin Adler <darin@apple.com>
1487 Reviewed by Sam Weinig.
1489 Remove remaining calls to deprecatedParseURL
1490 https://bugs.webkit.org/show_bug.cgi?id=26599
1492 * WebCoreSupport/WebFrameLoaderClient.cpp:
1493 (WebFrameLoaderClient::dispatchDidFailToStartPlugin):
1494 Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
1496 2010-09-28 Jenn Braithwaite <jennb@chromium.org>
1498 Reviewed by Dmitry Titov.
1500 Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
1501 https://bugs.webkit.org/show_bug.cgi?id=46663
1503 * WebCoreSupport/WebFrameLoaderClient.cpp:
1504 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
1505 * WebCoreSupport/WebFrameLoaderClient.h:
1507 2010-09-27 Andrey Kosyakov <caseq@chromium.org>
1509 Unreviewed build fix (win; broken in r68371)
1511 * WebFrame.cpp: remove include <WebCore/ResourceHandleWin.h>
1513 2010-09-23 Matthew Delaney <mdelaney@apple.com>
1515 Reviewed by Simon Fraser.
1517 Reduce minimum DOMTimer interval
1518 https://bugs.webkit.org/show_bug.cgi?id=45362
1521 Updating set interval call to use Settings' static version inside
1522 one time init block.
1524 2010-09-23 Nate Chapin <japhet@chromium.org>
1526 Unreviewed, build fix.
1528 Move hyperlinkAuditingEnabled to IWebPreferencesPrivate.idl
1529 and touch WebKit.idl
1531 * Interfaces/IWebPreferences.idl:
1532 * Interfaces/IWebPreferencesPrivate.idl:
1533 * Interfaces/WebKit.idl:
1535 (WebView::notifyPreferencesChanged):
1537 2010-09-23 Nate Chapin <japhet@chromium.org>
1539 Unreviewed, build fix.
1541 Look for hyperlinkAuditingEnabled in the right set of preferences.
1544 (WebView::notifyPreferencesChanged):
1546 2010-09-23 Nate Chapin <japhet@chromium.org>
1548 Reviewed by Darin Fisher.
1550 Add hyperlink auditing settings (i.e., <a ping>).
1551 https://bugs.webkit.org/show_bug.cgi?id=30458
1553 * Interfaces/IWebPreferences.idl:
1554 * WebPreferenceKeysPrivate.h:
1555 * WebPreferences.cpp:
1556 (WebPreferences::initializeDefaultSettings):
1557 (WebPreferences::hyperlinkAuditingEnabled):
1558 (WebPreferences::setHyperlinkAuditingEnabled):
1561 (WebView::notifyPreferencesChanged):
1563 2010-09-23 Matthew Delaney <mdelaney@apple.com>
1565 Reviewed by Adam Roben.
1567 Create one time initialization block for WebView's initWithFrame
1568 https://bugs.webkit.org/show_bug.cgi?id=46307
1570 * WebView.cpp: Added one time initialization block for webview code
1571 that needs only be run once and not for each webview. This is just as
1572 the mac version WebView.mm does.
1574 2010-09-22 Brent Fulgham <bfulgham@webkit.org>
1576 Reviewed by Martin Robinson.
1578 [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
1579 https://bugs.webkit.org/show_bug.cgi?id=46303.
1581 * WebKit.vcproj/WebKit.sln: Update overall Debug_Cairo and
1582 Release_Cairo configurations to select appropriate build
1583 targets for WebKitTestRunner and MiniBrowser.
1585 2010-09-22 Brent Fulgham <bfulgham@webkit.org>
1587 Reviewed by Martin Robinson.
1589 [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.rt
1590 https://bugs.webkit.org/show_bug.cgi?id=46303.
1592 * WebKit.vcproj/WebKit.sln: Update overall Debug_Cairo and
1593 Release_Cairo configurations to select appropriate build
1594 targets for InjectionBundle.
1596 2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>
1598 Reviewed by Kenneth Rohde Christiansen.
1600 PluginStrategy should satisfy the needs of Qt
1601 https://bugs.webkit.org/show_bug.cgi?id=45857
1602 No new functionality so no new tests.
1604 * WebCoreSupport/WebPlatformStrategies.cpp:
1605 (WebPlatformStrategies::getPluginInfo):
1606 * WebCoreSupport/WebPlatformStrategies.h:
1608 2010-09-20 Philippe Normand <pnormand@igalia.com>
1610 Reviewed by Eric Carlson.
1612 [GTK] enhanced context menu for media elements
1613 https://bugs.webkit.org/show_bug.cgi?id=45021
1615 New localized strings for the media element context-menu.
1617 * WebCoreSupport/WebPlatformStrategies.cpp:
1618 (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow):
1619 (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow):
1620 (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard):
1621 (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard):
1622 (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
1623 (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
1624 (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
1625 (WebPlatformStrategies::contextMenuItemTagMediaPlay):
1626 (WebPlatformStrategies::contextMenuItemTagMediaPause):
1627 (WebPlatformStrategies::contextMenuItemTagMediaMute):
1628 * WebCoreSupport/WebPlatformStrategies.h:
1630 2010-09-17 Darin Adler <darin@apple.com>
1632 Reviewed by Sam Weinig.
1634 REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
1635 https://bugs.webkit.org/show_bug.cgi?id=42863
1638 (WebView::setZoomMultiplier):
1639 Call functions on Frame instead of FrameView.
1641 2010-09-17 Matthew Delaney <mdelaney@apple.com>
1643 Reviewed by Simon Fraser.
1645 Reduce minimum DOMTimer interval
1646 https://bugs.webkit.org/show_bug.cgi?id=45362
1648 * WebView.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.
1650 2010-09-17 Simon Fraser <simon.fraser@apple.com>
1652 Reviewed by Chris Marrin.
1654 Remove scroll and clip layers for WKCACFLayerRenderer
1655 https://bugs.webkit.org/show_bug.cgi?id=45922
1657 WKCACFLayerRenderer no longer needs its own layers for managing scrolling
1658 and clipping, because RenderLayerCompositor provides this functionality.
1661 (WebView::sizeChanged): Moved code that handles the WM_SIZE message
1662 into this method. Use it to resize the layer renderer.
1663 (WebView::WebViewWndProc): Call sizeChanged().
1664 (WebView::updateRootLayerContents): No need to call setScrollFrame() any more.
1665 (WebView::layerRendererBecameVisible): Move this from the header (no need to be inline).
1668 2010-09-16 Darin Adler <darin@apple.com>
1670 Reviewed by Andreas Kling.
1672 Reduce use of HTMLInputElement::inputType so we can remove it later
1673 https://bugs.webkit.org/show_bug.cgi?id=45903
1676 (WebFrame::elementDoesAutoComplete): Use isPasswordField.
1677 (WebFrame::elementIsPassword): Use isPasswordField.
1679 2010-09-14 Ada Chan <adachan@apple.com>
1681 Reviewed by Adam Roben.
1683 Add an IWebFramePrivate API to load string as plain text into the WebFrame.
1684 https://bugs.webkit.org/show_bug.cgi?id=45782
1686 * Interfaces/IWebFramePrivate.idl:
1687 * Interfaces/WebKit.idl: Touch the file.
1689 (WebFrame::loadPlainTextString):
1692 2010-09-13 Enrica Casucci <enrica@apple.com>
1694 Reviewed by Sam Weinig.
1696 Paste should be implemented in WebCore like Copy and Cut for Mac also.
1697 https://bugs.webkit.org/show_bug.cgi?id=45494
1698 <rdar://problem/7660537>
1700 On the Mac platform, the implementation of the paste operation is all done
1701 at the WebKit level. In order to support it on WebKit2 it is necessary to
1702 refactor the code and move this functionality at the level of WebCore like
1703 we already have on Windows.
1704 The original code relies on some in AppKit functions that call back into
1705 WebKit causing problems in WebKit2. All this functionality has been moved
1706 at the level of the editor client where it can be dealt with appropriately.
1709 (WebFrame::canShowMIMETypeASHTML): Added.
1711 2010-09-11 Adam Barth <abarth@webkit.org>
1713 Reviewed by Sam Weinig.
1715 Make SecurityOrigin::canDisplay an instance function
1716 https://bugs.webkit.org/show_bug.cgi?id=45219
1719 (WebFrame::allowsFollowingLink):
1721 2010-09-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
1723 Reviewed by Darin Adler.
1725 Add NetworkingContext to avoid layer violations
1726 https://bugs.webkit.org/show_bug.cgi?id=42292
1728 * WebCoreSupport/WebFrameNetworkingContext.cpp:
1729 (WebFrameNetworkingContext::blockedError):
1730 * WebCoreSupport/WebFrameNetworkingContext.h:
1732 2010-09-10 Jer Noble <jer.noble@apple.com>
1734 Reviewed by Simon Fraser.
1736 Movies with track or movie matrices don't display in <video> elements (Safari 5/Windows)
1737 https://bugs.webkit.org/show_bug.cgi?id=45333
1739 The rootChild layer must be set as flipped, otherwise transformed movies will appear
1740 incorrectly rotated.
1742 * FullscreenVideoController.cpp:
1743 (FullscreenVideoController::enterFullscreen):
1745 2010-09-10 Sam Weinig <sam@webkit.org>
1747 Reviewed by Darin Adler.
1749 Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
1750 Precursor to <rdar://problem/7660657>
1751 https://bugs.webkit.org/show_bug.cgi?id=45522
1759 (WebView::setZoomMultiplier):
1760 (WebView::zoomMultiplier):
1761 (WebView::canMakeTextLarger):
1762 (WebView::makeTextLarger):
1763 (WebView::canMakeTextSmaller):
1764 (WebView::makeTextSmaller):
1765 (WebView::notifyPreferencesChanged):
1767 Move tracking of text only zoom here from WebCore.
1769 2010-09-10 Brian Weinstein <bweinstein@apple.com>
1771 Windows Build Fix. Fix some fallout from r67238, currentForm is now off of
1772 SelectionController instead of frame. Also fix a style issue.
1775 (WebFrame::currentForm):
1777 2010-09-10 Adam Barth <abarth@webkit.org>
1779 Reviewed by Darin Fisher.
1781 Move code from WebKit-layer to DocumentLoader
1782 https://bugs.webkit.org/show_bug.cgi?id=45569
1784 * WebCoreSupport/WebFrameLoaderClient.cpp:
1785 (WebFrameLoaderClient::committedLoad):
1786 * WebCoreSupport/WebFrameLoaderClient.h:
1788 2010-09-09 Darin Adler <darin@apple.com>
1790 Reviewed by Adam Barth.
1792 Move functions from Frame to SelectionController as planned
1793 https://bugs.webkit.org/show_bug.cgi?id=45508
1796 (WebView::selectionRect):
1797 (WebView::centerSelectionInVisibleArea):
1798 Call functions on selection().
1800 2010-09-10 Adam Barth <abarth@webkit.org>
1802 Reviewed by Eric Seidel.
1804 Main resource bytes shouldn't bounce through FrameLoader
1805 https://bugs.webkit.org/show_bug.cgi?id=45496
1807 Now return the bytes to the DocumentLoader.
1809 * WebCoreSupport/WebFrameLoaderClient.cpp:
1810 (WebFrameLoaderClient::receivedData):
1812 2010-09-09 Simon Fraser <simon.fraser@apple.com>
1814 Reviewed by Adam Roben.
1816 Scrollbars fail to render in composited iframes.
1817 https://bugs.webkit.org/show_bug.cgi?id=45335
1819 Use LocalWindowsContext when painting scrollbars.
1821 * WebCoreSupport/WebChromeClient.cpp:
1822 (WebChromeClient::paintCustomScrollbar):
1823 (WebChromeClient::paintCustomScrollCorner):
1825 2010-09-08 Darin Adler <darin@apple.com>
1827 Reviewed by Adam Barth.
1829 Move functions from Frame to Editor as planned
1830 https://bugs.webkit.org/show_bug.cgi?id=45218
1832 * WebCoreSupport/WebContextMenuClient.cpp:
1833 (WebContextMenuClient::searchWithGoogle):
1835 (WebFrame::selectedString):
1837 (WebView::selectedText):
1838 (WebView::prepareCandidateWindow):
1839 (WebView::onIMERequestCharPosition):
1840 Changed call sites to use editor().
1842 2010-09-08 Peter Kasting <pkasting@google.com>
1844 Not reviewed, build fix.
1847 (WebScrollBar::setScrollOffsetFromAnimation):
1849 2010-09-08 Peter Kasting <pkasting@google.com>
1851 Not reviewed, build fix.
1854 (WebScrollBar::scrollSize):
1855 (WebScrollBar::setScrollOffsetFromAnimation):
1857 2010-09-08 Peter Kasting <pkasting@google.com>
1859 Not reviewed, build fix.
1862 (WebScrollBar::setValue):
1863 (WebScrollBar::scrollSize):
1864 (WebScrollBar::setScrollOffsetFromAnimation):
1867 2010-09-08 Adam Barth <abarth@webkit.org>
1869 Attempted Window build fix.
1871 * WebDataSource.cpp:
1872 (WebDataSource::subresourceForURL):
1874 2010-09-08 Adam Barth <abarth@webkit.org>
1876 Rubber-stamped by Eric Seidel.
1878 Rename DocLoader to CachedResourceLoader because that's what it does.
1880 * WebDataSource.cpp:
1882 2010-09-07 Brent Fulgham <bfulgham@webkit.org>
1884 Reviewed by Adam Roben.
1886 Clean up a potential resource leak.
1887 https://bugs.webkit.org/show_bug.cgi?id=45198
1889 Several bitmap device context were being created and used,
1890 and destroyed without returning the context to its original
1891 state. This showed up as bitmap leaks in BoundsChecker.
1893 * FullscreenVideoController.cpp:
1895 (WebView::scrollBackingStore):
1898 2010-09-06 Adam Barth <abarth@webkit.org>
1900 Reviewed by Darin Adler.
1902 Rename SecurityOrigin::canLoad to canDisplay
1903 https://bugs.webkit.org/show_bug.cgi?id=45214
1905 Propagate name change.
1908 (WebFrame::allowsFollowingLink):
1910 2010-09-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
1912 Reviewed by Darin Adler.
1914 Add NetworkingContext to avoid layer violations
1915 https://bugs.webkit.org/show_bug.cgi?id=42292
1917 Add Win's specific implementation of NetworkingContext.
1919 * WebCoreSupport/WebFrameNetworkingContext.cpp:
1920 (WebFrameNetworkingContext::create):
1921 (WebFrameNetworkingContext::userAgent):
1922 (WebFrameNetworkingContext::referrer):
1924 (WebFrame::createNetworkingContext):
1927 2010-09-03 Adam Roben <aroben@apple.com>
1929 Attempt to fixing Windows nightlies again
1931 The fix in r66438 should be sufficient, but we have to touch
1932 WebKit.idl to force that change to be picked up by the build.
1934 * Interfaces/WebKit.idl: Touched this file to force a build.
1936 2010-09-02 Yury Semikhatsky <yurys@chromium.org>
1938 Reviewed by PavelFeldman.
1940 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
1941 https://bugs.webkit.org/show_bug.cgi?id=44230
1943 * WebCoreSupport/WebInspectorClient.cpp:
1944 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
1945 (WebInspectorFrontendClient::closeWindow):
1946 (WebInspectorFrontendClient::disconnectFromBackend):
1947 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
1948 (WebInspectorFrontendClient::destroyInspectorView):
1949 * WebCoreSupport/WebInspectorClient.h:
1951 2010-09-01 Jessie Berlin <jberlin@apple.com>
1953 Reviewed by Adam Roben.
1955 WebViews should allow their parent windows to handle WM_MOUSEACTIVATE messages.
1956 https://bugs.webkit.org/show_bug.cgi?id=45047
1959 (WebView::WebViewWndProc):
1961 2010-08-31 Dave Hyatt <hyatt@apple.com>
1963 Reviewed by Sam Weinig.
1965 https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
1966 the former can occur in more places without having to do the latter.
1969 (WebFrame::paintDocumentRectToContext):
1971 (WebView::updateBackingStore):
1973 2010-08-30 Adam Roben <aroben@apple.com>
1975 Fix crash on launch on Windows due to changing IWebFramePrivate's
1978 This regressed in r65107.
1980 Fixes <http://webkit.org/b/44755>.
1982 Rubber-stamped by Jon Honeycutt.
1984 * Interfaces/IWebFramePrivate.idl: Moved suspendAnimations and
1985 resumeAnimations to the end of the interface so that the vtable will
1986 match what Safari expects.
1988 2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
1990 Unreviewed, rolling out r66198.
1991 http://trac.webkit.org/changeset/66198
1992 https://bugs.webkit.org/show_bug.cgi?id=44856
1994 It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
1996 * WebCoreSupport/WebInspectorClient.cpp:
1997 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
1998 (WebInspectorFrontendClient::closeWindow):
1999 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
2000 (WebInspectorFrontendClient::destroyInspectorView):
2001 * WebCoreSupport/WebInspectorClient.h:
2003 2010-08-27 Yury Semikhatsky <yurys@chromium.org>
2005 Reviewed by Pavel Feldman.
2007 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
2008 https://bugs.webkit.org/show_bug.cgi?id=44230
2010 * WebCoreSupport/WebInspectorClient.cpp:
2011 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
2012 (WebInspectorFrontendClient::closeWindow):
2013 (WebInspectorFrontendClient::disconnectFromBackend):
2014 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
2015 (WebInspectorFrontendClient::destroyInspectorView):
2016 * WebCoreSupport/WebInspectorClient.h:
2018 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
2020 Unreviewed. Revert r66103 since Qt tests are failing.
2022 * WebCoreSupport/WebInspectorClient.cpp:
2023 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
2024 (WebInspectorFrontendClient::closeWindow):
2025 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
2026 (WebInspectorFrontendClient::destroyInspectorView):
2027 * WebCoreSupport/WebInspectorClient.h:
2029 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
2031 Reviewed by Pavel Feldman.
2033 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
2034 https://bugs.webkit.org/show_bug.cgi?id=44230
2036 * WebCoreSupport/WebInspectorClient.cpp:
2037 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
2038 (WebInspectorFrontendClient::closeWindow):
2039 (WebInspectorFrontendClient::disconnectFromBackend):
2040 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
2041 (WebInspectorFrontendClient::destroyInspectorView):
2042 * WebCoreSupport/WebInspectorClient.h:
2044 2010-08-24 Ada Chan <adachan@apple.com>
2046 Reviewed by Steve Falkenburg.
2048 <rdar://problem/8185379> Possible null dereference in WebView::canShowMIMEType.
2049 https://bugs.webkit.org/show_bug.cgi?id=44564
2052 (WebView::canShowMIMEType): Null check m_page->pluginData() since that can return NULL
2053 if plugins are disabled.
2055 2010-08-22 Daniel Bates <dbates@rim.com>
2057 Reviewed by Eric Seidel.
2059 Encapsulate document marker management into DocumentMarkerController
2060 https://bugs.webkit.org/show_bug.cgi?id=44383
2062 Modify call sites in the Apple Windows port to use DocumentMarkerController.
2064 No functionality was changed, so no new tests.
2067 (WebFrame::unmarkAllMisspellings):
2068 (WebFrame::unmarkAllBadGrammar):
2070 (WebView::rectsForTextMatches):
2072 2010-08-18 Jessie Berlin <jberlin@apple.com>
2074 Reviewed by Adam Roben.
2076 Bug 44180 - WebView::paint fails to paint a child WebView of a Layered Window.
2077 https://bugs.webkit.org/show_bug.cgi?id=44180
2079 Decide to end painting if the m_backingStoreBitmap is null after the call to
2080 ensureBackingStore() instead of when the rcPaint rect filled by BeginPaint is empty.
2081 The rcPaint rect filled by BeginPaint is always empty for a child WebView of a Layered
2082 Window, even if GetUpdateRect and GetUpdateRgn report a non-empty region that needs
2088 2010-08-17 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
2090 Reviewed by Darin Adler.
2092 Add NetworkingContext to avoid layer violations
2093 https://bugs.webkit.org/show_bug.cgi?id=42292
2095 Preparation: Just add the files to the build system.
2097 * WebCoreSupport/WebFrameNetworkingContext.cpp: Added.
2098 Empty placeholder for now.
2099 * WebCoreSupport/WebFrameNetworkingContext.h: Added.
2100 Placeholder with tentative code that might be changed when landing
2102 * WebKit.vcproj/WebKit.vcproj: Added new files.
2104 2010-08-17 Brady Eidson <beidson@apple.com>
2106 Reviewed by Sam Weinig.
2108 Navigating back/forward during a modal dialog causes a crash when the modal dialog is dismissed.
2109 <rdar://problem/8313579> and https://bugs.webkit.org/show_bug.cgi?id=44131
2112 (WebView::canGoBack): Return false if loads are deferred.
2113 (WebView::canGoForward): Ditto.
2115 2010-08-16 Kinuko Yasuda <kinuko@chromium.org>
2117 Unreviewed; build fix attempt for Windows.
2119 * DefaultDownloadDelegate.cpp:
2121 2010-08-12 Jeremy Orlow <jorlow@chromium.org>
2124 https://bugs.webkit.org/show_bug.cgi?id=43794
2127 (WebView::initWithFrame):
2129 2010-08-12 Jeremy Orlow <jorlow@chromium.org>
2131 Build fix. Matches solutions in qt and mac ports for
2132 https://bugs.webkit.org/show_bug.cgi?id=43794
2135 (WebView::initWithFrame):
2137 2010-08-10 Gavin Barraclough <barraclough@apple.com>
2139 Build fix (update more includes)
2142 * WebLocalizableStrings.cpp:
2143 * WebNotificationCenter.cpp:
2144 * WebPreferences.cpp:
2146 2010-08-10 Chris Marrin <cmarrin@apple.com>
2148 Reviewed by Oliver Hunt.
2150 Add suspendAnimations/resumeAnimation API to DRT
2151 https://bugs.webkit.org/show_bug.cgi?id=43733
2155 * Interfaces/IWebFramePrivate.idl:
2157 (WebFrame::suspendAnimations):
2158 (WebFrame::resumeAnimations):
2161 2010-08-06 Gavin Barraclough <barraclough@apple.com>
2163 Rubber stamped by Sam Weinig
2165 Bug 43594 - Add string forwards to Forward.h
2166 This allows us to remove forward declarations for these classes from
2167 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
2169 * COMVariantSetter.h:
2170 * MarshallingHelpers.h:
2171 * WebCoreSupport/WebContextMenuClient.h:
2172 * WebCoreSupport/WebPluginHalterClient.h:
2175 2010-08-06 Jessie Berlin <jberlin@apple.com>
2177 Roll out http://trac.webkit.org/changeset/64801, which broke the Safari Windows Build.
2180 * COMVariantSetter.h:
2181 * MarshallingHelpers.h:
2182 * WebCoreSupport/WebContextMenuClient.h:
2183 * WebCoreSupport/WebPluginHalterClient.h:
2186 2010-08-05 Jessie Berlin <jberlin@apple.com>
2188 Reviewed by Jon Honeycutt.
2190 Bug 43593 - WebView::backingStore should check if m_backingStoreBitmap is NULL.
2191 https://bugs.webkit.org/show_bug.cgi?id=43593
2194 (WebView::backingStore):
2195 If m_backingStoreBitmap is NULL, return E_FAIL.
2197 2010-08-05 Gavin Barraclough <barraclough@apple.com>
2199 Rubber stamped by Sam Weinig
2201 Bug 43594 - Add string forwards to Forward.h
2202 This allows us to remove forward declarations for these classes from
2203 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
2205 * COMVariantSetter.h:
2206 * MarshallingHelpers.h:
2207 * WebCoreSupport/WebContextMenuClient.h:
2208 * WebCoreSupport/WebPluginHalterClient.h:
2211 2010-08-03 Adam Roben <aroben@apple.com>
2213 Turn on PLATFORM_STRATEGIES on Windows
2215 Fixes <http://webkit.org/b/43431>.
2217 Reviewed by Anders Carlsson.
2219 * WebCoreLocalizedStrings.cpp: Removed.
2220 * WebCoreSupport/WebPlatformStrategies.cpp: Added. Based on the Mac
2222 (WebPlatformStrategies::initialize): Creates the singleton instance.
2223 (WebPlatformStrategies::WebPlatformStrategies): Registers the
2224 singleton instance as the PlatformStrategies instance for WebCore.
2226 (WebPlatformStrategies::createPluginStrategy):
2227 (WebPlatformStrategies::createLocalizationStrategy):
2228 (WebPlatformStrategies::createVisitedLinkStrategy):
2229 Return ourselves as the strategy.
2231 (WebPlatformStrategies::refreshPlugins):
2232 (WebPlatformStrategies::getPluginInfo):
2233 Moved code here from WebCore's PluginDataWin.cpp file.
2235 (WebPlatformStrategies::searchableIndexIntroduction):
2236 (WebPlatformStrategies::submitButtonDefaultLabel):
2237 (WebPlatformStrategies::inputElementAltText):
2238 (WebPlatformStrategies::resetButtonDefaultLabel):
2239 (WebPlatformStrategies::fileButtonChooseFileLabel):
2240 (WebPlatformStrategies::fileButtonNoFileSelectedLabel):
2241 (WebPlatformStrategies::contextMenuItemTagOpenLinkInNewWindow):
2242 (WebPlatformStrategies::contextMenuItemTagDownloadLinkToDisk):
2243 (WebPlatformStrategies::contextMenuItemTagCopyLinkToClipboard):
2244 (WebPlatformStrategies::contextMenuItemTagOpenImageInNewWindow):
2245 (WebPlatformStrategies::contextMenuItemTagDownloadImageToDisk):
2246 (WebPlatformStrategies::contextMenuItemTagCopyImageToClipboard):
2247 (WebPlatformStrategies::contextMenuItemTagOpenFrameInNewWindow):
2248 (WebPlatformStrategies::contextMenuItemTagCopy):
2249 (WebPlatformStrategies::contextMenuItemTagGoBack):
2250 (WebPlatformStrategies::contextMenuItemTagGoForward):
2251 (WebPlatformStrategies::contextMenuItemTagStop):
2252 (WebPlatformStrategies::contextMenuItemTagReload):
2253 (WebPlatformStrategies::contextMenuItemTagCut):
2254 (WebPlatformStrategies::contextMenuItemTagPaste):
2255 (WebPlatformStrategies::contextMenuItemTagNoGuessesFound):
2256 (WebPlatformStrategies::contextMenuItemTagIgnoreSpelling):
2257 (WebPlatformStrategies::contextMenuItemTagLearnSpelling):
2258 (WebPlatformStrategies::contextMenuItemTagSearchWeb):
2259 (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary):
2260 (WebPlatformStrategies::contextMenuItemTagOpenLink):
2261 (WebPlatformStrategies::contextMenuItemTagIgnoreGrammar):
2262 (WebPlatformStrategies::contextMenuItemTagSpellingMenu):
2263 (WebPlatformStrategies::contextMenuItemTagCheckSpelling):
2264 (WebPlatformStrategies::contextMenuItemTagCheckSpellingWhileTyping):
2265 (WebPlatformStrategies::contextMenuItemTagCheckGrammarWithSpelling):
2266 (WebPlatformStrategies::contextMenuItemTagFontMenu):
2267 (WebPlatformStrategies::contextMenuItemTagBold):
2268 (WebPlatformStrategies::contextMenuItemTagItalic):
2269 (WebPlatformStrategies::contextMenuItemTagUnderline):
2270 (WebPlatformStrategies::contextMenuItemTagOutline):
2271 (WebPlatformStrategies::contextMenuItemTagWritingDirectionMenu):
2272 (WebPlatformStrategies::contextMenuItemTagTextDirectionMenu):
2273 (WebPlatformStrategies::contextMenuItemTagDefaultDirection):
2274 (WebPlatformStrategies::contextMenuItemTagLeftToRight):
2275 (WebPlatformStrategies::contextMenuItemTagRightToLeft):
2276 (WebPlatformStrategies::contextMenuItemTagShowSpellingPanel):
2277 (WebPlatformStrategies::contextMenuItemTagInspectElement):
2278 (WebPlatformStrategies::searchMenuNoRecentSearchesText):
2279 (WebPlatformStrategies::searchMenuRecentSearchesText):
2280 (WebPlatformStrategies::searchMenuClearRecentSearchesText):
2281 (WebPlatformStrategies::AXWebAreaText):
2282 (WebPlatformStrategies::AXLinkText):
2283 (WebPlatformStrategies::AXListMarkerText):
2284 (WebPlatformStrategies::AXImageMapText):
2285 (WebPlatformStrategies::AXHeadingText):
2286 (WebPlatformStrategies::AXDefinitionListTermText):
2287 (WebPlatformStrategies::AXDefinitionListDefinitionText):
2288 (WebPlatformStrategies::AXButtonActionVerb):
2289 (WebPlatformStrategies::AXRadioButtonActionVerb):
2290 (WebPlatformStrategies::AXTextFieldActionVerb):
2291 (WebPlatformStrategies::AXCheckedCheckBoxActionVerb):
2292 (WebPlatformStrategies::AXUncheckedCheckBoxActionVerb):
2293 (WebPlatformStrategies::AXLinkActionVerb):
2294 (WebPlatformStrategies::AXMenuListActionVerb):
2295 (WebPlatformStrategies::AXMenuListPopupActionVerb):
2296 (WebPlatformStrategies::unknownFileSizeText):
2297 (WebPlatformStrategies::uploadFileText):
2298 (WebPlatformStrategies::allFilesText):
2299 (WebPlatformStrategies::missingPluginText):
2300 (WebPlatformStrategies::crashedPluginText):
2301 (WebPlatformStrategies::imageTitle):
2302 (WebPlatformStrategies::multipleFileUploadText):
2303 (WebPlatformStrategies::mediaElementLoadingStateText):
2304 (WebPlatformStrategies::mediaElementLiveBroadcastStateText):
2305 (WebPlatformStrategies::localizedMediaControlElementString):
2306 (WebPlatformStrategies::localizedMediaControlElementHelpText):
2307 (WebPlatformStrategies::localizedMediaTimeDescription):
2308 (WebPlatformStrategies::validationMessageValueMissingText):
2309 (WebPlatformStrategies::validationMessageTypeMismatchText):
2310 (WebPlatformStrategies::validationMessagePatternMismatchText):
2311 (WebPlatformStrategies::validationMessageTooLongText):
2312 (WebPlatformStrategies::validationMessageRangeUnderflowText):
2313 (WebPlatformStrategies::validationMessageRangeOverflowText):
2314 (WebPlatformStrategies::validationMessageStepMismatchText):
2315 Moved code here from WebCoreLocalizedStrings.cpp (and slightly cleaned
2318 (WebPlatformStrategies::isLinkVisited):
2319 (WebPlatformStrategies::addVisitedLink):
2320 Copied code from WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm.
2322 * WebCoreSupport/WebPlatformStrategies.h: Added.
2324 * WebKit.vcproj/WebKit.vcproj: Removed WebCoreLocalizedStrings, added
2325 WebPlatformStrategies.
2328 (WebView::initWithFrame): Initialize WebPlatformStrategies.
2330 2010-08-03 Alexey Proskuryakov <ap@apple.com>
2332 Reviewed by Sam Weinig.
2334 https://bugs.webkit.org/show_bug.cgi?id=42939
2335 WebEditorClient::didBeginEditing is never called in WebKit2
2337 * WebView.cpp: (WebView::WebViewWndProc): Removed a call to setFocusedFrame. WebCore will
2338 now set it to main frame, and besides, this call should have been before setFocused(), not
2339 after it. My understanding is that we weren't getting all the same editing delegates on Windows,
2340 so this change may make WebKit1 on Windows behave more like Mac - but I haven't tested it.
2342 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
2344 Reviewed by Darin Fisher.
2346 PopupMenu refactoring in preparation to WebKit2
2347 https://bugs.webkit.org/show_bug.cgi?id=42592
2349 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
2350 instances, concrete classes that inherit from ChromeClient needed to be changed to
2351 implement the new methods.
2353 * WebCoreSupport/WebChromeClient.cpp:
2354 (WebChromeClient::selectItemWritingDirectionIsNatural):
2355 (WebChromeClient::createPopupMenu):
2356 (WebChromeClient::createSearchPopupMenu):
2357 * WebCoreSupport/WebChromeClient.h:
2359 2010-08-02 Jon Honeycutt <jhoneycutt@apple.com>
2361 Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live.
2363 Reviewed by Sam Weinig.
2365 * WebKit.vcproj/WebKit.sln:
2367 2010-08-02 Jeremy Orlow <jorlow@chromium.org>
2369 Speculative revert of 64425 due to Chromium instability
2370 https://bugs.webkit.org/show_bug.cgi?id=43347
2372 * WebCoreSupport/WebChromeClient.cpp:
2373 * WebCoreSupport/WebChromeClient.h:
2375 (WebView::mouseWheel):
2377 2010-07-31 Luiz Agostini <luiz.agostini@openbossa.org>
2382 (WebView::mouseWheel):
2384 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
2386 Reviewed by Darin Fisher.
2388 PopupMenu refactoring in preparation to WebKit2
2389 https://bugs.webkit.org/show_bug.cgi?id=42592
2391 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
2392 instances, concrete classes that inherit from ChromeClient needed to be changed to
2393 implement the new methods.
2395 * WebCoreSupport/WebChromeClient.cpp:
2396 (WebChromeClient::selectItemWritingDirectionIsNatural):
2397 (WebChromeClient::createPopupMenu):
2398 (WebChromeClient::createSearchPopupMenu):
2399 * WebCoreSupport/WebChromeClient.h:
2401 2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
2403 Unreviewed, rolling out r64422.
2404 http://trac.webkit.org/changeset/64422
2405 https://bugs.webkit.org/show_bug.cgi?id=43304
2407 Build fixes are needed for Snow Leopard and Windows.
2408 (Requested by lca on #webkit).
2410 * WebCoreSupport/WebChromeClient.cpp:
2411 * WebCoreSupport/WebChromeClient.h:
2413 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
2415 Reviewed by Darin Fisher.
2417 PopupMenu refactoring in preparation to WebKit2
2418 https://bugs.webkit.org/show_bug.cgi?id=42592
2420 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
2421 instances, concrete classes that inherit from ChromeClient needed to be changed to
2422 implement the new methods.
2424 * WebCoreSupport/WebChromeClient.cpp:
2425 (WebChromeClient::selectItemWritingDirectionIsNatural):
2426 (WebChromeClient::createPopupMenu):
2427 (WebChromeClient::createSearchPopupMenu):
2428 * WebCoreSupport/WebChromeClient.h:
2430 2010-07-31 Daniel Bates <dbates@rim.com>
2432 Attempt to fix the Windows build after changeset 64409 <http://trac.webkit.org/changeset/64409>.
2435 (WebFrame::setPrinting):
2437 2010-07-30 Dan Bernstein <mitz@apple.com>
2439 Reviewed by Darin Adler.
2441 <rdar://problem/8257783> Short documents may print a second blank page
2442 https://bugs.webkit.org/show_bug.cgi?id=43271
2445 (WebFrame::setPrinting): Updated for changes to Frame::setPrinting(). Passing 0 for the
2446 page height, which maintains existing behavior.
2448 2010-07-30 Joseph Pecoraro <joepeck@webkit.org>
2450 Reviewed by David Kilzer.
2452 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
2453 https://bugs.webkit.org/show_bug.cgi?id=40627
2455 * WebCoreSupport/WebChromeClient.cpp:
2456 (WebChromeClient::reachedApplicationCacheOriginQuota):
2457 * WebCoreSupport/WebChromeClient.h:
2459 2010-07-26 Steve Block <steveblock@google.com>
2461 Reviewed by Jeremy Orlow.
2463 Page clients should be passed to Page constructor via structure of pointers
2464 https://bugs.webkit.org/show_bug.cgi?id=42834
2467 (WebView::initWithFrame):
2469 2010-07-27 Steve Block <steveblock@google.com>
2471 Reviewed by Alexey Proskuryakov.
2473 Client-based Geolocation does not pass enableHighAccuracy option to controller and client
2474 https://bugs.webkit.org/show_bug.cgi?id=40374
2476 Stub out setEnableHighAccuracy method for the Win port.
2478 * WebCoreSupport/WebGeolocationControllerClient.h:
2479 (WebGeolocationControllerClient::setEnableHighAccuracy):
2481 2010-07-22 Sam Weinig <sam@webkit.org>
2483 Reviewed by Maciej Stachowiak.
2485 Fix for <rdar://problem/8222626>
2486 Send textDidChangeInTextField delegate callback only in response to typing or other forms of user text input.
2488 The function name no longer perfectly matches the behavior, but I didn't want to break any existing clients. Maybe we
2489 should migrate to a new function name eventually
2491 * WebCoreSupport/WebEditorClient.cpp:
2492 (WebEditorClient::textDidChangeInTextField):
2494 2010-07-21 Brady Eidson <beidson@apple.com>
2496 Reviewed by Geoffrey Garen.
2498 Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
2499 https://bugs.webkit.org/show_bug.cgi?id=42783
2502 (WebView::registerURLSchemeAsLocal):
2503 (WebView::registerURLSchemeAsSecure):
2505 2010-07-20 Steve Falkenburg <sfalken@apple.com>
2507 Reviewed by Adam Roben.
2509 WebKit on Windows should build optionally with an unversioned ICU DLL
2510 https://bugs.webkit.org/show_bug.cgi?id=42722
2511 <rdar://problem/8211767> WebKit needs to link against unversioned ICU
2513 To get the proper value for U_DISABLE_RENAMING into all source files, we force
2514 the include of ICUVersion.h (our generated header) via the compiler options.
2516 * WebKit.vcproj/WebKit.vcproj: Add forced include of ICUVersion.h.
2518 2010-07-21 Adam Roben <aroben@apple.com>
2520 Update WebKit.sln for InjectedBundle's Debug_Internal configuration
2522 Fixes <http://webkit.org/b/42749> InjectedBundle's build
2523 configurations are screwy
2525 Reviewed by Darin Adler.
2527 * WebKit.vcproj/WebKit.sln: Build the Debug_Internal variant of
2528 InjectedBundle when we're using the Debug_Internal solution
2531 2010-07-21 Adam Roben <aroben@apple.com>
2533 Add MiniBrowser to WebKit.sln
2535 It is the last project to build.
2537 Fixes <http://webkit.org/b/42747> build-webkit should build
2540 Reviewed by Darin Adler.
2542 * WebKit.vcproj/WebKit.sln: Added MiniBrowser, and made it depend on
2545 2010-07-20 Adam Roben <aroben@apple.com>
2547 Add WebKitTestRunner and friends to WebKit.sln
2549 We added these projects to WebKit2.sln in r63585, but removed them
2550 again in r63600 because WebKitTestRunner required getopt, which
2551 doesn't exist in WebKitAuxiliaryLibrary. r63700 and r63788 removed the
2552 use of getopt in WebKitTestRunner, so we can now add it to WebKit.sln
2553 (which has replaced WebKit2.sln).
2555 Fixes <http://webkit.org/b/42711> WebKit.sln should build
2558 Reviewed by Steve Falkenburg.
2560 * WebKit.vcproj/WebKit.sln: Added the following projects to the end of
2561 the build order (in first-built to last-built order):
2562 InjectedBundleGenerated, InjectedBundle, WebKitTestRunner. Also
2563 removed an unnecessary dependency from testapi on WebKit2WebProcess.
2565 2010-07-19 Daniel Bates <dbates@rim.com>
2567 Reviewed by Adam Roben.
2569 [Win] Implement LayoutTestController::markerTextForListItem()
2570 https://bugs.webkit.org/show_bug.cgi?id=37930
2572 Implements support for markerTextForListItem in the Windows port.
2574 * DOMCoreClasses.cpp:
2575 (DOMElement::markerTextForListItem): Added.
2577 * Interfaces/DOMPrivate.idl: Added declaration for markerTextForListItem().
2578 * Interfaces/IWebViewPrivate.idl: Added declaration for elementFromJS().
2579 * Interfaces/WebKit.idl: Touch it to force a rebuild (and for good luck :-)).
2581 (WebView::elementFromJS): Added.
2584 2010-07-16 Zhe Su <suzhe@chromium.org>
2586 Reviewed by Darin Adler.
2588 REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
2589 https://bugs.webkit.org/show_bug.cgi?id=42253
2591 Dummy implementation of EditorClient::willSetInputMethodState.
2593 * WebCoreSupport/WebEditorClient.cpp:
2594 (WebEditorClient::willSetInputMethodState):
2595 * WebCoreSupport/WebEditorClient.h:
2597 2010-07-16 Mikhail Naganov <mnaganov@chromium.org>
2599 Reviewed by Pavel Feldman.
2601 Make JS memory stats available via 'Performance' object (Web Timing).
2602 This statistics is populated only if 'WebKitMemoryInfoEnabled'
2605 'console.memory' is kept until Web Timing object becomes visible by
2606 default (currently it is hidden under compile-time flag). These stats
2607 are guarded with the same preference.
2609 https://bugs.webkit.org/show_bug.cgi?id=41617
2611 * Interfaces/IWebPreferencesPrivate.idl:
2612 * WebPreferenceKeysPrivate.h:
2613 * WebPreferences.cpp:
2614 (WebPreferences::initializeDefaultSettings):
2615 (WebPreferences::memoryInfoEnabled):
2616 (WebPreferences::setMemoryInfoEnabled):
2619 (WebView::notifyPreferencesChanged):
2621 2010-07-14 Brent Fulgham <bfulgham@webkit.org>
2623 Reviewed by Steve Falkenburg.
2625 Patch for https://bugs.webkit.org/show_bug.cgi?id=42299
2626 Correct WinCairo build for new WebKit2 project structure.
2628 * WebKit.vcproj/WebKit.sln:
2630 2010-07-14 Sam Weinig <sam@webkit.org>
2632 Reviewed by Darin Adler.
2634 Patch for https://bugs.webkit.org/show_bug.cgi?id=42232
2635 Make changing Cursors work in WebKit2.
2637 * WebCoreSupport/WebChromeClient.cpp:
2638 (WebChromeClient::setCursor):
2639 We now need to grab the native cursor out of the WebCore cursor.
2641 (WebChromeClient::setLastSetCursorToCurrentCursor):
2642 Sets the WebView's "last set cursor" to be the current cursor so that
2643 the cursor is set correctly for plugins.
2644 * WebCoreSupport/WebChromeClient.h:
2647 (WebView::WebViewWndProc):
2649 (WebView::setLastCursor):
2650 Change the "last set cursor" to be stored as a member instead of a global.
2652 2010-07-13 Steve Falkenburg <sfalken@apple.com>
2655 Make WebKit.sln build WebKit.dll as it used to in the past.
2656 (sln is updated to include necessary projects)
2658 * WebKit.vcproj/WebKit.sln:
2660 2010-07-13 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
2664 * Interfaces/WebKit.idl: Touched to force a build
2666 2010-07-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
2668 Reviewed by Darin Adler.
2670 Prevent assertion/duplicate loads for non-deferred subtitute-data loads
2672 https://bugs.webkit.org/show_bug.cgi?id=30879
2674 MainResourceLoader uses the member m_initialRequest to store requests for future
2675 deferred loads. When doing the actual load in handleDataLoadNow(), we therefore
2676 have to clear this request so that subsequent entries into the loader will not
2677 start yet another load.
2679 This can happen as a result of a PageGroupLoadDeferrer going out of scope when
2680 returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false),
2681 but only in the case of using both substitute-data and non-deferred main resource
2682 load together. That's why two new DRT functions were added:
2684 * queueLoadHTMLString()
2685 * setDeferMainResourceLoad()
2687 The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac
2688 and Win the hook uses new SPI in WebDataSource. For Qt a new static member was
2689 added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt.
2691 * Interfaces/IWebDataSource.idl:
2692 * WebDataSource.cpp:
2693 (WebDataSource::setDeferMainResourceDataLoad):
2696 2010-07-12 Steve Falkenburg <sfalken@apple.com>
2698 Reviewed by Alice Liu.
2700 <rdar://problem/8113038> WebKit1 and WebKit2 should build as a single DLL
2701 https://bugs.webkit.org/show_bug.cgi?id=40921
2703 Pre-WebKit2 WebKit now builds into a static library named WebKitLib.lib.
2704 WebKit.dll now links in WebCore.lib, WebKitLib.lib and WebKit2 code.
2706 This is a first step. We'll likely want to migrate the remainder of
2707 the non-deprecated WebKit code (strings, DLLMain, resources) into WebKit2.
2709 * WebKit.vcproj/WebKit.def: Removed.
2710 * WebKit.vcproj/WebKit.make: Don't fail if WebKit doesn't produce a DLL.
2711 * WebKit.vcproj/WebKit.vcproj: Build WebKit as a static lib.
2712 Renamed project name to WebKitLib to avoid confusion and naming conflicts.
2713 Generate intermediate pdb file for debuggability of static lib.
2714 Removed DLL-related options.
2715 * WebKit.vcproj/deleteButton.png: Removed.
2716 * WebKit.vcproj/deleteButtonPressed.png: Removed.
2717 * WebKit.vcproj/fsVideoAudioVolumeHigh.png: Removed.
2718 * WebKit.vcproj/fsVideoAudioVolumeLow.png: Removed.
2719 * WebKit.vcproj/fsVideoExitFullscreen.png: Removed.
2720 * WebKit.vcproj/fsVideoPause.png: Removed.
2721 * WebKit.vcproj/fsVideoPlay.png: Removed.
2722 * WebKit.vcproj/missingImage.png: Removed.
2723 * WebKit.vcproj/nullplugin.png: Removed.
2724 * WebKit.vcproj/panEastCursor.png: Removed.
2725 * WebKit.vcproj/panIcon.png: Removed.
2726 * WebKit.vcproj/panNorthCursor.png: Removed.
2727 * WebKit.vcproj/panNorthEastCursor.png: Removed.
2728 * WebKit.vcproj/panNorthWestCursor.png: Removed.
2729 * WebKit.vcproj/panSouthCursor.png: Removed.
2730 * WebKit.vcproj/panSouthEastCursor.png: Removed.
2731 * WebKit.vcproj/panSouthWestCursor.png: Removed.
2732 * WebKit.vcproj/panWestCursor.png: Removed.
2733 * WebKit.vcproj/searchCancel.png: Removed.
2734 * WebKit.vcproj/searchCancelPressed.png: Removed.
2735 * WebKit.vcproj/searchMagnifier.png: Removed.
2736 * WebKit.vcproj/searchMagnifierResults.png: Removed.
2737 * WebKit.vcproj/textAreaResizeCorner.png: Removed.
2738 * WebKit.vcproj/verticalTextCursor.png: Removed.
2739 * WebKit.vcproj/zoomInCursor.png: Removed.
2740 * WebKit.vcproj/zoomOutCursor.png: Removed.
2742 2010-07-08 Aaron Boodman <aa@chromium.org>
2744 Reviewed by Timothy Hatcher.
2746 Add the ability for user scripts and user styles to affect just the top frame.
2748 https://bugs.webkit.org/show_bug.cgi?id=41529
2751 (WebView::addUserScriptToGroup):
2752 (WebView::addUserStyleSheetToGroup):
2754 2010-07-08 Adele Peterson <adele@apple.com>
2756 Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
2758 Fix for https://bugs.webkit.org/show_bug.cgi?id=41721
2759 <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
2761 Implement shouldMissingPluginMessageBeButton.
2763 * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::shouldMissingPluginMessageBeButton):
2764 * WebCoreSupport/WebChromeClient.h:
2766 2010-07-07 Anders Carlsson <andersca@apple.com>
2768 Reviewed by Simon Fraser.
2770 Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
2771 https://bugs.webkit.org/show_bug.cgi?id=41781
2773 * WebKit.vcproj/WebKit.sln:
2775 2010-07-07 Sam Weinig <sam@webkit.org>
2777 Reviewed by Anders Carlsson.
2779 Patch for https://bugs.webkit.org/show_bug.cgi?id=41772
2780 Add basic piping for BackForwardControllerClient.
2783 (WebView::initWithFrame):
2785 2010-07-07 Adam Roben <aroben@apple.com>
2789 * Interfaces/WebKit.idl: Touched to force a build.
2791 2010-07-06 Steve Falkenburg <sfalken@apple.com>
2793 Reviewed by Simon Fraser.
2795 Expose URL matching from WebUserContentURLPattern
2796 https://bugs.webkit.org/show_bug.cgi?id=41726
2797 <rdar://problem/7910144>
2799 We previously had a way to construct WebUserContentURLPattern
2800 instances via WebKit, but no way for callers to perform matching.
2801 This patch adds the matchesURL functionality to allow for this.
2803 * Interfaces/IWebUserContentURLPattern.idl: Added matchesURL.
2804 * Interfaces/IWebView.idl: Touch to force a build.
2805 * WebUserContentURLPattern.cpp:
2806 (WebUserContentURLPattern::matchesURL): Added. Calls through to WebCore::UserContentURLPattern::matches.
2807 * WebUserContentURLPattern.h: Added matchesURL.
2809 2010-07-03 Jon Honeycutt <jhoneycutt@apple.com>
2811 The missing plug-in indicator should be clickable
2813 https://bugs.webkit.org/show_bug.cgi?id=41550
2814 <rdar://problem/8132162>
2816 From an original patch by Kevin Decker.
2818 Reviewed by Darin Adler.
2820 * Interfaces/IWebUIDelegatePrivate.idl:
2821 Added a new delegate interface, and declare a function
2822 didPressMissingPluginButton().
2824 * Interfaces/WebKit.idl:
2825 Touch this file to force interfaces to be rebuilt.
2827 * WebCoreSupport/WebChromeClient.cpp:
2828 (WebChromeClient::missingPluginButtonClicked):
2829 Get the UI delegate, and query it for IWebUIDelegatePrivate3. Call its
2830 didPressMissingPluginButton() function.
2832 * WebCoreSupport/WebChromeClient.h:
2833 Declare an override of missingPluginButtonClicked().
2835 2010-07-03 Erik Arvidsson <arv@chromium.org>
2837 Reviewed by Ojan Vafai.
2839 Fix issue where a contextmenu event was reporting the wrong target
2840 if the context menu was shown due to pressing the context menu key
2844 (WebView::handleContextMenuEvent):
2846 2010-07-01 Steve Falkenburg <sfalken@apple.com>
2848 Reviewed by Adele Peterson.
2850 Provide a WebView preference to disable DNS prefetching on Windows
2851 https://bugs.webkit.org/show_bug.cgi?id=41504
2852 <rdar://problem/8151939>
2854 * Interfaces/IWebPreferencesPrivate.idl: Added isDNSPrefetchingEnabled, setDNSPrefetchingEnabled.
2855 * Interfaces/WebKit.idl: Touched to force IDL build.
2856 * WebPreferenceKeysPrivate.h: Added WebKitDNSPrefetchingEnabledPreferenceKey.
2857 * WebPreferences.cpp:
2858 (WebPreferences::initializeDefaultSettings): Default prefetch to true.
2859 (WebPreferences::setDNSPrefetchingEnabled): Added.
2860 (WebPreferences::isDNSPrefetchingEnabled): Added.
2861 * WebPreferences.h: Added isDNSPrefetchingEnabled, setDNSPrefetchingEnabled.
2863 (WebView::notifyPreferencesChanged): Propagate prefetch pref into settings.
2865 2010-06-21 Nate Chapin <japhet@chromium.org>
2867 Unreviewed, Windows build fix.
2869 Update WebFrame to use FrameLoaderStateMachine in
2873 (WebFrame::firstLayoutDone):
2875 2010-06-15 Dumitru Daniliuc <dumi@chromium.org>
2877 Reviewed by Adam Barth.
2879 Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase.
2880 https://bugs.webkit.org/show_bug.cgi?id=39041
2883 (WebView::notifyPreferencesChanged):
2885 2010-06-16 Adam Roben <aroben@apple.com>
2887 Add a "forPrinting" boolean parameter to
2888 IWebFramePrivate::renderTreeAsExternalRepresentation
2890 Fixes <http://webkit.org/b/40727> Respect
2891 LayoutTestController::isPrinting on Windows.
2893 Reviewed by Dan Bernstein.
2895 * Interfaces/IWebFramePrivate.idl: Renamed the current
2896 renderTreeAsExternalRepresentation to unused1, and added a new version
2897 that takes a boolean "forPrinting" parameter.
2899 * Interfaces/WebKit.idl: Touched to force a build.
2902 (WebFrame::renderTreeAsExternalRepresentation): Added a boolean
2903 "forPrinting" parameter, and used it to tell externalRepresentation
2904 what kind of behavior to use.
2906 * WebFrame.h: Renamed the old renderTreeAsExternalRepresentation and
2909 2010-06-15 Darin Adler <darin@apple.com>
2911 Reviewed by Adam Barth.
2913 Move functions out of Frame class that were marked "move to Chrome"
2914 https://bugs.webkit.org/show_bug.cgi?id=39636
2917 (WebView::shouldClose): Call shouldClose on FrameLoader instead of
2918 going through Frame.
2920 2010-06-14 Adam Roben <aroben@apple.com>
2922 Add WebKitLauncherWin to WebKit.sln
2924 Fixes <http://webkit.org/b/40583>.
2926 Reviewed by Darin Adler.
2928 * WebKit.vcproj/WebKit.sln: Added WebKitLauncherWin.vcproj. It depends
2929 on WebKitAPITest, so is the last project to build. (Also removed
2930 QTMovieWin's direct dependency on JavaScriptCore, since it already has
2931 an indirect dependency on it.)
2933 2010-06-14 Chang Shu <chang.shu@nokia.com>
2935 Reviewed by Kenneth Rohde Christiansen.
2937 [win] Make windows compile after API changes.
2939 https://bugs.webkit.org/show_bug.cgi?id=40434
2941 * WebKitGraphics.cpp:
2944 2010-06-14 Ilya Tikhonovsky <loislo@chromium.org>
2946 Reviewed by Pavel Feldman.
2948 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
2949 data from inspected page to WebInspector as JSON string via http. The native
2950 serialization to JSON string is supported by InspectorValue's classes. This patch
2951 has the implementation of sendMessageToFrontend function. WebKit version of it still
2952 uses ScriptFunctionCall and will be switched to another transport a little bit later.
2953 https://bugs.webkit.org/show_bug.cgi?id=40134
2955 * WebCoreSupport/WebInspectorClient.cpp:
2956 (WebInspectorClient::WebInspectorClient):
2957 (WebInspectorClient::~WebInspectorClient):
2958 (WebInspectorClient::openInspectorFrontend):
2959 * WebCoreSupport/WebInspectorClient.h:
2961 2010-06-10 Eric Seidel <eric@webkit.org>
2963 Reviewed by Adam Barth.
2965 Reduce FrameView.h includes to speed up build times
2966 https://bugs.webkit.org/show_bug.cgi?id=40408
2968 Another fix for Windows.
2972 2010-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
2974 Unreviewed, rolling out r60889.
2975 http://trac.webkit.org/changeset/60889
2976 https://bugs.webkit.org/show_bug.cgi?id=40365
2978 gtk bot has some kind of memory corruption (Requested by
2981 * WebCoreSupport/WebInspectorClient.cpp:
2982 (WebInspectorClient::WebInspectorClient):
2983 (WebInspectorClient::~WebInspectorClient):
2984 (WebInspectorClient::openInspectorFrontend):
2985 * WebCoreSupport/WebInspectorClient.h:
2986 (WebInspectorClient::frontendClosing):
2988 2010-06-07 Ilya Tikhonovsky <loislo@chromium.org>
2990 Reviewed by Pavel Feldman.
2992 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
2993 data from inspected page to WebInspector as JSON string via http. The native
2994 serialization to JSON string is supported by InspectorValue's classes. This patch
2995 has the implementation of sendMessageToFrontend function. WebKit version of it still
2996 uses ScriptFunctionCall and will be switched to another transport a little bit later.
2997 https://bugs.webkit.org/show_bug.cgi?id=40134
2999 * WebCoreSupport/WebInspectorClient.cpp:
3000 (WebInspectorClient::WebInspectorClient):
3001 (WebInspectorClient::~WebInspectorClient):
3002 (WebInspectorClient::openInspectorFrontend):
3003 * WebCoreSupport/WebInspectorClient.h:
3005 2010-06-08 Antonio Gomes <tonikitoo@webkit.org>
3007 Reviewed by Ojan Vafai and Darin Adler.
3009 Refactor platform dependent editing behavior code out of Settings
3010 https://bugs.webkit.org/show_bug.cgi?id=39854
3012 EditingBehavior enum was renamed to EditingBehaviorTypes and moved out from Settings.h to
3013 EditingBehaviorTypes.h . Call sites in WebKit/ adjusted accordingly.
3016 (WebView::notifyPreferencesChanged):
3018 2010-06-04 Alice Liu <alice.liu@apple.com>
3020 Reviewed by Jon Honeycutt.
3022 WebFrame::paintDocumentRectToContextAtPoint doesn't paint scrollbars
3023 https://bugs.webkit.org/show_bug.cgi?id=40034
3024 <rdar://problem/7799848>
3027 (WebFrame::paintScrollViewRectToContextAtPoint): Renamed from paintDocumentRectToContextAtPoint.
3028 Call paint() instead of paintContents(). Also move the dirtyRect to counteract the moving that happens in paint().
3030 Just renaming changes:
3031 * Interfaces/IWebFramePrivate.idl:
3032 * Interfaces/IWebViewPrivate.idl:
3035 (WebView::paintScrollViewRectToContextAtPoint):
3038 * Interfaces/WebKit.idl: Touched for rebuild.
3040 2010-05-30 Daniel Bates <dbates@rim.com>
3042 Unreviewed, attempt to fix the build after http://trac.webkit.org/changeset/60418.
3045 (WebFrame::elementWithName):
3046 (WebFrame::controlsInForm):
3048 2010-05-22 Jer Noble <jer.noble@apple.com>
3050 Reviewed by Adam Roben.
3052 Full screen doesn't work for video elements
3053 https://bugs.webkit.org/show_bug.cgi?id=39557
3054 rdar://problem/8011813
3056 Modified FullscreenVideoController to work with MediaPlayerPrivateFullscreenWindow. The FullscreenVideoController
3057 is now MediaPlayerPrivate agnostic..
3059 * FullscreenVideoController.cpp:
3060 (FullscreenVideoController::LayoutClient::LayoutClient): New helper class which implements WKCACFLayerLayoutClient.
3061 (FullscreenVideoController::LayoutClient::layoutSublayersOfLayer):
3062 (FullscreenVideoController::FullscreenVideoController):
3063 (FullscreenVideoController::~FullscreenVideoController):
3064 (FullscreenVideoController::enterFullscreen):
3065 (FullscreenVideoController::exitFullscreen):
3066 (FullscreenVideoController::fullscreenClientWndProc): Handle WM_KEYDOWN.
3067 (FullscreenVideoController::createHUDWindow):
3068 (FullscreenVideoController::hudWndProc): Handle WM_KEYDOWN.
3069 (FullscreenVideoController::onChar):
3070 (FullscreenVideoController::onKeyDown): New function: handles the VK_ESCAPE case more reliably than WM_CHAR.
3071 * FullscreenVideoController.h:
3073 (WebView::viewWindow): Added a simple viewWindow() accessor.
3075 2010-05-25 Brady Eidson <beidson@apple.com>
3077 Reviewed by Darin Adler.
3079 Database origins aren't populated at launch (missing db in prefs sheet, possible other symptoms)
3080 <rdar://problem/8013233> and https://bugs.webkit.org/show_bug.cgi?id=39486
3082 * WebDatabaseManager.cpp:
3083 (WebKitInitializeWebDatabasesIfNecessary): Call initializeTracker() instead of trying to set the path on
3084 an already created tracker that already has its origins populated.
3085 * WebDatabaseManager.h:
3088 (WebView::initWithFrame): Call a renamed method instead.
3090 2010-05-25 Ada Chan <adachan@apple.com>
3092 Reviewed by Steve Falkenburg.
3094 https://bugs.webkit.org/show_bug.cgi?id=39651
3096 Make m_closeWindowTimer a SuspendableTimer, so it is properly suspended
3097 when page loading is deferred.
3100 (WebView::WebView): m_closeWindowTimer is now a pointer to a SuspendableTimer.
3101 (WindowCloseTimer::create):
3102 (WindowCloseTimer::WindowCloseTimer):
3103 (WindowCloseTimer::contextDestroyed): Make sure we delete the WindowCloseTimer in the end.
3104 (WindowCloseTimer::fired):
3105 (WebView::closeWindowSoon):
3106 (WebView::closeWindowTimerFired):
3107 (WebView::notifyPreferencesChanged): Can just check for the existence m_closeWindowTimer, since
3108 we only create it when we need to start the timer.
3111 2010-05-24 Darin Adler <darin@apple.com>
3113 Reviewed by Eric Seidel.
3115 Move view-related functions from Frame to FrameView
3116 https://bugs.webkit.org/show_bug.cgi?id=39366
3119 (WebFrame::setTextSizeMultiplier): Call function on FrameView.
3121 (WebView::setZoomMultiplier): Ditto.
3123 2010-05-24 Anders Carlsson <andersca@apple.com>
3125 Yet another Windows build fix.
3128 (WebView::canShowMIMEType):
3129 Use the right capitalizatinon of 'MIME' (which also happens to be incorrect according to our guidelines).
3131 2010-05-24 Anders Carlsson <andersca@apple.com>
3133 Another Windows build fix.
3136 Don't include PlugInInfoStore.h, instead include PluginData.h
3138 2010-05-24 Anders Carlsson <andersca@apple.com>
3143 (WebView::canShowMIMEType):
3145 2010-05-21 Steve Block <steveblock@google.com>
3147 Reviewed by Jeremy Orlow.
3149 Add DeviceOrientation and DeviceOrientationClient
3150 https://bugs.webkit.org/show_bug.cgi?id=39479
3153 (WebView::initWithFrame):
3155 2010-05-20 Simon Fraser <simon.fraser@apple.com>
3157 Build fix, no review.
3159 Fix the non-accelerated-compositing Windows build with some
3160 #if USE(ACCELERATED_COMPOSITING) loving.
3165 2010-05-20 Simon Fraser <simon.fraser@apple.com>
3167 Reviewed by Adam Roben.
3169 Avoid flushing CA layers when a layout is pending
3170 https://bugs.webkit.org/show_bug.cgi?id=39463
3172 <rdar://problem/7999463>
3174 Avoid rendering the compositing layers to the screen if there's a layout pending,
3175 since the layer tree not in a state that should be presented to the user.
3177 This fixes flashes in some types of content that dynamically add and remove layers.
3179 Have the WebView implement WKCACFLayerRendererClient so that the
3180 WKCACFLayerRenderer can ask whether it's a good time to render. If the FrameView
3181 has a layout pending, say no.
3185 (WebView::setAcceleratedCompositing):
3186 (WebView::shouldRender):
3188 2010-05-18 Brent Fulgham <bfulgham@webkit.org>
3190 Reviewed by Adam Roben.
3192 [WinCairo] Correct scaling for print preview
3193 https://bugs.webkit.org/show_bug.cgi?id=39329
3195 Cairo does not properly deal with Windows HDCs that have been
3196 scaled using MM_ANISOTROPIC mapping mode, and a WindowExt and
3197 ViewportExt setting.
3198 (see http://bugs.freedesktop.org/show_bug.cgi?id=28161)
3200 Instead, reset the HDC's WorldTransform to be unscaled, then
3201 scale the cairo context to the desired scaling, and perform
3202 the drawing operation.
3205 (WebFrame::drawHeader): Use pre-positioned context to simplify
3207 (WebFrame::drawFooter): Use pre-positioned context to simplify
3209 (WebFrame::spoolPage): Revise scaling logic to turn off HDC
3210 scaling, and scale using only Cairo. Revert scaling at end
3211 so that user-defined GDI-based routines (e.g., header/footer)
3212 will draw in the right position.
3213 (WebFrame::spoolPages): Identify print preview case, and
3214 retrieve scaling factors from preview context. Set the
3215 Cairo context to use these factors during the spoolPage
3218 2010-05-20 Martin Robinson <mrobinson@igalia.com>
3222 Touch WebKit.idl to ensure that interfaces rebuild.
3224 * Interfaces/WebKit.idl: Touched.
3226 2010-05-20 Martin Robinson <mrobinson@igalia.com>
3228 Reviewed by Adam Roben.
3230 Fix the Windows build and move new IDL declarations to the bottom of the file.
3232 * Interfaces/IWebPreferences.idl: Move new API to the bottom of the IDL file to prevent vtable mismatch.
3233 * WebPreferences.cpp:
3234 (WebPreferences::setEditingBehavior): Change the type of the parameter to setEditingBehavior to the proper type.
3236 2010-05-20 Martin Robinson <mrobinson@igalia.com>
3240 Fix the Windows build.
3243 (WebView::notifyPreferencesChanged): Change behavior to 'editingBehavior'.
3245 2010-05-20 Martin Robinson <mrobinson@webkit.org>
3247 Reviewed by Ojan Vafai.
3249 Expose the editing behavior setting in DRT to test all editing code paths
3250 https://bugs.webkit.org/show_bug.cgi?id=38603
3252 Expose the EditingBehavior setting in the Windows API.
3254 * Interfaces/IWebPreferences.idl: Add the API point for setting the editing behavior.
3255 * WebPreferenceKeysPrivate.h: Add a key for the editing behavior setting.
3256 * WebPreferences.cpp:
3257 (WebPreferences::editingBehavior): Added.
3258 (WebPreferences::setEditingBehavior): Added.
3259 * WebPreferences.h: Add method declarations.
3261 (WebView::notifyPreferencesChanged): Update the WebCore setting based on the WebPreferences setting.
3263 2010-05-20 Chris Jerdonek <cjerdonek@webkit.org>
3265 Reviewed by Eric Seidel.
3267 Modified FrameLoader::urlSelected() to accept a KURL instead of a
3270 https://bugs.webkit.org/show_bug.cgi?id=39320
3272 Since ResourceRequest has non-explicit single-parameter constructors for
3273 String and KURL, urlSelected() previously accepted any of String, KURL,
3274 and ResourceRequest. This revision changes urlSelected() to accept only
3275 a KURL to make the API tighter and easier to refactor.
3277 * WebCoreSupport/WebContextMenuClient.cpp:
3278 (WebContextMenuClient::searchWithGoogle):
3279 - Updated the call to urlSelected().
3281 2010-05-13 Brian Weinstein <bweinstein@apple.com>
3283 Reviewed by Tim Hatcher.
3285 <rdar://problem/7982652>
3287 Allow reporting exceptions that occur when using JavaScriptCore APIs to the Web Inspector.
3289 * Interfaces/IWebViewPrivate.idl: Add a reportException function off of IWebViewPrivate.
3290 * Interfaces/WebKit.idl: Touch WebKit.idl to make sure Interfaces rebuild.
3292 (WebView::reportException): Make sure the function was called with a context from a WebView, and call
3293 WebCore::reportException.
3296 2010-05-12 Jer Noble <jer.noble@apple.com>
3298 Reviewed by Darin Adler.
3300 Bug 38689: #34005 will break fullscreen video playback
3301 https://bugs.webkit.org/show_bug.cgi?id=38689
3303 Use the new definition of PlatformMedia to check the actual type
3304 returned by MediaPlayer.
3306 * FullscreenVideoController.cpp:
3307 (FullscreenVideoController::movie):
3309 2010-05-11 Jer Noble <jer.noble@apple.com>
3313 Fix build error: The QTMovieWin project is dependent on the JavaScriptCore project.
3315 * WebKit.vcproj/WebKit.sln:
3317 2010-05-11 Alice Liu <alice.liu@apple.com>
3319 Rubber-stamped by Gavin Barraclough.
3321 Fix build error when enabling debugging block in WebKit win painting code
3324 (WebView::paintIntoBackingStore):
3326 2010-05-11 Alice Liu <alice.liu@apple.com>
3328 Reviewed by Steve Falkenburg.
3330 https://bugs.webkit.org/show_bug.cgi?id=38937
3331 W7 window preview paints content at the wrong location
3334 (WebFrame::paintDocumentRectToContext): Revert r58895
3335 (WebFrame::paintDocumentRectToContextAtPoint): Added
3337 * Interfaces/IWebFramePrivate.idl: Added paintDocumentRectToContextAtPoint
3338 * Interfaces/IWebViewPrivate.idl: ditto
3339 * Interfaces/WebKit.idl: touch to rebuild
3341 * WebView.cpp: ditto
3342 (WebView::paintDocumentRectToContextAtPoint): ditto
3345 2010-05-07 Jer Noble <jer.noble@apple.com>
3347 Reviewed by Adele Peterson.
3349 Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
3350 https://bugs.webkit.org/show_bug.cgi?id=34005
3352 QTMovieWin is now QTMovieGWorld.
3353 * FullscreenVideoController.cpp:
3354 (FullscreenVideoController::movie):
3355 * FullscreenVideoController.h:
3357 2010-05-06 Adam Roben <aroben@apple.com>
3359 Bail out of WebView::paint when there's nothing to paint
3361 Fixes <http://webkit.org/b/38670> <rdar://problem/7947105> REGRESSION
3362 (r58067): Crash in WebView::paint when Web Inspector is docked and
3363 window is resized so small that WebView disappears
3365 When the WebView is 0-sized, ensureBackingStore() bails out without
3366 creating a bitmap, leaving m_backingStoreBitmap null. Before r58067,
3367 m_backingStoreBitmap was an HBITMAP, so we were happily passing along
3368 a null HBITMAP to various Windows APIs. These calls would fail but not
3369 crash. r58067 changed m_backingStoreBitmap to a RefCountedHBITMAP, and
3370 dereferencing a null RefCountedHBITMAP* of course crashes.
3372 Reviewed by Steve Falkenburg.
3375 (WebView::paint): Bail if the rect to paint is empty.
3377 2010-05-06 Steve Falkenburg <sfalken@apple.com>
3379 Reviewed by Adam Roben.
3381 WebFrame::paintDocumentRectToContext paints content at the wrong location
3382 https://bugs.webkit.org/show_bug.cgi?id=38651
3385 (WebFrame::paintDocumentRectToContext):
3387 2010-05-05 Stuart Morgan <stuartmorgan@chromium.org>
3389 Reviewed by Darin Fisher.
3391 Update setFocus for the new boolean argument; no behavioral change.
3393 https://bugs.webkit.org/show_bug.cgi?id=37961
3395 * WebCoreSupport/EmbeddedWidget.cpp:
3396 (EmbeddedWidget::setFocus):
3397 * WebCoreSupport/EmbeddedWidget.h:
3399 2010-05-03 Abhishek Arya <inferno@chromium.org>
3401 Reviewed by Adam Barth.
3403 Add support for controlling clipboard access from javascript.
3404 Clipboard access from javascript is disabled by default.
3405 https://bugs.webkit.org/show_bug.cgi?id=27751
3407 * Interfaces/IWebPreferencesPrivate.idl:
3408 * WebPreferenceKeysPrivate.h:
3409 * WebPreferences.cpp:
3410 (WebPreferences::initializeDefaultSettings):
3411 (WebPreferences::javaScriptCanAccessClipboard):
3412 (WebPreferences::setJavaScriptCanAccessClipboard):
3415 (WebView::notifyPreferencesChanged):
3417 2010-05-03 Jens Alfke <snej@chromium.org>
3419 Reviewed by Darin Fisher.
3421 [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
3422 https://bugs.webkit.org/show_bug.cgi?id=38397
3424 No tests (functionality is exposed only through native WebKit API.)
3428 2010-04-30 Jon Honeycutt <jhoneycutt@apple.com>
3430 Caret may fail to blink if a focus handler brings up a modal dialog
3431 https://bugs.webkit.org/show_bug.cgi?id=38372
3433 Reviewed by Darin Adler.
3436 (WebView::handleMouseEvent):
3437 If the message is WM_CANCELMODE, which indicates that we our capturing
3438 of mouse events has been cancelled, tell the EventHandler.
3439 It's possible to re-enter this function if handling a mouse event allows
3440 the message loop to run; moved up the call to setMouseActivated(), so
3441 that if we do re-enter this function, the later mouse event will not be
3442 considered as activating the window.
3443 (WebView::WebViewWndProc):
3444 Handle WM_CANCELMODE by calling handleMouseEvent().
3446 2010-04-29 Anders Carlsson <andersca@apple.com>
3448 Reviewed by Dan Bernstein.
3451 https://bugs.webkit.org/show_bug.cgi?id=20784
3452 move npapi.h to C99 integer types.
3454 * WebKit.vcproj/WebKit.vcproj:
3456 2010-04-28 Beth Dakin <bdakin@apple.com>
3458 Reviewed by Darin Adler.
3460 Fix for <rdar://problem/7474349>
3462 Add a synchronous display mechanism for WKCACFLayerRenderer.
3464 * Interfaces/IWebViewPrivate.idl:
3465 * Interfaces/WebKit.idl:
3468 (WebView::updateRootLayerContents):
3469 (WebView::nextDisplayIsSynchronous):
3472 2010-04-28 Steve Falkenburg <sfalken@apple.com>
3474 Reviewed by Maciej Stachowiak.
3476 WebView drawing code may access null backing store dirty region
3477 https://bugs.webkit.org/show_bug.cgi?id=38245
3478 <rdar://problem/7916101> REGRESSION (r58067): All loaded pages fail to display after running iBench HTML test (intermittent)
3481 (WebView::updateBackingStore): Add null check for m_backingStoreDirtyRegion.
3483 2010-04-27 Jon Honeycutt <jhoneycutt@apple.com>
3485 <rdar://problem/7911140> Hitting the "delete" key goes back twice
3487 Reviewed by Maciej Stachowiak.
3491 Return true if we navigated back or forward from the key event to
3492 prevent the event from being propagated further.
3494 2010-04-25 Sam Weinig <sam@webkit.org>
3496 Reviewed by Maciej Stachowiak.
3498 Fix for https://bugs.webkit.org/show_bug.cgi?id=38097
3499 Disentangle initializing the main thread from initializing threading
3501 * WebKitClassFactory.cpp:
3502 (WebKitClassFactory::WebKitClassFactory): Add call to initializeMainThread.
3504 (WebView::WebView): Ditto.
3506 2010-04-25 Yury Semikhatsky <yurys@chromium.org>
3508 Reviewed by Pavel Feldman.
3510 Web Inspector: inspector client shouldn't check if it can be opened
3511 docked if it is already in that state.
3513 https://bugs.webkit.org/show_bug.cgi?id=37946
3515 * WebCoreSupport/WebInspectorClient.cpp:
3516 (WebInspectorFrontendClient::WebInspectorFrontendClient):
3517 (WebInspectorFrontendClient::showWindowWithoutNotifications):
3518 * WebCoreSupport/WebInspectorClient.h:
3520 2010-04-24 Steve Falkenburg <sfalken@apple.com>
3522 Reviewed by Sam Weinig.
3524 Typo in Geolocation code causes crashes when updates are stopped
3525 https://bugs.webkit.org/show_bug.cgi?id=38089
3526 <rdar://problem/7904104> Crash closing geolocation tab after allowing to use geolocation
3528 * WebCoreSupport/WebGeolocationControllerClient.cpp:
3529 (WebGeolocationControllerClient::stopUpdating): Call unregister instead of register.
3531 2010-04-23 Andy Estes <aestes@apple.com>
3533 Rubber stamped by Steve Falkenburg.
3535 Roll out http://trac.webkit.org/changeset/55385.
3537 <rdar://problem/7884444>
3539 * Interfaces/IWebUIDelegatePrivate.idl:
3540 * Interfaces/WebKit.idl:
3541 * WebCoreSupport/WebFrameLoaderClient.cpp:
3542 (WebFrameLoaderClient::createPlugin):
3544 2010-04-22 Dave Moore <davemoore@chromium.org>
3546 Reviewed by Dimitri Glazkov.
3548 Added notification when the favicons for a page are changed
3550 The Document object will notify the frame loader, which will
3551 notify the client. Implementations of FrameLoaderClient will
3552 have to add one method; dispatchDidChangeIcons().
3554 https://bugs.webkit.org/show_bug.cgi?id=33812
3556 * Interfaces/IWebFrameLoadDelegatePrivate2.idl:
3557 * WebCoreSupport/WebFrameLoaderClient.cpp:
3558 (WebFrameLoaderClient::dispatchDidChangeIcons):
3559 * WebCoreSupport/WebFrameLoaderClient.h:
3561 (WebFrame::didChangeIcons):
3564 2010-04-22 Adam Barth <abarth@webkit.org>
3566 Unreviewed, rolling out r58069.
3567 http://trac.webkit.org/changeset/58069
3568 https://bugs.webkit.org/show_bug.cgi?id=27751
3570 Broke compile on Windows.
3572 * Interfaces/IWebPreferencesPrivate.idl:
3573 * WebPreferenceKeysPrivate.h:
3574 * WebPreferences.cpp:
3575 (WebPreferences::initializeDefaultSettings):
3578 (WebView::notifyPreferencesChanged):
3580 2010-04-22 Abhishek Arya <inferno@chromium.org>
3582 Reviewed by Adam Barth.
3584 Add support for controlling clipboard access from javascript.
3585 Clipboard access from javascript is disabled by default.
3586 https://bugs.webkit.org/show_bug.cgi?id=27751
3588 * Interfaces/IWebPreferencesPrivate.idl:
3589 * WebPreferenceKeysPrivate.h:
3590 * WebPreferences.cpp:
3591 (WebPreferences::initializeDefaultSettings):
3592 (WebPreferences::javaScriptCanAccessClipboard):
3593 (WebPreferences::setJavaScriptCanAccessClipboard):
3596 (WebView::notifyPreferencesChanged):
3598 2010-04-21 Andy Estes <aestes@apple.com>
3600 Reviewed by Maciej Stachowiak.
3602 Reference count WebView's backing store bitmap to prevent
3603 deleteBackingStore() from freeing the bitmap while it is still being
3604 referenced by Core Animation.
3606 https://bugs.webkit.org/show_bug.cgi?id=37954
3609 (WebView::ensureBackingStore):
3610 (WebView::addToDirtyRegion):
3611 (WebView::scrollBackingStore):
3612 (WebView::updateBackingStore):
3614 (WebView::backingStore):
3615 (releaseBackingStoreCallback): deref m_backingStoreBitmap once Core
3616 Animation has dropeed its reference to the memory.
3617 (WebView::updateRootLayerContents): ref m_backingStoreBitmap before
3618 passing the memory to Core Animation to prevent deleteBackingStore()
3619 from freeing it while it is still referenced by CA.
3620 * WebView.h: Make m_backingStoreBitmap a RefCountedGDIHandle<HBITMAP>,
3621 and make m_backingStoreDirtyRegion a RefCountedGDIHandle<HRGN>.
3623 2010-04-20 Adam Barth <abarth@webkit.org>
3625 Reviewed by Eric Seidel.
3627 Factor DocumentWriter out of FrameLoader
3628 https://bugs.webkit.org/show_bug.cgi?id=37175
3630 Update these callsites because the method moved to DocumentWriter.
3632 * WebCoreSupport/WebFrameLoaderClient.cpp:
3633 (WebFrameLoaderClient::receivedData):
3635 2010-04-20 Kent Tamura <tkent@chromium.org>
3637 Reviewed by Darin Adler.
3639 Change a parameter type of chooseIconForFiles()
3640 https://bugs.webkit.org/show_bug.cgi?id=37504
3642 * WebCoreSupport/WebChromeClient.cpp:
3643 (WebChromeClient::chooseIconForFiles):
3644 * WebCoreSupport/WebChromeClient.h:
3646 2010-04-16 Gavin Barraclough <barraclough@apple.com>
3648 Reviewed by NOBODY (Windows build fix).
3651 (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
3653 (WebView::stringByEvaluatingJavaScriptFromString):
3655 2010-04-16 Adam Roben <aroben@apple.com>
3657 Make it possible for clients to instantiate a WebUserContentURLPattern
3659 Reviewed by Tim Hatcher.
3661 * ForEachCoClass.h: Added WebUserContentURLPattern to the FOR_EACH_COCLASS macro, which
3662 lists all our instantiatable classes.
3664 * WebKitClassFactory.cpp: Added a now-required #include.
3666 2010-04-15 Adam Roben <aroben@apple.com>
3668 Expose UserContentURLPattern as WebKit SPI
3670 Fixes <http://webkit.org/b/37354>.
3672 Reviewed by Tim Hatcher.
3674 * Interfaces/IWebUserContentURLPattern.idl: Added.
3676 * Interfaces/WebKit.idl: Added WebUserContentURLPattern.
3678 * WebKit.vcproj/Interfaces.vcproj: Added IWebUserContentURLPattern.
3680 * WebKit.vcproj/WebKit.vcproj: Added WebUserContentURLPattern.
3682 * WebUserContentURLPattern.cpp: Added.
3683 (WebUserContentURLPattern::WebUserContentURLPattern):
3684 (WebUserContentURLPattern::~WebUserContentURLPattern):
3685 (WebUserContentURLPattern::createInstance):
3686 (WebUserContentURLPattern::AddRef):
3687 (WebUserContentURLPattern::Release):
3688 (WebUserContentURLPattern::QueryInterface):
3689 Standard COM implementations.
3691 (WebUserContentURLPattern::parse): Parse the string into a
3692 UserContentURLPattern and store it.
3694 (WebUserContentURLPattern::isValid):
3695 (WebUserContentURLPattern::scheme):
3696 (WebUserContentURLPattern::host):
3697 (WebUserContentURLPattern::matchesSubdomains):
3698 Call through to UserContentURLPattern.
3700 * WebUserContentURLPattern.h: Added.
3702 2010-04-14 Adam Roben <aroben@apple.com>
3704 Expose DOMWrapperWorld::unregisterWorld as WebKit SPI on Windows
3706 Fixes <http://webkit.org/b/37619>.
3708 Reviewed by Steve Falkenburg.
3710 * Interfaces/IWebScriptWorld.idl: Added unregisterWorld.
3712 * Interfaces/WebKit.idl: Touched to force a build.
3714 * WebScriptWorld.cpp:
3715 (WebScriptWorld::unregisterWorld):
3717 Added. Just calls through to DOMWrapperWorld::unregisterWorld.
3719 2010-04-12 Timothy Hatcher <timothy@apple.com>
3721 SecurityOrigin needs a way to remove individual OriginAccessEntries
3722 https://bugs.webkit.org/show_bug.cgi?id=37449
3724 Reviewed by Dave Hyatt.
3726 * Interfaces/IWebViewPrivate.idl:
3728 (WebView::removeOriginAccessWhitelistEntry): Call SecurityOrigin::removeOriginAccessWhitelistEntry.
3729 * WebView.h: Added removeOriginAccessWhitelistEntry.
3731 2010-04-13 Timothy Hatcher <timothy@apple.com>
3733 Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
3734 And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
3736 SecurityOrigin needs a way to remove individual OriginAccessEntries
3737 https://bugs.webkit.org/show_bug.cgi?id=37449
3739 Reviewed by Dave Hyatt.
3741 * Interfaces/IWebViewPrivate.idl:
3743 (WebView::addOriginAccessWhitelistEntry):
3744 (WebView::resetOriginAccessWhitelists):
3747 2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
3749 Unreviewed, rolling out r57468.
3750 http://trac.webkit.org/changeset/57468
3751 https://bugs.webkit.org/show_bug.cgi?id=37433
3753 Broke the world... Must have applied the patch wrong
3754 (Requested by abarth on #webkit).
3756 * WebCoreSupport/WebFrameLoaderClient.cpp:
3757 (WebFrameLoaderClient::receivedData):
3759 2010-04-11 Adam Barth <abarth@webkit.org>
3761 Reviewed by Eric Seidel.
3763 Factor DocumentWriter out of FrameLoader
3764 https://bugs.webkit.org/show_bug.cgi?id=37175
3766 Update these callsites because the method moved to DocumentWriter.
3768 * WebCoreSupport/WebFrameLoaderClient.cpp:
3769 (WebFrameLoaderClient::receivedData):
3771 2010-04-09 Adam Roben <aroben@apple.com>
3773 Windows Debug/Release build fix after r57244
3775 * WebKit.vcproj/WebKit.vcproj: Don't delay-load QuartzCore.dll or
3776 QuartzCoreInterface.dll in any configurations. r57244 made this change
3777 only for Debug_Internal.
3779 2010-04-08 Steve Falkenburg <sfalken@apple.com>
3781 Reviewed by Darin Adler.
3783 WebView::isLoading should null check m_mainFrame
3784 https://bugs.webkit.org/show_bug.cgi?id=37294
3787 (WebView::isLoading):
3789 2010-04-07 Chris Marrin <cmarrin@apple.com>
3791 Reviewed by Steve Falkenburg.
3793 Remove QuartzCoreInterface from the build
3795 No longer needed since QuartzCore.dll is now included in the latest Safari release (4.0.5).
3797 * WebKit.vcproj/WebKit.vcproj:Removed delay load for QuartzCore and QuartzCoreInterface
3799 2010-04-07 Andrey Kosyakov <caseq@chromium.org>
3801 Reviewed by Yury Semikhatsky.
3803 Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
3804 https://bugs.webkit.org/show_bug.cgi?id=36949
3806 * WebCoreSupport/WebFrameLoaderClient.cpp:
3807 * WebCoreSupport/WebFrameLoaderClient.h:
3809 2010-04-05 Peter Nelson <charn.opcode@gmail.com>
3811 Reviewed by Eric Seidel.
3813 Fixed style errors in DOMCoreClasses.h to bring it up to scratch
3814 for https://bugs.webkit.org/show_bug.cgi?id=34979.
3817 (DOMObject::throwException):
3818 (DOMObject::callWebScriptMethod):
3819 (DOMObject::evaluateWebScript):
3820 (DOMObject::removeWebScriptKey):
3821 (DOMObject::stringRepresentation):
3822 (DOMObject::webScriptValueAtIndex):
3823 (DOMObject::setWebScriptValueAtIndex):
3824 (DOMObject::setException):
3825 (DOMNodeList::throwException):
3826 (DOMNodeList::callWebScriptMethod):
3827 (DOMNodeList::evaluateWebScript):
3828 (DOMNodeList::removeWebScriptKey):
3829 (DOMNodeList::stringRepresentation):
3830 (DOMNodeList::webScriptValueAtIndex):
3831 (DOMNodeList::setWebScriptValueAtIndex):
3832 (DOMNodeList::setException):
3833 (DOMDocument::throwException):
3834 (DOMDocument::callWebScriptMethod):
3835 (DOMDocument::evaluateWebScript):
3836 (DOMDocument::removeWebScriptKey):
3837 (DOMDocument::stringRepresentation):
3838 (DOMDocument::webScriptValueAtIndex):
3839 (DOMDocument::setWebScriptValueAtIndex):
3840 (DOMDocument::setException):
3841 (DOMDocument::nodeName):
3842 (DOMDocument::nodeValue):
3843 (DOMDocument::setNodeValue):
3844 (DOMDocument::nodeType):
3845 (DOMDocument::parentNode):
3846 (DOMDocument::childNodes):
3847 (DOMDocument::firstChild):
3848 (DOMDocument::lastChild):
3849 (DOMDocument::previousSibling):
3850 (DOMDocument::nextSibling):
3851 (DOMDocument::attributes):
3852 (DOMDocument::ownerDocument):
3853 (DOMDocument::insertBefore):
3854 (DOMDocument::replaceChild):
3855 (DOMDocument::removeChild):
3856 (DOMDocument::appendChild):
3857 (DOMDocument::hasChildNodes):
3858 (DOMDocument::cloneNode):
3859 (DOMDocument::isSupported):
3860 (DOMDocument::namespaceURI):
3861 (DOMDocument::prefix):
3862 (DOMDocument::setPrefix):
3863 (DOMDocument::localName):
3864 (DOMDocument::hasAttributes):
3865 (DOMDocument::isSameNode):
3866 (DOMDocument::isEqualNode):
3867 (DOMDocument::textContent):
3868 (DOMDocument::setTextContent):
3869 (DOMElement::throwException):
3870 (DOMElement::callWebScriptMethod):
3871 (DOMElement::evaluateWebScript):
3872 (DOMElement::removeWebScriptKey):
3873 (DOMElement::stringRepresentation):
3874 (DOMElement::webScriptValueAtIndex):
3875 (DOMElement::setWebScriptValueAtIndex):
3876 (DOMElement::setException):
3877 (DOMElement::nodeName):
3878 (DOMElement::nodeValue):
3879 (DOMElement::setNodeValue):
3880 (DOMElement::nodeType):
3881 (DOMElement::parentNode):
3882 (DOMElement::childNodes):
3883 (DOMElement::firstChild):
3884 (DOMElement::lastChild):
3885 (DOMElement::previousSibling):
3886 (DOMElement::nextSibling):
3887 (DOMElement::attributes):
3888 (DOMElement::ownerDocument):
3889 (DOMElement::insertBefore):
3890 (DOMElement::replaceChild):
3891 (DOMElement::removeChild):
3892 (DOMElement::appendChild):
3893 (DOMElement::hasChildNodes):
3894 (DOMElement::cloneNode):
3895 (DOMElement::isSupported):
3896 (DOMElement::namespaceURI):
3897 (DOMElement::prefix):
3898 (DOMElement::setPrefix):
3899 (DOMElement::localName):
3900 (DOMElement::hasAttributes):
3901 (DOMElement::isSameNode):
3902 (DOMElement::isEqualNode):
3903 (DOMElement::textContent):
3904 (DOMElement::setTextContent):
3906 2010-04-05 Alexey Proskuryakov <ap@apple.com>
3908 Reviewed by Darin Adler.
3910 https://bugs.webkit.org/show_bug.cgi?id=37111
3911 <rdar://problem/7790327> Draw replacement text when plug-in host crashes
3913 * WebCoreLocalizedStrings.cpp: (WebCore::crashedPluginText): Added a stub string for plug-in
3916 2010-04-02 Rafael Weinstein <rafaelw@chromium.org>
3918 Reviewed by Adam Barth.
3920 Clean up unused calls after changes to checkPermission and requestPermission argument lists.
3922 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
3923 (WebDesktopNotificationsDelegate::requestPermission):
3924 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
3926 2010-04-01 Chris Marrin <cmarrin@apple.com>
3928 Reviewed by Simon Fraser.
3930 Added layerTreeAsText function to DRT (for Mac)
3931 https://bugs.webkit.org/show_bug.cgi?id=36782
3933 This is the WebKit side for Windows. It plumbs the
3934 call from WebCore to DRT.
3936 * Interfaces/IWebFramePrivate.idl:
3937 * WebFrame.cpp:WebKit (Windows) side of plumbing
3938 (WebFrame::layerTreeAsText):
3941 2010-03-31 Marcus Bulach <bulach@chromium.org>
3943 Reviewed by Jeremy Orlow.
3945 Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
3946 https://bugs.webkit.org/show_bug.cgi?id=35031
3948 * WebCoreSupport/WebChromeClient.h:
3949 (WebChromeClient::cancelGeolocationPermissionRequestForFrame):
3951 2010-03-30 Gavin Barraclough <barraclough@apple.com>
3953 Rubber stamped by Sam Weinig.
3955 https://bugs.webkit.org/show_bug.cgi?id=36866
3959 * WebDownloadCFNet.cpp:
3960 * WebDownloadCurl.cpp:
3961 * WebHistoryItem.cpp:
3962 * WebLocalizableStrings.cpp:
3963 * WebMutableURLRequest.cpp:
3964 * WebPreferences.cpp:
3965 (WebPreferences::migrateWebKitPreferencesToCFPreferences):
3968 2010-03-30 Adam Roben <aroben@apple.com>
3972 * Interfaces/WebKit.idl: Touched this to force a build.
3974 2010-03-29 Steve Falkenburg <sfalken@apple.com>
3976 Reviewed by Adele Peterson.
3978 Default value of accelerated compositing should be false for Windows
3979 https://bugs.webkit.org/show_bug.cgi?id=36805
3981 * WebPreferences.cpp:
3982 (WebPreferences::initializeDefaultSettings):
3984 2010-03-29 Rafael Weinstein <rafaelw@chromium.org>
3986 Reviewed by Adam Barth.
3988 Change NotificationPresenter::checkPermission() to take the source frames full KURL,
3989 rather than its SecurityOrigin. This will aid chromium in having more fine grained
3990 permissions to control notification spam.
3992 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
3993 (WebDesktopNotificationsDelegate::checkPermission):
3994 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
3996 2010-03-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
3998 Reviewed by Antti Koivisto.
4000 Change method name due to it dealing with both flattening
4001 of frame sets and inner frames.
4003 * Interfaces/IWebPreferencesPrivate.idl:
4004 * WebPreferenceKeysPrivate.h:
4005 * WebPreferences.cpp:
4006 (WebPreferences::initializeDefaultSettings):
4007 (WebPreferences::isFrameFlatteningEnabled):
4008 (WebPreferences::setFrameFlatteningEnabled):
4011 (WebView::notifyPreferencesChanged):
4013 2010-03-24 Jon Honeycutt <jhoneycutt@apple.com>
4015 <rdar://problem/7780798> Missing plug-ins should be represented by text
4016 only, instead of lego block
4018 https://bugs.webkit.org/show_bug.cgi?id=36583
4020 Reviewed by Dan Bernstein.
4022 * WebCoreSupport/WebFrameLoaderClient.cpp:
4023 (WebFrameLoaderClient::createPlugin):
4024 Return 0 if we failed to initialize the plug-in, which causes the new
4025 "missing plug-in" text to draw.
4027 2010-03-24 Kent Tamura <tkent@chromium.org>
4029 Reviewed by Darin Adler.
4031 Make Icon::createIconForFiles() optional.
4032 https://bugs.webkit.org/show_bug.cgi?id=35072
4034 - Rename iconForFiles() to chooseIconForFiles().
4035 - Call Icon::createIconForFiles() from chooseIconForFiles().
4037 * WebCoreSupport/WebChromeClient.cpp:
4038 (WebChromeClient::chooseIconForFiles):
4039 * WebCoreSupport/WebChromeClient.h:
4041 2010-03-22 Darin Adler <darin@apple.com>
4043 * WebCoreLocalizedStrings.cpp:
4044 (WebCore::missingPluginText): Fixed localization helper text to match the same
4045 string from Mac WebKit.
4047 2010-03-22 Kevin Decker <kdecker@apple.com>
4049 Reviewed by John Sullivan.
4051 https://bugs.webkit.org/show_bug.cgi?id=36328
4053 * WebCoreLocalizedStrings.cpp:
4054 (WebCore::missingPluginText): Added.
4056 2010-03-17 Enrica Casucci <enrica@apple.com>
4058 Reviewed by Darin Adler.
4060 Missing support for showing compositing layers borders and repaint count on Windows.
4061 <rdar://problem/7760736>
4062 <https://bugs.webkit.org/show_bug.cgi?id=36197>
4064 * Interfaces/IWebPreferencesPrivate.idl:
4065 * WebPreferenceKeysPrivate.h:
4066 * WebPreferences.cpp:
4067 (WebPreferences::initializeDefaultSettings):
4068 (WebPreferences::showDebugBorders):
4069 (WebPreferences::setShowDebugBorders):
4070 (WebPreferences::showRepaintCounter):
4071 (WebPreferences::setShowRepaintCounter):
4074 (WebView::notifyPreferencesChanged):
4076 2010-03-16 Yury Semikhatsky <yurys@chromium.org>
4078 Reviewed by Pavel Feldman.
4080 Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
4082 Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
4083 https://bugs.webkit.org/show_bug.cgi?id=35036
4085 * WebCoreSupport/WebInspectorClient.cpp:
4086 (WebInspectorClient::WebInspectorClient):
4087 (WebInspectorClient::~WebInspectorClient):
4088 (WebInspectorClient::openInspectorFrontend):
4089 (WebInspectorClient::highlight):
4090 (WebInspectorClient::hideHighlight):
4091 (WebInspectorClient::updateHighlight):
4092 (WebInspectorFrontendClient::WebInspectorFrontendClient):
4093 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
4094 (WebInspectorFrontendClient::frontendLoaded):
4095 (WebInspectorFrontendClient::localizedStringsURL):
4096 (WebInspectorFrontendClient::hiddenPanels):
4097 (WebInspectorFrontendClient::bringToFront):
4098 (WebInspectorFrontendClient::closeWindow):
4099 (WebInspectorFrontendClient::attachWindow):
4100 (WebInspectorFrontendClient::detachWindow):
4101 (WebInspectorFrontendClient::setAttachedWindowHeight):
4102 (WebInspectorFrontendClient::inspectedURLChanged):
4103 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
4104 (WebInspectorFrontendClient::showWindowWithoutNotifications):
4105 (WebInspectorFrontendClient::destroyInspectorView):
4106 (WebInspectorFrontendClient::updateWindowTitle):
4107 (WebInspectorFrontendClient::onGetMinMaxInfo):
4108 (WebInspectorFrontendClient::onSize):
4109 (WebInspectorFrontendClient::onClose):
4110 (WebInspectorFrontendClient::onSetFocus):
4111 (WebInspectorFrontendClient::onWebViewWindowPosChanging):
4112 (WebInspectorWndProc):
4113 (WebInspectorFrontendClient::windowReceivedMessage):
4114 * WebCoreSupport/WebInspectorClient.h:
4115 (WebInspectorClient::frontendClosing):
4117 (WebInspector::attach):
4118 (WebInspector::detach):
4120 2010-03-14 Dan Bernstein <mitz@apple.com>
4122 Reviewed by Darin Adler.
4124 WebKit part of removing support for legacy versions of Core Graphics
4126 * WebKitClassFactory.cpp:
4127 (WebKitClassFactory::WebKitClassFactory): Removed call to populateFontDatabase().
4128 * WebKitGraphics.cpp:
4130 * WebTextRenderer.cpp:
4131 (WebTextRenderer::registerPrivateFont): Removed call to wkAddFontsAtPath().
4133 2010-03-12 Enrica Casucci <enrica@apple.com>
4135 Fixed broken build on Windows.
4136 Added contditional compilation for accelerated compositing.
4139 (WebView::deleteBackingStore):
4140 (WebView::addToDirtyRegion):
4141 (WebView::updateBackingStore):
4143 2010-03-12 Beth Dakin <bdakin@apple.com>
4145 Reviewed by Simon Fraser.
4147 Fix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen
4148 API naming is inconsistent
4150 <rdar://problem/7729165>
4152 This patch changes all occurrences of "fullScreen" to the more
4153 popular "fullscreen."
4155 * FullscreenVideoController.cpp:
4156 (FullscreenVideoController::onMouseDown):
4157 (FullscreenVideoController::onMouseMove):
4158 (FullscreenVideoController::onMouseUp):
4159 * FullscreenVideoController.h:
4160 (FullscreenVideoController::fullscreenToHUDCoordinates):
4162 2010-03-12 Beth Dakin <bdakin@apple.com>
4164 Reviewed by Adam Roben.
4166 Fix for https://bugs.webkit.org/show_bug.cgi?id=33739 Fullscreen
4167 video HUD stays on top when switching to another window (e.g. via
4170 <rdar://problem/7547574>
4172 The HUD was always on top because it had the WS_EX_TOPMOST style.
4173 So I removed the style and made m_videoWindow the owner of
4174 m_hudWindow. This keeps m_hudWindow on top only when m_videoWindow
4175 is the focused window.
4177 * FullscreenVideoController.cpp:
4178 (FullscreenVideoController::exitFullscreen): ASSERT that movie()->exitFullscreen() also destroyed the hud.
4179 (FullscreenVideoController::createHUDWindow):
4181 2010-03-12 Enrica Casucci <enrica@apple.com>
4183 Reviewed by Simon Fraser.
4185 Content of 3D tests appears at the bottom right corner sometimes.
4186 <rdar://problem/7556244>
4187 <https://bugs.webkit.org/show_bug.cgi?id=36027>
4189 See detailed comments in WebCore/ChangeLog.
4192 (WebView::deleteBackingStore): Reset the dirty flag when deleting the backing store.
4193 (WebView::addToDirtyRegion): Set the dirty flag when adding dirty rectangles to the
4194 backing store dirty region.
4195 (WebView::updateBackingStore): Reset the dirty flag after painting into the backing store.
4196 (WebView::setAcceleratedCompositing): Removed unnecessary call to updateRootLayerContents.
4197 (WebView::updateRootLayerContents): Changed the way we pass parameters to setScrollFrame.
4198 We are passing width and height of the view content together with the offset for the scrolling.
4199 It was confusing to pass it all as a rectangle, when it is not a rectangle.
4201 2010-03-11 Aaron Boodman <aa@ch