e2ccdcea959b565350dc35b875c922395d82a2f3
[WebKit-https.git] / Source / WebKit / qt / ChangeLog
1 2011-04-06  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2
3         Reviewed by Kenneth Rohde Christiansen.
4
5         [Qt] Improve tests for QWebFrame::url() and related methods
6         https://bugs.webkit.org/show_bug.cgi?id=57865
7
8         * tests/qwebframe/tst_qwebframe.cpp:
9         (FakeReply::FakeReply): make more URLs reply HostNotFound. We needed two different URLs in the test.
10         (tst_QWebFrame::requestedUrlAfterSetAndLoadFailures): check the properties after an setUrl()
11         that fails and a load() that fails (for a different URL).
12
13         (tst_QWebFrame::setUrlWithFragment_data):
14         (tst_QWebFrame::setUrlWithFragment): add other test cases similar to the original, but changing
15         the URL in the frame before the test starts.
16
17         (tst_QWebFrame::setUrlSameUrl): document existing behavior of calling setUrl() twice with
18         the same URL as argument.
19
20         (extractBaseUrl):
21         (tst_QWebFrame::setUrlThenLoads_data):
22         (tst_QWebFrame::setUrlThenLoads): check the URL related properties of the frame after a
23         sequence of set and loads. Those tests are interesting because the properties
24         react different to setUrl() and load(): 'requestedUrl' always change, 'url' only when setUrl()
25         is used or after the load() is committed and baseUrl() is similar to url() but also depends
26         on the contents of the page when it loads.
27
28 2011-04-04  MORITA Hajime  <morrita@google.com>
29
30         Reviewed by Ryosuke Niwa.
31
32         [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
33         https://bugs.webkit.org/show_bug.cgi?id=56085
34         
35         * WebCoreSupport/EditorClientQt.h:
36         (WebCore::EditorClientQt::requestCheckingOfString):
37
38 2011-04-04  Chang Shu  <cshu@webkit.org>
39
40         Reviewed by Ryosuke Niwa.
41
42         setContentEditable with true/false/inherit string is not working properly
43         https://bugs.webkit.org/show_bug.cgi?id=52058
44
45         Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
46         as rendererIsEditable is for WebCore internal use.
47
48         * WebCoreSupport/EditorClientQt.cpp:
49         (WebCore::EditorClientQt::handleKeyboardEvent):
50
51 2011-04-01  Carol Szabo  <carol.szabo@nokia.com>
52
53         Reviewed by Benjamin Poulain.
54
55         Changed QWebFramePrivate::renderFromTiledBackingStore to call directly into
56         Scrollbar/PanIcon rendering, bypassing the potential relayout in renderRelativeCoords.
57
58         Tiled painting still causes synchronous layout when
59         accelerated compositing and texture mapper are enabled
60         https://bugs.webkit.org/show_bug.cgi?id=56929
61
62         * Api/qwebframe.cpp:
63         (QWebFramePrivate::renderFromTiledBackingStore):
64         (QWebFramePrivate::renderRelativeCoords):
65         (QWebFramePrivate::renderFrameWidgets):
66         * Api/qwebframe_p.h:
67
68 2011-04-01  Nancy Piedra  <nancy.piedra@nokia.com>
69
70         Reviewed by Benjamin Poulain.
71
72         [Qt] DragClientQt.h has coding-style errors
73         https://bugs.webkit.org/show_bug.cgi?id=40425
74
75         * WebCoreSupport/DragClientQt.h:
76
77 2011-03-31  Marius Storm-Olsen  <marius.storm-olsen@nokia.com>
78
79         Reviewed by Kenneth Rohde Christiansen.
80
81         [Qt] Properly detect phonon include, and avoid double qtLibraryTarget() call
82         https://bugs.webkit.org/show_bug.cgi?id=57017
83
84         Build fix. No new tests.
85
86         * QtWebKit.pro:
87
88 2011-03-31  Evan Martin  <evan@chromium.org>
89
90         Another build fix.
91
92         * WebCoreSupport/FrameLoaderClientQt.cpp:
93         (WebCore::FrameLoaderClientQt::updateGlobalHistory):
94
95 2011-03-31  Nancy Piedra  <nancy.piedra@nokia.com>
96
97         Reviewed by Benjamin Poulain.
98
99         [Qt] ChromeClientQt.h has coding-style errors
100         https://bugs.webkit.org/show_bug.cgi?id=40239
101
102         * WebCoreSupport/ChromeClientQt.h:
103         (WebCore::ChromeClientQt::scrollbarsModeDidChange):
104         (WebCore::ChromeClientQt::needTouchEvents):
105         (WebCore::ChromeClientQt::formStateDidChange):
106         (WebCore::ChromeClientQt::scrollRectIntoView):
107         (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
108         (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
109
110 2011-03-31  Evan Martin  <evan@chromium.org>
111
112         Build fix from previous change.
113
114         * Api/qwebframe.cpp:
115         (QWebFrame::title):
116
117 2011-03-31  Evan Martin  <evan@chromium.org>
118
119         Reviewed by Eric Seidel.
120
121         <title> should support dir attribute
122         https://bugs.webkit.org/show_bug.cgi?id=50961
123
124         Update to new FrameLoaderClient interface.
125
126         * WebCoreSupport/FrameLoaderClientQt.cpp:
127         (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
128         (WebCore::FrameLoaderClientQt::setTitle):
129         * WebCoreSupport/FrameLoaderClientQt.h:
130
131 2011-03-30  Yi Shen  <yi.4.shen@nokia.com>
132
133         Reviewed by Kenneth Rohde Christiansen.
134
135         [Qt][Symbian] Fix Api test failure -- tst_QWebView::focusInputTypes
136         https://bugs.webkit.org/show_bug.cgi?id=57020
137
138         Added a macro 'VERIFY_INPUTMETHOD_HINTS' to test inputmethodhints().
139
140         * tests/qwebview/tst_qwebview.cpp:
141         (tst_QWebView::focusInputTypes):
142
143 2011-03-30  Robert Hogan  <robert@webkit.org>
144
145         Reviewed by Antonio Gomes.
146
147         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
148
149         Add DRT support for loading an alternate HTML string
150         for error pages. This allows Qt to unskip
151         http/tests/navigation/go-back-to-error-page.html.
152
153         https://bugs.webkit.org/show_bug.cgi?id=52614
154
155         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
156         (DumpRenderTreeSupportQt::setAlternateHtml):
157         * WebCoreSupport/DumpRenderTreeSupportQt.h:
158
159 2011-03-29  Alexis Menard  <alexis.menard@openbossa.org>
160
161         Unreviewed build fix for build-webkit -minimal.
162
163         Breakage introduced by http://trac.webkit.org/changeset/82238.
164         The minimal option has no support for shortcuts.
165
166         * WebCoreSupport/EditorClientQt.cpp:
167         (WebCore::EditorClientQt::handleInputMethodKeydown):
168
169 2011-03-29  Janne Koskinen  <janne.p.koskinen@digia.com>
170
171         Reviewed by Kenneth Rohde Christiansen.
172
173         [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
174         https://bugs.webkit.org/show_bug.cgi?id=33179
175
176         Fixed newline generation from Qt::Key_Enter when editting text area using InputMethods.
177
178         * WebCoreSupport/EditorClientQt.cpp:
179         (WebCore::EditorClientQt::handleInputMethodKeydown):
180         * tests/qwebpage/tst_qwebpage.cpp:
181         (tst_QWebPage::inputMethods):
182
183 2011-03-29  Andreas Kling  <kling@webkit.org>
184
185         Reviewed by Simon Hausmann.
186
187         [Qt] Fix documentation for QWebPage::repaintRequested()
188
189         This signal is always emitted when the page is dirtied, so remove
190         reference to old behavior where we would only emit the signal for
191         headless QWebPages.
192
193         * Api/qwebpage.cpp:
194
195 2011-03-28  Andreas Kling  <kling@webkit.org>
196
197         Reviewed by Benjamin Poulain.
198
199         [Qt] Pass QString() instead of String() when emitting titleChanged() for new loads.
200
201         * WebCoreSupport/FrameLoaderClientQt.cpp:
202         (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
203
204 2011-03-28  Andreas Kling  <kling@webkit.org>
205
206         Reviewed by Benjamin Poulain.
207
208         [Qt] Crash when calling QWebFrame::render() in response to QWebPage::repaintRequested()
209         https://bugs.webkit.org/show_bug.cgi?id=52629
210
211         * WebCoreSupport/ChromeClientQt.cpp:
212         (WebCore::ChromeClientQt::invalidateContentsAndWindow): Make the emission of
213         QWebPage::repaintRequested() use a Qt::QueuedConnection.
214
215         * tests/qwebpage/tst_qwebpage.cpp:
216         (RepaintRequestedRenderer::RepaintRequestedRenderer):
217         (RepaintRequestedRenderer::onRepaintRequested):
218         (tst_QWebPage::renderOnRepaintRequestedShouldNotRecurse): Test that calling
219         QWebFrame::render() in a slot connected to to QWebPage::repaintRequested()
220         doesn't cause recursive signal emissions.
221
222 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
223
224         Reviewed by Andreas Kling.
225
226         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
227         https://bugs.webkit.org/show_bug.cgi?id=57087
228
229         * QtWebKit.pro: we can now enable QT_ASCII_CAST_WARNINGS
230         * tests/tests.pri: we do not require QT_ASCII_CAST_WARNINGS for tests
231         since they are applications, not libraries.
232
233 2011-03-28  Andras Becsi  <abecsi@webkit.org>
234
235         Reviewed by Csaba Osztrogonác.
236
237         [Qt] QtWebKit does not link with --3d-canvas using MinGW
238         https://bugs.webkit.org/show_bug.cgi?id=57225
239
240         * QtWebKit.pro: Append the OpenGL libraries on MinGW so it can resolve symbols.
241
242 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
243
244         Reviewed by Andreas Kling.
245
246         REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
247         https://bugs.webkit.org/show_bug.cgi?id=57183
248
249         Windows buildfix after r82065.
250
251         * Api/DerivedSources.pro: Readding escaping on Windows platforms.
252
253 2011-03-27  Andreas Kling  <kling@webkit.org>
254
255         Fix build warning about IconDatabaseClient.h (wrong path.)
256
257         * QtWebKit.pro:
258
259 2011-03-27  Andreas Kling  <kling@webkit.org>
260
261         Reviewed by Kenneth Rohde Christiansen.
262
263         [Qt] Support for CSS color and background-color properties on select element's dropdown list
264         https://bugs.webkit.org/show_bug.cgi?id=51627
265
266         Extend the QWebSelectData interface with background and foreground colors
267         for the whole menu, as well as per-item. Hook it up to the PopupMenuStyle
268         getters in RenderMenuList.
269
270         * Api/qwebkitplatformplugin.h:
271         * WebCoreSupport/PopupMenuQt.cpp:
272         (SelectData::backgroundColor):
273         (SelectData::foregroundColor):
274         (SelectData::itemBackgroundColor):
275         (SelectData::itemForegroundColor):
276         * WebCoreSupport/QtFallbackWebPopup.cpp:
277         (WebCore::QtFallbackWebPopup::show):
278         (WebCore::QtFallbackWebPopup::populate):
279
280 2011-03-27  Yi Shen  <yi.4.shen@nokia.com>
281
282         Reviewed by Andreas Kling.
283
284         [Qt][Symbian] Fix Api test failure -- microFocusCoordinates
285         https://bugs.webkit.org/show_bug.cgi?id=57108
286
287         Since the canvas is not self-closing tag, we need to add '</canvas>'. 
288
289         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
290         (tst_QGraphicsWebView::microFocusCoordinates):
291         * tests/qwebview/tst_qwebview.cpp:
292         (tst_QWebView::microFocusCoordinates):
293
294 2011-03-27  Kwang Yul Seo  <skyul@company100.net>
295
296         Reviewed by Eric Seidel.
297
298         [Qt] Build fix: Define WTF_USE_TEXTURE_MAPPER=1 when CONFIG contains texmap.
299         https://bugs.webkit.org/show_bug.cgi?id=57143
300
301         Qt WebKit uses USE(TEXTURE_MAPPER) guard. Check texmap in CONFIG and
302         define WTF_USE_TEXTURE_MAPPER=1.
303
304         * QtWebKit.pro:
305
306 2011-03-27  Andreas Kling  <kling@webkit.org>
307
308         Reviewed by Benjamin Poulain.
309
310         REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
311         https://bugs.webkit.org/show_bug.cgi?id=57183
312
313         The convenience <QtWebKit> header would include \<QtNetwork/QtNetwork\>
314         which was due to the outputting code previously being wrapped in eval().
315
316         * Api/DerivedSources.pro:
317
318 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
319
320         Reviewed by Andreas Kling.
321
322         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
323         https://bugs.webkit.org/show_bug.cgi?id=57087
324
325         Use explicit conversion for string to avoid depending on the default codec
326         installed by the user code.
327
328         * Api/qwebkitversion.cpp:
329         (qWebKitVersion):
330         * Api/qwebpage.cpp:
331         (QWebPagePrivate::dynamicPropertyChangeEvent):
332         (QWebPage::javaScriptConsoleMessage):
333         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
334         (convertToPropertyName):
335         (DumpRenderTreeSupportQt::setEditingBehavior):
336         (DumpRenderTreeSupportQt::plainText):
337         * WebCoreSupport/EditorClientQt.cpp:
338         (dumpRange):
339         * WebCoreSupport/FrameLoaderClientQt.cpp:
340         (drtDescriptionSuitableForTestResult):
341         (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
342         * WebCoreSupport/InspectorClientQt.cpp:
343         (WebCore::InspectorClientQt::openInspectorFrontend):
344         * WebCoreSupport/InspectorServerQt.cpp:
345         (WebCore::parseWebSocketChallengeNumber):
346         (WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
347
348 2011-03-26  Andreas Kling  <kling@webkit.org>
349
350         Reviewed by Kenneth Rohde Christiansen.
351
352         [Qt] QWebFrame::iconChanged() not emitted when icon is cached but not yet loaded
353         https://bugs.webkit.org/show_bug.cgi?id=57157
354
355         Add an IconDatabaseClient for the Qt port to ensure that QWebFrame::iconChanged()
356         is always emitted when appropriate.
357
358         * QtWebKit.pro: Add new files.
359
360         * WebCoreSupport/IconDatabaseClientQt.h: Added.
361         * WebCoreSupport/IconDatabaseClientQt.cpp: Added.
362         (WebCore::IconDatabaseClientQt::instance):
363         (WebCore::IconDatabaseClientQt::IconDatabaseClientQt):
364         (WebCore::IconDatabaseClientQt::~IconDatabaseClientQt):
365         (WebCore::IconDatabaseClientQt::performImport):
366         (WebCore::IconDatabaseClientQt::didRemoveAllIcons):
367         (WebCore::IconDatabaseClientQt::didImportIconURLForPageURL):
368         (WebCore::IconDatabaseClientQt::didImportIconDataForPageURL):
369         (WebCore::IconDatabaseClientQt::didChangeIconForPageURL):
370         (WebCore::IconDatabaseClientQt::didFinishURLImport):
371
372         * WebCoreSupport/FrameLoaderClientQt.h:
373         * WebCoreSupport/FrameLoaderClientQt.cpp:
374         (WebCore::FrameLoaderClientQt::registerForIconNotification):
375         (WebCore::FrameLoaderClientQt::onIconLoadedForPageURL): New slot connected
376         to the IconDatabaseClientQt::iconLoadedForPageURL() signal. This emits the
377         QWebFrame::iconChanged() signal when the IconDatabases finishes loading
378         a cached favicon for the frame's URL.
379
380         * Api/qwebsettings.cpp:
381         (QWebSettings::setIconDatabasePath): Make sure that IconDatabaseClientQt is
382         instantiated. An IconDatabaseClient has to be registered before the IconDatabase
383         spawns its reader thread.
384
385 2011-03-25  Andy Estes  <aestes@apple.com>
386
387         Reviewed by Adele Peterson.
388
389         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
390         https://bugs.webkit.org/show_bug.cgi?id=49016
391
392         Update objectContentType() implementation to handle the
393         shouldPreferPlugInsForImages flag.
394
395         * WebCoreSupport/FrameLoaderClientQt.cpp:
396         (WebCore::FrameLoaderClientQt::objectContentType):
397         * WebCoreSupport/FrameLoaderClientQt.h:
398
399 2011-03-25  Chang Shu  <cshu@webkit.org>
400
401         Reviewed by Ryosuke Niwa.
402
403         rename Node::isContentEditable and all call sites to rendererIsEditable
404         https://bugs.webkit.org/show_bug.cgi?id=54290
405
406         This is part of the effort to separate JS API HTMLElement isContentEditable from
407         internal Node::rendererIsEditable.
408
409         * WebCoreSupport/EditorClientQt.cpp:
410         (WebCore::EditorClientQt::handleKeyboardEvent):
411
412 2011-03-25  Alexis Menard  <alexis.menard@openbossa.org>
413
414         Reviewed by Andreas Kling.
415
416         [Qt] The keyboard shortcuts during fullscreen playback do not work.
417         https://bugs.webkit.org/show_bug.cgi?id=57095
418
419         We need to explicitely set the focus on the widget in order to receive the keyboard events.
420
421         * WebCoreSupport/FullScreenVideoWidget.cpp:
422         (WebCore::FullScreenVideoWidget::show):
423
424 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
425
426         Unreviewed, rolling out r81916 and r81917.
427         http://trac.webkit.org/changeset/81916
428         http://trac.webkit.org/changeset/81917
429         https://bugs.webkit.org/show_bug.cgi?id=57071
430
431         broke a test on platforms that do not have QuickTime installed
432         (Requested by estes on #webkit).
433
434         * WebCoreSupport/FrameLoaderClientQt.cpp:
435         (WebCore::FrameLoaderClientQt::objectContentType):
436         * WebCoreSupport/FrameLoaderClientQt.h:
437
438 2011-03-24  Andy Estes  <aestes@apple.com>
439
440         Reviewed by Darin Adler.
441
442         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
443         https://bugs.webkit.org/show_bug.cgi?id=49016
444
445         Update objectContentType() implementation to handle the
446         shouldPreferPlugInsForImages flag.
447
448         * WebCoreSupport/FrameLoaderClientQt.cpp:
449         (WebCore::FrameLoaderClientQt::objectContentType):
450         * WebCoreSupport/FrameLoaderClientQt.h:
451
452 2011-03-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
453
454         Reviewed by Kenneth Rohde Christiansen.
455
456         [Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles
457         https://bugs.webkit.org/show_bug.cgi?id=40884
458
459         Add tests and benchmarks for the software fallback of WebGL.
460
461         * tests/benchmarks/webgl/10000_triangles.html: Added.
462         * tests/benchmarks/webgl/tst_webgl.cpp: Added.
463         (GraphicsView::GraphicsView):
464         (GraphicsView::resizeEvent):
465         (tst_WebGlPerformance::init):
466         (tst_WebGlPerformance::cleanup):
467         (tst_WebGlPerformance::benchSoftwareFallbackRgb16):
468         (tst_WebGlPerformance::benchSoftwareFallbackRgb32):
469         (tst_WebGlPerformance::benchSoftwareFallbackArgb32):
470         (tst_WebGlPerformance::benchSoftwareFallbackArgb32Premultiplied):
471         (tst_WebGlPerformance::benchmarkFrameRenderingOnImage):
472         * tests/benchmarks/webgl/tst_webgl.qrc: Added.
473         * tests/benchmarks/webgl/webgl.pro: Added.
474         * tests/qgraphicswebview/qgraphicswebview.pro:
475         * tests/qgraphicswebview/resources/pointing_right.html: Added.
476         * tests/qgraphicswebview/resources/pointing_up.html: Added.
477         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
478         (compareImagesFuzzyPixelCount):
479         (GraphicsView::GraphicsView):
480         (tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation):
481         (tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation):
482         (tst_QGraphicsWebView::compareCanvasToImage):
483         * tests/qgraphicswebview/tst_qgraphicswebview.qrc:
484         * tests/tests.pro:
485
486 2011-03-24  Kristian Amlie  <kristian.amlie@nokia.com>
487
488         Reviewed by Benjamin Poulain.
489
490         Avoided ASCII-cast warnings for WebKit.
491
492         Normally they won't be enabled anyway, but if you build webkit from
493         within the Qt mother repository it will pick up Qt's default build
494         settings, which do enable it. We need to disable them because
495         warnings are treated as errors and there are way too many of them in
496         the WebKit code.
497
498         [Qt] Avoid ASCII-cast warnings for WebKit.
499         https://bugs.webkit.org/show_bug.cgi?id=57016
500
501         * QtWebKit.pro:
502
503 2011-03-24  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
504
505         Reviewed by Benjamin Poulain.
506
507         [Qt] Resetting the URL property of a QWebView results in the current directory being set as file::-type URL
508         https://bugs.webkit.org/show_bug.cgi?id=29595
509
510         Qt Designer resets the URL by setting it to QUrl(). The bug was caused by
511         ensureAbsoluteUrl() helper function treating the empty URL as a relative URL, and
512         prepending the current directory.
513
514         By fixing this, now we can pass QUrl() invalid and empty URLs to WebCore layer, which
515         will end up loading "about:blank", but keeping it as a requested URL.
516
517         This patch also simplifies the logic for requestedUrl(), since m_lastRequestedUrl
518         is filled for the loaded URLs as well, we can use it in every case.
519
520         Three new autotests were added, to better cover the expected behavior of setting
521         the QUrl() in a QWebFrame.
522
523         * Api/qwebframe.cpp:
524         (ensureAbsoluteUrl): do not treat invalid URLs (empty included) as relative.
525         (QWebFrame::requestedUrl): always use m_lastRequestedUrl.
526
527         * WebCoreSupport/FrameLoaderClientQt.cpp:
528         (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): do not clear m_lastRequestedUrl
529         anymore, since we always rely on it even for loaded frames.
530
531         * tests/qwebframe/tst_qwebframe.cpp:
532         (tst_QWebFrame::setUrlToEmpty): verify the behavior of setting empty URLs. This includes
533         the reduction of the bug report.
534         (tst_QWebFrame::setUrlToInvalid): setting invalid, but not necessarily empty, URLs.
535         (tst_QWebFrame::setUrlHistory): to verify how setting empty URLs affect history.
536
537 2011-03-23  Brady Eidson  <beidson@apple.com>
538
539         Reviewed by Sam Weinig.
540
541         Change IconDatabase opening to allow for arbitrary filenames
542         https://bugs.webkit.org/show_bug.cgi?id=56977
543
544         * Api/qwebsettings.cpp:
545         (QWebSettings::setIconDatabasePath):
546
547 2011-03-23  Aparna Nandyal  <aparna.nand@wipro.com>
548
549         Reviewed by Andreas Kling.
550
551         [Qt] QtWebKit rendering problem when maximizing and doing a back
552         https://bugs.webkit.org/show_bug.cgi?id=56669
553
554         Added an auto test.
555         Patch by Alexis Menard < alexis.menard@nokia.com> on 2011-03-21
556  
557         * tests/qwebview/tst_qwebview.cpp:
558         (tst_QWebView::rendering):
559
560 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
561
562         Reviewed by Pavel Feldman.
563
564         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
565         https://bugs.webkit.org/show_bug.cgi?id=56843
566
567         * WebCoreSupport/InspectorClientQt.cpp:
568         (WebCore::InspectorClientQt::openInspectorFrontend):
569
570 2011-03-22  Andrew Wason  <rectalogic@rectalogic.com>
571
572         Reviewed by Benjamin Poulain.
573
574         [Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
575         https://bugs.webkit.org/show_bug.cgi?id=54138
576
577         * tests/qwebpage/tst_qwebpage.cpp:
578         (webGLScreenshotWithoutView):
579         (tst_QWebPage::acceleratedWebGLScreenshotWithoutView):
580         (tst_QWebPage::unacceleratedWebGLScreenshotWithoutView):
581          Render a QWebPage (with and without accelerated compositing)
582          with a WebGL context that has no owning view.  Shouldn't crash.
583
584 2011-03-21  Chang Shu  <cshu@webkit.org>
585
586         Reviewed by Alexey Proskuryakov.
587
588         REGRESSION (r79953): Can't type in MS Outlook 2011
589         https://bugs.webkit.org/show_bug.cgi?id=56665
590
591         r79953 removed the WebView level editablity which is persistent no matter whether
592         underlying document itself is changed and editability gets lost. The resolution is to
593         set this WebView editable value to WebCore. This avoids the callback from WebCore to
594         WebKit which was the main goal in r79953 to improve performance.
595
596         * Api/qwebpage.cpp:
597         (QWebPage::setContentEditable):
598         (QWebPage::isContentEditable):
599
600 2011-03-19  Andreas Kling  <kling@webkit.org>
601
602         Reviewed by Benjamin Poulain.
603
604         [Qt] Remove support for Qt 4.6
605         https://bugs.webkit.org/show_bug.cgi?id=56712
606
607         * Api/qwebframe.cpp:
608         (QWebFrame::load):
609         * Api/qwebpage.cpp:
610         (QWebPagePrivate::QWebPagePrivate):
611         * Api/qwebsettings.cpp:
612         (QWebSettings::QWebSettings):
613         * WebCoreSupport/GeolocationClientQt.cpp:
614         (WebCore::GeolocationClientQt::positionUpdated):
615
616 2011-03-19  Andreas Kling  <kling@webkit.org>
617
618         Reviewed by Antonio Gomes.
619
620         [Qt][Doc] QWebPage::unsupportedContent() passes ownership of the QNetworkReply
621         https://bugs.webkit.org/show_bug.cgi?id=56711
622
623         Document the fact that when unsupportedContent(QNetworkReply*) is emitted,
624         ownership of the reply is transferred to the receiving slot.
625
626         * Api/qwebpage.cpp:
627
628 2011-03-17  Brady Eidson  <beidson@apple.com>
629
630         Reviewed by Sam Weinig.
631
632         https://bugs.webkit.org/show_bug.cgi?id=56425
633         More groundwork for WebKit2 IconDatabase
634
635         Update already-used function names:
636         * Api/qwebhistory.cpp:
637         (QWebHistoryItem::icon):
638         * Api/qwebsettings.cpp:
639         (QWebSettings::iconForUrl):
640
641 2011-03-18  Alexis Menard  <alexis.menard@openbossa.org>
642
643         Reviewed by Benjamin Poulain.
644
645         [Qt] console.log not being exposed to QmlViewer
646         https://bugs.webkit.org/show_bug.cgi?id=56536
647
648         The documentation is bogus the feature does not exist.
649
650         * declarative/qdeclarativewebview.cpp:
651
652 2011-03-17  Andreas Kling  <kling@webkit.org>
653
654         Reviewed by Kenneth Rohde Christiansen.
655
656         [Qt] QML WebView emits iconChanged() when the page title changes
657         https://bugs.webkit.org/show_bug.cgi?id=56570
658
659         * declarative/qdeclarativewebview.cpp:
660         (QDeclarativeWebView::setPage): Don't forward the frame's titleChanged
661         signal to the view's iconChanged signal.
662
663 2011-03-17  Alexis Menard  <alexis.menard@openbossa.org>
664
665         Reviewed by Benjamin Poulain.
666
667         [Qt] Videos look ugly when using QGraphicsWebView.
668         https://bugs.webkit.org/show_bug.cgi?id=56580
669
670         We need to set QPainter::SmoothPixmapTransform on the painter for a proper rendering of the video.
671         QWebView does it but not QGraphicsWebView because the API does not exist. This patch is fixing it
672         by introducing the same API as QWebView to control the renderHints of the item. Unlike QWebView
673         QGraphicsWebView inherits the painter from QGraphicsScene and those flags are not set. This patch
674         ensure that before rendering the item we add QPainter::SmoothPixmapTransform and QPainter::TextAntialiasing
675         in addition of what could be set on the painter. In order to not break the rendering of all the items in the
676         scene we set back the painter to its original state when QGraphicsWebView is rendered.
677
678         * Api/qgraphicswebview.cpp:
679         (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
680         (QGraphicsWebView::paint):
681         (QGraphicsWebView::renderHints):
682         (QGraphicsWebView::setRenderHints):
683         (QGraphicsWebView::setRenderHint):
684         * Api/qgraphicswebview.h:
685         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
686         (tst_QGraphicsWebView::renderHints):
687
688 2011-03-16  Joseph Pecoraro  <joepeck@webkit.org>
689
690         Reviewed by Kenneth Rohde Christiansen.
691
692         Viewport no longer allows an auto value for "user-scalable"
693         https://bugs.webkit.org/show_bug.cgi?id=55416
694
695         Make the default value for userScalable be true.
696
697         * Api/qwebpage.cpp:
698         (QWebPage::viewportAttributesForSize):
699         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
700         (DumpRenderTreeSupportQt::viewportAsText): update test output to include userScalable.
701
702 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
703
704         Reviewed by Darin Adler.
705
706         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
707         info into the headers rather than in export symbol definition files, but disable it on 
708         all platforms initially so we can deal with port build issues one port at a time.
709         
710         https://bugs.webkit.org/show_bug.cgi?id=27551
711
712         * WebCoreSupport/GeolocationClientQt.cpp:
713         * WebCoreSupport/PopupMenuQt.cpp:
714
715 2011-03-14  Brady Eidson  <beidson@apple.com>
716
717         Reviewed by Anders Carlsson.
718
719         https://bugs.webkit.org/show_bug.cgi?id=56320
720         Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
721
722         * Api/qwebhistory.cpp:
723         (QWebHistoryItem::icon): Use IconDatabase directly.
724
725 2011-03-11  Brady Eidson  <beidson@apple.com>
726
727         Reviewed by attempt at build fix!
728
729         https://bugs.webkit.org/show_bug.cgi?id=56216
730         Fix the Qt build following the same pattern of the patch.
731
732         * Api/qwebsettings.cpp:
733         (QWebSettings::setIconDatabasePath): Call the static method via IconDatabase:: and not via iconDatabase()
734
735 2011-03-11  Alexis Menard  <alexis.menard@openbossa.org>
736
737         Reviewed by Ariya Hidayat.
738
739         [Qt] Entering fullscreen and leaving it may hide the cursor of the application.
740         https://bugs.webkit.org/show_bug.cgi?id=56181
741
742         We need to stop the auto hide cursor timer when closing the widget otherwise the timer
743         might get fired and therefore hide the cursor even when the fullscreen widget is closed.
744
745         * WebCoreSupport/FullScreenVideoWidget.cpp:
746         (WebCore::FullScreenVideoWidget::closeEvent):
747
748 2011-03-10  David Boddie <david.boddie@nokia.com>
749
750         Reviewed by Andreas Kling.
751
752         Fixed a qdoc warning and terminology (WebKit instead of Webkit).
753         https://bugs.webkit.org/show_bug.cgi?id=55756
754
755         * Api/qwebhistoryinterface.cpp:
756
757 2011-03-10  Andreas Kling  <kling@webkit.org>
758
759         Unreviewed build fix after r80774.
760
761         QML property versioning is introduced in Qt 4.7.3, not 4.7.2.
762         See also: http://bugreports.qt.nokia.com/browse/QTBUG-13451
763
764         * declarative/plugin.cpp:
765         (WebKitQmlPlugin::registerTypes):
766         * declarative/qdeclarativewebview.cpp:
767         * declarative/qdeclarativewebview_p.h:
768         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
769
770 2011-03-10  Alexis Menard  <alexis.menard@openbossa.org>
771
772         Reviewed by Andreas Kling.
773
774         [Qt] QtDeclarative Webview element has a fixed white background
775         https://bugs.webkit.org/show_bug.cgi?id=40918
776
777         Implement a way to change the background color of the WebView QML element.
778         This feature is activated for QtWebKit 1.1 version of the plugin.
779
780         * declarative/plugin.cpp:
781         (WebKitQmlPlugin::registerTypes):
782         * declarative/qdeclarativewebview.cpp:
783         (QDeclarativeWebView::backgroundColor):
784         (QDeclarativeWebView::setBackgroundColor):
785         * declarative/qdeclarativewebview_p.h:
786         * tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml: Added.
787         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
788         (tst_QDeclarativeWebView::backgroundColor):
789         * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
790
791 2011-03-10  Stanislav Paltis  <Stanislav.Paltis@nokia.com>
792
793         Reviewed by Laszlo Gombos.
794
795         [Qt] MemoryCache deadDecodedDataDeletionInterval is not exposed for client's usage
796         https://bugs.webkit.org/show_bug.cgi?id=55945
797         
798         Added handling of dynamic/runtime property _q_deadDecodedDataDeletionInterval to 
799         set interval used to trigger when decoded data in dead list of object cache will 
800         be purged from object cache. 
801
802         * Api/qwebpage.cpp:
803         (QWebPagePrivate::dynamicPropertyChangeEvent):
804
805 2011-03-10  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
806
807         Reviewed by Antonio Gomes.
808
809         Simplify how QWebFrame::requestedUrl() is obtained
810         https://bugs.webkit.org/show_bug.cgi?id=55842
811
812         When a load starts, store the requested URL until we know that it'll be
813         available for us in the document loader -- after load finished.
814
815         The existing auto tests cover the three different code paths in
816         requestedUrl() and the new code passes the autotests. In each of those
817         cases, we looked for the information in a different place, but in all
818         of them, dispatchDidStartProvisionalLoad was called.
819
820         This simplification will be useful to fix bug 32723. The way requestedUrl()
821         is implementent, we can't use it as a fallback for url() when the setUrl()
822         was called with an invalid URL.
823
824         * Api/qwebframe.cpp:
825         (QWebFrame::requestedUrl):
826         * WebCoreSupport/FrameLoaderClientQt.cpp:
827         (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
828         (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
829         * WebCoreSupport/FrameLoaderClientQt.h:
830         (WebCore::FrameLoaderClientQt::lastRequestedUrl):
831
832 2011-03-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
833
834         Reviewed by Kenneth Rohde Christiansen.
835
836         Tiled backing store's delegated scroll request uses incorrect convention
837         https://bugs.webkit.org/show_bug.cgi?id=56011
838
839         Adapt internal API to match the change from delta to point on the
840         WebCore side, and convert the point to a delta for the public API.
841
842         * WebCoreSupport/ChromeClientQt.cpp:
843         (WebCore::ChromeClientQt::delegatedScrollRequested):
844         * WebCoreSupport/ChromeClientQt.h:
845
846 2011-03-09  Peter Kasting  <pkasting@google.com>
847
848         Reviewed by Mihai Parparita.
849
850         Unify Windows version checks.
851         https://bugs.webkit.org/show_bug.cgi?id=55979
852
853         * Api/qwebpage.cpp:
854         (QWebPage::userAgentForUrl):
855
856 2011-03-07  Sam Weinig  <sam@webkit.org>
857
858         Reviewed by Anders Carlsson.
859
860         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
861         https://bugs.webkit.org/show_bug.cgi?id=55827
862
863         Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
864         and pass the entire response, instead of just the MIMEType.
865
866         * WebCoreSupport/FrameLoaderClientQt.cpp:
867         (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
868         * WebCoreSupport/FrameLoaderClientQt.h:
869
870 2011-03-05  Qi Zhang  <qi.2.zhang@nokia.com>
871
872         Reviewed by Laszlo Gombos.
873
874         [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
875         https://bugs.webkit.org/show_bug.cgi?id=48636
876
877         Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.
878
879         * Api/qwebpage.cpp:
880         (QWebPage::userAgentForUrl):
881
882 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
883
884         Reviewed by Kenneth Rohde Christiansen.
885
886         [QT] Implement mock client-based geolocation for layout testing
887         https://bugs.webkit.org/show_bug.cgi?id=54334
888
889         Implement layout testing for Client-Based geolocation. If drt_run is set 
890         then create mock geolocationClient and update the same with controller.
891
892         * Api/qwebpage.cpp:
893         (QWebPagePrivate::QWebPagePrivate):
894         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
895         (DumpRenderTreeSupportQt::mockGeolocationReset):
896         (DumpRenderTreeSupportQt::setMockGeolocationPermission):
897         (DumpRenderTreeSupportQt::setMockGeolocationPosition):
898         (DumpRenderTreeSupportQt::setMockGeolocationError):
899         * WebCoreSupport/DumpRenderTreeSupportQt.h:
900         * WebCoreSupport/GeolocationClientQt.cpp:
901         (WebCore::GeolocationClientQt::GeolocationClientQt):
902         * WebCoreSupport/GeolocationClientQt.h:
903
904 2011-03-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
905
906         Reviewed by Kenneth Rohde Christiansen.
907
908         [Qt] QWebFrame::setUrl works only from second time if url fragment is present
909         https://bugs.webkit.org/show_bug.cgi?id=32723
910
911         Create an auto-test for Qt based on the bug description.
912
913         * tests/qwebframe/tst_qwebframe.cpp: add setUrlWithFragment() test.
914
915 2011-03-03  Brady Eidson  <beidson@apple.com>
916
917         Reviewed by Darin Adler.
918
919         https://bugs.webkit.org/show_bug.cgi?id=55721
920         Global IconDatabase should be returned by reference, not as a pointer
921
922         * Api/qwebsettings.cpp:
923         (QWebSettings::setIconDatabasePath):
924         (QWebSettings::iconDatabasePath):
925         (QWebSettings::clearIconDatabase):
926         (QWebSettings::iconForUrl):
927
928 2011-03-03  Alexey Proskuryakov  <ap@apple.com>
929
930         Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included
931         via ChromeClient.h
932
933         * WebCoreSupport/ChromeClientQt.h:
934
935 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
936
937         Reviewed by Darin Adler.
938
939         REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
940         https://bugs.webkit.org/show_bug.cgi?id=55633
941         <rdar://problem/8963023>
942
943         * WebCoreSupport/ChromeClientQt.cpp (WebCore::ChromeClientQt::keyboardUIMode):
944         * WebCoreSupport/ChromeClientQt.h:
945         Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since
946         this platform doesn't observe or have full keyboard access state.
947
948 2011-03-03  Alexis Menard  <alexis.menard@openbossa.org>
949
950         Reviewed by Andreas Kling.
951
952         [Qt] QGraphicsWebView should use updateMicroFocus() of QGraphicsItem
953         https://bugs.webkit.org/show_bug.cgi?id=55568
954
955         We should use updateMicroFocus() from QGraphicsItem rather than the implementation
956         in QGraphicsWebView. _q_updateMicroFocus was added when QGraphicsItem didn't have the feature.
957         In Qt 4.7, updateMicroFocus was added, let's use it, then we can benefit of all bug fixing done
958         in QGraphicsItem.
959
960         * Api/qgraphicswebview.cpp:
961         (QGraphicsWebView::setPage):
962         * Api/qgraphicswebview.h:
963
964 2011-03-03  Peter Kasting  <pkasting@google.com>
965
966         Reviewed by James Robinson.
967
968         Drop redundant "Windows; " from the Windows-specific User Agent string.
969         https://bugs.webkit.org/show_bug.cgi?id=54567
970
971         * Api/qwebpage.cpp:
972         (QWebPage::userAgentForUrl):
973
974 2011-03-01  Brian Weinstein  <bweinstein@apple.com>
975
976         Reviewed by Adam Roben.
977
978         Part of WebKit2: Need a way to send notifications to client when cookies change
979         https://bugs.webkit.org/show_bug.cgi?id=55427
980         <rdar://problem/9056027>
981         
982         Add stubs for CookiesStrategy on Qt WebKit1.
983
984         * WebCoreSupport/WebPlatformStrategies.cpp:
985         (WebPlatformStrategies::createCookiesStrategy):
986         (WebPlatformStrategies::notifyCookiesChanged):
987         * WebCoreSupport/WebPlatformStrategies.h:
988
989 2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>
990
991         Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.
992
993         * Api/qwebpage.cpp:
994         (QWebPage::viewportAttributesForSize):
995         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
996         (DumpRenderTreeSupportQt::viewportAsText):
997
998 2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>
999
1000         Reviewed by Kenneth Rohde Christiansen.
1001
1002         Viewport Warning/Error Messages Are Now Inaccurate
1003         https://bugs.webkit.org/show_bug.cgi?id=53707
1004
1005         * Api/qwebpage.cpp:
1006         (QWebPage::viewportAttributesForSize): pass a Document into computeViewportAttributes for warnings to be reported to.
1007         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1008         (DumpRenderTreeSupportQt::viewportAsText): pass a Document into computeViewportAttributes for warnings to be reported to.
1009
1010 2011-03-01  Andras Becsi  <abecsi@webkit.org>
1011
1012         Reviewed by Csaba Osztrogonác.
1013
1014         [Qt] Clean up the project files and move common options to WebKit.pri.
1015
1016         * QtWebKit.pro: Move common options to WebKit.pri.
1017
1018 2011-03-01  Aparna Nandyal  <aparna.nand@wipro.com>
1019
1020         Reviewed by Simon Hausmann.
1021
1022         [Qt]tst_QWebPage::backActionUpdate fails when there is not network connection
1023         https://bugs.webkit.org/show_bug.cgi?id=55319
1024
1025         The test case required internet connection to be able to connect to
1026         google.com. Added new html file which refers to local html file.
1027
1028         * tests/qwebpage/resources/content.html: Added.
1029         * tests/qwebpage/resources/frame_c.html: Added.
1030         * tests/qwebpage/resources/framedindex.html: Added.
1031         * tests/qwebpage/tst_qwebpage.cpp:
1032         (tst_QWebPage::backActionUpdate):
1033         * tests/qwebpage/tst_qwebpage.qrc:
1034
1035 2011-02-25 Steve Block <steveblock@google.com>
1036
1037         Reviewed by Jeremy Orlow.
1038
1039         Bridge.h should not include BridgeJSC.h
1040         https://bugs.webkit.org/show_bug.cgi?id=55212
1041
1042         Include BridgeJSC.h directly instead.
1043
1044         * Api/qwebframe.cpp:
1045
1046 2011-02-28  Chang Shu  <cshu@webkit.org>
1047
1048         Reviewed by Ryosuke Niwa.
1049
1050         Remove the support of Frame::isContentEditable and its dependencies.
1051         https://bugs.webkit.org/show_bug.cgi?id=54292
1052
1053         Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
1054
1055         * Api/qwebpage.cpp:
1056         (QWebPagePrivate::QWebPagePrivate):
1057         (QWebPage::setContentEditable):
1058         (QWebPage::isContentEditable):
1059         * Api/qwebpage_p.h:
1060         * WebCoreSupport/EditorClientQt.cpp:
1061         * WebCoreSupport/EditorClientQt.h:
1062
1063 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
1064
1065         Reviewed by Oliver Hunt.
1066
1067         Build fix for Qt port after API changes of http://trac.webkit.org/changeset/79904.
1068
1069         * Api/qwebelement.cpp:
1070         (QWebElement::evaluateJavaScript):
1071
1072 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
1073
1074         Reviewed by Andreas Kling.
1075
1076         [Qt]tst_QDeclarativeWebView - 8 test cases fail
1077         https://bugs.webkit.org/show_bug.cgi?id=55214
1078
1079         Fix the API tests for the QML WebView element. The default size of the element should be the size of the QGraphicsWebView
1080         if no preferred width or height are provided (see http://trac.webkit.org/changeset/79672).
1081         I also refactored the tests so we don't use the network but instead a local html file.
1082         QML doesn't support qrc loading so I had to workaround by using a property that I update afterwards.
1083
1084         * tests/qdeclarativewebview/resources/sample.html: Added.
1085         * tests/qdeclarativewebview/resources/webviewtest.qml:
1086         * tests/qdeclarativewebview/resources/webviewtestdefault.qml:
1087         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
1088         (tst_QDeclarativeWebView::preferredWidthTest):
1089         (tst_QDeclarativeWebView::preferredHeightTest):
1090         (tst_QDeclarativeWebView::preferredWidthDefaultTest):
1091         (tst_QDeclarativeWebView::preferredHeightDefaultTest):
1092         * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
1093
1094 2011-02-28  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1095
1096         Reviewed by Andreas Kling.
1097
1098         [Qt] Add clipped version of QWebElement::render method.
1099         Allows faster rendering of web element part.
1100         https://bugs.webkit.org/show_bug.cgi?id=50311
1101
1102         * Api/qwebelement.cpp:
1103         (QWebElement::render):
1104         * Api/qwebelement.h:
1105         * tests/qwebelement/tst_qwebelement.cpp:
1106         (tst_QWebElement::render):
1107
1108 2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>
1109
1110         Reviewed by Andreas Kling.
1111
1112         Added full webkit module profile and a syncqt profile.
1113
1114         This is for modularized Qt.
1115
1116         [Qt] WebKit patches required to work with a modularized version of Qt
1117         https://bugs.webkit.org/show_bug.cgi?id=53916
1118
1119         * qt_webkit_version.pri:
1120
1121 2011-02-27  Aparna Nandyal  <aparna.nand@wipro.com>
1122
1123         Reviewed by Antonio Gomes.
1124
1125         [Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
1126         https://bugs.webkit.org/show_bug.cgi?id=53917
1127
1128         Adding test case to check the scenario to avoid regressions in the
1129         future. 
1130
1131         * tests/qwebframe/tst_qwebframe.cpp:
1132
1133 2011-02-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
1134
1135         Reviewed by Andreas Kling.
1136
1137         [Qt] Reference the documentation of the WebKit bridge from QWebFrame::addToJavaScriptWindowObject()
1138         https://bugs.webkit.org/show_bug.cgi?id=55322
1139
1140         Documentation update, add a reference to the QtWebKit bridge page.
1141
1142         * Api/qwebframe.cpp:
1143
1144 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
1145
1146         Reviewed by Pavel Feldman.
1147
1148         DumpRenderTree should reset frame opener between tests.
1149         https://bugs.webkit.org/show_bug.cgi?id=54874
1150
1151         Added clearOpener method to DumpRenderTreeSupportQT.
1152
1153         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1154         (DumpRenderTreeSupportQt::clearOpener):
1155         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1156
1157 2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1158
1159         Reviewed by Andreas Kling.
1160
1161         Make it possible to test the targetdensity-dpi support
1162         https://bugs.webkit.org/show_bug.cgi?id=55142
1163
1164         Test the viewport meta tag feature targetdensity-dpi by
1165         adding extra arguments to dumpConfigurationForViewport
1166
1167         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1168         (DumpRenderTreeSupportQt::viewportAsText):
1169         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1170
1171 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1172
1173         Unreviewed, rolling out r79764.
1174         http://trac.webkit.org/changeset/79764
1175         https://bugs.webkit.org/show_bug.cgi?id=55295
1176
1177         "broke Chromium builds" (Requested by rniwa on #webkit).
1178
1179         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1180         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1181
1182 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
1183
1184         Reviewed by Pavel Feldman.
1185
1186         DumpRenderTree should reset frame opener between tests.
1187         https://bugs.webkit.org/show_bug.cgi?id=54874
1188
1189         Added clearOpener method to DumpRenderTreeSupportQT.
1190
1191         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1192         (DumpRenderTreeSupportQt::clearOpener):
1193         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1194
1195 2011-02-25  Andras Becsi  <abecsi@webkit.org>
1196
1197         Reviewed by Csaba Osztrogonác.
1198
1199         [Qt] Make the WebKit2 build system less confusing for non-Qt developers
1200         https://bugs.webkit.org/show_bug.cgi?id=55213
1201
1202         * QtWebKit.pro: Move the WebKit2 API into a project include file
1203         in the WebKit2 directory and include the pri file here.
1204
1205 2011-02-25  Alexis Menard  <alexis.menard@openbossa.org>
1206
1207         Unreviewed build fix for Intel ICC and MSVC.
1208
1209         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
1210         (tst_QGraphicsWebView::setPalette):
1211         * tests/qwebview/tst_qwebview.cpp:
1212         (tst_QWebView::setPalette):
1213
1214 2011-02-25  Alexis Menard  <alexis.menard@openbossa.org>
1215
1216         Reviewed by Kenneth Rohde Christiansen.
1217
1218         [Qt] Properly propagate the palette to QWebPage from QGraphicsWebView
1219         https://bugs.webkit.org/show_bug.cgi?id=31742
1220
1221         Discovered while looking at 31742. When we set a palette on the
1222         QGraphicsWebView we need to propagate it to the page like QWebView.
1223         I have added the same tests as QWebView to be sure to catch potential
1224         regressions as well as two extras QVERIFY to check the palette propagation.
1225
1226         * Api/qgraphicswebview.cpp:
1227         (QGraphicsWebView::event):
1228         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
1229         (tst_QGraphicsWebView::setPalette_data):
1230         (tst_QGraphicsWebView::setPalette):
1231
1232 2011-02-25  Csaba Osztrogonác  <ossy@webkit.org>
1233
1234         Unreviewed buildfix after r79672.
1235
1236         [Qt] Build tst_qdeclarativewebview if QT_CONFIG contains declarative.
1237
1238         * tests/tests.pri:
1239         * tests/tests.pro:
1240
1241 2011-02-25  Gopal Raghavan  <gopal.1.raghavan@nokia.com>
1242
1243         Reviewed by Kenneth Rohde Christiansen.
1244
1245         [Qt] QML WebView inside a Flickable shows checkers pattern at startup
1246         https://bugs.webkit.org/show_bug.cgi?id=50222.
1247
1248         This patch fixes the checkerboard visible at startup even if preferredWidth and preferredHeight are not set.
1249
1250         * declarative/qdeclarativewebview.cpp:
1251         (QDeclarativeWebView::init):
1252         * tests/qdeclarativewebview: Added.
1253         * tests/qdeclarativewebview/qdeclarativewebview.pro: Added.
1254         * tests/qdeclarativewebview/resources: Added.
1255         * tests/qdeclarativewebview/resources/webviewtest.qml: Added.
1256         * tests/qdeclarativewebview/resources/webviewtestdefault.qml: Added.
1257         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Added.
1258         (tst_QDeclarativeWebView::initTestCase):
1259         (tst_QDeclarativeWebView::cleanupTestCase):
1260         (tst_QDeclarativeWebView::init):
1261         (tst_QDeclarativeWebView::cleanup):
1262         (tst_QDeclarativeWebView::preferredWidthTest):
1263         (tst_QDeclarativeWebView::preferredHeightTest):
1264         (tst_QDeclarativeWebView::preferredWidthDefaultTest):
1265         (tst_QDeclarativeWebView::preferredHeightDefaultTest):
1266         (tst_QDeclarativeWebView::checkNoErrors):
1267         * tests/tests.pri:
1268         * tests/tests.pro:
1269
1270 2011-02-24  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1271
1272         Reviewed by Andreas Kling.
1273
1274         [Qt] Revert the support for QNAM affined to a different thread.
1275         https://bugs.webkit.org/show_bug.cgi?id=55149
1276
1277         Qt 4.8 will have QNAM use its own thread internally by default,
1278         no need to keep this complexity in WebKit.
1279
1280         This mainly reverts:
1281         http://trac.webkit.org/changeset/73710
1282         http://trac.webkit.org/changeset/73712
1283
1284         * WebCoreSupport/FrameLoaderClientQt.cpp:
1285         (WebCore::FrameLoaderClientQt::download):
1286         * tests/qwebpage/tst_qwebpage.cpp:
1287
1288 2011-02-24  Sam Weinig  <sam@webkit.org>
1289
1290         Try to fix the Qt build.
1291
1292         * QtWebKit.pro:
1293
1294 2011-02-24  Peter Kasting  <pkasting@google.com>
1295
1296         Reviewed by Eric Seidel.
1297
1298         Drop the "U; " encryption level from the User Agent string.
1299         https://bugs.webkit.org/show_bug.cgi?id=54566
1300
1301         * Api/qwebpage.cpp:
1302         (QWebPage::userAgentForUrl):
1303
1304 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
1305
1306         Unreviewed, rolling out r79570.
1307         http://trac.webkit.org/changeset/79570
1308         https://bugs.webkit.org/show_bug.cgi?id=54874
1309
1310         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
1311         was not updated
1312
1313         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1314         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1315
1316 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
1317
1318         Reviewed by Alexey Proskuryakov.
1319
1320         DumpRenderTree should reset frame opener between tests.
1321         https://bugs.webkit.org/show_bug.cgi?id=54874
1322
1323         Added clearOpener method to DumpRenderTreeSupportQT.
1324
1325         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1326         (DumpRenderTreeSupportQt::clearOpener):
1327         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1328
1329 2011-02-24  Alexis Menard  <alexis.menard@openbossa.org>
1330
1331         Reviewed by Andreas Kling.
1332
1333         [Qt] tst_QWebView::setPalette(activeFG) fails
1334         https://bugs.webkit.org/show_bug.cgi?id=55029
1335
1336         This time it should be the proper fix. The window needs to be shown before we
1337         call activateWindow() otherwise there is no active windows for the application.
1338
1339         * tests/qwebview/tst_qwebview.cpp:
1340         (tst_QWebView::setPalette):
1341
1342 2011-02-24  Andras Becsi  <abecsi@webkit.org>
1343
1344         Reviewed by Laszlo Gombos.
1345
1346         [Qt] MinGW build fails to link
1347         https://bugs.webkit.org/show_bug.cgi?id=55050
1348
1349         Prepend the libraries of subcomponents instead of appending them
1350         to fix the library order according to the dependency of the libraries
1351
1352         * QtWebKit.pro: prepend libraries in the correct order
1353
1354 2011-02-23  Alexis Menard  <alexis.menard@openbossa.org>
1355
1356         Reviewed by Ariya Hidayat.
1357
1358         [Qt] tst_QWebView::setPalette(activeFG) fails
1359         https://bugs.webkit.org/show_bug.cgi?id=55029
1360
1361         Attempt to make the test more robust. By investigating with the bot virtual machine
1362         I discovered that the activation can take some time. In this patch we make sure that
1363         the active window we want to have is the same as the QApplication.
1364
1365         * tests/qwebview/tst_qwebview.cpp:
1366         (tst_QWebView::setPalette):
1367
1368 2011-02-23  Alexis Menard  <alexis.menard@openbossa.org>
1369
1370         Reviewed by Dan Bernstein.
1371
1372         [Qt]REGRESSION(r79167): It broke 3 Qt-API test cases
1373         http://trac.webkit.org/changeset/79167 refactored the way the bound size of
1374         the frame is handled. A new API setBoundsSize was added, we need to call it
1375         in addition to setFrameRect. I could call setBoundSize after setFrameRect but
1376         I thought It would be more elegant to use the resize method.
1377
1378         * Api/qwebpage.cpp:
1379         (QWebPage::setViewportSize):
1380
1381 2011-02-22  Fabrizio Machado  <fabrizio.machado@nokia.com>
1382
1383         Reviewed by Laszlo Gombos.
1384
1385         [Qt] Don't fall through case in variantToSetting() if qvariant.type() is Bool
1386         https://bugs.webkit.org/show_bug.cgi?id=54976
1387
1388         Test not needed.
1389         
1390         * WebCoreSupport/InspectorClientQt.cpp:
1391
1392 2011-02-22  Alexis Menard  <alexis.menard@openbossa.org>
1393
1394         Reviewed by Andreas Kling.
1395
1396         [Qt] QWebView ignores a palette set with QWebView::setPalette()
1397         https://bugs.webkit.org/show_bug.cgi?id=31742
1398
1399         Test case to check that the palette sets on the QWebView is taken
1400         into account.
1401
1402         * tests/qwebview/tst_qwebview.cpp:
1403         (tst_QWebView::setPalette_data):
1404         (tst_QWebView::setPalette):
1405
1406 2011-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1407
1408         Reviewed by Alexey Proskuryakov.
1409
1410         Drop the language tag part from the User Agent string
1411         https://bugs.webkit.org/show_bug.cgi?id=54560
1412
1413         * Api/qwebpage.cpp:
1414         (QWebPage::userAgentForUrl):
1415
1416         * tests/qwebpage/tst_qwebpage.cpp: Remove the userAgentLocaleChange
1417         test.
1418
1419 2011-02-22  Chang Shu  <cshu@webkit.org>
1420
1421         Reviewed by Csaba Osztrogonác.
1422
1423         [Qt] editing/deleting/5408255.html fails
1424         https://bugs.webkit.org/show_bug.cgi?id=54964
1425
1426         Move WebCore resource file to QtWebKit since they are referred in WebKit.
1427
1428         * QtWebKit.pro:
1429
1430 2011-02-22  Andras Becsi  <abecsi@webkit.org>
1431
1432         Reviewed by Csaba Osztrogonác.
1433
1434         [Qt] Redesign the build system
1435         https://bugs.webkit.org/show_bug.cgi?id=51339
1436
1437         Move inspector's resource files into the final build step to fix the layout test regression.
1438
1439         * QtWebKit.pro: Add inspector's reaource files.
1440
1441 2011-02-22  Andras Becsi  <abecsi@webkit.org>
1442
1443         Reviewed by Laszlo Gombos.
1444         Rubber-stamped by Csaba Osztrogonác.
1445
1446         [Qt] Redesign the build system
1447         https://bugs.webkit.org/show_bug.cgi?id=51339
1448
1449         The patch landed in r79320 didn't contain the cleanup
1450         which was already addressed in the last attachment.
1451
1452         * QtWebKit.pro: Move common LIB and CONFIG options to WebCore.pri.
1453
1454 2011-02-22  Andras Becsi  <abecsi@webkit.org>
1455
1456         Reviewed by Laszlo Gombos.
1457
1458         [Qt] Redesign the build system
1459         https://bugs.webkit.org/show_bug.cgi?id=51339
1460
1461         Part 2.
1462
1463         Build WebCore as a static library, compile the WebKit API and WebKit2 API
1464         in a final step and link to WebKit2, WebCore and JSC libraries to fix
1465         linking issues resulting from stripped away symbols.
1466
1467         * QtWebKit.pro: Added.
1468         Project file for the final build step.
1469
1470 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
1471
1472         Reviewed by Kent Tamura.
1473
1474         Rename Position::node() to Position::deprecatedNode()
1475         https://bugs.webkit.org/show_bug.cgi?id=54622
1476
1477         Replaced the call to node() by a call to containerNode() because the returned node is
1478         used to determine whether or not the selected contents are editable and such a check
1479         must be done against the container node.
1480
1481         * WebCoreSupport/EditorClientQt.cpp:
1482         (WebCore::EditorClientQt::handleKeyboardEvent):
1483
1484 2011-02-19  Charlie Reis  <creis@chromium.org>
1485
1486         Reviewed by Mihai Parparita.
1487
1488         Ensure loading has stopped in HistoryController::goToItem
1489         https://bugs.webkit.org/show_bug.cgi?id=54517
1490
1491         Add a FrameLoaderClient callback for whether to stop loading before goToItem.
1492
1493         Test: http/tests/navigation/forward-to-fragment-fires-onload.html
1494
1495         * WebCoreSupport/FrameLoaderClientQt.cpp:
1496         (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): Added.
1497         * WebCoreSupport/FrameLoaderClientQt.h:
1498
1499 2011-02-18  Fabrizio Machado  <fabrizio.machado@nokia.com>
1500
1501         Reviewed by Eric Seidel.
1502
1503         Remove reduntant checks.
1504         https://bugs.webkit.org/show_bug.cgi?id=54764
1505         
1506
1507         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1508         (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
1509         * WebCoreSupport/NotificationPresenterClientQt.cpp:
1510         (WebCore::NotificationPresenterClientQt::toPage):
1511
1512 2011-02-18  Csaba Osztrogonác  <ossy@webkit.org>
1513
1514         Unreviewed.
1515
1516         [Qt] Buildfix for platforms with geolocation disabled.
1517
1518         * Api/qwebpage.cpp: Add the missing guard.
1519
1520 2011-02-18  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1521
1522         Reviewed by Kenneth Rohde Christiansen.
1523
1524         [Qt] Implement client based geolocation for qtport
1525         https://bugs.webkit.org/show_bug.cgi?id=42629
1526
1527         Implements client based geolocation for qtwebkit.
1528         New client based geolocation contains permission API's as well,
1529         so removed the implementation from ChromeClientQt.cpp. 
1530
1531         * Api/qwebpage.cpp:
1532         (QWebPagePrivate::QWebPagePrivate):
1533         * WebCoreSupport/ChromeClientQt.cpp:
1534         * WebCoreSupport/ChromeClientQt.h:
1535         (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
1536         (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
1537         * WebCoreSupport/GeolocationClientQt.cpp: Added.
1538         (WebCore::GeolocationClientQt::GeolocationClientQt):
1539         (WebCore::GeolocationClientQt::~GeolocationClientQt):
1540         (WebCore::GeolocationClientQt::geolocationDestroyed):
1541         (WebCore::GeolocationClientQt::positionUpdated):
1542         (WebCore::GeolocationClientQt::startUpdating):
1543         (WebCore::GeolocationClientQt::stopUpdating):
1544         (WebCore::GeolocationClientQt::setEnableHighAccuracy):
1545         (WebCore::GeolocationClientQt::requestPermission):
1546         (WebCore::GeolocationClientQt::cancelPermissionRequest):
1547         * WebCoreSupport/GeolocationClientQt.h: Added.
1548         (WebCore::GeolocationClientQt::lastPosition):
1549
1550 2011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
1551
1552         Reviewed by Adam Roben.
1553
1554         HTML5 <details> and <summary>: localized text
1555         https://bugs.webkit.org/show_bug.cgi?id=54260
1556
1557         The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
1558         provide the default label to be used by a <details> tag that has no <summary> child.
1559
1560         * WebCoreSupport/WebPlatformStrategies.cpp:
1561         (WebPlatformStrategies::defaultDetailsSummaryText):
1562         * WebCoreSupport/WebPlatformStrategies.h:
1563
1564 2011-02-17  Hui Huang  <hui.2.huang@nokia.com>
1565
1566         Reviewed by Laszlo Gombos.
1567
1568         The URL of HTML5 Video Element is percent encoded at websites such as youtube.
1569         It is percent encoded again by QUrl constructor QUrl::QUrl(QString). This causes
1570         the HTTP GET request for the video to be rejected by the service provider. 
1571         https://bugs.webkit.org/show_bug.cgi?id=53973.
1572
1573         The bug is fixed by constructing QUrl from the encoded URL in 
1574         MediaPlayerPrivateQt::commitLoad. 
1575
1576         New test function tst_QWebPage::loadHtml5Video() is added to load HTML content with
1577         HTML5 Video element. A new public method DumpRenderTreeSupportQt::mediaContentUrlByElementId
1578         is added to retrieve the URL of the media content from WebCore MediaPlayerPrivateQt.
1579         A new macro ENABLE_QT_MULTIMEDIA is introduced in tests.pri to make sure that the test
1580         is skipped if Qt Multimedia is not available.
1581
1582         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1583         (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
1584         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1585         * tests/qwebpage/tst_qwebpage.cpp:
1586         (tst_QWebPage::loadHtml5Video):
1587         * tests/tests.pri:
1588
1589 2011-02-17  Andreas Kling  <kling@webkit.org>
1590
1591         Reviewed by Antti Koivisto.
1592
1593         [Qt] Crash when calling QWebFrame::setUrl() while a previous load has pending requests
1594         https://bugs.webkit.org/show_bug.cgi?id=49216
1595
1596         * tests/qwebframe/tst_qwebframe.cpp:
1597
1598 == Rolled over to ChangeLog-2011-02-16 ==