19cbc1f8eb19900efd93e7d8e5b087229eb61daf
[WebKit-https.git] / Source / WebKit / qt / ChangeLog
1 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
2
3         Reviewed by Andreas Kling.
4
5         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
6         https://bugs.webkit.org/show_bug.cgi?id=57087
7
8         * QtWebKit.pro: we can now enable QT_ASCII_CAST_WARNINGS
9         * tests/tests.pri: we do not require QT_ASCII_CAST_WARNINGS for tests
10         since they are applications, not libraries.
11
12 2011-03-28  Andras Becsi  <abecsi@webkit.org>
13
14         Reviewed by Csaba Osztrogonác.
15
16         [Qt] QtWebKit does not link with --3d-canvas using MinGW
17         https://bugs.webkit.org/show_bug.cgi?id=57225
18
19         * QtWebKit.pro: Append the OpenGL libraries on MinGW so it can resolve symbols.
20
21 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
22
23         Reviewed by Andreas Kling.
24
25         REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
26         https://bugs.webkit.org/show_bug.cgi?id=57183
27
28         Windows buildfix after r82065.
29
30         * Api/DerivedSources.pro: Readding escaping on Windows platforms.
31
32 2011-03-27  Andreas Kling  <kling@webkit.org>
33
34         Fix build warning about IconDatabaseClient.h (wrong path.)
35
36         * QtWebKit.pro:
37
38 2011-03-27  Andreas Kling  <kling@webkit.org>
39
40         Reviewed by Kenneth Rohde Christiansen.
41
42         [Qt] Support for CSS color and background-color properties on select element's dropdown list
43         https://bugs.webkit.org/show_bug.cgi?id=51627
44
45         Extend the QWebSelectData interface with background and foreground colors
46         for the whole menu, as well as per-item. Hook it up to the PopupMenuStyle
47         getters in RenderMenuList.
48
49         * Api/qwebkitplatformplugin.h:
50         * WebCoreSupport/PopupMenuQt.cpp:
51         (SelectData::backgroundColor):
52         (SelectData::foregroundColor):
53         (SelectData::itemBackgroundColor):
54         (SelectData::itemForegroundColor):
55         * WebCoreSupport/QtFallbackWebPopup.cpp:
56         (WebCore::QtFallbackWebPopup::show):
57         (WebCore::QtFallbackWebPopup::populate):
58
59 2011-03-27  Yi Shen  <yi.4.shen@nokia.com>
60
61         Reviewed by Andreas Kling.
62
63         [Qt][Symbian] Fix Api test failure -- microFocusCoordinates
64         https://bugs.webkit.org/show_bug.cgi?id=57108
65
66         Since the canvas is not self-closing tag, we need to add '</canvas>'. 
67
68         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
69         (tst_QGraphicsWebView::microFocusCoordinates):
70         * tests/qwebview/tst_qwebview.cpp:
71         (tst_QWebView::microFocusCoordinates):
72
73 2011-03-27  Kwang Yul Seo  <skyul@company100.net>
74
75         Reviewed by Eric Seidel.
76
77         [Qt] Build fix: Define WTF_USE_TEXTURE_MAPPER=1 when CONFIG contains texmap.
78         https://bugs.webkit.org/show_bug.cgi?id=57143
79
80         Qt WebKit uses USE(TEXTURE_MAPPER) guard. Check texmap in CONFIG and
81         define WTF_USE_TEXTURE_MAPPER=1.
82
83         * QtWebKit.pro:
84
85 2011-03-27  Andreas Kling  <kling@webkit.org>
86
87         Reviewed by Benjamin Poulain.
88
89         REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
90         https://bugs.webkit.org/show_bug.cgi?id=57183
91
92         The convenience <QtWebKit> header would include \<QtNetwork/QtNetwork\>
93         which was due to the outputting code previously being wrapped in eval().
94
95         * Api/DerivedSources.pro:
96
97 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
98
99         Reviewed by Andreas Kling.
100
101         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
102         https://bugs.webkit.org/show_bug.cgi?id=57087
103
104         Use explicit conversion for string to avoid depending on the default codec
105         installed by the user code.
106
107         * Api/qwebkitversion.cpp:
108         (qWebKitVersion):
109         * Api/qwebpage.cpp:
110         (QWebPagePrivate::dynamicPropertyChangeEvent):
111         (QWebPage::javaScriptConsoleMessage):
112         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
113         (convertToPropertyName):
114         (DumpRenderTreeSupportQt::setEditingBehavior):
115         (DumpRenderTreeSupportQt::plainText):
116         * WebCoreSupport/EditorClientQt.cpp:
117         (dumpRange):
118         * WebCoreSupport/FrameLoaderClientQt.cpp:
119         (drtDescriptionSuitableForTestResult):
120         (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
121         * WebCoreSupport/InspectorClientQt.cpp:
122         (WebCore::InspectorClientQt::openInspectorFrontend):
123         * WebCoreSupport/InspectorServerQt.cpp:
124         (WebCore::parseWebSocketChallengeNumber):
125         (WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
126
127 2011-03-26  Andreas Kling  <kling@webkit.org>
128
129         Reviewed by Kenneth Rohde Christiansen.
130
131         [Qt] QWebFrame::iconChanged() not emitted when icon is cached but not yet loaded
132         https://bugs.webkit.org/show_bug.cgi?id=57157
133
134         Add an IconDatabaseClient for the Qt port to ensure that QWebFrame::iconChanged()
135         is always emitted when appropriate.
136
137         * QtWebKit.pro: Add new files.
138
139         * WebCoreSupport/IconDatabaseClientQt.h: Added.
140         * WebCoreSupport/IconDatabaseClientQt.cpp: Added.
141         (WebCore::IconDatabaseClientQt::instance):
142         (WebCore::IconDatabaseClientQt::IconDatabaseClientQt):
143         (WebCore::IconDatabaseClientQt::~IconDatabaseClientQt):
144         (WebCore::IconDatabaseClientQt::performImport):
145         (WebCore::IconDatabaseClientQt::didRemoveAllIcons):
146         (WebCore::IconDatabaseClientQt::didImportIconURLForPageURL):
147         (WebCore::IconDatabaseClientQt::didImportIconDataForPageURL):
148         (WebCore::IconDatabaseClientQt::didChangeIconForPageURL):
149         (WebCore::IconDatabaseClientQt::didFinishURLImport):
150
151         * WebCoreSupport/FrameLoaderClientQt.h:
152         * WebCoreSupport/FrameLoaderClientQt.cpp:
153         (WebCore::FrameLoaderClientQt::registerForIconNotification):
154         (WebCore::FrameLoaderClientQt::onIconLoadedForPageURL): New slot connected
155         to the IconDatabaseClientQt::iconLoadedForPageURL() signal. This emits the
156         QWebFrame::iconChanged() signal when the IconDatabases finishes loading
157         a cached favicon for the frame's URL.
158
159         * Api/qwebsettings.cpp:
160         (QWebSettings::setIconDatabasePath): Make sure that IconDatabaseClientQt is
161         instantiated. An IconDatabaseClient has to be registered before the IconDatabase
162         spawns its reader thread.
163
164 2011-03-25  Andy Estes  <aestes@apple.com>
165
166         Reviewed by Adele Peterson.
167
168         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
169         https://bugs.webkit.org/show_bug.cgi?id=49016
170
171         Update objectContentType() implementation to handle the
172         shouldPreferPlugInsForImages flag.
173
174         * WebCoreSupport/FrameLoaderClientQt.cpp:
175         (WebCore::FrameLoaderClientQt::objectContentType):
176         * WebCoreSupport/FrameLoaderClientQt.h:
177
178 2011-03-25  Chang Shu  <cshu@webkit.org>
179
180         Reviewed by Ryosuke Niwa.
181
182         rename Node::isContentEditable and all call sites to rendererIsEditable
183         https://bugs.webkit.org/show_bug.cgi?id=54290
184
185         This is part of the effort to separate JS API HTMLElement isContentEditable from
186         internal Node::rendererIsEditable.
187
188         * WebCoreSupport/EditorClientQt.cpp:
189         (WebCore::EditorClientQt::handleKeyboardEvent):
190
191 2011-03-25  Alexis Menard  <alexis.menard@openbossa.org>
192
193         Reviewed by Andreas Kling.
194
195         [Qt] The keyboard shortcuts during fullscreen playback do not work.
196         https://bugs.webkit.org/show_bug.cgi?id=57095
197
198         We need to explicitely set the focus on the widget in order to receive the keyboard events.
199
200         * WebCoreSupport/FullScreenVideoWidget.cpp:
201         (WebCore::FullScreenVideoWidget::show):
202
203 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
204
205         Unreviewed, rolling out r81916 and r81917.
206         http://trac.webkit.org/changeset/81916
207         http://trac.webkit.org/changeset/81917
208         https://bugs.webkit.org/show_bug.cgi?id=57071
209
210         broke a test on platforms that do not have QuickTime installed
211         (Requested by estes on #webkit).
212
213         * WebCoreSupport/FrameLoaderClientQt.cpp:
214         (WebCore::FrameLoaderClientQt::objectContentType):
215         * WebCoreSupport/FrameLoaderClientQt.h:
216
217 2011-03-24  Andy Estes  <aestes@apple.com>
218
219         Reviewed by Darin Adler.
220
221         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
222         https://bugs.webkit.org/show_bug.cgi?id=49016
223
224         Update objectContentType() implementation to handle the
225         shouldPreferPlugInsForImages flag.
226
227         * WebCoreSupport/FrameLoaderClientQt.cpp:
228         (WebCore::FrameLoaderClientQt::objectContentType):
229         * WebCoreSupport/FrameLoaderClientQt.h:
230
231 2011-03-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
232
233         Reviewed by Kenneth Rohde Christiansen.
234
235         [Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles
236         https://bugs.webkit.org/show_bug.cgi?id=40884
237
238         Add tests and benchmarks for the software fallback of WebGL.
239
240         * tests/benchmarks/webgl/10000_triangles.html: Added.
241         * tests/benchmarks/webgl/tst_webgl.cpp: Added.
242         (GraphicsView::GraphicsView):
243         (GraphicsView::resizeEvent):
244         (tst_WebGlPerformance::init):
245         (tst_WebGlPerformance::cleanup):
246         (tst_WebGlPerformance::benchSoftwareFallbackRgb16):
247         (tst_WebGlPerformance::benchSoftwareFallbackRgb32):
248         (tst_WebGlPerformance::benchSoftwareFallbackArgb32):
249         (tst_WebGlPerformance::benchSoftwareFallbackArgb32Premultiplied):
250         (tst_WebGlPerformance::benchmarkFrameRenderingOnImage):
251         * tests/benchmarks/webgl/tst_webgl.qrc: Added.
252         * tests/benchmarks/webgl/webgl.pro: Added.
253         * tests/qgraphicswebview/qgraphicswebview.pro:
254         * tests/qgraphicswebview/resources/pointing_right.html: Added.
255         * tests/qgraphicswebview/resources/pointing_up.html: Added.
256         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
257         (compareImagesFuzzyPixelCount):
258         (GraphicsView::GraphicsView):
259         (tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation):
260         (tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation):
261         (tst_QGraphicsWebView::compareCanvasToImage):
262         * tests/qgraphicswebview/tst_qgraphicswebview.qrc:
263         * tests/tests.pro:
264
265 2011-03-24  Kristian Amlie  <kristian.amlie@nokia.com>
266
267         Reviewed by Benjamin Poulain.
268
269         Avoided ASCII-cast warnings for WebKit.
270
271         Normally they won't be enabled anyway, but if you build webkit from
272         within the Qt mother repository it will pick up Qt's default build
273         settings, which do enable it. We need to disable them because
274         warnings are treated as errors and there are way too many of them in
275         the WebKit code.
276
277         [Qt] Avoid ASCII-cast warnings for WebKit.
278         https://bugs.webkit.org/show_bug.cgi?id=57016
279
280         * QtWebKit.pro:
281
282 2011-03-24  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
283
284         Reviewed by Benjamin Poulain.
285
286         [Qt] Resetting the URL property of a QWebView results in the current directory being set as file::-type URL
287         https://bugs.webkit.org/show_bug.cgi?id=29595
288
289         Qt Designer resets the URL by setting it to QUrl(). The bug was caused by
290         ensureAbsoluteUrl() helper function treating the empty URL as a relative URL, and
291         prepending the current directory.
292
293         By fixing this, now we can pass QUrl() invalid and empty URLs to WebCore layer, which
294         will end up loading "about:blank", but keeping it as a requested URL.
295
296         This patch also simplifies the logic for requestedUrl(), since m_lastRequestedUrl
297         is filled for the loaded URLs as well, we can use it in every case.
298
299         Three new autotests were added, to better cover the expected behavior of setting
300         the QUrl() in a QWebFrame.
301
302         * Api/qwebframe.cpp:
303         (ensureAbsoluteUrl): do not treat invalid URLs (empty included) as relative.
304         (QWebFrame::requestedUrl): always use m_lastRequestedUrl.
305
306         * WebCoreSupport/FrameLoaderClientQt.cpp:
307         (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): do not clear m_lastRequestedUrl
308         anymore, since we always rely on it even for loaded frames.
309
310         * tests/qwebframe/tst_qwebframe.cpp:
311         (tst_QWebFrame::setUrlToEmpty): verify the behavior of setting empty URLs. This includes
312         the reduction of the bug report.
313         (tst_QWebFrame::setUrlToInvalid): setting invalid, but not necessarily empty, URLs.
314         (tst_QWebFrame::setUrlHistory): to verify how setting empty URLs affect history.
315
316 2011-03-23  Brady Eidson  <beidson@apple.com>
317
318         Reviewed by Sam Weinig.
319
320         Change IconDatabase opening to allow for arbitrary filenames
321         https://bugs.webkit.org/show_bug.cgi?id=56977
322
323         * Api/qwebsettings.cpp:
324         (QWebSettings::setIconDatabasePath):
325
326 2011-03-23  Aparna Nandyal  <aparna.nand@wipro.com>
327
328         Reviewed by Andreas Kling.
329
330         [Qt] QtWebKit rendering problem when maximizing and doing a back
331         https://bugs.webkit.org/show_bug.cgi?id=56669
332
333         Added an auto test.
334         Patch by Alexis Menard < alexis.menard@nokia.com> on 2011-03-21
335  
336         * tests/qwebview/tst_qwebview.cpp:
337         (tst_QWebView::rendering):
338
339 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
340
341         Reviewed by Pavel Feldman.
342
343         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
344         https://bugs.webkit.org/show_bug.cgi?id=56843
345
346         * WebCoreSupport/InspectorClientQt.cpp:
347         (WebCore::InspectorClientQt::openInspectorFrontend):
348
349 2011-03-22  Andrew Wason  <rectalogic@rectalogic.com>
350
351         Reviewed by Benjamin Poulain.
352
353         [Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
354         https://bugs.webkit.org/show_bug.cgi?id=54138
355
356         * tests/qwebpage/tst_qwebpage.cpp:
357         (webGLScreenshotWithoutView):
358         (tst_QWebPage::acceleratedWebGLScreenshotWithoutView):
359         (tst_QWebPage::unacceleratedWebGLScreenshotWithoutView):
360          Render a QWebPage (with and without accelerated compositing)
361          with a WebGL context that has no owning view.  Shouldn't crash.
362
363 2011-03-21  Chang Shu  <cshu@webkit.org>
364
365         Reviewed by Alexey Proskuryakov.
366
367         REGRESSION (r79953): Can't type in MS Outlook 2011
368         https://bugs.webkit.org/show_bug.cgi?id=56665
369
370         r79953 removed the WebView level editablity which is persistent no matter whether
371         underlying document itself is changed and editability gets lost. The resolution is to
372         set this WebView editable value to WebCore. This avoids the callback from WebCore to
373         WebKit which was the main goal in r79953 to improve performance.
374
375         * Api/qwebpage.cpp:
376         (QWebPage::setContentEditable):
377         (QWebPage::isContentEditable):
378
379 2011-03-19  Andreas Kling  <kling@webkit.org>
380
381         Reviewed by Benjamin Poulain.
382
383         [Qt] Remove support for Qt 4.6
384         https://bugs.webkit.org/show_bug.cgi?id=56712
385
386         * Api/qwebframe.cpp:
387         (QWebFrame::load):
388         * Api/qwebpage.cpp:
389         (QWebPagePrivate::QWebPagePrivate):
390         * Api/qwebsettings.cpp:
391         (QWebSettings::QWebSettings):
392         * WebCoreSupport/GeolocationClientQt.cpp:
393         (WebCore::GeolocationClientQt::positionUpdated):
394
395 2011-03-19  Andreas Kling  <kling@webkit.org>
396
397         Reviewed by Antonio Gomes.
398
399         [Qt][Doc] QWebPage::unsupportedContent() passes ownership of the QNetworkReply
400         https://bugs.webkit.org/show_bug.cgi?id=56711
401
402         Document the fact that when unsupportedContent(QNetworkReply*) is emitted,
403         ownership of the reply is transferred to the receiving slot.
404
405         * Api/qwebpage.cpp:
406
407 2011-03-17  Brady Eidson  <beidson@apple.com>
408
409         Reviewed by Sam Weinig.
410
411         https://bugs.webkit.org/show_bug.cgi?id=56425
412         More groundwork for WebKit2 IconDatabase
413
414         Update already-used function names:
415         * Api/qwebhistory.cpp:
416         (QWebHistoryItem::icon):
417         * Api/qwebsettings.cpp:
418         (QWebSettings::iconForUrl):
419
420 2011-03-18  Alexis Menard  <alexis.menard@openbossa.org>
421
422         Reviewed by Benjamin Poulain.
423
424         [Qt] console.log not being exposed to QmlViewer
425         https://bugs.webkit.org/show_bug.cgi?id=56536
426
427         The documentation is bogus the feature does not exist.
428
429         * declarative/qdeclarativewebview.cpp:
430
431 2011-03-17  Andreas Kling  <kling@webkit.org>
432
433         Reviewed by Kenneth Rohde Christiansen.
434
435         [Qt] QML WebView emits iconChanged() when the page title changes
436         https://bugs.webkit.org/show_bug.cgi?id=56570
437
438         * declarative/qdeclarativewebview.cpp:
439         (QDeclarativeWebView::setPage): Don't forward the frame's titleChanged
440         signal to the view's iconChanged signal.
441
442 2011-03-17  Alexis Menard  <alexis.menard@openbossa.org>
443
444         Reviewed by Benjamin Poulain.
445
446         [Qt] Videos look ugly when using QGraphicsWebView.
447         https://bugs.webkit.org/show_bug.cgi?id=56580
448
449         We need to set QPainter::SmoothPixmapTransform on the painter for a proper rendering of the video.
450         QWebView does it but not QGraphicsWebView because the API does not exist. This patch is fixing it
451         by introducing the same API as QWebView to control the renderHints of the item. Unlike QWebView
452         QGraphicsWebView inherits the painter from QGraphicsScene and those flags are not set. This patch
453         ensure that before rendering the item we add QPainter::SmoothPixmapTransform and QPainter::TextAntialiasing
454         in addition of what could be set on the painter. In order to not break the rendering of all the items in the
455         scene we set back the painter to its original state when QGraphicsWebView is rendered.
456
457         * Api/qgraphicswebview.cpp:
458         (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
459         (QGraphicsWebView::paint):
460         (QGraphicsWebView::renderHints):
461         (QGraphicsWebView::setRenderHints):
462         (QGraphicsWebView::setRenderHint):
463         * Api/qgraphicswebview.h:
464         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
465         (tst_QGraphicsWebView::renderHints):
466
467 2011-03-16  Joseph Pecoraro  <joepeck@webkit.org>
468
469         Reviewed by Kenneth Rohde Christiansen.
470
471         Viewport no longer allows an auto value for "user-scalable"
472         https://bugs.webkit.org/show_bug.cgi?id=55416
473
474         Make the default value for userScalable be true.
475
476         * Api/qwebpage.cpp:
477         (QWebPage::viewportAttributesForSize):
478         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
479         (DumpRenderTreeSupportQt::viewportAsText): update test output to include userScalable.
480
481 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
482
483         Reviewed by Darin Adler.
484
485         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
486         info into the headers rather than in export symbol definition files, but disable it on 
487         all platforms initially so we can deal with port build issues one port at a time.
488         
489         https://bugs.webkit.org/show_bug.cgi?id=27551
490
491         * WebCoreSupport/GeolocationClientQt.cpp:
492         * WebCoreSupport/PopupMenuQt.cpp:
493
494 2011-03-14  Brady Eidson  <beidson@apple.com>
495
496         Reviewed by Anders Carlsson.
497
498         https://bugs.webkit.org/show_bug.cgi?id=56320
499         Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
500
501         * Api/qwebhistory.cpp:
502         (QWebHistoryItem::icon): Use IconDatabase directly.
503
504 2011-03-11  Brady Eidson  <beidson@apple.com>
505
506         Reviewed by attempt at build fix!
507
508         https://bugs.webkit.org/show_bug.cgi?id=56216
509         Fix the Qt build following the same pattern of the patch.
510
511         * Api/qwebsettings.cpp:
512         (QWebSettings::setIconDatabasePath): Call the static method via IconDatabase:: and not via iconDatabase()
513
514 2011-03-11  Alexis Menard  <alexis.menard@openbossa.org>
515
516         Reviewed by Ariya Hidayat.
517
518         [Qt] Entering fullscreen and leaving it may hide the cursor of the application.
519         https://bugs.webkit.org/show_bug.cgi?id=56181
520
521         We need to stop the auto hide cursor timer when closing the widget otherwise the timer
522         might get fired and therefore hide the cursor even when the fullscreen widget is closed.
523
524         * WebCoreSupport/FullScreenVideoWidget.cpp:
525         (WebCore::FullScreenVideoWidget::closeEvent):
526
527 2011-03-10  David Boddie <david.boddie@nokia.com>
528
529         Reviewed by Andreas Kling.
530
531         Fixed a qdoc warning and terminology (WebKit instead of Webkit).
532         https://bugs.webkit.org/show_bug.cgi?id=55756
533
534         * Api/qwebhistoryinterface.cpp:
535
536 2011-03-10  Andreas Kling  <kling@webkit.org>
537
538         Unreviewed build fix after r80774.
539
540         QML property versioning is introduced in Qt 4.7.3, not 4.7.2.
541         See also: http://bugreports.qt.nokia.com/browse/QTBUG-13451
542
543         * declarative/plugin.cpp:
544         (WebKitQmlPlugin::registerTypes):
545         * declarative/qdeclarativewebview.cpp:
546         * declarative/qdeclarativewebview_p.h:
547         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
548
549 2011-03-10  Alexis Menard  <alexis.menard@openbossa.org>
550
551         Reviewed by Andreas Kling.
552
553         [Qt] QtDeclarative Webview element has a fixed white background
554         https://bugs.webkit.org/show_bug.cgi?id=40918
555
556         Implement a way to change the background color of the WebView QML element.
557         This feature is activated for QtWebKit 1.1 version of the plugin.
558
559         * declarative/plugin.cpp:
560         (WebKitQmlPlugin::registerTypes):
561         * declarative/qdeclarativewebview.cpp:
562         (QDeclarativeWebView::backgroundColor):
563         (QDeclarativeWebView::setBackgroundColor):
564         * declarative/qdeclarativewebview_p.h:
565         * tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml: Added.
566         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
567         (tst_QDeclarativeWebView::backgroundColor):
568         * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
569
570 2011-03-10  Stanislav Paltis  <Stanislav.Paltis@nokia.com>
571
572         Reviewed by Laszlo Gombos.
573
574         [Qt] MemoryCache deadDecodedDataDeletionInterval is not exposed for client's usage
575         https://bugs.webkit.org/show_bug.cgi?id=55945
576         
577         Added handling of dynamic/runtime property _q_deadDecodedDataDeletionInterval to 
578         set interval used to trigger when decoded data in dead list of object cache will 
579         be purged from object cache. 
580
581         * Api/qwebpage.cpp:
582         (QWebPagePrivate::dynamicPropertyChangeEvent):
583
584 2011-03-10  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
585
586         Reviewed by Antonio Gomes.
587
588         Simplify how QWebFrame::requestedUrl() is obtained
589         https://bugs.webkit.org/show_bug.cgi?id=55842
590
591         When a load starts, store the requested URL until we know that it'll be
592         available for us in the document loader -- after load finished.
593
594         The existing auto tests cover the three different code paths in
595         requestedUrl() and the new code passes the autotests. In each of those
596         cases, we looked for the information in a different place, but in all
597         of them, dispatchDidStartProvisionalLoad was called.
598
599         This simplification will be useful to fix bug 32723. The way requestedUrl()
600         is implementent, we can't use it as a fallback for url() when the setUrl()
601         was called with an invalid URL.
602
603         * Api/qwebframe.cpp:
604         (QWebFrame::requestedUrl):
605         * WebCoreSupport/FrameLoaderClientQt.cpp:
606         (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
607         (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
608         * WebCoreSupport/FrameLoaderClientQt.h:
609         (WebCore::FrameLoaderClientQt::lastRequestedUrl):
610
611 2011-03-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
612
613         Reviewed by Kenneth Rohde Christiansen.
614
615         Tiled backing store's delegated scroll request uses incorrect convention
616         https://bugs.webkit.org/show_bug.cgi?id=56011
617
618         Adapt internal API to match the change from delta to point on the
619         WebCore side, and convert the point to a delta for the public API.
620
621         * WebCoreSupport/ChromeClientQt.cpp:
622         (WebCore::ChromeClientQt::delegatedScrollRequested):
623         * WebCoreSupport/ChromeClientQt.h:
624
625 2011-03-09  Peter Kasting  <pkasting@google.com>
626
627         Reviewed by Mihai Parparita.
628
629         Unify Windows version checks.
630         https://bugs.webkit.org/show_bug.cgi?id=55979
631
632         * Api/qwebpage.cpp:
633         (QWebPage::userAgentForUrl):
634
635 2011-03-07  Sam Weinig  <sam@webkit.org>
636
637         Reviewed by Anders Carlsson.
638
639         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
640         https://bugs.webkit.org/show_bug.cgi?id=55827
641
642         Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
643         and pass the entire response, instead of just the MIMEType.
644
645         * WebCoreSupport/FrameLoaderClientQt.cpp:
646         (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
647         * WebCoreSupport/FrameLoaderClientQt.h:
648
649 2011-03-05  Qi Zhang  <qi.2.zhang@nokia.com>
650
651         Reviewed by Laszlo Gombos.
652
653         [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
654         https://bugs.webkit.org/show_bug.cgi?id=48636
655
656         Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.
657
658         * Api/qwebpage.cpp:
659         (QWebPage::userAgentForUrl):
660
661 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
662
663         Reviewed by Kenneth Rohde Christiansen.
664
665         [QT] Implement mock client-based geolocation for layout testing
666         https://bugs.webkit.org/show_bug.cgi?id=54334
667
668         Implement layout testing for Client-Based geolocation. If drt_run is set 
669         then create mock geolocationClient and update the same with controller.
670
671         * Api/qwebpage.cpp:
672         (QWebPagePrivate::QWebPagePrivate):
673         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
674         (DumpRenderTreeSupportQt::mockGeolocationReset):
675         (DumpRenderTreeSupportQt::setMockGeolocationPermission):
676         (DumpRenderTreeSupportQt::setMockGeolocationPosition):
677         (DumpRenderTreeSupportQt::setMockGeolocationError):
678         * WebCoreSupport/DumpRenderTreeSupportQt.h:
679         * WebCoreSupport/GeolocationClientQt.cpp:
680         (WebCore::GeolocationClientQt::GeolocationClientQt):
681         * WebCoreSupport/GeolocationClientQt.h:
682
683 2011-03-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
684
685         Reviewed by Kenneth Rohde Christiansen.
686
687         [Qt] QWebFrame::setUrl works only from second time if url fragment is present
688         https://bugs.webkit.org/show_bug.cgi?id=32723
689
690         Create an auto-test for Qt based on the bug description.
691
692         * tests/qwebframe/tst_qwebframe.cpp: add setUrlWithFragment() test.
693
694 2011-03-03  Brady Eidson  <beidson@apple.com>
695
696         Reviewed by Darin Adler.
697
698         https://bugs.webkit.org/show_bug.cgi?id=55721
699         Global IconDatabase should be returned by reference, not as a pointer
700
701         * Api/qwebsettings.cpp:
702         (QWebSettings::setIconDatabasePath):
703         (QWebSettings::iconDatabasePath):
704         (QWebSettings::clearIconDatabase):
705         (QWebSettings::iconForUrl):
706
707 2011-03-03  Alexey Proskuryakov  <ap@apple.com>
708
709         Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included
710         via ChromeClient.h
711
712         * WebCoreSupport/ChromeClientQt.h:
713
714 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
715
716         Reviewed by Darin Adler.
717
718         REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
719         https://bugs.webkit.org/show_bug.cgi?id=55633
720         <rdar://problem/8963023>
721
722         * WebCoreSupport/ChromeClientQt.cpp (WebCore::ChromeClientQt::keyboardUIMode):
723         * WebCoreSupport/ChromeClientQt.h:
724         Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since
725         this platform doesn't observe or have full keyboard access state.
726
727 2011-03-03  Alexis Menard  <alexis.menard@openbossa.org>
728
729         Reviewed by Andreas Kling.
730
731         [Qt] QGraphicsWebView should use updateMicroFocus() of QGraphicsItem
732         https://bugs.webkit.org/show_bug.cgi?id=55568
733
734         We should use updateMicroFocus() from QGraphicsItem rather than the implementation
735         in QGraphicsWebView. _q_updateMicroFocus was added when QGraphicsItem didn't have the feature.
736         In Qt 4.7, updateMicroFocus was added, let's use it, then we can benefit of all bug fixing done
737         in QGraphicsItem.
738
739         * Api/qgraphicswebview.cpp:
740         (QGraphicsWebView::setPage):
741         * Api/qgraphicswebview.h:
742
743 2011-03-03  Peter Kasting  <pkasting@google.com>
744
745         Reviewed by James Robinson.
746
747         Drop redundant "Windows; " from the Windows-specific User Agent string.
748         https://bugs.webkit.org/show_bug.cgi?id=54567
749
750         * Api/qwebpage.cpp:
751         (QWebPage::userAgentForUrl):
752
753 2011-03-01  Brian Weinstein  <bweinstein@apple.com>
754
755         Reviewed by Adam Roben.
756
757         Part of WebKit2: Need a way to send notifications to client when cookies change
758         https://bugs.webkit.org/show_bug.cgi?id=55427
759         <rdar://problem/9056027>
760         
761         Add stubs for CookiesStrategy on Qt WebKit1.
762
763         * WebCoreSupport/WebPlatformStrategies.cpp:
764         (WebPlatformStrategies::createCookiesStrategy):
765         (WebPlatformStrategies::notifyCookiesChanged):
766         * WebCoreSupport/WebPlatformStrategies.h:
767
768 2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>
769
770         Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.
771
772         * Api/qwebpage.cpp:
773         (QWebPage::viewportAttributesForSize):
774         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
775         (DumpRenderTreeSupportQt::viewportAsText):
776
777 2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>
778
779         Reviewed by Kenneth Rohde Christiansen.
780
781         Viewport Warning/Error Messages Are Now Inaccurate
782         https://bugs.webkit.org/show_bug.cgi?id=53707
783
784         * Api/qwebpage.cpp:
785         (QWebPage::viewportAttributesForSize): pass a Document into computeViewportAttributes for warnings to be reported to.
786         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
787         (DumpRenderTreeSupportQt::viewportAsText): pass a Document into computeViewportAttributes for warnings to be reported to.
788
789 2011-03-01  Andras Becsi  <abecsi@webkit.org>
790
791         Reviewed by Csaba Osztrogonác.
792
793         [Qt] Clean up the project files and move common options to WebKit.pri.
794
795         * QtWebKit.pro: Move common options to WebKit.pri.
796
797 2011-03-01  Aparna Nandyal  <aparna.nand@wipro.com>
798
799         Reviewed by Simon Hausmann.
800
801         [Qt]tst_QWebPage::backActionUpdate fails when there is not network connection
802         https://bugs.webkit.org/show_bug.cgi?id=55319
803
804         The test case required internet connection to be able to connect to
805         google.com. Added new html file which refers to local html file.
806
807         * tests/qwebpage/resources/content.html: Added.
808         * tests/qwebpage/resources/frame_c.html: Added.
809         * tests/qwebpage/resources/framedindex.html: Added.
810         * tests/qwebpage/tst_qwebpage.cpp:
811         (tst_QWebPage::backActionUpdate):
812         * tests/qwebpage/tst_qwebpage.qrc:
813
814 2011-02-25 Steve Block <steveblock@google.com>
815
816         Reviewed by Jeremy Orlow.
817
818         Bridge.h should not include BridgeJSC.h
819         https://bugs.webkit.org/show_bug.cgi?id=55212
820
821         Include BridgeJSC.h directly instead.
822
823         * Api/qwebframe.cpp:
824
825 2011-02-28  Chang Shu  <cshu@webkit.org>
826
827         Reviewed by Ryosuke Niwa.
828
829         Remove the support of Frame::isContentEditable and its dependencies.
830         https://bugs.webkit.org/show_bug.cgi?id=54292
831
832         Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
833
834         * Api/qwebpage.cpp:
835         (QWebPagePrivate::QWebPagePrivate):
836         (QWebPage::setContentEditable):
837         (QWebPage::isContentEditable):
838         * Api/qwebpage_p.h:
839         * WebCoreSupport/EditorClientQt.cpp:
840         * WebCoreSupport/EditorClientQt.h:
841
842 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
843
844         Reviewed by Oliver Hunt.
845
846         Build fix for Qt port after API changes of http://trac.webkit.org/changeset/79904.
847
848         * Api/qwebelement.cpp:
849         (QWebElement::evaluateJavaScript):
850
851 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
852
853         Reviewed by Andreas Kling.
854
855         [Qt]tst_QDeclarativeWebView - 8 test cases fail
856         https://bugs.webkit.org/show_bug.cgi?id=55214
857
858         Fix the API tests for the QML WebView element. The default size of the element should be the size of the QGraphicsWebView
859         if no preferred width or height are provided (see http://trac.webkit.org/changeset/79672).
860         I also refactored the tests so we don't use the network but instead a local html file.
861         QML doesn't support qrc loading so I had to workaround by using a property that I update afterwards.
862
863         * tests/qdeclarativewebview/resources/sample.html: Added.
864         * tests/qdeclarativewebview/resources/webviewtest.qml:
865         * tests/qdeclarativewebview/resources/webviewtestdefault.qml:
866         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
867         (tst_QDeclarativeWebView::preferredWidthTest):
868         (tst_QDeclarativeWebView::preferredHeightTest):
869         (tst_QDeclarativeWebView::preferredWidthDefaultTest):
870         (tst_QDeclarativeWebView::preferredHeightDefaultTest):
871         * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
872
873 2011-02-28  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
874
875         Reviewed by Andreas Kling.
876
877         [Qt] Add clipped version of QWebElement::render method.
878         Allows faster rendering of web element part.
879         https://bugs.webkit.org/show_bug.cgi?id=50311
880
881         * Api/qwebelement.cpp:
882         (QWebElement::render):
883         * Api/qwebelement.h:
884         * tests/qwebelement/tst_qwebelement.cpp:
885         (tst_QWebElement::render):
886
887 2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>
888
889         Reviewed by Andreas Kling.
890
891         Added full webkit module profile and a syncqt profile.
892
893         This is for modularized Qt.
894
895         [Qt] WebKit patches required to work with a modularized version of Qt
896         https://bugs.webkit.org/show_bug.cgi?id=53916
897
898         * qt_webkit_version.pri:
899
900 2011-02-27  Aparna Nandyal  <aparna.nand@wipro.com>
901
902         Reviewed by Antonio Gomes.
903
904         [Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
905         https://bugs.webkit.org/show_bug.cgi?id=53917
906
907         Adding test case to check the scenario to avoid regressions in the
908         future. 
909
910         * tests/qwebframe/tst_qwebframe.cpp:
911
912 2011-02-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
913
914         Reviewed by Andreas Kling.
915
916         [Qt] Reference the documentation of the WebKit bridge from QWebFrame::addToJavaScriptWindowObject()
917         https://bugs.webkit.org/show_bug.cgi?id=55322
918
919         Documentation update, add a reference to the QtWebKit bridge page.
920
921         * Api/qwebframe.cpp:
922
923 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
924
925         Reviewed by Pavel Feldman.
926
927         DumpRenderTree should reset frame opener between tests.
928         https://bugs.webkit.org/show_bug.cgi?id=54874
929
930         Added clearOpener method to DumpRenderTreeSupportQT.
931
932         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
933         (DumpRenderTreeSupportQt::clearOpener):
934         * WebCoreSupport/DumpRenderTreeSupportQt.h:
935
936 2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
937
938         Reviewed by Andreas Kling.
939
940         Make it possible to test the targetdensity-dpi support
941         https://bugs.webkit.org/show_bug.cgi?id=55142
942
943         Test the viewport meta tag feature targetdensity-dpi by
944         adding extra arguments to dumpConfigurationForViewport
945
946         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
947         (DumpRenderTreeSupportQt::viewportAsText):
948         * WebCoreSupport/DumpRenderTreeSupportQt.h:
949
950 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
951
952         Unreviewed, rolling out r79764.
953         http://trac.webkit.org/changeset/79764
954         https://bugs.webkit.org/show_bug.cgi?id=55295
955
956         "broke Chromium builds" (Requested by rniwa on #webkit).
957
958         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
959         * WebCoreSupport/DumpRenderTreeSupportQt.h:
960
961 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
962
963         Reviewed by Pavel Feldman.
964
965         DumpRenderTree should reset frame opener between tests.
966         https://bugs.webkit.org/show_bug.cgi?id=54874
967
968         Added clearOpener method to DumpRenderTreeSupportQT.
969
970         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
971         (DumpRenderTreeSupportQt::clearOpener):
972         * WebCoreSupport/DumpRenderTreeSupportQt.h:
973
974 2011-02-25  Andras Becsi  <abecsi@webkit.org>
975
976         Reviewed by Csaba Osztrogonác.
977
978         [Qt] Make the WebKit2 build system less confusing for non-Qt developers
979         https://bugs.webkit.org/show_bug.cgi?id=55213
980
981         * QtWebKit.pro: Move the WebKit2 API into a project include file
982         in the WebKit2 directory and include the pri file here.
983
984 2011-02-25  Alexis Menard  <alexis.menard@openbossa.org>
985
986         Unreviewed build fix for Intel ICC and MSVC.
987
988         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
989         (tst_QGraphicsWebView::setPalette):
990         * tests/qwebview/tst_qwebview.cpp:
991         (tst_QWebView::setPalette):
992
993 2011-02-25  Alexis Menard  <alexis.menard@openbossa.org>
994
995         Reviewed by Kenneth Rohde Christiansen.
996
997         [Qt] Properly propagate the palette to QWebPage from QGraphicsWebView
998         https://bugs.webkit.org/show_bug.cgi?id=31742
999
1000         Discovered while looking at 31742. When we set a palette on the
1001         QGraphicsWebView we need to propagate it to the page like QWebView.
1002         I have added the same tests as QWebView to be sure to catch potential
1003         regressions as well as two extras QVERIFY to check the palette propagation.
1004
1005         * Api/qgraphicswebview.cpp:
1006         (QGraphicsWebView::event):
1007         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
1008         (tst_QGraphicsWebView::setPalette_data):
1009         (tst_QGraphicsWebView::setPalette):
1010
1011 2011-02-25  Csaba Osztrogonác  <ossy@webkit.org>
1012
1013         Unreviewed buildfix after r79672.
1014
1015         [Qt] Build tst_qdeclarativewebview if QT_CONFIG contains declarative.
1016
1017         * tests/tests.pri:
1018         * tests/tests.pro:
1019
1020 2011-02-25  Gopal Raghavan  <gopal.1.raghavan@nokia.com>
1021
1022         Reviewed by Kenneth Rohde Christiansen.
1023
1024         [Qt] QML WebView inside a Flickable shows checkers pattern at startup
1025         https://bugs.webkit.org/show_bug.cgi?id=50222.
1026
1027         This patch fixes the checkerboard visible at startup even if preferredWidth and preferredHeight are not set.
1028
1029         * declarative/qdeclarativewebview.cpp:
1030         (QDeclarativeWebView::init):
1031         * tests/qdeclarativewebview: Added.
1032         * tests/qdeclarativewebview/qdeclarativewebview.pro: Added.
1033         * tests/qdeclarativewebview/resources: Added.
1034         * tests/qdeclarativewebview/resources/webviewtest.qml: Added.
1035         * tests/qdeclarativewebview/resources/webviewtestdefault.qml: Added.
1036         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Added.
1037         (tst_QDeclarativeWebView::initTestCase):
1038         (tst_QDeclarativeWebView::cleanupTestCase):
1039         (tst_QDeclarativeWebView::init):
1040         (tst_QDeclarativeWebView::cleanup):
1041         (tst_QDeclarativeWebView::preferredWidthTest):
1042         (tst_QDeclarativeWebView::preferredHeightTest):
1043         (tst_QDeclarativeWebView::preferredWidthDefaultTest):
1044         (tst_QDeclarativeWebView::preferredHeightDefaultTest):
1045         (tst_QDeclarativeWebView::checkNoErrors):
1046         * tests/tests.pri:
1047         * tests/tests.pro:
1048
1049 2011-02-24  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1050
1051         Reviewed by Andreas Kling.
1052
1053         [Qt] Revert the support for QNAM affined to a different thread.
1054         https://bugs.webkit.org/show_bug.cgi?id=55149
1055
1056         Qt 4.8 will have QNAM use its own thread internally by default,
1057         no need to keep this complexity in WebKit.
1058
1059         This mainly reverts:
1060         http://trac.webkit.org/changeset/73710
1061         http://trac.webkit.org/changeset/73712
1062
1063         * WebCoreSupport/FrameLoaderClientQt.cpp:
1064         (WebCore::FrameLoaderClientQt::download):
1065         * tests/qwebpage/tst_qwebpage.cpp:
1066
1067 2011-02-24  Sam Weinig  <sam@webkit.org>
1068
1069         Try to fix the Qt build.
1070
1071         * QtWebKit.pro:
1072
1073 2011-02-24  Peter Kasting  <pkasting@google.com>
1074
1075         Reviewed by Eric Seidel.
1076
1077         Drop the "U; " encryption level from the User Agent string.
1078         https://bugs.webkit.org/show_bug.cgi?id=54566
1079
1080         * Api/qwebpage.cpp:
1081         (QWebPage::userAgentForUrl):
1082
1083 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
1084
1085         Unreviewed, rolling out r79570.
1086         http://trac.webkit.org/changeset/79570
1087         https://bugs.webkit.org/show_bug.cgi?id=54874
1088
1089         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
1090         was not updated
1091
1092         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1093         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1094
1095 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
1096
1097         Reviewed by Alexey Proskuryakov.
1098
1099         DumpRenderTree should reset frame opener between tests.
1100         https://bugs.webkit.org/show_bug.cgi?id=54874
1101
1102         Added clearOpener method to DumpRenderTreeSupportQT.
1103
1104         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1105         (DumpRenderTreeSupportQt::clearOpener):
1106         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1107
1108 2011-02-24  Alexis Menard  <alexis.menard@openbossa.org>
1109
1110         Reviewed by Andreas Kling.
1111
1112         [Qt] tst_QWebView::setPalette(activeFG) fails
1113         https://bugs.webkit.org/show_bug.cgi?id=55029
1114
1115         This time it should be the proper fix. The window needs to be shown before we
1116         call activateWindow() otherwise there is no active windows for the application.
1117
1118         * tests/qwebview/tst_qwebview.cpp:
1119         (tst_QWebView::setPalette):
1120
1121 2011-02-24  Andras Becsi  <abecsi@webkit.org>
1122
1123         Reviewed by Laszlo Gombos.
1124
1125         [Qt] MinGW build fails to link
1126         https://bugs.webkit.org/show_bug.cgi?id=55050
1127
1128         Prepend the libraries of subcomponents instead of appending them
1129         to fix the library order according to the dependency of the libraries
1130
1131         * QtWebKit.pro: prepend libraries in the correct order
1132
1133 2011-02-23  Alexis Menard  <alexis.menard@openbossa.org>
1134
1135         Reviewed by Ariya Hidayat.
1136
1137         [Qt] tst_QWebView::setPalette(activeFG) fails
1138         https://bugs.webkit.org/show_bug.cgi?id=55029
1139
1140         Attempt to make the test more robust. By investigating with the bot virtual machine
1141         I discovered that the activation can take some time. In this patch we make sure that
1142         the active window we want to have is the same as the QApplication.
1143
1144         * tests/qwebview/tst_qwebview.cpp:
1145         (tst_QWebView::setPalette):
1146
1147 2011-02-23  Alexis Menard  <alexis.menard@openbossa.org>
1148
1149         Reviewed by Dan Bernstein.
1150
1151         [Qt]REGRESSION(r79167): It broke 3 Qt-API test cases
1152         http://trac.webkit.org/changeset/79167 refactored the way the bound size of
1153         the frame is handled. A new API setBoundsSize was added, we need to call it
1154         in addition to setFrameRect. I could call setBoundSize after setFrameRect but
1155         I thought It would be more elegant to use the resize method.
1156
1157         * Api/qwebpage.cpp:
1158         (QWebPage::setViewportSize):
1159
1160 2011-02-22  Fabrizio Machado  <fabrizio.machado@nokia.com>
1161
1162         Reviewed by Laszlo Gombos.
1163
1164         [Qt] Don't fall through case in variantToSetting() if qvariant.type() is Bool
1165         https://bugs.webkit.org/show_bug.cgi?id=54976
1166
1167         Test not needed.
1168         
1169         * WebCoreSupport/InspectorClientQt.cpp:
1170
1171 2011-02-22  Alexis Menard  <alexis.menard@openbossa.org>
1172
1173         Reviewed by Andreas Kling.
1174
1175         [Qt] QWebView ignores a palette set with QWebView::setPalette()
1176         https://bugs.webkit.org/show_bug.cgi?id=31742
1177
1178         Test case to check that the palette sets on the QWebView is taken
1179         into account.
1180
1181         * tests/qwebview/tst_qwebview.cpp:
1182         (tst_QWebView::setPalette_data):
1183         (tst_QWebView::setPalette):
1184
1185 2011-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1186
1187         Reviewed by Alexey Proskuryakov.
1188
1189         Drop the language tag part from the User Agent string
1190         https://bugs.webkit.org/show_bug.cgi?id=54560
1191
1192         * Api/qwebpage.cpp:
1193         (QWebPage::userAgentForUrl):
1194
1195         * tests/qwebpage/tst_qwebpage.cpp: Remove the userAgentLocaleChange
1196         test.
1197
1198 2011-02-22  Chang Shu  <cshu@webkit.org>
1199
1200         Reviewed by Csaba Osztrogonác.
1201
1202         [Qt] editing/deleting/5408255.html fails
1203         https://bugs.webkit.org/show_bug.cgi?id=54964
1204
1205         Move WebCore resource file to QtWebKit since they are referred in WebKit.
1206
1207         * QtWebKit.pro:
1208
1209 2011-02-22  Andras Becsi  <abecsi@webkit.org>
1210
1211         Reviewed by Csaba Osztrogonác.
1212
1213         [Qt] Redesign the build system
1214         https://bugs.webkit.org/show_bug.cgi?id=51339
1215
1216         Move inspector's resource files into the final build step to fix the layout test regression.
1217
1218         * QtWebKit.pro: Add inspector's reaource files.
1219
1220 2011-02-22  Andras Becsi  <abecsi@webkit.org>
1221
1222         Reviewed by Laszlo Gombos.
1223         Rubber-stamped by Csaba Osztrogonác.
1224
1225         [Qt] Redesign the build system
1226         https://bugs.webkit.org/show_bug.cgi?id=51339
1227
1228         The patch landed in r79320 didn't contain the cleanup
1229         which was already addressed in the last attachment.
1230
1231         * QtWebKit.pro: Move common LIB and CONFIG options to WebCore.pri.
1232
1233 2011-02-22  Andras Becsi  <abecsi@webkit.org>
1234
1235         Reviewed by Laszlo Gombos.
1236
1237         [Qt] Redesign the build system
1238         https://bugs.webkit.org/show_bug.cgi?id=51339
1239
1240         Part 2.
1241
1242         Build WebCore as a static library, compile the WebKit API and WebKit2 API
1243         in a final step and link to WebKit2, WebCore and JSC libraries to fix
1244         linking issues resulting from stripped away symbols.
1245
1246         * QtWebKit.pro: Added.
1247         Project file for the final build step.
1248
1249 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
1250
1251         Reviewed by Kent Tamura.
1252
1253         Rename Position::node() to Position::deprecatedNode()
1254         https://bugs.webkit.org/show_bug.cgi?id=54622
1255
1256         Replaced the call to node() by a call to containerNode() because the returned node is
1257         used to determine whether or not the selected contents are editable and such a check
1258         must be done against the container node.
1259
1260         * WebCoreSupport/EditorClientQt.cpp:
1261         (WebCore::EditorClientQt::handleKeyboardEvent):
1262
1263 2011-02-19  Charlie Reis  <creis@chromium.org>
1264
1265         Reviewed by Mihai Parparita.
1266
1267         Ensure loading has stopped in HistoryController::goToItem
1268         https://bugs.webkit.org/show_bug.cgi?id=54517
1269
1270         Add a FrameLoaderClient callback for whether to stop loading before goToItem.
1271
1272         Test: http/tests/navigation/forward-to-fragment-fires-onload.html
1273
1274         * WebCoreSupport/FrameLoaderClientQt.cpp:
1275         (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): Added.
1276         * WebCoreSupport/FrameLoaderClientQt.h:
1277
1278 2011-02-18  Fabrizio Machado  <fabrizio.machado@nokia.com>
1279
1280         Reviewed by Eric Seidel.
1281
1282         Remove reduntant checks.
1283         https://bugs.webkit.org/show_bug.cgi?id=54764
1284         
1285
1286         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1287         (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
1288         * WebCoreSupport/NotificationPresenterClientQt.cpp:
1289         (WebCore::NotificationPresenterClientQt::toPage):
1290
1291 2011-02-18  Csaba Osztrogonác  <ossy@webkit.org>
1292
1293         Unreviewed.
1294
1295         [Qt] Buildfix for platforms with geolocation disabled.
1296
1297         * Api/qwebpage.cpp: Add the missing guard.
1298
1299 2011-02-18  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1300
1301         Reviewed by Kenneth Rohde Christiansen.
1302
1303         [Qt] Implement client based geolocation for qtport
1304         https://bugs.webkit.org/show_bug.cgi?id=42629
1305
1306         Implements client based geolocation for qtwebkit.
1307         New client based geolocation contains permission API's as well,
1308         so removed the implementation from ChromeClientQt.cpp. 
1309
1310         * Api/qwebpage.cpp:
1311         (QWebPagePrivate::QWebPagePrivate):
1312         * WebCoreSupport/ChromeClientQt.cpp:
1313         * WebCoreSupport/ChromeClientQt.h:
1314         (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
1315         (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
1316         * WebCoreSupport/GeolocationClientQt.cpp: Added.
1317         (WebCore::GeolocationClientQt::GeolocationClientQt):
1318         (WebCore::GeolocationClientQt::~GeolocationClientQt):
1319         (WebCore::GeolocationClientQt::geolocationDestroyed):
1320         (WebCore::GeolocationClientQt::positionUpdated):
1321         (WebCore::GeolocationClientQt::startUpdating):
1322         (WebCore::GeolocationClientQt::stopUpdating):
1323         (WebCore::GeolocationClientQt::setEnableHighAccuracy):
1324         (WebCore::GeolocationClientQt::requestPermission):
1325         (WebCore::GeolocationClientQt::cancelPermissionRequest):
1326         * WebCoreSupport/GeolocationClientQt.h: Added.
1327         (WebCore::GeolocationClientQt::lastPosition):
1328
1329 2011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
1330
1331         Reviewed by Adam Roben.
1332
1333         HTML5 <details> and <summary>: localized text
1334         https://bugs.webkit.org/show_bug.cgi?id=54260
1335
1336         The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
1337         provide the default label to be used by a <details> tag that has no <summary> child.
1338
1339         * WebCoreSupport/WebPlatformStrategies.cpp:
1340         (WebPlatformStrategies::defaultDetailsSummaryText):
1341         * WebCoreSupport/WebPlatformStrategies.h:
1342
1343 2011-02-17  Hui Huang  <hui.2.huang@nokia.com>
1344
1345         Reviewed by Laszlo Gombos.
1346
1347         The URL of HTML5 Video Element is percent encoded at websites such as youtube.
1348         It is percent encoded again by QUrl constructor QUrl::QUrl(QString). This causes
1349         the HTTP GET request for the video to be rejected by the service provider. 
1350         https://bugs.webkit.org/show_bug.cgi?id=53973.
1351
1352         The bug is fixed by constructing QUrl from the encoded URL in 
1353         MediaPlayerPrivateQt::commitLoad. 
1354
1355         New test function tst_QWebPage::loadHtml5Video() is added to load HTML content with
1356         HTML5 Video element. A new public method DumpRenderTreeSupportQt::mediaContentUrlByElementId
1357         is added to retrieve the URL of the media content from WebCore MediaPlayerPrivateQt.
1358         A new macro ENABLE_QT_MULTIMEDIA is introduced in tests.pri to make sure that the test
1359         is skipped if Qt Multimedia is not available.
1360
1361         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1362         (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
1363         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1364         * tests/qwebpage/tst_qwebpage.cpp:
1365         (tst_QWebPage::loadHtml5Video):
1366         * tests/tests.pri:
1367
1368 2011-02-17  Andreas Kling  <kling@webkit.org>
1369
1370         Reviewed by Antti Koivisto.
1371
1372         [Qt] Crash when calling QWebFrame::setUrl() while a previous load has pending requests
1373         https://bugs.webkit.org/show_bug.cgi?id=49216
1374
1375         * tests/qwebframe/tst_qwebframe.cpp:
1376
1377 == Rolled over to ChangeLog-2011-02-16 ==