2011-03-28 Andreas Kling <kling@webkit.org>
[WebKit-https.git] / Source / WebKit / qt / ChangeLog
1 2011-03-28  Andreas Kling  <kling@webkit.org>
2
3         Reviewed by Benjamin Poulain.
4
5         [Qt] Crash when calling QWebFrame::render() in response to QWebPage::repaintRequested()
6         https://bugs.webkit.org/show_bug.cgi?id=52629
7
8         * WebCoreSupport/ChromeClientQt.cpp:
9         (WebCore::ChromeClientQt::invalidateContentsAndWindow): Make the emission of
10         QWebPage::repaintRequested() use a Qt::QueuedConnection.
11
12         * tests/qwebpage/tst_qwebpage.cpp:
13         (RepaintRequestedRenderer::RepaintRequestedRenderer):
14         (RepaintRequestedRenderer::onRepaintRequested):
15         (tst_QWebPage::renderOnRepaintRequestedShouldNotRecurse): Test that calling
16         QWebFrame::render() in a slot connected to to QWebPage::repaintRequested()
17         doesn't cause recursive signal emissions.
18
19 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
20
21         Reviewed by Andreas Kling.
22
23         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
24         https://bugs.webkit.org/show_bug.cgi?id=57087
25
26         * QtWebKit.pro: we can now enable QT_ASCII_CAST_WARNINGS
27         * tests/tests.pri: we do not require QT_ASCII_CAST_WARNINGS for tests
28         since they are applications, not libraries.
29
30 2011-03-28  Andras Becsi  <abecsi@webkit.org>
31
32         Reviewed by Csaba Osztrogonác.
33
34         [Qt] QtWebKit does not link with --3d-canvas using MinGW
35         https://bugs.webkit.org/show_bug.cgi?id=57225
36
37         * QtWebKit.pro: Append the OpenGL libraries on MinGW so it can resolve symbols.
38
39 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
40
41         Reviewed by Andreas Kling.
42
43         REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
44         https://bugs.webkit.org/show_bug.cgi?id=57183
45
46         Windows buildfix after r82065.
47
48         * Api/DerivedSources.pro: Readding escaping on Windows platforms.
49
50 2011-03-27  Andreas Kling  <kling@webkit.org>
51
52         Fix build warning about IconDatabaseClient.h (wrong path.)
53
54         * QtWebKit.pro:
55
56 2011-03-27  Andreas Kling  <kling@webkit.org>
57
58         Reviewed by Kenneth Rohde Christiansen.
59
60         [Qt] Support for CSS color and background-color properties on select element's dropdown list
61         https://bugs.webkit.org/show_bug.cgi?id=51627
62
63         Extend the QWebSelectData interface with background and foreground colors
64         for the whole menu, as well as per-item. Hook it up to the PopupMenuStyle
65         getters in RenderMenuList.
66
67         * Api/qwebkitplatformplugin.h:
68         * WebCoreSupport/PopupMenuQt.cpp:
69         (SelectData::backgroundColor):
70         (SelectData::foregroundColor):
71         (SelectData::itemBackgroundColor):
72         (SelectData::itemForegroundColor):
73         * WebCoreSupport/QtFallbackWebPopup.cpp:
74         (WebCore::QtFallbackWebPopup::show):
75         (WebCore::QtFallbackWebPopup::populate):
76
77 2011-03-27  Yi Shen  <yi.4.shen@nokia.com>
78
79         Reviewed by Andreas Kling.
80
81         [Qt][Symbian] Fix Api test failure -- microFocusCoordinates
82         https://bugs.webkit.org/show_bug.cgi?id=57108
83
84         Since the canvas is not self-closing tag, we need to add '</canvas>'. 
85
86         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
87         (tst_QGraphicsWebView::microFocusCoordinates):
88         * tests/qwebview/tst_qwebview.cpp:
89         (tst_QWebView::microFocusCoordinates):
90
91 2011-03-27  Kwang Yul Seo  <skyul@company100.net>
92
93         Reviewed by Eric Seidel.
94
95         [Qt] Build fix: Define WTF_USE_TEXTURE_MAPPER=1 when CONFIG contains texmap.
96         https://bugs.webkit.org/show_bug.cgi?id=57143
97
98         Qt WebKit uses USE(TEXTURE_MAPPER) guard. Check texmap in CONFIG and
99         define WTF_USE_TEXTURE_MAPPER=1.
100
101         * QtWebKit.pro:
102
103 2011-03-27  Andreas Kling  <kling@webkit.org>
104
105         Reviewed by Benjamin Poulain.
106
107         REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
108         https://bugs.webkit.org/show_bug.cgi?id=57183
109
110         The convenience <QtWebKit> header would include \<QtNetwork/QtNetwork\>
111         which was due to the outputting code previously being wrapped in eval().
112
113         * Api/DerivedSources.pro:
114
115 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
116
117         Reviewed by Andreas Kling.
118
119         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
120         https://bugs.webkit.org/show_bug.cgi?id=57087
121
122         Use explicit conversion for string to avoid depending on the default codec
123         installed by the user code.
124
125         * Api/qwebkitversion.cpp:
126         (qWebKitVersion):
127         * Api/qwebpage.cpp:
128         (QWebPagePrivate::dynamicPropertyChangeEvent):
129         (QWebPage::javaScriptConsoleMessage):
130         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
131         (convertToPropertyName):
132         (DumpRenderTreeSupportQt::setEditingBehavior):
133         (DumpRenderTreeSupportQt::plainText):
134         * WebCoreSupport/EditorClientQt.cpp:
135         (dumpRange):
136         * WebCoreSupport/FrameLoaderClientQt.cpp:
137         (drtDescriptionSuitableForTestResult):
138         (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
139         * WebCoreSupport/InspectorClientQt.cpp:
140         (WebCore::InspectorClientQt::openInspectorFrontend):
141         * WebCoreSupport/InspectorServerQt.cpp:
142         (WebCore::parseWebSocketChallengeNumber):
143         (WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
144
145 2011-03-26  Andreas Kling  <kling@webkit.org>
146
147         Reviewed by Kenneth Rohde Christiansen.
148
149         [Qt] QWebFrame::iconChanged() not emitted when icon is cached but not yet loaded
150         https://bugs.webkit.org/show_bug.cgi?id=57157
151
152         Add an IconDatabaseClient for the Qt port to ensure that QWebFrame::iconChanged()
153         is always emitted when appropriate.
154
155         * QtWebKit.pro: Add new files.
156
157         * WebCoreSupport/IconDatabaseClientQt.h: Added.
158         * WebCoreSupport/IconDatabaseClientQt.cpp: Added.
159         (WebCore::IconDatabaseClientQt::instance):
160         (WebCore::IconDatabaseClientQt::IconDatabaseClientQt):
161         (WebCore::IconDatabaseClientQt::~IconDatabaseClientQt):
162         (WebCore::IconDatabaseClientQt::performImport):
163         (WebCore::IconDatabaseClientQt::didRemoveAllIcons):
164         (WebCore::IconDatabaseClientQt::didImportIconURLForPageURL):
165         (WebCore::IconDatabaseClientQt::didImportIconDataForPageURL):
166         (WebCore::IconDatabaseClientQt::didChangeIconForPageURL):
167         (WebCore::IconDatabaseClientQt::didFinishURLImport):
168
169         * WebCoreSupport/FrameLoaderClientQt.h:
170         * WebCoreSupport/FrameLoaderClientQt.cpp:
171         (WebCore::FrameLoaderClientQt::registerForIconNotification):
172         (WebCore::FrameLoaderClientQt::onIconLoadedForPageURL): New slot connected
173         to the IconDatabaseClientQt::iconLoadedForPageURL() signal. This emits the
174         QWebFrame::iconChanged() signal when the IconDatabases finishes loading
175         a cached favicon for the frame's URL.
176
177         * Api/qwebsettings.cpp:
178         (QWebSettings::setIconDatabasePath): Make sure that IconDatabaseClientQt is
179         instantiated. An IconDatabaseClient has to be registered before the IconDatabase
180         spawns its reader thread.
181
182 2011-03-25  Andy Estes  <aestes@apple.com>
183
184         Reviewed by Adele Peterson.
185
186         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
187         https://bugs.webkit.org/show_bug.cgi?id=49016
188
189         Update objectContentType() implementation to handle the
190         shouldPreferPlugInsForImages flag.
191
192         * WebCoreSupport/FrameLoaderClientQt.cpp:
193         (WebCore::FrameLoaderClientQt::objectContentType):
194         * WebCoreSupport/FrameLoaderClientQt.h:
195
196 2011-03-25  Chang Shu  <cshu@webkit.org>
197
198         Reviewed by Ryosuke Niwa.
199
200         rename Node::isContentEditable and all call sites to rendererIsEditable
201         https://bugs.webkit.org/show_bug.cgi?id=54290
202
203         This is part of the effort to separate JS API HTMLElement isContentEditable from
204         internal Node::rendererIsEditable.
205
206         * WebCoreSupport/EditorClientQt.cpp:
207         (WebCore::EditorClientQt::handleKeyboardEvent):
208
209 2011-03-25  Alexis Menard  <alexis.menard@openbossa.org>
210
211         Reviewed by Andreas Kling.
212
213         [Qt] The keyboard shortcuts during fullscreen playback do not work.
214         https://bugs.webkit.org/show_bug.cgi?id=57095
215
216         We need to explicitely set the focus on the widget in order to receive the keyboard events.
217
218         * WebCoreSupport/FullScreenVideoWidget.cpp:
219         (WebCore::FullScreenVideoWidget::show):
220
221 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
222
223         Unreviewed, rolling out r81916 and r81917.
224         http://trac.webkit.org/changeset/81916
225         http://trac.webkit.org/changeset/81917
226         https://bugs.webkit.org/show_bug.cgi?id=57071
227
228         broke a test on platforms that do not have QuickTime installed
229         (Requested by estes on #webkit).
230
231         * WebCoreSupport/FrameLoaderClientQt.cpp:
232         (WebCore::FrameLoaderClientQt::objectContentType):
233         * WebCoreSupport/FrameLoaderClientQt.h:
234
235 2011-03-24  Andy Estes  <aestes@apple.com>
236
237         Reviewed by Darin Adler.
238
239         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
240         https://bugs.webkit.org/show_bug.cgi?id=49016
241
242         Update objectContentType() implementation to handle the
243         shouldPreferPlugInsForImages flag.
244
245         * WebCoreSupport/FrameLoaderClientQt.cpp:
246         (WebCore::FrameLoaderClientQt::objectContentType):
247         * WebCoreSupport/FrameLoaderClientQt.h:
248
249 2011-03-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
250
251         Reviewed by Kenneth Rohde Christiansen.
252
253         [Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles
254         https://bugs.webkit.org/show_bug.cgi?id=40884
255
256         Add tests and benchmarks for the software fallback of WebGL.
257
258         * tests/benchmarks/webgl/10000_triangles.html: Added.
259         * tests/benchmarks/webgl/tst_webgl.cpp: Added.
260         (GraphicsView::GraphicsView):
261         (GraphicsView::resizeEvent):
262         (tst_WebGlPerformance::init):
263         (tst_WebGlPerformance::cleanup):
264         (tst_WebGlPerformance::benchSoftwareFallbackRgb16):
265         (tst_WebGlPerformance::benchSoftwareFallbackRgb32):
266         (tst_WebGlPerformance::benchSoftwareFallbackArgb32):
267         (tst_WebGlPerformance::benchSoftwareFallbackArgb32Premultiplied):
268         (tst_WebGlPerformance::benchmarkFrameRenderingOnImage):
269         * tests/benchmarks/webgl/tst_webgl.qrc: Added.
270         * tests/benchmarks/webgl/webgl.pro: Added.
271         * tests/qgraphicswebview/qgraphicswebview.pro:
272         * tests/qgraphicswebview/resources/pointing_right.html: Added.
273         * tests/qgraphicswebview/resources/pointing_up.html: Added.
274         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
275         (compareImagesFuzzyPixelCount):
276         (GraphicsView::GraphicsView):
277         (tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation):
278         (tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation):
279         (tst_QGraphicsWebView::compareCanvasToImage):
280         * tests/qgraphicswebview/tst_qgraphicswebview.qrc:
281         * tests/tests.pro:
282
283 2011-03-24  Kristian Amlie  <kristian.amlie@nokia.com>
284
285         Reviewed by Benjamin Poulain.
286
287         Avoided ASCII-cast warnings for WebKit.
288
289         Normally they won't be enabled anyway, but if you build webkit from
290         within the Qt mother repository it will pick up Qt's default build
291         settings, which do enable it. We need to disable them because
292         warnings are treated as errors and there are way too many of them in
293         the WebKit code.
294
295         [Qt] Avoid ASCII-cast warnings for WebKit.
296         https://bugs.webkit.org/show_bug.cgi?id=57016
297
298         * QtWebKit.pro:
299
300 2011-03-24  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
301
302         Reviewed by Benjamin Poulain.
303
304         [Qt] Resetting the URL property of a QWebView results in the current directory being set as file::-type URL
305         https://bugs.webkit.org/show_bug.cgi?id=29595
306
307         Qt Designer resets the URL by setting it to QUrl(). The bug was caused by
308         ensureAbsoluteUrl() helper function treating the empty URL as a relative URL, and
309         prepending the current directory.
310
311         By fixing this, now we can pass QUrl() invalid and empty URLs to WebCore layer, which
312         will end up loading "about:blank", but keeping it as a requested URL.
313
314         This patch also simplifies the logic for requestedUrl(), since m_lastRequestedUrl
315         is filled for the loaded URLs as well, we can use it in every case.
316
317         Three new autotests were added, to better cover the expected behavior of setting
318         the QUrl() in a QWebFrame.
319
320         * Api/qwebframe.cpp:
321         (ensureAbsoluteUrl): do not treat invalid URLs (empty included) as relative.
322         (QWebFrame::requestedUrl): always use m_lastRequestedUrl.
323
324         * WebCoreSupport/FrameLoaderClientQt.cpp:
325         (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): do not clear m_lastRequestedUrl
326         anymore, since we always rely on it even for loaded frames.
327
328         * tests/qwebframe/tst_qwebframe.cpp:
329         (tst_QWebFrame::setUrlToEmpty): verify the behavior of setting empty URLs. This includes
330         the reduction of the bug report.
331         (tst_QWebFrame::setUrlToInvalid): setting invalid, but not necessarily empty, URLs.
332         (tst_QWebFrame::setUrlHistory): to verify how setting empty URLs affect history.
333
334 2011-03-23  Brady Eidson  <beidson@apple.com>
335
336         Reviewed by Sam Weinig.
337
338         Change IconDatabase opening to allow for arbitrary filenames
339         https://bugs.webkit.org/show_bug.cgi?id=56977
340
341         * Api/qwebsettings.cpp:
342         (QWebSettings::setIconDatabasePath):
343
344 2011-03-23  Aparna Nandyal  <aparna.nand@wipro.com>
345
346         Reviewed by Andreas Kling.
347
348         [Qt] QtWebKit rendering problem when maximizing and doing a back
349         https://bugs.webkit.org/show_bug.cgi?id=56669
350
351         Added an auto test.
352         Patch by Alexis Menard < alexis.menard@nokia.com> on 2011-03-21
353  
354         * tests/qwebview/tst_qwebview.cpp:
355         (tst_QWebView::rendering):
356
357 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
358
359         Reviewed by Pavel Feldman.
360
361         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
362         https://bugs.webkit.org/show_bug.cgi?id=56843
363
364         * WebCoreSupport/InspectorClientQt.cpp:
365         (WebCore::InspectorClientQt::openInspectorFrontend):
366
367 2011-03-22  Andrew Wason  <rectalogic@rectalogic.com>
368
369         Reviewed by Benjamin Poulain.
370
371         [Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
372         https://bugs.webkit.org/show_bug.cgi?id=54138
373
374         * tests/qwebpage/tst_qwebpage.cpp:
375         (webGLScreenshotWithoutView):
376         (tst_QWebPage::acceleratedWebGLScreenshotWithoutView):
377         (tst_QWebPage::unacceleratedWebGLScreenshotWithoutView):
378          Render a QWebPage (with and without accelerated compositing)
379          with a WebGL context that has no owning view.  Shouldn't crash.
380
381 2011-03-21  Chang Shu  <cshu@webkit.org>
382
383         Reviewed by Alexey Proskuryakov.
384
385         REGRESSION (r79953): Can't type in MS Outlook 2011
386         https://bugs.webkit.org/show_bug.cgi?id=56665
387
388         r79953 removed the WebView level editablity which is persistent no matter whether
389         underlying document itself is changed and editability gets lost. The resolution is to
390         set this WebView editable value to WebCore. This avoids the callback from WebCore to
391         WebKit which was the main goal in r79953 to improve performance.
392
393         * Api/qwebpage.cpp:
394         (QWebPage::setContentEditable):
395         (QWebPage::isContentEditable):
396
397 2011-03-19  Andreas Kling  <kling@webkit.org>
398
399         Reviewed by Benjamin Poulain.
400
401         [Qt] Remove support for Qt 4.6
402         https://bugs.webkit.org/show_bug.cgi?id=56712
403
404         * Api/qwebframe.cpp:
405         (QWebFrame::load):
406         * Api/qwebpage.cpp:
407         (QWebPagePrivate::QWebPagePrivate):
408         * Api/qwebsettings.cpp:
409         (QWebSettings::QWebSettings):
410         * WebCoreSupport/GeolocationClientQt.cpp:
411         (WebCore::GeolocationClientQt::positionUpdated):
412
413 2011-03-19  Andreas Kling  <kling@webkit.org>
414
415         Reviewed by Antonio Gomes.
416
417         [Qt][Doc] QWebPage::unsupportedContent() passes ownership of the QNetworkReply
418         https://bugs.webkit.org/show_bug.cgi?id=56711
419
420         Document the fact that when unsupportedContent(QNetworkReply*) is emitted,
421         ownership of the reply is transferred to the receiving slot.
422
423         * Api/qwebpage.cpp:
424
425 2011-03-17  Brady Eidson  <beidson@apple.com>
426
427         Reviewed by Sam Weinig.
428
429         https://bugs.webkit.org/show_bug.cgi?id=56425
430         More groundwork for WebKit2 IconDatabase
431
432         Update already-used function names:
433         * Api/qwebhistory.cpp:
434         (QWebHistoryItem::icon):
435         * Api/qwebsettings.cpp:
436         (QWebSettings::iconForUrl):
437
438 2011-03-18  Alexis Menard  <alexis.menard@openbossa.org>
439
440         Reviewed by Benjamin Poulain.
441
442         [Qt] console.log not being exposed to QmlViewer
443         https://bugs.webkit.org/show_bug.cgi?id=56536
444
445         The documentation is bogus the feature does not exist.
446
447         * declarative/qdeclarativewebview.cpp:
448
449 2011-03-17  Andreas Kling  <kling@webkit.org>
450
451         Reviewed by Kenneth Rohde Christiansen.
452
453         [Qt] QML WebView emits iconChanged() when the page title changes
454         https://bugs.webkit.org/show_bug.cgi?id=56570
455
456         * declarative/qdeclarativewebview.cpp:
457         (QDeclarativeWebView::setPage): Don't forward the frame's titleChanged
458         signal to the view's iconChanged signal.
459
460 2011-03-17  Alexis Menard  <alexis.menard@openbossa.org>
461
462         Reviewed by Benjamin Poulain.
463
464         [Qt] Videos look ugly when using QGraphicsWebView.
465         https://bugs.webkit.org/show_bug.cgi?id=56580
466
467         We need to set QPainter::SmoothPixmapTransform on the painter for a proper rendering of the video.
468         QWebView does it but not QGraphicsWebView because the API does not exist. This patch is fixing it
469         by introducing the same API as QWebView to control the renderHints of the item. Unlike QWebView
470         QGraphicsWebView inherits the painter from QGraphicsScene and those flags are not set. This patch
471         ensure that before rendering the item we add QPainter::SmoothPixmapTransform and QPainter::TextAntialiasing
472         in addition of what could be set on the painter. In order to not break the rendering of all the items in the
473         scene we set back the painter to its original state when QGraphicsWebView is rendered.
474
475         * Api/qgraphicswebview.cpp:
476         (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
477         (QGraphicsWebView::paint):
478         (QGraphicsWebView::renderHints):
479         (QGraphicsWebView::setRenderHints):
480         (QGraphicsWebView::setRenderHint):
481         * Api/qgraphicswebview.h:
482         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
483         (tst_QGraphicsWebView::renderHints):
484
485 2011-03-16  Joseph Pecoraro  <joepeck@webkit.org>
486
487         Reviewed by Kenneth Rohde Christiansen.
488
489         Viewport no longer allows an auto value for "user-scalable"
490         https://bugs.webkit.org/show_bug.cgi?id=55416
491
492         Make the default value for userScalable be true.
493
494         * Api/qwebpage.cpp:
495         (QWebPage::viewportAttributesForSize):
496         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
497         (DumpRenderTreeSupportQt::viewportAsText): update test output to include userScalable.
498
499 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
500
501         Reviewed by Darin Adler.
502
503         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
504         info into the headers rather than in export symbol definition files, but disable it on 
505         all platforms initially so we can deal with port build issues one port at a time.
506         
507         https://bugs.webkit.org/show_bug.cgi?id=27551
508
509         * WebCoreSupport/GeolocationClientQt.cpp:
510         * WebCoreSupport/PopupMenuQt.cpp:
511
512 2011-03-14  Brady Eidson  <beidson@apple.com>
513
514         Reviewed by Anders Carlsson.
515
516         https://bugs.webkit.org/show_bug.cgi?id=56320
517         Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
518
519         * Api/qwebhistory.cpp:
520         (QWebHistoryItem::icon): Use IconDatabase directly.
521
522 2011-03-11  Brady Eidson  <beidson@apple.com>
523
524         Reviewed by attempt at build fix!
525
526         https://bugs.webkit.org/show_bug.cgi?id=56216
527         Fix the Qt build following the same pattern of the patch.
528
529         * Api/qwebsettings.cpp:
530         (QWebSettings::setIconDatabasePath): Call the static method via IconDatabase:: and not via iconDatabase()
531
532 2011-03-11  Alexis Menard  <alexis.menard@openbossa.org>
533
534         Reviewed by Ariya Hidayat.
535
536         [Qt] Entering fullscreen and leaving it may hide the cursor of the application.
537         https://bugs.webkit.org/show_bug.cgi?id=56181
538
539         We need to stop the auto hide cursor timer when closing the widget otherwise the timer
540         might get fired and therefore hide the cursor even when the fullscreen widget is closed.
541
542         * WebCoreSupport/FullScreenVideoWidget.cpp:
543         (WebCore::FullScreenVideoWidget::closeEvent):
544
545 2011-03-10  David Boddie <david.boddie@nokia.com>
546
547         Reviewed by Andreas Kling.
548
549         Fixed a qdoc warning and terminology (WebKit instead of Webkit).
550         https://bugs.webkit.org/show_bug.cgi?id=55756
551
552         * Api/qwebhistoryinterface.cpp:
553
554 2011-03-10  Andreas Kling  <kling@webkit.org>
555
556         Unreviewed build fix after r80774.
557
558         QML property versioning is introduced in Qt 4.7.3, not 4.7.2.
559         See also: http://bugreports.qt.nokia.com/browse/QTBUG-13451
560
561         * declarative/plugin.cpp:
562         (WebKitQmlPlugin::registerTypes):
563         * declarative/qdeclarativewebview.cpp:
564         * declarative/qdeclarativewebview_p.h:
565         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
566
567 2011-03-10  Alexis Menard  <alexis.menard@openbossa.org>
568
569         Reviewed by Andreas Kling.
570
571         [Qt] QtDeclarative Webview element has a fixed white background
572         https://bugs.webkit.org/show_bug.cgi?id=40918
573
574         Implement a way to change the background color of the WebView QML element.
575         This feature is activated for QtWebKit 1.1 version of the plugin.
576
577         * declarative/plugin.cpp:
578         (WebKitQmlPlugin::registerTypes):
579         * declarative/qdeclarativewebview.cpp:
580         (QDeclarativeWebView::backgroundColor):
581         (QDeclarativeWebView::setBackgroundColor):
582         * declarative/qdeclarativewebview_p.h:
583         * tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml: Added.
584         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
585         (tst_QDeclarativeWebView::backgroundColor):
586         * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
587
588 2011-03-10  Stanislav Paltis  <Stanislav.Paltis@nokia.com>
589
590         Reviewed by Laszlo Gombos.
591
592         [Qt] MemoryCache deadDecodedDataDeletionInterval is not exposed for client's usage
593         https://bugs.webkit.org/show_bug.cgi?id=55945
594         
595         Added handling of dynamic/runtime property _q_deadDecodedDataDeletionInterval to 
596         set interval used to trigger when decoded data in dead list of object cache will 
597         be purged from object cache. 
598
599         * Api/qwebpage.cpp:
600         (QWebPagePrivate::dynamicPropertyChangeEvent):
601
602 2011-03-10  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
603
604         Reviewed by Antonio Gomes.
605
606         Simplify how QWebFrame::requestedUrl() is obtained
607         https://bugs.webkit.org/show_bug.cgi?id=55842
608
609         When a load starts, store the requested URL until we know that it'll be
610         available for us in the document loader -- after load finished.
611
612         The existing auto tests cover the three different code paths in
613         requestedUrl() and the new code passes the autotests. In each of those
614         cases, we looked for the information in a different place, but in all
615         of them, dispatchDidStartProvisionalLoad was called.
616
617         This simplification will be useful to fix bug 32723. The way requestedUrl()
618         is implementent, we can't use it as a fallback for url() when the setUrl()
619         was called with an invalid URL.
620
621         * Api/qwebframe.cpp:
622         (QWebFrame::requestedUrl):
623         * WebCoreSupport/FrameLoaderClientQt.cpp:
624         (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
625         (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
626         * WebCoreSupport/FrameLoaderClientQt.h:
627         (WebCore::FrameLoaderClientQt::lastRequestedUrl):
628
629 2011-03-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
630
631         Reviewed by Kenneth Rohde Christiansen.
632
633         Tiled backing store's delegated scroll request uses incorrect convention
634         https://bugs.webkit.org/show_bug.cgi?id=56011
635
636         Adapt internal API to match the change from delta to point on the
637         WebCore side, and convert the point to a delta for the public API.
638
639         * WebCoreSupport/ChromeClientQt.cpp:
640         (WebCore::ChromeClientQt::delegatedScrollRequested):
641         * WebCoreSupport/ChromeClientQt.h:
642
643 2011-03-09  Peter Kasting  <pkasting@google.com>
644
645         Reviewed by Mihai Parparita.
646
647         Unify Windows version checks.
648         https://bugs.webkit.org/show_bug.cgi?id=55979
649
650         * Api/qwebpage.cpp:
651         (QWebPage::userAgentForUrl):
652
653 2011-03-07  Sam Weinig  <sam@webkit.org>
654
655         Reviewed by Anders Carlsson.
656
657         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
658         https://bugs.webkit.org/show_bug.cgi?id=55827
659
660         Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
661         and pass the entire response, instead of just the MIMEType.
662
663         * WebCoreSupport/FrameLoaderClientQt.cpp:
664         (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
665         * WebCoreSupport/FrameLoaderClientQt.h:
666
667 2011-03-05  Qi Zhang  <qi.2.zhang@nokia.com>
668
669         Reviewed by Laszlo Gombos.
670
671         [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
672         https://bugs.webkit.org/show_bug.cgi?id=48636
673
674         Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.
675
676         * Api/qwebpage.cpp:
677         (QWebPage::userAgentForUrl):
678
679 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
680
681         Reviewed by Kenneth Rohde Christiansen.
682
683         [QT] Implement mock client-based geolocation for layout testing
684         https://bugs.webkit.org/show_bug.cgi?id=54334
685
686         Implement layout testing for Client-Based geolocation. If drt_run is set 
687         then create mock geolocationClient and update the same with controller.
688
689         * Api/qwebpage.cpp:
690         (QWebPagePrivate::QWebPagePrivate):
691         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
692         (DumpRenderTreeSupportQt::mockGeolocationReset):
693         (DumpRenderTreeSupportQt::setMockGeolocationPermission):
694         (DumpRenderTreeSupportQt::setMockGeolocationPosition):
695         (DumpRenderTreeSupportQt::setMockGeolocationError):
696         * WebCoreSupport/DumpRenderTreeSupportQt.h:
697         * WebCoreSupport/GeolocationClientQt.cpp:
698         (WebCore::GeolocationClientQt::GeolocationClientQt):
699         * WebCoreSupport/GeolocationClientQt.h:
700
701 2011-03-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
702
703         Reviewed by Kenneth Rohde Christiansen.
704
705         [Qt] QWebFrame::setUrl works only from second time if url fragment is present
706         https://bugs.webkit.org/show_bug.cgi?id=32723
707
708         Create an auto-test for Qt based on the bug description.
709
710         * tests/qwebframe/tst_qwebframe.cpp: add setUrlWithFragment() test.
711
712 2011-03-03  Brady Eidson  <beidson@apple.com>
713
714         Reviewed by Darin Adler.
715
716         https://bugs.webkit.org/show_bug.cgi?id=55721
717         Global IconDatabase should be returned by reference, not as a pointer
718
719         * Api/qwebsettings.cpp:
720         (QWebSettings::setIconDatabasePath):
721         (QWebSettings::iconDatabasePath):
722         (QWebSettings::clearIconDatabase):
723         (QWebSettings::iconForUrl):
724
725 2011-03-03  Alexey Proskuryakov  <ap@apple.com>
726
727         Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included
728         via ChromeClient.h
729
730         * WebCoreSupport/ChromeClientQt.h:
731
732 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
733
734         Reviewed by Darin Adler.
735
736         REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
737         https://bugs.webkit.org/show_bug.cgi?id=55633
738         <rdar://problem/8963023>
739
740         * WebCoreSupport/ChromeClientQt.cpp (WebCore::ChromeClientQt::keyboardUIMode):
741         * WebCoreSupport/ChromeClientQt.h:
742         Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since
743         this platform doesn't observe or have full keyboard access state.
744
745 2011-03-03  Alexis Menard  <alexis.menard@openbossa.org>
746
747         Reviewed by Andreas Kling.
748
749         [Qt] QGraphicsWebView should use updateMicroFocus() of QGraphicsItem
750         https://bugs.webkit.org/show_bug.cgi?id=55568
751
752         We should use updateMicroFocus() from QGraphicsItem rather than the implementation
753         in QGraphicsWebView. _q_updateMicroFocus was added when QGraphicsItem didn't have the feature.
754         In Qt 4.7, updateMicroFocus was added, let's use it, then we can benefit of all bug fixing done
755         in QGraphicsItem.
756
757         * Api/qgraphicswebview.cpp:
758         (QGraphicsWebView::setPage):
759         * Api/qgraphicswebview.h:
760
761 2011-03-03  Peter Kasting  <pkasting@google.com>
762
763         Reviewed by James Robinson.
764
765         Drop redundant "Windows; " from the Windows-specific User Agent string.
766         https://bugs.webkit.org/show_bug.cgi?id=54567
767
768         * Api/qwebpage.cpp:
769         (QWebPage::userAgentForUrl):
770
771 2011-03-01  Brian Weinstein  <bweinstein@apple.com>
772
773         Reviewed by Adam Roben.
774
775         Part of WebKit2: Need a way to send notifications to client when cookies change
776         https://bugs.webkit.org/show_bug.cgi?id=55427
777         <rdar://problem/9056027>
778         
779         Add stubs for CookiesStrategy on Qt WebKit1.
780
781         * WebCoreSupport/WebPlatformStrategies.cpp:
782         (WebPlatformStrategies::createCookiesStrategy):
783         (WebPlatformStrategies::notifyCookiesChanged):
784         * WebCoreSupport/WebPlatformStrategies.h:
785
786 2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>
787
788         Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.
789
790         * Api/qwebpage.cpp:
791         (QWebPage::viewportAttributesForSize):
792         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
793         (DumpRenderTreeSupportQt::viewportAsText):
794
795 2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>
796
797         Reviewed by Kenneth Rohde Christiansen.
798
799         Viewport Warning/Error Messages Are Now Inaccurate
800         https://bugs.webkit.org/show_bug.cgi?id=53707
801
802         * Api/qwebpage.cpp:
803         (QWebPage::viewportAttributesForSize): pass a Document into computeViewportAttributes for warnings to be reported to.
804         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
805         (DumpRenderTreeSupportQt::viewportAsText): pass a Document into computeViewportAttributes for warnings to be reported to.
806
807 2011-03-01  Andras Becsi  <abecsi@webkit.org>
808
809         Reviewed by Csaba Osztrogonác.
810
811         [Qt] Clean up the project files and move common options to WebKit.pri.
812
813         * QtWebKit.pro: Move common options to WebKit.pri.
814
815 2011-03-01  Aparna Nandyal  <aparna.nand@wipro.com>
816
817         Reviewed by Simon Hausmann.
818
819         [Qt]tst_QWebPage::backActionUpdate fails when there is not network connection
820         https://bugs.webkit.org/show_bug.cgi?id=55319
821
822         The test case required internet connection to be able to connect to
823         google.com. Added new html file which refers to local html file.
824
825         * tests/qwebpage/resources/content.html: Added.
826         * tests/qwebpage/resources/frame_c.html: Added.
827         * tests/qwebpage/resources/framedindex.html: Added.
828         * tests/qwebpage/tst_qwebpage.cpp:
829         (tst_QWebPage::backActionUpdate):
830         * tests/qwebpage/tst_qwebpage.qrc:
831
832 2011-02-25 Steve Block <steveblock@google.com>
833
834         Reviewed by Jeremy Orlow.
835
836         Bridge.h should not include BridgeJSC.h
837         https://bugs.webkit.org/show_bug.cgi?id=55212
838
839         Include BridgeJSC.h directly instead.
840
841         * Api/qwebframe.cpp:
842
843 2011-02-28  Chang Shu  <cshu@webkit.org>
844
845         Reviewed by Ryosuke Niwa.
846
847         Remove the support of Frame::isContentEditable and its dependencies.
848         https://bugs.webkit.org/show_bug.cgi?id=54292
849
850         Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
851
852         * Api/qwebpage.cpp:
853         (QWebPagePrivate::QWebPagePrivate):
854         (QWebPage::setContentEditable):
855         (QWebPage::isContentEditable):
856         * Api/qwebpage_p.h:
857         * WebCoreSupport/EditorClientQt.cpp:
858         * WebCoreSupport/EditorClientQt.h:
859
860 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
861
862         Reviewed by Oliver Hunt.
863
864         Build fix for Qt port after API changes of http://trac.webkit.org/changeset/79904.
865
866         * Api/qwebelement.cpp:
867         (QWebElement::evaluateJavaScript):
868
869 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
870
871         Reviewed by Andreas Kling.
872
873         [Qt]tst_QDeclarativeWebView - 8 test cases fail
874         https://bugs.webkit.org/show_bug.cgi?id=55214
875
876         Fix the API tests for the QML WebView element. The default size of the element should be the size of the QGraphicsWebView
877         if no preferred width or height are provided (see http://trac.webkit.org/changeset/79672).
878         I also refactored the tests so we don't use the network but instead a local html file.
879         QML doesn't support qrc loading so I had to workaround by using a property that I update afterwards.
880
881         * tests/qdeclarativewebview/resources/sample.html: Added.
882         * tests/qdeclarativewebview/resources/webviewtest.qml:
883         * tests/qdeclarativewebview/resources/webviewtestdefault.qml:
884         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
885         (tst_QDeclarativeWebView::preferredWidthTest):
886         (tst_QDeclarativeWebView::preferredHeightTest):
887         (tst_QDeclarativeWebView::preferredWidthDefaultTest):
888         (tst_QDeclarativeWebView::preferredHeightDefaultTest):
889         * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
890
891 2011-02-28  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
892
893         Reviewed by Andreas Kling.
894
895         [Qt] Add clipped version of QWebElement::render method.
896         Allows faster rendering of web element part.
897         https://bugs.webkit.org/show_bug.cgi?id=50311
898
899         * Api/qwebelement.cpp:
900         (QWebElement::render):
901         * Api/qwebelement.h:
902         * tests/qwebelement/tst_qwebelement.cpp:
903         (tst_QWebElement::render):
904
905 2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>
906
907         Reviewed by Andreas Kling.
908
909         Added full webkit module profile and a syncqt profile.
910
911         This is for modularized Qt.
912
913         [Qt] WebKit patches required to work with a modularized version of Qt
914         https://bugs.webkit.org/show_bug.cgi?id=53916
915
916         * qt_webkit_version.pri:
917
918 2011-02-27  Aparna Nandyal  <aparna.nand@wipro.com>
919
920         Reviewed by Antonio Gomes.
921
922         [Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
923         https://bugs.webkit.org/show_bug.cgi?id=53917
924
925         Adding test case to check the scenario to avoid regressions in the
926         future. 
927
928         * tests/qwebframe/tst_qwebframe.cpp:
929
930 2011-02-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
931
932         Reviewed by Andreas Kling.
933
934         [Qt] Reference the documentation of the WebKit bridge from QWebFrame::addToJavaScriptWindowObject()
935         https://bugs.webkit.org/show_bug.cgi?id=55322
936
937         Documentation update, add a reference to the QtWebKit bridge page.
938
939         * Api/qwebframe.cpp:
940
941 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
942
943         Reviewed by Pavel Feldman.
944
945         DumpRenderTree should reset frame opener between tests.
946         https://bugs.webkit.org/show_bug.cgi?id=54874
947
948         Added clearOpener method to DumpRenderTreeSupportQT.
949
950         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
951         (DumpRenderTreeSupportQt::clearOpener):
952         * WebCoreSupport/DumpRenderTreeSupportQt.h:
953
954 2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
955
956         Reviewed by Andreas Kling.
957
958         Make it possible to test the targetdensity-dpi support
959         https://bugs.webkit.org/show_bug.cgi?id=55142
960
961         Test the viewport meta tag feature targetdensity-dpi by
962         adding extra arguments to dumpConfigurationForViewport
963
964         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
965         (DumpRenderTreeSupportQt::viewportAsText):
966         * WebCoreSupport/DumpRenderTreeSupportQt.h:
967
968 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
969
970         Unreviewed, rolling out r79764.
971         http://trac.webkit.org/changeset/79764
972         https://bugs.webkit.org/show_bug.cgi?id=55295
973
974         "broke Chromium builds" (Requested by rniwa on #webkit).
975
976         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
977         * WebCoreSupport/DumpRenderTreeSupportQt.h:
978
979 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
980
981         Reviewed by Pavel Feldman.
982
983         DumpRenderTree should reset frame opener between tests.
984         https://bugs.webkit.org/show_bug.cgi?id=54874
985
986         Added clearOpener method to DumpRenderTreeSupportQT.
987
988         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
989         (DumpRenderTreeSupportQt::clearOpener):
990         * WebCoreSupport/DumpRenderTreeSupportQt.h:
991
992 2011-02-25  Andras Becsi  <abecsi@webkit.org>
993
994         Reviewed by Csaba Osztrogonác.
995
996         [Qt] Make the WebKit2 build system less confusing for non-Qt developers
997         https://bugs.webkit.org/show_bug.cgi?id=55213
998
999         * QtWebKit.pro: Move the WebKit2 API into a project include file
1000         in the WebKit2 directory and include the pri file here.
1001
1002 2011-02-25  Alexis Menard  <alexis.menard@openbossa.org>
1003
1004         Unreviewed build fix for Intel ICC and MSVC.
1005
1006         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
1007         (tst_QGraphicsWebView::setPalette):
1008         * tests/qwebview/tst_qwebview.cpp:
1009         (tst_QWebView::setPalette):
1010
1011 2011-02-25  Alexis Menard  <alexis.menard@openbossa.org>
1012
1013         Reviewed by Kenneth Rohde Christiansen.
1014
1015         [Qt] Properly propagate the palette to QWebPage from QGraphicsWebView
1016         https://bugs.webkit.org/show_bug.cgi?id=31742
1017
1018         Discovered while looking at 31742. When we set a palette on the
1019         QGraphicsWebView we need to propagate it to the page like QWebView.
1020         I have added the same tests as QWebView to be sure to catch potential
1021         regressions as well as two extras QVERIFY to check the palette propagation.
1022
1023         * Api/qgraphicswebview.cpp:
1024         (QGraphicsWebView::event):
1025         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
1026         (tst_QGraphicsWebView::setPalette_data):
1027         (tst_QGraphicsWebView::setPalette):
1028
1029 2011-02-25  Csaba Osztrogonác  <ossy@webkit.org>
1030
1031         Unreviewed buildfix after r79672.
1032
1033         [Qt] Build tst_qdeclarativewebview if QT_CONFIG contains declarative.
1034
1035         * tests/tests.pri:
1036         * tests/tests.pro:
1037
1038 2011-02-25  Gopal Raghavan  <gopal.1.raghavan@nokia.com>
1039
1040         Reviewed by Kenneth Rohde Christiansen.
1041
1042         [Qt] QML WebView inside a Flickable shows checkers pattern at startup
1043         https://bugs.webkit.org/show_bug.cgi?id=50222.
1044
1045         This patch fixes the checkerboard visible at startup even if preferredWidth and preferredHeight are not set.
1046
1047         * declarative/qdeclarativewebview.cpp:
1048         (QDeclarativeWebView::init):
1049         * tests/qdeclarativewebview: Added.
1050         * tests/qdeclarativewebview/qdeclarativewebview.pro: Added.
1051         * tests/qdeclarativewebview/resources: Added.
1052         * tests/qdeclarativewebview/resources/webviewtest.qml: Added.
1053         * tests/qdeclarativewebview/resources/webviewtestdefault.qml: Added.
1054         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Added.
1055         (tst_QDeclarativeWebView::initTestCase):
1056         (tst_QDeclarativeWebView::cleanupTestCase):
1057         (tst_QDeclarativeWebView::init):
1058         (tst_QDeclarativeWebView::cleanup):
1059         (tst_QDeclarativeWebView::preferredWidthTest):
1060         (tst_QDeclarativeWebView::preferredHeightTest):
1061         (tst_QDeclarativeWebView::preferredWidthDefaultTest):
1062         (tst_QDeclarativeWebView::preferredHeightDefaultTest):
1063         (tst_QDeclarativeWebView::checkNoErrors):
1064         * tests/tests.pri:
1065         * tests/tests.pro:
1066
1067 2011-02-24  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1068
1069         Reviewed by Andreas Kling.
1070
1071         [Qt] Revert the support for QNAM affined to a different thread.
1072         https://bugs.webkit.org/show_bug.cgi?id=55149
1073
1074         Qt 4.8 will have QNAM use its own thread internally by default,
1075         no need to keep this complexity in WebKit.
1076
1077         This mainly reverts:
1078         http://trac.webkit.org/changeset/73710
1079         http://trac.webkit.org/changeset/73712
1080
1081         * WebCoreSupport/FrameLoaderClientQt.cpp:
1082         (WebCore::FrameLoaderClientQt::download):
1083         * tests/qwebpage/tst_qwebpage.cpp:
1084
1085 2011-02-24  Sam Weinig  <sam@webkit.org>
1086
1087         Try to fix the Qt build.
1088
1089         * QtWebKit.pro:
1090
1091 2011-02-24  Peter Kasting  <pkasting@google.com>
1092
1093         Reviewed by Eric Seidel.
1094
1095         Drop the "U; " encryption level from the User Agent string.
1096         https://bugs.webkit.org/show_bug.cgi?id=54566
1097
1098         * Api/qwebpage.cpp:
1099         (QWebPage::userAgentForUrl):
1100
1101 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
1102
1103         Unreviewed, rolling out r79570.
1104         http://trac.webkit.org/changeset/79570
1105         https://bugs.webkit.org/show_bug.cgi?id=54874
1106
1107         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
1108         was not updated
1109
1110         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1111         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1112
1113 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
1114
1115         Reviewed by Alexey Proskuryakov.
1116
1117         DumpRenderTree should reset frame opener between tests.
1118         https://bugs.webkit.org/show_bug.cgi?id=54874
1119
1120         Added clearOpener method to DumpRenderTreeSupportQT.
1121
1122         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1123         (DumpRenderTreeSupportQt::clearOpener):
1124         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1125
1126 2011-02-24  Alexis Menard  <alexis.menard@openbossa.org>
1127
1128         Reviewed by Andreas Kling.
1129
1130         [Qt] tst_QWebView::setPalette(activeFG) fails
1131         https://bugs.webkit.org/show_bug.cgi?id=55029
1132
1133         This time it should be the proper fix. The window needs to be shown before we
1134         call activateWindow() otherwise there is no active windows for the application.
1135
1136         * tests/qwebview/tst_qwebview.cpp:
1137         (tst_QWebView::setPalette):
1138
1139 2011-02-24  Andras Becsi  <abecsi@webkit.org>
1140
1141         Reviewed by Laszlo Gombos.
1142
1143         [Qt] MinGW build fails to link
1144         https://bugs.webkit.org/show_bug.cgi?id=55050
1145
1146         Prepend the libraries of subcomponents instead of appending them
1147         to fix the library order according to the dependency of the libraries
1148
1149         * QtWebKit.pro: prepend libraries in the correct order
1150
1151 2011-02-23  Alexis Menard  <alexis.menard@openbossa.org>
1152
1153         Reviewed by Ariya Hidayat.
1154
1155         [Qt] tst_QWebView::setPalette(activeFG) fails
1156         https://bugs.webkit.org/show_bug.cgi?id=55029
1157
1158         Attempt to make the test more robust. By investigating with the bot virtual machine
1159         I discovered that the activation can take some time. In this patch we make sure that
1160         the active window we want to have is the same as the QApplication.
1161
1162         * tests/qwebview/tst_qwebview.cpp:
1163         (tst_QWebView::setPalette):
1164
1165 2011-02-23  Alexis Menard  <alexis.menard@openbossa.org>
1166
1167         Reviewed by Dan Bernstein.
1168
1169         [Qt]REGRESSION(r79167): It broke 3 Qt-API test cases
1170         http://trac.webkit.org/changeset/79167 refactored the way the bound size of
1171         the frame is handled. A new API setBoundsSize was added, we need to call it
1172         in addition to setFrameRect. I could call setBoundSize after setFrameRect but
1173         I thought It would be more elegant to use the resize method.
1174
1175         * Api/qwebpage.cpp:
1176         (QWebPage::setViewportSize):
1177
1178 2011-02-22  Fabrizio Machado  <fabrizio.machado@nokia.com>
1179
1180         Reviewed by Laszlo Gombos.
1181
1182         [Qt] Don't fall through case in variantToSetting() if qvariant.type() is Bool
1183         https://bugs.webkit.org/show_bug.cgi?id=54976
1184
1185         Test not needed.
1186         
1187         * WebCoreSupport/InspectorClientQt.cpp:
1188
1189 2011-02-22  Alexis Menard  <alexis.menard@openbossa.org>
1190
1191         Reviewed by Andreas Kling.
1192
1193         [Qt] QWebView ignores a palette set with QWebView::setPalette()
1194         https://bugs.webkit.org/show_bug.cgi?id=31742
1195
1196         Test case to check that the palette sets on the QWebView is taken
1197         into account.
1198
1199         * tests/qwebview/tst_qwebview.cpp:
1200         (tst_QWebView::setPalette_data):
1201         (tst_QWebView::setPalette):
1202
1203 2011-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1204
1205         Reviewed by Alexey Proskuryakov.
1206
1207         Drop the language tag part from the User Agent string
1208         https://bugs.webkit.org/show_bug.cgi?id=54560
1209
1210         * Api/qwebpage.cpp:
1211         (QWebPage::userAgentForUrl):
1212
1213         * tests/qwebpage/tst_qwebpage.cpp: Remove the userAgentLocaleChange
1214         test.
1215
1216 2011-02-22  Chang Shu  <cshu@webkit.org>
1217
1218         Reviewed by Csaba Osztrogonác.
1219
1220         [Qt] editing/deleting/5408255.html fails
1221         https://bugs.webkit.org/show_bug.cgi?id=54964
1222
1223         Move WebCore resource file to QtWebKit since they are referred in WebKit.
1224
1225         * QtWebKit.pro:
1226
1227 2011-02-22  Andras Becsi  <abecsi@webkit.org>
1228
1229         Reviewed by Csaba Osztrogonác.
1230
1231         [Qt] Redesign the build system
1232         https://bugs.webkit.org/show_bug.cgi?id=51339
1233
1234         Move inspector's resource files into the final build step to fix the layout test regression.
1235
1236         * QtWebKit.pro: Add inspector's reaource files.
1237
1238 2011-02-22  Andras Becsi  <abecsi@webkit.org>
1239
1240         Reviewed by Laszlo Gombos.
1241         Rubber-stamped by Csaba Osztrogonác.
1242
1243         [Qt] Redesign the build system
1244         https://bugs.webkit.org/show_bug.cgi?id=51339
1245
1246         The patch landed in r79320 didn't contain the cleanup
1247         which was already addressed in the last attachment.
1248
1249         * QtWebKit.pro: Move common LIB and CONFIG options to WebCore.pri.
1250
1251 2011-02-22  Andras Becsi  <abecsi@webkit.org>
1252
1253         Reviewed by Laszlo Gombos.
1254
1255         [Qt] Redesign the build system
1256         https://bugs.webkit.org/show_bug.cgi?id=51339
1257
1258         Part 2.
1259
1260         Build WebCore as a static library, compile the WebKit API and WebKit2 API
1261         in a final step and link to WebKit2, WebCore and JSC libraries to fix
1262         linking issues resulting from stripped away symbols.
1263
1264         * QtWebKit.pro: Added.
1265         Project file for the final build step.
1266
1267 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
1268
1269         Reviewed by Kent Tamura.
1270
1271         Rename Position::node() to Position::deprecatedNode()
1272         https://bugs.webkit.org/show_bug.cgi?id=54622
1273
1274         Replaced the call to node() by a call to containerNode() because the returned node is
1275         used to determine whether or not the selected contents are editable and such a check
1276         must be done against the container node.
1277
1278         * WebCoreSupport/EditorClientQt.cpp:
1279         (WebCore::EditorClientQt::handleKeyboardEvent):
1280
1281 2011-02-19  Charlie Reis  <creis@chromium.org>
1282
1283         Reviewed by Mihai Parparita.
1284
1285         Ensure loading has stopped in HistoryController::goToItem
1286         https://bugs.webkit.org/show_bug.cgi?id=54517
1287
1288         Add a FrameLoaderClient callback for whether to stop loading before goToItem.
1289
1290         Test: http/tests/navigation/forward-to-fragment-fires-onload.html
1291
1292         * WebCoreSupport/FrameLoaderClientQt.cpp:
1293         (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): Added.
1294         * WebCoreSupport/FrameLoaderClientQt.h:
1295
1296 2011-02-18  Fabrizio Machado  <fabrizio.machado@nokia.com>
1297
1298         Reviewed by Eric Seidel.
1299
1300         Remove reduntant checks.
1301         https://bugs.webkit.org/show_bug.cgi?id=54764
1302         
1303
1304         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1305         (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
1306         * WebCoreSupport/NotificationPresenterClientQt.cpp:
1307         (WebCore::NotificationPresenterClientQt::toPage):
1308
1309 2011-02-18  Csaba Osztrogonác  <ossy@webkit.org>
1310
1311         Unreviewed.
1312
1313         [Qt] Buildfix for platforms with geolocation disabled.
1314
1315         * Api/qwebpage.cpp: Add the missing guard.
1316
1317 2011-02-18  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1318
1319         Reviewed by Kenneth Rohde Christiansen.
1320
1321         [Qt] Implement client based geolocation for qtport
1322         https://bugs.webkit.org/show_bug.cgi?id=42629
1323
1324         Implements client based geolocation for qtwebkit.
1325         New client based geolocation contains permission API's as well,
1326         so removed the implementation from ChromeClientQt.cpp. 
1327
1328         * Api/qwebpage.cpp:
1329         (QWebPagePrivate::QWebPagePrivate):
1330         * WebCoreSupport/ChromeClientQt.cpp:
1331         * WebCoreSupport/ChromeClientQt.h:
1332         (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
1333         (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
1334         * WebCoreSupport/GeolocationClientQt.cpp: Added.
1335         (WebCore::GeolocationClientQt::GeolocationClientQt):
1336         (WebCore::GeolocationClientQt::~GeolocationClientQt):
1337         (WebCore::GeolocationClientQt::geolocationDestroyed):
1338         (WebCore::GeolocationClientQt::positionUpdated):
1339         (WebCore::GeolocationClientQt::startUpdating):
1340         (WebCore::GeolocationClientQt::stopUpdating):
1341         (WebCore::GeolocationClientQt::setEnableHighAccuracy):
1342         (WebCore::GeolocationClientQt::requestPermission):
1343         (WebCore::GeolocationClientQt::cancelPermissionRequest):
1344         * WebCoreSupport/GeolocationClientQt.h: Added.
1345         (WebCore::GeolocationClientQt::lastPosition):
1346
1347 2011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
1348
1349         Reviewed by Adam Roben.
1350
1351         HTML5 <details> and <summary>: localized text
1352         https://bugs.webkit.org/show_bug.cgi?id=54260
1353
1354         The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
1355         provide the default label to be used by a <details> tag that has no <summary> child.
1356
1357         * WebCoreSupport/WebPlatformStrategies.cpp:
1358         (WebPlatformStrategies::defaultDetailsSummaryText):
1359         * WebCoreSupport/WebPlatformStrategies.h:
1360
1361 2011-02-17  Hui Huang  <hui.2.huang@nokia.com>
1362
1363         Reviewed by Laszlo Gombos.
1364
1365         The URL of HTML5 Video Element is percent encoded at websites such as youtube.
1366         It is percent encoded again by QUrl constructor QUrl::QUrl(QString). This causes
1367         the HTTP GET request for the video to be rejected by the service provider. 
1368         https://bugs.webkit.org/show_bug.cgi?id=53973.
1369
1370         The bug is fixed by constructing QUrl from the encoded URL in 
1371         MediaPlayerPrivateQt::commitLoad. 
1372
1373         New test function tst_QWebPage::loadHtml5Video() is added to load HTML content with
1374         HTML5 Video element. A new public method DumpRenderTreeSupportQt::mediaContentUrlByElementId
1375         is added to retrieve the URL of the media content from WebCore MediaPlayerPrivateQt.
1376         A new macro ENABLE_QT_MULTIMEDIA is introduced in tests.pri to make sure that the test
1377         is skipped if Qt Multimedia is not available.
1378
1379         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1380         (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
1381         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1382         * tests/qwebpage/tst_qwebpage.cpp:
1383         (tst_QWebPage::loadHtml5Video):
1384         * tests/tests.pri:
1385
1386 2011-02-17  Andreas Kling  <kling@webkit.org>
1387
1388         Reviewed by Antti Koivisto.
1389
1390         [Qt] Crash when calling QWebFrame::setUrl() while a previous load has pending requests
1391         https://bugs.webkit.org/show_bug.cgi?id=49216
1392
1393         * tests/qwebframe/tst_qwebframe.cpp:
1394
1395 == Rolled over to ChangeLog-2011-02-16 ==