f4bb9a89d523a8612c525be65bc4b922cd47828b
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2014-12-05  David Kilzer  <ddkilzer@apple.com>
2
3         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
4         <http://webkit.org/b/139286>
5
6         Reviewed by Daniel Bates.
7
8         * Configurations/FeatureDefines.xcconfig: Switch back to using
9         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
10
11 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
12
13         Fix the 32-bit build.
14
15         * WebView/WebView.mm:
16         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
17
18 2014-12-04  Tim Horton  <timothy_horton@apple.com>
19
20         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
21         https://bugs.webkit.org/show_bug.cgi?id=139252
22         <rdar://problem/19140827>
23
24         Reviewed by Anders Carlsson.
25
26         * WebView/WebView.mm:
27         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
28         Adjust to the WebCore changes.
29
30 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
31
32         Implement action menus for tel: URLs
33         https://bugs.webkit.org/show_bug.cgi?id=139240
34         <rdar://problem/19115662>
35
36         Reviewed by Anders Carlsson.
37
38         * WebView/WebActionMenuController.mm:
39         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
40         Make sure to use the newly created currentActionContext... everywhere.
41
42 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
43
44         Implement action menus for tel: URLs
45         https://bugs.webkit.org/show_bug.cgi?id=139240
46         <rdar://problem/19115662>
47
48         Reviewed by Anders Carlsson.
49
50         * WebView/WebActionMenuController.mm:
51         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
52         Make sure to use the newly created currentActionContext.
53
54 2014-12-03  Beth Dakin  <bdakin@apple.com>
55
56         <input> elements get whitespace action menu instead of editable text menu
57         https://bugs.webkit.org/show_bug.cgi?id=139241
58         -and corresponding-
59         rdar://problem/19072083
60
61         Reviewed by Sam Weinig.
62
63         We should disallow shadow content in the hit test. This is the default and it is 
64         how context menus behave. We originally wanted to text inside shadow content so 
65         that we could find the text, but the new function I added to HitTestResult will 
66         allow that.
67         * WebView/WebActionMenuController.mm:
68         (-[WebActionMenuController performHitTestAtPoint:]):
69
70         Adjust to the fact that we don’t hit test shadow content any more.
71         (-[WebActionMenuController focusAndSelectHitTestResult]):
72
73         Offer the text menus for text inside form controls.
74         (-[WebActionMenuController _defaultMenuItems]):
75
76 2014-12-03  Tim Horton  <timothy_horton@apple.com>
77
78         Implement action menus for tel: URLs
79         https://bugs.webkit.org/show_bug.cgi?id=139240
80         <rdar://problem/19115662>
81
82         Reviewed by Anders Carlsson.
83
84         * WebView/WebActionMenuController.mm:
85         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
86         Rename this function as it will work for both mailto and tel URLs.
87         Adjust it to use contextForView:.
88
89         (-[WebActionMenuController webView:willHandleMouseDown:]):
90         (-[WebActionMenuController prepareForMenu:withEvent:]):
91         (-[WebActionMenuController didCloseMenu:withEvent:]):
92         (-[WebActionMenuController _defaultMenuItems]):
93         Don't check the menu type when going to interact with _currentActionContext.
94         We'll only have a _currentActionContext if we have a data detected item,
95         and there are multiple menu types that end up using DDActionContext.
96
97         * WebView/WebUIDelegatePrivate.h:
98         Add a new type.
99
100 2014-12-03  Anders Carlsson  <andersca@apple.com>
101
102         Set a visited link store when creating a simple WebView
103         https://bugs.webkit.org/show_bug.cgi?id=139234
104         <rdar://problem/19132978>
105
106         Reviewed by Sam Weinig.
107
108         * WebView/WebView.mm:
109         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
110
111 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
112
113         Fix the build.
114
115         * WebCoreSupport/WebFrameLoaderClient.mm:
116
117 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
118
119         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
120         https://bugs.webkit.org/show_bug.cgi?id=139149
121
122         Reviewed by Anders Carlsson.
123
124         This changes API behavior. I think that it's OK, because existing behavior made no sense.
125         We used to delete caches from disk, but they were still active in memory. Now we also
126         obsolete them in memory, so documents that use a cache still work, but new ones don't
127         pick one up.
128
129         * WebCoreSupport/WebApplicationCache.mm:
130         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
131         need to delete in-momry caches too. Keep existing behavior.
132         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
133         that properly deletes caches.
134
135 2014-12-02  Tim Horton  <timothy_horton@apple.com>
136
137         Remove a SnowLeopard-era quirk for QuickLook
138         https://bugs.webkit.org/show_bug.cgi?id=139208
139         <rdar://problem/19121822>
140
141         Reviewed by Alexey Proskuryakov.
142
143         * WebCoreSupport/WebFrameLoaderClient.h:
144         * WebCoreSupport/WebFrameLoaderClient.mm:
145
146 2014-12-02  Tim Horton  <timothy_horton@apple.com>
147
148         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
149         https://bugs.webkit.org/show_bug.cgi?id=139204
150
151         Reviewed by Anders Carlsson.
152
153         * WebView/WebView.mm:
154         (-[WebView _commonInitializationWithFrameName:groupName:]):
155         (-[WebView _showDictionaryLookupPopup:]):
156         * WebView/WebViewData.h:
157         Work around this by delaying the softlinking (and setting up the notification
158         observer) until we actually need it. There's still an underlying bug, but
159         this will fix the test.
160
161 2014-12-02  Beth Dakin  <bdakin@apple.com>
162
163         Yet another build fix.
164
165         * WebView/WebActionMenuController.mm:
166         (-[WebActionMenuController _defaultMenuItemsForLink]):
167
168 2014-12-02  Beth Dakin  <bdakin@apple.com>
169
170         Build fix.
171
172         * WebView/WebActionMenuController.mm:
173         (-[WebActionMenuController _defaultMenuItemsForLink]):
174
175 2014-12-02  Beth Dakin  <bdakin@apple.com>
176
177         More build fixing.
178
179         * WebView/WebActionMenuController.mm:
180         (-[WebActionMenuController _defaultMenuItemsForLink]):
181
182 2014-12-02  Beth Dakin  <bdakin@apple.com>
183
184         Should use standardQuickLookMenuItem for apps that don't implement customizations
185         https://bugs.webkit.org/show_bug.cgi?id=139193
186         -and corresponding-
187         rdar://problem/18944696
188
189         Reviewed by Anders Carlsson.
190
191         Use [NSMenuItem standardQuickLookMenuItem].
192         * WebView/WebActionMenuController.mm:
193         (-[WebActionMenuController _defaultMenuItemsForLink]):
194
195         Delegate methods to set up the standardQuickLookMenuItem.
196         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
197         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
198         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
199
200         Remove all of the old QLPreviewBubble code.
201         (-[WebActionMenuController _createActionMenuItemForTag:]):
202         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
203
204 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
205
206         Fix the build.
207
208         * WebView/WebViewData.h:
209
210 2014-12-02  Tim Horton  <timothy_horton@apple.com>
211
212         Implement Lookup transition from selection for Legacy WebKit
213         https://bugs.webkit.org/show_bug.cgi?id=139180
214         <rdar://problem/19067172>
215
216         Reviewed by Beth Dakin.
217
218         * WebView/DictionaryPopupInfo.h: Added.
219         Split DictionaryPopupInfo out into its own file.
220
221         * WebView/WebActionMenuController.mm:
222         (-[WebActionMenuController _lookupText:]):
223         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
224
225         (performDictionaryLookupForSelection):
226         (performDictionaryLookupForRange):
227         Plumb the transition style through these helpers.
228         Create a TextIndicator from the selection range.
229
230         * WebView/WebHTMLView.mm:
231         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
232         Make use of TextIndicator (and DictionaryPopupInfo, and the new
233         _showDictionaryLookupPopup on WebView) to add a transition from blue
234         when performing Lookup from the context menu.
235
236         (-[WebHTMLView quickLookWithEvent:]):
237         Remove our TextIndicator whenever a normal three-finger-tap event
238         comes through, as it will have its own indication.
239
240         * WebView/WebView.mm:
241         (-[WebView _commonInitializationWithFrameName:groupName:]):
242         (-[WebView _dictionaryLookupPopoverWillClose:]):
243         Register for the LUNotificationPopoverWillClose notification and remove
244         our TextIndicator when it is called, just like in WebKit2.
245         Deregistration is already handled in _close.
246
247         (-[WebView _showDictionaryLookupPopup:]):
248         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
249         if the relevant API is available.
250
251         * WebView/WebViewInternal.h:
252
253 2014-12-02  Anders Carlsson  <andersca@apple.com>
254
255         Remove visited link handling from PageGroup
256         https://bugs.webkit.org/show_bug.cgi?id=139185
257
258         Reviewed by Sam Weinig.
259
260         * History/WebHistory.mm:
261         (-[WebHistoryPrivate removeItemForURLString:]):
262         (-[WebHistoryPrivate removeAllItems]):
263         (+[WebHistory setOptionalSharedHistory:]):
264         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
265         (+[WebHistory _removeAllVisitedLinks]):
266         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
267         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
268         * History/WebHistoryInternal.h:
269         * WebCoreSupport/WebChromeClient.h:
270         * WebCoreSupport/WebChromeClient.mm:
271         (WebChromeClient::populateVisitedLinks): Deleted.
272         * WebView/WebView.mm:
273         (-[WebView addVisitedLinks:]):
274         (-[WebView removeVisitedLink:]):
275
276 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
277
278         Try to fix the Mac build.
279
280         * WebView/WebView.mm:
281         (-[WebView _commonInitializationWithFrameName:groupName:]):
282         (-[WebView _close]):
283
284 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
285
286         Fix the iOS build.
287
288         * WebView/WebActionMenuController.h:
289         * WebView/WebActionMenuController.mm:
290         * WebView/WebHTMLView.mm:
291         (-[WebHTMLView scrollWheel:scrollWheel:]):
292         (-[WebHTMLView mouseDown:mouseDown:]):
293         * WebView/WebView.mm:
294         * WebView/WebViewData.h:
295         * WebView/WebViewData.mm:
296         (-[WebViewPrivate dealloc]):
297         * WebView/WebViewInternal.h:
298
299 2014-12-01  Tim Horton  <timothy_horton@apple.com>
300
301         Implement yellow highlight for WebKit1 data detectors
302         https://bugs.webkit.org/show_bug.cgi?id=138956
303         <rdar://problem/18992185>
304
305         Reviewed by Beth Dakin.
306
307         * WebView/WebActionMenuController.h:
308         * WebView/WebActionMenuController.mm:
309         (-[WebActionMenuController webView:willHandleMouseDown:]):
310         (-[WebActionMenuController webView:didHandleScrollWheel:]):
311         (-[WebActionMenuController prepareForMenu:withEvent:]):
312         (-[WebActionMenuController didCloseMenu:withEvent:]):
313         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
314         (-[WebActionMenuController _showTextIndicator]):
315         (-[WebActionMenuController _hideTextIndicator]):
316         (-[WebActionMenuController _dismissActionMenuPopovers]):
317         Copy the WebKit2 WKActionMenuController TextIndicator implementation
318         into WebActionMenuController. The only significant difference is
319         that we build the TextIndicator right at menu construction time
320         instead of in the Web process.
321
322         * WebView/WebHTMLView.mm:
323         (-[WebHTMLView scrollWheel:]):
324         Let the WebActionMenuController know that we're handling a scroll.
325
326         (-[WebHTMLView mouseDown:]):
327         Let the WebActionMenuController know that we're handling a mouseDown.
328
329         * WebView/WebView.mm:
330         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
331         (-[WebView _clearTextIndicator]):
332         (-[WebView _actionMenuController]):
333         (-[WebView _convertRectFromRootView:]): Deleted.
334         * WebView/WebViewData.h:
335         * WebView/WebViewData.mm:
336         * WebView/WebViewInternal.h:
337         Keep a TextIndicatorWindow on WebView, just like WKView does.
338         Expose the WebActionMenuController on WebView (internally).
339
340 2014-12-01  Anders Carlsson  <andersca@apple.com>
341
342         Remove old site specific quirks code that was added in 2009
343         https://bugs.webkit.org/show_bug.cgi?id=139141
344
345         Reviewed by Antti Koivisto.
346
347         * WebCoreSupport/WebFrameNetworkingContext.h:
348         * WebCoreSupport/WebFrameNetworkingContext.mm:
349         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
350
351 2014-11-30  Anders Carlsson  <andersca@apple.com>
352
353         Fix a test failure.
354
355         * History/WebHistory.mm:
356         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
357         Call through to the visited link store.
358
359         (+[WebHistory _removeAllVisitedLinks]):
360         Ditto.
361
362         * WebCoreSupport/WebVisitedLinkStore.mm:
363         (WebVisitedLinkStore::isLinkVisited):
364         Make sure to populate visited links.
365
366 2014-11-30  Anders Carlsson  <andersca@apple.com>
367
368         Switch over to the visited link store from the WebViewGroup
369         https://bugs.webkit.org/show_bug.cgi?id=139112
370
371         Reviewed by Sam Weinig.
372
373         * WebView/WebView.mm:
374         (-[WebView _commonInitializationWithFrameName:groupName:]):
375         (-[WebView setGroupName:]):
376
377 2014-11-30  Anders Carlsson  <andersca@apple.com>
378
379         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
380         https://bugs.webkit.org/show_bug.cgi?id=139111
381
382         Reviewed by Sam Weinig.
383
384         * WebCoreSupport/WebVisitedLinkStore.h:
385         * WebCoreSupport/WebVisitedLinkStore.mm:
386         (WebVisitedLinkStore::removeVisitedLink):
387         * WebView/WebView.mm:
388         (-[WebView removeVisitedLink:]):
389
390 2014-11-29  Anders Carlsson  <andersca@apple.com>
391
392         Populate visited links
393         https://bugs.webkit.org/show_bug.cgi?id=139101
394
395         Reviewed by Sam Weinig.
396
397         * History/WebHistory.mm:
398         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
399         Helper function that adds all visited link to the given store.
400
401         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
402         Call the private method.
403
404         * History/WebHistoryInternal.h:
405         * WebCoreSupport/WebVisitedLinkStore.h:
406         Add new members.
407
408         * WebCoreSupport/WebVisitedLinkStore.mm:
409         (WebVisitedLinkStore::addVisitedLink):
410         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
411
412         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
413         Implement this. First try the delegate, then try the shared history.
414
415         (WebVisitedLinkStore::addVisitedLinkHash):
416         Factor code that adds the link to the hash table into a separate function.
417
418         * WebView/WebView.mm:
419         (-[WebView addVisitedLinks:]):
420         Add the visited links to the store.
421
422 2014-11-29  Anders Carlsson  <andersca@apple.com>
423
424         More work on the legacy WebKit visited link store
425         https://bugs.webkit.org/show_bug.cgi?id=139100
426
427         Reviewed by Sam Weinig.
428
429         * History/WebHistory.mm:
430         (+[WebHistory setOptionalSharedHistory:]):
431         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
432
433         * WebCoreSupport/WebVisitedLinkStore.h:
434         * WebCoreSupport/WebVisitedLinkStore.mm:
435         (visitedLinkStores):
436         (WebVisitedLinkStore::WebVisitedLinkStore):
437         (WebVisitedLinkStore::~WebVisitedLinkStore):
438         Keep track of live visited link stores.
439
440         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
441         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
442
443         (WebVisitedLinkStore::removeAllVisitedLinks):
444         Iterate over all live link stores and remove their links.
445
446         (WebVisitedLinkStore::isLinkVisited):
447         Populate visited links and check if our hash table contains the link.
448
449         (WebVisitedLinkStore::addVisitedLink):
450         Add the link hash to the table.
451
452         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
453         Add stub.
454
455         (WebVisitedLinkStore::removeVisitedLinkHashes):
456         Clear out the hash table.
457
458 2014-11-27  Anders Carlsson  <andersca@apple.com>
459
460         Add a stubbed out WebVisitedLinkStore to WebViewGroup
461         https://bugs.webkit.org/show_bug.cgi?id=139066
462
463         Reviewed by Antti Koivisto.
464
465         * WebCoreSupport/WebViewGroup.h:
466         (WebViewGroup::visitedLinkStore):
467         * WebCoreSupport/WebViewGroup.mm:
468         (WebViewGroup::WebViewGroup):
469         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
470         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
471         (WebVisitedLinkStore::create):
472         (WebVisitedLinkStore::WebVisitedLinkStore):
473         (WebVisitedLinkStore::~WebVisitedLinkStore):
474         (WebVisitedLinkStore::isLinkVisited):
475         (WebVisitedLinkStore::addVisitedLink):
476
477 2014-11-25  Anders Carlsson  <andersca@apple.com>
478
479         Remove user content handling from PageGroup
480         https://bugs.webkit.org/show_bug.cgi?id=139051
481
482         Reviewed by Antti Koivisto.
483
484         Use the user content controller in the web view group.
485
486         * WebView/WebView.mm:
487         (-[WebView _injectOutlookQuirksScript]):
488
489 2014-11-25  Anders Carlsson  <andersca@apple.com>
490
491         Add a user content controller to WebViewGroup and use it for user content
492         https://bugs.webkit.org/show_bug.cgi?id=139043
493
494         Reviewed by Antti Koivisto.
495
496         This is another tiny step towards getting rid of user content handling inside PageGroup.
497
498         * WebCoreSupport/WebViewGroup.h:
499         (WebViewGroup::userContentController):
500         Add a UserContentController member and getter.
501
502         * WebCoreSupport/WebViewGroup.mm:
503         (WebViewGroup::get):
504         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
505
506         (WebViewGroup::WebViewGroup):
507         Create a user content controller.
508
509         * WebView/WebView.mm:
510         (-[WebView _commonInitializationWithFrameName:groupName:]):
511         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
512         set its user content controller in the PageConfiguration.
513
514         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
515         Ditto.
516
517         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
518         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
519         (+[WebView _removeUserScriptFromGroup:world:url:]):
520         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
521         (+[WebView _removeUserScriptsFromGroup:world:]):
522         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
523         (+[WebView _removeAllUserContentFromGroup:]):
524         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
525
526         (-[WebView setGroupName:]):
527         Set the user content controller to the new WebViewGroup's user content controller.
528
529 2014-11-21  Jer Noble  <jer.noble@apple.com>
530
531         Support multiple signatures of diagnostic logging.
532         https://bugs.webkit.org/show_bug.cgi?id=138690
533
534         Reviewed by Anders Carlsson.
535
536         Page::PageClients has been renamed PageConfiguration.
537
538         * WebView/WebView.mm:
539         (-[WebView _commonInitializationWithFrameName:groupName:]):
540         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
541
542 2014-11-21  Zalan Bujtas  <zalan@apple.com>
543
544         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
545         https://bugs.webkit.org/show_bug.cgi?id=138981
546
547         Reviewed by Simon Fraser.
548
549         * WebView/WebPreferenceKeysPrivate.h:
550         * WebView/WebPreferences.mm:
551         (+[WebPreferences initialize]):
552         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
553         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
554         * WebView/WebPreferencesPrivate.h:
555         * WebView/WebView.mm:
556         (-[WebView _preferencesChanged:]):
557
558 2014-11-21  Tim Horton  <timothy_horton@apple.com>
559
560         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
561         ​https://bugs.webkit.org/show_bug.cgi?id=138960
562         <rdar://problem/19056715>
563
564         Reviewed by Anders Carlsson.
565
566         * WebView/WebActionMenuController.mm:
567         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
568         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
569         Use DataDetectors SPI instead of an explicit blacklist.
570
571 2014-11-21  Tim Horton  <timothy_horton@apple.com>
572
573         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
574         https://bugs.webkit.org/show_bug.cgi?id=138960
575         <rdar://problem/19056715>
576
577         Reviewed by Beth Dakin.
578
579         * WebView/WebActionMenuController.mm:
580         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
581         Blacklist contact results, because they don't have useful menus. If we
582         bail before setting up _currentActionContext, we'll still allow fallthrough
583         to ordinary text actions, avoiding mysterious failure when a contact is detected.
584
585         This doesn't break the case that r176351 was intended to fix,
586         because in that case we were detecting e.g. addresses.
587
588 2014-11-21  Anders Carlsson  <andersca@apple.com>
589
590         Remove the Timer parameters from timer callbacks
591         https://bugs.webkit.org/show_bug.cgi?id=138974
592
593         Reviewed by Antti Koivisto.
594
595         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
596         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
597         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
598         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
599         * Plugins/WebNetscapePluginStream.h:
600         * Plugins/WebNetscapePluginStream.mm:
601         (WebNetscapePluginStream::WebNetscapePluginStream):
602         (WebNetscapePluginStream::deliverDataTimerFired):
603
604 2014-11-21  Anders Carlsson  <andersca@apple.com>
605
606         Make memoryCache() return a reference
607         https://bugs.webkit.org/show_bug.cgi?id=138939
608
609         Reviewed by Antti Koivisto.
610
611         * Misc/WebCache.mm:
612         (+[WebCache statistics]):
613         (+[WebCache emptyInMemoryResources]):
614         (+[WebCache sizeOfDeadResources:]):
615         (+[WebCache addImageToCache:forURL:forFrame:]):
616         (+[WebCache removeImageFromCacheForURL:forFrame:]):
617         (+[WebCache imageForURL:]):
618         (+[WebCache setDisabled:]):
619         (+[WebCache isDisabled]):
620         * WebView/WebView.mm:
621         (+[WebView _setCacheModel:]):
622
623 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
624
625         Remove the remaining vestiges of minimal-ui
626         https://bugs.webkit.org/show_bug.cgi?id=138890
627
628         Reviewed by Sam Weinig.
629
630         * History/WebHistoryItem.mm:
631         * History/WebHistoryItemPrivate.h:
632
633 2014-11-20  Tim Horton  <timothy_horton@apple.com>
634
635         Cancel DataDetectors menu earlier if we know it can't be presented
636         https://bugs.webkit.org/show_bug.cgi?id=138922
637         <rdar://problem/18950441>
638
639         Reviewed by Beth Dakin.
640
641         * WebView/WebActionMenuController.mm:
642         (-[WebActionMenuController prepareForMenu:withEvent:]):
643         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
644         and use a bigger hammer (removeAllItems).
645
646         (-[WebActionMenuController willOpenMenu:withEvent:]):
647         If we end up with a menu with no items, don't change selection or anything.
648
649 2014-11-20  Beth Dakin  <bdakin@apple.com>
650
651         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
652         https://bugs.webkit.org/show_bug.cgi?id=138568
653         -and corresponding-
654         rdar://problem/18904600
655
656         Reviewed by Tim Horton.
657
658         Skip images for lookup.
659         * WebView/WebActionMenuController.mm:
660         (performDictionaryLookupForRange):
661
662 2014-11-19  Beth Dakin  <bdakin@apple.com>
663
664         Invoking an action menu on a selection should result in the text menu
665         https://bugs.webkit.org/show_bug.cgi?id=138892
666         -and corresponding-
667         rdar://problem/18996776
668
669         Reviewed by Tim Horton.
670
671         * WebView/WebActionMenuController.mm:
672         (-[WebActionMenuController _defaultMenuItems]):
673
674 2014-11-19  Beth Dakin  <bdakin@apple.com>
675
676         Data detected results with no menu items should not fall through to regular text 
677         action menus
678         https://bugs.webkit.org/show_bug.cgi?id=138887
679         -and corresponding-
680         rdar://problem/18971616
681
682         Reviewed by Tim Horton.
683
684         * WebView/WebActionMenuController.mm:
685         (-[WebActionMenuController _defaultMenuItems]):
686
687 2014-11-19  Daniel Bates  <dabates@apple.com>
688
689         [iOS] Make WebKit build with public iOS SDK
690         https://bugs.webkit.org/show_bug.cgi?id=136863
691
692         Reviewed by David Kilzer.
693
694         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
695         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
696         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
697         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
698         may be used by Apple internal clients that do not include wtf/Platform.h.
699         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
700         private Foundation headers directly.
701         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
702         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
703         instead of including private CFNetwork headers directly. Also fixed up style and
704         ordering of header include directives.
705         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
706         CFNetwork headers directly. Also sort the #import directives.
707         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
708         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
709
710 2014-11-18  David Kilzer  <ddkilzer@apple.com>
711
712         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
713         <http://webkit.org/b/138813>
714
715         Reviewed by Mark Rowe.
716
717         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
718         selectors.
719
720 2014-11-18  Chris Dumez  <cdumez@apple.com>
721
722         Add a setting to toggle DOMTimer throttling support
723         https://bugs.webkit.org/show_bug.cgi?id=138844
724         <rdar://problem/19020874>
725
726         Reviewed by Andreas Kling.
727
728         Add a setting to disable DOM timers throttling, in order to help
729         developers determine if a specific issue is caused by timer
730         throttling.
731
732         * WebView/WebPreferenceKeysPrivate.h:
733         * WebView/WebPreferences.mm:
734         (+[WebPreferences initialize]):
735         (-[WebPreferences domTimersThrottlingEnabled]):
736         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
737         * WebView/WebPreferencesPrivate.h:
738         * WebView/WebView.mm:
739         (-[WebView _preferencesChanged:]):
740
741 2014-11-18  Tim Horton  <timothy_horton@apple.com>
742
743         Avoid re-encoding action menu image data
744         https://bugs.webkit.org/show_bug.cgi?id=138817
745         <rdar://problem/18840382>
746
747         Reviewed by Anders Carlsson.
748
749         * WebView/WebActionMenuController.mm:
750         (-[WebActionMenuController _defaultMenuItemsForImage:]):
751         (-[WebActionMenuController _addImageToPhotos:]):
752         Build a temporary filename from a UUID and the image's desired extension.
753         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
754         Build an image menu only if we have an image, URL, data, and extension.
755
756 2014-11-18  Daniel Bates  <dabates@apple.com>
757
758         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
759         SPI are not available in public SDK
760         https://bugs.webkit.org/show_bug.cgi?id=138802
761
762         Reviewed by David Kilzer.
763
764         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
765         libdispatch and MobileGestalt headers directly.
766
767         * WebView/WebView.mm:
768
769 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
770
771         Remove calls to deprecated NSMenu methods
772         https://bugs.webkit.org/show_bug.cgi?id=138808.
773
774         Reviewed by Anders Carlsson.
775
776         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
777
778         * WebCoreSupport/PopupMenuMac.mm:
779         (PopupMenuMac::populate):
780
781 2014-11-17  Daniel Bates  <dabates@apple.com>
782
783         Unreviewed, rolling out r176232.
784
785         Broke the Mac build. Will investigate offline.
786
787         Reverted changeset:
788
789         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
790         MobileGestalt"
791         https://bugs.webkit.org/show_bug.cgi?id=138802
792         http://trac.webkit.org/changeset/176232
793
794 2014-11-17  Daniel Bates  <dabates@apple.com>
795
796         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
797         SPI are not available in public SDK
798         https://bugs.webkit.org/show_bug.cgi?id=138802
799
800         Reviewed by David Kilzer.
801
802         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
803         libdispatch and MobileGestalt headers directly.
804
805         * WebView/WebView.mm:
806
807 2014-11-17  Beth Dakin  <bdakin@apple.com>
808
809         Whitespace action menus should focus the HitTestResult and create an insertion 
810         point
811         https://bugs.webkit.org/show_bug.cgi?id=138786
812         -and corresponding-
813         rdar://problem/18944893
814
815         Reviewed by Tim Horton.
816
817         Whitespace menus should cause the HitTestResult to be focused, and they should set 
818         the selection based on the HitTest location.
819
820         * WebView/WebActionMenuController.mm:
821         (-[WebActionMenuController isMenuForTextContent]):
822         (-[WebActionMenuController focusAndSelectHitTestResult]):
823         (-[WebActionMenuController willOpenMenu:withEvent:]):
824
825 2014-11-17  Daniel Bates  <dabates@apple.com>
826
827         [iOS] QuartzCore SPI not available in public SDK
828         https://bugs.webkit.org/show_bug.cgi?id=138751
829
830         Reviewed by David Kilzer.
831
832         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
833
834         * WebInspector/WebNodeHighlight.mm:
835         * WebView/WebIndicateLayer.mm:
836
837 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
838
839         [iOS] allow host application to opt-out of alternate fullscreen
840         https://bugs.webkit.org/show_bug.cgi?id=138787
841
842         Reviewed by Darin Adler.
843
844         * WebView/WebPreferenceKeysPrivate.h:
845         * WebView/WebPreferences.mm:
846         (+[WebPreferences initialize]):
847         (-[WebPreferences allowsAlternateFullscreen]):
848         (-[WebPreferences setAllowsAlternateFullscreen:]):
849         * WebView/WebPreferencesPrivate.h:
850         * WebView/WebView.mm:
851         (-[WebView _preferencesChanged:]):
852
853 2014-11-16  Tim Horton  <timothy_horton@apple.com>
854
855         Use TextIndicator instead of the built in Lookup highlight
856         https://bugs.webkit.org/show_bug.cgi?id=138775
857         <rdar://problem/18953982>
858
859         Reviewed by Anders Carlsson.
860
861         * WebCoreSupport/WebSystemInterface.mm:
862         (InitWebCoreSystemInterface):
863         Remove a WKSI import.
864
865         * WebView/WebActionMenuController.mm:
866         (-[WebActionMenuController _lookupText:]):
867         (-[WebActionMenuController _createActionMenuItemForTag:]):
868         Make use of the new Lookup SPI header.
869         Disable the Lookup item if lookup is not available.
870
871 2014-11-15  Tim Horton  <timothy_horton@apple.com>
872
873         Implement data detectors and mailto action menus for WebKit1
874         https://bugs.webkit.org/show_bug.cgi?id=138765
875         <rdar://problem/18877535>
876
877         Reviewed by Beth Dakin.
878
879         * WebView/WebActionMenuController.h:
880         * WebView/WebActionMenuController.mm:
881         (-[WebActionMenuController willOpenMenu:withEvent:]):
882         Tell DataDetectors that the menu is going to open.
883         Select the text (or not) based on the number of items in the menu, just like WebKit2.
884
885         (-[WebActionMenuController didCloseMenu:withEvent:]):
886         Tell DataDetectors that the menu closed.
887
888         (-[WebActionMenuController _defaultMenuItemsForLink]):
889         Move these checks out of _defaultMenuItemsForLink, because we expect this
890         to always return a complete link menu.
891
892         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
893         Implement. More or less copied from WebKit2.
894
895         (-[WebActionMenuController _selectDataDetectedText]):
896         Select the stashed range.
897
898         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
899         Implement. More or less copied from WebKit2.
900         The yellow highlight isn't hooked up yet.
901         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
902
903         (-[WebActionMenuController _selectLookupText]):
904         Remove an unnecessary return.
905
906         (-[WebActionMenuController _defaultMenuItems]):
907         Call into the two new menu types.
908
909         * WebView/WebUIDelegatePrivate.h:
910
911 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
912
913         Get rid of WebFontCache
914         https://bugs.webkit.org/show_bug.cgi?id=134752
915
916         Reviewed by Dave Hyatt.
917
918         * WebView/WebHTMLView.mm:
919
920 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
921
922         Update some artwork for the legacy WebKit action menu
923         https://bugs.webkit.org/show_bug.cgi?id=138758
924         <rdar://problem/18989840>
925
926         * WebView/WebActionMenuController.mm:
927         (webKitBundleImageNamed): Deleted.
928         Fix the build.
929
930 2014-11-14  Tim Horton  <timothy_horton@apple.com>
931
932         Update some artwork for the legacy WebKit action menu
933         https://bugs.webkit.org/show_bug.cgi?id=138758
934         <rdar://problem/18989840>
935
936         Reviewed by Simon Fraser.
937
938         * WebView/WebActionMenuController.mm:
939         (-[WebActionMenuController _createActionMenuItemForTag:]):
940
941 2014-11-14  Daniel Bates  <dabates@apple.com>
942
943         [iOS] NSFileManager and QuickLook SPI not available in public SDK
944         https://bugs.webkit.org/show_bug.cgi?id=138742
945
946         Reviewed by Pratik Solanki.
947
948         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
949
950         * WebCoreSupport/WebFrameLoaderClient.mm:
951
952 2014-11-14  Beth Dakin  <bdakin@apple.com>
953
954         WK1: Webpage preview can come up in wrong location
955         https://bugs.webkit.org/show_bug.cgi?id=138747
956         -and corresponding-
957         rdar://problem/18979004
958
959         Reviewed by Tim Horton.
960
961         Converting to window twice is bad.
962         * WebView/WebActionMenuController.mm:
963         (elementBoundingBoxInWindowCoordinatesFromNode):
964         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
965         (elementBoundingBoxFromNode): Deleted.
966
967 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
968
969         Move FontMac and FontCacheMac off of WKSI
970         https://bugs.webkit.org/show_bug.cgi?id=138633
971
972         Reviewed by Simon Fraser.
973
974         * WebCoreSupport/WebSystemInterface.mm:
975         (InitWebCoreSystemInterface):
976         * WebKit.order:
977
978 2014-11-13  Beth Dakin  <bdakin@apple.com>
979
980         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
981         https://bugs.webkit.org/show_bug.cgi?id=138716
982         -and corresponding-
983         rdar://problem/18977222
984
985         Reviewed by Tim Horton.
986
987         It’s not necessary to use the WebElementDictionary for so many things now that we 
988         are caching the HitTestResult. We should just use the HitTestResult.
989
990         * WebView/WebActionMenuController.mm:
991         (-[WebActionMenuController prepareForMenu:withEvent:]):
992         (-[WebActionMenuController _openURLFromActionMenu:]):
993         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
994         (elementBoundingBoxFromNode):
995         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
996         (-[WebActionMenuController _defaultMenuItemsForLink]):
997         (-[WebActionMenuController _defaultMenuItemsForImage]):
998         (-[WebActionMenuController _defaultMenuItemsForVideo]):
999         (-[WebActionMenuController _defaultMenuItemsForText]):
1000         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
1001         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
1002         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
1003         (-[WebActionMenuController _createActionMenuItemForTag:]):
1004         (-[WebActionMenuController _defaultMenuItems]):
1005         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
1006         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
1007         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
1008         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
1009         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
1010         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
1011         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
1012         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
1013         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
1014         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
1015
1016 2014-11-13  Daniel Bates  <dabates@apple.com>
1017
1018         [iOS] NSGeometry data types are not available in the public SDK
1019         https://bugs.webkit.org/show_bug.cgi?id=137536
1020
1021         Reviewed by David Kilzer.
1022
1023         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
1024         private header.
1025
1026         * DOM/WebDOMOperationsPrivate.h:
1027
1028 2014-11-13  Beth Dakin  <bdakin@apple.com>
1029
1030         WK1: Support default actions for video
1031         https://bugs.webkit.org/show_bug.cgi?id=138713
1032         -and corresponding-
1033         rdar://problem/18877520
1034
1035         Reviewed by Tim Horton.
1036
1037         Call setToNonShadowAncestor() for media HitTestResults.
1038         * WebView/WebActionMenuController.mm:
1039         (-[WebActionMenuController performHitTestAtPoint:]):
1040
1041         Default items and actions.
1042         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
1043         (-[WebActionMenuController _copyVideoURL:]):
1044         (-[WebActionMenuController _saveVideoToDownloads:]):
1045         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1046         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1047         * WebView/WebUIDelegatePrivate.h:
1048
1049 2014-11-13  Tim Horton  <timothy_horton@apple.com>
1050
1051         WK1: Update icon for Add to Reading List
1052         https://bugs.webkit.org/show_bug.cgi?id=138710
1053         <rdar://problem/18975774>
1054
1055         Reviewed by Beth Dakin.
1056
1057         * WebView/WebActionMenuController.mm:
1058         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1059         Use the right icon, matching WebKit2.
1060
1061 2014-11-12  Beth Dakin  <bdakin@apple.com>
1062
1063         WK1: Support default actions for images
1064         https://bugs.webkit.org/show_bug.cgi?id=138668
1065         -and corresponding-
1066         rdar://problem/18785434
1067
1068         Reviewed by Tim Horton.
1069
1070         * WebView/WebActionMenuController.h:
1071         * WebView/WebActionMenuController.mm:
1072         (-[WebActionMenuController didCloseMenu:withEvent:]):
1073         (-[WebActionMenuController _defaultMenuItemsForImage:]):
1074         (-[WebActionMenuController _copyImage:]):
1075         (temporaryPhotosDirectoryPath):
1076         (pathToPhotoOnDisk):
1077         (-[WebActionMenuController _canAddMediaToPhotos]):
1078         (-[WebActionMenuController _addImageToPhotos:]):
1079         (-[WebActionMenuController _saveImageToDownloads:]):
1080         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
1081         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
1082         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
1083         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1084         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1085         * WebView/WebUIDelegatePrivate.h:
1086
1087 2014-11-11  Beth Dakin  <bdakin@apple.com>
1088
1089         Action menu hit testing is not working properly with all WK1 apps
1090         https://bugs.webkit.org/show_bug.cgi?id=138643
1091         -and corresponding-
1092         rdar://problem/18949376
1093
1094         Reviewed by Tim Horton.
1095
1096         * WebView/WebActionMenuController.mm:
1097         (-[WebActionMenuController prepareForMenu:withEvent:]):
1098         (-[WebActionMenuController _lookupText:]):
1099
1100 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1101
1102         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
1103         https://bugs.webkit.org/show_bug.cgi?id=138623
1104
1105         Reviewed by Geoff Garen.
1106
1107         * WebCoreSupport/WebSystemInterface.mm:
1108         (InitWebCoreSystemInterface):
1109         * WebKit.order:
1110
1111 2014-11-11  Tim Horton  <timothy_horton@apple.com>
1112
1113         Localize strings for action menus
1114         https://bugs.webkit.org/show_bug.cgi?id=138591
1115         <rdar://problem/18815343>
1116
1117         Reviewed by Dan Bates.
1118
1119         * WebView/WebActionMenuController.mm:
1120         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1121         Make use of the new strings.
1122
1123 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1124
1125         Cleanup from r175379
1126         https://bugs.webkit.org/show_bug.cgi?id=138616
1127
1128         Reviewed by Simon Fraser.
1129
1130         * WebCoreSupport/WebSystemInterface.mm:
1131         (InitWebCoreSystemInterface):
1132         * WebKit.order:
1133
1134 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1135
1136         Move CTFontTransformGlyphs out from WKSI
1137         https://bugs.webkit.org/show_bug.cgi?id=138599
1138
1139         Reviewed by Simon Fraser.
1140
1141         * WebCoreSupport/WebSystemInterface.mm:
1142         (InitWebCoreSystemInterface):
1143         * WebKit.order:
1144
1145 2014-11-11  Dan Bernstein  <mitz@apple.com>
1146
1147         More iOS build fix.
1148
1149         * WebView/WebHTMLViewInternal.h:
1150
1151 2014-11-11  Dan Bernstein  <mitz@apple.com>
1152
1153         iOS build fix.
1154
1155         * WebView/WebHTMLView.mm:
1156
1157 2014-11-10  Beth Dakin  <bdakin@apple.com>
1158
1159         WK1: Support default actions for editable text with misspelled word
1160         https://bugs.webkit.org/show_bug.cgi?id=138590
1161         -and corresponding-
1162         rdar://problem/18877506
1163
1164         Reviewed by Tim Horton.
1165
1166         If there are misspelled word suggestions for editable text, create a new type of 
1167         menu with a spelling suggestion sub-menu.
1168
1169         * WebView/WebActionMenuController.mm:
1170         (-[WebActionMenuController isMenuForTextContent]):
1171         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
1172         (-[WebActionMenuController _changeSelectionToSuggestion:]):
1173         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1174         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1175         * WebView/WebHTMLView.mm:
1176         (-[WebHTMLView _changeSpellingToWord:]):
1177         * WebView/WebHTMLViewInternal.h:
1178         * WebView/WebUIDelegatePrivate.h:
1179
1180 2014-11-10  Beth Dakin  <bdakin@apple.com>
1181
1182         WK1: Support default actions for editable whitespace
1183         https://bugs.webkit.org/show_bug.cgi?id=138586
1184         -and corresponding-
1185         rdar://problem/18932048
1186
1187         Reviewed by Tim Horton.
1188
1189         New menu type. Just wants paste.
1190
1191         * WebView/WebActionMenuController.mm:
1192         (-[WebActionMenuController isMenuForTextContent]):
1193         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
1194         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1195         * WebView/WebUIDelegatePrivate.h:
1196
1197 2014-11-10  Beth Dakin  <bdakin@apple.com>
1198
1199         WK1: Support default actions for editable text
1200         https://bugs.webkit.org/show_bug.cgi?id=138580
1201         -and corresponding-
1202         rdar://problem/18877497
1203
1204         Reviewed by Tim Horton.
1205
1206         New menu type, and new action type for paste. 
1207
1208         * WebView/WebActionMenuController.mm:
1209         (-[WebActionMenuController isMenuForTextContent]):
1210         (-[WebActionMenuController willOpenMenu:withEvent:]):
1211         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
1212         (-[WebActionMenuController _paste:]):
1213         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1214         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1215         * WebView/WebUIDelegatePrivate.h:
1216
1217 2014-11-10  Beth Dakin  <bdakin@apple.com>
1218
1219         WK1: Text is getting selected even when an action menu fails to invoke
1220         https://bugs.webkit.org/show_bug.cgi?id=138576
1221         -and corresponding-
1222         rdar://problem/18931330
1223
1224         Reviewed by Tim Horton.
1225
1226         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
1227         * WebView/WebActionMenuController.h:
1228         * WebView/WebActionMenuController.mm:
1229         (-[WebActionMenuController prepareForMenu:withEvent:]):
1230         (-[WebActionMenuController willOpenMenu:withEvent:]):
1231
1232         _selectLookupText no longer needs to return a BOOL indicating success or failure.
1233         (-[WebActionMenuController _selectLookupText]):
1234         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1235
1236         Pass willOpenMenu: on to the controller.
1237         * WebView/WebView.mm:
1238         (-[WebView willOpenMenu:withEvent:]):
1239
1240 2014-11-10  Beth Dakin  <bdakin@apple.com>
1241
1242         Speculative build fix.
1243
1244         * WebView/WebActionMenuController.mm:
1245
1246 2014-11-10  Beth Dakin  <bdakin@apple.com>
1247
1248         Action menu initialization should be moved to _commonInitializationWithFrameName
1249         https://bugs.webkit.org/show_bug.cgi?id=138572
1250         -and corresponding-
1251         rdar://problem/18929733
1252
1253         Reviewed by Tim Horton.
1254
1255         * WebView/WebView.mm:
1256         (-[WebView _commonInitializationWithFrameName:groupName:]):
1257         (-[WebView _initWithFrame:frameName:groupName:]):
1258
1259 2014-11-10  Beth Dakin  <bdakin@apple.com>
1260
1261         WK1: Support default actions for read-only text
1262         https://bugs.webkit.org/show_bug.cgi?id=138552
1263         -and corresponding-
1264         rdar://problem/18877483
1265
1266         Reviewed by Tim Horton.
1267
1268         New WKSystemInterface functions that WebCore needs to use.
1269         * WebCoreSupport/WebSystemInterface.mm:
1270         (InitWebCoreSystemInterface):
1271
1272         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
1273         makes a lot of things easier.
1274         * WebView/WebActionMenuController.h:
1275         * WebView/WebActionMenuController.mm:
1276
1277         Perform the hit test ourselves instead of calling into WebView so that we can more 
1278         easily save the WebCore::HitTestResult for ourselves.
1279         (-[WebActionMenuController performHitTestAtPoint:]):
1280
1281         Clear selection for non-text menus.
1282         (-[WebActionMenuController prepareForMenu:withEvent:]):
1283
1284         Re-set the _type here just to be safe.
1285         (-[WebActionMenuController didCloseMenu:withEvent:]):
1286
1287         Moving this method to be next to the link actions so they can be within a pragma 
1288         mark.
1289         (-[WebActionMenuController _defaultMenuItemsForLink:]):
1290
1291         New method for default text actions — lookup and copy.
1292         (-[WebActionMenuController _defaultMenuItemsForText:]):
1293         (-[WebActionMenuController _copySelection:]):
1294         (-[WebActionMenuController _lookupText:]):
1295
1296         If there is not already a selection, invoking the action menu on text should 
1297         select the lookup text.
1298         (-[WebActionMenuController _selectLookupText]):
1299         (performDictionaryLookupForSelection):
1300         (performDictionaryLookupForRange):
1301
1302         Handle text now.
1303         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1304         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1305
1306         New enum values.
1307         * WebView/WebUIDelegatePrivate.h:
1308
1309         Pass didCloseMenu on to the controller.
1310         * WebView/WebView.mm:
1311         (-[WebView didCloseMenu:withEvent:]):
1312
1313 2014-11-09  Chris Dumez  <cdumez@apple.com>
1314
1315         Add a more correct way to compare floating point numbers and use it
1316         https://bugs.webkit.org/show_bug.cgi?id=138527
1317
1318         Reviewed by Darin Adler.
1319
1320         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
1321         to compare floating-point numbers.
1322
1323         * WebView/WebHTMLView.mm:
1324         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
1325
1326 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
1327
1328         Delete cookies between tests
1329         https://bugs.webkit.org/show_bug.cgi?id=138528
1330
1331         Reviewed by Sam Weinig.
1332
1333         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
1334         * WebView/WebPreferencesPrivate.h:
1335         Added an SPI for DumpRenderTree.
1336
1337 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
1338
1339         [iOS] Update optimized fullscreen media controls
1340         https://bugs.webkit.org/show_bug.cgi?id=138493
1341
1342         Reviewed by Brent Fulgham.
1343
1344         * WebCoreSupport/WebSystemInterface.mm:
1345         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
1346
1347 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
1348
1349         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
1350         https://bugs.webkit.org/show_bug.cgi?id=138443
1351
1352         Reviewed by Anders Carlsson.
1353
1354         Wrapping the dealloc method in its own autorelease pool avoids the problem of
1355         complex tear-downs leading to the WebView itself being added to an autorelease
1356         pool that is not drained until after the instance has been dealloc'd.
1357  
1358         * WebView/WebView.mm:
1359         (-[WebView dealloc]):
1360
1361 2014-11-05  Jer Noble  <jer.noble@apple.com>
1362
1363         De-templatize Timer
1364         https://bugs.webkit.org/show_bug.cgi?id=138450
1365
1366         Reviewed by Anders Carlsson.
1367
1368         Remove template specifiers from Timer.
1369
1370         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1371         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1372         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
1373         * Plugins/WebNetscapePluginStream.h:
1374         * Plugins/WebNetscapePluginStream.mm:
1375         (WebNetscapePluginStream::deliverDataTimerFired):
1376
1377 2014-11-05  Dan Bernstein  <mitz@apple.com>
1378
1379         Remove the unused deletion UI feature
1380         https://bugs.webkit.org/show_bug.cgi?id=138442
1381
1382         Rubber-stamped by Alexey Proskuryakov.
1383
1384         * DefaultDelegates/WebDefaultEditingDelegate.m:
1385         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
1386         * WebCoreSupport/WebEditorClient.h:
1387         * WebCoreSupport/WebEditorClient.mm:
1388         (WebEditorClient::shouldShowDeleteInterface): Deleted.
1389         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
1390         -webView:shouldShowDeleteInterfaceForElement:.
1391
1392 2014-11-03  Dean Jackson  <dino@apple.com>
1393
1394         Add ENABLE_FILTERS_LEVEL_2 feature guard.
1395         https://bugs.webkit.org/show_bug.cgi?id=138362
1396
1397         Reviewed by Tim Horton.
1398
1399         Add a new feature define for Level 2 of CSS Filters.
1400         http://dev.w3.org/fxtf/filters-2/
1401
1402         * Configurations/FeatureDefines.xcconfig:
1403
1404 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
1405
1406         Add button and enable optimized fullscreen.
1407         https://bugs.webkit.org/show_bug.cgi?id=138351
1408
1409         Reviewed by Eric Carlson.
1410
1411         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
1412
1413         * WebCoreSupport/WebSystemInterface.mm:
1414         (InitWebCoreSystemInterface): added
1415
1416 2014-11-04  Chris Dumez  <cdumez@apple.com>
1417
1418         Add ptr() method to Ref class
1419         https://bugs.webkit.org/show_bug.cgi?id=138361
1420
1421         Reviewed by Darin Adler.
1422
1423         Use the new Ref::ptr() method.
1424
1425         * WebView/WebFrame.mm:
1426         (-[WebFrame _setTypingStyle:withUndoAction:]):
1427         * WebView/WebHTMLView.mm:
1428         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
1429         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
1430         * WebView/WebView.mm:
1431         (-[WebView applyStyle:]):
1432
1433 2014-11-04  Darin Adler  <darin@apple.com>
1434
1435         Eliminate ResourceBuffer and use SharedBuffer directly instead
1436         https://bugs.webkit.org/show_bug.cgi?id=138174
1437
1438         Reviewed by Antti Koivisto.
1439
1440         * WebView/WebDataSource.mm:
1441         (-[WebDataSource data]): Use SharedBuffer directly.
1442         * WebView/WebHTMLView.mm:
1443         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1444
1445 2014-11-03  Commit Queue  <commit-queue@webkit.org>
1446
1447         Unreviewed, rolling out r175406, r175413, and r175423.
1448         https://bugs.webkit.org/show_bug.cgi?id=138327
1449
1450         Multipart tests are still broken (Requested by ap on #webkit).
1451
1452         Reverted changesets:
1453
1454         "Eliminate ResourceBuffer and use SharedBuffer directly
1455         instead"
1456         https://bugs.webkit.org/show_bug.cgi?id=138174
1457         http://trac.webkit.org/changeset/175406
1458
1459         "Unreviewed, iOS build fix since 175406."
1460         http://trac.webkit.org/changeset/175413
1461
1462         "Fix assertion in CachedResource::addDataBuffer"
1463         http://trac.webkit.org/changeset/175423
1464
1465 2014-10-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1466
1467         Use std::unique_ptr for TypeCountSet
1468         https://bugs.webkit.org/show_bug.cgi?id=138242
1469
1470         Reviewed by Andreas Kling.
1471
1472         * Misc/WebCoreStatistics.mm:
1473         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr.
1474         (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto.
1475
1476 2014-10-31  Beth Dakin  <bdakin@apple.com>
1477
1478         Use system art for action menus when possible
1479         https://bugs.webkit.org/show_bug.cgi?id=138260
1480
1481         Reviewed by Tim Horton.
1482
1483         * WebView/WebActionMenuController.mm:
1484         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1485
1486 2014-10-30  Darin Adler  <darin@apple.com>
1487
1488         Eliminate ResourceBuffer and use SharedBuffer directly instead
1489         https://bugs.webkit.org/show_bug.cgi?id=138174
1490
1491         Reviewed by Antti Koivisto.
1492
1493         * WebView/WebDataSource.mm:
1494         (-[WebDataSource data]): Use SharedBuffer directly.
1495         * WebView/WebHTMLView.mm:
1496         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1497
1498 2014-10-30  Jer Noble  <jer.noble@apple.com>
1499
1500         [EME] Add Setting for accessing storage location for MediaKeys data
1501         https://bugs.webkit.org/show_bug.cgi?id=138147
1502
1503         Reviewed by Brady Eidson.
1504
1505         * WebView/WebPreferenceKeysPrivate.h:
1506         * WebView/WebPreferences.mm:
1507         (+[WebPreferences initialize]): Set default location.
1508         (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor.
1509         (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter.
1510         * WebView/WebPreferencesPrivate.h:
1511         * WebView/WebView.mm:
1512         (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings.
1513
1514 2014-10-30  Dana Burkart  <dburkart@apple.com>
1515
1516         <rdar://problem/18821260> Prepare for the mysterious future
1517
1518         Reviewed by Lucas Forschler.
1519
1520         * Configurations/Base.xcconfig:
1521         * Configurations/DebugRelease.xcconfig:
1522         * Configurations/FeatureDefines.xcconfig:
1523         * Configurations/Version.xcconfig:
1524
1525 2014-10-28  Jeremy Jones  <jeremyj@apple.com>
1526
1527         Add optimized fullscreen mode.
1528         https://bugs.webkit.org/show_bug.cgi?id=138044
1529
1530         Reviewed by Jer Noble.
1531
1532         Enable different types of fullscreen video behavior.
1533         Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
1534
1535         * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
1536         * WebCoreSupport/WebChromeClient.mm:
1537         (WebChromeClient::enterVideoFullscreenForVideoElement): ditto
1538         * WebView/WebView.mm:
1539         (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
1540         (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.
1541         * WebView/WebViewInternal.h: ditto
1542
1543 2014-10-27  Beth Dakin  <bdakin@apple.com>
1544
1545         Provide a way for WebKit1 clients to override default action menu items
1546         https://bugs.webkit.org/show_bug.cgi?id=138066
1547         -and corresponding-
1548         rdar://problem/18451638
1549
1550         Reviewed by Anders Carlsson.
1551
1552         WebActionMenuController now has an ivar for the WebActionMenuType so that it can 
1553         send that along to clients customizing the menu.
1554         * WebView/WebActionMenuController.h:
1555         * WebView/WebActionMenuController.mm:
1556         (-[WebActionMenuController prepareForMenu:withEvent:]):
1557         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1558
1559         New enum and new SPI to customize menus.
1560         * WebView/WebUIDelegatePrivate.h:
1561
1562 2014-10-24  Benjamin Poulain  <bpoulain@apple.com>
1563
1564         Fix the iOS build
1565
1566         * Configurations/WebKitLegacy.xcconfig:
1567         * WebView/WebView.mm:
1568
1569 2014-10-24  Beth Dakin  <bdakin@apple.com>
1570
1571         Build fix.
1572
1573         * WebView/WebActionMenuController.mm:
1574         (-[WebActionMenuController _openURLFromActionMenu:]):
1575         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
1576         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1577
1578 2014-10-24  Beth Dakin  <bdakin@apple.com>
1579
1580         WebKit1 should support action menus
1581         https://bugs.webkit.org/show_bug.cgi?id=138032
1582
1583         Reviewed by Tim Horton.
1584
1585         This patch adds basic support for action menus and adds actions for links.
1586
1587         Helper class takes care of all of the action menu work. WebView will forward the 
1588         prepareForMenu: message, and then the helper class takes it from there.
1589         * WebView/WebActionMenuController.h: Added.
1590         * WebView/WebActionMenuController.mm: Added.
1591         (-[WebActionMenuController webViewClosed]):
1592         (-[WebActionMenuController prepareForMenu:withEvent:]):
1593
1594         Selectors for link actions.
1595         (-[WebActionMenuController _openURLFromActionMenu:]):
1596         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
1597         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
1598         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1599         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1600         (webKitBundleImageNamed):
1601         (-[WebActionMenuController _defaultMenuItemsForLink:]):
1602         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1603
1604         Tags for the action menu items.
1605         * WebView/WebUIDelegatePrivate.h:
1606         * WebView/WebView.mm:
1607
1608         Set the action menu if possible and create the controller.
1609         (-[WebView _initWithFrame:frameName:groupName:]):
1610         (-[WebView _close]):
1611         (-[WebView prepareForMenu:withEvent:]):
1612
1613         WebViewData stores the WebActionMenuHelper
1614         * WebView/WebViewData.h:
1615         * WebView/WebViewData.mm:
1616         (-[WebViewPrivate dealloc]):
1617
1618 2014-10-23  Joseph Pecoraro  <pecoraro@apple.com>
1619
1620         Web Inspector: Provide a way to have alternate inspector agents
1621         https://bugs.webkit.org/show_bug.cgi?id=137901
1622
1623         Reviewed by Brian Burg.
1624
1625         * Configurations/FeatureDefines.xcconfig:
1626
1627 2014-10-23  Tim Horton  <timothy_horton@apple.com>
1628
1629         Add some SPI headers for NSExtension and NSSharingService{Picker}
1630         https://bugs.webkit.org/show_bug.cgi?id=138027
1631
1632         Reviewed by Anders Carlsson.
1633
1634         * Misc/WebSharingServicePickerController.h:
1635         * Misc/WebSharingServicePickerController.mm:
1636         * WebCoreSupport/WebSelectionServiceController.mm:
1637         * WebCoreSupport/WebContextMenuClient.mm:
1638         Fix a sorting issue.
1639         Replace redefinitions with SPI header #imports.
1640
1641 2014-10-23  Tim Horton  <timothy_horton@apple.com>
1642
1643         Crashes under WebSelectionServiceController::hasRelevantSelectionServices
1644         https://bugs.webkit.org/show_bug.cgi?id=138013
1645
1646         Reviewed by Dan Bernstein.
1647
1648         * WebCoreSupport/WebSelectionServiceController.mm:
1649         (WebSelectionServiceController::hasRelevantSelectionServices):
1650         Don't adopt this autoreleased object.
1651
1652 2014-10-22  Chris Dumez  <cdumez@apple.com>
1653
1654         [Mac][WK2] Fix applicationIsSafari() detection
1655         https://bugs.webkit.org/show_bug.cgi?id=137893
1656
1657         Reviewed by Alexey Proskuryakov.
1658
1659         Provide an implementation for FrameLoaderClient's new
1660         needsQuickLookResourceCachingQuirks() that returns
1661         a static flag initialized using
1662         QuickLookMac::computeNeedsQuickLookResourceCachingQuirks().
1663
1664         * WebCoreSupport/WebFrameLoaderClient.h:
1665         * WebCoreSupport/WebFrameLoaderClient.mm:
1666
1667 2014-10-20  Chris Dumez  <cdumez@apple.com>
1668
1669         ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition
1670         https://bugs.webkit.org/show_bug.cgi?id=137797
1671
1672         Reviewed by Darin Adler.
1673
1674         Call ResourceRequest::setDomainForPartitionName() instead of
1675         setPartitionName() as the argument is a domain, not a valid
1676         partition name.
1677
1678         * Misc/WebCache.mm:
1679         (+[WebCache addImageToCache:forURL:forFrame:]):
1680         (+[WebCache removeImageFromCacheForURL:forFrame:]):
1681
1682 2014-10-20  Andy Estes  <aestes@apple.com>
1683
1684         Fix the iOS build.
1685
1686         * WebView/WebFrame.mm:
1687         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1688         (-[WebFrame dictationResultMetadataForRange:]):
1689
1690 2014-10-19  Chris Dumez  <cdumez@apple.com>
1691
1692         Use is<>() / downcast<>() for all remaining RenderObject subclasses
1693         https://bugs.webkit.org/show_bug.cgi?id=137845
1694
1695         Reviewed by Darin Adler.
1696
1697         Use is<>() / downcast<>() for all remaining RenderObject subclasses and 
1698         clean up the surrounding code.
1699
1700         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1701         (-[WebHostedNetscapePluginView pluginHostDied]):
1702         * Plugins/WebBaseNetscapePluginView.mm:
1703         (-[WebBaseNetscapePluginView _windowClipRect]):
1704         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
1705         * WebCoreSupport/WebFrameLoaderClient.mm:
1706         (WebFrameLoaderClient::createPlugin):
1707         (WebFrameLoaderClient::createJavaAppletWidget):
1708
1709 2014-10-17  Tim Horton  <timothy_horton@apple.com>
1710
1711         Build fix for 32-bit Yosemite
1712
1713         * WebCoreSupport/WebContextMenuClient.mm:
1714         (WebContextMenuClient::contextMenuForEvent):
1715         Avoid using NSItemProvider in 32-bit, because it doesn't exist.
1716
1717 2014-10-17  Chris Dumez  <cdumez@apple.com>
1718
1719         Use is<>() / downcast<>() for RenderBox
1720         https://bugs.webkit.org/show_bug.cgi?id=137804
1721
1722         Reviewed by Andreas Kling.
1723
1724         Use is<>() / downcast<>() for RenderBox and clean up the surrounding
1725         code.
1726
1727         * WebCoreSupport/WebContextMenuClient.mm:
1728         (WebContextMenuClient::clientFloatRectForNode):
1729         * WebView/WebFrame.mm:
1730         (-[WebFrame renderedSizeOfNode:constrainedToWidth:]):
1731
1732 2014-10-17  Tim Horton  <timothy_horton@apple.com>
1733
1734         Fix the build with the public SDK.
1735
1736         * WebCoreSupport/WebSelectionServiceController.mm:
1737         We should transition all this SPI to real SPI headers as soon as possible.
1738
1739 2014-10-16  Tim Horton  <timothy_horton@apple.com>
1740
1741         Implement selection services menu for Legacy WebKit
1742         https://bugs.webkit.org/show_bug.cgi?id=137582
1743         <rdar://problem/18604241>
1744
1745         Reviewed by Brady Eidson.
1746
1747         * Misc/WebSharingServicePickerController.h:
1748         Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
1749         Add WebSharingServicePickerClient, which other classes can implement
1750         instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
1751         Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.
1752
1753         * Misc/WebSharingServicePickerController.mm:
1754         Pass in NSSharingServicePickerStyle, so that clients can specify the style.
1755
1756         (-[WebSharingServicePickerController clear]):
1757         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
1758         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
1759         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
1760         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
1761         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
1762         Make use of WebSharingServicePickerClient.
1763
1764         (-[WebSharingServicePickerController sharingService:didShareItems:]):
1765         If we're returned a NSAttributedString, paste it on top of the current selection,
1766         similar to what the WebKit2 implementation currently does.
1767         
1768         * WebCoreSupport/WebChromeClient.h:
1769         * WebCoreSupport/WebChromeClient.mm:
1770         (WebChromeClient::handleTelephoneNumberClick):
1771         (WebChromeClient::handleSelectionServiceClick):
1772         (WebChromeClient::hasRelevantSelectionServices):
1773         Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.
1774
1775         * WebCoreSupport/WebContextMenuClient.h:
1776         * WebCoreSupport/WebContextMenuClient.mm:
1777         (WebContextMenuClient::sharingServicePickerWillBeDestroyed):
1778         (WebContextMenuClient::pageForSharingServicePicker):
1779         (WebContextMenuClient::windowForSharingServicePicker):
1780         (WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
1781         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1782         (WebContextMenuClient::contextMenuForEvent):
1783         (WebContextMenuClient::screenRectForHitTestNode): Deleted.
1784         (WebContextMenuClient::renderedImageForControlledImage): Deleted.
1785         (WebContextMenuClient::clearSharingServicePickerController): Deleted.
1786         Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
1787         having WebSharingServicePickerController tightly bound to it.
1788         Make an NSItemProvider array when instantiating WebSharingServicePickerController
1789         instead of handing it data directly.
1790
1791         * WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
1792         * WebCoreSupport/WebSelectionServiceController.mm: Added.
1793         (WebSelectionServiceController::WebSelectionServiceController):
1794         Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
1795         for selection services.
1796
1797         (WebSelectionServiceController::handleSelectionServiceClick):
1798         Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.
1799
1800         (hasCompatibleServicesForItems):
1801         (WebSelectionServiceController::hasRelevantSelectionServices):
1802         Determine whether or not services are available.
1803
1804         (WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
1805         (WebSelectionServiceController::pageForSharingServicePicker):
1806         (WebSelectionServiceController::windowForSharingServicePicker):
1807         Implement the rest of the WebSharingServicePickerClient overrides.
1808
1809         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
1810         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
1811         These are only useful for image sharing services, so we don't need to
1812         implement them (WebContextMenuClient does, on the other hand).
1813
1814         * WebView/WebView.mm:
1815         (-[WebView _selectionServiceController]):
1816         * WebView/WebViewData.h:
1817         * WebView/WebViewData.mm:
1818         * WebView/WebViewInternal.h:
1819         Keep a WebSelectionServiceController.
1820
1821 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
1822
1823         Improve debug description of WAKViews
1824         https://bugs.webkit.org/show_bug.cgi?id=137716
1825
1826         Reviewed by Simon Fraser.
1827
1828         * WebView/WebView.mm:
1829         (-[WebView _touchEventRegions]): Adding a comment.
1830
1831 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
1832
1833         Addressing post-review comment.
1834         https://bugs.webkit.org/show_bug.cgi?id=137550
1835
1836         Unreviewed.
1837
1838         * WebView/WebHTMLView.mm:
1839         (fontNameForDescription):
1840         (-[WebHTMLView _addToStyle:fontA:fontB:]):
1841
1842 2014-10-14  Chris Dumez  <cdumez@apple.com>
1843
1844         Use is<>() / downcast<>() for RenderImage
1845         https://bugs.webkit.org/show_bug.cgi?id=137683
1846
1847         Reviewed by Mihnea Ovidenie.
1848
1849         Use is<>() / downcast<>() for RenderImage.
1850
1851         * Misc/WebNSPasteboardExtras.mm:
1852         (imageFromElement):
1853         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1854
1855 2014-10-10  Daniel Bates  <dabates@apple.com>
1856
1857         Remove unused classes WebRender{Node, Layer}
1858         https://bugs.webkit.org/show_bug.cgi?id=137628
1859
1860         Reviewed by Simon Fraser.
1861
1862         We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
1863         For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.
1864
1865         * Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list
1866         of excluded source files when building for iOS.
1867         * WebKit.exp: Remove symbol for WebRenderLayer.
1868         * WebKit.mac.exp: Remove symbol for WebRenderNode.
1869         * WebView/WebRenderLayer.h: Removed.
1870         * WebView/WebRenderLayer.mm: Removed.
1871         * WebView/WebRenderNode.h: Removed.
1872         * WebView/WebRenderNode.mm: Removed.
1873
1874 2014-10-10  Chris Dumez  <cdumez@apple.com>
1875
1876         Use is<>() / downcast<>() for RenderBoxModelObject
1877         https://bugs.webkit.org/show_bug.cgi?id=137587
1878
1879         Reviewed by Mihnea Ovidenie.
1880
1881         Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
1882         surrounding code.
1883
1884         * Plugins/WebBaseNetscapePluginView.mm:
1885         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
1886         * WebView/WebRenderLayer.mm:
1887         (-[WebRenderLayer initWithWebFrame:]):
1888
1889 2014-10-09  Dean Jackson  <dino@apple.com>
1890
1891         Remove ENABLE_CSS3_CONDITIONAL_RULES
1892         https://bugs.webkit.org/show_bug.cgi?id=137571
1893
1894         Reviewed by Simon Fraser.
1895
1896         * Configurations/FeatureDefines.xcconfig:
1897
1898 2014-10-09  Tim Horton  <timothy_horton@apple.com>
1899
1900         Add a WebKit1 preference for selection services
1901         https://bugs.webkit.org/show_bug.cgi?id=137498
1902         <rdar://problem/18572699>
1903
1904         Reviewed by Simon Fraser.
1905
1906         * WebView/WebPreferenceKeysPrivate.h:
1907         * WebView/WebPreferences.mm:
1908         (+[WebPreferences initialize]):
1909         (-[WebPreferences serviceControlsEnabled]):
1910         (-[WebPreferences setServiceControlsEnabled:]):
1911         * WebView/WebPreferencesPrivate.h:
1912         * WebView/WebView.mm:
1913         (-[WebView _preferencesChanged:]):
1914         Add and plumb the preference.
1915
1916 2014-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
1917
1918         Remove second-to-last client of WebFontCache
1919         https://bugs.webkit.org/show_bug.cgi?id=137550
1920
1921         Reviewed by Darin Adler.
1922
1923         Use FontCache::getCachedFontData() instead of WebFontCache.
1924
1925         * WebView/WebHTMLView.mm:
1926         (-[WebHTMLView _addToStyle:fontA:fontB:]):
1927
1928 2014-10-09  Chris Dumez  <cdumez@apple.com>
1929
1930         Use is<>() / downcast<>() for Widget subclasses
1931         https://bugs.webkit.org/show_bug.cgi?id=137549
1932
1933         Reviewed by Darin Adler.
1934
1935         Use is<>() / downcast<>() for Widget subclasses and clean up the
1936         surrounding code.
1937
1938         * WebView/WebRenderNode.mm:
1939         (copyRenderNode):
1940         * WebView/WebView.mm:
1941         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
1942
1943 2014-10-07  Christophe Dumez  <cdumez@apple.com>
1944
1945         Use is<>() / downcast<>() for RenderText / RenderTextFragment
1946         https://bugs.webkit.org/show_bug.cgi?id=137476
1947
1948         Reviewed by Darin Adler.
1949
1950         * WebView/WebRenderNode.mm:
1951         (copyRenderNode):
1952
1953 2014-10-06  Dan Bernstein  <mitz@apple.com>
1954
1955         Build fix.
1956
1957         * Misc/WebCache.mm:
1958         (+[WebCache imageForURL:]):
1959
1960 2014-10-06  Chris Dumez  <cdumez@apple.com>
1961
1962         Unreviewed build fix after r174333.
1963
1964         Forgot explicit WebCore:: namespace.
1965
1966         * Misc/WebCache.mm:
1967         (+[WebCache imageForURL:]):
1968
1969 2014-10-05  Christophe Dumez  <cdumez@apple.com>
1970
1971         Use is<>() / downcast<>() for CachedResource subclasses
1972         https://bugs.webkit.org/show_bug.cgi?id=137431
1973
1974         Reviewed by Benjamin Poulain.
1975
1976         Use is<>() / downcast<>() for CachedResource subclasses.
1977
1978         * Misc/WebCache.mm:
1979         (+[WebCache imageForURL:]):
1980
1981 2014-10-02  Daniel Bates  <dabates@apple.com>
1982
1983         Use version number 101000 instead of 10100 for OS X Yosemite
1984         https://bugs.webkit.org/show_bug.cgi?id=137372
1985
1986         Reviewed by Mark Rowe.
1987
1988         The version number for OS X Yosemite is 101000.
1989
1990         * WebView/WebView.mm:
1991         (-[WebView _preferencesChanged:]):
1992
1993 2014-10-02  Tim Horton  <timothy_horton@apple.com>
1994
1995         Move PageOverlay[Controller] to WebCore
1996         https://bugs.webkit.org/show_bug.cgi?id=137164
1997         <rdar://problem/18508258>
1998
1999         Reviewed by Anders Carlsson.
2000
2001         * WebCoreSupport/WebChromeClient.h:
2002         * WebCoreSupport/WebChromeClient.mm:
2003         (WebChromeClient::attachViewOverlayGraphicsLayer):
2004         Add an empty ChromeClient override.
2005
2006 2014-10-01  Christophe Dumez  <cdumez@apple.com>
2007
2008         Have is<>(T*) function do a null check on the pointer argument
2009         https://bugs.webkit.org/show_bug.cgi?id=137333
2010
2011         Reviewed by Gavin Barraclough.
2012
2013         Have is<>(T*) function do a null check on the argument instead of a
2014         simple assertion. This makes sense for 2 reasons:
2015         1. It is more consistent with downcast<>(T*), which will succeed even
2016            if the argument is a nullptr.
2017         2. It simplifies the code a bit as it gets rid of a lot of explicit
2018            null checks.
2019
2020         * WebCoreSupport/WebChromeClient.mm:
2021         (WebChromeClient::focusedElementChanged):
2022         * WebCoreSupport/WebEditorClient.mm:
2023         (WebEditorClient::textFieldDidBeginEditing):
2024         (WebEditorClient::textFieldDidEndEditing):
2025         (WebEditorClient::textDidChangeInTextField):
2026         (WebEditorClient::doTextFieldCommandFromEvent):
2027         (WebEditorClient::textWillBeDeletedInTextField):
2028         (WebEditorClient::textDidChangeInTextArea):
2029         * WebView/WebHTMLRepresentation.mm:
2030         (inputElementFromDOMElement):
2031         (searchForLabelsBeforeElement):
2032         * WebView/WebRenderLayer.mm:
2033         (+[WebRenderLayer nameForLayer:]):
2034
2035 2014-10-01  Mark Rowe  <mrowe@apple.com>
2036
2037         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
2038
2039         Reviewed by Dan Bernstein.
2040
2041         * Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite.
2042
2043 2014-09-30  Chris Dumez  <cdumez@apple.com>
2044
2045         Use is<>() / downcast<>() for Element
2046         https://bugs.webkit.org/show_bug.cgi?id=137241
2047
2048         Reviewed by Andreas Kling.
2049
2050         Use is<>() / downcast<>() for Element instead of isElementNode() /
2051         toElement().
2052
2053         * WebView/WebRenderLayer.mm:
2054         (+[WebRenderLayer nameForLayer:]):
2055
2056 2014-09-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2057
2058         Move ColorInputType class to std::unique_ptr
2059         https://bugs.webkit.org/show_bug.cgi?id=137173
2060
2061         Reviewed by Darin Adler.
2062
2063         Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr.
2064         Child classes follow this change as well.
2065
2066         * WebCoreSupport/WebChromeClient.h:
2067         * WebCoreSupport/WebChromeClient.mm:
2068         (WebChromeClient::createColorChooser):
2069
2070 2014-09-24  Christophe Dumez  <cdumez@apple.com>
2071
2072         Add initial is<>() / downcast<>() support for any type of Nodes
2073         https://bugs.webkit.org/show_bug.cgi?id=137056
2074
2075         Reviewed by Benjamin Poulain.
2076
2077         Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
2078         instead of isFormControlElement() / toHTMLFormControlElement().
2079
2080         * WebView/WebHTMLRepresentation.mm:
2081         (searchForLabelsBeforeElement):
2082
2083 2014-09-24  Christophe Dumez  <cdumez@apple.com>
2084
2085         Use is<HTML*Element>() instead of isHTML*Element() - Part 1
2086         https://bugs.webkit.org/show_bug.cgi?id=137068
2087
2088         Reviewed by Ryosuke Niwa.
2089
2090         Start using is<HTML*Element>() instead of isHTML*Element().
2091         Remaining usages will be updated in a follow-up patch to
2092         reduce the size of the change.
2093
2094         * WebCoreSupport/WebChromeClient.mm:
2095         (WebChromeClient::focusedElementChanged):
2096         * WebCoreSupport/WebEditorClient.mm:
2097         (WebEditorClient::textFieldDidBeginEditing):
2098         (WebEditorClient::textFieldDidEndEditing):
2099         (WebEditorClient::textDidChangeInTextField):
2100         (WebEditorClient::doTextFieldCommandFromEvent):
2101         (WebEditorClient::textWillBeDeletedInTextField):
2102         (WebEditorClient::textDidChangeInTextArea):
2103         * WebView/WebHTMLRepresentation.mm:
2104         (inputElementFromDOMElement):
2105
2106 2014-09-21  Timothy Hatcher  <timothy@apple.com>
2107
2108         Make the Web Inspector use a separate web process.
2109
2110         https://bugs.webkit.org/show_bug.cgi?id=135120
2111
2112         Reviewed by Anders Carlsson.
2113
2114         * WebCoreSupport/WebInspectorClient.h:
2115         * WebCoreSupport/WebInspectorClient.mm:
2116         (WebInspectorClient::WebInspectorClient):
2117         (WebInspectorClient::openInspectorFrontend):
2118         (WebInspectorClient::releaseFrontend):
2119         Own WebInspectorFrontendClient instead of moving it.
2120
2121 2014-09-23  Chris Dumez  <cdumez@apple.com>
2122
2123         Use downcast<HTML*Element>() instead of toHTML*Element()
2124         https://bugs.webkit.org/show_bug.cgi?id=137007
2125
2126         Reviewed by Benjamin Poulain.
2127
2128         Use downcast<HTML*Element>() instead of toHTML*Element().
2129
2130         * DOM/WebDOMOperations.mm:
2131         (-[DOMHTMLInputElement _setAutofilled:]):
2132         * WebCoreSupport/WebChromeClient.mm:
2133         (WebChromeClient::focusedElementChanged):
2134         * WebCoreSupport/WebEditorClient.mm:
2135         (WebEditorClient::textFieldDidBeginEditing):
2136         (WebEditorClient::textFieldDidEndEditing):
2137         (WebEditorClient::textDidChangeInTextField):
2138         (WebEditorClient::doTextFieldCommandFromEvent):
2139         (WebEditorClient::textWillBeDeletedInTextField):
2140         (WebEditorClient::textDidChangeInTextArea):
2141         * WebView/WebHTMLRepresentation.mm:
2142         (inputElementFromDOMElement):
2143
2144 2014-09-21  Chris Dumez  <cdumez@apple.com>
2145
2146         Generate Element casting helper functions
2147         https://bugs.webkit.org/show_bug.cgi?id=136839
2148
2149         Reviewed by Darin Adler.
2150
2151         Use JSXXX::toWrapped() instead of toXXX() function.
2152
2153         * DOM/WebDOMOperations.mm:
2154         * WebView/WebView.mm:
2155         (-[WebView _notificationIDForTesting:]):
2156
2157 2014-09-21  Joseph Pecoraro  <pecoraro@apple.com>
2158
2159         Leak: WebNotificationPrivate ObjC leaks seen on leaks bot
2160         https://bugs.webkit.org/show_bug.cgi?id=136972
2161
2162         Reviewed by Darin Adler.
2163
2164         * WebView/WebNotification.h:
2165         * WebView/WebNotification.mm:
2166         (-[WebNotification initWithCoreNotification:notificationID:]):
2167         Switch to RetainPtr and adopt into _private to ensure when we are
2168         deallocated that _private will get deallocated.
2169
2170 2014-09-19  Dean Jackson  <dino@apple.com>
2171
2172         Multithreaded WebGL is a bad idea - remove it
2173         https://bugs.webkit.org/show_bug.cgi?id=136964
2174         <rdar://problem/18399858>
2175
2176         Reviewed by Brent Fulgham.
2177
2178         Remove the setting to allow multithreaded WebGL.
2179
2180         * WebView/WebPreferenceKeysPrivate.h:
2181         * WebView/WebPreferences.mm:
2182         (+[WebPreferences initialize]):
2183         (-[WebPreferences multithreadedWebGLEnabled]): Deleted.
2184         (-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted.
2185         * WebView/WebPreferencesPrivate.h:
2186         * WebView/WebView.mm:
2187         (-[WebView _preferencesChanged:]):
2188
2189 2014-09-19  Daniel Bates  <dabates@apple.com>
2190
2191         Always assume internal SDK when building configuration Production
2192         https://bugs.webkit.org/show_bug.cgi?id=136925
2193         <rdar://problem/18362399>
2194
2195         Reviewed by Dan Bernstein.
2196
2197         As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
2198         and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.
2199
2200         * Configurations/Base.xcconfig:
2201
2202 2014-09-17  Daniel Bates  <dabates@apple.com>
2203
2204         Unreviewed, rolling out r173695.
2205
2206         Broke building third-party Legacy WebKit apps; will
2207         investigate offline
2208
2209         Reverted changeset:
2210
2211         "[iOS] Make WebCore build with public iOS SDK"
2212         https://bugs.webkit.org/show_bug.cgi?id=136487
2213         http://trac.webkit.org/changeset/173695
2214
2215 2014-09-17  Daniel Bates  <dabates@apple.com>
2216
2217         [iOS] Make WebCore build with public iOS SDK
2218         https://bugs.webkit.org/show_bug.cgi?id=136487
2219
2220         Reviewed by David Kilzer.
2221
2222         Update WebKit1 source files to include the wrapper SPI headers instead of the corresponding
2223         actual SPI header(s).
2224
2225         * DOM/WebDOMOperationsPrivate.h:
2226         * MigrateHeaders.make: Modified to only modify the include path of a "<WebCore/"-prefixed header
2227         file if its filename doesn't end in "SPI.h" as an alternative to having MigrateHeaders.make copy
2228         such files into the WebKit framework as private headers.
2229         * WebCoreSupport/WebFrameLoaderClient.mm:
2230         * WebInspector/WebNodeHighlight.mm:
2231         * WebView/WebIndicateLayer.mm:
2232         * WebView/WebRenderLayer.h:
2233         * WebView/WebView.mm:
2234
2235 2014-09-16  Daniel Bates  <dabates@apple.com>
2236
2237         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
2238         https://bugs.webkit.org/show_bug.cgi?id=136862
2239
2240         Reviewed by David Kilzer.
2241
2242         * Configurations/DebugRelease.xcconfig:
2243
2244 2014-09-16  Enrica Casucci  <enrica@apple.com>
2245
2246         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
2247         https://bugs.webkit.org/show_bug.cgi?id=136474
2248
2249         Reviewed by Benjamin Poulain.
2250
2251         This is the updated version of the patch that was landed in r173340.
2252         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
2253         and removes the assumption that EAffinity values match NSSelectionAffinity
2254         values. It also removes the includes in TextAffinity.h, creating the need to
2255         include explicitly the files when necessary.
2256
2257         * WebCoreSupport/WebEditorClient.h:
2258         (kit):
2259         (core):
2260
2261 2014-09-14  Daniel Bates  <dabates@apple.com>
2262
2263         [iOS] Attempt to fix the iOS build after <http://trac.webkit.org/changeset/173606>
2264         (https://bugs.webkit.org/show_bug.cgi?id=136789)
2265
2266         Substitute Node::countChildNodes() for Node::childNodeCount() in more places.
2267
2268         * WebView/WebFrame.mm:
2269         (-[WebFrame focusedNodeHasContent]):
2270
2271 2014-09-14  Chris Dumez  <cdumez@apple.com>
2272
2273         Rename Node::childNodeCount() to countChildNodes() and avoid inefficient uses
2274         https://bugs.webkit.org/show_bug.cgi?id=136789
2275
2276         Reviewed by Darin Adler.
2277
2278         Rename childNodeCount() to countChildNodes().
2279
2280         * WebView/WebHTMLView.mm:
2281         (-[WebHTMLView attributedString]):
2282
2283 2014-09-10  Jon Honeycutt  <jhoneycutt@apple.com>
2284
2285         Re-add the request autocomplete feature
2286
2287         <https://bugs.webkit.org/show_bug.cgi?id=136730>
2288
2289         This feature was rolled out in r148731 because it was only used by
2290         Chromium. As we consider supporting this feature, roll it back in, but
2291         leave it disabled.
2292
2293         This rolls out r148731 (which removed the feature) with small changes
2294         needed to make the code build in ToT, to match modern style, to make
2295         the tests run, and to remove unused code.
2296
2297         Reviewed by Andy Estes.
2298
2299         * Configurations/FeatureDefines.xcconfig:
2300         * WebCoreSupport/WebFrameLoaderClient.h:
2301
2302 2014-09-12  Commit Queue  <commit-queue@webkit.org>
2303
2304         Unreviewed, rolling out r173575.
2305         https://bugs.webkit.org/show_bug.cgi?id=136790
2306
2307         Failing tests (Requested by enrica on #webkit).
2308
2309         Reverted changeset:
2310
2311         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
2312         https://bugs.webkit.org/show_bug.cgi?id=136474
2313         http://trac.webkit.org/changeset/173575
2314
2315 2014-09-12  Enrica Casucci  <enrica@apple.com>
2316
2317         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
2318         https://bugs.webkit.org/show_bug.cgi?id=136474
2319
2320         Reviewed by Benjamin Poulain.
2321
2322         This is the updated version of the patch that was landed in r173340.
2323         I changed the use of IntPoint to FloatPoint since it was causing tests
2324         to fail.
2325         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
2326         and removes the assumption that EAffinity values match NSSelectionAffinity
2327         values. It also removes the includes in TextAffinity.h, creating the need to
2328         include explicitly the files when necessary. It also removes the unnecessary
2329         use of platform specific types, replacing them with WebCore types.
2330
2331         * WebCoreSupport/WebEditorClient.h:
2332         (kit):
2333         (core):
2334         * WebView/WebFrameView.mm:
2335         (-[WebFrameView _scrollToBeginningOfDocument]):
2336         (-[WebFrameView _scrollToEndOfDocument]):
2337
2338 2014-09-11  Bear Travis  <betravis@adobe.com>
2339
2340         [CSS Font Loading] Enable CSS Font Loading on Mac
2341         https://bugs.webkit.org/show_bug.cgi?id=135473
2342
2343         Reviewed by Antti Koivisto.
2344
2345         Enable CSS Font Loading in FeatureDefines.
2346
2347         * Configurations/FeatureDefines.xcconfig:
2348
2349 2014-09-11  Beth Dakin  <bdakin@apple.com>
2350
2351         Support rubber-banding in sub-frames
2352         https://bugs.webkit.org/show_bug.cgi?id=136726
2353         -and corresponding-
2354         rdar://problem/10011924
2355
2356         Reviewed by Tim Horton.
2357
2358         rubberBandingForOverflowScrollEnabled is re-named to
2359         rubberBandingForSubScrollableRegionsEnabled
2360         * WebView/WebView.mm:
2361         (-[WebView _preferencesChanged:]):
2362
2363 2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
2364
2365         Disable the "unreachable-code" warning
2366         https://bugs.webkit.org/show_bug.cgi?id=136677
2367
2368         Reviewed by Darin Adler.
2369
2370         * Configurations/Base.xcconfig:
2371
2372 2014-09-08  Maciej Stachowiak  <mjs@apple.com>
2373
2374         Fix 32-bit Mac build for new warnings
2375         https://bugs.webkit.org/show_bug.cgi?id=136624
2376
2377         Reviewed by Darin Adler.
2378         
2379         (Jessie already fixed this but my version with typedefs seems a tiny bit cleaner.)
2380
2381         * Carbon/HIViewAdapter.m:
2382         (+[HIViewAdapter bindHIViewToNSView:nsView:]): Need to use explicit casting now.
2383
2384 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2385
2386         Remove FILTERS flag
2387         https://bugs.webkit.org/show_bug.cgi?id=136571
2388
2389         Reviewed by Darin Adler.
2390
2391         * Configurations/FeatureDefines.xcconfig:
2392
2393 2014-09-08  Jessie Berlin  <jberlin@apple.com>
2394
2395         32-bit build fix after r173364.
2396
2397         * Carbon/HIViewAdapter.m:
2398         (+[HIViewAdapter bindHIViewToNSView:nsView:]):
2399
2400 2014-09-08  Dan Bernstein  <mitz@apple.com>
2401
2402         Build fix.
2403
2404         Added back SPI that is still in use.
2405
2406         * Misc/WebNSURLExtras.h:
2407         * Misc/WebNSURLExtras.mm:
2408         (-[NSURL _webkit_URLByRemovingFragment]):
2409
2410 2014-09-08  Dan Bernstein  <mitz@apple.com>
2411
2412         iOS Simulator build fix.
2413
2414         * Misc/WebKitSystemBits.m:
2415         (WebMemorySize):
2416
2417 2014-09-07  Darin Adler  <darin@apple.com>
2418
2419         Fix build failure seen on Mountain Lion buildbot.
2420
2421         * Misc/WebNSDataExtras.h: Make WEB_GUESS_MIME_TYPE_PEEK_LENGTH an unsigned instead
2422         of an int, to avoid warning about mixing signs.
2423
2424 2014-09-06  Darin Adler  <darin@apple.com>
2425
2426         Make updates suggested by new version of Xcode
2427         https://bugs.webkit.org/show_bug.cgi?id=136603
2428
2429         Reviewed by Mark Rowe.
2430
2431         * Configurations/Base.xcconfig: Added CLANG_WARN_UNREACHABLE_CODE, COMBINE_HIDPI_IMAGES,
2432         and ENABLE_STRICT_OBJC_MSGSEND as suggested by Xcode upgrade check.
2433
2434         * History/WebURLsWithTitles.m:
2435         (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): Use NSUInteger instead of
2436         unsigned for correctness, and to quiet the 32-to-64-bit compiler warning (which is
2437         not turned on because it gives us too many false positives).
2438         * Misc/WebElementDictionary.mm:
2439         (-[WebElementDictionary objectForKey:]): Ditto.
2440         * Misc/WebNSDataExtras.m:
2441         (-[NSData _webkit_guessedMIMETypeForXML]): Ditto.
2442         (-[NSData _webkit_guessedMIMEType]): Ditto.
2443         (-[NSData _webkit_parseRFC822HeaderFields]): Ditto.
2444         (-[NSData _web_locationAfterFirstBlankLine]): Ditto.
2445
2446         * Misc/WebNSURLExtras.h: Removed unused _web_URLWithLowercasedScheme, _web_hostData,
2447         _webkit_URLByRemovingFragment, _webkit_URLByRemovingResourceSpecifier, _webkit_isFTPDirectoryURL,
2448         _webkit_shouldLoadAsEmptyDocument, _web_hostNameNeedsDecodingWithRange:,
2449         _web_hostNameNeedsEncodingWithRange:, _web_decodeHostNameWithRange:, _web_encodeHostNameWithRange:,
2450         and _webkit_URLFragment methods.
2451
2452         * Misc/WebNSURLExtras.mm:
2453         (-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): Deleted.
2454         (-[NSURL _webkit_URLByRemovingFragment]): Deleted.
2455         (-[NSURL _webkit_URLByRemovingResourceSpecifier]): Deleted.
2456         (-[NSURL _webkit_isFTPDirectoryURL]): Deleted.
2457         (-[NSURL _webkit_shouldLoadAsEmptyDocument]): Deleted.
2458         (-[NSURL _web_URLWithLowercasedScheme]): Deleted.
2459         (-[NSString _webkit_isFTPDirectoryURL]): Deleted.
2460         (-[NSString _web_hostNameNeedsDecodingWithRange:]): Deleted.
2461         (-[NSString _web_hostNameNeedsEncodingWithRange:]): Deleted.
2462         (-[NSString _web_decodeHostNameWithRange:]): Deleted.
2463         (-[NSString _web_encodeHostNameWithRange:]): Deleted.
2464         (-[NSString _webkit_URLFragment]): Deleted.
2465
2466         * Plugins/WebPluginDatabase.mm:
2467         (-[WebPluginDatabase removePluginInstanceViewsFor:]): Use a modern for loop
2468         to iterate an array instead of a loop using the type "unsigned int".
2469
2470         * WebCoreSupport/WebOpenPanelResultListener.mm:
2471         (-[WebOpenPanelResultListener chooseFilenames:]): Use NSUInteger instead of int.
2472
2473         * WebView/WebDelegateImplementationCaching.mm:
2474         (CallDelegate): Use wtfCallIMP in one overload that was instead just calling the
2475         directly without a proper type for the function pointer. This might have been causing
2476         an actual problem on 64-bit systems, and it was different from all the other CallDelegate
2477         functions that were already doing this correctly.
2478
2479         * WebView/WebTextCompletionController.mm:
2480         (-[WebTextCompletionController _placePopupWindow:]): Use NSUInteger instead of int.
2481
2482 2014-09-06  Brian J. Burg  <burg@cs.washington.edu>
2483
2484         Web Inspector: convert DockSide to an enum class
2485         https://bugs.webkit.org/show_bug.cgi?id=136601
2486
2487         Reviewed by Timothy Hatcher.
2488
2489         * WebCoreSupport/WebInspectorClient.mm:
2490         (WebInspectorFrontendClient::frontendLoaded):
2491         (-[WebInspectorWindowController attachWindow:]):
2492         (-[WebInspectorWindowController attach]):
2493         (-[WebInspectorWindowController detach]):
2494         * WebInspector/WebInspectorFrontend.mm:
2495         (-[WebInspectorFrontend attach]):
2496
2497 2014-09-05  Commit Queue  <commit-queue@webkit.org>
2498
2499         Unreviewed, rolling out r173340 and r173342.
2500         https://bugs.webkit.org/show_bug.cgi?id=136596
2501
2502         Broke many tests (Requested by ap on #webkit).
2503
2504         Reverted changesets:
2505
2506         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
2507         https://bugs.webkit.org/show_bug.cgi?id=136474
2508         http://trac.webkit.org/changeset/173340
2509
2510         "Build fix after r173340."
2511         http://trac.webkit.org/changeset/173342
2512
2513 2014-09-05  Enrica Casucci  <enrica@apple.com>
2514
2515         Build fix after r173340.
2516
2517         * WebCoreSupport/WebEditorClient.h:
2518         (kit):
2519         (core):
2520
2521 2014-09-05  Enrica Casucci  <enrica@apple.com>
2522
2523         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
2524         https://bugs.webkit.org/show_bug.cgi?id=136474
2525
2526         Reviewed by Benjamin Poulain.
2527
2528         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
2529         and removes the assumption that EAffinity values match NSSelectionAffinity
2530         values. It also removes the includes in TextAffinity.h, creating the need to
2531         include explicitly the files when necessary. It also removes the unnecessary
2532         use of platform specific types, replacing them with WebCore types.
2533
2534         * WebCoreSupport/WebEditorClient.h: Added kit and core for EAffinity.
2535         * WebView/WebFrameView.mm:
2536         (-[WebFrameView _scrollToBeginningOfDocument]):
2537         (-[WebFrameView _scrollToEndOfDocument]):
2538
2539 2014-09-05  Daniel Bates  <dabates@apple.com>
2540
2541         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
2542         (https://bugs.webkit.org/show_bug.cgi?id=136564)
2543
2544         Move #endif inside -viewDidMoveToWindow up one line such that the closing brace ('}') is after it.
2545
2546         * WebView/WebHTMLView.mm:
2547         (-[WebHTMLView viewDidMoveToWindow]):
2548
2549 2014-09-05  Daniel Bates  <dabates@apple.com>
2550
2551         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
2552         (https://bugs.webkit.org/show_bug.cgi?id=136564)
2553
2554         Add !PLATFORM(IOS)-guard in -viewDidMoveToWindow around code that references WebHTMLViewPrivate.flagsChangedEventMonitor.
2555         The instance variable WebHTMLViewPrivate.flagsChangedEventMonitor is guarded by !PLATFORM(IOS).
2556
2557         * WebView/WebHTMLView.mm:
2558         (-[WebHTMLView viewDidMoveToWindow]):
2559
2560 2014-09-05  Daniel Bates  <dabates@apple.com>
2561
2562         [iOS] Fix the iOS build after <http://trac.webkit.org/changeset/173309>
2563         (https://bugs.webkit.org/show_bug.cgi?id=136564)
2564
2565         Include more code inside the !PLATFORM(IOS)-guarded section in -setDataSource:.
2566
2567         * WebView/WebHTMLView.mm:
2568         (-[WebHTMLView setDataSource:]):
2569
2570 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
2571
2572         Use tracking areas instead of (SPI) mouse moved notifications, and follow flags changes with an event monitor
2573         https://bugs.webkit.org/show_bug.cgi?id=136564
2574
2575         Reviewed by Dan Bernstein.
2576         
2577         WebKit1 depended on mouse moved event notifications to track mouse
2578         moves, and on being specially called by Safari to track flags
2579         changes. WebKit2 does both these things better - it uses a tracking area
2580         and event monitors. Copy those approaches.
2581
2582         * WebKit.order: Remove reference to obsolete call.
2583         * WebView/WebHTMLView.mm:
2584         (-[WebHTMLViewPrivate dealloc]): No need to deallocate tracking
2585         area, since we now just always have one.
2586         (-[WebHTMLViewPrivate clear]): ditto
2587         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
2588         New method that posts a fake mouse move event in response to
2589         a flags change event, for use by the event monitor.
2590         (+[WebHTMLView _postFlagsChangedEvent:]): Empty this old call,
2591         still kept around for benefit of older Safari.
2592         (-[WebHTMLView _updateMouseoverWithEvent:]): Handle Dashboard's
2593         special mouseover mode (previously handled in a weird way).
2594         (-[WebHTMLView close]): No more need to mess with mouse moved observer.
2595         (-[WebHTMLView viewWillMoveToWindow:]): ditto
2596         (-[WebHTMLView viewDidMoveToWindow]): ditto; but now hook up a flags
2597         changed monitor.
2598         (-[WebHTMLView windowDidBecomeKey:]): No need to handle non-key window
2599         tracking area or mouse moved observer.
2600         (-[WebHTMLView windowDidResignKey:]): ditto
2601         (-[WebHTMLView windowWillOrderOnScreen:]): No need to mess with mouse
2602         moved observer.
2603         (-[WebHTMLView windowWillOrderOffScreen:]): ditto
2604         (-[WebHTMLView mouseMoved:]): Converted from the old mouseMovedNotification:
2605         (-[WebHTMLView setDataSource:]): Change if around body to early return. Hook
2606         up tracking area - we have to do it here, because before this point, the
2607         WebHTMLView does not know its WebView, which is where dashboard settings
2608         live.
2609         (-[WebHTMLView _removeMouseMovedObserverUnconditionally]): Deleted.
2610         (-[WebHTMLView addMouseMovedObserver]): Deleted.
2611         (-[WebHTMLView removeMouseMovedObserver]): Deleted.
2612
2613 2014-09-04  Pratik Solanki  <psolanki@apple.com>
2614
2615         Bring back [WebPreferences setDiskImageCacheEnabled:] for backwards compatibility
2616         https://bugs.webkit.org/show_bug.cgi?id=136560
2617
2618         Reviewed by Joseph Pecoraro.
2619
2620         I removed the disk image caching code in r173265. However, we still have clients that call
2621         setDiskImageCacheEnabled. Add in a stub method until we can wean the clients off this call.
2622
2623         * WebView/WebPreferences.mm:
2624         (-[WebPreferences setDiskImageCacheEnabled:]):
2625         * WebView/WebPreferencesPrivate.h:
2626
2627 2014-09-03  Andy Estes  <aestes@apple.com>
2628
2629         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
2630         https://bugs.webkit.org/show_bug.cgi?id=136521
2631
2632         Reviewed by Anders Carlsson.
2633
2634         Taught MigrateHeaders.make to remove WEBCORE_EXPORT from headers using this sed expression:
2635
2636             s/(^ *)WEBCORE_EXPORT /\1/g
2637
2638         This removes WEBCORE_EXPORT and a single following space character but preserves preceeding spaces.
2639
2640         * MigrateHeaders.make:
2641
2642 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
2643
2644         Remove WebCoreSystemInterface glue for otherwise unused WKSI calls
2645         https://bugs.webkit.org/show_bug.cgi?id=136527
2646
2647         Reviewed by Alexey Proskuryakov.
2648
2649         * WebCoreSupport/WebSystemInterface.mm:
2650         (InitWebCoreSystemInterface):
2651
2652 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2653
2654         Remove CSS_FILTERS flag
2655         https://bugs.webkit.org/show_bug.cgi?id=136529
2656
2657         Reviewed by Dirk Schulze.
2658
2659         * Configurations/FeatureDefines.xcconfig:
2660
2661 2014-09-04  Pratik Solanki  <psolanki@apple.com>
2662
2663         Remove iOS specific disk image cache
2664         https://bugs.webkit.org/show_bug.cgi?id=136517
2665
2666         Reviewed by Antti Koivisto.
2667
2668         Disk image cache code unnecessarily complicates SharedBuffer implementation. We can remove
2669         this now since we don't enable it in WebKit2 on iOS.
2670
2671         * Misc/WebCache.mm:
2672         (+[WebCache statistics]):
2673         * WebView/WebDataSource.mm:
2674         (-[WebDataSource _setAllowToBeMemoryMapped]):
2675         (-[WebDataSource setDataSourceDelegate:]):
2676         (-[WebDataSource dataSourceDelegate]):
2677         (-[WebDataSource dealloc]):
2678         (BufferMemoryMapped): Deleted.
2679         * WebView/WebPreferenceKeysPrivate.h:
2680         * WebView/WebPreferences.mm:
2681         (+[WebPreferences initialize]):
2682         (-[WebPreferences diskImageCacheEnabled]): Deleted.
2683         (-[WebPreferences setDiskImageCacheEnabled:]): Deleted.
2684         (-[WebPreferences diskImageCacheMinimumImageSize]): Deleted.
2685         (-[WebPreferences setDiskImageCacheMinimumImageSize:]): Deleted.
2686         (-[WebPreferences diskImageCacheMaximumCacheSize]): Deleted.
2687         (-[WebPreferences setDiskImageCacheMaximumCacheSize:]): Deleted.
2688         (-[WebPreferences _diskImageCacheSavedCacheDirectory]): Deleted.
2689         (-[WebPreferences _setDiskImageCacheSavedCacheDirectory:]): Deleted.
2690         * WebView/WebPreferencesPrivate.h:
2691         * WebView/WebView.mm:
2692         (-[WebView _commonInitializationWithFrameName:groupName:]):
2693         (+[WebView _handleMemoryWarning]):
2694         (-[WebView _preferencesChanged:]):
2695
2696 2014-09-04  Daniel Bates  <dabates@apple.com>
2697
2698         [iOS] Make iOS build when ENABLE_TOUCH_EVENT and ENABLE_IOS_TOUCH_EVENTS disabled
2699         https://bugs.webkit.org/show_bug.cgi?id=136494
2700
2701         Reviewed by Andy Estes.
2702
2703         * MigrateHeaders.make: Migrate header WebEventRegion.h only when ENABLE_IOS_TOUCH_EVENTS is defined.
2704         * WebView/WebView.mm: Substitute ENABLE(IOS_TOUCH_EVENTS) for ENABLE(TOUCH_EVENTS).
2705
2706 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
2707
2708         Web Inspector: fix prefixes for subclasses of JSC::ConsoleClient
2709         https://bugs.webkit.org/show_bug.cgi?id=136476
2710
2711         Reviewed by Timothy Hatcher.
2712
2713         * Misc/WebCoreStatistics.mm:
2714         (+[WebCoreStatistics shouldPrintExceptions]):
2715         (+[WebCoreStatistics setShouldPrintExceptions:]):
2716
2717 2014-09-03  Enrica Casucci  <enrica@apple.com>
2718
2719         Remove PLATFORM(IOS) from WebCore/editing (Part 1).
2720         https://bugs.webkit.org/show_bug.cgi?id=136474
2721
2722         Reviewed by Tim Horton.
2723
2724         * WebCoreSupport/WebEditorClient.mm:
2725         (undoNameForEditAction):
2726
2727 2014-09-02  Maciej Stachowiak  <mjs@apple.com>
2728
2729         Clean up naming for and slightly refactor legacy video fullscreen support
2730         https://bugs.webkit.org/show_bug.cgi?id=136446
2731
2732         Reviewed by Jer Noble.
2733
2734         Key changes:
2735         supportsFullscreenForNode(Node*) --> supportsVideoFullscreen()
2736         enterFullscreenForNode(Node*) --> enterVideoFullscreenForVideoElement(HTMLVideoElement*)
2737         exitFullscreenForNode(Node*) --> exitVideoFullscreen()
2738         
2739         The old versions had unnecessary parameters, did not clearly distinguish their purpose
2740         from enterFullscreenForElement and friends, and wrongly claimed generality to all Nodes.
2741         Also changed many other places to use HTMLVideoElement* instead of Node* or 
2742         HTMLMediaElement* when they were in fact only used for video elements and would only
2743         work for such.
2744
2745         * WebCoreSupport/WebChromeClient.h:
2746         * WebCoreSupport/WebChromeClient.mm:
2747         (WebChromeClient::supportsVideoFullscreen): Adjust for main refactoring.
2748         Also no more need to check for video elementness.
2749         (WebChromeClient::enterVideoFullscreenForVideoElement): Adjust for main refactoring.
2750         (WebChromeClient::exitVideoFullscreen): ditto
2751         * WebView/WebView.mm:
2752         (-[WebView _enterVideoFullscreenForVideoElement:]): Adjust for main
2753         refactoring.
2754         (-[WebView _exitVideoFullscreen]): ditto
2755         (-[WebView _close]): ditto
2756         * WebView/WebViewInternal.h:
2757
2758 2014-09-03  Dan Bernstein  <mitz@apple.com>
2759
2760         Get rid of HIGH_DPI_CANVAS leftovers
2761         https://bugs.webkit.org/show_bug.cgi?id=136491
2762
2763         Reviewed by Benjamin Poulain.
2764
2765         * Configurations/FeatureDefines.xcconfig: Removed definition of ENABLE_HIGH_DPI_CANVAS
2766         and removed it from FEATURE_DEFINES.
2767
2768 2014-08-31  Tim Horton  <timothy_horton@apple.com>
2769
2770         Remove unnecessary (and unnecessarily iOS-specific) setStrokeAndFillColor
2771         https://bugs.webkit.org/show_bug.cgi?id=136416
2772
2773         Reviewed by Dan Bernstein.
2774
2775         * WebView/WebFrameView.mm:
2776         (-[WebFrameView drawRect:]):
2777         We only end up filling, so only set the fill color.
2778
2779 2014-08-26  Maciej Stachowiak  <mjs@apple.com>
2780
2781         Use RetainPtr::autorelease in some places where it seems appropriate
2782         https://bugs.webkit.org/show_bug.cgi?id=136280
2783
2784         Reviewed by Darin Adler.
2785
2786         * WebView/WebHTMLView.mm:
2787         (imageFromRect): Use RetainPtr in this function.
2788         * WebView/WebPDFRepresentation.mm:
2789         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use RetainPtr
2790         in this method.
2791
2792 2014-08-29  Csaba Osztrogonác  <ossy@webkit.org>
2793
2794         Unreviwed, remove empty directories.
2795
2796         * ForwardingHeaders/wtf: Removed.
2797
2798 2014-08-27  Zalan Bujtas  <zalan@apple.com>
2799
2800         Subpixel layout: Rename LayoutRect's device pixel snapping functions.
2801         https://bugs.webkit.org/show_bug.cgi?id=136319
2802
2803         Reviewed by Simon Fraser.
2804
2805         From pixelSnappedForPainting() to snapRectToDevicePixels() and 
2806         pixelSnappedIntRect*() to snappedIntRect*().
2807
2808         No change in functionality.
2809
2810         * WebView/WebView.mm:
2811         (-[WebView _dashboardRegions]):
2812         (-[WebView trackedRepaintRects]):
2813
2814 2014-08-25  Maciej Stachowiak  <mjs@apple.com>
2815
2816         Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API
2817         https://bugs.webkit.org/show_bug.cgi?id=136082
2818
2819         Reviewed by Alexey Proskuryakov.
2820
2821         * Plugins/Hosted/NetscapePluginHostManager.mm:
2822         (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current
2823         localization name using WebCore helper instead of SPI.
2824         * Plugins/WebBasePluginPackage.mm: Fixed the include style for this 
2825         file.
2826         (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current
2827         localization name using WebCore helper instead of SPI.
2828         (+[WebBasePluginPackage preferredLocalizationName]): Deleted. This
2829         helper no longer pulls its weight.
2830         * WebCoreSupport/WebSystemInterface.mm: 
2831         (InitWebCoreSystemInterface): Remove mention of
2832         WKCopyCFLocalizationPreferredName.
2833         * WebKit.order: ditto
2834
2835 2014-08-25  Daniel Bates  <dabates@apple.com>
2836
2837         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/172889>
2838         (https://bugs.webkit.org/show_bug.cgi?id=109658)
2839
2840         Substitute GraphicsLayer::setContentsToPlatformLayer(..., GraphicsLayer::ContentsLayerForMedia)
2841         for GraphicsLayer::setContentsToMedia(...) because the latter was removed in <http://trac.webkit.org/changeset/172889>.
2842
2843         * WebView/WebView.mm:
2844         (-[WebView _setMediaLayer:forPluginView:]):
2845
2846 2014-08-22  Commit Queue  <commit-queue@webkit.org>
2847
2848         Unreviewed, rolling out r172866.
2849         https://bugs.webkit.org/show_bug.cgi?id=136177
2850
2851         Broke iOS build (Requested by othermaciej on #webkit).
2852
2853         Reverted changeset:
2854
2855         "Replace use of WKCopyCFLocalizationPreferredName with
2856         NSLocale public API"
2857         https://bugs.webkit.org/show_bug.cgi?id=136082
2858         http://trac.webkit.org/changeset/172866
2859
2860 2014-08-22  Simon Fraser  <simon.fraser@apple.com>
2861
2862         Implement paint flashing in the WK1 InspectorOverlay page
2863         https://bugs.webkit.org/show_bug.cgi?id=136138
2864
2865         Reviewed by Sam Weinig, Joseph Pecoraro.
2866
2867         Implement paint flashing for the WebKit1 InspectorOverlay via a second canvas in the overlay page.
2868         We avoid allocating backing store for this canvas until we have paint rects.
2869         
2870         Because this overlay page is weird and doesn't know how to paint itself, InspectorOverlay manages
2871         an array of rects, and pushes them to the page when they change, before forcing a paint.
2872         
2873         Because iOS doesn't use the InspectorOverlay page, stub out setShowPaintRects on its
2874         WebKit WebInspectorClient, but don't yet implement paint flashing there.
2875
2876         * WebCoreSupport/WebInspectorClient.h:
2877         * WebCoreSupport/WebInspectorClient.mm:
2878         (WebInspectorClient::WebInspectorClient):
2879
2880 2014-08-20  Maciej Stachowiak  <mjs@apple.com>
2881
2882         Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API
2883         https://bugs.webkit.org/show_bug.cgi?id=136082
2884
2885         Reviewed by Alexey Proskuryakov.
2886
2887         * Plugins/Hosted/NetscapePluginHostManager.mm:
2888         (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current
2889         localization name using WebCore helper instead of SPI.
2890         * Plugins/WebBasePluginPackage.mm: Fixed the include style for this 
2891         file.
2892         (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current
2893         localization name using WebCore helper instead of SPI.
2894         (+[WebBasePluginPackage preferredLocalizationName]): Deleted. This
2895         helper no longer pulls its weight.
2896         * WebCoreSupport/WebSystemInterface.mm: 
2897         (InitWebCoreSystemInterface): Remove mention of
2898         WKCopyCFLocalizationPreferredName.
2899         * WebKit.order: ditto
2900
2901 2014-08-22  Daniel Bates  <dabates@apple.com>
2902
2903         [iOS] Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, and temporarily disable ENABLE_TOUCH_EVENTS
2904         and ENABLE_XSLT when building with the iOS public SDK
2905         https://bugs.webkit.org/show_bug.cgi?id=135945
2906
2907         Reviewed by Andy Estes.
2908
2909         * Configurations/FeatureDefines.xcconfig: Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, ENABLE_TOUCH_EVENTS
2910         and ENABLE_XSLT when building with the public SDK.
2911         * MigrateHeaders.make: Conditionally migrate headers for touch and gesture events.
2912
2913 2014-08-22  Jon Lee  <jonlee@apple.com>
2914
2915         Fix iOS build due to r172832 and move RUBBER_BANDING out of FeatureDefines.h
2916         https://bugs.webkit.org/show_bug.cgi?id=136157
2917
2918         Reviewed by Simon Fraser.
2919
2920         * Configurations/FeatureDefines.xcconfig: Add ENABLE(RUBBER_BANDING).
2921         * WebView/WebView.mm:
2922         (-[WebView _preferencesChanged:]): Wrap in ENABLE(RUBBER_BANDING).
2923
2924 2014-08-21  Zalan Bujtas  <zalan@apple.com>
2925
2926         Enable SATURATED_LAYOUT_ARITHMETIC.
2927         https://bugs.webkit.org/show_bug.cgi?id=136106
2928
2929         Reviewed by Simon Fraser.
2930
2931         SATURATED_LAYOUT_ARITHMETIC protects LayoutUnit against arithmetic overflow.
2932         (No measurable performance regression on Mac.)
2933
2934         * Configurations/FeatureDefines.xcconfig:
2935
2936 2014-08-21  Beth Dakin  <bdakin@apple.com>
2937
2938         overflow:scroll elements should support rubber-banding
2939         https://bugs.webkit.org/show_bug.cgi?id=91655
2940
2941         Reviewed by Sam Weinig and Darin Adler.
2942
2943         Disable rubber-banding in overflow areas for now.
2944         * WebView/WebView.mm:
2945         (-[WebView _preferencesChanged:]):
2946
2947 2014-08-19  Pratik Solanki  <psolanki@apple.com>
2948
2949         Remove PurgeableBuffer since it is not very useful any more
2950         https://bugs.webkit.org/show_bug.cgi?id=135939
2951
2952         Reviewed by Andreas Kling.
2953
2954         * Misc/WebCache.mm:
2955         (+[WebCache statistics]):
2956
2957 2014-08-19  Zalan Bujtas  <zalan@apple.com>
2958
2959         Remove ENABLE(SUBPIXEL_LAYOUT).
2960         https://bugs.webkit.org/show_bug.cgi?id=136077
2961
2962         Reviewed by Simon Fraser.
2963
2964         Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.
2965
2966         * Configurations/FeatureDefines.xcconfig:
2967
2968 2014-08-18  Maciej Stachowiak  <mjs@apple.com>
2969
2970         Use NSURLFileTypeMappings directly instead of depending on WebKitSystemInterface wrappers for it
2971         https://bugs.webkit.org/show_bug.cgi?id=136035
2972
2973         Reviewed by Dan Bernstein.
2974
2975         * Misc/WebNSViewExtras.m:
2976         (-[NSView _web_DragImageForElement:rect:event:pasteboard:source:offset:]): Remove comment
2977         reference to obsolete WKSI function.
2978         * WebCoreSupport/WebSystemInterface.mm:
2979         (InitWebCoreSystemInterface): Don't initialize the no-longer-used WKGetExtensionsForMIMEType,
2980         WKGetPreferredExtensionForMIMEType, or WKGetMIMETypeForExtension
2981         * Plugins/WebPluginDatabase.mm:
2982         (-[WebPluginDatabase pluginForExtension:]): Include SPI header from WebCore; use
2983         NSURLFileTypeMappings directly instead of via WKSI wrapper.
2984         * WebCoreSupport/WebFrameLoaderClient.mm:
2985         (WebFrameLoaderClient::objectContentType): ditto
2986         * WebView/WebHTMLView.mm:
2987         (-[WebHTMLView _imageExistsAtPaths:]): ditto
2988         * WebView/WebView.mm:
2989         (+[WebView _supportedFileExtensions]): ditto
2990         (+[WebView suggestedFileExtensionForMIMEType:]): ditto
2991         (+[WebView _MIMETypeForFile:]): ditto
2992
2993 2014-08-18  Commit Queue  <commit-queue@webkit.org>
2994
2995         Unreviewed, rolling out r172736.
2996         https://bugs.webkit.org/show_bug.cgi?id=136060
2997
2998         Caused 14% PLT regressions (Requested by rniwa on #webkit).
2999
3000         Reverted changeset:
3001
3002         "Remove PurgeableBuffer since it is not very useful any more"
3003         https://bugs.webkit.org/show_bug.cgi?id=135939
3004         http://trac.webkit.org/changeset/172736
3005
3006 2014-08-18  Pratik Solanki  <psolanki@apple.com>
3007
3008         Remove PurgeableBuffer since it is not very useful any more
3009         https://bugs.webkit.org/show_bug.cgi?id=135939
3010
3011         Reviewed by Geoffrey Garen.
3012
3013         * Misc/WebCache.mm:
3014         (+[WebCache statistics]):
3015
3016 2014-08-18  Andy Estes  <aestes@apple.com>
3017
3018         REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
3019         https://bugs.webkit.org/show_bug.cgi?id=136010
3020
3021         Reviewed by Darin Adler.
3022
3023         * Misc/WebKitVersionChecks.h: Removed WEBKIT_FIRST_VERSION_WITH_NAVIGATION_URL_VALIDATION.
3024         * WebView/WebPDFView.mm:
3025         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Passed AllowNavigationToInvalidURL::Yes to FrameLoader::loadFrameRequest.
3026         * WebView/WebView.mm:
3027         (-[WebView _preferencesChanged:]): Reverted the linked-on-or-after check added in r170120 since it's no longer necessary.
3028
3029 2014-08-18  Andy Estes  <aestes@apple.com>
3030
3031         Revert r172697.
3032
3033         It made several webarchive layout tests flaky and didn't have the correct behavior for non-quick redirects.
3034
3035         * Misc/WebKitVersionChecks.h:
3036         * WebView/WebView.mm:
3037         (-[WebView _preferencesChanged:]):
3038
3039 2014-08-15  Andy Estes  <aestes@apple.com>
3040
3041         REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
3042         https://bugs.webkit.org/show_bug.cgi?id=136010
3043
3044         Reviewed by Darin Adler.
3045
3046         Reverted the linked-on-or-after check added in r170120 since it is no longer necessary.
3047
3048         * Misc/WebKitVersionChecks.h:
3049         * WebView/WebView.mm:
3050         (-[WebView _preferencesChanged:]):
3051
3052 2014-08-16  Maciej Stachowiak  <mjs@apple.com>
3053
3054         Remove the obsolete WebKitEnableCoalescedUpdatesPreferenceKey
3055         https://bugs.webkit.org/show_bug.cgi?id=136024
3056
3057         Reviewed by Filip Pizlo.
3058
3059         * WebView/WebFrameView.mm:
3060         (-[WebFrameView initWithFrame:]): Remove code that respects
3061         this key. It was SPI and is no longer used; also it was
3062         only relevant for versions of OS X that WebKit no longer supports.
3063         * WebView/WebPreferenceKeysPrivate.h: Remove declaration.
3064
3065 2014-08-15  Daniel Bates  <dabates@apple.com>
3066
3067         [iOS] Teach postprocess-headers.sh to remove code guarded by ENABLE_IOS_GESTURE_EVENTS
3068         and ENABLE_TOUCH_EVENTS if applicable
3069         https://bugs.webkit.org/show_bug.cgi?id=135993
3070
3071         Reviewed by Andy Estes.
3072
3073         Add support infrastructure to remove code from public and private API headers that is
3074         guarded by macro define ENABLE_{IOS_GESTURE, TOUCH}_EVENTS when these features are disabled.
3075
3076         We aren't using this functionality yet, but we will soon.
3077
3078         * postprocess-headers.sh:
3079
3080 2014-08-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3081
3082         Enable CSS_SCROLL_SNAP for iOS
3083         https://bugs.webkit.org/show_bug.cgi?id=135915
3084
3085         Turn on CSS_SCROLL_SNAP for iOS and the iOS simulator.
3086
3087         Reviewed by Tim Horton.
3088
3089         * Configurations/FeatureDefines.xcconfig:
3090
3091 2014-08-13  Mark Rowe  <mrowe@apple.com>
3092
3093         <https://webkit.org/b/135911> WebKit should build on Yosemite with the public SDK.
3094
3095         Reviewed by Darin Adler.
3096
3097         * Misc/WebSharingServicePickerController.mm: Forward-declare some details related to NSSharingServicePicker.
3098
3099 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3100
3101         Web Inspector: Workaround a NSWindow change to the title bar.
3102         https://bugs.webkit.org/show_bug.cgi?id=135880
3103
3104         Reviewed by Joseph Pecoraro.
3105
3106         * WebCoreSupport/WebInspectorClient.mm:
3107         (WebInspectorFrontendClient::setToolbarHeight): Only call setContentBorderThickness: on 10.9 and earlier.
3108         (-[WebInspectorWindowController init]): Only call setDrawsBackground: on 10.9 and earlier.
3109         (-[WebInspectorWindowController window]): Set titlebarAppearsTransparent on 10.10.
3110         Only call border thickness APIs on 10.9 and earlier.
3111
3112 2014-08-12  Peyton Randolph  <prandolph@apple.com>
3113
3114         Runtime switch for long mouse press gesture. Part of 135257 - Add long mouse press gesture.           
3115         https://bugs.webkit.org/show_bug.cgi?id=135682
3116
3117         Reviewed by Tim Horton.
3118
3119         * Configurations/FeatureDefines.xcconfig:
3120         Remove LONG_MOUSE_PRESS feature flag.
3121
3122 2014-08-11  Andy Estes  <aestes@apple.com>
3123
3124         [iOS] Get rid of iOS.xcconfig
3125         https://bugs.webkit.org/show_bug.cgi?id=135809
3126
3127         Reviewed by Joseph Pecoraro.
3128
3129         All iOS.xcconfig did was include AspenFamily.xcconfig, so there's no need for the indirection.
3130
3131         * Configurations/Base.xcconfig:
3132         * Configurations/iOS.xcconfig: Removed.
3133
3134 2014-08-10  Timothy Hatcher  <timothy@apple.com>
3135
3136         Web Inspector: new glyphs are visible on OS X 10.9 builds
3137         https://bugs.webkit.org/show_bug.cgi?id=135743
3138
3139         Reviewed by Joseph Pecoraro.
3140
3141         * WebCoreSupport/WebInspectorClient.mm:
3142         (-[WebInspectorWindowController window]): Use 10100 instead of 1090 for the version.
3143
3144 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
3145
3146         Get rid of SCRIPTED_SPEECH
3147         https://bugs.webkit.org/show_bug.cgi?id=135729
3148
3149         Reviewed by Brent Fulgham.
3150
3151         * Configurations/FeatureDefines.xcconfig:
3152
3153 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
3154
3155         Get rid of INPUT_SPEECH
3156         https://bugs.webkit.org/show_bug.cgi?id=135672
3157
3158         Reviewed by Andreas Kling.
3159
3160         * Configurations/FeatureDefines.xcconfig:
3161
3162 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3163
3164         Web Inspector: Update glyphs to be more like Xcode 6
3165         https://bugs.webkit.org/show_bug.cgi?id=135705
3166
3167         Reviewed by Joseph Pecoraro.
3168
3169         * Resources/Dock.pdf: Added.
3170         * Resources/DockLegacy.pdf: Copied from Source/WebKit/mac/Resources/Dock.pdf.
3171         * WebCoreSupport/WebInspectorClient.mm:
3172         (-[WebInspectorWindowController window]): Use new images.
3173
3174 2014-08-06  Dean Jackson  <dino@apple.com>
3175
3176         ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED is not used anywhere. Remove it.
3177         https://bugs.webkit.org/show_bug.cgi?id=135675
3178
3179         Reviewed by Sam Weinig.
3180
3181         * Configurations/FeatureDefines.xcconfig:
3182
3183 2014-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3184
3185         Implement parsing for CSS scroll snap points
3186         https://bugs.webkit.org/show_bug.cgi?id=134301
3187
3188         Reviewed by Dean Jackson.
3189
3190         * Configurations/FeatureDefines.xcconfig: Added ENABLE_CSS_SCROLL_SNAP
3191
3192 2014-08-06  Alexey Proskuryakov  <ap@apple.com>
3193
3194         REGRESSION (WebKit2): iOS Safari default encoding doesn't follow system language
3195         https://bugs.webkit.org/show_bug.cgi?id=135667
3196         <rdar://problem/17862892>
3197
3198         Reviewed by Anders Carlsson.
3199
3200         * WebView/WebPreferences.mm: (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]):
3201         Moved implementation to WebCore, so that it can be shared with WebKit2.
3202
3203         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
3204         We now use WKGetWebDefaultCFStringEncoding in WebCore, so it needs to be initialized.
3205
3206 2014-08-05  Peyton Randolph  <prandolph@apple.com>
3207
3208         Rename MAC_LONG_PRESS feature flag to LONG_MOUSE_PRESS.
3209         https://bugs.webkit.org/show_bug.cgi?id=135276
3210
3211         Reviewed by Beth Dakin.
3212
3213         * Configurations/FeatureDefines.xcconfig:
3214
3215 2014-08-04  Benjamin Poulain  <benjamin@webkit.org>
3216
3217         Add a flag for the CSS Selectors level 4 implementation
3218         https://bugs.webkit.org/show_bug.cgi?id=135535
3219
3220         Reviewed by Andreas Kling.
3221
3222         * Configurations/FeatureDefines.xcconfig:
3223
3224 2014-08-04  Benjamin Poulain  <bpoulain@apple.com>
3225
3226         Check for null frame when processing geolocation authorization request
3227         https://bugs.webkit.org/show_bug.cgi?id=135577
3228         <rdar://problem/17896295>
3229
3230         Reviewed by Geoffrey Garen.
3231
3232         * WebCoreSupport/WebGeolocationClient.mm:
3233         (WebGeolocationClient::requestPermission):
3234
3235 2014-08-02  Jeremy Jones  <jeremyj@apple.com>
3236
3237         Support both window and view based video fullscreen.
3238         https://bugs.webkit.org/show_bug.cgi?id=135525
3239
3240         Reviewed by Simon Fraser.
3241
3242         Parenting in the view instead of the window gives the fullscreen implementation more latitude 
3243         in how it implements the animation.
3244
3245         * WebView/WebView.mm:
3246         (-[WebView _enterFullscreenForNode:]): Use view instead of window.
3247
3248 2014-08-01  Dan Bernstein  <mitz@apple.com>
3249
3250         <rdar://problem/17891752> [iOS] WebKit links against libraries it doesn’t use
3251         https://bugs.webkit.org/show_bug.cgi?id=135536
3252
3253         Reviewed by Tim Horton.
3254
3255         * Configurations/WebKitLegacy.xcconfig: Removed -framework MobileAsset from
3256         OTHER_LDFLAGS_iphoneos.
3257
3258 2014-07-30  Andy Estes  <aestes@apple.com>
3259
3260         USE(CONTENT_FILTERING) should be ENABLE(CONTENT_FILTERING)
3261         https://bugs.webkit.org/show_bug.cgi?id=135439
3262
3263         Reviewed by Tim Horton.
3264
3265         We now support two different platform content filters, and will soon support a mock content filter (as part of
3266         webkit.org/b/128858). This makes content filtering a feature of WebKit, not just an adoption of a third-party
3267         library. ENABLE() is the correct macro to use for such a feature.
3268
3269         * Configurations/FeatureDefines.xcconfig:
3270
3271 2014-07-30  Andreas Kling  <akling@apple.com>
3272
3273         Static hash tables no longer need to be coupled with a VM.
3274         <https://webkit.org/b/135421>
3275
3276         Reviewed by Geoffrey Garen.
3277
3278         * Plugins/Hosted/ProxyInstance.mm:
3279         * Plugins/Hosted/ProxyRuntimeObject.mm:
3280
3281 2014-07-30  Dan Bernstein  <mitz@apple.com>
3282
3283         Updated for changes to the WebCore::Credential API.
3284         Work towards fixing https://bugs.webkit.org/show_bug.cgi?id=135327
3285
3286         Reviewed by Alexey Proskuryakov.
3287
3288         * Misc/WebDownload.mm:
3289         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): Use new nsCredential
3290         getter.
3291         * Plugins/WebBaseNetscapePluginView.mm:
3292         (WebKit::getAuthenticationInfo): Ditto.
3293
3294 2014-07-27  Pratik Solanki  <psolanki@apple.com>
3295
3296         Remove unused preference keys
3297         https://bugs.webkit.org/show_bug.cgi?id=135280
3298
3299         Reviewed by Darin Adler.
3300
3301         * WebView/WebPreferenceKeysPrivate.h:
3302         * WebView/WebPreferences.mm:
3303         (+[WebPreferences initialize]):
3304         (-[WebPreferences _setPageCacheSize:]): Deleted.
3305         (-[WebPreferences _pageCacheSize]): Deleted.
3306         (-[WebPreferences _setObjectCacheSize:]): Deleted.
3307         (-[WebPreferences _objectCacheSize]): Deleted.
3308         * WebView/WebPreferencesPrivate.h:
3309
3310 2014-07-27  Filip Pizlo  <fpizlo@apple.com>
3311
3312         Merge r170090, r170092, r170129, r170141, r170161, r170215, r170275, r170375, r170376, r170382, r170383, r170399, r170436, r170489, r170490, r170556 from ftlopt.
3313
3314     2014-07-25  Mark Lam  <mark.lam@apple.com>
3315     
3316             [ftlopt] Renamed DebuggerActivation to DebuggerScope.
3317             <https://webkit.org/b/134273>
3318     
3319             Reviewed by Michael Saboff.
3320     
3321             * WebView/WebScriptDebugDelegate.mm:
3322             - Removed unneeded #include.
3323     
3324 2014-07-26  Filip Pizlo  <fpizlo@apple.com>
3325
3326         Unreviewed, roll out r171641-r171644. It broke some tests; will investigate and
3327         reland later.
3328
3329         * WebView/WebScriptDebugDelegate.mm:
3330
3331 2014-07-25  Filip Pizlo  <fpizlo@apple.com>
3332
3333         Merge r170090, r170092, r170129, r170141, r170161, r170215, r170275, r170375, r170376, r170382, r170383, r170399, r170436, r170489, r170490, r170556 from ftlopt.
3334
3335     2014-07-25  Mark Lam  <mark.lam@apple.com>
3336     
3337             [ftlopt] Renamed DebuggerActivation to DebuggerScope.
3338             <https://webkit.org/b/134273>
3339     
3340             Reviewed by Michael Saboff.
3341     
3342             * WebView/WebScriptDebugDelegate.mm:
3343             - Removed unneeded #include.
3344     
3345 2014-07-25  Jeremy Jones  <jeremyj@apple.com>
3346
3347         Parent fullscreen from window instead of view
3348         https://bugs.webkit.org/show_bug.cgi?id=135310
3349
3350         Reviewed by Jer Noble.
3351
3352         Parenting in the view causes an incorrect animation to fullscreen, and can cause 
3353         fullscreen to only expand to the size of the view instead of the whole window.
3354
3355         * WebView/WebView.mm:
3356         (-[WebView _enterFullscreenForNode:]): Pass window instead of view.
3357
3358 2014-07-24  Pratik Solanki  <psolanki@apple.com>
3359
3360         [iOS] Remove prefs to tweak cache values
3361         https://bugs.webkit.org/show_bug.cgi?id=135274
3362         <rdar://problem/17784826>
3363
3364         Reviewed by Alexey Proskuryakov.
3365
3366         Remove iOS specific code that used to look up user defaults to see if any cache values were
3367         overridden. This was added for testing, is not used any more and is actually harmful now. It
3368         can cause unnecessary memory churn when under memory pressure since we call [WebView _setCacheModel]
3369         as a means to clear out memory cache.
3370
3371         * WebView/WebPreferenceKeysPrivate.h:
3372         * WebView/WebPreferences.mm:
3373         (+[WebPreferences initialize]):
3374         (-[WebPreferences _setNSURLMemoryCacheSize:]): Deleted.
3375         (-[WebPreferences _NSURLMemoryCacheSize]): Deleted.
3376         (-[WebPreferences _setNSURLDiskCacheSize:]): Deleted.
3377         (-[WebPreferences _NSURLDiskCacheSize]): Deleted.
3378         * WebView/WebPreferencesPrivate.h:
3379         * WebView/WebView.mm:
3380         (+[WebView _setCacheModel:]):
3381
3382 2014-07-24  Peyton Randolph  <prandolph@apple.com>
3383
3384         Rename feature flag for long-press gesture on Mac.                                                                   
3385         https://bugs.webkit.org/show_bug.cgi?id=135259                                                                 
3386
3387         Reviewed by Beth Dakin.
3388
3389         * Configurations/FeatureDefines.xcconfig:
3390         Rename LINK_LONG_PRESS to MAC_LONG_PRESS.
3391
3392 2014-07-24  Dan Bernstein  <mitz@apple.com>
3393
3394         WebKit part of <rdar://problem/17766348> [Cocoa] WebCore::ProtectionSpace doesn’t preserve all NSURLProtectionSpace properties, such as the distinguishedNames array
3395         https://bugs.webkit.org/show_bug.cgi?id=135229
3396
3397         Reviewed by Alexey Proskuryakov.
3398
3399         * Misc/WebDownload.mm:
3400         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): Chanegd to use the
3401         ProtectionSpace constructor that takes an NSURLProtectionSpace.
3402
3403         * Plugins/WebBaseNetscapePluginView.mm:
3404         (WebKit::getAuthenticationInfo): Ditto.
3405
3406         * WebCoreSupport/WebFrameLoaderClient.mm:
3407         (WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace): Changed to use
3408         ProtectionSpace::nsSpace.
3409
3410 2014-07-23  Bem Jones-Bey  <bjonesbe@adobe.com>
3411
3412         Remove CSS_EXCLUSIONS compile flag and leftover code
3413         https://bugs.webkit.org/show_bug.cgi?id=135175
3414
3415         Reviewed by Zoltan Horvath.
3416
3417         At this point, the CSS_EXCLUSIONS flag guards nothing but some useless
3418         stubs. This removes the flag and the useless code.
3419
3420         * Configurations/FeatureDefines.xcconfig:
3421
3422 2014-07-22  Enrica Casucci  <enrica@apple.com>
3423
3424         REGRESSION (WebKit2): Selection inside accelerated overflow:scroll doesn't track scrolling.
3425         https://bugs.webkit.org/show_bug.cgi?id=135180
3426         <rdar://problem/16721055>
3427
3428         Reviewed by Simon Fraser.
3429
3430         * WebCoreSupport/WebEditorClient.h:
3431
3432 2014-07-22  Jeremy Jones  <jeremyj@apple.com>
3433
3434         Don't create new UIWindow for video fullscreen.
3435         https://bugs.webkit.org/show_bug.cgi?id=135038
3436
3437         Reviewed by Darin Adler.
3438
3439         Provide UIView to WebVideoFullscreenController
3440
3441         * WebView/WebView.mm:
3442         (-[WebView _enterFullscreenForNode:]): pass UIView instead of nil
3443
3444 2014-07-21  Pratik Solanki  <psolanki@apple.com>
3445
3446         Unreviewed iOS build fix after r171321.
3447
3448         * WebView/WebView.mm:
3449         (-[WebView _preferencesChanged:]):
3450
3451 2014-07-21  Beth Dakin  <bdakin@apple.com>
3452
3453         WK1 should always setAcceleratedCompositingForFixedPositionEnabled(true) on 
3454         Yosemite
3455         https://bugs.webkit.org/show_bug.cgi?id=135135
3456
3457         Reviewed by Darin Adler.
3458
3459         Get rid of the ChromeClient function, and enable the Setting instead.
3460         * WebCoreSupport/WebChromeClient.h:
3461         * WebCoreSupport/WebChromeClient.mm:
3462         (WebChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition): Deleted.
3463         * WebView/WebView.mm:
3464         (-[WebView _preferencesChanged:]):
3465
3466 2014-07-21  Beth Dakin  <bdakin@apple.com>
3467
3468         Build fix.
3469
3470         * WebCoreSupport/WebChromeClient.mm:
3471         (WebChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition):
3472
3473 2014-07-21  Beth Dakin  <bdakin@apple.com>
3474
3475         Put position:fixed elements into layers when a WK1 view is layer-backed
3476         https://bugs.webkit.org/show_bug.cgi?id=135075
3477
3478         Reviewed by Darin Adler.
3479
3480         Returns true when the WebHTMLView has a layer.
3481
3482         * WebCoreSupport/WebChromeClient.h:
3483         * WebCoreSupport/WebChromeClient.mm:
3484         (WebChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition):
3485
3486 2014-07-18  Andy Estes  <aestes@apple.com>
3487
3488         [iOS] Tapping "Allow Website" on a restricted page does not bring up the keypad
3489         https://bugs.webkit.org/show_bug.cgi?id=135072
3490         <rdar://problem/17528188>
3491
3492         Reviewed by David Kilzer.
3493
3494         * WebCoreSupport/WebFrameLoaderClient.h: Override contentFilterDidBlockLoad().
3495         * WebCoreSupport/WebFrameLoaderClient.mm:
3496         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): Reset contentFilterForBlockedLoad to nullptr.
3497         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Check if this is navigation represents an
3498         unblock request and ignore if so.
3499         * WebView/WebFrame.mm:
3500         (-[WebFrame _contentFilterDidHandleNavigationAction:]): Called ContentFilter::handleUnblockRequestAndDispatchIfSuccessful().
3501         If the unblock is successful, reload the main frame.
3502         * WebView/WebFrameInternal.h:
3503
3504 2014-07-17  David Kilzer  <ddkilzer@apple.com>
3505
3506         SECTORDER_FLAGS should be defined in target's xcconfig file, not Base.xcconfig
3507         <http://webkit.org/b/135006>
3508
3509         Reviewed by Darin Adler.
3510
3511         * Configurations/Base.xcconfig: Move SECTORDER_FLAGS to
3512         WebKitLegacy.xcconfig.
3513         * Configurations/DebugRelease.xcconfig: Remove empty
3514         SECTORDER_FLAGS definition.
3515         * Configurations/WebKit.xcconfig: Removed.  Unused.
3516         * Configurations/WebKitLegacy.xcconfig: Use $(CONFIGURATION) so
3517         SECTORDER_FLAGS is only set on Production builds.
3518
3519 2014-07-17  Timothy Hatcher  <timothy@apple.com>
3520
3521         Make console.profile record to the Timeline.
3522
3523         https://bugs.webkit.org/show_bug.cgi?id=134643
3524
3525         Reviewed by Joseph Pecoraro.
3526
3527         * WebInspector/WebInspector.mm:
3528         (-[WebInspector isProfilingJavaScript]):
3529         (-[WebInspector toggleProfilingJavaScript:]):
3530         (-[WebInspector startProfilingJavaScript:]):
3531         (-[WebInspector stopProfilingJavaScript:]):
3532         (-[WebInspector isJavaScriptProfilingEnabled]):
3533         (-[WebInspector setJavaScriptProfilingEnabled:]):
3534
3535 2014-07-16  David Kilzer  <ddkilzer@apple.com>
3536
3537         [iOS] Update order file paths for WebKit and WebKit2
3538         <http://webkit.org/b/134993>
3539         <rdar://problem/17557776>
3540
3541         Reviewed by Darin Adler.
3542
3543         * Configurations/Base.xcconfig: Rename WebKit.order to
3544         WebKitLegacy.order.
3545
3546 2014-07-16  Brady Eidson  <beidson@apple.com>
3547
3548         Add WebSecurityOrigin "webSecurityOriginFromDatabaseIdentifier" SPI and change _websiteDataURLForContainerWithURL: SPI
3549         <rdar://problem/17454712> and https://bugs.webkit.org/show_bug.cgi?id=134984
3550
3551         Reviewed by Dan Bernstein.
3552
3553         * WebCoreSupport/WebSecurityOrigin.mm:
3554         (+[WebSecurityOrigin webSecurityOriginFromDatabaseIdentifier:]): Added.
3555         (-[WebSecurityOrigin initWithURL:]): Update using RefPtr API to avoid a ref().
3556
3557 2014-07-15  Myles C. Maxfield  <mmaxfield@apple.com>
3558
3559         [OSX] [WK1] Crash when exiting fullscreen
3560         https://bugs.webkit.org/show_bug.cgi?id=134943
3561
3562         Reviewed by Dean Jackson.
3563
3564         AppKit doesn't remove a view from the Key View Loop when removing it from its superview.
3565
3566         This codepath is already "tested" in fullscreen/full-screen-cancel.html, but because of our
3567         testing infrastructure, the broken codepath doesn't actually get hit in DRT. Therefore,
3568         there is no test.
3569
3570         * WebView/WebFullScreenController.mm:
3571         (-[WebFullScreenController enterFullScreen:]):
3572
3573         * WebCoreSupport/WebSecurityOriginPrivate.h:
3574
3575 2014-07-14  Bear Travis  <betravis@adobe.com>
3576
3577         [Feature Queries] Enable Feature Queries on Mac
3578         https://bugs.webkit.org/show_bug.cgi?id=134404
3579
3580         Reviewed by Antti Koivisto.
3581
3582         Enable Feature Queries on Mac and resume running the
3583         feature tests.
3584
3585         * Configurations/FeatureDefines.xcconfig: Turn on
3586         ENABLE_CSS3_CONDITIONAL_RULES.
3587
3588 2014-07-11  Zalan Bujtas  <zalan@apple.com>
3589
3590         Subpixel layout: return integral results for offset*, client*, scroll* by default.
3591         https://bugs.webkit.org/show_bug.cgi?id=134651
3592
3593         Reviewed by Simon Fraser.
3594
3595         Revert to returning integral values for Element.offset* client* scroll* by default.
3596         Fractional values break number of sites(tight design) and JS frameworks(fail to handle fractional values).
3597
3598         Since snapped dimension depends on both the original point and the width/height of the box,
3599         we need to call RenderBoxModelObject::pixelSnapped*() helpers, instead of round().
3600
3601         Covered by existing tests
3602
3603         * WebView/WebPreferences.mm:
3604         (+[WebPreferences initialize]):
3605
3606 2014-07-10  Joseph Pecoraro  <pecoraro@apple.com>
3607
3608         [Mac] NSWindow warning: adding an unknown subview opening detached Inspector
3609         https://bugs.webkit.org/show_bug.cgi?id=134813
3610
3611         Reviewed by Timothy Hatcher.
3612
3613         * WebCoreSupport/WebInspectorClient.mm:
3614         (-[WebInspectorWindowController window]):
3615         Use a selector that will avoid the warning message.
3616
3617 2014-07-09  Ryosuke Niwa  <rniwa@webkit.org>
3618
3619         REGRESSION(r167770): Cannot login in Evernote Safari extension
3620         https://bugs.webkit.org/show_bug.cgi?id=134776
3621
3622         Reviewed by Enrica Casucci.
3623
3624         Unfortunately, NSWindowDidBecomeKeyNotification does not notify us when a popover becomes key
3625         so we need to keep using the SPI (_windowChangedKeyState) I removed in r167770.
3626
3627         * WebView/WebView.mm:
3628         (-[WebView _windowChangedKeyState]):
3629
3630 2014-07-09  Enrica Casucci  <enrica@apple.com>
3631
3632         Implement Editor::fontAttributesForSelectionStart() or iOS.
3633         https://bugs.webkit.org/show_bug.cgi?id=134771
3634         <rdar://problem/16167838>
3635
3636         Reviewed by Ryosuke Niwa.
3637
3638         * WebView/WebViewPrivate.h:
3639
3640 2014-07-08  Tim Horton  <timothy_horton@apple.com>
3641
3642         [WK2] Expose a few drawing/compositing settings on WKPreferences(Private)
3643         https://bugs.webkit.org/show_bug.cgi?id=134645
3644
3645         Reviewed by Dan Bernstein.
3646
3647         * WebView/WebPreferences.mm:
3648         (-[WebPreferences setSubpixelCSSOMElementMetricsEnabled:]):
3649         Remove an extra unnecessary space.
3650
3651 2014-07-03  Daniel Bates  <dabates@apple.com>
3652
3653         Add WTF::move()
3654         https://bugs.webkit.org/show_bug.cgi?id=134500
3655
3656         Rubber-stamped by Anders Carlsson.
3657
3658         Substitute WTF::move() for std::move().
3659
3660         * History/WebHistoryItem.mm:
3661         (-[WebHistoryItem initFromDictionaryRepresentation:]):
3662         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3663         (WebKit::NetscapePluginInstanceProxy::setCurrentReply):
3664         * Plugins/WebNetscapePluginView.mm:
3665         (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
3666         * WebCoreSupport/WebFrameLoaderClient.mm:
3667         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3668         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3669         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3670         (WebFrameLoaderClient::dispatchWillSubmitForm):
3671         * WebCoreSupport/WebInspectorClient.mm:
3672         (WebInspectorClient::openInspectorFrontend):
3673         (WebInspectorFrontendClient::WebInspectorFrontendClient):
3674         * WebView/WebArchive.mm:
3675         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
3676
3677 2014-07-01  Mark Rowe  <mrowe@apple.com>
3678
3679         <https://webkit.org/b/134522> Remove duplication in code that prepares the user agent string on Mac and iOS
3680
3681         Reviewed by Simon Fraser.
3682
3683         * WebView/WebView.mm:
3684         (webKitBundleVersionString): Return the entire CFBundleVersion now that WebCore handles formatting it.
3685         (+[WebView _standardUserAgentWithApplicationName:]):
3686
3687 2014-07-02  Dan Bernstein  <mitz@apple.com>
3688
3689         Remove some code only needed for versions of Safari that are no longer supported
3690         https://bugs.webkit.org/show_bug.cgi?id=134537
3691
3692         Reviewed by Anders Carlsson.
3693
3694         * History/WebHistoryItem.mm:
3695         * Misc/WebKitVersionChecks.h:
3696         * WebCoreSupport/WebSecurityOrigin.mm:
3697         (-[WebSecurityOrigin domain]): Deleted.
3698         * WebInspector/WebInspector.mm:
3699         (-[WebInspector showTimeline:]): Deleted.
3700         (+[WebInspector webInspector]): Deleted.
3701         (-[WebInspector setWebFrame:]): Deleted.
3702         (-[WebInspector window]): Deleted.
3703         (-[WebInspector showWindow:]): Deleted.
3704         * WebView/WebFrame.mm:
3705         (-[WebFrame reload]):
3706         * WebView/WebPDFView.mm:
3707         (-[WebPDFView menuForEvent:]):
3708         (-[WebPDFView _anyPDFTagsFoundInMenu:]): Deleted.
3709         * WebView/WebView.mm:
3710         (-[WebView _initWithFrame:frameName:groupName:]):
3711         (-[WebView _preferencesChanged:]):
3712         (-[WebView initWithFrame:frameName:groupName:]):
3713         (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]): Deleted.
3714         (+[WebView _setAlwaysUseATSU:]): Deleted.
3715         (-[WebView _needsUnrestrictedGetMatchedCSSRules]): Deleted.
3716         * WebView/WebViewPrivate.h:
3717
3718 2014-07-01  Dan Bernstein  <mitz@apple.com>
3719
3720         Remove WebChromeClient code that was only needed for Safari versions earlier than 3.1
3721         https://bugs.webkit.org/show_bug.cgi?id=134531
3722
3723         Reviewed by Daniel Bates.
3724
3725         * WebCoreSupport/WebChromeClient.mm:
3726         (WebChromeClient::exceededDatabaseQuota):
3727
3728 2014-06-29  Yoav Weiss  <yoav@yoav.ws>
3729
3730         Add support for HTMLImageElement's sizes attribute
3731         https://bugs.webkit.org/show_bug.cgi?id=133620
3732
3733         Reviewed by Dean Jackson.
3734
3735         Added an ENABLE_PICTURE_SIZES compile flag.
3736
3737         * Configurations/FeatureDefines.xcconfig:
3738
3739 2014-06-27  Sam Weinig  <sam@webkit.org>
3740
3741         InfoClick (from Nisus Software) dies on viewing found items
3742         <rdar://problem/17395601>
3743         https://bugs.webkit.org/show_bug.cgi?id=134410
3744
3745         Reviewed by Andy Estes.
3746
3747         InfoClick was calling -[WebPreferences setPrivateBrowsingEnabled:] before
3748         setting up a WebView (or anything else that would have set up WebKitSystemInterface),
3749         which now requires a set up WebKitSystemInterface. We can fix this by initializing
3750         it from +[WebPreferences initialize].
3751
3752         * WebView/WebPreferences.mm:
3753         (+[WebPreferences initialize]):
3754         Add call to InitWebCoreSystemInterface().
3755
3756         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
3757         Remove now unnecessary call to InitWebCoreSystemInterface().
3758
3759 2014-06-27  Peyton Randolph  <prandolph@apple.com>
3760
3761         Add feature flag for link long-press gesture.
3762         https://bugs.webkit.org/show_bug.cgi?id=134262
3763
3764         Reviewed by Enrica Casucci.
3765
3766         * Configurations/FeatureDefines.xcconfig:
3767         Add ENABLE_LINK_LONG_PRESS.
3768
3769 2014-06-26  Brady Eidson  <beidson@apple.com>
3770
3771         Remove use of PlatformStrategies for Gamepad API.
3772         https://bugs.webkit.org/show_bug.cgi?id=134348
3773
3774         Reviewed by Dean Jackson.
3775
3776         Remove all the GamepadStrategy gunk:
3777         * WebCoreSupport/WebHIDGamepadController.mm: Removed.
3778         * WebCoreSupport/WebPlatformStrategies.h:
3779         * WebCoreSupport/WebPlatformStrategies.mm:
3780         (WebPlatformStrategies::createGamepadStrategy): Deleted.
3781         (WebPlatformStrategies::startMonitoringGamepads): Deleted.
3782         (WebPlatformStrategies::stopMonitoringGamepads): Deleted.
3783         (WebPlatformStrategies::platformGamepads): Deleted.
3784
3785         Instead, install the HIDGamepadProvider as the shared GamepadProvider:
3786         * WebView/WebView.mm:
3787         (WebKitInitializeGamepadProviderIfNecessary):
3788         (-[WebView _commonInitializationWithFrameName:groupName:]):
3789
3790 2014-06-26  Joseph Pecoraro  <pecoraro@apple.com>
3791
3792         [iOS] Remove User Default for iOS TextField Debugging
3793         https://bugs.webkit.org/show_bug.cgi?id=134356
3794
3795         Reviewed by Timothy Hatcher.
3796
3797         * WebView/WebPreferenceKeysPrivate.h:
3798         * WebView/WebView.mm:
3799         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3800
3801 2014-06-25  Brady Eidson  <beidson@apple.com>
3802
3803         Add HID-based gamepad implementation for Mac
3804         https://bugs.webkit.org/show_bug.cgi?id=134324
3805
3806         Reviewed by Dean Jackson.
3807
3808         Add a class that acts as an intermediary between the GamepadStrategyClient
3809         and the HIDGamepadListener:
3810         * WebCoreSupport/WebHIDGamepadController.h:
3811         * WebCoreSupport/WebHIDGamepadController.mm:
3812         (WebHIDGamepadController::shared):
3813         (WebHIDGamepadController::WebHIDGamepadController):
3814         (WebHIDGamepadController::gamepadConnected):
3815         (WebHIDGamepadController::gamepadDisconnected):
3816         (WebHIDGamepadController::registerGamepadStrategyClient):
3817         (WebHIDGamepadController::unregisterGamepadStrategyClient):
3818
3819         Implement the strategies by using the HIDGamepadListener:
3820         * WebCoreSupport/WebPlatformStrategies.mm:
3821         (WebPlatformStrategies::startMonitoringGamepads):
3822         (WebPlatformStrategies::stopMonitoringGamepads):
3823         (WebPlatformStrategies::platformGamepads):
3824
3825 2014-06-25  Brady Eidson  <beidson@apple.com>
3826
3827         Add new platform gamepad abstractions
3828         https://bugs.webkit.org/show_bug.cgi?id=134325
3829
3830         Reviewed by Dean Jackson.
3831
3832         * WebCoreSupport/WebPlatformStrategies.h:
3833         * WebCoreSupport/WebPlatformStrategies.mm:
3834         (WebPlatformStrategies::createGamepadStrategy):
3835         (WebPlatformStrategies::startMonitoringGamepads):
3836         (WebPlatformStrategies::stopMonitoringGamepads):
3837         (WebPlatformStrategies::platformGamepads):
3838
3839 2014-06-25  Gavin Barraclough  <baraclough@apple.com>
3840
3841         Should _updateVisibilityState on view hide/unhide.
3842         https://bugs.webkit.org/show_bug.cgi?id=134314
3843         rdar://17171803
3844
3845         Reviewed by Sam Weinig.
3846
3847         * WebView/WebView.mm:
3848         (-[WebView viewDidHide]):
3849         (-[WebView viewDidUnhide]):
3850
3851 2014-06-25  Chris Fleizach  <cfleizach@apple.com>
3852
3853         Add an undo group for each dictated utterance in WebKit
3854         https://bugs.webkit.org/show_bug.cgi?id=134086
3855
3856         Reviewed by Enrica Casucci.
3857
3858         * WebView/WebHTMLView.mm:
3859         (-[WebHTMLView validAttributesForMarkedText]):
3860         (-[WebHTMLView insertText:]):
3861
3862 2014-06-25  Dana Burkart  <dburkart@apple.com>
3863
3864         Add support for 5-tuple versioning.
3865
3866         Reviewed by David Farler.
3867
3868         * Configurations/Version.xcconfig:
3869
3870 2014-06-25  Laszlo Gombos  <l.gombos@samsung.com>
3871
3872         Remove build guard for progress element
3873         https://bugs.webkit.org/show_bug.cgi?id=134292
3874
3875         Reviewed by Benjamin Poulain.
3876
3877         * Configurations/FeatureDefines.xcconfig:
3878
3879 2014-06-24  Benjamin Poulain  <bpoulain@apple.com>
3880
3881         WK1 WebFrameNetworkingContext cleanup: do not instanciate an empty NSString to create an empty WTF::String
3882         https://bugs.webkit.org/show_bug.cgi?id=134222
3883
3884         Reviewed by Andreas Kling.
3885
3886         * WebCoreSupport/WebFrameNetworkingContext.mm:
3887         (WebFrameNetworkingContext::sourceApplicationIdentifier):
3888
3889 2014-06-24  Joseph Pecoraro  <pecoraro@apple.com>
3890
3891         [iOS]: WK2 Inspector Node Highlighting
3892         https://bugs.webkit.org/show_bug.cgi?id=134257
3893
3894         Reviewed by Timothy Hatcher.
3895
3896         * WebInspector/WebNodeHighlightView.mm:
3897         (-[WebNodeHighlightView layoutSublayers:]):
3898
3899 2014-06-24  Brady Eidson  <beidson@apple.com>
3900
3901         Enable GAMEPAD in the Mac build, but disabled at runtime.
3902         https://bugs.webkit.org/show_bug.cgi?id=134255
3903
3904         Reviewed by Dean Jackson.
3905
3906         * Configurations/FeatureDefines.xcconfig:
3907
3908         * WebView/WebPreferenceKeysPrivate.h:
3909         * WebView/WebPreferences.mm:
3910         (-[WebPreferences gamepadsEnabled]):
3911         (-[WebPreferences setGamepadsEnabled:]):
3912         * WebView/WebPreferencesPrivate.h:
3913
3914         * WebView/WebView.mm:
3915         (-[WebView _preferencesChanged:]):
3916
3917 2014-06-24  Dan Bernstein  <mitz@apple.com>
3918
3919         Fixed the iOS build after r170358.
3920
3921         * WebView/WebView.mm:
3922         (kit):
3923
3924 2014-06-23  Anders Carlsson  <andersca@apple.com>
3925
3926         Remove unused history visit code from WebHistoryItem
3927         https://bugs.webkit.org/show_bug.cgi?id=134201
3928
3929         Reviewed by Sam Weinig.
3930
3931         * History/HistoryPropertyList.h:
3932         * History/HistoryPropertyList.mm:
3933         (HistoryPropertyListWriter::HistoryPropertyListWriter):
3934         (HistoryPropertyListWriter::writeHistoryItem):
3935         * History/WebHistory.mm:
3936         (-[WebHistoryPrivate visitedURL:withTitle:]):
3937         (-[WebHistoryPrivate addItem:discardDuplicate:]):
3938         (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
3939         (-[WebHistoryPrivate visitedURL:withTitle:increaseVisitCount:]): Deleted.
3940         (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]): Deleted.
3941         * History/WebHistoryInternal.h:
3942         * History/WebHistoryItem.mm:
3943         (-[WebHistoryItem copyWithZone:]):
3944         (-[WebHistoryItem initFromDictionaryRepresentation:]):
3945         (-[WebHistoryItem _visitedWithTitle:]):
3946         (-[WebHistoryItem setVisitCount:]): Deleted.
3947         (-[WebHistoryItem _mergeAutoCompleteHints:]): Deleted.
3948         (-[WebHistoryItem _visitedWithTitle:increaseVisitCount:]): Deleted.
3949         (-[WebHistoryItem _recordInitialVisit]): Deleted.
3950         (timeToDay): Deleted.
3951         (-[WebHistoryItem _padDailyCountsForNewVisit:]): Deleted.
3952         (-[WebHistoryItem _collapseDailyVisitsToWeekly]): Deleted.
3953         (-[WebHistoryItem _recordVisitAtTime:increaseVisitCount:]): Deleted.
3954         (-[WebHistoryItem _setLastVisitedTimeInterval:]): Deleted.
3955         * History/WebHistoryItemInternal.h:
3956         * History/WebHistoryItemPrivate.h:
3957         * WebCoreSupport/WebFrameLoaderClient.mm:
3958         (WebFrameLoaderClient::updateGlobalHistory):
3959
3960 2014-06-24  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3961
3962         REGRESSION(r170235): Remove incorrect ifdef guard
3963         https://bugs.webkit.org/show_bug.cgi?id=134246
3964
3965         Reviewed by Csaba Osztrogonác.
3966
3967         * WebView/WebView.mm:
3968         (-[WebView _visibilityState]):
3969
3970 2014-06-23  Anders Carlsson  <andersca@apple.com>
3971
3972         Fix build.
3973
3974         * WebCoreSupport/WebSystemInterface.mm:
3975         (InitWebCoreSystemInterface):
3976
3977 2014-06-21  Dan Bernstein  <mitz@apple.com>
3978
3979         Tried to fix the iOS build after r170235.
3980
3981         * WebView/WebView.mm:
3982
3983 2014-06-21  Brady Eidson  <beidson@apple.com>
3984
3985         Gamepad API - Deprecate the existing implementation
3986         https://bugs.webkit.org/show_bug.cgi?id=134108
3987
3988         Reviewed by Timothy Hatcher.
3989
3990         -Add new "GAMEPAD_DEPRECATED" build flag, moving the existing implementation to use it
3991         -Move some implementation files into a "deprecated" subdirectory.
3992
3993         * Configurations/FeatureDefines.xcconfig:
3994
3995 2014-06-21  Commit Queue  <commit-queue@webkit.org>
3996
3997         Unreviewed, rolling out r170244.
3998         https://bugs.webkit.org/show_bug.cgi?id=134157
3999
4000         GTK/EFL bindings generator works differently, making this
4001         patch not work there.  Will fix entire patch after a rollout.
4002         (Requested by bradee-oh on #webkit).
4003
4004         Reverted changeset:
4005
4006         "Gamepad API - Deprecate the existing implementation"
4007         https://bugs.webkit.org/show_bug.cgi?id=134108
4008         http://trac.webkit.org/changeset/170244
4009
4010 2014-06-21  Brady Eidson  <beidson@apple.com>
4011
4012         Gamepad API - Deprecate the existing implementation
4013         https://bugs.webkit.org/show_bug.cgi?id=134108
4014
4015         Reviewed by Timothy Hatcher.
4016
4017         -Add new "GAMEPAD_DEPRECATED" build flag, moving the existing implementation to use it
4018         -Add the "Deprecated" suffix to some implementation files
4019
4020         * Configurations/FeatureDefines.xcconfig:
4021
4022 2014-06-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4023
4024         Removing PAGE_VISIBILITY_API compile guard.
4025         https://bugs.webkit.org/show_bug.cgi?id=133844
4026
4027         Reviewed by Gavin Barraclough.
4028
4029         * Configurations/FeatureDefines.xcconfig:
4030         * WebView/WebView.mm:
4031         (-[WebView _preferencesChanged:]):
4032         (-[WebView _visibilityState]):
4033
4034 2014-06-18  Anders Carlsson  <andersca@apple.com>
4035
4036         Make FrameLoadType a strongly typed enum
4037         https://bugs.webkit.org/show_bug.cgi?id=134047
4038
4039         Reviewed by Andreas Kling.
4040
4041         * WebView/WebFrame.mm:
4042         (toWebFrameLoadType):
4043         (-[WebFrame _loadType]):
4044         * WebView/WebView.mm:
4045         (-[WebView _loadBackForwardListFromOtherView:]):
4046         (-[WebView goToBackForwardItem:]):
4047
4048 2014-06-18  Daniel Bates  <dabates@apple.com>
4049
4050         REGRESSION (r167856): Unable to log into HSBC app
4051         https://bugs.webkit.org/show_bug.cgi?id=133991
4052         <rdar://problem/17044839>
4053
4054         Reviewed by David Kilzer.
4055
4056         Only enable the setting allowNavigationToInvalidURL for iOS app linked against WebKit/UIKit before iOS 8.
4057
4058         * Misc/WebKitVersionChecks.h: Added macro constant WEBKIT_FIRST_VERSION_WITH_NAVIGATION_URL_VALIDATION.
4059         * WebView/WebView.mm:
4060         (-[WebView _preferencesChanged:]): Enable or disable the setting allowNavigationToInvalidURL as appropriate.
4061
4062 2014-06-18  Anders Carlsson  <andersca@apple.com>
4063
4064         Adopt modern C++11 loops and fix WebArchive creation functions
4065         https://bugs.webkit.org/show_bug.cgi?id=134032
4066
4067         Reviewed by Andreas Kling.
4068
4069         * WebView/WebArchive.mm:
4070         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
4071         * WebView/WebDataSource.mm:
4072         (-[WebDataSource subresources]):
4073
4074 2014-06-15  Anders Carlsson  <andersca@apple.com>
4075
4076         Add an autorelease() member function to RetainPtr
4077         https://bugs.webkit.org/show_bug.cgi?id=133929
4078
4079         Reviewed by Dan Bernstein.
4080
4081         * WebView/WebDataSource.mm:
4082         (-[WebDataSource data]):
4083         * WebView/WebHTMLView.mm:
4084         (-[WebHTMLView _selectionDraggingImage]):
4085         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
4086         * WebView/WebResource.mm:
4087         (-[WebResource data]):
4088
4089 2014-06-11  Jeremy Jones  <jeremyj@apple.com>
4090
4091         WebFrameNetworkContext should not have a sourceApplicationIdentifier in WK1.
4092         https://bugs.webkit.org/show_bug.cgi?id=133772
4093
4094         Reviewed by Jer Noble.
4095
4096         Return empty string from sourceApplicationIdentifier for WK1.
4097
4098         * WebCoreSupport/WebFrameNetworkingContext.mm:
4099         (WebFrameNetworkingContext::sourceApplicationIdentifier):
4100
4101 2014-06-10  Timothy Horton  <timothy_horton@apple.com>
4102
4103         Factor repeated CFRunLoopObserver code out
4104         https://bugs.webkit.org/show_bug.cgi?id=133690
4105
4106         Reviewed by Simon Fraser.
4107
4108         * WebView/WebViewData.h:
4109
4110 2014-06-05  Pratik Solanki  <psolanki@apple.com>
4111
4112         Remove unsused method _setAcceleratedImageDecoding
4113         https://bugs.webkit.org/show_bug.cgi?id=133554
4114
4115         Reviewed by Jon Honeycutt.
4116
4117         * WebView/WebView.mm:
4118         (+[WebView _setAcceleratedImageDecoding:]): Deleted.
4119         * WebView/WebViewPrivate.h:
4120
4121 2014-06-05  Benjamin Poulain  <bpoulain@apple.com>
4122
4123         [iOS][WK2] Add device orientation
4124         https://bugs.webkit.org/show_bug.cgi?id=133530
4125
4126         Reviewed by Tim Horton.
4127
4128         * WebView/WebFrame.mm:
4129         (-[WebFrame deviceOrientationChanged]):
4130         (-[WebFrame sendOrientationChangeEvent:]):
4131         * WebView/WebFramePrivate.h:
4132
4133 2014-05-31  Anders Carlsson  <andersca@apple.com>
4134
4135         Change DeferrableOneShotTimer to use std::function instead of being a class template
4136         https://bugs.webkit.org/show_bug.cgi?id=133423
4137
4138         Reviewed by Antti Koivisto.
4139
4140         * WebView/WebView.mm:
4141         (+[WebView _setCacheModel:]):
4142
4143 2014-05-27  Jon Lee  <jonlee@apple.com>
4144
4145         Update ENABLE(MEDIA_SOURCE) on Mac
4146         https://bugs.webkit.org/show_bug.cgi?id=133141
4147
4148         Reviewed by Darin Adler.
4149
4150         * Configurations/FeatureDefines.xcconfig:
4151
4152 2014-05-27  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
4153
4154         Remove BLOB guards
4155         https://bugs.webkit.org/show_bug.cgi?id=132863
4156
4157         Reviewed by Csaba Osztrogonác.
4158
4159         * Configurations/FeatureDefines.xcconfig:
4160         * WebView/WebView.mm:
4161         (+[WebView _canHandleRequest:forMainFrame:]):
4162
4163 2014-05-24  Chris Fleizach  <cfleizach@apple.com>
4164
4165         AX: fix coordinate mapping for iOS accessibility
4166         https://bugs.webkit.org/show_bug.cgi?id=133188
4167
4168         Reviewed by Sam Weinig.
4169
4170         * WebCoreSupport/WebChromeClient.h:
4171         * WebCoreSupport/WebChromeClient.mm:
4172         (WebChromeClient::accessibilityScreenToRootView):
4173         (WebChromeClient::rootViewToAccessibilityScreen):
4174
4175 2014-05-23  Jeremy Jones  <jeremyj@apple.com>
4176
4177         Hide fullscreen immediately when switching tabs.
4178         https://bugs.webkit.org/show_bug.cgi?id=133239
4179
4180         Reviewed by Eric Carlson.
4181
4182         Renamed a function to better describe it's new functionality.
4183
4184         * WebView/WebView.mm:
4185         (-[WebView viewDidMoveToWindow]):
4186         now calls: requestHideAndExitFullscreen
4187
4188 2014-05-20  Dean Jackson  <dino@apple.com>
4189
4190         [Mac] Allow popup menus to override default appearance
4191         https://bugs.webkit.org/show_bug.cgi?id=133129
4192
4193         Reviewed by Tim Horton.
4194
4195         Replace the call to wkPopupMenuWithSize with wkPopupMenu, now
4196         with extra parameters to indicate the control size and whether
4197         or not to draw the arrows at the end.
4198
4199         * WebCoreSupport/PopupMenuMac.mm:
4200         (PopupMenuMac::show):
4201
4202 2014-05-20  Eric Carlson  <eric.carlson@apple.com>
4203
4204         [Mac] do not deactivate an audio session that has running I/O
4205         https://bugs.webkit.org/show_bug.cgi?id=133127
4206
4207         Reviewed by Jer Noble.
4208
4209         * WebView/WebView.mm:
4210         (-[WebView _commonInitializationWithFrameName:groupName:]): Settings::setShouldManageAudioSession
4211             renamed to setShouldManageAudioSessionCategory, deal with it.
4212
4213 2014-05-19  Brady Eidson  <beidson@apple.com>