Add +[WebView _allowsRoundingHacks]
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2011-06-30  Dan Bernstein  <mitz@apple.com>
2
3         Reviewed by Adele Peterson.
4
5         Add +[WebView _allowsRoundingHacks]
6         https://bugs.webkit.org/show_bug.cgi?id=63734
7
8         * WebView/WebView.mm:
9         (+[WebView _allowsRoundingHacks]): Added this accessor.
10         * WebView/WebViewPrivate.h:
11
12 2011-06-29  Darin Adler  <darin@apple.com>
13
14         Reviewed by Dan Bernstein.
15
16         [Mac] Use system cursors instead of custom bitmaps where possible
17         https://bugs.webkit.org/show_bug.cgi?id=63679
18
19         * WebCoreSupport/WebSystemInterface.mm:
20         (InitWebCoreSystemInterface): Added WKCursor.
21
22 2011-06-28  Ilya Sherman  <isherman@chromium.org>
23
24         Reviewed by Adam Barth.
25
26         form.autocomplete="off" does not work
27         https://bugs.webkit.org/show_bug.cgi?id=35823
28
29         * WebView/WebHTMLRepresentation.mm:
30         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Update callsite.
31
32 2011-06-26  Mark Rowe  <mrowe@apple.com>
33
34         Reviewed by Dan Bernstein.
35
36         Use a separate file name for Lion's WebKitSystemInterface.
37
38         * Configurations/DebugRelease.xcconfig:
39
40 2011-06-24  Dan Bernstein  <mitz@apple.com>
41
42         Reviewed by Anders Carlsson.
43
44         Add an option to enable legacy rounding hacks
45         https://bugs.webkit.org/show_bug.cgi?id=63363
46
47         * Misc/WebKitNSStringExtras.mm:
48         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
49         Disabled rounding hacks.
50         (-[NSString _web_widthWithFont:]): Ditto.
51         * WebView/WebView.mm:
52         (+[WebView _setAllowsRoundingHacks:]): Added this setter.
53         * WebView/WebViewPrivate.h:
54
55 2011-06-24  Dominic Cooney  <dominicc@chromium.org>
56
57         Reviewed by Dimitri Glazkov.
58
59         Convert shadow DOM-related tests to use window.internals
60         https://bugs.webkit.org/show_bug.cgi?id=61671
61
62         Remove shadow DOM-related methods from Mac API. These are not
63         required any more.
64
65         * DOM/WebDOMOperations.mm:
66         * DOM/WebDOMOperationsPrivate.h:
67
68 2011-06-24  Yuta Kitamura  <yutak@chromium.org>
69
70         Reviewed by Adam Barth.
71
72         WebSocket: Add run-time flag for new HyBi protocol
73         https://bugs.webkit.org/show_bug.cgi?id=60348
74
75         Make a new flag (Setting::m_useHixie76WebSocketProtocol)
76         switchable from WebView and WebPreferences.
77
78         * WebView/WebPreferenceKeysPrivate.h:
79         * WebView/WebPreferences.mm:
80         (+[WebPreferences initialize]):
81         (-[WebPreferences setHixie76WebSocketProtocolEnabled:]):
82         (-[WebPreferences isHixie76WebSocketProtocolEnabled]):
83         * WebView/WebPreferencesPrivate.h:
84         * WebView/WebView.mm:
85         (-[WebView _preferencesChanged:]):
86
87 2011-06-22  Sam Weinig  <sam@webkit.org>
88
89         Roll out r89469 (Add preference for setting the html parser depth limit)
90
91         The preference is not needed at this time, so there is no reason to expose it.
92
93         * WebView/WebPreferenceKeysPrivate.h:
94         * WebView/WebPreferences.mm:
95         (+[WebPreferences initialize]):
96         * WebView/WebPreferencesPrivate.h:
97         * WebView/WebView.mm:
98         (-[WebView _preferencesChanged:]):
99
100 2011-06-22  Sam Weinig  <sam@webkit.org>
101
102         Reviewed by Adam Barth.
103
104         Add preference for setting the html parser depth limit
105         https://bugs.webkit.org/show_bug.cgi?id=63163
106
107         * WebView/WebPreferenceKeysPrivate.h:
108         * WebView/WebPreferences.mm:
109         (+[WebPreferences initialize]):
110         (-[WebPreferences setMaximumHTMLParserDOMTreeDepth:]):
111         (-[WebPreferences maximumHTMLParserDOMTreeDepth]):
112         * WebView/WebPreferencesPrivate.h:
113         * WebView/WebView.mm:
114         (-[WebView _preferencesChanged:]):
115         Add private preference for setting the parser depth limit.
116
117 2011-06-22  Ryosuke Niwa  <rniwa@webkit.org>
118
119         Reviewed by Darin Adler.
120
121         Make instantiation of legacy editing position more explicit
122         https://bugs.webkit.org/show_bug.cgi?id=63037
123
124         Create new positions since we can't create a legacy editing position outside of WebCore anymore.
125
126         * WebView/WebFrame.mm:
127         (-[WebFrame _smartDeleteRangeForProposedRange:]): Calls createLegacyEditingPosition.
128         (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
129
130 2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
131
132         Reviewed by Kent Tamura.
133
134         FileChooser should be only created when we need to choose files.
135         https://bugs.webkit.org/show_bug.cgi?id=63039
136
137         * WebCoreSupport/WebChromeClient.mm:
138         (WebChromeClient::runOpenPanel): Changed to use settings.
139
140 2011-06-21  MORITA Hajime  <morrita@google.com>
141
142         Unreviewed, rolling out r89401 and r89403.
143         http://trac.webkit.org/changeset/89401
144         http://trac.webkit.org/changeset/89403
145         https://bugs.webkit.org/show_bug.cgi?id=62970
146
147         Breaks mac build and mistakenly enables the spellcheck API
148
149         * Configurations/FeatureDefines.xcconfig:
150
151 2011-06-20  MORITA Hajime  <morrita@google.com>
152
153         Reviewed by Kent Tamura.
154
155         Spellcheck API should be build-able.
156         https://bugs.webkit.org/show_bug.cgi?id=62970
157
158         No new tests, changing only build related files
159
160         * Configurations/FeatureDefines.xcconfig:
161
162 2011-06-21  Sheriff Bot  <webkit.review.bot@gmail.com>
163
164         Unreviewed, rolling out r89354.
165         http://trac.webkit.org/changeset/89354
166         https://bugs.webkit.org/show_bug.cgi?id=63099
167
168         Broke tests on Mac (Requested by rniwa on #webkit).
169
170         * WebCoreSupport/WebInspectorClient.mm:
171         (-[WebInspectorWindowController destroyInspectorView:]):
172         * WebInspector/WebInspector.mm:
173         (-[WebInspector show:]):
174         (-[WebInspector showConsole:]):
175         (-[WebInspector isDebuggingJavaScript]):
176         (-[WebInspector toggleDebuggingJavaScript:]):
177         (-[WebInspector startDebuggingJavaScript:]):
178         (-[WebInspector stopDebuggingJavaScript:]):
179         (-[WebInspector isProfilingJavaScript]):
180         (-[WebInspector toggleProfilingJavaScript:]):
181         (-[WebInspector startProfilingJavaScript:]):
182         (-[WebInspector stopProfilingJavaScript:]):
183         (-[WebInspector isJavaScriptProfilingEnabled]):
184         (-[WebInspector setJavaScriptProfilingEnabled:]):
185         (-[WebInspector isTimelineProfilingEnabled]):
186         (-[WebInspector setTimelineProfilingEnabled:]):
187         (-[WebInspector setFrontend:]):
188         (-[WebInspector showWindow:]):
189         * WebInspector/WebInspectorFrontend.h:
190         * WebInspector/WebInspectorFrontend.mm:
191         * WebInspector/WebInspectorPrivate.h:
192
193 2011-06-20  Pavel Feldman  <pfeldman@chromium.org>
194
195         Reviewed by Yury Semikhatsky.
196
197         Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
198         https://bugs.webkit.org/show_bug.cgi?id=62985
199
200         Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
201         methods for plumbing the menu action handlers through the WebKit and WebCore.
202         I intend to remove this menu support from the protocol and WebCore/InspectorController API.
203         I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
204         WebKit/win and WebKit2 to follow.
205
206         * WebCoreSupport/WebInspectorClient.mm:
207         (-[WebInspectorWindowController destroyInspectorView:]):
208         * WebInspector/WebInspector.mm:
209         (-[WebInspector showWindow]):
210         (-[WebInspector show:]):
211         (-[WebInspector showConsole:]):
212         (-[WebInspector isDebuggingJavaScript]):
213         (-[WebInspector toggleDebuggingJavaScript:]):
214         (-[WebInspector startDebuggingJavaScript:]):
215         (-[WebInspector stopDebuggingJavaScript:]):
216         (-[WebInspector isProfilingJavaScript]):
217         (-[WebInspector toggleProfilingJavaScript:]):
218         (-[WebInspector startProfilingJavaScript:]):
219         (-[WebInspector stopProfilingJavaScript:]):
220         (-[WebInspector isJavaScriptProfilingEnabled]):
221         (-[WebInspector setJavaScriptProfilingEnabled:]):
222         (-[WebInspector isTimelineProfilingEnabled]):
223         (-[WebInspector setTimelineProfilingEnabled:]):
224         (-[WebInspector setFrontend:]):
225         (-[WebInspector releaseFrontend]):
226         (-[WebInspector showWindow:]):
227         * WebInspector/WebInspectorFrontend.h:
228         * WebInspector/WebInspectorFrontend.mm:
229         (-[WebInspectorFrontend isDebuggingEnabled]):
230         (-[WebInspectorFrontend setDebuggingEnabled:]):
231         (-[WebInspectorFrontend isProfilingJavaScript]):
232         (-[WebInspectorFrontend startProfilingJavaScript]):
233         (-[WebInspectorFrontend stopProfilingJavaScript]):
234         (-[WebInspectorFrontend isJavaScriptProfilingEnabled]):
235         (-[WebInspectorFrontend setJavaScriptProfilingEnabled:]):
236         (-[WebInspectorFrontend isTimelineProfilingEnabled]):
237         (-[WebInspectorFrontend setTimelineProfilingEnabled:]):
238         * WebInspector/WebInspectorPrivate.h:
239
240 2011-06-01  Jer Noble  <jer.noble@apple.com>
241
242         Reviewed by Eric Carlson.
243
244         Move Full Screen Controllers into WebCore.
245
246         Remove dependency on QTKit from wekitExitFullscreen()
247         https://bugs.webkit.org/show_bug.cgi?id=61843
248
249         WebVideoFullscreenController, WebVideoFullscreenHUDController, and WebWindowAnimation
250         have been moved into WebCore.
251
252         * WebCoreSupport/WebSystemInterface.mm:
253         (InitWebCoreSystemInterface): Add support for four WKSI functions in WCSI.
254         * WebView/WebFullScreenController.mm: Remove unused #include.
255         * WebView/WebView.mm: Change the include location of 
256             WebVideoFullscreenController.h
257
258 2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
259
260         Reviewed by Darin Adler.
261
262         Separate concerns of loading file icons and choosing files.
263         https://bugs.webkit.org/show_bug.cgi?id=62931
264
265         * WebCoreSupport/WebChromeClient.h:
266         * WebCoreSupport/WebChromeClient.mm:
267         (WebChromeClient::loadIconForFiles): Renamed.
268
269 2011-06-18  Andrew Wellington  <andrew@webkit.org>
270
271         Reviewed by Alexey Proskuryakov.
272
273         https://bugs.webkit.org/show_bug.cgi?id=62843
274         WebKit Mac API calls didReceiveAuthenticationChallenge instead of
275         didCancelAuthenticationChallenge
276
277         * WebView/WebView.mm:
278         (-[WebView _cacheResourceLoadDelegateImplementations]):
279
280 2011-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
281
282         Unreviewed, rolling out r89026.
283         http://trac.webkit.org/changeset/89026
284         https://bugs.webkit.org/show_bug.cgi?id=62804
285
286         These patches were likely correct.  I'll investigate the
287         browser_test failures. (Requested by abarth on #webkit).
288
289         * WebView/WebVideoFullscreenHUDWindowController.mm:
290         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
291
292 2011-06-16  Vitaly Repeshko  <vitalyr@chromium.org>
293
294         Unreviewed.
295
296         Revert Adam's user gesture patch series r89002, r89005, r89007, r89018
297         https://bugs.webkit.org/show_bug.cgi?id=62796
298
299         The patches broke chromium browser tests.
300
301         * WebView/WebVideoFullscreenHUDWindowController.mm:
302         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
303
304 2011-06-16  Adam Barth  <abarth@webkit.org>
305
306         Reviewed by Eric Seidel.
307
308         Remove HTMLVideoElement::processingUserGesture
309         https://bugs.webkit.org/show_bug.cgi?id=62784
310
311         * WebView/WebVideoFullscreenHUDWindowController.mm:
312         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
313
314 2011-06-15  Adam Barth  <abarth@webkit.org>
315
316         Reviewed by Eric Seidel.
317
318         Remove ScriptController::setAllowPopupsFromPlugin
319         https://bugs.webkit.org/show_bug.cgi?id=62706
320
321         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
322         (WebKit::NetscapePluginInstanceProxy::evaluate):
323         * Plugins/WebNetscapePluginView.mm:
324         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
325
326 2011-06-15  David Kilzer  <ddkilzer@apple.com>
327
328         <http://webkit.org/b/62745> Convert WebNSFileManagerExtras.m to Objective-C++
329
330         Reviewed by Joseph Pecoraro.
331
332         * Misc/WebNSFileManagerExtras.mm: Renamed from Source/WebKit/mac/Misc/WebNSFileManagerExtras.m.
333         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
334         Added static_cast<MetaDataInfo *>.
335
336 2011-06-14  Stephanie Lewis  <slewis@apple.com>
337
338         Rubber stamped by Oliver Hunt.
339
340         <rdar://problem/9511169>
341         Update order files.
342
343         * WebKit.order:
344
345 2011-06-13  Kentaro Hara  <haraken@google.com>
346
347         Reviewed by Alexey Proskuryakov.
348
349         Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
350         https://bugs.webkit.org/show_bug.cgi?id=61256
351
352         In order to prevent rounding error caused by expanding/shrinking a page
353         using different calculation here and there, I added a common calculation
354         method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
355         keeping the ratio of width and height of the original page.
356         [WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]
357         and [WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]
358         use resizePageRectsKeepingRatio() to expand/shrink a page.
359
360         Test: printing/page-count-with-one-word.html
361
362         * WebView/WebHTMLView.mm:
363         (-[WebHTMLView _web_setPrintingModeRecursive]):
364         (-[WebHTMLView _web_clearPrintingModeRecursive]):
365         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
366         (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumShrinkRatio:]):
367         (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
368         (-[WebHTMLView _endPrintMode]):
369         (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
370         (-[WebHTMLView _endScreenPaginationMode]):
371         (-[WebHTMLView layoutToMinimumPageWidth:height:maximumShrinkRatio:adjustingViewSize:]):
372         (-[WebHTMLView layout]):
373         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
374         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
375         (-[WebHTMLView setPageWidthForPrinting:]):
376
377 2011-06-13  Tony Chang  <tony@chromium.org>
378
379         Reviewed by Dimitri Glazkov.
380
381         rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
382         https://bugs.webkit.org/show_bug.cgi?id=62578
383
384         * Configurations/FeatureDefines.xcconfig:
385
386 2011-06-13  Tony Chang  <tony@chromium.org>
387
388         Reviewed by Adam Barth.
389
390         rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
391         https://bugs.webkit.org/show_bug.cgi?id=62545
392
393         * Configurations/FeatureDefines.xcconfig:
394
395 2011-06-12  Adam Barth  <abarth@webkit.org>
396
397         Reviewed by Alexey Proskuryakov.
398
399         Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
400         https://bugs.webkit.org/show_bug.cgi?id=62516
401
402         * WebCoreSupport/WebFrameLoaderClient.h:
403         * WebCoreSupport/WebFrameLoaderClient.mm:
404         (WebFrameLoaderClient::interruptedForPolicyChangeError):
405
406 2011-06-12  Adam Barth  <abarth@webkit.org>
407
408         Reviewed by Eric Seidel.
409
410         Remove FrameLoader::isProcessingUserGesture
411         https://bugs.webkit.org/show_bug.cgi?id=62519
412
413         * WebView/WebView.mm:
414         (-[WebView _isProcessingUserGesture]):
415
416 2011-06-12  Adam Barth  <abarth@webkit.org>
417
418         Reviewed by Alexey Proskuryakov.
419
420         Remove trival "forward-to-client" member functions from FrameLoader
421         https://bugs.webkit.org/show_bug.cgi?id=62510
422
423         * WebCoreSupport/WebFrameNetworkingContext.mm:
424         (WebFrameNetworkingContext::blockedError):
425
426 2011-06-10  Tony Chang  <tony@chromium.org>
427
428         Reviewed by Ojan Vafai.
429
430         add a compile guard ENABLE(FLEXBOX)
431         https://bugs.webkit.org/show_bug.cgi?id=62049
432
433         * Configurations/FeatureDefines.xcconfig:
434
435 2011-06-06  Michael Saboff  <msaboff@apple.com>
436
437         Reviewed by Geoffrey Garen.
438
439         Fonts returned by FontCache::getFontDataForCharacters() are never released
440         https://bugs.webkit.org/show_bug.cgi?id=61875
441
442         This change allows fonts allocated as system fallback fonts to be
443         released.  Previously, the reference counts for these fonts grew
444         without bound.  This is implemented as an auto release class that wraps
445         accesses to the cache for system fallback fonts. All such accesses are
446         via the method FontCache::getFontDataForCharacters. The new class is
447         called FontCachePurgePreventer. When such an object exists, it protects
448         these fonts from deletion.
449
450         See more comments for this defect in Source/WebCore/ChangeLog.
451
452         * Misc/WebKitNSStringExtras.mm:
453         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
454         (-[NSString _web_widthWithFont:]):
455         Wrapped code accessing fallback fonts with local
456         FontCachePurgePreventer in these methods.
457
458         * Misc/WebStringTruncator.mm:
459         (+[WebStringTruncator centerTruncateString:toWidth:]):
460         (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):
461         (+[WebStringTruncator rightTruncateString:toWidth:withFont:]):
462         (+[WebStringTruncator widthOfString:font:]):
463         Wrapped code accessing fallback fonts with local
464         FontCachePurgePreventer in these methods.
465
466 2011-06-06  Peter Kasting  <pkasting@google.com>
467
468         Reviewed by Antonio Gomes.
469
470         Remove unnecessary args from scroll functions.
471         https://bugs.webkit.org/show_bug.cgi?id=61648
472
473         * WebView/WebFrame.mm:
474         (-[WebFrame _scrollDOMRangeToVisible:]):
475
476 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
477
478         Reviewed by Kent Tamura.
479
480         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
481         https://bugs.webkit.org/show_bug.cgi?id=61628
482
483         * Configurations/FeatureDefines.xcconfig:
484
485 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
486
487         Reviewed by Kent Tamura.
488
489         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
490         https://bugs.webkit.org/show_bug.cgi?id=61631
491
492         * Configurations/FeatureDefines.xcconfig:
493
494 2011-06-02  Anders Carlsson  <andersca@apple.com>
495
496         Reviewed by Sam Weinig.
497
498         Need a way to install the memory pressure handler without initializing WebKit1
499         https://bugs.webkit.org/show_bug.cgi?id=61975
500
501         Add a WebInstallMemoryPressureHandler function which will install the memory pressure handler.
502         -[WebView WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:] will do this,
503         but we'd like to be able to install a memory pressure handler without creating a WebView or even
504         calling any WebView method since that will call +[WebView initialize].
505
506         * WebKit.exp:
507         * WebView/WebView.mm:
508         (WebInstallMemoryPressureHandler):
509         * WebView/WebViewPrivate.h:
510
511 2011-05-27  Stephanie Lewis  <slewis@apple.com>
512
513         Unreviewed.
514
515         Fix a typo in the order_file flag.
516
517         * Configurations/Base.xcconfig:
518
519 2011-05-27  Stephanie Lewis  <slewis@apple.com>
520
521         Rubber Stamped by Adam Roben.
522
523         Update Order Files.  Use -order_file flag since it can order more of the binary.
524
525         * Configurations/Base.xcconfig:
526         * WebKit.order:
527
528 2011-05-25  Stephanie Lewis  <slewis@apple.com>
529
530         Reviewed by Brady Eidson.
531
532         https://bugs.webkit.org/show_bug.cgi?id=61407
533         part of <rdar://problem/8675177>
534         Remove Quicklook pref.  Moving it enirely down into WebCore so it can
535         be calculated only on reloads.
536
537         * WebView/WebPreferenceKeysPrivate.h:
538         * WebView/WebPreferences.mm:
539         (+[WebPreferences initialize]):
540         * WebView/WebPreferencesPrivate.h:
541         * WebView/WebView.mm:
542         (-[WebView _preferencesChanged:]):
543
544 2011-05-24  Jer Noble  <jer.noble@apple.com>
545
546         Reviewed by Darin Adler.
547
548         Video fails to play on Vimeo
549         https://bugs.webkit.org/show_bug.cgi?id=61403
550
551         * WebCoreSupport/WebSystemInterface.mm:
552         (InitWebCoreSystemInterface): Added support for wkAVAssetResolvedURL and
553             wkQTMovieResolvedURL.
554
555 2011-05-24  Keishi Hattori  <keishi@webkit.org>
556
557         Reviewed by Kent Tamura.
558
559         Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer.
560         https://bugs.webkit.org/show_bug.cgi?id=61273
561
562         * Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag.
563
564 2011-05-24  Adam Barth  <abarth@webkit.org>
565
566         Reviewed by Eric Seidel.
567
568         Add FIXME comments about removing FrameLoader::isProcessingUserGesture
569         https://bugs.webkit.org/show_bug.cgi?id=61395
570
571         * WebView/WebView.mm:
572         (-[WebView _isProcessingUserGesture]):
573
574 2011-05-24  Michael Saboff  <msaboff@apple.com>
575
576         Reviewed by Geoffrey Garen.
577
578         Improve handling in WebCore of low memory situations
579         https://bugs.webkit.org/show_bug.cgi?id=61222
580
581         Added call to enable memory pressure handling.
582
583         * WebView/WebView.mm:
584         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
585         * WebView/WebViewInternal.h:
586
587 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
588
589         Rubberstamped by David Kilzer.
590
591         Updated some files that I forgot in my previous MHTML CL.
592
593         * Configurations/FeatureDefines.xcconfig:
594
595 2011-05-20  Jeremy Noble  <jer.noble@apple.com>
596
597         Reviewed by Simon Fraser.
598
599         Stack overflow in WebFullScreenController when built on Leopard and run on SnowLeopard.
600         https://bugs.webkit.org/show_bug.cgi?id=61224
601
602         Remove the CATransaction(SnowLeopardConvenience) functions, and replace them with the Leopard
603         versions of same.
604
605         * WebView/WebFullScreenController.mm:
606         (-[WebFullScreenController windowDidEnterFullscreen:]):
607         (-[WebFullScreenController enterFullscreen:]):
608         (-[WebFullScreenController exitFullscreen]):
609         (-[WebFullscreenWindow setRendererLayer:]):
610
611 2011-05-20  Andy Estes  <aestes@apple.com>
612
613         Reviewed by Darin Adler.
614
615         WebView loses firstResponder status when entering full-screen mode.
616         https://bugs.webkit.org/show_bug.cgi?id=61153
617
618         * Misc/WebNSWindowExtras.h:
619         * Misc/WebNSWindowExtras.m:
620         (-[NSWindow makeResponder:firstResponderIfDescendantOfView:]): Add a
621         convenience method to NSWindow that makes the given NSResponder first
622         responder only if it is a descendant of the given view.
623         * WebView/WebFullScreenController.mm:
624         (-[WebFullScreenController windowDidEnterFullscreen:]): If the WebView
625         was a descendant of the browser window's first responder when entering
626         full-screen mode, set the full-screen window's first responder to that
627         same NSResponder.
628         (-[WebFullScreenController exitFullscreen]): Do the reverse of what is
629         done in windowDidEnterFullscreen:.
630
631 2011-05-20  Enrica Casucci  <enrica@apple.com>
632
633         Reviewed by David Kilzer.
634
635         Add delegate methods about focus and blur to all elements.
636         https://bugs.webkit.org/show_bug.cgi?id=61218
637
638         We want to have delegates for these events for all the elements, not only the form elements.
639         The patch changes the name of the methods in a way that is not form element specific.
640
641         * WebCoreSupport/WebChromeClient.h:
642         * WebCoreSupport/WebChromeClient.mm:
643         (WebChromeClient::elementDidFocus):
644         (WebChromeClient::elementDidBlur):
645         * WebView/WebUIDelegatePrivate.h:
646
647 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
648
649         Reviewed by Sam Weinig.
650
651         numberOfActiveAnimations() can include animations from documents in the page cache
652         https://bugs.webkit.org/show_bug.cgi?id=53641
653
654         Pass the Frame's document as the one to count animations on.
655
656         * WebView/WebFrame.mm:
657         (-[WebFrame _numberOfActiveAnimations]):
658
659 2011-05-17  Timothy Hatcher  <timothy@apple.com>
660
661         Update the the context menu to reflect the system search provider on Mac.
662
663         <rdar://problem/9198419>
664
665         Reviewed by Sam Weinig.
666
667         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
668         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): Use wkCopyDefaultSearchProviderDisplayName to
669         create the web search context menu title.
670         * WebCoreSupport/WebSystemInterface.mm:
671         (InitWebCoreSystemInterface): Added CopyDefaultSearchProviderDisplayName.
672
673 2011-05-16  Emil A Eklund  <eae@chromium.org>
674
675         Reviewed by Eric Seidel.
676
677         Replace docTop/Right/Bottom/Left/Width/Height with documentRect
678         https://bugs.webkit.org/show_bug.cgi?id=60743
679
680         Replace uses of docWidth/Height with documentRect.
681
682         * WebView/WebFrame.mm:
683         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
684
685 2011-05-16  Yuzo Fujishima  <yuzo@google.com>
686
687         Reviewed by Antti Koivisto.
688
689         Fix for Bug 43704 - Web font is printed as blank if it is not cached
690         https://bugs.webkit.org/show_bug.cgi?id=43704
691
692         * WebView/WebHTMLView.mm:
693         (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]): Use ResourceCacheValidationSuppressor to allow stale resources in printing.
694
695 2011-05-16  David Kilzer  <ddkilzer@apple.com>
696
697         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
698         <rdar://problem/9446430>
699
700         Reviewed by Mark Rowe.
701
702         * Configurations/Base.xcconfig: Fixed typo.
703
704 2011-05-13  Jon Lee  <jonlee@apple.com>
705
706         Reviewed by Simon Fraser.
707
708         Can't horizontally scroll iframes and overflow because wheel events are always accepted
709         https://bugs.webkit.org/show_bug.cgi?id=60779
710
711         * WebCoreSupport/WebChromeClient.h:
712         (WebChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method
713         (WebChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
714
715 2011-05-13  Sam Weinig  <sam@webkit.org>
716
717         Reviewed by Anders Carlsson.
718
719         Prune #includes from FrameView.h (Part 2)
720         https://bugs.webkit.org/show_bug.cgi?id=60748
721
722         - Update files that were depending on FrameView.h #including Frame.h or
723           Page.h.
724
725         * WebView/WebClipView.mm:
726         * WebView/WebHTMLView.mm:
727         (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
728
729 2011-05-12  Pratik Solanki  <psolanki@apple.com>
730
731         Reviewed by Antti Koivisto.
732
733         Part of WebCore should use CFNetwork-based loader on Mac
734         https://bugs.webkit.org/show_bug.cgi?id=51836
735
736         Use CFRunLoop when using CFNetwork.
737
738         * WebView/WebView.mm:
739         (-[WebView scheduleInRunLoop:forMode:]):
740         (-[WebView unscheduleFromRunLoop:forMode:]):
741
742 2011-05-12  Pratik Solanki  <psolanki@apple.com>
743
744         Reviewed by Antti Koivisto.
745
746         Part of WebCore should use CFNetwork-based loader on Mac
747         https://bugs.webkit.org/show_bug.cgi?id=51836
748
749         Include AuthenticationCF.h header file.
750
751         * Misc/WebDownload.mm:
752         * Plugins/WebBaseNetscapePluginView.mm:
753         * WebCoreSupport/WebFrameLoaderClient.mm:
754
755 2011-05-12  Adele Peterson  <adele@apple.com>
756
757         Reviewed by Darin Adler and Adam Barth.
758
759         Fix for <rdar://problem/9253454> Solar Walk For Mac: Info window is blank (HTML5 parser)
760         https://bugs.webkit.org/show_bug.cgi?id=60685
761
762         Solar Walk uses a self closing title tag, so to match the behavior of the old parser, 
763         we use a UserScript to write the contents of the title element to the end of the document so it can be re-parsed.
764
765         * Misc/SolarWalkQuirksUserScript.js: Added.
766         * WebView/WebView.mm:
767         (needsSolarWalkQuirksScript):
768         (leakSolarWalkQuirksUserScriptContents):
769         (-[WebView _injectSolarWalkQuirksScript]):
770         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
771
772 2011-05-12  Jia Pu  <jpu@apple.com>
773
774         Reviewed by Darin Adler.
775
776         Regression caused by changeset 86281
777         https://bugs.webkit.org/show_bug.cgi?id=60712
778         <rdar://problem/9427970>
779
780         Removed the condition variable. [NSSpellChecker dismissCorrectionIndicatorForView:] is blocking.
781         So handleAcceptedReplacement() triggered by dismissInternal() will return before dismissInternal()
782         returns. So we don't need to use the condition to coordinate between these two function. In fact,
783         all callbacks are delivered on main thread. We don't really need any locking here.
784
785         Since now we don't have distinction between dismiss() and dismissSoon(). dismissSoon() has
786         been removed.
787
788         * WebCoreSupport/CorrectionPanel.h:
789         * WebCoreSupport/CorrectionPanel.mm:
790         (CorrectionPanel::CorrectionPanel):
791         (CorrectionPanel::show):
792         (CorrectionPanel::dismiss):
793         (CorrectionPanel::dismissInternal):
794         (CorrectionPanel::handleAcceptedReplacement):
795         * WebCoreSupport/WebEditorClient.mm:
796         (WebEditorClient::dismissCorrectionPanelSoon):
797
798 2011-05-12  Patrick Gansterer  <paroga@webkit.org>
799
800         Reviewed by Adam Barth.
801
802         Enable OwnPtr strict mode in PluginHalter
803         https://bugs.webkit.org/show_bug.cgi?id=60681
804
805         * WebView/WebView.mm:
806         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
807
808 2011-05-12  Nikolas Zimmermann  <nzimmermann@rim.com>
809
810         Reviewed by Darin Adler.
811
812         String operator+ reallocates unnecessarily when concatting > 2 strings
813         https://bugs.webkit.org/show_bug.cgi?id=58420
814
815         Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.
816
817         * WebView/WebFrame.mm: Explicitely cast to Strings first, so operator NSString*() can be invoked.
818         (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]):
819
820 2011-05-10  Tony Gentilcore  <tonyg@chromium.org>
821
822         Reviewed by Darin Adler.
823
824         Perform some forward declarations suggested by include-what-you-use
825         https://bugs.webkit.org/show_bug.cgi?id=60545
826
827         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
828         * WebView/WebFrame.mm:
829
830 2011-05-11  Jia Pu  <jpu@apple.com>
831
832         Reviewed by Darin Adler.
833
834         CorrectionPanel sometimes hangs in dismissSoon().
835         https://bugs.webkit.org/show_bug.cgi?id=60599
836         <rdar://problem/9313628>
837
838         Make sure dismissSoon() won't wait indefinitely if handleAcceptedReplacement() sets m_resultForSynchronousDismissal
839         to nil. Added a designated variable m_isDismissing, instead of piggy-backing m_resultForSynchronousDismissal,
840         for condition checking.
841
842         * WebCoreSupport/CorrectionPanel.h:
843         * WebCoreSupport/CorrectionPanel.mm:
844         (CorrectionPanel::CorrectionPanel):
845         (CorrectionPanel::show):
846         (CorrectionPanel::dismissSoon):
847         (CorrectionPanel::dismissInternal):
848         (CorrectionPanel::handleAcceptedReplacement):
849
850 2011-05-10  Anton D'Auria  <adauria@apple.com>
851
852         Reviewed by David Levin.
853
854         Add ApplicationCache API to get disk usage per origin
855         https://bugs.webkit.org/show_bug.cgi?id=57127
856
857         Added Mac port API.
858
859         * WebCoreSupport/WebApplicationCache.h:
860         * WebCoreSupport/WebApplicationCache.mm:
861         (+[WebApplicationCache diskUsageForOrigin:]):
862
863 2011-05-10  Anton D'Auria  <adauria@apple.com>
864
865         Reviewed by Alexey Proskuryakov.
866
867         Add ApplicationCache API to get disk usage per origin
868         https://bugs.webkit.org/show_bug.cgi?id=57127
869
870         Added Mac port API.
871
872         * WebCoreSupport/WebApplicationCache.h:
873         * WebCoreSupport/WebApplicationCache.mm:
874         (+[WebApplicationCache diskUsageForOrigin:]):
875
876 2011-05-10  Beth Dakin  <bdakin@apple.com>
877
878         Reviewed by Darin Adler.
879
880         https://bugs.webkit.org/show_bug.cgi?id=60582
881         Crash switching overlay/non-overlay scrollbar preference still possible
882         -and corresponding-
883         <rdar://problem/9323983>
884
885         * WebCoreSupport/WebSystemInterface.mm:
886         (InitWebCoreSystemInterface):
887
888 2011-05-09  Jeremy Noble  <jer.noble@apple.com>
889
890         Reviewed by Darin Adler.
891
892         Command-~/Exposé to another window while <video> is in full screen, breaks Safari, eventually leading to crash
893         https://bugs.webkit.org/show_bug.cgi?id=60496
894
895         When animating into and out of full screen, order out and back in the original webView window,
896         disabling animations when necessary.  The exitFullscreen method was targeting the wrong window,
897         as the webView is hosted in the full screen window when we ask for it's parent window.
898
899         * WebView/WebFullScreenController.mm:
900         (-[WebFullScreenController windowDidEnterFullscreen:]):
901         (-[WebFullScreenController exitFullscreen]):
902
903 2011-05-04  Philippe Normand  <pnormand@igalia.com>
904
905         Reviewed by Dimitri Glazkov.
906
907         Implement LayoutTestController::pseudoShadowId()
908         https://bugs.webkit.org/show_bug.cgi?id=60034
909
910         * DOM/WebDOMOperations.mm:
911         (-[DOMElement _shadowPseudoId]):
912         * DOM/WebDOMOperationsPrivate.h:
913
914 2011-05-05  Dan Bernstein  <mitz@apple.com>
915
916         Reviewed by Simon Fraser.
917
918         WebKit part of <rdar://problem/9155590> Broken animation in iAd producer
919
920         * WebCoreSupport/WebSystemInterface.mm:
921         (InitWebCoreSystemInterface): Initialize wkExecutableWasLinkedOnOrBeforeSnowLeopard.
922
923 2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
924
925         Reviewed by Eric Seidel.
926
927         Rename SelectionController to FrameSelection
928         https://bugs.webkit.org/show_bug.cgi?id=60234
929
930         * WebView/WebFrame.mm:
931         (-[WebFrame _rangeByAlteringCurrentSelection:FrameSelection::direction:granularity:]):
932         * WebView/WebFrameInternal.h:
933         * WebView/WebHTMLView.mm:
934         * WebView/WebTextCompletionController.mm:
935         (-[WebTextCompletionController doCompletion]):
936         * WebView/WebView.mm:
937
938 2011-05-04  Cris Neckar  <cdn@chromium.org>
939
940         Reviewed by Adam Barth.
941
942         Expose WebView directly through ChromeClient.
943         https://bugs.webkit.org/show_bug.cgi?id=49902
944
945         * WebCoreSupport/WebChromeClient.h:
946         (WebChromeClient::webView):
947         * WebView/WebFrame.mm:
948         (kit):
949
950 2011-05-04  Tao Bai  <michaelbai@chromium.org>
951
952         Reviewed by David Kilzer.
953
954         Populate touch-icon url to FrameLoaderClient
955         https://bugs.webkit.org/show_bug.cgi?id=59143
956
957         Respect the interface change in FrameLoaderClient.
958
959         * Configurations/FeatureDefines.xcconfig:
960         * WebCoreSupport/WebFrameLoaderClient.h:
961         * WebCoreSupport/WebFrameLoaderClient.mm:
962         (WebFrameLoaderClient::dispatchDidChangeIcons):
963
964 2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>
965
966         Reviewed by Dimitri Glazkov.
967
968         Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
969         https://bugs.webkit.org/show_bug.cgi?id=58703
970
971         * DOM/WebDOMOperations.mm: Added #include for ShadowRoot.h.
972
973 2011-05-02  Adam Roben  <aroben@apple.com>
974
975         Take advantage of implicit conversion from nullptr_t to PassOwnPtr
976
977         Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
978         doesn't work, but should
979
980         Reviewed by Adam Barth.
981
982         * History/WebHistory.mm:
983         * Plugins/WebNetscapePluginEventHandler.mm:
984         * WebView/WebView.mm:
985
986 2011-05-02  Brady Eidson  <beidson@apple.com>
987
988         Reviewed by Anders Carlsson.
989
990         <rdar://problem/9340945> and https://bugs.webkit.org/show_bug.cgi?id=59973
991         In Aperture, a WebView might be dealloc'ed before it finishes loading.
992
993         * WebView/WebView.mm:
994         (needsSelfRetainWhileLoadingQuirk):
995         (-[WebView _didStartProvisionalLoadForFrame:]): If we need the quirk, retain self.
996         (-[WebView _didFinishLoadForFrame:]): If we need the quirk, release self on a delay.
997         (-[WebView _didFailLoadWithError:forFrame:]): Ditto.
998         (-[WebView _didFailProvisionalLoadWithError:forFrame:]): Ditto.
999
1000 2011-05-02  Adam Barth  <abarth@webkit.org>
1001
1002         Reviewed by David Levin.
1003
1004         PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
1005         https://bugs.webkit.org/show_bug.cgi?id=59924
1006
1007         * History/WebHistory.mm:
1008         (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
1009         * Plugins/WebBaseNetscapePluginView.mm:
1010         (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
1011         * WebCoreSupport/WebFrameLoaderClient.mm:
1012         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
1013         * WebView/WebView.mm:
1014         (-[WebView _injectMailQuirksScript]):
1015         (-[WebView _injectOutlookQuirksScript]):
1016         (toStringVector):
1017
1018 2011-05-02  Sam Weinig  <sam@webkit.org>
1019
1020         Reviewed by Adam Barth.
1021
1022         Prune some #includes from DOMWindow.h
1023         https://bugs.webkit.org/show_bug.cgi?id=59907
1024
1025         * Plugins/WebBaseNetscapePluginView.mm:
1026         * WebView/WebFrame.mm:
1027         Add now missing SecurityOrigin.h #includes.
1028
1029 2011-05-01  Ryosuke Niwa  <rniwa@webkit.org>
1030
1031         Reviewed by Eric Seidel.
1032
1033         Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
1034         https://bugs.webkit.org/show_bug.cgi?id=59837
1035
1036         Call sendContextMenuEvent and eventMayStartDrag with PlatformMouseEvent instead of NSEvent.
1037
1038         * WebView/WebHTMLView.mm:
1039         (-[WebHTMLView menuForEvent:]):
1040         (-[WebHTMLView acceptsFirstMouse:]):
1041         (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
1042
1043 2011-05-01  Ryosuke Niwa  <rniwa@webkit.org>
1044
1045         Reviewed by Eric Seidel.
1046
1047         Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
1048         https://bugs.webkit.org/show_bug.cgi?id=59835
1049
1050         Moved currentKeyboardEvent.
1051
1052         * WebView/WebHTMLView.mm:
1053         (currentKeyboardEvent):
1054         (-[WebHTMLView becomeFirstResponder]):
1055
1056 2011-04-29  Dean Jackson  <dino@apple.com>
1057
1058         Reviewed by Simon Fraser.
1059
1060         Add ENABLE macro for WebKitAnimation
1061         https://bugs.webkit.org/show_bug.cgi?id=59729
1062
1063         Add new feature to toggle WebKit Animation API.
1064
1065         * Configurations/FeatureDefines.xcconfig:
1066
1067 2011-04-28  David Kilzer  <ddkilzer@apple.com>
1068
1069         <http://webkit.org/b/59758> Fix static analyzer warnings for missing assignment to 'self' in -init methods
1070
1071         Reviewed by Anders Carlsson.
1072
1073         * History/WebHistory.mm:
1074         (-[WebHistoryPrivate init]):
1075         * Misc/WebElementDictionary.mm:
1076         (-[WebElementDictionary initWithHitTestResult:]):
1077         * Misc/WebIconDatabase.mm:
1078         (-[WebIconDatabase init]):
1079         * Plugins/WebPluginController.mm:
1080         (-[WebPluginController initWithDocumentView:]):
1081         * Plugins/WebPluginRequest.m:
1082         (-[WebPluginRequest initWithRequest:frameName:notifyData:sendNotification:didStartFromUserGesture:]):
1083         * WebCoreSupport/WebEditorClient.mm:
1084         (-[WebEditCommand initWithEditCommand:]):
1085         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1086         (-[WebJavaScriptTextInputPanel initWithPrompt:text:]):
1087         * WebView/WebNavigationData.mm:
1088         (-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
1089
1090 2011-04-28  David Levin  <levin@chromium.org>
1091
1092         Reviewed by Adam Barth.
1093
1094         Remove IMAGE_RESIZER related code.
1095         https://bugs.webkit.org/show_bug.cgi?id=59735
1096
1097         * Configurations/FeatureDefines.xcconfig:
1098
1099 2011-04-28  Adam Barth  <abarth@webkit.org>
1100
1101         Reviewed by Eric Seidel.
1102
1103         Remove WML
1104         https://bugs.webkit.org/show_bug.cgi?id=59678
1105
1106         Remove WML-related configuration options and private APIs.
1107
1108         * Configurations/FeatureDefines.xcconfig:
1109         * WebCoreSupport/WebChromeClient.mm:
1110         (stringForMessageSource):
1111         * WebView/WebFramePrivate.h:
1112         * WebView/WebUIDelegatePrivate.h:
1113
1114 2011-04-28  Brian Weinstein  <bweinstein@apple.com>
1115
1116         Reviewed by Timothy Hatcher.
1117
1118         Web Inspector: REGRESSION(85051): Develop Menu items are wrong when inspector is frontmost window
1119         https://bugs.webkit.org/show_bug.cgi?id=59747
1120
1121         Restore functions that were removed in r85051. They were needed when the inspector is the frontmost window.
1122         Also update them to call _inspectedWebView.get() - since it's a RetainPtr now.
1123
1124         * WebCoreSupport/WebInspectorClient.mm:
1125         (-[WebInspectorWindowController showWebInspector:]):
1126         (-[WebInspectorWindowController showErrorConsole:]):
1127         (-[WebInspectorWindowController toggleDebuggingJavaScript:]):
1128         (-[WebInspectorWindowController toggleProfilingJavaScript:]):
1129         (-[WebInspectorWindowController validateUserInterfaceItem:]):
1130
1131 2011-04-28  David Kilzer  <ddkilzer@apple.com>
1132
1133         <http://webkit.org/b/59725> -[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:] leaks a CALayer
1134
1135         Reviewed by Dan Bernstein.
1136
1137         * WebView/WebFullScreenController.mm:
1138         (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
1139         Use a RetainPtr to hold the CALayer and to fix the leak.
1140
1141 2011-04-28  David Kilzer  <ddkilzer@apple.com>
1142
1143         Follow-up fix: <http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects
1144
1145         Addresses review comment from Darin Adler.
1146
1147         * WebView/WebPDFView.mm:
1148         (-[WebPDFView menuForEvent:]): Use a local variable and -release
1149         instead of -autorelease.
1150
1151 2011-04-28  Anders Carlsson  <andersca@apple.com>
1152
1153         Fix a thinko - separateRealmLabel is not an NSImageView.
1154
1155         * Panels/WebAuthenticationPanel.h:
1156
1157 2011-04-28  David Kilzer  <ddkilzer@apple.com>
1158
1159         <http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects
1160
1161         Reviewed by Dan Bernstein.
1162
1163         * WebView/WebPDFView.mm:
1164         (-[WebPDFView menuForEvent:]): Call -autorelease after copying
1165         each NSMenuItem.  Regressed in r9566 for Bug 3711.
1166
1167 2011-04-28  Enrica Casucci  <enrica@apple.com>
1168
1169         Reviewed by Beth Dakin.
1170
1171         Momentum scroll tweak for WebKit.
1172         https://bugs.webkit.org/show_bug.cgi?id=59723
1173         <rdar://problem/9259933>
1174
1175         * WebView/WebDynamicScrollBarsView.mm:
1176         (-[WebDynamicScrollBarsView scrollWheel:]): Changed constant.
1177
1178 2011-04-27  Anders Carlsson  <andersca@apple.com>
1179
1180         Follow-up Leopard build fix.
1181
1182         * Carbon/HIViewAdapter.m:
1183         (_webkit_NSView_setNeedsDisplayInRect):
1184
1185 2011-04-27  Anders Carlsson  <andersca@apple.com>
1186
1187         More clang++ 32-bit build fixes.
1188
1189         * Carbon/CarbonWindowAdapter.mm:
1190         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1191         (-[CarbonWindowAdapter setContentView:]):
1192         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1193         * Carbon/HIViewAdapter.m:
1194         (_webkit_NSView_setNeedsDisplayInRect):
1195         * Panels/WebAuthenticationPanel.h:
1196         * Plugins/WebBaseNetscapePluginView.mm:
1197         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
1198         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1199         (getCarbonEvent):
1200         * WebCoreSupport/WebChromeClient.mm:
1201         (WebChromeClient::scrollRectIntoView):
1202         * WebCoreSupport/WebViewFactory.mm:
1203         (-[WebViewFactory accessibilityConvertScreenRect:]):
1204         * WebView/WebFrameView.mm:
1205         (-[WebFrameView _scrollToBeginningOfDocument]):
1206         (-[WebFrameView _scrollToEndOfDocument]):
1207         * WebView/WebFullScreenController.mm:
1208         (-[WebFullScreenController windowDidEnterFullscreen:]):
1209         * WebView/WebHTMLView.mm:
1210         (-[WebHTMLView _hitViewForEvent:]):
1211         (coreGraphicsScreenPointForAppKitScreenPoint):
1212         * WebView/WebPDFView.mm:
1213         (-[WebPDFView setScrollPoint:]):
1214
1215 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
1216
1217         Reviewed by Pavel Feldman.
1218
1219         REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
1220         https://bugs.webkit.org/show_bug.cgi?id=44230
1221
1222         Use RetainPtr access inspected view from the inspector one to avoid inspected view being deleted before
1223         inspector is closed.
1224
1225         * WebCoreSupport/WebInspectorClient.mm: store reference to inspected view in RetainPtr. Despite the removed
1226         comment in initWithInspectedWebView this doesn't introduce cyclic reference since there are no retaining
1227         pointers to the WebInspectorWindowController from the inspected page or from the WebInspectorClient.
1228         There is only one reference to it from WebInspectorFrontendClient which is held by the inspector
1229         front-end page.
1230
1231         Drive-by fix: removed several unused methods which are currently implemented in mac/WebInspector/WebInspector.mm
1232         (-[WebInspectorWindowController initWithInspectedWebView:]):
1233         (-[WebInspectorWindowController close]):
1234         (-[WebInspectorWindowController showWindow:]):
1235         (-[WebInspectorWindowController setAttachedWindowHeight:]):
1236         (-[WebInspectorWindowController destroyInspectorView:]):
1237
1238 2011-04-26  Sam Weinig  <sam@webkit.org>
1239
1240         Reviewed by David Hyatt.
1241
1242         Remove Datagrid from the tree
1243         https://bugs.webkit.org/show_bug.cgi?id=59543
1244
1245         * Configurations/FeatureDefines.xcconfig:
1246         Remove feature.
1247
1248 2011-04-26  Dan Bernstein  <mitz@apple.com>
1249
1250         Reviewed by Mark Rowe.
1251
1252         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
1253
1254         * Configurations/Base.xcconfig:
1255         * Configurations/CompilerVersion.xcconfig: Added.
1256
1257 2011-04-25  Adam Barth  <abarth@webkit.org>
1258
1259         Reviewed by David Levin.
1260
1261         WebKit2 should play nice with strict OwnPtrs
1262         https://bugs.webkit.org/show_bug.cgi?id=59426
1263
1264         Fix include ordering.
1265
1266         * WebView/WebDeviceOrientationProviderMock.mm:
1267
1268 2011-04-25  Adam Barth  <abarth@webkit.org>
1269
1270         Reviewed by David Levin.
1271
1272         WebKit1 should build cleanly with strict OwnPtrs
1273         https://bugs.webkit.org/show_bug.cgi?id=59424
1274
1275         * History/WebHistoryItem.mm:
1276         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1277         * Plugins/WebNetscapePluginEventHandler.h:
1278         * Plugins/WebNetscapePluginEventHandler.mm:
1279         (WebNetscapePluginEventHandler::create):
1280         * Plugins/WebNetscapePluginView.mm:
1281         (-[WebNetscapePluginView createPlugin]):
1282         * WebView/WebDeviceOrientationProviderMock.mm:
1283         * WebView/WebTextIterator.mm:
1284         (-[WebTextIterator initWithRange:]):
1285
1286 2011-04-25  Jon Lee  <jonlee@apple.com>
1287
1288         Reviewed by Maciej Stachowiak.
1289
1290         Overlay scroller hard to see on pages with dark background (59183)
1291         https://bugs.webkit.org/show_bug.cgi?id=59183
1292         <rdar://problem/8975367>
1293         
1294         * WebCoreSupport/WebSystemInterface.mm:
1295         (InitWebCoreSystemInterface): adding method to allow changing style
1296
1297 2011-04-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1298
1299         Unreviewed, rolling out r84740.
1300         http://trac.webkit.org/changeset/84740
1301         https://bugs.webkit.org/show_bug.cgi?id=59290
1302
1303         change breaks apple internal builds and is incorrect
1304         (Requested by smfr on #webkit).
1305
1306         * WebCoreSupport/WebSystemInterface.mm:
1307         (InitWebCoreSystemInterface):
1308
1309 2011-04-22  Jon Lee  <jonlee@apple.com>
1310
1311         Reviewed by Beth Dakin.
1312
1313         Overlay scroller hard to see on pages with dark background (59183)
1314         https://bugs.webkit.org/show_bug.cgi?id=59183
1315         <rdar://problem/8975367>
1316         
1317         * WebCoreSupport/WebSystemInterface.mm:
1318         (InitWebCoreSystemInterface): adding method to allow changing style
1319
1320 2011-04-19  Jer Noble  <jer.noble@apple.com>
1321
1322         Reviewed by Daniel Bates.
1323
1324         Full Screen from within an <iframe> does not cause <iframe> to resize.
1325         https://bugs.webkit.org/show_bug.cgi?id=58638
1326
1327         Tests: fullscreen/full-screen-frameset-allowed.html
1328                fullscreen/full-screen-frameset-not-allowed.html
1329
1330         Return the _element's document instead of the WKView's document, which 
1331         will be different in the case of elements within <iframe>s.
1332
1333         * WebView/WebFullScreenController.mm:
1334         (-[WebFullScreenController _document]):
1335
1336 2011-04-22  Jer Noble  <jer.noble@apple.com>
1337
1338         Reviewed by Maciej Stachowiak.
1339
1340         Disable MediaPlayerPrivateAVFoundation when using old full screen mode.
1341         https://bugs.webkit.org/show_bug.cgi?id=59147
1342
1343         Add a new user default preference, and plumb that preference down to WebCore
1344         Settings. Allow the fullScreenEnabled preference to override the new 
1345         isAVFoundationEnabled preference, so that clients of the legacy full screen
1346         mode will continue to use that mode normally.
1347
1348         * WebView/WebPreferenceKeysPrivate.h: Add new preference key.
1349         * WebView/WebPreferences.mm:
1350         (+[WebPreferences initialize]): Set the default value of new
1351             preference.
1352         (-[WebPreferences setAVFoundationEnabled:]): Added.
1353         (-[WebPreferences isAVFoundationEnabled]): Added.
1354         * WebView/WebPreferencesPrivate.h:
1355         * WebView/WebView.mm:
1356         (-[WebView _preferencesChanged:]): Update the WebCore settings with the
1357             new values from WebPreferences.
1358
1359 2011-04-22  Sam Weinig  <sam@webkit.org>
1360
1361         Reviewed by Gavin Barraclough.
1362
1363         Remove remaining uses of deprecated version of toJS
1364         https://bugs.webkit.org/show_bug.cgi?id=59170
1365
1366         * DOM/WebDOMOperations.mm:
1367         (-[DOMElement _shadowRoot:]):
1368         (-[DOMElement _ensureShadowRoot:]):
1369         Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
1370
1371 2011-04-21  Maciej Stachowiak  <mjs@apple.com>
1372
1373         Reviewed by Adam Roben.
1374
1375         Add a feature define to allow <details> and <summary> to be disabled
1376         https://bugs.webkit.org/show_bug.cgi?id=59118
1377         <rdar://problem/9257045>
1378
1379         * Configurations/FeatureDefines.xcconfig:
1380
1381 2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
1382
1383         Reviewed by Sam Weinig.
1384
1385         Add Frame* to the argument lists of canCopyCut and canPaste
1386         https://bugs.webkit.org/show_bug.cgi?id=59153
1387
1388         * WebCoreSupport/WebEditorClient.h:
1389         * WebCoreSupport/WebEditorClient.mm:
1390         (WebEditorClient::canCopyCut):
1391         (WebEditorClient::canPaste):
1392
1393 2011-04-21  Sheriff Bot  <webkit.review.bot@gmail.com>
1394
1395         Unreviewed, rolling out r82052.
1396         http://trac.webkit.org/changeset/82052
1397         https://bugs.webkit.org/show_bug.cgi?id=59135
1398
1399         New full screen api should be opt-in, not opt-out. (Requested
1400         by jernoble on #webkit).
1401
1402         * WebView/WebPreferences.mm:
1403         (+[WebPreferences initialize]):
1404
1405 2011-04-21  Beth Dakin  <bdakin@apple.com>
1406
1407         Reviewed by Dan Bernstein.
1408
1409         https://bugs.webkit.org/show_bug.cgi?id=59048
1410         Need to track whether overlay scrollbar is currently visible and in lower-
1411         righthand corner
1412         -and corresponding-
1413         <rdar://problem/9211232>
1414
1415         A new WebSystemInterface is needed for this.
1416         * WebCoreSupport/WebSystemInterface.mm:
1417         (InitWebCoreSystemInterface):
1418
1419 2011-04-21  Dirk Schulze  <krit@webkit.org>
1420
1421         Reviewed by Nikolas Zimmermann.
1422
1423         SVG feDropShadow implementation of SVG Filters 1.2
1424         https://bugs.webkit.org/show_bug.cgi?id=52513
1425
1426         * MigrateHeaders.make:
1427
1428 2011-04-20  Dominic Cooney  <dominicc@chromium.org>
1429
1430         Reviewed by Dimitri Glazkov.
1431
1432         layoutTestController can create and destroy shadow DOM
1433         https://bugs.webkit.org/show_bug.cgi?id=59058
1434
1435         Support for new methods in Mac DRT.
1436
1437         * DOM/WebDOMOperations.mm:
1438         (-[DOMElement _ensureShadowRoot:]):
1439         (-[DOMElement _removeShadowRoot]):
1440         * DOM/WebDOMOperationsPrivate.h:
1441
1442 2011-04-20  Eric Carlson  <eric.carlson@apple.com>
1443
1444         Reviewed by Dan Bernstein.
1445
1446         Adopt QTKit API for listing and deleting file in its media cache.
1447         <rdar://problem/9130029> 
1448
1449         * WebCoreSupport/WebSystemInterface.mm:
1450         (InitWebCoreSystemInterface): Initialize new functions.
1451
1452 2011-04-19  Matthew Delaney  <mdelaney@apple.com>
1453
1454         Reviewed by Simon Fraser.
1455
1456         WebPreferences in WebKit1 should have CanvasUsesAcceleratedDrawing set to NO by default
1457         https://bugs.webkit.org/show_bug.cgi?id=58936
1458
1459         * WebView/WebPreferences.mm:
1460         (+[WebPreferences initialize]):
1461
1462 2011-04-19  Vsevolod Vlasov  <vsevik@chromium.org>
1463
1464         Reviewed by Pavel Feldman.
1465
1466         Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
1467         https://bugs.webkit.org/show_bug.cgi?id=58883
1468
1469         * WebCoreSupport/WebFrameLoaderClient.h:
1470         * WebCoreSupport/WebFrameLoaderClient.mm:
1471         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1472
1473 2011-04-18  Jia Pu  <jpu@apple.com>
1474
1475         Reviewed by Mark Rowe.
1476
1477         WebKit needs to stop importing <AppKit/NSTextChecker.h>
1478         https://bugs.webkit.org/show_bug.cgi?id=58798
1479         <rdar://problem/9294938>
1480
1481         Use public header <AppKit/NSSpellChecker.h> instead.
1482
1483         * WebCoreSupport/CorrectionPanel.h:
1484         * WebCoreSupport/CorrectionPanel.mm:
1485         (correctionIndicatorType):
1486         (CorrectionPanel::show):
1487         (CorrectionPanel::dismissInternal):
1488         (CorrectionPanel::handleAcceptedReplacement):
1489         * WebCoreSupport/WebEditorClient.mm:
1490         * WebView/WebView.mm:
1491
1492 2011-04-17  Cameron Zwarich  <zwarich@apple.com>
1493
1494         Reviewed by Timothy Hatcher.
1495
1496         Stop using -[NSString initWithContentsOfFile:]
1497         https://bugs.webkit.org/show_bug.cgi?id=58763
1498
1499         -[NSString initWithContentsOfFile:] was deprecated in 10.4, so we should stop using it.
1500
1501         * WebView/WebView.mm:
1502         (leakMailQuirksUserScriptContents):
1503         (leakOutlookQuirksUserScriptContents):
1504
1505 2011-04-17  David Kilzer  <ddkilzer@apple.com>
1506
1507         <http://webkit.org/b/58463> Switch HTTP pipelining from user default to private setting
1508         <rdar://problem/9268729>
1509
1510         Reviewed by Dan Bernstein.
1511
1512         This replaces support for the WebKitEnableHTTPPipelining user
1513         default with methods on the WebCore::ResourceRequest class in
1514         WebCore, the WebView class in WebKit1, and the WebContext class
1515         in WebKit2.  It also removes support for the
1516         WebKitForceHTTPPipeliningPriorityHigh user default which was not
1517         needed.
1518
1519         * WebView/WebView.mm:
1520         (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added.
1521         (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added.
1522         * WebView/WebViewPrivate.h:
1523         (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added declaration.
1524         (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added declaration.
1525
1526 2011-04-17  Joseph Pecoraro  <joepeck@webkit.org>
1527
1528         Reviewed by Dan Bernstein.
1529
1530         Assign to self in WebInspectorWindowController constructors
1531         https://bugs.webkit.org/show_bug.cgi?id=58749
1532
1533         * WebCoreSupport/WebInspectorClient.mm:
1534         (-[WebInspectorWindowController init]):
1535         (-[WebInspectorWindowController initWithInspectedWebView:]):
1536
1537 2011-04-17  Joseph Pecoraro  <joepeck@webkit.org>
1538
1539         Reviewed by Timothy Hatcher.
1540
1541         Move WebNodeHighlighter into its own file
1542         https://bugs.webkit.org/show_bug.cgi?id=58746
1543
1544         Extract this class into its own file alongside the
1545         other WebNodeHighlight files. In doing so do some
1546         cleanup on WebInspectorClient removing some methods
1547         that were never called.
1548
1549         * WebCoreSupport/WebInspectorClient.mm:
1550         (WebInspectorClient::WebInspectorClient): style fix.
1551         * WebInspector/WebNodeHighlighter.h: Added.
1552         * WebInspector/WebNodeHighlighter.mm: Added.
1553         (-[WebNodeHighlighter initWithInspectedWebView:]): call super init.
1554         (-[WebNodeHighlighter dealloc]):
1555         (-[WebNodeHighlighter highlightNode:]):
1556         (-[WebNodeHighlighter hideHighlight]):
1557         (-[WebNodeHighlighter didAttachWebNodeHighlight:]):
1558         (-[WebNodeHighlighter willDetachWebNodeHighlight:]):
1559
1560 2011-04-15  Jia Pu  <jpu@apple.com>
1561
1562         Reviewed by Dan Bernstein.
1563
1564         [Mac] WebKit needs to convert the bounding box of autocorrected word to view coordinate.
1565         https://bugs.webkit.org/show_bug.cgi?id=58717
1566
1567         Convert the bounding box from window coordinate to view coordinate, which is expected by NSCorrectionPanel.
1568
1569         * WebCoreSupport/CorrectionPanel.mm:
1570         (CorrectionPanel::show):
1571
1572 2011-04-15  Shishir Agrawal  <shishir@chromium.org>
1573
1574         Reviewed by James Robinson.
1575
1576         Add a flag to guard Page Visibility API changes.
1577         https://bugs.webkit.org/show_bug.cgi?id=58464
1578
1579         * Configurations/FeatureDefines.xcconfig:
1580
1581 2011-04-15  Oliver Hunt  <oliver@apple.com>
1582
1583         GC allocate Structure
1584         https://bugs.webkit.org/show_bug.cgi?id=58483
1585
1586         Rolling r83894 r83827 r83810 r83809 r83808 back in with
1587         a workaround for the gcc bug seen by the gtk bots
1588
1589         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1590         * Plugins/Hosted/ProxyInstance.mm:
1591         (WebKit::ProxyRuntimeMethod::createStructure):
1592         * Plugins/Hosted/ProxyRuntimeObject.h:
1593         (WebKit::ProxyRuntimeObject::createStructure):
1594
1595 2011-04-14  Alexey Proskuryakov  <ap@apple.com>
1596
1597         Reviewed by Dan Bernstein.
1598
1599         WebKit2: Password field input does not switch to ASCII-compatible source
1600         https://bugs.webkit.org/show_bug.cgi?id=58583
1601         <rdar://problem/9059651>
1602
1603         Now that WebCore doesn't set secure input mode, WebKit has to. Happily, it already has the
1604         necessary logic, needed to return a nil text input context when in password fields.
1605
1606         * WebView/WebHTMLView.mm:
1607         (-[WebHTMLView close]): If the view is still enforcing secure event mode, stop.
1608         (-[WebHTMLView windowDidBecomeKey:]): Call _updateSecureInputState.
1609         (-[WebHTMLView windowDidResignKey:]): Ditto.
1610         (-[WebHTMLView becomeFirstResponder]): Call _updateSecureInputState. It's a bit tricky
1611         because the first responder is still different an this point, so set a boolean variable to
1612         let _updateSecureInputState know what's going on.
1613         (-[WebHTMLView resignFirstResponder]): Disable secure event mode if it's on.
1614         (-[WebHTMLView _updateSecureInputState]): Update HIToolbox secure event input state and
1615         allowed input sources accorsing to current selection.
1616         (-[WebHTMLView _updateSelectionForInputManager]): Call _updateSecureInputState.
1617
1618 2011-04-15  Sam Weinig  <sam@webkit.org>
1619
1620         Reviewed by Maciej Stachowiak.
1621
1622         Make mac WebKit1 use the default localization strategy
1623         https://bugs.webkit.org/show_bug.cgi?id=58628
1624
1625         * WebCoreSupport/WebPlatformStrategies.h:
1626         * WebCoreSupport/WebPlatformStrategies.mm:
1627         Remove the localization strategy code. The equivalent is now
1628         in WebCore/platform/DefaultLocalizationStrategy.cpp.
1629
1630 2011-04-15  Anna Cavender  <annacc@chromium.org>
1631
1632         Reviewed by Eric Carlson.
1633
1634         Renaming TRACK feature define to VIDEO_TRACK
1635         https://bugs.webkit.org/show_bug.cgi?id=53556
1636
1637         * Configurations/FeatureDefines.xcconfig:
1638
1639 2011-04-14  Pratik Solanki  <psolanki@apple.com>
1640
1641         Reviewed by David Kilzer.
1642
1643         Set minimum priority for fast lane connections
1644         https://bugs.webkit.org/show_bug.cgi?id=58353
1645
1646         * WebCoreSupport/WebSystemInterface.mm:
1647         (InitWebCoreSystemInterface): Support for new WKSI method WKSetHTTPPipeliningMinimumFastLanePriority.
1648
1649 2011-04-13  Sam Weinig  <sam@webkit.org>
1650
1651         Reviewed by Gavin Barraclough.
1652
1653         WebKit2 doesn't keep overlay scrollers shown while scroll gesture held
1654         <rdar://problem/9260518>
1655
1656         * WebCoreSupport/WebSystemInterface.mm:
1657         (InitWebCoreSystemInterface):
1658         Initialize new WKSI functions.
1659
1660 2011-04-13  David Kilzer  <ddkilzer@apple.com>
1661
1662         <http://webkit.org/b/58172> Fix -Wcast-align warning in WebBasePluginPackage.mm
1663
1664         Reviewed by Anders Carlsson.
1665
1666         Fixes the following warning with -Wcast-align enabled:
1667
1668             Source/WebKit/mac/Plugins/WebBasePluginPackage.mm:402:21:{402:21-402:93}{402:39-402:93}: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'struct fat_arch *' increases required alignment from 1 to 4 [-Werror,-Wcast-align,3]
1669                          archs = (struct fat_arch*)((uint8_t*)rawData.data() + sizeof(struct fat_header));
1670                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1671
1672         * Plugins/WebBasePluginPackage.mm:
1673         (-[WebBasePluginPackage isNativeLibraryData:]): Added
1674         COMPILE_ASSERT() to make sure our pointer math is valid.
1675         Removed cast to (uint8_t*) and divide sizeof(struct fat_header)
1676         by sizeof(uint32_t) to fix the pointer math.  Replaced C-style
1677         casts with reinterpret_cast.
1678
1679 2011-04-12  Enrica Casucci  <enrica@apple.com>
1680
1681         Reviewed by Alexey Proskuryakov.
1682
1683         Infinite recursion in WebHTMLView executeSavedKeypressCommands.
1684         https://bugs.webkit.org/show_bug.cgi?id=58382
1685         <rdar://problem/9239370>
1686
1687         Execution of some editing commands could trigger a call to selectedRange that
1688         internally calls executeSavedKeypressCommands creating an infinite recursion.
1689
1690         * WebView/WebHTMLView.mm:
1691         (-[WebHTMLView _executeSavedKeypressCommands]): Added a flag to avoid recursion.
1692         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added flag initialization.
1693
1694 2011-04-12  Alice Liu  <alice.liu@apple.com>
1695
1696         Reviewed by Sam Weinig.
1697
1698         https://bugs.webkit.org/show_bug.cgi?id=58292
1699         Provide new setting to allow site icon loading despite disabling automatic image loading in general.
1700
1701         * WebView/WebPreferenceKeysPrivate.h: Add preference key.
1702         * WebView/WebPreferences.mm:
1703         (+[WebPreferences initialize]): Initialize to false.
1704         (-[WebPreferences setLoadsSiteIconsIgnoringImageLoadingPreference:]): Added.
1705         (-[WebPreferences loadsSiteIconsIgnoringImageLoadingPreference]): Added.
1706         * WebView/WebPreferencesPrivate.h: Add setter/getter definitions.
1707         * WebView/WebView.mm:
1708         (-[WebView _preferencesChanged:]): Add to settings that get propagated upon changes. 
1709
1710 2011-04-11  Alexey Proskuryakov  <ap@apple.com>
1711
1712         Reviewed by Maciej Stachowiak.
1713
1714         WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
1715         https://bugs.webkit.org/show_bug.cgi?id=58175
1716         <rdar://problem/9060555>
1717
1718         * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
1719         should be changed to match WebKit2.
1720
1721 2011-04-06  Timothy Hatcher  <timothy@apple.com>
1722
1723         Fix a bug where the context menu does not show in PDF documents if there is no
1724         UI delegate or the UI delegate does not respond to the context menu selector.
1725
1726         https://webkit.org/b/57958
1727
1728         Reviewed by Darin Adler.
1729
1730         * WebView/WebView.mm:
1731         (-[WebView _menuForElement:defaultItems:]): CallUIDelegate returns nil
1732         if UIDelegate is nil or doesn't respond to the selector. So check that
1733         here to distinguish between using defaultMenuItems or the delegate
1734         really returning nil to say "no context menu".
1735
1736 2011-04-11  Jer Noble  <jer.noble@apple.com>
1737
1738         Unreviewed; roll out unintentional change to WebFullScreenController.mm.
1739
1740         * WebView/WebFullScreenController.mm:
1741         (-[WebFullScreenController enterFullscreen:]):
1742
1743 2011-04-08  Geoffrey Garen  <ggaren@apple.com>
1744
1745         Reviewed by Oliver Hunt.
1746
1747         A few heap-related renames and file moves.
1748         
1749         WeakGCPtr<T> => Weak<T>
1750         Global<T> => Strong<T>
1751         collector/ => heap/
1752         collector/* => heap/*
1753         runtime/WeakGCPtr.h => heap/Weak.h
1754         
1755         (Eventually, even more files should move into the heap directory. Like
1756         Heap.h and Heap.cpp, for example.)
1757
1758         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1759         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1760         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
1761         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
1762         (WebKit::NetscapePluginInstanceProxy::evaluate):
1763         * WebView/WebScriptDebugger.h:
1764
1765 2011-04-08  Alexey Proskuryakov  <ap@apple.com>
1766
1767         Reviewed by Darin Adler.
1768
1769         WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
1770         https://bugs.webkit.org/show_bug.cgi?id=58175
1771         <rdar://problem/9060555>
1772
1773         * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
1774         should be changed to match WebKit2.
1775
1776 2011-04-08  Alpha Lam  <hclam@chromium.org>
1777
1778         Unreviewed, rolling out r83335.
1779         http://trac.webkit.org/changeset/83335
1780         https://bugs.webkit.org/show_bug.cgi?id=53556
1781
1782         GTK and QT bots are broken
1783
1784         * Configurations/FeatureDefines.xcconfig:
1785
1786 2011-04-07  Anna Cavender  <annacc@chromium.org>
1787
1788         Reviewed by Eric Carlson.
1789
1790         Setup ENABLE(TRACK) feature define
1791         https://bugs.webkit.org/show_bug.cgi?id=53556
1792
1793         * Configurations/FeatureDefines.xcconfig:
1794
1795 2011-04-08  Maciej Stachowiak  <mjs@apple.com>
1796
1797         Reviewed by Darin Adler.
1798
1799         -[WebView setPreferences:] can take a lot of time if loading lots of webviews at once
1800         https://bugs.webkit.org/show_bug.cgi?id=58128
1801         <rdar://problem/9244553>
1802         
1803         The root of the problem here was an O(N^2) issue - each WebView,
1804         upon having its preferences initialized, would broadcast a
1805         notification that was listened to by all other WebViews sharing
1806         its preferences.
1807         
1808         To maintain the API contract, I split the notification into two,
1809         one that is for public API consumption, and the other which is for
1810         internal use only. Changes that don't need to be picked up by
1811         other WebViews broadcast the public notification only. And we
1812         avoid WebView broadcasting a notification just to get itself to
1813         update.
1814
1815         * Misc/WebIconDatabase.mm:
1816         (-[WebIconDatabase _startUpIconDatabase]):
1817         (-[WebIconDatabase _shutDownIconDatabase]):
1818         * Plugins/WebBaseNetscapePluginView.mm:
1819         (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
1820         (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]):
1821         (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
1822         (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]):
1823         * WebView/WebPreferences.mm:
1824         (-[WebPreferences initWithIdentifier:]):
1825         (-[WebPreferences _setStringValue:forKey:]):
1826         (-[WebPreferences _setIntegerValue:forKey:]):
1827         (-[WebPreferences _setFloatValue:forKey:]):
1828         (-[WebPreferences _setBoolValue:forKey:]):
1829         (-[WebPreferences _setLongLongValue:forKey:]):
1830         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
1831         (-[WebPreferences _postPreferencesChangedNotification]):
1832         (-[WebPreferences _postPreferencesChangedAPINotification]):
1833         * WebView/WebPreferencesPrivate.h:
1834         * WebView/WebView.mm:
1835         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
1836         (-[WebView _preferencesChangedNotification:]):
1837         (-[WebView _preferencesChanged:]):
1838         (-[WebView setUsesPageCache:]):
1839         (+[WebView initialize]):
1840         (-[WebView setPreferences:]):
1841         (-[WebView _keyboardUIMode]):
1842         * WebView/WebViewInternal.h:
1843
1844 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
1845
1846         Revert ENABLE_TRACK patch due to compile failures.
1847
1848         * Configurations/FeatureDefines.xcconfig:
1849
1850 2011-04-07  Alexey Proskuryakov  <ap@apple.com>
1851
1852         Reviewed by Anders Carlsson.
1853
1854         REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
1855         https://bugs.webkit.org/show_bug.cgi?id=58066
1856         <rdar://problem/8965302>
1857
1858         * WebView/WebHTMLRepresentation.mm:
1859         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
1860         * WebView/WebHTMLView.mm:
1861         (-[WebHTMLView attributedSubstringFromRange:]):
1862         (-[WebHTMLView attributedString]):
1863         (-[WebHTMLView selectedAttributedString]):
1864         Updated for editingAttributedStringFromRange: now taking a WebCore::Range instead of DOMRange.
1865
1866 2011-04-07  Andy Estes  <aestes@apple.com>
1867
1868         Reviewed by Darin Adler.
1869
1870         REGRESSION (r64712): Microsoft Outlook 2011: original message contents
1871         not included when replying to an email.
1872         https://bugs.webkit.org/show_bug.cgi?id=57794
1873         
1874         Outlook populates a reply message by creating an empty WebView and
1875         using DOM API to populate the WebView's empty document with content
1876         from the original message. It expects the initial empty document to
1877         simply be "<html></html>", and it proceeds to dynamically create and
1878         append a BODY node and add the original message content as a child of
1879         that node. Outlook then takes the innerHTML of the frame's first body
1880         element and copies it into a *new* document that is displayed and
1881         edited in the reply message window.
1882         
1883         Due to implementing the HTML5 tree building algorithm in r64712,
1884         initial empty documents went from being "<html></html>" to being
1885         "<html><head></head><body></body></html>". Outlook still dynamically
1886         creates a BODY node to parent the original message content, but this
1887         BODY node duplicates the one created by the tree builder. When Outlook
1888         then takes the innerHTML of the first body element to populate the
1889         reply message window it gets the empty body element created by the
1890         parser, not the one it created with the original message content.
1891         
1892         Fix this by injecting a user script into the initial empty document
1893         that removes the HEAD and BODY nodes created by the parser. This
1894         ensures that the BODY created by Outlook is the only BODY in the
1895         document.
1896
1897         * Misc/OutlookQuirksUserScript.js: Added.
1898         * WebView/WebView.mm:
1899         (leakMailQuirksUserScriptContents):
1900         (-[WebView _injectMailQuirksScript]):
1901         (needsOutlookQuirksScript):
1902         (leakOutlookQuirksUserScriptContents):
1903         (-[WebView _injectOutlookQuirksScript]):
1904         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
1905
1906 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
1907
1908         Reviewed by David Levin.
1909
1910         Add QUOTA build flag for unified quota API
1911         https://bugs.webkit.org/show_bug.cgi?id=57918
1912
1913         * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
1914
1915 2011-04-06  Robert Sesek  <rsesek@chromium.org>
1916
1917         Reviewed by Alexey Proskuryakov.
1918
1919         Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
1920         https://bugs.webkit.org/show_bug.cgi?id=54969
1921
1922         * WebView/WebFrame.mm:
1923         (-[WebFrame _convertToNSRange:]): Moved duplicated code to WebCore
1924         (-[WebFrame _characterRangeAtPoint:]): Moved duplicated code to WebCore
1925
1926 2011-04-05  Alexey Proskuryakov  <ap@apple.com>
1927
1928         Reviewed by Darin Adler.
1929
1930         Move attributedStringFromRange down to WebCore
1931         https://bugs.webkit.org/show_bug.cgi?id=57905
1932
1933         * Misc/WebNSAttributedStringExtras.h: Removed.
1934         * Misc/WebNSAttributedStringExtras.mm: Removed.
1935         * WebView/WebHTMLRepresentation.mm:
1936         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
1937         * WebView/WebHTMLView.mm:
1938         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1939         (-[WebHTMLView attributedSubstringFromRange:]):
1940         (-[WebHTMLView attributedString]):
1941         (-[WebHTMLView selectedAttributedString]):
1942         * WebView/WebPDFView.mm:
1943         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1944
1945 2011-04-04  MORITA Hajime  <morrita@google.com>
1946
1947         Reviewed by Ryosuke Niwa.
1948
1949         [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
1950         https://bugs.webkit.org/show_bug.cgi?id=56085
1951
1952         Removed NSTextCheckingResult to SpellCheckingResult convertion, and extracted
1953         NSTextCheckingResult to TextCheckingResult convertio from checkTextOfParagraph method.
1954         for requestCheckingOfString method.
1955         
1956         * WebCoreSupport/WebEditorClient.h:
1957         * WebCoreSupport/WebEditorClient.mm:
1958         (toCoreTextCheckingResults):
1959         (WebEditorClient::checkTextOfParagraph):
1960         (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:types:WebCore::results:]):
1961         (-[WebEditorSpellCheckResponder perform]):
1962         (WebEditorClient::requestCheckingOfString):
1963         * WebView/WebFrame.mm:
1964         (-[WebFrame markersForSelectionStartAsText]):
1965         * WebView/WebFramePrivate.h:
1966
1967 2011-04-05  Anders Carlsson  <andersca@apple.com>
1968
1969         Didn't mean to land this.
1970
1971         * Plugins/WebNetscapePluginView.mm:
1972         (-[WebNetscapePluginView getVariable:value:]):
1973
1974 2011-04-04  David Kilzer  <ddkilzer@apple.com>
1975
1976         <http://webkit.org/b/57384> CFNetwork and WebCore load priorities should match
1977
1978         Reviewed by Alexey Proskuryakov.
1979
1980         * WebCoreSupport/WebSystemInterface.mm:
1981         (InitWebCoreSystemInterface): Added initialization for
1982         wkSetHTTPPipeliningMaximumPriority().
1983
1984 2011-04-04  Alexey Proskuryakov  <ap@apple.com>
1985
1986         Reviewed by Dan Bernstein.
1987
1988         REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
1989         https://bugs.webkit.org/show_bug.cgi?id=51230
1990         <rdar://problem/8780989>
1991
1992         * WebView/WebHTMLView.mm: (-[WebHTMLView flagsChanged:]): Moved Caps Lock handling from
1993         WebKits to WebCore, because WebKit shouldn't be smart.
1994
1995 2011-04-01  Alexey Proskuryakov  <ap@apple.com>
1996
1997         Reviewed by Darin Adler.
1998
1999         REGRESSION: Assertion failure when executing a complex custom key binding
2000         https://bugs.webkit.org/show_bug.cgi?id=57681
2001
2002         * WebView/WebHTMLView.mm: (-[WebHTMLView hasMarkedText]): There is no need to execute saved
2003         commands when they can't possibly change the result.
2004
2005 2011-04-01  Anders Carlsson  <andersca@apple.com>
2006
2007         Reviewed by Sam Weinig.
2008
2009         Shockwave plug-in doesn't accept mouse events
2010         https://bugs.webkit.org/show_bug.cgi?id=57653
2011         <rdar://problem/8483273>
2012
2013         Fix an unrelated bug found by the added test.
2014
2015         * Plugins/WebBaseNetscapePluginView.mm:
2016         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
2017         Make sure to always set destX and destY.
2018
2019 2011-04-01  Alexey Proskuryakov  <ap@apple.com>
2020
2021         Reviewed by Darin Adler.
2022
2023         Make WebKit2 text input handling more like WebKit1
2024         https://bugs.webkit.org/show_bug.cgi?id=57649
2025
2026         * WebView/WebFrameInternal.h: Expose _convertToDOMRange for use in WebHTMLView.
2027         * WebView/WebHTMLView.mm:
2028         (-[WebHTMLView _executeSavedKeypressCommands]): Renamed, since these are not editor commands.
2029         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for the renamed _executeSavedKeypressCommands.
2030         (-[WebHTMLView characterIndexForPoint:]): Ditto.
2031         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2032         (-[WebHTMLView selectedRange]): Ditto.
2033         (-[WebHTMLView markedRange]): Ditto.
2034         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2035         (-[WebHTMLView hasMarkedText]): Ditto.
2036         (-[WebHTMLView unmarkText]): Ditto.
2037         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. Changed the comment about the argument
2038         type into an assertion. Removed resetting interpretKeyEventsParameters to 0, as we shouldn't
2039         be able to call text input protocol methods from here (and we didn't even reset it back on
2040         return). Changed to retrieve all data before starting to apply actions to better match WK2 code.
2041         (-[WebHTMLView insertText:]): Ditto.
2042
2043 2011-04-01  Timothy Hatcher  <timothy@apple.com>
2044
2045         Make momentum scroll event latching work in WebKit2 on Mac.
2046
2047         <rdar://problem/8751861>
2048
2049         Reviewed by Darin Adler.
2050
2051         * WebCoreSupport/WebSystemInterface.mm:
2052         (InitWebCoreSystemInterface): Remove IsLatchingWheelEvent, add GetNSEventMomentumPhase.
2053         * WebView/WebDynamicScrollBarsView.mm:
2054         (-[WebDynamicScrollBarsView scrollWheel:]): Use WKGetNSEventMomentumPhase to set isLatchingEvent.
2055
2056 2011-03-31  Darin Adler  <darin@apple.com>
2057
2058         Reviewed by Anders Carlsson.
2059
2060         Assertion failure in -[WebHTMLView _handleStyleKeyEquivalent:]
2061         https://bugs.webkit.org/show_bug.cgi?id=26667
2062
2063         * WebView/WebHTMLView.mm:
2064         (-[WebHTMLView _handleStyleKeyEquivalent:]): Handle the case where WebView is
2065         nil rather than asserting that it is non-nil. One case where WebView will be nil
2066         is when the frame is closed, but in any case where it is nil, the correct thing
2067         to do is to not try to handle the style key.
2068
2069 2011-03-31  Alexey Proskuryakov  <ap@apple.com>
2070
2071         Patch by John Harvey, reviewed and tweaked by me.
2072
2073         <rdar://problem/8644403> Should notify TSM that plug-ins would show a bottom input window for marked text.
2074
2075         * Plugins/Hosted/WebTextInputWindowController.m:
2076         (-[WebTextInputPanel _interpretKeyEvent:string:]):
2077
2078 2011-03-31  Evan Martin  <evan@chromium.org>
2079
2080         Reviewed by Eric Seidel.
2081
2082         <title> should support dir attribute
2083         https://bugs.webkit.org/show_bug.cgi?id=50961
2084
2085         Update to new FrameLoaderClient interface.
2086
2087         * WebCoreSupport/WebFrameLoaderClient.h:
2088         * WebCoreSupport/WebFrameLoaderClient.mm:
2089         (WebFrameLoaderClient::dispatchDidReceiveTitle):
2090         (WebFrameLoaderClient::setTitle):
2091
2092 2011-03-30  Dominic Cooney  <dominicc@google.com>
2093
2094         Reviewed by Dimitri Glazkov.
2095
2096         Adds layoutTestController.shadowRoot accessor to Mac DRT.
2097         https://bugs.webkit.org/show_bug.cgi?id=57415
2098
2099         * DOM/WebDOMOperations.mm:
2100         (-[DOMElement _shadowRoot:]):
2101         * DOM/WebDOMOperationsPrivate.h:
2102
2103 2011-03-30  Alexey Proskuryakov  <ap@apple.com>
2104
2105         Reviewed by Darin Adler.
2106
2107         WebHTMLView shouldn't resend noop: commands
2108         https://bugs.webkit.org/show_bug.cgi?id=57504
2109         <rdar://problem/9209390>
2110
2111         * WebView/WebHTMLView.mm: (-[WebHTMLView _executeSavedEditingCommands]): Filter out NOOPs,
2112         which we get e.g. when handling Cmd-key combos.
2113
2114 2011-03-30  Alexey Proskuryakov  <ap@apple.com>
2115
2116         Reviewed by Darin Adler.
2117
2118         REGRESSION (r82320): Spacebar no longer pages down
2119         https://bugs.webkit.org/show_bug.cgi?id=57423
2120         <rdar://problem/9207702>
2121
2122         Also includes some unrelated cleanup that I had in my tree.
2123
2124         * WebView/WebHTMLView.mm:
2125         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added an assertion that the event is
2126         being dispatched to the right frame.
2127         (-[WebHTMLView setMarkedText:selectedRange:]): Use 0 for a pointer, not NULL.
2128         (-[WebHTMLView doCommandBySelector:]): Update eventInterpretationHadSideEffects with "|=".
2129         Even if this specific command hasn't been handled, that doesn't nullify side effects from
2130         previous commands.
2131         (-[WebHTMLView insertText:]): Besides looking at the return value of insertText() to fix the
2132         bug, removed setting _private->interpretKeyEventsParameters to 0. I don't see any way for
2133         another WebHTMLView NSTextInput method to be called from within insertText:, so no one is
2134         going to look at it.
2135
2136 2011-03-30  Sam Weinig  <sam@webkit.org>
2137
2138         Reviewed by Brady Eidson.
2139
2140         WebKit2: Attempting to view css file from url causes it to download
2141         <rdar://problem/9102611>
2142         https://bugs.webkit.org/show_bug.cgi?id=57501
2143
2144         * WebView/WebHTMLRepresentation.h:
2145         * WebView/WebHTMLRepresentation.mm:
2146         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2147         * WebView/WebHTMLView.mm:
2148         (+[WebHTMLView unsupportedTextMIMETypes]):
2149         Re-factor unsupportedTextMIMETypes to pull from WebCore's
2150         MIMETypeRegistry, so that the list can be shared with WebKit2.
2151
2152 2011-03-29  Beth Dakin  <bdakin@apple.com>
2153
2154         Reviewed by Maciej Stachowiak.
2155
2156         Fix for https://bugs.webkit.org/show_bug.cgi?id=57408 
2157         webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard 
2158         -and corresponding-
2159         <rdar://problem/8665411>
2160
2161         * Misc/WebNSControlExtras.m:
2162         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2163         * WebCoreSupport/WebChromeClient.mm:
2164         (WebChromeClient::scaleFactor):
2165         * WebView/WebHTMLView.mm:
2166         (-[WebHTMLView viewDidMoveToWindow]):
2167         (-[WebHTMLView attachRootLayer:]):
2168
2169 2011-03-29  Kent Tamura  <tkent@chromium.org>
2170
2171         Reviewed by Dimitri Glazkov.
2172
2173         Make validation message bubble testable
2174         https://bugs.webkit.org/show_bug.cgi?id=57290
2175
2176         * WebView/WebView.mm:
2177         (-[WebView _preferencesChangedNotification:]): Copy the private value of
2178           the timer magnification to WebCore::Settings.
2179         (-[WebView validationMessageTimerMagnification]): Added.
2180         (-[WebView setValidationMessageTimerMagnification:]): Added.
2181         * WebView/WebViewData.h: Declare a member for the timer magnification.
2182         * WebView/WebViewData.mm:
2183         (-[WebViewPrivate init]): Initialize the timer magnification.
2184         * WebView/WebViewPrivate.h:
2185           Declare a setter and a getter for the timer magnification.
2186
2187 2011-03-29  Kent Tamura  <tkent@chromium.org>
2188
2189         Reviewed by Dimitri Glazkov.
2190
2191         [Mac] Enable interactive-validation tests on Mac DRT
2192         https://bugs.webkit.org/show_bug.cgi?id=57308
2193
2194         * WebView/WebView.mm:
2195         (-[WebView _preferencesChangedNotification:]):
2196           Convey a WebView flag for interactive validation to WebCore::Settings.
2197         (-[WebView interactiveFormValidationEnabled]): Added.
2198         (-[WebView setInteractiveFormValidationEnabled:]): Added.
2199         * WebView/WebViewData.h: Add interactiveFormValidationEnabled.
2200         * WebView/WebViewData.mm:
2201         (-[WebViewPrivate init]): Initialize interactiveFormValidationEnabled.
2202         * WebView/WebViewPrivate.h: Add setter and getter for interactiveFormValidationEnabled.
2203
2204 2011-03-29  Timothy Hatcher  <timothy@apple.com>
2205
2206         Update the order of the context menu to better match AppKit on Mac.
2207
2208         <rdar://problem/9054893>
2209
2210         Reviewed by John Sullivan.
2211
2212         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2213         (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Update the order of items.
2214         * WebCoreSupport/WebPlatformStrategies.h:
2215         * WebCoreSupport/WebPlatformStrategies.mm:
2216         (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): Added argument for selected string.
2217
2218 2011-03-29  Alexey Proskuryakov  <ap@apple.com>
2219
2220         Reviewed by Darin Adler.
2221
2222         https://bugs.webkit.org/show_bug.cgi?id=57379
2223         Clean up WK1 key event handling logic
2224
2225         No bugs knowingly fixed, but this makes the code more consistent.
2226
2227         * WebView/WebHTMLView.mm:
2228         (struct WebHTMLViewInterpretKeyEventsParameters): Renamed eventWasHandled to
2229         eventInterpretationHadSideEffects, because "handled" doesn't really mean much.
2230         (-[WebHTMLView _executeSavedEditingCommands]): Factored out from _interpretKeyEvent for use
2231         from other functions. We need to execute saved commands when an input method asks for current
2232         state, because providing stale state could confuse it.
2233         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Heavily commented, and updated for other
2234         changes.
2235         (-[WebHTMLView characterIndexForPoint:]): Call _executeSavedEditingCommands, because otherwise,
2236         the answer would be stale.
2237         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2238         (-[WebHTMLView selectedRange]): Ditto.
2239         (-[WebHTMLView markedRange]): Ditto.
2240         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2241         (-[WebHTMLView hasMarkedText]): Ditto.
2242         (-[WebHTMLView unmarkText]): Call _executeSavedEditingCommands, because otherwise, we'd be
2243         operating on stale data. Also, updated for eventWasHandled renaming.
2244         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2245         (-[WebHTMLView doCommandBySelector:]): Removed special handling for noop:. I verified that
2246         it's no longer needed for bug 14522, presumably due to WebCore level changes. It was also
2247         fragile, because there is no guarantee about when noop: is sent (also, a custom key binding
2248         could have a noop: as one of its commands, although that's hardly practical).
2249         Added the same "from input method" logic that we have in insertText: - I don't know of any
2250         IMs that call this method, but we clearly need to execute it as part of IM processing when
2251         there is marked text.
2252         (-[WebHTMLView insertText:]): Removed a confusing check for [text length]. Always set
2253         eventInterpretationHadSideEffects to true, becasue there is no reason to try multiple times
2254         if current selection isn't editable. This is different from doCommandBySelector:, where we
2255         need to give super class a chance to handle the event if our processing fails.
2256         Removed a nonsense "consumedByIM = true" assignment - we no longer need it now that the
2257         return value of _interpretKeyEvent is computed differently.
2258
2259 2011-03-28  Adele Peterson  <adele@apple.com>
2260
2261         Reviewed by Eric Seidel.
2262
2263         Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
2264         https://bugs.webkit.org/show_bug.cgi?id=57173
2265
2266         * WebView/WebFrame.mm:
2267         (-[WebFrame hasSpellingMarker:length:]): Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
2268         (-[WebFrame hasGrammarMarker:length:]): Call new selectionStartHasMarkerFor method.
2269         * WebView/WebFramePrivate.h: Add hasGrammarMarker so grammar marking can be tested.
2270
2271 2011-03-28  Alexey Proskuryakov  <ap@apple.com>
2272
2273         Reviewed by Darin Adler.
2274
2275         https://bugs.webkit.org/show_bug.cgi?id=57260
2276         Clean up text input code a little
2277
2278         * WebCoreSupport/WebEditorClient.mm:
2279         (WebEditorClient::handleKeyboardEvent):
2280         (WebEditorClient::handleInputMethodKeydown):
2281         * WebView/WebHTMLViewInternal.h:
2282         Renamed _interceptEditingKeyEvent:shouldSaveCommand:, becasue it doesn't really intercept
2283         anything. It's just a version it interpretKeyEvents: that tells us whether it was handled,
2284         and also possibly saves resulting commands for later execution.
2285
2286         * WebView/WebHTMLView.mm:
2287         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Changed to use early return. Changed
2288         return value in case platformEvent is null to be less mysterious. Moved receivedNOOP from
2289         WebHTMLViewPrivate to WebHTMLViewInterpretKeyEventsParameters, as this is just part of event
2290         handling state, like the other booleans there. Don't call interpretKeyEvents: again simply
2291         because the first call resulted in no saved commands, becasue it's confusing and apparently
2292         useless (I couldn't find any broken behavior).
2293         (-[WebHTMLView unmarkText]): Cleaned upo BOOL vs. bool constants.
2294         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2295         (-[WebHTMLView doCommandBySelector:]): Ditto.
2296         (-[WebHTMLView insertText:]): Ditto.
2297
2298         * WebView/WebViewInternal.h: There was no _interceptEditingKeyEvent:shouldSaveCommand:
2299         method on WebView.
2300
2301 2011-03-27  Jer Noble  <jer.noble@apple.com>
2302
2303         Reviewed by Maciej Stachowiak.
2304
2305         Full Screen: disable keyboard access by default
2306         https://bugs.webkit.org/show_bug.cgi?id=56684
2307
2308         Take into account whether keyboard access was requested when deciding whether full
2309         screen mode is supported.
2310
2311         * WebCoreSupport/WebChromeClient.h:
2312         * WebCoreSupport/WebChromeClient.mm:
2313         (WebChromeClient::supportsFullScreenForElement):
2314         * WebView/WebView.mm:
2315         (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):
2316         * WebView/WebViewInternal.h:
2317
2318 2011-03-26  Jer Noble  <jer.noble@apple.com>
2319
2320         Reviewed by Eric Carlson.
2321
2322         Enable the Full Screen API by default in WebKit/mac and WebKit2
2323         https://bugs.webkit.org/show_bug.cgi?id=56956
2324
2325         * WebView/WebPreferences.mm:
2326         (+[WebPreferences initialize]): Default the WebKitFullScreenEnabled preference to true.
2327
2328 2011-03-25  Andy Estes  <aestes@apple.com>
2329
2330         Reviewed by Adele Peterson.
2331
2332         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
2333         https://bugs.webkit.org/show_bug.cgi?id=49016
2334
2335         Update objectContentType() implementation to handle the
2336         shouldPreferPlugInsForImages flag.
2337
2338         * WebCoreSupport/WebFrameLoaderClient.h:
2339         * WebCoreSupport/WebFrameLoaderClient.mm:
2340         (WebFrameLoaderClient::objectContentType):
2341
2342 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2343
2344         Unreviewed, rolling out r81939.
2345         http://trac.webkit.org/changeset/81939
2346         https://bugs.webkit.org/show_bug.cgi?id=57084
2347
2348         Rolling out 81939, as it's causing a number of app cache test
2349         failures. (Requested by jernoble on #webkit).
2350
2351         * WebView/WebView.mm:
2352         (-[WebView _preferencesChangedNotification:]):
2353
2354 2011-03-23  Jer Noble  <jer.noble@apple.com>
2355
2356         Reviewed by Maciej Stachowiak.
2357
2358         Application Cache should save audio/ and video/ mime types as flat files
2359         https://bugs.webkit.org/show_bug.cgi?id=53784
2360         <rdar://problem/8932473>
2361
2362         No new tests.
2363
2364         Initialize the AppCache Total size quotas with the values for WebKitPreferences
2365         upon startup.
2366
2367         * WebView/WebView.mm:
2368         (-[WebView _preferencesChangedNotification:]):
2369
2370 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2371
2372         Unreviewed, rolling out r81916 and r81917.
2373         http://trac.webkit.org/changeset/81916
2374         http://trac.webkit.org/changeset/81917
2375         https://bugs.webkit.org/show_bug.cgi?id=57071
2376
2377         broke a test on platforms that do not have QuickTime installed
2378         (Requested by estes on #webkit).
2379
2380         * WebCoreSupport/WebFrameLoaderClient.h:
2381         * WebCoreSupport/WebFrameLoaderClient.mm:
2382         (WebFrameLoaderClient::objectContentType):
2383
2384 2011-03-24  Andy Estes  <aestes@apple.com>
2385
2386         Reviewed by Darin Adler.
2387
2388         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
2389         https://bugs.webkit.org/show_bug.cgi?id=49016
2390
2391         Update objectContentType() implementation to handle the
2392         shouldPreferPlugInsForImages flag.
2393
2394         * WebCoreSupport/WebFrameLoaderClient.h:
2395         * WebCoreSupport/WebFrameLoaderClient.mm:
2396         (WebFrameLoaderClient::objectContentType):
2397
2398 2011-03-24  Geoffrey Garen  <ggaren@apple.com>
2399
2400         Reviewed by Oliver Hunt.
2401
2402         Ensure that all compilation takes place within a dynamic global object scope
2403         https://bugs.webkit.org/show_bug.cgi?id=57054
2404
2405         * WebView/WebScriptDebugDelegate.mm:
2406         (-[WebScriptCallFrame evaluateWebScript:]): Updated for signature change.
2407
2408 2011-03-24  Jia Pu  <jpu@apple.com>
2409
2410         Reviewed by Darin Adler.
2411
2412         Dismissed reversion suggestion is incorrectly learned.
2413         https://bugs.webkit.org/show_bug.cgi?id=57039
2414
2415         CorrectionPanel should always use [NSSpellChecker dismissCorrectionBubbleForView].
2416         [NSSpellChecker cancelCorrectionBubbleForView] is reserved for situation where correction panel
2417         is dismissed explicitly by ESC key or clicking the dimiss button. Misusing these causes
2418         incorrect automatic learning.
2419
2420         * WebCoreSupport/CorrectionPanel.mm:
2421         (CorrectionPanel::dismissInternal):
2422
2423 2011-03-24  David Kilzer  <ddkilzer@apple.com>
2424
2425         <http://webkit.org/b/56993> ENABLE_PLUGIN_PROXY_FOR_VIDEO should be defined to 0 on Mac OS X
2426
2427         Reviewed by Joseph Pecoraro.
2428
2429         * Plugins/WebPluginContainerPrivate.h: Changed value of
2430         ENABLE_PLUGIN_PROXY_FOR_VIDEO from 1 to 0.
2431
2432 2011-03-23  Jia Pu  <jpu@apple.com>
2433
2434         Reviewed by Darin Adler.
2435
2436         Hook up new AppKit autocorrection UI with WK2.
2437         https://bugs.webkit.org/show_bug.cgi?id=56055
2438         <rdar://problem/8947463>
2439
2440         Please see WebCore/ChangeLog for detail.
2441
2442         * WebCoreSupport/CorrectionPanel.h: Added.
2443         (CorrectionPanel::isShowing):
2444         * WebCoreSupport/CorrectionPanel.mm: Added.
2445         (correctionBubbleType):
2446         (CorrectionPanel::CorrectionPanel):
2447         (CorrectionPanel::~CorrectionPanel):
2448         (CorrectionPanel::show):
2449         (CorrectionPanel::dismiss):
2450         (CorrectionPanel::dismissSoon):
2451         (CorrectionPanel::dismissInternal):
2452         (CorrectionPanel::recordAutocorrectionResponse):
2453         * WebCoreSupport/WebEditorClient.h:
2454         * WebCoreSupport/WebEditorClient.mm:
2455         (WebEditorClient::WebEditorClient):
2456         (WebEditorClient::showCorrectionPanel):
2457         (WebEditorClient::dismissCorrectionPanel):
2458         (WebEditorClient::dismissCorrectionPanelSoon):
2459         (WebEditorClient::recordAutocorrectionResponse):
2460         * WebView/WebView.mm:
2461         (-[WebView handleCorrectionPanelResult:]):
2462         * WebView/WebViewPrivate.h:
2463
2464 2011-03-23  Enrica Casucci  <enrica@apple.com>
2465
2466         Reviewed by Alexey Proskuryakov.
2467
2468         Services menu item to convert selected Simplified/Traditional Chinese Text is not working.
2469         https://bugs.webkit.org/show_bug.cgi?id=56974
2470         <rdar://problem/8284642>
2471
2472         This fixes a regression introduced by http://trac.webkit.org/changeset/61794
2473         where readSelectionFromPasteboard was accidentally removed.
2474         This method and writeSelectionToPasteboard are needed to support Mac OS X
2475         services.
2476         
2477         * WebView/WebHTMLView.mm:
2478         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Added.
2479         (-[WebHTMLView readSelectionFromPasteboard:]): Added.
2480
2481 2011-03-23  Brady Eidson  <beidson@apple.com>
2482
2483         Reviewed by Sam Weinig.
2484
2485         Change IconDatabase opening to allow for arbitrary filenames
2486         https://bugs.webkit.org/show_bug.cgi?id=56977
2487
2488         * Misc/WebIconDatabase.mm:
2489         (-[WebIconDatabase _startUpIconDatabase]):
2490
2491 2011-03-22  Anton D'Auria  <adauria@apple.com>
2492
2493         Reviewed by Alexey Proskuryakov.
2494
2495         Add +[WebApplicationCache getOriginsWithCache]
2496         https://bugs.webkit.org/show_bug.cgi?id=56722
2497
2498         Call existing WebCore::ApplicationCacheStorage::getOriginsWithCache API.
2499
2500         * WebCoreSupport/WebApplicationCache.h:
2501         * WebCoreSupport/WebApplicationCache.mm:
2502         (+[WebApplicationCache originsWithCache]):
2503
2504 2011-03-22  Anders Carlsson  <andersca@apple.com>
2505
2506         Reviewed by Sam Weinig.
2507
2508         OBJECT element with DivX source is always downloaded
2509         https://bugs.webkit.org/show_bug.cgi?id=56879
2510
2511         * Plugins/WebBasePluginPackage.mm:
2512         (-[WebBasePluginPackage getPluginInfoFromPLists]):
2513         Always try to split every element in the "WebPluginExtensions" array, since the DivX plug-in
2514         specifies multiple file extensions in a single element.
2515
2516 2011-03-22  Brady Eidson  <beidson@apple.com>
2517
2518         Reviewed by Sam Weinig.
2519
2520         <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876
2521         WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread
2522
2523         Note that while the new client calls always come through on the main thread, our mechanisms to
2524         route dispatches to the main thread are still valid and will still work.
2525
2526         Update to the new IconDatabaseClient interface:
2527         * WebCoreSupport/WebIconDatabaseClient.h:
2528         * WebCoreSupport/WebIconDatabaseClient.mm:
2529         (WebIconDatabaseClient::didRemoveAllIcons):
2530         (WebIconDatabaseClient::didImportIconURLForPageURL):
2531         (WebIconDatabaseClient::didImportIconDataForPageURL):
2532         (WebIconDatabaseClient::didChangeIconForPageURL):
2533         (WebIconDatabaseClient::didFinishURLImport):
2534
2535 2011-03-22  Matthew Delaney  <mdelaney@apple.com>
2536
2537         Reviewed by Simon Fraser.
2538
2539         Have WebKit push acceleratedDrawing preferences to settings
2540         https://bugs.webkit.org/show_bug.cgi?id=56792
2541
2542         * WebView/WebView.mm:
2543
2544 2011-03-21  Nate Chapin  <japhet@chromium.org>
2545
2546         Reviewed by Brady Eidson.
2547
2548         Expose a preference to use caching quirks for QuickLook,
2549         and use it if the QuickLook framework is loaded.
2550
2551         https://bugs.webkit.org/show_bug.cgi?id=38690
2552
2553         * WebView/WebPreferenceKeysPrivate.h:
2554         * WebView/WebPreferences.mm:
2555         (useQuickLookQuirks):
2556         (+[WebPreferences initialize]):
2557         (-[WebPreferences useQuickLookResourceCachingQuirks]):
2558         * WebView/WebPreferencesPrivate.h:
2559         * WebView/WebView.mm:
2560         (-[WebView _preferencesChangedNotification:]):
2561
2562 2011-03-21  Chris Fleizach  <cfleizach@apple.com>
2563
2564         Reviewed by Darin Adler.
2565
2566         AX: showContextMenu not working in WK2
2567         https://bugs.webkit.org/show_bug.cgi?id=56734
2568
2569         Implement showContextMenu() so accessibility related code can call this
2570         independent of whether WK1 or WK2 is running.
2571
2572         * WebCoreSupport/WebChromeClient.h:
2573         * WebCoreSupport/WebChromeClient.mm:
2574         (WebChromeClient::showContextMenu):
2575
2576 2011-03-21  Chang Shu  <cshu@webkit.org>
2577
2578         Reviewed by Alexey Proskuryakov.
2579
2580         REGRESSION (r79953): Can't type in MS Outlook 2011
2581         https://bugs.webkit.org/show_bug.cgi?id=56665
2582
2583         r79953 removed the WebView level editablity which is persistent no matter whether
2584         underlying document itself is changed and editability gets lost. The resolution is to
2585         set this WebView editable value to WebCore. This avoids the callback from WebCore to
2586         WebKit which was the main goal in r79953 to improve performance.
2587
2588         * WebView/WebView.mm:
2589         (-[WebView setEditable:]):
2590         (-[WebView isEditable]):
2591
2592 2011-03-19  Anton D'Auria  <adauria@apple.com>
2593
2594         Reviewed by Alexey Proskuryakov.
2595
2596         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
2597         https://bugs.webkit.org/show_bug.cgi?id=56415
2598         
2599         Use new ApplicationCache API to delete all cache for an origin.
2600
2601         * WebCoreSupport/WebApplicationCache.h:
2602         * WebCoreSupport/WebApplicationCache.mm:
2603         (+[WebApplicationCache deleteOrigin:]):
2604
2605 2011-03-17  Brady Eidson  <beidson@apple.com>
2606
2607         Reviewed by Sam Weinig.
2608
2609         https://bugs.webkit.org/show_bug.cgi?id=56425
2610         More groundwork for WebKit2 IconDatabase
2611
2612         Update already-used function names:
2613         * Misc/WebIconDatabase.mm:
2614         (-[WebIconDatabase iconForURL:withSize:cache:]):
2615         (-[WebIconDatabase iconURLForURL:]):
2616         * WebView/WebView.mm:
2617         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
2618
2619 2011-03-18  Pavel Podivilov  <podivilov@chromium.org>
2620
2621         Reviewed by Yury Semikhatsky.
2622
2623         Web Inspector: implement inspector session storage.
2624         https://bugs.webkit.org/show_bug.cgi?id=56643
2625
2626         * WebCoreSupport/WebInspectorClient.h:
2627         * WebCoreSupport/WebInspectorClient.mm:
2628         (WebInspectorClient::saveSessionSetting):
2629         (WebInspectorClient::loadSessionSetting):
2630         (WebInspectorFrontendClient::saveSessionSetting):
2631         (WebInspectorFrontendClient::loadSessionSetting):
2632         (-[WebInspectorWindowController inspectorClient]):
2633
2634 2011-03-17  Geoffrey Garen  <ggaren@apple.com>
2635
2636         Reviewed by Oliver Hunt.
2637
2638         Fixed a leak seen on the buildbot.
2639
2640         * WebCoreSupport/WebInspectorClient.mm:
2641         (WebInspectorClient::openInspectorFrontend): Smart pointers are smart.
2642
2643 2011-03-16  Jeff Johnson  <github@lapcatsoftware.com>
2644
2645         Reviewed by Alexey Proskuryakov.
2646
2647         Logic error in -[WebHTMLView close]
2648         https://bugs.webkit.org/show_bug.cgi?id=56445
2649
2650         Page is always nil at this point, because [self _webView] is nil,
2651         so the conditional code is never run.
2652
2653         * WebView/WebHTMLView.mm:
2654         (-[WebHTMLView close]):
2655
2656 2011-03-16  Chris Fleizach  <cfleizach@apple.com>
2657
2658         Reviewed by Darin Adler.
2659
2660         WK2: Need to propagate enhanced accessibility flag from UI -> web process
2661         https://bugs.webkit.org/show_bug.cgi?id=56379
2662
2663         * WebView/WebFrame.mm:
2664         (-[WebFrame accessibilityRoot]):
2665
2666 2011-03-15  Oliver Hunt  <oliver@apple.com>
2667
2668         Reviewed by Geoffrey Garen.
2669
2670         Make Structure creation require a JSGlobalData
2671         https://bugs.webkit.org/show_bug.cgi?id=56438
2672
2673         Mechanical change to make all Structure creation use a JSGlobalData&
2674
2675         * Plugins/Hosted/ProxyInstance.mm:
2676         (WebKit::ProxyRuntimeMethod::createStructure):
2677         * Plugins/Hosted/ProxyRuntimeObject.h:
2678         (WebKit::ProxyRuntimeObject::createStructure):
2679
2680 2011-03-15  Alexey Proskuryakov  <ap@apple.com>
2681
2682         Forgot to save a modification to this file when committing.
2683
2684         * WebCoreSupport/WebKeyGenerator.mm: Changed "Apple Computer" to "Apple" in copyright header.
2685
2686 2011-03-15  Alexey Proskuryakov  <ap@apple.com>
2687
2688         Reviewed by Darin Adler.
2689
2690         REGRESSION (WebKit2): keygen element doesn't work
2691         https://bugs.webkit.org/show_bug.cgi?id=56402
2692         <rdar://problem/9006545>
2693
2694         * WebCoreSupport/WebKeyGenerator.h:
2695         * WebCoreSupport/WebKeyGenerator.m: Removed.
2696         * WebCoreSupport/WebKeyGenerator.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebKeyGenerator.m.
2697         (+[WebKeyGenerator sharedGenerator]):
2698         (toWebCertificateParseResult):
2699         WebCore no longer needs WebKeyGenerator. Safari still does need a part of it, so keeping
2700         this misnamed and misplaced code for now.
2701
2702         * WebCoreSupport/WebPlatformStrategies.h:
2703         * WebCoreSupport/WebPlatformStrategies.mm:
2704         (WebPlatformStrategies::keygenMenuItem512):
2705         (WebPlatformStrategies::keygenMenuItem1024):
2706         (WebPlatformStrategies::keygenMenuItem2048):
2707         (WebPlatformStrategies::keygenKeychainItemName):
2708         Added strings used by keygen.
2709
2710         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize a WebCore
2711         pointer to a function used by keygen.
2712
2713         * WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): WebKeyGenerator can be lazily
2714         initialized now.
2715
2716 2011-03-15  Beth Dakin  <bdakin@apple.com>
2717
2718         Reviewed by Simon Fraser.
2719
2720         WebKit part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%
2721
2722         New WebKitystemInterface function to force the scrollbars to flash
2723         * WebCoreSupport/WebSystemInterface.mm:
2724         (InitWebCoreSystemInterface):
2725
2726 2011-03-15  Ilya Sherman  <isherman@chromium.org>
2727
2728         Reviewed by Tony Chang.
2729
2730         Autofilled form elements are assigned fixed background color but not text color
2731         https://bugs.webkit.org/show_bug.cgi?id=48382
2732
2733         * DOM/WebDOMOperations.mm:
2734         (-[DOMHTMLInputElement _setAutofilled:]): Added (wrapper).
2735         * DOM/WebDOMOperationsPrivate.h:
2736
2737 2011-03-15  Adam Roben  <aroben@apple.com>
2738
2739         Fix a leak in WebStorageTrackerClient::dispatchDidModifyOrigin
2740
2741         Fixes <http://webkit.org/b/56385> SecurityOrigin leaks seen in
2742         WebStorageTrackerClient::dispatchDidModifyOrigin
2743
2744         Reviewed by Antti Koivisto.
2745
2746         * Storage/WebStorageTrackerClient.mm:
2747         (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): Adopt the reference passed
2748         to us by dispatchDidModifyOrigin.
2749         (WebStorageTrackerClient::dispatchDidModifyOrigin): Added a comment and removed an
2750         unnecessary cast.
2751
2752 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2753
2754         Reviewed by Darin Adler.
2755
2756         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
2757         info into the headers rather than in export symbol definition files, but disable it on 
2758         all platforms initially so we can deal with port build issues one port at a time.
2759         
2760         https://bugs.webkit.org/show_bug.cgi?id=27551
2761
2762         * WebKitPrefix.h:
2763
2764 2011-03-14  Brady Eidson  <beidson@apple.com>
2765
2766         Reviewed by Anders Carlsson.
2767
2768         https://bugs.webkit.org/show_bug.cgi?id=56320
2769         Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
2770
2771         * History/WebHistoryItem.mm:
2772         (-[WebHistoryItem icon]): This far-future FIXME is now irrelevant.
2773
2774 2011-03-13  Pratik Solanki  <psolanki@apple.com>
2775
2776         Reviewed by Brady Eidson.
2777
2778         Make adjustMIMETypeIfNecessary use CFNetwork directly
2779         https://bugs.webkit.org/show_bug.cgi?id=55912
2780
2781         * WebCoreSupport/WebSystemInterface.mm:
2782         (InitWebCoreSystemInterface): Support for new WKSI functions.
2783
2784 2011-03-12  Mark Rowe  <mrowe@apple.com>
2785
2786         Fix the 32-bit build.
2787
2788         * Carbon/CarbonWindowAdapter.mm:
2789         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier.
2790         (-[CarbonWindowAdapter _carbonWindowClass]): Ditto.
2791
2792 2011-03-11  Brady Eidson  <beidson@apple.com>
2793
2794         Reviewed by Anders Carlsson
2795
2796         <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56216
2797         Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation.
2798
2799         * Misc/WebIconDatabase.mm:
2800         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Call these static methods on IconDatabase::, not iconDatabase().
2801         (-[WebIconDatabase _startUpIconDatabase]): Ditto.
2802         (importToWebCoreFormat):
2803
2804 2011-03-11  Anton D'Auria  <adauria@apple.com>
2805
2806         Reviewed and landed by Brady Eidson.
2807
2808         https://bugs.webkit.org/show_bug.cgi?id=51878
2809         Add WebKit1 API to view and delete local storage
2810
2811         * Storage/WebStorageManager.mm: Added.
2812         (+[WebStorageManager sharedWebStorageManager]):
2813         (-[WebStorageManager origins]):
2814         (-[WebStorageManager deleteAllOrigins]):
2815         (-[WebStorageManager deleteOrigin:]):
2816         (-[WebStorageManager syncLocalStorage]):
2817         (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
2818         (storageDirectoryPath):
2819         (WebKitInitializeStorageIfNecessary):
2820         * Storage/WebStorageManagerInternal.h: Added.
2821         * Storage/WebStorageManagerPrivate.h: Added.
2822         * Storage/WebStorageTrackerClient.h: Added.
2823         * Storage/WebStorageTrackerClient.mm: Added.
2824         (WebStorageTrackerClient::sharedWebStorageTrackerClient):
2825         (WebStorageTrackerClient::WebStorageTrackerClient):
2826         (WebStorageTrackerClient::~WebStorageTrackerClient):
2827         (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread):
2828         (WebStorageTrackerClient::dispatchDidModifyOrigin):
2829         * WebCoreSupport/WebSecurityOrigin.mm:
2830         (-[WebSecurityOrigin protocol]):
2831         (-[WebSecurityOrigin host]):
2832         (-[WebSecurityOrigin databaseIdentifier]):
2833         (-[WebSecurityOrigin domain]):
2834         (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
2835         * WebCoreSupport/WebSecurityOriginPrivate.h:
2836         * WebKit.exp:
2837         * WebView/WebView.mm:
2838         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2839
2840 2011-03-10  Anders Carlsson  <andersca@apple.com>
2841
2842         Reviewed by Sam Weinig.
2843
2844         <rdar://problem/9117047>
2845         Don't paint more than 60 times per second even when scrolling
2846
2847         * WebView/WebClipView.mm:
2848         (-[WebClipView _immediateScrollToPoint:]):
2849
2850 2011-03-09  Matthew Delaney  <mdelaney@apple.com>
2851
2852         Reviewed by Simon Fraser.
2853
2854         Plumb through settings for accelerated drawing for canvas
2855         https://bugs.webkit.org/show_bug.cgi?id=56039
2856
2857         * WebView/WebPreferenceKeysPrivate.h:
2858         * WebView/WebPreferences.mm:
2859         * WebView/WebPreferencesPrivate.h:
2860
2861 2011-03-10  Ryosuke Niwa  <rniwa@webkit.org>
2862
2863         Reviewed by Tony Chang.
2864
2865         VisiblePosition's next and previous should take an enum instead of a boolean
2866         https://bugs.webkit.org/show_bug.cgi?id=56135
2867
2868         SelectionController::isAll now takes EditingBoundaryCrossingRule instead of
2869         StayInEditableContent.
2870
2871         * WebView/WebView.mm:
2872         (-[WebView _selectionIsAll]):
2873
2874 2011-03-09  Jessie Berlin  <jberlin@apple.com>
2875
2876         Reviewed by Adam Roben.
2877
2878         Use the Cookie Storage from the Private Browsing Storage Session directly
2879         https://bugs.webkit.org/show_bug.cgi?id=55986
2880
2881         * WebCoreSupport/WebSystemInterface.mm:
2882         (InitWebCoreSystemInterface):
2883
2884 2011-03-08  Darin Adler  <darin@apple.com>
2885
2886         Reviewed by Timothy Hatcher.
2887
2888         Promote a method used outside WebKit from internal to private
2889         https://bugs.webkit.org/show_bug.cgi?id=55949
2890
2891         * Misc/WebNSPasteboardExtras.mm: Removed an unused category declaration.
2892         Minor tweak, not directly related to the rest of this patch.
2893
2894         * WebView/WebFrame.mm:
2895         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): Moved
2896         this method from the internal category into the private category.
2897         Streamlined the code a bit.
2898
2899         * WebView/WebFrameInternal.h: Removed _computePageRects method.
2900         * WebView/WebFramePrivate.h: Added _computePageRects method.
2901
2902 2011-03-07  Ryosuke Niwa  <rniwa@webkit.org>
2903
2904         Reviewed by Darin Adler.
2905
2906         selectionHasStyle and selectionStartHasStyle should use EditingStyle
2907         https://bugs.webkit.org/show_bug.cgi?id=55902
2908
2909         selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.
2910
2911         * WebView/WebHTMLView.mm: Removed unused selectionHasStyle.
2912         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Calls Editor::selectionHasStyle.
2913
2914 2011-03-07  Dan Bernstein  <mitz@apple.com>
2915
2916         LLVM Compiler build fix.
2917
2918         * WebCoreSupport/WebEditorClient.mm:
2919         (WebEditorClient::checkGrammarOfString):
2920
2921 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
2922
2923         Reviewed by Beth Dakin.
2924
2925         AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
2926         https://bugs.webkit.org/show_bug.cgi?id=55706
2927
2928         Make sure WebDynamicScrollBarsView appear in the AX tree in WK1 (since this object
2929         returns the scroll bar objects).
2930         Make the accessibilityRoot object be the web area in WK1 because WebDynamicScrollBarsView
2931         will expect that as its child, instead of the WebCore ScrollView object.
2932
2933         * WebView/WebDynamicScrollBarsView.mm:
2934         (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
2935         * WebView/WebFrame.mm:
2936         (-[WebFrame accessibilityRoot]):
2937
2938 2011-03-07  Sam Weinig  <sam@webkit.org>
2939
2940         Reviewed by Anders Carlsson.
2941
2942         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
2943         https://bugs.webkit.org/show_bug.cgi?id=55827
2944
2945         Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
2946         and pass the entire response, instead of just the MIMEType.
2947
2948         * WebCoreSupport/WebFrameLoaderClient.h:
2949         * WebCoreSupport/WebFrameLoaderClient.mm:
2950         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2951
2952 2011-03-06  Dan Bernstein  <mitz@apple.com>
2953
2954         LLVM Compiler build fix.
2955
2956         * DOM/WebDOMOperations.mm:
2957         (-[DOMHTMLInputElement _setValueForUser:]):
2958
2959 2011-03-06  Jessie Berlin  <jberlin@apple.com>
2960
2961         Reviewed by Sam Weinig.
2962
2963         WebKit2: Use CFNetwork Sessions API.
2964         https://bugs.webkit.org/show_bug.cgi?id=55435.
2965
2966         When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
2967         Private Browsing Storage Session.
2968
2969         * WebCoreSupport/WebSystemInterface.mm:
2970         (InitWebCoreSystemInterface):
2971         Add support for using the new WKSI functions in WebCore.
2972
2973 2011-03-05  Ilya Sherman  <isherman@chromium.org>
2974
2975         Reviewed by Darin Adler.
2976
2977         HTMLInputElement::setValue() should schedule change event when the element is focused
2978         In service of https://code.google.com/p/chromium/issues/detail?id=42716
2979         https://bugs.webkit.org/show_bug.cgi?id=53160
2980
2981         * DOM/WebDOMOperations.mm:
2982         (-[DOMHTMLInputElement _setValueForUser:]): Expose HTMLInputElement::setValueForUser() to tests
2983         * DOM/WebDOMOperationsPrivate.h:
2984         * WebView/WebViewInternal.h:
2985
2986 2011-03-04  Jia Pu  <jpu@apple.com>
2987
2988         Reviewed by Darin Adler.
2989
2990         On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
2991         https://bugs.webkit.org/show_bug.cgi?id=55717
2992         <rdar://problem/9018127>
2993
2994         With the change in WebCore, the bounding box passed into EditorClient::showCorrectionPanel()
2995         is already in window coordinate. We don't need to do further conversion anymore.
2996
2997         * WebCoreSupport/WebEditorClient.mm:
2998         (WebEditorClient::showCorrectionPanel):
2999
3000 2011-03-04  Jessie Berlin  <jberlin@apple.com>
3001
3002         Reviewed by Maciej Stachowiak.
3003
3004         WebKit2: Use CFNetwork Sessions API.
3005         https://bugs.webkit.org/show_bug.cgi?id=55435.
3006
3007         When Private Browsing is enabled, get the cached url response from the cache associated with
3008         the Private Browsing Storage Session.
3009
3010         * WebView/WebView.mm:
3011         (-[WebView _cachedResponseForURL:]):
3012
3013 2011-03-03  Anders Carlsson  <andersca@apple.com>
3014
3015         Reviewed by Sam Weinig.
3016
3017         Get rid of Page::globalHistoryItem
3018         https://bugs.webkit.org/show_bug.cgi?id=55738
3019
3020         * WebCoreSupport/WebFrameLoaderClient.h:
3021         * WebCoreSupport/WebFrameLoaderClient.mm:
3022         (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
3023         Get the current history item and update it using -[WebView _setGlobalHistoryItem:].
3024     
3025         * WebView/WebView.mm:
3026         (-[WebView _globalHistoryItem]):
3027         (-[WebView _setGlobalHistoryItem:]):
3028         Set _globalHistoryItem ivar.
3029
3030         * WebView/WebViewData.h:
3031         * WebView/WebViewData.mm:
3032         Add _globalHistoryItem ivar.
3033
3034 2011-03-03  Brady Eidson  <beidson@apple.com>
3035
3036         Reviewed by Darin Adler.
3037
3038         https://bugs.webkit.org/show_bug.cgi?id=55721
3039         Global IconDatabase should be returned by reference, not as a pointer
3040
3041         * Misc/WebCoreStatistics.mm:
3042         (+[WebCoreStatistics iconPageURLMappingCount]):
3043         (+[WebCoreStatistics iconRetainedPageURLCount]):
3044         (+[WebCoreStatistics iconRecordCount]):
3045         (+[WebCoreStatistics iconsWithDataCount]):
3046         * Misc/WebIconDatabase.mm:
3047         (-[WebIconDatabase init]):
3048         (-[WebIconDatabase iconForURL:withSize:cache:]):
3049         (-[WebIconDatabase iconURLForURL:]):
3050         (-[WebIconDatabase defaultIconWithSize:]):
3051         (-[WebIconDatabase retainIconForURL:]):
3052         (-[WebIconDatabase releaseIconForURL:]):
3053         (-[WebIconDatabase isEnabled]):
3054         (-[WebIconDatabase setEnabled:]):
3055         (-[WebIconDatabase removeAllIcons]):
3056         (+[WebIconDatabase _checkIntegrityBeforeOpening]):
3057         (-[WebIconDatabase _startUpIconDatabase]):
3058         (-[WebIconDatabase _applicationWillTerminate:]):
3059         (-[WebIconDatabase _resetCachedWebPreferences:]):
3060         (importToWebCoreFormat):
3061         * WebView/WebView.mm:
3062         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
3063
3064 2011-03-03  Jessie Berlin  <jberlin@apple.com>
3065
3066         Reviewed by Adam Roben.
3067
3068         WebKit2: Use CFNetwork Sessions API.
3069         https://bugs.webkit.org/show_bug.cgi?id=55435.
3070
3071         Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
3072
3073         * WebCoreSupport/WebSystemInterface.mm:
3074         (InitWebCoreSystemInterface):
3075         Support using WKCopyRequestWithStorageSession in WebCore.
3076
3077 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
3078
3079         Reviewed by Darin Adler.
3080
3081         REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
3082         https://bugs.webkit.org/show_bug.cgi?id=55633
3083         <rdar://problem/8963023>
3084
3085         * WebCoreSupport/WebChromeClient.h:
3086         * WebCoreSupport/WebChromeClient.mm:
3087         Removed tabsToLinks(). Mac WebKit already implements keyboardUIMode().
3088
3089         * WebView/WebView.mm: (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
3090         Removed an incorrect comment. We actually get a value of 2 on Snow Leopard, and we don't
3091         require both bits to be set. The rest of the comment might be wrong too, but I'm not sure,
3092         so I've preserved it.
3093
3094 2011-03-02  Jessie Berlin  <jberlin@apple.com>
3095
3096         Rubber-stamped by Dan Bernstein.
3097
3098         Fix crashes in private browsing tests in WK1 on Snow Leopard.
3099
3100         * WebCoreSupport/WebSystemInterface.mm:
3101         (InitWebCoreSystemInterface):
3102         Put the INIT call for wkCreatePrivateStorageSession outside of the
3103         #if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
3104         guards.
3105
3106 2011-03-02  Jessie Berlin  <jberlin@apple.com>
3107
3108         Reviewed by Adam Roben.
3109
3110         WebKit2: Use CFNetwork Sessions API.
3111         https://bugs.webkit.org/show_bug.cgi?id=55435.
3112
3113         Add the ability to create a Private Browsing Storage Session.
3114
3115         * WebCoreSupport/WebSystemInterface.mm:
3116         (InitWebCoreSystemInterface):
3117         Support calling wkCreatePrivateStorageSession from WebCore.
3118
3119 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
3120
3121         Reviewed by David Levin.
3122
3123         Add feature define for data transfer items
3124         https://bugs.webkit.org/show_bug.cgi?id=55510
3125
3126         * Configurations/FeatureDefines.xcconfig:
3127
3128 2011-03-02  Sam Weinig  <sam@webkit.org>
3129
3130         Reviewed by Anders Carlsson.
3131
3132         Fix remaining localization issues by piping all localized strings through WebCore's
3133         localization bottleneck.
3134         <rdar://problem/8728860>
3135
3136         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3137         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
3138         * Misc/WebKitErrors.m:
3139         * Misc/WebLocalizableStringsInternal.h: Added.
3140         * Misc/WebLocalizableStringsInternal.mm: Added.
3141         (WebLocalizedStringInternal):
3142         * Panels/WebAuthenticationPanel.m:
3143         (-[WebAuthenticationPanel setUpForChallenge:]):
3144         * Plugins/Hosted/NetscapePluginHostManager.mm:
3145         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3146         * WebCoreSupport/WebEditorClient.mm:
3147         (undoNameForEditAction):
3148         * WebCoreSupport/WebInspectorClient.mm:
3149         (WebInspectorFrontendClient::updateWindowTitle):
3150         (-[WebInspectorWindowController validateUserInterfaceItem:]):
3151         * WebCoreSupport/WebKeyGenerator.m:
3152         (-[WebKeyGenerator strengthMenuItemTitles]):
3153         (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]):
3154         * WebCoreSupport/WebPlatformStrategies.mm:
3155         * WebView/WebHTMLView.mm:
3156         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3157         * WebView/WebPDFView.mm:
3158         (-[WebPDFView menuForEvent:]):
3159
3160 2011-03-01  Brian Weinstein  <bweinstein@apple.com>
3161
3162         Reviewed by Adam Roben.
3163
3164         Part of WebKit2: Need a way to send notifications to client when cookies change
3165         https://bugs.webkit.org/show_bug.cgi?id=55427
3166         <rdar://problem/9056027>
3167         
3168         Add stubs for CookiesStrategy on Mac WebKit1.
3169
3170         * WebCoreSupport/WebPlatformStrategies.h:
3171         * WebCoreSupport/WebPlatformStrategies.mm:
3172         (WebPlatformStrategies::createCookiesStrategy):
3173         (WebPlatformStrategies::notifyCookiesChanged):
3174
3175 2011-03-01  Philippe Normand  <pnormand@igalia.com>
3176
3177         Reviewed by Eric Carlson.
3178
3179         [GStreamer] support in mac video fullscreen controller
3180         https://bugs.webkit.org/show_bug.cgi?id=52280
3181
3182         Factored the code to configure the video overlay in a new private
3183         method of the controller and added GStreamer support to it.
3184
3185         * WebView/WebVideoFullscreenController.h:
3186         * WebView/WebVideoFullscreenController.mm:
3187         (-[WebVideoFullscreenController setupVideoOverlay:]):
3188         (-[WebVideoFullscreenController windowDidLoad]):
3189         (-[WebVideoFullscreenController setMediaElement:WebCore::]):
3190         (-[WebVideoFullscreenController windowDidExitFullscreen]):
3191
3192 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
3193
3194         Reviewed by Timothy Hatcher.
3195
3196         All Console Messages should be passed to ChromeClients.
3197         https://bugs.webkit.org/show_bug.cgi?id=54926
3198
3199         Add a new private UIDelegate method, -webView:addMessageToConsole:withSource:,
3200         which supersedes -webView:addMessageToConsole if it exists. The new delegate
3201         does not filter to only JavaScript originated console messages. The old
3202         delegate is left around for clients that expect filtered messages, like
3203         DashCode and older versions of Safari.
3204
3205         The dictionary message passed to the delegate now includes more information
3206         about the message source, type, and level.
3207
3208         * WebCoreSupport/WebChromeClient.mm:
3209         (stringForMessageSource):
3210         (stringForMessageType):
3211         (stringForMessageLevel):
3212         (WebChromeClient::addMessageToConsole):
3213         * WebView/WebUIDelegatePrivate.h:
3214
3215 2011-03-01  Levi Weintraub  <leviw@chromium.org>
3216
3217         Reviewed by Ryosuke Niwa.
3218
3219         Stop instantiating legacy editing Positions in VisiblePosition
3220         https://bugs.webkit.org/show_bug.cgi?id=52919
3221
3222         Changing usage of legacy VisiblePosition constructor. Since we were dealing
3223         with positions from DOM Ranges, we're guaranteed a parent-anchored position.
3224
3225         * WebView/WebFrame.mm:
3226         (-[WebFrame _caretRectAtPosition:affinity:]):
3227         * WebView/WebFrameInternal.h:
3228         * WebView/WebTextCompletionController.mm:
3229         (-[WebTextCompletionController doCompletion]):
3230
3231 2011-03-01  Sam Weinig  <sam@webkit.org>
3232
3233         Reviewed by Timothy Hatcher.
3234
3235         WebKit2 needs to be made localizable
3236         https://bugs.webkit.org/show_bug.cgi?id=55483
3237
3238         * WebCoreSupport/WebPlatformStrategies.mm:
3239         Use WebCore's localizedString function instead of WebLocalizableStrings
3240         since WebCore is now responsible for localization.
3241
3242 2011-02-25 Steve Block <steveblock@google.com>
3243
3244         Reviewed by Jeremy Orlow.
3245
3246         Bridge.h should not include BridgeJSC.h
3247         https://bugs.webkit.org/show_bug.cgi?id=55212
3248
3249         Include BridgeJSC.h directly instead.
3250
3251         * Plugins/Hosted/ProxyInstance.h:
3252         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3253
3254 2011-02-28  Chang Shu  <cshu@webkit.org>
3255
3256         Reviewed by Ryosuke Niwa.
3257
3258         Remove the support of Frame::isContentEditable and its dependencies.
3259         https://bugs.webkit.org/show_bug.cgi?id=54292
3260
3261         Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
3262
3263         * WebCoreSupport/WebEditorClient.h:
3264         * WebCoreSupport/WebEditorClient.mm:
3265         * WebView/WebView.mm:
3266         (-[WebView setEditable:]):
3267         (-[WebView isEditable]):
3268         * WebView/WebViewData.h:
3269
3270 2011-02-28  Oliver Hunt  <oliver@apple.com>
3271
3272         Reviewed by Gavin Barraclough.
3273
3274         Make ScopeChainNode GC allocated
3275         https://bugs.webkit.org/show_bug.cgi?id=55283
3276
3277         More updates for the absence of the ScopeChain class
3278
3279         * WebView/WebScriptDebugDelegate.mm:
3280         (-[WebScriptCallFrame scopeChain]):
3281
3282 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
3283
3284         Reviewed by Pavel Feldman.
3285
3286         DumpRenderTree should reset frame opener between tests.
3287         https://bugs.webkit.org/show_bug.cgi?id=54874
3288
3289         Added clearOpener method to WebFramePrivate.
3290
3291         * WebView/WebFrame.mm:
3292         (-[WebFrame _clearOpener]):
3293         * WebView/WebFramePrivate.h:
3294
3295 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
3296
3297         Unreviewed, rolling out r79764.
3298         http://trac.webkit.org/changeset/79764
3299         https://bugs.webkit.org/show_bug.cgi?id=55295
3300
3301         "broke Chromium builds" (Requested by rniwa on #webkit).
3302
3303         * WebView/WebFrame.mm:
3304         * WebView/WebFramePrivate.h:
3305
3306 2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>
3307
3308         Reviewed by David Kilzer.
3309
3310         https://bugs.webkit.org/show_bug.cgi?id=48781
3311
3312         Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
3313
3314         Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
3315         should paint the default broken image when an image fails to load or decode.  The method also passes the
3316         URL of the failed image.
3317
3318         * WebCoreSupport/WebFrameLoaderClient.h:
3319         * WebCoreSupport/WebFrameLoaderClient.mm:
3320         (WebFrameLoaderClient::shouldPaintBrokenImage):
3321         * WebView/WebDelegateImplementationCaching.h:
3322         * WebView/WebDelegateImplementationCaching.mm: Added case for passing one object.
3323         (CallResourceLoadDelegateReturningBoolean):
3324         * WebView/WebResourceLoadDelegatePrivate.h:
3325         * WebView/WebView.mm:
3326         (-[WebView _cacheResourceLoadDelegateImplementations]):
3327
3328 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
3329
3330         Reviewed by Pavel Feldman.
3331
3332         DumpRenderTree should reset frame opener between tests.
3333         https://bugs.webkit.org/show_bug.cgi?id=54874
3334
3335         Added clearOpener method to WebFramePrivate.
3336
3337         * WebView/WebFrame.mm:
3338         (-[WebFrame _clearOpener]):
3339         * WebView/WebFramePrivate.h:
3340
3341 2011-02-25  Mark Rowe  <mrowe@apple.com>
3342
3343         <rdar://problem/8902546> Build fix.
3344
3345         * Misc/QuickDrawCompatibility.h:
3346
3347 2011-02-24  Anders Carlsson  <andersca@apple.com>
3348
3349         Fix clang build.
3350
3351         * WebCoreSupport/WebKeyGenerator.m:
3352         (toWebCertificateParseResult):
3353         (-[WebKeyGenerator addCertificatesToKeychainFromData:]):
3354         * WebView/WebTextCompletionController.mm:
3355
3356 2011-02-24  Peter Kasting  <pkasting@google.com>
3357
3358         Reviewed by Eric Seidel.
3359
3360         Drop the "U; " encryption level from the User Agent string.
3361         https://bugs.webkit.org/show_bug.cgi?id=54566
3362
3363         * WebView/WebView.mm:
3364         (+[WebView _standardUserAgentWithApplicationName:]):
3365
3366 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
3367
3368         Unreviewed, rolling out r79570.
3369         http://trac.webkit.org/changeset/79570
3370         https://bugs.webkit.org/show_bug.cgi?id=54874
3371
3372         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
3373         was not updated
3374
3375         * WebView/WebFrame.mm:
3376         * WebView/WebFramePrivate.h:
3377
3378 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
3379
3380         Reviewed by Alexey Proskuryakov.
3381
3382         DumpRenderTree should reset frame opener between tests.
3383         https://bugs.webkit.org/show_bug.cgi?id=54874
3384
3385         Added clearOpener method to WebFramePrivate.
3386
3387         * WebView/WebFrame.mm:
3388         (-[WebFrame _clearOpener]):
3389         * WebView/WebFramePrivate.h:
3390
3391 2011-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3392
3393         Reviewed by Alexey Proskuryakov.
3394
3395         Drop the language tag part from the User Agent string
3396         https://bugs.webkit.org/show_bug.cgi?id=54560
3397
3398         * WebView/WebView.mm:
3399         (+[WebView _standardUserAgentWithApplicationName:]): Drop the
3400         language tag part.
3401
3402 2011-02-22  Brady Eidson  <beidson@apple.com>
3403
3404         Reviewed by Anders Carlsson.
3405
3406         Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
3407         API to view and delete Application Cache data by origin.
3408
3409         * WebCoreSupport/WebApplicationCache.mm:
3410         (+[WebApplicationCache deleteAllApplicationCaches]): Move this implementation into WebCore itself.
3411
3412 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
3413
3414         Reviewed by Kent Tamura.
3415
3416         Rename Position::node() to Position::deprecatedNode()
3417         https://bugs.webkit.org/show_bug.cgi?id=54622
3418
3419         * WebView/WebFrame.mm:
3420         (-[WebFrame _smartDeleteRangeForProposedRange:]):
3421
3422 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
3423
3424         Reviewed by Kent Tamura.
3425
3426         Rename Position::node() to Position::deprecatedNode()
3427         https://bugs.webkit.org/show_bug.cgi?id=54622
3428         
3429         Done the rename.
3430
3431         * WebView/WebFrame.mm:
3432         (-[WebFrame _smartDeleteRangeForProposedRange:]): Since newStart and newEnd are parent-anchored,
3433         use containerNode() and offsetInContainerNode() instead of deprecated member functions.
3434
3435 2011-02-18  Gavin Barraclough  <barraclough@apple.com>
3436
3437         Reviewed by Sam Weinig.
3438
3439         Bug 54786 - Devirtualize JSCell::classInfo()
3440
3441         Instead of making a virtual function call, add a pointer to the ClassInfo
3442         onto Structure.
3443
3444         This removes a virtual function call, and paves the way towards removing all
3445         the createStructure methods, and StructureFlags/AnonymousSlotCount properties
3446         (these should be able to move onto ClassInfo).
3447
3448         Calls to Structure::create must now pass a pointer to the ClassInfo for the
3449         structure. All objects now have a ClassInfo pointer, non-object cell types
3450         still do not.
3451
3452         Changes are most mechanical, involving three steps:
3453             * Remove virtual classInfo() methods.
3454             * Add &s_info parameter to calls to Structure::create.
3455             * Rename ClassInfo static members on classes from 'info' to 's_info',
3456               for consistency.
3457
3458         * Plugins/Hosted/ProxyInstance.mm:
3459         (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
3460         (WebKit::ProxyRuntimeMethod::createStructure):
3461         * Plugins/Hosted/ProxyRuntimeObject.h:
3462         (WebKit::ProxyRuntimeObject::createStructure):
3463         * Plugins/Hosted/ProxyRuntimeObject.mm:
3464         (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
3465         * WebView/WebView.mm:
3466         (aeDescFromJSValue):
3467
3468 2011-02-19  Brian Ryner  <bryner@chromium.org>
3469
3470         Reviewed by Adam Barth.
3471
3472         Add missing #include of DocumentLoader.h, needed since the transitive
3473         include through Document.h is removed.
3474         https://bugs.webkit.org/show_bug.cgi?id=50489
3475
3476         * WebView/WebFrame.mm:
3477
3478 2011-02-19  Charlie Reis  <creis@chromium.org>
3479
3480         Reviewed by Mihai Parparita.
3481
3482         Ensure loading has stopped in HistoryController::goToItem
3483         https://bugs.webkit.org/show_bug.cgi?id=54517
3484
3485         Add a FrameLoaderClient callback for whether to stop loading before goToItem.
3486
3487         Test: http/tests/navigation/forward-to-fragment-fires-onload.html
3488
3489         * WebCoreSupport/WebFrameLoaderClient.mm:
3490         (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
3491         * WebCoreSupport/WebFrameLoaderClient.h:
3492
3493 2011-02-16  David Hyatt  <hyatt@apple.com>
3494
3495         Reviewed by Dan Bernstein.
3496
3497         https://bugs.webkit.org/show_bug.cgi?id=54244
3498         
3499         Convert the line box tree to floating point and eliminate font rounding hacks.  This patch removes all of the rounding
3500         hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
3501         
3502         The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
3503         been changed as well.
3504         
3505         In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
3506         
3507         Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
3508         
3509         Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
3510         still have a precise floating point position.
3511
3512         Justification will now allow subpixel positioning to occur as well.  Platforms that don't support subpixel positioning should already
3513         be rounding justification spacing in their font code.
3514
3515         Many layout test results change on Mac, since rounding hacks were used there and are now gone.
3516
3517         * Misc/WebKitNSStringExtras.mm:
3518         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
3519         (-[NSString _web_widthWithFont:]):
3520
3521 2011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
3522
3523         Reviewed by Adam Roben.
3524
3525         HTML5 <details> and <summary>: localized text
3526         https://bugs.webkit.org/show_bug.cgi?id=54260
3527
3528         The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
3529         provide the default label to be used by a <details> tag that has no <summary> child.
3530
3531         * WebCoreSupport/WebPlatformStrategies.h:
3532         * WebCoreSupport/WebPlatformStrategies.mm:
3533         (WebPlatformStrategies::defaultDetailsSummaryText):
3534
3535 2011-02-16  Matthew Delaney  <mdelaney@apple.com>
3536
3537         Reviewed by Simon Fraser.
3538
3539         Allow acceleratesDrawing for WebKit2
3540         https://bugs.webkit.org/show_bug.cgi?id=54511
3541
3542         Plumb through preference for accelerated drawing.
3543         
3544         * WebView/WebPreferenceKeysPrivate.h:
3545         * WebView/WebPreferences.mm:
3546         (+[WebPreferences initialize]):
3547         (-[WebPreferences acceleratedDrawingEnabled]):
3548         (-[WebPreferences setAcceleratedDrawingEnabled:]):
3549         * WebView/WebPreferencesPrivate.h:
3550
3551 2011-02-15  David Kilzer  <ddkilzer@apple.com>
3552
3553         <http://webkit.org/b/54505> Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h
3554
3555         Reviewed by Darin Adler.
3556