c3c28ccf22e36bba8b7de32c278caf6e931d4e4c
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2011-06-29  Darin Adler  <darin@apple.com>
2
3         Reviewed by Dan Bernstein.
4
5         [Mac] Use system cursors instead of custom bitmaps where possible
6         https://bugs.webkit.org/show_bug.cgi?id=63679
7
8         * WebCoreSupport/WebSystemInterface.mm:
9         (InitWebCoreSystemInterface): Added WKCursor.
10
11 2011-06-28  Ilya Sherman  <isherman@chromium.org>
12
13         Reviewed by Adam Barth.
14
15         form.autocomplete="off" does not work
16         https://bugs.webkit.org/show_bug.cgi?id=35823
17
18         * WebView/WebHTMLRepresentation.mm:
19         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Update callsite.
20
21 2011-06-26  Mark Rowe  <mrowe@apple.com>
22
23         Reviewed by Dan Bernstein.
24
25         Use a separate file name for Lion's WebKitSystemInterface.
26
27         * Configurations/DebugRelease.xcconfig:
28
29 2011-06-24  Dan Bernstein  <mitz@apple.com>
30
31         Reviewed by Anders Carlsson.
32
33         Add an option to enable legacy rounding hacks
34         https://bugs.webkit.org/show_bug.cgi?id=63363
35
36         * Misc/WebKitNSStringExtras.mm:
37         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
38         Disabled rounding hacks.
39         (-[NSString _web_widthWithFont:]): Ditto.
40         * WebView/WebView.mm:
41         (+[WebView _setAllowsRoundingHacks:]): Added this setter.
42         * WebView/WebViewPrivate.h:
43
44 2011-06-24  Dominic Cooney  <dominicc@chromium.org>
45
46         Reviewed by Dimitri Glazkov.
47
48         Convert shadow DOM-related tests to use window.internals
49         https://bugs.webkit.org/show_bug.cgi?id=61671
50
51         Remove shadow DOM-related methods from Mac API. These are not
52         required any more.
53
54         * DOM/WebDOMOperations.mm:
55         * DOM/WebDOMOperationsPrivate.h:
56
57 2011-06-24  Yuta Kitamura  <yutak@chromium.org>
58
59         Reviewed by Adam Barth.
60
61         WebSocket: Add run-time flag for new HyBi protocol
62         https://bugs.webkit.org/show_bug.cgi?id=60348
63
64         Make a new flag (Setting::m_useHixie76WebSocketProtocol)
65         switchable from WebView and WebPreferences.
66
67         * WebView/WebPreferenceKeysPrivate.h:
68         * WebView/WebPreferences.mm:
69         (+[WebPreferences initialize]):
70         (-[WebPreferences setHixie76WebSocketProtocolEnabled:]):
71         (-[WebPreferences isHixie76WebSocketProtocolEnabled]):
72         * WebView/WebPreferencesPrivate.h:
73         * WebView/WebView.mm:
74         (-[WebView _preferencesChanged:]):
75
76 2011-06-22  Sam Weinig  <sam@webkit.org>
77
78         Roll out r89469 (Add preference for setting the html parser depth limit)
79
80         The preference is not needed at this time, so there is no reason to expose it.
81
82         * WebView/WebPreferenceKeysPrivate.h:
83         * WebView/WebPreferences.mm:
84         (+[WebPreferences initialize]):
85         * WebView/WebPreferencesPrivate.h:
86         * WebView/WebView.mm:
87         (-[WebView _preferencesChanged:]):
88
89 2011-06-22  Sam Weinig  <sam@webkit.org>
90
91         Reviewed by Adam Barth.
92
93         Add preference for setting the html parser depth limit
94         https://bugs.webkit.org/show_bug.cgi?id=63163
95
96         * WebView/WebPreferenceKeysPrivate.h:
97         * WebView/WebPreferences.mm:
98         (+[WebPreferences initialize]):
99         (-[WebPreferences setMaximumHTMLParserDOMTreeDepth:]):
100         (-[WebPreferences maximumHTMLParserDOMTreeDepth]):
101         * WebView/WebPreferencesPrivate.h:
102         * WebView/WebView.mm:
103         (-[WebView _preferencesChanged:]):
104         Add private preference for setting the parser depth limit.
105
106 2011-06-22  Ryosuke Niwa  <rniwa@webkit.org>
107
108         Reviewed by Darin Adler.
109
110         Make instantiation of legacy editing position more explicit
111         https://bugs.webkit.org/show_bug.cgi?id=63037
112
113         Create new positions since we can't create a legacy editing position outside of WebCore anymore.
114
115         * WebView/WebFrame.mm:
116         (-[WebFrame _smartDeleteRangeForProposedRange:]): Calls createLegacyEditingPosition.
117         (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
118
119 2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
120
121         Reviewed by Kent Tamura.
122
123         FileChooser should be only created when we need to choose files.
124         https://bugs.webkit.org/show_bug.cgi?id=63039
125
126         * WebCoreSupport/WebChromeClient.mm:
127         (WebChromeClient::runOpenPanel): Changed to use settings.
128
129 2011-06-21  MORITA Hajime  <morrita@google.com>
130
131         Unreviewed, rolling out r89401 and r89403.
132         http://trac.webkit.org/changeset/89401
133         http://trac.webkit.org/changeset/89403
134         https://bugs.webkit.org/show_bug.cgi?id=62970
135
136         Breaks mac build and mistakenly enables the spellcheck API
137
138         * Configurations/FeatureDefines.xcconfig:
139
140 2011-06-20  MORITA Hajime  <morrita@google.com>
141
142         Reviewed by Kent Tamura.
143
144         Spellcheck API should be build-able.
145         https://bugs.webkit.org/show_bug.cgi?id=62970
146
147         No new tests, changing only build related files
148
149         * Configurations/FeatureDefines.xcconfig:
150
151 2011-06-21  Sheriff Bot  <webkit.review.bot@gmail.com>
152
153         Unreviewed, rolling out r89354.
154         http://trac.webkit.org/changeset/89354
155         https://bugs.webkit.org/show_bug.cgi?id=63099
156
157         Broke tests on Mac (Requested by rniwa on #webkit).
158
159         * WebCoreSupport/WebInspectorClient.mm:
160         (-[WebInspectorWindowController destroyInspectorView:]):
161         * WebInspector/WebInspector.mm:
162         (-[WebInspector show:]):
163         (-[WebInspector showConsole:]):
164         (-[WebInspector isDebuggingJavaScript]):
165         (-[WebInspector toggleDebuggingJavaScript:]):
166         (-[WebInspector startDebuggingJavaScript:]):
167         (-[WebInspector stopDebuggingJavaScript:]):
168         (-[WebInspector isProfilingJavaScript]):
169         (-[WebInspector toggleProfilingJavaScript:]):
170         (-[WebInspector startProfilingJavaScript:]):
171         (-[WebInspector stopProfilingJavaScript:]):
172         (-[WebInspector isJavaScriptProfilingEnabled]):
173         (-[WebInspector setJavaScriptProfilingEnabled:]):
174         (-[WebInspector isTimelineProfilingEnabled]):
175         (-[WebInspector setTimelineProfilingEnabled:]):
176         (-[WebInspector setFrontend:]):
177         (-[WebInspector showWindow:]):
178         * WebInspector/WebInspectorFrontend.h:
179         * WebInspector/WebInspectorFrontend.mm:
180         * WebInspector/WebInspectorPrivate.h:
181
182 2011-06-20  Pavel Feldman  <pfeldman@chromium.org>
183
184         Reviewed by Yury Semikhatsky.
185
186         Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
187         https://bugs.webkit.org/show_bug.cgi?id=62985
188
189         Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
190         methods for plumbing the menu action handlers through the WebKit and WebCore.
191         I intend to remove this menu support from the protocol and WebCore/InspectorController API.
192         I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
193         WebKit/win and WebKit2 to follow.
194
195         * WebCoreSupport/WebInspectorClient.mm:
196         (-[WebInspectorWindowController destroyInspectorView:]):
197         * WebInspector/WebInspector.mm:
198         (-[WebInspector showWindow]):
199         (-[WebInspector show:]):
200         (-[WebInspector showConsole:]):
201         (-[WebInspector isDebuggingJavaScript]):
202         (-[WebInspector toggleDebuggingJavaScript:]):
203         (-[WebInspector startDebuggingJavaScript:]):
204         (-[WebInspector stopDebuggingJavaScript:]):
205         (-[WebInspector isProfilingJavaScript]):
206         (-[WebInspector toggleProfilingJavaScript:]):
207         (-[WebInspector startProfilingJavaScript:]):
208         (-[WebInspector stopProfilingJavaScript:]):
209         (-[WebInspector isJavaScriptProfilingEnabled]):
210         (-[WebInspector setJavaScriptProfilingEnabled:]):
211         (-[WebInspector isTimelineProfilingEnabled]):
212         (-[WebInspector setTimelineProfilingEnabled:]):
213         (-[WebInspector setFrontend:]):
214         (-[WebInspector releaseFrontend]):
215         (-[WebInspector showWindow:]):
216         * WebInspector/WebInspectorFrontend.h:
217         * WebInspector/WebInspectorFrontend.mm:
218         (-[WebInspectorFrontend isDebuggingEnabled]):
219         (-[WebInspectorFrontend setDebuggingEnabled:]):
220         (-[WebInspectorFrontend isProfilingJavaScript]):
221         (-[WebInspectorFrontend startProfilingJavaScript]):
222         (-[WebInspectorFrontend stopProfilingJavaScript]):
223         (-[WebInspectorFrontend isJavaScriptProfilingEnabled]):
224         (-[WebInspectorFrontend setJavaScriptProfilingEnabled:]):
225         (-[WebInspectorFrontend isTimelineProfilingEnabled]):
226         (-[WebInspectorFrontend setTimelineProfilingEnabled:]):
227         * WebInspector/WebInspectorPrivate.h:
228
229 2011-06-01  Jer Noble  <jer.noble@apple.com>
230
231         Reviewed by Eric Carlson.
232
233         Move Full Screen Controllers into WebCore.
234
235         Remove dependency on QTKit from wekitExitFullscreen()
236         https://bugs.webkit.org/show_bug.cgi?id=61843
237
238         WebVideoFullscreenController, WebVideoFullscreenHUDController, and WebWindowAnimation
239         have been moved into WebCore.
240
241         * WebCoreSupport/WebSystemInterface.mm:
242         (InitWebCoreSystemInterface): Add support for four WKSI functions in WCSI.
243         * WebView/WebFullScreenController.mm: Remove unused #include.
244         * WebView/WebView.mm: Change the include location of 
245             WebVideoFullscreenController.h
246
247 2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
248
249         Reviewed by Darin Adler.
250
251         Separate concerns of loading file icons and choosing files.
252         https://bugs.webkit.org/show_bug.cgi?id=62931
253
254         * WebCoreSupport/WebChromeClient.h:
255         * WebCoreSupport/WebChromeClient.mm:
256         (WebChromeClient::loadIconForFiles): Renamed.
257
258 2011-06-18  Andrew Wellington  <andrew@webkit.org>
259
260         Reviewed by Alexey Proskuryakov.
261
262         https://bugs.webkit.org/show_bug.cgi?id=62843
263         WebKit Mac API calls didReceiveAuthenticationChallenge instead of
264         didCancelAuthenticationChallenge
265
266         * WebView/WebView.mm:
267         (-[WebView _cacheResourceLoadDelegateImplementations]):
268
269 2011-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
270
271         Unreviewed, rolling out r89026.
272         http://trac.webkit.org/changeset/89026
273         https://bugs.webkit.org/show_bug.cgi?id=62804
274
275         These patches were likely correct.  I'll investigate the
276         browser_test failures. (Requested by abarth on #webkit).
277
278         * WebView/WebVideoFullscreenHUDWindowController.mm:
279         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
280
281 2011-06-16  Vitaly Repeshko  <vitalyr@chromium.org>
282
283         Unreviewed.
284
285         Revert Adam's user gesture patch series r89002, r89005, r89007, r89018
286         https://bugs.webkit.org/show_bug.cgi?id=62796
287
288         The patches broke chromium browser tests.
289
290         * WebView/WebVideoFullscreenHUDWindowController.mm:
291         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
292
293 2011-06-16  Adam Barth  <abarth@webkit.org>
294
295         Reviewed by Eric Seidel.
296
297         Remove HTMLVideoElement::processingUserGesture
298         https://bugs.webkit.org/show_bug.cgi?id=62784
299
300         * WebView/WebVideoFullscreenHUDWindowController.mm:
301         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
302
303 2011-06-15  Adam Barth  <abarth@webkit.org>
304
305         Reviewed by Eric Seidel.
306
307         Remove ScriptController::setAllowPopupsFromPlugin
308         https://bugs.webkit.org/show_bug.cgi?id=62706
309
310         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
311         (WebKit::NetscapePluginInstanceProxy::evaluate):
312         * Plugins/WebNetscapePluginView.mm:
313         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
314
315 2011-06-15  David Kilzer  <ddkilzer@apple.com>
316
317         <http://webkit.org/b/62745> Convert WebNSFileManagerExtras.m to Objective-C++
318
319         Reviewed by Joseph Pecoraro.
320
321         * Misc/WebNSFileManagerExtras.mm: Renamed from Source/WebKit/mac/Misc/WebNSFileManagerExtras.m.
322         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
323         Added static_cast<MetaDataInfo *>.
324
325 2011-06-14  Stephanie Lewis  <slewis@apple.com>
326
327         Rubber stamped by Oliver Hunt.
328
329         <rdar://problem/9511169>
330         Update order files.
331
332         * WebKit.order:
333
334 2011-06-13  Kentaro Hara  <haraken@google.com>
335
336         Reviewed by Alexey Proskuryakov.
337
338         Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
339         https://bugs.webkit.org/show_bug.cgi?id=61256
340
341         In order to prevent rounding error caused by expanding/shrinking a page
342         using different calculation here and there, I added a common calculation
343         method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
344         keeping the ratio of width and height of the original page.
345         [WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]
346         and [WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]
347         use resizePageRectsKeepingRatio() to expand/shrink a page.
348
349         Test: printing/page-count-with-one-word.html
350
351         * WebView/WebHTMLView.mm:
352         (-[WebHTMLView _web_setPrintingModeRecursive]):
353         (-[WebHTMLView _web_clearPrintingModeRecursive]):
354         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
355         (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumShrinkRatio:]):
356         (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
357         (-[WebHTMLView _endPrintMode]):
358         (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
359         (-[WebHTMLView _endScreenPaginationMode]):
360         (-[WebHTMLView layoutToMinimumPageWidth:height:maximumShrinkRatio:adjustingViewSize:]):
361         (-[WebHTMLView layout]):
362         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
363         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
364         (-[WebHTMLView setPageWidthForPrinting:]):
365
366 2011-06-13  Tony Chang  <tony@chromium.org>
367
368         Reviewed by Dimitri Glazkov.
369
370         rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
371         https://bugs.webkit.org/show_bug.cgi?id=62578
372
373         * Configurations/FeatureDefines.xcconfig:
374
375 2011-06-13  Tony Chang  <tony@chromium.org>
376
377         Reviewed by Adam Barth.
378
379         rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
380         https://bugs.webkit.org/show_bug.cgi?id=62545
381
382         * Configurations/FeatureDefines.xcconfig:
383
384 2011-06-12  Adam Barth  <abarth@webkit.org>
385
386         Reviewed by Alexey Proskuryakov.
387
388         Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
389         https://bugs.webkit.org/show_bug.cgi?id=62516
390
391         * WebCoreSupport/WebFrameLoaderClient.h:
392         * WebCoreSupport/WebFrameLoaderClient.mm:
393         (WebFrameLoaderClient::interruptedForPolicyChangeError):
394
395 2011-06-12  Adam Barth  <abarth@webkit.org>
396
397         Reviewed by Eric Seidel.
398
399         Remove FrameLoader::isProcessingUserGesture
400         https://bugs.webkit.org/show_bug.cgi?id=62519
401
402         * WebView/WebView.mm:
403         (-[WebView _isProcessingUserGesture]):
404
405 2011-06-12  Adam Barth  <abarth@webkit.org>
406
407         Reviewed by Alexey Proskuryakov.
408
409         Remove trival "forward-to-client" member functions from FrameLoader
410         https://bugs.webkit.org/show_bug.cgi?id=62510
411
412         * WebCoreSupport/WebFrameNetworkingContext.mm:
413         (WebFrameNetworkingContext::blockedError):
414
415 2011-06-10  Tony Chang  <tony@chromium.org>
416
417         Reviewed by Ojan Vafai.
418
419         add a compile guard ENABLE(FLEXBOX)
420         https://bugs.webkit.org/show_bug.cgi?id=62049
421
422         * Configurations/FeatureDefines.xcconfig:
423
424 2011-06-06  Michael Saboff  <msaboff@apple.com>
425
426         Reviewed by Geoffrey Garen.
427
428         Fonts returned by FontCache::getFontDataForCharacters() are never released
429         https://bugs.webkit.org/show_bug.cgi?id=61875
430
431         This change allows fonts allocated as system fallback fonts to be
432         released.  Previously, the reference counts for these fonts grew
433         without bound.  This is implemented as an auto release class that wraps
434         accesses to the cache for system fallback fonts. All such accesses are
435         via the method FontCache::getFontDataForCharacters. The new class is
436         called FontCachePurgePreventer. When such an object exists, it protects
437         these fonts from deletion.
438
439         See more comments for this defect in Source/WebCore/ChangeLog.
440
441         * Misc/WebKitNSStringExtras.mm:
442         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
443         (-[NSString _web_widthWithFont:]):
444         Wrapped code accessing fallback fonts with local
445         FontCachePurgePreventer in these methods.
446
447         * Misc/WebStringTruncator.mm:
448         (+[WebStringTruncator centerTruncateString:toWidth:]):
449         (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):
450         (+[WebStringTruncator rightTruncateString:toWidth:withFont:]):
451         (+[WebStringTruncator widthOfString:font:]):
452         Wrapped code accessing fallback fonts with local
453         FontCachePurgePreventer in these methods.
454
455 2011-06-06  Peter Kasting  <pkasting@google.com>
456
457         Reviewed by Antonio Gomes.
458
459         Remove unnecessary args from scroll functions.
460         https://bugs.webkit.org/show_bug.cgi?id=61648
461
462         * WebView/WebFrame.mm:
463         (-[WebFrame _scrollDOMRangeToVisible:]):
464
465 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
466
467         Reviewed by Kent Tamura.
468
469         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
470         https://bugs.webkit.org/show_bug.cgi?id=61628
471
472         * Configurations/FeatureDefines.xcconfig:
473
474 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
475
476         Reviewed by Kent Tamura.
477
478         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
479         https://bugs.webkit.org/show_bug.cgi?id=61631
480
481         * Configurations/FeatureDefines.xcconfig:
482
483 2011-06-02  Anders Carlsson  <andersca@apple.com>
484
485         Reviewed by Sam Weinig.
486
487         Need a way to install the memory pressure handler without initializing WebKit1
488         https://bugs.webkit.org/show_bug.cgi?id=61975
489
490         Add a WebInstallMemoryPressureHandler function which will install the memory pressure handler.
491         -[WebView WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:] will do this,
492         but we'd like to be able to install a memory pressure handler without creating a WebView or even
493         calling any WebView method since that will call +[WebView initialize].
494
495         * WebKit.exp:
496         * WebView/WebView.mm:
497         (WebInstallMemoryPressureHandler):
498         * WebView/WebViewPrivate.h:
499
500 2011-05-27  Stephanie Lewis  <slewis@apple.com>
501
502         Unreviewed.
503
504         Fix a typo in the order_file flag.
505
506         * Configurations/Base.xcconfig:
507
508 2011-05-27  Stephanie Lewis  <slewis@apple.com>
509
510         Rubber Stamped by Adam Roben.
511
512         Update Order Files.  Use -order_file flag since it can order more of the binary.
513
514         * Configurations/Base.xcconfig:
515         * WebKit.order:
516
517 2011-05-25  Stephanie Lewis  <slewis@apple.com>
518
519         Reviewed by Brady Eidson.
520
521         https://bugs.webkit.org/show_bug.cgi?id=61407
522         part of <rdar://problem/8675177>
523         Remove Quicklook pref.  Moving it enirely down into WebCore so it can
524         be calculated only on reloads.
525
526         * WebView/WebPreferenceKeysPrivate.h:
527         * WebView/WebPreferences.mm:
528         (+[WebPreferences initialize]):
529         * WebView/WebPreferencesPrivate.h:
530         * WebView/WebView.mm:
531         (-[WebView _preferencesChanged:]):
532
533 2011-05-24  Jer Noble  <jer.noble@apple.com>
534
535         Reviewed by Darin Adler.
536
537         Video fails to play on Vimeo
538         https://bugs.webkit.org/show_bug.cgi?id=61403
539
540         * WebCoreSupport/WebSystemInterface.mm:
541         (InitWebCoreSystemInterface): Added support for wkAVAssetResolvedURL and
542             wkQTMovieResolvedURL.
543
544 2011-05-24  Keishi Hattori  <keishi@webkit.org>
545
546         Reviewed by Kent Tamura.
547
548         Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer.
549         https://bugs.webkit.org/show_bug.cgi?id=61273
550
551         * Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag.
552
553 2011-05-24  Adam Barth  <abarth@webkit.org>
554
555         Reviewed by Eric Seidel.
556
557         Add FIXME comments about removing FrameLoader::isProcessingUserGesture
558         https://bugs.webkit.org/show_bug.cgi?id=61395
559
560         * WebView/WebView.mm:
561         (-[WebView _isProcessingUserGesture]):
562
563 2011-05-24  Michael Saboff  <msaboff@apple.com>
564
565         Reviewed by Geoffrey Garen.
566
567         Improve handling in WebCore of low memory situations
568         https://bugs.webkit.org/show_bug.cgi?id=61222
569
570         Added call to enable memory pressure handling.
571
572         * WebView/WebView.mm:
573         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
574         * WebView/WebViewInternal.h:
575
576 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
577
578         Rubberstamped by David Kilzer.
579
580         Updated some files that I forgot in my previous MHTML CL.
581
582         * Configurations/FeatureDefines.xcconfig:
583
584 2011-05-20  Jeremy Noble  <jer.noble@apple.com>
585
586         Reviewed by Simon Fraser.
587
588         Stack overflow in WebFullScreenController when built on Leopard and run on SnowLeopard.
589         https://bugs.webkit.org/show_bug.cgi?id=61224
590
591         Remove the CATransaction(SnowLeopardConvenience) functions, and replace them with the Leopard
592         versions of same.
593
594         * WebView/WebFullScreenController.mm:
595         (-[WebFullScreenController windowDidEnterFullscreen:]):
596         (-[WebFullScreenController enterFullscreen:]):
597         (-[WebFullScreenController exitFullscreen]):
598         (-[WebFullscreenWindow setRendererLayer:]):
599
600 2011-05-20  Andy Estes  <aestes@apple.com>
601
602         Reviewed by Darin Adler.
603
604         WebView loses firstResponder status when entering full-screen mode.
605         https://bugs.webkit.org/show_bug.cgi?id=61153
606
607         * Misc/WebNSWindowExtras.h:
608         * Misc/WebNSWindowExtras.m:
609         (-[NSWindow makeResponder:firstResponderIfDescendantOfView:]): Add a
610         convenience method to NSWindow that makes the given NSResponder first
611         responder only if it is a descendant of the given view.
612         * WebView/WebFullScreenController.mm:
613         (-[WebFullScreenController windowDidEnterFullscreen:]): If the WebView
614         was a descendant of the browser window's first responder when entering
615         full-screen mode, set the full-screen window's first responder to that
616         same NSResponder.
617         (-[WebFullScreenController exitFullscreen]): Do the reverse of what is
618         done in windowDidEnterFullscreen:.
619
620 2011-05-20  Enrica Casucci  <enrica@apple.com>
621
622         Reviewed by David Kilzer.
623
624         Add delegate methods about focus and blur to all elements.
625         https://bugs.webkit.org/show_bug.cgi?id=61218
626
627         We want to have delegates for these events for all the elements, not only the form elements.
628         The patch changes the name of the methods in a way that is not form element specific.
629
630         * WebCoreSupport/WebChromeClient.h:
631         * WebCoreSupport/WebChromeClient.mm:
632         (WebChromeClient::elementDidFocus):
633         (WebChromeClient::elementDidBlur):
634         * WebView/WebUIDelegatePrivate.h:
635
636 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
637
638         Reviewed by Sam Weinig.
639
640         numberOfActiveAnimations() can include animations from documents in the page cache
641         https://bugs.webkit.org/show_bug.cgi?id=53641
642
643         Pass the Frame's document as the one to count animations on.
644
645         * WebView/WebFrame.mm:
646         (-[WebFrame _numberOfActiveAnimations]):
647
648 2011-05-17  Timothy Hatcher  <timothy@apple.com>
649
650         Update the the context menu to reflect the system search provider on Mac.
651
652         <rdar://problem/9198419>
653
654         Reviewed by Sam Weinig.
655
656         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
657         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): Use wkCopyDefaultSearchProviderDisplayName to
658         create the web search context menu title.
659         * WebCoreSupport/WebSystemInterface.mm:
660         (InitWebCoreSystemInterface): Added CopyDefaultSearchProviderDisplayName.
661
662 2011-05-16  Emil A Eklund  <eae@chromium.org>
663
664         Reviewed by Eric Seidel.
665
666         Replace docTop/Right/Bottom/Left/Width/Height with documentRect
667         https://bugs.webkit.org/show_bug.cgi?id=60743
668
669         Replace uses of docWidth/Height with documentRect.
670
671         * WebView/WebFrame.mm:
672         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
673
674 2011-05-16  Yuzo Fujishima  <yuzo@google.com>
675
676         Reviewed by Antti Koivisto.
677
678         Fix for Bug 43704 - Web font is printed as blank if it is not cached
679         https://bugs.webkit.org/show_bug.cgi?id=43704
680
681         * WebView/WebHTMLView.mm:
682         (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]): Use ResourceCacheValidationSuppressor to allow stale resources in printing.
683
684 2011-05-16  David Kilzer  <ddkilzer@apple.com>
685
686         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
687         <rdar://problem/9446430>
688
689         Reviewed by Mark Rowe.
690
691         * Configurations/Base.xcconfig: Fixed typo.
692
693 2011-05-13  Jon Lee  <jonlee@apple.com>
694
695         Reviewed by Simon Fraser.
696
697         Can't horizontally scroll iframes and overflow because wheel events are always accepted
698         https://bugs.webkit.org/show_bug.cgi?id=60779
699
700         * WebCoreSupport/WebChromeClient.h:
701         (WebChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method
702         (WebChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
703
704 2011-05-13  Sam Weinig  <sam@webkit.org>
705
706         Reviewed by Anders Carlsson.
707
708         Prune #includes from FrameView.h (Part 2)
709         https://bugs.webkit.org/show_bug.cgi?id=60748
710
711         - Update files that were depending on FrameView.h #including Frame.h or
712           Page.h.
713
714         * WebView/WebClipView.mm:
715         * WebView/WebHTMLView.mm:
716         (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
717
718 2011-05-12  Pratik Solanki  <psolanki@apple.com>
719
720         Reviewed by Antti Koivisto.
721
722         Part of WebCore should use CFNetwork-based loader on Mac
723         https://bugs.webkit.org/show_bug.cgi?id=51836
724
725         Use CFRunLoop when using CFNetwork.
726
727         * WebView/WebView.mm:
728         (-[WebView scheduleInRunLoop:forMode:]):
729         (-[WebView unscheduleFromRunLoop:forMode:]):
730
731 2011-05-12  Pratik Solanki  <psolanki@apple.com>
732
733         Reviewed by Antti Koivisto.
734
735         Part of WebCore should use CFNetwork-based loader on Mac
736         https://bugs.webkit.org/show_bug.cgi?id=51836
737
738         Include AuthenticationCF.h header file.
739
740         * Misc/WebDownload.mm:
741         * Plugins/WebBaseNetscapePluginView.mm:
742         * WebCoreSupport/WebFrameLoaderClient.mm:
743
744 2011-05-12  Adele Peterson  <adele@apple.com>
745
746         Reviewed by Darin Adler and Adam Barth.
747
748         Fix for <rdar://problem/9253454> Solar Walk For Mac: Info window is blank (HTML5 parser)
749         https://bugs.webkit.org/show_bug.cgi?id=60685
750
751         Solar Walk uses a self closing title tag, so to match the behavior of the old parser, 
752         we use a UserScript to write the contents of the title element to the end of the document so it can be re-parsed.
753
754         * Misc/SolarWalkQuirksUserScript.js: Added.
755         * WebView/WebView.mm:
756         (needsSolarWalkQuirksScript):
757         (leakSolarWalkQuirksUserScriptContents):
758         (-[WebView _injectSolarWalkQuirksScript]):
759         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
760
761 2011-05-12  Jia Pu  <jpu@apple.com>
762
763         Reviewed by Darin Adler.
764
765         Regression caused by changeset 86281
766         https://bugs.webkit.org/show_bug.cgi?id=60712
767         <rdar://problem/9427970>
768
769         Removed the condition variable. [NSSpellChecker dismissCorrectionIndicatorForView:] is blocking.
770         So handleAcceptedReplacement() triggered by dismissInternal() will return before dismissInternal()
771         returns. So we don't need to use the condition to coordinate between these two function. In fact,
772         all callbacks are delivered on main thread. We don't really need any locking here.
773
774         Since now we don't have distinction between dismiss() and dismissSoon(). dismissSoon() has
775         been removed.
776
777         * WebCoreSupport/CorrectionPanel.h:
778         * WebCoreSupport/CorrectionPanel.mm:
779         (CorrectionPanel::CorrectionPanel):
780         (CorrectionPanel::show):
781         (CorrectionPanel::dismiss):
782         (CorrectionPanel::dismissInternal):
783         (CorrectionPanel::handleAcceptedReplacement):
784         * WebCoreSupport/WebEditorClient.mm:
785         (WebEditorClient::dismissCorrectionPanelSoon):
786
787 2011-05-12  Patrick Gansterer  <paroga@webkit.org>
788
789         Reviewed by Adam Barth.
790
791         Enable OwnPtr strict mode in PluginHalter
792         https://bugs.webkit.org/show_bug.cgi?id=60681
793
794         * WebView/WebView.mm:
795         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
796
797 2011-05-12  Nikolas Zimmermann  <nzimmermann@rim.com>
798
799         Reviewed by Darin Adler.
800
801         String operator+ reallocates unnecessarily when concatting > 2 strings
802         https://bugs.webkit.org/show_bug.cgi?id=58420
803
804         Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.
805
806         * WebView/WebFrame.mm: Explicitely cast to Strings first, so operator NSString*() can be invoked.
807         (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]):
808
809 2011-05-10  Tony Gentilcore  <tonyg@chromium.org>
810
811         Reviewed by Darin Adler.
812
813         Perform some forward declarations suggested by include-what-you-use
814         https://bugs.webkit.org/show_bug.cgi?id=60545
815
816         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
817         * WebView/WebFrame.mm:
818
819 2011-05-11  Jia Pu  <jpu@apple.com>
820
821         Reviewed by Darin Adler.
822
823         CorrectionPanel sometimes hangs in dismissSoon().
824         https://bugs.webkit.org/show_bug.cgi?id=60599
825         <rdar://problem/9313628>
826
827         Make sure dismissSoon() won't wait indefinitely if handleAcceptedReplacement() sets m_resultForSynchronousDismissal
828         to nil. Added a designated variable m_isDismissing, instead of piggy-backing m_resultForSynchronousDismissal,
829         for condition checking.
830
831         * WebCoreSupport/CorrectionPanel.h:
832         * WebCoreSupport/CorrectionPanel.mm:
833         (CorrectionPanel::CorrectionPanel):
834         (CorrectionPanel::show):
835         (CorrectionPanel::dismissSoon):
836         (CorrectionPanel::dismissInternal):
837         (CorrectionPanel::handleAcceptedReplacement):
838
839 2011-05-10  Anton D'Auria  <adauria@apple.com>
840
841         Reviewed by David Levin.
842
843         Add ApplicationCache API to get disk usage per origin
844         https://bugs.webkit.org/show_bug.cgi?id=57127
845
846         Added Mac port API.
847
848         * WebCoreSupport/WebApplicationCache.h:
849         * WebCoreSupport/WebApplicationCache.mm:
850         (+[WebApplicationCache diskUsageForOrigin:]):
851
852 2011-05-10  Anton D'Auria  <adauria@apple.com>
853
854         Reviewed by Alexey Proskuryakov.
855
856         Add ApplicationCache API to get disk usage per origin
857         https://bugs.webkit.org/show_bug.cgi?id=57127
858
859         Added Mac port API.
860
861         * WebCoreSupport/WebApplicationCache.h:
862         * WebCoreSupport/WebApplicationCache.mm:
863         (+[WebApplicationCache diskUsageForOrigin:]):
864
865 2011-05-10  Beth Dakin  <bdakin@apple.com>
866
867         Reviewed by Darin Adler.
868
869         https://bugs.webkit.org/show_bug.cgi?id=60582
870         Crash switching overlay/non-overlay scrollbar preference still possible
871         -and corresponding-
872         <rdar://problem/9323983>
873
874         * WebCoreSupport/WebSystemInterface.mm:
875         (InitWebCoreSystemInterface):
876
877 2011-05-09  Jeremy Noble  <jer.noble@apple.com>
878
879         Reviewed by Darin Adler.
880
881         Command-~/Exposé to another window while <video> is in full screen, breaks Safari, eventually leading to crash
882         https://bugs.webkit.org/show_bug.cgi?id=60496
883
884         When animating into and out of full screen, order out and back in the original webView window,
885         disabling animations when necessary.  The exitFullscreen method was targeting the wrong window,
886         as the webView is hosted in the full screen window when we ask for it's parent window.
887
888         * WebView/WebFullScreenController.mm:
889         (-[WebFullScreenController windowDidEnterFullscreen:]):
890         (-[WebFullScreenController exitFullscreen]):
891
892 2011-05-04  Philippe Normand  <pnormand@igalia.com>
893
894         Reviewed by Dimitri Glazkov.
895
896         Implement LayoutTestController::pseudoShadowId()
897         https://bugs.webkit.org/show_bug.cgi?id=60034
898
899         * DOM/WebDOMOperations.mm:
900         (-[DOMElement _shadowPseudoId]):
901         * DOM/WebDOMOperationsPrivate.h:
902
903 2011-05-05  Dan Bernstein  <mitz@apple.com>
904
905         Reviewed by Simon Fraser.
906
907         WebKit part of <rdar://problem/9155590> Broken animation in iAd producer
908
909         * WebCoreSupport/WebSystemInterface.mm:
910         (InitWebCoreSystemInterface): Initialize wkExecutableWasLinkedOnOrBeforeSnowLeopard.
911
912 2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
913
914         Reviewed by Eric Seidel.
915
916         Rename SelectionController to FrameSelection
917         https://bugs.webkit.org/show_bug.cgi?id=60234
918
919         * WebView/WebFrame.mm:
920         (-[WebFrame _rangeByAlteringCurrentSelection:FrameSelection::direction:granularity:]):
921         * WebView/WebFrameInternal.h:
922         * WebView/WebHTMLView.mm:
923         * WebView/WebTextCompletionController.mm:
924         (-[WebTextCompletionController doCompletion]):
925         * WebView/WebView.mm:
926
927 2011-05-04  Cris Neckar  <cdn@chromium.org>
928
929         Reviewed by Adam Barth.
930
931         Expose WebView directly through ChromeClient.
932         https://bugs.webkit.org/show_bug.cgi?id=49902
933
934         * WebCoreSupport/WebChromeClient.h:
935         (WebChromeClient::webView):
936         * WebView/WebFrame.mm:
937         (kit):
938
939 2011-05-04  Tao Bai  <michaelbai@chromium.org>
940
941         Reviewed by David Kilzer.
942
943         Populate touch-icon url to FrameLoaderClient
944         https://bugs.webkit.org/show_bug.cgi?id=59143
945
946         Respect the interface change in FrameLoaderClient.
947
948         * Configurations/FeatureDefines.xcconfig:
949         * WebCoreSupport/WebFrameLoaderClient.h:
950         * WebCoreSupport/WebFrameLoaderClient.mm:
951         (WebFrameLoaderClient::dispatchDidChangeIcons):
952
953 2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>
954
955         Reviewed by Dimitri Glazkov.
956
957         Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
958         https://bugs.webkit.org/show_bug.cgi?id=58703
959
960         * DOM/WebDOMOperations.mm: Added #include for ShadowRoot.h.
961
962 2011-05-02  Adam Roben  <aroben@apple.com>
963
964         Take advantage of implicit conversion from nullptr_t to PassOwnPtr
965
966         Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
967         doesn't work, but should
968
969         Reviewed by Adam Barth.
970
971         * History/WebHistory.mm:
972         * Plugins/WebNetscapePluginEventHandler.mm:
973         * WebView/WebView.mm:
974
975 2011-05-02  Brady Eidson  <beidson@apple.com>
976
977         Reviewed by Anders Carlsson.
978
979         <rdar://problem/9340945> and https://bugs.webkit.org/show_bug.cgi?id=59973
980         In Aperture, a WebView might be dealloc'ed before it finishes loading.
981
982         * WebView/WebView.mm:
983         (needsSelfRetainWhileLoadingQuirk):
984         (-[WebView _didStartProvisionalLoadForFrame:]): If we need the quirk, retain self.
985         (-[WebView _didFinishLoadForFrame:]): If we need the quirk, release self on a delay.
986         (-[WebView _didFailLoadWithError:forFrame:]): Ditto.
987         (-[WebView _didFailProvisionalLoadWithError:forFrame:]): Ditto.
988
989 2011-05-02  Adam Barth  <abarth@webkit.org>
990
991         Reviewed by David Levin.
992
993         PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
994         https://bugs.webkit.org/show_bug.cgi?id=59924
995
996         * History/WebHistory.mm:
997         (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
998         * Plugins/WebBaseNetscapePluginView.mm:
999         (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
1000         * WebCoreSupport/WebFrameLoaderClient.mm:
1001         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
1002         * WebView/WebView.mm:
1003         (-[WebView _injectMailQuirksScript]):
1004         (-[WebView _injectOutlookQuirksScript]):
1005         (toStringVector):
1006
1007 2011-05-02  Sam Weinig  <sam@webkit.org>
1008
1009         Reviewed by Adam Barth.
1010
1011         Prune some #includes from DOMWindow.h
1012         https://bugs.webkit.org/show_bug.cgi?id=59907
1013
1014         * Plugins/WebBaseNetscapePluginView.mm:
1015         * WebView/WebFrame.mm:
1016         Add now missing SecurityOrigin.h #includes.
1017
1018 2011-05-01  Ryosuke Niwa  <rniwa@webkit.org>
1019
1020         Reviewed by Eric Seidel.
1021
1022         Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
1023         https://bugs.webkit.org/show_bug.cgi?id=59837
1024
1025         Call sendContextMenuEvent and eventMayStartDrag with PlatformMouseEvent instead of NSEvent.
1026
1027         * WebView/WebHTMLView.mm:
1028         (-[WebHTMLView menuForEvent:]):
1029         (-[WebHTMLView acceptsFirstMouse:]):
1030         (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
1031
1032 2011-05-01  Ryosuke Niwa  <rniwa@webkit.org>
1033
1034         Reviewed by Eric Seidel.
1035
1036         Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
1037         https://bugs.webkit.org/show_bug.cgi?id=59835
1038
1039         Moved currentKeyboardEvent.
1040
1041         * WebView/WebHTMLView.mm:
1042         (currentKeyboardEvent):
1043         (-[WebHTMLView becomeFirstResponder]):
1044
1045 2011-04-29  Dean Jackson  <dino@apple.com>
1046
1047         Reviewed by Simon Fraser.
1048
1049         Add ENABLE macro for WebKitAnimation
1050         https://bugs.webkit.org/show_bug.cgi?id=59729
1051
1052         Add new feature to toggle WebKit Animation API.
1053
1054         * Configurations/FeatureDefines.xcconfig:
1055
1056 2011-04-28  David Kilzer  <ddkilzer@apple.com>
1057
1058         <http://webkit.org/b/59758> Fix static analyzer warnings for missing assignment to 'self' in -init methods
1059
1060         Reviewed by Anders Carlsson.
1061
1062         * History/WebHistory.mm:
1063         (-[WebHistoryPrivate init]):
1064         * Misc/WebElementDictionary.mm:
1065         (-[WebElementDictionary initWithHitTestResult:]):
1066         * Misc/WebIconDatabase.mm:
1067         (-[WebIconDatabase init]):
1068         * Plugins/WebPluginController.mm:
1069         (-[WebPluginController initWithDocumentView:]):
1070         * Plugins/WebPluginRequest.m:
1071         (-[WebPluginRequest initWithRequest:frameName:notifyData:sendNotification:didStartFromUserGesture:]):
1072         * WebCoreSupport/WebEditorClient.mm:
1073         (-[WebEditCommand initWithEditCommand:]):
1074         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1075         (-[WebJavaScriptTextInputPanel initWithPrompt:text:]):
1076         * WebView/WebNavigationData.mm:
1077         (-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
1078
1079 2011-04-28  David Levin  <levin@chromium.org>
1080
1081         Reviewed by Adam Barth.
1082
1083         Remove IMAGE_RESIZER related code.
1084         https://bugs.webkit.org/show_bug.cgi?id=59735
1085
1086         * Configurations/FeatureDefines.xcconfig:
1087
1088 2011-04-28  Adam Barth  <abarth@webkit.org>
1089
1090         Reviewed by Eric Seidel.
1091
1092         Remove WML
1093         https://bugs.webkit.org/show_bug.cgi?id=59678
1094
1095         Remove WML-related configuration options and private APIs.
1096
1097         * Configurations/FeatureDefines.xcconfig:
1098         * WebCoreSupport/WebChromeClient.mm:
1099         (stringForMessageSource):
1100         * WebView/WebFramePrivate.h:
1101         * WebView/WebUIDelegatePrivate.h:
1102
1103 2011-04-28  Brian Weinstein  <bweinstein@apple.com>
1104
1105         Reviewed by Timothy Hatcher.
1106
1107         Web Inspector: REGRESSION(85051): Develop Menu items are wrong when inspector is frontmost window
1108         https://bugs.webkit.org/show_bug.cgi?id=59747
1109
1110         Restore functions that were removed in r85051. They were needed when the inspector is the frontmost window.
1111         Also update them to call _inspectedWebView.get() - since it's a RetainPtr now.
1112
1113         * WebCoreSupport/WebInspectorClient.mm:
1114         (-[WebInspectorWindowController showWebInspector:]):
1115         (-[WebInspectorWindowController showErrorConsole:]):
1116         (-[WebInspectorWindowController toggleDebuggingJavaScript:]):
1117         (-[WebInspectorWindowController toggleProfilingJavaScript:]):
1118         (-[WebInspectorWindowController validateUserInterfaceItem:]):
1119
1120 2011-04-28  David Kilzer  <ddkilzer@apple.com>
1121
1122         <http://webkit.org/b/59725> -[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:] leaks a CALayer
1123
1124         Reviewed by Dan Bernstein.
1125
1126         * WebView/WebFullScreenController.mm:
1127         (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
1128         Use a RetainPtr to hold the CALayer and to fix the leak.
1129
1130 2011-04-28  David Kilzer  <ddkilzer@apple.com>
1131
1132         Follow-up fix: <http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects
1133
1134         Addresses review comment from Darin Adler.
1135
1136         * WebView/WebPDFView.mm:
1137         (-[WebPDFView menuForEvent:]): Use a local variable and -release
1138         instead of -autorelease.
1139
1140 2011-04-28  Anders Carlsson  <andersca@apple.com>
1141
1142         Fix a thinko - separateRealmLabel is not an NSImageView.
1143
1144         * Panels/WebAuthenticationPanel.h:
1145
1146 2011-04-28  David Kilzer  <ddkilzer@apple.com>
1147
1148         <http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects
1149
1150         Reviewed by Dan Bernstein.
1151
1152         * WebView/WebPDFView.mm:
1153         (-[WebPDFView menuForEvent:]): Call -autorelease after copying
1154         each NSMenuItem.  Regressed in r9566 for Bug 3711.
1155
1156 2011-04-28  Enrica Casucci  <enrica@apple.com>
1157
1158         Reviewed by Beth Dakin.
1159
1160         Momentum scroll tweak for WebKit.
1161         https://bugs.webkit.org/show_bug.cgi?id=59723
1162         <rdar://problem/9259933>
1163
1164         * WebView/WebDynamicScrollBarsView.mm:
1165         (-[WebDynamicScrollBarsView scrollWheel:]): Changed constant.
1166
1167 2011-04-27  Anders Carlsson  <andersca@apple.com>
1168
1169         Follow-up Leopard build fix.
1170
1171         * Carbon/HIViewAdapter.m:
1172         (_webkit_NSView_setNeedsDisplayInRect):
1173
1174 2011-04-27  Anders Carlsson  <andersca@apple.com>
1175
1176         More clang++ 32-bit build fixes.
1177
1178         * Carbon/CarbonWindowAdapter.mm:
1179         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1180         (-[CarbonWindowAdapter setContentView:]):
1181         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1182         * Carbon/HIViewAdapter.m:
1183         (_webkit_NSView_setNeedsDisplayInRect):
1184         * Panels/WebAuthenticationPanel.h:
1185         * Plugins/WebBaseNetscapePluginView.mm:
1186         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
1187         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1188         (getCarbonEvent):
1189         * WebCoreSupport/WebChromeClient.mm:
1190         (WebChromeClient::scrollRectIntoView):
1191         * WebCoreSupport/WebViewFactory.mm:
1192         (-[WebViewFactory accessibilityConvertScreenRect:]):
1193         * WebView/WebFrameView.mm:
1194         (-[WebFrameView _scrollToBeginningOfDocument]):
1195         (-[WebFrameView _scrollToEndOfDocument]):
1196         * WebView/WebFullScreenController.mm:
1197         (-[WebFullScreenController windowDidEnterFullscreen:]):
1198         * WebView/WebHTMLView.mm:
1199         (-[WebHTMLView _hitViewForEvent:]):
1200         (coreGraphicsScreenPointForAppKitScreenPoint):
1201         * WebView/WebPDFView.mm:
1202         (-[WebPDFView setScrollPoint:]):
1203
1204 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
1205
1206         Reviewed by Pavel Feldman.
1207
1208         REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
1209         https://bugs.webkit.org/show_bug.cgi?id=44230
1210
1211         Use RetainPtr access inspected view from the inspector one to avoid inspected view being deleted before
1212         inspector is closed.
1213
1214         * WebCoreSupport/WebInspectorClient.mm: store reference to inspected view in RetainPtr. Despite the removed
1215         comment in initWithInspectedWebView this doesn't introduce cyclic reference since there are no retaining
1216         pointers to the WebInspectorWindowController from the inspected page or from the WebInspectorClient.
1217         There is only one reference to it from WebInspectorFrontendClient which is held by the inspector
1218         front-end page.
1219
1220         Drive-by fix: removed several unused methods which are currently implemented in mac/WebInspector/WebInspector.mm
1221         (-[WebInspectorWindowController initWithInspectedWebView:]):
1222         (-[WebInspectorWindowController close]):
1223         (-[WebInspectorWindowController showWindow:]):
1224         (-[WebInspectorWindowController setAttachedWindowHeight:]):
1225         (-[WebInspectorWindowController destroyInspectorView:]):
1226
1227 2011-04-26  Sam Weinig  <sam@webkit.org>
1228
1229         Reviewed by David Hyatt.
1230
1231         Remove Datagrid from the tree
1232         https://bugs.webkit.org/show_bug.cgi?id=59543
1233
1234         * Configurations/FeatureDefines.xcconfig:
1235         Remove feature.
1236
1237 2011-04-26  Dan Bernstein  <mitz@apple.com>
1238
1239         Reviewed by Mark Rowe.
1240
1241         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
1242
1243         * Configurations/Base.xcconfig:
1244         * Configurations/CompilerVersion.xcconfig: Added.
1245
1246 2011-04-25  Adam Barth  <abarth@webkit.org>
1247
1248         Reviewed by David Levin.
1249
1250         WebKit2 should play nice with strict OwnPtrs
1251         https://bugs.webkit.org/show_bug.cgi?id=59426
1252
1253         Fix include ordering.
1254
1255         * WebView/WebDeviceOrientationProviderMock.mm:
1256
1257 2011-04-25  Adam Barth  <abarth@webkit.org>
1258
1259         Reviewed by David Levin.
1260
1261         WebKit1 should build cleanly with strict OwnPtrs
1262         https://bugs.webkit.org/show_bug.cgi?id=59424
1263
1264         * History/WebHistoryItem.mm:
1265         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1266         * Plugins/WebNetscapePluginEventHandler.h:
1267         * Plugins/WebNetscapePluginEventHandler.mm:
1268         (WebNetscapePluginEventHandler::create):
1269         * Plugins/WebNetscapePluginView.mm:
1270         (-[WebNetscapePluginView createPlugin]):
1271         * WebView/WebDeviceOrientationProviderMock.mm:
1272         * WebView/WebTextIterator.mm:
1273         (-[WebTextIterator initWithRange:]):
1274
1275 2011-04-25  Jon Lee  <jonlee@apple.com>
1276
1277         Reviewed by Maciej Stachowiak.
1278
1279         Overlay scroller hard to see on pages with dark background (59183)
1280         https://bugs.webkit.org/show_bug.cgi?id=59183
1281         <rdar://problem/8975367>
1282         
1283         * WebCoreSupport/WebSystemInterface.mm:
1284         (InitWebCoreSystemInterface): adding method to allow changing style
1285
1286 2011-04-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1287
1288         Unreviewed, rolling out r84740.
1289         http://trac.webkit.org/changeset/84740
1290         https://bugs.webkit.org/show_bug.cgi?id=59290
1291
1292         change breaks apple internal builds and is incorrect
1293         (Requested by smfr on #webkit).
1294
1295         * WebCoreSupport/WebSystemInterface.mm:
1296         (InitWebCoreSystemInterface):
1297
1298 2011-04-22  Jon Lee  <jonlee@apple.com>
1299
1300         Reviewed by Beth Dakin.
1301
1302         Overlay scroller hard to see on pages with dark background (59183)
1303         https://bugs.webkit.org/show_bug.cgi?id=59183
1304         <rdar://problem/8975367>
1305         
1306         * WebCoreSupport/WebSystemInterface.mm:
1307         (InitWebCoreSystemInterface): adding method to allow changing style
1308
1309 2011-04-19  Jer Noble  <jer.noble@apple.com>
1310
1311         Reviewed by Daniel Bates.
1312
1313         Full Screen from within an <iframe> does not cause <iframe> to resize.
1314         https://bugs.webkit.org/show_bug.cgi?id=58638
1315
1316         Tests: fullscreen/full-screen-frameset-allowed.html
1317                fullscreen/full-screen-frameset-not-allowed.html
1318
1319         Return the _element's document instead of the WKView's document, which 
1320         will be different in the case of elements within <iframe>s.
1321
1322         * WebView/WebFullScreenController.mm:
1323         (-[WebFullScreenController _document]):
1324
1325 2011-04-22  Jer Noble  <jer.noble@apple.com>
1326
1327         Reviewed by Maciej Stachowiak.
1328
1329         Disable MediaPlayerPrivateAVFoundation when using old full screen mode.
1330         https://bugs.webkit.org/show_bug.cgi?id=59147
1331
1332         Add a new user default preference, and plumb that preference down to WebCore
1333         Settings. Allow the fullScreenEnabled preference to override the new 
1334         isAVFoundationEnabled preference, so that clients of the legacy full screen
1335         mode will continue to use that mode normally.
1336
1337         * WebView/WebPreferenceKeysPrivate.h: Add new preference key.
1338         * WebView/WebPreferences.mm:
1339         (+[WebPreferences initialize]): Set the default value of new
1340             preference.
1341         (-[WebPreferences setAVFoundationEnabled:]): Added.
1342         (-[WebPreferences isAVFoundationEnabled]): Added.
1343         * WebView/WebPreferencesPrivate.h:
1344         * WebView/WebView.mm:
1345         (-[WebView _preferencesChanged:]): Update the WebCore settings with the
1346             new values from WebPreferences.
1347
1348 2011-04-22  Sam Weinig  <sam@webkit.org>
1349
1350         Reviewed by Gavin Barraclough.
1351
1352         Remove remaining uses of deprecated version of toJS
1353         https://bugs.webkit.org/show_bug.cgi?id=59170
1354
1355         * DOM/WebDOMOperations.mm:
1356         (-[DOMElement _shadowRoot:]):
1357         (-[DOMElement _ensureShadowRoot:]):
1358         Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
1359
1360 2011-04-21  Maciej Stachowiak  <mjs@apple.com>
1361
1362         Reviewed by Adam Roben.
1363
1364         Add a feature define to allow <details> and <summary> to be disabled
1365         https://bugs.webkit.org/show_bug.cgi?id=59118
1366         <rdar://problem/9257045>
1367
1368         * Configurations/FeatureDefines.xcconfig:
1369
1370 2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
1371
1372         Reviewed by Sam Weinig.
1373
1374         Add Frame* to the argument lists of canCopyCut and canPaste
1375         https://bugs.webkit.org/show_bug.cgi?id=59153
1376
1377         * WebCoreSupport/WebEditorClient.h:
1378         * WebCoreSupport/WebEditorClient.mm:
1379         (WebEditorClient::canCopyCut):
1380         (WebEditorClient::canPaste):
1381
1382 2011-04-21  Sheriff Bot  <webkit.review.bot@gmail.com>
1383
1384         Unreviewed, rolling out r82052.
1385         http://trac.webkit.org/changeset/82052
1386         https://bugs.webkit.org/show_bug.cgi?id=59135
1387
1388         New full screen api should be opt-in, not opt-out. (Requested
1389         by jernoble on #webkit).
1390
1391         * WebView/WebPreferences.mm:
1392         (+[WebPreferences initialize]):
1393
1394 2011-04-21  Beth Dakin  <bdakin@apple.com>
1395
1396         Reviewed by Dan Bernstein.
1397
1398         https://bugs.webkit.org/show_bug.cgi?id=59048
1399         Need to track whether overlay scrollbar is currently visible and in lower-
1400         righthand corner
1401         -and corresponding-
1402         <rdar://problem/9211232>
1403
1404         A new WebSystemInterface is needed for this.
1405         * WebCoreSupport/WebSystemInterface.mm:
1406         (InitWebCoreSystemInterface):
1407
1408 2011-04-21  Dirk Schulze  <krit@webkit.org>
1409
1410         Reviewed by Nikolas Zimmermann.
1411
1412         SVG feDropShadow implementation of SVG Filters 1.2
1413         https://bugs.webkit.org/show_bug.cgi?id=52513
1414
1415         * MigrateHeaders.make:
1416
1417 2011-04-20  Dominic Cooney  <dominicc@chromium.org>
1418
1419         Reviewed by Dimitri Glazkov.
1420
1421         layoutTestController can create and destroy shadow DOM
1422         https://bugs.webkit.org/show_bug.cgi?id=59058
1423
1424         Support for new methods in Mac DRT.
1425
1426         * DOM/WebDOMOperations.mm:
1427         (-[DOMElement _ensureShadowRoot:]):
1428         (-[DOMElement _removeShadowRoot]):
1429         * DOM/WebDOMOperationsPrivate.h:
1430
1431 2011-04-20  Eric Carlson  <eric.carlson@apple.com>
1432
1433         Reviewed by Dan Bernstein.
1434
1435         Adopt QTKit API for listing and deleting file in its media cache.
1436         <rdar://problem/9130029> 
1437
1438         * WebCoreSupport/WebSystemInterface.mm:
1439         (InitWebCoreSystemInterface): Initialize new functions.
1440
1441 2011-04-19  Matthew Delaney  <mdelaney@apple.com>
1442
1443         Reviewed by Simon Fraser.
1444
1445         WebPreferences in WebKit1 should have CanvasUsesAcceleratedDrawing set to NO by default
1446         https://bugs.webkit.org/show_bug.cgi?id=58936
1447
1448         * WebView/WebPreferences.mm:
1449         (+[WebPreferences initialize]):
1450
1451 2011-04-19  Vsevolod Vlasov  <vsevik@chromium.org>
1452
1453         Reviewed by Pavel Feldman.
1454
1455         Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
1456         https://bugs.webkit.org/show_bug.cgi?id=58883
1457
1458         * WebCoreSupport/WebFrameLoaderClient.h:
1459         * WebCoreSupport/WebFrameLoaderClient.mm:
1460         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1461
1462 2011-04-18  Jia Pu  <jpu@apple.com>
1463
1464         Reviewed by Mark Rowe.
1465
1466         WebKit needs to stop importing <AppKit/NSTextChecker.h>
1467         https://bugs.webkit.org/show_bug.cgi?id=58798
1468         <rdar://problem/9294938>
1469
1470         Use public header <AppKit/NSSpellChecker.h> instead.
1471
1472         * WebCoreSupport/CorrectionPanel.h:
1473         * WebCoreSupport/CorrectionPanel.mm:
1474         (correctionIndicatorType):
1475         (CorrectionPanel::show):
1476         (CorrectionPanel::dismissInternal):
1477         (CorrectionPanel::handleAcceptedReplacement):
1478         * WebCoreSupport/WebEditorClient.mm:
1479         * WebView/WebView.mm:
1480
1481 2011-04-17  Cameron Zwarich  <zwarich@apple.com>
1482
1483         Reviewed by Timothy Hatcher.
1484
1485         Stop using -[NSString initWithContentsOfFile:]
1486         https://bugs.webkit.org/show_bug.cgi?id=58763
1487
1488         -[NSString initWithContentsOfFile:] was deprecated in 10.4, so we should stop using it.
1489
1490         * WebView/WebView.mm:
1491         (leakMailQuirksUserScriptContents):
1492         (leakOutlookQuirksUserScriptContents):
1493
1494 2011-04-17  David Kilzer  <ddkilzer@apple.com>
1495
1496         <http://webkit.org/b/58463> Switch HTTP pipelining from user default to private setting
1497         <rdar://problem/9268729>
1498
1499         Reviewed by Dan Bernstein.
1500
1501         This replaces support for the WebKitEnableHTTPPipelining user
1502         default with methods on the WebCore::ResourceRequest class in
1503         WebCore, the WebView class in WebKit1, and the WebContext class
1504         in WebKit2.  It also removes support for the
1505         WebKitForceHTTPPipeliningPriorityHigh user default which was not
1506         needed.
1507
1508         * WebView/WebView.mm:
1509         (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added.
1510         (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added.
1511         * WebView/WebViewPrivate.h:
1512         (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added declaration.
1513         (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added declaration.
1514
1515 2011-04-17  Joseph Pecoraro  <joepeck@webkit.org>
1516
1517         Reviewed by Dan Bernstein.
1518
1519         Assign to self in WebInspectorWindowController constructors
1520         https://bugs.webkit.org/show_bug.cgi?id=58749
1521
1522         * WebCoreSupport/WebInspectorClient.mm:
1523         (-[WebInspectorWindowController init]):
1524         (-[WebInspectorWindowController initWithInspectedWebView:]):
1525
1526 2011-04-17  Joseph Pecoraro  <joepeck@webkit.org>
1527
1528         Reviewed by Timothy Hatcher.
1529
1530         Move WebNodeHighlighter into its own file
1531         https://bugs.webkit.org/show_bug.cgi?id=58746
1532
1533         Extract this class into its own file alongside the
1534         other WebNodeHighlight files. In doing so do some
1535         cleanup on WebInspectorClient removing some methods
1536         that were never called.
1537
1538         * WebCoreSupport/WebInspectorClient.mm:
1539         (WebInspectorClient::WebInspectorClient): style fix.
1540         * WebInspector/WebNodeHighlighter.h: Added.
1541         * WebInspector/WebNodeHighlighter.mm: Added.
1542         (-[WebNodeHighlighter initWithInspectedWebView:]): call super init.
1543         (-[WebNodeHighlighter dealloc]):
1544         (-[WebNodeHighlighter highlightNode:]):
1545         (-[WebNodeHighlighter hideHighlight]):
1546         (-[WebNodeHighlighter didAttachWebNodeHighlight:]):
1547         (-[WebNodeHighlighter willDetachWebNodeHighlight:]):
1548
1549 2011-04-15  Jia Pu  <jpu@apple.com>
1550
1551         Reviewed by Dan Bernstein.
1552
1553         [Mac] WebKit needs to convert the bounding box of autocorrected word to view coordinate.
1554         https://bugs.webkit.org/show_bug.cgi?id=58717
1555
1556         Convert the bounding box from window coordinate to view coordinate, which is expected by NSCorrectionPanel.
1557
1558         * WebCoreSupport/CorrectionPanel.mm:
1559         (CorrectionPanel::show):
1560
1561 2011-04-15  Shishir Agrawal  <shishir@chromium.org>
1562
1563         Reviewed by James Robinson.
1564
1565         Add a flag to guard Page Visibility API changes.
1566         https://bugs.webkit.org/show_bug.cgi?id=58464
1567
1568         * Configurations/FeatureDefines.xcconfig:
1569
1570 2011-04-15  Oliver Hunt  <oliver@apple.com>
1571
1572         GC allocate Structure
1573         https://bugs.webkit.org/show_bug.cgi?id=58483
1574
1575         Rolling r83894 r83827 r83810 r83809 r83808 back in with
1576         a workaround for the gcc bug seen by the gtk bots
1577
1578         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1579         * Plugins/Hosted/ProxyInstance.mm:
1580         (WebKit::ProxyRuntimeMethod::createStructure):
1581         * Plugins/Hosted/ProxyRuntimeObject.h:
1582         (WebKit::ProxyRuntimeObject::createStructure):
1583
1584 2011-04-14  Alexey Proskuryakov  <ap@apple.com>
1585
1586         Reviewed by Dan Bernstein.
1587
1588         WebKit2: Password field input does not switch to ASCII-compatible source
1589         https://bugs.webkit.org/show_bug.cgi?id=58583
1590         <rdar://problem/9059651>
1591
1592         Now that WebCore doesn't set secure input mode, WebKit has to. Happily, it already has the
1593         necessary logic, needed to return a nil text input context when in password fields.
1594
1595         * WebView/WebHTMLView.mm:
1596         (-[WebHTMLView close]): If the view is still enforcing secure event mode, stop.
1597         (-[WebHTMLView windowDidBecomeKey:]): Call _updateSecureInputState.
1598         (-[WebHTMLView windowDidResignKey:]): Ditto.
1599         (-[WebHTMLView becomeFirstResponder]): Call _updateSecureInputState. It's a bit tricky
1600         because the first responder is still different an this point, so set a boolean variable to
1601         let _updateSecureInputState know what's going on.
1602         (-[WebHTMLView resignFirstResponder]): Disable secure event mode if it's on.
1603         (-[WebHTMLView _updateSecureInputState]): Update HIToolbox secure event input state and
1604         allowed input sources accorsing to current selection.
1605         (-[WebHTMLView _updateSelectionForInputManager]): Call _updateSecureInputState.
1606
1607 2011-04-15  Sam Weinig  <sam@webkit.org>
1608
1609         Reviewed by Maciej Stachowiak.
1610
1611         Make mac WebKit1 use the default localization strategy
1612         https://bugs.webkit.org/show_bug.cgi?id=58628
1613
1614         * WebCoreSupport/WebPlatformStrategies.h:
1615         * WebCoreSupport/WebPlatformStrategies.mm:
1616         Remove the localization strategy code. The equivalent is now
1617         in WebCore/platform/DefaultLocalizationStrategy.cpp.
1618
1619 2011-04-15  Anna Cavender  <annacc@chromium.org>
1620
1621         Reviewed by Eric Carlson.
1622
1623         Renaming TRACK feature define to VIDEO_TRACK
1624         https://bugs.webkit.org/show_bug.cgi?id=53556
1625
1626         * Configurations/FeatureDefines.xcconfig:
1627
1628 2011-04-14  Pratik Solanki  <psolanki@apple.com>
1629
1630         Reviewed by David Kilzer.
1631
1632         Set minimum priority for fast lane connections
1633         https://bugs.webkit.org/show_bug.cgi?id=58353
1634
1635         * WebCoreSupport/WebSystemInterface.mm:
1636         (InitWebCoreSystemInterface): Support for new WKSI method WKSetHTTPPipeliningMinimumFastLanePriority.
1637
1638 2011-04-13  Sam Weinig  <sam@webkit.org>
1639
1640         Reviewed by Gavin Barraclough.
1641
1642         WebKit2 doesn't keep overlay scrollers shown while scroll gesture held
1643         <rdar://problem/9260518>
1644
1645         * WebCoreSupport/WebSystemInterface.mm:
1646         (InitWebCoreSystemInterface):
1647         Initialize new WKSI functions.
1648
1649 2011-04-13  David Kilzer  <ddkilzer@apple.com>
1650
1651         <http://webkit.org/b/58172> Fix -Wcast-align warning in WebBasePluginPackage.mm
1652
1653         Reviewed by Anders Carlsson.
1654
1655         Fixes the following warning with -Wcast-align enabled:
1656
1657             Source/WebKit/mac/Plugins/WebBasePluginPackage.mm:402:21:{402:21-402:93}{402:39-402:93}: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'struct fat_arch *' increases required alignment from 1 to 4 [-Werror,-Wcast-align,3]
1658                          archs = (struct fat_arch*)((uint8_t*)rawData.data() + sizeof(struct fat_header));
1659                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1660
1661         * Plugins/WebBasePluginPackage.mm:
1662         (-[WebBasePluginPackage isNativeLibraryData:]): Added
1663         COMPILE_ASSERT() to make sure our pointer math is valid.
1664         Removed cast to (uint8_t*) and divide sizeof(struct fat_header)
1665         by sizeof(uint32_t) to fix the pointer math.  Replaced C-style
1666         casts with reinterpret_cast.
1667
1668 2011-04-12  Enrica Casucci  <enrica@apple.com>
1669
1670         Reviewed by Alexey Proskuryakov.
1671
1672         Infinite recursion in WebHTMLView executeSavedKeypressCommands.
1673         https://bugs.webkit.org/show_bug.cgi?id=58382
1674         <rdar://problem/9239370>
1675
1676         Execution of some editing commands could trigger a call to selectedRange that
1677         internally calls executeSavedKeypressCommands creating an infinite recursion.
1678
1679         * WebView/WebHTMLView.mm:
1680         (-[WebHTMLView _executeSavedKeypressCommands]): Added a flag to avoid recursion.
1681         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added flag initialization.
1682
1683 2011-04-12  Alice Liu  <alice.liu@apple.com>
1684
1685         Reviewed by Sam Weinig.
1686
1687         https://bugs.webkit.org/show_bug.cgi?id=58292
1688         Provide new setting to allow site icon loading despite disabling automatic image loading in general.
1689
1690         * WebView/WebPreferenceKeysPrivate.h: Add preference key.
1691         * WebView/WebPreferences.mm:
1692         (+[WebPreferences initialize]): Initialize to false.
1693         (-[WebPreferences setLoadsSiteIconsIgnoringImageLoadingPreference:]): Added.
1694         (-[WebPreferences loadsSiteIconsIgnoringImageLoadingPreference]): Added.
1695         * WebView/WebPreferencesPrivate.h: Add setter/getter definitions.
1696         * WebView/WebView.mm:
1697         (-[WebView _preferencesChanged:]): Add to settings that get propagated upon changes. 
1698
1699 2011-04-11  Alexey Proskuryakov  <ap@apple.com>
1700
1701         Reviewed by Maciej Stachowiak.
1702
1703         WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
1704         https://bugs.webkit.org/show_bug.cgi?id=58175
1705         <rdar://problem/9060555>
1706
1707         * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
1708         should be changed to match WebKit2.
1709
1710 2011-04-06  Timothy Hatcher  <timothy@apple.com>
1711
1712         Fix a bug where the context menu does not show in PDF documents if there is no
1713         UI delegate or the UI delegate does not respond to the context menu selector.
1714
1715         https://webkit.org/b/57958
1716
1717         Reviewed by Darin Adler.
1718
1719         * WebView/WebView.mm:
1720         (-[WebView _menuForElement:defaultItems:]): CallUIDelegate returns nil
1721         if UIDelegate is nil or doesn't respond to the selector. So check that
1722         here to distinguish between using defaultMenuItems or the delegate
1723         really returning nil to say "no context menu".
1724
1725 2011-04-11  Jer Noble  <jer.noble@apple.com>
1726
1727         Unreviewed; roll out unintentional change to WebFullScreenController.mm.
1728
1729         * WebView/WebFullScreenController.mm:
1730         (-[WebFullScreenController enterFullscreen:]):
1731
1732 2011-04-08  Geoffrey Garen  <ggaren@apple.com>
1733
1734         Reviewed by Oliver Hunt.
1735
1736         A few heap-related renames and file moves.
1737         
1738         WeakGCPtr<T> => Weak<T>
1739         Global<T> => Strong<T>
1740         collector/ => heap/
1741         collector/* => heap/*
1742         runtime/WeakGCPtr.h => heap/Weak.h
1743         
1744         (Eventually, even more files should move into the heap directory. Like
1745         Heap.h and Heap.cpp, for example.)
1746
1747         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1748         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1749         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
1750         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
1751         (WebKit::NetscapePluginInstanceProxy::evaluate):
1752         * WebView/WebScriptDebugger.h:
1753
1754 2011-04-08  Alexey Proskuryakov  <ap@apple.com>
1755
1756         Reviewed by Darin Adler.
1757
1758         WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
1759         https://bugs.webkit.org/show_bug.cgi?id=58175
1760         <rdar://problem/9060555>
1761
1762         * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
1763         should be changed to match WebKit2.
1764
1765 2011-04-08  Alpha Lam  <hclam@chromium.org>
1766
1767         Unreviewed, rolling out r83335.
1768         http://trac.webkit.org/changeset/83335
1769         https://bugs.webkit.org/show_bug.cgi?id=53556
1770
1771         GTK and QT bots are broken
1772
1773         * Configurations/FeatureDefines.xcconfig:
1774
1775 2011-04-07  Anna Cavender  <annacc@chromium.org>
1776
1777         Reviewed by Eric Carlson.
1778
1779         Setup ENABLE(TRACK) feature define
1780         https://bugs.webkit.org/show_bug.cgi?id=53556
1781
1782         * Configurations/FeatureDefines.xcconfig:
1783
1784 2011-04-08  Maciej Stachowiak  <mjs@apple.com>
1785
1786         Reviewed by Darin Adler.
1787
1788         -[WebView setPreferences:] can take a lot of time if loading lots of webviews at once
1789         https://bugs.webkit.org/show_bug.cgi?id=58128
1790         <rdar://problem/9244553>
1791         
1792         The root of the problem here was an O(N^2) issue - each WebView,
1793         upon having its preferences initialized, would broadcast a
1794         notification that was listened to by all other WebViews sharing
1795         its preferences.
1796         
1797         To maintain the API contract, I split the notification into two,
1798         one that is for public API consumption, and the other which is for
1799         internal use only. Changes that don't need to be picked up by
1800         other WebViews broadcast the public notification only. And we
1801         avoid WebView broadcasting a notification just to get itself to
1802         update.
1803
1804         * Misc/WebIconDatabase.mm:
1805         (-[WebIconDatabase _startUpIconDatabase]):
1806         (-[WebIconDatabase _shutDownIconDatabase]):
1807         * Plugins/WebBaseNetscapePluginView.mm:
1808         (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
1809         (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]):
1810         (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
1811         (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]):
1812         * WebView/WebPreferences.mm:
1813         (-[WebPreferences initWithIdentifier:]):
1814         (-[WebPreferences _setStringValue:forKey:]):
1815         (-[WebPreferences _setIntegerValue:forKey:]):
1816         (-[WebPreferences _setFloatValue:forKey:]):
1817         (-[WebPreferences _setBoolValue:forKey:]):
1818         (-[WebPreferences _setLongLongValue:forKey:]):
1819         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
1820         (-[WebPreferences _postPreferencesChangedNotification]):
1821         (-[WebPreferences _postPreferencesChangedAPINotification]):
1822         * WebView/WebPreferencesPrivate.h:
1823         * WebView/WebView.mm:
1824         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
1825         (-[WebView _preferencesChangedNotification:]):
1826         (-[WebView _preferencesChanged:]):
1827         (-[WebView setUsesPageCache:]):
1828         (+[WebView initialize]):
1829         (-[WebView setPreferences:]):
1830         (-[WebView _keyboardUIMode]):
1831         * WebView/WebViewInternal.h:
1832
1833 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
1834
1835         Revert ENABLE_TRACK patch due to compile failures.
1836
1837         * Configurations/FeatureDefines.xcconfig:
1838
1839 2011-04-07  Alexey Proskuryakov  <ap@apple.com>
1840
1841         Reviewed by Anders Carlsson.
1842
1843         REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
1844         https://bugs.webkit.org/show_bug.cgi?id=58066
1845         <rdar://problem/8965302>
1846
1847         * WebView/WebHTMLRepresentation.mm:
1848         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
1849         * WebView/WebHTMLView.mm:
1850         (-[WebHTMLView attributedSubstringFromRange:]):
1851         (-[WebHTMLView attributedString]):
1852         (-[WebHTMLView selectedAttributedString]):
1853         Updated for editingAttributedStringFromRange: now taking a WebCore::Range instead of DOMRange.
1854
1855 2011-04-07  Andy Estes  <aestes@apple.com>
1856
1857         Reviewed by Darin Adler.
1858
1859         REGRESSION (r64712): Microsoft Outlook 2011: original message contents
1860         not included when replying to an email.
1861         https://bugs.webkit.org/show_bug.cgi?id=57794
1862         
1863         Outlook populates a reply message by creating an empty WebView and
1864         using DOM API to populate the WebView's empty document with content
1865         from the original message. It expects the initial empty document to
1866         simply be "<html></html>", and it proceeds to dynamically create and
1867         append a BODY node and add the original message content as a child of
1868         that node. Outlook then takes the innerHTML of the frame's first body
1869         element and copies it into a *new* document that is displayed and
1870         edited in the reply message window.
1871         
1872         Due to implementing the HTML5 tree building algorithm in r64712,
1873         initial empty documents went from being "<html></html>" to being
1874         "<html><head></head><body></body></html>". Outlook still dynamically
1875         creates a BODY node to parent the original message content, but this
1876         BODY node duplicates the one created by the tree builder. When Outlook
1877         then takes the innerHTML of the first body element to populate the
1878         reply message window it gets the empty body element created by the
1879         parser, not the one it created with the original message content.
1880         
1881         Fix this by injecting a user script into the initial empty document
1882         that removes the HEAD and BODY nodes created by the parser. This
1883         ensures that the BODY created by Outlook is the only BODY in the
1884         document.
1885
1886         * Misc/OutlookQuirksUserScript.js: Added.
1887         * WebView/WebView.mm:
1888         (leakMailQuirksUserScriptContents):
1889         (-[WebView _injectMailQuirksScript]):
1890         (needsOutlookQuirksScript):
1891         (leakOutlookQuirksUserScriptContents):
1892         (-[WebView _injectOutlookQuirksScript]):
1893         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
1894
1895 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
1896
1897         Reviewed by David Levin.
1898
1899         Add QUOTA build flag for unified quota API
1900         https://bugs.webkit.org/show_bug.cgi?id=57918
1901
1902         * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
1903
1904 2011-04-06  Robert Sesek  <rsesek@chromium.org>
1905
1906         Reviewed by Alexey Proskuryakov.
1907
1908         Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
1909         https://bugs.webkit.org/show_bug.cgi?id=54969
1910
1911         * WebView/WebFrame.mm:
1912         (-[WebFrame _convertToNSRange:]): Moved duplicated code to WebCore
1913         (-[WebFrame _characterRangeAtPoint:]): Moved duplicated code to WebCore
1914
1915 2011-04-05  Alexey Proskuryakov  <ap@apple.com>
1916
1917         Reviewed by Darin Adler.
1918
1919         Move attributedStringFromRange down to WebCore
1920         https://bugs.webkit.org/show_bug.cgi?id=57905
1921
1922         * Misc/WebNSAttributedStringExtras.h: Removed.
1923         * Misc/WebNSAttributedStringExtras.mm: Removed.
1924         * WebView/WebHTMLRepresentation.mm:
1925         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
1926         * WebView/WebHTMLView.mm:
1927         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1928         (-[WebHTMLView attributedSubstringFromRange:]):
1929         (-[WebHTMLView attributedString]):
1930         (-[WebHTMLView selectedAttributedString]):
1931         * WebView/WebPDFView.mm:
1932         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1933
1934 2011-04-04  MORITA Hajime  <morrita@google.com>
1935
1936         Reviewed by Ryosuke Niwa.
1937
1938         [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
1939         https://bugs.webkit.org/show_bug.cgi?id=56085
1940
1941         Removed NSTextCheckingResult to SpellCheckingResult convertion, and extracted
1942         NSTextCheckingResult to TextCheckingResult convertio from checkTextOfParagraph method.
1943         for requestCheckingOfString method.
1944         
1945         * WebCoreSupport/WebEditorClient.h:
1946         * WebCoreSupport/WebEditorClient.mm:
1947         (toCoreTextCheckingResults):
1948         (WebEditorClient::checkTextOfParagraph):
1949         (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:types:WebCore::results:]):
1950         (-[WebEditorSpellCheckResponder perform]):
1951         (WebEditorClient::requestCheckingOfString):
1952         * WebView/WebFrame.mm:
1953         (-[WebFrame markersForSelectionStartAsText]):
1954         * WebView/WebFramePrivate.h:
1955
1956 2011-04-05  Anders Carlsson  <andersca@apple.com>
1957
1958         Didn't mean to land this.
1959
1960         * Plugins/WebNetscapePluginView.mm:
1961         (-[WebNetscapePluginView getVariable:value:]):
1962
1963 2011-04-04  David Kilzer  <ddkilzer@apple.com>
1964
1965         <http://webkit.org/b/57384> CFNetwork and WebCore load priorities should match
1966
1967         Reviewed by Alexey Proskuryakov.
1968
1969         * WebCoreSupport/WebSystemInterface.mm:
1970         (InitWebCoreSystemInterface): Added initialization for
1971         wkSetHTTPPipeliningMaximumPriority().
1972
1973 2011-04-04  Alexey Proskuryakov  <ap@apple.com>
1974
1975         Reviewed by Dan Bernstein.
1976
1977         REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
1978         https://bugs.webkit.org/show_bug.cgi?id=51230
1979         <rdar://problem/8780989>
1980
1981         * WebView/WebHTMLView.mm: (-[WebHTMLView flagsChanged:]): Moved Caps Lock handling from
1982         WebKits to WebCore, because WebKit shouldn't be smart.
1983
1984 2011-04-01  Alexey Proskuryakov  <ap@apple.com>
1985
1986         Reviewed by Darin Adler.
1987
1988         REGRESSION: Assertion failure when executing a complex custom key binding
1989         https://bugs.webkit.org/show_bug.cgi?id=57681
1990
1991         * WebView/WebHTMLView.mm: (-[WebHTMLView hasMarkedText]): There is no need to execute saved
1992         commands when they can't possibly change the result.
1993
1994 2011-04-01  Anders Carlsson  <andersca@apple.com>
1995
1996         Reviewed by Sam Weinig.
1997
1998         Shockwave plug-in doesn't accept mouse events
1999         https://bugs.webkit.org/show_bug.cgi?id=57653
2000         <rdar://problem/8483273>
2001
2002         Fix an unrelated bug found by the added test.
2003
2004         * Plugins/WebBaseNetscapePluginView.mm:
2005         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
2006         Make sure to always set destX and destY.
2007
2008 2011-04-01  Alexey Proskuryakov  <ap@apple.com>
2009
2010         Reviewed by Darin Adler.
2011
2012         Make WebKit2 text input handling more like WebKit1
2013         https://bugs.webkit.org/show_bug.cgi?id=57649
2014
2015         * WebView/WebFrameInternal.h: Expose _convertToDOMRange for use in WebHTMLView.
2016         * WebView/WebHTMLView.mm:
2017         (-[WebHTMLView _executeSavedKeypressCommands]): Renamed, since these are not editor commands.
2018         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for the renamed _executeSavedKeypressCommands.
2019         (-[WebHTMLView characterIndexForPoint:]): Ditto.
2020         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2021         (-[WebHTMLView selectedRange]): Ditto.
2022         (-[WebHTMLView markedRange]): Ditto.
2023         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2024         (-[WebHTMLView hasMarkedText]): Ditto.
2025         (-[WebHTMLView unmarkText]): Ditto.
2026         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. Changed the comment about the argument
2027         type into an assertion. Removed resetting interpretKeyEventsParameters to 0, as we shouldn't
2028         be able to call text input protocol methods from here (and we didn't even reset it back on
2029         return). Changed to retrieve all data before starting to apply actions to better match WK2 code.
2030         (-[WebHTMLView insertText:]): Ditto.
2031
2032 2011-04-01  Timothy Hatcher  <timothy@apple.com>
2033
2034         Make momentum scroll event latching work in WebKit2 on Mac.
2035
2036         <rdar://problem/8751861>
2037
2038         Reviewed by Darin Adler.
2039
2040         * WebCoreSupport/WebSystemInterface.mm:
2041         (InitWebCoreSystemInterface): Remove IsLatchingWheelEvent, add GetNSEventMomentumPhase.
2042         * WebView/WebDynamicScrollBarsView.mm:
2043         (-[WebDynamicScrollBarsView scrollWheel:]): Use WKGetNSEventMomentumPhase to set isLatchingEvent.
2044
2045 2011-03-31  Darin Adler  <darin@apple.com>
2046
2047         Reviewed by Anders Carlsson.
2048
2049         Assertion failure in -[WebHTMLView _handleStyleKeyEquivalent:]
2050         https://bugs.webkit.org/show_bug.cgi?id=26667
2051
2052         * WebView/WebHTMLView.mm:
2053         (-[WebHTMLView _handleStyleKeyEquivalent:]): Handle the case where WebView is
2054         nil rather than asserting that it is non-nil. One case where WebView will be nil
2055         is when the frame is closed, but in any case where it is nil, the correct thing
2056         to do is to not try to handle the style key.
2057
2058 2011-03-31  Alexey Proskuryakov  <ap@apple.com>
2059
2060         Patch by John Harvey, reviewed and tweaked by me.
2061
2062         <rdar://problem/8644403> Should notify TSM that plug-ins would show a bottom input window for marked text.
2063
2064         * Plugins/Hosted/WebTextInputWindowController.m:
2065         (-[WebTextInputPanel _interpretKeyEvent:string:]):
2066
2067 2011-03-31  Evan Martin  <evan@chromium.org>
2068
2069         Reviewed by Eric Seidel.
2070
2071         <title> should support dir attribute
2072         https://bugs.webkit.org/show_bug.cgi?id=50961
2073
2074         Update to new FrameLoaderClient interface.
2075
2076         * WebCoreSupport/WebFrameLoaderClient.h:
2077         * WebCoreSupport/WebFrameLoaderClient.mm:
2078         (WebFrameLoaderClient::dispatchDidReceiveTitle):
2079         (WebFrameLoaderClient::setTitle):
2080
2081 2011-03-30  Dominic Cooney  <dominicc@google.com>
2082
2083         Reviewed by Dimitri Glazkov.
2084
2085         Adds layoutTestController.shadowRoot accessor to Mac DRT.
2086         https://bugs.webkit.org/show_bug.cgi?id=57415
2087
2088         * DOM/WebDOMOperations.mm:
2089         (-[DOMElement _shadowRoot:]):
2090         * DOM/WebDOMOperationsPrivate.h:
2091
2092 2011-03-30  Alexey Proskuryakov  <ap@apple.com>
2093
2094         Reviewed by Darin Adler.
2095
2096         WebHTMLView shouldn't resend noop: commands
2097         https://bugs.webkit.org/show_bug.cgi?id=57504
2098         <rdar://problem/9209390>
2099
2100         * WebView/WebHTMLView.mm: (-[WebHTMLView _executeSavedEditingCommands]): Filter out NOOPs,
2101         which we get e.g. when handling Cmd-key combos.
2102
2103 2011-03-30  Alexey Proskuryakov  <ap@apple.com>
2104
2105         Reviewed by Darin Adler.
2106
2107         REGRESSION (r82320): Spacebar no longer pages down
2108         https://bugs.webkit.org/show_bug.cgi?id=57423
2109         <rdar://problem/9207702>
2110
2111         Also includes some unrelated cleanup that I had in my tree.
2112
2113         * WebView/WebHTMLView.mm:
2114         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added an assertion that the event is
2115         being dispatched to the right frame.
2116         (-[WebHTMLView setMarkedText:selectedRange:]): Use 0 for a pointer, not NULL.
2117         (-[WebHTMLView doCommandBySelector:]): Update eventInterpretationHadSideEffects with "|=".
2118         Even if this specific command hasn't been handled, that doesn't nullify side effects from
2119         previous commands.
2120         (-[WebHTMLView insertText:]): Besides looking at the return value of insertText() to fix the
2121         bug, removed setting _private->interpretKeyEventsParameters to 0. I don't see any way for
2122         another WebHTMLView NSTextInput method to be called from within insertText:, so no one is
2123         going to look at it.
2124
2125 2011-03-30  Sam Weinig  <sam@webkit.org>
2126
2127         Reviewed by Brady Eidson.
2128
2129         WebKit2: Attempting to view css file from url causes it to download
2130         <rdar://problem/9102611>
2131         https://bugs.webkit.org/show_bug.cgi?id=57501
2132
2133         * WebView/WebHTMLRepresentation.h:
2134         * WebView/WebHTMLRepresentation.mm:
2135         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2136         * WebView/WebHTMLView.mm:
2137         (+[WebHTMLView unsupportedTextMIMETypes]):
2138         Re-factor unsupportedTextMIMETypes to pull from WebCore's
2139         MIMETypeRegistry, so that the list can be shared with WebKit2.
2140
2141 2011-03-29  Beth Dakin  <bdakin@apple.com>
2142
2143         Reviewed by Maciej Stachowiak.
2144
2145         Fix for https://bugs.webkit.org/show_bug.cgi?id=57408 
2146         webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard 
2147         -and corresponding-
2148         <rdar://problem/8665411>
2149
2150         * Misc/WebNSControlExtras.m:
2151         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2152         * WebCoreSupport/WebChromeClient.mm:
2153         (WebChromeClient::scaleFactor):
2154         * WebView/WebHTMLView.mm:
2155         (-[WebHTMLView viewDidMoveToWindow]):
2156         (-[WebHTMLView attachRootLayer:]):
2157
2158 2011-03-29  Kent Tamura  <tkent@chromium.org>
2159
2160         Reviewed by Dimitri Glazkov.
2161
2162         Make validation message bubble testable
2163         https://bugs.webkit.org/show_bug.cgi?id=57290
2164
2165         * WebView/WebView.mm:
2166         (-[WebView _preferencesChangedNotification:]): Copy the private value of
2167           the timer magnification to WebCore::Settings.
2168         (-[WebView validationMessageTimerMagnification]): Added.
2169         (-[WebView setValidationMessageTimerMagnification:]): Added.
2170         * WebView/WebViewData.h: Declare a member for the timer magnification.
2171         * WebView/WebViewData.mm:
2172         (-[WebViewPrivate init]): Initialize the timer magnification.
2173         * WebView/WebViewPrivate.h:
2174           Declare a setter and a getter for the timer magnification.
2175
2176 2011-03-29  Kent Tamura  <tkent@chromium.org>
2177
2178         Reviewed by Dimitri Glazkov.
2179
2180         [Mac] Enable interactive-validation tests on Mac DRT
2181         https://bugs.webkit.org/show_bug.cgi?id=57308
2182
2183         * WebView/WebView.mm:
2184         (-[WebView _preferencesChangedNotification:]):
2185           Convey a WebView flag for interactive validation to WebCore::Settings.
2186         (-[WebView interactiveFormValidationEnabled]): Added.
2187         (-[WebView setInteractiveFormValidationEnabled:]): Added.
2188         * WebView/WebViewData.h: Add interactiveFormValidationEnabled.
2189         * WebView/WebViewData.mm:
2190         (-[WebViewPrivate init]): Initialize interactiveFormValidationEnabled.
2191         * WebView/WebViewPrivate.h: Add setter and getter for interactiveFormValidationEnabled.
2192
2193 2011-03-29  Timothy Hatcher  <timothy@apple.com>
2194
2195         Update the order of the context menu to better match AppKit on Mac.
2196
2197         <rdar://problem/9054893>
2198
2199         Reviewed by John Sullivan.
2200
2201         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2202         (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Update the order of items.
2203         * WebCoreSupport/WebPlatformStrategies.h:
2204         * WebCoreSupport/WebPlatformStrategies.mm:
2205         (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): Added argument for selected string.
2206
2207 2011-03-29  Alexey Proskuryakov  <ap@apple.com>
2208
2209         Reviewed by Darin Adler.
2210
2211         https://bugs.webkit.org/show_bug.cgi?id=57379
2212         Clean up WK1 key event handling logic
2213
2214         No bugs knowingly fixed, but this makes the code more consistent.
2215
2216         * WebView/WebHTMLView.mm:
2217         (struct WebHTMLViewInterpretKeyEventsParameters): Renamed eventWasHandled to
2218         eventInterpretationHadSideEffects, because "handled" doesn't really mean much.
2219         (-[WebHTMLView _executeSavedEditingCommands]): Factored out from _interpretKeyEvent for use
2220         from other functions. We need to execute saved commands when an input method asks for current
2221         state, because providing stale state could confuse it.
2222         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Heavily commented, and updated for other
2223         changes.
2224         (-[WebHTMLView characterIndexForPoint:]): Call _executeSavedEditingCommands, because otherwise,
2225         the answer would be stale.
2226         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2227         (-[WebHTMLView selectedRange]): Ditto.
2228         (-[WebHTMLView markedRange]): Ditto.
2229         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2230         (-[WebHTMLView hasMarkedText]): Ditto.
2231         (-[WebHTMLView unmarkText]): Call _executeSavedEditingCommands, because otherwise, we'd be
2232         operating on stale data. Also, updated for eventWasHandled renaming.
2233         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2234         (-[WebHTMLView doCommandBySelector:]): Removed special handling for noop:. I verified that
2235         it's no longer needed for bug 14522, presumably due to WebCore level changes. It was also
2236         fragile, because there is no guarantee about when noop: is sent (also, a custom key binding
2237         could have a noop: as one of its commands, although that's hardly practical).
2238         Added the same "from input method" logic that we have in insertText: - I don't know of any
2239         IMs that call this method, but we clearly need to execute it as part of IM processing when
2240         there is marked text.
2241         (-[WebHTMLView insertText:]): Removed a confusing check for [text length]. Always set
2242         eventInterpretationHadSideEffects to true, becasue there is no reason to try multiple times
2243         if current selection isn't editable. This is different from doCommandBySelector:, where we
2244         need to give super class a chance to handle the event if our processing fails.
2245         Removed a nonsense "consumedByIM = true" assignment - we no longer need it now that the
2246         return value of _interpretKeyEvent is computed differently.
2247
2248 2011-03-28  Adele Peterson  <adele@apple.com>
2249
2250         Reviewed by Eric Seidel.
2251
2252         Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
2253         https://bugs.webkit.org/show_bug.cgi?id=57173
2254
2255         * WebView/WebFrame.mm:
2256         (-[WebFrame hasSpellingMarker:length:]): Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
2257         (-[WebFrame hasGrammarMarker:length:]): Call new selectionStartHasMarkerFor method.
2258         * WebView/WebFramePrivate.h: Add hasGrammarMarker so grammar marking can be tested.
2259
2260 2011-03-28  Alexey Proskuryakov  <ap@apple.com>
2261
2262         Reviewed by Darin Adler.
2263
2264         https://bugs.webkit.org/show_bug.cgi?id=57260
2265         Clean up text input code a little
2266
2267         * WebCoreSupport/WebEditorClient.mm:
2268         (WebEditorClient::handleKeyboardEvent):
2269         (WebEditorClient::handleInputMethodKeydown):
2270         * WebView/WebHTMLViewInternal.h:
2271         Renamed _interceptEditingKeyEvent:shouldSaveCommand:, becasue it doesn't really intercept
2272         anything. It's just a version it interpretKeyEvents: that tells us whether it was handled,
2273         and also possibly saves resulting commands for later execution.
2274
2275         * WebView/WebHTMLView.mm:
2276         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Changed to use early return. Changed
2277         return value in case platformEvent is null to be less mysterious. Moved receivedNOOP from
2278         WebHTMLViewPrivate to WebHTMLViewInterpretKeyEventsParameters, as this is just part of event
2279         handling state, like the other booleans there. Don't call interpretKeyEvents: again simply
2280         because the first call resulted in no saved commands, becasue it's confusing and apparently
2281         useless (I couldn't find any broken behavior).
2282         (-[WebHTMLView unmarkText]): Cleaned upo BOOL vs. bool constants.
2283         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2284         (-[WebHTMLView doCommandBySelector:]): Ditto.
2285         (-[WebHTMLView insertText:]): Ditto.
2286
2287         * WebView/WebViewInternal.h: There was no _interceptEditingKeyEvent:shouldSaveCommand:
2288         method on WebView.
2289
2290 2011-03-27  Jer Noble  <jer.noble@apple.com>
2291
2292         Reviewed by Maciej Stachowiak.
2293
2294         Full Screen: disable keyboard access by default
2295         https://bugs.webkit.org/show_bug.cgi?id=56684
2296
2297         Take into account whether keyboard access was requested when deciding whether full
2298         screen mode is supported.
2299
2300         * WebCoreSupport/WebChromeClient.h:
2301         * WebCoreSupport/WebChromeClient.mm:
2302         (WebChromeClient::supportsFullScreenForElement):
2303         * WebView/WebView.mm:
2304         (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):
2305         * WebView/WebViewInternal.h:
2306
2307 2011-03-26  Jer Noble  <jer.noble@apple.com>
2308
2309         Reviewed by Eric Carlson.
2310
2311         Enable the Full Screen API by default in WebKit/mac and WebKit2
2312         https://bugs.webkit.org/show_bug.cgi?id=56956
2313
2314         * WebView/WebPreferences.mm:
2315         (+[WebPreferences initialize]): Default the WebKitFullScreenEnabled preference to true.
2316
2317 2011-03-25  Andy Estes  <aestes@apple.com>
2318
2319         Reviewed by Adele Peterson.
2320
2321         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
2322         https://bugs.webkit.org/show_bug.cgi?id=49016
2323
2324         Update objectContentType() implementation to handle the
2325         shouldPreferPlugInsForImages flag.
2326
2327         * WebCoreSupport/WebFrameLoaderClient.h:
2328         * WebCoreSupport/WebFrameLoaderClient.mm:
2329         (WebFrameLoaderClient::objectContentType):
2330
2331 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2332
2333         Unreviewed, rolling out r81939.
2334         http://trac.webkit.org/changeset/81939
2335         https://bugs.webkit.org/show_bug.cgi?id=57084
2336
2337         Rolling out 81939, as it's causing a number of app cache test
2338         failures. (Requested by jernoble on #webkit).
2339
2340         * WebView/WebView.mm:
2341         (-[WebView _preferencesChangedNotification:]):
2342
2343 2011-03-23  Jer Noble  <jer.noble@apple.com>
2344
2345         Reviewed by Maciej Stachowiak.
2346
2347         Application Cache should save audio/ and video/ mime types as flat files
2348         https://bugs.webkit.org/show_bug.cgi?id=53784
2349         <rdar://problem/8932473>
2350
2351         No new tests.
2352
2353         Initialize the AppCache Total size quotas with the values for WebKitPreferences
2354         upon startup.
2355
2356         * WebView/WebView.mm:
2357         (-[WebView _preferencesChangedNotification:]):
2358
2359 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2360
2361         Unreviewed, rolling out r81916 and r81917.
2362         http://trac.webkit.org/changeset/81916
2363         http://trac.webkit.org/changeset/81917
2364         https://bugs.webkit.org/show_bug.cgi?id=57071
2365
2366         broke a test on platforms that do not have QuickTime installed
2367         (Requested by estes on #webkit).
2368
2369         * WebCoreSupport/WebFrameLoaderClient.h:
2370         * WebCoreSupport/WebFrameLoaderClient.mm:
2371         (WebFrameLoaderClient::objectContentType):
2372
2373 2011-03-24  Andy Estes  <aestes@apple.com>
2374
2375         Reviewed by Darin Adler.
2376
2377         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
2378         https://bugs.webkit.org/show_bug.cgi?id=49016
2379
2380         Update objectContentType() implementation to handle the
2381         shouldPreferPlugInsForImages flag.
2382
2383         * WebCoreSupport/WebFrameLoaderClient.h:
2384         * WebCoreSupport/WebFrameLoaderClient.mm:
2385         (WebFrameLoaderClient::objectContentType):
2386
2387 2011-03-24  Geoffrey Garen  <ggaren@apple.com>
2388
2389         Reviewed by Oliver Hunt.
2390
2391         Ensure that all compilation takes place within a dynamic global object scope
2392         https://bugs.webkit.org/show_bug.cgi?id=57054
2393
2394         * WebView/WebScriptDebugDelegate.mm:
2395         (-[WebScriptCallFrame evaluateWebScript:]): Updated for signature change.
2396
2397 2011-03-24  Jia Pu  <jpu@apple.com>
2398
2399         Reviewed by Darin Adler.
2400
2401         Dismissed reversion suggestion is incorrectly learned.
2402         https://bugs.webkit.org/show_bug.cgi?id=57039
2403
2404         CorrectionPanel should always use [NSSpellChecker dismissCorrectionBubbleForView].
2405         [NSSpellChecker cancelCorrectionBubbleForView] is reserved for situation where correction panel
2406         is dismissed explicitly by ESC key or clicking the dimiss button. Misusing these causes
2407         incorrect automatic learning.
2408
2409         * WebCoreSupport/CorrectionPanel.mm:
2410         (CorrectionPanel::dismissInternal):
2411
2412 2011-03-24  David Kilzer  <ddkilzer@apple.com>
2413
2414         <http://webkit.org/b/56993> ENABLE_PLUGIN_PROXY_FOR_VIDEO should be defined to 0 on Mac OS X
2415
2416         Reviewed by Joseph Pecoraro.
2417
2418         * Plugins/WebPluginContainerPrivate.h: Changed value of
2419         ENABLE_PLUGIN_PROXY_FOR_VIDEO from 1 to 0.
2420
2421 2011-03-23  Jia Pu  <jpu@apple.com>
2422
2423         Reviewed by Darin Adler.
2424
2425         Hook up new AppKit autocorrection UI with WK2.
2426         https://bugs.webkit.org/show_bug.cgi?id=56055
2427         <rdar://problem/8947463>
2428
2429         Please see WebCore/ChangeLog for detail.
2430
2431         * WebCoreSupport/CorrectionPanel.h: Added.
2432         (CorrectionPanel::isShowing):
2433         * WebCoreSupport/CorrectionPanel.mm: Added.
2434         (correctionBubbleType):
2435         (CorrectionPanel::CorrectionPanel):
2436         (CorrectionPanel::~CorrectionPanel):
2437         (CorrectionPanel::show):
2438         (CorrectionPanel::dismiss):
2439         (CorrectionPanel::dismissSoon):
2440         (CorrectionPanel::dismissInternal):
2441         (CorrectionPanel::recordAutocorrectionResponse):
2442         * WebCoreSupport/WebEditorClient.h:
2443         * WebCoreSupport/WebEditorClient.mm:
2444         (WebEditorClient::WebEditorClient):
2445         (WebEditorClient::showCorrectionPanel):
2446         (WebEditorClient::dismissCorrectionPanel):
2447         (WebEditorClient::dismissCorrectionPanelSoon):
2448         (WebEditorClient::recordAutocorrectionResponse):
2449         * WebView/WebView.mm:
2450         (-[WebView handleCorrectionPanelResult:]):
2451         * WebView/WebViewPrivate.h:
2452
2453 2011-03-23  Enrica Casucci  <enrica@apple.com>
2454
2455         Reviewed by Alexey Proskuryakov.
2456
2457         Services menu item to convert selected Simplified/Traditional Chinese Text is not working.
2458         https://bugs.webkit.org/show_bug.cgi?id=56974
2459         <rdar://problem/8284642>
2460
2461         This fixes a regression introduced by http://trac.webkit.org/changeset/61794
2462         where readSelectionFromPasteboard was accidentally removed.
2463         This method and writeSelectionToPasteboard are needed to support Mac OS X
2464         services.
2465         
2466         * WebView/WebHTMLView.mm:
2467         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Added.
2468         (-[WebHTMLView readSelectionFromPasteboard:]): Added.
2469
2470 2011-03-23  Brady Eidson  <beidson@apple.com>
2471
2472         Reviewed by Sam Weinig.
2473
2474         Change IconDatabase opening to allow for arbitrary filenames
2475         https://bugs.webkit.org/show_bug.cgi?id=56977
2476
2477         * Misc/WebIconDatabase.mm:
2478         (-[WebIconDatabase _startUpIconDatabase]):
2479
2480 2011-03-22  Anton D'Auria  <adauria@apple.com>
2481
2482         Reviewed by Alexey Proskuryakov.
2483
2484         Add +[WebApplicationCache getOriginsWithCache]
2485         https://bugs.webkit.org/show_bug.cgi?id=56722
2486
2487         Call existing WebCore::ApplicationCacheStorage::getOriginsWithCache API.
2488
2489         * WebCoreSupport/WebApplicationCache.h:
2490         * WebCoreSupport/WebApplicationCache.mm:
2491         (+[WebApplicationCache originsWithCache]):
2492
2493 2011-03-22  Anders Carlsson  <andersca@apple.com>
2494
2495         Reviewed by Sam Weinig.
2496
2497         OBJECT element with DivX source is always downloaded
2498         https://bugs.webkit.org/show_bug.cgi?id=56879
2499
2500         * Plugins/WebBasePluginPackage.mm:
2501         (-[WebBasePluginPackage getPluginInfoFromPLists]):
2502         Always try to split every element in the "WebPluginExtensions" array, since the DivX plug-in
2503         specifies multiple file extensions in a single element.
2504
2505 2011-03-22  Brady Eidson  <beidson@apple.com>
2506
2507         Reviewed by Sam Weinig.
2508
2509         <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876
2510         WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread
2511
2512         Note that while the new client calls always come through on the main thread, our mechanisms to
2513         route dispatches to the main thread are still valid and will still work.
2514
2515         Update to the new IconDatabaseClient interface:
2516         * WebCoreSupport/WebIconDatabaseClient.h:
2517         * WebCoreSupport/WebIconDatabaseClient.mm:
2518         (WebIconDatabaseClient::didRemoveAllIcons):
2519         (WebIconDatabaseClient::didImportIconURLForPageURL):
2520         (WebIconDatabaseClient::didImportIconDataForPageURL):
2521         (WebIconDatabaseClient::didChangeIconForPageURL):
2522         (WebIconDatabaseClient::didFinishURLImport):
2523
2524 2011-03-22  Matthew Delaney  <mdelaney@apple.com>
2525
2526         Reviewed by Simon Fraser.
2527
2528         Have WebKit push acceleratedDrawing preferences to settings
2529         https://bugs.webkit.org/show_bug.cgi?id=56792
2530
2531         * WebView/WebView.mm:
2532
2533 2011-03-21  Nate Chapin  <japhet@chromium.org>
2534
2535         Reviewed by Brady Eidson.
2536
2537         Expose a preference to use caching quirks for QuickLook,
2538         and use it if the QuickLook framework is loaded.
2539
2540         https://bugs.webkit.org/show_bug.cgi?id=38690
2541
2542         * WebView/WebPreferenceKeysPrivate.h:
2543         * WebView/WebPreferences.mm:
2544         (useQuickLookQuirks):
2545         (+[WebPreferences initialize]):
2546         (-[WebPreferences useQuickLookResourceCachingQuirks]):
2547         * WebView/WebPreferencesPrivate.h:
2548         * WebView/WebView.mm:
2549         (-[WebView _preferencesChangedNotification:]):
2550
2551 2011-03-21  Chris Fleizach  <cfleizach@apple.com>
2552
2553         Reviewed by Darin Adler.
2554
2555         AX: showContextMenu not working in WK2
2556         https://bugs.webkit.org/show_bug.cgi?id=56734
2557
2558         Implement showContextMenu() so accessibility related code can call this
2559         independent of whether WK1 or WK2 is running.
2560
2561         * WebCoreSupport/WebChromeClient.h:
2562         * WebCoreSupport/WebChromeClient.mm:
2563         (WebChromeClient::showContextMenu):
2564
2565 2011-03-21  Chang Shu  <cshu@webkit.org>
2566
2567         Reviewed by Alexey Proskuryakov.
2568
2569         REGRESSION (r79953): Can't type in MS Outlook 2011
2570         https://bugs.webkit.org/show_bug.cgi?id=56665
2571
2572         r79953 removed the WebView level editablity which is persistent no matter whether
2573         underlying document itself is changed and editability gets lost. The resolution is to
2574         set this WebView editable value to WebCore. This avoids the callback from WebCore to
2575         WebKit which was the main goal in r79953 to improve performance.
2576
2577         * WebView/WebView.mm:
2578         (-[WebView setEditable:]):
2579         (-[WebView isEditable]):
2580
2581 2011-03-19  Anton D'Auria  <adauria@apple.com>
2582
2583         Reviewed by Alexey Proskuryakov.
2584
2585         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
2586         https://bugs.webkit.org/show_bug.cgi?id=56415
2587         
2588         Use new ApplicationCache API to delete all cache for an origin.
2589
2590         * WebCoreSupport/WebApplicationCache.h:
2591         * WebCoreSupport/WebApplicationCache.mm:
2592         (+[WebApplicationCache deleteOrigin:]):
2593
2594 2011-03-17  Brady Eidson  <beidson@apple.com>
2595
2596         Reviewed by Sam Weinig.
2597
2598         https://bugs.webkit.org/show_bug.cgi?id=56425
2599         More groundwork for WebKit2 IconDatabase
2600
2601         Update already-used function names:
2602         * Misc/WebIconDatabase.mm:
2603         (-[WebIconDatabase iconForURL:withSize:cache:]):
2604         (-[WebIconDatabase iconURLForURL:]):
2605         * WebView/WebView.mm:
2606         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
2607
2608 2011-03-18  Pavel Podivilov  <podivilov@chromium.org>
2609
2610         Reviewed by Yury Semikhatsky.
2611
2612         Web Inspector: implement inspector session storage.
2613         https://bugs.webkit.org/show_bug.cgi?id=56643
2614
2615         * WebCoreSupport/WebInspectorClient.h:
2616         * WebCoreSupport/WebInspectorClient.mm:
2617         (WebInspectorClient::saveSessionSetting):
2618         (WebInspectorClient::loadSessionSetting):
2619         (WebInspectorFrontendClient::saveSessionSetting):
2620         (WebInspectorFrontendClient::loadSessionSetting):
2621         (-[WebInspectorWindowController inspectorClient]):
2622
2623 2011-03-17  Geoffrey Garen  <ggaren@apple.com>
2624
2625         Reviewed by Oliver Hunt.
2626
2627         Fixed a leak seen on the buildbot.
2628
2629         * WebCoreSupport/WebInspectorClient.mm:
2630         (WebInspectorClient::openInspectorFrontend): Smart pointers are smart.
2631
2632 2011-03-16  Jeff Johnson  <github@lapcatsoftware.com>
2633
2634         Reviewed by Alexey Proskuryakov.
2635
2636         Logic error in -[WebHTMLView close]
2637         https://bugs.webkit.org/show_bug.cgi?id=56445
2638
2639         Page is always nil at this point, because [self _webView] is nil,
2640         so the conditional code is never run.
2641
2642         * WebView/WebHTMLView.mm:
2643         (-[WebHTMLView close]):
2644
2645 2011-03-16  Chris Fleizach  <cfleizach@apple.com>
2646
2647         Reviewed by Darin Adler.
2648
2649         WK2: Need to propagate enhanced accessibility flag from UI -> web process
2650         https://bugs.webkit.org/show_bug.cgi?id=56379
2651
2652         * WebView/WebFrame.mm:
2653         (-[WebFrame accessibilityRoot]):
2654
2655 2011-03-15  Oliver Hunt  <oliver@apple.com>
2656
2657         Reviewed by Geoffrey Garen.
2658
2659         Make Structure creation require a JSGlobalData
2660         https://bugs.webkit.org/show_bug.cgi?id=56438
2661
2662         Mechanical change to make all Structure creation use a JSGlobalData&
2663
2664         * Plugins/Hosted/ProxyInstance.mm:
2665         (WebKit::ProxyRuntimeMethod::createStructure):
2666         * Plugins/Hosted/ProxyRuntimeObject.h:
2667         (WebKit::ProxyRuntimeObject::createStructure):
2668
2669 2011-03-15  Alexey Proskuryakov  <ap@apple.com>
2670
2671         Forgot to save a modification to this file when committing.
2672
2673         * WebCoreSupport/WebKeyGenerator.mm: Changed "Apple Computer" to "Apple" in copyright header.
2674
2675 2011-03-15  Alexey Proskuryakov  <ap@apple.com>
2676
2677         Reviewed by Darin Adler.
2678
2679         REGRESSION (WebKit2): keygen element doesn't work
2680         https://bugs.webkit.org/show_bug.cgi?id=56402
2681         <rdar://problem/9006545>
2682
2683         * WebCoreSupport/WebKeyGenerator.h:
2684         * WebCoreSupport/WebKeyGenerator.m: Removed.
2685         * WebCoreSupport/WebKeyGenerator.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebKeyGenerator.m.
2686         (+[WebKeyGenerator sharedGenerator]):
2687         (toWebCertificateParseResult):
2688         WebCore no longer needs WebKeyGenerator. Safari still does need a part of it, so keeping
2689         this misnamed and misplaced code for now.
2690
2691         * WebCoreSupport/WebPlatformStrategies.h:
2692         * WebCoreSupport/WebPlatformStrategies.mm:
2693         (WebPlatformStrategies::keygenMenuItem512):
2694         (WebPlatformStrategies::keygenMenuItem1024):
2695         (WebPlatformStrategies::keygenMenuItem2048):
2696         (WebPlatformStrategies::keygenKeychainItemName):
2697         Added strings used by keygen.
2698
2699         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize a WebCore
2700         pointer to a function used by keygen.
2701
2702         * WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): WebKeyGenerator can be lazily
2703         initialized now.
2704
2705 2011-03-15  Beth Dakin  <bdakin@apple.com>
2706
2707         Reviewed by Simon Fraser.
2708
2709         WebKit part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%
2710
2711         New WebKitystemInterface function to force the scrollbars to flash
2712         * WebCoreSupport/WebSystemInterface.mm:
2713         (InitWebCoreSystemInterface):
2714
2715 2011-03-15  Ilya Sherman  <isherman@chromium.org>
2716
2717         Reviewed by Tony Chang.
2718
2719         Autofilled form elements are assigned fixed background color but not text color
2720         https://bugs.webkit.org/show_bug.cgi?id=48382
2721
2722         * DOM/WebDOMOperations.mm:
2723         (-[DOMHTMLInputElement _setAutofilled:]): Added (wrapper).
2724         * DOM/WebDOMOperationsPrivate.h:
2725
2726 2011-03-15  Adam Roben  <aroben@apple.com>
2727
2728         Fix a leak in WebStorageTrackerClient::dispatchDidModifyOrigin
2729
2730         Fixes <http://webkit.org/b/56385> SecurityOrigin leaks seen in
2731         WebStorageTrackerClient::dispatchDidModifyOrigin
2732
2733         Reviewed by Antti Koivisto.
2734
2735         * Storage/WebStorageTrackerClient.mm:
2736         (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): Adopt the reference passed
2737         to us by dispatchDidModifyOrigin.
2738         (WebStorageTrackerClient::dispatchDidModifyOrigin): Added a comment and removed an
2739         unnecessary cast.
2740
2741 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2742
2743         Reviewed by Darin Adler.
2744
2745         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
2746         info into the headers rather than in export symbol definition files, but disable it on 
2747         all platforms initially so we can deal with port build issues one port at a time.
2748         
2749         https://bugs.webkit.org/show_bug.cgi?id=27551
2750
2751         * WebKitPrefix.h:
2752
2753 2011-03-14  Brady Eidson  <beidson@apple.com>
2754
2755         Reviewed by Anders Carlsson.
2756
2757         https://bugs.webkit.org/show_bug.cgi?id=56320
2758         Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
2759
2760         * History/WebHistoryItem.mm:
2761         (-[WebHistoryItem icon]): This far-future FIXME is now irrelevant.
2762
2763 2011-03-13  Pratik Solanki  <psolanki@apple.com>
2764
2765         Reviewed by Brady Eidson.
2766
2767         Make adjustMIMETypeIfNecessary use CFNetwork directly
2768         https://bugs.webkit.org/show_bug.cgi?id=55912
2769
2770         * WebCoreSupport/WebSystemInterface.mm:
2771         (InitWebCoreSystemInterface): Support for new WKSI functions.
2772
2773 2011-03-12  Mark Rowe  <mrowe@apple.com>
2774
2775         Fix the 32-bit build.
2776
2777         * Carbon/CarbonWindowAdapter.mm:
2778         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier.
2779         (-[CarbonWindowAdapter _carbonWindowClass]): Ditto.
2780
2781 2011-03-11  Brady Eidson  <beidson@apple.com>
2782
2783         Reviewed by Anders Carlsson
2784
2785         <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56216
2786         Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation.
2787
2788         * Misc/WebIconDatabase.mm:
2789         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Call these static methods on IconDatabase::, not iconDatabase().
2790         (-[WebIconDatabase _startUpIconDatabase]): Ditto.
2791         (importToWebCoreFormat):
2792
2793 2011-03-11  Anton D'Auria  <adauria@apple.com>
2794
2795         Reviewed and landed by Brady Eidson.
2796
2797         https://bugs.webkit.org/show_bug.cgi?id=51878
2798         Add WebKit1 API to view and delete local storage
2799
2800         * Storage/WebStorageManager.mm: Added.
2801         (+[WebStorageManager sharedWebStorageManager]):
2802         (-[WebStorageManager origins]):
2803         (-[WebStorageManager deleteAllOrigins]):
2804         (-[WebStorageManager deleteOrigin:]):
2805         (-[WebStorageManager syncLocalStorage]):
2806         (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
2807         (storageDirectoryPath):
2808         (WebKitInitializeStorageIfNecessary):
2809         * Storage/WebStorageManagerInternal.h: Added.
2810         * Storage/WebStorageManagerPrivate.h: Added.
2811         * Storage/WebStorageTrackerClient.h: Added.
2812         * Storage/WebStorageTrackerClient.mm: Added.
2813         (WebStorageTrackerClient::sharedWebStorageTrackerClient):
2814         (WebStorageTrackerClient::WebStorageTrackerClient):
2815         (WebStorageTrackerClient::~WebStorageTrackerClient):
2816         (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread):
2817         (WebStorageTrackerClient::dispatchDidModifyOrigin):
2818         * WebCoreSupport/WebSecurityOrigin.mm:
2819         (-[WebSecurityOrigin protocol]):
2820         (-[WebSecurityOrigin host]):
2821         (-[WebSecurityOrigin databaseIdentifier]):
2822         (-[WebSecurityOrigin domain]):
2823         (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
2824         * WebCoreSupport/WebSecurityOriginPrivate.h:
2825         * WebKit.exp:
2826         * WebView/WebView.mm:
2827         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2828
2829 2011-03-10  Anders Carlsson  <andersca@apple.com>
2830
2831         Reviewed by Sam Weinig.
2832
2833         <rdar://problem/9117047>
2834         Don't paint more than 60 times per second even when scrolling
2835
2836         * WebView/WebClipView.mm:
2837         (-[WebClipView _immediateScrollToPoint:]):
2838
2839 2011-03-09  Matthew Delaney  <mdelaney@apple.com>
2840
2841         Reviewed by Simon Fraser.
2842
2843         Plumb through settings for accelerated drawing for canvas
2844         https://bugs.webkit.org/show_bug.cgi?id=56039
2845
2846         * WebView/WebPreferenceKeysPrivate.h:
2847         * WebView/WebPreferences.mm:
2848         * WebView/WebPreferencesPrivate.h:
2849
2850 2011-03-10  Ryosuke Niwa  <rniwa@webkit.org>
2851
2852         Reviewed by Tony Chang.
2853
2854         VisiblePosition's next and previous should take an enum instead of a boolean
2855         https://bugs.webkit.org/show_bug.cgi?id=56135
2856
2857         SelectionController::isAll now takes EditingBoundaryCrossingRule instead of
2858         StayInEditableContent.
2859
2860         * WebView/WebView.mm:
2861         (-[WebView _selectionIsAll]):
2862
2863 2011-03-09  Jessie Berlin  <jberlin@apple.com>
2864
2865         Reviewed by Adam Roben.
2866
2867         Use the Cookie Storage from the Private Browsing Storage Session directly
2868         https://bugs.webkit.org/show_bug.cgi?id=55986
2869
2870         * WebCoreSupport/WebSystemInterface.mm:
2871         (InitWebCoreSystemInterface):
2872
2873 2011-03-08  Darin Adler  <darin@apple.com>
2874
2875         Reviewed by Timothy Hatcher.
2876
2877         Promote a method used outside WebKit from internal to private
2878         https://bugs.webkit.org/show_bug.cgi?id=55949
2879
2880         * Misc/WebNSPasteboardExtras.mm: Removed an unused category declaration.
2881         Minor tweak, not directly related to the rest of this patch.
2882
2883         * WebView/WebFrame.mm:
2884         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): Moved
2885         this method from the internal category into the private category.
2886         Streamlined the code a bit.
2887
2888         * WebView/WebFrameInternal.h: Removed _computePageRects method.
2889         * WebView/WebFramePrivate.h: Added _computePageRects method.
2890
2891 2011-03-07  Ryosuke Niwa  <rniwa@webkit.org>
2892
2893         Reviewed by Darin Adler.
2894
2895         selectionHasStyle and selectionStartHasStyle should use EditingStyle
2896         https://bugs.webkit.org/show_bug.cgi?id=55902
2897
2898         selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.
2899
2900         * WebView/WebHTMLView.mm: Removed unused selectionHasStyle.
2901         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Calls Editor::selectionHasStyle.
2902
2903 2011-03-07  Dan Bernstein  <mitz@apple.com>
2904
2905         LLVM Compiler build fix.
2906
2907         * WebCoreSupport/WebEditorClient.mm:
2908         (WebEditorClient::checkGrammarOfString):
2909
2910 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
2911
2912         Reviewed by Beth Dakin.
2913
2914         AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
2915         https://bugs.webkit.org/show_bug.cgi?id=55706
2916
2917         Make sure WebDynamicScrollBarsView appear in the AX tree in WK1 (since this object
2918         returns the scroll bar objects).
2919         Make the accessibilityRoot object be the web area in WK1 because WebDynamicScrollBarsView
2920         will expect that as its child, instead of the WebCore ScrollView object.
2921
2922         * WebView/WebDynamicScrollBarsView.mm:
2923         (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
2924         * WebView/WebFrame.mm:
2925         (-[WebFrame accessibilityRoot]):
2926
2927 2011-03-07  Sam Weinig  <sam@webkit.org>
2928
2929         Reviewed by Anders Carlsson.
2930
2931         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
2932         https://bugs.webkit.org/show_bug.cgi?id=55827
2933
2934         Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
2935         and pass the entire response, instead of just the MIMEType.
2936
2937         * WebCoreSupport/WebFrameLoaderClient.h:
2938         * WebCoreSupport/WebFrameLoaderClient.mm:
2939         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2940
2941 2011-03-06  Dan Bernstein  <mitz@apple.com>
2942
2943         LLVM Compiler build fix.
2944
2945         * DOM/WebDOMOperations.mm:
2946         (-[DOMHTMLInputElement _setValueForUser:]):
2947
2948 2011-03-06  Jessie Berlin  <jberlin@apple.com>
2949
2950         Reviewed by Sam Weinig.
2951
2952         WebKit2: Use CFNetwork Sessions API.
2953         https://bugs.webkit.org/show_bug.cgi?id=55435.
2954
2955         When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
2956         Private Browsing Storage Session.
2957
2958         * WebCoreSupport/WebSystemInterface.mm:
2959         (InitWebCoreSystemInterface):
2960         Add support for using the new WKSI functions in WebCore.
2961
2962 2011-03-05  Ilya Sherman  <isherman@chromium.org>
2963
2964         Reviewed by Darin Adler.
2965
2966         HTMLInputElement::setValue() should schedule change event when the element is focused
2967         In service of https://code.google.com/p/chromium/issues/detail?id=42716
2968         https://bugs.webkit.org/show_bug.cgi?id=53160
2969
2970         * DOM/WebDOMOperations.mm:
2971         (-[DOMHTMLInputElement _setValueForUser:]): Expose HTMLInputElement::setValueForUser() to tests
2972         * DOM/WebDOMOperationsPrivate.h:
2973         * WebView/WebViewInternal.h:
2974
2975 2011-03-04  Jia Pu  <jpu@apple.com>
2976
2977         Reviewed by Darin Adler.
2978
2979         On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
2980         https://bugs.webkit.org/show_bug.cgi?id=55717
2981         <rdar://problem/9018127>
2982
2983         With the change in WebCore, the bounding box passed into EditorClient::showCorrectionPanel()
2984         is already in window coordinate. We don't need to do further conversion anymore.
2985
2986         * WebCoreSupport/WebEditorClient.mm:
2987         (WebEditorClient::showCorrectionPanel):
2988
2989 2011-03-04  Jessie Berlin  <jberlin@apple.com>
2990
2991         Reviewed by Maciej Stachowiak.
2992
2993         WebKit2: Use CFNetwork Sessions API.
2994         https://bugs.webkit.org/show_bug.cgi?id=55435.
2995
2996         When Private Browsing is enabled, get the cached url response from the cache associated with
2997         the Private Browsing Storage Session.
2998
2999         * WebView/WebView.mm:
3000         (-[WebView _cachedResponseForURL:]):
3001
3002 2011-03-03  Anders Carlsson  <andersca@apple.com>
3003
3004         Reviewed by Sam Weinig.
3005
3006         Get rid of Page::globalHistoryItem
3007         https://bugs.webkit.org/show_bug.cgi?id=55738
3008
3009         * WebCoreSupport/WebFrameLoaderClient.h:
3010         * WebCoreSupport/WebFrameLoaderClient.mm:
3011         (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
3012         Get the current history item and update it using -[WebView _setGlobalHistoryItem:].
3013     
3014         * WebView/WebView.mm:
3015         (-[WebView _globalHistoryItem]):
3016         (-[WebView _setGlobalHistoryItem:]):
3017         Set _globalHistoryItem ivar.
3018
3019         * WebView/WebViewData.h:
3020         * WebView/WebViewData.mm:
3021         Add _globalHistoryItem ivar.
3022
3023 2011-03-03  Brady Eidson  <beidson@apple.com>
3024
3025         Reviewed by Darin Adler.
3026
3027         https://bugs.webkit.org/show_bug.cgi?id=55721
3028         Global IconDatabase should be returned by reference, not as a pointer
3029
3030         * Misc/WebCoreStatistics.mm:
3031         (+[WebCoreStatistics iconPageURLMappingCount]):
3032         (+[WebCoreStatistics iconRetainedPageURLCount]):
3033         (+[WebCoreStatistics iconRecordCount]):
3034         (+[WebCoreStatistics iconsWithDataCount]):
3035         * Misc/WebIconDatabase.mm:
3036         (-[WebIconDatabase init]):
3037         (-[WebIconDatabase iconForURL:withSize:cache:]):
3038         (-[WebIconDatabase iconURLForURL:]):
3039         (-[WebIconDatabase defaultIconWithSize:]):
3040         (-[WebIconDatabase retainIconForURL:]):
3041         (-[WebIconDatabase releaseIconForURL:]):
3042         (-[WebIconDatabase isEnabled]):
3043         (-[WebIconDatabase setEnabled:]):
3044         (-[WebIconDatabase removeAllIcons]):
3045         (+[WebIconDatabase _checkIntegrityBeforeOpening]):
3046         (-[WebIconDatabase _startUpIconDatabase]):
3047         (-[WebIconDatabase _applicationWillTerminate:]):
3048         (-[WebIconDatabase _resetCachedWebPreferences:]):
3049         (importToWebCoreFormat):
3050         * WebView/WebView.mm:
3051         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
3052
3053 2011-03-03  Jessie Berlin  <jberlin@apple.com>
3054
3055         Reviewed by Adam Roben.
3056
3057         WebKit2: Use CFNetwork Sessions API.
3058         https://bugs.webkit.org/show_bug.cgi?id=55435.
3059
3060         Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
3061
3062         * WebCoreSupport/WebSystemInterface.mm:
3063         (InitWebCoreSystemInterface):
3064         Support using WKCopyRequestWithStorageSession in WebCore.
3065
3066 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
3067
3068         Reviewed by Darin Adler.
3069
3070         REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
3071         https://bugs.webkit.org/show_bug.cgi?id=55633
3072         <rdar://problem/8963023>
3073
3074         * WebCoreSupport/WebChromeClient.h:
3075         * WebCoreSupport/WebChromeClient.mm:
3076         Removed tabsToLinks(). Mac WebKit already implements keyboardUIMode().
3077
3078         * WebView/WebView.mm: (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
3079         Removed an incorrect comment. We actually get a value of 2 on Snow Leopard, and we don't
3080         require both bits to be set. The rest of the comment might be wrong too, but I'm not sure,
3081         so I've preserved it.
3082
3083 2011-03-02  Jessie Berlin  <jberlin@apple.com>
3084
3085         Rubber-stamped by Dan Bernstein.
3086
3087         Fix crashes in private browsing tests in WK1 on Snow Leopard.
3088
3089         * WebCoreSupport/WebSystemInterface.mm:
3090         (InitWebCoreSystemInterface):
3091         Put the INIT call for wkCreatePrivateStorageSession outside of the
3092         #if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
3093         guards.
3094
3095 2011-03-02  Jessie Berlin  <jberlin@apple.com>
3096
3097         Reviewed by Adam Roben.
3098
3099         WebKit2: Use CFNetwork Sessions API.
3100         https://bugs.webkit.org/show_bug.cgi?id=55435.
3101
3102         Add the ability to create a Private Browsing Storage Session.
3103
3104         * WebCoreSupport/WebSystemInterface.mm:
3105         (InitWebCoreSystemInterface):
3106         Support calling wkCreatePrivateStorageSession from WebCore.
3107
3108 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
3109
3110         Reviewed by David Levin.
3111
3112         Add feature define for data transfer items
3113         https://bugs.webkit.org/show_bug.cgi?id=55510
3114
3115         * Configurations/FeatureDefines.xcconfig:
3116
3117 2011-03-02  Sam Weinig  <sam@webkit.org>
3118
3119         Reviewed by Anders Carlsson.
3120
3121         Fix remaining localization issues by piping all localized strings through WebCore's
3122         localization bottleneck.
3123         <rdar://problem/8728860>
3124
3125         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3126         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
3127         * Misc/WebKitErrors.m:
3128         * Misc/WebLocalizableStringsInternal.h: Added.
3129         * Misc/WebLocalizableStringsInternal.mm: Added.
3130         (WebLocalizedStringInternal):
3131         * Panels/WebAuthenticationPanel.m:
3132         (-[WebAuthenticationPanel setUpForChallenge:]):
3133         * Plugins/Hosted/NetscapePluginHostManager.mm:
3134         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3135         * WebCoreSupport/WebEditorClient.mm:
3136         (undoNameForEditAction):
3137         * WebCoreSupport/WebInspectorClient.mm:
3138         (WebInspectorFrontendClient::updateWindowTitle):
3139         (-[WebInspectorWindowController validateUserInterfaceItem:]):
3140         * WebCoreSupport/WebKeyGenerator.m:
3141         (-[WebKeyGenerator strengthMenuItemTitles]):
3142         (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]):
3143         * WebCoreSupport/WebPlatformStrategies.mm:
3144         * WebView/WebHTMLView.mm:
3145         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3146         * WebView/WebPDFView.mm:
3147         (-[WebPDFView menuForEvent:]):
3148
3149 2011-03-01  Brian Weinstein  <bweinstein@apple.com>
3150
3151         Reviewed by Adam Roben.
3152
3153         Part of WebKit2: Need a way to send notifications to client when cookies change
3154         https://bugs.webkit.org/show_bug.cgi?id=55427
3155         <rdar://problem/9056027>
3156         
3157         Add stubs for CookiesStrategy on Mac WebKit1.
3158
3159         * WebCoreSupport/WebPlatformStrategies.h:
3160         * WebCoreSupport/WebPlatformStrategies.mm:
3161         (WebPlatformStrategies::createCookiesStrategy):
3162         (WebPlatformStrategies::notifyCookiesChanged):
3163
3164 2011-03-01  Philippe Normand  <pnormand@igalia.com>
3165
3166         Reviewed by Eric Carlson.
3167
3168         [GStreamer] support in mac video fullscreen controller
3169         https://bugs.webkit.org/show_bug.cgi?id=52280
3170
3171         Factored the code to configure the video overlay in a new private
3172         method of the controller and added GStreamer support to it.
3173
3174         * WebView/WebVideoFullscreenController.h:
3175         * WebView/WebVideoFullscreenController.mm:
3176         (-[WebVideoFullscreenController setupVideoOverlay:]):
3177         (-[WebVideoFullscreenController windowDidLoad]):
3178         (-[WebVideoFullscreenController setMediaElement:WebCore::]):
3179         (-[WebVideoFullscreenController windowDidExitFullscreen]):
3180
3181 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
3182
3183         Reviewed by Timothy Hatcher.
3184
3185         All Console Messages should be passed to ChromeClients.
3186         https://bugs.webkit.org/show_bug.cgi?id=54926
3187
3188         Add a new private UIDelegate method, -webView:addMessageToConsole:withSource:,
3189         which supersedes -webView:addMessageToConsole if it exists. The new delegate
3190         does not filter to only JavaScript originated console messages. The old
3191         delegate is left around for clients that expect filtered messages, like
3192         DashCode and older versions of Safari.
3193
3194         The dictionary message passed to the delegate now includes more information
3195         about the message source, type, and level.
3196
3197         * WebCoreSupport/WebChromeClient.mm:
3198         (stringForMessageSource):
3199         (stringForMessageType):
3200         (stringForMessageLevel):
3201         (WebChromeClient::addMessageToConsole):
3202         * WebView/WebUIDelegatePrivate.h:
3203
3204 2011-03-01  Levi Weintraub  <leviw@chromium.org>
3205
3206         Reviewed by Ryosuke Niwa.
3207
3208         Stop instantiating legacy editing Positions in VisiblePosition
3209         https://bugs.webkit.org/show_bug.cgi?id=52919
3210
3211         Changing usage of legacy VisiblePosition constructor. Since we were dealing
3212         with positions from DOM Ranges, we're guaranteed a parent-anchored position.
3213
3214         * WebView/WebFrame.mm:
3215         (-[WebFrame _caretRectAtPosition:affinity:]):
3216         * WebView/WebFrameInternal.h:
3217         * WebView/WebTextCompletionController.mm:
3218         (-[WebTextCompletionController doCompletion]):
3219
3220 2011-03-01  Sam Weinig  <sam@webkit.org>
3221
3222         Reviewed by Timothy Hatcher.
3223
3224         WebKit2 needs to be made localizable
3225         https://bugs.webkit.org/show_bug.cgi?id=55483
3226
3227         * WebCoreSupport/WebPlatformStrategies.mm:
3228         Use WebCore's localizedString function instead of WebLocalizableStrings
3229         since WebCore is now responsible for localization.
3230
3231 2011-02-25 Steve Block <steveblock@google.com>
3232
3233         Reviewed by Jeremy Orlow.
3234
3235         Bridge.h should not include BridgeJSC.h
3236         https://bugs.webkit.org/show_bug.cgi?id=55212
3237
3238         Include BridgeJSC.h directly instead.
3239
3240         * Plugins/Hosted/ProxyInstance.h:
3241         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3242
3243 2011-02-28  Chang Shu  <cshu@webkit.org>
3244
3245         Reviewed by Ryosuke Niwa.
3246
3247         Remove the support of Frame::isContentEditable and its dependencies.
3248         https://bugs.webkit.org/show_bug.cgi?id=54292
3249
3250         Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
3251
3252         * WebCoreSupport/WebEditorClient.h:
3253         * WebCoreSupport/WebEditorClient.mm:
3254         * WebView/WebView.mm:
3255         (-[WebView setEditable:]):
3256         (-[WebView isEditable]):
3257         * WebView/WebViewData.h:
3258
3259 2011-02-28  Oliver Hunt  <oliver@apple.com>
3260
3261         Reviewed by Gavin Barraclough.
3262
3263         Make ScopeChainNode GC allocated
3264         https://bugs.webkit.org/show_bug.cgi?id=55283
3265
3266         More updates for the absence of the ScopeChain class
3267
3268         * WebView/WebScriptDebugDelegate.mm:
3269         (-[WebScriptCallFrame scopeChain]):
3270
3271 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
3272
3273         Reviewed by Pavel Feldman.
3274
3275         DumpRenderTree should reset frame opener between tests.
3276         https://bugs.webkit.org/show_bug.cgi?id=54874
3277
3278         Added clearOpener method to WebFramePrivate.
3279
3280         * WebView/WebFrame.mm:
3281         (-[WebFrame _clearOpener]):
3282         * WebView/WebFramePrivate.h:
3283
3284 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
3285
3286         Unreviewed, rolling out r79764.
3287         http://trac.webkit.org/changeset/79764
3288         https://bugs.webkit.org/show_bug.cgi?id=55295
3289
3290         "broke Chromium builds" (Requested by rniwa on #webkit).
3291
3292         * WebView/WebFrame.mm:
3293         * WebView/WebFramePrivate.h:
3294
3295 2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>
3296
3297         Reviewed by David Kilzer.
3298
3299         https://bugs.webkit.org/show_bug.cgi?id=48781
3300
3301         Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
3302
3303         Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
3304         should paint the default broken image when an image fails to load or decode.  The method also passes the
3305         URL of the failed image.
3306
3307         * WebCoreSupport/WebFrameLoaderClient.h:
3308         * WebCoreSupport/WebFrameLoaderClient.mm:
3309         (WebFrameLoaderClient::shouldPaintBrokenImage):
3310         * WebView/WebDelegateImplementationCaching.h:
3311         * WebView/WebDelegateImplementationCaching.mm: Added case for passing one object.
3312         (CallResourceLoadDelegateReturningBoolean):
3313         * WebView/WebResourceLoadDelegatePrivate.h:
3314         * WebView/WebView.mm:
3315         (-[WebView _cacheResourceLoadDelegateImplementations]):
3316
3317 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
3318
3319         Reviewed by Pavel Feldman.
3320
3321         DumpRenderTree should reset frame opener between tests.
3322         https://bugs.webkit.org/show_bug.cgi?id=54874
3323
3324         Added clearOpener method to WebFramePrivate.
3325
3326         * WebView/WebFrame.mm:
3327         (-[WebFrame _clearOpener]):
3328         * WebView/WebFramePrivate.h:
3329
3330 2011-02-25  Mark Rowe  <mrowe@apple.com>
3331
3332         <rdar://problem/8902546> Build fix.
3333
3334         * Misc/QuickDrawCompatibility.h:
3335
3336 2011-02-24  Anders Carlsson  <andersca@apple.com>
3337
3338         Fix clang build.
3339
3340         * WebCoreSupport/WebKeyGenerator.m:
3341         (toWebCertificateParseResult):
3342         (-[WebKeyGenerator addCertificatesToKeychainFromData:]):
3343         * WebView/WebTextCompletionController.mm:
3344
3345 2011-02-24  Peter Kasting  <pkasting@google.com>
3346
3347         Reviewed by Eric Seidel.
3348
3349         Drop the "U; " encryption level from the User Agent string.
3350         https://bugs.webkit.org/show_bug.cgi?id=54566
3351
3352         * WebView/WebView.mm:
3353         (+[WebView _standardUserAgentWithApplicationName:]):
3354
3355 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
3356
3357         Unreviewed, rolling out r79570.
3358         http://trac.webkit.org/changeset/79570
3359         https://bugs.webkit.org/show_bug.cgi?id=54874
3360
3361         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
3362         was not updated
3363
3364         * WebView/WebFrame.mm:
3365         * WebView/WebFramePrivate.h:
3366
3367 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
3368
3369         Reviewed by Alexey Proskuryakov.
3370
3371         DumpRenderTree should reset frame opener between tests.
3372         https://bugs.webkit.org/show_bug.cgi?id=54874
3373
3374         Added clearOpener method to WebFramePrivate.
3375
3376         * WebView/WebFrame.mm:
3377         (-[WebFrame _clearOpener]):
3378         * WebView/WebFramePrivate.h:
3379
3380 2011-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3381
3382         Reviewed by Alexey Proskuryakov.
3383
3384         Drop the language tag part from the User Agent string
3385         https://bugs.webkit.org/show_bug.cgi?id=54560
3386
3387         * WebView/WebView.mm:
3388         (+[WebView _standardUserAgentWithApplicationName:]): Drop the
3389         language tag part.
3390
3391 2011-02-22  Brady Eidson  <beidson@apple.com>
3392
3393         Reviewed by Anders Carlsson.
3394
3395         Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
3396         API to view and delete Application Cache data by origin.
3397
3398         * WebCoreSupport/WebApplicationCache.mm:
3399         (+[WebApplicationCache deleteAllApplicationCaches]): Move this implementation into WebCore itself.
3400
3401 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
3402
3403         Reviewed by Kent Tamura.
3404
3405         Rename Position::node() to Position::deprecatedNode()
3406         https://bugs.webkit.org/show_bug.cgi?id=54622
3407
3408         * WebView/WebFrame.mm:
3409         (-[WebFrame _smartDeleteRangeForProposedRange:]):
3410
3411 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
3412
3413         Reviewed by Kent Tamura.
3414
3415         Rename Position::node() to Position::deprecatedNode()
3416         https://bugs.webkit.org/show_bug.cgi?id=54622
3417         
3418         Done the rename.
3419
3420         * WebView/WebFrame.mm:
3421         (-[WebFrame _smartDeleteRangeForProposedRange:]): Since newStart and newEnd are parent-anchored,
3422         use containerNode() and offsetInContainerNode() instead of deprecated member functions.
3423
3424 2011-02-18  Gavin Barraclough  <barraclough@apple.com>
3425
3426         Reviewed by Sam Weinig.
3427
3428         Bug 54786 - Devirtualize JSCell::classInfo()
3429
3430         Instead of making a virtual function call, add a pointer to the ClassInfo
3431         onto Structure.
3432
3433         This removes a virtual function call, and paves the way towards removing all
3434         the createStructure methods, and StructureFlags/AnonymousSlotCount properties
3435         (these should be able to move onto ClassInfo).
3436
3437         Calls to Structure::create must now pass a pointer to the ClassInfo for the
3438         structure. All objects now have a ClassInfo pointer, non-object cell types
3439         still do not.
3440
3441         Changes are most mechanical, involving three steps:
3442             * Remove virtual classInfo() methods.
3443             * Add &s_info parameter to calls to Structure::create.
3444             * Rename ClassInfo static members on classes from 'info' to 's_info',
3445               for consistency.
3446
3447         * Plugins/Hosted/ProxyInstance.mm:
3448         (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
3449         (WebKit::ProxyRuntimeMethod::createStructure):
3450         * Plugins/Hosted/ProxyRuntimeObject.h:
3451         (WebKit::ProxyRuntimeObject::createStructure):
3452         * Plugins/Hosted/ProxyRuntimeObject.mm:
3453         (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
3454         * WebView/WebView.mm:
3455         (aeDescFromJSValue):
3456
3457 2011-02-19  Brian Ryner  <bryner@chromium.org>
3458
3459         Reviewed by Adam Barth.
3460
3461         Add missing #include of DocumentLoader.h, needed since the transitive
3462         include through Document.h is removed.
3463         https://bugs.webkit.org/show_bug.cgi?id=50489
3464
3465         * WebView/WebFrame.mm:
3466
3467 2011-02-19  Charlie Reis  <creis@chromium.org>
3468
3469         Reviewed by Mihai Parparita.
3470
3471         Ensure loading has stopped in HistoryController::goToItem
3472         https://bugs.webkit.org/show_bug.cgi?id=54517
3473
3474         Add a FrameLoaderClient callback for whether to stop loading before goToItem.
3475
3476         Test: http/tests/navigation/forward-to-fragment-fires-onload.html
3477
3478         * WebCoreSupport/WebFrameLoaderClient.mm:
3479         (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
3480         * WebCoreSupport/WebFrameLoaderClient.h:
3481
3482 2011-02-16  David Hyatt  <hyatt@apple.com>
3483
3484         Reviewed by Dan Bernstein.
3485
3486         https://bugs.webkit.org/show_bug.cgi?id=54244
3487         
3488         Convert the line box tree to floating point and eliminate font rounding hacks.  This patch removes all of the rounding
3489         hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
3490         
3491         The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
3492         been changed as well.
3493         
3494         In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
3495         
3496         Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
3497         
3498         Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
3499         still have a precise floating point position.
3500
3501         Justification will now allow subpixel positioning to occur as well.  Platforms that don't support subpixel positioning should already
3502         be rounding justification spacing in their font code.
3503
3504         Many layout test results change on Mac, since rounding hacks were used there and are now gone.
3505
3506         * Misc/WebKitNSStringExtras.mm:
3507         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
3508         (-[NSString _web_widthWithFont:]):
3509
3510 2011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
3511
3512         Reviewed by Adam Roben.
3513
3514         HTML5 <details> and <summary>: localized text
3515         https://bugs.webkit.org/show_bug.cgi?id=54260
3516
3517         The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
3518         provide the default label to be used by a <details> tag that has no <summary> child.
3519
3520         * WebCoreSupport/WebPlatformStrategies.h:
3521         * WebCoreSupport/WebPlatformStrategies.mm:
3522         (WebPlatformStrategies::defaultDetailsSummaryText):
3523
3524 2011-02-16  Matthew Delaney  <mdelaney@apple.com>
3525
3526         Reviewed by Simon Fraser.
3527
3528         Allow acceleratesDrawing for WebKit2
3529         https://bugs.webkit.org/show_bug.cgi?id=54511
3530
3531         Plumb through preference for accelerated drawing.
3532         
3533         * WebView/WebPreferenceKeysPrivate.h:
3534         * WebView/WebPreferences.mm:
3535         (+[WebPreferences initialize]):
3536         (-[WebPreferences acceleratedDrawingEnabled]):
3537         (-[WebPreferences setAcceleratedDrawingEnabled:]):
3538         * WebView/WebPreferencesPrivate.h:
3539
3540 2011-02-15  David Kilzer  <ddkilzer@apple.com>
3541
3542         <http://webkit.org/b/54505> Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h
3543
3544         Reviewed by Darin Adler.
3545
3546         * WebView/WebDynamicScrollBarsView.h:
3547         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Removed
3548         declaration.
3549         * WebView/WebDynamicScrollBarsView.mm:
3550         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Moved
3551         implementation into correct category.
3552         * WebView/WebDynamicScrollBarsViewInternal.h:
3553         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Added
3554         declaration.
3555         * WebView/WebHTMLView.mm: Included
3556         WebDynamicScrollBarsViewInternal.h instead of
3557         WebDynamicScrollBarsView.h.
3558
3559 2011-02-14  Oliver Hunt  <oliver@apple.com>
3560
3561         Reviewed by Gavin Barraclough and Geoff Garen.
3562
3563         Refactor handles and weak pointers to become nicer and more automatic
3564         https://bugs.webkit.org/show_bug.cgi?id=54415
3565
3566         Update to use Global<> instead of ProtectedPtr, and refactored slightly
3567         to get global data to places it's needed for when we're assigning to
3568         Global<>s
3569
3570         * ForwardingHeaders/collector/handles/Global.h: Added.
3571         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3572         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3573         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get):
3574         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
3575         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
3576         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3577         (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
3578         (WebKit::NetscapePluginInstanceProxy::evaluate):
3579         (WebKit::NetscapePluginInstanceProxy::invoke):
3580         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3581         (WebKit::NetscapePluginInstanceProxy::construct):
3582         (WebKit::NetscapePluginInstanceProxy::addValueToArray):
3583         * WebView/WebScriptDebugger.h:
3584         * WebView/WebScriptDebugger.mm:
3585         (WebScriptDebugger::WebScriptDebugger):
3586
3587 2011-02-15  Jia Pu  <jpu@apple.com>
3588
3589         Reviewed by Darin Adler.
3590
3591         Autocorrection should respect undo.
3592         https://bugs.webkit.org/show_bug.cgi?id=52221
3593         <rdar://problem/8663399>
3594
3595         Please see WebCore/ChangeLog for detailed description.
3596
3597         * WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
3598
3599         * WebCoreSupport/WebEditorClient.mm:
3600         (WebEditorClient::recordAutocorrectionResponse): Ditto.
3601
3602         * WebView/WebFrame.mm:
3603         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
3604              Adopted new signature of ReplaceSelectionCommand::create().
3605
3606 2011-02-15  David Kilzer  <ddkilzer@apple.com>
3607
3608         <http://webkit.org/b/54485> Fix spelling of -inProgramaticScroll
3609
3610         Reviewed by Darin Adler.
3611
3612         * WebView/WebDynamicScrollBarsView.h:
3613         * WebView/WebDynamicScrollBarsView.mm:
3614         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from
3615         -inProgramaticScroll.
3616         * WebView/WebHTMLView.mm:
3617         (-[WebHTMLView _frameOrBoundsChanged]): Corrected method name.
3618
3619 2011-02-15  Kenneth Russell  <kbr@google.com>
3620
3621         Reviewed by Darin Fisher.
3622
3623         Allow controlling minimum DOMTimer interval on a per-page basis
3624         https://bugs.webkit.org/show_bug.cgi?id=54312
3625
3626         Added needed methods to implement LayoutTestController's new
3627         setMinimumTimerInterval method.
3628
3629         * WebView/WebView.mm:
3630         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
3631         (+[WebView _defaultMinimumTimerInterval]):
3632         (-[WebView _setMinimumTimerInterval:]):
3633         * WebView/WebViewPrivate.h:
3634
3635 2011-02-11  Geoffrey Garen  <ggaren@apple.com>
3636
3637         Reviewed by Oliver Hunt.
3638
3639         A little more encapsulation for the heap: Removed CollectorHeapIterator
3640         https://bugs.webkit.org/show_bug.cgi?id=54298
3641
3642         * Misc/WebCoreStatistics.mm:
3643         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
3644         (+[WebCoreStatistics javaScriptObjectTypeCounts]): Updated for new typedef.
3645
3646 2011-02-10  Nate Chapin  <japhet@chromium.org>
3647
3648         Reviewed by Adam Barth.
3649
3650         Update calls to DocumentWriter.
3651         https://bugs.webkit.org/show_bug.cgi?id=50489
3652
3653         * WebView/WebFrame.mm:
3654         (-[WebFrame _canProvideDocumentSource]):
3655
3656 2011-02-10  Chris Fleizach  <cfleizach@apple.com>
3657
3658         Reviewed by Anders Carlsson.
3659
3660         AX: AX needs to stop using WebCoreViewFactory
3661         https://bugs.webkit.org/show_bug.cgi?id=54153
3662
3663         * WebCoreSupport/WebSystemInterface.mm:
3664         (InitWebCoreSystemInterface):
3665
3666 2011-02-10  Peter Varga  <pvarga@webkit.org>
3667
3668         Reviewed by Csaba Osztrogonác.
3669
3670         Remove PCRE source from trunk
3671         https://bugs.webkit.org/show_bug.cgi?id=54188
3672
3673         * ForwardingHeaders/pcre/pcre.h: Removed.
3674
3675 2011-02-09  Pavel Feldman  <pfeldman@chromium.org>
3676
3677         Reviewed by Yury Semikhatsky.
3678
3679         Web Inspector: follow up on InspectorAgent split -
3680         removing unnecessary methods from InspectorController.
3681         https://bugs.webkit.org/show_bug.cgi?id=54093
3682
3683         * WebInspector/WebInspector.mm:
3684         (-[WebInspector showConsole:]):
3685         (-[WebInspector stopProfilingJavaScript:]):
3686
3687 2011-02-08  Dan Bernstein  <mitz@apple.com>
3688
3689         Reviewed by Jon Honeycutt and Maciej Stachowiak.
3690
3691         <rdar://problem/8959420> Find in Mail no longer cycles around
3692
3693         * WebView/WebHTMLView.mm:
3694         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Set
3695         the wrap option according to the flag.
3696
3697 2011-02-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3698
3699         Unreviewed, rolling out r77980.
3700         http://trac.webkit.org/changeset/77980
3701         https://bugs.webkit.org/show_bug.cgi?id=54043
3702
3703         "Crashes on Windows and Linux..." (Requested by leviw on
3704         #webkit).
3705
3706         * WebView/WebFrame.mm:
3707         (-[WebFrame _caretRectAtNode:offset:affinity:]):
3708         * WebView/WebFrameInternal.h:
3709         * WebView/WebTextCompletionController.mm:
3710         (-[WebTextCompletionController doCompletion]):
3711
3712 2011-02-08  Levi Weintraub  <leviw@chromium.org>
3713
3714         Reviewed by Ryosuke Niwa.
3715
3716         Stop instantiating legacy editing Positions in VisiblePosition
3717         https://bugs.webkit.org/show_bug.cgi?id=52919
3718
3719         Changing usage of legacy VisiblePosition constructor. Since we were dealing
3720         with positions from DOM Ranges, we're guaranteed a parent-anchored position.
3721
3722         * WebView/WebFrame.mm:
3723         (-[WebFrame _caretRectAtPosition:affinity:]):
3724         * WebView/WebFrameInternal.h:
3725         * WebView/WebTextCompletionController.mm:
3726         (-[WebTextCompletionController doCompletion]):
3727
3728 2011-02-08  Adam Barth  <abarth@webkit.org>
3729
3730         Reviewed by Eric Seidel.
3731
3732         Remove orphan code from old parser
3733         https://bugs.webkit.org/show_bug.cgi?id=53984
3734
3735         * WebCoreSupport/WebChromeClient.h:
3736
3737 2011-02-02  Ilya Tikhonovsky  <loislo@chromium.org>
3738
3739         Reviewed by Yury Semikhatsky.
3740
3741         Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
3742
3743         https://bugs.webkit.org/show_bug.cgi?id=53169
3744
3745         Minor change enforced by major changes in WebCore/inspector/InspectorController.
3746
3747         * WebInspector/WebInspector.mm:
3748         (-[WebInspector isTimelineProfilingEnabled]):
3749
3750 2011-02-07  Enrica Casucci  <enrica@apple.com>
3751
3752         Reviewed Adam Roben and Darin Adler.
3753
3754         WebKit2: drag and drop support on Windows.
3755         https://bugs.webkit.org/show_bug.cgi?id=52775
3756
3757         Removed createDragImageForLink from DragClient.
3758
3759         * WebCoreSupport/WebDragClient.h:
3760         * WebCoreSupport/WebDragClient.mm:
3761         (WebDragClient::startDrag):
3762
3763 2011-02-03  Yury Semikhatsky  <yurys@chromium.org>
3764
3765         Reviewed by Pavel Feldman.
3766
3767         Web Inspector: remove settings related methods from InspectorClient
3768         https://bugs.webkit.org/show_bug.cgi?id=53686
3769
3770         * WebCoreSupport/WebInspectorClient.h:
3771         * WebCoreSupport/WebInspectorClient.mm:
3772         (WebInspectorClient::openInspectorFrontend):
3773         (WebInspectorFrontendClient::WebInspectorFrontendClient):
3774
3775 2011-02-03  James Kozianski  <koz@chromium.org>
3776
3777         Reviewed by Dimitri Glazkov.
3778
3779         Add navigator.registerProtocolHandler behind a flag.
3780         https://bugs.webkit.org/show_bug.cgi?id=52609
3781
3782         * Configurations/FeatureDefines.xcconfig:
3783
3784 2011-02-03  Adam Langley  <agl@chromium.org>
3785
3786         Reviewed by Adam Barth.
3787
3788         Plumb mixed script URL to FrameLoaderClient
3789         https://bugs.webkit.org/show_bug.cgi?id=52384
3790
3791         Regressions covered by http/tests/security/mixedContent/*
3792
3793         * WebCoreSupport/WebFrameLoaderClient.h:
3794         * WebCoreSupport/WebFrameLoaderClient.mm:
3795         (WebFrameLoaderClient::didRunInsecureContent):
3796
3797 2011-02-03  Beth Dakin  <bdakin@apple.com>
3798
3799         Reviewed by Sam Weinig.
3800
3801         Fix for <rdar://problem/8944544> Ability to animate track
3802         for WKPainter scrollers
3803
3804         * WebCoreSupport/WebSystemInterface.mm:
3805         (InitWebCoreSystemInterface):
3806
3807 2011-02-02  Mark Rowe  <mrowe@apple.com>
3808
3809         Reviewed by Beth Dakin.
3810
3811         <rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement::createImageBuffer().
3812
3813         * WebCoreSupport/WebSystemInterface.mm:
3814         (InitWebCoreSystemInterface): Add some missing initializers.
3815
3816 2011-02-02  Steve Lacey  <sjl@chromium.org>
3817
3818         Reviewed by Eric Carlson.
3819
3820         Implement basic media statistics on media elements.
3821         https://bugs.webkit.org/show_bug.cgi?id=53322
3822
3823         * Configurations/FeatureDefines.xcconfig:
3824
3825 2011-02-01  Sam Weinig  <sam@webkit.org>
3826
3827         Reviewed by Beth Dakin.
3828
3829         Part 2 for <rdar://problem/8492788>
3830         Adopt WKScrollbarPainterController
3831
3832         Use header detection to define scrollbar painting controller #define.
3833
3834         * WebCoreSupport/WebSystemInterface.mm:
3835         (InitWebCoreSystemInterface):
3836
3837 2011-02-01  David Hyatt  <hyatt@apple.com>
3838
3839         Reviewed by Oliver Hunt.
3840
3841         https://bugs.webkit.org/show_bug.cgi?id=53520
3842         
3843         Remove the physical terminology from IntRect and FloatRect.
3844         
3845         Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
3846         we need to update our terminology to be more accurate.
3847
3848         I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
3849         renaming right() and bottom() to maxX() and maxY().  These terms remain accurate
3850         even for flipped rectangles.
3851
3852         * WebView/WebHTMLView.mm:
3853         (setNeedsDisplayInRect):
3854
3855 2011-02-01  Beth Dakin  <bdakin@apple.com>
3856
3857         Reviewed by Sam Weinig.
3858
3859         Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController
3860
3861         * WebCoreSupport/WebSystemInterface.mm:
3862         (InitWebCoreSystemInterface):
3863
3864 2011-02-01  Dave Hyatt  <hyatt@apple.com>
3865
3866         Reviewed by Darin Adler.
3867
3868         https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work
3869         with vertical text.
3870
3871         Change printing functions to check writing-mode and properly swap width and height
3872         as needed.
3873
3874         * WebView/WebDynamicScrollBarsView.mm:
3875         (-[WebDynamicScrollBarsView setScrollOrigin:updatePositionAtAll:immediately:]):
3876         * WebView/WebFrame.mm:
3877         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
3878         * WebView/WebFrameInternal.h:
3879         * WebView/WebHTMLView.mm:
3880         (-[WebHTMLView _web_setPrintingModeRecursive]):
3881         (-[WebHTMLView _web_clearPrintingModeRecursive]):
3882         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
3883         (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]):
3884         (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
3885         (-[WebHTMLView _endPrintMode]):
3886         (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
3887         (-[WebHTMLView _endScreenPaginationMode]):
3888         (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
3889         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumPageLogicalWidth:adjustViewSize:paginateScreenContent:]):
3890         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
3891         (-[WebHTMLView _scaleFactorForPrintOperation:]):
3892         (-[WebHTMLView setPageWidthForPrinting:]):
3893         (-[WebHTMLView knowsPageRange:]):
3894
3895 2011-01-31  Oliver Hunt  <oliver@apple.com>
3896
3897         Convert markstack to a slot visitor API
3898         https://bugs.webkit.org/show_bug.cgi?id=53219
3899
3900         rolling r77098, r77099, r77100, r77109, and
3901         r77111 back in, along with a few more Qt fix attempts.
3902
3903         * WebView/WebScriptDebugDelegate.mm:
3904         (-[WebScriptCallFrame scopeChain]):
3905
3906 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
3907
3908         Unreviewed, rolling out r77098, r77099, r77100, r77109, and
3909         r77111.
3910         http://trac.webkit.org/changeset/77098
3911         http://trac.webkit.org/changeset/77099
3912         http://trac.webkit.org/changeset/77100
3913         http://trac.webkit.org/changeset/77109
3914         http://trac.webkit.org/changeset/77111
3915         https://bugs.webkit.org/show_bug.cgi?id=53219
3916
3917         Qt build is broken
3918
3919         * WebView/WebScriptDebugDelegate.mm:
3920         (-[WebScriptCallFrame scopeChain]):
3921
3922 2011-01-30  Oliver Hunt  <oliver@apple.com>
3923
3924         Convert markstack to a slot visitor API
3925         https://bugs.webkit.org/show_bug.cgi?id=53219
3926
3927         rolling r77006 and r77020 back in.
3928
3929         * WebView/WebScriptDebugDelegate.mm:
3930         (-[WebScriptCallFrame scopeChain]):
3931
3932 2011-01-28  Geoffrey Garen  <ggaren@apple.com>
3933
3934         Reviewed by Maciej Stachowiak.
3935
3936         Some more Heap cleanup.
3937         https://bugs.webkit.org/show_bug.cgi?id=53357
3938
3939         Updated for JavaScriptCore changes.
3940
3941         * Misc/WebCoreStatistics.mm:
3942         (+[WebCoreStatistics memoryStatistics]):
3943
3944 2011-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
3945
3946         Unreviewed, rolling out r77006 and r77020.
3947         http://trac.webkit.org/changeset/77006
3948         http://trac.webkit.org/changeset/77020
3949         https://bugs.webkit.org/show_bug.cgi?id=53360
3950
3951         "Broke Windows tests" (Requested by rniwa on #webkit).
3952
3953         * WebView/WebScriptDebugDelegate.mm:
3954         (-[WebScriptCallFrame scopeChain]):
3955
3956 2011-01-27  Oliver Hunt  <oliver@apple.com>
3957
3958         Reviewed by Geoffrey Garen.
3959
3960         Convert markstack to a slot visitor API
3961         https://bugs.webkit.org/show_bug.cgi?id=53219
3962
3963         Update to new marking api
3964
3965         * WebView/WebScriptDebugDelegate.mm:
3966         (-[WebScriptCallFrame scopeChain]):
3967
3968 2011-01-28  Dan Bernstein  <mitz@apple.com>
3969
3970         Reviewed by Sam Weinig.
3971
3972         <select> can't display right-to-left (rtl) languages
3973         https://bugs.webkit.org/show_bug.cgi?id=19785
3974
3975         * WebCoreSupport/WebChromeClient.h:
3976         * WebCoreSupport/WebChromeClient.mm:
3977         (WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
3978         (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. Returns true.
3979
3980 2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3981
3982         Unreviewed, rolling out r76891.
3983         http://trac.webkit.org/changeset/76891
3984         https://bugs.webkit.org/show_bug.cgi?id=53280
3985
3986         Makes every layout test crash (Requested by othermaciej on
3987         #webkit).
3988
3989         * Misc/WebIconDatabase.mm:
3990         (-[ThreadEnabler threadEnablingSelector:]):
3991         (importToWebCoreFormat):
3992
3993 2011-01-27  Nate Chapin  <japhet@chromium.org>
3994
3995         Reviewed by Adam Barth.
3996
3997         Use Document::url() instead of FrameLoader::url().
3998         https://bugs.webkit.org/show_bug.cgi?id=41165
3999
4000         * WebView/WebView.mm:
4001         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
4002
4003 2011-01-27  Dan Bernstein  <mitz@apple.com>
4004
4005         Rubber-stamped by Anders Carlsson.
4006
4007         Reverted an accidental change in r76561.
4008
4009         * WebView/WebHTMLView.mm:
4010
4011 2011-01-26  David Kilzer  <ddkilzer@apple.com>
4012
4013         <http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork
4014         <rdar://problem/8821760>
4015
4016         Reviewed by Antti Koivisto.
4017
4018         * WebCoreSupport/WebSystemInterface.mm:
4019         (InitWebCoreSystemInterface): Added initialization for
4020         GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.
4021
4022 2011-01-26  Beth Dakin  <bdakin@apple.com>
4023
4024         Reviewed by Darin Adler.
4025
4026         Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics 
4027         when using WKScrollbars.
4028
4029         * WebCoreSupport/WebSystemInterface.mm:
4030         (InitWebCoreSystemInterface):
4031
4032 2011-01-25  Darin Adler  <darin@apple.com>
4033
4034         Reviewed by Anders Carlsson.
4035
4036         WebKit is using CSBackupSetItemExcluded incorrectly
4037         https://bugs.webkit.org/show_bug.cgi?id=53095
4038         rdar://problem/8790540
4039
4040         * Misc/WebIconDatabase.mm:
4041         (importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded.
4042         It was incorrect, and this responsibility has been moved to WebCore.
4043
4044 2011-01-24  Chris Marrin  <cmarrin@apple.com>
4045
4046         Reviewed by Eric Seidel.
4047
4048         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
4049         https://bugs.webkit.org/show_bug.cgi?id=53041
4050
4051         * Configurations/FeatureDefines.xcconfig:
4052
4053 2011-01-25  Yury Semikhatsky  <yurys@chromium.org>
4054
4055         Reviewed by Pavel Feldman.
4056
4057         Web Inspector: remove "attached" state related methods from InspectorAgent
4058         https://bugs.webkit.org/show_bug.cgi?id=53086
4059
4060         * WebCoreSupport/WebInspectorClient.h:
4061         * WebCoreSupport/WebInspectorClient.mm:
4062         (-[WebInspectorWindowController showWindow:]):
4063         (-[WebInspectorWindowController attach]):
4064         (-[WebInspectorWindowController detach]):
4065
4066 2011-01-23  Dan Bernstein  <mitz@apple.com>
4067
4068         Reviewed by John Sullivan.
4069
4070         <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter
4071
4072         * WebCoreSupport/WebChromeClient.mm:
4073         (WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.
4074
4075 2011-01-22  Alexey Proskuryakov  <ap@apple.com>
4076
4077         Reviewed by Darin Adler.
4078
4079         https://bugs.webkit.org/show_bug.cgi?id=52473
4080         Auto-scaling to avoid orphans is broken, remove dysfunctional code
4081
4082         * WebView/WebHTMLView.mm:
4083         (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
4084         (-[WebHTMLView _scaleFactorForPrintOperation:]):
4085         (-[WebHTMLView knowsPageRange:]):
4086
4087 2011-01-21  Mark Rowe  <mrowe@apple.com>
4088
4089         Rubber-stamped by Jon Honeycutt.
4090
4091         Fix the build when using Clang by removing some unused variables.
4092
4093         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
4094         (-[WebHostedNetscapePluginView updateAndSetWindow]):
4095         * WebView/WebFullScreenController.mm:
4096         (-[WebFullScreenController enterFullscreen:]):
4097         (-[WebFullScreenController exitFullscreen]):
4098
4099 2011-01-21  Chris Rogers  <crogers@google.com>
4100
4101         Reviewed by Darin Fisher.
4102
4103         Add run-time enable support for the web audio API
4104         https://bugs.webkit.org/show_bug.cgi?id=52741
4105
4106         * WebView/WebPreferenceKeysPrivate.h:
4107         * WebView/WebPreferences.mm:
4108         (-[WebPreferences webAudioEnabled]):
4109         (-[WebPreferences setWebAudioEnabled:]):
4110         * WebView/WebPreferencesPrivate.h:
4111         * WebView/WebView.mm:
4112         (-[WebView _preferencesChangedNotification:]):
4113
4114 2011-01-20  John Sullivan  <sullivan@apple.com>
4115
4116         Reviewed by Mark Rowe.
4117
4118         Shift-tab doesn't cycle through fields in http authentication panel
4119         https://bugs.webkit.org/show_bug.cgi?id=52850
4120
4121         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
4122         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
4123         Re-wired the key loop so that there aren't two views with the same nextKeyView.
4124
4125 2011-01-20  Beth Dakin  <bdakin@apple.com>
4126
4127         Reviewed by Geoffrey Garen.
4128
4129         Fix for <rdar://problem/8890255>
4130
4131         Allow WebKitSystemInterface to draw scrollbars 
4132         when appropriate.
4133         * WebCoreSupport/WebSystemInterface.mm:
4134         (InitWebCoreSystemInterface):
4135
4136 2011-01-19  Simon Fraser  <simon.fraser@apple.com>
4137
4138         Reviewed by Sam Weinig.
4139
4140         GraphicsLayers in subframes can get sync'd multiple times
4141         https://bugs.webkit.org/show_bug.cgi?id=52489
4142
4143         * WebView/WebView.mm:
4144         (-[WebView _syncCompositingChanges]): syncCompositingStateRecursive()
4145         was renamed to syncCompositingStateIncludingSubframes().
4146
4147 2011-01-19  Darin Adler  <darin@apple.com>
4148
4149         Reviewed by Sam Weinig.
4150
4151         Would like script debugging protocol method to differentiate between caught and uncaught exceptions
4152         https://bugs.webkit.org/show_bug.cgi?id=52104
4153         rdar://problem/8704226
4154
4155         * WebView/WebDelegateImplementationCaching.h:
4156         Fix type of second integer in CallScriptDebugDelegate function overload
4157         to be int to match the actual Objective-C method. Added a new overload
4158         that includes a BOOL in the right place. Added a boolean named
4159         exceptionWasRaisedExpectsHasHandlerFlag.
4160
4161         * WebView/WebDelegateImplementationCaching.mm:
4162         (CallDelegate): Added overloads as above.
4163         (CallScriptDebugDelegate): Ditto.
4164
4165         * WebView/WebScriptDebugDelegate.h: Added new method with the additional
4166         boolean argument. Marked the old method informally deprecated.
4167
4168         * WebView/WebScriptDebugger.mm:
4169         (WebScriptDebugger::exception): Added code to call with or without the
4170         boolean depending on exceptionWasRaisedExpectsHasHandlerFlag.
4171
4172         * WebView/WebView.mm:
4173         (-[WebView _cacheScriptDebugDelegateImplementations]): Set up the
4174         exceptionWasRaisedExpectsHasHandlerFlag. Also fixed old code that was not
4175         guaranteed to set didParseSourceExpectsBaseLineNumber to NO.
4176
4177 2011-01-19  Tony Gentilcore  <tonyg@chromium.org>
4178
4179         Reviewed by Mihai Parparita.
4180
4181         Perform some forward declaration
4182         https://bugs.webkit.org/show_bug.cgi?id=52522
4183
4184         * Misc/WebKitNSStringExtras.mm:
4185
4186 2011-01-19  Pavel Podivilov  <podivilov@chromium.org>
4187
4188         Reviewed by Yury Semikhatsky.
4189
4190         Web Inspector: [JSC] scripts have incorrect starting line (always 1).
4191         https://bugs.webkit.org/show_bug.cgi?id=52721
4192
4193         * WebView/WebScriptDebugger.h:
4194         * WebView/WebScriptDebugger.mm:
4195         (toNSString):
4196         (WebScriptDebugger::sourceParsed):
4197
4198 2011-01-19  Levi Weintraub  <leviw@google.com>
4199
4200         Reviewed by Ryosuke Niwa.
4201
4202         Updating to use Position::parentAnchoredEquivalent instead of
4203         the old htmlediting rangeCompliantEquivalent.
4204
4205        &nbs