Make it easy to test enabling formal delegate protocols
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2015-01-26  Anders Carlsson  <andersca@apple.com>
2
3         Make it easy to test enabling formal delegate protocols
4         https://bugs.webkit.org/show_bug.cgi?id=140892
5
6         Reviewed by Dan Bernstein.
7
8         Add an WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS define that controls whether delegates should be formal protocols.
9
10         * Misc/WebDownload.h:
11         * WebView/WebFrameLoadDelegate.h:
12         * WebView/WebPolicyDelegate.h:
13         * WebView/WebResourceLoadDelegate.h:
14         * WebView/WebUIDelegate.h:
15         * WebView/WebView.h:
16
17 2015-01-26  Chris Dumez  <cdumez@apple.com>
18
19         Rename Document::body() to Document::bodyOrFrameset() for clarity
20         https://bugs.webkit.org/show_bug.cgi?id=140902
21
22         Reviewed by Andreas Kling.
23
24         Rename Document::body() to Document::bodyOrFrameset() for clarity. This
25         method does not necessarily return an HTMLBodyElement, it can also
26         return a frameset as per the specification:
27         http://www.w3.org/TR/html5/dom.html#dom-tree-accessors
28
29         This method is often misused internally (the caller is only interested
30         in the <body> element). I will fix these instances in a follow-up patch,
31         this patch is only renaming mechanically.
32
33 2015-01-26  Chris Dumez  <cdumez@apple.com>
34
35         First argument to DOM traversal functions should be a reference
36         https://bugs.webkit.org/show_bug.cgi?id=140895
37
38         Reviewed by Antti Koivisto.
39
40         First argument to DOM traversal functions should be a reference instead
41         of a pointer as it is dereferenced without null-check.
42
43 2015-01-26  Myles C. Maxfield  <mmaxfield@apple.com>
44
45         [iOS] [SVG -> OTF Converter] Flip the switch off on iOS
46         https://bugs.webkit.org/show_bug.cgi?id=140860
47
48         Reviewed by Darin Adler.
49
50         The fonts it makes are grotesque. (See what I did there? Typographic
51         humor is the best humor.)
52
53         * Configurations/FeatureDefines.xcconfig:
54
55 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
56
57         QLPreviewMenuItem popovers don't close when the page scrolls
58         https://bugs.webkit.org/show_bug.cgi?id=140806
59         <rdar://problem/19555618>
60
61         Reviewed by Beth Dakin.
62
63         Now that QLPreviewMenuItem's popover doesn't eat scrolls, we need to dismiss it if the page scrolls.
64
65         * WebView/WebHTMLView.mm:
66         (-[WebHTMLView scrollWheel:scrollWheel:]):
67         Send scrollWheel along to WebImmediateActionController.
68
69         * WebView/WebImmediateActionController.h:
70         * WebView/WebImmediateActionController.mm:
71         (-[WebImmediateActionController webView:didHandleScrollWheel:]):
72         (-[WebImmediateActionController _clearImmediateActionState]):
73         (-[WebImmediateActionController _defaultAnimationController]):
74         Keep track of the active QLPreviewMenuItem, and close it upon scroll.
75
76 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
77
78         Infinite recursion in _clearImmediateActionState
79         https://bugs.webkit.org/show_bug.cgi?id=140807
80         <rdar://problem/19571601>
81
82         Reviewed by Anders Carlsson.
83
84         * WebView/WebImmediateActionController.mm:
85         (-[WebImmediateActionController _clearImmediateActionState]):
86         Use this opportunity to bring identical code to WebKit1, to avoid
87         getting DataDetectors stuck when an immediate action is canceled.
88
89 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
90
91         Add a build flag for ES6 class syntax
92         https://bugs.webkit.org/show_bug.cgi?id=140760
93
94         Reviewed by Michael Saboff.
95
96         * Configurations/FeatureDefines.xcconfig:
97
98 2015-01-22  Beth Dakin  <bdakin@apple.com>
99
100         ibtoold crash below -[WebView close]
101         https://bugs.webkit.org/show_bug.cgi?id=140782
102         -and corresponding-
103         rdar://problem/19558472
104
105         Reviewed by Tim Horton.
106
107         Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but 
108         it is because interface builder is messing with our views.
109         * WebView/WebImmediateActionController.h:
110         * WebView/WebImmediateActionController.mm:
111         (-[WebImmediateActionController webViewClosed]):
112         (-[WebImmediateActionController _cancelImmediateAction]):
113         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
114         (-[WebImmediateActionController _updateImmediateActionItem]):
115
116 2015-01-21  Beth Dakin  <bdakin@apple.com>
117
118         Crash in QuickLook preview delegate method
119         https://bugs.webkit.org/show_bug.cgi?id=140740
120         -and corresponding-
121         rdar://problem/19540806
122
123         Reviewed by Tim Horton.
124
125         Clear out the delegate.
126         * WebView/WebImmediateActionController.mm:
127         (-[WebImmediateActionController webViewClosed]):
128
129 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
130
131         Remove ENABLE(INSPECTOR) ifdef guards
132         https://bugs.webkit.org/show_bug.cgi?id=140668
133
134         Reviewed by Darin Adler.
135
136         * Configurations/FeatureDefines.xcconfig:
137         * WebCoreSupport/WebFrameLoaderClient.mm:
138         (WebFrameLoaderClient::dispatchWillSendRequest):
139
140 2015-01-20  Anders Carlsson  <andersca@apple.com>
141
142         Remove USE(GLIB) code from WebKit1
143         https://bugs.webkit.org/show_bug.cgi?id=140714
144
145         Reviewed by Andreas Kling.
146
147         * WebView/WebView.mm:
148         (-[WebView _commonInitializationWithFrameName:groupName:]):
149         (-[WebView _close]):
150         (-[WebView _clearGlibLoopObserver]): Deleted.
151         (glibContextIterationCallback): Deleted.
152         (-[WebView _scheduleGlibContextIterations]): Deleted.
153         * WebView/WebViewData.h:
154         * WebView/WebViewInternal.h:
155
156 2015-01-20  David Kilzer  <ddkilzer@apple.com>
157
158         Switch to comparing PLATFORM_NAME in terms of macosx
159         <http://webkit.org/b/139516>
160
161         Reviewed by Timothy Hatcher.
162
163         * MigrateHeaders.make:
164         * postprocess-headers.sh:
165
166 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
167
168         [SVG -> OTF Converter] Flip the switch on
169         https://bugs.webkit.org/show_bug.cgi?id=140592
170
171         Reviewed by Antti Koivisto.
172
173         * Configurations/FeatureDefines.xcconfig:
174
175 2015-01-19  Beth Dakin  <bdakin@apple.com>
176
177         Speculative build fix.
178
179         * WebView/WebView.mm:
180         (-[WebView _commonInitializationWithFrameName:groupName:]):
181
182 2015-01-19  Beth Dakin  <bdakin@apple.com>
183
184         Speculative build fix.
185
186         * WebView/WebView.mm:
187         (-[WebView _convertRectFromRootView:]):
188
189 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
190
191         Adjust naming of action menu SPI
192         https://bugs.webkit.org/show_bug.cgi?id=140644
193         <rdar://problem/19448129>
194
195         Reviewed by Brian Weinstein.
196
197         * WebView/WebActionMenuController.mm:
198         (-[WebActionMenuController prepareForMenu:withEvent:]):
199         (-[WebActionMenuController willOpenMenu:withEvent:]):
200         (-[WebActionMenuController didCloseMenu:withEvent:]):
201         * WebView/WebView.mm:
202         (-[WebView _commonInitializationWithFrameName:groupName:]):
203         (-[WebView prepareForMenu:withEvent:]):
204         (-[WebView willOpenMenu:withEvent:]):
205         (-[WebView didCloseMenu:withEvent:]):
206
207 2015-01-19  Beth Dakin  <bdakin@apple.com>
208
209         REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is 
210         offset by flipped-ness
211         https://bugs.webkit.org/show_bug.cgi?id=140643
212         -and corresponding-
213         rdar://problem/19489593
214
215         Reviewed by Tim Horton.
216
217         We universally flipped because we assumed that the root view was flipped and the 
218         WebView was not. However, in Dictionary, the WebView is flipped! So this patch 
219         fixes that assumption by checking the WebView’s flipped-ness.
220         * WebView/WebView.mm:
221         (-[WebView _convertRectFromRootView:]):
222
223 2015-01-19  Commit Queue  <commit-queue@webkit.org>
224
225         Unreviewed, rolling out r178653.
226         https://bugs.webkit.org/show_bug.cgi?id=140634
227
228         Broke multiple SVG tests on Mountain Lion (Requested by ap on
229         #webkit).
230
231         Reverted changeset:
232
233         "[SVG -> OTF Converter] Flip the switch on"
234         https://bugs.webkit.org/show_bug.cgi?id=140592
235         http://trac.webkit.org/changeset/178653
236
237 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
238
239         [SVG -> OTF Converter] Flip the switch on
240         https://bugs.webkit.org/show_bug.cgi?id=140592
241
242         Reviewed by Antti Koivisto.
243
244         * Configurations/FeatureDefines.xcconfig:
245
246 2015-01-18  Daniel Bates  <dabates@apple.com>
247
248         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/178631>
249         (https://bugs.webkit.org/show_bug.cgi?id=129441)
250
251         Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight().
252         Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.
253
254         * WebInspector/WebNodeHighlightView.mm:
255         (-[WebNodeHighlightView layoutSublayers:]):
256
257 2015-01-16  Beth Dakin  <bdakin@apple.com>
258
259         Make sure early cancellation of immediate action actually does that in WK1
260         https://bugs.webkit.org/show_bug.cgi?id=140566
261         -and corresponding-
262         rdar://problem/19490114
263
264         Reviewed by Tim Horton.
265
266         Work around an AppKit bug by dispatching the call to _cancelImmediateAction 
267         asynchronously.
268         * WebView/WebImmediateActionController.mm:
269         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
270
271 2015-01-16  Daniel Bates  <dabates@apple.com>
272
273         Fix the public iOS SDK build after <http://trac.webkit.org/changeset/178285>
274         (https://bugs.webkit.org/show_bug.cgi?id=140360)
275
276         Forward declare protocol NSURLDownloadDelegate as it is SPI on iOS.
277
278         * Misc/WebDownload.h:
279
280 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
281
282         Remove ENABLE(SQL_DATABASE) guards
283         https://bugs.webkit.org/show_bug.cgi?id=140434
284
285         Reviewed by Darin Adler.
286
287         * Configurations/FeatureDefines.xcconfig:
288         * Storage/WebDatabaseManager.mm:
289         (databasesDirectoryPath):
290         * Storage/WebDatabaseManagerClient.h:
291         * Storage/WebDatabaseManagerClient.mm:
292         * Storage/WebDatabaseManagerInternal.h:
293         * Storage/WebDatabaseManagerPrivate.h:
294         * Storage/WebDatabaseQuotaManager.mm:
295         (-[WebDatabaseQuotaManager usage]):
296         (-[WebDatabaseQuotaManager quota]):
297         (-[WebDatabaseQuotaManager setQuota:]):
298         * WebCoreSupport/WebChromeClient.h:
299         * WebCoreSupport/WebChromeClient.mm:
300         * WebCoreSupport/WebSecurityOrigin.mm:
301         (-[WebSecurityOrigin usage]):
302         (-[WebSecurityOrigin quota]):
303         (-[WebSecurityOrigin setQuota:]):
304         * WebView/WebFrame.mm:
305         (-[WebFrame _cacheabilityDictionary]):
306         * WebView/WebView.mm:
307         (-[WebView _commonInitializationWithFrameName:groupName:]):
308         (-[WebView _preferencesChanged:]):
309
310 2015-01-14  Chris Dumez  <cdumez@apple.com>
311
312         Make 'TypeName' parameter unnecessary in CSSPropertyNames.in
313         https://bugs.webkit.org/show_bug.cgi?id=140347
314
315         Reviewed by Darin Adler.
316
317         Call FontDescription::setIsItalic() instead of setItalic() as the
318         call site passes a boolean.
319
320         * WebView/WebHTMLView.mm:
321         (fontNameForDescription):
322
323 2015-01-13  Anders Carlsson  <andersca@apple.com>
324
325         Temporarily reintroduce the informal delegate protocols
326         https://bugs.webkit.org/show_bug.cgi?id=140416
327
328         Reviewed by Dan Bernstein.
329
330         * WebView/WebEditingDelegate.h:
331         * WebView/WebFrameLoadDelegate.h:
332         * WebView/WebPolicyDelegate.h:
333         * WebView/WebResourceLoadDelegate.h:
334         * WebView/WebUIDelegate.h:
335
336 2015-01-13  Beth Dakin  <bdakin@apple.com>
337
338         Should disable immediate actions for iTunes
339         https://bugs.webkit.org/show_bug.cgi?id=140405
340         -and corresponding-
341         rdar://problem/19461358
342
343         Reviewed by Tim Horton.
344
345         * WebView/WebImmediateActionController.mm:
346         (-[WebImmediateActionController _updateImmediateActionItem]):
347
348 2015-01-11  Sam Weinig  <sam@webkit.org>
349
350         Remove support for SharedWorkers
351         https://bugs.webkit.org/show_bug.cgi?id=140344
352
353         Reviewed by Anders Carlsson.
354
355         * Configurations/FeatureDefines.xcconfig:
356         * WebCoreSupport/WebPlatformStrategies.h:
357         * WebCoreSupport/WebPlatformStrategies.mm:
358         (WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
359
360 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
361
362         Get rid of unnecessary reimplementations of CGFloor/Ceiling
363         https://bugs.webkit.org/show_bug.cgi?id=140375
364
365         Reviewed by Simon Fraser.
366
367         * Misc/WebKitNSStringExtras.mm:
368         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
369         (webkit_CGCeiling): Deleted.
370         Delete unnecessary code, use the real CGFloor/Ceiling instead.
371
372 2015-01-12  Anders Carlsson  <andersca@apple.com>
373
374         Make delegates conform to formal delegate protocols
375         https://bugs.webkit.org/show_bug.cgi?id=140370
376
377         Reviewed by Dan Bernstein.
378
379         * DefaultDelegates/WebDefaultPolicyDelegate.h:
380         * WebCoreSupport/WebInspectorClient.mm:
381         Add protocols to the interface declarations.
382
383         * WebView/WebActionMenuController.mm:
384         (-[WebActionMenuController prepareForMenu:withEvent:]):
385         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
386         * WebView/WebImmediateActionController.mm:
387         (-[WebImmediateActionController _updateImmediateActionItem]):
388         (-[WebImmediateActionController _menuItemForDataDetectedText]):
389         Cast to id when trying to invoke delegate methods that aren't on WebUIDelegate.
390
391 2015-01-12  Myles C. Maxfield  <mmaxfield@apple.com>
392
393         Allow targetting the SVG->OTF font converter with ENABLE(SVG_OTF_CONVERTER)
394         https://bugs.webkit.org/show_bug.cgi?id=136769
395
396         Reviewed by Antti Koivisto.
397
398         * Configurations/FeatureDefines.xcconfig:
399
400 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
401
402         Multi-rect TextIndicators are vertically flipped in WebKit1
403         https://bugs.webkit.org/show_bug.cgi?id=140350
404         <rdar://problem/19441243>
405
406         Reviewed by Beth Dakin.
407
408         * WebView/WebView.mm:
409         (-[WebView _setTextIndicator:fadeOut:]):
410         Convert the textBoundingRect from root view to screen coordinates.
411
412 2015-01-12  Anders Carlsson  <andersca@apple.com>
413
414         Make WebResourceDelegate a formal protocol as well
415         https://bugs.webkit.org/show_bug.cgi?id=140364
416
417         Reviewed by Dan Bernstein.
418
419         * WebView/WebResourceLoadDelegate.h:
420
421 2015-01-12  Anders Carlsson  <andersca@apple.com>
422
423         Delegates should be formal protocols
424         https://bugs.webkit.org/show_bug.cgi?id=140360
425         rdar://problem/17380856
426
427         Reviewed by Dan Bernstein.
428
429         This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
430
431         * DefaultDelegates/WebDefaultUIDelegate.h:
432         * Misc/WebDownload.h:
433         * WebView/WebEditingDelegate.h:
434         * WebView/WebFrameLoadDelegate.h:
435         * WebView/WebPolicyDelegate.h:
436         * WebView/WebUIDelegate.h:
437
438 2015-01-09  Anders Carlsson  <andersca@apple.com>
439
440         Get rid of the database strategy
441         https://bugs.webkit.org/show_bug.cgi?id=140322
442
443         Reviewed by Sam Weinig.
444
445         * WebCoreSupport/WebPlatformStrategies.h:
446         * WebCoreSupport/WebPlatformStrategies.mm:
447         (WebPlatformStrategies::createDatabaseStrategy): Deleted.
448
449 2015-01-08  Timothy Horton  <timothy_horton@apple.com>
450
451         Can't use DataDetectors after immediate action preparation
452         https://bugs.webkit.org/show_bug.cgi?id=140263
453         <rdar://problem/19412705>
454
455         Reviewed by Beth Dakin.
456
457         * WebView/WebImmediateActionController.mm:
458         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
459         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
460         To match WebKit2, only call shouldUseActions if the animation is actually
461         going to begin, not when preparing for it. This way, we're guaranteed
462         to get a didCancel or didComplete.
463
464 2015-01-08  Dean Jackson  <dino@apple.com>
465
466         Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
467         https://bugs.webkit.org/show_bug.cgi?id=140232
468         <rdar://problem/19371010>
469
470         Reviewed by Anders Carlsson.
471
472         Remove the applicationChromeMode setting, but leave stubs in to make
473         sure existing binaries don't break.
474
475         * WebCoreSupport/WebInspectorClient.mm:
476         (-[WebInspectorWindowController init]):
477         * WebView/WebPreferenceKeysPrivate.h:
478         * WebView/WebPreferences.mm:
479         (+[WebPreferences initialize]):
480         (-[WebPreferences applicationChromeModeEnabled]):
481         (-[WebPreferences setApplicationChromeModeEnabled:]):
482         * WebView/WebView.mm:
483         (-[WebView _preferencesChanged:]):
484
485 2015-01-07  Daniel Bates  <dabates@apple.com>
486
487         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
488         https://bugs.webkit.org/show_bug.cgi?id=137371
489
490         Reviewed by David Kilzer.
491
492         Use SPI wrapper headers instead of directly references private SPI headers.
493
494         * Plugins/Hosted/NetscapePluginHostManager.mm:
495
496 2015-01-07  Commit Queue  <commit-queue@webkit.org>
497
498         Unreviewed, rolling out r178068.
499         https://bugs.webkit.org/show_bug.cgi?id=140235
500
501         Breaks the iOS build (Requested by enrica on #webkit).
502
503         Reverted changeset:
504
505         "[iOS] Make WebKit2 build with public iOS SDK and more build
506         fixes for DRT"
507         https://bugs.webkit.org/show_bug.cgi?id=137371
508         http://trac.webkit.org/changeset/178068
509
510 2015-01-07  Daniel Bates  <dabates@apple.com>
511
512         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
513         https://bugs.webkit.org/show_bug.cgi?id=137371
514
515         Reviewed by David Kilzer.
516
517         Use SPI wrapper headers instead of directly references private SPI headers.
518
519         * Plugins/Hosted/NetscapePluginHostManager.mm:
520
521 2015-01-07  Beth Dakin  <bdakin@apple.com>
522
523         Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the 
524         link
525         https://bugs.webkit.org/show_bug.cgi?id=140206
526         -and corresponding-
527         rdar://problem/19300492
528
529         Reviewed by Tim Horton.
530
531         Providing and item frame will ensure that the original link is not obscured.
532         * WebView/WebImmediateActionController.mm:
533         (elementBoundingBoxInWindowCoordinatesFromNode):
534         (-[WebImmediateActionController menuItem:itemFrameForPoint:]):
535
536         For now use a max size that is smaller than the WebView, with the screen’s aspect 
537         ratio, and scaled down.
538         (-[WebImmediateActionController menuItem:maxSizeForPoint:]):
539
540 2015-01-07  Anders Carlsson  <andersca@apple.com>
541
542         Give simple HTML documents a database provider
543         https://bugs.webkit.org/show_bug.cgi?id=140192
544         rdar://problem/19398825
545
546         Reviewed by Tim Horton.
547
548         * WebView/WebView.mm:
549         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
550
551 2015-01-06  Anders Carlsson  <andersca@apple.com>
552
553         Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
554         https://bugs.webkit.org/show_bug.cgi?id=140140
555
556         Reviewed by Andreas Kling.
557
558         Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler
559         out of WebCore since nobody else is using it.
560
561         * Plugins/WebNetscapePluginView.h:
562         * Plugins/WebNetscapePluginView.mm:
563         (-[WebNetscapePluginView _createPlugin]):
564         (-[WebNetscapePluginView _destroyPlugin]):
565         * Plugins/npapi.mm:
566         (NPN_PluginThreadAsyncCall):
567
568 2015-01-06  Anders Carlsson  <andersca@apple.com>
569
570         Add a WebKit1 database provider
571         https://bugs.webkit.org/show_bug.cgi?id=140126
572
573         Reviewed by Sam Weinig.
574
575         Set the database provider.
576
577         * WebView/WebView.mm:
578         (-[WebView _commonInitializationWithFrameName:groupName:]):
579
580 2015-01-06  Commit Queue  <commit-queue@webkit.org>
581
582         Unreviewed, rolling out r177963.
583         https://bugs.webkit.org/show_bug.cgi?id=140136
584
585         Caused lots of crashes (Requested by smfr on #webkit).
586
587         Reverted changeset:
588
589         "Add a WebKit1 database provider"
590         https://bugs.webkit.org/show_bug.cgi?id=140126
591         http://trac.webkit.org/changeset/177963
592
593 2015-01-06  Anders Carlsson  <andersca@apple.com>
594
595         Add a WebKit1 database provider
596         https://bugs.webkit.org/show_bug.cgi?id=140126
597
598         Reviewed by Sam Weinig.
599
600         Set the database provider.
601
602         * WebView/WebView.mm:
603         (-[WebView _commonInitializationWithFrameName:groupName:]):
604
605 2015-01-01  Jeff Miller  <jeffm@apple.com>
606
607         Update user-visible copyright strings to include 2015
608         https://bugs.webkit.org/show_bug.cgi?id=139880
609
610         Reviewed by Darin Adler.
611
612         * Info.plist:
613
614 2014-12-30  Dan Bernstein  <mitz@apple.com>
615
616         [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
617         https://bugs.webkit.org/show_bug.cgi?id=140003
618
619         Reviewed by Darin Adler.
620
621         * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
622         that takes their "string" parameter as a "value" "parameter and has an attribute telling
623         the compiler that if the "value" parameter is a format string then the function returns a
624         modified version of it. The result is that if UI_STRING is used as a format string parameter
625         to some function or method, the compiler will check the format specifiers in the string
626         against the other parameters.
627
628 2014-12-29  Dan Bernstein  <mitz@apple.com>
629
630         Fixed the iOS build.
631
632         * Configurations/WebKitLegacy.xcconfig:
633
634 2014-12-29  Anders Carlsson  <andersca@apple.com>
635
636         Get rid of some PageGroup storage functions
637         https://bugs.webkit.org/show_bug.cgi?id=139996
638
639         Reviewed by Sam Weinig.
640
641         Call WebStorageNamespaceProvider directly instead.
642
643         * Storage/WebStorageManager.mm:
644         (-[WebStorageManager syncLocalStorage]):
645         (+[WebStorageManager closeIdleLocalStorageDatabases]):
646         * WebView/WebView.mm:
647         (+[WebView _applicationWillTerminate]):
648
649 2014-12-29  Anders Carlsson  <andersca@apple.com>
650
651         Move storage code from WebCore to WebKit
652         https://bugs.webkit.org/show_bug.cgi?id=139558
653
654         Reviewed by Darin Adler.
655
656         * Storage/WebStorageManager.mm:
657         * Storage/WebStorageTrackerClient.h:
658         * WebView/WebView.mm:
659
660 2014-12-26  Dan Bernstein  <mitz@apple.com>
661
662         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
663         https://bugs.webkit.org/show_bug.cgi?id=139950
664
665         Reviewed by David Kilzer.
666
667         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
668         in a manner that works with Xcode 5.1.1.
669
670 2014-12-23  Timothy Horton  <timothy_horton@apple.com>
671
672         Install a TextIndicator for link immediate actions
673         https://bugs.webkit.org/show_bug.cgi?id=139897
674         <rdar://problem/19333076>
675
676         Reviewed by Anders Carlsson.
677
678         * WebView/WebImmediateActionController.h:
679         * WebView/WebImmediateActionController.mm:
680         (-[WebImmediateActionController _clearImmediateActionState]):
681         Tear down the TextIndicator, just like WebKit2.
682
683         (-[WebImmediateActionController _defaultAnimationController]):
684         Install a TextIndicator for links.
685
686         (-[WebImmediateActionController menuItemDidClose:]):
687         Tear down the TextIndicator when the QL preview closes.
688
689         (-[WebImmediateActionController _menuItemForDataDetectedText]):
690         Directly install and uninstall the TextIndicator for DataDetectors.
691
692         (-[WebImmediateActionController _showTextIndicator]): Deleted.
693         (-[WebImmediateActionController _hideTextIndicator]): Deleted.
694         Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
695
696 2014-12-20  Eric Carlson  <eric.carlson@apple.com>
697
698         [iOS] add optimized fullscreen API
699         https://bugs.webkit.org/show_bug.cgi?id=139833
700         <rdar://problem/18844486>
701
702         Reviewed by Simon Fraser.
703
704         * Configurations/FeatureDefines.xcconfig:  Add ENABLE_VIDEO_PRESENTATION_MODE.
705
706 2014-12-20  David Kilzer  <ddkilzer@apple.com>
707
708         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
709         <http://webkit.org/b/139463>
710
711         Reviewed by Mark Rowe.
712
713         * Configurations/Base.xcconfig:
714         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
715           on OS X.
716         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
717         * Configurations/DebugRelease.xcconfig:
718         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
719         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
720         * Configurations/Version.xcconfig:
721         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
722         * Configurations/WebKitLegacy.xcconfig:
723         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
724           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
725           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
726           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
727           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
728           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
729           WEBCORE_PRIVATE_HEADERS_DIR_Production and
730           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
731           based on SDK.
732         - Fix PRODUCTION_ROOT to actually be set properly.
733         - Simplify EXPORTED_SYMBOLS_FILE_i386.
734
735         * migrate-headers.sh:
736         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
737         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
738           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
739           WebKitLegacy.xcconfig.
740
741 2014-12-19  Simon Fraser  <simon.fraser@apple.com>
742
743         Fix pink background on CoreAnimation plug-ins in WebKit1
744         https://bugs.webkit.org/show_bug.cgi?id=139845
745         rdar://problem/19313075
746
747         Reviewed by Tim Horton.
748         
749         r154078 left in some debugging code that set a pink background on plug-in hosting
750         layers. Remove it.
751
752         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
753         (-[WebHostedNetscapePluginView createPluginLayer]):
754
755 2014-12-19  Andreas Kling  <akling@apple.com>
756
757         Ref-ify TextIterator API.
758         <https://webkit.org/b/139823>
759
760         Reviewed by Antti Koivisto.
761
762         * WebView/WebTextIterator.mm:
763         (-[WebTextIterator currentRange]):
764
765 2014-12-19  Joseph Pecoraro  <pecoraro@apple.com>
766
767         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
768         https://bugs.webkit.org/show_bug.cgi?id=139797
769
770         Reviewed by Mark Lam.
771
772         * WebView/WebScriptDebugger.h:
773         * WebView/WebScriptDebugger.mm:
774         (WebScriptDebugger::handlePause):
775         Standardize on passing JSGlobalObject parameter first.
776
777 2014-12-19  Commit Queue  <commit-queue@webkit.org>
778
779         Unreviewed, rolling out r177574.
780         https://bugs.webkit.org/show_bug.cgi?id=139821
781
782         "Broke Production builds by installing
783         libWebCoreTestSupport.dylib in the wrong directory" (Requested
784         by ddkilzer on #webkit).
785
786         Reverted changeset:
787
788         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
789         WebInspectorUI, WebKit, WebKit2"
790         https://bugs.webkit.org/show_bug.cgi?id=139463
791         http://trac.webkit.org/changeset/177574
792
793 2014-12-19  David Kilzer  <ddkilzer@apple.com>
794
795         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
796         <http://webkit.org/b/139463>
797
798         Reviewed by Mark Rowe.
799
800         * Configurations/Base.xcconfig:
801         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
802           on OS X.
803         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
804         * Configurations/DebugRelease.xcconfig:
805         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
806         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
807         * Configurations/Version.xcconfig:
808         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
809         * Configurations/WebKitLegacy.xcconfig:
810         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
811           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
812           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
813           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
814           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
815           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
816           WEBCORE_PRIVATE_HEADERS_DIR_Production and
817           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
818           based on SDK.
819         - Fix PRODUCTION_ROOT to actually be set properly.
820         - Simplify EXPORTED_SYMBOLS_FILE_i386.
821
822         * migrate-headers.sh:
823         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
824         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
825           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
826           WebKitLegacy.xcconfig.
827
828 2014-12-18  Andreas Kling  <akling@apple.com>
829
830         Ref-ify various Document-related things.
831         <https://webkit.org/b/139796>
832
833         Reviewed by Anders Carlsson.
834
835         * WebView/WebFrame.mm:
836         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
837
838 2014-12-18  Beth Dakin  <bdakin@apple.com>
839
840         Need to re-enable action menus
841         https://bugs.webkit.org/show_bug.cgi?id=139795
842         -and corresponding-
843         rdar://problem/19299367
844
845         Reviewed by Tim Horton.
846
847         Re-enable the menus by un-commenting the code to create the menu and controller.
848         * WebView/WebView.mm:
849         (-[WebView _commonInitializationWithFrameName:groupName:]):
850
851 2014-12-16  Sam Weinig  <sam@webkit.org>
852
853         Unify the Mac and iOS implementations of FontPlatformData a bit
854         https://bugs.webkit.org/show_bug.cgi?id=139721
855
856         Reviewed by Anders Carlsson.
857
858         * WebView/WebHTMLView.mm:
859         (fontNameForDescription):
860         Update for new function name.
861
862 2014-12-18  Antti Koivisto  <antti@apple.com>
863
864         Remove alwaysUseBaselineOfPrimaryFont setting
865         https://bugs.webkit.org/show_bug.cgi?id=139770
866
867         Reviewed by Anders Carlsson.
868
869         * WebView/WebPreferenceKeysPrivate.h:
870         * WebView/WebPreferences.mm:
871         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
872         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
873         * WebView/WebPreferencesPrivate.h:
874         * WebView/WebView.mm:
875         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
876         (-[WebView _preferencesChanged:]):
877
878 2014-12-17  Andreas Kling  <akling@apple.com>
879
880         Ref-ify Range::create().
881         <https://webkit.org/b/139755>
882
883         Reviewed by Anders Carlsson.
884
885         * WebView/WebHTMLRepresentation.mm:
886         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
887         * WebView/WebHTMLView.mm:
888         (-[WebHTMLView attributedString]):
889
890 2014-12-17  Anders Carlsson  <andersca@apple.com>
891
892         Unify -[WebResource description]
893         https://bugs.webkit.org/show_bug.cgi?id=139762
894
895         Reviewed by Dan Bernstein.
896
897         * WebView/WebResource.mm:
898         (-[WebResource description]):
899
900 2014-12-17  Anders Carlsson  <andersca@apple.com>
901
902         Get rid of an ugly #define hack in WebFrameLoaderClient
903         https://bugs.webkit.org/show_bug.cgi?id=139761
904
905         Reviewed by Dan Bernstein.
906
907         Also replace @private with @package in all public headers, for consistency.
908
909         * History/WebBackForwardList.h:
910         * History/WebHistory.h:
911         * Misc/WebDownload.h:
912         * WebCoreSupport/WebFrameLoaderClient.mm:
913         * WebView/WebArchive.h:
914         * WebView/WebDataSource.h:
915         * WebView/WebFrame.h:
916         * WebView/WebFrameView.h:
917         * WebView/WebPreferences.h:
918         * WebView/WebResource.h:
919
920 2014-12-17  Dan Bernstein  <mitz@apple.com>
921
922         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
923         https://bugs.webkit.org/show_bug.cgi?id=139760
924
925         Reviewed by Anders Carlsson.
926
927         * Configurations/WebKitLegacy.xcconfig:
928
929 2014-12-17  Andreas Kling  <akling@apple.com>
930
931         Purge PassRefPtr from Frame.
932         <https://webkit.org/b/139731>
933
934         Reviewed by Anders Carlsson.
935
936         * WebCoreSupport/WebFrameLoaderClient.mm:
937         (WebFrameLoaderClient::transitionToCommittedForNewPage):
938         * WebView/WebFrame.mm:
939         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
940         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
941         * WebView/WebFrameInternal.h:
942
943 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
944
945         Implement and adopt two new TextIndicator presentation animations
946         https://bugs.webkit.org/show_bug.cgi?id=139715
947         <rdar://problem/19237945>
948
949         Reviewed by Anders Carlsson.
950
951         * WebView/WebActionMenuController.mm:
952         (-[WebActionMenuController _showTextIndicator]):
953         * WebView/WebHTMLView.mm:
954         (-[WebHTMLView quickLookWithEvent:]):
955         Remove the completionHandler from text indicator presentation.
956
957         * WebView/WebImmediateActionController.mm:
958         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
959         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
960         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
961         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
962         (-[WebImmediateActionController _menuItemForDataDetectedText]):
963         (-[WebImmediateActionController _animationControllerForText]):
964         (-[WebImmediateActionController _showTextIndicator]):
965         Forward immediate action gesture recognizer animation progress
966         to TextIndicator. Force us to keep the selection when immediate
967         action popovers steal first responder status from the WebView.
968         If the Lookup range is equal to the selection range, use a Crossfade
969         animation; otherwise, use a FadeIn animation.
970
971         * WebView/WebView.mm:
972         (-[WebView _setMaintainsInactiveSelection:]):
973         (-[WebView maintainsInactiveSelection]):
974         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
975         (-[WebView _setTextIndicator:fadeOut:]):
976         (-[WebView _clearTextIndicator]):
977         (-[WebView _setTextIndicatorAnimationProgress:]):
978         (-[WebView _showDictionaryLookupPopup:]):
979         (-[WebView _dictionaryLookupPopoverWillClose:]):
980         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
981         Remove the completionHandler from text indicator presentation.
982         Add a _setMaintainsInactiveSelection, which allows WebKit internals
983         to change the return value of -maintainsInactiveSelection, allowing
984         us to keep the selection alive when the WebView loses first responder status.
985
986         * WebView/WebViewData.h:
987         * WebView/WebViewInternal.h:
988
989 2014-12-16  Andreas Kling  <akling@apple.com>
990
991         Use Ref for SecurityOrigin.
992         <https://webkit.org/b/139710>
993
994         Reviewed by Anders Carlsson.
995
996         * Storage/WebStorageTrackerClient.mm:
997         (WebStorageTrackerClient::dispatchDidModifyOrigin):
998         * WebView/WebView.mm:
999         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
1000         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
1001
1002 2014-12-16  Beth Dakin  <bdakin@apple.com>
1003
1004         Crash getting default animation controller for some text
1005         https://bugs.webkit.org/show_bug.cgi?id=139712
1006         -and corresponding-
1007         rdar://problem/19271707
1008
1009         Reviewed by Tim Horton.
1010
1011         Must null-check the range.
1012         * WebView/WebImmediateActionController.mm:
1013         (-[WebImmediateActionController _animationControllerForText]):
1014
1015 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
1016
1017         Immediate action popovers can get stuck open
1018         https://bugs.webkit.org/show_bug.cgi?id=139709
1019         <rdar://problem/19270279>
1020
1021         Reviewed by Beth Dakin.
1022
1023         * WebView/WebImmediateActionController.mm:
1024         (-[WebImmediateActionController _clearImmediateActionState]):
1025         Don't clear the animation controller; it breaks things and was unnecessary.
1026
1027 2014-12-16  Tim Horton  <timothy_horton@apple.com>
1028
1029         Disable TextIndication for Lookup immediate actions
1030         https://bugs.webkit.org/show_bug.cgi?id=139684
1031
1032         Reviewed by Anders Carlsson.
1033
1034         * WebView/WebView.mm:
1035         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1036
1037 2014-12-15  Beth Dakin  <bdakin@apple.com>
1038
1039         Build fix.
1040
1041         * WebView/WebImmediateActionController.mm:
1042
1043 2014-12-15  Beth Dakin  <bdakin@apple.com>
1044
1045         Speculative build fix.
1046
1047         * WebView/WebView.mm:
1048         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1049         * WebView/WebViewInternal.h:
1050
1051 2014-12-15  Beth Dakin  <bdakin@apple.com>
1052
1053         Make lookup an immediate action instead of an action menu item
1054         https://bugs.webkit.org/show_bug.cgi?id=139661
1055         -and corresponding-
1056         rdar://problem/19198414
1057
1058         Reviewed by Tim Horton.
1059
1060         Remove the lookup menu items and non-unused static function associated with 
1061         lookup.
1062         * WebView/WebActionMenuController.mm:
1063         (-[WebActionMenuController _defaultMenuItemsForText]):
1064         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
1065         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
1066         (-[WebActionMenuController _createActionMenuItemForTag:]):
1067         (-[WebActionMenuController _lookupText:]): Deleted.
1068         (performDictionaryLookupForSelection): Deleted.
1069         (performDictionaryLookupForRange): Deleted.
1070
1071         Set the defaultAnimationController to the lookup-provided animation controller 
1072         when appropriate.
1073         * WebView/WebImmediateActionController.mm:
1074         (-[WebImmediateActionController _defaultAnimationController]):
1075         (dictionaryPopupInfoForRange):
1076         (-[WebImmediateActionController _animationControllerForText]):
1077
1078         New type.
1079         * WebView/WebUIDelegatePrivate.h:
1080
1081         New function to get the lookup animation controller.
1082         * WebView/WebView.mm:
1083         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1084         * WebView/WebViewInternal.h:
1085
1086 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
1087
1088         Implement Data Detectors immediate actions for Legacy WebKit
1089         https://bugs.webkit.org/show_bug.cgi?id=139619
1090         <rdar://problem/19198539>
1091
1092         Reviewed by Beth Dakin.
1093
1094         * WebView/WebImmediateActionController.mm:
1095         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1096         Note that this action context is only for immediate actions.
1097
1098 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
1099
1100         Addressing post-review comments in r177035
1101         https://bugs.webkit.org/show_bug.cgi?id=139557
1102
1103         Reviewed by Darin Adler.
1104
1105         * WebView/WebActionMenuController.mm:
1106         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
1107
1108 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
1109
1110         Implement Data Detectors immediate actions for Legacy WebKit
1111         https://bugs.webkit.org/show_bug.cgi?id=139619
1112         <rdar://problem/19198539>
1113
1114         Reviewed by Eric Carlson.
1115
1116         * WebView/WebHTMLView.mm:
1117         (-[WebHTMLView mouseDown:mouseDown:]):
1118         Send mouseDown along to the WebImmediateActionController too.
1119
1120         * WebView/WebImmediateActionController.h:
1121         * WebView/WebImmediateActionController.mm:
1122         (-[WebImmediateActionController webViewClosed]):
1123         (-[WebImmediateActionController webView:willHandleMouseDown:]):
1124         (-[WebImmediateActionController _cancelImmediateAction]):
1125         (-[WebImmediateActionController _clearImmediateActionState]):
1126         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1127         (-[WebImmediateActionController _defaultAnimationController]):
1128         (-[WebImmediateActionController _updateImmediateActionItem]):
1129         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1130         (-[WebImmediateActionController _showTextIndicator]):
1131         (-[WebImmediateActionController _hideTextIndicator]):
1132         Copy most of the DataDetectors implementation into WebImmediateActionController.
1133
1134         * WebView/WebUIDelegatePrivate.h:
1135         Add a new type.
1136
1137         * WebView/WebView.mm:
1138         (-[WebView _commonInitializationWithFrameName:groupName:]):
1139         Temporarily disable action menus.
1140
1141         (-[WebView _immediateActionController]):
1142         * WebView/WebViewInternal.h:
1143
1144 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
1145
1146         Delete Notation because we don't use it
1147         https://bugs.webkit.org/show_bug.cgi?id=139171
1148
1149         Reviewed by Kent Tamura.
1150
1151         * MigrateHeaders.make:
1152
1153 2014-12-14  Andreas Kling  <akling@apple.com>
1154
1155         Replace PassRef with Ref/Ref&& across the board.
1156         <https://webkit.org/b/139587>
1157
1158         Reviewed by Darin Adler.
1159
1160         * WebCoreSupport/WebEditorClient.mm:
1161         (WebEditorClient::shouldApplyStyle):
1162         * WebCoreSupport/WebVisitedLinkStore.h:
1163         * WebCoreSupport/WebVisitedLinkStore.mm:
1164         (WebVisitedLinkStore::create):
1165
1166 2014-12-11  Dan Bernstein  <mitz@apple.com>
1167
1168         Fix a leak introduced in r177199.
1169
1170         Reviewed by Anders Carlsson.
1171
1172         * WebView/WebImmediateActionController.mm:
1173         (-[WebImmediateActionController _updateImmediateActionItem]):
1174
1175 2014-12-11  Beth Dakin  <bdakin@apple.com>
1176
1177         WK1: Need new SPI for Webkit clients to override default immediate action
1178         https://bugs.webkit.org/show_bug.cgi?id=139568
1179         -and corresponding-
1180         rdar://problem/19225448
1181
1182         Reviewed by Dan Bernstein.
1183
1184         Call SPI giving clients a chance to override the default behavior.
1185         * WebView/WebImmediateActionController.mm:
1186         (-[WebImmediateActionController _updateImmediateActionItem]):
1187
1188         New SPI.
1189         * WebView/WebUIDelegatePrivate.h:
1190
1191 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
1192
1193         Move the preview popover to WebImmediateActionController
1194         https://bugs.webkit.org/show_bug.cgi?id=139563
1195         <rdar://problem/19208291>
1196
1197         Reviewed by Beth Dakin.
1198
1199         * WebView/WebActionMenuController.mm:
1200         (-[WebActionMenuController _defaultMenuItemsForLink]):
1201         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
1202         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
1203         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
1204         * WebView/WebImmediateActionController.h:
1205         * WebView/WebImmediateActionController.mm:
1206         (-[WebImmediateActionController webViewClosed]):
1207         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1208         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1209         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1210         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1211         (-[WebImmediateActionController _updateImmediateActionItem]):
1212         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
1213         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
1214         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
1215         Move page preview popover related code to WebImmediateActionController.
1216
1217         * WebView/WebUIDelegatePrivate.h:
1218         Add a link preview type.
1219
1220         * WebView/WebView.mm:
1221         (-[WebView _commonInitializationWithFrameName:groupName:]):
1222         Pass the gesture recognizer to the WebImmediateActionController.
1223
1224 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
1225
1226         Fix the build.
1227
1228         * WebView/WebImmediateActionController.h:
1229         * WebView/WebImmediateActionController.mm:
1230
1231 2014-12-11  Anders Carlsson  <andersca@apple.com>
1232
1233         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
1234         https://bugs.webkit.org/show_bug.cgi?id=139547
1235
1236         Reviewed by Sam Weinig.
1237
1238         * WebView/WebView.mm:
1239         (+[WebView _handleMemoryWarning]):
1240
1241 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
1242
1243         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
1244         https://bugs.webkit.org/show_bug.cgi?id=139504
1245         rdar://problem/19034674
1246
1247         Reviewed by Enrica Casucci.
1248
1249         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
1250
1251         * WebCoreSupport/WebEditorClient.h:
1252         * WebCoreSupport/WebEditorClient.mm:
1253         (WebEditorClient::discardedComposition):
1254
1255 2014-12-10  Anders Carlsson  <andersca@apple.com>
1256
1257         Get rid of the storage strategy
1258         https://bugs.webkit.org/show_bug.cgi?id=139519
1259
1260         Reviewed by Antti Koivisto.
1261
1262         * WebCoreSupport/WebPlatformStrategies.h:
1263         * WebCoreSupport/WebPlatformStrategies.mm:
1264         (WebPlatformStrategies::createStorageStrategy): Deleted.
1265
1266 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
1267
1268         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
1269         https://bugs.webkit.org/show_bug.cgi?id=139529
1270         <rdar://problem/19213620>
1271
1272         Reviewed by Beth Dakin.
1273
1274         * WebView/WebActionMenuController.mm:
1275         (-[WebActionMenuController _copySelection:]):
1276         (-[WebActionMenuController _paste:]):
1277         Use the copy: and paste: methods on WebView so that we traverse subviews
1278         when trying to respond, otherwise these actions don't work in subframes.
1279
1280 2014-12-10  Beth Dakin  <bdakin@apple.com>
1281
1282         WK1: Add initial support for immediate actions
1283         https://bugs.webkit.org/show_bug.cgi?id=139522
1284
1285         Reviewed by Dan Bernstein.
1286
1287         This basic implementation of the controller will use the delegate methods to 
1288         perform and cache a HitTest when relevant. Future patches will patch 
1289         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
1290         immediate action that should be taken.
1291         * WebView/WebImmediateActionController.h: Added.
1292         * WebView/WebImmediateActionController.mm: Added.
1293         (-[WebImmediateActionController webViewClosed]):
1294         (-[WebImmediateActionController _clearImmediateActionState]):
1295         (-[WebImmediateActionController performHitTestAtPoint:]):
1296         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1297         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1298         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1299         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1300         (-[WebImmediateActionController _updateImmediateActionItem]):
1301
1302         New enum for immediate action types.
1303         * WebView/WebUIDelegatePrivate.h:
1304
1305         Create an NSImmediateActionGestureRecognizer if possible and a controller.
1306         * WebView/WebView.mm:
1307         (-[WebView _commonInitializationWithFrameName:groupName:]):
1308         (-[WebView _close]):
1309         * WebView/WebViewData.h:
1310         * WebView/WebViewData.mm:
1311         (-[WebViewPrivate dealloc]):
1312
1313 2014-12-08  Anders Carlsson  <andersca@apple.com>
1314
1315         Use the new storage namespace provider in WebKit1
1316         https://bugs.webkit.org/show_bug.cgi?id=139425
1317
1318         Reviewed by Tim Horton.
1319
1320         * WebView/WebView.mm:
1321         (-[WebView _commonInitializationWithFrameName:groupName:]):
1322         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1323         Set the storage namespace provider from the web page group.
1324
1325 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
1326
1327         Should have copy and paste items in all text menus
1328         https://bugs.webkit.org/show_bug.cgi?id=139510
1329         <rdar://problem/19198388>
1330
1331         Reviewed by Beth Dakin.
1332
1333         * WebView/WebActionMenuController.mm:
1334         (-[WebActionMenuController _defaultMenuItemsForText]):
1335         Add a disabled paste menu item into the read-only text menu.
1336
1337         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
1338         Add a disabled copy menu item into the editable whitespace text menu.
1339
1340 2014-12-10  Anders Carlsson  <andersca@apple.com>
1341
1342         Add WebStorageNamespaceProvider::closeLocalStorage
1343         https://bugs.webkit.org/show_bug.cgi?id=139502
1344
1345         Reviewed by Tim Horton.
1346
1347         * WebView/WebView.mm:
1348         (+[WebView _applicationWillTerminate]):
1349         Call WebStorageNamespaceProvider::closeLocalStorage.
1350
1351 2014-12-09  Commit Queue  <commit-queue@webkit.org>
1352
1353         Unreviewed, rolling out r177037.
1354         https://bugs.webkit.org/show_bug.cgi?id=139464
1355
1356         broke ~50 API tests (Requested by thorton on #webkit).
1357
1358         Reverted changeset:
1359
1360         "Use the new storage namespace provider in WebKit1"
1361         https://bugs.webkit.org/show_bug.cgi?id=139425
1362         http://trac.webkit.org/changeset/177037
1363
1364 2014-12-08  Anders Carlsson  <andersca@apple.com>
1365
1366         Use the new storage namespace provider in WebKit1
1367         https://bugs.webkit.org/show_bug.cgi?id=139425
1368
1369         Reviewed by Tim Horton.
1370
1371         * WebView/WebView.mm:
1372         (-[WebView _commonInitializationWithFrameName:groupName:]):
1373         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1374         Set the storage namespace provider from the web page group.
1375
1376 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
1377
1378         Delete Node::boundingBox()
1379         https://bugs.webkit.org/show_bug.cgi?id=139333
1380
1381         Reviewed by Zalan Bujtas.
1382
1383         * WebView/WebActionMenuController.mm:
1384         (elementBoundingBoxInWindowCoordinatesFromNode): Use
1385         RenderObject::absoluteBoundingBoxRect().
1386
1387 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
1388
1389         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
1390         https://bugs.webkit.org/show_bug.cgi?id=138843
1391         rdar://problem/18793695
1392
1393         Reviewed by Dan Bernstein.
1394
1395         * Panels/WebAuthenticationPanel.m:
1396         (-[WebAuthenticationPanel cancel:]):
1397         (-[WebAuthenticationPanel logIn:]):
1398         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
1399         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
1400         that only when using an old NSWindow API.
1401
1402 2014-12-08  Beth Dakin  <bdakin@apple.com>
1403
1404         Copy and Lookup menu items should be disabled when something is not copyable
1405         https://bugs.webkit.org/show_bug.cgi?id=139423
1406
1407         Reviewed by Tim Horton.
1408
1409         Disable both lookup and copy when a HitTestResult does not allow copy.
1410         * WebView/WebActionMenuController.mm:
1411
1412         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
1413         disable state otherwise.
1414         * WebView/WebView.mm:
1415         (-[WebView _commonInitializationWithFrameName:groupName:]):
1416
1417 2014-12-08  Anders Carlsson  <andersca@apple.com>
1418
1419         Adding user content to a group should force that group to be created
1420         https://bugs.webkit.org/show_bug.cgi?id=139421
1421         rdar://problem/19180108
1422
1423         Reviewed by Sam Weinig.
1424
1425         * WebCoreSupport/WebViewGroup.h:
1426         Store the local storage database path in the group.
1427
1428         * WebCoreSupport/WebViewGroup.mm:
1429         (WebViewGroup::getOrCreate):
1430         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
1431         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
1432
1433         (WebViewGroup::WebViewGroup):
1434         Initialize the new member variable.
1435
1436         (WebViewGroup::storageNamespaceProvider):
1437         Create the namespace provider lazily.
1438
1439         * WebView/WebView.mm:
1440         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1441         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1442         Use getOrCreate instead of get.
1443
1444 2014-12-08  Anders Carlsson  <andersca@apple.com>
1445
1446         WebStorageNamespaceProvider should know about its local storage database path
1447         https://bugs.webkit.org/show_bug.cgi?id=139413
1448
1449         Reviewed by Andreas Kling.
1450
1451         * WebCoreSupport/WebViewGroup.h:
1452         * WebCoreSupport/WebViewGroup.mm:
1453         (WebViewGroup::getOrCreate):
1454         (WebViewGroup::WebViewGroup):
1455         * WebView/WebView.mm:
1456         (-[WebView _commonInitializationWithFrameName:groupName:]):
1457         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1458         (-[WebView setGroupName:]):
1459         (-[WebView groupName]): Deleted.
1460
1461 2014-12-08  Daniel Bates  <dabates@apple.com>
1462
1463         [iOS] Fix the WebKit build with the public SDK
1464
1465         Include header NSURLDownloadSPI.h.
1466
1467         * WebCoreSupport/WebFrameLoaderClient.mm:
1468
1469 2014-12-07  Dan Bernstein  <mitz@apple.com>
1470
1471         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
1472         https://bugs.webkit.org/show_bug.cgi?id=139348
1473
1474         Reviewed by Anders Carlsson.
1475
1476         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
1477         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
1478         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
1479         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
1480         avoiding the ambiguity.
1481
1482         * WebView/WebActionMenuController.mm:
1483         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1484
1485 2014-12-06  Anders Carlsson  <andersca@apple.com>
1486
1487         Add a stubbed out version of WebStorageNamespaceProvider
1488         https://bugs.webkit.org/show_bug.cgi?id=139213
1489
1490         Reviewed by Sam Weinig.
1491
1492         * WebCoreSupport/WebViewGroup.h:
1493         (WebViewGroup::storageNamespaceProvider):
1494         * WebCoreSupport/WebViewGroup.mm:
1495         (WebViewGroup::getOrCreate):
1496         (WebViewGroup::WebViewGroup):
1497         Give WebViewGroup a storage namespace provider.
1498
1499 2014-12-06  Anders Carlsson  <andersca@apple.com>
1500
1501         Fix build with newer versions of clang.
1502         rdar://problem/18978687
1503
1504         Add missing overrides and missing casts.
1505
1506         * Storage/WebDatabaseManagerClient.h:
1507         * Storage/WebStorageTrackerClient.h:
1508         * WebCoreSupport/WebChromeClient.h:
1509         * WebCoreSupport/WebFrameLoaderClient.h:
1510         * WebCoreSupport/WebInspectorClient.h:
1511         * WebView/WebDataSource.mm:
1512         (-[WebDataSource _makeRepresentation]):
1513         * WebView/WebFrameView.mm:
1514         (-[WebFrameView _makeDocumentViewForDataSource:]):
1515
1516 2014-12-05  Tim Horton  <timothy_horton@apple.com>
1517
1518         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
1519         https://bugs.webkit.org/show_bug.cgi?id=139306
1520         <rdar://problem/19157955>
1521
1522         Reviewed by Beth Dakin.
1523
1524         * WebView/WebView.mm:
1525         (-[WebView _commonInitializationWithFrameName:groupName:]):
1526         (-[WebView _initWithFrame:frameName:groupName:]):
1527         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
1528
1529 2014-12-05  David Kilzer  <ddkilzer@apple.com>
1530
1531         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
1532         <http://webkit.org/b/139286>
1533
1534         Reviewed by Daniel Bates.
1535
1536         * Configurations/FeatureDefines.xcconfig: Switch back to using
1537         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
1538
1539 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
1540
1541         Fix the 32-bit build.
1542
1543         * WebView/WebView.mm:
1544         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1545
1546 2014-12-04  Tim Horton  <timothy_horton@apple.com>
1547
1548         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
1549         https://bugs.webkit.org/show_bug.cgi?id=139252
1550         <rdar://problem/19140827>
1551
1552         Reviewed by Anders Carlsson.
1553
1554         * WebView/WebView.mm:
1555         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1556         Adjust to the WebCore changes.
1557
1558 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
1559
1560         Implement action menus for tel: URLs
1561         https://bugs.webkit.org/show_bug.cgi?id=139240
1562         <rdar://problem/19115662>
1563
1564         Reviewed by Anders Carlsson.
1565
1566         * WebView/WebActionMenuController.mm:
1567         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1568         Make sure to use the newly created currentActionContext... everywhere.
1569
1570 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
1571
1572         Implement action menus for tel: URLs
1573         https://bugs.webkit.org/show_bug.cgi?id=139240
1574         <rdar://problem/19115662>
1575
1576         Reviewed by Anders Carlsson.
1577
1578         * WebView/WebActionMenuController.mm:
1579         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1580         Make sure to use the newly created currentActionContext.
1581
1582 2014-12-03  Beth Dakin  <bdakin@apple.com>
1583
1584         <input> elements get whitespace action menu instead of editable text menu
1585         https://bugs.webkit.org/show_bug.cgi?id=139241
1586         -and corresponding-
1587         rdar://problem/19072083
1588
1589         Reviewed by Sam Weinig.
1590
1591         We should disallow shadow content in the hit test. This is the default and it is 
1592         how context menus behave. We originally wanted to text inside shadow content so 
1593         that we could find the text, but the new function I added to HitTestResult will 
1594         allow that.
1595         * WebView/WebActionMenuController.mm:
1596         (-[WebActionMenuController performHitTestAtPoint:]):
1597
1598         Adjust to the fact that we don’t hit test shadow content any more.
1599         (-[WebActionMenuController focusAndSelectHitTestResult]):
1600
1601         Offer the text menus for text inside form controls.
1602         (-[WebActionMenuController _defaultMenuItems]):
1603
1604 2014-12-03  Tim Horton  <timothy_horton@apple.com>
1605
1606         Implement action menus for tel: URLs
1607         https://bugs.webkit.org/show_bug.cgi?id=139240
1608         <rdar://problem/19115662>
1609
1610         Reviewed by Anders Carlsson.
1611
1612         * WebView/WebActionMenuController.mm:
1613         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1614         Rename this function as it will work for both mailto and tel URLs.
1615         Adjust it to use contextForView:.
1616
1617         (-[WebActionMenuController webView:willHandleMouseDown:]):
1618         (-[WebActionMenuController prepareForMenu:withEvent:]):
1619         (-[WebActionMenuController didCloseMenu:withEvent:]):
1620         (-[WebActionMenuController _defaultMenuItems]):
1621         Don't check the menu type when going to interact with _currentActionContext.
1622         We'll only have a _currentActionContext if we have a data detected item,
1623         and there are multiple menu types that end up using DDActionContext.
1624
1625         * WebView/WebUIDelegatePrivate.h:
1626         Add a new type.
1627
1628 2014-12-03  Anders Carlsson  <andersca@apple.com>
1629
1630         Set a visited link store when creating a simple WebView
1631         https://bugs.webkit.org/show_bug.cgi?id=139234
1632         <rdar://problem/19132978>
1633
1634         Reviewed by Sam Weinig.
1635
1636         * WebView/WebView.mm:
1637         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1638
1639 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
1640
1641         Fix the build.
1642
1643         * WebCoreSupport/WebFrameLoaderClient.mm:
1644
1645 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
1646
1647         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
1648         https://bugs.webkit.org/show_bug.cgi?id=139149
1649
1650         Reviewed by Anders Carlsson.
1651
1652         This changes API behavior. I think that it's OK, because existing behavior made no sense.
1653         We used to delete caches from disk, but they were still active in memory. Now we also
1654         obsolete them in memory, so documents that use a cache still work, but new ones don't
1655         pick one up.
1656
1657         * WebCoreSupport/WebApplicationCache.mm:
1658         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
1659         need to delete in-momry caches too. Keep existing behavior.
1660         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
1661         that properly deletes caches.
1662
1663 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1664
1665         Remove a SnowLeopard-era quirk for QuickLook
1666         https://bugs.webkit.org/show_bug.cgi?id=139208
1667         <rdar://problem/19121822>
1668
1669         Reviewed by Alexey Proskuryakov.
1670
1671         * WebCoreSupport/WebFrameLoaderClient.h:
1672         * WebCoreSupport/WebFrameLoaderClient.mm:
1673
1674 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1675
1676         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
1677         https://bugs.webkit.org/show_bug.cgi?id=139204
1678
1679         Reviewed by Anders Carlsson.
1680
1681         * WebView/WebView.mm:
1682         (-[WebView _commonInitializationWithFrameName:groupName:]):
1683         (-[WebView _showDictionaryLookupPopup:]):
1684         * WebView/WebViewData.h:
1685         Work around this by delaying the softlinking (and setting up the notification
1686         observer) until we actually need it. There's still an underlying bug, but
1687         this will fix the test.
1688
1689 2014-12-02  Beth Dakin  <bdakin@apple.com>
1690
1691         Yet another build fix.
1692
1693         * WebView/WebActionMenuController.mm:
1694         (-[WebActionMenuController _defaultMenuItemsForLink]):
1695
1696 2014-12-02  Beth Dakin  <bdakin@apple.com>
1697
1698         Build fix.
1699
1700         * WebView/WebActionMenuController.mm:
1701         (-[WebActionMenuController _defaultMenuItemsForLink]):
1702
1703 2014-12-02  Beth Dakin  <bdakin@apple.com>
1704
1705         More build fixing.
1706
1707         * WebView/WebActionMenuController.mm:
1708         (-[WebActionMenuController _defaultMenuItemsForLink]):
1709
1710 2014-12-02  Beth Dakin  <bdakin@apple.com>
1711
1712         Should use standardQuickLookMenuItem for apps that don't implement customizations
1713         https://bugs.webkit.org/show_bug.cgi?id=139193
1714         -and corresponding-
1715         rdar://problem/18944696
1716
1717         Reviewed by Anders Carlsson.
1718
1719         Use [NSMenuItem standardQuickLookMenuItem].
1720         * WebView/WebActionMenuController.mm:
1721         (-[WebActionMenuController _defaultMenuItemsForLink]):
1722
1723         Delegate methods to set up the standardQuickLookMenuItem.
1724         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
1725         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
1726         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
1727
1728         Remove all of the old QLPreviewBubble code.
1729         (-[WebActionMenuController _createActionMenuItemForTag:]):
1730         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
1731
1732 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
1733
1734         Fix the build.
1735
1736         * WebView/WebViewData.h:
1737
1738 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1739
1740         Implement Lookup transition from selection for Legacy WebKit
1741         https://bugs.webkit.org/show_bug.cgi?id=139180
1742         <rdar://problem/19067172>
1743
1744         Reviewed by Beth Dakin.
1745
1746         * WebView/DictionaryPopupInfo.h: Added.
1747         Split DictionaryPopupInfo out into its own file.
1748
1749         * WebView/WebActionMenuController.mm:
1750         (-[WebActionMenuController _lookupText:]):
1751         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
1752
1753         (performDictionaryLookupForSelection):
1754         (performDictionaryLookupForRange):
1755         Plumb the transition style through these helpers.
1756         Create a TextIndicator from the selection range.
1757
1758         * WebView/WebHTMLView.mm:
1759         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
1760         Make use of TextIndicator (and DictionaryPopupInfo, and the new
1761         _showDictionaryLookupPopup on WebView) to add a transition from blue
1762         when performing Lookup from the context menu.
1763
1764         (-[WebHTMLView quickLookWithEvent:]):
1765         Remove our TextIndicator whenever a normal three-finger-tap event
1766         comes through, as it will have its own indication.
1767
1768         * WebView/WebView.mm:
1769         (-[WebView _commonInitializationWithFrameName:groupName:]):
1770         (-[WebView _dictionaryLookupPopoverWillClose:]):
1771         Register for the LUNotificationPopoverWillClose notification and remove
1772         our TextIndicator when it is called, just like in WebKit2.
1773         Deregistration is already handled in _close.
1774
1775         (-[WebView _showDictionaryLookupPopup:]):
1776         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
1777         if the relevant API is available.
1778
1779         * WebView/WebViewInternal.h:
1780
1781 2014-12-02  Anders Carlsson  <andersca@apple.com>
1782
1783         Remove visited link handling from PageGroup
1784         https://bugs.webkit.org/show_bug.cgi?id=139185
1785
1786         Reviewed by Sam Weinig.
1787
1788         * History/WebHistory.mm:
1789         (-[WebHistoryPrivate removeItemForURLString:]):
1790         (-[WebHistoryPrivate removeAllItems]):
1791         (+[WebHistory setOptionalSharedHistory:]):
1792         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1793         (+[WebHistory _removeAllVisitedLinks]):
1794         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
1795         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
1796         * History/WebHistoryInternal.h:
1797         * WebCoreSupport/WebChromeClient.h:
1798         * WebCoreSupport/WebChromeClient.mm:
1799         (WebChromeClient::populateVisitedLinks): Deleted.
1800         * WebView/WebView.mm:
1801         (-[WebView addVisitedLinks:]):
1802         (-[WebView removeVisitedLink:]):
1803
1804 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1805
1806         Try to fix the Mac build.
1807
1808         * WebView/WebView.mm:
1809         (-[WebView _commonInitializationWithFrameName:groupName:]):
1810         (-[WebView _close]):
1811
1812 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1813
1814         Fix the iOS build.
1815
1816         * WebView/WebActionMenuController.h:
1817         * WebView/WebActionMenuController.mm:
1818         * WebView/WebHTMLView.mm:
1819         (-[WebHTMLView scrollWheel:scrollWheel:]):
1820         (-[WebHTMLView mouseDown:mouseDown:]):
1821         * WebView/WebView.mm:
1822         * WebView/WebViewData.h:
1823         * WebView/WebViewData.mm:
1824         (-[WebViewPrivate dealloc]):
1825         * WebView/WebViewInternal.h:
1826
1827 2014-12-01  Tim Horton  <timothy_horton@apple.com>
1828
1829         Implement yellow highlight for WebKit1 data detectors
1830         https://bugs.webkit.org/show_bug.cgi?id=138956
1831         <rdar://problem/18992185>
1832
1833         Reviewed by Beth Dakin.
1834
1835         * WebView/WebActionMenuController.h:
1836         * WebView/WebActionMenuController.mm:
1837         (-[WebActionMenuController webView:willHandleMouseDown:]):
1838         (-[WebActionMenuController webView:didHandleScrollWheel:]):
1839         (-[WebActionMenuController prepareForMenu:withEvent:]):
1840         (-[WebActionMenuController didCloseMenu:withEvent:]):
1841         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1842         (-[WebActionMenuController _showTextIndicator]):
1843         (-[WebActionMenuController _hideTextIndicator]):
1844         (-[WebActionMenuController _dismissActionMenuPopovers]):
1845         Copy the WebKit2 WKActionMenuController TextIndicator implementation
1846         into WebActionMenuController. The only significant difference is
1847         that we build the TextIndicator right at menu construction time
1848         instead of in the Web process.
1849
1850         * WebView/WebHTMLView.mm:
1851         (-[WebHTMLView scrollWheel:]):
1852         Let the WebActionMenuController know that we're handling a scroll.
1853
1854         (-[WebHTMLView mouseDown:]):
1855         Let the WebActionMenuController know that we're handling a mouseDown.
1856
1857         * WebView/WebView.mm:
1858         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1859         (-[WebView _clearTextIndicator]):
1860         (-[WebView _actionMenuController]):
1861         (-[WebView _convertRectFromRootView:]): Deleted.
1862         * WebView/WebViewData.h:
1863         * WebView/WebViewData.mm:
1864         * WebView/WebViewInternal.h:
1865         Keep a TextIndicatorWindow on WebView, just like WKView does.
1866         Expose the WebActionMenuController on WebView (internally).
1867
1868 2014-12-01  Anders Carlsson  <andersca@apple.com>
1869
1870         Remove old site specific quirks code that was added in 2009
1871         https://bugs.webkit.org/show_bug.cgi?id=139141
1872
1873         Reviewed by Antti Koivisto.
1874
1875         * WebCoreSupport/WebFrameNetworkingContext.h:
1876         * WebCoreSupport/WebFrameNetworkingContext.mm:
1877         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
1878
1879 2014-11-30  Anders Carlsson  <andersca@apple.com>
1880
1881         Fix a test failure.
1882
1883         * History/WebHistory.mm:
1884         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1885         Call through to the visited link store.
1886
1887         (+[WebHistory _removeAllVisitedLinks]):
1888         Ditto.
1889
1890         * WebCoreSupport/WebVisitedLinkStore.mm:
1891         (WebVisitedLinkStore::isLinkVisited):
1892         Make sure to populate visited links.
1893
1894 2014-11-30  Anders Carlsson  <andersca@apple.com>
1895
1896         Switch over to the visited link store from the WebViewGroup
1897         https://bugs.webkit.org/show_bug.cgi?id=139112
1898
1899         Reviewed by Sam Weinig.
1900
1901         * WebView/WebView.mm:
1902         (-[WebView _commonInitializationWithFrameName:groupName:]):
1903         (-[WebView setGroupName:]):
1904
1905 2014-11-30  Anders Carlsson  <andersca@apple.com>
1906
1907         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
1908         https://bugs.webkit.org/show_bug.cgi?id=139111
1909
1910         Reviewed by Sam Weinig.
1911
1912         * WebCoreSupport/WebVisitedLinkStore.h:
1913         * WebCoreSupport/WebVisitedLinkStore.mm:
1914         (WebVisitedLinkStore::removeVisitedLink):
1915         * WebView/WebView.mm:
1916         (-[WebView removeVisitedLink:]):
1917
1918 2014-11-29  Anders Carlsson  <andersca@apple.com>
1919
1920         Populate visited links
1921         https://bugs.webkit.org/show_bug.cgi?id=139101
1922
1923         Reviewed by Sam Weinig.
1924
1925         * History/WebHistory.mm:
1926         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
1927         Helper function that adds all visited link to the given store.
1928
1929         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
1930         Call the private method.
1931
1932         * History/WebHistoryInternal.h:
1933         * WebCoreSupport/WebVisitedLinkStore.h:
1934         Add new members.
1935
1936         * WebCoreSupport/WebVisitedLinkStore.mm:
1937         (WebVisitedLinkStore::addVisitedLink):
1938         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
1939
1940         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1941         Implement this. First try the delegate, then try the shared history.
1942
1943         (WebVisitedLinkStore::addVisitedLinkHash):
1944         Factor code that adds the link to the hash table into a separate function.
1945
1946         * WebView/WebView.mm:
1947         (-[WebView addVisitedLinks:]):
1948         Add the visited links to the store.
1949
1950 2014-11-29  Anders Carlsson  <andersca@apple.com>
1951
1952         More work on the legacy WebKit visited link store
1953         https://bugs.webkit.org/show_bug.cgi?id=139100
1954
1955         Reviewed by Sam Weinig.
1956
1957         * History/WebHistory.mm:
1958         (+[WebHistory setOptionalSharedHistory:]):
1959         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
1960
1961         * WebCoreSupport/WebVisitedLinkStore.h:
1962         * WebCoreSupport/WebVisitedLinkStore.mm:
1963         (visitedLinkStores):
1964         (WebVisitedLinkStore::WebVisitedLinkStore):
1965         (WebVisitedLinkStore::~WebVisitedLinkStore):
1966         Keep track of live visited link stores.
1967
1968         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
1969         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
1970
1971         (WebVisitedLinkStore::removeAllVisitedLinks):
1972         Iterate over all live link stores and remove their links.
1973
1974         (WebVisitedLinkStore::isLinkVisited):
1975         Populate visited links and check if our hash table contains the link.
1976
1977         (WebVisitedLinkStore::addVisitedLink):
1978         Add the link hash to the table.
1979
1980         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1981         Add stub.
1982
1983         (WebVisitedLinkStore::removeVisitedLinkHashes):
1984         Clear out the hash table.
1985
1986 2014-11-27  Anders Carlsson  <andersca@apple.com>
1987
1988         Add a stubbed out WebVisitedLinkStore to WebViewGroup
1989         https://bugs.webkit.org/show_bug.cgi?id=139066
1990
1991         Reviewed by Antti Koivisto.
1992
1993         * WebCoreSupport/WebViewGroup.h:
1994         (WebViewGroup::visitedLinkStore):
1995         * WebCoreSupport/WebViewGroup.mm:
1996         (WebViewGroup::WebViewGroup):
1997         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1998         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1999         (WebVisitedLinkStore::create):
2000         (WebVisitedLinkStore::WebVisitedLinkStore):
2001         (WebVisitedLinkStore::~WebVisitedLinkStore):
2002         (WebVisitedLinkStore::isLinkVisited):
2003         (WebVisitedLinkStore::addVisitedLink):
2004
2005 2014-11-25  Anders Carlsson  <andersca@apple.com>
2006
2007         Remove user content handling from PageGroup
2008         https://bugs.webkit.org/show_bug.cgi?id=139051
2009
2010         Reviewed by Antti Koivisto.
2011
2012         Use the user content controller in the web view group.
2013
2014         * WebView/WebView.mm:
2015         (-[WebView _injectOutlookQuirksScript]):
2016
2017 2014-11-25  Anders Carlsson  <andersca@apple.com>
2018
2019         Add a user content controller to WebViewGroup and use it for user content
2020         https://bugs.webkit.org/show_bug.cgi?id=139043
2021
2022         Reviewed by Antti Koivisto.
2023
2024         This is another tiny step towards getting rid of user content handling inside PageGroup.
2025
2026         * WebCoreSupport/WebViewGroup.h:
2027         (WebViewGroup::userContentController):
2028         Add a UserContentController member and getter.
2029
2030         * WebCoreSupport/WebViewGroup.mm:
2031         (WebViewGroup::get):
2032         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
2033
2034         (WebViewGroup::WebViewGroup):
2035         Create a user content controller.
2036
2037         * WebView/WebView.mm:
2038         (-[WebView _commonInitializationWithFrameName:groupName:]):
2039         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
2040         set its user content controller in the PageConfiguration.
2041
2042         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2043         Ditto.
2044
2045         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
2046         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
2047         (+[WebView _removeUserScriptFromGroup:world:url:]):
2048         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
2049         (+[WebView _removeUserScriptsFromGroup:world:]):
2050         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
2051         (+[WebView _removeAllUserContentFromGroup:]):
2052         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
2053
2054         (-[WebView setGroupName:]):
2055         Set the user content controller to the new WebViewGroup's user content controller.
2056
2057 2014-11-21  Jer Noble  <jer.noble@apple.com>
2058
2059         Support multiple signatures of diagnostic logging.
2060         https://bugs.webkit.org/show_bug.cgi?id=138690
2061
2062         Reviewed by Anders Carlsson.
2063
2064         Page::PageClients has been renamed PageConfiguration.
2065
2066         * WebView/WebView.mm:
2067         (-[WebView _commonInitializationWithFrameName:groupName:]):
2068         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2069
2070 2014-11-21  Zalan Bujtas  <zalan@apple.com>
2071
2072         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
2073         https://bugs.webkit.org/show_bug.cgi?id=138981
2074
2075         Reviewed by Simon Fraser.
2076
2077         * WebView/WebPreferenceKeysPrivate.h:
2078         * WebView/WebPreferences.mm:
2079         (+[WebPreferences initialize]):
2080         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
2081         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
2082         * WebView/WebPreferencesPrivate.h:
2083         * WebView/WebView.mm:
2084         (-[WebView _preferencesChanged:]):
2085
2086 2014-11-21  Tim Horton  <timothy_horton@apple.com>
2087
2088         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
2089         ​https://bugs.webkit.org/show_bug.cgi?id=138960
2090         <rdar://problem/19056715>
2091
2092         Reviewed by Anders Carlsson.
2093
2094         * WebView/WebActionMenuController.mm:
2095         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
2096         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2097         Use DataDetectors SPI instead of an explicit blacklist.
2098
2099 2014-11-21  Tim Horton  <timothy_horton@apple.com>
2100
2101         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
2102         https://bugs.webkit.org/show_bug.cgi?id=138960
2103         <rdar://problem/19056715>
2104
2105         Reviewed by Beth Dakin.
2106
2107         * WebView/WebActionMenuController.mm:
2108         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2109         Blacklist contact results, because they don't have useful menus. If we
2110         bail before setting up _currentActionContext, we'll still allow fallthrough
2111         to ordinary text actions, avoiding mysterious failure when a contact is detected.
2112
2113         This doesn't break the case that r176351 was intended to fix,
2114         because in that case we were detecting e.g. addresses.
2115
2116 2014-11-21  Anders Carlsson  <andersca@apple.com>
2117
2118         Remove the Timer parameters from timer callbacks
2119         https://bugs.webkit.org/show_bug.cgi?id=138974
2120
2121         Reviewed by Antti Koivisto.
2122
2123         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2124         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2125         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
2126         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2127         * Plugins/WebNetscapePluginStream.h:
2128         * Plugins/WebNetscapePluginStream.mm:
2129         (WebNetscapePluginStream::WebNetscapePluginStream):
2130         (WebNetscapePluginStream::deliverDataTimerFired):
2131
2132 2014-11-21  Anders Carlsson  <andersca@apple.com>
2133
2134         Make memoryCache() return a reference
2135         https://bugs.webkit.org/show_bug.cgi?id=138939
2136
2137         Reviewed by Antti Koivisto.
2138
2139         * Misc/WebCache.mm:
2140         (+[WebCache statistics]):
2141         (+[WebCache emptyInMemoryResources]):
2142         (+[WebCache sizeOfDeadResources:]):
2143         (+[WebCache addImageToCache:forURL:forFrame:]):
2144         (+[WebCache removeImageFromCacheForURL:forFrame:]):
2145         (+[WebCache imageForURL:]):
2146         (+[WebCache setDisabled:]):
2147         (+[WebCache isDisabled]):
2148         * WebView/WebView.mm:
2149         (+[WebView _setCacheModel:]):
2150
2151 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
2152
2153         Remove the remaining vestiges of minimal-ui
2154         https://bugs.webkit.org/show_bug.cgi?id=138890
2155
2156         Reviewed by Sam Weinig.
2157
2158         * History/WebHistoryItem.mm:
2159         * History/WebHistoryItemPrivate.h:
2160
2161 2014-11-20  Tim Horton  <timothy_horton@apple.com>
2162
2163         Cancel DataDetectors menu earlier if we know it can't be presented
2164         https://bugs.webkit.org/show_bug.cgi?id=138922
2165         <rdar://problem/18950441>
2166
2167         Reviewed by Beth Dakin.
2168
2169         * WebView/WebActionMenuController.mm:
2170         (-[WebActionMenuController prepareForMenu:withEvent:]):
2171         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
2172         and use a bigger hammer (removeAllItems).
2173
2174         (-[WebActionMenuController willOpenMenu:withEvent:]):
2175         If we end up with a menu with no items, don't change selection or anything.
2176
2177 2014-11-20  Beth Dakin  <bdakin@apple.com>
2178
2179         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
2180         https://bugs.webkit.org/show_bug.cgi?id=138568
2181         -and corresponding-
2182         rdar://problem/18904600
2183
2184         Reviewed by Tim Horton.
2185
2186         Skip images for lookup.
2187         * WebView/WebActionMenuController.mm:
2188         (performDictionaryLookupForRange):
2189
2190 2014-11-19  Beth Dakin  <bdakin@apple.com>
2191
2192         Invoking an action menu on a selection should result in the text menu
2193         https://bugs.webkit.org/show_bug.cgi?id=138892
2194         -and corresponding-
2195         rdar://problem/18996776
2196
2197         Reviewed by Tim Horton.
2198
2199         * WebView/WebActionMenuController.mm:
2200         (-[WebActionMenuController _defaultMenuItems]):
2201
2202 2014-11-19  Beth Dakin  <bdakin@apple.com>
2203
2204         Data detected results with no menu items should not fall through to regular text 
2205         action menus
2206         https://bugs.webkit.org/show_bug.cgi?id=138887
2207         -and corresponding-
2208         rdar://problem/18971616
2209
2210         Reviewed by Tim Horton.
2211
2212         * WebView/WebActionMenuController.mm:
2213         (-[WebActionMenuController _defaultMenuItems]):
2214
2215 2014-11-19  Daniel Bates  <dabates@apple.com>
2216
2217         [iOS] Make WebKit build with public iOS SDK
2218         https://bugs.webkit.org/show_bug.cgi?id=136863
2219
2220         Reviewed by David Kilzer.
2221
2222         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
2223         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
2224         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
2225         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
2226         may be used by Apple internal clients that do not include wtf/Platform.h.
2227         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
2228         private Foundation headers directly.
2229         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
2230         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
2231         instead of including private CFNetwork headers directly. Also fixed up style and
2232         ordering of header include directives.
2233         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
2234         CFNetwork headers directly. Also sort the #import directives.
2235         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
2236         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
2237
2238 2014-11-18  David Kilzer  <ddkilzer@apple.com>
2239
2240         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
2241         <http://webkit.org/b/138813>
2242
2243         Reviewed by Mark Rowe.
2244
2245         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
2246         selectors.
2247
2248 2014-11-18  Chris Dumez  <cdumez@apple.com>
2249
2250         Add a setting to toggle DOMTimer throttling support
2251         https://bugs.webkit.org/show_bug.cgi?id=138844
2252         <rdar://problem/19020874>
2253
2254         Reviewed by Andreas Kling.
2255
2256         Add a setting to disable DOM timers throttling, in order to help
2257         developers determine if a specific issue is caused by timer
2258         throttling.
2259
2260         * WebView/WebPreferenceKeysPrivate.h:
2261         * WebView/WebPreferences.mm:
2262         (+[WebPreferences initialize]):
2263         (-[WebPreferences domTimersThrottlingEnabled]):
2264         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
2265         * WebView/WebPreferencesPrivate.h:
2266         * WebView/WebView.mm:
2267         (-[WebView _preferencesChanged:]):
2268
2269 2014-11-18  Tim Horton  <timothy_horton@apple.com>
2270
2271         Avoid re-encoding action menu image data
2272         https://bugs.webkit.org/show_bug.cgi?id=138817
2273         <rdar://problem/18840382>
2274
2275         Reviewed by Anders Carlsson.
2276
2277         * WebView/WebActionMenuController.mm:
2278         (-[WebActionMenuController _defaultMenuItemsForImage:]):
2279         (-[WebActionMenuController _addImageToPhotos:]):
2280         Build a temporary filename from a UUID and the image's desired extension.
2281         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
2282         Build an image menu only if we have an image, URL, data, and extension.
2283
2284 2014-11-18  Daniel Bates  <dabates@apple.com>
2285
2286         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2287         SPI are not available in public SDK
2288         https://bugs.webkit.org/show_bug.cgi?id=138802
2289
2290         Reviewed by David Kilzer.
2291
2292         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
2293         libdispatch and MobileGestalt headers directly.
2294
2295         * WebView/WebView.mm:
2296
2297 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
2298
2299         Remove calls to deprecated NSMenu methods
2300         https://bugs.webkit.org/show_bug.cgi?id=138808.
2301
2302         Reviewed by Anders Carlsson.
2303
2304         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
2305
2306         * WebCoreSupport/PopupMenuMac.mm:
2307         (PopupMenuMac::populate):
2308
2309 2014-11-17  Daniel Bates  <dabates@apple.com>
2310
2311         Unreviewed, rolling out r176232.
2312
2313         Broke the Mac build. Will investigate offline.
2314
2315         Reverted changeset:
2316
2317         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
2318         MobileGestalt"
2319         https://bugs.webkit.org/show_bug.cgi?id=138802
2320         http://trac.webkit.org/changeset/176232
2321
2322 2014-11-17  Daniel Bates  <dabates@apple.com>
2323
2324         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2325         SPI are not available in public SDK
2326         https://bugs.webkit.org/show_bug.cgi?id=138802
2327
2328         Reviewed by David Kilzer.
2329
2330         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
2331         libdispatch and MobileGestalt headers directly.
2332
2333         * WebView/WebView.mm:
2334
2335 2014-11-17  Beth Dakin  <bdakin@apple.com>
2336
2337         Whitespace action menus should focus the HitTestResult and create an insertion 
2338         point
2339         https://bugs.webkit.org/show_bug.cgi?id=138786
2340         -and corresponding-
2341         rdar://problem/18944893
2342
2343         Reviewed by Tim Horton.
2344
2345         Whitespace menus should cause the HitTestResult to be focused, and they should set 
2346         the selection based on the HitTest location.
2347
2348         * WebView/WebActionMenuController.mm:
2349         (-[WebActionMenuController isMenuForTextContent]):
2350         (-[WebActionMenuController focusAndSelectHitTestResult]):
2351         (-[WebActionMenuController willOpenMenu:withEvent:]):
2352
2353 2014-11-17  Daniel Bates  <dabates@apple.com>
2354
2355         [iOS] QuartzCore SPI not available in public SDK
2356         https://bugs.webkit.org/show_bug.cgi?id=138751
2357
2358         Reviewed by David Kilzer.
2359
2360         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
2361
2362         * WebInspector/WebNodeHighlight.mm:
2363         * WebView/WebIndicateLayer.mm:
2364
2365 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
2366
2367         [iOS] allow host application to opt-out of alternate fullscreen
2368         https://bugs.webkit.org/show_bug.cgi?id=138787
2369
2370         Reviewed by Darin Adler.
2371
2372         * WebView/WebPreferenceKeysPrivate.h:
2373         * WebView/WebPreferences.mm:
2374         (+[WebPreferences initialize]):
2375         (-[WebPreferences allowsAlternateFullscreen]):
2376         (-[WebPreferences setAllowsAlternateFullscreen:]):
2377         * WebView/WebPreferencesPrivate.h:
2378         * WebView/WebView.mm:
2379         (-[WebView _preferencesChanged:]):
2380
2381 2014-11-16  Tim Horton  <timothy_horton@apple.com>
2382
2383         Use TextIndicator instead of the built in Lookup highlight
2384         https://bugs.webkit.org/show_bug.cgi?id=138775
2385         <rdar://problem/18953982>
2386
2387         Reviewed by Anders Carlsson.
2388
2389         * WebCoreSupport/WebSystemInterface.mm:
2390         (InitWebCoreSystemInterface):
2391         Remove a WKSI import.
2392
2393         * WebView/WebActionMenuController.mm:
2394         (-[WebActionMenuController _lookupText:]):
2395         (-[WebActionMenuController _createActionMenuItemForTag:]):
2396         Make use of the new Lookup SPI header.
2397         Disable the Lookup item if lookup is not available.
2398
2399 2014-11-15  Tim Horton  <timothy_horton@apple.com>
2400
2401         Implement data detectors and mailto action menus for WebKit1
2402         https://bugs.webkit.org/show_bug.cgi?id=138765
2403         <rdar://problem/18877535>
2404
2405         Reviewed by Beth Dakin.
2406
2407         * WebView/WebActionMenuController.h:
2408         * WebView/WebActionMenuController.mm:
2409         (-[WebActionMenuController willOpenMenu:withEvent:]):
2410         Tell DataDetectors that the menu is going to open.
2411         Select the text (or not) based on the number of items in the menu, just like WebKit2.
2412
2413         (-[WebActionMenuController didCloseMenu:withEvent:]):
2414         Tell DataDetectors that the menu closed.
2415
2416         (-[WebActionMenuController _defaultMenuItemsForLink]):
2417         Move these checks out of _defaultMenuItemsForLink, because we expect this
2418         to always return a complete link menu.
2419
2420         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
2421         Implement. More or less copied from WebKit2.
2422
2423         (-[WebActionMenuController _selectDataDetectedText]):
2424         Select the stashed range.
2425
2426         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2427         Implement. More or less copied from WebKit2.
2428         The yellow highlight isn't hooked up yet.
2429         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
2430
2431         (-[WebActionMenuController _selectLookupText]):
2432         Remove an unnecessary return.
2433
2434         (-[WebActionMenuController _defaultMenuItems]):
2435         Call into the two new menu types.
2436
2437         * WebView/WebUIDelegatePrivate.h:
2438
2439 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
2440
2441         Get rid of WebFontCache
2442         https://bugs.webkit.org/show_bug.cgi?id=134752
2443
2444         Reviewed by Dave Hyatt.
2445
2446         * WebView/WebHTMLView.mm:
2447
2448 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
2449
2450         Update some artwork for the legacy WebKit action menu
2451         https://bugs.webkit.org/show_bug.cgi?id=138758
2452         <rdar://problem/18989840>
2453
2454         * WebView/WebActionMenuController.mm:
2455         (webKitBundleImageNamed): Deleted.
2456         Fix the build.
2457
2458 2014-11-14  Tim Horton  <timothy_horton@apple.com>
2459
2460         Update some artwork for the legacy WebKit action menu
2461         https://bugs.webkit.org/show_bug.cgi?id=138758
2462         <rdar://problem/18989840>
2463
2464         Reviewed by Simon Fraser.
2465
2466         * WebView/WebActionMenuController.mm:
2467         (-[WebActionMenuController _createActionMenuItemForTag:]):
2468
2469 2014-11-14  Daniel Bates  <dabates@apple.com>
2470
2471         [iOS] NSFileManager and QuickLook SPI not available in public SDK
2472         https://bugs.webkit.org/show_bug.cgi?id=138742
2473
2474         Reviewed by Pratik Solanki.
2475
2476         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
2477
2478         * WebCoreSupport/WebFrameLoaderClient.mm:
2479
2480 2014-11-14  Beth Dakin  <bdakin@apple.com>
2481
2482         WK1: Webpage preview can come up in wrong location
2483         https://bugs.webkit.org/show_bug.cgi?id=138747
2484         -and corresponding-
2485         rdar://problem/18979004
2486
2487         Reviewed by Tim Horton.
2488
2489         Converting to window twice is bad.
2490         * WebView/WebActionMenuController.mm:
2491         (elementBoundingBoxInWindowCoordinatesFromNode):
2492         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2493         (elementBoundingBoxFromNode): Deleted.
2494
2495 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
2496
2497         Move FontMac and FontCacheMac off of WKSI
2498         https://bugs.webkit.org/show_bug.cgi?id=138633
2499
2500         Reviewed by Simon Fraser.
2501
2502         * WebCoreSupport/WebSystemInterface.mm:
2503         (InitWebCoreSystemInterface):
2504         * WebKit.order:
2505
2506 2014-11-13  Beth Dakin  <bdakin@apple.com>
2507
2508         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
2509         https://bugs.webkit.org/show_bug.cgi?id=138716
2510         -and corresponding-
2511         rdar://problem/18977222
2512
2513         Reviewed by Tim Horton.
2514
2515         It’s not necessary to use the WebElementDictionary for so many things now that we 
2516         are caching the HitTestResult. We should just use the HitTestResult.
2517
2518         * WebView/WebActionMenuController.mm:
2519         (-[WebActionMenuController prepareForMenu:withEvent:]):
2520         (-[WebActionMenuController _openURLFromActionMenu:]):
2521         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2522         (elementBoundingBoxFromNode):
2523         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2524         (-[WebActionMenuController _defaultMenuItemsForLink]):
2525         (-[WebActionMenuController _defaultMenuItemsForImage]):
2526         (-[WebActionMenuController _defaultMenuItemsForVideo]):
2527         (-[WebActionMenuController _defaultMenuItemsForText]):
2528         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
2529         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
2530         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
2531         (-[WebActionMenuController _createActionMenuItemForTag:]):
2532         (-[WebActionMenuController _defaultMenuItems]):
2533         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
2534         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
2535         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
2536         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
2537         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
2538         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
2539         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
2540         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
2541         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
2542         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
2543
2544 2014-11-13  Daniel Bates  <dabates@apple.com>
2545
2546         [iOS] NSGeometry data types are not available in the public SDK
2547         https://bugs.webkit.org/show_bug.cgi?id=137536
2548
2549         Reviewed by David Kilzer.
2550
2551         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
2552         private header.
2553
2554         * DOM/WebDOMOperationsPrivate.h:
2555
2556 2014-11-13  Beth Dakin  <bdakin@apple.com>
2557
2558         WK1: Support default actions for video
2559         https://bugs.webkit.org/show_bug.cgi?id=138713
2560         -and corresponding-
2561         rdar://problem/18877520
2562
2563         Reviewed by Tim Horton.
2564
2565         Call setToNonShadowAncestor() for media HitTestResults.
2566         * WebView/WebActionMenuController.mm:
2567         (-[WebActionMenuController performHitTestAtPoint:]):
2568
2569         Default items and actions.
2570         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
2571         (-[WebActionMenuController _copyVideoURL:]):
2572         (-[WebActionMenuController _saveVideoToDownloads:]):
2573         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2574         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2575         * WebView/WebUIDelegatePrivate.h:
2576
2577 2014-11-13  Tim Horton  <timothy_horton@apple.com>
2578
2579         WK1: Update icon for Add to Reading List
2580         https://bugs.webkit.org/show_bug.cgi?id=138710
2581         <rdar://problem/18975774>
2582
2583         Reviewed by Beth Dakin.
2584
2585         * WebView/WebActionMenuController.mm:
2586         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2587         Use the right icon, matching WebKit2.
2588
2589 2014-11-12  Beth Dakin  <bdakin@apple.com>
2590
2591         WK1: Support default actions for images
2592         https://bugs.webkit.org/show_bug.cgi?id=138668
2593         -and corresponding-
2594         rdar://problem/18785434
2595
2596         Reviewed by Tim Horton.
2597
2598         * WebView/WebActionMenuController.h:
2599         * WebView/WebActionMenuController.mm:
2600         (-[WebActionMenuController didCloseMenu:withEvent:]):
2601         (-[WebActionMenuController _defaultMenuItemsForImage:]):
2602         (-[WebActionMenuController _copyImage:]):
2603         (temporaryPhotosDirectoryPath):
2604         (pathToPhotoOnDisk):
2605         (-[WebActionMenuController _canAddMediaToPhotos]):
2606         (-[WebActionMenuController _addImageToPhotos:]):
2607         (-[WebActionMenuController _saveImageToDownloads:]):
2608         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
2609         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
2610         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2611         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2612         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2613         * WebView/WebUIDelegatePrivate.h:
2614
2615 2014-11-11  Beth Dakin  <bdakin@apple.com>
2616
2617         Action menu hit testing is not working properly with all WK1 apps
2618         https://bugs.webkit.org/show_bug.cgi?id=138643
2619         -and corresponding-
2620         rdar://problem/18949376
2621
2622         Reviewed by Tim Horton.
2623
2624         * WebView/WebActionMenuController.mm:
2625         (-[WebActionMenuController prepareForMenu:withEvent:]):
2626         (-[WebActionMenuController _lookupText:]):
2627
2628 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2629
2630         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
2631         https://bugs.webkit.org/show_bug.cgi?id=138623
2632
2633         Reviewed by Geoff Garen.
2634
2635         * WebCoreSupport/WebSystemInterface.mm:
2636         (InitWebCoreSystemInterface):
2637         * WebKit.order:
2638
2639 2014-11-11  Tim Horton  <timothy_horton@apple.com>
2640
2641         Localize strings for action menus
2642         https://bugs.webkit.org/show_bug.cgi?id=138591
2643         <rdar://problem/18815343>
2644
2645         Reviewed by Dan Bates.
2646
2647         * WebView/WebActionMenuController.mm:
2648         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2649         Make use of the new strings.
2650
2651 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2652
2653         Cleanup from r175379
2654         https://bugs.webkit.org/show_bug.cgi?id=138616
2655
2656         Reviewed by Simon Fraser.
2657
2658         * WebCoreSupport/WebSystemInterface.mm:
2659         (InitWebCoreSystemInterface):
2660         * WebKit.order:
2661
2662 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2663
2664         Move CTFontTransformGlyphs out from WKSI
2665         https://bugs.webkit.org/show_bug.cgi?id=138599
2666
2667         Reviewed by Simon Fraser.
2668
2669         * WebCoreSupport/WebSystemInterface.mm:
2670         (InitWebCoreSystemInterface):
2671         * WebKit.order:
2672
2673 2014-11-11  Dan Bernstein  <mitz@apple.com>
2674
2675         More iOS build fix.
2676
2677         * WebView/WebHTMLViewInternal.h:
2678
2679 2014-11-11  Dan Bernstein  <mitz@apple.com>
2680
2681         iOS build fix.
2682
2683         * WebView/WebHTMLView.mm:
2684
2685 2014-11-10  Beth Dakin  <bdakin@apple.com>
2686
2687         WK1: Support default actions for editable text with misspelled word
2688         https://bugs.webkit.org/show_bug.cgi?id=138590
2689         -and corresponding-
2690         rdar://problem/18877506
2691
2692         Reviewed by Tim Horton.
2693
2694         If there are misspelled word suggestions for editable text, create a new type of 
2695         menu with a spelling suggestion sub-menu.
2696
2697         * WebView/WebActionMenuController.mm:
2698         (-[WebActionMenuController isMenuForTextContent]):
2699         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
2700         (-[WebActionMenuController _changeSelectionToSuggestion:]):
2701         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2702         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2703         * WebView/WebHTMLView.mm:
2704         (-[WebHTMLView _changeSpellingToWord:]):
2705         * WebView/WebHTMLViewInternal.h:
2706         * WebView/WebUIDelegatePrivate.h:
2707
2708 2014-11-10  Beth Dakin  <bdakin@apple.com>
2709
2710         WK1: Support default actions for editable whitespace
2711         https://bugs.webkit.org/show_bug.cgi?id=138586
2712         -and corresponding-
2713         rdar://problem/18932048
2714
2715         Reviewed by Tim Horton.
2716
2717         New menu type. Just wants paste.
2718
2719         * WebView/WebActionMenuController.mm:
2720         (-[WebActionMenuController isMenuForTextContent]):
2721         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
2722         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2723         * WebView/WebUIDelegatePrivate.h:
2724
2725 2014-11-10  Beth Dakin  <bdakin@apple.com>
2726
2727         WK1: Support default actions for editable text
2728         https://bugs.webkit.org/show_bug.cgi?id=138580
2729         -and corresponding-
2730         rdar://problem/18877497
2731
2732         Reviewed by Tim Horton.
2733
2734         New menu type, and new action type for paste. 
2735
2736         * WebView/WebActionMenuController.mm:
2737         (-[WebActionMenuController isMenuForTextContent]):
2738         (-[WebActionMenuController willOpenMenu:withEvent:]):
2739         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
2740         (-[WebActionMenuController _paste:]):
2741         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2742         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2743         * WebView/WebUIDelegatePrivate.h:
2744
2745 2014-11-10  Beth Dakin  <bdakin@apple.com>
2746
2747         WK1: Text is getting selected even when an action menu fails to invoke
2748         https://bugs.webkit.org/show_bug.cgi?id=138576
2749         -and corresponding-
2750         rdar://problem/18931330
2751
2752         Reviewed by Tim Horton.
2753
2754         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
2755         * WebView/WebActionMenuController.h:
2756         * WebView/WebActionMenuController.mm:
2757         (-[WebActionMenuController prepareForMenu:withEvent:]):
2758         (-[WebActionMenuController willOpenMenu:withEvent:]):
2759
2760         _selectLookupText no longer needs to return a BOOL indicating success or failure.
2761         (-[WebActionMenuController _selectLookupText]):
2762         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2763
2764         Pass willOpenMenu: on to the controller.
2765         * WebView/WebView.mm:
2766         (-[WebView willOpenMenu:withEvent:]):
2767
2768 2014-11-10  Beth Dakin  <bdakin@apple.com>
2769
2770         Speculative build fix.
2771
2772         * WebView/WebActionMenuController.mm:
2773
2774 2014-11-10  Beth Dakin  <bdakin@apple.com>
2775
2776         Action menu initialization should be moved to _commonInitializationWithFrameName
2777         https://bugs.webkit.org/show_bug.cgi?id=138572
2778         -and corresponding-
2779         rdar://problem/18929733
2780
2781         Reviewed by Tim Horton.
2782
2783         * WebView/WebView.mm:
2784         (-[WebView _commonInitializationWithFrameName:groupName:]):
2785         (-[WebView _initWithFrame:frameName:groupName:]):
2786
2787 2014-11-10  Beth Dakin  <bdakin@apple.com>
2788
2789         WK1: Support default actions for read-only text
2790         https://bugs.webkit.org/show_bug.cgi?id=138552
2791         -and corresponding-
2792         rdar://problem/18877483
2793
2794         Reviewed by Tim Horton.
2795
2796         New WKSystemInterface functions that WebCore needs to use.
2797         * WebCoreSupport/WebSystemInterface.mm:
2798         (InitWebCoreSystemInterface):
2799
2800         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
2801         makes a lot of things easier.
2802         * WebView/WebActionMenuController.h:
2803         * WebView/WebActionMenuController.mm:
2804
2805         Perform the hit test ourselves instead of calling into WebView so that we can more 
2806         easily save the WebCore::HitTestResult for ourselves.
2807         (-[WebActionMenuController performHitTestAtPoint:]):
2808
2809         Clear selection for non-text menus.
2810         (-[WebActionMenuController prepareForMenu:withEvent:]):
2811
2812         Re-set the _type here just to be safe.
2813         (-[WebActionMenuController didCloseMenu:withEvent:]):
2814
2815         Moving this method to be next to the link actions so they can be within a pragma 
2816         mark.
2817         (-[WebActionMenuController _defaultMenuItemsForLink:]):
2818
2819         New method for default text actions — lookup and copy.
2820         (-[WebActionMenuController _defaultMenuItemsForText:]):
2821         (-[WebActionMenuController _copySelection:]):
2822         (-[WebActionMenuController _lookupText:]):
2823
2824         If there is not already a selection, invoking the action menu on text should 
2825         select the lookup text.
2826         (-[WebActionMenuController _selectLookupText]):
2827         (performDictionaryLookupForSelection):
2828         (performDictionaryLookupForRange):
2829
2830         Handle text now.
2831         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2832         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2833
2834         New enum values.
2835         * WebView/WebUIDelegatePrivate.h:
2836
2837         Pass didCloseMenu on to the controller.
2838         * WebView/WebView.mm:
2839         (-[WebView didCloseMenu:withEvent:]):
2840
2841 2014-11-09  Chris Dumez  <cdumez@apple.com>
2842
2843         Add a more correct way to compare floating point numbers and use it
2844         https://bugs.webkit.org/show_bug.cgi?id=138527
2845
2846         Reviewed by Darin Adler.
2847
2848         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
2849         to compare floating-point numbers.
2850
2851         * WebView/WebHTMLView.mm:
2852         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
2853
2854 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
2855
2856         Delete cookies between tests
2857         https://bugs.webkit.org/show_bug.cgi?id=138528
2858
2859         Reviewed by Sam Weinig.
2860
2861         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
2862         * WebView/WebPreferencesPrivate.h:
2863         Added an SPI for DumpRenderTree.
2864
2865 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
2866
2867         [iOS] Update optimized fullscreen media controls
2868         https://bugs.webkit.org/show_bug.cgi?id=138493
2869
2870         Reviewed by Brent Fulgham.
2871
2872         * WebCoreSupport/WebSystemInterface.mm:
2873         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
2874
2875 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
2876
2877         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
2878         https://bugs.webkit.org/show_bug.cgi?id=138443
2879
2880         Reviewed by Anders Carlsson.
2881
2882         Wrapping the dealloc method in its own autorelease pool avoids the problem of
2883         complex tear-downs leading to the WebView itself being added to an autorelease
2884         pool that is not drained until after the instance has been dealloc'd.
2885  
2886         * WebView/WebView.mm:
2887         (-[WebView dealloc]):
2888
2889 2014-11-05  Jer Noble  <jer.noble@apple.com>
2890
2891         De-templatize Timer
2892         https://bugs.webkit.org/show_bug.cgi?id=138450
2893
2894         Reviewed by Anders Carlsson.
2895
2896         Remove template specifiers from Timer.
2897
2898         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2899         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2900         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2901         * Plugins/WebNetscapePluginStream.h:
2902         * Plugins/WebNetscapePluginStream.mm:
2903         (WebNetscapePluginStream::deliverDataTimerFired):
2904
2905 2014-11-05  Dan Bernstein  <mitz@apple.com>
2906
2907         Remove the unused deletion UI feature
2908         https://bugs.webkit.org/show_bug.cgi?id=138442
2909
2910         Rubber-stamped by Alexey Proskuryakov.
2911
2912         * DefaultDelegates/WebDefaultEditingDelegate.m:
2913         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
2914         * WebCoreSupport/WebEditorClient.h:
2915         * WebCoreSupport/WebEditorClient.mm:
2916         (WebEditorClient::shouldShowDeleteInterface): Deleted.
2917         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
2918         -webView:shouldShowDeleteInterfaceForElement:.
2919
2920 2014-11-03  Dean Jackson  <dino@apple.com>
2921
2922         Add ENABLE_FILTERS_LEVEL_2 feature guard.
2923         https://bugs.webkit.org/show_bug.cgi?id=138362
2924
2925         Reviewed by Tim Horton.
2926
2927         Add a new feature define for Level 2 of CSS Filters.
2928         http://dev.w3.org/fxtf/filters-2/
2929
2930         * Configurations/FeatureDefines.xcconfig:
2931
2932 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
2933
2934         Add button and enable optimized fullscreen.
2935         https://bugs.webkit.org/show_bug.cgi?id=138351
2936
2937         Reviewed by Eric Carlson.
2938
2939         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
2940
2941         * WebCoreSupport/WebSystemInterface.mm:
2942         (InitWebCoreSystemInterface): added
2943
2944 2014-11-04  Chris Dumez  <cdumez@apple.com>
2945
2946         Add ptr() method to Ref class
2947         https://bugs.webkit.org/show_bug.cgi?id=138361
2948
2949         Reviewed by Darin Adler.
2950
2951         Use the new Ref::ptr() method.
2952
2953         * WebView/WebFrame.mm:
2954         (-[WebFrame _setTypingStyle:withUndoAction:]):
2955         * WebView/WebHTMLView.mm:
2956         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
2957         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
2958         * WebView/WebView.mm:
2959         (-[WebView applyStyle:]):
2960
2961 2014-11-04  Darin Adler  <darin@apple.com>
2962
2963         Eliminate ResourceBuffer and use SharedBuffer directly instead
2964         https://bugs.webkit.org/show_bug.cgi?id=138174
2965
2966         Reviewed by Antti Koivisto.
2967
2968         * WebView/WebDataSource.mm:
2969         (-[WebDataSource data]): Use SharedBuffer directly.
2970         * WebView/WebHTMLView.mm:
2971         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2972
2973 2014-11-03  Commit Queue  <commit-queue@webkit.org>
2974
2975         Unreviewed, rolling out r175406, r175413, and r175423.
2976         https://bugs.webkit.org/show_bug.cgi?id=138327
2977
2978         Multipart tests are still broken (Requested by ap on #webkit).
2979
2980         Reverted changesets:
2981
2982         "Eliminate ResourceBuffer and use SharedBuffer directly
2983         instead"
2984         https://bugs.webkit.org/show_bug.cgi?id=138174
2985         http://trac.webkit.org/changeset/175406
2986
2987         "Unreviewed, iOS build fix since 175406."
2988         http://trac.webkit.org/changeset/175413
2989
2990         "Fix assertion in CachedResource::addDataBuffer"
2991         http://trac.webkit.org/changeset/175423
2992
2993 2014-10-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2994
2995         Use std::unique_ptr for TypeCountSet
2996         https://bugs.webkit.org/show_bug.cgi?id=138242
2997
2998         Reviewed by Andreas Kling.
2999
3000         * Misc/WebCoreStatistics.mm:
3001         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr.
3002         (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto.
3003
3004 2014-10-31  Beth Dakin  <bdakin@apple.com>
3005
3006         Use system art for action menus when possible
3007         https://bugs.webkit.org/show_bug.cgi?id=138260
3008
3009         Reviewed by Tim Horton.
3010
3011         * WebView/WebActionMenuController.mm:
3012         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3013
3014 2014-10-30  Darin Adler  <darin@apple.com>
3015
3016         Eliminate ResourceBuffer and use SharedBuffer directly instead
3017         https://bugs.webkit.org/show_bug.cgi?id=138174
3018
3019         Reviewed by Antti Koivisto.
3020
3021         * WebView/WebDataSource.mm:
3022         (-[WebDataSource data]): Use SharedBuffer directly.
3023         * WebView/WebHTMLView.mm:
3024         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3025
3026 2014-10-30  Jer Noble  <jer.noble@apple.com>
3027
3028         [EME] Add Setting for accessing storage location for MediaKeys data
3029         https://bugs.webkit.org/show_bug.cgi?id=138147
3030
3031         Reviewed by Brady Eidson.
3032
3033         * WebView/WebPreferenceKeysPrivate.h:
3034         * WebView/WebPreferences.mm:
3035         (+[WebPreferences initialize]): Set default location.
3036         (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor.
3037         (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter.
3038         * WebView/WebPreferencesPrivate.h:
3039         * WebView/WebView.mm:
3040         (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings.
3041
3042 2014-10-30  Dana Burkart  <dburkart@apple.com>
3043
3044         <rdar://problem/18821260> Prepare for the mysterious future
3045
3046         Reviewed by Lucas Forschler.
3047
3048         * Configurations/Base.xcconfig:
3049         * Configurations/DebugRelease.xcconfig:
3050         * Configurations/FeatureDefines.xcconfig:
3051         * Configurations/Version.xcconfig:
3052
3053 2014-10-28  Jeremy Jones  <jeremyj@apple.com>
3054
3055         Add optimized fullscreen mode.
3056         https://bugs.webkit.org/show_bug.cgi?id=138044
3057
3058         Reviewed by Jer Noble.
3059
3060         Enable different types of fullscreen video behavior.
3061         Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
3062
3063         * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
3064         * WebCoreSupport/WebChromeClient.mm:
3065         (WebChromeClient::enterVideoFullscreenForVideoElement): ditto
3066         * WebView/WebView.mm:
3067         (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
3068         (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.
3069         * WebView/WebViewInternal.h: ditto
3070
3071 2014-10-27  Beth Dakin  <bdakin@apple.com>
3072
3073         Provide a way for WebKit1 clients to override default action menu items
3074         https://bugs.webkit.org/show_bug.cgi?id=138066
3075         -and corresponding-
3076         rdar://problem/18451638
3077
3078         Reviewed by Anders Carlsson.
3079
3080         WebActionMenuController now has an ivar for the WebActionMenuType so that it can 
3081         send that along to clients customizing the menu.
3082         * WebView/WebActionMenuController.h:
3083         * WebView/WebActionMenuController.mm:
3084         (-[WebActionMenuController prepareForMenu:withEvent:]):
3085         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3086
3087         New enum and new SPI to customize menus.
3088         * WebView/WebUIDelegatePrivate.h:
3089
3090 2014-10-24  Benjamin Poulain  <bpoulain@apple.com>
3091
3092         Fix the iOS build
3093
3094         * Configurations/WebKitLegacy.xcconfig:
3095         * WebView/WebView.mm:
3096
3097 2014-10-24  Beth Dakin  <bdakin@apple.com>
3098
3099         Build fix.
3100
3101         * WebView/WebActionMenuController.mm:
3102         (-[WebActionMenuController _openURLFromActionMenu:]):
3103         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
3104         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
3105
3106 2014-10-24  Beth Dakin  <bdakin@apple.com>
3107
3108         WebKit1 should support action menus
3109         https://bugs.webkit.org/show_bug.cgi?id=138032
3110
3111         Reviewed by Tim Horton.
3112
3113         This patch adds basic support for action menus and adds actions for links.
3114
3115         Helper class takes care of all of the action menu work. WebView will forward the 
3116         prepareForMenu: message, and then the helper class takes it from there.
3117         * WebView/WebActionMenuController.h: Added.
3118         * WebView/WebActionMenuController.mm: Added.
3119         (-[WebActionMenuController webViewClosed]):
3120         (-[WebActionMenuController prepareForMenu:withEvent:]):
3121
3122         Selectors for link actions.
3123         (-[WebActionMenuController _openURLFromActionMenu:]):
3124         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
3125         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
3126         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
3127         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3128         (webKitBundleImageNamed):
3129         (-[WebActionMenuController _defaultMenuItemsForLink:]):
3130         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3131
3132         Tags for the action menu items.
3133         * WebView/WebUIDelegatePrivate.h:
3134         * WebView/WebView.mm:
3135
3136         Set the action menu if possible and create the controller.
3137         (-[WebView _initWithFrame:frameName:groupName:]):
3138         (-[WebView _close]):
3139         (-[WebView prepareForMenu:withEvent:]):
3140
3141         WebViewData stores the WebActionMenuHelper
3142         * WebView/WebViewData.h:
3143         * WebView/WebViewData.mm:
3144         (-[WebViewPrivate dealloc]):
3145
3146 2014-10-23  Joseph Pecoraro  <pecoraro@apple.com>
3147
3148         Web Inspector: Provide a way to have alternate inspector agents
3149         https://bugs.webkit.org/show_bug.cgi?id=137901
3150
3151         Reviewed by Brian Burg.
3152
3153         * Configurations/FeatureDefines.xcconfig:
3154
3155 2014-10-23  Tim Horton  <timothy_horton@apple.com>
3156
3157         Add some SPI headers for NSExtension and NSSharingService{Picker}
3158         https://bugs.webkit.org/show_bug.cgi?id=138027
3159
3160         Reviewed by Anders Carlsson.
3161
3162         * Misc/WebSharingServicePickerController.h:
3163         * Misc/WebSharingServicePickerController.mm:
3164         * WebCoreSupport/WebSelectionServiceController.mm:
3165         * WebCoreSupport/WebContextMenuClient.mm:
3166         Fix a sorting issue.
3167         Replace redefinitions with SPI header #imports.
3168
3169 2014-10-23  Tim Horton  <timothy_horton@apple.com>
3170
3171         Crashes under WebSelectionServiceController::hasRelevantSelectionServices
3172         https://bugs.webkit.org/show_bug.cgi?id=138013
3173
3174         Reviewed by Dan Bernstein.
3175
3176         * WebCoreSupport/WebSelectionServiceController.mm:
3177         (WebSelectionServiceController::hasRelevantSelectionServices):
3178         Don't adopt this autoreleased object.
3179
3180 2014-10-22  Chris Dumez  <cdumez@apple.com>
3181
3182         [Mac][WK2] Fix applicationIsSafari() detection
3183         https://bugs.webkit.org/show_bug.cgi?id=137893
3184
3185         Reviewed by Alexey Proskuryakov.
3186
3187         Provide an implementation for FrameLoaderClient's new
3188         needsQuickLookResourceCachingQuirks() that returns
3189         a static flag initialized using
3190         QuickLookMac::computeNeedsQuickLookResourceCachingQuirks().
3191
3192         * WebCoreSupport/WebFrameLoaderClient.h:
3193         * WebCoreSupport/WebFrameLoaderClient.mm:
3194
3195 2014-10-20  Chris Dumez  <cdumez@apple.com>
3196
3197         ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition
3198         https://bugs.webkit.org/show_bug.cgi?id=137797
3199
3200         Reviewed by Darin Adler.
3201
3202         Call ResourceRequest::setDomainForPartitionName() instead of
3203         setPartitionName() as the argument is a domain, not a valid
3204         partition name.
3205
3206         * Misc/WebCache.mm:
3207         (+[WebCache addImageToCache:forURL:forFrame:]):
3208         (+[WebCache removeImageFromCacheForURL:forFrame:]):
3209
3210 2014-10-20  Andy Estes  <aestes@apple.com>
3211
3212         Fix the iOS build.
3213
3214         * WebView/WebFrame.mm:
3215         (-[WebFrame getDictationResultRanges:andMetadatas:]):
3216         (-[WebFrame dictationResultMetadataForRange:]):
3217
3218 2014-10-19  Chris Dumez  <cdumez@apple.com>
3219
3220         Use is<>() / downcast<>() for all remaining RenderObject subclasses
3221         https://bugs.webkit.org/show_bug.cgi?id=137845
3222
3223         Reviewed by Darin Adler.
3224
3225         Use is<>() / downcast<>() for all remaining RenderObject subclasses and 
3226         clean up the surrounding code.
3227
3228         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3229         (-[WebHostedNetscapePluginView pluginHostDied]):
3230         * Plugins/WebBaseNetscapePluginView.mm:
3231         (-[WebBaseNetscapePluginView _windowClipRect]):
3232         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
3233         * WebCoreSupport/WebFrameLoaderClient.mm:
3234         (WebFrameLoaderClient::createPlugin):
3235         (WebFrameLoaderClient::createJavaAppletWidget):
3236
3237 2014-10-17  Tim Horton  <timothy_horton@apple.com>
3238
3239         Build fix for 32-bit Yosemite
3240
3241         * WebCoreSupport/WebContextMenuClient.mm:
3242         (WebContextMenuClient::contextMenuForEvent):
3243         Avoid using NSItemProvider in 32-bit, because it doesn't exist.
3244
3245 2014-10-17  Chris Dumez  <cdumez@apple.com>
3246
3247         Use is<>() / downcast<>() for RenderBox
3248         https://bugs.webkit.org/show_bug.cgi?id=137804
3249
3250         Reviewed by Andreas Kling.
3251
3252         Use is<>() / downcast<>() for RenderBox and clean up the surrounding
3253         code.
3254
3255         * WebCoreSupport/WebContextMenuClient.mm:
3256         (WebContextMenuClient::clientFloatRectForNode):
3257         * WebView/WebFrame.mm:
3258         (-[WebFrame renderedSizeOfNode:constrainedToWidth:]):
3259
3260 2014-10-17  Tim Horton  <timothy_horton@apple.com>
3261
3262         Fix the build with the public SDK.
3263
3264         * WebCoreSupport/WebSelectionServiceController.mm:
3265         We should transition all this SPI to real SPI headers as soon as possible.
3266
3267 2014-10-16  Tim Horton  <timothy_horton@apple.com>
3268
3269         Implement selection services menu for Legacy WebKit
3270         https://bugs.webkit.org/show_bug.cgi?id=137582
3271         <rdar://problem/18604241>
3272
3273         Reviewed by Brady Eidson.
3274
3275         * Misc/WebSharingServicePickerController.h:
3276         Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
3277         Add WebSharingServicePickerClient, which other classes can implement
3278         instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
3279         Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.
3280
3281         * Misc/WebSharingServicePickerController.mm:
3282         Pass in NSSharingServicePickerStyle, so that clients can specify the style.
3283
3284         (-[WebSharingServicePickerController clear]):
3285         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
3286         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
3287         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
3288         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
3289         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
3290         Make use of WebSharingServicePickerClient.
3291
3292         (-[WebSharingServicePickerController sharingService:didShareItems:]):
3293         If we're returned a NSAttributedString, paste it on top of the current selection,
3294         similar to what the WebKit2 implementation currently does.
3295         
3296         * WebCoreSupport/WebChromeClient.h:
3297         * WebCoreSupport/WebChromeClient.mm:
3298         (WebChromeClient::handleTelephoneNumberClick):
3299         (WebChromeClient::handleSelectionServiceClick):
3300         (WebChromeClient::hasRelevantSelectionServices):
3301         Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.
3302
3303         * WebCoreSupport/WebContextMenuClient.h:
3304         * WebCoreSupport/WebContextMenuClient.mm:
3305         (WebContextMenuClient::sharingServicePickerWillBeDestroyed):
3306         (WebContextMenuClient::pageForSharingServicePicker):
3307         (WebContextMenuClient::windowForSharingServicePicker):
3308         (WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
3309         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3310         (WebContextMenuClient::contextMenuForEvent):
3311         (WebContextMenuClient::screenRectForHitTestNode): Deleted.
3312         (WebContextMenuClient::renderedImageForControlledImage): Deleted.
3313         (WebContextMenuClient::clearSharingServicePickerController): Deleted.
3314         Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
3315         having WebSharingServicePickerController tightly bound to it.
3316         Make an NSItemProvider array when instantiating WebSharingServicePickerController
3317         instead of handing it data directly.
3318
3319         * WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
3320         * WebCoreSupport/WebSelectionServiceController.mm: Added.
3321         (WebSelectionServiceController::WebSelectionServiceController):
3322         Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
3323         for selection services.
3324
3325         (WebSelectionServiceController::handleSelectionServiceClick):
3326         Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.
3327
3328         (hasCompatibleServicesForItems):
3329         (WebSelectionServiceController::hasRelevantSelectionServices):
3330         Determine whether or not services are available.
3331
3332         (WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
3333         (WebSelectionServiceController::pageForSharingServicePicker):
3334         (WebSelectionServiceController::windowForSharingServicePicker):
3335         Implement the rest of the WebSharingServicePickerClient overrides.
3336
3337         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
3338         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
3339         These are only useful for image sharing services, so we don't need to
3340         implement them (WebContextMenuClient does, on the other hand).
3341
3342         * WebView/WebView.mm:
3343         (-[WebView _selectionServiceController]):
3344         * WebView/WebViewData.h:
3345         * WebView/WebViewData.mm:
3346         * WebView/WebViewInternal.h:
3347         Keep a WebSelectionServiceController.
3348
3349 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
3350
3351         Improve debug description of WAKViews
3352         https://bugs.webkit.org/show_bug.cgi?id=137716
3353
3354         Reviewed by Simon Fraser.
3355
3356         * WebView/WebView.mm:
3357         (-[WebView _touchEventRegions]): Adding a comment.
3358
3359 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
3360
3361         Addressing post-review comment.
3362         https://bugs.webkit.org/show_bug.cgi?id=137550
3363
3364         Unreviewed.
3365
3366         * WebView/WebHTMLView.mm:
3367         (fontNameForDescription):
3368         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3369
3370 2014-10-14  Chris Dumez  <cdumez@apple.com>
3371
3372         Use is<>() / downcast<>() for RenderImage
3373         https://bugs.webkit.org/show_bug.cgi?id=137683
3374
3375         Reviewed by Mihnea Ovidenie.
3376
3377         Use is<>() / downcast<>() for RenderImage.
3378
3379         * Misc/WebNSPasteboardExtras.mm:
3380         (imageFromElement):
3381         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3382
3383 2014-10-10  Daniel Bates  <dabates@apple.com>
3384
3385         Remove unused classes WebRender{Node, Layer}
3386         https://bugs.webkit.org/show_bug.cgi?id=137628
3387
3388         Reviewed by Simon Fraser.
3389
3390         We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
3391         For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.
3392
3393         * Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list
3394         of excluded source files when building for iOS.
3395         * WebKit.exp: Remove symbol for WebRenderLayer.
3396         * WebKit.mac.exp: Remove symbol for WebRenderNode.
3397         * WebView/WebRenderLayer.h: Removed.
3398         * WebView/WebRenderLayer.mm: Removed.
3399         * WebView/WebRenderNode.h: Removed.
3400         * WebView/WebRenderNode.mm: Removed.
3401
3402 2014-10-10  Chris Dumez  <cdumez@apple.com>
3403
3404         Use is<>() / downcast<>() for RenderBoxModelObject
3405         https://bugs.webkit.org/show_bug.cgi?id=137587
3406
3407         Reviewed by Mihnea Ovidenie.
3408
3409         Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
3410         surrounding code.
3411
3412         * Plugins/WebBaseNetscapePluginView.mm:
3413         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
3414         * WebView/WebRenderLayer.mm:
3415         (-[WebRenderLayer initWithWebFrame:]):
3416
3417 2014-10-09  Dean Jackson  <dino@apple.com>
3418
3419         Remove ENABLE_CSS3_CONDITIONAL_RULES
3420         https://bugs.webkit.org/show_bug.cgi?id=137571
3421
3422         Reviewed by Simon Fraser.
3423
3424         * Configurations/FeatureDefines.xcconfig:
3425
3426 2014-10-09  Tim Horton  <timothy_horton@apple.com>
3427
3428         Add a WebKit1 preference for selection services
3429         https://bugs.webkit.org/show_bug.cgi?id=137498
3430         <rdar://problem/18572699>
3431
3432         Reviewed by Simon Fraser.
3433
3434         * WebView/WebPreferenceKeysPrivate.h:
3435         * WebView/WebPreferences.mm:
3436         (+[WebPreferences initialize]):
3437         (-[WebPreferences serviceControlsEnabled]):
3438         (-[WebPreferences setServiceControlsEnabled:]):
3439         * WebView/WebPreferencesPrivate.h:
3440         * WebView/WebView.mm:
3441         (-[WebView _preferencesChanged:]):
3442         Add and plumb the preference.
3443
3444 2014-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
3445
3446         Remove second-to-last client of WebFontCache
3447         https://bugs.webkit.org/show_bug.cgi?id=137550
3448
3449         Reviewed by Darin Adler.
3450
3451         Use FontCache::getCachedFontData() instead of WebFontCache.
3452
3453         * WebView/WebHTMLView.mm:
3454         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3455
3456 2014-10-09  Chris Dumez  <cdumez@apple.com>
3457
3458         Use is<>() / downcast<>() for Widget subclasses
3459         https://bugs.webkit.org/show_bug.cgi?id=137549
3460
3461         Reviewed by Darin Adler.
3462
3463         Use is<>() / downcast<>() for Widget subclasses and clean up the
3464         surrounding code.
3465
3466         * WebView/WebRenderNode.mm:
3467         (copyRenderNode):
3468         * WebView/WebView.mm:
3469         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
3470
3471 2014-10-07  Christophe Dumez  <cdumez@apple.com>
3472
3473         Use is<>() / downcast<>() for RenderText / RenderTextFragment
3474         https://bugs.webkit.org/show_bug.cgi?id=137476
3475
3476         Reviewed by Darin Adler.
3477
3478         * WebView/WebRenderNode.mm:
3479         (copyRenderNode):
3480
3481 2014-10-06  Dan Bernstein  <mitz@apple.com>
3482
3483         Build fix.
3484
3485         * Misc/WebCache.mm:
3486         (+[WebCache imageForURL:]):
3487
3488 2014-10-06  Chris Dumez  <cdumez@apple.com>
3489
3490         Unreviewed build fix after r174333.
3491
3492         Forgot explicit WebCore:: namespace.
3493
3494         * Misc/WebCache.mm:
3495         (+[WebCache imageForURL:]):
3496
3497 2014-10-05  Christophe Dumez  <cdumez@apple.com>
3498
3499         Use is<>() / downcast<>() for CachedResource subclasses
3500         https://bugs.webkit.org/show_bug.cgi?id=137431
3501
3502         Reviewed by Benjamin Poulain.
3503
3504         Use is<>() / downcast<>() for CachedResource subclasses.
3505
3506         * Misc/WebCache.mm:
3507         (+[WebCache imageForURL:]):
3508
3509 2014-10-02  Daniel Bates  <dabates@apple.com>
3510
3511         Use version number 101000 instead of 10100 for OS X Yosemite
3512         https://bugs.webkit.org/show_bug.cgi?id=137372
3513
3514         Reviewed by Mark Rowe.
3515
3516         The version number for OS X Yosemite is 101000.
3517
3518         * WebView/WebView.mm:
3519         (-[WebView _preferencesChanged:]):
3520
3521 2014-10-02  Tim Horton  <timothy_horton@apple.com>
3522
3523         Move PageOverlay[Controller] to WebCore
3524         https://bugs.webkit.org/show_bug.cgi?id=137164
3525         <rdar://problem/18508258>
3526
3527         Reviewed by Anders Carlsson.
3528
3529         * WebCoreSupport/WebChromeClient.h:
3530         * WebCoreSupport/WebChromeClient.mm:
3531         (WebChromeClient::attachViewOverlayGraphicsLayer):
3532         Add an empty ChromeClient override.
3533
3534 2014-10-01  Christophe Dumez  <cdumez@apple.com>
3535
3536         Have is<>(T*) function do a null check on the pointer argument
3537         https://bugs.webkit.org/show_bug.cgi?id=137333
3538
3539         Reviewed by Gavin Barraclough.
3540
3541         Have is<>(T*) function do a null check on the argument instead of a
3542         simple assertion. This makes sense for 2 reasons:
3543         1. It is more consistent with downcast<>(T*), which will succeed even
3544            if the argument is a nullptr.
3545         2. It simplifies the code a bit as it gets rid of a lot of explicit
3546            null checks.
3547
3548         * WebCoreSupport/WebChromeClient.mm:
3549         (WebChromeClient::focusedElementChanged):
3550         * WebCoreSupport/WebEditorClient.mm:
3551         (WebEditorClient::textFieldDidBeginEditing):
3552         (WebEditorClient::textFieldDidEndEditing):
3553         (WebEditorClient::textDidChangeInTextField):
3554         (WebEditorClient::doTextFieldCommandFromEvent):
3555         (WebEditorClient::textWillBeDeletedInTextField):
3556         (WebEditorClient::textDidChangeInTextArea):
3557         * WebView/WebHTMLRepresentation.mm:
3558         (inputElementFromDOMElement):
3559         (searchForLabelsBeforeElement):
3560         * WebView/WebRenderLayer.mm:
3561         (+[WebRenderLayer nameForLayer:]):
3562
3563 2014-10-01  Mark Rowe  <mrowe@apple.com>
3564
3565         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
3566
3567         Reviewed by Dan Bernstein.
3568
3569         * Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite.
3570
3571 2014-09-30  Chris Dumez  <cdumez@apple.com>
3572
3573         Use is<>() / downcast<>() for Element
3574         https://bugs.webkit.org/show_bug.cgi?id=137241
3575
3576         Reviewed by Andreas Kling.