a8145fb8c01cb2605c87db724663d02659bf9d89
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2014-07-09  Enrica Casucci  <enrica@apple.com>
2
3         Implement Editor::fontAttributesForSelectionStart() or iOS.
4         https://bugs.webkit.org/show_bug.cgi?id=134771
5         <rdar://problem/16167838>
6
7         Reviewed by Ryosuke Niwa.
8
9         * WebView/WebViewPrivate.h:
10
11 2014-07-08  Tim Horton  <timothy_horton@apple.com>
12
13         [WK2] Expose a few drawing/compositing settings on WKPreferences(Private)
14         https://bugs.webkit.org/show_bug.cgi?id=134645
15
16         Reviewed by Dan Bernstein.
17
18         * WebView/WebPreferences.mm:
19         (-[WebPreferences setSubpixelCSSOMElementMetricsEnabled:]):
20         Remove an extra unnecessary space.
21
22 2014-07-03  Daniel Bates  <dabates@apple.com>
23
24         Add WTF::move()
25         https://bugs.webkit.org/show_bug.cgi?id=134500
26
27         Rubber-stamped by Anders Carlsson.
28
29         Substitute WTF::move() for std::move().
30
31         * History/WebHistoryItem.mm:
32         (-[WebHistoryItem initFromDictionaryRepresentation:]):
33         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
34         (WebKit::NetscapePluginInstanceProxy::setCurrentReply):
35         * Plugins/WebNetscapePluginView.mm:
36         (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
37         * WebCoreSupport/WebFrameLoaderClient.mm:
38         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
39         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
40         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
41         (WebFrameLoaderClient::dispatchWillSubmitForm):
42         * WebCoreSupport/WebInspectorClient.mm:
43         (WebInspectorClient::openInspectorFrontend):
44         (WebInspectorFrontendClient::WebInspectorFrontendClient):
45         * WebView/WebArchive.mm:
46         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
47
48 2014-07-01  Mark Rowe  <mrowe@apple.com>
49
50         <https://webkit.org/b/134522> Remove duplication in code that prepares the user agent string on Mac and iOS
51
52         Reviewed by Simon Fraser.
53
54         * WebView/WebView.mm:
55         (webKitBundleVersionString): Return the entire CFBundleVersion now that WebCore handles formatting it.
56         (+[WebView _standardUserAgentWithApplicationName:]):
57
58 2014-07-02  Dan Bernstein  <mitz@apple.com>
59
60         Remove some code only needed for versions of Safari that are no longer supported
61         https://bugs.webkit.org/show_bug.cgi?id=134537
62
63         Reviewed by Anders Carlsson.
64
65         * History/WebHistoryItem.mm:
66         * Misc/WebKitVersionChecks.h:
67         * WebCoreSupport/WebSecurityOrigin.mm:
68         (-[WebSecurityOrigin domain]): Deleted.
69         * WebInspector/WebInspector.mm:
70         (-[WebInspector showTimeline:]): Deleted.
71         (+[WebInspector webInspector]): Deleted.
72         (-[WebInspector setWebFrame:]): Deleted.
73         (-[WebInspector window]): Deleted.
74         (-[WebInspector showWindow:]): Deleted.
75         * WebView/WebFrame.mm:
76         (-[WebFrame reload]):
77         * WebView/WebPDFView.mm:
78         (-[WebPDFView menuForEvent:]):
79         (-[WebPDFView _anyPDFTagsFoundInMenu:]): Deleted.
80         * WebView/WebView.mm:
81         (-[WebView _initWithFrame:frameName:groupName:]):
82         (-[WebView _preferencesChanged:]):
83         (-[WebView initWithFrame:frameName:groupName:]):
84         (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]): Deleted.
85         (+[WebView _setAlwaysUseATSU:]): Deleted.
86         (-[WebView _needsUnrestrictedGetMatchedCSSRules]): Deleted.
87         * WebView/WebViewPrivate.h:
88
89 2014-07-01  Dan Bernstein  <mitz@apple.com>
90
91         Remove WebChromeClient code that was only needed for Safari versions earlier than 3.1
92         https://bugs.webkit.org/show_bug.cgi?id=134531
93
94         Reviewed by Daniel Bates.
95
96         * WebCoreSupport/WebChromeClient.mm:
97         (WebChromeClient::exceededDatabaseQuota):
98
99 2014-06-29  Yoav Weiss  <yoav@yoav.ws>
100
101         Add support for HTMLImageElement's sizes attribute
102         https://bugs.webkit.org/show_bug.cgi?id=133620
103
104         Reviewed by Dean Jackson.
105
106         Added an ENABLE_PICTURE_SIZES compile flag.
107
108         * Configurations/FeatureDefines.xcconfig:
109
110 2014-06-27  Sam Weinig  <sam@webkit.org>
111
112         InfoClick (from Nisus Software) dies on viewing found items
113         <rdar://problem/17395601>
114         https://bugs.webkit.org/show_bug.cgi?id=134410
115
116         Reviewed by Andy Estes.
117
118         InfoClick was calling -[WebPreferences setPrivateBrowsingEnabled:] before
119         setting up a WebView (or anything else that would have set up WebKitSystemInterface),
120         which now requires a set up WebKitSystemInterface. We can fix this by initializing
121         it from +[WebPreferences initialize].
122
123         * WebView/WebPreferences.mm:
124         (+[WebPreferences initialize]):
125         Add call to InitWebCoreSystemInterface().
126
127         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
128         Remove now unnecessary call to InitWebCoreSystemInterface().
129
130 2014-06-27  Peyton Randolph  <prandolph@apple.com>
131
132         Add feature flag for link long-press gesture.
133         https://bugs.webkit.org/show_bug.cgi?id=134262
134
135         Reviewed by Enrica Casucci.
136
137         * Configurations/FeatureDefines.xcconfig:
138         Add ENABLE_LINK_LONG_PRESS.
139
140 2014-06-26  Brady Eidson  <beidson@apple.com>
141
142         Remove use of PlatformStrategies for Gamepad API.
143         https://bugs.webkit.org/show_bug.cgi?id=134348
144
145         Reviewed by Dean Jackson.
146
147         Remove all the GamepadStrategy gunk:
148         * WebCoreSupport/WebHIDGamepadController.mm: Removed.
149         * WebCoreSupport/WebPlatformStrategies.h:
150         * WebCoreSupport/WebPlatformStrategies.mm:
151         (WebPlatformStrategies::createGamepadStrategy): Deleted.
152         (WebPlatformStrategies::startMonitoringGamepads): Deleted.
153         (WebPlatformStrategies::stopMonitoringGamepads): Deleted.
154         (WebPlatformStrategies::platformGamepads): Deleted.
155
156         Instead, install the HIDGamepadProvider as the shared GamepadProvider:
157         * WebView/WebView.mm:
158         (WebKitInitializeGamepadProviderIfNecessary):
159         (-[WebView _commonInitializationWithFrameName:groupName:]):
160
161 2014-06-26  Joseph Pecoraro  <pecoraro@apple.com>
162
163         [iOS] Remove User Default for iOS TextField Debugging
164         https://bugs.webkit.org/show_bug.cgi?id=134356
165
166         Reviewed by Timothy Hatcher.
167
168         * WebView/WebPreferenceKeysPrivate.h:
169         * WebView/WebView.mm:
170         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
171
172 2014-06-25  Brady Eidson  <beidson@apple.com>
173
174         Add HID-based gamepad implementation for Mac
175         https://bugs.webkit.org/show_bug.cgi?id=134324
176
177         Reviewed by Dean Jackson.
178
179         Add a class that acts as an intermediary between the GamepadStrategyClient
180         and the HIDGamepadListener:
181         * WebCoreSupport/WebHIDGamepadController.h:
182         * WebCoreSupport/WebHIDGamepadController.mm:
183         (WebHIDGamepadController::shared):
184         (WebHIDGamepadController::WebHIDGamepadController):
185         (WebHIDGamepadController::gamepadConnected):
186         (WebHIDGamepadController::gamepadDisconnected):
187         (WebHIDGamepadController::registerGamepadStrategyClient):
188         (WebHIDGamepadController::unregisterGamepadStrategyClient):
189
190         Implement the strategies by using the HIDGamepadListener:
191         * WebCoreSupport/WebPlatformStrategies.mm:
192         (WebPlatformStrategies::startMonitoringGamepads):
193         (WebPlatformStrategies::stopMonitoringGamepads):
194         (WebPlatformStrategies::platformGamepads):
195
196 2014-06-25  Brady Eidson  <beidson@apple.com>
197
198         Add new platform gamepad abstractions
199         https://bugs.webkit.org/show_bug.cgi?id=134325
200
201         Reviewed by Dean Jackson.
202
203         * WebCoreSupport/WebPlatformStrategies.h:
204         * WebCoreSupport/WebPlatformStrategies.mm:
205         (WebPlatformStrategies::createGamepadStrategy):
206         (WebPlatformStrategies::startMonitoringGamepads):
207         (WebPlatformStrategies::stopMonitoringGamepads):
208         (WebPlatformStrategies::platformGamepads):
209
210 2014-06-25  Gavin Barraclough  <baraclough@apple.com>
211
212         Should _updateVisibilityState on view hide/unhide.
213         https://bugs.webkit.org/show_bug.cgi?id=134314
214         rdar://17171803
215
216         Reviewed by Sam Weinig.
217
218         * WebView/WebView.mm:
219         (-[WebView viewDidHide]):
220         (-[WebView viewDidUnhide]):
221
222 2014-06-25  Chris Fleizach  <cfleizach@apple.com>
223
224         Add an undo group for each dictated utterance in WebKit
225         https://bugs.webkit.org/show_bug.cgi?id=134086
226
227         Reviewed by Enrica Casucci.
228
229         * WebView/WebHTMLView.mm:
230         (-[WebHTMLView validAttributesForMarkedText]):
231         (-[WebHTMLView insertText:]):
232
233 2014-06-25  Dana Burkart  <dburkart@apple.com>
234
235         Add support for 5-tuple versioning.
236
237         Reviewed by David Farler.
238
239         * Configurations/Version.xcconfig:
240
241 2014-06-25  Laszlo Gombos  <l.gombos@samsung.com>
242
243         Remove build guard for progress element
244         https://bugs.webkit.org/show_bug.cgi?id=134292
245
246         Reviewed by Benjamin Poulain.
247
248         * Configurations/FeatureDefines.xcconfig:
249
250 2014-06-24  Benjamin Poulain  <bpoulain@apple.com>
251
252         WK1 WebFrameNetworkingContext cleanup: do not instanciate an empty NSString to create an empty WTF::String
253         https://bugs.webkit.org/show_bug.cgi?id=134222
254
255         Reviewed by Andreas Kling.
256
257         * WebCoreSupport/WebFrameNetworkingContext.mm:
258         (WebFrameNetworkingContext::sourceApplicationIdentifier):
259
260 2014-06-24  Joseph Pecoraro  <pecoraro@apple.com>
261
262         [iOS]: WK2 Inspector Node Highlighting
263         https://bugs.webkit.org/show_bug.cgi?id=134257
264
265         Reviewed by Timothy Hatcher.
266
267         * WebInspector/WebNodeHighlightView.mm:
268         (-[WebNodeHighlightView layoutSublayers:]):
269
270 2014-06-24  Brady Eidson  <beidson@apple.com>
271
272         Enable GAMEPAD in the Mac build, but disabled at runtime.
273         https://bugs.webkit.org/show_bug.cgi?id=134255
274
275         Reviewed by Dean Jackson.
276
277         * Configurations/FeatureDefines.xcconfig:
278
279         * WebView/WebPreferenceKeysPrivate.h:
280         * WebView/WebPreferences.mm:
281         (-[WebPreferences gamepadsEnabled]):
282         (-[WebPreferences setGamepadsEnabled:]):
283         * WebView/WebPreferencesPrivate.h:
284
285         * WebView/WebView.mm:
286         (-[WebView _preferencesChanged:]):
287
288 2014-06-24  Dan Bernstein  <mitz@apple.com>
289
290         Fixed the iOS build after r170358.
291
292         * WebView/WebView.mm:
293         (kit):
294
295 2014-06-23  Anders Carlsson  <andersca@apple.com>
296
297         Remove unused history visit code from WebHistoryItem
298         https://bugs.webkit.org/show_bug.cgi?id=134201
299
300         Reviewed by Sam Weinig.
301
302         * History/HistoryPropertyList.h:
303         * History/HistoryPropertyList.mm:
304         (HistoryPropertyListWriter::HistoryPropertyListWriter):
305         (HistoryPropertyListWriter::writeHistoryItem):
306         * History/WebHistory.mm:
307         (-[WebHistoryPrivate visitedURL:withTitle:]):
308         (-[WebHistoryPrivate addItem:discardDuplicate:]):
309         (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
310         (-[WebHistoryPrivate visitedURL:withTitle:increaseVisitCount:]): Deleted.
311         (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]): Deleted.
312         * History/WebHistoryInternal.h:
313         * History/WebHistoryItem.mm:
314         (-[WebHistoryItem copyWithZone:]):
315         (-[WebHistoryItem initFromDictionaryRepresentation:]):
316         (-[WebHistoryItem _visitedWithTitle:]):
317         (-[WebHistoryItem setVisitCount:]): Deleted.
318         (-[WebHistoryItem _mergeAutoCompleteHints:]): Deleted.
319         (-[WebHistoryItem _visitedWithTitle:increaseVisitCount:]): Deleted.
320         (-[WebHistoryItem _recordInitialVisit]): Deleted.
321         (timeToDay): Deleted.
322         (-[WebHistoryItem _padDailyCountsForNewVisit:]): Deleted.
323         (-[WebHistoryItem _collapseDailyVisitsToWeekly]): Deleted.
324         (-[WebHistoryItem _recordVisitAtTime:increaseVisitCount:]): Deleted.
325         (-[WebHistoryItem _setLastVisitedTimeInterval:]): Deleted.
326         * History/WebHistoryItemInternal.h:
327         * History/WebHistoryItemPrivate.h:
328         * WebCoreSupport/WebFrameLoaderClient.mm:
329         (WebFrameLoaderClient::updateGlobalHistory):
330
331 2014-06-24  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
332
333         REGRESSION(r170235): Remove incorrect ifdef guard
334         https://bugs.webkit.org/show_bug.cgi?id=134246
335
336         Reviewed by Csaba Osztrogonác.
337
338         * WebView/WebView.mm:
339         (-[WebView _visibilityState]):
340
341 2014-06-23  Anders Carlsson  <andersca@apple.com>
342
343         Fix build.
344
345         * WebCoreSupport/WebSystemInterface.mm:
346         (InitWebCoreSystemInterface):
347
348 2014-06-21  Dan Bernstein  <mitz@apple.com>
349
350         Tried to fix the iOS build after r170235.
351
352         * WebView/WebView.mm:
353
354 2014-06-21  Brady Eidson  <beidson@apple.com>
355
356         Gamepad API - Deprecate the existing implementation
357         https://bugs.webkit.org/show_bug.cgi?id=134108
358
359         Reviewed by Timothy Hatcher.
360
361         -Add new "GAMEPAD_DEPRECATED" build flag, moving the existing implementation to use it
362         -Move some implementation files into a "deprecated" subdirectory.
363
364         * Configurations/FeatureDefines.xcconfig:
365
366 2014-06-21  Commit Queue  <commit-queue@webkit.org>
367
368         Unreviewed, rolling out r170244.
369         https://bugs.webkit.org/show_bug.cgi?id=134157
370
371         GTK/EFL bindings generator works differently, making this
372         patch not work there.  Will fix entire patch after a rollout.
373         (Requested by bradee-oh on #webkit).
374
375         Reverted changeset:
376
377         "Gamepad API - Deprecate the existing implementation"
378         https://bugs.webkit.org/show_bug.cgi?id=134108
379         http://trac.webkit.org/changeset/170244
380
381 2014-06-21  Brady Eidson  <beidson@apple.com>
382
383         Gamepad API - Deprecate the existing implementation
384         https://bugs.webkit.org/show_bug.cgi?id=134108
385
386         Reviewed by Timothy Hatcher.
387
388         -Add new "GAMEPAD_DEPRECATED" build flag, moving the existing implementation to use it
389         -Add the "Deprecated" suffix to some implementation files
390
391         * Configurations/FeatureDefines.xcconfig:
392
393 2014-06-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
394
395         Removing PAGE_VISIBILITY_API compile guard.
396         https://bugs.webkit.org/show_bug.cgi?id=133844
397
398         Reviewed by Gavin Barraclough.
399
400         * Configurations/FeatureDefines.xcconfig:
401         * WebView/WebView.mm:
402         (-[WebView _preferencesChanged:]):
403         (-[WebView _visibilityState]):
404
405 2014-06-18  Anders Carlsson  <andersca@apple.com>
406
407         Make FrameLoadType a strongly typed enum
408         https://bugs.webkit.org/show_bug.cgi?id=134047
409
410         Reviewed by Andreas Kling.
411
412         * WebView/WebFrame.mm:
413         (toWebFrameLoadType):
414         (-[WebFrame _loadType]):
415         * WebView/WebView.mm:
416         (-[WebView _loadBackForwardListFromOtherView:]):
417         (-[WebView goToBackForwardItem:]):
418
419 2014-06-18  Daniel Bates  <dabates@apple.com>
420
421         REGRESSION (r167856): Unable to log into HSBC app
422         https://bugs.webkit.org/show_bug.cgi?id=133991
423         <rdar://problem/17044839>
424
425         Reviewed by David Kilzer.
426
427         Only enable the setting allowNavigationToInvalidURL for iOS app linked against WebKit/UIKit before iOS 8.
428
429         * Misc/WebKitVersionChecks.h: Added macro constant WEBKIT_FIRST_VERSION_WITH_NAVIGATION_URL_VALIDATION.
430         * WebView/WebView.mm:
431         (-[WebView _preferencesChanged:]): Enable or disable the setting allowNavigationToInvalidURL as appropriate.
432
433 2014-06-18  Anders Carlsson  <andersca@apple.com>
434
435         Adopt modern C++11 loops and fix WebArchive creation functions
436         https://bugs.webkit.org/show_bug.cgi?id=134032
437
438         Reviewed by Andreas Kling.
439
440         * WebView/WebArchive.mm:
441         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
442         * WebView/WebDataSource.mm:
443         (-[WebDataSource subresources]):
444
445 2014-06-15  Anders Carlsson  <andersca@apple.com>
446
447         Add an autorelease() member function to RetainPtr
448         https://bugs.webkit.org/show_bug.cgi?id=133929
449
450         Reviewed by Dan Bernstein.
451
452         * WebView/WebDataSource.mm:
453         (-[WebDataSource data]):
454         * WebView/WebHTMLView.mm:
455         (-[WebHTMLView _selectionDraggingImage]):
456         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
457         * WebView/WebResource.mm:
458         (-[WebResource data]):
459
460 2014-06-11  Jeremy Jones  <jeremyj@apple.com>
461
462         WebFrameNetworkContext should not have a sourceApplicationIdentifier in WK1.
463         https://bugs.webkit.org/show_bug.cgi?id=133772
464
465         Reviewed by Jer Noble.
466
467         Return empty string from sourceApplicationIdentifier for WK1.
468
469         * WebCoreSupport/WebFrameNetworkingContext.mm:
470         (WebFrameNetworkingContext::sourceApplicationIdentifier):
471
472 2014-06-10  Timothy Horton  <timothy_horton@apple.com>
473
474         Factor repeated CFRunLoopObserver code out
475         https://bugs.webkit.org/show_bug.cgi?id=133690
476
477         Reviewed by Simon Fraser.
478
479         * WebView/WebViewData.h:
480
481 2014-06-05  Pratik Solanki  <psolanki@apple.com>
482
483         Remove unsused method _setAcceleratedImageDecoding
484         https://bugs.webkit.org/show_bug.cgi?id=133554
485
486         Reviewed by Jon Honeycutt.
487
488         * WebView/WebView.mm:
489         (+[WebView _setAcceleratedImageDecoding:]): Deleted.
490         * WebView/WebViewPrivate.h:
491
492 2014-06-05  Benjamin Poulain  <bpoulain@apple.com>
493
494         [iOS][WK2] Add device orientation
495         https://bugs.webkit.org/show_bug.cgi?id=133530
496
497         Reviewed by Tim Horton.
498
499         * WebView/WebFrame.mm:
500         (-[WebFrame deviceOrientationChanged]):
501         (-[WebFrame sendOrientationChangeEvent:]):
502         * WebView/WebFramePrivate.h:
503
504 2014-05-31  Anders Carlsson  <andersca@apple.com>
505
506         Change DeferrableOneShotTimer to use std::function instead of being a class template
507         https://bugs.webkit.org/show_bug.cgi?id=133423
508
509         Reviewed by Antti Koivisto.
510
511         * WebView/WebView.mm:
512         (+[WebView _setCacheModel:]):
513
514 2014-05-27  Jon Lee  <jonlee@apple.com>
515
516         Update ENABLE(MEDIA_SOURCE) on Mac
517         https://bugs.webkit.org/show_bug.cgi?id=133141
518
519         Reviewed by Darin Adler.
520
521         * Configurations/FeatureDefines.xcconfig:
522
523 2014-05-27  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
524
525         Remove BLOB guards
526         https://bugs.webkit.org/show_bug.cgi?id=132863
527
528         Reviewed by Csaba Osztrogonác.
529
530         * Configurations/FeatureDefines.xcconfig:
531         * WebView/WebView.mm:
532         (+[WebView _canHandleRequest:forMainFrame:]):
533
534 2014-05-24  Chris Fleizach  <cfleizach@apple.com>
535
536         AX: fix coordinate mapping for iOS accessibility
537         https://bugs.webkit.org/show_bug.cgi?id=133188
538
539         Reviewed by Sam Weinig.
540
541         * WebCoreSupport/WebChromeClient.h:
542         * WebCoreSupport/WebChromeClient.mm:
543         (WebChromeClient::accessibilityScreenToRootView):
544         (WebChromeClient::rootViewToAccessibilityScreen):
545
546 2014-05-23  Jeremy Jones  <jeremyj@apple.com>
547
548         Hide fullscreen immediately when switching tabs.
549         https://bugs.webkit.org/show_bug.cgi?id=133239
550
551         Reviewed by Eric Carlson.
552
553         Renamed a function to better describe it's new functionality.
554
555         * WebView/WebView.mm:
556         (-[WebView viewDidMoveToWindow]):
557         now calls: requestHideAndExitFullscreen
558
559 2014-05-20  Dean Jackson  <dino@apple.com>
560
561         [Mac] Allow popup menus to override default appearance
562         https://bugs.webkit.org/show_bug.cgi?id=133129
563
564         Reviewed by Tim Horton.
565
566         Replace the call to wkPopupMenuWithSize with wkPopupMenu, now
567         with extra parameters to indicate the control size and whether
568         or not to draw the arrows at the end.
569
570         * WebCoreSupport/PopupMenuMac.mm:
571         (PopupMenuMac::show):
572
573 2014-05-20  Eric Carlson  <eric.carlson@apple.com>
574
575         [Mac] do not deactivate an audio session that has running I/O
576         https://bugs.webkit.org/show_bug.cgi?id=133127
577
578         Reviewed by Jer Noble.
579
580         * WebView/WebView.mm:
581         (-[WebView _commonInitializationWithFrameName:groupName:]): Settings::setShouldManageAudioSession
582             renamed to setShouldManageAudioSessionCategory, deal with it.
583
584 2014-05-19  Brady Eidson  <beidson@apple.com>
585
586         Use different AppKit API for image control menus.
587         <rdar://problem/16807828> and https://bugs.webkit.org/show_bug.cgi?id=133087
588
589         Reviewed by Tim Horton.
590
591         For image control menus, use popUpMenuPositioningItem: instead of popUpContextMenu:
592         
593         * WebCoreSupport/WebContextMenuClient.h:
594         * WebCoreSupport/WebContextMenuClient.mm:
595         (WebContextMenuClient::contextMenuForEvent):
596         (WebContextMenuClient::showContextMenu):
597
598 2014-05-19  Andy Estes  <aestes@apple.com>
599
600         Set WebKitSuppressesIncrementalRenderingKey to NO by default on both Mac and iOS
601         https://bugs.webkit.org/show_bug.cgi?id=133073
602
603         Reviewed by Simon Fraser.
604
605         * WebView/WebPreferences.mm:
606         (+[WebPreferences initialize]):
607
608 2014-05-18  Anders Carlsson  <andersca@apple.com>
609
610         Bring back two NSString category methods on iOS
611         https://bugs.webkit.org/show_bug.cgi?id=133055
612         <rdar://problem/16951983>
613
614         Reviewed by Adele Peterson.
615
616         * Misc/WebNSURLExtras.h:
617         * Misc/WebNSURLExtras.mm:
618         (-[NSString _webkit_unescapedQueryValue]):
619         (-[NSString _webkit_queryKeysAndValues]):
620
621 2014-05-18  Rik Cabanier  <cabanier@adobe.com>
622
623         support for navigator.hardwareConcurrency
624         https://bugs.webkit.org/show_bug.cgi?id=132588
625
626         Reviewed by Filip Pizlo.
627
628         * Configurations/FeatureDefines.xcconfig:
629
630 2014-05-17  Zalan Bujtas  <zalan@apple.com>
631
632         Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
633         https://bugs.webkit.org/show_bug.cgi?id=133029
634
635         Reviewed by Simon Fraser.
636
637         To match the WK2 preferences API.
638
639         * WebView/WebPreferenceKeysPrivate.h:
640         * WebView/WebPreferences.mm:
641         (+[WebPreferences initialize]):
642         (-[WebPreferences subpixelCSSOMElementMetricsEnabled]):
643         (-[WebPreferences setSubpixelCSSOMElementMetricsEnabled:]):
644         * WebView/WebPreferencesPrivate.h:
645         * WebView/WebView.mm:
646         (-[WebView _preferencesChanged:]):
647
648 2014-05-16  Simon Fraser  <simon.fraser@apple.com>
649
650         Remove "region-based columns" prefs
651         https://bugs.webkit.org/show_bug.cgi?id=133006
652         <rdar://problem/16945824>
653
654         Reviewed by Dave Hyatt.
655
656         Remove "region-based columns" prefs and related code, since this is only
657         way to render columns now.
658
659         * WebView/WebPreferenceKeysPrivate.h:
660         * WebView/WebPreferences.mm:
661         (+[WebPreferences initialize]):
662         (-[WebPreferences setRegionBasedColumnsEnabled:]): Deleted.
663         (-[WebPreferences regionBasedColumnsEnabled]): Deleted.
664         * WebView/WebPreferencesPrivate.h:
665         * WebView/WebView.mm:
666         (-[WebView _preferencesChanged:]):
667
668 2014-05-15  Brady Eidson  <beidson@apple.com>
669
670         Crash in [WebSharingServicePickerController clear]
671         <rdar://problem/16879073> and https://bugs.webkit.org/show_bug.cgi?id=132968
672
673         Reviewed by Tim Horton.
674
675         * Misc/WebSharingServicePickerController.mm:
676         (-[WebSharingServicePickerController clear]): Add a RetainPtr protector so this object
677           isn’t dealloc’ed partway through.
678
679 2014-05-15  Simon Fraser  <simon.fraser@apple.com>
680
681         Initialize the WebKitRegionBasedColumnsEnabled pref on iOS WK1
682         https://bugs.webkit.org/show_bug.cgi?id=132969
683
684         Reviewed by Dan Bernstein.
685         
686         Move this outside the #if !PLATFORM(IOS) block.
687
688         * WebView/WebPreferences.mm:
689         (+[WebPreferences initialize]):
690
691 2014-05-15  Simon Fraser  <simon.fraser@apple.com>
692
693         Clean up -[WebView _preferencesChanged]
694         https://bugs.webkit.org/show_bug.cgi?id=132967
695
696         Reviewed by Sam Weinig.
697         
698         -[WebView _preferencesChanged] was a horrible mess of #ifdefs. Clean this up by
699         moving all the #if PLATFORM() code together, and moving all the feature-define related
700         settings to the end.
701         
702         No behavior changes, checked by diffing the resulting Settings with and without
703         the patch, on OS X and iOS.
704
705         * WebView/WebView.mm:
706         (-[WebView _preferencesChanged:]):
707
708 2014-05-15  Alex Christensen  <achristensen@webkit.org>
709
710         Add pointer lock to features without enabling it.
711         https://bugs.webkit.org/show_bug.cgi?id=132961
712
713         Reviewed by Sam Weinig.
714
715         * Configurations/FeatureDefines.xcconfig:
716         Added ENABLE_POINTER_LOCK to list of features.
717         * WebView/WebPDFView.mm:
718         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
719         Added extra parameters needed when pointer lock is enabled.
720
721 2014-05-14  Brady Eidson  <beidson@apple.com>
722
723         Implement NSSharingServiceDelegate method "transitionImageForShareItem"
724         <rdar://problem/16878020> and https://bugs.webkit.org/show_bug.cgi?id=132911
725
726         Reviewed by Tim Horton.
727
728         * Misc/WebSharingServicePickerController.mm:
729         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
730
731         * WebCoreSupport/WebContextMenuClient.h:
732         * WebCoreSupport/WebContextMenuClient.mm:
733         (WebContextMenuClient::renderedImageForControlledImage): Paint the entire content rect for the controlled image
734           into an ImageBuffer, then return the resulting NSImage. This only paints the image itself and not any
735           overlapping content by setting the selection and appropriate painting mode.
736
737 2014-05-14  Brady Eidson  <beidson@apple.com>
738
739         sourceFrameOnScreenForShareItem: can be off by a pixel
740         <rdar://problem/16878020> and https://bugs.webkit.org/show_bug.cgi?id=132911
741
742         Reviewed by Simon Fraser.
743
744         In a land of LayoutUnits and sub-pixel rendering, converting between IntRects and
745         FloatRects can be error prone. So we now try to minimize such conversions.
746
747         * Misc/WebSharingServicePickerController.mm:
748         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
749
750         * WebCoreSupport/WebContextMenuClient.h:
751         * WebCoreSupport/WebContextMenuClient.mm:
752         (WebContextMenuClient::clientFloatRectForNode): Split this into a separate utility method
753           as it will be shared with other code very soon. Instead of using absoluteBoundingBoxRect()
754           which does lossy float->int conversions, try to keep things in terms of FloatRects as
755           much as possible.
756         (WebContextMenuClient::screenRectForHitTestNode): Call clientFloatRectForNode to get the
757           FloatRect, then perform the lossy rounding conversion to an IntRect only once.
758
759 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
760
761         Remove CSS_STICKY_POSITION guards
762         https://bugs.webkit.org/show_bug.cgi?id=132676
763
764         Reviewed by Simon Fraser.
765
766         * Configurations/FeatureDefines.xcconfig:
767
768 2014-05-14  Antti Koivisto  <antti@apple.com>
769
770         GIF animations don't restart after scrolling with iOS WebKit1
771         https://bugs.webkit.org/show_bug.cgi?id=132900
772         <rdar://problem/16490858>
773
774         Reviewed by Andreas Kling.
775
776         * WebView/WebView.mm:
777         (-[WebView _didFinishScrollingOrZooming]):
778         
779             Check if the animations need to be restarted after scrolling finishes.
780
781 2014-05-09  Joseph Pecoraro  <pecoraro@apple.com>
782
783         Web Inspector: Allow Remote Inspector to entitlement check UIProcess through WebProcess
784         https://bugs.webkit.org/show_bug.cgi?id=132409
785
786         Reviewed by Timothy Hatcher.
787
788         Simplify the legacy iOS UIWebViewController case by passing on
789         the host process pid and audit_token.
790
791         * WebView/WebView.mm:
792         (-[WebView _setHostApplicationProcessIdentifier:auditToken:]):
793         (-[WebView setHostApplicationBundleId:name:]): Deleted.
794         (-[WebView hostApplicationBundleId]): Deleted.
795         (-[WebView hostApplicationName]): Deleted.
796         * WebView/WebViewData.h:
797         * WebView/WebViewData.mm:
798         (-[WebViewPrivate dealloc]):
799         * WebView/WebViewPrivate.h:
800
801 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
802
803         [iOS] Switch geolocation to an explicit authorization query model
804         https://bugs.webkit.org/show_bug.cgi?id=132717
805
806         Reviewed by Sam Weinig.
807
808         Since there is no warmup code, WebGeolocationPolicyListener no longer need to know about the provider,
809         which is awesome :)
810
811         * WebCoreSupport/WebGeolocationClient.mm:
812         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
813         (-[WebGeolocationPolicyListener deny]):
814         (-[WebGeolocationProviderInitializationListener initializationAllowedWebView:]):
815         (-[WebGeolocationProviderInitializationListener initializationDeniedWebView:]):
816         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:provider:]): Deleted.
817         (-[WebGeolocationProviderInitializationListener initializationAllowedWebView:provider:]): Deleted.
818         (-[WebGeolocationProviderInitializationListener initializationDeniedWebView:provider:]): Deleted.
819         * WebView/WebViewPrivate.h:
820
821 2014-05-08  Jer Noble  <jer.noble@apple.com>
822
823         [Mac, iOS] Add source application accounting to AVURLAsset.
824         https://bugs.webkit.org/show_bug.cgi?id=132637
825
826         Reviewed by Eric Carlson.
827
828         Add accessor for sourceApplicationIdentifier.
829
830         * WebCoreSupport/WebFrameNetworkingContext.h:
831         * WebCoreSupport/WebFrameNetworkingContext.mm:
832         (WebFrameNetworkingContext::sourceApplicationIdentifier):
833
834 2014-05-08  Anders Carlsson  <andersca@apple.com>
835
836         Use a different install name for WebKitLegacy.framework for staged framework builds
837         https://bugs.webkit.org/show_bug.cgi?id=132711
838         <rdar://problem/16850620>
839
840         Reviewed by Dan Bernstein.
841
842         * Configurations/WebKitLegacy.xcconfig:
843
844 2014-05-08  Brady Eidson  <beidson@apple.com>
845
846         Wrap a new class definition with __has_include()
847         <rdar://problem/16852395> and https://bugs.webkit.org/show_bug.cgi?id=132694
848
849         Reviewed by Tim Horton.
850
851         * Misc/WebSharingServicePickerController.mm:
852
853 2014-05-07  Pratik Solanki  <psolanki@apple.com>
854
855         Use system defaults for hardware jpeg decoding
856         https://bugs.webkit.org/show_bug.cgi?id=132661
857         <rdar://problem/11348201>
858
859         Reviewed by Tim Horton.
860
861         Remove code that explicitly disabled hardware image decoding. Let the system decide what to do.
862
863         * WebView/WebView.mm:
864         (+[WebView _setAcceleratedImageDecoding:]):
865         (+[WebView _acceleratedImageDecoding]): Deleted.
866         * WebView/WebViewPrivate.h:
867
868 2014-05-07  Brent Fulgham  <bfulgham@apple.com>
869
870         [Mac, iOS] REGRESSION: WK2 YouTube support
871         https://bugs.webkit.org/show_bug.cgi?id=132568
872         <rdar://problem/11464344>
873
874         Reviewed by Darin Adler.
875
876         * Misc/WebNSURLExtras.h:
877         * Misc/WebNSURLExtras.mm: Remove code that has been converted to C++
878         and added to YouTubePluginReplacement.cpp.
879         (-[NSURL _webkit_youTubeURL]):
880         (-[NSString _webkit_queryKeysAndValues]):
881         (createYouTubeURL): Deleted.
882         (-[NSString _webkit_unescapedQueryValue]): Deleted.
883
884 2014-05-07  Jeremy Jones  <jeremyj@apple.com>
885
886         HTMLMediaElement should exitFullscreen when view is removed from the window.
887         https://bugs.webkit.org/show_bug.cgi?id=132506
888
889         Reviewed by Tim Horton.
890
891         * WebView/WebView.mm:
892         (-[WebView viewDidMoveToWindow]):
893         Request WebVideoFullscreenController to exitFullscreen when view is removed from the window.
894
895 2014-05-07  Brady Eidson  <beidson@apple.com>
896
897         Image menu is offset by the amount the view is scrolled
898         <rdar://problem/16818966> and https://bugs.webkit.org/show_bug.cgi?id=132663
899
900         Reviewed by Tim Horton.
901
902         * WebCoreSupport/WebContextMenuClient.mm:
903         (WebContextMenuClient::showContextMenu): Use FrameView::contentsToWindow instead of contentsToRoot, 
904           and skip the [NSView convertPoint:toView:] step.
905
906 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
907
908         WebKit1 is flashy when compositing layers come and go
909         https://bugs.webkit.org/show_bug.cgi?id=132655
910
911         Reviewed by Sam Weinig.
912         
913         In r166117 I removed code to flush compositing layers in FrameView::paintContents(),
914         which caused problems when painting iframes. However, this removed a flush
915         that WebKit1 relied on to flush compositing layers when painting, which caused
916         flashing when compositing layers come and go, and broke WebView snapshotting
917         in some cases.
918         
919         Fix by adding back compositing layer flushing, but this time in WebKit1's
920         -viewWillDraw code path. This allows removal of some flushing in DumpRenderTree.
921
922         * WebView/WebHTMLView.mm:
923         (-[WebHTMLView viewWillDraw]):
924         * WebView/WebView.mm:
925         (-[WebView _flushCompositingChanges]):
926         * WebView/WebViewInternal.h:
927         * WebView/WebViewPrivate.h:
928
929 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
930
931         [CSS Grid Layout] Remove runtime feature
932         https://bugs.webkit.org/show_bug.cgi?id=132382
933
934         Reviewed by Benjamin Poulain.
935
936         Remove cssGridLayoutEnabled setting usage.
937
938         * WebKit.order:
939         * WebView/WebPreferenceKeysPrivate.h:
940         * WebView/WebPreferences.mm:
941         (+[WebPreferences initialize]):
942         (-[WebPreferences cssGridLayoutEnabled]): Deleted.
943         (-[WebPreferences setCSSGridLayoutEnabled:]): Deleted.
944         * WebView/WebPreferencesPrivate.h:
945         * WebView/WebView.mm:
946         (-[WebView _preferencesChanged:]):
947
948 2014-05-06  Dean Jackson  <dino@apple.com>
949
950         [Mac] Allow focus rings to redraw themselves if necessary
951         https://bugs.webkit.org/show_bug.cgi?id=132593
952
953         Reviewed by Simon Fraser.
954
955         * WebCoreSupport/WebSystemInterface.mm:
956         (InitWebCoreSystemInterface): Add DrawFocusRingAtTime and DrawCellFocusRingWithFrameAtTime.
957
958 2014-05-06  Brady Eidson  <beidson@apple.com>
959
960         Don't select an image that is about to have its menu shown.
961         <rdar://problem/16807845> and https://bugs.webkit.org/show_bug.cgi?id=132579
962
963         Reviewed by Tim Horton.
964
965         * Misc/WebSharingServicePickerController.mm:
966         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
967           Call the new replaceNodeFromPasteboard API instead of readSelectionFromPasteboard.
968
969 2014-05-06  Anders Carlsson  <andersca@apple.com>
970
971         Move the WebKitLegacy header check to the right file
972         https://bugs.webkit.org/show_bug.cgi?id=132620
973         <rdar://problem/16815716>
974
975         Reviewed by Dan Bernstein.
976
977         * WebKitLegacy/MigrateHeadersFromWebKitLegacy.make:
978         * WebKitLegacy/WebKit.h:
979
980 2014-05-06  Anders Carlsson  <andersca@apple.com>
981
982         Put WebKitPluginHost.app in WebKitLegacy.framework
983         https://bugs.webkit.org/show_bug.cgi?id=132592
984         <rdar://problem/15920046>
985
986         Reviewed by Dan Bernstein.
987
988         * Plugins/Hosted/NetscapePluginHostManager.mm:
989         (WebKit::NetscapePluginHostManager::spawnPluginHost):
990
991 2014-05-06  Darin Adler  <darin@apple.com>
992
993         [iOS] Fix two more AdoptCF I missed in my last patch.
994
995         * WebView/WebHTMLView.mm:
996         (imageFromRect): Use adoptCF instead of AdoptCF.
997
998 2014-05-05  Andreas Kling  <akling@apple.com>
999
1000         Unreviewed, rolling out r168334.
1001
1002         Broke builds.
1003
1004         Reverted changeset:
1005
1006         "Put WebKitPluginHost.app in WebKitLegacy.framework"
1007         https://bugs.webkit.org/show_bug.cgi?id=132592
1008         http://trac.webkit.org/changeset/168334
1009
1010 2014-05-05  Anders Carlsson  <andersca@apple.com>
1011
1012         Put WebKitPluginHost.app in WebKitLegacy.framework
1013         https://bugs.webkit.org/show_bug.cgi?id=132592
1014         <rdar://problem/15920046>
1015
1016         Reviewed by Dan Bernstein.
1017
1018         * Plugins/Hosted/NetscapePluginHostManager.mm:
1019         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1020
1021 2014-05-02  Brady Eidson  <beidson@apple.com>
1022
1023         Implement new delegate method -sharingService:sourceFrameOnScreenForShareItem:.
1024         <rdar://problem/16797425> and https://bugs.webkit.org/show_bug.cgi?id=132484
1025
1026         Reviewed by Tim Horton.
1027
1028         * Misc/WebSharingServicePickerController.mm:
1029         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
1030
1031         * WebCoreSupport/WebContextMenuClient.h:
1032         * WebCoreSupport/WebContextMenuClient.mm:
1033         (WebContextMenuClient::screenRectForHitTestNode):
1034
1035 2014-05-02  Brady Eidson  <beidson@apple.com>
1036
1037         Crash inside [WebSharingServicePickerController clear]
1038         <rdar://problem/16791944> and https://bugs.webkit.org/show_bug.cgi?id=132477
1039
1040         Reviewed by Tim Horton.
1041
1042         * Misc/WebSharingServicePickerController.h:
1043         * Misc/WebSharingServicePickerController.mm:
1044         (-[WebSharingServicePickerController clear]): clear can be called twice, so null check _menuClient.
1045
1046         * WebCoreSupport/WebContextMenuClient.h:
1047         * WebCoreSupport/WebContextMenuClient.mm:
1048         (WebContextMenuClient::~WebContextMenuClient): For a sanity check, call clear on the picker here.
1049
1050 2014-05-01  Tim Horton  <timothy_horton@apple.com>
1051
1052         More 32-bit build fixes.
1053
1054         * Misc/WebSharingServicePickerController.mm:
1055         (-[WebSharingServicePickerController sharingService:didShareItems:]):
1056
1057 2014-05-01  Tim Horton  <timothy_horton@apple.com>
1058
1059         Temporarily "fix" the 32-bit build.
1060
1061         * Misc/WebSharingServicePickerController.mm:
1062         This will fail miserably at runtime, but we shouldn't ever get here in a 32-bit process.
1063
1064 2014-05-01  Brady Eidson  <beidson@apple.com>
1065
1066         Update service picker API usage.
1067         <rdar://problem/16772674> and https://bugs.webkit.org/show_bug.cgi?id=132452
1068
1069         Reviewed by Tim Horton.
1070
1071         * Misc/WebSharingServicePickerController.h:
1072         * Misc/WebSharingServicePickerController.mm:
1073         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
1074           Factor out a common "didShare" handler that optionally validates whether the data represents an image.
1075         (-[WebSharingServicePickerController sharingService:didShareItems:]): Update API usage, including marshalling
1076           on off-main thread call back to the main thread.
1077
1078         * WebCoreSupport/WebContextMenuClient.mm:
1079         (WebContextMenuClient::contextMenuForEvent): Update API usage.
1080
1081 2014-05-01  Anders Carlsson  <andersca@apple.com>
1082
1083         Support OS-version-specific install paths for WebKit.framework
1084         https://bugs.webkit.org/show_bug.cgi?id=132448
1085         <rdar://problem/16784932>
1086
1087         Reviewed by Dan Bernstein.
1088
1089         * WebKitLegacy/WebKit.m:
1090         Add version specific install names.
1091
1092 2014-04-30  Alexey Proskuryakov  <ap@apple.com>
1093
1094         Roll out fix for https://bugs.webkit.org/show_bug.cgi?id=131637:
1095         Clean up unnecessary methods in the BackForwardClient interface
1096
1097         It broke a regression test and an API test.
1098
1099         * History/WebBackForwardList.mm:
1100         (-[WebBackForwardList initWithBackForwardList:]):
1101         (-[WebBackForwardList init]):
1102         (-[WebBackForwardList dealloc]):
1103         (-[WebBackForwardList finalize]):
1104         (-[WebBackForwardList setPageCacheSize:]):
1105         (-[WebBackForwardList pageCacheSize]):
1106         * History/WebBackForwardListInternal.h:
1107         * WebCoreSupport/WebFrameLoaderClient.mm:
1108         (WebFrameLoaderClient::canCachePage):
1109         * WebView/WebFrameView.mm:
1110         (-[WebFrameView keyDown:keyDown:]):
1111         * WebView/WebView.mm:
1112         (-[WebView _loadBackForwardListFromOtherView:]):
1113         (-[WebView initWithCoder:]):
1114         (-[WebView encodeWithCoder:]):
1115         (-[WebView backForwardList]):
1116         (-[WebView setMaintainsBackForwardList:]):
1117
1118 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
1119
1120         Remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
1121         https://bugs.webkit.org/show_bug.cgi?id=132396
1122
1123         Reviewed by Eric Carlson.
1124
1125         Remove ENABLE_PLUGIN_PROXY_FOR_VIDEO and related code.
1126
1127         * Configurations/FeatureDefines.xcconfig:
1128         * Plugins/WebPluginContainerPrivate.h:
1129         * Plugins/WebPluginController.h:
1130         * Plugins/WebPluginController.mm:
1131         (-[WebPluginController dealloc]):
1132         (-[WebPluginController plugInsAreRunning]):
1133         (-[WebPluginController stopAllPlugins]):
1134         (-[WebPluginController stopPluginsForPageCache]):
1135         (-[WebPluginController restorePluginsFromCache]):
1136         (-[WebPluginController addPlugin:]):
1137         (-[WebPluginController destroyPlugin:]):
1138         (-[WebPluginController destroyAllPlugins]):
1139         (-[NSView isMediaPlugInProxyView]): Deleted.
1140         (-[NSView setIsMediaPlugInProxyView:]): Deleted.
1141         (-[WebPluginController mediaPlugInProxyViewCreated:]): Deleted.
1142         (+[WebPluginController pluginViewHidden:]): Deleted.
1143         (mediaProxyClient): Deleted.
1144         (-[WebPluginController _webPluginContainerSetMediaPlayerProxy:forElement:]): Deleted.
1145         (-[WebPluginController _webPluginContainerPostMediaPlayerNotification:forElement:]): Deleted.
1146         * WebCoreSupport/WebFrameLoaderClient.h:
1147         * WebCoreSupport/WebFrameLoaderClient.mm:
1148         (pluginView):
1149         * WebView/WebView.mm:
1150         (-[WebView _preferencesChanged:]):
1151         (-[WebView _videoProxyPluginForMIMEType:]): Deleted.
1152         * WebView/WebViewInternal.h:
1153
1154 2014-04-30  Anders Carlsson  <andersca@apple.com>
1155
1156         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
1157         https://bugs.webkit.org/show_bug.cgi?id=132399
1158         <rdar://problem/15920046>
1159
1160         Reviewed by Dan Bernstein.
1161
1162         * Carbon/CarbonUtils.h:
1163         * Carbon/HIViewAdapter.h:
1164         * Carbon/HIWebView.h:
1165         Import WebKitLegacy headers instead of WebKit headers.
1166
1167         * Configurations/WebKit.xcconfig:
1168         Move the definitions needed for building WebKitLegacy.framework to WebKitLegacy.xcconfig and
1169         add the relevant definitions needed for re-exporting WebKitLegacy.framework.
1170
1171         * Configurations/WebKitLegacy.xcconfig:
1172         Add definitions needed for building the "old" WebKit API as WebKitLegacy.framework.
1173
1174         * DOM/WebDOMOperations.h:
1175         * DOM/WebDOMOperations.mm:
1176         * DOM/WebDOMOperationsInternal.h:
1177         * DOM/WebDOMOperationsPrivate.h:
1178         * DefaultDelegates/WebDefaultContextMenuDelegate.h:
1179         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1180         * DefaultDelegates/WebDefaultEditingDelegate.m:
1181         * History/WebBackForwardListInternal.h:
1182         * History/WebBackForwardListPrivate.h:
1183         * History/WebHistoryItemPrivate.h:
1184         * History/WebHistoryPrivate.h:
1185         * History/WebURLsWithTitles.m:
1186         Import WebKitLegacy headers instead of WebKit headers.
1187
1188         * MigrateHeaders.make:
1189         Update header paths now that all WebKitLegacy headers are private.
1190         Remove migration of WebKit2 headers, that is done by MigrateHeadersFromWebKitLegacy.make now.
1191         
1192         * Misc/WebCoreStatistics.h:
1193         * Misc/WebDownload.h:
1194         * Misc/WebDownload.mm:
1195         * Misc/WebDownloadInternal.h:
1196         * Misc/WebElementDictionary.mm:
1197         * Misc/WebIconDatabasePrivate.h:
1198         * Misc/WebKit.h:
1199         * Misc/WebKitErrors.m:
1200         * Misc/WebKitErrorsPrivate.h:
1201         * Misc/WebKitNSStringExtras.mm:
1202         * Misc/WebLocalizableStrings.mm:
1203         * Misc/WebNSDataExtras.m:
1204         * Misc/WebNSDictionaryExtras.m:
1205         * Misc/WebNSEventExtras.m:
1206         * Misc/WebNSFileManagerExtras.mm:
1207         * Misc/WebNSImageExtras.m:
1208         * Misc/WebNSPasteboardExtras.mm:
1209         * Misc/WebNSViewExtras.h:
1210         * Misc/WebNSViewExtras.m:
1211         * Panels/WebAuthenticationPanel.m:
1212         * Panels/WebPanelAuthenticationHandler.m:
1213         * Plugins/Hosted/HostedNetscapePluginStream.h:
1214         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1215         * Plugins/Hosted/WebKitPluginAgent.defs:
1216         * Plugins/Hosted/WebKitPluginAgentReply.defs:
1217         * Plugins/Hosted/WebKitPluginClient.defs:
1218         * Plugins/Hosted/WebKitPluginHost.defs:
1219         * Plugins/Hosted/WebKitPluginHostTypes.defs:
1220         * Plugins/WebBaseNetscapePluginView.mm:
1221         * Plugins/WebBasePluginPackage.h:
1222         * Plugins/WebBasePluginPackage.mm:
1223         * Plugins/WebNetscapeContainerCheckPrivate.h:
1224         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
1225         * Plugins/WebNetscapePluginStream.h:
1226         * Plugins/WebNetscapePluginView.h:
1227         * Plugins/WebNetscapePluginView.mm:
1228         * Plugins/WebPlugin.h:
1229         * Plugins/WebPluginController.h:
1230         * Plugins/WebPluginDatabase.h:
1231         * Plugins/WebPluginPackage.h:
1232         * Plugins/WebPluginPackage.mm:
1233         * Plugins/WebPluginViewFactory.h:
1234         * Plugins/WebPluginViewFactoryPrivate.h:
1235         * Plugins/npapi.mm:
1236         * Storage/WebDatabaseManagerPrivate.h:
1237         * WebCoreSupport/WebContextMenuClient.mm:
1238         * WebCoreSupport/WebFrameLoaderClient.mm:
1239         * WebCoreSupport/WebFrameNetworkingContext.mm:
1240         * WebCoreSupport/WebGeolocationClient.mm:
1241         * WebCoreSupport/WebInspectorClient.mm:
1242         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1243         * WebCoreSupport/WebKeyGenerator.mm:
1244         * WebInspector/WebInspectorPrivate.h:
1245         * WebInspector/WebNodeHighlight.h:
1246         * WebInspector/WebNodeHighlightView.h:
1247         Import WebKitLegacy headers instead of WebKit headers.
1248         
1249         * WebKitLegacy/MigrateHeadersFromWebKitLegacy.make: Added.
1250         New makefile that handles copying WebKitLegacy headers to the WebKit framework, rewriting WebKitLegacy
1251         imports to WebKit imports. (On iOS the WebKit headers just forward to the relevant WebKitLegacy headers).
1252         On OS X, this also handles copying WebKit2 headers to the WebKit framework, rewriting WebKit2 imports to WebKit imports
1253         and getting rid of C SPI imports.
1254         
1255         * WebKitLegacy/MigrateHeadersToLegacy.make: Removed.
1256         This is no longer needed.
1257         
1258         * WebKitLegacy/WebKit.h: Added.
1259         New umbrella header that imports the modern API if available, as well as the legacy API (using WebKit/WebKitLegacy.h).
1260
1261         * WebKitLegacy/WebKit.m:
1262         This is an empty file so we'll have something to link.
1263
1264         * WebKitLegacy/WebKitPrivate.h:
1265         New SPI header that imports the private headers of the modern API.
1266
1267         * WebView/WebDataSource.h:
1268         * WebView/WebDataSource.mm:
1269         * WebView/WebDataSourcePrivate.h:
1270         * WebView/WebDelegateImplementationCaching.h:
1271         * WebView/WebDocument.h:
1272         * WebView/WebDocumentInternal.h:
1273         * WebView/WebDocumentPrivate.h:
1274         * WebView/WebEditingDelegate.h:
1275         * WebView/WebEditingDelegatePrivate.h:
1276         * WebView/WebFrameLoadDelegate.h:
1277         * WebView/WebFrameLoadDelegatePrivate.h:
1278         * WebView/WebFramePrivate.h:
1279         * WebView/WebFrameView.h:
1280         * WebView/WebFrameViewInternal.h:
1281         * WebView/WebFrameViewPrivate.h:
1282         * WebView/WebHTMLRepresentation.h:
1283         * WebView/WebHTMLRepresentation.mm:
1284         * WebView/WebHTMLRepresentationPrivate.h:
1285         * WebView/WebHTMLView.h:
1286         * WebView/WebHTMLView.mm:
1287         * WebView/WebHTMLViewPrivate.h:
1288         * WebView/WebPDFView.h:
1289         * WebView/WebPolicyDelegatePrivate.h:
1290         * WebView/WebPreferencesPrivate.h:
1291         * WebView/WebResourcePrivate.h:
1292         * WebView/WebUIDelegate.h:
1293         * WebView/WebUIDelegatePrivate.h:
1294         * WebView/WebView.h:
1295         * WebView/WebView.mm:
1296         * WebView/WebViewPrivate.h:
1297         Import WebKitLegacy headers instead of WebKit headers.
1298
1299         * migrate-headers.sh:
1300         Derived sources are put in DerivedSources/WebKitLegacy now.
1301
1302 2014-04-30  David Hyatt  <hyatt@apple.com>
1303
1304         [New Multicolumn] Enable new multi-column mode
1305         https://bugs.webkit.org/show_bug.cgi?id=131825
1306
1307         Reviewed by Simon Fraser.
1308
1309         * WebView/WebPreferences.mm:
1310         (+[WebPreferences initialize]):
1311
1312 2014-04-30  Brian J. Burg  <burg@cs.washington.edu>
1313
1314         Clean up unnecessary methods in the BackForwardClient interface
1315         https://bugs.webkit.org/show_bug.cgi?id=131637
1316
1317         Reviewed by Andreas Kling.
1318
1319         BackForwardClient instances now have ownership lifetime semantics, so
1320         WebBackForwardList now explicitly deletes its inner BackForwardList.
1321
1322         Convert uses of WebCore::BackForwardList through backForward().client() to
1323         accept references instead of pointers.
1324
1325         Use BackForwardController methods rather than directly operating with the
1326         BackForwardClient where possible.
1327
1328         Remove page cache-related methods that are not used anywhere and that call
1329         BackForwardClient::page(), which is removed by this change.
1330
1331         * History/WebBackForwardList.mm:
1332         (-[WebBackForwardList initWithBackForwardList:]):
1333         (-[WebBackForwardList init]):
1334         (-[WebBackForwardList dealloc]):
1335         (-[WebBackForwardList finalize]):
1336         (-[WebBackForwardList setPageCacheSize]): Deleted.
1337         (-[WebBackForwardList pageCacheSize]): Deleted.
1338         (-[WebBackForwardList itemAtIndex:]): Deleted.
1339         * History/WebBackForwardListInternal.h:
1340         * WebCoreSupport/WebFrameLoaderClient.mm:
1341         (WebFrameLoaderClient::canCachePage):
1342         * WebView/WebFrameView.mm:
1343         (-[WebFrameView keyDown:keyDown:]):
1344         * WebView/WebView.mm:
1345         (-[WebView _loadBackForwardListFromOtherView:]):
1346         (-[WebView initWithCoder:]):
1347         (-[WebView encodeWithCoder:]):
1348         (-[WebView backForwardList]):
1349         (-[WebView setMaintainsBackForwardList:]):
1350
1351 2014-04-29  Sam Weinig  <sam@webkit.org>
1352
1353         [iOS] -[WebHTMLView selectionImageForcingBlackText:] returns blank image on iOS
1354         https://bugs.webkit.org/show_bug.cgi?id=132359
1355
1356         Reviewed by Darin Adler.
1357
1358         * WebView/WebHTMLView.mm:
1359         (imageFromRect):
1360         (selectionImage):
1361         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
1362         Bring back the old FrameSnapshottingMac code for drawing the selection image as drag code for this
1363         is still unimplemented on iOS.
1364
1365         * WebView/WebView.mm:
1366         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1367         Set the page scale for "simple HTML documents" (this is already done for the all other documents), 
1368         to ensure that the snapshot is the correct size.
1369
1370 2014-04-30  Manuel Rego Casasnovas  <rego@igalia.com>
1371
1372         [CSS Grid Layout] Enable runtime feature by default
1373         https://bugs.webkit.org/show_bug.cgi?id=132189
1374
1375         Reviewed by Benjamin Poulain.
1376
1377         * WebView/WebPreferences.mm:
1378         (+[WebPreferences initialize]): Remove unneeded changes that
1379         enable/disable the runtime feature depending on the compilation flag.
1380         And set it to true by default.
1381
1382 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
1383
1384         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
1385         https://bugs.webkit.org/show_bug.cgi?id=112840
1386
1387         Rubber stamped by Geoffrey Garen.
1388
1389         * Configurations/FeatureDefines.xcconfig:
1390
1391 2014-04-29  Brady Eidson  <beidson@apple.com>
1392
1393         Change Image Controls replacement to use selection and paste
1394         <rdar://problem/16302722> and https://bugs.webkit.org/show_bug.cgi?id=131992
1395
1396         Reviewed by Tim Horton.
1397
1398         * Misc/WebSharingServicePickerController.mm:
1399         (-[WebSharingServicePickerController sharingService:didShareItems:]): Write the
1400           replacement data to a special pasteboard, then replace the current selection from
1401           that pasteboard.
1402
1403 2014-04-27  Sam Weinig  <sam@webkit.org>
1404
1405         [iOS WebKit2] Add support for text autosizing
1406         <rdar://problem/16545245>
1407         https://bugs.webkit.org/show_bug.cgi?id=132237
1408
1409         Reviewed by Tim Horton.
1410
1411         * WebView/WebFrame.mm:
1412         (-[WebFrame _setTextAutosizingWidth:]):
1413         Forward setting of the text autosizing width to the Page.
1414
1415 2014-04-25  Dean Jackson  <dino@apple.com>
1416
1417         Allow a platform-specific size enumeration to be passed into popup-menu display
1418         https://bugs.webkit.org/show_bug.cgi?id=132195
1419
1420         Reviewed by Brent Fulgham. With some in-person review comments from Sam Weinig.
1421
1422         Platforms like OS X use a set of predefined sizes for built-in controls
1423         used for <select>: normal, small and mini. Expose that information to
1424         the PopupMenuClient via the PopupMenuStyle, allowing it to be passed
1425         into the platform code in WebKitSystemInterface.
1426
1427         * WebCoreSupport/PopupMenuMac.mm:
1428         (PopupMenuMac::show): Convert the WebCore menu size type into the
1429         WebCoreSystemInterface type.
1430
1431 2014-04-24  Commit Queue  <commit-queue@webkit.org>
1432
1433         Unreviewed, rolling out r167700.
1434         https://bugs.webkit.org/show_bug.cgi?id=132142
1435
1436         Incorrectly reverted the change in r167547 for
1437         webkit.org/b/131898 (Requested by rniwa on #webkit).
1438
1439         Reverted changeset:
1440
1441         "Cursor doesn't change back to pointer when leaving the Safari
1442         window"
1443         https://bugs.webkit.org/show_bug.cgi?id=132038
1444         http://trac.webkit.org/changeset/167700
1445
1446 2014-04-24  Brady Eidson  <beidson@apple.com>
1447
1448         Rename "IMAGE_CONTROLS" feature to "SERVICE_CONTROLS"
1449         https://bugs.webkit.org/show_bug.cgi?id=132155
1450
1451         Reviewed by Tim Horton.
1452
1453         * Configurations/FeatureDefines.xcconfig:
1454         * Misc/WebSharingServicePickerController.h:
1455         * Misc/WebSharingServicePickerController.mm:
1456         * WebCoreSupport/WebContextMenuClient.h:
1457         * WebCoreSupport/WebContextMenuClient.mm:
1458         (WebContextMenuClient::contextMenuForEvent):
1459         * WebView/WebPreferences.mm:
1460         (+[WebPreferences initialize]):
1461         * WebView/WebView.mm:
1462         (-[WebView _preferencesChanged:]):
1463
1464 2014-04-24  Ryosuke Niwa  <rniwa@webkit.org>
1465
1466         Text caret disappears in Mail after returning from another application
1467         https://bugs.webkit.org/show_bug.cgi?id=132111
1468
1469         Reviewed by Darin Adler.
1470
1471         The bug was caused by our SPI _windowChangedKeyState not getting called upon deminiaturization.
1472
1473         Fixed the bug by using the standard NSWindowDidBecomeKeyNotification and NSWindowDidResignKeyNotification
1474         notifications as done in WebKit2 since they DO get called upon deminiaturization.
1475
1476         * WebView/WebView.mm:
1477         (-[WebView addWindowObserversForWindow:]):
1478         (-[WebView removeWindowObservers]):
1479         (-[WebView _windowKeyStateChanged:]):
1480         (-[WebView _windowChangedKeyState]): Deleted.
1481
1482 2014-04-24  Myles C. Maxfield  <mmaxfield@apple.com>
1483
1484         FontCache::fontCache() never returns nullptr so it can be made to return a reference instead
1485         https://bugs.webkit.org/show_bug.cgi?id=132110
1486
1487         Reviewed by Tim Horton.
1488
1489         Updates callers to use '.' instead of '->'.
1490
1491         No new tests are necessary because there should be no behavior change.
1492
1493         * Misc/WebCoreStatistics.mm:
1494         (+[WebCoreStatistics cachedFontDataCount]):
1495         (+[WebCoreStatistics cachedFontDataInactiveCount]):
1496         (+[WebCoreStatistics purgeInactiveFontData]):
1497         * WebView/WebView.mm:
1498         (+[WebView purgeInactiveFontData]):
1499
1500 2014-04-24  Eric Carlson  <eric.carlson@apple.com>
1501
1502         [iOS] Manage AudioSession category according to media type
1503         https://bugs.webkit.org/show_bug.cgi?id=132096
1504
1505         Reviewed by Jer Noble.
1506
1507         * WebView/WebView.mm:
1508         (-[WebView _commonInitializationWithFrameName:groupName:]): Tell 
1509             WebCore to manage the AudioSession when running in MobileSafari.
1510
1511 2014-04-23  Andreas Kling  <akling@apple.com>
1512
1513         Remove Apple Dictionary workaround in WebFrameLoaderClient.
1514         <https://webkit.org/b/132095>
1515
1516         Kill a hack to work around a WK1 client bug that got fixed years ago.
1517         See <rdar://problem/6471058> for backstory.
1518
1519         Reviewed by Darin Adler.
1520
1521         * WebCoreSupport/WebFrameLoaderClient.mm:
1522         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1523         (WebFrameLoaderClient::dispatchWillSendRequest):
1524         (applyAppleDictionaryApplicationQuirkNonInlinePart): Deleted.
1525         (applyAppleDictionaryApplicationQuirk): Deleted.
1526
1527 2014-04-23  Anders Carlsson  <andersca@apple.com>
1528
1529         Don't migrate the WKView.h header from WebCore to WebKit
1530         https://bugs.webkit.org/show_bug.cgi?id=132086
1531
1532         Reviewed by Dan Bernstein.
1533
1534         * MigrateHeaders.make:
1535         Remove WKView.h from the list of headers to migrate.
1536
1537         * WebView/WebView.mm:
1538         Import WKView.h.
1539
1540 2014-04-22  Ryosuke Niwa  <rniwa@webkit.org>
1541
1542         Cursor doesn't change back to pointer when leaving the Safari window
1543         https://bugs.webkit.org/show_bug.cgi?id=132038
1544
1545         Reviewed by Alexey Proskuryakov.
1546
1547         Since the cursor type is now updated asynchronously after r147739,
1548         [window windowNumber] != [NSWindow windowNumberAtPoint:[NSEvent mouseLocation] belowWindowWithWindowNumber:0]
1549         evalutes to false depending on how fast cursor is moving.
1550
1551         Instead, check whether the NSWindow of the WebView is the key window or not since
1552         key window appears to control the cursor style in Cocoa as far as I've tested:
1553         https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/WinPanel/Concepts/ChangingMainKeyWindow.html
1554
1555         * WebCoreSupport/WebChromeClient.mm:
1556         (WebChromeClient::setCursor):
1557
1558 2014-04-22  Commit Queue  <commit-queue@webkit.org>
1559
1560         Unreviewed, rolling out r167674.
1561         https://bugs.webkit.org/show_bug.cgi?id=132025
1562
1563         Going a different way with this (Requested by bradee-oh on
1564         #webkit).
1565
1566         Reverted changeset:
1567
1568         "Change Image Controls replacement to use selection and paste"
1569         https://bugs.webkit.org/show_bug.cgi?id=131992
1570         http://trac.webkit.org/changeset/167674
1571
1572 2014-04-22  Brady Eidson  <beidson@apple.com>
1573
1574         Change Image Controls replacement to use selection and paste
1575         <rdar://problem/16302722> and https://bugs.webkit.org/show_bug.cgi?id=131992
1576
1577         Reviewed by Tim Horton.
1578
1579         * Misc/WebSharingServicePickerController.mm:
1580         (-[WebSharingServicePickerController sharingService:didShareItems:]): Write the
1581           replacement data to a special pasteboard, then replace the current selection from
1582           that pasteboard.
1583
1584 2014-04-21  Eric Carlson  <eric.carlson@apple.com>
1585
1586         [Mac] implement WebKitDataCue
1587         https://bugs.webkit.org/show_bug.cgi?id=131799
1588
1589         Reviewed by Dean Jackson.
1590
1591         * Configurations/FeatureDefines.xcconfig: Define ENABLE_DATACUE_VALUE.
1592
1593 2014-04-21  Joseph Pecoraro  <pecoraro@apple.com>
1594
1595         Remove unused WebKitSystemInterface functions
1596         https://bugs.webkit.org/show_bug.cgi?id=131938
1597
1598         Reviewed by Alexey Proskuryakov.
1599
1600         * WebCoreSupport/WebSystemInterface.mm:
1601         (InitWebCoreSystemInterface):
1602
1603 2014-04-21  Zan Dobersek  <zdobersek@igalia.com>
1604
1605         Move cross-port Source/WebCore/page/ code to std::unique_ptr
1606         https://bugs.webkit.org/show_bug.cgi?id=130534
1607
1608         Reviewed by Darin Adler.
1609
1610         * WebView/WebHTMLRepresentation.mm:
1611         (searchForLabelsBeforeElement): Pass a RegExp reference to Frame::searchForLabelsAboveCell().
1612
1613 2014-04-19  Darin Adler  <darin@apple.com>
1614
1615         [Mac] WebView adjusts the cursor even when another window is in front
1616         https://bugs.webkit.org/show_bug.cgi?id=131898
1617         rdar://problem/14619911
1618
1619         Reviewed by Dan Bernstein.
1620
1621         * WebCoreSupport/WebChromeClient.mm:
1622         (WebChromeClient::setCursor): Added a check that the window is under the cursor
1623         and do nothing if it's not.
1624
1625 2014-04-18  Commit Queue  <commit-queue@webkit.org>
1626
1627         Unreviewed, rolling out r167527.
1628         https://bugs.webkit.org/show_bug.cgi?id=131883
1629
1630         Broke 32-bit build (Requested by ap on #webkit).
1631
1632         Reverted changeset:
1633
1634         "[Mac] implement WebKitDataCue"
1635         https://bugs.webkit.org/show_bug.cgi?id=131799
1636         http://trac.webkit.org/changeset/167527
1637
1638 2014-04-18  Eric Carlson  <eric.carlson@apple.com>
1639
1640         [Mac] implement WebKitDataCue
1641         https://bugs.webkit.org/show_bug.cgi?id=131799
1642
1643         Reviewed by Dean Jackson.
1644
1645         * Configurations/FeatureDefines.xcconfig: Define ENABLE_DATACUE_VALUE.
1646
1647 2014-04-17  Daniel Bates  <dabates@apple.com>
1648
1649         [iOS] Hook up screen.{availHeight, availWidth, height, width}
1650         https://bugs.webkit.org/show_bug.cgi?id=131821
1651         <rdar://problem/16413795>
1652
1653         Reviewed by Benjamin Poulain and Tim Horton.
1654
1655         Add declaration for WKGetViewportAvailableScreenSize() to return the available screen size.
1656
1657         Additionally substitute "ScreenSize" for "ViewportScreenSize" to make the code more understandable.
1658
1659         * WebCoreSupport/WebSystemInterface.mm:
1660         (InitWebCoreSystemInterface):
1661
1662 2014-04-17  Darin Adler  <darin@apple.com>
1663
1664         Add separate flag for IndexedDatabase in workers since the current implementation is not threadsafe
1665         https://bugs.webkit.org/show_bug.cgi?id=131785
1666         rdar://problem/16003108
1667
1668         Reviewed by Brady Eidson.
1669         
1670         * Configurations/FeatureDefines.xcconfig: Added INDEXED_DATABASE_IN_WORKERS.
1671
1672 2014-04-16  Tim Horton  <timothy_horton@apple.com>
1673
1674         Images dragged from WebKit1 on 2x displays are too big
1675         https://bugs.webkit.org/show_bug.cgi?id=131775
1676         <rdar://problem/15933525>
1677
1678         Reviewed by Simon Fraser.
1679
1680         * WebCoreSupport/WebDragClient.mm:
1681         (WebDragClient::startDrag):
1682         Scale the drag image's logical size down by the device scale factor
1683         in WebKit1 just like we do in WebKit2.
1684
1685 2014-04-13  Andy Estes  <aestes@apple.com>
1686
1687         [QuickLook] Move file system-related code into WebKit
1688         https://bugs.webkit.org/show_bug.cgi?id=131597
1689
1690         Reviewed by Dan Bernstein.
1691
1692         Moved file system and WebKit1-only code from QuickLookHandle into a new
1693         QuickLookHandleClient subclass.
1694
1695         * WebCoreSupport/WebFrameLoaderClient.h:
1696         * WebCoreSupport/WebFrameLoaderClient.mm:
1697
1698 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
1699
1700         Eliminate DragSession structure
1701         https://bugs.webkit.org/show_bug.cgi?id=131465
1702
1703         Reviewed by Benjamin Poulain.
1704
1705         * WebView/WebView.mm:
1706         (-[WebView draggingEntered:]):
1707         (-[WebView draggingUpdated:]):
1708
1709 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
1710
1711         Rename some dragging functions
1712         https://bugs.webkit.org/show_bug.cgi?id=131460
1713
1714         Reviewed by Tim Horton.
1715
1716         Renamed performDrag to performDragOperation.
1717
1718         * WebView/WebView.mm: (-[WebView performDragOperation:]):
1719
1720 2014-04-08  Jon Lee  <jonlee@apple.com>
1721
1722         Turn MSE on by default
1723         https://bugs.webkit.org/show_bug.cgi?id=131313
1724         <rdar://problem/16525223>
1725
1726         Reviewed by Jer Noble.
1727
1728         * Configurations/FeatureDefines.xcconfig:
1729         * WebView/WebPreferences.mm:
1730         (+[WebPreferences initialize]): Set default to true.
1731
1732 2014-04-08  Alexey Proskuryakov  <ap@apple.com>
1733
1734         Rename Clipboard to DataTransfer
1735         https://bugs.webkit.org/show_bug.cgi?id=131371
1736
1737         Reviewed by Anders Carlsson.
1738
1739         * WebCoreSupport/WebDragClient.h:
1740         * WebCoreSupport/WebDragClient.mm:
1741         (WebDragClient::willPerformDragSourceAction):
1742         (WebDragClient::startDrag):
1743         * WebView/WebPDFView.mm:
1744
1745 2014-04-08  Dan Bernstein  <mitz@apple.com>
1746
1747         WebKit part of [Cocoa] Add WKFormDelegate
1748         https://bugs.webkit.org/show_bug.cgi?id=131343
1749
1750         Reviewed by Anders Carlsson.
1751
1752         * MigrateHeaders.make: Added new WebKit2 headers to WEBKIT2_HEADERS.
1753
1754 2014-04-08  Daniel Bates  <dabates@apple.com>
1755
1756         Fallback to default storage session when there isn't a valid session ID
1757         https://bugs.webkit.org/show_bug.cgi?id=131326
1758         <rdar://problem/16231679>
1759
1760         Reviewed by Alexey Proskuryakov.
1761
1762         Fixes and issue where we may use the wrong storage session after disabling
1763         a private browsing session.
1764
1765         Currently WebKit1 and WebKit2 without NetworkProcess assume that there
1766         is always a non-null private browsing storage session so long as the page
1767         has a non-default session ID. Instead we should only use the private browsing
1768         storage session when it's non-null and the page has a non-default session ID;
1769         otherwise, we should use the default storage session. This change will make
1770         the behavior in WebKit1 and WebKit2 without NetworkProcess consistent with
1771         the behavior in WebKit2 with NetworkProcess.
1772
1773         * WebCoreSupport/WebFrameNetworkingContext.mm:
1774         (WebFrameNetworkingContext::storageSession):
1775
1776 2014-04-06  Sam Weinig  <sam@webkit.org>
1777
1778         Document user content related APIs
1779
1780         Reviewed by Anders Carlsson.
1781
1782         * MigrateHeaders.make:
1783
1784 2014-04-06  Darin Adler  <darin@apple.com>
1785
1786         Refactor post-attach and HTMLObjectElement-related code
1787         https://bugs.webkit.org/show_bug.cgi?id=131282
1788
1789         Reviewed by Antti Koivisto.
1790
1791         * WebCoreSupport/WebFrameLoaderClient.mm: Call toHTMLPlugInImageElement instead of
1792         doing a static_cast.
1793
1794 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
1795
1796         Enable WEB_REPLAY for PLATFORM(MAC)
1797         https://bugs.webkit.org/show_bug.cgi?id=130700
1798
1799         Reviewed by Timothy Hatcher.
1800
1801         * Configurations/FeatureDefines.xcconfig:
1802
1803 2014-04-03  Sam Weinig  <sam@webkit.org>
1804
1805         [WebKit2] Promote user script SPI to API
1806         https://bugs.webkit.org/show_bug.cgi?id=131181
1807
1808         Reviewed by Anders Carlsson.
1809
1810         * MigrateHeaders.make:
1811
1812 2014-04-02  Benjamin Poulain  <bpoulain@apple.com>
1813
1814         [iOS] Remove the legacy string drawing code
1815         https://bugs.webkit.org/show_bug.cgi?id=131088
1816
1817         Reviewed by Sam Weinig.
1818
1819         * Configurations/WebKit.xcconfig:
1820
1821 2014-04-02  Mark Rowe  <mrowe@apple.com>
1822
1823         <https://webkit.org/b/131135> Introduce LockHistory and LockBackForwardList enums to use in place of bools.
1824
1825         These arguments are often passed using literals at the call site, where the use of bools severely hinders
1826         the readability of the code.
1827
1828         Reviewed by Andreas Kling.
1829
1830         * WebView/WebPDFView.mm:
1831         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1832
1833 2014-04-02  Stephanie Lewis  <slewis@apple.com>
1834
1835         Roll out http://trac.webkit.org/changeset/166144
1836         <rdar://problem/16481284> PLT stops loading on news.google.com
1837         
1838         Unreviewed rollout.
1839
1840         Rollout 166144 since it prevents the PLT from completing.
1841
1842         * WebCoreSupport/WebFrameLoaderClient.mm:
1843
1844 2014-04-02  Daniel Bates  <dabates@apple.com>
1845
1846         Remove Settings::maximumDecodedImageSize()
1847         https://bugs.webkit.org/show_bug.cgi?id=131057
1848         <rdar://problem/15626368>
1849
1850         Reviewed by Darin Adler. 
1851
1852         Remove preferences key WebKitMaximumImageSize.
1853
1854         * WebView/WebPreferenceKeysPrivate.h:
1855         * WebView/WebPreferences.mm:
1856         (+[WebPreferences initialize]):
1857         (-[WebPreferences _maximumImageSize:]): Deleted.
1858         * WebView/WebPreferencesPrivate.h:
1859         * WebView/WebView.mm:
1860         (-[WebView _preferencesChanged:]):
1861
1862 2014-04-02  Martin Hock  <mhock@apple.com>
1863
1864         Unify private browsing with sessions.
1865         https://bugs.webkit.org/show_bug.cgi?id=130099
1866
1867         Reviewed by Alexey Proskuryakov.
1868
1869         * WebCoreSupport/WebFrameLoaderClient.mm: Change WebCore::Settings::privateBrowsingEnabled() to Page::sessionID().isEphemeral().
1870         (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
1871         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
1872         (WebFrameNetworkingContext::storageSession):
1873         * WebView/WebView.mm: Change WebCore::Settings::setPrivateBrowsingEnabled() to Page::enableLegacyPrivateBrowsing().
1874         (-[WebView _preferencesChanged:]):
1875
1876 2014-04-01  Anders Carlsson  <andersca@apple.com>
1877
1878         Migrate more headers
1879         https://bugs.webkit.org/show_bug.cgi?id=131068
1880
1881         Reviewed by Tim Horton.
1882
1883         * MigrateHeaders.make:
1884
1885 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1886
1887         [CSS Grid Layout] Enable runtime feature if feature flag is enabled
1888         https://bugs.webkit.org/show_bug.cgi?id=130013
1889
1890         Reviewed by Simon Fraser.
1891
1892         Enable CSS Grid Layout runtime feature when ENABLE_CSS_GRID_LAYOUT flag is true.
1893
1894         * WebView/WebPreferences.mm:
1895         (+[WebPreferences initialize]):
1896
1897 2014-03-31  Simon Fraser  <simon.fraser@apple.com>
1898
1899         Enable WEB_TIMING on Mac and iOS
1900         https://bugs.webkit.org/show_bug.cgi?id=128064
1901
1902         Reviewed by Sam Weinig, Brent Fulgham.
1903
1904         Enable WEB_TIMING.
1905
1906         * Configurations/FeatureDefines.xcconfig:
1907
1908 2014-03-31  Dean Jackson  <dino@apple.com>
1909
1910         Remove WEB_ANIMATIONS
1911         https://bugs.webkit.org/show_bug.cgi?id=130989
1912
1913         Reviewed by Simon Fraser.
1914
1915         Remove this feature flag until we plan to implement.
1916
1917         * Configurations/FeatureDefines.xcconfig:
1918
1919 2014-03-31  Antti Koivisto  <antti@apple.com>
1920
1921         Rename TileCache to LegacyTileCache
1922         https://bugs.webkit.org/show_bug.cgi?id=130986
1923
1924         Reviewed by Simon Fraser.
1925
1926         * WebView/WebView.mm:
1927         (+[WebView drainLayerPool]):
1928         (+[WebView _setTileCacheLayerPoolCapacity:]):
1929
1930 2014-03-28  Darin Adler  <darin@apple.com>
1931
1932         Fix recently-introduced off-by-one error in centerTruncateToBuffer
1933         https://bugs.webkit.org/show_bug.cgi?id=130889
1934
1935         Reviewed by Alexey Proskuryakov.
1936
1937         * Misc/WebStringTruncator.mm:
1938         (defaultMenuFont): Changed to use NeverDestroyed since I had to touch this file anyway.
1939         (fontFromNSFont): Ditto. Also improved variable names a bit.
1940         (+[WebStringTruncator initialize]): Added threading initialization, needed for main
1941         thread assertions in string truncator code.
1942
1943 2014-03-27  Commit Queue  <commit-queue@webkit.org>
1944
1945         Unreviewed, rolling out r166360.
1946         https://bugs.webkit.org/show_bug.cgi?id=130869
1947
1948         Seems to have broken PLT (Requested by ap on #webkit).
1949
1950         Reverted changeset:
1951
1952         "Connection::dispatchOneMessage() can be re-entered while
1953         handling Cmd-key menu"
1954         https://bugs.webkit.org/show_bug.cgi?id=130767
1955         http://trac.webkit.org/changeset/166360
1956
1957 2014-03-27  Alexey Proskuryakov  <ap@apple.com>
1958
1959         Connection::dispatchOneMessage() can be re-entered while handling Cmd-key menu
1960         equivalents, ASSERT(!_data->_keyDownEventBeingResent)
1961         https://bugs.webkit.org/show_bug.cgi?id=130767
1962         <rdar://problem/16307487>
1963
1964         Reviewed by Darin Adler.
1965
1966         Switched to a WebCore wrapper for RunLoop::initializeMainRunLoop that adds
1967         NSModalPanelRunLoopMode to RunLoop event source and timer modes.
1968
1969         * Carbon/CarbonWindowAdapter.mm: (+[CarbonWindowAdapter initialize]):
1970         * History/WebBackForwardList.mm: (+[WebBackForwardList initialize]):
1971         * History/WebHistoryItem.mm: (+[WebHistoryItem initialize]):
1972         * Misc/WebCache.mm: (+[WebCache initialize]):
1973         * Misc/WebElementDictionary.mm: (+[WebElementDictionary initialize]):
1974         * Misc/WebIconDatabase.mm: (+[WebIconDatabase initialize]):
1975         * Plugins/Hosted/WebHostedNetscapePluginView.mm: (+[WebHostedNetscapePluginView initialize]):
1976         * Plugins/WebBaseNetscapePluginView.mm:
1977         * Plugins/WebBasePluginPackage.mm:
1978         * Plugins/WebNetscapePluginView.mm: (+[WebNetscapePluginView initialize]):
1979         * WebCoreSupport/WebEditorClient.mm: (+[WebUndoStep initialize]):
1980         * WebCoreSupport/WebFrameLoaderClient.mm:
1981         * WebView/WebArchive.mm: (+[WebArchivePrivate initialize]):
1982         * WebView/WebDataSource.mm: (+[WebDataSource initialize]):
1983         * WebView/WebHTMLView.mm:
1984         (+[WebHTMLViewPrivate initialize]):
1985         (+[WebHTMLView initialize]):
1986         * WebView/WebPreferences.mm: (+[WebPreferences initialize]):
1987         * WebView/WebResource.mm: (+[WebResourcePrivate initialize]):
1988         * WebView/WebTextIterator.mm: (+[WebTextIteratorPrivate initialize]):
1989         * WebView/WebView.mm: (+[WebView initialize]):
1990         * WebView/WebViewData.mm: (+[WebViewPrivate initialize]):
1991
1992 2014-03-26  Timothy Hatcher  <timothy@apple.com>
1993
1994         Propagate the hiddenFromInspector flag on ResourceRequest in
1995         places when a new request a made or passed between processes.
1996
1997         https://bugs.webkit.org/show_bug.cgi?id=130741
1998
1999         Reviewed by Joseph Pecoraro.
2000
2001         * WebCoreSupport/WebFrameLoaderClient.mm:
2002         (WebFrameLoaderClient::dispatchWillSendRequest): Copy hiddenFromInspector to
2003         the new request.
2004
2005 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
2006
2007         [CSS Shapes] Remove shape-inside support
2008         https://bugs.webkit.org/show_bug.cgi?id=130698
2009
2010         Reviewed by David Hyatt.
2011
2012         * Configurations/FeatureDefines.xcconfig:
2013
2014 2014-03-25  Joseph Pecoraro  <pecoraro@apple.com>
2015
2016         [iOS] Inspector View Indication Support
2017         https://bugs.webkit.org/show_bug.cgi?id=130709
2018
2019         Reviewed by Simon Fraser.
2020
2021         * WebCoreSupport/WebInspectorClient.h:
2022         * WebCoreSupport/WebInspectorClient.mm:
2023         (WebInspectorClient::didSetSearchingForNode): Deleted.
2024         (WebInspectorClient::releaseFrontend): Deleted.
2025         * WebView/WebView.mm:
2026         (-[WebView setShowingInspectorIndication:]):
2027         * WebView/WebViewPrivate.h:
2028         Renamed methods.
2029
2030 2014-03-24  Brent Fulgham  <bfulgham@apple.com>
2031
2032         Activate WebVTT Tests Once Merging is Complete
2033         https://bugs.webkit.org/show_bug.cgi?id=130420
2034
2035         Reviewed by Eric Carlson.
2036
2037         * Configurations/FeatureDefines.xcconfig: Turn on ENABLE(WEBVTT_REGIONS)
2038
2039 2014-03-24  Andy Estes  <aestes@apple.com>
2040
2041         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
2042         https://bugs.webkit.org/show_bug.cgi?id=129322
2043
2044         Reviewed by Anders Carlsson.
2045
2046         * WebCoreSupport/WebFrameLoaderClient.mm:
2047         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Use the
2048         RetainPtr returned by releaseConnectionForDownload() rather than
2049         manually releasing.
2050
2051 2014-03-24  Jon Lee  <jonlee@apple.com>
2052
2053         Build fixes.
2054
2055         Unreviewed.
2056
2057         * WebInspector/WebNodeHighlightView.mm: Missing include to GeometryUtilities.
2058
2059 2014-03-23  Sam Weinig  <sam@webkit.org>
2060
2061         Remove some unnecessary .get()s that Darin noticed.
2062
2063         * WebView/WebHTMLRepresentation.mm:
2064         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
2065         * WebView/WebHTMLView.mm:
2066         (-[WebHTMLView attributedString]):
2067
2068 2014-03-23  Sam Weinig  <sam@webkit.org>
2069
2070         Simplify the HTMLConverter interface (Part 2)
2071         https://bugs.webkit.org/show_bug.cgi?id=130654
2072
2073         Reviewed by Darin Adler.
2074
2075         * WebView/WebHTMLRepresentation.mm:
2076         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
2077         * WebView/WebHTMLView.mm:
2078         (-[WebHTMLView attributedSubstringFromRange:]):
2079         (-[WebHTMLView attributedString]):
2080         (-[WebHTMLView selectedAttributedString]):
2081
2082 2014-03-23  Darin Adler  <darin@apple.com>
2083
2084         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
2085         https://bugs.webkit.org/show_bug.cgi?id=130653
2086
2087         Reviewed by Antti Koivisto.
2088
2089         * WebCoreSupport/WebFrameLoaderClient.mm: Call toHTMLPlugInImageElement instead of
2090         doing a static_cast.
2091
2092 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
2093
2094         Don't flush compositing layers within FrameView::willPaintContents()
2095         https://bugs.webkit.org/show_bug.cgi?id=130627
2096
2097         Reviewed by Sam Weinig.
2098         
2099         Make _flushCompositingChanges private so DRT can call it;
2100         moved it into the Private category.
2101
2102         * WebView/WebView.mm:
2103         (-[WebView _flushCompositingChanges]):
2104         * WebView/WebViewPrivate.h:
2105
2106 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
2107
2108         Remove duplicate line added during merging
2109         https://bugs.webkit.org/show_bug.cgi?id=130623
2110
2111         Reviewed by Beth Dakin.
2112         
2113         Remove a duplicate call to -_viewWillDrawInternal which
2114         was added during merges.
2115
2116         * WebView/WebView.mm:
2117         (LayerFlushController::flushLayers):
2118
2119 2014-03-21  Darin Adler  <darin@apple.com>
2120
2121         Improve idiom used for string building in a few places
2122         https://bugs.webkit.org/show_bug.cgi?id=130561
2123
2124         Reviewed by Andreas Kling.
2125
2126         * WebView/WebHTMLRepresentation.mm:
2127         (regExpForLabels): Use StringBuilder.
2128
2129 2014-03-21  Darin Adler  <darin@apple.com>
2130
2131         Add a combined decodeAndFlush to TextResourceDecoder
2132         https://bugs.webkit.org/show_bug.cgi?id=130560
2133
2134         Reviewed by Andreas Kling.
2135
2136         * WebView/WebView.mm:
2137         (+[WebView _decodeData:]): Use decodeAndFlush.
2138
2139 2014-03-20  Anders Carlsson  <andersca@apple.com>
2140
2141         Fix build.
2142
2143         * MigrateHeaders.make:
2144
2145 2014-03-20  Pratik Solanki  <psolanki@apple.com>
2146
2147         [iOS] Get code to compile on older iOS versions
2148         https://bugs.webkit.org/show_bug.cgi?id=130142
2149         <rdar://problem/16302908>
2150
2151         Reviewed by Darin Adler.
2152
2153         * History/WebHistory.mm:
2154         (getDayBoundaries):
2155         * Plugins/WebPluginController.h:
2156         * Plugins/WebPluginController.mm:
2157         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2158         * WebCoreSupport/WebFrameLoaderClient.mm:
2159         (pluginView):
2160         * WebView/WebPreferences.mm:
2161         (-[WebPreferences _setAllowCompositingLayerVisualDegradation:]):
2162         * WebView/WebPreferencesPrivate.h:
2163
2164 2014-03-20  Lucas Forschler  <lforschler@apple.com>
2165
2166     Rollout r165944.  Build break.
2167     
2168 2014-03-19  Pratik Solanki  <psolanki@apple.com>
2169
2170         [iOS] Get code to compile on older iOS versions
2171         https://bugs.webkit.org/show_bug.cgi?id=130142
2172         <rdar://problem/16302908>
2173
2174         Reviewed by Darin Adler.
2175
2176         * History/WebHistory.mm:
2177         (getDayBoundaries):
2178         * Plugins/WebPluginController.h:
2179         * Plugins/WebPluginController.mm:
2180         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2181         * WebCoreSupport/WebFrameLoaderClient.mm:
2182         (pluginView):
2183         * WebView/WebPreferences.mm:
2184         (-[WebPreferences _setAllowCompositingLayerVisualDegradation:]):
2185         * WebView/WebPreferencesPrivate.h:
2186
2187 2014-03-19  Jer Noble  <jer.noble@apple.com>
2188
2189         [Mac][EME] Query whether decoder support exists before creating a new MediaKeys object.
2190         https://bugs.webkit.org/show_bug.cgi?id=130459
2191
2192         Reviewed by Eric Carlson.
2193
2194         * WebCoreSupport/WebSystemInterface.mm:
2195         (InitWebCoreSystemInterface): Initialize the new WCSI method.
2196
2197 2014-03-19  Brady Eidson  <beidson@apple.com>
2198
2199         Filter out editable services from image menu for non-contenteditable images
2200         <rdar://problem/16319645> and https://bugs.webkit.org/show_bug.cgi?id=130437
2201
2202         Reviewed by Tim Horton.
2203
2204         * Misc/WebSharingServicePickerController.h:
2205         * Misc/WebSharingServicePickerController.mm:
2206         (-[WebSharingServicePickerController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
2207           Filter out editing services based on the includeEditorServices flag.
2208         * WebCoreSupport/WebContextMenuClient.mm:
2209         (WebContextMenuClient::contextMenuForEvent):
2210
2211 2014-03-19  Jer Noble  <jer.noble@apple.com>
2212
2213         [iOS] Disable the video plugin proxy by default on WK1.
2214         https://bugs.webkit.org/show_bug.cgi?id=130460
2215
2216         Reviewed by Eric Carlson.
2217
2218         Update the defaults to universally enable the AVFoundationEnabled preference, disable the
2219         VideoPluginProxyEnabled preference, and on iOS only enable the AVKitEnabled preference.
2220
2221         * WebView/WebPreferences.mm:
2222         (+[WebPreferences initialize]):
2223
2224 2014-03-18  Samuel White  <samuel_white@apple.com>
2225
2226         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
2227         https://bugs.webkit.org/show_bug.cgi?id=130250
2228
2229         Reviewed by Chris Fleizach.
2230
2231         Added ability to toggle enhanced accessibility on and off to support tests that require it.
2232
2233         * WebView/WebFrame.mm:
2234         (-[WebFrame enhancedAccessibilityEnabled]):
2235         (-[WebFrame setEnhancedAccessibility:]):
2236         * WebView/WebFramePrivate.h:
2237
2238 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
2239
2240         More FTL enabling.
2241
2242         Rubber stamped by Dan Bernstein.
2243
2244         * Configurations/FeatureDefines.xcconfig:
2245
2246 2014-03-17  Andy Estes  <aestes@apple.com>
2247
2248         Remove staging code added for <http://webkit.org/b/129358> [iOS] Support network state notification using CPNetworkObserver
2249
2250         Reviewed by Enrica Casucci.
2251
2252         * WebView/WebView.mm:
2253
2254 2014-03-17  Anders Carlsson  <andersca@apple.com>
2255
2256         WebKitLegacy headers should #import the relevant WebKit headers
2257         https://bugs.webkit.org/show_bug.cgi?id=130372
2258         <rdar://problem/16349094>
2259
2260         Reviewed by Dan Bernstein.
2261
2262         Create forwarding headers instead.
2263
2264         * WebKitLegacy/MigrateHeadersToLegacy.make:
2265
2266 2014-03-17  Tim Horton  <timothy_horton@apple.com>
2267
2268         Rename WKThumbnailView to _WKThumbnailView
2269         https://bugs.webkit.org/show_bug.cgi?id=130361
2270
2271         Reviewed by Anders Carlsson.
2272
2273         * MigrateHeaders.make:
2274
2275 2014-03-17  David Farler  <dfarler@apple.com>
2276
2277         REGRESSION: WebKitLegacy causes ASan build to fail
2278         <rdar://problem/16344326>
2279
2280         Reviewed by David Kilzer.
2281
2282         * Configurations/DebugRelease.xcconfig: Remove $(inherited) from
2283         OTHER_CFLAGS, OTHER_CPLUSPLUSFLAGS, OTHER_LDFLAGS to prevent
2284         double complete ASAN flags.
2285
2286 2014-03-16  Brent Fulgham  <bfulgham@apple.com>
2287
2288         Provide preference to enable additional AVFoundation options
2289         https://bugs.webkit.org/show_bug.cgi?id=130275
2290
2291         Reviewed by Eric Carlson.
2292
2293         * WebView/WebPreferenceKeysPrivate.h: Added new preference.
2294         * WebView/WebPreferences.mm:
2295         (+[WebPreferences initialize]): Initialize preference to false.
2296         (-[WebPreferences isInheritURIQueryComponentEnabled]): Added.
2297         (-[WebPreferences setEnableInheritURIQueryComponent:]): Added.
2298         * WebView/WebPreferencesPrivate.h:
2299         * WebView/WebView.mm:
2300         (-[WebView _preferencesChanged:]): Handle new preference.
2301
2302 2014-03-16  Darin Adler  <darin@apple.com>
2303
2304         Remove all deprecatedCharacters use from WebKit directory
2305         https://bugs.webkit.org/show_bug.cgi?id=130305
2306
2307         Reviewed by Andreas Kling.
2308
2309         * History/BinaryPropertyList.cpp:
2310         (BinaryPropertyListSerializer::appendStringObject): Use operator[]
2311         instead of deprecatedCharacters.
2312
2313 2014-03-14  Mark Rowe  <mrowe@apple.com>
2314
2315         Fix the production build.
2316
2317         Don't rely on USE_INTERNAL_SDK being set for the Production configuration since UseInternalSDK.xcconfig won't
2318         be at the expected relative path when working from installed source.
2319
2320         * Configurations/Base.xcconfig:
2321
2322 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
2323
2324         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
2325         https://bugs.webkit.org/show_bug.cgi?id=130276
2326         <rdar://problem/16266927>
2327         
2328         Reviewed by Simon Fraser.
2329
2330         * Carbon/CarbonUtils.h:
2331         * Carbon/CarbonUtils.m:
2332         * Carbon/CarbonWindowAdapter.h:
2333         * Carbon/CarbonWindowAdapter.mm:
2334         * Carbon/CarbonWindowContentView.h:
2335         * Carbon/CarbonWindowContentView.m:
2336         * Carbon/CarbonWindowFrame.h:
2337         * Carbon/CarbonWindowFrame.m:
2338         * Carbon/HIViewAdapter.h:
2339         * Carbon/HIViewAdapter.m:
2340         * Carbon/HIWebView.h:
2341         * Carbon/HIWebView.mm:
2342         * DOM/WebDOMOperations.h:
2343         * DOM/WebDOMOperations.mm:
2344         * DOM/WebDOMOperationsInternal.h:
2345         * DOM/WebDOMOperationsPrivate.h:
2346         * DefaultDelegates/WebDefaultContextMenuDelegate.h:
2347         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2348         * DefaultDelegates/WebDefaultEditingDelegate.h:
2349         * DefaultDelegates/WebDefaultEditingDelegate.m:
2350         * DefaultDelegates/WebDefaultPolicyDelegate.h:
2351         * DefaultDelegates/WebDefaultPolicyDelegate.m:
2352         * DefaultDelegates/WebDefaultUIDelegate.h:
2353         * DefaultDelegates/WebDefaultUIDelegate.m:
2354         * History/WebBackForwardList.h:
2355         * History/WebBackForwardList.mm:
2356         * History/WebBackForwardListInternal.h:
2357         * History/WebBackForwardListPrivate.h:
2358         * History/WebHistory.h:
2359         * History/WebHistory.mm:
2360         * History/WebHistoryInternal.h:
2361         * History/WebHistoryItem.h:
2362         * History/WebHistoryItem.mm:
2363         * History/WebHistoryItemInternal.h:
2364         * History/WebHistoryItemPrivate.h:
2365         * History/WebHistoryPrivate.h:
2366         * History/WebURLsWithTitles.h:
2367         * History/WebURLsWithTitles.m:
2368         * MigrateHeaders.make:
2369         * Misc/OldWebAssertions.c:
2370         * Misc/WebCache.h:
2371         * Misc/WebCache.mm:
2372         * Misc/WebCoreStatistics.h:
2373         * Misc/WebCoreStatistics.mm:
2374         * Misc/WebDownload.h:
2375         * Misc/WebDownload.mm:
2376         * Misc/WebDownloadInternal.h:
2377         * Misc/WebElementDictionary.h:
2378         * Misc/WebElementDictionary.mm:
2379         * Misc/WebIconDatabase.h:
2380         * Misc/WebIconDatabase.mm:
2381         * Misc/WebIconDatabaseDelegate.h:
2382         * Misc/WebIconDatabaseInternal.h:
2383         * Misc/WebIconDatabasePrivate.h:
2384         * Misc/WebKit.h:
2385         * Misc/WebKitErrors.h:
2386         * Misc/WebKitErrors.m:
2387         * Misc/WebKitErrorsPrivate.h:
2388         * Misc/WebKitLogging.h:
2389         * Misc/WebKitLogging.m:
2390         * Misc/WebKitNSStringExtras.h:
2391         * Misc/WebKitNSStringExtras.mm:
2392         * Misc/WebKitStatistics.h:
2393         * Misc/WebKitStatistics.m:
2394         * Misc/WebKitStatisticsPrivate.h:
2395         * Misc/WebKitSystemBits.h:
2396         * Misc/WebKitSystemBits.m:
2397         * Misc/WebKitVersionChecks.h:
2398         * Misc/WebKitVersionChecks.m:
2399         * Misc/WebLocalizableStrings.h:
2400         * Misc/WebLocalizableStrings.mm:
2401         * Misc/WebNSArrayExtras.h:
2402         * Misc/WebNSArrayExtras.m:
2403         * Misc/WebNSControlExtras.h:
2404         * Misc/WebNSControlExtras.m:
2405         * Misc/WebNSDataExtras.h:
2406         * Misc/WebNSDataExtras.m:
2407         * Misc/WebNSDataExtrasPrivate.h:
2408         * Misc/WebNSDictionaryExtras.h:
2409         * Misc/WebNSDictionaryExtras.m:
2410         * Misc/WebNSEventExtras.h:
2411         * Misc/WebNSEventExtras.m:
2412         * Misc/WebNSFileManagerExtras.h:
2413         * Misc/WebNSFileManagerExtras.mm:
2414         * Misc/WebNSImageExtras.h:
2415         * Misc/WebNSImageExtras.m:
2416         * Misc/WebNSObjectExtras.h:
2417         * Misc/WebNSObjectExtras.mm:
2418         * Misc/WebNSPasteboardExtras.h:
2419         * Misc/WebNSPasteboardExtras.mm:
2420         * Misc/WebNSPrintOperationExtras.h:
2421         * Misc/WebNSPrintOperationExtras.m:
2422         * Misc/WebNSURLExtras.h:
2423         * Misc/WebNSURLExtras.mm:
2424         * Misc/WebNSURLRequestExtras.h:
2425         * Misc/WebNSURLRequestExtras.m:
2426         * Misc/WebNSUserDefaultsExtras.h:
2427         * Misc/WebNSUserDefaultsExtras.mm:
2428         * Misc/WebNSViewExtras.h:
2429         * Misc/WebNSViewExtras.m:
2430         * Misc/WebNSWindowExtras.h:
2431         * Misc/WebNSWindowExtras.m:
2432         * Misc/WebStringTruncator.h:
2433         * Misc/WebStringTruncator.mm:
2434         * Misc/WebTypesInternal.h:
2435         * Panels/WebAuthenticationPanel.h:
2436         * Panels/WebAuthenticationPanel.m:
2437         * Panels/WebPanelAuthenticationHandler.h:
2438         * Panels/WebPanelAuthenticationHandler.m:
2439         * Plugins/Hosted/ProxyRuntimeObject.h:
2440         * Plugins/Hosted/ProxyRuntimeObject.mm:
2441         * Plugins/WebBaseNetscapePluginView.h:
2442         * Plugins/WebBaseNetscapePluginView.mm:
2443         * Plugins/WebBasePluginPackage.h:
2444         * Plugins/WebBasePluginPackage.mm:
2445         * Plugins/WebJavaPlugIn.h:
2446         * Plugins/WebNetscapeContainerCheckContextInfo.h:
2447         * Plugins/WebNetscapeContainerCheckPrivate.h:
2448         * Plugins/WebNetscapeContainerCheckPrivate.mm:
2449         * Plugins/WebNetscapePluginPackage.h:
2450         * Plugins/WebNetscapePluginPackage.mm:
2451         * Plugins/WebNetscapePluginStream.h:
2452         * Plugins/WebNetscapePluginStream.mm:
2453         * Plugins/WebNetscapePluginView.h:
2454         * Plugins/WebNetscapePluginView.mm:
2455         * Plugins/WebPlugin.h:
2456         * Plugins/WebPluginContainer.h:
2457         * Plugins/WebPluginContainerCheck.h:
2458         * Plugins/WebPluginContainerCheck.mm:
2459         * Plugins/WebPluginContainerPrivate.h:
2460         * Plugins/WebPluginController.h:
2461         * Plugins/WebPluginController.mm:
2462         * Plugins/WebPluginDatabase.h:
2463         * Plugins/WebPluginDatabase.mm:
2464         * Plugins/WebPluginPackage.h:
2465         * Plugins/WebPluginPackage.mm:
2466         * Plugins/WebPluginRequest.h:
2467         * Plugins/WebPluginRequest.m:
2468         * Plugins/WebPluginViewFactory.h:
2469         * Plugins/WebPluginViewFactoryPrivate.h:
2470         * Plugins/WebPluginsPrivate.h:
2471         * Plugins/WebPluginsPrivate.m:
2472         * Plugins/npapi.mm:
2473         * Storage/WebDatabaseManager.mm:
2474         * Storage/WebDatabaseManagerInternal.h:
2475         * Storage/WebDatabaseManagerPrivate.h:
2476         * WebCoreSupport/SearchPopupMenuMac.mm:
2477         * WebCoreSupport/WebAlternativeTextClient.h:
2478         * WebCoreSupport/WebAlternativeTextClient.mm:
2479         * WebCoreSupport/WebCachedFramePlatformData.h:
2480         * WebCoreSupport/WebChromeClient.h:
2481         * WebCoreSupport/WebChromeClient.mm:
2482         * WebCoreSupport/WebContextMenuClient.h:
2483         * WebCoreSupport/WebContextMenuClient.mm:
2484         * WebCoreSupport/WebDragClient.h:
2485         * WebCoreSupport/WebDragClient.mm:
2486         * WebCoreSupport/WebEditorClient.h:
2487         * WebCoreSupport/WebEditorClient.mm:
2488         * WebCoreSupport/WebFrameLoaderClient.h:
2489         * WebCoreSupport/WebFrameLoaderClient.mm:
2490         * WebCoreSupport/WebIconDatabaseClient.h:
2491         * WebCoreSupport/WebIconDatabaseClient.mm:
2492         * WebCoreSupport/WebInspectorClient.h:
2493         * WebCoreSupport/WebInspectorClient.mm:
2494         * WebCoreSupport/WebJavaScriptTextInputPanel.h:
2495         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2496         * WebCoreSupport/WebSecurityOrigin.mm:
2497         * WebCoreSupport/WebSecurityOriginInternal.h:
2498         * WebCoreSupport/WebSecurityOriginPrivate.h:
2499         * WebCoreSupport/WebSystemInterface.h:
2500         * WebCoreSupport/WebSystemInterface.mm:
2501         * WebInspector/WebInspector.h:
2502         * WebInspector/WebInspector.mm:
2503         * WebInspector/WebInspectorPrivate.h:
2504         * WebInspector/WebNodeHighlight.h:
2505         * WebInspector/WebNodeHighlight.mm:
2506         * WebInspector/WebNodeHighlightView.h:
2507         * WebInspector/WebNodeHighlightView.mm:
2508         * WebInspector/WebNodeHighlighter.h:
2509         * WebInspector/WebNodeHighlighter.mm:
2510         * WebKitLegacy/MigrateHeadersToLegacy.make:
2511         * WebKitPrefix.h:
2512         * WebView/WebArchive.h:
2513         * WebView/WebArchive.mm:
2514         * WebView/WebArchiveInternal.h:
2515         * WebView/WebClipView.h:
2516         * WebView/WebClipView.mm:
2517         * WebView/WebDashboardRegion.h:
2518         * WebView/WebDashboardRegion.mm:
2519         * WebView/WebDataSource.h:
2520         * WebView/WebDataSource.mm:
2521         * WebView/WebDataSourceInternal.h:
2522         * WebView/WebDataSourcePrivate.h:
2523         * WebView/WebDelegateImplementationCaching.h:
2524         * WebView/WebDelegateImplementationCaching.mm:
2525         * WebView/WebDocument.h:
2526         * WebView/WebDocumentInternal.h:
2527         * WebView/WebDocumentLoaderMac.h:
2528         * WebView/WebDocumentLoaderMac.mm:
2529         * WebView/WebDocumentPrivate.h:
2530         * WebView/WebDynamicScrollBarsViewInternal.h:
2531         * WebView/WebEditingDelegate.h:
2532         * WebView/WebEditingDelegatePrivate.h:
2533         * WebView/WebFormDelegate.h:
2534         * WebView/WebFormDelegate.m:
2535         * WebView/WebFormDelegatePrivate.h:
2536         * WebView/WebFrame.h:
2537         * WebView/WebFrame.mm:
2538         * WebView/WebFrameInternal.h:
2539         * WebView/WebFrameLoadDelegate.h:
2540         * WebView/WebFrameLoadDelegatePrivate.h:
2541         * WebView/WebFramePrivate.h:
2542         * WebView/WebFrameView.h:
2543         * WebView/WebFrameView.mm:
2544         * WebView/WebFrameViewInternal.h:
2545         * WebView/WebFrameViewPrivate.h:
2546         * WebView/WebHTMLRepresentation.h:
2547         * WebView/WebHTMLRepresentation.mm:
2548         * WebView/WebHTMLRepresentationPrivate.h:
2549         * WebView/WebHTMLView.h:
2550         * WebView/WebHTMLView.mm:
2551         * WebView/WebHTMLViewInternal.h:
2552         * WebView/WebHTMLViewPrivate.h:
2553         * WebView/WebNotification.h:
2554         * WebView/WebNotification.mm:
2555         * WebView/WebNotificationInternal.h:
2556         * WebView/WebPDFRepresentation.h:
2557         * WebView/WebPDFRepresentation.mm:
2558         * WebView/WebPDFView.h:
2559         * WebView/WebPDFView.mm:
2560         * WebView/WebPolicyDelegate.h:
2561         * WebView/WebPolicyDelegate.mm:
2562         * WebView/WebPolicyDelegatePrivate.h:
2563         * WebView/WebPreferenceKeysPrivate.h:
2564         * WebView/WebPreferences.h:
2565         * WebView/WebPreferences.mm:
2566         * WebView/WebPreferencesPrivate.h:
2567         * WebView/WebRenderLayer.h:
2568         * WebView/WebRenderLayer.mm:
2569         * WebView/WebRenderNode.h:
2570         * WebView/WebRenderNode.mm:
2571         * WebView/WebResource.h:
2572         * WebView/WebResource.mm:
2573         * WebView/WebResourceInternal.h:
2574         * WebView/WebResourceLoadDelegate.h:
2575         * WebView/WebResourceLoadDelegatePrivate.h:
2576         * WebView/WebResourcePrivate.h:
2577         * WebView/WebScriptDebugDelegate.h:
2578         * WebView/WebScriptDebugDelegate.mm:
2579         * WebView/WebScriptDebugger.h:
2580         * WebView/WebScriptDebugger.mm:
2581         * WebView/WebTextCompletionController.mm:
2582         * WebView/WebUIDelegate.h:
2583         * WebView/WebUIDelegatePrivate.h:
2584         * WebView/WebView.h:
2585         * WebView/WebView.mm:
2586         * WebView/WebViewData.h:
2587         * WebView/WebViewData.mm:
2588         * WebView/WebViewInternal.h:
2589         * WebView/WebViewPrivate.h:
2590
2591 2014-03-14  Ryosuke Niwa  <rniwa@webkit.org>
2592
2593         REGRESSION(r165385): [WebTextIterator currentRange] crashes
2594         https://bugs.webkit.org/show_bug.cgi?id=130271
2595
2596         Reviewed by Anders Carlsson.
2597
2598         After r165385, TextIterator::range no longer checked the nullity of m_positionNode. As a result,
2599         [WebTextIterator currentRange] which simply calls TextIterator::range crashes when an application
2600         that embeds WebKit doesn't check [WebTextIterator atEnd] first.
2601
2602         Preserve the old public API behavior by checking atEnd in [WebTextIterator currentRange].
2603
2604         * WebView/WebTextIterator.mm:
2605         (-[WebTextIterator currentRange]):
2606
2607 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
2608
2609         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
2610         https://bugs.webkit.org/show_bug.cgi?id=129612
2611
2612         Reviewed by Darin Adler.
2613
2614         For new code use static NeverDestroyed<T> instead.
2615
2616         * History/WebBackForwardList.mm:
2617         (backForwardLists):
2618         * History/WebHistoryItem.mm:
2619         (historyItemWrappers):
2620         * Misc/WebNSPasteboardExtras.mm:
2621         (+[NSPasteboard _web_writableTypesForURL]):
2622         (_writableTypesForImageWithoutArchive):
2623         (_writableTypesForImageWithArchive):
2624         * Misc/WebStringTruncator.mm:
2625         (fontFromNSFont):
2626         * Plugins/Hosted/NetscapePluginHostManager.mm:
2627         (WebKit::NetscapePluginHostManager::shared):
2628         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2629         (WebKit::pluginProxyMap):
2630         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2631         (WebKit::globalExceptionString):
2632         * Plugins/Hosted/ProxyInstance.mm:
2633         (WebKit::proxyClass):
2634         * Plugins/WebNetscapePluginStream.mm:
2635         (streams):
2636         * Storage/WebDatabaseManager.mm:
2637         (transactionBackgroundTaskIdentifierLock):
2638         * WebCoreSupport/WebUserMediaClient.mm:
2639         (userMediaRequestsMap):
2640         * WebView/WebHTMLRepresentation.mm:
2641         (regExpForLabels):
2642         * WebView/WebView.mm:
2643         (aeDescFromJSValue):
2644
2645 2014-03-13  Tim Horton  <timothy_horton@apple.com>
2646
2647         Fix relative paths to UseInternalSDK.xcconfig for ANGLE and WebKit/mac
2648
2649         Rubber-stamped by Mark Rowe.
2650
2651         One-too-few "..".
2652
2653         * Configurations/Base.xcconfig:
2654
2655 2014-03-13  Anders Carlsson  <andersca@apple.com>
2656
2657         Fix build.
2658
2659         * Misc/WebSharingServicePickerController.mm:
2660
2661 2014-03-13  Radu Stavila  <stavila@adobe.com>
2662
2663         Webkit not building on XCode 5.1 due to garbage collection no longer being supported
2664         https://bugs.webkit.org/show_bug.cgi?id=130087
2665
2666         Reviewed by Mark Rowe.
2667
2668         Disable garbage collection on macosx when not using internal SDK.
2669
2670         * Configurations/Base.xcconfig:
2671
2672 2014-03-10  Darin Adler  <darin@apple.com>
2673
2674         Avoid copy-prone idiom "for (auto item : collection)"
2675         https://bugs.webkit.org/show_bug.cgi?id=129990
2676
2677         Reviewed by Geoffrey Garen.
2678
2679         * WebView/WebFrame.mm:
2680         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
2681         Use auto*. Also removed uneeded ASSERT_NO_EXCEPTION, which is already
2682         the default without specifying it explicitly.
2683
2684 2014-03-12  Brian Burg  <bburg@apple.com>
2685
2686         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
2687         https://bugs.webkit.org/show_bug.cgi?id=129744
2688
2689         Reviewed by Timothy Hatcher.
2690
2691         * WebInspector/WebInspector.mm:
2692         (-[WebInspector evaluateInFrontend:script:]):
2693         * WebInspector/WebInspectorPrivate.h:
2694
2695 2014-03-12  Dean Jackson  <dino@apple.com>
2696
2697         [WebGL] WebKit1 + WebKit2 iOS clients should check load policy
2698         https://bugs.webkit.org/show_bug.cgi?id=130162
2699
2700         Reviewed by Simon Fraser.
2701
2702         Implement the webGLPolicyForURL methods, calling into WebKitSystemInterface.
2703
2704         * Configurations/WebKit.xcconfig: Add MobileAsset to iOS config.
2705         * WebCoreSupport/WebFrameLoaderClient.h:
2706         * WebCoreSupport/WebFrameLoaderClient.mm:
2707
2708 2014-03-12  Joseph Pecoraro  <pecoraro@apple.com>
2709
2710         Web Inspector: Disable REMOTE_INSPECTOR in earlier OS X releases
2711         https://bugs.webkit.org/show_bug.cgi?id=130118
2712
2713         Reviewed by Timothy Hatcher.
2714
2715         * Configurations/FeatureDefines.xcconfig:
2716
2717         * WebCoreSupport/WebInspectorClient.mm:
2718         (WebInspectorClient::indicate):
2719         (WebInspectorClient::hideIndication):
2720         Properly guard REMOTE_INSPECTOR only calls.
2721
2722 2014-03-12  Tim Horton  <timothy_horton@apple.com>
2723
2724         Build fix for ENABLE(IMAGE_CONTROLS) after 165479
2725
2726         * Misc/WebSharingServicePickerController.h:
2727         * Misc/WebSharingServicePickerController.mm:
2728         Don't use new-runtime features in code that has to build 32-bit.
2729
2730 2014-03-12  Anders Carlsson  <andersca@apple.com>
2731
2732         <rdar://problem/16307346> Add new WebKitLegacy.framework.
2733
2734         Reviewed by Dan Bernstein.
2735
2736         * Configurations/WebKitLegacy.xcconfig:
2737         Add xcconfig file for the new framework.
2738
2739         * WebKitLegacy/Info.plist:
2740         Add Info.plist for WebKitLegacy.framework.
2741
2742         * WebKitLegacy/MigrateHeadersToLegacy.make:
2743         Add makefile that copies headers from WebKit to WebKitLegacy and rewrites includes from WebKit/ to WebKitLegacy/
2744         * WebKitLegacy/WebKitLegacy.cpp:
2745         Add an empty file so we'll have something to link.
2746
2747 2014-03-12  Tim Horton  <timothy_horton@apple.com>
2748
2749         Hook up image controls for WebKit1
2750         https://bugs.webkit.org/show_bug.cgi?id=130062
2751         <rdar://problem/15964809>
2752
2753         Reviewed by Brady Eidson.
2754
2755         * Misc/WebSharingServicePickerController.h: Added.
2756         * Misc/WebSharingServicePickerController.mm: Added.
2757         (-[WebSharingServicePickerController initWithImage:menuClient:]):
2758         (-[WebSharingServicePickerController menu]):
2759         (-[WebSharingServicePickerController sharingServicePicker:delegateForSharingService:]):
2760         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
2761         (-[WebSharingServicePickerController sharingService:didShareItems:]):
2762         (-[WebSharingServicePickerController sharingService:didFailToShareItems:error:]):
2763         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2764         Add a NSSharingServiceDelegate and NSSharingServicePickerDelegate, which will also
2765         provide a NSMenu instance for WebContextMenuClient to pop up when image controls are needed.
2766         When data is returned from the service, it is re-inserted into the image via replaceControlledImage.
2767
2768         * WebCoreSupport/WebContextMenuClient.h:
2769         * WebCoreSupport/WebContextMenuClient.mm:
2770         (WebContextMenuClient::contextMenuForEvent):
2771         Factor out code to decide which NSMenu to use, so that we can use early-returns to simplify it.
2772         If we hit an image with image controls, use the WebSharingServicePickerController's menu.
2773
2774         (WebContextMenuClient::showContextMenu):
2775         (WebContextMenuClient::clearSharingServicePickerController):
2776
2777 2014-03-10  Jer Noble  <jer.noble@apple.com>
2778
2779         [iOS][WK1] Crash in HTMLMediaElement::createElementRenderer() - "-[NSSet addObject:]: object cannot be nil"
2780         https://bugs.webkit.org/show_bug.cgi?id=129634
2781
2782         Reviewed by Eric Carlson.
2783
2784         If a plugin fails to create a NSView, a nil object is inserted into the WebPluginController's
2785         pluginViews set. This is an exceptional case, so add an ASSERT so that this error will continue
2786         to occur in debug builds, but also add an early return so as not to crash release builds.
2787
2788         * Plugins/WebPluginController.mm:
2789         (+[WebPluginController addPlugInView:]):
2790
2791 2014-03-06  Alexey Proskuryakov  <ap@apple.com>
2792
2793         [Mac] Don't perform a round-trip through WebProcess before interpreting key events
2794         https://bugs.webkit.org/show_bug.cgi?id=129812
2795
2796         Reviewed by Darin Adler.
2797
2798         * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleInputMethodKeydown):
2799         Added a FIXME. WebKit1/mac is the only port that uses this roundabout way to
2800         interpret events, so it would simplify code if we switched it to WebKit2/mac model.
2801
2802 2014-03-08  Simon Fraser  <simon.fraser@apple.com>
2803
2804         [iOS Wk2] Can't scroll after going back to page in page cache
2805         https://bugs.webkit.org/show_bug.cgi?id=129989
2806         <rdar://problem/16217588>
2807
2808         Reviewed by Dan Bernstein.
2809
2810         iOS has a special FrameLoader::forceLayoutWithoutRecalculatingStyle()
2811         function that is called instead of FrameView::forceLayout(). This was unimplemented
2812         for the WK2 FrameLoaderClient, so no layout was forced, with the result
2813         that the contentSize was never updated and scrolling was broken.
2814         
2815         Fix by renaming the client function to forceLayoutOnRestoreFromPageCache()
2816         and having it return a bool to say whether the default forceLayout()
2817         should be done. WK1 can then continue to have its custom behavior,
2818         and Wk2 will simply do a forceLayout().
2819         
2820         Also remove FrameLaoderClient::forceLayout(), which was never called.
2821
2822         * WebCoreSupport/WebFrameLoaderClient.h:
2823         * WebCoreSupport/WebFrameLoaderClient.mm:
2824         (WebFrameLoaderClient::forceLayoutOnRestoreFromPageCache):
2825
2826 2014-03-07  Anders Carlsson  <andersca@apple.com>
2827
2828         Add the remaining WebKit2 headers to WEBKIT2_HEADERS
2829         https://bugs.webkit.org/show_bug.cgi?id=129942
2830         <rdar://problem/15920020>
2831
2832         Reviewed by Tim Horton.
2833
2834         * MigrateHeaders.make:
2835
2836 2014-03-07  Anders Carlsson  <andersca@apple.com>
2837
2838         MigrateHeaders.make should remove C SPI includes from WebKit2 headers
2839         https://bugs.webkit.org/show_bug.cgi?id=129937
2840         <rdar://problem/15920020>
2841
2842         Reviewed by Tim Horton.
2843
2844         * MigrateHeaders.make:
2845         Add WKPreferences.h to WEBKIT2_HEADERS. 
2846         Add a sed rule that deletes all lines that start with a # and contain <WebKit/*Ref.h>.
2847
2848 2014-03-07  Anders Carlsson  <andersca@apple.com>
2849
2850         Make it possible to copy WebKit2 headers to WebKit.framework
2851         https://bugs.webkit.org/show_bug.cgi?id=129935
2852         <rdar://problem/15920020>
2853
2854         Reviewed by Dan Bernstein.
2855
2856         * MigrateHeaders.make:
2857         Gather a list of public and private WebKit2 headers and filter them against the WEBKIT2_HEADERS list.
2858         The matching headers are copied to the respective Headers or PrivateHeaders directories under WebKit.framework,
2859         and also have their #imports rewritten to reference WebKit instead of WebKit2.
2860
2861         * migrate-headers.sh: Added.
2862         Set up the WEBKIT2_FRAMEWORKS_DIR if needed.
2863
2864 2014-03-07  Anders Carlsson  <andersca@apple.com>
2865
2866         Fix a typo
2867         <rdar://problem/15920020>
2868
2869         Rubber-stamped by Dan Bernstein.
2870
2871         * Configurations/WebKit.xcconfig:
2872
2873 2014-03-07  Anders Carlsson  <andersca@apple.com>
2874
2875         Tweak the WebKit2 frameworks directories
2876         https://bugs.webkit.org/show_bug.cgi?id=129910
2877         <rdar://problem/15920020>
2878
2879         Reviewed by Dan Bernstein.
2880
2881         Use an SDK relative directory for production builds.
2882
2883         * Configurations/WebKit.xcconfig:
2884
2885 2014-03-07  Anders Carlsson  <andersca@apple.com>
2886
2887         Link WebKit.framework against WebKit2.framework and re-export all WebKit2 symbols
2888         https://bugs.webkit.org/show_bug.cgi?id=129901
2889         <rdar://problem/15920020>
2890
2891         Reviewed by Andreas Kling.
2892
2893         * Configurations/WebKit.xcconfig:
2894
2895 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
2896
2897         Web Inspector: Expose the console object in JSContexts to interact with Web Inspector
2898         https://bugs.webkit.org/show_bug.cgi?id=127944
2899
2900         Reviewed by Geoffrey Garen.
2901
2902         * WebCoreSupport/WebChromeClient.h:
2903         * WebCoreSupport/WebChromeClient.mm:
2904         Update namespaces.
2905
2906 2014-03-05  Eric Carlson  <eric.carlson@apple.com>
2907
2908         [iOS] Show external device name/type in placeholder
2909         https://bugs.webkit.org/show_bug.cgi?id=129723
2910
2911         Reviewed by Jer Noble.
2912
2913         * WebCoreSupport/WebSystemInterface.mm:
2914         (InitWebCoreSystemInterface):
2915
2916 2014-03-05  Simon Fraser  <simon.fraser@apple.com>
2917
2918         ObjC exception when dropping files into a WKView: drag and drop uses code from WebKit.framework
2919         https://bugs.webkit.org/show_bug.cgi?id=129752
2920
2921         Reviewed by Enrica Casucci.
2922         
2923         Call URLByCanonicalizingURL() which is implemented in WebCore.
2924
2925         * Misc/WebNSURLExtras.mm:
2926         (-[NSURL _webkit_canonicalize]):
2927
2928 2014-03-04  Zalan Bujtas  <zalan@apple.com>
2929
2930         Enable device pixel repaint rect tracking.
2931         https://bugs.webkit.org/show_bug.cgi?id=129712
2932
2933         Reviewed by Simon Fraser.
2934
2935         Tracked repaint rects are device pixel snapped now to support hiDPI test cases.
2936
2937         * WebView/WebView.mm:
2938         (-[WebView trackedRepaintRects]): Keep existing behavior for now.
2939
2940 2014-03-04  Simon Fraser  <simon.fraser@apple.com>
2941
2942         Allow iOS DumpRenderTree crashes to show application-specific information
2943         https://bugs.webkit.org/show_bug.cgi?id=129705
2944
2945         Reviewed by David Kilzer.
2946
2947         Make the WKSI function SetCrashReportApplicationSpecificInformation available
2948         in iOS simulator builds.
2949
2950         * WebCoreSupport/WebSystemInterface.mm:
2951         (InitWebCoreSystemInterface):
2952
2953 2014-03-04  Mark Hahnenberg  <mhahnenberg@apple.com>
2954
2955         Merge API shims and JSLock
2956         https://bugs.webkit.org/show_bug.cgi?id=129650
2957
2958         Reviewed by Mark Lam.
2959
2960         JSLock is now taking on all of APIEntryShim's responsibilities since there is never a reason 
2961         to take just the JSLock. Ditto for DropAllLocks and APICallbackShim.
2962
2963         * WebView/WebFrame.mm:
2964         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2965
2966 2014-03-02  Darin Adler  <darin@apple.com>
2967
2968         Sort Mac platform export files so they merge better
2969         https://bugs.webkit.org/show_bug.cgi?id=129581
2970
2971         Reviewed by Sam Weinig.
2972
2973         * WebKit.exp: Ran the new sort-export-file on this.
2974
2975 2014-03-02  Darin Adler  <darin@apple.com>
2976
2977         Change public text iterator API implementations to not depend on 16-bit character pointers
2978         https://bugs.webkit.org/show_bug.cgi?id=129566
2979
2980         Reviewed by Anders Carlsson.
2981
2982         * WebView/WebTextIterator.mm:
2983         (-[WebTextIterator initWithRange:]): Use make_unique instead of adoptPtr.
2984         (-[WebTextIterator advance]): Clear out the upconverted text since we are moving on to the
2985         next text.
2986         (-[WebTextIterator currentTextPointer]): Upconvert if we have 8-bit text.
2987         (-[WebTextIterator currentTextLength]): Call TextIterator::text().length() since we will
2988         probably be removing TextIterator::length eventually.
2989
2990 2014-03-01  Pratik Solanki  <psolanki@apple.com>
2991
2992         [iOS] selectionImageForcingBlackText should return autoreleased object
2993         https://bugs.webkit.org/show_bug.cgi?id=129437
2994         <rdar://problem/15810384>
2995
2996         Reviewed by Darin Adler.
2997
2998         * WebView/WebHTMLView.mm:
2999         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
3000
3001 2014-02-28  Dan Bernstein  <mitz@apple.com>
3002
3003         [Mac] Remove MailQuirksUserScript.js
3004         https://bugs.webkit.org/show_bug.cgi?id=129536
3005
3006         Reviewed by Andy Estes.
3007
3008         * Configurations/WebKit.xcconfig: Removed from EXCLUDED_SOURCE_FILE_NAMES_iphoneos.
3009         * Misc/MailQuirksUserScript.js: Removed. This file has been unused since r147447.
3010
3011 2014-02-28  Timothy Hatcher  <timothy@apple.com>
3012
3013         Properly handle when Test.html is not present in Production builds.
3014
3015         https://bugs.webkit.org/show_bug.cgi?id=129506
3016
3017         Reviewed by Joseph Pecoraro.
3018
3019         * WebCoreSupport/WebInspectorClient.mm:
3020         (-[WebInspectorWindowController inspectorTestPagePath]):
3021         (-[WebInspectorWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3022
3023 2014-02-27  Brian Burg  <bburg@apple.com>
3024
3025         Web Inspector: model tests should use a special Test.html inspector page
3026         https://bugs.webkit.org/show_bug.cgi?id=129190
3027
3028         Reviewed by Timothy Hatcher.
3029
3030         Support creating a separate test inspector page, based on the value of
3031         InspectorController::isUnderTest(). Modify the navigation policy to check
3032         the URL against both normal and test inspector pages.
3033
3034         * WebCoreSupport/WebInspectorClient.mm:
3035         (WebInspectorClient::openInspectorFrontend):
3036         (-[WebInspectorWindowController init]):
3037         (-[WebInspectorWindowController initWithInspectedWebView:isUnderTest:]):
3038         Move the initial navigation of the inspector page to this method, and change
3039         the URL based on the value of InspectorController::isUnderTest().
3040
3041         (-[WebInspectorWindowController inspectorTestPagePath]): Added.
3042         (-[WebInspectorWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3043
3044 2014-02-27  Pratik Solanki  <psolanki@apple.com>
3045
3046         Assertion failure at CachedResource.h:196: ASSERT(!m_purgeableData)
3047         https://bugs.webkit.org/show_bug.cgi?id=129349
3048         <rdar://problem/14871837>
3049
3050         Reviewed by Joseph Pecoraro.
3051
3052         The code for clearing out memory mapped notification callbacks is only needed when loading
3053         PDFs. And in such cases, we always have dataSourceDelegate object. So make this code
3054         conditional on its presence so that we don't trigger the assert for non-PDF main resources.
3055
3056         * WebView/WebDataSource.mm:
3057         (-[WebDataSource dealloc]):
3058
3059 2014-02-26  Andy Estes  <aestes@apple.com>
3060
3061         [iOS] Support network state notification using CPNetworkObserver
3062         https://bugs.webkit.org/show_bug.cgi?id=129358
3063
3064         Reviewed by Dan Bernstein.
3065
3066         * WebView/WebView.mm:
3067         (-[WebView _setNetworkStateIsOnline:]): Retained an empty
3068         implementation for binary compatibility for UIKit.
3069         (+[WebView _doNotStartObservingNetworkReachability]): Called
3070         Settings::setShouldOptOutOfNetworkStateObservation(true).
3071         * WebView/WebViewPrivate.h: Removed declaration of
3072         _setNetworkStateIsOnline: and declared
3073         _doNotStartObservingNetworkReachability.
3074
3075 2014-02-25  Anders Carlsson  <andersca@apple.com>
3076
3077         Get rid of VisitedLinkStrategy
3078         https://bugs.webkit.org/show_bug.cgi?id=129324
3079
3080         Reviewed by Dan Bernstein.
3081
3082         * WebCoreSupport/WebPlatformStrategies.h:
3083         * WebCoreSupport/WebPlatformStrategies.mm:
3084
3085 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
3086
3087         [CSS Grid Layout] Add ENABLE flag
3088         https://bugs.webkit.org/show_bug.cgi?id=129153
3089
3090         Reviewed by Simon Fraser.
3091
3092         Added ENABLE_CSS_GRID_LAYOUT feature flag.
3093
3094         * Configurations/FeatureDefines.xcconfig:
3095
3096 2014-02-24  Anders Carlsson  <andersca@apple.com>
3097
3098         Add WebViewGroup
3099         https://bugs.webkit.org/show_bug.cgi?id=129280
3100
3101         Reviewed by Dan Bernstein.
3102
3103         This is a first step towards getting rid of page groups in WebCore. The idea is that
3104         everything that is per page group in WebCore will be per page. In order to retain WebKit1 compatibility
3105         WebViewGroup is going to take over more and more responsibility from WebCore::PageGroup.
3106
3107         * WebCoreSupport/WebViewGroup.h: Added.
3108         * WebCoreSupport/WebViewGroup.mm: Added.
3109         (webViewGroups):
3110         (WebViewGroup::getOrCreate):
3111         (WebViewGroup::WebViewGroup):
3112         (WebViewGroup::~WebViewGroup):
3113         (WebViewGroup::addWebView):
3114         (WebViewGroup::removeWebView):
3115         * WebView/WebView.mm:
3116         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3117         (-[WebView _close]):
3118         (-[WebView setGroupName:]):
3119         * WebView/WebViewData.h:
3120         * WebView/WebViewData.mm:
3121
3122 2014-02-24  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
3123
3124         Code cleanup: remove leftover ENABLE(WORKERS) macros and support.
3125         https://bugs.webkit.org/show_bug.cgi?id=129255
3126
3127         Reviewed by Csaba Osztrogonác.
3128
3129         ENABLE_WORKERS macro was removed in r159679.
3130         Support is now also removed from xcconfig files.
3131
3132         * Configurations/FeatureDefines.xcconfig:
3133
3134 2014-02-24  David Kilzer  <ddkilzer@apple.com>
3135
3136         Remove redundant setting in FeatureDefines.xcconfig
3137
3138         * Configurations/FeatureDefines.xcconfig:
3139
3140 2014-02-23  Sam Weinig  <sam@webkit.org>
3141
3142         Update FeatureDefines.xcconfig
3143
3144         Rubber-stamped by Anders Carlsson.
3145
3146         * Configurations/FeatureDefines.xcconfig:
3147
3148 2014-02-23  Sam Weinig  <sam@webkit.org>
3149
3150         Move telephone number detection behind its own ENABLE macro
3151         https://bugs.webkit.org/show_bug.cgi?id=129236
3152
3153         Reviewed by Dean Jackson.
3154
3155         * Configurations/FeatureDefines.xcconfig:
3156         Add ENABLE_TELEPHONE_NUMBER_DETECTION.
3157
3158 2014-02-21  Sam Weinig  <sam@webkit.org>
3159
3160         Expose phase and momentum phase as SPI on DOMWheelEvent
3161         <rdar://problem/16110871>
3162         https://bugs.webkit.org/show_bug.cgi?id=129184
3163
3164         Reviewed by Anders Carlsson.
3165
3166         * DOM/WebDOMOperations.mm:
3167         (toNSEventPhase):
3168         (-[DOMWheelEvent _phase]):
3169         (-[DOMWheelEvent _momentumPhase]):
3170         * DOM/WebDOMOperationsPrivate.h:
3171         Expose _phase and _momentumPhase as SPI.
3172
3173         * MigrateHeaders.make:
3174         Make DOMWheelEventInternal.h to WebKit.
3175
3176 2014-02-22  David Kilzer  <ddkilzer@apple.com>
3177
3178         Revert r164434 since it actually broke ASan builds
3179         <http://webkit.org/b/128871>
3180
3181         * Configurations/WebKit.xcconfig: This caused -asan-blacklist to
3182         be included twice on every compiler command, which caused clang
3183         to error out.
3184
3185 2014-02-21  Brent Fulgham  <bfulgham@apple.com>
3186
3187         Extend media support for WebVTT sources
3188         https://bugs.webkit.org/show_bug.cgi?id=129156
3189
3190         Reviewed by Eric Carlson.
3191
3192         * Configurations/FeatureDefines.xcconfig: Add new feature define for AVF_CAPTIONS
3193
3194 2014-02-20  Brady Eidson  <beidson@apple.com>
3195
3196         Add very basic image control rendering
3197         https://bugs.webkit.org/show_bug.cgi?id=129080
3198
3199         Reviewed by Tim Horton.
3200
3201         Expose the imageControlsEnabled setting to WebKit1 so DRT can use it.
3202
3203         * WebView/WebPreferenceKeysPrivate.h:
3204         * WebView/WebPreferences.mm:
3205         (+[WebPreferences initialize]):
3206         (-[WebPreferences imageControlsEnabled]):
3207         (-[WebPreferences setImageControlsEnabled:]):
3208         * WebView/WebPreferencesPrivate.h:
3209
3210         * WebView/WebView.mm:
3211         (-[WebView _preferencesChanged:]):
3212
3213 2014-02-20  David Kilzer  <ddkilzer@apple.com>
3214
3215         [ASan] WebKit1 sources are not compiled using ASAN macros
3216         <http://webkit.org/b/128871>
3217
3218         Reviewed by Brent Fulgham.
3219
3220         * Configurations/WebKit.xcconfig: Use $inherited for
3221         OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS so that ASAN_OTHER_CFLAGS
3222         and ASAN_OTHER_CPLUSPLUSFLAGS are inherited from
3223         DebugRelease.xcconfig.
3224
3225 2014-02-19  Brady Eidson  <beidson@apple.com>
3226
3227         Add FeatureDefines for image controls
3228         https://bugs.webkit.org/show_bug.cgi?id=129022
3229
3230         Reviewed by Jer Noble.
3231
3232         * Configurations/FeatureDefines.xcconfig:
3233
3234 2014-02-18  Sam Weinig  <sam@webkit.org>
3235
3236         Simplify HTML tokenizer parameterization down to what is used
3237         https://bugs.webkit.org/show_bug.cgi?id=128977
3238
3239         Reviewed by Alexey Proskuryakov.
3240
3241         Remove unused _setCustomHTMLTokenizerTimeDelay and _setCustomHTMLTokenizerChunkSize SPI.
3242
3243         * WebView/WebView.mm:
3244         * WebView/WebViewPrivate.h:
3245
3246 2014-02-17  Anders Carlsson  <andersca@apple.com>
3247
3248         Remove view source code
3249         https://bugs.webkit.org/show_bug.cgi?id=127233
3250
3251         Reviewed by Antti Koivisto.
3252
3253         * WebView/WebView.mm:
3254         * WebView/WebViewPrivate.h:
3255
3256 2014-02-17  Sergio Correia  <sergio.correia@openbossa.org>
3257
3258         Replace uses of PassOwnPtr/OwnPtr with std::unique_ptr in WebCore/inspector
3259         https://bugs.webkit.org/show_bug.cgi?id=128681
3260
3261         Reviewed by Timothy Hatcher.
3262
3263         Another step towards getting rid of PassOwnPtr/OwnPtr, now targeting
3264         WebCore/inspector/*. Besides files in there, a few other files in
3265         JavaScriptCore/inspector, WebKit/, WebKit2/WebProcess/WebCoreSupport/
3266         and WebCore/testing were touched.
3267
3268         * WebCoreSupport/WebInspectorClient.h:
3269         * WebCoreSupport/WebInspectorClient.mm:
3270
3271 2014-02-15  Alexey Proskuryakov  <ap@apple.com>
3272
3273         [Mac] Remove WebSerializedJSValue SPI
3274         https://bugs.webkit.org/show_bug.cgi?id=128720
3275
3276         Reviewed by Anders Carlsson.
3277
3278         * WebKit.exp:
3279         * WebView/WebSerializedJSValue.h: Removed.
3280         * WebView/WebSerializedJSValue.mm: Removed.
3281         * WebView/WebSerializedJSValuePrivate.h: Removed.
3282
3283 2014-02-15  Alexey Proskuryakov  <ap@apple.com>
3284
3285         [Mac] All WebKit clients should encrypt WebCrypto keys automatically
3286         https://bugs.webkit.org/show_bug.cgi?id=128852
3287
3288         Reviewed by Oliver Hunt.
3289
3290         * WebCoreSupport/WebChromeClient.mm:
3291         (WebChromeClient::wrapCryptoKey):
3292         (WebChromeClient::unwrapCryptoKey):
3293         Call the default implementation if key is not provided by a client.
3294
3295 2014-02-14  Anders Carlsson  <andersca@apple.com>
3296
3297         Control tints don't update inside WebViews
3298         https://bugs.webkit.org/show_bug.cgi?id=128862
3299
3300         Reviewed by Ryosuke Niwa.
3301
3302         * WebView/WebView.mm:
3303         (-[WebView _windowChangedKeyState]):
3304         Call [super _windowChangedKeyState].
3305
3306 2014-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
3307
3308         During a copy, position:fixed gets converted to position:absolute even if only part of the document is selected
3309         https://bugs.webkit.org/show_bug.cgi?id=128688
3310
3311         Reviewed by Ryosuke Niwa.
3312
3313         Renames the ConvertPositionStyleOnCopy setting to ShouldConvertPositionStyleOnCopy
3314
3315         * WebView/WebPreferenceKeysPrivate.h:
3316         * WebView/WebPreferences.mm:
3317         (-[WebPreferences shouldConvertPositionStyleOnCopy]):
3318         (-[WebPreferences setShouldConvertPositionStyleOnCopy:]):
3319         * WebView/WebPreferencesPrivate.h:
3320         * WebView/WebView.mm:
3321         (-[WebView _preferencesChanged:]):
3322
3323 2014-02-13  Alexey Proskuryakov  <ap@apple.com>
3324
3325         [Mac] Add a WebKit1 SPI to get WebCrypto master key from a client
3326         https://bugs.webkit.org/show_bug.cgi?id=128725
3327
3328         Reviewed by Anders Carlsson.
3329
3330         * WebCoreSupport/WebChromeClient.mm:
3331         (WebChromeClient::wrapCryptoKey):
3332         (WebChromeClient::unwrapCryptoKey):
3333         * WebView/WebUIDelegatePrivate.h:
3334         Looks like UIDelegate is the closest we have to a reasonable place.
3335
3336 2014-02-13  Dan Bernstein  <mitz@apple.com>
3337
3338         iOS build fix.
3339
3340         * WebView/WebView.mm:
3341         (+[WebView registerForMemoryNotifications]):
3342
3343 2014-02-12  Alexey Proskuryakov  <ap@apple.com>
3344
3345         Wrap WebCrypto keys in SerializedScriptValue
3346         https://bugs.webkit.org/show_bug.cgi?id=128680
3347
3348         Reviewed by Anders Carlsson.
3349
3350         Retrieve a master key (placeholder code for now), and use it to wrap key data.
3351
3352         * WebCoreSupport/WebChromeClient.mm:
3353         (WebChromeClient::wrapCryptoKey):
3354         (WebChromeClient::unwrapCryptoKey):
3355
3356 2014-02-11  Ryosuke Niwa  <rniwa@webkit.org>
3357
3358         Frame::rectForSelection shouldn't instantiate FrameSelection
3359         https://bugs.webkit.org/show_bug.cgi?id=128587
3360
3361         Reviewed by Enrica Casucci.
3362
3363         * WebCoreSupport/WebEditorClient.h:
3364         * WebCoreSupport/WebEditorClient.mm:
3365         (WebEditorClient::WebEditorClient):
3366         (WebEditorClient::respondToChangedSelection):
3367
3368 2014-02-10  Myles C. Maxfield  <mmaxfield@apple.com>
3369
3370         Convert position:sticky and position:fixed properties to position:static and position:absolute upon copy
3371         https://bugs.webkit.org/show_bug.cgi?id=128194
3372
3373         Reviewed by Simon Fraser.
3374
3375         * WebView/WebPreferenceKeysPrivate.h:
3376         * WebView/WebPreferences.mm:
3377         (-[WebPreferences convertPositionStyleOnCopy]):
3378         (-[WebPreferences setConvertPositionStyleOnCopy:]):
3379         * WebView/WebPreferencesPrivate.h: Opt-in to new behavior
3380         * WebView/WebView.mm:
3381         (-[WebView _preferencesChanged:]):
3382
3383 2014-02-11  Andy Estes  <aestes@apple.com>
3384
3385         [Mac] connection:willStopBufferingData: no longer exists in NSURLConnectionDelegate
3386         https://bugs.webkit.org/show_bug.cgi?id=128583
3387
3388         Reviewed by Anders Carlsson.
3389
3390         The delegate method was removed in Snow Leopard.
3391
3392         * Misc/WebDownload.mm:
3393
3394 2014-02-11  Alexey Proskuryakov  <ap@apple.com>
3395
3396         iOS build fix.
3397
3398         * WebCoreSupport/WebChromeClient.mm: Fixed incorrectly nested ifdefs.
3399
3400 2014-02-10  Alexey Proskuryakov  <ap@apple.com>
3401
3402         Add hooks for wrapping CryptoKeys in SerializedScriptValue
3403         https://bugs.webkit.org/show_bug.cgi?id=128567
3404
3405         Reviewed by Anders Carlsson.
3406
3407         * WebCoreSupport/WebChromeClient.h:
3408         * WebCoreSupport/WebChromeClient.mm:
3409         (WebChromeClient::wrapCryptoKey):
3410         (WebChromeClient::unwrapCryptoKey):
3411         Dummy implementation, to be filled in later.
3412
3413 2014-02-08  Ryosuke Niwa  <rniwa@webkit.org>
3414
3415         Cleanup the interface of FrameSelection
3416         https://bugs.webkit.org/show_bug.cgi?id=128481
3417
3418         Reviewed by Andreas Kling.
3419
3420         * WebView/WebHTMLView.mm:
3421         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
3422         (-[WebHTMLView selectionRect]):
3423         (-[WebHTMLView selectionImageRect]):
3424
3425 2014-02-08  Dan Bernstein  <mitz@apple.com>
3426
3427         Remove use of PLATFORM(MAC) from WebKit/mac
3428         https://bugs.webkit.org/show_bug.cgi?id=128476
3429
3430         Reviewed by Anders Carlsson.
3431
3432         * WebCoreSupport/WebFrameLoaderClient.h:
3433         * WebCoreSupport/WebSystemInterface.mm:
3434         (InitWebCoreSystemInterface):
3435
3436 2014-02-08  Dan Bernstein  <mitz@apple.com>
3437
3438         Remove client-drawn highlights (-webkit-highlight, WebHTMLHighlighter)
3439         https://bugs.webkit.org/show_bug.cgi?id=128456
3440
3441         Reviewed by Anders Carlsson.
3442
3443         * WebCoreSupport/WebChromeClient.h:
3444         * WebCoreSupport/WebChromeClient.mm: Removed customHighlightRect and paintCustomHighlight.
3445         * WebView/WebHTMLView.mm:
3446         (-[WebHTMLViewPrivate dealloc]): Removed highlighters ivar.
3447         (-[WebHTMLViewPrivate clear]): Ditto.
3448         * WebView/WebHTMLViewInternal.h: Removed declaration.
3449         * WebView/WebHTMLViewPrivate.h: Removed WebHTMLHighlighter protocol and method declarations.
3450
3451 2014-02-08  Dan Bernstein  <mitz@apple.com>
3452
3453         iOS build fix after r163712.
3454
3455         * WebCoreSupport/WebEditorClient.h:
3456         * WebCoreSupport/WebEditorClient.mm:
3457
3458 2014-02-08  Darin Adler  <darin@apple.com>
3459
3460         Change TextIterator to use StringView, preparing to wean it from deprecatedCharacters
3461         https://bugs.webkit.org/show_bug.cgi?id=128233
3462
3463         Reviewed by Anders Carlsson.
3464
3465         * WebCoreSupport/WebEditorClient.h: Made most data members private. Moved inlines
3466         for iOS out of the class definition. Fixed formatting. Added missing virtual keyword.
3467         Changed interfaces to use StringView.
3468
3469         * WebCoreSupport/WebEditorClient.mm:
3470         (WebEditorClient::checkTextOfParagraph): Use the new StringView::createNSStringWithoutCopying
3471         function instead of a similar function that was local in this file.
3472         (WebEditorClient::ignoreWordInSpellDocument): Tweaked formatting.
3473         (WebEditorClient::checkSpellingOfString): Changed to take a StringView.
3474         (WebEditorClient::checkGrammarOfString): Ditto.
3475
3476         * WebView/WebTextIterator.mm:
3477         (-[WebTextIterator currentTextPointer]): Call TextIterator::deprecatedTextIteratorCharacters.
3478         (-[WebTextIterator currentText]): Convert a the text to an NSString with TextIterator::text
3479         instead of with TextIterator::characters/length.
3480
3481 2014-02-07  Gavin Barraclough  <barraclough@apple.com>
3482
3483         Remove isInitialState flag from Page::setViewState
3484         https://bugs.webkit.org/show_bug.cgi?id=128428
3485
3486         Reviewed by Sam Weinig.
3487
3488         * WebView/WebView.mm:
3489         (-[WebView _commonInitializationWithFrameName:groupName:]):
3490         (-[WebView _updateVisibilityState]):
3491         (-[WebView _setIsVisible:]):
3492         (-[WebView _setVisibilityState:isInitialState:]):
3493         (-[WebView _windowWillOrderOnScreen:]):
3494         (-[WebView _windowWillOrderOffScreen:]):
3495             - don't pass isInitialState to setViewState.
3496
3497 2014-02-06  Filip Pizlo  <fpizlo@apple.com>
3498
3499         More FTL build scaffolding
3500         https://bugs.webkit.org/show_bug.cgi?id=128330
3501
3502         Reviewed by Geoffrey Garen.
3503
3504         * Configurations/FeatureDefines.xcconfig:
3505
3506 2014-02-07  Dan Bernstein  <mitz@apple.com>
3507
3508         iOS build fix.
3509
3510         * Misc/WebElementDictionary.mm:
3511         (+[WebElementDictionary initializeLookupTable]):
3512         (-[WebElementDictionary _image]):
3513         (-[WebElementDictionary _imageRect]):
3514
3515 2014-02-06  Joseph Pecoraro  <pecoraro@apple.com>
3516
3517         Web Inspector: Add Console support to JSContext Inspection
3518         https://bugs.webkit.org/show_bug.cgi?id=127941
3519
3520         Reviewed by Geoffrey Garen.
3521
3522         * WebCoreSupport/WebChromeClient.h:
3523         * WebCoreSupport/WebChromeClient.mm:
3524         (stringForMessageSource):
3525         (stringForMessageLevel):
3526         (WebChromeClient::addMessageToConsole):
3527
3528 2014-02-05  Gavin Barraclough  <barraclough@apple.com>
3529
3530         Change Page, FocusController to use ViewState
3531         https://bugs.webkit.org/show_bug.cgi?id=126533
3532
3533         Reviewed by Tim Horton.
3534
3535         These classes currently maintain a set of separate fields to represent the view state;
3536         combine these into a single field, and allow WebPage to send the combined update rather
3537         than individual changes.
3538
3539         Maintain existing interface for WebKit1 clients.
3540
3541         * WebView/WebView.mm:
3542         (-[WebView _windowWillOrderOnScreen:]):
3543         (-[WebView _windowWillOrderOffScreen:]):
3544             - remove calls to FocusController::setContentIsVisible, these are redundant
3545               (this is handled when page visibility is set).
3546
3547 2014-02-05  Andreas Kling  <akling@apple.com>
3548
3549         Remove ENABLE(DIRECTORY_UPLOAD).
3550         <https://webkit.org/b/128275>
3551
3552         Rubber-stamped by Ryosuke Niwa.
3553
3554         * Configurations/FeatureDefines.xcconfig:
3555
3556 2014-02-05  Csaba Osztrogonác  <ossy@webkit.org>
3557
3558         Remove ENABLE(SVG) guards
3559         https://bugs.webkit.org/show_bug.cgi?id=127991
3560
3561         Reviewed by Sam Weinig.
3562
3563         * Configurations/FeatureDefines.xcconfig:
3564
3565 2014-02-04  Andreas Kling  <akling@apple.com>
3566
3567         Remove <iframe seamless> support.
3568         <https://webkit.org/b/128213>
3569
3570         Rubber-stamped by Antti Koivisto.
3571
3572         * Configurations/FeatureDefines.xcconfig:
3573         * WebView/WebPreferenceKeysPrivate.h:
3574         * WebView/WebPreferences.mm:
3575         * WebView/WebPreferencesPrivate.h:
3576         * WebView/WebView.mm:
3577         (-[WebView _preferencesChanged:]):
3578
3579 2014-02-03  Dean Jackson  <dino@apple.com>
3580
3581         Feature flag for shape-inside
3582         https://bugs.webkit.org/show_bug.cgi?id=128001
3583
3584         Reviewed by Simon Fraser.
3585
3586         Add CSS_SHAPE_INSIDE flag.
3587
3588         * Configurations/FeatureDefines.xcconfig:
3589
3590 2014-01-31  Ryosuke Niwa  <rniwa@webkit.org>
3591
3592         Remove inline member functions of FrameSelection that access m_selection
3593         https://bugs.webkit.org/show_bug.cgi?id=127986
3594
3595         Reviewed by Enrica Casucci.
3596
3597         * WebView/WebFrame.mm:
3598         (-[WebFrame hasEditableSelection]):
3599         (-[WebFrame selectionAffinity]):
3600         (-[WebFrame getDictationResultRanges:andMetadatas:]):
3601         (-[WebFrame hasRichlyEditableSelection]):
3602         (-[WebFrame focusedNodeHasContent]):
3603         * WebView/WebHTMLView.mm:
3604         (-[WebHTMLView readSelectionFromPasteboard:]):
3605         (-[WebHTMLView _hasSelection]):
3606         (-[WebHTMLView _hasSelectionOrInsertionPoint]):
3607         (-[WebHTMLView _hasInsertionPoint]):
3608         (-[WebHTMLView _isEditable]):
3609         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3610         (-[WebHTMLView maintainsInactiveSelection]):
3611         (isTextInput):
3612         (isInPasswordField):
3613         * WebView/WebView.mm:
3614         (-[WebView selectionAffinity]):
3615
3616 2014-01-31  Tim Horton  <timothy_horton@apple.com>
3617
3618         [wk2] PlatformCALayerRemoteCustom doesn't work on iOS
3619         https://bugs.webkit.org/show_bug.cgi?id=128025
3620         <rdar://problem/15950271>
3621
3622         Reviewed by Simon Fraser.
3623
3624         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3625         (-[WebHostedNetscapePluginView windowHostsLayersInWindowServer]):
3626         Use the new macro name.
3627
3628 2014-01-30  David Kilzer  <ddkilzer@apple.com>
3629
3630         Add security-checked cast for WebCore::CachedImage
3631         <http://webkit.org/b/127967>
3632
3633         Reviewed by Darin Adler.
3634
3635         * Misc/WebCache.mm:
3636         (+[WebCache imageForURL:]):
3637         - Use WebCore::toCachedImage().
3638
3639 2014-01-30  David Kilzer  <ddkilzer@apple.com>
3640
3641         De-virtual-ize CachedResource::isImage()
3642         <http://webkit.org/b/127936>
3643
3644         Reviewed by Andreas Kling.
3645
3646         Also replace explicit type() checks with isImage().
3647
3648         * Misc/WebCache.mm:
3649         (+[WebCache imageForURL:]): Use !isImage().
3650
3651 2014-01-30  Beth Dakin  <bdakin@apple.com>
3652
3653         https://bugs.webkit.org/show_bug.cgi?id=127371
3654         Explore new API that could be used to help build infinitely scrolling websites
3655         -and corresponding-
3656         <rdar://problem/15244768>
3657
3658         Reviewed by Sam Weinig.
3659
3660         FrameView::scrollPositionChangedViaPlatformWidget() now take two parameters 
3661         representing the old scroll position and the new position.
3662         * WebView/WebHTMLView.mm:
3663         (-[WebHTMLView _frameOrBoundsChanged]):
3664
3665 2014-01-30  Andrei Bucur  <abucur@adobe.com>
3666
3667         Remove the ACCELERATED_COMPOSITING flag
3668         https://bugs.webkit.org/show_bug.cgi?id=127833
3669
3670         Reviewed by Antti Koivisto.
3671
3672         Remove the USE(ACCELERATED_COMPOSITING) conditionals from the code base and make AC
3673         mandatory.
3674
3675         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3676         (-[WebHostedNetscapePluginView createPlugin]):
3677         (-[WebHostedNetscapePluginView createPluginLayer]):
3678         * Plugins/WebNetscapePluginView.mm:
3679         (-[WebNetscapePluginView createPlugin]):
3680         (-[WebNetscapePluginView getVariable:value:]):
3681         * Plugins/WebPluginController.mm:
3682         (-[WebPluginController superlayerForPluginView:]):
3683         * WebCoreSupport/WebChromeClient.h:
3684         (WebChromeClient::allowedCompositingTriggers):
3685         * WebCoreSupport/WebChromeClient.mm:
3686         * WebCoreSupport/WebFrameLoaderClient.mm:
3687         (PluginWidgetIOS::detachPluginLayer):
3688         (NetscapePluginWidget::platformLayer):
3689         * WebView/WebClipView.mm:
3690         (-[WebClipView _immediateScrollToPoint:]):
3691         * WebView/WebHTMLView.mm:
3692         (setNeedsDisplayInRect):
3693         (+[WebHTMLViewPrivate initialize]):
3694         (-[WebHTMLViewPrivate clear]):
3695         (-[WebHTMLView _setAsideSubviews]):
3696         (-[WebHTMLView hitTest:]):
3697         (-[WebHTMLView _isUsingAcceleratedCompositing]):
3698         (-[WebHTMLView _compositingLayersHostingView]):
3699         (-[WebHTMLView viewDidMoveToSuperview]):
3700         (-[WebHTMLView drawRect:]):
3701         * WebView/WebHTMLViewInternal.h:
3702         * WebView/WebRenderLayer.mm:
3703         (+[WebRenderLayer compositingInfoForLayer:]):
3704         * WebView/WebView.mm:
3705         (-[WebView _close]):
3706         (-[WebView _setMediaLayer:forPluginView:]):
3707         (-[WebView _postsAcceleratedCompositingNotifications]):
3708         (-[WebView _setPostsAcceleratedCompositingNotifications:]):
3709         (-[WebView _isUsingAcceleratedCompositing]):
3710         (-[WebView _isSoftwareRenderable]):
3711         (-[WebView close]):
3712         * WebView/WebViewData.h:
3713         * WebView/WebViewData.mm:
3714         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
3715         * WebView/WebViewInternal.h:
3716
3717 2014-01-29  Csaba Osztrogonác  <ossy@webkit.org>
3718
3719         Remove ENABLE(JAVASCRIPT_DEBUGGER) leftovers
3720         https://bugs.webkit.org/show_bug.cgi?id=127845
3721
3722         Reviewed by Joseph Pecoraro.
3723
3724         * Configurations/FeatureDefines.xcconfig:
3725
3726 2014-01-29  Dan Bernstein  <mitz@apple.com>
3727
3728         Moved linking against common frameworks and a library from the .xcconfig file into the target.
3729
3730         Reviewed by Tim Horton.
3731
3732         * Configurations/WebKit.xcconfig:
3733
3734 2014-01-29  Ryosuke Niwa  <rniwa@webkit.org>
3735
3736         checkTextOfParagraph releases NSString twice
3737         https://bugs.webkit.org/show_bug.cgi?id=127881
3738         <rdar://problem/15937446>
3739
3740         Reviewed by Anders Carlsson.
3741
3742         textString is released once by an explicit call to release and again by it going out of scope.
3743         Don't do the explicit release.
3744
3745         The bug was spotted by Sam Weinig.
3746
3747         * WebCoreSupport/WebEditorClient.mm:
3748         (WebEditorClient::checkTextOfParagraph):
3749
3750 2014-01-29  Anders Carlsson  <andersca@apple.com>
3751
3752         Fix build.
3753
3754         * WebView/WebPDFView.mm:
3755         (_applicationInfoForMIMEType):
3756
3757 2014-01-28  Mark Rowe  <mrowe@apple.com>
3758
3759         <https://webkit.org/b/127767> Disable some deprecation warnings to fix the build.
3760
3761         Reviewed by Ryosuke Niwa.
3762
3763         * WebCoreSupport/PopupMenuMac.mm:
3764         (PopupMenuMac::populate):
3765
3766 2014-01-27  Joseph Pecoraro  <pecoraro@apple.com>
3767
3768         WebKit1: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
3769         https://bugs.webkit.org/show_bug.cgi?id=127664
3770
3771         Reviewed by Darin Adler.
3772
3773         * Configurations/Base.xcconfig:
3774         * History/BinaryPropertyList.cpp:
3775         (BinaryPropertyListSerializer::appendObjectReference):
3776         (BinaryPropertyListSerializer::startObject):
3777         (BinaryPropertyListSerializer::addAggregateObjectReference):
3778         * WebView/WebPDFView.mm:
3779         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3780
3781 2014-01-27  Andy Estes  <aestes@apple.com>
3782
3783         Scrub WebKit API headers of WTF macros
3784         https://bugs.webkit.org/show_bug.cgi?id=127706
3785
3786         Reviewed by David Kilzer.
3787
3788         * Configurations/FeatureDefines.xcconfig: Added ENABLE_INSPECTOR.
3789         * WebView/WebPreferenceKeysPrivate.h: Changed ENABLE(REMOTE_INSPECTOR)
3790         to !defined(ENABLE_REMOTE_INSPECTOR) || ENABLE_REMOTE_INSPECTOR. We are
3791         in a TARGET_OS_IPHONE block, and ENABLE_REMOTE_INSPECTOR is enabled by
3792         default on iOS, so include this block unless the feature is explicitly
3793         disabled.
3794         * postprocess-headers.sh: Stopped processing ENABLE_IOS_TOUCH_EVENTS
3795         and ENABLE_IOS_GESTURE_EVENTS. These are now defined in DOMEvents.h.
3796
3797 2014-01-27  Tim Horton  <timothy_horton@apple.com>
3798
3799         Another iOS build fix.
3800
3801         * Misc/WebElementDictionary.mm:
3802         (-[WebElementDictionary _image]):
3803         We were apparently depending on Image::getNSImage() being defined
3804         (yet always returning nullptr) on iOS.
3805
3806 2014-01-26  David Kilzer  <ddkilzer@apple.com>
3807
3808         Remove duplicate settings for ENABLE(DISK_IMAGE_CACHE)
3809         <http://webkit.org/b/127669>
3810
3811         Reviewed by Joseph Pecoraro.
3812
3813         * WebView/WebPreferences.mm:
3814         (+[WebPreferences initialize]): Remove duplicate code.
3815
3816 2014-01-24  Andy Estes  <aestes@apple.com>
3817
3818         [iOS] Upstream changes in Tools/DumpRenderTree
3819         https://bugs.webkit.org/show_bug.cgi?id=127412
3820
3821         Reviewed by Simon Fraser.
3822
3823         * Misc/WebCoreStatistics.h: Included CGContext.h.
3824
3825 2014-01-26  Anders Carlsson  <andersca@apple.com>
3826
3827         Move history item visit count handling to WebKit
3828         https://bugs.webkit.org/show_bug.cgi?id=127659
3829
3830         Reviewed by Dan Bernstein.
3831
3832         Move code to deal with visit count and visit dates here from WebCore.
3833
3834         * History/HistoryPropertyList.mm:
3835         (HistoryPropertyListWriter::writeHistoryItem):
3836         * History/WebHistoryItem.mm:
3837         (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
3838         (-[WebHistoryItem copyWithZone:]):
3839         (-[WebHistoryItem lastVisitedTimeInterval]):
3840         (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
3841         (-[WebHistoryItem setVisitCount:]):
3842         (-[WebHistoryItem _mergeAutoCompleteHints:]):
3843         (-[WebHistoryItem initFromDictionaryRepresentation:]):
3844         (-[WebHistoryItem _visitedWithTitle:increaseVisitCount:]):
3845         (-[WebHistoryItem _recordInitialVisit]):
3846         (timeToDay):
3847         (-[WebHistoryItem _padDailyCountsForNewVisit:]):
3848         (-[WebHistoryItem _collapseDailyVisitsToWeekly]):
3849         (-[WebHistoryItem _recordVisitAtTime:increaseVisitCount:]):
3850         (-[WebHistoryItem _setLastVisitedTimeInterval:]):
3851         * History/WebHistoryItemInternal.h:
3852
3853 2014-01-26  Anders Carlsson  <andersca@apple.com>
3854
3855         Fix build.
3856
3857         Pass a WebHistoryItem to writeHistoryItem so we can extract _lastVisitWasHTTPNonGet from it.
3858
3859         * History/HistoryPropertyList.h:
3860         * History/HistoryPropertyList.mm:
3861         (HistoryPropertyListWriter::HistoryPropertyListWriter):
3862         (HistoryPropertyListWriter::buffer):
3863         (HistoryPropertyListWriter::releaseData):
3864         (HistoryPropertyListWriter::writeObjects):
3865         (HistoryPropertyListWriter::writeHistoryItem):
3866         * History/WebHistory.mm:
3867         (WebHistoryWriter::writeHistoryItems):
3868         * History/WebHistoryItem.mm:
3869
3870 2014-01-26  Anders Carlsson  <andersca@apple.com>
3871
3872         Move lastVisitWasHTTPNonGet out to WebHistoryItem
3873         https://bugs.webkit.org/show_bug.cgi?id=127657
3874
3875         Reviewed by Dan Bernstein.
3876
3877         Keep track of _lastVisitWasHTTPNonGet inside WebHistoryItem.
3878
3879         * History/WebHistory.mm:
3880         (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
3881         Set entry->_private->_lastVisitWasHTTPNonGet.
3882
3883         * History/WebHistoryItem.h:
3884         Change @private to @package so we can get at WebHistoryItemPrivate from WebHistory.
3885
3886         * History/WebHistoryItem.mm:
3887         (-[WebHistoryItem copyWithZone:]):
3888         Assign _private->_lastVisitWasHTTPNonGet.
3889
3890         (-[WebHistoryItem initFromDictionaryRepresentation:]):
3891         Set _private->_lastVisitWasHTTPNonGet.
3892
3893         * History/WebHistoryItemInternal.h:
3894         Move WebHistoryItemPrivate interface here.
3895
3896 2014-01-26  Anders Carlsson  <andersca@apple.com>
3897
3898         Turn WebHistoryItemPrivate back into a real Objective-C class
3899         https://bugs.webkit.org/show_bug.cgi?id=127653
3900
3901         Reviewed by Sam Weinig.
3902
3903         This is a first step towards moving some history specific code from WebCore::HistoryItem back into WebKit.
3904
3905         * History/WebHistoryItem.mm:
3906         (-[WebHistoryItem dealloc]):
3907         (-[WebHistoryItem finalize]):
3908         (-[WebHistoryItem initWithWebCoreHistoryItem:]):
3909
3910 2014-01-25  Sam Weinig  <sam@webkit.org>
3911
3912         Remove unused support for DRAGGABLE_REGION
3913         https://bugs.webkit.org/show_bug.cgi?id=127642
3914
3915         Reviewed by Simon Fraser.
3916
3917         * Configurations/FeatureDefines.xcconfig:
3918
3919 2014-01-25  Anders Carlsson  <andersca@apple.com>
3920
3921         Remove an unused FrameLoaderClient function
3922         https://bugs.webkit.org/show_bug.cgi?id=127628
3923
3924         Reviewed by Andreas Kling.
3925
3926         * WebCoreSupport/WebFrameLoaderClient.h:
3927         * WebCoreSupport/WebFrameLoaderClient.mm:
3928
3929 2014-01-25  Anders Carlsson  <andersca@apple.com>
3930
3931         Build fix.
3932
3933         * WebView/WebViewData.h:
3934
3935 2014-01-25  Anders Carlsson  <andersca@apple.com>
3936
3937         Get rid of BackForwardController::isActive()
3938         https://bugs.webkit.org/show_bug.cgi?id=127604
3939
3940         Reviewed by Sam Weinig.
3941
3942         * WebCoreSupport/WebFrameLoaderClient.mm:
3943         (WebFrameLoaderClient::canCachePage):
3944         Move isActive logic here.
3945
3946 2014-01-24  Anders Carlsson  <andersca@apple.com>
3947
3948         Remove back/forward list related functions from Page
3949         https://bugs.webkit.org/show_bug.cgi?id=127596
3950
3951         Reviewed by Andreas Kling.
3952
3953         * WebView/WebFrameView.mm:
3954         (-[WebFrameView keyDown:keyDown:]):
3955         * WebView/WebView.mm:
3956         (-[WebView _loadBackForwardListFromOtherView:]):
3957         (-[WebView initWithCoder:]):
3958         (-[WebView encodeWithCoder:]):
3959         (-[WebView backForwardList]):
3960         (-[WebView setMaintainsBackForwardList:]):
3961         (-[WebView goBack]):
3962         (-[WebView goForward]):
3963         (-[WebView canGoBack]):
3964         (-[WebView canGoForward]):
3965
3966 2014-01-24  Anders Carlsson  <andersca@apple.com>
3967
3968         Get rid of monotonicallyIncreasingTimeMS and start using std::chrono instead
3969         https://bugs.webkit.org/show_bug.cgi?id=127571
3970
3971         Reviewed by Antti Koivisto.
3972
3973         * WebView/WebView.mm:
3974         (-[WebView _preferencesChanged:]):
3975         Convert the layout interval to std::chrono::milliseconds.
3976
3977 2014-01-24  Zan Dobersek  <zdobersek@igalia.com>
3978
3979         Move HistoryItem to std::unique_ptr
3980         https://bugs.webkit.org/show_bug.cgi?id=127275
3981
3982         Reviewed by Darin Adler.
3983
3984         * History/WebHistoryItem.mm: The Vector object that's passed to HistoryItem::setRedirectURLs
3985         should now be handled by std::unique_ptr and passed on through move semantics.
3986         (-[WebHistoryItem initFromDictionaryRepresentation:]):
3987
3988 2014-01-23  Joseph Pecoraro  <pecoraro@apple.com>
3989
3990         Move RegularExpression into JavaScriptCore for inspector
3991         https://bugs.webkit.org/show_bug.cgi?id=127526
3992
3993         Reviewed by Geoffrey Garen.
3994
3995         * WebView/WebHTMLRepresentation.mm:
3996
3997 2014-01-23  Benjamin Poulain  <bpoulain@apple.com>
3998
3999         Remote Inspector uses the Page pointer before the page is created on iOS
4000         https://bugs.webkit.org/show_bug.cgi?id=127534
4001
4002         Reviewed by Joseph Pecoraro.
4003
4004         * WebView/WebView.mm:
4005         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
4006
4007 2014-01-23  Jon Honeycutt  <jhoneycutt@apple.com>
4008
4009         Assertion failure in WebCore::PseudoElement::didRecalcStyle()
4010         <https://bugs.webkit.org/show_bug.cgi?id=126761>
4011         <rdar://problem/15793540>
4012
4013         Some areas of code were erroneously checking the value of
4014         RenderObject::isImage() rather than RenderObject::isRenderImage()
4015         before casting the object to RenderImage.
4016
4017         This could lead to an assertion failure for RenderListMarkers, which
4018         may return true for isImage(), but are not RenderImages.
4019
4020         Reviewed by Andy Estes.
4021
4022         * Misc/WebNSPasteboardExtras.mm:
4023         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
4024         Check isRenderImage() rather than isImage() before casting to
4025         RenderImage.
4026
4027 2014-01-23  Joseph Pecoraro  <pecoraro@apple.com>
4028
4029         Web Inspector: Remove recompileAllJSFunctions timer in ScriptDebugServer
4030         https://bugs.webkit.org/show_bug.cgi?id=127409
4031
4032         Reviewed by Geoffrey Garen.
4033
4034         * WebCoreSupport/WebInspectorClient.mm:
4035         (-[WebInspectorWindowController destroyInspectorView:]):
4036         Include InspectorDisconnectReason.
4037
4038 2014-01-23  Max Vujovic  <mvujovic@adobe.com>
4039
4040         Remove CSS Custom Filters code and tests
4041         https://bugs.webkit.org/show_bug.cgi?id=127382
4042
4043         Reviewed by Simon Fraser.
4044
4045         * Configurations/FeatureDefines.xcconfig:
4046         * WebView/WebPreferenceKeysPrivate.h:
4047         * WebView/WebPreferences.mm:
4048         (+[WebPreferences initialize]):
4049         * WebView/WebPreferencesPrivate.h:
4050         * WebView/WebView.mm:
4051         (-[WebView _preferencesChanged:]):
4052
4053 2014-01-22  Myles C. Maxfield  <mmaxfield@apple.com>
4054
4055         Remove CSS3_TEXT_DECORATION define
4056         https://bugs.webkit.org/show_bug.cgi?id=127333
4057
4058         Reviewed by Simon Fraser.
4059
4060         This is required for unprefixing the text-decoration-* CSS properties.
4061
4062         * Configurations/FeatureDefines.xcconfig:
4063
4064 2014-01-22  Dan Bernstein  <mitz@apple.com>
4065
4066         Build fix for iOS clients of WebUIDelegatePrivate.h.
4067
4068         * WebView/WebUIDelegatePrivate.h: Ensure that ENABLE_DASHBOARD_SUPPORT is defined on iOS.
4069
4070 2014-01-21  Dan Bernstein  <mitz@apple.com>
4071
4072         Added a method declaration that was missed in r161185.
4073
4074         Reviewed by Sam Weinig.
4075
4076         * WebView/WebViewPrivate.h: Declared -removeVisitedLink:.
4077
4078 2014-01-21  Commit Queue  <commit-queue@webkit.org>
4079
4080         Unreviewed, rolling out r162452.
4081         http://trac.webkit.org/changeset/162452
4082         https://bugs.webkit.org/show_bug.cgi?id=127366
4083
4084         broke a few tests on all Mac WebKit1 bots (Requested by
4085         thorton on #webkit).
4086
4087         * WebView/WebView.mm:
4088         (-[WebView _windowWillOrderOnScreen:]):
4089         (-[WebView _windowWillOrderOffScreen:]):
4090
4091 2014-01-21  Gavin Barraclough  <barraclough@apple.com>
4092
4093         Change Page, FocusController to use ViewState
4094         https://bugs.webkit.org/show_bug.cgi?id=126533
4095
4096         Reviewed by Tim Horton.
4097
4098         These classes currently maintain a set of separate fields to represent the view state;
4099         combine these into a single field, and allow WebPage to send the combined update rather
4100         than individual changes.
4101
4102         Maintain existing interface for WebKit1 clients.
4103
4104         * WebView/WebView.mm:
4105         (-[WebView _windowWillOrderOnScreen:]):
4106         (-[WebView _windowWillOrderOffScreen:]):
4107             - remove calls to FocusController::setContentIsVisible, these are redundant
4108               (this is handled when page visibility is set).
4109
4110 2014-01-20  Jeremy Jones  <jeremyj@apple.com>
4111
4112         Add AVKit fullscreen video interface.
4113         https://bugs.webkit.org/show_bug.cgi?id=126818
4114
4115         Reviewed by Eric Carlson.
4116
4117         * WebCoreSupport/WebChromeClient.h:
4118         * WebCoreSupport/WebChromeClient.mm:
4119         (WebChromeClient::supportsFullscreenForNode):
4120         Enable *FullscreenForNode for HTMLMediaElement for iOS
4121
4122         * WebView/WebPreferenceKeysPrivate.h:
4123         * WebView/WebPreferences.mm:
4124         (+[WebPreferences initialize]):
4125         (-[WebPreferences mediaPlaybackFullscreenAVKit]):
4126         (-[WebPreferences setMediaPlaybackFullscreenAVKit:]):
4127         * WebView/WebPreferencesPrivate.h:
4128         * WebView/WebView.mm:
4129         (-[WebView _preferencesChanged:]):
4130         (-[WebView _enterFullscreenForNode:WebCore::]):
4131         * WebView/WebViewInternal.h:
4132         Add a disabled pref mediaPlaybackFullscreenAVKit.
4133         Use WebVideoFullscreenControllerAVKit on iOS
4134
4135 2014-01-18  Brian Burg  <bburg@apple.com>
4136
4137         Web Inspector: Page should use std::unique_ptr for InspectorController
4138         https://bugs.webkit.org/show_bug.cgi?id=127068
4139
4140         Reviewed by Joseph Pecoraro.
4141
4142         Convert call sites to use a InspectorController reference.
4143         Convert instantiations of InspectorFrontendClient to use std::unique_ptr.
4144
4145         * WebCoreSupport/WebInspectorClient.mm:
4146         (WebInspectorClient::openInspectorFrontend):
4147         (-[WebInspectorWindowController destroyInspectorView:]):
4148         * WebInspector/WebInspector.mm:
4149         (-[WebInspector showWindow]):
4150         (-[WebInspector isJavaScriptProfilingEnabled]):
4151         (-[WebInspector setJavaScriptProfilingEnabled:]):
4152         (-[WebInspector close:]):
4153         (-[WebInspector evaluateInFrontend:callId:script:]):
4154         * WebInspector/WebNodeHighlighter.mm:
4155         (-[WebNodeHighlighter highlight]):
4156
4157 2014-01-18  Anders Carlsson  <andersca@apple.com>
4158
4159         Remove ENABLE_THREADED_HTML_PARSER defines everywhere
4160         https://bugs.webkit.org/show_bug.cgi?id=127225
4161
4162         Reviewed by Andreas Kling.
4163
4164         This concludes the removal of over 8.8 million lines of threaded parser code.
4165
4166         * Configurations/FeatureDefines.xcconfig:
4167
4168 2014-01-17  Anders Carlsson  <andersca@apple.com>
4169
4170         Clean up PageCache classes
4171         https://bugs.webkit.org/show_bug.cgi?id=127202
4172
4173         Reviewed by Andreas Kling.
4174
4175         * WebCoreSupport/WebFrameLoaderClient.mm:
4176         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
4177         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
4178
4179 2014-01-17  Anders Carlsson  <andersca@apple.com>
4180
4181         Remove another unused FrameLoaderClient callback
4182         https://bugs.webkit.org/show_bug.cgi?id=127192
4183
4184         Reviewed by Dan Bernstein.
4185
4186         * WebCoreSupport/WebFrameLoaderClient.h:
4187         * WebCoreSupport/WebFrameLoaderClient.mm:
4188
4189 2014-01-17  Anders Carlsson  <andersca@apple.com>
4190
4191         Move didPerformFirstNavigation() logic to -[WebView _didCommitLoadForFrame:]
4192         https://bugs.webkit.org/show_bug.cgi?id=127189
4193
4194         Reviewed by Dan Bernstein.
4195
4196         This is a first step towards completely eliminating the didPerformFirstNavigation() client callback.
4197         
4198         * WebCoreSupport/WebFrameLoaderClient.h:
4199         * WebCoreSupport/WebFrameLoaderClient.mm:
4200         Remove didPerformFirstNavigation() implementation.
4201
4202         * WebView/WebView.mm:
4203         (-[WebView _checkDidPerformFirstNavigation]):
4204         Check if we have both a current item and a previous item which indicates that we've navigated once.
4205         The old code was called before there was a current item but since this is called from _didCommitLoadForFrame
4206         we have to check that there's a current item as well.
4207
4208         (-[WebView _didCommitLoadForFrame:]):
4209         Call _didCommitLoadForFrame.
4210
4211         * WebView/WebViewData.h:
4212         Add new ivar.
4213
4214 2014-01-17  Alexey Proskuryakov  <ap@apple.com>
4215
4216         More iOS build fix.
4217
4218         * WebView/WebPreferences.mm: (-[WebPreferences _synchronizeWebStoragePolicyWithCookiePolicy]):
4219         NSHTTPCookieAcceptPolicyExclusivelyFromMainDocumentDomain is not part of NSHTTPCookieAcceptPolicy enum.
4220
4221 2014-01-16  Daniel Bates  <dabates@apple.com>
4222
4223         [iOS] MobileSafari build fix. Declare iOS-specific method mainFrameIconURL
4224
4225         For now, add mainFrameIconURL() to WebView.h. We should further investigate its
4226         usage and API/SPI status.
4227
4228         * WebView/WebView.h:
4229
4230 2014-01-16  Alexey Proskuryakov  <ap@apple.com>
4231
4232         [Mac] [iOS] Add support for CFHTTPCookieStorageAcceptPolicyExclusivelyFromMainDocumentDomain
4233         https://bugs.webkit.org/show_bug.cgi?id=127139
4234
4235         Reviewed by Brady Eidson.
4236
4237         * WebView/WebPreferences.mm: (-[WebPreferences _synchronizeWebStoragePolicyWithCookiePolicy]):
4238         Handle the new case.
4239