Web Inspector: Dashboard when paused in debugger shows some missing glyph boxes
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2014-04-24  Brady Eidson  <beidson@apple.com>
2
3         Rename "IMAGE_CONTROLS" feature to "SERVICE_CONTROLS"
4         https://bugs.webkit.org/show_bug.cgi?id=132155
5
6         Reviewed by Tim Horton.
7
8         * Configurations/FeatureDefines.xcconfig:
9         * Misc/WebSharingServicePickerController.h:
10         * Misc/WebSharingServicePickerController.mm:
11         * WebCoreSupport/WebContextMenuClient.h:
12         * WebCoreSupport/WebContextMenuClient.mm:
13         (WebContextMenuClient::contextMenuForEvent):
14         * WebView/WebPreferences.mm:
15         (+[WebPreferences initialize]):
16         * WebView/WebView.mm:
17         (-[WebView _preferencesChanged:]):
18
19 2014-04-24  Ryosuke Niwa  <rniwa@webkit.org>
20
21         Text caret disappears in Mail after returning from another application
22         https://bugs.webkit.org/show_bug.cgi?id=132111
23
24         Reviewed by Darin Adler.
25
26         The bug was caused by our SPI _windowChangedKeyState not getting called upon deminiaturization.
27
28         Fixed the bug by using the standard NSWindowDidBecomeKeyNotification and NSWindowDidResignKeyNotification
29         notifications as done in WebKit2 since they DO get called upon deminiaturization.
30
31         * WebView/WebView.mm:
32         (-[WebView addWindowObserversForWindow:]):
33         (-[WebView removeWindowObservers]):
34         (-[WebView _windowKeyStateChanged:]):
35         (-[WebView _windowChangedKeyState]): Deleted.
36
37 2014-04-24  Myles C. Maxfield  <mmaxfield@apple.com>
38
39         FontCache::fontCache() never returns nullptr so it can be made to return a reference instead
40         https://bugs.webkit.org/show_bug.cgi?id=132110
41
42         Reviewed by Tim Horton.
43
44         Updates callers to use '.' instead of '->'.
45
46         No new tests are necessary because there should be no behavior change.
47
48         * Misc/WebCoreStatistics.mm:
49         (+[WebCoreStatistics cachedFontDataCount]):
50         (+[WebCoreStatistics cachedFontDataInactiveCount]):
51         (+[WebCoreStatistics purgeInactiveFontData]):
52         * WebView/WebView.mm:
53         (+[WebView purgeInactiveFontData]):
54
55 2014-04-24  Eric Carlson  <eric.carlson@apple.com>
56
57         [iOS] Manage AudioSession category according to media type
58         https://bugs.webkit.org/show_bug.cgi?id=132096
59
60         Reviewed by Jer Noble.
61
62         * WebView/WebView.mm:
63         (-[WebView _commonInitializationWithFrameName:groupName:]): Tell 
64             WebCore to manage the AudioSession when running in MobileSafari.
65
66 2014-04-23  Andreas Kling  <akling@apple.com>
67
68         Remove Apple Dictionary workaround in WebFrameLoaderClient.
69         <https://webkit.org/b/132095>
70
71         Kill a hack to work around a WK1 client bug that got fixed years ago.
72         See <rdar://problem/6471058> for backstory.
73
74         Reviewed by Darin Adler.
75
76         * WebCoreSupport/WebFrameLoaderClient.mm:
77         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
78         (WebFrameLoaderClient::dispatchWillSendRequest):
79         (applyAppleDictionaryApplicationQuirkNonInlinePart): Deleted.
80         (applyAppleDictionaryApplicationQuirk): Deleted.
81
82 2014-04-23  Anders Carlsson  <andersca@apple.com>
83
84         Don't migrate the WKView.h header from WebCore to WebKit
85         https://bugs.webkit.org/show_bug.cgi?id=132086
86
87         Reviewed by Dan Bernstein.
88
89         * MigrateHeaders.make:
90         Remove WKView.h from the list of headers to migrate.
91
92         * WebView/WebView.mm:
93         Import WKView.h.
94
95 2014-04-22  Ryosuke Niwa  <rniwa@webkit.org>
96
97         Cursor doesn't change back to pointer when leaving the Safari window
98         https://bugs.webkit.org/show_bug.cgi?id=132038
99
100         Reviewed by Alexey Proskuryakov.
101
102         Since the cursor type is now updated asynchronously after r147739,
103         [window windowNumber] != [NSWindow windowNumberAtPoint:[NSEvent mouseLocation] belowWindowWithWindowNumber:0]
104         evalutes to false depending on how fast cursor is moving.
105
106         Instead, check whether the NSWindow of the WebView is the key window or not since
107         key window appears to control the cursor style in Cocoa as far as I've tested:
108         https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/WinPanel/Concepts/ChangingMainKeyWindow.html
109
110         * WebCoreSupport/WebChromeClient.mm:
111         (WebChromeClient::setCursor):
112
113 2014-04-22  Commit Queue  <commit-queue@webkit.org>
114
115         Unreviewed, rolling out r167674.
116         https://bugs.webkit.org/show_bug.cgi?id=132025
117
118         Going a different way with this (Requested by bradee-oh on
119         #webkit).
120
121         Reverted changeset:
122
123         "Change Image Controls replacement to use selection and paste"
124         https://bugs.webkit.org/show_bug.cgi?id=131992
125         http://trac.webkit.org/changeset/167674
126
127 2014-04-22  Brady Eidson  <beidson@apple.com>
128
129         Change Image Controls replacement to use selection and paste
130         <rdar://problem/16302722> and https://bugs.webkit.org/show_bug.cgi?id=131992
131
132         Reviewed by Tim Horton.
133
134         * Misc/WebSharingServicePickerController.mm:
135         (-[WebSharingServicePickerController sharingService:didShareItems:]): Write the
136           replacement data to a special pasteboard, then replace the current selection from
137           that pasteboard.
138
139 2014-04-21  Eric Carlson  <eric.carlson@apple.com>
140
141         [Mac] implement WebKitDataCue
142         https://bugs.webkit.org/show_bug.cgi?id=131799
143
144         Reviewed by Dean Jackson.
145
146         * Configurations/FeatureDefines.xcconfig: Define ENABLE_DATACUE_VALUE.
147
148 2014-04-21  Joseph Pecoraro  <pecoraro@apple.com>
149
150         Remove unused WebKitSystemInterface functions
151         https://bugs.webkit.org/show_bug.cgi?id=131938
152
153         Reviewed by Alexey Proskuryakov.
154
155         * WebCoreSupport/WebSystemInterface.mm:
156         (InitWebCoreSystemInterface):
157
158 2014-04-21  Zan Dobersek  <zdobersek@igalia.com>
159
160         Move cross-port Source/WebCore/page/ code to std::unique_ptr
161         https://bugs.webkit.org/show_bug.cgi?id=130534
162
163         Reviewed by Darin Adler.
164
165         * WebView/WebHTMLRepresentation.mm:
166         (searchForLabelsBeforeElement): Pass a RegExp reference to Frame::searchForLabelsAboveCell().
167
168 2014-04-19  Darin Adler  <darin@apple.com>
169
170         [Mac] WebView adjusts the cursor even when another window is in front
171         https://bugs.webkit.org/show_bug.cgi?id=131898
172         rdar://problem/14619911
173
174         Reviewed by Dan Bernstein.
175
176         * WebCoreSupport/WebChromeClient.mm:
177         (WebChromeClient::setCursor): Added a check that the window is under the cursor
178         and do nothing if it's not.
179
180 2014-04-18  Commit Queue  <commit-queue@webkit.org>
181
182         Unreviewed, rolling out r167527.
183         https://bugs.webkit.org/show_bug.cgi?id=131883
184
185         Broke 32-bit build (Requested by ap on #webkit).
186
187         Reverted changeset:
188
189         "[Mac] implement WebKitDataCue"
190         https://bugs.webkit.org/show_bug.cgi?id=131799
191         http://trac.webkit.org/changeset/167527
192
193 2014-04-18  Eric Carlson  <eric.carlson@apple.com>
194
195         [Mac] implement WebKitDataCue
196         https://bugs.webkit.org/show_bug.cgi?id=131799
197
198         Reviewed by Dean Jackson.
199
200         * Configurations/FeatureDefines.xcconfig: Define ENABLE_DATACUE_VALUE.
201
202 2014-04-17  Daniel Bates  <dabates@apple.com>
203
204         [iOS] Hook up screen.{availHeight, availWidth, height, width}
205         https://bugs.webkit.org/show_bug.cgi?id=131821
206         <rdar://problem/16413795>
207
208         Reviewed by Benjamin Poulain and Tim Horton.
209
210         Add declaration for WKGetViewportAvailableScreenSize() to return the available screen size.
211
212         Additionally substitute "ScreenSize" for "ViewportScreenSize" to make the code more understandable.
213
214         * WebCoreSupport/WebSystemInterface.mm:
215         (InitWebCoreSystemInterface):
216
217 2014-04-17  Darin Adler  <darin@apple.com>
218
219         Add separate flag for IndexedDatabase in workers since the current implementation is not threadsafe
220         https://bugs.webkit.org/show_bug.cgi?id=131785
221         rdar://problem/16003108
222
223         Reviewed by Brady Eidson.
224         
225         * Configurations/FeatureDefines.xcconfig: Added INDEXED_DATABASE_IN_WORKERS.
226
227 2014-04-16  Tim Horton  <timothy_horton@apple.com>
228
229         Images dragged from WebKit1 on 2x displays are too big
230         https://bugs.webkit.org/show_bug.cgi?id=131775
231         <rdar://problem/15933525>
232
233         Reviewed by Simon Fraser.
234
235         * WebCoreSupport/WebDragClient.mm:
236         (WebDragClient::startDrag):
237         Scale the drag image's logical size down by the device scale factor
238         in WebKit1 just like we do in WebKit2.
239
240 2014-04-13  Andy Estes  <aestes@apple.com>
241
242         [QuickLook] Move file system-related code into WebKit
243         https://bugs.webkit.org/show_bug.cgi?id=131597
244
245         Reviewed by Dan Bernstein.
246
247         Moved file system and WebKit1-only code from QuickLookHandle into a new
248         QuickLookHandleClient subclass.
249
250         * WebCoreSupport/WebFrameLoaderClient.h:
251         * WebCoreSupport/WebFrameLoaderClient.mm:
252
253 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
254
255         Eliminate DragSession structure
256         https://bugs.webkit.org/show_bug.cgi?id=131465
257
258         Reviewed by Benjamin Poulain.
259
260         * WebView/WebView.mm:
261         (-[WebView draggingEntered:]):
262         (-[WebView draggingUpdated:]):
263
264 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
265
266         Rename some dragging functions
267         https://bugs.webkit.org/show_bug.cgi?id=131460
268
269         Reviewed by Tim Horton.
270
271         Renamed performDrag to performDragOperation.
272
273         * WebView/WebView.mm: (-[WebView performDragOperation:]):
274
275 2014-04-08  Jon Lee  <jonlee@apple.com>
276
277         Turn MSE on by default
278         https://bugs.webkit.org/show_bug.cgi?id=131313
279         <rdar://problem/16525223>
280
281         Reviewed by Jer Noble.
282
283         * Configurations/FeatureDefines.xcconfig:
284         * WebView/WebPreferences.mm:
285         (+[WebPreferences initialize]): Set default to true.
286
287 2014-04-08  Alexey Proskuryakov  <ap@apple.com>
288
289         Rename Clipboard to DataTransfer
290         https://bugs.webkit.org/show_bug.cgi?id=131371
291
292         Reviewed by Anders Carlsson.
293
294         * WebCoreSupport/WebDragClient.h:
295         * WebCoreSupport/WebDragClient.mm:
296         (WebDragClient::willPerformDragSourceAction):
297         (WebDragClient::startDrag):
298         * WebView/WebPDFView.mm:
299
300 2014-04-08  Dan Bernstein  <mitz@apple.com>
301
302         WebKit part of [Cocoa] Add WKFormDelegate
303         https://bugs.webkit.org/show_bug.cgi?id=131343
304
305         Reviewed by Anders Carlsson.
306
307         * MigrateHeaders.make: Added new WebKit2 headers to WEBKIT2_HEADERS.
308
309 2014-04-08  Daniel Bates  <dabates@apple.com>
310
311         Fallback to default storage session when there isn't a valid session ID
312         https://bugs.webkit.org/show_bug.cgi?id=131326
313         <rdar://problem/16231679>
314
315         Reviewed by Alexey Proskuryakov.
316
317         Fixes and issue where we may use the wrong storage session after disabling
318         a private browsing session.
319
320         Currently WebKit1 and WebKit2 without NetworkProcess assume that there
321         is always a non-null private browsing storage session so long as the page
322         has a non-default session ID. Instead we should only use the private browsing
323         storage session when it's non-null and the page has a non-default session ID;
324         otherwise, we should use the default storage session. This change will make
325         the behavior in WebKit1 and WebKit2 without NetworkProcess consistent with
326         the behavior in WebKit2 with NetworkProcess.
327
328         * WebCoreSupport/WebFrameNetworkingContext.mm:
329         (WebFrameNetworkingContext::storageSession):
330
331 2014-04-06  Sam Weinig  <sam@webkit.org>
332
333         Document user content related APIs
334
335         Reviewed by Anders Carlsson.
336
337         * MigrateHeaders.make:
338
339 2014-04-06  Darin Adler  <darin@apple.com>
340
341         Refactor post-attach and HTMLObjectElement-related code
342         https://bugs.webkit.org/show_bug.cgi?id=131282
343
344         Reviewed by Antti Koivisto.
345
346         * WebCoreSupport/WebFrameLoaderClient.mm: Call toHTMLPlugInImageElement instead of
347         doing a static_cast.
348
349 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
350
351         Enable WEB_REPLAY for PLATFORM(MAC)
352         https://bugs.webkit.org/show_bug.cgi?id=130700
353
354         Reviewed by Timothy Hatcher.
355
356         * Configurations/FeatureDefines.xcconfig:
357
358 2014-04-03  Sam Weinig  <sam@webkit.org>
359
360         [WebKit2] Promote user script SPI to API
361         https://bugs.webkit.org/show_bug.cgi?id=131181
362
363         Reviewed by Anders Carlsson.
364
365         * MigrateHeaders.make:
366
367 2014-04-02  Benjamin Poulain  <bpoulain@apple.com>
368
369         [iOS] Remove the legacy string drawing code
370         https://bugs.webkit.org/show_bug.cgi?id=131088
371
372         Reviewed by Sam Weinig.
373
374         * Configurations/WebKit.xcconfig:
375
376 2014-04-02  Mark Rowe  <mrowe@apple.com>
377
378         <https://webkit.org/b/131135> Introduce LockHistory and LockBackForwardList enums to use in place of bools.
379
380         These arguments are often passed using literals at the call site, where the use of bools severely hinders
381         the readability of the code.
382
383         Reviewed by Andreas Kling.
384
385         * WebView/WebPDFView.mm:
386         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
387
388 2014-04-02  Stephanie Lewis  <slewis@apple.com>
389
390         Roll out http://trac.webkit.org/changeset/166144
391         <rdar://problem/16481284> PLT stops loading on news.google.com
392         
393         Unreviewed rollout.
394
395         Rollout 166144 since it prevents the PLT from completing.
396
397         * WebCoreSupport/WebFrameLoaderClient.mm:
398
399 2014-04-02  Daniel Bates  <dabates@apple.com>
400
401         Remove Settings::maximumDecodedImageSize()
402         https://bugs.webkit.org/show_bug.cgi?id=131057
403         <rdar://problem/15626368>
404
405         Reviewed by Darin Adler. 
406
407         Remove preferences key WebKitMaximumImageSize.
408
409         * WebView/WebPreferenceKeysPrivate.h:
410         * WebView/WebPreferences.mm:
411         (+[WebPreferences initialize]):
412         (-[WebPreferences _maximumImageSize:]): Deleted.
413         * WebView/WebPreferencesPrivate.h:
414         * WebView/WebView.mm:
415         (-[WebView _preferencesChanged:]):
416
417 2014-04-02  Martin Hock  <mhock@apple.com>
418
419         Unify private browsing with sessions.
420         https://bugs.webkit.org/show_bug.cgi?id=130099
421
422         Reviewed by Alexey Proskuryakov.
423
424         * WebCoreSupport/WebFrameLoaderClient.mm: Change WebCore::Settings::privateBrowsingEnabled() to Page::sessionID().isEphemeral().
425         (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
426         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
427         (WebFrameNetworkingContext::storageSession):
428         * WebView/WebView.mm: Change WebCore::Settings::setPrivateBrowsingEnabled() to Page::enableLegacyPrivateBrowsing().
429         (-[WebView _preferencesChanged:]):
430
431 2014-04-01  Anders Carlsson  <andersca@apple.com>
432
433         Migrate more headers
434         https://bugs.webkit.org/show_bug.cgi?id=131068
435
436         Reviewed by Tim Horton.
437
438         * MigrateHeaders.make:
439
440 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
441
442         [CSS Grid Layout] Enable runtime feature if feature flag is enabled
443         https://bugs.webkit.org/show_bug.cgi?id=130013
444
445         Reviewed by Simon Fraser.
446
447         Enable CSS Grid Layout runtime feature when ENABLE_CSS_GRID_LAYOUT flag is true.
448
449         * WebView/WebPreferences.mm:
450         (+[WebPreferences initialize]):
451
452 2014-03-31  Simon Fraser  <simon.fraser@apple.com>
453
454         Enable WEB_TIMING on Mac and iOS
455         https://bugs.webkit.org/show_bug.cgi?id=128064
456
457         Reviewed by Sam Weinig, Brent Fulgham.
458
459         Enable WEB_TIMING.
460
461         * Configurations/FeatureDefines.xcconfig:
462
463 2014-03-31  Dean Jackson  <dino@apple.com>
464
465         Remove WEB_ANIMATIONS
466         https://bugs.webkit.org/show_bug.cgi?id=130989
467
468         Reviewed by Simon Fraser.
469
470         Remove this feature flag until we plan to implement.
471
472         * Configurations/FeatureDefines.xcconfig:
473
474 2014-03-31  Antti Koivisto  <antti@apple.com>
475
476         Rename TileCache to LegacyTileCache
477         https://bugs.webkit.org/show_bug.cgi?id=130986
478
479         Reviewed by Simon Fraser.
480
481         * WebView/WebView.mm:
482         (+[WebView drainLayerPool]):
483         (+[WebView _setTileCacheLayerPoolCapacity:]):
484
485 2014-03-28  Darin Adler  <darin@apple.com>
486
487         Fix recently-introduced off-by-one error in centerTruncateToBuffer
488         https://bugs.webkit.org/show_bug.cgi?id=130889
489
490         Reviewed by Alexey Proskuryakov.
491
492         * Misc/WebStringTruncator.mm:
493         (defaultMenuFont): Changed to use NeverDestroyed since I had to touch this file anyway.
494         (fontFromNSFont): Ditto. Also improved variable names a bit.
495         (+[WebStringTruncator initialize]): Added threading initialization, needed for main
496         thread assertions in string truncator code.
497
498 2014-03-27  Commit Queue  <commit-queue@webkit.org>
499
500         Unreviewed, rolling out r166360.
501         https://bugs.webkit.org/show_bug.cgi?id=130869
502
503         Seems to have broken PLT (Requested by ap on #webkit).
504
505         Reverted changeset:
506
507         "Connection::dispatchOneMessage() can be re-entered while
508         handling Cmd-key menu"
509         https://bugs.webkit.org/show_bug.cgi?id=130767
510         http://trac.webkit.org/changeset/166360
511
512 2014-03-27  Alexey Proskuryakov  <ap@apple.com>
513
514         Connection::dispatchOneMessage() can be re-entered while handling Cmd-key menu
515         equivalents, ASSERT(!_data->_keyDownEventBeingResent)
516         https://bugs.webkit.org/show_bug.cgi?id=130767
517         <rdar://problem/16307487>
518
519         Reviewed by Darin Adler.
520
521         Switched to a WebCore wrapper for RunLoop::initializeMainRunLoop that adds
522         NSModalPanelRunLoopMode to RunLoop event source and timer modes.
523
524         * Carbon/CarbonWindowAdapter.mm: (+[CarbonWindowAdapter initialize]):
525         * History/WebBackForwardList.mm: (+[WebBackForwardList initialize]):
526         * History/WebHistoryItem.mm: (+[WebHistoryItem initialize]):
527         * Misc/WebCache.mm: (+[WebCache initialize]):
528         * Misc/WebElementDictionary.mm: (+[WebElementDictionary initialize]):
529         * Misc/WebIconDatabase.mm: (+[WebIconDatabase initialize]):
530         * Plugins/Hosted/WebHostedNetscapePluginView.mm: (+[WebHostedNetscapePluginView initialize]):
531         * Plugins/WebBaseNetscapePluginView.mm:
532         * Plugins/WebBasePluginPackage.mm:
533         * Plugins/WebNetscapePluginView.mm: (+[WebNetscapePluginView initialize]):
534         * WebCoreSupport/WebEditorClient.mm: (+[WebUndoStep initialize]):
535         * WebCoreSupport/WebFrameLoaderClient.mm:
536         * WebView/WebArchive.mm: (+[WebArchivePrivate initialize]):
537         * WebView/WebDataSource.mm: (+[WebDataSource initialize]):
538         * WebView/WebHTMLView.mm:
539         (+[WebHTMLViewPrivate initialize]):
540         (+[WebHTMLView initialize]):
541         * WebView/WebPreferences.mm: (+[WebPreferences initialize]):
542         * WebView/WebResource.mm: (+[WebResourcePrivate initialize]):
543         * WebView/WebTextIterator.mm: (+[WebTextIteratorPrivate initialize]):
544         * WebView/WebView.mm: (+[WebView initialize]):
545         * WebView/WebViewData.mm: (+[WebViewPrivate initialize]):
546
547 2014-03-26  Timothy Hatcher  <timothy@apple.com>
548
549         Propagate the hiddenFromInspector flag on ResourceRequest in
550         places when a new request a made or passed between processes.
551
552         https://bugs.webkit.org/show_bug.cgi?id=130741
553
554         Reviewed by Joseph Pecoraro.
555
556         * WebCoreSupport/WebFrameLoaderClient.mm:
557         (WebFrameLoaderClient::dispatchWillSendRequest): Copy hiddenFromInspector to
558         the new request.
559
560 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
561
562         [CSS Shapes] Remove shape-inside support
563         https://bugs.webkit.org/show_bug.cgi?id=130698
564
565         Reviewed by David Hyatt.
566
567         * Configurations/FeatureDefines.xcconfig:
568
569 2014-03-25  Joseph Pecoraro  <pecoraro@apple.com>
570
571         [iOS] Inspector View Indication Support
572         https://bugs.webkit.org/show_bug.cgi?id=130709
573
574         Reviewed by Simon Fraser.
575
576         * WebCoreSupport/WebInspectorClient.h:
577         * WebCoreSupport/WebInspectorClient.mm:
578         (WebInspectorClient::didSetSearchingForNode): Deleted.
579         (WebInspectorClient::releaseFrontend): Deleted.
580         * WebView/WebView.mm:
581         (-[WebView setShowingInspectorIndication:]):
582         * WebView/WebViewPrivate.h:
583         Renamed methods.
584
585 2014-03-24  Brent Fulgham  <bfulgham@apple.com>
586
587         Activate WebVTT Tests Once Merging is Complete
588         https://bugs.webkit.org/show_bug.cgi?id=130420
589
590         Reviewed by Eric Carlson.
591
592         * Configurations/FeatureDefines.xcconfig: Turn on ENABLE(WEBVTT_REGIONS)
593
594 2014-03-24  Andy Estes  <aestes@apple.com>
595
596         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
597         https://bugs.webkit.org/show_bug.cgi?id=129322
598
599         Reviewed by Anders Carlsson.
600
601         * WebCoreSupport/WebFrameLoaderClient.mm:
602         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Use the
603         RetainPtr returned by releaseConnectionForDownload() rather than
604         manually releasing.
605
606 2014-03-24  Jon Lee  <jonlee@apple.com>
607
608         Build fixes.
609
610         Unreviewed.
611
612         * WebInspector/WebNodeHighlightView.mm: Missing include to GeometryUtilities.
613
614 2014-03-23  Sam Weinig  <sam@webkit.org>
615
616         Remove some unnecessary .get()s that Darin noticed.
617
618         * WebView/WebHTMLRepresentation.mm:
619         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
620         * WebView/WebHTMLView.mm:
621         (-[WebHTMLView attributedString]):
622
623 2014-03-23  Sam Weinig  <sam@webkit.org>
624
625         Simplify the HTMLConverter interface (Part 2)
626         https://bugs.webkit.org/show_bug.cgi?id=130654
627
628         Reviewed by Darin Adler.
629
630         * WebView/WebHTMLRepresentation.mm:
631         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
632         * WebView/WebHTMLView.mm:
633         (-[WebHTMLView attributedSubstringFromRange:]):
634         (-[WebHTMLView attributedString]):
635         (-[WebHTMLView selectedAttributedString]):
636
637 2014-03-23  Darin Adler  <darin@apple.com>
638
639         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
640         https://bugs.webkit.org/show_bug.cgi?id=130653
641
642         Reviewed by Antti Koivisto.
643
644         * WebCoreSupport/WebFrameLoaderClient.mm: Call toHTMLPlugInImageElement instead of
645         doing a static_cast.
646
647 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
648
649         Don't flush compositing layers within FrameView::willPaintContents()
650         https://bugs.webkit.org/show_bug.cgi?id=130627
651
652         Reviewed by Sam Weinig.
653         
654         Make _flushCompositingChanges private so DRT can call it;
655         moved it into the Private category.
656
657         * WebView/WebView.mm:
658         (-[WebView _flushCompositingChanges]):
659         * WebView/WebViewPrivate.h:
660
661 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
662
663         Remove duplicate line added during merging
664         https://bugs.webkit.org/show_bug.cgi?id=130623
665
666         Reviewed by Beth Dakin.
667         
668         Remove a duplicate call to -_viewWillDrawInternal which
669         was added during merges.
670
671         * WebView/WebView.mm:
672         (LayerFlushController::flushLayers):
673
674 2014-03-21  Darin Adler  <darin@apple.com>
675
676         Improve idiom used for string building in a few places
677         https://bugs.webkit.org/show_bug.cgi?id=130561
678
679         Reviewed by Andreas Kling.
680
681         * WebView/WebHTMLRepresentation.mm:
682         (regExpForLabels): Use StringBuilder.
683
684 2014-03-21  Darin Adler  <darin@apple.com>
685
686         Add a combined decodeAndFlush to TextResourceDecoder
687         https://bugs.webkit.org/show_bug.cgi?id=130560
688
689         Reviewed by Andreas Kling.
690
691         * WebView/WebView.mm:
692         (+[WebView _decodeData:]): Use decodeAndFlush.
693
694 2014-03-20  Anders Carlsson  <andersca@apple.com>
695
696         Fix build.
697
698         * MigrateHeaders.make:
699
700 2014-03-20  Pratik Solanki  <psolanki@apple.com>
701
702         [iOS] Get code to compile on older iOS versions
703         https://bugs.webkit.org/show_bug.cgi?id=130142
704         <rdar://problem/16302908>
705
706         Reviewed by Darin Adler.
707
708         * History/WebHistory.mm:
709         (getDayBoundaries):
710         * Plugins/WebPluginController.h:
711         * Plugins/WebPluginController.mm:
712         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
713         * WebCoreSupport/WebFrameLoaderClient.mm:
714         (pluginView):
715         * WebView/WebPreferences.mm:
716         (-[WebPreferences _setAllowCompositingLayerVisualDegradation:]):
717         * WebView/WebPreferencesPrivate.h:
718
719 2014-03-20  Lucas Forschler  <lforschler@apple.com>
720
721     Rollout r165944.  Build break.
722     
723 2014-03-19  Pratik Solanki  <psolanki@apple.com>
724
725         [iOS] Get code to compile on older iOS versions
726         https://bugs.webkit.org/show_bug.cgi?id=130142
727         <rdar://problem/16302908>
728
729         Reviewed by Darin Adler.
730
731         * History/WebHistory.mm:
732         (getDayBoundaries):
733         * Plugins/WebPluginController.h:
734         * Plugins/WebPluginController.mm:
735         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
736         * WebCoreSupport/WebFrameLoaderClient.mm:
737         (pluginView):
738         * WebView/WebPreferences.mm:
739         (-[WebPreferences _setAllowCompositingLayerVisualDegradation:]):
740         * WebView/WebPreferencesPrivate.h:
741
742 2014-03-19  Jer Noble  <jer.noble@apple.com>
743
744         [Mac][EME] Query whether decoder support exists before creating a new MediaKeys object.
745         https://bugs.webkit.org/show_bug.cgi?id=130459
746
747         Reviewed by Eric Carlson.
748
749         * WebCoreSupport/WebSystemInterface.mm:
750         (InitWebCoreSystemInterface): Initialize the new WCSI method.
751
752 2014-03-19  Brady Eidson  <beidson@apple.com>
753
754         Filter out editable services from image menu for non-contenteditable images
755         <rdar://problem/16319645> and https://bugs.webkit.org/show_bug.cgi?id=130437
756
757         Reviewed by Tim Horton.
758
759         * Misc/WebSharingServicePickerController.h:
760         * Misc/WebSharingServicePickerController.mm:
761         (-[WebSharingServicePickerController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
762           Filter out editing services based on the includeEditorServices flag.
763         * WebCoreSupport/WebContextMenuClient.mm:
764         (WebContextMenuClient::contextMenuForEvent):
765
766 2014-03-19  Jer Noble  <jer.noble@apple.com>
767
768         [iOS] Disable the video plugin proxy by default on WK1.
769         https://bugs.webkit.org/show_bug.cgi?id=130460
770
771         Reviewed by Eric Carlson.
772
773         Update the defaults to universally enable the AVFoundationEnabled preference, disable the
774         VideoPluginProxyEnabled preference, and on iOS only enable the AVKitEnabled preference.
775
776         * WebView/WebPreferences.mm:
777         (+[WebPreferences initialize]):
778
779 2014-03-18  Samuel White  <samuel_white@apple.com>
780
781         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
782         https://bugs.webkit.org/show_bug.cgi?id=130250
783
784         Reviewed by Chris Fleizach.
785
786         Added ability to toggle enhanced accessibility on and off to support tests that require it.
787
788         * WebView/WebFrame.mm:
789         (-[WebFrame enhancedAccessibilityEnabled]):
790         (-[WebFrame setEnhancedAccessibility:]):
791         * WebView/WebFramePrivate.h:
792
793 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
794
795         More FTL enabling.
796
797         Rubber stamped by Dan Bernstein.
798
799         * Configurations/FeatureDefines.xcconfig:
800
801 2014-03-17  Andy Estes  <aestes@apple.com>
802
803         Remove staging code added for <http://webkit.org/b/129358> [iOS] Support network state notification using CPNetworkObserver
804
805         Reviewed by Enrica Casucci.
806
807         * WebView/WebView.mm:
808
809 2014-03-17  Anders Carlsson  <andersca@apple.com>
810
811         WebKitLegacy headers should #import the relevant WebKit headers
812         https://bugs.webkit.org/show_bug.cgi?id=130372
813         <rdar://problem/16349094>
814
815         Reviewed by Dan Bernstein.
816
817         Create forwarding headers instead.
818
819         * WebKitLegacy/MigrateHeadersToLegacy.make:
820
821 2014-03-17  Tim Horton  <timothy_horton@apple.com>
822
823         Rename WKThumbnailView to _WKThumbnailView
824         https://bugs.webkit.org/show_bug.cgi?id=130361
825
826         Reviewed by Anders Carlsson.
827
828         * MigrateHeaders.make:
829
830 2014-03-17  David Farler  <dfarler@apple.com>
831
832         REGRESSION: WebKitLegacy causes ASan build to fail
833         <rdar://problem/16344326>
834
835         Reviewed by David Kilzer.
836
837         * Configurations/DebugRelease.xcconfig: Remove $(inherited) from
838         OTHER_CFLAGS, OTHER_CPLUSPLUSFLAGS, OTHER_LDFLAGS to prevent
839         double complete ASAN flags.
840
841 2014-03-16  Brent Fulgham  <bfulgham@apple.com>
842
843         Provide preference to enable additional AVFoundation options
844         https://bugs.webkit.org/show_bug.cgi?id=130275
845
846         Reviewed by Eric Carlson.
847
848         * WebView/WebPreferenceKeysPrivate.h: Added new preference.
849         * WebView/WebPreferences.mm:
850         (+[WebPreferences initialize]): Initialize preference to false.
851         (-[WebPreferences isInheritURIQueryComponentEnabled]): Added.
852         (-[WebPreferences setEnableInheritURIQueryComponent:]): Added.
853         * WebView/WebPreferencesPrivate.h:
854         * WebView/WebView.mm:
855         (-[WebView _preferencesChanged:]): Handle new preference.
856
857 2014-03-16  Darin Adler  <darin@apple.com>
858
859         Remove all deprecatedCharacters use from WebKit directory
860         https://bugs.webkit.org/show_bug.cgi?id=130305
861
862         Reviewed by Andreas Kling.
863
864         * History/BinaryPropertyList.cpp:
865         (BinaryPropertyListSerializer::appendStringObject): Use operator[]
866         instead of deprecatedCharacters.
867
868 2014-03-14  Mark Rowe  <mrowe@apple.com>
869
870         Fix the production build.
871
872         Don't rely on USE_INTERNAL_SDK being set for the Production configuration since UseInternalSDK.xcconfig won't
873         be at the expected relative path when working from installed source.
874
875         * Configurations/Base.xcconfig:
876
877 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
878
879         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
880         https://bugs.webkit.org/show_bug.cgi?id=130276
881         <rdar://problem/16266927>
882         
883         Reviewed by Simon Fraser.
884
885         * Carbon/CarbonUtils.h:
886         * Carbon/CarbonUtils.m:
887         * Carbon/CarbonWindowAdapter.h:
888         * Carbon/CarbonWindowAdapter.mm:
889         * Carbon/CarbonWindowContentView.h:
890         * Carbon/CarbonWindowContentView.m:
891         * Carbon/CarbonWindowFrame.h:
892         * Carbon/CarbonWindowFrame.m:
893         * Carbon/HIViewAdapter.h:
894         * Carbon/HIViewAdapter.m:
895         * Carbon/HIWebView.h:
896         * Carbon/HIWebView.mm:
897         * DOM/WebDOMOperations.h:
898         * DOM/WebDOMOperations.mm:
899         * DOM/WebDOMOperationsInternal.h:
900         * DOM/WebDOMOperationsPrivate.h:
901         * DefaultDelegates/WebDefaultContextMenuDelegate.h:
902         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
903         * DefaultDelegates/WebDefaultEditingDelegate.h:
904         * DefaultDelegates/WebDefaultEditingDelegate.m:
905         * DefaultDelegates/WebDefaultPolicyDelegate.h:
906         * DefaultDelegates/WebDefaultPolicyDelegate.m:
907         * DefaultDelegates/WebDefaultUIDelegate.h:
908         * DefaultDelegates/WebDefaultUIDelegate.m:
909         * History/WebBackForwardList.h:
910         * History/WebBackForwardList.mm:
911         * History/WebBackForwardListInternal.h:
912         * History/WebBackForwardListPrivate.h:
913         * History/WebHistory.h:
914         * History/WebHistory.mm:
915         * History/WebHistoryInternal.h:
916         * History/WebHistoryItem.h:
917         * History/WebHistoryItem.mm:
918         * History/WebHistoryItemInternal.h:
919         * History/WebHistoryItemPrivate.h:
920         * History/WebHistoryPrivate.h:
921         * History/WebURLsWithTitles.h:
922         * History/WebURLsWithTitles.m:
923         * MigrateHeaders.make:
924         * Misc/OldWebAssertions.c:
925         * Misc/WebCache.h:
926         * Misc/WebCache.mm:
927         * Misc/WebCoreStatistics.h:
928         * Misc/WebCoreStatistics.mm:
929         * Misc/WebDownload.h:
930         * Misc/WebDownload.mm:
931         * Misc/WebDownloadInternal.h:
932         * Misc/WebElementDictionary.h:
933         * Misc/WebElementDictionary.mm:
934         * Misc/WebIconDatabase.h:
935         * Misc/WebIconDatabase.mm:
936         * Misc/WebIconDatabaseDelegate.h:
937         * Misc/WebIconDatabaseInternal.h:
938         * Misc/WebIconDatabasePrivate.h:
939         * Misc/WebKit.h:
940         * Misc/WebKitErrors.h:
941         * Misc/WebKitErrors.m:
942         * Misc/WebKitErrorsPrivate.h:
943         * Misc/WebKitLogging.h:
944         * Misc/WebKitLogging.m:
945         * Misc/WebKitNSStringExtras.h:
946         * Misc/WebKitNSStringExtras.mm:
947         * Misc/WebKitStatistics.h:
948         * Misc/WebKitStatistics.m:
949         * Misc/WebKitStatisticsPrivate.h:
950         * Misc/WebKitSystemBits.h:
951         * Misc/WebKitSystemBits.m:
952         * Misc/WebKitVersionChecks.h:
953         * Misc/WebKitVersionChecks.m:
954         * Misc/WebLocalizableStrings.h:
955         * Misc/WebLocalizableStrings.mm:
956         * Misc/WebNSArrayExtras.h:
957         * Misc/WebNSArrayExtras.m:
958         * Misc/WebNSControlExtras.h:
959         * Misc/WebNSControlExtras.m:
960         * Misc/WebNSDataExtras.h:
961         * Misc/WebNSDataExtras.m:
962         * Misc/WebNSDataExtrasPrivate.h:
963         * Misc/WebNSDictionaryExtras.h:
964         * Misc/WebNSDictionaryExtras.m:
965         * Misc/WebNSEventExtras.h:
966         * Misc/WebNSEventExtras.m:
967         * Misc/WebNSFileManagerExtras.h:
968         * Misc/WebNSFileManagerExtras.mm:
969         * Misc/WebNSImageExtras.h:
970         * Misc/WebNSImageExtras.m:
971         * Misc/WebNSObjectExtras.h:
972         * Misc/WebNSObjectExtras.mm:
973         * Misc/WebNSPasteboardExtras.h:
974         * Misc/WebNSPasteboardExtras.mm:
975         * Misc/WebNSPrintOperationExtras.h:
976         * Misc/WebNSPrintOperationExtras.m:
977         * Misc/WebNSURLExtras.h:
978         * Misc/WebNSURLExtras.mm:
979         * Misc/WebNSURLRequestExtras.h:
980         * Misc/WebNSURLRequestExtras.m:
981         * Misc/WebNSUserDefaultsExtras.h:
982         * Misc/WebNSUserDefaultsExtras.mm:
983         * Misc/WebNSViewExtras.h:
984         * Misc/WebNSViewExtras.m:
985         * Misc/WebNSWindowExtras.h:
986         * Misc/WebNSWindowExtras.m:
987         * Misc/WebStringTruncator.h:
988         * Misc/WebStringTruncator.mm:
989         * Misc/WebTypesInternal.h:
990         * Panels/WebAuthenticationPanel.h:
991         * Panels/WebAuthenticationPanel.m:
992         * Panels/WebPanelAuthenticationHandler.h:
993         * Panels/WebPanelAuthenticationHandler.m:
994         * Plugins/Hosted/ProxyRuntimeObject.h:
995         * Plugins/Hosted/ProxyRuntimeObject.mm:
996         * Plugins/WebBaseNetscapePluginView.h:
997         * Plugins/WebBaseNetscapePluginView.mm:
998         * Plugins/WebBasePluginPackage.h:
999         * Plugins/WebBasePluginPackage.mm:
1000         * Plugins/WebJavaPlugIn.h:
1001         * Plugins/WebNetscapeContainerCheckContextInfo.h:
1002         * Plugins/WebNetscapeContainerCheckPrivate.h:
1003         * Plugins/WebNetscapeContainerCheckPrivate.mm:
1004         * Plugins/WebNetscapePluginPackage.h:
1005         * Plugins/WebNetscapePluginPackage.mm:
1006         * Plugins/WebNetscapePluginStream.h:
1007         * Plugins/WebNetscapePluginStream.mm:
1008         * Plugins/WebNetscapePluginView.h:
1009         * Plugins/WebNetscapePluginView.mm:
1010         * Plugins/WebPlugin.h:
1011         * Plugins/WebPluginContainer.h:
1012         * Plugins/WebPluginContainerCheck.h:
1013         * Plugins/WebPluginContainerCheck.mm:
1014         * Plugins/WebPluginContainerPrivate.h:
1015         * Plugins/WebPluginController.h:
1016         * Plugins/WebPluginController.mm:
1017         * Plugins/WebPluginDatabase.h:
1018         * Plugins/WebPluginDatabase.mm:
1019         * Plugins/WebPluginPackage.h:
1020         * Plugins/WebPluginPackage.mm:
1021         * Plugins/WebPluginRequest.h:
1022         * Plugins/WebPluginRequest.m:
1023         * Plugins/WebPluginViewFactory.h:
1024         * Plugins/WebPluginViewFactoryPrivate.h:
1025         * Plugins/WebPluginsPrivate.h:
1026         * Plugins/WebPluginsPrivate.m:
1027         * Plugins/npapi.mm:
1028         * Storage/WebDatabaseManager.mm:
1029         * Storage/WebDatabaseManagerInternal.h:
1030         * Storage/WebDatabaseManagerPrivate.h:
1031         * WebCoreSupport/SearchPopupMenuMac.mm:
1032         * WebCoreSupport/WebAlternativeTextClient.h:
1033         * WebCoreSupport/WebAlternativeTextClient.mm:
1034         * WebCoreSupport/WebCachedFramePlatformData.h:
1035         * WebCoreSupport/WebChromeClient.h:
1036         * WebCoreSupport/WebChromeClient.mm:
1037         * WebCoreSupport/WebContextMenuClient.h:
1038         * WebCoreSupport/WebContextMenuClient.mm:
1039         * WebCoreSupport/WebDragClient.h:
1040         * WebCoreSupport/WebDragClient.mm:
1041         * WebCoreSupport/WebEditorClient.h:
1042         * WebCoreSupport/WebEditorClient.mm:
1043         * WebCoreSupport/WebFrameLoaderClient.h:
1044         * WebCoreSupport/WebFrameLoaderClient.mm:
1045         * WebCoreSupport/WebIconDatabaseClient.h:
1046         * WebCoreSupport/WebIconDatabaseClient.mm:
1047         * WebCoreSupport/WebInspectorClient.h:
1048         * WebCoreSupport/WebInspectorClient.mm:
1049         * WebCoreSupport/WebJavaScriptTextInputPanel.h:
1050         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1051         * WebCoreSupport/WebSecurityOrigin.mm:
1052         * WebCoreSupport/WebSecurityOriginInternal.h:
1053         * WebCoreSupport/WebSecurityOriginPrivate.h:
1054         * WebCoreSupport/WebSystemInterface.h:
1055         * WebCoreSupport/WebSystemInterface.mm:
1056         * WebInspector/WebInspector.h:
1057         * WebInspector/WebInspector.mm:
1058         * WebInspector/WebInspectorPrivate.h:
1059         * WebInspector/WebNodeHighlight.h:
1060         * WebInspector/WebNodeHighlight.mm:
1061         * WebInspector/WebNodeHighlightView.h:
1062         * WebInspector/WebNodeHighlightView.mm:
1063         * WebInspector/WebNodeHighlighter.h:
1064         * WebInspector/WebNodeHighlighter.mm:
1065         * WebKitLegacy/MigrateHeadersToLegacy.make:
1066         * WebKitPrefix.h:
1067         * WebView/WebArchive.h:
1068         * WebView/WebArchive.mm:
1069         * WebView/WebArchiveInternal.h:
1070         * WebView/WebClipView.h:
1071         * WebView/WebClipView.mm:
1072         * WebView/WebDashboardRegion.h:
1073         * WebView/WebDashboardRegion.mm:
1074         * WebView/WebDataSource.h:
1075         * WebView/WebDataSource.mm:
1076         * WebView/WebDataSourceInternal.h:
1077         * WebView/WebDataSourcePrivate.h:
1078         * WebView/WebDelegateImplementationCaching.h:
1079         * WebView/WebDelegateImplementationCaching.mm:
1080         * WebView/WebDocument.h:
1081         * WebView/WebDocumentInternal.h:
1082         * WebView/WebDocumentLoaderMac.h:
1083         * WebView/WebDocumentLoaderMac.mm:
1084         * WebView/WebDocumentPrivate.h:
1085         * WebView/WebDynamicScrollBarsViewInternal.h:
1086         * WebView/WebEditingDelegate.h:
1087         * WebView/WebEditingDelegatePrivate.h:
1088         * WebView/WebFormDelegate.h:
1089         * WebView/WebFormDelegate.m:
1090         * WebView/WebFormDelegatePrivate.h:
1091         * WebView/WebFrame.h:
1092         * WebView/WebFrame.mm:
1093         * WebView/WebFrameInternal.h:
1094         * WebView/WebFrameLoadDelegate.h:
1095         * WebView/WebFrameLoadDelegatePrivate.h:
1096         * WebView/WebFramePrivate.h:
1097         * WebView/WebFrameView.h:
1098         * WebView/WebFrameView.mm:
1099         * WebView/WebFrameViewInternal.h:
1100         * WebView/WebFrameViewPrivate.h:
1101         * WebView/WebHTMLRepresentation.h:
1102         * WebView/WebHTMLRepresentation.mm:
1103         * WebView/WebHTMLRepresentationPrivate.h:
1104         * WebView/WebHTMLView.h:
1105         * WebView/WebHTMLView.mm:
1106         * WebView/WebHTMLViewInternal.h:
1107         * WebView/WebHTMLViewPrivate.h:
1108         * WebView/WebNotification.h:
1109         * WebView/WebNotification.mm:
1110         * WebView/WebNotificationInternal.h:
1111         * WebView/WebPDFRepresentation.h:
1112         * WebView/WebPDFRepresentation.mm:
1113         * WebView/WebPDFView.h:
1114         * WebView/WebPDFView.mm:
1115         * WebView/WebPolicyDelegate.h:
1116         * WebView/WebPolicyDelegate.mm:
1117         * WebView/WebPolicyDelegatePrivate.h:
1118         * WebView/WebPreferenceKeysPrivate.h:
1119         * WebView/WebPreferences.h:
1120         * WebView/WebPreferences.mm:
1121         * WebView/WebPreferencesPrivate.h:
1122         * WebView/WebRenderLayer.h:
1123         * WebView/WebRenderLayer.mm:
1124         * WebView/WebRenderNode.h:
1125         * WebView/WebRenderNode.mm:
1126         * WebView/WebResource.h:
1127         * WebView/WebResource.mm:
1128         * WebView/WebResourceInternal.h:
1129         * WebView/WebResourceLoadDelegate.h:
1130         * WebView/WebResourceLoadDelegatePrivate.h:
1131         * WebView/WebResourcePrivate.h:
1132         * WebView/WebScriptDebugDelegate.h:
1133         * WebView/WebScriptDebugDelegate.mm:
1134         * WebView/WebScriptDebugger.h:
1135         * WebView/WebScriptDebugger.mm:
1136         * WebView/WebTextCompletionController.mm:
1137         * WebView/WebUIDelegate.h:
1138         * WebView/WebUIDelegatePrivate.h:
1139         * WebView/WebView.h:
1140         * WebView/WebView.mm:
1141         * WebView/WebViewData.h:
1142         * WebView/WebViewData.mm:
1143         * WebView/WebViewInternal.h:
1144         * WebView/WebViewPrivate.h:
1145
1146 2014-03-14  Ryosuke Niwa  <rniwa@webkit.org>
1147
1148         REGRESSION(r165385): [WebTextIterator currentRange] crashes
1149         https://bugs.webkit.org/show_bug.cgi?id=130271
1150
1151         Reviewed by Anders Carlsson.
1152
1153         After r165385, TextIterator::range no longer checked the nullity of m_positionNode. As a result,
1154         [WebTextIterator currentRange] which simply calls TextIterator::range crashes when an application
1155         that embeds WebKit doesn't check [WebTextIterator atEnd] first.
1156
1157         Preserve the old public API behavior by checking atEnd in [WebTextIterator currentRange].
1158
1159         * WebView/WebTextIterator.mm:
1160         (-[WebTextIterator currentRange]):
1161
1162 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
1163
1164         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
1165         https://bugs.webkit.org/show_bug.cgi?id=129612
1166
1167         Reviewed by Darin Adler.
1168
1169         For new code use static NeverDestroyed<T> instead.
1170
1171         * History/WebBackForwardList.mm:
1172         (backForwardLists):
1173         * History/WebHistoryItem.mm:
1174         (historyItemWrappers):
1175         * Misc/WebNSPasteboardExtras.mm:
1176         (+[NSPasteboard _web_writableTypesForURL]):
1177         (_writableTypesForImageWithoutArchive):
1178         (_writableTypesForImageWithArchive):
1179         * Misc/WebStringTruncator.mm:
1180         (fontFromNSFont):
1181         * Plugins/Hosted/NetscapePluginHostManager.mm:
1182         (WebKit::NetscapePluginHostManager::shared):
1183         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1184         (WebKit::pluginProxyMap):
1185         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1186         (WebKit::globalExceptionString):
1187         * Plugins/Hosted/ProxyInstance.mm:
1188         (WebKit::proxyClass):
1189         * Plugins/WebNetscapePluginStream.mm:
1190         (streams):
1191         * Storage/WebDatabaseManager.mm:
1192         (transactionBackgroundTaskIdentifierLock):
1193         * WebCoreSupport/WebUserMediaClient.mm:
1194         (userMediaRequestsMap):
1195         * WebView/WebHTMLRepresentation.mm:
1196         (regExpForLabels):
1197         * WebView/WebView.mm:
1198         (aeDescFromJSValue):
1199
1200 2014-03-13  Tim Horton  <timothy_horton@apple.com>
1201
1202         Fix relative paths to UseInternalSDK.xcconfig for ANGLE and WebKit/mac
1203
1204         Rubber-stamped by Mark Rowe.
1205
1206         One-too-few "..".
1207
1208         * Configurations/Base.xcconfig:
1209
1210 2014-03-13  Anders Carlsson  <andersca@apple.com>
1211
1212         Fix build.
1213
1214         * Misc/WebSharingServicePickerController.mm:
1215
1216 2014-03-13  Radu Stavila  <stavila@adobe.com>
1217
1218         Webkit not building on XCode 5.1 due to garbage collection no longer being supported
1219         https://bugs.webkit.org/show_bug.cgi?id=130087
1220
1221         Reviewed by Mark Rowe.
1222
1223         Disable garbage collection on macosx when not using internal SDK.
1224
1225         * Configurations/Base.xcconfig:
1226
1227 2014-03-10  Darin Adler  <darin@apple.com>
1228
1229         Avoid copy-prone idiom "for (auto item : collection)"
1230         https://bugs.webkit.org/show_bug.cgi?id=129990
1231
1232         Reviewed by Geoffrey Garen.
1233
1234         * WebView/WebFrame.mm:
1235         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
1236         Use auto*. Also removed uneeded ASSERT_NO_EXCEPTION, which is already
1237         the default without specifying it explicitly.
1238
1239 2014-03-12  Brian Burg  <bburg@apple.com>
1240
1241         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
1242         https://bugs.webkit.org/show_bug.cgi?id=129744
1243
1244         Reviewed by Timothy Hatcher.
1245
1246         * WebInspector/WebInspector.mm:
1247         (-[WebInspector evaluateInFrontend:script:]):
1248         * WebInspector/WebInspectorPrivate.h:
1249
1250 2014-03-12  Dean Jackson  <dino@apple.com>
1251
1252         [WebGL] WebKit1 + WebKit2 iOS clients should check load policy
1253         https://bugs.webkit.org/show_bug.cgi?id=130162
1254
1255         Reviewed by Simon Fraser.
1256
1257         Implement the webGLPolicyForURL methods, calling into WebKitSystemInterface.
1258
1259         * Configurations/WebKit.xcconfig: Add MobileAsset to iOS config.
1260         * WebCoreSupport/WebFrameLoaderClient.h:
1261         * WebCoreSupport/WebFrameLoaderClient.mm:
1262
1263 2014-03-12  Joseph Pecoraro  <pecoraro@apple.com>
1264
1265         Web Inspector: Disable REMOTE_INSPECTOR in earlier OS X releases
1266         https://bugs.webkit.org/show_bug.cgi?id=130118
1267
1268         Reviewed by Timothy Hatcher.
1269
1270         * Configurations/FeatureDefines.xcconfig:
1271
1272         * WebCoreSupport/WebInspectorClient.mm:
1273         (WebInspectorClient::indicate):
1274         (WebInspectorClient::hideIndication):
1275         Properly guard REMOTE_INSPECTOR only calls.
1276
1277 2014-03-12  Tim Horton  <timothy_horton@apple.com>
1278
1279         Build fix for ENABLE(IMAGE_CONTROLS) after 165479
1280
1281         * Misc/WebSharingServicePickerController.h:
1282         * Misc/WebSharingServicePickerController.mm:
1283         Don't use new-runtime features in code that has to build 32-bit.
1284
1285 2014-03-12  Anders Carlsson  <andersca@apple.com>
1286
1287         <rdar://problem/16307346> Add new WebKitLegacy.framework.
1288
1289         Reviewed by Dan Bernstein.
1290
1291         * Configurations/WebKitLegacy.xcconfig:
1292         Add xcconfig file for the new framework.
1293
1294         * WebKitLegacy/Info.plist:
1295         Add Info.plist for WebKitLegacy.framework.
1296
1297         * WebKitLegacy/MigrateHeadersToLegacy.make:
1298         Add makefile that copies headers from WebKit to WebKitLegacy and rewrites includes from WebKit/ to WebKitLegacy/
1299         * WebKitLegacy/WebKitLegacy.cpp:
1300         Add an empty file so we'll have something to link.
1301
1302 2014-03-12  Tim Horton  <timothy_horton@apple.com>
1303
1304         Hook up image controls for WebKit1
1305         https://bugs.webkit.org/show_bug.cgi?id=130062
1306         <rdar://problem/15964809>
1307
1308         Reviewed by Brady Eidson.
1309
1310         * Misc/WebSharingServicePickerController.h: Added.
1311         * Misc/WebSharingServicePickerController.mm: Added.
1312         (-[WebSharingServicePickerController initWithImage:menuClient:]):
1313         (-[WebSharingServicePickerController menu]):
1314         (-[WebSharingServicePickerController sharingServicePicker:delegateForSharingService:]):
1315         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
1316         (-[WebSharingServicePickerController sharingService:didShareItems:]):
1317         (-[WebSharingServicePickerController sharingService:didFailToShareItems:error:]):
1318         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
1319         Add a NSSharingServiceDelegate and NSSharingServicePickerDelegate, which will also
1320         provide a NSMenu instance for WebContextMenuClient to pop up when image controls are needed.
1321         When data is returned from the service, it is re-inserted into the image via replaceControlledImage.
1322
1323         * WebCoreSupport/WebContextMenuClient.h:
1324         * WebCoreSupport/WebContextMenuClient.mm:
1325         (WebContextMenuClient::contextMenuForEvent):
1326         Factor out code to decide which NSMenu to use, so that we can use early-returns to simplify it.
1327         If we hit an image with image controls, use the WebSharingServicePickerController's menu.
1328
1329         (WebContextMenuClient::showContextMenu):
1330         (WebContextMenuClient::clearSharingServicePickerController):
1331
1332 2014-03-10  Jer Noble  <jer.noble@apple.com>
1333
1334         [iOS][WK1] Crash in HTMLMediaElement::createElementRenderer() - "-[NSSet addObject:]: object cannot be nil"
1335         https://bugs.webkit.org/show_bug.cgi?id=129634
1336
1337         Reviewed by Eric Carlson.
1338
1339         If a plugin fails to create a NSView, a nil object is inserted into the WebPluginController's
1340         pluginViews set. This is an exceptional case, so add an ASSERT so that this error will continue
1341         to occur in debug builds, but also add an early return so as not to crash release builds.
1342
1343         * Plugins/WebPluginController.mm:
1344         (+[WebPluginController addPlugInView:]):
1345
1346 2014-03-06  Alexey Proskuryakov  <ap@apple.com>
1347
1348         [Mac] Don't perform a round-trip through WebProcess before interpreting key events
1349         https://bugs.webkit.org/show_bug.cgi?id=129812
1350
1351         Reviewed by Darin Adler.
1352
1353         * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleInputMethodKeydown):
1354         Added a FIXME. WebKit1/mac is the only port that uses this roundabout way to
1355         interpret events, so it would simplify code if we switched it to WebKit2/mac model.
1356
1357 2014-03-08  Simon Fraser  <simon.fraser@apple.com>
1358
1359         [iOS Wk2] Can't scroll after going back to page in page cache
1360         https://bugs.webkit.org/show_bug.cgi?id=129989
1361         <rdar://problem/16217588>
1362
1363         Reviewed by Dan Bernstein.
1364
1365         iOS has a special FrameLoader::forceLayoutWithoutRecalculatingStyle()
1366         function that is called instead of FrameView::forceLayout(). This was unimplemented
1367         for the WK2 FrameLoaderClient, so no layout was forced, with the result
1368         that the contentSize was never updated and scrolling was broken.
1369         
1370         Fix by renaming the client function to forceLayoutOnRestoreFromPageCache()
1371         and having it return a bool to say whether the default forceLayout()
1372         should be done. WK1 can then continue to have its custom behavior,
1373         and Wk2 will simply do a forceLayout().
1374         
1375         Also remove FrameLaoderClient::forceLayout(), which was never called.
1376
1377         * WebCoreSupport/WebFrameLoaderClient.h:
1378         * WebCoreSupport/WebFrameLoaderClient.mm:
1379         (WebFrameLoaderClient::forceLayoutOnRestoreFromPageCache):
1380
1381 2014-03-07  Anders Carlsson  <andersca@apple.com>
1382
1383         Add the remaining WebKit2 headers to WEBKIT2_HEADERS
1384         https://bugs.webkit.org/show_bug.cgi?id=129942
1385         <rdar://problem/15920020>
1386
1387         Reviewed by Tim Horton.
1388
1389         * MigrateHeaders.make:
1390
1391 2014-03-07  Anders Carlsson  <andersca@apple.com>
1392
1393         MigrateHeaders.make should remove C SPI includes from WebKit2 headers
1394         https://bugs.webkit.org/show_bug.cgi?id=129937
1395         <rdar://problem/15920020>
1396
1397         Reviewed by Tim Horton.
1398
1399         * MigrateHeaders.make:
1400         Add WKPreferences.h to WEBKIT2_HEADERS. 
1401         Add a sed rule that deletes all lines that start with a # and contain <WebKit/*Ref.h>.
1402
1403 2014-03-07  Anders Carlsson  <andersca@apple.com>
1404
1405         Make it possible to copy WebKit2 headers to WebKit.framework
1406         https://bugs.webkit.org/show_bug.cgi?id=129935
1407         <rdar://problem/15920020>
1408
1409         Reviewed by Dan Bernstein.
1410
1411         * MigrateHeaders.make:
1412         Gather a list of public and private WebKit2 headers and filter them against the WEBKIT2_HEADERS list.
1413         The matching headers are copied to the respective Headers or PrivateHeaders directories under WebKit.framework,
1414         and also have their #imports rewritten to reference WebKit instead of WebKit2.
1415
1416         * migrate-headers.sh: Added.
1417         Set up the WEBKIT2_FRAMEWORKS_DIR if needed.
1418
1419 2014-03-07  Anders Carlsson  <andersca@apple.com>
1420
1421         Fix a typo
1422         <rdar://problem/15920020>
1423
1424         Rubber-stamped by Dan Bernstein.
1425
1426         * Configurations/WebKit.xcconfig:
1427
1428 2014-03-07  Anders Carlsson  <andersca@apple.com>
1429
1430         Tweak the WebKit2 frameworks directories
1431         https://bugs.webkit.org/show_bug.cgi?id=129910
1432         <rdar://problem/15920020>
1433
1434         Reviewed by Dan Bernstein.
1435
1436         Use an SDK relative directory for production builds.
1437
1438         * Configurations/WebKit.xcconfig:
1439
1440 2014-03-07  Anders Carlsson  <andersca@apple.com>
1441
1442         Link WebKit.framework against WebKit2.framework and re-export all WebKit2 symbols
1443         https://bugs.webkit.org/show_bug.cgi?id=129901
1444         <rdar://problem/15920020>
1445
1446         Reviewed by Andreas Kling.
1447
1448         * Configurations/WebKit.xcconfig:
1449
1450 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
1451
1452         Web Inspector: Expose the console object in JSContexts to interact with Web Inspector
1453         https://bugs.webkit.org/show_bug.cgi?id=127944
1454
1455         Reviewed by Geoffrey Garen.
1456
1457         * WebCoreSupport/WebChromeClient.h:
1458         * WebCoreSupport/WebChromeClient.mm:
1459         Update namespaces.
1460
1461 2014-03-05  Eric Carlson  <eric.carlson@apple.com>
1462
1463         [iOS] Show external device name/type in placeholder
1464         https://bugs.webkit.org/show_bug.cgi?id=129723
1465
1466         Reviewed by Jer Noble.
1467
1468         * WebCoreSupport/WebSystemInterface.mm:
1469         (InitWebCoreSystemInterface):
1470
1471 2014-03-05  Simon Fraser  <simon.fraser@apple.com>
1472
1473         ObjC exception when dropping files into a WKView: drag and drop uses code from WebKit.framework
1474         https://bugs.webkit.org/show_bug.cgi?id=129752
1475
1476         Reviewed by Enrica Casucci.
1477         
1478         Call URLByCanonicalizingURL() which is implemented in WebCore.
1479
1480         * Misc/WebNSURLExtras.mm:
1481         (-[NSURL _webkit_canonicalize]):
1482
1483 2014-03-04  Zalan Bujtas  <zalan@apple.com>
1484
1485         Enable device pixel repaint rect tracking.
1486         https://bugs.webkit.org/show_bug.cgi?id=129712
1487
1488         Reviewed by Simon Fraser.
1489
1490         Tracked repaint rects are device pixel snapped now to support hiDPI test cases.
1491
1492         * WebView/WebView.mm:
1493         (-[WebView trackedRepaintRects]): Keep existing behavior for now.
1494
1495 2014-03-04  Simon Fraser  <simon.fraser@apple.com>
1496
1497         Allow iOS DumpRenderTree crashes to show application-specific information
1498         https://bugs.webkit.org/show_bug.cgi?id=129705
1499
1500         Reviewed by David Kilzer.
1501
1502         Make the WKSI function SetCrashReportApplicationSpecificInformation available
1503         in iOS simulator builds.
1504
1505         * WebCoreSupport/WebSystemInterface.mm:
1506         (InitWebCoreSystemInterface):
1507
1508 2014-03-04  Mark Hahnenberg  <mhahnenberg@apple.com>
1509
1510         Merge API shims and JSLock
1511         https://bugs.webkit.org/show_bug.cgi?id=129650
1512
1513         Reviewed by Mark Lam.
1514
1515         JSLock is now taking on all of APIEntryShim's responsibilities since there is never a reason 
1516         to take just the JSLock. Ditto for DropAllLocks and APICallbackShim.
1517
1518         * WebView/WebFrame.mm:
1519         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1520
1521 2014-03-02  Darin Adler  <darin@apple.com>
1522
1523         Sort Mac platform export files so they merge better
1524         https://bugs.webkit.org/show_bug.cgi?id=129581
1525
1526         Reviewed by Sam Weinig.
1527
1528         * WebKit.exp: Ran the new sort-export-file on this.
1529
1530 2014-03-02  Darin Adler  <darin@apple.com>
1531
1532         Change public text iterator API implementations to not depend on 16-bit character pointers
1533         https://bugs.webkit.org/show_bug.cgi?id=129566
1534
1535         Reviewed by Anders Carlsson.
1536
1537         * WebView/WebTextIterator.mm:
1538         (-[WebTextIterator initWithRange:]): Use make_unique instead of adoptPtr.
1539         (-[WebTextIterator advance]): Clear out the upconverted text since we are moving on to the
1540         next text.
1541         (-[WebTextIterator currentTextPointer]): Upconvert if we have 8-bit text.
1542         (-[WebTextIterator currentTextLength]): Call TextIterator::text().length() since we will
1543         probably be removing TextIterator::length eventually.
1544
1545 2014-03-01  Pratik Solanki  <psolanki@apple.com>
1546
1547         [iOS] selectionImageForcingBlackText should return autoreleased object
1548         https://bugs.webkit.org/show_bug.cgi?id=129437
1549         <rdar://problem/15810384>
1550
1551         Reviewed by Darin Adler.
1552
1553         * WebView/WebHTMLView.mm:
1554         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
1555
1556 2014-02-28  Dan Bernstein  <mitz@apple.com>
1557
1558         [Mac] Remove MailQuirksUserScript.js
1559         https://bugs.webkit.org/show_bug.cgi?id=129536
1560
1561         Reviewed by Andy Estes.
1562
1563         * Configurations/WebKit.xcconfig: Removed from EXCLUDED_SOURCE_FILE_NAMES_iphoneos.
1564         * Misc/MailQuirksUserScript.js: Removed. This file has been unused since r147447.
1565
1566 2014-02-28  Timothy Hatcher  <timothy@apple.com>
1567
1568         Properly handle when Test.html is not present in Production builds.
1569
1570         https://bugs.webkit.org/show_bug.cgi?id=129506
1571
1572         Reviewed by Joseph Pecoraro.
1573
1574         * WebCoreSupport/WebInspectorClient.mm:
1575         (-[WebInspectorWindowController inspectorTestPagePath]):
1576         (-[WebInspectorWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1577
1578 2014-02-27  Brian Burg  <bburg@apple.com>
1579
1580         Web Inspector: model tests should use a special Test.html inspector page
1581         https://bugs.webkit.org/show_bug.cgi?id=129190
1582
1583         Reviewed by Timothy Hatcher.
1584
1585         Support creating a separate test inspector page, based on the value of
1586         InspectorController::isUnderTest(). Modify the navigation policy to check
1587         the URL against both normal and test inspector pages.
1588
1589         * WebCoreSupport/WebInspectorClient.mm:
1590         (WebInspectorClient::openInspectorFrontend):
1591         (-[WebInspectorWindowController init]):
1592         (-[WebInspectorWindowController initWithInspectedWebView:isUnderTest:]):
1593         Move the initial navigation of the inspector page to this method, and change
1594         the URL based on the value of InspectorController::isUnderTest().
1595
1596         (-[WebInspectorWindowController inspectorTestPagePath]): Added.
1597         (-[WebInspectorWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1598
1599 2014-02-27  Pratik Solanki  <psolanki@apple.com>
1600
1601         Assertion failure at CachedResource.h:196: ASSERT(!m_purgeableData)
1602         https://bugs.webkit.org/show_bug.cgi?id=129349
1603         <rdar://problem/14871837>
1604
1605         Reviewed by Joseph Pecoraro.
1606
1607         The code for clearing out memory mapped notification callbacks is only needed when loading
1608         PDFs. And in such cases, we always have dataSourceDelegate object. So make this code
1609         conditional on its presence so that we don't trigger the assert for non-PDF main resources.
1610
1611         * WebView/WebDataSource.mm:
1612         (-[WebDataSource dealloc]):
1613
1614 2014-02-26  Andy Estes  <aestes@apple.com>
1615
1616         [iOS] Support network state notification using CPNetworkObserver
1617         https://bugs.webkit.org/show_bug.cgi?id=129358
1618
1619         Reviewed by Dan Bernstein.
1620
1621         * WebView/WebView.mm:
1622         (-[WebView _setNetworkStateIsOnline:]): Retained an empty
1623         implementation for binary compatibility for UIKit.
1624         (+[WebView _doNotStartObservingNetworkReachability]): Called
1625         Settings::setShouldOptOutOfNetworkStateObservation(true).
1626         * WebView/WebViewPrivate.h: Removed declaration of
1627         _setNetworkStateIsOnline: and declared
1628         _doNotStartObservingNetworkReachability.
1629
1630 2014-02-25  Anders Carlsson  <andersca@apple.com>
1631
1632         Get rid of VisitedLinkStrategy
1633         https://bugs.webkit.org/show_bug.cgi?id=129324
1634
1635         Reviewed by Dan Bernstein.
1636
1637         * WebCoreSupport/WebPlatformStrategies.h:
1638         * WebCoreSupport/WebPlatformStrategies.mm:
1639
1640 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
1641
1642         [CSS Grid Layout] Add ENABLE flag
1643         https://bugs.webkit.org/show_bug.cgi?id=129153
1644
1645         Reviewed by Simon Fraser.
1646
1647         Added ENABLE_CSS_GRID_LAYOUT feature flag.
1648
1649         * Configurations/FeatureDefines.xcconfig:
1650
1651 2014-02-24  Anders Carlsson  <andersca@apple.com>
1652
1653         Add WebViewGroup
1654         https://bugs.webkit.org/show_bug.cgi?id=129280
1655
1656         Reviewed by Dan Bernstein.
1657
1658         This is a first step towards getting rid of page groups in WebCore. The idea is that
1659         everything that is per page group in WebCore will be per page. In order to retain WebKit1 compatibility
1660         WebViewGroup is going to take over more and more responsibility from WebCore::PageGroup.
1661
1662         * WebCoreSupport/WebViewGroup.h: Added.
1663         * WebCoreSupport/WebViewGroup.mm: Added.
1664         (webViewGroups):
1665         (WebViewGroup::getOrCreate):
1666         (WebViewGroup::WebViewGroup):
1667         (WebViewGroup::~WebViewGroup):
1668         (WebViewGroup::addWebView):
1669         (WebViewGroup::removeWebView):
1670         * WebView/WebView.mm:
1671         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1672         (-[WebView _close]):
1673         (-[WebView setGroupName:]):
1674         * WebView/WebViewData.h:
1675         * WebView/WebViewData.mm:
1676
1677 2014-02-24  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1678
1679         Code cleanup: remove leftover ENABLE(WORKERS) macros and support.
1680         https://bugs.webkit.org/show_bug.cgi?id=129255
1681
1682         Reviewed by Csaba Osztrogonác.
1683
1684         ENABLE_WORKERS macro was removed in r159679.
1685         Support is now also removed from xcconfig files.
1686
1687         * Configurations/FeatureDefines.xcconfig:
1688
1689 2014-02-24  David Kilzer  <ddkilzer@apple.com>
1690
1691         Remove redundant setting in FeatureDefines.xcconfig
1692
1693         * Configurations/FeatureDefines.xcconfig:
1694
1695 2014-02-23  Sam Weinig  <sam@webkit.org>
1696
1697         Update FeatureDefines.xcconfig
1698
1699         Rubber-stamped by Anders Carlsson.
1700
1701         * Configurations/FeatureDefines.xcconfig:
1702
1703 2014-02-23  Sam Weinig  <sam@webkit.org>
1704
1705         Move telephone number detection behind its own ENABLE macro
1706         https://bugs.webkit.org/show_bug.cgi?id=129236
1707
1708         Reviewed by Dean Jackson.
1709
1710         * Configurations/FeatureDefines.xcconfig:
1711         Add ENABLE_TELEPHONE_NUMBER_DETECTION.
1712
1713 2014-02-21  Sam Weinig  <sam@webkit.org>
1714
1715         Expose phase and momentum phase as SPI on DOMWheelEvent
1716         <rdar://problem/16110871>
1717         https://bugs.webkit.org/show_bug.cgi?id=129184
1718
1719         Reviewed by Anders Carlsson.
1720
1721         * DOM/WebDOMOperations.mm:
1722         (toNSEventPhase):
1723         (-[DOMWheelEvent _phase]):
1724         (-[DOMWheelEvent _momentumPhase]):
1725         * DOM/WebDOMOperationsPrivate.h:
1726         Expose _phase and _momentumPhase as SPI.
1727
1728         * MigrateHeaders.make:
1729         Make DOMWheelEventInternal.h to WebKit.
1730
1731 2014-02-22  David Kilzer  <ddkilzer@apple.com>
1732
1733         Revert r164434 since it actually broke ASan builds
1734         <http://webkit.org/b/128871>
1735
1736         * Configurations/WebKit.xcconfig: This caused -asan-blacklist to
1737         be included twice on every compiler command, which caused clang
1738         to error out.
1739
1740 2014-02-21  Brent Fulgham  <bfulgham@apple.com>
1741
1742         Extend media support for WebVTT sources
1743         https://bugs.webkit.org/show_bug.cgi?id=129156
1744
1745         Reviewed by Eric Carlson.
1746
1747         * Configurations/FeatureDefines.xcconfig: Add new feature define for AVF_CAPTIONS
1748
1749 2014-02-20  Brady Eidson  <beidson@apple.com>
1750
1751         Add very basic image control rendering
1752         https://bugs.webkit.org/show_bug.cgi?id=129080
1753
1754         Reviewed by Tim Horton.
1755
1756         Expose the imageControlsEnabled setting to WebKit1 so DRT can use it.
1757
1758         * WebView/WebPreferenceKeysPrivate.h:
1759         * WebView/WebPreferences.mm:
1760         (+[WebPreferences initialize]):
1761         (-[WebPreferences imageControlsEnabled]):
1762         (-[WebPreferences setImageControlsEnabled:]):
1763         * WebView/WebPreferencesPrivate.h:
1764
1765         * WebView/WebView.mm:
1766         (-[WebView _preferencesChanged:]):
1767
1768 2014-02-20  David Kilzer  <ddkilzer@apple.com>
1769
1770         [ASan] WebKit1 sources are not compiled using ASAN macros
1771         <http://webkit.org/b/128871>
1772
1773         Reviewed by Brent Fulgham.
1774
1775         * Configurations/WebKit.xcconfig: Use $inherited for
1776         OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS so that ASAN_OTHER_CFLAGS
1777         and ASAN_OTHER_CPLUSPLUSFLAGS are inherited from
1778         DebugRelease.xcconfig.
1779
1780 2014-02-19  Brady Eidson  <beidson@apple.com>
1781
1782         Add FeatureDefines for image controls
1783         https://bugs.webkit.org/show_bug.cgi?id=129022
1784
1785         Reviewed by Jer Noble.
1786
1787         * Configurations/FeatureDefines.xcconfig:
1788
1789 2014-02-18  Sam Weinig  <sam@webkit.org>
1790
1791         Simplify HTML tokenizer parameterization down to what is used
1792         https://bugs.webkit.org/show_bug.cgi?id=128977
1793
1794         Reviewed by Alexey Proskuryakov.
1795
1796         Remove unused _setCustomHTMLTokenizerTimeDelay and _setCustomHTMLTokenizerChunkSize SPI.
1797
1798         * WebView/WebView.mm:
1799         * WebView/WebViewPrivate.h:
1800
1801 2014-02-17  Anders Carlsson  <andersca@apple.com>
1802
1803         Remove view source code
1804         https://bugs.webkit.org/show_bug.cgi?id=127233
1805
1806         Reviewed by Antti Koivisto.
1807
1808         * WebView/WebView.mm:
1809         * WebView/WebViewPrivate.h:
1810
1811 2014-02-17  Sergio Correia  <sergio.correia@openbossa.org>
1812
1813         Replace uses of PassOwnPtr/OwnPtr with std::unique_ptr in WebCore/inspector
1814         https://bugs.webkit.org/show_bug.cgi?id=128681
1815
1816         Reviewed by Timothy Hatcher.
1817
1818         Another step towards getting rid of PassOwnPtr/OwnPtr, now targeting
1819         WebCore/inspector/*. Besides files in there, a few other files in
1820         JavaScriptCore/inspector, WebKit/, WebKit2/WebProcess/WebCoreSupport/
1821         and WebCore/testing were touched.
1822
1823         * WebCoreSupport/WebInspectorClient.h:
1824         * WebCoreSupport/WebInspectorClient.mm:
1825
1826 2014-02-15  Alexey Proskuryakov  <ap@apple.com>
1827
1828         [Mac] Remove WebSerializedJSValue SPI
1829         https://bugs.webkit.org/show_bug.cgi?id=128720
1830
1831         Reviewed by Anders Carlsson.
1832
1833         * WebKit.exp:
1834         * WebView/WebSerializedJSValue.h: Removed.
1835         * WebView/WebSerializedJSValue.mm: Removed.
1836         * WebView/WebSerializedJSValuePrivate.h: Removed.
1837
1838 2014-02-15  Alexey Proskuryakov  <ap@apple.com>
1839
1840         [Mac] All WebKit clients should encrypt WebCrypto keys automatically
1841         https://bugs.webkit.org/show_bug.cgi?id=128852
1842
1843         Reviewed by Oliver Hunt.
1844
1845         * WebCoreSupport/WebChromeClient.mm:
1846         (WebChromeClient::wrapCryptoKey):
1847         (WebChromeClient::unwrapCryptoKey):
1848         Call the default implementation if key is not provided by a client.
1849
1850 2014-02-14  Anders Carlsson  <andersca@apple.com>
1851
1852         Control tints don't update inside WebViews
1853         https://bugs.webkit.org/show_bug.cgi?id=128862
1854
1855         Reviewed by Ryosuke Niwa.
1856
1857         * WebView/WebView.mm:
1858         (-[WebView _windowChangedKeyState]):
1859         Call [super _windowChangedKeyState].
1860
1861 2014-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
1862
1863         During a copy, position:fixed gets converted to position:absolute even if only part of the document is selected
1864         https://bugs.webkit.org/show_bug.cgi?id=128688
1865
1866         Reviewed by Ryosuke Niwa.
1867
1868         Renames the ConvertPositionStyleOnCopy setting to ShouldConvertPositionStyleOnCopy
1869
1870         * WebView/WebPreferenceKeysPrivate.h:
1871         * WebView/WebPreferences.mm:
1872         (-[WebPreferences shouldConvertPositionStyleOnCopy]):
1873         (-[WebPreferences setShouldConvertPositionStyleOnCopy:]):
1874         * WebView/WebPreferencesPrivate.h:
1875         * WebView/WebView.mm:
1876         (-[WebView _preferencesChanged:]):
1877
1878 2014-02-13  Alexey Proskuryakov  <ap@apple.com>
1879
1880         [Mac] Add a WebKit1 SPI to get WebCrypto master key from a client
1881         https://bugs.webkit.org/show_bug.cgi?id=128725
1882
1883         Reviewed by Anders Carlsson.
1884
1885         * WebCoreSupport/WebChromeClient.mm:
1886         (WebChromeClient::wrapCryptoKey):
1887         (WebChromeClient::unwrapCryptoKey):
1888         * WebView/WebUIDelegatePrivate.h:
1889         Looks like UIDelegate is the closest we have to a reasonable place.
1890
1891 2014-02-13  Dan Bernstein  <mitz@apple.com>
1892
1893         iOS build fix.
1894
1895         * WebView/WebView.mm:
1896         (+[WebView registerForMemoryNotifications]):
1897
1898 2014-02-12  Alexey Proskuryakov  <ap@apple.com>
1899
1900         Wrap WebCrypto keys in SerializedScriptValue
1901         https://bugs.webkit.org/show_bug.cgi?id=128680
1902
1903         Reviewed by Anders Carlsson.
1904
1905         Retrieve a master key (placeholder code for now), and use it to wrap key data.
1906
1907         * WebCoreSupport/WebChromeClient.mm:
1908         (WebChromeClient::wrapCryptoKey):
1909         (WebChromeClient::unwrapCryptoKey):
1910
1911 2014-02-11  Ryosuke Niwa  <rniwa@webkit.org>
1912
1913         Frame::rectForSelection shouldn't instantiate FrameSelection
1914         https://bugs.webkit.org/show_bug.cgi?id=128587
1915
1916         Reviewed by Enrica Casucci.
1917
1918         * WebCoreSupport/WebEditorClient.h:
1919         * WebCoreSupport/WebEditorClient.mm:
1920         (WebEditorClient::WebEditorClient):
1921         (WebEditorClient::respondToChangedSelection):
1922
1923 2014-02-10  Myles C. Maxfield  <mmaxfield@apple.com>
1924
1925         Convert position:sticky and position:fixed properties to position:static and position:absolute upon copy
1926         https://bugs.webkit.org/show_bug.cgi?id=128194
1927
1928         Reviewed by Simon Fraser.
1929
1930         * WebView/WebPreferenceKeysPrivate.h:
1931         * WebView/WebPreferences.mm:
1932         (-[WebPreferences convertPositionStyleOnCopy]):
1933         (-[WebPreferences setConvertPositionStyleOnCopy:]):
1934         * WebView/WebPreferencesPrivate.h: Opt-in to new behavior
1935         * WebView/WebView.mm:
1936         (-[WebView _preferencesChanged:]):
1937
1938 2014-02-11  Andy Estes  <aestes@apple.com>
1939
1940         [Mac] connection:willStopBufferingData: no longer exists in NSURLConnectionDelegate
1941         https://bugs.webkit.org/show_bug.cgi?id=128583
1942
1943         Reviewed by Anders Carlsson.
1944
1945         The delegate method was removed in Snow Leopard.
1946
1947         * Misc/WebDownload.mm:
1948
1949 2014-02-11  Alexey Proskuryakov  <ap@apple.com>
1950
1951         iOS build fix.
1952
1953         * WebCoreSupport/WebChromeClient.mm: Fixed incorrectly nested ifdefs.
1954
1955 2014-02-10  Alexey Proskuryakov  <ap@apple.com>
1956
1957         Add hooks for wrapping CryptoKeys in SerializedScriptValue
1958         https://bugs.webkit.org/show_bug.cgi?id=128567
1959
1960         Reviewed by Anders Carlsson.
1961
1962         * WebCoreSupport/WebChromeClient.h:
1963         * WebCoreSupport/WebChromeClient.mm:
1964         (WebChromeClient::wrapCryptoKey):
1965         (WebChromeClient::unwrapCryptoKey):
1966         Dummy implementation, to be filled in later.
1967
1968 2014-02-08  Ryosuke Niwa  <rniwa@webkit.org>
1969
1970         Cleanup the interface of FrameSelection
1971         https://bugs.webkit.org/show_bug.cgi?id=128481
1972
1973         Reviewed by Andreas Kling.
1974
1975         * WebView/WebHTMLView.mm:
1976         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
1977         (-[WebHTMLView selectionRect]):
1978         (-[WebHTMLView selectionImageRect]):
1979
1980 2014-02-08  Dan Bernstein  <mitz@apple.com>
1981
1982         Remove use of PLATFORM(MAC) from WebKit/mac
1983         https://bugs.webkit.org/show_bug.cgi?id=128476
1984
1985         Reviewed by Anders Carlsson.
1986
1987         * WebCoreSupport/WebFrameLoaderClient.h:
1988         * WebCoreSupport/WebSystemInterface.mm:
1989         (InitWebCoreSystemInterface):
1990
1991 2014-02-08  Dan Bernstein  <mitz@apple.com>
1992
1993         Remove client-drawn highlights (-webkit-highlight, WebHTMLHighlighter)
1994         https://bugs.webkit.org/show_bug.cgi?id=128456
1995
1996         Reviewed by Anders Carlsson.
1997
1998         * WebCoreSupport/WebChromeClient.h:
1999         * WebCoreSupport/WebChromeClient.mm: Removed customHighlightRect and paintCustomHighlight.
2000         * WebView/WebHTMLView.mm:
2001         (-[WebHTMLViewPrivate dealloc]): Removed highlighters ivar.
2002         (-[WebHTMLViewPrivate clear]): Ditto.
2003         * WebView/WebHTMLViewInternal.h: Removed declaration.
2004         * WebView/WebHTMLViewPrivate.h: Removed WebHTMLHighlighter protocol and method declarations.
2005
2006 2014-02-08  Dan Bernstein  <mitz@apple.com>
2007
2008         iOS build fix after r163712.
2009
2010         * WebCoreSupport/WebEditorClient.h:
2011         * WebCoreSupport/WebEditorClient.mm:
2012
2013 2014-02-08  Darin Adler  <darin@apple.com>
2014
2015         Change TextIterator to use StringView, preparing to wean it from deprecatedCharacters
2016         https://bugs.webkit.org/show_bug.cgi?id=128233
2017
2018         Reviewed by Anders Carlsson.
2019
2020         * WebCoreSupport/WebEditorClient.h: Made most data members private. Moved inlines
2021         for iOS out of the class definition. Fixed formatting. Added missing virtual keyword.
2022         Changed interfaces to use StringView.
2023
2024         * WebCoreSupport/WebEditorClient.mm:
2025         (WebEditorClient::checkTextOfParagraph): Use the new StringView::createNSStringWithoutCopying
2026         function instead of a similar function that was local in this file.
2027         (WebEditorClient::ignoreWordInSpellDocument): Tweaked formatting.
2028         (WebEditorClient::checkSpellingOfString): Changed to take a StringView.
2029         (WebEditorClient::checkGrammarOfString): Ditto.
2030
2031         * WebView/WebTextIterator.mm:
2032         (-[WebTextIterator currentTextPointer]): Call TextIterator::deprecatedTextIteratorCharacters.
2033         (-[WebTextIterator currentText]): Convert a the text to an NSString with TextIterator::text
2034         instead of with TextIterator::characters/length.
2035
2036 2014-02-07  Gavin Barraclough  <barraclough@apple.com>
2037
2038         Remove isInitialState flag from Page::setViewState
2039         https://bugs.webkit.org/show_bug.cgi?id=128428
2040
2041         Reviewed by Sam Weinig.
2042
2043         * WebView/WebView.mm:
2044         (-[WebView _commonInitializationWithFrameName:groupName:]):
2045         (-[WebView _updateVisibilityState]):
2046         (-[WebView _setIsVisible:]):
2047         (-[WebView _setVisibilityState:isInitialState:]):
2048         (-[WebView _windowWillOrderOnScreen:]):
2049         (-[WebView _windowWillOrderOffScreen:]):
2050             - don't pass isInitialState to setViewState.
2051
2052 2014-02-06  Filip Pizlo  <fpizlo@apple.com>
2053
2054         More FTL build scaffolding
2055         https://bugs.webkit.org/show_bug.cgi?id=128330
2056
2057         Reviewed by Geoffrey Garen.
2058
2059         * Configurations/FeatureDefines.xcconfig:
2060
2061 2014-02-07  Dan Bernstein  <mitz@apple.com>
2062
2063         iOS build fix.
2064
2065         * Misc/WebElementDictionary.mm:
2066         (+[WebElementDictionary initializeLookupTable]):
2067         (-[WebElementDictionary _image]):
2068         (-[WebElementDictionary _imageRect]):
2069
2070 2014-02-06  Joseph Pecoraro  <pecoraro@apple.com>
2071
2072         Web Inspector: Add Console support to JSContext Inspection
2073         https://bugs.webkit.org/show_bug.cgi?id=127941
2074
2075         Reviewed by Geoffrey Garen.
2076
2077         * WebCoreSupport/WebChromeClient.h:
2078         * WebCoreSupport/WebChromeClient.mm:
2079         (stringForMessageSource):
2080         (stringForMessageLevel):
2081         (WebChromeClient::addMessageToConsole):
2082
2083 2014-02-05  Gavin Barraclough  <barraclough@apple.com>
2084
2085         Change Page, FocusController to use ViewState
2086         https://bugs.webkit.org/show_bug.cgi?id=126533
2087
2088         Reviewed by Tim Horton.
2089
2090         These classes currently maintain a set of separate fields to represent the view state;
2091         combine these into a single field, and allow WebPage to send the combined update rather
2092         than individual changes.
2093
2094         Maintain existing interface for WebKit1 clients.
2095
2096         * WebView/WebView.mm:
2097         (-[WebView _windowWillOrderOnScreen:]):
2098         (-[WebView _windowWillOrderOffScreen:]):
2099             - remove calls to FocusController::setContentIsVisible, these are redundant
2100               (this is handled when page visibility is set).
2101
2102 2014-02-05  Andreas Kling  <akling@apple.com>
2103
2104         Remove ENABLE(DIRECTORY_UPLOAD).
2105         <https://webkit.org/b/128275>
2106
2107         Rubber-stamped by Ryosuke Niwa.
2108
2109         * Configurations/FeatureDefines.xcconfig:
2110
2111 2014-02-05  Csaba Osztrogonác  <ossy@webkit.org>
2112
2113         Remove ENABLE(SVG) guards
2114         https://bugs.webkit.org/show_bug.cgi?id=127991
2115
2116         Reviewed by Sam Weinig.
2117
2118         * Configurations/FeatureDefines.xcconfig:
2119
2120 2014-02-04  Andreas Kling  <akling@apple.com>
2121
2122         Remove <iframe seamless> support.
2123         <https://webkit.org/b/128213>
2124
2125         Rubber-stamped by Antti Koivisto.
2126
2127         * Configurations/FeatureDefines.xcconfig:
2128         * WebView/WebPreferenceKeysPrivate.h:
2129         * WebView/WebPreferences.mm:
2130         * WebView/WebPreferencesPrivate.h:
2131         * WebView/WebView.mm:
2132         (-[WebView _preferencesChanged:]):
2133
2134 2014-02-03  Dean Jackson  <dino@apple.com>
2135
2136         Feature flag for shape-inside
2137         https://bugs.webkit.org/show_bug.cgi?id=128001
2138
2139         Reviewed by Simon Fraser.
2140
2141         Add CSS_SHAPE_INSIDE flag.
2142
2143         * Configurations/FeatureDefines.xcconfig:
2144
2145 2014-01-31  Ryosuke Niwa  <rniwa@webkit.org>
2146
2147         Remove inline member functions of FrameSelection that access m_selection
2148         https://bugs.webkit.org/show_bug.cgi?id=127986
2149
2150         Reviewed by Enrica Casucci.
2151
2152         * WebView/WebFrame.mm:
2153         (-[WebFrame hasEditableSelection]):
2154         (-[WebFrame selectionAffinity]):
2155         (-[WebFrame getDictationResultRanges:andMetadatas:]):
2156         (-[WebFrame hasRichlyEditableSelection]):
2157         (-[WebFrame focusedNodeHasContent]):
2158         * WebView/WebHTMLView.mm:
2159         (-[WebHTMLView readSelectionFromPasteboard:]):
2160         (-[WebHTMLView _hasSelection]):
2161         (-[WebHTMLView _hasSelectionOrInsertionPoint]):
2162         (-[WebHTMLView _hasInsertionPoint]):
2163         (-[WebHTMLView _isEditable]):
2164         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
2165         (-[WebHTMLView maintainsInactiveSelection]):
2166         (isTextInput):
2167         (isInPasswordField):
2168         * WebView/WebView.mm:
2169         (-[WebView selectionAffinity]):
2170
2171 2014-01-31  Tim Horton  <timothy_horton@apple.com>
2172
2173         [wk2] PlatformCALayerRemoteCustom doesn't work on iOS
2174         https://bugs.webkit.org/show_bug.cgi?id=128025
2175         <rdar://problem/15950271>
2176
2177         Reviewed by Simon Fraser.
2178
2179         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2180         (-[WebHostedNetscapePluginView windowHostsLayersInWindowServer]):
2181         Use the new macro name.
2182
2183 2014-01-30  David Kilzer  <ddkilzer@apple.com>
2184
2185         Add security-checked cast for WebCore::CachedImage
2186         <http://webkit.org/b/127967>
2187
2188         Reviewed by Darin Adler.
2189
2190         * Misc/WebCache.mm:
2191         (+[WebCache imageForURL:]):
2192         - Use WebCore::toCachedImage().
2193
2194 2014-01-30  David Kilzer  <ddkilzer@apple.com>
2195
2196         De-virtual-ize CachedResource::isImage()
2197         <http://webkit.org/b/127936>
2198
2199         Reviewed by Andreas Kling.
2200
2201         Also replace explicit type() checks with isImage().
2202
2203         * Misc/WebCache.mm:
2204         (+[WebCache imageForURL:]): Use !isImage().
2205
2206 2014-01-30  Beth Dakin  <bdakin@apple.com>
2207
2208         https://bugs.webkit.org/show_bug.cgi?id=127371
2209         Explore new API that could be used to help build infinitely scrolling websites
2210         -and corresponding-
2211         <rdar://problem/15244768>
2212
2213         Reviewed by Sam Weinig.
2214
2215         FrameView::scrollPositionChangedViaPlatformWidget() now take two parameters 
2216         representing the old scroll position and the new position.
2217         * WebView/WebHTMLView.mm:
2218         (-[WebHTMLView _frameOrBoundsChanged]):
2219
2220 2014-01-30  Andrei Bucur  <abucur@adobe.com>
2221
2222         Remove the ACCELERATED_COMPOSITING flag
2223         https://bugs.webkit.org/show_bug.cgi?id=127833
2224
2225         Reviewed by Antti Koivisto.
2226
2227         Remove the USE(ACCELERATED_COMPOSITING) conditionals from the code base and make AC
2228         mandatory.
2229
2230         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2231         (-[WebHostedNetscapePluginView createPlugin]):
2232         (-[WebHostedNetscapePluginView createPluginLayer]):
2233         * Plugins/WebNetscapePluginView.mm:
2234         (-[WebNetscapePluginView createPlugin]):
2235         (-[WebNetscapePluginView getVariable:value:]):
2236         * Plugins/WebPluginController.mm:
2237         (-[WebPluginController superlayerForPluginView:]):
2238         * WebCoreSupport/WebChromeClient.h:
2239         (WebChromeClient::allowedCompositingTriggers):
2240         * WebCoreSupport/WebChromeClient.mm:
2241         * WebCoreSupport/WebFrameLoaderClient.mm:
2242         (PluginWidgetIOS::detachPluginLayer):
2243         (NetscapePluginWidget::platformLayer):
2244         * WebView/WebClipView.mm:
2245         (-[WebClipView _immediateScrollToPoint:]):
2246         * WebView/WebHTMLView.mm:
2247         (setNeedsDisplayInRect):
2248         (+[WebHTMLViewPrivate initialize]):
2249         (-[WebHTMLViewPrivate clear]):
2250         (-[WebHTMLView _setAsideSubviews]):
2251         (-[WebHTMLView hitTest:]):
2252         (-[WebHTMLView _isUsingAcceleratedCompositing]):
2253         (-[WebHTMLView _compositingLayersHostingView]):
2254         (-[WebHTMLView viewDidMoveToSuperview]):
2255         (-[WebHTMLView drawRect:]):
2256         * WebView/WebHTMLViewInternal.h:
2257         * WebView/WebRenderLayer.mm:
2258         (+[WebRenderLayer compositingInfoForLayer:]):
2259         * WebView/WebView.mm:
2260         (-[WebView _close]):
2261         (-[WebView _setMediaLayer:forPluginView:]):
2262         (-[WebView _postsAcceleratedCompositingNotifications]):
2263         (-[WebView _setPostsAcceleratedCompositingNotifications:]):
2264         (-[WebView _isUsingAcceleratedCompositing]):
2265         (-[WebView _isSoftwareRenderable]):
2266         (-[WebView close]):
2267         * WebView/WebViewData.h:
2268         * WebView/WebViewData.mm:
2269         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
2270         * WebView/WebViewInternal.h:
2271
2272 2014-01-29  Csaba Osztrogonác  <ossy@webkit.org>
2273
2274         Remove ENABLE(JAVASCRIPT_DEBUGGER) leftovers
2275         https://bugs.webkit.org/show_bug.cgi?id=127845
2276
2277         Reviewed by Joseph Pecoraro.
2278
2279         * Configurations/FeatureDefines.xcconfig:
2280
2281 2014-01-29  Dan Bernstein  <mitz@apple.com>
2282
2283         Moved linking against common frameworks and a library from the .xcconfig file into the target.
2284
2285         Reviewed by Tim Horton.
2286
2287         * Configurations/WebKit.xcconfig:
2288
2289 2014-01-29  Ryosuke Niwa  <rniwa@webkit.org>
2290
2291         checkTextOfParagraph releases NSString twice
2292         https://bugs.webkit.org/show_bug.cgi?id=127881
2293         <rdar://problem/15937446>
2294
2295         Reviewed by Anders Carlsson.
2296
2297         textString is released once by an explicit call to release and again by it going out of scope.
2298         Don't do the explicit release.
2299
2300         The bug was spotted by Sam Weinig.
2301
2302         * WebCoreSupport/WebEditorClient.mm:
2303         (WebEditorClient::checkTextOfParagraph):
2304
2305 2014-01-29  Anders Carlsson  <andersca@apple.com>
2306
2307         Fix build.
2308
2309         * WebView/WebPDFView.mm:
2310         (_applicationInfoForMIMEType):
2311
2312 2014-01-28  Mark Rowe  <mrowe@apple.com>
2313
2314         <https://webkit.org/b/127767> Disable some deprecation warnings to fix the build.
2315
2316         Reviewed by Ryosuke Niwa.
2317
2318         * WebCoreSupport/PopupMenuMac.mm:
2319         (PopupMenuMac::populate):
2320
2321 2014-01-27  Joseph Pecoraro  <pecoraro@apple.com>
2322
2323         WebKit1: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
2324         https://bugs.webkit.org/show_bug.cgi?id=127664
2325
2326         Reviewed by Darin Adler.
2327
2328         * Configurations/Base.xcconfig:
2329         * History/BinaryPropertyList.cpp:
2330         (BinaryPropertyListSerializer::appendObjectReference):
2331         (BinaryPropertyListSerializer::startObject):
2332         (BinaryPropertyListSerializer::addAggregateObjectReference):
2333         * WebView/WebPDFView.mm:
2334         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2335
2336 2014-01-27  Andy Estes  <aestes@apple.com>
2337
2338         Scrub WebKit API headers of WTF macros
2339         https://bugs.webkit.org/show_bug.cgi?id=127706
2340
2341         Reviewed by David Kilzer.
2342
2343         * Configurations/FeatureDefines.xcconfig: Added ENABLE_INSPECTOR.
2344         * WebView/WebPreferenceKeysPrivate.h: Changed ENABLE(REMOTE_INSPECTOR)
2345         to !defined(ENABLE_REMOTE_INSPECTOR) || ENABLE_REMOTE_INSPECTOR. We are
2346         in a TARGET_OS_IPHONE block, and ENABLE_REMOTE_INSPECTOR is enabled by
2347         default on iOS, so include this block unless the feature is explicitly
2348         disabled.
2349         * postprocess-headers.sh: Stopped processing ENABLE_IOS_TOUCH_EVENTS
2350         and ENABLE_IOS_GESTURE_EVENTS. These are now defined in DOMEvents.h.
2351
2352 2014-01-27  Tim Horton  <timothy_horton@apple.com>
2353
2354         Another iOS build fix.
2355
2356         * Misc/WebElementDictionary.mm:
2357         (-[WebElementDictionary _image]):
2358         We were apparently depending on Image::getNSImage() being defined
2359         (yet always returning nullptr) on iOS.
2360
2361 2014-01-26  David Kilzer  <ddkilzer@apple.com>
2362
2363         Remove duplicate settings for ENABLE(DISK_IMAGE_CACHE)
2364         <http://webkit.org/b/127669>
2365
2366         Reviewed by Joseph Pecoraro.
2367
2368         * WebView/WebPreferences.mm:
2369         (+[WebPreferences initialize]): Remove duplicate code.
2370
2371 2014-01-24  Andy Estes  <aestes@apple.com>
2372
2373         [iOS] Upstream changes in Tools/DumpRenderTree
2374         https://bugs.webkit.org/show_bug.cgi?id=127412
2375
2376         Reviewed by Simon Fraser.
2377
2378         * Misc/WebCoreStatistics.h: Included CGContext.h.
2379
2380 2014-01-26  Anders Carlsson  <andersca@apple.com>
2381
2382         Move history item visit count handling to WebKit
2383         https://bugs.webkit.org/show_bug.cgi?id=127659
2384
2385         Reviewed by Dan Bernstein.
2386
2387         Move code to deal with visit count and visit dates here from WebCore.
2388
2389         * History/HistoryPropertyList.mm:
2390         (HistoryPropertyListWriter::writeHistoryItem):
2391         * History/WebHistoryItem.mm:
2392         (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
2393         (-[WebHistoryItem copyWithZone:]):
2394         (-[WebHistoryItem lastVisitedTimeInterval]):
2395         (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
2396         (-[WebHistoryItem setVisitCount:]):
2397         (-[WebHistoryItem _mergeAutoCompleteHints:]):
2398         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2399         (-[WebHistoryItem _visitedWithTitle:increaseVisitCount:]):
2400         (-[WebHistoryItem _recordInitialVisit]):
2401         (timeToDay):
2402         (-[WebHistoryItem _padDailyCountsForNewVisit:]):
2403         (-[WebHistoryItem _collapseDailyVisitsToWeekly]):
2404         (-[WebHistoryItem _recordVisitAtTime:increaseVisitCount:]):
2405         (-[WebHistoryItem _setLastVisitedTimeInterval:]):
2406         * History/WebHistoryItemInternal.h:
2407
2408 2014-01-26  Anders Carlsson  <andersca@apple.com>
2409
2410         Fix build.
2411
2412         Pass a WebHistoryItem to writeHistoryItem so we can extract _lastVisitWasHTTPNonGet from it.
2413
2414         * History/HistoryPropertyList.h:
2415         * History/HistoryPropertyList.mm:
2416         (HistoryPropertyListWriter::HistoryPropertyListWriter):
2417         (HistoryPropertyListWriter::buffer):
2418         (HistoryPropertyListWriter::releaseData):
2419         (HistoryPropertyListWriter::writeObjects):
2420         (HistoryPropertyListWriter::writeHistoryItem):
2421         * History/WebHistory.mm:
2422         (WebHistoryWriter::writeHistoryItems):
2423         * History/WebHistoryItem.mm:
2424
2425 2014-01-26  Anders Carlsson  <andersca@apple.com>
2426
2427         Move lastVisitWasHTTPNonGet out to WebHistoryItem
2428         https://bugs.webkit.org/show_bug.cgi?id=127657
2429
2430         Reviewed by Dan Bernstein.
2431
2432         Keep track of _lastVisitWasHTTPNonGet inside WebHistoryItem.
2433
2434         * History/WebHistory.mm:
2435         (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
2436         Set entry->_private->_lastVisitWasHTTPNonGet.
2437
2438         * History/WebHistoryItem.h:
2439         Change @private to @package so we can get at WebHistoryItemPrivate from WebHistory.
2440
2441         * History/WebHistoryItem.mm:
2442         (-[WebHistoryItem copyWithZone:]):
2443         Assign _private->_lastVisitWasHTTPNonGet.
2444
2445         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2446         Set _private->_lastVisitWasHTTPNonGet.
2447
2448         * History/WebHistoryItemInternal.h:
2449         Move WebHistoryItemPrivate interface here.
2450
2451 2014-01-26  Anders Carlsson  <andersca@apple.com>
2452
2453         Turn WebHistoryItemPrivate back into a real Objective-C class
2454         https://bugs.webkit.org/show_bug.cgi?id=127653
2455
2456         Reviewed by Sam Weinig.
2457
2458         This is a first step towards moving some history specific code from WebCore::HistoryItem back into WebKit.
2459
2460         * History/WebHistoryItem.mm:
2461         (-[WebHistoryItem dealloc]):
2462         (-[WebHistoryItem finalize]):
2463         (-[WebHistoryItem initWithWebCoreHistoryItem:]):
2464
2465 2014-01-25  Sam Weinig  <sam@webkit.org>
2466
2467         Remove unused support for DRAGGABLE_REGION
2468         https://bugs.webkit.org/show_bug.cgi?id=127642
2469
2470         Reviewed by Simon Fraser.
2471
2472         * Configurations/FeatureDefines.xcconfig:
2473
2474 2014-01-25  Anders Carlsson  <andersca@apple.com>
2475
2476         Remove an unused FrameLoaderClient function
2477         https://bugs.webkit.org/show_bug.cgi?id=127628
2478
2479         Reviewed by Andreas Kling.
2480
2481         * WebCoreSupport/WebFrameLoaderClient.h:
2482         * WebCoreSupport/WebFrameLoaderClient.mm:
2483
2484 2014-01-25  Anders Carlsson  <andersca@apple.com>
2485
2486         Build fix.
2487
2488         * WebView/WebViewData.h:
2489
2490 2014-01-25  Anders Carlsson  <andersca@apple.com>
2491
2492         Get rid of BackForwardController::isActive()
2493         https://bugs.webkit.org/show_bug.cgi?id=127604
2494
2495         Reviewed by Sam Weinig.
2496
2497         * WebCoreSupport/WebFrameLoaderClient.mm:
2498         (WebFrameLoaderClient::canCachePage):
2499         Move isActive logic here.
2500
2501 2014-01-24  Anders Carlsson  <andersca@apple.com>
2502
2503         Remove back/forward list related functions from Page
2504         https://bugs.webkit.org/show_bug.cgi?id=127596
2505
2506         Reviewed by Andreas Kling.
2507
2508         * WebView/WebFrameView.mm:
2509         (-[WebFrameView keyDown:keyDown:]):
2510         * WebView/WebView.mm:
2511         (-[WebView _loadBackForwardListFromOtherView:]):
2512         (-[WebView initWithCoder:]):
2513         (-[WebView encodeWithCoder:]):
2514         (-[WebView backForwardList]):
2515         (-[WebView setMaintainsBackForwardList:]):
2516         (-[WebView goBack]):
2517         (-[WebView goForward]):
2518         (-[WebView canGoBack]):
2519         (-[WebView canGoForward]):
2520
2521 2014-01-24  Anders Carlsson  <andersca@apple.com>
2522
2523         Get rid of monotonicallyIncreasingTimeMS and start using std::chrono instead
2524         https://bugs.webkit.org/show_bug.cgi?id=127571
2525
2526         Reviewed by Antti Koivisto.
2527
2528         * WebView/WebView.mm:
2529         (-[WebView _preferencesChanged:]):
2530         Convert the layout interval to std::chrono::milliseconds.
2531
2532 2014-01-24  Zan Dobersek  <zdobersek@igalia.com>
2533
2534         Move HistoryItem to std::unique_ptr
2535         https://bugs.webkit.org/show_bug.cgi?id=127275
2536
2537         Reviewed by Darin Adler.
2538
2539         * History/WebHistoryItem.mm: The Vector object that's passed to HistoryItem::setRedirectURLs
2540         should now be handled by std::unique_ptr and passed on through move semantics.
2541         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2542
2543 2014-01-23  Joseph Pecoraro  <pecoraro@apple.com>
2544
2545         Move RegularExpression into JavaScriptCore for inspector
2546         https://bugs.webkit.org/show_bug.cgi?id=127526
2547
2548         Reviewed by Geoffrey Garen.
2549
2550         * WebView/WebHTMLRepresentation.mm:
2551
2552 2014-01-23  Benjamin Poulain  <bpoulain@apple.com>
2553
2554         Remote Inspector uses the Page pointer before the page is created on iOS
2555         https://bugs.webkit.org/show_bug.cgi?id=127534
2556
2557         Reviewed by Joseph Pecoraro.
2558
2559         * WebView/WebView.mm:
2560         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2561
2562 2014-01-23  Jon Honeycutt  <jhoneycutt@apple.com>
2563
2564         Assertion failure in WebCore::PseudoElement::didRecalcStyle()
2565         <https://bugs.webkit.org/show_bug.cgi?id=126761>
2566         <rdar://problem/15793540>
2567
2568         Some areas of code were erroneously checking the value of
2569         RenderObject::isImage() rather than RenderObject::isRenderImage()
2570         before casting the object to RenderImage.
2571
2572         This could lead to an assertion failure for RenderListMarkers, which
2573         may return true for isImage(), but are not RenderImages.
2574
2575         Reviewed by Andy Estes.
2576
2577         * Misc/WebNSPasteboardExtras.mm:
2578         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2579         Check isRenderImage() rather than isImage() before casting to
2580         RenderImage.
2581
2582 2014-01-23  Joseph Pecoraro  <pecoraro@apple.com>
2583
2584         Web Inspector: Remove recompileAllJSFunctions timer in ScriptDebugServer
2585         https://bugs.webkit.org/show_bug.cgi?id=127409
2586
2587         Reviewed by Geoffrey Garen.
2588
2589         * WebCoreSupport/WebInspectorClient.mm:
2590         (-[WebInspectorWindowController destroyInspectorView:]):
2591         Include InspectorDisconnectReason.
2592
2593 2014-01-23  Max Vujovic  <mvujovic@adobe.com>
2594
2595         Remove CSS Custom Filters code and tests
2596         https://bugs.webkit.org/show_bug.cgi?id=127382
2597
2598         Reviewed by Simon Fraser.
2599
2600         * Configurations/FeatureDefines.xcconfig:
2601         * WebView/WebPreferenceKeysPrivate.h:
2602         * WebView/WebPreferences.mm:
2603         (+[WebPreferences initialize]):
2604         * WebView/WebPreferencesPrivate.h:
2605         * WebView/WebView.mm:
2606         (-[WebView _preferencesChanged:]):
2607
2608 2014-01-22  Myles C. Maxfield  <mmaxfield@apple.com>
2609
2610         Remove CSS3_TEXT_DECORATION define
2611         https://bugs.webkit.org/show_bug.cgi?id=127333
2612
2613         Reviewed by Simon Fraser.
2614
2615         This is required for unprefixing the text-decoration-* CSS properties.
2616
2617         * Configurations/FeatureDefines.xcconfig:
2618
2619 2014-01-22  Dan Bernstein  <mitz@apple.com>
2620
2621         Build fix for iOS clients of WebUIDelegatePrivate.h.
2622
2623         * WebView/WebUIDelegatePrivate.h: Ensure that ENABLE_DASHBOARD_SUPPORT is defined on iOS.
2624
2625 2014-01-21  Dan Bernstein  <mitz@apple.com>
2626
2627         Added a method declaration that was missed in r161185.
2628
2629         Reviewed by Sam Weinig.
2630
2631         * WebView/WebViewPrivate.h: Declared -removeVisitedLink:.
2632
2633 2014-01-21  Commit Queue  <commit-queue@webkit.org>
2634
2635         Unreviewed, rolling out r162452.
2636         http://trac.webkit.org/changeset/162452
2637         https://bugs.webkit.org/show_bug.cgi?id=127366
2638
2639         broke a few tests on all Mac WebKit1 bots (Requested by
2640         thorton on #webkit).
2641
2642         * WebView/WebView.mm:
2643         (-[WebView _windowWillOrderOnScreen:]):
2644         (-[WebView _windowWillOrderOffScreen:]):
2645
2646 2014-01-21  Gavin Barraclough  <barraclough@apple.com>
2647
2648         Change Page, FocusController to use ViewState
2649         https://bugs.webkit.org/show_bug.cgi?id=126533
2650
2651         Reviewed by Tim Horton.
2652
2653         These classes currently maintain a set of separate fields to represent the view state;
2654         combine these into a single field, and allow WebPage to send the combined update rather
2655         than individual changes.
2656
2657         Maintain existing interface for WebKit1 clients.
2658
2659         * WebView/WebView.mm:
2660         (-[WebView _windowWillOrderOnScreen:]):
2661         (-[WebView _windowWillOrderOffScreen:]):
2662             - remove calls to FocusController::setContentIsVisible, these are redundant
2663               (this is handled when page visibility is set).
2664
2665 2014-01-20  Jeremy Jones  <jeremyj@apple.com>
2666
2667         Add AVKit fullscreen video interface.
2668         https://bugs.webkit.org/show_bug.cgi?id=126818
2669
2670         Reviewed by Eric Carlson.
2671
2672         * WebCoreSupport/WebChromeClient.h:
2673         * WebCoreSupport/WebChromeClient.mm:
2674         (WebChromeClient::supportsFullscreenForNode):
2675         Enable *FullscreenForNode for HTMLMediaElement for iOS
2676
2677         * WebView/WebPreferenceKeysPrivate.h:
2678         * WebView/WebPreferences.mm:
2679         (+[WebPreferences initialize]):
2680         (-[WebPreferences mediaPlaybackFullscreenAVKit]):
2681         (-[WebPreferences setMediaPlaybackFullscreenAVKit:]):
2682         * WebView/WebPreferencesPrivate.h:
2683         * WebView/WebView.mm:
2684         (-[WebView _preferencesChanged:]):
2685         (-[WebView _enterFullscreenForNode:WebCore::]):
2686         * WebView/WebViewInternal.h:
2687         Add a disabled pref mediaPlaybackFullscreenAVKit.
2688         Use WebVideoFullscreenControllerAVKit on iOS
2689
2690 2014-01-18  Brian Burg  <bburg@apple.com>
2691
2692         Web Inspector: Page should use std::unique_ptr for InspectorController
2693         https://bugs.webkit.org/show_bug.cgi?id=127068
2694
2695         Reviewed by Joseph Pecoraro.
2696
2697         Convert call sites to use a InspectorController reference.
2698         Convert instantiations of InspectorFrontendClient to use std::unique_ptr.
2699
2700         * WebCoreSupport/WebInspectorClient.mm:
2701         (WebInspectorClient::openInspectorFrontend):
2702         (-[WebInspectorWindowController destroyInspectorView:]):
2703         * WebInspector/WebInspector.mm:
2704         (-[WebInspector showWindow]):
2705         (-[WebInspector isJavaScriptProfilingEnabled]):
2706         (-[WebInspector setJavaScriptProfilingEnabled:]):
2707         (-[WebInspector close:]):
2708         (-[WebInspector evaluateInFrontend:callId:script:]):
2709         * WebInspector/WebNodeHighlighter.mm:
2710         (-[WebNodeHighlighter highlight]):
2711
2712 2014-01-18  Anders Carlsson  <andersca@apple.com>
2713
2714         Remove ENABLE_THREADED_HTML_PARSER defines everywhere
2715         https://bugs.webkit.org/show_bug.cgi?id=127225
2716
2717         Reviewed by Andreas Kling.
2718
2719         This concludes the removal of over 8.8 million lines of threaded parser code.
2720
2721         * Configurations/FeatureDefines.xcconfig:
2722
2723 2014-01-17  Anders Carlsson  <andersca@apple.com>
2724
2725         Clean up PageCache classes
2726         https://bugs.webkit.org/show_bug.cgi?id=127202
2727
2728         Reviewed by Andreas Kling.
2729
2730         * WebCoreSupport/WebFrameLoaderClient.mm:
2731         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2732         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2733
2734 2014-01-17  Anders Carlsson  <andersca@apple.com>
2735
2736         Remove another unused FrameLoaderClient callback
2737         https://bugs.webkit.org/show_bug.cgi?id=127192
2738
2739         Reviewed by Dan Bernstein.
2740
2741         * WebCoreSupport/WebFrameLoaderClient.h:
2742         * WebCoreSupport/WebFrameLoaderClient.mm:
2743
2744 2014-01-17  Anders Carlsson  <andersca@apple.com>
2745
2746         Move didPerformFirstNavigation() logic to -[WebView _didCommitLoadForFrame:]
2747         https://bugs.webkit.org/show_bug.cgi?id=127189
2748
2749         Reviewed by Dan Bernstein.
2750
2751         This is a first step towards completely eliminating the didPerformFirstNavigation() client callback.
2752         
2753         * WebCoreSupport/WebFrameLoaderClient.h:
2754         * WebCoreSupport/WebFrameLoaderClient.mm:
2755         Remove didPerformFirstNavigation() implementation.
2756
2757         * WebView/WebView.mm:
2758         (-[WebView _checkDidPerformFirstNavigation]):
2759         Check if we have both a current item and a previous item which indicates that we've navigated once.
2760         The old code was called before there was a current item but since this is called from _didCommitLoadForFrame
2761         we have to check that there's a current item as well.
2762
2763         (-[WebView _didCommitLoadForFrame:]):
2764         Call _didCommitLoadForFrame.
2765
2766         * WebView/WebViewData.h:
2767         Add new ivar.
2768
2769 2014-01-17  Alexey Proskuryakov  <ap@apple.com>
2770
2771         More iOS build fix.
2772
2773         * WebView/WebPreferences.mm: (-[WebPreferences _synchronizeWebStoragePolicyWithCookiePolicy]):
2774         NSHTTPCookieAcceptPolicyExclusivelyFromMainDocumentDomain is not part of NSHTTPCookieAcceptPolicy enum.
2775
2776 2014-01-16  Daniel Bates  <dabates@apple.com>
2777
2778         [iOS] MobileSafari build fix. Declare iOS-specific method mainFrameIconURL
2779
2780         For now, add mainFrameIconURL() to WebView.h. We should further investigate its
2781         usage and API/SPI status.
2782
2783         * WebView/WebView.h:
2784
2785 2014-01-16  Alexey Proskuryakov  <ap@apple.com>
2786
2787         [Mac] [iOS] Add support for CFHTTPCookieStorageAcceptPolicyExclusivelyFromMainDocumentDomain
2788         https://bugs.webkit.org/show_bug.cgi?id=127139
2789
2790         Reviewed by Brady Eidson.
2791
2792         * WebView/WebPreferences.mm: (-[WebPreferences _synchronizeWebStoragePolicyWithCookiePolicy]):
2793         Handle the new case.
2794
2795 2014-01-16  Daniel Bates  <dabates@apple.com>
2796
2797         [iOS] Fix UIKit build warning about undefined macro ENABLE_NETSCAPE_PLUGIN_API
2798
2799         * WebView/WebFramePrivate.h: Wrap use of ENABLE_NETSCAPE_PLUGIN_API in TARGET_OS_IPHONE.
2800
2801 2014-01-16  Anders Carlsson  <andersca@apple.com>
2802
2803         Change all uses of FINAL to final now that all our compilers support it
2804         https://bugs.webkit.org/show_bug.cgi?id=127142
2805
2806         Reviewed by Benjamin Poulain.
2807
2808         * WebCoreSupport/WebUserMediaClient.h:
2809         * WebView/WebScriptDebugger.h:
2810
2811 2014-01-16  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2812
2813         Remove workaround for compilers not supporting explicit override control
2814         https://bugs.webkit.org/show_bug.cgi?id=127111
2815
2816         Reviewed by Anders Carlsson.
2817
2818         Now all compilers support explicit override control, this workaround can be removed.
2819
2820         * Storage/WebDatabaseManagerClient.h:
2821         * Storage/WebStorageTrackerClient.h:
2822         * WebCoreSupport/WebAlternativeTextClient.h:
2823         * WebCoreSupport/WebChromeClient.h:
2824         * WebCoreSupport/WebContextMenuClient.h:
2825         * WebCoreSupport/WebDeviceOrientationClient.h:
2826         * WebCoreSupport/WebDragClient.h:
2827         * WebCoreSupport/WebEditorClient.h:
2828         * WebCoreSupport/WebFrameLoaderClient.h:
2829         * WebCoreSupport/WebFrameNetworkingContext.h:
2830         * WebCoreSupport/WebGeolocationClient.h:
2831         * WebCoreSupport/WebIconDatabaseClient.h:
2832         * WebCoreSupport/WebInspectorClient.h:
2833         * WebCoreSupport/WebNotificationClient.h:
2834         * WebCoreSupport/WebPlatformStrategies.h:
2835         * WebCoreSupport/WebProgressTrackerClient.h:
2836         * WebCoreSupport/WebUserMediaClient.h:
2837         * WebView/WebScriptDebugger.h:
2838         * WebView/WebViewData.h:
2839
2840 2014-01-16  Andy Estes  <aestes@apple.com>
2841
2842         [iOS] Fix build issues with exported headers
2843
2844         * DOM/WebDOMOperationsPrivate.h: Changed PLATFORM(IOS) to
2845         TARGET_OS_IPHONE.
2846         * MigrateHeaders.make: Excluded WAKScrollView.h from normal replacement
2847         rules so that WebCoreFrameScrollView won't inadvertently get changed to
2848         WebKitFrameScrollView.
2849         * Plugins/WebPlugin.h: Moved contents of WebPluginPrivate.h to here in
2850         order to maintain source compatibility.
2851         * Plugins/WebPluginController.mm: Removed an import of WebPluginPrivate.h.
2852         * Plugins/WebPluginPrivate.h: Removed.
2853         * Storage/WebDatabaseManagerPrivate.h: Replaced ENABLE(SQL_DATABASE)
2854         with ENABLE_SQL_DATABASE.
2855         * WebView/WebViewPrivate.h: Added declaration of
2856         -[WebView _touchEventRegions] for source compatibility.
2857
2858 2014-01-15  Benjamin Poulain  <bpoulain@apple.com>
2859
2860         Fix the iOS build after r162114
2861
2862         Unreviewed.
2863
2864         * WebView/WebViewPrivate.h: I forgot to remove the declaration, fix that.
2865
2866 2014-01-15  Benjamin Poulain  <bpoulain@apple.com>
2867
2868         Move user agent code to WebCore and unify some code between OS X and iOS
2869         https://bugs.webkit.org/show_bug.cgi?id=127080
2870
2871         Reviewed by Sam Weinig.
2872
2873         * WebCoreSupport/WebSystemInterface.mm:
2874         (InitWebCoreSystemInterface):
2875         * WebView/WebView.mm:
2876         (userVisibleWebKitVersionString):
2877         (+[WebView _standardUserAgentWithApplicationName:]):
2878         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]):
2879
2880 2014-01-15  Joseph Pecoraro  <pecoraro@apple.com>
2881
2882         [iOS] Clean up REMOTE_INSPECTOR code in OpenSource after the iOS merge
2883         https://bugs.webkit.org/show_bug.cgi?id=127069
2884
2885         Reviewed by Timothy Hatcher.
2886
2887         * WebView/WebView.mm:
2888         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2889         (+[WebView _enableRemoteInspector]):
2890         (+[WebView _disableRemoteInspector]):
2891         (+[WebView _disableAutoStartRemoteInspector]):
2892         (+[WebView _isRemoteInspectorEnabled]):
2893         (+[WebView _hasRemoteInspectorSession]):
2894         (-[WebView allowsRemoteInspection]):
2895         Implement with RemoteInspector.h SPIs.
2896
2897         (-[WebView setAllowsRemoteInspection:]):
2898         (-[WebView setHostApplicationBundleId:name:]):
2899         Still unimplemented, update comment.
2900
2901         (-[WebView _didCommitLoadForFrame:]):
2902         Remove dead path, WebCore now pushes updates on navigations.
2903
2904         * WebView/WebViewData.h:
2905         * WebView/WebViewData.mm:
2906         (-[WebViewPrivate init]):
2907         Remove now unused ivar.
2908
2909 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
2910
2911         More iOS build fixing.
2912
2913         * WebView/WebPreferences.mm: (-[WebPreferences _invalidateCachedPreferences]):
2914         Removed a now unused local variable.
2915
2916 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
2917
2918         Build fix for iOS.
2919
2920         * WebView/WebPreferences.mm: (-[WebPreferences _invalidateCachedPreferences]):
2921         Update a remaining call site of _updatePrivateBrowsingStateFram:to:.
2922
2923 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
2924
2925         Crash when multiple WebView instances have different PrivateBrowsing settings
2926         https://bugs.webkit.org/show_bug.cgi?id=127019
2927
2928         * WebView/WebPreferences.mm: (-[WebPreferences _updatePrivateBrowsingStateTo:]):
2929         Added a null check to fix Safari crash on startup when extensions are enabled.
2930
2931 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
2932
2933         Crash when multiple WebView instances have different PrivateBrowsing settings
2934         https://bugs.webkit.org/show_bug.cgi?id=127019
2935
2936         Reviewed by Sam Weinig.
2937
2938         * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Don't delete a private
2939         browsing session simply because one preferences object doesn't use private browsing.
2940         There could be others that do.
2941
2942         * WebView/WebPreferences.mm: Track how many WebPreferences objects use private
2943         browsing, and only delete the private session when there are none any more.
2944
2945 2014-01-15  David Kilzer  <ddkilzer@apple.com>
2946
2947         [iOS] Missing RenderObject::style() symbol in WebDOMOperations.mm
2948
2949         Fixes the following linker error:
2950
2951             Undefined symbols for architecture x86_64:
2952               "__ZNK7WebCore12RenderObject5styleEv", referenced from:
2953                   -[DOMNode(WebDOMNodeOperations) isHorizontalWritingMode] in WebDOMOperations.o
2954
2955         * DOM/WebDOMOperations.mm: Include RenderElement.h instead of
2956         RenderObject.h since the inline RenderObject::style() method
2957         moved to the former header.
2958
2959 2014-01-15  Commit Queue  <commit-queue@webkit.org>
2960
2961         Unreviewed, rolling out r162054.
2962         http://trac.webkit.org/changeset/162054
2963         https://bugs.webkit.org/show_bug.cgi?id=127053
2964
2965         Causes assertion failures in DumpRenderTree (Requested by ap
2966         on #webkit).
2967
2968         * WebView/WebPreferences.mm:
2969         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2970         (-[WebPreferences initWithCoder:]):
2971         (+[WebPreferences standardPreferences]):
2972         (-[WebPreferences dealloc]):
2973         (-[WebPreferences setPrivateBrowsingEnabled:]):
2974         (-[WebPreferences _invalidateCachedPreferences]):
2975         * WebView/WebView.mm:
2976         (-[WebView _preferencesChanged:]):
2977
2978 2014-01-14  Alexey Proskuryakov  <ap@apple.com>
2979
2980         Crash when multiple WebView instances have different PrivateBrowsing settings
2981         https://bugs.webkit.org/show_bug.cgi?id=127019
2982
2983         Reviewed by Sam Weinig.
2984
2985         * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Don't delete a private
2986         browsing session simply because one preferences object doesn't use private browsing.
2987         There could be others that do.
2988
2989         * WebView/WebPreferences.mm: Track how many WebPreferences objects use private
2990         browsing, and only delete the private session when there are none any more.
2991
2992 2014-01-14  Simon Fraser  <simon.fraser@apple.com>
2993
2994         Fix the iOS build after r162034.
2995
2996         * WebCoreSupport/WebProgressTrackerClient.mm:
2997         * WebView/WebView.mm:
2998         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2999
3000 2014-01-14  Mark Rowe  <mrowe@apple.com>
3001
3002         Stop cmp from spewing useless info during postprocess-headers.sh.
3003
3004         * postprocess-headers.sh: Pass -s to silence cmp since we only care about the
3005         exit status.
3006
3007 2014-01-14  Joseph Pecoraro  <pecoraro@apple.com>
3008
3009         [iOS] Crash in NavigatorBase::vendor loading apple.com
3010         https://bugs.webkit.org/show_bug.cgi?id=127028
3011
3012         Reviewed by Daniel Bates.
3013
3014         Fill in iOS WebKitSystemInterface functions.
3015
3016         * WebCoreSupport/WebSystemInterface.mm:
3017         (InitWebCoreSystemInterface):
3018
3019 2014-01-14  Anders Carlsson  <andersca@apple.com>
3020
3021         Create separate progress tracker clients
3022         https://bugs.webkit.org/show_bug.cgi?id=127025
3023
3024         Reviewed by Sam Weinig.
3025
3026         * WebCoreSupport/WebFrameLoaderClient.h:
3027         * WebCoreSupport/WebFrameLoaderClient.mm:
3028         * WebCoreSupport/WebProgressTrackerClient.h: Copied from Source/WebCore/loader/ProgressTrackerClient.h.
3029         * WebCoreSupport/WebProgressTrackerClient.mm: Added.
3030         (WebProgressTrackerClient::WebProgressTrackerClient):
3031         (WebProgressTrackerClient::progressTrackerDestroyed):
3032         (WebProgressTrackerClient::willChangeEstimatedProgress):
3033         (WebProgressTrackerClient::didChangeEstimatedProgress):
3034         (WebProgressTrackerClient::progressStarted):
3035         (WebProgressTrackerClient::progressEstimateChanged):
3036         (WebProgressTrackerClient::progressFinished):
3037         * WebView/WebView.mm:
3038         (-[WebView _commonInitializationWithFrameName:groupName:]):
3039         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3040
3041 2014-01-14  Dean Jackson  <dino@apple.com>
3042
3043         Correct grave mistake in updating the pbxproj file rather than xcconfig.
3044
3045         * Configurations/WebKit.xcconfig:
3046
3047 2014-01-14  Simon Fraser  <simon.fraser@apple.com>
3048
3049         #define ENABLE_DASHBOARD_SUPPORT for iOS.
3050
3051         * WebView/WebViewPrivate.h:
3052
3053 2014-01-14  Simon Fraser  <simon.fraser@apple.com>
3054
3055         Clean up exports and headers for iOS.
3056         
3057         Need to export WebArchivePboardType on Mac and iOS.
3058
3059         * WebKit.exp:
3060         * WebKit.mac.exp:
3061
3062 2014-01-14  Simon Fraser  <simon.fraser@apple.com>
3063
3064         Fix header availability checks on iOS
3065         https://bugs.webkit.org/show_bug.cgi?id=127016
3066
3067         Reviewed by Andy Estes.
3068
3069         Make DOMTouch* and DOMGesture* headers public headers on iOS,
3070         and fix MigrateHeaders.make to skip availability checks when
3071         building for iOS.
3072
3073         * MigrateHeaders.make:
3074
3075 2014-01-14  Simon Fraser  <simon.fraser@apple.com>
3076
3077         Need to #import <WebCore/QuickLook.h>.
3078
3079         * WebView/WebDataSource.mm:
3080
3081 2014-01-14  Daniel Bates  <dabates@apple.com>
3082
3083         [iOS] Enable QuickLook
3084         https://bugs.webkit.org/show_bug.cgi?id=126954
3085
3086         Reviewed by David Kilzer.
3087
3088         Remove empty implementation for quickLookContentForURL: since we always enable QuickLook on iOS.
3089
3090         * WebView/WebView.mm:
3091         (-[WebView quickLookContentForURL:]):
3092
3093 2014-01-14  Dean Jackson  <dino@apple.com>
3094
3095         Move some Mac-only exports to WebKit.mac.exp for iOS build.
3096
3097         * WebKit.exp:
3098         * WebKit.mac.exp:
3099
3100 2014-01-14  Simon Fraser  <simon.fraser@apple.com>
3101
3102         Move some Mac-only exports to WebKit.mac.exp for iOS build.
3103
3104         * WebKit.exp:
3105         * WebKit.mac.exp:
3106
3107 2014-01-14  Simon Fraser  <simon.fraser@apple.com>
3108
3109         Fix iOS WK1 linking.
3110
3111         * Configurations/WebKit.xcconfig: We do need WebOpenPanelResultListener
3112         on iOS.
3113         * WebCoreSupport/WebOpenPanelResultListener.mm: Need <WebCore/Icon.h>
3114
3115 2014-01-14  Simon Fraser  <simon.fraser@apple.com>
3116
3117         iOS build fixing: link WebKit against Security.framework on iOS.
3118
3119         * Configurations/WebKit.xcconfig:
3120
3121 2014-01-14  Dean Jackson  <dino@apple.com>
3122
3123         [WK1] Allow generated export files on iOS
3124         https://bugs.webkit.org/show_bug.cgi?id=127008
3125
3126         Reviewed by Simon Fraser.
3127
3128         Add a new Mac-only symbol file.
3129
3130         * WebKit.exp: To begin, move the WebIcon* into the Mac-specific exports.
3131         * WebKit.mac.exp: Added. New file holds Mac-only symbols.
3132
3133 2014-01-14  Brian J. Burg  <burg@cs.washington.edu>
3134
3135         Add ENABLE(WEB_REPLAY) feature flag to the build system
3136         https://bugs.webkit.org/show_bug.cgi?id=126949
3137
3138         Reviewed by Joseph Pecoraro.
3139
3140         * Configurations/FeatureDefines.xcconfig:
3141
3142 2014-01-13  Simon Fraser  <simon.fraser@apple.com>
3143
3144         Fix the Mac build. WebViewPrivate.h declares quickLookContentForURL:
3145         for iOS, but the implementation conditionalizes on USE(QUICK_LOOK),
3146         which we are confused about.
3147
3148         * WebView/WebView.mm:
3149         (-[WebView quickLookContentForURL:]):
3150         * WebView/WebViewPrivate.h:
3151
3152 2014-01-13  Simon Fraser  <simon.fraser@apple.com>
3153
3154         Fix the remaining compiler errors in iOS WK1.
3155
3156         * WebView/WebFrame.mm:
3157         (vectorForDictationPhrasesArray): Need this function on iOS.
3158         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]): We're already inside
3159         a huge if PLATFORM(IOS) block.
3160         (-[WebFrame resetTextAutosizingBeforeLayout]): Document now exposes RenderView.
3161         * WebView/WebFrameInternal.h: Declare vectorForDictationPhrasesArray() (not a good place for it!)
3162         * WebView/WebView.mm: #import cleanup for iOS.
3163         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Declare autoStartRemoteInspector
3164         here but this needs cleaning up (<rdar://problem/15810991>).
3165         (-[WebView setHostApplicationBundleId:name:]): No [WebView sharedWebInspectorServer] any more.
3166         (-[WebView _didCommitLoadForFrame:]): Ditto.
3167         * WebView/WebViewData.h: Add allowsRemoteInspection.
3168         * WebView/WebViewData.mm: Initialize allowsRemoteInspection
3169         (-[WebViewPrivate init]):
3170         * WebView/WebViewPrivate.h: Fumbled #ifdef.
3171
3172 2014-01-13  Simon Fraser  <simon.fraser@apple.com>
3173
3174         More work towards getting iOS WK1 building.
3175
3176         * DOM/WebDOMOperations.mm: Need RenderObject.h.
3177         * DOM/WebDOMOperationsPrivate.h:
3178         * History/WebBackForwardList.mm: Need Foundation/NSGeometry.h for NSRect
3179         (-[WebBackForwardList dictionaryRepresentation]): Fix array iteration to match
3180         other code.
3181         * Misc/WebIconDatabase.h: #ifdef out functions that return NSImages.
3182         * Plugins/WebPluginController.mm: Need <WebCore/AudioSession.h>
3183         * WebCoreSupport/WebFrameLoaderClient.mm:
3184         (WebFrameLoaderClient::transitionToCommittedForNewPage): Some new code to
3185         handle the error case.
3186         * WebView/WebFrameView.mm: Avoid including some headers which pull in AppKit classes.
3187         * WebView/WebHTMLView.mm: Ditto.
3188         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]): Handle
3189         different return type of createDragImageForSelection().
3190         * WebView/WebPolicyDelegatePrivate.h:
3191         * WebView/WebPreferences.mm: <WebCore/AudioSession.h> and <AudioToolbox/AudioSession.h>
3192
3193 2014-01-13  Daniel Bates  <dabates@apple.com>
3194
3195         [iOS] Remove duplicate inclusions of header WAKView.h
3196         following <http://trac.webkit.org/changeset/161910>
3197
3198         * WebView/WebFrameView.h:
3199         * WebView/WebHTMLView.h:
3200
3201 2014-01-13  Simon Fraser  <simon.fraser@apple.com>
3202
3203         Various iOS WebKit1 build fixes.
3204
3205         * Configurations/WebKit.xcconfig: Add more Mac-only files
3206         to the excluded files list for iOS.
3207         * DefaultDelegates/WebDefaultUIDelegate.m: Don't include WebJavaScriptTextInputPanel.h
3208         on iOS
3209         * History/WebHistory.h: NSCalendarDate doesn't exist on iOS.
3210         * Misc/WebDownload.h: Need WAKAppKitStubs.h
3211         * Misc/WebNSViewExtras.m: No WebNSPasteboardExtras on iOS
3212         * Storage/WebDatabaseManagerClient.mm: Need DatabaseTracker.h, no harm
3213         in including it for all platforms.
3214         * WebCoreSupport/WebEditorClient.h: Remove useless comment.
3215         * WebCoreSupport/WebEditorClient.mm:
3216         (nsStringWithoutCopying): Moved
3217         (WebEditorClient::checkTextOfParagraph): Modernized.
3218         * WebInspector/WebNodeHighlightView.mm: Need FloatQuad.h.
3219         * WebView/WebDataSource.mm: Need WebFrameViewInternal.h
3220         * WebView/WebDocument.h: Needs WAKView.h.
3221         * WebView/WebFrameView.h: Ditto.
3222         * WebView/WebHTMLView.h: Ditto.
3223         * WebView/WebPDFDocumentExtras.mm:
3224         (allScriptsInPDFDocument): No PDFDocument on iOS.
3225         * WebView/WebPolicyDelegate.h:
3226         * WebView/WebView.h: Fix incorrect #if.
3227
3228 2014-01-13  Daniel Bates  <dabates@apple.com>
3229
3230         [iOS] More build fixes for WebKit
3231
3232         * Configurations/Base.xcconfig: Removed extraneous definition of SUPPORTED_PLATFORMS.
3233         * Configurations/WebKit.xcconfig: Exclude more Mac-specific files when building for iOS:
3234         CarbonUtils.m, CarbonWindowAdapter.mm, CarbonWindowContentView.m, CarbonWindowFrame.m,
3235         HIViewAdapter.m, HIWebView.mm, MailQuirksUserScript.js, OutlookQuirksUserScript.js,
3236         PopupMenuMac.mm, SearchPopupMenuMac.mm, WebClipView.mm, WebInspectorClient.mm,
3237         WebNetscapeContainerCheckContextInfo.mm, WebNetscapeContainerCheckPrivate.mm, WebRenderNode.mm,
3238         WebStringTruncator.mm, and WebTextCompletionController.mm. I haven't verified the Mac-specific
3239         nature of each of these files. We may be able to reduce this list upon further investigation.
3240         * WebView/WebDocument.h: Include header <WebKit/WAKView.h> for definition of WAKView.
3241         * WebView/WebFrameView.h: Ditto.
3242         * WebView/WebUIDelegate.h: Ditto.
3243         * WebView/WebView.h: Ditto.
3244
3245 2014-01-13  Simon Fraser  <simon.fraser@apple.com>
3246
3247         Include WAKAppKitStubs.h to get NSSelectionAffinity.
3248
3249         * WebView/WebEditingDelegate.h:
3250
3251 2014-01-13  Simon Fraser  <simon.fraser@apple.com>
3252
3253         DOMTouch* etc should not be public headers on iOS.
3254         
3255         * MigrateHeaders.make:
3256
3257 2014-01-13  Andy Estes  <aestes@apple.com>
3258
3259         [iOS] Build Fix: switch back to calling postprocess-headers.sh
3260
3261         * postprocess-headers.sh:
3262
3263 2014-01-13  Zalan Bujtas  <zalan@apple.com>
3264
3265         Enable SUBPIXEL_LAYOUT on Mac
3266         <https://webkit.org/b/126283>
3267
3268         Reviewed by Simon Fraser.
3269
3270         * Configurations/FeatureDefines.xcconfig:
3271
3272 2014-01-12  Darin Adler  <darin@apple.com>
3273
3274         Add deprecatedCharacters as a synonym for characters and convert most call sites
3275         https://bugs.webkit.org/show_bug.cgi?id=126858
3276
3277         Reviewed by Anders Carlsson.
3278
3279         * History/BinaryPropertyList.cpp:
3280         (BinaryPropertyListSerializer::appendStringObject):
3281         Use deprecatedCharacters instead of characters.
3282
3283 2014-01-12  Darin Adler  <darin@apple.com>
3284
3285         Add type checking to isEqual methods
3286         https://bugs.webkit.org/show_bug.cgi?id=126862
3287
3288         Reviewed by Anders Carlsson.
3289
3290         * WebCoreSupport/WebSecurityOrigin.mm:
3291         (-[WebSecurityOrigin isEqual:]): Added a FIXME about the lack of a hash method
3292         override. Tweaked formatting.
3293
3294         * WebView/WebDashboardRegion.mm:
3295         (-[WebDashboardRegion isEqual:]): Added type checking on the argument. Added a
3296         FIXME about the lack of a hash method override.
3297
3298 2014-01-11  Alexey Proskuryakov  <ap@apple.com>
3299
3300         [Mac] [Windows] Stop scheduling network requests in WebCore
3301         https://bugs.webkit.org/show_bug.cgi?id=126789
3302         <rdar://problem/15114727>
3303
3304         Reviewed by Sam Weinig.
3305
3306         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Updated
3307         for new WKSI function names.
3308
3309 2014-01-10  Anders Carlsson  <andersca@apple.com>
3310
3311         Tweak ProgressTrackerClient functions
3312         https://bugs.webkit.org/show_bug.cgi?id=126808
3313
3314         Reviewed by Sam Weinig.
3315
3316         * WebCoreSupport/WebFrameLoaderClient.h:
3317         * WebCoreSupport/WebFrameLoaderClient.mm:
3318         (WebFrameLoaderClient::progressStarted):
3319         (WebFrameLoaderClient::progressEstimateChanged):
3320         (WebFrameLoaderClient::progressFinished):
3321
3322 2014-01-10  Anders Carlsson  <andersca@apple.com>
3323
3324         Move progress tracking functions from FrameLoaderClient to a new ProgressTrackerClient
3325         https://bugs.webkit.org/show_bug.cgi?id=126801
3326
3327         Reviewed by Sam Weinig.
3328
3329         * WebCoreSupport/WebFrameLoaderClient.h:
3330         * WebView/WebView.mm:
3331         (-[WebView _commonInitializationWithFrameName:groupName:]):
3332
3333 2014-01-10  David Kilzer  <ddkilzer@apple.com>
3334
3335         Clean up architectures in xcconfig files
3336         <http://webkit.org/b/126794>
3337
3338         Reviewed by Andy Estes.
3339
3340         * Configurations/WebKit.xcconfig: Remove armv6, armv7f, ppc.
3341         - Add new arch.
3342
3343 2014-01-10  Yongjun Zhang  <yongjun_zhang@apple.com>
3344
3345         Clear unparented tiled layers on memory pressure.
3346         https://bugs.webkit.org/show_bug.cgi?id=126737
3347
3348         Reviewed by Simon Fraser.
3349
3350         * WebView/WebView.mm:
3351         (+[WebView _handleMemoryWarning]): Clear all unparented tiles when under memory pressure.
3352
3353 2014-01-10  Daniel Bates  <dabates@apple.com>
3354
3355         Fix the WebCore, WebKit build targets following <http://trac.webkit.org/changeset/161638>
3356         (https://bugs.webkit.org/show_bug.cgi?id=126698)
3357
3358         Tell Xcode that the supported platforms for all WebCore targets are iOS and OS X.
3359
3360         * Configurations/Base.xcconfig:
3361
3362 2014-01-09  Andy Estes  <aestes@apple.com>
3363
3364         [iOS] Upstream iOS changes to MigrateHeaders.make
3365         https://bugs.webkit.org/show_bug.cgi?id=126731
3366
3367         Reviewed by David Kilzer.
3368
3369         * MigrateHeaders.make: Migrate iOS-specific headers when building for iOS.
3370
3371 2014-01-10  Daniel Bates  <dabates@apple.com>
3372
3373         [iOS] Upstream WebCore and Tools miscellaneous changes
3374         https://bugs.webkit.org/show_bug.cgi?id=126698
3375
3376         Reviewed by David Kilzer.
3377
3378         * MigrateHeaders.make:
3379
3380 2014-01-08  Anders Carlsson  <andersca@apple.com>
3381
3382         Add WTF::StringView and use it for grammar checking
3383         https://bugs.webkit.org/show_bug.cgi?id=126644
3384
3385         Reviewed by Antti Koivisto.
3386
3387         * WebCoreSupport/WebEditorClient.h:
3388         * WebCoreSupport/WebEditorClient.mm:
3389         (WebEditorClient::checkTextOfParagraph):
3390         Update to match the new signature.
3391
3392         (nsStringWithoutCopying):
3393         New function that creates an NSString that references StringView data
3394         without copying the data. (If this function proves to be useful elsewhere, it could
3395         potentially be added to StringView).
3396
3397 2014-01-02  Andy Estes  <aestes@apple.com>
3398
3399         [iOS] Clean up some exported headers
3400         https://bugs.webkit.org/show_bug.cgi?id=126403
3401
3402         Reviewed by Simon Fraser.
3403
3404         Public header files that are completely excluded on iOS don't need
3405         !TARGET_OS_IPHONE guards since they are already listed in
3406         EXCLUDED_SOURCE_FILE_NAMES.
3407
3408         I also took the opportunity to sort EXCLUDED_SOURCE_FILE_NAMES and to
3409         clean up some #imports.
3410
3411         * Configurations/WebKit.xcconfig:
3412         * Misc/WebCache.h:
3413         * Misc/WebIconDatabasePrivate.h:
3414         * Misc/WebLocalizableStrings.h:
3415         * Misc/WebNSEventExtras.h:
3416         * Misc/WebNSPasteboardExtras.h:
3417         * Misc/WebNSWindowExtras.h:
3418         * Panels/WebPanelAuthenticationHandler.h:
3419         * Plugins/WebPluginsPrivate.h:
3420         * Storage/WebDatabaseManagerPrivate.h:
3421         * WebCoreSupport/WebJavaScriptTextInputPanel.h:
3422         * WebCoreSupport/WebKeyGenerator.h:
3423         * WebCoreSupport/WebSecurityOriginPrivate.h:
3424         * WebView/WebDashboardRegion.h:
3425         * WebView/WebDynamicScrollBarsView.h:
3426         * WebView/WebFrameView.h:
3427         * WebView/WebPreferenceKeysPrivate.h:
3428         * WebView/WebResourceLoadDelegatePrivate.h:
3429         * WebView/WebView.h:
3430
3431 2014-01-07  Seokju Kwon  <seokju@webkit.org>
3432
3433         Web Inspector: Remove leftover 'device metrics' code
3434         https://bugs.webkit.org/show_bug.cgi?id=126607
3435
3436         Reviewed by Joseph Pecoraro.
3437
3438         * WebKit.order: Update after removing InspectorClient::overrideDeviceMetrics().
3439
3440 2014-01-02  Andy Estes  <aestes@apple.com>
3441
3442         [iOS] Upstream WebKit support for various features
3443         https://bugs.webkit.org/show_bug.cgi?id=126413
3444
3445         Reviewed by Sam Weinig.
3446
3447         Upstream iOS WebKit changes needed for these features:
3448
3449         - ENABLE(DELETION_UI)
3450         - ENABLE(TOUCH_EVENTS)
3451         - USE(QUICK_LOOK)
3452         - USE(UIKIT_EDITING)
3453         - ENABLE(DISK_IMAGE_CACHE)
3454         - ENABLE(IOS_TEXT_AUTOSIZING)
3455         - ENABLE(ICONDATABASE)
3456         - ENABLE(DASHBOARD_SUPPORT)
3457
3458         * DefaultDelegates/WebDefaultEditingDelegate.m:
3459         * Misc/WebCache.mm:
3460         * WebCoreSupport/WebChromeClient.h:
3461         * WebView/WebDataSource.mm:
3462         (-[WebDataSource dealloc]):
3463         * WebView/WebEditingDelegatePrivate.h:
3464         * WebView/WebFrame.mm:
3465         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
3466         * WebView/WebHTMLView.mm:
3467         (-[WebHTMLView maintainsInactiveSelection]):
3468         (-[WebHTMLView touch:]):
3469         * WebView/WebPreferences.mm:
3470         (+[WebPreferences initialize]):
3471         * WebView/WebPreferencesPrivate.h:
3472         * WebView/WebView.mm:
3473         (-[WebView _preferencesChanged:]):
3474         (-[WebView _cacheFrameLoadDelegateImplementations]):
3475         (-[WebView quickLookContentForURL:]):
3476         (-[WebView _touchEventRegions]):
3477         * WebView/WebViewPrivate.h:
3478
3479 2014-01-02  Andy Estes  <aestes@apple.com>
3480
3481         [iOS] Upstream a bug fix for plugin-backed media elements
3482         https://bugs.webkit.org/show_bug.cgi?id=126412
3483
3484         Reviewed by Eric Carlson.
3485
3486         Media elements backed by plug-ins should outlive being removed from the
3487         document, like their native counterparts do.
3488
3489         * Plugins/WebPluginController.h:
3490         * Plugins/WebPluginController.mm:
3491         (-[NSView isMediaPlugInProxyView]):
3492         (-[NSView setIsMediaPlugInProxyView:]):
3493         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
3494         (-[WebPluginController mediaPlugInProxyViewCreated:]):
3495         (-[WebPluginController destroyPlugin:]):
3496         * WebCoreSupport/WebFrameLoaderClient.mm:
3497         (pluginView):
3498
3499 2014-01-07  Mark Rowe  <mrowe@apple.com>
3500
3501         <https://webkit.org/b/126562> DOMProgressEvent has unspecified availability
3502
3503         Reviewed by Ryosuke Niwa.
3504
3505         * MigrateHeaders.make: Ensure that public DOM headers do not have unspecified availability.
3506
3507 2014-01-06  Mark Rowe  <mrowe@apple.com>
3508
3509         Mountain Lion build fix after r161332.
3510
3511         * Carbon/HIWebView.h: Mountain Lion's version of CF_AVAILABLE_MAC doesn't accept a message
3512         argument so remove it.
3513
3514 2014-01-06  Mark Rowe  <mrowe@apple.com>
3515
3516         <https://webkit.org/b/126499> Move WebKit off the legacy WebKit availability macros
3517
3518         The legacy WebKit availability macros are verbose, confusing, and provide no benefit
3519         over using the system availability macros directly. The original vision was that
3520         they'd serve a cross-platform purpose but that never came to be.
3521
3522         Since WebKit1 is API on OS X but SPI on iOS, some indirection is still needed in the
3523         availability macros to allow the headers to advertise the API as unavailable on OS X
3524         without interfering with the ability to build on iOS. This is achieved by defining
3525         WEBKIT-prefixed versions of the Foundation availability macros that are defined to
3526         their NS-prefixed equivalents. The installed headers are post-processed to map these
3527         macros back to their Foundation equivalents.
3528
3529         Part of <rdar://problem/15512304>.
3530
3531         The OS X version used in the new availability macros is based on the mapping in
3532         JavaScriptCore/WebKitAvailability.h.
3533
3534         Reviewed by Sam Weinig.
3535
3536         * Carbon/CarbonUtils.h:
3537         * Carbon/HIWebView.h:
3538         * MigrateHeaders.make: Migrate WebKitAvailability.h from WebCore as an API header.
3539         * Plugins/WebPlugin.h:
3540         * Plugins/WebPluginViewFactory.h:
3541         * WebView/WebFrameLoadDelegate.h:
3542         * WebView/WebResourceLoadDelegatePrivate.h:
3543         * WebView/WebUIDelegate.h:
3544         * postprocess-headers.sh: Added. Extracted from the Xcode project. Extended to map the
3545         WEBKIT-prefixed macros to their NS-prefixed equivalents on OS X and to remove them on iOS.
3546
3547 2014-01-04  Zan Dobersek  <zdobersek@igalia.com>
3548
3549         Explicitly use the std:: nested name specifier when using std::pair, std::make_pair
3550         https://bugs.webkit.org/show_bug.cgi?id=126439
3551
3552         Reviewed by Andreas Kling.
3553
3554         Instead of relying on std::pair and std::make_pair symbols being present in the current scope
3555         through the pair and make_pair symbols, the std:: specifier should be used explicitly.
3556
3557         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3558         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3559         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
3560         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain):
3561         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release):
3562         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
3563
3564 2014-01-02  Gavin Barraclough  <barraclough@apple.com>
3565
3566         Remove WindowIsVisible
3567         https://bugs.webkit.org/show_bug.cgi?id=126270
3568
3569         Reviewed by Tim Horton.
3570
3571         We currently track visibility in two ways - ViewState::IsVisible and ViewState::WindowIsVisible.
3572         The latter detects that the content is hidden in fewer cases than the former, and as such, the
3573         former is always preferable.
3574
3575         This affects the hidden state provided to FocusController::contentAreaDidShowOrHide and to
3576         Plugin::windowVisibilityChanged.
3577
3578         * WebView/WebView.mm:
3579         (-[WebView _windowWillOrderOnScreen:]):
3580         (-[WebView _windowWillOrderOffScreen:]):
3581             - rename ContainingWindowIsVisible -> ContentIsVisible.
3582
3583 2014-01-02  Gavin Barraclough  <barraclough@apple.com>
3584
3585         Merge didMoveOnscreen / page visibility to isVisible
3586         https://bugs.webkit.org/show_bug.cgi?id=126268
3587
3588         Reviewed by Tim Horton.
3589
3590         The onscreen state most closely tracks view visibility (though currently
3591         also tracks a mix of in-window state). Make more consistent, simplify,
3592         and move all animation suspension logic to Page, so it can be controlled
<