Cursor doesn't change back to pointer when leaving Mail
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2015-03-26  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Cursor doesn't change back to pointer when leaving Mail
4         https://bugs.webkit.org/show_bug.cgi?id=132038
5
6         Reviewed by Anders Carlsson.
7
8         Fixed the bug by adding a cursor rect and making the primary tracking area update the cursor so that
9         AppKit will reset the cursor as it leaves the WebView.
10
11         We use nil cursor here since we manually update the cursor by calling [NSCursor set].
12
13         * WebView/WebHTMLView.mm:
14         (-[WebHTMLView setDataSource:]): Use NSTrackingCursorUpdate option in creating the primary tracking area.
15
16 2015-03-24  Anders Carlsson  <andersca@apple.com>
17
18         Fix designated initializer violations
19         https://bugs.webkit.org/show_bug.cgi?id=143016
20         rdar://problem/20268858
21
22         Reviewed by Dan Bernstein.
23
24         Move -[WebBackForwardList initWithBackForwardList:] to the implementation instead of a category since
25         nobody calls it outside of WebBackForwardList.mm.
26
27         * History/WebBackForwardList.mm:
28         * History/WebBackForwardListInternal.h:
29
30 2015-03-23  Alexey Proskuryakov  <ap@apple.com>
31
32         REGRESSION (Yosemite): WKView visibility notifications are messed up
33         https://bugs.webkit.org/show_bug.cgi?id=142945
34
35         Reviewed by Tim Horton.
36
37         As these notifications cannot be used by NSView subclasses, create a separate
38         object for observing them.
39
40         * WebView/WebView.mm:
41         (-[WebView _commonInitializationWithFrameName:groupName:]):
42         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
43         (-[WebView addWindowObserversForWindow:]):
44         (-[WebView removeWindowObservers]):
45         (-[WebView viewWillMoveToWindow:]): Make sure that observers are removed even
46         if -[WebView close] is called manually.
47         * WebView/WebViewData.h:
48         * WebView/WebViewData.mm:
49         (-[WebWindowVisibilityObserver initWithView:]):
50         (-[WebWindowVisibilityObserver startObserving:]):
51         (-[WebWindowVisibilityObserver stopObserving:]):
52         (-[WebWindowVisibilityObserver _windowVisibilityChanged:]):
53
54 2015-03-23  Tim Horton  <timothy_horton@apple.com>
55
56         Add a share item to the link action menu
57         https://bugs.webkit.org/show_bug.cgi?id=142961
58         <rdar://problem/19198374>
59
60         Reviewed by Beth Dakin.
61
62         * WebView/WebActionMenuController.mm:
63         (-[WebActionMenuController _defaultMenuItemsForImage]):
64         (-[WebActionMenuController _defaultMenuItemsForVideo]):
65         (-[WebActionMenuController _createActionMenuItemForTag:]):
66         (-[WebActionMenuController _createShareActionMenuItemForTag:withItems:]):
67         Adopt -[NSMenuItem standardShareMenuItemWithItems].
68         All of the null-checking is unnecessary as it's impossible to enter
69         these functions with a null image/etc.
70         Also, remove a duplicate isDownloadableMedia check for the 'save to downloads' item.
71
72         (-[WebActionMenuController _defaultMenuItemsForLink]):
73         * WebView/WebUIDelegatePrivate.h:
74         Add a 'Share' item to the link menu.
75
76 2015-03-22  Alexey Proskuryakov  <ap@apple.com>
77
78         Build fix.
79
80         * WebView/WebView.mm: (-[WebView _showPlaybackTargetPicker:hasVideo:]):
81
82 2015-03-22  Eric Carlson  <eric.carlson@apple.com>
83
84         [Mac] Enable WIRELESS_PLAYBACK_TARGET for WK1
85         https://bugs.webkit.org/show_bug.cgi?id=142940
86
87         Reviewed by Sam Weinig.
88
89         * WebCoreSupport/WebChromeClient.h:
90         * WebCoreSupport/WebChromeClient.mm:
91         (WebChromeClient::showPlaybackTargetPicker): New.
92         (WebChromeClient::startingMonitoringPlaybackTargets): New.
93         (WebChromeClient::stopMonitoringPlaybackTargets): New.
94
95         * WebView/WebView.mm:
96         (-[WebView _close]): Invalidate and free the target picker.
97         (-[WebView _devicePicker]): New.
98         (-[WebView _showPlaybackTargetPicker:hasVideo:]): New.
99         (-[WebView _startingMonitoringPlaybackTargets]): New.
100         (-[WebView _stopMonitoringPlaybackTargets]): New.
101
102         * WebView/WebMediaPlaybackTargetPicker.h:
103         * WebView/WebMediaPlaybackTargetPicker.mm:
104         (WebMediaPlaybackTargetPicker::create): New.
105         (WebMediaPlaybackTargetPicker::WebMediaPlaybackTargetPicker): New.
106         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): New.
107         (WebMediaPlaybackTargetPicker::startingMonitoringPlaybackTargets): New.
108         (WebMediaPlaybackTargetPicker::stopMonitoringPlaybackTargets): New.
109         (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): New.
110         (WebMediaPlaybackTargetPicker::externalOutputDeviceAvailableDidChange): New.
111         (WebMediaPlaybackTargetPicker::invalidate): New.
112         (WebMediaPlaybackTargetPicker::targetPicker): New.
113
114         * WebView/WebViewData.h:
115         (WebMediaPlaybackTargetPicker::~WebMediaPlaybackTargetPicker):
116         * WebView/WebViewData.mm:
117         * WebView/WebViewInternal.h:
118
119 2015-03-19  Andy Estes  <aestes@apple.com>
120
121         [Content Filtering] Add tests for unblock requests
122         https://bugs.webkit.org/show_bug.cgi?id=142900
123
124         Reviewed by Andreas Kling.
125
126         * WebCoreSupport/WebFrameLoaderClient.mm:
127         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): This now happens in PolicyChecker.
128         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
129         * WebView/WebFrame.mm:
130         (-[WebFrame _contentFilterDidHandleNavigationAction:]): Deleted.
131         * WebView/WebFrameInternal.h: Removed contentFilterUnblockHandler from WebFramePrivate.
132
133 2015-03-19  Enrica Casucci  <enrica@apple.com>
134
135         <attachment> should put URLs on the pasteboard so that Finder can accept drops.
136         https://bugs.webkit.org/show_bug.cgi?id=142801
137         rdar://problem/19982527
138
139         Reviewed by Tim Horton.
140
141         This patch adds all the necessary support to write attachment elements into
142         the pasteboard, including the promised type in WK1.
143
144         * Misc/WebNSPasteboardExtras.mm:
145         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
146         * WebCoreSupport/WebDragClient.h:
147         * WebCoreSupport/WebDragClient.mm:
148         (WebDragClient::declareAndWriteAttachment):
149         * WebView/WebHTMLView.mm:
150         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
151         * WebView/WebUIDelegate.h:
152
153 2015-03-19  Chris Dumez  <cdumez@apple.com>
154
155         Clean up DOMTimer related settings
156         https://bugs.webkit.org/show_bug.cgi?id=142837
157
158         Reviewed by Darin Adler.
159
160         Stop setting the DOMTimers' default minimum interval to 4ms as this
161         is now the default.
162
163         * WebView/WebView.mm:
164         (-[WebView _commonInitializationWithFrameName:groupName:]):
165
166 2015-03-17  Conrad Shultz  <conrad_shultz@apple.com>
167
168         Ignore some deprecation warnings
169         https://bugs.webkit.org/show_bug.cgi?id=142813
170
171         Reviewed by Mark Rowe.
172
173         Fixing the deprecations is tracked by: <rdar://problem/20201450>
174
175         * WebCoreSupport/PopupMenuMac.mm:
176         (PopupMenuMac::populate):
177
178 2015-03-17  Tim Horton  <timothy_horton@apple.com>
179
180         Cannot invoke action menus anymore
181         https://bugs.webkit.org/show_bug.cgi?id=142797
182         <rdar://problem/20032670>
183
184         * WebView/WebHTMLView.mm:
185         (-[WebHTMLView otherMouseDown:]):
186         Need a respondsToSelector check.
187
188 2015-03-17  Tim Horton  <timothy_horton@apple.com>
189
190         Fix the iOS build
191
192         * WebView/WebHTMLView.mm:
193
194 2015-03-17  Tim Horton  <timothy_horton@apple.com>
195
196         Cannot invoke action menus anymore
197         https://bugs.webkit.org/show_bug.cgi?id=142797
198         <rdar://problem/20032670>
199
200         Reviewed by Beth Dakin.
201
202         * WebView/WebHTMLView.mm:
203         (-[WebHTMLView otherMouseDown:]):
204         Don't override otherMouseDown: if the event would make an action menu.
205
206 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
207
208         Enable ES6 classes by default
209         https://bugs.webkit.org/show_bug.cgi?id=142774
210
211         Reviewed by Gavin Barraclough.
212
213         * Configurations/FeatureDefines.xcconfig:
214
215 2015-03-16  Brent Fulgham  <bfulgham@apple.com>
216
217         WebKit1 Clients Are Not Reliably Repainted
218         https://bugs.webkit.org/show_bug.cgi?id=142750
219         <rdar://problem/20042453>
220
221         Reviewed by Simon Fraser.
222
223         Check with the FrameView to see if we are in an immediately paintable state. If we are not,
224         mark the view as dirty once the _immediateScrollToPoint operation is complete so that the
225         region will be painted properly.
226
227         * WebView/WebClipView.mm:
228         (-[WebClipView _immediateScrollToPoint:]): 
229
230 2015-03-16  Conrad Shultz  <conrad_shultz@apple.com>
231
232         Allow clients to selectively disable plug-ins
233         https://bugs.webkit.org/show_bug.cgi?id=142506
234
235         Reviewed by Anders Carlsson.
236
237         Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
238         from the page). As part of this:
239
240         1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying
241            set of plug-ins.
242
243         2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper
244            down the stack.
245
246         3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce
247            a concrete implementation thereof in WebPlatformStrategies in WebKit2.
248
249         4) Add messaging infrastructure to allow clients to set and clear plug-in policies.
250
251         While currently only used in a very limited manner, the new declarative plug-in policies are written generically
252         so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.
253
254         * Plugins/WebBasePluginPackage.mm:
255         (-[WebBasePluginPackage getPluginInfoFromPLists]):
256         Set new members in PluginInfo.
257
258         * Plugins/WebNetscapePluginPackage.mm:
259         (-[WebNetscapePluginPackage getPluginInfoFromResources]):
260         Set new members in PluginInfo.
261
262         * WebCoreSupport/WebPlatformStrategies.h:
263         * WebCoreSupport/WebPlatformStrategies.mm:
264         (WebPlatformStrategies::getWebVisiblePluginInfo):
265         Override to wrap getPluginInfo().
266         (WebPlatformStrategies::setPluginLoadClientPolicy):
267         Override to do nothing.
268         (WebPlatformStrategies::clearPluginClientPolicies):
269         Ditto.
270
271         * WebView/WebFrame.mm:
272         (-[WebFrame _canProvideDocumentSource]):
273         Update to reflect function rename.
274
275 2015-03-14  Dean Jackson  <dino@apple.com>
276
277         Feature flag for Animations Level 2
278         https://bugs.webkit.org/show_bug.cgi?id=142699
279         <rdar://problem/20165097>
280
281         Reviewed by Brent Fulgham.
282
283         Add ENABLE_CSS_ANIMATIONS_LEVEL_2 and a runtime flag animationTriggersEnabled.
284
285         * Configurations/FeatureDefines.xcconfig:
286
287 2015-03-13  Commit Queue  <commit-queue@webkit.org>
288
289         Unreviewed, rolling out r181483.
290         https://bugs.webkit.org/show_bug.cgi?id=142688
291
292         Caused use-after-free on many tests (Requested by ap on
293         #webkit).
294
295         Reverted changeset:
296
297         "Allow clients to selectively disable plug-ins"
298         https://bugs.webkit.org/show_bug.cgi?id=142506
299         http://trac.webkit.org/changeset/181483
300
301 2015-03-13  Eric Carlson  <eric.carlson@apple.com>
302
303         [Mac] Enable WIRELESS_PLAYBACK_TARGET
304         https://bugs.webkit.org/show_bug.cgi?id=142635
305
306         Reviewed by Darin Adler.
307
308         * Configurations/FeatureDefines.xcconfig:
309
310 2015-03-10  Conrad Shultz  <conrad_shultz@apple.com>
311
312         Allow clients to selectively disable plug-ins
313         https://bugs.webkit.org/show_bug.cgi?id=142506
314
315         Reviewed by Anders Carlsson.
316
317         Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
318         from the page). As part of this:
319
320         1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying
321            set of plug-ins.
322
323         2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper
324            down the stack.
325
326         3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce
327            a concrete implementation thereof in WebPlatformStrategies in WebKit2.
328
329         4) Add messaging infrastructure to allow clients to set and clear plug-in policies.
330
331         While currently only used in a very limited manner, the new declarative plug-in policies are written generically
332         so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.
333
334         * Plugins/WebBasePluginPackage.mm:
335         (-[WebBasePluginPackage getPluginInfoFromPLists]):
336         Set new members in PluginInfo.
337
338         * Plugins/WebNetscapePluginPackage.mm:
339         (-[WebNetscapePluginPackage getPluginInfoFromResources]):
340         Set new members in PluginInfo.
341
342         * WebCoreSupport/WebPlatformStrategies.h:
343         * WebCoreSupport/WebPlatformStrategies.mm:
344         (WebPlatformStrategies::getWebVisiblePluginInfo):
345         Override to wrap getPluginInfo().
346         (WebPlatformStrategies::setPluginLoadClientPolicy):
347         Override to do nothing.
348         (WebPlatformStrategies::clearPluginClientPolicies):
349         Ditto.
350
351         * WebView/WebFrame.mm:
352         (-[WebFrame _canProvideDocumentSource]):
353         Update to reflect function rename.
354
355 2015-03-10  Sam Weinig  <sam@webkit.org>
356
357         Allow adding a button in input elements for auto fill related functionality
358         <rdar://problem/19782066>
359         https://bugs.webkit.org/show_bug.cgi?id=142564
360
361         Reviewed by Anders Carlsson.
362
363         * DOM/WebDOMOperations.mm:
364         (-[DOMHTMLInputElement _setAutofilled:]):
365         Update for consistent spelling of AutoFill.
366
367 2015-03-10  Timothy Horton  <timothy_horton@apple.com>
368
369         Fix the build
370
371         * History/WebHistory.mm:
372         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
373         * WebCoreSupport/WebFrameLoaderClient.mm:
374         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
375
376 2015-03-10  Tim Horton  <timothy_horton@apple.com>
377
378         Fix the Mac build with a newer compiler
379
380         * Plugins/WebPluginController.mm:
381         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
382         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
383
384 2015-03-09  David Kilzer  <ddkilzer@apple.com>
385
386         [iOS] Fix build when compiling with dead code stripping disabled
387         <http://webkit.org/b/142467>
388
389         Reviewed by Simon Fraser.
390
391         * Configurations/WebKitLegacy.xcconfig:
392         (EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*]): Disable mig code
393         generation and compilation for out-of-process plugin support.
394         This was never used on iOS.
395
396 2015-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
397
398         [iOS] SVG fonts are garbled
399         https://bugs.webkit.org/show_bug.cgi?id=142377
400
401         Reviewed by Simon Fraser.
402
403         * Configurations/FeatureDefines.xcconfig:
404
405 2015-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
406
407         Hide Promise with runtime flags under Cocoa JSContext API
408         https://bugs.webkit.org/show_bug.cgi?id=141965
409
410         Reviewed by Filip Pizlo.
411
412         Add new JSC runtime flag, PromiseDisabled.
413
414         * WebView/WebPreferencesPrivate.h:
415
416 2015-03-03  Andy Estes  <aestes@apple.com>
417
418         [Content Filtering] Separate unblock handling into its own class
419         https://bugs.webkit.org/show_bug.cgi?id=142251
420
421         Reviewed by Andreas Kling.
422         
423         Adopted ContentFilterUnblockHandler.
424
425         * WebCoreSupport/WebFrameLoaderClient.h:
426         * WebCoreSupport/WebFrameLoaderClient.mm:
427         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
428         * WebView/WebFrame.mm:
429         (-[WebFrame _contentFilterDidHandleNavigationAction:]):
430         * WebView/WebFrameInternal.h:
431
432 2015-03-03  Chris Dumez  <cdumez@apple.com>
433
434         Access ApplicationCacheStorage global instance via singleton() static member function
435         https://bugs.webkit.org/show_bug.cgi?id=142239
436
437         Reviewed by Anders Carlsson.
438
439         Access ApplicationCacheStorage global instance via singleton() static
440         member function as per WebKit coding style.
441
442 2015-03-02  Jer Noble  <jer.noble@apple.com>
443
444         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
445         https://bugs.webkit.org/show_bug.cgi?id=142121
446
447         Reviewed by Simon Fraser.
448
449         Fullscreening a page with a non-1 scale would result in that scale being applied to the
450         fullscreen content, breaking fullscreen mode. Set the page scale to 1 when entering
451         fullscreen and reset it to the original value when exiting fullscreen.
452
453         * WebView/WebFullScreenController.h:
454         * WebView/WebFullScreenController.mm:
455         (-[WebFullScreenController enterFullScreen:]): Set the page scale to 1.
456         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Reset the page
457                 scale to the original value.
458         * WebView/WebView.mm:
459         (-[WebView _supportsFullScreenForElement:withKeyboard:]): Drive-by fix. Check the
460                 WebView's own preferences to see if fullscreen mode is enabled, rather than
461                 the global object's.
462
463 2015-03-01  Chris Dumez  <cdumez@apple.com>
464
465         Make NotificationCenter / Notification suspendable
466         https://bugs.webkit.org/show_bug.cgi?id=142117
467         <rdar://problem/19923085>
468
469         Reviewed by Andreas Kling.
470
471         Provide implementation for NotificationClient::hasPendingPermissionRequests().
472         The implementation is very simplistic. it will only return false if no
473         request for permission for ever made. This is because there is currently no
474         easy way to figure out if a permission request is pending or not.
475
476         * WebCoreSupport/WebNotificationClient.h:
477         * WebCoreSupport/WebNotificationClient.mm:
478         (WebNotificationClient::requestPermission):
479         (WebNotificationClient::hasPendingPermissionRequests):
480
481 2015-02-28  Simon Fraser  <simon.fraser@apple.com>
482
483         Viewport units should not dirty style just before we do layout
484         https://bugs.webkit.org/show_bug.cgi?id=141682
485
486         Reviewed by Zalan Bujtas.
487
488         * WebView/WebFrameView.mm:
489         (-[WebFrameView _frameSizeChanged]):
490
491 2015-02-26  Chris Dumez  <cdumez@apple.com>
492
493         Rename DatabaseManager::manager() to DatabaseManager::singleton()
494         https://bugs.webkit.org/show_bug.cgi?id=142054
495
496         Reviewed by Ryosuke Niwa.
497
498         Rename DatabaseManager::manager() to DatabaseManager::singleton() as
499         per coding style and use WTF::NeverDestroyed.
500
501         * Storage/WebDatabaseManager.mm:
502         (-[WebDatabaseManager init]):
503         (-[WebDatabaseManager origins]):
504         (-[WebDatabaseManager databasesWithOrigin:]):
505         (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
506         (-[WebDatabaseManager deleteAllDatabases]):
507         (-[WebDatabaseManager deleteOrigin:]):
508         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
509         * Storage/WebDatabaseQuotaManager.mm:
510         (-[WebDatabaseQuotaManager usage]):
511         (-[WebDatabaseQuotaManager quota]):
512         (-[WebDatabaseQuotaManager setQuota:]):
513         * WebCoreSupport/WebSecurityOrigin.mm:
514         (-[WebSecurityOrigin usage]):
515         (-[WebSecurityOrigin quota]):
516         (-[WebSecurityOrigin setQuota:]):
517         * WebView/WebFrame.mm:
518         (-[WebFrame _cacheabilityDictionary]):
519         * WebView/WebView.mm:
520         (-[WebView _preferencesChanged:]):
521
522 2015-02-26  Myles C. Maxfield  <mmaxfield@apple.com>
523
524         [Mac] [iOS] Parsing support for -apple-trailing-word
525         https://bugs.webkit.org/show_bug.cgi?id=141939
526
527         Reviewed by Andreas Kling.
528
529         * Configurations/FeatureDefines.xcconfig:
530
531 2015-02-24  Commit Queue  <commit-queue@webkit.org>
532
533         Unreviewed, rolling out r180599.
534         https://bugs.webkit.org/show_bug.cgi?id=141998
535
536         Lots of new test failures (Requested by smfr on #webkit).
537
538         Reverted changeset:
539
540         "Parsing support for -webkit-trailing-word"
541         https://bugs.webkit.org/show_bug.cgi?id=141939
542         http://trac.webkit.org/changeset/180599
543
544 2015-02-24  Myles C. Maxfield  <mmaxfield@apple.com>
545
546         [Mac] [iOS] Parsing support for -apple-trailing-word
547         https://bugs.webkit.org/show_bug.cgi?id=141939
548
549         Reviewed by Andreas Kling.
550
551         * Configurations/FeatureDefines.xcconfig:
552
553 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
554
555         REGRESSION(r179429): Can't type comments in Facebook
556         https://bugs.webkit.org/show_bug.cgi?id=141859
557
558         Reviewed by Brent Fulgham.
559
560         Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
561         Private API, javaScriptExperimentsEnabled is dropped.
562
563         * Misc/WebNSDictionaryExtras.h:
564         * Misc/WebNSDictionaryExtras.m:
565         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
566         * WebKit.order:
567         * WebView/WebPreferenceKeysPrivate.h:
568         * WebView/WebPreferences.mm:
569         (+[WebPreferences initialize]):
570         (-[WebPreferences _setUnsignedIntValue:forKey:]):
571         (-[WebPreferences javaScriptRuntimeFlags]):
572         (-[WebPreferences setJavaScriptRuntimeFlags:]):
573         (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
574         (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
575         * WebView/WebPreferencesPrivate.h:
576         * WebView/WebView.mm:
577         (-[WebView _preferencesChanged:]):
578
579 2015-02-23  Commit Queue  <commit-queue@webkit.org>
580
581         Unreviewed, rolling out r180547 and r180550.
582         https://bugs.webkit.org/show_bug.cgi?id=141957
583
584         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
585
586         Reverted changesets:
587
588         "REGRESSION(r179429): Can't type comments in Facebook"
589         https://bugs.webkit.org/show_bug.cgi?id=141859
590         http://trac.webkit.org/changeset/180547
591
592         "Constructor returning null should construct an object instead
593         of null"
594         https://bugs.webkit.org/show_bug.cgi?id=141640
595         http://trac.webkit.org/changeset/180550
596
597 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
598
599         Disable font loading events until our implementation gets updated to match the latest spec
600         https://bugs.webkit.org/show_bug.cgi?id=141938
601
602         Reviewed by Andreas Kling.
603
604         * Configurations/FeatureDefines.xcconfig:
605
606 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
607
608         REGRESSION(r179429): Can't type comments in Facebook
609         https://bugs.webkit.org/show_bug.cgi?id=141859
610
611         Reviewed by Geoffrey Garen.
612
613         Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
614         Private API, javaScriptExperimentsEnabled is dropped.
615
616         * Misc/WebNSDictionaryExtras.h:
617         * Misc/WebNSDictionaryExtras.m:
618         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
619         * WebKit.order:
620         * WebView/WebPreferenceKeysPrivate.h:
621         * WebView/WebPreferences.mm:
622         (+[WebPreferences initialize]):
623         (-[WebPreferences _setUnsignedIntValue:forKey:]):
624         (-[WebPreferences javaScriptRuntimeFlags]):
625         (-[WebPreferences setJavaScriptRuntimeFlags:]):
626         (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
627         (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
628         * WebView/WebPreferencesPrivate.h:
629         * WebView/WebView.mm:
630         (-[WebView _preferencesChanged:]):
631
632 2015-02-20  Eric Carlson  <eric.carlson@apple.com>
633
634         [iOS] cleanup AirPlay code
635         https://bugs.webkit.org/show_bug.cgi?id=141811
636
637         Reviewed by Jer Noble.
638
639         * Configurations/FeatureDefines.xcconfig: IOS_AIRPLAY -> WIRELESS_PLAYBACK_TARGET.
640
641 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
642
643         Adopt WebCore::IOSurface in ImageBuffer
644         https://bugs.webkit.org/show_bug.cgi?id=141751
645
646         Reviewed by Simon Fraser.
647
648         * WebCoreSupport/WebSystemInterface.mm:
649         (InitWebCoreSystemInterface):
650         Remove old WKSI IOSurface-related functions.
651
652 2015-02-18  Commit Queue  <commit-queue@webkit.org>
653
654         Unreviewed, rolling out r180286.
655         https://bugs.webkit.org/show_bug.cgi?id=141766
656
657         Caused >50 crashed LayoutTests (Requested by jernoble on
658         #webkit).
659
660         Reverted changeset:
661
662         "Page::userContentController() should return a reference, not
663         a pointer"
664         https://bugs.webkit.org/show_bug.cgi?id=141764
665         http://trac.webkit.org/changeset/180286
666
667 2015-02-18  Brady Eidson  <beidson@apple.com>
668
669         Page::userContentController() should return a reference, not a pointer
670         https://bugs.webkit.org/show_bug.cgi?id=141764
671
672         Reviewed by Jer Noble.
673
674         * WebView/WebView.mm:
675         (-[WebView setGroupName:]):
676
677 2015-02-18  Chris Dumez  <cdumez@apple.com>
678
679         Access FontCache global instance via singleton() static member function
680         https://bugs.webkit.org/show_bug.cgi?id=141726
681
682         Reviewed by Daniel Bates.
683
684         Access FontCache global instance via singleton() static member function,
685         as per coding style.
686
687 2015-02-17  Chris Dumez  <cdumez@apple.com>
688
689         Access MemoryPressureHandler global instance via a singleton() static member function
690         https://bugs.webkit.org/show_bug.cgi?id=141691
691
692         Reviewed by Andreas Kling.
693
694         Access MemoryPressureHandler global instance via a singleton() static
695         member function.
696
697         * WebView/WebView.mm:
698         (-[WebView _commonInitializationWithFrameName:groupName:]):
699         (+[WebView registerForMemoryNotifications]):
700         (+[WebView _isUnderMemoryPressure]):
701         (+[WebView _clearMemoryPressure]):
702         (+[WebView _shouldWaitForMemoryClearMessage]):
703         (WebInstallMemoryPressureHandler):
704
705 2015-02-15  Sam Weinig  <sam@webkit.org>
706
707         Add experimental <attachment> element support
708         https://bugs.webkit.org/show_bug.cgi?id=141626
709
710         Reviewed by Tim Horton.
711
712         * Configurations/FeatureDefines.xcconfig:
713
714 2015-02-14  Joseph Pecoraro  <pecoraro@apple.com>
715
716         [Mac] Possible DDActionContext leaks, RetainPtr cleanup
717         https://bugs.webkit.org/show_bug.cgi?id=141613
718
719         Reviewed by Tim Horton.
720
721         * WebCoreSupport/WebEditorClient.mm:
722         (WebEditorClient::WebEditorClient):
723         Avoid unnecessary retain/autorelease by adopting.
724
725         * WebView/WebActionMenuController.mm:
726         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
727         Adopt the allocated object.
728
729 2015-02-09  Brian J. Burg  <burg@cs.washington.edu>
730
731         Web Inspector: remove some unnecessary Inspector prefixes from class names in Inspector namespace
732         https://bugs.webkit.org/show_bug.cgi?id=141372
733
734         Reviewed by Joseph Pecoraro.
735
736         * WebCoreSupport/WebInspectorClient.mm:
737         (-[WebInspectorWindowController destroyInspectorView:]):
738
739 2015-02-14  Alexey Proskuryakov  <ap@apple.com>
740
741         rel="noreferrer" should make window.opener null
742         https://bugs.webkit.org/show_bug.cgi?id=141579
743
744         Reviewed by Darin Adler.
745
746         * WebView/WebPDFView.mm:
747         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Updated for a new WebCore
748         function signature. There is no rel="noreferrer" in PDF, so we can just always allow.
749
750 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
751
752         [Streams API] Implement a barebone ReadableStream interface
753         https://bugs.webkit.org/show_bug.cgi?id=141045
754
755         Reviewed by Benjamin Poulain.
756
757         * Configurations/FeatureDefines.xcconfig:
758
759 2015-02-03  Enrica Casucci  <enrica@apple.com>
760
761         [iOS] Add support for deleteFromInputWithFlags.
762         https://bugs.webkit.org/show_bug.cgi?id=141216
763         rdar://problem/19130081
764
765         Reviewed by Benjamin Poulain.
766
767         Adopts the new method as soon as it is available.
768         The patch also removes some obsolete code used for staging.
769
770         * WebView/WebHTMLView.mm:
771         (-[WebHTMLView _handleEditingKeyEvent:]):
772
773 2015-02-02  Chris Dumez  <cdumez@apple.com>
774
775         Access MemoryCache singleton using MemoryCache::singleton()
776         https://bugs.webkit.org/show_bug.cgi?id=141104
777
778         Reviewed by Andreas Kling.
779
780         Access MemoryCache singleton using MemoryCache::singleton() static
781         member function, instead of a free function, as per the recent
782         coding style discussion on WebKit-dev.
783
784 2015-02-01  Chris Dumez  <cdumez@apple.com>
785
786         Use more references in HistoryItem
787         https://bugs.webkit.org/show_bug.cgi?id=141133
788
789         Reviewed by Andreas Kling.
790
791         Use more references in HistoryItem instead of pointers.
792
793 2015-01-31  Sam Weinig  <sam@webkit.org>
794
795         Remove even more Mountain Lion support
796         https://bugs.webkit.org/show_bug.cgi?id=141124
797
798         Reviewed by Alexey Proskuryakov.
799
800         * Configurations/Base.xcconfig:
801         * Configurations/DebugRelease.xcconfig:
802         * Configurations/FeatureDefines.xcconfig:
803         * Configurations/Version.xcconfig:
804         * Configurations/WebKitLegacy.xcconfig:
805
806 2015-01-30  Eric Carlson  <eric.carlson@apple.com>
807
808         Remove MediaPlayerProxy.h
809         https://bugs.webkit.org/show_bug.cgi?id=141087
810
811         Reviewed by Sam Weinig.
812
813         * MigrateHeaders.make: Don't need to copy MediaPlayerProxy.h.
814         * Plugins/WebPluginController.mm: Don't include MediaPlayerProxy.h.
815
816 2015-01-30  Chris Dumez  <cdumez@apple.com>
817
818         Rename shared() static member functions to singleton() for singleton classes.
819         https://bugs.webkit.org/show_bug.cgi?id=141088
820
821         Reviewed by Ryosuke Niwa and Benjamin Poulain.
822
823         Rename shared() static member functions to singleton() for singleton
824         classes as per the recent coding style change.
825
826 2015-01-29  Beth Dakin  <bdakin@apple.com>
827
828         Remove more Mountain Lion code from WebKit
829         https://bugs.webkit.org/show_bug.cgi?id=141050
830
831         Reviewed by Anders Carlsson.
832
833         * History/WebHistory.mm:
834         (getDayBoundaries):
835         * Panels/WebAuthenticationPanel.m:
836         (-[WebAuthenticationPanel cancel:]):
837         (-[WebAuthenticationPanel logIn:]):
838         (-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]):
839         * WebCoreSupport/WebSystemInterface.mm:
840         (InitWebCoreSystemInterface):
841         * WebView/WebFrameView.mm:
842         * WebView/WebPreferences.mm:
843         (+[WebPreferences initialize]):
844         (needsScreenFontsEnabledQuirk):
845         * WebView/WebView.mm:
846         (+[WebView registerForMemoryNotifications]):
847         (-[WebView _preferencesChanged:]):
848         (+[WebView initialize]):
849         (+[WebView _shouldAutomaticQuoteSubstitutionBeEnabled]):
850         (+[WebView _shouldAutomaticDashSubstitutionBeEnabled]):
851         (+[WebView _didChangeAutomaticDashSubstitutionEnabled:]):
852
853 2015-01-29  Sam Weinig  <sam@webkit.org>
854
855         Remove support for screen font substitution
856         https://bugs.webkit.org/show_bug.cgi?id=141038
857
858         Reviewed by Tim Horton.
859
860         * Misc/WebKitNSStringExtras.mm:
861         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
862         (-[NSString _web_widthWithFont:]):
863         * Misc/WebStringTruncator.mm:
864         (fontFromNSFont):
865         Update for new signature of the FontPlatformData constructor, which no longer cares about
866         whether to use printer fonts.
867
868         * WebView/WebPreferenceKeysPrivate.h:
869         Remove the WebKitScreenFontSubstitutionEnabledKey key.
870
871         * WebView/WebPreferences.mm:
872         (+[WebPreferences initialize]):
873         Remove support for WebKitScreenFontSubstitutionEnabledKey.
874
875         (needsScreenFontsEnabledQuirk): Deleted.
876         Remove support for the Mountain Lion era 1-Password quirk.
877
878         (-[WebPreferences screenFontSubstitutionEnabled]): Deleted.
879         (-[WebPreferences setScreenFontSubstitutionEnabled:]): Deleted.
880         * WebView/WebPreferencesPrivate.h:
881         * WebView/WebView.mm:
882         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
883         (-[WebView _preferencesChanged:]):
884         Remove support for the screen font substitution setting.
885
886 2015-01-29  Chris Dumez  <cdumez@apple.com>
887
888         Clean up / modernize PageCache class
889         https://bugs.webkit.org/show_bug.cgi?id=141009
890
891         Reviewed by Darin Adler.
892
893         Clean up / modernize PageCache class.
894
895         * History/WebBackForwardList.mm:
896         (-[WebBackForwardList pageCacheSize]):
897         * WebView/WebView.mm:
898         (-[WebView _loadBackForwardListFromOtherView:]):
899         (-[WebView goToBackForwardItem:]):
900         (+[WebView _setCacheModel:]):
901
902 2015-01-28  Beth Dakin  <bdakin@apple.com>
903
904         Remove Mountain Lion code from WebKit and WebKit2
905         https://bugs.webkit.org/show_bug.cgi?id=141010
906
907         Reviewed by Sam Weinig.
908
909         * DOM/WebDOMOperations.mm:
910         (toNSEventPhase):
911         * WebView/WebHTMLView.mm:
912         (isQuickLookEvent):
913
914 2015-01-28  Dana Burkart  <dburkart@apple.com>
915
916         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
917         https://bugs.webkit.org/show_bug.cgi?id=136765
918
919         Reviewed by Alexey Proskuryakov.
920
921         * Configurations/Base.xcconfig:
922         * Configurations/DebugRelease.xcconfig:
923
924 2015-01-28  Chris Dumez  <cdumez@apple.com>
925
926         Fix typo in markPagesForVistedLinkStyleRecalc()
927         https://bugs.webkit.org/show_bug.cgi?id=140977
928
929         Reviewed by Darin Adler.
930
931         * WebCoreSupport/WebVisitedLinkStore.mm:
932         (WebVisitedLinkStore::removeAllVisitedLinks):
933         (WebVisitedLinkStore::removeVisitedLink):
934         (WebVisitedLinkStore::addVisitedLinkHash):
935
936 2015-01-28  Chris Dumez  <cdumez@apple.com>
937
938         Rename pageCache() to PageCache::shared() and return a reference
939         https://bugs.webkit.org/show_bug.cgi?id=140983
940
941         Reviewed by Andreas Kling.
942
943         Rename pageCache() to PageCache::shared() as this is a singleton class
944         and have it return a reference instead of a pointer.
945
946         * History/WebBackForwardList.mm:
947         (-[WebBackForwardList pageCacheSize]):
948         * Misc/WebCoreStatistics.mm:
949         (+[WebCoreStatistics cachedPageCount]):
950         (+[WebCoreStatistics cachedFrameCount]):
951         * WebCoreSupport/WebVisitedLinkStore.mm:
952         (WebVisitedLinkStore::removeAllVisitedLinks):
953         (WebVisitedLinkStore::removeVisitedLink):
954         (WebVisitedLinkStore::addVisitedLinkHash):
955         * WebView/WebView.mm:
956         (+[WebView _setCacheModel:]):
957
958 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
959
960         More build fixes for newer clang.
961
962         Rubber-stamped by Anders Carlsson.
963
964         Marked a deprecated accessibility method as such.
965
966         * WebView/WebFrame.mm:
967         (-[WebFrame accessibilityRoot]):
968
969 2015-01-27  Beth Dakin  <bdakin@apple.com>
970
971         Immediate action gesture recognizer still doesn't work well with IB
972         https://bugs.webkit.org/show_bug.cgi?id=140967
973         -and corresponding-
974         rdar://problem/19621509
975
976         Reviewed by Tim Horton.
977
978         We should add (or remove) the gesture recognizer in viewDidMoveToWindow because 
979         initWithFrame it too early and IB might mess with it.
980         * WebView/WebImmediateActionController.h:
981         * WebView/WebImmediateActionController.mm:
982         (-[WebImmediateActionController immediateActionRecognizer]):
983         * WebView/WebView.mm:
984         (-[WebView _commonInitializationWithFrameName:groupName:]):
985         (-[WebView viewDidMoveToWindow]):
986
987 2015-01-27  Dan Bernstein  <mitz@apple.com>
988
989         Fixed building projects that import WebView.h with WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS.
990
991         Rubber-stamped by Anders Carlsson.
992
993         * WebView/WebView.h: Added forward declarations of the protocols.
994
995 2015-01-26  Anders Carlsson  <andersca@apple.com>
996
997         Make it easy to test enabling formal delegate protocols
998         https://bugs.webkit.org/show_bug.cgi?id=140892
999
1000         Reviewed by Dan Bernstein.
1001
1002         Add an WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS define that controls whether delegates should be formal protocols.
1003
1004         * Misc/WebDownload.h:
1005         * WebView/WebFrameLoadDelegate.h:
1006         * WebView/WebPolicyDelegate.h:
1007         * WebView/WebResourceLoadDelegate.h:
1008         * WebView/WebUIDelegate.h:
1009         * WebView/WebView.h:
1010
1011 2015-01-26  Chris Dumez  <cdumez@apple.com>
1012
1013         Rename Document::body() to Document::bodyOrFrameset() for clarity
1014         https://bugs.webkit.org/show_bug.cgi?id=140902
1015
1016         Reviewed by Andreas Kling.
1017
1018         Rename Document::body() to Document::bodyOrFrameset() for clarity. This
1019         method does not necessarily return an HTMLBodyElement, it can also
1020         return a frameset as per the specification:
1021         http://www.w3.org/TR/html5/dom.html#dom-tree-accessors
1022
1023         This method is often misused internally (the caller is only interested
1024         in the <body> element). I will fix these instances in a follow-up patch,
1025         this patch is only renaming mechanically.
1026
1027 2015-01-26  Chris Dumez  <cdumez@apple.com>
1028
1029         First argument to DOM traversal functions should be a reference
1030         https://bugs.webkit.org/show_bug.cgi?id=140895
1031
1032         Reviewed by Antti Koivisto.
1033
1034         First argument to DOM traversal functions should be a reference instead
1035         of a pointer as it is dereferenced without null-check.
1036
1037 2015-01-26  Myles C. Maxfield  <mmaxfield@apple.com>
1038
1039         [iOS] [SVG -> OTF Converter] Flip the switch off on iOS
1040         https://bugs.webkit.org/show_bug.cgi?id=140860
1041
1042         Reviewed by Darin Adler.
1043
1044         The fonts it makes are grotesque. (See what I did there? Typographic
1045         humor is the best humor.)
1046
1047         * Configurations/FeatureDefines.xcconfig:
1048
1049 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
1050
1051         QLPreviewMenuItem popovers don't close when the page scrolls
1052         https://bugs.webkit.org/show_bug.cgi?id=140806
1053         <rdar://problem/19555618>
1054
1055         Reviewed by Beth Dakin.
1056
1057         Now that QLPreviewMenuItem's popover doesn't eat scrolls, we need to dismiss it if the page scrolls.
1058
1059         * WebView/WebHTMLView.mm:
1060         (-[WebHTMLView scrollWheel:scrollWheel:]):
1061         Send scrollWheel along to WebImmediateActionController.
1062
1063         * WebView/WebImmediateActionController.h:
1064         * WebView/WebImmediateActionController.mm:
1065         (-[WebImmediateActionController webView:didHandleScrollWheel:]):
1066         (-[WebImmediateActionController _clearImmediateActionState]):
1067         (-[WebImmediateActionController _defaultAnimationController]):
1068         Keep track of the active QLPreviewMenuItem, and close it upon scroll.
1069
1070 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
1071
1072         Infinite recursion in _clearImmediateActionState
1073         https://bugs.webkit.org/show_bug.cgi?id=140807
1074         <rdar://problem/19571601>
1075
1076         Reviewed by Anders Carlsson.
1077
1078         * WebView/WebImmediateActionController.mm:
1079         (-[WebImmediateActionController _clearImmediateActionState]):
1080         Use this opportunity to bring identical code to WebKit1, to avoid
1081         getting DataDetectors stuck when an immediate action is canceled.
1082
1083 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1084
1085         Add a build flag for ES6 class syntax
1086         https://bugs.webkit.org/show_bug.cgi?id=140760
1087
1088         Reviewed by Michael Saboff.
1089
1090         * Configurations/FeatureDefines.xcconfig:
1091
1092 2015-01-22  Beth Dakin  <bdakin@apple.com>
1093
1094         ibtoold crash below -[WebView close]
1095         https://bugs.webkit.org/show_bug.cgi?id=140782
1096         -and corresponding-
1097         rdar://problem/19558472
1098
1099         Reviewed by Tim Horton.
1100
1101         Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but 
1102         it is because interface builder is messing with our views.
1103         * WebView/WebImmediateActionController.h:
1104         * WebView/WebImmediateActionController.mm:
1105         (-[WebImmediateActionController webViewClosed]):
1106         (-[WebImmediateActionController _cancelImmediateAction]):
1107         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1108         (-[WebImmediateActionController _updateImmediateActionItem]):
1109
1110 2015-01-21  Beth Dakin  <bdakin@apple.com>
1111
1112         Crash in QuickLook preview delegate method
1113         https://bugs.webkit.org/show_bug.cgi?id=140740
1114         -and corresponding-
1115         rdar://problem/19540806
1116
1117         Reviewed by Tim Horton.
1118
1119         Clear out the delegate.
1120         * WebView/WebImmediateActionController.mm:
1121         (-[WebImmediateActionController webViewClosed]):
1122
1123 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
1124
1125         Remove ENABLE(INSPECTOR) ifdef guards
1126         https://bugs.webkit.org/show_bug.cgi?id=140668
1127
1128         Reviewed by Darin Adler.
1129
1130         * Configurations/FeatureDefines.xcconfig:
1131         * WebCoreSupport/WebFrameLoaderClient.mm:
1132         (WebFrameLoaderClient::dispatchWillSendRequest):
1133
1134 2015-01-20  Anders Carlsson  <andersca@apple.com>
1135
1136         Remove USE(GLIB) code from WebKit1
1137         https://bugs.webkit.org/show_bug.cgi?id=140714
1138
1139         Reviewed by Andreas Kling.
1140
1141         * WebView/WebView.mm:
1142         (-[WebView _commonInitializationWithFrameName:groupName:]):
1143         (-[WebView _close]):
1144         (-[WebView _clearGlibLoopObserver]): Deleted.
1145         (glibContextIterationCallback): Deleted.
1146         (-[WebView _scheduleGlibContextIterations]): Deleted.
1147         * WebView/WebViewData.h:
1148         * WebView/WebViewInternal.h:
1149
1150 2015-01-20  David Kilzer  <ddkilzer@apple.com>
1151
1152         Switch to comparing PLATFORM_NAME in terms of macosx
1153         <http://webkit.org/b/139516>
1154
1155         Reviewed by Timothy Hatcher.
1156
1157         * MigrateHeaders.make:
1158         * postprocess-headers.sh:
1159
1160 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1161
1162         [SVG -> OTF Converter] Flip the switch on
1163         https://bugs.webkit.org/show_bug.cgi?id=140592
1164
1165         Reviewed by Antti Koivisto.
1166
1167         * Configurations/FeatureDefines.xcconfig:
1168
1169 2015-01-19  Beth Dakin  <bdakin@apple.com>
1170
1171         Speculative build fix.
1172
1173         * WebView/WebView.mm:
1174         (-[WebView _commonInitializationWithFrameName:groupName:]):
1175
1176 2015-01-19  Beth Dakin  <bdakin@apple.com>
1177
1178         Speculative build fix.
1179
1180         * WebView/WebView.mm:
1181         (-[WebView _convertRectFromRootView:]):
1182
1183 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
1184
1185         Adjust naming of action menu SPI
1186         https://bugs.webkit.org/show_bug.cgi?id=140644
1187         <rdar://problem/19448129>
1188
1189         Reviewed by Brian Weinstein.
1190
1191         * WebView/WebActionMenuController.mm:
1192         (-[WebActionMenuController prepareForMenu:withEvent:]):
1193         (-[WebActionMenuController willOpenMenu:withEvent:]):
1194         (-[WebActionMenuController didCloseMenu:withEvent:]):
1195         * WebView/WebView.mm:
1196         (-[WebView _commonInitializationWithFrameName:groupName:]):
1197         (-[WebView prepareForMenu:withEvent:]):
1198         (-[WebView willOpenMenu:withEvent:]):
1199         (-[WebView didCloseMenu:withEvent:]):
1200
1201 2015-01-19  Beth Dakin  <bdakin@apple.com>
1202
1203         REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is 
1204         offset by flipped-ness
1205         https://bugs.webkit.org/show_bug.cgi?id=140643
1206         -and corresponding-
1207         rdar://problem/19489593
1208
1209         Reviewed by Tim Horton.
1210
1211         We universally flipped because we assumed that the root view was flipped and the 
1212         WebView was not. However, in Dictionary, the WebView is flipped! So this patch 
1213         fixes that assumption by checking the WebView’s flipped-ness.
1214         * WebView/WebView.mm:
1215         (-[WebView _convertRectFromRootView:]):
1216
1217 2015-01-19  Commit Queue  <commit-queue@webkit.org>
1218
1219         Unreviewed, rolling out r178653.
1220         https://bugs.webkit.org/show_bug.cgi?id=140634
1221
1222         Broke multiple SVG tests on Mountain Lion (Requested by ap on
1223         #webkit).
1224
1225         Reverted changeset:
1226
1227         "[SVG -> OTF Converter] Flip the switch on"
1228         https://bugs.webkit.org/show_bug.cgi?id=140592
1229         http://trac.webkit.org/changeset/178653
1230
1231 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1232
1233         [SVG -> OTF Converter] Flip the switch on
1234         https://bugs.webkit.org/show_bug.cgi?id=140592
1235
1236         Reviewed by Antti Koivisto.
1237
1238         * Configurations/FeatureDefines.xcconfig:
1239
1240 2015-01-18  Daniel Bates  <dabates@apple.com>
1241
1242         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/178631>
1243         (https://bugs.webkit.org/show_bug.cgi?id=129441)
1244
1245         Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight().
1246         Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.
1247
1248         * WebInspector/WebNodeHighlightView.mm:
1249         (-[WebNodeHighlightView layoutSublayers:]):
1250
1251 2015-01-16  Beth Dakin  <bdakin@apple.com>
1252
1253         Make sure early cancellation of immediate action actually does that in WK1
1254         https://bugs.webkit.org/show_bug.cgi?id=140566
1255         -and corresponding-
1256         rdar://problem/19490114
1257
1258         Reviewed by Tim Horton.
1259
1260         Work around an AppKit bug by dispatching the call to _cancelImmediateAction 
1261         asynchronously.
1262         * WebView/WebImmediateActionController.mm:
1263         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1264
1265 2015-01-16  Daniel Bates  <dabates@apple.com>
1266
1267         Fix the public iOS SDK build after <http://trac.webkit.org/changeset/178285>
1268         (https://bugs.webkit.org/show_bug.cgi?id=140360)
1269
1270         Forward declare protocol NSURLDownloadDelegate as it is SPI on iOS.
1271
1272         * Misc/WebDownload.h:
1273
1274 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
1275
1276         Remove ENABLE(SQL_DATABASE) guards
1277         https://bugs.webkit.org/show_bug.cgi?id=140434
1278
1279         Reviewed by Darin Adler.
1280
1281         * Configurations/FeatureDefines.xcconfig:
1282         * Storage/WebDatabaseManager.mm:
1283         (databasesDirectoryPath):
1284         * Storage/WebDatabaseManagerClient.h:
1285         * Storage/WebDatabaseManagerClient.mm:
1286         * Storage/WebDatabaseManagerInternal.h:
1287         * Storage/WebDatabaseManagerPrivate.h:
1288         * Storage/WebDatabaseQuotaManager.mm:
1289         (-[WebDatabaseQuotaManager usage]):
1290         (-[WebDatabaseQuotaManager quota]):
1291         (-[WebDatabaseQuotaManager setQuota:]):
1292         * WebCoreSupport/WebChromeClient.h:
1293         * WebCoreSupport/WebChromeClient.mm:
1294         * WebCoreSupport/WebSecurityOrigin.mm:
1295         (-[WebSecurityOrigin usage]):
1296         (-[WebSecurityOrigin quota]):
1297         (-[WebSecurityOrigin setQuota:]):
1298         * WebView/WebFrame.mm:
1299         (-[WebFrame _cacheabilityDictionary]):
1300         * WebView/WebView.mm:
1301         (-[WebView _commonInitializationWithFrameName:groupName:]):
1302         (-[WebView _preferencesChanged:]):
1303
1304 2015-01-14  Chris Dumez  <cdumez@apple.com>
1305
1306         Make 'TypeName' parameter unnecessary in CSSPropertyNames.in
1307         https://bugs.webkit.org/show_bug.cgi?id=140347
1308
1309         Reviewed by Darin Adler.
1310
1311         Call FontDescription::setIsItalic() instead of setItalic() as the
1312         call site passes a boolean.
1313
1314         * WebView/WebHTMLView.mm:
1315         (fontNameForDescription):
1316
1317 2015-01-13  Anders Carlsson  <andersca@apple.com>
1318
1319         Temporarily reintroduce the informal delegate protocols
1320         https://bugs.webkit.org/show_bug.cgi?id=140416
1321
1322         Reviewed by Dan Bernstein.
1323
1324         * WebView/WebEditingDelegate.h:
1325         * WebView/WebFrameLoadDelegate.h:
1326         * WebView/WebPolicyDelegate.h:
1327         * WebView/WebResourceLoadDelegate.h:
1328         * WebView/WebUIDelegate.h:
1329
1330 2015-01-13  Beth Dakin  <bdakin@apple.com>
1331
1332         Should disable immediate actions for iTunes
1333         https://bugs.webkit.org/show_bug.cgi?id=140405
1334         -and corresponding-
1335         rdar://problem/19461358
1336
1337         Reviewed by Tim Horton.
1338
1339         * WebView/WebImmediateActionController.mm:
1340         (-[WebImmediateActionController _updateImmediateActionItem]):
1341
1342 2015-01-11  Sam Weinig  <sam@webkit.org>
1343
1344         Remove support for SharedWorkers
1345         https://bugs.webkit.org/show_bug.cgi?id=140344
1346
1347         Reviewed by Anders Carlsson.
1348
1349         * Configurations/FeatureDefines.xcconfig:
1350         * WebCoreSupport/WebPlatformStrategies.h:
1351         * WebCoreSupport/WebPlatformStrategies.mm:
1352         (WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
1353
1354 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
1355
1356         Get rid of unnecessary reimplementations of CGFloor/Ceiling
1357         https://bugs.webkit.org/show_bug.cgi?id=140375
1358
1359         Reviewed by Simon Fraser.
1360
1361         * Misc/WebKitNSStringExtras.mm:
1362         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
1363         (webkit_CGCeiling): Deleted.
1364         Delete unnecessary code, use the real CGFloor/Ceiling instead.
1365
1366 2015-01-12  Anders Carlsson  <andersca@apple.com>
1367
1368         Make delegates conform to formal delegate protocols
1369         https://bugs.webkit.org/show_bug.cgi?id=140370
1370
1371         Reviewed by Dan Bernstein.
1372
1373         * DefaultDelegates/WebDefaultPolicyDelegate.h:
1374         * WebCoreSupport/WebInspectorClient.mm:
1375         Add protocols to the interface declarations.
1376
1377         * WebView/WebActionMenuController.mm:
1378         (-[WebActionMenuController prepareForMenu:withEvent:]):
1379         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1380         * WebView/WebImmediateActionController.mm:
1381         (-[WebImmediateActionController _updateImmediateActionItem]):
1382         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1383         Cast to id when trying to invoke delegate methods that aren't on WebUIDelegate.
1384
1385 2015-01-12  Myles C. Maxfield  <mmaxfield@apple.com>
1386
1387         Allow targetting the SVG->OTF font converter with ENABLE(SVG_OTF_CONVERTER)
1388         https://bugs.webkit.org/show_bug.cgi?id=136769
1389
1390         Reviewed by Antti Koivisto.
1391
1392         * Configurations/FeatureDefines.xcconfig:
1393
1394 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
1395
1396         Multi-rect TextIndicators are vertically flipped in WebKit1
1397         https://bugs.webkit.org/show_bug.cgi?id=140350
1398         <rdar://problem/19441243>
1399
1400         Reviewed by Beth Dakin.
1401
1402         * WebView/WebView.mm:
1403         (-[WebView _setTextIndicator:fadeOut:]):
1404         Convert the textBoundingRect from root view to screen coordinates.
1405
1406 2015-01-12  Anders Carlsson  <andersca@apple.com>
1407
1408         Make WebResourceDelegate a formal protocol as well
1409         https://bugs.webkit.org/show_bug.cgi?id=140364
1410
1411         Reviewed by Dan Bernstein.
1412
1413         * WebView/WebResourceLoadDelegate.h:
1414
1415 2015-01-12  Anders Carlsson  <andersca@apple.com>
1416
1417         Delegates should be formal protocols
1418         https://bugs.webkit.org/show_bug.cgi?id=140360
1419         rdar://problem/17380856
1420
1421         Reviewed by Dan Bernstein.
1422
1423         This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
1424
1425         * DefaultDelegates/WebDefaultUIDelegate.h:
1426         * Misc/WebDownload.h:
1427         * WebView/WebEditingDelegate.h:
1428         * WebView/WebFrameLoadDelegate.h:
1429         * WebView/WebPolicyDelegate.h:
1430         * WebView/WebUIDelegate.h:
1431
1432 2015-01-09  Anders Carlsson  <andersca@apple.com>
1433
1434         Get rid of the database strategy
1435         https://bugs.webkit.org/show_bug.cgi?id=140322
1436
1437         Reviewed by Sam Weinig.
1438
1439         * WebCoreSupport/WebPlatformStrategies.h:
1440         * WebCoreSupport/WebPlatformStrategies.mm:
1441         (WebPlatformStrategies::createDatabaseStrategy): Deleted.
1442
1443 2015-01-08  Timothy Horton  <timothy_horton@apple.com>
1444
1445         Can't use DataDetectors after immediate action preparation
1446         https://bugs.webkit.org/show_bug.cgi?id=140263
1447         <rdar://problem/19412705>
1448
1449         Reviewed by Beth Dakin.
1450
1451         * WebView/WebImmediateActionController.mm:
1452         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1453         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1454         To match WebKit2, only call shouldUseActions if the animation is actually
1455         going to begin, not when preparing for it. This way, we're guaranteed
1456         to get a didCancel or didComplete.
1457
1458 2015-01-08  Dean Jackson  <dino@apple.com>
1459
1460         Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
1461         https://bugs.webkit.org/show_bug.cgi?id=140232
1462         <rdar://problem/19371010>
1463
1464         Reviewed by Anders Carlsson.
1465
1466         Remove the applicationChromeMode setting, but leave stubs in to make
1467         sure existing binaries don't break.
1468
1469         * WebCoreSupport/WebInspectorClient.mm:
1470         (-[WebInspectorWindowController init]):
1471         * WebView/WebPreferenceKeysPrivate.h:
1472         * WebView/WebPreferences.mm:
1473         (+[WebPreferences initialize]):
1474         (-[WebPreferences applicationChromeModeEnabled]):
1475         (-[WebPreferences setApplicationChromeModeEnabled:]):
1476         * WebView/WebView.mm:
1477         (-[WebView _preferencesChanged:]):
1478
1479 2015-01-07  Daniel Bates  <dabates@apple.com>
1480
1481         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
1482         https://bugs.webkit.org/show_bug.cgi?id=137371
1483
1484         Reviewed by David Kilzer.
1485
1486         Use SPI wrapper headers instead of directly references private SPI headers.
1487
1488         * Plugins/Hosted/NetscapePluginHostManager.mm:
1489
1490 2015-01-07  Commit Queue  <commit-queue@webkit.org>
1491
1492         Unreviewed, rolling out r178068.
1493         https://bugs.webkit.org/show_bug.cgi?id=140235
1494
1495         Breaks the iOS build (Requested by enrica on #webkit).
1496
1497         Reverted changeset:
1498
1499         "[iOS] Make WebKit2 build with public iOS SDK and more build
1500         fixes for DRT"
1501         https://bugs.webkit.org/show_bug.cgi?id=137371
1502         http://trac.webkit.org/changeset/178068
1503
1504 2015-01-07  Daniel Bates  <dabates@apple.com>
1505
1506         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
1507         https://bugs.webkit.org/show_bug.cgi?id=137371
1508
1509         Reviewed by David Kilzer.
1510
1511         Use SPI wrapper headers instead of directly references private SPI headers.
1512
1513         * Plugins/Hosted/NetscapePluginHostManager.mm:
1514
1515 2015-01-07  Beth Dakin  <bdakin@apple.com>
1516
1517         Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the 
1518         link
1519         https://bugs.webkit.org/show_bug.cgi?id=140206
1520         -and corresponding-
1521         rdar://problem/19300492
1522
1523         Reviewed by Tim Horton.
1524
1525         Providing and item frame will ensure that the original link is not obscured.
1526         * WebView/WebImmediateActionController.mm:
1527         (elementBoundingBoxInWindowCoordinatesFromNode):
1528         (-[WebImmediateActionController menuItem:itemFrameForPoint:]):
1529
1530         For now use a max size that is smaller than the WebView, with the screen’s aspect 
1531         ratio, and scaled down.
1532         (-[WebImmediateActionController menuItem:maxSizeForPoint:]):
1533
1534 2015-01-07  Anders Carlsson  <andersca@apple.com>
1535
1536         Give simple HTML documents a database provider
1537         https://bugs.webkit.org/show_bug.cgi?id=140192
1538         rdar://problem/19398825
1539
1540         Reviewed by Tim Horton.
1541
1542         * WebView/WebView.mm:
1543         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1544
1545 2015-01-06  Anders Carlsson  <andersca@apple.com>
1546
1547         Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
1548         https://bugs.webkit.org/show_bug.cgi?id=140140
1549
1550         Reviewed by Andreas Kling.
1551
1552         Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler
1553         out of WebCore since nobody else is using it.
1554
1555         * Plugins/WebNetscapePluginView.h:
1556         * Plugins/WebNetscapePluginView.mm:
1557         (-[WebNetscapePluginView _createPlugin]):
1558         (-[WebNetscapePluginView _destroyPlugin]):
1559         * Plugins/npapi.mm:
1560         (NPN_PluginThreadAsyncCall):
1561
1562 2015-01-06  Anders Carlsson  <andersca@apple.com>
1563
1564         Add a WebKit1 database provider
1565         https://bugs.webkit.org/show_bug.cgi?id=140126
1566
1567         Reviewed by Sam Weinig.
1568
1569         Set the database provider.
1570
1571         * WebView/WebView.mm:
1572         (-[WebView _commonInitializationWithFrameName:groupName:]):
1573
1574 2015-01-06  Commit Queue  <commit-queue@webkit.org>
1575
1576         Unreviewed, rolling out r177963.
1577         https://bugs.webkit.org/show_bug.cgi?id=140136
1578
1579         Caused lots of crashes (Requested by smfr on #webkit).
1580
1581         Reverted changeset:
1582
1583         "Add a WebKit1 database provider"
1584         https://bugs.webkit.org/show_bug.cgi?id=140126
1585         http://trac.webkit.org/changeset/177963
1586
1587 2015-01-06  Anders Carlsson  <andersca@apple.com>
1588
1589         Add a WebKit1 database provider
1590         https://bugs.webkit.org/show_bug.cgi?id=140126
1591
1592         Reviewed by Sam Weinig.
1593
1594         Set the database provider.
1595
1596         * WebView/WebView.mm:
1597         (-[WebView _commonInitializationWithFrameName:groupName:]):
1598
1599 2015-01-01  Jeff Miller  <jeffm@apple.com>
1600
1601         Update user-visible copyright strings to include 2015
1602         https://bugs.webkit.org/show_bug.cgi?id=139880
1603
1604         Reviewed by Darin Adler.
1605
1606         * Info.plist:
1607
1608 2014-12-30  Dan Bernstein  <mitz@apple.com>
1609
1610         [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
1611         https://bugs.webkit.org/show_bug.cgi?id=140003
1612
1613         Reviewed by Darin Adler.
1614
1615         * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
1616         that takes their "string" parameter as a "value" "parameter and has an attribute telling
1617         the compiler that if the "value" parameter is a format string then the function returns a
1618         modified version of it. The result is that if UI_STRING is used as a format string parameter
1619         to some function or method, the compiler will check the format specifiers in the string
1620         against the other parameters.
1621
1622 2014-12-29  Dan Bernstein  <mitz@apple.com>
1623
1624         Fixed the iOS build.
1625
1626         * Configurations/WebKitLegacy.xcconfig:
1627
1628 2014-12-29  Anders Carlsson  <andersca@apple.com>
1629
1630         Get rid of some PageGroup storage functions
1631         https://bugs.webkit.org/show_bug.cgi?id=139996
1632
1633         Reviewed by Sam Weinig.
1634
1635         Call WebStorageNamespaceProvider directly instead.
1636
1637         * Storage/WebStorageManager.mm:
1638         (-[WebStorageManager syncLocalStorage]):
1639         (+[WebStorageManager closeIdleLocalStorageDatabases]):
1640         * WebView/WebView.mm:
1641         (+[WebView _applicationWillTerminate]):
1642
1643 2014-12-29  Anders Carlsson  <andersca@apple.com>
1644
1645         Move storage code from WebCore to WebKit
1646         https://bugs.webkit.org/show_bug.cgi?id=139558
1647
1648         Reviewed by Darin Adler.
1649
1650         * Storage/WebStorageManager.mm:
1651         * Storage/WebStorageTrackerClient.h:
1652         * WebView/WebView.mm:
1653
1654 2014-12-26  Dan Bernstein  <mitz@apple.com>
1655
1656         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
1657         https://bugs.webkit.org/show_bug.cgi?id=139950
1658
1659         Reviewed by David Kilzer.
1660
1661         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
1662         in a manner that works with Xcode 5.1.1.
1663
1664 2014-12-23  Timothy Horton  <timothy_horton@apple.com>
1665
1666         Install a TextIndicator for link immediate actions
1667         https://bugs.webkit.org/show_bug.cgi?id=139897
1668         <rdar://problem/19333076>
1669
1670         Reviewed by Anders Carlsson.
1671
1672         * WebView/WebImmediateActionController.h:
1673         * WebView/WebImmediateActionController.mm:
1674         (-[WebImmediateActionController _clearImmediateActionState]):
1675         Tear down the TextIndicator, just like WebKit2.
1676
1677         (-[WebImmediateActionController _defaultAnimationController]):
1678         Install a TextIndicator for links.
1679
1680         (-[WebImmediateActionController menuItemDidClose:]):
1681         Tear down the TextIndicator when the QL preview closes.
1682
1683         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1684         Directly install and uninstall the TextIndicator for DataDetectors.
1685
1686         (-[WebImmediateActionController _showTextIndicator]): Deleted.
1687         (-[WebImmediateActionController _hideTextIndicator]): Deleted.
1688         Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
1689
1690 2014-12-20  Eric Carlson  <eric.carlson@apple.com>
1691
1692         [iOS] add optimized fullscreen API
1693         https://bugs.webkit.org/show_bug.cgi?id=139833
1694         <rdar://problem/18844486>
1695
1696         Reviewed by Simon Fraser.
1697
1698         * Configurations/FeatureDefines.xcconfig:  Add ENABLE_VIDEO_PRESENTATION_MODE.
1699
1700 2014-12-20  David Kilzer  <ddkilzer@apple.com>
1701
1702         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
1703         <http://webkit.org/b/139463>
1704
1705         Reviewed by Mark Rowe.
1706
1707         * Configurations/Base.xcconfig:
1708         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
1709           on OS X.
1710         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
1711         * Configurations/DebugRelease.xcconfig:
1712         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
1713         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
1714         * Configurations/Version.xcconfig:
1715         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
1716         * Configurations/WebKitLegacy.xcconfig:
1717         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
1718           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
1719           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
1720           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
1721           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
1722           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
1723           WEBCORE_PRIVATE_HEADERS_DIR_Production and
1724           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
1725           based on SDK.
1726         - Fix PRODUCTION_ROOT to actually be set properly.
1727         - Simplify EXPORTED_SYMBOLS_FILE_i386.
1728
1729         * migrate-headers.sh:
1730         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
1731         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
1732           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
1733           WebKitLegacy.xcconfig.
1734
1735 2014-12-19  Simon Fraser  <simon.fraser@apple.com>
1736
1737         Fix pink background on CoreAnimation plug-ins in WebKit1
1738         https://bugs.webkit.org/show_bug.cgi?id=139845
1739         rdar://problem/19313075
1740
1741         Reviewed by Tim Horton.
1742         
1743         r154078 left in some debugging code that set a pink background on plug-in hosting
1744         layers. Remove it.
1745
1746         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1747         (-[WebHostedNetscapePluginView createPluginLayer]):
1748
1749 2014-12-19  Andreas Kling  <akling@apple.com>
1750
1751         Ref-ify TextIterator API.
1752         <https://webkit.org/b/139823>
1753
1754         Reviewed by Antti Koivisto.
1755
1756         * WebView/WebTextIterator.mm:
1757         (-[WebTextIterator currentRange]):
1758
1759 2014-12-19  Joseph Pecoraro  <pecoraro@apple.com>
1760
1761         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
1762         https://bugs.webkit.org/show_bug.cgi?id=139797
1763
1764         Reviewed by Mark Lam.
1765
1766         * WebView/WebScriptDebugger.h:
1767         * WebView/WebScriptDebugger.mm:
1768         (WebScriptDebugger::handlePause):
1769         Standardize on passing JSGlobalObject parameter first.
1770
1771 2014-12-19  Commit Queue  <commit-queue@webkit.org>
1772
1773         Unreviewed, rolling out r177574.
1774         https://bugs.webkit.org/show_bug.cgi?id=139821
1775
1776         "Broke Production builds by installing
1777         libWebCoreTestSupport.dylib in the wrong directory" (Requested
1778         by ddkilzer on #webkit).
1779
1780         Reverted changeset:
1781
1782         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
1783         WebInspectorUI, WebKit, WebKit2"
1784         https://bugs.webkit.org/show_bug.cgi?id=139463
1785         http://trac.webkit.org/changeset/177574
1786
1787 2014-12-19  David Kilzer  <ddkilzer@apple.com>
1788
1789         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
1790         <http://webkit.org/b/139463>
1791
1792         Reviewed by Mark Rowe.
1793
1794         * Configurations/Base.xcconfig:
1795         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
1796           on OS X.
1797         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
1798         * Configurations/DebugRelease.xcconfig:
1799         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
1800         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
1801         * Configurations/Version.xcconfig:
1802         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
1803         * Configurations/WebKitLegacy.xcconfig:
1804         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
1805           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
1806           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
1807           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
1808           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
1809           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
1810           WEBCORE_PRIVATE_HEADERS_DIR_Production and
1811           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
1812           based on SDK.
1813         - Fix PRODUCTION_ROOT to actually be set properly.
1814         - Simplify EXPORTED_SYMBOLS_FILE_i386.
1815
1816         * migrate-headers.sh:
1817         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
1818         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
1819           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
1820           WebKitLegacy.xcconfig.
1821
1822 2014-12-18  Andreas Kling  <akling@apple.com>
1823
1824         Ref-ify various Document-related things.
1825         <https://webkit.org/b/139796>
1826
1827         Reviewed by Anders Carlsson.
1828
1829         * WebView/WebFrame.mm:
1830         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
1831
1832 2014-12-18  Beth Dakin  <bdakin@apple.com>
1833
1834         Need to re-enable action menus
1835         https://bugs.webkit.org/show_bug.cgi?id=139795
1836         -and corresponding-
1837         rdar://problem/19299367
1838
1839         Reviewed by Tim Horton.
1840
1841         Re-enable the menus by un-commenting the code to create the menu and controller.
1842         * WebView/WebView.mm:
1843         (-[WebView _commonInitializationWithFrameName:groupName:]):
1844
1845 2014-12-16  Sam Weinig  <sam@webkit.org>
1846
1847         Unify the Mac and iOS implementations of FontPlatformData a bit
1848         https://bugs.webkit.org/show_bug.cgi?id=139721
1849
1850         Reviewed by Anders Carlsson.
1851
1852         * WebView/WebHTMLView.mm:
1853         (fontNameForDescription):
1854         Update for new function name.
1855
1856 2014-12-18  Antti Koivisto  <antti@apple.com>
1857
1858         Remove alwaysUseBaselineOfPrimaryFont setting
1859         https://bugs.webkit.org/show_bug.cgi?id=139770
1860
1861         Reviewed by Anders Carlsson.
1862
1863         * WebView/WebPreferenceKeysPrivate.h:
1864         * WebView/WebPreferences.mm:
1865         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
1866         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
1867         * WebView/WebPreferencesPrivate.h:
1868         * WebView/WebView.mm:
1869         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1870         (-[WebView _preferencesChanged:]):
1871
1872 2014-12-17  Andreas Kling  <akling@apple.com>
1873
1874         Ref-ify Range::create().
1875         <https://webkit.org/b/139755>
1876
1877         Reviewed by Anders Carlsson.
1878
1879         * WebView/WebHTMLRepresentation.mm:
1880         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
1881         * WebView/WebHTMLView.mm:
1882         (-[WebHTMLView attributedString]):
1883
1884 2014-12-17  Anders Carlsson  <andersca@apple.com>
1885
1886         Unify -[WebResource description]
1887         https://bugs.webkit.org/show_bug.cgi?id=139762
1888
1889         Reviewed by Dan Bernstein.
1890
1891         * WebView/WebResource.mm:
1892         (-[WebResource description]):
1893
1894 2014-12-17  Anders Carlsson  <andersca@apple.com>
1895
1896         Get rid of an ugly #define hack in WebFrameLoaderClient
1897         https://bugs.webkit.org/show_bug.cgi?id=139761
1898
1899         Reviewed by Dan Bernstein.
1900
1901         Also replace @private with @package in all public headers, for consistency.
1902
1903         * History/WebBackForwardList.h:
1904         * History/WebHistory.h:
1905         * Misc/WebDownload.h:
1906         * WebCoreSupport/WebFrameLoaderClient.mm:
1907         * WebView/WebArchive.h:
1908         * WebView/WebDataSource.h:
1909         * WebView/WebFrame.h:
1910         * WebView/WebFrameView.h:
1911         * WebView/WebPreferences.h:
1912         * WebView/WebResource.h:
1913
1914 2014-12-17  Dan Bernstein  <mitz@apple.com>
1915
1916         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
1917         https://bugs.webkit.org/show_bug.cgi?id=139760
1918
1919         Reviewed by Anders Carlsson.
1920
1921         * Configurations/WebKitLegacy.xcconfig:
1922
1923 2014-12-17  Andreas Kling  <akling@apple.com>
1924
1925         Purge PassRefPtr from Frame.
1926         <https://webkit.org/b/139731>
1927
1928         Reviewed by Anders Carlsson.
1929
1930         * WebCoreSupport/WebFrameLoaderClient.mm:
1931         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1932         * WebView/WebFrame.mm:
1933         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
1934         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
1935         * WebView/WebFrameInternal.h:
1936
1937 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
1938
1939         Implement and adopt two new TextIndicator presentation animations
1940         https://bugs.webkit.org/show_bug.cgi?id=139715
1941         <rdar://problem/19237945>
1942
1943         Reviewed by Anders Carlsson.
1944
1945         * WebView/WebActionMenuController.mm:
1946         (-[WebActionMenuController _showTextIndicator]):
1947         * WebView/WebHTMLView.mm:
1948         (-[WebHTMLView quickLookWithEvent:]):
1949         Remove the completionHandler from text indicator presentation.
1950
1951         * WebView/WebImmediateActionController.mm:
1952         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1953         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
1954         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1955         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1956         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1957         (-[WebImmediateActionController _animationControllerForText]):
1958         (-[WebImmediateActionController _showTextIndicator]):
1959         Forward immediate action gesture recognizer animation progress
1960         to TextIndicator. Force us to keep the selection when immediate
1961         action popovers steal first responder status from the WebView.
1962         If the Lookup range is equal to the selection range, use a Crossfade
1963         animation; otherwise, use a FadeIn animation.
1964
1965         * WebView/WebView.mm:
1966         (-[WebView _setMaintainsInactiveSelection:]):
1967         (-[WebView maintainsInactiveSelection]):
1968         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1969         (-[WebView _setTextIndicator:fadeOut:]):
1970         (-[WebView _clearTextIndicator]):
1971         (-[WebView _setTextIndicatorAnimationProgress:]):
1972         (-[WebView _showDictionaryLookupPopup:]):
1973         (-[WebView _dictionaryLookupPopoverWillClose:]):
1974         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1975         Remove the completionHandler from text indicator presentation.
1976         Add a _setMaintainsInactiveSelection, which allows WebKit internals
1977         to change the return value of -maintainsInactiveSelection, allowing
1978         us to keep the selection alive when the WebView loses first responder status.
1979
1980         * WebView/WebViewData.h:
1981         * WebView/WebViewInternal.h:
1982
1983 2014-12-16  Andreas Kling  <akling@apple.com>
1984
1985         Use Ref for SecurityOrigin.
1986         <https://webkit.org/b/139710>
1987
1988         Reviewed by Anders Carlsson.
1989
1990         * Storage/WebStorageTrackerClient.mm:
1991         (WebStorageTrackerClient::dispatchDidModifyOrigin):
1992         * WebView/WebView.mm:
1993         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
1994         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
1995
1996 2014-12-16  Beth Dakin  <bdakin@apple.com>
1997
1998         Crash getting default animation controller for some text
1999         https://bugs.webkit.org/show_bug.cgi?id=139712
2000         -and corresponding-
2001         rdar://problem/19271707
2002
2003         Reviewed by Tim Horton.
2004
2005         Must null-check the range.
2006         * WebView/WebImmediateActionController.mm:
2007         (-[WebImmediateActionController _animationControllerForText]):
2008
2009 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
2010
2011         Immediate action popovers can get stuck open
2012         https://bugs.webkit.org/show_bug.cgi?id=139709
2013         <rdar://problem/19270279>
2014
2015         Reviewed by Beth Dakin.
2016
2017         * WebView/WebImmediateActionController.mm:
2018         (-[WebImmediateActionController _clearImmediateActionState]):
2019         Don't clear the animation controller; it breaks things and was unnecessary.
2020
2021 2014-12-16  Tim Horton  <timothy_horton@apple.com>
2022
2023         Disable TextIndication for Lookup immediate actions
2024         https://bugs.webkit.org/show_bug.cgi?id=139684
2025
2026         Reviewed by Anders Carlsson.
2027
2028         * WebView/WebView.mm:
2029         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2030
2031 2014-12-15  Beth Dakin  <bdakin@apple.com>
2032
2033         Build fix.
2034
2035         * WebView/WebImmediateActionController.mm:
2036
2037 2014-12-15  Beth Dakin  <bdakin@apple.com>
2038
2039         Speculative build fix.
2040
2041         * WebView/WebView.mm:
2042         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2043         * WebView/WebViewInternal.h:
2044
2045 2014-12-15  Beth Dakin  <bdakin@apple.com>
2046
2047         Make lookup an immediate action instead of an action menu item
2048         https://bugs.webkit.org/show_bug.cgi?id=139661
2049         -and corresponding-
2050         rdar://problem/19198414
2051
2052         Reviewed by Tim Horton.
2053
2054         Remove the lookup menu items and non-unused static function associated with 
2055         lookup.
2056         * WebView/WebActionMenuController.mm:
2057         (-[WebActionMenuController _defaultMenuItemsForText]):
2058         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
2059         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
2060         (-[WebActionMenuController _createActionMenuItemForTag:]):
2061         (-[WebActionMenuController _lookupText:]): Deleted.
2062         (performDictionaryLookupForSelection): Deleted.
2063         (performDictionaryLookupForRange): Deleted.
2064
2065         Set the defaultAnimationController to the lookup-provided animation controller 
2066         when appropriate.
2067         * WebView/WebImmediateActionController.mm:
2068         (-[WebImmediateActionController _defaultAnimationController]):
2069         (dictionaryPopupInfoForRange):
2070         (-[WebImmediateActionController _animationControllerForText]):
2071
2072         New type.
2073         * WebView/WebUIDelegatePrivate.h:
2074
2075         New function to get the lookup animation controller.
2076         * WebView/WebView.mm:
2077         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2078         * WebView/WebViewInternal.h:
2079
2080 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2081
2082         Implement Data Detectors immediate actions for Legacy WebKit
2083         https://bugs.webkit.org/show_bug.cgi?id=139619
2084         <rdar://problem/19198539>
2085
2086         Reviewed by Beth Dakin.
2087
2088         * WebView/WebImmediateActionController.mm:
2089         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2090         Note that this action context is only for immediate actions.
2091
2092 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
2093
2094         Addressing post-review comments in r177035
2095         https://bugs.webkit.org/show_bug.cgi?id=139557
2096
2097         Reviewed by Darin Adler.
2098
2099         * WebView/WebActionMenuController.mm:
2100         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
2101
2102 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2103
2104         Implement Data Detectors immediate actions for Legacy WebKit
2105         https://bugs.webkit.org/show_bug.cgi?id=139619
2106         <rdar://problem/19198539>
2107
2108         Reviewed by Eric Carlson.
2109
2110         * WebView/WebHTMLView.mm:
2111         (-[WebHTMLView mouseDown:mouseDown:]):
2112         Send mouseDown along to the WebImmediateActionController too.
2113
2114         * WebView/WebImmediateActionController.h:
2115         * WebView/WebImmediateActionController.mm:
2116         (-[WebImmediateActionController webViewClosed]):
2117         (-[WebImmediateActionController webView:willHandleMouseDown:]):
2118         (-[WebImmediateActionController _cancelImmediateAction]):
2119         (-[WebImmediateActionController _clearImmediateActionState]):
2120         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2121         (-[WebImmediateActionController _defaultAnimationController]):
2122         (-[WebImmediateActionController _updateImmediateActionItem]):
2123         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2124         (-[WebImmediateActionController _showTextIndicator]):
2125         (-[WebImmediateActionController _hideTextIndicator]):
2126         Copy most of the DataDetectors implementation into WebImmediateActionController.
2127
2128         * WebView/WebUIDelegatePrivate.h:
2129         Add a new type.
2130
2131         * WebView/WebView.mm:
2132         (-[WebView _commonInitializationWithFrameName:groupName:]):
2133         Temporarily disable action menus.
2134
2135         (-[WebView _immediateActionController]):
2136         * WebView/WebViewInternal.h:
2137
2138 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
2139
2140         Delete Notation because we don't use it
2141         https://bugs.webkit.org/show_bug.cgi?id=139171
2142
2143         Reviewed by Kent Tamura.
2144
2145         * MigrateHeaders.make:
2146
2147 2014-12-14  Andreas Kling  <akling@apple.com>
2148
2149         Replace PassRef with Ref/Ref&& across the board.
2150         <https://webkit.org/b/139587>
2151
2152         Reviewed by Darin Adler.
2153
2154         * WebCoreSupport/WebEditorClient.mm:
2155         (WebEditorClient::shouldApplyStyle):
2156         * WebCoreSupport/WebVisitedLinkStore.h:
2157         * WebCoreSupport/WebVisitedLinkStore.mm:
2158         (WebVisitedLinkStore::create):
2159
2160 2014-12-11  Dan Bernstein  <mitz@apple.com>
2161
2162         Fix a leak introduced in r177199.
2163
2164         Reviewed by Anders Carlsson.
2165
2166         * WebView/WebImmediateActionController.mm:
2167         (-[WebImmediateActionController _updateImmediateActionItem]):
2168
2169 2014-12-11  Beth Dakin  <bdakin@apple.com>
2170
2171         WK1: Need new SPI for Webkit clients to override default immediate action
2172         https://bugs.webkit.org/show_bug.cgi?id=139568
2173         -and corresponding-
2174         rdar://problem/19225448
2175
2176         Reviewed by Dan Bernstein.
2177
2178         Call SPI giving clients a chance to override the default behavior.
2179         * WebView/WebImmediateActionController.mm:
2180         (-[WebImmediateActionController _updateImmediateActionItem]):
2181
2182         New SPI.
2183         * WebView/WebUIDelegatePrivate.h:
2184
2185 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
2186
2187         Move the preview popover to WebImmediateActionController
2188         https://bugs.webkit.org/show_bug.cgi?id=139563
2189         <rdar://problem/19208291>
2190
2191         Reviewed by Beth Dakin.
2192
2193         * WebView/WebActionMenuController.mm:
2194         (-[WebActionMenuController _defaultMenuItemsForLink]):
2195         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
2196         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
2197         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
2198         * WebView/WebImmediateActionController.h:
2199         * WebView/WebImmediateActionController.mm:
2200         (-[WebImmediateActionController webViewClosed]):
2201         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2202         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
2203         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
2204         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
2205         (-[WebImmediateActionController _updateImmediateActionItem]):
2206         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
2207         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
2208         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
2209         Move page preview popover related code to WebImmediateActionController.
2210
2211         * WebView/WebUIDelegatePrivate.h:
2212         Add a link preview type.
2213
2214         * WebView/WebView.mm:
2215         (-[WebView _commonInitializationWithFrameName:groupName:]):
2216         Pass the gesture recognizer to the WebImmediateActionController.
2217
2218 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
2219
2220         Fix the build.
2221
2222         * WebView/WebImmediateActionController.h:
2223         * WebView/WebImmediateActionController.mm:
2224
2225 2014-12-11  Anders Carlsson  <andersca@apple.com>
2226
2227         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
2228         https://bugs.webkit.org/show_bug.cgi?id=139547
2229
2230         Reviewed by Sam Weinig.
2231
2232         * WebView/WebView.mm:
2233         (+[WebView _handleMemoryWarning]):
2234
2235 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
2236
2237         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
2238         https://bugs.webkit.org/show_bug.cgi?id=139504
2239         rdar://problem/19034674
2240
2241         Reviewed by Enrica Casucci.
2242
2243         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
2244
2245         * WebCoreSupport/WebEditorClient.h:
2246         * WebCoreSupport/WebEditorClient.mm:
2247         (WebEditorClient::discardedComposition):
2248
2249 2014-12-10  Anders Carlsson  <andersca@apple.com>
2250
2251         Get rid of the storage strategy
2252         https://bugs.webkit.org/show_bug.cgi?id=139519
2253
2254         Reviewed by Antti Koivisto.
2255
2256         * WebCoreSupport/WebPlatformStrategies.h:
2257         * WebCoreSupport/WebPlatformStrategies.mm:
2258         (WebPlatformStrategies::createStorageStrategy): Deleted.
2259
2260 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
2261
2262         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
2263         https://bugs.webkit.org/show_bug.cgi?id=139529
2264         <rdar://problem/19213620>
2265
2266         Reviewed by Beth Dakin.
2267
2268         * WebView/WebActionMenuController.mm:
2269         (-[WebActionMenuController _copySelection:]):
2270         (-[WebActionMenuController _paste:]):
2271         Use the copy: and paste: methods on WebView so that we traverse subviews
2272         when trying to respond, otherwise these actions don't work in subframes.
2273
2274 2014-12-10  Beth Dakin  <bdakin@apple.com>
2275
2276         WK1: Add initial support for immediate actions
2277         https://bugs.webkit.org/show_bug.cgi?id=139522
2278
2279         Reviewed by Dan Bernstein.
2280
2281         This basic implementation of the controller will use the delegate methods to 
2282         perform and cache a HitTest when relevant. Future patches will patch 
2283         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
2284         immediate action that should be taken.
2285         * WebView/WebImmediateActionController.h: Added.
2286         * WebView/WebImmediateActionController.mm: Added.
2287         (-[WebImmediateActionController webViewClosed]):
2288         (-[WebImmediateActionController _clearImmediateActionState]):
2289         (-[WebImmediateActionController performHitTestAtPoint:]):
2290         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2291         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
2292         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
2293         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
2294         (-[WebImmediateActionController _updateImmediateActionItem]):
2295
2296         New enum for immediate action types.
2297         * WebView/WebUIDelegatePrivate.h:
2298
2299         Create an NSImmediateActionGestureRecognizer if possible and a controller.
2300         * WebView/WebView.mm:
2301         (-[WebView _commonInitializationWithFrameName:groupName:]):
2302         (-[WebView _close]):
2303         * WebView/WebViewData.h:
2304         * WebView/WebViewData.mm:
2305         (-[WebViewPrivate dealloc]):
2306
2307 2014-12-08  Anders Carlsson  <andersca@apple.com>
2308
2309         Use the new storage namespace provider in WebKit1
2310         https://bugs.webkit.org/show_bug.cgi?id=139425
2311
2312         Reviewed by Tim Horton.
2313
2314         * WebView/WebView.mm:
2315         (-[WebView _commonInitializationWithFrameName:groupName:]):
2316         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2317         Set the storage namespace provider from the web page group.
2318
2319 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
2320
2321         Should have copy and paste items in all text menus
2322         https://bugs.webkit.org/show_bug.cgi?id=139510
2323         <rdar://problem/19198388>
2324
2325         Reviewed by Beth Dakin.
2326
2327         * WebView/WebActionMenuController.mm:
2328         (-[WebActionMenuController _defaultMenuItemsForText]):
2329         Add a disabled paste menu item into the read-only text menu.
2330
2331         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
2332         Add a disabled copy menu item into the editable whitespace text menu.
2333
2334 2014-12-10  Anders Carlsson  <andersca@apple.com>
2335
2336         Add WebStorageNamespaceProvider::closeLocalStorage
2337         https://bugs.webkit.org/show_bug.cgi?id=139502
2338
2339         Reviewed by Tim Horton.
2340
2341         * WebView/WebView.mm:
2342         (+[WebView _applicationWillTerminate]):
2343         Call WebStorageNamespaceProvider::closeLocalStorage.
2344
2345 2014-12-09  Commit Queue  <commit-queue@webkit.org>
2346
2347         Unreviewed, rolling out r177037.
2348         https://bugs.webkit.org/show_bug.cgi?id=139464
2349
2350         broke ~50 API tests (Requested by thorton on #webkit).
2351
2352         Reverted changeset:
2353
2354         "Use the new storage namespace provider in WebKit1"
2355         https://bugs.webkit.org/show_bug.cgi?id=139425
2356         http://trac.webkit.org/changeset/177037
2357
2358 2014-12-08  Anders Carlsson  <andersca@apple.com>
2359
2360         Use the new storage namespace provider in WebKit1
2361         https://bugs.webkit.org/show_bug.cgi?id=139425
2362
2363         Reviewed by Tim Horton.
2364
2365         * WebView/WebView.mm:
2366         (-[WebView _commonInitializationWithFrameName:groupName:]):
2367         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2368         Set the storage namespace provider from the web page group.
2369
2370 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
2371
2372         Delete Node::boundingBox()
2373         https://bugs.webkit.org/show_bug.cgi?id=139333
2374
2375         Reviewed by Zalan Bujtas.
2376
2377         * WebView/WebActionMenuController.mm:
2378         (elementBoundingBoxInWindowCoordinatesFromNode): Use
2379         RenderObject::absoluteBoundingBoxRect().
2380
2381 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
2382
2383         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
2384         https://bugs.webkit.org/show_bug.cgi?id=138843
2385         rdar://problem/18793695
2386
2387         Reviewed by Dan Bernstein.
2388
2389         * Panels/WebAuthenticationPanel.m:
2390         (-[WebAuthenticationPanel cancel:]):
2391         (-[WebAuthenticationPanel logIn:]):
2392         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
2393         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
2394         that only when using an old NSWindow API.
2395
2396 2014-12-08  Beth Dakin  <bdakin@apple.com>
2397
2398         Copy and Lookup menu items should be disabled when something is not copyable
2399         https://bugs.webkit.org/show_bug.cgi?id=139423
2400
2401         Reviewed by Tim Horton.
2402
2403         Disable both lookup and copy when a HitTestResult does not allow copy.
2404         * WebView/WebActionMenuController.mm:
2405
2406         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
2407         disable state otherwise.
2408         * WebView/WebView.mm:
2409         (-[WebView _commonInitializationWithFrameName:groupName:]):
2410
2411 2014-12-08  Anders Carlsson  <andersca@apple.com>
2412
2413         Adding user content to a group should force that group to be created
2414         https://bugs.webkit.org/show_bug.cgi?id=139421
2415         rdar://problem/19180108
2416
2417         Reviewed by Sam Weinig.
2418
2419         * WebCoreSupport/WebViewGroup.h:
2420         Store the local storage database path in the group.
2421
2422         * WebCoreSupport/WebViewGroup.mm:
2423         (WebViewGroup::getOrCreate):
2424         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
2425         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
2426
2427         (WebViewGroup::WebViewGroup):
2428         Initialize the new member variable.
2429
2430         (WebViewGroup::storageNamespaceProvider):
2431         Create the namespace provider lazily.
2432
2433         * WebView/WebView.mm:
2434         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
2435         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
2436         Use getOrCreate instead of get.
2437
2438 2014-12-08  Anders Carlsson  <andersca@apple.com>
2439
2440         WebStorageNamespaceProvider should know about its local storage database path
2441         https://bugs.webkit.org/show_bug.cgi?id=139413
2442
2443         Reviewed by Andreas Kling.
2444
2445         * WebCoreSupport/WebViewGroup.h:
2446         * WebCoreSupport/WebViewGroup.mm:
2447         (WebViewGroup::getOrCreate):
2448         (WebViewGroup::WebViewGroup):
2449         * WebView/WebView.mm:
2450         (-[WebView _commonInitializationWithFrameName:groupName:]):
2451         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2452         (-[WebView setGroupName:]):
2453         (-[WebView groupName]): Deleted.
2454
2455 2014-12-08  Daniel Bates  <dabates@apple.com>
2456
2457         [iOS] Fix the WebKit build with the public SDK
2458
2459         Include header NSURLDownloadSPI.h.
2460
2461         * WebCoreSupport/WebFrameLoaderClient.mm:
2462
2463 2014-12-07  Dan Bernstein  <mitz@apple.com>
2464
2465         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
2466         https://bugs.webkit.org/show_bug.cgi?id=139348
2467
2468         Reviewed by Anders Carlsson.
2469
2470         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
2471         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
2472         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
2473         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
2474         avoiding the ambiguity.
2475
2476         * WebView/WebActionMenuController.mm:
2477         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
2478
2479 2014-12-06  Anders Carlsson  <andersca@apple.com>
2480
2481         Add a stubbed out version of WebStorageNamespaceProvider
2482         https://bugs.webkit.org/show_bug.cgi?id=139213
2483
2484         Reviewed by Sam Weinig.
2485
2486         * WebCoreSupport/WebViewGroup.h:
2487         (WebViewGroup::storageNamespaceProvider):
2488         * WebCoreSupport/WebViewGroup.mm:
2489         (WebViewGroup::getOrCreate):
2490         (WebViewGroup::WebViewGroup):
2491         Give WebViewGroup a storage namespace provider.
2492
2493 2014-12-06  Anders Carlsson  <andersca@apple.com>
2494
2495         Fix build with newer versions of clang.
2496         rdar://problem/18978687
2497
2498         Add missing overrides and missing casts.
2499
2500         * Storage/WebDatabaseManagerClient.h:
2501         * Storage/WebStorageTrackerClient.h:
2502         * WebCoreSupport/WebChromeClient.h:
2503         * WebCoreSupport/WebFrameLoaderClient.h:
2504         * WebCoreSupport/WebInspectorClient.h:
2505         * WebView/WebDataSource.mm:
2506         (-[WebDataSource _makeRepresentation]):
2507         * WebView/WebFrameView.mm:
2508         (-[WebFrameView _makeDocumentViewForDataSource:]):
2509
2510 2014-12-05  Tim Horton  <timothy_horton@apple.com>
2511
2512         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
2513         https://bugs.webkit.org/show_bug.cgi?id=139306
2514         <rdar://problem/19157955>
2515
2516         Reviewed by Beth Dakin.
2517
2518         * WebView/WebView.mm:
2519         (-[WebView _commonInitializationWithFrameName:groupName:]):
2520         (-[WebView _initWithFrame:frameName:groupName:]):
2521         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
2522
2523 2014-12-05  David Kilzer  <ddkilzer@apple.com>
2524
2525         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
2526         <http://webkit.org/b/139286>
2527
2528         Reviewed by Daniel Bates.
2529
2530         * Configurations/FeatureDefines.xcconfig: Switch back to using
2531         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
2532
2533 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
2534
2535         Fix the 32-bit build.
2536
2537         * WebView/WebView.mm:
2538         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
2539
2540 2014-12-04  Tim Horton  <timothy_horton@apple.com>
2541
2542         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
2543         https://bugs.webkit.org/show_bug.cgi?id=139252
2544         <rdar://problem/19140827>
2545
2546         Reviewed by Anders Carlsson.
2547
2548         * WebView/WebView.mm:
2549         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
2550         Adjust to the WebCore changes.
2551
2552 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
2553
2554         Implement action menus for tel: URLs
2555         https://bugs.webkit.org/show_bug.cgi?id=139240
2556         <rdar://problem/19115662>
2557
2558         Reviewed by Anders Carlsson.
2559
2560         * WebView/WebActionMenuController.mm:
2561         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
2562         Make sure to use the newly created currentActionContext... everywhere.
2563
2564 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
2565
2566         Implement action menus for tel: URLs
2567         https://bugs.webkit.org/show_bug.cgi?id=139240
2568         <rdar://problem/19115662>
2569
2570         Reviewed by Anders Carlsson.
2571
2572         * WebView/WebActionMenuController.mm:
2573         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
2574         Make sure to use the newly created currentActionContext.
2575
2576 2014-12-03  Beth Dakin  <bdakin@apple.com>
2577
2578         <input> elements get whitespace action menu instead of editable text menu
2579         https://bugs.webkit.org/show_bug.cgi?id=139241
2580         -and corresponding-
2581         rdar://problem/19072083
2582
2583         Reviewed by Sam Weinig.
2584
2585         We should disallow shadow content in the hit test. This is the default and it is 
2586         how context menus behave. We originally wanted to text inside shadow content so 
2587         that we could find the text, but the new function I added to HitTestResult will 
2588         allow that.
2589         * WebView/WebActionMenuController.mm:
2590         (-[WebActionMenuController performHitTestAtPoint:]):
2591
2592         Adjust to the fact that we don’t hit test shadow content any more.
2593         (-[WebActionMenuController focusAndSelectHitTestResult]):
2594
2595         Offer the text menus for text inside form controls.
2596         (-[WebActionMenuController _defaultMenuItems]):
2597
2598 2014-12-03  Tim Horton  <timothy_horton@apple.com>
2599
2600         Implement action menus for tel: URLs
2601         https://bugs.webkit.org/show_bug.cgi?id=139240
2602         <rdar://problem/19115662>
2603
2604         Reviewed by Anders Carlsson.
2605
2606         * WebView/WebActionMenuController.mm:
2607         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
2608         Rename this function as it will work for both mailto and tel URLs.
2609         Adjust it to use contextForView:.
2610
2611         (-[WebActionMenuController webView:willHandleMouseDown:]):
2612         (-[WebActionMenuController prepareForMenu:withEvent:]):
2613         (-[WebActionMenuController didCloseMenu:withEvent:]):
2614         (-[WebActionMenuController _defaultMenuItems]):
2615         Don't check the menu type when going to interact with _currentActionContext.
2616         We'll only have a _currentActionContext if we have a data detected item,
2617         and there are multiple menu types that end up using DDActionContext.
2618
2619         * WebView/WebUIDelegatePrivate.h:
2620         Add a new type.
2621
2622 2014-12-03  Anders Carlsson  <andersca@apple.com>
2623
2624         Set a visited link store when creating a simple WebView
2625         https://bugs.webkit.org/show_bug.cgi?id=139234
2626         <rdar://problem/19132978>
2627
2628         Reviewed by Sam Weinig.
2629
2630         * WebView/WebView.mm:
2631         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2632
2633 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
2634
2635         Fix the build.
2636
2637         * WebCoreSupport/WebFrameLoaderClient.mm:
2638
2639 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
2640
2641         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
2642         https://bugs.webkit.org/show_bug.cgi?id=139149
2643
2644         Reviewed by Anders Carlsson.
2645
2646         This changes API behavior. I think that it's OK, because existing behavior made no sense.
2647         We used to delete caches from disk, but they were still active in memory. Now we also
2648         obsolete them in memory, so documents that use a cache still work, but new ones don't
2649         pick one up.
2650
2651         * WebCoreSupport/WebApplicationCache.mm:
2652         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
2653         need to delete in-momry caches too. Keep existing behavior.
2654         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
2655         that properly deletes caches.
2656
2657 2014-12-02  Tim Horton  <timothy_horton@apple.com>
2658
2659         Remove a SnowLeopard-era quirk for QuickLook
2660         https://bugs.webkit.org/show_bug.cgi?id=139208
2661         <rdar://problem/19121822>
2662
2663         Reviewed by Alexey Proskuryakov.
2664
2665         * WebCoreSupport/WebFrameLoaderClient.h:
2666         * WebCoreSupport/WebFrameLoaderClient.mm:
2667
2668 2014-12-02  Tim Horton  <timothy_horton@apple.com>
2669
2670         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
2671         https://bugs.webkit.org/show_bug.cgi?id=139204
2672
2673         Reviewed by Anders Carlsson.
2674
2675         * WebView/WebView.mm:
2676         (-[WebView _commonInitializationWithFrameName:groupName:]):
2677         (-[WebView _showDictionaryLookupPopup:]):
2678         * WebView/WebViewData.h:
2679         Work around this by delaying the softlinking (and setting up the notification
2680         observer) until we actually need it. There's still an underlying bug, but
2681         this will fix the test.
2682
2683 2014-12-02  Beth Dakin  <bdakin@apple.com>
2684
2685         Yet another build fix.
2686
2687         * WebView/WebActionMenuController.mm:
2688         (-[WebActionMenuController _defaultMenuItemsForLink]):
2689
2690 2014-12-02  Beth Dakin  <bdakin@apple.com>
2691
2692         Build fix.
2693
2694         * WebView/WebActionMenuController.mm:
2695         (-[WebActionMenuController _defaultMenuItemsForLink]):
2696
2697 2014-12-02  Beth Dakin  <bdakin@apple.com>
2698
2699         More build fixing.
2700
2701         * WebView/WebActionMenuController.mm:
2702         (-[WebActionMenuController _defaultMenuItemsForLink]):
2703
2704 2014-12-02  Beth Dakin  <bdakin@apple.com>
2705
2706         Should use standardQuickLookMenuItem for apps that don't implement customizations
2707         https://bugs.webkit.org/show_bug.cgi?id=139193
2708         -and corresponding-
2709         rdar://problem/18944696
2710
2711         Reviewed by Anders Carlsson.
2712
2713         Use [NSMenuItem standardQuickLookMenuItem].
2714         * WebView/WebActionMenuController.mm:
2715         (-[WebActionMenuController _defaultMenuItemsForLink]):
2716
2717         Delegate methods to set up the standardQuickLookMenuItem.
2718         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
2719         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
2720         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
2721
2722         Remove all of the old QLPreviewBubble code.
2723         (-[WebActionMenuController _createActionMenuItemForTag:]):
2724         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
2725
2726 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
2727
2728         Fix the build.
2729
2730         * WebView/WebViewData.h:
2731
2732 2014-12-02  Tim Horton  <timothy_horton@apple.com>
2733
2734         Implement Lookup transition from selection for Legacy WebKit
2735         https://bugs.webkit.org/show_bug.cgi?id=139180
2736         <rdar://problem/19067172>
2737
2738         Reviewed by Beth Dakin.
2739
2740         * WebView/DictionaryPopupInfo.h: Added.
2741         Split DictionaryPopupInfo out into its own file.
2742
2743         * WebView/WebActionMenuController.mm:
2744         (-[WebActionMenuController _lookupText:]):
2745         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
2746
2747         (performDictionaryLookupForSelection):
2748         (performDictionaryLookupForRange):
2749         Plumb the transition style through these helpers.
2750         Create a TextIndicator from the selection range.
2751
2752         * WebView/WebHTMLView.mm:
2753         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
2754         Make use of TextIndicator (and DictionaryPopupInfo, and the new
2755         _showDictionaryLookupPopup on WebView) to add a transition from blue
2756         when performing Lookup from the context menu.
2757
2758         (-[WebHTMLView quickLookWithEvent:]):
2759         Remove our TextIndicator whenever a normal three-finger-tap event
2760         comes through, as it will have its own indication.
2761
2762         * WebView/WebView.mm:
2763         (-[WebView _commonInitializationWithFrameName:groupName:]):
2764         (-[WebView _dictionaryLookupPopoverWillClose:]):
2765         Register for the LUNotificationPopoverWillClose notification and remove
2766         our TextIndicator when it is called, just like in WebKit2.
2767         Deregistration is already handled in _close.
2768
2769         (-[WebView _showDictionaryLookupPopup:]):
2770         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
2771         if the relevant API is available.
2772
2773         * WebView/WebViewInternal.h:
2774
2775 2014-12-02  Anders Carlsson  <andersca@apple.com>
2776
2777         Remove visited link handling from PageGroup
2778         https://bugs.webkit.org/show_bug.cgi?id=139185
2779
2780         Reviewed by Sam Weinig.
2781
2782         * History/WebHistory.mm:
2783         (-[WebHistoryPrivate removeItemForURLString:]):
2784         (-[WebHistoryPrivate removeAllItems]):
2785         (+[WebHistory setOptionalSharedHistory:]):
2786         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
2787         (+[WebHistory _removeAllVisitedLinks]):
2788         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
2789         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
2790         * History/WebHistoryInternal.h:
2791         * WebCoreSupport/WebChromeClient.h:
2792         * WebCoreSupport/WebChromeClient.mm:
2793         (WebChromeClient::populateVisitedLinks): Deleted.
2794         * WebView/WebView.mm:
2795         (-[WebView addVisitedLinks:]):
2796         (-[WebView removeVisitedLink:]):
2797
2798 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
2799
2800         Try to fix the Mac build.
2801
2802         * WebView/WebView.mm:
2803         (-[WebView _commonInitializationWithFrameName:groupName:]):
2804         (-[WebView _close]):
2805
2806 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
2807
2808         Fix the iOS build.
2809
2810         * WebView/WebActionMenuController.h:
2811         * WebView/WebActionMenuController.mm:
2812         * WebView/WebHTMLView.mm:
2813         (-[WebHTMLView scrollWheel:scrollWheel:]):
2814         (-[WebHTMLView mouseDown:mouseDown:]):
2815         * WebView/WebView.mm:
2816         * WebView/WebViewData.h:
2817         * WebView/WebViewData.mm:
2818         (-[WebViewPrivate dealloc]):
2819         * WebView/WebViewInternal.h:
2820
2821 2014-12-01  Tim Horton  <timothy_horton@apple.com>
2822
2823         Implement yellow highlight for WebKit1 data detectors
2824         https://bugs.webkit.org/show_bug.cgi?id=138956
2825         <rdar://problem/18992185>
2826
2827         Reviewed by Beth Dakin.
2828
2829         * WebView/WebActionMenuController.h:
2830         * WebView/WebActionMenuController.mm:
2831         (-[WebActionMenuController webView:willHandleMouseDown:]):
2832         (-[WebActionMenuController webView:didHandleScrollWheel:]):
2833         (-[WebActionMenuController prepareForMenu:withEvent:]):
2834         (-[WebActionMenuController didCloseMenu:withEvent:]):
2835         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2836         (-[WebActionMenuController _showTextIndicator]):
2837         (-[WebActionMenuController _hideTextIndicator]):
2838         (-[WebActionMenuController _dismissActionMenuPopovers]):
2839         Copy the WebKit2 WKActionMenuController TextIndicator implementation
2840         into WebActionMenuController. The only significant difference is
2841         that we build the TextIndicator right at menu construction time
2842         instead of in the Web process.
2843
2844         * WebView/WebHTMLView.mm:
2845         (-[WebHTMLView scrollWheel:]):
2846         Let the WebActionMenuController know that we're handling a scroll.
2847
2848         (-[WebHTMLView mouseDown:]):
2849         Let the WebActionMenuController know that we're handling a mouseDown.
2850
2851         * WebView/WebView.mm:
2852         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
2853         (-[WebView _clearTextIndicator]):
2854         (-[WebView _actionMenuController]):
2855         (-[WebView _convertRectFromRootView:]): Deleted.
2856         * WebView/WebViewData.h:
2857         * WebView/WebViewData.mm:
2858         * WebView/WebViewInternal.h:
2859         Keep a TextIndicatorWindow on WebView, just like WKView does.
2860         Expose the WebActionMenuController on WebView (internally).
2861
2862 2014-12-01  Anders Carlsson  <andersca@apple.com>
2863
2864         Remove old site specific quirks code that was added in 2009
2865         https://bugs.webkit.org/show_bug.cgi?id=139141
2866
2867         Reviewed by Antti Koivisto.
2868
2869         * WebCoreSupport/WebFrameNetworkingContext.h:
2870         * WebCoreSupport/WebFrameNetworkingContext.mm:
2871         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
2872
2873 2014-11-30  Anders Carlsson  <andersca@apple.com>
2874
2875         Fix a test failure.
2876
2877         * History/WebHistory.mm:
2878         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
2879         Call through to the visited link store.
2880
2881         (+[WebHistory _removeAllVisitedLinks]):
2882         Ditto.
2883
2884         * WebCoreSupport/WebVisitedLinkStore.mm:
2885         (WebVisitedLinkStore::isLinkVisited):
2886         Make sure to populate visited links.
2887
2888 2014-11-30  Anders Carlsson  <andersca@apple.com>
2889
2890         Switch over to the visited link store from the WebViewGroup
2891         https://bugs.webkit.org/show_bug.cgi?id=139112
2892
2893         Reviewed by Sam Weinig.
2894
2895         * WebView/WebView.mm:
2896         (-[WebView _commonInitializationWithFrameName:groupName:]):
2897         (-[WebView setGroupName:]):
2898
2899 2014-11-30  Anders Carlsson  <andersca@apple.com>
2900
2901         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
2902         https://bugs.webkit.org/show_bug.cgi?id=139111
2903
2904         Reviewed by Sam Weinig.
2905
2906         * WebCoreSupport/WebVisitedLinkStore.h:
2907         * WebCoreSupport/WebVisitedLinkStore.mm:
2908         (WebVisitedLinkStore::removeVisitedLink):
2909         * WebView/WebView.mm:
2910         (-[WebView removeVisitedLink:]):
2911
2912 2014-11-29  Anders Carlsson  <andersca@apple.com>
2913
2914         Populate visited links
2915         https://bugs.webkit.org/show_bug.cgi?id=139101
2916
2917         Reviewed by Sam Weinig.
2918
2919         * History/WebHistory.mm:
2920         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
2921         Helper function that adds all visited link to the given store.
2922
2923         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
2924         Call the private method.
2925
2926         * History/WebHistoryInternal.h:
2927         * WebCoreSupport/WebVisitedLinkStore.h:
2928         Add new members.
2929
2930         * WebCoreSupport/WebVisitedLinkStore.mm:
2931         (WebVisitedLinkStore::addVisitedLink):
2932         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
2933
2934         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
2935         Implement this. First try the delegate, then try the shared history.
2936
2937         (WebVisitedLinkStore::addVisitedLinkHash):
2938         Factor code that adds the link to the hash table into a separate function.
2939
2940         * WebView/WebView.mm:
2941         (-[WebView addVisitedLinks:]):
2942         Add the visited links to the store.
2943
2944 2014-11-29  Anders Carlsson  <andersca@apple.com>
2945
2946         More work on the legacy WebKit visited link store
2947         https://bugs.webkit.org/show_bug.cgi?id=139100
2948
2949         Reviewed by Sam Weinig.
2950
2951         * History/WebHistory.mm:
2952         (+[WebHistory setOptionalSharedHistory:]):
2953         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
2954
2955         * WebCoreSupport/WebVisitedLinkStore.h:
2956         * WebCoreSupport/WebVisitedLinkStore.mm:
2957         (visitedLinkStores):
2958         (WebVisitedLinkStore::WebVisitedLinkStore):
2959         (WebVisitedLinkStore::~WebVisitedLinkStore):
2960         Keep track of live visited link stores.
2961
2962         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
2963         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
2964
2965         (WebVisitedLinkStore::removeAllVisitedLinks):
2966         Iterate over all live link stores and remove their links.
2967
2968         (WebVisitedLinkStore::isLinkVisited):
2969         Populate visited links and check if our hash table contains the link.
2970
2971         (WebVisitedLinkStore::addVisitedLink):
2972         Add the link hash to the table.
2973
2974         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
2975         Add stub.
2976
2977         (WebVisitedLinkStore::removeVisitedLinkHashes):
2978         Clear out the hash table.
2979
2980 2014-11-27  Anders Carlsson  <andersca@apple.com>
2981
2982         Add a stubbed out WebVisitedLinkStore to WebViewGroup
2983         https://bugs.webkit.org/show_bug.cgi?id=139066
2984
2985         Reviewed by Antti Koivisto.
2986
2987         * WebCoreSupport/WebViewGroup.h:
2988         (WebViewGroup::visitedLinkStore):
2989         * WebCoreSupport/WebViewGroup.mm:
2990         (WebViewGroup::WebViewGroup):
2991         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
2992         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
2993         (WebVisitedLinkStore::create):
2994         (WebVisitedLinkStore::WebVisitedLinkStore):
2995         (WebVisitedLinkStore::~WebVisitedLinkStore):
2996         (WebVisitedLinkStore::isLinkVisited):
2997         (WebVisitedLinkStore::addVisitedLink):
2998
2999 2014-11-25  Anders Carlsson  <andersca@apple.com>
3000
3001         Remove user content handling from PageGroup
3002         https://bugs.webkit.org/show_bug.cgi?id=139051
3003
3004         Reviewed by Antti Koivisto.
3005
3006         Use the user content controller in the web view group.
3007
3008         * WebView/WebView.mm:
3009         (-[WebView _injectOutlookQuirksScript]):
3010
3011 2014-11-25  Anders Carlsson  <andersca@apple.com>
3012
3013         Add a user content controller to WebViewGroup and use it for user content
3014         https://bugs.webkit.org/show_bug.cgi?id=139043
3015
3016         Reviewed by Antti Koivisto.
3017
3018         This is another tiny step towards getting rid of user content handling inside PageGroup.
3019
3020         * WebCoreSupport/WebViewGroup.h:
3021         (WebViewGroup::userContentController):
3022         Add a UserContentController member and getter.
3023
3024         * WebCoreSupport/WebViewGroup.mm:
3025         (WebViewGroup::get):
3026         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
3027
3028         (WebViewGroup::WebViewGroup):
3029         Create a user content controller.
3030
3031         * WebView/WebView.mm:
3032         (-[WebView _commonInitializationWithFrameName:groupName:]):
3033         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
3034         set its user content controller in the PageConfiguration.
3035
3036         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3037         Ditto.
3038
3039         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
3040         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
3041         (+[WebView _removeUserScriptFromGroup:world:url:]):
3042         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
3043         (+[WebView _removeUserScriptsFromGroup:world:]):
3044         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
3045         (+[WebView _removeAllUserContentFromGroup:]):
3046         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
3047
3048         (-[WebView setGroupName:]):
3049         Set the user content controller to the new WebViewGroup's user content controller.
3050
3051 2014-11-21  Jer Noble  <jer.noble@apple.com>
3052
3053         Support multiple signatures of diagnostic logging.
3054         https://bugs.webkit.org/show_bug.cgi?id=138690
3055
3056         Reviewed by Anders Carlsson.
3057
3058         Page::PageClients has been renamed PageConfiguration.
3059
3060         * WebView/WebView.mm:
3061         (-[WebView _commonInitializationWithFrameName:groupName:]):
3062         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3063
3064 2014-11-21  Zalan Bujtas  <zalan@apple.com>
3065
3066         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
3067         https://bugs.webkit.org/show_bug.cgi?id=138981
3068
3069         Reviewed by Simon Fraser.
3070
3071         * WebView/WebPreferenceKeysPrivate.h:
3072         * WebView/WebPreferences.mm:
3073         (+[WebPreferences initialize]):
3074         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
3075         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
3076         * WebView/WebPreferencesPrivate.h:
3077         * WebView/WebView.mm:
3078         (-[WebView _preferencesChanged:]):
3079
3080 2014-11-21  Tim Horton  <timothy_horton@apple.com>
3081
3082         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
3083         ​https://bugs.webkit.org/show_bug.cgi?id=138960
3084         <rdar://problem/19056715>
3085
3086         Reviewed by Anders Carlsson.
3087
3088         * WebView/WebActionMenuController.mm:
3089         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
3090         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
3091         Use DataDetectors SPI instead of an explicit blacklist.
3092
3093 2014-11-21  Tim Horton  <timothy_horton@apple.com>
3094
3095         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
3096         https://bugs.webkit.org/show_bug.cgi?id=138960
3097         <rdar://problem/19056715>
3098
3099         Reviewed by Beth Dakin.
3100
3101         * WebView/WebActionMenuController.mm:
3102         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
3103         Blacklist contact results, because they don't have useful menus. If we
3104         bail before setting up _currentActionContext, we'll still allow fallthrough
3105         to ordinary text actions, avoiding mysterious failure when a contact is detected.
3106
3107         This doesn't break the case that r176351 was intended to fix,
3108         because in that case we were detecting e.g. addresses.
3109
3110 2014-11-21  Anders Carlsson  <andersca@apple.com>
3111
3112         Remove the Timer parameters from timer callbacks
3113         https://bugs.webkit.org/show_bug.cgi?id=138974
3114
3115         Reviewed by Antti Koivisto.
3116
3117         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3118         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3119         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
3120         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
3121         * Plugins/WebNetscapePluginStream.h:
3122         * Plugins/WebNetscapePluginStream.mm:
3123         (WebNetscapePluginStream::WebNetscapePluginStream):
3124         (WebNetscapePluginStream::deliverDataTimerFired):
3125
3126 2014-11-21  Anders Carlsson  <andersca@apple.com>
3127
3128         Make memoryCache() return a reference
3129         https://bugs.webkit.org/show_bug.cgi?id=138939
3130
3131         Reviewed by Antti Koivisto.
3132
3133         * Misc/WebCache.mm:
3134         (+[WebCache statistics]):
3135         (+[WebCache emptyInMemoryResources]):
3136         (+[WebCache sizeOfDeadResources:]):
3137         (+[WebCache addImageToCache:forURL:forFrame:]):
3138         (+[WebCache removeImageFromCacheForURL:forFrame:]):
3139         (+[WebCache imageForURL:]):
3140         (+[WebCache setDisabled:]):
3141         (+[WebCache isDisabled]):
3142         * WebView/WebView.mm:
3143         (+[WebView _setCacheModel:]):
3144
3145 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
3146
3147         Remove the remaining vestiges of minimal-ui
3148         https://bugs.webkit.org/show_bug.cgi?id=138890
3149
3150         Reviewed by Sam Weinig.
3151
3152         * History/WebHistoryItem.mm:
3153         * History/WebHistoryItemPrivate.h:
3154
3155 2014-11-20  Tim Horton  <timothy_horton@apple.com>
3156
3157         Cancel DataDetectors menu earlier if we know it can't be presented
3158         https://bugs.webkit.org/show_bug.cgi?id=138922
3159         <rdar://problem/18950441>
3160
3161         Reviewed by Beth Dakin.
3162
3163         * WebView/WebActionMenuController.mm:
3164         (-[WebActionMenuController prepareForMenu:withEvent:]):
3165         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
3166         and use a bigger hammer (removeAllItems).
3167
3168         (-[WebActionMenuController willOpenMenu:withEvent:]):
3169         If we end up with a menu with no items, don't change selection or anything.
3170
3171 2014-11-20  Beth Dakin  <bdakin@apple.com>
3172
3173         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
3174         https://bugs.webkit.org/show_bug.cgi?id=138568
3175         -and corresponding-
3176         rdar://problem/18904600
3177
3178         Reviewed by Tim Horton.
3179
3180         Skip images for lookup.
3181         * WebView/WebActionMenuController.mm:
3182         (performDictionaryLookupForRange):
3183
3184 2014-11-19  Beth Dakin  <bdakin@apple.com>
3185
3186         Invoking an action menu on a selection should result in the text menu
3187         https://bugs.webkit.org/show_bug.cgi?id=138892
3188         -and corresponding-
3189         rdar://problem/18996776
3190
3191         Reviewed by Tim Horton.
3192
3193         * WebView/WebActionMenuController.mm:
3194         (-[WebActionMenuController _defaultMenuItems]):
3195
3196 2014-11-19  Beth Dakin  <bdakin@apple.com>
3197
3198         Data detected results with no menu items should not fall through to regular text 
3199         action menus
3200         https://bugs.webkit.org/show_bug.cgi?id=138887
3201         -and corresponding-
3202         rdar://problem/18971616
3203
3204         Reviewed by Tim Horton.
3205
3206         * WebView/WebActionMenuController.mm:
3207         (-[WebActionMenuController _defaultMenuItems]):
3208
3209 2014-11-19  Daniel Bates  <dabates@apple.com>
3210
3211         [iOS] Make WebKit build with public iOS SDK
3212         https://bugs.webkit.org/show_bug.cgi?id=136863
3213
3214         Reviewed by David Kilzer.
3215
3216         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
3217         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
3218         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
3219         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
3220         may be used by Apple internal clients that do not include wtf/Platform.h.
3221         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
3222         private Foundation headers directly.
3223         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
3224         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
3225         instead of including private CFNetwork headers directly. Also fixed up style and
3226         ordering of header include directives.
3227         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
3228         CFNetwork headers directly. Also sort the #import directives.
3229         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
3230         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
3231
3232 2014-11-18  David Kilzer  <ddkilzer@apple.com>
3233
3234         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
3235         <http://webkit.org/b/138813>
3236
3237         Reviewed by Mark Rowe.
3238
3239         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
3240         selectors.
3241
3242 2014-11-18  Chris Dumez  <cdumez@apple.com>
3243
3244         Add a setting to toggle DOMTimer throttling support
3245         https://bugs.webkit.org/show_bug.cgi?id=138844
3246         <rdar://problem/19020874>
3247
3248         Reviewed by Andreas Kling.
3249
3250         Add a setting to disable DOM timers throttling, in order to help
3251         developers determine if a specific issue is caused by timer
3252         throttling.
3253
3254         * WebView/WebPreferenceKeysPrivate.h:
3255         * WebView/WebPreferences.mm:
3256         (+[WebPreferences initialize]):
3257         (-[WebPreferences domTimersThrottlingEnabled]):
3258         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
3259         * WebView/WebPreferencesPrivate.h:
3260         * WebView/WebView.mm:
3261         (-[WebView _preferencesChanged:]):
3262
3263 2014-11-18  Tim Horton  <timothy_horton@apple.com>
3264
3265         Avoid re-encoding action menu image data
3266         https://bugs.webkit.org/show_bug.cgi?id=138817
3267         <rdar://problem/18840382>
3268
3269         Reviewed by Anders Carlsson.
3270
3271         * WebView/WebActionMenuController.mm:
3272         (-[WebActionMenuController _defaultMenuItemsForImage:]):
3273         (-[WebActionMenuController _addImageToPhotos:]):
3274         Build a temporary filename from a UUID and the image's desired extension.
3275         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
3276         Build an image menu only if we have an image, URL, data, and extension.
3277
3278 2014-11-18  Daniel Bates  <dabates@apple.com>
3279
3280         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
3281         SPI are not available in public SDK
3282         https://bugs.webkit.org/show_bug.cgi?id=138802
3283
3284         Reviewed by David Kilzer.
3285
3286         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
3287         libdispatch and MobileGestalt headers directly.
3288
3289         * WebView/WebView.mm:
3290
3291 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
3292
3293         Remove calls to deprecated NSMenu methods
3294         https://bugs.webkit.org/show_bug.cgi?id=138808.
3295
3296         Reviewed by Anders Carlsson.
3297
3298         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
3299
3300         * WebCoreSupport/PopupMenuMac.mm:
3301         (PopupMenuMac::populate):
3302
3303 2014-11-17  Daniel Bates  <dabates@apple.com>
3304
3305         Unreviewed, rolling out r176232.
3306
3307         Broke the Mac build. Will investigate offline.
3308
3309         Reverted changeset:
3310
3311         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
3312         MobileGestalt"
3313         https://bugs.webkit.org/show_bug.cgi?id=138802
3314         http://trac.webkit.org/changeset/176232
3315
3316 2014-11-17  Daniel Bates  <dabates@apple.com>
3317
3318         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
3319         SPI are not available in public SDK
3320         https://bugs.webkit.org/show_bug.cgi?id=138802
3321
3322         Reviewed by David Kilzer.
3323
3324         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
3325         libdispatch and MobileGestalt headers directly.
3326
3327         * WebView/WebView.mm:
3328
3329 2014-11-17  Beth Dakin  <bdakin@apple.com>
3330
3331         Whitespace action menus should focus the HitTestResult and create an insertion 
3332         point
3333         https://bugs.webkit.org/show_bug.cgi?id=138786
3334         -and corresponding-
3335         rdar://problem/18944893
3336
3337         Reviewed by Tim Horton.
3338
3339         Whitespace menus should cause the HitTestResult to be focused, and they should set 
3340         the selection based on the HitTest location.
3341
3342         * WebView/WebActionMenuController.mm:
3343         (-[WebActionMenuController isMenuForTextContent]):
3344         (-[WebActionMenuController focusAndSelectHitTestResult]):
3345         (-[WebActionMenuController willOpenMenu:withEvent:]):
3346
3347 2014-11-17  Daniel Bates  <dabates@apple.com>
3348
3349         [iOS] QuartzCore SPI not available in public SDK
3350         https://bugs.webkit.org/show_bug.cgi?id=138751
3351
3352         Reviewed by David Kilzer.
3353
3354         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
3355
3356         * WebInspector/WebNodeHighlight.mm:
3357         * WebView/WebIndicateLayer.mm:
3358
3359 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
3360
3361         [iOS] allow host application to opt-out of alternate fullscreen
3362         https://bugs.webkit.org/show_bug.cgi?id=138787
3363
3364         Reviewed by Darin Adler.
3365
3366         * WebView/WebPreferenceKeysPrivate.h:
3367         * WebView/WebPreferences.mm:
3368         (+[WebPreferences initialize]):
3369         (-[WebPreferences allowsAlternateFullscreen]):
3370         (-[WebPreferences setAllowsAlternateFullscreen:]):
3371         * WebView/WebPreferencesPrivate.h:
3372         * WebView/WebView.mm:
3373         (-[WebView _preferencesChanged:]):
3374
3375 2014-11-16  Tim Horton  <timothy_horton@apple.com>
3376
3377         Use TextIndicator instead of the built in Lookup highlight
3378         https://bugs.webkit.org/show_bug.cgi?id=138775
3379         <rdar://problem/18953982>
3380
3381         Reviewed by Anders Carlsson.
3382
3383         * WebCoreSupport/WebSystemInterface.mm:
3384         (InitWebCoreSystemInterface):
3385         Remove a WKSI import.
3386
3387         * WebView/WebActionMenuController.mm:
3388         (-[WebActionMenuController _lookupText:]):
3389         (-[WebActionMenuController _createActionMenuItemForTag:]):
3390         Make use of the new Lookup SPI header.
3391         Disable the Lookup item if lookup is not available.
3392
3393 2014-11-15  Tim Horton  <timothy_horton@apple.com>
3394
3395         Implement data detectors and mailto action menus for WebKit1
3396         https://bugs.webkit.org/show_bug.cgi?id=138765
3397         <rdar://problem/18877535>
3398
3399         Reviewed by Beth Dakin.
3400
3401         * WebView/WebActionMenuController.h:
3402         * WebView/WebActionMenuController.mm:
3403         (-[WebActionMenuController willOpenMenu:withEvent:]):
3404         Tell DataDetectors that the menu is going to open.
3405         Select the text (or not) based on the number of items in the menu, just like WebKit2.
3406
3407         (-[WebActionMenuController didCloseMenu:withEvent:]):
3408         Tell DataDetectors that the menu closed.
3409
3410         (-[WebActionMenuController _defaultMenuItemsForLink]):
3411         Move these checks out of _defaultMenuItemsForLink, because we expect this
3412         to always return a complete link menu.
3413
3414         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
3415         Implement. More or less copied from WebKit2.
3416
3417         (-[WebActionMenuController _selectDataDetectedText]):
3418         Select the stashed range.
3419
3420         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
3421         Implement. More or less copied from WebKit2.
3422         The yellow highlight isn't hooked up yet.
3423         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
3424
3425         (-[WebActionMenuController _selectLookupText]):
3426         Remove an unnecessary return.
3427
3428         (-[WebActionMenuController _defaultMenuItems]):
3429         Call into the two new menu types.
3430
3431         * WebView/WebUIDelegatePrivate.h:
3432
3433 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
3434
3435         Get rid of WebFontCache
3436         https://bugs.webkit.org/show_bug.cgi?id=134752
3437
3438         Reviewed by Dave Hyatt.
3439
3440         * WebView/WebHTMLView.mm:
3441
3442 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
3443
3444         Update some artwork for the legacy WebKit action menu
3445         https://bugs.webkit.org/show_bug.cgi?id=138758
3446         <rdar://problem/18989840>
3447
3448         * WebView/WebActionMenuController.mm:
3449         (webKitBundleImageNamed): Deleted.
3450         Fix the build.
3451
3452 2014-11-14  Tim Horton  <timothy_horton@apple.com>
3453
3454         Update some artwork for the legacy WebKit action menu
3455         https://bugs.webkit.org/show_bug.cgi?id=138758
3456         <rdar://problem/18989840>
3457
3458         Reviewed by Simon Fraser.
3459
3460         * WebView/WebActionMenuController.mm:
3461         (-[WebActionMenuController _createActionMenuItemForTag:]):
3462
3463 2014-11-14  Daniel Bates  <dabates@apple.com>
3464
3465         [iOS] NSFileManager and QuickLook SPI not available in public SDK
3466         https://bugs.webkit.org/show_bug.cgi?id=138742
3467
3468         Reviewed by Pratik Solanki.
3469
3470         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
3471
3472         * WebCoreSupport/WebFrameLoaderClient.mm:
3473
3474 2014-11-14  Beth Dakin  <bdakin@apple.com>
3475
3476         WK1: Webpage preview can come up in wrong location
3477         https://bugs.webkit.org/show_bug.cgi?id=138747
3478         -and corresponding-
3479         rdar://problem/18979004
3480
3481         Reviewed by Tim Horton.
3482
3483         Converting to window twice is bad.
3484         * WebView/WebActionMenuController.mm:
3485         (elementBoundingBoxInWindowCoordinatesFromNode):
3486         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
3487         (elementBoundingBoxFromNode): Deleted.
3488
3489 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
3490
3491         Move FontMac and FontCacheMac off of WKSI
3492         https://bugs.webkit.org/show_bug.cgi?id=138633
3493
3494         Reviewed by Simon Fraser.
3495
3496         * WebCoreSupport/WebSystemInterface.mm:
3497         (InitWebCoreSystemInterface):
3498         * WebKit.order:
3499
3500 2014-11-13  Beth Dakin  <bdakin@apple.com>
3501
3502         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
3503         https://bugs.webkit.org/show_bug.cgi?id=138716
3504         -and corresponding-
3505         rdar://problem/18977222
3506
3507         Reviewed by Tim Horton.
3508
3509         It’s not necessary to use the WebElementDictionary for so many things now that we 
3510         are caching the HitTestResult. We should just use the HitTestResult.
3511
3512         * WebView/WebActionMenuController.mm:
3513         (-[WebActionMenuController prepareForMenu:withEvent:]):
3514         (-[WebActionMenuController _openURLFromActionMenu:]):
3515         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
3516         (elementBoundingBoxFromNode):
3517         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
3518         (-[WebActionMenuController _defaultMenuItemsForLink]):
3519         (-[WebActionMenuController _defaultMenuItemsForImage]):
3520         (-[WebActionMenuController _defaultMenuItemsForVideo]):
3521         (-[WebActionMenuController _defaultMenuItemsForText]):
3522         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
3523         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
3524         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
3525         (-[WebActionMenuController _createActionMenuItemForTag:]):
3526         (-[WebActionMenuController _defaultMenuItems]):
3527         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
3528         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
3529         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
3530         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
3531         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
3532         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
3533         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
3534         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
3535         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
3536         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
3537
3538 2014-11-13  Daniel Bates  <dabates@apple.com>
3539
3540         [iOS] NSGeometry data types are not available in the public SDK
3541         https://bugs.webkit.org/show_bug.cgi?id=137536
3542
3543         Reviewed by David Kilzer.
3544
3545         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
3546         private header.
3547
3548         * DOM/WebDOMOperationsPrivate.h:
3549
3550 2014-11-13  Beth Dakin  <bdakin@apple.com>
3551
3552         WK1: Support default actions for video
3553         https://bugs.webkit.org/show_bug.cgi?id=138713
3554         -and corresponding-
3555         rdar://problem/18877520
3556
3557         Reviewed by Tim Horton.
3558
3559         Call setToNonShadowAncestor() for media HitTestResults.
3560         * WebView/WebActionMenuController.mm:
3561         (-[WebActionMenuController performHitTestAtPoint:]):
3562
3563         Default items and actions.
3564         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
3565         (-[WebActionMenuController _copyVideoURL:]):
3566         (-[WebActionMenuController _saveVideoToDownloads:]):
3567         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3568         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3569         * WebView/WebUIDelegatePrivate.h:
3570
3571 2014-11-13  Tim Horton  <timothy_horton@apple.com>
3572
3573         WK1: Update icon for Add to Reading List
3574         https://bugs.webkit.org/show_bug.cgi?id=138710
3575         <rdar://problem/18975774>