1 2015-05-05 Myles C. Maxfield <mmaxfield@apple.com>
3 Revert "Introducing the Platform Abstraction Layer (PAL)"
4 https://bugs.webkit.org/show_bug.cgi?id=144751
8 PAL should be a new target inside WebCore, rather than a top-level folder.
10 * Configurations/FeatureDefines.xcconfig: Updated
12 2015-05-07 Dan Bernstein <mitz@apple.com>
14 <rdar://problem/19317140> [Xcode] Remove usage of AspenFamily.xcconfig in Source/
15 https://bugs.webkit.org/show_bug.cgi?id=144727
17 Reviewed by Darin Adler.
19 * Configurations/Base.xcconfig: Don’t include AspenFamily.xcconfig.
20 * Configurations/WebKitLegacy.xcconfig: Define INSTALL_PATH in terms of
21 INSTALL_PATH_PREFIX and INSTALL_PATH_ACTUAL, and define INSTALL_PATH_PREFIX for the iOS 8.x
24 2015-04-02 Myles C. Maxfield <mmaxfield@apple.com>
26 Introducing the Platform Abstraction Layer (PAL)
27 https://bugs.webkit.org/show_bug.cgi?id=143358
29 Reviewed by Simon Fraser.
31 * Configurations/FeatureDefines.xcconfig: Updated
33 2015-05-06 Antti Koivisto <antti@apple.com>
35 REGRESSION (r183467): Unable to start downloads in private browsing mode
36 https://bugs.webkit.org/show_bug.cgi?id=144533
38 Reviewed by Darin Adler.
40 * WebCoreSupport/WebFrameLoaderClient.mm:
41 (WebFrameLoaderClient::dispatchWillSendRequest):
43 Use updateFromDelegatePreservingOldProperties (like WK2) instead of doing the same thing manually.
45 2015-05-06 Ryosuke Niwa <rniwa@webkit.org>
47 Toggling underline on font panel removes strike through
48 https://bugs.webkit.org/show_bug.cgi?id=144670
49 <rdar://problem/3790443>
51 Reviewed by Darin Adler.
53 Use setStrikeThroughChange and setUnderlineChange added in r183770 to toggle underline and strike through.
55 * WebView/WebHTMLView.mm:
56 (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
57 (-[WebHTMLView _styleForAttributeChange:]):
58 (-[WebHTMLView changeAttributes:]):
60 2015-05-04 Ryosuke Niwa <rniwa@webkit.org>
62 Toggling underline or strike through affects each other
63 https://bugs.webkit.org/show_bug.cgi?id=27818
65 Reviewed by Darin Adler.
67 * WebView/WebFrame.mm:
68 (-[WebFrame _setTypingStyle:withUndoAction:]):
70 2015-05-01 Martin Robinson <mrobinson@igalia.com>
72 USE(...) macro should expect unprefixed variables
73 https://bugs.webkit.org/show_bug.cgi?id=144454
75 Reviewed by Daniel Bates.
77 * Misc/WebDownload.h: Replace all occurrences WTF_USE with USE.
79 2015-05-01 Brady Eidson <beidson@apple.com>
81 Add API to disable meta refreshes.
82 <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
84 Reviewed by Alexey Proskuryakov.
86 Add a preference to enable/disable meta refreshes, enabled by default.
88 * WebView/WebPreferenceKeysPrivate.h:
89 * WebView/WebPreferences.mm:
90 (+[WebPreferences initialize]):
91 (-[WebPreferences setMetaRefreshEnabled:]):
92 (-[WebPreferences metaRefreshEnabled]):
93 * WebView/WebPreferencesPrivate.h:
95 (-[WebView _preferencesChanged:]):
97 2015-04-30 Jon Davis <jond@apple.com>
99 Web Inspector: console should show an icon for console.info() messages
100 https://bugs.webkit.org/show_bug.cgi?id=18530
102 Reviewed by Timothy Hatcher.
104 * WebCoreSupport/WebChromeClient.mm:
105 (stringForMessageLevel):
106 * WebView/WebUIDelegatePrivate.h:
108 2015-04-29 Myles C. Maxfield <mmaxfield@apple.com>
110 [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
111 https://bugs.webkit.org/show_bug.cgi?id=132159
113 Reviewed by Darin Adler.
115 Add SPI to set the font whitelist.
117 * WebView/WebView.mm:
118 (+[WebView _setFontWhitelist:]):
119 * WebView/WebViewPrivate.h:
121 2015-04-28 Timothy Horton <timothy_horton@apple.com>
123 [TextIndicator] Yellow highlight takes too long to fade out on scroll
124 https://bugs.webkit.org/show_bug.cgi?id=144358
125 <rdar://problem/19451011>
127 Reviewed by Beth Dakin.
129 * WebView/WebActionMenuController.mm:
130 (-[WebActionMenuController _showTextIndicator]):
131 * WebView/WebHTMLView.mm:
132 (-[WebHTMLView quickLookWithEvent:]):
133 * WebView/WebImmediateActionController.mm:
134 (-[WebImmediateActionController _defaultAnimationController]):
135 (-[WebImmediateActionController _animationControllerForDataDetectedText]):
136 (-[WebImmediateActionController _animationControllerForDataDetectedLink]):
137 Pull _clearTextIndicatorWithAnimation out, make it avoid using a dismissal animation
138 if we're called from didHandleScrollWheel.
140 * WebView/WebView.mm:
141 (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
142 (-[WebView _setTextIndicator:]):
143 (-[WebView _setTextIndicator:withLifetime:]):
144 (-[WebView _clearTextIndicator]):
145 (-[WebView _showDictionaryLookupPopup:]):
146 (-[WebView _dictionaryLookupPopoverWillClose:]):
147 (-[WebView _setTextIndicator:fadeOut:]): Deleted.
148 * WebView/WebViewInternal.h:
149 Make _setTextIndicator take a reference.
150 Add a variant of _setTextIndicator that takes a Lifetime.
151 Make _clearTextIndicatorWithAnimation take a DismissalAnimation.
153 2015-04-28 Michael Catanzaro <mcatanzaro@igalia.com>
155 Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
156 https://bugs.webkit.org/show_bug.cgi?id=144304
158 Reviewed by Geoffrey Garen.
160 Define ENABLE_JIT, enabled by default, instead of ENABLE_LLINT_C_LOOP, disabled by default.
162 * Configurations/FeatureDefines.xcconfig:
164 2015-04-28 Commit Queue <commit-queue@webkit.org>
166 Unreviewed, rolling out r183514.
167 https://bugs.webkit.org/show_bug.cgi?id=144359
169 It broke cloop test bots (Requested by mcatanzaro on #webkit).
173 "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
174 https://bugs.webkit.org/show_bug.cgi?id=144304
175 http://trac.webkit.org/changeset/183514
177 2015-04-28 Michael Catanzaro <mcatanzaro@igalia.com>
179 Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
180 https://bugs.webkit.org/show_bug.cgi?id=144304
182 Reviewed by Geoffrey Garen.
184 Define ENABLE_JIT, enabled by default, instead of ENABLE_LLINT_C_LOOP, disabled by default.
186 * Configurations/FeatureDefines.xcconfig:
188 2015-04-28 Joseph Pecoraro <pecoraro@apple.com>
190 Fix common typo "targetting" => "targeting"
191 https://bugs.webkit.org/show_bug.cgi?id=144349
193 Reviewed by Daniel Bates.
195 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
196 (WebKit::NetscapePluginInstanceProxy::loadRequest):
197 * Plugins/WebNetscapePluginView.mm:
198 (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
199 * WebView/WebPolicyDelegate.h:
201 2015-04-28 Brady Eidson <beidson@apple.com>
203 Consolidate most "frame load" arguments into FrameLoadRequest.
204 https://bugs.webkit.org/show_bug.cgi?id=144276
206 Reviewed by Alexey Proskuryakov.
208 * WebView/WebPDFView.mm:
209 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
211 2015-04-27 Dan Bernstein <mitz@apple.com>
213 <rdar://problem/20721931> REGRESSION (r178753): All legacy framework headers are missing availability annotations
214 https://bugs.webkit.org/show_bug.cgi?id=144311
216 Reviewed by Adele Peterson.
218 * postprocess-headers.sh: Changed “macsox” to “macosx”.
220 2015-04-27 Brady Eidson <beidson@apple.com>
222 Make 'enum NavigationType' be an enum class
223 https://bugs.webkit.org/show_bug.cgi?id=144270
225 Reviewed by Alex Christensen.
227 * WebCoreSupport/WebFrameLoaderClient.mm:
228 (WebFrameLoaderClient::actionDictionary):
230 2015-04-27 Brent Fulgham <bfulgham@apple.com>
232 REGRESSION(r182879): Images and video can no longer be downloaded
233 https://bugs.webkit.org/show_bug.cgi?id=144267
234 <rdar://problem/20702844>
236 Reviewed by Simon Fraser.
238 * WebView/WebActionMenuController.mm:
239 (-[WebActionMenuController _createActionMenuItemForTag:]): Check for
240 "!WebCore::protocolIs(..., "file")" for image and media downloads.
242 2015-04-26 Yusuke Suzuki <utatane.tea@gmail.com>
244 [ES6] Implement ES6 template literals
245 https://bugs.webkit.org/show_bug.cgi?id=142691
247 Reviewed by Darin Adler.
249 Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
251 * Configurations/FeatureDefines.xcconfig:
253 2015-04-26 Doug Russell <d_russell@apple.com>
255 AX: richer text change notifications (142719)
256 https://bugs.webkit.org/show_bug.cgi?id=142719
258 Reviewed by Darin Adler.
260 Richer accessibility value change notifications. Introduce AXTextEditType,
261 postTextStateChangeNotification and postTextReplacementNotification to give assistive
262 tech apps more reliable context for responding to changes in web content. Also implement
263 a mechanism to post value changes in password form fields in coalesced ticks to thwart
264 analyzing the cadence of changes.
266 Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
267 and an overload of postTextReplacementNotification to give assistive tech apps more
268 reliable context for responding to changes in web content selection. Also block posting
269 selection changes on password fields.
271 * WebCoreSupport/WebEditorClient.mm:
272 (undoNameForEditAction):
274 2015-04-24 Timothy Hatcher <timothy@apple.com>
276 Web Inspector: Remove native window dock controls
277 https://bugs.webkit.org/show_bug.cgi?id=144184
279 Reviewed by Joseph Pecoraro.
281 * Resources/Dock.pdf: Removed.
282 * Resources/DockLegacy.pdf: Removed.
283 * WebCoreSupport/WebInspectorClient.mm:
284 (-[WebInspectorWindowController window]):
285 (-[WebInspectorWindowController setDockingUnavailable:]):
287 2015-04-25 Martin Robinson <mrobinson@igalia.com>
289 Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
290 https://bugs.webkit.org/show_bug.cgi?id=144182
292 Reviewed by Simon Fraser.
294 * Configurations/FeatureDefines.xcconfig: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
296 2015-04-24 Commit Queue <commit-queue@webkit.org>
298 Unreviewed, rolling out r183266.
299 https://bugs.webkit.org/show_bug.cgi?id=144164
301 Broke 32-bit build and a test. (Requested by ap on #webkit).
305 "AX: richer text change notifications (142719)"
306 https://bugs.webkit.org/show_bug.cgi?id=142719
307 http://trac.webkit.org/changeset/183266
309 2015-04-24 Myles C. Maxfield <mmaxfield@apple.com>
311 [Cocoa] Start cleaning up FontPlatformData
312 https://bugs.webkit.org/show_bug.cgi?id=144133
314 Reviewed by Enrica Casucci.
316 Receive casts which have been hoisted from the deleted FontPlatformData constructor.
318 * Misc/WebKitNSStringExtras.mm:
319 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Receive cast which has
320 been hoisted from the deleted FontPlatformData constructor.
321 (-[NSString _web_widthWithFont:]): Ditto.
322 * Misc/WebStringTruncator.mm:
323 (fontFromNSFont): Ditto.
325 2015-04-24 Doug Russell <d_russell@apple.com>
327 AX: richer text change notifications (142719)
328 https://bugs.webkit.org/show_bug.cgi?id=142719
330 Reviewed by Darin Adler.
332 Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
334 Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
336 * WebCoreSupport/WebEditorClient.mm:
337 (undoNameForEditAction):
339 2015-04-23 Jer Noble <jer.noble@apple.com>
341 [Mac] Disable QTKit by default on future OS X.
342 https://bugs.webkit.org/show_bug.cgi?id=144082
344 Reviewed by Darin Adler.
346 Default WebKitQTKitEnabledPreferenceKey to NO.
348 * WebView/WebPreferences.mm:
349 (+[WebPreferences initialize]):
351 2015-04-23 Andreas Kling <akling@apple.com>
353 There should only be one way to get the system memory size.
354 <https://webkit.org/b/144081>
356 Reviewed by Antti Koivisto.
358 * Misc/WebKitSystemBits.h:
359 * Misc/WebKitSystemBits.m:
360 (WebMemorySize): Deleted.
361 * WebView/WebView.mm:
362 (+[WebView _setCacheModel:]):
363 (roundUpToPowerOf2): Deleted.
365 2015-04-22 Darin Adler <darin@apple.com>
367 Remove OwnPtr and PassOwnPtr use from WebKit/cf, WebKit/mac, and WebKit2
368 https://bugs.webkit.org/show_bug.cgi?id=143943
370 Reviewed by Anders Carlsson.
372 * Plugins/Hosted/ProxyInstance.h: Removed unneeded include.
373 * Plugins/WebBaseNetscapePluginView.h: Ditto.
375 * Plugins/WebNetscapePluginEventHandler.h: Use unique_ptr instead of
376 PassOwnPtr for the create function. Also tweaked formatting and removed
377 unneeded forward declaration of CGRect.
378 * Plugins/WebNetscapePluginEventHandler.mm:
379 (WebNetscapePluginEventHandler::create): Changed to use unique_ptr and
382 * Plugins/WebNetscapePluginView.h: Use unique_ptr instead of OwnPtr for
383 the _eventHandler field.
384 * Plugins/WebNetscapePluginView.mm:
385 (-[WebNetscapePluginView destroyPlugin]): Changed code to work with unique_ptr.
387 * WebCoreSupport/WebUserMediaClient.mm: Removed unneeded include.
389 * WebView/WebDeviceOrientationProviderMock.mm: Changed to use make_unique.
390 * WebView/WebDeviceOrientationProviderMockInternal.h: Changed to use unique_ptr.
392 * WebView/WebFrame.mm:
393 (vectorForDictationPhrasesArray): Changed to return Vector<Vector<String>> and
394 not a PassOwnPtr. Also rewrote to be much simpler, although there is still a
395 pre-existing problem here where this could put empty vectors into the result,
396 and I'm pretty sure the client never expects any of the Vector<String> to be empty.
397 (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
398 Rewrote logic to involve WebCore types a bit less; old code was round tripping
399 things through WebCore::URL for no obvious reason.
401 * WebView/WebFrameInternal.h: Changed vectorForDictationPhrasesArray to return
402 a Vector<Vector<String>> and not a PassOwnPtr.
404 * WebView/WebFullScreenController.h: Removed unneeded include.
406 * WebView/WebViewData.h: Changed m_alternativeTextUIController to be a
407 m_alternativeTextUIController.
408 * WebView/WebViewData.mm:
409 (-[WebViewPrivate init]): Use make_unique to initialize m_alternativeTextUIController.
411 2015-04-22 Brent Fulgham <bfulgham@apple.com>
413 VisibleSelection should only accept Range by reference
414 https://bugs.webkit.org/show_bug.cgi?id=144047
416 Reviewed by Tim Horton.
418 Update all uses of VisibleSelection to pass a Range reference instead
421 * WebCoreSupport/WebContextMenuClient.mm:
422 (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
423 * WebView/WebFrame.mm:
424 (-[WebFrame _selectNSRange:]):
426 2015-04-22 Eric Carlson <eric.carlson@apple.com>
428 [Mac] Device picker menu is positioned incorrectly in WK1
429 https://bugs.webkit.org/show_bug.cgi?id=144049
430 <rdar://problem/20493101>
432 Reviewed by Dean Jackson.
434 * WebView/WebView.mm:
435 (-[WebView _showPlaybackTargetPicker:location:hasVideo:]): Mouse location is already in
436 window coordinates so don't call convertRect:toView:nil.
438 2015-04-21 Brent Fulgham <bfulgham@apple.com>
440 Extend action menus to support PDF
441 https://bugs.webkit.org/show_bug.cgi?id=143895
442 <rdar://problem/19003333>
444 Reviewed by Tim Horton.
446 Prevent a crash when someone attempts to invoke an action menu on a PDF hosted
449 * WebView/WebActionMenuController.mm:
450 (-[WebActionMenuController performHitTestAtPoint:]): Handle WebPDFView as well as
451 the WebHTMLView case.
452 * WebView/WebDocument.h:
453 * WebView/WebHTMLView.h:
454 * WebView/WebHTMLView.mm:
455 (-[WebHTMLView _frame]):
456 * WebView/WebHTMLViewInternal.h:
457 * WebView/WebPDFView.h:
458 * WebView/WebPDFView.mm:
459 (-[WebPDFView _frame]): Added.
461 2015-04-22 Eric Carlson <eric.carlson@apple.com>
463 Unreviewed post-review clean up after r183096.
465 * WebView/WebMediaPlaybackTargetPicker.h:
467 2015-04-21 Eric Carlson <eric.carlson@apple.com>
469 [Mac] Use one playback target for all web processes
470 https://bugs.webkit.org/show_bug.cgi?id=144009
472 Reviewed by Tim Horton.
474 Update to use WebMediaSessionManager for playback target management.
476 * WebCoreSupport/WebChromeClient.h:
477 * WebCoreSupport/WebChromeClient.mm:
478 (WebChromeClient::addPlaybackTargetPickerClient):
479 (WebChromeClient::removePlaybackTargetPickerClient):
480 (WebChromeClient::showPlaybackTargetPicker):
481 (WebChromeClient::playbackTargetPickerClientStateDidChange):
482 (WebChromeClient::startingMonitoringPlaybackTargets): Deleted.
483 (WebChromeClient::stopMonitoringPlaybackTargets): Deleted.
484 * WebView/WebMediaPlaybackTargetPicker.h:
485 * WebView/WebMediaPlaybackTargetPicker.mm:
486 (WebMediaPlaybackTargetPicker::addPlaybackTargetPickerClient):
487 (WebMediaPlaybackTargetPicker::removePlaybackTargetPickerClient):
488 (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
489 (WebMediaPlaybackTargetPicker::playbackTargetPickerClientStateDidChange):
490 (WebMediaPlaybackTargetPicker::setPlaybackTarget):
491 (WebMediaPlaybackTargetPicker::externalOutputDeviceAvailableDidChange):
492 (WebMediaPlaybackTargetPicker::setShouldPlayToPlaybackTarget):
493 (WebMediaPlaybackTargetPicker::invalidate):
494 (WebMediaPlaybackTargetPicker::startingMonitoringPlaybackTargets): Deleted.
495 (WebMediaPlaybackTargetPicker::stopMonitoringPlaybackTargets): Deleted.
496 (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): Deleted.
497 (WebMediaPlaybackTargetPicker::targetPicker): Deleted.
498 * WebView/WebView.mm:
499 (-[WebView _addPlaybackTargetPickerClient:]):
500 (-[WebView _removePlaybackTargetPickerClient:]):
501 (-[WebView _showPlaybackTargetPicker:location:hasVideo:]):
502 (-[WebView _playbackTargetPickerClientStateDidChange:state:]):
503 (-[WebView _showPlaybackTargetPicker:hasVideo:]): Deleted.
504 (-[WebView _startingMonitoringPlaybackTargets]): Deleted.
505 (-[WebView _stopMonitoringPlaybackTargets]): Deleted.
506 * WebView/WebViewInternal.h:
508 2015-04-20 Alexey Proskuryakov <ap@apple.com>
510 Disable mixed content blocking for existing WebKit1 clients
511 https://bugs.webkit.org/show_bug.cgi?id=143955
512 rdar://problem/20177186
514 Reviewed by Oliver Hunt.
516 * Misc/WebKitVersionChecks.h:
517 * WebView/WebView.mm:
518 (shouldAllowInsecureContent):
519 (-[WebView _preferencesChanged:]):
521 2015-04-20 Tim Horton <timothy_horton@apple.com>
523 Implement immediate action support for tel: and mailto: URLs
524 https://bugs.webkit.org/show_bug.cgi?id=143916
525 <rdar://problem/19721711>
527 Reviewed by Darin Adler.
529 * WebView/WebImmediateActionController.mm:
530 (-[WebImmediateActionController _defaultAnimationController]):
531 (-[WebImmediateActionController _animationControllerForDataDetectedText]):
532 (-[WebImmediateActionController _animationControllerForDataDetectedLink]):
533 (-[WebImmediateActionController _menuItemForDataDetectedText]): Deleted.
534 * WebView/WebUIDelegatePrivate.h:
535 Add _animationControllerForDataDetectedLink and use it when
536 building immediate actions for tel: and mailto: links.
538 2015-04-17 Daniel Bates <dabates@apple.com>
540 REGRESSION: SVG does not support link dragging
541 https://bugs.webkit.org/show_bug.cgi?id=141597
543 Reviewed by Darin Adler.
545 Write -[WebElementDictionary _isLiveLink] in terms of WebCore::isDraggableLink().
547 * Misc/WebElementDictionary.mm:
548 (-[WebElementDictionary _isLiveLink]):
550 2015-04-16 Sam Weinig <sam@webkit.org>
552 Expose JavaScriptMarkupEnabled preference for WebKit1
553 <rdar://problem/19939450>
554 https://bugs.webkit.org/show_bug.cgi?id=143855
556 Reviewed by Dan Bernstein.
558 * WebView/WebPreferenceKeysPrivate.h:
559 Add new key, WebKitJavaScriptMarkupEnabledPreferenceKey
561 * WebView/WebPreferences.mm:
562 (+[WebPreferences initialize]):
563 Initialize WebKitJavaScriptMarkupEnabledPreferenceKey to YES.
565 (-[WebPreferences isJavaScriptMarkupEnabled]):
566 (-[WebPreferences setJavaScriptMarkupEnabled:]):
567 Implement getter/setter.
569 * WebView/WebPreferencesPrivate.h:
570 Add new property, javaScriptMarkupEnabled.
572 * WebView/WebView.mm:
573 (-[WebView _preferencesChanged:]):
574 Map the new preference to WebCore's scriptMarkupEnabled setting.
576 2015-04-15 Brent Fulgham <bfulgham@apple.com>
578 [Mac] Disable "Save to Downloads" option for local files
579 https://bugs.webkit.org/show_bug.cgi?id=143794
581 Reviewed by Tim Horton.
583 Disable the Image and Media download options if the download
584 target is a local file. We can only download web resources;
585 anything else is actually a no-op.
587 * WebView/WebActionMenuController.mm:
588 (-[WebActionMenuController _defaultMenuItemsForImage]):
589 (-[WebActionMenuController _defaultMenuItemsForVideo]):
591 2015-04-15 Alex Christensen <achristensen@webkit.org>
593 Progress towards CMake on Mac.
594 https://bugs.webkit.org/show_bug.cgi?id=143785
596 Reviewed by Csaba Osztrogonác.
598 * WebView/WebPDFDocumentExtras.mm:
599 * WebView/WebPDFView.mm:
601 2015-04-13 Jer Noble <jer.noble@apple.com>
603 [Fullscreen] ChromeClient::exitVideoFullscreen() should take a pointer to a HTMLVideoElement.
604 https://bugs.webkit.org/show_bug.cgi?id=143674
606 Reviewed by Darin Adler.
608 * WebCoreSupport/WebChromeClient.h:
609 * WebCoreSupport/WebChromeClient.mm:
610 (WebChromeClient::enterVideoFullscreenForVideoElement): Takes a reference.
611 (WebChromeClient::exitVideoFullscreenForVideoElement): Renamed from exitVideoFullscreen().
612 (WebChromeClient::exitVideoFullscreen): Deleted.
614 2015-04-14 Simon Fraser <simon.fraser@apple.com>
616 Re-enable custom dilation for antialiased fonts
617 https://bugs.webkit.org/show_bug.cgi?id=143738
619 Reviewed by Tim Horton.
621 Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
622 but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
623 a private WebKit pref. This pref defaults to YES, enabling the feature by default
624 in WK1 as we do for WK2.
626 * WebView/WebPreferenceKeysPrivate.h:
627 * WebView/WebPreferences.mm:
628 (+[WebPreferences initialize]):
629 (-[WebPreferences setAntialiasedFontDilationEnabled:]):
630 (-[WebPreferences antialiasedFontDilationEnabled]):
631 * WebView/WebPreferencesPrivate.h:
632 * WebView/WebView.mm:
633 (-[WebView _preferencesChanged:]):
635 2015-04-13 Brady Eidson <beidson@apple.com>
637 Share sheets from Share menus appear outside the browser window.
638 <rdar://problem/20455592> and https://bugs.webkit.org/show_bug.cgi?id=143620
640 Reviewed by Darin Adler.
642 Refactor existing Sharing Service Picker code to also be used for the Share menu NSMenuItem.
644 * Misc/WebSharingServicePickerController.h:
645 (WebSharingServicePickerClient::webView):
646 * Misc/WebSharingServicePickerController.mm:
647 (WebSharingServicePickerClient::WebSharingServicePickerClient):
648 (WebSharingServicePickerClient::sharingServicePickerWillBeDestroyed):
649 (WebSharingServicePickerClient::pageForSharingServicePicker):
650 (WebSharingServicePickerClient::windowForSharingServicePicker):
651 (WebSharingServicePickerClient::screenRectForCurrentSharingServicePickerItem):
652 (WebSharingServicePickerClient::imageForCurrentSharingServicePickerItem):
653 (-[WebSharingServicePickerController initWithItems:includeEditorServices:client:style:]):
654 (-[WebSharingServicePickerController initWithSharingServicePicker:client:]):
655 (-[WebSharingServicePickerController sharingService:didShareItems:]):
657 * WebCoreSupport/WebContextMenuClient.h:
658 (WebContextMenuClient::webView): Deleted.
659 * WebCoreSupport/WebContextMenuClient.mm:
660 (WebContextMenuClient::WebContextMenuClient):
661 (WebContextMenuClient::pageForSharingServicePicker): Deleted.
662 (WebContextMenuClient::windowForSharingServicePicker): Deleted.
664 * WebCoreSupport/WebSelectionServiceController.h:
665 * WebCoreSupport/WebSelectionServiceController.mm:
666 (WebSelectionServiceController::WebSelectionServiceController):
667 (WebSelectionServiceController::handleSelectionServiceClick):
668 (WebSelectionServiceController::pageForSharingServicePicker): Deleted.
669 (WebSelectionServiceController::windowForSharingServicePicker): Deleted.
670 (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem): Deleted.
671 (WebSelectionServiceController::imageForCurrentSharingServicePickerItem): Deleted.
673 * WebView/WebHTMLView.mm:
674 (-[WebHTMLView menuForEvent:]):
675 * WebView/WebViewData.h:
677 2015-04-13 Beth Dakin <bdakin@apple.com>
679 Add force property to MouseEvents
680 https://bugs.webkit.org/show_bug.cgi?id=143569
682 rdar://problem/20472954
684 Reviewed by Darin Adler.
686 PlatformMouseEvent and MouseEvent now take force parameters.
687 * WebView/WebFrame.mm:
688 (-[WebFrame _dragSourceEndedAt:operation:]):
689 * WebView/WebPDFView.mm:
690 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
692 2015-04-12 Darin Adler <darin@apple.com>
694 [Cocoa] Localizable strings are inconsistent and need to be regenerated
695 https://bugs.webkit.org/show_bug.cgi?id=143661
696 rdar://problem/19634388
698 Reviewed by Dan Bernstein.
700 * Misc/WebLocalizableStrings.mm:
701 (LoadWebLocalizedStringsTimerCallback): Moved the comment, useful for programmers but
702 not for localization, into a C++ source code comment, and made the localizer comment
703 consistent with the place this localizable string is used for actual localization.
704 * WebCoreSupport/WebEditorClient.mm:
705 (undoNameForEditAction): Changed the localizer comments for Delete and Dictation
706 to match the ones in WebKit2; no need to specify that these are iOS only, and if we do
707 want to specify that, we should not be using the term PLATFORM(IOS) since there is no
708 reason for us to expect localizers to understand that terminology. Also added a comment
709 about the fact that we have two copies of all the localizable strings.
711 2015-04-11 Yusuke Suzuki <utatane.tea@gmail.com>
713 [ES6] Enable Symbol in web pages
714 https://bugs.webkit.org/show_bug.cgi?id=143375
716 Reviewed by Ryosuke Niwa.
718 * WebView/WebPreferencesPrivate.h:
720 2015-04-08 Sam Weinig <sam@webkit.org>
722 Allow LaunchServices to handle URLs on link navigations
723 <rdar://problem/19446826>
724 https://bugs.webkit.org/show_bug.cgi?id=143544
726 Reviewed by Anders Carlsson.
728 * Configurations/WebKitLegacy.xcconfig:
729 Link MobileCoreServices.
731 * WebCoreSupport/WebFrameLoaderClient.h:
732 * WebCoreSupport/WebFrameLoaderClient.mm:
734 (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
735 (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
736 (WebFrameLoaderClient::setUpPolicyListener):
737 Only let LaunchServices have a crack at the URL if the navigation is:
738 1) a main frame navigation
739 2) a result of a user gesture
741 2015-04-10 Alexey Proskuryakov <ap@apple.com>
745 * Misc/WebNSURLExtras.mm: (-[NSString _webkit_unescapedQueryValue]): Ignore a deprecation.
747 2015-04-10 Eric Carlson <eric.carlson@apple.com>
749 [Mac] Refactor MediaPlaybackTarget
750 https://bugs.webkit.org/show_bug.cgi?id=143571
752 Reviewed by Jer Noble.
754 * WebView/WebMediaPlaybackTargetPicker.h:
755 * WebView/WebMediaPlaybackTargetPicker.mm:
756 (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): Take a Ref<MediaPlaybackTarget>&&.
758 2015-04-09 Andy Estes <aestes@apple.com>
760 [Cocoa] Add a HAVE(AVKIT) and use it
761 https://bugs.webkit.org/show_bug.cgi?id=143593
763 Reviewed by David Kilzer.
765 * WebView/WebPreferences.mm:
766 (+[WebPreferences initialize]): Only set WebKitAVKitEnabled to YES if HAVE(AVKIT).
767 (-[WebPreferences setAVKitEnabled:]): Only set value for WebKitAVKitEnabled if HAVE(AVKIT).
768 * WebView/WebView.mm:
769 (-[WebView _preferencesChanged:]): Only called Settings::setAVKitEnabled() if HAVE(AVKIT).
771 2015-04-09 Chris Dumez <cdumez@apple.com>
773 [WK2][iOS] editorState() should not cause a synchronous layout
774 https://bugs.webkit.org/show_bug.cgi?id=142536
775 <rdar://problem/20041506>
777 Reviewed by Enrica Casucci.
779 Provide implementation for EditorClient::didChangeSelectionAndUpdateLayout().
781 * WebCoreSupport/WebEditorClient.h:
783 2015-04-08 Brent Fulgham <bfulgham@apple.com>
785 [Mac] WebKit is not honoring OS preferences for secondary click behaviors
786 https://bugs.webkit.org/show_bug.cgi?id=143452
787 <rdar://problem/20437483>
789 Reviewed by Tim Horton.
791 We were improperly intercepting contextual menu clicks and passing them through
792 the mouseDown handler, rather than processing via NSView's menu handling code.
794 * WebView/WebHTMLView.mm:
795 (-[WebHTMLView otherMouseDown:]): Treat context menu events the same as the action
796 menu case, and pass it to AppKit for normal menu processing.
798 2015-04-08 Brady Eidson <beidson@apple.com>
800 Expose the "Share" menu for links, images, and media.
801 <rdar://problem/20435340> and https://bugs.webkit.org/show_bug.cgi?id=143502
803 Reviewed by Tim Horton.
805 * WebCoreSupport/WebContextMenuClient.h:
806 * WebCoreSupport/WebContextMenuClient.mm:
807 (WebContextMenuClient::shareMenuItem):
809 2015-04-08 Anders Carlsson <andersca@apple.com>
811 Move some ApplicationCache static member functions to ApplicationCacheStorage
812 https://bugs.webkit.org/show_bug.cgi?id=143524
814 Reviewed by Antti Koivisto.
816 * WebCoreSupport/WebApplicationCache.mm:
817 (+[WebApplicationCache diskUsageForOrigin:]):
818 (+[WebApplicationCache deleteAllApplicationCaches]):
819 (+[WebApplicationCache deleteCacheForOrigin:]):
821 2015-04-08 Chris Dumez <cdumez@apple.com>
823 Rename ActiveDOMObject::canSuspend() to canSuspendForPageCache() for clarity
824 https://bugs.webkit.org/show_bug.cgi?id=143513
826 Reviewed by Andreas Kling.
828 Update ScriptExecutionContext::canSuspendActiveDOMObjects() to
829 canSuspendActiveDOMObjectsForPageCache() as the method was renamed.
831 * WebView/WebFrame.mm:
832 (-[WebFrame _cacheabilityDictionary]):
834 2015-04-07 Anders Carlsson <andersca@apple.com>
836 Get rid of uses of ApplicationCacheStorage::singleton() from WebKitLegacy
837 https://bugs.webkit.org/show_bug.cgi?id=143504
839 Reviewed by Sam Weinig.
841 Add a webApplicationCacheStorage() function and use it throughout WebKitLegacy.
842 In the future, webApplicationCacheStorage will return a custom singleton, but for now
843 it just returns ApplicationCacheStorage::singleton().
847 * WebCoreSupport/WebApplicationCache.mm:
848 (+[WebApplicationCache maximumSize]):
849 (+[WebApplicationCache setMaximumSize:]):
850 (+[WebApplicationCache defaultOriginQuota]):
851 (+[WebApplicationCache setDefaultOriginQuota:]):
852 (+[WebApplicationCache originsWithCache]):
853 (webApplicationCacheStorage):
854 * WebCoreSupport/WebApplicationCacheInternal.h: Added.
855 * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
856 (-[WebApplicationCacheQuotaManager usage]):
857 (-[WebApplicationCacheQuotaManager quota]):
858 (-[WebApplicationCacheQuotaManager setQuota:]):
859 * WebView/WebView.mm:
860 (WebKitInitializeApplicationCachePathIfNecessary):
862 2015-04-07 Brady Eidson <beidson@apple.com>
864 ContextMenuItem refactoring
865 https://bugs.webkit.org/show_bug.cgi?id=143485
867 Reviewed by Beth Dakin.
869 * WebCoreSupport/WebContextMenuClient.mm:
870 (WebContextMenuClient::contextMenuItemSelected):
872 2015-04-06 Chris Dumez <cdumez@apple.com>
874 Bing video search result pages are not PageCacheable
875 https://bugs.webkit.org/show_bug.cgi?id=143463
876 <rdar://problem/20440916>
878 Reviewed by Alexey Proskuryakov.
880 Fix the iOS / WK1 build by using MemoryCache::resourceForRequest()
881 instead of resourceForUrl().
884 (+[WebCache imageForURL:]):
886 2015-04-05 Simon Fraser <simon.fraser@apple.com>
888 Remove "go ahead and" from comments
889 https://bugs.webkit.org/show_bug.cgi?id=143421
891 Reviewed by Darin Adler, Benjamin Poulain.
893 Remove the phrase "go ahead and" from comments where it doesn't add
894 anything (which is almost all of them).
896 * WebView/WebDynamicScrollBarsView.mm:
897 (-[WebDynamicScrollBarsView updateScrollers]):
898 * WebView/WebHTMLView.mm:
899 (-[WebHTMLView insertText:]):
901 2015-04-02 Brady Eidson <beidson@apple.com>
903 Unreviewed: Reland change after rollout.
905 Expose the "Share" menu for text selections on platforms where it's available.
906 rdar://problem/20034174 and https://bugs.webkit.org/show_bug.cgi?id=143318
908 * WebView/WebImmediateActionController.mm: Update for required #include
910 2015-04-02 Commit Queue <commit-queue@webkit.org>
912 Unreviewed, rolling out r182293.
913 https://bugs.webkit.org/show_bug.cgi?id=143355
915 Broke GTK and EFL builds. (Requested by bfulgham on #webkit).
919 "Expose the "Share" menu for text selections on platforms
920 where it's available."
921 https://bugs.webkit.org/show_bug.cgi?id=143318
922 http://trac.webkit.org/changeset/182293
924 2015-04-02 Brady Eidson <beidson@apple.com>
926 Expose the "Share" menu for text selections on platforms where it's available.
927 rdar://problem/20034174 and https://bugs.webkit.org/show_bug.cgi?id=143318
929 Reviewed by Sam Weinig.
931 * WebView/WebImmediateActionController.mm: Update for required #include
933 2015-04-02 Yusuke Suzuki <utatane.tea@gmail.com>
935 Clean up EnumerationMode to easily extend
936 https://bugs.webkit.org/show_bug.cgi?id=143276
938 Reviewed by Geoffrey Garen.
940 Use default EnumerationMode().
942 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
943 (WebKit::NetscapePluginInstanceProxy::enumerate):
945 2015-03-31 Simon Fraser <simon.fraser@apple.com>
947 Remove scrolling tree dependency on wheel event handler counts, and use fast scrolling even when there are wheel handlers
948 https://bugs.webkit.org/show_bug.cgi?id=143288
950 Reviewed by Beth Dakin.
952 Remove the wheel event counting that Document does, and passes into the scrolling tree.
953 The ScrollingTree now just uses the non-fast scrollable region to determine when to
954 fast scroll on pages with wheel event handlers.
956 * WebCoreSupport/WebChromeClient.h:
958 2015-03-31 Timothy Horton <timothy_horton@apple.com>
960 TextIndicator for <span> inside an <a> only highlights the <span>, should highlight the whole <a>
961 https://bugs.webkit.org/show_bug.cgi?id=143287
962 <rdar://problem/20318342>
964 Reviewed by Beth Dakin.
966 * WebView/WebImmediateActionController.mm:
967 (-[WebImmediateActionController _defaultAnimationController]):
968 Instead of just highlighting the hit element, highlight the whole
969 element that the link URL comes from.
971 2015-03-31 Yusuke Suzuki <utatane.tea@gmail.com>
973 Clean up Identifier factories to clarify the meaning of StringImpl*
974 https://bugs.webkit.org/show_bug.cgi?id=143146
976 Reviewed by Filip Pizlo.
978 Just change to Identifier::fromString.
980 * Plugins/Hosted/NetscapePluginHostProxy.mm:
981 (identifierFromIdentifierRep):
982 * Plugins/Hosted/ProxyInstance.mm:
983 (WebKit::ProxyInstance::getPropertyNames):
985 2015-03-28 Anders Carlsson <andersca@apple.com>
987 Remove an unused SPI method from WebKitLegacy
988 https://bugs.webkit.org/show_bug.cgi?id=143185
990 Reviewed by Sam Weinig.
992 * WebView/WebDataSource.mm:
993 (-[WebDataSource _transferApplicationCache:]): Deleted.
994 * WebView/WebDataSourcePrivate.h:
996 2015-03-26 Alex Christensen <achristensen@webkit.org>
998 Progress towards CMake on Mac.
999 https://bugs.webkit.org/show_bug.cgi?id=143112
1001 Reviewed by Chris Dumez.
1003 * WebCoreSupport/WebFrameLoaderClient.h:
1005 2015-03-26 Ryosuke Niwa <rniwa@webkit.org>
1007 Cursor doesn't change back to pointer when leaving Mail
1008 https://bugs.webkit.org/show_bug.cgi?id=132038
1010 Reviewed by Anders Carlsson.
1012 Fixed the bug by adding a cursor rect and making the primary tracking area update the cursor so that
1013 AppKit will reset the cursor as it leaves the WebView.
1015 We use nil cursor here since we manually update the cursor by calling [NSCursor set].
1017 * WebView/WebHTMLView.mm:
1018 (-[WebHTMLView setDataSource:]): Use NSTrackingCursorUpdate option in creating the primary tracking area.
1020 2015-03-24 Anders Carlsson <andersca@apple.com>
1022 Fix designated initializer violations
1023 https://bugs.webkit.org/show_bug.cgi?id=143016
1024 rdar://problem/20268858
1026 Reviewed by Dan Bernstein.
1028 Move -[WebBackForwardList initWithBackForwardList:] to the implementation instead of a category since
1029 nobody calls it outside of WebBackForwardList.mm.
1031 * History/WebBackForwardList.mm:
1032 * History/WebBackForwardListInternal.h:
1034 2015-03-23 Alexey Proskuryakov <ap@apple.com>
1036 REGRESSION (Yosemite): WKView visibility notifications are messed up
1037 https://bugs.webkit.org/show_bug.cgi?id=142945
1039 Reviewed by Tim Horton.
1041 As these notifications cannot be used by NSView subclasses, create a separate
1042 object for observing them.
1044 * WebView/WebView.mm:
1045 (-[WebView _commonInitializationWithFrameName:groupName:]):
1046 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1047 (-[WebView addWindowObserversForWindow:]):
1048 (-[WebView removeWindowObservers]):
1049 (-[WebView viewWillMoveToWindow:]): Make sure that observers are removed even
1050 if -[WebView close] is called manually.
1051 * WebView/WebViewData.h:
1052 * WebView/WebViewData.mm:
1053 (-[WebWindowVisibilityObserver initWithView:]):
1054 (-[WebWindowVisibilityObserver startObserving:]):
1055 (-[WebWindowVisibilityObserver stopObserving:]):
1056 (-[WebWindowVisibilityObserver _windowVisibilityChanged:]):
1058 2015-03-23 Tim Horton <timothy_horton@apple.com>
1060 Add a share item to the link action menu
1061 https://bugs.webkit.org/show_bug.cgi?id=142961
1062 <rdar://problem/19198374>
1064 Reviewed by Beth Dakin.
1066 * WebView/WebActionMenuController.mm:
1067 (-[WebActionMenuController _defaultMenuItemsForImage]):
1068 (-[WebActionMenuController _defaultMenuItemsForVideo]):
1069 (-[WebActionMenuController _createActionMenuItemForTag:]):
1070 (-[WebActionMenuController _createShareActionMenuItemForTag:withItems:]):
1071 Adopt -[NSMenuItem standardShareMenuItemWithItems].
1072 All of the null-checking is unnecessary as it's impossible to enter
1073 these functions with a null image/etc.
1074 Also, remove a duplicate isDownloadableMedia check for the 'save to downloads' item.
1076 (-[WebActionMenuController _defaultMenuItemsForLink]):
1077 * WebView/WebUIDelegatePrivate.h:
1078 Add a 'Share' item to the link menu.
1080 2015-03-22 Alexey Proskuryakov <ap@apple.com>
1084 * WebView/WebView.mm: (-[WebView _showPlaybackTargetPicker:hasVideo:]):
1086 2015-03-22 Eric Carlson <eric.carlson@apple.com>
1088 [Mac] Enable WIRELESS_PLAYBACK_TARGET for WK1
1089 https://bugs.webkit.org/show_bug.cgi?id=142940
1091 Reviewed by Sam Weinig.
1093 * WebCoreSupport/WebChromeClient.h:
1094 * WebCoreSupport/WebChromeClient.mm:
1095 (WebChromeClient::showPlaybackTargetPicker): New.
1096 (WebChromeClient::startingMonitoringPlaybackTargets): New.
1097 (WebChromeClient::stopMonitoringPlaybackTargets): New.
1099 * WebView/WebView.mm:
1100 (-[WebView _close]): Invalidate and free the target picker.
1101 (-[WebView _devicePicker]): New.
1102 (-[WebView _showPlaybackTargetPicker:hasVideo:]): New.
1103 (-[WebView _startingMonitoringPlaybackTargets]): New.
1104 (-[WebView _stopMonitoringPlaybackTargets]): New.
1106 * WebView/WebMediaPlaybackTargetPicker.h:
1107 * WebView/WebMediaPlaybackTargetPicker.mm:
1108 (WebMediaPlaybackTargetPicker::create): New.
1109 (WebMediaPlaybackTargetPicker::WebMediaPlaybackTargetPicker): New.
1110 (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): New.
1111 (WebMediaPlaybackTargetPicker::startingMonitoringPlaybackTargets): New.
1112 (WebMediaPlaybackTargetPicker::stopMonitoringPlaybackTargets): New.
1113 (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): New.
1114 (WebMediaPlaybackTargetPicker::externalOutputDeviceAvailableDidChange): New.
1115 (WebMediaPlaybackTargetPicker::invalidate): New.
1116 (WebMediaPlaybackTargetPicker::targetPicker): New.
1118 * WebView/WebViewData.h:
1119 (WebMediaPlaybackTargetPicker::~WebMediaPlaybackTargetPicker):
1120 * WebView/WebViewData.mm:
1121 * WebView/WebViewInternal.h:
1123 2015-03-19 Andy Estes <aestes@apple.com>
1125 [Content Filtering] Add tests for unblock requests
1126 https://bugs.webkit.org/show_bug.cgi?id=142900
1128 Reviewed by Andreas Kling.
1130 * WebCoreSupport/WebFrameLoaderClient.mm:
1131 (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): This now happens in PolicyChecker.
1132 (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
1133 * WebView/WebFrame.mm:
1134 (-[WebFrame _contentFilterDidHandleNavigationAction:]): Deleted.
1135 * WebView/WebFrameInternal.h: Removed contentFilterUnblockHandler from WebFramePrivate.
1137 2015-03-19 Enrica Casucci <enrica@apple.com>
1139 <attachment> should put URLs on the pasteboard so that Finder can accept drops.
1140 https://bugs.webkit.org/show_bug.cgi?id=142801
1141 rdar://problem/19982527
1143 Reviewed by Tim Horton.
1145 This patch adds all the necessary support to write attachment elements into
1146 the pasteboard, including the promised type in WK1.
1148 * Misc/WebNSPasteboardExtras.mm:
1149 (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1150 * WebCoreSupport/WebDragClient.h:
1151 * WebCoreSupport/WebDragClient.mm:
1152 (WebDragClient::declareAndWriteAttachment):
1153 * WebView/WebHTMLView.mm:
1154 (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1155 * WebView/WebUIDelegate.h:
1157 2015-03-19 Chris Dumez <cdumez@apple.com>
1159 Clean up DOMTimer related settings
1160 https://bugs.webkit.org/show_bug.cgi?id=142837
1162 Reviewed by Darin Adler.
1164 Stop setting the DOMTimers' default minimum interval to 4ms as this
1167 * WebView/WebView.mm:
1168 (-[WebView _commonInitializationWithFrameName:groupName:]):
1170 2015-03-17 Conrad Shultz <conrad_shultz@apple.com>
1172 Ignore some deprecation warnings
1173 https://bugs.webkit.org/show_bug.cgi?id=142813
1175 Reviewed by Mark Rowe.
1177 Fixing the deprecations is tracked by: <rdar://problem/20201450>
1179 * WebCoreSupport/PopupMenuMac.mm:
1180 (PopupMenuMac::populate):
1182 2015-03-17 Tim Horton <timothy_horton@apple.com>
1184 Cannot invoke action menus anymore
1185 https://bugs.webkit.org/show_bug.cgi?id=142797
1186 <rdar://problem/20032670>
1188 * WebView/WebHTMLView.mm:
1189 (-[WebHTMLView otherMouseDown:]):
1190 Need a respondsToSelector check.
1192 2015-03-17 Tim Horton <timothy_horton@apple.com>
1196 * WebView/WebHTMLView.mm:
1198 2015-03-17 Tim Horton <timothy_horton@apple.com>
1200 Cannot invoke action menus anymore
1201 https://bugs.webkit.org/show_bug.cgi?id=142797
1202 <rdar://problem/20032670>
1204 Reviewed by Beth Dakin.
1206 * WebView/WebHTMLView.mm:
1207 (-[WebHTMLView otherMouseDown:]):
1208 Don't override otherMouseDown: if the event would make an action menu.
1210 2015-03-16 Ryosuke Niwa <rniwa@webkit.org>
1212 Enable ES6 classes by default
1213 https://bugs.webkit.org/show_bug.cgi?id=142774
1215 Reviewed by Gavin Barraclough.
1217 * Configurations/FeatureDefines.xcconfig:
1219 2015-03-16 Brent Fulgham <bfulgham@apple.com>
1221 WebKit1 Clients Are Not Reliably Repainted
1222 https://bugs.webkit.org/show_bug.cgi?id=142750
1223 <rdar://problem/20042453>
1225 Reviewed by Simon Fraser.
1227 Check with the FrameView to see if we are in an immediately paintable state. If we are not,
1228 mark the view as dirty once the _immediateScrollToPoint operation is complete so that the
1229 region will be painted properly.
1231 * WebView/WebClipView.mm:
1232 (-[WebClipView _immediateScrollToPoint:]):
1234 2015-03-16 Conrad Shultz <conrad_shultz@apple.com>
1236 Allow clients to selectively disable plug-ins
1237 https://bugs.webkit.org/show_bug.cgi?id=142506
1239 Reviewed by Anders Carlsson.
1241 Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
1242 from the page). As part of this:
1244 1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying
1247 2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper
1250 3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce
1251 a concrete implementation thereof in WebPlatformStrategies in WebKit2.
1253 4) Add messaging infrastructure to allow clients to set and clear plug-in policies.
1255 While currently only used in a very limited manner, the new declarative plug-in policies are written generically
1256 so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.
1258 * Plugins/WebBasePluginPackage.mm:
1259 (-[WebBasePluginPackage getPluginInfoFromPLists]):
1260 Set new members in PluginInfo.
1262 * Plugins/WebNetscapePluginPackage.mm:
1263 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
1264 Set new members in PluginInfo.
1266 * WebCoreSupport/WebPlatformStrategies.h:
1267 * WebCoreSupport/WebPlatformStrategies.mm:
1268 (WebPlatformStrategies::getWebVisiblePluginInfo):
1269 Override to wrap getPluginInfo().
1270 (WebPlatformStrategies::setPluginLoadClientPolicy):
1271 Override to do nothing.
1272 (WebPlatformStrategies::clearPluginClientPolicies):
1275 * WebView/WebFrame.mm:
1276 (-[WebFrame _canProvideDocumentSource]):
1277 Update to reflect function rename.
1279 2015-03-14 Dean Jackson <dino@apple.com>
1281 Feature flag for Animations Level 2
1282 https://bugs.webkit.org/show_bug.cgi?id=142699
1283 <rdar://problem/20165097>
1285 Reviewed by Brent Fulgham.
1287 Add ENABLE_CSS_ANIMATIONS_LEVEL_2 and a runtime flag animationTriggersEnabled.
1289 * Configurations/FeatureDefines.xcconfig:
1291 2015-03-13 Commit Queue <commit-queue@webkit.org>
1293 Unreviewed, rolling out r181483.
1294 https://bugs.webkit.org/show_bug.cgi?id=142688
1296 Caused use-after-free on many tests (Requested by ap on
1301 "Allow clients to selectively disable plug-ins"
1302 https://bugs.webkit.org/show_bug.cgi?id=142506
1303 http://trac.webkit.org/changeset/181483
1305 2015-03-13 Eric Carlson <eric.carlson@apple.com>
1307 [Mac] Enable WIRELESS_PLAYBACK_TARGET
1308 https://bugs.webkit.org/show_bug.cgi?id=142635
1310 Reviewed by Darin Adler.
1312 * Configurations/FeatureDefines.xcconfig:
1314 2015-03-10 Conrad Shultz <conrad_shultz@apple.com>
1316 Allow clients to selectively disable plug-ins
1317 https://bugs.webkit.org/show_bug.cgi?id=142506
1319 Reviewed by Anders Carlsson.
1321 Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
1322 from the page). As part of this:
1324 1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying
1327 2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper
1330 3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce
1331 a concrete implementation thereof in WebPlatformStrategies in WebKit2.
1333 4) Add messaging infrastructure to allow clients to set and clear plug-in policies.
1335 While currently only used in a very limited manner, the new declarative plug-in policies are written generically
1336 so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.
1338 * Plugins/WebBasePluginPackage.mm:
1339 (-[WebBasePluginPackage getPluginInfoFromPLists]):
1340 Set new members in PluginInfo.
1342 * Plugins/WebNetscapePluginPackage.mm:
1343 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
1344 Set new members in PluginInfo.
1346 * WebCoreSupport/WebPlatformStrategies.h:
1347 * WebCoreSupport/WebPlatformStrategies.mm:
1348 (WebPlatformStrategies::getWebVisiblePluginInfo):
1349 Override to wrap getPluginInfo().
1350 (WebPlatformStrategies::setPluginLoadClientPolicy):
1351 Override to do nothing.
1352 (WebPlatformStrategies::clearPluginClientPolicies):
1355 * WebView/WebFrame.mm:
1356 (-[WebFrame _canProvideDocumentSource]):
1357 Update to reflect function rename.
1359 2015-03-10 Sam Weinig <sam@webkit.org>
1361 Allow adding a button in input elements for auto fill related functionality
1362 <rdar://problem/19782066>
1363 https://bugs.webkit.org/show_bug.cgi?id=142564
1365 Reviewed by Anders Carlsson.
1367 * DOM/WebDOMOperations.mm:
1368 (-[DOMHTMLInputElement _setAutofilled:]):
1369 Update for consistent spelling of AutoFill.
1371 2015-03-10 Timothy Horton <timothy_horton@apple.com>
1375 * History/WebHistory.mm:
1376 (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
1377 * WebCoreSupport/WebFrameLoaderClient.mm:
1378 (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1380 2015-03-10 Tim Horton <timothy_horton@apple.com>
1382 Fix the Mac build with a newer compiler
1384 * Plugins/WebPluginController.mm:
1385 (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
1386 (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
1388 2015-03-09 David Kilzer <ddkilzer@apple.com>
1390 [iOS] Fix build when compiling with dead code stripping disabled
1391 <http://webkit.org/b/142467>
1393 Reviewed by Simon Fraser.
1395 * Configurations/WebKitLegacy.xcconfig:
1396 (EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*]): Disable mig code
1397 generation and compilation for out-of-process plugin support.
1398 This was never used on iOS.
1400 2015-03-06 Myles C. Maxfield <mmaxfield@apple.com>
1402 [iOS] SVG fonts are garbled
1403 https://bugs.webkit.org/show_bug.cgi?id=142377
1405 Reviewed by Simon Fraser.
1407 * Configurations/FeatureDefines.xcconfig:
1409 2015-03-04 Yusuke Suzuki <utatane.tea@gmail.com>
1411 Hide Promise with runtime flags under Cocoa JSContext API
1412 https://bugs.webkit.org/show_bug.cgi?id=141965
1414 Reviewed by Filip Pizlo.
1416 Add new JSC runtime flag, PromiseDisabled.
1418 * WebView/WebPreferencesPrivate.h:
1420 2015-03-03 Andy Estes <aestes@apple.com>
1422 [Content Filtering] Separate unblock handling into its own class
1423 https://bugs.webkit.org/show_bug.cgi?id=142251
1425 Reviewed by Andreas Kling.
1427 Adopted ContentFilterUnblockHandler.
1429 * WebCoreSupport/WebFrameLoaderClient.h:
1430 * WebCoreSupport/WebFrameLoaderClient.mm:
1431 (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1432 * WebView/WebFrame.mm:
1433 (-[WebFrame _contentFilterDidHandleNavigationAction:]):
1434 * WebView/WebFrameInternal.h:
1436 2015-03-03 Chris Dumez <cdumez@apple.com>
1438 Access ApplicationCacheStorage global instance via singleton() static member function
1439 https://bugs.webkit.org/show_bug.cgi?id=142239
1441 Reviewed by Anders Carlsson.
1443 Access ApplicationCacheStorage global instance via singleton() static
1444 member function as per WebKit coding style.
1446 2015-03-02 Jer Noble <jer.noble@apple.com>
1448 [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
1449 https://bugs.webkit.org/show_bug.cgi?id=142121
1451 Reviewed by Simon Fraser.
1453 Fullscreening a page with a non-1 scale would result in that scale being applied to the
1454 fullscreen content, breaking fullscreen mode. Set the page scale to 1 when entering
1455 fullscreen and reset it to the original value when exiting fullscreen.
1457 * WebView/WebFullScreenController.h:
1458 * WebView/WebFullScreenController.mm:
1459 (-[WebFullScreenController enterFullScreen:]): Set the page scale to 1.
1460 (-[WebFullScreenController finishedExitFullScreenAnimation:]): Reset the page
1461 scale to the original value.
1462 * WebView/WebView.mm:
1463 (-[WebView _supportsFullScreenForElement:withKeyboard:]): Drive-by fix. Check the
1464 WebView's own preferences to see if fullscreen mode is enabled, rather than
1465 the global object's.
1467 2015-03-01 Chris Dumez <cdumez@apple.com>
1469 Make NotificationCenter / Notification suspendable
1470 https://bugs.webkit.org/show_bug.cgi?id=142117
1471 <rdar://problem/19923085>
1473 Reviewed by Andreas Kling.
1475 Provide implementation for NotificationClient::hasPendingPermissionRequests().
1476 The implementation is very simplistic. it will only return false if no
1477 request for permission for ever made. This is because there is currently no
1478 easy way to figure out if a permission request is pending or not.
1480 * WebCoreSupport/WebNotificationClient.h:
1481 * WebCoreSupport/WebNotificationClient.mm:
1482 (WebNotificationClient::requestPermission):
1483 (WebNotificationClient::hasPendingPermissionRequests):
1485 2015-02-28 Simon Fraser <simon.fraser@apple.com>
1487 Viewport units should not dirty style just before we do layout
1488 https://bugs.webkit.org/show_bug.cgi?id=141682
1490 Reviewed by Zalan Bujtas.
1492 * WebView/WebFrameView.mm:
1493 (-[WebFrameView _frameSizeChanged]):
1495 2015-02-26 Chris Dumez <cdumez@apple.com>
1497 Rename DatabaseManager::manager() to DatabaseManager::singleton()
1498 https://bugs.webkit.org/show_bug.cgi?id=142054
1500 Reviewed by Ryosuke Niwa.
1502 Rename DatabaseManager::manager() to DatabaseManager::singleton() as
1503 per coding style and use WTF::NeverDestroyed.
1505 * Storage/WebDatabaseManager.mm:
1506 (-[WebDatabaseManager init]):
1507 (-[WebDatabaseManager origins]):
1508 (-[WebDatabaseManager databasesWithOrigin:]):
1509 (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
1510 (-[WebDatabaseManager deleteAllDatabases]):
1511 (-[WebDatabaseManager deleteOrigin:]):
1512 (-[WebDatabaseManager deleteDatabase:withOrigin:]):
1513 * Storage/WebDatabaseQuotaManager.mm:
1514 (-[WebDatabaseQuotaManager usage]):
1515 (-[WebDatabaseQuotaManager quota]):
1516 (-[WebDatabaseQuotaManager setQuota:]):
1517 * WebCoreSupport/WebSecurityOrigin.mm:
1518 (-[WebSecurityOrigin usage]):
1519 (-[WebSecurityOrigin quota]):
1520 (-[WebSecurityOrigin setQuota:]):
1521 * WebView/WebFrame.mm:
1522 (-[WebFrame _cacheabilityDictionary]):
1523 * WebView/WebView.mm:
1524 (-[WebView _preferencesChanged:]):
1526 2015-02-26 Myles C. Maxfield <mmaxfield@apple.com>
1528 [Mac] [iOS] Parsing support for -apple-trailing-word
1529 https://bugs.webkit.org/show_bug.cgi?id=141939
1531 Reviewed by Andreas Kling.
1533 * Configurations/FeatureDefines.xcconfig:
1535 2015-02-24 Commit Queue <commit-queue@webkit.org>
1537 Unreviewed, rolling out r180599.
1538 https://bugs.webkit.org/show_bug.cgi?id=141998
1540 Lots of new test failures (Requested by smfr on #webkit).
1544 "Parsing support for -webkit-trailing-word"
1545 https://bugs.webkit.org/show_bug.cgi?id=141939
1546 http://trac.webkit.org/changeset/180599
1548 2015-02-24 Myles C. Maxfield <mmaxfield@apple.com>
1550 [Mac] [iOS] Parsing support for -apple-trailing-word
1551 https://bugs.webkit.org/show_bug.cgi?id=141939
1553 Reviewed by Andreas Kling.
1555 * Configurations/FeatureDefines.xcconfig:
1557 2015-02-24 Yusuke Suzuki <utatane.tea@gmail.com>
1559 REGRESSION(r179429): Can't type comments in Facebook
1560 https://bugs.webkit.org/show_bug.cgi?id=141859
1562 Reviewed by Brent Fulgham.
1564 Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
1565 Private API, javaScriptExperimentsEnabled is dropped.
1567 * Misc/WebNSDictionaryExtras.h:
1568 * Misc/WebNSDictionaryExtras.m:
1569 (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
1571 * WebView/WebPreferenceKeysPrivate.h:
1572 * WebView/WebPreferences.mm:
1573 (+[WebPreferences initialize]):
1574 (-[WebPreferences _setUnsignedIntValue:forKey:]):
1575 (-[WebPreferences javaScriptRuntimeFlags]):
1576 (-[WebPreferences setJavaScriptRuntimeFlags:]):
1577 (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
1578 (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
1579 * WebView/WebPreferencesPrivate.h:
1580 * WebView/WebView.mm:
1581 (-[WebView _preferencesChanged:]):
1583 2015-02-23 Commit Queue <commit-queue@webkit.org>
1585 Unreviewed, rolling out r180547 and r180550.
1586 https://bugs.webkit.org/show_bug.cgi?id=141957
1588 Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
1590 Reverted changesets:
1592 "REGRESSION(r179429): Can't type comments in Facebook"
1593 https://bugs.webkit.org/show_bug.cgi?id=141859
1594 http://trac.webkit.org/changeset/180547
1596 "Constructor returning null should construct an object instead
1598 https://bugs.webkit.org/show_bug.cgi?id=141640
1599 http://trac.webkit.org/changeset/180550
1601 2015-02-23 Ryosuke Niwa <rniwa@webkit.org>
1603 Disable font loading events until our implementation gets updated to match the latest spec
1604 https://bugs.webkit.org/show_bug.cgi?id=141938
1606 Reviewed by Andreas Kling.
1608 * Configurations/FeatureDefines.xcconfig:
1610 2015-02-23 Yusuke Suzuki <utatane.tea@gmail.com>
1612 REGRESSION(r179429): Can't type comments in Facebook
1613 https://bugs.webkit.org/show_bug.cgi?id=141859
1615 Reviewed by Geoffrey Garen.
1617 Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
1618 Private API, javaScriptExperimentsEnabled is dropped.
1620 * Misc/WebNSDictionaryExtras.h:
1621 * Misc/WebNSDictionaryExtras.m:
1622 (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
1624 * WebView/WebPreferenceKeysPrivate.h:
1625 * WebView/WebPreferences.mm:
1626 (+[WebPreferences initialize]):
1627 (-[WebPreferences _setUnsignedIntValue:forKey:]):
1628 (-[WebPreferences javaScriptRuntimeFlags]):
1629 (-[WebPreferences setJavaScriptRuntimeFlags:]):
1630 (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
1631 (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
1632 * WebView/WebPreferencesPrivate.h:
1633 * WebView/WebView.mm:
1634 (-[WebView _preferencesChanged:]):
1636 2015-02-20 Eric Carlson <eric.carlson@apple.com>
1638 [iOS] cleanup AirPlay code
1639 https://bugs.webkit.org/show_bug.cgi?id=141811
1641 Reviewed by Jer Noble.
1643 * Configurations/FeatureDefines.xcconfig: IOS_AIRPLAY -> WIRELESS_PLAYBACK_TARGET.
1645 2015-02-18 Timothy Horton <timothy_horton@apple.com>
1647 Adopt WebCore::IOSurface in ImageBuffer
1648 https://bugs.webkit.org/show_bug.cgi?id=141751
1650 Reviewed by Simon Fraser.
1652 * WebCoreSupport/WebSystemInterface.mm:
1653 (InitWebCoreSystemInterface):
1654 Remove old WKSI IOSurface-related functions.
1656 2015-02-18 Commit Queue <commit-queue@webkit.org>
1658 Unreviewed, rolling out r180286.
1659 https://bugs.webkit.org/show_bug.cgi?id=141766
1661 Caused >50 crashed LayoutTests (Requested by jernoble on
1666 "Page::userContentController() should return a reference, not
1668 https://bugs.webkit.org/show_bug.cgi?id=141764
1669 http://trac.webkit.org/changeset/180286
1671 2015-02-18 Brady Eidson <beidson@apple.com>
1673 Page::userContentController() should return a reference, not a pointer
1674 https://bugs.webkit.org/show_bug.cgi?id=141764
1676 Reviewed by Jer Noble.
1678 * WebView/WebView.mm:
1679 (-[WebView setGroupName:]):
1681 2015-02-18 Chris Dumez <cdumez@apple.com>
1683 Access FontCache global instance via singleton() static member function
1684 https://bugs.webkit.org/show_bug.cgi?id=141726
1686 Reviewed by Daniel Bates.
1688 Access FontCache global instance via singleton() static member function,
1689 as per coding style.
1691 2015-02-17 Chris Dumez <cdumez@apple.com>
1693 Access MemoryPressureHandler global instance via a singleton() static member function
1694 https://bugs.webkit.org/show_bug.cgi?id=141691
1696 Reviewed by Andreas Kling.
1698 Access MemoryPressureHandler global instance via a singleton() static
1701 * WebView/WebView.mm:
1702 (-[WebView _commonInitializationWithFrameName:groupName:]):
1703 (+[WebView registerForMemoryNotifications]):
1704 (+[WebView _isUnderMemoryPressure]):
1705 (+[WebView _clearMemoryPressure]):
1706 (+[WebView _shouldWaitForMemoryClearMessage]):
1707 (WebInstallMemoryPressureHandler):
1709 2015-02-15 Sam Weinig <sam@webkit.org>
1711 Add experimental <attachment> element support
1712 https://bugs.webkit.org/show_bug.cgi?id=141626
1714 Reviewed by Tim Horton.
1716 * Configurations/FeatureDefines.xcconfig:
1718 2015-02-14 Joseph Pecoraro <pecoraro@apple.com>
1720 [Mac] Possible DDActionContext leaks, RetainPtr cleanup
1721 https://bugs.webkit.org/show_bug.cgi?id=141613
1723 Reviewed by Tim Horton.
1725 * WebCoreSupport/WebEditorClient.mm:
1726 (WebEditorClient::WebEditorClient):
1727 Avoid unnecessary retain/autorelease by adopting.
1729 * WebView/WebActionMenuController.mm:
1730 (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1731 Adopt the allocated object.
1733 2015-02-09 Brian J. Burg <burg@cs.washington.edu>
1735 Web Inspector: remove some unnecessary Inspector prefixes from class names in Inspector namespace
1736 https://bugs.webkit.org/show_bug.cgi?id=141372
1738 Reviewed by Joseph Pecoraro.
1740 * WebCoreSupport/WebInspectorClient.mm:
1741 (-[WebInspectorWindowController destroyInspectorView:]):
1743 2015-02-14 Alexey Proskuryakov <ap@apple.com>
1745 rel="noreferrer" should make window.opener null
1746 https://bugs.webkit.org/show_bug.cgi?id=141579
1748 Reviewed by Darin Adler.
1750 * WebView/WebPDFView.mm:
1751 (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Updated for a new WebCore
1752 function signature. There is no rel="noreferrer" in PDF, so we can just always allow.
1754 2015-02-05 Youenn Fablet <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
1756 [Streams API] Implement a barebone ReadableStream interface
1757 https://bugs.webkit.org/show_bug.cgi?id=141045
1759 Reviewed by Benjamin Poulain.
1761 * Configurations/FeatureDefines.xcconfig:
1763 2015-02-03 Enrica Casucci <enrica@apple.com>
1765 [iOS] Add support for deleteFromInputWithFlags.
1766 https://bugs.webkit.org/show_bug.cgi?id=141216
1767 rdar://problem/19130081
1769 Reviewed by Benjamin Poulain.
1771 Adopts the new method as soon as it is available.
1772 The patch also removes some obsolete code used for staging.
1774 * WebView/WebHTMLView.mm:
1775 (-[WebHTMLView _handleEditingKeyEvent:]):
1777 2015-02-02 Chris Dumez <cdumez@apple.com>
1779 Access MemoryCache singleton using MemoryCache::singleton()
1780 https://bugs.webkit.org/show_bug.cgi?id=141104
1782 Reviewed by Andreas Kling.
1784 Access MemoryCache singleton using MemoryCache::singleton() static
1785 member function, instead of a free function, as per the recent
1786 coding style discussion on WebKit-dev.
1788 2015-02-01 Chris Dumez <cdumez@apple.com>
1790 Use more references in HistoryItem
1791 https://bugs.webkit.org/show_bug.cgi?id=141133
1793 Reviewed by Andreas Kling.
1795 Use more references in HistoryItem instead of pointers.
1797 2015-01-31 Sam Weinig <sam@webkit.org>
1799 Remove even more Mountain Lion support
1800 https://bugs.webkit.org/show_bug.cgi?id=141124
1802 Reviewed by Alexey Proskuryakov.
1804 * Configurations/Base.xcconfig:
1805 * Configurations/DebugRelease.xcconfig:
1806 * Configurations/FeatureDefines.xcconfig:
1807 * Configurations/Version.xcconfig:
1808 * Configurations/WebKitLegacy.xcconfig:
1810 2015-01-30 Eric Carlson <eric.carlson@apple.com>
1812 Remove MediaPlayerProxy.h
1813 https://bugs.webkit.org/show_bug.cgi?id=141087
1815 Reviewed by Sam Weinig.
1817 * MigrateHeaders.make: Don't need to copy MediaPlayerProxy.h.
1818 * Plugins/WebPluginController.mm: Don't include MediaPlayerProxy.h.
1820 2015-01-30 Chris Dumez <cdumez@apple.com>
1822 Rename shared() static member functions to singleton() for singleton classes.
1823 https://bugs.webkit.org/show_bug.cgi?id=141088
1825 Reviewed by Ryosuke Niwa and Benjamin Poulain.
1827 Rename shared() static member functions to singleton() for singleton
1828 classes as per the recent coding style change.
1830 2015-01-29 Beth Dakin <bdakin@apple.com>
1832 Remove more Mountain Lion code from WebKit
1833 https://bugs.webkit.org/show_bug.cgi?id=141050
1835 Reviewed by Anders Carlsson.
1837 * History/WebHistory.mm:
1839 * Panels/WebAuthenticationPanel.m:
1840 (-[WebAuthenticationPanel cancel:]):
1841 (-[WebAuthenticationPanel logIn:]):
1842 (-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]):
1843 * WebCoreSupport/WebSystemInterface.mm:
1844 (InitWebCoreSystemInterface):
1845 * WebView/WebFrameView.mm:
1846 * WebView/WebPreferences.mm:
1847 (+[WebPreferences initialize]):
1848 (needsScreenFontsEnabledQuirk):
1849 * WebView/WebView.mm:
1850 (+[WebView registerForMemoryNotifications]):
1851 (-[WebView _preferencesChanged:]):
1852 (+[WebView initialize]):
1853 (+[WebView _shouldAutomaticQuoteSubstitutionBeEnabled]):
1854 (+[WebView _shouldAutomaticDashSubstitutionBeEnabled]):
1855 (+[WebView _didChangeAutomaticDashSubstitutionEnabled:]):
1857 2015-01-29 Sam Weinig <sam@webkit.org>
1859 Remove support for screen font substitution
1860 https://bugs.webkit.org/show_bug.cgi?id=141038
1862 Reviewed by Tim Horton.
1864 * Misc/WebKitNSStringExtras.mm:
1865 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
1866 (-[NSString _web_widthWithFont:]):
1867 * Misc/WebStringTruncator.mm:
1869 Update for new signature of the FontPlatformData constructor, which no longer cares about
1870 whether to use printer fonts.
1872 * WebView/WebPreferenceKeysPrivate.h:
1873 Remove the WebKitScreenFontSubstitutionEnabledKey key.
1875 * WebView/WebPreferences.mm:
1876 (+[WebPreferences initialize]):
1877 Remove support for WebKitScreenFontSubstitutionEnabledKey.
1879 (needsScreenFontsEnabledQuirk): Deleted.
1880 Remove support for the Mountain Lion era 1-Password quirk.
1882 (-[WebPreferences screenFontSubstitutionEnabled]): Deleted.
1883 (-[WebPreferences setScreenFontSubstitutionEnabled:]): Deleted.
1884 * WebView/WebPreferencesPrivate.h:
1885 * WebView/WebView.mm:
1886 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1887 (-[WebView _preferencesChanged:]):
1888 Remove support for the screen font substitution setting.
1890 2015-01-29 Chris Dumez <cdumez@apple.com>
1892 Clean up / modernize PageCache class
1893 https://bugs.webkit.org/show_bug.cgi?id=141009
1895 Reviewed by Darin Adler.
1897 Clean up / modernize PageCache class.
1899 * History/WebBackForwardList.mm:
1900 (-[WebBackForwardList pageCacheSize]):
1901 * WebView/WebView.mm:
1902 (-[WebView _loadBackForwardListFromOtherView:]):
1903 (-[WebView goToBackForwardItem:]):
1904 (+[WebView _setCacheModel:]):
1906 2015-01-28 Beth Dakin <bdakin@apple.com>
1908 Remove Mountain Lion code from WebKit and WebKit2
1909 https://bugs.webkit.org/show_bug.cgi?id=141010
1911 Reviewed by Sam Weinig.
1913 * DOM/WebDOMOperations.mm:
1915 * WebView/WebHTMLView.mm:
1918 2015-01-28 Dana Burkart <dburkart@apple.com>
1920 Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
1921 https://bugs.webkit.org/show_bug.cgi?id=136765
1923 Reviewed by Alexey Proskuryakov.
1925 * Configurations/Base.xcconfig:
1926 * Configurations/DebugRelease.xcconfig:
1928 2015-01-28 Chris Dumez <cdumez@apple.com>
1930 Fix typo in markPagesForVistedLinkStyleRecalc()
1931 https://bugs.webkit.org/show_bug.cgi?id=140977
1933 Reviewed by Darin Adler.
1935 * WebCoreSupport/WebVisitedLinkStore.mm:
1936 (WebVisitedLinkStore::removeAllVisitedLinks):
1937 (WebVisitedLinkStore::removeVisitedLink):
1938 (WebVisitedLinkStore::addVisitedLinkHash):
1940 2015-01-28 Chris Dumez <cdumez@apple.com>
1942 Rename pageCache() to PageCache::shared() and return a reference
1943 https://bugs.webkit.org/show_bug.cgi?id=140983
1945 Reviewed by Andreas Kling.
1947 Rename pageCache() to PageCache::shared() as this is a singleton class
1948 and have it return a reference instead of a pointer.
1950 * History/WebBackForwardList.mm:
1951 (-[WebBackForwardList pageCacheSize]):
1952 * Misc/WebCoreStatistics.mm:
1953 (+[WebCoreStatistics cachedPageCount]):
1954 (+[WebCoreStatistics cachedFrameCount]):
1955 * WebCoreSupport/WebVisitedLinkStore.mm:
1956 (WebVisitedLinkStore::removeAllVisitedLinks):
1957 (WebVisitedLinkStore::removeVisitedLink):
1958 (WebVisitedLinkStore::addVisitedLinkHash):
1959 * WebView/WebView.mm:
1960 (+[WebView _setCacheModel:]):
1962 2015-01-27 Alexey Proskuryakov <ap@apple.com>
1964 More build fixes for newer clang.
1966 Rubber-stamped by Anders Carlsson.
1968 Marked a deprecated accessibility method as such.
1970 * WebView/WebFrame.mm:
1971 (-[WebFrame accessibilityRoot]):
1973 2015-01-27 Beth Dakin <bdakin@apple.com>
1975 Immediate action gesture recognizer still doesn't work well with IB
1976 https://bugs.webkit.org/show_bug.cgi?id=140967
1978 rdar://problem/19621509
1980 Reviewed by Tim Horton.
1982 We should add (or remove) the gesture recognizer in viewDidMoveToWindow because
1983 initWithFrame it too early and IB might mess with it.
1984 * WebView/WebImmediateActionController.h:
1985 * WebView/WebImmediateActionController.mm:
1986 (-[WebImmediateActionController immediateActionRecognizer]):
1987 * WebView/WebView.mm:
1988 (-[WebView _commonInitializationWithFrameName:groupName:]):
1989 (-[WebView viewDidMoveToWindow]):
1991 2015-01-27 Dan Bernstein <mitz@apple.com>
1993 Fixed building projects that import WebView.h with WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS.
1995 Rubber-stamped by Anders Carlsson.
1997 * WebView/WebView.h: Added forward declarations of the protocols.
1999 2015-01-26 Anders Carlsson <andersca@apple.com>
2001 Make it easy to test enabling formal delegate protocols
2002 https://bugs.webkit.org/show_bug.cgi?id=140892
2004 Reviewed by Dan Bernstein.
2006 Add an WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS define that controls whether delegates should be formal protocols.
2008 * Misc/WebDownload.h:
2009 * WebView/WebFrameLoadDelegate.h:
2010 * WebView/WebPolicyDelegate.h:
2011 * WebView/WebResourceLoadDelegate.h:
2012 * WebView/WebUIDelegate.h:
2013 * WebView/WebView.h:
2015 2015-01-26 Chris Dumez <cdumez@apple.com>
2017 Rename Document::body() to Document::bodyOrFrameset() for clarity
2018 https://bugs.webkit.org/show_bug.cgi?id=140902
2020 Reviewed by Andreas Kling.
2022 Rename Document::body() to Document::bodyOrFrameset() for clarity. This
2023 method does not necessarily return an HTMLBodyElement, it can also
2024 return a frameset as per the specification:
2025 http://www.w3.org/TR/html5/dom.html#dom-tree-accessors
2027 This method is often misused internally (the caller is only interested
2028 in the <body> element). I will fix these instances in a follow-up patch,
2029 this patch is only renaming mechanically.
2031 2015-01-26 Chris Dumez <cdumez@apple.com>
2033 First argument to DOM traversal functions should be a reference
2034 https://bugs.webkit.org/show_bug.cgi?id=140895
2036 Reviewed by Antti Koivisto.
2038 First argument to DOM traversal functions should be a reference instead
2039 of a pointer as it is dereferenced without null-check.
2041 2015-01-26 Myles C. Maxfield <mmaxfield@apple.com>
2043 [iOS] [SVG -> OTF Converter] Flip the switch off on iOS
2044 https://bugs.webkit.org/show_bug.cgi?id=140860
2046 Reviewed by Darin Adler.
2048 The fonts it makes are grotesque. (See what I did there? Typographic
2049 humor is the best humor.)
2051 * Configurations/FeatureDefines.xcconfig:
2053 2015-01-23 Timothy Horton <timothy_horton@apple.com>
2055 QLPreviewMenuItem popovers don't close when the page scrolls
2056 https://bugs.webkit.org/show_bug.cgi?id=140806
2057 <rdar://problem/19555618>
2059 Reviewed by Beth Dakin.
2061 Now that QLPreviewMenuItem's popover doesn't eat scrolls, we need to dismiss it if the page scrolls.
2063 * WebView/WebHTMLView.mm:
2064 (-[WebHTMLView scrollWheel:scrollWheel:]):
2065 Send scrollWheel along to WebImmediateActionController.
2067 * WebView/WebImmediateActionController.h:
2068 * WebView/WebImmediateActionController.mm:
2069 (-[WebImmediateActionController webView:didHandleScrollWheel:]):
2070 (-[WebImmediateActionController _clearImmediateActionState]):
2071 (-[WebImmediateActionController _defaultAnimationController]):
2072 Keep track of the active QLPreviewMenuItem, and close it upon scroll.
2074 2015-01-23 Timothy Horton <timothy_horton@apple.com>
2076 Infinite recursion in _clearImmediateActionState
2077 https://bugs.webkit.org/show_bug.cgi?id=140807
2078 <rdar://problem/19571601>
2080 Reviewed by Anders Carlsson.
2082 * WebView/WebImmediateActionController.mm:
2083 (-[WebImmediateActionController _clearImmediateActionState]):
2084 Use this opportunity to bring identical code to WebKit1, to avoid
2085 getting DataDetectors stuck when an immediate action is canceled.
2087 2015-01-22 Ryosuke Niwa <rniwa@webkit.org>
2089 Add a build flag for ES6 class syntax
2090 https://bugs.webkit.org/show_bug.cgi?id=140760
2092 Reviewed by Michael Saboff.
2094 * Configurations/FeatureDefines.xcconfig:
2096 2015-01-22 Beth Dakin <bdakin@apple.com>
2098 ibtoold crash below -[WebView close]
2099 https://bugs.webkit.org/show_bug.cgi?id=140782
2101 rdar://problem/19558472
2103 Reviewed by Tim Horton.
2105 Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but
2106 it is because interface builder is messing with our views.
2107 * WebView/WebImmediateActionController.h:
2108 * WebView/WebImmediateActionController.mm:
2109 (-[WebImmediateActionController webViewClosed]):
2110 (-[WebImmediateActionController _cancelImmediateAction]):
2111 (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2112 (-[WebImmediateActionController _updateImmediateActionItem]):
2114 2015-01-21 Beth Dakin <bdakin@apple.com>
2116 Crash in QuickLook preview delegate method
2117 https://bugs.webkit.org/show_bug.cgi?id=140740
2119 rdar://problem/19540806
2121 Reviewed by Tim Horton.
2123 Clear out the delegate.
2124 * WebView/WebImmediateActionController.mm:
2125 (-[WebImmediateActionController webViewClosed]):
2127 2015-01-21 Csaba Osztrogonác <ossy@webkit.org>
2129 Remove ENABLE(INSPECTOR) ifdef guards
2130 https://bugs.webkit.org/show_bug.cgi?id=140668
2132 Reviewed by Darin Adler.
2134 * Configurations/FeatureDefines.xcconfig:
2135 * WebCoreSupport/WebFrameLoaderClient.mm:
2136 (WebFrameLoaderClient::dispatchWillSendRequest):
2138 2015-01-20 Anders Carlsson <andersca@apple.com>
2140 Remove USE(GLIB) code from WebKit1
2141 https://bugs.webkit.org/show_bug.cgi?id=140714
2143 Reviewed by Andreas Kling.
2145 * WebView/WebView.mm:
2146 (-[WebView _commonInitializationWithFrameName:groupName:]):
2147 (-[WebView _close]):
2148 (-[WebView _clearGlibLoopObserver]): Deleted.
2149 (glibContextIterationCallback): Deleted.
2150 (-[WebView _scheduleGlibContextIterations]): Deleted.
2151 * WebView/WebViewData.h:
2152 * WebView/WebViewInternal.h:
2154 2015-01-20 David Kilzer <ddkilzer@apple.com>
2156 Switch to comparing PLATFORM_NAME in terms of macosx
2157 <http://webkit.org/b/139516>
2159 Reviewed by Timothy Hatcher.
2161 * MigrateHeaders.make:
2162 * postprocess-headers.sh:
2164 2015-01-19 Myles C. Maxfield <mmaxfield@apple.com>
2166 [SVG -> OTF Converter] Flip the switch on
2167 https://bugs.webkit.org/show_bug.cgi?id=140592
2169 Reviewed by Antti Koivisto.
2171 * Configurations/FeatureDefines.xcconfig:
2173 2015-01-19 Beth Dakin <bdakin@apple.com>
2175 Speculative build fix.
2177 * WebView/WebView.mm:
2178 (-[WebView _commonInitializationWithFrameName:groupName:]):
2180 2015-01-19 Beth Dakin <bdakin@apple.com>
2182 Speculative build fix.
2184 * WebView/WebView.mm:
2185 (-[WebView _convertRectFromRootView:]):
2187 2015-01-19 Timothy Horton <timothy_horton@apple.com>
2189 Adjust naming of action menu SPI
2190 https://bugs.webkit.org/show_bug.cgi?id=140644
2191 <rdar://problem/19448129>
2193 Reviewed by Brian Weinstein.
2195 * WebView/WebActionMenuController.mm:
2196 (-[WebActionMenuController prepareForMenu:withEvent:]):
2197 (-[WebActionMenuController willOpenMenu:withEvent:]):
2198 (-[WebActionMenuController didCloseMenu:withEvent:]):
2199 * WebView/WebView.mm:
2200 (-[WebView _commonInitializationWithFrameName:groupName:]):
2201 (-[WebView prepareForMenu:withEvent:]):
2202 (-[WebView willOpenMenu:withEvent:]):
2203 (-[WebView didCloseMenu:withEvent:]):
2205 2015-01-19 Beth Dakin <bdakin@apple.com>
2207 REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is
2208 offset by flipped-ness
2209 https://bugs.webkit.org/show_bug.cgi?id=140643
2211 rdar://problem/19489593
2213 Reviewed by Tim Horton.
2215 We universally flipped because we assumed that the root view was flipped and the
2216 WebView was not. However, in Dictionary, the WebView is flipped! So this patch
2217 fixes that assumption by checking the WebView’s flipped-ness.
2218 * WebView/WebView.mm:
2219 (-[WebView _convertRectFromRootView:]):
2221 2015-01-19 Commit Queue <commit-queue@webkit.org>
2223 Unreviewed, rolling out r178653.
2224 https://bugs.webkit.org/show_bug.cgi?id=140634
2226 Broke multiple SVG tests on Mountain Lion (Requested by ap on
2231 "[SVG -> OTF Converter] Flip the switch on"
2232 https://bugs.webkit.org/show_bug.cgi?id=140592
2233 http://trac.webkit.org/changeset/178653
2235 2015-01-19 Myles C. Maxfield <mmaxfield@apple.com>
2237 [SVG -> OTF Converter] Flip the switch on
2238 https://bugs.webkit.org/show_bug.cgi?id=140592
2240 Reviewed by Antti Koivisto.
2242 * Configurations/FeatureDefines.xcconfig:
2244 2015-01-18 Daniel Bates <dabates@apple.com>
2246 Attempt to fix the iOS build after <http://trac.webkit.org/changeset/178631>
2247 (https://bugs.webkit.org/show_bug.cgi?id=129441)
2249 Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight().
2250 Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.
2252 * WebInspector/WebNodeHighlightView.mm:
2253 (-[WebNodeHighlightView layoutSublayers:]):
2255 2015-01-16 Beth Dakin <bdakin@apple.com>
2257 Make sure early cancellation of immediate action actually does that in WK1
2258 https://bugs.webkit.org/show_bug.cgi?id=140566
2260 rdar://problem/19490114
2262 Reviewed by Tim Horton.
2264 Work around an AppKit bug by dispatching the call to _cancelImmediateAction
2266 * WebView/WebImmediateActionController.mm:
2267 (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2269 2015-01-16 Daniel Bates <dabates@apple.com>
2271 Fix the public iOS SDK build after <http://trac.webkit.org/changeset/178285>
2272 (https://bugs.webkit.org/show_bug.cgi?id=140360)
2274 Forward declare protocol NSURLDownloadDelegate as it is SPI on iOS.
2276 * Misc/WebDownload.h:
2278 2015-01-15 Csaba Osztrogonác <ossy@webkit.org>
2280 Remove ENABLE(SQL_DATABASE) guards
2281 https://bugs.webkit.org/show_bug.cgi?id=140434
2283 Reviewed by Darin Adler.
2285 * Configurations/FeatureDefines.xcconfig:
2286 * Storage/WebDatabaseManager.mm:
2287 (databasesDirectoryPath):
2288 * Storage/WebDatabaseManagerClient.h:
2289 * Storage/WebDatabaseManagerClient.mm:
2290 * Storage/WebDatabaseManagerInternal.h:
2291 * Storage/WebDatabaseManagerPrivate.h:
2292 * Storage/WebDatabaseQuotaManager.mm:
2293 (-[WebDatabaseQuotaManager usage]):
2294 (-[WebDatabaseQuotaManager quota]):
2295 (-[WebDatabaseQuotaManager setQuota:]):
2296 * WebCoreSupport/WebChromeClient.h:
2297 * WebCoreSupport/WebChromeClient.mm:
2298 * WebCoreSupport/WebSecurityOrigin.mm:
2299 (-[WebSecurityOrigin usage]):
2300 (-[WebSecurityOrigin quota]):
2301 (-[WebSecurityOrigin setQuota:]):
2302 * WebView/WebFrame.mm:
2303 (-[WebFrame _cacheabilityDictionary]):
2304 * WebView/WebView.mm:
2305 (-[WebView _commonInitializationWithFrameName:groupName:]):
2306 (-[WebView _preferencesChanged:]):
2308 2015-01-14 Chris Dumez <cdumez@apple.com>
2310 Make 'TypeName' parameter unnecessary in CSSPropertyNames.in
2311 https://bugs.webkit.org/show_bug.cgi?id=140347
2313 Reviewed by Darin Adler.
2315 Call FontDescription::setIsItalic() instead of setItalic() as the
2316 call site passes a boolean.
2318 * WebView/WebHTMLView.mm:
2319 (fontNameForDescription):
2321 2015-01-13 Anders Carlsson <andersca@apple.com>
2323 Temporarily reintroduce the informal delegate protocols
2324 https://bugs.webkit.org/show_bug.cgi?id=140416
2326 Reviewed by Dan Bernstein.
2328 * WebView/WebEditingDelegate.h:
2329 * WebView/WebFrameLoadDelegate.h:
2330 * WebView/WebPolicyDelegate.h:
2331 * WebView/WebResourceLoadDelegate.h:
2332 * WebView/WebUIDelegate.h:
2334 2015-01-13 Beth Dakin <bdakin@apple.com>
2336 Should disable immediate actions for iTunes
2337 https://bugs.webkit.org/show_bug.cgi?id=140405
2339 rdar://problem/19461358
2341 Reviewed by Tim Horton.
2343 * WebView/WebImmediateActionController.mm:
2344 (-[WebImmediateActionController _updateImmediateActionItem]):
2346 2015-01-11 Sam Weinig <sam@webkit.org>
2348 Remove support for SharedWorkers
2349 https://bugs.webkit.org/show_bug.cgi?id=140344
2351 Reviewed by Anders Carlsson.
2353 * Configurations/FeatureDefines.xcconfig:
2354 * WebCoreSupport/WebPlatformStrategies.h:
2355 * WebCoreSupport/WebPlatformStrategies.mm:
2356 (WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
2358 2015-01-12 Timothy Horton <timothy_horton@apple.com>
2360 Get rid of unnecessary reimplementations of CGFloor/Ceiling
2361 https://bugs.webkit.org/show_bug.cgi?id=140375
2363 Reviewed by Simon Fraser.
2365 * Misc/WebKitNSStringExtras.mm:
2366 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2367 (webkit_CGCeiling): Deleted.
2368 Delete unnecessary code, use the real CGFloor/Ceiling instead.
2370 2015-01-12 Anders Carlsson <andersca@apple.com>
2372 Make delegates conform to formal delegate protocols
2373 https://bugs.webkit.org/show_bug.cgi?id=140370
2375 Reviewed by Dan Bernstein.
2377 * DefaultDelegates/WebDefaultPolicyDelegate.h:
2378 * WebCoreSupport/WebInspectorClient.mm:
2379 Add protocols to the interface declarations.
2381 * WebView/WebActionMenuController.mm:
2382 (-[WebActionMenuController prepareForMenu:withEvent:]):
2383 (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2384 * WebView/WebImmediateActionController.mm:
2385 (-[WebImmediateActionController _updateImmediateActionItem]):
2386 (-[WebImmediateActionController _menuItemForDataDetectedText]):
2387 Cast to id when trying to invoke delegate methods that aren't on WebUIDelegate.
2389 2015-01-12 Myles C. Maxfield <mmaxfield@apple.com>
2391 Allow targetting the SVG->OTF font converter with ENABLE(SVG_OTF_CONVERTER)
2392 https://bugs.webkit.org/show_bug.cgi?id=136769
2394 Reviewed by Antti Koivisto.
2396 * Configurations/FeatureDefines.xcconfig:
2398 2015-01-12 Timothy Horton <timothy_horton@apple.com>
2400 Multi-rect TextIndicators are vertically flipped in WebKit1
2401 https://bugs.webkit.org/show_bug.cgi?id=140350
2402 <rdar://problem/19441243>
2404 Reviewed by Beth Dakin.
2406 * WebView/WebView.mm:
2407 (-[WebView _setTextIndicator:fadeOut:]):
2408 Convert the textBoundingRect from root view to screen coordinates.
2410 2015-01-12 Anders Carlsson <andersca@apple.com>
2412 Make WebResourceDelegate a formal protocol as well
2413 https://bugs.webkit.org/show_bug.cgi?id=140364
2415 Reviewed by Dan Bernstein.
2417 * WebView/WebResourceLoadDelegate.h:
2419 2015-01-12 Anders Carlsson <andersca@apple.com>
2421 Delegates should be formal protocols
2422 https://bugs.webkit.org/show_bug.cgi?id=140360
2423 rdar://problem/17380856
2425 Reviewed by Dan Bernstein.
2427 This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
2429 * DefaultDelegates/WebDefaultUIDelegate.h:
2430 * Misc/WebDownload.h:
2431 * WebView/WebEditingDelegate.h:
2432 * WebView/WebFrameLoadDelegate.h:
2433 * WebView/WebPolicyDelegate.h:
2434 * WebView/WebUIDelegate.h:
2436 2015-01-09 Anders Carlsson <andersca@apple.com>
2438 Get rid of the database strategy
2439 https://bugs.webkit.org/show_bug.cgi?id=140322
2441 Reviewed by Sam Weinig.
2443 * WebCoreSupport/WebPlatformStrategies.h:
2444 * WebCoreSupport/WebPlatformStrategies.mm:
2445 (WebPlatformStrategies::createDatabaseStrategy): Deleted.
2447 2015-01-08 Timothy Horton <timothy_horton@apple.com>
2449 Can't use DataDetectors after immediate action preparation
2450 https://bugs.webkit.org/show_bug.cgi?id=140263
2451 <rdar://problem/19412705>
2453 Reviewed by Beth Dakin.
2455 * WebView/WebImmediateActionController.mm:
2456 (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2457 (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
2458 To match WebKit2, only call shouldUseActions if the animation is actually
2459 going to begin, not when preparing for it. This way, we're guaranteed
2460 to get a didCancel or didComplete.
2462 2015-01-08 Dean Jackson <dino@apple.com>
2464 Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
2465 https://bugs.webkit.org/show_bug.cgi?id=140232
2466 <rdar://problem/19371010>
2468 Reviewed by Anders Carlsson.
2470 Remove the applicationChromeMode setting, but leave stubs in to make
2471 sure existing binaries don't break.
2473 * WebCoreSupport/WebInspectorClient.mm:
2474 (-[WebInspectorWindowController init]):
2475 * WebView/WebPreferenceKeysPrivate.h:
2476 * WebView/WebPreferences.mm:
2477 (+[WebPreferences initialize]):
2478 (-[WebPreferences applicationChromeModeEnabled]):
2479 (-[WebPreferences setApplicationChromeModeEnabled:]):
2480 * WebView/WebView.mm:
2481 (-[WebView _preferencesChanged:]):
2483 2015-01-07 Daniel Bates <dabates@apple.com>
2485 [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
2486 https://bugs.webkit.org/show_bug.cgi?id=137371
2488 Reviewed by David Kilzer.
2490 Use SPI wrapper headers instead of directly references private SPI headers.
2492 * Plugins/Hosted/NetscapePluginHostManager.mm:
2494 2015-01-07 Commit Queue <commit-queue@webkit.org>
2496 Unreviewed, rolling out r178068.
2497 https://bugs.webkit.org/show_bug.cgi?id=140235
2499 Breaks the iOS build (Requested by enrica on #webkit).
2503 "[iOS] Make WebKit2 build with public iOS SDK and more build
2505 https://bugs.webkit.org/show_bug.cgi?id=137371
2506 http://trac.webkit.org/changeset/178068
2508 2015-01-07 Daniel Bates <dabates@apple.com>
2510 [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
2511 https://bugs.webkit.org/show_bug.cgi?id=137371
2513 Reviewed by David Kilzer.
2515 Use SPI wrapper headers instead of directly references private SPI headers.
2517 * Plugins/Hosted/NetscapePluginHostManager.mm:
2519 2015-01-07 Beth Dakin <bdakin@apple.com>
2521 Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the
2523 https://bugs.webkit.org/show_bug.cgi?id=140206
2525 rdar://problem/19300492
2527 Reviewed by Tim Horton.
2529 Providing and item frame will ensure that the original link is not obscured.
2530 * WebView/WebImmediateActionController.mm:
2531 (elementBoundingBoxInWindowCoordinatesFromNode):
2532 (-[WebImmediateActionController menuItem:itemFrameForPoint:]):
2534 For now use a max size that is smaller than the WebView, with the screen’s aspect
2535 ratio, and scaled down.
2536 (-[WebImmediateActionController menuItem:maxSizeForPoint:]):
2538 2015-01-07 Anders Carlsson <andersca@apple.com>
2540 Give simple HTML documents a database provider
2541 https://bugs.webkit.org/show_bug.cgi?id=140192
2542 rdar://problem/19398825
2544 Reviewed by Tim Horton.
2546 * WebView/WebView.mm:
2547 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2549 2015-01-06 Anders Carlsson <andersca@apple.com>
2551 Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
2552 https://bugs.webkit.org/show_bug.cgi?id=140140
2554 Reviewed by Andreas Kling.
2556 Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler
2557 out of WebCore since nobody else is using it.
2559 * Plugins/WebNetscapePluginView.h:
2560 * Plugins/WebNetscapePluginView.mm:
2561 (-[WebNetscapePluginView _createPlugin]):
2562 (-[WebNetscapePluginView _destroyPlugin]):
2564 (NPN_PluginThreadAsyncCall):
2566 2015-01-06 Anders Carlsson <andersca@apple.com>
2568 Add a WebKit1 database provider
2569 https://bugs.webkit.org/show_bug.cgi?id=140126
2571 Reviewed by Sam Weinig.
2573 Set the database provider.
2575 * WebView/WebView.mm:
2576 (-[WebView _commonInitializationWithFrameName:groupName:]):
2578 2015-01-06 Commit Queue <commit-queue@webkit.org>
2580 Unreviewed, rolling out r177963.
2581 https://bugs.webkit.org/show_bug.cgi?id=140136
2583 Caused lots of crashes (Requested by smfr on #webkit).
2587 "Add a WebKit1 database provider"
2588 https://bugs.webkit.org/show_bug.cgi?id=140126
2589 http://trac.webkit.org/changeset/177963
2591 2015-01-06 Anders Carlsson <andersca@apple.com>
2593 Add a WebKit1 database provider
2594 https://bugs.webkit.org/show_bug.cgi?id=140126
2596 Reviewed by Sam Weinig.
2598 Set the database provider.
2600 * WebView/WebView.mm:
2601 (-[WebView _commonInitializationWithFrameName:groupName:]):
2603 2015-01-01 Jeff Miller <jeffm@apple.com>
2605 Update user-visible copyright strings to include 2015
2606 https://bugs.webkit.org/show_bug.cgi?id=139880
2608 Reviewed by Darin Adler.
2612 2014-12-30 Dan Bernstein <mitz@apple.com>
2614 [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
2615 https://bugs.webkit.org/show_bug.cgi?id=140003
2617 Reviewed by Darin Adler.
2619 * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
2620 that takes their "string" parameter as a "value" "parameter and has an attribute telling
2621 the compiler that if the "value" parameter is a format string then the function returns a
2622 modified version of it. The result is that if UI_STRING is used as a format string parameter
2623 to some function or method, the compiler will check the format specifiers in the string
2624 against the other parameters.
2626 2014-12-29 Dan Bernstein <mitz@apple.com>
2628 Fixed the iOS build.
2630 * Configurations/WebKitLegacy.xcconfig:
2632 2014-12-29 Anders Carlsson <andersca@apple.com>
2634 Get rid of some PageGroup storage functions
2635 https://bugs.webkit.org/show_bug.cgi?id=139996
2637 Reviewed by Sam Weinig.
2639 Call WebStorageNamespaceProvider directly instead.
2641 * Storage/WebStorageManager.mm:
2642 (-[WebStorageManager syncLocalStorage]):
2643 (+[WebStorageManager closeIdleLocalStorageDatabases]):
2644 * WebView/WebView.mm:
2645 (+[WebView _applicationWillTerminate]):
2647 2014-12-29 Anders Carlsson <andersca@apple.com>
2649 Move storage code from WebCore to WebKit
2650 https://bugs.webkit.org/show_bug.cgi?id=139558
2652 Reviewed by Darin Adler.
2654 * Storage/WebStorageManager.mm:
2655 * Storage/WebStorageTrackerClient.h:
2656 * WebView/WebView.mm:
2658 2014-12-26 Dan Bernstein <mitz@apple.com>
2660 <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
2661 https://bugs.webkit.org/show_bug.cgi?id=139950
2663 Reviewed by David Kilzer.
2665 * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
2666 in a manner that works with Xcode 5.1.1.
2668 2014-12-23 Timothy Horton <timothy_horton@apple.com>
2670 Install a TextIndicator for link immediate actions
2671 https://bugs.webkit.org/show_bug.cgi?id=139897
2672 <rdar://problem/19333076>
2674 Reviewed by Anders Carlsson.
2676 * WebView/WebImmediateActionController.h:
2677 * WebView/WebImmediateActionController.mm:
2678 (-[WebImmediateActionController _clearImmediateActionState]):
2679 Tear down the TextIndicator, just like WebKit2.
2681 (-[WebImmediateActionController _defaultAnimationController]):
2682 Install a TextIndicator for links.
2684 (-[WebImmediateActionController menuItemDidClose:]):
2685 Tear down the TextIndicator when the QL preview closes.
2687 (-[WebImmediateActionController _menuItemForDataDetectedText]):
2688 Directly install and uninstall the TextIndicator for DataDetectors.
2690 (-[WebImmediateActionController _showTextIndicator]): Deleted.
2691 (-[WebImmediateActionController _hideTextIndicator]): Deleted.
2692 Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
2694 2014-12-20 Eric Carlson <eric.carlson@apple.com>
2696 [iOS] add optimized fullscreen API
2697 https://bugs.webkit.org/show_bug.cgi?id=139833
2698 <rdar://problem/18844486>
2700 Reviewed by Simon Fraser.
2702 * Configurations/FeatureDefines.xcconfig: Add ENABLE_VIDEO_PRESENTATION_MODE.
2704 2014-12-20 David Kilzer <ddkilzer@apple.com>
2706 Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
2707 <http://webkit.org/b/139463>
2709 Reviewed by Mark Rowe.
2711 * Configurations/Base.xcconfig:
2712 - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
2714 - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
2715 * Configurations/DebugRelease.xcconfig:
2716 - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
2717 - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
2718 * Configurations/Version.xcconfig:
2719 - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
2720 * Configurations/WebKitLegacy.xcconfig:
2721 - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
2722 FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
2723 DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
2724 NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
2725 WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
2726 PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
2727 WEBCORE_PRIVATE_HEADERS_DIR_Production and
2728 WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
2730 - Fix PRODUCTION_ROOT to actually be set properly.
2731 - Simplify EXPORTED_SYMBOLS_FILE_i386.
2733 * migrate-headers.sh:
2734 - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
2735 - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
2736 WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
2737 WebKitLegacy.xcconfig.
2739 2014-12-19 Simon Fraser <simon.fraser@apple.com>
2741 Fix pink background on CoreAnimation plug-ins in WebKit1
2742 https://bugs.webkit.org/show_bug.cgi?id=139845
2743 rdar://problem/19313075
2745 Reviewed by Tim Horton.
2747 r154078 left in some debugging code that set a pink background on plug-in hosting
2750 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2751 (-[WebHostedNetscapePluginView createPluginLayer]):
2753 2014-12-19 Andreas Kling <akling@apple.com>
2755 Ref-ify TextIterator API.
2756 <https://webkit.org/b/139823>
2758 Reviewed by Antti Koivisto.
2760 * WebView/WebTextIterator.mm:
2761 (-[WebTextIterator currentRange]):
2763 2014-12-19 Joseph Pecoraro <pecoraro@apple.com>
2765 Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
2766 https://bugs.webkit.org/show_bug.cgi?id=139797
2768 Reviewed by Mark Lam.
2770 * WebView/WebScriptDebugger.h:
2771 * WebView/WebScriptDebugger.mm:
2772 (WebScriptDebugger::handlePause):
2773 Standardize on passing JSGlobalObject parameter first.
2775 2014-12-19 Commit Queue <commit-queue@webkit.org>
2777 Unreviewed, rolling out r177574.
2778 https://bugs.webkit.org/show_bug.cgi?id=139821
2780 "Broke Production builds by installing
2781 libWebCoreTestSupport.dylib in the wrong directory" (Requested
2782 by ddkilzer on #webkit).
2786 "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
2787 WebInspectorUI, WebKit, WebKit2"
2788 https://bugs.webkit.org/show_bug.cgi?id=139463
2789 http://trac.webkit.org/changeset/177574
2791 2014-12-19 David Kilzer <ddkilzer@apple.com>
2793 Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
2794 <http://webkit.org/b/139463>
2796 Reviewed by Mark Rowe.
2798 * Configurations/Base.xcconfig:
2799 - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
2801 - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
2802 * Configurations/DebugRelease.xcconfig:
2803 - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
2804 - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
2805 * Configurations/Version.xcconfig:
2806 - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
2807 * Configurations/WebKitLegacy.xcconfig:
2808 - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
2809 FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
2810 DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
2811 NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
2812 WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
2813 PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
2814 WEBCORE_PRIVATE_HEADERS_DIR_Production and
2815 WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
2817 - Fix PRODUCTION_ROOT to actually be set properly.
2818 - Simplify EXPORTED_SYMBOLS_FILE_i386.
2820 * migrate-headers.sh:
2821 - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
2822 - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
2823 WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
2824 WebKitLegacy.xcconfig.
2826 2014-12-18 Andreas Kling <akling@apple.com>
2828 Ref-ify various Document-related things.
2829 <https://webkit.org/b/139796>
2831 Reviewed by Anders Carlsson.
2833 * WebView/WebFrame.mm:
2834 (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
2836 2014-12-18 Beth Dakin <bdakin@apple.com>
2838 Need to re-enable action menus
2839 https://bugs.webkit.org/show_bug.cgi?id=139795
2841 rdar://problem/19299367
2843 Reviewed by Tim Horton.
2845 Re-enable the menus by un-commenting the code to create the menu and controller.
2846 * WebView/WebView.mm:
2847 (-[WebView _commonInitializationWithFrameName:groupName:]):
2849 2014-12-16 Sam Weinig <sam@webkit.org>
2851 Unify the Mac and iOS implementations of FontPlatformData a bit
2852 https://bugs.webkit.org/show_bug.cgi?id=139721
2854 Reviewed by Anders Carlsson.
2856 * WebView/WebHTMLView.mm:
2857 (fontNameForDescription):
2858 Update for new function name.
2860 2014-12-18 Antti Koivisto <antti@apple.com>
2862 Remove alwaysUseBaselineOfPrimaryFont setting
2863 https://bugs.webkit.org/show_bug.cgi?id=139770
2865 Reviewed by Anders Carlsson.
2867 * WebView/WebPreferenceKeysPrivate.h:
2868 * WebView/WebPreferences.mm:
2869 (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
2870 (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
2871 * WebView/WebPreferencesPrivate.h:
2872 * WebView/WebView.mm:
2873 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2874 (-[WebView _preferencesChanged:]):
2876 2014-12-17 Andreas Kling <akling@apple.com>
2878 Ref-ify Range::create().
2879 <https://webkit.org/b/139755>
2881 Reviewed by Anders Carlsson.
2883 * WebView/WebHTMLRepresentation.mm:
2884 (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
2885 * WebView/WebHTMLView.mm:
2886 (-[WebHTMLView attributedString]):
2888 2014-12-17 Anders Carlsson <andersca@apple.com>
2890 Unify -[WebResource description]
2891 https://bugs.webkit.org/show_bug.cgi?id=139762
2893 Reviewed by Dan Bernstein.
2895 * WebView/WebResource.mm:
2896 (-[WebResource description]):
2898 2014-12-17 Anders Carlsson <andersca@apple.com>
2900 Get rid of an ugly #define hack in WebFrameLoaderClient
2901 https://bugs.webkit.org/show_bug.cgi?id=139761
2903 Reviewed by Dan Bernstein.
2905 Also replace @private with @package in all public headers, for consistency.
2907 * History/WebBackForwardList.h:
2908 * History/WebHistory.h:
2909 * Misc/WebDownload.h:
2910 * WebCoreSupport/WebFrameLoaderClient.mm:
2911 * WebView/WebArchive.h:
2912 * WebView/WebDataSource.h:
2913 * WebView/WebFrame.h:
2914 * WebView/WebFrameView.h:
2915 * WebView/WebPreferences.h:
2916 * WebView/WebResource.h:
2918 2014-12-17 Dan Bernstein <mitz@apple.com>
2920 <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
2921 https://bugs.webkit.org/show_bug.cgi?id=139760
2923 Reviewed by Anders Carlsson.
2925 * Configurations/WebKitLegacy.xcconfig:
2927 2014-12-17 Andreas Kling <akling@apple.com>
2929 Purge PassRefPtr from Frame.
2930 <https://webkit.org/b/139731>
2932 Reviewed by Anders Carlsson.
2934 * WebCoreSupport/WebFrameLoaderClient.mm:
2935 (WebFrameLoaderClient::transitionToCommittedForNewPage):
2936 * WebView/WebFrame.mm:
2937 (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
2938 (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
2939 * WebView/WebFrameInternal.h:
2941 2014-12-16 Timothy Horton <timothy_horton@apple.com>
2943 Implement and adopt two new TextIndicator presentation animations
2944 https://bugs.webkit.org/show_bug.cgi?id=139715
2945 <rdar://problem/19237945>
2947 Reviewed by Anders Carlsson.
2949 * WebView/WebActionMenuController.mm:
2950 (-[WebActionMenuController _showTextIndicator]):
2951 * WebView/WebHTMLView.mm:
2952 (-[WebHTMLView quickLookWithEvent:]):
2953 Remove the completionHandler from text indicator presentation.
2955 * WebView/WebImmediateActionController.mm:
2956 (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2957 (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
2958 (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
2959 (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
2960 (-[WebImmediateActionController _menuItemForDataDetectedText]):
2961 (-[WebImmediateActionController _animationControllerForText]):
2962 (-[WebImmediateActionController _showTextIndicator]):
2963 Forward immediate action gesture recognizer animation progress
2964 to TextIndicator. Force us to keep the selection when immediate
2965 action popovers steal first responder status from the WebView.
2966 If the Lookup range is equal to the selection range, use a Crossfade
2967 animation; otherwise, use a FadeIn animation.
2969 * WebView/WebView.mm:
2970 (-[WebView _setMaintainsInactiveSelection:]):
2971 (-[WebView maintainsInactiveSelection]):
2972 (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2973 (-[WebView _setTextIndicator:fadeOut:]):
2974 (-[WebView _clearTextIndicator]):
2975 (-[WebView _setTextIndicatorAnimationProgress:]):
2976 (-[WebView _showDictionaryLookupPopup:]):
2977 (-[WebView _dictionaryLookupPopoverWillClose:]):
2978 (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
2979 Remove the completionHandler from text indicator presentation.
2980 Add a _setMaintainsInactiveSelection, which allows WebKit internals
2981 to change the return value of -maintainsInactiveSelection, allowing
2982 us to keep the selection alive when the WebView loses first responder status.
2984 * WebView/WebViewData.h:
2985 * WebView/WebViewInternal.h:
2987 2014-12-16 Andreas Kling <akling@apple.com>
2989 Use Ref for SecurityOrigin.
2990 <https://webkit.org/b/139710>
2992 Reviewed by Anders Carlsson.
2994 * Storage/WebStorageTrackerClient.mm:
2995 (WebStorageTrackerClient::dispatchDidModifyOrigin):
2996 * WebView/WebView.mm:
2997 (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
2998 (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
3000 2014-12-16 Beth Dakin <bdakin@apple.com>
3002 Crash getting default animation controller for some text
3003 https://bugs.webkit.org/show_bug.cgi?id=139712
3005 rdar://problem/19271707
3007 Reviewed by Tim Horton.
3009 Must null-check the range.
3010 * WebView/WebImmediateActionController.mm:
3011 (-[WebImmediateActionController _animationControllerForText]):
3013 2014-12-16 Timothy Horton <timothy_horton@apple.com>
3015 Immediate action popovers can get stuck open
3016 https://bugs.webkit.org/show_bug.cgi?id=139709
3017 <rdar://problem/19270279>
3019 Reviewed by Beth Dakin.
3021 * WebView/WebImmediateActionController.mm:
3022 (-[WebImmediateActionController _clearImmediateActionState]):
3023 Don't clear the animation controller; it breaks things and was unnecessary.
3025 2014-12-16 Tim Horton <timothy_horton@apple.com>
3027 Disable TextIndication for Lookup immediate actions
3028 https://bugs.webkit.org/show_bug.cgi?id=139684
3030 Reviewed by Anders Carlsson.
3032 * WebView/WebView.mm:
3033 (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
3035 2014-12-15 Beth Dakin <bdakin@apple.com>
3039 * WebView/WebImmediateActionController.mm:
3041 2014-12-15 Beth Dakin <bdakin@apple.com>
3043 Speculative build fix.
3045 * WebView/WebView.mm:
3046 (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
3047 * WebView/WebViewInternal.h:
3049 2014-12-15 Beth Dakin <bdakin@apple.com>
3051 Make lookup an immediate action instead of an action menu item
3052 https://bugs.webkit.org/show_bug.cgi?id=139661
3054 rdar://problem/19198414
3056 Reviewed by Tim Horton.
3058 Remove the lookup menu items and non-unused static function associated with
3060 * WebView/WebActionMenuController.mm:
3061 (-[WebActionMenuController _defaultMenuItemsForText]):
3062 (-[WebActionMenuController _defaultMenuItemsForEditableText]):
3063 (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
3064 (-[WebActionMenuController _createActionMenuItemForTag:]):
3065 (-[WebActionMenuController _lookupText:]): Deleted.
3066 (performDictionaryLookupForSelection): Deleted.
3067 (performDictionaryLookupForRange): Deleted.
3069 Set the defaultAnimationController to the lookup-provided animation controller
3071 * WebView/WebImmediateActionController.mm:
3072 (-[WebImmediateActionController _defaultAnimationController]):
3073 (dictionaryPopupInfoForRange):
3074 (-[WebImmediateActionController _animationControllerForText]):
3077 * WebView/WebUIDelegatePrivate.h:
3079 New function to get the lookup animation controller.
3080 * WebView/WebView.mm:
3081 (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
3082 * WebView/WebViewInternal.h:
3084 2014-12-15 Timothy Horton <timothy_horton@apple.com>
3086 Implement Data Detectors immediate actions for Legacy WebKit
3087 https://bugs.webkit.org/show_bug.cgi?id=139619
3088 <rdar://problem/19198539>
3090 Reviewed by Beth Dakin.
3092 * WebView/WebImmediateActionController.mm:
3093 (-[WebImmediateActionController _menuItemForDataDetectedText]):
3094 Note that this action context is only for immediate actions.
3096 2014-12-15 Myles C. Maxfield <mmaxfield@apple.com>
3098 Addressing post-review comments in r177035
3099 https://bugs.webkit.org/show_bug.cgi?id=139557
3101 Reviewed by Darin Adler.
3103 * WebView/WebActionMenuController.mm:
3104 (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
3106 2014-12-15 Timothy Horton <timothy_horton@apple.com>
3108 Implement Data Detectors immediate actions for Legacy WebKit
3109 https://bugs.webkit.org/show_bug.cgi?id=139619
3110 <rdar://problem/19198539>
3112 Reviewed by Eric Carlson.
3114 * WebView/WebHTMLView.mm:
3115 (-[WebHTMLView mouseDown:mouseDown:]):
3116 Send mouseDown along to the WebImmediateActionController too.
3118 * WebView/WebImmediateActionController.h:
3119 * WebView/WebImmediateActionController.mm:
3120 (-[WebImmediateActionController webViewClosed]):
3121 (-[WebImmediateActionController webView:willHandleMouseDown:]):
3122 (-[WebImmediateActionController _cancelImmediateAction]):
3123 (-[WebImmediateActionController _clearImmediateActionState]):
3124 (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
3125 (-[WebImmediateActionController _defaultAnimationController]):
3126 (-[WebImmediateActionController _updateImmediateActionItem]):
3127 (-[WebImmediateActionController _menuItemForDataDetectedText]):
3128 (-[WebImmediateActionController _showTextIndicator]):
3129 (-[WebImmediateActionController _hideTextIndicator]):
3130 Copy most of the DataDetectors implementation into WebImmediateActionController.
3132 * WebView/WebUIDelegatePrivate.h:
3135 * WebView/WebView.mm:
3136 (-[WebView _commonInitializationWithFrameName:groupName:]):
3137 Temporarily disable action menus.
3139 (-[WebView _immediateActionController]):
3140 * WebView/WebViewInternal.h:
3142 2014-12-15 Myles C. Maxfield <mmaxfield@apple.com>
3144 Delete Notation because we don't use it
3145 https://bugs.webkit.org/show_bug.cgi?id=139171
3147 Reviewed by Kent Tamura.
3149 * MigrateHeaders.make:
3151 2014-12-14 Andreas Kling <akling@apple.com>
3153 Replace PassRef with Ref/Ref&& across the board.
3154 <https://webkit.org/b/139587>
3156 Reviewed by Darin Adler.
3158 * WebCoreSupport/WebEditorClient.mm:
3159 (WebEditorClient::shouldApplyStyle):
3160 * WebCoreSupport/WebVisitedLinkStore.h:
3161 * WebCoreSupport/WebVisitedLinkStore.mm:
3162 (WebVisitedLinkStore::create):
3164 2014-12-11 Dan Bernstein <mitz@apple.com>
3166 Fix a leak introduced in r177199.
3168 Reviewed by Anders Carlsson.
3170 * WebView/WebImmediateActionController.mm:
3171 (-[WebImmediateActionController _updateImmediateActionItem]):
3173 2014-12-11 Beth Dakin <bdakin@apple.com>
3175 WK1: Need new SPI for Webkit clients to override default immediate action
3176 https://bugs.webkit.org/show_bug.cgi?id=139568
3178 rdar://problem/19225448
3180 Reviewed by Dan Bernstein.
3182 Call SPI giving clients a chance to override the default behavior.
3183 * WebView/WebImmediateActionController.mm:
3184 (-[WebImmediateActionController _updateImmediateActionItem]):
3187 * WebView/WebUIDelegatePrivate.h:
3189 2014-12-11 Timothy Horton <timothy_horton@apple.com>
3191 Move the preview popover to WebImmediateActionController
3192 https://bugs.webkit.org/show_bug.cgi?id=139563
3193 <rdar://problem/19208291>
3195 Reviewed by Beth Dakin.
3197 * WebView/WebActionMenuController.mm:
3198 (-[WebActionMenuController _defaultMenuItemsForLink]):
3199 (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
3200 (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
3201 (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
3202 * WebView/WebImmediateActionController.h:
3203 * WebView/WebImmediateActionController.mm:
3204 (-[WebImmediateActionController webViewClosed]):
3205 (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
3206 (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
3207 (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
3208 (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
3209 (-[WebImmediateActionController _updateImmediateActionItem]):
3210 (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
3211 (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
3212 (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
3213 Move page preview popover related code to WebImmediateActionController.
3215 * WebView/WebUIDelegatePrivate.h:
3216 Add a link preview type.
3218 * WebView/WebView.mm:
3219 (-[WebView _commonInitializationWithFrameName:groupName:]):
3220 Pass the gesture recognizer to the WebImmediateActionController.
3222 2014-12-11 Timothy Horton <timothy_horton@apple.com>
3226 * WebView/WebImmediateActionController.h:
3227 * WebView/WebImmediateActionController.mm:
3229 2014-12-11 Anders Carlsson <andersca@apple.com>
3231 Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
3232 https://bugs.webkit.org/show_bug.cgi?id=139547
3234 Reviewed by Sam Weinig.
3236 * WebView/WebView.mm:
3237 (+[WebView _handleMemoryWarning]):
3239 2014-12-11 Alexey Proskuryakov <ap@apple.com>
3241 REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
3242 https://bugs.webkit.org/show_bug.cgi?id=139504
3243 rdar://problem/19034674
3245 Reviewed by Enrica Casucci.
3247 Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
3249 * WebCoreSupport/WebEditorClient.h:
3250 * WebCoreSupport/WebEditorClient.mm:
3251 (WebEditorClient::discardedComposition):
3253 2014-12-10 Anders Carlsson <andersca@apple.com>
3255 Get rid of the storage strategy
3256 https://bugs.webkit.org/show_bug.cgi?id=139519
3258 Reviewed by Antti Koivisto.
3260 * WebCoreSupport/WebPlatformStrategies.h:
3261 * WebCoreSupport/WebPlatformStrategies.mm:
3262 (WebPlatformStrategies::createStorageStrategy): Deleted.
3264 2014-12-10 Timothy Horton <timothy_horton@apple.com>
3266 Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
3267 https://bugs.webkit.org/show_bug.cgi?id=139529
3268 <rdar://problem/19213620>
3270 Reviewed by Beth Dakin.
3272 * WebView/WebActionMenuController.mm:
3273 (-[WebActionMenuController _copySelection:]):
3274 (-[WebActionMenuController _paste:]):
3275 Use the copy: and paste: methods on WebView so that we traverse subviews
3276 when trying to respond, otherwise these actions don't work in subframes.
3278 2014-12-10 Beth Dakin <bdakin@apple.com>
3280 WK1: Add initial support for immediate actions
3281 https://bugs.webkit.org/show_bug.cgi?id=139522
3283 Reviewed by Dan Bernstein.
3285 This basic implementation of the controller will use the delegate methods to
3286 perform and cache a HitTest when relevant. Future patches will patch
3287 _updateImmediateActionItem to use the HitTestResult to determine if there is any
3288 immediate action that should be taken.
3289 * WebView/WebImmediateActionController.h: Added.
3290 * WebView/WebImmediateActionController.mm: Added.
3291 (-[WebImmediateActionController webViewClosed]):
3292 (-[WebImmediateActionController _clearImmediateActionState]):
3293 (-[WebImmediateActionController performHitTestAtPoint:]):
3294 (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
3295 (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
3296 (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
3297 (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
3298 (-[WebImmediateActionController _updateImmediateActionItem]):
3300 New enum for immediate action types.
3301 * WebView/WebUIDelegatePrivate.h:
3303 Create an NSImmediateActionGestureRecognizer if possible and a controller.
3304 * WebView/WebView.mm:
3305 (-[WebView _commonInitializationWithFrameName:groupName:]):
3306 (-[WebView _close]):
3307 * WebView/WebViewData.h:
3308 * WebView/WebViewData.mm:
3309 (-[WebViewPrivate dealloc]):
3311 2014-12-08 Anders Carlsson <andersca@apple.com>
3313 Use the new storage namespace provider in WebKit1
3314 https://bugs.webkit.org/show_bug.cgi?id=139425
3316 Reviewed by Tim Horton.
3318 * WebView/WebView.mm:
3319 (-[WebView _commonInitializationWithFrameName:groupName:]):
3320 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3321 Set the storage namespace provider from the web page group.
3323 2014-12-10 Timothy Horton <timothy_horton@apple.com>
3325 Should have copy and paste items in all text menus
3326 https://bugs.webkit.org/show_bug.cgi?id=139510
3327 <rdar://problem/19198388>
3329 Reviewed by Beth Dakin.
3331 * WebView/WebActionMenuController.mm:
3332 (-[WebActionMenuController _defaultMenuItemsForText]):
3333 Add a disabled paste menu item into the read-only text menu.
3335 (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
3336 Add a disabled copy menu item into the editable whitespace text menu.
3338 2014-12-10 Anders Carlsson <andersca@apple.com>
3340 Add WebStorageNamespaceProvider::closeLocalStorage
3341 https://bugs.webkit.org/show_bug.cgi?id=139502
3343 Reviewed by Tim Horton.
3345 * WebView/WebView.mm:
3346 (+[WebView _applicationWillTerminate]):
3347 Call WebStorageNamespaceProvider::closeLocalStorage.
3349 2014-12-09 Commit Queue <commit-queue@webkit.org>
3351 Unreviewed, rolling out r177037.
3352 https://bugs.webkit.org/show_bug.cgi?id=139464
3354 broke ~50 API tests (Requested by thorton on #webkit).
3358 "Use the new storage namespace provider in WebKit1"
3359 https://bugs.webkit.org/show_bug.cgi?id=139425
3360 http://trac.webkit.org/changeset/177037
3362 2014-12-08 Anders Carlsson <andersca@apple.com>
3364 Use the new storage namespace provider in WebKit1
3365 https://bugs.webkit.org/show_bug.cgi?id=139425
3367 Reviewed by Tim Horton.
3369 * WebView/WebView.mm:
3370 (-[WebView _commonInitializationWithFrameName:groupName:]):
3371 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3372 Set the storage namespace provider from the web page group.
3374 2014-12-09 Myles C. Maxfield <mmaxfield@apple.com>
3376 Delete Node::boundingBox()
3377 https://bugs.webkit.org/show_bug.cgi?id=139333
3379 Reviewed by Zalan Bujtas.
3381 * WebView/WebActionMenuController.mm:
3382 (elementBoundingBoxInWindowCoordinatesFromNode): Use
3383 RenderObject::absoluteBoundingBoxRect().
3385 2014-12-08 Alexey Proskuryakov <ap@apple.com>
3387 REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
3388 https://bugs.webkit.org/show_bug.cgi?id=138843
3389 rdar://problem/18793695
3391 Reviewed by Dan Bernstein.
3393 * Panels/WebAuthenticationPanel.m:
3394 (-[WebAuthenticationPanel cancel:]):
3395 (-[WebAuthenticationPanel logIn:]):
3396 Don't close the panel before using panel.sheetParent, because the parent becomes nil.
3397 In fact, we don't need to close it at all, it's enough to call orderOut:, and even
3398 that only when using an old NSWindow API.
3400 2014-12-08 Beth Dakin <bdakin@apple.com>
3402 Copy and Lookup menu items should be disabled when something is not copyable
3403 https://bugs.webkit.org/show_bug.cgi?id=139423
3405 Reviewed by Tim Horton.
3407 Disable both lookup and copy when a HitTestResult does not allow copy.
3408 * WebView/WebActionMenuController.mm:
3410 Set autoenablesItems to NO. It’s messing with our ability to control the enable/
3411 disable state otherwise.
3412 * WebView/WebView.mm:
3413 (-[WebView _commonInitializationWithFrameName:groupName:]):
3415 2014-12-08 Anders Carlsson <andersca@apple.com>
3417 Adding user content to a group should force that group to be created
3418 https://bugs.webkit.org/show_bug.cgi?id=139421
3419 rdar://problem/19180108
3421 Reviewed by Sam Weinig.
3423 * WebCoreSupport/WebViewGroup.h:
3424 Store the local storage database path in the group.
3426 * WebCoreSupport/WebViewGroup.mm:
3427 (WebViewGroup::getOrCreate):
3428 If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
3429 set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
3431 (WebViewGroup::WebViewGroup):
3432 Initialize the new member variable.
3434 (WebViewGroup::storageNamespaceProvider):
3435 Create the namespace provider lazily.
3437 * WebView/WebView.mm:
3438 (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
3439 (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
3440 Use getOrCreate instead of get.
3442 2014-12-08 Anders Carlsson <andersca@apple.com>
3444 WebStorageNamespaceProvider should know about its local storage database path
3445 https://bugs.webkit.org/show_bug.cgi?id=139413
3447 Reviewed by Andreas Kling.
3449 * WebCoreSupport/WebViewGroup.h:
3450 * WebCoreSupport/WebViewGroup.mm:
3451 (WebViewGroup::getOrCreate):
3452 (WebViewGroup::WebViewGroup):
3453 * WebView/WebView.mm:
3454 (-[WebView _commonInitializationWithFrameName:groupName:]):
3455 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3456 (-[WebView setGroupName:]):
3457 (-[WebView groupName]): Deleted.
3459 2014-12-08 Daniel Bates <dabates@apple.com>
3461 [iOS] Fix the WebKit build with the public SDK
3463 Include header NSURLDownloadSPI.h.
3465 * WebCoreSupport/WebFrameLoaderClient.mm:
3467 2014-12-07 Dan Bernstein <mitz@apple.com>
3469 Introduce and deploy a function that allocates and returns an instance of a soft-linked class
3470 https://bugs.webkit.org/show_bug.cgi?id=139348
3472 Reviewed by Anders Carlsson.
3474 In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
3475 picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
3476 to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
3477 doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
3478 avoiding the ambiguity.
3480 * WebView/WebActionMenuController.mm:
3481 (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3483 2014-12-06 Anders Carlsson <andersca@apple.com>
3485 Add a stubbed out version of WebStorageNamespaceProvider
3486 https://bugs.webkit.org/show_bug.cgi?id=139213
3488 Reviewed by Sam Weinig.
3490 * WebCoreSupport/WebViewGroup.h:
3491 (WebViewGroup::storageNamespaceProvider):
3492 * WebCoreSupport/WebViewGroup.mm:
3493 (WebViewGroup::getOrCreate):
3494 (WebViewGroup::WebViewGroup):
3495 Give WebViewGroup a storage namespace provider.
3497 2014-12-06 Anders Carlsson <andersca@apple.com>
3499 Fix build with newer versions of clang.
3500 rdar://problem/18978687
3502 Add missing overrides and missing casts.
3504 * Storage/WebDatabaseManagerClient.h:
3505 * Storage/WebStorageTrackerClient.h:
3506 * WebCoreSupport/WebChromeClient.h:
3507 * WebCoreSupport/WebFrameLoaderClient.h:
3508 * WebCoreSupport/WebInspectorClient.h:
3509 * WebView/WebDataSource.mm:
3510 (-[WebDataSource _makeRepresentation]):
3511 * WebView/WebFrameView.mm:
3512 (-[WebFrameView _makeDocumentViewForDataSource:]):
3514 2014-12-05 Tim Horton <timothy_horton@apple.com>
3516 Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
3517 https://bugs.webkit.org/show_bug.cgi?id=139306
3518 <rdar://problem/19157955>
3520 Reviewed by Beth Dakin.
3522 * WebView/WebView.mm:
3523 (-[WebView _commonInitializationWithFrameName:groupName:]):
3524 (-[WebView _initWithFrame:frameName:groupName:]):
3525 Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
3527 2014-12-05 David Kilzer <ddkilzer@apple.com>
3529 FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
3530 <http://webkit.org/b/139286>
3532 Reviewed by Daniel Bates.
3534 * Configurations/FeatureDefines.xcconfig: Switch back to using
3535 PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
3537 2014-12-04 Timothy Horton <timothy_horton@apple.com>
3539 Fix the 32-bit build.
3541 * WebView/WebView.mm:
3542 (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
3544 2014-12-04 Tim Horton <timothy_horton@apple.com>
3546 TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
3547 https://bugs.webkit.org/show_bug.cgi?id=139252
3548 <rdar://problem/19140827>
3550 Reviewed by Anders Carlsson.
3552 * WebView/WebView.mm:
3553 (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
3554 Adjust to the WebCore changes.
3556 2014-12-03 Timothy Horton <timothy_horton@apple.com>
3558 Implement action menus for tel: URLs
3559 https://bugs.webkit.org/show_bug.cgi?id=139240
3560 <rdar://problem/19115662>
3562 Reviewed by Anders Carlsson.
3564 * WebView/WebActionMenuController.mm:
3565 (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3566 Make sure to use the newly created currentActionContext... everywhere.
3568 2014-12-03 Timothy Horton <timothy_horton@apple.com>
3570 Implement action menus for tel: URLs
3571 https://bugs.webkit.org/show_bug.cgi?id=139240
3572 <rdar://problem/19115662>
3574 Reviewed by Anders Carlsson.
3576 * WebView/WebActionMenuController.mm:
3577 (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):