Fix the iOS build.
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
2
3         Fix the iOS build.
4
5         * WebView/WebActionMenuController.h:
6         * WebView/WebActionMenuController.mm:
7         * WebView/WebHTMLView.mm:
8         (-[WebHTMLView scrollWheel:scrollWheel:]):
9         (-[WebHTMLView mouseDown:mouseDown:]):
10         * WebView/WebView.mm:
11         * WebView/WebViewData.h:
12         * WebView/WebViewData.mm:
13         (-[WebViewPrivate dealloc]):
14         * WebView/WebViewInternal.h:
15
16 2014-12-01  Tim Horton  <timothy_horton@apple.com>
17
18         Implement yellow highlight for WebKit1 data detectors
19         https://bugs.webkit.org/show_bug.cgi?id=138956
20         <rdar://problem/18992185>
21
22         Reviewed by Beth Dakin.
23
24         * WebView/WebActionMenuController.h:
25         * WebView/WebActionMenuController.mm:
26         (-[WebActionMenuController webView:willHandleMouseDown:]):
27         (-[WebActionMenuController webView:didHandleScrollWheel:]):
28         (-[WebActionMenuController prepareForMenu:withEvent:]):
29         (-[WebActionMenuController didCloseMenu:withEvent:]):
30         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
31         (-[WebActionMenuController _showTextIndicator]):
32         (-[WebActionMenuController _hideTextIndicator]):
33         (-[WebActionMenuController _dismissActionMenuPopovers]):
34         Copy the WebKit2 WKActionMenuController TextIndicator implementation
35         into WebActionMenuController. The only significant difference is
36         that we build the TextIndicator right at menu construction time
37         instead of in the Web process.
38
39         * WebView/WebHTMLView.mm:
40         (-[WebHTMLView scrollWheel:]):
41         Let the WebActionMenuController know that we're handling a scroll.
42
43         (-[WebHTMLView mouseDown:]):
44         Let the WebActionMenuController know that we're handling a mouseDown.
45
46         * WebView/WebView.mm:
47         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
48         (-[WebView _clearTextIndicator]):
49         (-[WebView _actionMenuController]):
50         (-[WebView _convertRectFromRootView:]): Deleted.
51         * WebView/WebViewData.h:
52         * WebView/WebViewData.mm:
53         * WebView/WebViewInternal.h:
54         Keep a TextIndicatorWindow on WebView, just like WKView does.
55         Expose the WebActionMenuController on WebView (internally).
56
57 2014-12-01  Anders Carlsson  <andersca@apple.com>
58
59         Remove old site specific quirks code that was added in 2009
60         https://bugs.webkit.org/show_bug.cgi?id=139141
61
62         Reviewed by Antti Koivisto.
63
64         * WebCoreSupport/WebFrameNetworkingContext.h:
65         * WebCoreSupport/WebFrameNetworkingContext.mm:
66         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
67
68 2014-11-30  Anders Carlsson  <andersca@apple.com>
69
70         Fix a test failure.
71
72         * History/WebHistory.mm:
73         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
74         Call through to the visited link store.
75
76         (+[WebHistory _removeAllVisitedLinks]):
77         Ditto.
78
79         * WebCoreSupport/WebVisitedLinkStore.mm:
80         (WebVisitedLinkStore::isLinkVisited):
81         Make sure to populate visited links.
82
83 2014-11-30  Anders Carlsson  <andersca@apple.com>
84
85         Switch over to the visited link store from the WebViewGroup
86         https://bugs.webkit.org/show_bug.cgi?id=139112
87
88         Reviewed by Sam Weinig.
89
90         * WebView/WebView.mm:
91         (-[WebView _commonInitializationWithFrameName:groupName:]):
92         (-[WebView setGroupName:]):
93
94 2014-11-30  Anders Carlsson  <andersca@apple.com>
95
96         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
97         https://bugs.webkit.org/show_bug.cgi?id=139111
98
99         Reviewed by Sam Weinig.
100
101         * WebCoreSupport/WebVisitedLinkStore.h:
102         * WebCoreSupport/WebVisitedLinkStore.mm:
103         (WebVisitedLinkStore::removeVisitedLink):
104         * WebView/WebView.mm:
105         (-[WebView removeVisitedLink:]):
106
107 2014-11-29  Anders Carlsson  <andersca@apple.com>
108
109         Populate visited links
110         https://bugs.webkit.org/show_bug.cgi?id=139101
111
112         Reviewed by Sam Weinig.
113
114         * History/WebHistory.mm:
115         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
116         Helper function that adds all visited link to the given store.
117
118         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
119         Call the private method.
120
121         * History/WebHistoryInternal.h:
122         * WebCoreSupport/WebVisitedLinkStore.h:
123         Add new members.
124
125         * WebCoreSupport/WebVisitedLinkStore.mm:
126         (WebVisitedLinkStore::addVisitedLink):
127         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
128
129         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
130         Implement this. First try the delegate, then try the shared history.
131
132         (WebVisitedLinkStore::addVisitedLinkHash):
133         Factor code that adds the link to the hash table into a separate function.
134
135         * WebView/WebView.mm:
136         (-[WebView addVisitedLinks:]):
137         Add the visited links to the store.
138
139 2014-11-29  Anders Carlsson  <andersca@apple.com>
140
141         More work on the legacy WebKit visited link store
142         https://bugs.webkit.org/show_bug.cgi?id=139100
143
144         Reviewed by Sam Weinig.
145
146         * History/WebHistory.mm:
147         (+[WebHistory setOptionalSharedHistory:]):
148         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
149
150         * WebCoreSupport/WebVisitedLinkStore.h:
151         * WebCoreSupport/WebVisitedLinkStore.mm:
152         (visitedLinkStores):
153         (WebVisitedLinkStore::WebVisitedLinkStore):
154         (WebVisitedLinkStore::~WebVisitedLinkStore):
155         Keep track of live visited link stores.
156
157         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
158         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
159
160         (WebVisitedLinkStore::removeAllVisitedLinks):
161         Iterate over all live link stores and remove their links.
162
163         (WebVisitedLinkStore::isLinkVisited):
164         Populate visited links and check if our hash table contains the link.
165
166         (WebVisitedLinkStore::addVisitedLink):
167         Add the link hash to the table.
168
169         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
170         Add stub.
171
172         (WebVisitedLinkStore::removeVisitedLinkHashes):
173         Clear out the hash table.
174
175 2014-11-27  Anders Carlsson  <andersca@apple.com>
176
177         Add a stubbed out WebVisitedLinkStore to WebViewGroup
178         https://bugs.webkit.org/show_bug.cgi?id=139066
179
180         Reviewed by Antti Koivisto.
181
182         * WebCoreSupport/WebViewGroup.h:
183         (WebViewGroup::visitedLinkStore):
184         * WebCoreSupport/WebViewGroup.mm:
185         (WebViewGroup::WebViewGroup):
186         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
187         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
188         (WebVisitedLinkStore::create):
189         (WebVisitedLinkStore::WebVisitedLinkStore):
190         (WebVisitedLinkStore::~WebVisitedLinkStore):
191         (WebVisitedLinkStore::isLinkVisited):
192         (WebVisitedLinkStore::addVisitedLink):
193
194 2014-11-25  Anders Carlsson  <andersca@apple.com>
195
196         Remove user content handling from PageGroup
197         https://bugs.webkit.org/show_bug.cgi?id=139051
198
199         Reviewed by Antti Koivisto.
200
201         Use the user content controller in the web view group.
202
203         * WebView/WebView.mm:
204         (-[WebView _injectOutlookQuirksScript]):
205
206 2014-11-25  Anders Carlsson  <andersca@apple.com>
207
208         Add a user content controller to WebViewGroup and use it for user content
209         https://bugs.webkit.org/show_bug.cgi?id=139043
210
211         Reviewed by Antti Koivisto.
212
213         This is another tiny step towards getting rid of user content handling inside PageGroup.
214
215         * WebCoreSupport/WebViewGroup.h:
216         (WebViewGroup::userContentController):
217         Add a UserContentController member and getter.
218
219         * WebCoreSupport/WebViewGroup.mm:
220         (WebViewGroup::get):
221         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
222
223         (WebViewGroup::WebViewGroup):
224         Create a user content controller.
225
226         * WebView/WebView.mm:
227         (-[WebView _commonInitializationWithFrameName:groupName:]):
228         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
229         set its user content controller in the PageConfiguration.
230
231         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
232         Ditto.
233
234         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
235         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
236         (+[WebView _removeUserScriptFromGroup:world:url:]):
237         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
238         (+[WebView _removeUserScriptsFromGroup:world:]):
239         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
240         (+[WebView _removeAllUserContentFromGroup:]):
241         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
242
243         (-[WebView setGroupName:]):
244         Set the user content controller to the new WebViewGroup's user content controller.
245
246 2014-11-21  Jer Noble  <jer.noble@apple.com>
247
248         Support multiple signatures of diagnostic logging.
249         https://bugs.webkit.org/show_bug.cgi?id=138690
250
251         Reviewed by Anders Carlsson.
252
253         Page::PageClients has been renamed PageConfiguration.
254
255         * WebView/WebView.mm:
256         (-[WebView _commonInitializationWithFrameName:groupName:]):
257         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
258
259 2014-11-21  Zalan Bujtas  <zalan@apple.com>
260
261         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
262         https://bugs.webkit.org/show_bug.cgi?id=138981
263
264         Reviewed by Simon Fraser.
265
266         * WebView/WebPreferenceKeysPrivate.h:
267         * WebView/WebPreferences.mm:
268         (+[WebPreferences initialize]):
269         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
270         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
271         * WebView/WebPreferencesPrivate.h:
272         * WebView/WebView.mm:
273         (-[WebView _preferencesChanged:]):
274
275 2014-11-21  Tim Horton  <timothy_horton@apple.com>
276
277         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
278         ​https://bugs.webkit.org/show_bug.cgi?id=138960
279         <rdar://problem/19056715>
280
281         Reviewed by Anders Carlsson.
282
283         * WebView/WebActionMenuController.mm:
284         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
285         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
286         Use DataDetectors SPI instead of an explicit blacklist.
287
288 2014-11-21  Tim Horton  <timothy_horton@apple.com>
289
290         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
291         https://bugs.webkit.org/show_bug.cgi?id=138960
292         <rdar://problem/19056715>
293
294         Reviewed by Beth Dakin.
295
296         * WebView/WebActionMenuController.mm:
297         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
298         Blacklist contact results, because they don't have useful menus. If we
299         bail before setting up _currentActionContext, we'll still allow fallthrough
300         to ordinary text actions, avoiding mysterious failure when a contact is detected.
301
302         This doesn't break the case that r176351 was intended to fix,
303         because in that case we were detecting e.g. addresses.
304
305 2014-11-21  Anders Carlsson  <andersca@apple.com>
306
307         Remove the Timer parameters from timer callbacks
308         https://bugs.webkit.org/show_bug.cgi?id=138974
309
310         Reviewed by Antti Koivisto.
311
312         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
313         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
314         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
315         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
316         * Plugins/WebNetscapePluginStream.h:
317         * Plugins/WebNetscapePluginStream.mm:
318         (WebNetscapePluginStream::WebNetscapePluginStream):
319         (WebNetscapePluginStream::deliverDataTimerFired):
320
321 2014-11-21  Anders Carlsson  <andersca@apple.com>
322
323         Make memoryCache() return a reference
324         https://bugs.webkit.org/show_bug.cgi?id=138939
325
326         Reviewed by Antti Koivisto.
327
328         * Misc/WebCache.mm:
329         (+[WebCache statistics]):
330         (+[WebCache emptyInMemoryResources]):
331         (+[WebCache sizeOfDeadResources:]):
332         (+[WebCache addImageToCache:forURL:forFrame:]):
333         (+[WebCache removeImageFromCacheForURL:forFrame:]):
334         (+[WebCache imageForURL:]):
335         (+[WebCache setDisabled:]):
336         (+[WebCache isDisabled]):
337         * WebView/WebView.mm:
338         (+[WebView _setCacheModel:]):
339
340 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
341
342         Remove the remaining vestiges of minimal-ui
343         https://bugs.webkit.org/show_bug.cgi?id=138890
344
345         Reviewed by Sam Weinig.
346
347         * History/WebHistoryItem.mm:
348         * History/WebHistoryItemPrivate.h:
349
350 2014-11-20  Tim Horton  <timothy_horton@apple.com>
351
352         Cancel DataDetectors menu earlier if we know it can't be presented
353         https://bugs.webkit.org/show_bug.cgi?id=138922
354         <rdar://problem/18950441>
355
356         Reviewed by Beth Dakin.
357
358         * WebView/WebActionMenuController.mm:
359         (-[WebActionMenuController prepareForMenu:withEvent:]):
360         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
361         and use a bigger hammer (removeAllItems).
362
363         (-[WebActionMenuController willOpenMenu:withEvent:]):
364         If we end up with a menu with no items, don't change selection or anything.
365
366 2014-11-20  Beth Dakin  <bdakin@apple.com>
367
368         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
369         https://bugs.webkit.org/show_bug.cgi?id=138568
370         -and corresponding-
371         rdar://problem/18904600
372
373         Reviewed by Tim Horton.
374
375         Skip images for lookup.
376         * WebView/WebActionMenuController.mm:
377         (performDictionaryLookupForRange):
378
379 2014-11-19  Beth Dakin  <bdakin@apple.com>
380
381         Invoking an action menu on a selection should result in the text menu
382         https://bugs.webkit.org/show_bug.cgi?id=138892
383         -and corresponding-
384         rdar://problem/18996776
385
386         Reviewed by Tim Horton.
387
388         * WebView/WebActionMenuController.mm:
389         (-[WebActionMenuController _defaultMenuItems]):
390
391 2014-11-19  Beth Dakin  <bdakin@apple.com>
392
393         Data detected results with no menu items should not fall through to regular text 
394         action menus
395         https://bugs.webkit.org/show_bug.cgi?id=138887
396         -and corresponding-
397         rdar://problem/18971616
398
399         Reviewed by Tim Horton.
400
401         * WebView/WebActionMenuController.mm:
402         (-[WebActionMenuController _defaultMenuItems]):
403
404 2014-11-19  Daniel Bates  <dabates@apple.com>
405
406         [iOS] Make WebKit build with public iOS SDK
407         https://bugs.webkit.org/show_bug.cgi?id=136863
408
409         Reviewed by David Kilzer.
410
411         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
412         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
413         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
414         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
415         may be used by Apple internal clients that do not include wtf/Platform.h.
416         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
417         private Foundation headers directly.
418         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
419         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
420         instead of including private CFNetwork headers directly. Also fixed up style and
421         ordering of header include directives.
422         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
423         CFNetwork headers directly. Also sort the #import directives.
424         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
425         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
426
427 2014-11-18  David Kilzer  <ddkilzer@apple.com>
428
429         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
430         <http://webkit.org/b/138813>
431
432         Reviewed by Mark Rowe.
433
434         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
435         selectors.
436
437 2014-11-18  Chris Dumez  <cdumez@apple.com>
438
439         Add a setting to toggle DOMTimer throttling support
440         https://bugs.webkit.org/show_bug.cgi?id=138844
441         <rdar://problem/19020874>
442
443         Reviewed by Andreas Kling.
444
445         Add a setting to disable DOM timers throttling, in order to help
446         developers determine if a specific issue is caused by timer
447         throttling.
448
449         * WebView/WebPreferenceKeysPrivate.h:
450         * WebView/WebPreferences.mm:
451         (+[WebPreferences initialize]):
452         (-[WebPreferences domTimersThrottlingEnabled]):
453         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
454         * WebView/WebPreferencesPrivate.h:
455         * WebView/WebView.mm:
456         (-[WebView _preferencesChanged:]):
457
458 2014-11-18  Tim Horton  <timothy_horton@apple.com>
459
460         Avoid re-encoding action menu image data
461         https://bugs.webkit.org/show_bug.cgi?id=138817
462         <rdar://problem/18840382>
463
464         Reviewed by Anders Carlsson.
465
466         * WebView/WebActionMenuController.mm:
467         (-[WebActionMenuController _defaultMenuItemsForImage:]):
468         (-[WebActionMenuController _addImageToPhotos:]):
469         Build a temporary filename from a UUID and the image's desired extension.
470         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
471         Build an image menu only if we have an image, URL, data, and extension.
472
473 2014-11-18  Daniel Bates  <dabates@apple.com>
474
475         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
476         SPI are not available in public SDK
477         https://bugs.webkit.org/show_bug.cgi?id=138802
478
479         Reviewed by David Kilzer.
480
481         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
482         libdispatch and MobileGestalt headers directly.
483
484         * WebView/WebView.mm:
485
486 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
487
488         Remove calls to deprecated NSMenu methods
489         https://bugs.webkit.org/show_bug.cgi?id=138808.
490
491         Reviewed by Anders Carlsson.
492
493         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
494
495         * WebCoreSupport/PopupMenuMac.mm:
496         (PopupMenuMac::populate):
497
498 2014-11-17  Daniel Bates  <dabates@apple.com>
499
500         Unreviewed, rolling out r176232.
501
502         Broke the Mac build. Will investigate offline.
503
504         Reverted changeset:
505
506         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
507         MobileGestalt"
508         https://bugs.webkit.org/show_bug.cgi?id=138802
509         http://trac.webkit.org/changeset/176232
510
511 2014-11-17  Daniel Bates  <dabates@apple.com>
512
513         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
514         SPI are not available in public SDK
515         https://bugs.webkit.org/show_bug.cgi?id=138802
516
517         Reviewed by David Kilzer.
518
519         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
520         libdispatch and MobileGestalt headers directly.
521
522         * WebView/WebView.mm:
523
524 2014-11-17  Beth Dakin  <bdakin@apple.com>
525
526         Whitespace action menus should focus the HitTestResult and create an insertion 
527         point
528         https://bugs.webkit.org/show_bug.cgi?id=138786
529         -and corresponding-
530         rdar://problem/18944893
531
532         Reviewed by Tim Horton.
533
534         Whitespace menus should cause the HitTestResult to be focused, and they should set 
535         the selection based on the HitTest location.
536
537         * WebView/WebActionMenuController.mm:
538         (-[WebActionMenuController isMenuForTextContent]):
539         (-[WebActionMenuController focusAndSelectHitTestResult]):
540         (-[WebActionMenuController willOpenMenu:withEvent:]):
541
542 2014-11-17  Daniel Bates  <dabates@apple.com>
543
544         [iOS] QuartzCore SPI not available in public SDK
545         https://bugs.webkit.org/show_bug.cgi?id=138751
546
547         Reviewed by David Kilzer.
548
549         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
550
551         * WebInspector/WebNodeHighlight.mm:
552         * WebView/WebIndicateLayer.mm:
553
554 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
555
556         [iOS] allow host application to opt-out of alternate fullscreen
557         https://bugs.webkit.org/show_bug.cgi?id=138787
558
559         Reviewed by Darin Adler.
560
561         * WebView/WebPreferenceKeysPrivate.h:
562         * WebView/WebPreferences.mm:
563         (+[WebPreferences initialize]):
564         (-[WebPreferences allowsAlternateFullscreen]):
565         (-[WebPreferences setAllowsAlternateFullscreen:]):
566         * WebView/WebPreferencesPrivate.h:
567         * WebView/WebView.mm:
568         (-[WebView _preferencesChanged:]):
569
570 2014-11-16  Tim Horton  <timothy_horton@apple.com>
571
572         Use TextIndicator instead of the built in Lookup highlight
573         https://bugs.webkit.org/show_bug.cgi?id=138775
574         <rdar://problem/18953982>
575
576         Reviewed by Anders Carlsson.
577
578         * WebCoreSupport/WebSystemInterface.mm:
579         (InitWebCoreSystemInterface):
580         Remove a WKSI import.
581
582         * WebView/WebActionMenuController.mm:
583         (-[WebActionMenuController _lookupText:]):
584         (-[WebActionMenuController _createActionMenuItemForTag:]):
585         Make use of the new Lookup SPI header.
586         Disable the Lookup item if lookup is not available.
587
588 2014-11-15  Tim Horton  <timothy_horton@apple.com>
589
590         Implement data detectors and mailto action menus for WebKit1
591         https://bugs.webkit.org/show_bug.cgi?id=138765
592         <rdar://problem/18877535>
593
594         Reviewed by Beth Dakin.
595
596         * WebView/WebActionMenuController.h:
597         * WebView/WebActionMenuController.mm:
598         (-[WebActionMenuController willOpenMenu:withEvent:]):
599         Tell DataDetectors that the menu is going to open.
600         Select the text (or not) based on the number of items in the menu, just like WebKit2.
601
602         (-[WebActionMenuController didCloseMenu:withEvent:]):
603         Tell DataDetectors that the menu closed.
604
605         (-[WebActionMenuController _defaultMenuItemsForLink]):
606         Move these checks out of _defaultMenuItemsForLink, because we expect this
607         to always return a complete link menu.
608
609         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
610         Implement. More or less copied from WebKit2.
611
612         (-[WebActionMenuController _selectDataDetectedText]):
613         Select the stashed range.
614
615         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
616         Implement. More or less copied from WebKit2.
617         The yellow highlight isn't hooked up yet.
618         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
619
620         (-[WebActionMenuController _selectLookupText]):
621         Remove an unnecessary return.
622
623         (-[WebActionMenuController _defaultMenuItems]):
624         Call into the two new menu types.
625
626         * WebView/WebUIDelegatePrivate.h:
627
628 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
629
630         Get rid of WebFontCache
631         https://bugs.webkit.org/show_bug.cgi?id=134752
632
633         Reviewed by Dave Hyatt.
634
635         * WebView/WebHTMLView.mm:
636
637 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
638
639         Update some artwork for the legacy WebKit action menu
640         https://bugs.webkit.org/show_bug.cgi?id=138758
641         <rdar://problem/18989840>
642
643         * WebView/WebActionMenuController.mm:
644         (webKitBundleImageNamed): Deleted.
645         Fix the build.
646
647 2014-11-14  Tim Horton  <timothy_horton@apple.com>
648
649         Update some artwork for the legacy WebKit action menu
650         https://bugs.webkit.org/show_bug.cgi?id=138758
651         <rdar://problem/18989840>
652
653         Reviewed by Simon Fraser.
654
655         * WebView/WebActionMenuController.mm:
656         (-[WebActionMenuController _createActionMenuItemForTag:]):
657
658 2014-11-14  Daniel Bates  <dabates@apple.com>
659
660         [iOS] NSFileManager and QuickLook SPI not available in public SDK
661         https://bugs.webkit.org/show_bug.cgi?id=138742
662
663         Reviewed by Pratik Solanki.
664
665         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
666
667         * WebCoreSupport/WebFrameLoaderClient.mm:
668
669 2014-11-14  Beth Dakin  <bdakin@apple.com>
670
671         WK1: Webpage preview can come up in wrong location
672         https://bugs.webkit.org/show_bug.cgi?id=138747
673         -and corresponding-
674         rdar://problem/18979004
675
676         Reviewed by Tim Horton.
677
678         Converting to window twice is bad.
679         * WebView/WebActionMenuController.mm:
680         (elementBoundingBoxInWindowCoordinatesFromNode):
681         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
682         (elementBoundingBoxFromNode): Deleted.
683
684 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
685
686         Move FontMac and FontCacheMac off of WKSI
687         https://bugs.webkit.org/show_bug.cgi?id=138633
688
689         Reviewed by Simon Fraser.
690
691         * WebCoreSupport/WebSystemInterface.mm:
692         (InitWebCoreSystemInterface):
693         * WebKit.order:
694
695 2014-11-13  Beth Dakin  <bdakin@apple.com>
696
697         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
698         https://bugs.webkit.org/show_bug.cgi?id=138716
699         -and corresponding-
700         rdar://problem/18977222
701
702         Reviewed by Tim Horton.
703
704         It’s not necessary to use the WebElementDictionary for so many things now that we 
705         are caching the HitTestResult. We should just use the HitTestResult.
706
707         * WebView/WebActionMenuController.mm:
708         (-[WebActionMenuController prepareForMenu:withEvent:]):
709         (-[WebActionMenuController _openURLFromActionMenu:]):
710         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
711         (elementBoundingBoxFromNode):
712         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
713         (-[WebActionMenuController _defaultMenuItemsForLink]):
714         (-[WebActionMenuController _defaultMenuItemsForImage]):
715         (-[WebActionMenuController _defaultMenuItemsForVideo]):
716         (-[WebActionMenuController _defaultMenuItemsForText]):
717         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
718         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
719         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
720         (-[WebActionMenuController _createActionMenuItemForTag:]):
721         (-[WebActionMenuController _defaultMenuItems]):
722         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
723         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
724         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
725         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
726         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
727         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
728         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
729         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
730         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
731         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
732
733 2014-11-13  Daniel Bates  <dabates@apple.com>
734
735         [iOS] NSGeometry data types are not available in the public SDK
736         https://bugs.webkit.org/show_bug.cgi?id=137536
737
738         Reviewed by David Kilzer.
739
740         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
741         private header.
742
743         * DOM/WebDOMOperationsPrivate.h:
744
745 2014-11-13  Beth Dakin  <bdakin@apple.com>
746
747         WK1: Support default actions for video
748         https://bugs.webkit.org/show_bug.cgi?id=138713
749         -and corresponding-
750         rdar://problem/18877520
751
752         Reviewed by Tim Horton.
753
754         Call setToNonShadowAncestor() for media HitTestResults.
755         * WebView/WebActionMenuController.mm:
756         (-[WebActionMenuController performHitTestAtPoint:]):
757
758         Default items and actions.
759         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
760         (-[WebActionMenuController _copyVideoURL:]):
761         (-[WebActionMenuController _saveVideoToDownloads:]):
762         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
763         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
764         * WebView/WebUIDelegatePrivate.h:
765
766 2014-11-13  Tim Horton  <timothy_horton@apple.com>
767
768         WK1: Update icon for Add to Reading List
769         https://bugs.webkit.org/show_bug.cgi?id=138710
770         <rdar://problem/18975774>
771
772         Reviewed by Beth Dakin.
773
774         * WebView/WebActionMenuController.mm:
775         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
776         Use the right icon, matching WebKit2.
777
778 2014-11-12  Beth Dakin  <bdakin@apple.com>
779
780         WK1: Support default actions for images
781         https://bugs.webkit.org/show_bug.cgi?id=138668
782         -and corresponding-
783         rdar://problem/18785434
784
785         Reviewed by Tim Horton.
786
787         * WebView/WebActionMenuController.h:
788         * WebView/WebActionMenuController.mm:
789         (-[WebActionMenuController didCloseMenu:withEvent:]):
790         (-[WebActionMenuController _defaultMenuItemsForImage:]):
791         (-[WebActionMenuController _copyImage:]):
792         (temporaryPhotosDirectoryPath):
793         (pathToPhotoOnDisk):
794         (-[WebActionMenuController _canAddMediaToPhotos]):
795         (-[WebActionMenuController _addImageToPhotos:]):
796         (-[WebActionMenuController _saveImageToDownloads:]):
797         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
798         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
799         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
800         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
801         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
802         * WebView/WebUIDelegatePrivate.h:
803
804 2014-11-11  Beth Dakin  <bdakin@apple.com>
805
806         Action menu hit testing is not working properly with all WK1 apps
807         https://bugs.webkit.org/show_bug.cgi?id=138643
808         -and corresponding-
809         rdar://problem/18949376
810
811         Reviewed by Tim Horton.
812
813         * WebView/WebActionMenuController.mm:
814         (-[WebActionMenuController prepareForMenu:withEvent:]):
815         (-[WebActionMenuController _lookupText:]):
816
817 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
818
819         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
820         https://bugs.webkit.org/show_bug.cgi?id=138623
821
822         Reviewed by Geoff Garen.
823
824         * WebCoreSupport/WebSystemInterface.mm:
825         (InitWebCoreSystemInterface):
826         * WebKit.order:
827
828 2014-11-11  Tim Horton  <timothy_horton@apple.com>
829
830         Localize strings for action menus
831         https://bugs.webkit.org/show_bug.cgi?id=138591
832         <rdar://problem/18815343>
833
834         Reviewed by Dan Bates.
835
836         * WebView/WebActionMenuController.mm:
837         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
838         Make use of the new strings.
839
840 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
841
842         Cleanup from r175379
843         https://bugs.webkit.org/show_bug.cgi?id=138616
844
845         Reviewed by Simon Fraser.
846
847         * WebCoreSupport/WebSystemInterface.mm:
848         (InitWebCoreSystemInterface):
849         * WebKit.order:
850
851 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
852
853         Move CTFontTransformGlyphs out from WKSI
854         https://bugs.webkit.org/show_bug.cgi?id=138599
855
856         Reviewed by Simon Fraser.
857
858         * WebCoreSupport/WebSystemInterface.mm:
859         (InitWebCoreSystemInterface):
860         * WebKit.order:
861
862 2014-11-11  Dan Bernstein  <mitz@apple.com>
863
864         More iOS build fix.
865
866         * WebView/WebHTMLViewInternal.h:
867
868 2014-11-11  Dan Bernstein  <mitz@apple.com>
869
870         iOS build fix.
871
872         * WebView/WebHTMLView.mm:
873
874 2014-11-10  Beth Dakin  <bdakin@apple.com>
875
876         WK1: Support default actions for editable text with misspelled word
877         https://bugs.webkit.org/show_bug.cgi?id=138590
878         -and corresponding-
879         rdar://problem/18877506
880
881         Reviewed by Tim Horton.
882
883         If there are misspelled word suggestions for editable text, create a new type of 
884         menu with a spelling suggestion sub-menu.
885
886         * WebView/WebActionMenuController.mm:
887         (-[WebActionMenuController isMenuForTextContent]):
888         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
889         (-[WebActionMenuController _changeSelectionToSuggestion:]):
890         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
891         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
892         * WebView/WebHTMLView.mm:
893         (-[WebHTMLView _changeSpellingToWord:]):
894         * WebView/WebHTMLViewInternal.h:
895         * WebView/WebUIDelegatePrivate.h:
896
897 2014-11-10  Beth Dakin  <bdakin@apple.com>
898
899         WK1: Support default actions for editable whitespace
900         https://bugs.webkit.org/show_bug.cgi?id=138586
901         -and corresponding-
902         rdar://problem/18932048
903
904         Reviewed by Tim Horton.
905
906         New menu type. Just wants paste.
907
908         * WebView/WebActionMenuController.mm:
909         (-[WebActionMenuController isMenuForTextContent]):
910         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
911         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
912         * WebView/WebUIDelegatePrivate.h:
913
914 2014-11-10  Beth Dakin  <bdakin@apple.com>
915
916         WK1: Support default actions for editable text
917         https://bugs.webkit.org/show_bug.cgi?id=138580
918         -and corresponding-
919         rdar://problem/18877497
920
921         Reviewed by Tim Horton.
922
923         New menu type, and new action type for paste. 
924
925         * WebView/WebActionMenuController.mm:
926         (-[WebActionMenuController isMenuForTextContent]):
927         (-[WebActionMenuController willOpenMenu:withEvent:]):
928         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
929         (-[WebActionMenuController _paste:]):
930         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
931         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
932         * WebView/WebUIDelegatePrivate.h:
933
934 2014-11-10  Beth Dakin  <bdakin@apple.com>
935
936         WK1: Text is getting selected even when an action menu fails to invoke
937         https://bugs.webkit.org/show_bug.cgi?id=138576
938         -and corresponding-
939         rdar://problem/18931330
940
941         Reviewed by Tim Horton.
942
943         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
944         * WebView/WebActionMenuController.h:
945         * WebView/WebActionMenuController.mm:
946         (-[WebActionMenuController prepareForMenu:withEvent:]):
947         (-[WebActionMenuController willOpenMenu:withEvent:]):
948
949         _selectLookupText no longer needs to return a BOOL indicating success or failure.
950         (-[WebActionMenuController _selectLookupText]):
951         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
952
953         Pass willOpenMenu: on to the controller.
954         * WebView/WebView.mm:
955         (-[WebView willOpenMenu:withEvent:]):
956
957 2014-11-10  Beth Dakin  <bdakin@apple.com>
958
959         Speculative build fix.
960
961         * WebView/WebActionMenuController.mm:
962
963 2014-11-10  Beth Dakin  <bdakin@apple.com>
964
965         Action menu initialization should be moved to _commonInitializationWithFrameName
966         https://bugs.webkit.org/show_bug.cgi?id=138572
967         -and corresponding-
968         rdar://problem/18929733
969
970         Reviewed by Tim Horton.
971
972         * WebView/WebView.mm:
973         (-[WebView _commonInitializationWithFrameName:groupName:]):
974         (-[WebView _initWithFrame:frameName:groupName:]):
975
976 2014-11-10  Beth Dakin  <bdakin@apple.com>
977
978         WK1: Support default actions for read-only text
979         https://bugs.webkit.org/show_bug.cgi?id=138552
980         -and corresponding-
981         rdar://problem/18877483
982
983         Reviewed by Tim Horton.
984
985         New WKSystemInterface functions that WebCore needs to use.
986         * WebCoreSupport/WebSystemInterface.mm:
987         (InitWebCoreSystemInterface):
988
989         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
990         makes a lot of things easier.
991         * WebView/WebActionMenuController.h:
992         * WebView/WebActionMenuController.mm:
993
994         Perform the hit test ourselves instead of calling into WebView so that we can more 
995         easily save the WebCore::HitTestResult for ourselves.
996         (-[WebActionMenuController performHitTestAtPoint:]):
997
998         Clear selection for non-text menus.
999         (-[WebActionMenuController prepareForMenu:withEvent:]):
1000
1001         Re-set the _type here just to be safe.
1002         (-[WebActionMenuController didCloseMenu:withEvent:]):
1003
1004         Moving this method to be next to the link actions so they can be within a pragma 
1005         mark.
1006         (-[WebActionMenuController _defaultMenuItemsForLink:]):
1007
1008         New method for default text actions — lookup and copy.
1009         (-[WebActionMenuController _defaultMenuItemsForText:]):
1010         (-[WebActionMenuController _copySelection:]):
1011         (-[WebActionMenuController _lookupText:]):
1012
1013         If there is not already a selection, invoking the action menu on text should 
1014         select the lookup text.
1015         (-[WebActionMenuController _selectLookupText]):
1016         (performDictionaryLookupForSelection):
1017         (performDictionaryLookupForRange):
1018
1019         Handle text now.
1020         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1021         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1022
1023         New enum values.
1024         * WebView/WebUIDelegatePrivate.h:
1025
1026         Pass didCloseMenu on to the controller.
1027         * WebView/WebView.mm:
1028         (-[WebView didCloseMenu:withEvent:]):
1029
1030 2014-11-09  Chris Dumez  <cdumez@apple.com>
1031
1032         Add a more correct way to compare floating point numbers and use it
1033         https://bugs.webkit.org/show_bug.cgi?id=138527
1034
1035         Reviewed by Darin Adler.
1036
1037         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
1038         to compare floating-point numbers.
1039
1040         * WebView/WebHTMLView.mm:
1041         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
1042
1043 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
1044
1045         Delete cookies between tests
1046         https://bugs.webkit.org/show_bug.cgi?id=138528
1047
1048         Reviewed by Sam Weinig.
1049
1050         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
1051         * WebView/WebPreferencesPrivate.h:
1052         Added an SPI for DumpRenderTree.
1053
1054 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
1055
1056         [iOS] Update optimized fullscreen media controls
1057         https://bugs.webkit.org/show_bug.cgi?id=138493
1058
1059         Reviewed by Brent Fulgham.
1060
1061         * WebCoreSupport/WebSystemInterface.mm:
1062         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
1063
1064 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
1065
1066         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
1067         https://bugs.webkit.org/show_bug.cgi?id=138443
1068
1069         Reviewed by Anders Carlsson.
1070
1071         Wrapping the dealloc method in its own autorelease pool avoids the problem of
1072         complex tear-downs leading to the WebView itself being added to an autorelease
1073         pool that is not drained until after the instance has been dealloc'd.
1074  
1075         * WebView/WebView.mm:
1076         (-[WebView dealloc]):
1077
1078 2014-11-05  Jer Noble  <jer.noble@apple.com>
1079
1080         De-templatize Timer
1081         https://bugs.webkit.org/show_bug.cgi?id=138450
1082
1083         Reviewed by Anders Carlsson.
1084
1085         Remove template specifiers from Timer.
1086
1087         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1088         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1089         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
1090         * Plugins/WebNetscapePluginStream.h:
1091         * Plugins/WebNetscapePluginStream.mm:
1092         (WebNetscapePluginStream::deliverDataTimerFired):
1093
1094 2014-11-05  Dan Bernstein  <mitz@apple.com>
1095
1096         Remove the unused deletion UI feature
1097         https://bugs.webkit.org/show_bug.cgi?id=138442
1098
1099         Rubber-stamped by Alexey Proskuryakov.
1100
1101         * DefaultDelegates/WebDefaultEditingDelegate.m:
1102         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
1103         * WebCoreSupport/WebEditorClient.h:
1104         * WebCoreSupport/WebEditorClient.mm:
1105         (WebEditorClient::shouldShowDeleteInterface): Deleted.
1106         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
1107         -webView:shouldShowDeleteInterfaceForElement:.
1108
1109 2014-11-03  Dean Jackson  <dino@apple.com>
1110
1111         Add ENABLE_FILTERS_LEVEL_2 feature guard.
1112         https://bugs.webkit.org/show_bug.cgi?id=138362
1113
1114         Reviewed by Tim Horton.
1115
1116         Add a new feature define for Level 2 of CSS Filters.
1117         http://dev.w3.org/fxtf/filters-2/
1118
1119         * Configurations/FeatureDefines.xcconfig:
1120
1121 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
1122
1123         Add button and enable optimized fullscreen.
1124         https://bugs.webkit.org/show_bug.cgi?id=138351
1125
1126         Reviewed by Eric Carlson.
1127
1128         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
1129
1130         * WebCoreSupport/WebSystemInterface.mm:
1131         (InitWebCoreSystemInterface): added
1132
1133 2014-11-04  Chris Dumez  <cdumez@apple.com>
1134
1135         Add ptr() method to Ref class
1136         https://bugs.webkit.org/show_bug.cgi?id=138361
1137
1138         Reviewed by Darin Adler.
1139
1140         Use the new Ref::ptr() method.
1141
1142         * WebView/WebFrame.mm:
1143         (-[WebFrame _setTypingStyle:withUndoAction:]):
1144         * WebView/WebHTMLView.mm:
1145         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
1146         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
1147         * WebView/WebView.mm:
1148         (-[WebView applyStyle:]):
1149
1150 2014-11-04  Darin Adler  <darin@apple.com>
1151
1152         Eliminate ResourceBuffer and use SharedBuffer directly instead
1153         https://bugs.webkit.org/show_bug.cgi?id=138174
1154
1155         Reviewed by Antti Koivisto.
1156
1157         * WebView/WebDataSource.mm:
1158         (-[WebDataSource data]): Use SharedBuffer directly.
1159         * WebView/WebHTMLView.mm:
1160         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1161
1162 2014-11-03  Commit Queue  <commit-queue@webkit.org>
1163
1164         Unreviewed, rolling out r175406, r175413, and r175423.
1165         https://bugs.webkit.org/show_bug.cgi?id=138327
1166
1167         Multipart tests are still broken (Requested by ap on #webkit).
1168
1169         Reverted changesets:
1170
1171         "Eliminate ResourceBuffer and use SharedBuffer directly
1172         instead"
1173         https://bugs.webkit.org/show_bug.cgi?id=138174
1174         http://trac.webkit.org/changeset/175406
1175
1176         "Unreviewed, iOS build fix since 175406."
1177         http://trac.webkit.org/changeset/175413
1178
1179         "Fix assertion in CachedResource::addDataBuffer"
1180         http://trac.webkit.org/changeset/175423
1181
1182 2014-10-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1183
1184         Use std::unique_ptr for TypeCountSet
1185         https://bugs.webkit.org/show_bug.cgi?id=138242
1186
1187         Reviewed by Andreas Kling.
1188
1189         * Misc/WebCoreStatistics.mm:
1190         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr.
1191         (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto.
1192
1193 2014-10-31  Beth Dakin  <bdakin@apple.com>
1194
1195         Use system art for action menus when possible
1196         https://bugs.webkit.org/show_bug.cgi?id=138260
1197
1198         Reviewed by Tim Horton.
1199
1200         * WebView/WebActionMenuController.mm:
1201         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1202
1203 2014-10-30  Darin Adler  <darin@apple.com>
1204
1205         Eliminate ResourceBuffer and use SharedBuffer directly instead
1206         https://bugs.webkit.org/show_bug.cgi?id=138174
1207
1208         Reviewed by Antti Koivisto.
1209
1210         * WebView/WebDataSource.mm:
1211         (-[WebDataSource data]): Use SharedBuffer directly.
1212         * WebView/WebHTMLView.mm:
1213         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1214
1215 2014-10-30  Jer Noble  <jer.noble@apple.com>
1216
1217         [EME] Add Setting for accessing storage location for MediaKeys data
1218         https://bugs.webkit.org/show_bug.cgi?id=138147
1219
1220         Reviewed by Brady Eidson.
1221
1222         * WebView/WebPreferenceKeysPrivate.h:
1223         * WebView/WebPreferences.mm:
1224         (+[WebPreferences initialize]): Set default location.
1225         (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor.
1226         (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter.
1227         * WebView/WebPreferencesPrivate.h:
1228         * WebView/WebView.mm:
1229         (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings.
1230
1231 2014-10-30  Dana Burkart  <dburkart@apple.com>
1232
1233         <rdar://problem/18821260> Prepare for the mysterious future
1234
1235         Reviewed by Lucas Forschler.
1236
1237         * Configurations/Base.xcconfig:
1238         * Configurations/DebugRelease.xcconfig:
1239         * Configurations/FeatureDefines.xcconfig:
1240         * Configurations/Version.xcconfig:
1241
1242 2014-10-28  Jeremy Jones  <jeremyj@apple.com>
1243
1244         Add optimized fullscreen mode.
1245         https://bugs.webkit.org/show_bug.cgi?id=138044
1246
1247         Reviewed by Jer Noble.
1248
1249         Enable different types of fullscreen video behavior.
1250         Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
1251
1252         * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
1253         * WebCoreSupport/WebChromeClient.mm:
1254         (WebChromeClient::enterVideoFullscreenForVideoElement): ditto
1255         * WebView/WebView.mm:
1256         (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
1257         (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.
1258         * WebView/WebViewInternal.h: ditto
1259
1260 2014-10-27  Beth Dakin  <bdakin@apple.com>
1261
1262         Provide a way for WebKit1 clients to override default action menu items
1263         https://bugs.webkit.org/show_bug.cgi?id=138066
1264         -and corresponding-
1265         rdar://problem/18451638
1266
1267         Reviewed by Anders Carlsson.
1268
1269         WebActionMenuController now has an ivar for the WebActionMenuType so that it can 
1270         send that along to clients customizing the menu.
1271         * WebView/WebActionMenuController.h:
1272         * WebView/WebActionMenuController.mm:
1273         (-[WebActionMenuController prepareForMenu:withEvent:]):
1274         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1275
1276         New enum and new SPI to customize menus.
1277         * WebView/WebUIDelegatePrivate.h:
1278
1279 2014-10-24  Benjamin Poulain  <bpoulain@apple.com>
1280
1281         Fix the iOS build
1282
1283         * Configurations/WebKitLegacy.xcconfig:
1284         * WebView/WebView.mm:
1285
1286 2014-10-24  Beth Dakin  <bdakin@apple.com>
1287
1288         Build fix.
1289
1290         * WebView/WebActionMenuController.mm:
1291         (-[WebActionMenuController _openURLFromActionMenu:]):
1292         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
1293         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1294
1295 2014-10-24  Beth Dakin  <bdakin@apple.com>
1296
1297         WebKit1 should support action menus
1298         https://bugs.webkit.org/show_bug.cgi?id=138032
1299
1300         Reviewed by Tim Horton.
1301
1302         This patch adds basic support for action menus and adds actions for links.
1303
1304         Helper class takes care of all of the action menu work. WebView will forward the 
1305         prepareForMenu: message, and then the helper class takes it from there.
1306         * WebView/WebActionMenuController.h: Added.
1307         * WebView/WebActionMenuController.mm: Added.
1308         (-[WebActionMenuController webViewClosed]):
1309         (-[WebActionMenuController prepareForMenu:withEvent:]):
1310
1311         Selectors for link actions.
1312         (-[WebActionMenuController _openURLFromActionMenu:]):
1313         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
1314         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
1315         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1316         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1317         (webKitBundleImageNamed):
1318         (-[WebActionMenuController _defaultMenuItemsForLink:]):
1319         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1320
1321         Tags for the action menu items.
1322         * WebView/WebUIDelegatePrivate.h:
1323         * WebView/WebView.mm:
1324
1325         Set the action menu if possible and create the controller.
1326         (-[WebView _initWithFrame:frameName:groupName:]):
1327         (-[WebView _close]):
1328         (-[WebView prepareForMenu:withEvent:]):
1329
1330         WebViewData stores the WebActionMenuHelper
1331         * WebView/WebViewData.h:
1332         * WebView/WebViewData.mm:
1333         (-[WebViewPrivate dealloc]):
1334
1335 2014-10-23  Joseph Pecoraro  <pecoraro@apple.com>
1336
1337         Web Inspector: Provide a way to have alternate inspector agents
1338         https://bugs.webkit.org/show_bug.cgi?id=137901
1339
1340         Reviewed by Brian Burg.
1341
1342         * Configurations/FeatureDefines.xcconfig:
1343
1344 2014-10-23  Tim Horton  <timothy_horton@apple.com>
1345
1346         Add some SPI headers for NSExtension and NSSharingService{Picker}
1347         https://bugs.webkit.org/show_bug.cgi?id=138027
1348
1349         Reviewed by Anders Carlsson.
1350
1351         * Misc/WebSharingServicePickerController.h:
1352         * Misc/WebSharingServicePickerController.mm:
1353         * WebCoreSupport/WebSelectionServiceController.mm:
1354         * WebCoreSupport/WebContextMenuClient.mm:
1355         Fix a sorting issue.
1356         Replace redefinitions with SPI header #imports.
1357
1358 2014-10-23  Tim Horton  <timothy_horton@apple.com>
1359
1360         Crashes under WebSelectionServiceController::hasRelevantSelectionServices
1361         https://bugs.webkit.org/show_bug.cgi?id=138013
1362
1363         Reviewed by Dan Bernstein.
1364
1365         * WebCoreSupport/WebSelectionServiceController.mm:
1366         (WebSelectionServiceController::hasRelevantSelectionServices):
1367         Don't adopt this autoreleased object.
1368
1369 2014-10-22  Chris Dumez  <cdumez@apple.com>
1370
1371         [Mac][WK2] Fix applicationIsSafari() detection
1372         https://bugs.webkit.org/show_bug.cgi?id=137893
1373
1374         Reviewed by Alexey Proskuryakov.
1375
1376         Provide an implementation for FrameLoaderClient's new
1377         needsQuickLookResourceCachingQuirks() that returns
1378         a static flag initialized using
1379         QuickLookMac::computeNeedsQuickLookResourceCachingQuirks().
1380
1381         * WebCoreSupport/WebFrameLoaderClient.h:
1382         * WebCoreSupport/WebFrameLoaderClient.mm:
1383
1384 2014-10-20  Chris Dumez  <cdumez@apple.com>
1385
1386         ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition
1387         https://bugs.webkit.org/show_bug.cgi?id=137797
1388
1389         Reviewed by Darin Adler.
1390
1391         Call ResourceRequest::setDomainForPartitionName() instead of
1392         setPartitionName() as the argument is a domain, not a valid
1393         partition name.
1394
1395         * Misc/WebCache.mm:
1396         (+[WebCache addImageToCache:forURL:forFrame:]):
1397         (+[WebCache removeImageFromCacheForURL:forFrame:]):
1398
1399 2014-10-20  Andy Estes  <aestes@apple.com>
1400
1401         Fix the iOS build.
1402
1403         * WebView/WebFrame.mm:
1404         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1405         (-[WebFrame dictationResultMetadataForRange:]):
1406
1407 2014-10-19  Chris Dumez  <cdumez@apple.com>
1408
1409         Use is<>() / downcast<>() for all remaining RenderObject subclasses
1410         https://bugs.webkit.org/show_bug.cgi?id=137845
1411
1412         Reviewed by Darin Adler.
1413
1414         Use is<>() / downcast<>() for all remaining RenderObject subclasses and 
1415         clean up the surrounding code.
1416
1417         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1418         (-[WebHostedNetscapePluginView pluginHostDied]):
1419         * Plugins/WebBaseNetscapePluginView.mm:
1420         (-[WebBaseNetscapePluginView _windowClipRect]):
1421         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
1422         * WebCoreSupport/WebFrameLoaderClient.mm:
1423         (WebFrameLoaderClient::createPlugin):
1424         (WebFrameLoaderClient::createJavaAppletWidget):
1425
1426 2014-10-17  Tim Horton  <timothy_horton@apple.com>
1427
1428         Build fix for 32-bit Yosemite
1429
1430         * WebCoreSupport/WebContextMenuClient.mm:
1431         (WebContextMenuClient::contextMenuForEvent):
1432         Avoid using NSItemProvider in 32-bit, because it doesn't exist.
1433
1434 2014-10-17  Chris Dumez  <cdumez@apple.com>
1435
1436         Use is<>() / downcast<>() for RenderBox
1437         https://bugs.webkit.org/show_bug.cgi?id=137804
1438
1439         Reviewed by Andreas Kling.
1440
1441         Use is<>() / downcast<>() for RenderBox and clean up the surrounding
1442         code.
1443
1444         * WebCoreSupport/WebContextMenuClient.mm:
1445         (WebContextMenuClient::clientFloatRectForNode):
1446         * WebView/WebFrame.mm:
1447         (-[WebFrame renderedSizeOfNode:constrainedToWidth:]):
1448
1449 2014-10-17  Tim Horton  <timothy_horton@apple.com>
1450
1451         Fix the build with the public SDK.
1452
1453         * WebCoreSupport/WebSelectionServiceController.mm:
1454         We should transition all this SPI to real SPI headers as soon as possible.
1455
1456 2014-10-16  Tim Horton  <timothy_horton@apple.com>
1457
1458         Implement selection services menu for Legacy WebKit
1459         https://bugs.webkit.org/show_bug.cgi?id=137582
1460         <rdar://problem/18604241>
1461
1462         Reviewed by Brady Eidson.
1463
1464         * Misc/WebSharingServicePickerController.h:
1465         Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
1466         Add WebSharingServicePickerClient, which other classes can implement
1467         instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
1468         Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.
1469
1470         * Misc/WebSharingServicePickerController.mm:
1471         Pass in NSSharingServicePickerStyle, so that clients can specify the style.
1472
1473         (-[WebSharingServicePickerController clear]):
1474         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
1475         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
1476         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
1477         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
1478         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
1479         Make use of WebSharingServicePickerClient.
1480
1481         (-[WebSharingServicePickerController sharingService:didShareItems:]):
1482         If we're returned a NSAttributedString, paste it on top of the current selection,
1483         similar to what the WebKit2 implementation currently does.
1484         
1485         * WebCoreSupport/WebChromeClient.h:
1486         * WebCoreSupport/WebChromeClient.mm:
1487         (WebChromeClient::handleTelephoneNumberClick):
1488         (WebChromeClient::handleSelectionServiceClick):
1489         (WebChromeClient::hasRelevantSelectionServices):
1490         Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.
1491
1492         * WebCoreSupport/WebContextMenuClient.h:
1493         * WebCoreSupport/WebContextMenuClient.mm:
1494         (WebContextMenuClient::sharingServicePickerWillBeDestroyed):
1495         (WebContextMenuClient::pageForSharingServicePicker):
1496         (WebContextMenuClient::windowForSharingServicePicker):
1497         (WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
1498         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1499         (WebContextMenuClient::contextMenuForEvent):
1500         (WebContextMenuClient::screenRectForHitTestNode): Deleted.
1501         (WebContextMenuClient::renderedImageForControlledImage): Deleted.
1502         (WebContextMenuClient::clearSharingServicePickerController): Deleted.
1503         Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
1504         having WebSharingServicePickerController tightly bound to it.
1505         Make an NSItemProvider array when instantiating WebSharingServicePickerController
1506         instead of handing it data directly.
1507
1508         * WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
1509         * WebCoreSupport/WebSelectionServiceController.mm: Added.
1510         (WebSelectionServiceController::WebSelectionServiceController):
1511         Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
1512         for selection services.
1513
1514         (WebSelectionServiceController::handleSelectionServiceClick):
1515         Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.
1516
1517         (hasCompatibleServicesForItems):
1518         (WebSelectionServiceController::hasRelevantSelectionServices):
1519         Determine whether or not services are available.
1520
1521         (WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
1522         (WebSelectionServiceController::pageForSharingServicePicker):
1523         (WebSelectionServiceController::windowForSharingServicePicker):
1524         Implement the rest of the WebSharingServicePickerClient overrides.
1525
1526         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
1527         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
1528         These are only useful for image sharing services, so we don't need to
1529         implement them (WebContextMenuClient does, on the other hand).
1530
1531         * WebView/WebView.mm:
1532         (-[WebView _selectionServiceController]):
1533         * WebView/WebViewData.h:
1534         * WebView/WebViewData.mm:
1535         * WebView/WebViewInternal.h:
1536         Keep a WebSelectionServiceController.
1537
1538 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
1539
1540         Improve debug description of WAKViews
1541         https://bugs.webkit.org/show_bug.cgi?id=137716
1542
1543         Reviewed by Simon Fraser.
1544
1545         * WebView/WebView.mm:
1546         (-[WebView _touchEventRegions]): Adding a comment.
1547
1548 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
1549
1550         Addressing post-review comment.
1551         https://bugs.webkit.org/show_bug.cgi?id=137550
1552
1553         Unreviewed.
1554
1555         * WebView/WebHTMLView.mm:
1556         (fontNameForDescription):
1557         (-[WebHTMLView _addToStyle:fontA:fontB:]):
1558
1559 2014-10-14  Chris Dumez  <cdumez@apple.com>
1560
1561         Use is<>() / downcast<>() for RenderImage
1562         https://bugs.webkit.org/show_bug.cgi?id=137683
1563
1564         Reviewed by Mihnea Ovidenie.
1565
1566         Use is<>() / downcast<>() for RenderImage.
1567
1568         * Misc/WebNSPasteboardExtras.mm:
1569         (imageFromElement):
1570         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1571
1572 2014-10-10  Daniel Bates  <dabates@apple.com>
1573
1574         Remove unused classes WebRender{Node, Layer}
1575         https://bugs.webkit.org/show_bug.cgi?id=137628
1576
1577         Reviewed by Simon Fraser.
1578
1579         We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
1580         For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.
1581
1582         * Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list
1583         of excluded source files when building for iOS.
1584         * WebKit.exp: Remove symbol for WebRenderLayer.
1585         * WebKit.mac.exp: Remove symbol for WebRenderNode.
1586         * WebView/WebRenderLayer.h: Removed.
1587         * WebView/WebRenderLayer.mm: Removed.
1588         * WebView/WebRenderNode.h: Removed.
1589         * WebView/WebRenderNode.mm: Removed.
1590
1591 2014-10-10  Chris Dumez  <cdumez@apple.com>
1592
1593         Use is<>() / downcast<>() for RenderBoxModelObject
1594         https://bugs.webkit.org/show_bug.cgi?id=137587
1595
1596         Reviewed by Mihnea Ovidenie.
1597
1598         Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
1599         surrounding code.
1600
1601         * Plugins/WebBaseNetscapePluginView.mm:
1602         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
1603         * WebView/WebRenderLayer.mm:
1604         (-[WebRenderLayer initWithWebFrame:]):
1605
1606 2014-10-09  Dean Jackson  <dino@apple.com>
1607
1608         Remove ENABLE_CSS3_CONDITIONAL_RULES
1609         https://bugs.webkit.org/show_bug.cgi?id=137571
1610
1611         Reviewed by Simon Fraser.
1612
1613         * Configurations/FeatureDefines.xcconfig:
1614
1615 2014-10-09  Tim Horton  <timothy_horton@apple.com>
1616
1617         Add a WebKit1 preference for selection services
1618         https://bugs.webkit.org/show_bug.cgi?id=137498
1619         <rdar://problem/18572699>
1620
1621         Reviewed by Simon Fraser.
1622
1623         * WebView/WebPreferenceKeysPrivate.h:
1624         * WebView/WebPreferences.mm:
1625         (+[WebPreferences initialize]):
1626         (-[WebPreferences serviceControlsEnabled]):
1627         (-[WebPreferences setServiceControlsEnabled:]):
1628         * WebView/WebPreferencesPrivate.h:
1629         * WebView/WebView.mm:
1630         (-[WebView _preferencesChanged:]):
1631         Add and plumb the preference.
1632
1633 2014-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
1634
1635         Remove second-to-last client of WebFontCache
1636         https://bugs.webkit.org/show_bug.cgi?id=137550
1637
1638         Reviewed by Darin Adler.
1639
1640         Use FontCache::getCachedFontData() instead of WebFontCache.
1641
1642         * WebView/WebHTMLView.mm:
1643         (-[WebHTMLView _addToStyle:fontA:fontB:]):
1644
1645 2014-10-09  Chris Dumez  <cdumez@apple.com>
1646
1647         Use is<>() / downcast<>() for Widget subclasses
1648         https://bugs.webkit.org/show_bug.cgi?id=137549
1649
1650         Reviewed by Darin Adler.
1651
1652         Use is<>() / downcast<>() for Widget subclasses and clean up the
1653         surrounding code.
1654
1655         * WebView/WebRenderNode.mm:
1656         (copyRenderNode):
1657         * WebView/WebView.mm:
1658         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
1659
1660 2014-10-07  Christophe Dumez  <cdumez@apple.com>
1661
1662         Use is<>() / downcast<>() for RenderText / RenderTextFragment
1663         https://bugs.webkit.org/show_bug.cgi?id=137476
1664
1665         Reviewed by Darin Adler.
1666
1667         * WebView/WebRenderNode.mm:
1668         (copyRenderNode):
1669
1670 2014-10-06  Dan Bernstein  <mitz@apple.com>
1671
1672         Build fix.
1673
1674         * Misc/WebCache.mm:
1675         (+[WebCache imageForURL:]):
1676
1677 2014-10-06  Chris Dumez  <cdumez@apple.com>
1678
1679         Unreviewed build fix after r174333.
1680
1681         Forgot explicit WebCore:: namespace.
1682
1683         * Misc/WebCache.mm:
1684         (+[WebCache imageForURL:]):
1685
1686 2014-10-05  Christophe Dumez  <cdumez@apple.com>
1687
1688         Use is<>() / downcast<>() for CachedResource subclasses
1689         https://bugs.webkit.org/show_bug.cgi?id=137431
1690
1691         Reviewed by Benjamin Poulain.
1692
1693         Use is<>() / downcast<>() for CachedResource subclasses.
1694
1695         * Misc/WebCache.mm:
1696         (+[WebCache imageForURL:]):
1697
1698 2014-10-02  Daniel Bates  <dabates@apple.com>
1699
1700         Use version number 101000 instead of 10100 for OS X Yosemite
1701         https://bugs.webkit.org/show_bug.cgi?id=137372
1702
1703         Reviewed by Mark Rowe.
1704
1705         The version number for OS X Yosemite is 101000.
1706
1707         * WebView/WebView.mm:
1708         (-[WebView _preferencesChanged:]):
1709
1710 2014-10-02  Tim Horton  <timothy_horton@apple.com>
1711
1712         Move PageOverlay[Controller] to WebCore
1713         https://bugs.webkit.org/show_bug.cgi?id=137164
1714         <rdar://problem/18508258>
1715
1716         Reviewed by Anders Carlsson.
1717
1718         * WebCoreSupport/WebChromeClient.h:
1719         * WebCoreSupport/WebChromeClient.mm:
1720         (WebChromeClient::attachViewOverlayGraphicsLayer):
1721         Add an empty ChromeClient override.
1722
1723 2014-10-01  Christophe Dumez  <cdumez@apple.com>
1724
1725         Have is<>(T*) function do a null check on the pointer argument
1726         https://bugs.webkit.org/show_bug.cgi?id=137333
1727
1728         Reviewed by Gavin Barraclough.
1729
1730         Have is<>(T*) function do a null check on the argument instead of a
1731         simple assertion. This makes sense for 2 reasons:
1732         1. It is more consistent with downcast<>(T*), which will succeed even
1733            if the argument is a nullptr.
1734         2. It simplifies the code a bit as it gets rid of a lot of explicit
1735            null checks.
1736
1737         * WebCoreSupport/WebChromeClient.mm:
1738         (WebChromeClient::focusedElementChanged):
1739         * WebCoreSupport/WebEditorClient.mm:
1740         (WebEditorClient::textFieldDidBeginEditing):
1741         (WebEditorClient::textFieldDidEndEditing):
1742         (WebEditorClient::textDidChangeInTextField):
1743         (WebEditorClient::doTextFieldCommandFromEvent):
1744         (WebEditorClient::textWillBeDeletedInTextField):
1745         (WebEditorClient::textDidChangeInTextArea):
1746         * WebView/WebHTMLRepresentation.mm:
1747         (inputElementFromDOMElement):
1748         (searchForLabelsBeforeElement):
1749         * WebView/WebRenderLayer.mm:
1750         (+[WebRenderLayer nameForLayer:]):
1751
1752 2014-10-01  Mark Rowe  <mrowe@apple.com>
1753
1754         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
1755
1756         Reviewed by Dan Bernstein.
1757
1758         * Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite.
1759
1760 2014-09-30  Chris Dumez  <cdumez@apple.com>
1761
1762         Use is<>() / downcast<>() for Element
1763         https://bugs.webkit.org/show_bug.cgi?id=137241
1764
1765         Reviewed by Andreas Kling.
1766
1767         Use is<>() / downcast<>() for Element instead of isElementNode() /
1768         toElement().
1769
1770         * WebView/WebRenderLayer.mm:
1771         (+[WebRenderLayer nameForLayer:]):
1772
1773 2014-09-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1774
1775         Move ColorInputType class to std::unique_ptr
1776         https://bugs.webkit.org/show_bug.cgi?id=137173
1777
1778         Reviewed by Darin Adler.
1779
1780         Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr.
1781         Child classes follow this change as well.
1782
1783         * WebCoreSupport/WebChromeClient.h:
1784         * WebCoreSupport/WebChromeClient.mm:
1785         (WebChromeClient::createColorChooser):
1786
1787 2014-09-24  Christophe Dumez  <cdumez@apple.com>
1788
1789         Add initial is<>() / downcast<>() support for any type of Nodes
1790         https://bugs.webkit.org/show_bug.cgi?id=137056
1791
1792         Reviewed by Benjamin Poulain.
1793
1794         Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
1795         instead of isFormControlElement() / toHTMLFormControlElement().
1796
1797         * WebView/WebHTMLRepresentation.mm:
1798         (searchForLabelsBeforeElement):
1799
1800 2014-09-24  Christophe Dumez  <cdumez@apple.com>
1801
1802         Use is<HTML*Element>() instead of isHTML*Element() - Part 1
1803         https://bugs.webkit.org/show_bug.cgi?id=137068
1804
1805         Reviewed by Ryosuke Niwa.
1806
1807         Start using is<HTML*Element>() instead of isHTML*Element().
1808         Remaining usages will be updated in a follow-up patch to
1809         reduce the size of the change.
1810
1811         * WebCoreSupport/WebChromeClient.mm:
1812         (WebChromeClient::focusedElementChanged):
1813         * WebCoreSupport/WebEditorClient.mm:
1814         (WebEditorClient::textFieldDidBeginEditing):
1815         (WebEditorClient::textFieldDidEndEditing):
1816         (WebEditorClient::textDidChangeInTextField):
1817         (WebEditorClient::doTextFieldCommandFromEvent):
1818         (WebEditorClient::textWillBeDeletedInTextField):
1819         (WebEditorClient::textDidChangeInTextArea):
1820         * WebView/WebHTMLRepresentation.mm:
1821         (inputElementFromDOMElement):
1822
1823 2014-09-21  Timothy Hatcher  <timothy@apple.com>
1824
1825         Make the Web Inspector use a separate web process.
1826
1827         https://bugs.webkit.org/show_bug.cgi?id=135120
1828
1829         Reviewed by Anders Carlsson.
1830
1831         * WebCoreSupport/WebInspectorClient.h:
1832         * WebCoreSupport/WebInspectorClient.mm:
1833         (WebInspectorClient::WebInspectorClient):
1834         (WebInspectorClient::openInspectorFrontend):
1835         (WebInspectorClient::releaseFrontend):
1836         Own WebInspectorFrontendClient instead of moving it.
1837
1838 2014-09-23  Chris Dumez  <cdumez@apple.com>
1839
1840         Use downcast<HTML*Element>() instead of toHTML*Element()
1841         https://bugs.webkit.org/show_bug.cgi?id=137007
1842
1843         Reviewed by Benjamin Poulain.
1844
1845         Use downcast<HTML*Element>() instead of toHTML*Element().
1846
1847         * DOM/WebDOMOperations.mm:
1848         (-[DOMHTMLInputElement _setAutofilled:]):
1849         * WebCoreSupport/WebChromeClient.mm:
1850         (WebChromeClient::focusedElementChanged):
1851         * WebCoreSupport/WebEditorClient.mm:
1852         (WebEditorClient::textFieldDidBeginEditing):
1853         (WebEditorClient::textFieldDidEndEditing):
1854         (WebEditorClient::textDidChangeInTextField):
1855         (WebEditorClient::doTextFieldCommandFromEvent):
1856         (WebEditorClient::textWillBeDeletedInTextField):
1857         (WebEditorClient::textDidChangeInTextArea):
1858         * WebView/WebHTMLRepresentation.mm:
1859         (inputElementFromDOMElement):
1860
1861 2014-09-21  Chris Dumez  <cdumez@apple.com>
1862
1863         Generate Element casting helper functions
1864         https://bugs.webkit.org/show_bug.cgi?id=136839
1865
1866         Reviewed by Darin Adler.
1867
1868         Use JSXXX::toWrapped() instead of toXXX() function.
1869
1870         * DOM/WebDOMOperations.mm:
1871         * WebView/WebView.mm:
1872         (-[WebView _notificationIDForTesting:]):
1873
1874 2014-09-21  Joseph Pecoraro  <pecoraro@apple.com>
1875
1876         Leak: WebNotificationPrivate ObjC leaks seen on leaks bot
1877         https://bugs.webkit.org/show_bug.cgi?id=136972
1878
1879         Reviewed by Darin Adler.
1880
1881         * WebView/WebNotification.h:
1882         * WebView/WebNotification.mm:
1883         (-[WebNotification initWithCoreNotification:notificationID:]):
1884         Switch to RetainPtr and adopt into _private to ensure when we are
1885         deallocated that _private will get deallocated.
1886
1887 2014-09-19  Dean Jackson  <dino@apple.com>
1888
1889         Multithreaded WebGL is a bad idea - remove it
1890         https://bugs.webkit.org/show_bug.cgi?id=136964
1891         <rdar://problem/18399858>
1892
1893         Reviewed by Brent Fulgham.
1894
1895         Remove the setting to allow multithreaded WebGL.
1896
1897         * WebView/WebPreferenceKeysPrivate.h:
1898         * WebView/WebPreferences.mm:
1899         (+[WebPreferences initialize]):
1900         (-[WebPreferences multithreadedWebGLEnabled]): Deleted.
1901         (-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted.
1902         * WebView/WebPreferencesPrivate.h:
1903         * WebView/WebView.mm:
1904         (-[WebView _preferencesChanged:]):
1905
1906 2014-09-19  Daniel Bates  <dabates@apple.com>
1907
1908         Always assume internal SDK when building configuration Production
1909         https://bugs.webkit.org/show_bug.cgi?id=136925
1910         <rdar://problem/18362399>
1911
1912         Reviewed by Dan Bernstein.
1913
1914         As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
1915         and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.
1916
1917         * Configurations/Base.xcconfig:
1918
1919 2014-09-17  Daniel Bates  <dabates@apple.com>
1920
1921         Unreviewed, rolling out r173695.
1922
1923         Broke building third-party Legacy WebKit apps; will
1924         investigate offline
1925
1926         Reverted changeset:
1927
1928         "[iOS] Make WebCore build with public iOS SDK"
1929         https://bugs.webkit.org/show_bug.cgi?id=136487
1930         http://trac.webkit.org/changeset/173695
1931
1932 2014-09-17  Daniel Bates  <dabates@apple.com>
1933
1934         [iOS] Make WebCore build with public iOS SDK
1935         https://bugs.webkit.org/show_bug.cgi?id=136487
1936
1937         Reviewed by David Kilzer.
1938
1939         Update WebKit1 source files to include the wrapper SPI headers instead of the corresponding
1940         actual SPI header(s).
1941
1942         * DOM/WebDOMOperationsPrivate.h:
1943         * MigrateHeaders.make: Modified to only modify the include path of a "<WebCore/"-prefixed header
1944         file if its filename doesn't end in "SPI.h" as an alternative to having MigrateHeaders.make copy
1945         such files into the WebKit framework as private headers.
1946         * WebCoreSupport/WebFrameLoaderClient.mm:
1947         * WebInspector/WebNodeHighlight.mm:
1948         * WebView/WebIndicateLayer.mm:
1949         * WebView/WebRenderLayer.h:
1950         * WebView/WebView.mm:
1951
1952 2014-09-16  Daniel Bates  <dabates@apple.com>
1953
1954         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
1955         https://bugs.webkit.org/show_bug.cgi?id=136862
1956
1957         Reviewed by David Kilzer.
1958
1959         * Configurations/DebugRelease.xcconfig:
1960
1961 2014-09-16  Enrica Casucci  <enrica@apple.com>
1962
1963         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
1964         https://bugs.webkit.org/show_bug.cgi?id=136474
1965
1966         Reviewed by Benjamin Poulain.
1967
1968         This is the updated version of the patch that was landed in r173340.
1969         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
1970         and removes the assumption that EAffinity values match NSSelectionAffinity
1971         values. It also removes the includes in TextAffinity.h, creating the need to
1972         include explicitly the files when necessary.
1973
1974         * WebCoreSupport/WebEditorClient.h:
1975         (kit):
1976         (core):
1977
1978 2014-09-14  Daniel Bates  <dabates@apple.com>
1979
1980         [iOS] Attempt to fix the iOS build after <http://trac.webkit.org/changeset/173606>
1981         (https://bugs.webkit.org/show_bug.cgi?id=136789)
1982
1983         Substitute Node::countChildNodes() for Node::childNodeCount() in more places.
1984
1985         * WebView/WebFrame.mm:
1986         (-[WebFrame focusedNodeHasContent]):
1987
1988 2014-09-14  Chris Dumez  <cdumez@apple.com>
1989
1990         Rename Node::childNodeCount() to countChildNodes() and avoid inefficient uses
1991         https://bugs.webkit.org/show_bug.cgi?id=136789
1992
1993         Reviewed by Darin Adler.
1994
1995         Rename childNodeCount() to countChildNodes().
1996
1997         * WebView/WebHTMLView.mm:
1998         (-[WebHTMLView attributedString]):
1999
2000 2014-09-10  Jon Honeycutt  <jhoneycutt@apple.com>
2001
2002         Re-add the request autocomplete feature
2003
2004         <https://bugs.webkit.org/show_bug.cgi?id=136730>
2005
2006         This feature was rolled out in r148731 because it was only used by
2007         Chromium. As we consider supporting this feature, roll it back in, but
2008         leave it disabled.
2009
2010         This rolls out r148731 (which removed the feature) with small changes
2011         needed to make the code build in ToT, to match modern style, to make
2012         the tests run, and to remove unused code.
2013
2014         Reviewed by Andy Estes.
2015
2016         * Configurations/FeatureDefines.xcconfig:
2017         * WebCoreSupport/WebFrameLoaderClient.h:
2018
2019 2014-09-12  Commit Queue  <commit-queue@webkit.org>
2020
2021         Unreviewed, rolling out r173575.
2022         https://bugs.webkit.org/show_bug.cgi?id=136790
2023
2024         Failing tests (Requested by enrica on #webkit).
2025
2026         Reverted changeset:
2027
2028         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
2029         https://bugs.webkit.org/show_bug.cgi?id=136474
2030         http://trac.webkit.org/changeset/173575
2031
2032 2014-09-12  Enrica Casucci  <enrica@apple.com>
2033
2034         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
2035         https://bugs.webkit.org/show_bug.cgi?id=136474
2036
2037         Reviewed by Benjamin Poulain.
2038
2039         This is the updated version of the patch that was landed in r173340.
2040         I changed the use of IntPoint to FloatPoint since it was causing tests
2041         to fail.
2042         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
2043         and removes the assumption that EAffinity values match NSSelectionAffinity
2044         values. It also removes the includes in TextAffinity.h, creating the need to
2045         include explicitly the files when necessary. It also removes the unnecessary
2046         use of platform specific types, replacing them with WebCore types.
2047
2048         * WebCoreSupport/WebEditorClient.h:
2049         (kit):
2050         (core):
2051         * WebView/WebFrameView.mm:
2052         (-[WebFrameView _scrollToBeginningOfDocument]):
2053         (-[WebFrameView _scrollToEndOfDocument]):
2054
2055 2014-09-11  Bear Travis  <betravis@adobe.com>
2056
2057         [CSS Font Loading] Enable CSS Font Loading on Mac
2058         https://bugs.webkit.org/show_bug.cgi?id=135473
2059
2060         Reviewed by Antti Koivisto.
2061
2062         Enable CSS Font Loading in FeatureDefines.
2063
2064         * Configurations/FeatureDefines.xcconfig:
2065
2066 2014-09-11  Beth Dakin  <bdakin@apple.com>
2067
2068         Support rubber-banding in sub-frames
2069         https://bugs.webkit.org/show_bug.cgi?id=136726
2070         -and corresponding-
2071         rdar://problem/10011924
2072
2073         Reviewed by Tim Horton.
2074
2075         rubberBandingForOverflowScrollEnabled is re-named to
2076         rubberBandingForSubScrollableRegionsEnabled
2077         * WebView/WebView.mm:
2078         (-[WebView _preferencesChanged:]):
2079
2080 2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
2081
2082         Disable the "unreachable-code" warning
2083         https://bugs.webkit.org/show_bug.cgi?id=136677
2084
2085         Reviewed by Darin Adler.
2086
2087         * Configurations/Base.xcconfig:
2088
2089 2014-09-08  Maciej Stachowiak  <mjs@apple.com>
2090
2091         Fix 32-bit Mac build for new warnings
2092         https://bugs.webkit.org/show_bug.cgi?id=136624
2093
2094         Reviewed by Darin Adler.
2095         
2096         (Jessie already fixed this but my version with typedefs seems a tiny bit cleaner.)
2097
2098         * Carbon/HIViewAdapter.m:
2099         (+[HIViewAdapter bindHIViewToNSView:nsView:]): Need to use explicit casting now.
2100
2101 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2102
2103         Remove FILTERS flag
2104         https://bugs.webkit.org/show_bug.cgi?id=136571
2105
2106         Reviewed by Darin Adler.
2107
2108         * Configurations/FeatureDefines.xcconfig:
2109
2110 2014-09-08  Jessie Berlin  <jberlin@apple.com>
2111
2112         32-bit build fix after r173364.
2113
2114         * Carbon/HIViewAdapter.m:
2115         (+[HIViewAdapter bindHIViewToNSView:nsView:]):
2116
2117 2014-09-08  Dan Bernstein  <mitz@apple.com>
2118
2119         Build fix.
2120
2121         Added back SPI that is still in use.
2122
2123         * Misc/WebNSURLExtras.h:
2124         * Misc/WebNSURLExtras.mm:
2125         (-[NSURL _webkit_URLByRemovingFragment]):
2126
2127 2014-09-08  Dan Bernstein  <mitz@apple.com>
2128
2129         iOS Simulator build fix.
2130
2131         * Misc/WebKitSystemBits.m:
2132         (WebMemorySize):
2133
2134 2014-09-07  Darin Adler  <darin@apple.com>
2135
2136         Fix build failure seen on Mountain Lion buildbot.
2137
2138         * Misc/WebNSDataExtras.h: Make WEB_GUESS_MIME_TYPE_PEEK_LENGTH an unsigned instead
2139         of an int, to avoid warning about mixing signs.
2140
2141 2014-09-06  Darin Adler  <darin@apple.com>
2142
2143         Make updates suggested by new version of Xcode
2144         https://bugs.webkit.org/show_bug.cgi?id=136603
2145
2146         Reviewed by Mark Rowe.
2147
2148         * Configurations/Base.xcconfig: Added CLANG_WARN_UNREACHABLE_CODE, COMBINE_HIDPI_IMAGES,
2149         and ENABLE_STRICT_OBJC_MSGSEND as suggested by Xcode upgrade check.
2150
2151         * History/WebURLsWithTitles.m:
2152         (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): Use NSUInteger instead of
2153         unsigned for correctness, and to quiet the 32-to-64-bit compiler warning (which is
2154         not turned on because it gives us too many false positives).
2155         * Misc/WebElementDictionary.mm:
2156         (-[WebElementDictionary objectForKey:]): Ditto.
2157         * Misc/WebNSDataExtras.m:
2158         (-[NSData _webkit_guessedMIMETypeForXML]): Ditto.
2159         (-[NSData _webkit_guessedMIMEType]): Ditto.
2160         (-[NSData _webkit_parseRFC822HeaderFields]): Ditto.
2161         (-[NSData _web_locationAfterFirstBlankLine]): Ditto.
2162
2163         * Misc/WebNSURLExtras.h: Removed unused _web_URLWithLowercasedScheme, _web_hostData,
2164         _webkit_URLByRemovingFragment, _webkit_URLByRemovingResourceSpecifier, _webkit_isFTPDirectoryURL,
2165         _webkit_shouldLoadAsEmptyDocument, _web_hostNameNeedsDecodingWithRange:,
2166         _web_hostNameNeedsEncodingWithRange:, _web_decodeHostNameWithRange:, _web_encodeHostNameWithRange:,
2167         and _webkit_URLFragment methods.
2168
2169         * Misc/WebNSURLExtras.mm:
2170         (-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): Deleted.
2171         (-[NSURL _webkit_URLByRemovingFragment]): Deleted.
2172         (-[NSURL _webkit_URLByRemovingResourceSpecifier]): Deleted.
2173         (-[NSURL _webkit_isFTPDirectoryURL]): Deleted.
2174         (-[NSURL _webkit_shouldLoadAsEmptyDocument]): Deleted.
2175         (-[NSURL _web_URLWithLowercasedScheme]): Deleted.
2176         (-[NSString _webkit_isFTPDirectoryURL]): Deleted.
2177         (-[NSString _web_hostNameNeedsDecodingWithRange:]): Deleted.
2178         (-[NSString _web_hostNameNeedsEncodingWithRange:]): Deleted.
2179         (-[NSString _web_decodeHostNameWithRange:]): Deleted.
2180         (-[NSString _web_encodeHostNameWithRange:]): Deleted.
2181         (-[NSString _webkit_URLFragment]): Deleted.
2182
2183         * Plugins/WebPluginDatabase.mm:
2184         (-[WebPluginDatabase removePluginInstanceViewsFor:]): Use a modern for loop
2185         to iterate an array instead of a loop using the type "unsigned int".
2186
2187         * WebCoreSupport/WebOpenPanelResultListener.mm:
2188         (-[WebOpenPanelResultListener chooseFilenames:]): Use NSUInteger instead of int.
2189
2190         * WebView/WebDelegateImplementationCaching.mm:
2191         (CallDelegate): Use wtfCallIMP in one overload that was instead just calling the
2192         directly without a proper type for the function pointer. This might have been causing
2193         an actual problem on 64-bit systems, and it was different from all the other CallDelegate
2194         functions that were already doing this correctly.
2195
2196         * WebView/WebTextCompletionController.mm:
2197         (-[WebTextCompletionController _placePopupWindow:]): Use NSUInteger instead of int.
2198
2199 2014-09-06  Brian J. Burg  <burg@cs.washington.edu>
2200
2201         Web Inspector: convert DockSide to an enum class
2202         https://bugs.webkit.org/show_bug.cgi?id=136601
2203
2204         Reviewed by Timothy Hatcher.
2205
2206         * WebCoreSupport/WebInspectorClient.mm:
2207         (WebInspectorFrontendClient::frontendLoaded):
2208         (-[WebInspectorWindowController attachWindow:]):
2209         (-[WebInspectorWindowController attach]):
2210         (-[WebInspectorWindowController detach]):
2211         * WebInspector/WebInspectorFrontend.mm:
2212         (-[WebInspectorFrontend attach]):
2213
2214 2014-09-05  Commit Queue  <commit-queue@webkit.org>
2215
2216         Unreviewed, rolling out r173340 and r173342.
2217         https://bugs.webkit.org/show_bug.cgi?id=136596
2218
2219         Broke many tests (Requested by ap on #webkit).
2220
2221         Reverted changesets:
2222
2223         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
2224         https://bugs.webkit.org/show_bug.cgi?id=136474
2225         http://trac.webkit.org/changeset/173340
2226
2227         "Build fix after r173340."
2228         http://trac.webkit.org/changeset/173342
2229
2230 2014-09-05  Enrica Casucci  <enrica@apple.com>
2231
2232         Build fix after r173340.
2233
2234         * WebCoreSupport/WebEditorClient.h:
2235         (kit):
2236         (core):
2237
2238 2014-09-05  Enrica Casucci  <enrica@apple.com>
2239
2240         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
2241         https://bugs.webkit.org/show_bug.cgi?id=136474
2242
2243         Reviewed by Benjamin Poulain.
2244
2245         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
2246         and removes the assumption that EAffinity values match NSSelectionAffinity
2247         values. It also removes the includes in TextAffinity.h, creating the need to
2248         include explicitly the files when necessary. It also removes the unnecessary
2249         use of platform specific types, replacing them with WebCore types.
2250
2251         * WebCoreSupport/WebEditorClient.h: Added kit and core for EAffinity.
2252         * WebView/WebFrameView.mm:
2253         (-[WebFrameView _scrollToBeginningOfDocument]):
2254         (-[WebFrameView _scrollToEndOfDocument]):
2255
2256 2014-09-05  Daniel Bates  <dabates@apple.com>
2257
2258         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
2259         (https://bugs.webkit.org/show_bug.cgi?id=136564)
2260
2261         Move #endif inside -viewDidMoveToWindow up one line such that the closing brace ('}') is after it.
2262
2263         * WebView/WebHTMLView.mm:
2264         (-[WebHTMLView viewDidMoveToWindow]):
2265
2266 2014-09-05  Daniel Bates  <dabates@apple.com>
2267
2268         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
2269         (https://bugs.webkit.org/show_bug.cgi?id=136564)
2270
2271         Add !PLATFORM(IOS)-guard in -viewDidMoveToWindow around code that references WebHTMLViewPrivate.flagsChangedEventMonitor.
2272         The instance variable WebHTMLViewPrivate.flagsChangedEventMonitor is guarded by !PLATFORM(IOS).
2273
2274         * WebView/WebHTMLView.mm:
2275         (-[WebHTMLView viewDidMoveToWindow]):
2276
2277 2014-09-05  Daniel Bates  <dabates@apple.com>
2278
2279         [iOS] Fix the iOS build after <http://trac.webkit.org/changeset/173309>
2280         (https://bugs.webkit.org/show_bug.cgi?id=136564)
2281
2282         Include more code inside the !PLATFORM(IOS)-guarded section in -setDataSource:.
2283
2284         * WebView/WebHTMLView.mm:
2285         (-[WebHTMLView setDataSource:]):
2286
2287 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
2288
2289         Use tracking areas instead of (SPI) mouse moved notifications, and follow flags changes with an event monitor
2290         https://bugs.webkit.org/show_bug.cgi?id=136564
2291
2292         Reviewed by Dan Bernstein.
2293         
2294         WebKit1 depended on mouse moved event notifications to track mouse
2295         moves, and on being specially called by Safari to track flags
2296         changes. WebKit2 does both these things better - it uses a tracking area
2297         and event monitors. Copy those approaches.
2298
2299         * WebKit.order: Remove reference to obsolete call.
2300         * WebView/WebHTMLView.mm:
2301         (-[WebHTMLViewPrivate dealloc]): No need to deallocate tracking
2302         area, since we now just always have one.
2303         (-[WebHTMLViewPrivate clear]): ditto
2304         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
2305         New method that posts a fake mouse move event in response to
2306         a flags change event, for use by the event monitor.
2307         (+[WebHTMLView _postFlagsChangedEvent:]): Empty this old call,
2308         still kept around for benefit of older Safari.
2309         (-[WebHTMLView _updateMouseoverWithEvent:]): Handle Dashboard's
2310         special mouseover mode (previously handled in a weird way).
2311         (-[WebHTMLView close]): No more need to mess with mouse moved observer.
2312         (-[WebHTMLView viewWillMoveToWindow:]): ditto
2313         (-[WebHTMLView viewDidMoveToWindow]): ditto; but now hook up a flags
2314         changed monitor.
2315         (-[WebHTMLView windowDidBecomeKey:]): No need to handle non-key window
2316         tracking area or mouse moved observer.
2317         (-[WebHTMLView windowDidResignKey:]): ditto
2318         (-[WebHTMLView windowWillOrderOnScreen:]): No need to mess with mouse
2319         moved observer.
2320         (-[WebHTMLView windowWillOrderOffScreen:]): ditto
2321         (-[WebHTMLView mouseMoved:]): Converted from the old mouseMovedNotification:
2322         (-[WebHTMLView setDataSource:]): Change if around body to early return. Hook
2323         up tracking area - we have to do it here, because before this point, the
2324         WebHTMLView does not know its WebView, which is where dashboard settings
2325         live.
2326         (-[WebHTMLView _removeMouseMovedObserverUnconditionally]): Deleted.
2327         (-[WebHTMLView addMouseMovedObserver]): Deleted.
2328         (-[WebHTMLView removeMouseMovedObserver]): Deleted.
2329
2330 2014-09-04  Pratik Solanki  <psolanki@apple.com>
2331
2332         Bring back [WebPreferences setDiskImageCacheEnabled:] for backwards compatibility
2333         https://bugs.webkit.org/show_bug.cgi?id=136560
2334
2335         Reviewed by Joseph Pecoraro.
2336
2337         I removed the disk image caching code in r173265. However, we still have clients that call
2338         setDiskImageCacheEnabled. Add in a stub method until we can wean the clients off this call.
2339
2340         * WebView/WebPreferences.mm:
2341         (-[WebPreferences setDiskImageCacheEnabled:]):
2342         * WebView/WebPreferencesPrivate.h:
2343
2344 2014-09-03  Andy Estes  <aestes@apple.com>
2345
2346         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
2347         https://bugs.webkit.org/show_bug.cgi?id=136521
2348
2349         Reviewed by Anders Carlsson.
2350
2351         Taught MigrateHeaders.make to remove WEBCORE_EXPORT from headers using this sed expression:
2352
2353             s/(^ *)WEBCORE_EXPORT /\1/g
2354
2355         This removes WEBCORE_EXPORT and a single following space character but preserves preceeding spaces.
2356
2357         * MigrateHeaders.make:
2358
2359 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
2360
2361         Remove WebCoreSystemInterface glue for otherwise unused WKSI calls
2362         https://bugs.webkit.org/show_bug.cgi?id=136527
2363
2364         Reviewed by Alexey Proskuryakov.
2365
2366         * WebCoreSupport/WebSystemInterface.mm:
2367         (InitWebCoreSystemInterface):
2368
2369 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2370
2371         Remove CSS_FILTERS flag
2372         https://bugs.webkit.org/show_bug.cgi?id=136529
2373
2374         Reviewed by Dirk Schulze.
2375
2376         * Configurations/FeatureDefines.xcconfig:
2377
2378 2014-09-04  Pratik Solanki  <psolanki@apple.com>
2379
2380         Remove iOS specific disk image cache
2381         https://bugs.webkit.org/show_bug.cgi?id=136517
2382
2383         Reviewed by Antti Koivisto.
2384
2385         Disk image cache code unnecessarily complicates SharedBuffer implementation. We can remove
2386         this now since we don't enable it in WebKit2 on iOS.
2387
2388         * Misc/WebCache.mm:
2389         (+[WebCache statistics]):
2390         * WebView/WebDataSource.mm:
2391         (-[WebDataSource _setAllowToBeMemoryMapped]):
2392         (-[WebDataSource setDataSourceDelegate:]):
2393         (-[WebDataSource dataSourceDelegate]):
2394         (-[WebDataSource dealloc]):
2395         (BufferMemoryMapped): Deleted.
2396         * WebView/WebPreferenceKeysPrivate.h:
2397         * WebView/WebPreferences.mm:
2398         (+[WebPreferences initialize]):
2399         (-[WebPreferences diskImageCacheEnabled]): Deleted.
2400         (-[WebPreferences setDiskImageCacheEnabled:]): Deleted.
2401         (-[WebPreferences diskImageCacheMinimumImageSize]): Deleted.
2402         (-[WebPreferences setDiskImageCacheMinimumImageSize:]): Deleted.
2403         (-[WebPreferences diskImageCacheMaximumCacheSize]): Deleted.
2404         (-[WebPreferences setDiskImageCacheMaximumCacheSize:]): Deleted.
2405         (-[WebPreferences _diskImageCacheSavedCacheDirectory]): Deleted.
2406         (-[WebPreferences _setDiskImageCacheSavedCacheDirectory:]): Deleted.
2407         * WebView/WebPreferencesPrivate.h:
2408         * WebView/WebView.mm:
2409         (-[WebView _commonInitializationWithFrameName:groupName:]):
2410         (+[WebView _handleMemoryWarning]):
2411         (-[WebView _preferencesChanged:]):
2412
2413 2014-09-04  Daniel Bates  <dabates@apple.com>
2414
2415         [iOS] Make iOS build when ENABLE_TOUCH_EVENT and ENABLE_IOS_TOUCH_EVENTS disabled
2416         https://bugs.webkit.org/show_bug.cgi?id=136494
2417
2418         Reviewed by Andy Estes.
2419
2420         * MigrateHeaders.make: Migrate header WebEventRegion.h only when ENABLE_IOS_TOUCH_EVENTS is defined.
2421         * WebView/WebView.mm: Substitute ENABLE(IOS_TOUCH_EVENTS) for ENABLE(TOUCH_EVENTS).
2422
2423 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
2424
2425         Web Inspector: fix prefixes for subclasses of JSC::ConsoleClient
2426         https://bugs.webkit.org/show_bug.cgi?id=136476
2427
2428         Reviewed by Timothy Hatcher.
2429
2430         * Misc/WebCoreStatistics.mm:
2431         (+[WebCoreStatistics shouldPrintExceptions]):
2432         (+[WebCoreStatistics setShouldPrintExceptions:]):
2433
2434 2014-09-03  Enrica Casucci  <enrica@apple.com>
2435
2436         Remove PLATFORM(IOS) from WebCore/editing (Part 1).
2437         https://bugs.webkit.org/show_bug.cgi?id=136474
2438
2439         Reviewed by Tim Horton.
2440
2441         * WebCoreSupport/WebEditorClient.mm:
2442         (undoNameForEditAction):
2443
2444 2014-09-02  Maciej Stachowiak  <mjs@apple.com>
2445
2446         Clean up naming for and slightly refactor legacy video fullscreen support
2447         https://bugs.webkit.org/show_bug.cgi?id=136446
2448
2449         Reviewed by Jer Noble.
2450
2451         Key changes:
2452         supportsFullscreenForNode(Node*) --> supportsVideoFullscreen()
2453         enterFullscreenForNode(Node*) --> enterVideoFullscreenForVideoElement(HTMLVideoElement*)
2454         exitFullscreenForNode(Node*) --> exitVideoFullscreen()
2455         
2456         The old versions had unnecessary parameters, did not clearly distinguish their purpose
2457         from enterFullscreenForElement and friends, and wrongly claimed generality to all Nodes.
2458         Also changed many other places to use HTMLVideoElement* instead of Node* or 
2459         HTMLMediaElement* when they were in fact only used for video elements and would only
2460         work for such.
2461
2462         * WebCoreSupport/WebChromeClient.h:
2463         * WebCoreSupport/WebChromeClient.mm:
2464         (WebChromeClient::supportsVideoFullscreen): Adjust for main refactoring.
2465         Also no more need to check for video elementness.
2466         (WebChromeClient::enterVideoFullscreenForVideoElement): Adjust for main refactoring.
2467         (WebChromeClient::exitVideoFullscreen): ditto
2468         * WebView/WebView.mm:
2469         (-[WebView _enterVideoFullscreenForVideoElement:]): Adjust for main
2470         refactoring.
2471         (-[WebView _exitVideoFullscreen]): ditto
2472         (-[WebView _close]): ditto
2473         * WebView/WebViewInternal.h:
2474
2475 2014-09-03  Dan Bernstein  <mitz@apple.com>
2476
2477         Get rid of HIGH_DPI_CANVAS leftovers
2478         https://bugs.webkit.org/show_bug.cgi?id=136491
2479
2480         Reviewed by Benjamin Poulain.
2481
2482         * Configurations/FeatureDefines.xcconfig: Removed definition of ENABLE_HIGH_DPI_CANVAS
2483         and removed it from FEATURE_DEFINES.
2484
2485 2014-08-31  Tim Horton  <timothy_horton@apple.com>
2486
2487         Remove unnecessary (and unnecessarily iOS-specific) setStrokeAndFillColor
2488         https://bugs.webkit.org/show_bug.cgi?id=136416
2489
2490         Reviewed by Dan Bernstein.
2491
2492         * WebView/WebFrameView.mm:
2493         (-[WebFrameView drawRect:]):
2494         We only end up filling, so only set the fill color.
2495
2496 2014-08-26  Maciej Stachowiak  <mjs@apple.com>
2497
2498         Use RetainPtr::autorelease in some places where it seems appropriate
2499         https://bugs.webkit.org/show_bug.cgi?id=136280
2500
2501         Reviewed by Darin Adler.
2502
2503         * WebView/WebHTMLView.mm:
2504         (imageFromRect): Use RetainPtr in this function.
2505         * WebView/WebPDFRepresentation.mm:
2506         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use RetainPtr
2507         in this method.
2508
2509 2014-08-29  Csaba Osztrogonác  <ossy@webkit.org>
2510
2511         Unreviwed, remove empty directories.
2512
2513         * ForwardingHeaders/wtf: Removed.
2514
2515 2014-08-27  Zalan Bujtas  <zalan@apple.com>
2516
2517         Subpixel layout: Rename LayoutRect's device pixel snapping functions.
2518         https://bugs.webkit.org/show_bug.cgi?id=136319
2519
2520         Reviewed by Simon Fraser.
2521
2522         From pixelSnappedForPainting() to snapRectToDevicePixels() and 
2523         pixelSnappedIntRect*() to snappedIntRect*().
2524
2525         No change in functionality.
2526
2527         * WebView/WebView.mm:
2528         (-[WebView _dashboardRegions]):
2529         (-[WebView trackedRepaintRects]):
2530
2531 2014-08-25  Maciej Stachowiak  <mjs@apple.com>
2532
2533         Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API
2534         https://bugs.webkit.org/show_bug.cgi?id=136082
2535
2536         Reviewed by Alexey Proskuryakov.
2537
2538         * Plugins/Hosted/NetscapePluginHostManager.mm:
2539         (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current
2540         localization name using WebCore helper instead of SPI.
2541         * Plugins/WebBasePluginPackage.mm: Fixed the include style for this 
2542         file.
2543         (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current
2544         localization name using WebCore helper instead of SPI.
2545         (+[WebBasePluginPackage preferredLocalizationName]): Deleted. This
2546         helper no longer pulls its weight.
2547         * WebCoreSupport/WebSystemInterface.mm: 
2548         (InitWebCoreSystemInterface): Remove mention of
2549         WKCopyCFLocalizationPreferredName.
2550         * WebKit.order: ditto
2551
2552 2014-08-25  Daniel Bates  <dabates@apple.com>
2553
2554         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/172889>
2555         (https://bugs.webkit.org/show_bug.cgi?id=109658)
2556
2557         Substitute GraphicsLayer::setContentsToPlatformLayer(..., GraphicsLayer::ContentsLayerForMedia)
2558         for GraphicsLayer::setContentsToMedia(...) because the latter was removed in <http://trac.webkit.org/changeset/172889>.
2559
2560         * WebView/WebView.mm:
2561         (-[WebView _setMediaLayer:forPluginView:]):
2562
2563 2014-08-22  Commit Queue  <commit-queue@webkit.org>
2564
2565         Unreviewed, rolling out r172866.
2566         https://bugs.webkit.org/show_bug.cgi?id=136177
2567
2568         Broke iOS build (Requested by othermaciej on #webkit).
2569
2570         Reverted changeset:
2571
2572         "Replace use of WKCopyCFLocalizationPreferredName with
2573         NSLocale public API"
2574         https://bugs.webkit.org/show_bug.cgi?id=136082
2575         http://trac.webkit.org/changeset/172866
2576
2577 2014-08-22  Simon Fraser  <simon.fraser@apple.com>
2578
2579         Implement paint flashing in the WK1 InspectorOverlay page
2580         https://bugs.webkit.org/show_bug.cgi?id=136138
2581
2582         Reviewed by Sam Weinig, Joseph Pecoraro.
2583
2584         Implement paint flashing for the WebKit1 InspectorOverlay via a second canvas in the overlay page.
2585         We avoid allocating backing store for this canvas until we have paint rects.
2586         
2587         Because this overlay page is weird and doesn't know how to paint itself, InspectorOverlay manages
2588         an array of rects, and pushes them to the page when they change, before forcing a paint.
2589         
2590         Because iOS doesn't use the InspectorOverlay page, stub out setShowPaintRects on its
2591         WebKit WebInspectorClient, but don't yet implement paint flashing there.
2592
2593         * WebCoreSupport/WebInspectorClient.h:
2594         * WebCoreSupport/WebInspectorClient.mm:
2595         (WebInspectorClient::WebInspectorClient):
2596
2597 2014-08-20  Maciej Stachowiak  <mjs@apple.com>
2598
2599         Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API
2600         https://bugs.webkit.org/show_bug.cgi?id=136082
2601
2602         Reviewed by Alexey Proskuryakov.
2603
2604         * Plugins/Hosted/NetscapePluginHostManager.mm:
2605         (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current
2606         localization name using WebCore helper instead of SPI.
2607         * Plugins/WebBasePluginPackage.mm: Fixed the include style for this 
2608         file.
2609         (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current
2610         localization name using WebCore helper instead of SPI.
2611         (+[WebBasePluginPackage preferredLocalizationName]): Deleted. This
2612         helper no longer pulls its weight.
2613         * WebCoreSupport/WebSystemInterface.mm: 
2614         (InitWebCoreSystemInterface): Remove mention of
2615         WKCopyCFLocalizationPreferredName.
2616         * WebKit.order: ditto
2617
2618 2014-08-22  Daniel Bates  <dabates@apple.com>
2619
2620         [iOS] Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, and temporarily disable ENABLE_TOUCH_EVENTS
2621         and ENABLE_XSLT when building with the iOS public SDK
2622         https://bugs.webkit.org/show_bug.cgi?id=135945
2623
2624         Reviewed by Andy Estes.
2625
2626         * Configurations/FeatureDefines.xcconfig: Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, ENABLE_TOUCH_EVENTS
2627         and ENABLE_XSLT when building with the public SDK.
2628         * MigrateHeaders.make: Conditionally migrate headers for touch and gesture events.
2629
2630 2014-08-22  Jon Lee  <jonlee@apple.com>
2631
2632         Fix iOS build due to r172832 and move RUBBER_BANDING out of FeatureDefines.h
2633         https://bugs.webkit.org/show_bug.cgi?id=136157
2634
2635         Reviewed by Simon Fraser.
2636
2637         * Configurations/FeatureDefines.xcconfig: Add ENABLE(RUBBER_BANDING).
2638         * WebView/WebView.mm:
2639         (-[WebView _preferencesChanged:]): Wrap in ENABLE(RUBBER_BANDING).
2640
2641 2014-08-21  Zalan Bujtas  <zalan@apple.com>
2642
2643         Enable SATURATED_LAYOUT_ARITHMETIC.
2644         https://bugs.webkit.org/show_bug.cgi?id=136106
2645
2646         Reviewed by Simon Fraser.
2647
2648         SATURATED_LAYOUT_ARITHMETIC protects LayoutUnit against arithmetic overflow.
2649         (No measurable performance regression on Mac.)
2650
2651         * Configurations/FeatureDefines.xcconfig:
2652
2653 2014-08-21  Beth Dakin  <bdakin@apple.com>
2654
2655         overflow:scroll elements should support rubber-banding
2656         https://bugs.webkit.org/show_bug.cgi?id=91655
2657
2658         Reviewed by Sam Weinig and Darin Adler.
2659
2660         Disable rubber-banding in overflow areas for now.
2661         * WebView/WebView.mm:
2662         (-[WebView _preferencesChanged:]):
2663
2664 2014-08-19  Pratik Solanki  <psolanki@apple.com>
2665
2666         Remove PurgeableBuffer since it is not very useful any more
2667         https://bugs.webkit.org/show_bug.cgi?id=135939
2668
2669         Reviewed by Andreas Kling.
2670
2671         * Misc/WebCache.mm:
2672         (+[WebCache statistics]):
2673
2674 2014-08-19  Zalan Bujtas  <zalan@apple.com>
2675
2676         Remove ENABLE(SUBPIXEL_LAYOUT).
2677         https://bugs.webkit.org/show_bug.cgi?id=136077
2678
2679         Reviewed by Simon Fraser.
2680
2681         Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.
2682
2683         * Configurations/FeatureDefines.xcconfig:
2684
2685 2014-08-18  Maciej Stachowiak  <mjs@apple.com>
2686
2687         Use NSURLFileTypeMappings directly instead of depending on WebKitSystemInterface wrappers for it
2688         https://bugs.webkit.org/show_bug.cgi?id=136035
2689
2690         Reviewed by Dan Bernstein.
2691
2692         * Misc/WebNSViewExtras.m:
2693         (-[NSView _web_DragImageForElement:rect:event:pasteboard:source:offset:]): Remove comment
2694         reference to obsolete WKSI function.
2695         * WebCoreSupport/WebSystemInterface.mm:
2696         (InitWebCoreSystemInterface): Don't initialize the no-longer-used WKGetExtensionsForMIMEType,
2697         WKGetPreferredExtensionForMIMEType, or WKGetMIMETypeForExtension
2698         * Plugins/WebPluginDatabase.mm:
2699         (-[WebPluginDatabase pluginForExtension:]): Include SPI header from WebCore; use
2700         NSURLFileTypeMappings directly instead of via WKSI wrapper.
2701         * WebCoreSupport/WebFrameLoaderClient.mm:
2702         (WebFrameLoaderClient::objectContentType): ditto
2703         * WebView/WebHTMLView.mm:
2704         (-[WebHTMLView _imageExistsAtPaths:]): ditto
2705         * WebView/WebView.mm:
2706         (+[WebView _supportedFileExtensions]): ditto
2707         (+[WebView suggestedFileExtensionForMIMEType:]): ditto
2708         (+[WebView _MIMETypeForFile:]): ditto
2709
2710 2014-08-18  Commit Queue  <commit-queue@webkit.org>
2711
2712         Unreviewed, rolling out r172736.
2713         https://bugs.webkit.org/show_bug.cgi?id=136060
2714
2715         Caused 14% PLT regressions (Requested by rniwa on #webkit).
2716
2717         Reverted changeset:
2718
2719         "Remove PurgeableBuffer since it is not very useful any more"
2720         https://bugs.webkit.org/show_bug.cgi?id=135939
2721         http://trac.webkit.org/changeset/172736
2722
2723 2014-08-18  Pratik Solanki  <psolanki@apple.com>
2724
2725         Remove PurgeableBuffer since it is not very useful any more
2726         https://bugs.webkit.org/show_bug.cgi?id=135939
2727
2728         Reviewed by Geoffrey Garen.
2729
2730         * Misc/WebCache.mm:
2731         (+[WebCache statistics]):
2732
2733 2014-08-18  Andy Estes  <aestes@apple.com>
2734
2735         REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
2736         https://bugs.webkit.org/show_bug.cgi?id=136010
2737
2738         Reviewed by Darin Adler.
2739
2740         * Misc/WebKitVersionChecks.h: Removed WEBKIT_FIRST_VERSION_WITH_NAVIGATION_URL_VALIDATION.
2741         * WebView/WebPDFView.mm:
2742         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Passed AllowNavigationToInvalidURL::Yes to FrameLoader::loadFrameRequest.
2743         * WebView/WebView.mm:
2744         (-[WebView _preferencesChanged:]): Reverted the linked-on-or-after check added in r170120 since it's no longer necessary.
2745
2746 2014-08-18  Andy Estes  <aestes@apple.com>
2747
2748         Revert r172697.
2749
2750         It made several webarchive layout tests flaky and didn't have the correct behavior for non-quick redirects.
2751
2752         * Misc/WebKitVersionChecks.h:
2753         * WebView/WebView.mm:
2754         (-[WebView _preferencesChanged:]):
2755
2756 2014-08-15  Andy Estes  <aestes@apple.com>
2757
2758         REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
2759         https://bugs.webkit.org/show_bug.cgi?id=136010
2760
2761         Reviewed by Darin Adler.
2762
2763         Reverted the linked-on-or-after check added in r170120 since it is no longer necessary.
2764
2765         * Misc/WebKitVersionChecks.h:
2766         * WebView/WebView.mm:
2767         (-[WebView _preferencesChanged:]):
2768
2769 2014-08-16  Maciej Stachowiak  <mjs@apple.com>
2770
2771         Remove the obsolete WebKitEnableCoalescedUpdatesPreferenceKey
2772         https://bugs.webkit.org/show_bug.cgi?id=136024
2773
2774         Reviewed by Filip Pizlo.
2775
2776         * WebView/WebFrameView.mm:
2777         (-[WebFrameView initWithFrame:]): Remove code that respects
2778         this key. It was SPI and is no longer used; also it was
2779         only relevant for versions of OS X that WebKit no longer supports.
2780         * WebView/WebPreferenceKeysPrivate.h: Remove declaration.
2781
2782 2014-08-15  Daniel Bates  <dabates@apple.com>
2783
2784         [iOS] Teach postprocess-headers.sh to remove code guarded by ENABLE_IOS_GESTURE_EVENTS
2785         and ENABLE_TOUCH_EVENTS if applicable
2786         https://bugs.webkit.org/show_bug.cgi?id=135993
2787
2788         Reviewed by Andy Estes.
2789
2790         Add support infrastructure to remove code from public and private API headers that is
2791         guarded by macro define ENABLE_{IOS_GESTURE, TOUCH}_EVENTS when these features are disabled.
2792
2793         We aren't using this functionality yet, but we will soon.
2794
2795         * postprocess-headers.sh:
2796
2797 2014-08-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2798
2799         Enable CSS_SCROLL_SNAP for iOS
2800         https://bugs.webkit.org/show_bug.cgi?id=135915
2801
2802         Turn on CSS_SCROLL_SNAP for iOS and the iOS simulator.
2803
2804         Reviewed by Tim Horton.
2805
2806         * Configurations/FeatureDefines.xcconfig:
2807
2808 2014-08-13  Mark Rowe  <mrowe@apple.com>
2809
2810         <https://webkit.org/b/135911> WebKit should build on Yosemite with the public SDK.
2811
2812         Reviewed by Darin Adler.
2813
2814         * Misc/WebSharingServicePickerController.mm: Forward-declare some details related to NSSharingServicePicker.
2815
2816 2014-08-13  Timothy Hatcher  <timothy@apple.com>
2817
2818         Web Inspector: Workaround a NSWindow change to the title bar.
2819         https://bugs.webkit.org/show_bug.cgi?id=135880
2820
2821         Reviewed by Joseph Pecoraro.
2822
2823         * WebCoreSupport/WebInspectorClient.mm:
2824         (WebInspectorFrontendClient::setToolbarHeight): Only call setContentBorderThickness: on 10.9 and earlier.
2825         (-[WebInspectorWindowController init]): Only call setDrawsBackground: on 10.9 and earlier.
2826         (-[WebInspectorWindowController window]): Set titlebarAppearsTransparent on 10.10.
2827         Only call border thickness APIs on 10.9 and earlier.
2828
2829 2014-08-12  Peyton Randolph  <prandolph@apple.com>
2830
2831         Runtime switch for long mouse press gesture. Part of 135257 - Add long mouse press gesture.           
2832         https://bugs.webkit.org/show_bug.cgi?id=135682
2833
2834         Reviewed by Tim Horton.
2835
2836         * Configurations/FeatureDefines.xcconfig:
2837         Remove LONG_MOUSE_PRESS feature flag.
2838
2839 2014-08-11  Andy Estes  <aestes@apple.com>
2840
2841         [iOS] Get rid of iOS.xcconfig
2842         https://bugs.webkit.org/show_bug.cgi?id=135809
2843
2844         Reviewed by Joseph Pecoraro.
2845
2846         All iOS.xcconfig did was include AspenFamily.xcconfig, so there's no need for the indirection.
2847
2848         * Configurations/Base.xcconfig:
2849         * Configurations/iOS.xcconfig: Removed.
2850
2851 2014-08-10  Timothy Hatcher  <timothy@apple.com>
2852
2853         Web Inspector: new glyphs are visible on OS X 10.9 builds
2854         https://bugs.webkit.org/show_bug.cgi?id=135743
2855
2856         Reviewed by Joseph Pecoraro.
2857
2858         * WebCoreSupport/WebInspectorClient.mm:
2859         (-[WebInspectorWindowController window]): Use 10100 instead of 1090 for the version.
2860
2861 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
2862
2863         Get rid of SCRIPTED_SPEECH
2864         https://bugs.webkit.org/show_bug.cgi?id=135729
2865
2866         Reviewed by Brent Fulgham.
2867
2868         * Configurations/FeatureDefines.xcconfig:
2869
2870 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
2871
2872         Get rid of INPUT_SPEECH
2873         https://bugs.webkit.org/show_bug.cgi?id=135672
2874
2875         Reviewed by Andreas Kling.
2876
2877         * Configurations/FeatureDefines.xcconfig:
2878
2879 2014-08-07  Timothy Hatcher  <timothy@apple.com>
2880
2881         Web Inspector: Update glyphs to be more like Xcode 6
2882         https://bugs.webkit.org/show_bug.cgi?id=135705
2883
2884         Reviewed by Joseph Pecoraro.
2885
2886         * Resources/Dock.pdf: Added.
2887         * Resources/DockLegacy.pdf: Copied from Source/WebKit/mac/Resources/Dock.pdf.
2888         * WebCoreSupport/WebInspectorClient.mm:
2889         (-[WebInspectorWindowController window]): Use new images.
2890
2891 2014-08-06  Dean Jackson  <dino@apple.com>
2892
2893         ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED is not used anywhere. Remove it.
2894         https://bugs.webkit.org/show_bug.cgi?id=135675
2895
2896         Reviewed by Sam Weinig.
2897
2898         * Configurations/FeatureDefines.xcconfig:
2899
2900 2014-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2901
2902         Implement parsing for CSS scroll snap points
2903         https://bugs.webkit.org/show_bug.cgi?id=134301
2904
2905         Reviewed by Dean Jackson.
2906
2907         * Configurations/FeatureDefines.xcconfig: Added ENABLE_CSS_SCROLL_SNAP
2908
2909 2014-08-06  Alexey Proskuryakov  <ap@apple.com>
2910
2911         REGRESSION (WebKit2): iOS Safari default encoding doesn't follow system language
2912         https://bugs.webkit.org/show_bug.cgi?id=135667
2913         <rdar://problem/17862892>
2914
2915         Reviewed by Anders Carlsson.
2916
2917         * WebView/WebPreferences.mm: (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]):
2918         Moved implementation to WebCore, so that it can be shared with WebKit2.
2919
2920         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
2921         We now use WKGetWebDefaultCFStringEncoding in WebCore, so it needs to be initialized.
2922
2923 2014-08-05  Peyton Randolph  <prandolph@apple.com>
2924
2925         Rename MAC_LONG_PRESS feature flag to LONG_MOUSE_PRESS.
2926         https://bugs.webkit.org/show_bug.cgi?id=135276
2927
2928         Reviewed by Beth Dakin.
2929
2930         * Configurations/FeatureDefines.xcconfig:
2931
2932 2014-08-04  Benjamin Poulain  <benjamin@webkit.org>
2933
2934         Add a flag for the CSS Selectors level 4 implementation
2935         https://bugs.webkit.org/show_bug.cgi?id=135535
2936
2937         Reviewed by Andreas Kling.
2938
2939         * Configurations/FeatureDefines.xcconfig:
2940
2941 2014-08-04  Benjamin Poulain  <bpoulain@apple.com>
2942
2943         Check for null frame when processing geolocation authorization request
2944         https://bugs.webkit.org/show_bug.cgi?id=135577
2945         <rdar://problem/17896295>
2946
2947         Reviewed by Geoffrey Garen.
2948
2949         * WebCoreSupport/WebGeolocationClient.mm:
2950         (WebGeolocationClient::requestPermission):
2951
2952 2014-08-02  Jeremy Jones  <jeremyj@apple.com>
2953
2954         Support both window and view based video fullscreen.
2955         https://bugs.webkit.org/show_bug.cgi?id=135525
2956
2957         Reviewed by Simon Fraser.
2958
2959         Parenting in the view instead of the window gives the fullscreen implementation more latitude 
2960         in how it implements the animation.
2961
2962         * WebView/WebView.mm:
2963         (-[WebView _enterFullscreenForNode:]): Use view instead of window.
2964
2965 2014-08-01  Dan Bernstein  <mitz@apple.com>
2966
2967         <rdar://problem/17891752> [iOS] WebKit links against libraries it doesn’t use
2968         https://bugs.webkit.org/show_bug.cgi?id=135536
2969
2970         Reviewed by Tim Horton.
2971
2972         * Configurations/WebKitLegacy.xcconfig: Removed -framework MobileAsset from
2973         OTHER_LDFLAGS_iphoneos.
2974
2975 2014-07-30  Andy Estes  <aestes@apple.com>
2976
2977         USE(CONTENT_FILTERING) should be ENABLE(CONTENT_FILTERING)
2978         https://bugs.webkit.org/show_bug.cgi?id=135439
2979
2980         Reviewed by Tim Horton.
2981
2982         We now support two different platform content filters, and will soon support a mock content filter (as part of
2983         webkit.org/b/128858). This makes content filtering a feature of WebKit, not just an adoption of a third-party
2984         library. ENABLE() is the correct macro to use for such a feature.
2985
2986         * Configurations/FeatureDefines.xcconfig:
2987
2988 2014-07-30  Andreas Kling  <akling@apple.com>
2989
2990         Static hash tables no longer need to be coupled with a VM.
2991         <https://webkit.org/b/135421>
2992
2993         Reviewed by Geoffrey Garen.
2994
2995         * Plugins/Hosted/ProxyInstance.mm:
2996         * Plugins/Hosted/ProxyRuntimeObject.mm:
2997
2998 2014-07-30  Dan Bernstein  <mitz@apple.com>
2999
3000         Updated for changes to the WebCore::Credential API.
3001         Work towards fixing https://bugs.webkit.org/show_bug.cgi?id=135327
3002
3003         Reviewed by Alexey Proskuryakov.
3004
3005         * Misc/WebDownload.mm:
3006         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): Use new nsCredential
3007         getter.
3008         * Plugins/WebBaseNetscapePluginView.mm:
3009         (WebKit::getAuthenticationInfo): Ditto.
3010
3011 2014-07-27  Pratik Solanki  <psolanki@apple.com>
3012
3013         Remove unused preference keys
3014         https://bugs.webkit.org/show_bug.cgi?id=135280
3015
3016         Reviewed by Darin Adler.
3017
3018         * WebView/WebPreferenceKeysPrivate.h:
3019         * WebView/WebPreferences.mm:
3020         (+[WebPreferences initialize]):
3021         (-[WebPreferences _setPageCacheSize:]): Deleted.
3022         (-[WebPreferences _pageCacheSize]): Deleted.
3023         (-[WebPreferences _setObjectCacheSize:]): Deleted.
3024         (-[WebPreferences _objectCacheSize]): Deleted.
3025         * WebView/WebPreferencesPrivate.h:
3026
3027 2014-07-27  Filip Pizlo  <fpizlo@apple.com>
3028
3029         Merge r170090, r170092, r170129, r170141, r170161, r170215, r170275, r170375, r170376, r170382, r170383, r170399, r170436, r170489, r170490, r170556 from ftlopt.
3030
3031     2014-07-25  Mark Lam  <mark.lam@apple.com>
3032     
3033             [ftlopt] Renamed DebuggerActivation to DebuggerScope.
3034             <https://webkit.org/b/134273>
3035     
3036             Reviewed by Michael Saboff.
3037     
3038             * WebView/WebScriptDebugDelegate.mm:
3039             - Removed unneeded #include.
3040     
3041 2014-07-26  Filip Pizlo  <fpizlo@apple.com>
3042
3043         Unreviewed, roll out r171641-r171644. It broke some tests; will investigate and
3044         reland later.
3045
3046         * WebView/WebScriptDebugDelegate.mm:
3047
3048 2014-07-25  Filip Pizlo  <fpizlo@apple.com>
3049
3050         Merge r170090, r170092, r170129, r170141, r170161, r170215, r170275, r170375, r170376, r170382, r170383, r170399, r170436, r170489, r170490, r170556 from ftlopt.
3051
3052     2014-07-25  Mark Lam  <mark.lam@apple.com>
3053     
3054             [ftlopt] Renamed DebuggerActivation to DebuggerScope.
3055             <https://webkit.org/b/134273>
3056     
3057             Reviewed by Michael Saboff.
3058     
3059             * WebView/WebScriptDebugDelegate.mm:
3060             - Removed unneeded #include.
3061     
3062 2014-07-25  Jeremy Jones  <jeremyj@apple.com>
3063
3064         Parent fullscreen from window instead of view
3065         https://bugs.webkit.org/show_bug.cgi?id=135310
3066
3067         Reviewed by Jer Noble.
3068
3069         Parenting in the view causes an incorrect animation to fullscreen, and can cause 
3070         fullscreen to only expand to the size of the view instead of the whole window.
3071
3072         * WebView/WebView.mm:
3073         (-[WebView _enterFullscreenForNode:]): Pass window instead of view.
3074
3075 2014-07-24  Pratik Solanki  <psolanki@apple.com>
3076
3077         [iOS] Remove prefs to tweak cache values
3078         https://bugs.webkit.org/show_bug.cgi?id=135274
3079         <rdar://problem/17784826>
3080
3081         Reviewed by Alexey Proskuryakov.
3082
3083         Remove iOS specific code that used to look up user defaults to see if any cache values were
3084         overridden. This was added for testing, is not used any more and is actually harmful now. It
3085         can cause unnecessary memory churn when under memory pressure since we call [WebView _setCacheModel]
3086         as a means to clear out memory cache.
3087
3088         * WebView/WebPreferenceKeysPrivate.h:
3089         * WebView/WebPreferences.mm:
3090         (+[WebPreferences initialize]):
3091         (-[WebPreferences _setNSURLMemoryCacheSize:]): Deleted.
3092         (-[WebPreferences _NSURLMemoryCacheSize]): Deleted.
3093         (-[WebPreferences _setNSURLDiskCacheSize:]): Deleted.
3094         (-[WebPreferences _NSURLDiskCacheSize]): Deleted.
3095         * WebView/WebPreferencesPrivate.h:
3096         * WebView/WebView.mm:
3097         (+[WebView _setCacheModel:]):
3098
3099 2014-07-24  Peyton Randolph  <prandolph@apple.com>
3100
3101         Rename feature flag for long-press gesture on Mac.                                                                   
3102         https://bugs.webkit.org/show_bug.cgi?id=135259                                                                 
3103
3104         Reviewed by Beth Dakin.
3105
3106         * Configurations/FeatureDefines.xcconfig:
3107         Rename LINK_LONG_PRESS to MAC_LONG_PRESS.
3108
3109 2014-07-24  Dan Bernstein  <mitz@apple.com>
3110
3111         WebKit part of <rdar://problem/17766348> [Cocoa] WebCore::ProtectionSpace doesn’t preserve all NSURLProtectionSpace properties, such as the distinguishedNames array
3112         https://bugs.webkit.org/show_bug.cgi?id=135229
3113
3114         Reviewed by Alexey Proskuryakov.
3115
3116         * Misc/WebDownload.mm:
3117         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): Chanegd to use the
3118         ProtectionSpace constructor that takes an NSURLProtectionSpace.
3119
3120         * Plugins/WebBaseNetscapePluginView.mm:
3121         (WebKit::getAuthenticationInfo): Ditto.
3122
3123         * WebCoreSupport/WebFrameLoaderClient.mm:
3124         (WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace): Changed to use
3125         ProtectionSpace::nsSpace.
3126
3127 2014-07-23  Bem Jones-Bey  <bjonesbe@adobe.com>
3128
3129         Remove CSS_EXCLUSIONS compile flag and leftover code
3130         https://bugs.webkit.org/show_bug.cgi?id=135175
3131
3132         Reviewed by Zoltan Horvath.
3133
3134         At this point, the CSS_EXCLUSIONS flag guards nothing but some useless
3135         stubs. This removes the flag and the useless code.
3136
3137         * Configurations/FeatureDefines.xcconfig:
3138
3139 2014-07-22  Enrica Casucci  <enrica@apple.com>
3140
3141         REGRESSION (WebKit2): Selection inside accelerated overflow:scroll doesn't track scrolling.
3142         https://bugs.webkit.org/show_bug.cgi?id=135180
3143         <rdar://problem/16721055>
3144
3145         Reviewed by Simon Fraser.
3146
3147         * WebCoreSupport/WebEditorClient.h:
3148
3149 2014-07-22  Jeremy Jones  <jeremyj@apple.com>
3150
3151         Don't create new UIWindow for video fullscreen.
3152         https://bugs.webkit.org/show_bug.cgi?id=135038
3153
3154         Reviewed by Darin Adler.
3155
3156         Provide UIView to WebVideoFullscreenController
3157
3158         * WebView/WebView.mm:
3159         (-[WebView _enterFullscreenForNode:]): pass UIView instead of nil
3160
3161 2014-07-21  Pratik Solanki  <psolanki@apple.com>
3162
3163         Unreviewed iOS build fix after r171321.
3164
3165         * WebView/WebView.mm:
3166         (-[WebView _preferencesChanged:]):
3167
3168 2014-07-21  Beth Dakin  <bdakin@apple.com>
3169
3170         WK1 should always setAcceleratedCompositingForFixedPositionEnabled(true) on 
3171         Yosemite
3172         https://bugs.webkit.org/show_bug.cgi?id=135135
3173
3174         Reviewed by Darin Adler.
3175
3176         Get rid of the ChromeClient function, and enable the Setting instead.
3177         * WebCoreSupport/WebChromeClient.h:
3178         * WebCoreSupport/WebChromeClient.mm:
3179         (WebChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition): Deleted.
3180         * WebView/WebView.mm:
3181         (-[WebView _preferencesChanged:]):
3182
3183 2014-07-21  Beth Dakin  <bdakin@apple.com>
3184
3185         Build fix.
3186
3187         * WebCoreSupport/WebChromeClient.mm:
3188         (WebChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition):
3189
3190 2014-07-21  Beth Dakin  <bdakin@apple.com>
3191
3192         Put position:fixed elements into layers when a WK1 view is layer-backed
3193         https://bugs.webkit.org/show_bug.cgi?id=135075
3194
3195         Reviewed by Darin Adler.
3196
3197         Returns true when the WebHTMLView has a layer.
3198
3199         * WebCoreSupport/WebChromeClient.h:
3200         * WebCoreSupport/WebChromeClient.mm:
3201         (WebChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition):
3202
3203 2014-07-18  Andy Estes  <aestes@apple.com>
3204
3205         [iOS] Tapping "Allow Website" on a restricted page does not bring up the keypad
3206         https://bugs.webkit.org/show_bug.cgi?id=135072
3207         <rdar://problem/17528188>
3208
3209         Reviewed by David Kilzer.
3210
3211         * WebCoreSupport/WebFrameLoaderClient.h: Override contentFilterDidBlockLoad().
3212         * WebCoreSupport/WebFrameLoaderClient.mm:
3213         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): Reset contentFilterForBlockedLoad to nullptr.
3214         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Check if this is navigation represents an
3215         unblock request and ignore if so.
3216         * WebView/WebFrame.mm:
3217         (-[WebFrame _contentFilterDidHandleNavigationAction:]): Called ContentFilter::handleUnblockRequestAndDispatchIfSuccessful().
3218         If the unblock is successful, reload the main frame.
3219         * WebView/WebFrameInternal.h:
3220
3221 2014-07-17  David Kilzer  <ddkilzer@apple.com>
3222
3223         SECTORDER_FLAGS should be defined in target's xcconfig file, not Base.xcconfig
3224         <http://webkit.org/b/135006>
3225
3226         Reviewed by Darin Adler.
3227
3228         * Configurations/Base.xcconfig: Move SECTORDER_FLAGS to
3229         WebKitLegacy.xcconfig.
3230         * Configurations/DebugRelease.xcconfig: Remove empty
3231         SECTORDER_FLAGS definition.
3232         * Configurations/WebKit.xcconfig: Removed.  Unused.
3233         * Configurations/WebKitLegacy.xcconfig: Use $(CONFIGURATION) so
3234         SECTORDER_FLAGS is only set on Production builds.
3235
3236 2014-07-17  Timothy Hatcher  <timothy@apple.com>
3237
3238         Make console.profile record to the Timeline.
3239
3240         https://bugs.webkit.org/show_bug.cgi?id=134643
3241
3242         Reviewed by Joseph Pecoraro.
3243
3244         * WebInspector/WebInspector.mm:
3245         (-[WebInspector isProfilingJavaScript]):
3246         (-[WebInspector toggleProfilingJavaScript:]):
3247         (-[WebInspector startProfilingJavaScript:]):
3248         (-[WebInspector stopProfilingJavaScript:]):
3249         (-[WebInspector isJavaScriptProfilingEnabled]):
3250         (-[WebInspector setJavaScriptProfilingEnabled:]):
3251
3252 2014-07-16  David Kilzer  <ddkilzer@apple.com>
3253
3254         [iOS] Update order file paths for WebKit and WebKit2
3255         <http://webkit.org/b/134993>
3256         <rdar://problem/17557776>
3257
3258         Reviewed by Darin Adler.
3259
3260         * Configurations/Base.xcconfig: Rename WebKit.order to
3261         WebKitLegacy.order.
3262
3263 2014-07-16  Brady Eidson  <beidson@apple.com>
3264
3265         Add WebSecurityOrigin "webSecurityOriginFromDatabaseIdentifier" SPI and change _websiteDataURLForContainerWithURL: SPI
3266         <rdar://problem/17454712> and https://bugs.webkit.org/show_bug.cgi?id=134984
3267
3268         Reviewed by Dan Bernstein.
3269
3270         * WebCoreSupport/WebSecurityOrigin.mm:
3271         (+[WebSecurityOrigin webSecurityOriginFromDatabaseIdentifier:]): Added.
3272         (-[WebSecurityOrigin initWithURL:]): Update using RefPtr API to avoid a ref().
3273
3274 2014-07-15  Myles C. Maxfield  <mmaxfield@apple.com>
3275
3276         [OSX] [WK1] Crash when exiting fullscreen
3277         https://bugs.webkit.org/show_bug.cgi?id=134943
3278
3279         Reviewed by Dean Jackson.
3280
3281         AppKit doesn't remove a view from the Key View Loop when removing it from its superview.
3282
3283         This codepath is already "tested" in fullscreen/full-screen-cancel.html, but because of our
3284         testing infrastructure, the broken codepath doesn't actually get hit in DRT. Therefore,
3285         there is no test.
3286
3287         * WebView/WebFullScreenController.mm:
3288         (-[WebFullScreenController enterFullScreen:]):
3289
3290         * WebCoreSupport/WebSecurityOriginPrivate.h:
3291
3292 2014-07-14  Bear Travis  <betravis@adobe.com>
3293
3294         [Feature Queries] Enable Feature Queries on Mac
3295         https://bugs.webkit.org/show_bug.cgi?id=134404
3296
3297         Reviewed by Antti Koivisto.
3298
3299         Enable Feature Queries on Mac and resume running the
3300         feature tests.
3301
3302         * Configurations/FeatureDefines.xcconfig: Turn on
3303         ENABLE_CSS3_CONDITIONAL_RULES.
3304
3305 2014-07-11  Zalan Bujtas  <zalan@apple.com>
3306
3307         Subpixel layout: return integral results for offset*, client*, scroll* by default.
3308         https://bugs.webkit.org/show_bug.cgi?id=134651
3309
3310         Reviewed by Simon Fraser.
3311
3312         Revert to returning integral values for Element.offset* client* scroll* by default.
3313         Fractional values break number of sites(tight design) and JS frameworks(fail to handle fractional values).
3314
3315         Since snapped dimension depends on both the original point and the width/height of the box,
3316         we need to call RenderBoxModelObject::pixelSnapped*() helpers, instead of round().
3317
3318         Covered by existing tests
3319
3320         * WebView/WebPreferences.mm:
3321         (+[WebPreferences initialize]):
3322
3323 2014-07-10  Joseph Pecoraro  <pecoraro@apple.com>
3324
3325         [Mac] NSWindow warning: adding an unknown subview opening detached Inspector
3326         https://bugs.webkit.org/show_bug.cgi?id=134813
3327
3328         Reviewed by Timothy Hatcher.
3329
3330         * WebCoreSupport/WebInspectorClient.mm:
3331         (-[WebInspectorWindowController window]):
3332         Use a selector that will avoid the warning message.
3333
3334 2014-07-09  Ryosuke Niwa  <rniwa@webkit.org>
3335
3336         REGRESSION(r167770): Cannot login in Evernote Safari extension
3337         https://bugs.webkit.org/show_bug.cgi?id=134776
3338
3339         Reviewed by Enrica Casucci.
3340
3341         Unfortunately, NSWindowDidBecomeKeyNotification does not notify us when a popover becomes key
3342         so we need to keep using the SPI (_windowChangedKeyState) I removed in r167770.
3343
3344         * WebView/WebView.mm:
3345         (-[WebView _windowChangedKeyState]):
3346
3347 2014-07-09  Enrica Casucci  <enrica@apple.com>
3348
3349         Implement Editor::fontAttributesForSelectionStart() or iOS.
3350         https://bugs.webkit.org/show_bug.cgi?id=134771
3351         <rdar://problem/16167838>
3352
3353         Reviewed by Ryosuke Niwa.
3354
3355         * WebView/WebViewPrivate.h:
3356
3357 2014-07-08  Tim Horton  <timothy_horton@apple.com>
3358
3359         [WK2] Expose a few drawing/compositing settings on WKPreferences(Private)
3360         https://bugs.webkit.org/show_bug.cgi?id=134645
3361
3362         Reviewed by Dan Bernstein.
3363
3364         * WebView/WebPreferences.mm:
3365         (-[WebPreferences setSubpixelCSSOMElementMetricsEnabled:]):
3366         Remove an extra unnecessary space.
3367
3368 2014-07-03  Daniel Bates  <dabates@apple.com>
3369
3370         Add WTF::move()
3371         https://bugs.webkit.org/show_bug.cgi?id=134500
3372
3373         Rubber-stamped by Anders Carlsson.
3374
3375         Substitute WTF::move() for std::move().
3376
3377         * History/WebHistoryItem.mm:
3378         (-[WebHistoryItem initFromDictionaryRepresentation:]):
3379         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3380         (WebKit::NetscapePluginInstanceProxy::setCurrentReply):
3381         * Plugins/WebNetscapePluginView.mm:
3382         (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
3383         * WebCoreSupport/WebFrameLoaderClient.mm:
3384         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3385         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3386         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3387         (WebFrameLoaderClient::dispatchWillSubmitForm):
3388         * WebCoreSupport/WebInspectorClient.mm:
3389         (WebInspectorClient::openInspectorFrontend):
3390         (WebInspectorFrontendClient::WebInspectorFrontendClient):
3391         * WebView/WebArchive.mm:
3392         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
3393
3394 2014-07-01  Mark Rowe  <mrowe@apple.com>
3395
3396         <https://webkit.org/b/134522> Remove duplication in code that prepares the user agent string on Mac and iOS
3397
3398         Reviewed by Simon Fraser.
3399
3400         * WebView/WebView.mm:
3401         (webKitBundleVersionString): Return the entire CFBundleVersion now that WebCore handles formatting it.
3402         (+[WebView _standardUserAgentWithApplicationName:]):
3403
3404 2014-07-02  Dan Bernstein  <mitz@apple.com>
3405
3406         Remove some code only needed for versions of Safari that are no longer supported
3407         https://bugs.webkit.org/show_bug.cgi?id=134537
3408
3409         Reviewed by Anders Carlsson.
3410
3411         * History/WebHistoryItem.mm:
3412         * Misc/WebKitVersionChecks.h:
3413         * WebCoreSupport/WebSecurityOrigin.mm:
3414         (-[WebSecurityOrigin domain]): Deleted.
3415         * WebInspector/WebInspector.mm:
3416         (-[WebInspector showTimeline:]): Deleted.
3417         (+[WebInspector webInspector]): Deleted.
3418         (-[WebInspector setWebFrame:]): Deleted.
3419         (-[WebInspector window]): Deleted.
3420         (-[WebInspector showWindow:]): Deleted.
3421         * WebView/WebFrame.mm:
3422         (-[WebFrame reload]):
3423         * WebView/WebPDFView.mm:
3424         (-[WebPDFView menuForEvent:]):
3425         (-[WebPDFView _anyPDFTagsFoundInMenu:]): Deleted.
3426         * WebView/WebView.mm:
3427         (-[WebView _initWithFrame:frameName:groupName:]):
3428         (-[WebView _preferencesChanged:]):
3429         (-[WebView initWithFrame:frameName:groupName:]):
3430         (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]): Deleted.
3431         (+[WebView _setAlwaysUseATSU:]): Deleted.
3432         (-[WebView _needsUnrestrictedGetMatchedCSSRules]): Deleted.
3433         * WebView/WebViewPrivate.h:
3434
3435 2014-07-01  Dan Bernstein  <mitz@apple.com>
3436
3437         Remove WebChromeClient code that was only needed for Safari versions earlier than 3.1
3438         https://bugs.webkit.org/show_bug.cgi?id=134531
3439
3440         Reviewed by Daniel Bates.
3441
3442         * WebCoreSupport/WebChromeClient.mm:
3443         (WebChromeClient::exceededDatabaseQuota):
3444
3445 2014-06-29  Yoav Weiss  <yoav@yoav.ws>
3446
3447         Add support for HTMLImageElement's sizes attribute
3448         https://bugs.webkit.org/show_bug.cgi?id=133620
3449
3450         Reviewed by Dean Jackson.
3451
3452         Added an ENABLE_PICTURE_SIZES compile flag.
3453
3454         * Configurations/FeatureDefines.xcconfig:
3455
3456 2014-06-27  Sam Weinig  <sam@webkit.org>
3457
3458         InfoClick (from Nisus Software) dies on viewing found items
3459         <rdar://problem/17395601>
3460         https://bugs.webkit.org/show_bug.cgi?id=134410
3461
3462         Reviewed by Andy Estes.
3463
3464         InfoClick was calling -[WebPreferences setPrivateBrowsingEnabled:] before
3465         setting up a WebView (or anything else that would have set up WebKitSystemInterface),
3466         which now requires a set up WebKitSystemInterface. We can fix this by initializing
3467         it from +[WebPreferences initialize].
3468
3469         * WebView/WebPreferences.mm:
3470         (+[WebPreferences initialize]):
3471         Add call to InitWebCoreSystemInterface().
3472
3473         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
3474         Remove now unnecessary call to InitWebCoreSystemInterface().
3475
3476 2014-06-27  Peyton Randolph  <prandolph@apple.com>
3477
3478         Add feature flag for link long-press gesture.
3479         https://bugs.webkit.org/show_bug.cgi?id=134262
3480
3481         Reviewed by Enrica Casucci.
3482
3483         * Configurations/FeatureDefines.xcconfig:
3484         Add ENABLE_LINK_LONG_PRESS.
3485
3486 2014-06-26  Brady Eidson  <beidson@apple.com>
3487
3488         Remove use of PlatformStrategies for Gamepad API.
3489         https://bugs.webkit.org/show_bug.cgi?id=134348
3490
3491         Reviewed by Dean Jackson.
3492
3493         Remove all the GamepadStrategy gunk:
3494         * WebCoreSupport/WebHIDGamepadController.mm: Removed.
3495         * WebCoreSupport/WebPlatformStrategies.h:
3496         * WebCoreSupport/WebPlatformStrategies.mm:
3497         (WebPlatformStrategies::createGamepadStrategy): Deleted.
3498         (WebPlatformStrategies::startMonitoringGamepads): Deleted.
3499         (WebPlatformStrategies::stopMonitoringGamepads): Deleted.
3500         (WebPlatformStrategies::platformGamepads): Deleted.
3501
3502         Instead, install the HIDGamepadProvider as the shared GamepadProvider:
3503         * WebView/WebView.mm:
3504         (WebKitInitializeGamepadProviderIfNecessary):
3505         (-[WebView _commonInitializationWithFrameName:groupName:]):
3506
3507 2014-06-26  Joseph Pecoraro  <pecoraro@apple.com>
3508
3509         [iOS] Remove User Default for iOS TextField Debugging
3510         https://bugs.webkit.org/show_bug.cgi?id=134356
3511
3512         Reviewed by Timothy Hatcher.
3513
3514         * WebView/WebPreferenceKeysPrivate.h:
3515         * WebView/WebView.mm:
3516         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3517
3518 2014-06-25  Brady Eidson  <beidson@apple.com>
3519
3520         Add HID-based gamepad implementation for Mac
3521         https://bugs.webkit.org/show_bug.cgi?id=134324
3522
3523         Reviewed by Dean Jackson.
3524
3525         Add a class that acts as an intermediary between the GamepadStrategyClient
3526         and the HIDGamepadListener:
3527         * WebCoreSupport/WebHIDGamepadController.h:
3528         * WebCoreSupport/WebHIDGamepadController.mm:
3529         (WebHIDGamepadController::shared):
3530         (WebHIDGamepadController::WebHIDGamepadController):
3531         (WebHIDGamepadController::gamepadConnected):
3532         (WebHIDGamepadController::gamepadDisconnected):
3533         (WebHIDGamepadController::registerGamepadStrategyClient):
3534         (WebHIDGamepadController::unregisterGamepadStrategyClient):
3535
3536         Implement the strategies by using the HIDGamepadListener:
3537         * WebCoreSupport/WebPlatformStrategies.mm:
3538         (WebPlatformStrategies::startMonitoringGamepads):
3539         (WebPlatformStrategies::stopMonitoringGamepads):
3540         (WebPlatformStrategies::platformGamepads):
3541
3542 2014-06-25  Brady Eidson  <beidson@apple.com>
3543
3544         Add new platform gamepad abstractions
3545         https://bugs.webkit.org/show_bug.cgi?id=134325
3546
3547         Reviewed by Dean Jackson.
3548
3549         * WebCoreSupport/WebPlatformStrategies.h:
3550         * WebCoreSupport/WebPlatformStrategies.mm:
3551         (WebPlatformStrategies::createGamepadStrategy):
3552         (WebPlatformStrategies::startMonitoringGamepads):
3553         (WebPlatformStrategies::stopMonitoringGamepads):
3554         (WebPlatformStrategies::platformGamepads):
3555
3556 2014-06-25  Gavin Barraclough  <baraclough@apple.com>
3557
3558         Should _updateVisibilityState on view hide/unhide.
3559         https://bugs.webkit.org/show_bug.cgi?id=134314
3560         rdar://17171803
3561
3562         Reviewed by Sam Weinig.
3563
3564         * WebView/WebView.mm:
3565         (-[WebView viewDidHide]):
3566         (-[WebView viewDidUnhide]):