8c9196093f8afc05246d8e3d7d8ca9ca669cb0ee
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2014-12-20  Eric Carlson  <eric.carlson@apple.com>
2
3         [iOS] add optimized fullscreen API
4         https://bugs.webkit.org/show_bug.cgi?id=139833
5         <rdar://problem/18844486>
6
7         Reviewed by Simon Fraser.
8
9         * Configurations/FeatureDefines.xcconfig:  Add ENABLE_VIDEO_PRESENTATION_MODE.
10
11 2014-12-20  David Kilzer  <ddkilzer@apple.com>
12
13         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
14         <http://webkit.org/b/139463>
15
16         Reviewed by Mark Rowe.
17
18         * Configurations/Base.xcconfig:
19         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
20           on OS X.
21         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
22         * Configurations/DebugRelease.xcconfig:
23         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
24         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
25         * Configurations/Version.xcconfig:
26         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
27         * Configurations/WebKitLegacy.xcconfig:
28         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
29           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
30           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
31           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
32           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
33           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
34           WEBCORE_PRIVATE_HEADERS_DIR_Production and
35           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
36           based on SDK.
37         - Fix PRODUCTION_ROOT to actually be set properly.
38         - Simplify EXPORTED_SYMBOLS_FILE_i386.
39
40         * migrate-headers.sh:
41         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
42         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
43           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
44           WebKitLegacy.xcconfig.
45
46 2014-12-19  Simon Fraser  <simon.fraser@apple.com>
47
48         Fix pink background on CoreAnimation plug-ins in WebKit1
49         https://bugs.webkit.org/show_bug.cgi?id=139845
50         rdar://problem/19313075
51
52         Reviewed by Tim Horton.
53         
54         r154078 left in some debugging code that set a pink background on plug-in hosting
55         layers. Remove it.
56
57         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
58         (-[WebHostedNetscapePluginView createPluginLayer]):
59
60 2014-12-19  Andreas Kling  <akling@apple.com>
61
62         Ref-ify TextIterator API.
63         <https://webkit.org/b/139823>
64
65         Reviewed by Antti Koivisto.
66
67         * WebView/WebTextIterator.mm:
68         (-[WebTextIterator currentRange]):
69
70 2014-12-19  Joseph Pecoraro  <pecoraro@apple.com>
71
72         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
73         https://bugs.webkit.org/show_bug.cgi?id=139797
74
75         Reviewed by Mark Lam.
76
77         * WebView/WebScriptDebugger.h:
78         * WebView/WebScriptDebugger.mm:
79         (WebScriptDebugger::handlePause):
80         Standardize on passing JSGlobalObject parameter first.
81
82 2014-12-19  Commit Queue  <commit-queue@webkit.org>
83
84         Unreviewed, rolling out r177574.
85         https://bugs.webkit.org/show_bug.cgi?id=139821
86
87         "Broke Production builds by installing
88         libWebCoreTestSupport.dylib in the wrong directory" (Requested
89         by ddkilzer on #webkit).
90
91         Reverted changeset:
92
93         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
94         WebInspectorUI, WebKit, WebKit2"
95         https://bugs.webkit.org/show_bug.cgi?id=139463
96         http://trac.webkit.org/changeset/177574
97
98 2014-12-19  David Kilzer  <ddkilzer@apple.com>
99
100         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
101         <http://webkit.org/b/139463>
102
103         Reviewed by Mark Rowe.
104
105         * Configurations/Base.xcconfig:
106         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
107           on OS X.
108         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
109         * Configurations/DebugRelease.xcconfig:
110         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
111         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
112         * Configurations/Version.xcconfig:
113         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
114         * Configurations/WebKitLegacy.xcconfig:
115         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
116           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
117           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
118           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
119           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
120           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
121           WEBCORE_PRIVATE_HEADERS_DIR_Production and
122           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
123           based on SDK.
124         - Fix PRODUCTION_ROOT to actually be set properly.
125         - Simplify EXPORTED_SYMBOLS_FILE_i386.
126
127         * migrate-headers.sh:
128         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
129         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
130           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
131           WebKitLegacy.xcconfig.
132
133 2014-12-18  Andreas Kling  <akling@apple.com>
134
135         Ref-ify various Document-related things.
136         <https://webkit.org/b/139796>
137
138         Reviewed by Anders Carlsson.
139
140         * WebView/WebFrame.mm:
141         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
142
143 2014-12-18  Beth Dakin  <bdakin@apple.com>
144
145         Need to re-enable action menus
146         https://bugs.webkit.org/show_bug.cgi?id=139795
147         -and corresponding-
148         rdar://problem/19299367
149
150         Reviewed by Tim Horton.
151
152         Re-enable the menus by un-commenting the code to create the menu and controller.
153         * WebView/WebView.mm:
154         (-[WebView _commonInitializationWithFrameName:groupName:]):
155
156 2014-12-16  Sam Weinig  <sam@webkit.org>
157
158         Unify the Mac and iOS implementations of FontPlatformData a bit
159         https://bugs.webkit.org/show_bug.cgi?id=139721
160
161         Reviewed by Anders Carlsson.
162
163         * WebView/WebHTMLView.mm:
164         (fontNameForDescription):
165         Update for new function name.
166
167 2014-12-18  Antti Koivisto  <antti@apple.com>
168
169         Remove alwaysUseBaselineOfPrimaryFont setting
170         https://bugs.webkit.org/show_bug.cgi?id=139770
171
172         Reviewed by Anders Carlsson.
173
174         * WebView/WebPreferenceKeysPrivate.h:
175         * WebView/WebPreferences.mm:
176         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
177         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
178         * WebView/WebPreferencesPrivate.h:
179         * WebView/WebView.mm:
180         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
181         (-[WebView _preferencesChanged:]):
182
183 2014-12-17  Andreas Kling  <akling@apple.com>
184
185         Ref-ify Range::create().
186         <https://webkit.org/b/139755>
187
188         Reviewed by Anders Carlsson.
189
190         * WebView/WebHTMLRepresentation.mm:
191         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
192         * WebView/WebHTMLView.mm:
193         (-[WebHTMLView attributedString]):
194
195 2014-12-17  Anders Carlsson  <andersca@apple.com>
196
197         Unify -[WebResource description]
198         https://bugs.webkit.org/show_bug.cgi?id=139762
199
200         Reviewed by Dan Bernstein.
201
202         * WebView/WebResource.mm:
203         (-[WebResource description]):
204
205 2014-12-17  Anders Carlsson  <andersca@apple.com>
206
207         Get rid of an ugly #define hack in WebFrameLoaderClient
208         https://bugs.webkit.org/show_bug.cgi?id=139761
209
210         Reviewed by Dan Bernstein.
211
212         Also replace @private with @package in all public headers, for consistency.
213
214         * History/WebBackForwardList.h:
215         * History/WebHistory.h:
216         * Misc/WebDownload.h:
217         * WebCoreSupport/WebFrameLoaderClient.mm:
218         * WebView/WebArchive.h:
219         * WebView/WebDataSource.h:
220         * WebView/WebFrame.h:
221         * WebView/WebFrameView.h:
222         * WebView/WebPreferences.h:
223         * WebView/WebResource.h:
224
225 2014-12-17  Dan Bernstein  <mitz@apple.com>
226
227         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
228         https://bugs.webkit.org/show_bug.cgi?id=139760
229
230         Reviewed by Anders Carlsson.
231
232         * Configurations/WebKitLegacy.xcconfig:
233
234 2014-12-17  Andreas Kling  <akling@apple.com>
235
236         Purge PassRefPtr from Frame.
237         <https://webkit.org/b/139731>
238
239         Reviewed by Anders Carlsson.
240
241         * WebCoreSupport/WebFrameLoaderClient.mm:
242         (WebFrameLoaderClient::transitionToCommittedForNewPage):
243         * WebView/WebFrame.mm:
244         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
245         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
246         * WebView/WebFrameInternal.h:
247
248 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
249
250         Implement and adopt two new TextIndicator presentation animations
251         https://bugs.webkit.org/show_bug.cgi?id=139715
252         <rdar://problem/19237945>
253
254         Reviewed by Anders Carlsson.
255
256         * WebView/WebActionMenuController.mm:
257         (-[WebActionMenuController _showTextIndicator]):
258         * WebView/WebHTMLView.mm:
259         (-[WebHTMLView quickLookWithEvent:]):
260         Remove the completionHandler from text indicator presentation.
261
262         * WebView/WebImmediateActionController.mm:
263         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
264         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
265         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
266         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
267         (-[WebImmediateActionController _menuItemForDataDetectedText]):
268         (-[WebImmediateActionController _animationControllerForText]):
269         (-[WebImmediateActionController _showTextIndicator]):
270         Forward immediate action gesture recognizer animation progress
271         to TextIndicator. Force us to keep the selection when immediate
272         action popovers steal first responder status from the WebView.
273         If the Lookup range is equal to the selection range, use a Crossfade
274         animation; otherwise, use a FadeIn animation.
275
276         * WebView/WebView.mm:
277         (-[WebView _setMaintainsInactiveSelection:]):
278         (-[WebView maintainsInactiveSelection]):
279         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
280         (-[WebView _setTextIndicator:fadeOut:]):
281         (-[WebView _clearTextIndicator]):
282         (-[WebView _setTextIndicatorAnimationProgress:]):
283         (-[WebView _showDictionaryLookupPopup:]):
284         (-[WebView _dictionaryLookupPopoverWillClose:]):
285         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
286         Remove the completionHandler from text indicator presentation.
287         Add a _setMaintainsInactiveSelection, which allows WebKit internals
288         to change the return value of -maintainsInactiveSelection, allowing
289         us to keep the selection alive when the WebView loses first responder status.
290
291         * WebView/WebViewData.h:
292         * WebView/WebViewInternal.h:
293
294 2014-12-16  Andreas Kling  <akling@apple.com>
295
296         Use Ref for SecurityOrigin.
297         <https://webkit.org/b/139710>
298
299         Reviewed by Anders Carlsson.
300
301         * Storage/WebStorageTrackerClient.mm:
302         (WebStorageTrackerClient::dispatchDidModifyOrigin):
303         * WebView/WebView.mm:
304         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
305         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
306
307 2014-12-16  Beth Dakin  <bdakin@apple.com>
308
309         Crash getting default animation controller for some text
310         https://bugs.webkit.org/show_bug.cgi?id=139712
311         -and corresponding-
312         rdar://problem/19271707
313
314         Reviewed by Tim Horton.
315
316         Must null-check the range.
317         * WebView/WebImmediateActionController.mm:
318         (-[WebImmediateActionController _animationControllerForText]):
319
320 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
321
322         Immediate action popovers can get stuck open
323         https://bugs.webkit.org/show_bug.cgi?id=139709
324         <rdar://problem/19270279>
325
326         Reviewed by Beth Dakin.
327
328         * WebView/WebImmediateActionController.mm:
329         (-[WebImmediateActionController _clearImmediateActionState]):
330         Don't clear the animation controller; it breaks things and was unnecessary.
331
332 2014-12-16  Tim Horton  <timothy_horton@apple.com>
333
334         Disable TextIndication for Lookup immediate actions
335         https://bugs.webkit.org/show_bug.cgi?id=139684
336
337         Reviewed by Anders Carlsson.
338
339         * WebView/WebView.mm:
340         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
341
342 2014-12-15  Beth Dakin  <bdakin@apple.com>
343
344         Build fix.
345
346         * WebView/WebImmediateActionController.mm:
347
348 2014-12-15  Beth Dakin  <bdakin@apple.com>
349
350         Speculative build fix.
351
352         * WebView/WebView.mm:
353         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
354         * WebView/WebViewInternal.h:
355
356 2014-12-15  Beth Dakin  <bdakin@apple.com>
357
358         Make lookup an immediate action instead of an action menu item
359         https://bugs.webkit.org/show_bug.cgi?id=139661
360         -and corresponding-
361         rdar://problem/19198414
362
363         Reviewed by Tim Horton.
364
365         Remove the lookup menu items and non-unused static function associated with 
366         lookup.
367         * WebView/WebActionMenuController.mm:
368         (-[WebActionMenuController _defaultMenuItemsForText]):
369         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
370         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
371         (-[WebActionMenuController _createActionMenuItemForTag:]):
372         (-[WebActionMenuController _lookupText:]): Deleted.
373         (performDictionaryLookupForSelection): Deleted.
374         (performDictionaryLookupForRange): Deleted.
375
376         Set the defaultAnimationController to the lookup-provided animation controller 
377         when appropriate.
378         * WebView/WebImmediateActionController.mm:
379         (-[WebImmediateActionController _defaultAnimationController]):
380         (dictionaryPopupInfoForRange):
381         (-[WebImmediateActionController _animationControllerForText]):
382
383         New type.
384         * WebView/WebUIDelegatePrivate.h:
385
386         New function to get the lookup animation controller.
387         * WebView/WebView.mm:
388         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
389         * WebView/WebViewInternal.h:
390
391 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
392
393         Implement Data Detectors immediate actions for Legacy WebKit
394         https://bugs.webkit.org/show_bug.cgi?id=139619
395         <rdar://problem/19198539>
396
397         Reviewed by Beth Dakin.
398
399         * WebView/WebImmediateActionController.mm:
400         (-[WebImmediateActionController _menuItemForDataDetectedText]):
401         Note that this action context is only for immediate actions.
402
403 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
404
405         Addressing post-review comments in r177035
406         https://bugs.webkit.org/show_bug.cgi?id=139557
407
408         Reviewed by Darin Adler.
409
410         * WebView/WebActionMenuController.mm:
411         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
412
413 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
414
415         Implement Data Detectors immediate actions for Legacy WebKit
416         https://bugs.webkit.org/show_bug.cgi?id=139619
417         <rdar://problem/19198539>
418
419         Reviewed by Eric Carlson.
420
421         * WebView/WebHTMLView.mm:
422         (-[WebHTMLView mouseDown:mouseDown:]):
423         Send mouseDown along to the WebImmediateActionController too.
424
425         * WebView/WebImmediateActionController.h:
426         * WebView/WebImmediateActionController.mm:
427         (-[WebImmediateActionController webViewClosed]):
428         (-[WebImmediateActionController webView:willHandleMouseDown:]):
429         (-[WebImmediateActionController _cancelImmediateAction]):
430         (-[WebImmediateActionController _clearImmediateActionState]):
431         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
432         (-[WebImmediateActionController _defaultAnimationController]):
433         (-[WebImmediateActionController _updateImmediateActionItem]):
434         (-[WebImmediateActionController _menuItemForDataDetectedText]):
435         (-[WebImmediateActionController _showTextIndicator]):
436         (-[WebImmediateActionController _hideTextIndicator]):
437         Copy most of the DataDetectors implementation into WebImmediateActionController.
438
439         * WebView/WebUIDelegatePrivate.h:
440         Add a new type.
441
442         * WebView/WebView.mm:
443         (-[WebView _commonInitializationWithFrameName:groupName:]):
444         Temporarily disable action menus.
445
446         (-[WebView _immediateActionController]):
447         * WebView/WebViewInternal.h:
448
449 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
450
451         Delete Notation because we don't use it
452         https://bugs.webkit.org/show_bug.cgi?id=139171
453
454         Reviewed by Kent Tamura.
455
456         * MigrateHeaders.make:
457
458 2014-12-14  Andreas Kling  <akling@apple.com>
459
460         Replace PassRef with Ref/Ref&& across the board.
461         <https://webkit.org/b/139587>
462
463         Reviewed by Darin Adler.
464
465         * WebCoreSupport/WebEditorClient.mm:
466         (WebEditorClient::shouldApplyStyle):
467         * WebCoreSupport/WebVisitedLinkStore.h:
468         * WebCoreSupport/WebVisitedLinkStore.mm:
469         (WebVisitedLinkStore::create):
470
471 2014-12-11  Dan Bernstein  <mitz@apple.com>
472
473         Fix a leak introduced in r177199.
474
475         Reviewed by Anders Carlsson.
476
477         * WebView/WebImmediateActionController.mm:
478         (-[WebImmediateActionController _updateImmediateActionItem]):
479
480 2014-12-11  Beth Dakin  <bdakin@apple.com>
481
482         WK1: Need new SPI for Webkit clients to override default immediate action
483         https://bugs.webkit.org/show_bug.cgi?id=139568
484         -and corresponding-
485         rdar://problem/19225448
486
487         Reviewed by Dan Bernstein.
488
489         Call SPI giving clients a chance to override the default behavior.
490         * WebView/WebImmediateActionController.mm:
491         (-[WebImmediateActionController _updateImmediateActionItem]):
492
493         New SPI.
494         * WebView/WebUIDelegatePrivate.h:
495
496 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
497
498         Move the preview popover to WebImmediateActionController
499         https://bugs.webkit.org/show_bug.cgi?id=139563
500         <rdar://problem/19208291>
501
502         Reviewed by Beth Dakin.
503
504         * WebView/WebActionMenuController.mm:
505         (-[WebActionMenuController _defaultMenuItemsForLink]):
506         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
507         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
508         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
509         * WebView/WebImmediateActionController.h:
510         * WebView/WebImmediateActionController.mm:
511         (-[WebImmediateActionController webViewClosed]):
512         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
513         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
514         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
515         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
516         (-[WebImmediateActionController _updateImmediateActionItem]):
517         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
518         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
519         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
520         Move page preview popover related code to WebImmediateActionController.
521
522         * WebView/WebUIDelegatePrivate.h:
523         Add a link preview type.
524
525         * WebView/WebView.mm:
526         (-[WebView _commonInitializationWithFrameName:groupName:]):
527         Pass the gesture recognizer to the WebImmediateActionController.
528
529 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
530
531         Fix the build.
532
533         * WebView/WebImmediateActionController.h:
534         * WebView/WebImmediateActionController.mm:
535
536 2014-12-11  Anders Carlsson  <andersca@apple.com>
537
538         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
539         https://bugs.webkit.org/show_bug.cgi?id=139547
540
541         Reviewed by Sam Weinig.
542
543         * WebView/WebView.mm:
544         (+[WebView _handleMemoryWarning]):
545
546 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
547
548         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
549         https://bugs.webkit.org/show_bug.cgi?id=139504
550         rdar://problem/19034674
551
552         Reviewed by Enrica Casucci.
553
554         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
555
556         * WebCoreSupport/WebEditorClient.h:
557         * WebCoreSupport/WebEditorClient.mm:
558         (WebEditorClient::discardedComposition):
559
560 2014-12-10  Anders Carlsson  <andersca@apple.com>
561
562         Get rid of the storage strategy
563         https://bugs.webkit.org/show_bug.cgi?id=139519
564
565         Reviewed by Antti Koivisto.
566
567         * WebCoreSupport/WebPlatformStrategies.h:
568         * WebCoreSupport/WebPlatformStrategies.mm:
569         (WebPlatformStrategies::createStorageStrategy): Deleted.
570
571 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
572
573         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
574         https://bugs.webkit.org/show_bug.cgi?id=139529
575         <rdar://problem/19213620>
576
577         Reviewed by Beth Dakin.
578
579         * WebView/WebActionMenuController.mm:
580         (-[WebActionMenuController _copySelection:]):
581         (-[WebActionMenuController _paste:]):
582         Use the copy: and paste: methods on WebView so that we traverse subviews
583         when trying to respond, otherwise these actions don't work in subframes.
584
585 2014-12-10  Beth Dakin  <bdakin@apple.com>
586
587         WK1: Add initial support for immediate actions
588         https://bugs.webkit.org/show_bug.cgi?id=139522
589
590         Reviewed by Dan Bernstein.
591
592         This basic implementation of the controller will use the delegate methods to 
593         perform and cache a HitTest when relevant. Future patches will patch 
594         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
595         immediate action that should be taken.
596         * WebView/WebImmediateActionController.h: Added.
597         * WebView/WebImmediateActionController.mm: Added.
598         (-[WebImmediateActionController webViewClosed]):
599         (-[WebImmediateActionController _clearImmediateActionState]):
600         (-[WebImmediateActionController performHitTestAtPoint:]):
601         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
602         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
603         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
604         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
605         (-[WebImmediateActionController _updateImmediateActionItem]):
606
607         New enum for immediate action types.
608         * WebView/WebUIDelegatePrivate.h:
609
610         Create an NSImmediateActionGestureRecognizer if possible and a controller.
611         * WebView/WebView.mm:
612         (-[WebView _commonInitializationWithFrameName:groupName:]):
613         (-[WebView _close]):
614         * WebView/WebViewData.h:
615         * WebView/WebViewData.mm:
616         (-[WebViewPrivate dealloc]):
617
618 2014-12-08  Anders Carlsson  <andersca@apple.com>
619
620         Use the new storage namespace provider in WebKit1
621         https://bugs.webkit.org/show_bug.cgi?id=139425
622
623         Reviewed by Tim Horton.
624
625         * WebView/WebView.mm:
626         (-[WebView _commonInitializationWithFrameName:groupName:]):
627         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
628         Set the storage namespace provider from the web page group.
629
630 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
631
632         Should have copy and paste items in all text menus
633         https://bugs.webkit.org/show_bug.cgi?id=139510
634         <rdar://problem/19198388>
635
636         Reviewed by Beth Dakin.
637
638         * WebView/WebActionMenuController.mm:
639         (-[WebActionMenuController _defaultMenuItemsForText]):
640         Add a disabled paste menu item into the read-only text menu.
641
642         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
643         Add a disabled copy menu item into the editable whitespace text menu.
644
645 2014-12-10  Anders Carlsson  <andersca@apple.com>
646
647         Add WebStorageNamespaceProvider::closeLocalStorage
648         https://bugs.webkit.org/show_bug.cgi?id=139502
649
650         Reviewed by Tim Horton.
651
652         * WebView/WebView.mm:
653         (+[WebView _applicationWillTerminate]):
654         Call WebStorageNamespaceProvider::closeLocalStorage.
655
656 2014-12-09  Commit Queue  <commit-queue@webkit.org>
657
658         Unreviewed, rolling out r177037.
659         https://bugs.webkit.org/show_bug.cgi?id=139464
660
661         broke ~50 API tests (Requested by thorton on #webkit).
662
663         Reverted changeset:
664
665         "Use the new storage namespace provider in WebKit1"
666         https://bugs.webkit.org/show_bug.cgi?id=139425
667         http://trac.webkit.org/changeset/177037
668
669 2014-12-08  Anders Carlsson  <andersca@apple.com>
670
671         Use the new storage namespace provider in WebKit1
672         https://bugs.webkit.org/show_bug.cgi?id=139425
673
674         Reviewed by Tim Horton.
675
676         * WebView/WebView.mm:
677         (-[WebView _commonInitializationWithFrameName:groupName:]):
678         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
679         Set the storage namespace provider from the web page group.
680
681 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
682
683         Delete Node::boundingBox()
684         https://bugs.webkit.org/show_bug.cgi?id=139333
685
686         Reviewed by Zalan Bujtas.
687
688         * WebView/WebActionMenuController.mm:
689         (elementBoundingBoxInWindowCoordinatesFromNode): Use
690         RenderObject::absoluteBoundingBoxRect().
691
692 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
693
694         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
695         https://bugs.webkit.org/show_bug.cgi?id=138843
696         rdar://problem/18793695
697
698         Reviewed by Dan Bernstein.
699
700         * Panels/WebAuthenticationPanel.m:
701         (-[WebAuthenticationPanel cancel:]):
702         (-[WebAuthenticationPanel logIn:]):
703         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
704         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
705         that only when using an old NSWindow API.
706
707 2014-12-08  Beth Dakin  <bdakin@apple.com>
708
709         Copy and Lookup menu items should be disabled when something is not copyable
710         https://bugs.webkit.org/show_bug.cgi?id=139423
711
712         Reviewed by Tim Horton.
713
714         Disable both lookup and copy when a HitTestResult does not allow copy.
715         * WebView/WebActionMenuController.mm:
716
717         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
718         disable state otherwise.
719         * WebView/WebView.mm:
720         (-[WebView _commonInitializationWithFrameName:groupName:]):
721
722 2014-12-08  Anders Carlsson  <andersca@apple.com>
723
724         Adding user content to a group should force that group to be created
725         https://bugs.webkit.org/show_bug.cgi?id=139421
726         rdar://problem/19180108
727
728         Reviewed by Sam Weinig.
729
730         * WebCoreSupport/WebViewGroup.h:
731         Store the local storage database path in the group.
732
733         * WebCoreSupport/WebViewGroup.mm:
734         (WebViewGroup::getOrCreate):
735         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
736         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
737
738         (WebViewGroup::WebViewGroup):
739         Initialize the new member variable.
740
741         (WebViewGroup::storageNamespaceProvider):
742         Create the namespace provider lazily.
743
744         * WebView/WebView.mm:
745         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
746         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
747         Use getOrCreate instead of get.
748
749 2014-12-08  Anders Carlsson  <andersca@apple.com>
750
751         WebStorageNamespaceProvider should know about its local storage database path
752         https://bugs.webkit.org/show_bug.cgi?id=139413
753
754         Reviewed by Andreas Kling.
755
756         * WebCoreSupport/WebViewGroup.h:
757         * WebCoreSupport/WebViewGroup.mm:
758         (WebViewGroup::getOrCreate):
759         (WebViewGroup::WebViewGroup):
760         * WebView/WebView.mm:
761         (-[WebView _commonInitializationWithFrameName:groupName:]):
762         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
763         (-[WebView setGroupName:]):
764         (-[WebView groupName]): Deleted.
765
766 2014-12-08  Daniel Bates  <dabates@apple.com>
767
768         [iOS] Fix the WebKit build with the public SDK
769
770         Include header NSURLDownloadSPI.h.
771
772         * WebCoreSupport/WebFrameLoaderClient.mm:
773
774 2014-12-07  Dan Bernstein  <mitz@apple.com>
775
776         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
777         https://bugs.webkit.org/show_bug.cgi?id=139348
778
779         Reviewed by Anders Carlsson.
780
781         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
782         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
783         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
784         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
785         avoiding the ambiguity.
786
787         * WebView/WebActionMenuController.mm:
788         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
789
790 2014-12-06  Anders Carlsson  <andersca@apple.com>
791
792         Add a stubbed out version of WebStorageNamespaceProvider
793         https://bugs.webkit.org/show_bug.cgi?id=139213
794
795         Reviewed by Sam Weinig.
796
797         * WebCoreSupport/WebViewGroup.h:
798         (WebViewGroup::storageNamespaceProvider):
799         * WebCoreSupport/WebViewGroup.mm:
800         (WebViewGroup::getOrCreate):
801         (WebViewGroup::WebViewGroup):
802         Give WebViewGroup a storage namespace provider.
803
804 2014-12-06  Anders Carlsson  <andersca@apple.com>
805
806         Fix build with newer versions of clang.
807         rdar://problem/18978687
808
809         Add missing overrides and missing casts.
810
811         * Storage/WebDatabaseManagerClient.h:
812         * Storage/WebStorageTrackerClient.h:
813         * WebCoreSupport/WebChromeClient.h:
814         * WebCoreSupport/WebFrameLoaderClient.h:
815         * WebCoreSupport/WebInspectorClient.h:
816         * WebView/WebDataSource.mm:
817         (-[WebDataSource _makeRepresentation]):
818         * WebView/WebFrameView.mm:
819         (-[WebFrameView _makeDocumentViewForDataSource:]):
820
821 2014-12-05  Tim Horton  <timothy_horton@apple.com>
822
823         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
824         https://bugs.webkit.org/show_bug.cgi?id=139306
825         <rdar://problem/19157955>
826
827         Reviewed by Beth Dakin.
828
829         * WebView/WebView.mm:
830         (-[WebView _commonInitializationWithFrameName:groupName:]):
831         (-[WebView _initWithFrame:frameName:groupName:]):
832         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
833
834 2014-12-05  David Kilzer  <ddkilzer@apple.com>
835
836         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
837         <http://webkit.org/b/139286>
838
839         Reviewed by Daniel Bates.
840
841         * Configurations/FeatureDefines.xcconfig: Switch back to using
842         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
843
844 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
845
846         Fix the 32-bit build.
847
848         * WebView/WebView.mm:
849         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
850
851 2014-12-04  Tim Horton  <timothy_horton@apple.com>
852
853         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
854         https://bugs.webkit.org/show_bug.cgi?id=139252
855         <rdar://problem/19140827>
856
857         Reviewed by Anders Carlsson.
858
859         * WebView/WebView.mm:
860         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
861         Adjust to the WebCore changes.
862
863 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
864
865         Implement action menus for tel: URLs
866         https://bugs.webkit.org/show_bug.cgi?id=139240
867         <rdar://problem/19115662>
868
869         Reviewed by Anders Carlsson.
870
871         * WebView/WebActionMenuController.mm:
872         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
873         Make sure to use the newly created currentActionContext... everywhere.
874
875 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
876
877         Implement action menus for tel: URLs
878         https://bugs.webkit.org/show_bug.cgi?id=139240
879         <rdar://problem/19115662>
880
881         Reviewed by Anders Carlsson.
882
883         * WebView/WebActionMenuController.mm:
884         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
885         Make sure to use the newly created currentActionContext.
886
887 2014-12-03  Beth Dakin  <bdakin@apple.com>
888
889         <input> elements get whitespace action menu instead of editable text menu
890         https://bugs.webkit.org/show_bug.cgi?id=139241
891         -and corresponding-
892         rdar://problem/19072083
893
894         Reviewed by Sam Weinig.
895
896         We should disallow shadow content in the hit test. This is the default and it is 
897         how context menus behave. We originally wanted to text inside shadow content so 
898         that we could find the text, but the new function I added to HitTestResult will 
899         allow that.
900         * WebView/WebActionMenuController.mm:
901         (-[WebActionMenuController performHitTestAtPoint:]):
902
903         Adjust to the fact that we don’t hit test shadow content any more.
904         (-[WebActionMenuController focusAndSelectHitTestResult]):
905
906         Offer the text menus for text inside form controls.
907         (-[WebActionMenuController _defaultMenuItems]):
908
909 2014-12-03  Tim Horton  <timothy_horton@apple.com>
910
911         Implement action menus for tel: URLs
912         https://bugs.webkit.org/show_bug.cgi?id=139240
913         <rdar://problem/19115662>
914
915         Reviewed by Anders Carlsson.
916
917         * WebView/WebActionMenuController.mm:
918         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
919         Rename this function as it will work for both mailto and tel URLs.
920         Adjust it to use contextForView:.
921
922         (-[WebActionMenuController webView:willHandleMouseDown:]):
923         (-[WebActionMenuController prepareForMenu:withEvent:]):
924         (-[WebActionMenuController didCloseMenu:withEvent:]):
925         (-[WebActionMenuController _defaultMenuItems]):
926         Don't check the menu type when going to interact with _currentActionContext.
927         We'll only have a _currentActionContext if we have a data detected item,
928         and there are multiple menu types that end up using DDActionContext.
929
930         * WebView/WebUIDelegatePrivate.h:
931         Add a new type.
932
933 2014-12-03  Anders Carlsson  <andersca@apple.com>
934
935         Set a visited link store when creating a simple WebView
936         https://bugs.webkit.org/show_bug.cgi?id=139234
937         <rdar://problem/19132978>
938
939         Reviewed by Sam Weinig.
940
941         * WebView/WebView.mm:
942         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
943
944 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
945
946         Fix the build.
947
948         * WebCoreSupport/WebFrameLoaderClient.mm:
949
950 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
951
952         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
953         https://bugs.webkit.org/show_bug.cgi?id=139149
954
955         Reviewed by Anders Carlsson.
956
957         This changes API behavior. I think that it's OK, because existing behavior made no sense.
958         We used to delete caches from disk, but they were still active in memory. Now we also
959         obsolete them in memory, so documents that use a cache still work, but new ones don't
960         pick one up.
961
962         * WebCoreSupport/WebApplicationCache.mm:
963         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
964         need to delete in-momry caches too. Keep existing behavior.
965         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
966         that properly deletes caches.
967
968 2014-12-02  Tim Horton  <timothy_horton@apple.com>
969
970         Remove a SnowLeopard-era quirk for QuickLook
971         https://bugs.webkit.org/show_bug.cgi?id=139208
972         <rdar://problem/19121822>
973
974         Reviewed by Alexey Proskuryakov.
975
976         * WebCoreSupport/WebFrameLoaderClient.h:
977         * WebCoreSupport/WebFrameLoaderClient.mm:
978
979 2014-12-02  Tim Horton  <timothy_horton@apple.com>
980
981         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
982         https://bugs.webkit.org/show_bug.cgi?id=139204
983
984         Reviewed by Anders Carlsson.
985
986         * WebView/WebView.mm:
987         (-[WebView _commonInitializationWithFrameName:groupName:]):
988         (-[WebView _showDictionaryLookupPopup:]):
989         * WebView/WebViewData.h:
990         Work around this by delaying the softlinking (and setting up the notification
991         observer) until we actually need it. There's still an underlying bug, but
992         this will fix the test.
993
994 2014-12-02  Beth Dakin  <bdakin@apple.com>
995
996         Yet another build fix.
997
998         * WebView/WebActionMenuController.mm:
999         (-[WebActionMenuController _defaultMenuItemsForLink]):
1000
1001 2014-12-02  Beth Dakin  <bdakin@apple.com>
1002
1003         Build fix.
1004
1005         * WebView/WebActionMenuController.mm:
1006         (-[WebActionMenuController _defaultMenuItemsForLink]):
1007
1008 2014-12-02  Beth Dakin  <bdakin@apple.com>
1009
1010         More build fixing.
1011
1012         * WebView/WebActionMenuController.mm:
1013         (-[WebActionMenuController _defaultMenuItemsForLink]):
1014
1015 2014-12-02  Beth Dakin  <bdakin@apple.com>
1016
1017         Should use standardQuickLookMenuItem for apps that don't implement customizations
1018         https://bugs.webkit.org/show_bug.cgi?id=139193
1019         -and corresponding-
1020         rdar://problem/18944696
1021
1022         Reviewed by Anders Carlsson.
1023
1024         Use [NSMenuItem standardQuickLookMenuItem].
1025         * WebView/WebActionMenuController.mm:
1026         (-[WebActionMenuController _defaultMenuItemsForLink]):
1027
1028         Delegate methods to set up the standardQuickLookMenuItem.
1029         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
1030         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
1031         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
1032
1033         Remove all of the old QLPreviewBubble code.
1034         (-[WebActionMenuController _createActionMenuItemForTag:]):
1035         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
1036
1037 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
1038
1039         Fix the build.
1040
1041         * WebView/WebViewData.h:
1042
1043 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1044
1045         Implement Lookup transition from selection for Legacy WebKit
1046         https://bugs.webkit.org/show_bug.cgi?id=139180
1047         <rdar://problem/19067172>
1048
1049         Reviewed by Beth Dakin.
1050
1051         * WebView/DictionaryPopupInfo.h: Added.
1052         Split DictionaryPopupInfo out into its own file.
1053
1054         * WebView/WebActionMenuController.mm:
1055         (-[WebActionMenuController _lookupText:]):
1056         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
1057
1058         (performDictionaryLookupForSelection):
1059         (performDictionaryLookupForRange):
1060         Plumb the transition style through these helpers.
1061         Create a TextIndicator from the selection range.
1062
1063         * WebView/WebHTMLView.mm:
1064         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
1065         Make use of TextIndicator (and DictionaryPopupInfo, and the new
1066         _showDictionaryLookupPopup on WebView) to add a transition from blue
1067         when performing Lookup from the context menu.
1068
1069         (-[WebHTMLView quickLookWithEvent:]):
1070         Remove our TextIndicator whenever a normal three-finger-tap event
1071         comes through, as it will have its own indication.
1072
1073         * WebView/WebView.mm:
1074         (-[WebView _commonInitializationWithFrameName:groupName:]):
1075         (-[WebView _dictionaryLookupPopoverWillClose:]):
1076         Register for the LUNotificationPopoverWillClose notification and remove
1077         our TextIndicator when it is called, just like in WebKit2.
1078         Deregistration is already handled in _close.
1079
1080         (-[WebView _showDictionaryLookupPopup:]):
1081         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
1082         if the relevant API is available.
1083
1084         * WebView/WebViewInternal.h:
1085
1086 2014-12-02  Anders Carlsson  <andersca@apple.com>
1087
1088         Remove visited link handling from PageGroup
1089         https://bugs.webkit.org/show_bug.cgi?id=139185
1090
1091         Reviewed by Sam Weinig.
1092
1093         * History/WebHistory.mm:
1094         (-[WebHistoryPrivate removeItemForURLString:]):
1095         (-[WebHistoryPrivate removeAllItems]):
1096         (+[WebHistory setOptionalSharedHistory:]):
1097         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1098         (+[WebHistory _removeAllVisitedLinks]):
1099         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
1100         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
1101         * History/WebHistoryInternal.h:
1102         * WebCoreSupport/WebChromeClient.h:
1103         * WebCoreSupport/WebChromeClient.mm:
1104         (WebChromeClient::populateVisitedLinks): Deleted.
1105         * WebView/WebView.mm:
1106         (-[WebView addVisitedLinks:]):
1107         (-[WebView removeVisitedLink:]):
1108
1109 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1110
1111         Try to fix the Mac build.
1112
1113         * WebView/WebView.mm:
1114         (-[WebView _commonInitializationWithFrameName:groupName:]):
1115         (-[WebView _close]):
1116
1117 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1118
1119         Fix the iOS build.
1120
1121         * WebView/WebActionMenuController.h:
1122         * WebView/WebActionMenuController.mm:
1123         * WebView/WebHTMLView.mm:
1124         (-[WebHTMLView scrollWheel:scrollWheel:]):
1125         (-[WebHTMLView mouseDown:mouseDown:]):
1126         * WebView/WebView.mm:
1127         * WebView/WebViewData.h:
1128         * WebView/WebViewData.mm:
1129         (-[WebViewPrivate dealloc]):
1130         * WebView/WebViewInternal.h:
1131
1132 2014-12-01  Tim Horton  <timothy_horton@apple.com>
1133
1134         Implement yellow highlight for WebKit1 data detectors
1135         https://bugs.webkit.org/show_bug.cgi?id=138956
1136         <rdar://problem/18992185>
1137
1138         Reviewed by Beth Dakin.
1139
1140         * WebView/WebActionMenuController.h:
1141         * WebView/WebActionMenuController.mm:
1142         (-[WebActionMenuController webView:willHandleMouseDown:]):
1143         (-[WebActionMenuController webView:didHandleScrollWheel:]):
1144         (-[WebActionMenuController prepareForMenu:withEvent:]):
1145         (-[WebActionMenuController didCloseMenu:withEvent:]):
1146         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1147         (-[WebActionMenuController _showTextIndicator]):
1148         (-[WebActionMenuController _hideTextIndicator]):
1149         (-[WebActionMenuController _dismissActionMenuPopovers]):
1150         Copy the WebKit2 WKActionMenuController TextIndicator implementation
1151         into WebActionMenuController. The only significant difference is
1152         that we build the TextIndicator right at menu construction time
1153         instead of in the Web process.
1154
1155         * WebView/WebHTMLView.mm:
1156         (-[WebHTMLView scrollWheel:]):
1157         Let the WebActionMenuController know that we're handling a scroll.
1158
1159         (-[WebHTMLView mouseDown:]):
1160         Let the WebActionMenuController know that we're handling a mouseDown.
1161
1162         * WebView/WebView.mm:
1163         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1164         (-[WebView _clearTextIndicator]):
1165         (-[WebView _actionMenuController]):
1166         (-[WebView _convertRectFromRootView:]): Deleted.
1167         * WebView/WebViewData.h:
1168         * WebView/WebViewData.mm:
1169         * WebView/WebViewInternal.h:
1170         Keep a TextIndicatorWindow on WebView, just like WKView does.
1171         Expose the WebActionMenuController on WebView (internally).
1172
1173 2014-12-01  Anders Carlsson  <andersca@apple.com>
1174
1175         Remove old site specific quirks code that was added in 2009
1176         https://bugs.webkit.org/show_bug.cgi?id=139141
1177
1178         Reviewed by Antti Koivisto.
1179
1180         * WebCoreSupport/WebFrameNetworkingContext.h:
1181         * WebCoreSupport/WebFrameNetworkingContext.mm:
1182         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
1183
1184 2014-11-30  Anders Carlsson  <andersca@apple.com>
1185
1186         Fix a test failure.
1187
1188         * History/WebHistory.mm:
1189         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1190         Call through to the visited link store.
1191
1192         (+[WebHistory _removeAllVisitedLinks]):
1193         Ditto.
1194
1195         * WebCoreSupport/WebVisitedLinkStore.mm:
1196         (WebVisitedLinkStore::isLinkVisited):
1197         Make sure to populate visited links.
1198
1199 2014-11-30  Anders Carlsson  <andersca@apple.com>
1200
1201         Switch over to the visited link store from the WebViewGroup
1202         https://bugs.webkit.org/show_bug.cgi?id=139112
1203
1204         Reviewed by Sam Weinig.
1205
1206         * WebView/WebView.mm:
1207         (-[WebView _commonInitializationWithFrameName:groupName:]):
1208         (-[WebView setGroupName:]):
1209
1210 2014-11-30  Anders Carlsson  <andersca@apple.com>
1211
1212         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
1213         https://bugs.webkit.org/show_bug.cgi?id=139111
1214
1215         Reviewed by Sam Weinig.
1216
1217         * WebCoreSupport/WebVisitedLinkStore.h:
1218         * WebCoreSupport/WebVisitedLinkStore.mm:
1219         (WebVisitedLinkStore::removeVisitedLink):
1220         * WebView/WebView.mm:
1221         (-[WebView removeVisitedLink:]):
1222
1223 2014-11-29  Anders Carlsson  <andersca@apple.com>
1224
1225         Populate visited links
1226         https://bugs.webkit.org/show_bug.cgi?id=139101
1227
1228         Reviewed by Sam Weinig.
1229
1230         * History/WebHistory.mm:
1231         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
1232         Helper function that adds all visited link to the given store.
1233
1234         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
1235         Call the private method.
1236
1237         * History/WebHistoryInternal.h:
1238         * WebCoreSupport/WebVisitedLinkStore.h:
1239         Add new members.
1240
1241         * WebCoreSupport/WebVisitedLinkStore.mm:
1242         (WebVisitedLinkStore::addVisitedLink):
1243         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
1244
1245         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1246         Implement this. First try the delegate, then try the shared history.
1247
1248         (WebVisitedLinkStore::addVisitedLinkHash):
1249         Factor code that adds the link to the hash table into a separate function.
1250
1251         * WebView/WebView.mm:
1252         (-[WebView addVisitedLinks:]):
1253         Add the visited links to the store.
1254
1255 2014-11-29  Anders Carlsson  <andersca@apple.com>
1256
1257         More work on the legacy WebKit visited link store
1258         https://bugs.webkit.org/show_bug.cgi?id=139100
1259
1260         Reviewed by Sam Weinig.
1261
1262         * History/WebHistory.mm:
1263         (+[WebHistory setOptionalSharedHistory:]):
1264         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
1265
1266         * WebCoreSupport/WebVisitedLinkStore.h:
1267         * WebCoreSupport/WebVisitedLinkStore.mm:
1268         (visitedLinkStores):
1269         (WebVisitedLinkStore::WebVisitedLinkStore):
1270         (WebVisitedLinkStore::~WebVisitedLinkStore):
1271         Keep track of live visited link stores.
1272
1273         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
1274         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
1275
1276         (WebVisitedLinkStore::removeAllVisitedLinks):
1277         Iterate over all live link stores and remove their links.
1278
1279         (WebVisitedLinkStore::isLinkVisited):
1280         Populate visited links and check if our hash table contains the link.
1281
1282         (WebVisitedLinkStore::addVisitedLink):
1283         Add the link hash to the table.
1284
1285         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1286         Add stub.
1287
1288         (WebVisitedLinkStore::removeVisitedLinkHashes):
1289         Clear out the hash table.
1290
1291 2014-11-27  Anders Carlsson  <andersca@apple.com>
1292
1293         Add a stubbed out WebVisitedLinkStore to WebViewGroup
1294         https://bugs.webkit.org/show_bug.cgi?id=139066
1295
1296         Reviewed by Antti Koivisto.
1297
1298         * WebCoreSupport/WebViewGroup.h:
1299         (WebViewGroup::visitedLinkStore):
1300         * WebCoreSupport/WebViewGroup.mm:
1301         (WebViewGroup::WebViewGroup):
1302         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1303         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1304         (WebVisitedLinkStore::create):
1305         (WebVisitedLinkStore::WebVisitedLinkStore):
1306         (WebVisitedLinkStore::~WebVisitedLinkStore):
1307         (WebVisitedLinkStore::isLinkVisited):
1308         (WebVisitedLinkStore::addVisitedLink):
1309
1310 2014-11-25  Anders Carlsson  <andersca@apple.com>
1311
1312         Remove user content handling from PageGroup
1313         https://bugs.webkit.org/show_bug.cgi?id=139051
1314
1315         Reviewed by Antti Koivisto.
1316
1317         Use the user content controller in the web view group.
1318
1319         * WebView/WebView.mm:
1320         (-[WebView _injectOutlookQuirksScript]):
1321
1322 2014-11-25  Anders Carlsson  <andersca@apple.com>
1323
1324         Add a user content controller to WebViewGroup and use it for user content
1325         https://bugs.webkit.org/show_bug.cgi?id=139043
1326
1327         Reviewed by Antti Koivisto.
1328
1329         This is another tiny step towards getting rid of user content handling inside PageGroup.
1330
1331         * WebCoreSupport/WebViewGroup.h:
1332         (WebViewGroup::userContentController):
1333         Add a UserContentController member and getter.
1334
1335         * WebCoreSupport/WebViewGroup.mm:
1336         (WebViewGroup::get):
1337         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
1338
1339         (WebViewGroup::WebViewGroup):
1340         Create a user content controller.
1341
1342         * WebView/WebView.mm:
1343         (-[WebView _commonInitializationWithFrameName:groupName:]):
1344         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
1345         set its user content controller in the PageConfiguration.
1346
1347         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1348         Ditto.
1349
1350         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1351         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1352         (+[WebView _removeUserScriptFromGroup:world:url:]):
1353         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
1354         (+[WebView _removeUserScriptsFromGroup:world:]):
1355         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
1356         (+[WebView _removeAllUserContentFromGroup:]):
1357         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
1358
1359         (-[WebView setGroupName:]):
1360         Set the user content controller to the new WebViewGroup's user content controller.
1361
1362 2014-11-21  Jer Noble  <jer.noble@apple.com>
1363
1364         Support multiple signatures of diagnostic logging.
1365         https://bugs.webkit.org/show_bug.cgi?id=138690
1366
1367         Reviewed by Anders Carlsson.
1368
1369         Page::PageClients has been renamed PageConfiguration.
1370
1371         * WebView/WebView.mm:
1372         (-[WebView _commonInitializationWithFrameName:groupName:]):
1373         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1374
1375 2014-11-21  Zalan Bujtas  <zalan@apple.com>
1376
1377         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
1378         https://bugs.webkit.org/show_bug.cgi?id=138981
1379
1380         Reviewed by Simon Fraser.
1381
1382         * WebView/WebPreferenceKeysPrivate.h:
1383         * WebView/WebPreferences.mm:
1384         (+[WebPreferences initialize]):
1385         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
1386         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
1387         * WebView/WebPreferencesPrivate.h:
1388         * WebView/WebView.mm:
1389         (-[WebView _preferencesChanged:]):
1390
1391 2014-11-21  Tim Horton  <timothy_horton@apple.com>
1392
1393         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
1394         ​https://bugs.webkit.org/show_bug.cgi?id=138960
1395         <rdar://problem/19056715>
1396
1397         Reviewed by Anders Carlsson.
1398
1399         * WebView/WebActionMenuController.mm:
1400         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
1401         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1402         Use DataDetectors SPI instead of an explicit blacklist.
1403
1404 2014-11-21  Tim Horton  <timothy_horton@apple.com>
1405
1406         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
1407         https://bugs.webkit.org/show_bug.cgi?id=138960
1408         <rdar://problem/19056715>
1409
1410         Reviewed by Beth Dakin.
1411
1412         * WebView/WebActionMenuController.mm:
1413         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1414         Blacklist contact results, because they don't have useful menus. If we
1415         bail before setting up _currentActionContext, we'll still allow fallthrough
1416         to ordinary text actions, avoiding mysterious failure when a contact is detected.
1417
1418         This doesn't break the case that r176351 was intended to fix,
1419         because in that case we were detecting e.g. addresses.
1420
1421 2014-11-21  Anders Carlsson  <andersca@apple.com>
1422
1423         Remove the Timer parameters from timer callbacks
1424         https://bugs.webkit.org/show_bug.cgi?id=138974
1425
1426         Reviewed by Antti Koivisto.
1427
1428         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1429         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1430         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
1431         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
1432         * Plugins/WebNetscapePluginStream.h:
1433         * Plugins/WebNetscapePluginStream.mm:
1434         (WebNetscapePluginStream::WebNetscapePluginStream):
1435         (WebNetscapePluginStream::deliverDataTimerFired):
1436
1437 2014-11-21  Anders Carlsson  <andersca@apple.com>
1438
1439         Make memoryCache() return a reference
1440         https://bugs.webkit.org/show_bug.cgi?id=138939
1441
1442         Reviewed by Antti Koivisto.
1443
1444         * Misc/WebCache.mm:
1445         (+[WebCache statistics]):
1446         (+[WebCache emptyInMemoryResources]):
1447         (+[WebCache sizeOfDeadResources:]):
1448         (+[WebCache addImageToCache:forURL:forFrame:]):
1449         (+[WebCache removeImageFromCacheForURL:forFrame:]):
1450         (+[WebCache imageForURL:]):
1451         (+[WebCache setDisabled:]):
1452         (+[WebCache isDisabled]):
1453         * WebView/WebView.mm:
1454         (+[WebView _setCacheModel:]):
1455
1456 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
1457
1458         Remove the remaining vestiges of minimal-ui
1459         https://bugs.webkit.org/show_bug.cgi?id=138890
1460
1461         Reviewed by Sam Weinig.
1462
1463         * History/WebHistoryItem.mm:
1464         * History/WebHistoryItemPrivate.h:
1465
1466 2014-11-20  Tim Horton  <timothy_horton@apple.com>
1467
1468         Cancel DataDetectors menu earlier if we know it can't be presented
1469         https://bugs.webkit.org/show_bug.cgi?id=138922
1470         <rdar://problem/18950441>
1471
1472         Reviewed by Beth Dakin.
1473
1474         * WebView/WebActionMenuController.mm:
1475         (-[WebActionMenuController prepareForMenu:withEvent:]):
1476         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
1477         and use a bigger hammer (removeAllItems).
1478
1479         (-[WebActionMenuController willOpenMenu:withEvent:]):
1480         If we end up with a menu with no items, don't change selection or anything.
1481
1482 2014-11-20  Beth Dakin  <bdakin@apple.com>
1483
1484         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
1485         https://bugs.webkit.org/show_bug.cgi?id=138568
1486         -and corresponding-
1487         rdar://problem/18904600
1488
1489         Reviewed by Tim Horton.
1490
1491         Skip images for lookup.
1492         * WebView/WebActionMenuController.mm:
1493         (performDictionaryLookupForRange):
1494
1495 2014-11-19  Beth Dakin  <bdakin@apple.com>
1496
1497         Invoking an action menu on a selection should result in the text menu
1498         https://bugs.webkit.org/show_bug.cgi?id=138892
1499         -and corresponding-
1500         rdar://problem/18996776
1501
1502         Reviewed by Tim Horton.
1503
1504         * WebView/WebActionMenuController.mm:
1505         (-[WebActionMenuController _defaultMenuItems]):
1506
1507 2014-11-19  Beth Dakin  <bdakin@apple.com>
1508
1509         Data detected results with no menu items should not fall through to regular text 
1510         action menus
1511         https://bugs.webkit.org/show_bug.cgi?id=138887
1512         -and corresponding-
1513         rdar://problem/18971616
1514
1515         Reviewed by Tim Horton.
1516
1517         * WebView/WebActionMenuController.mm:
1518         (-[WebActionMenuController _defaultMenuItems]):
1519
1520 2014-11-19  Daniel Bates  <dabates@apple.com>
1521
1522         [iOS] Make WebKit build with public iOS SDK
1523         https://bugs.webkit.org/show_bug.cgi?id=136863
1524
1525         Reviewed by David Kilzer.
1526
1527         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
1528         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
1529         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
1530         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
1531         may be used by Apple internal clients that do not include wtf/Platform.h.
1532         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
1533         private Foundation headers directly.
1534         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
1535         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
1536         instead of including private CFNetwork headers directly. Also fixed up style and
1537         ordering of header include directives.
1538         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
1539         CFNetwork headers directly. Also sort the #import directives.
1540         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
1541         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
1542
1543 2014-11-18  David Kilzer  <ddkilzer@apple.com>
1544
1545         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
1546         <http://webkit.org/b/138813>
1547
1548         Reviewed by Mark Rowe.
1549
1550         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
1551         selectors.
1552
1553 2014-11-18  Chris Dumez  <cdumez@apple.com>
1554
1555         Add a setting to toggle DOMTimer throttling support
1556         https://bugs.webkit.org/show_bug.cgi?id=138844
1557         <rdar://problem/19020874>
1558
1559         Reviewed by Andreas Kling.
1560
1561         Add a setting to disable DOM timers throttling, in order to help
1562         developers determine if a specific issue is caused by timer
1563         throttling.
1564
1565         * WebView/WebPreferenceKeysPrivate.h:
1566         * WebView/WebPreferences.mm:
1567         (+[WebPreferences initialize]):
1568         (-[WebPreferences domTimersThrottlingEnabled]):
1569         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
1570         * WebView/WebPreferencesPrivate.h:
1571         * WebView/WebView.mm:
1572         (-[WebView _preferencesChanged:]):
1573
1574 2014-11-18  Tim Horton  <timothy_horton@apple.com>
1575
1576         Avoid re-encoding action menu image data
1577         https://bugs.webkit.org/show_bug.cgi?id=138817
1578         <rdar://problem/18840382>
1579
1580         Reviewed by Anders Carlsson.
1581
1582         * WebView/WebActionMenuController.mm:
1583         (-[WebActionMenuController _defaultMenuItemsForImage:]):
1584         (-[WebActionMenuController _addImageToPhotos:]):
1585         Build a temporary filename from a UUID and the image's desired extension.
1586         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
1587         Build an image menu only if we have an image, URL, data, and extension.
1588
1589 2014-11-18  Daniel Bates  <dabates@apple.com>
1590
1591         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1592         SPI are not available in public SDK
1593         https://bugs.webkit.org/show_bug.cgi?id=138802
1594
1595         Reviewed by David Kilzer.
1596
1597         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
1598         libdispatch and MobileGestalt headers directly.
1599
1600         * WebView/WebView.mm:
1601
1602 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
1603
1604         Remove calls to deprecated NSMenu methods
1605         https://bugs.webkit.org/show_bug.cgi?id=138808.
1606
1607         Reviewed by Anders Carlsson.
1608
1609         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
1610
1611         * WebCoreSupport/PopupMenuMac.mm:
1612         (PopupMenuMac::populate):
1613
1614 2014-11-17  Daniel Bates  <dabates@apple.com>
1615
1616         Unreviewed, rolling out r176232.
1617
1618         Broke the Mac build. Will investigate offline.
1619
1620         Reverted changeset:
1621
1622         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
1623         MobileGestalt"
1624         https://bugs.webkit.org/show_bug.cgi?id=138802
1625         http://trac.webkit.org/changeset/176232
1626
1627 2014-11-17  Daniel Bates  <dabates@apple.com>
1628
1629         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1630         SPI are not available in public SDK
1631         https://bugs.webkit.org/show_bug.cgi?id=138802
1632
1633         Reviewed by David Kilzer.
1634
1635         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
1636         libdispatch and MobileGestalt headers directly.
1637
1638         * WebView/WebView.mm:
1639
1640 2014-11-17  Beth Dakin  <bdakin@apple.com>
1641
1642         Whitespace action menus should focus the HitTestResult and create an insertion 
1643         point
1644         https://bugs.webkit.org/show_bug.cgi?id=138786
1645         -and corresponding-
1646         rdar://problem/18944893
1647
1648         Reviewed by Tim Horton.
1649
1650         Whitespace menus should cause the HitTestResult to be focused, and they should set 
1651         the selection based on the HitTest location.
1652
1653         * WebView/WebActionMenuController.mm:
1654         (-[WebActionMenuController isMenuForTextContent]):
1655         (-[WebActionMenuController focusAndSelectHitTestResult]):
1656         (-[WebActionMenuController willOpenMenu:withEvent:]):
1657
1658 2014-11-17  Daniel Bates  <dabates@apple.com>
1659
1660         [iOS] QuartzCore SPI not available in public SDK
1661         https://bugs.webkit.org/show_bug.cgi?id=138751
1662
1663         Reviewed by David Kilzer.
1664
1665         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
1666
1667         * WebInspector/WebNodeHighlight.mm:
1668         * WebView/WebIndicateLayer.mm:
1669
1670 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
1671
1672         [iOS] allow host application to opt-out of alternate fullscreen
1673         https://bugs.webkit.org/show_bug.cgi?id=138787
1674
1675         Reviewed by Darin Adler.
1676
1677         * WebView/WebPreferenceKeysPrivate.h:
1678         * WebView/WebPreferences.mm:
1679         (+[WebPreferences initialize]):
1680         (-[WebPreferences allowsAlternateFullscreen]):
1681         (-[WebPreferences setAllowsAlternateFullscreen:]):
1682         * WebView/WebPreferencesPrivate.h:
1683         * WebView/WebView.mm:
1684         (-[WebView _preferencesChanged:]):
1685
1686 2014-11-16  Tim Horton  <timothy_horton@apple.com>
1687
1688         Use TextIndicator instead of the built in Lookup highlight
1689         https://bugs.webkit.org/show_bug.cgi?id=138775
1690         <rdar://problem/18953982>
1691
1692         Reviewed by Anders Carlsson.
1693
1694         * WebCoreSupport/WebSystemInterface.mm:
1695         (InitWebCoreSystemInterface):
1696         Remove a WKSI import.
1697
1698         * WebView/WebActionMenuController.mm:
1699         (-[WebActionMenuController _lookupText:]):
1700         (-[WebActionMenuController _createActionMenuItemForTag:]):
1701         Make use of the new Lookup SPI header.
1702         Disable the Lookup item if lookup is not available.
1703
1704 2014-11-15  Tim Horton  <timothy_horton@apple.com>
1705
1706         Implement data detectors and mailto action menus for WebKit1
1707         https://bugs.webkit.org/show_bug.cgi?id=138765
1708         <rdar://problem/18877535>
1709
1710         Reviewed by Beth Dakin.
1711
1712         * WebView/WebActionMenuController.h:
1713         * WebView/WebActionMenuController.mm:
1714         (-[WebActionMenuController willOpenMenu:withEvent:]):
1715         Tell DataDetectors that the menu is going to open.
1716         Select the text (or not) based on the number of items in the menu, just like WebKit2.
1717
1718         (-[WebActionMenuController didCloseMenu:withEvent:]):
1719         Tell DataDetectors that the menu closed.
1720
1721         (-[WebActionMenuController _defaultMenuItemsForLink]):
1722         Move these checks out of _defaultMenuItemsForLink, because we expect this
1723         to always return a complete link menu.
1724
1725         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
1726         Implement. More or less copied from WebKit2.
1727
1728         (-[WebActionMenuController _selectDataDetectedText]):
1729         Select the stashed range.
1730
1731         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1732         Implement. More or less copied from WebKit2.
1733         The yellow highlight isn't hooked up yet.
1734         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
1735
1736         (-[WebActionMenuController _selectLookupText]):
1737         Remove an unnecessary return.
1738
1739         (-[WebActionMenuController _defaultMenuItems]):
1740         Call into the two new menu types.
1741
1742         * WebView/WebUIDelegatePrivate.h:
1743
1744 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
1745
1746         Get rid of WebFontCache
1747         https://bugs.webkit.org/show_bug.cgi?id=134752
1748
1749         Reviewed by Dave Hyatt.
1750
1751         * WebView/WebHTMLView.mm:
1752
1753 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
1754
1755         Update some artwork for the legacy WebKit action menu
1756         https://bugs.webkit.org/show_bug.cgi?id=138758
1757         <rdar://problem/18989840>
1758
1759         * WebView/WebActionMenuController.mm:
1760         (webKitBundleImageNamed): Deleted.
1761         Fix the build.
1762
1763 2014-11-14  Tim Horton  <timothy_horton@apple.com>
1764
1765         Update some artwork for the legacy WebKit action menu
1766         https://bugs.webkit.org/show_bug.cgi?id=138758
1767         <rdar://problem/18989840>
1768
1769         Reviewed by Simon Fraser.
1770
1771         * WebView/WebActionMenuController.mm:
1772         (-[WebActionMenuController _createActionMenuItemForTag:]):
1773
1774 2014-11-14  Daniel Bates  <dabates@apple.com>
1775
1776         [iOS] NSFileManager and QuickLook SPI not available in public SDK
1777         https://bugs.webkit.org/show_bug.cgi?id=138742
1778
1779         Reviewed by Pratik Solanki.
1780
1781         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
1782
1783         * WebCoreSupport/WebFrameLoaderClient.mm:
1784
1785 2014-11-14  Beth Dakin  <bdakin@apple.com>
1786
1787         WK1: Webpage preview can come up in wrong location
1788         https://bugs.webkit.org/show_bug.cgi?id=138747
1789         -and corresponding-
1790         rdar://problem/18979004
1791
1792         Reviewed by Tim Horton.
1793
1794         Converting to window twice is bad.
1795         * WebView/WebActionMenuController.mm:
1796         (elementBoundingBoxInWindowCoordinatesFromNode):
1797         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1798         (elementBoundingBoxFromNode): Deleted.
1799
1800 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
1801
1802         Move FontMac and FontCacheMac off of WKSI
1803         https://bugs.webkit.org/show_bug.cgi?id=138633
1804
1805         Reviewed by Simon Fraser.
1806
1807         * WebCoreSupport/WebSystemInterface.mm:
1808         (InitWebCoreSystemInterface):
1809         * WebKit.order:
1810
1811 2014-11-13  Beth Dakin  <bdakin@apple.com>
1812
1813         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
1814         https://bugs.webkit.org/show_bug.cgi?id=138716
1815         -and corresponding-
1816         rdar://problem/18977222
1817
1818         Reviewed by Tim Horton.
1819
1820         It’s not necessary to use the WebElementDictionary for so many things now that we 
1821         are caching the HitTestResult. We should just use the HitTestResult.
1822
1823         * WebView/WebActionMenuController.mm:
1824         (-[WebActionMenuController prepareForMenu:withEvent:]):
1825         (-[WebActionMenuController _openURLFromActionMenu:]):
1826         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
1827         (elementBoundingBoxFromNode):
1828         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1829         (-[WebActionMenuController _defaultMenuItemsForLink]):
1830         (-[WebActionMenuController _defaultMenuItemsForImage]):
1831         (-[WebActionMenuController _defaultMenuItemsForVideo]):
1832         (-[WebActionMenuController _defaultMenuItemsForText]):
1833         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
1834         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
1835         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
1836         (-[WebActionMenuController _createActionMenuItemForTag:]):
1837         (-[WebActionMenuController _defaultMenuItems]):
1838         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
1839         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
1840         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
1841         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
1842         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
1843         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
1844         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
1845         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
1846         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
1847         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
1848
1849 2014-11-13  Daniel Bates  <dabates@apple.com>
1850
1851         [iOS] NSGeometry data types are not available in the public SDK
1852         https://bugs.webkit.org/show_bug.cgi?id=137536
1853
1854         Reviewed by David Kilzer.
1855
1856         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
1857         private header.
1858
1859         * DOM/WebDOMOperationsPrivate.h:
1860
1861 2014-11-13  Beth Dakin  <bdakin@apple.com>
1862
1863         WK1: Support default actions for video
1864         https://bugs.webkit.org/show_bug.cgi?id=138713
1865         -and corresponding-
1866         rdar://problem/18877520
1867
1868         Reviewed by Tim Horton.
1869
1870         Call setToNonShadowAncestor() for media HitTestResults.
1871         * WebView/WebActionMenuController.mm:
1872         (-[WebActionMenuController performHitTestAtPoint:]):
1873
1874         Default items and actions.
1875         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
1876         (-[WebActionMenuController _copyVideoURL:]):
1877         (-[WebActionMenuController _saveVideoToDownloads:]):
1878         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1879         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1880         * WebView/WebUIDelegatePrivate.h:
1881
1882 2014-11-13  Tim Horton  <timothy_horton@apple.com>
1883
1884         WK1: Update icon for Add to Reading List
1885         https://bugs.webkit.org/show_bug.cgi?id=138710
1886         <rdar://problem/18975774>
1887
1888         Reviewed by Beth Dakin.
1889
1890         * WebView/WebActionMenuController.mm:
1891         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1892         Use the right icon, matching WebKit2.
1893
1894 2014-11-12  Beth Dakin  <bdakin@apple.com>
1895
1896         WK1: Support default actions for images
1897         https://bugs.webkit.org/show_bug.cgi?id=138668
1898         -and corresponding-
1899         rdar://problem/18785434
1900
1901         Reviewed by Tim Horton.
1902
1903         * WebView/WebActionMenuController.h:
1904         * WebView/WebActionMenuController.mm:
1905         (-[WebActionMenuController didCloseMenu:withEvent:]):
1906         (-[WebActionMenuController _defaultMenuItemsForImage:]):
1907         (-[WebActionMenuController _copyImage:]):
1908         (temporaryPhotosDirectoryPath):
1909         (pathToPhotoOnDisk):
1910         (-[WebActionMenuController _canAddMediaToPhotos]):
1911         (-[WebActionMenuController _addImageToPhotos:]):
1912         (-[WebActionMenuController _saveImageToDownloads:]):
1913         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
1914         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
1915         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
1916         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1917         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1918         * WebView/WebUIDelegatePrivate.h:
1919
1920 2014-11-11  Beth Dakin  <bdakin@apple.com>
1921
1922         Action menu hit testing is not working properly with all WK1 apps
1923         https://bugs.webkit.org/show_bug.cgi?id=138643
1924         -and corresponding-
1925         rdar://problem/18949376
1926
1927         Reviewed by Tim Horton.
1928
1929         * WebView/WebActionMenuController.mm:
1930         (-[WebActionMenuController prepareForMenu:withEvent:]):
1931         (-[WebActionMenuController _lookupText:]):
1932
1933 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1934
1935         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
1936         https://bugs.webkit.org/show_bug.cgi?id=138623
1937
1938         Reviewed by Geoff Garen.
1939
1940         * WebCoreSupport/WebSystemInterface.mm:
1941         (InitWebCoreSystemInterface):
1942         * WebKit.order:
1943
1944 2014-11-11  Tim Horton  <timothy_horton@apple.com>
1945
1946         Localize strings for action menus
1947         https://bugs.webkit.org/show_bug.cgi?id=138591
1948         <rdar://problem/18815343>
1949
1950         Reviewed by Dan Bates.
1951
1952         * WebView/WebActionMenuController.mm:
1953         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1954         Make use of the new strings.
1955
1956 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1957
1958         Cleanup from r175379
1959         https://bugs.webkit.org/show_bug.cgi?id=138616
1960
1961         Reviewed by Simon Fraser.
1962
1963         * WebCoreSupport/WebSystemInterface.mm:
1964         (InitWebCoreSystemInterface):
1965         * WebKit.order:
1966
1967 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1968
1969         Move CTFontTransformGlyphs out from WKSI
1970         https://bugs.webkit.org/show_bug.cgi?id=138599
1971
1972         Reviewed by Simon Fraser.
1973
1974         * WebCoreSupport/WebSystemInterface.mm:
1975         (InitWebCoreSystemInterface):
1976         * WebKit.order:
1977
1978 2014-11-11  Dan Bernstein  <mitz@apple.com>
1979
1980         More iOS build fix.
1981
1982         * WebView/WebHTMLViewInternal.h:
1983
1984 2014-11-11  Dan Bernstein  <mitz@apple.com>
1985
1986         iOS build fix.
1987
1988         * WebView/WebHTMLView.mm:
1989
1990 2014-11-10  Beth Dakin  <bdakin@apple.com>
1991
1992         WK1: Support default actions for editable text with misspelled word
1993         https://bugs.webkit.org/show_bug.cgi?id=138590
1994         -and corresponding-
1995         rdar://problem/18877506
1996
1997         Reviewed by Tim Horton.
1998
1999         If there are misspelled word suggestions for editable text, create a new type of 
2000         menu with a spelling suggestion sub-menu.
2001
2002         * WebView/WebActionMenuController.mm:
2003         (-[WebActionMenuController isMenuForTextContent]):
2004         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
2005         (-[WebActionMenuController _changeSelectionToSuggestion:]):
2006         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2007         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2008         * WebView/WebHTMLView.mm:
2009         (-[WebHTMLView _changeSpellingToWord:]):
2010         * WebView/WebHTMLViewInternal.h:
2011         * WebView/WebUIDelegatePrivate.h:
2012
2013 2014-11-10  Beth Dakin  <bdakin@apple.com>
2014
2015         WK1: Support default actions for editable whitespace
2016         https://bugs.webkit.org/show_bug.cgi?id=138586
2017         -and corresponding-
2018         rdar://problem/18932048
2019
2020         Reviewed by Tim Horton.
2021
2022         New menu type. Just wants paste.
2023
2024         * WebView/WebActionMenuController.mm:
2025         (-[WebActionMenuController isMenuForTextContent]):
2026         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
2027         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2028         * WebView/WebUIDelegatePrivate.h:
2029
2030 2014-11-10  Beth Dakin  <bdakin@apple.com>
2031
2032         WK1: Support default actions for editable text
2033         https://bugs.webkit.org/show_bug.cgi?id=138580
2034         -and corresponding-
2035         rdar://problem/18877497
2036
2037         Reviewed by Tim Horton.
2038
2039         New menu type, and new action type for paste. 
2040
2041         * WebView/WebActionMenuController.mm:
2042         (-[WebActionMenuController isMenuForTextContent]):
2043         (-[WebActionMenuController willOpenMenu:withEvent:]):
2044         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
2045         (-[WebActionMenuController _paste:]):
2046         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2047         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2048         * WebView/WebUIDelegatePrivate.h:
2049
2050 2014-11-10  Beth Dakin  <bdakin@apple.com>
2051
2052         WK1: Text is getting selected even when an action menu fails to invoke
2053         https://bugs.webkit.org/show_bug.cgi?id=138576
2054         -and corresponding-
2055         rdar://problem/18931330
2056
2057         Reviewed by Tim Horton.
2058
2059         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
2060         * WebView/WebActionMenuController.h:
2061         * WebView/WebActionMenuController.mm:
2062         (-[WebActionMenuController prepareForMenu:withEvent:]):
2063         (-[WebActionMenuController willOpenMenu:withEvent:]):
2064
2065         _selectLookupText no longer needs to return a BOOL indicating success or failure.
2066         (-[WebActionMenuController _selectLookupText]):
2067         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2068
2069         Pass willOpenMenu: on to the controller.
2070         * WebView/WebView.mm:
2071         (-[WebView willOpenMenu:withEvent:]):
2072
2073 2014-11-10  Beth Dakin  <bdakin@apple.com>
2074
2075         Speculative build fix.
2076
2077         * WebView/WebActionMenuController.mm:
2078
2079 2014-11-10  Beth Dakin  <bdakin@apple.com>
2080
2081         Action menu initialization should be moved to _commonInitializationWithFrameName
2082         https://bugs.webkit.org/show_bug.cgi?id=138572
2083         -and corresponding-
2084         rdar://problem/18929733
2085
2086         Reviewed by Tim Horton.
2087
2088         * WebView/WebView.mm:
2089         (-[WebView _commonInitializationWithFrameName:groupName:]):
2090         (-[WebView _initWithFrame:frameName:groupName:]):
2091
2092 2014-11-10  Beth Dakin  <bdakin@apple.com>
2093
2094         WK1: Support default actions for read-only text
2095         https://bugs.webkit.org/show_bug.cgi?id=138552
2096         -and corresponding-
2097         rdar://problem/18877483
2098
2099         Reviewed by Tim Horton.
2100
2101         New WKSystemInterface functions that WebCore needs to use.
2102         * WebCoreSupport/WebSystemInterface.mm:
2103         (InitWebCoreSystemInterface):
2104
2105         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
2106         makes a lot of things easier.
2107         * WebView/WebActionMenuController.h:
2108         * WebView/WebActionMenuController.mm:
2109
2110         Perform the hit test ourselves instead of calling into WebView so that we can more 
2111         easily save the WebCore::HitTestResult for ourselves.
2112         (-[WebActionMenuController performHitTestAtPoint:]):
2113
2114         Clear selection for non-text menus.
2115         (-[WebActionMenuController prepareForMenu:withEvent:]):
2116
2117         Re-set the _type here just to be safe.
2118         (-[WebActionMenuController didCloseMenu:withEvent:]):
2119
2120         Moving this method to be next to the link actions so they can be within a pragma 
2121         mark.
2122         (-[WebActionMenuController _defaultMenuItemsForLink:]):
2123
2124         New method for default text actions — lookup and copy.
2125         (-[WebActionMenuController _defaultMenuItemsForText:]):
2126         (-[WebActionMenuController _copySelection:]):
2127         (-[WebActionMenuController _lookupText:]):
2128
2129         If there is not already a selection, invoking the action menu on text should 
2130         select the lookup text.
2131         (-[WebActionMenuController _selectLookupText]):
2132         (performDictionaryLookupForSelection):
2133         (performDictionaryLookupForRange):
2134
2135         Handle text now.
2136         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2137         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2138
2139         New enum values.
2140         * WebView/WebUIDelegatePrivate.h:
2141
2142         Pass didCloseMenu on to the controller.
2143         * WebView/WebView.mm:
2144         (-[WebView didCloseMenu:withEvent:]):
2145
2146 2014-11-09  Chris Dumez  <cdumez@apple.com>
2147
2148         Add a more correct way to compare floating point numbers and use it
2149         https://bugs.webkit.org/show_bug.cgi?id=138527
2150
2151         Reviewed by Darin Adler.
2152
2153         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
2154         to compare floating-point numbers.
2155
2156         * WebView/WebHTMLView.mm:
2157         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
2158
2159 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
2160
2161         Delete cookies between tests
2162         https://bugs.webkit.org/show_bug.cgi?id=138528
2163
2164         Reviewed by Sam Weinig.
2165
2166         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
2167         * WebView/WebPreferencesPrivate.h:
2168         Added an SPI for DumpRenderTree.
2169
2170 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
2171
2172         [iOS] Update optimized fullscreen media controls
2173         https://bugs.webkit.org/show_bug.cgi?id=138493
2174
2175         Reviewed by Brent Fulgham.
2176
2177         * WebCoreSupport/WebSystemInterface.mm:
2178         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
2179
2180 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
2181
2182         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
2183         https://bugs.webkit.org/show_bug.cgi?id=138443
2184
2185         Reviewed by Anders Carlsson.
2186
2187         Wrapping the dealloc method in its own autorelease pool avoids the problem of
2188         complex tear-downs leading to the WebView itself being added to an autorelease
2189         pool that is not drained until after the instance has been dealloc'd.
2190  
2191         * WebView/WebView.mm:
2192         (-[WebView dealloc]):
2193
2194 2014-11-05  Jer Noble  <jer.noble@apple.com>
2195
2196         De-templatize Timer
2197         https://bugs.webkit.org/show_bug.cgi?id=138450
2198
2199         Reviewed by Anders Carlsson.
2200
2201         Remove template specifiers from Timer.
2202
2203         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2204         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2205         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2206         * Plugins/WebNetscapePluginStream.h:
2207         * Plugins/WebNetscapePluginStream.mm:
2208         (WebNetscapePluginStream::deliverDataTimerFired):
2209
2210 2014-11-05  Dan Bernstein  <mitz@apple.com>
2211
2212         Remove the unused deletion UI feature
2213         https://bugs.webkit.org/show_bug.cgi?id=138442
2214
2215         Rubber-stamped by Alexey Proskuryakov.
2216
2217         * DefaultDelegates/WebDefaultEditingDelegate.m:
2218         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
2219         * WebCoreSupport/WebEditorClient.h:
2220         * WebCoreSupport/WebEditorClient.mm:
2221         (WebEditorClient::shouldShowDeleteInterface): Deleted.
2222         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
2223         -webView:shouldShowDeleteInterfaceForElement:.
2224
2225 2014-11-03  Dean Jackson  <dino@apple.com>
2226
2227         Add ENABLE_FILTERS_LEVEL_2 feature guard.
2228         https://bugs.webkit.org/show_bug.cgi?id=138362
2229
2230         Reviewed by Tim Horton.
2231
2232         Add a new feature define for Level 2 of CSS Filters.
2233         http://dev.w3.org/fxtf/filters-2/
2234
2235         * Configurations/FeatureDefines.xcconfig:
2236
2237 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
2238
2239         Add button and enable optimized fullscreen.
2240         https://bugs.webkit.org/show_bug.cgi?id=138351
2241
2242         Reviewed by Eric Carlson.
2243
2244         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
2245
2246         * WebCoreSupport/WebSystemInterface.mm:
2247         (InitWebCoreSystemInterface): added
2248
2249 2014-11-04  Chris Dumez  <cdumez@apple.com>
2250
2251         Add ptr() method to Ref class
2252         https://bugs.webkit.org/show_bug.cgi?id=138361
2253
2254         Reviewed by Darin Adler.
2255
2256         Use the new Ref::ptr() method.
2257
2258         * WebView/WebFrame.mm:
2259         (-[WebFrame _setTypingStyle:withUndoAction:]):
2260         * WebView/WebHTMLView.mm:
2261         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
2262         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
2263         * WebView/WebView.mm:
2264         (-[WebView applyStyle:]):
2265
2266 2014-11-04  Darin Adler  <darin@apple.com>
2267
2268         Eliminate ResourceBuffer and use SharedBuffer directly instead
2269         https://bugs.webkit.org/show_bug.cgi?id=138174
2270
2271         Reviewed by Antti Koivisto.
2272
2273         * WebView/WebDataSource.mm:
2274         (-[WebDataSource data]): Use SharedBuffer directly.
2275         * WebView/WebHTMLView.mm:
2276         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2277
2278 2014-11-03  Commit Queue  <commit-queue@webkit.org>
2279
2280         Unreviewed, rolling out r175406, r175413, and r175423.
2281         https://bugs.webkit.org/show_bug.cgi?id=138327
2282
2283         Multipart tests are still broken (Requested by ap on #webkit).
2284
2285         Reverted changesets:
2286
2287         "Eliminate ResourceBuffer and use SharedBuffer directly
2288         instead"
2289         https://bugs.webkit.org/show_bug.cgi?id=138174
2290         http://trac.webkit.org/changeset/175406
2291
2292         "Unreviewed, iOS build fix since 175406."
2293         http://trac.webkit.org/changeset/175413
2294
2295         "Fix assertion in CachedResource::addDataBuffer"
2296         http://trac.webkit.org/changeset/175423
2297
2298 2014-10-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2299
2300         Use std::unique_ptr for TypeCountSet
2301         https://bugs.webkit.org/show_bug.cgi?id=138242
2302
2303         Reviewed by Andreas Kling.
2304
2305         * Misc/WebCoreStatistics.mm:
2306         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr.
2307         (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto.
2308
2309 2014-10-31  Beth Dakin  <bdakin@apple.com>
2310
2311         Use system art for action menus when possible
2312         https://bugs.webkit.org/show_bug.cgi?id=138260
2313
2314         Reviewed by Tim Horton.
2315
2316         * WebView/WebActionMenuController.mm:
2317         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2318
2319 2014-10-30  Darin Adler  <darin@apple.com>
2320
2321         Eliminate ResourceBuffer and use SharedBuffer directly instead
2322         https://bugs.webkit.org/show_bug.cgi?id=138174
2323
2324         Reviewed by Antti Koivisto.
2325
2326         * WebView/WebDataSource.mm:
2327         (-[WebDataSource data]): Use SharedBuffer directly.
2328         * WebView/WebHTMLView.mm:
2329         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2330
2331 2014-10-30  Jer Noble  <jer.noble@apple.com>
2332
2333         [EME] Add Setting for accessing storage location for MediaKeys data
2334         https://bugs.webkit.org/show_bug.cgi?id=138147
2335
2336         Reviewed by Brady Eidson.
2337
2338         * WebView/WebPreferenceKeysPrivate.h:
2339         * WebView/WebPreferences.mm:
2340         (+[WebPreferences initialize]): Set default location.
2341         (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor.
2342         (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter.
2343         * WebView/WebPreferencesPrivate.h:
2344         * WebView/WebView.mm:
2345         (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings.
2346
2347 2014-10-30  Dana Burkart  <dburkart@apple.com>
2348
2349         <rdar://problem/18821260> Prepare for the mysterious future
2350
2351         Reviewed by Lucas Forschler.
2352
2353         * Configurations/Base.xcconfig:
2354         * Configurations/DebugRelease.xcconfig:
2355         * Configurations/FeatureDefines.xcconfig:
2356         * Configurations/Version.xcconfig:
2357
2358 2014-10-28  Jeremy Jones  <jeremyj@apple.com>
2359
2360         Add optimized fullscreen mode.
2361         https://bugs.webkit.org/show_bug.cgi?id=138044
2362
2363         Reviewed by Jer Noble.
2364
2365         Enable different types of fullscreen video behavior.
2366         Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
2367
2368         * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
2369         * WebCoreSupport/WebChromeClient.mm:
2370         (WebChromeClient::enterVideoFullscreenForVideoElement): ditto
2371         * WebView/WebView.mm:
2372         (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
2373         (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.
2374         * WebView/WebViewInternal.h: ditto
2375
2376 2014-10-27  Beth Dakin  <bdakin@apple.com>
2377
2378         Provide a way for WebKit1 clients to override default action menu items
2379         https://bugs.webkit.org/show_bug.cgi?id=138066
2380         -and corresponding-
2381         rdar://problem/18451638
2382
2383         Reviewed by Anders Carlsson.
2384
2385         WebActionMenuController now has an ivar for the WebActionMenuType so that it can 
2386         send that along to clients customizing the menu.
2387         * WebView/WebActionMenuController.h:
2388         * WebView/WebActionMenuController.mm:
2389         (-[WebActionMenuController prepareForMenu:withEvent:]):
2390         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2391
2392         New enum and new SPI to customize menus.
2393         * WebView/WebUIDelegatePrivate.h:
2394
2395 2014-10-24  Benjamin Poulain  <bpoulain@apple.com>
2396
2397         Fix the iOS build
2398
2399         * Configurations/WebKitLegacy.xcconfig:
2400         * WebView/WebView.mm:
2401
2402 2014-10-24  Beth Dakin  <bdakin@apple.com>
2403
2404         Build fix.
2405
2406         * WebView/WebActionMenuController.mm:
2407         (-[WebActionMenuController _openURLFromActionMenu:]):
2408         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2409         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2410
2411 2014-10-24  Beth Dakin  <bdakin@apple.com>
2412
2413         WebKit1 should support action menus
2414         https://bugs.webkit.org/show_bug.cgi?id=138032
2415
2416         Reviewed by Tim Horton.
2417
2418         This patch adds basic support for action menus and adds actions for links.
2419
2420         Helper class takes care of all of the action menu work. WebView will forward the 
2421         prepareForMenu: message, and then the helper class takes it from there.
2422         * WebView/WebActionMenuController.h: Added.
2423         * WebView/WebActionMenuController.mm: Added.
2424         (-[WebActionMenuController webViewClosed]):
2425         (-[WebActionMenuController prepareForMenu:withEvent:]):
2426
2427         Selectors for link actions.
2428         (-[WebActionMenuController _openURLFromActionMenu:]):
2429         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2430         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
2431         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2432         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2433         (webKitBundleImageNamed):
2434         (-[WebActionMenuController _defaultMenuItemsForLink:]):
2435         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2436
2437         Tags for the action menu items.
2438         * WebView/WebUIDelegatePrivate.h:
2439         * WebView/WebView.mm:
2440
2441         Set the action menu if possible and create the controller.
2442         (-[WebView _initWithFrame:frameName:groupName:]):
2443         (-[WebView _close]):
2444         (-[WebView prepareForMenu:withEvent:]):
2445
2446         WebViewData stores the WebActionMenuHelper
2447         * WebView/WebViewData.h:
2448         * WebView/WebViewData.mm:
2449         (-[WebViewPrivate dealloc]):
2450
2451 2014-10-23  Joseph Pecoraro  <pecoraro@apple.com>
2452
2453         Web Inspector: Provide a way to have alternate inspector agents
2454         https://bugs.webkit.org/show_bug.cgi?id=137901
2455
2456         Reviewed by Brian Burg.
2457
2458         * Configurations/FeatureDefines.xcconfig:
2459
2460 2014-10-23  Tim Horton  <timothy_horton@apple.com>
2461
2462         Add some SPI headers for NSExtension and NSSharingService{Picker}
2463         https://bugs.webkit.org/show_bug.cgi?id=138027
2464
2465         Reviewed by Anders Carlsson.
2466
2467         * Misc/WebSharingServicePickerController.h:
2468         * Misc/WebSharingServicePickerController.mm:
2469         * WebCoreSupport/WebSelectionServiceController.mm:
2470         * WebCoreSupport/WebContextMenuClient.mm:
2471         Fix a sorting issue.
2472         Replace redefinitions with SPI header #imports.
2473
2474 2014-10-23  Tim Horton  <timothy_horton@apple.com>
2475
2476         Crashes under WebSelectionServiceController::hasRelevantSelectionServices
2477         https://bugs.webkit.org/show_bug.cgi?id=138013
2478
2479         Reviewed by Dan Bernstein.
2480
2481         * WebCoreSupport/WebSelectionServiceController.mm:
2482         (WebSelectionServiceController::hasRelevantSelectionServices):
2483         Don't adopt this autoreleased object.
2484
2485 2014-10-22  Chris Dumez  <cdumez@apple.com>
2486
2487         [Mac][WK2] Fix applicationIsSafari() detection
2488         https://bugs.webkit.org/show_bug.cgi?id=137893
2489
2490         Reviewed by Alexey Proskuryakov.
2491
2492         Provide an implementation for FrameLoaderClient's new
2493         needsQuickLookResourceCachingQuirks() that returns
2494         a static flag initialized using
2495         QuickLookMac::computeNeedsQuickLookResourceCachingQuirks().
2496
2497         * WebCoreSupport/WebFrameLoaderClient.h:
2498         * WebCoreSupport/WebFrameLoaderClient.mm:
2499
2500 2014-10-20  Chris Dumez  <cdumez@apple.com>
2501
2502         ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition
2503         https://bugs.webkit.org/show_bug.cgi?id=137797
2504
2505         Reviewed by Darin Adler.
2506
2507         Call ResourceRequest::setDomainForPartitionName() instead of
2508         setPartitionName() as the argument is a domain, not a valid
2509         partition name.
2510
2511         * Misc/WebCache.mm:
2512         (+[WebCache addImageToCache:forURL:forFrame:]):
2513         (+[WebCache removeImageFromCacheForURL:forFrame:]):
2514
2515 2014-10-20  Andy Estes  <aestes@apple.com>
2516
2517         Fix the iOS build.
2518
2519         * WebView/WebFrame.mm:
2520         (-[WebFrame getDictationResultRanges:andMetadatas:]):
2521         (-[WebFrame dictationResultMetadataForRange:]):
2522
2523 2014-10-19  Chris Dumez  <cdumez@apple.com>
2524
2525         Use is<>() / downcast<>() for all remaining RenderObject subclasses
2526         https://bugs.webkit.org/show_bug.cgi?id=137845
2527
2528         Reviewed by Darin Adler.
2529
2530         Use is<>() / downcast<>() for all remaining RenderObject subclasses and 
2531         clean up the surrounding code.
2532
2533         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2534         (-[WebHostedNetscapePluginView pluginHostDied]):
2535         * Plugins/WebBaseNetscapePluginView.mm:
2536         (-[WebBaseNetscapePluginView _windowClipRect]):
2537         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
2538         * WebCoreSupport/WebFrameLoaderClient.mm:
2539         (WebFrameLoaderClient::createPlugin):
2540         (WebFrameLoaderClient::createJavaAppletWidget):
2541
2542 2014-10-17  Tim Horton  <timothy_horton@apple.com>
2543
2544         Build fix for 32-bit Yosemite
2545
2546         * WebCoreSupport/WebContextMenuClient.mm:
2547         (WebContextMenuClient::contextMenuForEvent):
2548         Avoid using NSItemProvider in 32-bit, because it doesn't exist.
2549
2550 2014-10-17  Chris Dumez  <cdumez@apple.com>
2551
2552         Use is<>() / downcast<>() for RenderBox
2553         https://bugs.webkit.org/show_bug.cgi?id=137804
2554
2555         Reviewed by Andreas Kling.
2556
2557         Use is<>() / downcast<>() for RenderBox and clean up the surrounding
2558         code.
2559
2560         * WebCoreSupport/WebContextMenuClient.mm:
2561         (WebContextMenuClient::clientFloatRectForNode):
2562         * WebView/WebFrame.mm:
2563         (-[WebFrame renderedSizeOfNode:constrainedToWidth:]):
2564
2565 2014-10-17  Tim Horton  <timothy_horton@apple.com>
2566
2567         Fix the build with the public SDK.
2568
2569         * WebCoreSupport/WebSelectionServiceController.mm:
2570         We should transition all this SPI to real SPI headers as soon as possible.
2571
2572 2014-10-16  Tim Horton  <timothy_horton@apple.com>
2573
2574         Implement selection services menu for Legacy WebKit
2575         https://bugs.webkit.org/show_bug.cgi?id=137582
2576         <rdar://problem/18604241>
2577
2578         Reviewed by Brady Eidson.
2579
2580         * Misc/WebSharingServicePickerController.h:
2581         Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
2582         Add WebSharingServicePickerClient, which other classes can implement
2583         instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
2584         Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.
2585
2586         * Misc/WebSharingServicePickerController.mm:
2587         Pass in NSSharingServicePickerStyle, so that clients can specify the style.
2588
2589         (-[WebSharingServicePickerController clear]):
2590         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
2591         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
2592         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
2593         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
2594         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2595         Make use of WebSharingServicePickerClient.
2596
2597         (-[WebSharingServicePickerController sharingService:didShareItems:]):
2598         If we're returned a NSAttributedString, paste it on top of the current selection,
2599         similar to what the WebKit2 implementation currently does.
2600         
2601         * WebCoreSupport/WebChromeClient.h:
2602         * WebCoreSupport/WebChromeClient.mm:
2603         (WebChromeClient::handleTelephoneNumberClick):
2604         (WebChromeClient::handleSelectionServiceClick):
2605         (WebChromeClient::hasRelevantSelectionServices):
2606         Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.
2607
2608         * WebCoreSupport/WebContextMenuClient.h:
2609         * WebCoreSupport/WebContextMenuClient.mm:
2610         (WebContextMenuClient::sharingServicePickerWillBeDestroyed):
2611         (WebContextMenuClient::pageForSharingServicePicker):
2612         (WebContextMenuClient::windowForSharingServicePicker):
2613         (WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
2614         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
2615         (WebContextMenuClient::contextMenuForEvent):
2616         (WebContextMenuClient::screenRectForHitTestNode): Deleted.
2617         (WebContextMenuClient::renderedImageForControlledImage): Deleted.
2618         (WebContextMenuClient::clearSharingServicePickerController): Deleted.
2619         Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
2620         having WebSharingServicePickerController tightly bound to it.
2621         Make an NSItemProvider array when instantiating WebSharingServicePickerController
2622         instead of handing it data directly.
2623
2624         * WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
2625         * WebCoreSupport/WebSelectionServiceController.mm: Added.
2626         (WebSelectionServiceController::WebSelectionServiceController):
2627         Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
2628         for selection services.
2629
2630         (WebSelectionServiceController::handleSelectionServiceClick):
2631         Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.
2632
2633         (hasCompatibleServicesForItems):
2634         (WebSelectionServiceController::hasRelevantSelectionServices):
2635         Determine whether or not services are available.
2636
2637         (WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
2638         (WebSelectionServiceController::pageForSharingServicePicker):
2639         (WebSelectionServiceController::windowForSharingServicePicker):
2640         Implement the rest of the WebSharingServicePickerClient overrides.
2641
2642         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
2643         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
2644         These are only useful for image sharing services, so we don't need to
2645         implement them (WebContextMenuClient does, on the other hand).
2646
2647         * WebView/WebView.mm:
2648         (-[WebView _selectionServiceController]):
2649         * WebView/WebViewData.h:
2650         * WebView/WebViewData.mm:
2651         * WebView/WebViewInternal.h:
2652         Keep a WebSelectionServiceController.
2653
2654 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2655
2656         Improve debug description of WAKViews
2657         https://bugs.webkit.org/show_bug.cgi?id=137716
2658
2659         Reviewed by Simon Fraser.
2660
2661         * WebView/WebView.mm:
2662         (-[WebView _touchEventRegions]): Adding a comment.
2663
2664 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2665
2666         Addressing post-review comment.
2667         https://bugs.webkit.org/show_bug.cgi?id=137550
2668
2669         Unreviewed.
2670
2671         * WebView/WebHTMLView.mm:
2672         (fontNameForDescription):
2673         (-[WebHTMLView _addToStyle:fontA:fontB:]):
2674
2675 2014-10-14  Chris Dumez  <cdumez@apple.com>
2676
2677         Use is<>() / downcast<>() for RenderImage
2678         https://bugs.webkit.org/show_bug.cgi?id=137683
2679
2680         Reviewed by Mihnea Ovidenie.
2681
2682         Use is<>() / downcast<>() for RenderImage.
2683
2684         * Misc/WebNSPasteboardExtras.mm:
2685         (imageFromElement):
2686         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2687
2688 2014-10-10  Daniel Bates  <dabates@apple.com>
2689
2690         Remove unused classes WebRender{Node, Layer}
2691         https://bugs.webkit.org/show_bug.cgi?id=137628
2692
2693         Reviewed by Simon Fraser.
2694
2695         We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
2696         For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.
2697
2698         * Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list
2699         of excluded source files when building for iOS.
2700         * WebKit.exp: Remove symbol for WebRenderLayer.
2701         * WebKit.mac.exp: Remove symbol for WebRenderNode.
2702         * WebView/WebRenderLayer.h: Removed.
2703         * WebView/WebRenderLayer.mm: Removed.
2704         * WebView/WebRenderNode.h: Removed.
2705         * WebView/WebRenderNode.mm: Removed.
2706
2707 2014-10-10  Chris Dumez  <cdumez@apple.com>
2708
2709         Use is<>() / downcast<>() for RenderBoxModelObject
2710         https://bugs.webkit.org/show_bug.cgi?id=137587
2711
2712         Reviewed by Mihnea Ovidenie.
2713
2714         Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
2715         surrounding code.
2716
2717         * Plugins/WebBaseNetscapePluginView.mm:
2718         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
2719         * WebView/WebRenderLayer.mm:
2720         (-[WebRenderLayer initWithWebFrame:]):
2721
2722 2014-10-09  Dean Jackson  <dino@apple.com>
2723
2724         Remove ENABLE_CSS3_CONDITIONAL_RULES
2725         https://bugs.webkit.org/show_bug.cgi?id=137571
2726
2727         Reviewed by Simon Fraser.
2728
2729         * Configurations/FeatureDefines.xcconfig:
2730
2731 2014-10-09  Tim Horton  <timothy_horton@apple.com>
2732
2733         Add a WebKit1 preference for selection services
2734         https://bugs.webkit.org/show_bug.cgi?id=137498
2735         <rdar://problem/18572699>
2736
2737         Reviewed by Simon Fraser.
2738
2739         * WebView/WebPreferenceKeysPrivate.h:
2740         * WebView/WebPreferences.mm:
2741         (+[WebPreferences initialize]):
2742         (-[WebPreferences serviceControlsEnabled]):
2743         (-[WebPreferences setServiceControlsEnabled:]):
2744         * WebView/WebPreferencesPrivate.h:
2745         * WebView/WebView.mm:
2746         (-[WebView _preferencesChanged:]):
2747         Add and plumb the preference.
2748
2749 2014-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
2750
2751         Remove second-to-last client of WebFontCache
2752         https://bugs.webkit.org/show_bug.cgi?id=137550
2753
2754         Reviewed by Darin Adler.
2755
2756         Use FontCache::getCachedFontData() instead of WebFontCache.
2757
2758         * WebView/WebHTMLView.mm:
2759         (-[WebHTMLView _addToStyle:fontA:fontB:]):
2760
2761 2014-10-09  Chris Dumez  <cdumez@apple.com>
2762
2763         Use is<>() / downcast<>() for Widget subclasses
2764         https://bugs.webkit.org/show_bug.cgi?id=137549
2765
2766         Reviewed by Darin Adler.
2767
2768         Use is<>() / downcast<>() for Widget subclasses and clean up the
2769         surrounding code.
2770
2771         * WebView/WebRenderNode.mm:
2772         (copyRenderNode):
2773         * WebView/WebView.mm:
2774         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
2775
2776 2014-10-07  Christophe Dumez  <cdumez@apple.com>
2777
2778         Use is<>() / downcast<>() for RenderText / RenderTextFragment
2779         https://bugs.webkit.org/show_bug.cgi?id=137476
2780
2781         Reviewed by Darin Adler.
2782
2783         * WebView/WebRenderNode.mm:
2784         (copyRenderNode):
2785
2786 2014-10-06  Dan Bernstein  <mitz@apple.com>
2787
2788         Build fix.
2789
2790         * Misc/WebCache.mm:
2791         (+[WebCache imageForURL:]):
2792
2793 2014-10-06  Chris Dumez  <cdumez@apple.com>
2794
2795         Unreviewed build fix after r174333.
2796
2797         Forgot explicit WebCore:: namespace.
2798
2799         * Misc/WebCache.mm:
2800         (+[WebCache imageForURL:]):
2801
2802 2014-10-05  Christophe Dumez  <cdumez@apple.com>
2803
2804         Use is<>() / downcast<>() for CachedResource subclasses
2805         https://bugs.webkit.org/show_bug.cgi?id=137431
2806
2807         Reviewed by Benjamin Poulain.
2808
2809         Use is<>() / downcast<>() for CachedResource subclasses.
2810
2811         * Misc/WebCache.mm:
2812         (+[WebCache imageForURL:]):
2813
2814 2014-10-02  Daniel Bates  <dabates@apple.com>
2815
2816         Use version number 101000 instead of 10100 for OS X Yosemite
2817         https://bugs.webkit.org/show_bug.cgi?id=137372
2818
2819         Reviewed by Mark Rowe.
2820
2821         The version number for OS X Yosemite is 101000.
2822
2823         * WebView/WebView.mm:
2824         (-[WebView _preferencesChanged:]):
2825
2826 2014-10-02  Tim Horton  <timothy_horton@apple.com>
2827
2828         Move PageOverlay[Controller] to WebCore
2829         https://bugs.webkit.org/show_bug.cgi?id=137164
2830         <rdar://problem/18508258>
2831
2832         Reviewed by Anders Carlsson.
2833
2834         * WebCoreSupport/WebChromeClient.h:
2835         * WebCoreSupport/WebChromeClient.mm:
2836         (WebChromeClient::attachViewOverlayGraphicsLayer):
2837         Add an empty ChromeClient override.
2838
2839 2014-10-01  Christophe Dumez  <cdumez@apple.com>
2840
2841         Have is<>(T*) function do a null check on the pointer argument
2842         https://bugs.webkit.org/show_bug.cgi?id=137333
2843
2844         Reviewed by Gavin Barraclough.
2845
2846         Have is<>(T*) function do a null check on the argument instead of a
2847         simple assertion. This makes sense for 2 reasons:
2848         1. It is more consistent with downcast<>(T*), which will succeed even
2849            if the argument is a nullptr.
2850         2. It simplifies the code a bit as it gets rid of a lot of explicit
2851            null checks.
2852
2853         * WebCoreSupport/WebChromeClient.mm:
2854         (WebChromeClient::focusedElementChanged):
2855         * WebCoreSupport/WebEditorClient.mm:
2856         (WebEditorClient::textFieldDidBeginEditing):
2857         (WebEditorClient::textFieldDidEndEditing):
2858         (WebEditorClient::textDidChangeInTextField):
2859         (WebEditorClient::doTextFieldCommandFromEvent):
2860         (WebEditorClient::textWillBeDeletedInTextField):
2861         (WebEditorClient::textDidChangeInTextArea):
2862         * WebView/WebHTMLRepresentation.mm:
2863         (inputElementFromDOMElement):
2864         (searchForLabelsBeforeElement):
2865         * WebView/WebRenderLayer.mm:
2866         (+[WebRenderLayer nameForLayer:]):
2867
2868 2014-10-01  Mark Rowe  <mrowe@apple.com>
2869
2870         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
2871
2872         Reviewed by Dan Bernstein.
2873
2874         * Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite.
2875
2876 2014-09-30  Chris Dumez  <cdumez@apple.com>
2877
2878         Use is<>() / downcast<>() for Element
2879         https://bugs.webkit.org/show_bug.cgi?id=137241
2880
2881         Reviewed by Andreas Kling.
2882
2883         Use is<>() / downcast<>() for Element instead of isElementNode() /
2884         toElement().
2885
2886         * WebView/WebRenderLayer.mm:
2887         (+[WebRenderLayer nameForLayer:]):
2888
2889 2014-09-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2890
2891         Move ColorInputType class to std::unique_ptr
2892         https://bugs.webkit.org/show_bug.cgi?id=137173
2893
2894         Reviewed by Darin Adler.
2895
2896         Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr.
2897         Child classes follow this change as well.
2898
2899         * WebCoreSupport/WebChromeClient.h:
2900         * WebCoreSupport/WebChromeClient.mm:
2901         (WebChromeClient::createColorChooser):
2902
2903 2014-09-24  Christophe Dumez  <cdumez@apple.com>
2904
2905         Add initial is<>() / downcast<>() support for any type of Nodes
2906         https://bugs.webkit.org/show_bug.cgi?id=137056
2907
2908         Reviewed by Benjamin Poulain.
2909
2910         Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
2911         instead of isFormControlElement() / toHTMLFormControlElement().
2912
2913         * WebView/WebHTMLRepresentation.mm:
2914         (searchForLabelsBeforeElement):
2915
2916 2014-09-24  Christophe Dumez  <cdumez@apple.com>
2917
2918         Use is<HTML*Element>() instead of isHTML*Element() - Part 1
2919         https://bugs.webkit.org/show_bug.cgi?id=137068
2920
2921         Reviewed by Ryosuke Niwa.
2922
2923         Start using is<HTML*Element>() instead of isHTML*Element().
2924         Remaining usages will be updated in a follow-up patch to
2925         reduce the size of the change.
2926
2927         * WebCoreSupport/WebChromeClient.mm:
2928         (WebChromeClient::focusedElementChanged):
2929         * WebCoreSupport/WebEditorClient.mm:
2930         (WebEditorClient::textFieldDidBeginEditing):
2931         (WebEditorClient::textFieldDidEndEditing):
2932         (WebEditorClient::textDidChangeInTextField):
2933         (WebEditorClient::doTextFieldCommandFromEvent):
2934         (WebEditorClient::textWillBeDeletedInTextField):
2935         (WebEditorClient::textDidChangeInTextArea):
2936         * WebView/WebHTMLRepresentation.mm:
2937         (inputElementFromDOMElement):
2938
2939 2014-09-21  Timothy Hatcher  <timothy@apple.com>
2940
2941         Make the Web Inspector use a separate web process.
2942
2943         https://bugs.webkit.org/show_bug.cgi?id=135120
2944
2945         Reviewed by Anders Carlsson.
2946
2947         * WebCoreSupport/WebInspectorClient.h:
2948         * WebCoreSupport/WebInspectorClient.mm:
2949         (WebInspectorClient::WebInspectorClient):
2950         (WebInspectorClient::openInspectorFrontend):
2951         (WebInspectorClient::releaseFrontend):
2952         Own WebInspectorFrontendClient instead of moving it.
2953
2954 2014-09-23  Chris Dumez  <cdumez@apple.com>
2955
2956         Use downcast<HTML*Element>() instead of toHTML*Element()
2957         https://bugs.webkit.org/show_bug.cgi?id=137007
2958
2959         Reviewed by Benjamin Poulain.
2960
2961         Use downcast<HTML*Element>() instead of toHTML*Element().
2962
2963         * DOM/WebDOMOperations.mm:
2964         (-[DOMHTMLInputElement _setAutofilled:]):
2965         * WebCoreSupport/WebChromeClient.mm:
2966         (WebChromeClient::focusedElementChanged):
2967         * WebCoreSupport/WebEditorClient.mm:
2968         (WebEditorClient::textFieldDidBeginEditing):
2969         (WebEditorClient::textFieldDidEndEditing):
2970         (WebEditorClient::textDidChangeInTextField):
2971         (WebEditorClient::doTextFieldCommandFromEvent):
2972         (WebEditorClient::textWillBeDeletedInTextField):
2973         (WebEditorClient::textDidChangeInTextArea):
2974         * WebView/WebHTMLRepresentation.mm:
2975         (inputElementFromDOMElement):
2976
2977 2014-09-21  Chris Dumez  <cdumez@apple.com>
2978
2979         Generate Element casting helper functions
2980         https://bugs.webkit.org/show_bug.cgi?id=136839
2981
2982         Reviewed by Darin Adler.
2983
2984         Use JSXXX::toWrapped() instead of toXXX() function.
2985
2986         * DOM/WebDOMOperations.mm:
2987         * WebView/WebView.mm:
2988         (-[WebView _notificationIDForTesting:]):
2989
2990 2014-09-21  Joseph Pecoraro  <pecoraro@apple.com>
2991
2992         Leak: WebNotificationPrivate ObjC leaks seen on leaks bot
2993         https://bugs.webkit.org/show_bug.cgi?id=136972
2994
2995         Reviewed by Darin Adler.
2996
2997         * WebView/WebNotification.h:
2998         * WebView/WebNotification.mm:
2999         (-[WebNotification initWithCoreNotification:notificationID:]):
3000         Switch to RetainPtr and adopt into _private to ensure when we are
3001         deallocated that _private will get deallocated.
3002
3003 2014-09-19  Dean Jackson  <dino@apple.com>
3004
3005         Multithreaded WebGL is a bad idea - remove it
3006         https://bugs.webkit.org/show_bug.cgi?id=136964
3007         <rdar://problem/18399858>
3008
3009         Reviewed by Brent Fulgham.
3010
3011         Remove the setting to allow multithreaded WebGL.
3012
3013         * WebView/WebPreferenceKeysPrivate.h:
3014         * WebView/WebPreferences.mm:
3015         (+[WebPreferences initialize]):
3016         (-[WebPreferences multithreadedWebGLEnabled]): Deleted.
3017         (-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted.
3018         * WebView/WebPreferencesPrivate.h:
3019         * WebView/WebView.mm:
3020         (-[WebView _preferencesChanged:]):
3021
3022 2014-09-19  Daniel Bates  <dabates@apple.com>
3023
3024         Always assume internal SDK when building configuration Production
3025         https://bugs.webkit.org/show_bug.cgi?id=136925
3026         <rdar://problem/18362399>
3027
3028         Reviewed by Dan Bernstein.
3029
3030         As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
3031         and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.
3032
3033         * Configurations/Base.xcconfig:
3034
3035 2014-09-17  Daniel Bates  <dabates@apple.com>
3036
3037         Unreviewed, rolling out r173695.
3038
3039         Broke building third-party Legacy WebKit apps; will
3040         investigate offline
3041
3042         Reverted changeset:
3043
3044         "[iOS] Make WebCore build with public iOS SDK"
3045         https://bugs.webkit.org/show_bug.cgi?id=136487
3046         http://trac.webkit.org/changeset/173695
3047
3048 2014-09-17  Daniel Bates  <dabates@apple.com>
3049
3050         [iOS] Make WebCore build with public iOS SDK
3051         https://bugs.webkit.org/show_bug.cgi?id=136487
3052
3053         Reviewed by David Kilzer.
3054
3055         Update WebKit1 source files to include the wrapper SPI headers instead of the corresponding
3056         actual SPI header(s).
3057
3058         * DOM/WebDOMOperationsPrivate.h:
3059         * MigrateHeaders.make: Modified to only modify the include path of a "<WebCore/"-prefixed header
3060         file if its filename doesn't end in "SPI.h" as an alternative to having MigrateHeaders.make copy
3061         such files into the WebKit framework as private headers.
3062         * WebCoreSupport/WebFrameLoaderClient.mm:
3063         * WebInspector/WebNodeHighlight.mm:
3064         * WebView/WebIndicateLayer.mm:
3065         * WebView/WebRenderLayer.h:
3066         * WebView/WebView.mm:
3067
3068 2014-09-16  Daniel Bates  <dabates@apple.com>
3069
3070         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
3071         https://bugs.webkit.org/show_bug.cgi?id=136862
3072
3073         Reviewed by David Kilzer.
3074
3075         * Configurations/DebugRelease.xcconfig:
3076
3077 2014-09-16  Enrica Casucci  <enrica@apple.com>
3078
3079         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
3080         https://bugs.webkit.org/show_bug.cgi?id=136474
3081
3082         Reviewed by Benjamin Poulain.
3083
3084         This is the updated version of the patch that was landed in r173340.
3085         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
3086         and removes the assumption that EAffinity values match NSSelectionAffinity
3087         values. It also removes the includes in TextAffinity.h, creating the need to
3088         include explicitly the files when necessary.
3089
3090         * WebCoreSupport/WebEditorClient.h:
3091         (kit):
3092         (core):
3093
3094 2014-09-14  Daniel Bates  <dabates@apple.com>
3095
3096         [iOS] Attempt to fix the iOS build after <http://trac.webkit.org/changeset/173606>
3097         (https://bugs.webkit.org/show_bug.cgi?id=136789)
3098
3099         Substitute Node::countChildNodes() for Node::childNodeCount() in more places.
3100
3101         * WebView/WebFrame.mm:
3102         (-[WebFrame focusedNodeHasContent]):
3103
3104 2014-09-14  Chris Dumez  <cdumez@apple.com>
3105
3106         Rename Node::childNodeCount() to countChildNodes() and avoid inefficient uses
3107         https://bugs.webkit.org/show_bug.cgi?id=136789
3108
3109         Reviewed by Darin Adler.
3110
3111         Rename childNodeCount() to countChildNodes().
3112
3113         * WebView/WebHTMLView.mm:
3114         (-[WebHTMLView attributedString]):
3115
3116 2014-09-10  Jon Honeycutt  <jhoneycutt@apple.com>
3117
3118         Re-add the request autocomplete feature
3119
3120         <https://bugs.webkit.org/show_bug.cgi?id=136730>
3121
3122         This feature was rolled out in r148731 because it was only used by
3123         Chromium. As we consider supporting this feature, roll it back in, but
3124         leave it disabled.
3125
3126         This rolls out r148731 (which removed the feature) with small changes
3127         needed to make the code build in ToT, to match modern style, to make
3128         the tests run, and to remove unused code.
3129
3130         Reviewed by Andy Estes.
3131
3132         * Configurations/FeatureDefines.xcconfig:
3133         * WebCoreSupport/WebFrameLoaderClient.h:
3134
3135 2014-09-12  Commit Queue  <commit-queue@webkit.org>
3136
3137         Unreviewed, rolling out r173575.
3138         https://bugs.webkit.org/show_bug.cgi?id=136790
3139
3140         Failing tests (Requested by enrica on #webkit).
3141
3142         Reverted changeset:
3143
3144         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
3145         https://bugs.webkit.org/show_bug.cgi?id=136474
3146         http://trac.webkit.org/changeset/173575
3147
3148 2014-09-12  Enrica Casucci  <enrica@apple.com>
3149
3150         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
3151         https://bugs.webkit.org/show_bug.cgi?id=136474
3152
3153         Reviewed by Benjamin Poulain.
3154
3155         This is the updated version of the patch that was landed in r173340.
3156         I changed the use of IntPoint to FloatPoint since it was causing tests
3157         to fail.
3158         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
3159         and removes the assumption that EAffinity values match NSSelectionAffinity
3160         values. It also removes the includes in TextAffinity.h, creating the need to
3161         include explicitly the files when necessary. It also removes the unnecessary
3162         use of platform specific types, replacing them with WebCore types.
3163
3164         * WebCoreSupport/WebEditorClient.h:
3165         (kit):
3166         (core):
3167         * WebView/WebFrameView.mm:
3168         (-[WebFrameView _scrollToBeginningOfDocument]):
3169         (-[WebFrameView _scrollToEndOfDocument]):
3170
3171 2014-09-11  Bear Travis  <betravis@adobe.com>
3172
3173         [CSS Font Loading] Enable CSS Font Loading on Mac
3174         https://bugs.webkit.org/show_bug.cgi?id=135473
3175
3176         Reviewed by Antti Koivisto.
3177
3178         Enable CSS Font Loading in FeatureDefines.
3179
3180         * Configurations/FeatureDefines.xcconfig:
3181
3182 2014-09-11  Beth Dakin  <bdakin@apple.com>
3183
3184         Support rubber-banding in sub-frames
3185         https://bugs.webkit.org/show_bug.cgi?id=136726
3186         -and corresponding-
3187         rdar://problem/10011924
3188
3189         Reviewed by Tim Horton.
3190
3191         rubberBandingForOverflowScrollEnabled is re-named to
3192         rubberBandingForSubScrollableRegionsEnabled
3193         * WebView/WebView.mm:
3194         (-[WebView _preferencesChanged:]):
3195
3196 2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
3197
3198         Disable the "unreachable-code" warning
3199         https://bugs.webkit.org/show_bug.cgi?id=136677
3200
3201         Reviewed by Darin Adler.
3202
3203         * Configurations/Base.xcconfig:
3204
3205 2014-09-08  Maciej Stachowiak  <mjs@apple.com>
3206
3207         Fix 32-bit Mac build for new warnings
3208         https://bugs.webkit.org/show_bug.cgi?id=136624
3209
3210         Reviewed by Darin Adler.
3211         
3212         (Jessie already fixed this but my version with typedefs seems a tiny bit cleaner.)
3213
3214         * Carbon/HIViewAdapter.m:
3215         (+[HIViewAdapter bindHIViewToNSView:nsView:]): Need to use explicit casting now.
3216
3217 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3218
3219         Remove FILTERS flag
3220         https://bugs.webkit.org/show_bug.cgi?id=136571
3221
3222         Reviewed by Darin Adler.
3223
3224         * Configurations/FeatureDefines.xcconfig:
3225
3226 2014-09-08  Jessie Berlin  <jberlin@apple.com>
3227
3228         32-bit build fix after r173364.
3229
3230         * Carbon/HIViewAdapter.m:
3231         (+[HIViewAdapter bindHIViewToNSView:nsView:]):
3232
3233 2014-09-08  Dan Bernstein  <mitz@apple.com>
3234
3235         Build fix.
3236
3237         Added back SPI that is still in use.
3238
3239         * Misc/WebNSURLExtras.h:
3240         * Misc/WebNSURLExtras.mm:
3241         (-[NSURL _webkit_URLByRemovingFragment]):
3242
3243 2014-09-08  Dan Bernstein  <mitz@apple.com>
3244
3245         iOS Simulator build fix.
3246
3247         * Misc/WebKitSystemBits.m:
3248         (WebMemorySize):
3249
3250 2014-09-07  Darin Adler  <darin@apple.com>
3251
3252         Fix build failure seen on Mountain Lion buildbot.
3253
3254         * Misc/WebNSDataExtras.h: Make WEB_GUESS_MIME_TYPE_PEEK_LENGTH an unsigned instead
3255         of an int, to avoid warning about mixing signs.
3256
3257 2014-09-06  Darin Adler  <darin@apple.com>
3258
3259         Make updates suggested by new version of Xcode
3260         https://bugs.webkit.org/show_bug.cgi?id=136603
3261
3262         Reviewed by Mark Rowe.
3263
3264         * Configurations/Base.xcconfig: Added CLANG_WARN_UNREACHABLE_CODE, COMBINE_HIDPI_IMAGES,
3265         and ENABLE_STRICT_OBJC_MSGSEND as suggested by Xcode upgrade check.
3266
3267         * History/WebURLsWithTitles.m:
3268         (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): Use NSUInteger instead of
3269         unsigned for correctness, and to quiet the 32-to-64-bit compiler warning (which is
3270         not turned on because it gives us too many false positives).
3271         * Misc/WebElementDictionary.mm:
3272         (-[WebElementDictionary objectForKey:]): Ditto.
3273         * Misc/WebNSDataExtras.m:
3274         (-[NSData _webkit_guessedMIMETypeForXML]): Ditto.
3275         (-[NSData _webkit_guessedMIMEType]): Ditto.
3276         (-[NSData _webkit_parseRFC822HeaderFields]): Ditto.
3277         (-[NSData _web_locationAfterFirstBlankLine]): Ditto.
3278
3279         * Misc/WebNSURLExtras.h: Removed unused _web_URLWithLowercasedScheme, _web_hostData,
3280         _webkit_URLByRemovingFragment, _webkit_URLByRemovingResourceSpecifier, _webkit_isFTPDirectoryURL,
3281         _webkit_shouldLoadAsEmptyDocument, _web_hostNameNeedsDecodingWithRange:,
3282         _web_hostNameNeedsEncodingWithRange:, _web_decodeHostNameWithRange:, _web_encodeHostNameWithRange:,
3283         and _webkit_URLFragment methods.
3284
3285         * Misc/WebNSURLExtras.mm:
3286         (-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): Deleted.
3287         (-[NSURL _webkit_URLByRemovingFragment]): Deleted.
3288         (-[NSURL _webkit_URLByRemovingResourceSpecifier]): Deleted.
3289         (-[NSURL _webkit_isFTPDirectoryURL]): Deleted.
3290         (-[NSURL _webkit_shouldLoadAsEmptyDocument]): Deleted.
3291         (-[NSURL _web_URLWithLowercasedScheme]): Deleted.
3292         (-[NSString _webkit_isFTPDirectoryURL]): Deleted.
3293         (-[NSString _web_hostNameNeedsDecodingWithRange:]): Deleted.
3294         (-[NSString _web_hostNameNeedsEncodingWithRange:]): Deleted.
3295         (-[NSString _web_decodeHostNameWithRange:]): Deleted.
3296         (-[NSString _web_encodeHostNameWithRange:]): Deleted.
3297         (-[NSString _webkit_URLFragment]): Deleted.
3298
3299         * Plugins/WebPluginDatabase.mm:
3300         (-[WebPluginDatabase removePluginInstanceViewsFor:]): Use a modern for loop
3301         to iterate an array instead of a loop using the type "unsigned int".
3302
3303         * WebCoreSupport/WebOpenPanelResultListener.mm:
3304         (-[WebOpenPanelResultListener chooseFilenames:]): Use NSUInteger instead of int.
3305
3306         * WebView/WebDelegateImplementationCaching.mm:
3307         (CallDelegate): Use wtfCallIMP in one overload that was instead just calling the
3308         directly without a proper type for the function pointer. This might have been causing
3309         an actual problem on 64-bit systems, and it was different from all the other CallDelegate
3310         functions that were already doing this correctly.
3311
3312         * WebView/WebTextCompletionController.mm:
3313         (-[WebTextCompletionController _placePopupWindow:]): Use NSUInteger instead of int.
3314
3315 2014-09-06  Brian J. Burg  <burg@cs.washington.edu>
3316
3317         Web Inspector: convert DockSide to an enum class
3318         https://bugs.webkit.org/show_bug.cgi?id=136601
3319
3320         Reviewed by Timothy Hatcher.
3321
3322         * WebCoreSupport/WebInspectorClient.mm:
3323         (WebInspectorFrontendClient::frontendLoaded):
3324         (-[WebInspectorWindowController attachWindow:]):
3325         (-[WebInspectorWindowController attach]):
3326         (-[WebInspectorWindowController detach]):
3327         * WebInspector/WebInspectorFrontend.mm:
3328         (-[WebInspectorFrontend attach]):
3329
3330 2014-09-05  Commit Queue  <commit-queue@webkit.org>
3331
3332         Unreviewed, rolling out r173340 and r173342.
3333         https://bugs.webkit.org/show_bug.cgi?id=136596
3334
3335         Broke many tests (Requested by ap on #webkit).
3336
3337         Reverted changesets:
3338
3339         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
3340         https://bugs.webkit.org/show_bug.cgi?id=136474
3341         http://trac.webkit.org/changeset/173340
3342
3343         "Build fix after r173340."
3344         http://trac.webkit.org/changeset/173342
3345
3346 2014-09-05  Enrica Casucci  <enrica@apple.com>
3347
3348         Build fix after r173340.
3349
3350         * WebCoreSupport/WebEditorClient.h:
3351         (kit):
3352         (core):
3353
3354 2014-09-05  Enrica Casucci  <enrica@apple.com>
3355
3356         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
3357         https://bugs.webkit.org/show_bug.cgi?id=136474
3358
3359         Reviewed by Benjamin Poulain.
3360
3361         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
3362         and removes the assumption that EAffinity values match NSSelectionAffinity
3363         values. It also removes the includes in TextAffinity.h, creating the need to
3364         include explicitly the files when necessary. It also removes the unnecessary
3365         use of platform specific types, replacing them with WebCore types.
3366
3367         * WebCoreSupport/WebEditorClient.h: Added kit and core for EAffinity.
3368         * WebView/WebFrameView.mm:
3369         (-[WebFrameView _scrollToBeginningOfDocument]):
3370         (-[WebFrameView _scrollToEndOfDocument]):
3371
3372 2014-09-05  Daniel Bates  <dabates@apple.com>
3373
3374         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
3375         (https://bugs.webkit.org/show_bug.cgi?id=136564)
3376
3377         Move #endif inside -viewDidMoveToWindow up one line such that the closing brace ('}') is after it.
3378
3379         * WebView/WebHTMLView.mm:
3380         (-[WebHTMLView viewDidMoveToWindow]):
3381
3382 2014-09-05  Daniel Bates  <dabates@apple.com>
3383
3384         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
3385         (https://bugs.webkit.org/show_bug.cgi?id=136564)
3386
3387         Add !PLATFORM(IOS)-guard in -viewDidMoveToWindow around code that references WebHTMLViewPrivate.flagsChangedEventMonitor.
3388         The instance variable WebHTMLViewPrivate.flagsChangedEventMonitor is guarded by !PLATFORM(IOS).
3389
3390         * WebView/WebHTMLView.mm:
3391         (-[WebHTMLView viewDidMoveToWindow]):
3392
3393 2014-09-05  Daniel Bates  <dabates@apple.com>
3394
3395         [iOS] Fix the iOS build after <http://trac.webkit.org/changeset/173309>
3396         (https://bugs.webkit.org/show_bug.cgi?id=136564)
3397
3398         Include more code inside the !PLATFORM(IOS)-guarded section in -setDataSource:.
3399
3400         * WebView/WebHTMLView.mm:
3401         (-[WebHTMLView setDataSource:]):
3402
3403 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
3404
3405         Use tracking areas instead of (SPI) mouse moved notifications, and follow flags changes with an event monitor
3406         https://bugs.webkit.org/show_bug.cgi?id=136564
3407
3408         Reviewed by Dan Bernstein.
3409         
3410         WebKit1 depended on mouse moved event notifications to track mouse
3411         moves, and on being specially called by Safari to track flags
3412         changes. WebKit2 does both these things better - it uses a tracking area
3413         and event monitors. Copy those approaches.
3414
3415         * WebKit.order: Remove reference to obsolete call.
3416         * WebView/WebHTMLView.mm:
3417         (-[WebHTMLViewPrivate dealloc]): No need to deallocate tracking
3418         area, since we now just always have one.
3419         (-[WebHTMLViewPrivate clear]): ditto
3420         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
3421         New method that posts a fake mouse move event in response to
3422         a flags change event, for use by the event monitor.
3423         (+[WebHTMLView _postFlagsChangedEvent:]): Empty this old call,
3424         still kept around for benefit of older Safari.
3425         (-[WebHTMLView _updateMouseoverWithEvent:]): Handle Dashboard's
3426         special mouseover mode (previously handled in a weird way).
3427         (-[WebHTMLView close]): No more need to mess with mouse moved observer.
3428         (-[WebHTMLView viewWillMoveToWindow:]): ditto
3429         (-[WebHTMLView viewDidMoveToWindow]): ditto; but now hook up a flags
3430         changed monitor.
3431         (-[WebHTMLView windowDidBecomeKey:]): No need to handle non-key window
3432         tracking area or mouse moved observer.
3433         (-[WebHTMLView windowDidResignKey:]): ditto
3434         (-[WebHTMLView windowWillOrderOnScreen:]): No need to mess with mouse
3435         moved observer.
3436         (-[WebHTMLView windowWillOrderOffScreen:]): ditto
3437         (-[WebHTMLView mouseMoved:]): Converted from the old mouseMovedNotification:
3438         (-[WebHTMLView setDataSource:]): Change if around body to early return. Hook
3439         up tracking area - we have to do it here, because before this point, the
3440         WebHTMLView does not know its WebView, which is where dashboard settings
3441         live.
3442         (-[WebHTMLView _removeMouseMovedObserverUnconditionally]): Deleted.
3443         (-[WebHTMLView addMouseMovedObserver]): Deleted.
3444         (-[WebHTMLView removeMouseMovedObserver]): Deleted.
3445
3446 2014-09-04  Pratik Solanki  <psolanki@apple.com>
3447
3448         Bring back [WebPreferences setDiskImageCacheEnabled:] for backwards compatibility
3449         https://bugs.webkit.org/show_bug.cgi?id=136560
3450
3451         Reviewed by Joseph Pecoraro.
3452
3453         I removed the disk image caching code in r173265. However, we still have clients that call
3454         setDiskImageCacheEnabled. Add in a stub method until we can wean the clients off this call.
3455
3456         * WebView/WebPreferences.mm:
3457         (-[WebPreferences setDiskImageCacheEnabled:]):
3458         * WebView/WebPreferencesPrivate.h:
3459
3460 2014-09-03  Andy Estes  <aestes@apple.com>
3461
3462         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
3463         https://bugs.webkit.org/show_bug.cgi?id=136521
3464
3465         Reviewed by Anders Carlsson.
3466
3467         Taught MigrateHeaders.make to remove WEBCORE_EXPORT from headers using this sed expression:
3468
3469             s/(^ *)WEBCORE_EXPORT /\1/g
3470
3471         This removes WEBCORE_EXPORT and a single following space character but preserves preceeding spaces.
3472
3473         * MigrateHeaders.make:
3474
3475 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
3476
3477         Remove WebCoreSystemInterface glue for otherwise unused WKSI calls
3478         https://bugs.webkit.org/show_bug.cgi?id=136527
3479
3480         Reviewed by Alexey Proskuryakov.
3481
3482         * WebCoreSupport/WebSystemInterface.mm:
3483         (InitWebCoreSystemInterface):
3484
3485 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3486
3487         Remove CSS_FILTERS flag
3488         https://bugs.webkit.org/show_bug.cgi?id=136529
3489
3490         Reviewed by Dirk Schulze.
3491
3492         * Configurations/FeatureDefines.xcconfig:
3493
3494 2014-09-04  Pratik Solanki  <psolanki@apple.com>
3495
3496         Remove iOS specific disk image cache
3497         https://bugs.webkit.org/show_bug.cgi?id=136517
3498
3499         Reviewed by Antti Koivisto.
3500
3501         Disk image cache code unnecessarily complicates SharedBuffer implementation. We can remove
3502         this now since we don't enable it in WebKit2 on iOS.
3503
3504         * Misc/WebCache.mm:
3505         (+[WebCache statistics]):
3506         * WebView/WebDataSource.mm:
3507         (-[WebDataSource _setAllowToBeMemoryMapped]):
3508         (-[WebDataSource setDataSourceDelegate:]):
3509         (-[WebDataSource dataSourceDelegate]):
3510         (-[WebDataSource dealloc]):
3511         (BufferMemoryMapped): Deleted.
3512         * WebView/WebPreferenceKeysPrivate.h:
3513         * WebView/WebPreferences.mm:
3514         (+[WebPreferences initialize]):
3515         (-[WebPreferences diskImageCacheEnabled]): Deleted.
3516         (-[WebPreferences setDiskImageCacheEnabled:]): Deleted.
3517         (-[WebPreferences diskImageCacheMinimumImageSize]): Deleted.
3518         (-[WebPreferences setDiskImageCacheMinimumImageSize:]): Deleted.
3519         (-[WebPreferences diskImageCacheMaximumCacheSize]): Deleted.
3520         (-[WebPreferences setDiskImageCacheMaximumCacheSize:]): Deleted.
3521         (-[WebPreferences _diskImageCacheSavedCacheDirectory]): Deleted.
3522         (-[WebPreferences _setDiskImageCacheSavedCacheDirectory:]): Deleted.
3523         * WebView/WebPreferencesPrivate.h:
3524         * WebView/WebView.mm:
3525         (-[WebView _commonInitializationWithFrameName:groupName:]):
3526         (+[WebView _handleMemoryWarning]):
3527         (-[WebView _preferencesChanged:]):
3528
3529 2014-09-04  Daniel Bates  <dabates@apple.com>
3530
3531         [iOS] Make iOS build when ENABLE_TOUCH_EVENT and ENABLE_IOS_TOUCH_EVENTS disabled
3532         https://bugs.webkit.org/show_bug.cgi?id=136494
3533
3534         Reviewed by Andy Estes.
3535
3536         * MigrateHeaders.make: Migrate header WebEventRegion.h only when ENABLE_IOS_TOUCH_EVENTS is defined.
3537         * WebView/WebView.mm: Substitute ENABLE(IOS_TOUCH_EVENTS) for ENABLE(TOUCH_EVENTS).
3538
3539 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
3540
3541         Web Inspector: fix prefixes for subclasses of JSC::ConsoleClient
3542         https://bugs.webkit.org/show_bug.cgi?id=136476
3543
3544         Reviewed by Timothy Hatcher.
3545
3546         * Misc/WebCoreStatistics.mm:
3547         (+[WebCoreStatistics shouldPrintExceptions]):
3548         (+[WebCoreStatistics setShouldPrintExceptions:]):
3549
3550 2014-09-03  Enrica Casucci  <enrica@apple.com>
3551
3552         Remove PLATFORM(IOS) from WebCore/editing (Part 1).
3553         https://bugs.webkit.org/show_bug.cgi?id=136474
3554
3555         Reviewed by Tim Horton.
3556
3557         * WebCoreSupport/WebEditorClient.mm:
3558         (undoNameForEditAction):
3559
3560 2014-09-02  Maciej Stachowiak  <mjs@apple.com>
3561
3562         Clean up naming for and slightly refactor legacy video fullscreen support
3563         https://bugs.webkit.org/show_bug.cgi?id=136446
3564
3565         Reviewed by Jer Noble.
3566
3567         Key changes:
3568         supportsFullscreenForNode(Node*) --> supportsVideoFullscreen()
3569         enterFullscreenForNode(Node*) --> enterVideoFullscreenForVideoElement(HTMLVideoElement*)
3570         exitFullscreenForNode(Node*) --> exitVideoFullscreen()
3571         
3572         The old versions had unnecessary parameters, did not clearly distinguish their purpose
3573         from enterFullscreenForElement and friends, and wrongly claimed generality to all Nodes.
3574         Also changed many other places to use HTMLVideoElement* instead of Node* or 
3575         HTMLMediaElement* when they were in fact only used for video elements and would only
3576         work for such.
3577
3578         * WebCoreSupport/WebChromeClient.h:
3579         * WebCoreSupport/WebChromeClient.mm:
3580         (WebChromeClient::supportsVideoFullscreen): Adjust for main refactoring.
3581         Also no more need to check for video elementness.
3582         (WebChromeClient::enterVideoFullscreenForVideoElement): Adjust for main refactoring.
3583         (WebChromeClient::exitVideoFullscreen): ditto
3584         * WebView/WebView.mm:
3585         (-[WebView _enterVideoFullscreenForVideoElement:]): Adjust for main
3586         refactoring.
3587         (-[WebView _exitVideoFullscreen]): ditto
3588         (-[WebView _close]): ditto
3589         * WebView/WebViewInternal.h:
3590
3591 2014-09-03  Dan Bernstein  <mitz@apple.com>
3592
3593         Get rid of HIGH_DPI_CANVAS leftovers
3594         https://bugs.webkit.org/show_bug.cgi?id=136491
3595
3596         Reviewed by Benjamin Poulain.
3597
3598         * Configurations/FeatureDefines.xcconfig: Removed definition of ENABLE_HIGH_DPI_CANVAS
3599         and removed it from FEATURE_DEFINES.
3600
3601 2014-08-31  Tim Horton  <timothy_horton@apple.com>
3602
3603         Remove unnecessary (and unnecessarily iOS-specific) setStrokeAndFillColor
3604         https://bugs.webkit.org/show_bug.cgi?id=136416
3605
3606         Reviewed by Dan Bernstein.
3607
3608         * WebView/WebFrameView.mm:
3609         (-[WebFrameView drawRect:]):
3610         We only end up filling, so only set the fill color.
3611
3612 2014-08-26  Maciej Stachowiak  <mjs@apple.com>
3613
3614         Use RetainPtr::autorelease in some places where it seems appropriate
3615         https://bugs.webkit.org/show_bug.cgi?id=136280
3616
3617         Reviewed by Darin Adler.
3618
3619         * WebView/WebHTMLView.mm:
3620         (imageFromRect): Use RetainPtr in this function.
3621         * WebView/WebPDFRepresentation.mm:
3622         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use RetainPtr
3623         in this method.
3624
3625 2014-08-29  Csaba Osztrogonác  <ossy@webkit.org>
3626
3627         Unreviwed, remove empty directories.
3628
3629         * ForwardingHeaders/wtf: Removed.
3630
3631 2014-08-27  Zalan Bujtas  <zalan@apple.com>
3632
3633         Subpixel layout: Rename LayoutRect's device pixel snapping functions.
3634         https://bugs.webkit.org/show_bug.cgi?id=136319
3635
3636         Reviewed by Simon Fraser.
3637
3638         From pixelSnappedForPainting() to snapRectToDevicePixels() and 
3639         pixelSnappedIntRect*() to snappedIntRect*().
3640
3641         No change in functionality.
3642
3643         * WebView/WebView.mm:
3644         (-[WebView _dashboardRegions]):
3645         (-[WebView trackedRepaintRects]):
3646
3647 2014-08-25  Maciej Stachowiak  <mjs@apple.com>
3648
3649         Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API
3650         https://bugs.webkit.org/show_bug.cgi?id=136082
3651
3652         Reviewed by Alexey Proskuryakov.
3653
3654         * Plugins/Hosted/NetscapePluginHostManager.mm:
3655         (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current
3656         localization name using WebCore helper instead of SPI.
3657         * Plugins/WebBasePluginPackage.mm: Fixed the include style for this 
3658         file.
3659         (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current
3660         localization name using WebCore helper instead of SPI.
3661         (+[WebBasePluginPackage preferredLocalizationName]): Deleted. This
3662         helper no longer pulls its weight.
3663         * WebCoreSupport/WebSystemInterface.mm: 
3664         (InitWebCoreSystemInterface): Remove mention of
3665         WKCopyCFLocalizationPreferredName.
3666         * WebKit.order: ditto
3667
3668 2014-08-25  Daniel Bates  <dabates@apple.com>
3669
3670         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/172889>
3671         (https://bugs.webkit.org/show_bug.cgi?id=109658)
3672
3673         Substitute GraphicsLayer::setContentsToPlatformLayer(..., GraphicsLayer::ContentsLayerForMedia)
3674         for GraphicsLayer::setContentsToMedia(...) because the latter was removed in <http://trac.webkit.org/changeset/172889>.
3675
3676         * WebView/WebView.mm:
3677         (-[WebView _setMediaLayer:forPluginView:]):
3678
3679 2014-08-22  Commit Queue  <commit-queue@webkit.org>
3680
3681         Unreviewed, rolling out r172866.
3682         https://bugs.webkit.org/show_bug.cgi?id=136177
3683
3684         Broke iOS build (Requested by othermaciej on #webkit).
3685
3686         Reverted changeset:
3687
3688         "Replace use of WKCopyCFLocalizationPreferredName with
3689         NSLocale public API"
3690         https://bugs.webkit.org/show_bug.cgi?id=136082
3691         http://trac.webkit.org/changeset/172866
3692
3693 2014-08-22  Simon Fraser  <simon.fraser@apple.com>
3694
3695         Implement paint flashing in the WK1 InspectorOverlay page
3696         https://bugs.webkit.org/show_bug.cgi?id=136138
3697
3698         Reviewed by Sam Weinig, Joseph Pecoraro.
3699
3700         Implement paint flashing for the WebKit1 InspectorOverlay via a second canvas in the overlay page.
3701         We avoid allocating backing store for this canvas until we have paint rects.
3702         
3703         Because this overlay page is weird and doesn't know how to paint itself, InspectorOverlay manages
3704         an array of rects, and pushes them to the page when they change, before forcing a paint.
3705         
3706         Because iOS doesn't use the InspectorOverlay page, stub out setShowPaintRects on its
3707         WebKit WebInspectorClient, but don't yet implement paint flashing there.
3708
3709         * WebCoreSupport/WebInspectorClient.h:
3710         * WebCoreSupport/WebInspectorClient.mm:
3711         (WebInspectorClient::WebInspectorClient):
3712
3713 2014-08-20  Maciej Stachowiak  <mjs@apple.com>
3714
3715         Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API
3716         https://bugs.webkit.org/show_bug.cgi?id=136082
3717
3718         Reviewed by Alexey Proskuryakov.
3719
3720         * Plugins/Hosted/NetscapePluginHostManager.mm:
3721         (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current
3722         localization name using WebCore helper instead of SPI.
3723         * Plugins/WebBasePluginPackage.mm: Fixed the include style for this 
3724         file.
3725         (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current
3726         localization name using WebCore helper instead of SPI.
3727         (+[WebBasePluginPackage preferredLocalizationName]): Deleted. This
3728         helper no longer pulls its weight.
3729         * WebCoreSupport/WebSystemInterface.mm: 
3730         (InitWebCoreSystemInterface): Remove mention of
3731         WKCopyCFLocalizationPreferredName.
3732         * WebKit.order: ditto
3733
3734 2014-08-22  Daniel Bates  <dabates@apple.com>
3735
3736         [iOS] Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, and temporarily disable ENABLE_TOUCH_EVENTS
3737         and ENABLE_XSLT when building with the iOS public SDK
3738         https://bugs.webkit.org/show_bug.cgi?id=135945
3739
3740         Reviewed by Andy Estes.
3741
3742         * Configurations/FeatureDefines.xcconfig: Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, ENABLE_TOUCH_EVENTS
3743         and ENABLE_XSLT when building with the public SDK.
3744         * MigrateHeaders.make: Conditionally migrate headers for touch and gesture events.
3745
3746 2014-08-22  Jon Lee  <jonlee@apple.com>
3747
3748         Fix iOS build due to r172832 and move RUBBER_BANDING out of FeatureDefines.h
3749         https://bugs.webkit.org/show_bug.cgi?id=136157
3750
3751         Reviewed by Simon Fraser.
3752
3753         * Configurations/FeatureDefines.xcconfig: Add ENABLE(RUBBER_BANDING).
3754         * WebView/WebView.mm:
3755         (-[WebView _preferencesChanged:]): Wrap in ENABLE(RUBBER_BANDING).
3756
3757 2014-08-21  Zalan Bujtas  <zalan@apple.com>
3758
3759         Enable SATURATED_LAYOUT_ARITHMETIC.
3760         https://bugs.webkit.org/show_bug.cgi?id=136106
3761
3762         Reviewed by Simon Fraser.
3763
3764         SATURATED_LAYOUT_ARITHMETIC protects LayoutUnit against arithmetic overflow.
3765         (No measurable performance regression on Mac.)
3766
3767         * Configurations/FeatureDefines.xcconfig:
3768
3769 2014-08-21  Beth Dakin  <bdakin@apple.com>
3770
3771         overflow:scroll elements should support rubber-banding
3772         https://bugs.webkit.org/show_bug.cgi?id=91655
3773
3774         Reviewed by Sam Weinig and Darin Adler.
3775
3776         Disable rubber-banding in overflow areas for now.
3777         * WebView/WebView.mm:
3778         (-[WebView _preferencesChanged:]):
3779
3780 2014-08-19  Pratik Solanki  <psolanki@apple.com>
3781
3782         Remove PurgeableBuffer since it is not very useful any more
3783         https://bugs.webkit.org/show_bug.cgi?id=135939
3784
3785         Reviewed by Andreas Kling.
3786
3787         * Misc/WebCache.mm:
3788         (+[WebCache statistics]):
3789
3790 2014-08-19  Zalan Bujtas  <zalan@apple.com>
3791
3792         Remove ENABLE(SUBPIXEL_LAYOUT).
3793         https://bugs.webkit.org/show_bug.cgi?id=136077
3794
3795         Reviewed by Simon Fraser.
3796
3797         Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.
3798
3799         * Configurations/FeatureDefines.xcconfig:
3800
3801 2014-08-18  Maciej Stachowiak  <mjs@apple.com>
3802
3803         Use NSURLFileTypeMappings directly instead of depending on WebKitSystemInterface wrappers for it
3804         https://bugs.webkit.org/show_bug.cgi?id=136035
3805
3806         Reviewed by Dan Bernstein.
3807
3808         * Misc/WebNSViewExtras.m:
3809         (-[NSView _web_DragImageForElement:rect:event:pasteboard:source:offset:]): Remove comment
3810         reference to obsolete WKSI function.
3811         * WebCoreSupport/WebSystemInterface.mm:
3812         (InitWebCoreSystemInterface): Don't initialize the no-longer-used WKGetExtensionsForMIMEType,
3813         WKGetPreferredExtensionForMIMEType, or WKGetMIMETypeForExtension
3814         * Plugins/WebPluginDatabase.mm:
3815         (-[WebPluginDatabase pluginForExtension:]): Include SPI header from WebCore; use
3816         NSURLFileTypeMappings directly instead of via WKSI wrapper.
3817         * WebCoreSupport/WebFrameLoaderClient.mm:
3818         (WebFrameLoaderClient::objectContentType): ditto
3819         * WebView/WebHTMLView.mm:
3820         (-[WebHTMLView _imageExistsAtPaths:]): ditto
3821         * WebView/WebView.mm:
3822         (+[WebView _supportedFileExtensions]): ditto
3823         (+[WebView suggestedFileExtensionForMIMEType:]): ditto
3824         (+[WebView _MIMETypeForFile:]): ditto
3825
3826 2014-08-18  Commit Queue  <commit-queue@webkit.org>
3827
3828         Unreviewed, rolling out r172736.
3829         https://bugs.webkit.org/show_bug.cgi?id=136060
3830
3831         Caused 14% PLT regressions (Requested by rniwa on #webkit).
3832
3833         Reverted changeset:
3834
3835         "Remove PurgeableBuffer since it is not very useful any more"
3836         https://bugs.webkit.org/show_bug.cgi?id=135939
3837         http://trac.webkit.org/changeset/172736
3838
3839 2014-08-18  Pratik Solanki  <psolanki@apple.com>
3840
3841         Remove PurgeableBuffer since it is not very useful any more
3842         https://bugs.webkit.org/show_bug.cgi?id=135939
3843
3844         Reviewed by Geoffrey Garen.
3845
3846         * Misc/WebCache.mm:
3847         (+[WebCache statistics]):
3848
3849 2014-08-18  Andy Estes  <aestes@apple.com>
3850
3851         REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
3852         https://bugs.webkit.org/show_bug.cgi?id=136010
3853
3854         Reviewed by Darin Adler.
3855
3856         * Misc/WebKitVersionChecks.h: Removed WEBKIT_FIRST_VERSION_WITH_NAVIGATION_URL_VALIDATION.
3857         * WebView/WebPDFView.mm:
3858         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Passed AllowNavigationToInvalidURL::Yes to FrameLoader::loadFrameRequest.
3859         * WebView/WebView.mm:
3860         (-[WebView _preferencesChanged:]): Reverted the linked-on-or-after check added in r170120 since it's no longer necessary.
3861
3862 2014-08-18  Andy Estes  <aestes@apple.com>
3863
3864         Revert r172697.
3865
3866         It made several webarchive layout tests flaky and didn't have the correct behavior for non-quick redirects.
3867
3868         * Misc/WebKitVersionChecks.h:
3869         * WebView/WebView.mm:
3870         (-[WebView _preferencesChanged:]):
3871
3872 2014-08-15  Andy Estes  <aestes@apple.com>
3873
3874         REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
3875         https://bugs.webkit.org/show_bug.cgi?id=136010
3876
3877         Reviewed by Darin Adler.
3878
3879         Reverted the linked-on-or-after check added in r170120 since it is no longer necessary.
3880
3881         * Misc/WebKitVersionChecks.h:
3882         * WebView/WebView.mm:
3883         (-[WebView _preferencesChanged:]):
3884
3885 2014-08-16  Maciej Stachowiak  <mjs@apple.com>
3886
3887         Remove the obsolete WebKitEnableCoalescedUpdatesPreferenceKey
3888         https://bugs.webkit.org/show_bug.cgi?id=136024
3889
3890         Reviewed by Filip Pizlo.
3891
3892         * WebView/WebFrameView.mm:
3893         (-[WebFrameView initWithFrame:]): Remove code that respects
3894         this key. It was SPI and is no longer used; also it was
3895         only relevant for versions of OS X that WebKit no longer supports.
3896         * WebView/WebPreferenceKeysPrivate.h: Remove declaration.
3897
3898 2014-08-15  Daniel Bates  <dabates@apple.com>
3899
3900         [iOS] Teach postprocess-headers.sh to remove code guarded by ENABLE_IOS_GESTURE_EVENTS
3901         and ENABLE_TOUCH_EVENTS if applicable
3902         https://bugs.webkit.org/show_bug.cgi?id=135993
3903
3904         Reviewed by Andy Estes.
3905
3906         Add support infrastructure to remove code from public and private API headers that is
3907         guarded by macro define ENABLE_{IOS_GESTURE, TOUCH}_EVENTS when these features are disabled.
3908
3909         We aren't using this functionality yet, but we will soon.
3910
3911         * postprocess-headers.sh:
3912
3913 2014-08-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3914
3915         Enable CSS_SCROLL_SNAP for iOS
3916         https://bugs.webkit.org/show_bug.cgi?id=135915
3917
3918         Turn on CSS_SCROLL_SNAP for iOS and the iOS simulator.
3919
3920         Reviewed by Tim Horton.
3921
3922         * Configurations/FeatureDefines.xcconfig:
3923
3924 2014-08-13  Mark Rowe  <mrowe@apple.com>
3925
3926         <https://webkit.org/b/135911> WebKit should build on Yosemite with the public SDK.
3927
3928         Reviewed by Darin Adler.
3929
3930         * Misc/WebSharingServicePickerController.mm: Forward-declare some details related to NSSharingServicePicker.
3931
3932 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3933
3934         Web Inspector: Workaround a NSWindow change to the title bar.
3935         https://bugs.webkit.org/show_bug.cgi?id=135880
3936
3937         Reviewed by Joseph Pecoraro.
3938
3939         * WebCoreSupport/WebInspectorClient.mm:
3940         (WebInspectorFrontendClient::setToolbarHeight): Only call setContentBorderThickness: on 10.9 and earlier.
3941         (-[WebInspectorWindowController init]): Only call setDrawsBackground: on 10.9 and earlier.
3942         (-[WebInspectorWindowController window]): Set titlebarAppearsTransparent on 10.10.
3943         Only call border thickness APIs on 10.9 and earlier.
3944
3945 2014-08-12  Peyton Randolph  <prandolph@apple.com>
3946
3947         Runtime switch for long mouse press gesture. Part of 135257 - Add long mouse press gesture.           
3948         https://bugs.webkit.org/show_bug.cgi?id=135682
3949
3950         Reviewed by Tim Horton.
3951
3952         * Configurations/FeatureDefines.xcconfig:
3953         Remove LONG_MOUSE_PRESS feature flag.
3954
3955 2014-08-11  Andy Estes  <aestes@apple.com>
3956
3957         [iOS] Get rid of iOS.xcconfig
3958         https://bugs.webkit.org/show_bug.cgi?id=135809
3959
3960         Reviewed by Joseph Pecoraro.
3961
3962         All iOS.xcconfig did was include AspenFamily.xcconfig, so there's no need for the indirection.
3963
3964         * Configurations/Base.xcconfig:
3965         * Configurations/iOS.xcconfig: Removed.
3966
3967 2014-08-10  Timothy Hatcher  <timothy@apple.com>
3968
3969         Web Inspector: new glyphs are visible on OS X 10.9 builds
3970         https://bugs.webkit.org/show_bug.cgi?id=135743
3971
3972         Reviewed by Joseph Pecoraro.
3973
3974         * WebCoreSupport/WebInspectorClient.mm:
3975         (-[WebInspectorWindowController window]): Use 10100 instead of 1090 for the version.
3976
3977 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
3978
3979         Get rid of SCRIPTED_SPEECH
3980         https://bugs.webkit.org/show_bug.cgi?id=135729
3981
3982         Reviewed by Brent Fulgham.
3983
3984         * Configurations/FeatureDefines.xcconfig:
3985
3986 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
3987
3988         Get rid of INPUT_SPEECH
3989         https://bugs.webkit.org/show_bug.cgi?id=135672
3990
3991         Reviewed by Andreas Kling.
3992
3993         * Configurations/FeatureDefines.xcconfig:
3994
3995 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3996
3997         Web Inspector: Update glyphs to be more like Xcode 6
3998         https://bugs.webkit.org/show_bug.cgi?id=135705
3999
4000         Reviewed by Joseph Pecoraro.
4001
4002         * Resources/Dock.pdf: Added.
4003         * Resources/DockLegacy.pdf: Copied from Source/WebKit/mac/Resources/Dock.pdf.
4004         * WebCoreSupport/WebInspectorClient.mm:
4005         (-[WebInspectorWindowController window]): Use new images.
4006
4007 2014-08-06  Dean Jackson  <dino@apple.com>
4008
4009         ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED is not used anywhere. Remove it.
4010         https://bugs.webkit.org/show_bug.cgi?id=135675
4011
4012         Reviewed by Sam Weinig.
4013
4014         * Configurations/FeatureDefines.xcconfig:
4015
4016 2014-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
4017
4018         Implement parsing for CSS scroll snap points
4019         https://bugs.webkit.org/show_bug.cgi?id=134301
4020
4021         Reviewed by Dean Jackson.
4022
4023         * Configurations/FeatureDefines.xcconfig: Added ENABLE_CSS_SCROLL_SNAP
4024
4025 2014-08-06  Alexey Proskuryakov  <ap@apple.com>
4026
4027         REGRESSION (WebKit2): iOS Safari default encoding doesn't follow system language
4028         https://bugs.webkit.org/show_bug.cgi?id=135667
4029         <rdar://problem/17862892>
4030
4031         Reviewed by Anders Carlsson.
4032
4033         * WebView/WebPreferences.mm: (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]):
4034         Moved implementation to WebCore, so that it can be shared with WebKit2.
4035
4036         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
4037         We now use WKGetWebDefaultCFStringEncoding in WebCore, so it needs to be initialized.
4038
4039 2014-08-05  Peyton Randolph  <prandolph@apple.com>
4040
4041         Rename MAC_LONG_PRESS feature flag to LONG_MOUSE_PRESS.
4042         https://bugs.webkit.org/show_bug.cgi?id=135276
4043
4044         Reviewed by Beth Dakin.
4045
4046         * Configurations/FeatureDefines.xcconfig:
4047
4048 2014-08-04  Benjamin Poulain  <benjamin@webkit.org>
4049
4050         Add a flag for the CSS Selectors level 4 implementation
4051         https://bugs.webkit.org/show_bug.cgi?id=135535
4052
4053         Reviewed by Andreas Kling.
4054
4055         * Configurations/FeatureDefines.xcconfig:
4056
4057 2014-08-04  Benjamin Poulain  <bpoulain@apple.com>
4058
4059         Check for null frame when processing geolocation authorization request
4060         https://bugs.webkit.org/show_bug.cgi?id=135577
4061         <rdar://problem/17896295>
4062
4063         Reviewed by Geoffrey Garen.
4064
4065         * WebCoreSupport/WebGeolocationClient.mm:
4066         (WebGeolocationClient::requestPermission):
4067
4068 2014-08-02  Jeremy Jones  <jeremyj@apple.com>
4069
4070         Support both window and view based video fullscreen.
4071         https://bugs.webkit.org/show_bug.cgi?id=135525
4072
4073         Reviewed by Simon Fraser.
4074
4075         Parenting in the view instead of the window gives the fullscreen implementation more latitude 
4076         in how it implements the animation.
4077
4078         * WebView/WebView.mm:
4079         (-[WebView _enterFullscreenForNode:]): Use view instead of window.
4080
4081 2014-08-01  Dan Bernstein  <mitz@apple.com>
4082
4083         <rdar://problem/17891752> [iOS] WebKit links against libraries it doesn’t use
4084         https://bugs.webkit.org/show_bug.cgi?id=135536
4085
4086         Reviewed by Tim Horton.
4087
4088         * Configurations/WebKitLegacy.xcconfig: Removed -framework MobileAsset from
4089         OTHER_LDFLAGS_iphoneos.
4090
4091 2014-07-30  Andy Estes  <aestes@apple.com>
4092
4093         USE(CONTENT_FILTERING) should be ENABLE(CONTENT_FILTERING)
4094         https://bugs.webkit.org/show_bug.cgi?id=135439
4095
4096         Reviewed by Tim Horton.
4097
4098         We now support two different platform content filters, and will soon support a mock content filter (as part of
4099         webkit.org/b/128858). This makes content filtering a feature of WebKit, not just an adoption of a third-party
4100         library. ENABLE() is the correct macro to use for such a feature.
4101
4102         * Configurations/FeatureDefines.xcconfig:
4103
4104 2014-07-30  Andreas Kling  <akling@apple.com>
4105
4106         Static hash tables no longer need to be coupled with a VM.
4107         <https://webkit.org/b/135421>
4108
4109         Reviewed by Geoffrey Garen.
4110
4111         * Plugins/Hosted/ProxyInstance.mm:
4112         * Plugins/Hosted/ProxyRuntimeObject.mm:
4113
4114 2014-07-30  Dan Bernstein  <mitz@apple.com>
4115
4116         Updated for changes to the WebCore::Credential API.
4117         Work towards fixing https://bugs.webkit.org/show_bug.cgi?id=135327
4118
4119         Reviewed by Alexey Proskuryakov.
4120
4121         * Misc/WebDownload.mm:
4122         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): Use new nsCredential
4123         getter.
4124         * Plugins/WebBaseNetscapePluginView.mm:
4125         (WebKit::getAuthenticationInfo): Ditto.
4126
4127 2014-07-27  Pratik Solanki  <psolanki@apple.com>
4128
4129         Remove unused preference keys
4130         https://bugs.webkit.org/show_bug.cgi?id=135280
4131
4132         Reviewed by Darin Adler.
4133
4134         * WebView/WebPreferenceKeysPrivate.h:
4135         * WebView/WebPreferences.mm:
4136         (+[WebPreferences initialize]):
4137         (-[WebPreferences _setPageCacheSize:]): Deleted.
4138         (-[WebPreferences _pageCacheSize]): Deleted.
4139         (-[WebPreferences _setObjectCacheSize:]): Deleted.
4140         (-[WebPreferences _objectCacheSize]): Deleted.
4141         * WebView/WebPreferencesPrivate.h:
4142
4143 2014-07-27  Filip Pizlo  <fpizlo@apple.com>
4144
4145         Merge r170090, r170092, r170129, r170141, r170161, r170215, r170275, r170375, r170376, r170382, r170383, r170399, r170436, r170489, r170490, r170556 from ftlopt.
4146
4147     2014-07-25  Mark Lam  <mark.lam@apple.com>
4148     
4149             [ftlopt] Renamed DebuggerActivation to DebuggerScope.
4150             <https://webkit.org/b/134273>
4151     
4152             Reviewed by Michael Saboff.
4153     
4154             * WebView/WebScriptDebugDelegate.mm:
4155             - Removed unneeded #include.
4156     
4157 2014-07-26  Filip Pizlo  <fpizlo@apple.com>
4158
4159         Unreviewed, roll out r171641-r171644. It broke some tests; will investigate and
4160         reland later.
4161
4162         * WebView/WebScriptDebugDelegate.mm:
4163
4164 2014-07-25  Filip Pizlo  <fpizlo@apple.com>
4165
4166         Merge r170090, r170092, r170129, r170141, r170161, r170215, r170275, r170375, r170376, r170382, r170383, r170399, r170436, r170489, r170490, r170556 from ftlopt.
4167
4168     2014-07-25  Mark Lam  <mark.lam@apple.com>
4169     
4170             [ftlopt] Renamed DebuggerActivation to DebuggerScope.
4171             <https://webkit.org/b/134273>
4172     
4173             Reviewed by Michael Saboff.
4174     
4175             * WebView/WebScriptDebugDelegate.mm:
4176             - Removed unneeded #include.
4177     
4178 2014-07-25  Jeremy Jones  <jeremyj@apple.com>
4179
4180         Parent fullscreen from window instead of view
4181         https://bugs.webkit.org/show_bug.cgi?id=135310
4182
4183         Reviewed by Jer Noble.
4184
4185         Parenting in the view causes an incorrect animation to fullscreen, and can cause 
4186         fullscreen to only expand to the size of the view instead of the whole window.
4187
4188         * WebView/WebView.mm:
4189         (-[WebView _enterFullscreenForNode:]): Pass window instead of view.
4190
4191 2014-07-24  Pratik Solanki  <psolanki@apple.com>
4192
4193         [iOS] Remove prefs to tweak cache values
4194         https://bugs.webkit.org/show_bug.cgi?id=135274
4195         <rdar://problem/17784826>
4196
4197         Reviewed by Alexey Proskuryakov.