Infinite recursion in _clearImmediateActionState
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
2
3         Infinite recursion in _clearImmediateActionState
4         https://bugs.webkit.org/show_bug.cgi?id=140807
5         <rdar://problem/19571601>
6
7         Reviewed by Anders Carlsson.
8
9         * WebView/WebImmediateActionController.mm:
10         (-[WebImmediateActionController _clearImmediateActionState]):
11         Use this opportunity to bring identical code to WebKit1, to avoid
12         getting DataDetectors stuck when an immediate action is canceled.
13
14 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
15
16         Add a build flag for ES6 class syntax
17         https://bugs.webkit.org/show_bug.cgi?id=140760
18
19         Reviewed by Michael Saboff.
20
21         * Configurations/FeatureDefines.xcconfig:
22
23 2015-01-22  Beth Dakin  <bdakin@apple.com>
24
25         ibtoold crash below -[WebView close]
26         https://bugs.webkit.org/show_bug.cgi?id=140782
27         -and corresponding-
28         rdar://problem/19558472
29
30         Reviewed by Tim Horton.
31
32         Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but 
33         it is because interface builder is messing with our views.
34         * WebView/WebImmediateActionController.h:
35         * WebView/WebImmediateActionController.mm:
36         (-[WebImmediateActionController webViewClosed]):
37         (-[WebImmediateActionController _cancelImmediateAction]):
38         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
39         (-[WebImmediateActionController _updateImmediateActionItem]):
40
41 2015-01-21  Beth Dakin  <bdakin@apple.com>
42
43         Crash in QuickLook preview delegate method
44         https://bugs.webkit.org/show_bug.cgi?id=140740
45         -and corresponding-
46         rdar://problem/19540806
47
48         Reviewed by Tim Horton.
49
50         Clear out the delegate.
51         * WebView/WebImmediateActionController.mm:
52         (-[WebImmediateActionController webViewClosed]):
53
54 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
55
56         Remove ENABLE(INSPECTOR) ifdef guards
57         https://bugs.webkit.org/show_bug.cgi?id=140668
58
59         Reviewed by Darin Adler.
60
61         * Configurations/FeatureDefines.xcconfig:
62         * WebCoreSupport/WebFrameLoaderClient.mm:
63         (WebFrameLoaderClient::dispatchWillSendRequest):
64
65 2015-01-20  Anders Carlsson  <andersca@apple.com>
66
67         Remove USE(GLIB) code from WebKit1
68         https://bugs.webkit.org/show_bug.cgi?id=140714
69
70         Reviewed by Andreas Kling.
71
72         * WebView/WebView.mm:
73         (-[WebView _commonInitializationWithFrameName:groupName:]):
74         (-[WebView _close]):
75         (-[WebView _clearGlibLoopObserver]): Deleted.
76         (glibContextIterationCallback): Deleted.
77         (-[WebView _scheduleGlibContextIterations]): Deleted.
78         * WebView/WebViewData.h:
79         * WebView/WebViewInternal.h:
80
81 2015-01-20  David Kilzer  <ddkilzer@apple.com>
82
83         Switch to comparing PLATFORM_NAME in terms of macosx
84         <http://webkit.org/b/139516>
85
86         Reviewed by Timothy Hatcher.
87
88         * MigrateHeaders.make:
89         * postprocess-headers.sh:
90
91 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
92
93         [SVG -> OTF Converter] Flip the switch on
94         https://bugs.webkit.org/show_bug.cgi?id=140592
95
96         Reviewed by Antti Koivisto.
97
98         * Configurations/FeatureDefines.xcconfig:
99
100 2015-01-19  Beth Dakin  <bdakin@apple.com>
101
102         Speculative build fix.
103
104         * WebView/WebView.mm:
105         (-[WebView _commonInitializationWithFrameName:groupName:]):
106
107 2015-01-19  Beth Dakin  <bdakin@apple.com>
108
109         Speculative build fix.
110
111         * WebView/WebView.mm:
112         (-[WebView _convertRectFromRootView:]):
113
114 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
115
116         Adjust naming of action menu SPI
117         https://bugs.webkit.org/show_bug.cgi?id=140644
118         <rdar://problem/19448129>
119
120         Reviewed by Brian Weinstein.
121
122         * WebView/WebActionMenuController.mm:
123         (-[WebActionMenuController prepareForMenu:withEvent:]):
124         (-[WebActionMenuController willOpenMenu:withEvent:]):
125         (-[WebActionMenuController didCloseMenu:withEvent:]):
126         * WebView/WebView.mm:
127         (-[WebView _commonInitializationWithFrameName:groupName:]):
128         (-[WebView prepareForMenu:withEvent:]):
129         (-[WebView willOpenMenu:withEvent:]):
130         (-[WebView didCloseMenu:withEvent:]):
131
132 2015-01-19  Beth Dakin  <bdakin@apple.com>
133
134         REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is 
135         offset by flipped-ness
136         https://bugs.webkit.org/show_bug.cgi?id=140643
137         -and corresponding-
138         rdar://problem/19489593
139
140         Reviewed by Tim Horton.
141
142         We universally flipped because we assumed that the root view was flipped and the 
143         WebView was not. However, in Dictionary, the WebView is flipped! So this patch 
144         fixes that assumption by checking the WebView’s flipped-ness.
145         * WebView/WebView.mm:
146         (-[WebView _convertRectFromRootView:]):
147
148 2015-01-19  Commit Queue  <commit-queue@webkit.org>
149
150         Unreviewed, rolling out r178653.
151         https://bugs.webkit.org/show_bug.cgi?id=140634
152
153         Broke multiple SVG tests on Mountain Lion (Requested by ap on
154         #webkit).
155
156         Reverted changeset:
157
158         "[SVG -> OTF Converter] Flip the switch on"
159         https://bugs.webkit.org/show_bug.cgi?id=140592
160         http://trac.webkit.org/changeset/178653
161
162 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
163
164         [SVG -> OTF Converter] Flip the switch on
165         https://bugs.webkit.org/show_bug.cgi?id=140592
166
167         Reviewed by Antti Koivisto.
168
169         * Configurations/FeatureDefines.xcconfig:
170
171 2015-01-18  Daniel Bates  <dabates@apple.com>
172
173         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/178631>
174         (https://bugs.webkit.org/show_bug.cgi?id=129441)
175
176         Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight().
177         Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.
178
179         * WebInspector/WebNodeHighlightView.mm:
180         (-[WebNodeHighlightView layoutSublayers:]):
181
182 2015-01-16  Beth Dakin  <bdakin@apple.com>
183
184         Make sure early cancellation of immediate action actually does that in WK1
185         https://bugs.webkit.org/show_bug.cgi?id=140566
186         -and corresponding-
187         rdar://problem/19490114
188
189         Reviewed by Tim Horton.
190
191         Work around an AppKit bug by dispatching the call to _cancelImmediateAction 
192         asynchronously.
193         * WebView/WebImmediateActionController.mm:
194         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
195
196 2015-01-16  Daniel Bates  <dabates@apple.com>
197
198         Fix the public iOS SDK build after <http://trac.webkit.org/changeset/178285>
199         (https://bugs.webkit.org/show_bug.cgi?id=140360)
200
201         Forward declare protocol NSURLDownloadDelegate as it is SPI on iOS.
202
203         * Misc/WebDownload.h:
204
205 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
206
207         Remove ENABLE(SQL_DATABASE) guards
208         https://bugs.webkit.org/show_bug.cgi?id=140434
209
210         Reviewed by Darin Adler.
211
212         * Configurations/FeatureDefines.xcconfig:
213         * Storage/WebDatabaseManager.mm:
214         (databasesDirectoryPath):
215         * Storage/WebDatabaseManagerClient.h:
216         * Storage/WebDatabaseManagerClient.mm:
217         * Storage/WebDatabaseManagerInternal.h:
218         * Storage/WebDatabaseManagerPrivate.h:
219         * Storage/WebDatabaseQuotaManager.mm:
220         (-[WebDatabaseQuotaManager usage]):
221         (-[WebDatabaseQuotaManager quota]):
222         (-[WebDatabaseQuotaManager setQuota:]):
223         * WebCoreSupport/WebChromeClient.h:
224         * WebCoreSupport/WebChromeClient.mm:
225         * WebCoreSupport/WebSecurityOrigin.mm:
226         (-[WebSecurityOrigin usage]):
227         (-[WebSecurityOrigin quota]):
228         (-[WebSecurityOrigin setQuota:]):
229         * WebView/WebFrame.mm:
230         (-[WebFrame _cacheabilityDictionary]):
231         * WebView/WebView.mm:
232         (-[WebView _commonInitializationWithFrameName:groupName:]):
233         (-[WebView _preferencesChanged:]):
234
235 2015-01-14  Chris Dumez  <cdumez@apple.com>
236
237         Make 'TypeName' parameter unnecessary in CSSPropertyNames.in
238         https://bugs.webkit.org/show_bug.cgi?id=140347
239
240         Reviewed by Darin Adler.
241
242         Call FontDescription::setIsItalic() instead of setItalic() as the
243         call site passes a boolean.
244
245         * WebView/WebHTMLView.mm:
246         (fontNameForDescription):
247
248 2015-01-13  Anders Carlsson  <andersca@apple.com>
249
250         Temporarily reintroduce the informal delegate protocols
251         https://bugs.webkit.org/show_bug.cgi?id=140416
252
253         Reviewed by Dan Bernstein.
254
255         * WebView/WebEditingDelegate.h:
256         * WebView/WebFrameLoadDelegate.h:
257         * WebView/WebPolicyDelegate.h:
258         * WebView/WebResourceLoadDelegate.h:
259         * WebView/WebUIDelegate.h:
260
261 2015-01-13  Beth Dakin  <bdakin@apple.com>
262
263         Should disable immediate actions for iTunes
264         https://bugs.webkit.org/show_bug.cgi?id=140405
265         -and corresponding-
266         rdar://problem/19461358
267
268         Reviewed by Tim Horton.
269
270         * WebView/WebImmediateActionController.mm:
271         (-[WebImmediateActionController _updateImmediateActionItem]):
272
273 2015-01-11  Sam Weinig  <sam@webkit.org>
274
275         Remove support for SharedWorkers
276         https://bugs.webkit.org/show_bug.cgi?id=140344
277
278         Reviewed by Anders Carlsson.
279
280         * Configurations/FeatureDefines.xcconfig:
281         * WebCoreSupport/WebPlatformStrategies.h:
282         * WebCoreSupport/WebPlatformStrategies.mm:
283         (WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
284
285 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
286
287         Get rid of unnecessary reimplementations of CGFloor/Ceiling
288         https://bugs.webkit.org/show_bug.cgi?id=140375
289
290         Reviewed by Simon Fraser.
291
292         * Misc/WebKitNSStringExtras.mm:
293         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
294         (webkit_CGCeiling): Deleted.
295         Delete unnecessary code, use the real CGFloor/Ceiling instead.
296
297 2015-01-12  Anders Carlsson  <andersca@apple.com>
298
299         Make delegates conform to formal delegate protocols
300         https://bugs.webkit.org/show_bug.cgi?id=140370
301
302         Reviewed by Dan Bernstein.
303
304         * DefaultDelegates/WebDefaultPolicyDelegate.h:
305         * WebCoreSupport/WebInspectorClient.mm:
306         Add protocols to the interface declarations.
307
308         * WebView/WebActionMenuController.mm:
309         (-[WebActionMenuController prepareForMenu:withEvent:]):
310         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
311         * WebView/WebImmediateActionController.mm:
312         (-[WebImmediateActionController _updateImmediateActionItem]):
313         (-[WebImmediateActionController _menuItemForDataDetectedText]):
314         Cast to id when trying to invoke delegate methods that aren't on WebUIDelegate.
315
316 2015-01-12  Myles C. Maxfield  <mmaxfield@apple.com>
317
318         Allow targetting the SVG->OTF font converter with ENABLE(SVG_OTF_CONVERTER)
319         https://bugs.webkit.org/show_bug.cgi?id=136769
320
321         Reviewed by Antti Koivisto.
322
323         * Configurations/FeatureDefines.xcconfig:
324
325 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
326
327         Multi-rect TextIndicators are vertically flipped in WebKit1
328         https://bugs.webkit.org/show_bug.cgi?id=140350
329         <rdar://problem/19441243>
330
331         Reviewed by Beth Dakin.
332
333         * WebView/WebView.mm:
334         (-[WebView _setTextIndicator:fadeOut:]):
335         Convert the textBoundingRect from root view to screen coordinates.
336
337 2015-01-12  Anders Carlsson  <andersca@apple.com>
338
339         Make WebResourceDelegate a formal protocol as well
340         https://bugs.webkit.org/show_bug.cgi?id=140364
341
342         Reviewed by Dan Bernstein.
343
344         * WebView/WebResourceLoadDelegate.h:
345
346 2015-01-12  Anders Carlsson  <andersca@apple.com>
347
348         Delegates should be formal protocols
349         https://bugs.webkit.org/show_bug.cgi?id=140360
350         rdar://problem/17380856
351
352         Reviewed by Dan Bernstein.
353
354         This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
355
356         * DefaultDelegates/WebDefaultUIDelegate.h:
357         * Misc/WebDownload.h:
358         * WebView/WebEditingDelegate.h:
359         * WebView/WebFrameLoadDelegate.h:
360         * WebView/WebPolicyDelegate.h:
361         * WebView/WebUIDelegate.h:
362
363 2015-01-09  Anders Carlsson  <andersca@apple.com>
364
365         Get rid of the database strategy
366         https://bugs.webkit.org/show_bug.cgi?id=140322
367
368         Reviewed by Sam Weinig.
369
370         * WebCoreSupport/WebPlatformStrategies.h:
371         * WebCoreSupport/WebPlatformStrategies.mm:
372         (WebPlatformStrategies::createDatabaseStrategy): Deleted.
373
374 2015-01-08  Timothy Horton  <timothy_horton@apple.com>
375
376         Can't use DataDetectors after immediate action preparation
377         https://bugs.webkit.org/show_bug.cgi?id=140263
378         <rdar://problem/19412705>
379
380         Reviewed by Beth Dakin.
381
382         * WebView/WebImmediateActionController.mm:
383         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
384         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
385         To match WebKit2, only call shouldUseActions if the animation is actually
386         going to begin, not when preparing for it. This way, we're guaranteed
387         to get a didCancel or didComplete.
388
389 2015-01-08  Dean Jackson  <dino@apple.com>
390
391         Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
392         https://bugs.webkit.org/show_bug.cgi?id=140232
393         <rdar://problem/19371010>
394
395         Reviewed by Anders Carlsson.
396
397         Remove the applicationChromeMode setting, but leave stubs in to make
398         sure existing binaries don't break.
399
400         * WebCoreSupport/WebInspectorClient.mm:
401         (-[WebInspectorWindowController init]):
402         * WebView/WebPreferenceKeysPrivate.h:
403         * WebView/WebPreferences.mm:
404         (+[WebPreferences initialize]):
405         (-[WebPreferences applicationChromeModeEnabled]):
406         (-[WebPreferences setApplicationChromeModeEnabled:]):
407         * WebView/WebView.mm:
408         (-[WebView _preferencesChanged:]):
409
410 2015-01-07  Daniel Bates  <dabates@apple.com>
411
412         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
413         https://bugs.webkit.org/show_bug.cgi?id=137371
414
415         Reviewed by David Kilzer.
416
417         Use SPI wrapper headers instead of directly references private SPI headers.
418
419         * Plugins/Hosted/NetscapePluginHostManager.mm:
420
421 2015-01-07  Commit Queue  <commit-queue@webkit.org>
422
423         Unreviewed, rolling out r178068.
424         https://bugs.webkit.org/show_bug.cgi?id=140235
425
426         Breaks the iOS build (Requested by enrica on #webkit).
427
428         Reverted changeset:
429
430         "[iOS] Make WebKit2 build with public iOS SDK and more build
431         fixes for DRT"
432         https://bugs.webkit.org/show_bug.cgi?id=137371
433         http://trac.webkit.org/changeset/178068
434
435 2015-01-07  Daniel Bates  <dabates@apple.com>
436
437         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
438         https://bugs.webkit.org/show_bug.cgi?id=137371
439
440         Reviewed by David Kilzer.
441
442         Use SPI wrapper headers instead of directly references private SPI headers.
443
444         * Plugins/Hosted/NetscapePluginHostManager.mm:
445
446 2015-01-07  Beth Dakin  <bdakin@apple.com>
447
448         Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the 
449         link
450         https://bugs.webkit.org/show_bug.cgi?id=140206
451         -and corresponding-
452         rdar://problem/19300492
453
454         Reviewed by Tim Horton.
455
456         Providing and item frame will ensure that the original link is not obscured.
457         * WebView/WebImmediateActionController.mm:
458         (elementBoundingBoxInWindowCoordinatesFromNode):
459         (-[WebImmediateActionController menuItem:itemFrameForPoint:]):
460
461         For now use a max size that is smaller than the WebView, with the screen’s aspect 
462         ratio, and scaled down.
463         (-[WebImmediateActionController menuItem:maxSizeForPoint:]):
464
465 2015-01-07  Anders Carlsson  <andersca@apple.com>
466
467         Give simple HTML documents a database provider
468         https://bugs.webkit.org/show_bug.cgi?id=140192
469         rdar://problem/19398825
470
471         Reviewed by Tim Horton.
472
473         * WebView/WebView.mm:
474         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
475
476 2015-01-06  Anders Carlsson  <andersca@apple.com>
477
478         Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
479         https://bugs.webkit.org/show_bug.cgi?id=140140
480
481         Reviewed by Andreas Kling.
482
483         Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler
484         out of WebCore since nobody else is using it.
485
486         * Plugins/WebNetscapePluginView.h:
487         * Plugins/WebNetscapePluginView.mm:
488         (-[WebNetscapePluginView _createPlugin]):
489         (-[WebNetscapePluginView _destroyPlugin]):
490         * Plugins/npapi.mm:
491         (NPN_PluginThreadAsyncCall):
492
493 2015-01-06  Anders Carlsson  <andersca@apple.com>
494
495         Add a WebKit1 database provider
496         https://bugs.webkit.org/show_bug.cgi?id=140126
497
498         Reviewed by Sam Weinig.
499
500         Set the database provider.
501
502         * WebView/WebView.mm:
503         (-[WebView _commonInitializationWithFrameName:groupName:]):
504
505 2015-01-06  Commit Queue  <commit-queue@webkit.org>
506
507         Unreviewed, rolling out r177963.
508         https://bugs.webkit.org/show_bug.cgi?id=140136
509
510         Caused lots of crashes (Requested by smfr on #webkit).
511
512         Reverted changeset:
513
514         "Add a WebKit1 database provider"
515         https://bugs.webkit.org/show_bug.cgi?id=140126
516         http://trac.webkit.org/changeset/177963
517
518 2015-01-06  Anders Carlsson  <andersca@apple.com>
519
520         Add a WebKit1 database provider
521         https://bugs.webkit.org/show_bug.cgi?id=140126
522
523         Reviewed by Sam Weinig.
524
525         Set the database provider.
526
527         * WebView/WebView.mm:
528         (-[WebView _commonInitializationWithFrameName:groupName:]):
529
530 2015-01-01  Jeff Miller  <jeffm@apple.com>
531
532         Update user-visible copyright strings to include 2015
533         https://bugs.webkit.org/show_bug.cgi?id=139880
534
535         Reviewed by Darin Adler.
536
537         * Info.plist:
538
539 2014-12-30  Dan Bernstein  <mitz@apple.com>
540
541         [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
542         https://bugs.webkit.org/show_bug.cgi?id=140003
543
544         Reviewed by Darin Adler.
545
546         * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
547         that takes their "string" parameter as a "value" "parameter and has an attribute telling
548         the compiler that if the "value" parameter is a format string then the function returns a
549         modified version of it. The result is that if UI_STRING is used as a format string parameter
550         to some function or method, the compiler will check the format specifiers in the string
551         against the other parameters.
552
553 2014-12-29  Dan Bernstein  <mitz@apple.com>
554
555         Fixed the iOS build.
556
557         * Configurations/WebKitLegacy.xcconfig:
558
559 2014-12-29  Anders Carlsson  <andersca@apple.com>
560
561         Get rid of some PageGroup storage functions
562         https://bugs.webkit.org/show_bug.cgi?id=139996
563
564         Reviewed by Sam Weinig.
565
566         Call WebStorageNamespaceProvider directly instead.
567
568         * Storage/WebStorageManager.mm:
569         (-[WebStorageManager syncLocalStorage]):
570         (+[WebStorageManager closeIdleLocalStorageDatabases]):
571         * WebView/WebView.mm:
572         (+[WebView _applicationWillTerminate]):
573
574 2014-12-29  Anders Carlsson  <andersca@apple.com>
575
576         Move storage code from WebCore to WebKit
577         https://bugs.webkit.org/show_bug.cgi?id=139558
578
579         Reviewed by Darin Adler.
580
581         * Storage/WebStorageManager.mm:
582         * Storage/WebStorageTrackerClient.h:
583         * WebView/WebView.mm:
584
585 2014-12-26  Dan Bernstein  <mitz@apple.com>
586
587         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
588         https://bugs.webkit.org/show_bug.cgi?id=139950
589
590         Reviewed by David Kilzer.
591
592         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
593         in a manner that works with Xcode 5.1.1.
594
595 2014-12-23  Timothy Horton  <timothy_horton@apple.com>
596
597         Install a TextIndicator for link immediate actions
598         https://bugs.webkit.org/show_bug.cgi?id=139897
599         <rdar://problem/19333076>
600
601         Reviewed by Anders Carlsson.
602
603         * WebView/WebImmediateActionController.h:
604         * WebView/WebImmediateActionController.mm:
605         (-[WebImmediateActionController _clearImmediateActionState]):
606         Tear down the TextIndicator, just like WebKit2.
607
608         (-[WebImmediateActionController _defaultAnimationController]):
609         Install a TextIndicator for links.
610
611         (-[WebImmediateActionController menuItemDidClose:]):
612         Tear down the TextIndicator when the QL preview closes.
613
614         (-[WebImmediateActionController _menuItemForDataDetectedText]):
615         Directly install and uninstall the TextIndicator for DataDetectors.
616
617         (-[WebImmediateActionController _showTextIndicator]): Deleted.
618         (-[WebImmediateActionController _hideTextIndicator]): Deleted.
619         Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
620
621 2014-12-20  Eric Carlson  <eric.carlson@apple.com>
622
623         [iOS] add optimized fullscreen API
624         https://bugs.webkit.org/show_bug.cgi?id=139833
625         <rdar://problem/18844486>
626
627         Reviewed by Simon Fraser.
628
629         * Configurations/FeatureDefines.xcconfig:  Add ENABLE_VIDEO_PRESENTATION_MODE.
630
631 2014-12-20  David Kilzer  <ddkilzer@apple.com>
632
633         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
634         <http://webkit.org/b/139463>
635
636         Reviewed by Mark Rowe.
637
638         * Configurations/Base.xcconfig:
639         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
640           on OS X.
641         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
642         * Configurations/DebugRelease.xcconfig:
643         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
644         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
645         * Configurations/Version.xcconfig:
646         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
647         * Configurations/WebKitLegacy.xcconfig:
648         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
649           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
650           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
651           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
652           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
653           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
654           WEBCORE_PRIVATE_HEADERS_DIR_Production and
655           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
656           based on SDK.
657         - Fix PRODUCTION_ROOT to actually be set properly.
658         - Simplify EXPORTED_SYMBOLS_FILE_i386.
659
660         * migrate-headers.sh:
661         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
662         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
663           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
664           WebKitLegacy.xcconfig.
665
666 2014-12-19  Simon Fraser  <simon.fraser@apple.com>
667
668         Fix pink background on CoreAnimation plug-ins in WebKit1
669         https://bugs.webkit.org/show_bug.cgi?id=139845
670         rdar://problem/19313075
671
672         Reviewed by Tim Horton.
673         
674         r154078 left in some debugging code that set a pink background on plug-in hosting
675         layers. Remove it.
676
677         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
678         (-[WebHostedNetscapePluginView createPluginLayer]):
679
680 2014-12-19  Andreas Kling  <akling@apple.com>
681
682         Ref-ify TextIterator API.
683         <https://webkit.org/b/139823>
684
685         Reviewed by Antti Koivisto.
686
687         * WebView/WebTextIterator.mm:
688         (-[WebTextIterator currentRange]):
689
690 2014-12-19  Joseph Pecoraro  <pecoraro@apple.com>
691
692         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
693         https://bugs.webkit.org/show_bug.cgi?id=139797
694
695         Reviewed by Mark Lam.
696
697         * WebView/WebScriptDebugger.h:
698         * WebView/WebScriptDebugger.mm:
699         (WebScriptDebugger::handlePause):
700         Standardize on passing JSGlobalObject parameter first.
701
702 2014-12-19  Commit Queue  <commit-queue@webkit.org>
703
704         Unreviewed, rolling out r177574.
705         https://bugs.webkit.org/show_bug.cgi?id=139821
706
707         "Broke Production builds by installing
708         libWebCoreTestSupport.dylib in the wrong directory" (Requested
709         by ddkilzer on #webkit).
710
711         Reverted changeset:
712
713         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
714         WebInspectorUI, WebKit, WebKit2"
715         https://bugs.webkit.org/show_bug.cgi?id=139463
716         http://trac.webkit.org/changeset/177574
717
718 2014-12-19  David Kilzer  <ddkilzer@apple.com>
719
720         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
721         <http://webkit.org/b/139463>
722
723         Reviewed by Mark Rowe.
724
725         * Configurations/Base.xcconfig:
726         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
727           on OS X.
728         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
729         * Configurations/DebugRelease.xcconfig:
730         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
731         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
732         * Configurations/Version.xcconfig:
733         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
734         * Configurations/WebKitLegacy.xcconfig:
735         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
736           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
737           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
738           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
739           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
740           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
741           WEBCORE_PRIVATE_HEADERS_DIR_Production and
742           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
743           based on SDK.
744         - Fix PRODUCTION_ROOT to actually be set properly.
745         - Simplify EXPORTED_SYMBOLS_FILE_i386.
746
747         * migrate-headers.sh:
748         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
749         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
750           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
751           WebKitLegacy.xcconfig.
752
753 2014-12-18  Andreas Kling  <akling@apple.com>
754
755         Ref-ify various Document-related things.
756         <https://webkit.org/b/139796>
757
758         Reviewed by Anders Carlsson.
759
760         * WebView/WebFrame.mm:
761         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
762
763 2014-12-18  Beth Dakin  <bdakin@apple.com>
764
765         Need to re-enable action menus
766         https://bugs.webkit.org/show_bug.cgi?id=139795
767         -and corresponding-
768         rdar://problem/19299367
769
770         Reviewed by Tim Horton.
771
772         Re-enable the menus by un-commenting the code to create the menu and controller.
773         * WebView/WebView.mm:
774         (-[WebView _commonInitializationWithFrameName:groupName:]):
775
776 2014-12-16  Sam Weinig  <sam@webkit.org>
777
778         Unify the Mac and iOS implementations of FontPlatformData a bit
779         https://bugs.webkit.org/show_bug.cgi?id=139721
780
781         Reviewed by Anders Carlsson.
782
783         * WebView/WebHTMLView.mm:
784         (fontNameForDescription):
785         Update for new function name.
786
787 2014-12-18  Antti Koivisto  <antti@apple.com>
788
789         Remove alwaysUseBaselineOfPrimaryFont setting
790         https://bugs.webkit.org/show_bug.cgi?id=139770
791
792         Reviewed by Anders Carlsson.
793
794         * WebView/WebPreferenceKeysPrivate.h:
795         * WebView/WebPreferences.mm:
796         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
797         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
798         * WebView/WebPreferencesPrivate.h:
799         * WebView/WebView.mm:
800         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
801         (-[WebView _preferencesChanged:]):
802
803 2014-12-17  Andreas Kling  <akling@apple.com>
804
805         Ref-ify Range::create().
806         <https://webkit.org/b/139755>
807
808         Reviewed by Anders Carlsson.
809
810         * WebView/WebHTMLRepresentation.mm:
811         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
812         * WebView/WebHTMLView.mm:
813         (-[WebHTMLView attributedString]):
814
815 2014-12-17  Anders Carlsson  <andersca@apple.com>
816
817         Unify -[WebResource description]
818         https://bugs.webkit.org/show_bug.cgi?id=139762
819
820         Reviewed by Dan Bernstein.
821
822         * WebView/WebResource.mm:
823         (-[WebResource description]):
824
825 2014-12-17  Anders Carlsson  <andersca@apple.com>
826
827         Get rid of an ugly #define hack in WebFrameLoaderClient
828         https://bugs.webkit.org/show_bug.cgi?id=139761
829
830         Reviewed by Dan Bernstein.
831
832         Also replace @private with @package in all public headers, for consistency.
833
834         * History/WebBackForwardList.h:
835         * History/WebHistory.h:
836         * Misc/WebDownload.h:
837         * WebCoreSupport/WebFrameLoaderClient.mm:
838         * WebView/WebArchive.h:
839         * WebView/WebDataSource.h:
840         * WebView/WebFrame.h:
841         * WebView/WebFrameView.h:
842         * WebView/WebPreferences.h:
843         * WebView/WebResource.h:
844
845 2014-12-17  Dan Bernstein  <mitz@apple.com>
846
847         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
848         https://bugs.webkit.org/show_bug.cgi?id=139760
849
850         Reviewed by Anders Carlsson.
851
852         * Configurations/WebKitLegacy.xcconfig:
853
854 2014-12-17  Andreas Kling  <akling@apple.com>
855
856         Purge PassRefPtr from Frame.
857         <https://webkit.org/b/139731>
858
859         Reviewed by Anders Carlsson.
860
861         * WebCoreSupport/WebFrameLoaderClient.mm:
862         (WebFrameLoaderClient::transitionToCommittedForNewPage):
863         * WebView/WebFrame.mm:
864         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
865         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
866         * WebView/WebFrameInternal.h:
867
868 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
869
870         Implement and adopt two new TextIndicator presentation animations
871         https://bugs.webkit.org/show_bug.cgi?id=139715
872         <rdar://problem/19237945>
873
874         Reviewed by Anders Carlsson.
875
876         * WebView/WebActionMenuController.mm:
877         (-[WebActionMenuController _showTextIndicator]):
878         * WebView/WebHTMLView.mm:
879         (-[WebHTMLView quickLookWithEvent:]):
880         Remove the completionHandler from text indicator presentation.
881
882         * WebView/WebImmediateActionController.mm:
883         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
884         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
885         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
886         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
887         (-[WebImmediateActionController _menuItemForDataDetectedText]):
888         (-[WebImmediateActionController _animationControllerForText]):
889         (-[WebImmediateActionController _showTextIndicator]):
890         Forward immediate action gesture recognizer animation progress
891         to TextIndicator. Force us to keep the selection when immediate
892         action popovers steal first responder status from the WebView.
893         If the Lookup range is equal to the selection range, use a Crossfade
894         animation; otherwise, use a FadeIn animation.
895
896         * WebView/WebView.mm:
897         (-[WebView _setMaintainsInactiveSelection:]):
898         (-[WebView maintainsInactiveSelection]):
899         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
900         (-[WebView _setTextIndicator:fadeOut:]):
901         (-[WebView _clearTextIndicator]):
902         (-[WebView _setTextIndicatorAnimationProgress:]):
903         (-[WebView _showDictionaryLookupPopup:]):
904         (-[WebView _dictionaryLookupPopoverWillClose:]):
905         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
906         Remove the completionHandler from text indicator presentation.
907         Add a _setMaintainsInactiveSelection, which allows WebKit internals
908         to change the return value of -maintainsInactiveSelection, allowing
909         us to keep the selection alive when the WebView loses first responder status.
910
911         * WebView/WebViewData.h:
912         * WebView/WebViewInternal.h:
913
914 2014-12-16  Andreas Kling  <akling@apple.com>
915
916         Use Ref for SecurityOrigin.
917         <https://webkit.org/b/139710>
918
919         Reviewed by Anders Carlsson.
920
921         * Storage/WebStorageTrackerClient.mm:
922         (WebStorageTrackerClient::dispatchDidModifyOrigin):
923         * WebView/WebView.mm:
924         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
925         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
926
927 2014-12-16  Beth Dakin  <bdakin@apple.com>
928
929         Crash getting default animation controller for some text
930         https://bugs.webkit.org/show_bug.cgi?id=139712
931         -and corresponding-
932         rdar://problem/19271707
933
934         Reviewed by Tim Horton.
935
936         Must null-check the range.
937         * WebView/WebImmediateActionController.mm:
938         (-[WebImmediateActionController _animationControllerForText]):
939
940 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
941
942         Immediate action popovers can get stuck open
943         https://bugs.webkit.org/show_bug.cgi?id=139709
944         <rdar://problem/19270279>
945
946         Reviewed by Beth Dakin.
947
948         * WebView/WebImmediateActionController.mm:
949         (-[WebImmediateActionController _clearImmediateActionState]):
950         Don't clear the animation controller; it breaks things and was unnecessary.
951
952 2014-12-16  Tim Horton  <timothy_horton@apple.com>
953
954         Disable TextIndication for Lookup immediate actions
955         https://bugs.webkit.org/show_bug.cgi?id=139684
956
957         Reviewed by Anders Carlsson.
958
959         * WebView/WebView.mm:
960         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
961
962 2014-12-15  Beth Dakin  <bdakin@apple.com>
963
964         Build fix.
965
966         * WebView/WebImmediateActionController.mm:
967
968 2014-12-15  Beth Dakin  <bdakin@apple.com>
969
970         Speculative build fix.
971
972         * WebView/WebView.mm:
973         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
974         * WebView/WebViewInternal.h:
975
976 2014-12-15  Beth Dakin  <bdakin@apple.com>
977
978         Make lookup an immediate action instead of an action menu item
979         https://bugs.webkit.org/show_bug.cgi?id=139661
980         -and corresponding-
981         rdar://problem/19198414
982
983         Reviewed by Tim Horton.
984
985         Remove the lookup menu items and non-unused static function associated with 
986         lookup.
987         * WebView/WebActionMenuController.mm:
988         (-[WebActionMenuController _defaultMenuItemsForText]):
989         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
990         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
991         (-[WebActionMenuController _createActionMenuItemForTag:]):
992         (-[WebActionMenuController _lookupText:]): Deleted.
993         (performDictionaryLookupForSelection): Deleted.
994         (performDictionaryLookupForRange): Deleted.
995
996         Set the defaultAnimationController to the lookup-provided animation controller 
997         when appropriate.
998         * WebView/WebImmediateActionController.mm:
999         (-[WebImmediateActionController _defaultAnimationController]):
1000         (dictionaryPopupInfoForRange):
1001         (-[WebImmediateActionController _animationControllerForText]):
1002
1003         New type.
1004         * WebView/WebUIDelegatePrivate.h:
1005
1006         New function to get the lookup animation controller.
1007         * WebView/WebView.mm:
1008         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1009         * WebView/WebViewInternal.h:
1010
1011 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
1012
1013         Implement Data Detectors immediate actions for Legacy WebKit
1014         https://bugs.webkit.org/show_bug.cgi?id=139619
1015         <rdar://problem/19198539>
1016
1017         Reviewed by Beth Dakin.
1018
1019         * WebView/WebImmediateActionController.mm:
1020         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1021         Note that this action context is only for immediate actions.
1022
1023 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
1024
1025         Addressing post-review comments in r177035
1026         https://bugs.webkit.org/show_bug.cgi?id=139557
1027
1028         Reviewed by Darin Adler.
1029
1030         * WebView/WebActionMenuController.mm:
1031         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
1032
1033 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
1034
1035         Implement Data Detectors immediate actions for Legacy WebKit
1036         https://bugs.webkit.org/show_bug.cgi?id=139619
1037         <rdar://problem/19198539>
1038
1039         Reviewed by Eric Carlson.
1040
1041         * WebView/WebHTMLView.mm:
1042         (-[WebHTMLView mouseDown:mouseDown:]):
1043         Send mouseDown along to the WebImmediateActionController too.
1044
1045         * WebView/WebImmediateActionController.h:
1046         * WebView/WebImmediateActionController.mm:
1047         (-[WebImmediateActionController webViewClosed]):
1048         (-[WebImmediateActionController webView:willHandleMouseDown:]):
1049         (-[WebImmediateActionController _cancelImmediateAction]):
1050         (-[WebImmediateActionController _clearImmediateActionState]):
1051         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1052         (-[WebImmediateActionController _defaultAnimationController]):
1053         (-[WebImmediateActionController _updateImmediateActionItem]):
1054         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1055         (-[WebImmediateActionController _showTextIndicator]):
1056         (-[WebImmediateActionController _hideTextIndicator]):
1057         Copy most of the DataDetectors implementation into WebImmediateActionController.
1058
1059         * WebView/WebUIDelegatePrivate.h:
1060         Add a new type.
1061
1062         * WebView/WebView.mm:
1063         (-[WebView _commonInitializationWithFrameName:groupName:]):
1064         Temporarily disable action menus.
1065
1066         (-[WebView _immediateActionController]):
1067         * WebView/WebViewInternal.h:
1068
1069 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
1070
1071         Delete Notation because we don't use it
1072         https://bugs.webkit.org/show_bug.cgi?id=139171
1073
1074         Reviewed by Kent Tamura.
1075
1076         * MigrateHeaders.make:
1077
1078 2014-12-14  Andreas Kling  <akling@apple.com>
1079
1080         Replace PassRef with Ref/Ref&& across the board.
1081         <https://webkit.org/b/139587>
1082
1083         Reviewed by Darin Adler.
1084
1085         * WebCoreSupport/WebEditorClient.mm:
1086         (WebEditorClient::shouldApplyStyle):
1087         * WebCoreSupport/WebVisitedLinkStore.h:
1088         * WebCoreSupport/WebVisitedLinkStore.mm:
1089         (WebVisitedLinkStore::create):
1090
1091 2014-12-11  Dan Bernstein  <mitz@apple.com>
1092
1093         Fix a leak introduced in r177199.
1094
1095         Reviewed by Anders Carlsson.
1096
1097         * WebView/WebImmediateActionController.mm:
1098         (-[WebImmediateActionController _updateImmediateActionItem]):
1099
1100 2014-12-11  Beth Dakin  <bdakin@apple.com>
1101
1102         WK1: Need new SPI for Webkit clients to override default immediate action
1103         https://bugs.webkit.org/show_bug.cgi?id=139568
1104         -and corresponding-
1105         rdar://problem/19225448
1106
1107         Reviewed by Dan Bernstein.
1108
1109         Call SPI giving clients a chance to override the default behavior.
1110         * WebView/WebImmediateActionController.mm:
1111         (-[WebImmediateActionController _updateImmediateActionItem]):
1112
1113         New SPI.
1114         * WebView/WebUIDelegatePrivate.h:
1115
1116 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
1117
1118         Move the preview popover to WebImmediateActionController
1119         https://bugs.webkit.org/show_bug.cgi?id=139563
1120         <rdar://problem/19208291>
1121
1122         Reviewed by Beth Dakin.
1123
1124         * WebView/WebActionMenuController.mm:
1125         (-[WebActionMenuController _defaultMenuItemsForLink]):
1126         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
1127         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
1128         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
1129         * WebView/WebImmediateActionController.h:
1130         * WebView/WebImmediateActionController.mm:
1131         (-[WebImmediateActionController webViewClosed]):
1132         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1133         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1134         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1135         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1136         (-[WebImmediateActionController _updateImmediateActionItem]):
1137         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
1138         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
1139         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
1140         Move page preview popover related code to WebImmediateActionController.
1141
1142         * WebView/WebUIDelegatePrivate.h:
1143         Add a link preview type.
1144
1145         * WebView/WebView.mm:
1146         (-[WebView _commonInitializationWithFrameName:groupName:]):
1147         Pass the gesture recognizer to the WebImmediateActionController.
1148
1149 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
1150
1151         Fix the build.
1152
1153         * WebView/WebImmediateActionController.h:
1154         * WebView/WebImmediateActionController.mm:
1155
1156 2014-12-11  Anders Carlsson  <andersca@apple.com>
1157
1158         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
1159         https://bugs.webkit.org/show_bug.cgi?id=139547
1160
1161         Reviewed by Sam Weinig.
1162
1163         * WebView/WebView.mm:
1164         (+[WebView _handleMemoryWarning]):
1165
1166 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
1167
1168         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
1169         https://bugs.webkit.org/show_bug.cgi?id=139504
1170         rdar://problem/19034674
1171
1172         Reviewed by Enrica Casucci.
1173
1174         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
1175
1176         * WebCoreSupport/WebEditorClient.h:
1177         * WebCoreSupport/WebEditorClient.mm:
1178         (WebEditorClient::discardedComposition):
1179
1180 2014-12-10  Anders Carlsson  <andersca@apple.com>
1181
1182         Get rid of the storage strategy
1183         https://bugs.webkit.org/show_bug.cgi?id=139519
1184
1185         Reviewed by Antti Koivisto.
1186
1187         * WebCoreSupport/WebPlatformStrategies.h:
1188         * WebCoreSupport/WebPlatformStrategies.mm:
1189         (WebPlatformStrategies::createStorageStrategy): Deleted.
1190
1191 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
1192
1193         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
1194         https://bugs.webkit.org/show_bug.cgi?id=139529
1195         <rdar://problem/19213620>
1196
1197         Reviewed by Beth Dakin.
1198
1199         * WebView/WebActionMenuController.mm:
1200         (-[WebActionMenuController _copySelection:]):
1201         (-[WebActionMenuController _paste:]):
1202         Use the copy: and paste: methods on WebView so that we traverse subviews
1203         when trying to respond, otherwise these actions don't work in subframes.
1204
1205 2014-12-10  Beth Dakin  <bdakin@apple.com>
1206
1207         WK1: Add initial support for immediate actions
1208         https://bugs.webkit.org/show_bug.cgi?id=139522
1209
1210         Reviewed by Dan Bernstein.
1211
1212         This basic implementation of the controller will use the delegate methods to 
1213         perform and cache a HitTest when relevant. Future patches will patch 
1214         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
1215         immediate action that should be taken.
1216         * WebView/WebImmediateActionController.h: Added.
1217         * WebView/WebImmediateActionController.mm: Added.
1218         (-[WebImmediateActionController webViewClosed]):
1219         (-[WebImmediateActionController _clearImmediateActionState]):
1220         (-[WebImmediateActionController performHitTestAtPoint:]):
1221         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1222         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1223         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1224         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1225         (-[WebImmediateActionController _updateImmediateActionItem]):
1226
1227         New enum for immediate action types.
1228         * WebView/WebUIDelegatePrivate.h:
1229
1230         Create an NSImmediateActionGestureRecognizer if possible and a controller.
1231         * WebView/WebView.mm:
1232         (-[WebView _commonInitializationWithFrameName:groupName:]):
1233         (-[WebView _close]):
1234         * WebView/WebViewData.h:
1235         * WebView/WebViewData.mm:
1236         (-[WebViewPrivate dealloc]):
1237
1238 2014-12-08  Anders Carlsson  <andersca@apple.com>
1239
1240         Use the new storage namespace provider in WebKit1
1241         https://bugs.webkit.org/show_bug.cgi?id=139425
1242
1243         Reviewed by Tim Horton.
1244
1245         * WebView/WebView.mm:
1246         (-[WebView _commonInitializationWithFrameName:groupName:]):
1247         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1248         Set the storage namespace provider from the web page group.
1249
1250 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
1251
1252         Should have copy and paste items in all text menus
1253         https://bugs.webkit.org/show_bug.cgi?id=139510
1254         <rdar://problem/19198388>
1255
1256         Reviewed by Beth Dakin.
1257
1258         * WebView/WebActionMenuController.mm:
1259         (-[WebActionMenuController _defaultMenuItemsForText]):
1260         Add a disabled paste menu item into the read-only text menu.
1261
1262         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
1263         Add a disabled copy menu item into the editable whitespace text menu.
1264
1265 2014-12-10  Anders Carlsson  <andersca@apple.com>
1266
1267         Add WebStorageNamespaceProvider::closeLocalStorage
1268         https://bugs.webkit.org/show_bug.cgi?id=139502
1269
1270         Reviewed by Tim Horton.
1271
1272         * WebView/WebView.mm:
1273         (+[WebView _applicationWillTerminate]):
1274         Call WebStorageNamespaceProvider::closeLocalStorage.
1275
1276 2014-12-09  Commit Queue  <commit-queue@webkit.org>
1277
1278         Unreviewed, rolling out r177037.
1279         https://bugs.webkit.org/show_bug.cgi?id=139464
1280
1281         broke ~50 API tests (Requested by thorton on #webkit).
1282
1283         Reverted changeset:
1284
1285         "Use the new storage namespace provider in WebKit1"
1286         https://bugs.webkit.org/show_bug.cgi?id=139425
1287         http://trac.webkit.org/changeset/177037
1288
1289 2014-12-08  Anders Carlsson  <andersca@apple.com>
1290
1291         Use the new storage namespace provider in WebKit1
1292         https://bugs.webkit.org/show_bug.cgi?id=139425
1293
1294         Reviewed by Tim Horton.
1295
1296         * WebView/WebView.mm:
1297         (-[WebView _commonInitializationWithFrameName:groupName:]):
1298         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1299         Set the storage namespace provider from the web page group.
1300
1301 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
1302
1303         Delete Node::boundingBox()
1304         https://bugs.webkit.org/show_bug.cgi?id=139333
1305
1306         Reviewed by Zalan Bujtas.
1307
1308         * WebView/WebActionMenuController.mm:
1309         (elementBoundingBoxInWindowCoordinatesFromNode): Use
1310         RenderObject::absoluteBoundingBoxRect().
1311
1312 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
1313
1314         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
1315         https://bugs.webkit.org/show_bug.cgi?id=138843
1316         rdar://problem/18793695
1317
1318         Reviewed by Dan Bernstein.
1319
1320         * Panels/WebAuthenticationPanel.m:
1321         (-[WebAuthenticationPanel cancel:]):
1322         (-[WebAuthenticationPanel logIn:]):
1323         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
1324         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
1325         that only when using an old NSWindow API.
1326
1327 2014-12-08  Beth Dakin  <bdakin@apple.com>
1328
1329         Copy and Lookup menu items should be disabled when something is not copyable
1330         https://bugs.webkit.org/show_bug.cgi?id=139423
1331
1332         Reviewed by Tim Horton.
1333
1334         Disable both lookup and copy when a HitTestResult does not allow copy.
1335         * WebView/WebActionMenuController.mm:
1336
1337         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
1338         disable state otherwise.
1339         * WebView/WebView.mm:
1340         (-[WebView _commonInitializationWithFrameName:groupName:]):
1341
1342 2014-12-08  Anders Carlsson  <andersca@apple.com>
1343
1344         Adding user content to a group should force that group to be created
1345         https://bugs.webkit.org/show_bug.cgi?id=139421
1346         rdar://problem/19180108
1347
1348         Reviewed by Sam Weinig.
1349
1350         * WebCoreSupport/WebViewGroup.h:
1351         Store the local storage database path in the group.
1352
1353         * WebCoreSupport/WebViewGroup.mm:
1354         (WebViewGroup::getOrCreate):
1355         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
1356         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
1357
1358         (WebViewGroup::WebViewGroup):
1359         Initialize the new member variable.
1360
1361         (WebViewGroup::storageNamespaceProvider):
1362         Create the namespace provider lazily.
1363
1364         * WebView/WebView.mm:
1365         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1366         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1367         Use getOrCreate instead of get.
1368
1369 2014-12-08  Anders Carlsson  <andersca@apple.com>
1370
1371         WebStorageNamespaceProvider should know about its local storage database path
1372         https://bugs.webkit.org/show_bug.cgi?id=139413
1373
1374         Reviewed by Andreas Kling.
1375
1376         * WebCoreSupport/WebViewGroup.h:
1377         * WebCoreSupport/WebViewGroup.mm:
1378         (WebViewGroup::getOrCreate):
1379         (WebViewGroup::WebViewGroup):
1380         * WebView/WebView.mm:
1381         (-[WebView _commonInitializationWithFrameName:groupName:]):
1382         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1383         (-[WebView setGroupName:]):
1384         (-[WebView groupName]): Deleted.
1385
1386 2014-12-08  Daniel Bates  <dabates@apple.com>
1387
1388         [iOS] Fix the WebKit build with the public SDK
1389
1390         Include header NSURLDownloadSPI.h.
1391
1392         * WebCoreSupport/WebFrameLoaderClient.mm:
1393
1394 2014-12-07  Dan Bernstein  <mitz@apple.com>
1395
1396         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
1397         https://bugs.webkit.org/show_bug.cgi?id=139348
1398
1399         Reviewed by Anders Carlsson.
1400
1401         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
1402         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
1403         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
1404         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
1405         avoiding the ambiguity.
1406
1407         * WebView/WebActionMenuController.mm:
1408         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1409
1410 2014-12-06  Anders Carlsson  <andersca@apple.com>
1411
1412         Add a stubbed out version of WebStorageNamespaceProvider
1413         https://bugs.webkit.org/show_bug.cgi?id=139213
1414
1415         Reviewed by Sam Weinig.
1416
1417         * WebCoreSupport/WebViewGroup.h:
1418         (WebViewGroup::storageNamespaceProvider):
1419         * WebCoreSupport/WebViewGroup.mm:
1420         (WebViewGroup::getOrCreate):
1421         (WebViewGroup::WebViewGroup):
1422         Give WebViewGroup a storage namespace provider.
1423
1424 2014-12-06  Anders Carlsson  <andersca@apple.com>
1425
1426         Fix build with newer versions of clang.
1427         rdar://problem/18978687
1428
1429         Add missing overrides and missing casts.
1430
1431         * Storage/WebDatabaseManagerClient.h:
1432         * Storage/WebStorageTrackerClient.h:
1433         * WebCoreSupport/WebChromeClient.h:
1434         * WebCoreSupport/WebFrameLoaderClient.h:
1435         * WebCoreSupport/WebInspectorClient.h:
1436         * WebView/WebDataSource.mm:
1437         (-[WebDataSource _makeRepresentation]):
1438         * WebView/WebFrameView.mm:
1439         (-[WebFrameView _makeDocumentViewForDataSource:]):
1440
1441 2014-12-05  Tim Horton  <timothy_horton@apple.com>
1442
1443         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
1444         https://bugs.webkit.org/show_bug.cgi?id=139306
1445         <rdar://problem/19157955>
1446
1447         Reviewed by Beth Dakin.
1448
1449         * WebView/WebView.mm:
1450         (-[WebView _commonInitializationWithFrameName:groupName:]):
1451         (-[WebView _initWithFrame:frameName:groupName:]):
1452         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
1453
1454 2014-12-05  David Kilzer  <ddkilzer@apple.com>
1455
1456         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
1457         <http://webkit.org/b/139286>
1458
1459         Reviewed by Daniel Bates.
1460
1461         * Configurations/FeatureDefines.xcconfig: Switch back to using
1462         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
1463
1464 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
1465
1466         Fix the 32-bit build.
1467
1468         * WebView/WebView.mm:
1469         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1470
1471 2014-12-04  Tim Horton  <timothy_horton@apple.com>
1472
1473         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
1474         https://bugs.webkit.org/show_bug.cgi?id=139252
1475         <rdar://problem/19140827>
1476
1477         Reviewed by Anders Carlsson.
1478
1479         * WebView/WebView.mm:
1480         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1481         Adjust to the WebCore changes.
1482
1483 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
1484
1485         Implement action menus for tel: URLs
1486         https://bugs.webkit.org/show_bug.cgi?id=139240
1487         <rdar://problem/19115662>
1488
1489         Reviewed by Anders Carlsson.
1490
1491         * WebView/WebActionMenuController.mm:
1492         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1493         Make sure to use the newly created currentActionContext... everywhere.
1494
1495 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
1496
1497         Implement action menus for tel: URLs
1498         https://bugs.webkit.org/show_bug.cgi?id=139240
1499         <rdar://problem/19115662>
1500
1501         Reviewed by Anders Carlsson.
1502
1503         * WebView/WebActionMenuController.mm:
1504         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1505         Make sure to use the newly created currentActionContext.
1506
1507 2014-12-03  Beth Dakin  <bdakin@apple.com>
1508
1509         <input> elements get whitespace action menu instead of editable text menu
1510         https://bugs.webkit.org/show_bug.cgi?id=139241
1511         -and corresponding-
1512         rdar://problem/19072083
1513
1514         Reviewed by Sam Weinig.
1515
1516         We should disallow shadow content in the hit test. This is the default and it is 
1517         how context menus behave. We originally wanted to text inside shadow content so 
1518         that we could find the text, but the new function I added to HitTestResult will 
1519         allow that.
1520         * WebView/WebActionMenuController.mm:
1521         (-[WebActionMenuController performHitTestAtPoint:]):
1522
1523         Adjust to the fact that we don’t hit test shadow content any more.
1524         (-[WebActionMenuController focusAndSelectHitTestResult]):
1525
1526         Offer the text menus for text inside form controls.
1527         (-[WebActionMenuController _defaultMenuItems]):
1528
1529 2014-12-03  Tim Horton  <timothy_horton@apple.com>
1530
1531         Implement action menus for tel: URLs
1532         https://bugs.webkit.org/show_bug.cgi?id=139240
1533         <rdar://problem/19115662>
1534
1535         Reviewed by Anders Carlsson.
1536
1537         * WebView/WebActionMenuController.mm:
1538         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1539         Rename this function as it will work for both mailto and tel URLs.
1540         Adjust it to use contextForView:.
1541
1542         (-[WebActionMenuController webView:willHandleMouseDown:]):
1543         (-[WebActionMenuController prepareForMenu:withEvent:]):
1544         (-[WebActionMenuController didCloseMenu:withEvent:]):
1545         (-[WebActionMenuController _defaultMenuItems]):
1546         Don't check the menu type when going to interact with _currentActionContext.
1547         We'll only have a _currentActionContext if we have a data detected item,
1548         and there are multiple menu types that end up using DDActionContext.
1549
1550         * WebView/WebUIDelegatePrivate.h:
1551         Add a new type.
1552
1553 2014-12-03  Anders Carlsson  <andersca@apple.com>
1554
1555         Set a visited link store when creating a simple WebView
1556         https://bugs.webkit.org/show_bug.cgi?id=139234
1557         <rdar://problem/19132978>
1558
1559         Reviewed by Sam Weinig.
1560
1561         * WebView/WebView.mm:
1562         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1563
1564 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
1565
1566         Fix the build.
1567
1568         * WebCoreSupport/WebFrameLoaderClient.mm:
1569
1570 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
1571
1572         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
1573         https://bugs.webkit.org/show_bug.cgi?id=139149
1574
1575         Reviewed by Anders Carlsson.
1576
1577         This changes API behavior. I think that it's OK, because existing behavior made no sense.
1578         We used to delete caches from disk, but they were still active in memory. Now we also
1579         obsolete them in memory, so documents that use a cache still work, but new ones don't
1580         pick one up.
1581
1582         * WebCoreSupport/WebApplicationCache.mm:
1583         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
1584         need to delete in-momry caches too. Keep existing behavior.
1585         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
1586         that properly deletes caches.
1587
1588 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1589
1590         Remove a SnowLeopard-era quirk for QuickLook
1591         https://bugs.webkit.org/show_bug.cgi?id=139208
1592         <rdar://problem/19121822>
1593
1594         Reviewed by Alexey Proskuryakov.
1595
1596         * WebCoreSupport/WebFrameLoaderClient.h:
1597         * WebCoreSupport/WebFrameLoaderClient.mm:
1598
1599 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1600
1601         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
1602         https://bugs.webkit.org/show_bug.cgi?id=139204
1603
1604         Reviewed by Anders Carlsson.
1605
1606         * WebView/WebView.mm:
1607         (-[WebView _commonInitializationWithFrameName:groupName:]):
1608         (-[WebView _showDictionaryLookupPopup:]):
1609         * WebView/WebViewData.h:
1610         Work around this by delaying the softlinking (and setting up the notification
1611         observer) until we actually need it. There's still an underlying bug, but
1612         this will fix the test.
1613
1614 2014-12-02  Beth Dakin  <bdakin@apple.com>
1615
1616         Yet another build fix.
1617
1618         * WebView/WebActionMenuController.mm:
1619         (-[WebActionMenuController _defaultMenuItemsForLink]):
1620
1621 2014-12-02  Beth Dakin  <bdakin@apple.com>
1622
1623         Build fix.
1624
1625         * WebView/WebActionMenuController.mm:
1626         (-[WebActionMenuController _defaultMenuItemsForLink]):
1627
1628 2014-12-02  Beth Dakin  <bdakin@apple.com>
1629
1630         More build fixing.
1631
1632         * WebView/WebActionMenuController.mm:
1633         (-[WebActionMenuController _defaultMenuItemsForLink]):
1634
1635 2014-12-02  Beth Dakin  <bdakin@apple.com>
1636
1637         Should use standardQuickLookMenuItem for apps that don't implement customizations
1638         https://bugs.webkit.org/show_bug.cgi?id=139193
1639         -and corresponding-
1640         rdar://problem/18944696
1641
1642         Reviewed by Anders Carlsson.
1643
1644         Use [NSMenuItem standardQuickLookMenuItem].
1645         * WebView/WebActionMenuController.mm:
1646         (-[WebActionMenuController _defaultMenuItemsForLink]):
1647
1648         Delegate methods to set up the standardQuickLookMenuItem.
1649         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
1650         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
1651         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
1652
1653         Remove all of the old QLPreviewBubble code.
1654         (-[WebActionMenuController _createActionMenuItemForTag:]):
1655         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
1656
1657 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
1658
1659         Fix the build.
1660
1661         * WebView/WebViewData.h:
1662
1663 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1664
1665         Implement Lookup transition from selection for Legacy WebKit
1666         https://bugs.webkit.org/show_bug.cgi?id=139180
1667         <rdar://problem/19067172>
1668
1669         Reviewed by Beth Dakin.
1670
1671         * WebView/DictionaryPopupInfo.h: Added.
1672         Split DictionaryPopupInfo out into its own file.
1673
1674         * WebView/WebActionMenuController.mm:
1675         (-[WebActionMenuController _lookupText:]):
1676         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
1677
1678         (performDictionaryLookupForSelection):
1679         (performDictionaryLookupForRange):
1680         Plumb the transition style through these helpers.
1681         Create a TextIndicator from the selection range.
1682
1683         * WebView/WebHTMLView.mm:
1684         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
1685         Make use of TextIndicator (and DictionaryPopupInfo, and the new
1686         _showDictionaryLookupPopup on WebView) to add a transition from blue
1687         when performing Lookup from the context menu.
1688
1689         (-[WebHTMLView quickLookWithEvent:]):
1690         Remove our TextIndicator whenever a normal three-finger-tap event
1691         comes through, as it will have its own indication.
1692
1693         * WebView/WebView.mm:
1694         (-[WebView _commonInitializationWithFrameName:groupName:]):
1695         (-[WebView _dictionaryLookupPopoverWillClose:]):
1696         Register for the LUNotificationPopoverWillClose notification and remove
1697         our TextIndicator when it is called, just like in WebKit2.
1698         Deregistration is already handled in _close.
1699
1700         (-[WebView _showDictionaryLookupPopup:]):
1701         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
1702         if the relevant API is available.
1703
1704         * WebView/WebViewInternal.h:
1705
1706 2014-12-02  Anders Carlsson  <andersca@apple.com>
1707
1708         Remove visited link handling from PageGroup
1709         https://bugs.webkit.org/show_bug.cgi?id=139185
1710
1711         Reviewed by Sam Weinig.
1712
1713         * History/WebHistory.mm:
1714         (-[WebHistoryPrivate removeItemForURLString:]):
1715         (-[WebHistoryPrivate removeAllItems]):
1716         (+[WebHistory setOptionalSharedHistory:]):
1717         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1718         (+[WebHistory _removeAllVisitedLinks]):
1719         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
1720         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
1721         * History/WebHistoryInternal.h:
1722         * WebCoreSupport/WebChromeClient.h:
1723         * WebCoreSupport/WebChromeClient.mm:
1724         (WebChromeClient::populateVisitedLinks): Deleted.
1725         * WebView/WebView.mm:
1726         (-[WebView addVisitedLinks:]):
1727         (-[WebView removeVisitedLink:]):
1728
1729 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1730
1731         Try to fix the Mac build.
1732
1733         * WebView/WebView.mm:
1734         (-[WebView _commonInitializationWithFrameName:groupName:]):
1735         (-[WebView _close]):
1736
1737 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1738
1739         Fix the iOS build.
1740
1741         * WebView/WebActionMenuController.h:
1742         * WebView/WebActionMenuController.mm:
1743         * WebView/WebHTMLView.mm:
1744         (-[WebHTMLView scrollWheel:scrollWheel:]):
1745         (-[WebHTMLView mouseDown:mouseDown:]):
1746         * WebView/WebView.mm:
1747         * WebView/WebViewData.h:
1748         * WebView/WebViewData.mm:
1749         (-[WebViewPrivate dealloc]):
1750         * WebView/WebViewInternal.h:
1751
1752 2014-12-01  Tim Horton  <timothy_horton@apple.com>
1753
1754         Implement yellow highlight for WebKit1 data detectors
1755         https://bugs.webkit.org/show_bug.cgi?id=138956
1756         <rdar://problem/18992185>
1757
1758         Reviewed by Beth Dakin.
1759
1760         * WebView/WebActionMenuController.h:
1761         * WebView/WebActionMenuController.mm:
1762         (-[WebActionMenuController webView:willHandleMouseDown:]):
1763         (-[WebActionMenuController webView:didHandleScrollWheel:]):
1764         (-[WebActionMenuController prepareForMenu:withEvent:]):
1765         (-[WebActionMenuController didCloseMenu:withEvent:]):
1766         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1767         (-[WebActionMenuController _showTextIndicator]):
1768         (-[WebActionMenuController _hideTextIndicator]):
1769         (-[WebActionMenuController _dismissActionMenuPopovers]):
1770         Copy the WebKit2 WKActionMenuController TextIndicator implementation
1771         into WebActionMenuController. The only significant difference is
1772         that we build the TextIndicator right at menu construction time
1773         instead of in the Web process.
1774
1775         * WebView/WebHTMLView.mm:
1776         (-[WebHTMLView scrollWheel:]):
1777         Let the WebActionMenuController know that we're handling a scroll.
1778
1779         (-[WebHTMLView mouseDown:]):
1780         Let the WebActionMenuController know that we're handling a mouseDown.
1781
1782         * WebView/WebView.mm:
1783         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1784         (-[WebView _clearTextIndicator]):
1785         (-[WebView _actionMenuController]):
1786         (-[WebView _convertRectFromRootView:]): Deleted.
1787         * WebView/WebViewData.h:
1788         * WebView/WebViewData.mm:
1789         * WebView/WebViewInternal.h:
1790         Keep a TextIndicatorWindow on WebView, just like WKView does.
1791         Expose the WebActionMenuController on WebView (internally).
1792
1793 2014-12-01  Anders Carlsson  <andersca@apple.com>
1794
1795         Remove old site specific quirks code that was added in 2009
1796         https://bugs.webkit.org/show_bug.cgi?id=139141
1797
1798         Reviewed by Antti Koivisto.
1799
1800         * WebCoreSupport/WebFrameNetworkingContext.h:
1801         * WebCoreSupport/WebFrameNetworkingContext.mm:
1802         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
1803
1804 2014-11-30  Anders Carlsson  <andersca@apple.com>
1805
1806         Fix a test failure.
1807
1808         * History/WebHistory.mm:
1809         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1810         Call through to the visited link store.
1811
1812         (+[WebHistory _removeAllVisitedLinks]):
1813         Ditto.
1814
1815         * WebCoreSupport/WebVisitedLinkStore.mm:
1816         (WebVisitedLinkStore::isLinkVisited):
1817         Make sure to populate visited links.
1818
1819 2014-11-30  Anders Carlsson  <andersca@apple.com>
1820
1821         Switch over to the visited link store from the WebViewGroup
1822         https://bugs.webkit.org/show_bug.cgi?id=139112
1823
1824         Reviewed by Sam Weinig.
1825
1826         * WebView/WebView.mm:
1827         (-[WebView _commonInitializationWithFrameName:groupName:]):
1828         (-[WebView setGroupName:]):
1829
1830 2014-11-30  Anders Carlsson  <andersca@apple.com>
1831
1832         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
1833         https://bugs.webkit.org/show_bug.cgi?id=139111
1834
1835         Reviewed by Sam Weinig.
1836
1837         * WebCoreSupport/WebVisitedLinkStore.h:
1838         * WebCoreSupport/WebVisitedLinkStore.mm:
1839         (WebVisitedLinkStore::removeVisitedLink):
1840         * WebView/WebView.mm:
1841         (-[WebView removeVisitedLink:]):
1842
1843 2014-11-29  Anders Carlsson  <andersca@apple.com>
1844
1845         Populate visited links
1846         https://bugs.webkit.org/show_bug.cgi?id=139101
1847
1848         Reviewed by Sam Weinig.
1849
1850         * History/WebHistory.mm:
1851         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
1852         Helper function that adds all visited link to the given store.
1853
1854         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
1855         Call the private method.
1856
1857         * History/WebHistoryInternal.h:
1858         * WebCoreSupport/WebVisitedLinkStore.h:
1859         Add new members.
1860
1861         * WebCoreSupport/WebVisitedLinkStore.mm:
1862         (WebVisitedLinkStore::addVisitedLink):
1863         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
1864
1865         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1866         Implement this. First try the delegate, then try the shared history.
1867
1868         (WebVisitedLinkStore::addVisitedLinkHash):
1869         Factor code that adds the link to the hash table into a separate function.
1870
1871         * WebView/WebView.mm:
1872         (-[WebView addVisitedLinks:]):
1873         Add the visited links to the store.
1874
1875 2014-11-29  Anders Carlsson  <andersca@apple.com>
1876
1877         More work on the legacy WebKit visited link store
1878         https://bugs.webkit.org/show_bug.cgi?id=139100
1879
1880         Reviewed by Sam Weinig.
1881
1882         * History/WebHistory.mm:
1883         (+[WebHistory setOptionalSharedHistory:]):
1884         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
1885
1886         * WebCoreSupport/WebVisitedLinkStore.h:
1887         * WebCoreSupport/WebVisitedLinkStore.mm:
1888         (visitedLinkStores):
1889         (WebVisitedLinkStore::WebVisitedLinkStore):
1890         (WebVisitedLinkStore::~WebVisitedLinkStore):
1891         Keep track of live visited link stores.
1892
1893         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
1894         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
1895
1896         (WebVisitedLinkStore::removeAllVisitedLinks):
1897         Iterate over all live link stores and remove their links.
1898
1899         (WebVisitedLinkStore::isLinkVisited):
1900         Populate visited links and check if our hash table contains the link.
1901
1902         (WebVisitedLinkStore::addVisitedLink):
1903         Add the link hash to the table.
1904
1905         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1906         Add stub.
1907
1908         (WebVisitedLinkStore::removeVisitedLinkHashes):
1909         Clear out the hash table.
1910
1911 2014-11-27  Anders Carlsson  <andersca@apple.com>
1912
1913         Add a stubbed out WebVisitedLinkStore to WebViewGroup
1914         https://bugs.webkit.org/show_bug.cgi?id=139066
1915
1916         Reviewed by Antti Koivisto.
1917
1918         * WebCoreSupport/WebViewGroup.h:
1919         (WebViewGroup::visitedLinkStore):
1920         * WebCoreSupport/WebViewGroup.mm:
1921         (WebViewGroup::WebViewGroup):
1922         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1923         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1924         (WebVisitedLinkStore::create):
1925         (WebVisitedLinkStore::WebVisitedLinkStore):
1926         (WebVisitedLinkStore::~WebVisitedLinkStore):
1927         (WebVisitedLinkStore::isLinkVisited):
1928         (WebVisitedLinkStore::addVisitedLink):
1929
1930 2014-11-25  Anders Carlsson  <andersca@apple.com>
1931
1932         Remove user content handling from PageGroup
1933         https://bugs.webkit.org/show_bug.cgi?id=139051
1934
1935         Reviewed by Antti Koivisto.
1936
1937         Use the user content controller in the web view group.
1938
1939         * WebView/WebView.mm:
1940         (-[WebView _injectOutlookQuirksScript]):
1941
1942 2014-11-25  Anders Carlsson  <andersca@apple.com>
1943
1944         Add a user content controller to WebViewGroup and use it for user content
1945         https://bugs.webkit.org/show_bug.cgi?id=139043
1946
1947         Reviewed by Antti Koivisto.
1948
1949         This is another tiny step towards getting rid of user content handling inside PageGroup.
1950
1951         * WebCoreSupport/WebViewGroup.h:
1952         (WebViewGroup::userContentController):
1953         Add a UserContentController member and getter.
1954
1955         * WebCoreSupport/WebViewGroup.mm:
1956         (WebViewGroup::get):
1957         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
1958
1959         (WebViewGroup::WebViewGroup):
1960         Create a user content controller.
1961
1962         * WebView/WebView.mm:
1963         (-[WebView _commonInitializationWithFrameName:groupName:]):
1964         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
1965         set its user content controller in the PageConfiguration.
1966
1967         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1968         Ditto.
1969
1970         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1971         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1972         (+[WebView _removeUserScriptFromGroup:world:url:]):
1973         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
1974         (+[WebView _removeUserScriptsFromGroup:world:]):
1975         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
1976         (+[WebView _removeAllUserContentFromGroup:]):
1977         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
1978
1979         (-[WebView setGroupName:]):
1980         Set the user content controller to the new WebViewGroup's user content controller.
1981
1982 2014-11-21  Jer Noble  <jer.noble@apple.com>
1983
1984         Support multiple signatures of diagnostic logging.
1985         https://bugs.webkit.org/show_bug.cgi?id=138690
1986
1987         Reviewed by Anders Carlsson.
1988
1989         Page::PageClients has been renamed PageConfiguration.
1990
1991         * WebView/WebView.mm:
1992         (-[WebView _commonInitializationWithFrameName:groupName:]):
1993         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1994
1995 2014-11-21  Zalan Bujtas  <zalan@apple.com>
1996
1997         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
1998         https://bugs.webkit.org/show_bug.cgi?id=138981
1999
2000         Reviewed by Simon Fraser.
2001
2002         * WebView/WebPreferenceKeysPrivate.h:
2003         * WebView/WebPreferences.mm:
2004         (+[WebPreferences initialize]):
2005         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
2006         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
2007         * WebView/WebPreferencesPrivate.h:
2008         * WebView/WebView.mm:
2009         (-[WebView _preferencesChanged:]):
2010
2011 2014-11-21  Tim Horton  <timothy_horton@apple.com>
2012
2013         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
2014         ​https://bugs.webkit.org/show_bug.cgi?id=138960
2015         <rdar://problem/19056715>
2016
2017         Reviewed by Anders Carlsson.
2018
2019         * WebView/WebActionMenuController.mm:
2020         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
2021         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2022         Use DataDetectors SPI instead of an explicit blacklist.
2023
2024 2014-11-21  Tim Horton  <timothy_horton@apple.com>
2025
2026         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
2027         https://bugs.webkit.org/show_bug.cgi?id=138960
2028         <rdar://problem/19056715>
2029
2030         Reviewed by Beth Dakin.
2031
2032         * WebView/WebActionMenuController.mm:
2033         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2034         Blacklist contact results, because they don't have useful menus. If we
2035         bail before setting up _currentActionContext, we'll still allow fallthrough
2036         to ordinary text actions, avoiding mysterious failure when a contact is detected.
2037
2038         This doesn't break the case that r176351 was intended to fix,
2039         because in that case we were detecting e.g. addresses.
2040
2041 2014-11-21  Anders Carlsson  <andersca@apple.com>
2042
2043         Remove the Timer parameters from timer callbacks
2044         https://bugs.webkit.org/show_bug.cgi?id=138974
2045
2046         Reviewed by Antti Koivisto.
2047
2048         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2049         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2050         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
2051         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2052         * Plugins/WebNetscapePluginStream.h:
2053         * Plugins/WebNetscapePluginStream.mm:
2054         (WebNetscapePluginStream::WebNetscapePluginStream):
2055         (WebNetscapePluginStream::deliverDataTimerFired):
2056
2057 2014-11-21  Anders Carlsson  <andersca@apple.com>
2058
2059         Make memoryCache() return a reference
2060         https://bugs.webkit.org/show_bug.cgi?id=138939
2061
2062         Reviewed by Antti Koivisto.
2063
2064         * Misc/WebCache.mm:
2065         (+[WebCache statistics]):
2066         (+[WebCache emptyInMemoryResources]):
2067         (+[WebCache sizeOfDeadResources:]):
2068         (+[WebCache addImageToCache:forURL:forFrame:]):
2069         (+[WebCache removeImageFromCacheForURL:forFrame:]):
2070         (+[WebCache imageForURL:]):
2071         (+[WebCache setDisabled:]):
2072         (+[WebCache isDisabled]):
2073         * WebView/WebView.mm:
2074         (+[WebView _setCacheModel:]):
2075
2076 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
2077
2078         Remove the remaining vestiges of minimal-ui
2079         https://bugs.webkit.org/show_bug.cgi?id=138890
2080
2081         Reviewed by Sam Weinig.
2082
2083         * History/WebHistoryItem.mm:
2084         * History/WebHistoryItemPrivate.h:
2085
2086 2014-11-20  Tim Horton  <timothy_horton@apple.com>
2087
2088         Cancel DataDetectors menu earlier if we know it can't be presented
2089         https://bugs.webkit.org/show_bug.cgi?id=138922
2090         <rdar://problem/18950441>
2091
2092         Reviewed by Beth Dakin.
2093
2094         * WebView/WebActionMenuController.mm:
2095         (-[WebActionMenuController prepareForMenu:withEvent:]):
2096         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
2097         and use a bigger hammer (removeAllItems).
2098
2099         (-[WebActionMenuController willOpenMenu:withEvent:]):
2100         If we end up with a menu with no items, don't change selection or anything.
2101
2102 2014-11-20  Beth Dakin  <bdakin@apple.com>
2103
2104         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
2105         https://bugs.webkit.org/show_bug.cgi?id=138568
2106         -and corresponding-
2107         rdar://problem/18904600
2108
2109         Reviewed by Tim Horton.
2110
2111         Skip images for lookup.
2112         * WebView/WebActionMenuController.mm:
2113         (performDictionaryLookupForRange):
2114
2115 2014-11-19  Beth Dakin  <bdakin@apple.com>
2116
2117         Invoking an action menu on a selection should result in the text menu
2118         https://bugs.webkit.org/show_bug.cgi?id=138892
2119         -and corresponding-
2120         rdar://problem/18996776
2121
2122         Reviewed by Tim Horton.
2123
2124         * WebView/WebActionMenuController.mm:
2125         (-[WebActionMenuController _defaultMenuItems]):
2126
2127 2014-11-19  Beth Dakin  <bdakin@apple.com>
2128
2129         Data detected results with no menu items should not fall through to regular text 
2130         action menus
2131         https://bugs.webkit.org/show_bug.cgi?id=138887
2132         -and corresponding-
2133         rdar://problem/18971616
2134
2135         Reviewed by Tim Horton.
2136
2137         * WebView/WebActionMenuController.mm:
2138         (-[WebActionMenuController _defaultMenuItems]):
2139
2140 2014-11-19  Daniel Bates  <dabates@apple.com>
2141
2142         [iOS] Make WebKit build with public iOS SDK
2143         https://bugs.webkit.org/show_bug.cgi?id=136863
2144
2145         Reviewed by David Kilzer.
2146
2147         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
2148         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
2149         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
2150         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
2151         may be used by Apple internal clients that do not include wtf/Platform.h.
2152         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
2153         private Foundation headers directly.
2154         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
2155         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
2156         instead of including private CFNetwork headers directly. Also fixed up style and
2157         ordering of header include directives.
2158         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
2159         CFNetwork headers directly. Also sort the #import directives.
2160         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
2161         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
2162
2163 2014-11-18  David Kilzer  <ddkilzer@apple.com>
2164
2165         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
2166         <http://webkit.org/b/138813>
2167
2168         Reviewed by Mark Rowe.
2169
2170         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
2171         selectors.
2172
2173 2014-11-18  Chris Dumez  <cdumez@apple.com>
2174
2175         Add a setting to toggle DOMTimer throttling support
2176         https://bugs.webkit.org/show_bug.cgi?id=138844
2177         <rdar://problem/19020874>
2178
2179         Reviewed by Andreas Kling.
2180
2181         Add a setting to disable DOM timers throttling, in order to help
2182         developers determine if a specific issue is caused by timer
2183         throttling.
2184
2185         * WebView/WebPreferenceKeysPrivate.h:
2186         * WebView/WebPreferences.mm:
2187         (+[WebPreferences initialize]):
2188         (-[WebPreferences domTimersThrottlingEnabled]):
2189         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
2190         * WebView/WebPreferencesPrivate.h:
2191         * WebView/WebView.mm:
2192         (-[WebView _preferencesChanged:]):
2193
2194 2014-11-18  Tim Horton  <timothy_horton@apple.com>
2195
2196         Avoid re-encoding action menu image data
2197         https://bugs.webkit.org/show_bug.cgi?id=138817
2198         <rdar://problem/18840382>
2199
2200         Reviewed by Anders Carlsson.
2201
2202         * WebView/WebActionMenuController.mm:
2203         (-[WebActionMenuController _defaultMenuItemsForImage:]):
2204         (-[WebActionMenuController _addImageToPhotos:]):
2205         Build a temporary filename from a UUID and the image's desired extension.
2206         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
2207         Build an image menu only if we have an image, URL, data, and extension.
2208
2209 2014-11-18  Daniel Bates  <dabates@apple.com>
2210
2211         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2212         SPI are not available in public SDK
2213         https://bugs.webkit.org/show_bug.cgi?id=138802
2214
2215         Reviewed by David Kilzer.
2216
2217         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
2218         libdispatch and MobileGestalt headers directly.
2219
2220         * WebView/WebView.mm:
2221
2222 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
2223
2224         Remove calls to deprecated NSMenu methods
2225         https://bugs.webkit.org/show_bug.cgi?id=138808.
2226
2227         Reviewed by Anders Carlsson.
2228
2229         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
2230
2231         * WebCoreSupport/PopupMenuMac.mm:
2232         (PopupMenuMac::populate):
2233
2234 2014-11-17  Daniel Bates  <dabates@apple.com>
2235
2236         Unreviewed, rolling out r176232.
2237
2238         Broke the Mac build. Will investigate offline.
2239
2240         Reverted changeset:
2241
2242         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
2243         MobileGestalt"
2244         https://bugs.webkit.org/show_bug.cgi?id=138802
2245         http://trac.webkit.org/changeset/176232
2246
2247 2014-11-17  Daniel Bates  <dabates@apple.com>
2248
2249         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2250         SPI are not available in public SDK
2251         https://bugs.webkit.org/show_bug.cgi?id=138802
2252
2253         Reviewed by David Kilzer.
2254
2255         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
2256         libdispatch and MobileGestalt headers directly.
2257
2258         * WebView/WebView.mm:
2259
2260 2014-11-17  Beth Dakin  <bdakin@apple.com>
2261
2262         Whitespace action menus should focus the HitTestResult and create an insertion 
2263         point
2264         https://bugs.webkit.org/show_bug.cgi?id=138786
2265         -and corresponding-
2266         rdar://problem/18944893
2267
2268         Reviewed by Tim Horton.
2269
2270         Whitespace menus should cause the HitTestResult to be focused, and they should set 
2271         the selection based on the HitTest location.
2272
2273         * WebView/WebActionMenuController.mm:
2274         (-[WebActionMenuController isMenuForTextContent]):
2275         (-[WebActionMenuController focusAndSelectHitTestResult]):
2276         (-[WebActionMenuController willOpenMenu:withEvent:]):
2277
2278 2014-11-17  Daniel Bates  <dabates@apple.com>
2279
2280         [iOS] QuartzCore SPI not available in public SDK
2281         https://bugs.webkit.org/show_bug.cgi?id=138751
2282
2283         Reviewed by David Kilzer.
2284
2285         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
2286
2287         * WebInspector/WebNodeHighlight.mm:
2288         * WebView/WebIndicateLayer.mm:
2289
2290 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
2291
2292         [iOS] allow host application to opt-out of alternate fullscreen
2293         https://bugs.webkit.org/show_bug.cgi?id=138787
2294
2295         Reviewed by Darin Adler.
2296
2297         * WebView/WebPreferenceKeysPrivate.h:
2298         * WebView/WebPreferences.mm:
2299         (+[WebPreferences initialize]):
2300         (-[WebPreferences allowsAlternateFullscreen]):
2301         (-[WebPreferences setAllowsAlternateFullscreen:]):
2302         * WebView/WebPreferencesPrivate.h:
2303         * WebView/WebView.mm:
2304         (-[WebView _preferencesChanged:]):
2305
2306 2014-11-16  Tim Horton  <timothy_horton@apple.com>
2307
2308         Use TextIndicator instead of the built in Lookup highlight
2309         https://bugs.webkit.org/show_bug.cgi?id=138775
2310         <rdar://problem/18953982>
2311
2312         Reviewed by Anders Carlsson.
2313
2314         * WebCoreSupport/WebSystemInterface.mm:
2315         (InitWebCoreSystemInterface):
2316         Remove a WKSI import.
2317
2318         * WebView/WebActionMenuController.mm:
2319         (-[WebActionMenuController _lookupText:]):
2320         (-[WebActionMenuController _createActionMenuItemForTag:]):
2321         Make use of the new Lookup SPI header.
2322         Disable the Lookup item if lookup is not available.
2323
2324 2014-11-15  Tim Horton  <timothy_horton@apple.com>
2325
2326         Implement data detectors and mailto action menus for WebKit1
2327         https://bugs.webkit.org/show_bug.cgi?id=138765
2328         <rdar://problem/18877535>
2329
2330         Reviewed by Beth Dakin.
2331
2332         * WebView/WebActionMenuController.h:
2333         * WebView/WebActionMenuController.mm:
2334         (-[WebActionMenuController willOpenMenu:withEvent:]):
2335         Tell DataDetectors that the menu is going to open.
2336         Select the text (or not) based on the number of items in the menu, just like WebKit2.
2337
2338         (-[WebActionMenuController didCloseMenu:withEvent:]):
2339         Tell DataDetectors that the menu closed.
2340
2341         (-[WebActionMenuController _defaultMenuItemsForLink]):
2342         Move these checks out of _defaultMenuItemsForLink, because we expect this
2343         to always return a complete link menu.
2344
2345         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
2346         Implement. More or less copied from WebKit2.
2347
2348         (-[WebActionMenuController _selectDataDetectedText]):
2349         Select the stashed range.
2350
2351         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2352         Implement. More or less copied from WebKit2.
2353         The yellow highlight isn't hooked up yet.
2354         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
2355
2356         (-[WebActionMenuController _selectLookupText]):
2357         Remove an unnecessary return.
2358
2359         (-[WebActionMenuController _defaultMenuItems]):
2360         Call into the two new menu types.
2361
2362         * WebView/WebUIDelegatePrivate.h:
2363
2364 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
2365
2366         Get rid of WebFontCache
2367         https://bugs.webkit.org/show_bug.cgi?id=134752
2368
2369         Reviewed by Dave Hyatt.
2370
2371         * WebView/WebHTMLView.mm:
2372
2373 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
2374
2375         Update some artwork for the legacy WebKit action menu
2376         https://bugs.webkit.org/show_bug.cgi?id=138758
2377         <rdar://problem/18989840>
2378
2379         * WebView/WebActionMenuController.mm:
2380         (webKitBundleImageNamed): Deleted.
2381         Fix the build.
2382
2383 2014-11-14  Tim Horton  <timothy_horton@apple.com>
2384
2385         Update some artwork for the legacy WebKit action menu
2386         https://bugs.webkit.org/show_bug.cgi?id=138758
2387         <rdar://problem/18989840>
2388
2389         Reviewed by Simon Fraser.
2390
2391         * WebView/WebActionMenuController.mm:
2392         (-[WebActionMenuController _createActionMenuItemForTag:]):
2393
2394 2014-11-14  Daniel Bates  <dabates@apple.com>
2395
2396         [iOS] NSFileManager and QuickLook SPI not available in public SDK
2397         https://bugs.webkit.org/show_bug.cgi?id=138742
2398
2399         Reviewed by Pratik Solanki.
2400
2401         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
2402
2403         * WebCoreSupport/WebFrameLoaderClient.mm:
2404
2405 2014-11-14  Beth Dakin  <bdakin@apple.com>
2406
2407         WK1: Webpage preview can come up in wrong location
2408         https://bugs.webkit.org/show_bug.cgi?id=138747
2409         -and corresponding-
2410         rdar://problem/18979004
2411
2412         Reviewed by Tim Horton.
2413
2414         Converting to window twice is bad.
2415         * WebView/WebActionMenuController.mm:
2416         (elementBoundingBoxInWindowCoordinatesFromNode):
2417         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2418         (elementBoundingBoxFromNode): Deleted.
2419
2420 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
2421
2422         Move FontMac and FontCacheMac off of WKSI
2423         https://bugs.webkit.org/show_bug.cgi?id=138633
2424
2425         Reviewed by Simon Fraser.
2426
2427         * WebCoreSupport/WebSystemInterface.mm:
2428         (InitWebCoreSystemInterface):
2429         * WebKit.order:
2430
2431 2014-11-13  Beth Dakin  <bdakin@apple.com>
2432
2433         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
2434         https://bugs.webkit.org/show_bug.cgi?id=138716
2435         -and corresponding-
2436         rdar://problem/18977222
2437
2438         Reviewed by Tim Horton.
2439
2440         It’s not necessary to use the WebElementDictionary for so many things now that we 
2441         are caching the HitTestResult. We should just use the HitTestResult.
2442
2443         * WebView/WebActionMenuController.mm:
2444         (-[WebActionMenuController prepareForMenu:withEvent:]):
2445         (-[WebActionMenuController _openURLFromActionMenu:]):
2446         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2447         (elementBoundingBoxFromNode):
2448         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2449         (-[WebActionMenuController _defaultMenuItemsForLink]):
2450         (-[WebActionMenuController _defaultMenuItemsForImage]):
2451         (-[WebActionMenuController _defaultMenuItemsForVideo]):
2452         (-[WebActionMenuController _defaultMenuItemsForText]):
2453         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
2454         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
2455         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
2456         (-[WebActionMenuController _createActionMenuItemForTag:]):
2457         (-[WebActionMenuController _defaultMenuItems]):
2458         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
2459         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
2460         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
2461         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
2462         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
2463         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
2464         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
2465         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
2466         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
2467         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
2468
2469 2014-11-13  Daniel Bates  <dabates@apple.com>
2470
2471         [iOS] NSGeometry data types are not available in the public SDK
2472         https://bugs.webkit.org/show_bug.cgi?id=137536
2473
2474         Reviewed by David Kilzer.
2475
2476         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
2477         private header.
2478
2479         * DOM/WebDOMOperationsPrivate.h:
2480
2481 2014-11-13  Beth Dakin  <bdakin@apple.com>
2482
2483         WK1: Support default actions for video
2484         https://bugs.webkit.org/show_bug.cgi?id=138713
2485         -and corresponding-
2486         rdar://problem/18877520
2487
2488         Reviewed by Tim Horton.
2489
2490         Call setToNonShadowAncestor() for media HitTestResults.
2491         * WebView/WebActionMenuController.mm:
2492         (-[WebActionMenuController performHitTestAtPoint:]):
2493
2494         Default items and actions.
2495         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
2496         (-[WebActionMenuController _copyVideoURL:]):
2497         (-[WebActionMenuController _saveVideoToDownloads:]):
2498         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2499         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2500         * WebView/WebUIDelegatePrivate.h:
2501
2502 2014-11-13  Tim Horton  <timothy_horton@apple.com>
2503
2504         WK1: Update icon for Add to Reading List
2505         https://bugs.webkit.org/show_bug.cgi?id=138710
2506         <rdar://problem/18975774>
2507
2508         Reviewed by Beth Dakin.
2509
2510         * WebView/WebActionMenuController.mm:
2511         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2512         Use the right icon, matching WebKit2.
2513
2514 2014-11-12  Beth Dakin  <bdakin@apple.com>
2515
2516         WK1: Support default actions for images
2517         https://bugs.webkit.org/show_bug.cgi?id=138668
2518         -and corresponding-
2519         rdar://problem/18785434
2520
2521         Reviewed by Tim Horton.
2522
2523         * WebView/WebActionMenuController.h:
2524         * WebView/WebActionMenuController.mm:
2525         (-[WebActionMenuController didCloseMenu:withEvent:]):
2526         (-[WebActionMenuController _defaultMenuItemsForImage:]):
2527         (-[WebActionMenuController _copyImage:]):
2528         (temporaryPhotosDirectoryPath):
2529         (pathToPhotoOnDisk):
2530         (-[WebActionMenuController _canAddMediaToPhotos]):
2531         (-[WebActionMenuController _addImageToPhotos:]):
2532         (-[WebActionMenuController _saveImageToDownloads:]):
2533         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
2534         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
2535         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2536         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2537         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2538         * WebView/WebUIDelegatePrivate.h:
2539
2540 2014-11-11  Beth Dakin  <bdakin@apple.com>
2541
2542         Action menu hit testing is not working properly with all WK1 apps
2543         https://bugs.webkit.org/show_bug.cgi?id=138643
2544         -and corresponding-
2545         rdar://problem/18949376
2546
2547         Reviewed by Tim Horton.
2548
2549         * WebView/WebActionMenuController.mm:
2550         (-[WebActionMenuController prepareForMenu:withEvent:]):
2551         (-[WebActionMenuController _lookupText:]):
2552
2553 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2554
2555         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
2556         https://bugs.webkit.org/show_bug.cgi?id=138623
2557
2558         Reviewed by Geoff Garen.
2559
2560         * WebCoreSupport/WebSystemInterface.mm:
2561         (InitWebCoreSystemInterface):
2562         * WebKit.order:
2563
2564 2014-11-11  Tim Horton  <timothy_horton@apple.com>
2565
2566         Localize strings for action menus
2567         https://bugs.webkit.org/show_bug.cgi?id=138591
2568         <rdar://problem/18815343>
2569
2570         Reviewed by Dan Bates.
2571
2572         * WebView/WebActionMenuController.mm:
2573         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2574         Make use of the new strings.
2575
2576 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2577
2578         Cleanup from r175379
2579         https://bugs.webkit.org/show_bug.cgi?id=138616
2580
2581         Reviewed by Simon Fraser.
2582
2583         * WebCoreSupport/WebSystemInterface.mm:
2584         (InitWebCoreSystemInterface):
2585         * WebKit.order:
2586
2587 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2588
2589         Move CTFontTransformGlyphs out from WKSI
2590         https://bugs.webkit.org/show_bug.cgi?id=138599
2591
2592         Reviewed by Simon Fraser.
2593
2594         * WebCoreSupport/WebSystemInterface.mm:
2595         (InitWebCoreSystemInterface):
2596         * WebKit.order:
2597
2598 2014-11-11  Dan Bernstein  <mitz@apple.com>
2599
2600         More iOS build fix.
2601
2602         * WebView/WebHTMLViewInternal.h:
2603
2604 2014-11-11  Dan Bernstein  <mitz@apple.com>
2605
2606         iOS build fix.
2607
2608         * WebView/WebHTMLView.mm:
2609
2610 2014-11-10  Beth Dakin  <bdakin@apple.com>
2611
2612         WK1: Support default actions for editable text with misspelled word
2613         https://bugs.webkit.org/show_bug.cgi?id=138590
2614         -and corresponding-
2615         rdar://problem/18877506
2616
2617         Reviewed by Tim Horton.
2618
2619         If there are misspelled word suggestions for editable text, create a new type of 
2620         menu with a spelling suggestion sub-menu.
2621
2622         * WebView/WebActionMenuController.mm:
2623         (-[WebActionMenuController isMenuForTextContent]):
2624         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
2625         (-[WebActionMenuController _changeSelectionToSuggestion:]):
2626         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2627         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2628         * WebView/WebHTMLView.mm:
2629         (-[WebHTMLView _changeSpellingToWord:]):
2630         * WebView/WebHTMLViewInternal.h:
2631         * WebView/WebUIDelegatePrivate.h:
2632
2633 2014-11-10  Beth Dakin  <bdakin@apple.com>
2634
2635         WK1: Support default actions for editable whitespace
2636         https://bugs.webkit.org/show_bug.cgi?id=138586
2637         -and corresponding-
2638         rdar://problem/18932048
2639
2640         Reviewed by Tim Horton.
2641
2642         New menu type. Just wants paste.
2643
2644         * WebView/WebActionMenuController.mm:
2645         (-[WebActionMenuController isMenuForTextContent]):
2646         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
2647         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2648         * WebView/WebUIDelegatePrivate.h:
2649
2650 2014-11-10  Beth Dakin  <bdakin@apple.com>
2651
2652         WK1: Support default actions for editable text
2653         https://bugs.webkit.org/show_bug.cgi?id=138580
2654         -and corresponding-
2655         rdar://problem/18877497
2656
2657         Reviewed by Tim Horton.
2658
2659         New menu type, and new action type for paste. 
2660
2661         * WebView/WebActionMenuController.mm:
2662         (-[WebActionMenuController isMenuForTextContent]):
2663         (-[WebActionMenuController willOpenMenu:withEvent:]):
2664         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
2665         (-[WebActionMenuController _paste:]):
2666         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2667         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2668         * WebView/WebUIDelegatePrivate.h:
2669
2670 2014-11-10  Beth Dakin  <bdakin@apple.com>
2671
2672         WK1: Text is getting selected even when an action menu fails to invoke
2673         https://bugs.webkit.org/show_bug.cgi?id=138576
2674         -and corresponding-
2675         rdar://problem/18931330
2676
2677         Reviewed by Tim Horton.
2678
2679         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
2680         * WebView/WebActionMenuController.h:
2681         * WebView/WebActionMenuController.mm:
2682         (-[WebActionMenuController prepareForMenu:withEvent:]):
2683         (-[WebActionMenuController willOpenMenu:withEvent:]):
2684
2685         _selectLookupText no longer needs to return a BOOL indicating success or failure.
2686         (-[WebActionMenuController _selectLookupText]):
2687         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2688
2689         Pass willOpenMenu: on to the controller.
2690         * WebView/WebView.mm:
2691         (-[WebView willOpenMenu:withEvent:]):
2692
2693 2014-11-10  Beth Dakin  <bdakin@apple.com>
2694
2695         Speculative build fix.
2696
2697         * WebView/WebActionMenuController.mm:
2698
2699 2014-11-10  Beth Dakin  <bdakin@apple.com>
2700
2701         Action menu initialization should be moved to _commonInitializationWithFrameName
2702         https://bugs.webkit.org/show_bug.cgi?id=138572
2703         -and corresponding-
2704         rdar://problem/18929733
2705
2706         Reviewed by Tim Horton.
2707
2708         * WebView/WebView.mm:
2709         (-[WebView _commonInitializationWithFrameName:groupName:]):
2710         (-[WebView _initWithFrame:frameName:groupName:]):
2711
2712 2014-11-10  Beth Dakin  <bdakin@apple.com>
2713
2714         WK1: Support default actions for read-only text
2715         https://bugs.webkit.org/show_bug.cgi?id=138552
2716         -and corresponding-
2717         rdar://problem/18877483
2718
2719         Reviewed by Tim Horton.
2720
2721         New WKSystemInterface functions that WebCore needs to use.
2722         * WebCoreSupport/WebSystemInterface.mm:
2723         (InitWebCoreSystemInterface):
2724
2725         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
2726         makes a lot of things easier.
2727         * WebView/WebActionMenuController.h:
2728         * WebView/WebActionMenuController.mm:
2729
2730         Perform the hit test ourselves instead of calling into WebView so that we can more 
2731         easily save the WebCore::HitTestResult for ourselves.
2732         (-[WebActionMenuController performHitTestAtPoint:]):
2733
2734         Clear selection for non-text menus.
2735         (-[WebActionMenuController prepareForMenu:withEvent:]):
2736
2737         Re-set the _type here just to be safe.
2738         (-[WebActionMenuController didCloseMenu:withEvent:]):
2739
2740         Moving this method to be next to the link actions so they can be within a pragma 
2741         mark.
2742         (-[WebActionMenuController _defaultMenuItemsForLink:]):
2743
2744         New method for default text actions — lookup and copy.
2745         (-[WebActionMenuController _defaultMenuItemsForText:]):
2746         (-[WebActionMenuController _copySelection:]):
2747         (-[WebActionMenuController _lookupText:]):
2748
2749         If there is not already a selection, invoking the action menu on text should 
2750         select the lookup text.
2751         (-[WebActionMenuController _selectLookupText]):
2752         (performDictionaryLookupForSelection):
2753         (performDictionaryLookupForRange):
2754
2755         Handle text now.
2756         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2757         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2758
2759         New enum values.
2760         * WebView/WebUIDelegatePrivate.h:
2761
2762         Pass didCloseMenu on to the controller.
2763         * WebView/WebView.mm:
2764         (-[WebView didCloseMenu:withEvent:]):
2765
2766 2014-11-09  Chris Dumez  <cdumez@apple.com>
2767
2768         Add a more correct way to compare floating point numbers and use it
2769         https://bugs.webkit.org/show_bug.cgi?id=138527
2770
2771         Reviewed by Darin Adler.
2772
2773         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
2774         to compare floating-point numbers.
2775
2776         * WebView/WebHTMLView.mm:
2777         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
2778
2779 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
2780
2781         Delete cookies between tests
2782         https://bugs.webkit.org/show_bug.cgi?id=138528
2783
2784         Reviewed by Sam Weinig.
2785
2786         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
2787         * WebView/WebPreferencesPrivate.h:
2788         Added an SPI for DumpRenderTree.
2789
2790 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
2791
2792         [iOS] Update optimized fullscreen media controls
2793         https://bugs.webkit.org/show_bug.cgi?id=138493
2794
2795         Reviewed by Brent Fulgham.
2796
2797         * WebCoreSupport/WebSystemInterface.mm:
2798         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
2799
2800 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
2801
2802         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
2803         https://bugs.webkit.org/show_bug.cgi?id=138443
2804
2805         Reviewed by Anders Carlsson.
2806
2807         Wrapping the dealloc method in its own autorelease pool avoids the problem of
2808         complex tear-downs leading to the WebView itself being added to an autorelease
2809         pool that is not drained until after the instance has been dealloc'd.
2810  
2811         * WebView/WebView.mm:
2812         (-[WebView dealloc]):
2813
2814 2014-11-05  Jer Noble  <jer.noble@apple.com>
2815
2816         De-templatize Timer
2817         https://bugs.webkit.org/show_bug.cgi?id=138450
2818
2819         Reviewed by Anders Carlsson.
2820
2821         Remove template specifiers from Timer.
2822
2823         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2824         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2825         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2826         * Plugins/WebNetscapePluginStream.h:
2827         * Plugins/WebNetscapePluginStream.mm:
2828         (WebNetscapePluginStream::deliverDataTimerFired):
2829
2830 2014-11-05  Dan Bernstein  <mitz@apple.com>
2831
2832         Remove the unused deletion UI feature
2833         https://bugs.webkit.org/show_bug.cgi?id=138442
2834
2835         Rubber-stamped by Alexey Proskuryakov.
2836
2837         * DefaultDelegates/WebDefaultEditingDelegate.m:
2838         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
2839         * WebCoreSupport/WebEditorClient.h:
2840         * WebCoreSupport/WebEditorClient.mm:
2841         (WebEditorClient::shouldShowDeleteInterface): Deleted.
2842         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
2843         -webView:shouldShowDeleteInterfaceForElement:.
2844
2845 2014-11-03  Dean Jackson  <dino@apple.com>
2846
2847         Add ENABLE_FILTERS_LEVEL_2 feature guard.
2848         https://bugs.webkit.org/show_bug.cgi?id=138362
2849
2850         Reviewed by Tim Horton.
2851
2852         Add a new feature define for Level 2 of CSS Filters.
2853         http://dev.w3.org/fxtf/filters-2/
2854
2855         * Configurations/FeatureDefines.xcconfig:
2856
2857 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
2858
2859         Add button and enable optimized fullscreen.
2860         https://bugs.webkit.org/show_bug.cgi?id=138351
2861
2862         Reviewed by Eric Carlson.
2863
2864         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
2865
2866         * WebCoreSupport/WebSystemInterface.mm:
2867         (InitWebCoreSystemInterface): added
2868
2869 2014-11-04  Chris Dumez  <cdumez@apple.com>
2870
2871         Add ptr() method to Ref class
2872         https://bugs.webkit.org/show_bug.cgi?id=138361
2873
2874         Reviewed by Darin Adler.
2875
2876         Use the new Ref::ptr() method.
2877
2878         * WebView/WebFrame.mm:
2879         (-[WebFrame _setTypingStyle:withUndoAction:]):
2880         * WebView/WebHTMLView.mm:
2881         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
2882         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
2883         * WebView/WebView.mm:
2884         (-[WebView applyStyle:]):
2885
2886 2014-11-04  Darin Adler  <darin@apple.com>
2887
2888         Eliminate ResourceBuffer and use SharedBuffer directly instead
2889         https://bugs.webkit.org/show_bug.cgi?id=138174
2890
2891         Reviewed by Antti Koivisto.
2892
2893         * WebView/WebDataSource.mm:
2894         (-[WebDataSource data]): Use SharedBuffer directly.
2895         * WebView/WebHTMLView.mm:
2896         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2897
2898 2014-11-03  Commit Queue  <commit-queue@webkit.org>
2899
2900         Unreviewed, rolling out r175406, r175413, and r175423.
2901         https://bugs.webkit.org/show_bug.cgi?id=138327
2902
2903         Multipart tests are still broken (Requested by ap on #webkit).
2904
2905         Reverted changesets:
2906
2907         "Eliminate ResourceBuffer and use SharedBuffer directly
2908         instead"
2909         https://bugs.webkit.org/show_bug.cgi?id=138174
2910         http://trac.webkit.org/changeset/175406
2911
2912         "Unreviewed, iOS build fix since 175406."
2913         http://trac.webkit.org/changeset/175413
2914
2915         "Fix assertion in CachedResource::addDataBuffer"
2916         http://trac.webkit.org/changeset/175423
2917
2918 2014-10-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2919
2920         Use std::unique_ptr for TypeCountSet
2921         https://bugs.webkit.org/show_bug.cgi?id=138242
2922
2923         Reviewed by Andreas Kling.
2924
2925         * Misc/WebCoreStatistics.mm:
2926         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr.
2927         (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto.
2928
2929 2014-10-31  Beth Dakin  <bdakin@apple.com>
2930
2931         Use system art for action menus when possible
2932         https://bugs.webkit.org/show_bug.cgi?id=138260
2933
2934         Reviewed by Tim Horton.
2935
2936         * WebView/WebActionMenuController.mm:
2937         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2938
2939 2014-10-30  Darin Adler  <darin@apple.com>
2940
2941         Eliminate ResourceBuffer and use SharedBuffer directly instead
2942         https://bugs.webkit.org/show_bug.cgi?id=138174
2943
2944         Reviewed by Antti Koivisto.
2945
2946         * WebView/WebDataSource.mm:
2947         (-[WebDataSource data]): Use SharedBuffer directly.
2948         * WebView/WebHTMLView.mm:
2949         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2950
2951 2014-10-30  Jer Noble  <jer.noble@apple.com>
2952
2953         [EME] Add Setting for accessing storage location for MediaKeys data
2954         https://bugs.webkit.org/show_bug.cgi?id=138147
2955
2956         Reviewed by Brady Eidson.
2957
2958         * WebView/WebPreferenceKeysPrivate.h:
2959         * WebView/WebPreferences.mm:
2960         (+[WebPreferences initialize]): Set default location.
2961         (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor.
2962         (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter.
2963         * WebView/WebPreferencesPrivate.h:
2964         * WebView/WebView.mm:
2965         (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings.
2966
2967 2014-10-30  Dana Burkart  <dburkart@apple.com>
2968
2969         <rdar://problem/18821260> Prepare for the mysterious future
2970
2971         Reviewed by Lucas Forschler.
2972
2973         * Configurations/Base.xcconfig:
2974         * Configurations/DebugRelease.xcconfig:
2975         * Configurations/FeatureDefines.xcconfig:
2976         * Configurations/Version.xcconfig:
2977
2978 2014-10-28  Jeremy Jones  <jeremyj@apple.com>
2979
2980         Add optimized fullscreen mode.
2981         https://bugs.webkit.org/show_bug.cgi?id=138044
2982
2983         Reviewed by Jer Noble.
2984
2985         Enable different types of fullscreen video behavior.
2986         Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
2987
2988         * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
2989         * WebCoreSupport/WebChromeClient.mm:
2990         (WebChromeClient::enterVideoFullscreenForVideoElement): ditto
2991         * WebView/WebView.mm:
2992         (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
2993         (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.
2994         * WebView/WebViewInternal.h: ditto
2995
2996 2014-10-27  Beth Dakin  <bdakin@apple.com>
2997
2998         Provide a way for WebKit1 clients to override default action menu items
2999         https://bugs.webkit.org/show_bug.cgi?id=138066
3000         -and corresponding-
3001         rdar://problem/18451638
3002
3003         Reviewed by Anders Carlsson.
3004
3005         WebActionMenuController now has an ivar for the WebActionMenuType so that it can 
3006         send that along to clients customizing the menu.
3007         * WebView/WebActionMenuController.h:
3008         * WebView/WebActionMenuController.mm:
3009         (-[WebActionMenuController prepareForMenu:withEvent:]):
3010         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3011
3012         New enum and new SPI to customize menus.
3013         * WebView/WebUIDelegatePrivate.h:
3014
3015 2014-10-24  Benjamin Poulain  <bpoulain@apple.com>
3016
3017         Fix the iOS build
3018
3019         * Configurations/WebKitLegacy.xcconfig:
3020         * WebView/WebView.mm:
3021
3022 2014-10-24  Beth Dakin  <bdakin@apple.com>
3023
3024         Build fix.
3025
3026         * WebView/WebActionMenuController.mm:
3027         (-[WebActionMenuController _openURLFromActionMenu:]):
3028         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
3029         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
3030
3031 2014-10-24  Beth Dakin  <bdakin@apple.com>
3032
3033         WebKit1 should support action menus
3034         https://bugs.webkit.org/show_bug.cgi?id=138032
3035
3036         Reviewed by Tim Horton.
3037
3038         This patch adds basic support for action menus and adds actions for links.
3039
3040         Helper class takes care of all of the action menu work. WebView will forward the 
3041         prepareForMenu: message, and then the helper class takes it from there.
3042         * WebView/WebActionMenuController.h: Added.
3043         * WebView/WebActionMenuController.mm: Added.
3044         (-[WebActionMenuController webViewClosed]):
3045         (-[WebActionMenuController prepareForMenu:withEvent:]):
3046
3047         Selectors for link actions.
3048         (-[WebActionMenuController _openURLFromActionMenu:]):
3049         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
3050         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
3051         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
3052         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3053         (webKitBundleImageNamed):
3054         (-[WebActionMenuController _defaultMenuItemsForLink:]):
3055         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3056
3057         Tags for the action menu items.
3058         * WebView/WebUIDelegatePrivate.h:
3059         * WebView/WebView.mm:
3060
3061         Set the action menu if possible and create the controller.
3062         (-[WebView _initWithFrame:frameName:groupName:]):
3063         (-[WebView _close]):
3064         (-[WebView prepareForMenu:withEvent:]):
3065
3066         WebViewData stores the WebActionMenuHelper
3067         * WebView/WebViewData.h:
3068         * WebView/WebViewData.mm:
3069         (-[WebViewPrivate dealloc]):
3070
3071 2014-10-23  Joseph Pecoraro  <pecoraro@apple.com>
3072
3073         Web Inspector: Provide a way to have alternate inspector agents
3074         https://bugs.webkit.org/show_bug.cgi?id=137901
3075
3076         Reviewed by Brian Burg.
3077
3078         * Configurations/FeatureDefines.xcconfig:
3079
3080 2014-10-23  Tim Horton  <timothy_horton@apple.com>
3081
3082         Add some SPI headers for NSExtension and NSSharingService{Picker}
3083         https://bugs.webkit.org/show_bug.cgi?id=138027
3084
3085         Reviewed by Anders Carlsson.
3086
3087         * Misc/WebSharingServicePickerController.h:
3088         * Misc/WebSharingServicePickerController.mm:
3089         * WebCoreSupport/WebSelectionServiceController.mm:
3090         * WebCoreSupport/WebContextMenuClient.mm:
3091         Fix a sorting issue.
3092         Replace redefinitions with SPI header #imports.
3093
3094 2014-10-23  Tim Horton  <timothy_horton@apple.com>
3095
3096         Crashes under WebSelectionServiceController::hasRelevantSelectionServices
3097         https://bugs.webkit.org/show_bug.cgi?id=138013
3098
3099         Reviewed by Dan Bernstein.
3100
3101         * WebCoreSupport/WebSelectionServiceController.mm:
3102         (WebSelectionServiceController::hasRelevantSelectionServices):
3103         Don't adopt this autoreleased object.
3104
3105 2014-10-22  Chris Dumez  <cdumez@apple.com>
3106
3107         [Mac][WK2] Fix applicationIsSafari() detection
3108         https://bugs.webkit.org/show_bug.cgi?id=137893
3109
3110         Reviewed by Alexey Proskuryakov.
3111
3112         Provide an implementation for FrameLoaderClient's new
3113         needsQuickLookResourceCachingQuirks() that returns
3114         a static flag initialized using
3115         QuickLookMac::computeNeedsQuickLookResourceCachingQuirks().
3116
3117         * WebCoreSupport/WebFrameLoaderClient.h:
3118         * WebCoreSupport/WebFrameLoaderClient.mm:
3119
3120 2014-10-20  Chris Dumez  <cdumez@apple.com>
3121
3122         ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition
3123         https://bugs.webkit.org/show_bug.cgi?id=137797
3124
3125         Reviewed by Darin Adler.
3126
3127         Call ResourceRequest::setDomainForPartitionName() instead of
3128         setPartitionName() as the argument is a domain, not a valid
3129         partition name.
3130
3131         * Misc/WebCache.mm:
3132         (+[WebCache addImageToCache:forURL:forFrame:]):
3133         (+[WebCache removeImageFromCacheForURL:forFrame:]):
3134
3135 2014-10-20  Andy Estes  <aestes@apple.com>
3136
3137         Fix the iOS build.
3138
3139         * WebView/WebFrame.mm:
3140         (-[WebFrame getDictationResultRanges:andMetadatas:]):
3141         (-[WebFrame dictationResultMetadataForRange:]):
3142
3143 2014-10-19  Chris Dumez  <cdumez@apple.com>
3144
3145         Use is<>() / downcast<>() for all remaining RenderObject subclasses
3146         https://bugs.webkit.org/show_bug.cgi?id=137845
3147
3148         Reviewed by Darin Adler.
3149
3150         Use is<>() / downcast<>() for all remaining RenderObject subclasses and 
3151         clean up the surrounding code.
3152
3153         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3154         (-[WebHostedNetscapePluginView pluginHostDied]):
3155         * Plugins/WebBaseNetscapePluginView.mm:
3156         (-[WebBaseNetscapePluginView _windowClipRect]):
3157         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
3158         * WebCoreSupport/WebFrameLoaderClient.mm:
3159         (WebFrameLoaderClient::createPlugin):
3160         (WebFrameLoaderClient::createJavaAppletWidget):
3161
3162 2014-10-17  Tim Horton  <timothy_horton@apple.com>
3163
3164         Build fix for 32-bit Yosemite
3165
3166         * WebCoreSupport/WebContextMenuClient.mm:
3167         (WebContextMenuClient::contextMenuForEvent):
3168         Avoid using NSItemProvider in 32-bit, because it doesn't exist.
3169
3170 2014-10-17  Chris Dumez  <cdumez@apple.com>
3171
3172         Use is<>() / downcast<>() for RenderBox
3173         https://bugs.webkit.org/show_bug.cgi?id=137804
3174
3175         Reviewed by Andreas Kling.
3176
3177         Use is<>() / downcast<>() for RenderBox and clean up the surrounding
3178         code.
3179
3180         * WebCoreSupport/WebContextMenuClient.mm:
3181         (WebContextMenuClient::clientFloatRectForNode):
3182         * WebView/WebFrame.mm:
3183         (-[WebFrame renderedSizeOfNode:constrainedToWidth:]):
3184
3185 2014-10-17  Tim Horton  <timothy_horton@apple.com>
3186
3187         Fix the build with the public SDK.
3188
3189         * WebCoreSupport/WebSelectionServiceController.mm:
3190         We should transition all this SPI to real SPI headers as soon as possible.
3191
3192 2014-10-16  Tim Horton  <timothy_horton@apple.com>
3193
3194         Implement selection services menu for Legacy WebKit
3195         https://bugs.webkit.org/show_bug.cgi?id=137582
3196         <rdar://problem/18604241>
3197
3198         Reviewed by Brady Eidson.
3199
3200         * Misc/WebSharingServicePickerController.h:
3201         Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
3202         Add WebSharingServicePickerClient, which other classes can implement
3203         instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
3204         Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.
3205
3206         * Misc/WebSharingServicePickerController.mm:
3207         Pass in NSSharingServicePickerStyle, so that clients can specify the style.
3208
3209         (-[WebSharingServicePickerController clear]):
3210         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
3211         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
3212         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
3213         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
3214         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
3215         Make use of WebSharingServicePickerClient.
3216
3217         (-[WebSharingServicePickerController sharingService:didShareItems:]):
3218         If we're returned a NSAttributedString, paste it on top of the current selection,
3219         similar to what the WebKit2 implementation currently does.
3220         
3221         * WebCoreSupport/WebChromeClient.h:
3222         * WebCoreSupport/WebChromeClient.mm:
3223         (WebChromeClient::handleTelephoneNumberClick):
3224         (WebChromeClient::handleSelectionServiceClick):
3225         (WebChromeClient::hasRelevantSelectionServices):
3226         Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.
3227
3228         * WebCoreSupport/WebContextMenuClient.h:
3229         * WebCoreSupport/WebContextMenuClient.mm:
3230         (WebContextMenuClient::sharingServicePickerWillBeDestroyed):
3231         (WebContextMenuClient::pageForSharingServicePicker):
3232         (WebContextMenuClient::windowForSharingServicePicker):
3233         (WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
3234         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3235         (WebContextMenuClient::contextMenuForEvent):
3236         (WebContextMenuClient::screenRectForHitTestNode): Deleted.
3237         (WebContextMenuClient::renderedImageForControlledImage): Deleted.
3238         (WebContextMenuClient::clearSharingServicePickerController): Deleted.
3239         Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
3240         having WebSharingServicePickerController tightly bound to it.
3241         Make an NSItemProvider array when instantiating WebSharingServicePickerController
3242         instead of handing it data directly.
3243
3244         * WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
3245         * WebCoreSupport/WebSelectionServiceController.mm: Added.
3246         (WebSelectionServiceController::WebSelectionServiceController):
3247         Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
3248         for selection services.
3249
3250         (WebSelectionServiceController::handleSelectionServiceClick):
3251         Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.
3252
3253         (hasCompatibleServicesForItems):
3254         (WebSelectionServiceController::hasRelevantSelectionServices):
3255         Determine whether or not services are available.
3256
3257         (WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
3258         (WebSelectionServiceController::pageForSharingServicePicker):
3259         (WebSelectionServiceController::windowForSharingServicePicker):
3260         Implement the rest of the WebSharingServicePickerClient overrides.
3261
3262         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
3263         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
3264         These are only useful for image sharing services, so we don't need to
3265         implement them (WebContextMenuClient does, on the other hand).
3266
3267         * WebView/WebView.mm:
3268         (-[WebView _selectionServiceController]):
3269         * WebView/WebViewData.h:
3270         * WebView/WebViewData.mm:
3271         * WebView/WebViewInternal.h:
3272         Keep a WebSelectionServiceController.
3273
3274 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
3275
3276         Improve debug description of WAKViews
3277         https://bugs.webkit.org/show_bug.cgi?id=137716
3278
3279         Reviewed by Simon Fraser.
3280
3281         * WebView/WebView.mm:
3282         (-[WebView _touchEventRegions]): Adding a comment.
3283
3284 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
3285
3286         Addressing post-review comment.
3287         https://bugs.webkit.org/show_bug.cgi?id=137550
3288
3289         Unreviewed.
3290
3291         * WebView/WebHTMLView.mm:
3292         (fontNameForDescription):
3293         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3294
3295 2014-10-14  Chris Dumez  <cdumez@apple.com>
3296
3297         Use is<>() / downcast<>() for RenderImage
3298         https://bugs.webkit.org/show_bug.cgi?id=137683
3299
3300         Reviewed by Mihnea Ovidenie.
3301
3302         Use is<>() / downcast<>() for RenderImage.
3303
3304         * Misc/WebNSPasteboardExtras.mm:
3305         (imageFromElement):
3306         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3307
3308 2014-10-10  Daniel Bates  <dabates@apple.com>
3309
3310         Remove unused classes WebRender{Node, Layer}
3311         https://bugs.webkit.org/show_bug.cgi?id=137628
3312
3313         Reviewed by Simon Fraser.
3314
3315         We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
3316         For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.
3317
3318         * Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list
3319         of excluded source files when building for iOS.
3320         * WebKit.exp: Remove symbol for WebRenderLayer.
3321         * WebKit.mac.exp: Remove symbol for WebRenderNode.
3322         * WebView/WebRenderLayer.h: Removed.
3323         * WebView/WebRenderLayer.mm: Removed.
3324         * WebView/WebRenderNode.h: Removed.
3325         * WebView/WebRenderNode.mm: Removed.
3326
3327 2014-10-10  Chris Dumez  <cdumez@apple.com>
3328
3329         Use is<>() / downcast<>() for RenderBoxModelObject
3330         https://bugs.webkit.org/show_bug.cgi?id=137587
3331
3332         Reviewed by Mihnea Ovidenie.
3333
3334         Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
3335         surrounding code.
3336
3337         * Plugins/WebBaseNetscapePluginView.mm:
3338         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
3339         * WebView/WebRenderLayer.mm:
3340         (-[WebRenderLayer initWithWebFrame:]):
3341
3342 2014-10-09  Dean Jackson  <dino@apple.com>
3343
3344         Remove ENABLE_CSS3_CONDITIONAL_RULES
3345         https://bugs.webkit.org/show_bug.cgi?id=137571
3346
3347         Reviewed by Simon Fraser.
3348
3349         * Configurations/FeatureDefines.xcconfig:
3350
3351 2014-10-09  Tim Horton  <timothy_horton@apple.com>
3352
3353         Add a WebKit1 preference for selection services
3354         https://bugs.webkit.org/show_bug.cgi?id=137498
3355         <rdar://problem/18572699>
3356
3357         Reviewed by Simon Fraser.
3358
3359         * WebView/WebPreferenceKeysPrivate.h:
3360         * WebView/WebPreferences.mm:
3361         (+[WebPreferences initialize]):
3362         (-[WebPreferences serviceControlsEnabled]):
3363         (-[WebPreferences setServiceControlsEnabled:]):
3364         * WebView/WebPreferencesPrivate.h:
3365         * WebView/WebView.mm:
3366         (-[WebView _preferencesChanged:]):
3367         Add and plumb the preference.
3368
3369 2014-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
3370
3371         Remove second-to-last client of WebFontCache
3372         https://bugs.webkit.org/show_bug.cgi?id=137550
3373
3374         Reviewed by Darin Adler.
3375
3376         Use FontCache::getCachedFontData() instead of WebFontCache.
3377
3378         * WebView/WebHTMLView.mm:
3379         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3380
3381 2014-10-09  Chris Dumez  <cdumez@apple.com>
3382
3383         Use is<>() / downcast<>() for Widget subclasses
3384         https://bugs.webkit.org/show_bug.cgi?id=137549
3385
3386         Reviewed by Darin Adler.
3387
3388         Use is<>() / downcast<>() for Widget subclasses and clean up the
3389         surrounding code.
3390
3391         * WebView/WebRenderNode.mm:
3392         (copyRenderNode):
3393         * WebView/WebView.mm:
3394         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
3395
3396 2014-10-07  Christophe Dumez  <cdumez@apple.com>
3397
3398         Use is<>() / downcast<>() for RenderText / RenderTextFragment
3399         https://bugs.webkit.org/show_bug.cgi?id=137476
3400
3401         Reviewed by Darin Adler.
3402
3403         * WebView/WebRenderNode.mm:
3404         (copyRenderNode):
3405
3406 2014-10-06  Dan Bernstein  <mitz@apple.com>
3407
3408         Build fix.
3409
3410         * Misc/WebCache.mm:
3411         (+[WebCache imageForURL:]):
3412
3413 2014-10-06  Chris Dumez  <cdumez@apple.com>
3414
3415         Unreviewed build fix after r174333.
3416
3417         Forgot explicit WebCore:: namespace.
3418
3419         * Misc/WebCache.mm:
3420         (+[WebCache imageForURL:]):
3421
3422 2014-10-05  Christophe Dumez  <cdumez@apple.com>
3423
3424         Use is<>() / downcast<>() for CachedResource subclasses
3425         https://bugs.webkit.org/show_bug.cgi?id=137431
3426
3427         Reviewed by Benjamin Poulain.
3428
3429         Use is<>() / downcast<>() for CachedResource subclasses.
3430
3431         * Misc/WebCache.mm:
3432         (+[WebCache imageForURL:]):
3433
3434 2014-10-02  Daniel Bates  <dabates@apple.com>
3435
3436         Use version number 101000 instead of 10100 for OS X Yosemite
3437         https://bugs.webkit.org/show_bug.cgi?id=137372
3438
3439         Reviewed by Mark Rowe.
3440
3441         The version number for OS X Yosemite is 101000.
3442
3443         * WebView/WebView.mm:
3444         (-[WebView _preferencesChanged:]):
3445
3446 2014-10-02  Tim Horton  <timothy_horton@apple.com>
3447
3448         Move PageOverlay[Controller] to WebCore
3449         https://bugs.webkit.org/show_bug.cgi?id=137164
3450         <rdar://problem/18508258>
3451
3452         Reviewed by Anders Carlsson.
3453
3454         * WebCoreSupport/WebChromeClient.h:
3455         * WebCoreSupport/WebChromeClient.mm:
3456         (WebChromeClient::attachViewOverlayGraphicsLayer):
3457         Add an empty ChromeClient override.
3458
3459 2014-10-01  Christophe Dumez  <cdumez@apple.com>
3460
3461         Have is<>(T*) function do a null check on the pointer argument
3462         https://bugs.webkit.org/show_bug.cgi?id=137333
3463
3464         Reviewed by Gavin Barraclough.
3465
3466         Have is<>(T*) function do a null check on the argument instead of a
3467         simple assertion. This makes sense for 2 reasons:
3468         1. It is more consistent with downcast<>(T*), which will succeed even
3469            if the argument is a nullptr.
3470         2. It simplifies the code a bit as it gets rid of a lot of explicit
3471            null checks.
3472
3473         * WebCoreSupport/WebChromeClient.mm:
3474         (WebChromeClient::focusedElementChanged):
3475         * WebCoreSupport/WebEditorClient.mm:
3476         (WebEditorClient::textFieldDidBeginEditing):
3477         (WebEditorClient::textFieldDidEndEditing):
3478         (WebEditorClient::textDidChangeInTextField):
3479         (WebEditorClient::doTextFieldCommandFromEvent):
3480         (WebEditorClient::textWillBeDeletedInTextField):
3481         (WebEditorClient::textDidChangeInTextArea):
3482         * WebView/WebHTMLRepresentation.mm:
3483         (inputElementFromDOMElement):
3484         (searchForLabelsBeforeElement):
3485         * WebView/WebRenderLayer.mm:
3486         (+[WebRenderLayer nameForLayer:]):
3487
3488 2014-10-01  Mark Rowe  <mrowe@apple.com>
3489
3490         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
3491
3492         Reviewed by Dan Bernstein.
3493
3494         * Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite.
3495
3496 2014-09-30  Chris Dumez  <cdumez@apple.com>
3497
3498         Use is<>() / downcast<>() for Element
3499         https://bugs.webkit.org/show_bug.cgi?id=137241
3500
3501         Reviewed by Andreas Kling.
3502
3503         Use is<>() / downcast<>() for Element instead of isElementNode() /
3504         toElement().
3505
3506         * WebView/WebRenderLayer.mm:
3507         (+[WebRenderLayer nameForLayer:]):
3508
3509 2014-09-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3510
3511         Move ColorInputType class to std::unique_ptr
3512         https://bugs.webkit.org/show_bug.cgi?id=137173
3513
3514         Reviewed by Darin Adler.
3515
3516         Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr.
3517         Child classes follow this change as well.
3518
3519         * WebCoreSupport/WebChromeClient.h:
3520         * WebCoreSupport/WebChromeClient.mm:
3521         (WebChromeClient::createColorChooser):
3522
3523 2014-09-24  Christophe Dumez  <cdumez@apple.com>
3524
3525         Add initial is<>() / downcast<>() support for any type of Nodes
3526         https://bugs.webkit.org/show_bug.cgi?id=137056
3527
3528         Reviewed by Benjamin Poulain.
3529
3530         Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
3531         instead of isFormControlElement() / toHTMLFormControlElement().
3532
3533         * WebView/WebHTMLRepresentation.mm:
3534         (searchForLabelsBeforeElement):
3535
3536 2014-09-24  Christophe Dumez  <cdumez@apple.com>
3537
3538         Use is<HTML*Element>() instead of isHTML*Element() - Part 1
3539         https://bugs.webkit.org/show_bug.cgi?id=137068
3540
3541         Reviewed by Ryosuke Niwa.
3542
3543         Start using is<HTML*Element>() instead of isHTML*Element().
3544         Remaining usages will be updated in a follow-up patch to
3545         reduce the size of the change.
3546
3547         * WebCoreSupport/WebChromeClient.mm:
3548         (WebChromeClient::focusedElementChanged):
3549         * WebCoreSupport/WebEditorClient.mm:
3550         (WebEditorClient::textFieldDidBeginEditing):
3551         (WebEditorClient::textFieldDidEndEditing):
3552         (WebEditorClient::textDidChangeInTextField):
3553         (WebEditorClient::doTextFieldCommandFromEvent):
3554         (WebEditorClient::textWillBeDeletedInTextField):
3555         (WebEditorClient::textDidChangeInTextArea):
3556         * WebView/WebHTMLRepresentation.mm:
3557         (inputElementFromDOMElement):
3558
3559 2014-09-21  Timothy Hatcher  <timothy@apple.com>
3560
3561         Make the Web Inspector use a separate web process.
3562
3563         https://bugs.webkit.org/show_bug.cgi?id=135120
3564
3565         Reviewed by Anders Carlsson.
3566
3567         * WebCoreSupport/WebInspectorClient.h:
3568         * WebCoreSupport/WebInspectorClient.mm:
3569         (WebInspectorClient::WebInspectorClient):
3570         (WebInspectorClient::openInspectorFrontend):
3571         (WebInspectorClient::releaseFrontend):
3572         Own WebInspectorFrontendClient instead of moving it.
3573
3574 2014-09-23  Chris Dumez  <cdumez@apple.com>
3575
3576         Use downcast<HTML*Element>() instead of toHTML*Element()
3577         https://bugs.webkit.org/show_bug.cgi?id=137007
3578