1 2011-03-09 Jessie Berlin <jberlin@apple.com>
3 Reviewed by Adam Roben.
5 Use the Cookie Storage from the Private Browsing Storage Session directly
6 https://bugs.webkit.org/show_bug.cgi?id=55986
8 * WebCoreSupport/WebSystemInterface.mm:
9 (InitWebCoreSystemInterface):
11 2011-03-08 Darin Adler <darin@apple.com>
13 Reviewed by Timothy Hatcher.
15 Promote a method used outside WebKit from internal to private
16 https://bugs.webkit.org/show_bug.cgi?id=55949
18 * Misc/WebNSPasteboardExtras.mm: Removed an unused category declaration.
19 Minor tweak, not directly related to the rest of this patch.
21 * WebView/WebFrame.mm:
22 (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): Moved
23 this method from the internal category into the private category.
24 Streamlined the code a bit.
26 * WebView/WebFrameInternal.h: Removed _computePageRects method.
27 * WebView/WebFramePrivate.h: Added _computePageRects method.
29 2011-03-07 Ryosuke Niwa <rniwa@webkit.org>
31 Reviewed by Darin Adler.
33 selectionHasStyle and selectionStartHasStyle should use EditingStyle
34 https://bugs.webkit.org/show_bug.cgi?id=55902
36 selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.
38 * WebView/WebHTMLView.mm: Removed unused selectionHasStyle.
39 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Calls Editor::selectionHasStyle.
41 2011-03-07 Dan Bernstein <mitz@apple.com>
43 LLVM Compiler build fix.
45 * WebCoreSupport/WebEditorClient.mm:
46 (WebEditorClient::checkGrammarOfString):
48 2011-03-07 Chris Fleizach <cfleizach@apple.com>
50 Reviewed by Beth Dakin.
52 AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
53 https://bugs.webkit.org/show_bug.cgi?id=55706
55 Make sure WebDynamicScrollBarsView appear in the AX tree in WK1 (since this object
56 returns the scroll bar objects).
57 Make the accessibilityRoot object be the web area in WK1 because WebDynamicScrollBarsView
58 will expect that as its child, instead of the WebCore ScrollView object.
60 * WebView/WebDynamicScrollBarsView.mm:
61 (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
62 * WebView/WebFrame.mm:
63 (-[WebFrame accessibilityRoot]):
65 2011-03-07 Sam Weinig <sam@webkit.org>
67 Reviewed by Anders Carlsson.
69 Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
70 https://bugs.webkit.org/show_bug.cgi?id=55827
72 Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
73 and pass the entire response, instead of just the MIMEType.
75 * WebCoreSupport/WebFrameLoaderClient.h:
76 * WebCoreSupport/WebFrameLoaderClient.mm:
77 (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
79 2011-03-06 Dan Bernstein <mitz@apple.com>
81 LLVM Compiler build fix.
83 * DOM/WebDOMOperations.mm:
84 (-[DOMHTMLInputElement _setValueForUser:]):
86 2011-03-06 Jessie Berlin <jberlin@apple.com>
88 Reviewed by Sam Weinig.
90 WebKit2: Use CFNetwork Sessions API.
91 https://bugs.webkit.org/show_bug.cgi?id=55435.
93 When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
94 Private Browsing Storage Session.
96 * WebCoreSupport/WebSystemInterface.mm:
97 (InitWebCoreSystemInterface):
98 Add support for using the new WKSI functions in WebCore.
100 2011-03-05 Ilya Sherman <isherman@chromium.org>
102 Reviewed by Darin Adler.
104 HTMLInputElement::setValue() should schedule change event when the element is focused
105 In service of https://code.google.com/p/chromium/issues/detail?id=42716
106 https://bugs.webkit.org/show_bug.cgi?id=53160
108 * DOM/WebDOMOperations.mm:
109 (-[DOMHTMLInputElement _setValueForUser:]): Expose HTMLInputElement::setValueForUser() to tests
110 * DOM/WebDOMOperationsPrivate.h:
111 * WebView/WebViewInternal.h:
113 2011-03-04 Jia Pu <jpu@apple.com>
115 Reviewed by Darin Adler.
117 On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
118 https://bugs.webkit.org/show_bug.cgi?id=55717
119 <rdar://problem/9018127>
121 With the change in WebCore, the bounding box passed into EditorClient::showCorrectionPanel()
122 is already in window coordinate. We don't need to do further conversion anymore.
124 * WebCoreSupport/WebEditorClient.mm:
125 (WebEditorClient::showCorrectionPanel):
127 2011-03-04 Jessie Berlin <jberlin@apple.com>
129 Reviewed by Maciej Stachowiak.
131 WebKit2: Use CFNetwork Sessions API.
132 https://bugs.webkit.org/show_bug.cgi?id=55435.
134 When Private Browsing is enabled, get the cached url response from the cache associated with
135 the Private Browsing Storage Session.
137 * WebView/WebView.mm:
138 (-[WebView _cachedResponseForURL:]):
140 2011-03-03 Anders Carlsson <andersca@apple.com>
142 Reviewed by Sam Weinig.
144 Get rid of Page::globalHistoryItem
145 https://bugs.webkit.org/show_bug.cgi?id=55738
147 * WebCoreSupport/WebFrameLoaderClient.h:
148 * WebCoreSupport/WebFrameLoaderClient.mm:
149 (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
150 Get the current history item and update it using -[WebView _setGlobalHistoryItem:].
152 * WebView/WebView.mm:
153 (-[WebView _globalHistoryItem]):
154 (-[WebView _setGlobalHistoryItem:]):
155 Set _globalHistoryItem ivar.
157 * WebView/WebViewData.h:
158 * WebView/WebViewData.mm:
159 Add _globalHistoryItem ivar.
161 2011-03-03 Brady Eidson <beidson@apple.com>
163 Reviewed by Darin Adler.
165 https://bugs.webkit.org/show_bug.cgi?id=55721
166 Global IconDatabase should be returned by reference, not as a pointer
168 * Misc/WebCoreStatistics.mm:
169 (+[WebCoreStatistics iconPageURLMappingCount]):
170 (+[WebCoreStatistics iconRetainedPageURLCount]):
171 (+[WebCoreStatistics iconRecordCount]):
172 (+[WebCoreStatistics iconsWithDataCount]):
173 * Misc/WebIconDatabase.mm:
174 (-[WebIconDatabase init]):
175 (-[WebIconDatabase iconForURL:withSize:cache:]):
176 (-[WebIconDatabase iconURLForURL:]):
177 (-[WebIconDatabase defaultIconWithSize:]):
178 (-[WebIconDatabase retainIconForURL:]):
179 (-[WebIconDatabase releaseIconForURL:]):
180 (-[WebIconDatabase isEnabled]):
181 (-[WebIconDatabase setEnabled:]):
182 (-[WebIconDatabase removeAllIcons]):
183 (+[WebIconDatabase _checkIntegrityBeforeOpening]):
184 (-[WebIconDatabase _startUpIconDatabase]):
185 (-[WebIconDatabase _applicationWillTerminate:]):
186 (-[WebIconDatabase _resetCachedWebPreferences:]):
187 (importToWebCoreFormat):
188 * WebView/WebView.mm:
189 (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
191 2011-03-03 Jessie Berlin <jberlin@apple.com>
193 Reviewed by Adam Roben.
195 WebKit2: Use CFNetwork Sessions API.
196 https://bugs.webkit.org/show_bug.cgi?id=55435.
198 Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
200 * WebCoreSupport/WebSystemInterface.mm:
201 (InitWebCoreSystemInterface):
202 Support using WKCopyRequestWithStorageSession in WebCore.
204 2011-03-02 Alexey Proskuryakov <ap@apple.com>
206 Reviewed by Darin Adler.
208 REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
209 https://bugs.webkit.org/show_bug.cgi?id=55633
210 <rdar://problem/8963023>
212 * WebCoreSupport/WebChromeClient.h:
213 * WebCoreSupport/WebChromeClient.mm:
214 Removed tabsToLinks(). Mac WebKit already implements keyboardUIMode().
216 * WebView/WebView.mm: (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
217 Removed an incorrect comment. We actually get a value of 2 on Snow Leopard, and we don't
218 require both bits to be set. The rest of the comment might be wrong too, but I'm not sure,
219 so I've preserved it.
221 2011-03-02 Jessie Berlin <jberlin@apple.com>
223 Rubber-stamped by Dan Bernstein.
225 Fix crashes in private browsing tests in WK1 on Snow Leopard.
227 * WebCoreSupport/WebSystemInterface.mm:
228 (InitWebCoreSystemInterface):
229 Put the INIT call for wkCreatePrivateStorageSession outside of the
230 #if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
233 2011-03-02 Jessie Berlin <jberlin@apple.com>
235 Reviewed by Adam Roben.
237 WebKit2: Use CFNetwork Sessions API.
238 https://bugs.webkit.org/show_bug.cgi?id=55435.
240 Add the ability to create a Private Browsing Storage Session.
242 * WebCoreSupport/WebSystemInterface.mm:
243 (InitWebCoreSystemInterface):
244 Support calling wkCreatePrivateStorageSession from WebCore.
246 2011-03-02 Daniel Cheng <dcheng@chromium.org>
248 Reviewed by David Levin.
250 Add feature define for data transfer items
251 https://bugs.webkit.org/show_bug.cgi?id=55510
253 * Configurations/FeatureDefines.xcconfig:
255 2011-03-02 Sam Weinig <sam@webkit.org>
257 Reviewed by Anders Carlsson.
259 Fix remaining localization issues by piping all localized strings through WebCore's
260 localization bottleneck.
261 <rdar://problem/8728860>
263 * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
264 (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
265 * Misc/WebKitErrors.m:
266 * Misc/WebLocalizableStringsInternal.h: Added.
267 * Misc/WebLocalizableStringsInternal.mm: Added.
268 (WebLocalizedStringInternal):
269 * Panels/WebAuthenticationPanel.m:
270 (-[WebAuthenticationPanel setUpForChallenge:]):
271 * Plugins/Hosted/NetscapePluginHostManager.mm:
272 (WebKit::NetscapePluginHostManager::spawnPluginHost):
273 * WebCoreSupport/WebEditorClient.mm:
274 (undoNameForEditAction):
275 * WebCoreSupport/WebInspectorClient.mm:
276 (WebInspectorFrontendClient::updateWindowTitle):
277 (-[WebInspectorWindowController validateUserInterfaceItem:]):
278 * WebCoreSupport/WebKeyGenerator.m:
279 (-[WebKeyGenerator strengthMenuItemTitles]):
280 (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]):
281 * WebCoreSupport/WebPlatformStrategies.mm:
282 * WebView/WebHTMLView.mm:
283 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
284 * WebView/WebPDFView.mm:
285 (-[WebPDFView menuForEvent:]):
287 2011-03-01 Brian Weinstein <bweinstein@apple.com>
289 Reviewed by Adam Roben.
291 Part of WebKit2: Need a way to send notifications to client when cookies change
292 https://bugs.webkit.org/show_bug.cgi?id=55427
293 <rdar://problem/9056027>
295 Add stubs for CookiesStrategy on Mac WebKit1.
297 * WebCoreSupport/WebPlatformStrategies.h:
298 * WebCoreSupport/WebPlatformStrategies.mm:
299 (WebPlatformStrategies::createCookiesStrategy):
300 (WebPlatformStrategies::notifyCookiesChanged):
302 2011-03-01 Philippe Normand <pnormand@igalia.com>
304 Reviewed by Eric Carlson.
306 [GStreamer] support in mac video fullscreen controller
307 https://bugs.webkit.org/show_bug.cgi?id=52280
309 Factored the code to configure the video overlay in a new private
310 method of the controller and added GStreamer support to it.
312 * WebView/WebVideoFullscreenController.h:
313 * WebView/WebVideoFullscreenController.mm:
314 (-[WebVideoFullscreenController setupVideoOverlay:]):
315 (-[WebVideoFullscreenController windowDidLoad]):
316 (-[WebVideoFullscreenController setMediaElement:WebCore::]):
317 (-[WebVideoFullscreenController windowDidExitFullscreen]):
319 2011-02-23 Joseph Pecoraro <joepeck@webkit.org>
321 Reviewed by Timothy Hatcher.
323 All Console Messages should be passed to ChromeClients.
324 https://bugs.webkit.org/show_bug.cgi?id=54926
326 Add a new private UIDelegate method, -webView:addMessageToConsole:withSource:,
327 which supersedes -webView:addMessageToConsole if it exists. The new delegate
328 does not filter to only JavaScript originated console messages. The old
329 delegate is left around for clients that expect filtered messages, like
330 DashCode and older versions of Safari.
332 The dictionary message passed to the delegate now includes more information
333 about the message source, type, and level.
335 * WebCoreSupport/WebChromeClient.mm:
336 (stringForMessageSource):
337 (stringForMessageType):
338 (stringForMessageLevel):
339 (WebChromeClient::addMessageToConsole):
340 * WebView/WebUIDelegatePrivate.h:
342 2011-03-01 Levi Weintraub <leviw@chromium.org>
344 Reviewed by Ryosuke Niwa.
346 Stop instantiating legacy editing Positions in VisiblePosition
347 https://bugs.webkit.org/show_bug.cgi?id=52919
349 Changing usage of legacy VisiblePosition constructor. Since we were dealing
350 with positions from DOM Ranges, we're guaranteed a parent-anchored position.
352 * WebView/WebFrame.mm:
353 (-[WebFrame _caretRectAtPosition:affinity:]):
354 * WebView/WebFrameInternal.h:
355 * WebView/WebTextCompletionController.mm:
356 (-[WebTextCompletionController doCompletion]):
358 2011-03-01 Sam Weinig <sam@webkit.org>
360 Reviewed by Timothy Hatcher.
362 WebKit2 needs to be made localizable
363 https://bugs.webkit.org/show_bug.cgi?id=55483
365 * WebCoreSupport/WebPlatformStrategies.mm:
366 Use WebCore's localizedString function instead of WebLocalizableStrings
367 since WebCore is now responsible for localization.
369 2011-02-25 Steve Block <steveblock@google.com>
371 Reviewed by Jeremy Orlow.
373 Bridge.h should not include BridgeJSC.h
374 https://bugs.webkit.org/show_bug.cgi?id=55212
376 Include BridgeJSC.h directly instead.
378 * Plugins/Hosted/ProxyInstance.h:
379 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
381 2011-02-28 Chang Shu <cshu@webkit.org>
383 Reviewed by Ryosuke Niwa.
385 Remove the support of Frame::isContentEditable and its dependencies.
386 https://bugs.webkit.org/show_bug.cgi?id=54292
388 Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
390 * WebCoreSupport/WebEditorClient.h:
391 * WebCoreSupport/WebEditorClient.mm:
392 * WebView/WebView.mm:
393 (-[WebView setEditable:]):
394 (-[WebView isEditable]):
395 * WebView/WebViewData.h:
397 2011-02-28 Oliver Hunt <oliver@apple.com>
399 Reviewed by Gavin Barraclough.
401 Make ScopeChainNode GC allocated
402 https://bugs.webkit.org/show_bug.cgi?id=55283
404 More updates for the absence of the ScopeChain class
406 * WebView/WebScriptDebugDelegate.mm:
407 (-[WebScriptCallFrame scopeChain]):
409 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
411 Reviewed by Pavel Feldman.
413 DumpRenderTree should reset frame opener between tests.
414 https://bugs.webkit.org/show_bug.cgi?id=54874
416 Added clearOpener method to WebFramePrivate.
418 * WebView/WebFrame.mm:
419 (-[WebFrame _clearOpener]):
420 * WebView/WebFramePrivate.h:
422 2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
424 Unreviewed, rolling out r79764.
425 http://trac.webkit.org/changeset/79764
426 https://bugs.webkit.org/show_bug.cgi?id=55295
428 "broke Chromium builds" (Requested by rniwa on #webkit).
430 * WebView/WebFrame.mm:
431 * WebView/WebFramePrivate.h:
433 2011-02-26 Yongjun Zhang <yongjun_zhang@apple.com>
435 Reviewed by David Kilzer.
437 https://bugs.webkit.org/show_bug.cgi?id=48781
439 Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
441 Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore
442 should paint the default broken image when an image fails to load or decode. The method also passes the
443 URL of the failed image.
445 * WebCoreSupport/WebFrameLoaderClient.h:
446 * WebCoreSupport/WebFrameLoaderClient.mm:
447 (WebFrameLoaderClient::shouldPaintBrokenImage):
448 * WebView/WebDelegateImplementationCaching.h:
449 * WebView/WebDelegateImplementationCaching.mm: Added case for passing one object.
450 (CallResourceLoadDelegateReturningBoolean):
451 * WebView/WebResourceLoadDelegatePrivate.h:
452 * WebView/WebView.mm:
453 (-[WebView _cacheResourceLoadDelegateImplementations]):
455 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
457 Reviewed by Pavel Feldman.
459 DumpRenderTree should reset frame opener between tests.
460 https://bugs.webkit.org/show_bug.cgi?id=54874
462 Added clearOpener method to WebFramePrivate.
464 * WebView/WebFrame.mm:
465 (-[WebFrame _clearOpener]):
466 * WebView/WebFramePrivate.h:
468 2011-02-25 Mark Rowe <mrowe@apple.com>
470 <rdar://problem/8902546> Build fix.
472 * Misc/QuickDrawCompatibility.h:
474 2011-02-24 Anders Carlsson <andersca@apple.com>
478 * WebCoreSupport/WebKeyGenerator.m:
479 (toWebCertificateParseResult):
480 (-[WebKeyGenerator addCertificatesToKeychainFromData:]):
481 * WebView/WebTextCompletionController.mm:
483 2011-02-24 Peter Kasting <pkasting@google.com>
485 Reviewed by Eric Seidel.
487 Drop the "U; " encryption level from the User Agent string.
488 https://bugs.webkit.org/show_bug.cgi?id=54566
490 * WebView/WebView.mm:
491 (+[WebView _standardUserAgentWithApplicationName:]):
493 2011-02-24 Andrew Wilson <atwilson@chromium.org>
495 Unreviewed, rolling out r79570.
496 http://trac.webkit.org/changeset/79570
497 https://bugs.webkit.org/show_bug.cgi?id=54874
499 Breaks chromium build because glue/mocks/mock_web_frame.h/cc
502 * WebView/WebFrame.mm:
503 * WebView/WebFramePrivate.h:
505 2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
507 Reviewed by Alexey Proskuryakov.
509 DumpRenderTree should reset frame opener between tests.
510 https://bugs.webkit.org/show_bug.cgi?id=54874
512 Added clearOpener method to WebFramePrivate.
514 * WebView/WebFrame.mm:
515 (-[WebFrame _clearOpener]):
516 * WebView/WebFramePrivate.h:
518 2011-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
520 Reviewed by Alexey Proskuryakov.
522 Drop the language tag part from the User Agent string
523 https://bugs.webkit.org/show_bug.cgi?id=54560
525 * WebView/WebView.mm:
526 (+[WebView _standardUserAgentWithApplicationName:]): Drop the
529 2011-02-22 Brady Eidson <beidson@apple.com>
531 Reviewed by Anders Carlsson.
533 Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
534 API to view and delete Application Cache data by origin.
536 * WebCoreSupport/WebApplicationCache.mm:
537 (+[WebApplicationCache deleteAllApplicationCaches]): Move this implementation into WebCore itself.
539 2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
541 Reviewed by Kent Tamura.
543 Rename Position::node() to Position::deprecatedNode()
544 https://bugs.webkit.org/show_bug.cgi?id=54622
546 * WebView/WebFrame.mm:
547 (-[WebFrame _smartDeleteRangeForProposedRange:]):
549 2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
551 Reviewed by Kent Tamura.
553 Rename Position::node() to Position::deprecatedNode()
554 https://bugs.webkit.org/show_bug.cgi?id=54622
558 * WebView/WebFrame.mm:
559 (-[WebFrame _smartDeleteRangeForProposedRange:]): Since newStart and newEnd are parent-anchored,
560 use containerNode() and offsetInContainerNode() instead of deprecated member functions.
562 2011-02-18 Gavin Barraclough <barraclough@apple.com>
564 Reviewed by Sam Weinig.
566 Bug 54786 - Devirtualize JSCell::classInfo()
568 Instead of making a virtual function call, add a pointer to the ClassInfo
571 This removes a virtual function call, and paves the way towards removing all
572 the createStructure methods, and StructureFlags/AnonymousSlotCount properties
573 (these should be able to move onto ClassInfo).
575 Calls to Structure::create must now pass a pointer to the ClassInfo for the
576 structure. All objects now have a ClassInfo pointer, non-object cell types
579 Changes are most mechanical, involving three steps:
580 * Remove virtual classInfo() methods.
581 * Add &s_info parameter to calls to Structure::create.
582 * Rename ClassInfo static members on classes from 'info' to 's_info',
585 * Plugins/Hosted/ProxyInstance.mm:
586 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
587 (WebKit::ProxyRuntimeMethod::createStructure):
588 * Plugins/Hosted/ProxyRuntimeObject.h:
589 (WebKit::ProxyRuntimeObject::createStructure):
590 * Plugins/Hosted/ProxyRuntimeObject.mm:
591 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
592 * WebView/WebView.mm:
595 2011-02-19 Brian Ryner <bryner@chromium.org>
597 Reviewed by Adam Barth.
599 Add missing #include of DocumentLoader.h, needed since the transitive
600 include through Document.h is removed.
601 https://bugs.webkit.org/show_bug.cgi?id=50489
603 * WebView/WebFrame.mm:
605 2011-02-19 Charlie Reis <creis@chromium.org>
607 Reviewed by Mihai Parparita.
609 Ensure loading has stopped in HistoryController::goToItem
610 https://bugs.webkit.org/show_bug.cgi?id=54517
612 Add a FrameLoaderClient callback for whether to stop loading before goToItem.
614 Test: http/tests/navigation/forward-to-fragment-fires-onload.html
616 * WebCoreSupport/WebFrameLoaderClient.mm:
617 (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
618 * WebCoreSupport/WebFrameLoaderClient.h:
620 2011-02-16 David Hyatt <hyatt@apple.com>
622 Reviewed by Dan Bernstein.
624 https://bugs.webkit.org/show_bug.cgi?id=54244
626 Convert the line box tree to floating point and eliminate font rounding hacks. This patch removes all of the rounding
627 hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
629 The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
630 been changed as well.
632 In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
634 Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
636 Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
637 still have a precise floating point position.
639 Justification will now allow subpixel positioning to occur as well. Platforms that don't support subpixel positioning should already
640 be rounding justification spacing in their font code.
642 Many layout test results change on Mac, since rounding hacks were used there and are now gone.
644 * Misc/WebKitNSStringExtras.mm:
645 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
646 (-[NSString _web_widthWithFont:]):
648 2011-02-10 Luiz Agostini <luiz.agostini@openbossa.org>
650 Reviewed by Adam Roben.
652 HTML5 <details> and <summary>: localized text
653 https://bugs.webkit.org/show_bug.cgi?id=54260
655 The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
656 provide the default label to be used by a <details> tag that has no <summary> child.
658 * WebCoreSupport/WebPlatformStrategies.h:
659 * WebCoreSupport/WebPlatformStrategies.mm:
660 (WebPlatformStrategies::defaultDetailsSummaryText):
662 2011-02-16 Matthew Delaney <mdelaney@apple.com>
664 Reviewed by Simon Fraser.
666 Allow acceleratesDrawing for WebKit2
667 https://bugs.webkit.org/show_bug.cgi?id=54511
669 Plumb through preference for accelerated drawing.
671 * WebView/WebPreferenceKeysPrivate.h:
672 * WebView/WebPreferences.mm:
673 (+[WebPreferences initialize]):
674 (-[WebPreferences acceleratedDrawingEnabled]):
675 (-[WebPreferences setAcceleratedDrawingEnabled:]):
676 * WebView/WebPreferencesPrivate.h:
678 2011-02-15 David Kilzer <ddkilzer@apple.com>
680 <http://webkit.org/b/54505> Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h
682 Reviewed by Darin Adler.
684 * WebView/WebDynamicScrollBarsView.h:
685 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Removed
687 * WebView/WebDynamicScrollBarsView.mm:
688 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Moved
689 implementation into correct category.
690 * WebView/WebDynamicScrollBarsViewInternal.h:
691 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Added
693 * WebView/WebHTMLView.mm: Included
694 WebDynamicScrollBarsViewInternal.h instead of
695 WebDynamicScrollBarsView.h.
697 2011-02-14 Oliver Hunt <oliver@apple.com>
699 Reviewed by Gavin Barraclough and Geoff Garen.
701 Refactor handles and weak pointers to become nicer and more automatic
702 https://bugs.webkit.org/show_bug.cgi?id=54415
704 Update to use Global<> instead of ProtectedPtr, and refactored slightly
705 to get global data to places it's needed for when we're assigning to
708 * ForwardingHeaders/collector/handles/Global.h: Added.
709 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
710 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
711 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get):
712 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
713 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
714 (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
715 (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
716 (WebKit::NetscapePluginInstanceProxy::evaluate):
717 (WebKit::NetscapePluginInstanceProxy::invoke):
718 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
719 (WebKit::NetscapePluginInstanceProxy::construct):
720 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
721 * WebView/WebScriptDebugger.h:
722 * WebView/WebScriptDebugger.mm:
723 (WebScriptDebugger::WebScriptDebugger):
725 2011-02-15 Jia Pu <jpu@apple.com>
727 Reviewed by Darin Adler.
729 Autocorrection should respect undo.
730 https://bugs.webkit.org/show_bug.cgi?id=52221
731 <rdar://problem/8663399>
733 Please see WebCore/ChangeLog for detailed description.
735 * WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
737 * WebCoreSupport/WebEditorClient.mm:
738 (WebEditorClient::recordAutocorrectionResponse): Ditto.
740 * WebView/WebFrame.mm:
741 (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
742 Adopted new signature of ReplaceSelectionCommand::create().
744 2011-02-15 David Kilzer <ddkilzer@apple.com>
746 <http://webkit.org/b/54485> Fix spelling of -inProgramaticScroll
748 Reviewed by Darin Adler.
750 * WebView/WebDynamicScrollBarsView.h:
751 * WebView/WebDynamicScrollBarsView.mm:
752 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from
753 -inProgramaticScroll.
754 * WebView/WebHTMLView.mm:
755 (-[WebHTMLView _frameOrBoundsChanged]): Corrected method name.
757 2011-02-15 Kenneth Russell <kbr@google.com>
759 Reviewed by Darin Fisher.
761 Allow controlling minimum DOMTimer interval on a per-page basis
762 https://bugs.webkit.org/show_bug.cgi?id=54312
764 Added needed methods to implement LayoutTestController's new
765 setMinimumTimerInterval method.
767 * WebView/WebView.mm:
768 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
769 (+[WebView _defaultMinimumTimerInterval]):
770 (-[WebView _setMinimumTimerInterval:]):
771 * WebView/WebViewPrivate.h:
773 2011-02-11 Geoffrey Garen <ggaren@apple.com>
775 Reviewed by Oliver Hunt.
777 A little more encapsulation for the heap: Removed CollectorHeapIterator
778 https://bugs.webkit.org/show_bug.cgi?id=54298
780 * Misc/WebCoreStatistics.mm:
781 (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
782 (+[WebCoreStatistics javaScriptObjectTypeCounts]): Updated for new typedef.
784 2011-02-10 Nate Chapin <japhet@chromium.org>
786 Reviewed by Adam Barth.
788 Update calls to DocumentWriter.
789 https://bugs.webkit.org/show_bug.cgi?id=50489
791 * WebView/WebFrame.mm:
792 (-[WebFrame _canProvideDocumentSource]):
794 2011-02-10 Chris Fleizach <cfleizach@apple.com>
796 Reviewed by Anders Carlsson.
798 AX: AX needs to stop using WebCoreViewFactory
799 https://bugs.webkit.org/show_bug.cgi?id=54153
801 * WebCoreSupport/WebSystemInterface.mm:
802 (InitWebCoreSystemInterface):
804 2011-02-10 Peter Varga <pvarga@webkit.org>
806 Reviewed by Csaba Osztrogonác.
808 Remove PCRE source from trunk
809 https://bugs.webkit.org/show_bug.cgi?id=54188
811 * ForwardingHeaders/pcre/pcre.h: Removed.
813 2011-02-09 Pavel Feldman <pfeldman@chromium.org>
815 Reviewed by Yury Semikhatsky.
817 Web Inspector: follow up on InspectorAgent split -
818 removing unnecessary methods from InspectorController.
819 https://bugs.webkit.org/show_bug.cgi?id=54093
821 * WebInspector/WebInspector.mm:
822 (-[WebInspector showConsole:]):
823 (-[WebInspector stopProfilingJavaScript:]):
825 2011-02-08 Dan Bernstein <mitz@apple.com>
827 Reviewed by Jon Honeycutt and Maciej Stachowiak.
829 <rdar://problem/8959420> Find in Mail no longer cycles around
831 * WebView/WebHTMLView.mm:
832 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Set
833 the wrap option according to the flag.
835 2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
837 Unreviewed, rolling out r77980.
838 http://trac.webkit.org/changeset/77980
839 https://bugs.webkit.org/show_bug.cgi?id=54043
841 "Crashes on Windows and Linux..." (Requested by leviw on
844 * WebView/WebFrame.mm:
845 (-[WebFrame _caretRectAtNode:offset:affinity:]):
846 * WebView/WebFrameInternal.h:
847 * WebView/WebTextCompletionController.mm:
848 (-[WebTextCompletionController doCompletion]):
850 2011-02-08 Levi Weintraub <leviw@chromium.org>
852 Reviewed by Ryosuke Niwa.
854 Stop instantiating legacy editing Positions in VisiblePosition
855 https://bugs.webkit.org/show_bug.cgi?id=52919
857 Changing usage of legacy VisiblePosition constructor. Since we were dealing
858 with positions from DOM Ranges, we're guaranteed a parent-anchored position.
860 * WebView/WebFrame.mm:
861 (-[WebFrame _caretRectAtPosition:affinity:]):
862 * WebView/WebFrameInternal.h:
863 * WebView/WebTextCompletionController.mm:
864 (-[WebTextCompletionController doCompletion]):
866 2011-02-08 Adam Barth <abarth@webkit.org>
868 Reviewed by Eric Seidel.
870 Remove orphan code from old parser
871 https://bugs.webkit.org/show_bug.cgi?id=53984
873 * WebCoreSupport/WebChromeClient.h:
875 2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
877 Reviewed by Yury Semikhatsky.
879 Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
881 https://bugs.webkit.org/show_bug.cgi?id=53169
883 Minor change enforced by major changes in WebCore/inspector/InspectorController.
885 * WebInspector/WebInspector.mm:
886 (-[WebInspector isTimelineProfilingEnabled]):
888 2011-02-07 Enrica Casucci <enrica@apple.com>
890 Reviewed Adam Roben and Darin Adler.
892 WebKit2: drag and drop support on Windows.
893 https://bugs.webkit.org/show_bug.cgi?id=52775
895 Removed createDragImageForLink from DragClient.
897 * WebCoreSupport/WebDragClient.h:
898 * WebCoreSupport/WebDragClient.mm:
899 (WebDragClient::startDrag):
901 2011-02-03 Yury Semikhatsky <yurys@chromium.org>
903 Reviewed by Pavel Feldman.
905 Web Inspector: remove settings related methods from InspectorClient
906 https://bugs.webkit.org/show_bug.cgi?id=53686
908 * WebCoreSupport/WebInspectorClient.h:
909 * WebCoreSupport/WebInspectorClient.mm:
910 (WebInspectorClient::openInspectorFrontend):
911 (WebInspectorFrontendClient::WebInspectorFrontendClient):
913 2011-02-03 James Kozianski <koz@chromium.org>
915 Reviewed by Dimitri Glazkov.
917 Add navigator.registerProtocolHandler behind a flag.
918 https://bugs.webkit.org/show_bug.cgi?id=52609
920 * Configurations/FeatureDefines.xcconfig:
922 2011-02-03 Adam Langley <agl@chromium.org>
924 Reviewed by Adam Barth.
926 Plumb mixed script URL to FrameLoaderClient
927 https://bugs.webkit.org/show_bug.cgi?id=52384
929 Regressions covered by http/tests/security/mixedContent/*
931 * WebCoreSupport/WebFrameLoaderClient.h:
932 * WebCoreSupport/WebFrameLoaderClient.mm:
933 (WebFrameLoaderClient::didRunInsecureContent):
935 2011-02-03 Beth Dakin <bdakin@apple.com>
937 Reviewed by Sam Weinig.
939 Fix for <rdar://problem/8944544> Ability to animate track
940 for WKPainter scrollers
942 * WebCoreSupport/WebSystemInterface.mm:
943 (InitWebCoreSystemInterface):
945 2011-02-02 Mark Rowe <mrowe@apple.com>
947 Reviewed by Beth Dakin.
949 <rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement::createImageBuffer().
951 * WebCoreSupport/WebSystemInterface.mm:
952 (InitWebCoreSystemInterface): Add some missing initializers.
954 2011-02-02 Steve Lacey <sjl@chromium.org>
956 Reviewed by Eric Carlson.
958 Implement basic media statistics on media elements.
959 https://bugs.webkit.org/show_bug.cgi?id=53322
961 * Configurations/FeatureDefines.xcconfig:
963 2011-02-01 Sam Weinig <sam@webkit.org>
965 Reviewed by Beth Dakin.
967 Part 2 for <rdar://problem/8492788>
968 Adopt WKScrollbarPainterController
970 Use header detection to define scrollbar painting controller #define.
972 * WebCoreSupport/WebSystemInterface.mm:
973 (InitWebCoreSystemInterface):
975 2011-02-01 David Hyatt <hyatt@apple.com>
977 Reviewed by Oliver Hunt.
979 https://bugs.webkit.org/show_bug.cgi?id=53520
981 Remove the physical terminology from IntRect and FloatRect.
983 Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
984 we need to update our terminology to be more accurate.
986 I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
987 renaming right() and bottom() to maxX() and maxY(). These terms remain accurate
988 even for flipped rectangles.
990 * WebView/WebHTMLView.mm:
991 (setNeedsDisplayInRect):
993 2011-02-01 Beth Dakin <bdakin@apple.com>
995 Reviewed by Sam Weinig.
997 Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController
999 * WebCoreSupport/WebSystemInterface.mm:
1000 (InitWebCoreSystemInterface):
1002 2011-02-01 Dave Hyatt <hyatt@apple.com>
1004 Reviewed by Darin Adler.
1006 https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work
1009 Change printing functions to check writing-mode and properly swap width and height
1012 * WebView/WebDynamicScrollBarsView.mm:
1013 (-[WebDynamicScrollBarsView setScrollOrigin:updatePositionAtAll:immediately:]):
1014 * WebView/WebFrame.mm:
1015 (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
1016 * WebView/WebFrameInternal.h:
1017 * WebView/WebHTMLView.mm:
1018 (-[WebHTMLView _web_setPrintingModeRecursive]):
1019 (-[WebHTMLView _web_clearPrintingModeRecursive]):
1020 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
1021 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]):
1022 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
1023 (-[WebHTMLView _endPrintMode]):
1024 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
1025 (-[WebHTMLView _endScreenPaginationMode]):
1026 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
1027 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumPageLogicalWidth:adjustViewSize:paginateScreenContent:]):
1028 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
1029 (-[WebHTMLView _scaleFactorForPrintOperation:]):
1030 (-[WebHTMLView setPageWidthForPrinting:]):
1031 (-[WebHTMLView knowsPageRange:]):
1033 2011-01-31 Oliver Hunt <oliver@apple.com>
1035 Convert markstack to a slot visitor API
1036 https://bugs.webkit.org/show_bug.cgi?id=53219
1038 rolling r77098, r77099, r77100, r77109, and
1039 r77111 back in, along with a few more Qt fix attempts.
1041 * WebView/WebScriptDebugDelegate.mm:
1042 (-[WebScriptCallFrame scopeChain]):
1044 2011-01-30 Csaba Osztrogonác <ossy@webkit.org>
1046 Unreviewed, rolling out r77098, r77099, r77100, r77109, and
1048 http://trac.webkit.org/changeset/77098
1049 http://trac.webkit.org/changeset/77099
1050 http://trac.webkit.org/changeset/77100
1051 http://trac.webkit.org/changeset/77109
1052 http://trac.webkit.org/changeset/77111
1053 https://bugs.webkit.org/show_bug.cgi?id=53219
1057 * WebView/WebScriptDebugDelegate.mm:
1058 (-[WebScriptCallFrame scopeChain]):
1060 2011-01-30 Oliver Hunt <oliver@apple.com>
1062 Convert markstack to a slot visitor API
1063 https://bugs.webkit.org/show_bug.cgi?id=53219
1065 rolling r77006 and r77020 back in.
1067 * WebView/WebScriptDebugDelegate.mm:
1068 (-[WebScriptCallFrame scopeChain]):
1070 2011-01-28 Geoffrey Garen <ggaren@apple.com>
1072 Reviewed by Maciej Stachowiak.
1074 Some more Heap cleanup.
1075 https://bugs.webkit.org/show_bug.cgi?id=53357
1077 Updated for JavaScriptCore changes.
1079 * Misc/WebCoreStatistics.mm:
1080 (+[WebCoreStatistics memoryStatistics]):
1082 2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com>
1084 Unreviewed, rolling out r77006 and r77020.
1085 http://trac.webkit.org/changeset/77006
1086 http://trac.webkit.org/changeset/77020
1087 https://bugs.webkit.org/show_bug.cgi?id=53360
1089 "Broke Windows tests" (Requested by rniwa on #webkit).
1091 * WebView/WebScriptDebugDelegate.mm:
1092 (-[WebScriptCallFrame scopeChain]):
1094 2011-01-27 Oliver Hunt <oliver@apple.com>
1096 Reviewed by Geoffrey Garen.
1098 Convert markstack to a slot visitor API
1099 https://bugs.webkit.org/show_bug.cgi?id=53219
1101 Update to new marking api
1103 * WebView/WebScriptDebugDelegate.mm:
1104 (-[WebScriptCallFrame scopeChain]):
1106 2011-01-28 Dan Bernstein <mitz@apple.com>
1108 Reviewed by Sam Weinig.
1110 <select> can't display right-to-left (rtl) languages
1111 https://bugs.webkit.org/show_bug.cgi?id=19785
1113 * WebCoreSupport/WebChromeClient.h:
1114 * WebCoreSupport/WebChromeClient.mm:
1115 (WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
1116 (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. Returns true.
1118 2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
1120 Unreviewed, rolling out r76891.
1121 http://trac.webkit.org/changeset/76891
1122 https://bugs.webkit.org/show_bug.cgi?id=53280
1124 Makes every layout test crash (Requested by othermaciej on
1127 * Misc/WebIconDatabase.mm:
1128 (-[ThreadEnabler threadEnablingSelector:]):
1129 (importToWebCoreFormat):
1131 2011-01-27 Nate Chapin <japhet@chromium.org>
1133 Reviewed by Adam Barth.
1135 Use Document::url() instead of FrameLoader::url().
1136 https://bugs.webkit.org/show_bug.cgi?id=41165
1138 * WebView/WebView.mm:
1139 (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
1141 2011-01-27 Dan Bernstein <mitz@apple.com>
1143 Rubber-stamped by Anders Carlsson.
1145 Reverted an accidental change in r76561.
1147 * WebView/WebHTMLView.mm:
1149 2011-01-26 David Kilzer <ddkilzer@apple.com>
1151 <http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork
1152 <rdar://problem/8821760>
1154 Reviewed by Antti Koivisto.
1156 * WebCoreSupport/WebSystemInterface.mm:
1157 (InitWebCoreSystemInterface): Added initialization for
1158 GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.
1160 2011-01-26 Beth Dakin <bdakin@apple.com>
1162 Reviewed by Darin Adler.
1164 Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics
1165 when using WKScrollbars.
1167 * WebCoreSupport/WebSystemInterface.mm:
1168 (InitWebCoreSystemInterface):
1170 2011-01-25 Darin Adler <darin@apple.com>
1172 Reviewed by Anders Carlsson.
1174 WebKit is using CSBackupSetItemExcluded incorrectly
1175 https://bugs.webkit.org/show_bug.cgi?id=53095
1176 rdar://problem/8790540
1178 * Misc/WebIconDatabase.mm:
1179 (importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded.
1180 It was incorrect, and this responsibility has been moved to WebCore.
1182 2011-01-24 Chris Marrin <cmarrin@apple.com>
1184 Reviewed by Eric Seidel.
1186 Change ENABLE_3D_CANVAS to ENABLE_WEBGL
1187 https://bugs.webkit.org/show_bug.cgi?id=53041
1189 * Configurations/FeatureDefines.xcconfig:
1191 2011-01-25 Yury Semikhatsky <yurys@chromium.org>
1193 Reviewed by Pavel Feldman.
1195 Web Inspector: remove "attached" state related methods from InspectorAgent
1196 https://bugs.webkit.org/show_bug.cgi?id=53086
1198 * WebCoreSupport/WebInspectorClient.h:
1199 * WebCoreSupport/WebInspectorClient.mm:
1200 (-[WebInspectorWindowController showWindow:]):
1201 (-[WebInspectorWindowController attach]):
1202 (-[WebInspectorWindowController detach]):
1204 2011-01-23 Dan Bernstein <mitz@apple.com>
1206 Reviewed by John Sullivan.
1208 <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter
1210 * WebCoreSupport/WebChromeClient.mm:
1211 (WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.
1213 2011-01-22 Alexey Proskuryakov <ap@apple.com>
1215 Reviewed by Darin Adler.
1217 https://bugs.webkit.org/show_bug.cgi?id=52473
1218 Auto-scaling to avoid orphans is broken, remove dysfunctional code
1220 * WebView/WebHTMLView.mm:
1221 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
1222 (-[WebHTMLView _scaleFactorForPrintOperation:]):
1223 (-[WebHTMLView knowsPageRange:]):
1225 2011-01-21 Mark Rowe <mrowe@apple.com>
1227 Rubber-stamped by Jon Honeycutt.
1229 Fix the build when using Clang by removing some unused variables.
1231 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1232 (-[WebHostedNetscapePluginView updateAndSetWindow]):
1233 * WebView/WebFullScreenController.mm:
1234 (-[WebFullScreenController enterFullscreen:]):
1235 (-[WebFullScreenController exitFullscreen]):
1237 2011-01-21 Chris Rogers <crogers@google.com>
1239 Reviewed by Darin Fisher.
1241 Add run-time enable support for the web audio API
1242 https://bugs.webkit.org/show_bug.cgi?id=52741
1244 * WebView/WebPreferenceKeysPrivate.h:
1245 * WebView/WebPreferences.mm:
1246 (-[WebPreferences webAudioEnabled]):
1247 (-[WebPreferences setWebAudioEnabled:]):
1248 * WebView/WebPreferencesPrivate.h:
1249 * WebView/WebView.mm:
1250 (-[WebView _preferencesChangedNotification:]):
1252 2011-01-20 John Sullivan <sullivan@apple.com>
1254 Reviewed by Mark Rowe.
1256 Shift-tab doesn't cycle through fields in http authentication panel
1257 https://bugs.webkit.org/show_bug.cgi?id=52850
1259 * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
1260 * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
1261 Re-wired the key loop so that there aren't two views with the same nextKeyView.
1263 2011-01-20 Beth Dakin <bdakin@apple.com>
1265 Reviewed by Geoffrey Garen.
1267 Fix for <rdar://problem/8890255>
1269 Allow WebKitSystemInterface to draw scrollbars
1271 * WebCoreSupport/WebSystemInterface.mm:
1272 (InitWebCoreSystemInterface):
1274 2011-01-19 Simon Fraser <simon.fraser@apple.com>
1276 Reviewed by Sam Weinig.
1278 GraphicsLayers in subframes can get sync'd multiple times
1279 https://bugs.webkit.org/show_bug.cgi?id=52489
1281 * WebView/WebView.mm:
1282 (-[WebView _syncCompositingChanges]): syncCompositingStateRecursive()
1283 was renamed to syncCompositingStateIncludingSubframes().
1285 2011-01-19 Darin Adler <darin@apple.com>
1287 Reviewed by Sam Weinig.
1289 Would like script debugging protocol method to differentiate between caught and uncaught exceptions
1290 https://bugs.webkit.org/show_bug.cgi?id=52104
1291 rdar://problem/8704226
1293 * WebView/WebDelegateImplementationCaching.h:
1294 Fix type of second integer in CallScriptDebugDelegate function overload
1295 to be int to match the actual Objective-C method. Added a new overload
1296 that includes a BOOL in the right place. Added a boolean named
1297 exceptionWasRaisedExpectsHasHandlerFlag.
1299 * WebView/WebDelegateImplementationCaching.mm:
1300 (CallDelegate): Added overloads as above.
1301 (CallScriptDebugDelegate): Ditto.
1303 * WebView/WebScriptDebugDelegate.h: Added new method with the additional
1304 boolean argument. Marked the old method informally deprecated.
1306 * WebView/WebScriptDebugger.mm:
1307 (WebScriptDebugger::exception): Added code to call with or without the
1308 boolean depending on exceptionWasRaisedExpectsHasHandlerFlag.
1310 * WebView/WebView.mm:
1311 (-[WebView _cacheScriptDebugDelegateImplementations]): Set up the
1312 exceptionWasRaisedExpectsHasHandlerFlag. Also fixed old code that was not
1313 guaranteed to set didParseSourceExpectsBaseLineNumber to NO.
1315 2011-01-19 Tony Gentilcore <tonyg@chromium.org>
1317 Reviewed by Mihai Parparita.
1319 Perform some forward declaration
1320 https://bugs.webkit.org/show_bug.cgi?id=52522
1322 * Misc/WebKitNSStringExtras.mm:
1324 2011-01-19 Pavel Podivilov <podivilov@chromium.org>
1326 Reviewed by Yury Semikhatsky.
1328 Web Inspector: [JSC] scripts have incorrect starting line (always 1).
1329 https://bugs.webkit.org/show_bug.cgi?id=52721
1331 * WebView/WebScriptDebugger.h:
1332 * WebView/WebScriptDebugger.mm:
1334 (WebScriptDebugger::sourceParsed):
1336 2011-01-19 Levi Weintraub <leviw@google.com>
1338 Reviewed by Ryosuke Niwa.
1340 Updating to use Position::parentAnchoredEquivalent instead of
1341 the old htmlediting rangeCompliantEquivalent.
1343 remove rangeCompliantEquivalent and replace it with Position methods
1344 https://bugs.webkit.org/show_bug.cgi?id=25057
1346 * WebView/WebFrame.mm:
1347 (-[WebFrame _smartDeleteRangeForProposedRange:]):
1349 2011-01-18 Chris Fleizach <cfleizach@apple.com>
1351 Reviewed by Darin Adler.
1353 REGRESSION: A problem with Voiceover and finding links
1354 https://bugs.webkit.org/show_bug.cgi?id=52324
1356 * WebView/WebDynamicScrollBarsView.mm:
1357 (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
1359 2011-01-17 David Kilzer <ddkilzer@apple.com>
1361 <http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project
1363 Reviewed by Dan Bernstein.
1365 * MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and
1366 DOMDocumentPrivate.h to the PrivateHeaders directory.
1368 2011-01-17 Enrica Casucci <enrica@apple.com>
1370 Reviewed by Alexey Proskuryakov.
1372 Drag and drop support: refactoring of image from link and image from selection
1373 https://bugs.webkit.org/show_bug.cgi?id=52496
1375 This work cleans up the Mac code and makes it more similar to the Windows implementation,
1376 avoiding the use of an NSView when the FrameView can be used.
1377 The refactoring is a necessary step towards the complete support of drag and drop
1380 * WebCoreSupport/WebDragClient.mm:
1381 (WebDragClient::createDragImageForLink): Added.
1382 * WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL.
1383 * WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL.
1385 2011-01-17 Pavel Feldman <pfeldman@chromium.org>
1387 Reviewed by Yury Semikhatsky.
1389 Web Inspector: simplify debugger enabling routine.
1390 https://bugs.webkit.org/show_bug.cgi?id=52472
1392 * WebInspector/WebInspector.mm:
1393 (-[WebInspector startDebuggingJavaScript:]):
1395 2011-01-16 Dan Bernstein <mitz@apple.com>
1397 Reviewed by Simon Fraser.
1399 Assertion failure (!inSetWindow) with in-process plug-in in plugins/destroy-on-setwindow.html
1400 https://bugs.webkit.org/show_bug.cgi?id=52550
1402 * Plugins/WebNetscapePluginView.mm:
1403 (-[WebNetscapePluginView setWindowIfNecessary]): Removed the assertion, making sure
1404 that inSetWindow remains YES until we exit the top-level setWindowIfNecessary.
1406 2011-01-16 Simon Fraser <simon.fraser@apple.com>
1408 Reviewed by Dan Bernstein.
1410 Issues with iframes and plugins when the WebView is scaled.
1411 <rdar://problem/6213380>
1413 When _scaleWebView has been called on a WebView, iframes
1414 in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
1415 This is caused by AppKit NSViews not playing nicely with the scale
1416 applied through style.
1418 Work around most of these issues by adjusting the bounds size
1419 of widgets to allow iframe contents to paint with the correct scale,
1420 and fix various places in the code where we relied on coordinate
1421 transforms via NSViews (which ignore CSS transforms).
1423 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1424 (-[WebHostedNetscapePluginView updateAndSetWindow]):
1425 * WebView/WebFrameView.mm:
1426 (-[WebFrameView setBoundsSize:]):
1428 2011-01-16 Beth Dakin <bdakin@apple.com>
1430 Reviewed by Kevin Decker.
1432 Fix for <rdar://problem/8871204>
1434 Don't try to save elasticity state. Just rely on
1435 NSScrollElasticityAutomatic to restore the correct state.
1436 * WebCoreSupport/WebFrameLoaderClient.h:
1437 * WebCoreSupport/WebFrameLoaderClient.mm:
1438 (WebFrameLoaderClient::WebFrameLoaderClient):
1439 (WebFrameLoaderClient::dispatchDidFirstLayout):
1440 (WebFrameLoaderClient::provisionalLoadStarted):
1442 2011-01-14 Simon Fraser <simon.fraser@apple.com>
1444 Reviewed by Dan Bernstein.
1446 Plugins render incorrectly with transformed ancestors
1447 https://bugs.webkit.org/show_bug.cgi?id=52507
1449 -[NSView visibleRect] gives the wrong answer if there are CSS transforms
1450 in the ancestor chain of a plugin.
1452 So use of this method with calls to -actualVisibleRectInWindow, which
1453 maps rects through the render tree to compute the correct rect,
1454 clipping via windowClipRect() if necessary.
1456 Not testable, because doing so relies on the behavior of some
1457 plugins, which stop rendering if setWindow passes an empty rect.
1459 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1460 (-[WebHostedNetscapePluginView updateAndSetWindow]):
1461 * Plugins/WebBaseNetscapePluginView.h:
1462 * Plugins/WebBaseNetscapePluginView.mm:
1463 (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
1464 * Plugins/WebNetscapePluginView.mm:
1465 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1467 2011-01-14 Yuzo Fujishima <yuzo@google.com>
1469 Reviewed by Antti Koivisto.
1471 Rename cache() to memoryCache()
1472 https://bugs.webkit.org/show_bug.cgi?id=52433
1475 (+[WebCache statistics]):
1476 (+[WebCache setDisabled:]):
1477 (+[WebCache isDisabled]):
1478 * WebView/WebView.mm:
1479 (+[WebView _setCacheModel:]):
1481 2011-01-13 Geoffrey Garen <ggaren@apple.com>
1483 Reviewed by Oliver Hunt.
1485 Split out a MarkedSpace strategy object from Heap.
1486 https://bugs.webkit.org/show_bug.cgi?id=52421
1488 * Misc/WebCoreStatistics.mm:
1489 (+[WebCoreStatistics memoryStatistics]): Updated for class move.
1491 2011-01-14 Dan Bernstein <mitz@apple.com>
1493 Reviewed by Simon Fraser.
1495 WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
1497 * WebView/WebHTMLView.mm:
1498 (-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
1499 to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
1500 that the NSView tree doesn’t change from under AppKit as it traverses it.
1502 2011-01-14 Beth Dakin <bdakin@apple.com>
1504 Reviewed by Mark Rowe.
1506 Fix for <rdar://problem/7793902> Artifacts when scrolling
1507 page in Safari while page is loading
1509 Call setDrawsBackground:YES on the scrollView in
1510 dispatchDidFirstLayout() rather than waiting until
1511 frameLoadCompleted(). Also suspend scrolling elasticity
1512 between provisionalLoadStarted() and dispatchDidFirstLayout()
1513 * WebCoreSupport/WebFrameLoaderClient.h:
1514 * WebCoreSupport/WebFrameLoaderClient.mm:
1515 (WebFrameLoaderClient::WebFrameLoaderClient):
1516 (WebFrameLoaderClient::dispatchDidFirstLayout):
1517 (WebFrameLoaderClient::provisionalLoadStarted):
1519 2011-01-12 Enrica Casucci <enrica@apple.com>
1521 Reviewed by Darin Adler.
1523 WebKit2: Add support for drag and drop
1524 https://bugs.webkit.org/show_bug.cgi?id=52343
1525 <rdar://problem/7660558>
1527 The DragData class has been extended to provide
1528 additional context from the application (keyboard state, modal windows, etc.)
1529 as well as information of the drag pasteboard being used.
1530 These are the changes to align the behavior for WebKit.
1532 * WebView/WebView.mm:
1533 (-[WebView applicationFlags:]): Added.
1534 (-[WebView draggingEntered:]): Added parameter to the DragData constructor.
1535 (-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
1536 (-[WebView draggingExited:]): Added parameter to the DragData constructor.
1537 (-[WebView performDragOperation:]): Added parameter to the DragData constructor.
1539 2011-01-12 Beth Dakin <bdakin@apple.com>
1541 Reviewed by Anders Carlsson.
1543 Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309
1544 Expose fixed layout through WebKit SPI
1546 <rdar://problem/8844464>
1548 And now with getters!
1549 * WebView/WebView.mm:
1550 (-[WebView _useFixedLayout]):
1551 (-[WebView _fixedLayoutSize]):
1552 * WebView/WebViewPrivate.h:
1554 2011-01-12 Beth Dakin <bdakin@apple.com>
1556 Reviewed by Anders Carlsson.
1558 Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
1559 fixed layout through WebKit SPI
1561 <rdar://problem/8844464>
1563 * WebView/WebView.mm:
1564 (-[WebView _setUseFixedLayout:]):
1565 (-[WebView _setFixedLayoutSize:]):
1566 * WebView/WebViewPrivate.h:
1568 2011-01-07 Enrica Casucci <enrica@apple.com>
1570 Reviewed by Alexey Proskuryakov.
1572 Paste and drag and drop use different code paths to interact with the pasteboard.
1573 https://bugs.webkit.org/show_bug.cgi?id=52093
1574 The change consists in a refactoring of the code to have only one class that
1575 deals with the pasteboard on Mac.
1577 * WebCoreSupport/WebEditorClient.h:
1578 * WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality
1579 exposed by NSURLExtras.
1580 (WebEditorClient::canonicalizeURL):
1581 (WebEditorClient::canonicalizeURLString):
1582 * WebCoreSupport/WebPasteboardHelper.h: Removed.
1583 * WebCoreSupport/WebPasteboardHelper.mm: Removed.
1584 * WebView/WebHTMLView.mm: Removed comment.
1585 * WebView/WebView.mm: The following methods have been changed to use the new DragData
1586 constructor that doesn't use the WebPasteboardHelper reference.
1587 (-[WebView draggingEntered:]):
1588 (-[WebView draggingUpdated:]):
1589 (-[WebView draggingExited:]):
1590 (-[WebView performDragOperation:]):
1592 2011-01-09 Tony Gentilcore <tonyg@chromium.org>
1594 Reviewed by Alexey Proskuryakov.
1596 Forward declare some headers where possible
1597 https://bugs.webkit.org/show_bug.cgi?id=52133
1599 * WebView/WebFrame.mm:
1601 2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>
1603 Reviewed by Darin Fisher.
1605 https://bugs.webkit.org/show_bug.cgi?id=41441
1606 createWindow method should only do window-creating without URL navigation
1608 * WebCoreSupport/WebChromeClient.mm:
1609 (WebChromeClient::createWindow):
1611 2011-01-08 Dan Bernstein <mitz@apple.com>
1613 Try to fix the Leopard build.
1615 * WebView/WebFullScreenController.mm:
1617 2011-01-07 Jer Noble <jer.noble@apple.com>
1619 Yet another Leopard build fix: NSRect and CGRect are not inter-
1620 changable in 32-bit.
1622 * WebView/WebFullScreenController.mm:
1623 (-[WebFullScreenController exitFullscreen]):
1625 2011-01-07 Jer Noble <jer.noble@apple.com>
1627 Fix the Leopard build: Replace CoreAnimation SL-only functions
1628 with Leopard equivalents.
1630 * WebView/WebFullScreenController.mm:
1631 (+[CATransaction setDisableActions:]):
1632 (+[CATransaction setAnimationDuration:]):
1633 (-[WebFullScreenController _animationDuration]):
1634 (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
1636 2010-12-21 Jer Noble <jer.noble@apple.com>
1638 Reviewed by Simon Fraser.
1640 Implement WebKit Full Screen support.
1641 https://bugs.webkit.org/show_bug.cgi?id=49481
1642 rdar://problem/8247444
1644 Support the new fullscreen Chrome client requests. WebView will pass
1645 through these requests to a WebFullscreenController.
1647 * WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged().
1648 * WebView/WebView.mm:
1649 (-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled.
1650 (-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController.
1651 (-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen.
1652 (-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed.
1653 * WebView/WebViewData.h: Add ivar newFullscreenController.
1655 2010-12-17 Jer Noble <jer@kokode.apple.com>
1657 Reviewed by Simon Fraser.
1659 Implement WebKit Full Screen support.
1660 https://bugs.webkit.org/show_bug.cgi?id=49481
1661 rdar://problem/8247444
1663 This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new
1664 Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen
1665 window, and a custom CAAnimation animates that layer between the initial screen rect of the
1666 full screen element, to its final value. WebFullscreenController will swap the WebView out of
1667 its original window, and into the fullscreen window. The controller will replace the WebView
1668 with a placeholder view, so that if the placeholder moves or resized while the WebView is
1669 absent, the WebView will move back to the correct location when exiting fullscreen.
1671 * WebView/WebFullscreenController.h: Added.
1672 * WebView/WebFullscreenController.mm: Added.
1673 (-[WebFullscreenController windowDidExitFullscreen:]): Close the fullscreen window.
1674 (-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window.
1675 (-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate.
1676 (-[WebFullscreenController applicationDidResignActive:]):
1677 (-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match
1678 the new screen parameters.
1679 (-[WebFullscreenController enterFullscreen:]): Set up the animation that will take the fullscreen element
1680 from its original screen rect into fullscreen.
1681 (-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window.
1682 Set up the animation that will take the fullscreen element back into its original screen
1684 (-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine
1685 whether to disable screensaver and sleep.
1686 (-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element
1687 looking for HTMLVideoElements; returns whether any are found to be playing.
1688 (-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control
1690 (-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key.
1691 (-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key.
1692 (-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen.
1693 (-[WebFullscreenWindow rendererLayer]): Convenience accessor.
1694 (-[WebFullscreenWindow setRendererLayer:]): Ditto.
1695 (-[WebFullscreenWindow backgroundLayer]): Ditto.
1696 (-[WebFullscreenWindow animationView]): Ditto.
1697 (MediaEventListener::MediaEventListener): Implements the EventListener protocol.
1698 (MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions.
1700 2011-01-07 James Robinson <jamesr@chromium.org>
1702 Revert "Implement mozilla's animationTime property"
1703 https://bugs.webkit.org/show_bug.cgi?id=51952
1705 This approach isn't quite right.
1707 * WebView/WebHTMLView.mm:
1708 (-[WebHTMLView drawRect:]):
1709 * WebView/WebView.mm:
1710 (layerSyncRunLoopObserverCallBack):
1712 2011-01-06 Gavin Barraclough <barraclough@apple.com>
1714 Reviewed by Geoff Garen.
1716 Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
1718 The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
1719 destructor early, in order to release wrappers once we know we no longer intend to use them.
1720 Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
1721 lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
1722 A sequence of events that triggers the bug would look like this:
1724 (1) Create a DOMWrapperWorld.
1725 (2) Register a timer in the world.
1726 (3) Call unregisterWorld() on the world.
1727 (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
1728 (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
1729 called forgetWorld() none exists.
1730 (6) Attempt to add a wrapper to a NULL map.
1732 Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
1734 * WebView/WebScriptWorld.mm:
1735 (-[WebScriptWorld unregisterWorld]):
1737 2011-01-04 Chris Fleizach <cfleizach@apple.com>
1739 Reviewed by Sam Weinig.
1741 WK2: Support Accessibility
1742 https://bugs.webkit.org/show_bug.cgi?id=51859
1744 Use rootObject() method to get top of AX tree.
1746 * WebCoreSupport/WebFrameLoaderClient.h:
1747 (WebFrameLoaderClient::accessibilityRemoteObject):
1748 * WebView/WebFrame.mm:
1749 (-[WebFrame setAccessibleName:]):
1750 (-[WebFrame accessibilityRoot]):
1751 * WebView/WebFrameInternal.h:
1752 * WebView/WebFramePrivate.h:
1753 * WebView/WebHTMLView.mm:
1754 (-[WebHTMLView accessibilityAttributeValue:]):
1755 (-[WebHTMLView accessibilityFocusedUIElement]):
1756 (-[WebHTMLView accessibilityHitTest:]):
1757 (-[WebHTMLView _accessibilityParentForSubview:]):
1759 2011-01-04 David Kilzer <ddkilzer@apple.com>
1761 <http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name
1763 Reviewed by Eric Carlson.
1765 This originally broke in r61581. It is inside an
1766 ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
1769 * WebCoreSupport/WebFrameLoaderClient.mm: Call
1770 (WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
1771 use WebCore::PluginInfo.name instead of
1772 -[WebBasePluginPackage name].
1774 2011-01-02 Dan Bernstein <mitz@apple.com>
1776 Rubber-stamped by Simon Fraser.
1778 <rdar://problem/8812159> Update copyright strings
1782 2010-12-29 Dan Bernstein <mitz@apple.com>
1784 Reviewed by Ada Chan.
1786 <rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
1787 https://bugs.webkit.org/show_bug.cgi?id=51717
1789 Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
1790 protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.
1792 * WebView/WebDocumentInternal.h:
1793 * WebView/WebHTMLView.mm:
1794 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
1795 (-[WebHTMLView _findString:options:]):
1796 * WebView/WebView.mm:
1799 2010-12-28 Daniel Bates <dbates@rim.com>
1801 Reviewed by Sam Weinig.
1803 Substitute // MARK: for compiler-specific #pragma mark
1804 https://bugs.webkit.org/show_bug.cgi?id=51657
1806 For consistency, we should substitute "// MARK:" for compiler-
1807 specific "#pragma mark" in the source files for the Mac port.
1809 * History/WebHistory.mm:
1810 * Plugins/WebBaseNetscapePluginView.mm:
1811 * Plugins/WebNetscapePluginView.mm:
1812 * WebCoreSupport/WebInspectorClient.mm:
1813 * WebCoreSupport/WebSecurityOrigin.mm:
1814 * WebView/WebPDFView.mm:
1815 * WebView/WebVideoFullscreenController.mm:
1816 * WebView/WebVideoFullscreenHUDWindowController.mm:
1818 2010-12-23 Yongjun Zhang <yongjun_zhang@apple.com>
1820 Reviewed by Darin Adler.
1822 WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
1823 https://bugs.webkit.org/show_bug.cgi?id=38535
1825 WebScriptDebugger in WebKit has empty implementations for willExecuteProgram and didExecuteProgram. As a result,
1826 if the top call frame is from a program, WebKitScriptDebugger doesn't record that callframe as the top frame, and
1827 WebScriptDebugger's callframe stack is wrong from this point. That could cause crash if we trying to access the top
1828 call frame from this stack when an exception throws because the saved top frame could be invalid.
1830 To fix that, we need to maintain the call frame stack in willExecuteProgram and didExecuteProgram, as we did in
1831 callEvent and returnEvent.
1833 * WebView/WebScriptDebugger.mm:
1834 (WebScriptDebugger::willExecuteProgram):
1835 (WebScriptDebugger::didExecuteProgram):
1837 2010-12-22 Sam Weinig <sam@webkit.org>
1839 Reviewed by Darin Adler.
1841 WebKit2 needs to mirror the frame tree in the UIProcess
1842 https://bugs.webkit.org/show_bug.cgi?id=51546
1844 - Add client functions to notify that a frame has been added or
1845 removed from the page cache.
1847 * WebCoreSupport/WebFrameLoaderClient.h:
1848 * WebCoreSupport/WebFrameLoaderClient.mm:
1849 (WebFrameLoaderClient::didSaveToPageCache):
1850 (WebFrameLoaderClient::didRestoreFromPageCache):
1852 2010-12-22 Ryosuke Niwa <rniwa@webkit.org>
1854 Reviewed by Eric Seidel.
1856 Editor.h doesn't need to include SelectionController.h
1857 https://bugs.webkit.org/show_bug.cgi?id=51441
1859 Renamed SelectionController::EDirection to SelectionDirection.
1861 * WebView/WebFrame.mm:
1862 (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]):
1863 Takes SelectionDirection instead of SelectionController::EDirection.
1864 * WebView/WebFrameInternal.h:
1865 * WebView/WebTextCompletionController.mm:
1866 (-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController.
1868 2010-12-22 Simon Fraser <simon.fraser@apple.com>
1870 Reviewed by Darin Adler.
1872 Cache snapshots of plug-ins before painting, to avoid script running during painting
1873 https://bugs.webkit.org/show_bug.cgi?id=51493
1875 When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
1876 or when printing), plug-ins which otherwise use the CA rendering model
1877 are sent a paint event. Some plug-ins may run script while handling this event,
1878 or out of process plug-ins may process queued requests at this time. Running
1879 script while inside layout or painting can have bad consequences, because it
1880 can result in arbitrary changes to the render tree.
1882 This patch avoids sending plug-ins paint events inside of painting. Instead,
1883 we ask the plug-ins to cache a snapshot before we paint, and then the software
1884 paint simply draws that snapshot.
1886 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1887 (-[WebHostedNetscapePluginView drawRect:]): If we have a cached snapshot,
1888 draw it. Also only send the snapshot message to the plugin proxy if we
1889 know we're snapshotting, since even if creating the snapshot image failed,
1890 we still don't want to call to the plug-in.
1892 * Plugins/WebBaseNetscapePluginView.h: Add a retained NSImage member for the snapshot.
1893 * Plugins/WebBaseNetscapePluginView.mm:
1894 (-[WebBaseNetscapePluginView cacheSnapshot]): Create an image and draw the snapshot into it.
1895 (-[WebBaseNetscapePluginView clearCachedSnapshot]): Clear the snapshot.
1897 * Plugins/WebNetscapePluginView.mm:
1898 (-[WebNetscapePluginView drawRect:]): If we have a cached snapshot, use it.
1899 * WebCoreSupport/WebFrameLoaderClient.mm:
1900 (NetscapePluginWidget::notifyWidget): Implement notifyWidget() and use it
1901 to cache and clear the snapshots.
1903 2010-12-21 Cameron Zwarich <zwarich@apple.com>
1905 Reviewed by Darin Adler.
1907 -[WebBasePluginPackage isNativeLibraryData:] integer underflows on zero-sized data
1908 https://bugs.webkit.org/show_bug.cgi?id=51431
1909 <rdar://problem/8791757>
1911 * Plugins/WebBasePluginPackage.mm:
1912 (-[WebBasePluginPackage isNativeLibraryData:]): Change an arithmetic expression so
1913 it doesn't underflow.
1915 2010-12-16 Ryosuke Niwa <rniwa@webkit.org>
1917 Reviewed by Cameron Zwarich.
1919 REGRESSION(r74172): 125 java tests fail on Mac
1920 https://bugs.webkit.org/show_bug.cgi?id=51214
1922 The regression was caused by an incorrectly adding sizeof(struct fat_header)
1923 to a pointer for uint32_t as supposed to uint8_t.
1925 Fixed the bug by explicitly casting it to uint8_t* before the addition.
1927 * Plugins/WebBasePluginPackage.mm:
1928 (-[WebBasePluginPackage isNativeLibraryData:]):
1930 2010-12-15 Cameron Zwarich <zwarich@apple.com>
1932 Reviewed by Darin Adler.
1934 Clang -Wcast-align gives an error in WebBasePluginPackage.mm
1935 https://bugs.webkit.org/show_bug.cgi?id=51144
1937 Fix an alignment issue. OSSwapInt32 takes data that is 32-bit aligned on ARM, but
1938 we were calling it on a byte array 32 bits at a time. While this is okay in practice,
1939 since TCMalloc won't give us a non-32-bit aligned block array of bytes and Vector's
1940 inline storage is at the beginning of the Vector, it is still better to fix this
1941 and silence the warning.
1943 * Plugins/WebBasePluginPackage.mm:
1945 (-[WebBasePluginPackage isNativeLibraryData:]):
1947 2010-12-14 Mark Rowe <mrowe@apple.com>
1949 Reviewed by Sam Weinig.
1951 <http://webkit.org/b/51064> Reproducible crash inside WebCore::MediaPlayerPrivateQTKit::createQTMovie when loading <video>
1953 * History/WebHistoryItem.mm:
1954 (-[WebHistoryItem description]): Test whether the string is empty rather than incorrectly
1955 always including the target in the output.
1957 2010-12-13 Alexey Proskuryakov <ap@apple.com>
1959 Reviewed by Adam Barth.
1961 https://bugs.webkit.org/show_bug.cgi?id=50953
1962 DNS Prefetch should be an opt-in feature
1964 * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default to false.
1966 2010-12-13 Mike Thole <mthole@apple.com>
1968 Rubber-stamped by John Sullivan.
1970 https://bugs.webkit.org/show_bug.cgi?id=50956
1971 WebAuthenticationPanel.nib appears to have a cut-off sentence
1973 Replace the sentence fragment in the sheet layout with "<-- do not localize -->" style text.
1974 The contents of this text field are updated dynamically before the sheet is displayed.
1976 * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
1977 * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
1979 2010-12-13 Antti Koivisto <antti@apple.com>
1981 Reviewed by Alexey Proskuryakov.
1983 https://bugs.webkit.org/show_bug.cgi?id=50758
1984 <rdar://problem/8722094>
1985 Defer loading print stylesheets
1987 Expose SPI for DRT for making resources load serially. This is useful for testing resource load order.
1989 * WebView/WebView.mm:
1990 (+[WebView _setLoadResourcesSerially:forHost:]):
1991 * WebView/WebViewPrivate.h:
1993 2010-12-09 Matthew Delaney <mdelaney@apple.com>
1995 Reviewed by Simon Fraser.
1997 Adopt new CG API for canvas
1998 https://bugs.webkit.org/show_bug.cgi?id=50591
2000 * WebCoreSupport/WebSystemInterface.mm:
2002 2010-10-28 MORITA Hajime <morrita@google.com>
2004 Reviewed by Ojan Vafai.
2006 spellcheck does not check pasted text
2007 https://bugs.webkit.org/show_bug.cgi?id=40092
2009 Added asynchronous spell checking API to WebEditorClient using
2010 -[NSSpellChecker requestCheckingOfString].
2011 Note that WebEditorSpellCheckResponder is a small class to receive
2012 requested spell-checking result. Note that this feature is
2013 disabled at default.
2015 Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to
2016 enable the feature from LayoutTestController.
2018 * WebCoreSupport/WebEditorClient.h:
2019 * WebCoreSupport/WebEditorClient.mm:
2020 (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
2021 (-[WebEditorSpellCheckResponder perform]):
2022 (toCoreSpellingResult):
2023 (-[WebEditorSpellCheckResponder WTF::WebCore::]):
2024 (WebEditorClient::requestCheckingOfString):
2025 * WebView/WebPreferenceKeysPrivate.h:
2026 * WebView/WebPreferences.mm:
2027 (+[WebPreferences initialize]):
2028 (-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
2029 (-[WebPreferences asynchronousSpellCheckingEnabled]):
2030 * WebView/WebPreferencesPrivate.h:
2031 * WebView/WebView.mm:
2032 (-[WebView _preferencesChangedNotification:]):
2034 2010-12-09 Anders Carlsson <andersca@apple.com>
2036 Fix a bug uncovered by clang++.
2038 * WebView/WebHTMLView.mm:
2039 (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2041 2010-12-09 Anders Carlsson <andersca@apple.com>
2043 Clang++ build fixes.
2045 Silence a couple of warnings.
2047 * WebView/WebFrame.mm:
2048 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2049 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
2050 * WebView/WebTextCompletionController.mm:
2051 (-[WebTextCompletionController filterKeyDown:]):
2053 2010-12-09 David Hyatt <hyatt@apple.com>
2055 Reviewed by Dan Bernstein.
2057 https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PgUp, PgDown should respect
2058 writing-mode. This first part of the patch just patches Mac WebKit 1 views.
2060 * WebView/WebFrameView.mm:
2061 (-[WebFrameView _isVerticalDocument]):
2062 (-[WebFrameView _isFlippedDocument]):
2063 (-[WebFrameView _scrollToEndOfDocument]):
2064 (-[WebFrameView _pageInBlockProgressionDirection:]):
2065 (-[WebFrameView scrollPageUp:]):
2066 (-[WebFrameView scrollPageDown:]):
2068 2010-12-08 Andy Estes <aestes@apple.com>
2070 Reviewed by Darin Adler.
2072 Enable pre-HTML5 parser quirks for Apple Mail.app
2073 https://bugs.webkit.org/show_bug.cgi?id=50727
2075 * WebView/WebView.mm:
2076 (-[WebView _needsPreHTML5ParserQuirks]): Return true if the embedding
2077 application is Mail.app.
2079 2010-12-08 Brian Weinstein <bweinstein@apple.com>
2081 Reviewed by John Sullivan.
2083 REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab
2084 https://bugs.webkit.org/show_bug.cgi?id=50683
2086 If our context menu item already has an action, don't overwrite the action with the context menu
2089 * WebView/WebHTMLView.mm:
2090 (setMenuItemTarget):
2092 2010-12-08 Anders Carlsson <andersca@apple.com>
2094 Remove an unused variable.
2096 * WebView/WebDynamicScrollBarsView.mm:
2097 (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
2099 2010-12-07 Brian Weinstein <bweinstein@apple.com>
2101 Reviewed by John Sullivan.
2103 Layering Violation in ContextMenu - member variable of type HitTestResult
2104 https://bugs.webkit.org/show_bug.cgi?id=50586
2106 Update users of ContextMenu and ContextMenuController to match where the new functions
2109 * WebCoreSupport/WebContextMenuClient.mm:
2110 (WebContextMenuClient::getCustomMenuFromDefaultItems):
2111 (WebContextMenuClient::contextMenuItemSelected):
2112 * WebView/WebHTMLView.mm:
2113 (-[WebMenuTarget validateMenuItem:]):
2115 2010-12-07 Brian Weinstein <bweinstein@apple.com>
2117 Reviewed by John Sullivan.
2119 Part of Layering Violation in ContextMenu
2120 https://bugs.webkit.org/show_bug.cgi?id=50586
2122 Move WebMenuTarget from ContextMenuMac to here, because having it in ContextMenuMac
2123 was a layering violation. Also, make sure we set the menu item targets for all menu
2124 items before showing them, because the ContextMenu constructor doesn't do that anymore.
2126 * WebView/WebHTMLView.mm:
2127 (+[WebMenuTarget sharedMenuTarget]): Moved from ContextMenuMac.mm.
2128 (-[WebMenuTarget WebCore::]): Ditto.
2129 (-[WebMenuTarget setMenuController:WebCore::]): Ditto.
2130 (-[WebMenuTarget forwardContextMenuAction:]): Ditto.
2131 (-[WebMenuTarget validateMenuItem:]): Ditto.
2133 (setMenuItemTarget): Sets the target of the NSMenuItem to the shared WebMenuTarget.
2134 (setMenuTargets): Recursively iterates over all NSMenuItems in an NSMenu (including
2135 submenus), and calls setMenuItemTarget on them.
2136 (-[WebHTMLView menuForEvent:]): Call setMenuTarget on all the menu items before adding
2139 2010-12-06 Darin Adler <darin@apple.com>
2141 Reviewed by Sam Weinig.
2143 Pass security origin to make local file decision correctly
2144 https://bugs.webkit.org/show_bug.cgi?id=48603
2146 * WebView/WebPDFView.mm:
2147 (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Pass security origin.
2149 2010-12-07 Martin Robinson <mrobinson@igalia.com>
2151 Unreviewed, rolling out r73392.
2152 http://trac.webkit.org/changeset/73392
2153 https://bugs.webkit.org/show_bug.cgi?id=50489
2155 This commit caused crashes on the GTK+ bots
2157 * WebView/WebFrame.mm:
2158 (-[WebFrame _canProvideDocumentSource]):
2160 2010-12-07 Kenichi Ishibashi <bashi@google.com>
2162 Reviewed by Kent Tamura.
2164 Let HTMLObjectElement be a form associated element
2165 https://bugs.webkit.org/show_bug.cgi?id=48821
2167 Modified to use FormAssociatedElement instead of HTMLFormControlElement.
2169 * WebView/WebHTMLRepresentation.mm:
2170 (-[WebHTMLRepresentation elementWithName:inForm:]): Modified to use
2171 FormAssociatedElement instead of HTMLFormControlElement.
2172 (-[WebHTMLRepresentation controlsInForm:]): Ditto.
2174 2010-12-06 Nate Chapin <japhet@chromium.org>
2176 Reviewed by Adam Barth.
2178 Update calls to DocumentWriter.
2179 https://bugs.webkit.org/show_bug.cgi?id=50489
2181 * WebView/WebFrame.mm:
2182 (-[WebFrame _canProvideDocumentSource]):
2184 2010-12-06 Chris Marrin <cmarrin@apple.com>
2186 Reviewed by Simon Fraser.
2188 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
2189 https://bugs.webkit.org/show_bug.cgi?id=49388
2191 Got rid of GraphicsLayer::nativeLayer() call, replacing it with
2192 GraphicsLayer::platformLayer().
2194 * WebCoreSupport/WebChromeClient.mm:
2195 (WebChromeClient::attachRootGraphicsLayer):
2197 2010-12-04 Dan Bernstein <mitz@apple.com>
2199 Reviewed by Sam Weinig.
2201 WebKit part of <rdar://problem/8145955> Add text search API for counting/marking/highlighting matches in a range
2202 https://bugs.webkit.org/show_bug.cgi?id=50530
2204 * WebView/WebDocumentInternal.h: Added a DOMRange parameter to -countMatchesForText:options:limit:markMatches:
2205 * WebView/WebHTMLView.mm:
2206 (-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter,
2207 which is passed through to WebCore.
2208 * WebView/WebPDFView.mm:
2209 (isFrameInRange): Added this helper function.
2210 (-[WebPDFView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter and
2211 a check if the frame is in the range.
2212 * WebView/WebView.mm:
2213 (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Now calls the inDOMRange: version.
2214 (-[WebView countMatchesForText:inDOMRange:options:highlight:limit:markMatches:]): Added DOMRange
2215 parameter, which is passed to document views' -countMatchesForText:inDOMRange:options:limit:markMatches:.
2216 * WebView/WebViewPrivate.h:
2218 2010-12-03 Sam Weinig <sam@webkit.org>
2220 Reviewed by Maciej Stachowiak.
2222 Enable <a ping> for Mac/Windows/WebKit2 builds
2223 <rdar://problem/8504473>
2224 https://bugs.webkit.org/show_bug.cgi?id=50488
2226 * WebView/WebPreferences.mm:
2227 (+[WebPreferences initialize]): Enable "HyperlinkAuditing" by default.
2229 2010-12-03 Jia Pu <jpu@apple.com>
2231 Reviewed by Darin Adler.
2233 Need to move all code that applies correction into correction panel callback.
2234 https://bugs.webkit.org/show_bug.cgi?id=50426
2235 <rdar://problem/8720832>
2237 * WebCoreSupport/WebEditorClient.h: Adopted new signature of dismissCorrectionPanel.
2239 * WebCoreSupport/WebEditorClient.mm:
2240 (WebEditorClient::~WebEditorClient): Adopted new signature of dismissCorrectionPanel.
2241 (WebEditorClient::showCorrectionPanel): Added more user dictionary learning code.
2242 (WebEditorClient::dismissCorrectionPanel): Adopted new signature of dismissCorrectionPanel.
2244 2010-12-02 Simon Fraser <simon.fraser@apple.com>
2246 Revert r73217 and r73227 because of continued bustage.
2248 * WebCoreSupport/WebChromeClient.mm:
2249 (WebChromeClient::attachRootGraphicsLayer):
2251 2010-12-02 Chris Marrin <cmarrin@apple.com>
2253 Reviewed by Simon Fraser.
2255 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
2256 https://bugs.webkit.org/show_bug.cgi?id=49388
2258 Got rid of GraphicsLayer::nativeLayer() call, replacing it with
2259 GraphicsLayer::platformLayer().
2261 * WebCoreSupport/WebChromeClient.mm:
2262 (WebChromeClient::attachRootGraphicsLayer):
2264 2010-12-02 Mark Rowe <mrowe@apple.com>
2266 Reviewed by Beth Dakin.
2268 <rdar://problem/8708730> Objects reported as being leaked due to lack of autorelease pool
2270 * Misc/WebNSFileManagerExtras.m:
2271 (setMetaData): Create an autorelease pool for the duration of the thread body.
2273 2010-12-02 John Knottenbelt <jknotten@chromium.org>
2275 Reviewed by Steve Block.
2277 Move requestGeolocationPermissionForFrame to GeolocationClient
2278 https://bugs.webkit.org/show_bug.cgi?id=50061
2280 This change facilitates client-based geolocation implementation by
2281 bringing together permission control into the geolocation client
2284 Move method ChromeClient::requestGeolocationPermissionForFrame to
2285 GeolocationClient::requestPermission, and supporting class
2286 WebGeolocationPolicyListener. The moved code is unchanged except
2287 that requestPermission now takes only one argument (Geolocation*)
2288 and the Frame parameter is retrieved from the Geolocation object.
2290 * WebCoreSupport/WebChromeClient.h:
2291 * WebCoreSupport/WebChromeClient.mm:
2292 * WebCoreSupport/WebGeolocationClient.h:
2293 (WebGeolocationClient::cancelPermissionRequest):
2294 * WebCoreSupport/WebGeolocationClient.mm:
2295 (WebGeolocationClient::requestPermission):
2296 (-[WebGeolocationPolicyListener initWithGeolocation:]):
2297 (-[WebGeolocationPolicyListener allow]):
2298 (-[WebGeolocationPolicyListener deny]):
2300 2010-12-02 Joseph Pecoraro <joepeck@webkit.org>
2302 Reviewed by Eric Carlson.
2304 Style Fixes in WebPluginController
2305 https://bugs.webkit.org/show_bug.cgi?id=50397
2307 * Plugins/WebPluginController.mm:
2308 (-[WebPluginController startAllPlugins]):
2309 (-[WebPluginController stopAllPlugins]):
2311 2010-12-02 John Sullivan <sullivan@apple.com>
2313 Reviewed by Adam Roben.
2315 Slightly speculative fix for:
2317 <rdar://problem/8712674>
2318 <https://bugs.webkit.org/show_bug.cgi?id=50393>
2319 setStringValue: sometimes called with nil in [WebAuthenticationPanel setUpForChallenge]
2321 * Panels/WebAuthenticationPanel.m:
2322 (-[WebAuthenticationPanel setUpForChallenge:]):
2323 If the realm is nil, use @"" instead.
2325 2010-12-01 Jia Pu <jpu@apple.com>
2327 Reviewed by Darin Adler.
2329 Support multiple correction candidates panel for misspelled word on Mac OS X.
2330 https://bugs.webkit.org/show_bug.cgi?id=50137
2331 <rdar://problem/8568059>
2333 This patch is for supporting multiple correction suggestion panel on Mac OS X.
2334 The behavior and implementation is similar to that of reversion candiate panel.
2336 * WebCoreSupport/WebEditorClient.h: Adopted new signatures defined in base class.
2338 * WebCoreSupport/WebEditorClient.mm: Adopted new signatures defined in base class.
2339 Added code to handle new multiple suggestion canidate panel type.
2340 (WebEditorClient::showCorrectionPanel):
2341 (WebEditorClient::getGuessesForWord):
2343 2010-12-01 David Hyatt <hyatt@apple.com>
2345 Reviewed by Darin Adler.
2347 https://bugs.webkit.org/show_bug.cgi?id=46645
2349 Part 1 of making scrolling work with vertical text. This patch generalizes the scrollOriginX concept
2350 recently added for horizontal RTL documents and applies it to writing modes as well. Now the
2351 scrollOrigin is a point, since you can start off locked to the bottom or locked to the right.
2353 This patch also fixes numerous bugs with the scrollOrigin code using native Mac NSScrollViews and
2354 makes them behave the same as the cross-platform code (allowing for cross-platform results to be
2357 * WebView/WebDynamicScrollBarsView.mm:
2358 (-[WebDynamicScrollBarsView adjustForScrollOriginChange]):
2359 (-[WebDynamicScrollBarsView updateScrollers]):
2360 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
2361 (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
2362 (-[WebDynamicScrollBarsView scrollOrigin]):
2363 * WebView/WebFrameView.mm:
2364 (-[WebFrameView _scrollToBeginningOfDocument]):
2365 (-[WebFrameView _scrollToEndOfDocument]):
2367 2010-11-29 Dan Bernstein <mitz@apple.com>
2369 Reviewed by Darin Adler.
2371 WebKit Mac part of <rdar://problem/8650085> adding word-prefix search options to the text search API.
2372 https://bugs.webkit.org/show_bug.cgi?id=50038
2373 Based on a patch from Darin Adler.
2375 * WebView/WebDocumentInternal.h: Removed -markAllMatchesForText:caseSensitive:limit: and
2376 replaced -countMatchesForText:caseSensitive:limit:markMatches: with a WebFindOptions-based
2377 method. Declared a WebDocumentOptionsSearching protocol with a new -findString:options:
2378 method. Made WebHTMLView conform to the new protocol.
2379 * WebView/WebHTMLView.mm:
2380 (coreOptions): Added. Converts WebFindOptions to WebCore FindOptions.
2381 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Changed to use
2382 -findString:options:.
2383 (-[WebHTMLView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
2384 (-[WebHTMLView findString:options:]): Added. Calls through to WebCore::Editor::findString().
2385 * WebView/WebPDFView.mm:
2386 (-[WebPDFView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
2387 * WebView/WebView.mm:
2388 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): Now calls through to
2389 -countMatchesForText:options:highlight:limit:markMatches.
2390 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]): Ditto.
2391 (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]): Now calls through to
2392 -findString:options:.
2393 (incrementFrame): Changed to use WebFindOptions.
2394 (findString): Added this helper method that performs the search using the best supported
2395 method for the document view.
2396 (-[WebView findString:options:]): Changed -searchFor::::: into this.
2397 (-[WebView canMarkAllTextMatches]):
2398 (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Updated to use
2400 (-[WebView unmarkAllTextMatches]): Updated for change to incrementFrame.
2401 (-[WebView rectsForTextMatches]): Ditto.
2402 * WebView/WebViewPrivate.h: Added WebFindOptions, -findString:options:, and WebFindOptions version
2403 of countMatchesForText:.
2405 2010-11-29 Jeremy Moskovich <jeremy@chromium.org>
2407 Reviewed by David Hyatt.
2409 Right-to-left pages should be scrollable to reveal left overflow.
2410 https://bugs.webkit.org/show_bug.cgi?id=23556
2412 Set and get the original x-axis scroll position and reset scroll position on HOME/END key press.
2413 Modify WebFrameView to support setting the initial horizontal scroller's thumb position to the right for
2414 pages with a left overflow.
2416 * WebView/WebDynamicScrollBarsView.h:
2417 * WebView/WebDynamicScrollBarsView.mm:
2418 (-[WebDynamicScrollBarsView inProgramaticScroll]):
2419 (-[WebDynamicScrollBarsView refreshInitialScrollbarPosition]):
2420 (-[WebDynamicScrollBarsView updateScrollers]):
2421 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
2422 (-[WebDynamicScrollBarsView setScrollOriginX:]):
2423 (-[WebDynamicScrollBarsView scrollOriginX]):
2424 * WebView/WebFrameView.mm:
2425 (-[WebFrameView _scrollToBeginningOfDocument]):
2426 (-[WebFrameView _scrollToEndOfDocument]):
2427 * WebView/WebHTMLView.mm:
2428 (-[WebHTMLView _frameOrBoundsChanged]):
2430 2010-11-22 Ryosuke Niwa <rniwa@webkit.org>
2432 Reviewed by Tony Chang.
2434 SelectionController::typingStyle() should return EditingStyle*
2435 https://bugs.webkit.org/show_bug.cgi?id=49813
2437 Changed the return value of SelectionController::typingStyle() to EditingStyle*.
2438 Also added SelectionController::copyTypingStyle() to copy the typing style
2439 as an instance of CSSMutableStyleDeclaration.
2441 No tests are added since this is no behavioral change.
2443 * WebView/WebFrame.mm:
2444 (-[WebFrame _typingStyle]): Calls SelectionController::copyTypingStyle()
2446 2010-11-19 Michael Saboff <msaboff@apple.com>
2448 Reviewed by Sam Weinig
2450 Remove DOMSVGAnimatedPathData.h from all: target to fix build.
2452 * MigrateHeaders.make:
2454 2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>
2456 Reviewed by Dirk Schulze.
2458 Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
2459 https://bugs.webkit.org/show_bug.cgi?id=49580
2461 * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.
2463 2010-11-18 Mark Rowe <mrowe@apple.com>
2465 Rubber-stamped by Adam Roben.
2467 <rdar://problem/8602509&8602717&8602724> Enable compaction support.
2469 * Configurations/WebKit.xcconfig:
2471 2010-11-18 Sheriff Bot <webkit.review.bot@gmail.com>
2473 Unreviewed, rolling out r72288.
2474 http://trac.webkit.org/changeset/72288
2475 https://bugs.webkit.org/show_bug.cgi?id=49730
2477 'krit attempted to do that, but revert got stuck' (Requested
2478 by antonm on #webkit).
2480 * WebView/WebRenderLayer.mm:
2482 2010-11-17 Nikolas Zimmermann <nzimmermann@rim.com>
2484 Reviewed by Dirk Schulze.
2486 Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
2487 https://bugs.webkit.org/show_bug.cgi?id=49580
2489 * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.
2491 2010-11-16 Stephanie Lewis <slewis@apple.com>
2493 Reviewed by Geoff Garen.
2495 <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
2497 Make a static provider for WebDeviceOrientationProviderMock. The old code allocated a new WebDeviceOrientationProviderMock for
2498 every WebView, and the WebKit API doesn't support that ownership model.
2500 * WebView/WebDeviceOrientationProviderMock.h:
2501 * WebView/WebDeviceOrientationProviderMock.mm:
2502 (+[WebDeviceOrientationProviderMock shared]):
2504 2010-11-16 Dave Hyatt <hyatt@apple.com>
2506 Reviewed by Dan Bernstein.
2508 https://bugs.webkit.org/show_bug.cgi?id=11004
2510 font-size:0 is ignored. Remove the minimum font size of 1 in CSSStyleSelector.
2511 Change the pref value for minimum font size from 1 to 0. Make sure to never use the NSFont's size,
2512 since it doesn't honor a size of 0. Instead pass the size in to the FontPlatformData(NSFont*) version
2513 of the constructor rather than using [NSFont pointSize].
2515 https://bugs.webkit.org/show_bug.cgi?id=49582
2517 Negative leading is not handled correctly. There are two bugs here. The first is that
2518 maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
2519 set them before so that we can allow them to be < 0.
2521 The second issue is that we should understand where fonts will end up relative to
2522 our baseline (excluding line height), and only allow those boxes to impact ascent and
2523 descent if the actual font box (without factoring in line height) is above or below the
2524 root line box baseline.
2526 Added fast/css/negative-leading.html
2528 These two bug fixes have to land together to keep the Acid 3 test rendering correctly.
2530 * Misc/WebKitNSStringExtras.mm:
2531 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2532 (-[NSString _web_widthWithFont:]):
2533 * Misc/WebStringTruncator.mm:
2535 * WebView/WebPreferences.mm:
2536 (+[WebPreferences initialize]):
2538 2010-11-16 Anders Carlsson <andersca@apple.com>
2542 * WebCoreSupport/WebFrameLoaderClient.mm:
2544 2010-11-14 Kent Tamura <tkent@chromium.org>
2546 Reviewed by Andreas Kling.
2548 KeyboardEvent::keyIdentifier() should return "const String&"
2549 https://bugs.webkit.org/show_bug.cgi?id=49426
2551 * WebCoreSupport/WebEditorClient.mm:
2552 (selectorForKeyEvent):
2553 Change the type of a variable to have keyIdentifier(); String -> const String&
2555 2010-11-12 John Knottenbelt <jknotten@chromium.org>
2557 Reviewed by Steve Block.
2559 Rename GeolocationControllerClient to GeolocationClient.
2560 https://bugs.webkit.org/show_bug.cgi?id=49259
2562 * WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h.
2563 (WebGeolocationClient::webView):
2564 (WebGeolocationClient::setEnableHighAccuracy):
2565 * WebCoreSupport/WebGeolocationClient.mm: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.mm.
2566 (WebGeolocationClient::WebGeolocationClient):
2567 (WebGeolocationClient::geolocationDestroyed):
2568 (WebGeolocationClient::startUpdating):
2569 (WebGeolocationClient::stopUpdating):
2570 (WebGeolocationClient::lastPosition):
2572 * WebView/WebView.mm:
2573 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2575 2010-11-10 Beth Dakin <bdakin@apple.com>
2577 Reviewed by Simon Fraser.
2579 Fix for https://bugs.webkit.org/show_bug.cgi?id=49356
2580 -[WebView _scaleWebView:] should take and origin and scroll the
2583 <rdar://problem/8643921>
2585 * WebView/WebView.mm:
2586 (-[WebView _scaleWebView:atOrigin:]):
2587 * WebView/WebViewPrivate.h:
2589 2010-11-10 Csaba Osztrogonác <ossy@webkit.org>
2591 Reviewed by David Hyatt.
2593 HTML5 Ruby support should be mandatory feature
2594 https://bugs.webkit.org/show_bug.cgi?id=49272
2596 Remove Ruby as optional feature.
2598 * Configurations/FeatureDefines.xcconfig:
2600 2010-11-08 Ned Holbrook <nholbrook@apple.com>
2602 Reviewed by Adam Barth.
2604 Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI.
2605 https://bugs.webkit.org/show_bug.cgi?id=48886
2607 * WebCoreSupport/WebSystemInterface.mm:
2608 (InitWebCoreSystemInterface):
2610 2010-11-08 Nate Chapin <japhet@chromium.org>
2612 Unreviewed, build fix.
2614 Clumsy typo in r71562.
2616 * Plugins/Hosted/HostedNetscapePluginStream.mm:
2617 (WebKit::HostedNetscapePluginStream::start):
2619 2010-11-08 Nate Chapin <japhet@chromium.org>
2621 Reviewed by Alexey Proskuryakov.
2623 Interface changes in https://bugs.webkit.org/show_bug.cgi?id=27165
2625 * Plugins/Hosted/HostedNetscapePluginStream.mm:
2626 (WebKit::HostedNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
2627 * Plugins/WebNetscapePluginStream.mm:
2628 (WebNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
2629 * WebView/WebView.mm:
2630 (-[WebView _dispatchPendingLoadRequests]): Use resourceLoadScheduler() instead of cache()->loader().
2632 2010-11-08 Anders Carlsson <andersca@apple.com>
2634 Reviewed by Dan Bernstein.
2636 Plug-in views should not assume that plugins are RenderEmbeddedObjects
2637 https://bugs.webkit.org/show_bug.cgi?id=49196
2638 <rdar://problem/8638467>
2640 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2641 (-[WebHostedNetscapePluginView pluginHostDied]):
2643 2010-11-08 Alexey Proskuryakov <ap@apple.com>
2645 Reviewed by Darin Adler.
2647 https://bugs.webkit.org/show_bug.cgi?id=48685
2648 Notify UI process about focused frame
2650 Added an empty implementation of the new ChromeClient method.
2652 * WebCoreSupport/WebChromeClient.h:
2653 * WebCoreSupport/WebChromeClient.mm:
2654 (WebChromeClient::focusedFrameChanged):
2656 2010-11-08 Anders Carlsson <andersca@apple.com>
2660 * MigrateHeaders.make:
2662 2010-11-08 Anders Carlsson <andersca@apple.com>
2664 Reviewed by Adam Roben.
2666 Remove use of HIGetScaleFactor
2667 https://bugs.webkit.org/show_bug.cgi?id=49186
2668 <rdar://problem/8618410>
2670 Scale factors can vary on a display-by-display basis and it doesn't make sense
2671 to compute scale factor event coordinates like this.
2673 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2676 2010-11-08 Simon Fraser <simon.fraser@apple.com>
2678 Reviewed by Sam Weinig.
2680 Allow applets to participate in accelerated compositing
2681 https://bugs.webkit.org/show_bug.cgi?id=49117
2682 <rdar://problem/8625819>
2684 If Java is being loaded via the Netscape Plugin API, create a
2685 NetscapePluginWidget so that it has an implementation of platformLayer().
2687 Also clean up by using early returns.
2689 * WebCoreSupport/WebFrameLoaderClient.mm:
2691 2010-11-07 Adam Barth <abarth@webkit.org>
2693 Reviewed by Eric Seidel.
2695 Rename Cache to MemoryCache
2696 https://bugs.webkit.org/show_bug.cgi?id=49159
2699 (+[WebCache statistics]):
2700 * WebCoreSupport/WebDeviceOrientationClient.mm:
2701 (WebDeviceOrientationClient::setController):
2702 * WebView/WebView.mm:
2704 2010-11-05 Alexey Proskuryakov <ap@apple.com>
2706 Reviewed by Darin Adler.
2708 https://bugs.webkit.org/show_bug.cgi?id=49100
2709 ASSERT([self window]) fails in -[WebBaseNetscapePluginView restartTimers]
2711 * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView restartTimers]):
2712 Removed the assertion. Multiple callers provide no guarantee that the plug-in is still alive
2713 (see bug comments), and there seems to be no harm in executing this function in that case.
2715 2010-11-05 Chris Marrin <cmarrin@apple.com>
2717 Reviewed by Simon Fraser.
2719 Move resumeAnimations/suspendAnimations from Frame to AnimationController.
2720 https://bugs.webkit.org/show_bug.cgi?id=49073
2722 * WebView/WebFrame.mm:
2723 (-[WebFrame _suspendAnimations]):
2724 (-[WebFrame _resumeAnimations]):
2726 2010-11-04 Alexey Proskuryakov <ap@apple.com>
2728 Reviewed by Darin Adler.
2730 https://bugs.webkit.org/show_bug.cgi?id=49008
2731 <rdar://problem/7906226> Frequent crashes on mail.yahoo.co.jp
2733 Callers of NetscapePluginInstanceProxy::waitForReply() are not prepared to be deleted during
2734 the call, unless it returns 0. There are two reasons for NetscapePluginInstanceProxy to be
2735 deleted during wait:
2737 - plugin was stopped (e.g. due to a DOM modification performed by another reply that came in
2740 We didn't recognize the latter.
2742 * Plugins/Hosted/NetscapePluginHostProxy.mm:
2743 (WebKit::PluginDestroyDeferrer::~PluginDestroyDeferrer):
2744 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2745 (WebKit::NetscapePluginInstanceProxy::waitForReply):
2746 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2747 (WebKit::NetscapePluginInstanceProxy::didCallPluginFunction):
2749 2010-11-05 Chris Marrin <cmarrin@apple.com>
2751 Reviewed by Simon Fraser.
2753 Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state
2754 https://bugs.webkit.org/show_bug.cgi?id=46945
2756 * WebView/WebFrame.mm:
2757 (-[WebFrame _suspendAnimations]):
2758 (-[WebFrame _resumeAnimations]):
2760 2010-11-04 Jia Pu <jpu@apple.com>
2762 Reviewed by Dan Bernstein.
2764 reversion bubble in WebViews
2765 https://bugs.webkit.org/show_bug.cgi?id=47630
2766 <rdar://problem/8530960>
2768 This patch is to add reversion to correction panel. Please see WebCore/ChangeLog for detail.
2770 * WebCoreSupport/WebEditorClient.h: Adopted new signature of base class method.
2771 * WebCoreSupport/WebEditorClient.mm: Adopted new signature of base class method. And code
2772 change to use new reversion API in AppKit.
2773 (WebEditorClient::WebEditorClient):
2774 (WebEditorClient::~WebEditorClient):
2775 (WebEditorClient::respondToChangedSelection):
2776 (WebEditorClient::showCorrectionPanel):
2777 (WebEditorClient::dismissCorrectionPanel):
2778 (WebEditorClient::isShowingCorrectionPanel):
2780 2010-11-04 Mike Thole <mthole@apple.com>
2782 Reviewed by Dan Bernstein.
2784 Title for images should use localized numerals
2785 https://bugs.webkit.org/show_bug.cgi?id=49017
2787 * WebCoreSupport/WebPlatformStrategies.mm:
2788 (WebPlatformStrategies::imageTitle): Use localized numerals on Snow Leopard or newer.
2790 2010-11-02 Daniel Bates <dbates@rim.com>
2792 Reviewed by Adam Barth.
2794 For unnamed frames, window.name returns a generated name
2795 https://bugs.webkit.org/show_bug.cgi?id=6751
2799 Substitute FrameTree::uniqueName() for FrameTree::name() in the Mac port.
2801 * WebView/WebFrame.mm:
2804 2010-11-01 Brady Eidson <beidson@apple.com>
2806 Reviewed by Anders Carlsson.
2808 <rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699
2809 Context menu support for WebKit 2.
2811 * WebCoreSupport/WebChromeClient.h:
2812 (WebChromeClient::showContextMenu):
2814 2010-10-29 Daniel Bates <dbates@rim.com>
2816 No review, rolling out 70971.
2817 http://trac.webkit.org/changeset/70971
2818 https://bugs.webkit.org/show_bug.cgi?id=6751
2820 Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
2821 it caused layout test failures on all bots. In particular, the
2822 child count in a generated frame name differs after this patch. We need
2823 to look into this further.
2825 * WebView/WebFrame.mm:
2828 2010-10-28 Antonio Gomes <agomes@rim.com>
2830 Reviewed by Ojan Vafai.
2832 Needs a "LinuxEditingBehavior", perhaps with a better name
2833 https://bugs.webkit.org/show_bug.cgi?id=36627
2835 Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
2837 * WebView/WebFrame.mm:
2839 * WebView/WebPreferencesPrivate.h:
2841 2010-10-29 Daniel Bates <dbates@rim.com>
2843 Reviewed by Adam Barth.
2845 For unnamed frames, window.name returns a generated name
2846 https://bugs.webkit.org/show_bug.cgi?id=6751
2848 Modified Mac-port to use FrameTree::uniqueName().
2850 * WebView/WebFrame.mm:
2853 2010-10-29 Darin Adler <darin@apple.com>
2855 Reviewed by Sam Weinig.
2857 Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
2858 https://bugs.webkit.org/show_bug.cgi?id=48574
2860 * History/WebBackForwardList.mm:
2861 Use BackForwardListImpl.
2863 2010-10-29 Alexey Proskuryakov <ap@apple.com>
2865 Rubber-stamped by Sam Weinig.
2867 Comment for usesDocumentViews explains it backwards. This flag is true in ToT, and we do
2868 create views for subframes.
2870 * WebView/WebViewData.h: Double negation is better than a lie.
2872 2010-10-27 Jer Noble <jer.noble@apple.com>
2874 Reviewed by Darin Adler.
2876 Full screen video in Safari (still) exits full-screen if you switch to another
2877 app on a multi-display system.
2878 https://bugs.webkit.org/show_bug.cgi?id=47364
2879 <rdar://problem/8382299>
2881 The FullScreen window does not technically close when it deactivates, but the
2882 two NSWindows that make up the FullScreen feature should not hide when deactivated.
2884 * WebView/WebVideoFullscreenController.mm:
2885 (createBackgroundFullscreenWindow): Do not set hidesOnDeactivate.
2886 (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
2887 * WebView/WebVideoFullscreenHUDWindowController.mm:
2888 (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
2890 2010-10-29 Alexey Proskuryakov <ap@apple.com>
2892 Reviewed by Darin Adler.
2894 https://bugs.webkit.org/show_bug.cgi?id=48576
2895 Let WebKit2 client know when a frame is a frameset
2897 Added a blank implementation of the new FrameLoaderClient method.
2899 * WebCoreSupport/WebFrameLoaderClient.h:
2900 * WebCoreSupport/WebFrameLoaderClient.mm:
2901 (WebFrameLoaderClient::dispatchDidBecomeFrameset):
2903 2010-10-29 Csaba Osztrogonác <ossy@webkit.org>
2905 Reviewed by Adam Roben and David Kilzer.
2907 Fix and cleanup of build systems
2908 https://bugs.webkit.org/show_bug.cgi?id=48342
2910 * Configurations/FeatureDefines.xcconfig: Remove unnecessary ENABLE_SANDBOX.
2912 2010-10-28 Dan Bernstein <mitz@apple.com>
2914 Reviewed by Mark Rowe.
2916 LLVM compiler build fix
2918 * Misc/WebDownload.mm:
2919 (-[WebDownload initWithRequest:delegate:]): Changed the delegate type from id to
2920 id<NSURLDownloadDelegate> to match the method signature in NSURLDownload.
2922 2010-10-28 Ivan Krstić <ike@apple.com>
2924 Reviewed by Mark Rowe.
2926 Remove unused experimental proxied panel interface.
2927 <rdar://problem/7237059>
2929 * Plugins/Hosted/NetscapePluginHostManager.h:
2930 * Plugins/Hosted/NetscapePluginHostManager.mm:
2931 (WebKit::NetscapePluginHostManager::hostForPlugin):
2932 (WebKit::NetscapePluginHostManager::spawnPluginHost):
2933 (WebKit::NetscapePluginHostManager::instantiatePlugin):
2934 * Plugins/Hosted/NetscapePluginHostProxy.mm:
2935 * Plugins/Hosted/WebKitPluginClient.defs:
2936 * Plugins/Hosted/WebKitPluginHost.defs:
2937 * WebCoreSupport/WebSystemInterface.mm:
2938 (InitWebCoreSystemInterface):
2939 * WebView/WebPreferenceKeysPrivate.h:
2940 * WebView/WebPreferences.mm:
2941 (+[WebPreferences initialize]):
2942 * WebView/WebPreferencesPrivate.h:
2944 2010-10-27 Pratik Solanki <psolanki@apple.com>
2946 Reviewed by Darin Adler.
2948 Improve memSize calculation in [WebView _setCacheModel]
2949 https://bugs.webkit.org/show_bug.cgi?id=48484
2951 * WebView/WebView.mm:
2952 (roundUpToPowerOf2): Added. Utility function to calculate the nearest power of 2.
2953 (+[WebView _setCacheModel:]): Update memSize calculation to set it to the next
2954 bigger power of 2. Also update WebCore cache settings.
2956 2010-10-26 Darin Adler <darin@apple.com>
2958 Reviewed by Sam Weinig.
2960 WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
2961 https://bugs.webkit.org/show_bug.cgi?id=42322
2962 rdar://problem/8193631
2964 WebKitTestRunner needs to support layoutTestController.clearBackForwardList
2965 https://bugs.webkit.org/show_bug.cgi?id=42333
2966 rdar://problem/8193643
2968 * History/WebBackForwardList.mm:
2969 (core): Return BackForwardListImpl.
2970 (kit): Take BackForwardListImpl.
2971 (-[WebBackForwardList initWithBackForwardList:]): Use BackForwardListImpl.
2972 (-[WebBackForwardList dealloc]): Ditto.
2973 (-[WebBackForwardList finalize]): Ditto.
2974 (-[WebBackForwardList description]): Ditto.
2975 (-[WebBackForwardList setPageCacheSize:]): Ditto.
2976 (-[WebBackForwardList pageCacheSize]): Ditto.
2977 * History/WebBackForwardListInternal.h: Ditto.
2978 * WebView/WebFrameView.mm:
2979 (-[WebFrameView keyDown:]): Ditto.
2980 * WebView/WebView.mm:
2981 (-[WebView initWithCoder:]): Ditto.
2982 (-[WebView encodeWithCoder:]): Ditto.
2983 (-[WebView backForwardList]): Ditto.
2984 (-[WebView setMaintainsBackForwardList:]): Ditto.
2986 2010-10-27 Chris Rogers <crogers@google.com>
2988 Reviewed by Chris Marrin.
2990 Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
2991 https://bugs.webkit.org/show_bug.cgi?id=48279
2993 * Configurations/FeatureDefines.xcconfig:
2995 2010-10-27 Beth Dakin <bdakin@apple.com>
2997 Reviewed by Darin Adler.
2999 Fix for https://bugs.webkit.org/show_bug.cgi?id=48385 Add WebKit
3000 SPI to scale a WebView
3002 <rdar://problem/8107667>
3004 This patch adds SPI to Mac WebKit that scales the page by the given
3007 * WebView/WebView.mm:
3008 (-[WebView _scaleWebView:]):
3009 (-[WebView _viewScaleFactor]):
3010 * WebView/WebViewPrivate.h:
3012 2010-10-27 Dan Bernstein <mitz@apple.com>
3014 Reviewed by Darin Adler.
3016 REGRESSION (r70335): Incorrect article layout in Safari Reader
3017 https://bugs.webkit.org/show_bug.cgi?id=48436
3019 * Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITH_GET_MATCHED_CSS_RULES_RESTRICTIONS.
3020 * WebView/WebView.mm:
3021 (-[WebView _needsUnrestrictedGetMatchedCSSRules]): Added. Returns YES for Safari linked against
3022 versions of WebKit that did not have the cross-origin restrictions in getMatchedCSSRules().
3023 (-[WebView _preferencesChangedNotification:]): Call Settings::setCrossOriginCheckInGetMatchedCSSRulesDisabled()
3026 2010-10-18 Jer Noble <jer.noble@apple.com>
3028 Reviewed by Eric Carlson.
3030 Safari fullscreen media element tickles when it should not.
3032 https://bugs.webkit.org/show_bug.cgi?id=47861
3034 * WebView/WebVideoFullscreenController.mm:
3035 (-[WebVideoFullscreenController updatePowerAssertions]):
3037 2010-10-26 Jenn Braithwaite <jennb@chromium.org>
3039 Reviewed by Dmitry Titov.
3041 Resource tracking failure when trying to move a frame between documents
3042 https://bugs.webkit.org/show_bug.cgi?id=44713
3044 * WebCoreSupport/WebFrameLoaderClient.h:
3045 * WebCoreSupport/WebFrameLoaderClient.mm:
3046 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
3048 (WebFrameLoaderClient::transferLoadingResourceFromPage):
3049 Update resource tracking for a resource load that has been transferred
3052 2010-10-25 Oliver Hunt <oliver@apple.com>
3054 Reviewed by Gavin Barraclough.
3056 Remove exec and globalData arguments from jsNumber
3057 https://bugs.webkit.org/show_bug.cgi?id=48270
3059 Mechanical removal of exec parameter to jsNumber
3061 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3062 (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
3063 * Plugins/Hosted/ProxyInstance.mm:
3064 (WebKit::ProxyInstance::numberValue):
3066 2010-10-24 Dan Bernstein <mitz@apple.com>
3068 Reviewed by Anders Carlsson.
3070 Expose HitTestResult::absoluteMediaURL() via WebKit API
3071 https://bugs.webkit.org/show_bug.cgi?id=48219
3073 * Misc/WebElementDictionary.mm:
3074 (+[WebElementDictionary initializeLookupTable]): Map WebElementMediaURLKey to
3076 (-[WebElementDictionary _absoluteMediaURL]): Added. Returns absoluteMediaURL().
3077 * WebKit.exp: Export WebElementMediaURLKey.
3078 * WebView/WebView.mm: Define WebElementMediaURLKey.
3079 * WebView/WebViewPrivate.h: Declare WebElementMediaURLKey.
3081 2010-10-24 Dan Bernstein <mitz@apple.com>
3083 Reviewed by Simon Fraser.
3085 Removed deprecated methods from the WebHTMLHighlighter private protocol.
3087 * WebCoreSupport/WebChromeClient.mm:
3088 (WebChromeClient::customHighlightRect): Call -highlightRectForLine:representedNode:
3090 (WebChromeClient::paintCustomHighlight): Call
3091 -paintHighlightForBox:onLine:behindText:entireLine:representedNode: unconditionally.
3092 * WebView/WebHTMLViewPrivate.h:
3094 2010-10-23 Xan Lopez <xlopez@igalia.com>
3096 Reviewed by Sam Weinig.
3098 Unify globalData APIs
3099 https://bugs.webkit.org/show_bug.cgi?id=47969
3101 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3102 (WebKit::NetscapePluginInstanceProxy::evaluate):
3103 (WebKit::NetscapePluginInstanceProxy::invoke):
3104 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3105 (WebKit::NetscapePluginInstanceProxy::construct):
3106 * WebView/WebScriptDebugDelegate.mm:
3107 (-[WebScriptCallFrame evaluateWebScript:]):
3109 2010-10-23 David Kilzer <ddkilzer@apple.com>
3111 <http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header
3113 Reviewed by Sam Weinig.
3115 The only method defined in WebHTMLRepresentationInternal.h is
3116 also defined in WebHTMLRepresentation.h, so use that instead.
3118 * WebView/WebHTMLRepresentationInternal.h: Removed.
3120 2010-10-23 Alexey Proskuryakov <ap@apple.com>
3122 Reviewed by Anders Carlsson.
3124 https://bugs.webkit.org/show_bug.cgi?id=48083
3125 <rdar://problem/8489082> Need WebKit2 API for private browsing (48083)
3127 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize the new method.
3129 2010-10-22 Sam Weinig <sam@webkit.org>
3131 Reviewed by Anders Carlsson.
3133 WebKit2 needs to pass the current event modifier flags when requesting a new window
3134 https://bugs.webkit.org/show_bug.cgi?id=48140
3136 * WebCoreSupport/WebChromeClient.h:
3137 * WebCoreSupport/WebChromeClient.mm:
3138 (WebChromeClient::createWindow):
3139 * WebCoreSupport/WebFrameLoaderClient.h:
3140 * WebCoreSupport/WebFrameLoaderClient.mm:
3141 (WebFrameLoaderClient::dispatchCreatePage):
3142 Add NavigationAction parameter.
3144 2010-10-21 Andy Estes <aestes@apple.com>
3146 Reviewed by Eric Carlson.
3148 WebKit shouldn't load a plug-in based on file extension if a MIME type
3150 https://bugs.webkit.org/show_bug.cgi?id=48046
3152 If a MIME type is specified in an object or embed element, and that MIME
3153 type isn't supported by an installed plug-in, WebKit shouldn't attempt
3154 to find a plug-in based on the file extension of the url attribute.
3155 Doing so can lead to cases where a plug-in is loaded that can't handle
3156 resources of the MIME type specified by the author.
3158 * WebCoreSupport/WebFrameLoaderClient.mm:
3159 (WebFrameLoaderClient::createPlugin): Only check for a pluginPackage by
3160 extension if MIME type is the empty string.
3162 2010-10-20 Simon Fraser <simon.fraser@apple.com>
3164 Reviewed by Dan Bernstein.
3166 Composited elements drawn twice when WebView is layer-backed
3167 https://bugs.webkit.org/show_bug.cgi?id=48024
3168 <rdar://problem/7916580>
3170 When drawing content in a layer-backed WebView, WebFrame's test
3171 for drawing to a bitmap succeeded, causing us to paint flattened
3172 compositing layers into the view. They would also be rendered
3173 by the normal compositing path, resulting in double rendering.
3175 Fix this by detecting when the WebHTMLView is being drawn into
3176 a layer, and avoiding flattening in that case.
3178 * WebView/WebFrame.mm:
3179 (-[WebFrame _showFlattenedCompositingLayers:]):
3180 (-[WebFrame _drawRect:contentsOnly:]):
3181 * WebView/WebHTMLView.mm:
3182 (-[WebHTMLView drawLayer:inContext:]):
3183 (-[WebHTMLView _web_isDrawingIntoLayer]):
3184 * WebView/WebHTMLViewInternal.h:
3186 2010-10-20 Dumitru Daniliuc <dumi@chromium.org>
3188 Reviewed by David Levin.
3190 Repost the DatabaseTracker notifications to the main thread, if needed.
3191 https://bugs.webkit.org/show_bug.cgi?id=40655
3193 * Storage/WebDatabaseTrackerClient.mm:
3194 (DidModifyOriginData::dispatchToMainThread):
3195 (DidModifyOriginData::DidModifyOriginData):
3196 (DidModifyOriginData::dispatchDidModifyOriginOnMainThread):
3197 (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
3198 (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
3200 2010-10-20 Simon Fraser <simon.fraser@apple.com>
3202 Reviewed by Darin Adler.
3204 REGRESSION(r67568-r67643): Some HTML/CSS renders upside down and backwards on Leopard
3205 https://bugs.webkit.org/show_bug.cgi?id=47369
3207 r46947 added code that limits the size of the layer-backed view on Leopard when
3208 the page height exceeds 4096px (later adjusted to 2048px in r48401).
3210 Later, r67576 altered the geometry flipping behavior to push the geometry flipping
3211 down into WebKit. However, the code that adjusts the hosting layer's sublayer transform
3212 to account for layer-backed view size-limiting was not fixed at the same time.
3213 This change corrects that.
3215 * WebView/WebHTMLView.mm:
3216 (-[WebHTMLView _updateLayerHostingViewPosition]):
3218 2010-10-19 Simon Fraser <simon.fraser@apple.com>
3220 Reviewed by Dan Bernstein.
3222 <rdar://problem/8508422> Compositing layers aren't always displayed correctly in layer-backed WebViews
3224 AppKit has some special code to prevent it meddling with view's layers
3225 under layer-backed WebViews. When a layer-backed WebView became composited,
3226 this caused our layer to remain zero-sized. Fix this by manually
3227 setting the geometry for our layer, if the WebHTMLView has a layer.
3229 This does not seem to be a problem if the WebView becomes layer-backed, or
3230 stops being layer-backed after the WebView starts using compositing.
3232 * WebView/WebHTMLView.mm:
3233 (-[WebHTMLView attachRootLayer:]):
3235 2010-10-20 Dirk Schulze <krit@webkit.org>
3237 Reviewed by Nikolas Zimmermann.
3239 Merge ColorSpace and ImageColorSpace enums
3240 https://bugs.webkit.org/show_bug.cgi?id=47922
3242 Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
3243 to follow webkit style rules.
3245 * Misc/WebKitNSStringExtras.mm:
3246 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
3248 2010-10-19 Alexey Proskuryakov <ap@apple.com>
3250 Reviewed by Anders Carlsson.
3252 https://bugs.webkit.org/show_bug.cgi?id=47933
3253 <rdar://problem/8494337> navigator.language doesn't work in WebKit2
3255 * Misc/WebNSUserDefaultsExtras.mm: Moved code for computing default language to WebCore.
3256 We need to keep _webkit_preferredLanguageCode for Safari.
3258 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
3259 Initialize wkCopyCFLocalizationPreferredName.
3261 * WebCoreSupport/WebViewFactory.mm: Removed defaultLanguage. WebCore was the only caller.
3263 2010-10-18 Alexey Proskuryakov <ap@apple.com>
3265 Reviewed by David Kilzer.
3267 https://bugs.webkit.org/show_bug.cgi?id=47864
3268 Convert WebNSUserDefaultsExtras.m to .mm
3270 Also, fixed some issues in the process:
3271 - removed locking, which was only necessary when this code was in Foundation;
3272 - fixed notification center observer to actually work (previously, it picked up changes
3273 when application preferences changed, not when system language did);
3274 - removed unused NSString category;
3277 * Misc/WebNSUserDefaultsExtras.m: Removed.
3278 * Misc/WebNSUserDefaultsExtras.mm: Copied from WebKit/mac/Misc/WebNSUserDefaultsExtras.m.
3279 (createHTTPStyleLanguageCode):
3280 (+[NSUserDefaults _webkit_defaultsDidChange]):
3281 (addLanguageChangeObserver):
3282 (+[NSUserDefaults _webkit_preferredLanguageCode]):
3284 2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>
3286 Reviewed by Eric Seidel.
3288 Switch to using the new Carbon NPAPI event declarations, and remove
3291 https://bugs.webkit.org/show_bug.cgi?id=40784
3293 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3294 (WebNetscapePluginEventHandlerCarbon::mouseEntered):
3295 (WebNetscapePluginEventHandlerCarbon::mouseExited):
3296 (WebNetscapePluginEventHandlerCarbon::mouseMoved):
3297 (WebNetscapePluginEventHandlerCarbon::focusChanged):
3299 2010-10-18 Pavel Podivilov <podivilov@chromium.org>
3301 Reviewed by Timothy Hatcher.
3303 Web Inspector: disable private browsing for inspector
3304 https://bugs.webkit.org/show_bug.cgi?id=47827
3306 * WebCoreSupport/WebInspectorClient.mm:
3307 (-[WebInspectorWindowController init]):
3309 2010-10-14 Ilya Tikhonovsky <loislo@chromium.org>
3311 Reviewed by Pavel Feldman.
3313 Web Inspector: inspector settings/properties/states management
3314 should be extracted into separate class.
3316 We have a lot of flags/values in InspectorController.
3317 Some flags are persisting into profile.
3318 Others are part of inspector state for frontend.
3319 All these flags should keep their values after navigation.
3320 It'd be better to extract these flags/values into separate
3321 class which will care about theirs lifetime.
3323 https://bugs.webkit.org/show_bug.cgi?id=47275
3325 * WebCoreSupport/WebInspectorClient.mm:
3326 (-[WebInspectorWindowController showWindow:]):
3327 (-[WebInspectorWindowController attach]):
3328 (-[WebInspectorWindowController detach]):
3330 2010-10-13 Gavin Barraclough <barraclough@apple.com>
3332 Reviewed by Oliver Hunt.
3334 https://bugs.webkit.org/show_bug.cgi?id=43987
3335 Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder
3336 to construct their internal result string. Remove ScriptString (this is now
3339 * WebCoreSupport/WebFrameLoaderClient.mm:
3341 2010-10-12 Andy Estes <aestes@apple.com>
3343 Rubber-stamped by Darin Adler.
3345 Check in some cleanup from the previous commit.
3347 * WebView/WebView.mm:
3348 (leakMailQuirksUserScriptPath): Renamed to indicate that this function
3350 (-[WebView _injectMailQuirksScript]): Moved a static initialization from
3351 a separate class method into the only method that used it and removed
3352 the now-unnecessary class method.
3354 2010-10-12 Eric Seidel <eric@webkit.org>
3356 Reviewed by Darin Adler.
3358 REGRESSION (new parser): Leopard/Tiger Mail <head>/<body> quirk is gone
3359 https://bugs.webkit.org/show_bug.cgi?id=45693
3361 Re-implement this former WebCore parser quirk as a
3362 Mac-only userscript-based quirk. As far as I can tell
3363 from Darin's description this should satisfy Mail's needs.
3365 * Misc/MailQuirksUserScript.js: Added.
3366 * WebView/WebView.mm:
3367 (+[WebView _mailQuirksUserScript]):
3368 (-[WebView _injectMailQuirksScript]):
3369 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
3371 2010-10-12 Simon Fraser <simon.fraser@apple.com>
3373 Reviewed by Sam Weinig.
3375 Add 'didDraw' callback for framerate tracking
3376 https://bugs.webkit.org/show_bug.cgi?id=47478
3378 Add a callback at the end of -[WebHTMLView drawRect:] so
3379 a delegate can get notified when a draw happens.
3381 * WebView/WebHTMLView.mm:
3382 (-[WebHTMLView drawRect:]):
3383 * WebView/WebUIDelegatePrivate.h:
3385 2010-10-11 Anders Carlsson <andersca@apple.com>
3387 Reviewed by Darin Adler.
3389 Remove WebIconFetcher from WebKit and IconFetcher from WebCore
3390 https://bugs.webkit.org/show_bug.cgi?id=47523
3392 Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.
3394 * Misc/WebIconFetcher.h: Removed.
3395 * Misc/WebIconFetcher.mm: Removed.
3396 * Misc/WebIconFetcherInternal.h: Removed.
3397 * WebView/WebFrame.mm:
3398 * WebView/WebFramePrivate.h:
3400 2010-10-11 Jessie Berlin <jberlin@apple.com>
3402 Reviewed by Darin Adler.
3404 Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal
3405 representation of a WebKit1 WebSerializedJSValue.
3406 https://bugs.webkit.org/show_bug.cgi?id=47439
3408 * WebView/WebSerializedJSValue.mm:
3409 (-[WebSerializedJSValue internalRepresentation]):
3410 * WebView/WebSerializedJSValuePrivate.h:
3412 2010-10-07 Jessie Berlin <jberlin@apple.com>
3414 Reviewed by Sam Weinig.
3416 Add Private API for creating a WebKit1 WebSerializedJSValue from the internal
3417 representation of a WebKit2 WebSerializedScriptValue.
3418 https://bugs.webkit.org/show_bug.cgi?id=47390
3420 * WebView/WebSerializedJSValue.mm:
3421 (-[WebSerializedJSValue initWithInternalRepresentation:]):
3422 Set the WebSerializedJSValuePrivate's WebCore::SerializedScriptValue to be the passed in
3423 internal representation.
3424 * WebView/WebSerializedJSValuePrivate.h: Added.
3426 2010-10-07 Antonio Gomes <agomes@rim.com>
3428 Reviewed by Simon Fraser.
3430 [Mac] [DRT] implement setSpatialNavigationEnabled
3431 https://bugs.webkit.org/show_bug.cgi?id=47291
3433 Added the needed bits to make it possible to enabled spatial navigation
3434 for the Mac port. For now it is being only used by DRT.
3436 * WebView/WebPreferenceKeysPrivate.h:
3437 * WebView/WebPreferences.mm:
3438 (+[WebPreferences initialize]):
3439 (-[WebPreferences isSpatialNavigationEnabled]):
3440 (-[WebPreferences setSpatialNavigationEnabled:]):
3441 * WebView/WebPreferencesPrivate.h:
3442 * WebView/WebView.mm:
3443 (-[WebView _preferencesChangedNotification:]):
3445 2010-10-07 Jer Noble <jer.noble@apple.com>
3447 Fix the Leopard 64-bit build.
3449 * Configurations/WebKit.xcconfig: Add CoreServices.framework/Frameworks to the
3450 framework search path.
3451 * WebView/WebVideoFullscreenController.mm: Explicitly import <OSStatus/Power.h>.
3453 2010-10-06 Jer Noble <jer.noble@apple.com>
3455 Reviewed by Darin Adler.
3457 Screensaver starts while watching fullscreen playback.
3458 https://bugs.webkit.org/show_bug.cgi?id=47299
3459 <rdar://problem/8478956>
3461 To disable the Screen Saver, we need to periodically call UpdateSystemActivity().
3463 * WebView/WebVideoFullscreenController.h: Added _tickleTimer.
3464 * WebView/WebVideoFullscreenController.mm:
3465 (-[WebVideoFullscreenController dealloc]): Invalidate _tickleTimer.
3466 (-[WebVideoFullscreenController _enableTickleTimer]): Create _tickleTimer.
3467 (-[WebVideoFullscreenController _disableTickleTimer]): Invalidate _tickleTimer.
3468 (-[WebVideoFullscreenController _tickleTimerFired]): Call UpdateSystemActivity().
3469 (-[WebVideoFullscreenController updatePowerAssertions]): Call _enableTickleTimer
3470 or _disableTickleTimer.
3472 2010-10-05 Philippe Normand <pnormand@igalia.com>
3474 Reviewed by Martin Robinson.
3476 check for ENABLE(GLIB_SUPPORT) in WebView
3477 https://bugs.webkit.org/show_bug.cgi?id=46788
3479 Use ENABLE(GLIB_SUPPORT) in WebView to guard the glib runloop observer.
3481 * WebView/WebView.mm:
3482 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
3483 (-[WebView _close]):
3484 * WebView/WebViewData.h:
3485 * WebView/WebViewInternal.h:
3487 2010-10-01 Anders Carlsson <andersca@apple.com>
3489 Fix Snow Leopard build.
3491 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3492 (WebKit::NetscapePluginInstanceProxy::getProxy):
3494 2010-10-01 Anders Carlsson <andersca@apple.com>
3496 Reviewed by Dan Bernstein.
3498 Add proxy server query function proxyServersForURL and change the Mac plug-in code to use it
3499 https://bugs.webkit.org/show_bug.cgi?id=47022
3500 <rdar://problem/8504712>
3502 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3503 (WebKit::NetscapePluginInstanceProxy::getProxy):
3504 * Plugins/WebBaseNetscapePluginView.h:
3505 * Plugins/WebBaseNetscapePluginView.mm:
3506 * Plugins/WebNetscapePluginView.mm:
3507 (-[WebNetscapePluginView getVariable:forURL:value:length:]):
3509 2010-09-30 Darin Adler <darin@apple.com>
3511 Reviewed by Sam Weinig.
3513 Remove remaining calls to deprecatedParseURL
3514 https://bugs.webkit.org/show_bug.cgi?id=26599
3516 * DOM/WebDOMOperations.mm:
3517 (-[DOMDocument URLWithAttributeString:]):
3518 * WebCoreSupport/WebFrameLoaderClient.mm:
3519 (WebFrameLoaderClient::createPlugin):
3520 Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
3522 2010-09-30 Anders Carlsson <andersca@apple.com>
3524 Reviewed by Darin Adler.
3526 -[DOMDocument _documentRange] throws an exception if there is no document element
3527 https://bugs.webkit.org/show_bug.cgi?id=46934
3528 <rdar://problem/8169260>
3530 If there is no document element, just return an empty range. Otherwise we'll try to call
3531 Range::selectNode with a null Node which will throw a NOT_FOUND exception.
3533 * DOM/WebDOMOperations.mm:
3534 (-[DOMDocument _documentRange]):
3536 2010-09-30 Chris Marrin <cmarrin@apple.com>
3538 Reviewed by Simon Fraser.
3540 Make 2D accelerated canvas rendering build on Mac
3541 https://bugs.webkit.org/show_bug.cgi?id=46007
3543 Added ACCELERATED_2D_CANVAS to FeatureDefines
3545 * Configurations/FeatureDefines.xcconfig:
3547 2010-09-30 Dan Bernstein <mitz@apple.com>
3549 Reviewed by John Sullivan.<