Should have copy and paste items in all text menus
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
2
3         Should have copy and paste items in all text menus
4         https://bugs.webkit.org/show_bug.cgi?id=139510
5         <rdar://problem/19198388>
6
7         Reviewed by Beth Dakin.
8
9         * WebView/WebActionMenuController.mm:
10         (-[WebActionMenuController _defaultMenuItemsForText]):
11         Add a disabled paste menu item into the read-only text menu.
12
13         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
14         Add a disabled copy menu item into the editable whitespace text menu.
15
16 2014-12-10  Anders Carlsson  <andersca@apple.com>
17
18         Add WebStorageNamespaceProvider::closeLocalStorage
19         https://bugs.webkit.org/show_bug.cgi?id=139502
20
21         Reviewed by Tim Horton.
22
23         * WebView/WebView.mm:
24         (+[WebView _applicationWillTerminate]):
25         Call WebStorageNamespaceProvider::closeLocalStorage.
26
27 2014-12-09  Commit Queue  <commit-queue@webkit.org>
28
29         Unreviewed, rolling out r177037.
30         https://bugs.webkit.org/show_bug.cgi?id=139464
31
32         broke ~50 API tests (Requested by thorton on #webkit).
33
34         Reverted changeset:
35
36         "Use the new storage namespace provider in WebKit1"
37         https://bugs.webkit.org/show_bug.cgi?id=139425
38         http://trac.webkit.org/changeset/177037
39
40 2014-12-08  Anders Carlsson  <andersca@apple.com>
41
42         Use the new storage namespace provider in WebKit1
43         https://bugs.webkit.org/show_bug.cgi?id=139425
44
45         Reviewed by Tim Horton.
46
47         * WebView/WebView.mm:
48         (-[WebView _commonInitializationWithFrameName:groupName:]):
49         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
50         Set the storage namespace provider from the web page group.
51
52 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
53
54         Delete Node::boundingBox()
55         https://bugs.webkit.org/show_bug.cgi?id=139333
56
57         Reviewed by Zalan Bujtas.
58
59         * WebView/WebActionMenuController.mm:
60         (elementBoundingBoxInWindowCoordinatesFromNode): Use
61         RenderObject::absoluteBoundingBoxRect().
62
63 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
64
65         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
66         https://bugs.webkit.org/show_bug.cgi?id=138843
67         rdar://problem/18793695
68
69         Reviewed by Dan Bernstein.
70
71         * Panels/WebAuthenticationPanel.m:
72         (-[WebAuthenticationPanel cancel:]):
73         (-[WebAuthenticationPanel logIn:]):
74         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
75         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
76         that only when using an old NSWindow API.
77
78 2014-12-08  Beth Dakin  <bdakin@apple.com>
79
80         Copy and Lookup menu items should be disabled when something is not copyable
81         https://bugs.webkit.org/show_bug.cgi?id=139423
82
83         Reviewed by Tim Horton.
84
85         Disable both lookup and copy when a HitTestResult does not allow copy.
86         * WebView/WebActionMenuController.mm:
87
88         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
89         disable state otherwise.
90         * WebView/WebView.mm:
91         (-[WebView _commonInitializationWithFrameName:groupName:]):
92
93 2014-12-08  Anders Carlsson  <andersca@apple.com>
94
95         Adding user content to a group should force that group to be created
96         https://bugs.webkit.org/show_bug.cgi?id=139421
97         rdar://problem/19180108
98
99         Reviewed by Sam Weinig.
100
101         * WebCoreSupport/WebViewGroup.h:
102         Store the local storage database path in the group.
103
104         * WebCoreSupport/WebViewGroup.mm:
105         (WebViewGroup::getOrCreate):
106         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
107         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
108
109         (WebViewGroup::WebViewGroup):
110         Initialize the new member variable.
111
112         (WebViewGroup::storageNamespaceProvider):
113         Create the namespace provider lazily.
114
115         * WebView/WebView.mm:
116         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
117         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
118         Use getOrCreate instead of get.
119
120 2014-12-08  Anders Carlsson  <andersca@apple.com>
121
122         WebStorageNamespaceProvider should know about its local storage database path
123         https://bugs.webkit.org/show_bug.cgi?id=139413
124
125         Reviewed by Andreas Kling.
126
127         * WebCoreSupport/WebViewGroup.h:
128         * WebCoreSupport/WebViewGroup.mm:
129         (WebViewGroup::getOrCreate):
130         (WebViewGroup::WebViewGroup):
131         * WebView/WebView.mm:
132         (-[WebView _commonInitializationWithFrameName:groupName:]):
133         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
134         (-[WebView setGroupName:]):
135         (-[WebView groupName]): Deleted.
136
137 2014-12-08  Daniel Bates  <dabates@apple.com>
138
139         [iOS] Fix the WebKit build with the public SDK
140
141         Include header NSURLDownloadSPI.h.
142
143         * WebCoreSupport/WebFrameLoaderClient.mm:
144
145 2014-12-07  Dan Bernstein  <mitz@apple.com>
146
147         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
148         https://bugs.webkit.org/show_bug.cgi?id=139348
149
150         Reviewed by Anders Carlsson.
151
152         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
153         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
154         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
155         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
156         avoiding the ambiguity.
157
158         * WebView/WebActionMenuController.mm:
159         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
160
161 2014-12-06  Anders Carlsson  <andersca@apple.com>
162
163         Add a stubbed out version of WebStorageNamespaceProvider
164         https://bugs.webkit.org/show_bug.cgi?id=139213
165
166         Reviewed by Sam Weinig.
167
168         * WebCoreSupport/WebViewGroup.h:
169         (WebViewGroup::storageNamespaceProvider):
170         * WebCoreSupport/WebViewGroup.mm:
171         (WebViewGroup::getOrCreate):
172         (WebViewGroup::WebViewGroup):
173         Give WebViewGroup a storage namespace provider.
174
175 2014-12-06  Anders Carlsson  <andersca@apple.com>
176
177         Fix build with newer versions of clang.
178         rdar://problem/18978687
179
180         Add missing overrides and missing casts.
181
182         * Storage/WebDatabaseManagerClient.h:
183         * Storage/WebStorageTrackerClient.h:
184         * WebCoreSupport/WebChromeClient.h:
185         * WebCoreSupport/WebFrameLoaderClient.h:
186         * WebCoreSupport/WebInspectorClient.h:
187         * WebView/WebDataSource.mm:
188         (-[WebDataSource _makeRepresentation]):
189         * WebView/WebFrameView.mm:
190         (-[WebFrameView _makeDocumentViewForDataSource:]):
191
192 2014-12-05  Tim Horton  <timothy_horton@apple.com>
193
194         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
195         https://bugs.webkit.org/show_bug.cgi?id=139306
196         <rdar://problem/19157955>
197
198         Reviewed by Beth Dakin.
199
200         * WebView/WebView.mm:
201         (-[WebView _commonInitializationWithFrameName:groupName:]):
202         (-[WebView _initWithFrame:frameName:groupName:]):
203         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
204
205 2014-12-05  David Kilzer  <ddkilzer@apple.com>
206
207         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
208         <http://webkit.org/b/139286>
209
210         Reviewed by Daniel Bates.
211
212         * Configurations/FeatureDefines.xcconfig: Switch back to using
213         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
214
215 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
216
217         Fix the 32-bit build.
218
219         * WebView/WebView.mm:
220         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
221
222 2014-12-04  Tim Horton  <timothy_horton@apple.com>
223
224         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
225         https://bugs.webkit.org/show_bug.cgi?id=139252
226         <rdar://problem/19140827>
227
228         Reviewed by Anders Carlsson.
229
230         * WebView/WebView.mm:
231         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
232         Adjust to the WebCore changes.
233
234 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
235
236         Implement action menus for tel: URLs
237         https://bugs.webkit.org/show_bug.cgi?id=139240
238         <rdar://problem/19115662>
239
240         Reviewed by Anders Carlsson.
241
242         * WebView/WebActionMenuController.mm:
243         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
244         Make sure to use the newly created currentActionContext... everywhere.
245
246 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
247
248         Implement action menus for tel: URLs
249         https://bugs.webkit.org/show_bug.cgi?id=139240
250         <rdar://problem/19115662>
251
252         Reviewed by Anders Carlsson.
253
254         * WebView/WebActionMenuController.mm:
255         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
256         Make sure to use the newly created currentActionContext.
257
258 2014-12-03  Beth Dakin  <bdakin@apple.com>
259
260         <input> elements get whitespace action menu instead of editable text menu
261         https://bugs.webkit.org/show_bug.cgi?id=139241
262         -and corresponding-
263         rdar://problem/19072083
264
265         Reviewed by Sam Weinig.
266
267         We should disallow shadow content in the hit test. This is the default and it is 
268         how context menus behave. We originally wanted to text inside shadow content so 
269         that we could find the text, but the new function I added to HitTestResult will 
270         allow that.
271         * WebView/WebActionMenuController.mm:
272         (-[WebActionMenuController performHitTestAtPoint:]):
273
274         Adjust to the fact that we don’t hit test shadow content any more.
275         (-[WebActionMenuController focusAndSelectHitTestResult]):
276
277         Offer the text menus for text inside form controls.
278         (-[WebActionMenuController _defaultMenuItems]):
279
280 2014-12-03  Tim Horton  <timothy_horton@apple.com>
281
282         Implement action menus for tel: URLs
283         https://bugs.webkit.org/show_bug.cgi?id=139240
284         <rdar://problem/19115662>
285
286         Reviewed by Anders Carlsson.
287
288         * WebView/WebActionMenuController.mm:
289         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
290         Rename this function as it will work for both mailto and tel URLs.
291         Adjust it to use contextForView:.
292
293         (-[WebActionMenuController webView:willHandleMouseDown:]):
294         (-[WebActionMenuController prepareForMenu:withEvent:]):
295         (-[WebActionMenuController didCloseMenu:withEvent:]):
296         (-[WebActionMenuController _defaultMenuItems]):
297         Don't check the menu type when going to interact with _currentActionContext.
298         We'll only have a _currentActionContext if we have a data detected item,
299         and there are multiple menu types that end up using DDActionContext.
300
301         * WebView/WebUIDelegatePrivate.h:
302         Add a new type.
303
304 2014-12-03  Anders Carlsson  <andersca@apple.com>
305
306         Set a visited link store when creating a simple WebView
307         https://bugs.webkit.org/show_bug.cgi?id=139234
308         <rdar://problem/19132978>
309
310         Reviewed by Sam Weinig.
311
312         * WebView/WebView.mm:
313         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
314
315 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
316
317         Fix the build.
318
319         * WebCoreSupport/WebFrameLoaderClient.mm:
320
321 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
322
323         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
324         https://bugs.webkit.org/show_bug.cgi?id=139149
325
326         Reviewed by Anders Carlsson.
327
328         This changes API behavior. I think that it's OK, because existing behavior made no sense.
329         We used to delete caches from disk, but they were still active in memory. Now we also
330         obsolete them in memory, so documents that use a cache still work, but new ones don't
331         pick one up.
332
333         * WebCoreSupport/WebApplicationCache.mm:
334         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
335         need to delete in-momry caches too. Keep existing behavior.
336         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
337         that properly deletes caches.
338
339 2014-12-02  Tim Horton  <timothy_horton@apple.com>
340
341         Remove a SnowLeopard-era quirk for QuickLook
342         https://bugs.webkit.org/show_bug.cgi?id=139208
343         <rdar://problem/19121822>
344
345         Reviewed by Alexey Proskuryakov.
346
347         * WebCoreSupport/WebFrameLoaderClient.h:
348         * WebCoreSupport/WebFrameLoaderClient.mm:
349
350 2014-12-02  Tim Horton  <timothy_horton@apple.com>
351
352         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
353         https://bugs.webkit.org/show_bug.cgi?id=139204
354
355         Reviewed by Anders Carlsson.
356
357         * WebView/WebView.mm:
358         (-[WebView _commonInitializationWithFrameName:groupName:]):
359         (-[WebView _showDictionaryLookupPopup:]):
360         * WebView/WebViewData.h:
361         Work around this by delaying the softlinking (and setting up the notification
362         observer) until we actually need it. There's still an underlying bug, but
363         this will fix the test.
364
365 2014-12-02  Beth Dakin  <bdakin@apple.com>
366
367         Yet another build fix.
368
369         * WebView/WebActionMenuController.mm:
370         (-[WebActionMenuController _defaultMenuItemsForLink]):
371
372 2014-12-02  Beth Dakin  <bdakin@apple.com>
373
374         Build fix.
375
376         * WebView/WebActionMenuController.mm:
377         (-[WebActionMenuController _defaultMenuItemsForLink]):
378
379 2014-12-02  Beth Dakin  <bdakin@apple.com>
380
381         More build fixing.
382
383         * WebView/WebActionMenuController.mm:
384         (-[WebActionMenuController _defaultMenuItemsForLink]):
385
386 2014-12-02  Beth Dakin  <bdakin@apple.com>
387
388         Should use standardQuickLookMenuItem for apps that don't implement customizations
389         https://bugs.webkit.org/show_bug.cgi?id=139193
390         -and corresponding-
391         rdar://problem/18944696
392
393         Reviewed by Anders Carlsson.
394
395         Use [NSMenuItem standardQuickLookMenuItem].
396         * WebView/WebActionMenuController.mm:
397         (-[WebActionMenuController _defaultMenuItemsForLink]):
398
399         Delegate methods to set up the standardQuickLookMenuItem.
400         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
401         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
402         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
403
404         Remove all of the old QLPreviewBubble code.
405         (-[WebActionMenuController _createActionMenuItemForTag:]):
406         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
407
408 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
409
410         Fix the build.
411
412         * WebView/WebViewData.h:
413
414 2014-12-02  Tim Horton  <timothy_horton@apple.com>
415
416         Implement Lookup transition from selection for Legacy WebKit
417         https://bugs.webkit.org/show_bug.cgi?id=139180
418         <rdar://problem/19067172>
419
420         Reviewed by Beth Dakin.
421
422         * WebView/DictionaryPopupInfo.h: Added.
423         Split DictionaryPopupInfo out into its own file.
424
425         * WebView/WebActionMenuController.mm:
426         (-[WebActionMenuController _lookupText:]):
427         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
428
429         (performDictionaryLookupForSelection):
430         (performDictionaryLookupForRange):
431         Plumb the transition style through these helpers.
432         Create a TextIndicator from the selection range.
433
434         * WebView/WebHTMLView.mm:
435         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
436         Make use of TextIndicator (and DictionaryPopupInfo, and the new
437         _showDictionaryLookupPopup on WebView) to add a transition from blue
438         when performing Lookup from the context menu.
439
440         (-[WebHTMLView quickLookWithEvent:]):
441         Remove our TextIndicator whenever a normal three-finger-tap event
442         comes through, as it will have its own indication.
443
444         * WebView/WebView.mm:
445         (-[WebView _commonInitializationWithFrameName:groupName:]):
446         (-[WebView _dictionaryLookupPopoverWillClose:]):
447         Register for the LUNotificationPopoverWillClose notification and remove
448         our TextIndicator when it is called, just like in WebKit2.
449         Deregistration is already handled in _close.
450
451         (-[WebView _showDictionaryLookupPopup:]):
452         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
453         if the relevant API is available.
454
455         * WebView/WebViewInternal.h:
456
457 2014-12-02  Anders Carlsson  <andersca@apple.com>
458
459         Remove visited link handling from PageGroup
460         https://bugs.webkit.org/show_bug.cgi?id=139185
461
462         Reviewed by Sam Weinig.
463
464         * History/WebHistory.mm:
465         (-[WebHistoryPrivate removeItemForURLString:]):
466         (-[WebHistoryPrivate removeAllItems]):
467         (+[WebHistory setOptionalSharedHistory:]):
468         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
469         (+[WebHistory _removeAllVisitedLinks]):
470         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
471         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
472         * History/WebHistoryInternal.h:
473         * WebCoreSupport/WebChromeClient.h:
474         * WebCoreSupport/WebChromeClient.mm:
475         (WebChromeClient::populateVisitedLinks): Deleted.
476         * WebView/WebView.mm:
477         (-[WebView addVisitedLinks:]):
478         (-[WebView removeVisitedLink:]):
479
480 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
481
482         Try to fix the Mac build.
483
484         * WebView/WebView.mm:
485         (-[WebView _commonInitializationWithFrameName:groupName:]):
486         (-[WebView _close]):
487
488 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
489
490         Fix the iOS build.
491
492         * WebView/WebActionMenuController.h:
493         * WebView/WebActionMenuController.mm:
494         * WebView/WebHTMLView.mm:
495         (-[WebHTMLView scrollWheel:scrollWheel:]):
496         (-[WebHTMLView mouseDown:mouseDown:]):
497         * WebView/WebView.mm:
498         * WebView/WebViewData.h:
499         * WebView/WebViewData.mm:
500         (-[WebViewPrivate dealloc]):
501         * WebView/WebViewInternal.h:
502
503 2014-12-01  Tim Horton  <timothy_horton@apple.com>
504
505         Implement yellow highlight for WebKit1 data detectors
506         https://bugs.webkit.org/show_bug.cgi?id=138956
507         <rdar://problem/18992185>
508
509         Reviewed by Beth Dakin.
510
511         * WebView/WebActionMenuController.h:
512         * WebView/WebActionMenuController.mm:
513         (-[WebActionMenuController webView:willHandleMouseDown:]):
514         (-[WebActionMenuController webView:didHandleScrollWheel:]):
515         (-[WebActionMenuController prepareForMenu:withEvent:]):
516         (-[WebActionMenuController didCloseMenu:withEvent:]):
517         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
518         (-[WebActionMenuController _showTextIndicator]):
519         (-[WebActionMenuController _hideTextIndicator]):
520         (-[WebActionMenuController _dismissActionMenuPopovers]):
521         Copy the WebKit2 WKActionMenuController TextIndicator implementation
522         into WebActionMenuController. The only significant difference is
523         that we build the TextIndicator right at menu construction time
524         instead of in the Web process.
525
526         * WebView/WebHTMLView.mm:
527         (-[WebHTMLView scrollWheel:]):
528         Let the WebActionMenuController know that we're handling a scroll.
529
530         (-[WebHTMLView mouseDown:]):
531         Let the WebActionMenuController know that we're handling a mouseDown.
532
533         * WebView/WebView.mm:
534         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
535         (-[WebView _clearTextIndicator]):
536         (-[WebView _actionMenuController]):
537         (-[WebView _convertRectFromRootView:]): Deleted.
538         * WebView/WebViewData.h:
539         * WebView/WebViewData.mm:
540         * WebView/WebViewInternal.h:
541         Keep a TextIndicatorWindow on WebView, just like WKView does.
542         Expose the WebActionMenuController on WebView (internally).
543
544 2014-12-01  Anders Carlsson  <andersca@apple.com>
545
546         Remove old site specific quirks code that was added in 2009
547         https://bugs.webkit.org/show_bug.cgi?id=139141
548
549         Reviewed by Antti Koivisto.
550
551         * WebCoreSupport/WebFrameNetworkingContext.h:
552         * WebCoreSupport/WebFrameNetworkingContext.mm:
553         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
554
555 2014-11-30  Anders Carlsson  <andersca@apple.com>
556
557         Fix a test failure.
558
559         * History/WebHistory.mm:
560         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
561         Call through to the visited link store.
562
563         (+[WebHistory _removeAllVisitedLinks]):
564         Ditto.
565
566         * WebCoreSupport/WebVisitedLinkStore.mm:
567         (WebVisitedLinkStore::isLinkVisited):
568         Make sure to populate visited links.
569
570 2014-11-30  Anders Carlsson  <andersca@apple.com>
571
572         Switch over to the visited link store from the WebViewGroup
573         https://bugs.webkit.org/show_bug.cgi?id=139112
574
575         Reviewed by Sam Weinig.
576
577         * WebView/WebView.mm:
578         (-[WebView _commonInitializationWithFrameName:groupName:]):
579         (-[WebView setGroupName:]):
580
581 2014-11-30  Anders Carlsson  <andersca@apple.com>
582
583         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
584         https://bugs.webkit.org/show_bug.cgi?id=139111
585
586         Reviewed by Sam Weinig.
587
588         * WebCoreSupport/WebVisitedLinkStore.h:
589         * WebCoreSupport/WebVisitedLinkStore.mm:
590         (WebVisitedLinkStore::removeVisitedLink):
591         * WebView/WebView.mm:
592         (-[WebView removeVisitedLink:]):
593
594 2014-11-29  Anders Carlsson  <andersca@apple.com>
595
596         Populate visited links
597         https://bugs.webkit.org/show_bug.cgi?id=139101
598
599         Reviewed by Sam Weinig.
600
601         * History/WebHistory.mm:
602         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
603         Helper function that adds all visited link to the given store.
604
605         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
606         Call the private method.
607
608         * History/WebHistoryInternal.h:
609         * WebCoreSupport/WebVisitedLinkStore.h:
610         Add new members.
611
612         * WebCoreSupport/WebVisitedLinkStore.mm:
613         (WebVisitedLinkStore::addVisitedLink):
614         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
615
616         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
617         Implement this. First try the delegate, then try the shared history.
618
619         (WebVisitedLinkStore::addVisitedLinkHash):
620         Factor code that adds the link to the hash table into a separate function.
621
622         * WebView/WebView.mm:
623         (-[WebView addVisitedLinks:]):
624         Add the visited links to the store.
625
626 2014-11-29  Anders Carlsson  <andersca@apple.com>
627
628         More work on the legacy WebKit visited link store
629         https://bugs.webkit.org/show_bug.cgi?id=139100
630
631         Reviewed by Sam Weinig.
632
633         * History/WebHistory.mm:
634         (+[WebHistory setOptionalSharedHistory:]):
635         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
636
637         * WebCoreSupport/WebVisitedLinkStore.h:
638         * WebCoreSupport/WebVisitedLinkStore.mm:
639         (visitedLinkStores):
640         (WebVisitedLinkStore::WebVisitedLinkStore):
641         (WebVisitedLinkStore::~WebVisitedLinkStore):
642         Keep track of live visited link stores.
643
644         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
645         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
646
647         (WebVisitedLinkStore::removeAllVisitedLinks):
648         Iterate over all live link stores and remove their links.
649
650         (WebVisitedLinkStore::isLinkVisited):
651         Populate visited links and check if our hash table contains the link.
652
653         (WebVisitedLinkStore::addVisitedLink):
654         Add the link hash to the table.
655
656         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
657         Add stub.
658
659         (WebVisitedLinkStore::removeVisitedLinkHashes):
660         Clear out the hash table.
661
662 2014-11-27  Anders Carlsson  <andersca@apple.com>
663
664         Add a stubbed out WebVisitedLinkStore to WebViewGroup
665         https://bugs.webkit.org/show_bug.cgi?id=139066
666
667         Reviewed by Antti Koivisto.
668
669         * WebCoreSupport/WebViewGroup.h:
670         (WebViewGroup::visitedLinkStore):
671         * WebCoreSupport/WebViewGroup.mm:
672         (WebViewGroup::WebViewGroup):
673         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
674         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
675         (WebVisitedLinkStore::create):
676         (WebVisitedLinkStore::WebVisitedLinkStore):
677         (WebVisitedLinkStore::~WebVisitedLinkStore):
678         (WebVisitedLinkStore::isLinkVisited):
679         (WebVisitedLinkStore::addVisitedLink):
680
681 2014-11-25  Anders Carlsson  <andersca@apple.com>
682
683         Remove user content handling from PageGroup
684         https://bugs.webkit.org/show_bug.cgi?id=139051
685
686         Reviewed by Antti Koivisto.
687
688         Use the user content controller in the web view group.
689
690         * WebView/WebView.mm:
691         (-[WebView _injectOutlookQuirksScript]):
692
693 2014-11-25  Anders Carlsson  <andersca@apple.com>
694
695         Add a user content controller to WebViewGroup and use it for user content
696         https://bugs.webkit.org/show_bug.cgi?id=139043
697
698         Reviewed by Antti Koivisto.
699
700         This is another tiny step towards getting rid of user content handling inside PageGroup.
701
702         * WebCoreSupport/WebViewGroup.h:
703         (WebViewGroup::userContentController):
704         Add a UserContentController member and getter.
705
706         * WebCoreSupport/WebViewGroup.mm:
707         (WebViewGroup::get):
708         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
709
710         (WebViewGroup::WebViewGroup):
711         Create a user content controller.
712
713         * WebView/WebView.mm:
714         (-[WebView _commonInitializationWithFrameName:groupName:]):
715         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
716         set its user content controller in the PageConfiguration.
717
718         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
719         Ditto.
720
721         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
722         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
723         (+[WebView _removeUserScriptFromGroup:world:url:]):
724         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
725         (+[WebView _removeUserScriptsFromGroup:world:]):
726         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
727         (+[WebView _removeAllUserContentFromGroup:]):
728         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
729
730         (-[WebView setGroupName:]):
731         Set the user content controller to the new WebViewGroup's user content controller.
732
733 2014-11-21  Jer Noble  <jer.noble@apple.com>
734
735         Support multiple signatures of diagnostic logging.
736         https://bugs.webkit.org/show_bug.cgi?id=138690
737
738         Reviewed by Anders Carlsson.
739
740         Page::PageClients has been renamed PageConfiguration.
741
742         * WebView/WebView.mm:
743         (-[WebView _commonInitializationWithFrameName:groupName:]):
744         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
745
746 2014-11-21  Zalan Bujtas  <zalan@apple.com>
747
748         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
749         https://bugs.webkit.org/show_bug.cgi?id=138981
750
751         Reviewed by Simon Fraser.
752
753         * WebView/WebPreferenceKeysPrivate.h:
754         * WebView/WebPreferences.mm:
755         (+[WebPreferences initialize]):
756         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
757         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
758         * WebView/WebPreferencesPrivate.h:
759         * WebView/WebView.mm:
760         (-[WebView _preferencesChanged:]):
761
762 2014-11-21  Tim Horton  <timothy_horton@apple.com>
763
764         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
765         ​https://bugs.webkit.org/show_bug.cgi?id=138960
766         <rdar://problem/19056715>
767
768         Reviewed by Anders Carlsson.
769
770         * WebView/WebActionMenuController.mm:
771         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
772         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
773         Use DataDetectors SPI instead of an explicit blacklist.
774
775 2014-11-21  Tim Horton  <timothy_horton@apple.com>
776
777         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
778         https://bugs.webkit.org/show_bug.cgi?id=138960
779         <rdar://problem/19056715>
780
781         Reviewed by Beth Dakin.
782
783         * WebView/WebActionMenuController.mm:
784         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
785         Blacklist contact results, because they don't have useful menus. If we
786         bail before setting up _currentActionContext, we'll still allow fallthrough
787         to ordinary text actions, avoiding mysterious failure when a contact is detected.
788
789         This doesn't break the case that r176351 was intended to fix,
790         because in that case we were detecting e.g. addresses.
791
792 2014-11-21  Anders Carlsson  <andersca@apple.com>
793
794         Remove the Timer parameters from timer callbacks
795         https://bugs.webkit.org/show_bug.cgi?id=138974
796
797         Reviewed by Antti Koivisto.
798
799         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
800         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
801         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
802         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
803         * Plugins/WebNetscapePluginStream.h:
804         * Plugins/WebNetscapePluginStream.mm:
805         (WebNetscapePluginStream::WebNetscapePluginStream):
806         (WebNetscapePluginStream::deliverDataTimerFired):
807
808 2014-11-21  Anders Carlsson  <andersca@apple.com>
809
810         Make memoryCache() return a reference
811         https://bugs.webkit.org/show_bug.cgi?id=138939
812
813         Reviewed by Antti Koivisto.
814
815         * Misc/WebCache.mm:
816         (+[WebCache statistics]):
817         (+[WebCache emptyInMemoryResources]):
818         (+[WebCache sizeOfDeadResources:]):
819         (+[WebCache addImageToCache:forURL:forFrame:]):
820         (+[WebCache removeImageFromCacheForURL:forFrame:]):
821         (+[WebCache imageForURL:]):
822         (+[WebCache setDisabled:]):
823         (+[WebCache isDisabled]):
824         * WebView/WebView.mm:
825         (+[WebView _setCacheModel:]):
826
827 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
828
829         Remove the remaining vestiges of minimal-ui
830         https://bugs.webkit.org/show_bug.cgi?id=138890
831
832         Reviewed by Sam Weinig.
833
834         * History/WebHistoryItem.mm:
835         * History/WebHistoryItemPrivate.h:
836
837 2014-11-20  Tim Horton  <timothy_horton@apple.com>
838
839         Cancel DataDetectors menu earlier if we know it can't be presented
840         https://bugs.webkit.org/show_bug.cgi?id=138922
841         <rdar://problem/18950441>
842
843         Reviewed by Beth Dakin.
844
845         * WebView/WebActionMenuController.mm:
846         (-[WebActionMenuController prepareForMenu:withEvent:]):
847         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
848         and use a bigger hammer (removeAllItems).
849
850         (-[WebActionMenuController willOpenMenu:withEvent:]):
851         If we end up with a menu with no items, don't change selection or anything.
852
853 2014-11-20  Beth Dakin  <bdakin@apple.com>
854
855         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
856         https://bugs.webkit.org/show_bug.cgi?id=138568
857         -and corresponding-
858         rdar://problem/18904600
859
860         Reviewed by Tim Horton.
861
862         Skip images for lookup.
863         * WebView/WebActionMenuController.mm:
864         (performDictionaryLookupForRange):
865
866 2014-11-19  Beth Dakin  <bdakin@apple.com>
867
868         Invoking an action menu on a selection should result in the text menu
869         https://bugs.webkit.org/show_bug.cgi?id=138892
870         -and corresponding-
871         rdar://problem/18996776
872
873         Reviewed by Tim Horton.
874
875         * WebView/WebActionMenuController.mm:
876         (-[WebActionMenuController _defaultMenuItems]):
877
878 2014-11-19  Beth Dakin  <bdakin@apple.com>
879
880         Data detected results with no menu items should not fall through to regular text 
881         action menus
882         https://bugs.webkit.org/show_bug.cgi?id=138887
883         -and corresponding-
884         rdar://problem/18971616
885
886         Reviewed by Tim Horton.
887
888         * WebView/WebActionMenuController.mm:
889         (-[WebActionMenuController _defaultMenuItems]):
890
891 2014-11-19  Daniel Bates  <dabates@apple.com>
892
893         [iOS] Make WebKit build with public iOS SDK
894         https://bugs.webkit.org/show_bug.cgi?id=136863
895
896         Reviewed by David Kilzer.
897
898         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
899         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
900         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
901         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
902         may be used by Apple internal clients that do not include wtf/Platform.h.
903         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
904         private Foundation headers directly.
905         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
906         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
907         instead of including private CFNetwork headers directly. Also fixed up style and
908         ordering of header include directives.
909         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
910         CFNetwork headers directly. Also sort the #import directives.
911         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
912         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
913
914 2014-11-18  David Kilzer  <ddkilzer@apple.com>
915
916         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
917         <http://webkit.org/b/138813>
918
919         Reviewed by Mark Rowe.
920
921         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
922         selectors.
923
924 2014-11-18  Chris Dumez  <cdumez@apple.com>
925
926         Add a setting to toggle DOMTimer throttling support
927         https://bugs.webkit.org/show_bug.cgi?id=138844
928         <rdar://problem/19020874>
929
930         Reviewed by Andreas Kling.
931
932         Add a setting to disable DOM timers throttling, in order to help
933         developers determine if a specific issue is caused by timer
934         throttling.
935
936         * WebView/WebPreferenceKeysPrivate.h:
937         * WebView/WebPreferences.mm:
938         (+[WebPreferences initialize]):
939         (-[WebPreferences domTimersThrottlingEnabled]):
940         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
941         * WebView/WebPreferencesPrivate.h:
942         * WebView/WebView.mm:
943         (-[WebView _preferencesChanged:]):
944
945 2014-11-18  Tim Horton  <timothy_horton@apple.com>
946
947         Avoid re-encoding action menu image data
948         https://bugs.webkit.org/show_bug.cgi?id=138817
949         <rdar://problem/18840382>
950
951         Reviewed by Anders Carlsson.
952
953         * WebView/WebActionMenuController.mm:
954         (-[WebActionMenuController _defaultMenuItemsForImage:]):
955         (-[WebActionMenuController _addImageToPhotos:]):
956         Build a temporary filename from a UUID and the image's desired extension.
957         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
958         Build an image menu only if we have an image, URL, data, and extension.
959
960 2014-11-18  Daniel Bates  <dabates@apple.com>
961
962         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
963         SPI are not available in public SDK
964         https://bugs.webkit.org/show_bug.cgi?id=138802
965
966         Reviewed by David Kilzer.
967
968         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
969         libdispatch and MobileGestalt headers directly.
970
971         * WebView/WebView.mm:
972
973 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
974
975         Remove calls to deprecated NSMenu methods
976         https://bugs.webkit.org/show_bug.cgi?id=138808.
977
978         Reviewed by Anders Carlsson.
979
980         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
981
982         * WebCoreSupport/PopupMenuMac.mm:
983         (PopupMenuMac::populate):
984
985 2014-11-17  Daniel Bates  <dabates@apple.com>
986
987         Unreviewed, rolling out r176232.
988
989         Broke the Mac build. Will investigate offline.
990
991         Reverted changeset:
992
993         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
994         MobileGestalt"
995         https://bugs.webkit.org/show_bug.cgi?id=138802
996         http://trac.webkit.org/changeset/176232
997
998 2014-11-17  Daniel Bates  <dabates@apple.com>
999
1000         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1001         SPI are not available in public SDK
1002         https://bugs.webkit.org/show_bug.cgi?id=138802
1003
1004         Reviewed by David Kilzer.
1005
1006         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
1007         libdispatch and MobileGestalt headers directly.
1008
1009         * WebView/WebView.mm:
1010
1011 2014-11-17  Beth Dakin  <bdakin@apple.com>
1012
1013         Whitespace action menus should focus the HitTestResult and create an insertion 
1014         point
1015         https://bugs.webkit.org/show_bug.cgi?id=138786
1016         -and corresponding-
1017         rdar://problem/18944893
1018
1019         Reviewed by Tim Horton.
1020
1021         Whitespace menus should cause the HitTestResult to be focused, and they should set 
1022         the selection based on the HitTest location.
1023
1024         * WebView/WebActionMenuController.mm:
1025         (-[WebActionMenuController isMenuForTextContent]):
1026         (-[WebActionMenuController focusAndSelectHitTestResult]):
1027         (-[WebActionMenuController willOpenMenu:withEvent:]):
1028
1029 2014-11-17  Daniel Bates  <dabates@apple.com>
1030
1031         [iOS] QuartzCore SPI not available in public SDK
1032         https://bugs.webkit.org/show_bug.cgi?id=138751
1033
1034         Reviewed by David Kilzer.
1035
1036         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
1037
1038         * WebInspector/WebNodeHighlight.mm:
1039         * WebView/WebIndicateLayer.mm:
1040
1041 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
1042
1043         [iOS] allow host application to opt-out of alternate fullscreen
1044         https://bugs.webkit.org/show_bug.cgi?id=138787
1045
1046         Reviewed by Darin Adler.
1047
1048         * WebView/WebPreferenceKeysPrivate.h:
1049         * WebView/WebPreferences.mm:
1050         (+[WebPreferences initialize]):
1051         (-[WebPreferences allowsAlternateFullscreen]):
1052         (-[WebPreferences setAllowsAlternateFullscreen:]):
1053         * WebView/WebPreferencesPrivate.h:
1054         * WebView/WebView.mm:
1055         (-[WebView _preferencesChanged:]):
1056
1057 2014-11-16  Tim Horton  <timothy_horton@apple.com>
1058
1059         Use TextIndicator instead of the built in Lookup highlight
1060         https://bugs.webkit.org/show_bug.cgi?id=138775
1061         <rdar://problem/18953982>
1062
1063         Reviewed by Anders Carlsson.
1064
1065         * WebCoreSupport/WebSystemInterface.mm:
1066         (InitWebCoreSystemInterface):
1067         Remove a WKSI import.
1068
1069         * WebView/WebActionMenuController.mm:
1070         (-[WebActionMenuController _lookupText:]):
1071         (-[WebActionMenuController _createActionMenuItemForTag:]):
1072         Make use of the new Lookup SPI header.
1073         Disable the Lookup item if lookup is not available.
1074
1075 2014-11-15  Tim Horton  <timothy_horton@apple.com>
1076
1077         Implement data detectors and mailto action menus for WebKit1
1078         https://bugs.webkit.org/show_bug.cgi?id=138765
1079         <rdar://problem/18877535>
1080
1081         Reviewed by Beth Dakin.
1082
1083         * WebView/WebActionMenuController.h:
1084         * WebView/WebActionMenuController.mm:
1085         (-[WebActionMenuController willOpenMenu:withEvent:]):
1086         Tell DataDetectors that the menu is going to open.
1087         Select the text (or not) based on the number of items in the menu, just like WebKit2.
1088
1089         (-[WebActionMenuController didCloseMenu:withEvent:]):
1090         Tell DataDetectors that the menu closed.
1091
1092         (-[WebActionMenuController _defaultMenuItemsForLink]):
1093         Move these checks out of _defaultMenuItemsForLink, because we expect this
1094         to always return a complete link menu.
1095
1096         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
1097         Implement. More or less copied from WebKit2.
1098
1099         (-[WebActionMenuController _selectDataDetectedText]):
1100         Select the stashed range.
1101
1102         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1103         Implement. More or less copied from WebKit2.
1104         The yellow highlight isn't hooked up yet.
1105         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
1106
1107         (-[WebActionMenuController _selectLookupText]):
1108         Remove an unnecessary return.
1109
1110         (-[WebActionMenuController _defaultMenuItems]):
1111         Call into the two new menu types.
1112
1113         * WebView/WebUIDelegatePrivate.h:
1114
1115 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
1116
1117         Get rid of WebFontCache
1118         https://bugs.webkit.org/show_bug.cgi?id=134752
1119
1120         Reviewed by Dave Hyatt.
1121
1122         * WebView/WebHTMLView.mm:
1123
1124 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
1125
1126         Update some artwork for the legacy WebKit action menu
1127         https://bugs.webkit.org/show_bug.cgi?id=138758
1128         <rdar://problem/18989840>
1129
1130         * WebView/WebActionMenuController.mm:
1131         (webKitBundleImageNamed): Deleted.
1132         Fix the build.
1133
1134 2014-11-14  Tim Horton  <timothy_horton@apple.com>
1135
1136         Update some artwork for the legacy WebKit action menu
1137         https://bugs.webkit.org/show_bug.cgi?id=138758
1138         <rdar://problem/18989840>
1139
1140         Reviewed by Simon Fraser.
1141
1142         * WebView/WebActionMenuController.mm:
1143         (-[WebActionMenuController _createActionMenuItemForTag:]):
1144
1145 2014-11-14  Daniel Bates  <dabates@apple.com>
1146
1147         [iOS] NSFileManager and QuickLook SPI not available in public SDK
1148         https://bugs.webkit.org/show_bug.cgi?id=138742
1149
1150         Reviewed by Pratik Solanki.
1151
1152         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
1153
1154         * WebCoreSupport/WebFrameLoaderClient.mm:
1155
1156 2014-11-14  Beth Dakin  <bdakin@apple.com>
1157
1158         WK1: Webpage preview can come up in wrong location
1159         https://bugs.webkit.org/show_bug.cgi?id=138747
1160         -and corresponding-
1161         rdar://problem/18979004
1162
1163         Reviewed by Tim Horton.
1164
1165         Converting to window twice is bad.
1166         * WebView/WebActionMenuController.mm:
1167         (elementBoundingBoxInWindowCoordinatesFromNode):
1168         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1169         (elementBoundingBoxFromNode): Deleted.
1170
1171 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
1172
1173         Move FontMac and FontCacheMac off of WKSI
1174         https://bugs.webkit.org/show_bug.cgi?id=138633
1175
1176         Reviewed by Simon Fraser.
1177
1178         * WebCoreSupport/WebSystemInterface.mm:
1179         (InitWebCoreSystemInterface):
1180         * WebKit.order:
1181
1182 2014-11-13  Beth Dakin  <bdakin@apple.com>
1183
1184         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
1185         https://bugs.webkit.org/show_bug.cgi?id=138716
1186         -and corresponding-
1187         rdar://problem/18977222
1188
1189         Reviewed by Tim Horton.
1190
1191         It’s not necessary to use the WebElementDictionary for so many things now that we 
1192         are caching the HitTestResult. We should just use the HitTestResult.
1193
1194         * WebView/WebActionMenuController.mm:
1195         (-[WebActionMenuController prepareForMenu:withEvent:]):
1196         (-[WebActionMenuController _openURLFromActionMenu:]):
1197         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
1198         (elementBoundingBoxFromNode):
1199         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1200         (-[WebActionMenuController _defaultMenuItemsForLink]):
1201         (-[WebActionMenuController _defaultMenuItemsForImage]):
1202         (-[WebActionMenuController _defaultMenuItemsForVideo]):
1203         (-[WebActionMenuController _defaultMenuItemsForText]):
1204         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
1205         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
1206         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
1207         (-[WebActionMenuController _createActionMenuItemForTag:]):
1208         (-[WebActionMenuController _defaultMenuItems]):
1209         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
1210         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
1211         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
1212         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
1213         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
1214         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
1215         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
1216         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
1217         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
1218         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
1219
1220 2014-11-13  Daniel Bates  <dabates@apple.com>
1221
1222         [iOS] NSGeometry data types are not available in the public SDK
1223         https://bugs.webkit.org/show_bug.cgi?id=137536
1224
1225         Reviewed by David Kilzer.
1226
1227         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
1228         private header.
1229
1230         * DOM/WebDOMOperationsPrivate.h:
1231
1232 2014-11-13  Beth Dakin  <bdakin@apple.com>
1233
1234         WK1: Support default actions for video
1235         https://bugs.webkit.org/show_bug.cgi?id=138713
1236         -and corresponding-
1237         rdar://problem/18877520
1238
1239         Reviewed by Tim Horton.
1240
1241         Call setToNonShadowAncestor() for media HitTestResults.
1242         * WebView/WebActionMenuController.mm:
1243         (-[WebActionMenuController performHitTestAtPoint:]):
1244
1245         Default items and actions.
1246         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
1247         (-[WebActionMenuController _copyVideoURL:]):
1248         (-[WebActionMenuController _saveVideoToDownloads:]):
1249         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1250         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1251         * WebView/WebUIDelegatePrivate.h:
1252
1253 2014-11-13  Tim Horton  <timothy_horton@apple.com>
1254
1255         WK1: Update icon for Add to Reading List
1256         https://bugs.webkit.org/show_bug.cgi?id=138710
1257         <rdar://problem/18975774>
1258
1259         Reviewed by Beth Dakin.
1260
1261         * WebView/WebActionMenuController.mm:
1262         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1263         Use the right icon, matching WebKit2.
1264
1265 2014-11-12  Beth Dakin  <bdakin@apple.com>
1266
1267         WK1: Support default actions for images
1268         https://bugs.webkit.org/show_bug.cgi?id=138668
1269         -and corresponding-
1270         rdar://problem/18785434
1271
1272         Reviewed by Tim Horton.
1273
1274         * WebView/WebActionMenuController.h:
1275         * WebView/WebActionMenuController.mm:
1276         (-[WebActionMenuController didCloseMenu:withEvent:]):
1277         (-[WebActionMenuController _defaultMenuItemsForImage:]):
1278         (-[WebActionMenuController _copyImage:]):
1279         (temporaryPhotosDirectoryPath):
1280         (pathToPhotoOnDisk):
1281         (-[WebActionMenuController _canAddMediaToPhotos]):
1282         (-[WebActionMenuController _addImageToPhotos:]):
1283         (-[WebActionMenuController _saveImageToDownloads:]):
1284         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
1285         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
1286         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
1287         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1288         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1289         * WebView/WebUIDelegatePrivate.h:
1290
1291 2014-11-11  Beth Dakin  <bdakin@apple.com>
1292
1293         Action menu hit testing is not working properly with all WK1 apps
1294         https://bugs.webkit.org/show_bug.cgi?id=138643
1295         -and corresponding-
1296         rdar://problem/18949376
1297
1298         Reviewed by Tim Horton.
1299
1300         * WebView/WebActionMenuController.mm:
1301         (-[WebActionMenuController prepareForMenu:withEvent:]):
1302         (-[WebActionMenuController _lookupText:]):
1303
1304 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1305
1306         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
1307         https://bugs.webkit.org/show_bug.cgi?id=138623
1308
1309         Reviewed by Geoff Garen.
1310
1311         * WebCoreSupport/WebSystemInterface.mm:
1312         (InitWebCoreSystemInterface):
1313         * WebKit.order:
1314
1315 2014-11-11  Tim Horton  <timothy_horton@apple.com>
1316
1317         Localize strings for action menus
1318         https://bugs.webkit.org/show_bug.cgi?id=138591
1319         <rdar://problem/18815343>
1320
1321         Reviewed by Dan Bates.
1322
1323         * WebView/WebActionMenuController.mm:
1324         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1325         Make use of the new strings.
1326
1327 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1328
1329         Cleanup from r175379
1330         https://bugs.webkit.org/show_bug.cgi?id=138616
1331
1332         Reviewed by Simon Fraser.
1333
1334         * WebCoreSupport/WebSystemInterface.mm:
1335         (InitWebCoreSystemInterface):
1336         * WebKit.order:
1337
1338 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1339
1340         Move CTFontTransformGlyphs out from WKSI
1341         https://bugs.webkit.org/show_bug.cgi?id=138599
1342
1343         Reviewed by Simon Fraser.
1344
1345         * WebCoreSupport/WebSystemInterface.mm:
1346         (InitWebCoreSystemInterface):
1347         * WebKit.order:
1348
1349 2014-11-11  Dan Bernstein  <mitz@apple.com>
1350
1351         More iOS build fix.
1352
1353         * WebView/WebHTMLViewInternal.h:
1354
1355 2014-11-11  Dan Bernstein  <mitz@apple.com>
1356
1357         iOS build fix.
1358
1359         * WebView/WebHTMLView.mm:
1360
1361 2014-11-10  Beth Dakin  <bdakin@apple.com>
1362
1363         WK1: Support default actions for editable text with misspelled word
1364         https://bugs.webkit.org/show_bug.cgi?id=138590
1365         -and corresponding-
1366         rdar://problem/18877506
1367
1368         Reviewed by Tim Horton.
1369
1370         If there are misspelled word suggestions for editable text, create a new type of 
1371         menu with a spelling suggestion sub-menu.
1372
1373         * WebView/WebActionMenuController.mm:
1374         (-[WebActionMenuController isMenuForTextContent]):
1375         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
1376         (-[WebActionMenuController _changeSelectionToSuggestion:]):
1377         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1378         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1379         * WebView/WebHTMLView.mm:
1380         (-[WebHTMLView _changeSpellingToWord:]):
1381         * WebView/WebHTMLViewInternal.h:
1382         * WebView/WebUIDelegatePrivate.h:
1383
1384 2014-11-10  Beth Dakin  <bdakin@apple.com>
1385
1386         WK1: Support default actions for editable whitespace
1387         https://bugs.webkit.org/show_bug.cgi?id=138586
1388         -and corresponding-
1389         rdar://problem/18932048
1390
1391         Reviewed by Tim Horton.
1392
1393         New menu type. Just wants paste.
1394
1395         * WebView/WebActionMenuController.mm:
1396         (-[WebActionMenuController isMenuForTextContent]):
1397         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
1398         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1399         * WebView/WebUIDelegatePrivate.h:
1400
1401 2014-11-10  Beth Dakin  <bdakin@apple.com>
1402
1403         WK1: Support default actions for editable text
1404         https://bugs.webkit.org/show_bug.cgi?id=138580
1405         -and corresponding-
1406         rdar://problem/18877497
1407
1408         Reviewed by Tim Horton.
1409
1410         New menu type, and new action type for paste. 
1411
1412         * WebView/WebActionMenuController.mm:
1413         (-[WebActionMenuController isMenuForTextContent]):
1414         (-[WebActionMenuController willOpenMenu:withEvent:]):
1415         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
1416         (-[WebActionMenuController _paste:]):
1417         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1418         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1419         * WebView/WebUIDelegatePrivate.h:
1420
1421 2014-11-10  Beth Dakin  <bdakin@apple.com>
1422
1423         WK1: Text is getting selected even when an action menu fails to invoke
1424         https://bugs.webkit.org/show_bug.cgi?id=138576
1425         -and corresponding-
1426         rdar://problem/18931330
1427
1428         Reviewed by Tim Horton.
1429
1430         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
1431         * WebView/WebActionMenuController.h:
1432         * WebView/WebActionMenuController.mm:
1433         (-[WebActionMenuController prepareForMenu:withEvent:]):
1434         (-[WebActionMenuController willOpenMenu:withEvent:]):
1435
1436         _selectLookupText no longer needs to return a BOOL indicating success or failure.
1437         (-[WebActionMenuController _selectLookupText]):
1438         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1439
1440         Pass willOpenMenu: on to the controller.
1441         * WebView/WebView.mm:
1442         (-[WebView willOpenMenu:withEvent:]):
1443
1444 2014-11-10  Beth Dakin  <bdakin@apple.com>
1445
1446         Speculative build fix.
1447
1448         * WebView/WebActionMenuController.mm:
1449
1450 2014-11-10  Beth Dakin  <bdakin@apple.com>
1451
1452         Action menu initialization should be moved to _commonInitializationWithFrameName
1453         https://bugs.webkit.org/show_bug.cgi?id=138572
1454         -and corresponding-
1455         rdar://problem/18929733
1456
1457         Reviewed by Tim Horton.
1458
1459         * WebView/WebView.mm:
1460         (-[WebView _commonInitializationWithFrameName:groupName:]):
1461         (-[WebView _initWithFrame:frameName:groupName:]):
1462
1463 2014-11-10  Beth Dakin  <bdakin@apple.com>
1464
1465         WK1: Support default actions for read-only text
1466         https://bugs.webkit.org/show_bug.cgi?id=138552
1467         -and corresponding-
1468         rdar://problem/18877483
1469
1470         Reviewed by Tim Horton.
1471
1472         New WKSystemInterface functions that WebCore needs to use.
1473         * WebCoreSupport/WebSystemInterface.mm:
1474         (InitWebCoreSystemInterface):
1475
1476         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
1477         makes a lot of things easier.
1478         * WebView/WebActionMenuController.h:
1479         * WebView/WebActionMenuController.mm:
1480
1481         Perform the hit test ourselves instead of calling into WebView so that we can more 
1482         easily save the WebCore::HitTestResult for ourselves.
1483         (-[WebActionMenuController performHitTestAtPoint:]):
1484
1485         Clear selection for non-text menus.
1486         (-[WebActionMenuController prepareForMenu:withEvent:]):
1487
1488         Re-set the _type here just to be safe.
1489         (-[WebActionMenuController didCloseMenu:withEvent:]):
1490
1491         Moving this method to be next to the link actions so they can be within a pragma 
1492         mark.
1493         (-[WebActionMenuController _defaultMenuItemsForLink:]):
1494
1495         New method for default text actions — lookup and copy.
1496         (-[WebActionMenuController _defaultMenuItemsForText:]):
1497         (-[WebActionMenuController _copySelection:]):
1498         (-[WebActionMenuController _lookupText:]):
1499
1500         If there is not already a selection, invoking the action menu on text should 
1501         select the lookup text.
1502         (-[WebActionMenuController _selectLookupText]):
1503         (performDictionaryLookupForSelection):
1504         (performDictionaryLookupForRange):
1505
1506         Handle text now.
1507         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1508         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1509
1510         New enum values.
1511         * WebView/WebUIDelegatePrivate.h:
1512
1513         Pass didCloseMenu on to the controller.
1514         * WebView/WebView.mm:
1515         (-[WebView didCloseMenu:withEvent:]):
1516
1517 2014-11-09  Chris Dumez  <cdumez@apple.com>
1518
1519         Add a more correct way to compare floating point numbers and use it
1520         https://bugs.webkit.org/show_bug.cgi?id=138527
1521
1522         Reviewed by Darin Adler.
1523
1524         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
1525         to compare floating-point numbers.
1526
1527         * WebView/WebHTMLView.mm:
1528         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
1529
1530 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
1531
1532         Delete cookies between tests
1533         https://bugs.webkit.org/show_bug.cgi?id=138528
1534
1535         Reviewed by Sam Weinig.
1536
1537         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
1538         * WebView/WebPreferencesPrivate.h:
1539         Added an SPI for DumpRenderTree.
1540
1541 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
1542
1543         [iOS] Update optimized fullscreen media controls
1544         https://bugs.webkit.org/show_bug.cgi?id=138493
1545
1546         Reviewed by Brent Fulgham.
1547
1548         * WebCoreSupport/WebSystemInterface.mm:
1549         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
1550
1551 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
1552
1553         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
1554         https://bugs.webkit.org/show_bug.cgi?id=138443
1555
1556         Reviewed by Anders Carlsson.
1557
1558         Wrapping the dealloc method in its own autorelease pool avoids the problem of
1559         complex tear-downs leading to the WebView itself being added to an autorelease
1560         pool that is not drained until after the instance has been dealloc'd.
1561  
1562         * WebView/WebView.mm:
1563         (-[WebView dealloc]):
1564
1565 2014-11-05  Jer Noble  <jer.noble@apple.com>
1566
1567         De-templatize Timer
1568         https://bugs.webkit.org/show_bug.cgi?id=138450
1569
1570         Reviewed by Anders Carlsson.
1571
1572         Remove template specifiers from Timer.
1573
1574         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1575         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1576         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
1577         * Plugins/WebNetscapePluginStream.h:
1578         * Plugins/WebNetscapePluginStream.mm:
1579         (WebNetscapePluginStream::deliverDataTimerFired):
1580
1581 2014-11-05  Dan Bernstein  <mitz@apple.com>
1582
1583         Remove the unused deletion UI feature
1584         https://bugs.webkit.org/show_bug.cgi?id=138442
1585
1586         Rubber-stamped by Alexey Proskuryakov.
1587
1588         * DefaultDelegates/WebDefaultEditingDelegate.m:
1589         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
1590         * WebCoreSupport/WebEditorClient.h:
1591         * WebCoreSupport/WebEditorClient.mm:
1592         (WebEditorClient::shouldShowDeleteInterface): Deleted.
1593         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
1594         -webView:shouldShowDeleteInterfaceForElement:.
1595
1596 2014-11-03  Dean Jackson  <dino@apple.com>
1597
1598         Add ENABLE_FILTERS_LEVEL_2 feature guard.
1599         https://bugs.webkit.org/show_bug.cgi?id=138362
1600
1601         Reviewed by Tim Horton.
1602
1603         Add a new feature define for Level 2 of CSS Filters.
1604         http://dev.w3.org/fxtf/filters-2/
1605
1606         * Configurations/FeatureDefines.xcconfig:
1607
1608 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
1609
1610         Add button and enable optimized fullscreen.
1611         https://bugs.webkit.org/show_bug.cgi?id=138351
1612
1613         Reviewed by Eric Carlson.
1614
1615         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
1616
1617         * WebCoreSupport/WebSystemInterface.mm:
1618         (InitWebCoreSystemInterface): added
1619
1620 2014-11-04  Chris Dumez  <cdumez@apple.com>
1621
1622         Add ptr() method to Ref class
1623         https://bugs.webkit.org/show_bug.cgi?id=138361
1624
1625         Reviewed by Darin Adler.
1626
1627         Use the new Ref::ptr() method.
1628
1629         * WebView/WebFrame.mm:
1630         (-[WebFrame _setTypingStyle:withUndoAction:]):
1631         * WebView/WebHTMLView.mm:
1632         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
1633         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
1634         * WebView/WebView.mm:
1635         (-[WebView applyStyle:]):
1636
1637 2014-11-04  Darin Adler  <darin@apple.com>
1638
1639         Eliminate ResourceBuffer and use SharedBuffer directly instead
1640         https://bugs.webkit.org/show_bug.cgi?id=138174
1641
1642         Reviewed by Antti Koivisto.
1643
1644         * WebView/WebDataSource.mm:
1645         (-[WebDataSource data]): Use SharedBuffer directly.
1646         * WebView/WebHTMLView.mm:
1647         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1648
1649 2014-11-03  Commit Queue  <commit-queue@webkit.org>
1650
1651         Unreviewed, rolling out r175406, r175413, and r175423.
1652         https://bugs.webkit.org/show_bug.cgi?id=138327
1653
1654         Multipart tests are still broken (Requested by ap on #webkit).
1655
1656         Reverted changesets:
1657
1658         "Eliminate ResourceBuffer and use SharedBuffer directly
1659         instead"
1660         https://bugs.webkit.org/show_bug.cgi?id=138174
1661         http://trac.webkit.org/changeset/175406
1662
1663         "Unreviewed, iOS build fix since 175406."
1664         http://trac.webkit.org/changeset/175413
1665
1666         "Fix assertion in CachedResource::addDataBuffer"
1667         http://trac.webkit.org/changeset/175423
1668
1669 2014-10-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1670
1671         Use std::unique_ptr for TypeCountSet
1672         https://bugs.webkit.org/show_bug.cgi?id=138242
1673
1674         Reviewed by Andreas Kling.
1675
1676         * Misc/WebCoreStatistics.mm:
1677         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr.
1678         (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto.
1679
1680 2014-10-31  Beth Dakin  <bdakin@apple.com>
1681
1682         Use system art for action menus when possible
1683         https://bugs.webkit.org/show_bug.cgi?id=138260
1684
1685         Reviewed by Tim Horton.
1686
1687         * WebView/WebActionMenuController.mm:
1688         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1689
1690 2014-10-30  Darin Adler  <darin@apple.com>
1691
1692         Eliminate ResourceBuffer and use SharedBuffer directly instead
1693         https://bugs.webkit.org/show_bug.cgi?id=138174
1694
1695         Reviewed by Antti Koivisto.
1696
1697         * WebView/WebDataSource.mm:
1698         (-[WebDataSource data]): Use SharedBuffer directly.
1699         * WebView/WebHTMLView.mm:
1700         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1701
1702 2014-10-30  Jer Noble  <jer.noble@apple.com>
1703
1704         [EME] Add Setting for accessing storage location for MediaKeys data
1705         https://bugs.webkit.org/show_bug.cgi?id=138147
1706
1707         Reviewed by Brady Eidson.
1708
1709         * WebView/WebPreferenceKeysPrivate.h:
1710         * WebView/WebPreferences.mm:
1711         (+[WebPreferences initialize]): Set default location.
1712         (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor.
1713         (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter.
1714         * WebView/WebPreferencesPrivate.h:
1715         * WebView/WebView.mm:
1716         (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings.
1717
1718 2014-10-30  Dana Burkart  <dburkart@apple.com>
1719
1720         <rdar://problem/18821260> Prepare for the mysterious future
1721
1722         Reviewed by Lucas Forschler.
1723
1724         * Configurations/Base.xcconfig:
1725         * Configurations/DebugRelease.xcconfig:
1726         * Configurations/FeatureDefines.xcconfig:
1727         * Configurations/Version.xcconfig:
1728
1729 2014-10-28  Jeremy Jones  <jeremyj@apple.com>
1730
1731         Add optimized fullscreen mode.
1732         https://bugs.webkit.org/show_bug.cgi?id=138044
1733
1734         Reviewed by Jer Noble.
1735
1736         Enable different types of fullscreen video behavior.
1737         Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
1738
1739         * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
1740         * WebCoreSupport/WebChromeClient.mm:
1741         (WebChromeClient::enterVideoFullscreenForVideoElement): ditto
1742         * WebView/WebView.mm:
1743         (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
1744         (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.
1745         * WebView/WebViewInternal.h: ditto
1746
1747 2014-10-27  Beth Dakin  <bdakin@apple.com>
1748
1749         Provide a way for WebKit1 clients to override default action menu items
1750         https://bugs.webkit.org/show_bug.cgi?id=138066
1751         -and corresponding-
1752         rdar://problem/18451638
1753
1754         Reviewed by Anders Carlsson.
1755
1756         WebActionMenuController now has an ivar for the WebActionMenuType so that it can 
1757         send that along to clients customizing the menu.
1758         * WebView/WebActionMenuController.h:
1759         * WebView/WebActionMenuController.mm:
1760         (-[WebActionMenuController prepareForMenu:withEvent:]):
1761         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1762
1763         New enum and new SPI to customize menus.
1764         * WebView/WebUIDelegatePrivate.h:
1765
1766 2014-10-24  Benjamin Poulain  <bpoulain@apple.com>
1767
1768         Fix the iOS build
1769
1770         * Configurations/WebKitLegacy.xcconfig:
1771         * WebView/WebView.mm:
1772
1773 2014-10-24  Beth Dakin  <bdakin@apple.com>
1774
1775         Build fix.
1776
1777         * WebView/WebActionMenuController.mm:
1778         (-[WebActionMenuController _openURLFromActionMenu:]):
1779         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
1780         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1781
1782 2014-10-24  Beth Dakin  <bdakin@apple.com>
1783
1784         WebKit1 should support action menus
1785         https://bugs.webkit.org/show_bug.cgi?id=138032
1786
1787         Reviewed by Tim Horton.
1788
1789         This patch adds basic support for action menus and adds actions for links.
1790
1791         Helper class takes care of all of the action menu work. WebView will forward the 
1792         prepareForMenu: message, and then the helper class takes it from there.
1793         * WebView/WebActionMenuController.h: Added.
1794         * WebView/WebActionMenuController.mm: Added.
1795         (-[WebActionMenuController webViewClosed]):
1796         (-[WebActionMenuController prepareForMenu:withEvent:]):
1797
1798         Selectors for link actions.
1799         (-[WebActionMenuController _openURLFromActionMenu:]):
1800         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
1801         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
1802         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1803         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1804         (webKitBundleImageNamed):
1805         (-[WebActionMenuController _defaultMenuItemsForLink:]):
1806         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1807
1808         Tags for the action menu items.
1809         * WebView/WebUIDelegatePrivate.h:
1810         * WebView/WebView.mm:
1811
1812         Set the action menu if possible and create the controller.
1813         (-[WebView _initWithFrame:frameName:groupName:]):
1814         (-[WebView _close]):
1815         (-[WebView prepareForMenu:withEvent:]):
1816
1817         WebViewData stores the WebActionMenuHelper
1818         * WebView/WebViewData.h:
1819         * WebView/WebViewData.mm:
1820         (-[WebViewPrivate dealloc]):
1821
1822 2014-10-23  Joseph Pecoraro  <pecoraro@apple.com>
1823
1824         Web Inspector: Provide a way to have alternate inspector agents
1825         https://bugs.webkit.org/show_bug.cgi?id=137901
1826
1827         Reviewed by Brian Burg.
1828
1829         * Configurations/FeatureDefines.xcconfig:
1830
1831 2014-10-23  Tim Horton  <timothy_horton@apple.com>
1832
1833         Add some SPI headers for NSExtension and NSSharingService{Picker}
1834         https://bugs.webkit.org/show_bug.cgi?id=138027
1835
1836         Reviewed by Anders Carlsson.
1837
1838         * Misc/WebSharingServicePickerController.h:
1839         * Misc/WebSharingServicePickerController.mm:
1840         * WebCoreSupport/WebSelectionServiceController.mm:
1841         * WebCoreSupport/WebContextMenuClient.mm:
1842         Fix a sorting issue.
1843         Replace redefinitions with SPI header #imports.
1844
1845 2014-10-23  Tim Horton  <timothy_horton@apple.com>
1846
1847         Crashes under WebSelectionServiceController::hasRelevantSelectionServices
1848         https://bugs.webkit.org/show_bug.cgi?id=138013
1849
1850         Reviewed by Dan Bernstein.
1851
1852         * WebCoreSupport/WebSelectionServiceController.mm:
1853         (WebSelectionServiceController::hasRelevantSelectionServices):
1854         Don't adopt this autoreleased object.
1855
1856 2014-10-22  Chris Dumez  <cdumez@apple.com>
1857
1858         [Mac][WK2] Fix applicationIsSafari() detection
1859         https://bugs.webkit.org/show_bug.cgi?id=137893
1860
1861         Reviewed by Alexey Proskuryakov.
1862
1863         Provide an implementation for FrameLoaderClient's new
1864         needsQuickLookResourceCachingQuirks() that returns
1865         a static flag initialized using
1866         QuickLookMac::computeNeedsQuickLookResourceCachingQuirks().
1867
1868         * WebCoreSupport/WebFrameLoaderClient.h:
1869         * WebCoreSupport/WebFrameLoaderClient.mm:
1870
1871 2014-10-20  Chris Dumez  <cdumez@apple.com>
1872
1873         ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition
1874         https://bugs.webkit.org/show_bug.cgi?id=137797
1875
1876         Reviewed by Darin Adler.
1877
1878         Call ResourceRequest::setDomainForPartitionName() instead of
1879         setPartitionName() as the argument is a domain, not a valid
1880         partition name.
1881
1882         * Misc/WebCache.mm:
1883         (+[WebCache addImageToCache:forURL:forFrame:]):
1884         (+[WebCache removeImageFromCacheForURL:forFrame:]):
1885
1886 2014-10-20  Andy Estes  <aestes@apple.com>
1887
1888         Fix the iOS build.
1889
1890         * WebView/WebFrame.mm:
1891         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1892         (-[WebFrame dictationResultMetadataForRange:]):
1893
1894 2014-10-19  Chris Dumez  <cdumez@apple.com>
1895
1896         Use is<>() / downcast<>() for all remaining RenderObject subclasses
1897         https://bugs.webkit.org/show_bug.cgi?id=137845
1898
1899         Reviewed by Darin Adler.
1900
1901         Use is<>() / downcast<>() for all remaining RenderObject subclasses and 
1902         clean up the surrounding code.
1903
1904         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1905         (-[WebHostedNetscapePluginView pluginHostDied]):
1906         * Plugins/WebBaseNetscapePluginView.mm:
1907         (-[WebBaseNetscapePluginView _windowClipRect]):
1908         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
1909         * WebCoreSupport/WebFrameLoaderClient.mm:
1910         (WebFrameLoaderClient::createPlugin):
1911         (WebFrameLoaderClient::createJavaAppletWidget):
1912
1913 2014-10-17  Tim Horton  <timothy_horton@apple.com>
1914
1915         Build fix for 32-bit Yosemite
1916
1917         * WebCoreSupport/WebContextMenuClient.mm:
1918         (WebContextMenuClient::contextMenuForEvent):
1919         Avoid using NSItemProvider in 32-bit, because it doesn't exist.
1920
1921 2014-10-17  Chris Dumez  <cdumez@apple.com>
1922
1923         Use is<>() / downcast<>() for RenderBox
1924         https://bugs.webkit.org/show_bug.cgi?id=137804
1925
1926         Reviewed by Andreas Kling.
1927
1928         Use is<>() / downcast<>() for RenderBox and clean up the surrounding
1929         code.
1930
1931         * WebCoreSupport/WebContextMenuClient.mm:
1932         (WebContextMenuClient::clientFloatRectForNode):
1933         * WebView/WebFrame.mm:
1934         (-[WebFrame renderedSizeOfNode:constrainedToWidth:]):
1935
1936 2014-10-17  Tim Horton  <timothy_horton@apple.com>
1937
1938         Fix the build with the public SDK.
1939
1940         * WebCoreSupport/WebSelectionServiceController.mm:
1941         We should transition all this SPI to real SPI headers as soon as possible.
1942
1943 2014-10-16  Tim Horton  <timothy_horton@apple.com>
1944
1945         Implement selection services menu for Legacy WebKit
1946         https://bugs.webkit.org/show_bug.cgi?id=137582
1947         <rdar://problem/18604241>
1948
1949         Reviewed by Brady Eidson.
1950
1951         * Misc/WebSharingServicePickerController.h:
1952         Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
1953         Add WebSharingServicePickerClient, which other classes can implement
1954         instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
1955         Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.
1956
1957         * Misc/WebSharingServicePickerController.mm:
1958         Pass in NSSharingServicePickerStyle, so that clients can specify the style.
1959
1960         (-[WebSharingServicePickerController clear]):
1961         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
1962         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
1963         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
1964         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
1965         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
1966         Make use of WebSharingServicePickerClient.
1967
1968         (-[WebSharingServicePickerController sharingService:didShareItems:]):
1969         If we're returned a NSAttributedString, paste it on top of the current selection,
1970         similar to what the WebKit2 implementation currently does.
1971         
1972         * WebCoreSupport/WebChromeClient.h:
1973         * WebCoreSupport/WebChromeClient.mm:
1974         (WebChromeClient::handleTelephoneNumberClick):
1975         (WebChromeClient::handleSelectionServiceClick):
1976         (WebChromeClient::hasRelevantSelectionServices):
1977         Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.
1978
1979         * WebCoreSupport/WebContextMenuClient.h:
1980         * WebCoreSupport/WebContextMenuClient.mm:
1981         (WebContextMenuClient::sharingServicePickerWillBeDestroyed):
1982         (WebContextMenuClient::pageForSharingServicePicker):
1983         (WebContextMenuClient::windowForSharingServicePicker):
1984         (WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
1985         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1986         (WebContextMenuClient::contextMenuForEvent):
1987         (WebContextMenuClient::screenRectForHitTestNode): Deleted.
1988         (WebContextMenuClient::renderedImageForControlledImage): Deleted.
1989         (WebContextMenuClient::clearSharingServicePickerController): Deleted.
1990         Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
1991         having WebSharingServicePickerController tightly bound to it.
1992         Make an NSItemProvider array when instantiating WebSharingServicePickerController
1993         instead of handing it data directly.
1994
1995         * WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
1996         * WebCoreSupport/WebSelectionServiceController.mm: Added.
1997         (WebSelectionServiceController::WebSelectionServiceController):
1998         Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
1999         for selection services.
2000
2001         (WebSelectionServiceController::handleSelectionServiceClick):
2002         Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.
2003
2004         (hasCompatibleServicesForItems):
2005         (WebSelectionServiceController::hasRelevantSelectionServices):
2006         Determine whether or not services are available.
2007
2008         (WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
2009         (WebSelectionServiceController::pageForSharingServicePicker):
2010         (WebSelectionServiceController::windowForSharingServicePicker):
2011         Implement the rest of the WebSharingServicePickerClient overrides.
2012
2013         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
2014         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
2015         These are only useful for image sharing services, so we don't need to
2016         implement them (WebContextMenuClient does, on the other hand).
2017
2018         * WebView/WebView.mm:
2019         (-[WebView _selectionServiceController]):
2020         * WebView/WebViewData.h:
2021         * WebView/WebViewData.mm:
2022         * WebView/WebViewInternal.h:
2023         Keep a WebSelectionServiceController.
2024
2025 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2026
2027         Improve debug description of WAKViews
2028         https://bugs.webkit.org/show_bug.cgi?id=137716
2029
2030         Reviewed by Simon Fraser.
2031
2032         * WebView/WebView.mm:
2033         (-[WebView _touchEventRegions]): Adding a comment.
2034
2035 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2036
2037         Addressing post-review comment.
2038         https://bugs.webkit.org/show_bug.cgi?id=137550
2039
2040         Unreviewed.
2041
2042         * WebView/WebHTMLView.mm:
2043         (fontNameForDescription):
2044         (-[WebHTMLView _addToStyle:fontA:fontB:]):
2045
2046 2014-10-14  Chris Dumez  <cdumez@apple.com>
2047
2048         Use is<>() / downcast<>() for RenderImage
2049         https://bugs.webkit.org/show_bug.cgi?id=137683
2050
2051         Reviewed by Mihnea Ovidenie.
2052
2053         Use is<>() / downcast<>() for RenderImage.
2054
2055         * Misc/WebNSPasteboardExtras.mm:
2056         (imageFromElement):
2057         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2058
2059 2014-10-10  Daniel Bates  <dabates@apple.com>
2060
2061         Remove unused classes WebRender{Node, Layer}
2062         https://bugs.webkit.org/show_bug.cgi?id=137628
2063
2064         Reviewed by Simon Fraser.
2065
2066         We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
2067         For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.
2068
2069         * Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list
2070         of excluded source files when building for iOS.
2071         * WebKit.exp: Remove symbol for WebRenderLayer.
2072         * WebKit.mac.exp: Remove symbol for WebRenderNode.
2073         * WebView/WebRenderLayer.h: Removed.
2074         * WebView/WebRenderLayer.mm: Removed.
2075         * WebView/WebRenderNode.h: Removed.
2076         * WebView/WebRenderNode.mm: Removed.
2077
2078 2014-10-10  Chris Dumez  <cdumez@apple.com>
2079
2080         Use is<>() / downcast<>() for RenderBoxModelObject
2081         https://bugs.webkit.org/show_bug.cgi?id=137587
2082
2083         Reviewed by Mihnea Ovidenie.
2084
2085         Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
2086         surrounding code.
2087
2088         * Plugins/WebBaseNetscapePluginView.mm:
2089         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
2090         * WebView/WebRenderLayer.mm:
2091         (-[WebRenderLayer initWithWebFrame:]):
2092
2093 2014-10-09  Dean Jackson  <dino@apple.com>
2094
2095         Remove ENABLE_CSS3_CONDITIONAL_RULES
2096         https://bugs.webkit.org/show_bug.cgi?id=137571
2097
2098         Reviewed by Simon Fraser.
2099
2100         * Configurations/FeatureDefines.xcconfig:
2101
2102 2014-10-09  Tim Horton  <timothy_horton@apple.com>
2103
2104         Add a WebKit1 preference for selection services
2105         https://bugs.webkit.org/show_bug.cgi?id=137498
2106         <rdar://problem/18572699>
2107
2108         Reviewed by Simon Fraser.
2109
2110         * WebView/WebPreferenceKeysPrivate.h:
2111         * WebView/WebPreferences.mm:
2112         (+[WebPreferences initialize]):
2113         (-[WebPreferences serviceControlsEnabled]):
2114         (-[WebPreferences setServiceControlsEnabled:]):
2115         * WebView/WebPreferencesPrivate.h:
2116         * WebView/WebView.mm:
2117         (-[WebView _preferencesChanged:]):
2118         Add and plumb the preference.
2119
2120 2014-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
2121
2122         Remove second-to-last client of WebFontCache
2123         https://bugs.webkit.org/show_bug.cgi?id=137550
2124
2125         Reviewed by Darin Adler.
2126
2127         Use FontCache::getCachedFontData() instead of WebFontCache.
2128
2129         * WebView/WebHTMLView.mm:
2130         (-[WebHTMLView _addToStyle:fontA:fontB:]):
2131
2132 2014-10-09  Chris Dumez  <cdumez@apple.com>
2133
2134         Use is<>() / downcast<>() for Widget subclasses
2135         https://bugs.webkit.org/show_bug.cgi?id=137549
2136
2137         Reviewed by Darin Adler.
2138
2139         Use is<>() / downcast<>() for Widget subclasses and clean up the
2140         surrounding code.
2141
2142         * WebView/WebRenderNode.mm:
2143         (copyRenderNode):
2144         * WebView/WebView.mm:
2145         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
2146
2147 2014-10-07  Christophe Dumez  <cdumez@apple.com>
2148
2149         Use is<>() / downcast<>() for RenderText / RenderTextFragment
2150         https://bugs.webkit.org/show_bug.cgi?id=137476
2151
2152         Reviewed by Darin Adler.
2153
2154         * WebView/WebRenderNode.mm:
2155         (copyRenderNode):
2156
2157 2014-10-06  Dan Bernstein  <mitz@apple.com>
2158
2159         Build fix.
2160
2161         * Misc/WebCache.mm:
2162         (+[WebCache imageForURL:]):
2163
2164 2014-10-06  Chris Dumez  <cdumez@apple.com>
2165
2166         Unreviewed build fix after r174333.
2167
2168         Forgot explicit WebCore:: namespace.
2169
2170         * Misc/WebCache.mm:
2171         (+[WebCache imageForURL:]):
2172
2173 2014-10-05  Christophe Dumez  <cdumez@apple.com>
2174
2175         Use is<>() / downcast<>() for CachedResource subclasses
2176         https://bugs.webkit.org/show_bug.cgi?id=137431
2177
2178         Reviewed by Benjamin Poulain.
2179
2180         Use is<>() / downcast<>() for CachedResource subclasses.
2181
2182         * Misc/WebCache.mm:
2183         (+[WebCache imageForURL:]):
2184
2185 2014-10-02  Daniel Bates  <dabates@apple.com>
2186
2187         Use version number 101000 instead of 10100 for OS X Yosemite
2188         https://bugs.webkit.org/show_bug.cgi?id=137372
2189
2190         Reviewed by Mark Rowe.
2191
2192         The version number for OS X Yosemite is 101000.
2193
2194         * WebView/WebView.mm:
2195         (-[WebView _preferencesChanged:]):
2196
2197 2014-10-02  Tim Horton  <timothy_horton@apple.com>
2198
2199         Move PageOverlay[Controller] to WebCore
2200         https://bugs.webkit.org/show_bug.cgi?id=137164
2201         <rdar://problem/18508258>
2202
2203         Reviewed by Anders Carlsson.
2204
2205         * WebCoreSupport/WebChromeClient.h:
2206         * WebCoreSupport/WebChromeClient.mm:
2207         (WebChromeClient::attachViewOverlayGraphicsLayer):
2208         Add an empty ChromeClient override.
2209
2210 2014-10-01  Christophe Dumez  <cdumez@apple.com>
2211
2212         Have is<>(T*) function do a null check on the pointer argument
2213         https://bugs.webkit.org/show_bug.cgi?id=137333
2214
2215         Reviewed by Gavin Barraclough.
2216
2217         Have is<>(T*) function do a null check on the argument instead of a
2218         simple assertion. This makes sense for 2 reasons:
2219         1. It is more consistent with downcast<>(T*), which will succeed even
2220            if the argument is a nullptr.
2221         2. It simplifies the code a bit as it gets rid of a lot of explicit
2222            null checks.
2223
2224         * WebCoreSupport/WebChromeClient.mm:
2225         (WebChromeClient::focusedElementChanged):
2226         * WebCoreSupport/WebEditorClient.mm:
2227         (WebEditorClient::textFieldDidBeginEditing):
2228         (WebEditorClient::textFieldDidEndEditing):
2229         (WebEditorClient::textDidChangeInTextField):
2230         (WebEditorClient::doTextFieldCommandFromEvent):
2231         (WebEditorClient::textWillBeDeletedInTextField):
2232         (WebEditorClient::textDidChangeInTextArea):
2233         * WebView/WebHTMLRepresentation.mm:
2234         (inputElementFromDOMElement):
2235         (searchForLabelsBeforeElement):
2236         * WebView/WebRenderLayer.mm:
2237         (+[WebRenderLayer nameForLayer:]):
2238
2239 2014-10-01  Mark Rowe  <mrowe@apple.com>
2240
2241         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
2242
2243         Reviewed by Dan Bernstein.
2244
2245         * Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite.
2246
2247 2014-09-30  Chris Dumez  <cdumez@apple.com>
2248
2249         Use is<>() / downcast<>() for Element
2250         https://bugs.webkit.org/show_bug.cgi?id=137241
2251
2252         Reviewed by Andreas Kling.
2253
2254         Use is<>() / downcast<>() for Element instead of isElementNode() /
2255         toElement().
2256
2257         * WebView/WebRenderLayer.mm:
2258         (+[WebRenderLayer nameForLayer:]):
2259
2260 2014-09-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2261
2262         Move ColorInputType class to std::unique_ptr
2263         https://bugs.webkit.org/show_bug.cgi?id=137173
2264
2265         Reviewed by Darin Adler.
2266
2267         Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr.
2268         Child classes follow this change as well.
2269
2270         * WebCoreSupport/WebChromeClient.h:
2271         * WebCoreSupport/WebChromeClient.mm:
2272         (WebChromeClient::createColorChooser):
2273
2274 2014-09-24  Christophe Dumez  <cdumez@apple.com>
2275
2276         Add initial is<>() / downcast<>() support for any type of Nodes
2277         https://bugs.webkit.org/show_bug.cgi?id=137056
2278
2279         Reviewed by Benjamin Poulain.
2280
2281         Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
2282         instead of isFormControlElement() / toHTMLFormControlElement().
2283
2284         * WebView/WebHTMLRepresentation.mm:
2285         (searchForLabelsBeforeElement):
2286
2287 2014-09-24  Christophe Dumez  <cdumez@apple.com>
2288
2289         Use is<HTML*Element>() instead of isHTML*Element() - Part 1
2290         https://bugs.webkit.org/show_bug.cgi?id=137068
2291
2292         Reviewed by Ryosuke Niwa.
2293
2294         Start using is<HTML*Element>() instead of isHTML*Element().
2295         Remaining usages will be updated in a follow-up patch to
2296         reduce the size of the change.
2297
2298         * WebCoreSupport/WebChromeClient.mm:
2299         (WebChromeClient::focusedElementChanged):
2300         * WebCoreSupport/WebEditorClient.mm:
2301         (WebEditorClient::textFieldDidBeginEditing):
2302         (WebEditorClient::textFieldDidEndEditing):
2303         (WebEditorClient::textDidChangeInTextField):
2304         (WebEditorClient::doTextFieldCommandFromEvent):
2305         (WebEditorClient::textWillBeDeletedInTextField):
2306         (WebEditorClient::textDidChangeInTextArea):
2307         * WebView/WebHTMLRepresentation.mm:
2308         (inputElementFromDOMElement):
2309
2310 2014-09-21  Timothy Hatcher  <timothy@apple.com>
2311
2312         Make the Web Inspector use a separate web process.
2313
2314         https://bugs.webkit.org/show_bug.cgi?id=135120
2315
2316         Reviewed by Anders Carlsson.
2317
2318         * WebCoreSupport/WebInspectorClient.h:
2319         * WebCoreSupport/WebInspectorClient.mm:
2320         (WebInspectorClient::WebInspectorClient):
2321         (WebInspectorClient::openInspectorFrontend):
2322         (WebInspectorClient::releaseFrontend):
2323         Own WebInspectorFrontendClient instead of moving it.
2324
2325 2014-09-23  Chris Dumez  <cdumez@apple.com>
2326
2327         Use downcast<HTML*Element>() instead of toHTML*Element()
2328         https://bugs.webkit.org/show_bug.cgi?id=137007
2329
2330         Reviewed by Benjamin Poulain.
2331
2332         Use downcast<HTML*Element>() instead of toHTML*Element().
2333
2334         * DOM/WebDOMOperations.mm:
2335         (-[DOMHTMLInputElement _setAutofilled:]):
2336         * WebCoreSupport/WebChromeClient.mm:
2337         (WebChromeClient::focusedElementChanged):
2338         * WebCoreSupport/WebEditorClient.mm:
2339         (WebEditorClient::textFieldDidBeginEditing):
2340         (WebEditorClient::textFieldDidEndEditing):
2341         (WebEditorClient::textDidChangeInTextField):
2342         (WebEditorClient::doTextFieldCommandFromEvent):
2343         (WebEditorClient::textWillBeDeletedInTextField):
2344         (WebEditorClient::textDidChangeInTextArea):
2345         * WebView/WebHTMLRepresentation.mm:
2346         (inputElementFromDOMElement):
2347
2348 2014-09-21  Chris Dumez  <cdumez@apple.com>
2349
2350         Generate Element casting helper functions
2351         https://bugs.webkit.org/show_bug.cgi?id=136839
2352
2353         Reviewed by Darin Adler.
2354
2355         Use JSXXX::toWrapped() instead of toXXX() function.
2356
2357         * DOM/WebDOMOperations.mm:
2358         * WebView/WebView.mm:
2359         (-[WebView _notificationIDForTesting:]):
2360
2361 2014-09-21  Joseph Pecoraro  <pecoraro@apple.com>
2362
2363         Leak: WebNotificationPrivate ObjC leaks seen on leaks bot
2364         https://bugs.webkit.org/show_bug.cgi?id=136972
2365
2366         Reviewed by Darin Adler.
2367
2368         * WebView/WebNotification.h:
2369         * WebView/WebNotification.mm:
2370         (-[WebNotification initWithCoreNotification:notificationID:]):
2371         Switch to RetainPtr and adopt into _private to ensure when we are
2372         deallocated that _private will get deallocated.
2373
2374 2014-09-19  Dean Jackson  <dino@apple.com>
2375
2376         Multithreaded WebGL is a bad idea - remove it
2377         https://bugs.webkit.org/show_bug.cgi?id=136964
2378         <rdar://problem/18399858>
2379
2380         Reviewed by Brent Fulgham.
2381
2382         Remove the setting to allow multithreaded WebGL.
2383
2384         * WebView/WebPreferenceKeysPrivate.h:
2385         * WebView/WebPreferences.mm:
2386         (+[WebPreferences initialize]):
2387         (-[WebPreferences multithreadedWebGLEnabled]): Deleted.
2388         (-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted.
2389         * WebView/WebPreferencesPrivate.h:
2390         * WebView/WebView.mm:
2391         (-[WebView _preferencesChanged:]):
2392
2393 2014-09-19  Daniel Bates  <dabates@apple.com>
2394
2395         Always assume internal SDK when building configuration Production
2396         https://bugs.webkit.org/show_bug.cgi?id=136925
2397         <rdar://problem/18362399>
2398
2399         Reviewed by Dan Bernstein.
2400
2401         As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
2402         and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.
2403
2404         * Configurations/Base.xcconfig:
2405
2406 2014-09-17  Daniel Bates  <dabates@apple.com>
2407
2408         Unreviewed, rolling out r173695.
2409
2410         Broke building third-party Legacy WebKit apps; will
2411         investigate offline
2412
2413         Reverted changeset:
2414
2415         "[iOS] Make WebCore build with public iOS SDK"
2416         https://bugs.webkit.org/show_bug.cgi?id=136487
2417         http://trac.webkit.org/changeset/173695
2418
2419 2014-09-17  Daniel Bates  <dabates@apple.com>
2420
2421         [iOS] Make WebCore build with public iOS SDK
2422         https://bugs.webkit.org/show_bug.cgi?id=136487
2423
2424         Reviewed by David Kilzer.
2425
2426         Update WebKit1 source files to include the wrapper SPI headers instead of the corresponding
2427         actual SPI header(s).
2428
2429         * DOM/WebDOMOperationsPrivate.h:
2430         * MigrateHeaders.make: Modified to only modify the include path of a "<WebCore/"-prefixed header
2431         file if its filename doesn't end in "SPI.h" as an alternative to having MigrateHeaders.make copy
2432         such files into the WebKit framework as private headers.
2433         * WebCoreSupport/WebFrameLoaderClient.mm:
2434         * WebInspector/WebNodeHighlight.mm:
2435         * WebView/WebIndicateLayer.mm:
2436         * WebView/WebRenderLayer.h:
2437         * WebView/WebView.mm:
2438
2439 2014-09-16  Daniel Bates  <dabates@apple.com>
2440
2441         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
2442         https://bugs.webkit.org/show_bug.cgi?id=136862
2443
2444         Reviewed by David Kilzer.
2445
2446         * Configurations/DebugRelease.xcconfig:
2447
2448 2014-09-16  Enrica Casucci  <enrica@apple.com>
2449
2450         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
2451         https://bugs.webkit.org/show_bug.cgi?id=136474
2452
2453         Reviewed by Benjamin Poulain.
2454
2455         This is the updated version of the patch that was landed in r173340.
2456         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
2457         and removes the assumption that EAffinity values match NSSelectionAffinity
2458         values. It also removes the includes in TextAffinity.h, creating the need to
2459         include explicitly the files when necessary.
2460
2461         * WebCoreSupport/WebEditorClient.h:
2462         (kit):
2463         (core):
2464
2465 2014-09-14  Daniel Bates  <dabates@apple.com>
2466
2467         [iOS] Attempt to fix the iOS build after <http://trac.webkit.org/changeset/173606>
2468         (https://bugs.webkit.org/show_bug.cgi?id=136789)
2469
2470         Substitute Node::countChildNodes() for Node::childNodeCount() in more places.
2471
2472         * WebView/WebFrame.mm:
2473         (-[WebFrame focusedNodeHasContent]):
2474
2475 2014-09-14  Chris Dumez  <cdumez@apple.com>
2476
2477         Rename Node::childNodeCount() to countChildNodes() and avoid inefficient uses
2478         https://bugs.webkit.org/show_bug.cgi?id=136789
2479
2480         Reviewed by Darin Adler.
2481
2482         Rename childNodeCount() to countChildNodes().
2483
2484         * WebView/WebHTMLView.mm:
2485         (-[WebHTMLView attributedString]):
2486
2487 2014-09-10  Jon Honeycutt  <jhoneycutt@apple.com>
2488
2489         Re-add the request autocomplete feature
2490
2491         <https://bugs.webkit.org/show_bug.cgi?id=136730>
2492
2493         This feature was rolled out in r148731 because it was only used by
2494         Chromium. As we consider supporting this feature, roll it back in, but
2495         leave it disabled.
2496
2497         This rolls out r148731 (which removed the feature) with small changes
2498         needed to make the code build in ToT, to match modern style, to make
2499         the tests run, and to remove unused code.
2500
2501         Reviewed by Andy Estes.
2502
2503         * Configurations/FeatureDefines.xcconfig:
2504         * WebCoreSupport/WebFrameLoaderClient.h:
2505
2506 2014-09-12  Commit Queue  <commit-queue@webkit.org>
2507
2508         Unreviewed, rolling out r173575.
2509         https://bugs.webkit.org/show_bug.cgi?id=136790
2510
2511         Failing tests (Requested by enrica on #webkit).
2512
2513         Reverted changeset:
2514
2515         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
2516         https://bugs.webkit.org/show_bug.cgi?id=136474
2517         http://trac.webkit.org/changeset/173575
2518
2519 2014-09-12  Enrica Casucci  <enrica@apple.com>
2520
2521         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
2522         https://bugs.webkit.org/show_bug.cgi?id=136474
2523
2524         Reviewed by Benjamin Poulain.
2525
2526         This is the updated version of the patch that was landed in r173340.
2527         I changed the use of IntPoint to FloatPoint since it was causing tests
2528         to fail.
2529         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
2530         and removes the assumption that EAffinity values match NSSelectionAffinity
2531         values. It also removes the includes in TextAffinity.h, creating the need to
2532         include explicitly the files when necessary. It also removes the unnecessary
2533         use of platform specific types, replacing them with WebCore types.
2534
2535         * WebCoreSupport/WebEditorClient.h:
2536         (kit):
2537         (core):
2538         * WebView/WebFrameView.mm:
2539         (-[WebFrameView _scrollToBeginningOfDocument]):
2540         (-[WebFrameView _scrollToEndOfDocument]):
2541
2542 2014-09-11  Bear Travis  <betravis@adobe.com>
2543
2544         [CSS Font Loading] Enable CSS Font Loading on Mac
2545         https://bugs.webkit.org/show_bug.cgi?id=135473
2546
2547         Reviewed by Antti Koivisto.
2548
2549         Enable CSS Font Loading in FeatureDefines.
2550
2551         * Configurations/FeatureDefines.xcconfig:
2552
2553 2014-09-11  Beth Dakin  <bdakin@apple.com>
2554
2555         Support rubber-banding in sub-frames
2556         https://bugs.webkit.org/show_bug.cgi?id=136726
2557         -and corresponding-
2558         rdar://problem/10011924
2559
2560         Reviewed by Tim Horton.
2561
2562         rubberBandingForOverflowScrollEnabled is re-named to
2563         rubberBandingForSubScrollableRegionsEnabled
2564         * WebView/WebView.mm:
2565         (-[WebView _preferencesChanged:]):
2566
2567 2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
2568
2569         Disable the "unreachable-code" warning
2570         https://bugs.webkit.org/show_bug.cgi?id=136677
2571
2572         Reviewed by Darin Adler.
2573
2574         * Configurations/Base.xcconfig:
2575
2576 2014-09-08  Maciej Stachowiak  <mjs@apple.com>
2577
2578         Fix 32-bit Mac build for new warnings
2579         https://bugs.webkit.org/show_bug.cgi?id=136624
2580
2581         Reviewed by Darin Adler.
2582         
2583         (Jessie already fixed this but my version with typedefs seems a tiny bit cleaner.)
2584
2585         * Carbon/HIViewAdapter.m:
2586         (+[HIViewAdapter bindHIViewToNSView:nsView:]): Need to use explicit casting now.
2587
2588 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2589
2590         Remove FILTERS flag
2591         https://bugs.webkit.org/show_bug.cgi?id=136571
2592
2593         Reviewed by Darin Adler.
2594
2595         * Configurations/FeatureDefines.xcconfig:
2596
2597 2014-09-08  Jessie Berlin  <jberlin@apple.com>
2598
2599         32-bit build fix after r173364.
2600
2601         * Carbon/HIViewAdapter.m:
2602         (+[HIViewAdapter bindHIViewToNSView:nsView:]):
2603
2604 2014-09-08  Dan Bernstein  <mitz@apple.com>
2605
2606         Build fix.
2607
2608         Added back SPI that is still in use.
2609
2610         * Misc/WebNSURLExtras.h:
2611         * Misc/WebNSURLExtras.mm:
2612         (-[NSURL _webkit_URLByRemovingFragment]):
2613
2614 2014-09-08  Dan Bernstein  <mitz@apple.com>
2615
2616         iOS Simulator build fix.
2617
2618         * Misc/WebKitSystemBits.m:
2619         (WebMemorySize):
2620
2621 2014-09-07  Darin Adler  <darin@apple.com>
2622
2623         Fix build failure seen on Mountain Lion buildbot.
2624
2625         * Misc/WebNSDataExtras.h: Make WEB_GUESS_MIME_TYPE_PEEK_LENGTH an unsigned instead
2626         of an int, to avoid warning about mixing signs.
2627
2628 2014-09-06  Darin Adler  <darin@apple.com>
2629
2630         Make updates suggested by new version of Xcode
2631         https://bugs.webkit.org/show_bug.cgi?id=136603
2632
2633         Reviewed by Mark Rowe.
2634
2635         * Configurations/Base.xcconfig: Added CLANG_WARN_UNREACHABLE_CODE, COMBINE_HIDPI_IMAGES,
2636         and ENABLE_STRICT_OBJC_MSGSEND as suggested by Xcode upgrade check.
2637
2638         * History/WebURLsWithTitles.m:
2639         (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): Use NSUInteger instead of
2640         unsigned for correctness, and to quiet the 32-to-64-bit compiler warning (which is
2641         not turned on because it gives us too many false positives).
2642         * Misc/WebElementDictionary.mm:
2643         (-[WebElementDictionary objectForKey:]): Ditto.
2644         * Misc/WebNSDataExtras.m:
2645         (-[NSData _webkit_guessedMIMETypeForXML]): Ditto.
2646         (-[NSData _webkit_guessedMIMEType]): Ditto.
2647         (-[NSData _webkit_parseRFC822HeaderFields]): Ditto.
2648         (-[NSData _web_locationAfterFirstBlankLine]): Ditto.
2649
2650         * Misc/WebNSURLExtras.h: Removed unused _web_URLWithLowercasedScheme, _web_hostData,
2651         _webkit_URLByRemovingFragment, _webkit_URLByRemovingResourceSpecifier, _webkit_isFTPDirectoryURL,
2652         _webkit_shouldLoadAsEmptyDocument, _web_hostNameNeedsDecodingWithRange:,
2653         _web_hostNameNeedsEncodingWithRange:, _web_decodeHostNameWithRange:, _web_encodeHostNameWithRange:,
2654         and _webkit_URLFragment methods.
2655
2656         * Misc/WebNSURLExtras.mm:
2657         (-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): Deleted.
2658         (-[NSURL _webkit_URLByRemovingFragment]): Deleted.
2659         (-[NSURL _webkit_URLByRemovingResourceSpecifier]): Deleted.
2660         (-[NSURL _webkit_isFTPDirectoryURL]): Deleted.
2661         (-[NSURL _webkit_shouldLoadAsEmptyDocument]): Deleted.
2662         (-[NSURL _web_URLWithLowercasedScheme]): Deleted.
2663         (-[NSString _webkit_isFTPDirectoryURL]): Deleted.
2664         (-[NSString _web_hostNameNeedsDecodingWithRange:]): Deleted.
2665         (-[NSString _web_hostNameNeedsEncodingWithRange:]): Deleted.
2666         (-[NSString _web_decodeHostNameWithRange:]): Deleted.
2667         (-[NSString _web_encodeHostNameWithRange:]): Deleted.
2668         (-[NSString _webkit_URLFragment]): Deleted.
2669
2670         * Plugins/WebPluginDatabase.mm:
2671         (-[WebPluginDatabase removePluginInstanceViewsFor:]): Use a modern for loop
2672         to iterate an array instead of a loop using the type "unsigned int".
2673
2674         * WebCoreSupport/WebOpenPanelResultListener.mm:
2675         (-[WebOpenPanelResultListener chooseFilenames:]): Use NSUInteger instead of int.
2676
2677         * WebView/WebDelegateImplementationCaching.mm:
2678         (CallDelegate): Use wtfCallIMP in one overload that was instead just calling the
2679         directly without a proper type for the function pointer. This might have been causing
2680         an actual problem on 64-bit systems, and it was different from all the other CallDelegate
2681         functions that were already doing this correctly.
2682
2683         * WebView/WebTextCompletionController.mm:
2684         (-[WebTextCompletionController _placePopupWindow:]): Use NSUInteger instead of int.
2685
2686 2014-09-06  Brian J. Burg  <burg@cs.washington.edu>
2687
2688         Web Inspector: convert DockSide to an enum class
2689         https://bugs.webkit.org/show_bug.cgi?id=136601
2690
2691         Reviewed by Timothy Hatcher.
2692
2693         * WebCoreSupport/WebInspectorClient.mm:
2694         (WebInspectorFrontendClient::frontendLoaded):
2695         (-[WebInspectorWindowController attachWindow:]):
2696         (-[WebInspectorWindowController attach]):
2697         (-[WebInspectorWindowController detach]):
2698         * WebInspector/WebInspectorFrontend.mm:
2699         (-[WebInspectorFrontend attach]):
2700
2701 2014-09-05  Commit Queue  <commit-queue@webkit.org>
2702
2703         Unreviewed, rolling out r173340 and r173342.
2704         https://bugs.webkit.org/show_bug.cgi?id=136596
2705
2706         Broke many tests (Requested by ap on #webkit).
2707
2708         Reverted changesets:
2709
2710         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
2711         https://bugs.webkit.org/show_bug.cgi?id=136474
2712         http://trac.webkit.org/changeset/173340
2713
2714         "Build fix after r173340."
2715         http://trac.webkit.org/changeset/173342
2716
2717 2014-09-05  Enrica Casucci  <enrica@apple.com>
2718
2719         Build fix after r173340.
2720
2721         * WebCoreSupport/WebEditorClient.h:
2722         (kit):
2723         (core):
2724
2725 2014-09-05  Enrica Casucci  <enrica@apple.com>
2726
2727         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
2728         https://bugs.webkit.org/show_bug.cgi?id=136474
2729
2730         Reviewed by Benjamin Poulain.
2731
2732         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
2733         and removes the assumption that EAffinity values match NSSelectionAffinity
2734         values. It also removes the includes in TextAffinity.h, creating the need to
2735         include explicitly the files when necessary. It also removes the unnecessary
2736         use of platform specific types, replacing them with WebCore types.
2737
2738         * WebCoreSupport/WebEditorClient.h: Added kit and core for EAffinity.
2739         * WebView/WebFrameView.mm:
2740         (-[WebFrameView _scrollToBeginningOfDocument]):
2741         (-[WebFrameView _scrollToEndOfDocument]):
2742
2743 2014-09-05  Daniel Bates  <dabates@apple.com>
2744
2745         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
2746         (https://bugs.webkit.org/show_bug.cgi?id=136564)
2747
2748         Move #endif inside -viewDidMoveToWindow up one line such that the closing brace ('}') is after it.
2749
2750         * WebView/WebHTMLView.mm:
2751         (-[WebHTMLView viewDidMoveToWindow]):
2752
2753 2014-09-05  Daniel Bates  <dabates@apple.com>
2754
2755         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
2756         (https://bugs.webkit.org/show_bug.cgi?id=136564)
2757
2758         Add !PLATFORM(IOS)-guard in -viewDidMoveToWindow around code that references WebHTMLViewPrivate.flagsChangedEventMonitor.
2759         The instance variable WebHTMLViewPrivate.flagsChangedEventMonitor is guarded by !PLATFORM(IOS).
2760
2761         * WebView/WebHTMLView.mm:
2762         (-[WebHTMLView viewDidMoveToWindow]):
2763
2764 2014-09-05  Daniel Bates  <dabates@apple.com>
2765
2766         [iOS] Fix the iOS build after <http://trac.webkit.org/changeset/173309>
2767         (https://bugs.webkit.org/show_bug.cgi?id=136564)
2768
2769         Include more code inside the !PLATFORM(IOS)-guarded section in -setDataSource:.
2770
2771         * WebView/WebHTMLView.mm:
2772         (-[WebHTMLView setDataSource:]):
2773
2774 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
2775
2776         Use tracking areas instead of (SPI) mouse moved notifications, and follow flags changes with an event monitor
2777         https://bugs.webkit.org/show_bug.cgi?id=136564
2778
2779         Reviewed by Dan Bernstein.
2780         
2781         WebKit1 depended on mouse moved event notifications to track mouse
2782         moves, and on being specially called by Safari to track flags
2783         changes. WebKit2 does both these things better - it uses a tracking area
2784         and event monitors. Copy those approaches.
2785
2786         * WebKit.order: Remove reference to obsolete call.
2787         * WebView/WebHTMLView.mm:
2788         (-[WebHTMLViewPrivate dealloc]): No need to deallocate tracking
2789         area, since we now just always have one.
2790         (-[WebHTMLViewPrivate clear]): ditto
2791         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
2792         New method that posts a fake mouse move event in response to
2793         a flags change event, for use by the event monitor.
2794         (+[WebHTMLView _postFlagsChangedEvent:]): Empty this old call,
2795         still kept around for benefit of older Safari.
2796         (-[WebHTMLView _updateMouseoverWithEvent:]): Handle Dashboard's
2797         special mouseover mode (previously handled in a weird way).
2798         (-[WebHTMLView close]): No more need to mess with mouse moved observer.
2799         (-[WebHTMLView viewWillMoveToWindow:]): ditto
2800         (-[WebHTMLView viewDidMoveToWindow]): ditto; but now hook up a flags
2801         changed monitor.
2802         (-[WebHTMLView windowDidBecomeKey:]): No need to handle non-key window
2803         tracking area or mouse moved observer.
2804         (-[WebHTMLView windowDidResignKey:]): ditto
2805         (-[WebHTMLView windowWillOrderOnScreen:]): No need to mess with mouse
2806         moved observer.
2807         (-[WebHTMLView windowWillOrderOffScreen:]): ditto
2808         (-[WebHTMLView mouseMoved:]): Converted from the old mouseMovedNotification:
2809         (-[WebHTMLView setDataSource:]): Change if around body to early return. Hook
2810         up tracking area - we have to do it here, because before this point, the
2811         WebHTMLView does not know its WebView, which is where dashboard settings
2812         live.
2813         (-[WebHTMLView _removeMouseMovedObserverUnconditionally]): Deleted.
2814         (-[WebHTMLView addMouseMovedObserver]): Deleted.
2815         (-[WebHTMLView removeMouseMovedObserver]): Deleted.
2816
2817 2014-09-04  Pratik Solanki  <psolanki@apple.com>
2818
2819         Bring back [WebPreferences setDiskImageCacheEnabled:] for backwards compatibility
2820         https://bugs.webkit.org/show_bug.cgi?id=136560
2821
2822         Reviewed by Joseph Pecoraro.
2823
2824         I removed the disk image caching code in r173265. However, we still have clients that call
2825         setDiskImageCacheEnabled. Add in a stub method until we can wean the clients off this call.
2826
2827         * WebView/WebPreferences.mm:
2828         (-[WebPreferences setDiskImageCacheEnabled:]):
2829         * WebView/WebPreferencesPrivate.h:
2830
2831 2014-09-03  Andy Estes  <aestes@apple.com>
2832
2833         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
2834         https://bugs.webkit.org/show_bug.cgi?id=136521
2835
2836         Reviewed by Anders Carlsson.
2837
2838         Taught MigrateHeaders.make to remove WEBCORE_EXPORT from headers using this sed expression:
2839
2840             s/(^ *)WEBCORE_EXPORT /\1/g
2841
2842         This removes WEBCORE_EXPORT and a single following space character but preserves preceeding spaces.
2843
2844         * MigrateHeaders.make:
2845
2846 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
2847
2848         Remove WebCoreSystemInterface glue for otherwise unused WKSI calls
2849         https://bugs.webkit.org/show_bug.cgi?id=136527
2850
2851         Reviewed by Alexey Proskuryakov.
2852
2853         * WebCoreSupport/WebSystemInterface.mm:
2854         (InitWebCoreSystemInterface):
2855
2856 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2857
2858         Remove CSS_FILTERS flag
2859         https://bugs.webkit.org/show_bug.cgi?id=136529
2860
2861         Reviewed by Dirk Schulze.
2862
2863         * Configurations/FeatureDefines.xcconfig:
2864
2865 2014-09-04  Pratik Solanki  <psolanki@apple.com>
2866
2867         Remove iOS specific disk image cache
2868         https://bugs.webkit.org/show_bug.cgi?id=136517
2869
2870         Reviewed by Antti Koivisto.
2871
2872         Disk image cache code unnecessarily complicates SharedBuffer implementation. We can remove
2873         this now since we don't enable it in WebKit2 on iOS.
2874
2875         * Misc/WebCache.mm:
2876         (+[WebCache statistics]):
2877         * WebView/WebDataSource.mm:
2878         (-[WebDataSource _setAllowToBeMemoryMapped]):
2879         (-[WebDataSource setDataSourceDelegate:]):
2880         (-[WebDataSource dataSourceDelegate]):
2881         (-[WebDataSource dealloc]):
2882         (BufferMemoryMapped): Deleted.
2883         * WebView/WebPreferenceKeysPrivate.h:
2884         * WebView/WebPreferences.mm:
2885         (+[WebPreferences initialize]):
2886         (-[WebPreferences diskImageCacheEnabled]): Deleted.
2887         (-[WebPreferences setDiskImageCacheEnabled:]): Deleted.
2888         (-[WebPreferences diskImageCacheMinimumImageSize]): Deleted.
2889         (-[WebPreferences setDiskImageCacheMinimumImageSize:]): Deleted.
2890         (-[WebPreferences diskImageCacheMaximumCacheSize]): Deleted.
2891         (-[WebPreferences setDiskImageCacheMaximumCacheSize:]): Deleted.
2892         (-[WebPreferences _diskImageCacheSavedCacheDirectory]): Deleted.
2893         (-[WebPreferences _setDiskImageCacheSavedCacheDirectory:]): Deleted.
2894         * WebView/WebPreferencesPrivate.h:
2895         * WebView/WebView.mm:
2896         (-[WebView _commonInitializationWithFrameName:groupName:]):
2897         (+[WebView _handleMemoryWarning]):
2898         (-[WebView _preferencesChanged:]):
2899
2900 2014-09-04  Daniel Bates  <dabates@apple.com>
2901
2902         [iOS] Make iOS build when ENABLE_TOUCH_EVENT and ENABLE_IOS_TOUCH_EVENTS disabled
2903         https://bugs.webkit.org/show_bug.cgi?id=136494
2904
2905         Reviewed by Andy Estes.
2906
2907         * MigrateHeaders.make: Migrate header WebEventRegion.h only when ENABLE_IOS_TOUCH_EVENTS is defined.
2908         * WebView/WebView.mm: Substitute ENABLE(IOS_TOUCH_EVENTS) for ENABLE(TOUCH_EVENTS).
2909
2910 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
2911
2912         Web Inspector: fix prefixes for subclasses of JSC::ConsoleClient
2913         https://bugs.webkit.org/show_bug.cgi?id=136476
2914
2915         Reviewed by Timothy Hatcher.
2916
2917         * Misc/WebCoreStatistics.mm:
2918         (+[WebCoreStatistics shouldPrintExceptions]):
2919         (+[WebCoreStatistics setShouldPrintExceptions:]):
2920
2921 2014-09-03  Enrica Casucci  <enrica@apple.com>
2922
2923         Remove PLATFORM(IOS) from WebCore/editing (Part 1).
2924         https://bugs.webkit.org/show_bug.cgi?id=136474
2925
2926         Reviewed by Tim Horton.
2927
2928         * WebCoreSupport/WebEditorClient.mm:
2929         (undoNameForEditAction):
2930
2931 2014-09-02  Maciej Stachowiak  <mjs@apple.com>
2932
2933         Clean up naming for and slightly refactor legacy video fullscreen support
2934         https://bugs.webkit.org/show_bug.cgi?id=136446
2935
2936         Reviewed by Jer Noble.
2937
2938         Key changes:
2939         supportsFullscreenForNode(Node*) --> supportsVideoFullscreen()
2940         enterFullscreenForNode(Node*) --> enterVideoFullscreenForVideoElement(HTMLVideoElement*)
2941         exitFullscreenForNode(Node*) --> exitVideoFullscreen()
2942         
2943         The old versions had unnecessary parameters, did not clearly distinguish their purpose
2944         from enterFullscreenForElement and friends, and wrongly claimed generality to all Nodes.
2945         Also changed many other places to use HTMLVideoElement* instead of Node* or 
2946         HTMLMediaElement* when they were in fact only used for video elements and would only
2947         work for such.
2948
2949         * WebCoreSupport/WebChromeClient.h:
2950         * WebCoreSupport/WebChromeClient.mm:
2951         (WebChromeClient::supportsVideoFullscreen): Adjust for main refactoring.
2952         Also no more need to check for video elementness.
2953         (WebChromeClient::enterVideoFullscreenForVideoElement): Adjust for main refactoring.
2954         (WebChromeClient::exitVideoFullscreen): ditto
2955         * WebView/WebView.mm:
2956         (-[WebView _enterVideoFullscreenForVideoElement:]): Adjust for main
2957         refactoring.
2958         (-[WebView _exitVideoFullscreen]): ditto
2959         (-[WebView _close]): ditto
2960         * WebView/WebViewInternal.h:
2961
2962 2014-09-03  Dan Bernstein  <mitz@apple.com>
2963
2964         Get rid of HIGH_DPI_CANVAS leftovers
2965         https://bugs.webkit.org/show_bug.cgi?id=136491
2966
2967         Reviewed by Benjamin Poulain.
2968
2969         * Configurations/FeatureDefines.xcconfig: Removed definition of ENABLE_HIGH_DPI_CANVAS
2970         and removed it from FEATURE_DEFINES.
2971
2972 2014-08-31  Tim Horton  <timothy_horton@apple.com>
2973
2974         Remove unnecessary (and unnecessarily iOS-specific) setStrokeAndFillColor
2975         https://bugs.webkit.org/show_bug.cgi?id=136416
2976
2977         Reviewed by Dan Bernstein.
2978
2979         * WebView/WebFrameView.mm:
2980         (-[WebFrameView drawRect:]):
2981         We only end up filling, so only set the fill color.
2982
2983 2014-08-26  Maciej Stachowiak  <mjs@apple.com>
2984
2985         Use RetainPtr::autorelease in some places where it seems appropriate
2986         https://bugs.webkit.org/show_bug.cgi?id=136280
2987
2988         Reviewed by Darin Adler.
2989
2990         * WebView/WebHTMLView.mm:
2991         (imageFromRect): Use RetainPtr in this function.
2992         * WebView/WebPDFRepresentation.mm:
2993         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use RetainPtr
2994         in this method.
2995
2996 2014-08-29  Csaba Osztrogonác  <ossy@webkit.org>
2997
2998         Unreviwed, remove empty directories.
2999
3000         * ForwardingHeaders/wtf: Removed.
3001
3002 2014-08-27  Zalan Bujtas  <zalan@apple.com>
3003
3004         Subpixel layout: Rename LayoutRect's device pixel snapping functions.
3005         https://bugs.webkit.org/show_bug.cgi?id=136319
3006
3007         Reviewed by Simon Fraser.
3008
3009         From pixelSnappedForPainting() to snapRectToDevicePixels() and 
3010         pixelSnappedIntRect*() to snappedIntRect*().
3011
3012         No change in functionality.
3013
3014         * WebView/WebView.mm:
3015         (-[WebView _dashboardRegions]):
3016         (-[WebView trackedRepaintRects]):
3017
3018 2014-08-25  Maciej Stachowiak  <mjs@apple.com>
3019
3020         Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API
3021         https://bugs.webkit.org/show_bug.cgi?id=136082
3022
3023         Reviewed by Alexey Proskuryakov.
3024
3025         * Plugins/Hosted/NetscapePluginHostManager.mm:
3026         (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current
3027         localization name using WebCore helper instead of SPI.
3028         * Plugins/WebBasePluginPackage.mm: Fixed the include style for this 
3029         file.
3030         (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current
3031         localization name using WebCore helper instead of SPI.
3032         (+[WebBasePluginPackage preferredLocalizationName]): Deleted. This
3033         helper no longer pulls its weight.
3034         * WebCoreSupport/WebSystemInterface.mm: 
3035         (InitWebCoreSystemInterface): Remove mention of
3036         WKCopyCFLocalizationPreferredName.
3037         * WebKit.order: ditto
3038
3039 2014-08-25  Daniel Bates  <dabates@apple.com>
3040
3041         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/172889>
3042         (https://bugs.webkit.org/show_bug.cgi?id=109658)
3043
3044         Substitute GraphicsLayer::setContentsToPlatformLayer(..., GraphicsLayer::ContentsLayerForMedia)
3045         for GraphicsLayer::setContentsToMedia(...) because the latter was removed in <http://trac.webkit.org/changeset/172889>.
3046
3047         * WebView/WebView.mm:
3048         (-[WebView _setMediaLayer:forPluginView:]):
3049
3050 2014-08-22  Commit Queue  <commit-queue@webkit.org>
3051
3052         Unreviewed, rolling out r172866.
3053         https://bugs.webkit.org/show_bug.cgi?id=136177
3054
3055         Broke iOS build (Requested by othermaciej on #webkit).
3056
3057         Reverted changeset:
3058
3059         "Replace use of WKCopyCFLocalizationPreferredName with
3060         NSLocale public API"
3061         https://bugs.webkit.org/show_bug.cgi?id=136082
3062         http://trac.webkit.org/changeset/172866
3063
3064 2014-08-22  Simon Fraser  <simon.fraser@apple.com>
3065
3066         Implement paint flashing in the WK1 InspectorOverlay page
3067         https://bugs.webkit.org/show_bug.cgi?id=136138
3068
3069         Reviewed by Sam Weinig, Joseph Pecoraro.
3070
3071         Implement paint flashing for the WebKit1 InspectorOverlay via a second canvas in the overlay page.
3072         We avoid allocating backing store for this canvas until we have paint rects.
3073         
3074         Because this overlay page is weird and doesn't know how to paint itself, InspectorOverlay manages
3075         an array of rects, and pushes them to the page when they change, before forcing a paint.
3076         
3077         Because iOS doesn't use the InspectorOverlay page, stub out setShowPaintRects on its
3078         WebKit WebInspectorClient, but don't yet implement paint flashing there.
3079
3080         * WebCoreSupport/WebInspectorClient.h:
3081         * WebCoreSupport/WebInspectorClient.mm:
3082         (WebInspectorClient::WebInspectorClient):
3083
3084 2014-08-20  Maciej Stachowiak  <mjs@apple.com>
3085
3086         Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API
3087         https://bugs.webkit.org/show_bug.cgi?id=136082
3088
3089         Reviewed by Alexey Proskuryakov.
3090
3091         * Plugins/Hosted/NetscapePluginHostManager.mm:
3092         (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current
3093         localization name using WebCore helper instead of SPI.
3094         * Plugins/WebBasePluginPackage.mm: Fixed the include style for this 
3095         file.
3096         (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current
3097         localization name using WebCore helper instead of SPI.
3098         (+[WebBasePluginPackage preferredLocalizationName]): Deleted. This
3099         helper no longer pulls its weight.
3100         * WebCoreSupport/WebSystemInterface.mm: 
3101         (InitWebCoreSystemInterface): Remove mention of
3102         WKCopyCFLocalizationPreferredName.
3103         * WebKit.order: ditto
3104
3105 2014-08-22  Daniel Bates  <dabates@apple.com>
3106
3107         [iOS] Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, and temporarily disable ENABLE_TOUCH_EVENTS
3108         and ENABLE_XSLT when building with the iOS public SDK
3109         https://bugs.webkit.org/show_bug.cgi?id=135945
3110
3111         Reviewed by Andy Estes.
3112
3113         * Configurations/FeatureDefines.xcconfig: Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, ENABLE_TOUCH_EVENTS
3114         and ENABLE_XSLT when building with the public SDK.
3115         * MigrateHeaders.make: Conditionally migrate headers for touch and gesture events.
3116
3117 2014-08-22  Jon Lee  <jonlee@apple.com>
3118
3119         Fix iOS build due to r172832 and move RUBBER_BANDING out of FeatureDefines.h
3120         https://bugs.webkit.org/show_bug.cgi?id=136157
3121
3122         Reviewed by Simon Fraser.
3123
3124         * Configurations/FeatureDefines.xcconfig: Add ENABLE(RUBBER_BANDING).
3125         * WebView/WebView.mm:
3126         (-[WebView _preferencesChanged:]): Wrap in ENABLE(RUBBER_BANDING).
3127
3128 2014-08-21  Zalan Bujtas  <zalan@apple.com>
3129
3130         Enable SATURATED_LAYOUT_ARITHMETIC.
3131         https://bugs.webkit.org/show_bug.cgi?id=136106
3132
3133         Reviewed by Simon Fraser.
3134
3135         SATURATED_LAYOUT_ARITHMETIC protects LayoutUnit against arithmetic overflow.
3136         (No measurable performance regression on Mac.)
3137
3138         * Configurations/FeatureDefines.xcconfig:
3139
3140 2014-08-21  Beth Dakin  <bdakin@apple.com>
3141
3142         overflow:scroll elements should support rubber-banding
3143         https://bugs.webkit.org/show_bug.cgi?id=91655
3144
3145         Reviewed by Sam Weinig and Darin Adler.
3146
3147         Disable rubber-banding in overflow areas for now.
3148         * WebView/WebView.mm:
3149         (-[WebView _preferencesChanged:]):
3150
3151 2014-08-19  Pratik Solanki  <psolanki@apple.com>
3152
3153         Remove PurgeableBuffer since it is not very useful any more
3154         https://bugs.webkit.org/show_bug.cgi?id=135939
3155
3156         Reviewed by Andreas Kling.
3157
3158         * Misc/WebCache.mm:
3159         (+[WebCache statistics]):
3160
3161 2014-08-19  Zalan Bujtas  <zalan@apple.com>
3162
3163         Remove ENABLE(SUBPIXEL_LAYOUT).
3164         https://bugs.webkit.org/show_bug.cgi?id=136077
3165
3166         Reviewed by Simon Fraser.
3167
3168         Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.
3169
3170         * Configurations/FeatureDefines.xcconfig:
3171
3172 2014-08-18  Maciej Stachowiak  <mjs@apple.com>
3173
3174         Use NSURLFileTypeMappings directly instead of depending on WebKitSystemInterface wrappers for it
3175         https://bugs.webkit.org/show_bug.cgi?id=136035
3176
3177         Reviewed by Dan Bernstein.
3178
3179         * Misc/WebNSViewExtras.m:
3180         (-[NSView _web_DragImageForElement:rect:event:pasteboard:source:offset:]): Remove comment
3181         reference to obsolete WKSI function.
3182         * WebCoreSupport/WebSystemInterface.mm:
3183         (InitWebCoreSystemInterface): Don't initialize the no-longer-used WKGetExtensionsForMIMEType,
3184         WKGetPreferredExtensionForMIMEType, or WKGetMIMETypeForExtension
3185         * Plugins/WebPluginDatabase.mm:
3186         (-[WebPluginDatabase pluginForExtension:]): Include SPI header from WebCore; use
3187         NSURLFileTypeMappings directly instead of via WKSI wrapper.
3188         * WebCoreSupport/WebFrameLoaderClient.mm:
3189         (WebFrameLoaderClient::objectContentType): ditto
3190         * WebView/WebHTMLView.mm:
3191         (-[WebHTMLView _imageExistsAtPaths:]): ditto
3192         * WebView/WebView.mm:
3193         (+[WebView _supportedFileExtensions]): ditto
3194         (+[WebView suggestedFileExtensionForMIMEType:]): ditto
3195         (+[WebView _MIMETypeForFile:]): ditto
3196
3197 2014-08-18  Commit Queue  <commit-queue@webkit.org>
3198
3199         Unreviewed, rolling out r172736.
3200         https://bugs.webkit.org/show_bug.cgi?id=136060
3201
3202         Caused 14% PLT regressions (Requested by rniwa on #webkit).
3203
3204         Reverted changeset:
3205
3206         "Remove PurgeableBuffer since it is not very useful any more"
3207         https://bugs.webkit.org/show_bug.cgi?id=135939
3208         http://trac.webkit.org/changeset/172736
3209
3210 2014-08-18  Pratik Solanki  <psolanki@apple.com>
3211
3212         Remove PurgeableBuffer since it is not very useful any more
3213         https://bugs.webkit.org/show_bug.cgi?id=135939
3214
3215         Reviewed by Geoffrey Garen.
3216
3217         * Misc/WebCache.mm:
3218         (+[WebCache statistics]):
3219
3220 2014-08-18  Andy Estes  <aestes@apple.com>
3221
3222         REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
3223         https://bugs.webkit.org/show_bug.cgi?id=136010
3224
3225         Reviewed by Darin Adler.
3226
3227         * Misc/WebKitVersionChecks.h: Removed WEBKIT_FIRST_VERSION_WITH_NAVIGATION_URL_VALIDATION.
3228         * WebView/WebPDFView.mm:
3229         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Passed AllowNavigationToInvalidURL::Yes to FrameLoader::loadFrameRequest.
3230         * WebView/WebView.mm:
3231         (-[WebView _preferencesChanged:]): Reverted the linked-on-or-after check added in r170120 since it's no longer necessary.
3232
3233 2014-08-18  Andy Estes  <aestes@apple.com>
3234
3235         Revert r172697.
3236
3237         It made several webarchive layout tests flaky and didn't have the correct behavior for non-quick redirects.
3238
3239         * Misc/WebKitVersionChecks.h:
3240         * WebView/WebView.mm:
3241         (-[WebView _preferencesChanged:]):
3242
3243 2014-08-15  Andy Estes  <aestes@apple.com>
3244
3245         REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
3246         https://bugs.webkit.org/show_bug.cgi?id=136010
3247
3248         Reviewed by Darin Adler.
3249
3250         Reverted the linked-on-or-after check added in r170120 since it is no longer necessary.
3251
3252         * Misc/WebKitVersionChecks.h:
3253         * WebView/WebView.mm:
3254         (-[WebView _preferencesChanged:]):
3255
3256 2014-08-16  Maciej Stachowiak  <mjs@apple.com>
3257
3258         Remove the obsolete WebKitEnableCoalescedUpdatesPreferenceKey
3259         https://bugs.webkit.org/show_bug.cgi?id=136024
3260
3261         Reviewed by Filip Pizlo.
3262
3263         * WebView/WebFrameView.mm:
3264         (-[WebFrameView initWithFrame:]): Remove code that respects
3265         this key. It was SPI and is no longer used; also it was
3266         only relevant for versions of OS X that WebKit no longer supports.
3267         * WebView/WebPreferenceKeysPrivate.h: Remove declaration.
3268
3269 2014-08-15  Daniel Bates  <dabates@apple.com>
3270
3271         [iOS] Teach postprocess-headers.sh to remove code guarded by ENABLE_IOS_GESTURE_EVENTS
3272         and ENABLE_TOUCH_EVENTS if applicable
3273         https://bugs.webkit.org/show_bug.cgi?id=135993
3274
3275         Reviewed by Andy Estes.
3276
3277         Add support infrastructure to remove code from public and private API headers that is
3278         guarded by macro define ENABLE_{IOS_GESTURE, TOUCH}_EVENTS when these features are disabled.
3279
3280         We aren't using this functionality yet, but we will soon.
3281
3282         * postprocess-headers.sh:
3283
3284 2014-08-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3285
3286         Enable CSS_SCROLL_SNAP for iOS
3287         https://bugs.webkit.org/show_bug.cgi?id=135915
3288
3289         Turn on CSS_SCROLL_SNAP for iOS and the iOS simulator.
3290
3291         Reviewed by Tim Horton.
3292
3293         * Configurations/FeatureDefines.xcconfig:
3294
3295 2014-08-13  Mark Rowe  <mrowe@apple.com>
3296
3297         <https://webkit.org/b/135911> WebKit should build on Yosemite with the public SDK.
3298
3299         Reviewed by Darin Adler.
3300
3301         * Misc/WebSharingServicePickerController.mm: Forward-declare some details related to NSSharingServicePicker.
3302
3303 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3304
3305         Web Inspector: Workaround a NSWindow change to the title bar.
3306         https://bugs.webkit.org/show_bug.cgi?id=135880
3307
3308         Reviewed by Joseph Pecoraro.
3309
3310         * WebCoreSupport/WebInspectorClient.mm:
3311         (WebInspectorFrontendClient::setToolbarHeight): Only call setContentBorderThickness: on 10.9 and earlier.
3312         (-[WebInspectorWindowController init]): Only call setDrawsBackground: on 10.9 and earlier.
3313         (-[WebInspectorWindowController window]): Set titlebarAppearsTransparent on 10.10.
3314         Only call border thickness APIs on 10.9 and earlier.
3315
3316 2014-08-12  Peyton Randolph  <prandolph@apple.com>
3317
3318         Runtime switch for long mouse press gesture. Part of 135257 - Add long mouse press gesture.           
3319         https://bugs.webkit.org/show_bug.cgi?id=135682
3320
3321         Reviewed by Tim Horton.
3322
3323         * Configurations/FeatureDefines.xcconfig:
3324         Remove LONG_MOUSE_PRESS feature flag.
3325
3326 2014-08-11  Andy Estes  <aestes@apple.com>
3327
3328         [iOS] Get rid of iOS.xcconfig
3329         https://bugs.webkit.org/show_bug.cgi?id=135809
3330
3331         Reviewed by Joseph Pecoraro.
3332
3333         All iOS.xcconfig did was include AspenFamily.xcconfig, so there's no need for the indirection.
3334
3335         * Configurations/Base.xcconfig:
3336         * Configurations/iOS.xcconfig: Removed.
3337
3338 2014-08-10  Timothy Hatcher  <timothy@apple.com>
3339
3340         Web Inspector: new glyphs are visible on OS X 10.9 builds
3341         https://bugs.webkit.org/show_bug.cgi?id=135743
3342
3343         Reviewed by Joseph Pecoraro.
3344
3345         * WebCoreSupport/WebInspectorClient.mm:
3346         (-[WebInspectorWindowController window]): Use 10100 instead of 1090 for the version.
3347
3348 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
3349
3350         Get rid of SCRIPTED_SPEECH
3351         https://bugs.webkit.org/show_bug.cgi?id=135729
3352
3353         Reviewed by Brent Fulgham.
3354
3355         * Configurations/FeatureDefines.xcconfig:
3356
3357 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
3358
3359         Get rid of INPUT_SPEECH
3360         https://bugs.webkit.org/show_bug.cgi?id=135672
3361
3362         Reviewed by Andreas Kling.
3363
3364         * Configurations/FeatureDefines.xcconfig:
3365
3366 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3367
3368         Web Inspector: Update glyphs to be more like Xcode 6
3369         https://bugs.webkit.org/show_bug.cgi?id=135705
3370
3371         Reviewed by Joseph Pecoraro.
3372
3373         * Resources/Dock.pdf: Added.
3374         * Resources/DockLegacy.pdf: Copied from Source/WebKit/mac/Resources/Dock.pdf.
3375         * WebCoreSupport/WebInspectorClient.mm:
3376         (-[WebInspectorWindowController window]): Use new images.
3377
3378 2014-08-06  Dean Jackson  <dino@apple.com>
3379
3380         ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED is not used anywhere. Remove it.
3381         https://bugs.webkit.org/show_bug.cgi?id=135675
3382
3383         Reviewed by Sam Weinig.
3384
3385         * Configurations/FeatureDefines.xcconfig:
3386
3387 2014-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3388
3389         Implement parsing for CSS scroll snap points
3390         https://bugs.webkit.org/show_bug.cgi?id=134301
3391
3392         Reviewed by Dean Jackson.
3393
3394         * Configurations/FeatureDefines.xcconfig: Added ENABLE_CSS_SCROLL_SNAP
3395
3396 2014-08-06  Alexey Proskuryakov  <ap@apple.com>
3397
3398         REGRESSION (WebKit2): iOS Safari default encoding doesn't follow system language
3399         https://bugs.webkit.org/show_bug.cgi?id=135667
3400         <rdar://problem/17862892>
3401
3402         Reviewed by Anders Carlsson.
3403
3404         * WebView/WebPreferences.mm: (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]):
3405         Moved implementation to WebCore, so that it can be shared with WebKit2.
3406
3407         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
3408         We now use WKGetWebDefaultCFStringEncoding in WebCore, so it needs to be initialized.
3409
3410 2014-08-05  Peyton Randolph  <prandolph@apple.com>
3411
3412         Rename MAC_LONG_PRESS feature flag to LONG_MOUSE_PRESS.
3413         https://bugs.webkit.org/show_bug.cgi?id=135276
3414
3415         Reviewed by Beth Dakin.
3416
3417         * Configurations/FeatureDefines.xcconfig:
3418
3419 2014-08-04  Benjamin Poulain  <benjamin@webkit.org>
3420
3421         Add a flag for the CSS Selectors level 4 implementation
3422         https://bugs.webkit.org/show_bug.cgi?id=135535
3423
3424         Reviewed by Andreas Kling.
3425
3426         * Configurations/FeatureDefines.xcconfig:
3427
3428 2014-08-04  Benjamin Poulain  <bpoulain@apple.com>
3429
3430         Check for null frame when processing geolocation authorization request
3431         https://bugs.webkit.org/show_bug.cgi?id=135577
3432         <rdar://problem/17896295>
3433
3434         Reviewed by Geoffrey Garen.
3435
3436         * WebCoreSupport/WebGeolocationClient.mm:
3437         (WebGeolocationClient::requestPermission):
3438
3439 2014-08-02  Jeremy Jones  <jeremyj@apple.com>
3440
3441         Support both window and view based video fullscreen.
3442         https://bugs.webkit.org/show_bug.cgi?id=135525
3443
3444         Reviewed by Simon Fraser.
3445
3446         Parenting in the view instead of the window gives the fullscreen implementation more latitude 
3447         in how it implements the animation.
3448
3449         * WebView/WebView.mm:
3450         (-[WebView _enterFullscreenForNode:]): Use view instead of window.
3451
3452 2014-08-01  Dan Bernstein  <mitz@apple.com>
3453
3454         <rdar://problem/17891752> [iOS] WebKit links against libraries it doesn’t use
3455         https://bugs.webkit.org/show_bug.cgi?id=135536
3456
3457         Reviewed by Tim Horton.
3458
3459         * Configurations/WebKitLegacy.xcconfig: Removed -framework MobileAsset from
3460         OTHER_LDFLAGS_iphoneos.
3461
3462 2014-07-30  Andy Estes  <aestes@apple.com>
3463
3464         USE(CONTENT_FILTERING) should be ENABLE(CONTENT_FILTERING)
3465         https://bugs.webkit.org/show_bug.cgi?id=135439
3466
3467         Reviewed by Tim Horton.
3468
3469         We now support two different platform content filters, and will soon support a mock content filter (as part of
3470         webkit.org/b/128858). This makes content filtering a feature of WebKit, not just an adoption of a third-party
3471         library. ENABLE() is the correct macro to use for such a feature.
3472
3473         * Configurations/FeatureDefines.xcconfig:
3474
3475 2014-07-30  Andreas Kling  <akling@apple.com>
3476
3477         Static hash tables no longer need to be coupled with a VM.
3478         <https://webkit.org/b/135421>
3479
3480         Reviewed by Geoffrey Garen.
3481
3482         * Plugins/Hosted/ProxyInstance.mm:
3483         * Plugins/Hosted/ProxyRuntimeObject.mm:
3484
3485 2014-07-30  Dan Bernstein  <mitz@apple.com>
3486
3487         Updated for changes to the WebCore::Credential API.
3488         Work towards fixing https://bugs.webkit.org/show_bug.cgi?id=135327
3489
3490         Reviewed by Alexey Proskuryakov.
3491
3492         * Misc/WebDownload.mm:
3493         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): Use new nsCredential
3494         getter.
3495         * Plugins/WebBaseNetscapePluginView.mm:
3496         (WebKit::getAuthenticationInfo): Ditto.
3497
3498 2014-07-27  Pratik Solanki  <psolanki@apple.com>
3499
3500         Remove unused preference keys
3501         https://bugs.webkit.org/show_bug.cgi?id=135280
3502
3503         Reviewed by Darin Adler.
3504
3505         * WebView/WebPreferenceKeysPrivate.h:
3506         * WebView/WebPreferences.mm:
3507         (+[WebPreferences initialize]):
3508         (-[WebPreferences _setPageCacheSize:]): Deleted.
3509         (-[WebPreferences _pageCacheSize]): Deleted.
3510         (-[WebPreferences _setObjectCacheSize:]): Deleted.
3511         (-[WebPreferences _objectCacheSize]): Deleted.
3512         * WebView/WebPreferencesPrivate.h:
3513
3514 2014-07-27  Filip Pizlo  <fpizlo@apple.com>
3515
3516         Merge r170090, r170092, r170129, r170141, r170161, r170215, r170275, r170375, r170376, r170382, r170383, r170399, r170436, r170489, r170490, r170556 from ftlopt.
3517
3518     2014-07-25  Mark Lam  <mark.lam@apple.com>
3519     
3520             [ftlopt] Renamed DebuggerActivation to DebuggerScope.
3521             <https://webkit.org/b/134273>
3522     
3523             Reviewed by Michael Saboff.
3524     
3525             * WebView/WebScriptDebugDelegate.mm:
3526             - Removed unneeded #include.
3527     
3528 2014-07-26  Filip Pizlo  <fpizlo@apple.com>
3529
3530         Unreviewed, roll out r171641-r171644. It broke some tests; will investigate and
3531         reland later.
3532
3533         * WebView/WebScriptDebugDelegate.mm:
3534
3535 2014-07-25  Filip Pizlo  <fpizlo@apple.com>
3536
3537         Merge r170090, r170092, r170129, r170141, r170161, r170215, r170275, r170375, r170376, r170382, r170383, r170399, r170436, r170489, r170490, r170556 from ftlopt.
3538
3539     2014-07-25  Mark Lam  <mark.lam@apple.com>
3540     
3541             [ftlopt] Renamed DebuggerActivation to DebuggerScope.
3542             <https://webkit.org/b/134273>
3543     
3544             Reviewed by Michael Saboff.
3545     
3546             * WebView/WebScriptDebugDelegate.mm:
3547             - Removed unneeded #include.
3548     
3549 2014-07-25  Jeremy Jones  <jeremyj@apple.com>
3550
3551         Parent fullscreen from window instead of view
3552         https://bugs.webkit.org/show_bug.cgi?id=135310
3553
3554         Reviewed by Jer Noble.
3555
3556         Parenting in the view causes an incorrect animation to fullscreen, and can cause 
3557         fullscreen to only expand to the size of the view instead of the whole window.
3558
3559         * WebView/WebView.mm:
3560         (-[WebView _enterFullscreenForNode:]): Pass window instead of view.
3561
3562 2014-07-24  Pratik Solanki  <psolanki@apple.com>
3563
3564         [iOS] Remove prefs to tweak cache values
3565         https://bugs.webkit.org/show_bug.cgi?id=135274
3566         <rdar://problem/17784826>