Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
2
3         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
4         https://bugs.webkit.org/show_bug.cgi?id=139529
5         <rdar://problem/19213620>
6
7         Reviewed by Beth Dakin.
8
9         * WebView/WebActionMenuController.mm:
10         (-[WebActionMenuController _copySelection:]):
11         (-[WebActionMenuController _paste:]):
12         Use the copy: and paste: methods on WebView so that we traverse subviews
13         when trying to respond, otherwise these actions don't work in subframes.
14
15 2014-12-10  Beth Dakin  <bdakin@apple.com>
16
17         WK1: Add initial support for immediate actions
18         https://bugs.webkit.org/show_bug.cgi?id=139522
19
20         Reviewed by Dan Bernstein.
21
22         This basic implementation of the controller will use the delegate methods to 
23         perform and cache a HitTest when relevant. Future patches will patch 
24         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
25         immediate action that should be taken.
26         * WebView/WebImmediateActionController.h: Added.
27         * WebView/WebImmediateActionController.mm: Added.
28         (-[WebImmediateActionController webViewClosed]):
29         (-[WebImmediateActionController _clearImmediateActionState]):
30         (-[WebImmediateActionController performHitTestAtPoint:]):
31         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
32         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
33         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
34         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
35         (-[WebImmediateActionController _updateImmediateActionItem]):
36
37         New enum for immediate action types.
38         * WebView/WebUIDelegatePrivate.h:
39
40         Create an NSImmediateActionGestureRecognizer if possible and a controller.
41         * WebView/WebView.mm:
42         (-[WebView _commonInitializationWithFrameName:groupName:]):
43         (-[WebView _close]):
44         * WebView/WebViewData.h:
45         * WebView/WebViewData.mm:
46         (-[WebViewPrivate dealloc]):
47
48 2014-12-08  Anders Carlsson  <andersca@apple.com>
49
50         Use the new storage namespace provider in WebKit1
51         https://bugs.webkit.org/show_bug.cgi?id=139425
52
53         Reviewed by Tim Horton.
54
55         * WebView/WebView.mm:
56         (-[WebView _commonInitializationWithFrameName:groupName:]):
57         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
58         Set the storage namespace provider from the web page group.
59
60 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
61
62         Should have copy and paste items in all text menus
63         https://bugs.webkit.org/show_bug.cgi?id=139510
64         <rdar://problem/19198388>
65
66         Reviewed by Beth Dakin.
67
68         * WebView/WebActionMenuController.mm:
69         (-[WebActionMenuController _defaultMenuItemsForText]):
70         Add a disabled paste menu item into the read-only text menu.
71
72         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
73         Add a disabled copy menu item into the editable whitespace text menu.
74
75 2014-12-10  Anders Carlsson  <andersca@apple.com>
76
77         Add WebStorageNamespaceProvider::closeLocalStorage
78         https://bugs.webkit.org/show_bug.cgi?id=139502
79
80         Reviewed by Tim Horton.
81
82         * WebView/WebView.mm:
83         (+[WebView _applicationWillTerminate]):
84         Call WebStorageNamespaceProvider::closeLocalStorage.
85
86 2014-12-09  Commit Queue  <commit-queue@webkit.org>
87
88         Unreviewed, rolling out r177037.
89         https://bugs.webkit.org/show_bug.cgi?id=139464
90
91         broke ~50 API tests (Requested by thorton on #webkit).
92
93         Reverted changeset:
94
95         "Use the new storage namespace provider in WebKit1"
96         https://bugs.webkit.org/show_bug.cgi?id=139425
97         http://trac.webkit.org/changeset/177037
98
99 2014-12-08  Anders Carlsson  <andersca@apple.com>
100
101         Use the new storage namespace provider in WebKit1
102         https://bugs.webkit.org/show_bug.cgi?id=139425
103
104         Reviewed by Tim Horton.
105
106         * WebView/WebView.mm:
107         (-[WebView _commonInitializationWithFrameName:groupName:]):
108         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
109         Set the storage namespace provider from the web page group.
110
111 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
112
113         Delete Node::boundingBox()
114         https://bugs.webkit.org/show_bug.cgi?id=139333
115
116         Reviewed by Zalan Bujtas.
117
118         * WebView/WebActionMenuController.mm:
119         (elementBoundingBoxInWindowCoordinatesFromNode): Use
120         RenderObject::absoluteBoundingBoxRect().
121
122 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
123
124         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
125         https://bugs.webkit.org/show_bug.cgi?id=138843
126         rdar://problem/18793695
127
128         Reviewed by Dan Bernstein.
129
130         * Panels/WebAuthenticationPanel.m:
131         (-[WebAuthenticationPanel cancel:]):
132         (-[WebAuthenticationPanel logIn:]):
133         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
134         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
135         that only when using an old NSWindow API.
136
137 2014-12-08  Beth Dakin  <bdakin@apple.com>
138
139         Copy and Lookup menu items should be disabled when something is not copyable
140         https://bugs.webkit.org/show_bug.cgi?id=139423
141
142         Reviewed by Tim Horton.
143
144         Disable both lookup and copy when a HitTestResult does not allow copy.
145         * WebView/WebActionMenuController.mm:
146
147         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
148         disable state otherwise.
149         * WebView/WebView.mm:
150         (-[WebView _commonInitializationWithFrameName:groupName:]):
151
152 2014-12-08  Anders Carlsson  <andersca@apple.com>
153
154         Adding user content to a group should force that group to be created
155         https://bugs.webkit.org/show_bug.cgi?id=139421
156         rdar://problem/19180108
157
158         Reviewed by Sam Weinig.
159
160         * WebCoreSupport/WebViewGroup.h:
161         Store the local storage database path in the group.
162
163         * WebCoreSupport/WebViewGroup.mm:
164         (WebViewGroup::getOrCreate):
165         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
166         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
167
168         (WebViewGroup::WebViewGroup):
169         Initialize the new member variable.
170
171         (WebViewGroup::storageNamespaceProvider):
172         Create the namespace provider lazily.
173
174         * WebView/WebView.mm:
175         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
176         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
177         Use getOrCreate instead of get.
178
179 2014-12-08  Anders Carlsson  <andersca@apple.com>
180
181         WebStorageNamespaceProvider should know about its local storage database path
182         https://bugs.webkit.org/show_bug.cgi?id=139413
183
184         Reviewed by Andreas Kling.
185
186         * WebCoreSupport/WebViewGroup.h:
187         * WebCoreSupport/WebViewGroup.mm:
188         (WebViewGroup::getOrCreate):
189         (WebViewGroup::WebViewGroup):
190         * WebView/WebView.mm:
191         (-[WebView _commonInitializationWithFrameName:groupName:]):
192         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
193         (-[WebView setGroupName:]):
194         (-[WebView groupName]): Deleted.
195
196 2014-12-08  Daniel Bates  <dabates@apple.com>
197
198         [iOS] Fix the WebKit build with the public SDK
199
200         Include header NSURLDownloadSPI.h.
201
202         * WebCoreSupport/WebFrameLoaderClient.mm:
203
204 2014-12-07  Dan Bernstein  <mitz@apple.com>
205
206         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
207         https://bugs.webkit.org/show_bug.cgi?id=139348
208
209         Reviewed by Anders Carlsson.
210
211         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
212         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
213         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
214         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
215         avoiding the ambiguity.
216
217         * WebView/WebActionMenuController.mm:
218         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
219
220 2014-12-06  Anders Carlsson  <andersca@apple.com>
221
222         Add a stubbed out version of WebStorageNamespaceProvider
223         https://bugs.webkit.org/show_bug.cgi?id=139213
224
225         Reviewed by Sam Weinig.
226
227         * WebCoreSupport/WebViewGroup.h:
228         (WebViewGroup::storageNamespaceProvider):
229         * WebCoreSupport/WebViewGroup.mm:
230         (WebViewGroup::getOrCreate):
231         (WebViewGroup::WebViewGroup):
232         Give WebViewGroup a storage namespace provider.
233
234 2014-12-06  Anders Carlsson  <andersca@apple.com>
235
236         Fix build with newer versions of clang.
237         rdar://problem/18978687
238
239         Add missing overrides and missing casts.
240
241         * Storage/WebDatabaseManagerClient.h:
242         * Storage/WebStorageTrackerClient.h:
243         * WebCoreSupport/WebChromeClient.h:
244         * WebCoreSupport/WebFrameLoaderClient.h:
245         * WebCoreSupport/WebInspectorClient.h:
246         * WebView/WebDataSource.mm:
247         (-[WebDataSource _makeRepresentation]):
248         * WebView/WebFrameView.mm:
249         (-[WebFrameView _makeDocumentViewForDataSource:]):
250
251 2014-12-05  Tim Horton  <timothy_horton@apple.com>
252
253         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
254         https://bugs.webkit.org/show_bug.cgi?id=139306
255         <rdar://problem/19157955>
256
257         Reviewed by Beth Dakin.
258
259         * WebView/WebView.mm:
260         (-[WebView _commonInitializationWithFrameName:groupName:]):
261         (-[WebView _initWithFrame:frameName:groupName:]):
262         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
263
264 2014-12-05  David Kilzer  <ddkilzer@apple.com>
265
266         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
267         <http://webkit.org/b/139286>
268
269         Reviewed by Daniel Bates.
270
271         * Configurations/FeatureDefines.xcconfig: Switch back to using
272         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
273
274 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
275
276         Fix the 32-bit build.
277
278         * WebView/WebView.mm:
279         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
280
281 2014-12-04  Tim Horton  <timothy_horton@apple.com>
282
283         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
284         https://bugs.webkit.org/show_bug.cgi?id=139252
285         <rdar://problem/19140827>
286
287         Reviewed by Anders Carlsson.
288
289         * WebView/WebView.mm:
290         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
291         Adjust to the WebCore changes.
292
293 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
294
295         Implement action menus for tel: URLs
296         https://bugs.webkit.org/show_bug.cgi?id=139240
297         <rdar://problem/19115662>
298
299         Reviewed by Anders Carlsson.
300
301         * WebView/WebActionMenuController.mm:
302         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
303         Make sure to use the newly created currentActionContext... everywhere.
304
305 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
306
307         Implement action menus for tel: URLs
308         https://bugs.webkit.org/show_bug.cgi?id=139240
309         <rdar://problem/19115662>
310
311         Reviewed by Anders Carlsson.
312
313         * WebView/WebActionMenuController.mm:
314         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
315         Make sure to use the newly created currentActionContext.
316
317 2014-12-03  Beth Dakin  <bdakin@apple.com>
318
319         <input> elements get whitespace action menu instead of editable text menu
320         https://bugs.webkit.org/show_bug.cgi?id=139241
321         -and corresponding-
322         rdar://problem/19072083
323
324         Reviewed by Sam Weinig.
325
326         We should disallow shadow content in the hit test. This is the default and it is 
327         how context menus behave. We originally wanted to text inside shadow content so 
328         that we could find the text, but the new function I added to HitTestResult will 
329         allow that.
330         * WebView/WebActionMenuController.mm:
331         (-[WebActionMenuController performHitTestAtPoint:]):
332
333         Adjust to the fact that we don’t hit test shadow content any more.
334         (-[WebActionMenuController focusAndSelectHitTestResult]):
335
336         Offer the text menus for text inside form controls.
337         (-[WebActionMenuController _defaultMenuItems]):
338
339 2014-12-03  Tim Horton  <timothy_horton@apple.com>
340
341         Implement action menus for tel: URLs
342         https://bugs.webkit.org/show_bug.cgi?id=139240
343         <rdar://problem/19115662>
344
345         Reviewed by Anders Carlsson.
346
347         * WebView/WebActionMenuController.mm:
348         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
349         Rename this function as it will work for both mailto and tel URLs.
350         Adjust it to use contextForView:.
351
352         (-[WebActionMenuController webView:willHandleMouseDown:]):
353         (-[WebActionMenuController prepareForMenu:withEvent:]):
354         (-[WebActionMenuController didCloseMenu:withEvent:]):
355         (-[WebActionMenuController _defaultMenuItems]):
356         Don't check the menu type when going to interact with _currentActionContext.
357         We'll only have a _currentActionContext if we have a data detected item,
358         and there are multiple menu types that end up using DDActionContext.
359
360         * WebView/WebUIDelegatePrivate.h:
361         Add a new type.
362
363 2014-12-03  Anders Carlsson  <andersca@apple.com>
364
365         Set a visited link store when creating a simple WebView
366         https://bugs.webkit.org/show_bug.cgi?id=139234
367         <rdar://problem/19132978>
368
369         Reviewed by Sam Weinig.
370
371         * WebView/WebView.mm:
372         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
373
374 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
375
376         Fix the build.
377
378         * WebCoreSupport/WebFrameLoaderClient.mm:
379
380 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
381
382         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
383         https://bugs.webkit.org/show_bug.cgi?id=139149
384
385         Reviewed by Anders Carlsson.
386
387         This changes API behavior. I think that it's OK, because existing behavior made no sense.
388         We used to delete caches from disk, but they were still active in memory. Now we also
389         obsolete them in memory, so documents that use a cache still work, but new ones don't
390         pick one up.
391
392         * WebCoreSupport/WebApplicationCache.mm:
393         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
394         need to delete in-momry caches too. Keep existing behavior.
395         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
396         that properly deletes caches.
397
398 2014-12-02  Tim Horton  <timothy_horton@apple.com>
399
400         Remove a SnowLeopard-era quirk for QuickLook
401         https://bugs.webkit.org/show_bug.cgi?id=139208
402         <rdar://problem/19121822>
403
404         Reviewed by Alexey Proskuryakov.
405
406         * WebCoreSupport/WebFrameLoaderClient.h:
407         * WebCoreSupport/WebFrameLoaderClient.mm:
408
409 2014-12-02  Tim Horton  <timothy_horton@apple.com>
410
411         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
412         https://bugs.webkit.org/show_bug.cgi?id=139204
413
414         Reviewed by Anders Carlsson.
415
416         * WebView/WebView.mm:
417         (-[WebView _commonInitializationWithFrameName:groupName:]):
418         (-[WebView _showDictionaryLookupPopup:]):
419         * WebView/WebViewData.h:
420         Work around this by delaying the softlinking (and setting up the notification
421         observer) until we actually need it. There's still an underlying bug, but
422         this will fix the test.
423
424 2014-12-02  Beth Dakin  <bdakin@apple.com>
425
426         Yet another build fix.
427
428         * WebView/WebActionMenuController.mm:
429         (-[WebActionMenuController _defaultMenuItemsForLink]):
430
431 2014-12-02  Beth Dakin  <bdakin@apple.com>
432
433         Build fix.
434
435         * WebView/WebActionMenuController.mm:
436         (-[WebActionMenuController _defaultMenuItemsForLink]):
437
438 2014-12-02  Beth Dakin  <bdakin@apple.com>
439
440         More build fixing.
441
442         * WebView/WebActionMenuController.mm:
443         (-[WebActionMenuController _defaultMenuItemsForLink]):
444
445 2014-12-02  Beth Dakin  <bdakin@apple.com>
446
447         Should use standardQuickLookMenuItem for apps that don't implement customizations
448         https://bugs.webkit.org/show_bug.cgi?id=139193
449         -and corresponding-
450         rdar://problem/18944696
451
452         Reviewed by Anders Carlsson.
453
454         Use [NSMenuItem standardQuickLookMenuItem].
455         * WebView/WebActionMenuController.mm:
456         (-[WebActionMenuController _defaultMenuItemsForLink]):
457
458         Delegate methods to set up the standardQuickLookMenuItem.
459         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
460         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
461         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
462
463         Remove all of the old QLPreviewBubble code.
464         (-[WebActionMenuController _createActionMenuItemForTag:]):
465         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
466
467 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
468
469         Fix the build.
470
471         * WebView/WebViewData.h:
472
473 2014-12-02  Tim Horton  <timothy_horton@apple.com>
474
475         Implement Lookup transition from selection for Legacy WebKit
476         https://bugs.webkit.org/show_bug.cgi?id=139180
477         <rdar://problem/19067172>
478
479         Reviewed by Beth Dakin.
480
481         * WebView/DictionaryPopupInfo.h: Added.
482         Split DictionaryPopupInfo out into its own file.
483
484         * WebView/WebActionMenuController.mm:
485         (-[WebActionMenuController _lookupText:]):
486         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
487
488         (performDictionaryLookupForSelection):
489         (performDictionaryLookupForRange):
490         Plumb the transition style through these helpers.
491         Create a TextIndicator from the selection range.
492
493         * WebView/WebHTMLView.mm:
494         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
495         Make use of TextIndicator (and DictionaryPopupInfo, and the new
496         _showDictionaryLookupPopup on WebView) to add a transition from blue
497         when performing Lookup from the context menu.
498
499         (-[WebHTMLView quickLookWithEvent:]):
500         Remove our TextIndicator whenever a normal three-finger-tap event
501         comes through, as it will have its own indication.
502
503         * WebView/WebView.mm:
504         (-[WebView _commonInitializationWithFrameName:groupName:]):
505         (-[WebView _dictionaryLookupPopoverWillClose:]):
506         Register for the LUNotificationPopoverWillClose notification and remove
507         our TextIndicator when it is called, just like in WebKit2.
508         Deregistration is already handled in _close.
509
510         (-[WebView _showDictionaryLookupPopup:]):
511         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
512         if the relevant API is available.
513
514         * WebView/WebViewInternal.h:
515
516 2014-12-02  Anders Carlsson  <andersca@apple.com>
517
518         Remove visited link handling from PageGroup
519         https://bugs.webkit.org/show_bug.cgi?id=139185
520
521         Reviewed by Sam Weinig.
522
523         * History/WebHistory.mm:
524         (-[WebHistoryPrivate removeItemForURLString:]):
525         (-[WebHistoryPrivate removeAllItems]):
526         (+[WebHistory setOptionalSharedHistory:]):
527         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
528         (+[WebHistory _removeAllVisitedLinks]):
529         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
530         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
531         * History/WebHistoryInternal.h:
532         * WebCoreSupport/WebChromeClient.h:
533         * WebCoreSupport/WebChromeClient.mm:
534         (WebChromeClient::populateVisitedLinks): Deleted.
535         * WebView/WebView.mm:
536         (-[WebView addVisitedLinks:]):
537         (-[WebView removeVisitedLink:]):
538
539 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
540
541         Try to fix the Mac build.
542
543         * WebView/WebView.mm:
544         (-[WebView _commonInitializationWithFrameName:groupName:]):
545         (-[WebView _close]):
546
547 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
548
549         Fix the iOS build.
550
551         * WebView/WebActionMenuController.h:
552         * WebView/WebActionMenuController.mm:
553         * WebView/WebHTMLView.mm:
554         (-[WebHTMLView scrollWheel:scrollWheel:]):
555         (-[WebHTMLView mouseDown:mouseDown:]):
556         * WebView/WebView.mm:
557         * WebView/WebViewData.h:
558         * WebView/WebViewData.mm:
559         (-[WebViewPrivate dealloc]):
560         * WebView/WebViewInternal.h:
561
562 2014-12-01  Tim Horton  <timothy_horton@apple.com>
563
564         Implement yellow highlight for WebKit1 data detectors
565         https://bugs.webkit.org/show_bug.cgi?id=138956
566         <rdar://problem/18992185>
567
568         Reviewed by Beth Dakin.
569
570         * WebView/WebActionMenuController.h:
571         * WebView/WebActionMenuController.mm:
572         (-[WebActionMenuController webView:willHandleMouseDown:]):
573         (-[WebActionMenuController webView:didHandleScrollWheel:]):
574         (-[WebActionMenuController prepareForMenu:withEvent:]):
575         (-[WebActionMenuController didCloseMenu:withEvent:]):
576         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
577         (-[WebActionMenuController _showTextIndicator]):
578         (-[WebActionMenuController _hideTextIndicator]):
579         (-[WebActionMenuController _dismissActionMenuPopovers]):
580         Copy the WebKit2 WKActionMenuController TextIndicator implementation
581         into WebActionMenuController. The only significant difference is
582         that we build the TextIndicator right at menu construction time
583         instead of in the Web process.
584
585         * WebView/WebHTMLView.mm:
586         (-[WebHTMLView scrollWheel:]):
587         Let the WebActionMenuController know that we're handling a scroll.
588
589         (-[WebHTMLView mouseDown:]):
590         Let the WebActionMenuController know that we're handling a mouseDown.
591
592         * WebView/WebView.mm:
593         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
594         (-[WebView _clearTextIndicator]):
595         (-[WebView _actionMenuController]):
596         (-[WebView _convertRectFromRootView:]): Deleted.
597         * WebView/WebViewData.h:
598         * WebView/WebViewData.mm:
599         * WebView/WebViewInternal.h:
600         Keep a TextIndicatorWindow on WebView, just like WKView does.
601         Expose the WebActionMenuController on WebView (internally).
602
603 2014-12-01  Anders Carlsson  <andersca@apple.com>
604
605         Remove old site specific quirks code that was added in 2009
606         https://bugs.webkit.org/show_bug.cgi?id=139141
607
608         Reviewed by Antti Koivisto.
609
610         * WebCoreSupport/WebFrameNetworkingContext.h:
611         * WebCoreSupport/WebFrameNetworkingContext.mm:
612         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
613
614 2014-11-30  Anders Carlsson  <andersca@apple.com>
615
616         Fix a test failure.
617
618         * History/WebHistory.mm:
619         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
620         Call through to the visited link store.
621
622         (+[WebHistory _removeAllVisitedLinks]):
623         Ditto.
624
625         * WebCoreSupport/WebVisitedLinkStore.mm:
626         (WebVisitedLinkStore::isLinkVisited):
627         Make sure to populate visited links.
628
629 2014-11-30  Anders Carlsson  <andersca@apple.com>
630
631         Switch over to the visited link store from the WebViewGroup
632         https://bugs.webkit.org/show_bug.cgi?id=139112
633
634         Reviewed by Sam Weinig.
635
636         * WebView/WebView.mm:
637         (-[WebView _commonInitializationWithFrameName:groupName:]):
638         (-[WebView setGroupName:]):
639
640 2014-11-30  Anders Carlsson  <andersca@apple.com>
641
642         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
643         https://bugs.webkit.org/show_bug.cgi?id=139111
644
645         Reviewed by Sam Weinig.
646
647         * WebCoreSupport/WebVisitedLinkStore.h:
648         * WebCoreSupport/WebVisitedLinkStore.mm:
649         (WebVisitedLinkStore::removeVisitedLink):
650         * WebView/WebView.mm:
651         (-[WebView removeVisitedLink:]):
652
653 2014-11-29  Anders Carlsson  <andersca@apple.com>
654
655         Populate visited links
656         https://bugs.webkit.org/show_bug.cgi?id=139101
657
658         Reviewed by Sam Weinig.
659
660         * History/WebHistory.mm:
661         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
662         Helper function that adds all visited link to the given store.
663
664         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
665         Call the private method.
666
667         * History/WebHistoryInternal.h:
668         * WebCoreSupport/WebVisitedLinkStore.h:
669         Add new members.
670
671         * WebCoreSupport/WebVisitedLinkStore.mm:
672         (WebVisitedLinkStore::addVisitedLink):
673         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
674
675         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
676         Implement this. First try the delegate, then try the shared history.
677
678         (WebVisitedLinkStore::addVisitedLinkHash):
679         Factor code that adds the link to the hash table into a separate function.
680
681         * WebView/WebView.mm:
682         (-[WebView addVisitedLinks:]):
683         Add the visited links to the store.
684
685 2014-11-29  Anders Carlsson  <andersca@apple.com>
686
687         More work on the legacy WebKit visited link store
688         https://bugs.webkit.org/show_bug.cgi?id=139100
689
690         Reviewed by Sam Weinig.
691
692         * History/WebHistory.mm:
693         (+[WebHistory setOptionalSharedHistory:]):
694         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
695
696         * WebCoreSupport/WebVisitedLinkStore.h:
697         * WebCoreSupport/WebVisitedLinkStore.mm:
698         (visitedLinkStores):
699         (WebVisitedLinkStore::WebVisitedLinkStore):
700         (WebVisitedLinkStore::~WebVisitedLinkStore):
701         Keep track of live visited link stores.
702
703         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
704         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
705
706         (WebVisitedLinkStore::removeAllVisitedLinks):
707         Iterate over all live link stores and remove their links.
708
709         (WebVisitedLinkStore::isLinkVisited):
710         Populate visited links and check if our hash table contains the link.
711
712         (WebVisitedLinkStore::addVisitedLink):
713         Add the link hash to the table.
714
715         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
716         Add stub.
717
718         (WebVisitedLinkStore::removeVisitedLinkHashes):
719         Clear out the hash table.
720
721 2014-11-27  Anders Carlsson  <andersca@apple.com>
722
723         Add a stubbed out WebVisitedLinkStore to WebViewGroup
724         https://bugs.webkit.org/show_bug.cgi?id=139066
725
726         Reviewed by Antti Koivisto.
727
728         * WebCoreSupport/WebViewGroup.h:
729         (WebViewGroup::visitedLinkStore):
730         * WebCoreSupport/WebViewGroup.mm:
731         (WebViewGroup::WebViewGroup):
732         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
733         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
734         (WebVisitedLinkStore::create):
735         (WebVisitedLinkStore::WebVisitedLinkStore):
736         (WebVisitedLinkStore::~WebVisitedLinkStore):
737         (WebVisitedLinkStore::isLinkVisited):
738         (WebVisitedLinkStore::addVisitedLink):
739
740 2014-11-25  Anders Carlsson  <andersca@apple.com>
741
742         Remove user content handling from PageGroup
743         https://bugs.webkit.org/show_bug.cgi?id=139051
744
745         Reviewed by Antti Koivisto.
746
747         Use the user content controller in the web view group.
748
749         * WebView/WebView.mm:
750         (-[WebView _injectOutlookQuirksScript]):
751
752 2014-11-25  Anders Carlsson  <andersca@apple.com>
753
754         Add a user content controller to WebViewGroup and use it for user content
755         https://bugs.webkit.org/show_bug.cgi?id=139043
756
757         Reviewed by Antti Koivisto.
758
759         This is another tiny step towards getting rid of user content handling inside PageGroup.
760
761         * WebCoreSupport/WebViewGroup.h:
762         (WebViewGroup::userContentController):
763         Add a UserContentController member and getter.
764
765         * WebCoreSupport/WebViewGroup.mm:
766         (WebViewGroup::get):
767         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
768
769         (WebViewGroup::WebViewGroup):
770         Create a user content controller.
771
772         * WebView/WebView.mm:
773         (-[WebView _commonInitializationWithFrameName:groupName:]):
774         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
775         set its user content controller in the PageConfiguration.
776
777         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
778         Ditto.
779
780         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
781         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
782         (+[WebView _removeUserScriptFromGroup:world:url:]):
783         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
784         (+[WebView _removeUserScriptsFromGroup:world:]):
785         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
786         (+[WebView _removeAllUserContentFromGroup:]):
787         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
788
789         (-[WebView setGroupName:]):
790         Set the user content controller to the new WebViewGroup's user content controller.
791
792 2014-11-21  Jer Noble  <jer.noble@apple.com>
793
794         Support multiple signatures of diagnostic logging.
795         https://bugs.webkit.org/show_bug.cgi?id=138690
796
797         Reviewed by Anders Carlsson.
798
799         Page::PageClients has been renamed PageConfiguration.
800
801         * WebView/WebView.mm:
802         (-[WebView _commonInitializationWithFrameName:groupName:]):
803         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
804
805 2014-11-21  Zalan Bujtas  <zalan@apple.com>
806
807         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
808         https://bugs.webkit.org/show_bug.cgi?id=138981
809
810         Reviewed by Simon Fraser.
811
812         * WebView/WebPreferenceKeysPrivate.h:
813         * WebView/WebPreferences.mm:
814         (+[WebPreferences initialize]):
815         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
816         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
817         * WebView/WebPreferencesPrivate.h:
818         * WebView/WebView.mm:
819         (-[WebView _preferencesChanged:]):
820
821 2014-11-21  Tim Horton  <timothy_horton@apple.com>
822
823         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
824         ​https://bugs.webkit.org/show_bug.cgi?id=138960
825         <rdar://problem/19056715>
826
827         Reviewed by Anders Carlsson.
828
829         * WebView/WebActionMenuController.mm:
830         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
831         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
832         Use DataDetectors SPI instead of an explicit blacklist.
833
834 2014-11-21  Tim Horton  <timothy_horton@apple.com>
835
836         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
837         https://bugs.webkit.org/show_bug.cgi?id=138960
838         <rdar://problem/19056715>
839
840         Reviewed by Beth Dakin.
841
842         * WebView/WebActionMenuController.mm:
843         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
844         Blacklist contact results, because they don't have useful menus. If we
845         bail before setting up _currentActionContext, we'll still allow fallthrough
846         to ordinary text actions, avoiding mysterious failure when a contact is detected.
847
848         This doesn't break the case that r176351 was intended to fix,
849         because in that case we were detecting e.g. addresses.
850
851 2014-11-21  Anders Carlsson  <andersca@apple.com>
852
853         Remove the Timer parameters from timer callbacks
854         https://bugs.webkit.org/show_bug.cgi?id=138974
855
856         Reviewed by Antti Koivisto.
857
858         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
859         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
860         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
861         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
862         * Plugins/WebNetscapePluginStream.h:
863         * Plugins/WebNetscapePluginStream.mm:
864         (WebNetscapePluginStream::WebNetscapePluginStream):
865         (WebNetscapePluginStream::deliverDataTimerFired):
866
867 2014-11-21  Anders Carlsson  <andersca@apple.com>
868
869         Make memoryCache() return a reference
870         https://bugs.webkit.org/show_bug.cgi?id=138939
871
872         Reviewed by Antti Koivisto.
873
874         * Misc/WebCache.mm:
875         (+[WebCache statistics]):
876         (+[WebCache emptyInMemoryResources]):
877         (+[WebCache sizeOfDeadResources:]):
878         (+[WebCache addImageToCache:forURL:forFrame:]):
879         (+[WebCache removeImageFromCacheForURL:forFrame:]):
880         (+[WebCache imageForURL:]):
881         (+[WebCache setDisabled:]):
882         (+[WebCache isDisabled]):
883         * WebView/WebView.mm:
884         (+[WebView _setCacheModel:]):
885
886 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
887
888         Remove the remaining vestiges of minimal-ui
889         https://bugs.webkit.org/show_bug.cgi?id=138890
890
891         Reviewed by Sam Weinig.
892
893         * History/WebHistoryItem.mm:
894         * History/WebHistoryItemPrivate.h:
895
896 2014-11-20  Tim Horton  <timothy_horton@apple.com>
897
898         Cancel DataDetectors menu earlier if we know it can't be presented
899         https://bugs.webkit.org/show_bug.cgi?id=138922
900         <rdar://problem/18950441>
901
902         Reviewed by Beth Dakin.
903
904         * WebView/WebActionMenuController.mm:
905         (-[WebActionMenuController prepareForMenu:withEvent:]):
906         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
907         and use a bigger hammer (removeAllItems).
908
909         (-[WebActionMenuController willOpenMenu:withEvent:]):
910         If we end up with a menu with no items, don't change selection or anything.
911
912 2014-11-20  Beth Dakin  <bdakin@apple.com>
913
914         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
915         https://bugs.webkit.org/show_bug.cgi?id=138568
916         -and corresponding-
917         rdar://problem/18904600
918
919         Reviewed by Tim Horton.
920
921         Skip images for lookup.
922         * WebView/WebActionMenuController.mm:
923         (performDictionaryLookupForRange):
924
925 2014-11-19  Beth Dakin  <bdakin@apple.com>
926
927         Invoking an action menu on a selection should result in the text menu
928         https://bugs.webkit.org/show_bug.cgi?id=138892
929         -and corresponding-
930         rdar://problem/18996776
931
932         Reviewed by Tim Horton.
933
934         * WebView/WebActionMenuController.mm:
935         (-[WebActionMenuController _defaultMenuItems]):
936
937 2014-11-19  Beth Dakin  <bdakin@apple.com>
938
939         Data detected results with no menu items should not fall through to regular text 
940         action menus
941         https://bugs.webkit.org/show_bug.cgi?id=138887
942         -and corresponding-
943         rdar://problem/18971616
944
945         Reviewed by Tim Horton.
946
947         * WebView/WebActionMenuController.mm:
948         (-[WebActionMenuController _defaultMenuItems]):
949
950 2014-11-19  Daniel Bates  <dabates@apple.com>
951
952         [iOS] Make WebKit build with public iOS SDK
953         https://bugs.webkit.org/show_bug.cgi?id=136863
954
955         Reviewed by David Kilzer.
956
957         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
958         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
959         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
960         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
961         may be used by Apple internal clients that do not include wtf/Platform.h.
962         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
963         private Foundation headers directly.
964         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
965         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
966         instead of including private CFNetwork headers directly. Also fixed up style and
967         ordering of header include directives.
968         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
969         CFNetwork headers directly. Also sort the #import directives.
970         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
971         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
972
973 2014-11-18  David Kilzer  <ddkilzer@apple.com>
974
975         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
976         <http://webkit.org/b/138813>
977
978         Reviewed by Mark Rowe.
979
980         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
981         selectors.
982
983 2014-11-18  Chris Dumez  <cdumez@apple.com>
984
985         Add a setting to toggle DOMTimer throttling support
986         https://bugs.webkit.org/show_bug.cgi?id=138844
987         <rdar://problem/19020874>
988
989         Reviewed by Andreas Kling.
990
991         Add a setting to disable DOM timers throttling, in order to help
992         developers determine if a specific issue is caused by timer
993         throttling.
994
995         * WebView/WebPreferenceKeysPrivate.h:
996         * WebView/WebPreferences.mm:
997         (+[WebPreferences initialize]):
998         (-[WebPreferences domTimersThrottlingEnabled]):
999         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
1000         * WebView/WebPreferencesPrivate.h:
1001         * WebView/WebView.mm:
1002         (-[WebView _preferencesChanged:]):
1003
1004 2014-11-18  Tim Horton  <timothy_horton@apple.com>
1005
1006         Avoid re-encoding action menu image data
1007         https://bugs.webkit.org/show_bug.cgi?id=138817
1008         <rdar://problem/18840382>
1009
1010         Reviewed by Anders Carlsson.
1011
1012         * WebView/WebActionMenuController.mm:
1013         (-[WebActionMenuController _defaultMenuItemsForImage:]):
1014         (-[WebActionMenuController _addImageToPhotos:]):
1015         Build a temporary filename from a UUID and the image's desired extension.
1016         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
1017         Build an image menu only if we have an image, URL, data, and extension.
1018
1019 2014-11-18  Daniel Bates  <dabates@apple.com>
1020
1021         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1022         SPI are not available in public SDK
1023         https://bugs.webkit.org/show_bug.cgi?id=138802
1024
1025         Reviewed by David Kilzer.
1026
1027         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
1028         libdispatch and MobileGestalt headers directly.
1029
1030         * WebView/WebView.mm:
1031
1032 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
1033
1034         Remove calls to deprecated NSMenu methods
1035         https://bugs.webkit.org/show_bug.cgi?id=138808.
1036
1037         Reviewed by Anders Carlsson.
1038
1039         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
1040
1041         * WebCoreSupport/PopupMenuMac.mm:
1042         (PopupMenuMac::populate):
1043
1044 2014-11-17  Daniel Bates  <dabates@apple.com>
1045
1046         Unreviewed, rolling out r176232.
1047
1048         Broke the Mac build. Will investigate offline.
1049
1050         Reverted changeset:
1051
1052         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
1053         MobileGestalt"
1054         https://bugs.webkit.org/show_bug.cgi?id=138802
1055         http://trac.webkit.org/changeset/176232
1056
1057 2014-11-17  Daniel Bates  <dabates@apple.com>
1058
1059         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1060         SPI are not available in public SDK
1061         https://bugs.webkit.org/show_bug.cgi?id=138802
1062
1063         Reviewed by David Kilzer.
1064
1065         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
1066         libdispatch and MobileGestalt headers directly.
1067
1068         * WebView/WebView.mm:
1069
1070 2014-11-17  Beth Dakin  <bdakin@apple.com>
1071
1072         Whitespace action menus should focus the HitTestResult and create an insertion 
1073         point
1074         https://bugs.webkit.org/show_bug.cgi?id=138786
1075         -and corresponding-
1076         rdar://problem/18944893
1077
1078         Reviewed by Tim Horton.
1079
1080         Whitespace menus should cause the HitTestResult to be focused, and they should set 
1081         the selection based on the HitTest location.
1082
1083         * WebView/WebActionMenuController.mm:
1084         (-[WebActionMenuController isMenuForTextContent]):
1085         (-[WebActionMenuController focusAndSelectHitTestResult]):
1086         (-[WebActionMenuController willOpenMenu:withEvent:]):
1087
1088 2014-11-17  Daniel Bates  <dabates@apple.com>
1089
1090         [iOS] QuartzCore SPI not available in public SDK
1091         https://bugs.webkit.org/show_bug.cgi?id=138751
1092
1093         Reviewed by David Kilzer.
1094
1095         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
1096
1097         * WebInspector/WebNodeHighlight.mm:
1098         * WebView/WebIndicateLayer.mm:
1099
1100 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
1101
1102         [iOS] allow host application to opt-out of alternate fullscreen
1103         https://bugs.webkit.org/show_bug.cgi?id=138787
1104
1105         Reviewed by Darin Adler.
1106
1107         * WebView/WebPreferenceKeysPrivate.h:
1108         * WebView/WebPreferences.mm:
1109         (+[WebPreferences initialize]):
1110         (-[WebPreferences allowsAlternateFullscreen]):
1111         (-[WebPreferences setAllowsAlternateFullscreen:]):
1112         * WebView/WebPreferencesPrivate.h:
1113         * WebView/WebView.mm:
1114         (-[WebView _preferencesChanged:]):
1115
1116 2014-11-16  Tim Horton  <timothy_horton@apple.com>
1117
1118         Use TextIndicator instead of the built in Lookup highlight
1119         https://bugs.webkit.org/show_bug.cgi?id=138775
1120         <rdar://problem/18953982>
1121
1122         Reviewed by Anders Carlsson.
1123
1124         * WebCoreSupport/WebSystemInterface.mm:
1125         (InitWebCoreSystemInterface):
1126         Remove a WKSI import.
1127
1128         * WebView/WebActionMenuController.mm:
1129         (-[WebActionMenuController _lookupText:]):
1130         (-[WebActionMenuController _createActionMenuItemForTag:]):
1131         Make use of the new Lookup SPI header.
1132         Disable the Lookup item if lookup is not available.
1133
1134 2014-11-15  Tim Horton  <timothy_horton@apple.com>
1135
1136         Implement data detectors and mailto action menus for WebKit1
1137         https://bugs.webkit.org/show_bug.cgi?id=138765
1138         <rdar://problem/18877535>
1139
1140         Reviewed by Beth Dakin.
1141
1142         * WebView/WebActionMenuController.h:
1143         * WebView/WebActionMenuController.mm:
1144         (-[WebActionMenuController willOpenMenu:withEvent:]):
1145         Tell DataDetectors that the menu is going to open.
1146         Select the text (or not) based on the number of items in the menu, just like WebKit2.
1147
1148         (-[WebActionMenuController didCloseMenu:withEvent:]):
1149         Tell DataDetectors that the menu closed.
1150
1151         (-[WebActionMenuController _defaultMenuItemsForLink]):
1152         Move these checks out of _defaultMenuItemsForLink, because we expect this
1153         to always return a complete link menu.
1154
1155         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
1156         Implement. More or less copied from WebKit2.
1157
1158         (-[WebActionMenuController _selectDataDetectedText]):
1159         Select the stashed range.
1160
1161         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1162         Implement. More or less copied from WebKit2.
1163         The yellow highlight isn't hooked up yet.
1164         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
1165
1166         (-[WebActionMenuController _selectLookupText]):
1167         Remove an unnecessary return.
1168
1169         (-[WebActionMenuController _defaultMenuItems]):
1170         Call into the two new menu types.
1171
1172         * WebView/WebUIDelegatePrivate.h:
1173
1174 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
1175
1176         Get rid of WebFontCache
1177         https://bugs.webkit.org/show_bug.cgi?id=134752
1178
1179         Reviewed by Dave Hyatt.
1180
1181         * WebView/WebHTMLView.mm:
1182
1183 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
1184
1185         Update some artwork for the legacy WebKit action menu
1186         https://bugs.webkit.org/show_bug.cgi?id=138758
1187         <rdar://problem/18989840>
1188
1189         * WebView/WebActionMenuController.mm:
1190         (webKitBundleImageNamed): Deleted.
1191         Fix the build.
1192
1193 2014-11-14  Tim Horton  <timothy_horton@apple.com>
1194
1195         Update some artwork for the legacy WebKit action menu
1196         https://bugs.webkit.org/show_bug.cgi?id=138758
1197         <rdar://problem/18989840>
1198
1199         Reviewed by Simon Fraser.
1200
1201         * WebView/WebActionMenuController.mm:
1202         (-[WebActionMenuController _createActionMenuItemForTag:]):
1203
1204 2014-11-14  Daniel Bates  <dabates@apple.com>
1205
1206         [iOS] NSFileManager and QuickLook SPI not available in public SDK
1207         https://bugs.webkit.org/show_bug.cgi?id=138742
1208
1209         Reviewed by Pratik Solanki.
1210
1211         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
1212
1213         * WebCoreSupport/WebFrameLoaderClient.mm:
1214
1215 2014-11-14  Beth Dakin  <bdakin@apple.com>
1216
1217         WK1: Webpage preview can come up in wrong location
1218         https://bugs.webkit.org/show_bug.cgi?id=138747
1219         -and corresponding-
1220         rdar://problem/18979004
1221
1222         Reviewed by Tim Horton.
1223
1224         Converting to window twice is bad.
1225         * WebView/WebActionMenuController.mm:
1226         (elementBoundingBoxInWindowCoordinatesFromNode):
1227         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1228         (elementBoundingBoxFromNode): Deleted.
1229
1230 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
1231
1232         Move FontMac and FontCacheMac off of WKSI
1233         https://bugs.webkit.org/show_bug.cgi?id=138633
1234
1235         Reviewed by Simon Fraser.
1236
1237         * WebCoreSupport/WebSystemInterface.mm:
1238         (InitWebCoreSystemInterface):
1239         * WebKit.order:
1240
1241 2014-11-13  Beth Dakin  <bdakin@apple.com>
1242
1243         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
1244         https://bugs.webkit.org/show_bug.cgi?id=138716
1245         -and corresponding-
1246         rdar://problem/18977222
1247
1248         Reviewed by Tim Horton.
1249
1250         It’s not necessary to use the WebElementDictionary for so many things now that we 
1251         are caching the HitTestResult. We should just use the HitTestResult.
1252
1253         * WebView/WebActionMenuController.mm:
1254         (-[WebActionMenuController prepareForMenu:withEvent:]):
1255         (-[WebActionMenuController _openURLFromActionMenu:]):
1256         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
1257         (elementBoundingBoxFromNode):
1258         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1259         (-[WebActionMenuController _defaultMenuItemsForLink]):
1260         (-[WebActionMenuController _defaultMenuItemsForImage]):
1261         (-[WebActionMenuController _defaultMenuItemsForVideo]):
1262         (-[WebActionMenuController _defaultMenuItemsForText]):
1263         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
1264         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
1265         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
1266         (-[WebActionMenuController _createActionMenuItemForTag:]):
1267         (-[WebActionMenuController _defaultMenuItems]):
1268         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
1269         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
1270         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
1271         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
1272         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
1273         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
1274         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
1275         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
1276         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
1277         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
1278
1279 2014-11-13  Daniel Bates  <dabates@apple.com>
1280
1281         [iOS] NSGeometry data types are not available in the public SDK
1282         https://bugs.webkit.org/show_bug.cgi?id=137536
1283
1284         Reviewed by David Kilzer.
1285
1286         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
1287         private header.
1288
1289         * DOM/WebDOMOperationsPrivate.h:
1290
1291 2014-11-13  Beth Dakin  <bdakin@apple.com>
1292
1293         WK1: Support default actions for video
1294         https://bugs.webkit.org/show_bug.cgi?id=138713
1295         -and corresponding-
1296         rdar://problem/18877520
1297
1298         Reviewed by Tim Horton.
1299
1300         Call setToNonShadowAncestor() for media HitTestResults.
1301         * WebView/WebActionMenuController.mm:
1302         (-[WebActionMenuController performHitTestAtPoint:]):
1303
1304         Default items and actions.
1305         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
1306         (-[WebActionMenuController _copyVideoURL:]):
1307         (-[WebActionMenuController _saveVideoToDownloads:]):
1308         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1309         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1310         * WebView/WebUIDelegatePrivate.h:
1311
1312 2014-11-13  Tim Horton  <timothy_horton@apple.com>
1313
1314         WK1: Update icon for Add to Reading List
1315         https://bugs.webkit.org/show_bug.cgi?id=138710
1316         <rdar://problem/18975774>
1317
1318         Reviewed by Beth Dakin.
1319
1320         * WebView/WebActionMenuController.mm:
1321         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1322         Use the right icon, matching WebKit2.
1323
1324 2014-11-12  Beth Dakin  <bdakin@apple.com>
1325
1326         WK1: Support default actions for images
1327         https://bugs.webkit.org/show_bug.cgi?id=138668
1328         -and corresponding-
1329         rdar://problem/18785434
1330
1331         Reviewed by Tim Horton.
1332
1333         * WebView/WebActionMenuController.h:
1334         * WebView/WebActionMenuController.mm:
1335         (-[WebActionMenuController didCloseMenu:withEvent:]):
1336         (-[WebActionMenuController _defaultMenuItemsForImage:]):
1337         (-[WebActionMenuController _copyImage:]):
1338         (temporaryPhotosDirectoryPath):
1339         (pathToPhotoOnDisk):
1340         (-[WebActionMenuController _canAddMediaToPhotos]):
1341         (-[WebActionMenuController _addImageToPhotos:]):
1342         (-[WebActionMenuController _saveImageToDownloads:]):
1343         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
1344         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
1345         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
1346         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1347         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1348         * WebView/WebUIDelegatePrivate.h:
1349
1350 2014-11-11  Beth Dakin  <bdakin@apple.com>
1351
1352         Action menu hit testing is not working properly with all WK1 apps
1353         https://bugs.webkit.org/show_bug.cgi?id=138643
1354         -and corresponding-
1355         rdar://problem/18949376
1356
1357         Reviewed by Tim Horton.
1358
1359         * WebView/WebActionMenuController.mm:
1360         (-[WebActionMenuController prepareForMenu:withEvent:]):
1361         (-[WebActionMenuController _lookupText:]):
1362
1363 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1364
1365         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
1366         https://bugs.webkit.org/show_bug.cgi?id=138623
1367
1368         Reviewed by Geoff Garen.
1369
1370         * WebCoreSupport/WebSystemInterface.mm:
1371         (InitWebCoreSystemInterface):
1372         * WebKit.order:
1373
1374 2014-11-11  Tim Horton  <timothy_horton@apple.com>
1375
1376         Localize strings for action menus
1377         https://bugs.webkit.org/show_bug.cgi?id=138591
1378         <rdar://problem/18815343>
1379
1380         Reviewed by Dan Bates.
1381
1382         * WebView/WebActionMenuController.mm:
1383         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1384         Make use of the new strings.
1385
1386 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1387
1388         Cleanup from r175379
1389         https://bugs.webkit.org/show_bug.cgi?id=138616
1390
1391         Reviewed by Simon Fraser.
1392
1393         * WebCoreSupport/WebSystemInterface.mm:
1394         (InitWebCoreSystemInterface):
1395         * WebKit.order:
1396
1397 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1398
1399         Move CTFontTransformGlyphs out from WKSI
1400         https://bugs.webkit.org/show_bug.cgi?id=138599
1401
1402         Reviewed by Simon Fraser.
1403
1404         * WebCoreSupport/WebSystemInterface.mm:
1405         (InitWebCoreSystemInterface):
1406         * WebKit.order:
1407
1408 2014-11-11  Dan Bernstein  <mitz@apple.com>
1409
1410         More iOS build fix.
1411
1412         * WebView/WebHTMLViewInternal.h:
1413
1414 2014-11-11  Dan Bernstein  <mitz@apple.com>
1415
1416         iOS build fix.
1417
1418         * WebView/WebHTMLView.mm:
1419
1420 2014-11-10  Beth Dakin  <bdakin@apple.com>
1421
1422         WK1: Support default actions for editable text with misspelled word
1423         https://bugs.webkit.org/show_bug.cgi?id=138590
1424         -and corresponding-
1425         rdar://problem/18877506
1426
1427         Reviewed by Tim Horton.
1428
1429         If there are misspelled word suggestions for editable text, create a new type of 
1430         menu with a spelling suggestion sub-menu.
1431
1432         * WebView/WebActionMenuController.mm:
1433         (-[WebActionMenuController isMenuForTextContent]):
1434         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
1435         (-[WebActionMenuController _changeSelectionToSuggestion:]):
1436         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1437         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1438         * WebView/WebHTMLView.mm:
1439         (-[WebHTMLView _changeSpellingToWord:]):
1440         * WebView/WebHTMLViewInternal.h:
1441         * WebView/WebUIDelegatePrivate.h:
1442
1443 2014-11-10  Beth Dakin  <bdakin@apple.com>
1444
1445         WK1: Support default actions for editable whitespace
1446         https://bugs.webkit.org/show_bug.cgi?id=138586
1447         -and corresponding-
1448         rdar://problem/18932048
1449
1450         Reviewed by Tim Horton.
1451
1452         New menu type. Just wants paste.
1453
1454         * WebView/WebActionMenuController.mm:
1455         (-[WebActionMenuController isMenuForTextContent]):
1456         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
1457         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1458         * WebView/WebUIDelegatePrivate.h:
1459
1460 2014-11-10  Beth Dakin  <bdakin@apple.com>
1461
1462         WK1: Support default actions for editable text
1463         https://bugs.webkit.org/show_bug.cgi?id=138580
1464         -and corresponding-
1465         rdar://problem/18877497
1466
1467         Reviewed by Tim Horton.
1468
1469         New menu type, and new action type for paste. 
1470
1471         * WebView/WebActionMenuController.mm:
1472         (-[WebActionMenuController isMenuForTextContent]):
1473         (-[WebActionMenuController willOpenMenu:withEvent:]):
1474         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
1475         (-[WebActionMenuController _paste:]):
1476         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1477         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1478         * WebView/WebUIDelegatePrivate.h:
1479
1480 2014-11-10  Beth Dakin  <bdakin@apple.com>
1481
1482         WK1: Text is getting selected even when an action menu fails to invoke
1483         https://bugs.webkit.org/show_bug.cgi?id=138576
1484         -and corresponding-
1485         rdar://problem/18931330
1486
1487         Reviewed by Tim Horton.
1488
1489         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
1490         * WebView/WebActionMenuController.h:
1491         * WebView/WebActionMenuController.mm:
1492         (-[WebActionMenuController prepareForMenu:withEvent:]):
1493         (-[WebActionMenuController willOpenMenu:withEvent:]):
1494
1495         _selectLookupText no longer needs to return a BOOL indicating success or failure.
1496         (-[WebActionMenuController _selectLookupText]):
1497         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1498
1499         Pass willOpenMenu: on to the controller.
1500         * WebView/WebView.mm:
1501         (-[WebView willOpenMenu:withEvent:]):
1502
1503 2014-11-10  Beth Dakin  <bdakin@apple.com>
1504
1505         Speculative build fix.
1506
1507         * WebView/WebActionMenuController.mm:
1508
1509 2014-11-10  Beth Dakin  <bdakin@apple.com>
1510
1511         Action menu initialization should be moved to _commonInitializationWithFrameName
1512         https://bugs.webkit.org/show_bug.cgi?id=138572
1513         -and corresponding-
1514         rdar://problem/18929733
1515
1516         Reviewed by Tim Horton.
1517
1518         * WebView/WebView.mm:
1519         (-[WebView _commonInitializationWithFrameName:groupName:]):
1520         (-[WebView _initWithFrame:frameName:groupName:]):
1521
1522 2014-11-10  Beth Dakin  <bdakin@apple.com>
1523
1524         WK1: Support default actions for read-only text
1525         https://bugs.webkit.org/show_bug.cgi?id=138552
1526         -and corresponding-
1527         rdar://problem/18877483
1528
1529         Reviewed by Tim Horton.
1530
1531         New WKSystemInterface functions that WebCore needs to use.
1532         * WebCoreSupport/WebSystemInterface.mm:
1533         (InitWebCoreSystemInterface):
1534
1535         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
1536         makes a lot of things easier.
1537         * WebView/WebActionMenuController.h:
1538         * WebView/WebActionMenuController.mm:
1539
1540         Perform the hit test ourselves instead of calling into WebView so that we can more 
1541         easily save the WebCore::HitTestResult for ourselves.
1542         (-[WebActionMenuController performHitTestAtPoint:]):
1543
1544         Clear selection for non-text menus.
1545         (-[WebActionMenuController prepareForMenu:withEvent:]):
1546
1547         Re-set the _type here just to be safe.
1548         (-[WebActionMenuController didCloseMenu:withEvent:]):
1549
1550         Moving this method to be next to the link actions so they can be within a pragma 
1551         mark.
1552         (-[WebActionMenuController _defaultMenuItemsForLink:]):
1553
1554         New method for default text actions — lookup and copy.
1555         (-[WebActionMenuController _defaultMenuItemsForText:]):
1556         (-[WebActionMenuController _copySelection:]):
1557         (-[WebActionMenuController _lookupText:]):
1558
1559         If there is not already a selection, invoking the action menu on text should 
1560         select the lookup text.
1561         (-[WebActionMenuController _selectLookupText]):
1562         (performDictionaryLookupForSelection):
1563         (performDictionaryLookupForRange):
1564
1565         Handle text now.
1566         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1567         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1568
1569         New enum values.
1570         * WebView/WebUIDelegatePrivate.h:
1571
1572         Pass didCloseMenu on to the controller.
1573         * WebView/WebView.mm:
1574         (-[WebView didCloseMenu:withEvent:]):
1575
1576 2014-11-09  Chris Dumez  <cdumez@apple.com>
1577
1578         Add a more correct way to compare floating point numbers and use it
1579         https://bugs.webkit.org/show_bug.cgi?id=138527
1580
1581         Reviewed by Darin Adler.
1582
1583         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
1584         to compare floating-point numbers.
1585
1586         * WebView/WebHTMLView.mm:
1587         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
1588
1589 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
1590
1591         Delete cookies between tests
1592         https://bugs.webkit.org/show_bug.cgi?id=138528
1593
1594         Reviewed by Sam Weinig.
1595
1596         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
1597         * WebView/WebPreferencesPrivate.h:
1598         Added an SPI for DumpRenderTree.
1599
1600 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
1601
1602         [iOS] Update optimized fullscreen media controls
1603         https://bugs.webkit.org/show_bug.cgi?id=138493
1604
1605         Reviewed by Brent Fulgham.
1606
1607         * WebCoreSupport/WebSystemInterface.mm:
1608         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
1609
1610 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
1611
1612         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
1613         https://bugs.webkit.org/show_bug.cgi?id=138443
1614
1615         Reviewed by Anders Carlsson.
1616
1617         Wrapping the dealloc method in its own autorelease pool avoids the problem of
1618         complex tear-downs leading to the WebView itself being added to an autorelease
1619         pool that is not drained until after the instance has been dealloc'd.
1620  
1621         * WebView/WebView.mm:
1622         (-[WebView dealloc]):
1623
1624 2014-11-05  Jer Noble  <jer.noble@apple.com>
1625
1626         De-templatize Timer
1627         https://bugs.webkit.org/show_bug.cgi?id=138450
1628
1629         Reviewed by Anders Carlsson.
1630
1631         Remove template specifiers from Timer.
1632
1633         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1634         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1635         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
1636         * Plugins/WebNetscapePluginStream.h:
1637         * Plugins/WebNetscapePluginStream.mm:
1638         (WebNetscapePluginStream::deliverDataTimerFired):
1639
1640 2014-11-05  Dan Bernstein  <mitz@apple.com>
1641
1642         Remove the unused deletion UI feature
1643         https://bugs.webkit.org/show_bug.cgi?id=138442
1644
1645         Rubber-stamped by Alexey Proskuryakov.
1646
1647         * DefaultDelegates/WebDefaultEditingDelegate.m:
1648         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
1649         * WebCoreSupport/WebEditorClient.h:
1650         * WebCoreSupport/WebEditorClient.mm:
1651         (WebEditorClient::shouldShowDeleteInterface): Deleted.
1652         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
1653         -webView:shouldShowDeleteInterfaceForElement:.
1654
1655 2014-11-03  Dean Jackson  <dino@apple.com>
1656
1657         Add ENABLE_FILTERS_LEVEL_2 feature guard.
1658         https://bugs.webkit.org/show_bug.cgi?id=138362
1659
1660         Reviewed by Tim Horton.
1661
1662         Add a new feature define for Level 2 of CSS Filters.
1663         http://dev.w3.org/fxtf/filters-2/
1664
1665         * Configurations/FeatureDefines.xcconfig:
1666
1667 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
1668
1669         Add button and enable optimized fullscreen.
1670         https://bugs.webkit.org/show_bug.cgi?id=138351
1671
1672         Reviewed by Eric Carlson.
1673
1674         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
1675
1676         * WebCoreSupport/WebSystemInterface.mm:
1677         (InitWebCoreSystemInterface): added
1678
1679 2014-11-04  Chris Dumez  <cdumez@apple.com>
1680
1681         Add ptr() method to Ref class
1682         https://bugs.webkit.org/show_bug.cgi?id=138361
1683
1684         Reviewed by Darin Adler.
1685
1686         Use the new Ref::ptr() method.
1687
1688         * WebView/WebFrame.mm:
1689         (-[WebFrame _setTypingStyle:withUndoAction:]):
1690         * WebView/WebHTMLView.mm:
1691         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
1692         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
1693         * WebView/WebView.mm:
1694         (-[WebView applyStyle:]):
1695
1696 2014-11-04  Darin Adler  <darin@apple.com>
1697
1698         Eliminate ResourceBuffer and use SharedBuffer directly instead
1699         https://bugs.webkit.org/show_bug.cgi?id=138174
1700
1701         Reviewed by Antti Koivisto.
1702
1703         * WebView/WebDataSource.mm:
1704         (-[WebDataSource data]): Use SharedBuffer directly.
1705         * WebView/WebHTMLView.mm:
1706         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1707
1708 2014-11-03  Commit Queue  <commit-queue@webkit.org>
1709
1710         Unreviewed, rolling out r175406, r175413, and r175423.
1711         https://bugs.webkit.org/show_bug.cgi?id=138327
1712
1713         Multipart tests are still broken (Requested by ap on #webkit).
1714
1715         Reverted changesets:
1716
1717         "Eliminate ResourceBuffer and use SharedBuffer directly
1718         instead"
1719         https://bugs.webkit.org/show_bug.cgi?id=138174
1720         http://trac.webkit.org/changeset/175406
1721
1722         "Unreviewed, iOS build fix since 175406."
1723         http://trac.webkit.org/changeset/175413
1724
1725         "Fix assertion in CachedResource::addDataBuffer"
1726         http://trac.webkit.org/changeset/175423
1727
1728 2014-10-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1729
1730         Use std::unique_ptr for TypeCountSet
1731         https://bugs.webkit.org/show_bug.cgi?id=138242
1732
1733         Reviewed by Andreas Kling.
1734
1735         * Misc/WebCoreStatistics.mm:
1736         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr.
1737         (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto.
1738
1739 2014-10-31  Beth Dakin  <bdakin@apple.com>
1740
1741         Use system art for action menus when possible
1742         https://bugs.webkit.org/show_bug.cgi?id=138260
1743
1744         Reviewed by Tim Horton.
1745
1746         * WebView/WebActionMenuController.mm:
1747         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1748
1749 2014-10-30  Darin Adler  <darin@apple.com>
1750
1751         Eliminate ResourceBuffer and use SharedBuffer directly instead
1752         https://bugs.webkit.org/show_bug.cgi?id=138174
1753
1754         Reviewed by Antti Koivisto.
1755
1756         * WebView/WebDataSource.mm:
1757         (-[WebDataSource data]): Use SharedBuffer directly.
1758         * WebView/WebHTMLView.mm:
1759         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1760
1761 2014-10-30  Jer Noble  <jer.noble@apple.com>
1762
1763         [EME] Add Setting for accessing storage location for MediaKeys data
1764         https://bugs.webkit.org/show_bug.cgi?id=138147
1765
1766         Reviewed by Brady Eidson.
1767
1768         * WebView/WebPreferenceKeysPrivate.h:
1769         * WebView/WebPreferences.mm:
1770         (+[WebPreferences initialize]): Set default location.
1771         (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor.
1772         (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter.
1773         * WebView/WebPreferencesPrivate.h:
1774         * WebView/WebView.mm:
1775         (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings.
1776
1777 2014-10-30  Dana Burkart  <dburkart@apple.com>
1778
1779         <rdar://problem/18821260> Prepare for the mysterious future
1780
1781         Reviewed by Lucas Forschler.
1782
1783         * Configurations/Base.xcconfig:
1784         * Configurations/DebugRelease.xcconfig:
1785         * Configurations/FeatureDefines.xcconfig:
1786         * Configurations/Version.xcconfig:
1787
1788 2014-10-28  Jeremy Jones  <jeremyj@apple.com>
1789
1790         Add optimized fullscreen mode.
1791         https://bugs.webkit.org/show_bug.cgi?id=138044
1792
1793         Reviewed by Jer Noble.
1794
1795         Enable different types of fullscreen video behavior.
1796         Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
1797
1798         * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
1799         * WebCoreSupport/WebChromeClient.mm:
1800         (WebChromeClient::enterVideoFullscreenForVideoElement): ditto
1801         * WebView/WebView.mm:
1802         (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
1803         (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.
1804         * WebView/WebViewInternal.h: ditto
1805
1806 2014-10-27  Beth Dakin  <bdakin@apple.com>
1807
1808         Provide a way for WebKit1 clients to override default action menu items
1809         https://bugs.webkit.org/show_bug.cgi?id=138066
1810         -and corresponding-
1811         rdar://problem/18451638
1812
1813         Reviewed by Anders Carlsson.
1814
1815         WebActionMenuController now has an ivar for the WebActionMenuType so that it can 
1816         send that along to clients customizing the menu.
1817         * WebView/WebActionMenuController.h:
1818         * WebView/WebActionMenuController.mm:
1819         (-[WebActionMenuController prepareForMenu:withEvent:]):
1820         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1821
1822         New enum and new SPI to customize menus.
1823         * WebView/WebUIDelegatePrivate.h:
1824
1825 2014-10-24  Benjamin Poulain  <bpoulain@apple.com>
1826
1827         Fix the iOS build
1828
1829         * Configurations/WebKitLegacy.xcconfig:
1830         * WebView/WebView.mm:
1831
1832 2014-10-24  Beth Dakin  <bdakin@apple.com>
1833
1834         Build fix.
1835
1836         * WebView/WebActionMenuController.mm:
1837         (-[WebActionMenuController _openURLFromActionMenu:]):
1838         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
1839         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1840
1841 2014-10-24  Beth Dakin  <bdakin@apple.com>
1842
1843         WebKit1 should support action menus
1844         https://bugs.webkit.org/show_bug.cgi?id=138032
1845
1846         Reviewed by Tim Horton.
1847
1848         This patch adds basic support for action menus and adds actions for links.
1849
1850         Helper class takes care of all of the action menu work. WebView will forward the 
1851         prepareForMenu: message, and then the helper class takes it from there.
1852         * WebView/WebActionMenuController.h: Added.
1853         * WebView/WebActionMenuController.mm: Added.
1854         (-[WebActionMenuController webViewClosed]):
1855         (-[WebActionMenuController prepareForMenu:withEvent:]):
1856
1857         Selectors for link actions.
1858         (-[WebActionMenuController _openURLFromActionMenu:]):
1859         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
1860         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
1861         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1862         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1863         (webKitBundleImageNamed):
1864         (-[WebActionMenuController _defaultMenuItemsForLink:]):
1865         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1866
1867         Tags for the action menu items.
1868         * WebView/WebUIDelegatePrivate.h:
1869         * WebView/WebView.mm:
1870
1871         Set the action menu if possible and create the controller.
1872         (-[WebView _initWithFrame:frameName:groupName:]):
1873         (-[WebView _close]):
1874         (-[WebView prepareForMenu:withEvent:]):
1875
1876         WebViewData stores the WebActionMenuHelper
1877         * WebView/WebViewData.h:
1878         * WebView/WebViewData.mm:
1879         (-[WebViewPrivate dealloc]):
1880
1881 2014-10-23  Joseph Pecoraro  <pecoraro@apple.com>
1882
1883         Web Inspector: Provide a way to have alternate inspector agents
1884         https://bugs.webkit.org/show_bug.cgi?id=137901
1885
1886         Reviewed by Brian Burg.
1887
1888         * Configurations/FeatureDefines.xcconfig:
1889
1890 2014-10-23  Tim Horton  <timothy_horton@apple.com>
1891
1892         Add some SPI headers for NSExtension and NSSharingService{Picker}
1893         https://bugs.webkit.org/show_bug.cgi?id=138027
1894
1895         Reviewed by Anders Carlsson.
1896
1897         * Misc/WebSharingServicePickerController.h:
1898         * Misc/WebSharingServicePickerController.mm:
1899         * WebCoreSupport/WebSelectionServiceController.mm:
1900         * WebCoreSupport/WebContextMenuClient.mm:
1901         Fix a sorting issue.
1902         Replace redefinitions with SPI header #imports.
1903
1904 2014-10-23  Tim Horton  <timothy_horton@apple.com>
1905
1906         Crashes under WebSelectionServiceController::hasRelevantSelectionServices
1907         https://bugs.webkit.org/show_bug.cgi?id=138013
1908
1909         Reviewed by Dan Bernstein.
1910
1911         * WebCoreSupport/WebSelectionServiceController.mm:
1912         (WebSelectionServiceController::hasRelevantSelectionServices):
1913         Don't adopt this autoreleased object.
1914
1915 2014-10-22  Chris Dumez  <cdumez@apple.com>
1916
1917         [Mac][WK2] Fix applicationIsSafari() detection
1918         https://bugs.webkit.org/show_bug.cgi?id=137893
1919
1920         Reviewed by Alexey Proskuryakov.
1921
1922         Provide an implementation for FrameLoaderClient's new
1923         needsQuickLookResourceCachingQuirks() that returns
1924         a static flag initialized using
1925         QuickLookMac::computeNeedsQuickLookResourceCachingQuirks().
1926
1927         * WebCoreSupport/WebFrameLoaderClient.h:
1928         * WebCoreSupport/WebFrameLoaderClient.mm:
1929
1930 2014-10-20  Chris Dumez  <cdumez@apple.com>
1931
1932         ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition
1933         https://bugs.webkit.org/show_bug.cgi?id=137797
1934
1935         Reviewed by Darin Adler.
1936
1937         Call ResourceRequest::setDomainForPartitionName() instead of
1938         setPartitionName() as the argument is a domain, not a valid
1939         partition name.
1940
1941         * Misc/WebCache.mm:
1942         (+[WebCache addImageToCache:forURL:forFrame:]):
1943         (+[WebCache removeImageFromCacheForURL:forFrame:]):
1944
1945 2014-10-20  Andy Estes  <aestes@apple.com>
1946
1947         Fix the iOS build.
1948
1949         * WebView/WebFrame.mm:
1950         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1951         (-[WebFrame dictationResultMetadataForRange:]):
1952
1953 2014-10-19  Chris Dumez  <cdumez@apple.com>
1954
1955         Use is<>() / downcast<>() for all remaining RenderObject subclasses
1956         https://bugs.webkit.org/show_bug.cgi?id=137845
1957
1958         Reviewed by Darin Adler.
1959
1960         Use is<>() / downcast<>() for all remaining RenderObject subclasses and 
1961         clean up the surrounding code.
1962
1963         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1964         (-[WebHostedNetscapePluginView pluginHostDied]):
1965         * Plugins/WebBaseNetscapePluginView.mm:
1966         (-[WebBaseNetscapePluginView _windowClipRect]):
1967         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
1968         * WebCoreSupport/WebFrameLoaderClient.mm:
1969         (WebFrameLoaderClient::createPlugin):
1970         (WebFrameLoaderClient::createJavaAppletWidget):
1971
1972 2014-10-17  Tim Horton  <timothy_horton@apple.com>
1973
1974         Build fix for 32-bit Yosemite
1975
1976         * WebCoreSupport/WebContextMenuClient.mm:
1977         (WebContextMenuClient::contextMenuForEvent):
1978         Avoid using NSItemProvider in 32-bit, because it doesn't exist.
1979
1980 2014-10-17  Chris Dumez  <cdumez@apple.com>
1981
1982         Use is<>() / downcast<>() for RenderBox
1983         https://bugs.webkit.org/show_bug.cgi?id=137804
1984
1985         Reviewed by Andreas Kling.
1986
1987         Use is<>() / downcast<>() for RenderBox and clean up the surrounding
1988         code.
1989
1990         * WebCoreSupport/WebContextMenuClient.mm:
1991         (WebContextMenuClient::clientFloatRectForNode):
1992         * WebView/WebFrame.mm:
1993         (-[WebFrame renderedSizeOfNode:constrainedToWidth:]):
1994
1995 2014-10-17  Tim Horton  <timothy_horton@apple.com>
1996
1997         Fix the build with the public SDK.
1998
1999         * WebCoreSupport/WebSelectionServiceController.mm:
2000         We should transition all this SPI to real SPI headers as soon as possible.
2001
2002 2014-10-16  Tim Horton  <timothy_horton@apple.com>
2003
2004         Implement selection services menu for Legacy WebKit
2005         https://bugs.webkit.org/show_bug.cgi?id=137582
2006         <rdar://problem/18604241>
2007
2008         Reviewed by Brady Eidson.
2009
2010         * Misc/WebSharingServicePickerController.h:
2011         Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
2012         Add WebSharingServicePickerClient, which other classes can implement
2013         instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
2014         Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.
2015
2016         * Misc/WebSharingServicePickerController.mm:
2017         Pass in NSSharingServicePickerStyle, so that clients can specify the style.
2018
2019         (-[WebSharingServicePickerController clear]):
2020         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
2021         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
2022         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
2023         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
2024         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2025         Make use of WebSharingServicePickerClient.
2026
2027         (-[WebSharingServicePickerController sharingService:didShareItems:]):
2028         If we're returned a NSAttributedString, paste it on top of the current selection,
2029         similar to what the WebKit2 implementation currently does.
2030         
2031         * WebCoreSupport/WebChromeClient.h:
2032         * WebCoreSupport/WebChromeClient.mm:
2033         (WebChromeClient::handleTelephoneNumberClick):
2034         (WebChromeClient::handleSelectionServiceClick):
2035         (WebChromeClient::hasRelevantSelectionServices):
2036         Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.
2037
2038         * WebCoreSupport/WebContextMenuClient.h:
2039         * WebCoreSupport/WebContextMenuClient.mm:
2040         (WebContextMenuClient::sharingServicePickerWillBeDestroyed):
2041         (WebContextMenuClient::pageForSharingServicePicker):
2042         (WebContextMenuClient::windowForSharingServicePicker):
2043         (WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
2044         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
2045         (WebContextMenuClient::contextMenuForEvent):
2046         (WebContextMenuClient::screenRectForHitTestNode): Deleted.
2047         (WebContextMenuClient::renderedImageForControlledImage): Deleted.
2048         (WebContextMenuClient::clearSharingServicePickerController): Deleted.
2049         Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
2050         having WebSharingServicePickerController tightly bound to it.
2051         Make an NSItemProvider array when instantiating WebSharingServicePickerController
2052         instead of handing it data directly.
2053
2054         * WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
2055         * WebCoreSupport/WebSelectionServiceController.mm: Added.
2056         (WebSelectionServiceController::WebSelectionServiceController):
2057         Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
2058         for selection services.
2059
2060         (WebSelectionServiceController::handleSelectionServiceClick):
2061         Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.
2062
2063         (hasCompatibleServicesForItems):
2064         (WebSelectionServiceController::hasRelevantSelectionServices):
2065         Determine whether or not services are available.
2066
2067         (WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
2068         (WebSelectionServiceController::pageForSharingServicePicker):
2069         (WebSelectionServiceController::windowForSharingServicePicker):
2070         Implement the rest of the WebSharingServicePickerClient overrides.
2071
2072         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
2073         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
2074         These are only useful for image sharing services, so we don't need to
2075         implement them (WebContextMenuClient does, on the other hand).
2076
2077         * WebView/WebView.mm:
2078         (-[WebView _selectionServiceController]):
2079         * WebView/WebViewData.h:
2080         * WebView/WebViewData.mm:
2081         * WebView/WebViewInternal.h:
2082         Keep a WebSelectionServiceController.
2083
2084 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2085
2086         Improve debug description of WAKViews
2087         https://bugs.webkit.org/show_bug.cgi?id=137716
2088
2089         Reviewed by Simon Fraser.
2090
2091         * WebView/WebView.mm:
2092         (-[WebView _touchEventRegions]): Adding a comment.
2093
2094 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2095
2096         Addressing post-review comment.
2097         https://bugs.webkit.org/show_bug.cgi?id=137550
2098
2099         Unreviewed.
2100
2101         * WebView/WebHTMLView.mm:
2102         (fontNameForDescription):
2103         (-[WebHTMLView _addToStyle:fontA:fontB:]):
2104
2105 2014-10-14  Chris Dumez  <cdumez@apple.com>
2106
2107         Use is<>() / downcast<>() for RenderImage
2108         https://bugs.webkit.org/show_bug.cgi?id=137683
2109
2110         Reviewed by Mihnea Ovidenie.
2111
2112         Use is<>() / downcast<>() for RenderImage.
2113
2114         * Misc/WebNSPasteboardExtras.mm:
2115         (imageFromElement):
2116         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2117
2118 2014-10-10  Daniel Bates  <dabates@apple.com>
2119
2120         Remove unused classes WebRender{Node, Layer}
2121         https://bugs.webkit.org/show_bug.cgi?id=137628
2122
2123         Reviewed by Simon Fraser.
2124
2125         We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
2126         For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.
2127
2128         * Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list
2129         of excluded source files when building for iOS.
2130         * WebKit.exp: Remove symbol for WebRenderLayer.
2131         * WebKit.mac.exp: Remove symbol for WebRenderNode.
2132         * WebView/WebRenderLayer.h: Removed.
2133         * WebView/WebRenderLayer.mm: Removed.
2134         * WebView/WebRenderNode.h: Removed.
2135         * WebView/WebRenderNode.mm: Removed.
2136
2137 2014-10-10  Chris Dumez  <cdumez@apple.com>
2138
2139         Use is<>() / downcast<>() for RenderBoxModelObject
2140         https://bugs.webkit.org/show_bug.cgi?id=137587
2141
2142         Reviewed by Mihnea Ovidenie.
2143
2144         Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
2145         surrounding code.
2146
2147         * Plugins/WebBaseNetscapePluginView.mm:
2148         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
2149         * WebView/WebRenderLayer.mm:
2150         (-[WebRenderLayer initWithWebFrame:]):
2151
2152 2014-10-09  Dean Jackson  <dino@apple.com>
2153
2154         Remove ENABLE_CSS3_CONDITIONAL_RULES
2155         https://bugs.webkit.org/show_bug.cgi?id=137571
2156
2157         Reviewed by Simon Fraser.
2158
2159         * Configurations/FeatureDefines.xcconfig:
2160
2161 2014-10-09  Tim Horton  <timothy_horton@apple.com>
2162
2163         Add a WebKit1 preference for selection services
2164         https://bugs.webkit.org/show_bug.cgi?id=137498
2165         <rdar://problem/18572699>
2166
2167         Reviewed by Simon Fraser.
2168
2169         * WebView/WebPreferenceKeysPrivate.h:
2170         * WebView/WebPreferences.mm:
2171         (+[WebPreferences initialize]):
2172         (-[WebPreferences serviceControlsEnabled]):
2173         (-[WebPreferences setServiceControlsEnabled:]):
2174         * WebView/WebPreferencesPrivate.h:
2175         * WebView/WebView.mm:
2176         (-[WebView _preferencesChanged:]):
2177         Add and plumb the preference.
2178
2179 2014-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
2180
2181         Remove second-to-last client of WebFontCache
2182         https://bugs.webkit.org/show_bug.cgi?id=137550
2183
2184         Reviewed by Darin Adler.
2185
2186         Use FontCache::getCachedFontData() instead of WebFontCache.
2187
2188         * WebView/WebHTMLView.mm:
2189         (-[WebHTMLView _addToStyle:fontA:fontB:]):
2190
2191 2014-10-09  Chris Dumez  <cdumez@apple.com>
2192
2193         Use is<>() / downcast<>() for Widget subclasses
2194         https://bugs.webkit.org/show_bug.cgi?id=137549
2195
2196         Reviewed by Darin Adler.
2197
2198         Use is<>() / downcast<>() for Widget subclasses and clean up the
2199         surrounding code.
2200
2201         * WebView/WebRenderNode.mm:
2202         (copyRenderNode):
2203         * WebView/WebView.mm:
2204         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
2205
2206 2014-10-07  Christophe Dumez  <cdumez@apple.com>
2207
2208         Use is<>() / downcast<>() for RenderText / RenderTextFragment
2209         https://bugs.webkit.org/show_bug.cgi?id=137476
2210
2211         Reviewed by Darin Adler.
2212
2213         * WebView/WebRenderNode.mm:
2214         (copyRenderNode):
2215
2216 2014-10-06  Dan Bernstein  <mitz@apple.com>
2217
2218         Build fix.
2219
2220         * Misc/WebCache.mm:
2221         (+[WebCache imageForURL:]):
2222
2223 2014-10-06  Chris Dumez  <cdumez@apple.com>
2224
2225         Unreviewed build fix after r174333.
2226
2227         Forgot explicit WebCore:: namespace.
2228
2229         * Misc/WebCache.mm:
2230         (+[WebCache imageForURL:]):
2231
2232 2014-10-05  Christophe Dumez  <cdumez@apple.com>
2233
2234         Use is<>() / downcast<>() for CachedResource subclasses
2235         https://bugs.webkit.org/show_bug.cgi?id=137431
2236
2237         Reviewed by Benjamin Poulain.
2238
2239         Use is<>() / downcast<>() for CachedResource subclasses.
2240
2241         * Misc/WebCache.mm:
2242         (+[WebCache imageForURL:]):
2243
2244 2014-10-02  Daniel Bates  <dabates@apple.com>
2245
2246         Use version number 101000 instead of 10100 for OS X Yosemite
2247         https://bugs.webkit.org/show_bug.cgi?id=137372
2248
2249         Reviewed by Mark Rowe.
2250
2251         The version number for OS X Yosemite is 101000.
2252
2253         * WebView/WebView.mm:
2254         (-[WebView _preferencesChanged:]):
2255
2256 2014-10-02  Tim Horton  <timothy_horton@apple.com>
2257
2258         Move PageOverlay[Controller] to WebCore
2259         https://bugs.webkit.org/show_bug.cgi?id=137164
2260         <rdar://problem/18508258>
2261
2262         Reviewed by Anders Carlsson.
2263
2264         * WebCoreSupport/WebChromeClient.h:
2265         * WebCoreSupport/WebChromeClient.mm:
2266         (WebChromeClient::attachViewOverlayGraphicsLayer):
2267         Add an empty ChromeClient override.
2268
2269 2014-10-01  Christophe Dumez  <cdumez@apple.com>
2270
2271         Have is<>(T*) function do a null check on the pointer argument
2272         https://bugs.webkit.org/show_bug.cgi?id=137333
2273
2274         Reviewed by Gavin Barraclough.
2275
2276         Have is<>(T*) function do a null check on the argument instead of a
2277         simple assertion. This makes sense for 2 reasons:
2278         1. It is more consistent with downcast<>(T*), which will succeed even
2279            if the argument is a nullptr.
2280         2. It simplifies the code a bit as it gets rid of a lot of explicit
2281            null checks.
2282
2283         * WebCoreSupport/WebChromeClient.mm:
2284         (WebChromeClient::focusedElementChanged):
2285         * WebCoreSupport/WebEditorClient.mm:
2286         (WebEditorClient::textFieldDidBeginEditing):
2287         (WebEditorClient::textFieldDidEndEditing):
2288         (WebEditorClient::textDidChangeInTextField):
2289         (WebEditorClient::doTextFieldCommandFromEvent):
2290         (WebEditorClient::textWillBeDeletedInTextField):
2291         (WebEditorClient::textDidChangeInTextArea):
2292         * WebView/WebHTMLRepresentation.mm:
2293         (inputElementFromDOMElement):
2294         (searchForLabelsBeforeElement):
2295         * WebView/WebRenderLayer.mm:
2296         (+[WebRenderLayer nameForLayer:]):
2297
2298 2014-10-01  Mark Rowe  <mrowe@apple.com>
2299
2300         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
2301
2302         Reviewed by Dan Bernstein.
2303
2304         * Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite.
2305
2306 2014-09-30  Chris Dumez  <cdumez@apple.com>
2307
2308         Use is<>() / downcast<>() for Element
2309         https://bugs.webkit.org/show_bug.cgi?id=137241
2310
2311         Reviewed by Andreas Kling.
2312
2313         Use is<>() / downcast<>() for Element instead of isElementNode() /
2314         toElement().
2315
2316         * WebView/WebRenderLayer.mm:
2317         (+[WebRenderLayer nameForLayer:]):
2318
2319 2014-09-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2320
2321         Move ColorInputType class to std::unique_ptr
2322         https://bugs.webkit.org/show_bug.cgi?id=137173
2323
2324         Reviewed by Darin Adler.
2325
2326         Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr.
2327         Child classes follow this change as well.
2328
2329         * WebCoreSupport/WebChromeClient.h:
2330         * WebCoreSupport/WebChromeClient.mm:
2331         (WebChromeClient::createColorChooser):
2332
2333 2014-09-24  Christophe Dumez  <cdumez@apple.com>
2334
2335         Add initial is<>() / downcast<>() support for any type of Nodes
2336         https://bugs.webkit.org/show_bug.cgi?id=137056
2337
2338         Reviewed by Benjamin Poulain.
2339
2340         Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
2341         instead of isFormControlElement() / toHTMLFormControlElement().
2342
2343         * WebView/WebHTMLRepresentation.mm:
2344         (searchForLabelsBeforeElement):
2345
2346 2014-09-24  Christophe Dumez  <cdumez@apple.com>
2347
2348         Use is<HTML*Element>() instead of isHTML*Element() - Part 1
2349         https://bugs.webkit.org/show_bug.cgi?id=137068
2350
2351         Reviewed by Ryosuke Niwa.
2352
2353         Start using is<HTML*Element>() instead of isHTML*Element().
2354         Remaining usages will be updated in a follow-up patch to
2355         reduce the size of the change.
2356
2357         * WebCoreSupport/WebChromeClient.mm:
2358         (WebChromeClient::focusedElementChanged):
2359         * WebCoreSupport/WebEditorClient.mm:
2360         (WebEditorClient::textFieldDidBeginEditing):
2361         (WebEditorClient::textFieldDidEndEditing):
2362         (WebEditorClient::textDidChangeInTextField):
2363         (WebEditorClient::doTextFieldCommandFromEvent):
2364         (WebEditorClient::textWillBeDeletedInTextField):
2365         (WebEditorClient::textDidChangeInTextArea):
2366         * WebView/WebHTMLRepresentation.mm:
2367         (inputElementFromDOMElement):
2368
2369 2014-09-21  Timothy Hatcher  <timothy@apple.com>
2370
2371         Make the Web Inspector use a separate web process.
2372
2373         https://bugs.webkit.org/show_bug.cgi?id=135120
2374
2375         Reviewed by Anders Carlsson.
2376
2377         * WebCoreSupport/WebInspectorClient.h:
2378         * WebCoreSupport/WebInspectorClient.mm:
2379         (WebInspectorClient::WebInspectorClient):
2380         (WebInspectorClient::openInspectorFrontend):
2381         (WebInspectorClient::releaseFrontend):
2382         Own WebInspectorFrontendClient instead of moving it.
2383
2384 2014-09-23  Chris Dumez  <cdumez@apple.com>
2385
2386         Use downcast<HTML*Element>() instead of toHTML*Element()
2387         https://bugs.webkit.org/show_bug.cgi?id=137007
2388
2389         Reviewed by Benjamin Poulain.
2390
2391         Use downcast<HTML*Element>() instead of toHTML*Element().
2392
2393         * DOM/WebDOMOperations.mm:
2394         (-[DOMHTMLInputElement _setAutofilled:]):
2395         * WebCoreSupport/WebChromeClient.mm:
2396         (WebChromeClient::focusedElementChanged):
2397         * WebCoreSupport/WebEditorClient.mm:
2398         (WebEditorClient::textFieldDidBeginEditing):
2399         (WebEditorClient::textFieldDidEndEditing):
2400         (WebEditorClient::textDidChangeInTextField):
2401         (WebEditorClient::doTextFieldCommandFromEvent):
2402         (WebEditorClient::textWillBeDeletedInTextField):
2403         (WebEditorClient::textDidChangeInTextArea):
2404         * WebView/WebHTMLRepresentation.mm:
2405         (inputElementFromDOMElement):
2406
2407 2014-09-21  Chris Dumez  <cdumez@apple.com>
2408
2409         Generate Element casting helper functions
2410         https://bugs.webkit.org/show_bug.cgi?id=136839
2411
2412         Reviewed by Darin Adler.
2413
2414         Use JSXXX::toWrapped() instead of toXXX() function.
2415
2416         * DOM/WebDOMOperations.mm:
2417         * WebView/WebView.mm:
2418         (-[WebView _notificationIDForTesting:]):
2419
2420 2014-09-21  Joseph Pecoraro  <pecoraro@apple.com>
2421
2422         Leak: WebNotificationPrivate ObjC leaks seen on leaks bot
2423         https://bugs.webkit.org/show_bug.cgi?id=136972
2424
2425         Reviewed by Darin Adler.
2426
2427         * WebView/WebNotification.h:
2428         * WebView/WebNotification.mm:
2429         (-[WebNotification initWithCoreNotification:notificationID:]):
2430         Switch to RetainPtr and adopt into _private to ensure when we are
2431         deallocated that _private will get deallocated.
2432
2433 2014-09-19  Dean Jackson  <dino@apple.com>
2434
2435         Multithreaded WebGL is a bad idea - remove it
2436         https://bugs.webkit.org/show_bug.cgi?id=136964
2437         <rdar://problem/18399858>
2438
2439         Reviewed by Brent Fulgham.
2440
2441         Remove the setting to allow multithreaded WebGL.
2442
2443         * WebView/WebPreferenceKeysPrivate.h:
2444         * WebView/WebPreferences.mm:
2445         (+[WebPreferences initialize]):
2446         (-[WebPreferences multithreadedWebGLEnabled]): Deleted.
2447         (-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted.
2448         * WebView/WebPreferencesPrivate.h:
2449         * WebView/WebView.mm:
2450         (-[WebView _preferencesChanged:]):
2451
2452 2014-09-19  Daniel Bates  <dabates@apple.com>
2453
2454         Always assume internal SDK when building configuration Production
2455         https://bugs.webkit.org/show_bug.cgi?id=136925
2456         <rdar://problem/18362399>
2457
2458         Reviewed by Dan Bernstein.
2459
2460         As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
2461         and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.
2462
2463         * Configurations/Base.xcconfig:
2464
2465 2014-09-17  Daniel Bates  <dabates@apple.com>
2466
2467         Unreviewed, rolling out r173695.
2468
2469         Broke building third-party Legacy WebKit apps; will
2470         investigate offline
2471
2472         Reverted changeset:
2473
2474         "[iOS] Make WebCore build with public iOS SDK"
2475         https://bugs.webkit.org/show_bug.cgi?id=136487
2476         http://trac.webkit.org/changeset/173695
2477
2478 2014-09-17  Daniel Bates  <dabates@apple.com>
2479
2480         [iOS] Make WebCore build with public iOS SDK
2481         https://bugs.webkit.org/show_bug.cgi?id=136487
2482
2483         Reviewed by David Kilzer.
2484
2485         Update WebKit1 source files to include the wrapper SPI headers instead of the corresponding
2486         actual SPI header(s).
2487
2488         * DOM/WebDOMOperationsPrivate.h:
2489         * MigrateHeaders.make: Modified to only modify the include path of a "<WebCore/"-prefixed header
2490         file if its filename doesn't end in "SPI.h" as an alternative to having MigrateHeaders.make copy
2491         such files into the WebKit framework as private headers.
2492         * WebCoreSupport/WebFrameLoaderClient.mm:
2493         * WebInspector/WebNodeHighlight.mm:
2494         * WebView/WebIndicateLayer.mm:
2495         * WebView/WebRenderLayer.h:
2496         * WebView/WebView.mm:
2497
2498 2014-09-16  Daniel Bates  <dabates@apple.com>
2499
2500         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
2501         https://bugs.webkit.org/show_bug.cgi?id=136862
2502
2503         Reviewed by David Kilzer.
2504
2505         * Configurations/DebugRelease.xcconfig:
2506
2507 2014-09-16  Enrica Casucci  <enrica@apple.com>
2508
2509         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
2510         https://bugs.webkit.org/show_bug.cgi?id=136474
2511
2512         Reviewed by Benjamin Poulain.
2513
2514         This is the updated version of the patch that was landed in r173340.
2515         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
2516         and removes the assumption that EAffinity values match NSSelectionAffinity
2517         values. It also removes the includes in TextAffinity.h, creating the need to
2518         include explicitly the files when necessary.
2519
2520         * WebCoreSupport/WebEditorClient.h:
2521         (kit):
2522         (core):
2523
2524 2014-09-14  Daniel Bates  <dabates@apple.com>
2525
2526         [iOS] Attempt to fix the iOS build after <http://trac.webkit.org/changeset/173606>
2527         (https://bugs.webkit.org/show_bug.cgi?id=136789)
2528
2529         Substitute Node::countChildNodes() for Node::childNodeCount() in more places.
2530
2531         * WebView/WebFrame.mm:
2532         (-[WebFrame focusedNodeHasContent]):
2533
2534 2014-09-14  Chris Dumez  <cdumez@apple.com>
2535
2536         Rename Node::childNodeCount() to countChildNodes() and avoid inefficient uses
2537         https://bugs.webkit.org/show_bug.cgi?id=136789
2538
2539         Reviewed by Darin Adler.
2540
2541         Rename childNodeCount() to countChildNodes().
2542
2543         * WebView/WebHTMLView.mm:
2544         (-[WebHTMLView attributedString]):
2545
2546 2014-09-10  Jon Honeycutt  <jhoneycutt@apple.com>
2547
2548         Re-add the request autocomplete feature
2549
2550         <https://bugs.webkit.org/show_bug.cgi?id=136730>
2551
2552         This feature was rolled out in r148731 because it was only used by
2553         Chromium. As we consider supporting this feature, roll it back in, but
2554         leave it disabled.
2555
2556         This rolls out r148731 (which removed the feature) with small changes
2557         needed to make the code build in ToT, to match modern style, to make
2558         the tests run, and to remove unused code.
2559
2560         Reviewed by Andy Estes.
2561
2562         * Configurations/FeatureDefines.xcconfig:
2563         * WebCoreSupport/WebFrameLoaderClient.h:
2564
2565 2014-09-12  Commit Queue  <commit-queue@webkit.org>
2566
2567         Unreviewed, rolling out r173575.
2568         https://bugs.webkit.org/show_bug.cgi?id=136790
2569
2570         Failing tests (Requested by enrica on #webkit).
2571
2572         Reverted changeset:
2573
2574         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
2575         https://bugs.webkit.org/show_bug.cgi?id=136474
2576         http://trac.webkit.org/changeset/173575
2577
2578 2014-09-12  Enrica Casucci  <enrica@apple.com>
2579
2580         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
2581         https://bugs.webkit.org/show_bug.cgi?id=136474
2582
2583         Reviewed by Benjamin Poulain.
2584
2585         This is the updated version of the patch that was landed in r173340.
2586         I changed the use of IntPoint to FloatPoint since it was causing tests
2587         to fail.
2588         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
2589         and removes the assumption that EAffinity values match NSSelectionAffinity
2590         values. It also removes the includes in TextAffinity.h, creating the need to
2591         include explicitly the files when necessary. It also removes the unnecessary
2592         use of platform specific types, replacing them with WebCore types.
2593
2594         * WebCoreSupport/WebEditorClient.h:
2595         (kit):
2596         (core):
2597         * WebView/WebFrameView.mm:
2598         (-[WebFrameView _scrollToBeginningOfDocument]):
2599         (-[WebFrameView _scrollToEndOfDocument]):
2600
2601 2014-09-11  Bear Travis  <betravis@adobe.com>
2602
2603         [CSS Font Loading] Enable CSS Font Loading on Mac
2604         https://bugs.webkit.org/show_bug.cgi?id=135473
2605
2606         Reviewed by Antti Koivisto.
2607
2608         Enable CSS Font Loading in FeatureDefines.
2609
2610         * Configurations/FeatureDefines.xcconfig:
2611
2612 2014-09-11  Beth Dakin  <bdakin@apple.com>
2613
2614         Support rubber-banding in sub-frames
2615         https://bugs.webkit.org/show_bug.cgi?id=136726
2616         -and corresponding-
2617         rdar://problem/10011924
2618
2619         Reviewed by Tim Horton.
2620
2621         rubberBandingForOverflowScrollEnabled is re-named to
2622         rubberBandingForSubScrollableRegionsEnabled
2623         * WebView/WebView.mm:
2624         (-[WebView _preferencesChanged:]):
2625
2626 2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
2627
2628         Disable the "unreachable-code" warning
2629         https://bugs.webkit.org/show_bug.cgi?id=136677
2630
2631         Reviewed by Darin Adler.
2632
2633         * Configurations/Base.xcconfig:
2634
2635 2014-09-08  Maciej Stachowiak  <mjs@apple.com>
2636
2637         Fix 32-bit Mac build for new warnings
2638         https://bugs.webkit.org/show_bug.cgi?id=136624
2639
2640         Reviewed by Darin Adler.
2641         
2642         (Jessie already fixed this but my version with typedefs seems a tiny bit cleaner.)
2643
2644         * Carbon/HIViewAdapter.m:
2645         (+[HIViewAdapter bindHIViewToNSView:nsView:]): Need to use explicit casting now.
2646
2647 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2648
2649         Remove FILTERS flag
2650         https://bugs.webkit.org/show_bug.cgi?id=136571
2651
2652         Reviewed by Darin Adler.
2653
2654         * Configurations/FeatureDefines.xcconfig:
2655
2656 2014-09-08  Jessie Berlin  <jberlin@apple.com>
2657
2658         32-bit build fix after r173364.
2659
2660         * Carbon/HIViewAdapter.m:
2661         (+[HIViewAdapter bindHIViewToNSView:nsView:]):
2662
2663 2014-09-08  Dan Bernstein  <mitz@apple.com>
2664
2665         Build fix.
2666
2667         Added back SPI that is still in use.
2668
2669         * Misc/WebNSURLExtras.h:
2670         * Misc/WebNSURLExtras.mm:
2671         (-[NSURL _webkit_URLByRemovingFragment]):
2672
2673 2014-09-08  Dan Bernstein  <mitz@apple.com>
2674
2675         iOS Simulator build fix.
2676
2677         * Misc/WebKitSystemBits.m:
2678         (WebMemorySize):
2679
2680 2014-09-07  Darin Adler  <darin@apple.com>
2681
2682         Fix build failure seen on Mountain Lion buildbot.
2683
2684         * Misc/WebNSDataExtras.h: Make WEB_GUESS_MIME_TYPE_PEEK_LENGTH an unsigned instead
2685         of an int, to avoid warning about mixing signs.
2686
2687 2014-09-06  Darin Adler  <darin@apple.com>
2688
2689         Make updates suggested by new version of Xcode
2690         https://bugs.webkit.org/show_bug.cgi?id=136603
2691
2692         Reviewed by Mark Rowe.
2693
2694         * Configurations/Base.xcconfig: Added CLANG_WARN_UNREACHABLE_CODE, COMBINE_HIDPI_IMAGES,
2695         and ENABLE_STRICT_OBJC_MSGSEND as suggested by Xcode upgrade check.
2696
2697         * History/WebURLsWithTitles.m:
2698         (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): Use NSUInteger instead of
2699         unsigned for correctness, and to quiet the 32-to-64-bit compiler warning (which is
2700         not turned on because it gives us too many false positives).
2701         * Misc/WebElementDictionary.mm:
2702         (-[WebElementDictionary objectForKey:]): Ditto.
2703         * Misc/WebNSDataExtras.m:
2704         (-[NSData _webkit_guessedMIMETypeForXML]): Ditto.
2705         (-[NSData _webkit_guessedMIMEType]): Ditto.
2706         (-[NSData _webkit_parseRFC822HeaderFields]): Ditto.
2707         (-[NSData _web_locationAfterFirstBlankLine]): Ditto.
2708
2709         * Misc/WebNSURLExtras.h: Removed unused _web_URLWithLowercasedScheme, _web_hostData,
2710         _webkit_URLByRemovingFragment, _webkit_URLByRemovingResourceSpecifier, _webkit_isFTPDirectoryURL,
2711         _webkit_shouldLoadAsEmptyDocument, _web_hostNameNeedsDecodingWithRange:,
2712         _web_hostNameNeedsEncodingWithRange:, _web_decodeHostNameWithRange:, _web_encodeHostNameWithRange:,
2713         and _webkit_URLFragment methods.
2714
2715         * Misc/WebNSURLExtras.mm:
2716         (-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): Deleted.
2717         (-[NSURL _webkit_URLByRemovingFragment]): Deleted.
2718         (-[NSURL _webkit_URLByRemovingResourceSpecifier]): Deleted.
2719         (-[NSURL _webkit_isFTPDirectoryURL]): Deleted.
2720         (-[NSURL _webkit_shouldLoadAsEmptyDocument]): Deleted.
2721         (-[NSURL _web_URLWithLowercasedScheme]): Deleted.
2722         (-[NSString _webkit_isFTPDirectoryURL]): Deleted.
2723         (-[NSString _web_hostNameNeedsDecodingWithRange:]): Deleted.
2724         (-[NSString _web_hostNameNeedsEncodingWithRange:]): Deleted.
2725         (-[NSString _web_decodeHostNameWithRange:]): Deleted.
2726         (-[NSString _web_encodeHostNameWithRange:]): Deleted.
2727         (-[NSString _webkit_URLFragment]): Deleted.
2728
2729         * Plugins/WebPluginDatabase.mm:
2730         (-[WebPluginDatabase removePluginInstanceViewsFor:]): Use a modern for loop
2731         to iterate an array instead of a loop using the type "unsigned int".
2732
2733         * WebCoreSupport/WebOpenPanelResultListener.mm:
2734         (-[WebOpenPanelResultListener chooseFilenames:]): Use NSUInteger instead of int.
2735
2736         * WebView/WebDelegateImplementationCaching.mm:
2737         (CallDelegate): Use wtfCallIMP in one overload that was instead just calling the
2738         directly without a proper type for the function pointer. This might have been causing
2739         an actual problem on 64-bit systems, and it was different from all the other CallDelegate
2740         functions that were already doing this correctly.
2741
2742         * WebView/WebTextCompletionController.mm:
2743         (-[WebTextCompletionController _placePopupWindow:]): Use NSUInteger instead of int.
2744
2745 2014-09-06  Brian J. Burg  <burg@cs.washington.edu>
2746
2747         Web Inspector: convert DockSide to an enum class
2748         https://bugs.webkit.org/show_bug.cgi?id=136601
2749
2750         Reviewed by Timothy Hatcher.
2751
2752         * WebCoreSupport/WebInspectorClient.mm:
2753         (WebInspectorFrontendClient::frontendLoaded):
2754         (-[WebInspectorWindowController attachWindow:]):
2755         (-[WebInspectorWindowController attach]):
2756         (-[WebInspectorWindowController detach]):
2757         * WebInspector/WebInspectorFrontend.mm:
2758         (-[WebInspectorFrontend attach]):
2759
2760 2014-09-05  Commit Queue  <commit-queue@webkit.org>
2761
2762         Unreviewed, rolling out r173340 and r173342.
2763         https://bugs.webkit.org/show_bug.cgi?id=136596
2764
2765         Broke many tests (Requested by ap on #webkit).
2766
2767         Reverted changesets:
2768
2769         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
2770         https://bugs.webkit.org/show_bug.cgi?id=136474
2771         http://trac.webkit.org/changeset/173340
2772
2773         "Build fix after r173340."
2774         http://trac.webkit.org/changeset/173342
2775
2776 2014-09-05  Enrica Casucci  <enrica@apple.com>
2777
2778         Build fix after r173340.
2779
2780         * WebCoreSupport/WebEditorClient.h:
2781         (kit):
2782         (core):
2783
2784 2014-09-05  Enrica Casucci  <enrica@apple.com>
2785
2786         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
2787         https://bugs.webkit.org/show_bug.cgi?id=136474
2788
2789         Reviewed by Benjamin Poulain.
2790
2791         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
2792         and removes the assumption that EAffinity values match NSSelectionAffinity
2793         values. It also removes the includes in TextAffinity.h, creating the need to
2794         include explicitly the files when necessary. It also removes the unnecessary
2795         use of platform specific types, replacing them with WebCore types.
2796
2797         * WebCoreSupport/WebEditorClient.h: Added kit and core for EAffinity.
2798         * WebView/WebFrameView.mm:
2799         (-[WebFrameView _scrollToBeginningOfDocument]):
2800         (-[WebFrameView _scrollToEndOfDocument]):
2801
2802 2014-09-05  Daniel Bates  <dabates@apple.com>
2803
2804         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
2805         (https://bugs.webkit.org/show_bug.cgi?id=136564)
2806
2807         Move #endif inside -viewDidMoveToWindow up one line such that the closing brace ('}') is after it.
2808
2809         * WebView/WebHTMLView.mm:
2810         (-[WebHTMLView viewDidMoveToWindow]):
2811
2812 2014-09-05  Daniel Bates  <dabates@apple.com>
2813
2814         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
2815         (https://bugs.webkit.org/show_bug.cgi?id=136564)
2816
2817         Add !PLATFORM(IOS)-guard in -viewDidMoveToWindow around code that references WebHTMLViewPrivate.flagsChangedEventMonitor.
2818         The instance variable WebHTMLViewPrivate.flagsChangedEventMonitor is guarded by !PLATFORM(IOS).
2819
2820         * WebView/WebHTMLView.mm:
2821         (-[WebHTMLView viewDidMoveToWindow]):
2822
2823 2014-09-05  Daniel Bates  <dabates@apple.com>
2824
2825         [iOS] Fix the iOS build after <http://trac.webkit.org/changeset/173309>
2826         (https://bugs.webkit.org/show_bug.cgi?id=136564)
2827
2828         Include more code inside the !PLATFORM(IOS)-guarded section in -setDataSource:.
2829
2830         * WebView/WebHTMLView.mm:
2831         (-[WebHTMLView setDataSource:]):
2832
2833 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
2834
2835         Use tracking areas instead of (SPI) mouse moved notifications, and follow flags changes with an event monitor
2836         https://bugs.webkit.org/show_bug.cgi?id=136564
2837
2838         Reviewed by Dan Bernstein.
2839         
2840         WebKit1 depended on mouse moved event notifications to track mouse
2841         moves, and on being specially called by Safari to track flags
2842         changes. WebKit2 does both these things better - it uses a tracking area
2843         and event monitors. Copy those approaches.
2844
2845         * WebKit.order: Remove reference to obsolete call.
2846         * WebView/WebHTMLView.mm:
2847         (-[WebHTMLViewPrivate dealloc]): No need to deallocate tracking
2848         area, since we now just always have one.
2849         (-[WebHTMLViewPrivate clear]): ditto
2850         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
2851         New method that posts a fake mouse move event in response to
2852         a flags change event, for use by the event monitor.
2853         (+[WebHTMLView _postFlagsChangedEvent:]): Empty this old call,
2854         still kept around for benefit of older Safari.
2855         (-[WebHTMLView _updateMouseoverWithEvent:]): Handle Dashboard's
2856         special mouseover mode (previously handled in a weird way).
2857         (-[WebHTMLView close]): No more need to mess with mouse moved observer.
2858         (-[WebHTMLView viewWillMoveToWindow:]): ditto
2859         (-[WebHTMLView viewDidMoveToWindow]): ditto; but now hook up a flags
2860         changed monitor.
2861         (-[WebHTMLView windowDidBecomeKey:]): No need to handle non-key window
2862         tracking area or mouse moved observer.
2863         (-[WebHTMLView windowDidResignKey:]): ditto
2864         (-[WebHTMLView windowWillOrderOnScreen:]): No need to mess with mouse
2865         moved observer.
2866         (-[WebHTMLView windowWillOrderOffScreen:]): ditto
2867         (-[WebHTMLView mouseMoved:]): Converted from the old mouseMovedNotification:
2868         (-[WebHTMLView setDataSource:]): Change if around body to early return. Hook
2869         up tracking area - we have to do it here, because before this point, the
2870         WebHTMLView does not know its WebView, which is where dashboard settings
2871         live.
2872         (-[WebHTMLView _removeMouseMovedObserverUnconditionally]): Deleted.
2873         (-[WebHTMLView addMouseMovedObserver]): Deleted.
2874         (-[WebHTMLView removeMouseMovedObserver]): Deleted.
2875
2876 2014-09-04  Pratik Solanki  <psolanki@apple.com>
2877
2878         Bring back [WebPreferences setDiskImageCacheEnabled:] for backwards compatibility
2879         https://bugs.webkit.org/show_bug.cgi?id=136560
2880
2881         Reviewed by Joseph Pecoraro.
2882
2883         I removed the disk image caching code in r173265. However, we still have clients that call
2884         setDiskImageCacheEnabled. Add in a stub method until we can wean the clients off this call.
2885
2886         * WebView/WebPreferences.mm:
2887         (-[WebPreferences setDiskImageCacheEnabled:]):
2888         * WebView/WebPreferencesPrivate.h:
2889
2890 2014-09-03  Andy Estes  <aestes@apple.com>
2891
2892         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
2893         https://bugs.webkit.org/show_bug.cgi?id=136521
2894
2895         Reviewed by Anders Carlsson.
2896
2897         Taught MigrateHeaders.make to remove WEBCORE_EXPORT from headers using this sed expression:
2898
2899             s/(^ *)WEBCORE_EXPORT /\1/g
2900
2901         This removes WEBCORE_EXPORT and a single following space character but preserves preceeding spaces.
2902
2903         * MigrateHeaders.make:
2904
2905 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
2906
2907         Remove WebCoreSystemInterface glue for otherwise unused WKSI calls
2908         https://bugs.webkit.org/show_bug.cgi?id=136527
2909
2910         Reviewed by Alexey Proskuryakov.
2911
2912         * WebCoreSupport/WebSystemInterface.mm:
2913         (InitWebCoreSystemInterface):
2914
2915 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2916
2917         Remove CSS_FILTERS flag
2918         https://bugs.webkit.org/show_bug.cgi?id=136529
2919
2920         Reviewed by Dirk Schulze.
2921
2922         * Configurations/FeatureDefines.xcconfig:
2923
2924 2014-09-04  Pratik Solanki  <psolanki@apple.com>
2925
2926         Remove iOS specific disk image cache
2927         https://bugs.webkit.org/show_bug.cgi?id=136517
2928
2929         Reviewed by Antti Koivisto.
2930
2931         Disk image cache code unnecessarily complicates SharedBuffer implementation. We can remove
2932         this now since we don't enable it in WebKit2 on iOS.
2933
2934         * Misc/WebCache.mm:
2935         (+[WebCache statistics]):
2936         * WebView/WebDataSource.mm:
2937         (-[WebDataSource _setAllowToBeMemoryMapped]):
2938         (-[WebDataSource setDataSourceDelegate:]):
2939         (-[WebDataSource dataSourceDelegate]):
2940         (-[WebDataSource dealloc]):
2941         (BufferMemoryMapped): Deleted.
2942         * WebView/WebPreferenceKeysPrivate.h:
2943         * WebView/WebPreferences.mm:
2944         (+[WebPreferences initialize]):
2945         (-[WebPreferences diskImageCacheEnabled]): Deleted.
2946         (-[WebPreferences setDiskImageCacheEnabled:]): Deleted.
2947         (-[WebPreferences diskImageCacheMinimumImageSize]): Deleted.
2948         (-[WebPreferences setDiskImageCacheMinimumImageSize:]): Deleted.
2949         (-[WebPreferences diskImageCacheMaximumCacheSize]): Deleted.
2950         (-[WebPreferences setDiskImageCacheMaximumCacheSize:]): Deleted.
2951         (-[WebPreferences _diskImageCacheSavedCacheDirectory]): Deleted.
2952         (-[WebPreferences _setDiskImageCacheSavedCacheDirectory:]): Deleted.
2953         * WebView/WebPreferencesPrivate.h:
2954         * WebView/WebView.mm:
2955         (-[WebView _commonInitializationWithFrameName:groupName:]):
2956         (+[WebView _handleMemoryWarning]):
2957         (-[WebView _preferencesChanged:]):
2958
2959 2014-09-04  Daniel Bates  <dabates@apple.com>
2960
2961         [iOS] Make iOS build when ENABLE_TOUCH_EVENT and ENABLE_IOS_TOUCH_EVENTS disabled
2962         https://bugs.webkit.org/show_bug.cgi?id=136494
2963
2964         Reviewed by Andy Estes.
2965
2966         * MigrateHeaders.make: Migrate header WebEventRegion.h only when ENABLE_IOS_TOUCH_EVENTS is defined.
2967         * WebView/WebView.mm: Substitute ENABLE(IOS_TOUCH_EVENTS) for ENABLE(TOUCH_EVENTS).
2968
2969 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
2970
2971         Web Inspector: fix prefixes for subclasses of JSC::ConsoleClient
2972         https://bugs.webkit.org/show_bug.cgi?id=136476
2973
2974         Reviewed by Timothy Hatcher.
2975
2976         * Misc/WebCoreStatistics.mm:
2977         (+[WebCoreStatistics shouldPrintExceptions]):
2978         (+[WebCoreStatistics setShouldPrintExceptions:]):
2979
2980 2014-09-03  Enrica Casucci  <enrica@apple.com>
2981
2982         Remove PLATFORM(IOS) from WebCore/editing (Part 1).
2983         https://bugs.webkit.org/show_bug.cgi?id=136474
2984
2985         Reviewed by Tim Horton.
2986
2987         * WebCoreSupport/WebEditorClient.mm:
2988         (undoNameForEditAction):
2989
2990 2014-09-02  Maciej Stachowiak  <mjs@apple.com>
2991
2992         Clean up naming for and slightly refactor legacy video fullscreen support
2993         https://bugs.webkit.org/show_bug.cgi?id=136446
2994
2995         Reviewed by Jer Noble.
2996
2997         Key changes:
2998         supportsFullscreenForNode(Node*) --> supportsVideoFullscreen()
2999         enterFullscreenForNode(Node*) --> enterVideoFullscreenForVideoElement(HTMLVideoElement*)
3000         exitFullscreenForNode(Node*) --> exitVideoFullscreen()
3001         
3002         The old versions had unnecessary parameters, did not clearly distinguish their purpose
3003         from enterFullscreenForElement and friends, and wrongly claimed generality to all Nodes.
3004         Also changed many other places to use HTMLVideoElement* instead of Node* or 
3005         HTMLMediaElement* when they were in fact only used for video elements and would only
3006         work for such.
3007
3008         * WebCoreSupport/WebChromeClient.h:
3009         * WebCoreSupport/WebChromeClient.mm:
3010         (WebChromeClient::supportsVideoFullscreen): Adjust for main refactoring.
3011         Also no more need to check for video elementness.
3012         (WebChromeClient::enterVideoFullscreenForVideoElement): Adjust for main refactoring.
3013         (WebChromeClient::exitVideoFullscreen): ditto
3014         * WebView/WebView.mm:
3015         (-[WebView _enterVideoFullscreenForVideoElement:]): Adjust for main
3016         refactoring.
3017         (-[WebView _exitVideoFullscreen]): ditto
3018         (-[WebView _close]): ditto
3019         * WebView/WebViewInternal.h:
3020
3021 2014-09-03  Dan Bernstein  <mitz@apple.com>
3022
3023         Get rid of HIGH_DPI_CANVAS leftovers
3024         https://bugs.webkit.org/show_bug.cgi?id=136491
3025
3026         Reviewed by Benjamin Poulain.
3027
3028         * Configurations/FeatureDefines.xcconfig: Removed definition of ENABLE_HIGH_DPI_CANVAS
3029         and removed it from FEATURE_DEFINES.
3030
3031 2014-08-31  Tim Horton  <timothy_horton@apple.com>
3032
3033         Remove unnecessary (and unnecessarily iOS-specific) setStrokeAndFillColor
3034         https://bugs.webkit.org/show_bug.cgi?id=136416
3035
3036         Reviewed by Dan Bernstein.
3037
3038         * WebView/WebFrameView.mm:
3039         (-[WebFrameView drawRect:]):
3040         We only end up filling, so only set the fill color.
3041
3042 2014-08-26  Maciej Stachowiak  <mjs@apple.com>
3043
3044         Use RetainPtr::autorelease in some places where it seems appropriate
3045         https://bugs.webkit.org/show_bug.cgi?id=136280
3046
3047         Reviewed by Darin Adler.
3048
3049         * WebView/WebHTMLView.mm:
3050         (imageFromRect): Use RetainPtr in this function.
3051         * WebView/WebPDFRepresentation.mm:
3052         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use RetainPtr
3053         in this method.
3054
3055 2014-08-29  Csaba Osztrogonác  <ossy@webkit.org>
3056
3057         Unreviwed, remove empty directories.
3058
3059         * ForwardingHeaders/wtf: Removed.
3060
3061 2014-08-27  Zalan Bujtas  <zalan@apple.com>
3062
3063         Subpixel layout: Rename LayoutRect's device pixel snapping functions.
3064         https://bugs.webkit.org/show_bug.cgi?id=136319
3065
3066         Reviewed by Simon Fraser.
3067
3068         From pixelSnappedForPainting() to snapRectToDevicePixels() and 
3069         pixelSnappedIntRect*() to snappedIntRect*().
3070
3071         No change in functionality.
3072
3073         * WebView/WebView.mm:
3074         (-[WebView _dashboardRegions]):
3075         (-[WebView trackedRepaintRects]):
3076
3077 2014-08-25  Maciej Stachowiak  <mjs@apple.com>
3078
3079         Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API
3080         https://bugs.webkit.org/show_bug.cgi?id=136082
3081
3082         Reviewed by Alexey Proskuryakov.
3083
3084         * Plugins/Hosted/NetscapePluginHostManager.mm:
3085         (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current
3086         localization name using WebCore helper instead of SPI.
3087         * Plugins/WebBasePluginPackage.mm: Fixed the include style for this 
3088         file.
3089         (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current
3090         localization name using WebCore helper instead of SPI.
3091         (+[WebBasePluginPackage preferredLocalizationName]): Deleted. This
3092         helper no longer pulls its weight.
3093         * WebCoreSupport/WebSystemInterface.mm: 
3094         (InitWebCoreSystemInterface): Remove mention of
3095         WKCopyCFLocalizationPreferredName.
3096         * WebKit.order: ditto
3097
3098 2014-08-25  Daniel Bates  <dabates@apple.com>
3099
3100         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/172889>
3101         (https://bugs.webkit.org/show_bug.cgi?id=109658)
3102
3103         Substitute GraphicsLayer::setContentsToPlatformLayer(..., GraphicsLayer::ContentsLayerForMedia)
3104         for GraphicsLayer::setContentsToMedia(...) because the latter was removed in <http://trac.webkit.org/changeset/172889>.
3105
3106         * WebView/WebView.mm:
3107         (-[WebView _setMediaLayer:forPluginView:]):
3108
3109 2014-08-22  Commit Queue  <commit-queue@webkit.org>
3110
3111         Unreviewed, rolling out r172866.
3112         https://bugs.webkit.org/show_bug.cgi?id=136177
3113
3114         Broke iOS build (Requested by othermaciej on #webkit).
3115
3116         Reverted changeset:
3117
3118         "Replace use of WKCopyCFLocalizationPreferredName with
3119         NSLocale public API"
3120         https://bugs.webkit.org/show_bug.cgi?id=136082
3121         http://trac.webkit.org/changeset/172866
3122
3123 2014-08-22  Simon Fraser  <simon.fraser@apple.com>
3124
3125         Implement paint flashing in the WK1 InspectorOverlay page
3126         https://bugs.webkit.org/show_bug.cgi?id=136138
3127
3128         Reviewed by Sam Weinig, Joseph Pecoraro.
3129
3130         Implement paint flashing for the WebKit1 InspectorOverlay via a second canvas in the overlay page.
3131         We avoid allocating backing store for this canvas until we have paint rects.
3132         
3133         Because this overlay page is weird and doesn't know how to paint itself, InspectorOverlay manages
3134         an array of rects, and pushes them to the page when they change, before forcing a paint.
3135         
3136         Because iOS doesn't use the InspectorOverlay page, stub out setShowPaintRects on its
3137         WebKit WebInspectorClient, but don't yet implement paint flashing there.
3138
3139         * WebCoreSupport/WebInspectorClient.h:
3140         * WebCoreSupport/WebInspectorClient.mm:
3141         (WebInspectorClient::WebInspectorClient):
3142
3143 2014-08-20  Maciej Stachowiak  <mjs@apple.com>
3144
3145         Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API
3146         https://bugs.webkit.org/show_bug.cgi?id=136082
3147
3148         Reviewed by Alexey Proskuryakov.
3149
3150         * Plugins/Hosted/NetscapePluginHostManager.mm:
3151         (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current
3152         localization name using WebCore helper instead of SPI.
3153         * Plugins/WebBasePluginPackage.mm: Fixed the include style for this 
3154         file.
3155         (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current
3156         localization name using WebCore helper instead of SPI.
3157         (+[WebBasePluginPackage preferredLocalizationName]): Deleted. This
3158         helper no longer pulls its weight.
3159         * WebCoreSupport/WebSystemInterface.mm: 
3160         (InitWebCoreSystemInterface): Remove mention of
3161         WKCopyCFLocalizationPreferredName.
3162         * WebKit.order: ditto
3163
3164 2014-08-22  Daniel Bates  <dabates@apple.com>
3165
3166         [iOS] Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, and temporarily disable ENABLE_TOUCH_EVENTS
3167         and ENABLE_XSLT when building with the iOS public SDK
3168         https://bugs.webkit.org/show_bug.cgi?id=135945
3169
3170         Reviewed by Andy Estes.
3171
3172         * Configurations/FeatureDefines.xcconfig: Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, ENABLE_TOUCH_EVENTS
3173         and ENABLE_XSLT when building with the public SDK.
3174         * MigrateHeaders.make: Conditionally migrate headers for touch and gesture events.
3175
3176 2014-08-22  Jon Lee  <jonlee@apple.com>
3177
3178         Fix iOS build due to r172832 and move RUBBER_BANDING out of FeatureDefines.h
3179         https://bugs.webkit.org/show_bug.cgi?id=136157
3180
3181         Reviewed by Simon Fraser.
3182
3183         * Configurations/FeatureDefines.xcconfig: Add ENABLE(RUBBER_BANDING).
3184         * WebView/WebView.mm:
3185         (-[WebView _preferencesChanged:]): Wrap in ENABLE(RUBBER_BANDING).
3186
3187 2014-08-21  Zalan Bujtas  <zalan@apple.com>
3188
3189         Enable SATURATED_LAYOUT_ARITHMETIC.
3190         https://bugs.webkit.org/show_bug.cgi?id=136106
3191
3192         Reviewed by Simon Fraser.
3193
3194         SATURATED_LAYOUT_ARITHMETIC protects LayoutUnit against arithmetic overflow.
3195         (No measurable performance regression on Mac.)
3196
3197         * Configurations/FeatureDefines.xcconfig:
3198
3199 2014-08-21  Beth Dakin  <bdakin@apple.com>
3200
3201         overflow:scroll elements should support rubber-banding
3202         https://bugs.webkit.org/show_bug.cgi?id=91655
3203
3204         Reviewed by Sam Weinig and Darin Adler.
3205
3206         Disable rubber-banding in overflow areas for now.
3207         * WebView/WebView.mm:
3208         (-[WebView _preferencesChanged:]):
3209
3210 2014-08-19  Pratik Solanki  <psolanki@apple.com>
3211
3212         Remove PurgeableBuffer since it is not very useful any more
3213         https://bugs.webkit.org/show_bug.cgi?id=135939
3214
3215         Reviewed by Andreas Kling.
3216
3217         * Misc/WebCache.mm:
3218         (+[WebCache statistics]):
3219
3220 2014-08-19  Zalan Bujtas  <zalan@apple.com>
3221
3222         Remove ENABLE(SUBPIXEL_LAYOUT).
3223         https://bugs.webkit.org/show_bug.cgi?id=136077
3224
3225         Reviewed by Simon Fraser.
3226
3227         Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.
3228
3229         * Configurations/FeatureDefines.xcconfig:
3230
3231 2014-08-18  Maciej Stachowiak  <mjs@apple.com>
3232
3233         Use NSURLFileTypeMappings directly instead of depending on WebKitSystemInterface wrappers for it
3234         https://bugs.webkit.org/show_bug.cgi?id=136035
3235
3236         Reviewed by Dan Bernstein.
3237
3238         * Misc/WebNSViewExtras.m:
3239         (-[NSView _web_DragImageForElement:rect:event:pasteboard:source:offset:]): Remove comment
3240         reference to obsolete WKSI function.
3241         * WebCoreSupport/WebSystemInterface.mm:
3242         (InitWebCoreSystemInterface): Don't initialize the no-longer-used WKGetExtensionsForMIMEType,
3243         WKGetPreferredExtensionForMIMEType, or WKGetMIMETypeForExtension
3244         * Plugins/WebPluginDatabase.mm:
3245         (-[WebPluginDatabase pluginForExtension:]): Include SPI header from WebCore; use
3246         NSURLFileTypeMappings directly instead of via WKSI wrapper.
3247         * WebCoreSupport/WebFrameLoaderClient.mm:
3248         (WebFrameLoaderClient::objectContentType): ditto
3249         * WebView/WebHTMLView.mm:
3250         (-[WebHTMLView _imageExistsAtPaths:]): ditto
3251         * WebView/WebView.mm:
3252         (+[WebView _supportedFileExtensions]): ditto
3253         (+[WebView suggestedFileExtensionForMIMEType:]): ditto
3254         (+[WebView _MIMETypeForFile:]): ditto
3255
3256 2014-08-18  Commit Queue  <commit-queue@webkit.org>
3257
3258         Unreviewed, rolling out r172736.
3259         https://bugs.webkit.org/show_bug.cgi?id=136060
3260
3261         Caused 14% PLT regressions (Requested by rniwa on #webkit).
3262
3263         Reverted changeset:
3264
3265         "Remove PurgeableBuffer since it is not very useful any more"
3266         https://bugs.webkit.org/show_bug.cgi?id=135939
3267         http://trac.webkit.org/changeset/172736
3268
3269 2014-08-18  Pratik Solanki  <psolanki@apple.com>
3270
3271         Remove PurgeableBuffer since it is not very useful any more
3272         https://bugs.webkit.org/show_bug.cgi?id=135939
3273
3274         Reviewed by Geoffrey Garen.
3275
3276         * Misc/WebCache.mm:
3277         (+[WebCache statistics]):
3278
3279 2014-08-18  Andy Estes  <aestes@apple.com>
3280
3281         REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
3282         https://bugs.webkit.org/show_bug.cgi?id=136010
3283
3284         Reviewed by Darin Adler.
3285
3286         * Misc/WebKitVersionChecks.h: Removed WEBKIT_FIRST_VERSION_WITH_NAVIGATION_URL_VALIDATION.
3287         * WebView/WebPDFView.mm:
3288         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Passed AllowNavigationToInvalidURL::Yes to FrameLoader::loadFrameRequest.
3289         * WebView/WebView.mm:
3290         (-[WebView _preferencesChanged:]): Reverted the linked-on-or-after check added in r170120 since it's no longer necessary.
3291
3292 2014-08-18  Andy Estes  <aestes@apple.com>
3293
3294         Revert r172697.
3295
3296         It made several webarchive layout tests flaky and didn't have the correct behavior for non-quick redirects.
3297
3298         * Misc/WebKitVersionChecks.h:
3299         * WebView/WebView.mm:
3300         (-[WebView _preferencesChanged:]):
3301
3302 2014-08-15  Andy Estes  <aestes@apple.com>
3303
3304         REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
3305         https://bugs.webkit.org/show_bug.cgi?id=136010
3306
3307         Reviewed by Darin Adler.
3308
3309         Reverted the linked-on-or-after check added in r170120 since it is no longer necessary.
3310
3311         * Misc/WebKitVersionChecks.h:
3312         * WebView/WebView.mm:
3313         (-[WebView _preferencesChanged:]):
3314
3315 2014-08-16  Maciej Stachowiak  <mjs@apple.com>
3316
3317         Remove the obsolete WebKitEnableCoalescedUpdatesPreferenceKey
3318         https://bugs.webkit.org/show_bug.cgi?id=136024
3319
3320         Reviewed by Filip Pizlo.
3321
3322         * WebView/WebFrameView.mm:
3323         (-[WebFrameView initWithFrame:]): Remove code that respects
3324         this key. It was SPI and is no longer used; also it was
3325         only relevant for versions of OS X that WebKit no longer supports.
3326         * WebView/WebPreferenceKeysPrivate.h: Remove declaration.
3327
3328 2014-08-15  Daniel Bates  <dabates@apple.com>
3329
3330         [iOS] Teach postprocess-headers.sh to remove code guarded by ENABLE_IOS_GESTURE_EVENTS
3331         and ENABLE_TOUCH_EVENTS if applicable
3332         https://bugs.webkit.org/show_bug.cgi?id=135993
3333
3334         Reviewed by Andy Estes.
3335
3336         Add support infrastructure to remove code from public and private API headers that is
3337         guarded by macro define ENABLE_{IOS_GESTURE, TOUCH}_EVENTS when these features are disabled.
3338
3339         We aren't using this functionality yet, but we will soon.
3340
3341         * postprocess-headers.sh:
3342
3343 2014-08-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3344
3345         Enable CSS_SCROLL_SNAP for iOS
3346         https://bugs.webkit.org/show_bug.cgi?id=135915
3347
3348         Turn on CSS_SCROLL_SNAP for iOS and the iOS simulator.
3349
3350         Reviewed by Tim Horton.
3351
3352         * Configurations/FeatureDefines.xcconfig:
3353
3354 2014-08-13  Mark Rowe  <mrowe@apple.com>
3355
3356         <https://webkit.org/b/135911> WebKit should build on Yosemite with the public SDK.
3357
3358         Reviewed by Darin Adler.
3359
3360         * Misc/WebSharingServicePickerController.mm: Forward-declare some details related to NSSharingServicePicker.
3361
3362 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3363
3364         Web Inspector: Workaround a NSWindow change to the title bar.
3365         https://bugs.webkit.org/show_bug.cgi?id=135880
3366
3367         Reviewed by Joseph Pecoraro.
3368
3369         * WebCoreSupport/WebInspectorClient.mm:
3370         (WebInspectorFrontendClient::setToolbarHeight): Only call setContentBorderThickness: on 10.9 and earlier.
3371         (-[WebInspectorWindowController init]): Only call setDrawsBackground: on 10.9 and earlier.
3372         (-[WebInspectorWindowController window]): Set titlebarAppearsTransparent on 10.10.
3373         Only call border thickness APIs on 10.9 and earlier.
3374
3375 2014-08-12  Peyton Randolph  <prandolph@apple.com>
3376
3377         Runtime switch for long mouse press gesture. Part of 135257 - Add long mouse press gesture.           
3378         https://bugs.webkit.org/show_bug.cgi?id=135682
3379
3380         Reviewed by Tim Horton.
3381
3382         * Configurations/FeatureDefines.xcconfig:
3383         Remove LONG_MOUSE_PRESS feature flag.
3384
3385 2014-08-11  Andy Estes  <aestes@apple.com>
3386
3387         [iOS] Get rid of iOS.xcconfig
3388         https://bugs.webkit.org/show_bug.cgi?id=135809
3389
3390         Reviewed by Joseph Pecoraro.
3391
3392         All iOS.xcconfig did was include AspenFamily.xcconfig, so there's no need for the indirection.
3393
3394         * Configurations/Base.xcconfig:
3395         * Configurations/iOS.xcconfig: Removed.
3396
3397 2014-08-10  Timothy Hatcher  <timothy@apple.com>
3398
3399         Web Inspector: new glyphs are visible on OS X 10.9 builds
3400         https://bugs.webkit.org/show_bug.cgi?id=135743
3401
3402         Reviewed by Joseph Pecoraro.
3403
3404         * WebCoreSupport/WebInspectorClient.mm:
3405         (-[WebInspectorWindowController window]): Use 10100 instead of 1090 for the version.
3406
3407 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
3408
3409         Get rid of SCRIPTED_SPEECH
3410         https://bugs.webkit.org/show_bug.cgi?id=135729
3411
3412         Reviewed by Brent Fulgham.
3413
3414         * Configurations/FeatureDefines.xcconfig:
3415
3416 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
3417
3418         Get rid of INPUT_SPEECH
3419         https://bugs.webkit.org/show_bug.cgi?id=135672
3420
3421         Reviewed by Andreas Kling.
3422
3423         * Configurations/FeatureDefines.xcconfig:
3424
3425 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3426
3427         Web Inspector: Update glyphs to be more like Xcode 6
3428         https://bugs.webkit.org/show_bug.cgi?id=135705
3429
3430         Reviewed by Joseph Pecoraro.
3431
3432         * Resources/Dock.pdf: Added.
3433         * Resources/DockLegacy.pdf: Copied from Source/WebKit/mac/Resources/Dock.pdf.
3434         * WebCoreSupport/WebInspectorClient.mm:
3435         (-[WebInspectorWindowController window]): Use new images.
3436
3437 2014-08-06  Dean Jackson  <dino@apple.com>
3438
3439         ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED is not used anywhere. Remove it.
3440         https://bugs.webkit.org/show_bug.cgi?id=135675
3441
3442         Reviewed by Sam Weinig.
3443
3444         * Configurations/FeatureDefines.xcconfig:
3445
3446 2014-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3447
3448         Implement parsing for CSS scroll snap points
3449         https://bugs.webkit.org/show_bug.cgi?id=134301
3450
3451         Reviewed by Dean Jackson.
3452
3453         * Configurations/FeatureDefines.xcconfig: Added ENABLE_CSS_SCROLL_SNAP
3454
3455 2014-08-06  Alexey Proskuryakov  <ap@apple.com>
3456
3457         REGRESSION (WebKit2): iOS Safari default encoding doesn't follow system language
3458         https://bugs.webkit.org/show_bug.cgi?id=135667
3459         <rdar://problem/17862892>
3460
3461         Reviewed by Anders Carlsson.
3462
3463         * WebView/WebPreferences.mm: (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]):
3464         Moved implementation to WebCore, so that it can be shared with WebKit2.
3465
3466         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
3467         We now use WKGetWebDefaultCFStringEncoding in WebCore, so it needs to be initialized.
3468
3469 2014-08-05  Peyton Randolph  <prandolph@apple.com>
3470
3471         Rename MAC_LONG_PRESS feature flag to LONG_MOUSE_PRESS.
3472         https://bugs.webkit.org/show_bug.cgi?id=135276
3473
3474         Reviewed by Beth Dakin.
3475
3476         * Configurations/FeatureDefines.xcconfig:
3477
3478 2014-08-04  Benjamin Poulain  <benjamin@webkit.org>
3479
3480         Add a flag for the CSS Selectors level 4 implementation
3481         https://bugs.webkit.org/show_bug.cgi?id=135535
3482
3483         Reviewed by Andreas Kling.
3484
3485         * Configurations/FeatureDefines.xcconfig:
3486
3487 2014-08-04  Benjamin Poulain  <bpoulain@apple.com>
3488
3489         Check for null frame when processing geolocation authorization request
3490         https://bugs.webkit.org/show_bug.cgi?id=135577
3491         <rdar://problem/17896295>
3492
3493         Reviewed by Geoffrey Garen.
3494
3495         * WebCoreSupport/WebGeolocationClient.mm:
3496         (WebGeolocationClient::requestPermission):
3497
3498 2014-08-02  Jeremy Jones  <jeremyj@apple.com>
3499
3500         Support both window and view based video fullscreen.
3501         https://bugs.webkit.org/show_bug.cgi?id=135525
3502
3503         Reviewed by Simon Fraser.
3504
3505         Parenting in the view instead of the window gives the fullscreen implementation more latitude 
3506         in how it implements the animation.
3507
3508         * WebView/WebView.mm:
3509         (-[WebView _enterFullscreenForNode:]): Use view instead of window.
3510
3511 2014-08-01  Dan Bernstein  <mitz@apple.com>
3512
3513         <rdar://problem/17891752> [iOS] WebKit links against libraries it doesn’t use
3514         https://bugs.webkit.org/show_bug.cgi?id=135536
3515
3516         Reviewed by Tim Horton.
3517
3518         * Configurations/WebKitLegacy.xcconfig: Removed -framework MobileAsset from
3519         OTHER_LDFLAGS_iphoneos.
3520
3521 2014-07-30  Andy Estes  <aestes@apple.com>
3522
3523         USE(CONTENT_FILTERING) should be ENABLE(CONTENT_FILTERING)
3524         https://bugs.webkit.org/show_bug.cgi?id=135439
3525
3526         Reviewed by Tim Horton.
3527
3528         We now support two different platform content filters, and will soon support a mock content filter (as part of
3529         webkit.org/b/128858). This makes content filtering a feature of WebKit, not just an adoption of a third-party
3530         library. ENABLE() is the correct macro to use for such a feature.
3531
3532         * Configurations/FeatureDefines.xcconfig:
3533
3534 2014-07-30  Andreas Kling  <akling@apple.com>
3535
3536         Static hash tables no longer need to be coupled with a VM.
3537         <https://webkit.org/b/135421>
3538
3539         Reviewed by Geoffrey Garen.
3540
3541         * Plugins/Hosted/ProxyInstance.mm:
3542         * Plugins/Hosted/ProxyRuntimeObject.mm:
3543
3544 2014-07-30  Dan Bernstein  <mitz@apple.com>
3545
3546         Updated for changes to the WebCore::Credential API.
3547         Work towards fixing https://bugs.webkit.org/show_bug.cgi?id=135327
3548
3549         Reviewed by Alexey Proskuryakov.
3550
3551         * Misc/WebDownload.mm:
3552         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): Use new nsCredential
3553         getter.
3554         * Plugins/WebBaseNetscapePluginView.mm:
3555         (WebKit::getAuthenticationInfo): Ditto.
3556
3557 2014-07-27  Pratik Solanki  <psolanki@apple.com>
3558
3559         Remove unused preference keys
3560         https://bugs.webkit.org/show_bug.cgi?id=135280
3561
3562         Reviewed by Darin Adler.
3563
3564         * WebView/WebPreferenceKeysPrivate.h: