WKR does not include my nick when commit-queue lands my patch
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2
3         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
4         https://bugs.webkit.org/show_bug.cgi?id=167394
5
6         Reviewed by Ryosuke Niwa.
7
8         * Configurations/FeatureDefines.xcconfig:
9
10 2017-01-23  Chris Dumez  <cdumez@apple.com>
11
12         REGRESSION (r211033): ASSERTION FAILED: m_ptr in com.apple.WebCore: WTF::RefPtr<WebCore::Element>::operator* const + 70
13         https://bugs.webkit.org/show_bug.cgi?id=167308
14         <rdar://problem/30144964>
15
16         Unreviewed, do a partial revert of r211033 to fix assertion.
17
18         * WebCoreSupport/WebChromeClient.h:
19         * WebCoreSupport/WebChromeClient.mm:
20         (WebChromeClient::exitFullScreenForElement):
21
22 2017-01-23  Joseph Pecoraro  <pecoraro@apple.com>
23
24         Remove allowWindowOpenWithoutUserGesture setting
25         https://bugs.webkit.org/show_bug.cgi?id=167301
26
27         Reviewed by Darin Adler.
28
29         * WebView/WebView.mm:
30         (-[WebView _preferencesChanged:]):
31         Use the equivalent existing setting.
32
33 2017-01-20  Darin Adler  <darin@apple.com>
34
35         Remove PassRefPtr from "page" directory of WebCore, also deploy references
36         https://bugs.webkit.org/show_bug.cgi?id=167224
37
38         Reviewed by Chris Dumez.
39
40         * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
41         (-[WebApplicationCacheQuotaManager quota]): Pass reference.
42
43         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
44         * WebCoreSupport/WebChromeClient.mm:
45         (WebChromeClient::focusedElementChanged): Ditto.
46         (WebChromeClient::createWindow): Ditto.
47         (WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
48         (WebChromeClient::runJavaScriptAlert): Ditto.
49         (WebChromeClient::runJavaScriptConfirm): Ditto.
50         (WebChromeClient::runJavaScriptPrompt): Ditto.
51         (WebChromeClient::contentsSizeChanged): Ditto.
52         (WebChromeClient::unavailablePluginButtonClicked): Ditto.
53         (WebChromeClient::print): Ditto.
54         (WebChromeClient::exceededDatabaseQuota): Ditto.
55         (WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
56         (WebChromeClient::createColorChooser): Ditto.
57         (WebChromeClient::elementDidFocus): Ditto.
58         (WebChromeClient::elementDidBlur): Ditto.
59         (WebChromeClient::createPopupMenu): Ditto.
60         (WebChromeClient::createSearchPopupMenu): Ditto.
61         (WebChromeClient::attachRootGraphicsLayer): Ditto.
62         (WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
63         (WebChromeClient::supportsFullScreenForElement): Ditto.
64         (WebChromeClient::enterFullScreenForElement): Ditto.
65         (WebChromeClient::exitFullScreenForElement): Ditto.
66
67         * WebView/WebFrame.mm:
68         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
69         Updated for change to the appendChild function.
70
71 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
72
73         Remove -[WebFrame sendOrientationChangeEvent:] which is unused
74         https://bugs.webkit.org/show_bug.cgi?id=167276
75
76         Reviewed by Alex Christensen.
77         
78         It was usurped by -deviceOrientationChanged in 2014.
79
80         * WebView/WebFrame.mm:
81         (-[WebFrame sendOrientationChangeEvent:]): Deleted.
82         * WebView/WebFramePrivate.h:
83
84 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
85
86         Remove -[WebView _contentsSizeRespectingOverflow] which is no longer needed
87         https://bugs.webkit.org/show_bug.cgi?id=167271
88
89         Reviewed by Alex Christensen.
90         
91         -_contentsSizeRespectingOverflow was added to try to make viewport sizing on iOS respect
92         overflow:hidden on the body (webkit.org/b/146924) but that was reverted (webkit.org/b/152803),
93
94         * WebView/WebView.mm:
95         (-[WebView _contentsSizeRespectingOverflow]): Deleted.
96         * WebView/WebViewPrivate.h:
97
98 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
99
100         Remove never changing IndexedDB RuntimeEnabledFeature
101         https://bugs.webkit.org/show_bug.cgi?id=167278
102
103         Reviewed by Darin Adler.
104
105         * WebView/WebView.mm:
106         (-[WebView _preferencesChanged:]):
107
108 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
109
110         Cleanup RuntimeEnabledFeatures
111         https://bugs.webkit.org/show_bug.cgi?id=167228
112
113         Reviewed by Simon Fraser.
114
115         * WebView/WebView.mm:
116         (-[WebView _preferencesChanged:]):
117
118 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
119
120         Remove outdated ENABLE(CSP_NEXT) build flag
121         https://bugs.webkit.org/show_bug.cgi?id=167252
122
123         Reviewed by Brent Fulgham.
124
125         * Configurations/FeatureDefines.xcconfig:
126
127 2017-01-20  Antoine Quint  <graouts@apple.com>
128
129         [Modern Media Controls] Turn modern media controls on by default
130         https://bugs.webkit.org/show_bug.cgi?id=165668
131
132         Reviewed by Dean Jackson.
133
134         Enabled modern media controls by default in WK1.
135
136         * WebView/WebPreferences.mm:
137         (+[WebPreferences initialize]):
138
139 2017-01-19  Chris Dumez  <cdumez@apple.com>
140
141         iterable<> should be enabled on WK1
142         https://bugs.webkit.org/show_bug.cgi?id=167221
143         <rdar://problem/30108531>
144
145         Reviewed by Youenn Fablet.
146
147         * WebView/WebPreferenceKeysPrivate.h:
148         * WebView/WebPreferences.mm:
149         (-[WebPreferences setCustomElementsEnabled:]):
150         (-[WebPreferences DOMIteratorEnabled]): Deleted.
151         (-[WebPreferences setDOMIteratorEnabled:]): Deleted.
152         * WebView/WebPreferencesPrivate.h:
153         * WebView/WebView.mm:
154         (-[WebView _preferencesChanged:]):
155
156 2017-01-19  Chris Dumez  <cdumez@apple.com>
157
158         Make sure HTML validation bubble gets dismissed when its associated element's frame gets detached
159         https://bugs.webkit.org/show_bug.cgi?id=167215
160         <rdar://problem/29885052>
161
162         Reviewed by Andreas Kling.
163
164         Make sure HTML validation bubble gets dismissed when its associated
165         element's frame gets detached and that we do not crash.
166
167         * WebCoreSupport/WebValidationMessageClient.h:
168         * WebCoreSupport/WebValidationMessageClient.mm:
169         (WebValidationMessageClient::documentDetached):
170
171 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
172
173         [Cocoa] Variation fonts are erroneously disabled on iOS
174         https://bugs.webkit.org/show_bug.cgi?id=167172
175
176         Reviewed by Simon Fraser.
177
178         OpenSource builders don't seem to understand sdk=embedded*.
179
180         * Configurations/FeatureDefines.xcconfig:
181
182 2017-01-19  Andreas Kling  <akling@apple.com>
183
184         ScriptExecutionContext::topOrigin() should return a reference.
185         <https://webkit.org/b/167190>
186
187         Reviewed by Sam Weinig.
188
189         * Misc/WebCache.mm:
190         (+[WebCache addImageToCache:forURL:forFrame:]):
191         (+[WebCache removeImageFromCacheForURL:forFrame:]):
192
193 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
194
195         Unreviewed fix for the macOS build.
196
197         * Carbon/CarbonWindowAdapter.mm:
198         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
199
200 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
201
202         Unreviewed, rolling out r210848.
203
204         This change introduced media-related LayoutTest failures and
205         crashes on macOS.
206
207         Reverted changeset:
208
209         "[Modern Media Controls] Turn modern media controls on by
210         default"
211         https://bugs.webkit.org/show_bug.cgi?id=165668
212         http://trac.webkit.org/changeset/210848
213
214 2017-01-18  Andreas Kling  <akling@apple.com>
215
216         Document::securityOrigin() should return a reference.
217         <https://webkit.org/b/167124>
218
219         Reviewed by Sam Weinig.
220
221         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
222         (WebKit::NetscapePluginInstanceProxy::loadRequest):
223         * Plugins/WebNetscapePluginStream.mm:
224         (WebNetscapePluginStream::WebNetscapePluginStream):
225         * Plugins/WebNetscapePluginView.mm:
226         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
227         * Plugins/WebPluginContainerCheck.mm:
228         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
229         * WebCoreSupport/WebChromeClient.mm:
230         (WebChromeClient::exceededDatabaseQuota):
231         * WebCoreSupport/WebFrameLoaderClient.h:
232         * WebCoreSupport/WebFrameLoaderClient.mm:
233         (WebFrameLoaderClient::didRunInsecureContent):
234         * WebCoreSupport/WebGeolocationClient.mm:
235         (WebGeolocationClient::requestPermission):
236         (-[WebGeolocationProviderInitializationListener initializationAllowedWebView:]):
237         * WebView/WebFrame.mm:
238         (-[WebFrame _allowsFollowingLink:]):
239
240 2017-01-18  Antoine Quint  <graouts@apple.com>
241
242         [Modern Media Controls] Turn modern media controls on by default
243         https://bugs.webkit.org/show_bug.cgi?id=165668
244
245         Reviewed by Dean Jackson.
246
247         Enabled modern media controls by default in WK1. 
248
249         * WebView/WebPreferences.mm:
250         (+[WebPreferences initialize]):
251
252 2017-01-15  Darin Adler  <darin@apple.com>
253
254         Remove PassRefPtr from "loader" directory of WebCore
255         https://bugs.webkit.org/show_bug.cgi?id=167055
256
257         Reviewed by Alex Christensen.
258
259         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
260         Also made class final and most functions private and final.
261         * WebCoreSupport/WebChromeClient.mm:
262         (WebChromeClient::runOpenPanel): Updated to take references.
263
264         * WebCoreSupport/WebEditorClient.h: Updated for changes to EditorClient.
265         * WebCoreSupport/WebEditorClient.mm:
266         (-[WebUndoStep initWithUndoStep:]): Take reference instead of PassRefPtr.
267         (+[WebUndoStep stepWithUndoStep:]): Ditto.
268         (-[WebUndoStep step]): Return reference instead of pointer.
269         (-[WebEditorUndoTarget undoEditing:]): Updated for the above.
270         (-[WebEditorUndoTarget redoEditing:]): Ditto.
271         (WebEditorClient::registerUndoOrRedoStep): Take reference instead of
272         PassRefPtr.
273         (WebEditorClient::registerUndoStep): Ditto.
274         (WebEditorClient::registerRedoStep): Ditto.
275
276         * WebCoreSupport/WebFrameLoaderClient.h: Updated for changes to
277         FrameLoaderClient, marked functions final instead of override.
278         * WebCoreSupport/WebFrameLoaderClient.mm:
279         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Take
280         pointer instead of PassRefPtr.
281         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
282         (makeFormFieldValuesDictionary): Take a reference.
283         (WebFrameLoaderClient::dispatchWillSendSubmitEvent): Take Ref&& instead
284         of PassRefPtr.
285         (WebFrameLoaderClient::dispatchWillSubmitForm): Take a reference instead
286         of PassRefPtr.
287         (WebFrameLoaderClient::actionDictionary): Take a pointer instead of PassRePtr.
288         (WebFrameLoaderClient::createFrame): Take a reference instead of a pointer.
289         (WebFrameLoaderClient::createPlugin): Ditto.
290         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
291         (WebFrameLoaderClient::createNetworkingContext): Ditto.
292         (WebFrameLoaderClient::didCreateQuickLookHandle): Pass a reference.
293
294         * WebCoreSupport/WebFrameNetworkingContext.h: Use Ref instead of PassRefPtr.
295         * WebCoreSupport/WebFrameNetworkingContext.mm: Tweak style a bit.
296
297         * WebCoreSupport/WebOpenPanelResultListener.h: Take a reference instead of
298         PassRefPtr. Use RefPtr for class field.
299         * WebCoreSupport/WebOpenPanelResultListener.mm:
300         (-[WebOpenPanelResultListener dealloc]): Deleted. Compiler will now do it
301         correctly without us declaring anything explicitly.
302         (-[WebOpenPanelResultListener cancel]): Get rid of hand-written deref code,
303         and let RefPtr do the work.
304         (-[WebOpenPanelResultListener chooseFilename:]): Ditto.
305         (-[WebOpenPanelResultListener chooseFilenames:]): Ditto.
306         (-[WebOpenPanelResultListener chooseFilenames:displayString:iconImage:]):
307         Rewrote to use a modern Objective-C for loop, reserveInitialCapacity,
308         and uncheckedAppend.
309
310         * WebView/WebArchive.mm:
311         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
312         Updated for changes to LegacyWebArchive.
313         (-[WebArchive mainResource]): Ditto.
314         (-[WebArchive subresources]): Ditto.
315         (-[WebArchive subframeArchives]): Ditto.
316
317         * WebView/WebDataSource.mm:
318         (-[WebDataSource _addSubframeArchives:]): Use a modern Objective-C for loop
319         instead of NSEnumerator.
320         (-[WebDataSource _fileWrapperForURL:]): Use auto.
321         (-[WebDataSource _documentFragmentWithArchive:]): Pass a reference.
322         (-[WebDataSource mainResource]): Ditto.
323         (-[WebDataSource subresources]): Ditto.
324         (-[WebDataSource subresourceForURL:]): Ditto.
325         (-[WebDataSource addSubresource:]): Ditto.
326
327         * WebView/WebResource.mm:
328         (-[WebResourcePrivate initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
329         (-[WebResourcePrivate dealloc]): Remove explicit deref since RefPtr will now take
330         care of it
331         (-[WebResource initWithCoder:]): Pass a reference.
332         (-[WebResource encodeWithCoder:]): Updated since coreResource is now RefPtr.
333         (-[WebResource _initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
334         (-[WebResource _coreResource]): Return reference rather than pointer.
335         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
336         Added code to handle the null case and pass a reference rather than a pointer.
337         * WebView/WebResourceInternal.h: Updated for the above.
338
339 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
340
341         Unreviewed, rolling out r210834
342         https://bugs.webkit.org/show_bug.cgi?id=165668
343
344         It introduced dozens of test timeouts.
345
346         Reverted changeset:
347         "[Modern Media Controls] Turn modern media controls on by default"
348         https://bugs.webkit.org/show_bug.cgi?id=165668
349         http://trac.webkit.org/changeset/210834
350
351 2017-01-17  Antoine Quint  <graouts@apple.com>
352
353         [Modern Media Controls] Turn modern media controls on by default
354         https://bugs.webkit.org/show_bug.cgi?id=165668
355
356         Reviewed by Dean Jackson.
357
358         Enabled modern media controls by default in WK1. 
359
360         * WebView/WebPreferences.mm:
361         (+[WebPreferences initialize]):
362
363 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
364
365         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
366         https://bugs.webkit.org/show_bug.cgi?id=116551
367         <rdar://problem/13949830>
368
369         Reviewed by Alex Christensen.
370
371         * Configurations/FeatureDefines.xcconfig:
372
373 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
374
375         Crash when closing tab with debugger paused
376         https://bugs.webkit.org/show_bug.cgi?id=161746
377         <rdar://problem/15607819>
378
379         Reviewed by Brian Burg and Brent Fulgham.
380
381         * WebView/WebView.mm:
382         (WebKit::DeferredPageDestructor::createDeferredPageDestructor):
383         (WebKit::DeferredPageDestructor::DeferredPageDestructor):
384         (WebKit::DeferredPageDestructor::tryDestruction):
385         (-[WebView _close]):
386         Defer destruction of the Page if we are in a nested runloop.
387
388 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
389
390         Remove the REQUEST_ANIMATION_FRAME flag
391         https://bugs.webkit.org/show_bug.cgi?id=156980
392         <rdar://problem/25906849>
393
394         Reviewed by Simon Fraser.
395
396         * Configurations/FeatureDefines.xcconfig:
397
398 2017-01-16  Andy Estes  <aestes@apple.com>
399
400         [QuickLook] Do some cleanup in QuickLookHandle
401         https://bugs.webkit.org/show_bug.cgi?id=166864
402
403         Reviewed by Darin Adler.
404
405         * WebCoreSupport/WebFrameLoaderClient.mm:
406         (WebFrameLoaderClient::didCreateQuickLookHandle): Changed to pass a
407         Ref<QuickLookHandleClient>&& to QuickLookHandle::setClient().
408
409 2017-01-15  Tim Horton  <timothy_horton@apple.com>
410
411         De-duplicate more (nearly) identical code in Editor(Mac|IOS).mm
412         https://bugs.webkit.org/show_bug.cgi?id=167063
413
414         Reviewed by Dan Bernstein.
415
416         * WebView/WebHTMLView.mm:
417         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
418         (-[WebHTMLView _updateFontPanel]):
419         * WebView/WebView.mm:
420         (-[WebView typingAttributes]):
421         Adjust to fontAttributesForSelectionStart returning a RetainPtr.
422
423 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
424
425         Remove ENABLE(DETAILS_ELEMENT) guards
426         https://bugs.webkit.org/show_bug.cgi?id=167042
427
428         Reviewed by Alex Christensen.
429
430         * Configurations/FeatureDefines.xcconfig:
431
432 2017-01-11  Darin Adler  <darin@apple.com>
433
434         Remove PassRefPtr from more of "platform"
435         https://bugs.webkit.org/show_bug.cgi?id=166809
436
437         Reviewed by Sam Weinig.
438
439         * WebCoreSupport/WebFrameLoaderClient.mm:
440         (NetscapePluginWidget::handleEvent): Pass a reference.
441         * WebView/WebView.mm:
442         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
443         Updated since the children set now contains Ref instead of RefPtr.
444
445 2017-01-13  Sam Weinig  <sam@webkit.org>
446
447         [WebIDL] Remove custom bindings for DeviceMotionEvent and DeviceOrientationEvent
448         https://bugs.webkit.org/show_bug.cgi?id=167006
449
450         Reviewed by Geoffrey Garen.
451
452         * WebView/WebDeviceOrientation.mm:
453         (convert):
454         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
455         Update for new use of std::optional.
456
457 2017-01-12  Joseph Pecoraro  <pecoraro@apple.com>
458
459         Remove unnecessary includes of Page.h
460         https://bugs.webkit.org/show_bug.cgi?id=166996
461
462         Reviewed by Yusuke Suzuki.
463
464         * DOM/DOMHTML.mm:
465         * History/WebBackForwardList.mm:
466         * Plugins/WebPluginController.mm:
467         * WebCoreSupport/WebNotificationClient.mm:
468         * WebCoreSupport/WebPlatformStrategies.mm:
469         * WebCoreSupport/WebUserMediaClient.mm:
470         * WebView/WebFullScreenController.mm:
471
472 2017-01-12  Chris Dumez  <cdumez@apple.com>
473
474         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
475         https://bugs.webkit.org/show_bug.cgi?id=166995
476
477         Reviewed by Jer Noble.
478
479         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
480         as some people are having trouble building without it.
481
482         * Configurations/FeatureDefines.xcconfig:
483
484 2017-01-12  Chris Dumez  <cdumez@apple.com>
485
486         HTML form validation popover sometimes does not go away
487         https://bugs.webkit.org/show_bug.cgi?id=166990
488         <rdar://problem/29985957>
489
490         Reviewed by Tim Horton.
491
492         Update code using ValidationBubble now that it is RefCounted.
493
494         * WebView/WebView.mm:
495         (-[WebView showFormValidationMessage:withAnchorRect:]):
496
497 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
498
499         Remove pointerLockElement from DOMDocumentPrivate.h
500         https://bugs.webkit.org/show_bug.cgi?id=166882
501
502         Reviewed by Simon Fraser.
503
504         Removed pointerLockElement declaration that was supposed to be removed in r209637.
505
506         * DOM/DOMDocumentPrivate.h:
507
508 2017-01-06  Darin Adler  <darin@apple.com>
509
510         Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
511         https://bugs.webkit.org/show_bug.cgi?id=166797
512
513         Reviewed by Alex Christensen.
514
515         * WebCoreSupport/WebEditorClient.h: Updated to take a reference.
516         * WebCoreSupport/WebEditorClient.mm:
517         (WebEditorClient::requestCheckingOfString): Take a reference
518         instead of a PassRefPtr.
519
520 2017-01-05  Chris Dumez  <cdumez@apple.com>
521
522         Turn preferLowPowerWebGLRendering setting on by default
523         https://bugs.webkit.org/show_bug.cgi?id=166737
524         <rdar://problem/29870033>
525
526         Reviewed by Dean Jackson.
527
528         Temporarily turn preferLowPowerWebGLRendering setting on by default until
529         we deal better with WebGL content in background tabs.
530
531         * WebView/WebPreferences.mm:
532         (+[WebPreferences initialize]):
533
534 2017-01-05  Enrica Casucci  <enrica@apple.com>
535
536         Support File Promise during drag for macOS.
537         https://bugs.webkit.org/show_bug.cgi?id=165204
538         rdar://problem/19595567
539
540         Reviewed by Tim Horton.
541
542         Adds support for dropping a File Promise in a WebView.
543         The implementation uses new File Promise API available in Sierra.
544
545         * Misc/WebNSPasteboardExtras.mm:
546         (+[NSPasteboard _web_dragTypesForURL]):
547         * WebView/WebView.mm:
548         (-[WebView performDragOperation:]):
549
550 2017-01-05  Andreas Kling  <akling@apple.com>
551
552         Remove ChromeClient::needTouchEvents().
553         <https://webkit.org/b/166723>
554
555         Rubber-stamped by Antti Koivisto.
556
557         * WebCoreSupport/WebChromeClient.h:
558
559 2017-01-04  Darin Adler  <darin@apple.com>
560
561         Remove PassRefPtr use from the "html" directory, other improvements
562         https://bugs.webkit.org/show_bug.cgi?id=166635
563
564         Reviewed by Alex Christensen.
565
566         * WebCoreSupport/WebChromeClient.h:
567         * WebCoreSupport/WebChromeClient.mm:
568         (WebChromeClient::loadIconForFiles): Take a reference instead of a pointer.
569
570 2017-01-04  Ryan Haddad  <ryanhaddad@apple.com>
571
572         Unreviewed, rolling out r210287.
573
574         This change caused editing test failures on macOS.
575
576         Reverted changeset:
577
578         "Support File Promise during drag for macOS."
579         https://bugs.webkit.org/show_bug.cgi?id=165204
580         http://trac.webkit.org/changeset/210287
581
582 2017-01-04  Enrica Casucci  <enrica@apple.com>
583
584         Support File Promise during drag for macOS.
585         https://bugs.webkit.org/show_bug.cgi?id=165204
586         rdar://problem/19595567
587
588         Reviewed by Tim Horton.
589
590         Adds support for dropping a File Promise in a WebView.
591         The implementation uses new File Promise API available in Sierra.
592
593         * Misc/WebNSPasteboardExtras.mm:
594         (+[NSPasteboard _web_dragTypesForURL]):
595         * WebView/WebView.mm:
596         (-[WebView performDragOperation:]):
597
598 2017-01-04  Tim Horton  <timothy_horton@apple.com>
599
600         Provide a setting for clients to always prefer low-power WebGL
601         https://bugs.webkit.org/show_bug.cgi?id=166675
602         <rdar://problem/29834093>
603
604         Reviewed by Dan Bernstein.
605
606         * WebView/WebPreferenceKeysPrivate.h:
607         * WebView/WebPreferences.mm:
608         (+[WebPreferences initialize]):
609         (-[WebPreferences preferLowPowerWebGLRendering]):
610         (-[WebPreferences setPreferLowPowerWebGLRendering:]):
611         * WebView/WebPreferencesPrivate.h:
612         * WebView/WebView.mm:
613         (-[WebView _preferencesChanged:]):
614         Expose a new private preferLowPowerWebGLRendering WebKit1 preference.
615
616 2017-01-03  Tim Horton  <timothy_horton@apple.com>
617
618         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
619         https://bugs.webkit.org/show_bug.cgi?id=166450
620         <rdar://problem/29447824>
621
622         Reviewed by Darin Adler.
623
624         * WebCoreSupport/CorrectionPanel.h:
625         * WebCoreSupport/CorrectionPanel.mm:
626         (CorrectionPanel::recordAutocorrectionResponse):
627         (CorrectionPanel::handleAcceptedReplacement):
628         * WebCoreSupport/WebAlternativeTextClient.mm:
629         (toCorrectionResponse):
630         (WebAlternativeTextClient::recordAutocorrectionResponse):
631         Funnel all calls to recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
632         through recordAutocorrectionResponse, for debugging's sake.
633         Drop the NSView parameter because we don't need it, just the tag.
634         Convert the new AutocorrectionResponseType value to its corresponding
635         NSCorrectionResponse value.
636
637 2017-01-01  Jeff Miller  <jeffm@apple.com>
638
639         Update user-visible copyright strings to include 2017
640         https://bugs.webkit.org/show_bug.cgi?id=166278
641
642         Reviewed by Dan Bernstein.
643
644         * Info.plist:
645
646 2016-12-30  Darin Adler  <darin@apple.com>
647
648         Remove PassRefPtr use from the "dom" directory, related cleanup
649         https://bugs.webkit.org/show_bug.cgi?id=166569
650
651         Reviewed by Alex Christensen.
652
653         * WebCoreSupport/WebFrameLoaderClient.mm:
654         (WebFrameLoaderClient::dispatchDidReceiveTitle): Updated to use struct.
655         (WebFrameLoaderClient::updateGlobalHistory): Ditto.
656         (WebFrameLoaderClient::setTitle): Ditto.
657         (WebFrameLoaderClient::transitionToCommittedForNewPage): Ditto.
658         * WebView/WebFrame.mm:
659         (-[WebFrame _dispatchDidReceiveTitle:]): Use aggregate-style syntax for StringWithDirection.
660         Not needed now, but useful later if we ever can get rid of the explicit constructors.
661         (-[WebFrame loadArchive:]): Pass a reference to loadArchive.
662         * WebView/WebHTMLRepresentation.mm:
663         (-[WebHTMLRepresentation title]): Updated to use struct.
664
665 2016-12-25  Yusuke Suzuki  <utatane.tea@gmail.com>
666
667         Propagate the source origin as much as possible
668         https://bugs.webkit.org/show_bug.cgi?id=166348
669
670         Reviewed by Darin Adler.
671
672         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
673         (WebKit::NetscapePluginInstanceProxy::evaluate):
674
675 2016-12-23  Andy Estes  <aestes@apple.com>
676
677         [iOS] DumpRenderTree triggers an assertion failure when calling +[WebPreferences _switchNetworkLoaderToNewTestingSession]
678         https://bugs.webkit.org/show_bug.cgi?id=166471
679
680         Reviewed by Andreas Kling.
681
682         When DumpRenderTree starts up, it calls
683         +[WebPreferences _switchNetworkLoaderToNewTestingSession] from the main thread. In Debug
684         builds, this triggers the ASSERT(isMainThread()) in
685         NetworkStorageSession::defaultNetworkStorageSession() because the Web thread has already
686         started, we are on the main thread, and we are not holding the Web thread lock. This is
687         causing all layout tests to crash in the iOS WK1 Debug configuration.
688
689         * WebView/WebPreferences.mm: (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
690         Take the Web thread lock before calling NetworkStorageSession::switchToNewTestingSession().
691
692 2016-12-22  Andy Estes  <aestes@apple.com>
693
694         Make WebCore::EditorInsertAction an enum class
695         https://bugs.webkit.org/show_bug.cgi?id=166424
696
697         Reviewed by Brent Fulgham.
698
699         * WebCoreSupport/WebEditorClient.mm:
700         (kit):
701
702 2016-12-21  Beth Dakin  <bdakin@apple.com>
703
704         Holding down on candidates in the TouchBar should show panel on screen
705         https://bugs.webkit.org/show_bug.cgi?id=166367
706         -and corresponding-
707         <rdar://problem/28479236>
708
709         Reviewed by Tim Horton.
710
711         Stray whitespace.
712         * WebCoreSupport/WebEditorClient.mm:
713         (WebEditorClient::handleRequestedCandidates):
714
715         Call the version of setCandidates: that takes a rect. We need to keep the helper 
716         function in WK1 (unlike WK2) since we also use it for testing.
717         * WebView/WebView.mm:
718         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
719
720 2016-12-20  Dean Jackson  <dino@apple.com>
721
722         Remove INDIE_UI
723         https://bugs.webkit.org/show_bug.cgi?id=165881
724         <rdar://problem/29672532>
725
726         Reviewed by Simon Fraser.
727
728         The Indie UI work has been discontinued.
729
730         * Configurations/FeatureDefines.xcconfig:
731
732 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
733
734         [ES6] Enable ES6 Modules
735         https://bugs.webkit.org/show_bug.cgi?id=165849
736
737         Reviewed by Geoffrey Garen.
738
739         * WebView/WebPreferenceKeysPrivate.h:
740         * WebView/WebPreferences.mm:
741         (+[WebPreferences initialize]):
742         (-[WebPreferences es6ModulesEnabled]): Deleted.
743         (-[WebPreferences setES6ModulesEnabled:]): Deleted.
744         * WebView/WebPreferencesPrivate.h:
745         * WebView/WebView.mm:
746         (-[WebView _preferencesChanged:]):
747
748 2016-12-16  Dave Hyatt  <hyatt@apple.com>
749
750         [CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
751         https://bugs.webkit.org/show_bug.cgi?id=165968
752
753         Reviewed by Andreas Kling.
754
755         * DOM/DOMCSS.mm:
756         (kitClass):
757         * DOM/DOMCSSPrimitiveValue.mm:
758         (-[DOMCSSPrimitiveValue getCounterValue]):
759         (-[DOMCSSPrimitiveValue getRectValue]):
760         (kit):
761         * DOM/DOMCSSPrimitiveValueInternal.h:
762         * DOM/DOMCSSStyleDeclaration.mm:
763         * DOM/DOMCSSValue.mm:
764         (kit):
765         * DOM/DOMCSSValueInternal.h:
766         * DOM/DOMCSSValueList.mm:
767         * DOM/DOMCounter.mm:
768         (kit):
769         * DOM/DOMCounterInternal.h:
770         * DOM/DOMRGBColor.mm:
771         (kit):
772         * DOM/DOMRGBColorInternal.h:
773         * DOM/DOMRect.mm:
774         (kit):
775         * DOM/DOMRectInternal.h:
776         * DOM/DOMUtility.mm:
777         (createDOMWrapper):
778
779 2016-12-16  Chris Dumez  <cdumez@apple.com>
780
781         HTML form validation bubble should be dismissed on navigation
782         https://bugs.webkit.org/show_bug.cgi?id=165960
783         <rdar://problem/29668086>
784
785         Reviewed by Simon Fraser.
786
787         Dismiss HTML form validation bubble on top-level navigation on Mac WK1.
788
789         * WebView/WebView.mm:
790         (-[WebView _didStartProvisionalLoadForFrame:]):
791
792 2016-12-15  Darin Adler  <darin@apple.com>
793
794         Use asString instead of toWTFString, toString, or getString when we already checked isString
795         https://bugs.webkit.org/show_bug.cgi?id=165895
796
797         Reviewed by Yusuke Suzuki.
798
799         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
800         (WebKit::NetscapePluginInstanceProxy::addValueToArray): Use asString/value instead of
801         toWTFString.
802         * WebView/WebView.mm:
803         (aeDescFromJSValue): Use asString/value instead of getString.
804
805 2016-12-15  Chris Dumez  <cdumez@apple.com>
806
807         Make sure HTML validation bubble's state is updated after layout
808         https://bugs.webkit.org/show_bug.cgi?id=165922
809         <rdar://problem/29694730>
810
811         Reviewed by Simon Fraser.
812
813         Make sure HTML validation bubble's state is updated after layout.
814         In particular, if the validation bubble's associated element has
815         moved or is no longer visible, we now hide the bubble.
816
817         * WebCoreSupport/WebValidationMessageClient.h:
818         * WebCoreSupport/WebValidationMessageClient.mm:
819         (WebValidationMessageClient::showValidationMessage):
820         (WebValidationMessageClient::hideValidationMessage):
821         (WebValidationMessageClient::updateValidationBubbleStateIfNeeded):
822
823 2016-12-15  Chris Dumez  <cdumez@apple.com>
824
825         Move charCode / keyCode / which attributes from UIEvent to KeyboardEvent
826         https://bugs.webkit.org/show_bug.cgi?id=165904
827
828         Reviewed by Sam Weinig.
829
830         Update ObjC bindings so they keep building.
831
832         * DOM/DOMUIEvent.mm:
833         (-[DOMUIEvent keyCode]):
834         (-[DOMUIEvent charCode]):
835
836 2016-12-15  Andreas Kling  <akling@apple.com>
837
838         Always clear RenderLayer backing stores when going into page cache.
839         <https://webkit.org/b/165901>
840
841         Reviewed by Simon Fraser.
842
843         * WebView/WebView.mm:
844         (+[WebView _setCacheModel:]):
845
846 2016-12-12  Alex Christensen  <achristensen@webkit.org>
847
848         Remove unused workaround for Silverlight
849         https://bugs.webkit.org/show_bug.cgi?id=165773
850
851         Reviewed by Dean Jackson.
852
853         * Plugins/WebNetscapePluginView.mm:
854         (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]): Deleted.
855         This code was introduced in January 2010.  Microsoft fixed their bug shortly thereafter.
856         Allowing 6 years for users to update Silverlight is more than enough.
857         Safari doesn't even use WebKit1 for this any more.
858         I need this to be removed because this is the only non-WebGL code that needs to link against
859         the OpenGL framework, and I'm changing how that is done to link only through ANGLE instead.
860
861 2016-12-12  Chris Dumez  <cdumez@apple.com>
862
863         Document.visibilityState should use an IDL string enumeration
864         https://bugs.webkit.org/show_bug.cgi?id=165774
865
866         Reviewed by Daniel Bates.
867
868         * DOM/DOMDocument.mm:
869         (-[DOMDocument visibilityState]):
870         * WebView/WebView.mm:
871         (kit):
872
873 2016-12-12  Jer Noble  <jer.noble@apple.com>
874
875         Remove implementation of legacy Mozilla-based Fullscreen API.
876         https://bugs.webkit.org/show_bug.cgi?id=165689
877         <rdar://problem/29603053>
878
879         Reviewed by Eric Carlson.
880
881         * DOM/DOMElement.mm:
882         (-[DOMElement webkitRequestFullScreen:]):
883
884 2016-12-10  Filip Pizlo  <fpizlo@apple.com>
885
886         The DOM should have an advancing wavefront opaque root barrier
887         https://bugs.webkit.org/show_bug.cgi?id=165712
888
889         Reviewed by Yusuke Suzuki.
890         
891         Propagate the JSDOMWindowBase::commonVM() -> commonVM() change.
892
893         * Misc/WebCoreStatistics.mm:
894         (+[WebCoreStatistics javaScriptObjectsCount]):
895         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
896         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
897         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
898         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
899         (+[WebCoreStatistics javaScriptObjectTypeCounts]):
900         (+[WebCoreStatistics shouldPrintExceptions]):
901         (+[WebCoreStatistics setShouldPrintExceptions:]):
902         (+[WebCoreStatistics memoryStatistics]):
903         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
904         * Plugins/Hosted/NetscapePluginHostProxy.mm:
905         (identifierFromIdentifierRep):
906         * Plugins/Hosted/ProxyInstance.mm:
907         (WebKit::ProxyInstance::getPropertyNames):
908         * Plugins/WebNetscapePluginStream.mm:
909         (WebNetscapePluginStream::wantsAllStreams):
910         * Plugins/WebNetscapePluginView.mm:
911         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
912         (-[WebNetscapePluginView privateBrowsingModeDidChange]):
913         (-[WebNetscapePluginView setWindowIfNecessary]):
914         (-[WebNetscapePluginView createPluginScriptableObject]):
915         (-[WebNetscapePluginView getFormValue:]):
916         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
917         (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
918         (-[WebNetscapePluginView loadPluginRequest:]):
919         (-[WebNetscapePluginView _printedPluginBitmap]):
920         * Plugins/WebPluginController.mm:
921         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
922         (-[WebPluginController stopOnePlugin:]):
923         (-[WebPluginController stopOnePluginForPageCache:]):
924         (-[WebPluginController destroyOnePlugin:]):
925         (-[WebPluginController startAllPlugins]):
926         (-[WebPluginController addPlugin:]):
927
928 2016-12-09  Dave Hyatt  <hyatt@apple.com>
929
930         [CSS Parser] Remove the old CSS Parser
931         https://bugs.webkit.org/show_bug.cgi?id=165645
932
933         Reviewed by Daniel Bates.
934
935         * DOM/DOMCSS.mm:
936         (kitClass):
937         * DOM/DOMCSSRule.h:
938
939 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
940
941         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
942         https://bugs.webkit.org/show_bug.cgi?id=165251
943
944         Reviewed by Dean Jackson.
945
946         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
947
948         * WebView/WebPreferenceKeysPrivate.h: Add MediaStream and PeerConnection preferences.
949         * WebView/WebPreferences.mm:
950         (+[WebPreferences initialize]):
951         (-[WebPreferences mediaStreamEnabled]):
952         (-[WebPreferences setMediaStreamEnabled:]):
953         (-[WebPreferences peerConnectionEnabled]):
954         (-[WebPreferences setPeerConnectionEnabled:]):
955         * WebView/WebPreferencesPrivate.h:
956         * WebView/WebView.mm:
957         (-[WebView _preferencesChanged:]):
958
959 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
960
961         Don’t expose pointer lock in WebKit1 Objective-C API
962         https://bugs.webkit.org/show_bug.cgi?id=165692
963
964         Reviewed by Simon Fraser.
965
966         * DOM/DOMDocument.mm:
967         (-[DOMDocument pointerLockElement]): Deleted.
968         (-[DOMDocument exitPointerLock]): Deleted.
969         * DOM/DOMElement.mm:
970         (-[DOMElement requestPointerLock]): Deleted.
971         * DOM/DOMMouseEvent.mm:
972         (-[DOMMouseEvent movementX]): Deleted.
973         (-[DOMMouseEvent movementY]): Deleted.
974
975 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
976
977         document.webkitFullscreenElement leaks elements inside a shadow tree
978         https://bugs.webkit.org/show_bug.cgi?id=158471
979
980         Reviewed by Chris Dumez.
981
982         Use the API for bindings to avoid exposing nodes inside a shadow tree.
983
984         * DOM/DOMDocument.mm:
985         (-[DOMDocument webkitCurrentFullScreenElement]):
986         (-[DOMDocument webkitFullscreenElement]):
987
988 2016-12-09  Beth Dakin  <bdakin@apple.com>
989
990         Password fields should not show the emoji button in TouchBar
991         https://bugs.webkit.org/show_bug.cgi?id=165673
992         -and corresponding-
993         rdar://problem/29235739
994
995         Reviewed by Wenson Hsieh.
996
997         This patch adds a new ivar for the password touch bar and password 
998         candidateListTouchBarItem. Since this TouchBar will actually have a different set 
999         of identifiers than the plain text TouchBar, it should just have its own variable.
1000
1001         The candidate list should be the only item for passwords.
1002         * WebView/WebView.mm:
1003         (-[WebView _passwordTextTouchBarDefaultItemIdentifiers]):
1004
1005         Account for _passwordTextTouchBar.
1006         (-[WebView didChangeAutomaticTextCompletion:]):
1007         (-[WebView setUpTextTouchBar:]):
1008         (-[WebView textTouchBar]):
1009
1010         The empty candidates array is not needed. We can just set @[ ] as the candidates 
1011         for the _passwordTextCandidateListTouchBarItem. Safe guards already exist in the 
1012         other parts of the code to prevent us from requesting or setting other candidates 
1013         when in a password field. 
1014         (-[WebView updateTextTouchBar]):
1015
1016         Account for _passwordTextTouchBar.
1017         (-[WebView candidateList]):
1018         * WebView/WebViewData.h:
1019
1020 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
1021
1022         Enable SharedArrayBuffer, remove the flag
1023         https://bugs.webkit.org/show_bug.cgi?id=165614
1024
1025         Rubber stamped by Geoffrey Garen.
1026
1027         * WebView/WebPreferencesPrivate.h:
1028
1029 2016-12-07  Dean Jackson  <dino@apple.com>
1030
1031         Remove runtime toggle for pointer-lock
1032         https://bugs.webkit.org/show_bug.cgi?id=165577
1033         <rdar://problems/29566996>
1034
1035         Reviewed by Jon Lee.
1036
1037         Remove any runtime calls to check if pointer-lock is enabled. It's
1038         either compiled in or out.
1039
1040         * WebView/WebPreferenceKeysPrivate.h:
1041         * WebView/WebPreferences.mm:
1042         (-[WebPreferences pointerLockEnabled]): Deleted.
1043         (-[WebPreferences setPointerLockEnabled:]): Deleted.
1044         * WebView/WebPreferencesPrivate.h:
1045         * WebView/WebView.mm:
1046         (-[WebView _preferencesChanged:]):
1047
1048 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
1049
1050         Correct SDKROOT values in xcconfig files
1051         https://bugs.webkit.org/show_bug.cgi?id=165487
1052         rdar://problem/29539209
1053
1054         Reviewed by Dan Bernstein.
1055
1056         Fix suggested by Dan Bernstein.
1057
1058         * Configurations/DebugRelease.xcconfig:
1059
1060 2016-12-05  Simon Fraser  <simon.fraser@apple.com>
1061
1062         Improve the behavior of scroll-into-view when the target is inside position:fixed
1063         https://bugs.webkit.org/show_bug.cgi?id=165354
1064
1065         Reviewed by Zalan Bujtas.
1066
1067         Plumb through 'insideFixed'. We don't get compute it, so behavior from
1068         these call sites won't change.
1069
1070         * WebView/WebFrame.mm:
1071         (-[WebFrame _scrollDOMRangeToVisible:]):
1072         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
1073
1074 2016-12-06  Simon Fraser  <simon.fraser@apple.com>
1075
1076         Enable visual viewports by default on Mac, and iOS Wk2
1077         https://bugs.webkit.org/show_bug.cgi?id=165452
1078
1079         Reviewed by Zalan Bujtas.
1080
1081         Turn visual viewports on by default for WK1 on Mac.
1082
1083         * WebView/WebPreferences.mm:
1084         (+[WebPreferences initialize]):
1085
1086 2016-12-05  Dean Jackson  <dino@apple.com>
1087
1088         pointer lock needs to be feature detectable
1089         https://bugs.webkit.org/show_bug.cgi?id=165426
1090         <rdar://problem/29486715>
1091
1092         Reviewed by Antoine Quint.
1093
1094         Set the RuntimeEnabledFeature as preferences
1095         change.
1096
1097         * WebView/WebView.mm:
1098         (-[WebView _preferencesChanged:]):
1099
1100 2016-12-05  Ryan Haddad  <ryanhaddad@apple.com>
1101
1102         Unreviewed, rolling out r209299.
1103
1104         This change appears to have caused LayoutTest failures on
1105         Sierra WK1.
1106
1107         Reverted changeset:
1108
1109         "Improve the behavior of scroll-into-view when the target is
1110         inside position:fixed"
1111         https://bugs.webkit.org/show_bug.cgi?id=165354
1112         http://trac.webkit.org/changeset/209299
1113
1114 2016-12-02  Simon Fraser  <simon.fraser@apple.com>
1115
1116         Improve the behavior of scroll-into-view when the target is inside position:fixed
1117         https://bugs.webkit.org/show_bug.cgi?id=165354
1118
1119         Reviewed by Zalan Bujtas.
1120
1121         Plumb through 'insideFixed'. We don't get compute it, so behavior from
1122         these call sites won't change.
1123
1124         * WebView/WebFrame.mm:
1125         (-[WebFrame _scrollDOMRangeToVisible:]):
1126         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
1127
1128 2016-12-02  Andy Estes  <aestes@apple.com>
1129
1130         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
1131         https://bugs.webkit.org/show_bug.cgi?id=164492
1132
1133         Reviewed by Dan Bernstein.
1134
1135         * Configurations/WebKitLegacy.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
1136         com.apple.$(PRODUCT_NAME:rfc1034identifier).
1137         * Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
1138         ${PRODUCT_BUNDLE_IDENTIFIER}.
1139
1140 2016-12-02  Chris Dumez  <cdumez@apple.com>
1141
1142         Regression(r209252): HTML interactive validation should not be enabled on iOS WK1 yet
1143         https://bugs.webkit.org/show_bug.cgi?id=165328
1144
1145         Reviewed by Simon Fraser.
1146
1147         Only enable HTML interactive form validation on Mac WK1, not iOS WK1.
1148
1149         * WebView/WebViewData.mm:
1150         (-[WebViewPrivate init]):
1151
1152 2016-12-02  Chris Dumez  <cdumez@apple.com>
1153
1154         [Mac][WK1] Implement new HTML interactive form validation user interface
1155         https://bugs.webkit.org/show_bug.cgi?id=164483
1156
1157         Reviewed by Simon Fraser.
1158
1159         Implement new HTML interactive form validation user interface on Mac
1160         WK1 and enable it by default.
1161
1162         * WebCoreSupport/WebValidationMessageClient.h: Added.
1163         * WebCoreSupport/WebValidationMessageClient.mm: Added.
1164         (WebValidationMessageClient::WebValidationMessageClient):
1165         (WebValidationMessageClient::~WebValidationMessageClient):
1166         (WebValidationMessageClient::showValidationMessage):
1167         (WebValidationMessageClient::hideValidationMessage):
1168         (WebValidationMessageClient::isValidationMessageVisible):
1169         * WebView/WebHTMLView.mm:
1170         (-[WebHTMLView _frameOrBoundsChanged]):
1171         * WebView/WebView.mm:
1172         (-[WebView _commonInitializationWithFrameName:groupName:]):
1173         (-[WebView _willStartScrollingOrZooming]):
1174         (-[WebView _contentsOfUserInterfaceItem:]):
1175         (-[WebView _scaleWebView:atOrigin:]):
1176         (-[WebView _didScrollDocumentInFrameView:]):
1177         (-[WebView _setZoomMultiplier:isTextOnly:]):
1178         (-[WebView showFormValidationMessage:withAnchorRect:]):
1179         (-[WebView hideFormValidationMessage]):
1180         * WebView/WebViewData.h:
1181         * WebView/WebViewData.mm:
1182         (-[WebViewPrivate init]):
1183         * WebView/WebViewInternal.h:
1184         * WebView/WebViewPrivate.h:
1185
1186 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
1187
1188         Add a runtime flag for SubtleCrypto
1189         https://bugs.webkit.org/show_bug.cgi?id=164982
1190
1191         Reviewed by Brent Fulgham.
1192
1193         * WebView/WebPreferenceKeysPrivate.h:
1194         * WebView/WebPreferences.mm:
1195         (+[WebPreferences initialize]):
1196         (-[WebPreferences subtleCryptoEnabled]):
1197         (-[WebPreferences setSubtleCryptoEnabled:]):
1198         * WebView/WebPreferencesPrivate.h:
1199         * WebView/WebView.mm:
1200         (-[WebView _preferencesChanged:]):
1201
1202 2016-11-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
1203
1204         Add separate settings and preferences to enable/disable async decoding for large images and animated images
1205         https://bugs.webkit.org/show_bug.cgi?id=165177
1206
1207         Reviewed by Simon Fraser.
1208         
1209         Hook up the async image decoding settings for WebKit1.
1210
1211         * WebView/WebPreferenceKeysPrivate.h:
1212         * WebView/WebPreferences.mm:
1213         (+[WebPreferences initialize]):
1214         (-[WebPreferences largeImageAsyncDecodingEnabled]):
1215         (-[WebPreferences setLargeImageAsyncDecodingEnabled:]):
1216         (-[WebPreferences animatedImageAsyncDecodingEnabled]):
1217         (-[WebPreferences setAnimatedImageAsyncDecodingEnabled:]):
1218         (-[WebPreferences asyncImageDecodingEnabled]): Deleted.
1219         (-[WebPreferences setAsyncImageDecodingEnabled:]): Deleted.
1220         * WebView/WebPreferencesPrivate.h:
1221         * WebView/WebView.mm:
1222         (-[WebView _preferencesChanged:]):
1223
1224 2016-11-29  Andy Estes  <aestes@apple.com>
1225
1226         [Cocoa] Enable two clang warnings recommended by Xcode
1227         https://bugs.webkit.org/show_bug.cgi?id=164498
1228
1229         Reviewed by Mark Lam.
1230
1231         * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
1232
1233 2016-11-26  Yusuke Suzuki  <utatane.tea@gmail.com>
1234
1235         [WTF] Import std::optional reference implementation as WTF::Optional
1236         https://bugs.webkit.org/show_bug.cgi?id=164199
1237
1238         Reviewed by Saam Barati and Sam Weinig.
1239
1240         Use WTF::Optional::value_or.
1241
1242         * DOM/DOMHTMLOptionsCollection.mm:
1243         (-[DOMHTMLOptionsCollection add:index:]):
1244         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1245         (WebKit::NetscapePluginInstanceProxy::evaluate):
1246         * Plugins/WebNetscapePluginView.mm:
1247         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
1248         * WebCoreSupport/WebFrameLoaderClient.h:
1249         * WebCoreSupport/WebFrameLoaderClient.mm:
1250         (WebFrameLoaderClient::dispatchDidCommitLoad):
1251         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1252         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1253         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
1254         (WebPaymentCoordinatorClient::completeShippingContactSelection):
1255         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
1256         * WebCoreSupport/WebSecurityOrigin.mm:
1257         (-[WebSecurityOrigin port]):
1258         * WebView/WebHTMLView.mm:
1259         (toAction):
1260         (toTag):
1261
1262 2016-11-26  Sam Weinig  <sam@webkit.org>
1263
1264         Convert IntersectionObserver over to using RuntimeEnabledFeatures so it can be properly excluded from script
1265         https://bugs.webkit.org/show_bug.cgi?id=164965
1266
1267         Reviewed by Simon Fraser.
1268
1269         * WebView/WebPreferenceKeysPrivate.h:
1270         * WebView/WebPreferences.mm:
1271         (-[WebPreferences intersectionObserverEnabled]):
1272         (-[WebPreferences setIntersectionObserverEnabled:]):
1273         * WebView/WebPreferencesPrivate.h:
1274         * WebView/WebView.mm:
1275         (-[WebView _preferencesChanged:]):
1276         Add a preference, defaulting to off, for enabling IntersectionObserver.
1277
1278 2016-11-22  Dan Bernstein  <mitz@apple.com>
1279
1280         [Mac] In Legacy WebKit, pressing an arrow key in editable content doesn’t hide the mouse cursor
1281         https://bugs.webkit.org/show_bug.cgi?id=165036
1282         <rdar://problem/5708580>
1283
1284         Reviewed by Alexey Proskuryakov.
1285
1286         * WebView/WebHTMLView.mm:
1287         (-[WebHTMLView performKeyEquivalent:]): Hide the cursor if WebCore handled the event,
1288           similarly to what we do in -keyDown: and to what WKWebView does with all key events.
1289
1290 2016-11-21  Alex Christensen  <achristensen@webkit.org>
1291
1292         Fix Sierra CMake build after r208452
1293         https://bugs.webkit.org/show_bug.cgi?id=164437
1294
1295         * WebView/WebView.mm:
1296         (-[WebView updateMediaTouchBar]):
1297         I haven't enabled VIDEO_PRESENTATION_MODE in the CMake build yet.
1298         It's needed for playbackSessionInterface to exist.
1299
1300 2016-11-18  Enrica Casucci  <enrica@apple.com>
1301
1302         Refactor drag and drop for WebKit2 to encode DragData message exchange.
1303         https://bugs.webkit.org/show_bug.cgi?id=164945
1304
1305         Reviewed by Tim Horton.
1306
1307         * WebCoreSupport/WebDragClient.h:
1308         * WebCoreSupport/WebDragClient.mm:
1309         (WebDragClient::actionMaskForDrag):
1310         (WebDragClient::willPerformDragDestinationAction):
1311
1312 2016-11-18  Jeremy Jones  <jeremyj@apple.com>
1313
1314         Add runtime flag to enable pointer lock. Enable pointer lock feature for mac.
1315         https://bugs.webkit.org/show_bug.cgi?id=163801
1316
1317         Reviewed by Simon Fraser.
1318
1319         Plumb through PointerLockEnabled setting.
1320
1321         * Configurations/FeatureDefines.xcconfig:
1322         * WebCoreSupport/WebChromeClient.mm:
1323         (WebChromeClient::requestPointerUnlock):
1324         * WebView/WebPreferenceKeysPrivate.h:
1325         * WebView/WebPreferences.mm:
1326         (-[WebPreferences pointerLockEnabled]):
1327         (-[WebPreferences setPointerLockEnabled:]):
1328         * WebView/WebPreferencesPrivate.h:
1329         * WebView/WebView.mm:
1330         (-[WebView _preferencesChanged:]):
1331
1332 2016-11-17  Dan Bernstein  <mitz@apple.com>
1333
1334         Try to fix some non-macOS builds.
1335
1336         * WebView/WebView.mm:
1337
1338 2016-11-16  Dave Hyatt  <hyatt@apple.com>
1339
1340         [CSS Parser] Add @supports, @keyframe and media query parsing options
1341         https://bugs.webkit.org/show_bug.cgi?id=164821
1342
1343         Reviewed by Sam Weinig and Zalan Bujtas.
1344
1345         Fix up the create call now that fallback descriptor syntax is gone.
1346
1347         * DOM/DOM.mm:
1348         (-[DOMHTMLLinkElement _mediaQueryMatches]):
1349
1350 2016-11-17  Saam Barati  <sbarati@apple.com>
1351
1352         Remove async/await compile time flag and enable tests
1353         https://bugs.webkit.org/show_bug.cgi?id=164828
1354         <rdar://problem/28639334>
1355
1356         Reviewed by Yusuke Suzuki.
1357
1358         * Configurations/FeatureDefines.xcconfig:
1359
1360 2016-11-17  Yusuke Suzuki  <utatane.tea@gmail.com>
1361
1362         [JSC] WTF::TemporaryChange with WTF::SetForScope
1363         https://bugs.webkit.org/show_bug.cgi?id=164761
1364
1365         Reviewed by Saam Barati.
1366
1367         * WebView/WebView.mm:
1368         (-[WebView updateTextTouchBar]):
1369
1370 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1371
1372         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
1373         https://bugs.webkit.org/show_bug.cgi?id=164827
1374
1375         Reviewed by Ryosuke Niwa.
1376
1377         * Configurations/FeatureDefines.xcconfig:
1378         * WebView/WebPreferenceKeysPrivate.h:
1379         * WebView/WebPreferences.mm:
1380         (+[WebPreferences initialize]):
1381         (-[WebPreferences es6ModulesEnabled]):
1382         (-[WebPreferences setES6ModulesEnabled:]):
1383         * WebView/WebPreferencesPrivate.h:
1384         * WebView/WebView.mm:
1385         (-[WebView _preferencesChanged:]):
1386
1387 2016-11-14  Alex Christensen  <achristensen@webkit.org>
1388
1389         Move SecurityOrigin::createFromDatabaseIdentifier to SecurityOriginData
1390         https://bugs.webkit.org/show_bug.cgi?id=164720
1391
1392         Reviewed by Brady Eidson.
1393
1394         * Storage/WebDatabaseManager.mm:
1395         (-[WebDatabaseManager origins]):
1396         (-[WebDatabaseManager databasesWithOrigin:]):
1397         (-[WebDatabaseManager deleteOrigin:]):
1398         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
1399         * Storage/WebDatabaseManagerClient.h:
1400         * Storage/WebDatabaseManagerClient.mm:
1401         (DidModifyOriginData::dispatchToMainThread):
1402         (DidModifyOriginData::DidModifyOriginData):
1403         (WebDatabaseManagerClient::dispatchDidModifyOrigin):
1404         (WebDatabaseManagerClient::dispatchDidModifyDatabase):
1405         * Storage/WebDatabaseQuotaManager.mm:
1406         (-[WebDatabaseQuotaManager usage]):
1407         (-[WebDatabaseQuotaManager quota]):
1408         (-[WebDatabaseQuotaManager setQuota:]):
1409         * Storage/WebStorageManager.mm:
1410         (-[WebStorageManager origins]):
1411         (-[WebStorageManager deleteOrigin:]):
1412         * Storage/WebStorageTrackerClient.h:
1413         * Storage/WebStorageTrackerClient.mm:
1414         (WebStorageTrackerClient::dispatchDidModifyOrigin):
1415         * WebCoreSupport/WebSecurityOrigin.mm:
1416         (-[WebSecurityOrigin usage]):
1417         (-[WebSecurityOrigin quota]):
1418         (-[WebSecurityOrigin setQuota:]):
1419
1420 2016-11-13  Darin Adler  <darin@apple.com>
1421
1422         Fix exception handling in SQL database code, streamline and update code
1423         https://bugs.webkit.org/show_bug.cgi?id=164685
1424
1425         Reviewed by Sam Weinig.
1426
1427         * Storage/WebDatabaseManager.mm:
1428         (-[WebDatabaseManager origins]): Updated to use DatabaseTracker and pass
1429         a reference.
1430         (-[WebDatabaseManager databasesWithOrigin:]): Ditto.
1431         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Pass reference,
1432         but continue to use DatabaseManager.
1433         (-[WebDatabaseManager deleteOrigin:]): Use DatabaseTracker and pass a
1434         reference.
1435         (-[WebDatabaseManager deleteDatabase:withOrigin:]): Ditto.
1436
1437         * Storage/WebDatabaseManagerClient.h: Updated to take references.
1438         * Storage/WebDatabaseManagerClient.mm:
1439         (WebDatabaseManagerClient::WebDatabaseManagerClient): Initialize data
1440         members in the class definition.
1441         (DidModifyOriginData::dispatchToMainThread): Take references.
1442         (DidModifyOriginData::DidModifyOriginData): Ditto.
1443         (WebDatabaseManagerClient::dispatchDidModifyOrigin): Ditto.
1444         (WebDatabaseManagerClient::dispatchDidModifyDatabase): Ditto.
1445         (WebDatabaseManagerClient::dispatchDidAddNewOrigin): Ditto. Also use
1446         DatabaseTracker::singleton instead of tracker.
1447
1448         * Storage/WebDatabaseQuotaManager.mm:
1449         (-[WebDatabaseQuotaManager initWithOrigin:]): Reject nil pointer argument.
1450         (-[WebDatabaseQuotaManager usage]): Use reference instead of pointer.
1451         (-[WebDatabaseQuotaManager quota]): Ditto.
1452         (-[WebDatabaseQuotaManager setQuota:]): Ditto.
1453         * WebCoreSupport/WebSecurityOrigin.mm:
1454         (-[WebSecurityOrigin initWithURL:]): Tweaked code a bit.
1455         (-[WebSecurityOrigin usage]): Use DatabaseTracker and pass a reference.
1456         (-[WebSecurityOrigin quota]): Ditto.
1457         (-[WebSecurityOrigin setQuota:]): Ditto.
1458         * WebView/WebFrame.mm:
1459         (-[WebFrame _cacheabilityDictionary]): Pass a reference.
1460
1461 2016-11-12  Darin Adler  <darin@apple.com>
1462
1463         Remove a few assorted uses of ExceptionCode
1464         https://bugs.webkit.org/show_bug.cgi?id=164683
1465
1466         Reviewed by Chris Dumez.
1467
1468         * DOM/DOMDOMImplementation.mm:
1469         (-[DOMImplementation createDocumentType:publicId:systemId:]):
1470         Use raiseOnDOMError instead of much longer hand written equivalent.
1471         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
1472
1473         * DOM/DOMDocument.mm:
1474         (-[DOMDocument createEntityReference:]): Use raiseNotSupportedErrorException
1475         so we are not using a specific exception code.
1476
1477         * DOM/DOMHTMLOptionsCollection.mm:
1478         (-[DOMHTMLOptionsCollection add:index:]): Use raiseOnDOMError instead of
1479         much longer hand written equivalent.
1480         * DOM/DOMHTMLSelectElement.mm:
1481         (-[DOMHTMLSelectElement add:before:]): Ditto. Also removed unneeded return
1482         statement after calling a "no return" function.
1483
1484         * DOM/ExceptionHandlers.h: Removed overloads of raiseDOMException and
1485         raiseOnDOMError functions that take ExceptionCode; keep the ones that take
1486         Exception and ExceptionOr. Renamed the other overload of raiseDOMException
1487         to raiseDOMErrorException; it is only used as the non-inline implementation
1488         part of the inline raiseOnDOMError function.
1489         * DOM/ExceptionHandlers.mm:
1490         (raiseDOMErrorException): Renamed. Made the ExceptionCode overload be local
1491         to this source file instead of in the header.
1492         (raiseTypeErrorException): Updated for name change.
1493         (raiseNotSupportedErrorException): Added.
1494
1495 2016-11-11  Ryosuke Niwa  <rniwa@webkit.org>
1496
1497         Hovering over a slotted Text node clears hover state
1498         https://bugs.webkit.org/show_bug.cgi?id=164002
1499         <rdar://problem/29040471>
1500
1501         Reviewed by Simon Fraser.
1502
1503         * WebView/WebImmediateActionController.mm:
1504         (-[WebImmediateActionController performHitTestAtPoint:]):
1505
1506 2016-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1507
1508         [WK2] autocorrect and autocapitalize attributes do not work in contenteditable elements
1509         https://bugs.webkit.org/show_bug.cgi?id=164538
1510         <rdar://problem/8418711>
1511
1512         Reviewed by Ryosuke Niwa.
1513
1514         Account for renaming HTMLElement::autocorrect to HTMLElement::shouldAutocorrect, as well as moving
1515         WebAutocapitalizeType to WebKit from WebCore. Additionally, moves the -autocorrect and -autocapitalize SPIs out
1516         of HTML(Input|Form|TextArea)ElementPrivate.h and into HTMLElementPrivate.h. This also means removing redundant
1517         code for interfacing with the unwrapped HTMLElement's autocorrect and autocapitalize attributes.
1518
1519         * DOM/DOMHTML.mm:
1520         (webAutocapitalizeType):
1521         (-[DOMHTMLInputElement _autocapitalizeType]):
1522         (-[DOMHTMLTextAreaElement _autocapitalizeType]):
1523         * DOM/DOMHTMLElement.mm:
1524         (-[DOMHTMLElement autocorrect]):
1525         (-[DOMHTMLElement setAutocorrect:]):
1526         (-[DOMHTMLElement autocapitalize]):
1527         (-[DOMHTMLElement setAutocapitalize:]):
1528         * DOM/DOMHTMLElementPrivate.h: Copied from Source/WebCore/html/Autocapitalize.h.
1529         * DOM/DOMHTMLFormElement.mm:
1530         (-[DOMHTMLFormElement autocorrect]): Deleted.
1531         (-[DOMHTMLFormElement setAutocorrect:]): Deleted.
1532         (-[DOMHTMLFormElement autocapitalize]): Deleted.
1533         (-[DOMHTMLFormElement setAutocapitalize:]): Deleted.
1534         * DOM/DOMHTMLInputElement.mm:
1535         (-[DOMHTMLInputElement autocorrect]): Deleted.
1536         (-[DOMHTMLInputElement setAutocorrect:]): Deleted.
1537         (-[DOMHTMLInputElement autocapitalize]): Deleted.
1538         (-[DOMHTMLInputElement setAutocapitalize:]): Deleted.
1539         * DOM/DOMHTMLInputElementPrivate.h:
1540         * DOM/DOMHTMLTextAreaElement.mm:
1541         (-[DOMHTMLTextAreaElement autocorrect]): Deleted.
1542         (-[DOMHTMLTextAreaElement setAutocorrect:]): Deleted.
1543         (-[DOMHTMLTextAreaElement autocapitalize]): Deleted.
1544         (-[DOMHTMLTextAreaElement setAutocapitalize:]): Deleted.
1545         * DOM/DOMHTMLTextAreaElementPrivate.h:
1546
1547         We need to import DOMHTMLElementPrivate.h here to avoid breaking UIKit. We should follow this up with a UIKit
1548         change to import DOMHTMLElementPrivate.h directly.
1549
1550         * DOM/DOMPrivate.h:
1551         * DOM/WebAutocapitalizeTypes.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h.
1552         * MigrateHeaders.make:
1553
1554 2016-11-11  Beth Dakin  <bdakin@apple.com>
1555
1556         Move to modern TouchBar methods
1557         https://bugs.webkit.org/show_bug.cgi?id=164655
1558         -and corresponding-
1559         rdar://problem/29226911
1560
1561         Reviewed by Wenson Hsieh.
1562
1563         customizationDefaultItemIdentifiers -> defaultItemIdentifiers
1564         itemIdentifiers -> defaultItemIdentifiers
1565         defaultItems -> templateItems
1566
1567         * WebView/WebView.mm:
1568         (-[WebView _plainTextTouchBarDefaultItemIdentifiers]):
1569         (-[WebView _richTextTouchBarDefaultItemIdentifiers]):
1570         (-[WebView setUpTextTouchBar:]):
1571         (-[WebView updateTextTouchBar]):
1572         (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
1573         (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
1574
1575 2016-11-11  Darin Adler  <darin@apple.com>
1576
1577         Move Node from ExceptionCode to ExceptionOr
1578         https://bugs.webkit.org/show_bug.cgi?id=164515
1579
1580         Reviewed by Sam Weinig.
1581
1582         * DOM/DOMHTMLSelectElement.mm:
1583         (-[DOMHTMLSelectElement remove:]): Call remove instead of removeByIndex
1584         now that it was renamed.
1585         * DOM/DOMNode.mm:
1586         (-[DOMNode setNodeValue:]): Updated exception handling.
1587         (-[DOMNode setPrefix:]): Ditto.
1588         (-[DOMNode setTextContent:]): Ditto.
1589         (-[DOMNode insertBefore:refChild:]): Ditto.
1590         (-[DOMNode replaceChild:oldChild:]): Ditto.
1591         (-[DOMNode removeChild:]): Ditto.
1592         (-[DOMNode appendChild:]): Ditto.
1593         (-[DOMNode cloneNode:]): Ditto.
1594
1595 2016-11-11  Beth Dakin  <bdakin@apple.com>
1596
1597         Get touch bar code building for open source builds
1598         https://bugs.webkit.org/show_bug.cgi?id=164610
1599
1600         Reviewed by Wenson Hsieh.
1601
1602         * WebKitPrefix.h:
1603
1604 2016-11-10  Alex Christensen  <achristensen@webkit.org>
1605
1606         Fix assertion after r208534.
1607         https://bugs.webkit.org/show_bug.cgi?id=160497
1608
1609         * WebView/WebView.mm:
1610         (-[WebView _commonInitializationWithFrameName:groupName:]):
1611         (WebInstallMemoryPressureHandler):
1612         WebInstallMemoryPressureHandler can be called before [WebView initWithFrame:frameName:groupName:]
1613         When this happens, we should use the same std::once_flag to make sure we install the MemoryPressureHandler::singleton
1614         only once, otherwise we get an assertion !m_installed in MemoryPressureHandler::setLowMemoryHandler.
1615
1616 2016-11-10  Alex Christensen  <achristensen@webkit.org>
1617
1618         Move SecurityOrigin::databaseIdentifier() to SecurityOriginData
1619         https://bugs.webkit.org/show_bug.cgi?id=164573
1620
1621         Reviewed by Brady Eidson.
1622
1623         * WebCoreSupport/WebSecurityOrigin.mm:
1624         (-[WebSecurityOrigin databaseIdentifier]):
1625
1626 2016-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1627
1628         MemoryPressureHandler shouldn't know how to release WebCore memory
1629         https://bugs.webkit.org/show_bug.cgi?id=160497
1630
1631         Reviewed by Michael Catanzaro.
1632
1633         Set the low memory handler before installing the memory pressure handler.
1634
1635         * WebView/WebView.mm:
1636         (-[WebView _commonInitializationWithFrameName:groupName:]):
1637
1638 2016-11-09  Ryosuke Niwa  <rniwa@webkit.org>
1639
1640         WebHTMLView's _attributeStringFromDOMRange should use HTMLConverter instead of NSAttributedString's _initWithDOMRange
1641         https://bugs.webkit.org/show_bug.cgi?id=164501
1642         <rdar://problem/29152282>
1643
1644         Reviewed by Sam Weinig.
1645
1646         Align what [WebHTMLView attributedString] returns to what would be used on copy & paste by using HTMLConverter
1647         instead of _initWithDOMRange in [WebHTMLView _attributeStringFromDOMRange].
1648
1649         * WebView/WebHTMLView.mm:
1650         (-[WebHTMLView _attributedStringFromDOMRange:]): Renamed from _attributeStringFromDOMRange.
1651         (-[WebHTMLView attributedString]):
1652         (-[WebHTMLView selectedAttributedString]):
1653         (-[WebHTMLView selectedString]): Moved to reduce the number of occurrences of the if-defs.
1654
1655 2016-11-04  Brent Fulgham  <bfulgham@apple.com>
1656
1657         Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
1658         https://bugs.webkit.org/show_bug.cgi?id=155185
1659         <rdar://problem/11101440>
1660
1661         Reviewed by Brady Eidson.
1662
1663         Provide SPI to access the new quirk for localStorage. The quirk defaults to 'on'. When active, this
1664         quirk says that localStorage access should be granted, without needing to grant universal file access.
1665
1666         If the quirk is turned off, then localStorage is blocked unless the WebKit client explicitly
1667         grants universal file access.
1668
1669         * WebView/WebPreferenceKeysPrivate.h:
1670         * WebView/WebPreferences.mm:
1671         (-[WebPreferences needsLocalStorageQuirk]): Added.
1672         (-[WebPreferences setNeedsLocalStorageQuirk:]): Added.
1673         * WebView/WebPreferencesPrivate.h:
1674         * WebView/WebView.mm:
1675         (-[WebView _preferencesChanged:]): Honor the new localStorage quirk.
1676
1677 2016-11-09  Alex Christensen  <achristensen@webkit.org>
1678
1679         Clean up Storage code
1680         https://bugs.webkit.org/show_bug.cgi?id=164562
1681
1682         Reviewed by Brady Eidson.
1683
1684         * Storage/WebStorageManager.mm:
1685         (-[WebStorageManager origins]):
1686         (-[WebStorageManager deleteAllOrigins]):
1687         (-[WebStorageManager deleteOrigin:]):
1688         (-[WebStorageManager diskUsageForOrigin:]):
1689         (-[WebStorageManager syncLocalStorage]):
1690         (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
1691         (+[WebStorageManager setStorageDatabaseIdleInterval:]):
1692         (+[WebStorageManager closeIdleLocalStorageDatabases]):
1693         (WebKitInitializeStorageIfNecessary):
1694         * WebView/WebView.mm:
1695         (+[WebView _applicationWillTerminate]):
1696
1697 2016-11-09  Beth Dakin  <bdakin@apple.com>
1698
1699         Another attempted build fix.
1700
1701         * WebView/WebView.mm:
1702
1703 2016-11-09  Beth Dakin  <bdakin@apple.com>
1704
1705         Attempted build fix.
1706
1707         * WebView/WebView.mm:
1708
1709 2016-11-09  Darin Adler  <darin@apple.com>
1710
1711         Move Range from ExceptionCode to ExceptionOr
1712         https://bugs.webkit.org/show_bug.cgi?id=164457
1713
1714         Reviewed by Alex Christensen.
1715
1716         * DOM/DOMRange.mm:
1717         (-[DOMRange setStart:offset:]): Updated exception handling.
1718         (-[DOMRange setEnd:offset:]): Ditto.
1719         (-[DOMRange setStartBefore:]): Ditto.
1720         (-[DOMRange setStartAfter:]): Ditto.
1721         (-[DOMRange setEndBefore:]): Ditto.
1722         (-[DOMRange setEndAfter:]): Ditto.
1723         (-[DOMRange selectNode:]): Ditto.
1724         (-[DOMRange selectNodeContents:]): Ditto.
1725         (-[DOMRange compareBoundaryPoints:sourceRange:]): Ditto.
1726         (-[DOMRange deleteContents]): Ditto.
1727         (-[DOMRange extractContents]): Ditto.
1728         (-[DOMRange cloneContents]): Ditto.
1729         (-[DOMRange insertNode:]): Ditto.
1730         (-[DOMRange surroundContents:]): Ditto.
1731         (-[DOMRange createContextualFragment:]): Ditto.
1732         (-[DOMRange compareNode:]): Ditto.
1733         (-[DOMRange intersectsNode:]): Ditto.
1734         (-[DOMRange comparePoint:offset:]): Ditto.
1735         (-[DOMRange isPointInRange:offset:]): Ditto.
1736         (-[DOMRange expand:]): Ditto.
1737         * WebView/WebFrame.mm:
1738         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
1739         (-[WebFrame _smartDeleteRangeForProposedRange:]): Deleted.
1740         This function was incorrectly implemented (set both start and end of
1741         the range to the computed start), not declared in any header file,
1742         not used anywhere inside WebKit, and I also could not find a use of it
1743         in outside-WebKit Apple code.
1744         * mac/DOM/DOMUIKitExtensions.mm:
1745         (-[DOMRange move:inDirection:]): Ditto.
1746         (-[DOMRange extend:inDirection:]): Ditto.
1747
1748 2016-11-09  Darin Adler  <darin@apple.com>
1749
1750         Move EventTarget from ExceptionCode to ExceptionOr
1751         https://bugs.webkit.org/show_bug.cgi?id=164465
1752
1753         Reviewed by Youenn Fablet.
1754
1755         * DOM/DOMNode.mm:
1756         (-[DOMNode dispatchEvent:]): Updated exception handling.
1757
1758 2016-11-09  Chris Dumez  <cdumez@apple.com>
1759
1760         [Mac] Stop using deprecated AppKit enumeration values
1761         https://bugs.webkit.org/show_bug.cgi?id=164494
1762
1763         Reviewed by Darin Adler.
1764
1765         Stop using deprecated AppKit enumeration values.
1766
1767         * Carbon/CarbonWindowAdapter.mm:
1768         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1769         (-[CarbonWindowAdapter sendSuperEvent:]):
1770         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1771         (WebKit::NetscapePluginHostProxy::beginModal):
1772         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1773         (WebKit::NetscapePluginInstanceProxy::syntheticKeyDownWithCommandModifier):
1774         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1775         (-[WebHostedNetscapePluginView drawRect:]):
1776         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1777         (WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier):
1778         * WebCoreSupport/PopupMenuMac.mm:
1779         (PopupMenuMac::populate):
1780         (PopupMenuMac::show):
1781         * WebCoreSupport/WebContextMenuClient.mm:
1782         (WebContextMenuClient::showContextMenu):
1783         * WebCoreSupport/WebFrameLoaderClient.mm:
1784         (WebFrameLoaderClient::actionDictionary):
1785         * WebCoreSupport/WebInspectorClient.mm:
1786         (WebInspectorFrontendClient::canAttach):
1787         (-[WebInspectorWindowController window]):
1788         * WebInspector/WebNodeHighlight.mm:
1789         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1790         * WebView/WebFrameView.mm:
1791         (-[WebFrameView keyDown:keyDown:]):
1792         * WebView/WebFullScreenController.mm:
1793         (-[WebFullScreenController init]):
1794         (createBackgroundFullscreenWindow):
1795         * WebView/WebHTMLView.mm:
1796         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
1797         (-[WebHTMLView _setMouseDownEvent:_setMouseDownEvent:]):
1798         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
1799         (isQuickLookEvent):
1800         (-[WebHTMLView hitTest:]):
1801         (-[WebHTMLView _sendToolTipMouseExited]):
1802         (-[WebHTMLView _sendToolTipMouseEntered]):
1803         (mouseEventIsPartOfClickOrDrag):
1804         (-[WebHTMLView _updateMouseoverWithEvent:]):
1805         (-[WebHTMLView _autoscroll]):
1806         (-[WebHTMLView acceptsFirstResponder]):
1807         (-[WebHTMLView viewDidMoveToWindow]):
1808         (-[WebHTMLView mouseDown:mouseDown:]):
1809         (currentKeyboardEvent):
1810         (-[WebHTMLView _handleStyleKeyEquivalent:]):
1811         (-[WebHTMLView _interpretKeyEvent:savingCommands:]):
1812         * WebView/WebPDFView.mm:
1813         (-[WebPDFView hitTest:]):
1814         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1815         (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
1816         * WebView/WebTextCompletionController.mm:
1817         (-[WebTextCompletionController _buildUI]):
1818         (-[WebTextCompletionController _placePopupWindow:]):
1819         * WebView/WebView.mm:
1820         (-[WebView applicationFlags:]):
1821
1822 2016-11-09  Beth Dakin  <bdakin@apple.com>
1823
1824         Support TouchBar in WebKit
1825         https://bugs.webkit.org/show_bug.cgi?id=164437
1826         -and corresponding-
1827         rdar://problem/28876524
1828
1829         Reviewed by Darin Adler.
1830
1831         * WebCoreSupport/WebEditorClient.mm:
1832         (WebEditorClient::respondToChangedSelection):
1833         (WebEditorClient::updateEditorStateAfterLayoutIfEditabilityChanged):
1834         * WebView/WebHTMLView.mm:
1835         (-[WebHTMLView candidateListTouchBarItem]):
1836         * WebView/WebView.mm:
1837         (-[_WebTextListTouchBarViewController initWithWebView:]):
1838         (-[_WebTextListTouchBarViewController _selectList:]):
1839         (-[_WebTextListTouchBarViewController setCurrentListType:]):
1840         (-[WebTextTouchBarItemController initWithWebView:]):
1841         (-[WebTextTouchBarItemController itemForIdentifier:]):
1842         (-[WebTextTouchBarItemController webTextListTouchBarViewController]):
1843         (-[WebTextTouchBarItemController setTextIsBold:]):
1844         (-[WebTextTouchBarItemController setTextIsItalic:]):
1845         (-[WebTextTouchBarItemController setTextIsUnderlined:]):
1846         (-[WebTextTouchBarItemController _webChangeTextStyle:]):
1847         (-[WebTextTouchBarItemController setCurrentTextAlignment:]):
1848         (-[WebTextTouchBarItemController _webChangeTextAlignment:]):
1849         (-[WebTextTouchBarItemController textColor]):
1850         (-[WebTextTouchBarItemController setTextColor:]):
1851         (-[WebTextTouchBarItemController _webChangeColor:]):
1852         (-[WebTextTouchBarItemController textListViewController]):
1853         (-[WebView _commonInitializationWithFrameName:groupName:]):
1854         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
1855         (-[WebView shouldRequestCandidates]):
1856         (-[WebView forceRequestCandidatesForTesting]):
1857         (-[WebView makeTouchBar]):
1858         (-[WebView touchBar:makeItemForIdentifier:]):
1859         (textCheckingResultFromNSTextCheckingResult):
1860         (-[WebView candidateListTouchBarItem:endSelectingCandidateAtIndex:]):
1861         (-[WebView candidateListTouchBarItem:changedCandidateListVisibility:]):
1862         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
1863         (-[WebView _clearPlaybackControlsManager]):
1864         (-[WebView _dismissTextTouchBarPopoverItemWithIdentifier:]):
1865         (-[WebView _textTouchBarCustomizationAllowedIdentifiers]):
1866         (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]):
1867         (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]):
1868         (-[WebView touchBarDidExitCustomization:]):
1869         (-[WebView touchBarWillEnterCustomization:]):
1870         (-[WebView didChangeAutomaticTextCompletion:]):
1871         (-[WebView setUpTextTouchBar:]):
1872         (-[WebView _isRichlyEditable]):
1873         (-[WebView textTouchBar]):
1874         (-[WebView updateTextTouchBar]):
1875         (-[WebView updateMediaTouchBar]):
1876         (-[WebView updateTouchBar]):
1877         (-[WebView prepareForMouseDown]):
1878         (-[WebView prepareForMouseUp]):
1879         (-[WebView webViewAdditionsWillDestroyView]):
1880         (-[WebView candidateList]):
1881         (-[WebView updateWebViewAdditions]): Deleted.
1882         * WebView/WebViewData.h:
1883         * WebView/WebViewInternal.h:
1884         * WebView/WebViewPrivate.h:
1885
1886 2016-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1887
1888         Safari does not emit composition end if blurred for dead key / Japanese IME
1889         https://bugs.webkit.org/show_bug.cgi?id=164369
1890         <rdar://problem/29050439>
1891
1892         Reviewed by Ryosuke Niwa.
1893
1894         When canceling a composition, make sure that we clear the system IME state.
1895
1896         * WebCoreSupport/WebEditorClient.h:
1897         * WebCoreSupport/WebEditorClient.mm:
1898         (WebEditorClient::canceledComposition):
1899
1900 2016-11-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
1901
1902         Add a setting and preferences to enable/disable async image decoding
1903         https://bugs.webkit.org/show_bug.cgi?id=164417
1904
1905         Reviewed by Simon Fraser.
1906
1907         Hook up the asyncImageDecodingEnabled setting for WebKit1.
1908
1909         * WebView/WebPreferenceKeysPrivate.h:
1910         * WebView/WebPreferences.mm:
1911         (+[WebPreferences initialize]):
1912         (-[WebPreferences asyncImageDecodingEnabled]):
1913         (-[WebPreferences setAsyncImageDecodingEnabled:]):
1914         * WebView/WebPreferencesPrivate.h:
1915         * WebView/WebView.mm:
1916         (-[WebView _preferencesChanged:]):
1917
1918 2016-11-01  Alex Christensen  <achristensen@webkit.org>
1919
1920         Remove PassRefPtr from DumpRenderTree
1921         https://bugs.webkit.org/show_bug.cgi?id=164307
1922
1923         Reviewed by Sam Weinig.
1924
1925         * WebView/WebGeolocationPosition.mm:
1926         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1927
1928 2016-11-02  Romain Bellessort  <romain.bellessort@crf.canon.fr>
1929
1930         [Readable Streams API] Enable creation of ReadableByteStreamController
1931         https://bugs.webkit.org/show_bug.cgi?id=164014
1932
1933         Reviewed by Youenn Fablet.
1934
1935         Added flag for the byte stream part of Readable Streams API.
1936
1937         * Configurations/FeatureDefines.xcconfig:
1938
1939 2016-11-01  Ryosuke Niwa  <rniwa@webkit.org>
1940
1941         Remove CUSTOM_ELEMENTS build flag
1942         https://bugs.webkit.org/show_bug.cgi?id=164267
1943
1944         Reviewed by Antti Koivisto.
1945
1946         Removed the build flag.
1947
1948         * Configurations/FeatureDefines.xcconfig:
1949         * WebView/WebPreferences.mm:
1950         (+[WebPreferences initialize]):
1951         * WebView/WebView.mm:
1952         (-[WebView _preferencesChanged:]):
1953
1954 2016-11-01  Eric Carlson  <eric.carlson@apple.com>
1955
1956         [MediaStream] restrict media capture secure connections
1957         https://bugs.webkit.org/show_bug.cgi?id=164234
1958         <rdar://problem/28944906>
1959
1960         Reviewed by Alex Christensen.
1961
1962         * WebView/WebPreferenceKeysPrivate.h:
1963         * WebView/WebPreferences.mm:
1964         (+[WebPreferences initialize]): Initialize WebKitMediaCaptureRequiresSecureConnectionPreferenceKey.
1965         (-[WebPreferences mediaCaptureRequiresSecureConnection]): New.
1966         (-[WebPreferences setMediaCaptureRequiresSecureConnection:]): New.
1967         * WebView/WebPreferencesPrivate.h:
1968
1969         * WebView/WebView.mm:
1970         (-[WebView _preferencesChanged:]): Sync mediaCaptureRequiresSecureConnection.
1971
1972 2016-10-29  Filip Pizlo  <fpizlo@apple.com>
1973
1974         JSC should support SharedArrayBuffer
1975         https://bugs.webkit.org/show_bug.cgi?id=163986
1976
1977         Reviewed by Keith Miller.
1978         
1979         Support the RuntimeFlag.
1980
1981         * WebView/WebPreferencesPrivate.h:
1982
1983 2016-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
1984
1985         [WK1] Candidate visibility should not update as a result of selection during a dictionary lookup
1986         https://bugs.webkit.org/show_bug.cgi?id=164236
1987         <rdar://problem/28747712>
1988
1989         Reviewed by Beth Dakin.
1990
1991         See WebCore ChangeLog for more detail. Sets the Editor's isGettingDictionaryPopupInfo state to true during a
1992         dictionary lookup.
1993
1994         * WebCoreSupport/WebEditorClient.mm:
1995         (WebEditorClient::respondToChangedSelection):
1996         * WebView/WebImmediateActionController.mm:
1997         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1998
1999 2016-10-31  Darin Adler  <darin@apple.com>
2000
2001         Move ChildNode and ParentNode from ExceptionCode to Exception, add support for ExceptionOr<T&>
2002         https://bugs.webkit.org/show_bug.cgi?id=164214
2003
2004         Reviewed by Alex Christensen.
2005
2006         * DOM/DOMCSSPrimitiveValue.mm:
2007         (-[DOMCSSPrimitiveValue getCounterValue]): Updated since return value
2008         is a reference now.
2009         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
2010
2011         * DOM/DOMDocument.mm:
2012         (-[DOMDocument querySelector:]): Updated exception handling.
2013         (-[DOMDocument querySelectorAll:]): Ditto.
2014         * DOM/DOMDocumentFragment.mm:
2015         (-[DOMDocumentFragment querySelector:]): Ditto.
2016         (-[DOMDocumentFragment querySelectorAll:]): Ditto.
2017         * DOM/DOMElement.mm:
2018         (-[DOMElement querySelector:]): Ditto.
2019         (-[DOMElement querySelectorAll:]): Ditto.
2020
2021 2016-10-31  Darin Adler  <darin@apple.com>
2022
2023         Convert Document from ExceptionCode to Exception
2024         https://bugs.webkit.org/show_bug.cgi?id=164212
2025
2026         Reviewed by Alex Christensen.
2027
2028         * DOM/DOMDocument.mm:
2029         (-[DOMDocument setXmlVersion:]): Updated exception handling.
2030         (-[DOMDocument cookie]): Ditto.
2031         (-[DOMDocument setCookie:]): Ditto.
2032         (-[DOMDocument setBody:]): Ditto.
2033         (-[DOMDocument createElement:]): Ditto.
2034         (-[DOMDocument createCDATASection:]): Ditto.
2035         (-[DOMDocument createProcessingInstruction:data:]): Ditto.
2036         (-[DOMDocument createAttribute:]): Ditto.
2037         (-[DOMDocument createEntityReference:]): Ditto.
2038         (-[DOMDocument importNode:deep:]): Ditto.
2039         (-[DOMDocument createElementNS:qualifiedName:]): Ditto.
2040         (-[DOMDocument createAttributeNS:qualifiedName:]): Ditto.
2041         (-[DOMDocument getElementsByTagNameNS:localName:]): Ditto.
2042         (-[DOMDocument adoptNode:]): Ditto.
2043         (-[DOMDocument createEvent:]): Ditto.
2044
2045 2016-10-30  Darin Adler  <darin@apple.com>
2046
2047         Move Element, NamedNodeMap, and DOMStringMap from ExceptionCode to Exception
2048         https://bugs.webkit.org/show_bug.cgi?id=164206
2049
2050         Reviewed by Chris Dumez.
2051
2052         * DOM/DOMElement.mm:
2053         (-[DOMElement setInnerHTML:]): Updated exception handling.
2054         (-[DOMElement setOuterHTML:]): Ditto.
2055         (-[DOMElement setAttribute:value:]): Ditto.
2056         (-[DOMElement setAttributeNode:]): Ditto.
2057         (-[DOMElement removeAttributeNode:]): Ditto.
2058         (-[DOMElement setAttributeNS:qualifiedName:value:]): Ditto.
2059         (-[DOMElement setAttributeNodeNS:]): Ditto.
2060         (-[DOMElement matches:]): Ditto.
2061         (-[DOMElement closest:]): Ditto.
2062         (-[DOMElement webkitMatchesSelector:]): Ditto.
2063         * DOM/DOMHTMLElement.mm:
2064         (-[DOMHTMLElement insertAdjacentElement:element:]): Ditto.
2065         (-[DOMHTMLElement insertAdjacentHTML:html:]): Ditto.
2066         (-[DOMHTMLElement insertAdjacentText:text:]): Ditto.
2067         * DOM/DOMNamedNodeMap.mm:
2068         (-[DOMNamedNodeMap setNamedItem:]): Ditto.
2069         (-[DOMNamedNodeMap removeNamedItem:]): Ditto.
2070         (-[DOMNamedNodeMap setNamedItemNS:]): Ditto.
2071         (-[DOMNamedNodeMap removeNamedItemNS:localName:]): Ditto.
2072
2073 2016-10-29  Darin Adler  <darin@apple.com>
2074
2075         Convert more of DOM from ExceptionCode to Exception
2076         https://bugs.webkit.org/show_bug.cgi?id=164173
2077
2078         Reviewed by Ryosuke Niwa.
2079
2080         * DOM/DOMCharacterData.mm:
2081         (-[DOMCharacterData substringData:length:]): Updated since this
2082         now uses ExceptionOr.
2083         (-[DOMCharacterData insertData:data:]): Ditto.
2084         (-[DOMCharacterData deleteData:length:]): Ditto.
2085         (-[DOMCharacterData replaceData:length:data:]): Ditto.
2086         * DOM/DOMText.mm:
2087         (-[DOMText splitText:]): Ditto.
2088         (-[DOMText replaceWholeText:]): Removed unneeded exception code
2089         handling from function that does not throw an exception.
2090
2091 2016-10-28  Darin Adler  <darin@apple.com>
2092
2093         Move all classes in the HTML directory from ExceptionCode to Exception
2094         https://bugs.webkit.org/show_bug.cgi?id=163876
2095
2096         Reviewed by Sam Weinig.
2097
2098         * DOM/DOMCharacterData.mm:
2099         (-[DOMCharacterData remove]): Updated exception handling.
2100         * DOM/DOMDOMTokenList.mm:
2101         (-[DOMDOMTokenList toggle:force:]): Ditto.
2102         * DOM/DOMDocumentType.mm:
2103         (-[DOMDocumentType remove]): Ditto.
2104         * DOM/DOMElement.mm:
2105         (-[DOMElement remove]): Ditto.
2106         * DOM/DOMHTML.mm:
2107         (-[DOMHTMLInputElement setValueAsNumberWithChangeEvent:]): Ditto.
2108         * DOM/DOMHTMLCanvasElement.mm:
2109         (-[DOMHTMLCanvasElement toDataURL:]): Ditto.
2110         * DOM/DOMHTMLElement.mm:
2111         (-[DOMHTMLElement setInnerText:]): Ditto.
2112         (-[DOMHTMLElement setOuterText:]): Ditto.
2113         (-[DOMHTMLElement setContentEditable:]): Ditto.
2114         * DOM/DOMHTMLInputElement.mm:
2115         (-[DOMHTMLInputElement setMaxLength:]): Ditto.
2116         (-[DOMHTMLInputElement setValueAsDate:]): Ditto.
2117         (-[DOMHTMLInputElement setValueAsNumber:]): Ditto.
2118         (-[DOMHTMLInputElement stepUp:]): Ditto.
2119         (-[DOMHTMLInputElement stepDown:]): Ditto.
2120         (-[DOMHTMLInputElement setRangeText:]): Ditto.
2121         (-[DOMHTMLInputElement setRangeText:start:end:selectionMode:]): Ditto.
2122         * DOM/DOMHTMLMarqueeElement.mm:
2123         (-[DOMHTMLMarqueeElement setLoop:]): Ditto.
2124         * DOM/DOMHTMLMediaElement.mm:
2125         (-[DOMHTMLMediaElement setCurrentTime:]): Ditto.
2126         (-[DOMHTMLMediaElement setVolume:]): Ditto.
2127         * DOM/DOMHTMLOptionsCollection.mm:
2128         (-[DOMHTMLOptionsCollection setLength:]): Ditto.
2129         * DOM/DOMHTMLTableElement.mm:
2130         (-[DOMHTMLTableElement setCaption:]): Ditto.
2131         (-[DOMHTMLTableElement setTHead:]): Ditto.
2132         (-[DOMHTMLTableElement setTFoot:]): Ditto.
2133         (-[DOMHTMLTableElement insertRow:]): Ditto.
2134         (-[DOMHTMLTableElement deleteRow:]): Ditto.
2135         * DOM/DOMHTMLTableRowElement.mm:
2136         (-[DOMHTMLTableRowElement insertCell:]): Ditto.
2137         (-[DOMHTMLTableRowElement deleteCell:]): Ditto.
2138         * DOM/DOMHTMLTableSectionElement.mm:
2139         (-[DOMHTMLTableSectionElement insertRow:]): Ditto.
2140         (-[DOMHTMLTableSectionElement deleteRow:]): Ditto.
2141         * DOM/DOMHTMLTextAreaElement.mm:
2142         (-[DOMHTMLTextAreaElement setMaxLength:]): Ditto.
2143         (-[DOMHTMLTextAreaElement setRangeText:]): Ditto.
2144         (-[DOMHTMLTextAreaElement setRangeText:start:end:selectionMode:]): Ditto.
2145         * DOM/DOMHTMLVideoElement.mm:
2146         (-[DOMHTMLVideoElement webkitEnterFullscreen]): Ditto.
2147         (-[DOMHTMLVideoElement webkitEnterFullScreen]): Changed to call the other named
2148         version (lowercase S) instead of repeating the logic from that method.
2149         (-[DOMHTMLVideoElement webkitExitFullScreen]): Ditto.
2150         * DOM/DOMTimeRanges.mm:
2151         (-[DOMTimeRanges start:]): Updated exception handling.
2152         (-[DOMTimeRanges end:]): Ditto.
2153
2154 2016-10-27  Chris Dumez  <cdumez@apple.com>
2155
2156         Regression(r203601): Caused crashes in iBooks
2157         https://bugs.webkit.org/show_bug.cgi?id=164093
2158         <rdar://problem/28745634>
2159
2160         Reviewed by Darin Adler.
2161
2162         Restore pre-r203601 behavior when calling [DOMNode compareDocumentPosition:nil],
2163         which was to return Node::DOCUMENT_POSITION_DISCONNECTED.
2164
2165         * DOM/DOMNode.mm:
2166         (-[DOMNode compareDocumentPosition:]):
2167
2168 2016-10-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2169
2170         Support "insertFromDrop" and "deleteByDrag" for the InputEvent spec
2171         https://bugs.webkit.org/show_bug.cgi?id=163948
2172         <rdar://problem/28921433>
2173
2174         Reviewed by Darin Adler.
2175
2176         Add support for new drag and drop-related EditAction enum values.
2177
2178         * WebCoreSupport/WebEditorClient.mm:
2179         (undoNameForEditAction):
2180
2181 2016-10-27  Dan Bernstein  <mitz@apple.com>
2182
2183         Reapplied the configuration changes from r207934 without breaking iOS builds.
2184
2185         * Configurations/Base.xcconfig:
2186         * Configurations/WebKitLegacy.xcconfig:
2187
2188 2016-10-27  Dan Bernstein  <mitz@apple.com>
2189
2190         Reverted the configuration changes from r207934 because they broke iOS builds not using the Apple-internal SDK.
2191
2192         * Configurations/Base.xcconfig:
2193         * Configurations/WebKitLegacy.xcconfig:
2194
2195 2016-10-26  Dan Bernstein  <mitz@apple.com>
2196
2197         [Xcode] WebKit fails to build when CLANG_WARN_DOCUMENTATION_COMMENTS is enabled
2198         https://bugs.webkit.org/show_bug.cgi?id=164048
2199
2200         Reviewed by Tim Horton.
2201
2202         * Configurations/Base.xcconfig: Enabled CLANG_WARN_DOCUMENTATION_COMMENTS.
2203         * Configurations/WebKitLegacy.xcconfig: Made the compiler treat the icu headers as system
2204           headers.
2205
2206         * History/WebBackForwardList.h: Fixed parameter name in @param entry.
2207         * Misc/WebDownload.h: Removed empty entries.
2208         * Misc/WebIconDatabase.h: Remove incorrect @param entries.
2209         * Misc/WebQuotaManager.h: Added missing parameter names in @param entries.
2210         * WebView/WebFrameLoadDelegate.h: Corrected parameter names in @param entries.
2211         * WebView/WebFrameViewPrivate.h: Changed incorrect @result to @abstract.
2212         * WebView/WebPolicyDelegate.h: Fixed parameter name and removed incorrect @param entries.
2213         * WebView/WebPreferences.h: Changed @method to @property in a couple of places.
2214         * WebView/WebResourceLoadDelegate.h: Fixed parameter names.
2215         * WebView/WebUIDelegate.h: Filled in two empty @param entries. Added missing parameter name,
2216           Fixed a typo and removed empty @discussion entry. Fixed some parameter names.
2217         * WebView/WebUIDelegatePrivate.h: Fixed parameter names.
2218         * WebView/WebView.h: Changed @method to @property in a couple of places.
2219         * WebView/WebViewPrivate.h: Fixed parameter names, changed incorrect @result to @abstract.
2220
2221 2016-10-26  Brian Burg  <bburg@apple.com>
2222
2223         Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
2224         https://bugs.webkit.org/show_bug.cgi?id=164046
2225
2226         Reviewed by Joseph Pecoraro.
2227
2228         * WebCoreSupport/WebInspectorClient.h:
2229
2230 2016-10-21  Alex Christensen  <achristensen@webkit.org>
2231
2232         URL::port should return Optional<uint16_t>
2233         https://bugs.webkit.org/show_bug.cgi?id=163806
2234
2235         Reviewed by Darin Adler.
2236
2237         * WebCoreSupport/WebSecurityOrigin.mm:
2238         (-[WebSecurityOrigin port]):
2239
2240 2016-10-24  Dave Hyatt  <hyatt@apple.com>
2241
2242         Remove CSSCharsetRule from the CSS OM
2243         https://bugs.webkit.org/show_bug.cgi?id=163891
2244
2245         Reviewed by Darin Adler.
2246
2247         * DOM/DOMCSSCharsetRule.mm:
2248         (-[DOMCSSCharsetRule encoding]):
2249
2250 2016-10-24  Youenn Fablet  <youenn@apple.com>
2251
2252         Activate WEB_RTC compilation flags for Mac bots
2253         https://bugs.webkit.org/show_bug.cgi?id=163886
2254
2255         Reviewed by Eric Carlson.
2256
2257         * Configurations/FeatureDefines.xcconfig:
2258
2259 2016-10-23  Chris Dumez  <cdumez@apple.com>
2260
2261         addEventListener() / removeEventListener() should use a union for last parameter
2262         https://bugs.webkit.org/show_bug.cgi?id=163863
2263
2264         Reviewed by Darin Adler.
2265
2266         Cast BOOL to bool to help to compiler construct the new variant-type parameter.
2267
2268         * DOM/DOMNode.mm:
2269         (-[DOMNode addEventListener:listener:useCapture:]):
2270         (-[DOMNode addEventListener:::]):
2271         (-[DOMNode removeEventListener:listener:useCapture:]):
2272         (-[DOMNode removeEventListener:::]):
2273
2274 2016-10-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2275
2276         Support (insertFrom|deleteBy)Composition and (insert|delete)CompositionText inputTypes for InputEvents
2277         https://bugs.webkit.org/show_bug.cgi?id=163460
2278         <rdar://problem/28784142>
2279
2280         Reviewed by Darin Adler.
2281
2282         Handle new EditAction types for inserting/deleting pending/final compositions.
2283
2284         * WebCoreSupport/WebEditorClient.mm:
2285         (undoNameForEditAction):
2286
2287 2016-10-21  Jeremy Jones  <jeremyj@apple.com>
2288
2289         Implement basic pointer lock behavior for WebKit and WebKit2.
2290         https://bugs.webkit.org/show_bug.cgi?id=162745
2291
2292         Reviewed by Simon Fraser.
2293
2294         Add basic pointer lock functionality. User permission is not yet implemented.
2295
2296         * WebCoreSupport/WebChromeClient.h:
2297         * WebCoreSupport/WebChromeClient.mm:
2298         (WebChromeClient::requestPointerLock):
2299         (WebChromeClient::requestPointerUnlock):
2300
2301 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
2302
2303         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
2304         https://bugs.webkit.org/show_bug.cgi?id=163374
2305
2306         Reviewed by Darin Adler.
2307
2308         * Configurations/FeatureDefines.xcconfig:
2309
2310 2016-10-19  Alex Christensen  <achristensen@webkit.org>
2311
2312         Revert r207151
2313         https://bugs.webkit.org/show_bug.cgi?id=163675
2314
2315         Reviewed by Brent Fulgham.
2316
2317         * Misc/WebDownload.mm:
2318         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):
2319         * Misc/WebDownloadInternal.h:
2320         * WebCoreSupport/WebFrameLoaderClient.mm:
2321         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2322         * WebView/WebPreferences.mm:
2323         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
2324         * WebView/WebView.mm:
2325         (-[WebView scheduleInRunLoop:forMode:]):
2326         (-[WebView unscheduleFromRunLoop:forMode:]):
2327
2328 2016-10-19  Ryan Haddad  <ryanhaddad@apple.com>
2329
2330         Unreviewed, rolling out r207557.
2331
2332         This change caused animations/font-variations tests to time
2333         out on pre-Sierra Macs.
2334
2335         Reverted changeset:
2336
2337         "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
2338         iOS 9"
2339         https://bugs.webkit.org/show_bug.cgi?id=163374
2340         http://trac.webkit.org/changeset/207557
2341
2342 2016-10-19  Chris Dumez  <cdumez@apple.com>
2343
2344         Move HTML Interactive Form Validation behind an experimental flag
2345         https://bugs.webkit.org/show_bug.cgi?id=163673
2346
2347         Reviewed by Daniel Bates.
2348
2349         Re-disable HTML Interactive Form Validation by default on Mac WK1.
2350
2351         * WebView/WebViewData.mm:
2352         (-[WebViewPrivate init]):
2353
2354 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
2355
2356         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
2357         https://bugs.webkit.org/show_bug.cgi?id=163374
2358
2359         Reviewed by Darin Adler.
2360
2361         * Configurations/FeatureDefines.xcconfig:
2362
2363 2016-10-19  Simon Fraser  <simon.fraser@apple.com>
2364
2365         WebView needs to initialize the visualViewportEnabled Setting from WebKit preferences
2366         https://bugs.webkit.org/show_bug.cgi?id=163680
2367
2368         Reviewed by Dean Jackson.
2369
2370         Add code to set the Setting from WebKit prefs. This code is a mess and needs to be autogenerated.
2371
2372         * WebView/WebView.mm:
2373         (-[WebView _preferencesChanged:]):
2374
2375 2016-10-19  Darin Adler  <darin@apple.com>
2376
2377         Move XPath from ExceptionCode to Exception
2378         https://bugs.webkit.org/show_bug.cgi?id=163656
2379
2380         Reviewed by Chris Dumez.
2381
2382         * DOM/DOMDocument.mm:
2383         (wrap): Added. Helper function for wrapping a resolver.
2384         (-[DOMDocument createExpression:resolver:]): Use raiseOnDOMError.
2385         (-[DOMDocument evaluate:contextNode:resolver:type:inResult:]): Ditto.
2386         * DOM/DOMXPathExpression.mm:
2387         (-[DOMXPathExpression evaluate:type:inResult:]): Ditto.
2388         * DOM/DOMXPathResult.mm:
2389         (-[DOMXPathResult numberValue]): Ditto.
2390         (-[DOMXPathResult stringValue]): Ditto.
2391         (-[DOMXPathResult booleanValue]): Ditto.
2392         (-[DOMXPathResult singleNodeValue]): Ditto.
2393         (-[DOMXPathResult snapshotLength]): Ditto.
2394         (-[DOMXPathResult iterateNext]): Ditto.
2395         (-[DOMXPathResult snapshotItem:]): Ditto.
2396
2397 2016-10-18  Sam Weinig  <sam@webkit.org>
2398
2399         Replace std::experimental::variant with WTF::Variant (or similar)
2400         https://bugs.webkit.org/show_bug.cgi?id=163626
2401
2402         Reviewed by Chris Dumez.
2403
2404         Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
2405         into the WTF namespace.
2406
2407         * DOM/DOMHTMLSelectElement.mm:
2408         (-[DOMHTMLSelectElement add:before:]):
2409
2410 2016-10-18  Simon Fraser  <simon.fraser@apple.com>
2411
2412         Add a MiniBrowser menu item to apply page scale in WK1 and WK2
2413         https://bugs.webkit.org/show_bug.cgi?id=163627
2414
2415         Reviewed by Dean Jackson.
2416
2417         Add an explanatory comment about viewScaleFactor not really being viewScaleFactor.
2418
2419         * WebView/WebViewPrivate.h:
2420
2421 2016-10-18  Dean Jackson  <dino@apple.com>
2422
2423         Remove CSS_SHAPES feature definition. This should always be on.
2424         https://bugs.webkit.org/show_bug.cgi?id=163628
2425         <rdar://problem/28834613>
2426
2427         Reviewed by Tim Horton.
2428
2429         * Configurations/FeatureDefines.xcconfig:
2430
2431 2016-10-18  Chris Dumez  <cdumez@apple.com>
2432
2433         Leverage new union type support for HTMLSelectElement.add() / HTMLOptionsCollection.add()
2434         https://bugs.webkit.org/show_bug.cgi?id=163608
2435
2436         Reviewed by Ryosuke Niwa.
2437
2438         Update add() call sites now that it takes std::variant types in.
2439
2440         * DOM/DOMHTMLOptionsCollection.mm:
2441         (-[DOMHTMLOptionsCollection add:index:]):
2442         * DOM/DOMHTMLSelectElement.mm:
2443         (-[DOMHTMLSelectElement add:before:]):
2444
2445 2016-10-18  Anders Carlsson  <andersca@apple.com>
2446
2447         Get rid of more WebHistoryItem cruft
2448         https://bugs.webkit.org/show_bug.cgi?id=163623
2449
2450         Reviewed by Tim Horton.
2451
2452         * History/WebHistoryItem.mm:
2453         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2454         * History/WebHistoryItemPrivate.h:
2455
2456 2016-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2457
2458         Showing and hiding candidates list is very distracting after selecting word
2459         https://bugs.webkit.org/show_bug.cgi?id=163609
2460         <rdar://problem/28747712>
2461
2462         Reviewed by Tim Horton.
2463
2464         Introduce WebView hooks for mousedown and mouseup. See radar for more details.
2465
2466         * WebView/WebHTMLView.mm:
2467         (-[WebHTMLView mouseDown:mouseDown:]):
2468         (-[WebHTMLView mouseUp:mouseUp:]):
2469         * WebView/WebView.mm:
2470         (-[WebView prepareForMouseDown]):
2471         (-[WebView prepareForMouseUp]):
2472         * WebView/WebViewInternal.h:
2473
2474 2016-10-17  Anders Carlsson  <andersca@apple.com>
2475
2476         Move some history specific HistoryItem code to WebHistoryItem
2477         https://bugs.webkit.org/show_bug.cgi?id=163567
2478
2479         Reviewed by Tim Horton.
2480
2481         * History/HistoryPropertyList.mm:
2482         (HistoryPropertyListWriter::writeHistoryItem):
2483         * History/WebHistory.mm:
2484         (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
2485         * History/WebHistoryItem.mm:
2486         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2487         * History/WebHistoryItemInternal.h:
2488         * WebCoreSupport/WebFrameLoaderClient.mm:
2489         (addRedirectURL):
2490         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
2491
2492 2016-10-18  Eric Carlson  <eric.carlson@apple.com>
2493
2494         [MediaStream] Resolve constraints and enumerate devices in the UI process
2495         https://bugs.webkit.org/show_bug.cgi?id=162147
2496         <rdar://problem/28803569>
2497
2498         Reviewed by Darin Adler.
2499
2500         * WebCoreSupport/WebUserMediaClient.h:
2501         * WebCoreSupport/WebUserMediaClient.mm:
2502         (AddPermissionCheckToMap):
2503         (RemovePermissionCheckFromMap):
2504         (WebUserMediaClient::pageDestroyed):
2505         (WebUserMediaClient::requestUserMediaAccess):
2506         (WebUserMediaClient::enumerateMediaDevices):
2507         (WebUserMediaClient::cancelMediaDevicesEnumerationRequest):
2508         (-[WebUserMediaPolicyListener allow]):
2509         (-[WebUserMediaPolicyListener deny]):
2510         (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
2511         (-[WebUserMediaPolicyCheckerListener cancelMediaDevicesEnumerationRequest]):
2512         (-[WebUserMediaPolicyCheckerListener allow]):
2513         (-[WebUserMediaPolicyCheckerListener deny]):
2514         (WebUserMediaClient::checkUserMediaPermission): Deleted.
2515         (WebUserMediaClient::cancelUserMediaPermissionCheck): Deleted.
2516         (-[WebUserMediaPolicyCheckerListener initWithUserMediaPermissionCheck:]): Deleted.
2517         (-[WebUserMediaPolicyCheckerListener cancelUserMediaPermissionCheck]): Deleted.
2518
2519 2016-10-17  Antti Koivisto  <antti@apple.com>
2520
2521         Rename setNeedsStyleRecalc to invalidateStyle
2522         https://bugs.webkit.org/show_bug.cgi?id=163542
2523
2524         Reviewed by Darin Adler.
2525
2526         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2527         (-[WebHostedNetscapePluginView createPluginLayer]):
2528         * Plugins/WebNetscapePluginView.mm:
2529         (-[WebNetscapePluginView createPlugin]):
2530
2531 2016-10-17  Jeremy Jones  <jeremyj@apple.com>
2532
2533         Enable keyboard in fullscreen.
2534         https://bugs.webkit.org/show_bug.cgi?id=163146
2535
2536         Reviewed by Jer Noble.
2537
2538         Allow keyboard in fullscreen.
2539
2540         * WebView/WebView.mm:
2541         (-[WebView _supportsFullScreenForElement:withKeyboard:]):
2542
2543 2016-10-17  Chris Dumez  <cdumez@apple.com>
2544
2545         Move form.reportValidity() behind InteractiveFormValidation setting
2546         https://bugs.webkit.org/show_bug.cgi?id=163550
2547
2548         Reviewed by Darin Adler.
2549
2550         Enable InteractiveFormValidation setting by default and link it to
2551         RuntimeEnabledFeatures so we can use it in the IDL.
2552
2553         * WebView/WebView.mm:
2554         (-[WebView _preferencesChanged:]):
2555         * WebView/WebViewData.mm:
2556         (-[WebViewPrivate init]):
2557
2558 2016-10-17  Anders Carlsson  <andersca@apple.com>
2559
2560         Fix iOS build.
2561
2562         * History/WebBackForwardList.mm:
2563         (-[WebBackForwardList dictionaryRepresentation]):
2564
2565 2016-10-17  Anders Carlsson  <andersca@apple.com>
2566
2567         CTTE some of the BackForwardList member functions
2568         https://bugs.webkit.org/show_bug.cgi?id=163555
2569
2570         Reviewed by Dan Bernstein.
2571
2572         * History/BackForwardList.h:
2573         (BackForwardList::entries):
2574         * History/BackForwardList.mm:
2575         (BackForwardList::removeItem):
2576         (BackForwardList::containsItem):
2577         (BackForwardList::entries): Deleted.
2578         * History/WebBackForwardList.mm:
2579         (-[WebBackForwardList removeItem:]):
2580         (-[WebBackForwardList containsItem:]):
2581         (-[WebBackForwardList description]):
2582
2583 2016-10-17  Anders Carlsson  <andersca@apple.com>
2584
2585         Remove WEBCORE_EXPORT from BackForwardList, it lives in WebKit now
2586         https://bugs.webkit.org/show_bug.cgi?id=163551
2587
2588         Reviewed by Tim Horton.
2589
2590         * History/BackForwardList.h:
2591
2592 2016-10-16  Darin Adler  <darin@apple.com>
2593
2594         Move CSS classes from ExceptionCode to Exception
2595         https://bugs.webkit.org/show_bug.cgi?id=163494
2596
2597         Reviewed by Sam Weinig.
2598
2599         * DOM/DOMCSSMediaRule.mm:
2600         (-[DOMCSSMediaRule insertRule:index:]): Use raiseOnDOMError
2601         the new way to handle ExceptionOr instead of ExceptionCode.
2602         (-[DOMCSSMediaRule deleteRule:]): Ditto.
2603         * DOM/DOMCSSPrimitiveValue.mm:
2604         (-[DOMCSSPrimitiveValue setFloatValue:floatValue:]): Ditto.
2605         (-[DOMCSSPrimitiveValue getFloatValue:]): Ditto.
2606         (-[DOMCSSPrimitiveValue setStringValue:stringValue:]): Ditto.
2607         (-[DOMCSSPrimitiveValue getStringValue]): Ditto.
2608         (-[DOMCSSPrimitiveValue getCounterValue]): Ditto.
2609         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
2610         (-[DOMCSSPrimitiveValue getRGBColorValue]): Ditto.
2611         * DOM/DOMCSSRule.mm:
2612         (-[DOMCSSRule setCssText:]): Ditto.
2613         * DOM/DOMCSSStyleDeclaration.mm:
2614         (-[DOMCSSStyleDeclaration setCssText:]): Ditto.
2615         (-[DOMCSSStyleDeclaration removeProperty:]): Ditto.
2616         (-[DOMCSSStyleDeclaration setProperty:value:priority:]): Ditto.
2617         * DOM/DOMCSSStyleSheet.mm:
2618         (-[DOMCSSStyleSheet insertRule:index:]): Ditto.
2619         (-[DOMCSSStyleSheet deleteRule:]): Ditto.
2620         (-[DOMCSSStyleSheet addRule:style:index:]): Ditto.
2621         (-[DOMCSSStyleSheet removeRule:]): Ditto.
2622         * DOM/DOMCSSValue.mm:
2623         (-[DOMCSSValue setCssText:]): Ditto.
2624         * DOM/DOMMediaList.mm:
2625         (-[DOMMediaList setMediaText:]): Ditto.
2626         (-[DOMMediaList deleteMedium:]): Ditto.
2627         (-[DOMMediaList appendMedium:]): Ditto.
2628
2629         * DOM/ExceptionHandlers.h: Added an overload of raiseDOMException
2630         that works with a WebCore::Exception&& and overloads of
2631         raiseOnDOMError that work with WebCore::ExceptionOr&&.
2632         * DOM/ExceptionHandlers.mm:
2633         (raiseDOMException): Implemented the new version.
2634
2635 2016-10-15  Dan Bernstein  <mitz@apple.com>
2636
2637         REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
2638         https://bugs.webkit.org/show_bug.cgi?id=163492
2639         <rdar://problem/28654799>
2640
2641         Reviewed by Darin Adler.
2642
2643         Test: TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm
2644
2645         * WebView/WebHTMLView.mm:
2646         (createMenuItem): Set the tag for items that have submenus as well.
2647
2648 2016-10-14  Anders Carlsson  <andersca@apple.com>
2649
2650         Clean up BackForwardClient
2651         https://bugs.webkit.org/show_bug.cgi?id=163454
2652
2653         Reviewed by Sam Weinig.
2654
2655         * History/BackForwardList.h:
2656         Remove override keywords.
2657
2658         * History/BackForwardList.mm:
2659         (BackForwardList::clearAllPageCaches): Deleted.
2660         Remove this, it's no longer used.
2661
2662         * WebView/WebView.mm:
2663         (-[WebView _clearBackForwardCache]): Deleted.
2664         * WebView/WebViewPrivate.h:
2665         Remove SPI that's no longer used by anyone.
2666
2667 2016-10-13  Anders Carlsson  <andersca@apple.com>
2668
2669         Move BackForwardList from WebCore to WebKitLegacy
2670         https://bugs.webkit.org/show_bug.cgi?id=163418
2671
2672         Reviewed by Tim Horton.
2673
2674         * History/BackForwardList.h: Renamed from Source/WebCore/history/BackForwardList.h.
2675         (BackForwardList::create):
2676         (BackForwardList::webView):
2677         * History/BackForwardList.mm: Renamed from Source/WebCore/history/BackForwardList.cpp.
2678         (BackForwardList::BackForwardList):
2679         (BackForwardList::close):
2680         (BackForwardList::containsItem):
2681         * History/WebBackForwardList.mm:
2682         (kit):
2683         (-[WebBackForwardList initWithBackForwardList:]):
2684         (-[WebBackForwardList setPageCacheSize:]):
2685         (-[WebBackForwardList pageCacheSize]):
2686         * History/WebBackForwardListInternal.h:
2687         * WebCoreSupport/WebFrameLoaderClient.mm:
2688         * WebView/WebFrameView.mm:
2689         * WebView/WebView.mm:
2690         (-[WebView _commonInitializationWithFrameName:groupName:]):
2691         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2692
2693 2016-10-13  Anders Carlsson  <andersca@apple.com>
2694
2695         Get rid of the HistoryItemVector typedef
2696         https://bugs.webkit.org/show_bug.cgi?id=163398
2697
2698         Reviewed by Beth Dakin.
2699
2700         Expand the HistoryitemVector typedef instead to make it more clear what types we are dealing with.
2701
2702         * History/WebBackForwardList.mm:
2703         (-[WebBackForwardList dictionaryRepresentation]):
2704         (vectorToNSArray):
2705         (-[WebBackForwardList backListWithLimit:]):
2706         (-[WebBackForwardList forwardListWithLimit:]):
2707         (-[WebBackForwardList description]):
2708         * History/WebHistoryItem.mm:
2709         (-[WebHistoryItem description]):
2710
2711 2016-10-12  Chris Dumez  <cdumez@apple.com>
2712
2713         [Web IDL] Drop support for legacy [ConstructorConditional=*]
2714         https://bugs.webkit.org/show_bug.cgi?id=163368
2715
2716         Reviewed by Ryosuke Niwa.
2717
2718         Drop ENABLE_DOM4_EVENTS_CONSTRUCTOR compiler flag.
2719
2720         * Configurations/FeatureDefines.xcconfig:
2721
2722 2016-10-12  Beth Dakin  <bdakin@apple.com>
2723
2724         Adobe Contribute CS 6.5 Trial crashes on launch
2725         https://bugs.webkit.org/show_bug.cgi?id=163365
2726         -and corresponding-
2727         <rdar://problem/28732731>
2728
2729         Reviewed by Tim Horton.
2730
2731         * Carbon/CarbonWindowFrame.m:
2732         (-[CarbonWindowFrame contentFill]):
2733
2734 2016-10-11  Daniel Bates  <dabates@apple.com>
2735
2736         Attempt to fix the Apple Internal Mac build following r207159
2737         (https://bugs.webkit.org/show_bug.cgi?id=163244)
2738
2739         * WebView/WebView.mm:
2740         (shouldRequireUserGestureToLoadVideo):
2741
2742 2016-10-11  Daniel Bates  <dabates@apple.com>
2743
2744         REGRESSION (r198251): -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO
2745         https://bugs.webkit.org/show_bug.cgi?id=163259
2746         <rdar://problem/28680515>
2747
2748         Reviewed by Jer Noble.
2749
2750         In WebKit1 on iOS we want to require user action to load and play videos by default and
2751         allow an embedding app to change this behavior via -[UIWebView setMediaPlaybackRequiresUserAction:].
2752         Following r198251, -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO and videos
2753         can load and play without being initiated by a user action.
2754
2755         * WebView/WebPreferences.mm:
2756         (+[WebPreferences initialize]): Initialize the default value of the deprecated preference
2757         WebKitRequiresUserGestureForMediaPlaybackPreferenceKey to YES on iOS. The value of this
2758         preference takes precedence over the values of its replacement preferences
2759         WebKitRequiresUserGestureForVideoPlaybackPreferenceKey and WebKitRequiresUserGestureForAudioPlaybackPreferenceKey.
2760
2761 2016-10-11  Daniel Bates  <dabates@apple.com>
2762
2763         [iOS] REGRESSION (r197953): User gesture required to load video in iOS 9-built apps
2764         https://bugs.webkit.org/show_bug.cgi?id=163244
2765         <rdar://problem/27250015>
2766
2767         Reviewed by Jer Noble.
2768
2769         Enable or disable the Setting::requiresUserGestureToLoadVideo() in legacy WebKit depending
2770         on the version of iOS SDK that the app was linked against. We require a user gesture to
2771         begin loading a video as of iOS 10.
2772
2773         * WebView/WebView.mm:
2774         (shouldRequireUserGestureToLoadVideo):
2775         (-[WebView _preferencesChanged:]): Modified to pass the WebKit requiresUserGestureToLoadVideo
2776         preference to WebCore.
2777
2778 2016-10-11  Alex Christensen  <achristensen@webkit.org>
2779
2780         Remove dead networking code
2781         https://bugs.webkit.org/show_bug.cgi?id=163263
2782
2783         Reviewed by Daniel Bates.
2784
2785         * Misc/WebDownload.mm:
2786         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
2787         * Misc/WebDownloadInternal.h:
2788         * WebCoreSupport/WebFrameLoaderClient.mm:
2789         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2790         * WebView/WebPreferences.mm:
2791         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
2792         * WebView/WebView.mm:
2793         (-[WebView scheduleInRunLoop:forMode:]):
2794         (-[WebView unscheduleFromRunLoop:forMode:]):
2795
2796 2016-10-10  Zan Dobersek  <zdobersek@igalia.com>
2797
2798         Add ENABLE_ENCRYPTED_MEDIA configuration option
2799         https://bugs.webkit.org/show_bug.cgi?id=163219
2800
2801         Reviewed by Darin Adler.
2802
2803         * Configurations/FeatureDefines.xcconfig:
2804         Add the ENABLE_ENCRYPTED_MEDIA configuration option. It will be used
2805         to enable or disable the new EME implementation at build-time.
2806
2807 2016-10-10  Darin Adler  <darin@apple.com>
2808
2809         Move NotificationCenter from legacy to new DOM exceptions
2810         https://bugs.webkit.org/show_bug.cgi?id=163217
2811
2812         Reviewed by Chris Dumez.
2813
2814         * WebView/WebView.mm:
2815         (-[WebView _notificationIDForTesting:]): Pass reference to page rather than pointer.
2816
2817 2016-10-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2818
2819         Support InputEvent.inputType for the new InputEvent spec
2820         https://bugs.webkit.org/show_bug.cgi?id=163025
2821         <rdar://problem/28658092>
2822
2823         Reviewed by Darin Adler.
2824
2825         Accounts for some changes to the EditAction enum in nameForEditAction. See WebCore ChangeLog
2826         entry for more details.
2827
2828         * WebCoreSupport/WebEditorClient.mm:
2829         (undoNameForEditAction):
2830
2831 2016-10-06  Darin Adler  <darin@apple.com>
2832
2833         Next step on moving to modern way to return DOM exceptions
2834         https://bugs.webkit.org/show_bug.cgi?id=163016
2835
2836         Reviewed by Ryosuke Niwa.
2837
2838         * DOM/DOMDOMImplementation.mm:
2839         (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated for
2840         name change from takeReturnValue to releaseReturnValue.
2841         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
2842
2843 2016-10-07  Simon Fraser  <simon.fraser@apple.com>
2844
2845         [WK1 Mac] Fix repaints of fixed-background elements in layer-backed WebViews
2846         https://bugs.webkit.org/show_bug.cgi?id=163154
2847         rdar://problem/28674216
2848
2849         Reviewed by Tim Horton.
2850         
2851         r55159 added code to counteract AppKit's adjustment of dirty regions during scrolling,
2852         by offsetting the dirty rect in -setNeedsDisplayInRect: if the call happens during
2853         the NSViewBoundsDidChangeNotification handling.
2854         
2855         However, AppKit only does dirty region adjustment in the code path that blits ("copy
2856         on scroll"), so r55159 produces incorrect behavior in, for example, layer-backed views.
2857         
2858         Fix by overriding -[NSClipView _canCopyOnScrollForDeltaX:deltaY:] to know if a single
2859         scroll is going to blit, and only do adjustments in -setNeedsDisplayInRect: if it is.
2860
2861         * WebView/WebClipView.h:
2862         * WebView/WebClipView.mm:
2863         (-[WebClipView _immediateScrollToPoint:]):
2864         (-[WebClipView _canCopyOnScrollForDeltaX:deltaY:]):
2865         (-[WebClipView currentScrollIsBlit]):
2866         * WebView/WebHTMLView.mm:
2867         (-[WebHTMLView setNeedsDisplayInRect:]):
2868         (-[WebHTMLView drawRect:]):
2869
2870 2016-10-06  Youenn Fablet  <youenn@apple.com>
2871
2872         CachedResource client handling methods should take reference
2873         https://bugs.webkit.org/show_bug.cgi?id=163014
2874
2875         Reviewed by Alex Christensen.
2876
2877         * WebView/WebHTMLView.mm:
2878         (promisedDataClient):
2879
2880 2016-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
2881
2882         Put variation fonts work behind a compile-time flag
2883         https://bugs.webkit.org/show_bug.cgi?id=162949
2884
2885         Reviewed by Simon Fraser.
2886
2887         * Configurations/FeatureDefines.xcconfig:
2888
2889 2016-10-05  Zan Dobersek  <zdobersek@igalia.com>
2890
2891         Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
2892         https://bugs.webkit.org/show_bug.cgi?id=162903
2893
2894         Reviewed by Alex Christensen.
2895
2896         Rename build guards for the remaining implementation of the legacy EME API
2897         to ENABLE_LEGACY_ENCRYPTED_MEDIA. This will allow for the future implementation
2898         of the near-finished API to be guarded with the simple ENABLE_ENCRYPTED_MEDIA guards.
2899
2900         * Configurations/FeatureDefines.xcconfig:
2901         * WebView/WebPreferences.mm:
2902         (+[WebPreferences initialize]):
2903         * WebView/WebView.mm:
2904         (-[WebView _preferencesChanged:]):
2905
2906 2016-10-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
2907
2908         The dragged image should be the current frame only of the animated image
2909         https://bugs.webkit.org/show_bug.cgi?id=162109
2910
2911         Reviewed by Tim Horton.
2912
2913         * DOM/DOM.mm:
2914         (-[DOMElement image]): Call the Image function with its new name.
2915         (-[DOMElement _imageTIFFRepresentation]): Ditto.
2916         * Misc/WebElementDictionary.mm:
2917         (-[WebElementDictionary _image]): Call the Image function with its new name.
2918         * Misc/WebIconDatabase.mm:
2919         (-[WebIconDatabase defaultIconWithSize:]): Call snapshotNSImage() to create the icon image.
2920         (webGetNSImage): Call the Image function with its new name.
2921         * WebCoreSupport/WebContextMenuClient.mm:
2922         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call snapshotNSImage() instead of nsImage()..
2923         (WebContextMenuClient::contextMenuForEvent): Ditto.
2924         * WebView/WebHTMLView.mm:
2925         (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
2926
2927 2016-10-02  Ryan Haddad  <ryanhaddad@apple.com>
2928
2929         Unreviewed, rolling out r206683.
2930
2931         This change caused API test WebKit2.FindMatches to fail on
2932         Mac.
2933
2934         Reverted changeset:
2935
2936         "The dragged image should be the current frame only of the
2937         animated image"
2938         https://bugs.webkit.org/show_bug.cgi?id=162109
2939         http://trac.webkit.org/changeset/206683
2940
2941 2016-09-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
2942
2943         The dragged image should be the current frame only of the animated image
2944         https://bugs.webkit.org/show_bug.cgi?id=162109
2945
2946         Reviewed by Tim Horton.
2947
2948         * DOM/DOM.mm:
2949         (-[DOMElement image]): Call the Image function with its new name.
2950         (-[DOMElement _imageTIFFRepresentation]): Ditto.
2951         * Misc/WebElementDictionary.mm:
2952         (-[WebElementDictionary _image]): Call the Image function with its new name.
2953         * Misc/WebIconDatabase.mm:
2954         (-[WebIconDatabase defaultIconWithSize:]): Call currentFrameNSImage() to create the icon image.
2955         (webGetNSImage): Call the Image function with its new name.
2956         * WebCoreSupport/WebContextMenuClient.mm:
2957         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call currentFrameNSImage() instead of nsImage()..
2958         (WebContextMenuClient::contextMenuForEvent): Ditto.
2959         * WebView/WebHTMLView.mm:
2960         (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
2961
2962 2016-09-27  Jer Noble  <jer.noble@apple.com>
2963
2964         Remove deprecated ENCRYPTED_MEDIA implementation.
2965         https://bugs.webkit.org/show_bug.cgi?id=161010
2966
2967         Remove ENABLE_ENCRYPTED_MEDIA.
2968
2969         Reviewed by Eric Carlson.
2970
2971         * Configurations/FeatureDefines.xcconfig:
2972
2973 2016-09-26  Daniel Bates  <dabates@apple.com>
2974
2975         Rename IOS_TEXT_AUTOSIZING to TEXT_AUTOSIZING
2976         https://bugs.webkit.org/show_bug.cgi?id=162365
2977
2978         Reviewed by Simon Fraser.
2979
2980         * Configurations/FeatureDefines.xcconfig:
2981         * WebView/WebFrame.mm:
2982         * WebView/WebPreferences.mm:
2983         (+[WebPreferences initialize]):
2984         * WebView/WebView.mm:
2985         (-[WebView _preferencesChanged:]):
2986
2987 2016-09-25  Antti Koivisto  <antti@apple.com>
2988
2989         AuthorStyleSheets shouldn't trigger synchronous style resolutions
2990         https://bugs.webkit.org/show_bug.cgi?id=162532
2991
2992         Reviewed by Darin Adler.
2993
2994         * WebView/WebHTMLView.mm:
2995         (-[WebHTMLView reapplyStyles]):
2996         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2997
2998 2016-09-24  Antti Koivisto  <antti@apple.com>
2999
3000         Move stylesheet change logic from Document to AuthorStyleSheets
3001         https://bugs.webkit.org/show_bug.cgi?id=162488
3002
3003         Reviewed by Andreas Kling.
3004
3005         * WebView/WebHTMLView.mm:
3006         (-[WebHTMLView reapplyStyles]):
3007         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
3008
3009 2016-09-23  Caitlin Potter  <caitp@igalia.com>
3010
3011         [JSC] Implement parsing of Async Functions
3012         https://bugs.webkit.org/show_bug.cgi?id=161409
3013
3014         Reviewed by Yusuke Suzuki.
3015
3016         * Configurations/FeatureDefines.xcconfig:
3017
3018 2016-09-23  Commit Queue  <commit-queue@webkit.org>
3019
3020         Unreviewed, rolling out r206311.
3021         https://bugs.webkit.org/show_bug.cgi?id=162495
3022
3023         Broke internal iOS build (Requested by anttik on #webkit).
3024
3025         Reverted changeset:
3026
3027         "Move stylesheet change logic from Document to
3028         AuthorStyleSheets"
3029         https://bugs.webkit.org/show_bug.cgi?id=162488
3030         http://trac.webkit.org/changeset/206311
3031
3032 2016-09-23  Antoine Quint  <graouts@apple.com>
3033
3034         Add a new runtime flag for work on modern media controls (off by default)
3035         https://bugs.webkit.org/show_bug.cgi?id=162420
3036         <rdar://problem/27989489>
3037
3038         Reviewed by Eric Carlson.
3039
3040         * WebView/WebPreferenceKeysPrivate.h:
3041         * WebView/WebPreferences.mm:
3042         (-[WebPreferences modernMediaControlsEnabled]):
3043         (-[WebPreferences setModernMediaControlsEnabled:]):
3044         * WebView/WebPreferencesPrivate.h:
3045         * WebView/WebView.mm:
3046         (-[WebView _preferencesChanged:]):
3047
3048 2016-09-21  Anders Carlsson  <andersca@apple.com>
3049
3050         Support openPaymentSetup API on ApplePaySession object
3051         https://bugs.webkit.org/show_bug.cgi?id=162357
3052         rdar://problem/26776939
3053
3054         Reviewed by Tim Horton.
3055
3056         Add openPaymentSetup stub.
3057
3058         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3059         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3060         (WebPaymentCoordinatorClient::openPaymentSetup):
3061
3062 2016-09-19  Daniel Bates  <dabates@apple.com>
3063
3064         Remove ENABLE(TEXT_AUTOSIZING) automatic text size adjustment code
3065         https://bugs.webkit.org/show_bug.cgi?id=162167
3066
3067         Reviewed by Simon Fraser.
3068
3069         * Configurations/FeatureDefines.xcconfig:
3070
3071 2016-09-19  Joseph Pecoraro  <pecoraro@apple.com>
3072
3073         Web Inspector: Bring the inspected page's window forward when activating element search
3074         https://bugs.webkit.org/show_bug.cgi?id=162114
3075         <rdar://problem/28349357>
3076
3077         Reviewed by Brian Burg.
3078
3079         * WebCoreSupport/WebInspectorClient.mm:
3080         (WebInspectorClient::didSetSearchingForNode):
3081         When element search is activated bring the window
3082         containing the inspected page to the foreground.
3083
3084 2016-09-15  Brady Eidson  <beidson@apple.com>
3085
3086         WKWebView.hasOnlySecureContent always returns "YES" after going back to a CachedPage (even if it has http resources).
3087         <rdar://problem/27681261> and https://bugs.webkit.org/show_bug.cgi?id=162043
3088
3089         Reviewed by Brent Fulgham. 
3090
3091         * WebCoreSupport/WebFrameLoaderClient.h:
3092         * WebCoreSupport/WebFrameLoaderClient.mm:
3093         (WebFrameLoaderClient::dispatchDidCommitLoad):
3094
3095 2016-09-15  Anders Carlsson  <andersca@apple.com>
3096
3097         This was supposed to be committed with the previous patch!
3098
3099         * Plugins/WebBasePluginPackage.mm:
3100         (pathByResolvingSymlinksAndAliases): Deleted.
3101
3102 2016-09-15  Anders Carlsson  <andersca@apple.com>
3103
3104         Replace use of Carbon file system APIs in plug-in loading
3105         https://bugs.webkit.org/show_bug.cgi?id=162040
3106         rdar://problem/6017896
3107
3108         Reviewed by Sam Weinig.
3109
3110         * Plugins/WebBasePluginPackage.mm:
3111         (-[WebBasePluginPackage initWithPath:]):
3112         Use -[NSString stringByResolvingSymlinksInPath] directly here. We already check for duplicate bundle IDs, so there's no need to try
3113         to resolve aliases as well (and the modern WebKit plug-in implementation doesn't do this).
3114
3115 2016-09-15  Beth Dakin  <bdakin@apple.com>
3116
3117         Need hasMarkedText on Mac
3118         https://bugs.webkit.org/show_bug.cgi?id=162026
3119         -and corresponding-
3120         rdar://problem/28272353
3121
3122         Reviewed by Anders Carlsson.
3123
3124         * WebView/WebHTMLViewInternal.h:
3125
3126 2016-09-12  Dean Jackson  <dino@apple.com>
3127
3128         Replace RGBA32 with Color in member variables
3129         https://bugs.webkit.org/show_bug.cgi?id=161856
3130         <rdar://problem/28254324>
3131
3132         Reviewed by Simon Fraser.
3133
3134         In preparation for the Color class to become more than
3135         just a 4-byte RGBA value, I went through a few places
3136         that were using the RGBA32 type directly, and replaced
3137         them with Color. This will make some objects a little
3138         bigger e.g. BorderValue and its friends.
3139
3140         I mostly looked at the places that were using RGBA32 as
3141         a member variable. There is still a lot of RGBA32 use
3142         around the project, in particular the CSS parser.
3143
3144         There should be no behaviour change.
3145
3146         * Misc/WebKitNSStringExtras.mm:
3147         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Explicitly
3148         call a Color constructor, rather than passing an RGBA32.
3149
3150 2016-09-13  Chris Dumez  <cdumez@apple.com>
3151
3152         Drop support for <isindex>
3153         https://bugs.webkit.org/show_bug.cgi?id=7139
3154
3155         Reviewed by Ryosuke Niwa.
3156
3157         Drop references to isindex.
3158
3159         * WebCoreSupport/WebEditorClient.mm:
3160         (attributesForAttributedStringConversion):
3161         * WebView/WebHTMLView.mm:
3162         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
3163
3164 2016-09-12  Chris Dumez  <cdumez@apple.com>
3165
3166         Switch remaining users of Document::inPageCache() to pageCacheState()
3167         https://bugs.webkit.org/show_bug.cgi?id=161865
3168
3169         Reviewed by Darin Adler.
3170
3171         Switch remaining users of Document::inPageCache() to pageCacheState() as
3172         the former one is confusing (given that it returns true while the
3173         pagehide event is being fired).
3174
3175         * WebView/WebHTMLView.mm:
3176         (-[WebHTMLView layoutToMinimumPageWidth:height:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustingViewSize:]):
3177         (-[WebHTMLView setNeedsLayout:]):
3178         (-[WebHTMLView setNeedsToApplyStyles:]):
3179
3180 2016-09-09  Tim Horton  <timothy_horton@apple.com>
3181
3182         Text replacement candidates don't always overwrite the entire original string
3183         https://bugs.webkit.org/show_bug.cgi?id=161779
3184         <rdar://problem/28033492>
3185
3186         Reviewed by Simon Fraser.
3187
3188         * WebCoreSupport/WebEditorClient.mm:
3189         (WebEditorClient::requestCandidatesForSelection):
3190         Make use of the shared implementation of contextRangeForCandidateRequest.
3191
3192 2016-09-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
3193
3194         Move the BitmapImage platform dependent code to a new file named NativeImage[CG|Cairo].cpp
3195         https://bugs.webkit.org/show_bug.cgi?id=158684
3196
3197         Reviewed by Simon Fraser.
3198
3199         * DOM/DOM.mm:
3200         (-[DOMNode getPreviewSnapshotImage:andRects:]):
3201         * Misc/WebCache.mm:
3202         (+[WebCache imageForURL:]):
3203         Replace BitmapImage::getCGImageRef() with BitmapImage::nativeImage().
3204
3205 2016-09-07  Joseph Pecoraro  <pecoraro@apple.com>
3206
3207         [Mac] Address some clang static analyzer warnings in WebKit
3208         https://bugs.webkit.org/show_bug.cgi?id=161597
3209
3210         Reviewed by Darin Adler.
3211
3212         * Misc/WebIconDatabase.h:
3213         Remove unused instance variable. It has not been used since r16005 (2006)!
3214
3215         * Misc/WebSharingServicePickerController.mm:
3216         (-[WebSharingServicePickerController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
3217         Address array leak.
3218
3219         * WebCoreSupport/WebSelectionServiceController.mm:
3220         (WebSelectionServiceController::hasRelevantSelectionServices):
3221         Address attachment and cell leak.
3222
3223         * WebView/WebFullScreenController.h:
3224         * WebView/WebImmediateActionController.h:
3225         Remove unused instance variables.
3226
3227 2016-09-07  Simon Fraser  <simon.fraser@apple.com>
3228
3229         Enable the <meter> element on iOS
3230         https://bugs.webkit.org/show_bug.cgi?id=161714
3231         rdar://problem/8978410
3232
3233         Reviewed by Tim Horton.
3234
3235         Define ENABLE_METER_ELEMENT unconditionally now.
3236
3237         * Configurations/FeatureDefines.xcconfig:
3238
3239 2016-09-07  Mark Lam  <mark.lam@apple.com>
3240
3241         Add CatchScope and force all exception checks to be via ThrowScope or CatchScope.
3242         https://bugs.webkit.org/show_bug.cgi?id=161498
3243
3244         Reviewed by Geoffrey Garen.
3245
3246         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3247         (WebKit::NetscapePluginInstanceProxy::evaluate):
3248         (WebKit::NetscapePluginInstanceProxy::invoke):
3249         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3250         (WebKit::NetscapePluginInstanceProxy::construct):
3251         (WebKit::NetscapePluginInstanceProxy::getProperty):
3252         (WebKit::NetscapePluginInstanceProxy::setProperty):
3253         (WebKit::NetscapePluginInstanceProxy::removeProperty):
3254         (WebKit::NetscapePluginInstanceProxy::hasProperty):
3255         (WebKit::NetscapePluginInstanceProxy::hasMethod):
3256         (WebKit::NetscapePluginInstanceProxy::enumerate):
3257         * WebView/WebView.mm:
3258         (aeDescFromJSValue):
3259
3260 2016-09-07  Youenn Fablet  <youenn@apple.com>
3261
3262         [Streams API] Separate compile flag for ReadableStream and WritableStream
3263         https://bugs.webkit.org/show_bug.cgi?id=161044
3264
3265         Reviewed by Alex Christensen.
3266
3267         Moving from STREAMS_API to READABLE_STREAM_API and WRITABLE_STREAM_API compilation flags.
3268
3269         * Configurations/FeatureDefines.xcconfig:
3270
3271 2016-09-06  Chris Dumez  <cdumez@apple.com>
3272
3273         Add support for input.minLength / textArea.minLength
3274         https://bugs.webkit.org/show_bug.cgi?id=161644
3275
3276         Reviewed by Darin Adler.
3277
3278         Update ObjC bindings to reflect method renaming.
3279
3280         * DOM/DOMHTMLInputElement.mm:
3281         (-[DOMHTMLInputElement maxLength]):
3282         (-[DOMHTMLInputElement setMaxLength:]):
3283         * DOM/DOMHTMLTextAreaElement.mm:
3284         (-[DOMHTMLTextAreaElement maxLength]):
3285         (-[DOMHTMLTextAreaElement setMaxLength:]):
3286
3287 2016-09-06  Dan Bernstein  <mitz@apple.com>
3288
3289         <rdar://problem/8064563> Ugly NSLog in DOMInternal.mm
3290
3291         Rubber-stamped by Anders Carlsson.
3292
3293         * DOM/DOMInternal.mm:
3294         (-[WebScriptObject _initializeScriptDOMNodeImp]): Removed useless call to NSLog.
3295
3296 2016-09-06  Ryan Haddad  <ryanhaddad@apple.com>
3297
3298         Unreviewed, rolling out r205407.
3299
3300         Not the correct way to implement this functionality
3301
3302         Reverted changeset:
3303
3304         "Consult with the FrameLoaderClient about whether or not
3305         content extensions should be enabled when loading this URL."
3306         https://bugs.webkit.org/show_bug.cgi?id=161441
3307         http://trac.webkit.org/changeset/205407
3308
3309 2016-09-05  Darin Adler  <darin@apple.com>
3310
3311         More bindings improvements, particularly things not needed for JavaScript bindings
3312         https://bugs.webkit.org/show_bug.cgi?id=161572
3313
3314         Reviewed by Sam Weinig.
3315
3316         * DOM/DOMDOMImplementation.mm:
3317         (-[DOMImplementation hasFeature:version:]): Call SVGTests::hasFeatureForLegacyBindings
3318         instead of DOMImplementation::hasFeature. Also removed JSMainThreadNullState
3319         since this does not do anything that can invoke JavaScript.
3320
3321         * DOM/DOMDocument.mm:
3322         (-[DOMDocument defaultCharset]): Call defaultCharsetForLegacyBindings. Also removed
3323         JSMainThreadNullState.
3324
3325         * DOM/DOMDocumentType.mm:
3326         (-[DOMDocumentType entities]): Changed to simply return nil; same behavior as before,
3327         but with no dependency on WebCore. Also removed JSMainThreadNullState.
3328         (-[DOMDocumentType notations]): Ditto.
3329         (-[DOMDocumentType internalSubset]): Ditto, except empty string rather than nil.
3330
3331         * DOM/DOMNode.mm:
3332         (-[DOMNode isSupported:version:]): Call SVGTests::hasFeatureForLegacyBindings
3333         instead of Node::isSupportedForBindings. Also removed JSMainThreadNullState.
3334
3335 2016-09-04  Joseph Pecoraro  <pecoraro@apple.com>
3336
3337         Remove unnecessary RetainPtr.
3338
3339         Review comments on earlier change.
3340
3341         * WebView/WebImmediateActionController.mm:
3342         (-[WebImmediateActionController _defaultAnimationController]):
3343
3344 2016-09-03  Darin Adler  <darin@apple.com>
3345
3346         Streamline DOMImplementation, and move it to our new DOM exception system
3347         https://bugs.webkit.org/show_bug.cgi?id=161295
3348
3349         Reviewed by Ryosuke Niwa.
3350
3351         * DOM/DOMDOMImplementation.mm:
3352         (unwrap): Added. Use this instead of the IMPL macro.
3353         (-[DOMImplementation dealloc]): Updated to use unwrap.
3354         (-[DOMImplementation hasFeature:version:]): Ditto.
3355         (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated to work with
3356         ExceptionOr.
3357         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
3358         (-[DOMImplementation createCSSStyleSheet:media:]): Removed exception logic since
3359         this function can no longer raise an exception.
3360         (-[DOMImplementation createHTMLDocument:]): Updated to use unwrap.
3361         (-[DOMImplementation hasFeature::]): Changed to call the non-deprecated version
3362         rather than duplicating its implementation. Also moved into the category as defined
3363         in the header.
3364         (-[DOMImplementation createDocumentType:::]): Ditto.
3365         (-[DOMImplementation createDocument:::]): Ditto.
3366         (-[DOMImplementation createCSSStyleSheet::]): Ditto.
3367
3368         * DOM/DOMDocument.mm: Removed unneeded include of DOMImplementation.h.
3369         (-[DOMDocument setXmlStandalone:]): Updated since setXMLStandalone no longer can
3370         raise an exception.
3371
3372         * WebView/WebFrame.mm:
3373         (-[WebFrame _canProvideDocumentSource]): Updated to use isTextMIMEType in its new
3374         location in MIMETypeRegistry instead of in DOMImplementation.
3375
3376 2016-09-03  Brian Weinstein  <bweinstein@apple.com>
3377
3378         Implement a stub version of FrameLoaderClient::shouldUseContentExtensionsForURL.
3379         https://bugs.webkit.org/show_bug.cgi?id=16144
3380
3381         Reviewed by Darin Adler.
3382
3383         * WebCoreSupport/WebFrameLoaderClient.h:
3384
3385 2016-09-02  Beth Dakin  <bdakin@apple.com>
3386
3387         Need to updateEditorState if an element change edit-ability without changing 
3388         selection
3389         https://bugs.webkit.org/show_bug.cgi?id=161546
3390         -and corresponding-
3391         rdar://problem/27806012
3392
3393         Reviewed by Ryosuke Niwa.
3394
3395         Every time WebEditorClient::respondToChangedSelection is called, we now save 
3396         whether the last state was contentEditable. That way in 
3397         updateEditorStateAfterLayoutIfNeeded() we can assess whether or not edit-ability 
3398         has changed. 
3399
3400         * WebCoreSupport/WebEditorClient.h:
3401         * WebCoreSupport/WebEditorClient.mm:
3402         (WebEditorClient::respondToChangedSelection):
3403         (WebEditorClient:: updateEditorStateAfterLayoutIfEditabilityChanged):
3404
3405 2016-09-02  Joseph Pecoraro  <pecoraro@apple.com>
3406
3407         [Mac] RetainPtr misuse, AnimationController leaks
3408         https://bugs.webkit.org/show_bug.cgi?id=161552
3409
3410         Reviewed by Tim Horton.
3411
3412         * WebView/WebImmediateActionController.mm:
3413         (-[WebImmediateActionController _defaultAnimationController]):
3414
3415 2016-07-08  Jer Noble  <jer.noble@apple.com>
3416
3417         Refactor WebPlaybackSessionModelMediaElement to be client based.
3418         https://bugs.webkit.org/show_bug.cgi?id=159580
3419
3420         Reviewed by Eric Carlson.
3421
3422         No longer necessary to tell the models and interfaces about each other.
3423
3424         * WebView/WebView.mm:
3425         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3426         (-[WebView _clearPlaybackControlsManager]):
3427
3428 2016-09-01  Dan Bernstein  <mitz@apple.com>
3429
3430         Build fix.
3431
3432         * Configurations/FeatureDefines.xcconfig:
3433
3434 2016-09-01  Myles C. Maxfield  <mmaxfield@apple.com>
3435
3436         Clean up TextRun-related code
3437         https://bugs.webkit.org/show_bug.cgi?id=161473
3438
3439         Reviewed by Simon Fraser.
3440
3441         Remove unused #includes.
3442
3443         * WebCoreSupport/WebDragClient.mm:
3444         * WebView/WebView.mm:
3445
3446 2016-08-31  Keith Rollin  <krollin@apple.com>
3447
3448         WebKit should set a subsystem for os_log so it's easier to filter for WebKit log messages
3449         https://bugs.webkit.org/show_bug.cgi?id=160969
3450         <rdar://problem/26068734>
3451
3452         Reviewed by Simon Fraser.
3453
3454         Enable subsystem- and channel-related data and functions when using
3455         RELEASE_LOG macros. Use the DECLARE_LOG_CHANNEL, DEFINE_LOG_CHANNEL,
3456         and LOG_CHANNEL_ADDRESS macros that are now defined in WTF.
3457
3458         * Misc/WebKitLogging.h:
3459         * Misc/WebKitLogging.m:
3460         * WebView/WebView.mm:
3461         (-[WebView _commonInitializationWithFrameName:groupName:]):
3462
3463 2016-08-31  Brady Eidson  <beidson@apple.com>
3464
3465         WK2 Gamepad provider on iOS.
3466         https://bugs.webkit.org/show_bug.cgi?id=161412
3467
3468         Reviewed by Tim Horton.
3469
3470         * Configurations/FeatureDefines.xcconfig:
3471
3472         * WebView/WebView.mm:
3473         (WebKitInitializeGamepadProviderIfNecessary):
3474
3475 2016-08-30  Mark Lam  <mark.lam@apple.com>
3476
3477         Introduce the ThrowScope and force every throw site to instantiate a ThrowScope.
3478         https://bugs.webkit.org/show_bug.cgi?id=161171
3479
3480         Reviewed by Filip Pizlo and Geoffrey Garen.
3481
3482         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3483         (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
3484         * Plugins/Hosted/ProxyInstance.mm:
3485         (WebKit::ProxyInstance::invokeMethod):
3486
3487 2016-08-28  Andreas Kling  <akling@apple.com>
3488
3489         document.title setter can't throw.
3490         <https://webkit.org/b/161302>
3491
3492         Reviewed by Antti Koivisto.
3493
3494         * DOM/DOMDocument.mm:
3495         (-[DOMDocument setTitle:]):
3496
3497 2016-08-28  Andreas Kling  <akling@apple.com>
3498
3499         Clean up some .text attribute setters that don't throw.
3500         <https://webkit.org/b/161292>
3501
3502         Reviewed by Darin Adler.
3503
3504         * DOM/DOMHTMLTitleElement.mm:
3505         (-[DOMHTMLTitleElement setText:]):
3506
3507 2016-08-26  Sam Weinig  <sam@webkit.org>
3508
3509         Remove support for ENABLE_LEGACY_WEB_AUDIO
3510         https://bugs.webkit.org/show_bug.cgi?id=161262
3511
3512         Reviewed by Anders Carlsson.
3513
3514         * Configurations/FeatureDefines.xcconfig:
3515         Remove ENABLE_LEGACY_WEB_AUDIO
3516
3517 2016-08-25  Anders Carlsson  <andersca@apple.com>
3518
3519         Re-export DOMException NSStrings after r204717
3520         https://bugs.webkit.org/show_bug.cgi?id=161200
3521         <rdar://problem/27959937>
3522
3523         Reviewed by Alex Christensen.
3524
3525         * DOM/ExceptionHandlers.mm:
3526         (raiseDOMException):
3527         * WebKit.exp:
3528
3529 2016-08-22  Darin Adler  <darin@apple.com>
3530
3531         Move Objective-C DOM bindings from WebCore to legacy WebKit
3532         https://bugs.webkit.org/show_bug.cgi?id=160654
3533
3534         Reviewed by Alex Christensen.
3535
3536         * DOM: Added lots of files to the directory.
3537         The files are just as they were in bindings/objc except that the paths of includes
3538         have been updated as needed, and the code no longer is defined inside the WebCore
3539         namespace, requring changes to various functions and their call sites. Also removed
3540         all the WEBCORE_EXPORT since we export differently here in legacy WebKit.
3541
3542         * DOM/DOMInternal.h: Moved. Replaced createDOMWrapper with initializeDOMWrapperHooks.
3543         * DOM/DOMUtility.mm: Moved.
3544         (createDOMWrapper): Simplified to use toWrapped and not do unneeded namespace tricks.
3545         (disconnectWindowWrapper): Added.
3546         (initializeDOMWrapperHooks): Added.
3547
3548         * MigrateHeaders.make: Removed all the internal headers since they are now just
3549         normal project headers. Added the "DOM" directory to the VPATH. Some of the headers
3550         from WebCore are still being migrated, so we can't remove WebCorePrivateHeaders yet.
3551
3552         * WebCoreSupport/WebEditorClient.h:&n