Add simple line layout toggle to MiniBrowser
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2017-01-24  Zalan Bujtas  <zalan@apple.com>
2
3         Add simple line layout toggle to MiniBrowser
4         https://bugs.webkit.org/show_bug.cgi?id=167405
5
6         Reviewed by Andreas Kling.
7
8         * WebView/WebPreferenceKeysPrivate.h:
9         * WebView/WebPreferences.mm:
10         (+[WebPreferences initialize]):
11         (-[WebPreferences simpleLineLayoutEnabled]):
12         (-[WebPreferences setSimpleLineLayoutEnabled:]):
13         * WebView/WebPreferencesPrivate.h:
14         * WebView/WebView.mm:
15         (-[WebView _preferencesChanged:]):
16
17 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
18
19         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
20         https://bugs.webkit.org/show_bug.cgi?id=167394
21
22         Reviewed by Ryosuke Niwa.
23
24         * Configurations/FeatureDefines.xcconfig:
25
26 2017-01-23  Chris Dumez  <cdumez@apple.com>
27
28         REGRESSION (r211033): ASSERTION FAILED: m_ptr in com.apple.WebCore: WTF::RefPtr<WebCore::Element>::operator* const + 70
29         https://bugs.webkit.org/show_bug.cgi?id=167308
30         <rdar://problem/30144964>
31
32         Unreviewed, do a partial revert of r211033 to fix assertion.
33
34         * WebCoreSupport/WebChromeClient.h:
35         * WebCoreSupport/WebChromeClient.mm:
36         (WebChromeClient::exitFullScreenForElement):
37
38 2017-01-23  Joseph Pecoraro  <pecoraro@apple.com>
39
40         Remove allowWindowOpenWithoutUserGesture setting
41         https://bugs.webkit.org/show_bug.cgi?id=167301
42
43         Reviewed by Darin Adler.
44
45         * WebView/WebView.mm:
46         (-[WebView _preferencesChanged:]):
47         Use the equivalent existing setting.
48
49 2017-01-20  Darin Adler  <darin@apple.com>
50
51         Remove PassRefPtr from "page" directory of WebCore, also deploy references
52         https://bugs.webkit.org/show_bug.cgi?id=167224
53
54         Reviewed by Chris Dumez.
55
56         * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
57         (-[WebApplicationCacheQuotaManager quota]): Pass reference.
58
59         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
60         * WebCoreSupport/WebChromeClient.mm:
61         (WebChromeClient::focusedElementChanged): Ditto.
62         (WebChromeClient::createWindow): Ditto.
63         (WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
64         (WebChromeClient::runJavaScriptAlert): Ditto.
65         (WebChromeClient::runJavaScriptConfirm): Ditto.
66         (WebChromeClient::runJavaScriptPrompt): Ditto.
67         (WebChromeClient::contentsSizeChanged): Ditto.
68         (WebChromeClient::unavailablePluginButtonClicked): Ditto.
69         (WebChromeClient::print): Ditto.
70         (WebChromeClient::exceededDatabaseQuota): Ditto.
71         (WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
72         (WebChromeClient::createColorChooser): Ditto.
73         (WebChromeClient::elementDidFocus): Ditto.
74         (WebChromeClient::elementDidBlur): Ditto.
75         (WebChromeClient::createPopupMenu): Ditto.
76         (WebChromeClient::createSearchPopupMenu): Ditto.
77         (WebChromeClient::attachRootGraphicsLayer): Ditto.
78         (WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
79         (WebChromeClient::supportsFullScreenForElement): Ditto.
80         (WebChromeClient::enterFullScreenForElement): Ditto.
81         (WebChromeClient::exitFullScreenForElement): Ditto.
82
83         * WebView/WebFrame.mm:
84         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
85         Updated for change to the appendChild function.
86
87 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
88
89         Remove -[WebFrame sendOrientationChangeEvent:] which is unused
90         https://bugs.webkit.org/show_bug.cgi?id=167276
91
92         Reviewed by Alex Christensen.
93         
94         It was usurped by -deviceOrientationChanged in 2014.
95
96         * WebView/WebFrame.mm:
97         (-[WebFrame sendOrientationChangeEvent:]): Deleted.
98         * WebView/WebFramePrivate.h:
99
100 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
101
102         Remove -[WebView _contentsSizeRespectingOverflow] which is no longer needed
103         https://bugs.webkit.org/show_bug.cgi?id=167271
104
105         Reviewed by Alex Christensen.
106         
107         -_contentsSizeRespectingOverflow was added to try to make viewport sizing on iOS respect
108         overflow:hidden on the body (webkit.org/b/146924) but that was reverted (webkit.org/b/152803),
109
110         * WebView/WebView.mm:
111         (-[WebView _contentsSizeRespectingOverflow]): Deleted.
112         * WebView/WebViewPrivate.h:
113
114 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
115
116         Remove never changing IndexedDB RuntimeEnabledFeature
117         https://bugs.webkit.org/show_bug.cgi?id=167278
118
119         Reviewed by Darin Adler.
120
121         * WebView/WebView.mm:
122         (-[WebView _preferencesChanged:]):
123
124 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
125
126         Cleanup RuntimeEnabledFeatures
127         https://bugs.webkit.org/show_bug.cgi?id=167228
128
129         Reviewed by Simon Fraser.
130
131         * WebView/WebView.mm:
132         (-[WebView _preferencesChanged:]):
133
134 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
135
136         Remove outdated ENABLE(CSP_NEXT) build flag
137         https://bugs.webkit.org/show_bug.cgi?id=167252
138
139         Reviewed by Brent Fulgham.
140
141         * Configurations/FeatureDefines.xcconfig:
142
143 2017-01-20  Antoine Quint  <graouts@apple.com>
144
145         [Modern Media Controls] Turn modern media controls on by default
146         https://bugs.webkit.org/show_bug.cgi?id=165668
147
148         Reviewed by Dean Jackson.
149
150         Enabled modern media controls by default in WK1.
151
152         * WebView/WebPreferences.mm:
153         (+[WebPreferences initialize]):
154
155 2017-01-19  Chris Dumez  <cdumez@apple.com>
156
157         iterable<> should be enabled on WK1
158         https://bugs.webkit.org/show_bug.cgi?id=167221
159         <rdar://problem/30108531>
160
161         Reviewed by Youenn Fablet.
162
163         * WebView/WebPreferenceKeysPrivate.h:
164         * WebView/WebPreferences.mm:
165         (-[WebPreferences setCustomElementsEnabled:]):
166         (-[WebPreferences DOMIteratorEnabled]): Deleted.
167         (-[WebPreferences setDOMIteratorEnabled:]): Deleted.
168         * WebView/WebPreferencesPrivate.h:
169         * WebView/WebView.mm:
170         (-[WebView _preferencesChanged:]):
171
172 2017-01-19  Chris Dumez  <cdumez@apple.com>
173
174         Make sure HTML validation bubble gets dismissed when its associated element's frame gets detached
175         https://bugs.webkit.org/show_bug.cgi?id=167215
176         <rdar://problem/29885052>
177
178         Reviewed by Andreas Kling.
179
180         Make sure HTML validation bubble gets dismissed when its associated
181         element's frame gets detached and that we do not crash.
182
183         * WebCoreSupport/WebValidationMessageClient.h:
184         * WebCoreSupport/WebValidationMessageClient.mm:
185         (WebValidationMessageClient::documentDetached):
186
187 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
188
189         [Cocoa] Variation fonts are erroneously disabled on iOS
190         https://bugs.webkit.org/show_bug.cgi?id=167172
191
192         Reviewed by Simon Fraser.
193
194         OpenSource builders don't seem to understand sdk=embedded*.
195
196         * Configurations/FeatureDefines.xcconfig:
197
198 2017-01-19  Andreas Kling  <akling@apple.com>
199
200         ScriptExecutionContext::topOrigin() should return a reference.
201         <https://webkit.org/b/167190>
202
203         Reviewed by Sam Weinig.
204
205         * Misc/WebCache.mm:
206         (+[WebCache addImageToCache:forURL:forFrame:]):
207         (+[WebCache removeImageFromCacheForURL:forFrame:]):
208
209 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
210
211         Unreviewed fix for the macOS build.
212
213         * Carbon/CarbonWindowAdapter.mm:
214         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
215
216 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
217
218         Unreviewed, rolling out r210848.
219
220         This change introduced media-related LayoutTest failures and
221         crashes on macOS.
222
223         Reverted changeset:
224
225         "[Modern Media Controls] Turn modern media controls on by
226         default"
227         https://bugs.webkit.org/show_bug.cgi?id=165668
228         http://trac.webkit.org/changeset/210848
229
230 2017-01-18  Andreas Kling  <akling@apple.com>
231
232         Document::securityOrigin() should return a reference.
233         <https://webkit.org/b/167124>
234
235         Reviewed by Sam Weinig.
236
237         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
238         (WebKit::NetscapePluginInstanceProxy::loadRequest):
239         * Plugins/WebNetscapePluginStream.mm:
240         (WebNetscapePluginStream::WebNetscapePluginStream):
241         * Plugins/WebNetscapePluginView.mm:
242         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
243         * Plugins/WebPluginContainerCheck.mm:
244         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
245         * WebCoreSupport/WebChromeClient.mm:
246         (WebChromeClient::exceededDatabaseQuota):
247         * WebCoreSupport/WebFrameLoaderClient.h:
248         * WebCoreSupport/WebFrameLoaderClient.mm:
249         (WebFrameLoaderClient::didRunInsecureContent):
250         * WebCoreSupport/WebGeolocationClient.mm:
251         (WebGeolocationClient::requestPermission):
252         (-[WebGeolocationProviderInitializationListener initializationAllowedWebView:]):
253         * WebView/WebFrame.mm:
254         (-[WebFrame _allowsFollowingLink:]):
255
256 2017-01-18  Antoine Quint  <graouts@apple.com>
257
258         [Modern Media Controls] Turn modern media controls on by default
259         https://bugs.webkit.org/show_bug.cgi?id=165668
260
261         Reviewed by Dean Jackson.
262
263         Enabled modern media controls by default in WK1. 
264
265         * WebView/WebPreferences.mm:
266         (+[WebPreferences initialize]):
267
268 2017-01-15  Darin Adler  <darin@apple.com>
269
270         Remove PassRefPtr from "loader" directory of WebCore
271         https://bugs.webkit.org/show_bug.cgi?id=167055
272
273         Reviewed by Alex Christensen.
274
275         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
276         Also made class final and most functions private and final.
277         * WebCoreSupport/WebChromeClient.mm:
278         (WebChromeClient::runOpenPanel): Updated to take references.
279
280         * WebCoreSupport/WebEditorClient.h: Updated for changes to EditorClient.
281         * WebCoreSupport/WebEditorClient.mm:
282         (-[WebUndoStep initWithUndoStep:]): Take reference instead of PassRefPtr.
283         (+[WebUndoStep stepWithUndoStep:]): Ditto.
284         (-[WebUndoStep step]): Return reference instead of pointer.
285         (-[WebEditorUndoTarget undoEditing:]): Updated for the above.
286         (-[WebEditorUndoTarget redoEditing:]): Ditto.
287         (WebEditorClient::registerUndoOrRedoStep): Take reference instead of
288         PassRefPtr.
289         (WebEditorClient::registerUndoStep): Ditto.
290         (WebEditorClient::registerRedoStep): Ditto.
291
292         * WebCoreSupport/WebFrameLoaderClient.h: Updated for changes to
293         FrameLoaderClient, marked functions final instead of override.
294         * WebCoreSupport/WebFrameLoaderClient.mm:
295         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Take
296         pointer instead of PassRefPtr.
297         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
298         (makeFormFieldValuesDictionary): Take a reference.
299         (WebFrameLoaderClient::dispatchWillSendSubmitEvent): Take Ref&& instead
300         of PassRefPtr.
301         (WebFrameLoaderClient::dispatchWillSubmitForm): Take a reference instead
302         of PassRefPtr.
303         (WebFrameLoaderClient::actionDictionary): Take a pointer instead of PassRePtr.
304         (WebFrameLoaderClient::createFrame): Take a reference instead of a pointer.
305         (WebFrameLoaderClient::createPlugin): Ditto.
306         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
307         (WebFrameLoaderClient::createNetworkingContext): Ditto.
308         (WebFrameLoaderClient::didCreateQuickLookHandle): Pass a reference.
309
310         * WebCoreSupport/WebFrameNetworkingContext.h: Use Ref instead of PassRefPtr.
311         * WebCoreSupport/WebFrameNetworkingContext.mm: Tweak style a bit.
312
313         * WebCoreSupport/WebOpenPanelResultListener.h: Take a reference instead of
314         PassRefPtr. Use RefPtr for class field.
315         * WebCoreSupport/WebOpenPanelResultListener.mm:
316         (-[WebOpenPanelResultListener dealloc]): Deleted. Compiler will now do it
317         correctly without us declaring anything explicitly.
318         (-[WebOpenPanelResultListener cancel]): Get rid of hand-written deref code,
319         and let RefPtr do the work.
320         (-[WebOpenPanelResultListener chooseFilename:]): Ditto.
321         (-[WebOpenPanelResultListener chooseFilenames:]): Ditto.
322         (-[WebOpenPanelResultListener chooseFilenames:displayString:iconImage:]):
323         Rewrote to use a modern Objective-C for loop, reserveInitialCapacity,
324         and uncheckedAppend.
325
326         * WebView/WebArchive.mm:
327         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
328         Updated for changes to LegacyWebArchive.
329         (-[WebArchive mainResource]): Ditto.
330         (-[WebArchive subresources]): Ditto.
331         (-[WebArchive subframeArchives]): Ditto.
332
333         * WebView/WebDataSource.mm:
334         (-[WebDataSource _addSubframeArchives:]): Use a modern Objective-C for loop
335         instead of NSEnumerator.
336         (-[WebDataSource _fileWrapperForURL:]): Use auto.
337         (-[WebDataSource _documentFragmentWithArchive:]): Pass a reference.
338         (-[WebDataSource mainResource]): Ditto.
339         (-[WebDataSource subresources]): Ditto.
340         (-[WebDataSource subresourceForURL:]): Ditto.
341         (-[WebDataSource addSubresource:]): Ditto.
342
343         * WebView/WebResource.mm:
344         (-[WebResourcePrivate initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
345         (-[WebResourcePrivate dealloc]): Remove explicit deref since RefPtr will now take
346         care of it
347         (-[WebResource initWithCoder:]): Pass a reference.
348         (-[WebResource encodeWithCoder:]): Updated since coreResource is now RefPtr.
349         (-[WebResource _initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
350         (-[WebResource _coreResource]): Return reference rather than pointer.
351         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
352         Added code to handle the null case and pass a reference rather than a pointer.
353         * WebView/WebResourceInternal.h: Updated for the above.
354
355 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
356
357         Unreviewed, rolling out r210834
358         https://bugs.webkit.org/show_bug.cgi?id=165668
359
360         It introduced dozens of test timeouts.
361
362         Reverted changeset:
363         "[Modern Media Controls] Turn modern media controls on by default"
364         https://bugs.webkit.org/show_bug.cgi?id=165668
365         http://trac.webkit.org/changeset/210834
366
367 2017-01-17  Antoine Quint  <graouts@apple.com>
368
369         [Modern Media Controls] Turn modern media controls on by default
370         https://bugs.webkit.org/show_bug.cgi?id=165668
371
372         Reviewed by Dean Jackson.
373
374         Enabled modern media controls by default in WK1. 
375
376         * WebView/WebPreferences.mm:
377         (+[WebPreferences initialize]):
378
379 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
380
381         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
382         https://bugs.webkit.org/show_bug.cgi?id=116551
383         <rdar://problem/13949830>
384
385         Reviewed by Alex Christensen.
386
387         * Configurations/FeatureDefines.xcconfig:
388
389 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
390
391         Crash when closing tab with debugger paused
392         https://bugs.webkit.org/show_bug.cgi?id=161746
393         <rdar://problem/15607819>
394
395         Reviewed by Brian Burg and Brent Fulgham.
396
397         * WebView/WebView.mm:
398         (WebKit::DeferredPageDestructor::createDeferredPageDestructor):
399         (WebKit::DeferredPageDestructor::DeferredPageDestructor):
400         (WebKit::DeferredPageDestructor::tryDestruction):
401         (-[WebView _close]):
402         Defer destruction of the Page if we are in a nested runloop.
403
404 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
405
406         Remove the REQUEST_ANIMATION_FRAME flag
407         https://bugs.webkit.org/show_bug.cgi?id=156980
408         <rdar://problem/25906849>
409
410         Reviewed by Simon Fraser.
411
412         * Configurations/FeatureDefines.xcconfig:
413
414 2017-01-16  Andy Estes  <aestes@apple.com>
415
416         [QuickLook] Do some cleanup in QuickLookHandle
417         https://bugs.webkit.org/show_bug.cgi?id=166864
418
419         Reviewed by Darin Adler.
420
421         * WebCoreSupport/WebFrameLoaderClient.mm:
422         (WebFrameLoaderClient::didCreateQuickLookHandle): Changed to pass a
423         Ref<QuickLookHandleClient>&& to QuickLookHandle::setClient().
424
425 2017-01-15  Tim Horton  <timothy_horton@apple.com>
426
427         De-duplicate more (nearly) identical code in Editor(Mac|IOS).mm
428         https://bugs.webkit.org/show_bug.cgi?id=167063
429
430         Reviewed by Dan Bernstein.
431
432         * WebView/WebHTMLView.mm:
433         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
434         (-[WebHTMLView _updateFontPanel]):
435         * WebView/WebView.mm:
436         (-[WebView typingAttributes]):
437         Adjust to fontAttributesForSelectionStart returning a RetainPtr.
438
439 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
440
441         Remove ENABLE(DETAILS_ELEMENT) guards
442         https://bugs.webkit.org/show_bug.cgi?id=167042
443
444         Reviewed by Alex Christensen.
445
446         * Configurations/FeatureDefines.xcconfig:
447
448 2017-01-11  Darin Adler  <darin@apple.com>
449
450         Remove PassRefPtr from more of "platform"
451         https://bugs.webkit.org/show_bug.cgi?id=166809
452
453         Reviewed by Sam Weinig.
454
455         * WebCoreSupport/WebFrameLoaderClient.mm:
456         (NetscapePluginWidget::handleEvent): Pass a reference.
457         * WebView/WebView.mm:
458         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
459         Updated since the children set now contains Ref instead of RefPtr.
460
461 2017-01-13  Sam Weinig  <sam@webkit.org>
462
463         [WebIDL] Remove custom bindings for DeviceMotionEvent and DeviceOrientationEvent
464         https://bugs.webkit.org/show_bug.cgi?id=167006
465
466         Reviewed by Geoffrey Garen.
467
468         * WebView/WebDeviceOrientation.mm:
469         (convert):
470         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
471         Update for new use of std::optional.
472
473 2017-01-12  Joseph Pecoraro  <pecoraro@apple.com>
474
475         Remove unnecessary includes of Page.h
476         https://bugs.webkit.org/show_bug.cgi?id=166996
477
478         Reviewed by Yusuke Suzuki.
479
480         * DOM/DOMHTML.mm:
481         * History/WebBackForwardList.mm:
482         * Plugins/WebPluginController.mm:
483         * WebCoreSupport/WebNotificationClient.mm:
484         * WebCoreSupport/WebPlatformStrategies.mm:
485         * WebCoreSupport/WebUserMediaClient.mm:
486         * WebView/WebFullScreenController.mm:
487
488 2017-01-12  Chris Dumez  <cdumez@apple.com>
489
490         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
491         https://bugs.webkit.org/show_bug.cgi?id=166995
492
493         Reviewed by Jer Noble.
494
495         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
496         as some people are having trouble building without it.
497
498         * Configurations/FeatureDefines.xcconfig:
499
500 2017-01-12  Chris Dumez  <cdumez@apple.com>
501
502         HTML form validation popover sometimes does not go away
503         https://bugs.webkit.org/show_bug.cgi?id=166990
504         <rdar://problem/29985957>
505
506         Reviewed by Tim Horton.
507
508         Update code using ValidationBubble now that it is RefCounted.
509
510         * WebView/WebView.mm:
511         (-[WebView showFormValidationMessage:withAnchorRect:]):
512
513 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
514
515         Remove pointerLockElement from DOMDocumentPrivate.h
516         https://bugs.webkit.org/show_bug.cgi?id=166882
517
518         Reviewed by Simon Fraser.
519
520         Removed pointerLockElement declaration that was supposed to be removed in r209637.
521
522         * DOM/DOMDocumentPrivate.h:
523
524 2017-01-06  Darin Adler  <darin@apple.com>
525
526         Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
527         https://bugs.webkit.org/show_bug.cgi?id=166797
528
529         Reviewed by Alex Christensen.
530
531         * WebCoreSupport/WebEditorClient.h: Updated to take a reference.
532         * WebCoreSupport/WebEditorClient.mm:
533         (WebEditorClient::requestCheckingOfString): Take a reference
534         instead of a PassRefPtr.
535
536 2017-01-05  Chris Dumez  <cdumez@apple.com>
537
538         Turn preferLowPowerWebGLRendering setting on by default
539         https://bugs.webkit.org/show_bug.cgi?id=166737
540         <rdar://problem/29870033>
541
542         Reviewed by Dean Jackson.
543
544         Temporarily turn preferLowPowerWebGLRendering setting on by default until
545         we deal better with WebGL content in background tabs.
546
547         * WebView/WebPreferences.mm:
548         (+[WebPreferences initialize]):
549
550 2017-01-05  Enrica Casucci  <enrica@apple.com>
551
552         Support File Promise during drag for macOS.
553         https://bugs.webkit.org/show_bug.cgi?id=165204
554         rdar://problem/19595567
555
556         Reviewed by Tim Horton.
557
558         Adds support for dropping a File Promise in a WebView.
559         The implementation uses new File Promise API available in Sierra.
560
561         * Misc/WebNSPasteboardExtras.mm:
562         (+[NSPasteboard _web_dragTypesForURL]):
563         * WebView/WebView.mm:
564         (-[WebView performDragOperation:]):
565
566 2017-01-05  Andreas Kling  <akling@apple.com>
567
568         Remove ChromeClient::needTouchEvents().
569         <https://webkit.org/b/166723>
570
571         Rubber-stamped by Antti Koivisto.
572
573         * WebCoreSupport/WebChromeClient.h:
574
575 2017-01-04  Darin Adler  <darin@apple.com>
576
577         Remove PassRefPtr use from the "html" directory, other improvements
578         https://bugs.webkit.org/show_bug.cgi?id=166635
579
580         Reviewed by Alex Christensen.
581
582         * WebCoreSupport/WebChromeClient.h:
583         * WebCoreSupport/WebChromeClient.mm:
584         (WebChromeClient::loadIconForFiles): Take a reference instead of a pointer.
585
586 2017-01-04  Ryan Haddad  <ryanhaddad@apple.com>
587
588         Unreviewed, rolling out r210287.
589
590         This change caused editing test failures on macOS.
591
592         Reverted changeset:
593
594         "Support File Promise during drag for macOS."
595         https://bugs.webkit.org/show_bug.cgi?id=165204
596         http://trac.webkit.org/changeset/210287
597
598 2017-01-04  Enrica Casucci  <enrica@apple.com>
599
600         Support File Promise during drag for macOS.
601         https://bugs.webkit.org/show_bug.cgi?id=165204
602         rdar://problem/19595567
603
604         Reviewed by Tim Horton.
605
606         Adds support for dropping a File Promise in a WebView.
607         The implementation uses new File Promise API available in Sierra.
608
609         * Misc/WebNSPasteboardExtras.mm:
610         (+[NSPasteboard _web_dragTypesForURL]):
611         * WebView/WebView.mm:
612         (-[WebView performDragOperation:]):
613
614 2017-01-04  Tim Horton  <timothy_horton@apple.com>
615
616         Provide a setting for clients to always prefer low-power WebGL
617         https://bugs.webkit.org/show_bug.cgi?id=166675
618         <rdar://problem/29834093>
619
620         Reviewed by Dan Bernstein.
621
622         * WebView/WebPreferenceKeysPrivate.h:
623         * WebView/WebPreferences.mm:
624         (+[WebPreferences initialize]):
625         (-[WebPreferences preferLowPowerWebGLRendering]):
626         (-[WebPreferences setPreferLowPowerWebGLRendering:]):
627         * WebView/WebPreferencesPrivate.h:
628         * WebView/WebView.mm:
629         (-[WebView _preferencesChanged:]):
630         Expose a new private preferLowPowerWebGLRendering WebKit1 preference.
631
632 2017-01-03  Tim Horton  <timothy_horton@apple.com>
633
634         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
635         https://bugs.webkit.org/show_bug.cgi?id=166450
636         <rdar://problem/29447824>
637
638         Reviewed by Darin Adler.
639
640         * WebCoreSupport/CorrectionPanel.h:
641         * WebCoreSupport/CorrectionPanel.mm:
642         (CorrectionPanel::recordAutocorrectionResponse):
643         (CorrectionPanel::handleAcceptedReplacement):
644         * WebCoreSupport/WebAlternativeTextClient.mm:
645         (toCorrectionResponse):
646         (WebAlternativeTextClient::recordAutocorrectionResponse):
647         Funnel all calls to recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
648         through recordAutocorrectionResponse, for debugging's sake.
649         Drop the NSView parameter because we don't need it, just the tag.
650         Convert the new AutocorrectionResponseType value to its corresponding
651         NSCorrectionResponse value.
652
653 2017-01-01  Jeff Miller  <jeffm@apple.com>
654
655         Update user-visible copyright strings to include 2017
656         https://bugs.webkit.org/show_bug.cgi?id=166278
657
658         Reviewed by Dan Bernstein.
659
660         * Info.plist:
661
662 2016-12-30  Darin Adler  <darin@apple.com>
663
664         Remove PassRefPtr use from the "dom" directory, related cleanup
665         https://bugs.webkit.org/show_bug.cgi?id=166569
666
667         Reviewed by Alex Christensen.
668
669         * WebCoreSupport/WebFrameLoaderClient.mm:
670         (WebFrameLoaderClient::dispatchDidReceiveTitle): Updated to use struct.
671         (WebFrameLoaderClient::updateGlobalHistory): Ditto.
672         (WebFrameLoaderClient::setTitle): Ditto.
673         (WebFrameLoaderClient::transitionToCommittedForNewPage): Ditto.
674         * WebView/WebFrame.mm:
675         (-[WebFrame _dispatchDidReceiveTitle:]): Use aggregate-style syntax for StringWithDirection.
676         Not needed now, but useful later if we ever can get rid of the explicit constructors.
677         (-[WebFrame loadArchive:]): Pass a reference to loadArchive.
678         * WebView/WebHTMLRepresentation.mm:
679         (-[WebHTMLRepresentation title]): Updated to use struct.
680
681 2016-12-25  Yusuke Suzuki  <utatane.tea@gmail.com>
682
683         Propagate the source origin as much as possible
684         https://bugs.webkit.org/show_bug.cgi?id=166348
685
686         Reviewed by Darin Adler.
687
688         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
689         (WebKit::NetscapePluginInstanceProxy::evaluate):
690
691 2016-12-23  Andy Estes  <aestes@apple.com>
692
693         [iOS] DumpRenderTree triggers an assertion failure when calling +[WebPreferences _switchNetworkLoaderToNewTestingSession]
694         https://bugs.webkit.org/show_bug.cgi?id=166471
695
696         Reviewed by Andreas Kling.
697
698         When DumpRenderTree starts up, it calls
699         +[WebPreferences _switchNetworkLoaderToNewTestingSession] from the main thread. In Debug
700         builds, this triggers the ASSERT(isMainThread()) in
701         NetworkStorageSession::defaultNetworkStorageSession() because the Web thread has already
702         started, we are on the main thread, and we are not holding the Web thread lock. This is
703         causing all layout tests to crash in the iOS WK1 Debug configuration.
704
705         * WebView/WebPreferences.mm: (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
706         Take the Web thread lock before calling NetworkStorageSession::switchToNewTestingSession().
707
708 2016-12-22  Andy Estes  <aestes@apple.com>
709
710         Make WebCore::EditorInsertAction an enum class
711         https://bugs.webkit.org/show_bug.cgi?id=166424
712
713         Reviewed by Brent Fulgham.
714
715         * WebCoreSupport/WebEditorClient.mm:
716         (kit):
717
718 2016-12-21  Beth Dakin  <bdakin@apple.com>
719
720         Holding down on candidates in the TouchBar should show panel on screen
721         https://bugs.webkit.org/show_bug.cgi?id=166367
722         -and corresponding-
723         <rdar://problem/28479236>
724
725         Reviewed by Tim Horton.
726
727         Stray whitespace.
728         * WebCoreSupport/WebEditorClient.mm:
729         (WebEditorClient::handleRequestedCandidates):
730
731         Call the version of setCandidates: that takes a rect. We need to keep the helper 
732         function in WK1 (unlike WK2) since we also use it for testing.
733         * WebView/WebView.mm:
734         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
735
736 2016-12-20  Dean Jackson  <dino@apple.com>
737
738         Remove INDIE_UI
739         https://bugs.webkit.org/show_bug.cgi?id=165881
740         <rdar://problem/29672532>
741
742         Reviewed by Simon Fraser.
743
744         The Indie UI work has been discontinued.
745
746         * Configurations/FeatureDefines.xcconfig:
747
748 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
749
750         [ES6] Enable ES6 Modules
751         https://bugs.webkit.org/show_bug.cgi?id=165849
752
753         Reviewed by Geoffrey Garen.
754
755         * WebView/WebPreferenceKeysPrivate.h:
756         * WebView/WebPreferences.mm:
757         (+[WebPreferences initialize]):
758         (-[WebPreferences es6ModulesEnabled]): Deleted.
759         (-[WebPreferences setES6ModulesEnabled:]): Deleted.
760         * WebView/WebPreferencesPrivate.h:
761         * WebView/WebView.mm:
762         (-[WebView _preferencesChanged:]):
763
764 2016-12-16  Dave Hyatt  <hyatt@apple.com>
765
766         [CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
767         https://bugs.webkit.org/show_bug.cgi?id=165968
768
769         Reviewed by Andreas Kling.
770
771         * DOM/DOMCSS.mm:
772         (kitClass):
773         * DOM/DOMCSSPrimitiveValue.mm:
774         (-[DOMCSSPrimitiveValue getCounterValue]):
775         (-[DOMCSSPrimitiveValue getRectValue]):
776         (kit):
777         * DOM/DOMCSSPrimitiveValueInternal.h:
778         * DOM/DOMCSSStyleDeclaration.mm:
779         * DOM/DOMCSSValue.mm:
780         (kit):
781         * DOM/DOMCSSValueInternal.h:
782         * DOM/DOMCSSValueList.mm:
783         * DOM/DOMCounter.mm:
784         (kit):
785         * DOM/DOMCounterInternal.h:
786         * DOM/DOMRGBColor.mm:
787         (kit):
788         * DOM/DOMRGBColorInternal.h:
789         * DOM/DOMRect.mm:
790         (kit):
791         * DOM/DOMRectInternal.h:
792         * DOM/DOMUtility.mm:
793         (createDOMWrapper):
794
795 2016-12-16  Chris Dumez  <cdumez@apple.com>
796
797         HTML form validation bubble should be dismissed on navigation
798         https://bugs.webkit.org/show_bug.cgi?id=165960
799         <rdar://problem/29668086>
800
801         Reviewed by Simon Fraser.
802
803         Dismiss HTML form validation bubble on top-level navigation on Mac WK1.
804
805         * WebView/WebView.mm:
806         (-[WebView _didStartProvisionalLoadForFrame:]):
807
808 2016-12-15  Darin Adler  <darin@apple.com>
809
810         Use asString instead of toWTFString, toString, or getString when we already checked isString
811         https://bugs.webkit.org/show_bug.cgi?id=165895
812
813         Reviewed by Yusuke Suzuki.
814
815         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
816         (WebKit::NetscapePluginInstanceProxy::addValueToArray): Use asString/value instead of
817         toWTFString.
818         * WebView/WebView.mm:
819         (aeDescFromJSValue): Use asString/value instead of getString.
820
821 2016-12-15  Chris Dumez  <cdumez@apple.com>
822
823         Make sure HTML validation bubble's state is updated after layout
824         https://bugs.webkit.org/show_bug.cgi?id=165922
825         <rdar://problem/29694730>
826
827         Reviewed by Simon Fraser.
828
829         Make sure HTML validation bubble's state is updated after layout.
830         In particular, if the validation bubble's associated element has
831         moved or is no longer visible, we now hide the bubble.
832
833         * WebCoreSupport/WebValidationMessageClient.h:
834         * WebCoreSupport/WebValidationMessageClient.mm:
835         (WebValidationMessageClient::showValidationMessage):
836         (WebValidationMessageClient::hideValidationMessage):
837         (WebValidationMessageClient::updateValidationBubbleStateIfNeeded):
838
839 2016-12-15  Chris Dumez  <cdumez@apple.com>
840
841         Move charCode / keyCode / which attributes from UIEvent to KeyboardEvent
842         https://bugs.webkit.org/show_bug.cgi?id=165904
843
844         Reviewed by Sam Weinig.
845
846         Update ObjC bindings so they keep building.
847
848         * DOM/DOMUIEvent.mm:
849         (-[DOMUIEvent keyCode]):
850         (-[DOMUIEvent charCode]):
851
852 2016-12-15  Andreas Kling  <akling@apple.com>
853
854         Always clear RenderLayer backing stores when going into page cache.
855         <https://webkit.org/b/165901>
856
857         Reviewed by Simon Fraser.
858
859         * WebView/WebView.mm:
860         (+[WebView _setCacheModel:]):
861
862 2016-12-12  Alex Christensen  <achristensen@webkit.org>
863
864         Remove unused workaround for Silverlight
865         https://bugs.webkit.org/show_bug.cgi?id=165773
866
867         Reviewed by Dean Jackson.
868
869         * Plugins/WebNetscapePluginView.mm:
870         (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]): Deleted.
871         This code was introduced in January 2010.  Microsoft fixed their bug shortly thereafter.
872         Allowing 6 years for users to update Silverlight is more than enough.
873         Safari doesn't even use WebKit1 for this any more.
874         I need this to be removed because this is the only non-WebGL code that needs to link against
875         the OpenGL framework, and I'm changing how that is done to link only through ANGLE instead.
876
877 2016-12-12  Chris Dumez  <cdumez@apple.com>
878
879         Document.visibilityState should use an IDL string enumeration
880         https://bugs.webkit.org/show_bug.cgi?id=165774
881
882         Reviewed by Daniel Bates.
883
884         * DOM/DOMDocument.mm:
885         (-[DOMDocument visibilityState]):
886         * WebView/WebView.mm:
887         (kit):
888
889 2016-12-12  Jer Noble  <jer.noble@apple.com>
890
891         Remove implementation of legacy Mozilla-based Fullscreen API.
892         https://bugs.webkit.org/show_bug.cgi?id=165689
893         <rdar://problem/29603053>
894
895         Reviewed by Eric Carlson.
896
897         * DOM/DOMElement.mm:
898         (-[DOMElement webkitRequestFullScreen:]):
899
900 2016-12-10  Filip Pizlo  <fpizlo@apple.com>
901
902         The DOM should have an advancing wavefront opaque root barrier
903         https://bugs.webkit.org/show_bug.cgi?id=165712
904
905         Reviewed by Yusuke Suzuki.
906         
907         Propagate the JSDOMWindowBase::commonVM() -> commonVM() change.
908
909         * Misc/WebCoreStatistics.mm:
910         (+[WebCoreStatistics javaScriptObjectsCount]):
911         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
912         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
913         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
914         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
915         (+[WebCoreStatistics javaScriptObjectTypeCounts]):
916         (+[WebCoreStatistics shouldPrintExceptions]):
917         (+[WebCoreStatistics setShouldPrintExceptions:]):
918         (+[WebCoreStatistics memoryStatistics]):
919         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
920         * Plugins/Hosted/NetscapePluginHostProxy.mm:
921         (identifierFromIdentifierRep):
922         * Plugins/Hosted/ProxyInstance.mm:
923         (WebKit::ProxyInstance::getPropertyNames):
924         * Plugins/WebNetscapePluginStream.mm:
925         (WebNetscapePluginStream::wantsAllStreams):
926         * Plugins/WebNetscapePluginView.mm:
927         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
928         (-[WebNetscapePluginView privateBrowsingModeDidChange]):
929         (-[WebNetscapePluginView setWindowIfNecessary]):
930         (-[WebNetscapePluginView createPluginScriptableObject]):
931         (-[WebNetscapePluginView getFormValue:]):
932         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
933         (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
934         (-[WebNetscapePluginView loadPluginRequest:]):
935         (-[WebNetscapePluginView _printedPluginBitmap]):
936         * Plugins/WebPluginController.mm:
937         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
938         (-[WebPluginController stopOnePlugin:]):
939         (-[WebPluginController stopOnePluginForPageCache:]):
940         (-[WebPluginController destroyOnePlugin:]):
941         (-[WebPluginController startAllPlugins]):
942         (-[WebPluginController addPlugin:]):
943
944 2016-12-09  Dave Hyatt  <hyatt@apple.com>
945
946         [CSS Parser] Remove the old CSS Parser
947         https://bugs.webkit.org/show_bug.cgi?id=165645
948
949         Reviewed by Daniel Bates.
950
951         * DOM/DOMCSS.mm:
952         (kitClass):
953         * DOM/DOMCSSRule.h:
954
955 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
956
957         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
958         https://bugs.webkit.org/show_bug.cgi?id=165251
959
960         Reviewed by Dean Jackson.
961
962         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
963
964         * WebView/WebPreferenceKeysPrivate.h: Add MediaStream and PeerConnection preferences.
965         * WebView/WebPreferences.mm:
966         (+[WebPreferences initialize]):
967         (-[WebPreferences mediaStreamEnabled]):
968         (-[WebPreferences setMediaStreamEnabled:]):
969         (-[WebPreferences peerConnectionEnabled]):
970         (-[WebPreferences setPeerConnectionEnabled:]):
971         * WebView/WebPreferencesPrivate.h:
972         * WebView/WebView.mm:
973         (-[WebView _preferencesChanged:]):
974
975 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
976
977         Don’t expose pointer lock in WebKit1 Objective-C API
978         https://bugs.webkit.org/show_bug.cgi?id=165692
979
980         Reviewed by Simon Fraser.
981
982         * DOM/DOMDocument.mm:
983         (-[DOMDocument pointerLockElement]): Deleted.
984         (-[DOMDocument exitPointerLock]): Deleted.
985         * DOM/DOMElement.mm:
986         (-[DOMElement requestPointerLock]): Deleted.
987         * DOM/DOMMouseEvent.mm:
988         (-[DOMMouseEvent movementX]): Deleted.
989         (-[DOMMouseEvent movementY]): Deleted.
990
991 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
992
993         document.webkitFullscreenElement leaks elements inside a shadow tree
994         https://bugs.webkit.org/show_bug.cgi?id=158471
995
996         Reviewed by Chris Dumez.
997
998         Use the API for bindings to avoid exposing nodes inside a shadow tree.
999
1000         * DOM/DOMDocument.mm:
1001         (-[DOMDocument webkitCurrentFullScreenElement]):
1002         (-[DOMDocument webkitFullscreenElement]):
1003
1004 2016-12-09  Beth Dakin  <bdakin@apple.com>
1005
1006         Password fields should not show the emoji button in TouchBar
1007         https://bugs.webkit.org/show_bug.cgi?id=165673
1008         -and corresponding-
1009         rdar://problem/29235739
1010
1011         Reviewed by Wenson Hsieh.
1012
1013         This patch adds a new ivar for the password touch bar and password 
1014         candidateListTouchBarItem. Since this TouchBar will actually have a different set 
1015         of identifiers than the plain text TouchBar, it should just have its own variable.
1016
1017         The candidate list should be the only item for passwords.
1018         * WebView/WebView.mm:
1019         (-[WebView _passwordTextTouchBarDefaultItemIdentifiers]):
1020
1021         Account for _passwordTextTouchBar.
1022         (-[WebView didChangeAutomaticTextCompletion:]):
1023         (-[WebView setUpTextTouchBar:]):
1024         (-[WebView textTouchBar]):
1025
1026         The empty candidates array is not needed. We can just set @[ ] as the candidates 
1027         for the _passwordTextCandidateListTouchBarItem. Safe guards already exist in the 
1028         other parts of the code to prevent us from requesting or setting other candidates 
1029         when in a password field. 
1030         (-[WebView updateTextTouchBar]):
1031
1032         Account for _passwordTextTouchBar.
1033         (-[WebView candidateList]):
1034         * WebView/WebViewData.h:
1035
1036 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
1037
1038         Enable SharedArrayBuffer, remove the flag
1039         https://bugs.webkit.org/show_bug.cgi?id=165614
1040
1041         Rubber stamped by Geoffrey Garen.
1042
1043         * WebView/WebPreferencesPrivate.h:
1044
1045 2016-12-07  Dean Jackson  <dino@apple.com>
1046
1047         Remove runtime toggle for pointer-lock
1048         https://bugs.webkit.org/show_bug.cgi?id=165577
1049         <rdar://problems/29566996>
1050
1051         Reviewed by Jon Lee.
1052
1053         Remove any runtime calls to check if pointer-lock is enabled. It's
1054         either compiled in or out.
1055
1056         * WebView/WebPreferenceKeysPrivate.h:
1057         * WebView/WebPreferences.mm:
1058         (-[WebPreferences pointerLockEnabled]): Deleted.
1059         (-[WebPreferences setPointerLockEnabled:]): Deleted.
1060         * WebView/WebPreferencesPrivate.h:
1061         * WebView/WebView.mm:
1062         (-[WebView _preferencesChanged:]):
1063
1064 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
1065
1066         Correct SDKROOT values in xcconfig files
1067         https://bugs.webkit.org/show_bug.cgi?id=165487
1068         rdar://problem/29539209
1069
1070         Reviewed by Dan Bernstein.
1071
1072         Fix suggested by Dan Bernstein.
1073
1074         * Configurations/DebugRelease.xcconfig:
1075
1076 2016-12-05  Simon Fraser  <simon.fraser@apple.com>
1077
1078         Improve the behavior of scroll-into-view when the target is inside position:fixed
1079         https://bugs.webkit.org/show_bug.cgi?id=165354
1080
1081         Reviewed by Zalan Bujtas.
1082
1083         Plumb through 'insideFixed'. We don't get compute it, so behavior from
1084         these call sites won't change.
1085
1086         * WebView/WebFrame.mm:
1087         (-[WebFrame _scrollDOMRangeToVisible:]):
1088         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
1089
1090 2016-12-06  Simon Fraser  <simon.fraser@apple.com>
1091
1092         Enable visual viewports by default on Mac, and iOS Wk2
1093         https://bugs.webkit.org/show_bug.cgi?id=165452
1094
1095         Reviewed by Zalan Bujtas.
1096
1097         Turn visual viewports on by default for WK1 on Mac.
1098
1099         * WebView/WebPreferences.mm:
1100         (+[WebPreferences initialize]):
1101
1102 2016-12-05  Dean Jackson  <dino@apple.com>
1103
1104         pointer lock needs to be feature detectable
1105         https://bugs.webkit.org/show_bug.cgi?id=165426
1106         <rdar://problem/29486715>
1107
1108         Reviewed by Antoine Quint.
1109
1110         Set the RuntimeEnabledFeature as preferences
1111         change.
1112
1113         * WebView/WebView.mm:
1114         (-[WebView _preferencesChanged:]):
1115
1116 2016-12-05  Ryan Haddad  <ryanhaddad@apple.com>
1117
1118         Unreviewed, rolling out r209299.
1119
1120         This change appears to have caused LayoutTest failures on
1121         Sierra WK1.
1122
1123         Reverted changeset:
1124
1125         "Improve the behavior of scroll-into-view when the target is
1126         inside position:fixed"
1127         https://bugs.webkit.org/show_bug.cgi?id=165354
1128         http://trac.webkit.org/changeset/209299
1129
1130 2016-12-02  Simon Fraser  <simon.fraser@apple.com>
1131
1132         Improve the behavior of scroll-into-view when the target is inside position:fixed
1133         https://bugs.webkit.org/show_bug.cgi?id=165354
1134
1135         Reviewed by Zalan Bujtas.
1136
1137         Plumb through 'insideFixed'. We don't get compute it, so behavior from
1138         these call sites won't change.
1139
1140         * WebView/WebFrame.mm:
1141         (-[WebFrame _scrollDOMRangeToVisible:]):
1142         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
1143
1144 2016-12-02  Andy Estes  <aestes@apple.com>
1145
1146         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
1147         https://bugs.webkit.org/show_bug.cgi?id=164492
1148
1149         Reviewed by Dan Bernstein.
1150
1151         * Configurations/WebKitLegacy.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
1152         com.apple.$(PRODUCT_NAME:rfc1034identifier).
1153         * Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
1154         ${PRODUCT_BUNDLE_IDENTIFIER}.
1155
1156 2016-12-02  Chris Dumez  <cdumez@apple.com>
1157
1158         Regression(r209252): HTML interactive validation should not be enabled on iOS WK1 yet
1159         https://bugs.webkit.org/show_bug.cgi?id=165328
1160
1161         Reviewed by Simon Fraser.
1162
1163         Only enable HTML interactive form validation on Mac WK1, not iOS WK1.
1164
1165         * WebView/WebViewData.mm:
1166         (-[WebViewPrivate init]):
1167
1168 2016-12-02  Chris Dumez  <cdumez@apple.com>
1169
1170         [Mac][WK1] Implement new HTML interactive form validation user interface
1171         https://bugs.webkit.org/show_bug.cgi?id=164483
1172
1173         Reviewed by Simon Fraser.
1174
1175         Implement new HTML interactive form validation user interface on Mac
1176         WK1 and enable it by default.
1177
1178         * WebCoreSupport/WebValidationMessageClient.h: Added.
1179         * WebCoreSupport/WebValidationMessageClient.mm: Added.
1180         (WebValidationMessageClient::WebValidationMessageClient):
1181         (WebValidationMessageClient::~WebValidationMessageClient):
1182         (WebValidationMessageClient::showValidationMessage):
1183         (WebValidationMessageClient::hideValidationMessage):
1184         (WebValidationMessageClient::isValidationMessageVisible):
1185         * WebView/WebHTMLView.mm:
1186         (-[WebHTMLView _frameOrBoundsChanged]):
1187         * WebView/WebView.mm:
1188         (-[WebView _commonInitializationWithFrameName:groupName:]):
1189         (-[WebView _willStartScrollingOrZooming]):
1190         (-[WebView _contentsOfUserInterfaceItem:]):
1191         (-[WebView _scaleWebView:atOrigin:]):
1192         (-[WebView _didScrollDocumentInFrameView:]):
1193         (-[WebView _setZoomMultiplier:isTextOnly:]):
1194         (-[WebView showFormValidationMessage:withAnchorRect:]):
1195         (-[WebView hideFormValidationMessage]):
1196         * WebView/WebViewData.h:
1197         * WebView/WebViewData.mm:
1198         (-[WebViewPrivate init]):
1199         * WebView/WebViewInternal.h:
1200         * WebView/WebViewPrivate.h:
1201
1202 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
1203
1204         Add a runtime flag for SubtleCrypto
1205         https://bugs.webkit.org/show_bug.cgi?id=164982
1206
1207         Reviewed by Brent Fulgham.
1208
1209         * WebView/WebPreferenceKeysPrivate.h:
1210         * WebView/WebPreferences.mm:
1211         (+[WebPreferences initialize]):
1212         (-[WebPreferences subtleCryptoEnabled]):
1213         (-[WebPreferences setSubtleCryptoEnabled:]):
1214         * WebView/WebPreferencesPrivate.h:
1215         * WebView/WebView.mm:
1216         (-[WebView _preferencesChanged:]):
1217
1218 2016-11-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
1219
1220         Add separate settings and preferences to enable/disable async decoding for large images and animated images
1221         https://bugs.webkit.org/show_bug.cgi?id=165177
1222
1223         Reviewed by Simon Fraser.
1224         
1225         Hook up the async image decoding settings for WebKit1.
1226
1227         * WebView/WebPreferenceKeysPrivate.h:
1228         * WebView/WebPreferences.mm:
1229         (+[WebPreferences initialize]):
1230         (-[WebPreferences largeImageAsyncDecodingEnabled]):
1231         (-[WebPreferences setLargeImageAsyncDecodingEnabled:]):
1232         (-[WebPreferences animatedImageAsyncDecodingEnabled]):
1233         (-[WebPreferences setAnimatedImageAsyncDecodingEnabled:]):
1234         (-[WebPreferences asyncImageDecodingEnabled]): Deleted.
1235         (-[WebPreferences setAsyncImageDecodingEnabled:]): Deleted.
1236         * WebView/WebPreferencesPrivate.h:
1237         * WebView/WebView.mm:
1238         (-[WebView _preferencesChanged:]):
1239
1240 2016-11-29  Andy Estes  <aestes@apple.com>
1241
1242         [Cocoa] Enable two clang warnings recommended by Xcode
1243         https://bugs.webkit.org/show_bug.cgi?id=164498
1244
1245         Reviewed by Mark Lam.
1246
1247         * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
1248
1249 2016-11-26  Yusuke Suzuki  <utatane.tea@gmail.com>
1250
1251         [WTF] Import std::optional reference implementation as WTF::Optional
1252         https://bugs.webkit.org/show_bug.cgi?id=164199
1253
1254         Reviewed by Saam Barati and Sam Weinig.
1255
1256         Use WTF::Optional::value_or.
1257
1258         * DOM/DOMHTMLOptionsCollection.mm:
1259         (-[DOMHTMLOptionsCollection add:index:]):
1260         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1261         (WebKit::NetscapePluginInstanceProxy::evaluate):
1262         * Plugins/WebNetscapePluginView.mm:
1263         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
1264         * WebCoreSupport/WebFrameLoaderClient.h:
1265         * WebCoreSupport/WebFrameLoaderClient.mm:
1266         (WebFrameLoaderClient::dispatchDidCommitLoad):
1267         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1268         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1269         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
1270         (WebPaymentCoordinatorClient::completeShippingContactSelection):
1271         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
1272         * WebCoreSupport/WebSecurityOrigin.mm:
1273         (-[WebSecurityOrigin port]):
1274         * WebView/WebHTMLView.mm:
1275         (toAction):
1276         (toTag):
1277
1278 2016-11-26  Sam Weinig  <sam@webkit.org>
1279
1280         Convert IntersectionObserver over to using RuntimeEnabledFeatures so it can be properly excluded from script
1281         https://bugs.webkit.org/show_bug.cgi?id=164965
1282
1283         Reviewed by Simon Fraser.
1284
1285         * WebView/WebPreferenceKeysPrivate.h:
1286         * WebView/WebPreferences.mm:
1287         (-[WebPreferences intersectionObserverEnabled]):
1288         (-[WebPreferences setIntersectionObserverEnabled:]):
1289         * WebView/WebPreferencesPrivate.h:
1290         * WebView/WebView.mm:
1291         (-[WebView _preferencesChanged:]):
1292         Add a preference, defaulting to off, for enabling IntersectionObserver.
1293
1294 2016-11-22  Dan Bernstein  <mitz@apple.com>
1295
1296         [Mac] In Legacy WebKit, pressing an arrow key in editable content doesn’t hide the mouse cursor
1297         https://bugs.webkit.org/show_bug.cgi?id=165036
1298         <rdar://problem/5708580>
1299
1300         Reviewed by Alexey Proskuryakov.
1301
1302         * WebView/WebHTMLView.mm:
1303         (-[WebHTMLView performKeyEquivalent:]): Hide the cursor if WebCore handled the event,
1304           similarly to what we do in -keyDown: and to what WKWebView does with all key events.
1305
1306 2016-11-21  Alex Christensen  <achristensen@webkit.org>
1307
1308         Fix Sierra CMake build after r208452
1309         https://bugs.webkit.org/show_bug.cgi?id=164437
1310
1311         * WebView/WebView.mm:
1312         (-[WebView updateMediaTouchBar]):
1313         I haven't enabled VIDEO_PRESENTATION_MODE in the CMake build yet.
1314         It's needed for playbackSessionInterface to exist.
1315
1316 2016-11-18  Enrica Casucci  <enrica@apple.com>
1317
1318         Refactor drag and drop for WebKit2 to encode DragData message exchange.
1319         https://bugs.webkit.org/show_bug.cgi?id=164945
1320
1321         Reviewed by Tim Horton.
1322
1323         * WebCoreSupport/WebDragClient.h:
1324         * WebCoreSupport/WebDragClient.mm:
1325         (WebDragClient::actionMaskForDrag):
1326         (WebDragClient::willPerformDragDestinationAction):
1327
1328 2016-11-18  Jeremy Jones  <jeremyj@apple.com>
1329
1330         Add runtime flag to enable pointer lock. Enable pointer lock feature for mac.
1331         https://bugs.webkit.org/show_bug.cgi?id=163801
1332
1333         Reviewed by Simon Fraser.
1334
1335         Plumb through PointerLockEnabled setting.
1336
1337         * Configurations/FeatureDefines.xcconfig:
1338         * WebCoreSupport/WebChromeClient.mm:
1339         (WebChromeClient::requestPointerUnlock):
1340         * WebView/WebPreferenceKeysPrivate.h:
1341         * WebView/WebPreferences.mm:
1342         (-[WebPreferences pointerLockEnabled]):
1343         (-[WebPreferences setPointerLockEnabled:]):
1344         * WebView/WebPreferencesPrivate.h:
1345         * WebView/WebView.mm:
1346         (-[WebView _preferencesChanged:]):
1347
1348 2016-11-17  Dan Bernstein  <mitz@apple.com>
1349
1350         Try to fix some non-macOS builds.
1351
1352         * WebView/WebView.mm:
1353
1354 2016-11-16  Dave Hyatt  <hyatt@apple.com>
1355
1356         [CSS Parser] Add @supports, @keyframe and media query parsing options
1357         https://bugs.webkit.org/show_bug.cgi?id=164821
1358
1359         Reviewed by Sam Weinig and Zalan Bujtas.
1360
1361         Fix up the create call now that fallback descriptor syntax is gone.
1362
1363         * DOM/DOM.mm:
1364         (-[DOMHTMLLinkElement _mediaQueryMatches]):
1365
1366 2016-11-17  Saam Barati  <sbarati@apple.com>
1367
1368         Remove async/await compile time flag and enable tests
1369         https://bugs.webkit.org/show_bug.cgi?id=164828
1370         <rdar://problem/28639334>
1371
1372         Reviewed by Yusuke Suzuki.
1373
1374         * Configurations/FeatureDefines.xcconfig:
1375
1376 2016-11-17  Yusuke Suzuki  <utatane.tea@gmail.com>
1377
1378         [JSC] WTF::TemporaryChange with WTF::SetForScope
1379         https://bugs.webkit.org/show_bug.cgi?id=164761
1380
1381         Reviewed by Saam Barati.
1382
1383         * WebView/WebView.mm:
1384         (-[WebView updateTextTouchBar]):
1385
1386 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1387
1388         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
1389         https://bugs.webkit.org/show_bug.cgi?id=164827
1390
1391         Reviewed by Ryosuke Niwa.
1392
1393         * Configurations/FeatureDefines.xcconfig:
1394         * WebView/WebPreferenceKeysPrivate.h:
1395         * WebView/WebPreferences.mm:
1396         (+[WebPreferences initialize]):
1397         (-[WebPreferences es6ModulesEnabled]):
1398         (-[WebPreferences setES6ModulesEnabled:]):
1399         * WebView/WebPreferencesPrivate.h:
1400         * WebView/WebView.mm:
1401         (-[WebView _preferencesChanged:]):
1402
1403 2016-11-14  Alex Christensen  <achristensen@webkit.org>
1404
1405         Move SecurityOrigin::createFromDatabaseIdentifier to SecurityOriginData
1406         https://bugs.webkit.org/show_bug.cgi?id=164720
1407
1408         Reviewed by Brady Eidson.
1409
1410         * Storage/WebDatabaseManager.mm:
1411         (-[WebDatabaseManager origins]):
1412         (-[WebDatabaseManager databasesWithOrigin:]):
1413         (-[WebDatabaseManager deleteOrigin:]):
1414         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
1415         * Storage/WebDatabaseManagerClient.h:
1416         * Storage/WebDatabaseManagerClient.mm:
1417         (DidModifyOriginData::dispatchToMainThread):
1418         (DidModifyOriginData::DidModifyOriginData):
1419         (WebDatabaseManagerClient::dispatchDidModifyOrigin):
1420         (WebDatabaseManagerClient::dispatchDidModifyDatabase):
1421         * Storage/WebDatabaseQuotaManager.mm:
1422         (-[WebDatabaseQuotaManager usage]):
1423         (-[WebDatabaseQuotaManager quota]):
1424         (-[WebDatabaseQuotaManager setQuota:]):
1425         * Storage/WebStorageManager.mm:
1426         (-[WebStorageManager origins]):
1427         (-[WebStorageManager deleteOrigin:]):
1428         * Storage/WebStorageTrackerClient.h:
1429         * Storage/WebStorageTrackerClient.mm:
1430         (WebStorageTrackerClient::dispatchDidModifyOrigin):
1431         * WebCoreSupport/WebSecurityOrigin.mm:
1432         (-[WebSecurityOrigin usage]):
1433         (-[WebSecurityOrigin quota]):
1434         (-[WebSecurityOrigin setQuota:]):
1435
1436 2016-11-13  Darin Adler  <darin@apple.com>
1437
1438         Fix exception handling in SQL database code, streamline and update code
1439         https://bugs.webkit.org/show_bug.cgi?id=164685
1440
1441         Reviewed by Sam Weinig.
1442
1443         * Storage/WebDatabaseManager.mm:
1444         (-[WebDatabaseManager origins]): Updated to use DatabaseTracker and pass
1445         a reference.
1446         (-[WebDatabaseManager databasesWithOrigin:]): Ditto.
1447         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Pass reference,
1448         but continue to use DatabaseManager.
1449         (-[WebDatabaseManager deleteOrigin:]): Use DatabaseTracker and pass a
1450         reference.
1451         (-[WebDatabaseManager deleteDatabase:withOrigin:]): Ditto.
1452
1453         * Storage/WebDatabaseManagerClient.h: Updated to take references.
1454         * Storage/WebDatabaseManagerClient.mm:
1455         (WebDatabaseManagerClient::WebDatabaseManagerClient): Initialize data
1456         members in the class definition.
1457         (DidModifyOriginData::dispatchToMainThread): Take references.
1458         (DidModifyOriginData::DidModifyOriginData): Ditto.
1459         (WebDatabaseManagerClient::dispatchDidModifyOrigin): Ditto.
1460         (WebDatabaseManagerClient::dispatchDidModifyDatabase): Ditto.
1461         (WebDatabaseManagerClient::dispatchDidAddNewOrigin): Ditto. Also use
1462         DatabaseTracker::singleton instead of tracker.
1463
1464         * Storage/WebDatabaseQuotaManager.mm:
1465         (-[WebDatabaseQuotaManager initWithOrigin:]): Reject nil pointer argument.
1466         (-[WebDatabaseQuotaManager usage]): Use reference instead of pointer.
1467         (-[WebDatabaseQuotaManager quota]): Ditto.
1468         (-[WebDatabaseQuotaManager setQuota:]): Ditto.
1469         * WebCoreSupport/WebSecurityOrigin.mm:
1470         (-[WebSecurityOrigin initWithURL:]): Tweaked code a bit.
1471         (-[WebSecurityOrigin usage]): Use DatabaseTracker and pass a reference.
1472         (-[WebSecurityOrigin quota]): Ditto.
1473         (-[WebSecurityOrigin setQuota:]): Ditto.
1474         * WebView/WebFrame.mm:
1475         (-[WebFrame _cacheabilityDictionary]): Pass a reference.
1476
1477 2016-11-12  Darin Adler  <darin@apple.com>
1478
1479         Remove a few assorted uses of ExceptionCode
1480         https://bugs.webkit.org/show_bug.cgi?id=164683
1481
1482         Reviewed by Chris Dumez.
1483
1484         * DOM/DOMDOMImplementation.mm:
1485         (-[DOMImplementation createDocumentType:publicId:systemId:]):
1486         Use raiseOnDOMError instead of much longer hand written equivalent.
1487         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
1488
1489         * DOM/DOMDocument.mm:
1490         (-[DOMDocument createEntityReference:]): Use raiseNotSupportedErrorException
1491         so we are not using a specific exception code.
1492
1493         * DOM/DOMHTMLOptionsCollection.mm:
1494         (-[DOMHTMLOptionsCollection add:index:]): Use raiseOnDOMError instead of
1495         much longer hand written equivalent.
1496         * DOM/DOMHTMLSelectElement.mm:
1497         (-[DOMHTMLSelectElement add:before:]): Ditto. Also removed unneeded return
1498         statement after calling a "no return" function.
1499
1500         * DOM/ExceptionHandlers.h: Removed overloads of raiseDOMException and
1501         raiseOnDOMError functions that take ExceptionCode; keep the ones that take
1502         Exception and ExceptionOr. Renamed the other overload of raiseDOMException
1503         to raiseDOMErrorException; it is only used as the non-inline implementation
1504         part of the inline raiseOnDOMError function.
1505         * DOM/ExceptionHandlers.mm:
1506         (raiseDOMErrorException): Renamed. Made the ExceptionCode overload be local
1507         to this source file instead of in the header.
1508         (raiseTypeErrorException): Updated for name change.
1509         (raiseNotSupportedErrorException): Added.
1510
1511 2016-11-11  Ryosuke Niwa  <rniwa@webkit.org>
1512
1513         Hovering over a slotted Text node clears hover state
1514         https://bugs.webkit.org/show_bug.cgi?id=164002
1515         <rdar://problem/29040471>
1516
1517         Reviewed by Simon Fraser.
1518
1519         * WebView/WebImmediateActionController.mm:
1520         (-[WebImmediateActionController performHitTestAtPoint:]):
1521
1522 2016-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1523
1524         [WK2] autocorrect and autocapitalize attributes do not work in contenteditable elements
1525         https://bugs.webkit.org/show_bug.cgi?id=164538
1526         <rdar://problem/8418711>
1527
1528         Reviewed by Ryosuke Niwa.
1529
1530         Account for renaming HTMLElement::autocorrect to HTMLElement::shouldAutocorrect, as well as moving
1531         WebAutocapitalizeType to WebKit from WebCore. Additionally, moves the -autocorrect and -autocapitalize SPIs out
1532         of HTML(Input|Form|TextArea)ElementPrivate.h and into HTMLElementPrivate.h. This also means removing redundant
1533         code for interfacing with the unwrapped HTMLElement's autocorrect and autocapitalize attributes.
1534
1535         * DOM/DOMHTML.mm:
1536         (webAutocapitalizeType):
1537         (-[DOMHTMLInputElement _autocapitalizeType]):
1538         (-[DOMHTMLTextAreaElement _autocapitalizeType]):
1539         * DOM/DOMHTMLElement.mm:
1540         (-[DOMHTMLElement autocorrect]):
1541         (-[DOMHTMLElement setAutocorrect:]):
1542         (-[DOMHTMLElement autocapitalize]):
1543         (-[DOMHTMLElement setAutocapitalize:]):
1544         * DOM/DOMHTMLElementPrivate.h: Copied from Source/WebCore/html/Autocapitalize.h.
1545         * DOM/DOMHTMLFormElement.mm:
1546         (-[DOMHTMLFormElement autocorrect]): Deleted.
1547         (-[DOMHTMLFormElement setAutocorrect:]): Deleted.
1548         (-[DOMHTMLFormElement autocapitalize]): Deleted.
1549         (-[DOMHTMLFormElement setAutocapitalize:]): Deleted.
1550         * DOM/DOMHTMLInputElement.mm:
1551         (-[DOMHTMLInputElement autocorrect]): Deleted.
1552         (-[DOMHTMLInputElement setAutocorrect:]): Deleted.
1553         (-[DOMHTMLInputElement autocapitalize]): Deleted.
1554         (-[DOMHTMLInputElement setAutocapitalize:]): Deleted.
1555         * DOM/DOMHTMLInputElementPrivate.h:
1556         * DOM/DOMHTMLTextAreaElement.mm:
1557         (-[DOMHTMLTextAreaElement autocorrect]): Deleted.
1558         (-[DOMHTMLTextAreaElement setAutocorrect:]): Deleted.
1559         (-[DOMHTMLTextAreaElement autocapitalize]): Deleted.
1560         (-[DOMHTMLTextAreaElement setAutocapitalize:]): Deleted.
1561         * DOM/DOMHTMLTextAreaElementPrivate.h:
1562
1563         We need to import DOMHTMLElementPrivate.h here to avoid breaking UIKit. We should follow this up with a UIKit
1564         change to import DOMHTMLElementPrivate.h directly.
1565
1566         * DOM/DOMPrivate.h:
1567         * DOM/WebAutocapitalizeTypes.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h.
1568         * MigrateHeaders.make:
1569
1570 2016-11-11  Beth Dakin  <bdakin@apple.com>
1571
1572         Move to modern TouchBar methods
1573         https://bugs.webkit.org/show_bug.cgi?id=164655
1574         -and corresponding-
1575         rdar://problem/29226911
1576
1577         Reviewed by Wenson Hsieh.
1578
1579         customizationDefaultItemIdentifiers -> defaultItemIdentifiers
1580         itemIdentifiers -> defaultItemIdentifiers
1581         defaultItems -> templateItems
1582
1583         * WebView/WebView.mm:
1584         (-[WebView _plainTextTouchBarDefaultItemIdentifiers]):
1585         (-[WebView _richTextTouchBarDefaultItemIdentifiers]):
1586         (-[WebView setUpTextTouchBar:]):
1587         (-[WebView updateTextTouchBar]):
1588         (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
1589         (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
1590
1591 2016-11-11  Darin Adler  <darin@apple.com>
1592
1593         Move Node from ExceptionCode to ExceptionOr
1594         https://bugs.webkit.org/show_bug.cgi?id=164515
1595
1596         Reviewed by Sam Weinig.
1597
1598         * DOM/DOMHTMLSelectElement.mm:
1599         (-[DOMHTMLSelectElement remove:]): Call remove instead of removeByIndex
1600         now that it was renamed.
1601         * DOM/DOMNode.mm:
1602         (-[DOMNode setNodeValue:]): Updated exception handling.
1603         (-[DOMNode setPrefix:]): Ditto.
1604         (-[DOMNode setTextContent:]): Ditto.
1605         (-[DOMNode insertBefore:refChild:]): Ditto.
1606         (-[DOMNode replaceChild:oldChild:]): Ditto.
1607         (-[DOMNode removeChild:]): Ditto.
1608         (-[DOMNode appendChild:]): Ditto.
1609         (-[DOMNode cloneNode:]): Ditto.
1610
1611 2016-11-11  Beth Dakin  <bdakin@apple.com>
1612
1613         Get touch bar code building for open source builds
1614         https://bugs.webkit.org/show_bug.cgi?id=164610
1615
1616         Reviewed by Wenson Hsieh.
1617
1618         * WebKitPrefix.h:
1619
1620 2016-11-10  Alex Christensen  <achristensen@webkit.org>
1621
1622         Fix assertion after r208534.
1623         https://bugs.webkit.org/show_bug.cgi?id=160497
1624
1625         * WebView/WebView.mm:
1626         (-[WebView _commonInitializationWithFrameName:groupName:]):
1627         (WebInstallMemoryPressureHandler):
1628         WebInstallMemoryPressureHandler can be called before [WebView initWithFrame:frameName:groupName:]
1629         When this happens, we should use the same std::once_flag to make sure we install the MemoryPressureHandler::singleton
1630         only once, otherwise we get an assertion !m_installed in MemoryPressureHandler::setLowMemoryHandler.
1631
1632 2016-11-10  Alex Christensen  <achristensen@webkit.org>
1633
1634         Move SecurityOrigin::databaseIdentifier() to SecurityOriginData
1635         https://bugs.webkit.org/show_bug.cgi?id=164573
1636
1637         Reviewed by Brady Eidson.
1638
1639         * WebCoreSupport/WebSecurityOrigin.mm:
1640         (-[WebSecurityOrigin databaseIdentifier]):
1641
1642 2016-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1643
1644         MemoryPressureHandler shouldn't know how to release WebCore memory
1645         https://bugs.webkit.org/show_bug.cgi?id=160497
1646
1647         Reviewed by Michael Catanzaro.
1648
1649         Set the low memory handler before installing the memory pressure handler.
1650
1651         * WebView/WebView.mm:
1652         (-[WebView _commonInitializationWithFrameName:groupName:]):
1653
1654 2016-11-09  Ryosuke Niwa  <rniwa@webkit.org>
1655
1656         WebHTMLView's _attributeStringFromDOMRange should use HTMLConverter instead of NSAttributedString's _initWithDOMRange
1657         https://bugs.webkit.org/show_bug.cgi?id=164501
1658         <rdar://problem/29152282>
1659
1660         Reviewed by Sam Weinig.
1661
1662         Align what [WebHTMLView attributedString] returns to what would be used on copy & paste by using HTMLConverter
1663         instead of _initWithDOMRange in [WebHTMLView _attributeStringFromDOMRange].
1664
1665         * WebView/WebHTMLView.mm:
1666         (-[WebHTMLView _attributedStringFromDOMRange:]): Renamed from _attributeStringFromDOMRange.
1667         (-[WebHTMLView attributedString]):
1668         (-[WebHTMLView selectedAttributedString]):
1669         (-[WebHTMLView selectedString]): Moved to reduce the number of occurrences of the if-defs.
1670
1671 2016-11-04  Brent Fulgham  <bfulgham@apple.com>
1672
1673         Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
1674         https://bugs.webkit.org/show_bug.cgi?id=155185
1675         <rdar://problem/11101440>
1676
1677         Reviewed by Brady Eidson.
1678
1679         Provide SPI to access the new quirk for localStorage. The quirk defaults to 'on'. When active, this
1680         quirk says that localStorage access should be granted, without needing to grant universal file access.
1681
1682         If the quirk is turned off, then localStorage is blocked unless the WebKit client explicitly
1683         grants universal file access.
1684
1685         * WebView/WebPreferenceKeysPrivate.h:
1686         * WebView/WebPreferences.mm:
1687         (-[WebPreferences needsLocalStorageQuirk]): Added.
1688         (-[WebPreferences setNeedsLocalStorageQuirk:]): Added.
1689         * WebView/WebPreferencesPrivate.h:
1690         * WebView/WebView.mm:
1691         (-[WebView _preferencesChanged:]): Honor the new localStorage quirk.
1692
1693 2016-11-09  Alex Christensen  <achristensen@webkit.org>
1694
1695         Clean up Storage code
1696         https://bugs.webkit.org/show_bug.cgi?id=164562
1697
1698         Reviewed by Brady Eidson.
1699
1700         * Storage/WebStorageManager.mm:
1701         (-[WebStorageManager origins]):
1702         (-[WebStorageManager deleteAllOrigins]):
1703         (-[WebStorageManager deleteOrigin:]):
1704         (-[WebStorageManager diskUsageForOrigin:]):
1705         (-[WebStorageManager syncLocalStorage]):
1706         (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
1707         (+[WebStorageManager setStorageDatabaseIdleInterval:]):
1708         (+[WebStorageManager closeIdleLocalStorageDatabases]):
1709         (WebKitInitializeStorageIfNecessary):
1710         * WebView/WebView.mm:
1711         (+[WebView _applicationWillTerminate]):
1712
1713 2016-11-09  Beth Dakin  <bdakin@apple.com>
1714
1715         Another attempted build fix.
1716
1717         * WebView/WebView.mm:
1718
1719 2016-11-09  Beth Dakin  <bdakin@apple.com>
1720
1721         Attempted build fix.
1722
1723         * WebView/WebView.mm:
1724
1725 2016-11-09  Darin Adler  <darin@apple.com>
1726
1727         Move Range from ExceptionCode to ExceptionOr
1728         https://bugs.webkit.org/show_bug.cgi?id=164457
1729
1730         Reviewed by Alex Christensen.
1731
1732         * DOM/DOMRange.mm:
1733         (-[DOMRange setStart:offset:]): Updated exception handling.
1734         (-[DOMRange setEnd:offset:]): Ditto.
1735         (-[DOMRange setStartBefore:]): Ditto.
1736         (-[DOMRange setStartAfter:]): Ditto.
1737         (-[DOMRange setEndBefore:]): Ditto.
1738         (-[DOMRange setEndAfter:]): Ditto.
1739         (-[DOMRange selectNode:]): Ditto.
1740         (-[DOMRange selectNodeContents:]): Ditto.
1741         (-[DOMRange compareBoundaryPoints:sourceRange:]): Ditto.
1742         (-[DOMRange deleteContents]): Ditto.
1743         (-[DOMRange extractContents]): Ditto.
1744         (-[DOMRange cloneContents]): Ditto.
1745         (-[DOMRange insertNode:]): Ditto.
1746         (-[DOMRange surroundContents:]): Ditto.
1747         (-[DOMRange createContextualFragment:]): Ditto.
1748         (-[DOMRange compareNode:]): Ditto.
1749         (-[DOMRange intersectsNode:]): Ditto.
1750         (-[DOMRange comparePoint:offset:]): Ditto.
1751         (-[DOMRange isPointInRange:offset:]): Ditto.
1752         (-[DOMRange expand:]): Ditto.
1753         * WebView/WebFrame.mm:
1754         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
1755         (-[WebFrame _smartDeleteRangeForProposedRange:]): Deleted.
1756         This function was incorrectly implemented (set both start and end of
1757         the range to the computed start), not declared in any header file,
1758         not used anywhere inside WebKit, and I also could not find a use of it
1759         in outside-WebKit Apple code.
1760         * mac/DOM/DOMUIKitExtensions.mm:
1761         (-[DOMRange move:inDirection:]): Ditto.
1762         (-[DOMRange extend:inDirection:]): Ditto.
1763
1764 2016-11-09  Darin Adler  <darin@apple.com>
1765
1766         Move EventTarget from ExceptionCode to ExceptionOr
1767         https://bugs.webkit.org/show_bug.cgi?id=164465
1768
1769         Reviewed by Youenn Fablet.
1770
1771         * DOM/DOMNode.mm:
1772         (-[DOMNode dispatchEvent:]): Updated exception handling.
1773
1774 2016-11-09  Chris Dumez  <cdumez@apple.com>
1775
1776         [Mac] Stop using deprecated AppKit enumeration values
1777         https://bugs.webkit.org/show_bug.cgi?id=164494
1778
1779         Reviewed by Darin Adler.
1780
1781         Stop using deprecated AppKit enumeration values.
1782
1783         * Carbon/CarbonWindowAdapter.mm:
1784         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1785         (-[CarbonWindowAdapter sendSuperEvent:]):
1786         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1787         (WebKit::NetscapePluginHostProxy::beginModal):
1788         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1789         (WebKit::NetscapePluginInstanceProxy::syntheticKeyDownWithCommandModifier):
1790         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1791         (-[WebHostedNetscapePluginView drawRect:]):
1792         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1793         (WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier):
1794         * WebCoreSupport/PopupMenuMac.mm:
1795         (PopupMenuMac::populate):
1796         (PopupMenuMac::show):
1797         * WebCoreSupport/WebContextMenuClient.mm:
1798         (WebContextMenuClient::showContextMenu):
1799         * WebCoreSupport/WebFrameLoaderClient.mm:
1800         (WebFrameLoaderClient::actionDictionary):
1801         * WebCoreSupport/WebInspectorClient.mm:
1802         (WebInspectorFrontendClient::canAttach):
1803         (-[WebInspectorWindowController window]):
1804         * WebInspector/WebNodeHighlight.mm:
1805         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1806         * WebView/WebFrameView.mm:
1807         (-[WebFrameView keyDown:keyDown:]):
1808         * WebView/WebFullScreenController.mm:
1809         (-[WebFullScreenController init]):
1810         (createBackgroundFullscreenWindow):
1811         * WebView/WebHTMLView.mm:
1812         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
1813         (-[WebHTMLView _setMouseDownEvent:_setMouseDownEvent:]):
1814         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
1815         (isQuickLookEvent):
1816         (-[WebHTMLView hitTest:]):
1817         (-[WebHTMLView _sendToolTipMouseExited]):
1818         (-[WebHTMLView _sendToolTipMouseEntered]):
1819         (mouseEventIsPartOfClickOrDrag):
1820         (-[WebHTMLView _updateMouseoverWithEvent:]):
1821         (-[WebHTMLView _autoscroll]):
1822         (-[WebHTMLView acceptsFirstResponder]):
1823         (-[WebHTMLView viewDidMoveToWindow]):
1824         (-[WebHTMLView mouseDown:mouseDown:]):
1825         (currentKeyboardEvent):
1826         (-[WebHTMLView _handleStyleKeyEquivalent:]):
1827         (-[WebHTMLView _interpretKeyEvent:savingCommands:]):
1828         * WebView/WebPDFView.mm:
1829         (-[WebPDFView hitTest:]):
1830         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1831         (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
1832         * WebView/WebTextCompletionController.mm:
1833         (-[WebTextCompletionController _buildUI]):
1834         (-[WebTextCompletionController _placePopupWindow:]):
1835         * WebView/WebView.mm:
1836         (-[WebView applicationFlags:]):
1837
1838 2016-11-09  Beth Dakin  <bdakin@apple.com>
1839
1840         Support TouchBar in WebKit
1841         https://bugs.webkit.org/show_bug.cgi?id=164437
1842         -and corresponding-
1843         rdar://problem/28876524
1844
1845         Reviewed by Darin Adler.
1846
1847         * WebCoreSupport/WebEditorClient.mm:
1848         (WebEditorClient::respondToChangedSelection):
1849         (WebEditorClient::updateEditorStateAfterLayoutIfEditabilityChanged):
1850         * WebView/WebHTMLView.mm:
1851         (-[WebHTMLView candidateListTouchBarItem]):
1852         * WebView/WebView.mm:
1853         (-[_WebTextListTouchBarViewController initWithWebView:]):
1854         (-[_WebTextListTouchBarViewController _selectList:]):
1855         (-[_WebTextListTouchBarViewController setCurrentListType:]):
1856         (-[WebTextTouchBarItemController initWithWebView:]):
1857         (-[WebTextTouchBarItemController itemForIdentifier:]):
1858         (-[WebTextTouchBarItemController webTextListTouchBarViewController]):
1859         (-[WebTextTouchBarItemController setTextIsBold:]):
1860         (-[WebTextTouchBarItemController setTextIsItalic:]):
1861         (-[WebTextTouchBarItemController setTextIsUnderlined:]):
1862         (-[WebTextTouchBarItemController _webChangeTextStyle:]):
1863         (-[WebTextTouchBarItemController setCurrentTextAlignment:]):
1864         (-[WebTextTouchBarItemController _webChangeTextAlignment:]):
1865         (-[WebTextTouchBarItemController textColor]):
1866         (-[WebTextTouchBarItemController setTextColor:]):
1867         (-[WebTextTouchBarItemController _webChangeColor:]):
1868         (-[WebTextTouchBarItemController textListViewController]):
1869         (-[WebView _commonInitializationWithFrameName:groupName:]):
1870         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
1871         (-[WebView shouldRequestCandidates]):
1872         (-[WebView forceRequestCandidatesForTesting]):
1873         (-[WebView makeTouchBar]):
1874         (-[WebView touchBar:makeItemForIdentifier:]):
1875         (textCheckingResultFromNSTextCheckingResult):
1876         (-[WebView candidateListTouchBarItem:endSelectingCandidateAtIndex:]):
1877         (-[WebView candidateListTouchBarItem:changedCandidateListVisibility:]):
1878         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
1879         (-[WebView _clearPlaybackControlsManager]):
1880         (-[WebView _dismissTextTouchBarPopoverItemWithIdentifier:]):
1881         (-[WebView _textTouchBarCustomizationAllowedIdentifiers]):
1882         (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]):
1883         (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]):
1884         (-[WebView touchBarDidExitCustomization:]):
1885         (-[WebView touchBarWillEnterCustomization:]):
1886         (-[WebView didChangeAutomaticTextCompletion:]):
1887         (-[WebView setUpTextTouchBar:]):
1888         (-[WebView _isRichlyEditable]):
1889         (-[WebView textTouchBar]):
1890         (-[WebView updateTextTouchBar]):
1891         (-[WebView updateMediaTouchBar]):
1892         (-[WebView updateTouchBar]):
1893         (-[WebView prepareForMouseDown]):
1894         (-[WebView prepareForMouseUp]):
1895         (-[WebView webViewAdditionsWillDestroyView]):
1896         (-[WebView candidateList]):
1897         (-[WebView updateWebViewAdditions]): Deleted.
1898         * WebView/WebViewData.h:
1899         * WebView/WebViewInternal.h:
1900         * WebView/WebViewPrivate.h:
1901
1902 2016-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1903
1904         Safari does not emit composition end if blurred for dead key / Japanese IME
1905         https://bugs.webkit.org/show_bug.cgi?id=164369
1906         <rdar://problem/29050439>
1907
1908         Reviewed by Ryosuke Niwa.
1909
1910         When canceling a composition, make sure that we clear the system IME state.
1911
1912         * WebCoreSupport/WebEditorClient.h:
1913         * WebCoreSupport/WebEditorClient.mm:
1914         (WebEditorClient::canceledComposition):
1915
1916 2016-11-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
1917
1918         Add a setting and preferences to enable/disable async image decoding
1919         https://bugs.webkit.org/show_bug.cgi?id=164417
1920
1921         Reviewed by Simon Fraser.
1922
1923         Hook up the asyncImageDecodingEnabled setting for WebKit1.
1924
1925         * WebView/WebPreferenceKeysPrivate.h:
1926         * WebView/WebPreferences.mm:
1927         (+[WebPreferences initialize]):
1928         (-[WebPreferences asyncImageDecodingEnabled]):
1929         (-[WebPreferences setAsyncImageDecodingEnabled:]):
1930         * WebView/WebPreferencesPrivate.h:
1931         * WebView/WebView.mm:
1932         (-[WebView _preferencesChanged:]):
1933
1934 2016-11-01  Alex Christensen  <achristensen@webkit.org>
1935
1936         Remove PassRefPtr from DumpRenderTree
1937         https://bugs.webkit.org/show_bug.cgi?id=164307
1938
1939         Reviewed by Sam Weinig.
1940
1941         * WebView/WebGeolocationPosition.mm:
1942         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1943
1944 2016-11-02  Romain Bellessort  <romain.bellessort@crf.canon.fr>
1945
1946         [Readable Streams API] Enable creation of ReadableByteStreamController
1947         https://bugs.webkit.org/show_bug.cgi?id=164014
1948
1949         Reviewed by Youenn Fablet.
1950
1951         Added flag for the byte stream part of Readable Streams API.
1952
1953         * Configurations/FeatureDefines.xcconfig:
1954
1955 2016-11-01  Ryosuke Niwa  <rniwa@webkit.org>
1956
1957         Remove CUSTOM_ELEMENTS build flag
1958         https://bugs.webkit.org/show_bug.cgi?id=164267
1959
1960         Reviewed by Antti Koivisto.
1961
1962         Removed the build flag.
1963
1964         * Configurations/FeatureDefines.xcconfig:
1965         * WebView/WebPreferences.mm:
1966         (+[WebPreferences initialize]):
1967         * WebView/WebView.mm:
1968         (-[WebView _preferencesChanged:]):
1969
1970 2016-11-01  Eric Carlson  <eric.carlson@apple.com>
1971
1972         [MediaStream] restrict media capture secure connections
1973         https://bugs.webkit.org/show_bug.cgi?id=164234
1974         <rdar://problem/28944906>
1975
1976         Reviewed by Alex Christensen.
1977
1978         * WebView/WebPreferenceKeysPrivate.h:
1979         * WebView/WebPreferences.mm:
1980         (+[WebPreferences initialize]): Initialize WebKitMediaCaptureRequiresSecureConnectionPreferenceKey.
1981         (-[WebPreferences mediaCaptureRequiresSecureConnection]): New.
1982         (-[WebPreferences setMediaCaptureRequiresSecureConnection:]): New.
1983         * WebView/WebPreferencesPrivate.h:
1984
1985         * WebView/WebView.mm:
1986         (-[WebView _preferencesChanged:]): Sync mediaCaptureRequiresSecureConnection.
1987
1988 2016-10-29  Filip Pizlo  <fpizlo@apple.com>
1989
1990         JSC should support SharedArrayBuffer
1991         https://bugs.webkit.org/show_bug.cgi?id=163986
1992
1993         Reviewed by Keith Miller.
1994         
1995         Support the RuntimeFlag.
1996
1997         * WebView/WebPreferencesPrivate.h:
1998
1999 2016-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
2000
2001         [WK1] Candidate visibility should not update as a result of selection during a dictionary lookup
2002         https://bugs.webkit.org/show_bug.cgi?id=164236
2003         <rdar://problem/28747712>
2004
2005         Reviewed by Beth Dakin.
2006
2007         See WebCore ChangeLog for more detail. Sets the Editor's isGettingDictionaryPopupInfo state to true during a
2008         dictionary lookup.
2009
2010         * WebCoreSupport/WebEditorClient.mm:
2011         (WebEditorClient::respondToChangedSelection):
2012         * WebView/WebImmediateActionController.mm:
2013         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
2014
2015 2016-10-31  Darin Adler  <darin@apple.com>
2016
2017         Move ChildNode and ParentNode from ExceptionCode to Exception, add support for ExceptionOr<T&>
2018         https://bugs.webkit.org/show_bug.cgi?id=164214
2019
2020         Reviewed by Alex Christensen.
2021
2022         * DOM/DOMCSSPrimitiveValue.mm:
2023         (-[DOMCSSPrimitiveValue getCounterValue]): Updated since return value
2024         is a reference now.
2025         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
2026
2027         * DOM/DOMDocument.mm:
2028         (-[DOMDocument querySelector:]): Updated exception handling.
2029         (-[DOMDocument querySelectorAll:]): Ditto.
2030         * DOM/DOMDocumentFragment.mm:
2031         (-[DOMDocumentFragment querySelector:]): Ditto.
2032         (-[DOMDocumentFragment querySelectorAll:]): Ditto.
2033         * DOM/DOMElement.mm:
2034         (-[DOMElement querySelector:]): Ditto.
2035         (-[DOMElement querySelectorAll:]): Ditto.
2036
2037 2016-10-31  Darin Adler  <darin@apple.com>
2038
2039         Convert Document from ExceptionCode to Exception
2040         https://bugs.webkit.org/show_bug.cgi?id=164212
2041
2042         Reviewed by Alex Christensen.
2043
2044         * DOM/DOMDocument.mm:
2045         (-[DOMDocument setXmlVersion:]): Updated exception handling.
2046         (-[DOMDocument cookie]): Ditto.
2047         (-[DOMDocument setCookie:]): Ditto.
2048         (-[DOMDocument setBody:]): Ditto.
2049         (-[DOMDocument createElement:]): Ditto.
2050         (-[DOMDocument createCDATASection:]): Ditto.
2051         (-[DOMDocument createProcessingInstruction:data:]): Ditto.
2052         (-[DOMDocument createAttribute:]): Ditto.
2053         (-[DOMDocument createEntityReference:]): Ditto.
2054         (-[DOMDocument importNode:deep:]): Ditto.
2055         (-[DOMDocument createElementNS:qualifiedName:]): Ditto.
2056         (-[DOMDocument createAttributeNS:qualifiedName:]): Ditto.
2057         (-[DOMDocument getElementsByTagNameNS:localName:]): Ditto.
2058         (-[DOMDocument adoptNode:]): Ditto.
2059         (-[DOMDocument createEvent:]): Ditto.
2060
2061 2016-10-30  Darin Adler  <darin@apple.com>
2062
2063         Move Element, NamedNodeMap, and DOMStringMap from ExceptionCode to Exception
2064         https://bugs.webkit.org/show_bug.cgi?id=164206
2065
2066         Reviewed by Chris Dumez.
2067
2068         * DOM/DOMElement.mm:
2069         (-[DOMElement setInnerHTML:]): Updated exception handling.
2070         (-[DOMElement setOuterHTML:]): Ditto.
2071         (-[DOMElement setAttribute:value:]): Ditto.
2072         (-[DOMElement setAttributeNode:]): Ditto.
2073         (-[DOMElement removeAttributeNode:]): Ditto.
2074         (-[DOMElement setAttributeNS:qualifiedName:value:]): Ditto.
2075         (-[DOMElement setAttributeNodeNS:]): Ditto.
2076         (-[DOMElement matches:]): Ditto.
2077         (-[DOMElement closest:]): Ditto.
2078         (-[DOMElement webkitMatchesSelector:]): Ditto.
2079         * DOM/DOMHTMLElement.mm:
2080         (-[DOMHTMLElement insertAdjacentElement:element:]): Ditto.
2081         (-[DOMHTMLElement insertAdjacentHTML:html:]): Ditto.
2082         (-[DOMHTMLElement insertAdjacentText:text:]): Ditto.
2083         * DOM/DOMNamedNodeMap.mm:
2084         (-[DOMNamedNodeMap setNamedItem:]): Ditto.
2085         (-[DOMNamedNodeMap removeNamedItem:]): Ditto.
2086         (-[DOMNamedNodeMap setNamedItemNS:]): Ditto.
2087         (-[DOMNamedNodeMap removeNamedItemNS:localName:]): Ditto.
2088
2089 2016-10-29  Darin Adler  <darin@apple.com>
2090
2091         Convert more of DOM from ExceptionCode to Exception
2092         https://bugs.webkit.org/show_bug.cgi?id=164173
2093
2094         Reviewed by Ryosuke Niwa.
2095
2096         * DOM/DOMCharacterData.mm:
2097         (-[DOMCharacterData substringData:length:]): Updated since this
2098         now uses ExceptionOr.
2099         (-[DOMCharacterData insertData:data:]): Ditto.
2100         (-[DOMCharacterData deleteData:length:]): Ditto.
2101         (-[DOMCharacterData replaceData:length:data:]): Ditto.
2102         * DOM/DOMText.mm:
2103         (-[DOMText splitText:]): Ditto.
2104         (-[DOMText replaceWholeText:]): Removed unneeded exception code
2105         handling from function that does not throw an exception.
2106
2107 2016-10-28  Darin Adler  <darin@apple.com>
2108
2109         Move all classes in the HTML directory from ExceptionCode to Exception
2110         https://bugs.webkit.org/show_bug.cgi?id=163876
2111
2112         Reviewed by Sam Weinig.
2113
2114         * DOM/DOMCharacterData.mm:
2115         (-[DOMCharacterData remove]): Updated exception handling.
2116         * DOM/DOMDOMTokenList.mm:
2117         (-[DOMDOMTokenList toggle:force:]): Ditto.
2118         * DOM/DOMDocumentType.mm:
2119         (-[DOMDocumentType remove]): Ditto.
2120         * DOM/DOMElement.mm:
2121         (-[DOMElement remove]): Ditto.
2122         * DOM/DOMHTML.mm:
2123         (-[DOMHTMLInputElement setValueAsNumberWithChangeEvent:]): Ditto.
2124         * DOM/DOMHTMLCanvasElement.mm:
2125         (-[DOMHTMLCanvasElement toDataURL:]): Ditto.
2126         * DOM/DOMHTMLElement.mm:
2127         (-[DOMHTMLElement setInnerText:]): Ditto.
2128         (-[DOMHTMLElement setOuterText:]): Ditto.
2129         (-[DOMHTMLElement setContentEditable:]): Ditto.
2130         * DOM/DOMHTMLInputElement.mm:
2131         (-[DOMHTMLInputElement setMaxLength:]): Ditto.
2132         (-[DOMHTMLInputElement setValueAsDate:]): Ditto.
2133         (-[DOMHTMLInputElement setValueAsNumber:]): Ditto.
2134         (-[DOMHTMLInputElement stepUp:]): Ditto.
2135         (-[DOMHTMLInputElement stepDown:]): Ditto.
2136         (-[DOMHTMLInputElement setRangeText:]): Ditto.
2137         (-[DOMHTMLInputElement setRangeText:start:end:selectionMode:]): Ditto.
2138         * DOM/DOMHTMLMarqueeElement.mm:
2139         (-[DOMHTMLMarqueeElement setLoop:]): Ditto.
2140         * DOM/DOMHTMLMediaElement.mm:
2141         (-[DOMHTMLMediaElement setCurrentTime:]): Ditto.
2142         (-[DOMHTMLMediaElement setVolume:]): Ditto.
2143         * DOM/DOMHTMLOptionsCollection.mm:
2144         (-[DOMHTMLOptionsCollection setLength:]): Ditto.
2145         * DOM/DOMHTMLTableElement.mm:
2146         (-[DOMHTMLTableElement setCaption:]): Ditto.
2147         (-[DOMHTMLTableElement setTHead:]): Ditto.
2148         (-[DOMHTMLTableElement setTFoot:]): Ditto.
2149         (-[DOMHTMLTableElement insertRow:]): Ditto.
2150         (-[DOMHTMLTableElement deleteRow:]): Ditto.
2151         * DOM/DOMHTMLTableRowElement.mm:
2152         (-[DOMHTMLTableRowElement insertCell:]): Ditto.
2153         (-[DOMHTMLTableRowElement deleteCell:]): Ditto.
2154         * DOM/DOMHTMLTableSectionElement.mm:
2155         (-[DOMHTMLTableSectionElement insertRow:]): Ditto.
2156         (-[DOMHTMLTableSectionElement deleteRow:]): Ditto.
2157         * DOM/DOMHTMLTextAreaElement.mm:
2158         (-[DOMHTMLTextAreaElement setMaxLength:]): Ditto.
2159         (-[DOMHTMLTextAreaElement setRangeText:]): Ditto.
2160         (-[DOMHTMLTextAreaElement setRangeText:start:end:selectionMode:]): Ditto.
2161         * DOM/DOMHTMLVideoElement.mm:
2162         (-[DOMHTMLVideoElement webkitEnterFullscreen]): Ditto.
2163         (-[DOMHTMLVideoElement webkitEnterFullScreen]): Changed to call the other named
2164         version (lowercase S) instead of repeating the logic from that method.
2165         (-[DOMHTMLVideoElement webkitExitFullScreen]): Ditto.
2166         * DOM/DOMTimeRanges.mm:
2167         (-[DOMTimeRanges start:]): Updated exception handling.
2168         (-[DOMTimeRanges end:]): Ditto.
2169
2170 2016-10-27  Chris Dumez  <cdumez@apple.com>
2171
2172         Regression(r203601): Caused crashes in iBooks
2173         https://bugs.webkit.org/show_bug.cgi?id=164093
2174         <rdar://problem/28745634>
2175
2176         Reviewed by Darin Adler.
2177
2178         Restore pre-r203601 behavior when calling [DOMNode compareDocumentPosition:nil],
2179         which was to return Node::DOCUMENT_POSITION_DISCONNECTED.
2180
2181         * DOM/DOMNode.mm:
2182         (-[DOMNode compareDocumentPosition:]):
2183
2184 2016-10-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2185
2186         Support "insertFromDrop" and "deleteByDrag" for the InputEvent spec
2187         https://bugs.webkit.org/show_bug.cgi?id=163948
2188         <rdar://problem/28921433>
2189
2190         Reviewed by Darin Adler.
2191
2192         Add support for new drag and drop-related EditAction enum values.
2193
2194         * WebCoreSupport/WebEditorClient.mm:
2195         (undoNameForEditAction):
2196
2197 2016-10-27  Dan Bernstein  <mitz@apple.com>
2198
2199         Reapplied the configuration changes from r207934 without breaking iOS builds.
2200
2201         * Configurations/Base.xcconfig:
2202         * Configurations/WebKitLegacy.xcconfig:
2203
2204 2016-10-27  Dan Bernstein  <mitz@apple.com>
2205
2206         Reverted the configuration changes from r207934 because they broke iOS builds not using the Apple-internal SDK.
2207
2208         * Configurations/Base.xcconfig:
2209         * Configurations/WebKitLegacy.xcconfig:
2210
2211 2016-10-26  Dan Bernstein  <mitz@apple.com>
2212
2213         [Xcode] WebKit fails to build when CLANG_WARN_DOCUMENTATION_COMMENTS is enabled
2214         https://bugs.webkit.org/show_bug.cgi?id=164048
2215
2216         Reviewed by Tim Horton.
2217
2218         * Configurations/Base.xcconfig: Enabled CLANG_WARN_DOCUMENTATION_COMMENTS.
2219         * Configurations/WebKitLegacy.xcconfig: Made the compiler treat the icu headers as system
2220           headers.
2221
2222         * History/WebBackForwardList.h: Fixed parameter name in @param entry.
2223         * Misc/WebDownload.h: Removed empty entries.
2224         * Misc/WebIconDatabase.h: Remove incorrect @param entries.
2225         * Misc/WebQuotaManager.h: Added missing parameter names in @param entries.
2226         * WebView/WebFrameLoadDelegate.h: Corrected parameter names in @param entries.
2227         * WebView/WebFrameViewPrivate.h: Changed incorrect @result to @abstract.
2228         * WebView/WebPolicyDelegate.h: Fixed parameter name and removed incorrect @param entries.
2229         * WebView/WebPreferences.h: Changed @method to @property in a couple of places.
2230         * WebView/WebResourceLoadDelegate.h: Fixed parameter names.
2231         * WebView/WebUIDelegate.h: Filled in two empty @param entries. Added missing parameter name,
2232           Fixed a typo and removed empty @discussion entry. Fixed some parameter names.
2233         * WebView/WebUIDelegatePrivate.h: Fixed parameter names.
2234         * WebView/WebView.h: Changed @method to @property in a couple of places.
2235         * WebView/WebViewPrivate.h: Fixed parameter names, changed incorrect @result to @abstract.
2236
2237 2016-10-26  Brian Burg  <bburg@apple.com>
2238
2239         Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
2240         https://bugs.webkit.org/show_bug.cgi?id=164046
2241
2242         Reviewed by Joseph Pecoraro.
2243
2244         * WebCoreSupport/WebInspectorClient.h:
2245
2246 2016-10-21  Alex Christensen  <achristensen@webkit.org>
2247
2248         URL::port should return Optional<uint16_t>
2249         https://bugs.webkit.org/show_bug.cgi?id=163806
2250
2251         Reviewed by Darin Adler.
2252
2253         * WebCoreSupport/WebSecurityOrigin.mm:
2254         (-[WebSecurityOrigin port]):
2255
2256 2016-10-24  Dave Hyatt  <hyatt@apple.com>
2257
2258         Remove CSSCharsetRule from the CSS OM
2259         https://bugs.webkit.org/show_bug.cgi?id=163891
2260
2261         Reviewed by Darin Adler.
2262
2263         * DOM/DOMCSSCharsetRule.mm:
2264         (-[DOMCSSCharsetRule encoding]):
2265
2266 2016-10-24  Youenn Fablet  <youenn@apple.com>
2267
2268         Activate WEB_RTC compilation flags for Mac bots
2269         https://bugs.webkit.org/show_bug.cgi?id=163886
2270
2271         Reviewed by Eric Carlson.
2272
2273         * Configurations/FeatureDefines.xcconfig:
2274
2275 2016-10-23  Chris Dumez  <cdumez@apple.com>
2276
2277         addEventListener() / removeEventListener() should use a union for last parameter
2278         https://bugs.webkit.org/show_bug.cgi?id=163863
2279
2280         Reviewed by Darin Adler.
2281
2282         Cast BOOL to bool to help to compiler construct the new variant-type parameter.
2283
2284         * DOM/DOMNode.mm:
2285         (-[DOMNode addEventListener:listener:useCapture:]):
2286         (-[DOMNode addEventListener:::]):
2287         (-[DOMNode removeEventListener:listener:useCapture:]):
2288         (-[DOMNode removeEventListener:::]):
2289
2290 2016-10-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2291
2292         Support (insertFrom|deleteBy)Composition and (insert|delete)CompositionText inputTypes for InputEvents
2293         https://bugs.webkit.org/show_bug.cgi?id=163460
2294         <rdar://problem/28784142>
2295
2296         Reviewed by Darin Adler.
2297
2298         Handle new EditAction types for inserting/deleting pending/final compositions.
2299
2300         * WebCoreSupport/WebEditorClient.mm:
2301         (undoNameForEditAction):
2302
2303 2016-10-21  Jeremy Jones  <jeremyj@apple.com>
2304
2305         Implement basic pointer lock behavior for WebKit and WebKit2.
2306         https://bugs.webkit.org/show_bug.cgi?id=162745
2307
2308         Reviewed by Simon Fraser.
2309
2310         Add basic pointer lock functionality. User permission is not yet implemented.
2311
2312         * WebCoreSupport/WebChromeClient.h:
2313         * WebCoreSupport/WebChromeClient.mm:
2314         (WebChromeClient::requestPointerLock):
2315         (WebChromeClient::requestPointerUnlock):
2316
2317 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
2318
2319         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
2320         https://bugs.webkit.org/show_bug.cgi?id=163374
2321
2322         Reviewed by Darin Adler.
2323
2324         * Configurations/FeatureDefines.xcconfig:
2325
2326 2016-10-19  Alex Christensen  <achristensen@webkit.org>
2327
2328         Revert r207151
2329         https://bugs.webkit.org/show_bug.cgi?id=163675
2330
2331         Reviewed by Brent Fulgham.
2332
2333         * Misc/WebDownload.mm:
2334         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):
2335         * Misc/WebDownloadInternal.h:
2336         * WebCoreSupport/WebFrameLoaderClient.mm:
2337         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2338         * WebView/WebPreferences.mm:
2339         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
2340         * WebView/WebView.mm:
2341         (-[WebView scheduleInRunLoop:forMode:]):
2342         (-[WebView unscheduleFromRunLoop:forMode:]):
2343
2344 2016-10-19  Ryan Haddad  <ryanhaddad@apple.com>
2345
2346         Unreviewed, rolling out r207557.
2347
2348         This change caused animations/font-variations tests to time
2349         out on pre-Sierra Macs.
2350
2351         Reverted changeset:
2352
2353         "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
2354         iOS 9"
2355         https://bugs.webkit.org/show_bug.cgi?id=163374
2356         http://trac.webkit.org/changeset/207557
2357
2358 2016-10-19  Chris Dumez  <cdumez@apple.com>
2359
2360         Move HTML Interactive Form Validation behind an experimental flag
2361         https://bugs.webkit.org/show_bug.cgi?id=163673
2362
2363         Reviewed by Daniel Bates.
2364
2365         Re-disable HTML Interactive Form Validation by default on Mac WK1.
2366
2367         * WebView/WebViewData.mm:
2368         (-[WebViewPrivate init]):
2369
2370 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
2371
2372         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
2373         https://bugs.webkit.org/show_bug.cgi?id=163374
2374
2375         Reviewed by Darin Adler.
2376
2377         * Configurations/FeatureDefines.xcconfig:
2378
2379 2016-10-19  Simon Fraser  <simon.fraser@apple.com>
2380
2381         WebView needs to initialize the visualViewportEnabled Setting from WebKit preferences
2382         https://bugs.webkit.org/show_bug.cgi?id=163680
2383
2384         Reviewed by Dean Jackson.
2385
2386         Add code to set the Setting from WebKit prefs. This code is a mess and needs to be autogenerated.
2387
2388         * WebView/WebView.mm:
2389         (-[WebView _preferencesChanged:]):
2390
2391 2016-10-19  Darin Adler  <darin@apple.com>
2392
2393         Move XPath from ExceptionCode to Exception
2394         https://bugs.webkit.org/show_bug.cgi?id=163656
2395
2396         Reviewed by Chris Dumez.
2397
2398         * DOM/DOMDocument.mm:
2399         (wrap): Added. Helper function for wrapping a resolver.
2400         (-[DOMDocument createExpression:resolver:]): Use raiseOnDOMError.
2401         (-[DOMDocument evaluate:contextNode:resolver:type:inResult:]): Ditto.
2402         * DOM/DOMXPathExpression.mm:
2403         (-[DOMXPathExpression evaluate:type:inResult:]): Ditto.
2404         * DOM/DOMXPathResult.mm:
2405         (-[DOMXPathResult numberValue]): Ditto.
2406         (-[DOMXPathResult stringValue]): Ditto.
2407         (-[DOMXPathResult booleanValue]): Ditto.
2408         (-[DOMXPathResult singleNodeValue]): Ditto.
2409         (-[DOMXPathResult snapshotLength]): Ditto.
2410         (-[DOMXPathResult iterateNext]): Ditto.
2411         (-[DOMXPathResult snapshotItem:]): Ditto.
2412
2413 2016-10-18  Sam Weinig  <sam@webkit.org>
2414
2415         Replace std::experimental::variant with WTF::Variant (or similar)
2416         https://bugs.webkit.org/show_bug.cgi?id=163626
2417
2418         Reviewed by Chris Dumez.
2419
2420         Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
2421         into the WTF namespace.
2422
2423         * DOM/DOMHTMLSelectElement.mm:
2424         (-[DOMHTMLSelectElement add:before:]):
2425
2426 2016-10-18  Simon Fraser  <simon.fraser@apple.com>
2427
2428         Add a MiniBrowser menu item to apply page scale in WK1 and WK2
2429         https://bugs.webkit.org/show_bug.cgi?id=163627
2430
2431         Reviewed by Dean Jackson.
2432
2433         Add an explanatory comment about viewScaleFactor not really being viewScaleFactor.
2434
2435         * WebView/WebViewPrivate.h:
2436
2437 2016-10-18  Dean Jackson  <dino@apple.com>
2438
2439         Remove CSS_SHAPES feature definition. This should always be on.
2440         https://bugs.webkit.org/show_bug.cgi?id=163628
2441         <rdar://problem/28834613>
2442
2443         Reviewed by Tim Horton.
2444
2445         * Configurations/FeatureDefines.xcconfig:
2446
2447 2016-10-18  Chris Dumez  <cdumez@apple.com>
2448
2449         Leverage new union type support for HTMLSelectElement.add() / HTMLOptionsCollection.add()
2450         https://bugs.webkit.org/show_bug.cgi?id=163608
2451
2452         Reviewed by Ryosuke Niwa.
2453
2454         Update add() call sites now that it takes std::variant types in.
2455
2456         * DOM/DOMHTMLOptionsCollection.mm:
2457         (-[DOMHTMLOptionsCollection add:index:]):
2458         * DOM/DOMHTMLSelectElement.mm:
2459         (-[DOMHTMLSelectElement add:before:]):
2460
2461 2016-10-18  Anders Carlsson  <andersca@apple.com>
2462
2463         Get rid of more WebHistoryItem cruft
2464         https://bugs.webkit.org/show_bug.cgi?id=163623
2465
2466         Reviewed by Tim Horton.
2467
2468         * History/WebHistoryItem.mm:
2469         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2470         * History/WebHistoryItemPrivate.h:
2471
2472 2016-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2473
2474         Showing and hiding candidates list is very distracting after selecting word
2475         https://bugs.webkit.org/show_bug.cgi?id=163609
2476         <rdar://problem/28747712>
2477
2478         Reviewed by Tim Horton.
2479
2480         Introduce WebView hooks for mousedown and mouseup. See radar for more details.
2481
2482         * WebView/WebHTMLView.mm:
2483         (-[WebHTMLView mouseDown:mouseDown:]):
2484         (-[WebHTMLView mouseUp:mouseUp:]):
2485         * WebView/WebView.mm:
2486         (-[WebView prepareForMouseDown]):
2487         (-[WebView prepareForMouseUp]):
2488         * WebView/WebViewInternal.h:
2489
2490 2016-10-17  Anders Carlsson  <andersca@apple.com>
2491
2492         Move some history specific HistoryItem code to WebHistoryItem
2493         https://bugs.webkit.org/show_bug.cgi?id=163567
2494
2495         Reviewed by Tim Horton.
2496
2497         * History/HistoryPropertyList.mm:
2498         (HistoryPropertyListWriter::writeHistoryItem):
2499         * History/WebHistory.mm:
2500         (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
2501         * History/WebHistoryItem.mm:
2502         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2503         * History/WebHistoryItemInternal.h:
2504         * WebCoreSupport/WebFrameLoaderClient.mm:
2505         (addRedirectURL):
2506         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
2507
2508 2016-10-18  Eric Carlson  <eric.carlson@apple.com>
2509
2510         [MediaStream] Resolve constraints and enumerate devices in the UI process
2511         https://bugs.webkit.org/show_bug.cgi?id=162147
2512         <rdar://problem/28803569>
2513
2514         Reviewed by Darin Adler.
2515
2516         * WebCoreSupport/WebUserMediaClient.h:
2517         * WebCoreSupport/WebUserMediaClient.mm:
2518         (AddPermissionCheckToMap):
2519         (RemovePermissionCheckFromMap):
2520         (WebUserMediaClient::pageDestroyed):
2521         (WebUserMediaClient::requestUserMediaAccess):
2522         (WebUserMediaClient::enumerateMediaDevices):
2523         (WebUserMediaClient::cancelMediaDevicesEnumerationRequest):
2524         (-[WebUserMediaPolicyListener allow]):
2525         (-[WebUserMediaPolicyListener deny]):
2526         (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
2527         (-[WebUserMediaPolicyCheckerListener cancelMediaDevicesEnumerationRequest]):
2528         (-[WebUserMediaPolicyCheckerListener allow]):
2529         (-[WebUserMediaPolicyCheckerListener deny]):
2530         (WebUserMediaClient::checkUserMediaPermission): Deleted.
2531         (WebUserMediaClient::cancelUserMediaPermissionCheck): Deleted.
2532         (-[WebUserMediaPolicyCheckerListener initWithUserMediaPermissionCheck:]): Deleted.
2533         (-[WebUserMediaPolicyCheckerListener cancelUserMediaPermissionCheck]): Deleted.
2534
2535 2016-10-17  Antti Koivisto  <antti@apple.com>
2536
2537         Rename setNeedsStyleRecalc to invalidateStyle
2538         https://bugs.webkit.org/show_bug.cgi?id=163542
2539
2540         Reviewed by Darin Adler.
2541
2542         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2543         (-[WebHostedNetscapePluginView createPluginLayer]):
2544         * Plugins/WebNetscapePluginView.mm:
2545         (-[WebNetscapePluginView createPlugin]):
2546
2547 2016-10-17  Jeremy Jones  <jeremyj@apple.com>
2548
2549         Enable keyboard in fullscreen.
2550         https://bugs.webkit.org/show_bug.cgi?id=163146
2551
2552         Reviewed by Jer Noble.
2553
2554         Allow keyboard in fullscreen.
2555
2556         * WebView/WebView.mm:
2557         (-[WebView _supportsFullScreenForElement:withKeyboard:]):
2558
2559 2016-10-17  Chris Dumez  <cdumez@apple.com>
2560
2561         Move form.reportValidity() behind InteractiveFormValidation setting
2562         https://bugs.webkit.org/show_bug.cgi?id=163550
2563
2564         Reviewed by Darin Adler.
2565
2566         Enable InteractiveFormValidation setting by default and link it to
2567         RuntimeEnabledFeatures so we can use it in the IDL.
2568
2569         * WebView/WebView.mm:
2570         (-[WebView _preferencesChanged:]):
2571         * WebView/WebViewData.mm:
2572         (-[WebViewPrivate init]):
2573
2574 2016-10-17  Anders Carlsson  <andersca@apple.com>
2575
2576         Fix iOS build.
2577
2578         * History/WebBackForwardList.mm:
2579         (-[WebBackForwardList dictionaryRepresentation]):
2580
2581 2016-10-17  Anders Carlsson  <andersca@apple.com>
2582
2583         CTTE some of the BackForwardList member functions
2584         https://bugs.webkit.org/show_bug.cgi?id=163555
2585
2586         Reviewed by Dan Bernstein.
2587
2588         * History/BackForwardList.h:
2589         (BackForwardList::entries):
2590         * History/BackForwardList.mm:
2591         (BackForwardList::removeItem):
2592         (BackForwardList::containsItem):
2593         (BackForwardList::entries): Deleted.
2594         * History/WebBackForwardList.mm:
2595         (-[WebBackForwardList removeItem:]):
2596         (-[WebBackForwardList containsItem:]):
2597         (-[WebBackForwardList description]):
2598
2599 2016-10-17  Anders Carlsson  <andersca@apple.com>
2600
2601         Remove WEBCORE_EXPORT from BackForwardList, it lives in WebKit now
2602         https://bugs.webkit.org/show_bug.cgi?id=163551
2603
2604         Reviewed by Tim Horton.
2605
2606         * History/BackForwardList.h:
2607
2608 2016-10-16  Darin Adler  <darin@apple.com>
2609
2610         Move CSS classes from ExceptionCode to Exception
2611         https://bugs.webkit.org/show_bug.cgi?id=163494
2612
2613         Reviewed by Sam Weinig.
2614
2615         * DOM/DOMCSSMediaRule.mm:
2616         (-[DOMCSSMediaRule insertRule:index:]): Use raiseOnDOMError
2617         the new way to handle ExceptionOr instead of ExceptionCode.
2618         (-[DOMCSSMediaRule deleteRule:]): Ditto.
2619         * DOM/DOMCSSPrimitiveValue.mm:
2620         (-[DOMCSSPrimitiveValue setFloatValue:floatValue:]): Ditto.
2621         (-[DOMCSSPrimitiveValue getFloatValue:]): Ditto.
2622         (-[DOMCSSPrimitiveValue setStringValue:stringValue:]): Ditto.
2623         (-[DOMCSSPrimitiveValue getStringValue]): Ditto.
2624         (-[DOMCSSPrimitiveValue getCounterValue]): Ditto.
2625         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
2626         (-[DOMCSSPrimitiveValue getRGBColorValue]): Ditto.
2627         * DOM/DOMCSSRule.mm:
2628         (-[DOMCSSRule setCssText:]): Ditto.
2629         * DOM/DOMCSSStyleDeclaration.mm:
2630         (-[DOMCSSStyleDeclaration setCssText:]): Ditto.
2631         (-[DOMCSSStyleDeclaration removeProperty:]): Ditto.
2632         (-[DOMCSSStyleDeclaration setProperty:value:priority:]): Ditto.
2633         * DOM/DOMCSSStyleSheet.mm:
2634         (-[DOMCSSStyleSheet insertRule:index:]): Ditto.
2635         (-[DOMCSSStyleSheet deleteRule:]): Ditto.
2636         (-[DOMCSSStyleSheet addRule:style:index:]): Ditto.
2637         (-[DOMCSSStyleSheet removeRule:]): Ditto.
2638         * DOM/DOMCSSValue.mm:
2639         (-[DOMCSSValue setCssText:]): Ditto.
2640         * DOM/DOMMediaList.mm:
2641         (-[DOMMediaList setMediaText:]): Ditto.
2642         (-[DOMMediaList deleteMedium:]): Ditto.
2643         (-[DOMMediaList appendMedium:]): Ditto.
2644
2645         * DOM/ExceptionHandlers.h: Added an overload of raiseDOMException
2646         that works with a WebCore::Exception&& and overloads of
2647         raiseOnDOMError that work with WebCore::ExceptionOr&&.
2648         * DOM/ExceptionHandlers.mm:
2649         (raiseDOMException): Implemented the new version.
2650
2651 2016-10-15  Dan Bernstein  <mitz@apple.com>
2652
2653         REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
2654         https://bugs.webkit.org/show_bug.cgi?id=163492
2655         <rdar://problem/28654799>
2656
2657         Reviewed by Darin Adler.
2658
2659         Test: TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm
2660
2661         * WebView/WebHTMLView.mm:
2662         (createMenuItem): Set the tag for items that have submenus as well.
2663
2664 2016-10-14  Anders Carlsson  <andersca@apple.com>
2665
2666         Clean up BackForwardClient
2667         https://bugs.webkit.org/show_bug.cgi?id=163454
2668
2669         Reviewed by Sam Weinig.
2670
2671         * History/BackForwardList.h:
2672         Remove override keywords.
2673
2674         * History/BackForwardList.mm:
2675         (BackForwardList::clearAllPageCaches): Deleted.
2676         Remove this, it's no longer used.
2677
2678         * WebView/WebView.mm:
2679         (-[WebView _clearBackForwardCache]): Deleted.
2680         * WebView/WebViewPrivate.h:
2681         Remove SPI that's no longer used by anyone.
2682
2683 2016-10-13  Anders Carlsson  <andersca@apple.com>
2684
2685         Move BackForwardList from WebCore to WebKitLegacy
2686         https://bugs.webkit.org/show_bug.cgi?id=163418
2687
2688         Reviewed by Tim Horton.
2689
2690         * History/BackForwardList.h: Renamed from Source/WebCore/history/BackForwardList.h.
2691         (BackForwardList::create):
2692         (BackForwardList::webView):
2693         * History/BackForwardList.mm: Renamed from Source/WebCore/history/BackForwardList.cpp.
2694         (BackForwardList::BackForwardList):
2695         (BackForwardList::close):
2696         (BackForwardList::containsItem):
2697         * History/WebBackForwardList.mm:
2698         (kit):
2699         (-[WebBackForwardList initWithBackForwardList:]):
2700         (-[WebBackForwardList setPageCacheSize:]):
2701         (-[WebBackForwardList pageCacheSize]):
2702         * History/WebBackForwardListInternal.h:
2703         * WebCoreSupport/WebFrameLoaderClient.mm:
2704         * WebView/WebFrameView.mm:
2705         * WebView/WebView.mm:
2706         (-[WebView _commonInitializationWithFrameName:groupName:]):
2707         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2708
2709 2016-10-13  Anders Carlsson  <andersca@apple.com>
2710
2711         Get rid of the HistoryItemVector typedef
2712         https://bugs.webkit.org/show_bug.cgi?id=163398
2713
2714         Reviewed by Beth Dakin.
2715
2716         Expand the HistoryitemVector typedef instead to make it more clear what types we are dealing with.
2717
2718         * History/WebBackForwardList.mm:
2719         (-[WebBackForwardList dictionaryRepresentation]):
2720         (vectorToNSArray):
2721         (-[WebBackForwardList backListWithLimit:]):
2722         (-[WebBackForwardList forwardListWithLimit:]):
2723         (-[WebBackForwardList description]):
2724         * History/WebHistoryItem.mm:
2725         (-[WebHistoryItem description]):
2726
2727 2016-10-12  Chris Dumez  <cdumez@apple.com>
2728
2729         [Web IDL] Drop support for legacy [ConstructorConditional=*]
2730         https://bugs.webkit.org/show_bug.cgi?id=163368
2731
2732         Reviewed by Ryosuke Niwa.
2733
2734         Drop ENABLE_DOM4_EVENTS_CONSTRUCTOR compiler flag.
2735
2736         * Configurations/FeatureDefines.xcconfig:
2737
2738 2016-10-12  Beth Dakin  <bdakin@apple.com>
2739
2740         Adobe Contribute CS 6.5 Trial crashes on launch
2741         https://bugs.webkit.org/show_bug.cgi?id=163365
2742         -and corresponding-
2743         <rdar://problem/28732731>
2744
2745         Reviewed by Tim Horton.
2746
2747         * Carbon/CarbonWindowFrame.m:
2748         (-[CarbonWindowFrame contentFill]):
2749
2750 2016-10-11  Daniel Bates  <dabates@apple.com>
2751
2752         Attempt to fix the Apple Internal Mac build following r207159
2753         (https://bugs.webkit.org/show_bug.cgi?id=163244)
2754
2755         * WebView/WebView.mm:
2756         (shouldRequireUserGestureToLoadVideo):
2757
2758 2016-10-11  Daniel Bates  <dabates@apple.com>
2759
2760         REGRESSION (r198251): -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO
2761         https://bugs.webkit.org/show_bug.cgi?id=163259
2762         <rdar://problem/28680515>
2763
2764         Reviewed by Jer Noble.
2765
2766         In WebKit1 on iOS we want to require user action to load and play videos by default and
2767         allow an embedding app to change this behavior via -[UIWebView setMediaPlaybackRequiresUserAction:].
2768         Following r198251, -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO and videos
2769         can load and play without being initiated by a user action.
2770
2771         * WebView/WebPreferences.mm:
2772         (+[WebPreferences initialize]): Initialize the default value of the deprecated preference
2773         WebKitRequiresUserGestureForMediaPlaybackPreferenceKey to YES on iOS. The value of this
2774         preference takes precedence over the values of its replacement preferences
2775         WebKitRequiresUserGestureForVideoPlaybackPreferenceKey and WebKitRequiresUserGestureForAudioPlaybackPreferenceKey.
2776
2777 2016-10-11  Daniel Bates  <dabates@apple.com>
2778
2779         [iOS] REGRESSION (r197953): User gesture required to load video in iOS 9-built apps
2780         https://bugs.webkit.org/show_bug.cgi?id=163244
2781         <rdar://problem/27250015>
2782
2783         Reviewed by Jer Noble.
2784
2785         Enable or disable the Setting::requiresUserGestureToLoadVideo() in legacy WebKit depending
2786         on the version of iOS SDK that the app was linked against. We require a user gesture to
2787         begin loading a video as of iOS 10.
2788
2789         * WebView/WebView.mm:
2790         (shouldRequireUserGestureToLoadVideo):
2791         (-[WebView _preferencesChanged:]): Modified to pass the WebKit requiresUserGestureToLoadVideo
2792         preference to WebCore.
2793
2794 2016-10-11  Alex Christensen  <achristensen@webkit.org>
2795
2796         Remove dead networking code
2797         https://bugs.webkit.org/show_bug.cgi?id=163263
2798
2799         Reviewed by Daniel Bates.
2800
2801         * Misc/WebDownload.mm:
2802         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
2803         * Misc/WebDownloadInternal.h:
2804         * WebCoreSupport/WebFrameLoaderClient.mm:
2805         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2806         * WebView/WebPreferences.mm:
2807         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
2808         * WebView/WebView.mm:
2809         (-[WebView scheduleInRunLoop:forMode:]):
2810         (-[WebView unscheduleFromRunLoop:forMode:]):
2811
2812 2016-10-10  Zan Dobersek  <zdobersek@igalia.com>
2813
2814         Add ENABLE_ENCRYPTED_MEDIA configuration option
2815         https://bugs.webkit.org/show_bug.cgi?id=163219
2816
2817         Reviewed by Darin Adler.
2818
2819         * Configurations/FeatureDefines.xcconfig:
2820         Add the ENABLE_ENCRYPTED_MEDIA configuration option. It will be used
2821         to enable or disable the new EME implementation at build-time.
2822
2823 2016-10-10  Darin Adler  <darin@apple.com>
2824
2825         Move NotificationCenter from legacy to new DOM exceptions
2826         https://bugs.webkit.org/show_bug.cgi?id=163217
2827
2828         Reviewed by Chris Dumez.
2829
2830         * WebView/WebView.mm:
2831         (-[WebView _notificationIDForTesting:]): Pass reference to page rather than pointer.
2832
2833 2016-10-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2834
2835         Support InputEvent.inputType for the new InputEvent spec
2836         https://bugs.webkit.org/show_bug.cgi?id=163025
2837         <rdar://problem/28658092>
2838
2839         Reviewed by Darin Adler.
2840
2841         Accounts for some changes to the EditAction enum in nameForEditAction. See WebCore ChangeLog
2842         entry for more details.
2843
2844         * WebCoreSupport/WebEditorClient.mm:
2845         (undoNameForEditAction):
2846
2847 2016-10-06  Darin Adler  <darin@apple.com>
2848
2849         Next step on moving to modern way to return DOM exceptions
2850         https://bugs.webkit.org/show_bug.cgi?id=163016
2851
2852         Reviewed by Ryosuke Niwa.
2853
2854         * DOM/DOMDOMImplementation.mm:
2855         (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated for
2856         name change from takeReturnValue to releaseReturnValue.
2857         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
2858
2859 2016-10-07  Simon Fraser  <simon.fraser@apple.com>
2860
2861         [WK1 Mac] Fix repaints of fixed-background elements in layer-backed WebViews
2862         https://bugs.webkit.org/show_bug.cgi?id=163154
2863         rdar://problem/28674216
2864
2865         Reviewed by Tim Horton.
2866         
2867         r55159 added code to counteract AppKit's adjustment of dirty regions during scrolling,
2868         by offsetting the dirty rect in -setNeedsDisplayInRect: if the call happens during
2869         the NSViewBoundsDidChangeNotification handling.
2870         
2871         However, AppKit only does dirty region adjustment in the code path that blits ("copy
2872         on scroll"), so r55159 produces incorrect behavior in, for example, layer-backed views.
2873         
2874         Fix by overriding -[NSClipView _canCopyOnScrollForDeltaX:deltaY:] to know if a single
2875         scroll is going to blit, and only do adjustments in -setNeedsDisplayInRect: if it is.
2876
2877         * WebView/WebClipView.h:
2878         * WebView/WebClipView.mm:
2879         (-[WebClipView _immediateScrollToPoint:]):
2880         (-[WebClipView _canCopyOnScrollForDeltaX:deltaY:]):
2881         (-[WebClipView currentScrollIsBlit]):
2882         * WebView/WebHTMLView.mm:
2883         (-[WebHTMLView setNeedsDisplayInRect:]):
2884         (-[WebHTMLView drawRect:]):
2885
2886 2016-10-06  Youenn Fablet  <youenn@apple.com>
2887
2888         CachedResource client handling methods should take reference
2889         https://bugs.webkit.org/show_bug.cgi?id=163014
2890
2891         Reviewed by Alex Christensen.
2892
2893         * WebView/WebHTMLView.mm:
2894         (promisedDataClient):
2895
2896 2016-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
2897
2898         Put variation fonts work behind a compile-time flag
2899         https://bugs.webkit.org/show_bug.cgi?id=162949
2900
2901         Reviewed by Simon Fraser.
2902
2903         * Configurations/FeatureDefines.xcconfig:
2904
2905 2016-10-05  Zan Dobersek  <zdobersek@igalia.com>
2906
2907         Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
2908         https://bugs.webkit.org/show_bug.cgi?id=162903
2909
2910         Reviewed by Alex Christensen.
2911
2912         Rename build guards for the remaining implementation of the legacy EME API
2913         to ENABLE_LEGACY_ENCRYPTED_MEDIA. This will allow for the future implementation
2914         of the near-finished API to be guarded with the simple ENABLE_ENCRYPTED_MEDIA guards.
2915
2916         * Configurations/FeatureDefines.xcconfig:
2917         * WebView/WebPreferences.mm:
2918         (+[WebPreferences initialize]):
2919         * WebView/WebView.mm:
2920         (-[WebView _preferencesChanged:]):
2921
2922 2016-10-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
2923
2924         The dragged image should be the current frame only of the animated image
2925         https://bugs.webkit.org/show_bug.cgi?id=162109
2926
2927         Reviewed by Tim Horton.
2928
2929         * DOM/DOM.mm:
2930         (-[DOMElement image]): Call the Image function with its new name.
2931         (-[DOMElement _imageTIFFRepresentation]): Ditto.
2932         * Misc/WebElementDictionary.mm:
2933         (-[WebElementDictionary _image]): Call the Image function with its new name.
2934         * Misc/WebIconDatabase.mm:
2935         (-[WebIconDatabase defaultIconWithSize:]): Call snapshotNSImage() to create the icon image.
2936         (webGetNSImage): Call the Image function with its new name.
2937         * WebCoreSupport/WebContextMenuClient.mm:
2938         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call snapshotNSImage() instead of nsImage()..
2939         (WebContextMenuClient::contextMenuForEvent): Ditto.
2940         * WebView/WebHTMLView.mm:
2941         (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
2942
2943 2016-10-02  Ryan Haddad  <ryanhaddad@apple.com>
2944
2945         Unreviewed, rolling out r206683.
2946
2947         This change caused API test WebKit2.FindMatches to fail on
2948         Mac.
2949
2950         Reverted changeset:
2951
2952         "The dragged image should be the current frame only of the
2953         animated image"
2954         https://bugs.webkit.org/show_bug.cgi?id=162109
2955         http://trac.webkit.org/changeset/206683
2956
2957 2016-09-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
2958
2959         The dragged image should be the current frame only of the animated image
2960         https://bugs.webkit.org/show_bug.cgi?id=162109
2961
2962         Reviewed by Tim Horton.
2963
2964         * DOM/DOM.mm:
2965         (-[DOMElement image]): Call the Image function with its new name.
2966         (-[DOMElement _imageTIFFRepresentation]): Ditto.
2967         * Misc/WebElementDictionary.mm:
2968         (-[WebElementDictionary _image]): Call the Image function with its new name.
2969         * Misc/WebIconDatabase.mm:
2970         (-[WebIconDatabase defaultIconWithSize:]): Call currentFrameNSImage() to create the icon image.
2971         (webGetNSImage): Call the Image function with its new name.
2972         * WebCoreSupport/WebContextMenuClient.mm:
2973         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call currentFrameNSImage() instead of nsImage()..
2974         (WebContextMenuClient::contextMenuForEvent): Ditto.
2975         * WebView/WebHTMLView.mm:
2976         (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
2977
2978 2016-09-27  Jer Noble  <jer.noble@apple.com>
2979
2980         Remove deprecated ENCRYPTED_MEDIA implementation.
2981         https://bugs.webkit.org/show_bug.cgi?id=161010
2982
2983         Remove ENABLE_ENCRYPTED_MEDIA.
2984
2985         Reviewed by Eric Carlson.
2986
2987         * Configurations/FeatureDefines.xcconfig:
2988
2989 2016-09-26  Daniel Bates  <dabates@apple.com>
2990
2991         Rename IOS_TEXT_AUTOSIZING to TEXT_AUTOSIZING
2992         https://bugs.webkit.org/show_bug.cgi?id=162365
2993
2994         Reviewed by Simon Fraser.
2995
2996         * Configurations/FeatureDefines.xcconfig:
2997         * WebView/WebFrame.mm:
2998         * WebView/WebPreferences.mm:
2999         (+[WebPreferences initialize]):
3000         * WebView/WebView.mm:
3001         (-[WebView _preferencesChanged:]):
3002
3003 2016-09-25  Antti Koivisto  <antti@apple.com>
3004
3005         AuthorStyleSheets shouldn't trigger synchronous style resolutions
3006         https://bugs.webkit.org/show_bug.cgi?id=162532
3007
3008         Reviewed by Darin Adler.
3009
3010         * WebView/WebHTMLView.mm:
3011         (-[WebHTMLView reapplyStyles]):
3012         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
3013
3014 2016-09-24  Antti Koivisto  <antti@apple.com>
3015
3016         Move stylesheet change logic from Document to AuthorStyleSheets
3017         https://bugs.webkit.org/show_bug.cgi?id=162488
3018
3019         Reviewed by Andreas Kling.
3020
3021         * WebView/WebHTMLView.mm:
3022         (-[WebHTMLView reapplyStyles]):
3023         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
3024
3025 2016-09-23  Caitlin Potter  <caitp@igalia.com>
3026
3027         [JSC] Implement parsing of Async Functions
3028         https://bugs.webkit.org/show_bug.cgi?id=161409
3029
3030         Reviewed by Yusuke Suzuki.
3031
3032         * Configurations/FeatureDefines.xcconfig:
3033
3034 2016-09-23  Commit Queue  <commit-queue@webkit.org>
3035
3036         Unreviewed, rolling out r206311.
3037         https://bugs.webkit.org/show_bug.cgi?id=162495
3038
3039         Broke internal iOS build (Requested by anttik on #webkit).
3040
3041         Reverted changeset:
3042
3043         "Move stylesheet change logic from Document to
3044         AuthorStyleSheets"
3045         https://bugs.webkit.org/show_bug.cgi?id=162488
3046         http://trac.webkit.org/changeset/206311
3047
3048 2016-09-23  Antoine Quint  <graouts@apple.com>
3049
3050         Add a new runtime flag for work on modern media controls (off by default)
3051         https://bugs.webkit.org/show_bug.cgi?id=162420
3052         <rdar://problem/27989489>
3053
3054         Reviewed by Eric Carlson.
3055
3056         * WebView/WebPreferenceKeysPrivate.h:
3057         * WebView/WebPreferences.mm:
3058         (-[WebPreferences modernMediaControlsEnabled]):
3059         (-[WebPreferences setModernMediaControlsEnabled:]):
3060         * WebView/WebPreferencesPrivate.h:
3061         * WebView/WebView.mm:
3062         (-[WebView _preferencesChanged:]):
3063
3064 2016-09-21  Anders Carlsson  <andersca@apple.com>
3065
3066         Support openPaymentSetup API on ApplePaySession object
3067         https://bugs.webkit.org/show_bug.cgi?id=162357
3068         rdar://problem/26776939
3069
3070         Reviewed by Tim Horton.
3071
3072         Add openPaymentSetup stub.
3073
3074         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3075         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3076         (WebPaymentCoordinatorClient::openPaymentSetup):
3077
3078 2016-09-19  Daniel Bates  <dabates@apple.com>
3079
3080         Remove ENABLE(TEXT_AUTOSIZING) automatic text size adjustment code
3081         https://bugs.webkit.org/show_bug.cgi?id=162167
3082
3083         Reviewed by Simon Fraser.
3084
3085         * Configurations/FeatureDefines.xcconfig:
3086
3087 2016-09-19  Joseph Pecoraro  <pecoraro@apple.com>
3088
3089         Web Inspector: Bring the inspected page's window forward when activating element search
3090         https://bugs.webkit.org/show_bug.cgi?id=162114
3091         <rdar://problem/28349357>
3092
3093         Reviewed by Brian Burg.
3094
3095         * WebCoreSupport/WebInspectorClient.mm:
3096         (WebInspectorClient::didSetSearchingForNode):
3097         When element search is activated bring the window
3098         containing the inspected page to the foreground.
3099
3100 2016-09-15  Brady Eidson  <beidson@apple.com>
3101
3102         WKWebView.hasOnlySecureContent always returns "YES" after going back to a CachedPage (even if it has http resources).
3103         <rdar://problem/27681261> and https://bugs.webkit.org/show_bug.cgi?id=162043
3104
3105         Reviewed by Brent Fulgham. 
3106
3107         * WebCoreSupport/WebFrameLoaderClient.h:
3108         * WebCoreSupport/WebFrameLoaderClient.mm:
3109         (WebFrameLoaderClient::dispatchDidCommitLoad):
3110
3111 2016-09-15  Anders Carlsson  <andersca@apple.com>
3112
3113         This was supposed to be committed with the previous patch!
3114
3115         * Plugins/WebBasePluginPackage.mm:
3116         (pathByResolvingSymlinksAndAliases): Deleted.
3117
3118 2016-09-15  Anders Carlsson  <andersca@apple.com>
3119
3120         Replace use of Carbon file system APIs in plug-in loading
3121         https://bugs.webkit.org/show_bug.cgi?id=162040
3122         rdar://problem/6017896
3123
3124         Reviewed by Sam Weinig.
3125
3126         * Plugins/WebBasePluginPackage.mm:
3127         (-[WebBasePluginPackage initWithPath:]):
3128         Use -[NSString stringByResolvingSymlinksInPath] directly here. We already check for duplicate bundle IDs, so there's no need to try
3129         to resolve aliases as well (and the modern WebKit plug-in implementation doesn't do this).
3130
3131 2016-09-15  Beth Dakin  <bdakin@apple.com>
3132
3133         Need hasMarkedText on Mac
3134         https://bugs.webkit.org/show_bug.cgi?id=162026
3135         -and corresponding-
3136         rdar://problem/28272353
3137
3138         Reviewed by Anders Carlsson.
3139
3140         * WebView/WebHTMLViewInternal.h:
3141
3142 2016-09-12  Dean Jackson  <dino@apple.com>
3143
3144         Replace RGBA32 with Color in member variables
3145         https://bugs.webkit.org/show_bug.cgi?id=161856
3146         <rdar://problem/28254324>
3147
3148         Reviewed by Simon Fraser.
3149
3150         In preparation for the Color class to become more than
3151         just a 4-byte RGBA value, I went through a few places
3152         that were using the RGBA32 type directly, and replaced
3153         them with Color. This will make some objects a little
3154         bigger e.g. BorderValue and its friends.
3155
3156         I mostly looked at the places that were using RGBA32 as
3157         a member variable. There is still a lot of RGBA32 use
3158         around the project, in particular the CSS parser.
3159
3160         There should be no behaviour change.
3161
3162         * Misc/WebKitNSStringExtras.mm:
3163         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Explicitly
3164         call a Color constructor, rather than passing an RGBA32.
3165
3166 2016-09-13  Chris Dumez  <cdumez@apple.com>
3167
3168         Drop support for <isindex>
3169         https://bugs.webkit.org/show_bug.cgi?id=7139
3170
3171         Reviewed by Ryosuke Niwa.
3172
3173         Drop references to isindex.
3174
3175         * WebCoreSupport/WebEditorClient.mm:
3176         (attributesForAttributedStringConversion):
3177         * WebView/WebHTMLView.mm:
3178         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
3179
3180 2016-09-12  Chris Dumez  <cdumez@apple.com>
3181
3182         Switch remaining users of Document::inPageCache() to pageCacheState()
3183         https://bugs.webkit.org/show_bug.cgi?id=161865
3184
3185         Reviewed by Darin Adler.
3186
3187         Switch remaining users of Document::inPageCache() to pageCacheState() as
3188         the former one is confusing (given that it returns true while the
3189         pagehide event is being fired).
3190
3191         * WebView/WebHTMLView.mm:
3192         (-[WebHTMLView layoutToMinimumPageWidth:height:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustingViewSize:]):
3193         (-[WebHTMLView setNeedsLayout:]):
3194         (-[WebHTMLView setNeedsToApplyStyles:]):
3195
3196 2016-09-09  Tim Horton  <timothy_horton@apple.com>
3197
3198         Text replacement candidates don't always overwrite the entire original string
3199         https://bugs.webkit.org/show_bug.cgi?id=161779
3200         <rdar://problem/28033492>
3201
3202         Reviewed by Simon Fraser.
3203
3204         * WebCoreSupport/WebEditorClient.mm:
3205         (WebEditorClient::requestCandidatesForSelection):
3206         Make use of the shared implementation of contextRangeForCandidateRequest.
3207
3208 2016-09-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
3209
3210         Move the BitmapImage platform dependent code to a new file named NativeImage[CG|Cairo].cpp
3211         https://bugs.webkit.org/show_bug.cgi?id=158684
3212
3213         Reviewed by Simon Fraser.
3214
3215         * DOM/DOM.mm:
3216         (-[DOMNode getPreviewSnapshotImage:andRects:]):
3217         * Misc/WebCache.mm:
3218         (+[WebCache imageForURL:]):
3219         Replace BitmapImage::getCGImageRef() with BitmapImage::nativeImage().
3220
3221 2016-09-07  Joseph Pecoraro  <pecoraro@apple.com>
3222
3223         [Mac] Address some clang static analyzer warnings in WebKit
3224         https://bugs.webkit.org/show_bug.cgi?id=161597
3225
3226         Reviewed by Darin Adler.
3227
3228         * Misc/WebIconDatabase.h:
3229         Remove unused instance variable. It has not been used since r16005 (2006)!
3230
3231         * Misc/WebSharingServicePickerController.mm:
3232         (-[WebSharingServicePickerController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
3233         Address array leak.
3234
3235         * WebCoreSupport/WebSelectionServiceController.mm:
3236         (WebSelectionServiceController::hasRelevantSelectionServices):
3237         Address attachment and cell leak.
3238
3239         * WebView/WebFullScreenController.h:
3240         * WebView/WebImmediateActionController.h:
3241         Remove unused instance variables.
3242
3243 2016-09-07  Simon Fraser  <simon.fraser@apple.com>
3244
3245         Enable the <meter> element on iOS
3246         https://bugs.webkit.org/show_bug.cgi?id=161714
3247         rdar://problem/8978410
3248
3249         Reviewed by Tim Horton.
3250
3251         Define ENABLE_METER_ELEMENT unconditionally now.
3252
3253         * Configurations/FeatureDefines.xcconfig:
3254
3255 2016-09-07  Mark Lam  <mark.lam@apple.com>
3256
3257         Add CatchScope and force all exception checks to be via ThrowScope or CatchScope.
3258         https://bugs.webkit.org/show_bug.cgi?id=161498
3259
3260         Reviewed by Geoffrey Garen.
3261
3262         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3263         (WebKit::NetscapePluginInstanceProxy::evaluate):
3264         (WebKit::NetscapePluginInstanceProxy::invoke):
3265         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3266         (WebKit::NetscapePluginInstanceProxy::construct):
3267         (WebKit::NetscapePluginInstanceProxy::getProperty):
3268         (WebKit::NetscapePluginInstanceProxy::setProperty):
3269         (WebKit::NetscapePluginInstanceProxy::removeProperty):
3270         (WebKit::NetscapePluginInstanceProxy::hasProperty):
3271         (WebKit::NetscapePluginInstanceProxy::hasMethod):
3272         (WebKit::NetscapePluginInstanceProxy::enumerate):
3273         * WebView/WebView.mm:
3274         (aeDescFromJSValue):
3275
3276 2016-09-07  Youenn Fablet  <youenn@apple.com>
3277
3278         [Streams API] Separate compile flag for ReadableStream and WritableStream
3279         https://bugs.webkit.org/show_bug.cgi?id=161044
3280
3281         Reviewed by Alex Christensen.
3282
3283         Moving from STREAMS_API to READABLE_STREAM_API and WRITABLE_STREAM_API compilation flags.
3284
3285         * Configurations/FeatureDefines.xcconfig:
3286
3287 2016-09-06  Chris Dumez  <cdumez@apple.com>
3288
3289         Add support for input.minLength / textArea.minLength
3290         https://bugs.webkit.org/show_bug.cgi?id=161644
3291
3292         Reviewed by Darin Adler.
3293
3294         Update ObjC bindings to reflect method renaming.
3295
3296         * DOM/DOMHTMLInputElement.mm:
3297         (-[DOMHTMLInputElement maxLength]):
3298         (-[DOMHTMLInputElement setMaxLength:]):
3299         * DOM/DOMHTMLTextAreaElement.mm:
3300         (-[DOMHTMLTextAreaElement maxLength]):
3301         (-[DOMHTMLTextAreaElement setMaxLength:]):
3302
3303 2016-09-06  Dan Bernstein  <mitz@apple.com>
3304
3305         <rdar://problem/8064563> Ugly NSLog in DOMInternal.mm
3306
3307         Rubber-stamped by Anders Carlsson.
3308
3309         * DOM/DOMInternal.mm:
3310         (-[WebScriptObject _initializeScriptDOMNodeImp]): Removed useless call to NSLog.
3311
3312 2016-09-06  Ryan Haddad  <ryanhaddad@apple.com>
3313
3314         Unreviewed, rolling out r205407.
3315
3316         Not the correct way to implement this functionality
3317
3318         Reverted changeset:
3319
3320         "Consult with the FrameLoaderClient about whether or not
3321         content extensions should be enabled when loading this URL."
3322         https://bugs.webkit.org/show_bug.cgi?id=161441
3323         http://trac.webkit.org/changeset/205407
3324
3325 2016-09-05  Darin Adler  <darin@apple.com>
3326
3327         More bindings improvements, particularly things not needed for JavaScript bindings
3328         https://bugs.webkit.org/show_bug.cgi?id=161572
3329
3330         Reviewed by Sam Weinig.
3331
3332         * DOM/DOMDOMImplementation.mm:
3333         (-[DOMImplementation hasFeature:version:]): Call SVGTests::hasFeatureForLegacyBindings
3334         instead of DOMImplementation::hasFeature. Also removed JSMainThreadNullState
3335         since this does not do anything that can invoke JavaScript.
3336
3337         * DOM/DOMDocument.mm:
3338         (-[DOMDocument defaultCharset]): Call defaultCharsetForLegacyBindings. Also removed
3339         JSMainThreadNullState.
3340
3341         * DOM/DOMDocumentType.mm:
3342         (-[DOMDocumentType entities]): Changed to simply return nil; same behavior as before,
3343         but with no dependency on WebCore. Also removed JSMainThreadNullState.
3344         (-[DOMDocumentType notations]): Ditto.
3345         (-[DOMDocumentType internalSubset]): Ditto, except empty string rather than nil.
3346
3347         * DOM/DOMNode.mm:
3348         (-[DOMNode isSupported:version:]): Call SVGTests::hasFeatureForLegacyBindings
3349         instead of Node::isSupportedForBindings. Also removed JSMainThreadNullState.
3350
3351 2016-09-04  Joseph Pecoraro  <pecoraro@apple.com>
3352
3353         Remove unnecessary RetainPtr.
3354
3355         Review comments on earlier change.
3356
3357         * WebView/WebImmediateActionController.mm:
3358         (-[WebImmediateActionController _defaultAnimationController]):
3359
3360 2016-09-03  Darin Adler  <darin@apple.com>
3361
3362         Streamline DOMImplementation, and move it to our new DOM exception system
3363         https://bugs.webkit.org/show_bug.cgi?id=161295
3364
3365         Reviewed by Ryosuke Niwa.
3366
3367         * DOM/DOMDOMImplementation.mm:
3368         (unwrap): Added. Use this instead of the IMPL macro.
3369         (-[DOMImplementation dealloc]): Updated to use unwrap.
3370         (-[DOMImplementation hasFeature:version:]): Ditto.
3371         (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated to work with
3372         ExceptionOr.
3373         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
3374         (-[DOMImplementation createCSSStyleSheet:media:]): Removed exception logic since
3375         this function can no longer raise an exception.
3376         (-[DOMImplementation createHTMLDocument:]): Updated to use unwrap.
3377         (-[DOMImplementation hasFeature::]): Changed to call the non-deprecated version
3378         rather than duplicating its implementation. Also moved into the category as defined
3379         in the header.
3380         (-[DOMImplementation createDocumentType:::]): Ditto.
3381         (-[DOMImplementation createDocument:::]): Ditto.
3382         (-[DOMImplementation createCSSStyleSheet::]): Ditto.
3383
3384         * DOM/DOMDocument.mm: Removed unneeded include of DOMImplementation.h.
3385         (-[DOMDocument setXmlStandalone:]): Updated since setXMLStandalone no longer can
3386         raise an exception.
3387
3388         * WebView/WebFrame.mm:
3389         (-[WebFrame _canProvideDocumentSource]): Updated to use isTextMIMEType in its new
3390         location in MIMETypeRegistry instead of in DOMImplementation.
3391
3392 2016-09-03  Brian Weinstein  <bweinstein@apple.com>
3393
3394         Implement a stub version of FrameLoaderClient::shouldUseContentExtensionsForURL.
3395         https://bugs.webkit.org/show_bug.cgi?id=16144
3396
3397         Reviewed by Darin Adler.
3398
3399         * WebCoreSupport/WebFrameLoaderClient.h:
3400
3401 2016-09-02  Beth Dakin  <bdakin@apple.com>
3402
3403         Need to updateEditorState if an element change edit-ability without changing 
3404         selection
3405         https://bugs.webkit.org/show_bug.cgi?id=161546
3406         -and corresponding-
3407         rdar://problem/27806012
3408
3409         Reviewed by Ryosuke Niwa.
3410
3411         Every time WebEditorClient::respondToChangedSelection is called, we now save 
3412         whether the last state was contentEditable. That way in 
3413         updateEditorStateAfterLayoutIfNeeded() we can assess whether or not edit-ability 
3414         has changed. 
3415
3416         * WebCoreSupport/WebEditorClient.h:
3417         * WebCoreSupport/WebEditorClient.mm:
3418         (WebEditorClient::respondToChangedSelection):
3419         (WebEditorClient:: updateEditorStateAfterLayoutIfEditabilityChanged):
3420
3421 2016-09-02  Joseph Pecoraro  <pecoraro@apple.com>
3422
3423         [Mac] RetainPtr misuse, AnimationController leaks
3424         https://bugs.webkit.org/show_bug.cgi?id=161552
3425
3426         Reviewed by Tim Horton.
3427
3428         * WebView/WebImmediateActionController.mm:
3429         (-[WebImmediateActionController _defaultAnimationController]):
3430
3431 2016-07-08  Jer Noble  <jer.noble@apple.com>
3432
3433         Refactor WebPlaybackSessionModelMediaElement to be client based.
3434         https://bugs.webkit.org/show_bug.cgi?id=159580
3435
3436         Reviewed by Eric Carlson.
3437
3438         No longer necessary to tell the models and interfaces about each other.
3439
3440         * WebView/WebView.mm:
3441         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3442         (-[WebView _clearPlaybackControlsManager]):
3443
3444 2016-09-01  Dan Bernstein  <mitz@apple.com>
3445
3446         Build fix.
3447
3448         * Configurations/FeatureDefines.xcconfig:
3449
3450 2016-09-01  Myles C. Maxfield  <mmaxfield@apple.com>
3451
3452         Clean up TextRun-related code
3453         https://bugs.webkit.org/show_bug.cgi?id=161473
3454
3455         Reviewed by Simon Fraser.
3456
3457         Remove unused #includes.
3458
3459         * WebCoreSupport/WebDragClient.mm:
3460         * WebView/WebView.mm:
3461
3462 2016-08-31  Keith Rollin  <krollin@apple.com>
3463
3464         WebKit should set a subsystem for os_log so it's easier to filter for WebKit log messages
3465         https://bugs.webkit.org/show_bug.cgi?id=160969
3466         <rdar://problem/26068734>
3467
3468         Reviewed by Simon Fraser.
3469
3470         Enable subsystem- and channel-related data and functions when using
3471         RELEASE_LOG macros. Use the DECLARE_LOG_CHANNEL, DEFINE_LOG_CHANNEL,
3472         and LOG_CHANNEL_ADDRESS macros that are now defined in WTF.
3473
3474         * Misc/WebKitLogging.h:
3475         * Misc/WebKitLogging.m:
3476         * WebView/WebView.mm:
3477         (-[WebView _commonInitializationWithFrameName:groupName:]):
3478
3479 2016-08-31  Brady Eidson  <beidson@apple.com>
3480
3481         WK2 Gamepad provider on iOS.
3482         https://bugs.webkit.org/show_bug.cgi?id=161412
3483
3484         Reviewed by Tim Horton.
3485
3486         * Configurations/FeatureDefines.xcconfig:
3487
3488         * WebView/WebView.mm:
3489         (WebKitInitializeGamepadProviderIfNecessary):
3490
3491 2016-08-30  Mark Lam  <mark.lam@apple.com>
3492
3493         Introduce the ThrowScope and force every throw site to instantiate a ThrowScope.
3494         https://bugs.webkit.org/show_bug.cgi?id=161171
3495
3496         Reviewed by Filip Pizlo and Geoffrey Garen.
3497
3498         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3499         (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
3500         * Plugins/Hosted/ProxyInstance.mm:
3501         (WebKit::ProxyInstance::invokeMethod):
3502
3503 2016-08-28  Andreas Kling  <akling@apple.com>
3504
3505         document.title setter can't throw.
3506         <https://webkit.org/b/161302>
3507
3508         Reviewed by Antti Koivisto.
3509
3510         * DOM/DOMDocument.mm:
3511         (-[DOMDocument setTitle:]):
3512
3513 2016-08-28  Andreas Kling  <akling@apple.com>
3514
3515         Clean up some .text attribute setters that don't throw.
3516         <https://webkit.org/b/161292>
3517
3518         Reviewed by Darin Adler.
3519
3520         * DOM/DOMHTMLTitleElement.mm:
3521         (-[DOMHTMLTitleElement setText:]):
3522
3523 2016-08-26  Sam Weinig  <sam@webkit.org>
3524
3525         Remove support for ENABLE_LEGACY_WEB_AUDIO
3526         https://bugs.webkit.org/show_bug.cgi?id=161262
3527
3528         Reviewed by Anders Carlsson.
3529
3530         * Configurations/FeatureDefines.xcconfig:
3531         Remove ENABLE_LEGACY_WEB_AUDIO
3532
3533 2016-08-25  Anders Carlsson  <andersca@apple.com>
3534
3535         Re-export DOMException NSStrings after r204717
3536         https://bugs.webkit.org/show_bug.cgi?id=161200
3537         <rdar://problem/27959937>
3538
3539         Reviewed by Alex Christensen.
3540
3541         * DOM/ExceptionHandlers.mm:
3542         (raiseDOMException):
3543         * WebKit.exp:
3544
3545 2016-08-22  Darin Adler  <darin@apple.com>
3546
3547         Move Objective-C DOM bindings from WebCore to legacy WebKit
3548         https://bugs.webkit.org/show_bug.cgi?id=160654
3549
3550         Reviewed by Alex Christensen.
3551
3552         * DOM: Added lots of files to the directory.
3553         The files are just as they were in bindings/objc except that the paths of includes
3554         have been updated as needed, and the code no longer is defined inside the WebCore