Multi-rect TextIndicators are vertically flipped in WebKit1
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
2
3         Multi-rect TextIndicators are vertically flipped in WebKit1
4         https://bugs.webkit.org/show_bug.cgi?id=140350
5         <rdar://problem/19441243>
6
7         Reviewed by Beth Dakin.
8
9         * WebView/WebView.mm:
10         (-[WebView _setTextIndicator:fadeOut:]):
11         Convert the textBoundingRect from root view to screen coordinates.
12
13 2015-01-12  Anders Carlsson  <andersca@apple.com>
14
15         Make WebResourceDelegate a formal protocol as well
16         https://bugs.webkit.org/show_bug.cgi?id=140364
17
18         Reviewed by Dan Bernstein.
19
20         * WebView/WebResourceLoadDelegate.h:
21
22 2015-01-12  Anders Carlsson  <andersca@apple.com>
23
24         Delegates should be formal protocols
25         https://bugs.webkit.org/show_bug.cgi?id=140360
26         rdar://problem/17380856
27
28         Reviewed by Dan Bernstein.
29
30         This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
31
32         * DefaultDelegates/WebDefaultUIDelegate.h:
33         * Misc/WebDownload.h:
34         * WebView/WebEditingDelegate.h:
35         * WebView/WebFrameLoadDelegate.h:
36         * WebView/WebPolicyDelegate.h:
37         * WebView/WebUIDelegate.h:
38
39 2015-01-09  Anders Carlsson  <andersca@apple.com>
40
41         Get rid of the database strategy
42         https://bugs.webkit.org/show_bug.cgi?id=140322
43
44         Reviewed by Sam Weinig.
45
46         * WebCoreSupport/WebPlatformStrategies.h:
47         * WebCoreSupport/WebPlatformStrategies.mm:
48         (WebPlatformStrategies::createDatabaseStrategy): Deleted.
49
50 2015-01-08  Timothy Horton  <timothy_horton@apple.com>
51
52         Can't use DataDetectors after immediate action preparation
53         https://bugs.webkit.org/show_bug.cgi?id=140263
54         <rdar://problem/19412705>
55
56         Reviewed by Beth Dakin.
57
58         * WebView/WebImmediateActionController.mm:
59         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
60         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
61         To match WebKit2, only call shouldUseActions if the animation is actually
62         going to begin, not when preparing for it. This way, we're guaranteed
63         to get a didCancel or didComplete.
64
65 2015-01-08  Dean Jackson  <dino@apple.com>
66
67         Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
68         https://bugs.webkit.org/show_bug.cgi?id=140232
69         <rdar://problem/19371010>
70
71         Reviewed by Anders Carlsson.
72
73         Remove the applicationChromeMode setting, but leave stubs in to make
74         sure existing binaries don't break.
75
76         * WebCoreSupport/WebInspectorClient.mm:
77         (-[WebInspectorWindowController init]):
78         * WebView/WebPreferenceKeysPrivate.h:
79         * WebView/WebPreferences.mm:
80         (+[WebPreferences initialize]):
81         (-[WebPreferences applicationChromeModeEnabled]):
82         (-[WebPreferences setApplicationChromeModeEnabled:]):
83         * WebView/WebView.mm:
84         (-[WebView _preferencesChanged:]):
85
86 2015-01-07  Daniel Bates  <dabates@apple.com>
87
88         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
89         https://bugs.webkit.org/show_bug.cgi?id=137371
90
91         Reviewed by David Kilzer.
92
93         Use SPI wrapper headers instead of directly references private SPI headers.
94
95         * Plugins/Hosted/NetscapePluginHostManager.mm:
96
97 2015-01-07  Commit Queue  <commit-queue@webkit.org>
98
99         Unreviewed, rolling out r178068.
100         https://bugs.webkit.org/show_bug.cgi?id=140235
101
102         Breaks the iOS build (Requested by enrica on #webkit).
103
104         Reverted changeset:
105
106         "[iOS] Make WebKit2 build with public iOS SDK and more build
107         fixes for DRT"
108         https://bugs.webkit.org/show_bug.cgi?id=137371
109         http://trac.webkit.org/changeset/178068
110
111 2015-01-07  Daniel Bates  <dabates@apple.com>
112
113         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
114         https://bugs.webkit.org/show_bug.cgi?id=137371
115
116         Reviewed by David Kilzer.
117
118         Use SPI wrapper headers instead of directly references private SPI headers.
119
120         * Plugins/Hosted/NetscapePluginHostManager.mm:
121
122 2015-01-07  Beth Dakin  <bdakin@apple.com>
123
124         Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the 
125         link
126         https://bugs.webkit.org/show_bug.cgi?id=140206
127         -and corresponding-
128         rdar://problem/19300492
129
130         Reviewed by Tim Horton.
131
132         Providing and item frame will ensure that the original link is not obscured.
133         * WebView/WebImmediateActionController.mm:
134         (elementBoundingBoxInWindowCoordinatesFromNode):
135         (-[WebImmediateActionController menuItem:itemFrameForPoint:]):
136
137         For now use a max size that is smaller than the WebView, with the screen’s aspect 
138         ratio, and scaled down.
139         (-[WebImmediateActionController menuItem:maxSizeForPoint:]):
140
141 2015-01-07  Anders Carlsson  <andersca@apple.com>
142
143         Give simple HTML documents a database provider
144         https://bugs.webkit.org/show_bug.cgi?id=140192
145         rdar://problem/19398825
146
147         Reviewed by Tim Horton.
148
149         * WebView/WebView.mm:
150         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
151
152 2015-01-06  Anders Carlsson  <andersca@apple.com>
153
154         Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
155         https://bugs.webkit.org/show_bug.cgi?id=140140
156
157         Reviewed by Andreas Kling.
158
159         Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler
160         out of WebCore since nobody else is using it.
161
162         * Plugins/WebNetscapePluginView.h:
163         * Plugins/WebNetscapePluginView.mm:
164         (-[WebNetscapePluginView _createPlugin]):
165         (-[WebNetscapePluginView _destroyPlugin]):
166         * Plugins/npapi.mm:
167         (NPN_PluginThreadAsyncCall):
168
169 2015-01-06  Anders Carlsson  <andersca@apple.com>
170
171         Add a WebKit1 database provider
172         https://bugs.webkit.org/show_bug.cgi?id=140126
173
174         Reviewed by Sam Weinig.
175
176         Set the database provider.
177
178         * WebView/WebView.mm:
179         (-[WebView _commonInitializationWithFrameName:groupName:]):
180
181 2015-01-06  Commit Queue  <commit-queue@webkit.org>
182
183         Unreviewed, rolling out r177963.
184         https://bugs.webkit.org/show_bug.cgi?id=140136
185
186         Caused lots of crashes (Requested by smfr on #webkit).
187
188         Reverted changeset:
189
190         "Add a WebKit1 database provider"
191         https://bugs.webkit.org/show_bug.cgi?id=140126
192         http://trac.webkit.org/changeset/177963
193
194 2015-01-06  Anders Carlsson  <andersca@apple.com>
195
196         Add a WebKit1 database provider
197         https://bugs.webkit.org/show_bug.cgi?id=140126
198
199         Reviewed by Sam Weinig.
200
201         Set the database provider.
202
203         * WebView/WebView.mm:
204         (-[WebView _commonInitializationWithFrameName:groupName:]):
205
206 2015-01-01  Jeff Miller  <jeffm@apple.com>
207
208         Update user-visible copyright strings to include 2015
209         https://bugs.webkit.org/show_bug.cgi?id=139880
210
211         Reviewed by Darin Adler.
212
213         * Info.plist:
214
215 2014-12-30  Dan Bernstein  <mitz@apple.com>
216
217         [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
218         https://bugs.webkit.org/show_bug.cgi?id=140003
219
220         Reviewed by Darin Adler.
221
222         * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
223         that takes their "string" parameter as a "value" "parameter and has an attribute telling
224         the compiler that if the "value" parameter is a format string then the function returns a
225         modified version of it. The result is that if UI_STRING is used as a format string parameter
226         to some function or method, the compiler will check the format specifiers in the string
227         against the other parameters.
228
229 2014-12-29  Dan Bernstein  <mitz@apple.com>
230
231         Fixed the iOS build.
232
233         * Configurations/WebKitLegacy.xcconfig:
234
235 2014-12-29  Anders Carlsson  <andersca@apple.com>
236
237         Get rid of some PageGroup storage functions
238         https://bugs.webkit.org/show_bug.cgi?id=139996
239
240         Reviewed by Sam Weinig.
241
242         Call WebStorageNamespaceProvider directly instead.
243
244         * Storage/WebStorageManager.mm:
245         (-[WebStorageManager syncLocalStorage]):
246         (+[WebStorageManager closeIdleLocalStorageDatabases]):
247         * WebView/WebView.mm:
248         (+[WebView _applicationWillTerminate]):
249
250 2014-12-29  Anders Carlsson  <andersca@apple.com>
251
252         Move storage code from WebCore to WebKit
253         https://bugs.webkit.org/show_bug.cgi?id=139558
254
255         Reviewed by Darin Adler.
256
257         * Storage/WebStorageManager.mm:
258         * Storage/WebStorageTrackerClient.h:
259         * WebView/WebView.mm:
260
261 2014-12-26  Dan Bernstein  <mitz@apple.com>
262
263         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
264         https://bugs.webkit.org/show_bug.cgi?id=139950
265
266         Reviewed by David Kilzer.
267
268         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
269         in a manner that works with Xcode 5.1.1.
270
271 2014-12-23  Timothy Horton  <timothy_horton@apple.com>
272
273         Install a TextIndicator for link immediate actions
274         https://bugs.webkit.org/show_bug.cgi?id=139897
275         <rdar://problem/19333076>
276
277         Reviewed by Anders Carlsson.
278
279         * WebView/WebImmediateActionController.h:
280         * WebView/WebImmediateActionController.mm:
281         (-[WebImmediateActionController _clearImmediateActionState]):
282         Tear down the TextIndicator, just like WebKit2.
283
284         (-[WebImmediateActionController _defaultAnimationController]):
285         Install a TextIndicator for links.
286
287         (-[WebImmediateActionController menuItemDidClose:]):
288         Tear down the TextIndicator when the QL preview closes.
289
290         (-[WebImmediateActionController _menuItemForDataDetectedText]):
291         Directly install and uninstall the TextIndicator for DataDetectors.
292
293         (-[WebImmediateActionController _showTextIndicator]): Deleted.
294         (-[WebImmediateActionController _hideTextIndicator]): Deleted.
295         Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
296
297 2014-12-20  Eric Carlson  <eric.carlson@apple.com>
298
299         [iOS] add optimized fullscreen API
300         https://bugs.webkit.org/show_bug.cgi?id=139833
301         <rdar://problem/18844486>
302
303         Reviewed by Simon Fraser.
304
305         * Configurations/FeatureDefines.xcconfig:  Add ENABLE_VIDEO_PRESENTATION_MODE.
306
307 2014-12-20  David Kilzer  <ddkilzer@apple.com>
308
309         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
310         <http://webkit.org/b/139463>
311
312         Reviewed by Mark Rowe.
313
314         * Configurations/Base.xcconfig:
315         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
316           on OS X.
317         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
318         * Configurations/DebugRelease.xcconfig:
319         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
320         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
321         * Configurations/Version.xcconfig:
322         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
323         * Configurations/WebKitLegacy.xcconfig:
324         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
325           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
326           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
327           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
328           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
329           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
330           WEBCORE_PRIVATE_HEADERS_DIR_Production and
331           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
332           based on SDK.
333         - Fix PRODUCTION_ROOT to actually be set properly.
334         - Simplify EXPORTED_SYMBOLS_FILE_i386.
335
336         * migrate-headers.sh:
337         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
338         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
339           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
340           WebKitLegacy.xcconfig.
341
342 2014-12-19  Simon Fraser  <simon.fraser@apple.com>
343
344         Fix pink background on CoreAnimation plug-ins in WebKit1
345         https://bugs.webkit.org/show_bug.cgi?id=139845
346         rdar://problem/19313075
347
348         Reviewed by Tim Horton.
349         
350         r154078 left in some debugging code that set a pink background on plug-in hosting
351         layers. Remove it.
352
353         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
354         (-[WebHostedNetscapePluginView createPluginLayer]):
355
356 2014-12-19  Andreas Kling  <akling@apple.com>
357
358         Ref-ify TextIterator API.
359         <https://webkit.org/b/139823>
360
361         Reviewed by Antti Koivisto.
362
363         * WebView/WebTextIterator.mm:
364         (-[WebTextIterator currentRange]):
365
366 2014-12-19  Joseph Pecoraro  <pecoraro@apple.com>
367
368         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
369         https://bugs.webkit.org/show_bug.cgi?id=139797
370
371         Reviewed by Mark Lam.
372
373         * WebView/WebScriptDebugger.h:
374         * WebView/WebScriptDebugger.mm:
375         (WebScriptDebugger::handlePause):
376         Standardize on passing JSGlobalObject parameter first.
377
378 2014-12-19  Commit Queue  <commit-queue@webkit.org>
379
380         Unreviewed, rolling out r177574.
381         https://bugs.webkit.org/show_bug.cgi?id=139821
382
383         "Broke Production builds by installing
384         libWebCoreTestSupport.dylib in the wrong directory" (Requested
385         by ddkilzer on #webkit).
386
387         Reverted changeset:
388
389         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
390         WebInspectorUI, WebKit, WebKit2"
391         https://bugs.webkit.org/show_bug.cgi?id=139463
392         http://trac.webkit.org/changeset/177574
393
394 2014-12-19  David Kilzer  <ddkilzer@apple.com>
395
396         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
397         <http://webkit.org/b/139463>
398
399         Reviewed by Mark Rowe.
400
401         * Configurations/Base.xcconfig:
402         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
403           on OS X.
404         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
405         * Configurations/DebugRelease.xcconfig:
406         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
407         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
408         * Configurations/Version.xcconfig:
409         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
410         * Configurations/WebKitLegacy.xcconfig:
411         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
412           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
413           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
414           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
415           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
416           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
417           WEBCORE_PRIVATE_HEADERS_DIR_Production and
418           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
419           based on SDK.
420         - Fix PRODUCTION_ROOT to actually be set properly.
421         - Simplify EXPORTED_SYMBOLS_FILE_i386.
422
423         * migrate-headers.sh:
424         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
425         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
426           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
427           WebKitLegacy.xcconfig.
428
429 2014-12-18  Andreas Kling  <akling@apple.com>
430
431         Ref-ify various Document-related things.
432         <https://webkit.org/b/139796>
433
434         Reviewed by Anders Carlsson.
435
436         * WebView/WebFrame.mm:
437         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
438
439 2014-12-18  Beth Dakin  <bdakin@apple.com>
440
441         Need to re-enable action menus
442         https://bugs.webkit.org/show_bug.cgi?id=139795
443         -and corresponding-
444         rdar://problem/19299367
445
446         Reviewed by Tim Horton.
447
448         Re-enable the menus by un-commenting the code to create the menu and controller.
449         * WebView/WebView.mm:
450         (-[WebView _commonInitializationWithFrameName:groupName:]):
451
452 2014-12-16  Sam Weinig  <sam@webkit.org>
453
454         Unify the Mac and iOS implementations of FontPlatformData a bit
455         https://bugs.webkit.org/show_bug.cgi?id=139721
456
457         Reviewed by Anders Carlsson.
458
459         * WebView/WebHTMLView.mm:
460         (fontNameForDescription):
461         Update for new function name.
462
463 2014-12-18  Antti Koivisto  <antti@apple.com>
464
465         Remove alwaysUseBaselineOfPrimaryFont setting
466         https://bugs.webkit.org/show_bug.cgi?id=139770
467
468         Reviewed by Anders Carlsson.
469
470         * WebView/WebPreferenceKeysPrivate.h:
471         * WebView/WebPreferences.mm:
472         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
473         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
474         * WebView/WebPreferencesPrivate.h:
475         * WebView/WebView.mm:
476         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
477         (-[WebView _preferencesChanged:]):
478
479 2014-12-17  Andreas Kling  <akling@apple.com>
480
481         Ref-ify Range::create().
482         <https://webkit.org/b/139755>
483
484         Reviewed by Anders Carlsson.
485
486         * WebView/WebHTMLRepresentation.mm:
487         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
488         * WebView/WebHTMLView.mm:
489         (-[WebHTMLView attributedString]):
490
491 2014-12-17  Anders Carlsson  <andersca@apple.com>
492
493         Unify -[WebResource description]
494         https://bugs.webkit.org/show_bug.cgi?id=139762
495
496         Reviewed by Dan Bernstein.
497
498         * WebView/WebResource.mm:
499         (-[WebResource description]):
500
501 2014-12-17  Anders Carlsson  <andersca@apple.com>
502
503         Get rid of an ugly #define hack in WebFrameLoaderClient
504         https://bugs.webkit.org/show_bug.cgi?id=139761
505
506         Reviewed by Dan Bernstein.
507
508         Also replace @private with @package in all public headers, for consistency.
509
510         * History/WebBackForwardList.h:
511         * History/WebHistory.h:
512         * Misc/WebDownload.h:
513         * WebCoreSupport/WebFrameLoaderClient.mm:
514         * WebView/WebArchive.h:
515         * WebView/WebDataSource.h:
516         * WebView/WebFrame.h:
517         * WebView/WebFrameView.h:
518         * WebView/WebPreferences.h:
519         * WebView/WebResource.h:
520
521 2014-12-17  Dan Bernstein  <mitz@apple.com>
522
523         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
524         https://bugs.webkit.org/show_bug.cgi?id=139760
525
526         Reviewed by Anders Carlsson.
527
528         * Configurations/WebKitLegacy.xcconfig:
529
530 2014-12-17  Andreas Kling  <akling@apple.com>
531
532         Purge PassRefPtr from Frame.
533         <https://webkit.org/b/139731>
534
535         Reviewed by Anders Carlsson.
536
537         * WebCoreSupport/WebFrameLoaderClient.mm:
538         (WebFrameLoaderClient::transitionToCommittedForNewPage):
539         * WebView/WebFrame.mm:
540         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
541         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
542         * WebView/WebFrameInternal.h:
543
544 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
545
546         Implement and adopt two new TextIndicator presentation animations
547         https://bugs.webkit.org/show_bug.cgi?id=139715
548         <rdar://problem/19237945>
549
550         Reviewed by Anders Carlsson.
551
552         * WebView/WebActionMenuController.mm:
553         (-[WebActionMenuController _showTextIndicator]):
554         * WebView/WebHTMLView.mm:
555         (-[WebHTMLView quickLookWithEvent:]):
556         Remove the completionHandler from text indicator presentation.
557
558         * WebView/WebImmediateActionController.mm:
559         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
560         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
561         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
562         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
563         (-[WebImmediateActionController _menuItemForDataDetectedText]):
564         (-[WebImmediateActionController _animationControllerForText]):
565         (-[WebImmediateActionController _showTextIndicator]):
566         Forward immediate action gesture recognizer animation progress
567         to TextIndicator. Force us to keep the selection when immediate
568         action popovers steal first responder status from the WebView.
569         If the Lookup range is equal to the selection range, use a Crossfade
570         animation; otherwise, use a FadeIn animation.
571
572         * WebView/WebView.mm:
573         (-[WebView _setMaintainsInactiveSelection:]):
574         (-[WebView maintainsInactiveSelection]):
575         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
576         (-[WebView _setTextIndicator:fadeOut:]):
577         (-[WebView _clearTextIndicator]):
578         (-[WebView _setTextIndicatorAnimationProgress:]):
579         (-[WebView _showDictionaryLookupPopup:]):
580         (-[WebView _dictionaryLookupPopoverWillClose:]):
581         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
582         Remove the completionHandler from text indicator presentation.
583         Add a _setMaintainsInactiveSelection, which allows WebKit internals
584         to change the return value of -maintainsInactiveSelection, allowing
585         us to keep the selection alive when the WebView loses first responder status.
586
587         * WebView/WebViewData.h:
588         * WebView/WebViewInternal.h:
589
590 2014-12-16  Andreas Kling  <akling@apple.com>
591
592         Use Ref for SecurityOrigin.
593         <https://webkit.org/b/139710>
594
595         Reviewed by Anders Carlsson.
596
597         * Storage/WebStorageTrackerClient.mm:
598         (WebStorageTrackerClient::dispatchDidModifyOrigin):
599         * WebView/WebView.mm:
600         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
601         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
602
603 2014-12-16  Beth Dakin  <bdakin@apple.com>
604
605         Crash getting default animation controller for some text
606         https://bugs.webkit.org/show_bug.cgi?id=139712
607         -and corresponding-
608         rdar://problem/19271707
609
610         Reviewed by Tim Horton.
611
612         Must null-check the range.
613         * WebView/WebImmediateActionController.mm:
614         (-[WebImmediateActionController _animationControllerForText]):
615
616 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
617
618         Immediate action popovers can get stuck open
619         https://bugs.webkit.org/show_bug.cgi?id=139709
620         <rdar://problem/19270279>
621
622         Reviewed by Beth Dakin.
623
624         * WebView/WebImmediateActionController.mm:
625         (-[WebImmediateActionController _clearImmediateActionState]):
626         Don't clear the animation controller; it breaks things and was unnecessary.
627
628 2014-12-16  Tim Horton  <timothy_horton@apple.com>
629
630         Disable TextIndication for Lookup immediate actions
631         https://bugs.webkit.org/show_bug.cgi?id=139684
632
633         Reviewed by Anders Carlsson.
634
635         * WebView/WebView.mm:
636         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
637
638 2014-12-15  Beth Dakin  <bdakin@apple.com>
639
640         Build fix.
641
642         * WebView/WebImmediateActionController.mm:
643
644 2014-12-15  Beth Dakin  <bdakin@apple.com>
645
646         Speculative build fix.
647
648         * WebView/WebView.mm:
649         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
650         * WebView/WebViewInternal.h:
651
652 2014-12-15  Beth Dakin  <bdakin@apple.com>
653
654         Make lookup an immediate action instead of an action menu item
655         https://bugs.webkit.org/show_bug.cgi?id=139661
656         -and corresponding-
657         rdar://problem/19198414
658
659         Reviewed by Tim Horton.
660
661         Remove the lookup menu items and non-unused static function associated with 
662         lookup.
663         * WebView/WebActionMenuController.mm:
664         (-[WebActionMenuController _defaultMenuItemsForText]):
665         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
666         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
667         (-[WebActionMenuController _createActionMenuItemForTag:]):
668         (-[WebActionMenuController _lookupText:]): Deleted.
669         (performDictionaryLookupForSelection): Deleted.
670         (performDictionaryLookupForRange): Deleted.
671
672         Set the defaultAnimationController to the lookup-provided animation controller 
673         when appropriate.
674         * WebView/WebImmediateActionController.mm:
675         (-[WebImmediateActionController _defaultAnimationController]):
676         (dictionaryPopupInfoForRange):
677         (-[WebImmediateActionController _animationControllerForText]):
678
679         New type.
680         * WebView/WebUIDelegatePrivate.h:
681
682         New function to get the lookup animation controller.
683         * WebView/WebView.mm:
684         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
685         * WebView/WebViewInternal.h:
686
687 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
688
689         Implement Data Detectors immediate actions for Legacy WebKit
690         https://bugs.webkit.org/show_bug.cgi?id=139619
691         <rdar://problem/19198539>
692
693         Reviewed by Beth Dakin.
694
695         * WebView/WebImmediateActionController.mm:
696         (-[WebImmediateActionController _menuItemForDataDetectedText]):
697         Note that this action context is only for immediate actions.
698
699 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
700
701         Addressing post-review comments in r177035
702         https://bugs.webkit.org/show_bug.cgi?id=139557
703
704         Reviewed by Darin Adler.
705
706         * WebView/WebActionMenuController.mm:
707         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
708
709 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
710
711         Implement Data Detectors immediate actions for Legacy WebKit
712         https://bugs.webkit.org/show_bug.cgi?id=139619
713         <rdar://problem/19198539>
714
715         Reviewed by Eric Carlson.
716
717         * WebView/WebHTMLView.mm:
718         (-[WebHTMLView mouseDown:mouseDown:]):
719         Send mouseDown along to the WebImmediateActionController too.
720
721         * WebView/WebImmediateActionController.h:
722         * WebView/WebImmediateActionController.mm:
723         (-[WebImmediateActionController webViewClosed]):
724         (-[WebImmediateActionController webView:willHandleMouseDown:]):
725         (-[WebImmediateActionController _cancelImmediateAction]):
726         (-[WebImmediateActionController _clearImmediateActionState]):
727         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
728         (-[WebImmediateActionController _defaultAnimationController]):
729         (-[WebImmediateActionController _updateImmediateActionItem]):
730         (-[WebImmediateActionController _menuItemForDataDetectedText]):
731         (-[WebImmediateActionController _showTextIndicator]):
732         (-[WebImmediateActionController _hideTextIndicator]):
733         Copy most of the DataDetectors implementation into WebImmediateActionController.
734
735         * WebView/WebUIDelegatePrivate.h:
736         Add a new type.
737
738         * WebView/WebView.mm:
739         (-[WebView _commonInitializationWithFrameName:groupName:]):
740         Temporarily disable action menus.
741
742         (-[WebView _immediateActionController]):
743         * WebView/WebViewInternal.h:
744
745 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
746
747         Delete Notation because we don't use it
748         https://bugs.webkit.org/show_bug.cgi?id=139171
749
750         Reviewed by Kent Tamura.
751
752         * MigrateHeaders.make:
753
754 2014-12-14  Andreas Kling  <akling@apple.com>
755
756         Replace PassRef with Ref/Ref&& across the board.
757         <https://webkit.org/b/139587>
758
759         Reviewed by Darin Adler.
760
761         * WebCoreSupport/WebEditorClient.mm:
762         (WebEditorClient::shouldApplyStyle):
763         * WebCoreSupport/WebVisitedLinkStore.h:
764         * WebCoreSupport/WebVisitedLinkStore.mm:
765         (WebVisitedLinkStore::create):
766
767 2014-12-11  Dan Bernstein  <mitz@apple.com>
768
769         Fix a leak introduced in r177199.
770
771         Reviewed by Anders Carlsson.
772
773         * WebView/WebImmediateActionController.mm:
774         (-[WebImmediateActionController _updateImmediateActionItem]):
775
776 2014-12-11  Beth Dakin  <bdakin@apple.com>
777
778         WK1: Need new SPI for Webkit clients to override default immediate action
779         https://bugs.webkit.org/show_bug.cgi?id=139568
780         -and corresponding-
781         rdar://problem/19225448
782
783         Reviewed by Dan Bernstein.
784
785         Call SPI giving clients a chance to override the default behavior.
786         * WebView/WebImmediateActionController.mm:
787         (-[WebImmediateActionController _updateImmediateActionItem]):
788
789         New SPI.
790         * WebView/WebUIDelegatePrivate.h:
791
792 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
793
794         Move the preview popover to WebImmediateActionController
795         https://bugs.webkit.org/show_bug.cgi?id=139563
796         <rdar://problem/19208291>
797
798         Reviewed by Beth Dakin.
799
800         * WebView/WebActionMenuController.mm:
801         (-[WebActionMenuController _defaultMenuItemsForLink]):
802         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
803         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
804         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
805         * WebView/WebImmediateActionController.h:
806         * WebView/WebImmediateActionController.mm:
807         (-[WebImmediateActionController webViewClosed]):
808         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
809         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
810         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
811         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
812         (-[WebImmediateActionController _updateImmediateActionItem]):
813         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
814         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
815         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
816         Move page preview popover related code to WebImmediateActionController.
817
818         * WebView/WebUIDelegatePrivate.h:
819         Add a link preview type.
820
821         * WebView/WebView.mm:
822         (-[WebView _commonInitializationWithFrameName:groupName:]):
823         Pass the gesture recognizer to the WebImmediateActionController.
824
825 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
826
827         Fix the build.
828
829         * WebView/WebImmediateActionController.h:
830         * WebView/WebImmediateActionController.mm:
831
832 2014-12-11  Anders Carlsson  <andersca@apple.com>
833
834         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
835         https://bugs.webkit.org/show_bug.cgi?id=139547
836
837         Reviewed by Sam Weinig.
838
839         * WebView/WebView.mm:
840         (+[WebView _handleMemoryWarning]):
841
842 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
843
844         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
845         https://bugs.webkit.org/show_bug.cgi?id=139504
846         rdar://problem/19034674
847
848         Reviewed by Enrica Casucci.
849
850         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
851
852         * WebCoreSupport/WebEditorClient.h:
853         * WebCoreSupport/WebEditorClient.mm:
854         (WebEditorClient::discardedComposition):
855
856 2014-12-10  Anders Carlsson  <andersca@apple.com>
857
858         Get rid of the storage strategy
859         https://bugs.webkit.org/show_bug.cgi?id=139519
860
861         Reviewed by Antti Koivisto.
862
863         * WebCoreSupport/WebPlatformStrategies.h:
864         * WebCoreSupport/WebPlatformStrategies.mm:
865         (WebPlatformStrategies::createStorageStrategy): Deleted.
866
867 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
868
869         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
870         https://bugs.webkit.org/show_bug.cgi?id=139529
871         <rdar://problem/19213620>
872
873         Reviewed by Beth Dakin.
874
875         * WebView/WebActionMenuController.mm:
876         (-[WebActionMenuController _copySelection:]):
877         (-[WebActionMenuController _paste:]):
878         Use the copy: and paste: methods on WebView so that we traverse subviews
879         when trying to respond, otherwise these actions don't work in subframes.
880
881 2014-12-10  Beth Dakin  <bdakin@apple.com>
882
883         WK1: Add initial support for immediate actions
884         https://bugs.webkit.org/show_bug.cgi?id=139522
885
886         Reviewed by Dan Bernstein.
887
888         This basic implementation of the controller will use the delegate methods to 
889         perform and cache a HitTest when relevant. Future patches will patch 
890         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
891         immediate action that should be taken.
892         * WebView/WebImmediateActionController.h: Added.
893         * WebView/WebImmediateActionController.mm: Added.
894         (-[WebImmediateActionController webViewClosed]):
895         (-[WebImmediateActionController _clearImmediateActionState]):
896         (-[WebImmediateActionController performHitTestAtPoint:]):
897         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
898         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
899         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
900         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
901         (-[WebImmediateActionController _updateImmediateActionItem]):
902
903         New enum for immediate action types.
904         * WebView/WebUIDelegatePrivate.h:
905
906         Create an NSImmediateActionGestureRecognizer if possible and a controller.
907         * WebView/WebView.mm:
908         (-[WebView _commonInitializationWithFrameName:groupName:]):
909         (-[WebView _close]):
910         * WebView/WebViewData.h:
911         * WebView/WebViewData.mm:
912         (-[WebViewPrivate dealloc]):
913
914 2014-12-08  Anders Carlsson  <andersca@apple.com>
915
916         Use the new storage namespace provider in WebKit1
917         https://bugs.webkit.org/show_bug.cgi?id=139425
918
919         Reviewed by Tim Horton.
920
921         * WebView/WebView.mm:
922         (-[WebView _commonInitializationWithFrameName:groupName:]):
923         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
924         Set the storage namespace provider from the web page group.
925
926 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
927
928         Should have copy and paste items in all text menus
929         https://bugs.webkit.org/show_bug.cgi?id=139510
930         <rdar://problem/19198388>
931
932         Reviewed by Beth Dakin.
933
934         * WebView/WebActionMenuController.mm:
935         (-[WebActionMenuController _defaultMenuItemsForText]):
936         Add a disabled paste menu item into the read-only text menu.
937
938         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
939         Add a disabled copy menu item into the editable whitespace text menu.
940
941 2014-12-10  Anders Carlsson  <andersca@apple.com>
942
943         Add WebStorageNamespaceProvider::closeLocalStorage
944         https://bugs.webkit.org/show_bug.cgi?id=139502
945
946         Reviewed by Tim Horton.
947
948         * WebView/WebView.mm:
949         (+[WebView _applicationWillTerminate]):
950         Call WebStorageNamespaceProvider::closeLocalStorage.
951
952 2014-12-09  Commit Queue  <commit-queue@webkit.org>
953
954         Unreviewed, rolling out r177037.
955         https://bugs.webkit.org/show_bug.cgi?id=139464
956
957         broke ~50 API tests (Requested by thorton on #webkit).
958
959         Reverted changeset:
960
961         "Use the new storage namespace provider in WebKit1"
962         https://bugs.webkit.org/show_bug.cgi?id=139425
963         http://trac.webkit.org/changeset/177037
964
965 2014-12-08  Anders Carlsson  <andersca@apple.com>
966
967         Use the new storage namespace provider in WebKit1
968         https://bugs.webkit.org/show_bug.cgi?id=139425
969
970         Reviewed by Tim Horton.
971
972         * WebView/WebView.mm:
973         (-[WebView _commonInitializationWithFrameName:groupName:]):
974         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
975         Set the storage namespace provider from the web page group.
976
977 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
978
979         Delete Node::boundingBox()
980         https://bugs.webkit.org/show_bug.cgi?id=139333
981
982         Reviewed by Zalan Bujtas.
983
984         * WebView/WebActionMenuController.mm:
985         (elementBoundingBoxInWindowCoordinatesFromNode): Use
986         RenderObject::absoluteBoundingBoxRect().
987
988 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
989
990         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
991         https://bugs.webkit.org/show_bug.cgi?id=138843
992         rdar://problem/18793695
993
994         Reviewed by Dan Bernstein.
995
996         * Panels/WebAuthenticationPanel.m:
997         (-[WebAuthenticationPanel cancel:]):
998         (-[WebAuthenticationPanel logIn:]):
999         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
1000         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
1001         that only when using an old NSWindow API.
1002
1003 2014-12-08  Beth Dakin  <bdakin@apple.com>
1004
1005         Copy and Lookup menu items should be disabled when something is not copyable
1006         https://bugs.webkit.org/show_bug.cgi?id=139423
1007
1008         Reviewed by Tim Horton.
1009
1010         Disable both lookup and copy when a HitTestResult does not allow copy.
1011         * WebView/WebActionMenuController.mm:
1012
1013         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
1014         disable state otherwise.
1015         * WebView/WebView.mm:
1016         (-[WebView _commonInitializationWithFrameName:groupName:]):
1017
1018 2014-12-08  Anders Carlsson  <andersca@apple.com>
1019
1020         Adding user content to a group should force that group to be created
1021         https://bugs.webkit.org/show_bug.cgi?id=139421
1022         rdar://problem/19180108
1023
1024         Reviewed by Sam Weinig.
1025
1026         * WebCoreSupport/WebViewGroup.h:
1027         Store the local storage database path in the group.
1028
1029         * WebCoreSupport/WebViewGroup.mm:
1030         (WebViewGroup::getOrCreate):
1031         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
1032         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
1033
1034         (WebViewGroup::WebViewGroup):
1035         Initialize the new member variable.
1036
1037         (WebViewGroup::storageNamespaceProvider):
1038         Create the namespace provider lazily.
1039
1040         * WebView/WebView.mm:
1041         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1042         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1043         Use getOrCreate instead of get.
1044
1045 2014-12-08  Anders Carlsson  <andersca@apple.com>
1046
1047         WebStorageNamespaceProvider should know about its local storage database path
1048         https://bugs.webkit.org/show_bug.cgi?id=139413
1049
1050         Reviewed by Andreas Kling.
1051
1052         * WebCoreSupport/WebViewGroup.h:
1053         * WebCoreSupport/WebViewGroup.mm:
1054         (WebViewGroup::getOrCreate):
1055         (WebViewGroup::WebViewGroup):
1056         * WebView/WebView.mm:
1057         (-[WebView _commonInitializationWithFrameName:groupName:]):
1058         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1059         (-[WebView setGroupName:]):
1060         (-[WebView groupName]): Deleted.
1061
1062 2014-12-08  Daniel Bates  <dabates@apple.com>
1063
1064         [iOS] Fix the WebKit build with the public SDK
1065
1066         Include header NSURLDownloadSPI.h.
1067
1068         * WebCoreSupport/WebFrameLoaderClient.mm:
1069
1070 2014-12-07  Dan Bernstein  <mitz@apple.com>
1071
1072         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
1073         https://bugs.webkit.org/show_bug.cgi?id=139348
1074
1075         Reviewed by Anders Carlsson.
1076
1077         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
1078         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
1079         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
1080         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
1081         avoiding the ambiguity.
1082
1083         * WebView/WebActionMenuController.mm:
1084         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1085
1086 2014-12-06  Anders Carlsson  <andersca@apple.com>
1087
1088         Add a stubbed out version of WebStorageNamespaceProvider
1089         https://bugs.webkit.org/show_bug.cgi?id=139213
1090
1091         Reviewed by Sam Weinig.
1092
1093         * WebCoreSupport/WebViewGroup.h:
1094         (WebViewGroup::storageNamespaceProvider):
1095         * WebCoreSupport/WebViewGroup.mm:
1096         (WebViewGroup::getOrCreate):
1097         (WebViewGroup::WebViewGroup):
1098         Give WebViewGroup a storage namespace provider.
1099
1100 2014-12-06  Anders Carlsson  <andersca@apple.com>
1101
1102         Fix build with newer versions of clang.
1103         rdar://problem/18978687
1104
1105         Add missing overrides and missing casts.
1106
1107         * Storage/WebDatabaseManagerClient.h:
1108         * Storage/WebStorageTrackerClient.h:
1109         * WebCoreSupport/WebChromeClient.h:
1110         * WebCoreSupport/WebFrameLoaderClient.h:
1111         * WebCoreSupport/WebInspectorClient.h:
1112         * WebView/WebDataSource.mm:
1113         (-[WebDataSource _makeRepresentation]):
1114         * WebView/WebFrameView.mm:
1115         (-[WebFrameView _makeDocumentViewForDataSource:]):
1116
1117 2014-12-05  Tim Horton  <timothy_horton@apple.com>
1118
1119         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
1120         https://bugs.webkit.org/show_bug.cgi?id=139306
1121         <rdar://problem/19157955>
1122
1123         Reviewed by Beth Dakin.
1124
1125         * WebView/WebView.mm:
1126         (-[WebView _commonInitializationWithFrameName:groupName:]):
1127         (-[WebView _initWithFrame:frameName:groupName:]):
1128         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
1129
1130 2014-12-05  David Kilzer  <ddkilzer@apple.com>
1131
1132         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
1133         <http://webkit.org/b/139286>
1134
1135         Reviewed by Daniel Bates.
1136
1137         * Configurations/FeatureDefines.xcconfig: Switch back to using
1138         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
1139
1140 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
1141
1142         Fix the 32-bit build.
1143
1144         * WebView/WebView.mm:
1145         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1146
1147 2014-12-04  Tim Horton  <timothy_horton@apple.com>
1148
1149         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
1150         https://bugs.webkit.org/show_bug.cgi?id=139252
1151         <rdar://problem/19140827>
1152
1153         Reviewed by Anders Carlsson.
1154
1155         * WebView/WebView.mm:
1156         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1157         Adjust to the WebCore changes.
1158
1159 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
1160
1161         Implement action menus for tel: URLs
1162         https://bugs.webkit.org/show_bug.cgi?id=139240
1163         <rdar://problem/19115662>
1164
1165         Reviewed by Anders Carlsson.
1166
1167         * WebView/WebActionMenuController.mm:
1168         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1169         Make sure to use the newly created currentActionContext... everywhere.
1170
1171 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
1172
1173         Implement action menus for tel: URLs
1174         https://bugs.webkit.org/show_bug.cgi?id=139240
1175         <rdar://problem/19115662>
1176
1177         Reviewed by Anders Carlsson.
1178
1179         * WebView/WebActionMenuController.mm:
1180         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1181         Make sure to use the newly created currentActionContext.
1182
1183 2014-12-03  Beth Dakin  <bdakin@apple.com>
1184
1185         <input> elements get whitespace action menu instead of editable text menu
1186         https://bugs.webkit.org/show_bug.cgi?id=139241
1187         -and corresponding-
1188         rdar://problem/19072083
1189
1190         Reviewed by Sam Weinig.
1191
1192         We should disallow shadow content in the hit test. This is the default and it is 
1193         how context menus behave. We originally wanted to text inside shadow content so 
1194         that we could find the text, but the new function I added to HitTestResult will 
1195         allow that.
1196         * WebView/WebActionMenuController.mm:
1197         (-[WebActionMenuController performHitTestAtPoint:]):
1198
1199         Adjust to the fact that we don’t hit test shadow content any more.
1200         (-[WebActionMenuController focusAndSelectHitTestResult]):
1201
1202         Offer the text menus for text inside form controls.
1203         (-[WebActionMenuController _defaultMenuItems]):
1204
1205 2014-12-03  Tim Horton  <timothy_horton@apple.com>
1206
1207         Implement action menus for tel: URLs
1208         https://bugs.webkit.org/show_bug.cgi?id=139240
1209         <rdar://problem/19115662>
1210
1211         Reviewed by Anders Carlsson.
1212
1213         * WebView/WebActionMenuController.mm:
1214         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1215         Rename this function as it will work for both mailto and tel URLs.
1216         Adjust it to use contextForView:.
1217
1218         (-[WebActionMenuController webView:willHandleMouseDown:]):
1219         (-[WebActionMenuController prepareForMenu:withEvent:]):
1220         (-[WebActionMenuController didCloseMenu:withEvent:]):
1221         (-[WebActionMenuController _defaultMenuItems]):
1222         Don't check the menu type when going to interact with _currentActionContext.
1223         We'll only have a _currentActionContext if we have a data detected item,
1224         and there are multiple menu types that end up using DDActionContext.
1225
1226         * WebView/WebUIDelegatePrivate.h:
1227         Add a new type.
1228
1229 2014-12-03  Anders Carlsson  <andersca@apple.com>
1230
1231         Set a visited link store when creating a simple WebView
1232         https://bugs.webkit.org/show_bug.cgi?id=139234
1233         <rdar://problem/19132978>
1234
1235         Reviewed by Sam Weinig.
1236
1237         * WebView/WebView.mm:
1238         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1239
1240 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
1241
1242         Fix the build.
1243
1244         * WebCoreSupport/WebFrameLoaderClient.mm:
1245
1246 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
1247
1248         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
1249         https://bugs.webkit.org/show_bug.cgi?id=139149
1250
1251         Reviewed by Anders Carlsson.
1252
1253         This changes API behavior. I think that it's OK, because existing behavior made no sense.
1254         We used to delete caches from disk, but they were still active in memory. Now we also
1255         obsolete them in memory, so documents that use a cache still work, but new ones don't
1256         pick one up.
1257
1258         * WebCoreSupport/WebApplicationCache.mm:
1259         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
1260         need to delete in-momry caches too. Keep existing behavior.
1261         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
1262         that properly deletes caches.
1263
1264 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1265
1266         Remove a SnowLeopard-era quirk for QuickLook
1267         https://bugs.webkit.org/show_bug.cgi?id=139208
1268         <rdar://problem/19121822>
1269
1270         Reviewed by Alexey Proskuryakov.
1271
1272         * WebCoreSupport/WebFrameLoaderClient.h:
1273         * WebCoreSupport/WebFrameLoaderClient.mm:
1274
1275 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1276
1277         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
1278         https://bugs.webkit.org/show_bug.cgi?id=139204
1279
1280         Reviewed by Anders Carlsson.
1281
1282         * WebView/WebView.mm:
1283         (-[WebView _commonInitializationWithFrameName:groupName:]):
1284         (-[WebView _showDictionaryLookupPopup:]):
1285         * WebView/WebViewData.h:
1286         Work around this by delaying the softlinking (and setting up the notification
1287         observer) until we actually need it. There's still an underlying bug, but
1288         this will fix the test.
1289
1290 2014-12-02  Beth Dakin  <bdakin@apple.com>
1291
1292         Yet another build fix.
1293
1294         * WebView/WebActionMenuController.mm:
1295         (-[WebActionMenuController _defaultMenuItemsForLink]):
1296
1297 2014-12-02  Beth Dakin  <bdakin@apple.com>
1298
1299         Build fix.
1300
1301         * WebView/WebActionMenuController.mm:
1302         (-[WebActionMenuController _defaultMenuItemsForLink]):
1303
1304 2014-12-02  Beth Dakin  <bdakin@apple.com>
1305
1306         More build fixing.
1307
1308         * WebView/WebActionMenuController.mm:
1309         (-[WebActionMenuController _defaultMenuItemsForLink]):
1310
1311 2014-12-02  Beth Dakin  <bdakin@apple.com>
1312
1313         Should use standardQuickLookMenuItem for apps that don't implement customizations
1314         https://bugs.webkit.org/show_bug.cgi?id=139193
1315         -and corresponding-
1316         rdar://problem/18944696
1317
1318         Reviewed by Anders Carlsson.
1319
1320         Use [NSMenuItem standardQuickLookMenuItem].
1321         * WebView/WebActionMenuController.mm:
1322         (-[WebActionMenuController _defaultMenuItemsForLink]):
1323
1324         Delegate methods to set up the standardQuickLookMenuItem.
1325         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
1326         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
1327         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
1328
1329         Remove all of the old QLPreviewBubble code.
1330         (-[WebActionMenuController _createActionMenuItemForTag:]):
1331         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
1332
1333 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
1334
1335         Fix the build.
1336
1337         * WebView/WebViewData.h:
1338
1339 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1340
1341         Implement Lookup transition from selection for Legacy WebKit
1342         https://bugs.webkit.org/show_bug.cgi?id=139180
1343         <rdar://problem/19067172>
1344
1345         Reviewed by Beth Dakin.
1346
1347         * WebView/DictionaryPopupInfo.h: Added.
1348         Split DictionaryPopupInfo out into its own file.
1349
1350         * WebView/WebActionMenuController.mm:
1351         (-[WebActionMenuController _lookupText:]):
1352         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
1353
1354         (performDictionaryLookupForSelection):
1355         (performDictionaryLookupForRange):
1356         Plumb the transition style through these helpers.
1357         Create a TextIndicator from the selection range.
1358
1359         * WebView/WebHTMLView.mm:
1360         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
1361         Make use of TextIndicator (and DictionaryPopupInfo, and the new
1362         _showDictionaryLookupPopup on WebView) to add a transition from blue
1363         when performing Lookup from the context menu.
1364
1365         (-[WebHTMLView quickLookWithEvent:]):
1366         Remove our TextIndicator whenever a normal three-finger-tap event
1367         comes through, as it will have its own indication.
1368
1369         * WebView/WebView.mm:
1370         (-[WebView _commonInitializationWithFrameName:groupName:]):
1371         (-[WebView _dictionaryLookupPopoverWillClose:]):
1372         Register for the LUNotificationPopoverWillClose notification and remove
1373         our TextIndicator when it is called, just like in WebKit2.
1374         Deregistration is already handled in _close.
1375
1376         (-[WebView _showDictionaryLookupPopup:]):
1377         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
1378         if the relevant API is available.
1379
1380         * WebView/WebViewInternal.h:
1381
1382 2014-12-02  Anders Carlsson  <andersca@apple.com>
1383
1384         Remove visited link handling from PageGroup
1385         https://bugs.webkit.org/show_bug.cgi?id=139185
1386
1387         Reviewed by Sam Weinig.
1388
1389         * History/WebHistory.mm:
1390         (-[WebHistoryPrivate removeItemForURLString:]):
1391         (-[WebHistoryPrivate removeAllItems]):
1392         (+[WebHistory setOptionalSharedHistory:]):
1393         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1394         (+[WebHistory _removeAllVisitedLinks]):
1395         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
1396         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
1397         * History/WebHistoryInternal.h:
1398         * WebCoreSupport/WebChromeClient.h:
1399         * WebCoreSupport/WebChromeClient.mm:
1400         (WebChromeClient::populateVisitedLinks): Deleted.
1401         * WebView/WebView.mm:
1402         (-[WebView addVisitedLinks:]):
1403         (-[WebView removeVisitedLink:]):
1404
1405 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1406
1407         Try to fix the Mac build.
1408
1409         * WebView/WebView.mm:
1410         (-[WebView _commonInitializationWithFrameName:groupName:]):
1411         (-[WebView _close]):
1412
1413 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1414
1415         Fix the iOS build.
1416
1417         * WebView/WebActionMenuController.h:
1418         * WebView/WebActionMenuController.mm:
1419         * WebView/WebHTMLView.mm:
1420         (-[WebHTMLView scrollWheel:scrollWheel:]):
1421         (-[WebHTMLView mouseDown:mouseDown:]):
1422         * WebView/WebView.mm:
1423         * WebView/WebViewData.h:
1424         * WebView/WebViewData.mm:
1425         (-[WebViewPrivate dealloc]):
1426         * WebView/WebViewInternal.h:
1427
1428 2014-12-01  Tim Horton  <timothy_horton@apple.com>
1429
1430         Implement yellow highlight for WebKit1 data detectors
1431         https://bugs.webkit.org/show_bug.cgi?id=138956
1432         <rdar://problem/18992185>
1433
1434         Reviewed by Beth Dakin.
1435
1436         * WebView/WebActionMenuController.h:
1437         * WebView/WebActionMenuController.mm:
1438         (-[WebActionMenuController webView:willHandleMouseDown:]):
1439         (-[WebActionMenuController webView:didHandleScrollWheel:]):
1440         (-[WebActionMenuController prepareForMenu:withEvent:]):
1441         (-[WebActionMenuController didCloseMenu:withEvent:]):
1442         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1443         (-[WebActionMenuController _showTextIndicator]):
1444         (-[WebActionMenuController _hideTextIndicator]):
1445         (-[WebActionMenuController _dismissActionMenuPopovers]):
1446         Copy the WebKit2 WKActionMenuController TextIndicator implementation
1447         into WebActionMenuController. The only significant difference is
1448         that we build the TextIndicator right at menu construction time
1449         instead of in the Web process.
1450
1451         * WebView/WebHTMLView.mm:
1452         (-[WebHTMLView scrollWheel:]):
1453         Let the WebActionMenuController know that we're handling a scroll.
1454
1455         (-[WebHTMLView mouseDown:]):
1456         Let the WebActionMenuController know that we're handling a mouseDown.
1457
1458         * WebView/WebView.mm:
1459         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1460         (-[WebView _clearTextIndicator]):
1461         (-[WebView _actionMenuController]):
1462         (-[WebView _convertRectFromRootView:]): Deleted.
1463         * WebView/WebViewData.h:
1464         * WebView/WebViewData.mm:
1465         * WebView/WebViewInternal.h:
1466         Keep a TextIndicatorWindow on WebView, just like WKView does.
1467         Expose the WebActionMenuController on WebView (internally).
1468
1469 2014-12-01  Anders Carlsson  <andersca@apple.com>
1470
1471         Remove old site specific quirks code that was added in 2009
1472         https://bugs.webkit.org/show_bug.cgi?id=139141
1473
1474         Reviewed by Antti Koivisto.
1475
1476         * WebCoreSupport/WebFrameNetworkingContext.h:
1477         * WebCoreSupport/WebFrameNetworkingContext.mm:
1478         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
1479
1480 2014-11-30  Anders Carlsson  <andersca@apple.com>
1481
1482         Fix a test failure.
1483
1484         * History/WebHistory.mm:
1485         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1486         Call through to the visited link store.
1487
1488         (+[WebHistory _removeAllVisitedLinks]):
1489         Ditto.
1490
1491         * WebCoreSupport/WebVisitedLinkStore.mm:
1492         (WebVisitedLinkStore::isLinkVisited):
1493         Make sure to populate visited links.
1494
1495 2014-11-30  Anders Carlsson  <andersca@apple.com>
1496
1497         Switch over to the visited link store from the WebViewGroup
1498         https://bugs.webkit.org/show_bug.cgi?id=139112
1499
1500         Reviewed by Sam Weinig.
1501
1502         * WebView/WebView.mm:
1503         (-[WebView _commonInitializationWithFrameName:groupName:]):
1504         (-[WebView setGroupName:]):
1505
1506 2014-11-30  Anders Carlsson  <andersca@apple.com>
1507
1508         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
1509         https://bugs.webkit.org/show_bug.cgi?id=139111
1510
1511         Reviewed by Sam Weinig.
1512
1513         * WebCoreSupport/WebVisitedLinkStore.h:
1514         * WebCoreSupport/WebVisitedLinkStore.mm:
1515         (WebVisitedLinkStore::removeVisitedLink):
1516         * WebView/WebView.mm:
1517         (-[WebView removeVisitedLink:]):
1518
1519 2014-11-29  Anders Carlsson  <andersca@apple.com>
1520
1521         Populate visited links
1522         https://bugs.webkit.org/show_bug.cgi?id=139101
1523
1524         Reviewed by Sam Weinig.
1525
1526         * History/WebHistory.mm:
1527         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
1528         Helper function that adds all visited link to the given store.
1529
1530         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
1531         Call the private method.
1532
1533         * History/WebHistoryInternal.h:
1534         * WebCoreSupport/WebVisitedLinkStore.h:
1535         Add new members.
1536
1537         * WebCoreSupport/WebVisitedLinkStore.mm:
1538         (WebVisitedLinkStore::addVisitedLink):
1539         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
1540
1541         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1542         Implement this. First try the delegate, then try the shared history.
1543
1544         (WebVisitedLinkStore::addVisitedLinkHash):
1545         Factor code that adds the link to the hash table into a separate function.
1546
1547         * WebView/WebView.mm:
1548         (-[WebView addVisitedLinks:]):
1549         Add the visited links to the store.
1550
1551 2014-11-29  Anders Carlsson  <andersca@apple.com>
1552
1553         More work on the legacy WebKit visited link store
1554         https://bugs.webkit.org/show_bug.cgi?id=139100
1555
1556         Reviewed by Sam Weinig.
1557
1558         * History/WebHistory.mm:
1559         (+[WebHistory setOptionalSharedHistory:]):
1560         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
1561
1562         * WebCoreSupport/WebVisitedLinkStore.h:
1563         * WebCoreSupport/WebVisitedLinkStore.mm:
1564         (visitedLinkStores):
1565         (WebVisitedLinkStore::WebVisitedLinkStore):
1566         (WebVisitedLinkStore::~WebVisitedLinkStore):
1567         Keep track of live visited link stores.
1568
1569         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
1570         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
1571
1572         (WebVisitedLinkStore::removeAllVisitedLinks):
1573         Iterate over all live link stores and remove their links.
1574
1575         (WebVisitedLinkStore::isLinkVisited):
1576         Populate visited links and check if our hash table contains the link.
1577
1578         (WebVisitedLinkStore::addVisitedLink):
1579         Add the link hash to the table.
1580
1581         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1582         Add stub.
1583
1584         (WebVisitedLinkStore::removeVisitedLinkHashes):
1585         Clear out the hash table.
1586
1587 2014-11-27  Anders Carlsson  <andersca@apple.com>
1588
1589         Add a stubbed out WebVisitedLinkStore to WebViewGroup
1590         https://bugs.webkit.org/show_bug.cgi?id=139066
1591
1592         Reviewed by Antti Koivisto.
1593
1594         * WebCoreSupport/WebViewGroup.h:
1595         (WebViewGroup::visitedLinkStore):
1596         * WebCoreSupport/WebViewGroup.mm:
1597         (WebViewGroup::WebViewGroup):
1598         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1599         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1600         (WebVisitedLinkStore::create):
1601         (WebVisitedLinkStore::WebVisitedLinkStore):
1602         (WebVisitedLinkStore::~WebVisitedLinkStore):
1603         (WebVisitedLinkStore::isLinkVisited):
1604         (WebVisitedLinkStore::addVisitedLink):
1605
1606 2014-11-25  Anders Carlsson  <andersca@apple.com>
1607
1608         Remove user content handling from PageGroup
1609         https://bugs.webkit.org/show_bug.cgi?id=139051
1610
1611         Reviewed by Antti Koivisto.
1612
1613         Use the user content controller in the web view group.
1614
1615         * WebView/WebView.mm:
1616         (-[WebView _injectOutlookQuirksScript]):
1617
1618 2014-11-25  Anders Carlsson  <andersca@apple.com>
1619
1620         Add a user content controller to WebViewGroup and use it for user content
1621         https://bugs.webkit.org/show_bug.cgi?id=139043
1622
1623         Reviewed by Antti Koivisto.
1624
1625         This is another tiny step towards getting rid of user content handling inside PageGroup.
1626
1627         * WebCoreSupport/WebViewGroup.h:
1628         (WebViewGroup::userContentController):
1629         Add a UserContentController member and getter.
1630
1631         * WebCoreSupport/WebViewGroup.mm:
1632         (WebViewGroup::get):
1633         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
1634
1635         (WebViewGroup::WebViewGroup):
1636         Create a user content controller.
1637
1638         * WebView/WebView.mm:
1639         (-[WebView _commonInitializationWithFrameName:groupName:]):
1640         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
1641         set its user content controller in the PageConfiguration.
1642
1643         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1644         Ditto.
1645
1646         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1647         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1648         (+[WebView _removeUserScriptFromGroup:world:url:]):
1649         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
1650         (+[WebView _removeUserScriptsFromGroup:world:]):
1651         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
1652         (+[WebView _removeAllUserContentFromGroup:]):
1653         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
1654
1655         (-[WebView setGroupName:]):
1656         Set the user content controller to the new WebViewGroup's user content controller.
1657
1658 2014-11-21  Jer Noble  <jer.noble@apple.com>
1659
1660         Support multiple signatures of diagnostic logging.
1661         https://bugs.webkit.org/show_bug.cgi?id=138690
1662
1663         Reviewed by Anders Carlsson.
1664
1665         Page::PageClients has been renamed PageConfiguration.
1666
1667         * WebView/WebView.mm:
1668         (-[WebView _commonInitializationWithFrameName:groupName:]):
1669         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1670
1671 2014-11-21  Zalan Bujtas  <zalan@apple.com>
1672
1673         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
1674         https://bugs.webkit.org/show_bug.cgi?id=138981
1675
1676         Reviewed by Simon Fraser.
1677
1678         * WebView/WebPreferenceKeysPrivate.h:
1679         * WebView/WebPreferences.mm:
1680         (+[WebPreferences initialize]):
1681         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
1682         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
1683         * WebView/WebPreferencesPrivate.h:
1684         * WebView/WebView.mm:
1685         (-[WebView _preferencesChanged:]):
1686
1687 2014-11-21  Tim Horton  <timothy_horton@apple.com>
1688
1689         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
1690         ​https://bugs.webkit.org/show_bug.cgi?id=138960
1691         <rdar://problem/19056715>
1692
1693         Reviewed by Anders Carlsson.
1694
1695         * WebView/WebActionMenuController.mm:
1696         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
1697         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1698         Use DataDetectors SPI instead of an explicit blacklist.
1699
1700 2014-11-21  Tim Horton  <timothy_horton@apple.com>
1701
1702         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
1703         https://bugs.webkit.org/show_bug.cgi?id=138960
1704         <rdar://problem/19056715>
1705
1706         Reviewed by Beth Dakin.
1707
1708         * WebView/WebActionMenuController.mm:
1709         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1710         Blacklist contact results, because they don't have useful menus. If we
1711         bail before setting up _currentActionContext, we'll still allow fallthrough
1712         to ordinary text actions, avoiding mysterious failure when a contact is detected.
1713
1714         This doesn't break the case that r176351 was intended to fix,
1715         because in that case we were detecting e.g. addresses.
1716
1717 2014-11-21  Anders Carlsson  <andersca@apple.com>
1718
1719         Remove the Timer parameters from timer callbacks
1720         https://bugs.webkit.org/show_bug.cgi?id=138974
1721
1722         Reviewed by Antti Koivisto.
1723
1724         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1725         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1726         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
1727         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
1728         * Plugins/WebNetscapePluginStream.h:
1729         * Plugins/WebNetscapePluginStream.mm:
1730         (WebNetscapePluginStream::WebNetscapePluginStream):
1731         (WebNetscapePluginStream::deliverDataTimerFired):
1732
1733 2014-11-21  Anders Carlsson  <andersca@apple.com>
1734
1735         Make memoryCache() return a reference
1736         https://bugs.webkit.org/show_bug.cgi?id=138939
1737
1738         Reviewed by Antti Koivisto.
1739
1740         * Misc/WebCache.mm:
1741         (+[WebCache statistics]):
1742         (+[WebCache emptyInMemoryResources]):
1743         (+[WebCache sizeOfDeadResources:]):
1744         (+[WebCache addImageToCache:forURL:forFrame:]):
1745         (+[WebCache removeImageFromCacheForURL:forFrame:]):
1746         (+[WebCache imageForURL:]):
1747         (+[WebCache setDisabled:]):
1748         (+[WebCache isDisabled]):
1749         * WebView/WebView.mm:
1750         (+[WebView _setCacheModel:]):
1751
1752 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
1753
1754         Remove the remaining vestiges of minimal-ui
1755         https://bugs.webkit.org/show_bug.cgi?id=138890
1756
1757         Reviewed by Sam Weinig.
1758
1759         * History/WebHistoryItem.mm:
1760         * History/WebHistoryItemPrivate.h:
1761
1762 2014-11-20  Tim Horton  <timothy_horton@apple.com>
1763
1764         Cancel DataDetectors menu earlier if we know it can't be presented
1765         https://bugs.webkit.org/show_bug.cgi?id=138922
1766         <rdar://problem/18950441>
1767
1768         Reviewed by Beth Dakin.
1769
1770         * WebView/WebActionMenuController.mm:
1771         (-[WebActionMenuController prepareForMenu:withEvent:]):
1772         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
1773         and use a bigger hammer (removeAllItems).
1774
1775         (-[WebActionMenuController willOpenMenu:withEvent:]):
1776         If we end up with a menu with no items, don't change selection or anything.
1777
1778 2014-11-20  Beth Dakin  <bdakin@apple.com>
1779
1780         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
1781         https://bugs.webkit.org/show_bug.cgi?id=138568
1782         -and corresponding-
1783         rdar://problem/18904600
1784
1785         Reviewed by Tim Horton.
1786
1787         Skip images for lookup.
1788         * WebView/WebActionMenuController.mm:
1789         (performDictionaryLookupForRange):
1790
1791 2014-11-19  Beth Dakin  <bdakin@apple.com>
1792
1793         Invoking an action menu on a selection should result in the text menu
1794         https://bugs.webkit.org/show_bug.cgi?id=138892
1795         -and corresponding-
1796         rdar://problem/18996776
1797
1798         Reviewed by Tim Horton.
1799
1800         * WebView/WebActionMenuController.mm:
1801         (-[WebActionMenuController _defaultMenuItems]):
1802
1803 2014-11-19  Beth Dakin  <bdakin@apple.com>
1804
1805         Data detected results with no menu items should not fall through to regular text 
1806         action menus
1807         https://bugs.webkit.org/show_bug.cgi?id=138887
1808         -and corresponding-
1809         rdar://problem/18971616
1810
1811         Reviewed by Tim Horton.
1812
1813         * WebView/WebActionMenuController.mm:
1814         (-[WebActionMenuController _defaultMenuItems]):
1815
1816 2014-11-19  Daniel Bates  <dabates@apple.com>
1817
1818         [iOS] Make WebKit build with public iOS SDK
1819         https://bugs.webkit.org/show_bug.cgi?id=136863
1820
1821         Reviewed by David Kilzer.
1822
1823         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
1824         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
1825         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
1826         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
1827         may be used by Apple internal clients that do not include wtf/Platform.h.
1828         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
1829         private Foundation headers directly.
1830         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
1831         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
1832         instead of including private CFNetwork headers directly. Also fixed up style and
1833         ordering of header include directives.
1834         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
1835         CFNetwork headers directly. Also sort the #import directives.
1836         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
1837         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
1838
1839 2014-11-18  David Kilzer  <ddkilzer@apple.com>
1840
1841         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
1842         <http://webkit.org/b/138813>
1843
1844         Reviewed by Mark Rowe.
1845
1846         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
1847         selectors.
1848
1849 2014-11-18  Chris Dumez  <cdumez@apple.com>
1850
1851         Add a setting to toggle DOMTimer throttling support
1852         https://bugs.webkit.org/show_bug.cgi?id=138844
1853         <rdar://problem/19020874>
1854
1855         Reviewed by Andreas Kling.
1856
1857         Add a setting to disable DOM timers throttling, in order to help
1858         developers determine if a specific issue is caused by timer
1859         throttling.
1860
1861         * WebView/WebPreferenceKeysPrivate.h:
1862         * WebView/WebPreferences.mm:
1863         (+[WebPreferences initialize]):
1864         (-[WebPreferences domTimersThrottlingEnabled]):
1865         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
1866         * WebView/WebPreferencesPrivate.h:
1867         * WebView/WebView.mm:
1868         (-[WebView _preferencesChanged:]):
1869
1870 2014-11-18  Tim Horton  <timothy_horton@apple.com>
1871
1872         Avoid re-encoding action menu image data
1873         https://bugs.webkit.org/show_bug.cgi?id=138817
1874         <rdar://problem/18840382>
1875
1876         Reviewed by Anders Carlsson.
1877
1878         * WebView/WebActionMenuController.mm:
1879         (-[WebActionMenuController _defaultMenuItemsForImage:]):
1880         (-[WebActionMenuController _addImageToPhotos:]):
1881         Build a temporary filename from a UUID and the image's desired extension.
1882         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
1883         Build an image menu only if we have an image, URL, data, and extension.
1884
1885 2014-11-18  Daniel Bates  <dabates@apple.com>
1886
1887         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1888         SPI are not available in public SDK
1889         https://bugs.webkit.org/show_bug.cgi?id=138802
1890
1891         Reviewed by David Kilzer.
1892
1893         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
1894         libdispatch and MobileGestalt headers directly.
1895
1896         * WebView/WebView.mm:
1897
1898 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
1899
1900         Remove calls to deprecated NSMenu methods
1901         https://bugs.webkit.org/show_bug.cgi?id=138808.
1902
1903         Reviewed by Anders Carlsson.
1904
1905         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
1906
1907         * WebCoreSupport/PopupMenuMac.mm:
1908         (PopupMenuMac::populate):
1909
1910 2014-11-17  Daniel Bates  <dabates@apple.com>
1911
1912         Unreviewed, rolling out r176232.
1913
1914         Broke the Mac build. Will investigate offline.
1915
1916         Reverted changeset:
1917
1918         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
1919         MobileGestalt"
1920         https://bugs.webkit.org/show_bug.cgi?id=138802
1921         http://trac.webkit.org/changeset/176232
1922
1923 2014-11-17  Daniel Bates  <dabates@apple.com>
1924
1925         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1926         SPI are not available in public SDK
1927         https://bugs.webkit.org/show_bug.cgi?id=138802
1928
1929         Reviewed by David Kilzer.
1930
1931         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
1932         libdispatch and MobileGestalt headers directly.
1933
1934         * WebView/WebView.mm:
1935
1936 2014-11-17  Beth Dakin  <bdakin@apple.com>
1937
1938         Whitespace action menus should focus the HitTestResult and create an insertion 
1939         point
1940         https://bugs.webkit.org/show_bug.cgi?id=138786
1941         -and corresponding-
1942         rdar://problem/18944893
1943
1944         Reviewed by Tim Horton.
1945
1946         Whitespace menus should cause the HitTestResult to be focused, and they should set 
1947         the selection based on the HitTest location.
1948
1949         * WebView/WebActionMenuController.mm:
1950         (-[WebActionMenuController isMenuForTextContent]):
1951         (-[WebActionMenuController focusAndSelectHitTestResult]):
1952         (-[WebActionMenuController willOpenMenu:withEvent:]):
1953
1954 2014-11-17  Daniel Bates  <dabates@apple.com>
1955
1956         [iOS] QuartzCore SPI not available in public SDK
1957         https://bugs.webkit.org/show_bug.cgi?id=138751
1958
1959         Reviewed by David Kilzer.
1960
1961         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
1962
1963         * WebInspector/WebNodeHighlight.mm:
1964         * WebView/WebIndicateLayer.mm:
1965
1966 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
1967
1968         [iOS] allow host application to opt-out of alternate fullscreen
1969         https://bugs.webkit.org/show_bug.cgi?id=138787
1970
1971         Reviewed by Darin Adler.
1972
1973         * WebView/WebPreferenceKeysPrivate.h:
1974         * WebView/WebPreferences.mm:
1975         (+[WebPreferences initialize]):
1976         (-[WebPreferences allowsAlternateFullscreen]):
1977         (-[WebPreferences setAllowsAlternateFullscreen:]):
1978         * WebView/WebPreferencesPrivate.h:
1979         * WebView/WebView.mm:
1980         (-[WebView _preferencesChanged:]):
1981
1982 2014-11-16  Tim Horton  <timothy_horton@apple.com>
1983
1984         Use TextIndicator instead of the built in Lookup highlight
1985         https://bugs.webkit.org/show_bug.cgi?id=138775
1986         <rdar://problem/18953982>
1987
1988         Reviewed by Anders Carlsson.
1989
1990         * WebCoreSupport/WebSystemInterface.mm:
1991         (InitWebCoreSystemInterface):
1992         Remove a WKSI import.
1993
1994         * WebView/WebActionMenuController.mm:
1995         (-[WebActionMenuController _lookupText:]):
1996         (-[WebActionMenuController _createActionMenuItemForTag:]):
1997         Make use of the new Lookup SPI header.
1998         Disable the Lookup item if lookup is not available.
1999
2000 2014-11-15  Tim Horton  <timothy_horton@apple.com>
2001
2002         Implement data detectors and mailto action menus for WebKit1
2003         https://bugs.webkit.org/show_bug.cgi?id=138765
2004         <rdar://problem/18877535>
2005
2006         Reviewed by Beth Dakin.
2007
2008         * WebView/WebActionMenuController.h:
2009         * WebView/WebActionMenuController.mm:
2010         (-[WebActionMenuController willOpenMenu:withEvent:]):
2011         Tell DataDetectors that the menu is going to open.
2012         Select the text (or not) based on the number of items in the menu, just like WebKit2.
2013
2014         (-[WebActionMenuController didCloseMenu:withEvent:]):
2015         Tell DataDetectors that the menu closed.
2016
2017         (-[WebActionMenuController _defaultMenuItemsForLink]):
2018         Move these checks out of _defaultMenuItemsForLink, because we expect this
2019         to always return a complete link menu.
2020
2021         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
2022         Implement. More or less copied from WebKit2.
2023
2024         (-[WebActionMenuController _selectDataDetectedText]):
2025         Select the stashed range.
2026
2027         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2028         Implement. More or less copied from WebKit2.
2029         The yellow highlight isn't hooked up yet.
2030         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
2031
2032         (-[WebActionMenuController _selectLookupText]):
2033         Remove an unnecessary return.
2034
2035         (-[WebActionMenuController _defaultMenuItems]):
2036         Call into the two new menu types.
2037
2038         * WebView/WebUIDelegatePrivate.h:
2039
2040 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
2041
2042         Get rid of WebFontCache
2043         https://bugs.webkit.org/show_bug.cgi?id=134752
2044
2045         Reviewed by Dave Hyatt.
2046
2047         * WebView/WebHTMLView.mm:
2048
2049 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
2050
2051         Update some artwork for the legacy WebKit action menu
2052         https://bugs.webkit.org/show_bug.cgi?id=138758
2053         <rdar://problem/18989840>
2054
2055         * WebView/WebActionMenuController.mm:
2056         (webKitBundleImageNamed): Deleted.
2057         Fix the build.
2058
2059 2014-11-14  Tim Horton  <timothy_horton@apple.com>
2060
2061         Update some artwork for the legacy WebKit action menu
2062         https://bugs.webkit.org/show_bug.cgi?id=138758
2063         <rdar://problem/18989840>
2064
2065         Reviewed by Simon Fraser.
2066
2067         * WebView/WebActionMenuController.mm:
2068         (-[WebActionMenuController _createActionMenuItemForTag:]):
2069
2070 2014-11-14  Daniel Bates  <dabates@apple.com>
2071
2072         [iOS] NSFileManager and QuickLook SPI not available in public SDK
2073         https://bugs.webkit.org/show_bug.cgi?id=138742
2074
2075         Reviewed by Pratik Solanki.
2076
2077         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
2078
2079         * WebCoreSupport/WebFrameLoaderClient.mm:
2080
2081 2014-11-14  Beth Dakin  <bdakin@apple.com>
2082
2083         WK1: Webpage preview can come up in wrong location
2084         https://bugs.webkit.org/show_bug.cgi?id=138747
2085         -and corresponding-
2086         rdar://problem/18979004
2087
2088         Reviewed by Tim Horton.
2089
2090         Converting to window twice is bad.
2091         * WebView/WebActionMenuController.mm:
2092         (elementBoundingBoxInWindowCoordinatesFromNode):
2093         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2094         (elementBoundingBoxFromNode): Deleted.
2095
2096 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
2097
2098         Move FontMac and FontCacheMac off of WKSI
2099         https://bugs.webkit.org/show_bug.cgi?id=138633
2100
2101         Reviewed by Simon Fraser.
2102
2103         * WebCoreSupport/WebSystemInterface.mm:
2104         (InitWebCoreSystemInterface):
2105         * WebKit.order:
2106
2107 2014-11-13  Beth Dakin  <bdakin@apple.com>
2108
2109         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
2110         https://bugs.webkit.org/show_bug.cgi?id=138716
2111         -and corresponding-
2112         rdar://problem/18977222
2113
2114         Reviewed by Tim Horton.
2115
2116         It’s not necessary to use the WebElementDictionary for so many things now that we 
2117         are caching the HitTestResult. We should just use the HitTestResult.
2118
2119         * WebView/WebActionMenuController.mm:
2120         (-[WebActionMenuController prepareForMenu:withEvent:]):
2121         (-[WebActionMenuController _openURLFromActionMenu:]):
2122         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2123         (elementBoundingBoxFromNode):
2124         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2125         (-[WebActionMenuController _defaultMenuItemsForLink]):
2126         (-[WebActionMenuController _defaultMenuItemsForImage]):
2127         (-[WebActionMenuController _defaultMenuItemsForVideo]):
2128         (-[WebActionMenuController _defaultMenuItemsForText]):
2129         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
2130         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
2131         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
2132         (-[WebActionMenuController _createActionMenuItemForTag:]):
2133         (-[WebActionMenuController _defaultMenuItems]):
2134         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
2135         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
2136         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
2137         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
2138         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
2139         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
2140         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
2141         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
2142         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
2143         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
2144
2145 2014-11-13  Daniel Bates  <dabates@apple.com>
2146
2147         [iOS] NSGeometry data types are not available in the public SDK
2148         https://bugs.webkit.org/show_bug.cgi?id=137536
2149
2150         Reviewed by David Kilzer.
2151
2152         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
2153         private header.
2154
2155         * DOM/WebDOMOperationsPrivate.h:
2156
2157 2014-11-13  Beth Dakin  <bdakin@apple.com>
2158
2159         WK1: Support default actions for video
2160         https://bugs.webkit.org/show_bug.cgi?id=138713
2161         -and corresponding-
2162         rdar://problem/18877520
2163
2164         Reviewed by Tim Horton.
2165
2166         Call setToNonShadowAncestor() for media HitTestResults.
2167         * WebView/WebActionMenuController.mm:
2168         (-[WebActionMenuController performHitTestAtPoint:]):
2169
2170         Default items and actions.
2171         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
2172         (-[WebActionMenuController _copyVideoURL:]):
2173         (-[WebActionMenuController _saveVideoToDownloads:]):
2174         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2175         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2176         * WebView/WebUIDelegatePrivate.h:
2177
2178 2014-11-13  Tim Horton  <timothy_horton@apple.com>
2179
2180         WK1: Update icon for Add to Reading List
2181         https://bugs.webkit.org/show_bug.cgi?id=138710
2182         <rdar://problem/18975774>
2183
2184         Reviewed by Beth Dakin.
2185
2186         * WebView/WebActionMenuController.mm:
2187         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2188         Use the right icon, matching WebKit2.
2189
2190 2014-11-12  Beth Dakin  <bdakin@apple.com>
2191
2192         WK1: Support default actions for images
2193         https://bugs.webkit.org/show_bug.cgi?id=138668
2194         -and corresponding-
2195         rdar://problem/18785434
2196
2197         Reviewed by Tim Horton.
2198
2199         * WebView/WebActionMenuController.h:
2200         * WebView/WebActionMenuController.mm:
2201         (-[WebActionMenuController didCloseMenu:withEvent:]):
2202         (-[WebActionMenuController _defaultMenuItemsForImage:]):
2203         (-[WebActionMenuController _copyImage:]):
2204         (temporaryPhotosDirectoryPath):
2205         (pathToPhotoOnDisk):
2206         (-[WebActionMenuController _canAddMediaToPhotos]):
2207         (-[WebActionMenuController _addImageToPhotos:]):
2208         (-[WebActionMenuController _saveImageToDownloads:]):
2209         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
2210         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
2211         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2212         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2213         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2214         * WebView/WebUIDelegatePrivate.h:
2215
2216 2014-11-11  Beth Dakin  <bdakin@apple.com>
2217
2218         Action menu hit testing is not working properly with all WK1 apps
2219         https://bugs.webkit.org/show_bug.cgi?id=138643
2220         -and corresponding-
2221         rdar://problem/18949376
2222
2223         Reviewed by Tim Horton.
2224
2225         * WebView/WebActionMenuController.mm:
2226         (-[WebActionMenuController prepareForMenu:withEvent:]):
2227         (-[WebActionMenuController _lookupText:]):
2228
2229 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2230
2231         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
2232         https://bugs.webkit.org/show_bug.cgi?id=138623
2233
2234         Reviewed by Geoff Garen.
2235
2236         * WebCoreSupport/WebSystemInterface.mm:
2237         (InitWebCoreSystemInterface):
2238         * WebKit.order:
2239
2240 2014-11-11  Tim Horton  <timothy_horton@apple.com>
2241
2242         Localize strings for action menus
2243         https://bugs.webkit.org/show_bug.cgi?id=138591
2244         <rdar://problem/18815343>
2245
2246         Reviewed by Dan Bates.
2247
2248         * WebView/WebActionMenuController.mm:
2249         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2250         Make use of the new strings.
2251
2252 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2253
2254         Cleanup from r175379
2255         https://bugs.webkit.org/show_bug.cgi?id=138616
2256
2257         Reviewed by Simon Fraser.
2258
2259         * WebCoreSupport/WebSystemInterface.mm:
2260         (InitWebCoreSystemInterface):
2261         * WebKit.order:
2262
2263 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2264
2265         Move CTFontTransformGlyphs out from WKSI
2266         https://bugs.webkit.org/show_bug.cgi?id=138599
2267
2268         Reviewed by Simon Fraser.
2269
2270         * WebCoreSupport/WebSystemInterface.mm:
2271         (InitWebCoreSystemInterface):
2272         * WebKit.order:
2273
2274 2014-11-11  Dan Bernstein  <mitz@apple.com>
2275
2276         More iOS build fix.
2277
2278         * WebView/WebHTMLViewInternal.h:
2279
2280 2014-11-11  Dan Bernstein  <mitz@apple.com>
2281
2282         iOS build fix.
2283
2284         * WebView/WebHTMLView.mm:
2285
2286 2014-11-10  Beth Dakin  <bdakin@apple.com>
2287
2288         WK1: Support default actions for editable text with misspelled word
2289         https://bugs.webkit.org/show_bug.cgi?id=138590
2290         -and corresponding-
2291         rdar://problem/18877506
2292
2293         Reviewed by Tim Horton.
2294
2295         If there are misspelled word suggestions for editable text, create a new type of 
2296         menu with a spelling suggestion sub-menu.
2297
2298         * WebView/WebActionMenuController.mm:
2299         (-[WebActionMenuController isMenuForTextContent]):
2300         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
2301         (-[WebActionMenuController _changeSelectionToSuggestion:]):
2302         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2303         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2304         * WebView/WebHTMLView.mm:
2305         (-[WebHTMLView _changeSpellingToWord:]):
2306         * WebView/WebHTMLViewInternal.h:
2307         * WebView/WebUIDelegatePrivate.h:
2308
2309 2014-11-10  Beth Dakin  <bdakin@apple.com>
2310
2311         WK1: Support default actions for editable whitespace
2312         https://bugs.webkit.org/show_bug.cgi?id=138586
2313         -and corresponding-
2314         rdar://problem/18932048
2315
2316         Reviewed by Tim Horton.
2317
2318         New menu type. Just wants paste.
2319
2320         * WebView/WebActionMenuController.mm:
2321         (-[WebActionMenuController isMenuForTextContent]):
2322         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
2323         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2324         * WebView/WebUIDelegatePrivate.h:
2325
2326 2014-11-10  Beth Dakin  <bdakin@apple.com>
2327
2328         WK1: Support default actions for editable text
2329         https://bugs.webkit.org/show_bug.cgi?id=138580
2330         -and corresponding-
2331         rdar://problem/18877497
2332
2333         Reviewed by Tim Horton.
2334
2335         New menu type, and new action type for paste. 
2336
2337         * WebView/WebActionMenuController.mm:
2338         (-[WebActionMenuController isMenuForTextContent]):
2339         (-[WebActionMenuController willOpenMenu:withEvent:]):
2340         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
2341         (-[WebActionMenuController _paste:]):
2342         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2343         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2344         * WebView/WebUIDelegatePrivate.h:
2345
2346 2014-11-10  Beth Dakin  <bdakin@apple.com>
2347
2348         WK1: Text is getting selected even when an action menu fails to invoke
2349         https://bugs.webkit.org/show_bug.cgi?id=138576
2350         -and corresponding-
2351         rdar://problem/18931330
2352
2353         Reviewed by Tim Horton.
2354
2355         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
2356         * WebView/WebActionMenuController.h:
2357         * WebView/WebActionMenuController.mm:
2358         (-[WebActionMenuController prepareForMenu:withEvent:]):
2359         (-[WebActionMenuController willOpenMenu:withEvent:]):
2360
2361         _selectLookupText no longer needs to return a BOOL indicating success or failure.
2362         (-[WebActionMenuController _selectLookupText]):
2363         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2364
2365         Pass willOpenMenu: on to the controller.
2366         * WebView/WebView.mm:
2367         (-[WebView willOpenMenu:withEvent:]):
2368
2369 2014-11-10  Beth Dakin  <bdakin@apple.com>
2370
2371         Speculative build fix.
2372
2373         * WebView/WebActionMenuController.mm:
2374
2375 2014-11-10  Beth Dakin  <bdakin@apple.com>
2376
2377         Action menu initialization should be moved to _commonInitializationWithFrameName
2378         https://bugs.webkit.org/show_bug.cgi?id=138572
2379         -and corresponding-
2380         rdar://problem/18929733
2381
2382         Reviewed by Tim Horton.
2383
2384         * WebView/WebView.mm:
2385         (-[WebView _commonInitializationWithFrameName:groupName:]):
2386         (-[WebView _initWithFrame:frameName:groupName:]):
2387
2388 2014-11-10  Beth Dakin  <bdakin@apple.com>
2389
2390         WK1: Support default actions for read-only text
2391         https://bugs.webkit.org/show_bug.cgi?id=138552
2392         -and corresponding-
2393         rdar://problem/18877483
2394
2395         Reviewed by Tim Horton.
2396
2397         New WKSystemInterface functions that WebCore needs to use.
2398         * WebCoreSupport/WebSystemInterface.mm:
2399         (InitWebCoreSystemInterface):
2400
2401         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
2402         makes a lot of things easier.
2403         * WebView/WebActionMenuController.h:
2404         * WebView/WebActionMenuController.mm:
2405
2406         Perform the hit test ourselves instead of calling into WebView so that we can more 
2407         easily save the WebCore::HitTestResult for ourselves.
2408         (-[WebActionMenuController performHitTestAtPoint:]):
2409
2410         Clear selection for non-text menus.
2411         (-[WebActionMenuController prepareForMenu:withEvent:]):
2412
2413         Re-set the _type here just to be safe.
2414         (-[WebActionMenuController didCloseMenu:withEvent:]):
2415
2416         Moving this method to be next to the link actions so they can be within a pragma 
2417         mark.
2418         (-[WebActionMenuController _defaultMenuItemsForLink:]):
2419
2420         New method for default text actions — lookup and copy.
2421         (-[WebActionMenuController _defaultMenuItemsForText:]):
2422         (-[WebActionMenuController _copySelection:]):
2423         (-[WebActionMenuController _lookupText:]):
2424
2425         If there is not already a selection, invoking the action menu on text should 
2426         select the lookup text.
2427         (-[WebActionMenuController _selectLookupText]):
2428         (performDictionaryLookupForSelection):
2429         (performDictionaryLookupForRange):
2430
2431         Handle text now.
2432         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2433         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2434
2435         New enum values.
2436         * WebView/WebUIDelegatePrivate.h:
2437
2438         Pass didCloseMenu on to the controller.
2439         * WebView/WebView.mm:
2440         (-[WebView didCloseMenu:withEvent:]):
2441
2442 2014-11-09  Chris Dumez  <cdumez@apple.com>
2443
2444         Add a more correct way to compare floating point numbers and use it
2445         https://bugs.webkit.org/show_bug.cgi?id=138527
2446
2447         Reviewed by Darin Adler.
2448
2449         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
2450         to compare floating-point numbers.
2451
2452         * WebView/WebHTMLView.mm:
2453         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
2454
2455 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
2456
2457         Delete cookies between tests
2458         https://bugs.webkit.org/show_bug.cgi?id=138528
2459
2460         Reviewed by Sam Weinig.
2461
2462         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
2463         * WebView/WebPreferencesPrivate.h:
2464         Added an SPI for DumpRenderTree.
2465
2466 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
2467
2468         [iOS] Update optimized fullscreen media controls
2469         https://bugs.webkit.org/show_bug.cgi?id=138493
2470
2471         Reviewed by Brent Fulgham.
2472
2473         * WebCoreSupport/WebSystemInterface.mm:
2474         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
2475
2476 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
2477
2478         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
2479         https://bugs.webkit.org/show_bug.cgi?id=138443
2480
2481         Reviewed by Anders Carlsson.
2482
2483         Wrapping the dealloc method in its own autorelease pool avoids the problem of
2484         complex tear-downs leading to the WebView itself being added to an autorelease
2485         pool that is not drained until after the instance has been dealloc'd.
2486  
2487         * WebView/WebView.mm:
2488         (-[WebView dealloc]):
2489
2490 2014-11-05  Jer Noble  <jer.noble@apple.com>
2491
2492         De-templatize Timer
2493         https://bugs.webkit.org/show_bug.cgi?id=138450
2494
2495         Reviewed by Anders Carlsson.
2496
2497         Remove template specifiers from Timer.
2498
2499         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2500         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2501         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2502         * Plugins/WebNetscapePluginStream.h:
2503         * Plugins/WebNetscapePluginStream.mm:
2504         (WebNetscapePluginStream::deliverDataTimerFired):
2505
2506 2014-11-05  Dan Bernstein  <mitz@apple.com>
2507
2508         Remove the unused deletion UI feature
2509         https://bugs.webkit.org/show_bug.cgi?id=138442
2510
2511         Rubber-stamped by Alexey Proskuryakov.
2512
2513         * DefaultDelegates/WebDefaultEditingDelegate.m:
2514         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
2515         * WebCoreSupport/WebEditorClient.h:
2516         * WebCoreSupport/WebEditorClient.mm:
2517         (WebEditorClient::shouldShowDeleteInterface): Deleted.
2518         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
2519         -webView:shouldShowDeleteInterfaceForElement:.
2520
2521 2014-11-03  Dean Jackson  <dino@apple.com>
2522
2523         Add ENABLE_FILTERS_LEVEL_2 feature guard.
2524         https://bugs.webkit.org/show_bug.cgi?id=138362
2525
2526         Reviewed by Tim Horton.
2527
2528         Add a new feature define for Level 2 of CSS Filters.
2529         http://dev.w3.org/fxtf/filters-2/
2530
2531         * Configurations/FeatureDefines.xcconfig:
2532
2533 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
2534
2535         Add button and enable optimized fullscreen.
2536         https://bugs.webkit.org/show_bug.cgi?id=138351
2537
2538         Reviewed by Eric Carlson.
2539
2540         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
2541
2542         * WebCoreSupport/WebSystemInterface.mm:
2543         (InitWebCoreSystemInterface): added
2544
2545 2014-11-04  Chris Dumez  <cdumez@apple.com>
2546
2547         Add ptr() method to Ref class
2548         https://bugs.webkit.org/show_bug.cgi?id=138361
2549
2550         Reviewed by Darin Adler.
2551
2552         Use the new Ref::ptr() method.
2553
2554         * WebView/WebFrame.mm:
2555         (-[WebFrame _setTypingStyle:withUndoAction:]):
2556         * WebView/WebHTMLView.mm:
2557         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
2558         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
2559         * WebView/WebView.mm:
2560         (-[WebView applyStyle:]):
2561
2562 2014-11-04  Darin Adler  <darin@apple.com>
2563
2564         Eliminate ResourceBuffer and use SharedBuffer directly instead
2565         https://bugs.webkit.org/show_bug.cgi?id=138174
2566
2567         Reviewed by Antti Koivisto.
2568
2569         * WebView/WebDataSource.mm:
2570         (-[WebDataSource data]): Use SharedBuffer directly.
2571         * WebView/WebHTMLView.mm:
2572         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2573
2574 2014-11-03  Commit Queue  <commit-queue@webkit.org>
2575
2576         Unreviewed, rolling out r175406, r175413, and r175423.
2577         https://bugs.webkit.org/show_bug.cgi?id=138327
2578
2579         Multipart tests are still broken (Requested by ap on #webkit).
2580
2581         Reverted changesets:
2582
2583         "Eliminate ResourceBuffer and use SharedBuffer directly
2584         instead"
2585         https://bugs.webkit.org/show_bug.cgi?id=138174
2586         http://trac.webkit.org/changeset/175406
2587
2588         "Unreviewed, iOS build fix since 175406."
2589         http://trac.webkit.org/changeset/175413
2590
2591         "Fix assertion in CachedResource::addDataBuffer"
2592         http://trac.webkit.org/changeset/175423
2593
2594 2014-10-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2595
2596         Use std::unique_ptr for TypeCountSet
2597         https://bugs.webkit.org/show_bug.cgi?id=138242
2598
2599         Reviewed by Andreas Kling.
2600
2601         * Misc/WebCoreStatistics.mm:
2602         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr.
2603         (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto.
2604
2605 2014-10-31  Beth Dakin  <bdakin@apple.com>
2606
2607         Use system art for action menus when possible
2608         https://bugs.webkit.org/show_bug.cgi?id=138260
2609
2610         Reviewed by Tim Horton.
2611
2612         * WebView/WebActionMenuController.mm:
2613         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2614
2615 2014-10-30  Darin Adler  <darin@apple.com>
2616
2617         Eliminate ResourceBuffer and use SharedBuffer directly instead
2618         https://bugs.webkit.org/show_bug.cgi?id=138174
2619
2620         Reviewed by Antti Koivisto.
2621
2622         * WebView/WebDataSource.mm:
2623         (-[WebDataSource data]): Use SharedBuffer directly.
2624         * WebView/WebHTMLView.mm:
2625         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2626
2627 2014-10-30  Jer Noble  <jer.noble@apple.com>
2628
2629         [EME] Add Setting for accessing storage location for MediaKeys data
2630         https://bugs.webkit.org/show_bug.cgi?id=138147
2631
2632         Reviewed by Brady Eidson.
2633
2634         * WebView/WebPreferenceKeysPrivate.h:
2635         * WebView/WebPreferences.mm:
2636         (+[WebPreferences initialize]): Set default location.
2637         (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor.
2638         (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter.
2639         * WebView/WebPreferencesPrivate.h:
2640         * WebView/WebView.mm:
2641         (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings.
2642
2643 2014-10-30  Dana Burkart  <dburkart@apple.com>
2644
2645         <rdar://problem/18821260> Prepare for the mysterious future
2646
2647         Reviewed by Lucas Forschler.
2648
2649         * Configurations/Base.xcconfig:
2650         * Configurations/DebugRelease.xcconfig:
2651         * Configurations/FeatureDefines.xcconfig:
2652         * Configurations/Version.xcconfig:
2653
2654 2014-10-28  Jeremy Jones  <jeremyj@apple.com>
2655
2656         Add optimized fullscreen mode.
2657         https://bugs.webkit.org/show_bug.cgi?id=138044
2658
2659         Reviewed by Jer Noble.
2660
2661         Enable different types of fullscreen video behavior.
2662         Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
2663
2664         * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
2665         * WebCoreSupport/WebChromeClient.mm:
2666         (WebChromeClient::enterVideoFullscreenForVideoElement): ditto
2667         * WebView/WebView.mm:
2668         (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
2669         (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.
2670         * WebView/WebViewInternal.h: ditto
2671
2672 2014-10-27  Beth Dakin  <bdakin@apple.com>
2673
2674         Provide a way for WebKit1 clients to override default action menu items
2675         https://bugs.webkit.org/show_bug.cgi?id=138066
2676         -and corresponding-
2677         rdar://problem/18451638
2678
2679         Reviewed by Anders Carlsson.
2680
2681         WebActionMenuController now has an ivar for the WebActionMenuType so that it can 
2682         send that along to clients customizing the menu.
2683         * WebView/WebActionMenuController.h:
2684         * WebView/WebActionMenuController.mm:
2685         (-[WebActionMenuController prepareForMenu:withEvent:]):
2686         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2687
2688         New enum and new SPI to customize menus.
2689         * WebView/WebUIDelegatePrivate.h:
2690
2691 2014-10-24  Benjamin Poulain  <bpoulain@apple.com>
2692
2693         Fix the iOS build
2694
2695         * Configurations/WebKitLegacy.xcconfig:
2696         * WebView/WebView.mm:
2697
2698 2014-10-24  Beth Dakin  <bdakin@apple.com>
2699
2700         Build fix.
2701
2702         * WebView/WebActionMenuController.mm:
2703         (-[WebActionMenuController _openURLFromActionMenu:]):
2704         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2705         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2706
2707 2014-10-24  Beth Dakin  <bdakin@apple.com>
2708
2709         WebKit1 should support action menus
2710         https://bugs.webkit.org/show_bug.cgi?id=138032
2711
2712         Reviewed by Tim Horton.
2713
2714         This patch adds basic support for action menus and adds actions for links.
2715
2716         Helper class takes care of all of the action menu work. WebView will forward the 
2717         prepareForMenu: message, and then the helper class takes it from there.
2718         * WebView/WebActionMenuController.h: Added.
2719         * WebView/WebActionMenuController.mm: Added.
2720         (-[WebActionMenuController webViewClosed]):
2721         (-[WebActionMenuController prepareForMenu:withEvent:]):
2722
2723         Selectors for link actions.
2724         (-[WebActionMenuController _openURLFromActionMenu:]):
2725         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2726         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
2727         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2728         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2729         (webKitBundleImageNamed):
2730         (-[WebActionMenuController _defaultMenuItemsForLink:]):
2731         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2732
2733         Tags for the action menu items.
2734         * WebView/WebUIDelegatePrivate.h:
2735         * WebView/WebView.mm:
2736
2737         Set the action menu if possible and create the controller.
2738         (-[WebView _initWithFrame:frameName:groupName:]):
2739         (-[WebView _close]):
2740         (-[WebView prepareForMenu:withEvent:]):
2741
2742         WebViewData stores the WebActionMenuHelper
2743         * WebView/WebViewData.h:
2744         * WebView/WebViewData.mm:
2745         (-[WebViewPrivate dealloc]):
2746
2747 2014-10-23  Joseph Pecoraro  <pecoraro@apple.com>
2748
2749         Web Inspector: Provide a way to have alternate inspector agents
2750         https://bugs.webkit.org/show_bug.cgi?id=137901
2751
2752         Reviewed by Brian Burg.
2753
2754         * Configurations/FeatureDefines.xcconfig:
2755
2756 2014-10-23  Tim Horton  <timothy_horton@apple.com>
2757
2758         Add some SPI headers for NSExtension and NSSharingService{Picker}
2759         https://bugs.webkit.org/show_bug.cgi?id=138027
2760
2761         Reviewed by Anders Carlsson.
2762
2763         * Misc/WebSharingServicePickerController.h:
2764         * Misc/WebSharingServicePickerController.mm:
2765         * WebCoreSupport/WebSelectionServiceController.mm:
2766         * WebCoreSupport/WebContextMenuClient.mm:
2767         Fix a sorting issue.
2768         Replace redefinitions with SPI header #imports.
2769
2770 2014-10-23  Tim Horton  <timothy_horton@apple.com>
2771
2772         Crashes under WebSelectionServiceController::hasRelevantSelectionServices
2773         https://bugs.webkit.org/show_bug.cgi?id=138013
2774
2775         Reviewed by Dan Bernstein.
2776
2777         * WebCoreSupport/WebSelectionServiceController.mm:
2778         (WebSelectionServiceController::hasRelevantSelectionServices):
2779         Don't adopt this autoreleased object.
2780
2781 2014-10-22  Chris Dumez  <cdumez@apple.com>
2782
2783         [Mac][WK2] Fix applicationIsSafari() detection
2784         https://bugs.webkit.org/show_bug.cgi?id=137893
2785
2786         Reviewed by Alexey Proskuryakov.
2787
2788         Provide an implementation for FrameLoaderClient's new
2789         needsQuickLookResourceCachingQuirks() that returns
2790         a static flag initialized using
2791         QuickLookMac::computeNeedsQuickLookResourceCachingQuirks().
2792
2793         * WebCoreSupport/WebFrameLoaderClient.h:
2794         * WebCoreSupport/WebFrameLoaderClient.mm:
2795
2796 2014-10-20  Chris Dumez  <cdumez@apple.com>
2797
2798         ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition
2799         https://bugs.webkit.org/show_bug.cgi?id=137797
2800
2801         Reviewed by Darin Adler.
2802
2803         Call ResourceRequest::setDomainForPartitionName() instead of
2804         setPartitionName() as the argument is a domain, not a valid
2805         partition name.
2806
2807         * Misc/WebCache.mm:
2808         (+[WebCache addImageToCache:forURL:forFrame:]):
2809         (+[WebCache removeImageFromCacheForURL:forFrame:]):
2810
2811 2014-10-20  Andy Estes  <aestes@apple.com>
2812
2813         Fix the iOS build.
2814
2815         * WebView/WebFrame.mm:
2816         (-[WebFrame getDictationResultRanges:andMetadatas:]):
2817         (-[WebFrame dictationResultMetadataForRange:]):
2818
2819 2014-10-19  Chris Dumez  <cdumez@apple.com>
2820
2821         Use is<>() / downcast<>() for all remaining RenderObject subclasses
2822         https://bugs.webkit.org/show_bug.cgi?id=137845
2823
2824         Reviewed by Darin Adler.
2825
2826         Use is<>() / downcast<>() for all remaining RenderObject subclasses and 
2827         clean up the surrounding code.
2828
2829         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2830         (-[WebHostedNetscapePluginView pluginHostDied]):
2831         * Plugins/WebBaseNetscapePluginView.mm:
2832         (-[WebBaseNetscapePluginView _windowClipRect]):
2833         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
2834         * WebCoreSupport/WebFrameLoaderClient.mm:
2835         (WebFrameLoaderClient::createPlugin):
2836         (WebFrameLoaderClient::createJavaAppletWidget):
2837
2838 2014-10-17  Tim Horton  <timothy_horton@apple.com>
2839
2840         Build fix for 32-bit Yosemite
2841
2842         * WebCoreSupport/WebContextMenuClient.mm:
2843         (WebContextMenuClient::contextMenuForEvent):
2844         Avoid using NSItemProvider in 32-bit, because it doesn't exist.
2845
2846 2014-10-17  Chris Dumez  <cdumez@apple.com>
2847
2848         Use is<>() / downcast<>() for RenderBox
2849         https://bugs.webkit.org/show_bug.cgi?id=137804
2850
2851         Reviewed by Andreas Kling.
2852
2853         Use is<>() / downcast<>() for RenderBox and clean up the surrounding
2854         code.
2855
2856         * WebCoreSupport/WebContextMenuClient.mm:
2857         (WebContextMenuClient::clientFloatRectForNode):
2858         * WebView/WebFrame.mm:
2859         (-[WebFrame renderedSizeOfNode:constrainedToWidth:]):
2860
2861 2014-10-17  Tim Horton  <timothy_horton@apple.com>
2862
2863         Fix the build with the public SDK.
2864
2865         * WebCoreSupport/WebSelectionServiceController.mm:
2866         We should transition all this SPI to real SPI headers as soon as possible.
2867
2868 2014-10-16  Tim Horton  <timothy_horton@apple.com>
2869
2870         Implement selection services menu for Legacy WebKit
2871         https://bugs.webkit.org/show_bug.cgi?id=137582
2872         <rdar://problem/18604241>
2873
2874         Reviewed by Brady Eidson.
2875
2876         * Misc/WebSharingServicePickerController.h:
2877         Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
2878         Add WebSharingServicePickerClient, which other classes can implement
2879         instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
2880         Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.
2881
2882         * Misc/WebSharingServicePickerController.mm:
2883         Pass in NSSharingServicePickerStyle, so that clients can specify the style.
2884
2885         (-[WebSharingServicePickerController clear]):
2886         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
2887         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
2888         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
2889         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
2890         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2891         Make use of WebSharingServicePickerClient.
2892
2893         (-[WebSharingServicePickerController sharingService:didShareItems:]):
2894         If we're returned a NSAttributedString, paste it on top of the current selection,
2895         similar to what the WebKit2 implementation currently does.
2896         
2897         * WebCoreSupport/WebChromeClient.h:
2898         * WebCoreSupport/WebChromeClient.mm:
2899         (WebChromeClient::handleTelephoneNumberClick):
2900         (WebChromeClient::handleSelectionServiceClick):
2901         (WebChromeClient::hasRelevantSelectionServices):
2902         Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.
2903
2904         * WebCoreSupport/WebContextMenuClient.h:
2905         * WebCoreSupport/WebContextMenuClient.mm:
2906         (WebContextMenuClient::sharingServicePickerWillBeDestroyed):
2907         (WebContextMenuClient::pageForSharingServicePicker):
2908         (WebContextMenuClient::windowForSharingServicePicker):
2909         (WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
2910         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
2911         (WebContextMenuClient::contextMenuForEvent):
2912         (WebContextMenuClient::screenRectForHitTestNode): Deleted.
2913         (WebContextMenuClient::renderedImageForControlledImage): Deleted.
2914         (WebContextMenuClient::clearSharingServicePickerController): Deleted.
2915         Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
2916         having WebSharingServicePickerController tightly bound to it.
2917         Make an NSItemProvider array when instantiating WebSharingServicePickerController
2918         instead of handing it data directly.
2919
2920         * WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
2921         * WebCoreSupport/WebSelectionServiceController.mm: Added.
2922         (WebSelectionServiceController::WebSelectionServiceController):
2923         Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
2924         for selection services.
2925
2926         (WebSelectionServiceController::handleSelectionServiceClick):
2927         Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.
2928
2929         (hasCompatibleServicesForItems):
2930         (WebSelectionServiceController::hasRelevantSelectionServices):
2931         Determine whether or not services are available.
2932
2933         (WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
2934         (WebSelectionServiceController::pageForSharingServicePicker):
2935         (WebSelectionServiceController::windowForSharingServicePicker):
2936         Implement the rest of the WebSharingServicePickerClient overrides.
2937
2938         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
2939         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
2940         These are only useful for image sharing services, so we don't need to
2941         implement them (WebContextMenuClient does, on the other hand).
2942
2943         * WebView/WebView.mm:
2944         (-[WebView _selectionServiceController]):
2945         * WebView/WebViewData.h:
2946         * WebView/WebViewData.mm:
2947         * WebView/WebViewInternal.h:
2948         Keep a WebSelectionServiceController.
2949
2950 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2951
2952         Improve debug description of WAKViews
2953         https://bugs.webkit.org/show_bug.cgi?id=137716
2954
2955         Reviewed by Simon Fraser.
2956
2957         * WebView/WebView.mm:
2958         (-[WebView _touchEventRegions]): Adding a comment.
2959
2960 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2961
2962         Addressing post-review comment.
2963         https://bugs.webkit.org/show_bug.cgi?id=137550
2964
2965         Unreviewed.
2966
2967         * WebView/WebHTMLView.mm:
2968         (fontNameForDescription):
2969         (-[WebHTMLView _addToStyle:fontA:fontB:]):
2970
2971 2014-10-14  Chris Dumez  <cdumez@apple.com>
2972
2973         Use is<>() / downcast<>() for RenderImage
2974         https://bugs.webkit.org/show_bug.cgi?id=137683
2975
2976         Reviewed by Mihnea Ovidenie.
2977
2978         Use is<>() / downcast<>() for RenderImage.
2979
2980         * Misc/WebNSPasteboardExtras.mm:
2981         (imageFromElement):
2982         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2983
2984 2014-10-10  Daniel Bates  <dabates@apple.com>
2985
2986         Remove unused classes WebRender{Node, Layer}
2987         https://bugs.webkit.org/show_bug.cgi?id=137628
2988
2989         Reviewed by Simon Fraser.
2990
2991         We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
2992         For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.
2993
2994         * Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list
2995         of excluded source files when building for iOS.
2996         * WebKit.exp: Remove symbol for WebRenderLayer.
2997         * WebKit.mac.exp: Remove symbol for WebRenderNode.
2998         * WebView/WebRenderLayer.h: Removed.
2999         * WebView/WebRenderLayer.mm: Removed.
3000         * WebView/WebRenderNode.h: Removed.
3001         * WebView/WebRenderNode.mm: Removed.
3002
3003 2014-10-10  Chris Dumez  <cdumez@apple.com>
3004
3005         Use is<>() / downcast<>() for RenderBoxModelObject
3006         https://bugs.webkit.org/show_bug.cgi?id=137587
3007
3008         Reviewed by Mihnea Ovidenie.
3009
3010         Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
3011         surrounding code.
3012
3013         * Plugins/WebBaseNetscapePluginView.mm:
3014         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
3015         * WebView/WebRenderLayer.mm:
3016         (-[WebRenderLayer initWithWebFrame:]):
3017
3018 2014-10-09  Dean Jackson  <dino@apple.com>
3019
3020         Remove ENABLE_CSS3_CONDITIONAL_RULES
3021         https://bugs.webkit.org/show_bug.cgi?id=137571
3022
3023         Reviewed by Simon Fraser.
3024
3025         * Configurations/FeatureDefines.xcconfig:
3026
3027 2014-10-09  Tim Horton  <timothy_horton@apple.com>
3028
3029         Add a WebKit1 preference for selection services
3030         https://bugs.webkit.org/show_bug.cgi?id=137498
3031         <rdar://problem/18572699>
3032
3033         Reviewed by Simon Fraser.
3034
3035         * WebView/WebPreferenceKeysPrivate.h:
3036         * WebView/WebPreferences.mm:
3037         (+[WebPreferences initialize]):
3038         (-[WebPreferences serviceControlsEnabled]):
3039         (-[WebPreferences setServiceControlsEnabled:]):
3040         * WebView/WebPreferencesPrivate.h:
3041         * WebView/WebView.mm:
3042         (-[WebView _preferencesChanged:]):
3043         Add and plumb the preference.
3044
3045 2014-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
3046
3047         Remove second-to-last client of WebFontCache
3048         https://bugs.webkit.org/show_bug.cgi?id=137550
3049
3050         Reviewed by Darin Adler.
3051
3052         Use FontCache::getCachedFontData() instead of WebFontCache.
3053
3054         * WebView/WebHTMLView.mm:
3055         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3056
3057 2014-10-09  Chris Dumez  <cdumez@apple.com>
3058
3059         Use is<>() / downcast<>() for Widget subclasses
3060         https://bugs.webkit.org/show_bug.cgi?id=137549
3061
3062         Reviewed by Darin Adler.
3063
3064         Use is<>() / downcast<>() for Widget subclasses and clean up the
3065         surrounding code.
3066
3067         * WebView/WebRenderNode.mm:
3068         (copyRenderNode):
3069         * WebView/WebView.mm:
3070         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
3071
3072 2014-10-07  Christophe Dumez  <cdumez@apple.com>
3073
3074         Use is<>() / downcast<>() for RenderText / RenderTextFragment
3075         https://bugs.webkit.org/show_bug.cgi?id=137476
3076
3077         Reviewed by Darin Adler.
3078
3079         * WebView/WebRenderNode.mm:
3080         (copyRenderNode):
3081
3082 2014-10-06  Dan Bernstein  <mitz@apple.com>
3083
3084         Build fix.
3085
3086         * Misc/WebCache.mm:
3087         (+[WebCache imageForURL:]):
3088
3089 2014-10-06  Chris Dumez  <cdumez@apple.com>
3090
3091         Unreviewed build fix after r174333.
3092
3093         Forgot explicit WebCore:: namespace.
3094
3095         * Misc/WebCache.mm:
3096         (+[WebCache imageForURL:]):
3097
3098 2014-10-05  Christophe Dumez  <cdumez@apple.com>
3099
3100         Use is<>() / downcast<>() for CachedResource subclasses
3101         https://bugs.webkit.org/show_bug.cgi?id=137431
3102
3103         Reviewed by Benjamin Poulain.
3104
3105         Use is<>() / downcast<>() for CachedResource subclasses.
3106
3107         * Misc/WebCache.mm:
3108         (+[WebCache imageForURL:]):
3109
3110 2014-10-02  Daniel Bates  <dabates@apple.com>
3111
3112         Use version number 101000 instead of 10100 for OS X Yosemite
3113         https://bugs.webkit.org/show_bug.cgi?id=137372
3114
3115         Reviewed by Mark Rowe.
3116
3117         The version number for OS X Yosemite is 101000.
3118
3119         * WebView/WebView.mm:
3120         (-[WebView _preferencesChanged:]):
3121
3122 2014-10-02  Tim Horton  <timothy_horton@apple.com>
3123
3124         Move PageOverlay[Controller] to WebCore
3125         https://bugs.webkit.org/show_bug.cgi?id=137164
3126         <rdar://problem/18508258>
3127
3128         Reviewed by Anders Carlsson.
3129
3130         * WebCoreSupport/WebChromeClient.h:
3131         * WebCoreSupport/WebChromeClient.mm:
3132         (WebChromeClient::attachViewOverlayGraphicsLayer):
3133         Add an empty ChromeClient override.
3134
3135 2014-10-01  Christophe Dumez  <cdumez@apple.com>
3136
3137         Have is<>(T*) function do a null check on the pointer argument
3138         https://bugs.webkit.org/show_bug.cgi?id=137333
3139
3140         Reviewed by Gavin Barraclough.
3141
3142         Have is<>(T*) function do a null check on the argument instead of a
3143         simple assertion. This makes sense for 2 reasons:
3144         1. It is more consistent with downcast<>(T*), which will succeed even
3145            if the argument is a nullptr.
3146         2. It simplifies the code a bit as it gets rid of a lot of explicit
3147            null checks.
3148
3149         * WebCoreSupport/WebChromeClient.mm:
3150         (WebChromeClient::focusedElementChanged):
3151         * WebCoreSupport/WebEditorClient.mm:
3152         (WebEditorClient::textFieldDidBeginEditing):
3153         (WebEditorClient::textFieldDidEndEditing):
3154         (WebEditorClient::textDidChangeInTextField):
3155         (WebEditorClient::doTextFieldCommandFromEvent):
3156         (WebEditorClient::textWillBeDeletedInTextField):
3157         (WebEditorClient::textDidChangeInTextArea):
3158         * WebView/WebHTMLRepresentation.mm:
3159         (inputElementFromDOMElement):
3160         (searchForLabelsBeforeElement):
3161         * WebView/WebRenderLayer.mm:
3162         (+[WebRenderLayer nameForLayer:]):
3163
3164 2014-10-01  Mark Rowe  <mrowe@apple.com>
3165
3166         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
3167
3168         Reviewed by Dan Bernstein.
3169
3170         * Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite.
3171
3172 2014-09-30  Chris Dumez  <cdumez@apple.com>
3173
3174         Use is<>() / downcast<>() for Element
3175         https://bugs.webkit.org/show_bug.cgi?id=137241
3176
3177         Reviewed by Andreas Kling.
3178
3179         Use is<>() / downcast<>() for Element instead of isElementNode() /
3180         toElement().
3181
3182         * WebView/WebRenderLayer.mm:
3183         (+[WebRenderLayer nameForLayer:]):
3184
3185 2014-09-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3186
3187         Move ColorInputType class to std::unique_ptr
3188         https://bugs.webkit.org/show_bug.cgi?id=137173
3189
3190         Reviewed by Darin Adler.
3191
3192         Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr.
3193         Child classes follow this change as well.
3194
3195         * WebCoreSupport/WebChromeClient.h:
3196         * WebCoreSupport/WebChromeClient.mm:
3197         (WebChromeClient::createColorChooser):
3198
3199 2014-09-24  Christophe Dumez  <cdumez@apple.com>
3200
3201         Add initial is<>() / downcast<>() support for any type of Nodes
3202         https://bugs.webkit.org/show_bug.cgi?id=137056
3203
3204         Reviewed by Benjamin Poulain.
3205
3206         Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
3207         instead of isFormControlElement() / toHTMLFormControlElement().
3208
3209         * WebView/WebHTMLRepresentation.mm:
3210         (searchForLabelsBeforeElement):
3211
3212 2014-09-24  Christophe Dumez  <cdumez@apple.com>
3213
3214         Use is<HTML*Element>() instead of isHTML*Element() - Part 1
3215         https://bugs.webkit.org/show_bug.cgi?id=137068
3216
3217         Reviewed by Ryosuke Niwa.
3218
3219         Start using is<HTML*Element>() instead of isHTML*Element().
3220         Remaining usages will be updated in a follow-up patch to
3221         reduce the size of the change.
3222
3223         * WebCoreSupport/WebChromeClient.mm:
3224         (WebChromeClient::focusedElementChanged):
3225         * WebCoreSupport/WebEditorClient.mm:
3226         (WebEditorClient::textFieldDidBeginEditing):
3227         (WebEditorClient::textFieldDidEndEditing):
3228         (WebEditorClient::textDidChangeInTextField):
3229         (WebEditorClient::doTextFieldCommandFromEvent):
3230         (WebEditorClient::textWillBeDeletedInTextField):
3231         (WebEditorClient::textDidChangeInTextArea):
3232         * WebView/WebHTMLRepresentation.mm:
3233         (inputElementFromDOMElement):
3234
3235 2014-09-21  Timothy Hatcher  <timothy@apple.com>
3236
3237         Make the Web Inspector use a separate web process.
3238
3239         https://bugs.webkit.org/show_bug.cgi?id=135120
3240
3241         Reviewed by Anders Carlsson.
3242
3243         * WebCoreSupport/WebInspectorClient.h:
3244         * WebCoreSupport/WebInspectorClient.mm:
3245         (WebInspectorClient::WebInspectorClient):
3246         (WebInspectorClient::openInspectorFrontend):
3247         (WebInspectorClient::releaseFrontend):
3248         Own WebInspectorFrontendClient instead of moving it.
3249
3250 2014-09-23  Chris Dumez  <cdumez@apple.com>
3251
3252         Use downcast<HTML*Element>() instead of toHTML*Element()
3253         https://bugs.webkit.org/show_bug.cgi?id=137007
3254
3255         Reviewed by Benjamin Poulain.
3256
3257         Use downcast<HTML*Element>() instead of toHTML*Element().
3258
3259         * DOM/WebDOMOperations.mm:
3260         (-[DOMHTMLInputElement _setAutofilled:]):
3261         * WebCoreSupport/WebChromeClient.mm:
3262         (WebChromeClient::focusedElementChanged):
3263         * WebCoreSupport/WebEditorClient.mm:
3264         (WebEditorClient::textFieldDidBeginEditing):
3265         (WebEditorClient::textFieldDidEndEditing):
3266         (WebEditorClient::textDidChangeInTextField):
3267         (WebEditorClient::doTextFieldCommandFromEvent):
3268         (WebEditorClient::textWillBeDeletedInTextField):
3269         (WebEditorClient::textDidChangeInTextArea):
3270         * WebView/WebHTMLRepresentation.mm:
3271         (inputElementFromDOMElement):
3272
3273 2014-09-21  Chris Dumez  <cdumez@apple.com>
3274
3275         Generate Element casting helper functions
3276         https://bugs.webkit.org/show_bug.cgi?id=136839
3277
3278         Reviewed by Darin Adler.
3279
3280         Use JSXXX::toWrapped() instead of toXXX() function.
3281
3282         * DOM/WebDOMOperations.mm:
3283         * WebView/WebView.mm:
3284         (-[WebView _notificationIDForTesting:]):
3285
3286 2014-09-21  Joseph Pecoraro  <pecoraro@apple.com>
3287
3288         Leak: WebNotificationPrivate ObjC leaks seen on leaks bot
3289         https://bugs.webkit.org/show_bug.cgi?id=136972
3290
3291         Reviewed by Darin Adler.
3292
3293         * WebView/WebNotification.h:
3294         * WebView/WebNotification.mm:
3295         (-[WebNotification initWithCoreNotification:notificationID:]):
3296         Switch to RetainPtr and adopt into _private to ensure when we are
3297         deallocated that _private will get deallocated.
3298
3299 2014-09-19  Dean Jackson  <dino@apple.com>
3300
3301         Multithreaded WebGL is a bad idea - remove it
3302         https://bugs.webkit.org/show_bug.cgi?id=136964
3303         <rdar://problem/18399858>
3304
3305         Reviewed by Brent Fulgham.
3306
3307         Remove the setting to allow multithreaded WebGL.
3308
3309         * WebView/WebPreferenceKeysPrivate.h:
3310         * WebView/WebPreferences.mm:
3311         (+[WebPreferences initialize]):
3312         (-[WebPreferences multithreadedWebGLEnabled]): Deleted.
3313         (-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted.
3314         * WebView/WebPreferencesPrivate.h:
3315         * WebView/WebView.mm:
3316         (-[WebView _preferencesChanged:]):
3317
3318 2014-09-19  Daniel Bates  <dabates@apple.com>
3319
3320         Always assume internal SDK when building configuration Production
3321         https://bugs.webkit.org/show_bug.cgi?id=136925
3322         <rdar://problem/18362399>
3323
3324         Reviewed by Dan Bernstein.
3325
3326         As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
3327         and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.
3328
3329         * Configurations/Base.xcconfig:
3330
3331 2014-09-17  Daniel Bates  <dabates@apple.com>
3332
3333         Unreviewed, rolling out r173695.
3334
3335         Broke building third-party Legacy WebKit apps; will
3336         investigate offline
3337
3338         Reverted changeset:
3339
3340         "[iOS] Make WebCore build with public iOS SDK"
3341         https://bugs.webkit.org/show_bug.cgi?id=136487
3342         http://trac.webkit.org/changeset/173695
3343
3344 2014-09-17  Daniel Bates  <dabates@apple.com>
3345
3346         [iOS] Make WebCore build with public iOS SDK
3347         https://bugs.webkit.org/show_bug.cgi?id=136487
3348
3349         Reviewed by David Kilzer.
3350
3351         Update WebKit1 source files to include the wrapper SPI headers instead of the corresponding
3352         actual SPI header(s).
3353
3354         * DOM/WebDOMOperationsPrivate.h:
3355         * MigrateHeaders.make: Modified to only modify the include path of a "<WebCore/"-prefixed header
3356         file if its filename doesn't end in "SPI.h" as an alternative to having MigrateHeaders.make copy
3357         such files into the WebKit framework as private headers.
3358         * WebCoreSupport/WebFrameLoaderClient.mm:
3359         * WebInspector/WebNodeHighlight.mm:
3360         * WebView/WebIndicateLayer.mm:
3361         * WebView/WebRenderLayer.h:
3362         * WebView/WebView.mm:
3363
3364 2014-09-16  Daniel Bates  <dabates@apple.com>
3365
3366         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
3367         https://bugs.webkit.org/show_bug.cgi?id=136862
3368
3369         Reviewed by David Kilzer.
3370
3371         * Configurations/DebugRelease.xcconfig:
3372
3373 2014-09-16  Enrica Casucci  <enrica@apple.com>
3374
3375         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
3376         https://bugs.webkit.org/show_bug.cgi?id=136474
3377
3378         Reviewed by Benjamin Poulain.
3379
3380         This is the updated version of the patch that was landed in r173340.
3381         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
3382         and removes the assumption that EAffinity values match NSSelectionAffinity
3383         values. It also removes the includes in TextAffinity.h, creating the need to
3384         include explicitly the files when necessary.
3385
3386         * WebCoreSupport/WebEditorClient.h:
3387         (kit):
3388         (core):
3389
3390 2014-09-14  Daniel Bates  <dabates@apple.com>
3391
3392         [iOS] Attempt to fix the iOS build after <http://trac.webkit.org/changeset/173606>
3393         (https://bugs.webkit.org/show_bug.cgi?id=136789)
3394
3395         Substitute Node::countChildNodes() for Node::childNodeCount() in more places.
3396
3397         * WebView/WebFrame.mm:
3398         (-[WebFrame focusedNodeHasContent]):
3399
3400 2014-09-14  Chris Dumez  <cdumez@apple.com>
3401
3402         Rename Node::childNodeCount() to countChildNodes() and avoid inefficient uses
3403         https://bugs.webkit.org/show_bug.cgi?id=136789
3404
3405         Reviewed by Darin Adler.
3406
3407         Rename childNodeCount() to countChildNodes().
3408
3409         * WebView/WebHTMLView.mm:
3410         (-[WebHTMLView attributedString]):
3411
3412 2014-09-10  Jon Honeycutt  <jhoneycutt@apple.com>
3413
3414         Re-add the request autocomplete feature
3415
3416         <https://bugs.webkit.org/show_bug.cgi?id=136730>
3417
3418         This feature was rolled out in r148731 because it was only used by
3419         Chromium. As we consider supporting this feature, roll it back in, but
3420         leave it disabled.
3421
3422         This rolls out r148731 (which removed the feature) with small changes
3423         needed to make the code build in ToT, to match modern style, to make
3424         the tests run, and to remove unused code.
3425
3426         Reviewed by Andy Estes.
3427
3428         * Configurations/FeatureDefines.xcconfig:
3429         * WebCoreSupport/WebFrameLoaderClient.h:
3430
3431 2014-09-12  Commit Queue  <commit-queue@webkit.org>
3432
3433         Unreviewed, rolling out r173575.
3434         https://bugs.webkit.org/show_bug.cgi?id=136790
3435
3436         Failing tests (Requested by enrica on #webkit).
3437
3438         Reverted changeset:
3439
3440         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
3441         https://bugs.webkit.org/show_bug.cgi?id=136474
3442         http://trac.webkit.org/changeset/173575
3443
3444 2014-09-12  Enrica Casucci  <enrica@apple.com>
3445
3446         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
3447         https://bugs.webkit.org/show_bug.cgi?id=136474
3448
3449         Reviewed by Benjamin Poulain.
3450
3451         This is the updated version of the patch that was landed in r173340.
3452         I changed the use of IntPoint to FloatPoint since it was causing tests
3453         to fail.
3454         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
3455         and removes the assumption that EAffinity values match NSSelectionAffinity
3456         values. It also removes the includes in TextAffinity.h, creating the need to
3457         include explicitly the files when necessary. It also removes the unnecessary
3458         use of platform specific types, replacing them with WebCore types.
3459
3460         * WebCoreSupport/WebEditorClient.h:
3461         (kit):
3462         (core):
3463         * WebView/WebFrameView.mm:
3464         (-[WebFrameView _scrollToBeginningOfDocument]):
3465         (-[WebFrameView _scrollToEndOfDocument]):
3466
3467 2014-09-11  Bear Travis  <betravis@adobe.com>
3468
3469         [CSS Font Loading] Enable CSS Font Loading on Mac
3470         https://bugs.webkit.org/show_bug.cgi?id=135473
3471
3472         Reviewed by Antti Koivisto.
3473
3474         Enable CSS Font Loading in FeatureDefines.
3475
3476         * Configurations/FeatureDefines.xcconfig:
3477
3478 2014-09-11  Beth Dakin  <bdakin@apple.com>
3479
3480         Support rubber-banding in sub-frames
3481         https://bugs.webkit.org/show_bug.cgi?id=136726
3482         -and corresponding-
3483         rdar://problem/10011924
3484
3485         Reviewed by Tim Horton.
3486
3487         rubberBandingForOverflowScrollEnabled is re-named to
3488         rubberBandingForSubScrollableRegionsEnabled
3489         * WebView/WebView.mm:
3490         (-[WebView _preferencesChanged:]):
3491
3492 2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
3493
3494         Disable the "unreachable-code" warning
3495         https://bugs.webkit.org/show_bug.cgi?id=136677
3496
3497         Reviewed by Darin Adler.
3498
3499         * Configurations/Base.xcconfig:
3500
3501 2014-09-08  Maciej Stachowiak  <mjs@apple.com>
3502
3503         Fix 32-bit Mac build for new warnings
3504         https://bugs.webkit.org/show_bug.cgi?id=136624
3505
3506         Reviewed by Darin Adler.
3507         
3508         (Jessie already fixed this but my version with typedefs seems a tiny bit cleaner.)
3509
3510         * Carbon/HIViewAdapter.m:
3511         (+[HIViewAdapter bindHIViewToNSView:nsView:]): Need to use explicit casting now.
3512
3513 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3514
3515         Remove FILTERS flag
3516         https://bugs.webkit.org/show_bug.cgi?id=136571
3517
3518         Reviewed by Darin Adler.
3519
3520         * Configurations/FeatureDefines.xcconfig:
3521
3522 2014-09-08  Jessie Berlin  <jberlin@apple.com>
3523
3524         32-bit build fix after r173364.
3525
3526         * Carbon/HIViewAdapter.m:
3527         (+[HIViewAdapter bindHIViewToNSView:nsView:]):
3528
3529 2014-09-08  Dan Bernstein  <mitz@apple.com>
3530
3531         Build fix.
3532
3533         Added back SPI that is still in use.
3534
3535         * Misc/WebNSURLExtras.h:
3536         * Misc/WebNSURLExtras.mm:
3537         (-[NSURL _webkit_URLByRemovingFragment]):
3538
3539 2014-09-08  Dan Bernstein  <mitz@apple.com>
3540
3541         iOS Simulator build fix.
3542
3543         * Misc/WebKitSystemBits.m:
3544         (WebMemorySize):
3545
3546 2014-09-07  Darin Adler  <darin@apple.com>
3547
3548         Fix build failure seen on Mountain Lion buildbot.
3549
3550         * Misc/WebNSDataExtras.h: Make WEB_GUESS_MIME_TYPE_PEEK_LENGTH an unsigned instead
3551         of an int, to avoid warning about mixing signs.
3552
3553 2014-09-06  Darin Adler  <darin@apple.com>
3554
3555         Make updates suggested by new version of Xcode
3556         https://bugs.webkit.org/show_bug.cgi?id=136603
3557
3558         Reviewed by Mark Rowe.
3559
3560         * Configurations/Base.xcconfig: Added CLANG_WARN_UNREACHABLE_CODE, COMBINE_HIDPI_IMAGES,
3561         and ENABLE_STRICT_OBJC_MSGSEND as suggested by Xcode upgrade check.
3562
3563         * History/WebURLsWithTitles.m:
3564         (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): Use NSUInteger instead of
3565         unsigned for correctness, and to quiet the 32-to-64-bit compiler warning (which is
3566         not turned on because it gives us too many false positives).
3567         * Misc/WebElementDictionary.mm:
3568         (-[WebElementDictionary objectForKey:]): Ditto.
3569         * Misc/WebNSDataExtras.m:
3570         (-[NSData _webkit_guessedMIMETypeForXML]): Ditto.
3571         (-[NSData _webkit_guessedMIMEType]): Ditto.
3572         (-[NSData _webkit_parseRFC822HeaderFields]): Ditto.
3573         (-[NSData _web_locationAfterFirstBlankLine]): Ditto.
3574
3575         * Misc/WebNSURLExtras.h: Removed unused _web_URLWithLowercasedScheme, _web_hostData,
3576