Occasional null deref in WebImmediateActionController
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2015-05-07  Timothy Horton  <timothy_horton@apple.com>
2
3         Occasional null deref in WebImmediateActionController
4         https://bugs.webkit.org/show_bug.cgi?id=144772
5         <rdar://problem/20811128>
6
7         Reviewed by Beth Dakin.
8
9         * WebView/WebImmediateActionController.mm:
10         (-[WebImmediateActionController _defaultAnimationController]):
11         (-[WebImmediateActionController _animationControllerForDataDetectedText]):
12         (-[WebImmediateActionController _animationControllerForDataDetectedLink]):
13         Null-check TextIndicators before dereferencing.
14
15 2015-05-07  Beth Dakin  <bdakin@apple.com>
16
17         New force-related DOM events should fire in WK1 views
18         https://bugs.webkit.org/show_bug.cgi?id=144663
19         -and corresponding-
20         rdar://problem/20281886
21
22         Reviewed by Sam Weinig.
23
24         Pass the lastPressureEvent to WebCore.
25         * WebView/WebHTMLView.mm:
26         (-[WebHTMLView _updateMouseoverWithEvent:]):
27         (-[WebHTMLView rightMouseUp:]):
28         (-[WebHTMLView menuForEvent:]):
29         (-[WebHTMLView acceptsFirstMouse:]):
30         (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
31         (-[WebHTMLView mouseDown:mouseDown:]):
32         (-[WebHTMLView mouseDragged:]):
33         (-[WebHTMLView mouseUp:mouseUp:]):
34
35         New NSRespnder method for pressure changes.
36         (-[WebHTMLView pressureChangeWithEvent:]):
37
38         New BOOL _contentPreventsDefault tracks whether the HitTestResult prevented the 
39         default action. Get rid of willHandleMouseDown; now that the gesture recognizer 
40         sets delaysPrimaryMouseButtonEvents to NO, we don’t need this.
41         * WebView/WebImmediateActionController.h:
42         * WebView/WebImmediateActionController.mm:
43         (-[WebImmediateActionController _clearImmediateActionState]):
44
45         Set all of the immediateActionStages on EventHandler. This is critical to keep 
46         link navigation happening at the right time now that 
47         delaysPrimaryMouseButtonEvents is set to NO.
48         (-[WebImmediateActionController performHitTestAtPoint:]):
49         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
50         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
51         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
52
53         Use a dummy animation controller if the content prevents default.
54         (-[WebImmediateActionController _defaultAnimationController]):
55         (-[WebImmediateActionController _updateImmediateActionItem]):
56         (-[WebImmediateActionController webView:willHandleMouseDown:]): Deleted.
57
58         Set delaysPrimaryMouseButtonEvents to NO so that we get existing mouse events when 
59         we expect to.
60         * WebView/WebView.mm:
61         (-[WebView _commonInitializationWithFrameName:groupName:]):
62
63         Cache the most recent pressure event so that we can send it to WebCore for all of 
64         the mouse events.
65         (-[WebView _pressureEvent]):
66         (-[WebView _setPressureEvent:]):
67         * WebView/WebViewData.h:
68         * WebView/WebViewData.mm:
69         (-[WebViewPrivate dealloc]):
70         * WebView/WebViewInternal.h:
71
72 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
73
74         Revert "Introducing the Platform Abstraction Layer (PAL)"
75         https://bugs.webkit.org/show_bug.cgi?id=144751
76
77         Unreviewed.
78
79         PAL should be a new target inside WebCore, rather than a top-level folder.
80
81         * Configurations/FeatureDefines.xcconfig: Updated
82
83 2015-05-07  Dan Bernstein  <mitz@apple.com>
84
85         <rdar://problem/19317140> [Xcode] Remove usage of AspenFamily.xcconfig in Source/
86         https://bugs.webkit.org/show_bug.cgi?id=144727
87
88         Reviewed by Darin Adler.
89
90         * Configurations/Base.xcconfig: Don’t include AspenFamily.xcconfig.
91         * Configurations/WebKitLegacy.xcconfig: Define INSTALL_PATH in terms of
92         INSTALL_PATH_PREFIX and INSTALL_PATH_ACTUAL, and define INSTALL_PATH_PREFIX for the iOS 8.x
93         Simulator.
94
95 2015-04-02  Myles C. Maxfield  <mmaxfield@apple.com>
96
97         Introducing the Platform Abstraction Layer (PAL)
98         https://bugs.webkit.org/show_bug.cgi?id=143358
99
100         Reviewed by Simon Fraser.
101
102         * Configurations/FeatureDefines.xcconfig: Updated
103
104 2015-05-06  Antti Koivisto  <antti@apple.com>
105
106         REGRESSION (r183467): Unable to start downloads in private browsing mode
107         https://bugs.webkit.org/show_bug.cgi?id=144533
108
109         Reviewed by Darin Adler.
110
111         * WebCoreSupport/WebFrameLoaderClient.mm:
112         (WebFrameLoaderClient::dispatchWillSendRequest):
113
114             Use updateFromDelegatePreservingOldProperties (like WK2) instead of doing the same thing manually.
115
116 2015-05-06  Ryosuke Niwa  <rniwa@webkit.org>
117
118         Toggling underline on font panel removes strike through
119         https://bugs.webkit.org/show_bug.cgi?id=144670
120         <rdar://problem/3790443>
121
122         Reviewed by Darin Adler.
123
124         Use setStrikeThroughChange and setUnderlineChange added in r183770 to toggle underline and strike through.
125
126         * WebView/WebHTMLView.mm:
127         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
128         (-[WebHTMLView _styleForAttributeChange:]):
129         (-[WebHTMLView changeAttributes:]):
130
131 2015-05-04  Ryosuke Niwa  <rniwa@webkit.org>
132
133         Toggling underline or strike through affects each other
134         https://bugs.webkit.org/show_bug.cgi?id=27818
135
136         Reviewed by Darin Adler.
137
138         * WebView/WebFrame.mm:
139         (-[WebFrame _setTypingStyle:withUndoAction:]):
140
141 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
142
143         USE(...) macro should expect unprefixed variables
144         https://bugs.webkit.org/show_bug.cgi?id=144454
145
146         Reviewed by Daniel Bates.
147
148         * Misc/WebDownload.h: Replace all occurrences WTF_USE with USE.
149
150 2015-05-01  Brady Eidson  <beidson@apple.com>
151
152         Add API to disable meta refreshes.
153         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
154
155         Reviewed by Alexey Proskuryakov.
156
157         Add a preference to enable/disable meta refreshes, enabled by default.
158
159         * WebView/WebPreferenceKeysPrivate.h:
160         * WebView/WebPreferences.mm:
161         (+[WebPreferences initialize]):
162         (-[WebPreferences setMetaRefreshEnabled:]):
163         (-[WebPreferences metaRefreshEnabled]):
164         * WebView/WebPreferencesPrivate.h:
165         * WebView/WebView.mm:
166         (-[WebView _preferencesChanged:]):
167
168 2015-04-30  Jon Davis  <jond@apple.com>
169
170         Web Inspector: console should show an icon for console.info() messages
171         https://bugs.webkit.org/show_bug.cgi?id=18530
172
173         Reviewed by Timothy Hatcher.
174
175         * WebCoreSupport/WebChromeClient.mm:
176         (stringForMessageLevel):
177         * WebView/WebUIDelegatePrivate.h:
178
179 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
180
181         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
182         https://bugs.webkit.org/show_bug.cgi?id=132159
183
184         Reviewed by Darin Adler.
185
186         Add SPI to set the font whitelist.
187
188         * WebView/WebView.mm:
189         (+[WebView _setFontWhitelist:]):
190         * WebView/WebViewPrivate.h:
191
192 2015-04-28  Timothy Horton  <timothy_horton@apple.com>
193
194         [TextIndicator] Yellow highlight takes too long to fade out on scroll
195         https://bugs.webkit.org/show_bug.cgi?id=144358
196         <rdar://problem/19451011>
197
198         Reviewed by Beth Dakin.
199
200         * WebView/WebActionMenuController.mm:
201         (-[WebActionMenuController _showTextIndicator]):
202         * WebView/WebHTMLView.mm:
203         (-[WebHTMLView quickLookWithEvent:]):
204         * WebView/WebImmediateActionController.mm:
205         (-[WebImmediateActionController _defaultAnimationController]):
206         (-[WebImmediateActionController _animationControllerForDataDetectedText]):
207         (-[WebImmediateActionController _animationControllerForDataDetectedLink]):
208         Pull _clearTextIndicatorWithAnimation out, make it avoid using a dismissal animation
209         if we're called from didHandleScrollWheel.
210
211         * WebView/WebView.mm:
212         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
213         (-[WebView _setTextIndicator:]):
214         (-[WebView _setTextIndicator:withLifetime:]):
215         (-[WebView _clearTextIndicator]):
216         (-[WebView _showDictionaryLookupPopup:]):
217         (-[WebView _dictionaryLookupPopoverWillClose:]):
218         (-[WebView _setTextIndicator:fadeOut:]): Deleted.
219         * WebView/WebViewInternal.h:
220         Make _setTextIndicator take a reference.
221         Add a variant of _setTextIndicator that takes a Lifetime.
222         Make _clearTextIndicatorWithAnimation take a DismissalAnimation.
223
224 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
225
226         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
227         https://bugs.webkit.org/show_bug.cgi?id=144304
228
229         Reviewed by Geoffrey Garen.
230
231         Define ENABLE_JIT, enabled by default, instead of ENABLE_LLINT_C_LOOP, disabled by default.
232
233         * Configurations/FeatureDefines.xcconfig:
234
235 2015-04-28  Commit Queue  <commit-queue@webkit.org>
236
237         Unreviewed, rolling out r183514.
238         https://bugs.webkit.org/show_bug.cgi?id=144359
239
240         It broke cloop test bots (Requested by mcatanzaro on #webkit).
241
242         Reverted changeset:
243
244         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
245         https://bugs.webkit.org/show_bug.cgi?id=144304
246         http://trac.webkit.org/changeset/183514
247
248 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
249
250         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
251         https://bugs.webkit.org/show_bug.cgi?id=144304
252
253         Reviewed by Geoffrey Garen.
254
255         Define ENABLE_JIT, enabled by default, instead of ENABLE_LLINT_C_LOOP, disabled by default.
256
257         * Configurations/FeatureDefines.xcconfig:
258
259 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
260
261         Fix common typo "targetting" => "targeting"
262         https://bugs.webkit.org/show_bug.cgi?id=144349
263
264         Reviewed by Daniel Bates.
265
266         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
267         (WebKit::NetscapePluginInstanceProxy::loadRequest):
268         * Plugins/WebNetscapePluginView.mm:
269         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
270         * WebView/WebPolicyDelegate.h:
271
272 2015-04-28  Brady Eidson  <beidson@apple.com>
273
274         Consolidate most "frame load" arguments into FrameLoadRequest.
275         https://bugs.webkit.org/show_bug.cgi?id=144276
276
277         Reviewed by Alexey Proskuryakov.
278
279         * WebView/WebPDFView.mm:
280         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
281
282 2015-04-27  Dan Bernstein  <mitz@apple.com>
283
284         <rdar://problem/20721931> REGRESSION (r178753): All legacy framework headers are missing availability annotations
285         https://bugs.webkit.org/show_bug.cgi?id=144311
286
287         Reviewed by Adele Peterson.
288
289         * postprocess-headers.sh: Changed “macsox” to “macosx”.
290
291 2015-04-27  Brady Eidson  <beidson@apple.com>
292
293         Make 'enum NavigationType' be an enum class
294         https://bugs.webkit.org/show_bug.cgi?id=144270
295
296         Reviewed by Alex Christensen.
297
298         * WebCoreSupport/WebFrameLoaderClient.mm:
299         (WebFrameLoaderClient::actionDictionary):
300
301 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
302
303         REGRESSION(r182879): Images and video can no longer be downloaded
304         https://bugs.webkit.org/show_bug.cgi?id=144267
305         <rdar://problem/20702844>
306
307         Reviewed by Simon Fraser.
308
309         * WebView/WebActionMenuController.mm:
310         (-[WebActionMenuController _createActionMenuItemForTag:]): Check for
311         "!WebCore::protocolIs(..., "file")" for image and media downloads.
312
313 2015-04-26  Yusuke Suzuki  <utatane.tea@gmail.com>
314
315         [ES6] Implement ES6 template literals
316         https://bugs.webkit.org/show_bug.cgi?id=142691
317
318         Reviewed by Darin Adler.
319
320         Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
321
322         * Configurations/FeatureDefines.xcconfig:
323
324 2015-04-26  Doug Russell  <d_russell@apple.com>
325
326         AX: richer text change notifications (142719)
327         https://bugs.webkit.org/show_bug.cgi?id=142719
328
329         Reviewed by Darin Adler.
330
331         Richer accessibility value change notifications. Introduce AXTextEditType,
332         postTextStateChangeNotification and postTextReplacementNotification to give assistive
333         tech apps more reliable context for responding to changes in web content. Also implement
334         a mechanism to post value changes in password form fields in coalesced ticks to thwart
335         analyzing the cadence of changes.
336
337         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
338         and an overload of postTextReplacementNotification to give assistive tech apps more
339         reliable context for responding to changes in web content selection. Also block posting
340         selection changes on password fields.
341
342         * WebCoreSupport/WebEditorClient.mm:
343         (undoNameForEditAction):
344
345 2015-04-24  Timothy Hatcher  <timothy@apple.com>
346
347         Web Inspector: Remove native window dock controls
348         https://bugs.webkit.org/show_bug.cgi?id=144184
349
350         Reviewed by Joseph Pecoraro.
351
352         * Resources/Dock.pdf: Removed.
353         * Resources/DockLegacy.pdf: Removed.
354         * WebCoreSupport/WebInspectorClient.mm:
355         (-[WebInspectorWindowController window]):
356         (-[WebInspectorWindowController setDockingUnavailable:]):
357
358 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
359
360         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
361         https://bugs.webkit.org/show_bug.cgi?id=144182
362
363         Reviewed by Simon Fraser.
364
365         * Configurations/FeatureDefines.xcconfig: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
366
367 2015-04-24  Commit Queue  <commit-queue@webkit.org>
368
369         Unreviewed, rolling out r183266.
370         https://bugs.webkit.org/show_bug.cgi?id=144164
371
372         Broke 32-bit build and a test. (Requested by ap on #webkit).
373
374         Reverted changeset:
375
376         "AX: richer text change notifications (142719)"
377         https://bugs.webkit.org/show_bug.cgi?id=142719
378         http://trac.webkit.org/changeset/183266
379
380 2015-04-24  Myles C. Maxfield  <mmaxfield@apple.com>
381
382         [Cocoa] Start cleaning up FontPlatformData
383         https://bugs.webkit.org/show_bug.cgi?id=144133
384
385         Reviewed by Enrica Casucci.
386
387         Receive casts which have been hoisted from the deleted FontPlatformData constructor.
388
389         * Misc/WebKitNSStringExtras.mm:
390         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Receive cast which has
391         been hoisted from the deleted FontPlatformData constructor.
392         (-[NSString _web_widthWithFont:]): Ditto.
393         * Misc/WebStringTruncator.mm:
394         (fontFromNSFont): Ditto.
395
396 2015-04-24  Doug Russell  <d_russell@apple.com>
397
398         AX: richer text change notifications (142719)
399         https://bugs.webkit.org/show_bug.cgi?id=142719
400
401         Reviewed by Darin Adler.
402
403         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
404
405         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
406
407         * WebCoreSupport/WebEditorClient.mm:
408         (undoNameForEditAction):
409
410 2015-04-23  Jer Noble  <jer.noble@apple.com>
411
412         [Mac] Disable QTKit by default on future OS X.
413         https://bugs.webkit.org/show_bug.cgi?id=144082
414
415         Reviewed by Darin Adler.
416
417         Default WebKitQTKitEnabledPreferenceKey to NO.
418
419         * WebView/WebPreferences.mm:
420         (+[WebPreferences initialize]):
421
422 2015-04-23  Andreas Kling  <akling@apple.com>
423
424         There should only be one way to get the system memory size.
425         <https://webkit.org/b/144081>
426
427         Reviewed by Antti Koivisto.
428
429         * Misc/WebKitSystemBits.h:
430         * Misc/WebKitSystemBits.m:
431         (WebMemorySize): Deleted.
432         * WebView/WebView.mm:
433         (+[WebView _setCacheModel:]):
434         (roundUpToPowerOf2): Deleted.
435
436 2015-04-22  Darin Adler  <darin@apple.com>
437
438         Remove OwnPtr and PassOwnPtr use from WebKit/cf, WebKit/mac, and WebKit2
439         https://bugs.webkit.org/show_bug.cgi?id=143943
440
441         Reviewed by Anders Carlsson.
442
443         * Plugins/Hosted/ProxyInstance.h: Removed unneeded include.
444         * Plugins/WebBaseNetscapePluginView.h: Ditto.
445
446         * Plugins/WebNetscapePluginEventHandler.h: Use unique_ptr instead of
447         PassOwnPtr for the create function. Also tweaked formatting and removed
448         unneeded forward declaration of CGRect.
449         * Plugins/WebNetscapePluginEventHandler.mm:
450         (WebNetscapePluginEventHandler::create): Changed to use unique_ptr and
451         make_unique.
452
453         * Plugins/WebNetscapePluginView.h: Use unique_ptr instead of OwnPtr for
454         the _eventHandler field.
455         * Plugins/WebNetscapePluginView.mm:
456         (-[WebNetscapePluginView destroyPlugin]): Changed code to work with unique_ptr.
457
458         * WebCoreSupport/WebUserMediaClient.mm: Removed unneeded include.
459
460         * WebView/WebDeviceOrientationProviderMock.mm: Changed to use make_unique.
461         * WebView/WebDeviceOrientationProviderMockInternal.h: Changed to use unique_ptr.
462
463         * WebView/WebFrame.mm:
464         (vectorForDictationPhrasesArray): Changed to return Vector<Vector<String>> and
465         not a PassOwnPtr. Also rewrote to be much simpler, although there is still a
466         pre-existing problem here where this could put empty vectors into the result,
467         and I'm pretty sure the client never expects any of the Vector<String> to be empty.
468         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
469         Rewrote logic to involve WebCore types a bit less; old code was round tripping
470         things through WebCore::URL for no obvious reason.
471
472         * WebView/WebFrameInternal.h: Changed vectorForDictationPhrasesArray to return
473         a Vector<Vector<String>> and not a PassOwnPtr.
474
475         * WebView/WebFullScreenController.h: Removed unneeded include.
476
477         * WebView/WebViewData.h: Changed m_alternativeTextUIController to be a
478         m_alternativeTextUIController.
479         * WebView/WebViewData.mm:
480         (-[WebViewPrivate init]): Use make_unique to initialize m_alternativeTextUIController.
481
482 2015-04-22  Brent Fulgham  <bfulgham@apple.com>
483
484         VisibleSelection should only accept Range by reference
485         https://bugs.webkit.org/show_bug.cgi?id=144047
486
487         Reviewed by Tim Horton.
488
489         Update all uses of VisibleSelection to pass a Range reference instead
490         of a Range pointer.
491
492         * WebCoreSupport/WebContextMenuClient.mm:
493         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
494         * WebView/WebFrame.mm:
495         (-[WebFrame _selectNSRange:]):
496
497 2015-04-22  Eric Carlson  <eric.carlson@apple.com>
498
499         [Mac] Device picker menu is positioned incorrectly in WK1
500         https://bugs.webkit.org/show_bug.cgi?id=144049
501         <rdar://problem/20493101>
502
503         Reviewed by Dean Jackson.
504
505         * WebView/WebView.mm:
506         (-[WebView _showPlaybackTargetPicker:location:hasVideo:]): Mouse location is already in
507             window coordinates so don't call convertRect:toView:nil.
508
509 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
510
511         Extend action menus to support PDF
512         https://bugs.webkit.org/show_bug.cgi?id=143895
513         <rdar://problem/19003333>
514
515         Reviewed by Tim Horton.
516
517         Prevent a crash when someone attempts to invoke an action menu on a PDF hosted
518         in a WK1 view.
519
520         * WebView/WebActionMenuController.mm:
521         (-[WebActionMenuController performHitTestAtPoint:]): Handle WebPDFView as well as
522         the WebHTMLView case.
523         * WebView/WebDocument.h:
524         * WebView/WebHTMLView.h:
525         * WebView/WebHTMLView.mm:
526         (-[WebHTMLView _frame]):
527         * WebView/WebHTMLViewInternal.h:
528         * WebView/WebPDFView.h:
529         * WebView/WebPDFView.mm:
530         (-[WebPDFView _frame]): Added.
531
532 2015-04-22  Eric Carlson  <eric.carlson@apple.com>
533
534         Unreviewed post-review clean up after r183096.
535
536         * WebView/WebMediaPlaybackTargetPicker.h:
537
538 2015-04-21  Eric Carlson  <eric.carlson@apple.com>
539
540         [Mac] Use one playback target for all web processes
541         https://bugs.webkit.org/show_bug.cgi?id=144009
542
543         Reviewed by Tim Horton.
544
545         Update to use WebMediaSessionManager for playback target management.
546
547         * WebCoreSupport/WebChromeClient.h:
548         * WebCoreSupport/WebChromeClient.mm:
549         (WebChromeClient::addPlaybackTargetPickerClient):
550         (WebChromeClient::removePlaybackTargetPickerClient):
551         (WebChromeClient::showPlaybackTargetPicker):
552         (WebChromeClient::playbackTargetPickerClientStateDidChange):
553         (WebChromeClient::startingMonitoringPlaybackTargets): Deleted.
554         (WebChromeClient::stopMonitoringPlaybackTargets): Deleted.
555         * WebView/WebMediaPlaybackTargetPicker.h:
556         * WebView/WebMediaPlaybackTargetPicker.mm:
557         (WebMediaPlaybackTargetPicker::addPlaybackTargetPickerClient):
558         (WebMediaPlaybackTargetPicker::removePlaybackTargetPickerClient):
559         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
560         (WebMediaPlaybackTargetPicker::playbackTargetPickerClientStateDidChange):
561         (WebMediaPlaybackTargetPicker::setPlaybackTarget):
562         (WebMediaPlaybackTargetPicker::externalOutputDeviceAvailableDidChange):
563         (WebMediaPlaybackTargetPicker::setShouldPlayToPlaybackTarget):
564         (WebMediaPlaybackTargetPicker::invalidate):
565         (WebMediaPlaybackTargetPicker::startingMonitoringPlaybackTargets): Deleted.
566         (WebMediaPlaybackTargetPicker::stopMonitoringPlaybackTargets): Deleted.
567         (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): Deleted.
568         (WebMediaPlaybackTargetPicker::targetPicker): Deleted.
569         * WebView/WebView.mm:
570         (-[WebView _addPlaybackTargetPickerClient:]):
571         (-[WebView _removePlaybackTargetPickerClient:]):
572         (-[WebView _showPlaybackTargetPicker:location:hasVideo:]):
573         (-[WebView _playbackTargetPickerClientStateDidChange:state:]):
574         (-[WebView _showPlaybackTargetPicker:hasVideo:]): Deleted.
575         (-[WebView _startingMonitoringPlaybackTargets]): Deleted.
576         (-[WebView _stopMonitoringPlaybackTargets]): Deleted.
577         * WebView/WebViewInternal.h:
578
579 2015-04-20  Alexey Proskuryakov  <ap@apple.com>
580
581         Disable mixed content blocking for existing WebKit1 clients
582         https://bugs.webkit.org/show_bug.cgi?id=143955
583         rdar://problem/20177186
584
585         Reviewed by Oliver Hunt.
586
587         * Misc/WebKitVersionChecks.h:
588         * WebView/WebView.mm:
589         (shouldAllowInsecureContent):
590         (-[WebView _preferencesChanged:]):
591
592 2015-04-20  Tim Horton  <timothy_horton@apple.com>
593
594         Implement immediate action support for tel: and mailto: URLs
595         https://bugs.webkit.org/show_bug.cgi?id=143916
596         <rdar://problem/19721711>
597
598         Reviewed by Darin Adler.
599
600         * WebView/WebImmediateActionController.mm:
601         (-[WebImmediateActionController _defaultAnimationController]):
602         (-[WebImmediateActionController _animationControllerForDataDetectedText]):
603         (-[WebImmediateActionController _animationControllerForDataDetectedLink]):
604         (-[WebImmediateActionController _menuItemForDataDetectedText]): Deleted.
605         * WebView/WebUIDelegatePrivate.h:
606         Add _animationControllerForDataDetectedLink and use it when
607         building immediate actions for tel: and mailto: links.
608
609 2015-04-17  Daniel Bates  <dabates@apple.com>
610
611         REGRESSION: SVG does not support link dragging
612         https://bugs.webkit.org/show_bug.cgi?id=141597
613
614         Reviewed by Darin Adler.
615
616         Write -[WebElementDictionary _isLiveLink] in terms of WebCore::isDraggableLink().
617
618         * Misc/WebElementDictionary.mm:
619         (-[WebElementDictionary _isLiveLink]):
620
621 2015-04-16  Sam Weinig  <sam@webkit.org>
622
623         Expose JavaScriptMarkupEnabled preference for WebKit1
624         <rdar://problem/19939450>
625         https://bugs.webkit.org/show_bug.cgi?id=143855
626
627         Reviewed by Dan Bernstein.
628
629         * WebView/WebPreferenceKeysPrivate.h:
630         Add new key, WebKitJavaScriptMarkupEnabledPreferenceKey
631
632         * WebView/WebPreferences.mm:
633         (+[WebPreferences initialize]):
634         Initialize WebKitJavaScriptMarkupEnabledPreferenceKey to YES.
635
636         (-[WebPreferences isJavaScriptMarkupEnabled]):
637         (-[WebPreferences setJavaScriptMarkupEnabled:]):
638         Implement getter/setter.
639
640         * WebView/WebPreferencesPrivate.h:
641         Add new property, javaScriptMarkupEnabled.
642
643         * WebView/WebView.mm:
644         (-[WebView _preferencesChanged:]):
645         Map the new preference to WebCore's scriptMarkupEnabled setting.
646
647 2015-04-15  Brent Fulgham  <bfulgham@apple.com>
648
649         [Mac] Disable "Save to Downloads" option for local files
650         https://bugs.webkit.org/show_bug.cgi?id=143794
651
652         Reviewed by Tim Horton.
653
654         Disable the Image and Media download options if the download
655         target is a local file. We can only download web resources;
656         anything else is actually a no-op.
657
658         * WebView/WebActionMenuController.mm:
659         (-[WebActionMenuController _defaultMenuItemsForImage]):
660         (-[WebActionMenuController _defaultMenuItemsForVideo]):
661
662 2015-04-15  Alex Christensen  <achristensen@webkit.org>
663
664         Progress towards CMake on Mac.
665         https://bugs.webkit.org/show_bug.cgi?id=143785
666
667         Reviewed by Csaba Osztrogonác.
668
669         * WebView/WebPDFDocumentExtras.mm:
670         * WebView/WebPDFView.mm:
671
672 2015-04-13  Jer Noble  <jer.noble@apple.com>
673
674         [Fullscreen] ChromeClient::exitVideoFullscreen() should take a pointer to a HTMLVideoElement.
675         https://bugs.webkit.org/show_bug.cgi?id=143674
676
677         Reviewed by Darin Adler.
678
679         * WebCoreSupport/WebChromeClient.h:
680         * WebCoreSupport/WebChromeClient.mm:
681         (WebChromeClient::enterVideoFullscreenForVideoElement): Takes a reference.
682         (WebChromeClient::exitVideoFullscreenForVideoElement): Renamed from exitVideoFullscreen().
683         (WebChromeClient::exitVideoFullscreen): Deleted.
684
685 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
686
687         Re-enable custom dilation for antialiased fonts
688         https://bugs.webkit.org/show_bug.cgi?id=143738
689
690         Reviewed by Tim Horton.
691         
692         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
693         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
694         a private WebKit pref. This pref defaults to YES, enabling the feature by default
695         in WK1 as we do for WK2.
696
697         * WebView/WebPreferenceKeysPrivate.h:
698         * WebView/WebPreferences.mm:
699         (+[WebPreferences initialize]):
700         (-[WebPreferences setAntialiasedFontDilationEnabled:]):
701         (-[WebPreferences antialiasedFontDilationEnabled]):
702         * WebView/WebPreferencesPrivate.h:
703         * WebView/WebView.mm:
704         (-[WebView _preferencesChanged:]):
705
706 2015-04-13  Brady Eidson  <beidson@apple.com>
707
708         Share sheets from Share menus appear outside the browser window.
709         <rdar://problem/20455592> and https://bugs.webkit.org/show_bug.cgi?id=143620
710
711         Reviewed by Darin Adler.
712
713         Refactor existing Sharing Service Picker code to also be used for the Share menu NSMenuItem.
714
715         * Misc/WebSharingServicePickerController.h:
716         (WebSharingServicePickerClient::webView):
717         * Misc/WebSharingServicePickerController.mm:
718         (WebSharingServicePickerClient::WebSharingServicePickerClient):
719         (WebSharingServicePickerClient::sharingServicePickerWillBeDestroyed):
720         (WebSharingServicePickerClient::pageForSharingServicePicker):
721         (WebSharingServicePickerClient::windowForSharingServicePicker):
722         (WebSharingServicePickerClient::screenRectForCurrentSharingServicePickerItem):
723         (WebSharingServicePickerClient::imageForCurrentSharingServicePickerItem):
724         (-[WebSharingServicePickerController initWithItems:includeEditorServices:client:style:]):
725         (-[WebSharingServicePickerController initWithSharingServicePicker:client:]):
726         (-[WebSharingServicePickerController sharingService:didShareItems:]):
727
728         * WebCoreSupport/WebContextMenuClient.h:
729         (WebContextMenuClient::webView): Deleted.
730         * WebCoreSupport/WebContextMenuClient.mm:
731         (WebContextMenuClient::WebContextMenuClient):
732         (WebContextMenuClient::pageForSharingServicePicker): Deleted.
733         (WebContextMenuClient::windowForSharingServicePicker): Deleted.
734
735         * WebCoreSupport/WebSelectionServiceController.h:
736         * WebCoreSupport/WebSelectionServiceController.mm:
737         (WebSelectionServiceController::WebSelectionServiceController):
738         (WebSelectionServiceController::handleSelectionServiceClick):
739         (WebSelectionServiceController::pageForSharingServicePicker): Deleted.
740         (WebSelectionServiceController::windowForSharingServicePicker): Deleted.
741         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem): Deleted.
742         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem): Deleted.
743
744         * WebView/WebHTMLView.mm:
745         (-[WebHTMLView menuForEvent:]):
746         * WebView/WebViewData.h:
747
748 2015-04-13  Beth Dakin  <bdakin@apple.com>
749
750         Add force property to MouseEvents
751         https://bugs.webkit.org/show_bug.cgi?id=143569
752         -and corresponding-
753         rdar://problem/20472954
754
755         Reviewed by Darin Adler.
756
757         PlatformMouseEvent and MouseEvent now take force parameters.
758         * WebView/WebFrame.mm:
759         (-[WebFrame _dragSourceEndedAt:operation:]):
760         * WebView/WebPDFView.mm:
761         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
762
763 2015-04-12  Darin Adler  <darin@apple.com>
764
765         [Cocoa] Localizable strings are inconsistent and need to be regenerated
766         https://bugs.webkit.org/show_bug.cgi?id=143661
767         rdar://problem/19634388
768
769         Reviewed by Dan Bernstein.
770
771         * Misc/WebLocalizableStrings.mm:
772         (LoadWebLocalizedStringsTimerCallback): Moved the comment, useful for programmers but
773         not for localization, into a C++ source code comment, and made the localizer comment
774         consistent with the place this localizable string is used for actual localization.
775         * WebCoreSupport/WebEditorClient.mm:
776         (undoNameForEditAction): Changed the localizer comments for Delete and Dictation
777         to match the ones in WebKit2; no need to specify that these are iOS only, and if we do
778         want to specify that, we should not be using the term PLATFORM(IOS) since there is no
779         reason for us to expect localizers to understand that terminology. Also added a comment
780         about the fact that we have two copies of all the localizable strings.
781
782 2015-04-11  Yusuke Suzuki  <utatane.tea@gmail.com>
783
784         [ES6] Enable Symbol in web pages
785         https://bugs.webkit.org/show_bug.cgi?id=143375
786
787         Reviewed by Ryosuke Niwa.
788
789         * WebView/WebPreferencesPrivate.h:
790
791 2015-04-08  Sam Weinig  <sam@webkit.org>
792
793         Allow LaunchServices to handle URLs on link navigations
794         <rdar://problem/19446826>
795         https://bugs.webkit.org/show_bug.cgi?id=143544
796
797         Reviewed by Anders Carlsson.
798
799         * Configurations/WebKitLegacy.xcconfig:
800         Link MobileCoreServices.
801
802         * WebCoreSupport/WebFrameLoaderClient.h:
803         * WebCoreSupport/WebFrameLoaderClient.mm:
804         (shouldTryAppLink):
805         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
806         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
807         (WebFrameLoaderClient::setUpPolicyListener):
808         Only let LaunchServices have a crack at the URL if the navigation is:
809             1) a main frame navigation
810             2) a result of a user gesture
811
812 2015-04-10  Alexey Proskuryakov  <ap@apple.com>
813
814         Build fix.
815
816         * Misc/WebNSURLExtras.mm: (-[NSString _webkit_unescapedQueryValue]): Ignore a deprecation.
817
818 2015-04-10  Eric Carlson  <eric.carlson@apple.com>
819
820         [Mac] Refactor MediaPlaybackTarget
821         https://bugs.webkit.org/show_bug.cgi?id=143571
822
823         Reviewed by Jer Noble.
824
825         * WebView/WebMediaPlaybackTargetPicker.h:
826         * WebView/WebMediaPlaybackTargetPicker.mm:
827         (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): Take a Ref<MediaPlaybackTarget>&&.
828
829 2015-04-09  Andy Estes  <aestes@apple.com>
830
831         [Cocoa] Add a HAVE(AVKIT) and use it
832         https://bugs.webkit.org/show_bug.cgi?id=143593
833
834         Reviewed by David Kilzer.
835
836         * WebView/WebPreferences.mm:
837         (+[WebPreferences initialize]): Only set WebKitAVKitEnabled to YES if HAVE(AVKIT).
838         (-[WebPreferences setAVKitEnabled:]): Only set value for WebKitAVKitEnabled if HAVE(AVKIT).
839         * WebView/WebView.mm:
840         (-[WebView _preferencesChanged:]): Only called Settings::setAVKitEnabled() if HAVE(AVKIT).
841
842 2015-04-09  Chris Dumez  <cdumez@apple.com>
843
844         [WK2][iOS] editorState() should not cause a synchronous layout
845         https://bugs.webkit.org/show_bug.cgi?id=142536
846         <rdar://problem/20041506>
847
848         Reviewed by Enrica Casucci.
849
850         Provide implementation for EditorClient::didChangeSelectionAndUpdateLayout().
851
852         * WebCoreSupport/WebEditorClient.h:
853
854 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
855
856         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
857         https://bugs.webkit.org/show_bug.cgi?id=143452
858         <rdar://problem/20437483>
859
860         Reviewed by Tim Horton.
861
862         We were improperly intercepting contextual menu clicks and passing them through
863         the mouseDown handler, rather than processing via NSView's menu handling code.
864
865         * WebView/WebHTMLView.mm:
866         (-[WebHTMLView otherMouseDown:]): Treat context menu events the same as the action
867         menu case, and pass it to AppKit for normal menu processing. 
868
869 2015-04-08  Brady Eidson  <beidson@apple.com>
870
871         Expose the "Share" menu for links, images, and media.
872         <rdar://problem/20435340> and https://bugs.webkit.org/show_bug.cgi?id=143502
873
874         Reviewed by Tim Horton.
875
876         * WebCoreSupport/WebContextMenuClient.h:
877         * WebCoreSupport/WebContextMenuClient.mm:
878         (WebContextMenuClient::shareMenuItem): 
879
880 2015-04-08  Anders Carlsson  <andersca@apple.com>
881
882         Move some ApplicationCache static member functions to ApplicationCacheStorage
883         https://bugs.webkit.org/show_bug.cgi?id=143524
884
885         Reviewed by Antti Koivisto.
886
887         * WebCoreSupport/WebApplicationCache.mm:
888         (+[WebApplicationCache diskUsageForOrigin:]):
889         (+[WebApplicationCache deleteAllApplicationCaches]):
890         (+[WebApplicationCache deleteCacheForOrigin:]):
891
892 2015-04-08  Chris Dumez  <cdumez@apple.com>
893
894         Rename ActiveDOMObject::canSuspend() to canSuspendForPageCache() for clarity
895         https://bugs.webkit.org/show_bug.cgi?id=143513
896
897         Reviewed by Andreas Kling.
898
899         Update ScriptExecutionContext::canSuspendActiveDOMObjects() to
900         canSuspendActiveDOMObjectsForPageCache() as the method was renamed.
901
902         * WebView/WebFrame.mm:
903         (-[WebFrame _cacheabilityDictionary]):
904
905 2015-04-07  Anders Carlsson  <andersca@apple.com>
906
907         Get rid of uses of ApplicationCacheStorage::singleton() from WebKitLegacy
908         https://bugs.webkit.org/show_bug.cgi?id=143504
909
910         Reviewed by Sam Weinig.
911
912         Add a webApplicationCacheStorage() function and use it throughout WebKitLegacy.
913         In the future, webApplicationCacheStorage will return a custom singleton, but for now
914         it just returns ApplicationCacheStorage::singleton().
915
916         * Misc/WebCache.mm:
917         (+[WebCache empty]):
918         * WebCoreSupport/WebApplicationCache.mm:
919         (+[WebApplicationCache maximumSize]):
920         (+[WebApplicationCache setMaximumSize:]):
921         (+[WebApplicationCache defaultOriginQuota]):
922         (+[WebApplicationCache setDefaultOriginQuota:]):
923         (+[WebApplicationCache originsWithCache]):
924         (webApplicationCacheStorage):
925         * WebCoreSupport/WebApplicationCacheInternal.h: Added.
926         * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
927         (-[WebApplicationCacheQuotaManager usage]):
928         (-[WebApplicationCacheQuotaManager quota]):
929         (-[WebApplicationCacheQuotaManager setQuota:]):
930         * WebView/WebView.mm:
931         (WebKitInitializeApplicationCachePathIfNecessary):
932
933 2015-04-07  Brady Eidson  <beidson@apple.com>
934
935         ContextMenuItem refactoring
936         https://bugs.webkit.org/show_bug.cgi?id=143485
937
938         Reviewed by Beth Dakin.
939
940         * WebCoreSupport/WebContextMenuClient.mm:
941         (WebContextMenuClient::contextMenuItemSelected):
942
943 2015-04-06  Chris Dumez  <cdumez@apple.com>
944
945         Bing video search result pages are not PageCacheable
946         https://bugs.webkit.org/show_bug.cgi?id=143463
947         <rdar://problem/20440916>
948
949         Reviewed by Alexey Proskuryakov.
950
951         Fix the iOS / WK1 build by using MemoryCache::resourceForRequest()
952         instead of resourceForUrl().
953
954         * Misc/WebCache.mm:
955         (+[WebCache imageForURL:]):
956
957 2015-04-05  Simon Fraser  <simon.fraser@apple.com>
958
959         Remove "go ahead and" from comments
960         https://bugs.webkit.org/show_bug.cgi?id=143421
961
962         Reviewed by Darin Adler, Benjamin Poulain.
963
964         Remove the phrase "go ahead and" from comments where it doesn't add
965         anything (which is almost all of them).
966
967         * WebView/WebDynamicScrollBarsView.mm:
968         (-[WebDynamicScrollBarsView updateScrollers]):
969         * WebView/WebHTMLView.mm:
970         (-[WebHTMLView insertText:]):
971
972 2015-04-02  Brady Eidson  <beidson@apple.com>
973
974         Unreviewed: Reland change after rollout.
975
976         Expose the "Share" menu for text selections on platforms where it's available.
977         rdar://problem/20034174 and https://bugs.webkit.org/show_bug.cgi?id=143318
978
979         * WebView/WebImmediateActionController.mm: Update for required #include
980
981 2015-04-02  Commit Queue  <commit-queue@webkit.org>
982
983         Unreviewed, rolling out r182293.
984         https://bugs.webkit.org/show_bug.cgi?id=143355
985
986         Broke GTK and EFL builds. (Requested by bfulgham on #webkit).
987
988         Reverted changeset:
989
990         "Expose the "Share" menu for text selections on platforms
991         where it's available."
992         https://bugs.webkit.org/show_bug.cgi?id=143318
993         http://trac.webkit.org/changeset/182293
994
995 2015-04-02  Brady Eidson  <beidson@apple.com>
996
997         Expose the "Share" menu for text selections on platforms where it's available.
998         rdar://problem/20034174 and https://bugs.webkit.org/show_bug.cgi?id=143318
999
1000         Reviewed by Sam Weinig.
1001
1002         * WebView/WebImmediateActionController.mm: Update for required #include
1003
1004 2015-04-02  Yusuke Suzuki  <utatane.tea@gmail.com>
1005
1006         Clean up EnumerationMode to easily extend
1007         https://bugs.webkit.org/show_bug.cgi?id=143276
1008
1009         Reviewed by Geoffrey Garen.
1010
1011         Use default EnumerationMode().
1012
1013         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1014         (WebKit::NetscapePluginInstanceProxy::enumerate):
1015
1016 2015-03-31  Simon Fraser  <simon.fraser@apple.com>
1017
1018         Remove scrolling tree dependency on wheel event handler counts, and use fast scrolling even when there are wheel handlers
1019         https://bugs.webkit.org/show_bug.cgi?id=143288
1020
1021         Reviewed by Beth Dakin.
1022
1023         Remove the wheel event counting that Document does, and passes into the scrolling tree.
1024         The ScrollingTree now just uses the non-fast scrollable region to determine when to
1025         fast scroll on pages with wheel event handlers.
1026
1027         * WebCoreSupport/WebChromeClient.h:
1028
1029 2015-03-31  Timothy Horton  <timothy_horton@apple.com>
1030
1031         TextIndicator for <span> inside an <a> only highlights the <span>, should highlight the whole <a>
1032         https://bugs.webkit.org/show_bug.cgi?id=143287
1033         <rdar://problem/20318342>
1034
1035         Reviewed by Beth Dakin.
1036
1037         * WebView/WebImmediateActionController.mm:
1038         (-[WebImmediateActionController _defaultAnimationController]):
1039         Instead of just highlighting the hit element, highlight the whole
1040         element that the link URL comes from.
1041
1042 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
1043
1044         Clean up Identifier factories to clarify the meaning of StringImpl*
1045         https://bugs.webkit.org/show_bug.cgi?id=143146
1046
1047         Reviewed by Filip Pizlo.
1048
1049         Just change to Identifier::fromString.
1050
1051         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1052         (identifierFromIdentifierRep):
1053         * Plugins/Hosted/ProxyInstance.mm:
1054         (WebKit::ProxyInstance::getPropertyNames):
1055
1056 2015-03-28  Anders Carlsson  <andersca@apple.com>
1057
1058         Remove an unused SPI method from WebKitLegacy
1059         https://bugs.webkit.org/show_bug.cgi?id=143185
1060
1061         Reviewed by Sam Weinig.
1062
1063         * WebView/WebDataSource.mm:
1064         (-[WebDataSource _transferApplicationCache:]): Deleted.
1065         * WebView/WebDataSourcePrivate.h:
1066
1067 2015-03-26  Alex Christensen  <achristensen@webkit.org>
1068
1069         Progress towards CMake on Mac.
1070         https://bugs.webkit.org/show_bug.cgi?id=143112
1071
1072         Reviewed by Chris Dumez.
1073
1074         * WebCoreSupport/WebFrameLoaderClient.h:
1075
1076 2015-03-26  Ryosuke Niwa  <rniwa@webkit.org>
1077
1078         Cursor doesn't change back to pointer when leaving Mail
1079         https://bugs.webkit.org/show_bug.cgi?id=132038
1080
1081         Reviewed by Anders Carlsson.
1082
1083         Fixed the bug by adding a cursor rect and making the primary tracking area update the cursor so that
1084         AppKit will reset the cursor as it leaves the WebView.
1085
1086         We use nil cursor here since we manually update the cursor by calling [NSCursor set].
1087
1088         * WebView/WebHTMLView.mm:
1089         (-[WebHTMLView setDataSource:]): Use NSTrackingCursorUpdate option in creating the primary tracking area.
1090
1091 2015-03-24  Anders Carlsson  <andersca@apple.com>
1092
1093         Fix designated initializer violations
1094         https://bugs.webkit.org/show_bug.cgi?id=143016
1095         rdar://problem/20268858
1096
1097         Reviewed by Dan Bernstein.
1098
1099         Move -[WebBackForwardList initWithBackForwardList:] to the implementation instead of a category since
1100         nobody calls it outside of WebBackForwardList.mm.
1101
1102         * History/WebBackForwardList.mm:
1103         * History/WebBackForwardListInternal.h:
1104
1105 2015-03-23  Alexey Proskuryakov  <ap@apple.com>
1106
1107         REGRESSION (Yosemite): WKView visibility notifications are messed up
1108         https://bugs.webkit.org/show_bug.cgi?id=142945
1109
1110         Reviewed by Tim Horton.
1111
1112         As these notifications cannot be used by NSView subclasses, create a separate
1113         object for observing them.
1114
1115         * WebView/WebView.mm:
1116         (-[WebView _commonInitializationWithFrameName:groupName:]):
1117         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1118         (-[WebView addWindowObserversForWindow:]):
1119         (-[WebView removeWindowObservers]):
1120         (-[WebView viewWillMoveToWindow:]): Make sure that observers are removed even
1121         if -[WebView close] is called manually.
1122         * WebView/WebViewData.h:
1123         * WebView/WebViewData.mm:
1124         (-[WebWindowVisibilityObserver initWithView:]):
1125         (-[WebWindowVisibilityObserver startObserving:]):
1126         (-[WebWindowVisibilityObserver stopObserving:]):
1127         (-[WebWindowVisibilityObserver _windowVisibilityChanged:]):
1128
1129 2015-03-23  Tim Horton  <timothy_horton@apple.com>
1130
1131         Add a share item to the link action menu
1132         https://bugs.webkit.org/show_bug.cgi?id=142961
1133         <rdar://problem/19198374>
1134
1135         Reviewed by Beth Dakin.
1136
1137         * WebView/WebActionMenuController.mm:
1138         (-[WebActionMenuController _defaultMenuItemsForImage]):
1139         (-[WebActionMenuController _defaultMenuItemsForVideo]):
1140         (-[WebActionMenuController _createActionMenuItemForTag:]):
1141         (-[WebActionMenuController _createShareActionMenuItemForTag:withItems:]):
1142         Adopt -[NSMenuItem standardShareMenuItemWithItems].
1143         All of the null-checking is unnecessary as it's impossible to enter
1144         these functions with a null image/etc.
1145         Also, remove a duplicate isDownloadableMedia check for the 'save to downloads' item.
1146
1147         (-[WebActionMenuController _defaultMenuItemsForLink]):
1148         * WebView/WebUIDelegatePrivate.h:
1149         Add a 'Share' item to the link menu.
1150
1151 2015-03-22  Alexey Proskuryakov  <ap@apple.com>
1152
1153         Build fix.
1154
1155         * WebView/WebView.mm: (-[WebView _showPlaybackTargetPicker:hasVideo:]):
1156
1157 2015-03-22  Eric Carlson  <eric.carlson@apple.com>
1158
1159         [Mac] Enable WIRELESS_PLAYBACK_TARGET for WK1
1160         https://bugs.webkit.org/show_bug.cgi?id=142940
1161
1162         Reviewed by Sam Weinig.
1163
1164         * WebCoreSupport/WebChromeClient.h:
1165         * WebCoreSupport/WebChromeClient.mm:
1166         (WebChromeClient::showPlaybackTargetPicker): New.
1167         (WebChromeClient::startingMonitoringPlaybackTargets): New.
1168         (WebChromeClient::stopMonitoringPlaybackTargets): New.
1169
1170         * WebView/WebView.mm:
1171         (-[WebView _close]): Invalidate and free the target picker.
1172         (-[WebView _devicePicker]): New.
1173         (-[WebView _showPlaybackTargetPicker:hasVideo:]): New.
1174         (-[WebView _startingMonitoringPlaybackTargets]): New.
1175         (-[WebView _stopMonitoringPlaybackTargets]): New.
1176
1177         * WebView/WebMediaPlaybackTargetPicker.h:
1178         * WebView/WebMediaPlaybackTargetPicker.mm:
1179         (WebMediaPlaybackTargetPicker::create): New.
1180         (WebMediaPlaybackTargetPicker::WebMediaPlaybackTargetPicker): New.
1181         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): New.
1182         (WebMediaPlaybackTargetPicker::startingMonitoringPlaybackTargets): New.
1183         (WebMediaPlaybackTargetPicker::stopMonitoringPlaybackTargets): New.
1184         (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): New.
1185         (WebMediaPlaybackTargetPicker::externalOutputDeviceAvailableDidChange): New.
1186         (WebMediaPlaybackTargetPicker::invalidate): New.
1187         (WebMediaPlaybackTargetPicker::targetPicker): New.
1188
1189         * WebView/WebViewData.h:
1190         (WebMediaPlaybackTargetPicker::~WebMediaPlaybackTargetPicker):
1191         * WebView/WebViewData.mm:
1192         * WebView/WebViewInternal.h:
1193
1194 2015-03-19  Andy Estes  <aestes@apple.com>
1195
1196         [Content Filtering] Add tests for unblock requests
1197         https://bugs.webkit.org/show_bug.cgi?id=142900
1198
1199         Reviewed by Andreas Kling.
1200
1201         * WebCoreSupport/WebFrameLoaderClient.mm:
1202         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): This now happens in PolicyChecker.
1203         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
1204         * WebView/WebFrame.mm:
1205         (-[WebFrame _contentFilterDidHandleNavigationAction:]): Deleted.
1206         * WebView/WebFrameInternal.h: Removed contentFilterUnblockHandler from WebFramePrivate.
1207
1208 2015-03-19  Enrica Casucci  <enrica@apple.com>
1209
1210         <attachment> should put URLs on the pasteboard so that Finder can accept drops.
1211         https://bugs.webkit.org/show_bug.cgi?id=142801
1212         rdar://problem/19982527
1213
1214         Reviewed by Tim Horton.
1215
1216         This patch adds all the necessary support to write attachment elements into
1217         the pasteboard, including the promised type in WK1.
1218
1219         * Misc/WebNSPasteboardExtras.mm:
1220         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1221         * WebCoreSupport/WebDragClient.h:
1222         * WebCoreSupport/WebDragClient.mm:
1223         (WebDragClient::declareAndWriteAttachment):
1224         * WebView/WebHTMLView.mm:
1225         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1226         * WebView/WebUIDelegate.h:
1227
1228 2015-03-19  Chris Dumez  <cdumez@apple.com>
1229
1230         Clean up DOMTimer related settings
1231         https://bugs.webkit.org/show_bug.cgi?id=142837
1232
1233         Reviewed by Darin Adler.
1234
1235         Stop setting the DOMTimers' default minimum interval to 4ms as this
1236         is now the default.
1237
1238         * WebView/WebView.mm:
1239         (-[WebView _commonInitializationWithFrameName:groupName:]):
1240
1241 2015-03-17  Conrad Shultz  <conrad_shultz@apple.com>
1242
1243         Ignore some deprecation warnings
1244         https://bugs.webkit.org/show_bug.cgi?id=142813
1245
1246         Reviewed by Mark Rowe.
1247
1248         Fixing the deprecations is tracked by: <rdar://problem/20201450>
1249
1250         * WebCoreSupport/PopupMenuMac.mm:
1251         (PopupMenuMac::populate):
1252
1253 2015-03-17  Tim Horton  <timothy_horton@apple.com>
1254
1255         Cannot invoke action menus anymore
1256         https://bugs.webkit.org/show_bug.cgi?id=142797
1257         <rdar://problem/20032670>
1258
1259         * WebView/WebHTMLView.mm:
1260         (-[WebHTMLView otherMouseDown:]):
1261         Need a respondsToSelector check.
1262
1263 2015-03-17  Tim Horton  <timothy_horton@apple.com>
1264
1265         Fix the iOS build
1266
1267         * WebView/WebHTMLView.mm:
1268
1269 2015-03-17  Tim Horton  <timothy_horton@apple.com>
1270
1271         Cannot invoke action menus anymore
1272         https://bugs.webkit.org/show_bug.cgi?id=142797
1273         <rdar://problem/20032670>
1274
1275         Reviewed by Beth Dakin.
1276
1277         * WebView/WebHTMLView.mm:
1278         (-[WebHTMLView otherMouseDown:]):
1279         Don't override otherMouseDown: if the event would make an action menu.
1280
1281 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
1282
1283         Enable ES6 classes by default
1284         https://bugs.webkit.org/show_bug.cgi?id=142774
1285
1286         Reviewed by Gavin Barraclough.
1287
1288         * Configurations/FeatureDefines.xcconfig:
1289
1290 2015-03-16  Brent Fulgham  <bfulgham@apple.com>
1291
1292         WebKit1 Clients Are Not Reliably Repainted
1293         https://bugs.webkit.org/show_bug.cgi?id=142750
1294         <rdar://problem/20042453>
1295
1296         Reviewed by Simon Fraser.
1297
1298         Check with the FrameView to see if we are in an immediately paintable state. If we are not,
1299         mark the view as dirty once the _immediateScrollToPoint operation is complete so that the
1300         region will be painted properly.
1301
1302         * WebView/WebClipView.mm:
1303         (-[WebClipView _immediateScrollToPoint:]): 
1304
1305 2015-03-16  Conrad Shultz  <conrad_shultz@apple.com>
1306
1307         Allow clients to selectively disable plug-ins
1308         https://bugs.webkit.org/show_bug.cgi?id=142506
1309
1310         Reviewed by Anders Carlsson.
1311
1312         Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
1313         from the page). As part of this:
1314
1315         1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying
1316            set of plug-ins.
1317
1318         2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper
1319            down the stack.
1320
1321         3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce
1322            a concrete implementation thereof in WebPlatformStrategies in WebKit2.
1323
1324         4) Add messaging infrastructure to allow clients to set and clear plug-in policies.
1325
1326         While currently only used in a very limited manner, the new declarative plug-in policies are written generically
1327         so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.
1328
1329         * Plugins/WebBasePluginPackage.mm:
1330         (-[WebBasePluginPackage getPluginInfoFromPLists]):
1331         Set new members in PluginInfo.
1332
1333         * Plugins/WebNetscapePluginPackage.mm:
1334         (-[WebNetscapePluginPackage getPluginInfoFromResources]):
1335         Set new members in PluginInfo.
1336
1337         * WebCoreSupport/WebPlatformStrategies.h:
1338         * WebCoreSupport/WebPlatformStrategies.mm:
1339         (WebPlatformStrategies::getWebVisiblePluginInfo):
1340         Override to wrap getPluginInfo().
1341         (WebPlatformStrategies::setPluginLoadClientPolicy):
1342         Override to do nothing.
1343         (WebPlatformStrategies::clearPluginClientPolicies):
1344         Ditto.
1345
1346         * WebView/WebFrame.mm:
1347         (-[WebFrame _canProvideDocumentSource]):
1348         Update to reflect function rename.
1349
1350 2015-03-14  Dean Jackson  <dino@apple.com>
1351
1352         Feature flag for Animations Level 2
1353         https://bugs.webkit.org/show_bug.cgi?id=142699
1354         <rdar://problem/20165097>
1355
1356         Reviewed by Brent Fulgham.
1357
1358         Add ENABLE_CSS_ANIMATIONS_LEVEL_2 and a runtime flag animationTriggersEnabled.
1359
1360         * Configurations/FeatureDefines.xcconfig:
1361
1362 2015-03-13  Commit Queue  <commit-queue@webkit.org>
1363
1364         Unreviewed, rolling out r181483.
1365         https://bugs.webkit.org/show_bug.cgi?id=142688
1366
1367         Caused use-after-free on many tests (Requested by ap on
1368         #webkit).
1369
1370         Reverted changeset:
1371
1372         "Allow clients to selectively disable plug-ins"
1373         https://bugs.webkit.org/show_bug.cgi?id=142506
1374         http://trac.webkit.org/changeset/181483
1375
1376 2015-03-13  Eric Carlson  <eric.carlson@apple.com>
1377
1378         [Mac] Enable WIRELESS_PLAYBACK_TARGET
1379         https://bugs.webkit.org/show_bug.cgi?id=142635
1380
1381         Reviewed by Darin Adler.
1382
1383         * Configurations/FeatureDefines.xcconfig:
1384
1385 2015-03-10  Conrad Shultz  <conrad_shultz@apple.com>
1386
1387         Allow clients to selectively disable plug-ins
1388         https://bugs.webkit.org/show_bug.cgi?id=142506
1389
1390         Reviewed by Anders Carlsson.
1391
1392         Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
1393         from the page). As part of this:
1394
1395         1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying
1396            set of plug-ins.
1397
1398         2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper
1399            down the stack.
1400
1401         3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce
1402            a concrete implementation thereof in WebPlatformStrategies in WebKit2.
1403
1404         4) Add messaging infrastructure to allow clients to set and clear plug-in policies.
1405
1406         While currently only used in a very limited manner, the new declarative plug-in policies are written generically
1407         so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.
1408
1409         * Plugins/WebBasePluginPackage.mm:
1410         (-[WebBasePluginPackage getPluginInfoFromPLists]):
1411         Set new members in PluginInfo.
1412
1413         * Plugins/WebNetscapePluginPackage.mm:
1414         (-[WebNetscapePluginPackage getPluginInfoFromResources]):
1415         Set new members in PluginInfo.
1416
1417         * WebCoreSupport/WebPlatformStrategies.h:
1418         * WebCoreSupport/WebPlatformStrategies.mm:
1419         (WebPlatformStrategies::getWebVisiblePluginInfo):
1420         Override to wrap getPluginInfo().
1421         (WebPlatformStrategies::setPluginLoadClientPolicy):
1422         Override to do nothing.
1423         (WebPlatformStrategies::clearPluginClientPolicies):
1424         Ditto.
1425
1426         * WebView/WebFrame.mm:
1427         (-[WebFrame _canProvideDocumentSource]):
1428         Update to reflect function rename.
1429
1430 2015-03-10  Sam Weinig  <sam@webkit.org>
1431
1432         Allow adding a button in input elements for auto fill related functionality
1433         <rdar://problem/19782066>
1434         https://bugs.webkit.org/show_bug.cgi?id=142564
1435
1436         Reviewed by Anders Carlsson.
1437
1438         * DOM/WebDOMOperations.mm:
1439         (-[DOMHTMLInputElement _setAutofilled:]):
1440         Update for consistent spelling of AutoFill.
1441
1442 2015-03-10  Timothy Horton  <timothy_horton@apple.com>
1443
1444         Fix the build
1445
1446         * History/WebHistory.mm:
1447         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
1448         * WebCoreSupport/WebFrameLoaderClient.mm:
1449         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1450
1451 2015-03-10  Tim Horton  <timothy_horton@apple.com>
1452
1453         Fix the Mac build with a newer compiler
1454
1455         * Plugins/WebPluginController.mm:
1456         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
1457         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
1458
1459 2015-03-09  David Kilzer  <ddkilzer@apple.com>
1460
1461         [iOS] Fix build when compiling with dead code stripping disabled
1462         <http://webkit.org/b/142467>
1463
1464         Reviewed by Simon Fraser.
1465
1466         * Configurations/WebKitLegacy.xcconfig:
1467         (EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*]): Disable mig code
1468         generation and compilation for out-of-process plugin support.
1469         This was never used on iOS.
1470
1471 2015-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
1472
1473         [iOS] SVG fonts are garbled
1474         https://bugs.webkit.org/show_bug.cgi?id=142377
1475
1476         Reviewed by Simon Fraser.
1477
1478         * Configurations/FeatureDefines.xcconfig:
1479
1480 2015-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
1481
1482         Hide Promise with runtime flags under Cocoa JSContext API
1483         https://bugs.webkit.org/show_bug.cgi?id=141965
1484
1485         Reviewed by Filip Pizlo.
1486
1487         Add new JSC runtime flag, PromiseDisabled.
1488
1489         * WebView/WebPreferencesPrivate.h:
1490
1491 2015-03-03  Andy Estes  <aestes@apple.com>
1492
1493         [Content Filtering] Separate unblock handling into its own class
1494         https://bugs.webkit.org/show_bug.cgi?id=142251
1495
1496         Reviewed by Andreas Kling.
1497         
1498         Adopted ContentFilterUnblockHandler.
1499
1500         * WebCoreSupport/WebFrameLoaderClient.h:
1501         * WebCoreSupport/WebFrameLoaderClient.mm:
1502         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1503         * WebView/WebFrame.mm:
1504         (-[WebFrame _contentFilterDidHandleNavigationAction:]):
1505         * WebView/WebFrameInternal.h:
1506
1507 2015-03-03  Chris Dumez  <cdumez@apple.com>
1508
1509         Access ApplicationCacheStorage global instance via singleton() static member function
1510         https://bugs.webkit.org/show_bug.cgi?id=142239
1511
1512         Reviewed by Anders Carlsson.
1513
1514         Access ApplicationCacheStorage global instance via singleton() static
1515         member function as per WebKit coding style.
1516
1517 2015-03-02  Jer Noble  <jer.noble@apple.com>
1518
1519         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
1520         https://bugs.webkit.org/show_bug.cgi?id=142121
1521
1522         Reviewed by Simon Fraser.
1523
1524         Fullscreening a page with a non-1 scale would result in that scale being applied to the
1525         fullscreen content, breaking fullscreen mode. Set the page scale to 1 when entering
1526         fullscreen and reset it to the original value when exiting fullscreen.
1527
1528         * WebView/WebFullScreenController.h:
1529         * WebView/WebFullScreenController.mm:
1530         (-[WebFullScreenController enterFullScreen:]): Set the page scale to 1.
1531         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Reset the page
1532                 scale to the original value.
1533         * WebView/WebView.mm:
1534         (-[WebView _supportsFullScreenForElement:withKeyboard:]): Drive-by fix. Check the
1535                 WebView's own preferences to see if fullscreen mode is enabled, rather than
1536                 the global object's.
1537
1538 2015-03-01  Chris Dumez  <cdumez@apple.com>
1539
1540         Make NotificationCenter / Notification suspendable
1541         https://bugs.webkit.org/show_bug.cgi?id=142117
1542         <rdar://problem/19923085>
1543
1544         Reviewed by Andreas Kling.
1545
1546         Provide implementation for NotificationClient::hasPendingPermissionRequests().
1547         The implementation is very simplistic. it will only return false if no
1548         request for permission for ever made. This is because there is currently no
1549         easy way to figure out if a permission request is pending or not.
1550
1551         * WebCoreSupport/WebNotificationClient.h:
1552         * WebCoreSupport/WebNotificationClient.mm:
1553         (WebNotificationClient::requestPermission):
1554         (WebNotificationClient::hasPendingPermissionRequests):
1555
1556 2015-02-28  Simon Fraser  <simon.fraser@apple.com>
1557
1558         Viewport units should not dirty style just before we do layout
1559         https://bugs.webkit.org/show_bug.cgi?id=141682
1560
1561         Reviewed by Zalan Bujtas.
1562
1563         * WebView/WebFrameView.mm:
1564         (-[WebFrameView _frameSizeChanged]):
1565
1566 2015-02-26  Chris Dumez  <cdumez@apple.com>
1567
1568         Rename DatabaseManager::manager() to DatabaseManager::singleton()
1569         https://bugs.webkit.org/show_bug.cgi?id=142054
1570
1571         Reviewed by Ryosuke Niwa.
1572
1573         Rename DatabaseManager::manager() to DatabaseManager::singleton() as
1574         per coding style and use WTF::NeverDestroyed.
1575
1576         * Storage/WebDatabaseManager.mm:
1577         (-[WebDatabaseManager init]):
1578         (-[WebDatabaseManager origins]):
1579         (-[WebDatabaseManager databasesWithOrigin:]):
1580         (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
1581         (-[WebDatabaseManager deleteAllDatabases]):
1582         (-[WebDatabaseManager deleteOrigin:]):
1583         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
1584         * Storage/WebDatabaseQuotaManager.mm:
1585         (-[WebDatabaseQuotaManager usage]):
1586         (-[WebDatabaseQuotaManager quota]):
1587         (-[WebDatabaseQuotaManager setQuota:]):
1588         * WebCoreSupport/WebSecurityOrigin.mm:
1589         (-[WebSecurityOrigin usage]):
1590         (-[WebSecurityOrigin quota]):
1591         (-[WebSecurityOrigin setQuota:]):
1592         * WebView/WebFrame.mm:
1593         (-[WebFrame _cacheabilityDictionary]):
1594         * WebView/WebView.mm:
1595         (-[WebView _preferencesChanged:]):
1596
1597 2015-02-26  Myles C. Maxfield  <mmaxfield@apple.com>
1598
1599         [Mac] [iOS] Parsing support for -apple-trailing-word
1600         https://bugs.webkit.org/show_bug.cgi?id=141939
1601
1602         Reviewed by Andreas Kling.
1603
1604         * Configurations/FeatureDefines.xcconfig:
1605
1606 2015-02-24  Commit Queue  <commit-queue@webkit.org>
1607
1608         Unreviewed, rolling out r180599.
1609         https://bugs.webkit.org/show_bug.cgi?id=141998
1610
1611         Lots of new test failures (Requested by smfr on #webkit).
1612
1613         Reverted changeset:
1614
1615         "Parsing support for -webkit-trailing-word"
1616         https://bugs.webkit.org/show_bug.cgi?id=141939
1617         http://trac.webkit.org/changeset/180599
1618
1619 2015-02-24  Myles C. Maxfield  <mmaxfield@apple.com>
1620
1621         [Mac] [iOS] Parsing support for -apple-trailing-word
1622         https://bugs.webkit.org/show_bug.cgi?id=141939
1623
1624         Reviewed by Andreas Kling.
1625
1626         * Configurations/FeatureDefines.xcconfig:
1627
1628 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
1629
1630         REGRESSION(r179429): Can't type comments in Facebook
1631         https://bugs.webkit.org/show_bug.cgi?id=141859
1632
1633         Reviewed by Brent Fulgham.
1634
1635         Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
1636         Private API, javaScriptExperimentsEnabled is dropped.
1637
1638         * Misc/WebNSDictionaryExtras.h:
1639         * Misc/WebNSDictionaryExtras.m:
1640         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
1641         * WebKit.order:
1642         * WebView/WebPreferenceKeysPrivate.h:
1643         * WebView/WebPreferences.mm:
1644         (+[WebPreferences initialize]):
1645         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1646         (-[WebPreferences javaScriptRuntimeFlags]):
1647         (-[WebPreferences setJavaScriptRuntimeFlags:]):
1648         (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
1649         (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
1650         * WebView/WebPreferencesPrivate.h:
1651         * WebView/WebView.mm:
1652         (-[WebView _preferencesChanged:]):
1653
1654 2015-02-23  Commit Queue  <commit-queue@webkit.org>
1655
1656         Unreviewed, rolling out r180547 and r180550.
1657         https://bugs.webkit.org/show_bug.cgi?id=141957
1658
1659         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
1660
1661         Reverted changesets:
1662
1663         "REGRESSION(r179429): Can't type comments in Facebook"
1664         https://bugs.webkit.org/show_bug.cgi?id=141859
1665         http://trac.webkit.org/changeset/180547
1666
1667         "Constructor returning null should construct an object instead
1668         of null"
1669         https://bugs.webkit.org/show_bug.cgi?id=141640
1670         http://trac.webkit.org/changeset/180550
1671
1672 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
1673
1674         Disable font loading events until our implementation gets updated to match the latest spec
1675         https://bugs.webkit.org/show_bug.cgi?id=141938
1676
1677         Reviewed by Andreas Kling.
1678
1679         * Configurations/FeatureDefines.xcconfig:
1680
1681 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1682
1683         REGRESSION(r179429): Can't type comments in Facebook
1684         https://bugs.webkit.org/show_bug.cgi?id=141859
1685
1686         Reviewed by Geoffrey Garen.
1687
1688         Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
1689         Private API, javaScriptExperimentsEnabled is dropped.
1690
1691         * Misc/WebNSDictionaryExtras.h:
1692         * Misc/WebNSDictionaryExtras.m:
1693         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
1694         * WebKit.order:
1695         * WebView/WebPreferenceKeysPrivate.h:
1696         * WebView/WebPreferences.mm:
1697         (+[WebPreferences initialize]):
1698         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1699         (-[WebPreferences javaScriptRuntimeFlags]):
1700         (-[WebPreferences setJavaScriptRuntimeFlags:]):
1701         (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
1702         (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
1703         * WebView/WebPreferencesPrivate.h:
1704         * WebView/WebView.mm:
1705         (-[WebView _preferencesChanged:]):
1706
1707 2015-02-20  Eric Carlson  <eric.carlson@apple.com>
1708
1709         [iOS] cleanup AirPlay code
1710         https://bugs.webkit.org/show_bug.cgi?id=141811
1711
1712         Reviewed by Jer Noble.
1713
1714         * Configurations/FeatureDefines.xcconfig: IOS_AIRPLAY -> WIRELESS_PLAYBACK_TARGET.
1715
1716 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
1717
1718         Adopt WebCore::IOSurface in ImageBuffer
1719         https://bugs.webkit.org/show_bug.cgi?id=141751
1720
1721         Reviewed by Simon Fraser.
1722
1723         * WebCoreSupport/WebSystemInterface.mm:
1724         (InitWebCoreSystemInterface):
1725         Remove old WKSI IOSurface-related functions.
1726
1727 2015-02-18  Commit Queue  <commit-queue@webkit.org>
1728
1729         Unreviewed, rolling out r180286.
1730         https://bugs.webkit.org/show_bug.cgi?id=141766
1731
1732         Caused >50 crashed LayoutTests (Requested by jernoble on
1733         #webkit).
1734
1735         Reverted changeset:
1736
1737         "Page::userContentController() should return a reference, not
1738         a pointer"
1739         https://bugs.webkit.org/show_bug.cgi?id=141764
1740         http://trac.webkit.org/changeset/180286
1741
1742 2015-02-18  Brady Eidson  <beidson@apple.com>
1743
1744         Page::userContentController() should return a reference, not a pointer
1745         https://bugs.webkit.org/show_bug.cgi?id=141764
1746
1747         Reviewed by Jer Noble.
1748
1749         * WebView/WebView.mm:
1750         (-[WebView setGroupName:]):
1751
1752 2015-02-18  Chris Dumez  <cdumez@apple.com>
1753
1754         Access FontCache global instance via singleton() static member function
1755         https://bugs.webkit.org/show_bug.cgi?id=141726
1756
1757         Reviewed by Daniel Bates.
1758
1759         Access FontCache global instance via singleton() static member function,
1760         as per coding style.
1761
1762 2015-02-17  Chris Dumez  <cdumez@apple.com>
1763
1764         Access MemoryPressureHandler global instance via a singleton() static member function
1765         https://bugs.webkit.org/show_bug.cgi?id=141691
1766
1767         Reviewed by Andreas Kling.
1768
1769         Access MemoryPressureHandler global instance via a singleton() static
1770         member function.
1771
1772         * WebView/WebView.mm:
1773         (-[WebView _commonInitializationWithFrameName:groupName:]):
1774         (+[WebView registerForMemoryNotifications]):
1775         (+[WebView _isUnderMemoryPressure]):
1776         (+[WebView _clearMemoryPressure]):
1777         (+[WebView _shouldWaitForMemoryClearMessage]):
1778         (WebInstallMemoryPressureHandler):
1779
1780 2015-02-15  Sam Weinig  <sam@webkit.org>
1781
1782         Add experimental <attachment> element support
1783         https://bugs.webkit.org/show_bug.cgi?id=141626
1784
1785         Reviewed by Tim Horton.
1786
1787         * Configurations/FeatureDefines.xcconfig:
1788
1789 2015-02-14  Joseph Pecoraro  <pecoraro@apple.com>
1790
1791         [Mac] Possible DDActionContext leaks, RetainPtr cleanup
1792         https://bugs.webkit.org/show_bug.cgi?id=141613
1793
1794         Reviewed by Tim Horton.
1795
1796         * WebCoreSupport/WebEditorClient.mm:
1797         (WebEditorClient::WebEditorClient):
1798         Avoid unnecessary retain/autorelease by adopting.
1799
1800         * WebView/WebActionMenuController.mm:
1801         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1802         Adopt the allocated object.
1803
1804 2015-02-09  Brian J. Burg  <burg@cs.washington.edu>
1805
1806         Web Inspector: remove some unnecessary Inspector prefixes from class names in Inspector namespace
1807         https://bugs.webkit.org/show_bug.cgi?id=141372
1808
1809         Reviewed by Joseph Pecoraro.
1810
1811         * WebCoreSupport/WebInspectorClient.mm:
1812         (-[WebInspectorWindowController destroyInspectorView:]):
1813
1814 2015-02-14  Alexey Proskuryakov  <ap@apple.com>
1815
1816         rel="noreferrer" should make window.opener null
1817         https://bugs.webkit.org/show_bug.cgi?id=141579
1818
1819         Reviewed by Darin Adler.
1820
1821         * WebView/WebPDFView.mm:
1822         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Updated for a new WebCore
1823         function signature. There is no rel="noreferrer" in PDF, so we can just always allow.
1824
1825 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
1826
1827         [Streams API] Implement a barebone ReadableStream interface
1828         https://bugs.webkit.org/show_bug.cgi?id=141045
1829
1830         Reviewed by Benjamin Poulain.
1831
1832         * Configurations/FeatureDefines.xcconfig:
1833
1834 2015-02-03  Enrica Casucci  <enrica@apple.com>
1835
1836         [iOS] Add support for deleteFromInputWithFlags.
1837         https://bugs.webkit.org/show_bug.cgi?id=141216
1838         rdar://problem/19130081
1839
1840         Reviewed by Benjamin Poulain.
1841
1842         Adopts the new method as soon as it is available.
1843         The patch also removes some obsolete code used for staging.
1844
1845         * WebView/WebHTMLView.mm:
1846         (-[WebHTMLView _handleEditingKeyEvent:]):
1847
1848 2015-02-02  Chris Dumez  <cdumez@apple.com>
1849
1850         Access MemoryCache singleton using MemoryCache::singleton()
1851         https://bugs.webkit.org/show_bug.cgi?id=141104
1852
1853         Reviewed by Andreas Kling.
1854
1855         Access MemoryCache singleton using MemoryCache::singleton() static
1856         member function, instead of a free function, as per the recent
1857         coding style discussion on WebKit-dev.
1858
1859 2015-02-01  Chris Dumez  <cdumez@apple.com>
1860
1861         Use more references in HistoryItem
1862         https://bugs.webkit.org/show_bug.cgi?id=141133
1863
1864         Reviewed by Andreas Kling.
1865
1866         Use more references in HistoryItem instead of pointers.
1867
1868 2015-01-31  Sam Weinig  <sam@webkit.org>
1869
1870         Remove even more Mountain Lion support
1871         https://bugs.webkit.org/show_bug.cgi?id=141124
1872
1873         Reviewed by Alexey Proskuryakov.
1874
1875         * Configurations/Base.xcconfig:
1876         * Configurations/DebugRelease.xcconfig:
1877         * Configurations/FeatureDefines.xcconfig:
1878         * Configurations/Version.xcconfig:
1879         * Configurations/WebKitLegacy.xcconfig:
1880
1881 2015-01-30  Eric Carlson  <eric.carlson@apple.com>
1882
1883         Remove MediaPlayerProxy.h
1884         https://bugs.webkit.org/show_bug.cgi?id=141087
1885
1886         Reviewed by Sam Weinig.
1887
1888         * MigrateHeaders.make: Don't need to copy MediaPlayerProxy.h.
1889         * Plugins/WebPluginController.mm: Don't include MediaPlayerProxy.h.
1890
1891 2015-01-30  Chris Dumez  <cdumez@apple.com>
1892
1893         Rename shared() static member functions to singleton() for singleton classes.
1894         https://bugs.webkit.org/show_bug.cgi?id=141088
1895
1896         Reviewed by Ryosuke Niwa and Benjamin Poulain.
1897
1898         Rename shared() static member functions to singleton() for singleton
1899         classes as per the recent coding style change.
1900
1901 2015-01-29  Beth Dakin  <bdakin@apple.com>
1902
1903         Remove more Mountain Lion code from WebKit
1904         https://bugs.webkit.org/show_bug.cgi?id=141050
1905
1906         Reviewed by Anders Carlsson.
1907
1908         * History/WebHistory.mm:
1909         (getDayBoundaries):
1910         * Panels/WebAuthenticationPanel.m:
1911         (-[WebAuthenticationPanel cancel:]):
1912         (-[WebAuthenticationPanel logIn:]):
1913         (-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]):
1914         * WebCoreSupport/WebSystemInterface.mm:
1915         (InitWebCoreSystemInterface):
1916         * WebView/WebFrameView.mm:
1917         * WebView/WebPreferences.mm:
1918         (+[WebPreferences initialize]):
1919         (needsScreenFontsEnabledQuirk):
1920         * WebView/WebView.mm:
1921         (+[WebView registerForMemoryNotifications]):
1922         (-[WebView _preferencesChanged:]):
1923         (+[WebView initialize]):
1924         (+[WebView _shouldAutomaticQuoteSubstitutionBeEnabled]):
1925         (+[WebView _shouldAutomaticDashSubstitutionBeEnabled]):
1926         (+[WebView _didChangeAutomaticDashSubstitutionEnabled:]):
1927
1928 2015-01-29  Sam Weinig  <sam@webkit.org>
1929
1930         Remove support for screen font substitution
1931         https://bugs.webkit.org/show_bug.cgi?id=141038
1932
1933         Reviewed by Tim Horton.
1934
1935         * Misc/WebKitNSStringExtras.mm:
1936         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
1937         (-[NSString _web_widthWithFont:]):
1938         * Misc/WebStringTruncator.mm:
1939         (fontFromNSFont):
1940         Update for new signature of the FontPlatformData constructor, which no longer cares about
1941         whether to use printer fonts.
1942
1943         * WebView/WebPreferenceKeysPrivate.h:
1944         Remove the WebKitScreenFontSubstitutionEnabledKey key.
1945
1946         * WebView/WebPreferences.mm:
1947         (+[WebPreferences initialize]):
1948         Remove support for WebKitScreenFontSubstitutionEnabledKey.
1949
1950         (needsScreenFontsEnabledQuirk): Deleted.
1951         Remove support for the Mountain Lion era 1-Password quirk.
1952
1953         (-[WebPreferences screenFontSubstitutionEnabled]): Deleted.
1954         (-[WebPreferences setScreenFontSubstitutionEnabled:]): Deleted.
1955         * WebView/WebPreferencesPrivate.h:
1956         * WebView/WebView.mm:
1957         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1958         (-[WebView _preferencesChanged:]):
1959         Remove support for the screen font substitution setting.
1960
1961 2015-01-29  Chris Dumez  <cdumez@apple.com>
1962
1963         Clean up / modernize PageCache class
1964         https://bugs.webkit.org/show_bug.cgi?id=141009
1965
1966         Reviewed by Darin Adler.
1967
1968         Clean up / modernize PageCache class.
1969
1970         * History/WebBackForwardList.mm:
1971         (-[WebBackForwardList pageCacheSize]):
1972         * WebView/WebView.mm:
1973         (-[WebView _loadBackForwardListFromOtherView:]):
1974         (-[WebView goToBackForwardItem:]):
1975         (+[WebView _setCacheModel:]):
1976
1977 2015-01-28  Beth Dakin  <bdakin@apple.com>
1978
1979         Remove Mountain Lion code from WebKit and WebKit2
1980         https://bugs.webkit.org/show_bug.cgi?id=141010
1981
1982         Reviewed by Sam Weinig.
1983
1984         * DOM/WebDOMOperations.mm:
1985         (toNSEventPhase):
1986         * WebView/WebHTMLView.mm:
1987         (isQuickLookEvent):
1988
1989 2015-01-28  Dana Burkart  <dburkart@apple.com>
1990
1991         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
1992         https://bugs.webkit.org/show_bug.cgi?id=136765
1993
1994         Reviewed by Alexey Proskuryakov.
1995
1996         * Configurations/Base.xcconfig:
1997         * Configurations/DebugRelease.xcconfig:
1998
1999 2015-01-28  Chris Dumez  <cdumez@apple.com>
2000
2001         Fix typo in markPagesForVistedLinkStyleRecalc()
2002         https://bugs.webkit.org/show_bug.cgi?id=140977
2003
2004         Reviewed by Darin Adler.
2005
2006         * WebCoreSupport/WebVisitedLinkStore.mm:
2007         (WebVisitedLinkStore::removeAllVisitedLinks):
2008         (WebVisitedLinkStore::removeVisitedLink):
2009         (WebVisitedLinkStore::addVisitedLinkHash):
2010
2011 2015-01-28  Chris Dumez  <cdumez@apple.com>
2012
2013         Rename pageCache() to PageCache::shared() and return a reference
2014         https://bugs.webkit.org/show_bug.cgi?id=140983
2015
2016         Reviewed by Andreas Kling.
2017
2018         Rename pageCache() to PageCache::shared() as this is a singleton class
2019         and have it return a reference instead of a pointer.
2020
2021         * History/WebBackForwardList.mm:
2022         (-[WebBackForwardList pageCacheSize]):
2023         * Misc/WebCoreStatistics.mm:
2024         (+[WebCoreStatistics cachedPageCount]):
2025         (+[WebCoreStatistics cachedFrameCount]):
2026         * WebCoreSupport/WebVisitedLinkStore.mm:
2027         (WebVisitedLinkStore::removeAllVisitedLinks):
2028         (WebVisitedLinkStore::removeVisitedLink):
2029         (WebVisitedLinkStore::addVisitedLinkHash):
2030         * WebView/WebView.mm:
2031         (+[WebView _setCacheModel:]):
2032
2033 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
2034
2035         More build fixes for newer clang.
2036
2037         Rubber-stamped by Anders Carlsson.
2038
2039         Marked a deprecated accessibility method as such.
2040
2041         * WebView/WebFrame.mm:
2042         (-[WebFrame accessibilityRoot]):
2043
2044 2015-01-27  Beth Dakin  <bdakin@apple.com>
2045
2046         Immediate action gesture recognizer still doesn't work well with IB
2047         https://bugs.webkit.org/show_bug.cgi?id=140967
2048         -and corresponding-
2049         rdar://problem/19621509
2050
2051         Reviewed by Tim Horton.
2052
2053         We should add (or remove) the gesture recognizer in viewDidMoveToWindow because 
2054         initWithFrame it too early and IB might mess with it.
2055         * WebView/WebImmediateActionController.h:
2056         * WebView/WebImmediateActionController.mm:
2057         (-[WebImmediateActionController immediateActionRecognizer]):
2058         * WebView/WebView.mm:
2059         (-[WebView _commonInitializationWithFrameName:groupName:]):
2060         (-[WebView viewDidMoveToWindow]):
2061
2062 2015-01-27  Dan Bernstein  <mitz@apple.com>
2063
2064         Fixed building projects that import WebView.h with WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS.
2065
2066         Rubber-stamped by Anders Carlsson.
2067
2068         * WebView/WebView.h: Added forward declarations of the protocols.
2069
2070 2015-01-26  Anders Carlsson  <andersca@apple.com>
2071
2072         Make it easy to test enabling formal delegate protocols
2073         https://bugs.webkit.org/show_bug.cgi?id=140892
2074
2075         Reviewed by Dan Bernstein.
2076
2077         Add an WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS define that controls whether delegates should be formal protocols.
2078
2079         * Misc/WebDownload.h:
2080         * WebView/WebFrameLoadDelegate.h:
2081         * WebView/WebPolicyDelegate.h:
2082         * WebView/WebResourceLoadDelegate.h:
2083         * WebView/WebUIDelegate.h:
2084         * WebView/WebView.h:
2085
2086 2015-01-26  Chris Dumez  <cdumez@apple.com>
2087
2088         Rename Document::body() to Document::bodyOrFrameset() for clarity
2089         https://bugs.webkit.org/show_bug.cgi?id=140902
2090
2091         Reviewed by Andreas Kling.
2092
2093         Rename Document::body() to Document::bodyOrFrameset() for clarity. This
2094         method does not necessarily return an HTMLBodyElement, it can also
2095         return a frameset as per the specification:
2096         http://www.w3.org/TR/html5/dom.html#dom-tree-accessors
2097
2098         This method is often misused internally (the caller is only interested
2099         in the <body> element). I will fix these instances in a follow-up patch,
2100         this patch is only renaming mechanically.
2101
2102 2015-01-26  Chris Dumez  <cdumez@apple.com>
2103
2104         First argument to DOM traversal functions should be a reference
2105         https://bugs.webkit.org/show_bug.cgi?id=140895
2106
2107         Reviewed by Antti Koivisto.
2108
2109         First argument to DOM traversal functions should be a reference instead
2110         of a pointer as it is dereferenced without null-check.
2111
2112 2015-01-26  Myles C. Maxfield  <mmaxfield@apple.com>
2113
2114         [iOS] [SVG -> OTF Converter] Flip the switch off on iOS
2115         https://bugs.webkit.org/show_bug.cgi?id=140860
2116
2117         Reviewed by Darin Adler.
2118
2119         The fonts it makes are grotesque. (See what I did there? Typographic
2120         humor is the best humor.)
2121
2122         * Configurations/FeatureDefines.xcconfig:
2123
2124 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
2125
2126         QLPreviewMenuItem popovers don't close when the page scrolls
2127         https://bugs.webkit.org/show_bug.cgi?id=140806
2128         <rdar://problem/19555618>
2129
2130         Reviewed by Beth Dakin.
2131
2132         Now that QLPreviewMenuItem's popover doesn't eat scrolls, we need to dismiss it if the page scrolls.
2133
2134         * WebView/WebHTMLView.mm:
2135         (-[WebHTMLView scrollWheel:scrollWheel:]):
2136         Send scrollWheel along to WebImmediateActionController.
2137
2138         * WebView/WebImmediateActionController.h:
2139         * WebView/WebImmediateActionController.mm:
2140         (-[WebImmediateActionController webView:didHandleScrollWheel:]):
2141         (-[WebImmediateActionController _clearImmediateActionState]):
2142         (-[WebImmediateActionController _defaultAnimationController]):
2143         Keep track of the active QLPreviewMenuItem, and close it upon scroll.
2144
2145 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
2146
2147         Infinite recursion in _clearImmediateActionState
2148         https://bugs.webkit.org/show_bug.cgi?id=140807
2149         <rdar://problem/19571601>
2150
2151         Reviewed by Anders Carlsson.
2152
2153         * WebView/WebImmediateActionController.mm:
2154         (-[WebImmediateActionController _clearImmediateActionState]):
2155         Use this opportunity to bring identical code to WebKit1, to avoid
2156         getting DataDetectors stuck when an immediate action is canceled.
2157
2158 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2159
2160         Add a build flag for ES6 class syntax
2161         https://bugs.webkit.org/show_bug.cgi?id=140760
2162
2163         Reviewed by Michael Saboff.
2164
2165         * Configurations/FeatureDefines.xcconfig:
2166
2167 2015-01-22  Beth Dakin  <bdakin@apple.com>
2168
2169         ibtoold crash below -[WebView close]
2170         https://bugs.webkit.org/show_bug.cgi?id=140782
2171         -and corresponding-
2172         rdar://problem/19558472
2173
2174         Reviewed by Tim Horton.
2175
2176         Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but 
2177         it is because interface builder is messing with our views.
2178         * WebView/WebImmediateActionController.h:
2179         * WebView/WebImmediateActionController.mm:
2180         (-[WebImmediateActionController webViewClosed]):
2181         (-[WebImmediateActionController _cancelImmediateAction]):
2182         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2183         (-[WebImmediateActionController _updateImmediateActionItem]):
2184
2185 2015-01-21  Beth Dakin  <bdakin@apple.com>
2186
2187         Crash in QuickLook preview delegate method
2188         https://bugs.webkit.org/show_bug.cgi?id=140740
2189         -and corresponding-
2190         rdar://problem/19540806
2191
2192         Reviewed by Tim Horton.
2193
2194         Clear out the delegate.
2195         * WebView/WebImmediateActionController.mm:
2196         (-[WebImmediateActionController webViewClosed]):
2197
2198 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
2199
2200         Remove ENABLE(INSPECTOR) ifdef guards
2201         https://bugs.webkit.org/show_bug.cgi?id=140668
2202
2203         Reviewed by Darin Adler.
2204
2205         * Configurations/FeatureDefines.xcconfig:
2206         * WebCoreSupport/WebFrameLoaderClient.mm:
2207         (WebFrameLoaderClient::dispatchWillSendRequest):
2208
2209 2015-01-20  Anders Carlsson  <andersca@apple.com>
2210
2211         Remove USE(GLIB) code from WebKit1
2212         https://bugs.webkit.org/show_bug.cgi?id=140714
2213
2214         Reviewed by Andreas Kling.
2215
2216         * WebView/WebView.mm:
2217         (-[WebView _commonInitializationWithFrameName:groupName:]):
2218         (-[WebView _close]):
2219         (-[WebView _clearGlibLoopObserver]): Deleted.
2220         (glibContextIterationCallback): Deleted.
2221         (-[WebView _scheduleGlibContextIterations]): Deleted.
2222         * WebView/WebViewData.h:
2223         * WebView/WebViewInternal.h:
2224
2225 2015-01-20  David Kilzer  <ddkilzer@apple.com>
2226
2227         Switch to comparing PLATFORM_NAME in terms of macosx
2228         <http://webkit.org/b/139516>
2229
2230         Reviewed by Timothy Hatcher.
2231
2232         * MigrateHeaders.make:
2233         * postprocess-headers.sh:
2234
2235 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2236
2237         [SVG -> OTF Converter] Flip the switch on
2238         https://bugs.webkit.org/show_bug.cgi?id=140592
2239
2240         Reviewed by Antti Koivisto.
2241
2242         * Configurations/FeatureDefines.xcconfig:
2243
2244 2015-01-19  Beth Dakin  <bdakin@apple.com>
2245
2246         Speculative build fix.
2247
2248         * WebView/WebView.mm:
2249         (-[WebView _commonInitializationWithFrameName:groupName:]):
2250
2251 2015-01-19  Beth Dakin  <bdakin@apple.com>
2252
2253         Speculative build fix.
2254
2255         * WebView/WebView.mm:
2256         (-[WebView _convertRectFromRootView:]):
2257
2258 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
2259
2260         Adjust naming of action menu SPI
2261         https://bugs.webkit.org/show_bug.cgi?id=140644
2262         <rdar://problem/19448129>
2263
2264         Reviewed by Brian Weinstein.
2265
2266         * WebView/WebActionMenuController.mm:
2267         (-[WebActionMenuController prepareForMenu:withEvent:]):
2268         (-[WebActionMenuController willOpenMenu:withEvent:]):
2269         (-[WebActionMenuController didCloseMenu:withEvent:]):
2270         * WebView/WebView.mm:
2271         (-[WebView _commonInitializationWithFrameName:groupName:]):
2272         (-[WebView prepareForMenu:withEvent:]):
2273         (-[WebView willOpenMenu:withEvent:]):
2274         (-[WebView didCloseMenu:withEvent:]):
2275
2276 2015-01-19  Beth Dakin  <bdakin@apple.com>
2277
2278         REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is 
2279         offset by flipped-ness
2280         https://bugs.webkit.org/show_bug.cgi?id=140643
2281         -and corresponding-
2282         rdar://problem/19489593
2283
2284         Reviewed by Tim Horton.
2285
2286         We universally flipped because we assumed that the root view was flipped and the 
2287         WebView was not. However, in Dictionary, the WebView is flipped! So this patch 
2288         fixes that assumption by checking the WebView’s flipped-ness.
2289         * WebView/WebView.mm:
2290         (-[WebView _convertRectFromRootView:]):
2291
2292 2015-01-19  Commit Queue  <commit-queue@webkit.org>
2293
2294         Unreviewed, rolling out r178653.
2295         https://bugs.webkit.org/show_bug.cgi?id=140634
2296
2297         Broke multiple SVG tests on Mountain Lion (Requested by ap on
2298         #webkit).
2299
2300         Reverted changeset:
2301
2302         "[SVG -> OTF Converter] Flip the switch on"
2303         https://bugs.webkit.org/show_bug.cgi?id=140592
2304         http://trac.webkit.org/changeset/178653
2305
2306 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2307
2308         [SVG -> OTF Converter] Flip the switch on
2309         https://bugs.webkit.org/show_bug.cgi?id=140592
2310
2311         Reviewed by Antti Koivisto.
2312
2313         * Configurations/FeatureDefines.xcconfig:
2314
2315 2015-01-18  Daniel Bates  <dabates@apple.com>
2316
2317         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/178631>
2318         (https://bugs.webkit.org/show_bug.cgi?id=129441)
2319
2320         Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight().
2321         Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.
2322
2323         * WebInspector/WebNodeHighlightView.mm:
2324         (-[WebNodeHighlightView layoutSublayers:]):
2325
2326 2015-01-16  Beth Dakin  <bdakin@apple.com>
2327
2328         Make sure early cancellation of immediate action actually does that in WK1
2329         https://bugs.webkit.org/show_bug.cgi?id=140566
2330         -and corresponding-
2331         rdar://problem/19490114
2332
2333         Reviewed by Tim Horton.
2334
2335         Work around an AppKit bug by dispatching the call to _cancelImmediateAction 
2336         asynchronously.
2337         * WebView/WebImmediateActionController.mm:
2338         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2339
2340 2015-01-16  Daniel Bates  <dabates@apple.com>
2341
2342         Fix the public iOS SDK build after <http://trac.webkit.org/changeset/178285>
2343         (https://bugs.webkit.org/show_bug.cgi?id=140360)
2344
2345         Forward declare protocol NSURLDownloadDelegate as it is SPI on iOS.
2346
2347         * Misc/WebDownload.h:
2348
2349 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
2350
2351         Remove ENABLE(SQL_DATABASE) guards
2352         https://bugs.webkit.org/show_bug.cgi?id=140434
2353
2354         Reviewed by Darin Adler.
2355
2356         * Configurations/FeatureDefines.xcconfig:
2357         * Storage/WebDatabaseManager.mm:
2358         (databasesDirectoryPath):
2359         * Storage/WebDatabaseManagerClient.h:
2360         * Storage/WebDatabaseManagerClient.mm:
2361         * Storage/WebDatabaseManagerInternal.h:
2362         * Storage/WebDatabaseManagerPrivate.h:
2363         * Storage/WebDatabaseQuotaManager.mm:
2364         (-[WebDatabaseQuotaManager usage]):
2365         (-[WebDatabaseQuotaManager quota]):
2366         (-[WebDatabaseQuotaManager setQuota:]):
2367         * WebCoreSupport/WebChromeClient.h:
2368         * WebCoreSupport/WebChromeClient.mm:
2369         * WebCoreSupport/WebSecurityOrigin.mm:
2370         (-[WebSecurityOrigin usage]):
2371         (-[WebSecurityOrigin quota]):
2372         (-[WebSecurityOrigin setQuota:]):
2373         * WebView/WebFrame.mm:
2374         (-[WebFrame _cacheabilityDictionary]):
2375         * WebView/WebView.mm:
2376         (-[WebView _commonInitializationWithFrameName:groupName:]):
2377         (-[WebView _preferencesChanged:]):
2378
2379 2015-01-14  Chris Dumez  <cdumez@apple.com>
2380
2381         Make 'TypeName' parameter unnecessary in CSSPropertyNames.in
2382         https://bugs.webkit.org/show_bug.cgi?id=140347
2383
2384         Reviewed by Darin Adler.
2385
2386         Call FontDescription::setIsItalic() instead of setItalic() as the
2387         call site passes a boolean.
2388
2389         * WebView/WebHTMLView.mm:
2390         (fontNameForDescription):
2391
2392 2015-01-13  Anders Carlsson  <andersca@apple.com>
2393
2394         Temporarily reintroduce the informal delegate protocols
2395         https://bugs.webkit.org/show_bug.cgi?id=140416
2396
2397         Reviewed by Dan Bernstein.
2398
2399         * WebView/WebEditingDelegate.h:
2400         * WebView/WebFrameLoadDelegate.h:
2401         * WebView/WebPolicyDelegate.h:
2402         * WebView/WebResourceLoadDelegate.h:
2403         * WebView/WebUIDelegate.h:
2404
2405 2015-01-13  Beth Dakin  <bdakin@apple.com>
2406
2407         Should disable immediate actions for iTunes
2408         https://bugs.webkit.org/show_bug.cgi?id=140405
2409         -and corresponding-
2410         rdar://problem/19461358
2411
2412         Reviewed by Tim Horton.
2413
2414         * WebView/WebImmediateActionController.mm:
2415         (-[WebImmediateActionController _updateImmediateActionItem]):
2416
2417 2015-01-11  Sam Weinig  <sam@webkit.org>
2418
2419         Remove support for SharedWorkers
2420         https://bugs.webkit.org/show_bug.cgi?id=140344
2421
2422         Reviewed by Anders Carlsson.
2423
2424         * Configurations/FeatureDefines.xcconfig:
2425         * WebCoreSupport/WebPlatformStrategies.h:
2426         * WebCoreSupport/WebPlatformStrategies.mm:
2427         (WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
2428
2429 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
2430
2431         Get rid of unnecessary reimplementations of CGFloor/Ceiling
2432         https://bugs.webkit.org/show_bug.cgi?id=140375
2433
2434         Reviewed by Simon Fraser.
2435
2436         * Misc/WebKitNSStringExtras.mm:
2437         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2438         (webkit_CGCeiling): Deleted.
2439         Delete unnecessary code, use the real CGFloor/Ceiling instead.
2440
2441 2015-01-12  Anders Carlsson  <andersca@apple.com>
2442
2443         Make delegates conform to formal delegate protocols
2444         https://bugs.webkit.org/show_bug.cgi?id=140370
2445
2446         Reviewed by Dan Bernstein.
2447
2448         * DefaultDelegates/WebDefaultPolicyDelegate.h:
2449         * WebCoreSupport/WebInspectorClient.mm:
2450         Add protocols to the interface declarations.
2451
2452         * WebView/WebActionMenuController.mm:
2453         (-[WebActionMenuController prepareForMenu:withEvent:]):
2454         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2455         * WebView/WebImmediateActionController.mm:
2456         (-[WebImmediateActionController _updateImmediateActionItem]):
2457         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2458         Cast to id when trying to invoke delegate methods that aren't on WebUIDelegate.
2459
2460 2015-01-12  Myles C. Maxfield  <mmaxfield@apple.com>
2461
2462         Allow targetting the SVG->OTF font converter with ENABLE(SVG_OTF_CONVERTER)
2463         https://bugs.webkit.org/show_bug.cgi?id=136769
2464
2465         Reviewed by Antti Koivisto.
2466
2467         * Configurations/FeatureDefines.xcconfig:
2468
2469 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
2470
2471         Multi-rect TextIndicators are vertically flipped in WebKit1
2472         https://bugs.webkit.org/show_bug.cgi?id=140350
2473         <rdar://problem/19441243>
2474
2475         Reviewed by Beth Dakin.
2476
2477         * WebView/WebView.mm:
2478         (-[WebView _setTextIndicator:fadeOut:]):
2479         Convert the textBoundingRect from root view to screen coordinates.
2480
2481 2015-01-12  Anders Carlsson  <andersca@apple.com>
2482
2483         Make WebResourceDelegate a formal protocol as well
2484         https://bugs.webkit.org/show_bug.cgi?id=140364
2485
2486         Reviewed by Dan Bernstein.
2487
2488         * WebView/WebResourceLoadDelegate.h:
2489
2490 2015-01-12  Anders Carlsson  <andersca@apple.com>
2491
2492         Delegates should be formal protocols
2493         https://bugs.webkit.org/show_bug.cgi?id=140360
2494         rdar://problem/17380856
2495
2496         Reviewed by Dan Bernstein.
2497
2498         This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
2499
2500         * DefaultDelegates/WebDefaultUIDelegate.h:
2501         * Misc/WebDownload.h:
2502         * WebView/WebEditingDelegate.h:
2503         * WebView/WebFrameLoadDelegate.h:
2504         * WebView/WebPolicyDelegate.h:
2505         * WebView/WebUIDelegate.h:
2506
2507 2015-01-09  Anders Carlsson  <andersca@apple.com>
2508
2509         Get rid of the database strategy
2510         https://bugs.webkit.org/show_bug.cgi?id=140322
2511
2512         Reviewed by Sam Weinig.
2513
2514         * WebCoreSupport/WebPlatformStrategies.h:
2515         * WebCoreSupport/WebPlatformStrategies.mm:
2516         (WebPlatformStrategies::createDatabaseStrategy): Deleted.
2517
2518 2015-01-08  Timothy Horton  <timothy_horton@apple.com>
2519
2520         Can't use DataDetectors after immediate action preparation
2521         https://bugs.webkit.org/show_bug.cgi?id=140263
2522         <rdar://problem/19412705>
2523
2524         Reviewed by Beth Dakin.
2525
2526         * WebView/WebImmediateActionController.mm:
2527         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2528         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
2529         To match WebKit2, only call shouldUseActions if the animation is actually
2530         going to begin, not when preparing for it. This way, we're guaranteed
2531         to get a didCancel or didComplete.
2532
2533 2015-01-08  Dean Jackson  <dino@apple.com>
2534
2535         Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
2536         https://bugs.webkit.org/show_bug.cgi?id=140232
2537         <rdar://problem/19371010>
2538
2539         Reviewed by Anders Carlsson.
2540
2541         Remove the applicationChromeMode setting, but leave stubs in to make
2542         sure existing binaries don't break.
2543
2544         * WebCoreSupport/WebInspectorClient.mm:
2545         (-[WebInspectorWindowController init]):
2546         * WebView/WebPreferenceKeysPrivate.h:
2547         * WebView/WebPreferences.mm:
2548         (+[WebPreferences initialize]):
2549         (-[WebPreferences applicationChromeModeEnabled]):
2550         (-[WebPreferences setApplicationChromeModeEnabled:]):
2551         * WebView/WebView.mm:
2552         (-[WebView _preferencesChanged:]):
2553
2554 2015-01-07  Daniel Bates  <dabates@apple.com>
2555
2556         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
2557         https://bugs.webkit.org/show_bug.cgi?id=137371
2558
2559         Reviewed by David Kilzer.
2560
2561         Use SPI wrapper headers instead of directly references private SPI headers.
2562
2563         * Plugins/Hosted/NetscapePluginHostManager.mm:
2564
2565 2015-01-07  Commit Queue  <commit-queue@webkit.org>
2566
2567         Unreviewed, rolling out r178068.
2568         https://bugs.webkit.org/show_bug.cgi?id=140235
2569
2570         Breaks the iOS build (Requested by enrica on #webkit).
2571
2572         Reverted changeset:
2573
2574         "[iOS] Make WebKit2 build with public iOS SDK and more build
2575         fixes for DRT"
2576         https://bugs.webkit.org/show_bug.cgi?id=137371
2577         http://trac.webkit.org/changeset/178068
2578
2579 2015-01-07  Daniel Bates  <dabates@apple.com>
2580
2581         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
2582         https://bugs.webkit.org/show_bug.cgi?id=137371
2583
2584         Reviewed by David Kilzer.
2585
2586         Use SPI wrapper headers instead of directly references private SPI headers.
2587
2588         * Plugins/Hosted/NetscapePluginHostManager.mm:
2589
2590 2015-01-07  Beth Dakin  <bdakin@apple.com>
2591
2592         Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the 
2593         link
2594         https://bugs.webkit.org/show_bug.cgi?id=140206
2595         -and corresponding-
2596         rdar://problem/19300492
2597
2598         Reviewed by Tim Horton.
2599
2600         Providing and item frame will ensure that the original link is not obscured.
2601         * WebView/WebImmediateActionController.mm:
2602         (elementBoundingBoxInWindowCoordinatesFromNode):
2603         (-[WebImmediateActionController menuItem:itemFrameForPoint:]):
2604
2605         For now use a max size that is smaller than the WebView, with the screen’s aspect 
2606         ratio, and scaled down.
2607         (-[WebImmediateActionController menuItem:maxSizeForPoint:]):
2608
2609 2015-01-07  Anders Carlsson  <andersca@apple.com>
2610
2611         Give simple HTML documents a database provider
2612         https://bugs.webkit.org/show_bug.cgi?id=140192
2613         rdar://problem/19398825
2614
2615         Reviewed by Tim Horton.
2616
2617         * WebView/WebView.mm:
2618         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2619
2620 2015-01-06  Anders Carlsson  <andersca@apple.com>
2621
2622         Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
2623         https://bugs.webkit.org/show_bug.cgi?id=140140
2624
2625         Reviewed by Andreas Kling.
2626
2627         Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler
2628         out of WebCore since nobody else is using it.
2629
2630         * Plugins/WebNetscapePluginView.h:
2631         * Plugins/WebNetscapePluginView.mm:
2632         (-[WebNetscapePluginView _createPlugin]):
2633         (-[WebNetscapePluginView _destroyPlugin]):
2634         * Plugins/npapi.mm:
2635         (NPN_PluginThreadAsyncCall):
2636
2637 2015-01-06  Anders Carlsson  <andersca@apple.com>
2638
2639         Add a WebKit1 database provider
2640         https://bugs.webkit.org/show_bug.cgi?id=140126
2641
2642         Reviewed by Sam Weinig.
2643
2644         Set the database provider.
2645
2646         * WebView/WebView.mm:
2647         (-[WebView _commonInitializationWithFrameName:groupName:]):
2648
2649 2015-01-06  Commit Queue  <commit-queue@webkit.org>
2650
2651         Unreviewed, rolling out r177963.
2652         https://bugs.webkit.org/show_bug.cgi?id=140136
2653
2654         Caused lots of crashes (Requested by smfr on #webkit).
2655
2656         Reverted changeset:
2657
2658         "Add a WebKit1 database provider"
2659         https://bugs.webkit.org/show_bug.cgi?id=140126
2660         http://trac.webkit.org/changeset/177963
2661
2662 2015-01-06  Anders Carlsson  <andersca@apple.com>
2663
2664         Add a WebKit1 database provider
2665         https://bugs.webkit.org/show_bug.cgi?id=140126
2666
2667         Reviewed by Sam Weinig.
2668
2669         Set the database provider.
2670
2671         * WebView/WebView.mm:
2672         (-[WebView _commonInitializationWithFrameName:groupName:]):
2673
2674 2015-01-01  Jeff Miller  <jeffm@apple.com>
2675
2676         Update user-visible copyright strings to include 2015
2677         https://bugs.webkit.org/show_bug.cgi?id=139880
2678
2679         Reviewed by Darin Adler.
2680
2681         * Info.plist:
2682
2683 2014-12-30  Dan Bernstein  <mitz@apple.com>
2684
2685         [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
2686         https://bugs.webkit.org/show_bug.cgi?id=140003
2687
2688         Reviewed by Darin Adler.
2689
2690         * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
2691         that takes their "string" parameter as a "value" "parameter and has an attribute telling
2692         the compiler that if the "value" parameter is a format string then the function returns a
2693         modified version of it. The result is that if UI_STRING is used as a format string parameter
2694         to some function or method, the compiler will check the format specifiers in the string
2695         against the other parameters.
2696
2697 2014-12-29  Dan Bernstein  <mitz@apple.com>
2698
2699         Fixed the iOS build.
2700
2701         * Configurations/WebKitLegacy.xcconfig:
2702
2703 2014-12-29  Anders Carlsson  <andersca@apple.com>
2704
2705         Get rid of some PageGroup storage functions
2706         https://bugs.webkit.org/show_bug.cgi?id=139996
2707
2708         Reviewed by Sam Weinig.
2709
2710         Call WebStorageNamespaceProvider directly instead.
2711
2712         * Storage/WebStorageManager.mm:
2713         (-[WebStorageManager syncLocalStorage]):
2714         (+[WebStorageManager closeIdleLocalStorageDatabases]):
2715         * WebView/WebView.mm:
2716         (+[WebView _applicationWillTerminate]):
2717
2718 2014-12-29  Anders Carlsson  <andersca@apple.com>
2719
2720         Move storage code from WebCore to WebKit
2721         https://bugs.webkit.org/show_bug.cgi?id=139558
2722
2723         Reviewed by Darin Adler.
2724
2725         * Storage/WebStorageManager.mm:
2726         * Storage/WebStorageTrackerClient.h:
2727         * WebView/WebView.mm:
2728
2729 2014-12-26  Dan Bernstein  <mitz@apple.com>
2730
2731         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
2732         https://bugs.webkit.org/show_bug.cgi?id=139950
2733
2734         Reviewed by David Kilzer.
2735
2736         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
2737         in a manner that works with Xcode 5.1.1.
2738
2739 2014-12-23  Timothy Horton  <timothy_horton@apple.com>
2740
2741         Install a TextIndicator for link immediate actions
2742         https://bugs.webkit.org/show_bug.cgi?id=139897
2743         <rdar://problem/19333076>
2744
2745         Reviewed by Anders Carlsson.
2746
2747         * WebView/WebImmediateActionController.h:
2748         * WebView/WebImmediateActionController.mm:
2749         (-[WebImmediateActionController _clearImmediateActionState]):
2750         Tear down the TextIndicator, just like WebKit2.
2751
2752         (-[WebImmediateActionController _defaultAnimationController]):
2753         Install a TextIndicator for links.
2754
2755         (-[WebImmediateActionController menuItemDidClose:]):
2756         Tear down the TextIndicator when the QL preview closes.
2757
2758         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2759         Directly install and uninstall the TextIndicator for DataDetectors.
2760
2761         (-[WebImmediateActionController _showTextIndicator]): Deleted.
2762         (-[WebImmediateActionController _hideTextIndicator]): Deleted.
2763         Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
2764
2765 2014-12-20  Eric Carlson  <eric.carlson@apple.com>
2766
2767         [iOS] add optimized fullscreen API
2768         https://bugs.webkit.org/show_bug.cgi?id=139833
2769         <rdar://problem/18844486>
2770
2771         Reviewed by Simon Fraser.
2772
2773         * Configurations/FeatureDefines.xcconfig:  Add ENABLE_VIDEO_PRESENTATION_MODE.
2774
2775 2014-12-20  David Kilzer  <ddkilzer@apple.com>
2776
2777         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
2778         <http://webkit.org/b/139463>
2779
2780         Reviewed by Mark Rowe.
2781
2782         * Configurations/Base.xcconfig:
2783         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
2784           on OS X.
2785         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
2786         * Configurations/DebugRelease.xcconfig:
2787         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
2788         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
2789         * Configurations/Version.xcconfig:
2790         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
2791         * Configurations/WebKitLegacy.xcconfig:
2792         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
2793           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
2794           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
2795           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
2796           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
2797           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
2798           WEBCORE_PRIVATE_HEADERS_DIR_Production and
2799           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
2800           based on SDK.
2801         - Fix PRODUCTION_ROOT to actually be set properly.
2802         - Simplify EXPORTED_SYMBOLS_FILE_i386.
2803
2804         * migrate-headers.sh:
2805         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
2806         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
2807           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
2808           WebKitLegacy.xcconfig.
2809
2810 2014-12-19  Simon Fraser  <simon.fraser@apple.com>
2811
2812         Fix pink background on CoreAnimation plug-ins in WebKit1
2813         https://bugs.webkit.org/show_bug.cgi?id=139845
2814         rdar://problem/19313075
2815
2816         Reviewed by Tim Horton.
2817         
2818         r154078 left in some debugging code that set a pink background on plug-in hosting
2819         layers. Remove it.
2820
2821         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2822         (-[WebHostedNetscapePluginView createPluginLayer]):
2823
2824 2014-12-19  Andreas Kling  <akling@apple.com>
2825
2826         Ref-ify TextIterator API.
2827         <https://webkit.org/b/139823>
2828
2829         Reviewed by Antti Koivisto.
2830
2831         * WebView/WebTextIterator.mm:
2832         (-[WebTextIterator currentRange]):
2833
2834 2014-12-19  Joseph Pecoraro  <pecoraro@apple.com>
2835
2836         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
2837         https://bugs.webkit.org/show_bug.cgi?id=139797
2838
2839         Reviewed by Mark Lam.
2840
2841         * WebView/WebScriptDebugger.h:
2842         * WebView/WebScriptDebugger.mm:
2843         (WebScriptDebugger::handlePause):
2844         Standardize on passing JSGlobalObject parameter first.
2845
2846 2014-12-19  Commit Queue  <commit-queue@webkit.org>
2847
2848         Unreviewed, rolling out r177574.
2849         https://bugs.webkit.org/show_bug.cgi?id=139821
2850
2851         "Broke Production builds by installing
2852         libWebCoreTestSupport.dylib in the wrong directory" (Requested
2853         by ddkilzer on #webkit).
2854
2855         Reverted changeset:
2856
2857         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
2858         WebInspectorUI, WebKit, WebKit2"
2859         https://bugs.webkit.org/show_bug.cgi?id=139463
2860         http://trac.webkit.org/changeset/177574
2861
2862 2014-12-19  David Kilzer  <ddkilzer@apple.com>
2863
2864         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
2865         <http://webkit.org/b/139463>
2866
2867         Reviewed by Mark Rowe.
2868
2869         * Configurations/Base.xcconfig:
2870         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
2871           on OS X.
2872         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
2873         * Configurations/DebugRelease.xcconfig:
2874         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
2875         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
2876         * Configurations/Version.xcconfig:
2877         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
2878         * Configurations/WebKitLegacy.xcconfig:
2879         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
2880           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
2881           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
2882           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
2883           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
2884           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
2885           WEBCORE_PRIVATE_HEADERS_DIR_Production and
2886           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
2887           based on SDK.
2888         - Fix PRODUCTION_ROOT to actually be set properly.
2889         - Simplify EXPORTED_SYMBOLS_FILE_i386.
2890
2891         * migrate-headers.sh:
2892         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
2893         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
2894           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
2895           WebKitLegacy.xcconfig.
2896
2897 2014-12-18  Andreas Kling  <akling@apple.com>
2898
2899         Ref-ify various Document-related things.
2900         <https://webkit.org/b/139796>
2901
2902         Reviewed by Anders Carlsson.
2903
2904         * WebView/WebFrame.mm:
2905         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
2906
2907 2014-12-18  Beth Dakin  <bdakin@apple.com>
2908
2909         Need to re-enable action menus
2910         https://bugs.webkit.org/show_bug.cgi?id=139795
2911         -and corresponding-
2912         rdar://problem/19299367
2913
2914         Reviewed by Tim Horton.
2915
2916         Re-enable the menus by un-commenting the code to create the menu and controller.
2917         * WebView/WebView.mm:
2918         (-[WebView _commonInitializationWithFrameName:groupName:]):
2919
2920 2014-12-16  Sam Weinig  <sam@webkit.org>
2921
2922         Unify the Mac and iOS implementations of FontPlatformData a bit
2923         https://bugs.webkit.org/show_bug.cgi?id=139721
2924
2925         Reviewed by Anders Carlsson.
2926
2927         * WebView/WebHTMLView.mm:
2928         (fontNameForDescription):
2929         Update for new function name.
2930
2931 2014-12-18  Antti Koivisto  <antti@apple.com>
2932
2933         Remove alwaysUseBaselineOfPrimaryFont setting
2934         https://bugs.webkit.org/show_bug.cgi?id=139770
2935
2936         Reviewed by Anders Carlsson.
2937
2938         * WebView/WebPreferenceKeysPrivate.h:
2939         * WebView/WebPreferences.mm:
2940         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
2941         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
2942         * WebView/WebPreferencesPrivate.h:
2943         * WebView/WebView.mm:
2944         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2945         (-[WebView _preferencesChanged:]):
2946
2947 2014-12-17  Andreas Kling  <akling@apple.com>
2948
2949         Ref-ify Range::create().
2950         <https://webkit.org/b/139755>
2951
2952         Reviewed by Anders Carlsson.
2953
2954         * WebView/WebHTMLRepresentation.mm:
2955         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
2956         * WebView/WebHTMLView.mm:
2957         (-[WebHTMLView attributedString]):
2958
2959 2014-12-17  Anders Carlsson  <andersca@apple.com>
2960
2961         Unify -[WebResource description]
2962         https://bugs.webkit.org/show_bug.cgi?id=139762
2963
2964         Reviewed by Dan Bernstein.
2965
2966         * WebView/WebResource.mm:
2967         (-[WebResource description]):
2968
2969 2014-12-17  Anders Carlsson  <andersca@apple.com>
2970
2971         Get rid of an ugly #define hack in WebFrameLoaderClient
2972         https://bugs.webkit.org/show_bug.cgi?id=139761
2973
2974         Reviewed by Dan Bernstein.
2975
2976         Also replace @private with @package in all public headers, for consistency.
2977
2978         * History/WebBackForwardList.h:
2979         * History/WebHistory.h:
2980         * Misc/WebDownload.h:
2981         * WebCoreSupport/WebFrameLoaderClient.mm:
2982         * WebView/WebArchive.h:
2983         * WebView/WebDataSource.h:
2984         * WebView/WebFrame.h:
2985         * WebView/WebFrameView.h:
2986         * WebView/WebPreferences.h:
2987         * WebView/WebResource.h:
2988
2989 2014-12-17  Dan Bernstein  <mitz@apple.com>
2990
2991         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
2992         https://bugs.webkit.org/show_bug.cgi?id=139760
2993
2994         Reviewed by Anders Carlsson.
2995
2996         * Configurations/WebKitLegacy.xcconfig:
2997
2998 2014-12-17  Andreas Kling  <akling@apple.com>
2999
3000         Purge PassRefPtr from Frame.
3001         <https://webkit.org/b/139731>
3002
3003         Reviewed by Anders Carlsson.
3004
3005         * WebCoreSupport/WebFrameLoaderClient.mm:
3006         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3007         * WebView/WebFrame.mm:
3008         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
3009         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
3010         * WebView/WebFrameInternal.h:
3011
3012 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
3013
3014         Implement and adopt two new TextIndicator presentation animations
3015         https://bugs.webkit.org/show_bug.cgi?id=139715
3016         <rdar://problem/19237945>
3017
3018         Reviewed by Anders Carlsson.
3019
3020         * WebView/WebActionMenuController.mm:
3021         (-[WebActionMenuController _showTextIndicator]):
3022         * WebView/WebHTMLView.mm:
3023         (-[WebHTMLView quickLookWithEvent:]):
3024         Remove the completionHandler from text indicator presentation.
3025
3026         * WebView/WebImmediateActionController.mm:
3027         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
3028         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
3029         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
3030         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
3031         (-[WebImmediateActionController _menuItemForDataDetectedText]):
3032         (-[WebImmediateActionController _animationControllerForText]):
3033         (-[WebImmediateActionController _showTextIndicator]):
3034         Forward immediate action gesture recognizer animation progress
3035         to TextIndicator. Force us to keep the selection when immediate
3036         action popovers steal first responder status from the WebView.
3037         If the Lookup range is equal to the selection range, use a Crossfade
3038         animation; otherwise, use a FadeIn animation.
3039
3040         * WebView/WebView.mm:
3041         (-[WebView _setMaintainsInactiveSelection:]):
3042         (-[WebView maintainsInactiveSelection]):
3043         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
3044         (-[WebView _setTextIndicator:fadeOut:]):
3045         (-[WebView _clearTextIndicator]):
3046         (-[WebView _setTextIndicatorAnimationProgress:]):
3047         (-[WebView _showDictionaryLookupPopup:]):
3048         (-[WebView _dictionaryLookupPopoverWillClose:]):
3049         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
3050         Remove the completionHandler from text indicator presentation.
3051         Add a _setMaintainsInactiveSelection, which allows WebKit internals
3052         to change the return value of -maintainsInactiveSelection, allowing
3053         us to keep the selection alive when the WebView loses first responder status.
3054
3055         * WebView/WebViewData.h:
3056         * WebView/WebViewInternal.h:
3057
3058 2014-12-16  Andreas Kling  <akling@apple.com>
3059
3060         Use Ref for SecurityOrigin.
3061         <https://webkit.org/b/139710>
3062
3063         Reviewed by Anders Carlsson.
3064
3065         * Storage/WebStorageTrackerClient.mm:
3066         (WebStorageTrackerClient::dispatchDidModifyOrigin):
3067         * WebView/WebView.mm:
3068         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
3069         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
3070
3071 2014-12-16  Beth Dakin  <bdakin@apple.com>
3072
3073         Crash getting default animation controller for some text
3074         https://bugs.webkit.org/show_bug.cgi?id=139712
3075         -and corresponding-
3076         rdar://problem/19271707
3077
3078         Reviewed by Tim Horton.
3079
3080         Must null-check the range.
3081         * WebView/WebImmediateActionController.mm:
3082         (-[WebImmediateActionController _animationControllerForText]):
3083
3084 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
3085
3086         Immediate action popovers can get stuck open
3087         https://bugs.webkit.org/show_bug.cgi?id=139709
3088         <rdar://problem/19270279>
3089
3090         Reviewed by Beth Dakin.
3091
3092         * WebView/WebImmediateActionController.mm:
3093         (-[WebImmediateActionController _clearImmediateActionState]):
3094         Don't clear the animation controller; it breaks things and was unnecessary.
3095
3096 2014-12-16  Tim Horton  <timothy_horton@apple.com>
3097
3098         Disable TextIndication for Lookup immediate actions
3099         https://bugs.webkit.org/show_bug.cgi?id=139684
3100
3101         Reviewed by Anders Carlsson.
3102
3103         * WebView/WebView.mm:
3104         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
3105
3106 2014-12-15  Beth Dakin  <bdakin@apple.com>
3107
3108         Build fix.
3109
3110         * WebView/WebImmediateActionController.mm:
3111
3112 2014-12-15  Beth Dakin  <bdakin@apple.com>
3113
3114         Speculative build fix.
3115
3116         * WebView/WebView.mm:
3117         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
3118         * WebView/WebViewInternal.h:
3119
3120 2014-12-15  Beth Dakin  <bdakin@apple.com>
3121
3122         Make lookup an immediate action instead of an action menu item
3123         https://bugs.webkit.org/show_bug.cgi?id=139661
3124         -and corresponding-
3125         rdar://problem/19198414
3126
3127         Reviewed by Tim Horton.
3128
3129         Remove the lookup menu items and non-unused static function associated with 
3130         lookup.
3131         * WebView/WebActionMenuController.mm:
3132         (-[WebActionMenuController _defaultMenuItemsForText]):
3133         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
3134         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
3135         (-[WebActionMenuController _createActionMenuItemForTag:]):
3136         (-[WebActionMenuController _lookupText:]): Deleted.
3137         (performDictionaryLookupForSelection): Deleted.
3138         (performDictionaryLookupForRange): Deleted.
3139
3140         Set the defaultAnimationController to the lookup-provided animation controller 
3141         when appropriate.
3142         * WebView/WebImmediateActionController.mm:
3143         (-[WebImmediateActionController _defaultAnimationController]):
3144         (dictionaryPopupInfoForRange):
3145         (-[WebImmediateActionController _animationControllerForText]):
3146
3147         New type.
3148         * WebView/WebUIDelegatePrivate.h:
3149
3150         New function to get the lookup animation controller.
3151         * WebView/WebView.mm:
3152         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
3153         * WebView/WebViewInternal.h:
3154
3155 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
3156
3157         Implement Data Detectors immediate actions for Legacy WebKit
3158         https://bugs.webkit.org/show_bug.cgi?id=139619
3159         <rdar://problem/19198539>
3160
3161         Reviewed by Beth Dakin.
3162
3163         * WebView/WebImmediateActionController.mm:
3164         (-[WebImmediateActionController _menuItemForDataDetectedText]):
3165         Note that this action context is only for immediate actions.
3166
3167 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
3168
3169         Addressing post-review comments in r177035
3170         https://bugs.webkit.org/show_bug.cgi?id=139557
3171
3172         Reviewed by Darin Adler.
3173
3174         * WebView/WebActionMenuController.mm:
3175         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
3176
3177 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
3178
3179         Implement Data Detectors immediate actions for Legacy WebKit
3180         https://bugs.webkit.org/show_bug.cgi?id=139619
3181         <rdar://problem/19198539>
3182
3183         Reviewed by Eric Carlson.
3184
3185         * WebView/WebHTMLView.mm:
3186         (-[WebHTMLView mouseDown:mouseDown:]):
3187         Send mouseDown along to the WebImmediateActionController too.
3188
3189         * WebView/WebImmediateActionController.h:
3190         * WebView/WebImmediateActionController.mm:
3191         (-[WebImmediateActionController webViewClosed]):
3192         (-[WebImmediateActionController webView:willHandleMouseDown:]):
3193         (-[WebImmediateActionController _cancelImmediateAction]):
3194         (-[WebImmediateActionController _clearImmediateActionState]):
3195         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
3196         (-[WebImmediateActionController _defaultAnimationController]):
3197         (-[WebImmediateActionController _updateImmediateActionItem]):
3198         (-[WebImmediateActionController _menuItemForDataDetectedText]):
3199         (-[WebImmediateActionController _showTextIndicator]):
3200         (-[WebImmediateActionController _hideTextIndicator]):
3201         Copy most of the DataDetectors implementation into WebImmediateActionController.
3202
3203         * WebView/WebUIDelegatePrivate.h:
3204         Add a new type.
3205
3206         * WebView/WebView.mm:
3207         (-[WebView _commonInitializationWithFrameName:groupName:]):
3208         Temporarily disable action menus.
3209
3210         (-[WebView _immediateActionController]):
3211         * WebView/WebViewInternal.h:
3212
3213 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
3214
3215         Delete Notation because we don't use it
3216         https://bugs.webkit.org/show_bug.cgi?id=139171
3217
3218         Reviewed by Kent Tamura.
3219
3220         * MigrateHeaders.make:
3221
3222 2014-12-14  Andreas Kling  <akling@apple.com>
3223
3224         Replace PassRef with Ref/Ref&& across the board.
3225         <https://webkit.org/b/139587>
3226
3227         Reviewed by Darin Adler.
3228
3229         * WebCoreSupport/WebEditorClient.mm:
3230         (WebEditorClient::shouldApplyStyle):
3231         * WebCoreSupport/WebVisitedLinkStore.h:
3232         * WebCoreSupport/WebVisitedLinkStore.mm:
3233         (WebVisitedLinkStore::create):
3234
3235 2014-12-11  Dan Bernstein  <mitz@apple.com>
3236
3237         Fix a leak introduced in r177199.
3238
3239         Reviewed by Anders Carlsson.
3240
3241         * WebView/WebImmediateActionController.mm:
3242         (-[WebImmediateActionController _updateImmediateActionItem]):
3243
3244 2014-12-11  Beth Dakin  <bdakin@apple.com>
3245
3246         WK1: Need new SPI for Webkit clients to override default immediate action
3247         https://bugs.webkit.org/show_bug.cgi?id=139568
3248         -and corresponding-
3249         rdar://problem/19225448
3250
3251         Reviewed by Dan Bernstein.
3252
3253         Call SPI giving clients a chance to override the default behavior.
3254         * WebView/WebImmediateActionController.mm:
3255         (-[WebImmediateActionController _updateImmediateActionItem]):
3256
3257         New SPI.
3258         * WebView/WebUIDelegatePrivate.h:
3259
3260 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
3261
3262         Move the preview popover to WebImmediateActionController
3263         https://bugs.webkit.org/show_bug.cgi?id=139563
3264         <rdar://problem/19208291>
3265
3266         Reviewed by Beth Dakin.
3267
3268         * WebView/WebActionMenuController.mm:
3269         (-[WebActionMenuController _defaultMenuItemsForLink]):
3270         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
3271         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
3272         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
3273         * WebView/WebImmediateActionController.h:
3274         * WebView/WebImmediateActionController.mm:
3275         (-[WebImmediateActionController webViewClosed]):
3276         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
3277         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
3278         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
3279         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
3280         (-[WebImmediateActionController _updateImmediateActionItem]):
3281         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
3282         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
3283         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
3284         Move page preview popover related code to WebImmediateActionController.
3285
3286         * WebView/WebUIDelegatePrivate.h:
3287         Add a link preview type.
3288
3289         * WebView/WebView.mm:
3290         (-[WebView _commonInitializationWithFrameName:groupName:]):
3291         Pass the gesture recognizer to the WebImmediateActionController.
3292
3293 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
3294
3295         Fix the build.
3296
3297         * WebView/WebImmediateActionController.h:
3298         * WebView/WebImmediateActionController.mm:
3299
3300 2014-12-11  Anders Carlsson  <andersca@apple.com>
3301
3302         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
3303         https://bugs.webkit.org/show_bug.cgi?id=139547
3304
3305         Reviewed by Sam Weinig.
3306
3307         * WebView/WebView.mm:
3308         (+[WebView _handleMemoryWarning]):
3309
3310 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
3311
3312         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
3313         https://bugs.webkit.org/show_bug.cgi?id=139504
3314         rdar://problem/19034674
3315
3316         Reviewed by Enrica Casucci.
3317
3318         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
3319
3320         * WebCoreSupport/WebEditorClient.h:
3321         * WebCoreSupport/WebEditorClient.mm:
3322         (WebEditorClient::discardedComposition):
3323
3324 2014-12-10  Anders Carlsson  <andersca@apple.com>
3325
3326         Get rid of the storage strategy
3327         https://bugs.webkit.org/show_bug.cgi?id=139519
3328
3329         Reviewed by Antti Koivisto.
3330
3331         * WebCoreSupport/WebPlatformStrategies.h:
3332         * WebCoreSupport/WebPlatformStrategies.mm:
3333         (WebPlatformStrategies::createStorageStrategy): Deleted.
3334
3335 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
3336
3337         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
3338         https://bugs.webkit.org/show_bug.cgi?id=139529
3339         <rdar://problem/19213620>
3340
3341         Reviewed by Beth Dakin.
3342
3343         * WebView/WebActionMenuController.mm:
3344         (-[WebActionMenuController _copySelection:]):
3345         (-[WebActionMenuController _paste:]):
3346         Use the copy: and paste: methods on WebView so that we traverse subviews
3347         when trying to respond, otherwise these actions don't work in subframes.
3348
3349 2014-12-10  Beth Dakin  <bdakin@apple.com>
3350
3351         WK1: Add initial support for immediate actions
3352         https://bugs.webkit.org/show_bug.cgi?id=139522
3353
3354         Reviewed by Dan Bernstein.
3355
3356         This basic implementation of the controller will use the delegate methods to 
3357         perform and cache a HitTest when relevant. Future patches will patch 
3358         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
3359         immediate action that should be taken.
3360         * WebView/WebImmediateActionController.h: Added.
3361         * WebView/WebImmediateActionController.mm: Added.
3362         (-[WebImmediateActionController webViewClosed]):
3363         (-[WebImmediateActionController _clearImmediateActionState]):
3364         (-[WebImmediateActionController performHitTestAtPoint:]):
3365         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
3366         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
3367         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
3368         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
3369         (-[WebImmediateActionController _updateImmediateActionItem]):
3370
3371         New enum for immediate action types.
3372         * WebView/WebUIDelegatePrivate.h:
3373
3374         Create an NSImmediateActionGestureRecognizer if possible and a controller.
3375         * WebView/WebView.mm:
3376         (-[WebView _commonInitializationWithFrameName:groupName:]):
3377         (-[WebView _close]):
3378         * WebView/WebViewData.h:
3379         * WebView/WebViewData.mm:
3380         (-[WebViewPrivate dealloc]):
3381
3382 2014-12-08  Anders Carlsson  <andersca@apple.com>
3383
3384         Use the new storage namespace provider in WebKit1
3385         https://bugs.webkit.org/show_bug.cgi?id=139425
3386
3387         Reviewed by Tim Horton.
3388
3389         * WebView/WebView.mm:
3390         (-[WebView _commonInitializationWithFrameName:groupName:]):
3391         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3392         Set the storage namespace provider from the web page group.
3393
3394 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
3395
3396         Should have copy and paste items in all text menus
3397         https://bugs.webkit.org/show_bug.cgi?id=139510
3398         <rdar://problem/19198388>
3399
3400         Reviewed by Beth Dakin.
3401
3402         * WebView/WebActionMenuController.mm:
3403         (-[WebActionMenuController _defaultMenuItemsForText]):
3404         Add a disabled paste menu item into the read-only text menu.
3405
3406         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
3407         Add a disabled copy menu item into the editable whitespace text menu.
3408
3409 2014-12-10  Anders Carlsson  <andersca@apple.com>
3410
3411         Add WebStorageNamespaceProvider::closeLocalStorage
3412         https://bugs.webkit.org/show_bug.cgi?id=139502
3413
3414         Reviewed by Tim Horton.
3415
3416         * WebView/WebView.mm:
3417         (+[WebView _applicationWillTerminate]):
3418         Call WebStorageNamespaceProvider::closeLocalStorage.
3419
3420 2014-12-09  Commit Queue  <commit-queue@webkit.org>
3421
3422         Unreviewed, rolling out r177037.
3423         https://bugs.webkit.org/show_bug.cgi?id=139464
3424
3425         broke ~50 API tests (Requested by thorton on #webkit).
3426
3427         Reverted changeset:
3428
3429         "Use the new storage namespace provider in WebKit1"
3430         https://bugs.webkit.org/show_bug.cgi?id=139425
3431         http://trac.webkit.org/changeset/177037
3432
3433 2014-12-08  Anders Carlsson  <andersca@apple.com>
3434
3435         Use the new storage namespace provider in WebKit1
3436         https://bugs.webkit.org/show_bug.cgi?id=139425
3437
3438         Reviewed by Tim Horton.
3439
3440         * WebView/WebView.mm:
3441         (-[WebView _commonInitializationWithFrameName:groupName:]):
3442         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3443         Set the storage namespace provider from the web page group.
3444
3445 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
3446
3447         Delete Node::boundingBox()
3448         https://bugs.webkit.org/show_bug.cgi?id=139333
3449
3450         Reviewed by Zalan Bujtas.
3451
3452         * WebView/WebActionMenuController.mm:
3453         (elementBoundingBoxInWindowCoordinatesFromNode): Use
3454         RenderObject::absoluteBoundingBoxRect().
3455
3456 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
3457
3458         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
3459         https://bugs.webkit.org/show_bug.cgi?id=138843
3460         rdar://problem/18793695
3461
3462         Reviewed by Dan Bernstein.
3463
3464         * Panels/WebAuthenticationPanel.m:
3465         (-[WebAuthenticationPanel cancel:]):
3466         (-[WebAuthenticationPanel logIn:]):
3467         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
3468         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
3469         that only when using an old NSWindow API.
3470
3471 2014-12-08  Beth Dakin  <bdakin@apple.com>
3472
3473         Copy and Lookup menu items should be disabled when something is not copyable
3474         https://bugs.webkit.org/show_bug.cgi?id=139423
3475
3476         Reviewed by Tim Horton.
3477
3478         Disable both lookup and copy when a HitTestResult does not allow copy.
3479         * WebView/WebActionMenuController.mm:
3480
3481         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
3482         disable state otherwise.
3483         * WebView/WebView.mm:
3484         (-[WebView _commonInitializationWithFrameName:groupName:]):
3485
3486 2014-12-08  Anders Carlsson  <andersca@apple.com>
3487
3488         Adding user content to a group should force that group to be created
3489         https://bugs.webkit.org/show_bug.cgi?id=139421
3490         rdar://problem/19180108
3491
3492         Reviewed by Sam Weinig.
3493
3494         * WebCoreSupport/WebViewGroup.h:
3495         Store the local storage database path in the group.
3496
3497         * WebCoreSupport/WebViewGroup.mm:
3498         (WebViewGroup::getOrCreate):
3499         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
3500         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
3501
3502         (WebViewGroup::WebViewGroup):
3503         Initialize the new member variable.
3504
3505         (WebViewGroup::storageNamespaceProvider):
3506         Create the namespace provider lazily.
3507
3508         * WebView/WebView.mm:
3509         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
3510         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
3511         Use getOrCreate instead of get.
3512
3513 2014-12-08  Anders Carlsson  <andersca@apple.com>
3514
3515         WebStorageNamespaceProvider should know about its local storage database path
3516         https://bugs.webkit.org/show_bug.cgi?id=139413
3517
3518         Reviewed by Andreas Kling.
3519
3520         * WebCoreSupport/WebViewGroup.h:
3521         * WebCoreSupport/WebViewGroup.mm:
3522         (WebViewGroup::getOrCreate):
3523         (WebViewGroup::WebViewGroup):
3524         * WebView/WebView.mm:
3525         (-[WebView _commonInitializationWithFrameName:groupName:]):
3526         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3527         (-[WebView setGroupName:]):
3528         (-[WebView groupName]): Deleted.
3529
3530 2014-12-08  Daniel Bates  <dabates@apple.com>
3531
3532         [iOS] Fix the WebKit build with the public SDK
3533
3534         Include header NSURLDownloadSPI.h.
3535
3536         * WebCoreSupport/WebFrameLoaderClient.mm:
3537
3538 2014-12-07  Dan Bernstein  <mitz@apple.com>
3539
3540         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
3541         https://bugs.webkit.org/show_bug.cgi?id=139348
3542
3543         Reviewed by Anders Carlsson.
3544
3545         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
3546         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
3547         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
3548         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
3549         avoiding the ambiguity.
3550
3551         * WebView/WebActionMenuController.mm:
3552         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3553
3554 2014-12-06  Anders Carlsson  <andersca@apple.com>
3555
3556         Add a stubbed out version of WebStorageNamespaceProvider
3557         https://bugs.webkit.org/show_bug.cgi?id=139213
3558
3559         Reviewed by Sam Weinig.
3560
3561         * WebCoreSupport/WebViewGroup.h:
3562         (WebViewGroup::storageNamespaceProvider):
3563         * WebCoreSupport/WebViewGroup.mm:
3564         (WebViewGroup::getOrCreate):
3565         (WebViewGroup::WebViewGroup):
3566         Give WebViewGroup a storage namespace provider.
3567
3568 2014-12-06  Anders Carlsson  <andersca@apple.com>
3569
3570         Fix build with newer versions of clang.
3571         rdar://problem/18978687
3572
3573         Add missing override