Fix state maching debugging after r181964
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2015-03-24  Anders Carlsson  <andersca@apple.com>
2
3         Fix designated initializer violations
4         https://bugs.webkit.org/show_bug.cgi?id=143016
5         rdar://problem/20268858
6
7         Reviewed by Dan Bernstein.
8
9         Move -[WebBackForwardList initWithBackForwardList:] to the implementation instead of a category since
10         nobody calls it outside of WebBackForwardList.mm.
11
12         * History/WebBackForwardList.mm:
13         * History/WebBackForwardListInternal.h:
14
15 2015-03-23  Alexey Proskuryakov  <ap@apple.com>
16
17         REGRESSION (Yosemite): WKView visibility notifications are messed up
18         https://bugs.webkit.org/show_bug.cgi?id=142945
19
20         Reviewed by Tim Horton.
21
22         As these notifications cannot be used by NSView subclasses, create a separate
23         object for observing them.
24
25         * WebView/WebView.mm:
26         (-[WebView _commonInitializationWithFrameName:groupName:]):
27         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
28         (-[WebView addWindowObserversForWindow:]):
29         (-[WebView removeWindowObservers]):
30         (-[WebView viewWillMoveToWindow:]): Make sure that observers are removed even
31         if -[WebView close] is called manually.
32         * WebView/WebViewData.h:
33         * WebView/WebViewData.mm:
34         (-[WebWindowVisibilityObserver initWithView:]):
35         (-[WebWindowVisibilityObserver startObserving:]):
36         (-[WebWindowVisibilityObserver stopObserving:]):
37         (-[WebWindowVisibilityObserver _windowVisibilityChanged:]):
38
39 2015-03-23  Tim Horton  <timothy_horton@apple.com>
40
41         Add a share item to the link action menu
42         https://bugs.webkit.org/show_bug.cgi?id=142961
43         <rdar://problem/19198374>
44
45         Reviewed by Beth Dakin.
46
47         * WebView/WebActionMenuController.mm:
48         (-[WebActionMenuController _defaultMenuItemsForImage]):
49         (-[WebActionMenuController _defaultMenuItemsForVideo]):
50         (-[WebActionMenuController _createActionMenuItemForTag:]):
51         (-[WebActionMenuController _createShareActionMenuItemForTag:withItems:]):
52         Adopt -[NSMenuItem standardShareMenuItemWithItems].
53         All of the null-checking is unnecessary as it's impossible to enter
54         these functions with a null image/etc.
55         Also, remove a duplicate isDownloadableMedia check for the 'save to downloads' item.
56
57         (-[WebActionMenuController _defaultMenuItemsForLink]):
58         * WebView/WebUIDelegatePrivate.h:
59         Add a 'Share' item to the link menu.
60
61 2015-03-22  Alexey Proskuryakov  <ap@apple.com>
62
63         Build fix.
64
65         * WebView/WebView.mm: (-[WebView _showPlaybackTargetPicker:hasVideo:]):
66
67 2015-03-22  Eric Carlson  <eric.carlson@apple.com>
68
69         [Mac] Enable WIRELESS_PLAYBACK_TARGET for WK1
70         https://bugs.webkit.org/show_bug.cgi?id=142940
71
72         Reviewed by Sam Weinig.
73
74         * WebCoreSupport/WebChromeClient.h:
75         * WebCoreSupport/WebChromeClient.mm:
76         (WebChromeClient::showPlaybackTargetPicker): New.
77         (WebChromeClient::startingMonitoringPlaybackTargets): New.
78         (WebChromeClient::stopMonitoringPlaybackTargets): New.
79
80         * WebView/WebView.mm:
81         (-[WebView _close]): Invalidate and free the target picker.
82         (-[WebView _devicePicker]): New.
83         (-[WebView _showPlaybackTargetPicker:hasVideo:]): New.
84         (-[WebView _startingMonitoringPlaybackTargets]): New.
85         (-[WebView _stopMonitoringPlaybackTargets]): New.
86
87         * WebView/WebMediaPlaybackTargetPicker.h:
88         * WebView/WebMediaPlaybackTargetPicker.mm:
89         (WebMediaPlaybackTargetPicker::create): New.
90         (WebMediaPlaybackTargetPicker::WebMediaPlaybackTargetPicker): New.
91         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): New.
92         (WebMediaPlaybackTargetPicker::startingMonitoringPlaybackTargets): New.
93         (WebMediaPlaybackTargetPicker::stopMonitoringPlaybackTargets): New.
94         (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): New.
95         (WebMediaPlaybackTargetPicker::externalOutputDeviceAvailableDidChange): New.
96         (WebMediaPlaybackTargetPicker::invalidate): New.
97         (WebMediaPlaybackTargetPicker::targetPicker): New.
98
99         * WebView/WebViewData.h:
100         (WebMediaPlaybackTargetPicker::~WebMediaPlaybackTargetPicker):
101         * WebView/WebViewData.mm:
102         * WebView/WebViewInternal.h:
103
104 2015-03-19  Andy Estes  <aestes@apple.com>
105
106         [Content Filtering] Add tests for unblock requests
107         https://bugs.webkit.org/show_bug.cgi?id=142900
108
109         Reviewed by Andreas Kling.
110
111         * WebCoreSupport/WebFrameLoaderClient.mm:
112         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): This now happens in PolicyChecker.
113         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
114         * WebView/WebFrame.mm:
115         (-[WebFrame _contentFilterDidHandleNavigationAction:]): Deleted.
116         * WebView/WebFrameInternal.h: Removed contentFilterUnblockHandler from WebFramePrivate.
117
118 2015-03-19  Enrica Casucci  <enrica@apple.com>
119
120         <attachment> should put URLs on the pasteboard so that Finder can accept drops.
121         https://bugs.webkit.org/show_bug.cgi?id=142801
122         rdar://problem/19982527
123
124         Reviewed by Tim Horton.
125
126         This patch adds all the necessary support to write attachment elements into
127         the pasteboard, including the promised type in WK1.
128
129         * Misc/WebNSPasteboardExtras.mm:
130         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
131         * WebCoreSupport/WebDragClient.h:
132         * WebCoreSupport/WebDragClient.mm:
133         (WebDragClient::declareAndWriteAttachment):
134         * WebView/WebHTMLView.mm:
135         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
136         * WebView/WebUIDelegate.h:
137
138 2015-03-19  Chris Dumez  <cdumez@apple.com>
139
140         Clean up DOMTimer related settings
141         https://bugs.webkit.org/show_bug.cgi?id=142837
142
143         Reviewed by Darin Adler.
144
145         Stop setting the DOMTimers' default minimum interval to 4ms as this
146         is now the default.
147
148         * WebView/WebView.mm:
149         (-[WebView _commonInitializationWithFrameName:groupName:]):
150
151 2015-03-17  Conrad Shultz  <conrad_shultz@apple.com>
152
153         Ignore some deprecation warnings
154         https://bugs.webkit.org/show_bug.cgi?id=142813
155
156         Reviewed by Mark Rowe.
157
158         Fixing the deprecations is tracked by: <rdar://problem/20201450>
159
160         * WebCoreSupport/PopupMenuMac.mm:
161         (PopupMenuMac::populate):
162
163 2015-03-17  Tim Horton  <timothy_horton@apple.com>
164
165         Cannot invoke action menus anymore
166         https://bugs.webkit.org/show_bug.cgi?id=142797
167         <rdar://problem/20032670>
168
169         * WebView/WebHTMLView.mm:
170         (-[WebHTMLView otherMouseDown:]):
171         Need a respondsToSelector check.
172
173 2015-03-17  Tim Horton  <timothy_horton@apple.com>
174
175         Fix the iOS build
176
177         * WebView/WebHTMLView.mm:
178
179 2015-03-17  Tim Horton  <timothy_horton@apple.com>
180
181         Cannot invoke action menus anymore
182         https://bugs.webkit.org/show_bug.cgi?id=142797
183         <rdar://problem/20032670>
184
185         Reviewed by Beth Dakin.
186
187         * WebView/WebHTMLView.mm:
188         (-[WebHTMLView otherMouseDown:]):
189         Don't override otherMouseDown: if the event would make an action menu.
190
191 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
192
193         Enable ES6 classes by default
194         https://bugs.webkit.org/show_bug.cgi?id=142774
195
196         Reviewed by Gavin Barraclough.
197
198         * Configurations/FeatureDefines.xcconfig:
199
200 2015-03-16  Brent Fulgham  <bfulgham@apple.com>
201
202         WebKit1 Clients Are Not Reliably Repainted
203         https://bugs.webkit.org/show_bug.cgi?id=142750
204         <rdar://problem/20042453>
205
206         Reviewed by Simon Fraser.
207
208         Check with the FrameView to see if we are in an immediately paintable state. If we are not,
209         mark the view as dirty once the _immediateScrollToPoint operation is complete so that the
210         region will be painted properly.
211
212         * WebView/WebClipView.mm:
213         (-[WebClipView _immediateScrollToPoint:]): 
214
215 2015-03-16  Conrad Shultz  <conrad_shultz@apple.com>
216
217         Allow clients to selectively disable plug-ins
218         https://bugs.webkit.org/show_bug.cgi?id=142506
219
220         Reviewed by Anders Carlsson.
221
222         Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
223         from the page). As part of this:
224
225         1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying
226            set of plug-ins.
227
228         2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper
229            down the stack.
230
231         3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce
232            a concrete implementation thereof in WebPlatformStrategies in WebKit2.
233
234         4) Add messaging infrastructure to allow clients to set and clear plug-in policies.
235
236         While currently only used in a very limited manner, the new declarative plug-in policies are written generically
237         so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.
238
239         * Plugins/WebBasePluginPackage.mm:
240         (-[WebBasePluginPackage getPluginInfoFromPLists]):
241         Set new members in PluginInfo.
242
243         * Plugins/WebNetscapePluginPackage.mm:
244         (-[WebNetscapePluginPackage getPluginInfoFromResources]):
245         Set new members in PluginInfo.
246
247         * WebCoreSupport/WebPlatformStrategies.h:
248         * WebCoreSupport/WebPlatformStrategies.mm:
249         (WebPlatformStrategies::getWebVisiblePluginInfo):
250         Override to wrap getPluginInfo().
251         (WebPlatformStrategies::setPluginLoadClientPolicy):
252         Override to do nothing.
253         (WebPlatformStrategies::clearPluginClientPolicies):
254         Ditto.
255
256         * WebView/WebFrame.mm:
257         (-[WebFrame _canProvideDocumentSource]):
258         Update to reflect function rename.
259
260 2015-03-14  Dean Jackson  <dino@apple.com>
261
262         Feature flag for Animations Level 2
263         https://bugs.webkit.org/show_bug.cgi?id=142699
264         <rdar://problem/20165097>
265
266         Reviewed by Brent Fulgham.
267
268         Add ENABLE_CSS_ANIMATIONS_LEVEL_2 and a runtime flag animationTriggersEnabled.
269
270         * Configurations/FeatureDefines.xcconfig:
271
272 2015-03-13  Commit Queue  <commit-queue@webkit.org>
273
274         Unreviewed, rolling out r181483.
275         https://bugs.webkit.org/show_bug.cgi?id=142688
276
277         Caused use-after-free on many tests (Requested by ap on
278         #webkit).
279
280         Reverted changeset:
281
282         "Allow clients to selectively disable plug-ins"
283         https://bugs.webkit.org/show_bug.cgi?id=142506
284         http://trac.webkit.org/changeset/181483
285
286 2015-03-13  Eric Carlson  <eric.carlson@apple.com>
287
288         [Mac] Enable WIRELESS_PLAYBACK_TARGET
289         https://bugs.webkit.org/show_bug.cgi?id=142635
290
291         Reviewed by Darin Adler.
292
293         * Configurations/FeatureDefines.xcconfig:
294
295 2015-03-10  Conrad Shultz  <conrad_shultz@apple.com>
296
297         Allow clients to selectively disable plug-ins
298         https://bugs.webkit.org/show_bug.cgi?id=142506
299
300         Reviewed by Anders Carlsson.
301
302         Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
303         from the page). As part of this:
304
305         1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying
306            set of plug-ins.
307
308         2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper
309            down the stack.
310
311         3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce
312            a concrete implementation thereof in WebPlatformStrategies in WebKit2.
313
314         4) Add messaging infrastructure to allow clients to set and clear plug-in policies.
315
316         While currently only used in a very limited manner, the new declarative plug-in policies are written generically
317         so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.
318
319         * Plugins/WebBasePluginPackage.mm:
320         (-[WebBasePluginPackage getPluginInfoFromPLists]):
321         Set new members in PluginInfo.
322
323         * Plugins/WebNetscapePluginPackage.mm:
324         (-[WebNetscapePluginPackage getPluginInfoFromResources]):
325         Set new members in PluginInfo.
326
327         * WebCoreSupport/WebPlatformStrategies.h:
328         * WebCoreSupport/WebPlatformStrategies.mm:
329         (WebPlatformStrategies::getWebVisiblePluginInfo):
330         Override to wrap getPluginInfo().
331         (WebPlatformStrategies::setPluginLoadClientPolicy):
332         Override to do nothing.
333         (WebPlatformStrategies::clearPluginClientPolicies):
334         Ditto.
335
336         * WebView/WebFrame.mm:
337         (-[WebFrame _canProvideDocumentSource]):
338         Update to reflect function rename.
339
340 2015-03-10  Sam Weinig  <sam@webkit.org>
341
342         Allow adding a button in input elements for auto fill related functionality
343         <rdar://problem/19782066>
344         https://bugs.webkit.org/show_bug.cgi?id=142564
345
346         Reviewed by Anders Carlsson.
347
348         * DOM/WebDOMOperations.mm:
349         (-[DOMHTMLInputElement _setAutofilled:]):
350         Update for consistent spelling of AutoFill.
351
352 2015-03-10  Timothy Horton  <timothy_horton@apple.com>
353
354         Fix the build
355
356         * History/WebHistory.mm:
357         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
358         * WebCoreSupport/WebFrameLoaderClient.mm:
359         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
360
361 2015-03-10  Tim Horton  <timothy_horton@apple.com>
362
363         Fix the Mac build with a newer compiler
364
365         * Plugins/WebPluginController.mm:
366         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
367         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
368
369 2015-03-09  David Kilzer  <ddkilzer@apple.com>
370
371         [iOS] Fix build when compiling with dead code stripping disabled
372         <http://webkit.org/b/142467>
373
374         Reviewed by Simon Fraser.
375
376         * Configurations/WebKitLegacy.xcconfig:
377         (EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*]): Disable mig code
378         generation and compilation for out-of-process plugin support.
379         This was never used on iOS.
380
381 2015-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
382
383         [iOS] SVG fonts are garbled
384         https://bugs.webkit.org/show_bug.cgi?id=142377
385
386         Reviewed by Simon Fraser.
387
388         * Configurations/FeatureDefines.xcconfig:
389
390 2015-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
391
392         Hide Promise with runtime flags under Cocoa JSContext API
393         https://bugs.webkit.org/show_bug.cgi?id=141965
394
395         Reviewed by Filip Pizlo.
396
397         Add new JSC runtime flag, PromiseDisabled.
398
399         * WebView/WebPreferencesPrivate.h:
400
401 2015-03-03  Andy Estes  <aestes@apple.com>
402
403         [Content Filtering] Separate unblock handling into its own class
404         https://bugs.webkit.org/show_bug.cgi?id=142251
405
406         Reviewed by Andreas Kling.
407         
408         Adopted ContentFilterUnblockHandler.
409
410         * WebCoreSupport/WebFrameLoaderClient.h:
411         * WebCoreSupport/WebFrameLoaderClient.mm:
412         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
413         * WebView/WebFrame.mm:
414         (-[WebFrame _contentFilterDidHandleNavigationAction:]):
415         * WebView/WebFrameInternal.h:
416
417 2015-03-03  Chris Dumez  <cdumez@apple.com>
418
419         Access ApplicationCacheStorage global instance via singleton() static member function
420         https://bugs.webkit.org/show_bug.cgi?id=142239
421
422         Reviewed by Anders Carlsson.
423
424         Access ApplicationCacheStorage global instance via singleton() static
425         member function as per WebKit coding style.
426
427 2015-03-02  Jer Noble  <jer.noble@apple.com>
428
429         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
430         https://bugs.webkit.org/show_bug.cgi?id=142121
431
432         Reviewed by Simon Fraser.
433
434         Fullscreening a page with a non-1 scale would result in that scale being applied to the
435         fullscreen content, breaking fullscreen mode. Set the page scale to 1 when entering
436         fullscreen and reset it to the original value when exiting fullscreen.
437
438         * WebView/WebFullScreenController.h:
439         * WebView/WebFullScreenController.mm:
440         (-[WebFullScreenController enterFullScreen:]): Set the page scale to 1.
441         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Reset the page
442                 scale to the original value.
443         * WebView/WebView.mm:
444         (-[WebView _supportsFullScreenForElement:withKeyboard:]): Drive-by fix. Check the
445                 WebView's own preferences to see if fullscreen mode is enabled, rather than
446                 the global object's.
447
448 2015-03-01  Chris Dumez  <cdumez@apple.com>
449
450         Make NotificationCenter / Notification suspendable
451         https://bugs.webkit.org/show_bug.cgi?id=142117
452         <rdar://problem/19923085>
453
454         Reviewed by Andreas Kling.
455
456         Provide implementation for NotificationClient::hasPendingPermissionRequests().
457         The implementation is very simplistic. it will only return false if no
458         request for permission for ever made. This is because there is currently no
459         easy way to figure out if a permission request is pending or not.
460
461         * WebCoreSupport/WebNotificationClient.h:
462         * WebCoreSupport/WebNotificationClient.mm:
463         (WebNotificationClient::requestPermission):
464         (WebNotificationClient::hasPendingPermissionRequests):
465
466 2015-02-28  Simon Fraser  <simon.fraser@apple.com>
467
468         Viewport units should not dirty style just before we do layout
469         https://bugs.webkit.org/show_bug.cgi?id=141682
470
471         Reviewed by Zalan Bujtas.
472
473         * WebView/WebFrameView.mm:
474         (-[WebFrameView _frameSizeChanged]):
475
476 2015-02-26  Chris Dumez  <cdumez@apple.com>
477
478         Rename DatabaseManager::manager() to DatabaseManager::singleton()
479         https://bugs.webkit.org/show_bug.cgi?id=142054
480
481         Reviewed by Ryosuke Niwa.
482
483         Rename DatabaseManager::manager() to DatabaseManager::singleton() as
484         per coding style and use WTF::NeverDestroyed.
485
486         * Storage/WebDatabaseManager.mm:
487         (-[WebDatabaseManager init]):
488         (-[WebDatabaseManager origins]):
489         (-[WebDatabaseManager databasesWithOrigin:]):
490         (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
491         (-[WebDatabaseManager deleteAllDatabases]):
492         (-[WebDatabaseManager deleteOrigin:]):
493         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
494         * Storage/WebDatabaseQuotaManager.mm:
495         (-[WebDatabaseQuotaManager usage]):
496         (-[WebDatabaseQuotaManager quota]):
497         (-[WebDatabaseQuotaManager setQuota:]):
498         * WebCoreSupport/WebSecurityOrigin.mm:
499         (-[WebSecurityOrigin usage]):
500         (-[WebSecurityOrigin quota]):
501         (-[WebSecurityOrigin setQuota:]):
502         * WebView/WebFrame.mm:
503         (-[WebFrame _cacheabilityDictionary]):
504         * WebView/WebView.mm:
505         (-[WebView _preferencesChanged:]):
506
507 2015-02-26  Myles C. Maxfield  <mmaxfield@apple.com>
508
509         [Mac] [iOS] Parsing support for -apple-trailing-word
510         https://bugs.webkit.org/show_bug.cgi?id=141939
511
512         Reviewed by Andreas Kling.
513
514         * Configurations/FeatureDefines.xcconfig:
515
516 2015-02-24  Commit Queue  <commit-queue@webkit.org>
517
518         Unreviewed, rolling out r180599.
519         https://bugs.webkit.org/show_bug.cgi?id=141998
520
521         Lots of new test failures (Requested by smfr on #webkit).
522
523         Reverted changeset:
524
525         "Parsing support for -webkit-trailing-word"
526         https://bugs.webkit.org/show_bug.cgi?id=141939
527         http://trac.webkit.org/changeset/180599
528
529 2015-02-24  Myles C. Maxfield  <mmaxfield@apple.com>
530
531         [Mac] [iOS] Parsing support for -apple-trailing-word
532         https://bugs.webkit.org/show_bug.cgi?id=141939
533
534         Reviewed by Andreas Kling.
535
536         * Configurations/FeatureDefines.xcconfig:
537
538 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
539
540         REGRESSION(r179429): Can't type comments in Facebook
541         https://bugs.webkit.org/show_bug.cgi?id=141859
542
543         Reviewed by Brent Fulgham.
544
545         Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
546         Private API, javaScriptExperimentsEnabled is dropped.
547
548         * Misc/WebNSDictionaryExtras.h:
549         * Misc/WebNSDictionaryExtras.m:
550         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
551         * WebKit.order:
552         * WebView/WebPreferenceKeysPrivate.h:
553         * WebView/WebPreferences.mm:
554         (+[WebPreferences initialize]):
555         (-[WebPreferences _setUnsignedIntValue:forKey:]):
556         (-[WebPreferences javaScriptRuntimeFlags]):
557         (-[WebPreferences setJavaScriptRuntimeFlags:]):
558         (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
559         (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
560         * WebView/WebPreferencesPrivate.h:
561         * WebView/WebView.mm:
562         (-[WebView _preferencesChanged:]):
563
564 2015-02-23  Commit Queue  <commit-queue@webkit.org>
565
566         Unreviewed, rolling out r180547 and r180550.
567         https://bugs.webkit.org/show_bug.cgi?id=141957
568
569         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
570
571         Reverted changesets:
572
573         "REGRESSION(r179429): Can't type comments in Facebook"
574         https://bugs.webkit.org/show_bug.cgi?id=141859
575         http://trac.webkit.org/changeset/180547
576
577         "Constructor returning null should construct an object instead
578         of null"
579         https://bugs.webkit.org/show_bug.cgi?id=141640
580         http://trac.webkit.org/changeset/180550
581
582 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
583
584         Disable font loading events until our implementation gets updated to match the latest spec
585         https://bugs.webkit.org/show_bug.cgi?id=141938
586
587         Reviewed by Andreas Kling.
588
589         * Configurations/FeatureDefines.xcconfig:
590
591 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
592
593         REGRESSION(r179429): Can't type comments in Facebook
594         https://bugs.webkit.org/show_bug.cgi?id=141859
595
596         Reviewed by Geoffrey Garen.
597
598         Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
599         Private API, javaScriptExperimentsEnabled is dropped.
600
601         * Misc/WebNSDictionaryExtras.h:
602         * Misc/WebNSDictionaryExtras.m:
603         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
604         * WebKit.order:
605         * WebView/WebPreferenceKeysPrivate.h:
606         * WebView/WebPreferences.mm:
607         (+[WebPreferences initialize]):
608         (-[WebPreferences _setUnsignedIntValue:forKey:]):
609         (-[WebPreferences javaScriptRuntimeFlags]):
610         (-[WebPreferences setJavaScriptRuntimeFlags:]):
611         (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
612         (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
613         * WebView/WebPreferencesPrivate.h:
614         * WebView/WebView.mm:
615         (-[WebView _preferencesChanged:]):
616
617 2015-02-20  Eric Carlson  <eric.carlson@apple.com>
618
619         [iOS] cleanup AirPlay code
620         https://bugs.webkit.org/show_bug.cgi?id=141811
621
622         Reviewed by Jer Noble.
623
624         * Configurations/FeatureDefines.xcconfig: IOS_AIRPLAY -> WIRELESS_PLAYBACK_TARGET.
625
626 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
627
628         Adopt WebCore::IOSurface in ImageBuffer
629         https://bugs.webkit.org/show_bug.cgi?id=141751
630
631         Reviewed by Simon Fraser.
632
633         * WebCoreSupport/WebSystemInterface.mm:
634         (InitWebCoreSystemInterface):
635         Remove old WKSI IOSurface-related functions.
636
637 2015-02-18  Commit Queue  <commit-queue@webkit.org>
638
639         Unreviewed, rolling out r180286.
640         https://bugs.webkit.org/show_bug.cgi?id=141766
641
642         Caused >50 crashed LayoutTests (Requested by jernoble on
643         #webkit).
644
645         Reverted changeset:
646
647         "Page::userContentController() should return a reference, not
648         a pointer"
649         https://bugs.webkit.org/show_bug.cgi?id=141764
650         http://trac.webkit.org/changeset/180286
651
652 2015-02-18  Brady Eidson  <beidson@apple.com>
653
654         Page::userContentController() should return a reference, not a pointer
655         https://bugs.webkit.org/show_bug.cgi?id=141764
656
657         Reviewed by Jer Noble.
658
659         * WebView/WebView.mm:
660         (-[WebView setGroupName:]):
661
662 2015-02-18  Chris Dumez  <cdumez@apple.com>
663
664         Access FontCache global instance via singleton() static member function
665         https://bugs.webkit.org/show_bug.cgi?id=141726
666
667         Reviewed by Daniel Bates.
668
669         Access FontCache global instance via singleton() static member function,
670         as per coding style.
671
672 2015-02-17  Chris Dumez  <cdumez@apple.com>
673
674         Access MemoryPressureHandler global instance via a singleton() static member function
675         https://bugs.webkit.org/show_bug.cgi?id=141691
676
677         Reviewed by Andreas Kling.
678
679         Access MemoryPressureHandler global instance via a singleton() static
680         member function.
681
682         * WebView/WebView.mm:
683         (-[WebView _commonInitializationWithFrameName:groupName:]):
684         (+[WebView registerForMemoryNotifications]):
685         (+[WebView _isUnderMemoryPressure]):
686         (+[WebView _clearMemoryPressure]):
687         (+[WebView _shouldWaitForMemoryClearMessage]):
688         (WebInstallMemoryPressureHandler):
689
690 2015-02-15  Sam Weinig  <sam@webkit.org>
691
692         Add experimental <attachment> element support
693         https://bugs.webkit.org/show_bug.cgi?id=141626
694
695         Reviewed by Tim Horton.
696
697         * Configurations/FeatureDefines.xcconfig:
698
699 2015-02-14  Joseph Pecoraro  <pecoraro@apple.com>
700
701         [Mac] Possible DDActionContext leaks, RetainPtr cleanup
702         https://bugs.webkit.org/show_bug.cgi?id=141613
703
704         Reviewed by Tim Horton.
705
706         * WebCoreSupport/WebEditorClient.mm:
707         (WebEditorClient::WebEditorClient):
708         Avoid unnecessary retain/autorelease by adopting.
709
710         * WebView/WebActionMenuController.mm:
711         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
712         Adopt the allocated object.
713
714 2015-02-09  Brian J. Burg  <burg@cs.washington.edu>
715
716         Web Inspector: remove some unnecessary Inspector prefixes from class names in Inspector namespace
717         https://bugs.webkit.org/show_bug.cgi?id=141372
718
719         Reviewed by Joseph Pecoraro.
720
721         * WebCoreSupport/WebInspectorClient.mm:
722         (-[WebInspectorWindowController destroyInspectorView:]):
723
724 2015-02-14  Alexey Proskuryakov  <ap@apple.com>
725
726         rel="noreferrer" should make window.opener null
727         https://bugs.webkit.org/show_bug.cgi?id=141579
728
729         Reviewed by Darin Adler.
730
731         * WebView/WebPDFView.mm:
732         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Updated for a new WebCore
733         function signature. There is no rel="noreferrer" in PDF, so we can just always allow.
734
735 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
736
737         [Streams API] Implement a barebone ReadableStream interface
738         https://bugs.webkit.org/show_bug.cgi?id=141045
739
740         Reviewed by Benjamin Poulain.
741
742         * Configurations/FeatureDefines.xcconfig:
743
744 2015-02-03  Enrica Casucci  <enrica@apple.com>
745
746         [iOS] Add support for deleteFromInputWithFlags.
747         https://bugs.webkit.org/show_bug.cgi?id=141216
748         rdar://problem/19130081
749
750         Reviewed by Benjamin Poulain.
751
752         Adopts the new method as soon as it is available.
753         The patch also removes some obsolete code used for staging.
754
755         * WebView/WebHTMLView.mm:
756         (-[WebHTMLView _handleEditingKeyEvent:]):
757
758 2015-02-02  Chris Dumez  <cdumez@apple.com>
759
760         Access MemoryCache singleton using MemoryCache::singleton()
761         https://bugs.webkit.org/show_bug.cgi?id=141104
762
763         Reviewed by Andreas Kling.
764
765         Access MemoryCache singleton using MemoryCache::singleton() static
766         member function, instead of a free function, as per the recent
767         coding style discussion on WebKit-dev.
768
769 2015-02-01  Chris Dumez  <cdumez@apple.com>
770
771         Use more references in HistoryItem
772         https://bugs.webkit.org/show_bug.cgi?id=141133
773
774         Reviewed by Andreas Kling.
775
776         Use more references in HistoryItem instead of pointers.
777
778 2015-01-31  Sam Weinig  <sam@webkit.org>
779
780         Remove even more Mountain Lion support
781         https://bugs.webkit.org/show_bug.cgi?id=141124
782
783         Reviewed by Alexey Proskuryakov.
784
785         * Configurations/Base.xcconfig:
786         * Configurations/DebugRelease.xcconfig:
787         * Configurations/FeatureDefines.xcconfig:
788         * Configurations/Version.xcconfig:
789         * Configurations/WebKitLegacy.xcconfig:
790
791 2015-01-30  Eric Carlson  <eric.carlson@apple.com>
792
793         Remove MediaPlayerProxy.h
794         https://bugs.webkit.org/show_bug.cgi?id=141087
795
796         Reviewed by Sam Weinig.
797
798         * MigrateHeaders.make: Don't need to copy MediaPlayerProxy.h.
799         * Plugins/WebPluginController.mm: Don't include MediaPlayerProxy.h.
800
801 2015-01-30  Chris Dumez  <cdumez@apple.com>
802
803         Rename shared() static member functions to singleton() for singleton classes.
804         https://bugs.webkit.org/show_bug.cgi?id=141088
805
806         Reviewed by Ryosuke Niwa and Benjamin Poulain.
807
808         Rename shared() static member functions to singleton() for singleton
809         classes as per the recent coding style change.
810
811 2015-01-29  Beth Dakin  <bdakin@apple.com>
812
813         Remove more Mountain Lion code from WebKit
814         https://bugs.webkit.org/show_bug.cgi?id=141050
815
816         Reviewed by Anders Carlsson.
817
818         * History/WebHistory.mm:
819         (getDayBoundaries):
820         * Panels/WebAuthenticationPanel.m:
821         (-[WebAuthenticationPanel cancel:]):
822         (-[WebAuthenticationPanel logIn:]):
823         (-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]):
824         * WebCoreSupport/WebSystemInterface.mm:
825         (InitWebCoreSystemInterface):
826         * WebView/WebFrameView.mm:
827         * WebView/WebPreferences.mm:
828         (+[WebPreferences initialize]):
829         (needsScreenFontsEnabledQuirk):
830         * WebView/WebView.mm:
831         (+[WebView registerForMemoryNotifications]):
832         (-[WebView _preferencesChanged:]):
833         (+[WebView initialize]):
834         (+[WebView _shouldAutomaticQuoteSubstitutionBeEnabled]):
835         (+[WebView _shouldAutomaticDashSubstitutionBeEnabled]):
836         (+[WebView _didChangeAutomaticDashSubstitutionEnabled:]):
837
838 2015-01-29  Sam Weinig  <sam@webkit.org>
839
840         Remove support for screen font substitution
841         https://bugs.webkit.org/show_bug.cgi?id=141038
842
843         Reviewed by Tim Horton.
844
845         * Misc/WebKitNSStringExtras.mm:
846         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
847         (-[NSString _web_widthWithFont:]):
848         * Misc/WebStringTruncator.mm:
849         (fontFromNSFont):
850         Update for new signature of the FontPlatformData constructor, which no longer cares about
851         whether to use printer fonts.
852
853         * WebView/WebPreferenceKeysPrivate.h:
854         Remove the WebKitScreenFontSubstitutionEnabledKey key.
855
856         * WebView/WebPreferences.mm:
857         (+[WebPreferences initialize]):
858         Remove support for WebKitScreenFontSubstitutionEnabledKey.
859
860         (needsScreenFontsEnabledQuirk): Deleted.
861         Remove support for the Mountain Lion era 1-Password quirk.
862
863         (-[WebPreferences screenFontSubstitutionEnabled]): Deleted.
864         (-[WebPreferences setScreenFontSubstitutionEnabled:]): Deleted.
865         * WebView/WebPreferencesPrivate.h:
866         * WebView/WebView.mm:
867         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
868         (-[WebView _preferencesChanged:]):
869         Remove support for the screen font substitution setting.
870
871 2015-01-29  Chris Dumez  <cdumez@apple.com>
872
873         Clean up / modernize PageCache class
874         https://bugs.webkit.org/show_bug.cgi?id=141009
875
876         Reviewed by Darin Adler.
877
878         Clean up / modernize PageCache class.
879
880         * History/WebBackForwardList.mm:
881         (-[WebBackForwardList pageCacheSize]):
882         * WebView/WebView.mm:
883         (-[WebView _loadBackForwardListFromOtherView:]):
884         (-[WebView goToBackForwardItem:]):
885         (+[WebView _setCacheModel:]):
886
887 2015-01-28  Beth Dakin  <bdakin@apple.com>
888
889         Remove Mountain Lion code from WebKit and WebKit2
890         https://bugs.webkit.org/show_bug.cgi?id=141010
891
892         Reviewed by Sam Weinig.
893
894         * DOM/WebDOMOperations.mm:
895         (toNSEventPhase):
896         * WebView/WebHTMLView.mm:
897         (isQuickLookEvent):
898
899 2015-01-28  Dana Burkart  <dburkart@apple.com>
900
901         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
902         https://bugs.webkit.org/show_bug.cgi?id=136765
903
904         Reviewed by Alexey Proskuryakov.
905
906         * Configurations/Base.xcconfig:
907         * Configurations/DebugRelease.xcconfig:
908
909 2015-01-28  Chris Dumez  <cdumez@apple.com>
910
911         Fix typo in markPagesForVistedLinkStyleRecalc()
912         https://bugs.webkit.org/show_bug.cgi?id=140977
913
914         Reviewed by Darin Adler.
915
916         * WebCoreSupport/WebVisitedLinkStore.mm:
917         (WebVisitedLinkStore::removeAllVisitedLinks):
918         (WebVisitedLinkStore::removeVisitedLink):
919         (WebVisitedLinkStore::addVisitedLinkHash):
920
921 2015-01-28  Chris Dumez  <cdumez@apple.com>
922
923         Rename pageCache() to PageCache::shared() and return a reference
924         https://bugs.webkit.org/show_bug.cgi?id=140983
925
926         Reviewed by Andreas Kling.
927
928         Rename pageCache() to PageCache::shared() as this is a singleton class
929         and have it return a reference instead of a pointer.
930
931         * History/WebBackForwardList.mm:
932         (-[WebBackForwardList pageCacheSize]):
933         * Misc/WebCoreStatistics.mm:
934         (+[WebCoreStatistics cachedPageCount]):
935         (+[WebCoreStatistics cachedFrameCount]):
936         * WebCoreSupport/WebVisitedLinkStore.mm:
937         (WebVisitedLinkStore::removeAllVisitedLinks):
938         (WebVisitedLinkStore::removeVisitedLink):
939         (WebVisitedLinkStore::addVisitedLinkHash):
940         * WebView/WebView.mm:
941         (+[WebView _setCacheModel:]):
942
943 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
944
945         More build fixes for newer clang.
946
947         Rubber-stamped by Anders Carlsson.
948
949         Marked a deprecated accessibility method as such.
950
951         * WebView/WebFrame.mm:
952         (-[WebFrame accessibilityRoot]):
953
954 2015-01-27  Beth Dakin  <bdakin@apple.com>
955
956         Immediate action gesture recognizer still doesn't work well with IB
957         https://bugs.webkit.org/show_bug.cgi?id=140967
958         -and corresponding-
959         rdar://problem/19621509
960
961         Reviewed by Tim Horton.
962
963         We should add (or remove) the gesture recognizer in viewDidMoveToWindow because 
964         initWithFrame it too early and IB might mess with it.
965         * WebView/WebImmediateActionController.h:
966         * WebView/WebImmediateActionController.mm:
967         (-[WebImmediateActionController immediateActionRecognizer]):
968         * WebView/WebView.mm:
969         (-[WebView _commonInitializationWithFrameName:groupName:]):
970         (-[WebView viewDidMoveToWindow]):
971
972 2015-01-27  Dan Bernstein  <mitz@apple.com>
973
974         Fixed building projects that import WebView.h with WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS.
975
976         Rubber-stamped by Anders Carlsson.
977
978         * WebView/WebView.h: Added forward declarations of the protocols.
979
980 2015-01-26  Anders Carlsson  <andersca@apple.com>
981
982         Make it easy to test enabling formal delegate protocols
983         https://bugs.webkit.org/show_bug.cgi?id=140892
984
985         Reviewed by Dan Bernstein.
986
987         Add an WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS define that controls whether delegates should be formal protocols.
988
989         * Misc/WebDownload.h:
990         * WebView/WebFrameLoadDelegate.h:
991         * WebView/WebPolicyDelegate.h:
992         * WebView/WebResourceLoadDelegate.h:
993         * WebView/WebUIDelegate.h:
994         * WebView/WebView.h:
995
996 2015-01-26  Chris Dumez  <cdumez@apple.com>
997
998         Rename Document::body() to Document::bodyOrFrameset() for clarity
999         https://bugs.webkit.org/show_bug.cgi?id=140902
1000
1001         Reviewed by Andreas Kling.
1002
1003         Rename Document::body() to Document::bodyOrFrameset() for clarity. This
1004         method does not necessarily return an HTMLBodyElement, it can also
1005         return a frameset as per the specification:
1006         http://www.w3.org/TR/html5/dom.html#dom-tree-accessors
1007
1008         This method is often misused internally (the caller is only interested
1009         in the <body> element). I will fix these instances in a follow-up patch,
1010         this patch is only renaming mechanically.
1011
1012 2015-01-26  Chris Dumez  <cdumez@apple.com>
1013
1014         First argument to DOM traversal functions should be a reference
1015         https://bugs.webkit.org/show_bug.cgi?id=140895
1016
1017         Reviewed by Antti Koivisto.
1018
1019         First argument to DOM traversal functions should be a reference instead
1020         of a pointer as it is dereferenced without null-check.
1021
1022 2015-01-26  Myles C. Maxfield  <mmaxfield@apple.com>
1023
1024         [iOS] [SVG -> OTF Converter] Flip the switch off on iOS
1025         https://bugs.webkit.org/show_bug.cgi?id=140860
1026
1027         Reviewed by Darin Adler.
1028
1029         The fonts it makes are grotesque. (See what I did there? Typographic
1030         humor is the best humor.)
1031
1032         * Configurations/FeatureDefines.xcconfig:
1033
1034 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
1035
1036         QLPreviewMenuItem popovers don't close when the page scrolls
1037         https://bugs.webkit.org/show_bug.cgi?id=140806
1038         <rdar://problem/19555618>
1039
1040         Reviewed by Beth Dakin.
1041
1042         Now that QLPreviewMenuItem's popover doesn't eat scrolls, we need to dismiss it if the page scrolls.
1043
1044         * WebView/WebHTMLView.mm:
1045         (-[WebHTMLView scrollWheel:scrollWheel:]):
1046         Send scrollWheel along to WebImmediateActionController.
1047
1048         * WebView/WebImmediateActionController.h:
1049         * WebView/WebImmediateActionController.mm:
1050         (-[WebImmediateActionController webView:didHandleScrollWheel:]):
1051         (-[WebImmediateActionController _clearImmediateActionState]):
1052         (-[WebImmediateActionController _defaultAnimationController]):
1053         Keep track of the active QLPreviewMenuItem, and close it upon scroll.
1054
1055 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
1056
1057         Infinite recursion in _clearImmediateActionState
1058         https://bugs.webkit.org/show_bug.cgi?id=140807
1059         <rdar://problem/19571601>
1060
1061         Reviewed by Anders Carlsson.
1062
1063         * WebView/WebImmediateActionController.mm:
1064         (-[WebImmediateActionController _clearImmediateActionState]):
1065         Use this opportunity to bring identical code to WebKit1, to avoid
1066         getting DataDetectors stuck when an immediate action is canceled.
1067
1068 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1069
1070         Add a build flag for ES6 class syntax
1071         https://bugs.webkit.org/show_bug.cgi?id=140760
1072
1073         Reviewed by Michael Saboff.
1074
1075         * Configurations/FeatureDefines.xcconfig:
1076
1077 2015-01-22  Beth Dakin  <bdakin@apple.com>
1078
1079         ibtoold crash below -[WebView close]
1080         https://bugs.webkit.org/show_bug.cgi?id=140782
1081         -and corresponding-
1082         rdar://problem/19558472
1083
1084         Reviewed by Tim Horton.
1085
1086         Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but 
1087         it is because interface builder is messing with our views.
1088         * WebView/WebImmediateActionController.h:
1089         * WebView/WebImmediateActionController.mm:
1090         (-[WebImmediateActionController webViewClosed]):
1091         (-[WebImmediateActionController _cancelImmediateAction]):
1092         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1093         (-[WebImmediateActionController _updateImmediateActionItem]):
1094
1095 2015-01-21  Beth Dakin  <bdakin@apple.com>
1096
1097         Crash in QuickLook preview delegate method
1098         https://bugs.webkit.org/show_bug.cgi?id=140740
1099         -and corresponding-
1100         rdar://problem/19540806
1101
1102         Reviewed by Tim Horton.
1103
1104         Clear out the delegate.
1105         * WebView/WebImmediateActionController.mm:
1106         (-[WebImmediateActionController webViewClosed]):
1107
1108 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
1109
1110         Remove ENABLE(INSPECTOR) ifdef guards
1111         https://bugs.webkit.org/show_bug.cgi?id=140668
1112
1113         Reviewed by Darin Adler.
1114
1115         * Configurations/FeatureDefines.xcconfig:
1116         * WebCoreSupport/WebFrameLoaderClient.mm:
1117         (WebFrameLoaderClient::dispatchWillSendRequest):
1118
1119 2015-01-20  Anders Carlsson  <andersca@apple.com>
1120
1121         Remove USE(GLIB) code from WebKit1
1122         https://bugs.webkit.org/show_bug.cgi?id=140714
1123
1124         Reviewed by Andreas Kling.
1125
1126         * WebView/WebView.mm:
1127         (-[WebView _commonInitializationWithFrameName:groupName:]):
1128         (-[WebView _close]):
1129         (-[WebView _clearGlibLoopObserver]): Deleted.
1130         (glibContextIterationCallback): Deleted.
1131         (-[WebView _scheduleGlibContextIterations]): Deleted.
1132         * WebView/WebViewData.h:
1133         * WebView/WebViewInternal.h:
1134
1135 2015-01-20  David Kilzer  <ddkilzer@apple.com>
1136
1137         Switch to comparing PLATFORM_NAME in terms of macosx
1138         <http://webkit.org/b/139516>
1139
1140         Reviewed by Timothy Hatcher.
1141
1142         * MigrateHeaders.make:
1143         * postprocess-headers.sh:
1144
1145 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1146
1147         [SVG -> OTF Converter] Flip the switch on
1148         https://bugs.webkit.org/show_bug.cgi?id=140592
1149
1150         Reviewed by Antti Koivisto.
1151
1152         * Configurations/FeatureDefines.xcconfig:
1153
1154 2015-01-19  Beth Dakin  <bdakin@apple.com>
1155
1156         Speculative build fix.
1157
1158         * WebView/WebView.mm:
1159         (-[WebView _commonInitializationWithFrameName:groupName:]):
1160
1161 2015-01-19  Beth Dakin  <bdakin@apple.com>
1162
1163         Speculative build fix.
1164
1165         * WebView/WebView.mm:
1166         (-[WebView _convertRectFromRootView:]):
1167
1168 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
1169
1170         Adjust naming of action menu SPI
1171         https://bugs.webkit.org/show_bug.cgi?id=140644
1172         <rdar://problem/19448129>
1173
1174         Reviewed by Brian Weinstein.
1175
1176         * WebView/WebActionMenuController.mm:
1177         (-[WebActionMenuController prepareForMenu:withEvent:]):
1178         (-[WebActionMenuController willOpenMenu:withEvent:]):
1179         (-[WebActionMenuController didCloseMenu:withEvent:]):
1180         * WebView/WebView.mm:
1181         (-[WebView _commonInitializationWithFrameName:groupName:]):
1182         (-[WebView prepareForMenu:withEvent:]):
1183         (-[WebView willOpenMenu:withEvent:]):
1184         (-[WebView didCloseMenu:withEvent:]):
1185
1186 2015-01-19  Beth Dakin  <bdakin@apple.com>
1187
1188         REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is 
1189         offset by flipped-ness
1190         https://bugs.webkit.org/show_bug.cgi?id=140643
1191         -and corresponding-
1192         rdar://problem/19489593
1193
1194         Reviewed by Tim Horton.
1195
1196         We universally flipped because we assumed that the root view was flipped and the 
1197         WebView was not. However, in Dictionary, the WebView is flipped! So this patch 
1198         fixes that assumption by checking the WebView’s flipped-ness.
1199         * WebView/WebView.mm:
1200         (-[WebView _convertRectFromRootView:]):
1201
1202 2015-01-19  Commit Queue  <commit-queue@webkit.org>
1203
1204         Unreviewed, rolling out r178653.
1205         https://bugs.webkit.org/show_bug.cgi?id=140634
1206
1207         Broke multiple SVG tests on Mountain Lion (Requested by ap on
1208         #webkit).
1209
1210         Reverted changeset:
1211
1212         "[SVG -> OTF Converter] Flip the switch on"
1213         https://bugs.webkit.org/show_bug.cgi?id=140592
1214         http://trac.webkit.org/changeset/178653
1215
1216 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1217
1218         [SVG -> OTF Converter] Flip the switch on
1219         https://bugs.webkit.org/show_bug.cgi?id=140592
1220
1221         Reviewed by Antti Koivisto.
1222
1223         * Configurations/FeatureDefines.xcconfig:
1224
1225 2015-01-18  Daniel Bates  <dabates@apple.com>
1226
1227         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/178631>
1228         (https://bugs.webkit.org/show_bug.cgi?id=129441)
1229
1230         Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight().
1231         Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.
1232
1233         * WebInspector/WebNodeHighlightView.mm:
1234         (-[WebNodeHighlightView layoutSublayers:]):
1235
1236 2015-01-16  Beth Dakin  <bdakin@apple.com>
1237
1238         Make sure early cancellation of immediate action actually does that in WK1
1239         https://bugs.webkit.org/show_bug.cgi?id=140566
1240         -and corresponding-
1241         rdar://problem/19490114
1242
1243         Reviewed by Tim Horton.
1244
1245         Work around an AppKit bug by dispatching the call to _cancelImmediateAction 
1246         asynchronously.
1247         * WebView/WebImmediateActionController.mm:
1248         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1249
1250 2015-01-16  Daniel Bates  <dabates@apple.com>
1251
1252         Fix the public iOS SDK build after <http://trac.webkit.org/changeset/178285>
1253         (https://bugs.webkit.org/show_bug.cgi?id=140360)
1254
1255         Forward declare protocol NSURLDownloadDelegate as it is SPI on iOS.
1256
1257         * Misc/WebDownload.h:
1258
1259 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
1260
1261         Remove ENABLE(SQL_DATABASE) guards
1262         https://bugs.webkit.org/show_bug.cgi?id=140434
1263
1264         Reviewed by Darin Adler.
1265
1266         * Configurations/FeatureDefines.xcconfig:
1267         * Storage/WebDatabaseManager.mm:
1268         (databasesDirectoryPath):
1269         * Storage/WebDatabaseManagerClient.h:
1270         * Storage/WebDatabaseManagerClient.mm:
1271         * Storage/WebDatabaseManagerInternal.h:
1272         * Storage/WebDatabaseManagerPrivate.h:
1273         * Storage/WebDatabaseQuotaManager.mm:
1274         (-[WebDatabaseQuotaManager usage]):
1275         (-[WebDatabaseQuotaManager quota]):
1276         (-[WebDatabaseQuotaManager setQuota:]):
1277         * WebCoreSupport/WebChromeClient.h:
1278         * WebCoreSupport/WebChromeClient.mm:
1279         * WebCoreSupport/WebSecurityOrigin.mm:
1280         (-[WebSecurityOrigin usage]):
1281         (-[WebSecurityOrigin quota]):
1282         (-[WebSecurityOrigin setQuota:]):
1283         * WebView/WebFrame.mm:
1284         (-[WebFrame _cacheabilityDictionary]):
1285         * WebView/WebView.mm:
1286         (-[WebView _commonInitializationWithFrameName:groupName:]):
1287         (-[WebView _preferencesChanged:]):
1288
1289 2015-01-14  Chris Dumez  <cdumez@apple.com>
1290
1291         Make 'TypeName' parameter unnecessary in CSSPropertyNames.in
1292         https://bugs.webkit.org/show_bug.cgi?id=140347
1293
1294         Reviewed by Darin Adler.
1295
1296         Call FontDescription::setIsItalic() instead of setItalic() as the
1297         call site passes a boolean.
1298
1299         * WebView/WebHTMLView.mm:
1300         (fontNameForDescription):
1301
1302 2015-01-13  Anders Carlsson  <andersca@apple.com>
1303
1304         Temporarily reintroduce the informal delegate protocols
1305         https://bugs.webkit.org/show_bug.cgi?id=140416
1306
1307         Reviewed by Dan Bernstein.
1308
1309         * WebView/WebEditingDelegate.h:
1310         * WebView/WebFrameLoadDelegate.h:
1311         * WebView/WebPolicyDelegate.h:
1312         * WebView/WebResourceLoadDelegate.h:
1313         * WebView/WebUIDelegate.h:
1314
1315 2015-01-13  Beth Dakin  <bdakin@apple.com>
1316
1317         Should disable immediate actions for iTunes
1318         https://bugs.webkit.org/show_bug.cgi?id=140405
1319         -and corresponding-
1320         rdar://problem/19461358
1321
1322         Reviewed by Tim Horton.
1323
1324         * WebView/WebImmediateActionController.mm:
1325         (-[WebImmediateActionController _updateImmediateActionItem]):
1326
1327 2015-01-11  Sam Weinig  <sam@webkit.org>
1328
1329         Remove support for SharedWorkers
1330         https://bugs.webkit.org/show_bug.cgi?id=140344
1331
1332         Reviewed by Anders Carlsson.
1333
1334         * Configurations/FeatureDefines.xcconfig:
1335         * WebCoreSupport/WebPlatformStrategies.h:
1336         * WebCoreSupport/WebPlatformStrategies.mm:
1337         (WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
1338
1339 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
1340
1341         Get rid of unnecessary reimplementations of CGFloor/Ceiling
1342         https://bugs.webkit.org/show_bug.cgi?id=140375
1343
1344         Reviewed by Simon Fraser.
1345
1346         * Misc/WebKitNSStringExtras.mm:
1347         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
1348         (webkit_CGCeiling): Deleted.
1349         Delete unnecessary code, use the real CGFloor/Ceiling instead.
1350
1351 2015-01-12  Anders Carlsson  <andersca@apple.com>
1352
1353         Make delegates conform to formal delegate protocols
1354         https://bugs.webkit.org/show_bug.cgi?id=140370
1355
1356         Reviewed by Dan Bernstein.
1357
1358         * DefaultDelegates/WebDefaultPolicyDelegate.h:
1359         * WebCoreSupport/WebInspectorClient.mm:
1360         Add protocols to the interface declarations.
1361
1362         * WebView/WebActionMenuController.mm:
1363         (-[WebActionMenuController prepareForMenu:withEvent:]):
1364         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1365         * WebView/WebImmediateActionController.mm:
1366         (-[WebImmediateActionController _updateImmediateActionItem]):
1367         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1368         Cast to id when trying to invoke delegate methods that aren't on WebUIDelegate.
1369
1370 2015-01-12  Myles C. Maxfield  <mmaxfield@apple.com>
1371
1372         Allow targetting the SVG->OTF font converter with ENABLE(SVG_OTF_CONVERTER)
1373         https://bugs.webkit.org/show_bug.cgi?id=136769
1374
1375         Reviewed by Antti Koivisto.
1376
1377         * Configurations/FeatureDefines.xcconfig:
1378
1379 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
1380
1381         Multi-rect TextIndicators are vertically flipped in WebKit1
1382         https://bugs.webkit.org/show_bug.cgi?id=140350
1383         <rdar://problem/19441243>
1384
1385         Reviewed by Beth Dakin.
1386
1387         * WebView/WebView.mm:
1388         (-[WebView _setTextIndicator:fadeOut:]):
1389         Convert the textBoundingRect from root view to screen coordinates.
1390
1391 2015-01-12  Anders Carlsson  <andersca@apple.com>
1392
1393         Make WebResourceDelegate a formal protocol as well
1394         https://bugs.webkit.org/show_bug.cgi?id=140364
1395
1396         Reviewed by Dan Bernstein.
1397
1398         * WebView/WebResourceLoadDelegate.h:
1399
1400 2015-01-12  Anders Carlsson  <andersca@apple.com>
1401
1402         Delegates should be formal protocols
1403         https://bugs.webkit.org/show_bug.cgi?id=140360
1404         rdar://problem/17380856
1405
1406         Reviewed by Dan Bernstein.
1407
1408         This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
1409
1410         * DefaultDelegates/WebDefaultUIDelegate.h:
1411         * Misc/WebDownload.h:
1412         * WebView/WebEditingDelegate.h:
1413         * WebView/WebFrameLoadDelegate.h:
1414         * WebView/WebPolicyDelegate.h:
1415         * WebView/WebUIDelegate.h:
1416
1417 2015-01-09  Anders Carlsson  <andersca@apple.com>
1418
1419         Get rid of the database strategy
1420         https://bugs.webkit.org/show_bug.cgi?id=140322
1421
1422         Reviewed by Sam Weinig.
1423
1424         * WebCoreSupport/WebPlatformStrategies.h:
1425         * WebCoreSupport/WebPlatformStrategies.mm:
1426         (WebPlatformStrategies::createDatabaseStrategy): Deleted.
1427
1428 2015-01-08  Timothy Horton  <timothy_horton@apple.com>
1429
1430         Can't use DataDetectors after immediate action preparation
1431         https://bugs.webkit.org/show_bug.cgi?id=140263
1432         <rdar://problem/19412705>
1433
1434         Reviewed by Beth Dakin.
1435
1436         * WebView/WebImmediateActionController.mm:
1437         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1438         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1439         To match WebKit2, only call shouldUseActions if the animation is actually
1440         going to begin, not when preparing for it. This way, we're guaranteed
1441         to get a didCancel or didComplete.
1442
1443 2015-01-08  Dean Jackson  <dino@apple.com>
1444
1445         Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
1446         https://bugs.webkit.org/show_bug.cgi?id=140232
1447         <rdar://problem/19371010>
1448
1449         Reviewed by Anders Carlsson.
1450
1451         Remove the applicationChromeMode setting, but leave stubs in to make
1452         sure existing binaries don't break.
1453
1454         * WebCoreSupport/WebInspectorClient.mm:
1455         (-[WebInspectorWindowController init]):
1456         * WebView/WebPreferenceKeysPrivate.h:
1457         * WebView/WebPreferences.mm:
1458         (+[WebPreferences initialize]):
1459         (-[WebPreferences applicationChromeModeEnabled]):
1460         (-[WebPreferences setApplicationChromeModeEnabled:]):
1461         * WebView/WebView.mm:
1462         (-[WebView _preferencesChanged:]):
1463
1464 2015-01-07  Daniel Bates  <dabates@apple.com>
1465
1466         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
1467         https://bugs.webkit.org/show_bug.cgi?id=137371
1468
1469         Reviewed by David Kilzer.
1470
1471         Use SPI wrapper headers instead of directly references private SPI headers.
1472
1473         * Plugins/Hosted/NetscapePluginHostManager.mm:
1474
1475 2015-01-07  Commit Queue  <commit-queue@webkit.org>
1476
1477         Unreviewed, rolling out r178068.
1478         https://bugs.webkit.org/show_bug.cgi?id=140235
1479
1480         Breaks the iOS build (Requested by enrica on #webkit).
1481
1482         Reverted changeset:
1483
1484         "[iOS] Make WebKit2 build with public iOS SDK and more build
1485         fixes for DRT"
1486         https://bugs.webkit.org/show_bug.cgi?id=137371
1487         http://trac.webkit.org/changeset/178068
1488
1489 2015-01-07  Daniel Bates  <dabates@apple.com>
1490
1491         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
1492         https://bugs.webkit.org/show_bug.cgi?id=137371
1493
1494         Reviewed by David Kilzer.
1495
1496         Use SPI wrapper headers instead of directly references private SPI headers.
1497
1498         * Plugins/Hosted/NetscapePluginHostManager.mm:
1499
1500 2015-01-07  Beth Dakin  <bdakin@apple.com>
1501
1502         Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the 
1503         link
1504         https://bugs.webkit.org/show_bug.cgi?id=140206
1505         -and corresponding-
1506         rdar://problem/19300492
1507
1508         Reviewed by Tim Horton.
1509
1510         Providing and item frame will ensure that the original link is not obscured.
1511         * WebView/WebImmediateActionController.mm:
1512         (elementBoundingBoxInWindowCoordinatesFromNode):
1513         (-[WebImmediateActionController menuItem:itemFrameForPoint:]):
1514
1515         For now use a max size that is smaller than the WebView, with the screen’s aspect 
1516         ratio, and scaled down.
1517         (-[WebImmediateActionController menuItem:maxSizeForPoint:]):
1518
1519 2015-01-07  Anders Carlsson  <andersca@apple.com>
1520
1521         Give simple HTML documents a database provider
1522         https://bugs.webkit.org/show_bug.cgi?id=140192
1523         rdar://problem/19398825
1524
1525         Reviewed by Tim Horton.
1526
1527         * WebView/WebView.mm:
1528         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1529
1530 2015-01-06  Anders Carlsson  <andersca@apple.com>
1531
1532         Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
1533         https://bugs.webkit.org/show_bug.cgi?id=140140
1534
1535         Reviewed by Andreas Kling.
1536
1537         Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler
1538         out of WebCore since nobody else is using it.
1539
1540         * Plugins/WebNetscapePluginView.h:
1541         * Plugins/WebNetscapePluginView.mm:
1542         (-[WebNetscapePluginView _createPlugin]):
1543         (-[WebNetscapePluginView _destroyPlugin]):
1544         * Plugins/npapi.mm:
1545         (NPN_PluginThreadAsyncCall):
1546
1547 2015-01-06  Anders Carlsson  <andersca@apple.com>
1548
1549         Add a WebKit1 database provider
1550         https://bugs.webkit.org/show_bug.cgi?id=140126
1551
1552         Reviewed by Sam Weinig.
1553
1554         Set the database provider.
1555
1556         * WebView/WebView.mm:
1557         (-[WebView _commonInitializationWithFrameName:groupName:]):
1558
1559 2015-01-06  Commit Queue  <commit-queue@webkit.org>
1560
1561         Unreviewed, rolling out r177963.
1562         https://bugs.webkit.org/show_bug.cgi?id=140136
1563
1564         Caused lots of crashes (Requested by smfr on #webkit).
1565
1566         Reverted changeset:
1567
1568         "Add a WebKit1 database provider"
1569         https://bugs.webkit.org/show_bug.cgi?id=140126
1570         http://trac.webkit.org/changeset/177963
1571
1572 2015-01-06  Anders Carlsson  <andersca@apple.com>
1573
1574         Add a WebKit1 database provider
1575         https://bugs.webkit.org/show_bug.cgi?id=140126
1576
1577         Reviewed by Sam Weinig.
1578
1579         Set the database provider.
1580
1581         * WebView/WebView.mm:
1582         (-[WebView _commonInitializationWithFrameName:groupName:]):
1583
1584 2015-01-01  Jeff Miller  <jeffm@apple.com>
1585
1586         Update user-visible copyright strings to include 2015
1587         https://bugs.webkit.org/show_bug.cgi?id=139880
1588
1589         Reviewed by Darin Adler.
1590
1591         * Info.plist:
1592
1593 2014-12-30  Dan Bernstein  <mitz@apple.com>
1594
1595         [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
1596         https://bugs.webkit.org/show_bug.cgi?id=140003
1597
1598         Reviewed by Darin Adler.
1599
1600         * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
1601         that takes their "string" parameter as a "value" "parameter and has an attribute telling
1602         the compiler that if the "value" parameter is a format string then the function returns a
1603         modified version of it. The result is that if UI_STRING is used as a format string parameter
1604         to some function or method, the compiler will check the format specifiers in the string
1605         against the other parameters.
1606
1607 2014-12-29  Dan Bernstein  <mitz@apple.com>
1608
1609         Fixed the iOS build.
1610
1611         * Configurations/WebKitLegacy.xcconfig:
1612
1613 2014-12-29  Anders Carlsson  <andersca@apple.com>
1614
1615         Get rid of some PageGroup storage functions
1616         https://bugs.webkit.org/show_bug.cgi?id=139996
1617
1618         Reviewed by Sam Weinig.
1619
1620         Call WebStorageNamespaceProvider directly instead.
1621
1622         * Storage/WebStorageManager.mm:
1623         (-[WebStorageManager syncLocalStorage]):
1624         (+[WebStorageManager closeIdleLocalStorageDatabases]):
1625         * WebView/WebView.mm:
1626         (+[WebView _applicationWillTerminate]):
1627
1628 2014-12-29  Anders Carlsson  <andersca@apple.com>
1629
1630         Move storage code from WebCore to WebKit
1631         https://bugs.webkit.org/show_bug.cgi?id=139558
1632
1633         Reviewed by Darin Adler.
1634
1635         * Storage/WebStorageManager.mm:
1636         * Storage/WebStorageTrackerClient.h:
1637         * WebView/WebView.mm:
1638
1639 2014-12-26  Dan Bernstein  <mitz@apple.com>
1640
1641         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
1642         https://bugs.webkit.org/show_bug.cgi?id=139950
1643
1644         Reviewed by David Kilzer.
1645
1646         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
1647         in a manner that works with Xcode 5.1.1.
1648
1649 2014-12-23  Timothy Horton  <timothy_horton@apple.com>
1650
1651         Install a TextIndicator for link immediate actions
1652         https://bugs.webkit.org/show_bug.cgi?id=139897
1653         <rdar://problem/19333076>
1654
1655         Reviewed by Anders Carlsson.
1656
1657         * WebView/WebImmediateActionController.h:
1658         * WebView/WebImmediateActionController.mm:
1659         (-[WebImmediateActionController _clearImmediateActionState]):
1660         Tear down the TextIndicator, just like WebKit2.
1661
1662         (-[WebImmediateActionController _defaultAnimationController]):
1663         Install a TextIndicator for links.
1664
1665         (-[WebImmediateActionController menuItemDidClose:]):
1666         Tear down the TextIndicator when the QL preview closes.
1667
1668         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1669         Directly install and uninstall the TextIndicator for DataDetectors.
1670
1671         (-[WebImmediateActionController _showTextIndicator]): Deleted.
1672         (-[WebImmediateActionController _hideTextIndicator]): Deleted.
1673         Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
1674
1675 2014-12-20  Eric Carlson  <eric.carlson@apple.com>
1676
1677         [iOS] add optimized fullscreen API
1678         https://bugs.webkit.org/show_bug.cgi?id=139833
1679         <rdar://problem/18844486>
1680
1681         Reviewed by Simon Fraser.
1682
1683         * Configurations/FeatureDefines.xcconfig:  Add ENABLE_VIDEO_PRESENTATION_MODE.
1684
1685 2014-12-20  David Kilzer  <ddkilzer@apple.com>
1686
1687         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
1688         <http://webkit.org/b/139463>
1689
1690         Reviewed by Mark Rowe.
1691
1692         * Configurations/Base.xcconfig:
1693         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
1694           on OS X.
1695         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
1696         * Configurations/DebugRelease.xcconfig:
1697         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
1698         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
1699         * Configurations/Version.xcconfig:
1700         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
1701         * Configurations/WebKitLegacy.xcconfig:
1702         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
1703           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
1704           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
1705           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
1706           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
1707           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
1708           WEBCORE_PRIVATE_HEADERS_DIR_Production and
1709           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
1710           based on SDK.
1711         - Fix PRODUCTION_ROOT to actually be set properly.
1712         - Simplify EXPORTED_SYMBOLS_FILE_i386.
1713
1714         * migrate-headers.sh:
1715         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
1716         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
1717           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
1718           WebKitLegacy.xcconfig.
1719
1720 2014-12-19  Simon Fraser  <simon.fraser@apple.com>
1721
1722         Fix pink background on CoreAnimation plug-ins in WebKit1
1723         https://bugs.webkit.org/show_bug.cgi?id=139845
1724         rdar://problem/19313075
1725
1726         Reviewed by Tim Horton.
1727         
1728         r154078 left in some debugging code that set a pink background on plug-in hosting
1729         layers. Remove it.
1730
1731         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1732         (-[WebHostedNetscapePluginView createPluginLayer]):
1733
1734 2014-12-19  Andreas Kling  <akling@apple.com>
1735
1736         Ref-ify TextIterator API.
1737         <https://webkit.org/b/139823>
1738
1739         Reviewed by Antti Koivisto.
1740
1741         * WebView/WebTextIterator.mm:
1742         (-[WebTextIterator currentRange]):
1743
1744 2014-12-19  Joseph Pecoraro  <pecoraro@apple.com>
1745
1746         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
1747         https://bugs.webkit.org/show_bug.cgi?id=139797
1748
1749         Reviewed by Mark Lam.
1750
1751         * WebView/WebScriptDebugger.h:
1752         * WebView/WebScriptDebugger.mm:
1753         (WebScriptDebugger::handlePause):
1754         Standardize on passing JSGlobalObject parameter first.
1755
1756 2014-12-19  Commit Queue  <commit-queue@webkit.org>
1757
1758         Unreviewed, rolling out r177574.
1759         https://bugs.webkit.org/show_bug.cgi?id=139821
1760
1761         "Broke Production builds by installing
1762         libWebCoreTestSupport.dylib in the wrong directory" (Requested
1763         by ddkilzer on #webkit).
1764
1765         Reverted changeset:
1766
1767         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
1768         WebInspectorUI, WebKit, WebKit2"
1769         https://bugs.webkit.org/show_bug.cgi?id=139463
1770         http://trac.webkit.org/changeset/177574
1771
1772 2014-12-19  David Kilzer  <ddkilzer@apple.com>
1773
1774         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
1775         <http://webkit.org/b/139463>
1776
1777         Reviewed by Mark Rowe.
1778
1779         * Configurations/Base.xcconfig:
1780         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
1781           on OS X.
1782         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
1783         * Configurations/DebugRelease.xcconfig:
1784         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
1785         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
1786         * Configurations/Version.xcconfig:
1787         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
1788         * Configurations/WebKitLegacy.xcconfig:
1789         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
1790           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
1791           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
1792           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
1793           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
1794           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
1795           WEBCORE_PRIVATE_HEADERS_DIR_Production and
1796           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
1797           based on SDK.
1798         - Fix PRODUCTION_ROOT to actually be set properly.
1799         - Simplify EXPORTED_SYMBOLS_FILE_i386.
1800
1801         * migrate-headers.sh:
1802         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
1803         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
1804           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
1805           WebKitLegacy.xcconfig.
1806
1807 2014-12-18  Andreas Kling  <akling@apple.com>
1808
1809         Ref-ify various Document-related things.
1810         <https://webkit.org/b/139796>
1811
1812         Reviewed by Anders Carlsson.
1813
1814         * WebView/WebFrame.mm:
1815         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
1816
1817 2014-12-18  Beth Dakin  <bdakin@apple.com>
1818
1819         Need to re-enable action menus
1820         https://bugs.webkit.org/show_bug.cgi?id=139795
1821         -and corresponding-
1822         rdar://problem/19299367
1823
1824         Reviewed by Tim Horton.
1825
1826         Re-enable the menus by un-commenting the code to create the menu and controller.
1827         * WebView/WebView.mm:
1828         (-[WebView _commonInitializationWithFrameName:groupName:]):
1829
1830 2014-12-16  Sam Weinig  <sam@webkit.org>
1831
1832         Unify the Mac and iOS implementations of FontPlatformData a bit
1833         https://bugs.webkit.org/show_bug.cgi?id=139721
1834
1835         Reviewed by Anders Carlsson.
1836
1837         * WebView/WebHTMLView.mm:
1838         (fontNameForDescription):
1839         Update for new function name.
1840
1841 2014-12-18  Antti Koivisto  <antti@apple.com>
1842
1843         Remove alwaysUseBaselineOfPrimaryFont setting
1844         https://bugs.webkit.org/show_bug.cgi?id=139770
1845
1846         Reviewed by Anders Carlsson.
1847
1848         * WebView/WebPreferenceKeysPrivate.h:
1849         * WebView/WebPreferences.mm:
1850         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
1851         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
1852         * WebView/WebPreferencesPrivate.h:
1853         * WebView/WebView.mm:
1854         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1855         (-[WebView _preferencesChanged:]):
1856
1857 2014-12-17  Andreas Kling  <akling@apple.com>
1858
1859         Ref-ify Range::create().
1860         <https://webkit.org/b/139755>
1861
1862         Reviewed by Anders Carlsson.
1863
1864         * WebView/WebHTMLRepresentation.mm:
1865         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
1866         * WebView/WebHTMLView.mm:
1867         (-[WebHTMLView attributedString]):
1868
1869 2014-12-17  Anders Carlsson  <andersca@apple.com>
1870
1871         Unify -[WebResource description]
1872         https://bugs.webkit.org/show_bug.cgi?id=139762
1873
1874         Reviewed by Dan Bernstein.
1875
1876         * WebView/WebResource.mm:
1877         (-[WebResource description]):
1878
1879 2014-12-17  Anders Carlsson  <andersca@apple.com>
1880
1881         Get rid of an ugly #define hack in WebFrameLoaderClient
1882         https://bugs.webkit.org/show_bug.cgi?id=139761
1883
1884         Reviewed by Dan Bernstein.
1885
1886         Also replace @private with @package in all public headers, for consistency.
1887
1888         * History/WebBackForwardList.h:
1889         * History/WebHistory.h:
1890         * Misc/WebDownload.h:
1891         * WebCoreSupport/WebFrameLoaderClient.mm:
1892         * WebView/WebArchive.h:
1893         * WebView/WebDataSource.h:
1894         * WebView/WebFrame.h:
1895         * WebView/WebFrameView.h:
1896         * WebView/WebPreferences.h:
1897         * WebView/WebResource.h:
1898
1899 2014-12-17  Dan Bernstein  <mitz@apple.com>
1900
1901         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
1902         https://bugs.webkit.org/show_bug.cgi?id=139760
1903
1904         Reviewed by Anders Carlsson.
1905
1906         * Configurations/WebKitLegacy.xcconfig:
1907
1908 2014-12-17  Andreas Kling  <akling@apple.com>
1909
1910         Purge PassRefPtr from Frame.
1911         <https://webkit.org/b/139731>
1912
1913         Reviewed by Anders Carlsson.
1914
1915         * WebCoreSupport/WebFrameLoaderClient.mm:
1916         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1917         * WebView/WebFrame.mm:
1918         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
1919         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
1920         * WebView/WebFrameInternal.h:
1921
1922 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
1923
1924         Implement and adopt two new TextIndicator presentation animations
1925         https://bugs.webkit.org/show_bug.cgi?id=139715
1926         <rdar://problem/19237945>
1927
1928         Reviewed by Anders Carlsson.
1929
1930         * WebView/WebActionMenuController.mm:
1931         (-[WebActionMenuController _showTextIndicator]):
1932         * WebView/WebHTMLView.mm:
1933         (-[WebHTMLView quickLookWithEvent:]):
1934         Remove the completionHandler from text indicator presentation.
1935
1936         * WebView/WebImmediateActionController.mm:
1937         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1938         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
1939         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1940         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1941         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1942         (-[WebImmediateActionController _animationControllerForText]):
1943         (-[WebImmediateActionController _showTextIndicator]):
1944         Forward immediate action gesture recognizer animation progress
1945         to TextIndicator. Force us to keep the selection when immediate
1946         action popovers steal first responder status from the WebView.
1947         If the Lookup range is equal to the selection range, use a Crossfade
1948         animation; otherwise, use a FadeIn animation.
1949
1950         * WebView/WebView.mm:
1951         (-[WebView _setMaintainsInactiveSelection:]):
1952         (-[WebView maintainsInactiveSelection]):
1953         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1954         (-[WebView _setTextIndicator:fadeOut:]):
1955         (-[WebView _clearTextIndicator]):
1956         (-[WebView _setTextIndicatorAnimationProgress:]):
1957         (-[WebView _showDictionaryLookupPopup:]):
1958         (-[WebView _dictionaryLookupPopoverWillClose:]):
1959         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1960         Remove the completionHandler from text indicator presentation.
1961         Add a _setMaintainsInactiveSelection, which allows WebKit internals
1962         to change the return value of -maintainsInactiveSelection, allowing
1963         us to keep the selection alive when the WebView loses first responder status.
1964
1965         * WebView/WebViewData.h:
1966         * WebView/WebViewInternal.h:
1967
1968 2014-12-16  Andreas Kling  <akling@apple.com>
1969
1970         Use Ref for SecurityOrigin.
1971         <https://webkit.org/b/139710>
1972
1973         Reviewed by Anders Carlsson.
1974
1975         * Storage/WebStorageTrackerClient.mm:
1976         (WebStorageTrackerClient::dispatchDidModifyOrigin):
1977         * WebView/WebView.mm:
1978         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
1979         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
1980
1981 2014-12-16  Beth Dakin  <bdakin@apple.com>
1982
1983         Crash getting default animation controller for some text
1984         https://bugs.webkit.org/show_bug.cgi?id=139712
1985         -and corresponding-
1986         rdar://problem/19271707
1987
1988         Reviewed by Tim Horton.
1989
1990         Must null-check the range.
1991         * WebView/WebImmediateActionController.mm:
1992         (-[WebImmediateActionController _animationControllerForText]):
1993
1994 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
1995
1996         Immediate action popovers can get stuck open
1997         https://bugs.webkit.org/show_bug.cgi?id=139709
1998         <rdar://problem/19270279>
1999
2000         Reviewed by Beth Dakin.
2001
2002         * WebView/WebImmediateActionController.mm:
2003         (-[WebImmediateActionController _clearImmediateActionState]):
2004         Don't clear the animation controller; it breaks things and was unnecessary.
2005
2006 2014-12-16  Tim Horton  <timothy_horton@apple.com>
2007
2008         Disable TextIndication for Lookup immediate actions
2009         https://bugs.webkit.org/show_bug.cgi?id=139684
2010
2011         Reviewed by Anders Carlsson.
2012
2013         * WebView/WebView.mm:
2014         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2015
2016 2014-12-15  Beth Dakin  <bdakin@apple.com>
2017
2018         Build fix.
2019
2020         * WebView/WebImmediateActionController.mm:
2021
2022 2014-12-15  Beth Dakin  <bdakin@apple.com>
2023
2024         Speculative build fix.
2025
2026         * WebView/WebView.mm:
2027         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2028         * WebView/WebViewInternal.h:
2029
2030 2014-12-15  Beth Dakin  <bdakin@apple.com>
2031
2032         Make lookup an immediate action instead of an action menu item
2033         https://bugs.webkit.org/show_bug.cgi?id=139661
2034         -and corresponding-
2035         rdar://problem/19198414
2036
2037         Reviewed by Tim Horton.
2038
2039         Remove the lookup menu items and non-unused static function associated with 
2040         lookup.
2041         * WebView/WebActionMenuController.mm:
2042         (-[WebActionMenuController _defaultMenuItemsForText]):
2043         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
2044         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
2045         (-[WebActionMenuController _createActionMenuItemForTag:]):
2046         (-[WebActionMenuController _lookupText:]): Deleted.
2047         (performDictionaryLookupForSelection): Deleted.
2048         (performDictionaryLookupForRange): Deleted.
2049
2050         Set the defaultAnimationController to the lookup-provided animation controller 
2051         when appropriate.
2052         * WebView/WebImmediateActionController.mm:
2053         (-[WebImmediateActionController _defaultAnimationController]):
2054         (dictionaryPopupInfoForRange):
2055         (-[WebImmediateActionController _animationControllerForText]):
2056
2057         New type.
2058         * WebView/WebUIDelegatePrivate.h:
2059
2060         New function to get the lookup animation controller.
2061         * WebView/WebView.mm:
2062         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2063         * WebView/WebViewInternal.h:
2064
2065 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2066
2067         Implement Data Detectors immediate actions for Legacy WebKit
2068         https://bugs.webkit.org/show_bug.cgi?id=139619
2069         <rdar://problem/19198539>
2070
2071         Reviewed by Beth Dakin.
2072
2073         * WebView/WebImmediateActionController.mm:
2074         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2075         Note that this action context is only for immediate actions.
2076
2077 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
2078
2079         Addressing post-review comments in r177035
2080         https://bugs.webkit.org/show_bug.cgi?id=139557
2081
2082         Reviewed by Darin Adler.
2083
2084         * WebView/WebActionMenuController.mm:
2085         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
2086
2087 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2088
2089         Implement Data Detectors immediate actions for Legacy WebKit
2090         https://bugs.webkit.org/show_bug.cgi?id=139619
2091         <rdar://problem/19198539>
2092
2093         Reviewed by Eric Carlson.
2094
2095         * WebView/WebHTMLView.mm:
2096         (-[WebHTMLView mouseDown:mouseDown:]):
2097         Send mouseDown along to the WebImmediateActionController too.
2098
2099         * WebView/WebImmediateActionController.h:
2100         * WebView/WebImmediateActionController.mm:
2101         (-[WebImmediateActionController webViewClosed]):
2102         (-[WebImmediateActionController webView:willHandleMouseDown:]):
2103         (-[WebImmediateActionController _cancelImmediateAction]):
2104         (-[WebImmediateActionController _clearImmediateActionState]):
2105         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2106         (-[WebImmediateActionController _defaultAnimationController]):
2107         (-[WebImmediateActionController _updateImmediateActionItem]):
2108         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2109         (-[WebImmediateActionController _showTextIndicator]):
2110         (-[WebImmediateActionController _hideTextIndicator]):
2111         Copy most of the DataDetectors implementation into WebImmediateActionController.
2112
2113         * WebView/WebUIDelegatePrivate.h:
2114         Add a new type.
2115
2116         * WebView/WebView.mm:
2117         (-[WebView _commonInitializationWithFrameName:groupName:]):
2118         Temporarily disable action menus.
2119
2120         (-[WebView _immediateActionController]):
2121         * WebView/WebViewInternal.h:
2122
2123 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
2124
2125         Delete Notation because we don't use it
2126         https://bugs.webkit.org/show_bug.cgi?id=139171
2127
2128         Reviewed by Kent Tamura.
2129
2130         * MigrateHeaders.make:
2131
2132 2014-12-14  Andreas Kling  <akling@apple.com>
2133
2134         Replace PassRef with Ref/Ref&& across the board.
2135         <https://webkit.org/b/139587>
2136
2137         Reviewed by Darin Adler.
2138
2139         * WebCoreSupport/WebEditorClient.mm:
2140         (WebEditorClient::shouldApplyStyle):
2141         * WebCoreSupport/WebVisitedLinkStore.h:
2142         * WebCoreSupport/WebVisitedLinkStore.mm:
2143         (WebVisitedLinkStore::create):
2144
2145 2014-12-11  Dan Bernstein  <mitz@apple.com>
2146
2147         Fix a leak introduced in r177199.
2148
2149         Reviewed by Anders Carlsson.
2150
2151         * WebView/WebImmediateActionController.mm:
2152         (-[WebImmediateActionController _updateImmediateActionItem]):
2153
2154 2014-12-11  Beth Dakin  <bdakin@apple.com>
2155
2156         WK1: Need new SPI for Webkit clients to override default immediate action
2157         https://bugs.webkit.org/show_bug.cgi?id=139568
2158         -and corresponding-
2159         rdar://problem/19225448
2160
2161         Reviewed by Dan Bernstein.
2162
2163         Call SPI giving clients a chance to override the default behavior.
2164         * WebView/WebImmediateActionController.mm:
2165         (-[WebImmediateActionController _updateImmediateActionItem]):
2166
2167         New SPI.
2168         * WebView/WebUIDelegatePrivate.h:
2169
2170 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
2171
2172         Move the preview popover to WebImmediateActionController
2173         https://bugs.webkit.org/show_bug.cgi?id=139563
2174         <rdar://problem/19208291>
2175
2176         Reviewed by Beth Dakin.
2177
2178         * WebView/WebActionMenuController.mm:
2179         (-[WebActionMenuController _defaultMenuItemsForLink]):
2180         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
2181         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
2182         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
2183         * WebView/WebImmediateActionController.h:
2184         * WebView/WebImmediateActionController.mm:
2185         (-[WebImmediateActionController webViewClosed]):
2186         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2187         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
2188         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
2189         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
2190         (-[WebImmediateActionController _updateImmediateActionItem]):
2191         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
2192         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
2193         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
2194         Move page preview popover related code to WebImmediateActionController.
2195
2196         * WebView/WebUIDelegatePrivate.h:
2197         Add a link preview type.
2198
2199         * WebView/WebView.mm:
2200         (-[WebView _commonInitializationWithFrameName:groupName:]):
2201         Pass the gesture recognizer to the WebImmediateActionController.
2202
2203 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
2204
2205         Fix the build.
2206
2207         * WebView/WebImmediateActionController.h:
2208         * WebView/WebImmediateActionController.mm:
2209
2210 2014-12-11  Anders Carlsson  <andersca@apple.com>
2211
2212         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
2213         https://bugs.webkit.org/show_bug.cgi?id=139547
2214
2215         Reviewed by Sam Weinig.
2216
2217         * WebView/WebView.mm:
2218         (+[WebView _handleMemoryWarning]):
2219
2220 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
2221
2222         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
2223         https://bugs.webkit.org/show_bug.cgi?id=139504
2224         rdar://problem/19034674
2225
2226         Reviewed by Enrica Casucci.
2227
2228         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
2229
2230         * WebCoreSupport/WebEditorClient.h:
2231         * WebCoreSupport/WebEditorClient.mm:
2232         (WebEditorClient::discardedComposition):
2233
2234 2014-12-10  Anders Carlsson  <andersca@apple.com>
2235
2236         Get rid of the storage strategy
2237         https://bugs.webkit.org/show_bug.cgi?id=139519
2238
2239         Reviewed by Antti Koivisto.
2240
2241         * WebCoreSupport/WebPlatformStrategies.h:
2242         * WebCoreSupport/WebPlatformStrategies.mm:
2243         (WebPlatformStrategies::createStorageStrategy): Deleted.
2244
2245 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
2246
2247         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
2248         https://bugs.webkit.org/show_bug.cgi?id=139529
2249         <rdar://problem/19213620>
2250
2251         Reviewed by Beth Dakin.
2252
2253         * WebView/WebActionMenuController.mm:
2254         (-[WebActionMenuController _copySelection:]):
2255         (-[WebActionMenuController _paste:]):
2256         Use the copy: and paste: methods on WebView so that we traverse subviews
2257         when trying to respond, otherwise these actions don't work in subframes.
2258
2259 2014-12-10  Beth Dakin  <bdakin@apple.com>
2260
2261         WK1: Add initial support for immediate actions
2262         https://bugs.webkit.org/show_bug.cgi?id=139522
2263
2264         Reviewed by Dan Bernstein.
2265
2266         This basic implementation of the controller will use the delegate methods to 
2267         perform and cache a HitTest when relevant. Future patches will patch 
2268         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
2269         immediate action that should be taken.
2270         * WebView/WebImmediateActionController.h: Added.
2271         * WebView/WebImmediateActionController.mm: Added.
2272         (-[WebImmediateActionController webViewClosed]):
2273         (-[WebImmediateActionController _clearImmediateActionState]):
2274         (-[WebImmediateActionController performHitTestAtPoint:]):
2275         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2276         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
2277         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
2278         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
2279         (-[WebImmediateActionController _updateImmediateActionItem]):
2280
2281         New enum for immediate action types.
2282         * WebView/WebUIDelegatePrivate.h:
2283
2284         Create an NSImmediateActionGestureRecognizer if possible and a controller.
2285         * WebView/WebView.mm:
2286         (-[WebView _commonInitializationWithFrameName:groupName:]):
2287         (-[WebView _close]):
2288         * WebView/WebViewData.h:
2289         * WebView/WebViewData.mm:
2290         (-[WebViewPrivate dealloc]):
2291
2292 2014-12-08  Anders Carlsson  <andersca@apple.com>
2293
2294         Use the new storage namespace provider in WebKit1
2295         https://bugs.webkit.org/show_bug.cgi?id=139425
2296
2297         Reviewed by Tim Horton.
2298
2299         * WebView/WebView.mm:
2300         (-[WebView _commonInitializationWithFrameName:groupName:]):
2301         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2302         Set the storage namespace provider from the web page group.
2303
2304 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
2305
2306         Should have copy and paste items in all text menus
2307         https://bugs.webkit.org/show_bug.cgi?id=139510
2308         <rdar://problem/19198388>
2309
2310         Reviewed by Beth Dakin.
2311
2312         * WebView/WebActionMenuController.mm:
2313         (-[WebActionMenuController _defaultMenuItemsForText]):
2314         Add a disabled paste menu item into the read-only text menu.
2315
2316         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
2317         Add a disabled copy menu item into the editable whitespace text menu.
2318
2319 2014-12-10  Anders Carlsson  <andersca@apple.com>
2320
2321         Add WebStorageNamespaceProvider::closeLocalStorage
2322         https://bugs.webkit.org/show_bug.cgi?id=139502
2323
2324         Reviewed by Tim Horton.
2325
2326         * WebView/WebView.mm:
2327         (+[WebView _applicationWillTerminate]):
2328         Call WebStorageNamespaceProvider::closeLocalStorage.
2329
2330 2014-12-09  Commit Queue  <commit-queue@webkit.org>
2331
2332         Unreviewed, rolling out r177037.
2333         https://bugs.webkit.org/show_bug.cgi?id=139464
2334
2335         broke ~50 API tests (Requested by thorton on #webkit).
2336
2337         Reverted changeset:
2338
2339         "Use the new storage namespace provider in WebKit1"
2340         https://bugs.webkit.org/show_bug.cgi?id=139425
2341         http://trac.webkit.org/changeset/177037
2342
2343 2014-12-08  Anders Carlsson  <andersca@apple.com>
2344
2345         Use the new storage namespace provider in WebKit1
2346         https://bugs.webkit.org/show_bug.cgi?id=139425
2347
2348         Reviewed by Tim Horton.
2349
2350         * WebView/WebView.mm:
2351         (-[WebView _commonInitializationWithFrameName:groupName:]):
2352         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2353         Set the storage namespace provider from the web page group.
2354
2355 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
2356
2357         Delete Node::boundingBox()
2358         https://bugs.webkit.org/show_bug.cgi?id=139333
2359
2360         Reviewed by Zalan Bujtas.
2361
2362         * WebView/WebActionMenuController.mm:
2363         (elementBoundingBoxInWindowCoordinatesFromNode): Use
2364         RenderObject::absoluteBoundingBoxRect().
2365
2366 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
2367
2368         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
2369         https://bugs.webkit.org/show_bug.cgi?id=138843
2370         rdar://problem/18793695
2371
2372         Reviewed by Dan Bernstein.
2373
2374         * Panels/WebAuthenticationPanel.m:
2375         (-[WebAuthenticationPanel cancel:]):
2376         (-[WebAuthenticationPanel logIn:]):
2377         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
2378         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
2379         that only when using an old NSWindow API.
2380
2381 2014-12-08  Beth Dakin  <bdakin@apple.com>
2382
2383         Copy and Lookup menu items should be disabled when something is not copyable
2384         https://bugs.webkit.org/show_bug.cgi?id=139423
2385
2386         Reviewed by Tim Horton.
2387
2388         Disable both lookup and copy when a HitTestResult does not allow copy.
2389         * WebView/WebActionMenuController.mm:
2390
2391         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
2392         disable state otherwise.
2393         * WebView/WebView.mm:
2394         (-[WebView _commonInitializationWithFrameName:groupName:]):
2395
2396 2014-12-08  Anders Carlsson  <andersca@apple.com>
2397
2398         Adding user content to a group should force that group to be created
2399         https://bugs.webkit.org/show_bug.cgi?id=139421
2400         rdar://problem/19180108
2401
2402         Reviewed by Sam Weinig.
2403
2404         * WebCoreSupport/WebViewGroup.h:
2405         Store the local storage database path in the group.
2406
2407         * WebCoreSupport/WebViewGroup.mm:
2408         (WebViewGroup::getOrCreate):
2409         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
2410         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
2411
2412         (WebViewGroup::WebViewGroup):
2413         Initialize the new member variable.
2414
2415         (WebViewGroup::storageNamespaceProvider):
2416         Create the namespace provider lazily.
2417
2418         * WebView/WebView.mm:
2419         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
2420         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
2421         Use getOrCreate instead of get.
2422
2423 2014-12-08  Anders Carlsson  <andersca@apple.com>
2424
2425         WebStorageNamespaceProvider should know about its local storage database path
2426         https://bugs.webkit.org/show_bug.cgi?id=139413
2427
2428         Reviewed by Andreas Kling.
2429
2430         * WebCoreSupport/WebViewGroup.h:
2431         * WebCoreSupport/WebViewGroup.mm:
2432         (WebViewGroup::getOrCreate):
2433         (WebViewGroup::WebViewGroup):
2434         * WebView/WebView.mm:
2435         (-[WebView _commonInitializationWithFrameName:groupName:]):
2436         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2437         (-[WebView setGroupName:]):
2438         (-[WebView groupName]): Deleted.
2439
2440 2014-12-08  Daniel Bates  <dabates@apple.com>
2441
2442         [iOS] Fix the WebKit build with the public SDK
2443
2444         Include header NSURLDownloadSPI.h.
2445
2446         * WebCoreSupport/WebFrameLoaderClient.mm:
2447
2448 2014-12-07  Dan Bernstein  <mitz@apple.com>
2449
2450         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
2451         https://bugs.webkit.org/show_bug.cgi?id=139348
2452
2453         Reviewed by Anders Carlsson.
2454
2455         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
2456         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
2457         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
2458         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
2459         avoiding the ambiguity.
2460
2461         * WebView/WebActionMenuController.mm:
2462         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
2463
2464 2014-12-06  Anders Carlsson  <andersca@apple.com>
2465
2466         Add a stubbed out version of WebStorageNamespaceProvider
2467         https://bugs.webkit.org/show_bug.cgi?id=139213
2468
2469         Reviewed by Sam Weinig.
2470
2471         * WebCoreSupport/WebViewGroup.h:
2472         (WebViewGroup::storageNamespaceProvider):
2473         * WebCoreSupport/WebViewGroup.mm:
2474         (WebViewGroup::getOrCreate):
2475         (WebViewGroup::WebViewGroup):
2476         Give WebViewGroup a storage namespace provider.
2477
2478 2014-12-06  Anders Carlsson  <andersca@apple.com>
2479
2480         Fix build with newer versions of clang.
2481         rdar://problem/18978687
2482
2483         Add missing overrides and missing casts.
2484
2485         * Storage/WebDatabaseManagerClient.h:
2486         * Storage/WebStorageTrackerClient.h:
2487         * WebCoreSupport/WebChromeClient.h:
2488         * WebCoreSupport/WebFrameLoaderClient.h:
2489         * WebCoreSupport/WebInspectorClient.h:
2490         * WebView/WebDataSource.mm:
2491         (-[WebDataSource _makeRepresentation]):
2492         * WebView/WebFrameView.mm:
2493         (-[WebFrameView _makeDocumentViewForDataSource:]):
2494
2495 2014-12-05  Tim Horton  <timothy_horton@apple.com>
2496
2497         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
2498         https://bugs.webkit.org/show_bug.cgi?id=139306
2499         <rdar://problem/19157955>
2500
2501         Reviewed by Beth Dakin.
2502
2503         * WebView/WebView.mm:
2504         (-[WebView _commonInitializationWithFrameName:groupName:]):
2505         (-[WebView _initWithFrame:frameName:groupName:]):
2506         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
2507
2508 2014-12-05  David Kilzer  <ddkilzer@apple.com>
2509
2510         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
2511         <http://webkit.org/b/139286>
2512
2513         Reviewed by Daniel Bates.
2514
2515         * Configurations/FeatureDefines.xcconfig: Switch back to using
2516         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
2517
2518 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
2519
2520         Fix the 32-bit build.
2521
2522         * WebView/WebView.mm:
2523         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
2524
2525 2014-12-04  Tim Horton  <timothy_horton@apple.com>
2526
2527         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
2528         https://bugs.webkit.org/show_bug.cgi?id=139252
2529         <rdar://problem/19140827>
2530
2531         Reviewed by Anders Carlsson.
2532
2533         * WebView/WebView.mm:
2534         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
2535         Adjust to the WebCore changes.
2536
2537 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
2538
2539         Implement action menus for tel: URLs
2540         https://bugs.webkit.org/show_bug.cgi?id=139240
2541         <rdar://problem/19115662>
2542
2543         Reviewed by Anders Carlsson.
2544
2545         * WebView/WebActionMenuController.mm:
2546         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
2547         Make sure to use the newly created currentActionContext... everywhere.
2548
2549 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
2550
2551         Implement action menus for tel: URLs
2552         https://bugs.webkit.org/show_bug.cgi?id=139240
2553         <rdar://problem/19115662>
2554
2555         Reviewed by Anders Carlsson.
2556
2557         * WebView/WebActionMenuController.mm:
2558         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
2559         Make sure to use the newly created currentActionContext.
2560
2561 2014-12-03  Beth Dakin  <bdakin@apple.com>
2562
2563         <input> elements get whitespace action menu instead of editable text menu
2564         https://bugs.webkit.org/show_bug.cgi?id=139241
2565         -and corresponding-
2566         rdar://problem/19072083
2567
2568         Reviewed by Sam Weinig.
2569
2570         We should disallow shadow content in the hit test. This is the default and it is 
2571         how context menus behave. We originally wanted to text inside shadow content so 
2572         that we could find the text, but the new function I added to HitTestResult will 
2573         allow that.
2574         * WebView/WebActionMenuController.mm:
2575         (-[WebActionMenuController performHitTestAtPoint:]):
2576
2577         Adjust to the fact that we don’t hit test shadow content any more.
2578         (-[WebActionMenuController focusAndSelectHitTestResult]):
2579
2580         Offer the text menus for text inside form controls.
2581         (-[WebActionMenuController _defaultMenuItems]):
2582
2583 2014-12-03  Tim Horton  <timothy_horton@apple.com>
2584
2585         Implement action menus for tel: URLs
2586         https://bugs.webkit.org/show_bug.cgi?id=139240
2587         <rdar://problem/19115662>
2588
2589         Reviewed by Anders Carlsson.
2590
2591         * WebView/WebActionMenuController.mm:
2592         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
2593         Rename this function as it will work for both mailto and tel URLs.
2594         Adjust it to use contextForView:.
2595
2596         (-[WebActionMenuController webView:willHandleMouseDown:]):
2597         (-[WebActionMenuController prepareForMenu:withEvent:]):
2598         (-[WebActionMenuController didCloseMenu:withEvent:]):
2599         (-[WebActionMenuController _defaultMenuItems]):
2600         Don't check the menu type when going to interact with _currentActionContext.
2601         We'll only have a _currentActionContext if we have a data detected item,
2602         and there are multiple menu types that end up using DDActionContext.
2603
2604         * WebView/WebUIDelegatePrivate.h:
2605         Add a new type.
2606
2607 2014-12-03  Anders Carlsson  <andersca@apple.com>
2608
2609         Set a visited link store when creating a simple WebView
2610         https://bugs.webkit.org/show_bug.cgi?id=139234
2611         <rdar://problem/19132978>
2612
2613         Reviewed by Sam Weinig.
2614
2615         * WebView/WebView.mm:
2616         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2617
2618 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
2619
2620         Fix the build.
2621
2622         * WebCoreSupport/WebFrameLoaderClient.mm:
2623
2624 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
2625
2626         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
2627         https://bugs.webkit.org/show_bug.cgi?id=139149
2628
2629         Reviewed by Anders Carlsson.
2630
2631         This changes API behavior. I think that it's OK, because existing behavior made no sense.
2632         We used to delete caches from disk, but they were still active in memory. Now we also
2633         obsolete them in memory, so documents that use a cache still work, but new ones don't
2634         pick one up.
2635
2636         * WebCoreSupport/WebApplicationCache.mm:
2637         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
2638         need to delete in-momry caches too. Keep existing behavior.
2639         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
2640         that properly deletes caches.
2641
2642 2014-12-02  Tim Horton  <timothy_horton@apple.com>
2643
2644         Remove a SnowLeopard-era quirk for QuickLook
2645         https://bugs.webkit.org/show_bug.cgi?id=139208
2646         <rdar://problem/19121822>
2647
2648         Reviewed by Alexey Proskuryakov.
2649
2650         * WebCoreSupport/WebFrameLoaderClient.h:
2651         * WebCoreSupport/WebFrameLoaderClient.mm:
2652
2653 2014-12-02  Tim Horton  <timothy_horton@apple.com>
2654
2655         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
2656         https://bugs.webkit.org/show_bug.cgi?id=139204
2657
2658         Reviewed by Anders Carlsson.
2659
2660         * WebView/WebView.mm:
2661         (-[WebView _commonInitializationWithFrameName:groupName:]):
2662         (-[WebView _showDictionaryLookupPopup:]):
2663         * WebView/WebViewData.h:
2664         Work around this by delaying the softlinking (and setting up the notification
2665         observer) until we actually need it. There's still an underlying bug, but
2666         this will fix the test.
2667
2668 2014-12-02  Beth Dakin  <bdakin@apple.com>
2669
2670         Yet another build fix.
2671
2672         * WebView/WebActionMenuController.mm:
2673         (-[WebActionMenuController _defaultMenuItemsForLink]):
2674
2675 2014-12-02  Beth Dakin  <bdakin@apple.com>
2676
2677         Build fix.
2678
2679         * WebView/WebActionMenuController.mm:
2680         (-[WebActionMenuController _defaultMenuItemsForLink]):
2681
2682 2014-12-02  Beth Dakin  <bdakin@apple.com>
2683
2684         More build fixing.
2685
2686         * WebView/WebActionMenuController.mm:
2687         (-[WebActionMenuController _defaultMenuItemsForLink]):
2688
2689 2014-12-02  Beth Dakin  <bdakin@apple.com>
2690
2691         Should use standardQuickLookMenuItem for apps that don't implement customizations
2692         https://bugs.webkit.org/show_bug.cgi?id=139193
2693         -and corresponding-
2694         rdar://problem/18944696
2695
2696         Reviewed by Anders Carlsson.
2697
2698         Use [NSMenuItem standardQuickLookMenuItem].
2699         * WebView/WebActionMenuController.mm:
2700         (-[WebActionMenuController _defaultMenuItemsForLink]):
2701
2702         Delegate methods to set up the standardQuickLookMenuItem.
2703         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
2704         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
2705         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
2706
2707         Remove all of the old QLPreviewBubble code.
2708         (-[WebActionMenuController _createActionMenuItemForTag:]):
2709         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
2710
2711 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
2712
2713         Fix the build.
2714
2715         * WebView/WebViewData.h:
2716
2717 2014-12-02  Tim Horton  <timothy_horton@apple.com>
2718
2719         Implement Lookup transition from selection for Legacy WebKit
2720         https://bugs.webkit.org/show_bug.cgi?id=139180
2721         <rdar://problem/19067172>
2722
2723         Reviewed by Beth Dakin.
2724
2725         * WebView/DictionaryPopupInfo.h: Added.
2726         Split DictionaryPopupInfo out into its own file.
2727
2728         * WebView/WebActionMenuController.mm:
2729         (-[WebActionMenuController _lookupText:]):
2730         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
2731
2732         (performDictionaryLookupForSelection):
2733         (performDictionaryLookupForRange):
2734         Plumb the transition style through these helpers.
2735         Create a TextIndicator from the selection range.
2736
2737         * WebView/WebHTMLView.mm:
2738         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
2739         Make use of TextIndicator (and DictionaryPopupInfo, and the new
2740         _showDictionaryLookupPopup on WebView) to add a transition from blue
2741         when performing Lookup from the context menu.
2742
2743         (-[WebHTMLView quickLookWithEvent:]):
2744         Remove our TextIndicator whenever a normal three-finger-tap event
2745         comes through, as it will have its own indication.
2746
2747         * WebView/WebView.mm:
2748         (-[WebView _commonInitializationWithFrameName:groupName:]):
2749         (-[WebView _dictionaryLookupPopoverWillClose:]):
2750         Register for the LUNotificationPopoverWillClose notification and remove
2751         our TextIndicator when it is called, just like in WebKit2.
2752         Deregistration is already handled in _close.
2753
2754         (-[WebView _showDictionaryLookupPopup:]):
2755         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
2756         if the relevant API is available.
2757
2758         * WebView/WebViewInternal.h:
2759
2760 2014-12-02  Anders Carlsson  <andersca@apple.com>
2761
2762         Remove visited link handling from PageGroup
2763         https://bugs.webkit.org/show_bug.cgi?id=139185
2764
2765         Reviewed by Sam Weinig.
2766
2767         * History/WebHistory.mm:
2768         (-[WebHistoryPrivate removeItemForURLString:]):
2769         (-[WebHistoryPrivate removeAllItems]):
2770         (+[WebHistory setOptionalSharedHistory:]):
2771         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
2772         (+[WebHistory _removeAllVisitedLinks]):
2773         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
2774         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
2775         * History/WebHistoryInternal.h:
2776         * WebCoreSupport/WebChromeClient.h:
2777         * WebCoreSupport/WebChromeClient.mm:
2778         (WebChromeClient::populateVisitedLinks): Deleted.
2779         * WebView/WebView.mm:
2780         (-[WebView addVisitedLinks:]):
2781         (-[WebView removeVisitedLink:]):
2782
2783 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
2784
2785         Try to fix the Mac build.
2786
2787         * WebView/WebView.mm:
2788         (-[WebView _commonInitializationWithFrameName:groupName:]):
2789         (-[WebView _close]):
2790
2791 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
2792
2793         Fix the iOS build.
2794
2795         * WebView/WebActionMenuController.h:
2796         * WebView/WebActionMenuController.mm:
2797         * WebView/WebHTMLView.mm:
2798         (-[WebHTMLView scrollWheel:scrollWheel:]):
2799         (-[WebHTMLView mouseDown:mouseDown:]):
2800         * WebView/WebView.mm:
2801         * WebView/WebViewData.h:
2802         * WebView/WebViewData.mm:
2803         (-[WebViewPrivate dealloc]):
2804         * WebView/WebViewInternal.h:
2805
2806 2014-12-01  Tim Horton  <timothy_horton@apple.com>
2807
2808         Implement yellow highlight for WebKit1 data detectors
2809         https://bugs.webkit.org/show_bug.cgi?id=138956
2810         <rdar://problem/18992185>
2811
2812         Reviewed by Beth Dakin.
2813
2814         * WebView/WebActionMenuController.h:
2815         * WebView/WebActionMenuController.mm:
2816         (-[WebActionMenuController webView:willHandleMouseDown:]):
2817         (-[WebActionMenuController webView:didHandleScrollWheel:]):
2818         (-[WebActionMenuController prepareForMenu:withEvent:]):
2819         (-[WebActionMenuController didCloseMenu:withEvent:]):
2820         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2821         (-[WebActionMenuController _showTextIndicator]):
2822         (-[WebActionMenuController _hideTextIndicator]):
2823         (-[WebActionMenuController _dismissActionMenuPopovers]):
2824         Copy the WebKit2 WKActionMenuController TextIndicator implementation
2825         into WebActionMenuController. The only significant difference is
2826         that we build the TextIndicator right at menu construction time
2827         instead of in the Web process.
2828
2829         * WebView/WebHTMLView.mm:
2830         (-[WebHTMLView scrollWheel:]):
2831         Let the WebActionMenuController know that we're handling a scroll.
2832
2833         (-[WebHTMLView mouseDown:]):
2834         Let the WebActionMenuController know that we're handling a mouseDown.
2835
2836         * WebView/WebView.mm:
2837         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
2838         (-[WebView _clearTextIndicator]):
2839         (-[WebView _actionMenuController]):
2840         (-[WebView _convertRectFromRootView:]): Deleted.
2841         * WebView/WebViewData.h:
2842         * WebView/WebViewData.mm:
2843         * WebView/WebViewInternal.h:
2844         Keep a TextIndicatorWindow on WebView, just like WKView does.
2845         Expose the WebActionMenuController on WebView (internally).
2846
2847 2014-12-01  Anders Carlsson  <andersca@apple.com>
2848
2849         Remove old site specific quirks code that was added in 2009
2850         https://bugs.webkit.org/show_bug.cgi?id=139141
2851
2852         Reviewed by Antti Koivisto.
2853
2854         * WebCoreSupport/WebFrameNetworkingContext.h:
2855         * WebCoreSupport/WebFrameNetworkingContext.mm:
2856         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
2857
2858 2014-11-30  Anders Carlsson  <andersca@apple.com>
2859
2860         Fix a test failure.
2861
2862         * History/WebHistory.mm:
2863         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
2864         Call through to the visited link store.
2865
2866         (+[WebHistory _removeAllVisitedLinks]):
2867         Ditto.
2868
2869         * WebCoreSupport/WebVisitedLinkStore.mm:
2870         (WebVisitedLinkStore::isLinkVisited):
2871         Make sure to populate visited links.
2872
2873 2014-11-30  Anders Carlsson  <andersca@apple.com>
2874
2875         Switch over to the visited link store from the WebViewGroup
2876         https://bugs.webkit.org/show_bug.cgi?id=139112
2877
2878         Reviewed by Sam Weinig.
2879
2880         * WebView/WebView.mm:
2881         (-[WebView _commonInitializationWithFrameName:groupName:]):
2882         (-[WebView setGroupName:]):
2883
2884 2014-11-30  Anders Carlsson  <andersca@apple.com>
2885
2886         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
2887         https://bugs.webkit.org/show_bug.cgi?id=139111
2888
2889         Reviewed by Sam Weinig.
2890
2891         * WebCoreSupport/WebVisitedLinkStore.h:
2892         * WebCoreSupport/WebVisitedLinkStore.mm:
2893         (WebVisitedLinkStore::removeVisitedLink):
2894         * WebView/WebView.mm:
2895         (-[WebView removeVisitedLink:]):
2896
2897 2014-11-29  Anders Carlsson  <andersca@apple.com>
2898
2899         Populate visited links
2900         https://bugs.webkit.org/show_bug.cgi?id=139101
2901
2902         Reviewed by Sam Weinig.
2903
2904         * History/WebHistory.mm:
2905         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
2906         Helper function that adds all visited link to the given store.
2907
2908         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
2909         Call the private method.
2910
2911         * History/WebHistoryInternal.h:
2912         * WebCoreSupport/WebVisitedLinkStore.h:
2913         Add new members.
2914
2915         * WebCoreSupport/WebVisitedLinkStore.mm:
2916         (WebVisitedLinkStore::addVisitedLink):
2917         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
2918
2919         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
2920         Implement this. First try the delegate, then try the shared history.
2921
2922         (WebVisitedLinkStore::addVisitedLinkHash):
2923         Factor code that adds the link to the hash table into a separate function.
2924
2925         * WebView/WebView.mm:
2926         (-[WebView addVisitedLinks:]):
2927         Add the visited links to the store.
2928
2929 2014-11-29  Anders Carlsson  <andersca@apple.com>
2930
2931         More work on the legacy WebKit visited link store
2932         https://bugs.webkit.org/show_bug.cgi?id=139100
2933
2934         Reviewed by Sam Weinig.
2935
2936         * History/WebHistory.mm:
2937         (+[WebHistory setOptionalSharedHistory:]):
2938         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
2939
2940         * WebCoreSupport/WebVisitedLinkStore.h:
2941         * WebCoreSupport/WebVisitedLinkStore.mm:
2942         (visitedLinkStores):
2943         (WebVisitedLinkStore::WebVisitedLinkStore):
2944         (WebVisitedLinkStore::~WebVisitedLinkStore):
2945         Keep track of live visited link stores.
2946
2947         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
2948         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
2949
2950         (WebVisitedLinkStore::removeAllVisitedLinks):
2951         Iterate over all live link stores and remove their links.
2952
2953         (WebVisitedLinkStore::isLinkVisited):
2954         Populate visited links and check if our hash table contains the link.
2955
2956         (WebVisitedLinkStore::addVisitedLink):
2957         Add the link hash to the table.
2958
2959         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
2960         Add stub.
2961
2962         (WebVisitedLinkStore::removeVisitedLinkHashes):
2963         Clear out the hash table.
2964
2965 2014-11-27  Anders Carlsson  <andersca@apple.com>
2966
2967         Add a stubbed out WebVisitedLinkStore to WebViewGroup
2968         https://bugs.webkit.org/show_bug.cgi?id=139066
2969
2970         Reviewed by Antti Koivisto.
2971
2972         * WebCoreSupport/WebViewGroup.h:
2973         (WebViewGroup::visitedLinkStore):
2974         * WebCoreSupport/WebViewGroup.mm:
2975         (WebViewGroup::WebViewGroup):
2976         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
2977         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
2978         (WebVisitedLinkStore::create):
2979         (WebVisitedLinkStore::WebVisitedLinkStore):
2980         (WebVisitedLinkStore::~WebVisitedLinkStore):
2981         (WebVisitedLinkStore::isLinkVisited):
2982         (WebVisitedLinkStore::addVisitedLink):
2983
2984 2014-11-25  Anders Carlsson  <andersca@apple.com>
2985
2986         Remove user content handling from PageGroup
2987         https://bugs.webkit.org/show_bug.cgi?id=139051
2988
2989         Reviewed by Antti Koivisto.
2990
2991         Use the user content controller in the web view group.
2992
2993         * WebView/WebView.mm:
2994         (-[WebView _injectOutlookQuirksScript]):
2995
2996 2014-11-25  Anders Carlsson  <andersca@apple.com>
2997
2998         Add a user content controller to WebViewGroup and use it for user content
2999         https://bugs.webkit.org/show_bug.cgi?id=139043
3000
3001         Reviewed by Antti Koivisto.
3002
3003         This is another tiny step towards getting rid of user content handling inside PageGroup.
3004
3005         * WebCoreSupport/WebViewGroup.h:
3006         (WebViewGroup::userContentController):
3007         Add a UserContentController member and getter.
3008
3009         * WebCoreSupport/WebViewGroup.mm:
3010         (WebViewGroup::get):
3011         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
3012
3013         (WebViewGroup::WebViewGroup):
3014         Create a user content controller.
3015
3016         * WebView/WebView.mm:
3017         (-[WebView _commonInitializationWithFrameName:groupName:]):
3018         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
3019         set its user content controller in the PageConfiguration.
3020
3021         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3022         Ditto.
3023
3024         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
3025         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
3026         (+[WebView _removeUserScriptFromGroup:world:url:]):
3027         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
3028         (+[WebView _removeUserScriptsFromGroup:world:]):
3029         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
3030         (+[WebView _removeAllUserContentFromGroup:]):
3031         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
3032
3033         (-[WebView setGroupName:]):
3034         Set the user content controller to the new WebViewGroup's user content controller.
3035
3036 2014-11-21  Jer Noble  <jer.noble@apple.com>
3037
3038         Support multiple signatures of diagnostic logging.
3039         https://bugs.webkit.org/show_bug.cgi?id=138690
3040
3041         Reviewed by Anders Carlsson.
3042
3043         Page::PageClients has been renamed PageConfiguration.
3044
3045         * WebView/WebView.mm:
3046         (-[WebView _commonInitializationWithFrameName:groupName:]):
3047         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3048
3049 2014-11-21  Zalan Bujtas  <zalan@apple.com>
3050
3051         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
3052         https://bugs.webkit.org/show_bug.cgi?id=138981
3053
3054         Reviewed by Simon Fraser.
3055
3056         * WebView/WebPreferenceKeysPrivate.h:
3057         * WebView/WebPreferences.mm:
3058         (+[WebPreferences initialize]):
3059         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
3060         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
3061         * WebView/WebPreferencesPrivate.h:
3062         * WebView/WebView.mm:
3063         (-[WebView _preferencesChanged:]):
3064
3065 2014-11-21  Tim Horton  <timothy_horton@apple.com>
3066
3067         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
3068         ​https://bugs.webkit.org/show_bug.cgi?id=138960
3069         <rdar://problem/19056715>
3070
3071         Reviewed by Anders Carlsson.
3072
3073         * WebView/WebActionMenuController.mm:
3074         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
3075         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
3076         Use DataDetectors SPI instead of an explicit blacklist.
3077
3078 2014-11-21  Tim Horton  <timothy_horton@apple.com>
3079
3080         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
3081         https://bugs.webkit.org/show_bug.cgi?id=138960
3082         <rdar://problem/19056715>
3083
3084         Reviewed by Beth Dakin.
3085
3086         * WebView/WebActionMenuController.mm:
3087         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
3088         Blacklist contact results, because they don't have useful menus. If we
3089         bail before setting up _currentActionContext, we'll still allow fallthrough
3090         to ordinary text actions, avoiding mysterious failure when a contact is detected.
3091
3092         This doesn't break the case that r176351 was intended to fix,
3093         because in that case we were detecting e.g. addresses.
3094
3095 2014-11-21  Anders Carlsson  <andersca@apple.com>
3096
3097         Remove the Timer parameters from timer callbacks
3098         https://bugs.webkit.org/show_bug.cgi?id=138974
3099
3100         Reviewed by Antti Koivisto.
3101
3102         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3103         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3104         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
3105         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
3106         * Plugins/WebNetscapePluginStream.h:
3107         * Plugins/WebNetscapePluginStream.mm:
3108         (WebNetscapePluginStream::WebNetscapePluginStream):
3109         (WebNetscapePluginStream::deliverDataTimerFired):
3110
3111 2014-11-21  Anders Carlsson  <andersca@apple.com>
3112
3113         Make memoryCache() return a reference
3114         https://bugs.webkit.org/show_bug.cgi?id=138939
3115
3116         Reviewed by Antti Koivisto.
3117
3118         * Misc/WebCache.mm:
3119         (+[WebCache statistics]):
3120         (+[WebCache emptyInMemoryResources]):
3121         (+[WebCache sizeOfDeadResources:]):
3122         (+[WebCache addImageToCache:forURL:forFrame:]):
3123         (+[WebCache removeImageFromCacheForURL:forFrame:]):
3124         (+[WebCache imageForURL:]):
3125         (+[WebCache setDisabled:]):
3126         (+[WebCache isDisabled]):
3127         * WebView/WebView.mm:
3128         (+[WebView _setCacheModel:]):
3129
3130 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
3131
3132         Remove the remaining vestiges of minimal-ui
3133         https://bugs.webkit.org/show_bug.cgi?id=138890
3134
3135         Reviewed by Sam Weinig.
3136
3137         * History/WebHistoryItem.mm:
3138         * History/WebHistoryItemPrivate.h:
3139
3140 2014-11-20  Tim Horton  <timothy_horton@apple.com>
3141
3142         Cancel DataDetectors menu earlier if we know it can't be presented
3143         https://bugs.webkit.org/show_bug.cgi?id=138922
3144         <rdar://problem/18950441>
3145
3146         Reviewed by Beth Dakin.
3147
3148         * WebView/WebActionMenuController.mm:
3149         (-[WebActionMenuController prepareForMenu:withEvent:]):
3150         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
3151         and use a bigger hammer (removeAllItems).
3152
3153         (-[WebActionMenuController willOpenMenu:withEvent:]):
3154         If we end up with a menu with no items, don't change selection or anything.
3155
3156 2014-11-20  Beth Dakin  <bdakin@apple.com>
3157
3158         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
3159         https://bugs.webkit.org/show_bug.cgi?id=138568
3160         -and corresponding-
3161         rdar://problem/18904600
3162
3163         Reviewed by Tim Horton.
3164
3165         Skip images for lookup.
3166         * WebView/WebActionMenuController.mm:
3167         (performDictionaryLookupForRange):
3168
3169 2014-11-19  Beth Dakin  <bdakin@apple.com>
3170
3171         Invoking an action menu on a selection should result in the text menu
3172         https://bugs.webkit.org/show_bug.cgi?id=138892
3173         -and corresponding-
3174         rdar://problem/18996776
3175
3176         Reviewed by Tim Horton.
3177
3178         * WebView/WebActionMenuController.mm:
3179         (-[WebActionMenuController _defaultMenuItems]):
3180
3181 2014-11-19  Beth Dakin  <bdakin@apple.com>
3182
3183         Data detected results with no menu items should not fall through to regular text 
3184         action menus
3185         https://bugs.webkit.org/show_bug.cgi?id=138887
3186         -and corresponding-
3187         rdar://problem/18971616
3188
3189         Reviewed by Tim Horton.
3190
3191         * WebView/WebActionMenuController.mm:
3192         (-[WebActionMenuController _defaultMenuItems]):
3193
3194 2014-11-19  Daniel Bates  <dabates@apple.com>
3195
3196         [iOS] Make WebKit build with public iOS SDK
3197         https://bugs.webkit.org/show_bug.cgi?id=136863
3198
3199         Reviewed by David Kilzer.
3200
3201         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
3202         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
3203         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
3204         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
3205         may be used by Apple internal clients that do not include wtf/Platform.h.
3206         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
3207         private Foundation headers directly.
3208         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
3209         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
3210         instead of including private CFNetwork headers directly. Also fixed up style and
3211         ordering of header include directives.
3212         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
3213         CFNetwork headers directly. Also sort the #import directives.
3214         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
3215         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
3216
3217 2014-11-18  David Kilzer  <ddkilzer@apple.com>
3218
3219         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
3220         <http://webkit.org/b/138813>
3221
3222         Reviewed by Mark Rowe.
3223
3224         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
3225         selectors.
3226
3227 2014-11-18  Chris Dumez  <cdumez@apple.com>
3228
3229         Add a setting to toggle DOMTimer throttling support
3230         https://bugs.webkit.org/show_bug.cgi?id=138844
3231         <rdar://problem/19020874>
3232
3233         Reviewed by Andreas Kling.
3234
3235         Add a setting to disable DOM timers throttling, in order to help
3236         developers determine if a specific issue is caused by timer
3237         throttling.
3238
3239         * WebView/WebPreferenceKeysPrivate.h:
3240         * WebView/WebPreferences.mm:
3241         (+[WebPreferences initialize]):
3242         (-[WebPreferences domTimersThrottlingEnabled]):
3243         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
3244         * WebView/WebPreferencesPrivate.h:
3245         * WebView/WebView.mm:
3246         (-[WebView _preferencesChanged:]):
3247
3248 2014-11-18  Tim Horton  <timothy_horton@apple.com>
3249
3250         Avoid re-encoding action menu image data
3251         https://bugs.webkit.org/show_bug.cgi?id=138817
3252         <rdar://problem/18840382>
3253
3254         Reviewed by Anders Carlsson.
3255
3256         * WebView/WebActionMenuController.mm:
3257         (-[WebActionMenuController _defaultMenuItemsForImage:]):
3258         (-[WebActionMenuController _addImageToPhotos:]):
3259         Build a temporary filename from a UUID and the image's desired extension.
3260         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
3261         Build an image menu only if we have an image, URL, data, and extension.
3262
3263 2014-11-18  Daniel Bates  <dabates@apple.com>
3264
3265         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
3266         SPI are not available in public SDK
3267         https://bugs.webkit.org/show_bug.cgi?id=138802
3268
3269         Reviewed by David Kilzer.
3270
3271         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
3272         libdispatch and MobileGestalt headers directly.
3273
3274         * WebView/WebView.mm:
3275
3276 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
3277
3278         Remove calls to deprecated NSMenu methods
3279         https://bugs.webkit.org/show_bug.cgi?id=138808.
3280
3281         Reviewed by Anders Carlsson.
3282
3283         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
3284
3285         * WebCoreSupport/PopupMenuMac.mm:
3286         (PopupMenuMac::populate):
3287
3288 2014-11-17  Daniel Bates  <dabates@apple.com>
3289
3290         Unreviewed, rolling out r176232.
3291
3292         Broke the Mac build. Will investigate offline.
3293
3294         Reverted changeset:
3295
3296         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
3297         MobileGestalt"
3298         https://bugs.webkit.org/show_bug.cgi?id=138802
3299         http://trac.webkit.org/changeset/176232
3300
3301 2014-11-17  Daniel Bates  <dabates@apple.com>
3302
3303         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
3304         SPI are not available in public SDK
3305         https://bugs.webkit.org/show_bug.cgi?id=138802
3306
3307         Reviewed by David Kilzer.
3308
3309         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
3310         libdispatch and MobileGestalt headers directly.
3311
3312         * WebView/WebView.mm:
3313
3314 2014-11-17  Beth Dakin  <bdakin@apple.com>
3315
3316         Whitespace action menus should focus the HitTestResult and create an insertion 
3317         point
3318         https://bugs.webkit.org/show_bug.cgi?id=138786
3319         -and corresponding-
3320         rdar://problem/18944893
3321
3322         Reviewed by Tim Horton.
3323
3324         Whitespace menus should cause the HitTestResult to be focused, and they should set 
3325         the selection based on the HitTest location.
3326
3327         * WebView/WebActionMenuController.mm:
3328         (-[WebActionMenuController isMenuForTextContent]):
3329         (-[WebActionMenuController focusAndSelectHitTestResult]):
3330         (-[WebActionMenuController willOpenMenu:withEvent:]):
3331
3332 2014-11-17  Daniel Bates  <dabates@apple.com>
3333
3334         [iOS] QuartzCore SPI not available in public SDK
3335         https://bugs.webkit.org/show_bug.cgi?id=138751
3336
3337         Reviewed by David Kilzer.
3338
3339         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
3340
3341         * WebInspector/WebNodeHighlight.mm:
3342         * WebView/WebIndicateLayer.mm:
3343
3344 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
3345
3346         [iOS] allow host application to opt-out of alternate fullscreen
3347         https://bugs.webkit.org/show_bug.cgi?id=138787
3348
3349         Reviewed by Darin Adler.
3350
3351         * WebView/WebPreferenceKeysPrivate.h:
3352         * WebView/WebPreferences.mm:
3353         (+[WebPreferences initialize]):
3354         (-[WebPreferences allowsAlternateFullscreen]):
3355         (-[WebPreferences setAllowsAlternateFullscreen:]):
3356         * WebView/WebPreferencesPrivate.h:
3357         * WebView/WebView.mm:
3358         (-[WebView _preferencesChanged:]):
3359
3360 2014-11-16  Tim Horton  <timothy_horton@apple.com>
3361
3362         Use TextIndicator instead of the built in Lookup highlight
3363         https://bugs.webkit.org/show_bug.cgi?id=138775
3364         <rdar://problem/18953982>
3365
3366         Reviewed by Anders Carlsson.
3367
3368         * WebCoreSupport/WebSystemInterface.mm:
3369         (InitWebCoreSystemInterface):
3370         Remove a WKSI import.
3371
3372         * WebView/WebActionMenuController.mm:
3373         (-[WebActionMenuController _lookupText:]):
3374         (-[WebActionMenuController _createActionMenuItemForTag:]):
3375         Make use of the new Lookup SPI header.
3376         Disable the Lookup item if lookup is not available.
3377
3378 2014-11-15  Tim Horton  <timothy_horton@apple.com>
3379
3380         Implement data detectors and mailto action menus for WebKit1
3381         https://bugs.webkit.org/show_bug.cgi?id=138765
3382         <rdar://problem/18877535>
3383
3384         Reviewed by Beth Dakin.
3385
3386         * WebView/WebActionMenuController.h:
3387         * WebView/WebActionMenuController.mm:
3388         (-[WebActionMenuController willOpenMenu:withEvent:]):
3389         Tell DataDetectors that the menu is going to open.
3390         Select the text (or not) based on the number of items in the menu, just like WebKit2.
3391
3392         (-[WebActionMenuController didCloseMenu:withEvent:]):
3393         Tell DataDetectors that the menu closed.
3394
3395         (-[WebActionMenuController _defaultMenuItemsForLink]):
3396         Move these checks out of _defaultMenuItemsForLink, because we expect this
3397         to always return a complete link menu.
3398
3399         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
3400         Implement. More or less copied from WebKit2.
3401
3402         (-[WebActionMenuController _selectDataDetectedText]):
3403         Select the stashed range.
3404
3405         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
3406         Implement. More or less copied from WebKit2.
3407         The yellow highlight isn't hooked up yet.
3408         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
3409
3410         (-[WebActionMenuController _selectLookupText]):
3411         Remove an unnecessary return.
3412
3413         (-[WebActionMenuController _defaultMenuItems]):
3414         Call into the two new menu types.
3415
3416         * WebView/WebUIDelegatePrivate.h:
3417
3418 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
3419
3420         Get rid of WebFontCache
3421         https://bugs.webkit.org/show_bug.cgi?id=134752
3422
3423         Reviewed by Dave Hyatt.
3424
3425         * WebView/WebHTMLView.mm:
3426
3427 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
3428
3429         Update some artwork for the legacy WebKit action menu
3430         https://bugs.webkit.org/show_bug.cgi?id=138758
3431         <rdar://problem/18989840>
3432
3433         * WebView/WebActionMenuController.mm:
3434         (webKitBundleImageNamed): Deleted.
3435         Fix the build.
3436
3437 2014-11-14  Tim Horton  <timothy_horton@apple.com>
3438
3439         Update some artwork for the legacy WebKit action menu
3440         https://bugs.webkit.org/show_bug.cgi?id=138758
3441         <rdar://problem/18989840>
3442
3443         Reviewed by Simon Fraser.
3444
3445         * WebView/WebActionMenuController.mm:
3446         (-[WebActionMenuController _createActionMenuItemForTag:]):
3447
3448 2014-11-14  Daniel Bates  <dabates@apple.com>
3449
3450         [iOS] NSFileManager and QuickLook SPI not available in public SDK
3451         https://bugs.webkit.org/show_bug.cgi?id=138742
3452
3453         Reviewed by Pratik Solanki.
3454
3455         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
3456
3457         * WebCoreSupport/WebFrameLoaderClient.mm:
3458
3459 2014-11-14  Beth Dakin  <bdakin@apple.com>
3460
3461         WK1: Webpage preview can come up in wrong location
3462         https://bugs.webkit.org/show_bug.cgi?id=138747
3463         -and corresponding-
3464         rdar://problem/18979004
3465
3466         Reviewed by Tim Horton.
3467
3468         Converting to window twice is bad.
3469         * WebView/WebActionMenuController.mm:
3470         (elementBoundingBoxInWindowCoordinatesFromNode):
3471         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
3472         (elementBoundingBoxFromNode): Deleted.
3473
3474 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
3475
3476         Move FontMac and FontCacheMac off of WKSI
3477         https://bugs.webkit.org/show_bug.cgi?id=138633
3478
3479         Reviewed by Simon Fraser.
3480
3481         * WebCoreSupport/WebSystemInterface.mm:
3482         (InitWebCoreSystemInterface):
3483         * WebKit.order:
3484
3485 2014-11-13  Beth Dakin  <bdakin@apple.com>
3486
3487         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
3488         https://bugs.webkit.org/show_bug.cgi?id=138716
3489         -and corresponding-
3490         rdar://problem/18977222
3491
3492         Reviewed by Tim Horton.
3493
3494         It’s not necessary to use the WebElementDictionary for so many things now that we 
3495         are caching the HitTestResult. We should just use the HitTestResult.
3496
3497         * WebView/WebActionMenuController.mm:
3498         (-[WebActionMenuController prepareForMenu:withEvent:]):
3499         (-[WebActionMenuController _openURLFromActionMenu:]):
3500         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
3501         (elementBoundingBoxFromNode):
3502         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
3503         (-[WebActionMenuController _defaultMenuItemsForLink]):
3504         (-[WebActionMenuController _defaultMenuItemsForImage]):
3505         (-[WebActionMenuController _defaultMenuItemsForVideo]):
3506         (-[WebActionMenuController _defaultMenuItemsForText]):
3507         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
3508         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
3509         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
3510         (-[WebActionMenuController _createActionMenuItemForTag:]):
3511         (-[WebActionMenuController _defaultMenuItems]):
3512         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
3513         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
3514         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
3515         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
3516         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
3517         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
3518         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
3519         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
3520         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
3521         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
3522
3523 2014-11-13  Daniel Bates  <dabates@apple.com>
3524
3525         [iOS] NSGeometry data types are not available in the public SDK
3526         https://bugs.webkit.org/show_bug.cgi?id=137536
3527
3528         Reviewed by David Kilzer.
3529
3530         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
3531         private header.
3532
3533         * DOM/WebDOMOperationsPrivate.h:
3534
3535 2014-11-13  Beth Dakin  <bdakin@apple.com>
3536
3537         WK1: Support default actions for video
3538         https://bugs.webkit.org/show_bug.cgi?id=138713
3539         -and corresponding-
3540         rdar://problem/18877520
3541
3542         Reviewed by Tim Horton.
3543
3544         Call setToNonShadowAncestor() for media HitTestResults.
3545         * WebView/WebActionMenuController.mm:
3546         (-[WebActionMenuController performHitTestAtPoint:]):
3547
3548         Default items and actions.
3549         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
3550         (-[WebActionMenuController _copyVideoURL:]):
3551         (-[WebActionMenuController _saveVideoToDownloads:]):
3552         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3553         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3554         * WebView/WebUIDelegatePrivate.h:
3555
3556 2014-11-13  Tim Horton  <timothy_horton@apple.com>
3557
3558         WK1: Update icon for Add to Reading List
3559         https://bugs.webkit.org/show_bug.cgi?id=138710
3560         <rdar://problem/18975774>
3561
3562         Reviewed by Beth Dakin.
3563
3564         * WebView/WebActionMenuController.mm:
3565         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3566         Use the right icon, matching WebKit2.
3567
3568 2014-11-12  Beth Dakin  <bdakin@apple.com>
3569
3570         WK1: Support default actions for images
3571         https://bugs.webkit.org/show_bug.cgi?id=138668
3572         -and corresponding-
3573         rdar://problem/18785434
3574
3575         Reviewed by Tim Horton.
3576
3577       &n