22a7f393f03b0c1f8739f73fd6b7ec7a622feee2
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2015-01-12  Anders Carlsson  <andersca@apple.com>
2
3         Make WebResourceDelegate a formal protocol as well
4         https://bugs.webkit.org/show_bug.cgi?id=140364
5
6         Reviewed by Dan Bernstein.
7
8         * WebView/WebResourceLoadDelegate.h:
9
10 2015-01-12  Anders Carlsson  <andersca@apple.com>
11
12         Delegates should be formal protocols
13         https://bugs.webkit.org/show_bug.cgi?id=140360
14         rdar://problem/17380856
15
16         Reviewed by Dan Bernstein.
17
18         This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
19
20         * DefaultDelegates/WebDefaultUIDelegate.h:
21         * Misc/WebDownload.h:
22         * WebView/WebEditingDelegate.h:
23         * WebView/WebFrameLoadDelegate.h:
24         * WebView/WebPolicyDelegate.h:
25         * WebView/WebUIDelegate.h:
26
27 2015-01-09  Anders Carlsson  <andersca@apple.com>
28
29         Get rid of the database strategy
30         https://bugs.webkit.org/show_bug.cgi?id=140322
31
32         Reviewed by Sam Weinig.
33
34         * WebCoreSupport/WebPlatformStrategies.h:
35         * WebCoreSupport/WebPlatformStrategies.mm:
36         (WebPlatformStrategies::createDatabaseStrategy): Deleted.
37
38 2015-01-08  Timothy Horton  <timothy_horton@apple.com>
39
40         Can't use DataDetectors after immediate action preparation
41         https://bugs.webkit.org/show_bug.cgi?id=140263
42         <rdar://problem/19412705>
43
44         Reviewed by Beth Dakin.
45
46         * WebView/WebImmediateActionController.mm:
47         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
48         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
49         To match WebKit2, only call shouldUseActions if the animation is actually
50         going to begin, not when preparing for it. This way, we're guaranteed
51         to get a didCancel or didComplete.
52
53 2015-01-08  Dean Jackson  <dino@apple.com>
54
55         Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
56         https://bugs.webkit.org/show_bug.cgi?id=140232
57         <rdar://problem/19371010>
58
59         Reviewed by Anders Carlsson.
60
61         Remove the applicationChromeMode setting, but leave stubs in to make
62         sure existing binaries don't break.
63
64         * WebCoreSupport/WebInspectorClient.mm:
65         (-[WebInspectorWindowController init]):
66         * WebView/WebPreferenceKeysPrivate.h:
67         * WebView/WebPreferences.mm:
68         (+[WebPreferences initialize]):
69         (-[WebPreferences applicationChromeModeEnabled]):
70         (-[WebPreferences setApplicationChromeModeEnabled:]):
71         * WebView/WebView.mm:
72         (-[WebView _preferencesChanged:]):
73
74 2015-01-07  Daniel Bates  <dabates@apple.com>
75
76         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
77         https://bugs.webkit.org/show_bug.cgi?id=137371
78
79         Reviewed by David Kilzer.
80
81         Use SPI wrapper headers instead of directly references private SPI headers.
82
83         * Plugins/Hosted/NetscapePluginHostManager.mm:
84
85 2015-01-07  Commit Queue  <commit-queue@webkit.org>
86
87         Unreviewed, rolling out r178068.
88         https://bugs.webkit.org/show_bug.cgi?id=140235
89
90         Breaks the iOS build (Requested by enrica on #webkit).
91
92         Reverted changeset:
93
94         "[iOS] Make WebKit2 build with public iOS SDK and more build
95         fixes for DRT"
96         https://bugs.webkit.org/show_bug.cgi?id=137371
97         http://trac.webkit.org/changeset/178068
98
99 2015-01-07  Daniel Bates  <dabates@apple.com>
100
101         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
102         https://bugs.webkit.org/show_bug.cgi?id=137371
103
104         Reviewed by David Kilzer.
105
106         Use SPI wrapper headers instead of directly references private SPI headers.
107
108         * Plugins/Hosted/NetscapePluginHostManager.mm:
109
110 2015-01-07  Beth Dakin  <bdakin@apple.com>
111
112         Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the 
113         link
114         https://bugs.webkit.org/show_bug.cgi?id=140206
115         -and corresponding-
116         rdar://problem/19300492
117
118         Reviewed by Tim Horton.
119
120         Providing and item frame will ensure that the original link is not obscured.
121         * WebView/WebImmediateActionController.mm:
122         (elementBoundingBoxInWindowCoordinatesFromNode):
123         (-[WebImmediateActionController menuItem:itemFrameForPoint:]):
124
125         For now use a max size that is smaller than the WebView, with the screen’s aspect 
126         ratio, and scaled down.
127         (-[WebImmediateActionController menuItem:maxSizeForPoint:]):
128
129 2015-01-07  Anders Carlsson  <andersca@apple.com>
130
131         Give simple HTML documents a database provider
132         https://bugs.webkit.org/show_bug.cgi?id=140192
133         rdar://problem/19398825
134
135         Reviewed by Tim Horton.
136
137         * WebView/WebView.mm:
138         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
139
140 2015-01-06  Anders Carlsson  <andersca@apple.com>
141
142         Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
143         https://bugs.webkit.org/show_bug.cgi?id=140140
144
145         Reviewed by Andreas Kling.
146
147         Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler
148         out of WebCore since nobody else is using it.
149
150         * Plugins/WebNetscapePluginView.h:
151         * Plugins/WebNetscapePluginView.mm:
152         (-[WebNetscapePluginView _createPlugin]):
153         (-[WebNetscapePluginView _destroyPlugin]):
154         * Plugins/npapi.mm:
155         (NPN_PluginThreadAsyncCall):
156
157 2015-01-06  Anders Carlsson  <andersca@apple.com>
158
159         Add a WebKit1 database provider
160         https://bugs.webkit.org/show_bug.cgi?id=140126
161
162         Reviewed by Sam Weinig.
163
164         Set the database provider.
165
166         * WebView/WebView.mm:
167         (-[WebView _commonInitializationWithFrameName:groupName:]):
168
169 2015-01-06  Commit Queue  <commit-queue@webkit.org>
170
171         Unreviewed, rolling out r177963.
172         https://bugs.webkit.org/show_bug.cgi?id=140136
173
174         Caused lots of crashes (Requested by smfr on #webkit).
175
176         Reverted changeset:
177
178         "Add a WebKit1 database provider"
179         https://bugs.webkit.org/show_bug.cgi?id=140126
180         http://trac.webkit.org/changeset/177963
181
182 2015-01-06  Anders Carlsson  <andersca@apple.com>
183
184         Add a WebKit1 database provider
185         https://bugs.webkit.org/show_bug.cgi?id=140126
186
187         Reviewed by Sam Weinig.
188
189         Set the database provider.
190
191         * WebView/WebView.mm:
192         (-[WebView _commonInitializationWithFrameName:groupName:]):
193
194 2015-01-01  Jeff Miller  <jeffm@apple.com>
195
196         Update user-visible copyright strings to include 2015
197         https://bugs.webkit.org/show_bug.cgi?id=139880
198
199         Reviewed by Darin Adler.
200
201         * Info.plist:
202
203 2014-12-30  Dan Bernstein  <mitz@apple.com>
204
205         [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
206         https://bugs.webkit.org/show_bug.cgi?id=140003
207
208         Reviewed by Darin Adler.
209
210         * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
211         that takes their "string" parameter as a "value" "parameter and has an attribute telling
212         the compiler that if the "value" parameter is a format string then the function returns a
213         modified version of it. The result is that if UI_STRING is used as a format string parameter
214         to some function or method, the compiler will check the format specifiers in the string
215         against the other parameters.
216
217 2014-12-29  Dan Bernstein  <mitz@apple.com>
218
219         Fixed the iOS build.
220
221         * Configurations/WebKitLegacy.xcconfig:
222
223 2014-12-29  Anders Carlsson  <andersca@apple.com>
224
225         Get rid of some PageGroup storage functions
226         https://bugs.webkit.org/show_bug.cgi?id=139996
227
228         Reviewed by Sam Weinig.
229
230         Call WebStorageNamespaceProvider directly instead.
231
232         * Storage/WebStorageManager.mm:
233         (-[WebStorageManager syncLocalStorage]):
234         (+[WebStorageManager closeIdleLocalStorageDatabases]):
235         * WebView/WebView.mm:
236         (+[WebView _applicationWillTerminate]):
237
238 2014-12-29  Anders Carlsson  <andersca@apple.com>
239
240         Move storage code from WebCore to WebKit
241         https://bugs.webkit.org/show_bug.cgi?id=139558
242
243         Reviewed by Darin Adler.
244
245         * Storage/WebStorageManager.mm:
246         * Storage/WebStorageTrackerClient.h:
247         * WebView/WebView.mm:
248
249 2014-12-26  Dan Bernstein  <mitz@apple.com>
250
251         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
252         https://bugs.webkit.org/show_bug.cgi?id=139950
253
254         Reviewed by David Kilzer.
255
256         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
257         in a manner that works with Xcode 5.1.1.
258
259 2014-12-23  Timothy Horton  <timothy_horton@apple.com>
260
261         Install a TextIndicator for link immediate actions
262         https://bugs.webkit.org/show_bug.cgi?id=139897
263         <rdar://problem/19333076>
264
265         Reviewed by Anders Carlsson.
266
267         * WebView/WebImmediateActionController.h:
268         * WebView/WebImmediateActionController.mm:
269         (-[WebImmediateActionController _clearImmediateActionState]):
270         Tear down the TextIndicator, just like WebKit2.
271
272         (-[WebImmediateActionController _defaultAnimationController]):
273         Install a TextIndicator for links.
274
275         (-[WebImmediateActionController menuItemDidClose:]):
276         Tear down the TextIndicator when the QL preview closes.
277
278         (-[WebImmediateActionController _menuItemForDataDetectedText]):
279         Directly install and uninstall the TextIndicator for DataDetectors.
280
281         (-[WebImmediateActionController _showTextIndicator]): Deleted.
282         (-[WebImmediateActionController _hideTextIndicator]): Deleted.
283         Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
284
285 2014-12-20  Eric Carlson  <eric.carlson@apple.com>
286
287         [iOS] add optimized fullscreen API
288         https://bugs.webkit.org/show_bug.cgi?id=139833
289         <rdar://problem/18844486>
290
291         Reviewed by Simon Fraser.
292
293         * Configurations/FeatureDefines.xcconfig:  Add ENABLE_VIDEO_PRESENTATION_MODE.
294
295 2014-12-20  David Kilzer  <ddkilzer@apple.com>
296
297         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
298         <http://webkit.org/b/139463>
299
300         Reviewed by Mark Rowe.
301
302         * Configurations/Base.xcconfig:
303         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
304           on OS X.
305         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
306         * Configurations/DebugRelease.xcconfig:
307         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
308         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
309         * Configurations/Version.xcconfig:
310         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
311         * Configurations/WebKitLegacy.xcconfig:
312         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
313           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
314           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
315           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
316           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
317           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
318           WEBCORE_PRIVATE_HEADERS_DIR_Production and
319           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
320           based on SDK.
321         - Fix PRODUCTION_ROOT to actually be set properly.
322         - Simplify EXPORTED_SYMBOLS_FILE_i386.
323
324         * migrate-headers.sh:
325         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
326         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
327           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
328           WebKitLegacy.xcconfig.
329
330 2014-12-19  Simon Fraser  <simon.fraser@apple.com>
331
332         Fix pink background on CoreAnimation plug-ins in WebKit1
333         https://bugs.webkit.org/show_bug.cgi?id=139845
334         rdar://problem/19313075
335
336         Reviewed by Tim Horton.
337         
338         r154078 left in some debugging code that set a pink background on plug-in hosting
339         layers. Remove it.
340
341         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
342         (-[WebHostedNetscapePluginView createPluginLayer]):
343
344 2014-12-19  Andreas Kling  <akling@apple.com>
345
346         Ref-ify TextIterator API.
347         <https://webkit.org/b/139823>
348
349         Reviewed by Antti Koivisto.
350
351         * WebView/WebTextIterator.mm:
352         (-[WebTextIterator currentRange]):
353
354 2014-12-19  Joseph Pecoraro  <pecoraro@apple.com>
355
356         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
357         https://bugs.webkit.org/show_bug.cgi?id=139797
358
359         Reviewed by Mark Lam.
360
361         * WebView/WebScriptDebugger.h:
362         * WebView/WebScriptDebugger.mm:
363         (WebScriptDebugger::handlePause):
364         Standardize on passing JSGlobalObject parameter first.
365
366 2014-12-19  Commit Queue  <commit-queue@webkit.org>
367
368         Unreviewed, rolling out r177574.
369         https://bugs.webkit.org/show_bug.cgi?id=139821
370
371         "Broke Production builds by installing
372         libWebCoreTestSupport.dylib in the wrong directory" (Requested
373         by ddkilzer on #webkit).
374
375         Reverted changeset:
376
377         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
378         WebInspectorUI, WebKit, WebKit2"
379         https://bugs.webkit.org/show_bug.cgi?id=139463
380         http://trac.webkit.org/changeset/177574
381
382 2014-12-19  David Kilzer  <ddkilzer@apple.com>
383
384         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
385         <http://webkit.org/b/139463>
386
387         Reviewed by Mark Rowe.
388
389         * Configurations/Base.xcconfig:
390         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
391           on OS X.
392         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
393         * Configurations/DebugRelease.xcconfig:
394         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
395         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
396         * Configurations/Version.xcconfig:
397         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
398         * Configurations/WebKitLegacy.xcconfig:
399         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
400           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
401           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
402           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
403           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
404           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
405           WEBCORE_PRIVATE_HEADERS_DIR_Production and
406           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
407           based on SDK.
408         - Fix PRODUCTION_ROOT to actually be set properly.
409         - Simplify EXPORTED_SYMBOLS_FILE_i386.
410
411         * migrate-headers.sh:
412         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
413         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
414           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
415           WebKitLegacy.xcconfig.
416
417 2014-12-18  Andreas Kling  <akling@apple.com>
418
419         Ref-ify various Document-related things.
420         <https://webkit.org/b/139796>
421
422         Reviewed by Anders Carlsson.
423
424         * WebView/WebFrame.mm:
425         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
426
427 2014-12-18  Beth Dakin  <bdakin@apple.com>
428
429         Need to re-enable action menus
430         https://bugs.webkit.org/show_bug.cgi?id=139795
431         -and corresponding-
432         rdar://problem/19299367
433
434         Reviewed by Tim Horton.
435
436         Re-enable the menus by un-commenting the code to create the menu and controller.
437         * WebView/WebView.mm:
438         (-[WebView _commonInitializationWithFrameName:groupName:]):
439
440 2014-12-16  Sam Weinig  <sam@webkit.org>
441
442         Unify the Mac and iOS implementations of FontPlatformData a bit
443         https://bugs.webkit.org/show_bug.cgi?id=139721
444
445         Reviewed by Anders Carlsson.
446
447         * WebView/WebHTMLView.mm:
448         (fontNameForDescription):
449         Update for new function name.
450
451 2014-12-18  Antti Koivisto  <antti@apple.com>
452
453         Remove alwaysUseBaselineOfPrimaryFont setting
454         https://bugs.webkit.org/show_bug.cgi?id=139770
455
456         Reviewed by Anders Carlsson.
457
458         * WebView/WebPreferenceKeysPrivate.h:
459         * WebView/WebPreferences.mm:
460         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
461         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
462         * WebView/WebPreferencesPrivate.h:
463         * WebView/WebView.mm:
464         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
465         (-[WebView _preferencesChanged:]):
466
467 2014-12-17  Andreas Kling  <akling@apple.com>
468
469         Ref-ify Range::create().
470         <https://webkit.org/b/139755>
471
472         Reviewed by Anders Carlsson.
473
474         * WebView/WebHTMLRepresentation.mm:
475         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
476         * WebView/WebHTMLView.mm:
477         (-[WebHTMLView attributedString]):
478
479 2014-12-17  Anders Carlsson  <andersca@apple.com>
480
481         Unify -[WebResource description]
482         https://bugs.webkit.org/show_bug.cgi?id=139762
483
484         Reviewed by Dan Bernstein.
485
486         * WebView/WebResource.mm:
487         (-[WebResource description]):
488
489 2014-12-17  Anders Carlsson  <andersca@apple.com>
490
491         Get rid of an ugly #define hack in WebFrameLoaderClient
492         https://bugs.webkit.org/show_bug.cgi?id=139761
493
494         Reviewed by Dan Bernstein.
495
496         Also replace @private with @package in all public headers, for consistency.
497
498         * History/WebBackForwardList.h:
499         * History/WebHistory.h:
500         * Misc/WebDownload.h:
501         * WebCoreSupport/WebFrameLoaderClient.mm:
502         * WebView/WebArchive.h:
503         * WebView/WebDataSource.h:
504         * WebView/WebFrame.h:
505         * WebView/WebFrameView.h:
506         * WebView/WebPreferences.h:
507         * WebView/WebResource.h:
508
509 2014-12-17  Dan Bernstein  <mitz@apple.com>
510
511         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
512         https://bugs.webkit.org/show_bug.cgi?id=139760
513
514         Reviewed by Anders Carlsson.
515
516         * Configurations/WebKitLegacy.xcconfig:
517
518 2014-12-17  Andreas Kling  <akling@apple.com>
519
520         Purge PassRefPtr from Frame.
521         <https://webkit.org/b/139731>
522
523         Reviewed by Anders Carlsson.
524
525         * WebCoreSupport/WebFrameLoaderClient.mm:
526         (WebFrameLoaderClient::transitionToCommittedForNewPage):
527         * WebView/WebFrame.mm:
528         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
529         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
530         * WebView/WebFrameInternal.h:
531
532 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
533
534         Implement and adopt two new TextIndicator presentation animations
535         https://bugs.webkit.org/show_bug.cgi?id=139715
536         <rdar://problem/19237945>
537
538         Reviewed by Anders Carlsson.
539
540         * WebView/WebActionMenuController.mm:
541         (-[WebActionMenuController _showTextIndicator]):
542         * WebView/WebHTMLView.mm:
543         (-[WebHTMLView quickLookWithEvent:]):
544         Remove the completionHandler from text indicator presentation.
545
546         * WebView/WebImmediateActionController.mm:
547         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
548         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
549         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
550         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
551         (-[WebImmediateActionController _menuItemForDataDetectedText]):
552         (-[WebImmediateActionController _animationControllerForText]):
553         (-[WebImmediateActionController _showTextIndicator]):
554         Forward immediate action gesture recognizer animation progress
555         to TextIndicator. Force us to keep the selection when immediate
556         action popovers steal first responder status from the WebView.
557         If the Lookup range is equal to the selection range, use a Crossfade
558         animation; otherwise, use a FadeIn animation.
559
560         * WebView/WebView.mm:
561         (-[WebView _setMaintainsInactiveSelection:]):
562         (-[WebView maintainsInactiveSelection]):
563         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
564         (-[WebView _setTextIndicator:fadeOut:]):
565         (-[WebView _clearTextIndicator]):
566         (-[WebView _setTextIndicatorAnimationProgress:]):
567         (-[WebView _showDictionaryLookupPopup:]):
568         (-[WebView _dictionaryLookupPopoverWillClose:]):
569         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
570         Remove the completionHandler from text indicator presentation.
571         Add a _setMaintainsInactiveSelection, which allows WebKit internals
572         to change the return value of -maintainsInactiveSelection, allowing
573         us to keep the selection alive when the WebView loses first responder status.
574
575         * WebView/WebViewData.h:
576         * WebView/WebViewInternal.h:
577
578 2014-12-16  Andreas Kling  <akling@apple.com>
579
580         Use Ref for SecurityOrigin.
581         <https://webkit.org/b/139710>
582
583         Reviewed by Anders Carlsson.
584
585         * Storage/WebStorageTrackerClient.mm:
586         (WebStorageTrackerClient::dispatchDidModifyOrigin):
587         * WebView/WebView.mm:
588         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
589         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
590
591 2014-12-16  Beth Dakin  <bdakin@apple.com>
592
593         Crash getting default animation controller for some text
594         https://bugs.webkit.org/show_bug.cgi?id=139712
595         -and corresponding-
596         rdar://problem/19271707
597
598         Reviewed by Tim Horton.
599
600         Must null-check the range.
601         * WebView/WebImmediateActionController.mm:
602         (-[WebImmediateActionController _animationControllerForText]):
603
604 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
605
606         Immediate action popovers can get stuck open
607         https://bugs.webkit.org/show_bug.cgi?id=139709
608         <rdar://problem/19270279>
609
610         Reviewed by Beth Dakin.
611
612         * WebView/WebImmediateActionController.mm:
613         (-[WebImmediateActionController _clearImmediateActionState]):
614         Don't clear the animation controller; it breaks things and was unnecessary.
615
616 2014-12-16  Tim Horton  <timothy_horton@apple.com>
617
618         Disable TextIndication for Lookup immediate actions
619         https://bugs.webkit.org/show_bug.cgi?id=139684
620
621         Reviewed by Anders Carlsson.
622
623         * WebView/WebView.mm:
624         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
625
626 2014-12-15  Beth Dakin  <bdakin@apple.com>
627
628         Build fix.
629
630         * WebView/WebImmediateActionController.mm:
631
632 2014-12-15  Beth Dakin  <bdakin@apple.com>
633
634         Speculative build fix.
635
636         * WebView/WebView.mm:
637         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
638         * WebView/WebViewInternal.h:
639
640 2014-12-15  Beth Dakin  <bdakin@apple.com>
641
642         Make lookup an immediate action instead of an action menu item
643         https://bugs.webkit.org/show_bug.cgi?id=139661
644         -and corresponding-
645         rdar://problem/19198414
646
647         Reviewed by Tim Horton.
648
649         Remove the lookup menu items and non-unused static function associated with 
650         lookup.
651         * WebView/WebActionMenuController.mm:
652         (-[WebActionMenuController _defaultMenuItemsForText]):
653         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
654         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
655         (-[WebActionMenuController _createActionMenuItemForTag:]):
656         (-[WebActionMenuController _lookupText:]): Deleted.
657         (performDictionaryLookupForSelection): Deleted.
658         (performDictionaryLookupForRange): Deleted.
659
660         Set the defaultAnimationController to the lookup-provided animation controller 
661         when appropriate.
662         * WebView/WebImmediateActionController.mm:
663         (-[WebImmediateActionController _defaultAnimationController]):
664         (dictionaryPopupInfoForRange):
665         (-[WebImmediateActionController _animationControllerForText]):
666
667         New type.
668         * WebView/WebUIDelegatePrivate.h:
669
670         New function to get the lookup animation controller.
671         * WebView/WebView.mm:
672         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
673         * WebView/WebViewInternal.h:
674
675 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
676
677         Implement Data Detectors immediate actions for Legacy WebKit
678         https://bugs.webkit.org/show_bug.cgi?id=139619
679         <rdar://problem/19198539>
680
681         Reviewed by Beth Dakin.
682
683         * WebView/WebImmediateActionController.mm:
684         (-[WebImmediateActionController _menuItemForDataDetectedText]):
685         Note that this action context is only for immediate actions.
686
687 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
688
689         Addressing post-review comments in r177035
690         https://bugs.webkit.org/show_bug.cgi?id=139557
691
692         Reviewed by Darin Adler.
693
694         * WebView/WebActionMenuController.mm:
695         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
696
697 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
698
699         Implement Data Detectors immediate actions for Legacy WebKit
700         https://bugs.webkit.org/show_bug.cgi?id=139619
701         <rdar://problem/19198539>
702
703         Reviewed by Eric Carlson.
704
705         * WebView/WebHTMLView.mm:
706         (-[WebHTMLView mouseDown:mouseDown:]):
707         Send mouseDown along to the WebImmediateActionController too.
708
709         * WebView/WebImmediateActionController.h:
710         * WebView/WebImmediateActionController.mm:
711         (-[WebImmediateActionController webViewClosed]):
712         (-[WebImmediateActionController webView:willHandleMouseDown:]):
713         (-[WebImmediateActionController _cancelImmediateAction]):
714         (-[WebImmediateActionController _clearImmediateActionState]):
715         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
716         (-[WebImmediateActionController _defaultAnimationController]):
717         (-[WebImmediateActionController _updateImmediateActionItem]):
718         (-[WebImmediateActionController _menuItemForDataDetectedText]):
719         (-[WebImmediateActionController _showTextIndicator]):
720         (-[WebImmediateActionController _hideTextIndicator]):
721         Copy most of the DataDetectors implementation into WebImmediateActionController.
722
723         * WebView/WebUIDelegatePrivate.h:
724         Add a new type.
725
726         * WebView/WebView.mm:
727         (-[WebView _commonInitializationWithFrameName:groupName:]):
728         Temporarily disable action menus.
729
730         (-[WebView _immediateActionController]):
731         * WebView/WebViewInternal.h:
732
733 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
734
735         Delete Notation because we don't use it
736         https://bugs.webkit.org/show_bug.cgi?id=139171
737
738         Reviewed by Kent Tamura.
739
740         * MigrateHeaders.make:
741
742 2014-12-14  Andreas Kling  <akling@apple.com>
743
744         Replace PassRef with Ref/Ref&& across the board.
745         <https://webkit.org/b/139587>
746
747         Reviewed by Darin Adler.
748
749         * WebCoreSupport/WebEditorClient.mm:
750         (WebEditorClient::shouldApplyStyle):
751         * WebCoreSupport/WebVisitedLinkStore.h:
752         * WebCoreSupport/WebVisitedLinkStore.mm:
753         (WebVisitedLinkStore::create):
754
755 2014-12-11  Dan Bernstein  <mitz@apple.com>
756
757         Fix a leak introduced in r177199.
758
759         Reviewed by Anders Carlsson.
760
761         * WebView/WebImmediateActionController.mm:
762         (-[WebImmediateActionController _updateImmediateActionItem]):
763
764 2014-12-11  Beth Dakin  <bdakin@apple.com>
765
766         WK1: Need new SPI for Webkit clients to override default immediate action
767         https://bugs.webkit.org/show_bug.cgi?id=139568
768         -and corresponding-
769         rdar://problem/19225448
770
771         Reviewed by Dan Bernstein.
772
773         Call SPI giving clients a chance to override the default behavior.
774         * WebView/WebImmediateActionController.mm:
775         (-[WebImmediateActionController _updateImmediateActionItem]):
776
777         New SPI.
778         * WebView/WebUIDelegatePrivate.h:
779
780 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
781
782         Move the preview popover to WebImmediateActionController
783         https://bugs.webkit.org/show_bug.cgi?id=139563
784         <rdar://problem/19208291>
785
786         Reviewed by Beth Dakin.
787
788         * WebView/WebActionMenuController.mm:
789         (-[WebActionMenuController _defaultMenuItemsForLink]):
790         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
791         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
792         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
793         * WebView/WebImmediateActionController.h:
794         * WebView/WebImmediateActionController.mm:
795         (-[WebImmediateActionController webViewClosed]):
796         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
797         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
798         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
799         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
800         (-[WebImmediateActionController _updateImmediateActionItem]):
801         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
802         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
803         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
804         Move page preview popover related code to WebImmediateActionController.
805
806         * WebView/WebUIDelegatePrivate.h:
807         Add a link preview type.
808
809         * WebView/WebView.mm:
810         (-[WebView _commonInitializationWithFrameName:groupName:]):
811         Pass the gesture recognizer to the WebImmediateActionController.
812
813 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
814
815         Fix the build.
816
817         * WebView/WebImmediateActionController.h:
818         * WebView/WebImmediateActionController.mm:
819
820 2014-12-11  Anders Carlsson  <andersca@apple.com>
821
822         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
823         https://bugs.webkit.org/show_bug.cgi?id=139547
824
825         Reviewed by Sam Weinig.
826
827         * WebView/WebView.mm:
828         (+[WebView _handleMemoryWarning]):
829
830 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
831
832         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
833         https://bugs.webkit.org/show_bug.cgi?id=139504
834         rdar://problem/19034674
835
836         Reviewed by Enrica Casucci.
837
838         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
839
840         * WebCoreSupport/WebEditorClient.h:
841         * WebCoreSupport/WebEditorClient.mm:
842         (WebEditorClient::discardedComposition):
843
844 2014-12-10  Anders Carlsson  <andersca@apple.com>
845
846         Get rid of the storage strategy
847         https://bugs.webkit.org/show_bug.cgi?id=139519
848
849         Reviewed by Antti Koivisto.
850
851         * WebCoreSupport/WebPlatformStrategies.h:
852         * WebCoreSupport/WebPlatformStrategies.mm:
853         (WebPlatformStrategies::createStorageStrategy): Deleted.
854
855 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
856
857         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
858         https://bugs.webkit.org/show_bug.cgi?id=139529
859         <rdar://problem/19213620>
860
861         Reviewed by Beth Dakin.
862
863         * WebView/WebActionMenuController.mm:
864         (-[WebActionMenuController _copySelection:]):
865         (-[WebActionMenuController _paste:]):
866         Use the copy: and paste: methods on WebView so that we traverse subviews
867         when trying to respond, otherwise these actions don't work in subframes.
868
869 2014-12-10  Beth Dakin  <bdakin@apple.com>
870
871         WK1: Add initial support for immediate actions
872         https://bugs.webkit.org/show_bug.cgi?id=139522
873
874         Reviewed by Dan Bernstein.
875
876         This basic implementation of the controller will use the delegate methods to 
877         perform and cache a HitTest when relevant. Future patches will patch 
878         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
879         immediate action that should be taken.
880         * WebView/WebImmediateActionController.h: Added.
881         * WebView/WebImmediateActionController.mm: Added.
882         (-[WebImmediateActionController webViewClosed]):
883         (-[WebImmediateActionController _clearImmediateActionState]):
884         (-[WebImmediateActionController performHitTestAtPoint:]):
885         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
886         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
887         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
888         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
889         (-[WebImmediateActionController _updateImmediateActionItem]):
890
891         New enum for immediate action types.
892         * WebView/WebUIDelegatePrivate.h:
893
894         Create an NSImmediateActionGestureRecognizer if possible and a controller.
895         * WebView/WebView.mm:
896         (-[WebView _commonInitializationWithFrameName:groupName:]):
897         (-[WebView _close]):
898         * WebView/WebViewData.h:
899         * WebView/WebViewData.mm:
900         (-[WebViewPrivate dealloc]):
901
902 2014-12-08  Anders Carlsson  <andersca@apple.com>
903
904         Use the new storage namespace provider in WebKit1
905         https://bugs.webkit.org/show_bug.cgi?id=139425
906
907         Reviewed by Tim Horton.
908
909         * WebView/WebView.mm:
910         (-[WebView _commonInitializationWithFrameName:groupName:]):
911         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
912         Set the storage namespace provider from the web page group.
913
914 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
915
916         Should have copy and paste items in all text menus
917         https://bugs.webkit.org/show_bug.cgi?id=139510
918         <rdar://problem/19198388>
919
920         Reviewed by Beth Dakin.
921
922         * WebView/WebActionMenuController.mm:
923         (-[WebActionMenuController _defaultMenuItemsForText]):
924         Add a disabled paste menu item into the read-only text menu.
925
926         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
927         Add a disabled copy menu item into the editable whitespace text menu.
928
929 2014-12-10  Anders Carlsson  <andersca@apple.com>
930
931         Add WebStorageNamespaceProvider::closeLocalStorage
932         https://bugs.webkit.org/show_bug.cgi?id=139502
933
934         Reviewed by Tim Horton.
935
936         * WebView/WebView.mm:
937         (+[WebView _applicationWillTerminate]):
938         Call WebStorageNamespaceProvider::closeLocalStorage.
939
940 2014-12-09  Commit Queue  <commit-queue@webkit.org>
941
942         Unreviewed, rolling out r177037.
943         https://bugs.webkit.org/show_bug.cgi?id=139464
944
945         broke ~50 API tests (Requested by thorton on #webkit).
946
947         Reverted changeset:
948
949         "Use the new storage namespace provider in WebKit1"
950         https://bugs.webkit.org/show_bug.cgi?id=139425
951         http://trac.webkit.org/changeset/177037
952
953 2014-12-08  Anders Carlsson  <andersca@apple.com>
954
955         Use the new storage namespace provider in WebKit1
956         https://bugs.webkit.org/show_bug.cgi?id=139425
957
958         Reviewed by Tim Horton.
959
960         * WebView/WebView.mm:
961         (-[WebView _commonInitializationWithFrameName:groupName:]):
962         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
963         Set the storage namespace provider from the web page group.
964
965 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
966
967         Delete Node::boundingBox()
968         https://bugs.webkit.org/show_bug.cgi?id=139333
969
970         Reviewed by Zalan Bujtas.
971
972         * WebView/WebActionMenuController.mm:
973         (elementBoundingBoxInWindowCoordinatesFromNode): Use
974         RenderObject::absoluteBoundingBoxRect().
975
976 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
977
978         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
979         https://bugs.webkit.org/show_bug.cgi?id=138843
980         rdar://problem/18793695
981
982         Reviewed by Dan Bernstein.
983
984         * Panels/WebAuthenticationPanel.m:
985         (-[WebAuthenticationPanel cancel:]):
986         (-[WebAuthenticationPanel logIn:]):
987         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
988         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
989         that only when using an old NSWindow API.
990
991 2014-12-08  Beth Dakin  <bdakin@apple.com>
992
993         Copy and Lookup menu items should be disabled when something is not copyable
994         https://bugs.webkit.org/show_bug.cgi?id=139423
995
996         Reviewed by Tim Horton.
997
998         Disable both lookup and copy when a HitTestResult does not allow copy.
999         * WebView/WebActionMenuController.mm:
1000
1001         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
1002         disable state otherwise.
1003         * WebView/WebView.mm:
1004         (-[WebView _commonInitializationWithFrameName:groupName:]):
1005
1006 2014-12-08  Anders Carlsson  <andersca@apple.com>
1007
1008         Adding user content to a group should force that group to be created
1009         https://bugs.webkit.org/show_bug.cgi?id=139421
1010         rdar://problem/19180108
1011
1012         Reviewed by Sam Weinig.
1013
1014         * WebCoreSupport/WebViewGroup.h:
1015         Store the local storage database path in the group.
1016
1017         * WebCoreSupport/WebViewGroup.mm:
1018         (WebViewGroup::getOrCreate):
1019         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
1020         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
1021
1022         (WebViewGroup::WebViewGroup):
1023         Initialize the new member variable.
1024
1025         (WebViewGroup::storageNamespaceProvider):
1026         Create the namespace provider lazily.
1027
1028         * WebView/WebView.mm:
1029         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1030         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1031         Use getOrCreate instead of get.
1032
1033 2014-12-08  Anders Carlsson  <andersca@apple.com>
1034
1035         WebStorageNamespaceProvider should know about its local storage database path
1036         https://bugs.webkit.org/show_bug.cgi?id=139413
1037
1038         Reviewed by Andreas Kling.
1039
1040         * WebCoreSupport/WebViewGroup.h:
1041         * WebCoreSupport/WebViewGroup.mm:
1042         (WebViewGroup::getOrCreate):
1043         (WebViewGroup::WebViewGroup):
1044         * WebView/WebView.mm:
1045         (-[WebView _commonInitializationWithFrameName:groupName:]):
1046         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1047         (-[WebView setGroupName:]):
1048         (-[WebView groupName]): Deleted.
1049
1050 2014-12-08  Daniel Bates  <dabates@apple.com>
1051
1052         [iOS] Fix the WebKit build with the public SDK
1053
1054         Include header NSURLDownloadSPI.h.
1055
1056         * WebCoreSupport/WebFrameLoaderClient.mm:
1057
1058 2014-12-07  Dan Bernstein  <mitz@apple.com>
1059
1060         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
1061         https://bugs.webkit.org/show_bug.cgi?id=139348
1062
1063         Reviewed by Anders Carlsson.
1064
1065         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
1066         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
1067         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
1068         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
1069         avoiding the ambiguity.
1070
1071         * WebView/WebActionMenuController.mm:
1072         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1073
1074 2014-12-06  Anders Carlsson  <andersca@apple.com>
1075
1076         Add a stubbed out version of WebStorageNamespaceProvider
1077         https://bugs.webkit.org/show_bug.cgi?id=139213
1078
1079         Reviewed by Sam Weinig.
1080
1081         * WebCoreSupport/WebViewGroup.h:
1082         (WebViewGroup::storageNamespaceProvider):
1083         * WebCoreSupport/WebViewGroup.mm:
1084         (WebViewGroup::getOrCreate):
1085         (WebViewGroup::WebViewGroup):
1086         Give WebViewGroup a storage namespace provider.
1087
1088 2014-12-06  Anders Carlsson  <andersca@apple.com>
1089
1090         Fix build with newer versions of clang.
1091         rdar://problem/18978687
1092
1093         Add missing overrides and missing casts.
1094
1095         * Storage/WebDatabaseManagerClient.h:
1096         * Storage/WebStorageTrackerClient.h:
1097         * WebCoreSupport/WebChromeClient.h:
1098         * WebCoreSupport/WebFrameLoaderClient.h:
1099         * WebCoreSupport/WebInspectorClient.h:
1100         * WebView/WebDataSource.mm:
1101         (-[WebDataSource _makeRepresentation]):
1102         * WebView/WebFrameView.mm:
1103         (-[WebFrameView _makeDocumentViewForDataSource:]):
1104
1105 2014-12-05  Tim Horton  <timothy_horton@apple.com>
1106
1107         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
1108         https://bugs.webkit.org/show_bug.cgi?id=139306
1109         <rdar://problem/19157955>
1110
1111         Reviewed by Beth Dakin.
1112
1113         * WebView/WebView.mm:
1114         (-[WebView _commonInitializationWithFrameName:groupName:]):
1115         (-[WebView _initWithFrame:frameName:groupName:]):
1116         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
1117
1118 2014-12-05  David Kilzer  <ddkilzer@apple.com>
1119
1120         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
1121         <http://webkit.org/b/139286>
1122
1123         Reviewed by Daniel Bates.
1124
1125         * Configurations/FeatureDefines.xcconfig: Switch back to using
1126         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
1127
1128 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
1129
1130         Fix the 32-bit build.
1131
1132         * WebView/WebView.mm:
1133         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1134
1135 2014-12-04  Tim Horton  <timothy_horton@apple.com>
1136
1137         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
1138         https://bugs.webkit.org/show_bug.cgi?id=139252
1139         <rdar://problem/19140827>
1140
1141         Reviewed by Anders Carlsson.
1142
1143         * WebView/WebView.mm:
1144         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1145         Adjust to the WebCore changes.
1146
1147 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
1148
1149         Implement action menus for tel: URLs
1150         https://bugs.webkit.org/show_bug.cgi?id=139240
1151         <rdar://problem/19115662>
1152
1153         Reviewed by Anders Carlsson.
1154
1155         * WebView/WebActionMenuController.mm:
1156         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1157         Make sure to use the newly created currentActionContext... everywhere.
1158
1159 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
1160
1161         Implement action menus for tel: URLs
1162         https://bugs.webkit.org/show_bug.cgi?id=139240
1163         <rdar://problem/19115662>
1164
1165         Reviewed by Anders Carlsson.
1166
1167         * WebView/WebActionMenuController.mm:
1168         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1169         Make sure to use the newly created currentActionContext.
1170
1171 2014-12-03  Beth Dakin  <bdakin@apple.com>
1172
1173         <input> elements get whitespace action menu instead of editable text menu
1174         https://bugs.webkit.org/show_bug.cgi?id=139241
1175         -and corresponding-
1176         rdar://problem/19072083
1177
1178         Reviewed by Sam Weinig.
1179
1180         We should disallow shadow content in the hit test. This is the default and it is 
1181         how context menus behave. We originally wanted to text inside shadow content so 
1182         that we could find the text, but the new function I added to HitTestResult will 
1183         allow that.
1184         * WebView/WebActionMenuController.mm:
1185         (-[WebActionMenuController performHitTestAtPoint:]):
1186
1187         Adjust to the fact that we don’t hit test shadow content any more.
1188         (-[WebActionMenuController focusAndSelectHitTestResult]):
1189
1190         Offer the text menus for text inside form controls.
1191         (-[WebActionMenuController _defaultMenuItems]):
1192
1193 2014-12-03  Tim Horton  <timothy_horton@apple.com>
1194
1195         Implement action menus for tel: URLs
1196         https://bugs.webkit.org/show_bug.cgi?id=139240
1197         <rdar://problem/19115662>
1198
1199         Reviewed by Anders Carlsson.
1200
1201         * WebView/WebActionMenuController.mm:
1202         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1203         Rename this function as it will work for both mailto and tel URLs.
1204         Adjust it to use contextForView:.
1205
1206         (-[WebActionMenuController webView:willHandleMouseDown:]):
1207         (-[WebActionMenuController prepareForMenu:withEvent:]):
1208         (-[WebActionMenuController didCloseMenu:withEvent:]):
1209         (-[WebActionMenuController _defaultMenuItems]):
1210         Don't check the menu type when going to interact with _currentActionContext.
1211         We'll only have a _currentActionContext if we have a data detected item,
1212         and there are multiple menu types that end up using DDActionContext.
1213
1214         * WebView/WebUIDelegatePrivate.h:
1215         Add a new type.
1216
1217 2014-12-03  Anders Carlsson  <andersca@apple.com>
1218
1219         Set a visited link store when creating a simple WebView
1220         https://bugs.webkit.org/show_bug.cgi?id=139234
1221         <rdar://problem/19132978>
1222
1223         Reviewed by Sam Weinig.
1224
1225         * WebView/WebView.mm:
1226         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1227
1228 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
1229
1230         Fix the build.
1231
1232         * WebCoreSupport/WebFrameLoaderClient.mm:
1233
1234 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
1235
1236         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
1237         https://bugs.webkit.org/show_bug.cgi?id=139149
1238
1239         Reviewed by Anders Carlsson.
1240
1241         This changes API behavior. I think that it's OK, because existing behavior made no sense.
1242         We used to delete caches from disk, but they were still active in memory. Now we also
1243         obsolete them in memory, so documents that use a cache still work, but new ones don't
1244         pick one up.
1245
1246         * WebCoreSupport/WebApplicationCache.mm:
1247         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
1248         need to delete in-momry caches too. Keep existing behavior.
1249         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
1250         that properly deletes caches.
1251
1252 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1253
1254         Remove a SnowLeopard-era quirk for QuickLook
1255         https://bugs.webkit.org/show_bug.cgi?id=139208
1256         <rdar://problem/19121822>
1257
1258         Reviewed by Alexey Proskuryakov.
1259
1260         * WebCoreSupport/WebFrameLoaderClient.h:
1261         * WebCoreSupport/WebFrameLoaderClient.mm:
1262
1263 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1264
1265         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
1266         https://bugs.webkit.org/show_bug.cgi?id=139204
1267
1268         Reviewed by Anders Carlsson.
1269
1270         * WebView/WebView.mm:
1271         (-[WebView _commonInitializationWithFrameName:groupName:]):
1272         (-[WebView _showDictionaryLookupPopup:]):
1273         * WebView/WebViewData.h:
1274         Work around this by delaying the softlinking (and setting up the notification
1275         observer) until we actually need it. There's still an underlying bug, but
1276         this will fix the test.
1277
1278 2014-12-02  Beth Dakin  <bdakin@apple.com>
1279
1280         Yet another build fix.
1281
1282         * WebView/WebActionMenuController.mm:
1283         (-[WebActionMenuController _defaultMenuItemsForLink]):
1284
1285 2014-12-02  Beth Dakin  <bdakin@apple.com>
1286
1287         Build fix.
1288
1289         * WebView/WebActionMenuController.mm:
1290         (-[WebActionMenuController _defaultMenuItemsForLink]):
1291
1292 2014-12-02  Beth Dakin  <bdakin@apple.com>
1293
1294         More build fixing.
1295
1296         * WebView/WebActionMenuController.mm:
1297         (-[WebActionMenuController _defaultMenuItemsForLink]):
1298
1299 2014-12-02  Beth Dakin  <bdakin@apple.com>
1300
1301         Should use standardQuickLookMenuItem for apps that don't implement customizations
1302         https://bugs.webkit.org/show_bug.cgi?id=139193
1303         -and corresponding-
1304         rdar://problem/18944696
1305
1306         Reviewed by Anders Carlsson.
1307
1308         Use [NSMenuItem standardQuickLookMenuItem].
1309         * WebView/WebActionMenuController.mm:
1310         (-[WebActionMenuController _defaultMenuItemsForLink]):
1311
1312         Delegate methods to set up the standardQuickLookMenuItem.
1313         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
1314         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
1315         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
1316
1317         Remove all of the old QLPreviewBubble code.
1318         (-[WebActionMenuController _createActionMenuItemForTag:]):
1319         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
1320
1321 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
1322
1323         Fix the build.
1324
1325         * WebView/WebViewData.h:
1326
1327 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1328
1329         Implement Lookup transition from selection for Legacy WebKit
1330         https://bugs.webkit.org/show_bug.cgi?id=139180
1331         <rdar://problem/19067172>
1332
1333         Reviewed by Beth Dakin.
1334
1335         * WebView/DictionaryPopupInfo.h: Added.
1336         Split DictionaryPopupInfo out into its own file.
1337
1338         * WebView/WebActionMenuController.mm:
1339         (-[WebActionMenuController _lookupText:]):
1340         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
1341
1342         (performDictionaryLookupForSelection):
1343         (performDictionaryLookupForRange):
1344         Plumb the transition style through these helpers.
1345         Create a TextIndicator from the selection range.
1346
1347         * WebView/WebHTMLView.mm:
1348         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
1349         Make use of TextIndicator (and DictionaryPopupInfo, and the new
1350         _showDictionaryLookupPopup on WebView) to add a transition from blue
1351         when performing Lookup from the context menu.
1352
1353         (-[WebHTMLView quickLookWithEvent:]):
1354         Remove our TextIndicator whenever a normal three-finger-tap event
1355         comes through, as it will have its own indication.
1356
1357         * WebView/WebView.mm:
1358         (-[WebView _commonInitializationWithFrameName:groupName:]):
1359         (-[WebView _dictionaryLookupPopoverWillClose:]):
1360         Register for the LUNotificationPopoverWillClose notification and remove
1361         our TextIndicator when it is called, just like in WebKit2.
1362         Deregistration is already handled in _close.
1363
1364         (-[WebView _showDictionaryLookupPopup:]):
1365         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
1366         if the relevant API is available.
1367
1368         * WebView/WebViewInternal.h:
1369
1370 2014-12-02  Anders Carlsson  <andersca@apple.com>
1371
1372         Remove visited link handling from PageGroup
1373         https://bugs.webkit.org/show_bug.cgi?id=139185
1374
1375         Reviewed by Sam Weinig.
1376
1377         * History/WebHistory.mm:
1378         (-[WebHistoryPrivate removeItemForURLString:]):
1379         (-[WebHistoryPrivate removeAllItems]):
1380         (+[WebHistory setOptionalSharedHistory:]):
1381         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1382         (+[WebHistory _removeAllVisitedLinks]):
1383         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
1384         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
1385         * History/WebHistoryInternal.h:
1386         * WebCoreSupport/WebChromeClient.h:
1387         * WebCoreSupport/WebChromeClient.mm:
1388         (WebChromeClient::populateVisitedLinks): Deleted.
1389         * WebView/WebView.mm:
1390         (-[WebView addVisitedLinks:]):
1391         (-[WebView removeVisitedLink:]):
1392
1393 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1394
1395         Try to fix the Mac build.
1396
1397         * WebView/WebView.mm:
1398         (-[WebView _commonInitializationWithFrameName:groupName:]):
1399         (-[WebView _close]):
1400
1401 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1402
1403         Fix the iOS build.
1404
1405         * WebView/WebActionMenuController.h:
1406         * WebView/WebActionMenuController.mm:
1407         * WebView/WebHTMLView.mm:
1408         (-[WebHTMLView scrollWheel:scrollWheel:]):
1409         (-[WebHTMLView mouseDown:mouseDown:]):
1410         * WebView/WebView.mm:
1411         * WebView/WebViewData.h:
1412         * WebView/WebViewData.mm:
1413         (-[WebViewPrivate dealloc]):
1414         * WebView/WebViewInternal.h:
1415
1416 2014-12-01  Tim Horton  <timothy_horton@apple.com>
1417
1418         Implement yellow highlight for WebKit1 data detectors
1419         https://bugs.webkit.org/show_bug.cgi?id=138956
1420         <rdar://problem/18992185>
1421
1422         Reviewed by Beth Dakin.
1423
1424         * WebView/WebActionMenuController.h:
1425         * WebView/WebActionMenuController.mm:
1426         (-[WebActionMenuController webView:willHandleMouseDown:]):
1427         (-[WebActionMenuController webView:didHandleScrollWheel:]):
1428         (-[WebActionMenuController prepareForMenu:withEvent:]):
1429         (-[WebActionMenuController didCloseMenu:withEvent:]):
1430         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1431         (-[WebActionMenuController _showTextIndicator]):
1432         (-[WebActionMenuController _hideTextIndicator]):
1433         (-[WebActionMenuController _dismissActionMenuPopovers]):
1434         Copy the WebKit2 WKActionMenuController TextIndicator implementation
1435         into WebActionMenuController. The only significant difference is
1436         that we build the TextIndicator right at menu construction time
1437         instead of in the Web process.
1438
1439         * WebView/WebHTMLView.mm:
1440         (-[WebHTMLView scrollWheel:]):
1441         Let the WebActionMenuController know that we're handling a scroll.
1442
1443         (-[WebHTMLView mouseDown:]):
1444         Let the WebActionMenuController know that we're handling a mouseDown.
1445
1446         * WebView/WebView.mm:
1447         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1448         (-[WebView _clearTextIndicator]):
1449         (-[WebView _actionMenuController]):
1450         (-[WebView _convertRectFromRootView:]): Deleted.
1451         * WebView/WebViewData.h:
1452         * WebView/WebViewData.mm:
1453         * WebView/WebViewInternal.h:
1454         Keep a TextIndicatorWindow on WebView, just like WKView does.
1455         Expose the WebActionMenuController on WebView (internally).
1456
1457 2014-12-01  Anders Carlsson  <andersca@apple.com>
1458
1459         Remove old site specific quirks code that was added in 2009
1460         https://bugs.webkit.org/show_bug.cgi?id=139141
1461
1462         Reviewed by Antti Koivisto.
1463
1464         * WebCoreSupport/WebFrameNetworkingContext.h:
1465         * WebCoreSupport/WebFrameNetworkingContext.mm:
1466         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
1467
1468 2014-11-30  Anders Carlsson  <andersca@apple.com>
1469
1470         Fix a test failure.
1471
1472         * History/WebHistory.mm:
1473         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1474         Call through to the visited link store.
1475
1476         (+[WebHistory _removeAllVisitedLinks]):
1477         Ditto.
1478
1479         * WebCoreSupport/WebVisitedLinkStore.mm:
1480         (WebVisitedLinkStore::isLinkVisited):
1481         Make sure to populate visited links.
1482
1483 2014-11-30  Anders Carlsson  <andersca@apple.com>
1484
1485         Switch over to the visited link store from the WebViewGroup
1486         https://bugs.webkit.org/show_bug.cgi?id=139112
1487
1488         Reviewed by Sam Weinig.
1489
1490         * WebView/WebView.mm:
1491         (-[WebView _commonInitializationWithFrameName:groupName:]):
1492         (-[WebView setGroupName:]):
1493
1494 2014-11-30  Anders Carlsson  <andersca@apple.com>
1495
1496         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
1497         https://bugs.webkit.org/show_bug.cgi?id=139111
1498
1499         Reviewed by Sam Weinig.
1500
1501         * WebCoreSupport/WebVisitedLinkStore.h:
1502         * WebCoreSupport/WebVisitedLinkStore.mm:
1503         (WebVisitedLinkStore::removeVisitedLink):
1504         * WebView/WebView.mm:
1505         (-[WebView removeVisitedLink:]):
1506
1507 2014-11-29  Anders Carlsson  <andersca@apple.com>
1508
1509         Populate visited links
1510         https://bugs.webkit.org/show_bug.cgi?id=139101
1511
1512         Reviewed by Sam Weinig.
1513
1514         * History/WebHistory.mm:
1515         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
1516         Helper function that adds all visited link to the given store.
1517
1518         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
1519         Call the private method.
1520
1521         * History/WebHistoryInternal.h:
1522         * WebCoreSupport/WebVisitedLinkStore.h:
1523         Add new members.
1524
1525         * WebCoreSupport/WebVisitedLinkStore.mm:
1526         (WebVisitedLinkStore::addVisitedLink):
1527         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
1528
1529         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1530         Implement this. First try the delegate, then try the shared history.
1531
1532         (WebVisitedLinkStore::addVisitedLinkHash):
1533         Factor code that adds the link to the hash table into a separate function.
1534
1535         * WebView/WebView.mm:
1536         (-[WebView addVisitedLinks:]):
1537         Add the visited links to the store.
1538
1539 2014-11-29  Anders Carlsson  <andersca@apple.com>
1540
1541         More work on the legacy WebKit visited link store
1542         https://bugs.webkit.org/show_bug.cgi?id=139100
1543
1544         Reviewed by Sam Weinig.
1545
1546         * History/WebHistory.mm:
1547         (+[WebHistory setOptionalSharedHistory:]):
1548         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
1549
1550         * WebCoreSupport/WebVisitedLinkStore.h:
1551         * WebCoreSupport/WebVisitedLinkStore.mm:
1552         (visitedLinkStores):
1553         (WebVisitedLinkStore::WebVisitedLinkStore):
1554         (WebVisitedLinkStore::~WebVisitedLinkStore):
1555         Keep track of live visited link stores.
1556
1557         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
1558         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
1559
1560         (WebVisitedLinkStore::removeAllVisitedLinks):
1561         Iterate over all live link stores and remove their links.
1562
1563         (WebVisitedLinkStore::isLinkVisited):
1564         Populate visited links and check if our hash table contains the link.
1565
1566         (WebVisitedLinkStore::addVisitedLink):
1567         Add the link hash to the table.
1568
1569         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1570         Add stub.
1571
1572         (WebVisitedLinkStore::removeVisitedLinkHashes):
1573         Clear out the hash table.
1574
1575 2014-11-27  Anders Carlsson  <andersca@apple.com>
1576
1577         Add a stubbed out WebVisitedLinkStore to WebViewGroup
1578         https://bugs.webkit.org/show_bug.cgi?id=139066
1579
1580         Reviewed by Antti Koivisto.
1581
1582         * WebCoreSupport/WebViewGroup.h:
1583         (WebViewGroup::visitedLinkStore):
1584         * WebCoreSupport/WebViewGroup.mm:
1585         (WebViewGroup::WebViewGroup):
1586         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1587         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1588         (WebVisitedLinkStore::create):
1589         (WebVisitedLinkStore::WebVisitedLinkStore):
1590         (WebVisitedLinkStore::~WebVisitedLinkStore):
1591         (WebVisitedLinkStore::isLinkVisited):
1592         (WebVisitedLinkStore::addVisitedLink):
1593
1594 2014-11-25  Anders Carlsson  <andersca@apple.com>
1595
1596         Remove user content handling from PageGroup
1597         https://bugs.webkit.org/show_bug.cgi?id=139051
1598
1599         Reviewed by Antti Koivisto.
1600
1601         Use the user content controller in the web view group.
1602
1603         * WebView/WebView.mm:
1604         (-[WebView _injectOutlookQuirksScript]):
1605
1606 2014-11-25  Anders Carlsson  <andersca@apple.com>
1607
1608         Add a user content controller to WebViewGroup and use it for user content
1609         https://bugs.webkit.org/show_bug.cgi?id=139043
1610
1611         Reviewed by Antti Koivisto.
1612
1613         This is another tiny step towards getting rid of user content handling inside PageGroup.
1614
1615         * WebCoreSupport/WebViewGroup.h:
1616         (WebViewGroup::userContentController):
1617         Add a UserContentController member and getter.
1618
1619         * WebCoreSupport/WebViewGroup.mm:
1620         (WebViewGroup::get):
1621         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
1622
1623         (WebViewGroup::WebViewGroup):
1624         Create a user content controller.
1625
1626         * WebView/WebView.mm:
1627         (-[WebView _commonInitializationWithFrameName:groupName:]):
1628         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
1629         set its user content controller in the PageConfiguration.
1630
1631         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1632         Ditto.
1633
1634         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1635         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1636         (+[WebView _removeUserScriptFromGroup:world:url:]):
1637         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
1638         (+[WebView _removeUserScriptsFromGroup:world:]):
1639         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
1640         (+[WebView _removeAllUserContentFromGroup:]):
1641         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
1642
1643         (-[WebView setGroupName:]):
1644         Set the user content controller to the new WebViewGroup's user content controller.
1645
1646 2014-11-21  Jer Noble  <jer.noble@apple.com>
1647
1648         Support multiple signatures of diagnostic logging.
1649         https://bugs.webkit.org/show_bug.cgi?id=138690
1650
1651         Reviewed by Anders Carlsson.
1652
1653         Page::PageClients has been renamed PageConfiguration.
1654
1655         * WebView/WebView.mm:
1656         (-[WebView _commonInitializationWithFrameName:groupName:]):
1657         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1658
1659 2014-11-21  Zalan Bujtas  <zalan@apple.com>
1660
1661         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
1662         https://bugs.webkit.org/show_bug.cgi?id=138981
1663
1664         Reviewed by Simon Fraser.
1665
1666         * WebView/WebPreferenceKeysPrivate.h:
1667         * WebView/WebPreferences.mm:
1668         (+[WebPreferences initialize]):
1669         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
1670         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
1671         * WebView/WebPreferencesPrivate.h:
1672         * WebView/WebView.mm:
1673         (-[WebView _preferencesChanged:]):
1674
1675 2014-11-21  Tim Horton  <timothy_horton@apple.com>
1676
1677         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
1678         ​https://bugs.webkit.org/show_bug.cgi?id=138960
1679         <rdar://problem/19056715>
1680
1681         Reviewed by Anders Carlsson.
1682
1683         * WebView/WebActionMenuController.mm:
1684         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
1685         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1686         Use DataDetectors SPI instead of an explicit blacklist.
1687
1688 2014-11-21  Tim Horton  <timothy_horton@apple.com>
1689
1690         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
1691         https://bugs.webkit.org/show_bug.cgi?id=138960
1692         <rdar://problem/19056715>
1693
1694         Reviewed by Beth Dakin.
1695
1696         * WebView/WebActionMenuController.mm:
1697         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1698         Blacklist contact results, because they don't have useful menus. If we
1699         bail before setting up _currentActionContext, we'll still allow fallthrough
1700         to ordinary text actions, avoiding mysterious failure when a contact is detected.
1701
1702         This doesn't break the case that r176351 was intended to fix,
1703         because in that case we were detecting e.g. addresses.
1704
1705 2014-11-21  Anders Carlsson  <andersca@apple.com>
1706
1707         Remove the Timer parameters from timer callbacks
1708         https://bugs.webkit.org/show_bug.cgi?id=138974
1709
1710         Reviewed by Antti Koivisto.
1711
1712         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1713         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1714         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
1715         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
1716         * Plugins/WebNetscapePluginStream.h:
1717         * Plugins/WebNetscapePluginStream.mm:
1718         (WebNetscapePluginStream::WebNetscapePluginStream):
1719         (WebNetscapePluginStream::deliverDataTimerFired):
1720
1721 2014-11-21  Anders Carlsson  <andersca@apple.com>
1722
1723         Make memoryCache() return a reference
1724         https://bugs.webkit.org/show_bug.cgi?id=138939
1725
1726         Reviewed by Antti Koivisto.
1727
1728         * Misc/WebCache.mm:
1729         (+[WebCache statistics]):
1730         (+[WebCache emptyInMemoryResources]):
1731         (+[WebCache sizeOfDeadResources:]):
1732         (+[WebCache addImageToCache:forURL:forFrame:]):
1733         (+[WebCache removeImageFromCacheForURL:forFrame:]):
1734         (+[WebCache imageForURL:]):
1735         (+[WebCache setDisabled:]):
1736         (+[WebCache isDisabled]):
1737         * WebView/WebView.mm:
1738         (+[WebView _setCacheModel:]):
1739
1740 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
1741
1742         Remove the remaining vestiges of minimal-ui
1743         https://bugs.webkit.org/show_bug.cgi?id=138890
1744
1745         Reviewed by Sam Weinig.
1746
1747         * History/WebHistoryItem.mm:
1748         * History/WebHistoryItemPrivate.h:
1749
1750 2014-11-20  Tim Horton  <timothy_horton@apple.com>
1751
1752         Cancel DataDetectors menu earlier if we know it can't be presented
1753         https://bugs.webkit.org/show_bug.cgi?id=138922
1754         <rdar://problem/18950441>
1755
1756         Reviewed by Beth Dakin.
1757
1758         * WebView/WebActionMenuController.mm:
1759         (-[WebActionMenuController prepareForMenu:withEvent:]):
1760         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
1761         and use a bigger hammer (removeAllItems).
1762
1763         (-[WebActionMenuController willOpenMenu:withEvent:]):
1764         If we end up with a menu with no items, don't change selection or anything.
1765
1766 2014-11-20  Beth Dakin  <bdakin@apple.com>
1767
1768         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
1769         https://bugs.webkit.org/show_bug.cgi?id=138568
1770         -and corresponding-
1771         rdar://problem/18904600
1772
1773         Reviewed by Tim Horton.
1774
1775         Skip images for lookup.
1776         * WebView/WebActionMenuController.mm:
1777         (performDictionaryLookupForRange):
1778
1779 2014-11-19  Beth Dakin  <bdakin@apple.com>
1780
1781         Invoking an action menu on a selection should result in the text menu
1782         https://bugs.webkit.org/show_bug.cgi?id=138892
1783         -and corresponding-
1784         rdar://problem/18996776
1785
1786         Reviewed by Tim Horton.
1787
1788         * WebView/WebActionMenuController.mm:
1789         (-[WebActionMenuController _defaultMenuItems]):
1790
1791 2014-11-19  Beth Dakin  <bdakin@apple.com>
1792
1793         Data detected results with no menu items should not fall through to regular text 
1794         action menus
1795         https://bugs.webkit.org/show_bug.cgi?id=138887
1796         -and corresponding-
1797         rdar://problem/18971616
1798
1799         Reviewed by Tim Horton.
1800
1801         * WebView/WebActionMenuController.mm:
1802         (-[WebActionMenuController _defaultMenuItems]):
1803
1804 2014-11-19  Daniel Bates  <dabates@apple.com>
1805
1806         [iOS] Make WebKit build with public iOS SDK
1807         https://bugs.webkit.org/show_bug.cgi?id=136863
1808
1809         Reviewed by David Kilzer.
1810
1811         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
1812         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
1813         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
1814         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
1815         may be used by Apple internal clients that do not include wtf/Platform.h.
1816         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
1817         private Foundation headers directly.
1818         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
1819         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
1820         instead of including private CFNetwork headers directly. Also fixed up style and
1821         ordering of header include directives.
1822         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
1823         CFNetwork headers directly. Also sort the #import directives.
1824         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
1825         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
1826
1827 2014-11-18  David Kilzer  <ddkilzer@apple.com>
1828
1829         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
1830         <http://webkit.org/b/138813>
1831
1832         Reviewed by Mark Rowe.
1833
1834         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
1835         selectors.
1836
1837 2014-11-18  Chris Dumez  <cdumez@apple.com>
1838
1839         Add a setting to toggle DOMTimer throttling support
1840         https://bugs.webkit.org/show_bug.cgi?id=138844
1841         <rdar://problem/19020874>
1842
1843         Reviewed by Andreas Kling.
1844
1845         Add a setting to disable DOM timers throttling, in order to help
1846         developers determine if a specific issue is caused by timer
1847         throttling.
1848
1849         * WebView/WebPreferenceKeysPrivate.h:
1850         * WebView/WebPreferences.mm:
1851         (+[WebPreferences initialize]):
1852         (-[WebPreferences domTimersThrottlingEnabled]):
1853         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
1854         * WebView/WebPreferencesPrivate.h:
1855         * WebView/WebView.mm:
1856         (-[WebView _preferencesChanged:]):
1857
1858 2014-11-18  Tim Horton  <timothy_horton@apple.com>
1859
1860         Avoid re-encoding action menu image data
1861         https://bugs.webkit.org/show_bug.cgi?id=138817
1862         <rdar://problem/18840382>
1863
1864         Reviewed by Anders Carlsson.
1865
1866         * WebView/WebActionMenuController.mm:
1867         (-[WebActionMenuController _defaultMenuItemsForImage:]):
1868         (-[WebActionMenuController _addImageToPhotos:]):
1869         Build a temporary filename from a UUID and the image's desired extension.
1870         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
1871         Build an image menu only if we have an image, URL, data, and extension.
1872
1873 2014-11-18  Daniel Bates  <dabates@apple.com>
1874
1875         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1876         SPI are not available in public SDK
1877         https://bugs.webkit.org/show_bug.cgi?id=138802
1878
1879         Reviewed by David Kilzer.
1880
1881         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
1882         libdispatch and MobileGestalt headers directly.
1883
1884         * WebView/WebView.mm:
1885
1886 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
1887
1888         Remove calls to deprecated NSMenu methods
1889         https://bugs.webkit.org/show_bug.cgi?id=138808.
1890
1891         Reviewed by Anders Carlsson.
1892
1893         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
1894
1895         * WebCoreSupport/PopupMenuMac.mm:
1896         (PopupMenuMac::populate):
1897
1898 2014-11-17  Daniel Bates  <dabates@apple.com>
1899
1900         Unreviewed, rolling out r176232.
1901
1902         Broke the Mac build. Will investigate offline.
1903
1904         Reverted changeset:
1905
1906         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
1907         MobileGestalt"
1908         https://bugs.webkit.org/show_bug.cgi?id=138802
1909         http://trac.webkit.org/changeset/176232
1910
1911 2014-11-17  Daniel Bates  <dabates@apple.com>
1912
1913         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1914         SPI are not available in public SDK
1915         https://bugs.webkit.org/show_bug.cgi?id=138802
1916
1917         Reviewed by David Kilzer.
1918
1919         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
1920         libdispatch and MobileGestalt headers directly.
1921
1922         * WebView/WebView.mm:
1923
1924 2014-11-17  Beth Dakin  <bdakin@apple.com>
1925
1926         Whitespace action menus should focus the HitTestResult and create an insertion 
1927         point
1928         https://bugs.webkit.org/show_bug.cgi?id=138786
1929         -and corresponding-
1930         rdar://problem/18944893
1931
1932         Reviewed by Tim Horton.
1933
1934         Whitespace menus should cause the HitTestResult to be focused, and they should set 
1935         the selection based on the HitTest location.
1936
1937         * WebView/WebActionMenuController.mm:
1938         (-[WebActionMenuController isMenuForTextContent]):
1939         (-[WebActionMenuController focusAndSelectHitTestResult]):
1940         (-[WebActionMenuController willOpenMenu:withEvent:]):
1941
1942 2014-11-17  Daniel Bates  <dabates@apple.com>
1943
1944         [iOS] QuartzCore SPI not available in public SDK
1945         https://bugs.webkit.org/show_bug.cgi?id=138751
1946
1947         Reviewed by David Kilzer.
1948
1949         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
1950
1951         * WebInspector/WebNodeHighlight.mm:
1952         * WebView/WebIndicateLayer.mm:
1953
1954 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
1955
1956         [iOS] allow host application to opt-out of alternate fullscreen
1957         https://bugs.webkit.org/show_bug.cgi?id=138787
1958
1959         Reviewed by Darin Adler.
1960
1961         * WebView/WebPreferenceKeysPrivate.h:
1962         * WebView/WebPreferences.mm:
1963         (+[WebPreferences initialize]):
1964         (-[WebPreferences allowsAlternateFullscreen]):
1965         (-[WebPreferences setAllowsAlternateFullscreen:]):
1966         * WebView/WebPreferencesPrivate.h:
1967         * WebView/WebView.mm:
1968         (-[WebView _preferencesChanged:]):
1969
1970 2014-11-16  Tim Horton  <timothy_horton@apple.com>
1971
1972         Use TextIndicator instead of the built in Lookup highlight
1973         https://bugs.webkit.org/show_bug.cgi?id=138775
1974         <rdar://problem/18953982>
1975
1976         Reviewed by Anders Carlsson.
1977
1978         * WebCoreSupport/WebSystemInterface.mm:
1979         (InitWebCoreSystemInterface):
1980         Remove a WKSI import.
1981
1982         * WebView/WebActionMenuController.mm:
1983         (-[WebActionMenuController _lookupText:]):
1984         (-[WebActionMenuController _createActionMenuItemForTag:]):
1985         Make use of the new Lookup SPI header.
1986         Disable the Lookup item if lookup is not available.
1987
1988 2014-11-15  Tim Horton  <timothy_horton@apple.com>
1989
1990         Implement data detectors and mailto action menus for WebKit1
1991         https://bugs.webkit.org/show_bug.cgi?id=138765
1992         <rdar://problem/18877535>
1993
1994         Reviewed by Beth Dakin.
1995
1996         * WebView/WebActionMenuController.h:
1997         * WebView/WebActionMenuController.mm:
1998         (-[WebActionMenuController willOpenMenu:withEvent:]):
1999         Tell DataDetectors that the menu is going to open.
2000         Select the text (or not) based on the number of items in the menu, just like WebKit2.
2001
2002         (-[WebActionMenuController didCloseMenu:withEvent:]):
2003         Tell DataDetectors that the menu closed.
2004
2005         (-[WebActionMenuController _defaultMenuItemsForLink]):
2006         Move these checks out of _defaultMenuItemsForLink, because we expect this
2007         to always return a complete link menu.
2008
2009         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
2010         Implement. More or less copied from WebKit2.
2011
2012         (-[WebActionMenuController _selectDataDetectedText]):
2013         Select the stashed range.
2014
2015         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2016         Implement. More or less copied from WebKit2.
2017         The yellow highlight isn't hooked up yet.
2018         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
2019
2020         (-[WebActionMenuController _selectLookupText]):
2021         Remove an unnecessary return.
2022
2023         (-[WebActionMenuController _defaultMenuItems]):
2024         Call into the two new menu types.
2025
2026         * WebView/WebUIDelegatePrivate.h:
2027
2028 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
2029
2030         Get rid of WebFontCache
2031         https://bugs.webkit.org/show_bug.cgi?id=134752
2032
2033         Reviewed by Dave Hyatt.
2034
2035         * WebView/WebHTMLView.mm:
2036
2037 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
2038
2039         Update some artwork for the legacy WebKit action menu
2040         https://bugs.webkit.org/show_bug.cgi?id=138758
2041         <rdar://problem/18989840>
2042
2043         * WebView/WebActionMenuController.mm:
2044         (webKitBundleImageNamed): Deleted.
2045         Fix the build.
2046
2047 2014-11-14  Tim Horton  <timothy_horton@apple.com>
2048
2049         Update some artwork for the legacy WebKit action menu
2050         https://bugs.webkit.org/show_bug.cgi?id=138758
2051         <rdar://problem/18989840>
2052
2053         Reviewed by Simon Fraser.
2054
2055         * WebView/WebActionMenuController.mm:
2056         (-[WebActionMenuController _createActionMenuItemForTag:]):
2057
2058 2014-11-14  Daniel Bates  <dabates@apple.com>
2059
2060         [iOS] NSFileManager and QuickLook SPI not available in public SDK
2061         https://bugs.webkit.org/show_bug.cgi?id=138742
2062
2063         Reviewed by Pratik Solanki.
2064
2065         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
2066
2067         * WebCoreSupport/WebFrameLoaderClient.mm:
2068
2069 2014-11-14  Beth Dakin  <bdakin@apple.com>
2070
2071         WK1: Webpage preview can come up in wrong location
2072         https://bugs.webkit.org/show_bug.cgi?id=138747
2073         -and corresponding-
2074         rdar://problem/18979004
2075
2076         Reviewed by Tim Horton.
2077
2078         Converting to window twice is bad.
2079         * WebView/WebActionMenuController.mm:
2080         (elementBoundingBoxInWindowCoordinatesFromNode):
2081         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2082         (elementBoundingBoxFromNode): Deleted.
2083
2084 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
2085
2086         Move FontMac and FontCacheMac off of WKSI
2087         https://bugs.webkit.org/show_bug.cgi?id=138633
2088
2089         Reviewed by Simon Fraser.
2090
2091         * WebCoreSupport/WebSystemInterface.mm:
2092         (InitWebCoreSystemInterface):
2093         * WebKit.order:
2094
2095 2014-11-13  Beth Dakin  <bdakin@apple.com>
2096
2097         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
2098         https://bugs.webkit.org/show_bug.cgi?id=138716
2099         -and corresponding-
2100         rdar://problem/18977222
2101
2102         Reviewed by Tim Horton.
2103
2104         It’s not necessary to use the WebElementDictionary for so many things now that we 
2105         are caching the HitTestResult. We should just use the HitTestResult.
2106
2107         * WebView/WebActionMenuController.mm:
2108         (-[WebActionMenuController prepareForMenu:withEvent:]):
2109         (-[WebActionMenuController _openURLFromActionMenu:]):
2110         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2111         (elementBoundingBoxFromNode):
2112         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2113         (-[WebActionMenuController _defaultMenuItemsForLink]):
2114         (-[WebActionMenuController _defaultMenuItemsForImage]):
2115         (-[WebActionMenuController _defaultMenuItemsForVideo]):
2116         (-[WebActionMenuController _defaultMenuItemsForText]):
2117         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
2118         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
2119         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
2120         (-[WebActionMenuController _createActionMenuItemForTag:]):
2121         (-[WebActionMenuController _defaultMenuItems]):
2122         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
2123         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
2124         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
2125         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
2126         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
2127         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
2128         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
2129         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
2130         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
2131         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
2132
2133 2014-11-13  Daniel Bates  <dabates@apple.com>
2134
2135         [iOS] NSGeometry data types are not available in the public SDK
2136         https://bugs.webkit.org/show_bug.cgi?id=137536
2137
2138         Reviewed by David Kilzer.
2139
2140         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
2141         private header.
2142
2143         * DOM/WebDOMOperationsPrivate.h:
2144
2145 2014-11-13  Beth Dakin  <bdakin@apple.com>
2146
2147         WK1: Support default actions for video
2148         https://bugs.webkit.org/show_bug.cgi?id=138713
2149         -and corresponding-
2150         rdar://problem/18877520
2151
2152         Reviewed by Tim Horton.
2153
2154         Call setToNonShadowAncestor() for media HitTestResults.
2155         * WebView/WebActionMenuController.mm:
2156         (-[WebActionMenuController performHitTestAtPoint:]):
2157
2158         Default items and actions.
2159         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
2160         (-[WebActionMenuController _copyVideoURL:]):
2161         (-[WebActionMenuController _saveVideoToDownloads:]):
2162         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2163         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2164         * WebView/WebUIDelegatePrivate.h:
2165
2166 2014-11-13  Tim Horton  <timothy_horton@apple.com>
2167
2168         WK1: Update icon for Add to Reading List
2169         https://bugs.webkit.org/show_bug.cgi?id=138710
2170         <rdar://problem/18975774>
2171
2172         Reviewed by Beth Dakin.
2173
2174         * WebView/WebActionMenuController.mm:
2175         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2176         Use the right icon, matching WebKit2.
2177
2178 2014-11-12  Beth Dakin  <bdakin@apple.com>
2179
2180         WK1: Support default actions for images
2181         https://bugs.webkit.org/show_bug.cgi?id=138668
2182         -and corresponding-
2183         rdar://problem/18785434
2184
2185         Reviewed by Tim Horton.
2186
2187         * WebView/WebActionMenuController.h:
2188         * WebView/WebActionMenuController.mm:
2189         (-[WebActionMenuController didCloseMenu:withEvent:]):
2190         (-[WebActionMenuController _defaultMenuItemsForImage:]):
2191         (-[WebActionMenuController _copyImage:]):
2192         (temporaryPhotosDirectoryPath):
2193         (pathToPhotoOnDisk):
2194         (-[WebActionMenuController _canAddMediaToPhotos]):
2195         (-[WebActionMenuController _addImageToPhotos:]):
2196         (-[WebActionMenuController _saveImageToDownloads:]):
2197         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
2198         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
2199         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2200         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2201         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2202         * WebView/WebUIDelegatePrivate.h:
2203
2204 2014-11-11  Beth Dakin  <bdakin@apple.com>
2205
2206         Action menu hit testing is not working properly with all WK1 apps
2207         https://bugs.webkit.org/show_bug.cgi?id=138643
2208         -and corresponding-
2209         rdar://problem/18949376
2210
2211         Reviewed by Tim Horton.
2212
2213         * WebView/WebActionMenuController.mm:
2214         (-[WebActionMenuController prepareForMenu:withEvent:]):
2215         (-[WebActionMenuController _lookupText:]):
2216
2217 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2218
2219         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
2220         https://bugs.webkit.org/show_bug.cgi?id=138623
2221
2222         Reviewed by Geoff Garen.
2223
2224         * WebCoreSupport/WebSystemInterface.mm:
2225         (InitWebCoreSystemInterface):
2226         * WebKit.order:
2227
2228 2014-11-11  Tim Horton  <timothy_horton@apple.com>
2229
2230         Localize strings for action menus
2231         https://bugs.webkit.org/show_bug.cgi?id=138591
2232         <rdar://problem/18815343>
2233
2234         Reviewed by Dan Bates.
2235
2236         * WebView/WebActionMenuController.mm:
2237         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2238         Make use of the new strings.
2239
2240 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2241
2242         Cleanup from r175379
2243         https://bugs.webkit.org/show_bug.cgi?id=138616
2244
2245         Reviewed by Simon Fraser.
2246
2247         * WebCoreSupport/WebSystemInterface.mm:
2248         (InitWebCoreSystemInterface):
2249         * WebKit.order:
2250
2251 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2252
2253         Move CTFontTransformGlyphs out from WKSI
2254         https://bugs.webkit.org/show_bug.cgi?id=138599
2255
2256         Reviewed by Simon Fraser.
2257
2258         * WebCoreSupport/WebSystemInterface.mm:
2259         (InitWebCoreSystemInterface):
2260         * WebKit.order:
2261
2262 2014-11-11  Dan Bernstein  <mitz@apple.com>
2263
2264         More iOS build fix.
2265
2266         * WebView/WebHTMLViewInternal.h:
2267
2268 2014-11-11  Dan Bernstein  <mitz@apple.com>
2269
2270         iOS build fix.
2271
2272         * WebView/WebHTMLView.mm:
2273
2274 2014-11-10  Beth Dakin  <bdakin@apple.com>
2275
2276         WK1: Support default actions for editable text with misspelled word
2277         https://bugs.webkit.org/show_bug.cgi?id=138590
2278         -and corresponding-
2279         rdar://problem/18877506
2280
2281         Reviewed by Tim Horton.
2282
2283         If there are misspelled word suggestions for editable text, create a new type of 
2284         menu with a spelling suggestion sub-menu.
2285
2286         * WebView/WebActionMenuController.mm:
2287         (-[WebActionMenuController isMenuForTextContent]):
2288         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
2289         (-[WebActionMenuController _changeSelectionToSuggestion:]):
2290         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2291         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2292         * WebView/WebHTMLView.mm:
2293         (-[WebHTMLView _changeSpellingToWord:]):
2294         * WebView/WebHTMLViewInternal.h:
2295         * WebView/WebUIDelegatePrivate.h:
2296
2297 2014-11-10  Beth Dakin  <bdakin@apple.com>
2298
2299         WK1: Support default actions for editable whitespace
2300         https://bugs.webkit.org/show_bug.cgi?id=138586
2301         -and corresponding-
2302         rdar://problem/18932048
2303
2304         Reviewed by Tim Horton.
2305
2306         New menu type. Just wants paste.
2307
2308         * WebView/WebActionMenuController.mm:
2309         (-[WebActionMenuController isMenuForTextContent]):
2310         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
2311         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2312         * WebView/WebUIDelegatePrivate.h:
2313
2314 2014-11-10  Beth Dakin  <bdakin@apple.com>
2315
2316         WK1: Support default actions for editable text
2317         https://bugs.webkit.org/show_bug.cgi?id=138580
2318         -and corresponding-
2319         rdar://problem/18877497
2320
2321         Reviewed by Tim Horton.
2322
2323         New menu type, and new action type for paste. 
2324
2325         * WebView/WebActionMenuController.mm:
2326         (-[WebActionMenuController isMenuForTextContent]):
2327         (-[WebActionMenuController willOpenMenu:withEvent:]):
2328         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
2329         (-[WebActionMenuController _paste:]):
2330         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2331         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2332         * WebView/WebUIDelegatePrivate.h:
2333
2334 2014-11-10  Beth Dakin  <bdakin@apple.com>
2335
2336         WK1: Text is getting selected even when an action menu fails to invoke
2337         https://bugs.webkit.org/show_bug.cgi?id=138576
2338         -and corresponding-
2339         rdar://problem/18931330
2340
2341         Reviewed by Tim Horton.
2342
2343         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
2344         * WebView/WebActionMenuController.h:
2345         * WebView/WebActionMenuController.mm:
2346         (-[WebActionMenuController prepareForMenu:withEvent:]):
2347         (-[WebActionMenuController willOpenMenu:withEvent:]):
2348
2349         _selectLookupText no longer needs to return a BOOL indicating success or failure.
2350         (-[WebActionMenuController _selectLookupText]):
2351         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2352
2353         Pass willOpenMenu: on to the controller.
2354         * WebView/WebView.mm:
2355         (-[WebView willOpenMenu:withEvent:]):
2356
2357 2014-11-10  Beth Dakin  <bdakin@apple.com>
2358
2359         Speculative build fix.
2360
2361         * WebView/WebActionMenuController.mm:
2362
2363 2014-11-10  Beth Dakin  <bdakin@apple.com>
2364
2365         Action menu initialization should be moved to _commonInitializationWithFrameName
2366         https://bugs.webkit.org/show_bug.cgi?id=138572
2367         -and corresponding-
2368         rdar://problem/18929733
2369
2370         Reviewed by Tim Horton.
2371
2372         * WebView/WebView.mm:
2373         (-[WebView _commonInitializationWithFrameName:groupName:]):
2374         (-[WebView _initWithFrame:frameName:groupName:]):
2375
2376 2014-11-10  Beth Dakin  <bdakin@apple.com>
2377
2378         WK1: Support default actions for read-only text
2379         https://bugs.webkit.org/show_bug.cgi?id=138552
2380         -and corresponding-
2381         rdar://problem/18877483
2382
2383         Reviewed by Tim Horton.
2384
2385         New WKSystemInterface functions that WebCore needs to use.
2386         * WebCoreSupport/WebSystemInterface.mm:
2387         (InitWebCoreSystemInterface):
2388
2389         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
2390         makes a lot of things easier.
2391         * WebView/WebActionMenuController.h:
2392         * WebView/WebActionMenuController.mm:
2393
2394         Perform the hit test ourselves instead of calling into WebView so that we can more 
2395         easily save the WebCore::HitTestResult for ourselves.
2396         (-[WebActionMenuController performHitTestAtPoint:]):
2397
2398         Clear selection for non-text menus.
2399         (-[WebActionMenuController prepareForMenu:withEvent:]):
2400
2401         Re-set the _type here just to be safe.
2402         (-[WebActionMenuController didCloseMenu:withEvent:]):
2403
2404         Moving this method to be next to the link actions so they can be within a pragma 
2405         mark.
2406         (-[WebActionMenuController _defaultMenuItemsForLink:]):
2407
2408         New method for default text actions — lookup and copy.
2409         (-[WebActionMenuController _defaultMenuItemsForText:]):
2410         (-[WebActionMenuController _copySelection:]):
2411         (-[WebActionMenuController _lookupText:]):
2412
2413         If there is not already a selection, invoking the action menu on text should 
2414         select the lookup text.
2415         (-[WebActionMenuController _selectLookupText]):
2416         (performDictionaryLookupForSelection):
2417         (performDictionaryLookupForRange):
2418
2419         Handle text now.
2420         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2421         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2422
2423         New enum values.
2424         * WebView/WebUIDelegatePrivate.h:
2425
2426         Pass didCloseMenu on to the controller.
2427         * WebView/WebView.mm:
2428         (-[WebView didCloseMenu:withEvent:]):
2429
2430 2014-11-09  Chris Dumez  <cdumez@apple.com>
2431
2432         Add a more correct way to compare floating point numbers and use it
2433         https://bugs.webkit.org/show_bug.cgi?id=138527
2434
2435         Reviewed by Darin Adler.
2436
2437         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
2438         to compare floating-point numbers.
2439
2440         * WebView/WebHTMLView.mm:
2441         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
2442
2443 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
2444
2445         Delete cookies between tests
2446         https://bugs.webkit.org/show_bug.cgi?id=138528
2447
2448         Reviewed by Sam Weinig.
2449
2450         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
2451         * WebView/WebPreferencesPrivate.h:
2452         Added an SPI for DumpRenderTree.
2453
2454 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
2455
2456         [iOS] Update optimized fullscreen media controls
2457         https://bugs.webkit.org/show_bug.cgi?id=138493
2458
2459         Reviewed by Brent Fulgham.
2460
2461         * WebCoreSupport/WebSystemInterface.mm:
2462         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
2463
2464 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
2465
2466         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
2467         https://bugs.webkit.org/show_bug.cgi?id=138443
2468
2469         Reviewed by Anders Carlsson.
2470
2471         Wrapping the dealloc method in its own autorelease pool avoids the problem of
2472         complex tear-downs leading to the WebView itself being added to an autorelease
2473         pool that is not drained until after the instance has been dealloc'd.
2474  
2475         * WebView/WebView.mm:
2476         (-[WebView dealloc]):
2477
2478 2014-11-05  Jer Noble  <jer.noble@apple.com>
2479
2480         De-templatize Timer
2481         https://bugs.webkit.org/show_bug.cgi?id=138450
2482
2483         Reviewed by Anders Carlsson.
2484
2485         Remove template specifiers from Timer.
2486
2487         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2488         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2489         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2490         * Plugins/WebNetscapePluginStream.h:
2491         * Plugins/WebNetscapePluginStream.mm:
2492         (WebNetscapePluginStream::deliverDataTimerFired):
2493
2494 2014-11-05  Dan Bernstein  <mitz@apple.com>
2495
2496         Remove the unused deletion UI feature
2497         https://bugs.webkit.org/show_bug.cgi?id=138442
2498
2499         Rubber-stamped by Alexey Proskuryakov.
2500
2501         * DefaultDelegates/WebDefaultEditingDelegate.m:
2502         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
2503         * WebCoreSupport/WebEditorClient.h:
2504         * WebCoreSupport/WebEditorClient.mm:
2505         (WebEditorClient::shouldShowDeleteInterface): Deleted.
2506         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
2507         -webView:shouldShowDeleteInterfaceForElement:.
2508
2509 2014-11-03  Dean Jackson  <dino@apple.com>
2510
2511         Add ENABLE_FILTERS_LEVEL_2 feature guard.
2512         https://bugs.webkit.org/show_bug.cgi?id=138362
2513
2514         Reviewed by Tim Horton.
2515
2516         Add a new feature define for Level 2 of CSS Filters.
2517         http://dev.w3.org/fxtf/filters-2/
2518
2519         * Configurations/FeatureDefines.xcconfig:
2520
2521 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
2522
2523         Add button and enable optimized fullscreen.
2524         https://bugs.webkit.org/show_bug.cgi?id=138351
2525
2526         Reviewed by Eric Carlson.
2527
2528         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
2529
2530         * WebCoreSupport/WebSystemInterface.mm:
2531         (InitWebCoreSystemInterface): added
2532
2533 2014-11-04  Chris Dumez  <cdumez@apple.com>
2534
2535         Add ptr() method to Ref class
2536         https://bugs.webkit.org/show_bug.cgi?id=138361
2537
2538         Reviewed by Darin Adler.
2539
2540         Use the new Ref::ptr() method.
2541
2542         * WebView/WebFrame.mm:
2543         (-[WebFrame _setTypingStyle:withUndoAction:]):
2544         * WebView/WebHTMLView.mm:
2545         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
2546         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
2547         * WebView/WebView.mm:
2548         (-[WebView applyStyle:]):
2549
2550 2014-11-04  Darin Adler  <darin@apple.com>
2551
2552         Eliminate ResourceBuffer and use SharedBuffer directly instead
2553         https://bugs.webkit.org/show_bug.cgi?id=138174
2554
2555         Reviewed by Antti Koivisto.
2556
2557         * WebView/WebDataSource.mm:
2558         (-[WebDataSource data]): Use SharedBuffer directly.
2559         * WebView/WebHTMLView.mm:
2560         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2561
2562 2014-11-03  Commit Queue  <commit-queue@webkit.org>
2563
2564         Unreviewed, rolling out r175406, r175413, and r175423.
2565         https://bugs.webkit.org/show_bug.cgi?id=138327
2566
2567         Multipart tests are still broken (Requested by ap on #webkit).
2568
2569         Reverted changesets:
2570
2571         "Eliminate ResourceBuffer and use SharedBuffer directly
2572         instead"
2573         https://bugs.webkit.org/show_bug.cgi?id=138174
2574         http://trac.webkit.org/changeset/175406
2575
2576         "Unreviewed, iOS build fix since 175406."
2577         http://trac.webkit.org/changeset/175413
2578
2579         "Fix assertion in CachedResource::addDataBuffer"
2580         http://trac.webkit.org/changeset/175423
2581
2582 2014-10-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2583
2584         Use std::unique_ptr for TypeCountSet
2585         https://bugs.webkit.org/show_bug.cgi?id=138242
2586
2587         Reviewed by Andreas Kling.
2588
2589         * Misc/WebCoreStatistics.mm:
2590         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr.
2591         (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto.
2592
2593 2014-10-31  Beth Dakin  <bdakin@apple.com>
2594
2595         Use system art for action menus when possible
2596         https://bugs.webkit.org/show_bug.cgi?id=138260
2597
2598         Reviewed by Tim Horton.
2599
2600         * WebView/WebActionMenuController.mm:
2601         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2602
2603 2014-10-30  Darin Adler  <darin@apple.com>
2604
2605         Eliminate ResourceBuffer and use SharedBuffer directly instead
2606         https://bugs.webkit.org/show_bug.cgi?id=138174
2607
2608         Reviewed by Antti Koivisto.
2609
2610         * WebView/WebDataSource.mm:
2611         (-[WebDataSource data]): Use SharedBuffer directly.
2612         * WebView/WebHTMLView.mm:
2613         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2614
2615 2014-10-30  Jer Noble  <jer.noble@apple.com>
2616
2617         [EME] Add Setting for accessing storage location for MediaKeys data
2618         https://bugs.webkit.org/show_bug.cgi?id=138147
2619
2620         Reviewed by Brady Eidson.
2621
2622         * WebView/WebPreferenceKeysPrivate.h:
2623         * WebView/WebPreferences.mm:
2624         (+[WebPreferences initialize]): Set default location.
2625         (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor.
2626         (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter.
2627         * WebView/WebPreferencesPrivate.h:
2628         * WebView/WebView.mm:
2629         (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings.
2630
2631 2014-10-30  Dana Burkart  <dburkart@apple.com>
2632
2633         <rdar://problem/18821260> Prepare for the mysterious future
2634
2635         Reviewed by Lucas Forschler.
2636
2637         * Configurations/Base.xcconfig:
2638         * Configurations/DebugRelease.xcconfig:
2639         * Configurations/FeatureDefines.xcconfig:
2640         * Configurations/Version.xcconfig:
2641
2642 2014-10-28  Jeremy Jones  <jeremyj@apple.com>
2643
2644         Add optimized fullscreen mode.
2645         https://bugs.webkit.org/show_bug.cgi?id=138044
2646
2647         Reviewed by Jer Noble.
2648
2649         Enable different types of fullscreen video behavior.
2650         Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
2651
2652         * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
2653         * WebCoreSupport/WebChromeClient.mm:
2654         (WebChromeClient::enterVideoFullscreenForVideoElement): ditto
2655         * WebView/WebView.mm:
2656         (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
2657         (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.
2658         * WebView/WebViewInternal.h: ditto
2659
2660 2014-10-27  Beth Dakin  <bdakin@apple.com>
2661
2662         Provide a way for WebKit1 clients to override default action menu items
2663         https://bugs.webkit.org/show_bug.cgi?id=138066
2664         -and corresponding-
2665         rdar://problem/18451638
2666
2667         Reviewed by Anders Carlsson.
2668
2669         WebActionMenuController now has an ivar for the WebActionMenuType so that it can 
2670         send that along to clients customizing the menu.
2671         * WebView/WebActionMenuController.h:
2672         * WebView/WebActionMenuController.mm:
2673         (-[WebActionMenuController prepareForMenu:withEvent:]):
2674         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2675
2676         New enum and new SPI to customize menus.
2677         * WebView/WebUIDelegatePrivate.h:
2678
2679 2014-10-24  Benjamin Poulain  <bpoulain@apple.com>
2680
2681         Fix the iOS build
2682
2683         * Configurations/WebKitLegacy.xcconfig:
2684         * WebView/WebView.mm:
2685
2686 2014-10-24  Beth Dakin  <bdakin@apple.com>
2687
2688         Build fix.
2689
2690         * WebView/WebActionMenuController.mm:
2691         (-[WebActionMenuController _openURLFromActionMenu:]):
2692         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2693         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2694
2695 2014-10-24  Beth Dakin  <bdakin@apple.com>
2696
2697         WebKit1 should support action menus
2698         https://bugs.webkit.org/show_bug.cgi?id=138032
2699
2700         Reviewed by Tim Horton.
2701
2702         This patch adds basic support for action menus and adds actions for links.
2703
2704         Helper class takes care of all of the action menu work. WebView will forward the 
2705         prepareForMenu: message, and then the helper class takes it from there.
2706         * WebView/WebActionMenuController.h: Added.
2707         * WebView/WebActionMenuController.mm: Added.
2708         (-[WebActionMenuController webViewClosed]):
2709         (-[WebActionMenuController prepareForMenu:withEvent:]):
2710
2711         Selectors for link actions.
2712         (-[WebActionMenuController _openURLFromActionMenu:]):
2713         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2714         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
2715         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2716         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2717         (webKitBundleImageNamed):
2718         (-[WebActionMenuController _defaultMenuItemsForLink:]):
2719         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2720
2721         Tags for the action menu items.
2722         * WebView/WebUIDelegatePrivate.h:
2723         * WebView/WebView.mm:
2724
2725         Set the action menu if possible and create the controller.
2726         (-[WebView _initWithFrame:frameName:groupName:]):
2727         (-[WebView _close]):
2728         (-[WebView prepareForMenu:withEvent:]):
2729
2730         WebViewData stores the WebActionMenuHelper
2731         * WebView/WebViewData.h:
2732         * WebView/WebViewData.mm:
2733         (-[WebViewPrivate dealloc]):
2734
2735 2014-10-23  Joseph Pecoraro  <pecoraro@apple.com>
2736
2737         Web Inspector: Provide a way to have alternate inspector agents
2738         https://bugs.webkit.org/show_bug.cgi?id=137901
2739
2740         Reviewed by Brian Burg.
2741
2742         * Configurations/FeatureDefines.xcconfig:
2743
2744 2014-10-23  Tim Horton  <timothy_horton@apple.com>
2745
2746         Add some SPI headers for NSExtension and NSSharingService{Picker}
2747         https://bugs.webkit.org/show_bug.cgi?id=138027
2748
2749         Reviewed by Anders Carlsson.
2750
2751         * Misc/WebSharingServicePickerController.h:
2752         * Misc/WebSharingServicePickerController.mm:
2753         * WebCoreSupport/WebSelectionServiceController.mm:
2754         * WebCoreSupport/WebContextMenuClient.mm:
2755         Fix a sorting issue.
2756         Replace redefinitions with SPI header #imports.
2757
2758 2014-10-23  Tim Horton  <timothy_horton@apple.com>
2759
2760         Crashes under WebSelectionServiceController::hasRelevantSelectionServices
2761         https://bugs.webkit.org/show_bug.cgi?id=138013
2762
2763         Reviewed by Dan Bernstein.
2764
2765         * WebCoreSupport/WebSelectionServiceController.mm:
2766         (WebSelectionServiceController::hasRelevantSelectionServices):
2767         Don't adopt this autoreleased object.
2768
2769 2014-10-22  Chris Dumez  <cdumez@apple.com>
2770
2771         [Mac][WK2] Fix applicationIsSafari() detection
2772         https://bugs.webkit.org/show_bug.cgi?id=137893
2773
2774         Reviewed by Alexey Proskuryakov.
2775
2776         Provide an implementation for FrameLoaderClient's new
2777         needsQuickLookResourceCachingQuirks() that returns
2778         a static flag initialized using
2779         QuickLookMac::computeNeedsQuickLookResourceCachingQuirks().
2780
2781         * WebCoreSupport/WebFrameLoaderClient.h:
2782         * WebCoreSupport/WebFrameLoaderClient.mm:
2783
2784 2014-10-20  Chris Dumez  <cdumez@apple.com>
2785
2786         ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition
2787         https://bugs.webkit.org/show_bug.cgi?id=137797
2788
2789         Reviewed by Darin Adler.
2790
2791         Call ResourceRequest::setDomainForPartitionName() instead of
2792         setPartitionName() as the argument is a domain, not a valid
2793         partition name.
2794
2795         * Misc/WebCache.mm:
2796         (+[WebCache addImageToCache:forURL:forFrame:]):
2797         (+[WebCache removeImageFromCacheForURL:forFrame:]):
2798
2799 2014-10-20  Andy Estes  <aestes@apple.com>
2800
2801         Fix the iOS build.
2802
2803         * WebView/WebFrame.mm:
2804         (-[WebFrame getDictationResultRanges:andMetadatas:]):
2805         (-[WebFrame dictationResultMetadataForRange:]):
2806
2807 2014-10-19  Chris Dumez  <cdumez@apple.com>
2808
2809         Use is<>() / downcast<>() for all remaining RenderObject subclasses
2810         https://bugs.webkit.org/show_bug.cgi?id=137845
2811
2812         Reviewed by Darin Adler.
2813
2814         Use is<>() / downcast<>() for all remaining RenderObject subclasses and 
2815         clean up the surrounding code.
2816
2817         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2818         (-[WebHostedNetscapePluginView pluginHostDied]):
2819         * Plugins/WebBaseNetscapePluginView.mm:
2820         (-[WebBaseNetscapePluginView _windowClipRect]):
2821         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
2822         * WebCoreSupport/WebFrameLoaderClient.mm:
2823         (WebFrameLoaderClient::createPlugin):
2824         (WebFrameLoaderClient::createJavaAppletWidget):
2825
2826 2014-10-17  Tim Horton  <timothy_horton@apple.com>
2827
2828         Build fix for 32-bit Yosemite
2829
2830         * WebCoreSupport/WebContextMenuClient.mm:
2831         (WebContextMenuClient::contextMenuForEvent):
2832         Avoid using NSItemProvider in 32-bit, because it doesn't exist.
2833
2834 2014-10-17  Chris Dumez  <cdumez@apple.com>
2835
2836         Use is<>() / downcast<>() for RenderBox
2837         https://bugs.webkit.org/show_bug.cgi?id=137804
2838
2839         Reviewed by Andreas Kling.
2840
2841         Use is<>() / downcast<>() for RenderBox and clean up the surrounding
2842         code.
2843
2844         * WebCoreSupport/WebContextMenuClient.mm:
2845         (WebContextMenuClient::clientFloatRectForNode):
2846         * WebView/WebFrame.mm:
2847         (-[WebFrame renderedSizeOfNode:constrainedToWidth:]):
2848
2849 2014-10-17  Tim Horton  <timothy_horton@apple.com>
2850
2851         Fix the build with the public SDK.
2852
2853         * WebCoreSupport/WebSelectionServiceController.mm:
2854         We should transition all this SPI to real SPI headers as soon as possible.
2855
2856 2014-10-16  Tim Horton  <timothy_horton@apple.com>
2857
2858         Implement selection services menu for Legacy WebKit
2859         https://bugs.webkit.org/show_bug.cgi?id=137582
2860         <rdar://problem/18604241>
2861
2862         Reviewed by Brady Eidson.
2863
2864         * Misc/WebSharingServicePickerController.h:
2865         Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
2866         Add WebSharingServicePickerClient, which other classes can implement
2867         instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
2868         Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.
2869
2870         * Misc/WebSharingServicePickerController.mm:
2871         Pass in NSSharingServicePickerStyle, so that clients can specify the style.
2872
2873         (-[WebSharingServicePickerController clear]):
2874         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
2875         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
2876         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
2877         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
2878         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2879         Make use of WebSharingServicePickerClient.
2880
2881         (-[WebSharingServicePickerController sharingService:didShareItems:]):
2882         If we're returned a NSAttributedString, paste it on top of the current selection,
2883         similar to what the WebKit2 implementation currently does.
2884         
2885         * WebCoreSupport/WebChromeClient.h:
2886         * WebCoreSupport/WebChromeClient.mm:
2887         (WebChromeClient::handleTelephoneNumberClick):
2888         (WebChromeClient::handleSelectionServiceClick):
2889         (WebChromeClient::hasRelevantSelectionServices):
2890         Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.
2891
2892         * WebCoreSupport/WebContextMenuClient.h:
2893         * WebCoreSupport/WebContextMenuClient.mm:
2894         (WebContextMenuClient::sharingServicePickerWillBeDestroyed):
2895         (WebContextMenuClient::pageForSharingServicePicker):
2896         (WebContextMenuClient::windowForSharingServicePicker):
2897         (WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
2898         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
2899         (WebContextMenuClient::contextMenuForEvent):
2900         (WebContextMenuClient::screenRectForHitTestNode): Deleted.
2901         (WebContextMenuClient::renderedImageForControlledImage): Deleted.
2902         (WebContextMenuClient::clearSharingServicePickerController): Deleted.
2903         Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
2904         having WebSharingServicePickerController tightly bound to it.
2905         Make an NSItemProvider array when instantiating WebSharingServicePickerController
2906         instead of handing it data directly.
2907
2908         * WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
2909         * WebCoreSupport/WebSelectionServiceController.mm: Added.
2910         (WebSelectionServiceController::WebSelectionServiceController):
2911         Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
2912         for selection services.
2913
2914         (WebSelectionServiceController::handleSelectionServiceClick):
2915         Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.
2916
2917         (hasCompatibleServicesForItems):
2918         (WebSelectionServiceController::hasRelevantSelectionServices):
2919         Determine whether or not services are available.
2920
2921         (WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
2922         (WebSelectionServiceController::pageForSharingServicePicker):
2923         (WebSelectionServiceController::windowForSharingServicePicker):
2924         Implement the rest of the WebSharingServicePickerClient overrides.
2925
2926         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
2927         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
2928         These are only useful for image sharing services, so we don't need to
2929         implement them (WebContextMenuClient does, on the other hand).
2930
2931         * WebView/WebView.mm:
2932         (-[WebView _selectionServiceController]):
2933         * WebView/WebViewData.h:
2934         * WebView/WebViewData.mm:
2935         * WebView/WebViewInternal.h:
2936         Keep a WebSelectionServiceController.
2937
2938 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2939
2940         Improve debug description of WAKViews
2941         https://bugs.webkit.org/show_bug.cgi?id=137716
2942
2943         Reviewed by Simon Fraser.
2944
2945         * WebView/WebView.mm:
2946         (-[WebView _touchEventRegions]): Adding a comment.
2947
2948 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2949
2950         Addressing post-review comment.
2951         https://bugs.webkit.org/show_bug.cgi?id=137550
2952
2953         Unreviewed.
2954
2955         * WebView/WebHTMLView.mm:
2956         (fontNameForDescription):
2957         (-[WebHTMLView _addToStyle:fontA:fontB:]):
2958
2959 2014-10-14  Chris Dumez  <cdumez@apple.com>
2960
2961         Use is<>() / downcast<>() for RenderImage
2962         https://bugs.webkit.org/show_bug.cgi?id=137683
2963
2964         Reviewed by Mihnea Ovidenie.
2965
2966         Use is<>() / downcast<>() for RenderImage.
2967
2968         * Misc/WebNSPasteboardExtras.mm:
2969         (imageFromElement):
2970         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2971
2972 2014-10-10  Daniel Bates  <dabates@apple.com>
2973
2974         Remove unused classes WebRender{Node, Layer}
2975         https://bugs.webkit.org/show_bug.cgi?id=137628
2976
2977         Reviewed by Simon Fraser.
2978
2979         We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
2980         For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.
2981
2982         * Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list
2983         of excluded source files when building for iOS.
2984         * WebKit.exp: Remove symbol for WebRenderLayer.
2985         * WebKit.mac.exp: Remove symbol for WebRenderNode.
2986         * WebView/WebRenderLayer.h: Removed.
2987         * WebView/WebRenderLayer.mm: Removed.
2988         * WebView/WebRenderNode.h: Removed.
2989         * WebView/WebRenderNode.mm: Removed.
2990
2991 2014-10-10  Chris Dumez  <cdumez@apple.com>
2992
2993         Use is<>() / downcast<>() for RenderBoxModelObject
2994         https://bugs.webkit.org/show_bug.cgi?id=137587
2995
2996         Reviewed by Mihnea Ovidenie.
2997
2998         Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
2999         surrounding code.
3000
3001         * Plugins/WebBaseNetscapePluginView.mm:
3002         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
3003         * WebView/WebRenderLayer.mm:
3004         (-[WebRenderLayer initWithWebFrame:]):
3005
3006 2014-10-09  Dean Jackson  <dino@apple.com>
3007
3008         Remove ENABLE_CSS3_CONDITIONAL_RULES
3009         https://bugs.webkit.org/show_bug.cgi?id=137571
3010
3011         Reviewed by Simon Fraser.
3012
3013         * Configurations/FeatureDefines.xcconfig:
3014
3015 2014-10-09  Tim Horton  <timothy_horton@apple.com>
3016
3017         Add a WebKit1 preference for selection services
3018         https://bugs.webkit.org/show_bug.cgi?id=137498
3019         <rdar://problem/18572699>
3020
3021         Reviewed by Simon Fraser.
3022
3023         * WebView/WebPreferenceKeysPrivate.h:
3024         * WebView/WebPreferences.mm:
3025         (+[WebPreferences initialize]):
3026         (-[WebPreferences serviceControlsEnabled]):
3027         (-[WebPreferences setServiceControlsEnabled:]):
3028         * WebView/WebPreferencesPrivate.h:
3029         * WebView/WebView.mm:
3030         (-[WebView _preferencesChanged:]):
3031         Add and plumb the preference.
3032
3033 2014-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
3034
3035         Remove second-to-last client of WebFontCache
3036         https://bugs.webkit.org/show_bug.cgi?id=137550
3037
3038         Reviewed by Darin Adler.
3039
3040         Use FontCache::getCachedFontData() instead of WebFontCache.
3041
3042         * WebView/WebHTMLView.mm:
3043         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3044
3045 2014-10-09  Chris Dumez  <cdumez@apple.com>
3046
3047         Use is<>() / downcast<>() for Widget subclasses
3048         https://bugs.webkit.org/show_bug.cgi?id=137549
3049
3050         Reviewed by Darin Adler.
3051
3052         Use is<>() / downcast<>() for Widget subclasses and clean up the
3053         surrounding code.
3054
3055         * WebView/WebRenderNode.mm:
3056         (copyRenderNode):
3057         * WebView/WebView.mm:
3058         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
3059
3060 2014-10-07  Christophe Dumez  <cdumez@apple.com>
3061
3062         Use is<>() / downcast<>() for RenderText / RenderTextFragment
3063         https://bugs.webkit.org/show_bug.cgi?id=137476
3064
3065         Reviewed by Darin Adler.
3066
3067         * WebView/WebRenderNode.mm:
3068         (copyRenderNode):
3069
3070 2014-10-06  Dan Bernstein  <mitz@apple.com>
3071
3072         Build fix.
3073
3074         * Misc/WebCache.mm:
3075         (+[WebCache imageForURL:]):
3076
3077 2014-10-06  Chris Dumez  <cdumez@apple.com>
3078
3079         Unreviewed build fix after r174333.
3080
3081         Forgot explicit WebCore:: namespace.
3082
3083         * Misc/WebCache.mm:
3084         (+[WebCache imageForURL:]):
3085
3086 2014-10-05  Christophe Dumez  <cdumez@apple.com>
3087
3088         Use is<>() / downcast<>() for CachedResource subclasses
3089         https://bugs.webkit.org/show_bug.cgi?id=137431
3090
3091         Reviewed by Benjamin Poulain.
3092
3093         Use is<>() / downcast<>() for CachedResource subclasses.
3094
3095         * Misc/WebCache.mm:
3096         (+[WebCache imageForURL:]):
3097
3098 2014-10-02  Daniel Bates  <dabates@apple.com>
3099
3100         Use version number 101000 instead of 10100 for OS X Yosemite
3101         https://bugs.webkit.org/show_bug.cgi?id=137372
3102
3103         Reviewed by Mark Rowe.
3104
3105         The version number for OS X Yosemite is 101000.
3106
3107         * WebView/WebView.mm:
3108         (-[WebView _preferencesChanged:]):
3109
3110 2014-10-02  Tim Horton  <timothy_horton@apple.com>
3111
3112         Move PageOverlay[Controller] to WebCore
3113         https://bugs.webkit.org/show_bug.cgi?id=137164
3114         <rdar://problem/18508258>
3115
3116         Reviewed by Anders Carlsson.
3117
3118         * WebCoreSupport/WebChromeClient.h:
3119         * WebCoreSupport/WebChromeClient.mm:
3120         (WebChromeClient::attachViewOverlayGraphicsLayer):
3121         Add an empty ChromeClient override.
3122
3123 2014-10-01  Christophe Dumez  <cdumez@apple.com>
3124
3125         Have is<>(T*) function do a null check on the pointer argument
3126         https://bugs.webkit.org/show_bug.cgi?id=137333
3127
3128         Reviewed by Gavin Barraclough.
3129
3130         Have is<>(T*) function do a null check on the argument instead of a
3131         simple assertion. This makes sense for 2 reasons:
3132         1. It is more consistent with downcast<>(T*), which will succeed even
3133            if the argument is a nullptr.
3134         2. It simplifies the code a bit as it gets rid of a lot of explicit
3135            null checks.
3136
3137         * WebCoreSupport/WebChromeClient.mm:
3138         (WebChromeClient::focusedElementChanged):
3139         * WebCoreSupport/WebEditorClient.mm:
3140         (WebEditorClient::textFieldDidBeginEditing):
3141         (WebEditorClient::textFieldDidEndEditing):
3142         (WebEditorClient::textDidChangeInTextField):
3143         (WebEditorClient::doTextFieldCommandFromEvent):
3144         (WebEditorClient::textWillBeDeletedInTextField):
3145         (WebEditorClient::textDidChangeInTextArea):
3146         * WebView/WebHTMLRepresentation.mm:
3147         (inputElementFromDOMElement):
3148         (searchForLabelsBeforeElement):
3149         * WebView/WebRenderLayer.mm:
3150         (+[WebRenderLayer nameForLayer:]):
3151
3152 2014-10-01  Mark Rowe  <mrowe@apple.com>
3153
3154         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
3155
3156         Reviewed by Dan Bernstein.
3157
3158         * Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite.
3159
3160 2014-09-30  Chris Dumez  <cdumez@apple.com>
3161
3162         Use is<>() / downcast<>() for Element
3163         https://bugs.webkit.org/show_bug.cgi?id=137241
3164
3165         Reviewed by Andreas Kling.
3166
3167         Use is<>() / downcast<>() for Element instead of isElementNode() /
3168         toElement().
3169
3170         * WebView/WebRenderLayer.mm:
3171         (+[WebRenderLayer nameForLayer:]):
3172
3173 2014-09-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3174
3175         Move ColorInputType class to std::unique_ptr
3176         https://bugs.webkit.org/show_bug.cgi?id=137173
3177
3178         Reviewed by Darin Adler.
3179
3180         Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr.
3181         Child classes follow this change as well.
3182
3183         * WebCoreSupport/WebChromeClient.h:
3184         * WebCoreSupport/WebChromeClient.mm:
3185         (WebChromeClient::createColorChooser):
3186
3187 2014-09-24  Christophe Dumez  <cdumez@apple.com>
3188
3189         Add initial is<>() / downcast<>() support for any type of Nodes
3190         https://bugs.webkit.org/show_bug.cgi?id=137056
3191
3192         Reviewed by Benjamin Poulain.
3193
3194         Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
3195         instead of isFormControlElement() / toHTMLFormControlElement().
3196
3197         * WebView/WebHTMLRepresentation.mm:
3198         (searchForLabelsBeforeElement):
3199
3200 2014-09-24  Christophe Dumez  <cdumez@apple.com>
3201
3202         Use is<HTML*Element>() instead of isHTML*Element() - Part 1
3203         https://bugs.webkit.org/show_bug.cgi?id=137068
3204
3205         Reviewed by Ryosuke Niwa.
3206
3207         Start using is<HTML*Element>() instead of isHTML*Element().
3208         Remaining usages will be updated in a follow-up patch to
3209         reduce the size of the change.
3210
3211         * WebCoreSupport/WebChromeClient.mm:
3212         (WebChromeClient::focusedElementChanged):
3213         * WebCoreSupport/WebEditorClient.mm:
3214         (WebEditorClient::textFieldDidBeginEditing):
3215         (WebEditorClient::textFieldDidEndEditing):
3216         (WebEditorClient::textDidChangeInTextField):
3217         (WebEditorClient::doTextFieldCommandFromEvent):
3218         (WebEditorClient::textWillBeDeletedInTextField):
3219         (WebEditorClient::textDidChangeInTextArea):
3220         * WebView/WebHTMLRepresentation.mm:
3221         (inputElementFromDOMElement):
3222
3223 2014-09-21  Timothy Hatcher  <timothy@apple.com>
3224
3225         Make the Web Inspector use a separate web process.
3226
3227         https://bugs.webkit.org/show_bug.cgi?id=135120
3228
3229         Reviewed by Anders Carlsson.
3230
3231         * WebCoreSupport/WebInspectorClient.h:
3232         * WebCoreSupport/WebInspectorClient.mm:
3233         (WebInspectorClient::WebInspectorClient):
3234         (WebInspectorClient::openInspectorFrontend):
3235         (WebInspectorClient::releaseFrontend):
3236         Own WebInspectorFrontendClient instead of moving it.
3237
3238 2014-09-23  Chris Dumez  <cdumez@apple.com>
3239
3240         Use downcast<HTML*Element>() instead of toHTML*Element()
3241         https://bugs.webkit.org/show_bug.cgi?id=137007
3242
3243         Reviewed by Benjamin Poulain.
3244
3245         Use downcast<HTML*Element>() instead of toHTML*Element().
3246
3247         * DOM/WebDOMOperations.mm:
3248         (-[DOMHTMLInputElement _setAutofilled:]):
3249         * WebCoreSupport/WebChromeClient.mm:
3250         (WebChromeClient::focusedElementChanged):
3251         * WebCoreSupport/WebEditorClient.mm:
3252         (WebEditorClient::textFieldDidBeginEditing):
3253         (WebEditorClient::textFieldDidEndEditing):
3254         (WebEditorClient::textDidChangeInTextField):
3255         (WebEditorClient::doTextFieldCommandFromEvent):
3256         (WebEditorClient::textWillBeDeletedInTextField):
3257         (WebEditorClient::textDidChangeInTextArea):
3258         * WebView/WebHTMLRepresentation.mm:
3259         (inputElementFromDOMElement):
3260
3261 2014-09-21  Chris Dumez  <cdumez@apple.com>
3262
3263         Generate Element casting helper functions
3264         https://bugs.webkit.org/show_bug.cgi?id=136839
3265
3266         Reviewed by Darin Adler.
3267
3268         Use JSXXX::toWrapped() instead of toXXX() function.
3269
3270         * DOM/WebDOMOperations.mm:
3271         * WebView/WebView.mm:
3272         (-[WebView _notificationIDForTesting:]):
3273
3274 2014-09-21  Joseph Pecoraro  <pecoraro@apple.com>
3275
3276         Leak: WebNotificationPrivate ObjC leaks seen on leaks bot
3277         https://bugs.webkit.org/show_bug.cgi?id=136972
3278
3279         Reviewed by Darin Adler.
3280
3281         * WebView/WebNotification.h:
3282         * WebView/WebNotification.mm:
3283         (-[WebNotification initWithCoreNotification:notificationID:]):
3284         Switch to RetainPtr and adopt into _private to ensure when we are
3285         deallocated that _private will get deallocated.
3286
3287 2014-09-19  Dean Jackson  <dino@apple.com>
3288
3289         Multithreaded WebGL is a bad idea - remove it
3290         https://bugs.webkit.org/show_bug.cgi?id=136964
3291         <rdar://problem/18399858>
3292
3293         Reviewed by Brent Fulgham.
3294
3295         Remove the setting to allow multithreaded WebGL.
3296
3297         * WebView/WebPreferenceKeysPrivate.h:
3298         * WebView/WebPreferences.mm:
3299         (+[WebPreferences initialize]):
3300         (-[WebPreferences multithreadedWebGLEnabled]): Deleted.
3301         (-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted.
3302         * WebView/WebPreferencesPrivate.h:
3303         * WebView/WebView.mm:
3304         (-[WebView _preferencesChanged:]):
3305
3306 2014-09-19  Daniel Bates  <dabates@apple.com>
3307
3308         Always assume internal SDK when building configuration Production
3309         https://bugs.webkit.org/show_bug.cgi?id=136925
3310         <rdar://problem/18362399>
3311
3312         Reviewed by Dan Bernstein.
3313
3314         As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
3315         and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.
3316
3317         * Configurations/Base.xcconfig:
3318
3319 2014-09-17  Daniel Bates  <dabates@apple.com>
3320
3321         Unreviewed, rolling out r173695.
3322
3323         Broke building third-party Legacy WebKit apps; will
3324         investigate offline
3325
3326         Reverted changeset:
3327
3328         "[iOS] Make WebCore build with public iOS SDK"
3329         https://bugs.webkit.org/show_bug.cgi?id=136487
3330         http://trac.webkit.org/changeset/173695
3331
3332 2014-09-17  Daniel Bates  <dabates@apple.com>
3333
3334         [iOS] Make WebCore build with public iOS SDK
3335         https://bugs.webkit.org/show_bug.cgi?id=136487
3336
3337         Reviewed by David Kilzer.
3338
3339         Update WebKit1 source files to include the wrapper SPI headers instead of the corresponding
3340         actual SPI header(s).
3341
3342         * DOM/WebDOMOperationsPrivate.h:
3343         * MigrateHeaders.make: Modified to only modify the include path of a "<WebCore/"-prefixed header
3344         file if its filename doesn't end in "SPI.h" as an alternative to having MigrateHeaders.make copy
3345         such files into the WebKit framework as private headers.
3346         * WebCoreSupport/WebFrameLoaderClient.mm:
3347         * WebInspector/WebNodeHighlight.mm:
3348         * WebView/WebIndicateLayer.mm:
3349         * WebView/WebRenderLayer.h:
3350         * WebView/WebView.mm:
3351
3352 2014-09-16  Daniel Bates  <dabates@apple.com>
3353
3354         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
3355         https://bugs.webkit.org/show_bug.cgi?id=136862
3356
3357         Reviewed by David Kilzer.
3358
3359         * Configurations/DebugRelease.xcconfig:
3360
3361 2014-09-16  Enrica Casucci  <enrica@apple.com>
3362
3363         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
3364         https://bugs.webkit.org/show_bug.cgi?id=136474
3365
3366         Reviewed by Benjamin Poulain.
3367
3368         This is the updated version of the patch that was landed in r173340.
3369         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
3370         and removes the assumption that EAffinity values match NSSelectionAffinity
3371         values. It also removes the includes in TextAffinity.h, creating the need to
3372         include explicitly the files when necessary.
3373
3374         * WebCoreSupport/WebEditorClient.h:
3375         (kit):
3376         (core):
3377
3378 2014-09-14  Daniel Bates  <dabates@apple.com>
3379
3380         [iOS] Attempt to fix the iOS build after <http://trac.webkit.org/changeset/173606>
3381         (https://bugs.webkit.org/show_bug.cgi?id=136789)
3382
3383         Substitute Node::countChildNodes() for Node::childNodeCount() in more places.
3384
3385         * WebView/WebFrame.mm:
3386         (-[WebFrame focusedNodeHasContent]):
3387
3388 2014-09-14  Chris Dumez  <cdumez@apple.com>
3389
3390         Rename Node::childNodeCount() to countChildNodes() and avoid inefficient uses
3391         https://bugs.webkit.org/show_bug.cgi?id=136789
3392
3393         Reviewed by Darin Adler.
3394
3395         Rename childNodeCount() to countChildNodes().
3396
3397         * WebView/WebHTMLView.mm:
3398         (-[WebHTMLView attributedString]):
3399
3400 2014-09-10  Jon Honeycutt  <jhoneycutt@apple.com>
3401
3402         Re-add the request autocomplete feature
3403
3404         <https://bugs.webkit.org/show_bug.cgi?id=136730>
3405
3406         This feature was rolled out in r148731 because it was only used by
3407         Chromium. As we consider supporting this feature, roll it back in, but
3408         leave it disabled.
3409
3410         This rolls out r148731 (which removed the feature) with small changes
3411         needed to make the code build in ToT, to match modern style, to make
3412         the tests run, and to remove unused code.
3413
3414         Reviewed by Andy Estes.
3415
3416         * Configurations/FeatureDefines.xcconfig:
3417         * WebCoreSupport/WebFrameLoaderClient.h:
3418
3419 2014-09-12  Commit Queue  <commit-queue@webkit.org>
3420
3421         Unreviewed, rolling out r173575.
3422         https://bugs.webkit.org/show_bug.cgi?id=136790
3423
3424         Failing tests (Requested by enrica on #webkit).
3425
3426         Reverted changeset:
3427
3428         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
3429         https://bugs.webkit.org/show_bug.cgi?id=136474
3430         http://trac.webkit.org/changeset/173575
3431
3432 2014-09-12  Enrica Casucci  <enrica@apple.com>
3433
3434         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
3435         https://bugs.webkit.org/show_bug.cgi?id=136474
3436
3437         Reviewed by Benjamin Poulain.
3438
3439         This is the updated version of the patch that was landed in r173340.
3440         I changed the use of IntPoint to FloatPoint since it was causing tests
3441         to fail.
3442         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
3443         and removes the assumption that EAffinity values match NSSelectionAffinity
3444         values. It also removes the includes in TextAffinity.h, creating the need to
3445         include explicitly the files when necessary. It also removes the unnecessary
3446         use of platform specific types, replacing them with WebCore types.
3447
3448         * WebCoreSupport/WebEditorClient.h:
3449         (kit):
3450         (core):
3451         * WebView/WebFrameView.mm:
3452         (-[WebFrameView _scrollToBeginningOfDocument]):
3453         (-[WebFrameView _scrollToEndOfDocument]):
3454
3455 2014-09-11  Bear Travis  <betravis@adobe.com>
3456
3457         [CSS Font Loading] Enable CSS Font Loading on Mac
3458         https://bugs.webkit.org/show_bug.cgi?id=135473
3459
3460         Reviewed by Antti Koivisto.
3461
3462         Enable CSS Font Loading in FeatureDefines.
3463
3464         * Configurations/FeatureDefines.xcconfig:
3465
3466 2014-09-11  Beth Dakin  <bdakin@apple.com>
3467
3468         Support rubber-banding in sub-frames
3469         https://bugs.webkit.org/show_bug.cgi?id=136726
3470         -and corresponding-
3471         rdar://problem/10011924
3472
3473         Reviewed by Tim Horton.
3474
3475         rubberBandingForOverflowScrollEnabled is re-named to
3476         rubberBandingForSubScrollableRegionsEnabled
3477         * WebView/WebView.mm:
3478         (-[WebView _preferencesChanged:]):
3479
3480 2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
3481
3482         Disable the "unreachable-code" warning
3483         https://bugs.webkit.org/show_bug.cgi?id=136677
3484
3485         Reviewed by Darin Adler.
3486
3487         * Configurations/Base.xcconfig:
3488
3489 2014-09-08  Maciej Stachowiak  <mjs@apple.com>
3490
3491         Fix 32-bit Mac build for new warnings
3492         https://bugs.webkit.org/show_bug.cgi?id=136624
3493
3494         Reviewed by Darin Adler.
3495         
3496         (Jessie already fixed this but my version with typedefs seems a tiny bit cleaner.)
3497
3498         * Carbon/HIViewAdapter.m:
3499         (+[HIViewAdapter bindHIViewToNSView:nsView:]): Need to use explicit casting now.
3500
3501 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3502
3503         Remove FILTERS flag
3504         https://bugs.webkit.org/show_bug.cgi?id=136571
3505
3506         Reviewed by Darin Adler.
3507
3508         * Configurations/FeatureDefines.xcconfig:
3509
3510 2014-09-08  Jessie Berlin  <jberlin@apple.com>
3511
3512         32-bit build fix after r173364.
3513
3514         * Carbon/HIViewAdapter.m:
3515         (+[HIViewAdapter bindHIViewToNSView:nsView:]):
3516
3517 2014-09-08  Dan Bernstein  <mitz@apple.com>
3518
3519         Build fix.
3520
3521         Added back SPI that is still in use.
3522
3523         * Misc/WebNSURLExtras.h:
3524         * Misc/WebNSURLExtras.mm:
3525         (-[NSURL _webkit_URLByRemovingFragment]):
3526
3527 2014-09-08  Dan Bernstein  <mitz@apple.com>
3528
3529         iOS Simulator build fix.
3530
3531         * Misc/WebKitSystemBits.m:
3532         (WebMemorySize):
3533
3534 2014-09-07  Darin Adler  <darin@apple.com>
3535
3536         Fix build failure seen on Mountain Lion buildbot.
3537
3538         * Misc/WebNSDataExtras.h: Make WEB_GUESS_MIME_TYPE_PEEK_LENGTH an unsigned instead
3539         of an int, to avoid warning about mixing signs.
3540
3541 2014-09-06  Darin Adler  <darin@apple.com>
3542
3543         Make updates suggested by new version of Xcode
3544         https://bugs.webkit.org/show_bug.cgi?id=136603
3545
3546         Reviewed by Mark Rowe.
3547
3548         * Configurations/Base.xcconfig: Added CLANG_WARN_UNREACHABLE_CODE, COMBINE_HIDPI_IMAGES,
3549         and ENABLE_STRICT_OBJC_MSGSEND as suggested by Xcode upgrade check.
3550
3551         * History/WebURLsWithTitles.m:
3552         (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): Use NSUInteger instead of
3553         unsigned for correctness, and to quiet the 32-to-64-bit compiler warning (which is
3554         not turned on because it gives us too many false positives).
3555         * Misc/WebElementDictionary.mm:
3556         (-[WebElementDictionary objectForKey:]): Ditto.
3557         * Misc/WebNSDataExtras.m:
3558         (-[NSData _webkit_guessedMIMETypeForXML]): Ditto.
3559         (-[NSData _webkit_guessedMIMEType]): Ditto.
3560         (-[NSData _webkit_parseRFC822HeaderFields]): Ditto.
3561         (-[NSData _web_locationAfterFirstBlankLine]): Ditto.
3562
3563         * Misc/WebNSURLExtras.h: Removed unused _web_URLWithLowercasedScheme, _web_hostData,
3564         _webkit_URLByRemovingFragment, _webkit_URLByRemovingResourceSpecifier, _webkit_isFTPDirectoryURL,
3565         _webkit_shouldLoadAsEmptyDocument, _web_hostNameNeedsDecodingWithRange:,
3566         _web_hostNameNeedsEncodingWithRange:, _web_decodeHostNameWithRange:, _web_encodeHostNameWithRange:,
3567         and _webkit_URLFragment methods.
3568
3569         * Misc/WebNSURLExtras.mm:
3570         (-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): Deleted.
3571         (-[NSURL _webkit_URLByRemovingFragment]): Deleted.
3572         (-[NSURL _webkit_URLByRemovingResourceSpecifier]): Deleted.
3573         (-[NSURL _webkit_isFTPDirectoryURL]): Deleted.
3574         (-[NSURL _webkit_shouldLoadAsEmptyDocument]): Deleted.
3575         (-[NSURL _web_URLWithLowercasedScheme]): Deleted.
3576         (-[NSString _webkit_isFTPDirectoryURL]): Deleted.
3577         (-[NSString _web_hostNameNeedsDecodingWithRange:]): Deleted.
3578         (-[NSString _web_hostNameNeedsEncodingWithRange:]): Deleted.
3579         (-[NSString _web_decodeHostNameWithRange:]): Deleted.
3580         (-[NSString _web_encodeHostNameWithRange:]): Deleted.
3581         (-[NSString _webkit_URLFragment]): Deleted.
3582
3583         * Plugins/WebPluginDatabase.mm:
3584         (-[WebPluginDatabase removePluginInstanceViewsFor:]): Use a modern for loop
3585         to iterate an array instead of a loop using the type "unsigned int".
3586
3587         * WebCoreSupport/WebOpenPanelResultListener.mm:
3588         (-[WebOpenPanelResultListener chooseFilenames:]): Use NSUInteger instead of int.
3589
3590         * WebView/WebDelegateImplementationCaching.mm:
3591         (CallDelegate): Use wtfCallIMP in one overload that was instead just calling the
3592         directly without a proper type for the function pointer. This might have been causing
3593         an actual problem on 64-bit systems, and it was different from all the other CallDelegate
3594         functions that were already doing this correctly.
3595
3596         * WebView/WebTextCompletionController.mm:
3597         (-[WebTextCompletionController _placePopupWindow:]): Use NSUInteger instead of int.
3598
3599 2014-09-06  Brian J. Burg  <burg@cs.washington.edu>
3600
3601         Web Inspector: convert DockSide to an enum class
3602         https://bugs.webkit.org/show_bug.cgi?id=136601
3603
3604         Reviewed by Timothy Hatcher.
3605
3606         * WebCoreSupport/WebInspectorClient.mm:
3607         (WebInspectorFrontendClient::frontendLoaded):
3608         (-[WebInspectorWindowController attachWindow:]):
3609         (-[WebInspectorWindowController attach]):
3610         (-[WebInspectorWindowController detach]):
3611         * WebInspector/WebInspectorFrontend.mm:
3612         (-[WebInspectorFrontend attach]):
3613
3614 2014-09-05  Commit Queue  <commit-queue@webkit.org>
3615
3616         Unreviewed, rolling out r173340 and r173342.
3617         https://bugs.webkit.org/show_bug.cgi?id=136596
3618
3619         Broke many tests (Requested by ap on #webkit).
3620
3621         Reverted changesets:
3622
3623         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
3624         https://bugs.webkit.org/show_bug.cgi?id=136474
3625         http://trac.webkit.org/changeset/173340
3626
3627         "Build fix after r173340."
3628         http://trac.webkit.org/changeset/173342
3629
3630 2014-09-05  Enrica Casucci  <enrica@apple.com>
3631
3632         Build fix after r173340.
3633
3634         * WebCoreSupport/WebEditorClient.h:
3635         (kit):
3636         (core):
3637
3638 2014-09-05  Enrica Casucci  <enrica@apple.com>
3639
3640         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
3641         https://bugs.webkit.org/show_bug.cgi?id=136474
3642
3643         Reviewed by Benjamin Poulain.
3644
3645         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
3646         and removes the assumption that EAffinity values match NSSelectionAffinity
3647         values. It also removes the includes in TextAffinity.h, creating the need to
3648         include explicitly the files when necessary. It also removes the unnecessary
3649         use of platform specific types, replacing them with WebCore types.
3650
3651         * WebCoreSupport/WebEditorClient.h: Added kit and core for EAffinity.
3652         * WebView/WebFrameView.mm:
3653         (-[WebFrameView _scrollToBeginningOfDocument]):
3654         (-[WebFrameView _scrollToEndOfDocument]):
3655
3656 2014-09-05  Daniel Bates  <dabates@apple.com>
3657
3658         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
3659         (https://bugs.webkit.org/show_bug.cgi?id=136564)
3660
3661         Move #endif inside -viewDidMoveToWindow up one line such that the closing brace ('}') is after it.
3662
3663         * WebView/WebHTMLView.mm:
3664         (-[WebHTMLView viewDidMoveToWindow]):
3665
3666 2014-09-05  Daniel Bates  <dabates@apple.com>
3667
3668         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
3669         (https://bugs.webkit.org/show_bug.cgi?id=136564)
3670
3671         Add !PLATFORM(IOS)-guard in -viewDidMoveToWindow around code that references WebHTMLViewPrivate.flagsChangedEventMonitor.
3672         The instance variable WebHTMLViewPrivate.flagsChangedEventMonitor is guarded by !PLATFORM(IOS).
3673
3674         * WebView/WebHTMLView.mm:
3675         (-[WebHTMLView viewDidMoveToWindow]):
3676
3677 2014-09-05  Daniel Bates  <dabates@apple.com>
3678
3679         [iOS] Fix the iOS build after <http://trac.webkit.org/changeset/173309>
3680         (https://bugs.webkit.org/show_bug.cgi?id=136564)
3681
3682         Include more code inside the !PLATFORM(IOS)-guarded section in -setDataSource:.
3683
3684         * WebView/WebHTMLView.mm:
3685         (-[WebHTMLView setDataSource:]):
3686
3687 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
3688
3689         Use tracking areas instead of (SPI) mouse moved notifications, and follow flags changes with an event monitor
3690         https://bugs.webkit.org/show_bug.cgi?id=136564
3691
3692         Reviewed by Dan Bernstein.
3693         
3694         WebKit1 depended on mouse moved event notifications to track mouse
3695         moves, and on being specially called by Safari to track flags
3696         changes. WebKit2 does both these things better - it uses a tracking area
3697         and event monitors. Copy those approaches.
3698
3699         * WebKit.order: Remove reference to obsolete call.
3700         * WebView/WebHTMLView.mm:
3701         (-[WebHTMLViewPrivate dealloc]): No need to deallocate tracking
3702         area, since we now just always have one.
3703         (-[WebHTMLViewPrivate clear]): ditto
3704         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
3705         New method that posts a fake mouse move event in response to
3706         a flags change event, for use by the event monitor.
3707         (+[WebHTMLView _postFlagsChangedEvent:]): Empty this old call,
3708         still kept around for benefit of older Safari.
3709         (-[WebHTMLView _updateMouseoverWithEvent:]): Handle Dashboard's
3710         special mouseover mode (previously handled in a weird way).
3711         (-[WebHTMLView close]): No more need to mess with mouse moved observer.
3712         (-[WebHTMLView viewWillMoveToWindow:]): ditto
3713         (-[WebHTMLView viewDidMoveToWindow]): ditto; but now hook up a flags
3714         changed monitor.
3715         (-[WebHTMLView windowDidBecomeKey:]): No need to handle non-key window
3716         tracking area or mouse moved observer.
3717         (-[WebHTMLView windowDidResignKey:]): ditto
3718         (-[WebHTMLView windowWillOrderOnScreen:]): No need to mess with mouse
3719         moved observer.
3720         (-[WebHTMLView windowWillOrderOffScreen:]): ditto
3721         (-[WebHTMLView mouseMoved:]): Converted from the old mouseMovedNotification:
3722         (-[WebHTMLView setDataSource:]): Change if around body to early return. Hook
3723         up tracking area - we have to do it here, because before this point, the
3724         WebHTMLView does not know its WebView, which is where dashboard settings
3725         live.
3726         (-[WebHTMLView _removeMouseMovedObserverUnconditionally]): Deleted.
3727         (-[WebHTMLView addMouseMovedObserver]): Deleted.
3728         (-[WebHTMLView removeMouseMovedObserver]): Deleted.
3729
3730 2014-09-04  Pratik Solanki  <psolanki@apple.com>
3731
3732         Bring back [WebPreferences setDiskImageCacheEnabled:] for backwards compatibility
3733         https://bugs.webkit.org/show_bug.cgi?id=136560
3734
3735         Reviewed by Joseph Pecoraro.
3736
3737         I removed the disk image caching code in r173265. However, we still have clients that call
3738         setDiskImageCacheEnabled. Add in a stub method until we can wean the clients off this call.
3739
3740         * WebView/WebPreferences.mm:
3741         (-[WebPreferences setDiskImageCacheEnabled:]):
3742         * WebView/WebPreferencesPrivate.h:
3743
3744 2014-09-03  Andy Estes  <aestes@apple.com>
3745
3746         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
3747         https://bugs.webkit.org/show_bug.cgi?id=136521
3748
3749         Reviewed by Anders Carlsson.
3750
3751         Taught MigrateHeaders.make to remove WEBCORE_EXPORT from headers using this sed expression:
3752
3753             s/(^ *)WEBCORE_EXPORT /\1/g
3754
3755         This removes WEBCORE_EXPORT and a single following space character but preserves preceeding spaces.
3756
3757         * MigrateHeaders.make:
3758
3759 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
3760
3761         Remove WebCoreSystemInterface glue for otherwise unused WKSI calls
3762         https://bugs.webkit.org/show_bug.cgi?id=136527
3763
3764         Reviewed by Alexey Proskuryakov.
3765
3766         * WebCoreSupport/WebSystemInterface.mm:
3767         (InitWebCoreSystemInterface):
3768
3769 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3770
3771         Remove CSS_FILTERS flag
3772         https://bugs.webkit.org/show_bug.cgi?id=136529
3773
3774         Reviewed by Dirk Schulze.
3775
3776         * Configurations/FeatureDefines.xcconfig:
3777
3778 2014-09-04  Pratik Solanki  <psolanki@apple.com>
3779
3780         Remove iOS specific disk image cache
3781         https://bugs.webkit.org/show_bug.cgi?id=136517
3782
3783         Reviewed by Antti Koivisto.
3784
3785         Disk image cache code unnecessarily complicates SharedBuffer implementation. We can remove
3786         this now since we don't enable it in WebKit2 on iOS.
3787
3788         * Misc/WebCache.mm:
3789         (+[WebCache statistics]):
3790         * WebView/WebDataSource.mm:
3791         (-[WebDataSource _setAllowToBeMemoryMapped]):
3792         (-[WebDataSource setDataSourceDelegate:]):
3793         (-[WebDataSource dataSourceDelegate]):
3794         (-[WebDataSource dealloc]):
3795         (BufferMemoryMapped): Deleted.
3796         * WebView/WebPreferenceKeysPrivate.h:
3797         * WebView/WebPreferences.mm:
3798         (+[WebPreferences initialize]):
3799         (-[WebPreferences diskImageCacheEnabled]): Deleted.
3800         (-[WebPreferences setDiskImageCacheEnabled:]): Deleted.
3801         (-[WebPreferences diskImageCacheMinimumImageSize]): Deleted.
3802         (-[WebPreferences setDiskImageCacheMinimumImageSize:]): Deleted.
3803         (-[WebPreferences diskImageCacheMaximumCacheSize]): Deleted.
3804         (-[WebPreferences setDiskImageCacheMaximumCacheSize:]): Deleted.
3805         (-[WebPreferences _diskImageCacheSavedCacheDirectory]): Deleted.
3806         (-[WebPreferences _setDiskImageCacheSavedCacheDirectory:]): Deleted.
3807         * WebView/WebPreferencesPrivate.h:
3808         * WebView/WebView.mm:
3809         (-[WebView _commonInitializationWithFrameName:groupName:]):
3810         (+[WebView _handleMemoryWarning]):
3811         (-[WebView _preferencesChanged:]):
3812
3813 2014-09-04  Daniel Bates  <dabates@apple.com>
3814
3815         [iOS] Make iOS build when ENABLE_TOUCH_EVENT and ENABLE_IOS_TOUCH_EVENTS disabled
3816         https://bugs.webkit.org/show_bug.cgi?id=136494
3817
3818         Reviewed by Andy Estes.
3819
3820         * MigrateHeaders.make: Migrate header WebEventRegion.h only when ENABLE_IOS_TOUCH_EVENTS is defined.
3821         * WebView/WebView.mm: Substitute ENABLE(IOS_TOUCH_EVENTS) for ENABLE(TOUCH_EVENTS).
3822
3823 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
3824
3825         Web Inspector: fix prefixes for subclasses of JSC::ConsoleClient
3826         https://bugs.webkit.org/show_bug.cgi?id=136476
3827
3828         Reviewed by Timothy Hatcher.
3829
3830         * Misc/WebCoreStatistics.mm:
3831         (+[WebCoreStatistics shouldPrintExceptions]):
3832         (+[WebCoreStatistics setShouldPrintExceptions:]):
3833
3834 2014-09-03  Enrica Casucci  <enrica@apple.com>
3835
3836         Remove PLATFORM(IOS) from WebCore/editing (Part 1).
3837         https://bugs.webkit.org/show_bug.cgi?id=136474
3838
3839         Reviewed by Tim Horton.
3840
3841         * WebCoreSupport/WebEditorClient.mm:
3842         (undoNameForEditAction):
3843
3844 2014-09-02  Maciej Stachowiak  <mjs@apple.com>
3845
3846         Clean up naming for and slightly refactor legacy video fullscreen support
3847         https://bugs.webkit.org/show_bug.cgi?id=136446
3848
3849         Reviewed by Jer Noble.
3850
3851         Key changes:
3852         supportsFullscreenForNode(Node*) --> supportsVideoFullscreen()
3853         enterFullscreenForNode(Node*) --> enterVideoFullscreenForVideoElement(HTMLVideoElement*)
3854         exitFullscreenForNode(Node*) --> exitVideoFullscreen()
3855         
3856         The old versions had unnecessary parameters, did not clearly distinguish their purpose
3857         from enterFullscreenForElement and friends, and wrongly claimed generality to all Nodes.
3858         Also changed many other places to use HTMLVideoElement* instead of Node* or 
3859         HTMLMediaElement* when they were in fact only used for video elements and would only
3860         work for such.
3861
3862         * WebCoreSupport/WebChromeClient.h:
3863         * WebCoreSupport/WebChromeClient.mm:
3864         (WebChromeClient::supportsVideoFullscreen): Adjust for main refactoring.
3865         Also no more need to check for video elementness.
3866         (WebChromeClient::enterVideoFullscreenForVideoElement): Adjust for main refactoring.
3867         (WebChromeClient::exitVideoFullscreen): ditto
3868         * WebView/WebView.mm:
3869         (-[WebView _enterVideoFullscreenForVideoElement:]): Adjust for main
3870         refactoring.
3871         (-[WebView _exitVideoFullscreen]): ditto
3872         (-[WebView _close]): ditto
3873         * WebView/WebViewInternal.h:
3874
3875 2014-09-03  Dan Bernstein  <mitz@apple.com>
3876
3877         Get rid of HIGH_DPI_CANVAS leftovers
3878         https://bugs.webkit.org/show_bug.cgi?id=136491
3879
3880         Reviewed by Benjamin Poulain.
3881
3882         * Configurations/FeatureDefines.xcconfig: Removed definition of ENABLE_HIGH_DPI_CANVAS
3883         and removed it from FEATURE_DEFINES.
3884
3885 2014-08-31  Tim Horton  <timothy_horton@apple.com>
3886
3887         Remove unnecessary (and unnecessarily iOS-specific) setStrokeAndFillColor
3888         https://bugs.webkit.org/show_bug.cgi?id=136416
3889
3890         Reviewed by Dan Bernstein.
3891
3892         * WebView/WebFrameView.mm:
3893         (-[WebFrameView drawRect:]):
3894         We only end up filling, so only set the fill color.
3895
3896 2014-08-26  Maciej Stachowiak  <mjs@apple.com>
3897
3898         Use RetainPtr::autorelease in some places where it seems appropriate
3899         https://bugs.webkit.org/show_bug.cgi?id=136280
3900
3901         Reviewed by Darin Adler.
3902
3903         * WebView/WebHTMLView.mm:
3904         (imageFromRect): Use RetainPtr in this function.
3905         * WebView/WebPDFRepresentation.mm:
3906         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use RetainPtr
3907         in this method.
3908
3909 2014-08-29  Csaba Osztrogonác  <ossy@webkit.org>
3910
3911         Unreviwed, remove empty directories.
3912
3913         * ForwardingHeaders/wtf: Removed.
3914
3915 2014-08-27  Zalan Bujtas  <zalan@apple.com>
3916
3917         Subpixel layout: Rename LayoutRect's device pixel snapping functions.
3918         https://bugs.webkit.org/show_bug.cgi?id=136319
3919
3920         Reviewed by Simon Fraser.
3921
3922         From pixelSnappedForPainting() to snapRectToDevicePixels() and 
3923         pixelSnappedIntRect*() to snappedIntRect*().
3924
3925         No change in functionality.
3926
3927         * WebView/WebView.mm:
3928         (-[WebView _dashboardRegions]):
3929         (-[WebView trackedRepaintRects]):
3930
3931 2014-08-25  Maciej Stachowiak  <mjs@apple.com>
3932
3933         Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API
3934         https://bugs.webkit.org/show_bug.cgi?id=136082
3935
3936         Reviewed by Alexey Proskuryakov.
3937
3938         * Plugins/Hosted/NetscapePluginHostManager.mm:
3939         (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current
3940         localization name using WebCore helper instead of SPI.
3941         * Plugins/WebBasePluginPackage.mm: Fixed the include style for this 
3942         file.
3943         (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current
3944         localization name using WebCore helper instead of SPI.
3945         (+[WebBasePluginPackage preferredLocalizationName]): Deleted. This
3946         helper no longer pulls its weight.
3947         * WebCoreSupport/WebSystemInterface.mm: 
3948         (InitWebCoreSystemInterface): Remove mention of
3949         WKCopyCFLocalizationPreferredName.
3950         * WebKit.order: ditto
3951
3952 2014-08-25  Daniel Bates  <dabates@apple.com>
3953
3954         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/172889>
3955         (https://bugs.webkit.org/show_bug.cgi?id=109658)
3956
3957         Substitute GraphicsLayer::setContentsToPlatformLayer(..., GraphicsLayer::ContentsLayerForMedia)
3958         for GraphicsLayer::setContentsToMedia(...) because the latter was removed in <http://trac.webkit.org/changeset/172889>.
3959
3960         * WebView/WebView.mm:
3961         (-[WebView _setMediaLayer:forPluginView:]):
3962
3963 2014-08-22  Commit Queue  <commit-queue@webkit.org>
3964
3965         Unreviewed, rolling out r172866.
3966         https://bugs.webkit.org/show_bug.cgi?id=136177
3967
3968         Broke iOS build (Requested by othermaciej on #webkit).
3969
3970         Reverted changeset:
3971
3972         "Replace use of WKCopyCFLocalizationPreferredName with
3973         NSLocale public API"
3974         https://bugs.webkit.org/show_bug.cgi?id=136082
3975         http://trac.webkit.org/changeset/172866
3976
3977 2014-08-22  Simon Fraser  <simon.fraser@apple.com>
3978
3979         Implement paint flashing in the WK1 InspectorOverlay page
3980         https://bugs.webkit.org/show_bug.cgi?id=136138
3981
3982         Reviewed by Sam Weinig, Joseph Pecoraro.
3983
3984         Implement paint flashing for the WebKit1 InspectorOverlay via a second canvas in the overlay page.
3985         We avoid allocating backing store for this canvas until we have paint rects.
3986         
3987         Because this overlay page is weird and doesn't know how to paint itself, InspectorOverlay manages
3988         an array of rects, and pushes them to the page when they change, before forcing a paint.
3989         
3990         Because iOS doesn't use the InspectorOverlay page, stub out setShowPaintRects on its
3991         WebKit WebInspectorClient, but don't yet implement paint flashing there.
3992
3993         * WebCoreSupport/WebInspectorClient.h:
3994         * WebCoreSupport/WebInspectorClient.mm:
3995         (WebInspectorClient::WebInspectorClient):
3996
3997 2014-08-20  Maciej Stachowiak  <mjs@apple.com>
3998
3999         Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API
4000         https://bugs.webkit.org/show_bug.cgi?id=136082
4001
4002         Reviewed by Alexey Proskuryakov.
4003
4004         * Plugins/Hosted/NetscapePluginHostManager.mm:
4005         (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current
4006         localization name using WebCore helper instead of SPI.
4007         * Plugins/WebBasePluginPackage.mm: Fixed the include style for this 
4008         file.
4009         (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current
4010         localization name using WebCore helper instead of SPI.
4011         (+[WebBasePluginPackage preferredLocalizationName]): Deleted. This
4012         helper no longer pulls its weight.
4013         * WebCoreSupport/WebSystemInterface.mm: 
4014         (InitWebCoreSystemInterface): Remove mention of
4015         WKCopyCFLocalizationPreferredName.
4016         * WebKit.order: ditto
4017
4018 2014-08-22  Daniel Bates  <dabates@apple.com>
4019
4020         [iOS] Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, and temporarily disable ENABLE_TOUCH_EVENTS
4021         and ENABLE_XSLT when building with the iOS public SDK
4022         https://bugs.webkit.org/show_bug.cgi?id=135945
4023
4024         Reviewed by Andy Estes.
4025
4026         * Configurations/FeatureDefines.xcconfig: Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, ENABLE_TOUCH_EVENTS
4027         and ENABLE_XSLT when building with the public SDK.
4028         * MigrateHeaders.make: Conditionally migrate headers for touch and gesture events.
4029
4030 2014-08-22  Jon Lee  <jonlee@apple.com>
4031
4032         Fix iOS build due to r172832 and move RUBBER_BANDING out of FeatureDefines.h
4033         https://bugs.webkit.org/show_bug.cgi?id=136157
4034
4035         Reviewed by Simon Fraser.
4036
4037         * Configurations/FeatureDefines.xcconfig: Add ENABLE(RUBBER_BANDING).
4038         * WebView/WebView.mm:
4039         (-[WebView _preferencesChanged:]): Wrap in ENABLE(RUBBER_BANDING).
4040
4041 2014-08-21  Zalan Bujtas  <zalan@apple.com>
4042
4043         Enable SATURATED_LAYOUT_ARITHMETIC.
4044         https://bugs.webkit.org/show_bug.cgi?id=136106
4045
4046         Reviewed by Simon Fraser.
4047
4048         SATURATED_LAYOUT_ARITHMETIC protects LayoutUnit against arithmetic overflow.
4049         (No measurable performance regression on Mac.)
4050
4051         * Configurations/FeatureDefines.xcconfig:
4052
4053 2014-08-21  Beth Dakin  <bdakin@apple.com>
4054
4055         overflow:scroll elements should support rubber-banding
4056         https://bugs.webkit.org/show_bug.cgi?id=91655
4057
4058         Reviewed by Sam Weinig and Darin Adler.
4059
4060         Disable rubber-banding in overflow areas for now.
4061         * WebView/WebView.mm:
4062         (-[WebView _preferencesChanged:]):
4063
4064 2014-08-19  Pratik Solanki  <psolanki@apple.com>
4065
4066         Remove PurgeableBuffer since it is not very useful any more
4067         https://bugs.webkit.org/show_bug.cgi?id=135939
4068
4069         Reviewed by Andreas Kling.
4070
4071         * Misc/WebCache.mm:
4072         (+[WebCache statistics]):
4073
4074 2014-08-19  Zalan Bujtas  <zalan@apple.com>
4075
4076         Remove ENABLE(SUBPIXEL_LAYOUT).
4077         https://bugs.webkit.org/show_bug.cgi?id=136077
4078
4079         Reviewed by Simon Fraser.
4080
4081         Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.
4082
4083         * Configurations/FeatureDefines.xcconfig:
4084
4085 2014-08-18  Maciej Stachowiak  <mjs@apple.com>
4086
4087         Use NSURLFileTypeMappings directly instead of depending on WebKitSystemInterface wrappers for it
4088         https://bugs.webkit.org/show_bug.cgi?id=136035
4089
4090         Reviewed by Dan Bernstein.
4091
4092         * Misc/WebNSViewExtras.m:
4093         (-[NSView _web_DragImageForElement:rect:event:pasteboard:source:offset:]): Remove comment
4094         reference to obsolete WKSI function.
4095         * WebCoreSupport/WebSystemInterface.mm:
4096         (InitWebCoreSystemInterface): Don't initialize the no-longer-used WKGetExtensionsForMIMEType,
4097         WKGetPreferredExtensionForMIMEType, or WKGetMIMETypeForExtension
4098         * Plugins/WebPluginDatabase.mm:
4099         (-[WebPluginDatabase pluginForExtension:]): Include SPI header from WebCore; use
4100         NSURLFileTypeMappings directly instead of via WKSI wrapper.
4101         * WebCoreSupport/WebFrameLoaderClient.mm:
4102         (WebFrameLoaderClient::objectContentType): ditto
4103         * WebView/WebHTMLView.mm:
4104         (-[WebHTMLView _imageExistsAtPaths:]): ditto
4105         * WebView/WebView.mm:
4106         (+[WebView _supportedFileExtensions]): ditto
4107         (+[WebView suggestedFileExtensionForMIMEType:]): ditto
4108         (+[WebView _MIMETypeForFile:]): ditto
4109
4110 2014-08-18  Commit Queue  <commit-queue@webkit.org>
4111
4112         Unreviewed, rolling out r172736.
4113         https://bugs.webkit.org/show_bug.cgi?id=136060
4114
4115         Caused 14% PLT regressions (Requested by rniwa on #webkit).
4116
4117         Reverted changeset:
4118
4119         "Remove PurgeableBuffer since it is not very useful any more"
4120         https://bugs.webkit.org/show_bug.cgi?id=135939
4121         http://trac.webkit.org/changeset/172736
4122
4123 2014-08-18  Pratik Solanki  <psolanki@apple.com>
4124
4125         Remove PurgeableBuffer since it is not very useful any more
4126         https://bugs.webkit.org/show_bug.cgi?id=135939
4127
4128         Reviewed by Geoffrey Garen.
4129
4130         * Misc/WebCache.mm:
4131         (+[WebCache statistics]):
4132
4133 2014-08-18  Andy Estes  <aestes@apple.com>
4134
4135         REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
4136         https://bugs.webkit.org/show_bug.cgi?id=136010
4137
4138         Reviewed by Darin Adler.
4139
4140         * Misc/WebKitVersionChecks.h: Removed WEBKIT_FIRST_VERSION_WITH_NAVIGATION_URL_VALIDATION.
4141         * WebView/WebPDFView.mm:
4142         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Passed AllowNavigationToInvalidURL::Yes to FrameLoader::loadFrameRequest.
4143         * WebView/WebView.mm:
4144         (-[WebView _preferencesChanged:]): Reverted the linked-on-or-after check added in r170120 since it's no longer necessary.
4145
4146 2014-08-18  Andy Estes  <aestes@apple.com>
4147
4148         Revert r172697.
4149
4150         It made several webarchive layout tests flaky and didn't have the correct behavior for non-quick redirects.
4151
4152         * Misc/WebKitVersionChecks.h:
4153         * WebView/WebView.mm:
4154         (-[WebView _preferencesChanged:]):
4155
4156 2014-08-15  Andy Estes  <aestes@apple.com>
4157
4158         REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
4159         https://bugs.webkit.org/show_bug.cgi?id=136010
4160
4161         Reviewed by Darin Adler.
4162
4163         Reverted the linked-on-or-after check added in r170120 since it is no longer necessary.
4164
4165         * Misc/WebKitVersionChecks.h:
4166         * WebView/WebView.mm:
4167         (-[WebView _preferencesChanged:]):
4168
4169 2014-08-16  Maciej Stachowiak  <mjs@apple.com>
4170
4171         Remove the obsolete WebKitEnableCoalescedUpdatesPreferenceKey
4172         https://bugs.webkit.org/show_bug.cgi?id=136024
4173
4174         Reviewed by Filip Pizlo.
4175
4176         * WebView/WebFrameView.mm:
4177         (-[WebFrameView initWithFrame:]): Remove code that respects
4178         this key. It was SPI and is no longer used; also it was
4179         only relevant for versions of OS X that WebKit no longer supports.
4180         * WebView/WebPreferenceKeysPrivate.h: Remove declaration.
4181
4182 2014-08-15  Daniel Bates  <dabates@apple.com>
4183
4184         [iOS] Teach postprocess-headers.sh to remove code guarded by ENABLE_IOS_GESTURE_EVENTS
4185         and ENABLE_TOUCH_EVENTS if applicable
4186         https://bugs.webkit.org/show_bug.cgi?id=135993
4187
4188         Reviewed by Andy Estes.
4189
4190         Add support infrastructure to remove code from public and private API headers that is
4191         guarded by macro define ENABLE_{IOS_GESTURE, TOUCH}_EVENTS when these features are disabled.
4192
4193         We aren't using this functionality yet, but we will soon.
4194
4195         * postprocess-headers.sh:
4196