1 2011-12-31 Dan Bernstein <mitz@apple.com>
3 WebKit/mac changes for: REGRESSION (WebKit2): Cursor, hover states not updated when page scrolls under stationary mouse pointer
4 https://bugs.webkit.org/show_bug.cgi?id=75405
6 Reviewed by Anders Carlsson.
8 Removed the WebKit/mac mechanism for dispatching fake mouse moved events
9 when an HTML frame scrolls, since FrameView now does this.
11 * WebView/WebHTMLView.mm:
12 (-[WebHTMLViewPrivate dealloc]): Removed an assertion about a removed ivar.
13 (-[WebHTMLView _updateMouseoverWithFakeEvent]): Removed call to
14 -_cancelUpdateMouseoverTimer.
15 (-[WebHTMLView _frameOrBoundsChanged]): Removed code to schedule a timer
16 for dispatching a mouse moved event on scroll.
17 (-[WebHTMLView close]): Removed call to _cancelUpdateMouseoverTimer.
18 (-[WebHTMLView viewWillMoveToWindow:]): Ditto.
19 (-[WebHTMLView mouseDown:]): Ditto.
21 2011-12-23 Ryosuke Niwa <rniwa@webkit.org>
23 Chromium Mac build fix.
25 * WebCoreSupport/WebSystemInterface.mm:
26 (InitWebCoreSystemInterface):
28 2011-12-21 Sam Weinig <sam@webkit.org>
30 Start extracting platform specific bits out of PlatformEvents
31 https://bugs.webkit.org/show_bug.cgi?id=75063
33 Reviewed by Anders Carlsson.
35 * WebCoreSupport/WebSystemInterface.mm:
36 (InitWebCoreSystemInterface):
37 * WebView/WebFrame.mm:
38 * WebView/WebHTMLView.mm:
39 (-[WebHTMLView menuForEvent:]):
40 (-[WebHTMLView acceptsFirstMouse:]):
41 (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
42 (currentKeyboardEvent):
43 (-[WebHTMLView flagsChanged:]):
44 * WebView/WebPDFView.mm:
45 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
48 2011-12-21 Timothy Hatcher <timothy@apple.com>
50 Web Inspector: suppress incremental rendering and use application chrome mode
52 https://webkit.org/b/75026
54 Reviewed by Joseph Pecoraro.
56 * WebCoreSupport/WebInspectorClient.mm:
57 (-[WebInspectorWindowController init]): Sort the preferences, remove the Leopard font family setting,
58 set suppress incremental rendering and use application chrome mode.
60 2011-12-20 Pavel Feldman <pavel.feldman@gmail.com>
62 Web Inspector: reproducible crash after closing web inspector and browser window (iCab)
63 https://bugs.webkit.org/show_bug.cgi?id=74255
65 Reviewed by Yury Semikhatsky.
67 * WebCoreSupport/WebInspectorClient.h:
68 * WebCoreSupport/WebInspectorClient.mm:
69 (WebInspectorClient::bringFrontendToFront):
70 (-[WebInspectorWindowController destroyInspectorView:]):
72 2011-12-19 Eric Carlson <eric.carlson@apple.com>
74 Enable <track> for Mac build
75 https://bugs.webkit.org/show_bug.cgi?id=74838
77 Reviewed by Darin Adler.
79 * Configurations/FeatureDefines.xcconfig:
81 2011-12-16 Ryosuke Niwa <rniwa@webkit.org>
83 Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step
84 https://bugs.webkit.org/show_bug.cgi?id=74748
86 Reviewed by Eric Seidel.
88 * WebCoreSupport/WebEditorClient.h:
89 * WebCoreSupport/WebEditorClient.mm:
90 (WebEditorClient::registerUndoOrRedoStep):
91 (WebEditorClient::registerUndoStep):
92 (WebEditorClient::registerRedoStep):
94 2011-12-16 Sam Weinig <sam@webkit.org>
96 Give PlatformEvents a base class
97 https://bugs.webkit.org/show_bug.cgi?id=74685
99 Reviewed by Anders Carlsson.
101 Add a base class for PlatformMouseEvent, PlatformKeyboardEvent, PlatformWheelEvent
102 and PlatformGestureEvent and move Type enumeration and modifiers down to it.
104 * WebView/WebFrame.mm:
105 (-[WebFrame _dragSourceEndedAt:operation:]):
106 * WebView/WebHTMLView.mm:
107 (currentKeyboardEvent):
108 (-[WebHTMLView _interpretKeyEvent:savingCommands:]):
109 * WebView/WebPDFView.mm:
110 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
112 2011-12-16 Simon Fraser <simon.fraser@apple.com>
114 Fix a #elsif fumble in my earlier commit.
116 * WebView/WebHTMLView.mm:
117 (-[WebHTMLView attachRootLayer:]):
119 2011-12-16 Ryosuke Niwa <rniwa@webkit.org>
121 Only EditCommandComposition should implement unapply and reapply
122 https://bugs.webkit.org/show_bug.cgi?id=74490
124 Reviewed by Eric Seidel.
126 * WebCoreSupport/WebEditorClient.h:
127 * WebCoreSupport/WebEditorClient.mm:
128 (-[WebUndoStep initWithUndoStep:]):
129 (-[WebUndoStep dealloc]):
130 (+[WebUndoStep stepWithUndoStep:]):
131 (-[WebUndoStep step]):
132 (-[WebEditorUndoTarget undoEditing:]):
133 (-[WebEditorUndoTarget redoEditing:]):
134 (WebEditorClient::registerCommandForUndoOrRedo):
135 (WebEditorClient::registerCommandForUndo):
136 (WebEditorClient::registerCommandForRedo):
138 2011-12-16 Simon Fraser <simon.fraser@apple.com>
140 <rdar://problem/10589427> Avoid calling -setGeometryFlipped ourselves on the layer hosting view's layer
142 Reviewed by Sam Weinig.
144 Now that we're using a flipped view to host the compositing layers,
145 we should not set geometryFlipped on the root layer ourselves.
147 * WebView/WebHTMLView.mm:
148 (-[WebHTMLView attachRootLayer:]):
150 2011-12-16 Mark Hahnenberg <mhahnenberg@apple.com>
152 De-virtualize destructors
153 https://bugs.webkit.org/show_bug.cgi?id=74331
155 Reviewed by Geoffrey Garen.
157 * Plugins/Hosted/ProxyRuntimeObject.h: Remove empty virtual destructor.
158 * Plugins/Hosted/ProxyRuntimeObject.mm:
160 2011-12-14 Ryosuke Niwa <rniwa@webkit.org>
162 Mac build fix after r102874.
164 * WebCoreSupport/WebChromeClient.mm:
166 2011-12-14 Jing Zhao <jingzhao@chromium.org>
168 Opening two popup menus by dispatchEvent() makes problems.
169 https://bugs.webkit.org/show_bug.cgi?id=73304
171 Reviewed by Kent Tamura.
173 * WebCoreSupport/WebChromeClient.h: Overrides hasOpenedPopup().
174 * WebCoreSupport/WebChromeClient.mm:
175 (WebChromeClient::hasOpenedPopup): Not implemented.
177 2011-12-14 Michael Saboff <msaboff@apple.com>
179 Mac WebScriptDebugger crashes beneath sourceParsed()
180 https://bugs.webkit.org/show_bug.cgi?id=74564
182 Reviewed by Gavin Barraclough.
184 * WebView/WebScriptDebugger.mm:
185 (toNSString): Change to use ->characters() method to
186 actually get characters for string conversion.
188 2011-12-14 Hajime Morrita <morrita@chromium.org>
190 JS_INLINE and WTF_INLINE should be visible from WebCore
191 https://bugs.webkit.org/show_bug.cgi?id=73191
193 Reviewed by Kevin Ollivier.
195 Removed macro definitions which is now provided by Platform.h
199 2011-12-13 Jon Lee <jonlee@apple.com>
201 Enable notifications on Mac.
203 Reviewed by Sam Weinig.
205 * Configurations/FeatureDefines.xcconfig:
207 2011-12-12 Ryosuke Niwa <rniwa@webkit.org>
209 WebKit code shouldn't be calling applyCommand directly
210 https://bugs.webkit.org/show_bug.cgi?id=74337
212 Reviewed by Darin Adler.
214 * WebView/WebFrame.mm:
215 (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
217 2011-12-12 Brady Eidson <beidson@apple.com>
219 Page cache should support pages with plugins.
220 <rdar://problem/5190122> and https://bugs.webkit.org/show_bug.cgi?id=13634
222 Expose a WebKit preference for the page cache supporting plugins (on by default).
224 Reviewed by Anders Carlsson.
226 * WebView/WebPreferenceKeysPrivate.h:
228 * WebView/WebPreferences.mm:
229 (-[WebPreferences pageCacheSupportsPlugins]):
230 (-[WebPreferences setPageCacheSupportsPlugins:]):
231 * WebView/WebPreferencesPrivate.h:
233 * WebView/WebView.mm:
234 (-[WebView _preferencesChanged:]):
236 2011-12-12 Dan Bernstein <mitz@apple.com>
238 <rdar://problem/10328474> Text highlight changes to gray selection color when menu extra is shown
240 Reviewed by John Sullivan.
242 * WebView/WebView.mm:
243 (-[WebView _updateActiveState]): Changed to use -[NSWindow _hasKeyAppearance] instead
244 of -isKeyWindow. The former also returns YES when a menu extra is open.
245 (-[WebView addWindowObserversForWindow:]): Removed code to observe
246 NSWindowDidBecomeKeyNotification and NSWindowDidResignKeyNotification.
247 (-[WebView removeWindowObservers]): Removed code to stop observing the above.
248 (-[WebView _windowChangedKeyState]): Overridden this to call _updateActiveState.
249 This is called when the result of -_hasKeyAppearance changes.
250 (-[WebView _windowWillOrderOnScreen:]): Removed call to _updateActiveState,
251 previously needed for popovers, because _windowChangedKeyState is invoked
252 at the right time for them.
253 (-[WebView _windowWillOrderOffScreen:]): Ditto.
255 2011-12-07 Mark Rowe <mrowe@apple.com>
257 Fix the 32-bit build.
259 Ignore some warnings that only occur in 32-bit.
261 * Plugins/WebNetscapePluginPackage.mm:
263 2011-12-07 Mary Wu <mary.wu@torchmobile.com.cn>
265 Change function name InitializeLoggingChannelsIfNecessary to follow coding style guideline
266 https://bugs.webkit.org/show_bug.cgi?id=73986
268 Reviewed by Kenneth Rohde Christiansen.
270 * WebView/WebView.mm:
271 (-[WebView _commonInitializationWithFrameName:groupName:]):
273 2011-12-06 Alexey Proskuryakov <ap@apple.com>
275 REGRESSION (WebKit2): Kill ring is not cleared when selection changes
276 https://bugs.webkit.org/show_bug.cgi?id=73888
277 <rdar://problem/10532310>
279 Reviewed by Mark Rowe.
281 * WebView/WebHTMLView.mm:
282 (-[WebHTMLView becomeFirstResponder]): Added a FIXME comment.
283 (-[WebHTMLView _selectionChanged]): Moved the code to clear kill ring to WebCore. The rest
284 of kill ring implementation is there, so it makes no sense to have this call in WebKits.
286 2011-12-05 Anders Carlsson <andersca@apple.com>
288 Make LayerFlushSchedulerClient::flushLayers indicate whether the flush was successful or not
289 https://bugs.webkit.org/show_bug.cgi?id=73862
291 Reviewed by Andy Estes.
293 Remove the call to LayerFlushScheduler::invalidate and return true instead. Return false for the cases
294 where we don't want the layer flush scheduler to be invalidated.
296 * WebView/WebView.mm:
297 (LayerFlushController::flushLayers):
298 * WebView/WebViewData.h:
300 2011-12-05 Eric Carlson <eric.carlson@apple.com>
302 Add WebKit preferences for text track settings
303 https://bugs.webkit.org/show_bug.cgi?id=73721
305 Reviewed by John Sullivan.
307 * WebView/WebPreferenceKeysPrivate.h: Added #define for shouldDisplaySubtitles, shouldDisplayCaptions,
308 and shouldDisplayTextDescriptions properties.
310 * WebView/WebPreferences.mm:
311 (+[WebPreferences initialize]): Initialize new preferences to NO.
312 (-[WebPreferences setShouldDisplaySubtitles:]): Added.
313 (-[WebPreferences shouldDisplaySubtitles]): Ditto.
314 (-[WebPreferences setShouldDisplayCaptions:]): Ditto.
315 (-[WebPreferences shouldDisplayCaptions]): Ditto.
316 (-[WebPreferences setShouldDisplayTextDescriptions:]): Ditto.
317 (-[WebPreferences shouldDisplayTextDescriptions]): Ditto.
318 * WebView/WebPreferencesPrivate.h:
320 * WebView/WebView.mm:
321 (-[WebView _preferencesChanged:]): Updates WebCore settings from WebKit prefs.
323 2011-12-03 Dan Bernstein <mitz@apple.com>
325 <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
326 Reviewed by Darin Adler.
328 * WebView/WebView.mm:
329 (-[WebView _removeObjectForIdentifier:]): Changed the CFRelease(self) into
330 a WebCFAutorelease(self). This prevents re-entry into this method due to
331 the WebView closing and canceling all subresource loads, including the
332 one we have just removed.
334 2011-12-02 David Levin <levin@chromium.org>
336 Rename WTF class from TemporarilyChange to TemporaryChange.
337 https://bugs.webkit.org/show_bug.cgi?id=73479
339 Reviewed by Eric Seidel.
341 * ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
342 * ForwardingHeaders/wtf/TemporaryChange.h: Added.
344 2011-12-02 Simon Fraser <simon.fraser@apple.com>
346 <rdar://problem/10423627> Layers are flipped in WebKit1 views
348 Reviewed by Sam Weinig.
350 Host the compositing layers in an NSView which is flipped, which helps AppKit
351 get the geometry right in some situations.
353 * WebView/WebHTMLView.mm:
354 (-[WebLayerHostingFlippedView isFlipped]):
355 (-[WebHTMLView attachRootLayer:]):
357 2011-12-02 Hajime Morrita <morrita@chromium.org>
359 Unreviewed, rolling out r101751 and r101775.
360 http://trac.webkit.org/changeset/101751
361 http://trac.webkit.org/changeset/101775
362 https://bugs.webkit.org/show_bug.cgi?id=73191
368 2011-12-01 Hajime Morrita <morrita@chromium.org>
370 JS_INLINE and WTF_INLINE should be visible from WebCore
371 https://bugs.webkit.org/show_bug.cgi?id=73191
373 Reviewed by Kevin Ollivier.
375 Removed macro definitions which is now provided by Platform.h
379 2011-11-30 Alexey Proskuryakov <ap@apple.com>
381 Remove an unneeded argument from FrameLoaderClient::download
382 https://bugs.webkit.org/show_bug.cgi?id=73486
384 Reviewed by Andreas Kling.
386 * WebCoreSupport/WebFrameLoaderClient.h:
387 * WebCoreSupport/WebFrameLoaderClient.mm:
388 (WebFrameLoaderClient::download):
389 Updated for the change.
391 2011-11-30 Dan Bernstein <mitz@apple.com>
393 WebKit/mac part of: Allow the length of a page along the pagination axis to differ from the length of the view
394 https://bugs.webkit.org/show_bug.cgi?id=73476
396 Reviewed by Anders Carlsson.
398 * WebView/WebView.mm:
399 (-[WebView _setPageLength:]): Added this accessor.
400 (-[WebView _pageLength]): Ditto.
401 * WebView/WebViewPrivate.h:
403 2011-11-30 Alexey Proskuryakov <ap@apple.com>
405 Download page URL should be set by WebCore
406 https://bugs.webkit.org/show_bug.cgi?id=73358
408 Reviewed by Darin Adler.
410 * WebCoreSupport/WebFrameLoaderClient.h: Removed setOriginalURLForDownload, which is now
413 * WebCoreSupport/WebFrameLoaderClient.mm:
414 (WebFrameLoaderClient::download): There is no need to set original URL post factum any more.
415 (WebFrameLoaderClient::startDownload): Ditto.
417 2011-11-29 David Levin <levin@chromium.org>
419 Add a way to revert a variable to its previous value after leaving a scope.
420 https://bugs.webkit.org/show_bug.cgi?id=73371
422 Reviewed by Adam Barth.
424 * ForwardingHeaders/wtf/TemporarilyChange.h: Added.
426 2011-11-29 Jessie Berlin <jberlin@apple.com>
428 WKKeyValueStorageManagerGetKeyValueStorageOrigins may not report the correct list of origins
429 the first time it is called.
430 https://bugs.webkit.org/show_bug.cgi?id=73374 (<rdar://problem/10196057>)
432 Reviewed by Brady Eidson.
434 * Storage/WebStorageTrackerClient.h:
435 * Storage/WebStorageTrackerClient.mm:
436 (WebStorageTrackerClient::didFinishLoadingOrigins):
438 2011-11-15 Anders Carlsson <andersca@apple.com>
440 DragClient::dragSourceActionMaskForPoint should use root view coordinates
441 https://bugs.webkit.org/show_bug.cgi?id=72409
443 Reviewed by Sam Weinig.
445 * WebCoreSupport/WebDragClient.mm:
446 (WebDragClient::dragSourceActionMaskForPoint):
447 Use -[WebView _convertPointFromRootView:] to convert the point to the web view coordinate system.
449 2011-11-15 Anders Carlsson <andersca@apple.com>
451 EditorClient::showCorrectionPanel should pass the string bounding box in root view coordinates
452 https://bugs.webkit.org/show_bug.cgi?id=72408
454 Reviewed by Sam Weinig.
456 * WebCoreSupport/CorrectionPanel.mm:
457 (CorrectionPanel::show):
458 Convert the bounding rect to web view coordinates.
460 * WebView/WebView.mm:
461 (-[WebView _convertPointFromRootView:]):
462 (-[WebView _convertRectFromRootView:]):
463 * WebView/WebViewInternal.h:
464 Add helper methods for converting from root view coordinates to web view coordinates.
466 2011-11-29 Roland Steiner <rolandsteiner@chromium.org>
468 <style scoped>: add ENABLE(STYLE_SCOPED) flag to WebKit
469 https://bugs.webkit.org/show_bug.cgi?id=72848
471 Reviewed by Dimitri Glazkov.
473 * Configurations/FeatureDefines.xcconfig:
475 2011-11-28 Jon Lee <jonlee@apple.com>
477 Create skeleton framework for notifications support in WK2
478 https://bugs.webkit.org/show_bug.cgi?id=73253
479 <rdar://problem/10356943>
481 Reviewed by Sam Weinig.
483 * Configurations/FeatureDefines.xcconfig: Split out ENABLE_NOTIFICATIONS based on platform.
485 * WebCoreSupport/WebNotificationClient.h: Added.
486 (WebNotificationClient::webView):
487 * WebCoreSupport/WebNotificationClient.mm: Added. Implemented as stubs for now.
488 (WebNotificationClient::WebNotificationClient):
489 (WebNotificationClient::show):
490 (WebNotificationClient::cancel):
491 (WebNotificationClient::notificationObjectDestroyed):
492 (WebNotificationClient::requestPermission):
493 (WebNotificationClient::cancelRequestsForPermission):
494 (WebNotificationClient::checkPermission):
495 * WebView/WebView.mm: Set PageClient's notification client to an instance of this stubbed class.
497 2011-11-28 Adam Roben <aroben@apple.com>
499 Properly retain the OS X version string
501 Fixes <http://webkit.org/b/73214> REGRESSION (r101215): Crash on launch beneath +[WebView
502 _standardUserAgentWithApplicationName:]
504 Reviewed by Antti Koivisto.
506 * WebView/WebView.mm:
507 (createMacOSXVersionString): Retain the string we're returning, since this function is
508 supposed to return an owning reference to the caller.
510 2011-11-28 Hayato Ito <hayato@chromium.org>
512 Fix chromium canary build after r101215.
513 Unreviewed. Build fix.
515 * WebCoreSupport/WebSystemInterface.mm:
516 (InitWebCoreSystemInterface):
518 2011-11-27 Mark Rowe <mrowe@apple.com>
520 <http://webkit.org/b/72665> Switch to a more modern approach to retrieving the OS marketing version
522 Reviewed by Dan Bernstein.
524 * WebCoreSupport/WebSystemInterface.mm:
525 (InitWebCoreSystemInterface): Set up wkGetMacOSXVersionString.
526 * WebView/WebView.mm:
527 (createMacOSXVersionString): Use WKGetMacOSXVersionString.
529 2011-11-26 Pavel Feldman <pfeldman@google.com>
531 Web Inspector: remove disconnectFromBackend from the protocol.
532 https://bugs.webkit.org/show_bug.cgi?id=73127
534 Reviewed by Yury Semikhatsky.
536 * WebCoreSupport/WebInspectorClient.h:
537 * WebCoreSupport/WebInspectorClient.mm:
538 (WebInspectorClient::inspectorDestroyed):
539 (WebInspectorClient::closeInspectorFrontend):
541 2011-11-26 Sheriff Bot <webkit.review.bot@gmail.com>
543 Unreviewed, rolling out r101193.
544 http://trac.webkit.org/changeset/101193
545 https://bugs.webkit.org/show_bug.cgi?id=73158
547 Breaks Windows and Qt minimal. (Requested by pfeldman on
550 * WebCoreSupport/WebInspectorClient.h:
551 * WebCoreSupport/WebInspectorClient.mm:
552 (WebInspectorClient::inspectorDestroyed):
554 2011-11-26 Pavel Feldman <pfeldman@google.com>
556 Web Inspector: remove disconnectFromBackend from the protocol.
557 https://bugs.webkit.org/show_bug.cgi?id=73127
559 Reviewed by Yury Semikhatsky.
561 * WebCoreSupport/WebInspectorClient.h:
562 * WebCoreSupport/WebInspectorClient.mm:
563 (WebInspectorClient::inspectorDestroyed):
564 (WebInspectorClient::closeInspectorFrontend):
566 2011-11-22 Pavel Feldman <pfeldman@google.com>
568 Web Inspector: remove Inspector::bringToFront from the protocol.
569 https://bugs.webkit.org/show_bug.cgi?id=72937
571 Reviewed by Yury Semikhatsky.
573 * WebCoreSupport/WebInspectorClient.h:
574 * WebCoreSupport/WebInspectorClient.mm:
575 (WebInspectorClient::openInspectorFrontend):
576 (WebInspectorClient::bringFrontendToFront):
578 2011-11-21 Mark Rowe <mrowe@apple.com>
580 Fix the SnowLeopard build.
582 * Misc/WebNSFileManagerExtras.mm: Forward-declare DADiskCreateFromVolumePath on SnowLeopard as it was
583 not yet declared in a public header.
585 2011-11-20 Mark Rowe <mrowe@apple.com>
587 <http://webkit.org/b/72661> Switch to a more modern approach to retrieving the startup volume name
589 Use the DiskArbitration framework to retrieve the name of the startup volume rather than using Carbon
592 Reviewed by Dan Bernstein.
594 * Misc/WebNSFileManagerExtras.mm:
595 (-[NSFileManager _webkit_startupVolumeName]): Retrieve a DADiskRef for the startup volume and copy
596 the volume name from its description dictionary.
598 2011-06-20 Pavel Feldman <pfeldman@chromium.org>
600 Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
601 https://bugs.webkit.org/show_bug.cgi?id=62985
603 Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
604 methods for plumbing the menu action handlers through the WebKit and WebCore.
605 I intend to remove this menu support from the protocol and WebCore/InspectorController API.
606 I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
607 WebKit/win and WebKit2 to follow.
609 Reviewed by Yury Semikhatsky.
611 * WebCoreSupport/WebInspectorClient.mm:
612 (-[WebInspectorWindowController destroyInspectorView:]):
613 * WebInspector/WebInspector.mm:
614 (-[WebInspector showWindow]):
615 (-[WebInspector show:]):
616 (-[WebInspector showConsole:]):
617 (-[WebInspector isDebuggingJavaScript]):
618 (-[WebInspector toggleDebuggingJavaScript:]):
619 (-[WebInspector startDebuggingJavaScript:]):
620 (-[WebInspector stopDebuggingJavaScript:]):
621 (-[WebInspector isProfilingJavaScript]):
622 (-[WebInspector toggleProfilingJavaScript:]):
623 (-[WebInspector startProfilingJavaScript:]):
624 (-[WebInspector stopProfilingJavaScript:]):
625 (-[WebInspector isJavaScriptProfilingEnabled]):
626 (-[WebInspector setJavaScriptProfilingEnabled:]):
627 (-[WebInspector isTimelineProfilingEnabled]):
628 (-[WebInspector setTimelineProfilingEnabled:]):
629 (-[WebInspector setFrontend:]):
630 (-[WebInspector releaseFrontend]):
631 (-[WebInspector showWindow:]):
632 * WebInspector/WebInspectorFrontend.h:
633 * WebInspector/WebInspectorFrontend.mm:
634 (-[WebInspectorFrontend isDebuggingEnabled]):
635 (-[WebInspectorFrontend setDebuggingEnabled:]):
636 (-[WebInspectorFrontend isProfilingJavaScript]):
637 (-[WebInspectorFrontend startProfilingJavaScript]):
638 (-[WebInspectorFrontend stopProfilingJavaScript]):
639 (-[WebInspectorFrontend isJavaScriptProfilingEnabled]):
640 (-[WebInspectorFrontend setJavaScriptProfilingEnabled:]):
641 (-[WebInspectorFrontend isTimelineProfilingEnabled]):
642 (-[WebInspectorFrontend setTimelineProfilingEnabled:]):
643 * WebInspector/WebInspectorPrivate.h:
645 2011-11-21 Jochen Eisinger <jochen@chromium.org>
647 Implement Meta referrer
648 https://bugs.webkit.org/show_bug.cgi?id=72674
650 Reviewed by Adam Barth.
652 * Plugins/Hosted/HostedNetscapePluginStream.mm:
653 (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
654 * Plugins/WebNetscapePluginStream.mm:
655 (WebNetscapePluginStream::WebNetscapePluginStream):
657 2011-10-17 Antonio Gomes <agomes@rim.com>
659 Pass a Frame* parameter in EditorClient::respondToChangedSelection
660 https://bugs.webkit.org/show_bug.cgi?id=70248
662 Reviewed by Ryosuke Niwa.
664 * WebCoreSupport/WebEditorClient.h:
665 * WebCoreSupport/WebEditorClient.mm: Make use of the newly added Frame* parameter.
666 (WebEditorClient::respondToChangedSelection):
668 2011-11-17 Mark Rowe <mrowe@apple.com>
670 <http://webkit.org/b/72646> Disable deprecation warnings around code where we cannot easily
671 switch away from the deprecated APIs.
673 Reviewed by Sam Weinig.
675 * Plugins/WebBasePluginPackage.mm:
676 * Plugins/WebNetscapePluginPackage.mm:
677 (-[WebNetscapePluginPackage _tryLoad]):
679 2011-11-18 Anton D'Auria <adauria@apple.com>
681 bool WebChromeClient::shouldInterruptJavaScript casts pointer to bool and always returns true
682 https://bugs.webkit.org/show_bug.cgi?id=72568
684 Reviewed by David Kilzer.
686 WebChromeClient::shouldInterruptJavaScript called CallUIDelegate, which used an id
687 as the return value, which was then cast to a bool and always returned true. This
688 patch uses CallUIDelegateReturningBoolean instead of CallUIDelegate, with the default
691 * WebCoreSupport/WebChromeClient.mm:
692 (WebChromeClient::shouldInterruptJavaScript):
694 2011-11-16 Dan Bernstein <mitz@apple.com>
696 WebKit/mac part of <rdar://problem/10262242> Add API for paginated display
697 https://bugs.webkit.org/show_bug.cgi?id=72537
699 Reviewed by Anders Carlsson.
701 * WebView/WebView.mm:
702 (-[WebView _setPaginationMode:]): Added this accessor.
703 (-[WebView _paginationMode]): Ditto.
704 (-[WebView _setGapBetweenPages:]): Ditto.
705 (-[WebView _gapBetweenPages]): Ditto.
706 (-[WebView _pageCount]): Ditto.
707 * WebView/WebViewPrivate.h: Defined WebPaginationMode enum and values.
709 2011-11-15 Andy Estes <aestes@apple.com>
711 Consolidate the logic that creates run loop observers for flushing layer tree changes to CoreAnimation
712 https://bugs.webkit.org/show_bug.cgi?id=72106
714 Reviewed by Anders Carlsson.
716 Remove code that schedules layer flushes and use LayerFlushScheduler instead.
718 * WebView/WebView.mm:
719 (-[WebView _close]): Invalidate the run loop observer and destroy the
720 LayerFlushController.
721 (LayerFlushController::flushLayers): Perform the work that
722 layerSyncRunLoopObserverCallBack used to do.
723 (-[WebView _scheduleCompositingLayerSync]): If layerFlushController has
724 yet to be created, create it, then schedule a layer flush.
725 * WebView/WebViewData.h:
726 (LayerFlushController::create): Create a LayerFlushController that
727 implements the LayerFlushSchedulerClient interface and contains a
728 LayerFlushScheduler with itself as the client.
729 * WebView/WebViewData.mm:
730 (LayerFlushController::scheduleLayerFlush):
731 (LayerFlushController::invalidateObserver):
732 (LayerFlushController::LayerFlushController):
734 2011-11-15 Jochen Eisinger <jochen@chromium.org>
736 Rename ReferrerPolicy to clarify its meaning
737 https://bugs.webkit.org/show_bug.cgi?id=72420
739 Reviewed by Nate Chapin.
741 * WebView/WebPDFView.mm:
742 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
744 2011-11-15 Anders Carlsson <andersca@apple.com>
746 HostWindow screenToWindow/windowToScreen should be screenToRootView/rootViewToScreen
747 https://bugs.webkit.org/show_bug.cgi?id=72397
749 Reviewed by Dan Bernstein.
751 * WebCoreSupport/WebChromeClient.h:
752 * WebCoreSupport/WebChromeClient.mm:
753 (WebChromeClient::screenToRootView):
754 (WebChromeClient::rootViewToScreen):
756 2011-11-14 Anders Carlsson <andersca@apple.com>
758 HostWindow invalidation functions should use root view coordinates
759 https://bugs.webkit.org/show_bug.cgi?id=72338
761 Reviewed by Dan Bernstein.
763 * WebCoreSupport/WebChromeClient.h:
764 * WebCoreSupport/WebChromeClient.mm:
765 (WebChromeClient::invalidateRootView):
766 (WebChromeClient::invalidateContentsAndRootView):
767 (WebChromeClient::invalidateContentsForSlowScroll):
769 2011-11-14 Julien Chaffraix <jchaffraix@webkit.org>
771 Add --css-grid-layout to build-webkit and the build systems
772 https://bugs.webkit.org/show_bug.cgi?id=72320
774 Reviewed by Ojan Vafai.
776 * Configurations/FeatureDefines.xcconfig:
778 2011-11-14 Tony Chang <tony@chromium.org>
780 Remove the CSS3_FLEXBOX compile time flag and enable on all ports
781 https://bugs.webkit.org/show_bug.cgi?id=72196
783 Reviewed by Ojan Vafai.
785 * Configurations/FeatureDefines.xcconfig:
787 2011-11-07 Adam Barth <abarth@webkit.org>
789 Move static "policy" state from SecurityOrigin.cpp to SecurityPolicy.cpp
790 https://bugs.webkit.org/show_bug.cgi?id=71755
792 Reviewed by Eric Seidel.
794 * Plugins/Hosted/HostedNetscapePluginStream.mm:
795 (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
796 * Plugins/WebNetscapePluginStream.mm:
797 (WebNetscapePluginStream::WebNetscapePluginStream):
798 * WebView/WebView.mm:
799 (-[WebView _commonInitializationWithFrameName:groupName:]):
800 (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
801 (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
802 (+[WebView _resetOriginAccessWhitelists]):
804 2011-11-08 Joseph Pecoraro <pecoraro@apple.com>
806 Move NSRange / DOMRange functions back to WebFrameInternal
807 https://bugs.webkit.org/show_bug.cgi?id=71844
809 Reviewed by Alexey Proskuryakov.
811 * WebView/WebFrame.mm:
812 (-[WebFrame _convertNSRangeToDOMRange:]):
813 (-[WebFrame _convertDOMRangeToNSRange:]):
814 * WebView/WebFrameInternal.h:
815 * WebView/WebFramePrivate.h:
817 2011-11-08 Michael Saboff <msaboff@apple.com>
819 Towards 8 Bit Strings: Templatize JSC::Parser class by Lexer type
820 https://bugs.webkit.org/show_bug.cgi?id=71761
822 Changed WKPCEvaluate() to use emptyString() when the source is
825 Reviewed by Gavin Barraclough.
827 * Plugins/Hosted/NetscapePluginHostProxy.mm:
830 2011-11-08 Beth Dakin <bdakin@apple.com>
832 https://bugs.webkit.org/show_bug.cgi?id=71856
833 WebKit should use new NSWindowDidChangeBackingPropertiesNotification instead of
834 old NSWindowDidChangeResolutionNotification
836 <rdar://problem/10317253>
838 Reviewed by Tim Hatcher.
840 * WebView/WebView.mm:
841 (-[WebView addWindowObserversForWindow:]):
842 (-[WebView removeWindowObservers]):
844 We have to check that the backing scale factor actually changed since this
845 notification can also be used to signify other changes.
846 (-[WebView _windowDidChangeBackingProperties:]):
848 2011-11-07 Adam Barth <abarth@webkit.org>
850 Move DomainRelaxationForbidden scheme registry to SchemeRegistry
851 https://bugs.webkit.org/show_bug.cgi?id=71750
853 Reviewed by Eric Seidel.
855 * WebView/WebView.mm:
856 (+[WebView _setDomainRelaxationForbidden:forURLScheme:]):
858 2011-11-07 Jessie Berlin <jberlin@apple.com>
860 Need a way to allow a scheme access to Local Storage and Databases while Private Browsing is
862 https://bugs.webkit.org/show_bug.cgi?id=71631
864 Reviewed by Jon Honeycutt.
866 Add WebKit1 API to register a scheme as ignoring Private Browsing for Local Storage and
869 * WebView/WebView.mm:
870 (+[WebView _registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing:]):
871 Call through to the SchemeRegistry function.
872 (+[WebView _registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing:]):
874 * WebView/WebViewPrivate.h:
876 2011-11-03 Mark Hahnenberg <mhahnenberg@apple.com>
878 De-virtualize JSObject::getPropertyNames
879 https://bugs.webkit.org/show_bug.cgi?id=71306
881 Reviewed by Darin Adler.
883 Added getPropertyNames to the MethodTable, changed all the virtual
884 implementations of getPropertyNames to static ones, and replaced
885 all call sites with corresponding lookups in the MethodTable.
887 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
888 (WebKit::NetscapePluginInstanceProxy::enumerate):
890 2011-11-02 Darin Adler <darin@apple.com>
892 Change remaining callers of releaseRef to call leakRef
893 https://bugs.webkit.org/show_bug.cgi?id=71422
895 Reviewed by Darin Fisher.
897 * History/WebBackForwardList.mm:
898 (-[WebBackForwardList initWithBackForwardList:]):
899 * History/WebHistoryItem.mm:
900 (-[WebHistoryItem copyWithZone:]):
901 (-[WebHistoryItem initWithWebCoreHistoryItem:]):
902 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
903 (-[WebHostedNetscapePluginView createPlugin]):
904 * Plugins/WebNetscapePluginView.mm:
905 (-[WebNetscapePluginView createPlugin]):
906 * WebCoreSupport/WebOpenPanelResultListener.mm:
907 * WebView/WebDataSource.mm:
908 (-[WebDataSource _initWithDocumentLoader:]):
909 * WebView/WebResource.mm:
910 (-[WebResourcePrivate initWithCoreResource:]):
913 2011-11-02 Joseph Pecoraro <pecoraro@apple.com>
915 Move NSRange / DOMRange conversion functions to WebFramePrivate
916 https://bugs.webkit.org/show_bug.cgi?id=71435
918 Reviewed by Sam Weinig.
920 Move conversion functions to WebFramePrivate,
921 and remove the no longer used versions.
923 * WebView/WebFrame.mm:
924 (-[WebFrame _convertNSRangeToDOMRange:]):
925 (-[WebFrame _convertDOMRangeToNSRange:]):
926 * WebView/WebFrameInternal.h:
927 * WebView/WebFramePrivate.h:
929 2011-11-02 Dean Jackson <dino@apple.com>
931 Add ENABLE_CSS_SHADERS flag
932 https://bugs.webkit.org/show_bug.cgi?id=71394
934 Reviewed by Sam Weinig.
936 * Configurations/FeatureDefines.xcconfig:
938 2011-11-02 Jon Lee <jonlee@apple.com>
940 Expand DragController to provide more information about the dragging session
941 https://bugs.webkit.org/show_bug.cgi?id=71324
942 <rdar://problem/10379175>
944 Reviewed by Darin Adler.
946 * WebView/WebView.mm:
947 (-[WebView draggingEntered:]): DragOperation is now inside the DragSession struct.
948 (-[WebView draggingUpdated:]):
950 2011-11-02 Tom Sepez <tsepez@chromium.org>
953 https://bugs.webkit.org/show_bug.cgi?id=70973
955 Reviewed by Adam Barth.
957 * WebCoreSupport/WebFrameLoaderClient.h:
958 * WebCoreSupport/WebFrameLoaderClient.mm:
959 (WebFrameLoaderClient::didRunInsecureContent):
960 (WebFrameLoaderClient::didDetectXSS):
961 * WebView/WebDelegateImplementationCaching.h:
962 * WebView/WebFrameLoadDelegatePrivate.h:
963 * WebView/WebView.mm:
964 (-[WebView _cacheFrameLoadDelegateImplementations]):
966 2011-11-01 Darin Adler <darin@apple.com>
968 Crash in PDF code when script has illegal UTF-8 or UTF-16 sequences
969 https://bugs.webkit.org/show_bug.cgi?id=71289
971 Reviewed by Dan Bernstein.
973 Just adding a null check. I don't have access to an actual PDF with
974 this problem but crashes from the field indicate they exist.
976 * WebView/WebPDFDocumentExtras.mm:
977 (allScriptsInPDFDocument): Skip the code to add the script text
978 to an array when the script is null.
980 2011-10-28 John Sullivan <sullivan@apple.com>
983 https://bugs.webkit.org/show_bug.cgi?id=71142
984 Whether backspace goes Back should be configurable
986 Reviewed by Sam Weinig.
988 * WebView/WebFrameView.mm:
989 (-[WebFrameView keyDown:]):
990 Honor the new preference.
992 * WebView/WebPreferenceKeysPrivate.h:
993 Added #define for WebKitBackspaceKeyNavigationEnabledKey
995 * WebView/WebPreferences.mm:
996 (+[WebPreferences initialize]):
997 Initialize new pref to YES, to match current behavior.
998 (-[WebPreferences setBackspaceKeyNavigationEnabled:]):
999 New method, standard prefs setter.
1000 (-[WebPreferences backspaceKeyNavigationEnabled]):
1001 New method, standard prefs getter.
1003 * WebView/WebPreferencesPrivate.h:
1004 Declared new methods.
1006 * WebView/WebView.mm:
1007 (-[WebView _preferencesChanged:]):
1008 Updates WebCore settings from WebKit prefs.
1010 2011-10-28 Jochen Eisinger <jochen@chromium.org>
1012 Rename a number of methods mentioning JavaScript to just Script instead
1013 https://bugs.webkit.org/show_bug.cgi?id=71105
1015 Reviewed by Adam Barth.
1017 * WebView/WebView.mm:
1018 (-[WebView _preferencesChanged:]):
1020 2011-10-27 Joseph Pecoraro <pecoraro@apple.com>
1022 Reviewed by David Kilzer.
1024 Make FeatureDefines Identical Across OS X Projects
1025 https://bugs.webkit.org/show_bug.cgi?id=71051
1027 * Configurations/FeatureDefines.xcconfig:
1029 2011-10-27 Mark Hahnenberg <mhahnenberg@apple.com>
1031 De-virtualize JSCell::toThisObject
1032 https://bugs.webkit.org/show_bug.cgi?id=70958
1034 Reviewed by Geoffrey Garen.
1036 Converted all instances of toThisObject to static functions,
1037 added toThisObject to the MethodTable, and replaced all call sites
1038 with a corresponding lookup in the MethodTable.
1040 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1041 (WebKit::NetscapePluginInstanceProxy::invoke):
1042 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1044 2011-10-25 Mark Hahnenberg <mhahnenberg@apple.com>
1046 Remove deletePropertyVirtual
1047 https://bugs.webkit.org/show_bug.cgi?id=70738
1049 Reviewed by Geoffrey Garen.
1051 Removed all declarations and definitions of deletePropertyVirtual.
1052 Also replaced all call sites to deletePropertyVirtual with a
1053 corresponding lookup in the MethodTable.
1055 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1056 (WebKit::NetscapePluginInstanceProxy::removeProperty):
1058 2011-10-25 Mark Hahnenberg <mhahnenberg@apple.com>
1061 https://bugs.webkit.org/show_bug.cgi?id=70740
1063 Reviewed by Geoffrey Garen.
1065 Removed all declarations and definitions of putVirtual.
1066 Also replaced all call sites to putVirtual with a
1067 corresponding lookup in the MethodTable.
1069 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1070 (WebKit::NetscapePluginInstanceProxy::setProperty):
1072 2011-10-24 Geoffrey Garen <ggaren@apple.com>
1074 Removed SharedUChar and tightened language around its previous uses
1075 https://bugs.webkit.org/show_bug.cgi?id=70698
1077 Reviewed by David Levin.
1079 - Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because
1080 the former names gave the dangerous misimpression that the resulting object
1081 was thread-safe, which is not true.
1083 * Storage/WebDatabaseTrackerClient.mm:
1084 (DidModifyOriginData::dispatchToMainThread):
1086 2011-10-24 Michael Saboff <msaboff@apple.com>
1088 WebKit doesn't build with recent changes to libdispatch
1089 https://bugs.webkit.org/show_bug.cgi?id=70737
1091 Added initialization for new WebKitSystemInterface function
1092 CreateVMPressureDispatchOnMainQueue.
1094 Reviewed by Geoffrey Garen.
1096 * WebCoreSupport/WebSystemInterface.mm:
1097 (InitWebCoreSystemInterface):
1099 2011-10-23 Mark Hahnenberg <mhahnenberg@apple.com>
1101 Remove getConstructDataVirtual
1102 https://bugs.webkit.org/show_bug.cgi?id=70638
1104 Reviewed by Darin Adler.
1106 Removed all declarations and definitions of getConstructDataVirtual.
1107 Also replaced all call sites to getConstructDataVirtual with a
1108 corresponding lookup in the MethodTable.
1110 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1111 (WebKit::NetscapePluginInstanceProxy::construct):
1113 2011-10-20 Ian Henderson <ianh@apple.com>
1115 https://bugs.webkit.org/show_bug.cgi?id=70541
1116 There are two WebFrameLoadDelegatePrivate categories on NSObject
1118 Reviewed by David Kilzer.
1120 * WebView/WebViewPrivate.h: Rename the private delegate categories in
1121 WebViewPrivate.h with a "WebView" prefix to avoid collision.
1123 2011-10-20 Alexey Proskuryakov <ap@apple.com>
1125 REGRESSION (r96823): Contextual menu closes immediately when control-clicking in Flash plug-in
1126 https://bugs.webkit.org/show_bug.cgi?id=70534
1127 <rdar://problem/10308827>
1129 Reviewed by Darin Adler.
1131 * WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): Return true
1132 for contextmenu event, so that plug-ins won't get a default WebKit context menu. We can't
1133 know if the plug-in is handling mousedown (or even mouseup) by displaying a menu.
1135 2011-10-19 Beth Dakin <bdakin@apple.com>
1137 https://bugs.webkit.org/show_bug.cgi?id=70396
1138 Focus rings are too thin in HiDPI in WebKit2
1140 <rdar://problem/10086876>
1142 Reviewed by Dan Bernstein.
1144 Rename wkSetPatternBaseCTM to wkSetBaseCTM
1145 * WebCoreSupport/WebSystemInterface.mm:
1146 (InitWebCoreSystemInterface):
1148 To create a HiDPI context in DRT, we have to set the base CTM, which currently
1149 requires CG SPI, so we have to do it through WebKitSystemInterface.
1150 * WebView/WebView.mm:
1151 (-[WebView _setBaseCTM:forContext:]):
1152 * WebView/WebViewPrivate.h:
1154 2011-10-18 Adam Barth <abarth@webkit.org>
1156 Always enable ENABLE(XPATH)
1157 https://bugs.webkit.org/show_bug.cgi?id=70217
1159 Reviewed by Eric Seidel.
1161 * Configurations/FeatureDefines.xcconfig:
1163 2011-10-14 Chris Marrin <cmarrin@apple.com>
1165 Throttle rate of requestAnimationFrame when page is not visible
1166 https://bugs.webkit.org/show_bug.cgi?id=67873
1168 Reviewed by Anders Carlsson.
1170 Plumb through notification when the window is hidden/shown or
1171 minimized/unminimized
1173 * WebView/WebView.mm:
1174 (-[WebView _windowWillOrderOnScreen:]):
1175 (-[WebView _windowWillOrderOffScreen:]):
1177 2011-10-16 Adam Barth <abarth@webkit.org>
1179 Always enable ENABLE(DOM_STORAGE)
1180 https://bugs.webkit.org/show_bug.cgi?id=70189
1182 Reviewed by Eric Seidel.
1184 * Configurations/FeatureDefines.xcconfig:
1185 * Storage/WebStorageManager.mm:
1186 * Storage/WebStorageManagerInternal.h:
1187 * Storage/WebStorageTrackerClient.h:
1188 * Storage/WebStorageTrackerClient.mm:
1189 (WebStorageTrackerClient::dispatchDidModifyOrigin):
1190 * WebView/WebView.mm:
1191 (-[WebView _commonInitializationWithFrameName:groupName:]):
1193 2011-10-14 David Kilzer <ddkilzer@apple.com>
1195 <http://webkit.org/b/70158> Fix clang compiler warnings
1197 Reviewed by Darin Adler.
1199 The following two methods in WebDelegateImplementationCaching.h
1200 are ambiguous in WebChromeClient::runJavaScriptPrompt() because
1201 the compiler can't decide how to convert the WTF::String
1202 defaultText argument:
1204 id CallUIDelegate(WebView *, SEL, id, id);
1205 id CallUIDelegate(WebView *, SEL, id, BOOL);
1207 The fix is to perform the conversion explicitly.
1209 * WebCoreSupport/WebChromeClient.mm:
1210 (WebChromeClient::runJavaScriptPrompt): Extract a defaultString
1211 variable to convert the WTF::String to an NSString*, then
1212 use defaultString in place of defaultText.
1214 2011-10-14 Mark Hahnenberg <mhahnenberg@apple.com>
1216 Rename virtual put to putVirtual
1217 https://bugs.webkit.org/show_bug.cgi?id=69851
1219 Reviewed by Darin Adler.
1221 Renamed virtual versions of put to putVirtual in prepration for
1222 adding the static put to the MethodTable in ClassInfo since the
1223 compiler gets mad if the virtual and static versions have the same
1226 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1227 (WebKit::NetscapePluginInstanceProxy::setProperty):
1229 2011-10-14 Mark Hahnenberg <mhahnenberg@apple.com>
1231 Rename virtual deleteProperty to deletePropertyVirtual
1232 https://bugs.webkit.org/show_bug.cgi?id=69884
1234 Reviewed by Darin Adler.
1236 Renamed virtual versions of deleteProperty to deletePropertyVirtual in prepration for
1237 adding the static deleteProperty to the MethodTable in ClassInfo since the
1238 compiler gets mad if the virtual and static versions have the same name.
1240 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1241 (WebKit::NetscapePluginInstanceProxy::removeProperty):
1243 2011-10-12 Ryosuke Niwa <rniwa@webkit.org>
1245 Make the interface of locationAndLengthFromRange and rangeFromLocationAndLength consistent
1246 https://bugs.webkit.org/show_bug.cgi?id=69964
1248 Reviewed by Enrica Casucci.
1250 * WebView/WebFrame.mm:
1251 (-[WebFrame _convertToNSRange:]):
1252 (-[WebFrame _convertToDOMRange:]):
1254 2011-10-13 Mark Hahnenberg <mhahnenberg@apple.com>
1256 Rename virtual getConstructData to getConstructDataVirtual
1257 https://bugs.webkit.org/show_bug.cgi?id=69872
1259 Reviewed by Geoffrey Garen.
1261 Renamed virtual getConstructData functions to getConstructDataVirtual to
1262 avoid conflicts when we add static getConstructData to the MethodTable.
1264 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1265 (WebKit::NetscapePluginInstanceProxy::construct):
1267 2011-10-13 Beth Dakin <bdakin@apple.com>
1269 https://bugs.webkit.org/show_bug.cgi?id=70050
1270 DRT and WRT should have HiDPI testing capabilities
1272 Reviewed by Darin Adler.
1274 New method _backingScaleFactor matches SPI of a similar name that I added
1275 recently to WKPage in WebKit2. Equivalent functionality is needed for
1276 DumpRenderTree's HiDPI support.
1277 * WebView/WebView.mm:
1278 (-[WebView _backingScaleFactor]):
1279 * WebView/WebViewPrivate.h:
1281 2011-10-12 Chris Marrin <cmarrin@apple.com>
1283 Sync requestAnimationFrame callback to CVDisplayLink on Mac
1284 https://bugs.webkit.org/show_bug.cgi?id=68911
1286 Reviewed by Simon Fraser.
1288 Add windowDidChangeScreen function which listens for the window changing
1289 screens and passes the new displayID along to WebCore::Page. It also sends
1290 one on windowWillOrderOnScreen, so the Page has a fresh displayID after it's
1293 * WebView/WebView.mm:
1294 (-[WebView addWindowObserversForWindow:]):
1295 (-[WebView removeWindowObservers]):
1296 (-[WebView _windowDidChangeScreen:]):
1297 (-[WebView _windowWillOrderOnScreen:]):
1299 2011-10-12 Adam Barth <abarth@webkit.org>
1301 Remove ENABLE(XHTMLMP) and associated code
1302 https://bugs.webkit.org/show_bug.cgi?id=69729
1304 Reviewed by David Levin.
1306 * Configurations/FeatureDefines.xcconfig:
1308 2011-10-10 Nate Chapin <japhet@chromium.org>
1310 Use a CachedImageClient instead of CachedResourceClient
1312 https://bugs.webkit.org/show_bug.cgi?id=69790
1314 Reviewed by Adam Barth.
1316 * WebView/WebHTMLView.mm:
1317 (promisedDataClient):
1319 2011-10-10 Mark Hahnenberg <mhahnenberg@apple.com>
1321 Remove getCallDataVirtual methods
1322 https://bugs.webkit.org/show_bug.cgi?id=69186
1324 Reviewed by Geoffrey Garen.
1326 Removed all getCallDataVirtual methods and replaced their call sites
1327 with an explicit lookup in the MethodTable.
1329 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1330 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1332 2011-10-10 Joseph Pecoraro <joepeck@webkit.org>
1334 Extract WebOpenPanelResultListener out into its own file
1335 https://bugs.webkit.org/show_bug.cgi?id=69575
1337 Reviewed by David Kilzer.
1339 Extract the WebOpenPanelResultListener class out into
1340 its own file. No functional change.
1342 * WebCoreSupport/WebChromeClient.mm:
1343 * WebCoreSupport/WebOpenPanelResultListener.h: Added.
1344 * WebCoreSupport/WebOpenPanelResultListener.mm: Added.
1345 (-[WebOpenPanelResultListener dealloc]):
1346 (-[WebOpenPanelResultListener finalize]):
1347 (-[WebOpenPanelResultListener cancel]):
1348 (-[WebOpenPanelResultListener chooseFilename:]):
1349 (-[WebOpenPanelResultListener chooseFilenames:]):
1350 * WebView/WebUIDelegate.h:
1352 2011-10-08 Sheriff Bot <webkit.review.bot@gmail.com>
1354 Unreviewed, rolling out r96996.
1355 http://trac.webkit.org/changeset/96996
1356 https://bugs.webkit.org/show_bug.cgi?id=69697
1358 It broke all tests on the Qt bot (Requested by Ossy_night on
1361 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1362 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1364 2011-10-07 Mark Hahnenberg <mhahnenberg@apple.com>
1366 Remove getCallDataVirtual methods
1367 https://bugs.webkit.org/show_bug.cgi?id=69186
1369 Reviewed by Geoffrey Garen.
1371 Removed all getCallDataVirtual methods and replaced their call sites
1372 with an explicit lookup in the MethodTable.
1374 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1375 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1377 2011-10-06 Anders Carlsson <andersca@apple.com>
1379 When building with clang, enable -Wglobal-constructors and -Wexit-time-destructors
1380 https://bugs.webkit.org/show_bug.cgi?id=69586
1382 Reviewed by Darin Adler.
1384 * Configurations/Base.xcconfig:
1385 Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.
1387 2011-10-06 Anders Carlsson <andersca@apple.com>
1389 Add DEFINE_DEBUG_ONLY_GLOBAL for globals that should be defined in debug builds
1390 https://bugs.webkit.org/show_bug.cgi?id=69584
1392 Reviewed by Darin Adler.
1394 Adopt the DEFINE_DEBUG_ONLY_GLOBAL macro.
1396 * Plugins/Hosted/HostedNetscapePluginStream.mm:
1397 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1399 2011-10-03 Andy Estes <aestes@apple.com>
1401 Add an option to suppress rendering until the document's load event fires.
1402 https://bugs.webkit.org/show_bug.cgi?id=69298
1404 Reviewed by Simon Fraser.
1406 Add a new private WebPreference.
1408 * WebView/WebPreferenceKeysPrivate.h:
1409 * WebView/WebPreferences.mm:
1410 (+[WebPreferences initialize]):
1411 (-[WebPreferences setSuppressRenderingWhileInitiallyLoading:]):
1412 (-[WebPreferences suppressRenderingWhileInitiallyLoading]):
1413 * WebView/WebPreferencesPrivate.h:
1414 * WebView/WebView.mm:
1415 (-[WebView _preferencesChanged:]):
1417 2011-10-05 Jer Noble <jer.noble@apple.com>
1419 Enable WEB_AUDIO by default in the WebKit/mac port.
1420 https://bugs.webkit.org/show_bug.cgi?id=68587
1422 Reviewed by Simon Fraser.
1424 * Configurations/FeatureDefines.xcconfig:
1426 2011-10-05 David Kilzer <ddkilzer@apple.com>
1428 <http://webkit.org/b/69386> REGRESSION: Curious Location of StorageTracker.db
1430 Reviewed by Alexey Proskuryakov.
1432 * Storage/WebStorageManager.mm:
1433 (+[WebStorageManager _storageDirectoryPath]): Restore call to
1434 -[NSString stringByStandardizingPath]. Also fix over-release of
1435 sLocalStoragePath if the initial -objectForKey: call returned an
1436 NSString object. Use pthread_once to be thread-safe.
1438 2011-10-04 Kent Tamura <tkent@chromium.org>
1440 Introduce feature flags for incomplete input types
1441 https://bugs.webkit.org/show_bug.cgi?id=68971
1443 Reviewed by Hajime Morita.
1445 * Configurations/FeatureDefines.xcconfig:
1446 Add ENABLE_INPUT_TYPE_* flags. They are enabled only for iOS.
1448 2011-10-03 Geoffrey Garen <ggaren@apple.com>
1450 Some JSValue cleanup
1451 https://bugs.webkit.org/show_bug.cgi?id=69320
1453 Reviewed by Darin Adler.
1455 * WebView/WebView.mm:
1456 (aeDescFromJSValue): Updated for JSC changes.
1458 2011-10-04 Scott Graham <scottmg@chromium.org>
1460 Add GAMEPAD feature flag
1461 https://bugs.webkit.org/show_bug.cgi?id=66859
1463 Reviewed by Darin Fisher.
1465 * Configurations/FeatureDefines.xcconfig:
1467 2011-10-03 Jer Noble <jer.noble@apple.com>
1469 Unreviewed, rolling out r96526.
1470 http://trac.webkit.org/changeset/96526
1471 https://bugs.webkit.org/show_bug.cgi?id=68587
1473 WEB_AUDIO has numerous 64->32 bit casting warnings, causing
1474 build breakages where -Wall is enabled.
1476 * Configurations/FeatureDefines.xcconfig:
1478 2011-10-03 Jer Noble <jer.noble@apple.com>
1480 Enable WEB_AUDIO by default in the WebKit/mac port.
1481 https://bugs.webkit.org/show_bug.cgi?id=68587
1483 Reviewed by Simon Fraser.
1485 * Configurations/FeatureDefines.xcconfig:
1487 2011-10-02 Sam Weinig <sam@webkit.org>
1489 Strength reduce Mac only Frame::searchForLabelsBeforeElement and Frame::matchLabelsAgainstElement into callers
1490 https://bugs.webkit.org/show_bug.cgi?id=69230
1492 Reviewed by Anders Carlsson.
1494 * WebView/WebHTMLRepresentation.mm:
1496 (searchForLabelsBeforeElement):
1497 (matchLabelsAgainstString):
1498 (matchLabelsAgainstElement):
1499 (-[WebHTMLRepresentation searchForLabels:beforeElement:resultDistance:resultIsInCellAbove:]):
1500 (-[WebHTMLRepresentation matchLabels:againstElement:]):
1502 2011-10-02 Alexey Proskuryakov <ap@apple.com>
1504 REGRESSION (r95474): Unable to type anywhere in nightly builds in WebKit1 mode
1505 https://bugs.webkit.org/show_bug.cgi?id=68542
1507 Reviewed by Mark Rowe.
1509 * WebView/WebView.mm: (-[WebView _usesDocumentViews]): Re-add this method for now.
1511 2011-10-01 Geoffrey Garen <ggaren@apple.com>
1513 Leopard build fix: Updated for Strong<T> changes.
1515 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1516 * WebView/WebScriptDebugger.mm:
1518 2011-09-28 Joseph Pecoraro <joepeck@webkit.org>
1520 ASSERT if WebView's UIDelegate does not implement webView:runOpenPanel
1521 https://bugs.webkit.org/show_bug.cgi?id=69037
1523 Reviewed by Alexey Proskuryakov.
1525 * WebCoreSupport/WebChromeClient.mm:
1526 (WebChromeClient::runOpenPanel):
1527 If no delegate is implemented, dismiss the listener
1528 with a cancel. It expects some action.
1530 2011-09-28 Anton D'Auria <adauria@apple.com>
1532 Expose +[WebStorageManager _storageDirectoryPath] as SPI
1533 https://bugs.webkit.org/show_bug.cgi?id=68951
1535 Reviewed by Brady Eidson.
1537 This patch exposes +[WebStorageManager _storageDirectoryPath], which
1538 pulls the path from NSUserDefaults if the preference is set. Otherwise,
1539 it falls back on the default path.
1541 * Storage/WebStorageManager.mm:
1542 (+[WebStorageManager _storageDirectoryPath]): Adding static variable
1543 so that we don't reread user defaults repeatedly.
1544 (WebKitInitializeStorageIfNecessary):
1545 * Storage/WebStorageManagerPrivate.h:
1547 2011-09-27 Andy Estes <aestes@apple.com>
1549 WebKitLinkedOnOrAfter() check is ineffective for Solar Walk app-specific hack.
1550 https://bugs.webkit.org/show_bug.cgi?id=68863
1552 Reviewed by Darin Adler.
1554 The SolarWalk binary does not link against WebKit.framework directly,
1555 so calling NSVersionOfLinkTimeLibrary() will not return the version of
1556 WebKit against which SolarWalk was linked. Since Solar Walk has
1557 released an update that addresses the issue for which this app-specific
1558 hack was originally added, we should just remove the hack.
1560 * Misc/SolarWalkQuirksUserScript.js: Removed.
1561 * WebView/WebView.mm: Removed needsSolarWalkQuirksScript(),
1562 leakSolarWalkQuirksUserScriptContents(), and
1563 -[WebView _injectSolarWalkQuirksScript].
1564 (-[WebView _commonInitializationWithFrameName:groupName:]): Do not
1565 inject the Solar Walk quirks script.
1567 2011-09-27 Mark Hahnenberg <mhahnenberg@apple.com>
1569 Add static version of JSCell::getCallData
1570 https://bugs.webkit.org/show_bug.cgi?id=68741
1572 Reviewed by Darin Adler.
1574 In this patch we just extract the bodies of the virtual getCallData methods
1575 throughout the JSCell inheritance hierarchy out into static methods, which are
1576 now called from the virtual methods. This is an intermediate step in trying to
1577 move the virtual-ness of getCallData into our own method table stored in
1578 ClassInfo. We need to convert the methods to static methods because static methods
1579 can be represented as function pointers rather than pointers to member functions, and
1580 function pointers are smaller and faster to call than pointers to member functions.
1582 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1583 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1585 2011-09-23 Simon Fraser <simon.fraser@apple.com>
1587 Repaint tests don't work in WebKit2
1588 https://bugs.webkit.org/show_bug.cgi?id=68453
1590 Reviewed by Sam Weinig.
1592 Have FrameView keep track of repaint rects when asked to, and
1593 expose this set of repaint rects via private WebKit API for later
1594 use by DumpRenderTree.
1596 * WebView/WebView.mm:
1597 (-[WebView setTracksRepaints:]):
1598 (-[WebView isTrackingRepaints]):
1599 (-[WebView resetTrackedRepaints]):
1600 (-[WebView trackedRepaintRects]):
1601 * WebView/WebViewPrivate.h:
1603 2011-09-25 Mark Hahnenberg <mhahnenberg@apple.com>
1605 Add custom vtable struct to ClassInfo struct
1606 https://bugs.webkit.org/show_bug.cgi?id=68567
1608 Reviewed by Oliver Hunt.
1610 Added CREATE_METHOD_TABLE macro to generate the custom vtable for the
1611 specified class in its ClassInfo. Also added to it the first function to use
1612 this macro, visitChildren. This is part of the process of getting rid of all
1613 C++ virtual methods in JSCell. Eventually all virtual functions in JSCell
1614 that can't easily be converted to non-virtual functions will be put into
1615 this custom vtable structure.
1617 * Plugins/Hosted/ProxyInstance.mm:
1618 * Plugins/Hosted/ProxyRuntimeObject.mm:
1620 2011-09-24 Adam Barth <abarth@webkit.org>
1622 Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
1623 https://bugs.webkit.org/show_bug.cgi?id=68767
1625 Reviewed by Eric Seidel.
1627 * Configurations/FeatureDefines.xcconfig:
1629 (+[WebCache empty]):
1630 * WebCoreSupport/WebApplicationCache.mm:
1631 * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
1632 (-[WebApplicationCacheQuotaManager usage]):
1633 (-[WebApplicationCacheQuotaManager quota]):
1634 (-[WebApplicationCacheQuotaManager setQuota:]):
1635 * WebCoreSupport/WebChromeClient.h:
1636 * WebCoreSupport/WebChromeClient.mm:
1637 * WebView/WebDataSource.mm:
1638 (-[WebDataSource _transferApplicationCache:]):
1639 * WebView/WebFrame.mm:
1640 (-[WebFrame _cacheabilityDictionary]):
1641 * WebView/WebView.mm:
1642 (WebKitInitializeApplicationCachePathIfNecessary):
1644 2011-09-23 Adam Klein <adamk@chromium.org>
1646 Add ENABLE_MUTATION_OBSERVERS feature flag
1647 https://bugs.webkit.org/show_bug.cgi?id=68732
1649 Reviewed by Ojan Vafai.
1651 This flag will guard an implementation of the "Mutation Observers" proposed in
1652 http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html
1654 * Configurations/FeatureDefines.xcconfig:
1656 2011-09-23 Anders Carlsson <andersca@apple.com>
1658 Axe WebImageRendererFactory
1659 https://bugs.webkit.org/show_bug.cgi?id=68715
1661 Reviewed by Darin Adler.
1663 Remove WebImageRendererFactory, it was used by Safari 3, many a moon ago.
1665 * WebCoreSupport/WebImageRendererFactory.m: Removed.
1667 2011-09-23 Anders Carlsson <andersca@apple.com>
1669 Add OVERRIDE to a bunch of virtual member functions on clients
1670 https://bugs.webkit.org/show_bug.cgi?id=68712
1672 Reviewed by Sam Weinig.
1674 * Configurations/Base.xcconfig:
1675 * WebCoreSupport/WebChromeClient.h:
1676 * WebCoreSupport/WebContextMenuClient.h:
1677 * WebCoreSupport/WebDeviceOrientationClient.h:
1678 * WebCoreSupport/WebDragClient.h:
1679 * WebCoreSupport/WebEditorClient.h:
1680 * WebCoreSupport/WebFrameLoaderClient.h:
1681 * WebCoreSupport/WebFrameNetworkingContext.h:
1682 * WebCoreSupport/WebGeolocationClient.h:
1683 * WebCoreSupport/WebIconDatabaseClient.h:
1684 * WebCoreSupport/WebInspectorClient.h:
1685 * WebCoreSupport/WebPlatformStrategies.h:
1687 2011-09-22 Dean Jackson <dino@apple.com>
1689 Add ENABLE_CSS_FILTERS
1690 https://bugs.webkit.org/show_bug.cgi?id=68652
1692 Reviewed by Simon Fraser.
1694 * Configurations/FeatureDefines.xcconfig:
1696 2011-09-22 Anders Carlsson <andersca@apple.com>
1698 Get rid of Widget::setBoundsSize
1699 https://bugs.webkit.org/show_bug.cgi?id=68491
1701 Reviewed by Sam Weinig.
1703 This basically reverts http://trac.webkit.org/changeset/79167 and http://trac.webkit.org/changeset/75897
1704 which were added to make zoom gestures work with WebKit1, but since we don't support zoom gestures in WebKit1
1705 anymore, it's better for code cleanliness to get rid of Widget::setBoundsSize and the associated code. While this
1706 will unfortunately break transformed iframes in WebKit1, but Simon says that it's an acceptable tradeoff.
1708 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1709 (-[WebHostedNetscapePluginView updateAndSetWindow]):
1710 * WebView/WebFrameView.mm:
1712 2011-09-19 Jer Noble <jer.noble@apple.com>
1714 Add settings to control the availability of the Web Audio API to WebKit and WebKit2.
1715 https://bugs.webkit.org/show_bug.cgi?id=68382
1717 Reviewed by Darin Adler.
1719 Initialize the webAudioEnabled preference to NO by default.
1721 * WebView/WebPreferences.mm:
1722 (+[WebPreferences initialize]):
1724 2011-09-21 Anders Carlsson <andersca@apple.com>
1726 Remove checks for Leopard-only Objective-C APIs
1727 https://bugs.webkit.org/show_bug.cgi?id=68579
1729 Reviewed by Sam Weinig.
1731 We can always assume that OBJC_API_VERSION is at least 2, it's been 2 since Leopard.
1733 * Misc/WebNSObjectExtras.h:
1735 2011-09-21 Andras Becsi <andras.becsi@nokia.com>
1737 [Qt] Remove Qt specific code from css/SelectorChecker.cpp
1738 https://bugs.webkit.org/show_bug.cgi?id=67702
1740 Reviewed by Csaba Osztrogonác.
1742 * WebCoreSupport/WebPlatformStrategies.h:
1743 * WebCoreSupport/WebPlatformStrategies.mm:
1744 (WebPlatformStrategies::isLinkVisited):
1746 2011-09-20 Anders Carlsson <andersca@apple.com>
1748 Remove ScrollView::platformContentsSize
1749 https://bugs.webkit.org/show_bug.cgi?id=68188
1751 Reviewed by Darin Adler.
1753 When creating the document view, make sure it's zero sized which matches the initial size
1754 of the ScrollView. This is fine to do early since DocumentWriter::begin sets the contents
1755 size to a zero size anyway.
1757 * WebView/WebFrameView.mm:
1758 (-[WebFrameView _makeDocumentViewForDataSource:]):
1760 2011-09-19 Pavel Feldman <pfeldman@google.com>
1762 Web Inspector: streamline Console's MessageType and MessageSource semantics.
1763 https://bugs.webkit.org/show_bug.cgi?id=68342
1765 This change fixes semantics of the MessageSource and MessageType:
1766 MessageSource is now the source of the message (be it Network, HTML
1767 parser or Console API). MessageType is only defined for the Console API
1768 messages and contains the name of the API call (log, dir, dirxml, etc.).
1769 Subsequent https://bugs.webkit.org/show_bug.cgi?id=66371 will make MessageType
1770 private to the inspector.
1772 Reviewed by Tony Gentilcore.
1774 * WebCoreSupport/WebChromeClient.mm:
1775 (stringForMessageSource):
1776 (stringForMessageType):
1777 * WebView/WebUIDelegatePrivate.h:
1779 2011-09-19 Timothy Hatcher <timothy@apple.com>
1781 Make WebViews in NSPopovers render as they would in active windows.
1783 The NSWindowDid{Become,Resign}KeyNotifications are not fired when NSPopovers
1784 are shown or hidden since they share key with the parent window. So WebView
1785 and WebHTMLView need to also observe the will order on/off screen notifications.
1787 https://webkit.org/b/68402
1788 rdar://problem/9754099
1790 Reviewed by John Sullivan.
1792 * WebView/WebHTMLView.mm:
1793 (-[WebHTMLView _removeWindowObservers]): Remove order on/off screen notification obversers.
1794 (-[WebHTMLView addWindowObservers]): Add order on/off screen notification obversers.
1795 (-[WebHTMLView windowWillOrderOnScreen:]): Check if the window is already a key window,
1796 which can be the case for NSPopovers.
1797 (-[WebHTMLView windowWillOrderOffScreen:]): Remove the mouse moved observer.
1798 * WebView/WebView.mm:
1799 (-[WebView addWindowObserversForWindow:]): Add order off screen notification obverser.
1800 (-[WebView removeWindowObservers]): Remove order off screen notification obverser.
1801 (-[WebView _windowWillOrderOnScreen:]): Call _updateActiveState.
1802 (-[WebView _windowWillOrderOffScreen:]): Ditto.
1804 2011-09-19 Mark Rowe <mrowe@apple.com>
1806 <http://webkit.org/b/68421> Stop calling UpdateSystemActivity in places where we hold power assertions that achieve the same effect
1808 On SnowLeopard and newer it's not necessary to call UpdateSystemActivity to prevent the screensaver from kicking
1809 in as the NoDisplaySleep assertion now has that effect. It's also not necessary to hold both a NoDisplaySleep and
1810 a NoIdleSleep assertion as the latter is implied by the former.
1812 Adopt the DisplaySleepDisabler class that was added to WebCore and remove all of duplicated logic from WebFullScreenController.
1814 Reviewed by Dan Bernstein.
1816 * WebView/WebFullScreenController.h:
1817 * WebView/WebFullScreenController.mm:
1818 (-[WebFullScreenController dealloc]):
1819 (-[WebFullScreenController _updatePowerAssertions]): Create a DisplaySleepDisabler instance when transitioning from permitting
1820 display sleep to disabling display sleep. Clear out our reference when sleep should be permitted, destroying any
1821 disabler that we own.
1823 2011-09-19 Adam Barth <abarth@webkit.org>
1825 Always enable ENABLE(EVENTSOURCE)
1826 https://bugs.webkit.org/show_bug.cgi?id=68414
1828 Reviewed by Eric Seidel.
1830 * Configurations/FeatureDefines.xcconfig:
1832 2011-09-19 Anders Carlsson <andersca@apple.com>
1834 Fix crashes when running WebKit1 tests.
1836 -[WebView _mustDrawUnionedRect:singleRects:count:] was removed, so just put back the
1837 equivalent code directly into -[WebHTMLView drawRect:].
1839 * WebView/WebHTMLView.mm:
1840 (-[WebHTMLView drawRect:]):
1841 * WebView/WebViewInternal.h:
1843 2011-09-19 Anders Carlsson <andersca@apple.com>
1845 Remove the last remains of viewless WebKit1
1846 https://bugs.webkit.org/show_bug.cgi?id=68388
1848 Reviewed by Darin Adler.
1850 * WebCoreSupport/WebFrameLoaderClient.mm:
1851 (WebFrameLoaderClient::forceLayoutForNonHTML):
1854 * WebView/WebView.mm:
1855 (-[WebView _commonInitializationWithFrameName:groupName:]):
1856 Remove usesDocumentViews parameter and checks.
1858 (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]):
1859 Add an assertion that usesDocumentViews is always true.
1861 (-[WebView _isUsingAcceleratedCompositing]):
1862 Remove usesDocumentViews check.
1864 (-[WebView _isSoftwareRenderable]):
1865 Remove usesDocumentViews check.
1867 (-[WebView initWithFrame:frameName:groupName:]):
1868 Remove usesDocumentViews parameter and always pass YES to the _initWithFrame method.
1870 (-[WebView initWithCoder:]):
1871 Remove usesDocumentViews parameter.
1873 (-[WebView _frameViewAtWindowPoint:]):
1874 Remove usesDocumentViews check.
1876 * WebView/WebViewData.h:
1877 Remove usesDocumentViews ivar.
1879 * WebView/WebViewPrivate.h:
1880 Remove usesDocumentViews parameters.
1882 2011-09-19 Anders Carlsson <andersca@apple.com>
1884 Remove WebViewEventHandling.mm
1885 https://bugs.webkit.org/show_bug.cgi?id=68387
1887 Reviewed by Adam Roben.
1889 WebViewEventHandling.mm was all about event handling in viewless WebKit, so rip it out since
1890 we're getting rid of viewless WebKit1.
1892 * WebView/WebView.mm:
1893 (-[WebView _close]):
1894 * WebView/WebViewData.h:
1895 * WebView/WebViewEventHandling.mm: Removed.
1896 * WebView/WebViewInternal.h:
1898 2011-09-19 Anders Carlsson <andersca@apple.com>
1900 Remove -[WebView _selectionChanged] and -[WebView _setTooltip:]
1901 https://bugs.webkit.org/show_bug.cgi?id=68385
1903 Reviewed by Adam Roben.
1905 Move these functions back into the respective clients and remove usesDocumentViews checks.
1907 * WebCoreSupport/WebChromeClient.mm:
1908 (WebChromeClient::setToolTip):
1909 * WebCoreSupport/WebEditorClient.mm:
1910 (WebEditorClient::respondToChangedSelection):
1911 * WebView/WebView.mm:
1912 * WebView/WebViewEventHandling.mm:
1913 * WebView/WebViewInternal.h:
1915 2011-09-19 Anders Carlsson <andersca@apple.com>
1917 Begin removing -[WebView _usesDocumentCalls] from WebView.mm
1918 https://bugs.webkit.org/show_bug.cgi?id=68383
1920 Reviewed by Adam Roben.
1922 Remove checks and begin assuming that -[WebView _usesDocumentViews] always
1923 returns true, since viewless WebKit1 has been abandoned.
1925 * WebView/WebView.mm:
1926 (-[WebView selectedFrame]):
1927 (-[WebView setHostWindow:]):
1928 (-[WebView acceptsFirstResponder]):
1929 (-[WebView becomeFirstResponder]):
1930 (-[WebView _webcore_effectiveFirstResponder]):
1931 (-[WebView setNextKeyView:]):
1932 (-[WebView setHoverFeedbackSuspended:]):
1934 2011-09-19 Anders Carlsson <andersca@apple.com>
1936 Remove calls to -[WebView _usesDocumentViews] from WebFrameLoaderClient.mm
1937 https://bugs.webkit.org/show_bug.cgi?id=68379
1939 Reviewed by Adam Roben.
1941 Remove checks and begin assuming that -[WebView _usesDocumentViews] always
1942 returns true, since viewless WebKit1 has been abandoned.
1944 * WebCoreSupport/WebFrameLoaderClient.mm:
1945 (WebFrameLoaderClient::hasHTMLView):
1946 (WebFrameLoaderClient::dispatchDidCommitLoad):
1947 (WebFrameLoaderClient::transitionToCommittedForNewPage):
1948 (WebFrameLoaderClient::createFrame):
1949 * WebView/WebFrame.mm:
1950 (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1951 (-[WebFrame _hasSelection]):
1952 (-[WebFrame _clearSelection]):
1953 (-[WebFrame _shouldFlattenCompositingLayers:]):
1954 (-[WebFrame _dragSourceEndedAt:operation:]):
1955 (-[WebFrame frameView]):
1957 2011-09-19 Anders Carlsson <andersca@apple.com>
1959 Remove calls to -[WebView _usesDocumentViews]
1960 https://bugs.webkit.org/show_bug.cgi?id=68377
1962 Reviewed by Adam Roben.
1964 Remove checks and begin assuming that -[WebView _usesDocumentViews] always
1965 returns true, since viewless WebKit1 has been abandoned.
1967 * WebCoreSupport/WebChromeClient.mm:
1968 (WebChromeClient::windowResizerRect):
1969 (WebChromeClient::invalidateContentsAndWindow):
1970 (WebChromeClient::screenToWindow):
1971 (WebChromeClient::windowToScreen):
1972 (WebChromeClient::platformPageClient):
1973 (WebChromeClient::scrollRectIntoView):
1974 (WebChromeClient::print):
1975 * WebView/WebDataSource.mm:
1976 (-[WebDataSource _receivedData:]):
1978 2011-09-19 Dan Bernstein <mitz@apple.com>
1980 WebKit part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
1981 https://bugs.webkit.org/show_bug.cgi?id=68323
1983 Reviewed by Sam Weinig.
1985 Renamed NonBlockingPanel to WebNonBlockingPanel.
1986 Renamed ThreadEnabler to WebCocoaThreadingEnabler.
1987 Renamed PDFPrefUpdatingProxy to WebPDFPrefUpdatingProxy.
1989 * Misc/WebIconDatabase.mm:
1990 (+[WebCocoaThreadingEnabler enableThreading]):
1991 (importToWebCoreFormat):
1992 * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
1993 * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
1994 * Panels/WebAuthenticationPanel.h:
1995 * Panels/WebAuthenticationPanel.m: Renamed NonBlockingPanel to
1996 WebNonBlockingPanel. Because Safari 5.1 uses NonBlockingPanel, this will
1997 cause nightly builds to log an error message when showing the Safari
1998 HTTP authentication sheet and disable the Quit command while the sheet
2000 * WebView/WebPDFView.mm:
2001 (-[WebPDFView initWithFrame:]):
2002 (-[WebPDFView _updatePreferencesSoon]):
2004 2011-09-17 Mihai Parparita <mihaip@chromium.org>
2006 FrameLoaderClient BackForwardList-related methods are unsued
2007 https://bugs.webkit.org/show_bug.cgi?id=68293
2009 Reviewed by Darin Adler.
2011 Remove FrameLoaderClient methods that were added by r51629, since only
2012 the old (since-deleted) Android port needed them.
2014 * WebCoreSupport/WebFrameLoaderClient.h:
2015 * WebCoreSupport/WebFrameLoaderClient.mm:
2018 2011-09-16 Simon Fraser <simon.fraser@apple.com>
2020 Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
2021 https://bugs.webkit.org/show_bug.cgi?id=68134
2023 Reviewed by Sam Weinig.
2025 Hook up a private preference that enables the mock scrollbar theme.
2027 * WebView/WebPreferenceKeysPrivate.h:
2028 * WebView/WebPreferences.mm:
2029 (-[WebPreferences mockScrollbarsEnabled]):
2030 (-[WebPreferences setMockScrollbarsEnabled:]):
2031 * WebView/WebPreferencesPrivate.h:
2033 2011-09-15 Adam Barth <abarth@webkit.org>
2035 Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
2036 https://bugs.webkit.org/show_bug.cgi?id=68205
2038 Reviewed by Eric Seidel.
2040 * Storage/WebDatabaseManager.mm:
2041 * Storage/WebDatabaseManagerInternal.h:
2042 * Storage/WebDatabaseManagerPrivate.h:
2043 * Storage/WebDatabaseQuotaManager.mm:
2044 (-[WebDatabaseQuotaManager usage]):
2045 (-[WebDatabaseQuotaManager quota]):
2046 (-[WebDatabaseQuotaManager setQuota:]):
2047 * Storage/WebDatabaseTrackerClient.h:
2048 * Storage/WebDatabaseTrackerClient.mm:
2049 * WebCoreSupport/WebChromeClient.h:
2050 * WebCoreSupport/WebChromeClient.mm:
2051 * WebCoreSupport/WebSecurityOrigin.mm:
2052 (-[WebSecurityOrigin usage]):
2053 (-[WebSecurityOrigin quota]):
2054 (-[WebSecurityOrigin setQuota:]):
2055 * WebView/WebFrame.mm:
2056 (-[WebFrame _cacheabilityDictionary]):
2057 * WebView/WebView.mm:
2058 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2059 (-[WebView _preferencesChanged:]):
2061 2011-09-15 Mark Hahnenberg <mhahnenberg@apple.com>
2063 Unzip initialization lists and constructors in JSCell hierarchy (7/7)
2064 https://bugs.webkit.org/show_bug.cgi?id=68122
2066 Reviewed by Geoffrey Garen.
2068 Completed the seventh and final level of the refactoring to add finishCreation()
2069 methods to all classes within the JSCell hierarchy with non-trivial
2072 * Plugins/Hosted/ProxyInstance.mm:
2073 (WebKit::ProxyRuntimeMethod::create):
2074 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
2075 * Plugins/Hosted/ProxyRuntimeObject.h:
2076 (WebKit::ProxyRuntimeObject::create):
2077 * Plugins/Hosted/ProxyRuntimeObject.mm:
2078 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
2080 2011-09-15 Kentaro Hara <haraken@google.com>
2082 A single line must not be split into two pages.
2083 https://bugs.webkit.org/show_bug.cgi?id=65005
2085 Reviewed by David Hyatt.
2087 When the document width of a page is overflowed, the last line of the page can be
2088 split into the next page. This is the regression caused by r88737. r88737 tried to
2089 fix rounding errors in rendering calculations by expanding and shrinking a page
2090 using one common method, resizePageRectsKeepingRatio(), but overlooked the case where
2091 a document width gets overflowed.
2093 Test: printing/single-line-must-not-be-split-into-two-pages.html
2095 * WebView/WebHTMLView.mm:
2096 (-[WebHTMLView _web_setPrintingModeRecursive]): Passes an original page size to setPrinting().
2097 (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
2098 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
2099 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Ditto.
2100 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]): Ditto.
2101 (-[WebHTMLView _endPrintMode]): Ditto.
2102 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]): Ditto.
2103 (-[WebHTMLView _endScreenPaginationMode]): Ditto.
2104 (-[WebHTMLView layoutToMinimumPageWidth:height:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustingViewSize:]): Ditto.
2105 (-[WebHTMLView layout]): Ditto.
2106 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]): Ditto.
2107 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
2108 (-[WebHTMLView setPageWidthForPrinting:]): Ditto.
2110 2011-09-15 Eric Seidel <eric@webkit.org>
2112 Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
2113 https://bugs.webkit.org/show_bug.cgi?id=68182
2115 Reviewed by Adam Barth.
2117 * Configurations/FeatureDefines.xcconfig:
2119 2011-09-15 Eric Seidel <eric@webkit.org>
2121 Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
2122 https://bugs.webkit.org/show_bug.cgi?id=68022
2124 Reviewed by Ryosuke Niwa.
2126 * Configurations/FeatureDefines.xcconfig:
2128 2011-09-14 Anders Carlsson <andersca@apple.com>
2130 Get rid of WebCoreViewFactory and its WebViewFactory subclass
2131 https://bugs.webkit.org/show_bug.cgi?id=68124
2133 Reviewed by Sam Weinig.
2135 * WebCoreSupport/WebContextMenuClient.mm:
2136 * WebCoreSupport/WebViewFactory.h: Removed.
2137 * WebCoreSupport/WebViewFactory.mm: Removed.
2138 * WebView/WebFrameView.mm:
2139 (-[WebFrameView initWithFrame:]):
2141 2011-09-14 Mark Hahnenberg <mhahnenberg@apple.com>
2143 Unzip initialization lists and constructors in JSCell hierarchy (6/7)
2144 https://bugs.webkit.org/show_bug.cgi?id=67692
2146 Reviewed by Geoffrey Garen.
2148 Completed the sixth level of the refactoring to add finishCreation()
2149 methods to all classes within the JSCell hierarchy with non-trivial
2152 This primarily consists of pushing the calls to finishCreation() down
2153 into the constructors of the subclasses of the fifth level of the hierarchy
2154 as well as pulling the finishCreation() calls out into the class's corresponding
2155 create() method if it has one. Doing both simultaneously allows us to
2156 maintain the invariant that the finishCreation() method chain is called exactly
2157 once during the creation of an object, since calling it any other number of
2158 times (0, 2, or more) will cause an assertion failure.
2160 * Plugins/Hosted/ProxyInstance.mm:
2161 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
2162 (WebKit::ProxyRuntimeMethod::finishCreation):
2164 2011-09-13 Eric Seidel <eric@webkit.org>
2166 Remove ENABLE_SVG_USE as <use> is required by HTML5
2167 https://bugs.webkit.org/show_bug.cgi?id=68019
2169 Reviewed by Ryosuke Niwa.
2171 * Configurations/FeatureDefines.xcconfig:
2173 2011-09-13 Anders Carlsson <andersca@apple.com>
2175 Disable C++ exceptions when building with clang
2176 https://bugs.webkit.org/show_bug.cgi?id=68031
2177 <rdar://problem/9556880>
2179 Reviewed by Mark Rowe.
2181 * Configurations/Base.xcconfig:
2183 2011-09-13 Eric Seidel <eric@webkit.org>
2185 Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
2186 https://bugs.webkit.org/show_bug.cgi?id=68018
2188 Reviewed by Ryosuke Niwa.
2190 * Configurations/FeatureDefines.xcconfig:
2192 2011-09-09 Oliver Hunt <oliver@apple.com>
2194 Remove support for anonymous storage from jsobjects
2195 https://bugs.webkit.org/show_bug.cgi?id=67881
2197 Reviewed by Sam Weinig.
2199 Remove the use of AnonymousSlotCount
2201 * Plugins/Hosted/ProxyInstance.mm:
2202 (WebKit::ProxyRuntimeMethod::createStructure):
2203 * Plugins/Hosted/ProxyRuntimeObject.h:
2204 (WebKit::ProxyRuntimeObject::createStructure):
2206 2011-09-09 Chris Marrin <cmarrin@apple.com>
2208 requestAnimationFrame doesn't throttle on Mac
2209 https://bugs.webkit.org/show_bug.cgi?id=67171
2211 Reviewed by Simon Fraser.
2213 Removed runLoopObserver for requestAnimationFrame. It's now
2214 done by a Timer in ScriptedAnimationController in WebCore.
2216 * WebCoreSupport/WebChromeClient.h:
2217 * WebCoreSupport/WebChromeClient.mm:
2218 * WebView/WebView.mm:
2219 (-[WebView _close]):
2220 * WebView/WebViewData.h:
2221 * WebView/WebViewInternal.h:
2223 2011-09-09 Fady Samuel <fsamuel@chromium.org>
2225 Move pageScaleFactor code from Frame.{h|cpp} to Page.{h|cpp}
2226 https://bugs.webkit.org/show_bug.cgi?id=67250
2228 Reviewed by Simon Fraser.
2230 * WebView/WebView.mm:
2231 (-[WebView _scaleWebView:atOrigin:]):
2232 (-[WebView _viewScaleFactor]):
2234 2011-09-09 Mark Hahnenberg <mhahnenberg@apple.com>
2236 Unzip initialization lists and constructors in JSCell hierarchy (5/7)
2237 https://bugs.webkit.org/show_bug.cgi?id=67420
2239 Reviewed by Geoffrey Garen.
2241 Completed the fifth level of the refactoring to add finishCreation()
2242 methods to all classes within the JSCell hierarchy with non-trivial
2245 This primarily consists of pushing the calls to finishCreation() down
2246 into the constructors of the subclasses of the second level of the hierarchy
2247 as well as pulling the finishCreation() calls out into the class's corresponding
2248 create() method if it has one. Doing both simultaneously allows us to
2249 maintain the invariant that the finishCreation() method chain is called exactly
2250 once during the creation of an object, since calling it any other number of
2251 times (0, 2, or more) will cause an assertion failure.
2253 * Plugins/Hosted/ProxyRuntimeObject.h:
2254 * Plugins/Hosted/ProxyRuntimeObject.mm:
2255 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
2256 (WebKit::ProxyRuntimeObject::finishCreation):
2258 2011-09-08 Sam Weinig <sam@webkit.org>
2260 Remove the Completion object from JSC, I have never liked it
2261 https://bugs.webkit.org/show_bug.cgi?id=67755
2263 Reviewed by Gavin Barraclough.
2265 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2266 (WebKit::NetscapePluginInstanceProxy::evaluate):
2268 2011-09-07 Sheriff Bot <webkit.review.bot@gmail.com>
2270 Unreviewed, rolling out r94627 and r94632.
2271 http://trac.webkit.org/changeset/94627
2272 http://trac.webkit.org/changeset/94632
2273 https://bugs.webkit.org/show_bug.cgi?id=67698
2275 It broke tests on GTK and Qt (Requested by Ossy on #webkit).
2277 * Plugins/Hosted/ProxyRuntimeObject.h:
2278 * Plugins/Hosted/ProxyRuntimeObject.mm:
2279 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
2281 2011-09-06 Mark Hahnenberg <mhahnenberg@apple.com>
2283 Unzip initialization lists and constructors in JSCell hierarchy (5/7)
2284 https://bugs.webkit.org/show_bug.cgi?id=67420
2286 Reviewed by Geoffrey Garen.
2288 Completed the fifth level of the refactoring to add finishCreation()
2289 methods to all classes within the JSCell hierarchy with non-trivial
2292 This primarily consists of pushing the calls to finishCreation() down
2293 into the constructors of the subclasses of the second level of the hierarchy
2294 as well as pulling the finishCreation() calls out into the class's corresponding
2295 create() method if it has one. Doing both simultaneously allows us to
2296 maintain the invariant that the finishCreation() method chain is called exactly
2297 once during the creation of an object, since calling it any other number of
2298 times (0, 2, or more) will cause an assertion failure.
2300 * Plugins/Hosted/ProxyRuntimeObject.h:
2301 * Plugins/Hosted/ProxyRuntimeObject.mm:
2302 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
2303 (WebKit::ProxyRuntimeObject::finishCreation):
2305 2011-09-06 Ryosuke Niwa <rniwa@webkit.org>
2307 Rename confirmCompositionWithoutDisturbingSelection to cancelComposition
2308 https://bugs.webkit.org/show_bug.cgi?id=67569
2310 Reviewed by Antonio Gomes.
2312 * WebView/WebHTMLView.mm:
2313 (-[WebHTMLView _updateSelectionForInputManager]):
2315 2011-09-05 Oliver Hunt <oliver@apple.com>
2317 An object's structure should reference the global object responsible for its creation
2318 https://bugs.webkit.org/show_bug.cgi?id=67624
2320 Reviewed by Gavin Barraclough.
2322 Update for new Structure::create() globalObject parameter.
2324 * Plugins/Hosted/ProxyInstance.mm:
2325 (WebKit::ProxyRuntimeMethod::createStructure):
2326 * Plugins/Hosted/ProxyRuntimeObject.h:
2327 (WebKit::ProxyRuntimeObject::createStructure):
2329 2011-09-01 Mark Rowe <mrowe@apple.com>
2331 Fix the build by adding some more missing return types.
2333 * WebView/WebDashboardRegion.h:
2334 * WebView/WebDashboardRegion.mm:
2335 (-[WebDashboardRegion initWithRect:clip:type:]):
2337 2011-09-01 Tim Horton <timothy_horton@apple.com>
2339 REGRESSION: Rendering artifacts on a rotated, pattern filled shape
2340 https://bugs.webkit.org/show_bug.cgi?id=53055
2341 <rdar://problem/8910917>
2343 Reviewed by Simon Fraser.
2345 Introduce wkCGPatternCreateWithImageAndTransform.
2347 * WebCoreSupport/WebSystemInterface.mm:
2348 (InitWebCoreSystemInterface):
2350 2011-08-31 Beth Dakin <bdakin@apple.com>
2352 https://bugs.webkit.org/show_bug.cgi?id=67322
2353 Re-name overrideBackingScaleFactor
2355 Reviewed by John Sullivan.
2357 _setOverrideBackingScaleFactor is now _setCustomBackingScaleFactor
2358 * WebView/WebView.mm:
2359 (-[WebView _setCustomBackingScaleFactor:]):
2360 (-[WebView _deviceScaleFactor]):
2361 * WebView/WebViewData.h:
2362 * WebView/WebViewPrivate.h:
2364 2011-08-30 Dan Bernstein <mitz@apple.com>
2366 <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
2367 https://bugs.webkit.org/show_bug.cgi?id=67230
2369 Reviewed by Darin Adler.
2371 * WebView/WebHTMLView.mm:
2372 * WebView/WebView.mm:
2373 (coreOptions): Moved this function from WebHTMLView.mm to here and made
2374 it accessible from both this file and WebHTMLView.mm.
2375 (-[WebView DOMRangeOfString:relativeTo:options:]): Added this new API.
2376 * WebView/WebViewInternal.h:
2377 * WebView/WebViewPrivate.h:
2379 2011-08-30 Beth Dakin <bdakin@apple.com>
2381 https://bugs.webkit.org/show_bug.cgi?id=67150
2382 Would like API to use a custom device scale factor for a particular WebView/WKView
2384 <rdar://problem/10041016>
2386 Reviewed by Darin Adler.
2388 New API is _setOverrideBackingScaleFactor:(CGFloat)
2389 * WebView/WebView.mm:
2390 (-[WebView _setOverrideBackingScaleFactor:]):
2391 (-[WebView _deviceScaleFactor]):
2392 * WebView/WebViewData.h:
2393 * WebView/WebViewPrivate.h:
2395 2011-08-30 Aaron Colwell <acolwell@chromium.org>
2397 Add MediaSource API to HTMLMediaElement
2398 https://bugs.webkit.org/show_bug.cgi?id=64731
2400 Reviewed by Eric Carlson.
2402 * Configurations/FeatureDefines.xcconfig:
2404 2011-08-29 Alexey Proskuryakov <ap@apple.com>
2406 DumpRenderTree should begin each test with an empty cookie store
2407 https://bugs.webkit.org/show_bug.cgi?id=63545
2408 <rdar://problem/5666907>
2410 Reviewed by Darin Adler.
2412 * WebView/WebPreferences.mm:
2413 (+[WebPreferences initialize]):
2414 (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2415 (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
2416 * WebView/WebPreferencesPrivate.h:
2417 Exposed an SPI to use a private default session. It's separate from private browsing,
2418 because some tests enable the latter, and we don't want to mix them up.
2419 Also exposed an SPI to set cookie accept policy regardless of what session we are currently
2422 * WebView/WebView.mm: (-[WebView _cachedResponseForURL:]): Updated to use currentStorageSession()
2423 instead of privateBrowsingStorageSession().
2425 2011-08-30 Kaustubh Atrawalkar <kaustubh@motorola.com>
2427 The unused ScrollView* argument can and should be removed from
2429 https://bugs.webkit.org/show_bug.cgi?id=67117
2431 Reviewed by Darin Adler.
2433 * WebCoreSupport/WebChromeClient.h:
2434 * WebCoreSupport/WebChromeClient.mm:
2435 (WebChromeClient::scrollRectIntoView):
2437 2011-08-29 Sheriff Bot <webkit.review.bot@gmail.com>
2439 Unreviewed, rolling out r93987, r93992, r93995, r93998, and
2441 http://trac.webkit.org/changeset/93987
2442 http://trac.webkit.org/changeset/93992
2443 http://trac.webkit.org/changeset/93995
2444 http://trac.webkit.org/changeset/93998
2445 http://trac.webkit.org/changeset/93999
2446 https://bugs.webkit.org/show_bug.cgi?id=67147
2448 Many failing tests (Requested by ap on #webkit).
2450 * WebView/WebPreferences.mm:
2451 (+[WebPreferences initialize]):
2452 * WebView/WebPreferencesPrivate.h:
2454 2011-08-26 Alexey Proskuryakov <ap@apple.com>
2456 DumpRenderTree should begin each test with an empty cookie store
2457 https://bugs.webkit.org/show_bug.cgi?id=63545
2458 <rdar://problem/5666907>
2460 Reviewed by Darin Adler.
2462 * WebView/WebPreferences.mm:
2463 (+[WebPreferences initialize]):
2464 (+[WebPreferences _usePrivateSessionForNetworkLoading]):
2465 * WebView/WebPreferencesPrivate.h:
2466 Exposed an SPI to use a private default session. It's separate from private browsing,
2467 because some tests enable the latter, and we don't want to mix them up.
2469 2011-08-23 Chris Marrin <cmarrin@apple.com>
2471 [mac] requestAnimationFrame support for mac port
2472 https://bugs.webkit.org/show_bug.cgi?id=59146
2474 Reviewed by Simon Fraser.
2476 Implement requestAnimationFrame for WebKit. Add a
2477 CFRunLoopObserver to WebView, which runs just before
2478 the syncCompositingState RLO and calls into the
2479 ScriptedAnimationController if scheduleAnimation() has
2482 * Configurations/FeatureDefines.xcconfig:
2483 * WebCoreSupport/WebChromeClient.h:
2484 * WebCoreSupport/WebChromeClient.mm:
2485 (WebChromeClient::scheduleAnimation):
2486 * WebView/WebView.mm:
2487 (-[WebView _close]):
2488 (-[WebView _unscheduleAnimation]):
2489 (-[WebView _scheduleCompositingLayerSync]):
2490 (requestAnimationFrameRunLoopObserverCallback):
2491 (-[WebView _scheduleAnimation]):
2492 * WebView/WebViewData.h:
2493 * WebView/WebViewInternal.h:
2495 2011-08-24 Alexey Proskuryakov <ap@apple.com>
2497 Plug-in tests are flaky on Mac
2498 https://bugs.webkit.org/show_bug.cgi?id=66822
2500 Reviewed by Anders Carlsson.
2502 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2503 (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
2504 Protect objects that can be removed by a script.
2506 * WebView/WebFrame.mm:
2507 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto.
2508 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): Ditto.
2509 Also fixed some nonsense code.
2511 2011-08-23 Mark Hahnenberg <mhahnenberg@apple.com>
2513 Add checks to ensure allocation does not take place during initialization of GC-managed objects
2514 https://bugs.webkit.org/show_bug.cgi?id=65288
2516 Reviewed by Darin Adler.
2518 Adding the new validation functionality. In its current state, it will performs checks,
2519 but they don't fail unless you do allocation in the arguments to the parent constructor in the
2520 initialization list of a class. The allocateCell() method turns on the global flag disallowing any new
2521 allocations, and the constructorBody() method in JSCell turns it off. This way, allocation is still
2522 allowed in constructor bodies while other refactoring efforts continue.
2524 * Plugins/Hosted/ProxyRuntimeObject.h:
2525 (WebKit::ProxyRuntimeObject::create):
2526 * Plugins/Hosted/ProxyRuntimeObject.mm:
2527 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
2529 2011-08-18 Beth Dakin <bdakin@apple.com>
2531 Reviewed by Sam Weinig.
2533 https://bugs.webkit.org/show_bug.cgi?id=66495
2534 Lion-specific scroller SPIs can use forward declaration instead of
2535 WebKitSystemInterface
2537 * WebCoreSupport/WebSystemInterface.mm:
2538 (InitWebCoreSystemInterface):
2540 2011-08-18 Anders Carlsson <andersca@apple.com>
2542 More C++0x libc++ build fixes
2543 https://bugs.webkit.org/show_bug.cgi?id=66476
2545 Reviewed by Adam Roben.
2547 * Plugins/Hosted/NetscapePluginHostProxy.mm:
2549 Use a WTF String here instead of an STL string.
2551 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2552 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
2553 std::make_pair now takes rvalue references, so get rid of the template arguments and let
2554 the compiler deduce them instead.
2556 2011-08-18 Adam Roben <aroben@apple.com>
2558 Update the device scale factor when the WebView's window changes
2560 Fixes <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
2561 WebView is moved between windows with different backing scale factors
2563 Reviewed by Anders Carlsson.
2565 * WebView/WebView.mm:
2566 (-[WebView viewDidMoveToWindow]): Call setDeviceScaleFactor because our new window (or no
2567 window at all) might have a different backing scale factor than the previous one.
2568 (-[WebView _deviceScaleFactor]): Moved to the WebFileInternal category.
2570 2011-08-17 Adam Roben <aroben@apple.com>
2572 Make WebCore keep track of the current device scale factor
2574 Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the
2577 Reviewed by Darin Adler.
2579 * WebCoreSupport/WebChromeClient.h:
2580 * WebCoreSupport/WebChromeClient.mm:
2581 Moved code to calculate the device scale factor from here...
2583 * WebView/WebView.mm:
2584 (-[WebView _deviceScaleFactor]):
2587 (-[WebView _windowDidChangeResolution:]): Now calls Page::setDeviceScaleFactor.
2589 2011-08-17 Dan Bernstein <mitz@apple.com>
2591 Removed some code that is not needed when building for Leopard or later.
2593 Reviewed by Anders Carlsson.
2595 * WebCoreSupport/WebContextMenuClient.mm:
2596 (fixMenusToSendToOldClients): Removed check for Tiger Mail.
2597 * WebCoreSupport/WebFrameLoaderClient.mm:
2598 (WebFrameLoaderClient::objectContentType):
2599 * WebView/WebView.mm:
2600 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2601 (-[WebView _preferencesChanged:]):
2603 2011-08-17 Dan Bernstein <mitz@apple.com>
2605 Eliminate the WebCGFloat compatibility definition that was needed for Tiger.
2607 Rubber-stamped by Anders Carlsson.
2609 * WebView/WebHTMLViewPrivate.h:
2611 2011-08-17 Dan Bernstein <mitz@apple.com>
2613 Eliminate the WebNSInteger and WebNSUInteger compatibility definitions that were
2616 Reviewed by Darin Adler.
2618 * History/WebBackForwardList.h:
2619 * WebView/WebDocumentInternal.h:
2620 * WebView/WebHTMLRepresentation.h:
2621 * WebView/WebPreferences.h:
2622 * WebView/WebResourceLoadDelegate.h:
2623 * WebView/WebResourceLoadDelegatePrivate.h:
2624 * WebView/WebScriptDebugDelegate.h:
2625 * WebView/WebTextIterator.h:
2626 * WebView/WebUIDelegate.h:
2627 * WebView/WebView.h:
2628 * WebView/WebViewPrivate.h:
2630 2011-08-15 Dmitry Titov <dimich@chromium.org>
2632 FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters
2633 https://bugs.webkit.org/show_bug.cgi?id=66165
2635 Reviewed by Darin Fisher.
2637 * WebCoreSupport/WebFrameLoaderClient.h:
2638 * WebCoreSupport/WebFrameLoaderClient.mm:
2639 (WebFrameLoaderClient::transferLoadingResourceFromPage):
2641 2011-08-15 Mark Hahnenberg <mhahnenberg@apple.com>
2643 Refactor JS objects to allocate in static create methods rather than constructors
2644 https://bugs.webkit.org/show_bug.cgi?id=65347
2646 Reviewed by Geoffrey Garen.
2648 Removed all calls to deprecatedGetDOMObject from initialization lists as part of a
2649 larger refactoring to get rid of all allocation during initialization.
2651 * Plugins/Hosted/ProxyInstance.mm:
2652 (WebKit::ProxyRuntimeMethod::create):
2653 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
2655 2011-08-15 Adam Roben <aroben@apple.com>
2657 Update pages' style and content scale when the window's backing scale factor changes
2659 Unfortunately, I couldn't think of a way to test this in an automated fashion.
2661 Fixes <http://webkit.org/b/66229> <rdar://problem/9906269> WebKit doesn't react to device
2662 scale factor changes
2664 Reviewed by Simon Fraser.
2666 * WebView/WebView.mm:
2667 (-[WebView addWindowObserversForWindow:]):
2668 (-[WebView removeWindowObservers]):
2669 Listen for the notification that tells us the window's backing scale has changed.
2671 (-[WebView _windowDidChangeResolution:]): Tell the page about the change to the device scale
2672 factor so that, e.g., scale-factor-dependent media queries will be reevaluated.
2674 2011-08-10 Adam Roben <aroben@apple.com>
2676 Clear up scale factor terminology
2678 WebKit by and large deals with two scale factors: one intrinsic to the device on which the
2679 software is running, and one that is per-Page and can be controlled via API calls. This
2680 patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the
2681 code use those names. It should introduce no behavior changes.
2683 Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the
2686 Reviewed by Simon Fraser.
2688 * Misc/WebNSControlExtras.m:
2689 (-[NSControl sizeToFitAndAdjustWindowHeight]): Updated this function to use more modern
2690 AppKit scale factor terminology. (This is unrelated to the rest of the patch.)
2692 * WebCoreSupport/WebChromeClient.h:
2693 * WebCoreSupport/WebChromeClient.mm:
2695 2011-08-13 Dan Bernstein <mitz@apple.com>
2697 Changed the value of WebKitShowsToolTipOverTruncatedTextPreferenceKey to match the naming everywhere else.
2699 Reviewed by Joseph Pecoraro.
2701 * WebView/WebPreferenceKeysPrivate.h:
2703 2011-08-13 Sam Weinig <sam@webkit.org>
2705 Remove unused variables from WebView/WebFullScreenController.h
2706 https://bugs.webkit.org/show_bug.cgi?id=66194
2708 Reviewed by Dan Bernstein.
2710 * WebView/WebFullScreenController.h:
2711 Remove a few variables which were not used.
2713 2011-08-12 Dan Bernstein <mitz@apple.com>
2715 Add an option to automatically show tooltips (with the full text) over truncated text
2716 https://bugs.webkit.org/show_bug.cgi?id=66178
2718 Reviewed by Simon Fraser.
2720 * WebView/WebPreferenceKeysPrivate.h: Defined a preference key.
2721 * WebView/WebPreferences.mm:
2722 (+[WebPreferences initialize]): Added a default value of NO for the
2723 ShowsToolTipOverTruncatedText preference.
2724 (-[WebPreferences showsToolTipOverTruncatedText]): Added this getter.
2725 (-[WebPreferences setShowsToolTipOverTruncatedText:]): Added this setter.
2726 * WebView/WebPreferencesPrivate.h:
2727 * WebView/WebView.mm:
2728 (-[WebView _preferencesChanged:]): Added call to Settings::setShowsToolTipOverTruncatedText().
2730 2011-08-12 Sam Weinig <sam@webkit.org>
2732 Use __builtin_trap() for CRASH when building with clang
2733 https://bugs.webkit.org/show_bug.cgi?id=66152
2735 Reviewed by Anders Carlsson.
2737 * Plugins/WebBaseNetscapePluginView.mm:
2738 (-[WebBaseNetscapePluginView setAttributeKeys:andValues:]):
2739 (-[WebBaseNetscapePluginView handleMouseMoved:]):
2740 (-[WebBaseNetscapePluginView handleMouseEntered:]):
2741 (-[WebBaseNetscapePluginView handleMouseExited:]):
2742 (-[WebBaseNetscapePluginView focusChanged]):
2743 (-[WebBaseNetscapePluginView windowFocusChanged:]):
2744 (-[WebBaseNetscapePluginView createPlugin]):
2745 (-[WebBaseNetscapePluginView loadStream]):
2746 (-[WebBaseNetscapePluginView shouldStop]):
2747 (-[WebBaseNetscapePluginView destroyPlugin]):
2748 (-[WebBaseNetscapePluginView updateAndSetWindow]):
2749 (-[WebBaseNetscapePluginView sendModifierEventWithKeyCode:character:]):
2750 (-[WebBaseNetscapePluginView pluginLayer]):
2751 (-[WebBaseNetscapePluginView getFormValue:]):
2752 Remove the ASSERT_NOT_REACHED from the base class methods. They were not
2753 adding much value and were getting in the way of making the static analyzer
2754 work. A better way to do this would be to use a formal protocol.
2756 2011-08-12 Mark Rowe <mrowe@apple.com>
2758 Be more forward-looking in the choice of compiler.
2760 Rubber-stamped by Jon Honeycutt.
2762 * Configurations/CompilerVersion.xcconfig:
2764 2011-08-10 David Hyatt <hyatt@apple.com>
2766 https://bugs.webkit.org/show_bug.cgi?id=66004
2768 Removing the CSS Regions and Exclusions ifdefs.
2770 Reviewed by Adam Roben.
2772 * Configurations/FeatureDefines.xcconfig:
2774 2011-08-09 Mark Hahnenberg <mhahnenberg@apple.com>
2776 Add ParentClass typedef in all JSC classes
2777 https://bugs.webkit.org/show_bug.cgi?id=65731
2779 Reviewed by Oliver Hunt.
2781 Just added the Base typedefs in all the classes that are a subclass of JSCell
2782 to point at their parent classes. This is a change to support future changes to the way
2783 constructors and destructors are implemented in JS objects, among other things.
2785 * Plugins/Hosted/ProxyInstance.mm:
2786 * Plugins/Hosted/ProxyRuntimeObject.h:
2788 2011-08-08 Chris Marrin <cmarrin@apple.com>
2790 Logic to compute visible display rect in GraphicsLayerCA::syncCompositingState
2791 https://bugs.webkit.org/show_bug.cgi?id=65708
2793 Supply initial display rects for the full-screen case
2795 Reviewed by Simon Fraser.
2797 * WebView/WebFullScreenController.mm:
2798 (-[WebFullScreenController enterFullscreen:]):
2799 (-[WebFullScreenController exitFullscreen]):
2801 2011-08-06 Joseph Pecoraro <joepeck@webkit.org>
2803 Potential Leaks - RetainPtr<> over retaining Create'd objects
2804 https://bugs.webkit.org/show_bug.cgi?id=65806
2806 Reviewed by Darin Adler.
2808 Fix a possible leak by adopting an allocation instead of retaining it.
2810 * WebView/WebView.mm:
2811 (-[WebView previousValidKeyView]):
2813 2011-08-05 Anders Carlsson <andersca@apple.com>
2816 https://bugs.webkit.org/show_bug.cgi?id=65729
2818 Reviewed by Darin Adler.
2820 Remove plug-in halter and associated classes.
2822 * Plugins/WebBaseNetscapePluginView.h:
2823 * Plugins/WebBaseNetscapePluginView.mm:
2824 (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
2825 (-[WebBaseNetscapePluginView start]):
2826 (-[WebBaseNetscapePluginView stop]):
2827 * WebCoreSupport/WebPluginHalterClient.h: Removed.
2828 * WebCoreSupport/WebPluginHalterClient.mm: Removed.
2829 * WebView/WebPreferenceKeysPrivate.h:
2830 * WebView/WebPreferences.mm:
2831 (+[WebPreferences initialize]):
2832 * WebView/WebPreferencesPrivate.h:
2833 * WebView/WebView.mm:
2834 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2835 (-[WebView _preferencesChanged:]):
2836 * WebView/WebViewPrivate.h:
2838 2011-08-04 Mark Rowe <mrowe@apple.com>
2840 Future-proof Xcode configuration settings.
2842 * Configurations/Base.xcconfig:
2843 * Configurations/DebugRelease.xcconfig:
2844 * Configurations/Version.xcconfig:
2845 * Configurations/WebKit.xcconfig:
2847 2011-08-03 Kent Tamura <tkent@chromium.org>
2849 Fix incorrect checks for HTMLMediaElement
2850 https://bugs.webkit.org/show_bug.cgi?id=65590
2852 Reviewed by Dimitri Glazkov.
2854 <video> and <audio> can be an HTMLElement instance instead of
2855 HTMLMediaElement if MediaPlayer::isAvailable() returns false or
2856 the media feature is disabled at runtime.
2858 * WebView/WebFullScreenController.mm:
2859 (-[WebFullScreenController _isAnyMoviePlaying]):
2861 2011-08-03 Mark Rowe <mrowe@apple.com>
2863 Bring some order to FeatureDefines.xcconfig to make it easier to follow.
2865 Reviewed by Sam Weinig.
2867 * Configurations/FeatureDefines.xcconfig:
2869 2011-08-03 Mark Rowe <mrowe@apple.com>
2871 Clean up FeatureDefines.xcconfig to remove some unnecessary conditional settings
2873 Reviewed by Dave Kilzer.
2875 * Configurations/FeatureDefines.xcconfig:
2877 2011-08-03 Joseph Pecoraro <joepeck@webkit.org>
2879 Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
2880 https://bugs.webkit.org/show_bug.cgi?id=65582
2882 Reviewed by Pavel Feldman.
2884 * WebCoreSupport/WebInspectorClient.h:
2885 * WebCoreSupport/WebInspectorClient.mm:
2887 2011-08-03 Pavel Feldman <pfeldman@google.com>
2889 Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
2890 https://bugs.webkit.org/show_bug.cgi?id=65510
2892 Reviewed by Yury Semikhatsky.
2894 * WebInspector/WebNodeHighlightView.mm:
2895 (-[WebNodeHighlightView drawRect:]):
2897 2011-08-03 Pavel Feldman <pfeldman@chromium.org>
2899 Web Inspector: remove Node parameter from the InspectorClient::highlight
2900 https://bugs.webkit.org/show_bug.cgi?id=65549
2902 Reviewed by Yury Semikhatsky.
2904 * WebCoreSupport/WebInspectorClient.h:
2905 * WebCoreSupport/WebInspectorClient.mm:
2906 (WebInspectorClient::highlight):
2907 * WebInspector/WebNodeHighlighter.h:
2908 * WebInspector/WebNodeHighlighter.mm:
2909 (-[WebNodeHighlighter highlight]):
2911 2011-07-30 Patrick Gansterer <paroga@webkit.org>
2913 Remove inclusion of MainThread.h from Threading.h
2914 https://bugs.webkit.org/show_bug.cgi?id=65081
2916 Reviewed by Darin Adler.
2918 Add missing include statements for MainThread.
2920 * Carbon/CarbonWindowAdapter.mm:
2921 * History/WebBackForwardList.mm:
2922 * History/WebHistoryItem.mm:
2923 * Misc/WebElementDictionary.mm:
2924 * Misc/WebIconDatabase.mm:
2925 * Misc/WebLocalizableStrings.mm:
2926 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2927 * Plugins/WebBaseNetscapePluginView.mm:
2928 * Plugins/WebBasePluginPackage.mm:
2929 * Plugins/WebNetscapePluginView.mm:
2930 * WebCoreSupport/WebEditorClient.mm:
2931 * WebCoreSupport/WebFrameLoaderClient.mm:
2932 * WebView/WebArchive.mm:
2933 * WebView/WebDataSource.mm:
2934 * WebView/WebHTMLView.mm:
2935 * WebView/WebResource.mm:
2936 * WebView/WebTextIterator.mm:
2937 * WebView/WebView.mm:
2938 * WebView/WebViewData.mm:
2940 2011-07-28 Dan Bernstein <mitz@apple.com>
2942 <rdar://problem/9589433> Displaying Japanese dictionary contents in vertical orientation takes a couple of seconds
2944 Reviewed by Darin Adler.
2946 * WebCoreSupport/WebSystemInterface.mm:
2947 (InitWebCoreSystemInterface): Initialize wkGetVerticalGlyphsForCharacters.
2949 2011-07-28 Brady Eidson <beidson@apple.com>
2951 <rdar://problem/9714337> and https://bugs.webkit.org/show_bug.cgi?id=65306
2952 WebKitInitializeStorageIfNecessary() can take awhile performing i/o, isn't necessary for every WebView
2954 Reviewed by Maciej Stachowiak.
2956 * Storage/WebStorageManager.mm:
2957 (WebKitInitializeStorageIfNecessary): Pass the client along in initializeTracker().
2959 2011-07-27 Mark Hahnenberg <mhahnenberg@apple.com>
2961 Remove operator new from JSCell
2962 https://bugs.webkit.org/show_bug.cgi?id=64999
2964 Reviewed by Oliver Hunt.
2966 Removed the implementation of operator new in JSCell, so any further uses
2967 will not successfully link. Also removed any remaining uses of operator new.
2969 * Plugins/Hosted/ProxyInstance.mm:
2970 (WebKit::ProxyInstance::newRuntimeObject):
2971 (WebKit::ProxyRuntimeMethod::create):
2972 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
2973 (WebKit::ProxyInstance::getMethod):
2974 * Plugins/Hosted/ProxyRuntimeObject.h:
2975 (WebKit::ProxyRuntimeObject::create):
2976 * WebView/WebScriptDebugDelegate.mm:
2977 (-[WebScriptCallFrame scopeChain]):
2979 2011-07-26 Dan Bernstein <mitz@apple.com>
2981 <rdar://problem/9842889> Add a generic pictograph font family
2982 https://bugs.webkit.org/show_bug.cgi?id=65197
2984 Reviewed by Anders Carlsson.
2986 * WebView/WebPreferenceKeysPrivate.h: Added WebKitPictographFontPreferenceKey.
2987 * WebView/WebPreferences.mm:
2988 (+[WebPreferences initialize]): Set the default pictograph font family to
2989 "Apple Color Emoji".
2990 (-[WebPreferences pictographFontFamily]): Added this getter.
2991 (-[WebPreferences setPictographFontFamily:]): Added this setter.
2992 * WebView/WebPreferencesPrivate.h:
2993 * WebView/WebView.mm:
2994 (-[WebView _preferencesChanged:]): Pass the preference through to WebCore.
2996 2011-07-25 Ian Henderson <ianh@apple.com>
2998 WebFrame should have a method to determine its visual emptiness
2999 https://bugs.webkit.org/show_bug.cgi?id=64223
3001 Reviewed by Dan Bernstein.
3003 * WebView/WebFrame.mm:
3004 (-[WebFrame _isVisuallyNonEmpty]): Pipe the isVisuallyNonEmpty method
3006 * WebView/WebFramePrivate.h:
3008 2011-07-19 Leo Yang <leoyang.webkit@gmail.com>
3010 SVG: Missing implementation of <altGlyphDef>, <altGlyphItem> and <glyphRef>
3011 https://bugs.webkit.org/show_bug.cgi?id=60850
3013 Reviewed by Nikolas Zimmermann.
3015 SVG spec: http://www.w3.org/TR/SVG/text.html#AlternateGlyphDefinitions.
3016 This patch is to implement SVG <altGlyphDef>, <altGlyphItem> and <glyphRef>
3017 elements for alternative glyph features.
3019 * MigrateHeaders.make:
3021 2011-07-18 Andy Estes <aestes@apple.com>
3023 Solar Walk app-specific hack accidentally strips stylesheets from the document.
3024 https://bugs.webkit.org/show_bug.cgi?id=64777
3026 Reviewed by Adam Barth.
3028 Solar Walk uses a self-closed title tag in its documents ("<title />").
3029 The HTML5 parser does not recognize this as a valid self-closing tag,
3030 so it treats the remainder of the document as title text.
3032 We work around this in WebKit by injecting a script that calls
3033 document.write() on the contents of document.title, thereby restoring
3034 the contents of the document. Unfortunately this overwrote several
3035 <style> tags that existed before the <title>, thereby causing the
3036 document to not have the intended styling.
3038 Fix this by having the injected script concatenate document.title to
3039 the document instead of overwriting it during document.write(). We can
3040 also take the opportunity to remove document.title since it does not
3041 contain useful information.
3043 * Misc/SolarWalkQuirksUserScript.js:
3045 2011-07-18 Dean Jackson <dino@apple.com>
3047 https://bugs.webkit.org/show_bug.cgi?id=64742
3048 Expose WebPreferences for media playback requiring user gestures and inline playback
3050 Reviewed by Simon Fraser.
3052 Two new WebPreferences: MediaPlaybackRequiresUserGesture and
3053 MediaPlaybackAllowsInline.
3055 * WebView/WebPreferenceKeysPrivate.h:
3056 * WebView/WebPreferences.mm:
3057 (+[WebPreferences initialize]):
3058 (-[WebPreferences mediaPlaybackRequiresUserGesture]):
3059 (-[WebPreferences setMediaPlaybackRequiresUserGesture:]):
3060 (-[WebPreferences mediaPlaybackAllowsInline]):
3061 (-[WebPreferences setMediaPlaybackAllowsInline:]):
3062 * WebView/WebPreferencesPrivate.h:
3063 * WebView/WebView.mm:
3064 (-[WebView _preferencesChanged:]):
3066 2011-07-18 Pratik Solanki <psolanki@apple.com>
3068 Part of https://bugs.webkit.org/show_bug.cgi?id=63674
3069 Get webkit to compile with USE(CFNETWORK) enabled on Mac
3071 Reviewed by David Kilzer.
3073 Create an NSURLDownload from the CF objects that we have.
3075 * Misc/WebDownload.mm:
3076 (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):
3077 * Misc/WebDownloadInternal.h:
3078 * WebCoreSupport/WebFrameLoaderClient.mm:
3079 (WebFrameLoaderClient::download):
3081 2011-07-15 Pratik Solanki <psolanki@apple.com>
3083 Part of https://bugs.webkit.org/show_bug.cgi?id=63674
3084 Get webkit to compile with USE(CFNETWORK) enabled on Mac
3086 Reviewed by David Kilzer.
3088 New WebKitSystemInterface functions for CFNetwork-based loader.
3090 * WebCoreSupport/WebSystemInterface.mm:
3091 (InitWebCoreSystemInterface):
3093 2011-07-15 Tim Horton <timothy_horton@apple.com>
3095 Overlay scrollbars in overflow areas no longer pulse when revealed
3096 https://bugs.webkit.org/show_bug.cgi?id=64606
3097 <rdar://problem/9390674>
3099 Reviewed by Simon Fraser.
3101 Ensure that the state of the scrollbar implementation is kept in sync
3102 with WebCore's internal representation. Previously, we synchronized them
3103 at paint time, causing pulsing to be skipped due to the scrollbars being
3106 * WebCoreSupport/WebSystemInterface.mm:
3107 (InitWebCoreSystemInterface):
3109 2011-07-15 Andy Estes <aestes@apple.com>
3111 Rename applicationIsSolarWalk() to applicationIsSolarWalkMac().
3112 https://bugs.webkit.org/show_bug.cgi?id=64641
3114 Reviewed by Brian Weinstein.
3116 * WebView/WebView.mm:
3117 (needsSolarWalkQuirksScript): Call applicationIsSolarWalkMac().
3119 2011-07-15 Dan Bernstein <mitz@apple.com>
3121 REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides
3122 https://bugs.webkit.org/show_bug.cgi?id=64615
3124 Reviewed by Anders Carlsson.
3126 * WebCoreSupport/WebChromeClient.h:
3127 * WebCoreSupport/WebChromeClient.mm:
3128 (WebChromeClient::setCursorHiddenUntilMouseMoves): Added. Calls
3129 +[NSCursor setHiddenUntilMouseMoves:].
3131 2011-07-14 Gavin Barraclough <barraclough@apple.com>
3133 https://bugs.webkit.org/show_bug.cgi?id=64250
3134 Global strict mode function leaking global object as "this".
3136 Reviewed by Oliver Hunt.
3138 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3139 (WebKit::NetscapePluginInstanceProxy::invoke):
3140 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3141 - Change call to pass DOM Window shell, instead of the global varaible object.
3143 2011-07-13 Joseph Pecoraro <joepeck@webkit.org>
3145 Improve names of some ApplicationCacheStorage accessor methods
3146 https://bugs.webkit.org/show_bug.cgi?id=64433
3148 Reviewed by Alexey Proskuryakov.
3150 * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
3151 (-[WebApplicationCacheQuotaManager usage]):
3152 (-[WebApplicationCacheQuotaManager quota]):
3155 2011-07-12 Joseph Pecoraro <joepeck@webkit.org>
3157 ApplicationCache update should not immediately fail when reaching per-origin quota
3158 https://bugs.webkit.org/show_bug.cgi?id=64177
3160 Reviewed by Alexey Proskuryakov.
3162 * WebView/WebUIDelegatePrivate.h:
3163 * DefaultDelegates/WebDefaultUIDelegate.m:
3164 (-[WebDefaultUIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:spaceNeeded:]):
3165 Update the delegate to include a space needed parameter.
3167 * WebCoreSupport/WebChromeClient.h:
3168 * WebCoreSupport/WebChromeClient.mm:
3169 (WebChromeClient::reachedApplicationCacheOriginQuota):
3170 Call the delegate with the new space needed information.
3172 2011-07-12 Adam Roben <aroben@apple.com>
3174 Delete some redundant code in WebHTMLView
3176 This code had no user-visible effect, as we were just duplicating work that AppKit would do
3177 for us at a slightly different time.
3179 Fixes <http://webkit.org/b/64390> WebHTMLView sets its root layer's transform unnecessarily
3181 Reviewed by Simon Fraser.
3183 * WebView/WebHTMLView.mm:
3184 (-[WebHTMLView viewDidMoveToWindow]):
3185 (-[WebHTMLView attachRootLayer:]):
3186 Don't bother setting the root layer's transform to account for the scale factor. AppKit
3187 takes care of this for us nowadays.
3189 2011-07-10 Kenichi Ishibashi <bashi@chromium.org>
3191 Let plugins participate in form submission
3192 https://bugs.webkit.org/show_bug.cgi?id=13061
3194 Adds methods to get form value from NPAPI plugins.
3196 Reviewed by Anders Carlsson.
3198 * Plugins/Hosted/WebHostedNetscapePluginView.h:
3199 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3200 (-[WebHostedNetscapePluginView getFormValue:]): Added.
3201 * Plugins/WebBaseNetscapePluginView.h:
3202 * Plugins/WebBaseNetscapePluginView.mm:
3203 (-[WebBaseNetscapePluginView getFormValue:]): Added.
3204 * Plugins/WebNetscapePluginPackage.h:
3205 * Plugins/WebNetscapePluginPackage.mm:
3206 (-[WebNetscapePluginPackage browserFuncs]): Added.
3207 * Plugins/WebNetscapePluginView.h:
3208 * Plugins/WebNetscapePluginView.mm:
3209 (-[WebNetscapePluginView getFormValue:]): Added.
3210 * WebCoreSupport/WebFrameLoaderClient.mm:
3211 (NetscapePluginWidget::getFormValue): Added.
3213 2011-07-04 Dan Bernstein <mitz@apple.com>
3215 Moved handling of frame size changes into its own method.
3217 Reviewed by Oliver Hunt.
3219 * WebView/WebFrameView.mm:
3220 (-[WebFrameView _frameSizeChanged]): Added. Moved code here...
3221 (-[WebFrameView setFrameSize:]): ...from here.
3222 * WebView/WebFrameViewInternal.h:
3224 2011-07-01 Adele Peterson <adele@apple.com>
3226 Reviewed by Darin Adler.
3228 WebKit part of fix for https://bugs.webkit.org/show_bug.cgi?id=63851
3229 <rdar://problem/8981062> Crash when loading a document in an editable WebView that has a subframe with an unstyled body
3231 * WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
3232 Only call applyEditingStyleToBodyElement for the main frame. There's no need to apply break-word,
3233 space, and after-white-space properties to subframes in the editable document.
3235 2011-07-01 Andy Estes <aestes@apple.com>
3237 Reviewed by Mark Rowe.
3239 Simplify MailQuirksUserScript.js
3240 https://bugs.webkit.org/show_bug.cgi?id=63800
3242 MailQuirksUserScript.js is injected into WebViews in Mail.app on
3243 Leopard to resolve an incompatibility between it and the HTML5 parser.
3244 It did so by taking all nodes in the document between <html> and <body>
3245 and moving them to be children of <body>. This maintains Mail.app's
3246 assumption that document.firstChild.firstChild == document.body.
3248 While this script fixed a specific issue with the Signature panel in
3249 Mail.app, it caused regressions in other WebViews. Since the issue with
3250 the Signature panel is with the empty <head> node implicitly created by
3251 the parser, we can simplify this script by removing this implicit
3252 <head> in the case it has no attributes and no children. This fixes the
3253 Signature panel without affecting other WebViews that have non-trivial
3256 * Misc/MailQuirksUserScript.js: If <head> exists but has no attributes
3257 and no children, remove it.
3259 2011-06-30 Dan Bernstein <mitz@apple.com>
3261 Reviewed by Adele Peterson.
3263 Add +[WebView _allowsRoundingHacks]
3264 https://bugs.webkit.org/show_bug.cgi?id=63734
3266 * WebView/WebView.mm:
3267 (+[WebView _allowsRoundingHacks]): Added this accessor.
3268 * WebView/WebViewPrivate.h:
3270 2011-06-29 Darin Adler <darin@apple.com>
3272 Reviewed by Dan Bernstein.
3274 [Mac] Use system cursors instead of custom bitmaps where possible
3275 https://bugs.webkit.org/show_bug.cgi?id=63679
3277 * WebCoreSupport/WebSystemInterface.mm:
3278 (InitWebCoreSystemInterface): Added WKCursor.
3280 2011-06-28 Ilya Sherman <isherman@chromium.org>
3282 Reviewed by Adam Barth.
3284 form.autocomplete="off" does not work
3285 https://bugs.webkit.org/show_bug.cgi?id=35823
3287 * WebView/WebHTMLRepresentation.mm:
3288 (-[WebHTMLRepresentation elementDoesAutoComplete:]): Update callsite.
3290 2011-06-26 Mark Rowe <mrowe@apple.com>
3292 Reviewed by Dan Bernstein.
3294 Use a separate file name for Lion's WebKitSystemInterface.
3296 * Configurations/DebugRelease.xcconfig:
3298 2011-06-24 Dan Bernstein <mitz@apple.com>
3300 Reviewed by Anders Carlsson.
3302 Add an option to enable legacy rounding hacks
3303 https://bugs.webkit.org/show_bug.cgi?id=63363
3305 * Misc/WebKitNSStringExtras.mm:
3306 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
3307 Disabled rounding hacks.
3308 (-[NSString _web_widthWithFont:]): Ditto.
3309 * WebView/WebView.mm:
3310 (+[WebView _setAllowsRoundingHacks:]): Added this setter.
3311 * WebView/WebViewPrivate.h:
3313 2011-06-24 Dominic Cooney <dominicc@chromium.org>
3315 Reviewed by Dimitri Glazkov.
3317 Convert shadow DOM-related tests to use window.internals
3318 https://bugs.webkit.org/show_bug.cgi?id=61671
3320 Remove shadow DOM-related methods from Mac API. These are not
3323 * DOM/WebDOMOperations.mm:
3324 * DOM/WebDOMOperationsPrivate.h:
3326 2011-06-24 Yuta Kitamura <yutak@chromium.org>
3328 Reviewed by Adam Barth.
3330 WebSocket: Add run-time flag for new HyBi protocol
3331 https://bugs.webkit.org/show_bug.cgi?id=60348
3333 Make a new flag (Setting::m_useHixie76WebSocketProtocol)
3334 switchable from WebView and WebPreferences.
3336 * WebView/WebPreferenceKeysPrivate.h:
3337 * WebView/WebPreferences.mm:
3338 (+[WebPreferences initialize]):
3339 (-[WebPreferences setHixie76WebSocketProtocolEnabled:]):
3340 (-[WebPreferences isHixie76WebSocketProtocolEnabled]):
3341 * WebView/WebPreferencesPrivate.h:
3342 * WebView/WebView.mm:
3343 (-[WebView _preferencesChanged:]):
3345 2011-06-22 Sam Weinig <sam@webkit.org>
3347 Roll out r89469 (Add preference for setting the html parser depth limit)
3349 The preference is not needed at this time, so there is no reason to expose it.
3351 * WebView/WebPreferenceKeysPrivate.h:
3352 * WebView/WebPreferences.mm:
3353 (+[WebPreferences initialize]):
3354 * WebView/WebPreferencesPrivate.h:
3355 * WebView/WebView.mm:
3356 (-[WebView _preferencesChanged:]):
3358 2011-06-22 Sam Weinig <sam@webkit.org>
3360 Reviewed by Adam Barth.
3362 Add preference for setting the html parser depth limit
3363 https://bugs.webkit.org/show_bug.cgi?id=63163
3365 * WebView/WebPreferenceKeysPrivate.h:
3366 * WebView/WebPreferences.mm:
3367 (+[WebPreferences initialize]):
3368 (-[WebPreferences setMaximumHTMLParserDOMTreeDepth:]):
3369 (-[WebPreferences maximumHTMLParserDOMTreeDepth]):
3370 * WebView/WebPreferencesPrivate.h:
3371 * WebView/WebView.mm:
3372 (-[WebView _preferencesChanged:]):
3373 Add private preference for setting the parser depth limit.
3375 2011-06-22 Ryosuke Niwa <rniwa@webkit.org>
3377 Reviewed by Darin Adler.
3379 Make instantiation of legacy editing position more explicit
3380 https://bugs.webkit.org/show_bug.cgi?id=63037
3382 Create new positions since we can't create a legacy editing position outside of WebCore anymore.
3384 * WebView/WebFrame.mm:
3385 (-[WebFrame _smartDeleteRangeForProposedRange:]): Calls createLegacyEditingPosition.
3386 (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
3388 2011-06-20 Dimitri Glazkov <dglazkov@chromium.org>
3390 Reviewed by Kent Tamura.
3392 FileChooser should be only created when we need to choose files.
3393 https://bugs.webkit.org/show_bug.cgi?id=63039
3395 * WebCoreSupport/WebChromeClient.mm:
3396 (WebChromeClient::runOpenPanel): Changed to use settings.
3398 2011-06-21 MORITA Hajime <morrita@google.com>
3400 Unreviewed, rolling out r89401 and r89403.
3401 http://trac.webkit.org/changeset/89401
3402 http://trac.webkit.org/changeset/89403
3403 https://bugs.webkit.org/show_bug.cgi?id=62970
3405 Breaks mac build and mistakenly enables the spellcheck API
3407 * Configurations/FeatureDefines.xcconfig:
3409 2011-06-20 MORITA Hajime <morrita@google.com>
3411 Reviewed by Kent Tamura.
3413 Spellcheck API should be build-able.
3414 https://bugs.webkit.org/show_bug.cgi?id=62970
3416 No new tests, changing only build related files
3418 * Configurations/FeatureDefines.xcconfig:
3420 2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
3422 Unreviewed, rolling out r89354.
3423 http://trac.webkit.org/changeset/89354
3424 https://bugs.webkit.org/show_bug.cgi?id=63099
3426 Broke tests on Mac (Requested by rniwa on #webkit).
3428 * WebCoreSupport/WebInspectorClient.mm:
3429 (-[WebInspectorWindowController destroyInspectorView:]):
3430 * WebInspector/WebInspector.mm:
3431 (-[WebInspector show:]):
3432 (-[WebInspector showConsole:]):
3433 (-[WebInspector isDebuggingJavaScript]):
3434 (-[WebInspector toggleDebuggingJavaScript:]):
3435 (-[WebInspector startDebuggingJavaScript:]):
3436 (-[WebInspector stopDebuggingJavaScript:]):
3437 (-[WebInspector isProfilingJavaScript]):
3438 (-[WebInspector toggleProfilingJavaScript:]):
3439 (-[WebInspector startProfilingJavaScript:]):
3440 (-[WebInspector stopProfilingJavaScript:]):
3441 (-[WebInspector isJavaScriptProfilingEnabled]):
3442 (-[WebInspector setJavaScriptProfilingEnabled:]):
3443 (-[WebInspector isTimelineProfilingEnabled]):
3444 (-[WebInspector setTimelineProfilingEnabled:]):
3445 (-[WebInspector setFrontend:]):
3446 (-[WebInspector showWindow:]):
3447 * WebInspector/WebInspectorFrontend.h:
3448 * WebInspector/WebInspectorFrontend.mm:
3449 * WebInspector/WebInspectorPrivate.h:
3451 2011-06-20 Pavel Feldman <pfeldman@chromium.org>
3453 Reviewed by Yury Semikhatsky.
3455 Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
3456 https://bugs.webkit.org/show_bug.cgi?id=62985
3458 Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
3459 methods for plumbing the menu action handlers through the WebKit and WebCore.
3460 I intend to remove this menu support from the protocol and WebCore/InspectorController API.
3461 I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
3462 WebKit/win and WebKit2 to follow.
3464 * WebCoreSupport/WebInspectorClient.mm:
3465 (-[WebInspectorWindowController destroyInspectorView:]):
3466 * WebInspector/WebInspector.mm:
3467 (-[WebInspector showWindow]):
3468 (-[WebInspector show:]):
3469 (-[WebInspector showConsole:]):
3470 (-[WebInspector isDebuggingJavaScript]):
3471 (-[WebInspector toggleDebuggingJavaScript:]):
3472 (-[WebInspector startDebuggingJavaScript:]):
3473 (-[WebInspector stopDebuggingJavaScript:]):
3474 (-[WebInspector isProfilingJavaScript]):
3475 (-[WebInspector toggleProfilingJavaScript:]):
3476 (-[WebInspector startProfilingJavaScript:]):
3477 (-[WebInspector stopProfilingJavaScript:]):
3478 (-[WebInspector isJavaScriptProfilingEnabled]):
3479 (-[WebInspector setJavaScriptProfilingEnabled:]):
3480 (-[WebInspector isTimelineProfilingEnabled]):
3481 (-[WebInspector setTimelineProfilingEnabled:]):
3482 (-[WebInspector setFrontend:]):
3483 (-[WebInspector releaseFrontend]):
3484 (-[WebInspector showWindow:]):
3485 * WebInspector/WebInspectorFrontend.h:
3486 * WebInspector/WebInspectorFrontend.mm:
3487 (-[WebInspectorFrontend isDebuggingEnabled]):
3488 (-[WebInspectorFrontend setDebuggingEnabled:]):
3489 (-[WebInspectorFrontend isProfilingJavaScript]):
3490 (-[WebInspectorFrontend startProfilingJavaScript]):
3491 (-[WebInspectorFrontend stopProfilingJavaScript]):
3492 (-[WebInspectorFrontend isJavaScriptProfilingEnabled]):
3493 (-[WebInspectorFrontend setJavaScriptProfilingEnabled:]):
3494 (-[WebInspectorFrontend isTimelineProfilingEnabled]):
3495 (-[WebInspectorFrontend setTimelineProfilingEnabled:]):
3496 * WebInspector/WebInspectorPrivate.h:
3498 2011-06-01 Jer Noble <jer.noble@apple.com>
3500 Reviewed by Eric Carlson.
3502 Move Full Screen Controllers into WebCore.
3504 Remove dependency on QTKit from wekitExitFullscreen()
3505 https://bugs.webkit.org/show_bug.cgi?id=61843
3507 WebVideoFullscreenController, WebVideoFullscreenHUDController, and WebWindowAnimation
3508 have been moved into WebCore.
3510 * WebCoreSupport/WebSystemInterface.mm:
3511 (InitWebCoreSystemInterface): Add support for four WKSI functions in WCSI.
3512 * WebView/WebFullScreenController.mm: Remove unused #include.
3513 * WebView/WebView.mm: Change the include location of
3514 WebVideoFullscreenController.h
3516 2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
3518 Reviewed by Darin Adler.
3520 Separate concerns of loading file icons and choosing files.
3521 https://bugs.webkit.org/show_bug.cgi?id=62931
3523 * WebCoreSupport/WebChromeClient.h:
3524 * WebCoreSupport/WebChromeClient.mm:
3525 (WebChromeClient::loadIconForFiles): Renamed.
3527 2011-06-18 Andrew Wellington <andrew@webkit.org>
3529 Reviewed by Alexey Proskuryakov.
3531 https://bugs.webkit.org/show_bug.cgi?id=62843
3532 WebKit Mac API calls didReceiveAuthenticationChallenge instead of
3533 didCancelAuthenticationChallenge
3535 * WebView/WebView.mm:
3536 (-[WebView _cacheResourceLoadDelegateImplementations]):
3538 2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
3540 Unreviewed, rolling out r89026.
3541 http://trac.webkit.org/changeset/89026
3542 https://bugs.webkit.org/show_bug.cgi?id=62804
3544 These patches were likely correct. I'll investigate the
3545 browser_test failures. (Requested by abarth on #webkit).
3547 * WebView/WebVideoFullscreenHUDWindowController.mm:
3548 (-[WebVideoFullscreenHUDWindowController setPlaying:]):
3550 2011-06-16 Vitaly Repeshko <vitalyr@chromium.org>
3554 Revert Adam's user gesture patch series r89002, r89005, r89007, r89018
3555 https://bugs.webkit.org/show_bug.cgi?id=62796
3557 The patches broke chromium browser tests.
3559 * WebView/WebVideoFullscreenHUDWindowController.mm:
3560 (-[WebVideoFullscreenHUDWindowController setPlaying:]):
3562 2011-06-16 Adam Barth <abarth@webkit.org>
3564 Reviewed by Eric Seidel.