1 2014-07-03 Daniel Bates <dabates@apple.com>
4 https://bugs.webkit.org/show_bug.cgi?id=134500
6 Rubber-stamped by Anders Carlsson.
8 Substitute WTF::move() for std::move().
10 * History/WebHistoryItem.mm:
11 (-[WebHistoryItem initFromDictionaryRepresentation:]):
12 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
13 (WebKit::NetscapePluginInstanceProxy::setCurrentReply):
14 * Plugins/WebNetscapePluginView.mm:
15 (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
16 * WebCoreSupport/WebFrameLoaderClient.mm:
17 (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
18 (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
19 (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
20 (WebFrameLoaderClient::dispatchWillSubmitForm):
21 * WebCoreSupport/WebInspectorClient.mm:
22 (WebInspectorClient::openInspectorFrontend):
23 (WebInspectorFrontendClient::WebInspectorFrontendClient):
24 * WebView/WebArchive.mm:
25 (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
27 2014-07-01 Mark Rowe <mrowe@apple.com>
29 <https://webkit.org/b/134522> Remove duplication in code that prepares the user agent string on Mac and iOS
31 Reviewed by Simon Fraser.
34 (webKitBundleVersionString): Return the entire CFBundleVersion now that WebCore handles formatting it.
35 (+[WebView _standardUserAgentWithApplicationName:]):
37 2014-07-02 Dan Bernstein <mitz@apple.com>
39 Remove some code only needed for versions of Safari that are no longer supported
40 https://bugs.webkit.org/show_bug.cgi?id=134537
42 Reviewed by Anders Carlsson.
44 * History/WebHistoryItem.mm:
45 * Misc/WebKitVersionChecks.h:
46 * WebCoreSupport/WebSecurityOrigin.mm:
47 (-[WebSecurityOrigin domain]): Deleted.
48 * WebInspector/WebInspector.mm:
49 (-[WebInspector showTimeline:]): Deleted.
50 (+[WebInspector webInspector]): Deleted.
51 (-[WebInspector setWebFrame:]): Deleted.
52 (-[WebInspector window]): Deleted.
53 (-[WebInspector showWindow:]): Deleted.
54 * WebView/WebFrame.mm:
56 * WebView/WebPDFView.mm:
57 (-[WebPDFView menuForEvent:]):
58 (-[WebPDFView _anyPDFTagsFoundInMenu:]): Deleted.
60 (-[WebView _initWithFrame:frameName:groupName:]):
61 (-[WebView _preferencesChanged:]):
62 (-[WebView initWithFrame:frameName:groupName:]):
63 (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]): Deleted.
64 (+[WebView _setAlwaysUseATSU:]): Deleted.
65 (-[WebView _needsUnrestrictedGetMatchedCSSRules]): Deleted.
66 * WebView/WebViewPrivate.h:
68 2014-07-01 Dan Bernstein <mitz@apple.com>
70 Remove WebChromeClient code that was only needed for Safari versions earlier than 3.1
71 https://bugs.webkit.org/show_bug.cgi?id=134531
73 Reviewed by Daniel Bates.
75 * WebCoreSupport/WebChromeClient.mm:
76 (WebChromeClient::exceededDatabaseQuota):
78 2014-06-29 Yoav Weiss <yoav@yoav.ws>
80 Add support for HTMLImageElement's sizes attribute
81 https://bugs.webkit.org/show_bug.cgi?id=133620
83 Reviewed by Dean Jackson.
85 Added an ENABLE_PICTURE_SIZES compile flag.
87 * Configurations/FeatureDefines.xcconfig:
89 2014-06-27 Sam Weinig <sam@webkit.org>
91 InfoClick (from Nisus Software) dies on viewing found items
92 <rdar://problem/17395601>
93 https://bugs.webkit.org/show_bug.cgi?id=134410
95 Reviewed by Andy Estes.
97 InfoClick was calling -[WebPreferences setPrivateBrowsingEnabled:] before
98 setting up a WebView (or anything else that would have set up WebKitSystemInterface),
99 which now requires a set up WebKitSystemInterface. We can fix this by initializing
100 it from +[WebPreferences initialize].
102 * WebView/WebPreferences.mm:
103 (+[WebPreferences initialize]):
104 Add call to InitWebCoreSystemInterface().
106 (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
107 Remove now unnecessary call to InitWebCoreSystemInterface().
109 2014-06-27 Peyton Randolph <prandolph@apple.com>
111 Add feature flag for link long-press gesture.
112 https://bugs.webkit.org/show_bug.cgi?id=134262
114 Reviewed by Enrica Casucci.
116 * Configurations/FeatureDefines.xcconfig:
117 Add ENABLE_LINK_LONG_PRESS.
119 2014-06-26 Brady Eidson <beidson@apple.com>
121 Remove use of PlatformStrategies for Gamepad API.
122 https://bugs.webkit.org/show_bug.cgi?id=134348
124 Reviewed by Dean Jackson.
126 Remove all the GamepadStrategy gunk:
127 * WebCoreSupport/WebHIDGamepadController.mm: Removed.
128 * WebCoreSupport/WebPlatformStrategies.h:
129 * WebCoreSupport/WebPlatformStrategies.mm:
130 (WebPlatformStrategies::createGamepadStrategy): Deleted.
131 (WebPlatformStrategies::startMonitoringGamepads): Deleted.
132 (WebPlatformStrategies::stopMonitoringGamepads): Deleted.
133 (WebPlatformStrategies::platformGamepads): Deleted.
135 Instead, install the HIDGamepadProvider as the shared GamepadProvider:
136 * WebView/WebView.mm:
137 (WebKitInitializeGamepadProviderIfNecessary):
138 (-[WebView _commonInitializationWithFrameName:groupName:]):
140 2014-06-26 Joseph Pecoraro <pecoraro@apple.com>
142 [iOS] Remove User Default for iOS TextField Debugging
143 https://bugs.webkit.org/show_bug.cgi?id=134356
145 Reviewed by Timothy Hatcher.
147 * WebView/WebPreferenceKeysPrivate.h:
148 * WebView/WebView.mm:
149 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
151 2014-06-25 Brady Eidson <beidson@apple.com>
153 Add HID-based gamepad implementation for Mac
154 https://bugs.webkit.org/show_bug.cgi?id=134324
156 Reviewed by Dean Jackson.
158 Add a class that acts as an intermediary between the GamepadStrategyClient
159 and the HIDGamepadListener:
160 * WebCoreSupport/WebHIDGamepadController.h:
161 * WebCoreSupport/WebHIDGamepadController.mm:
162 (WebHIDGamepadController::shared):
163 (WebHIDGamepadController::WebHIDGamepadController):
164 (WebHIDGamepadController::gamepadConnected):
165 (WebHIDGamepadController::gamepadDisconnected):
166 (WebHIDGamepadController::registerGamepadStrategyClient):
167 (WebHIDGamepadController::unregisterGamepadStrategyClient):
169 Implement the strategies by using the HIDGamepadListener:
170 * WebCoreSupport/WebPlatformStrategies.mm:
171 (WebPlatformStrategies::startMonitoringGamepads):
172 (WebPlatformStrategies::stopMonitoringGamepads):
173 (WebPlatformStrategies::platformGamepads):
175 2014-06-25 Brady Eidson <beidson@apple.com>
177 Add new platform gamepad abstractions
178 https://bugs.webkit.org/show_bug.cgi?id=134325
180 Reviewed by Dean Jackson.
182 * WebCoreSupport/WebPlatformStrategies.h:
183 * WebCoreSupport/WebPlatformStrategies.mm:
184 (WebPlatformStrategies::createGamepadStrategy):
185 (WebPlatformStrategies::startMonitoringGamepads):
186 (WebPlatformStrategies::stopMonitoringGamepads):
187 (WebPlatformStrategies::platformGamepads):
189 2014-06-25 Gavin Barraclough <baraclough@apple.com>
191 Should _updateVisibilityState on view hide/unhide.
192 https://bugs.webkit.org/show_bug.cgi?id=134314
195 Reviewed by Sam Weinig.
197 * WebView/WebView.mm:
198 (-[WebView viewDidHide]):
199 (-[WebView viewDidUnhide]):
201 2014-06-25 Chris Fleizach <cfleizach@apple.com>
203 Add an undo group for each dictated utterance in WebKit
204 https://bugs.webkit.org/show_bug.cgi?id=134086
206 Reviewed by Enrica Casucci.
208 * WebView/WebHTMLView.mm:
209 (-[WebHTMLView validAttributesForMarkedText]):
210 (-[WebHTMLView insertText:]):
212 2014-06-25 Dana Burkart <dburkart@apple.com>
214 Add support for 5-tuple versioning.
216 Reviewed by David Farler.
218 * Configurations/Version.xcconfig:
220 2014-06-25 Laszlo Gombos <l.gombos@samsung.com>
222 Remove build guard for progress element
223 https://bugs.webkit.org/show_bug.cgi?id=134292
225 Reviewed by Benjamin Poulain.
227 * Configurations/FeatureDefines.xcconfig:
229 2014-06-24 Benjamin Poulain <bpoulain@apple.com>
231 WK1 WebFrameNetworkingContext cleanup: do not instanciate an empty NSString to create an empty WTF::String
232 https://bugs.webkit.org/show_bug.cgi?id=134222
234 Reviewed by Andreas Kling.
236 * WebCoreSupport/WebFrameNetworkingContext.mm:
237 (WebFrameNetworkingContext::sourceApplicationIdentifier):
239 2014-06-24 Joseph Pecoraro <pecoraro@apple.com>
241 [iOS]: WK2 Inspector Node Highlighting
242 https://bugs.webkit.org/show_bug.cgi?id=134257
244 Reviewed by Timothy Hatcher.
246 * WebInspector/WebNodeHighlightView.mm:
247 (-[WebNodeHighlightView layoutSublayers:]):
249 2014-06-24 Brady Eidson <beidson@apple.com>
251 Enable GAMEPAD in the Mac build, but disabled at runtime.
252 https://bugs.webkit.org/show_bug.cgi?id=134255
254 Reviewed by Dean Jackson.
256 * Configurations/FeatureDefines.xcconfig:
258 * WebView/WebPreferenceKeysPrivate.h:
259 * WebView/WebPreferences.mm:
260 (-[WebPreferences gamepadsEnabled]):
261 (-[WebPreferences setGamepadsEnabled:]):
262 * WebView/WebPreferencesPrivate.h:
264 * WebView/WebView.mm:
265 (-[WebView _preferencesChanged:]):
267 2014-06-24 Dan Bernstein <mitz@apple.com>
269 Fixed the iOS build after r170358.
271 * WebView/WebView.mm:
274 2014-06-23 Anders Carlsson <andersca@apple.com>
276 Remove unused history visit code from WebHistoryItem
277 https://bugs.webkit.org/show_bug.cgi?id=134201
279 Reviewed by Sam Weinig.
281 * History/HistoryPropertyList.h:
282 * History/HistoryPropertyList.mm:
283 (HistoryPropertyListWriter::HistoryPropertyListWriter):
284 (HistoryPropertyListWriter::writeHistoryItem):
285 * History/WebHistory.mm:
286 (-[WebHistoryPrivate visitedURL:withTitle:]):
287 (-[WebHistoryPrivate addItem:discardDuplicate:]):
288 (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
289 (-[WebHistoryPrivate visitedURL:withTitle:increaseVisitCount:]): Deleted.
290 (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]): Deleted.
291 * History/WebHistoryInternal.h:
292 * History/WebHistoryItem.mm:
293 (-[WebHistoryItem copyWithZone:]):
294 (-[WebHistoryItem initFromDictionaryRepresentation:]):
295 (-[WebHistoryItem _visitedWithTitle:]):
296 (-[WebHistoryItem setVisitCount:]): Deleted.
297 (-[WebHistoryItem _mergeAutoCompleteHints:]): Deleted.
298 (-[WebHistoryItem _visitedWithTitle:increaseVisitCount:]): Deleted.
299 (-[WebHistoryItem _recordInitialVisit]): Deleted.
300 (timeToDay): Deleted.
301 (-[WebHistoryItem _padDailyCountsForNewVisit:]): Deleted.
302 (-[WebHistoryItem _collapseDailyVisitsToWeekly]): Deleted.
303 (-[WebHistoryItem _recordVisitAtTime:increaseVisitCount:]): Deleted.
304 (-[WebHistoryItem _setLastVisitedTimeInterval:]): Deleted.
305 * History/WebHistoryItemInternal.h:
306 * History/WebHistoryItemPrivate.h:
307 * WebCoreSupport/WebFrameLoaderClient.mm:
308 (WebFrameLoaderClient::updateGlobalHistory):
310 2014-06-24 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
312 REGRESSION(r170235): Remove incorrect ifdef guard
313 https://bugs.webkit.org/show_bug.cgi?id=134246
315 Reviewed by Csaba Osztrogonác.
317 * WebView/WebView.mm:
318 (-[WebView _visibilityState]):
320 2014-06-23 Anders Carlsson <andersca@apple.com>
324 * WebCoreSupport/WebSystemInterface.mm:
325 (InitWebCoreSystemInterface):
327 2014-06-21 Dan Bernstein <mitz@apple.com>
329 Tried to fix the iOS build after r170235.
331 * WebView/WebView.mm:
333 2014-06-21 Brady Eidson <beidson@apple.com>
335 Gamepad API - Deprecate the existing implementation
336 https://bugs.webkit.org/show_bug.cgi?id=134108
338 Reviewed by Timothy Hatcher.
340 -Add new "GAMEPAD_DEPRECATED" build flag, moving the existing implementation to use it
341 -Move some implementation files into a "deprecated" subdirectory.
343 * Configurations/FeatureDefines.xcconfig:
345 2014-06-21 Commit Queue <commit-queue@webkit.org>
347 Unreviewed, rolling out r170244.
348 https://bugs.webkit.org/show_bug.cgi?id=134157
350 GTK/EFL bindings generator works differently, making this
351 patch not work there. Will fix entire patch after a rollout.
352 (Requested by bradee-oh on #webkit).
356 "Gamepad API - Deprecate the existing implementation"
357 https://bugs.webkit.org/show_bug.cgi?id=134108
358 http://trac.webkit.org/changeset/170244
360 2014-06-21 Brady Eidson <beidson@apple.com>
362 Gamepad API - Deprecate the existing implementation
363 https://bugs.webkit.org/show_bug.cgi?id=134108
365 Reviewed by Timothy Hatcher.
367 -Add new "GAMEPAD_DEPRECATED" build flag, moving the existing implementation to use it
368 -Add the "Deprecated" suffix to some implementation files
370 * Configurations/FeatureDefines.xcconfig:
372 2014-06-21 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
374 Removing PAGE_VISIBILITY_API compile guard.
375 https://bugs.webkit.org/show_bug.cgi?id=133844
377 Reviewed by Gavin Barraclough.
379 * Configurations/FeatureDefines.xcconfig:
380 * WebView/WebView.mm:
381 (-[WebView _preferencesChanged:]):
382 (-[WebView _visibilityState]):
384 2014-06-18 Anders Carlsson <andersca@apple.com>
386 Make FrameLoadType a strongly typed enum
387 https://bugs.webkit.org/show_bug.cgi?id=134047
389 Reviewed by Andreas Kling.
391 * WebView/WebFrame.mm:
392 (toWebFrameLoadType):
393 (-[WebFrame _loadType]):
394 * WebView/WebView.mm:
395 (-[WebView _loadBackForwardListFromOtherView:]):
396 (-[WebView goToBackForwardItem:]):
398 2014-06-18 Daniel Bates <dabates@apple.com>
400 REGRESSION (r167856): Unable to log into HSBC app
401 https://bugs.webkit.org/show_bug.cgi?id=133991
402 <rdar://problem/17044839>
404 Reviewed by David Kilzer.
406 Only enable the setting allowNavigationToInvalidURL for iOS app linked against WebKit/UIKit before iOS 8.
408 * Misc/WebKitVersionChecks.h: Added macro constant WEBKIT_FIRST_VERSION_WITH_NAVIGATION_URL_VALIDATION.
409 * WebView/WebView.mm:
410 (-[WebView _preferencesChanged:]): Enable or disable the setting allowNavigationToInvalidURL as appropriate.
412 2014-06-18 Anders Carlsson <andersca@apple.com>
414 Adopt modern C++11 loops and fix WebArchive creation functions
415 https://bugs.webkit.org/show_bug.cgi?id=134032
417 Reviewed by Andreas Kling.
419 * WebView/WebArchive.mm:
420 (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
421 * WebView/WebDataSource.mm:
422 (-[WebDataSource subresources]):
424 2014-06-15 Anders Carlsson <andersca@apple.com>
426 Add an autorelease() member function to RetainPtr
427 https://bugs.webkit.org/show_bug.cgi?id=133929
429 Reviewed by Dan Bernstein.
431 * WebView/WebDataSource.mm:
432 (-[WebDataSource data]):
433 * WebView/WebHTMLView.mm:
434 (-[WebHTMLView _selectionDraggingImage]):
435 (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
436 * WebView/WebResource.mm:
437 (-[WebResource data]):
439 2014-06-11 Jeremy Jones <jeremyj@apple.com>
441 WebFrameNetworkContext should not have a sourceApplicationIdentifier in WK1.
442 https://bugs.webkit.org/show_bug.cgi?id=133772
444 Reviewed by Jer Noble.
446 Return empty string from sourceApplicationIdentifier for WK1.
448 * WebCoreSupport/WebFrameNetworkingContext.mm:
449 (WebFrameNetworkingContext::sourceApplicationIdentifier):
451 2014-06-10 Timothy Horton <timothy_horton@apple.com>
453 Factor repeated CFRunLoopObserver code out
454 https://bugs.webkit.org/show_bug.cgi?id=133690
456 Reviewed by Simon Fraser.
458 * WebView/WebViewData.h:
460 2014-06-05 Pratik Solanki <psolanki@apple.com>
462 Remove unsused method _setAcceleratedImageDecoding
463 https://bugs.webkit.org/show_bug.cgi?id=133554
465 Reviewed by Jon Honeycutt.
467 * WebView/WebView.mm:
468 (+[WebView _setAcceleratedImageDecoding:]): Deleted.
469 * WebView/WebViewPrivate.h:
471 2014-06-05 Benjamin Poulain <bpoulain@apple.com>
473 [iOS][WK2] Add device orientation
474 https://bugs.webkit.org/show_bug.cgi?id=133530
476 Reviewed by Tim Horton.
478 * WebView/WebFrame.mm:
479 (-[WebFrame deviceOrientationChanged]):
480 (-[WebFrame sendOrientationChangeEvent:]):
481 * WebView/WebFramePrivate.h:
483 2014-05-31 Anders Carlsson <andersca@apple.com>
485 Change DeferrableOneShotTimer to use std::function instead of being a class template
486 https://bugs.webkit.org/show_bug.cgi?id=133423
488 Reviewed by Antti Koivisto.
490 * WebView/WebView.mm:
491 (+[WebView _setCacheModel:]):
493 2014-05-27 Jon Lee <jonlee@apple.com>
495 Update ENABLE(MEDIA_SOURCE) on Mac
496 https://bugs.webkit.org/show_bug.cgi?id=133141
498 Reviewed by Darin Adler.
500 * Configurations/FeatureDefines.xcconfig:
502 2014-05-27 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
505 https://bugs.webkit.org/show_bug.cgi?id=132863
507 Reviewed by Csaba Osztrogonác.
509 * Configurations/FeatureDefines.xcconfig:
510 * WebView/WebView.mm:
511 (+[WebView _canHandleRequest:forMainFrame:]):
513 2014-05-24 Chris Fleizach <cfleizach@apple.com>
515 AX: fix coordinate mapping for iOS accessibility
516 https://bugs.webkit.org/show_bug.cgi?id=133188
518 Reviewed by Sam Weinig.
520 * WebCoreSupport/WebChromeClient.h:
521 * WebCoreSupport/WebChromeClient.mm:
522 (WebChromeClient::accessibilityScreenToRootView):
523 (WebChromeClient::rootViewToAccessibilityScreen):
525 2014-05-23 Jeremy Jones <jeremyj@apple.com>
527 Hide fullscreen immediately when switching tabs.
528 https://bugs.webkit.org/show_bug.cgi?id=133239
530 Reviewed by Eric Carlson.
532 Renamed a function to better describe it's new functionality.
534 * WebView/WebView.mm:
535 (-[WebView viewDidMoveToWindow]):
536 now calls: requestHideAndExitFullscreen
538 2014-05-20 Dean Jackson <dino@apple.com>
540 [Mac] Allow popup menus to override default appearance
541 https://bugs.webkit.org/show_bug.cgi?id=133129
543 Reviewed by Tim Horton.
545 Replace the call to wkPopupMenuWithSize with wkPopupMenu, now
546 with extra parameters to indicate the control size and whether
547 or not to draw the arrows at the end.
549 * WebCoreSupport/PopupMenuMac.mm:
550 (PopupMenuMac::show):
552 2014-05-20 Eric Carlson <eric.carlson@apple.com>
554 [Mac] do not deactivate an audio session that has running I/O
555 https://bugs.webkit.org/show_bug.cgi?id=133127
557 Reviewed by Jer Noble.
559 * WebView/WebView.mm:
560 (-[WebView _commonInitializationWithFrameName:groupName:]): Settings::setShouldManageAudioSession
561 renamed to setShouldManageAudioSessionCategory, deal with it.
563 2014-05-19 Brady Eidson <beidson@apple.com>
565 Use different AppKit API for image control menus.
566 <rdar://problem/16807828> and https://bugs.webkit.org/show_bug.cgi?id=133087
568 Reviewed by Tim Horton.
570 For image control menus, use popUpMenuPositioningItem: instead of popUpContextMenu:
572 * WebCoreSupport/WebContextMenuClient.h:
573 * WebCoreSupport/WebContextMenuClient.mm:
574 (WebContextMenuClient::contextMenuForEvent):
575 (WebContextMenuClient::showContextMenu):
577 2014-05-19 Andy Estes <aestes@apple.com>
579 Set WebKitSuppressesIncrementalRenderingKey to NO by default on both Mac and iOS
580 https://bugs.webkit.org/show_bug.cgi?id=133073
582 Reviewed by Simon Fraser.
584 * WebView/WebPreferences.mm:
585 (+[WebPreferences initialize]):
587 2014-05-18 Anders Carlsson <andersca@apple.com>
589 Bring back two NSString category methods on iOS
590 https://bugs.webkit.org/show_bug.cgi?id=133055
591 <rdar://problem/16951983>
593 Reviewed by Adele Peterson.
595 * Misc/WebNSURLExtras.h:
596 * Misc/WebNSURLExtras.mm:
597 (-[NSString _webkit_unescapedQueryValue]):
598 (-[NSString _webkit_queryKeysAndValues]):
600 2014-05-18 Rik Cabanier <cabanier@adobe.com>
602 support for navigator.hardwareConcurrency
603 https://bugs.webkit.org/show_bug.cgi?id=132588
605 Reviewed by Filip Pizlo.
607 * Configurations/FeatureDefines.xcconfig:
609 2014-05-17 Zalan Bujtas <zalan@apple.com>
611 Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
612 https://bugs.webkit.org/show_bug.cgi?id=133029
614 Reviewed by Simon Fraser.
616 To match the WK2 preferences API.
618 * WebView/WebPreferenceKeysPrivate.h:
619 * WebView/WebPreferences.mm:
620 (+[WebPreferences initialize]):
621 (-[WebPreferences subpixelCSSOMElementMetricsEnabled]):
622 (-[WebPreferences setSubpixelCSSOMElementMetricsEnabled:]):
623 * WebView/WebPreferencesPrivate.h:
624 * WebView/WebView.mm:
625 (-[WebView _preferencesChanged:]):
627 2014-05-16 Simon Fraser <simon.fraser@apple.com>
629 Remove "region-based columns" prefs
630 https://bugs.webkit.org/show_bug.cgi?id=133006
631 <rdar://problem/16945824>
633 Reviewed by Dave Hyatt.
635 Remove "region-based columns" prefs and related code, since this is only
636 way to render columns now.
638 * WebView/WebPreferenceKeysPrivate.h:
639 * WebView/WebPreferences.mm:
640 (+[WebPreferences initialize]):
641 (-[WebPreferences setRegionBasedColumnsEnabled:]): Deleted.
642 (-[WebPreferences regionBasedColumnsEnabled]): Deleted.
643 * WebView/WebPreferencesPrivate.h:
644 * WebView/WebView.mm:
645 (-[WebView _preferencesChanged:]):
647 2014-05-15 Brady Eidson <beidson@apple.com>
649 Crash in [WebSharingServicePickerController clear]
650 <rdar://problem/16879073> and https://bugs.webkit.org/show_bug.cgi?id=132968
652 Reviewed by Tim Horton.
654 * Misc/WebSharingServicePickerController.mm:
655 (-[WebSharingServicePickerController clear]): Add a RetainPtr protector so this object
656 isn’t dealloc’ed partway through.
658 2014-05-15 Simon Fraser <simon.fraser@apple.com>
660 Initialize the WebKitRegionBasedColumnsEnabled pref on iOS WK1
661 https://bugs.webkit.org/show_bug.cgi?id=132969
663 Reviewed by Dan Bernstein.
665 Move this outside the #if !PLATFORM(IOS) block.
667 * WebView/WebPreferences.mm:
668 (+[WebPreferences initialize]):
670 2014-05-15 Simon Fraser <simon.fraser@apple.com>
672 Clean up -[WebView _preferencesChanged]
673 https://bugs.webkit.org/show_bug.cgi?id=132967
675 Reviewed by Sam Weinig.
677 -[WebView _preferencesChanged] was a horrible mess of #ifdefs. Clean this up by
678 moving all the #if PLATFORM() code together, and moving all the feature-define related
681 No behavior changes, checked by diffing the resulting Settings with and without
682 the patch, on OS X and iOS.
684 * WebView/WebView.mm:
685 (-[WebView _preferencesChanged:]):
687 2014-05-15 Alex Christensen <achristensen@webkit.org>
689 Add pointer lock to features without enabling it.
690 https://bugs.webkit.org/show_bug.cgi?id=132961
692 Reviewed by Sam Weinig.
694 * Configurations/FeatureDefines.xcconfig:
695 Added ENABLE_POINTER_LOCK to list of features.
696 * WebView/WebPDFView.mm:
697 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
698 Added extra parameters needed when pointer lock is enabled.
700 2014-05-14 Brady Eidson <beidson@apple.com>
702 Implement NSSharingServiceDelegate method "transitionImageForShareItem"
703 <rdar://problem/16878020> and https://bugs.webkit.org/show_bug.cgi?id=132911
705 Reviewed by Tim Horton.
707 * Misc/WebSharingServicePickerController.mm:
708 (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
710 * WebCoreSupport/WebContextMenuClient.h:
711 * WebCoreSupport/WebContextMenuClient.mm:
712 (WebContextMenuClient::renderedImageForControlledImage): Paint the entire content rect for the controlled image
713 into an ImageBuffer, then return the resulting NSImage. This only paints the image itself and not any
714 overlapping content by setting the selection and appropriate painting mode.
716 2014-05-14 Brady Eidson <beidson@apple.com>
718 sourceFrameOnScreenForShareItem: can be off by a pixel
719 <rdar://problem/16878020> and https://bugs.webkit.org/show_bug.cgi?id=132911
721 Reviewed by Simon Fraser.
723 In a land of LayoutUnits and sub-pixel rendering, converting between IntRects and
724 FloatRects can be error prone. So we now try to minimize such conversions.
726 * Misc/WebSharingServicePickerController.mm:
727 (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
729 * WebCoreSupport/WebContextMenuClient.h:
730 * WebCoreSupport/WebContextMenuClient.mm:
731 (WebContextMenuClient::clientFloatRectForNode): Split this into a separate utility method
732 as it will be shared with other code very soon. Instead of using absoluteBoundingBoxRect()
733 which does lossy float->int conversions, try to keep things in terms of FloatRects as
735 (WebContextMenuClient::screenRectForHitTestNode): Call clientFloatRectForNode to get the
736 FloatRect, then perform the lossy rounding conversion to an IntRect only once.
738 2014-05-14 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
740 Remove CSS_STICKY_POSITION guards
741 https://bugs.webkit.org/show_bug.cgi?id=132676
743 Reviewed by Simon Fraser.
745 * Configurations/FeatureDefines.xcconfig:
747 2014-05-14 Antti Koivisto <antti@apple.com>
749 GIF animations don't restart after scrolling with iOS WebKit1
750 https://bugs.webkit.org/show_bug.cgi?id=132900
751 <rdar://problem/16490858>
753 Reviewed by Andreas Kling.
755 * WebView/WebView.mm:
756 (-[WebView _didFinishScrollingOrZooming]):
758 Check if the animations need to be restarted after scrolling finishes.
760 2014-05-09 Joseph Pecoraro <pecoraro@apple.com>
762 Web Inspector: Allow Remote Inspector to entitlement check UIProcess through WebProcess
763 https://bugs.webkit.org/show_bug.cgi?id=132409
765 Reviewed by Timothy Hatcher.
767 Simplify the legacy iOS UIWebViewController case by passing on
768 the host process pid and audit_token.
770 * WebView/WebView.mm:
771 (-[WebView _setHostApplicationProcessIdentifier:auditToken:]):
772 (-[WebView setHostApplicationBundleId:name:]): Deleted.
773 (-[WebView hostApplicationBundleId]): Deleted.
774 (-[WebView hostApplicationName]): Deleted.
775 * WebView/WebViewData.h:
776 * WebView/WebViewData.mm:
777 (-[WebViewPrivate dealloc]):
778 * WebView/WebViewPrivate.h:
780 2014-05-09 Benjamin Poulain <benjamin@webkit.org>
782 [iOS] Switch geolocation to an explicit authorization query model
783 https://bugs.webkit.org/show_bug.cgi?id=132717
785 Reviewed by Sam Weinig.
787 Since there is no warmup code, WebGeolocationPolicyListener no longer need to know about the provider,
790 * WebCoreSupport/WebGeolocationClient.mm:
791 (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
792 (-[WebGeolocationPolicyListener deny]):
793 (-[WebGeolocationProviderInitializationListener initializationAllowedWebView:]):
794 (-[WebGeolocationProviderInitializationListener initializationDeniedWebView:]):
795 (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:provider:]): Deleted.
796 (-[WebGeolocationProviderInitializationListener initializationAllowedWebView:provider:]): Deleted.
797 (-[WebGeolocationProviderInitializationListener initializationDeniedWebView:provider:]): Deleted.
798 * WebView/WebViewPrivate.h:
800 2014-05-08 Jer Noble <jer.noble@apple.com>
802 [Mac, iOS] Add source application accounting to AVURLAsset.
803 https://bugs.webkit.org/show_bug.cgi?id=132637
805 Reviewed by Eric Carlson.
807 Add accessor for sourceApplicationIdentifier.
809 * WebCoreSupport/WebFrameNetworkingContext.h:
810 * WebCoreSupport/WebFrameNetworkingContext.mm:
811 (WebFrameNetworkingContext::sourceApplicationIdentifier):
813 2014-05-08 Anders Carlsson <andersca@apple.com>
815 Use a different install name for WebKitLegacy.framework for staged framework builds
816 https://bugs.webkit.org/show_bug.cgi?id=132711
817 <rdar://problem/16850620>
819 Reviewed by Dan Bernstein.
821 * Configurations/WebKitLegacy.xcconfig:
823 2014-05-08 Brady Eidson <beidson@apple.com>
825 Wrap a new class definition with __has_include()
826 <rdar://problem/16852395> and https://bugs.webkit.org/show_bug.cgi?id=132694
828 Reviewed by Tim Horton.
830 * Misc/WebSharingServicePickerController.mm:
832 2014-05-07 Pratik Solanki <psolanki@apple.com>
834 Use system defaults for hardware jpeg decoding
835 https://bugs.webkit.org/show_bug.cgi?id=132661
836 <rdar://problem/11348201>
838 Reviewed by Tim Horton.
840 Remove code that explicitly disabled hardware image decoding. Let the system decide what to do.
842 * WebView/WebView.mm:
843 (+[WebView _setAcceleratedImageDecoding:]):
844 (+[WebView _acceleratedImageDecoding]): Deleted.
845 * WebView/WebViewPrivate.h:
847 2014-05-07 Brent Fulgham <bfulgham@apple.com>
849 [Mac, iOS] REGRESSION: WK2 YouTube support
850 https://bugs.webkit.org/show_bug.cgi?id=132568
851 <rdar://problem/11464344>
853 Reviewed by Darin Adler.
855 * Misc/WebNSURLExtras.h:
856 * Misc/WebNSURLExtras.mm: Remove code that has been converted to C++
857 and added to YouTubePluginReplacement.cpp.
858 (-[NSURL _webkit_youTubeURL]):
859 (-[NSString _webkit_queryKeysAndValues]):
860 (createYouTubeURL): Deleted.
861 (-[NSString _webkit_unescapedQueryValue]): Deleted.
863 2014-05-07 Jeremy Jones <jeremyj@apple.com>
865 HTMLMediaElement should exitFullscreen when view is removed from the window.
866 https://bugs.webkit.org/show_bug.cgi?id=132506
868 Reviewed by Tim Horton.
870 * WebView/WebView.mm:
871 (-[WebView viewDidMoveToWindow]):
872 Request WebVideoFullscreenController to exitFullscreen when view is removed from the window.
874 2014-05-07 Brady Eidson <beidson@apple.com>
876 Image menu is offset by the amount the view is scrolled
877 <rdar://problem/16818966> and https://bugs.webkit.org/show_bug.cgi?id=132663
879 Reviewed by Tim Horton.
881 * WebCoreSupport/WebContextMenuClient.mm:
882 (WebContextMenuClient::showContextMenu): Use FrameView::contentsToWindow instead of contentsToRoot,
883 and skip the [NSView convertPoint:toView:] step.
885 2014-05-07 Simon Fraser <simon.fraser@apple.com>
887 WebKit1 is flashy when compositing layers come and go
888 https://bugs.webkit.org/show_bug.cgi?id=132655
890 Reviewed by Sam Weinig.
892 In r166117 I removed code to flush compositing layers in FrameView::paintContents(),
893 which caused problems when painting iframes. However, this removed a flush
894 that WebKit1 relied on to flush compositing layers when painting, which caused
895 flashing when compositing layers come and go, and broke WebView snapshotting
898 Fix by adding back compositing layer flushing, but this time in WebKit1's
899 -viewWillDraw code path. This allows removal of some flushing in DumpRenderTree.
901 * WebView/WebHTMLView.mm:
902 (-[WebHTMLView viewWillDraw]):
903 * WebView/WebView.mm:
904 (-[WebView _flushCompositingChanges]):
905 * WebView/WebViewInternal.h:
906 * WebView/WebViewPrivate.h:
908 2014-05-07 Manuel Rego Casasnovas <rego@igalia.com>
910 [CSS Grid Layout] Remove runtime feature
911 https://bugs.webkit.org/show_bug.cgi?id=132382
913 Reviewed by Benjamin Poulain.
915 Remove cssGridLayoutEnabled setting usage.
918 * WebView/WebPreferenceKeysPrivate.h:
919 * WebView/WebPreferences.mm:
920 (+[WebPreferences initialize]):
921 (-[WebPreferences cssGridLayoutEnabled]): Deleted.
922 (-[WebPreferences setCSSGridLayoutEnabled:]): Deleted.
923 * WebView/WebPreferencesPrivate.h:
924 * WebView/WebView.mm:
925 (-[WebView _preferencesChanged:]):
927 2014-05-06 Dean Jackson <dino@apple.com>
929 [Mac] Allow focus rings to redraw themselves if necessary
930 https://bugs.webkit.org/show_bug.cgi?id=132593
932 Reviewed by Simon Fraser.
934 * WebCoreSupport/WebSystemInterface.mm:
935 (InitWebCoreSystemInterface): Add DrawFocusRingAtTime and DrawCellFocusRingWithFrameAtTime.
937 2014-05-06 Brady Eidson <beidson@apple.com>
939 Don't select an image that is about to have its menu shown.
940 <rdar://problem/16807845> and https://bugs.webkit.org/show_bug.cgi?id=132579
942 Reviewed by Tim Horton.
944 * Misc/WebSharingServicePickerController.mm:
945 (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
946 Call the new replaceNodeFromPasteboard API instead of readSelectionFromPasteboard.
948 2014-05-06 Anders Carlsson <andersca@apple.com>
950 Move the WebKitLegacy header check to the right file
951 https://bugs.webkit.org/show_bug.cgi?id=132620
952 <rdar://problem/16815716>
954 Reviewed by Dan Bernstein.
956 * WebKitLegacy/MigrateHeadersFromWebKitLegacy.make:
957 * WebKitLegacy/WebKit.h:
959 2014-05-06 Anders Carlsson <andersca@apple.com>
961 Put WebKitPluginHost.app in WebKitLegacy.framework
962 https://bugs.webkit.org/show_bug.cgi?id=132592
963 <rdar://problem/15920046>
965 Reviewed by Dan Bernstein.
967 * Plugins/Hosted/NetscapePluginHostManager.mm:
968 (WebKit::NetscapePluginHostManager::spawnPluginHost):
970 2014-05-06 Darin Adler <darin@apple.com>
972 [iOS] Fix two more AdoptCF I missed in my last patch.
974 * WebView/WebHTMLView.mm:
975 (imageFromRect): Use adoptCF instead of AdoptCF.
977 2014-05-05 Andreas Kling <akling@apple.com>
979 Unreviewed, rolling out r168334.
985 "Put WebKitPluginHost.app in WebKitLegacy.framework"
986 https://bugs.webkit.org/show_bug.cgi?id=132592
987 http://trac.webkit.org/changeset/168334
989 2014-05-05 Anders Carlsson <andersca@apple.com>
991 Put WebKitPluginHost.app in WebKitLegacy.framework
992 https://bugs.webkit.org/show_bug.cgi?id=132592
993 <rdar://problem/15920046>
995 Reviewed by Dan Bernstein.
997 * Plugins/Hosted/NetscapePluginHostManager.mm:
998 (WebKit::NetscapePluginHostManager::spawnPluginHost):
1000 2014-05-02 Brady Eidson <beidson@apple.com>
1002 Implement new delegate method -sharingService:sourceFrameOnScreenForShareItem:.
1003 <rdar://problem/16797425> and https://bugs.webkit.org/show_bug.cgi?id=132484
1005 Reviewed by Tim Horton.
1007 * Misc/WebSharingServicePickerController.mm:
1008 (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
1010 * WebCoreSupport/WebContextMenuClient.h:
1011 * WebCoreSupport/WebContextMenuClient.mm:
1012 (WebContextMenuClient::screenRectForHitTestNode):
1014 2014-05-02 Brady Eidson <beidson@apple.com>
1016 Crash inside [WebSharingServicePickerController clear]
1017 <rdar://problem/16791944> and https://bugs.webkit.org/show_bug.cgi?id=132477
1019 Reviewed by Tim Horton.
1021 * Misc/WebSharingServicePickerController.h:
1022 * Misc/WebSharingServicePickerController.mm:
1023 (-[WebSharingServicePickerController clear]): clear can be called twice, so null check _menuClient.
1025 * WebCoreSupport/WebContextMenuClient.h:
1026 * WebCoreSupport/WebContextMenuClient.mm:
1027 (WebContextMenuClient::~WebContextMenuClient): For a sanity check, call clear on the picker here.
1029 2014-05-01 Tim Horton <timothy_horton@apple.com>
1031 More 32-bit build fixes.
1033 * Misc/WebSharingServicePickerController.mm:
1034 (-[WebSharingServicePickerController sharingService:didShareItems:]):
1036 2014-05-01 Tim Horton <timothy_horton@apple.com>
1038 Temporarily "fix" the 32-bit build.
1040 * Misc/WebSharingServicePickerController.mm:
1041 This will fail miserably at runtime, but we shouldn't ever get here in a 32-bit process.
1043 2014-05-01 Brady Eidson <beidson@apple.com>
1045 Update service picker API usage.
1046 <rdar://problem/16772674> and https://bugs.webkit.org/show_bug.cgi?id=132452
1048 Reviewed by Tim Horton.
1050 * Misc/WebSharingServicePickerController.h:
1051 * Misc/WebSharingServicePickerController.mm:
1052 (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
1053 Factor out a common "didShare" handler that optionally validates whether the data represents an image.
1054 (-[WebSharingServicePickerController sharingService:didShareItems:]): Update API usage, including marshalling
1055 on off-main thread call back to the main thread.
1057 * WebCoreSupport/WebContextMenuClient.mm:
1058 (WebContextMenuClient::contextMenuForEvent): Update API usage.
1060 2014-05-01 Anders Carlsson <andersca@apple.com>
1062 Support OS-version-specific install paths for WebKit.framework
1063 https://bugs.webkit.org/show_bug.cgi?id=132448
1064 <rdar://problem/16784932>
1066 Reviewed by Dan Bernstein.
1068 * WebKitLegacy/WebKit.m:
1069 Add version specific install names.
1071 2014-04-30 Alexey Proskuryakov <ap@apple.com>
1073 Roll out fix for https://bugs.webkit.org/show_bug.cgi?id=131637:
1074 Clean up unnecessary methods in the BackForwardClient interface
1076 It broke a regression test and an API test.
1078 * History/WebBackForwardList.mm:
1079 (-[WebBackForwardList initWithBackForwardList:]):
1080 (-[WebBackForwardList init]):
1081 (-[WebBackForwardList dealloc]):
1082 (-[WebBackForwardList finalize]):
1083 (-[WebBackForwardList setPageCacheSize:]):
1084 (-[WebBackForwardList pageCacheSize]):
1085 * History/WebBackForwardListInternal.h:
1086 * WebCoreSupport/WebFrameLoaderClient.mm:
1087 (WebFrameLoaderClient::canCachePage):
1088 * WebView/WebFrameView.mm:
1089 (-[WebFrameView keyDown:keyDown:]):
1090 * WebView/WebView.mm:
1091 (-[WebView _loadBackForwardListFromOtherView:]):
1092 (-[WebView initWithCoder:]):
1093 (-[WebView encodeWithCoder:]):
1094 (-[WebView backForwardList]):
1095 (-[WebView setMaintainsBackForwardList:]):
1097 2014-04-30 Simon Fraser <simon.fraser@apple.com>
1099 Remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
1100 https://bugs.webkit.org/show_bug.cgi?id=132396
1102 Reviewed by Eric Carlson.
1104 Remove ENABLE_PLUGIN_PROXY_FOR_VIDEO and related code.
1106 * Configurations/FeatureDefines.xcconfig:
1107 * Plugins/WebPluginContainerPrivate.h:
1108 * Plugins/WebPluginController.h:
1109 * Plugins/WebPluginController.mm:
1110 (-[WebPluginController dealloc]):
1111 (-[WebPluginController plugInsAreRunning]):
1112 (-[WebPluginController stopAllPlugins]):
1113 (-[WebPluginController stopPluginsForPageCache]):
1114 (-[WebPluginController restorePluginsFromCache]):
1115 (-[WebPluginController addPlugin:]):
1116 (-[WebPluginController destroyPlugin:]):
1117 (-[WebPluginController destroyAllPlugins]):
1118 (-[NSView isMediaPlugInProxyView]): Deleted.
1119 (-[NSView setIsMediaPlugInProxyView:]): Deleted.
1120 (-[WebPluginController mediaPlugInProxyViewCreated:]): Deleted.
1121 (+[WebPluginController pluginViewHidden:]): Deleted.
1122 (mediaProxyClient): Deleted.
1123 (-[WebPluginController _webPluginContainerSetMediaPlayerProxy:forElement:]): Deleted.
1124 (-[WebPluginController _webPluginContainerPostMediaPlayerNotification:forElement:]): Deleted.
1125 * WebCoreSupport/WebFrameLoaderClient.h:
1126 * WebCoreSupport/WebFrameLoaderClient.mm:
1128 * WebView/WebView.mm:
1129 (-[WebView _preferencesChanged:]):
1130 (-[WebView _videoProxyPluginForMIMEType:]): Deleted.
1131 * WebView/WebViewInternal.h:
1133 2014-04-30 Anders Carlsson <andersca@apple.com>
1135 Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
1136 https://bugs.webkit.org/show_bug.cgi?id=132399
1137 <rdar://problem/15920046>
1139 Reviewed by Dan Bernstein.
1141 * Carbon/CarbonUtils.h:
1142 * Carbon/HIViewAdapter.h:
1143 * Carbon/HIWebView.h:
1144 Import WebKitLegacy headers instead of WebKit headers.
1146 * Configurations/WebKit.xcconfig:
1147 Move the definitions needed for building WebKitLegacy.framework to WebKitLegacy.xcconfig and
1148 add the relevant definitions needed for re-exporting WebKitLegacy.framework.
1150 * Configurations/WebKitLegacy.xcconfig:
1151 Add definitions needed for building the "old" WebKit API as WebKitLegacy.framework.
1153 * DOM/WebDOMOperations.h:
1154 * DOM/WebDOMOperations.mm:
1155 * DOM/WebDOMOperationsInternal.h:
1156 * DOM/WebDOMOperationsPrivate.h:
1157 * DefaultDelegates/WebDefaultContextMenuDelegate.h:
1158 * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1159 * DefaultDelegates/WebDefaultEditingDelegate.m:
1160 * History/WebBackForwardListInternal.h:
1161 * History/WebBackForwardListPrivate.h:
1162 * History/WebHistoryItemPrivate.h:
1163 * History/WebHistoryPrivate.h:
1164 * History/WebURLsWithTitles.m:
1165 Import WebKitLegacy headers instead of WebKit headers.
1167 * MigrateHeaders.make:
1168 Update header paths now that all WebKitLegacy headers are private.
1169 Remove migration of WebKit2 headers, that is done by MigrateHeadersFromWebKitLegacy.make now.
1171 * Misc/WebCoreStatistics.h:
1172 * Misc/WebDownload.h:
1173 * Misc/WebDownload.mm:
1174 * Misc/WebDownloadInternal.h:
1175 * Misc/WebElementDictionary.mm:
1176 * Misc/WebIconDatabasePrivate.h:
1178 * Misc/WebKitErrors.m:
1179 * Misc/WebKitErrorsPrivate.h:
1180 * Misc/WebKitNSStringExtras.mm:
1181 * Misc/WebLocalizableStrings.mm:
1182 * Misc/WebNSDataExtras.m:
1183 * Misc/WebNSDictionaryExtras.m:
1184 * Misc/WebNSEventExtras.m:
1185 * Misc/WebNSFileManagerExtras.mm:
1186 * Misc/WebNSImageExtras.m:
1187 * Misc/WebNSPasteboardExtras.mm:
1188 * Misc/WebNSViewExtras.h:
1189 * Misc/WebNSViewExtras.m:
1190 * Panels/WebAuthenticationPanel.m:
1191 * Panels/WebPanelAuthenticationHandler.m:
1192 * Plugins/Hosted/HostedNetscapePluginStream.h:
1193 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1194 * Plugins/Hosted/WebKitPluginAgent.defs:
1195 * Plugins/Hosted/WebKitPluginAgentReply.defs:
1196 * Plugins/Hosted/WebKitPluginClient.defs:
1197 * Plugins/Hosted/WebKitPluginHost.defs:
1198 * Plugins/Hosted/WebKitPluginHostTypes.defs:
1199 * Plugins/WebBaseNetscapePluginView.mm:
1200 * Plugins/WebBasePluginPackage.h:
1201 * Plugins/WebBasePluginPackage.mm:
1202 * Plugins/WebNetscapeContainerCheckPrivate.h:
1203 * Plugins/WebNetscapePluginEventHandlerCocoa.h:
1204 * Plugins/WebNetscapePluginStream.h:
1205 * Plugins/WebNetscapePluginView.h:
1206 * Plugins/WebNetscapePluginView.mm:
1207 * Plugins/WebPlugin.h:
1208 * Plugins/WebPluginController.h:
1209 * Plugins/WebPluginDatabase.h:
1210 * Plugins/WebPluginPackage.h:
1211 * Plugins/WebPluginPackage.mm:
1212 * Plugins/WebPluginViewFactory.h:
1213 * Plugins/WebPluginViewFactoryPrivate.h:
1215 * Storage/WebDatabaseManagerPrivate.h:
1216 * WebCoreSupport/WebContextMenuClient.mm:
1217 * WebCoreSupport/WebFrameLoaderClient.mm:
1218 * WebCoreSupport/WebFrameNetworkingContext.mm:
1219 * WebCoreSupport/WebGeolocationClient.mm:
1220 * WebCoreSupport/WebInspectorClient.mm:
1221 * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1222 * WebCoreSupport/WebKeyGenerator.mm:
1223 * WebInspector/WebInspectorPrivate.h:
1224 * WebInspector/WebNodeHighlight.h:
1225 * WebInspector/WebNodeHighlightView.h:
1226 Import WebKitLegacy headers instead of WebKit headers.
1228 * WebKitLegacy/MigrateHeadersFromWebKitLegacy.make: Added.
1229 New makefile that handles copying WebKitLegacy headers to the WebKit framework, rewriting WebKitLegacy
1230 imports to WebKit imports. (On iOS the WebKit headers just forward to the relevant WebKitLegacy headers).
1231 On OS X, this also handles copying WebKit2 headers to the WebKit framework, rewriting WebKit2 imports to WebKit imports
1232 and getting rid of C SPI imports.
1234 * WebKitLegacy/MigrateHeadersToLegacy.make: Removed.
1235 This is no longer needed.
1237 * WebKitLegacy/WebKit.h: Added.
1238 New umbrella header that imports the modern API if available, as well as the legacy API (using WebKit/WebKitLegacy.h).
1240 * WebKitLegacy/WebKit.m:
1241 This is an empty file so we'll have something to link.
1243 * WebKitLegacy/WebKitPrivate.h:
1244 New SPI header that imports the private headers of the modern API.
1246 * WebView/WebDataSource.h:
1247 * WebView/WebDataSource.mm:
1248 * WebView/WebDataSourcePrivate.h:
1249 * WebView/WebDelegateImplementationCaching.h:
1250 * WebView/WebDocument.h:
1251 * WebView/WebDocumentInternal.h:
1252 * WebView/WebDocumentPrivate.h:
1253 * WebView/WebEditingDelegate.h:
1254 * WebView/WebEditingDelegatePrivate.h:
1255 * WebView/WebFrameLoadDelegate.h:
1256 * WebView/WebFrameLoadDelegatePrivate.h:
1257 * WebView/WebFramePrivate.h:
1258 * WebView/WebFrameView.h:
1259 * WebView/WebFrameViewInternal.h:
1260 * WebView/WebFrameViewPrivate.h:
1261 * WebView/WebHTMLRepresentation.h:
1262 * WebView/WebHTMLRepresentation.mm:
1263 * WebView/WebHTMLRepresentationPrivate.h:
1264 * WebView/WebHTMLView.h:
1265 * WebView/WebHTMLView.mm:
1266 * WebView/WebHTMLViewPrivate.h:
1267 * WebView/WebPDFView.h:
1268 * WebView/WebPolicyDelegatePrivate.h:
1269 * WebView/WebPreferencesPrivate.h:
1270 * WebView/WebResourcePrivate.h:
1271 * WebView/WebUIDelegate.h:
1272 * WebView/WebUIDelegatePrivate.h:
1273 * WebView/WebView.h:
1274 * WebView/WebView.mm:
1275 * WebView/WebViewPrivate.h:
1276 Import WebKitLegacy headers instead of WebKit headers.
1278 * migrate-headers.sh:
1279 Derived sources are put in DerivedSources/WebKitLegacy now.
1281 2014-04-30 David Hyatt <hyatt@apple.com>
1283 [New Multicolumn] Enable new multi-column mode
1284 https://bugs.webkit.org/show_bug.cgi?id=131825
1286 Reviewed by Simon Fraser.
1288 * WebView/WebPreferences.mm:
1289 (+[WebPreferences initialize]):
1291 2014-04-30 Brian J. Burg <burg@cs.washington.edu>
1293 Clean up unnecessary methods in the BackForwardClient interface
1294 https://bugs.webkit.org/show_bug.cgi?id=131637
1296 Reviewed by Andreas Kling.
1298 BackForwardClient instances now have ownership lifetime semantics, so
1299 WebBackForwardList now explicitly deletes its inner BackForwardList.
1301 Convert uses of WebCore::BackForwardList through backForward().client() to
1302 accept references instead of pointers.
1304 Use BackForwardController methods rather than directly operating with the
1305 BackForwardClient where possible.
1307 Remove page cache-related methods that are not used anywhere and that call
1308 BackForwardClient::page(), which is removed by this change.
1310 * History/WebBackForwardList.mm:
1311 (-[WebBackForwardList initWithBackForwardList:]):
1312 (-[WebBackForwardList init]):
1313 (-[WebBackForwardList dealloc]):
1314 (-[WebBackForwardList finalize]):
1315 (-[WebBackForwardList setPageCacheSize]): Deleted.
1316 (-[WebBackForwardList pageCacheSize]): Deleted.
1317 (-[WebBackForwardList itemAtIndex:]): Deleted.
1318 * History/WebBackForwardListInternal.h:
1319 * WebCoreSupport/WebFrameLoaderClient.mm:
1320 (WebFrameLoaderClient::canCachePage):
1321 * WebView/WebFrameView.mm:
1322 (-[WebFrameView keyDown:keyDown:]):
1323 * WebView/WebView.mm:
1324 (-[WebView _loadBackForwardListFromOtherView:]):
1325 (-[WebView initWithCoder:]):
1326 (-[WebView encodeWithCoder:]):
1327 (-[WebView backForwardList]):
1328 (-[WebView setMaintainsBackForwardList:]):
1330 2014-04-29 Sam Weinig <sam@webkit.org>
1332 [iOS] -[WebHTMLView selectionImageForcingBlackText:] returns blank image on iOS
1333 https://bugs.webkit.org/show_bug.cgi?id=132359
1335 Reviewed by Darin Adler.
1337 * WebView/WebHTMLView.mm:
1340 (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
1341 Bring back the old FrameSnapshottingMac code for drawing the selection image as drag code for this
1342 is still unimplemented on iOS.
1344 * WebView/WebView.mm:
1345 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1346 Set the page scale for "simple HTML documents" (this is already done for the all other documents),
1347 to ensure that the snapshot is the correct size.
1349 2014-04-30 Manuel Rego Casasnovas <rego@igalia.com>
1351 [CSS Grid Layout] Enable runtime feature by default
1352 https://bugs.webkit.org/show_bug.cgi?id=132189
1354 Reviewed by Benjamin Poulain.
1356 * WebView/WebPreferences.mm:
1357 (+[WebPreferences initialize]): Remove unneeded changes that
1358 enable/disable the runtime feature depending on the compilation flag.
1359 And set it to true by default.
1361 2014-04-29 Filip Pizlo <fpizlo@apple.com>
1363 Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
1364 https://bugs.webkit.org/show_bug.cgi?id=112840
1366 Rubber stamped by Geoffrey Garen.
1368 * Configurations/FeatureDefines.xcconfig:
1370 2014-04-29 Brady Eidson <beidson@apple.com>
1372 Change Image Controls replacement to use selection and paste
1373 <rdar://problem/16302722> and https://bugs.webkit.org/show_bug.cgi?id=131992
1375 Reviewed by Tim Horton.
1377 * Misc/WebSharingServicePickerController.mm:
1378 (-[WebSharingServicePickerController sharingService:didShareItems:]): Write the
1379 replacement data to a special pasteboard, then replace the current selection from
1382 2014-04-27 Sam Weinig <sam@webkit.org>
1384 [iOS WebKit2] Add support for text autosizing
1385 <rdar://problem/16545245>
1386 https://bugs.webkit.org/show_bug.cgi?id=132237
1388 Reviewed by Tim Horton.
1390 * WebView/WebFrame.mm:
1391 (-[WebFrame _setTextAutosizingWidth:]):
1392 Forward setting of the text autosizing width to the Page.
1394 2014-04-25 Dean Jackson <dino@apple.com>
1396 Allow a platform-specific size enumeration to be passed into popup-menu display
1397 https://bugs.webkit.org/show_bug.cgi?id=132195
1399 Reviewed by Brent Fulgham. With some in-person review comments from Sam Weinig.
1401 Platforms like OS X use a set of predefined sizes for built-in controls
1402 used for <select>: normal, small and mini. Expose that information to
1403 the PopupMenuClient via the PopupMenuStyle, allowing it to be passed
1404 into the platform code in WebKitSystemInterface.
1406 * WebCoreSupport/PopupMenuMac.mm:
1407 (PopupMenuMac::show): Convert the WebCore menu size type into the
1408 WebCoreSystemInterface type.
1410 2014-04-24 Commit Queue <commit-queue@webkit.org>
1412 Unreviewed, rolling out r167700.
1413 https://bugs.webkit.org/show_bug.cgi?id=132142
1415 Incorrectly reverted the change in r167547 for
1416 webkit.org/b/131898 (Requested by rniwa on #webkit).
1420 "Cursor doesn't change back to pointer when leaving the Safari
1422 https://bugs.webkit.org/show_bug.cgi?id=132038
1423 http://trac.webkit.org/changeset/167700
1425 2014-04-24 Brady Eidson <beidson@apple.com>
1427 Rename "IMAGE_CONTROLS" feature to "SERVICE_CONTROLS"
1428 https://bugs.webkit.org/show_bug.cgi?id=132155
1430 Reviewed by Tim Horton.
1432 * Configurations/FeatureDefines.xcconfig:
1433 * Misc/WebSharingServicePickerController.h:
1434 * Misc/WebSharingServicePickerController.mm:
1435 * WebCoreSupport/WebContextMenuClient.h:
1436 * WebCoreSupport/WebContextMenuClient.mm:
1437 (WebContextMenuClient::contextMenuForEvent):
1438 * WebView/WebPreferences.mm:
1439 (+[WebPreferences initialize]):
1440 * WebView/WebView.mm:
1441 (-[WebView _preferencesChanged:]):
1443 2014-04-24 Ryosuke Niwa <rniwa@webkit.org>
1445 Text caret disappears in Mail after returning from another application
1446 https://bugs.webkit.org/show_bug.cgi?id=132111
1448 Reviewed by Darin Adler.
1450 The bug was caused by our SPI _windowChangedKeyState not getting called upon deminiaturization.
1452 Fixed the bug by using the standard NSWindowDidBecomeKeyNotification and NSWindowDidResignKeyNotification
1453 notifications as done in WebKit2 since they DO get called upon deminiaturization.
1455 * WebView/WebView.mm:
1456 (-[WebView addWindowObserversForWindow:]):
1457 (-[WebView removeWindowObservers]):
1458 (-[WebView _windowKeyStateChanged:]):
1459 (-[WebView _windowChangedKeyState]): Deleted.
1461 2014-04-24 Myles C. Maxfield <mmaxfield@apple.com>
1463 FontCache::fontCache() never returns nullptr so it can be made to return a reference instead
1464 https://bugs.webkit.org/show_bug.cgi?id=132110
1466 Reviewed by Tim Horton.
1468 Updates callers to use '.' instead of '->'.
1470 No new tests are necessary because there should be no behavior change.
1472 * Misc/WebCoreStatistics.mm:
1473 (+[WebCoreStatistics cachedFontDataCount]):
1474 (+[WebCoreStatistics cachedFontDataInactiveCount]):
1475 (+[WebCoreStatistics purgeInactiveFontData]):
1476 * WebView/WebView.mm:
1477 (+[WebView purgeInactiveFontData]):
1479 2014-04-24 Eric Carlson <eric.carlson@apple.com>
1481 [iOS] Manage AudioSession category according to media type
1482 https://bugs.webkit.org/show_bug.cgi?id=132096
1484 Reviewed by Jer Noble.
1486 * WebView/WebView.mm:
1487 (-[WebView _commonInitializationWithFrameName:groupName:]): Tell
1488 WebCore to manage the AudioSession when running in MobileSafari.
1490 2014-04-23 Andreas Kling <akling@apple.com>
1492 Remove Apple Dictionary workaround in WebFrameLoaderClient.
1493 <https://webkit.org/b/132095>
1495 Kill a hack to work around a WK1 client bug that got fixed years ago.
1496 See <rdar://problem/6471058> for backstory.
1498 Reviewed by Darin Adler.
1500 * WebCoreSupport/WebFrameLoaderClient.mm:
1501 (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1502 (WebFrameLoaderClient::dispatchWillSendRequest):
1503 (applyAppleDictionaryApplicationQuirkNonInlinePart): Deleted.
1504 (applyAppleDictionaryApplicationQuirk): Deleted.
1506 2014-04-23 Anders Carlsson <andersca@apple.com>
1508 Don't migrate the WKView.h header from WebCore to WebKit
1509 https://bugs.webkit.org/show_bug.cgi?id=132086
1511 Reviewed by Dan Bernstein.
1513 * MigrateHeaders.make:
1514 Remove WKView.h from the list of headers to migrate.
1516 * WebView/WebView.mm:
1519 2014-04-22 Ryosuke Niwa <rniwa@webkit.org>
1521 Cursor doesn't change back to pointer when leaving the Safari window
1522 https://bugs.webkit.org/show_bug.cgi?id=132038
1524 Reviewed by Alexey Proskuryakov.
1526 Since the cursor type is now updated asynchronously after r147739,
1527 [window windowNumber] != [NSWindow windowNumberAtPoint:[NSEvent mouseLocation] belowWindowWithWindowNumber:0]
1528 evalutes to false depending on how fast cursor is moving.
1530 Instead, check whether the NSWindow of the WebView is the key window or not since
1531 key window appears to control the cursor style in Cocoa as far as I've tested:
1532 https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/WinPanel/Concepts/ChangingMainKeyWindow.html
1534 * WebCoreSupport/WebChromeClient.mm:
1535 (WebChromeClient::setCursor):
1537 2014-04-22 Commit Queue <commit-queue@webkit.org>
1539 Unreviewed, rolling out r167674.
1540 https://bugs.webkit.org/show_bug.cgi?id=132025
1542 Going a different way with this (Requested by bradee-oh on
1547 "Change Image Controls replacement to use selection and paste"
1548 https://bugs.webkit.org/show_bug.cgi?id=131992
1549 http://trac.webkit.org/changeset/167674
1551 2014-04-22 Brady Eidson <beidson@apple.com>
1553 Change Image Controls replacement to use selection and paste
1554 <rdar://problem/16302722> and https://bugs.webkit.org/show_bug.cgi?id=131992
1556 Reviewed by Tim Horton.
1558 * Misc/WebSharingServicePickerController.mm:
1559 (-[WebSharingServicePickerController sharingService:didShareItems:]): Write the
1560 replacement data to a special pasteboard, then replace the current selection from
1563 2014-04-21 Eric Carlson <eric.carlson@apple.com>
1565 [Mac] implement WebKitDataCue
1566 https://bugs.webkit.org/show_bug.cgi?id=131799
1568 Reviewed by Dean Jackson.
1570 * Configurations/FeatureDefines.xcconfig: Define ENABLE_DATACUE_VALUE.
1572 2014-04-21 Joseph Pecoraro <pecoraro@apple.com>
1574 Remove unused WebKitSystemInterface functions
1575 https://bugs.webkit.org/show_bug.cgi?id=131938
1577 Reviewed by Alexey Proskuryakov.
1579 * WebCoreSupport/WebSystemInterface.mm:
1580 (InitWebCoreSystemInterface):
1582 2014-04-21 Zan Dobersek <zdobersek@igalia.com>
1584 Move cross-port Source/WebCore/page/ code to std::unique_ptr
1585 https://bugs.webkit.org/show_bug.cgi?id=130534
1587 Reviewed by Darin Adler.
1589 * WebView/WebHTMLRepresentation.mm:
1590 (searchForLabelsBeforeElement): Pass a RegExp reference to Frame::searchForLabelsAboveCell().
1592 2014-04-19 Darin Adler <darin@apple.com>
1594 [Mac] WebView adjusts the cursor even when another window is in front
1595 https://bugs.webkit.org/show_bug.cgi?id=131898
1596 rdar://problem/14619911
1598 Reviewed by Dan Bernstein.
1600 * WebCoreSupport/WebChromeClient.mm:
1601 (WebChromeClient::setCursor): Added a check that the window is under the cursor
1602 and do nothing if it's not.
1604 2014-04-18 Commit Queue <commit-queue@webkit.org>
1606 Unreviewed, rolling out r167527.
1607 https://bugs.webkit.org/show_bug.cgi?id=131883
1609 Broke 32-bit build (Requested by ap on #webkit).
1613 "[Mac] implement WebKitDataCue"
1614 https://bugs.webkit.org/show_bug.cgi?id=131799
1615 http://trac.webkit.org/changeset/167527
1617 2014-04-18 Eric Carlson <eric.carlson@apple.com>
1619 [Mac] implement WebKitDataCue
1620 https://bugs.webkit.org/show_bug.cgi?id=131799
1622 Reviewed by Dean Jackson.
1624 * Configurations/FeatureDefines.xcconfig: Define ENABLE_DATACUE_VALUE.
1626 2014-04-17 Daniel Bates <dabates@apple.com>
1628 [iOS] Hook up screen.{availHeight, availWidth, height, width}
1629 https://bugs.webkit.org/show_bug.cgi?id=131821
1630 <rdar://problem/16413795>
1632 Reviewed by Benjamin Poulain and Tim Horton.
1634 Add declaration for WKGetViewportAvailableScreenSize() to return the available screen size.
1636 Additionally substitute "ScreenSize" for "ViewportScreenSize" to make the code more understandable.
1638 * WebCoreSupport/WebSystemInterface.mm:
1639 (InitWebCoreSystemInterface):
1641 2014-04-17 Darin Adler <darin@apple.com>
1643 Add separate flag for IndexedDatabase in workers since the current implementation is not threadsafe
1644 https://bugs.webkit.org/show_bug.cgi?id=131785
1645 rdar://problem/16003108
1647 Reviewed by Brady Eidson.
1649 * Configurations/FeatureDefines.xcconfig: Added INDEXED_DATABASE_IN_WORKERS.
1651 2014-04-16 Tim Horton <timothy_horton@apple.com>
1653 Images dragged from WebKit1 on 2x displays are too big
1654 https://bugs.webkit.org/show_bug.cgi?id=131775
1655 <rdar://problem/15933525>
1657 Reviewed by Simon Fraser.
1659 * WebCoreSupport/WebDragClient.mm:
1660 (WebDragClient::startDrag):
1661 Scale the drag image's logical size down by the device scale factor
1662 in WebKit1 just like we do in WebKit2.
1664 2014-04-13 Andy Estes <aestes@apple.com>
1666 [QuickLook] Move file system-related code into WebKit
1667 https://bugs.webkit.org/show_bug.cgi?id=131597
1669 Reviewed by Dan Bernstein.
1671 Moved file system and WebKit1-only code from QuickLookHandle into a new
1672 QuickLookHandleClient subclass.
1674 * WebCoreSupport/WebFrameLoaderClient.h:
1675 * WebCoreSupport/WebFrameLoaderClient.mm:
1677 2014-04-09 Alexey Proskuryakov <ap@apple.com>
1679 Eliminate DragSession structure
1680 https://bugs.webkit.org/show_bug.cgi?id=131465
1682 Reviewed by Benjamin Poulain.
1684 * WebView/WebView.mm:
1685 (-[WebView draggingEntered:]):
1686 (-[WebView draggingUpdated:]):
1688 2014-04-09 Alexey Proskuryakov <ap@apple.com>
1690 Rename some dragging functions
1691 https://bugs.webkit.org/show_bug.cgi?id=131460
1693 Reviewed by Tim Horton.
1695 Renamed performDrag to performDragOperation.
1697 * WebView/WebView.mm: (-[WebView performDragOperation:]):
1699 2014-04-08 Jon Lee <jonlee@apple.com>
1701 Turn MSE on by default
1702 https://bugs.webkit.org/show_bug.cgi?id=131313
1703 <rdar://problem/16525223>
1705 Reviewed by Jer Noble.
1707 * Configurations/FeatureDefines.xcconfig:
1708 * WebView/WebPreferences.mm:
1709 (+[WebPreferences initialize]): Set default to true.
1711 2014-04-08 Alexey Proskuryakov <ap@apple.com>
1713 Rename Clipboard to DataTransfer
1714 https://bugs.webkit.org/show_bug.cgi?id=131371
1716 Reviewed by Anders Carlsson.
1718 * WebCoreSupport/WebDragClient.h:
1719 * WebCoreSupport/WebDragClient.mm:
1720 (WebDragClient::willPerformDragSourceAction):
1721 (WebDragClient::startDrag):
1722 * WebView/WebPDFView.mm:
1724 2014-04-08 Dan Bernstein <mitz@apple.com>
1726 WebKit part of [Cocoa] Add WKFormDelegate
1727 https://bugs.webkit.org/show_bug.cgi?id=131343
1729 Reviewed by Anders Carlsson.
1731 * MigrateHeaders.make: Added new WebKit2 headers to WEBKIT2_HEADERS.
1733 2014-04-08 Daniel Bates <dabates@apple.com>
1735 Fallback to default storage session when there isn't a valid session ID
1736 https://bugs.webkit.org/show_bug.cgi?id=131326
1737 <rdar://problem/16231679>
1739 Reviewed by Alexey Proskuryakov.
1741 Fixes and issue where we may use the wrong storage session after disabling
1742 a private browsing session.
1744 Currently WebKit1 and WebKit2 without NetworkProcess assume that there
1745 is always a non-null private browsing storage session so long as the page
1746 has a non-default session ID. Instead we should only use the private browsing
1747 storage session when it's non-null and the page has a non-default session ID;
1748 otherwise, we should use the default storage session. This change will make
1749 the behavior in WebKit1 and WebKit2 without NetworkProcess consistent with
1750 the behavior in WebKit2 with NetworkProcess.
1752 * WebCoreSupport/WebFrameNetworkingContext.mm:
1753 (WebFrameNetworkingContext::storageSession):
1755 2014-04-06 Sam Weinig <sam@webkit.org>
1757 Document user content related APIs
1759 Reviewed by Anders Carlsson.
1761 * MigrateHeaders.make:
1763 2014-04-06 Darin Adler <darin@apple.com>
1765 Refactor post-attach and HTMLObjectElement-related code
1766 https://bugs.webkit.org/show_bug.cgi?id=131282
1768 Reviewed by Antti Koivisto.
1770 * WebCoreSupport/WebFrameLoaderClient.mm: Call toHTMLPlugInImageElement instead of
1771 doing a static_cast.
1773 2014-04-04 Brian J. Burg <burg@cs.washington.edu>
1775 Enable WEB_REPLAY for PLATFORM(MAC)
1776 https://bugs.webkit.org/show_bug.cgi?id=130700
1778 Reviewed by Timothy Hatcher.
1780 * Configurations/FeatureDefines.xcconfig:
1782 2014-04-03 Sam Weinig <sam@webkit.org>
1784 [WebKit2] Promote user script SPI to API
1785 https://bugs.webkit.org/show_bug.cgi?id=131181
1787 Reviewed by Anders Carlsson.
1789 * MigrateHeaders.make:
1791 2014-04-02 Benjamin Poulain <bpoulain@apple.com>
1793 [iOS] Remove the legacy string drawing code
1794 https://bugs.webkit.org/show_bug.cgi?id=131088
1796 Reviewed by Sam Weinig.
1798 * Configurations/WebKit.xcconfig:
1800 2014-04-02 Mark Rowe <mrowe@apple.com>
1802 <https://webkit.org/b/131135> Introduce LockHistory and LockBackForwardList enums to use in place of bools.
1804 These arguments are often passed using literals at the call site, where the use of bools severely hinders
1805 the readability of the code.
1807 Reviewed by Andreas Kling.
1809 * WebView/WebPDFView.mm:
1810 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1812 2014-04-02 Stephanie Lewis <slewis@apple.com>
1814 Roll out http://trac.webkit.org/changeset/166144
1815 <rdar://problem/16481284> PLT stops loading on news.google.com
1819 Rollout 166144 since it prevents the PLT from completing.
1821 * WebCoreSupport/WebFrameLoaderClient.mm:
1823 2014-04-02 Daniel Bates <dabates@apple.com>
1825 Remove Settings::maximumDecodedImageSize()
1826 https://bugs.webkit.org/show_bug.cgi?id=131057
1827 <rdar://problem/15626368>
1829 Reviewed by Darin Adler.
1831 Remove preferences key WebKitMaximumImageSize.
1833 * WebView/WebPreferenceKeysPrivate.h:
1834 * WebView/WebPreferences.mm:
1835 (+[WebPreferences initialize]):
1836 (-[WebPreferences _maximumImageSize:]): Deleted.
1837 * WebView/WebPreferencesPrivate.h:
1838 * WebView/WebView.mm:
1839 (-[WebView _preferencesChanged:]):
1841 2014-04-02 Martin Hock <mhock@apple.com>
1843 Unify private browsing with sessions.
1844 https://bugs.webkit.org/show_bug.cgi?id=130099
1846 Reviewed by Alexey Proskuryakov.
1848 * WebCoreSupport/WebFrameLoaderClient.mm: Change WebCore::Settings::privateBrowsingEnabled() to Page::sessionID().isEphemeral().
1849 (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
1850 * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
1851 (WebFrameNetworkingContext::storageSession):
1852 * WebView/WebView.mm: Change WebCore::Settings::setPrivateBrowsingEnabled() to Page::enableLegacyPrivateBrowsing().
1853 (-[WebView _preferencesChanged:]):
1855 2014-04-01 Anders Carlsson <andersca@apple.com>
1857 Migrate more headers
1858 https://bugs.webkit.org/show_bug.cgi?id=131068
1860 Reviewed by Tim Horton.
1862 * MigrateHeaders.make:
1864 2014-04-01 Manuel Rego Casasnovas <rego@igalia.com>
1866 [CSS Grid Layout] Enable runtime feature if feature flag is enabled
1867 https://bugs.webkit.org/show_bug.cgi?id=130013
1869 Reviewed by Simon Fraser.
1871 Enable CSS Grid Layout runtime feature when ENABLE_CSS_GRID_LAYOUT flag is true.
1873 * WebView/WebPreferences.mm:
1874 (+[WebPreferences initialize]):
1876 2014-03-31 Simon Fraser <simon.fraser@apple.com>
1878 Enable WEB_TIMING on Mac and iOS
1879 https://bugs.webkit.org/show_bug.cgi?id=128064
1881 Reviewed by Sam Weinig, Brent Fulgham.
1885 * Configurations/FeatureDefines.xcconfig:
1887 2014-03-31 Dean Jackson <dino@apple.com>
1889 Remove WEB_ANIMATIONS
1890 https://bugs.webkit.org/show_bug.cgi?id=130989
1892 Reviewed by Simon Fraser.
1894 Remove this feature flag until we plan to implement.
1896 * Configurations/FeatureDefines.xcconfig:
1898 2014-03-31 Antti Koivisto <antti@apple.com>
1900 Rename TileCache to LegacyTileCache
1901 https://bugs.webkit.org/show_bug.cgi?id=130986
1903 Reviewed by Simon Fraser.
1905 * WebView/WebView.mm:
1906 (+[WebView drainLayerPool]):
1907 (+[WebView _setTileCacheLayerPoolCapacity:]):
1909 2014-03-28 Darin Adler <darin@apple.com>
1911 Fix recently-introduced off-by-one error in centerTruncateToBuffer
1912 https://bugs.webkit.org/show_bug.cgi?id=130889
1914 Reviewed by Alexey Proskuryakov.
1916 * Misc/WebStringTruncator.mm:
1917 (defaultMenuFont): Changed to use NeverDestroyed since I had to touch this file anyway.
1918 (fontFromNSFont): Ditto. Also improved variable names a bit.
1919 (+[WebStringTruncator initialize]): Added threading initialization, needed for main
1920 thread assertions in string truncator code.
1922 2014-03-27 Commit Queue <commit-queue@webkit.org>
1924 Unreviewed, rolling out r166360.
1925 https://bugs.webkit.org/show_bug.cgi?id=130869
1927 Seems to have broken PLT (Requested by ap on #webkit).
1931 "Connection::dispatchOneMessage() can be re-entered while
1932 handling Cmd-key menu"
1933 https://bugs.webkit.org/show_bug.cgi?id=130767
1934 http://trac.webkit.org/changeset/166360
1936 2014-03-27 Alexey Proskuryakov <ap@apple.com>
1938 Connection::dispatchOneMessage() can be re-entered while handling Cmd-key menu
1939 equivalents, ASSERT(!_data->_keyDownEventBeingResent)
1940 https://bugs.webkit.org/show_bug.cgi?id=130767
1941 <rdar://problem/16307487>
1943 Reviewed by Darin Adler.
1945 Switched to a WebCore wrapper for RunLoop::initializeMainRunLoop that adds
1946 NSModalPanelRunLoopMode to RunLoop event source and timer modes.
1948 * Carbon/CarbonWindowAdapter.mm: (+[CarbonWindowAdapter initialize]):
1949 * History/WebBackForwardList.mm: (+[WebBackForwardList initialize]):
1950 * History/WebHistoryItem.mm: (+[WebHistoryItem initialize]):
1951 * Misc/WebCache.mm: (+[WebCache initialize]):
1952 * Misc/WebElementDictionary.mm: (+[WebElementDictionary initialize]):
1953 * Misc/WebIconDatabase.mm: (+[WebIconDatabase initialize]):
1954 * Plugins/Hosted/WebHostedNetscapePluginView.mm: (+[WebHostedNetscapePluginView initialize]):
1955 * Plugins/WebBaseNetscapePluginView.mm:
1956 * Plugins/WebBasePluginPackage.mm:
1957 * Plugins/WebNetscapePluginView.mm: (+[WebNetscapePluginView initialize]):
1958 * WebCoreSupport/WebEditorClient.mm: (+[WebUndoStep initialize]):
1959 * WebCoreSupport/WebFrameLoaderClient.mm:
1960 * WebView/WebArchive.mm: (+[WebArchivePrivate initialize]):
1961 * WebView/WebDataSource.mm: (+[WebDataSource initialize]):
1962 * WebView/WebHTMLView.mm:
1963 (+[WebHTMLViewPrivate initialize]):
1964 (+[WebHTMLView initialize]):
1965 * WebView/WebPreferences.mm: (+[WebPreferences initialize]):
1966 * WebView/WebResource.mm: (+[WebResourcePrivate initialize]):
1967 * WebView/WebTextIterator.mm: (+[WebTextIteratorPrivate initialize]):
1968 * WebView/WebView.mm: (+[WebView initialize]):
1969 * WebView/WebViewData.mm: (+[WebViewPrivate initialize]):
1971 2014-03-26 Timothy Hatcher <timothy@apple.com>
1973 Propagate the hiddenFromInspector flag on ResourceRequest in
1974 places when a new request a made or passed between processes.
1976 https://bugs.webkit.org/show_bug.cgi?id=130741
1978 Reviewed by Joseph Pecoraro.
1980 * WebCoreSupport/WebFrameLoaderClient.mm:
1981 (WebFrameLoaderClient::dispatchWillSendRequest): Copy hiddenFromInspector to
1984 2014-03-26 Zoltan Horvath <zoltan@webkit.org>
1986 [CSS Shapes] Remove shape-inside support
1987 https://bugs.webkit.org/show_bug.cgi?id=130698
1989 Reviewed by David Hyatt.
1991 * Configurations/FeatureDefines.xcconfig:
1993 2014-03-25 Joseph Pecoraro <pecoraro@apple.com>
1995 [iOS] Inspector View Indication Support
1996 https://bugs.webkit.org/show_bug.cgi?id=130709
1998 Reviewed by Simon Fraser.
2000 * WebCoreSupport/WebInspectorClient.h:
2001 * WebCoreSupport/WebInspectorClient.mm:
2002 (WebInspectorClient::didSetSearchingForNode): Deleted.
2003 (WebInspectorClient::releaseFrontend): Deleted.
2004 * WebView/WebView.mm:
2005 (-[WebView setShowingInspectorIndication:]):
2006 * WebView/WebViewPrivate.h:
2009 2014-03-24 Brent Fulgham <bfulgham@apple.com>
2011 Activate WebVTT Tests Once Merging is Complete
2012 https://bugs.webkit.org/show_bug.cgi?id=130420
2014 Reviewed by Eric Carlson.
2016 * Configurations/FeatureDefines.xcconfig: Turn on ENABLE(WEBVTT_REGIONS)
2018 2014-03-24 Andy Estes <aestes@apple.com>
2020 [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
2021 https://bugs.webkit.org/show_bug.cgi?id=129322
2023 Reviewed by Anders Carlsson.
2025 * WebCoreSupport/WebFrameLoaderClient.mm:
2026 (WebFrameLoaderClient::convertMainResourceLoadToDownload): Use the
2027 RetainPtr returned by releaseConnectionForDownload() rather than
2030 2014-03-24 Jon Lee <jonlee@apple.com>
2036 * WebInspector/WebNodeHighlightView.mm: Missing include to GeometryUtilities.
2038 2014-03-23 Sam Weinig <sam@webkit.org>
2040 Remove some unnecessary .get()s that Darin noticed.
2042 * WebView/WebHTMLRepresentation.mm:
2043 (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
2044 * WebView/WebHTMLView.mm:
2045 (-[WebHTMLView attributedString]):
2047 2014-03-23 Sam Weinig <sam@webkit.org>
2049 Simplify the HTMLConverter interface (Part 2)
2050 https://bugs.webkit.org/show_bug.cgi?id=130654
2052 Reviewed by Darin Adler.
2054 * WebView/WebHTMLRepresentation.mm:
2055 (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
2056 * WebView/WebHTMLView.mm:
2057 (-[WebHTMLView attributedSubstringFromRange:]):
2058 (-[WebHTMLView attributedString]):
2059 (-[WebHTMLView selectedAttributedString]):
2061 2014-03-23 Darin Adler <darin@apple.com>
2063 Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
2064 https://bugs.webkit.org/show_bug.cgi?id=130653
2066 Reviewed by Antti Koivisto.
2068 * WebCoreSupport/WebFrameLoaderClient.mm: Call toHTMLPlugInImageElement instead of
2069 doing a static_cast.
2071 2014-03-21 Simon Fraser <simon.fraser@apple.com>
2073 Don't flush compositing layers within FrameView::willPaintContents()
2074 https://bugs.webkit.org/show_bug.cgi?id=130627
2076 Reviewed by Sam Weinig.
2078 Make _flushCompositingChanges private so DRT can call it;
2079 moved it into the Private category.
2081 * WebView/WebView.mm:
2082 (-[WebView _flushCompositingChanges]):
2083 * WebView/WebViewPrivate.h:
2085 2014-03-21 Simon Fraser <simon.fraser@apple.com>
2087 Remove duplicate line added during merging
2088 https://bugs.webkit.org/show_bug.cgi?id=130623
2090 Reviewed by Beth Dakin.
2092 Remove a duplicate call to -_viewWillDrawInternal which
2093 was added during merges.
2095 * WebView/WebView.mm:
2096 (LayerFlushController::flushLayers):
2098 2014-03-21 Darin Adler <darin@apple.com>
2100 Improve idiom used for string building in a few places
2101 https://bugs.webkit.org/show_bug.cgi?id=130561
2103 Reviewed by Andreas Kling.
2105 * WebView/WebHTMLRepresentation.mm:
2106 (regExpForLabels): Use StringBuilder.
2108 2014-03-21 Darin Adler <darin@apple.com>
2110 Add a combined decodeAndFlush to TextResourceDecoder
2111 https://bugs.webkit.org/show_bug.cgi?id=130560
2113 Reviewed by Andreas Kling.
2115 * WebView/WebView.mm:
2116 (+[WebView _decodeData:]): Use decodeAndFlush.
2118 2014-03-20 Anders Carlsson <andersca@apple.com>
2122 * MigrateHeaders.make:
2124 2014-03-20 Pratik Solanki <psolanki@apple.com>
2126 [iOS] Get code to compile on older iOS versions
2127 https://bugs.webkit.org/show_bug.cgi?id=130142
2128 <rdar://problem/16302908>
2130 Reviewed by Darin Adler.
2132 * History/WebHistory.mm:
2134 * Plugins/WebPluginController.h:
2135 * Plugins/WebPluginController.mm:
2136 (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2137 * WebCoreSupport/WebFrameLoaderClient.mm:
2139 * WebView/WebPreferences.mm:
2140 (-[WebPreferences _setAllowCompositingLayerVisualDegradation:]):
2141 * WebView/WebPreferencesPrivate.h:
2143 2014-03-20 Lucas Forschler <lforschler@apple.com>
2145 Rollout r165944. Build break.
2147 2014-03-19 Pratik Solanki <psolanki@apple.com>
2149 [iOS] Get code to compile on older iOS versions
2150 https://bugs.webkit.org/show_bug.cgi?id=130142
2151 <rdar://problem/16302908>
2153 Reviewed by Darin Adler.
2155 * History/WebHistory.mm:
2157 * Plugins/WebPluginController.h:
2158 * Plugins/WebPluginController.mm:
2159 (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2160 * WebCoreSupport/WebFrameLoaderClient.mm:
2162 * WebView/WebPreferences.mm:
2163 (-[WebPreferences _setAllowCompositingLayerVisualDegradation:]):
2164 * WebView/WebPreferencesPrivate.h:
2166 2014-03-19 Jer Noble <jer.noble@apple.com>
2168 [Mac][EME] Query whether decoder support exists before creating a new MediaKeys object.
2169 https://bugs.webkit.org/show_bug.cgi?id=130459
2171 Reviewed by Eric Carlson.
2173 * WebCoreSupport/WebSystemInterface.mm:
2174 (InitWebCoreSystemInterface): Initialize the new WCSI method.
2176 2014-03-19 Brady Eidson <beidson@apple.com>
2178 Filter out editable services from image menu for non-contenteditable images
2179 <rdar://problem/16319645> and https://bugs.webkit.org/show_bug.cgi?id=130437
2181 Reviewed by Tim Horton.
2183 * Misc/WebSharingServicePickerController.h:
2184 * Misc/WebSharingServicePickerController.mm:
2185 (-[WebSharingServicePickerController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
2186 Filter out editing services based on the includeEditorServices flag.
2187 * WebCoreSupport/WebContextMenuClient.mm:
2188 (WebContextMenuClient::contextMenuForEvent):
2190 2014-03-19 Jer Noble <jer.noble@apple.com>
2192 [iOS] Disable the video plugin proxy by default on WK1.
2193 https://bugs.webkit.org/show_bug.cgi?id=130460
2195 Reviewed by Eric Carlson.
2197 Update the defaults to universally enable the AVFoundationEnabled preference, disable the
2198 VideoPluginProxyEnabled preference, and on iOS only enable the AVKitEnabled preference.
2200 * WebView/WebPreferences.mm:
2201 (+[WebPreferences initialize]):
2203 2014-03-18 Samuel White <samuel_white@apple.com>
2205 AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
2206 https://bugs.webkit.org/show_bug.cgi?id=130250
2208 Reviewed by Chris Fleizach.
2210 Added ability to toggle enhanced accessibility on and off to support tests that require it.
2212 * WebView/WebFrame.mm:
2213 (-[WebFrame enhancedAccessibilityEnabled]):
2214 (-[WebFrame setEnhancedAccessibility:]):
2215 * WebView/WebFramePrivate.h:
2217 2014-03-17 Filip Pizlo <fpizlo@apple.com>
2221 Rubber stamped by Dan Bernstein.
2223 * Configurations/FeatureDefines.xcconfig:
2225 2014-03-17 Andy Estes <aestes@apple.com>
2227 Remove staging code added for <http://webkit.org/b/129358> [iOS] Support network state notification using CPNetworkObserver
2229 Reviewed by Enrica Casucci.
2231 * WebView/WebView.mm:
2233 2014-03-17 Anders Carlsson <andersca@apple.com>
2235 WebKitLegacy headers should #import the relevant WebKit headers
2236 https://bugs.webkit.org/show_bug.cgi?id=130372
2237 <rdar://problem/16349094>
2239 Reviewed by Dan Bernstein.
2241 Create forwarding headers instead.
2243 * WebKitLegacy/MigrateHeadersToLegacy.make:
2245 2014-03-17 Tim Horton <timothy_horton@apple.com>
2247 Rename WKThumbnailView to _WKThumbnailView
2248 https://bugs.webkit.org/show_bug.cgi?id=130361
2250 Reviewed by Anders Carlsson.
2252 * MigrateHeaders.make:
2254 2014-03-17 David Farler <dfarler@apple.com>
2256 REGRESSION: WebKitLegacy causes ASan build to fail
2257 <rdar://problem/16344326>
2259 Reviewed by David Kilzer.
2261 * Configurations/DebugRelease.xcconfig: Remove $(inherited) from
2262 OTHER_CFLAGS, OTHER_CPLUSPLUSFLAGS, OTHER_LDFLAGS to prevent
2263 double complete ASAN flags.
2265 2014-03-16 Brent Fulgham <bfulgham@apple.com>
2267 Provide preference to enable additional AVFoundation options
2268 https://bugs.webkit.org/show_bug.cgi?id=130275
2270 Reviewed by Eric Carlson.
2272 * WebView/WebPreferenceKeysPrivate.h: Added new preference.
2273 * WebView/WebPreferences.mm:
2274 (+[WebPreferences initialize]): Initialize preference to false.
2275 (-[WebPreferences isInheritURIQueryComponentEnabled]): Added.
2276 (-[WebPreferences setEnableInheritURIQueryComponent:]): Added.
2277 * WebView/WebPreferencesPrivate.h:
2278 * WebView/WebView.mm:
2279 (-[WebView _preferencesChanged:]): Handle new preference.
2281 2014-03-16 Darin Adler <darin@apple.com>
2283 Remove all deprecatedCharacters use from WebKit directory
2284 https://bugs.webkit.org/show_bug.cgi?id=130305
2286 Reviewed by Andreas Kling.
2288 * History/BinaryPropertyList.cpp:
2289 (BinaryPropertyListSerializer::appendStringObject): Use operator[]
2290 instead of deprecatedCharacters.
2292 2014-03-14 Mark Rowe <mrowe@apple.com>
2294 Fix the production build.
2296 Don't rely on USE_INTERNAL_SDK being set for the Production configuration since UseInternalSDK.xcconfig won't
2297 be at the expected relative path when working from installed source.
2299 * Configurations/Base.xcconfig:
2301 2014-03-14 Maciej Stachowiak <mjs@apple.com>
2303 Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
2304 https://bugs.webkit.org/show_bug.cgi?id=130276
2305 <rdar://problem/16266927>
2307 Reviewed by Simon Fraser.
2309 * Carbon/CarbonUtils.h:
2310 * Carbon/CarbonUtils.m:
2311 * Carbon/CarbonWindowAdapter.h:
2312 * Carbon/CarbonWindowAdapter.mm:
2313 * Carbon/CarbonWindowContentView.h:
2314 * Carbon/CarbonWindowContentView.m:
2315 * Carbon/CarbonWindowFrame.h:
2316 * Carbon/CarbonWindowFrame.m:
2317 * Carbon/HIViewAdapter.h:
2318 * Carbon/HIViewAdapter.m:
2319 * Carbon/HIWebView.h:
2320 * Carbon/HIWebView.mm:
2321 * DOM/WebDOMOperations.h:
2322 * DOM/WebDOMOperations.mm:
2323 * DOM/WebDOMOperationsInternal.h:
2324 * DOM/WebDOMOperationsPrivate.h:
2325 * DefaultDelegates/WebDefaultContextMenuDelegate.h:
2326 * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2327 * DefaultDelegates/WebDefaultEditingDelegate.h:
2328 * DefaultDelegates/WebDefaultEditingDelegate.m:
2329 * DefaultDelegates/WebDefaultPolicyDelegate.h:
2330 * DefaultDelegates/WebDefaultPolicyDelegate.m:
2331 * DefaultDelegates/WebDefaultUIDelegate.h:
2332 * DefaultDelegates/WebDefaultUIDelegate.m:
2333 * History/WebBackForwardList.h:
2334 * History/WebBackForwardList.mm:
2335 * History/WebBackForwardListInternal.h:
2336 * History/WebBackForwardListPrivate.h:
2337 * History/WebHistory.h:
2338 * History/WebHistory.mm:
2339 * History/WebHistoryInternal.h:
2340 * History/WebHistoryItem.h:
2341 * History/WebHistoryItem.mm:
2342 * History/WebHistoryItemInternal.h:
2343 * History/WebHistoryItemPrivate.h:
2344 * History/WebHistoryPrivate.h:
2345 * History/WebURLsWithTitles.h:
2346 * History/WebURLsWithTitles.m:
2347 * MigrateHeaders.make:
2348 * Misc/OldWebAssertions.c:
2351 * Misc/WebCoreStatistics.h:
2352 * Misc/WebCoreStatistics.mm:
2353 * Misc/WebDownload.h:
2354 * Misc/WebDownload.mm:
2355 * Misc/WebDownloadInternal.h:
2356 * Misc/WebElementDictionary.h:
2357 * Misc/WebElementDictionary.mm:
2358 * Misc/WebIconDatabase.h:
2359 * Misc/WebIconDatabase.mm:
2360 * Misc/WebIconDatabaseDelegate.h:
2361 * Misc/WebIconDatabaseInternal.h:
2362 * Misc/WebIconDatabasePrivate.h:
2364 * Misc/WebKitErrors.h:
2365 * Misc/WebKitErrors.m:
2366 * Misc/WebKitErrorsPrivate.h:
2367 * Misc/WebKitLogging.h:
2368 * Misc/WebKitLogging.m:
2369 * Misc/WebKitNSStringExtras.h:
2370 * Misc/WebKitNSStringExtras.mm:
2371 * Misc/WebKitStatistics.h:
2372 * Misc/WebKitStatistics.m:
2373 * Misc/WebKitStatisticsPrivate.h:
2374 * Misc/WebKitSystemBits.h:
2375 * Misc/WebKitSystemBits.m:
2376 * Misc/WebKitVersionChecks.h:
2377 * Misc/WebKitVersionChecks.m:
2378 * Misc/WebLocalizableStrings.h:
2379 * Misc/WebLocalizableStrings.mm:
2380 * Misc/WebNSArrayExtras.h:
2381 * Misc/WebNSArrayExtras.m:
2382 * Misc/WebNSControlExtras.h:
2383 * Misc/WebNSControlExtras.m:
2384 * Misc/WebNSDataExtras.h:
2385 * Misc/WebNSDataExtras.m:
2386 * Misc/WebNSDataExtrasPrivate.h:
2387 * Misc/WebNSDictionaryExtras.h:
2388 * Misc/WebNSDictionaryExtras.m:
2389 * Misc/WebNSEventExtras.h:
2390 * Misc/WebNSEventExtras.m:
2391 * Misc/WebNSFileManagerExtras.h:
2392 * Misc/WebNSFileManagerExtras.mm:
2393 * Misc/WebNSImageExtras.h:
2394 * Misc/WebNSImageExtras.m:
2395 * Misc/WebNSObjectExtras.h:
2396 * Misc/WebNSObjectExtras.mm:
2397 * Misc/WebNSPasteboardExtras.h:
2398 * Misc/WebNSPasteboardExtras.mm:
2399 * Misc/WebNSPrintOperationExtras.h:
2400 * Misc/WebNSPrintOperationExtras.m:
2401 * Misc/WebNSURLExtras.h:
2402 * Misc/WebNSURLExtras.mm:
2403 * Misc/WebNSURLRequestExtras.h:
2404 * Misc/WebNSURLRequestExtras.m:
2405 * Misc/WebNSUserDefaultsExtras.h:
2406 * Misc/WebNSUserDefaultsExtras.mm:
2407 * Misc/WebNSViewExtras.h:
2408 * Misc/WebNSViewExtras.m:
2409 * Misc/WebNSWindowExtras.h:
2410 * Misc/WebNSWindowExtras.m:
2411 * Misc/WebStringTruncator.h:
2412 * Misc/WebStringTruncator.mm:
2413 * Misc/WebTypesInternal.h:
2414 * Panels/WebAuthenticationPanel.h:
2415 * Panels/WebAuthenticationPanel.m:
2416 * Panels/WebPanelAuthenticationHandler.h:
2417 * Panels/WebPanelAuthenticationHandler.m:
2418 * Plugins/Hosted/ProxyRuntimeObject.h:
2419 * Plugins/Hosted/ProxyRuntimeObject.mm:
2420 * Plugins/WebBaseNetscapePluginView.h:
2421 * Plugins/WebBaseNetscapePluginView.mm:
2422 * Plugins/WebBasePluginPackage.h:
2423 * Plugins/WebBasePluginPackage.mm:
2424 * Plugins/WebJavaPlugIn.h:
2425 * Plugins/WebNetscapeContainerCheckContextInfo.h:
2426 * Plugins/WebNetscapeContainerCheckPrivate.h:
2427 * Plugins/WebNetscapeContainerCheckPrivate.mm:
2428 * Plugins/WebNetscapePluginPackage.h:
2429 * Plugins/WebNetscapePluginPackage.mm:
2430 * Plugins/WebNetscapePluginStream.h:
2431 * Plugins/WebNetscapePluginStream.mm:
2432 * Plugins/WebNetscapePluginView.h:
2433 * Plugins/WebNetscapePluginView.mm:
2434 * Plugins/WebPlugin.h:
2435 * Plugins/WebPluginContainer.h:
2436 * Plugins/WebPluginContainerCheck.h:
2437 * Plugins/WebPluginContainerCheck.mm:
2438 * Plugins/WebPluginContainerPrivate.h:
2439 * Plugins/WebPluginController.h:
2440 * Plugins/WebPluginController.mm:
2441 * Plugins/WebPluginDatabase.h:
2442 * Plugins/WebPluginDatabase.mm:
2443 * Plugins/WebPluginPackage.h:
2444 * Plugins/WebPluginPackage.mm:
2445 * Plugins/WebPluginRequest.h:
2446 * Plugins/WebPluginRequest.m:
2447 * Plugins/WebPluginViewFactory.h:
2448 * Plugins/WebPluginViewFactoryPrivate.h:
2449 * Plugins/WebPluginsPrivate.h:
2450 * Plugins/WebPluginsPrivate.m:
2452 * Storage/WebDatabaseManager.mm:
2453 * Storage/WebDatabaseManagerInternal.h:
2454 * Storage/WebDatabaseManagerPrivate.h:
2455 * WebCoreSupport/SearchPopupMenuMac.mm:
2456 * WebCoreSupport/WebAlternativeTextClient.h:
2457 * WebCoreSupport/WebAlternativeTextClient.mm:
2458 * WebCoreSupport/WebCachedFramePlatformData.h:
2459 * WebCoreSupport/WebChromeClient.h:
2460 * WebCoreSupport/WebChromeClient.mm:
2461 * WebCoreSupport/WebContextMenuClient.h:
2462 * WebCoreSupport/WebContextMenuClient.mm:
2463 * WebCoreSupport/WebDragClient.h:
2464 * WebCoreSupport/WebDragClient.mm:
2465 * WebCoreSupport/WebEditorClient.h:
2466 * WebCoreSupport/WebEditorClient.mm:
2467 * WebCoreSupport/WebFrameLoaderClient.h:
2468 * WebCoreSupport/WebFrameLoaderClient.mm:
2469 * WebCoreSupport/WebIconDatabaseClient.h:
2470 * WebCoreSupport/WebIconDatabaseClient.mm:
2471 * WebCoreSupport/WebInspectorClient.h:
2472 * WebCoreSupport/WebInspectorClient.mm:
2473 * WebCoreSupport/WebJavaScriptTextInputPanel.h:
2474 * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2475 * WebCoreSupport/WebSecurityOrigin.mm:
2476 * WebCoreSupport/WebSecurityOriginInternal.h:
2477 * WebCoreSupport/WebSecurityOriginPrivate.h:
2478 * WebCoreSupport/WebSystemInterface.h:
2479 * WebCoreSupport/WebSystemInterface.mm:
2480 * WebInspector/WebInspector.h:
2481 * WebInspector/WebInspector.mm:
2482 * WebInspector/WebInspectorPrivate.h:
2483 * WebInspector/WebNodeHighlight.h:
2484 * WebInspector/WebNodeHighlight.mm:
2485 * WebInspector/WebNodeHighlightView.h:
2486 * WebInspector/WebNodeHighlightView.mm:
2487 * WebInspector/WebNodeHighlighter.h:
2488 * WebInspector/WebNodeHighlighter.mm:
2489 * WebKitLegacy/MigrateHeadersToLegacy.make:
2491 * WebView/WebArchive.h:
2492 * WebView/WebArchive.mm:
2493 * WebView/WebArchiveInternal.h:
2494 * WebView/WebClipView.h:
2495 * WebView/WebClipView.mm:
2496 * WebView/WebDashboardRegion.h:
2497 * WebView/WebDashboardRegion.mm:
2498 * WebView/WebDataSource.h:
2499 * WebView/WebDataSource.mm:
2500 * WebView/WebDataSourceInternal.h:
2501 * WebView/WebDataSourcePrivate.h:
2502 * WebView/WebDelegateImplementationCaching.h:
2503 * WebView/WebDelegateImplementationCaching.mm:
2504 * WebView/WebDocument.h:
2505 * WebView/WebDocumentInternal.h:
2506 * WebView/WebDocumentLoaderMac.h:
2507 * WebView/WebDocumentLoaderMac.mm:
2508 * WebView/WebDocumentPrivate.h:
2509 * WebView/WebDynamicScrollBarsViewInternal.h:
2510 * WebView/WebEditingDelegate.h:
2511 * WebView/WebEditingDelegatePrivate.h:
2512 * WebView/WebFormDelegate.h:
2513 * WebView/WebFormDelegate.m:
2514 * WebView/WebFormDelegatePrivate.h:
2515 * WebView/WebFrame.h:
2516 * WebView/WebFrame.mm:
2517 * WebView/WebFrameInternal.h:
2518 * WebView/WebFrameLoadDelegate.h:
2519 * WebView/WebFrameLoadDelegatePrivate.h:
2520 * WebView/WebFramePrivate.h:
2521 * WebView/WebFrameView.h:
2522 * WebView/WebFrameView.mm:
2523 * WebView/WebFrameViewInternal.h:
2524 * WebView/WebFrameViewPrivate.h:
2525 * WebView/WebHTMLRepresentation.h:
2526 * WebView/WebHTMLRepresentation.mm:
2527 * WebView/WebHTMLRepresentationPrivate.h:
2528 * WebView/WebHTMLView.h:
2529 * WebView/WebHTMLView.mm:
2530 * WebView/WebHTMLViewInternal.h:
2531 * WebView/WebHTMLViewPrivate.h:
2532 * WebView/WebNotification.h:
2533 * WebView/WebNotification.mm:
2534 * WebView/WebNotificationInternal.h:
2535 * WebView/WebPDFRepresentation.h:
2536 * WebView/WebPDFRepresentation.mm:
2537 * WebView/WebPDFView.h:
2538 * WebView/WebPDFView.mm:
2539 * WebView/WebPolicyDelegate.h:
2540 * WebView/WebPolicyDelegate.mm:
2541 * WebView/WebPolicyDelegatePrivate.h:
2542 * WebView/WebPreferenceKeysPrivate.h:
2543 * WebView/WebPreferences.h:
2544 * WebView/WebPreferences.mm:
2545 * WebView/WebPreferencesPrivate.h:
2546 * WebView/WebRenderLayer.h:
2547 * WebView/WebRenderLayer.mm:
2548 * WebView/WebRenderNode.h:
2549 * WebView/WebRenderNode.mm:
2550 * WebView/WebResource.h:
2551 * WebView/WebResource.mm:
2552 * WebView/WebResourceInternal.h:
2553 * WebView/WebResourceLoadDelegate.h:
2554 * WebView/WebResourceLoadDelegatePrivate.h:
2555 * WebView/WebResourcePrivate.h:
2556 * WebView/WebScriptDebugDelegate.h:
2557 * WebView/WebScriptDebugDelegate.mm:
2558 * WebView/WebScriptDebugger.h:
2559 * WebView/WebScriptDebugger.mm:
2560 * WebView/WebTextCompletionController.mm:
2561 * WebView/WebUIDelegate.h:
2562 * WebView/WebUIDelegatePrivate.h:
2563 * WebView/WebView.h:
2564 * WebView/WebView.mm:
2565 * WebView/WebViewData.h:
2566 * WebView/WebViewData.mm:
2567 * WebView/WebViewInternal.h:
2568 * WebView/WebViewPrivate.h:
2570 2014-03-14 Ryosuke Niwa <rniwa@webkit.org>
2572 REGRESSION(r165385): [WebTextIterator currentRange] crashes
2573 https://bugs.webkit.org/show_bug.cgi?id=130271
2575 Reviewed by Anders Carlsson.
2577 After r165385, TextIterator::range no longer checked the nullity of m_positionNode. As a result,
2578 [WebTextIterator currentRange] which simply calls TextIterator::range crashes when an application
2579 that embeds WebKit doesn't check [WebTextIterator atEnd] first.
2581 Preserve the old public API behavior by checking atEnd in [WebTextIterator currentRange].
2583 * WebView/WebTextIterator.mm:
2584 (-[WebTextIterator currentRange]):
2586 2014-03-12 Sergio Villar Senin <svillar@igalia.com>
2588 Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
2589 https://bugs.webkit.org/show_bug.cgi?id=129612
2591 Reviewed by Darin Adler.
2593 For new code use static NeverDestroyed<T> instead.
2595 * History/WebBackForwardList.mm:
2597 * History/WebHistoryItem.mm:
2598 (historyItemWrappers):
2599 * Misc/WebNSPasteboardExtras.mm:
2600 (+[NSPasteboard _web_writableTypesForURL]):
2601 (_writableTypesForImageWithoutArchive):
2602 (_writableTypesForImageWithArchive):
2603 * Misc/WebStringTruncator.mm:
2605 * Plugins/Hosted/NetscapePluginHostManager.mm:
2606 (WebKit::NetscapePluginHostManager::shared):
2607 * Plugins/Hosted/NetscapePluginHostProxy.mm:
2608 (WebKit::pluginProxyMap):
2609 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2610 (WebKit::globalExceptionString):
2611 * Plugins/Hosted/ProxyInstance.mm:
2612 (WebKit::proxyClass):
2613 * Plugins/WebNetscapePluginStream.mm:
2615 * Storage/WebDatabaseManager.mm:
2616 (transactionBackgroundTaskIdentifierLock):
2617 * WebCoreSupport/WebUserMediaClient.mm:
2618 (userMediaRequestsMap):
2619 * WebView/WebHTMLRepresentation.mm:
2621 * WebView/WebView.mm:
2622 (aeDescFromJSValue):
2624 2014-03-13 Tim Horton <timothy_horton@apple.com>
2626 Fix relative paths to UseInternalSDK.xcconfig for ANGLE and WebKit/mac
2628 Rubber-stamped by Mark Rowe.
2632 * Configurations/Base.xcconfig:
2634 2014-03-13 Anders Carlsson <andersca@apple.com>
2638 * Misc/WebSharingServicePickerController.mm:
2640 2014-03-13 Radu Stavila <stavila@adobe.com>
2642 Webkit not building on XCode 5.1 due to garbage collection no longer being supported
2643 https://bugs.webkit.org/show_bug.cgi?id=130087
2645 Reviewed by Mark Rowe.
2647 Disable garbage collection on macosx when not using internal SDK.
2649 * Configurations/Base.xcconfig:
2651 2014-03-10 Darin Adler <darin@apple.com>
2653 Avoid copy-prone idiom "for (auto item : collection)"
2654 https://bugs.webkit.org/show_bug.cgi?id=129990
2656 Reviewed by Geoffrey Garen.
2658 * WebView/WebFrame.mm:
2659 (-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
2660 Use auto*. Also removed uneeded ASSERT_NO_EXCEPTION, which is already
2661 the default without specifying it explicitly.
2663 2014-03-12 Brian Burg <bburg@apple.com>
2665 Web Inspector: Remove unused callId parameter from evaluateInWebInspector
2666 https://bugs.webkit.org/show_bug.cgi?id=129744
2668 Reviewed by Timothy Hatcher.
2670 * WebInspector/WebInspector.mm:
2671 (-[WebInspector evaluateInFrontend:script:]):
2672 * WebInspector/WebInspectorPrivate.h:
2674 2014-03-12 Dean Jackson <dino@apple.com>
2676 [WebGL] WebKit1 + WebKit2 iOS clients should check load policy
2677 https://bugs.webkit.org/show_bug.cgi?id=130162
2679 Reviewed by Simon Fraser.
2681 Implement the webGLPolicyForURL methods, calling into WebKitSystemInterface.
2683 * Configurations/WebKit.xcconfig: Add MobileAsset to iOS config.
2684 * WebCoreSupport/WebFrameLoaderClient.h:
2685 * WebCoreSupport/WebFrameLoaderClient.mm:
2687 2014-03-12 Joseph Pecoraro <pecoraro@apple.com>
2689 Web Inspector: Disable REMOTE_INSPECTOR in earlier OS X releases
2690 https://bugs.webkit.org/show_bug.cgi?id=130118
2692 Reviewed by Timothy Hatcher.
2694 * Configurations/FeatureDefines.xcconfig:
2696 * WebCoreSupport/WebInspectorClient.mm:
2697 (WebInspectorClient::indicate):
2698 (WebInspectorClient::hideIndication):
2699 Properly guard REMOTE_INSPECTOR only calls.
2701 2014-03-12 Tim Horton <timothy_horton@apple.com>
2703 Build fix for ENABLE(IMAGE_CONTROLS) after 165479
2705 * Misc/WebSharingServicePickerController.h:
2706 * Misc/WebSharingServicePickerController.mm:
2707 Don't use new-runtime features in code that has to build 32-bit.
2709 2014-03-12 Anders Carlsson <andersca@apple.com>
2711 <rdar://problem/16307346> Add new WebKitLegacy.framework.
2713 Reviewed by Dan Bernstein.
2715 * Configurations/WebKitLegacy.xcconfig:
2716 Add xcconfig file for the new framework.
2718 * WebKitLegacy/Info.plist:
2719 Add Info.plist for WebKitLegacy.framework.
2721 * WebKitLegacy/MigrateHeadersToLegacy.make:
2722 Add makefile that copies headers from WebKit to WebKitLegacy and rewrites includes from WebKit/ to WebKitLegacy/
2723 * WebKitLegacy/WebKitLegacy.cpp:
2724 Add an empty file so we'll have something to link.
2726 2014-03-12 Tim Horton <timothy_horton@apple.com>
2728 Hook up image controls for WebKit1
2729 https://bugs.webkit.org/show_bug.cgi?id=130062
2730 <rdar://problem/15964809>
2732 Reviewed by Brady Eidson.
2734 * Misc/WebSharingServicePickerController.h: Added.
2735 * Misc/WebSharingServicePickerController.mm: Added.
2736 (-[WebSharingServicePickerController initWithImage:menuClient:]):
2737 (-[WebSharingServicePickerController menu]):
2738 (-[WebSharingServicePickerController sharingServicePicker:delegateForSharingService:]):
2739 (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
2740 (-[WebSharingServicePickerController sharingService:didShareItems:]):
2741 (-[WebSharingServicePickerController sharingService:didFailToShareItems:error:]):
2742 (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2743 Add a NSSharingServiceDelegate and NSSharingServicePickerDelegate, which will also
2744 provide a NSMenu instance for WebContextMenuClient to pop up when image controls are needed.
2745 When data is returned from the service, it is re-inserted into the image via replaceControlledImage.
2747 * WebCoreSupport/WebContextMenuClient.h:
2748 * WebCoreSupport/WebContextMenuClient.mm:
2749 (WebContextMenuClient::contextMenuForEvent):
2750 Factor out code to decide which NSMenu to use, so that we can use early-returns to simplify it.
2751 If we hit an image with image controls, use the WebSharingServicePickerController's menu.
2753 (WebContextMenuClient::showContextMenu):
2754 (WebContextMenuClient::clearSharingServicePickerController):
2756 2014-03-10 Jer Noble <jer.noble@apple.com>
2758 [iOS][WK1] Crash in HTMLMediaElement::createElementRenderer() - "-[NSSet addObject:]: object cannot be nil"
2759 https://bugs.webkit.org/show_bug.cgi?id=129634
2761 Reviewed by Eric Carlson.
2763 If a plugin fails to create a NSView, a nil object is inserted into the WebPluginController's
2764 pluginViews set. This is an exceptional case, so add an ASSERT so that this error will continue
2765 to occur in debug builds, but also add an early return so as not to crash release builds.
2767 * Plugins/WebPluginController.mm:
2768 (+[WebPluginController addPlugInView:]):
2770 2014-03-06 Alexey Proskuryakov <ap@apple.com>
2772 [Mac] Don't perform a round-trip through WebProcess before interpreting key events
2773 https://bugs.webkit.org/show_bug.cgi?id=129812
2775 Reviewed by Darin Adler.
2777 * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleInputMethodKeydown):
2778 Added a FIXME. WebKit1/mac is the only port that uses this roundabout way to
2779 interpret events, so it would simplify code if we switched it to WebKit2/mac model.
2781 2014-03-08 Simon Fraser <simon.fraser@apple.com>
2783 [iOS Wk2] Can't scroll after going back to page in page cache
2784 https://bugs.webkit.org/show_bug.cgi?id=129989
2785 <rdar://problem/16217588>
2787 Reviewed by Dan Bernstein.
2789 iOS has a special FrameLoader::forceLayoutWithoutRecalculatingStyle()
2790 function that is called instead of FrameView::forceLayout(). This was unimplemented
2791 for the WK2 FrameLoaderClient, so no layout was forced, with the result
2792 that the contentSize was never updated and scrolling was broken.
2794 Fix by renaming the client function to forceLayoutOnRestoreFromPageCache()
2795 and having it return a bool to say whether the default forceLayout()
2796 should be done. WK1 can then continue to have its custom behavior,
2797 and Wk2 will simply do a forceLayout().
2799 Also remove FrameLaoderClient::forceLayout(), which was never called.
2801 * WebCoreSupport/WebFrameLoaderClient.h:
2802 * WebCoreSupport/WebFrameLoaderClient.mm:
2803 (WebFrameLoaderClient::forceLayoutOnRestoreFromPageCache):
2805 2014-03-07 Anders Carlsson <andersca@apple.com>
2807 Add the remaining WebKit2 headers to WEBKIT2_HEADERS
2808 https://bugs.webkit.org/show_bug.cgi?id=129942
2809 <rdar://problem/15920020>
2811 Reviewed by Tim Horton.
2813 * MigrateHeaders.make:
2815 2014-03-07 Anders Carlsson <andersca@apple.com>
2817 MigrateHeaders.make should remove C SPI includes from WebKit2 headers
2818 https://bugs.webkit.org/show_bug.cgi?id=129937
2819 <rdar://problem/15920020>
2821 Reviewed by Tim Horton.
2823 * MigrateHeaders.make:
2824 Add WKPreferences.h to WEBKIT2_HEADERS.
2825 Add a sed rule that deletes all lines that start with a # and contain <WebKit/*Ref.h>.
2827 2014-03-07 Anders Carlsson <andersca@apple.com>
2829 Make it possible to copy WebKit2 headers to WebKit.framework
2830 https://bugs.webkit.org/show_bug.cgi?id=129935
2831 <rdar://problem/15920020>
2833 Reviewed by Dan Bernstein.
2835 * MigrateHeaders.make:
2836 Gather a list of public and private WebKit2 headers and filter them against the WEBKIT2_HEADERS list.
2837 The matching headers are copied to the respective Headers or PrivateHeaders directories under WebKit.framework,
2838 and also have their #imports rewritten to reference WebKit instead of WebKit2.
2840 * migrate-headers.sh: Added.
2841 Set up the WEBKIT2_FRAMEWORKS_DIR if needed.
2843 2014-03-07 Anders Carlsson <andersca@apple.com>
2846 <rdar://problem/15920020>
2848 Rubber-stamped by Dan Bernstein.
2850 * Configurations/WebKit.xcconfig:
2852 2014-03-07 Anders Carlsson <andersca@apple.com>
2854 Tweak the WebKit2 frameworks directories
2855 https://bugs.webkit.org/show_bug.cgi?id=129910
2856 <rdar://problem/15920020>
2858 Reviewed by Dan Bernstein.
2860 Use an SDK relative directory for production builds.
2862 * Configurations/WebKit.xcconfig:
2864 2014-03-07 Anders Carlsson <andersca@apple.com>
2866 Link WebKit.framework against WebKit2.framework and re-export all WebKit2 symbols
2867 https://bugs.webkit.org/show_bug.cgi?id=129901
2868 <rdar://problem/15920020>
2870 Reviewed by Andreas Kling.
2872 * Configurations/WebKit.xcconfig:
2874 2014-03-06 Joseph Pecoraro <pecoraro@apple.com>
2876 Web Inspector: Expose the console object in JSContexts to interact with Web Inspector
2877 https://bugs.webkit.org/show_bug.cgi?id=127944
2879 Reviewed by Geoffrey Garen.
2881 * WebCoreSupport/WebChromeClient.h:
2882 * WebCoreSupport/WebChromeClient.mm:
2885 2014-03-05 Eric Carlson <eric.carlson@apple.com>
2887 [iOS] Show external device name/type in placeholder
2888 https://bugs.webkit.org/show_bug.cgi?id=129723
2890 Reviewed by Jer Noble.
2892 * WebCoreSupport/WebSystemInterface.mm:
2893 (InitWebCoreSystemInterface):
2895 2014-03-05 Simon Fraser <simon.fraser@apple.com>
2897 ObjC exception when dropping files into a WKView: drag and drop uses code from WebKit.framework
2898 https://bugs.webkit.org/show_bug.cgi?id=129752
2900 Reviewed by Enrica Casucci.
2902 Call URLByCanonicalizingURL() which is implemented in WebCore.
2904 * Misc/WebNSURLExtras.mm:
2905 (-[NSURL _webkit_canonicalize]):
2907 2014-03-04 Zalan Bujtas <zalan@apple.com>
2909 Enable device pixel repaint rect tracking.
2910 https://bugs.webkit.org/show_bug.cgi?id=129712
2912 Reviewed by Simon Fraser.
2914 Tracked repaint rects are device pixel snapped now to support hiDPI test cases.
2916 * WebView/WebView.mm:
2917 (-[WebView trackedRepaintRects]): Keep existing behavior for now.
2919 2014-03-04 Simon Fraser <simon.fraser@apple.com>
2921 Allow iOS DumpRenderTree crashes to show application-specific information
2922 https://bugs.webkit.org/show_bug.cgi?id=129705
2924 Reviewed by David Kilzer.
2926 Make the WKSI function SetCrashReportApplicationSpecificInformation available
2927 in iOS simulator builds.
2929 * WebCoreSupport/WebSystemInterface.mm:
2930 (InitWebCoreSystemInterface):
2932 2014-03-04 Mark Hahnenberg <mhahnenberg@apple.com>
2934 Merge API shims and JSLock
2935 https://bugs.webkit.org/show_bug.cgi?id=129650
2937 Reviewed by Mark Lam.
2939 JSLock is now taking on all of APIEntryShim's responsibilities since there is never a reason
2940 to take just the JSLock. Ditto for DropAllLocks and APICallbackShim.
2942 * WebView/WebFrame.mm:
2943 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2945 2014-03-02 Darin Adler <darin@apple.com>
2947 Sort Mac platform export files so they merge better
2948 https://bugs.webkit.org/show_bug.cgi?id=129581
2950 Reviewed by Sam Weinig.
2952 * WebKit.exp: Ran the new sort-export-file on this.
2954 2014-03-02 Darin Adler <darin@apple.com>
2956 Change public text iterator API implementations to not depend on 16-bit character pointers
2957 https://bugs.webkit.org/show_bug.cgi?id=129566
2959 Reviewed by Anders Carlsson.
2961 * WebView/WebTextIterator.mm:
2962 (-[WebTextIterator initWithRange:]): Use make_unique instead of adoptPtr.
2963 (-[WebTextIterator advance]): Clear out the upconverted text since we are moving on to the
2965 (-[WebTextIterator currentTextPointer]): Upconvert if we have 8-bit text.
2966 (-[WebTextIterator currentTextLength]): Call TextIterator::text().length() since we will
2967 probably be removing TextIterator::length eventually.
2969 2014-03-01 Pratik Solanki <psolanki@apple.com>
2971 [iOS] selectionImageForcingBlackText should return autoreleased object
2972 https://bugs.webkit.org/show_bug.cgi?id=129437
2973 <rdar://problem/15810384>
2975 Reviewed by Darin Adler.
2977 * WebView/WebHTMLView.mm:
2978 (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2980 2014-02-28 Dan Bernstein <mitz@apple.com>
2982 [Mac] Remove MailQuirksUserScript.js
2983 https://bugs.webkit.org/show_bug.cgi?id=129536
2985 Reviewed by Andy Estes.
2987 * Configurations/WebKit.xcconfig: Removed from EXCLUDED_SOURCE_FILE_NAMES_iphoneos.
2988 * Misc/MailQuirksUserScript.js: Removed. This file has been unused since r147447.
2990 2014-02-28 Timothy Hatcher <timothy@apple.com>
2992 Properly handle when Test.html is not present in Production builds.
2994 https://bugs.webkit.org/show_bug.cgi?id=129506
2996 Reviewed by Joseph Pecoraro.
2998 * WebCoreSupport/WebInspectorClient.mm:
2999 (-[WebInspectorWindowController inspectorTestPagePath]):
3000 (-[WebInspectorWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3002 2014-02-27 Brian Burg <bburg@apple.com>
3004 Web Inspector: model tests should use a special Test.html inspector page
3005 https://bugs.webkit.org/show_bug.cgi?id=129190
3007 Reviewed by Timothy Hatcher.
3009 Support creating a separate test inspector page, based on the value of
3010 InspectorController::isUnderTest(). Modify the navigation policy to check
3011 the URL against both normal and test inspector pages.
3013 * WebCoreSupport/WebInspectorClient.mm:
3014 (WebInspectorClient::openInspectorFrontend):
3015 (-[WebInspectorWindowController init]):
3016 (-[WebInspectorWindowController initWithInspectedWebView:isUnderTest:]):
3017 Move the initial navigation of the inspector page to this method, and change
3018 the URL based on the value of InspectorController::isUnderTest().
3020 (-[WebInspectorWindowController inspectorTestPagePath]): Added.
3021 (-[WebInspectorWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3023 2014-02-27 Pratik Solanki <psolanki@apple.com>
3025 Assertion failure at CachedResource.h:196: ASSERT(!m_purgeableData)
3026 https://bugs.webkit.org/show_bug.cgi?id=129349
3027 <rdar://problem/14871837>
3029 Reviewed by Joseph Pecoraro.
3031 The code for clearing out memory mapped notification callbacks is only needed when loading
3032 PDFs. And in such cases, we always have dataSourceDelegate object. So make this code
3033 conditional on its presence so that we don't trigger the assert for non-PDF main resources.
3035 * WebView/WebDataSource.mm:
3036 (-[WebDataSource dealloc]):
3038 2014-02-26 Andy Estes <aestes@apple.com>
3040 [iOS] Support network state notification using CPNetworkObserver
3041 https://bugs.webkit.org/show_bug.cgi?id=129358
3043 Reviewed by Dan Bernstein.
3045 * WebView/WebView.mm:
3046 (-[WebView _setNetworkStateIsOnline:]): Retained an empty
3047 implementation for binary compatibility for UIKit.
3048 (+[WebView _doNotStartObservingNetworkReachability]): Called
3049 Settings::setShouldOptOutOfNetworkStateObservation(true).
3050 * WebView/WebViewPrivate.h: Removed declaration of
3051 _setNetworkStateIsOnline: and declared
3052 _doNotStartObservingNetworkReachability.
3054 2014-02-25 Anders Carlsson <andersca@apple.com>
3056 Get rid of VisitedLinkStrategy
3057 https://bugs.webkit.org/show_bug.cgi?id=129324
3059 Reviewed by Dan Bernstein.
3061 * WebCoreSupport/WebPlatformStrategies.h:
3062 * WebCoreSupport/WebPlatformStrategies.mm:
3064 2014-02-25 Sergio Villar Senin <svillar@igalia.com>
3066 [CSS Grid Layout] Add ENABLE flag
3067 https://bugs.webkit.org/show_bug.cgi?id=129153
3069 Reviewed by Simon Fraser.
3071 Added ENABLE_CSS_GRID_LAYOUT feature flag.
3073 * Configurations/FeatureDefines.xcconfig:
3075 2014-02-24 Anders Carlsson <andersca@apple.com>
3078 https://bugs.webkit.org/show_bug.cgi?id=129280
3080 Reviewed by Dan Bernstein.
3082 This is a first step towards getting rid of page groups in WebCore. The idea is that
3083 everything that is per page group in WebCore will be per page. In order to retain WebKit1 compatibility
3084 WebViewGroup is going to take over more and more responsibility from WebCore::PageGroup.
3086 * WebCoreSupport/WebViewGroup.h: Added.
3087 * WebCoreSupport/WebViewGroup.mm: Added.
3089 (WebViewGroup::getOrCreate):
3090 (WebViewGroup::WebViewGroup):
3091 (WebViewGroup::~WebViewGroup):
3092 (WebViewGroup::addWebView):
3093 (WebViewGroup::removeWebView):
3094 * WebView/WebView.mm:
3095 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3096 (-[WebView _close]):
3097 (-[WebView setGroupName:]):
3098 * WebView/WebViewData.h:
3099 * WebView/WebViewData.mm:
3101 2014-02-24 Tamas Gergely <tgergely.u-szeged@partner.samsung.com>
3103 Code cleanup: remove leftover ENABLE(WORKERS) macros and support.
3104 https://bugs.webkit.org/show_bug.cgi?id=129255
3106 Reviewed by Csaba Osztrogonác.
3108 ENABLE_WORKERS macro was removed in r159679.
3109 Support is now also removed from xcconfig files.
3111 * Configurations/FeatureDefines.xcconfig:
3113 2014-02-24 David Kilzer <ddkilzer@apple.com>
3115 Remove redundant setting in FeatureDefines.xcconfig
3117 * Configurations/FeatureDefines.xcconfig:
3119 2014-02-23 Sam Weinig <sam@webkit.org>
3121 Update FeatureDefines.xcconfig
3123 Rubber-stamped by Anders Carlsson.
3125 * Configurations/FeatureDefines.xcconfig:
3127 2014-02-23 Sam Weinig <sam@webkit.org>
3129 Move telephone number detection behind its own ENABLE macro
3130 https://bugs.webkit.org/show_bug.cgi?id=129236
3132 Reviewed by Dean Jackson.
3134 * Configurations/FeatureDefines.xcconfig:
3135 Add ENABLE_TELEPHONE_NUMBER_DETECTION.
3137 2014-02-21 Sam Weinig <sam@webkit.org>
3139 Expose phase and momentum phase as SPI on DOMWheelEvent
3140 <rdar://problem/16110871>
3141 https://bugs.webkit.org/show_bug.cgi?id=129184
3143 Reviewed by Anders Carlsson.
3145 * DOM/WebDOMOperations.mm:
3147 (-[DOMWheelEvent _phase]):
3148 (-[DOMWheelEvent _momentumPhase]):
3149 * DOM/WebDOMOperationsPrivate.h:
3150 Expose _phase and _momentumPhase as SPI.
3152 * MigrateHeaders.make:
3153 Make DOMWheelEventInternal.h to WebKit.
3155 2014-02-22 David Kilzer <ddkilzer@apple.com>
3157 Revert r164434 since it actually broke ASan builds
3158 <http://webkit.org/b/128871>
3160 * Configurations/WebKit.xcconfig: This caused -asan-blacklist to
3161 be included twice on every compiler command, which caused clang
3164 2014-02-21 Brent Fulgham <bfulgham@apple.com>
3166 Extend media support for WebVTT sources
3167 https://bugs.webkit.org/show_bug.cgi?id=129156
3169 Reviewed by Eric Carlson.
3171 * Configurations/FeatureDefines.xcconfig: Add new feature define for AVF_CAPTIONS
3173 2014-02-20 Brady Eidson <beidson@apple.com>
3175 Add very basic image control rendering
3176 https://bugs.webkit.org/show_bug.cgi?id=129080
3178 Reviewed by Tim Horton.
3180 Expose the imageControlsEnabled setting to WebKit1 so DRT can use it.
3182 * WebView/WebPreferenceKeysPrivate.h:
3183 * WebView/WebPreferences.mm:
3184 (+[WebPreferences initialize]):
3185 (-[WebPreferences imageControlsEnabled]):
3186 (-[WebPreferences setImageControlsEnabled:]):
3187 * WebView/WebPreferencesPrivate.h:
3189 * WebView/WebView.mm:
3190 (-[WebView _preferencesChanged:]):
3192 2014-02-20 David Kilzer <ddkilzer@apple.com>
3194 [ASan] WebKit1 sources are not compiled using ASAN macros
3195 <http://webkit.org/b/128871>
3197 Reviewed by Brent Fulgham.
3199 * Configurations/WebKit.xcconfig: Use $inherited for
3200 OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS so that ASAN_OTHER_CFLAGS
3201 and ASAN_OTHER_CPLUSPLUSFLAGS are inherited from
3202 DebugRelease.xcconfig.
3204 2014-02-19 Brady Eidson <beidson@apple.com>
3206 Add FeatureDefines for image controls
3207 https://bugs.webkit.org/show_bug.cgi?id=129022
3209 Reviewed by Jer Noble.
3211 * Configurations/FeatureDefines.xcconfig:
3213 2014-02-18 Sam Weinig <sam@webkit.org>
3215 Simplify HTML tokenizer parameterization down to what is used
3216 https://bugs.webkit.org/show_bug.cgi?id=128977
3218 Reviewed by Alexey Proskuryakov.
3220 Remove unused _setCustomHTMLTokenizerTimeDelay and _setCustomHTMLTokenizerChunkSize SPI.
3222 * WebView/WebView.mm:
3223 * WebView/WebViewPrivate.h:
3225 2014-02-17 Anders Carlsson <andersca@apple.com>
3227 Remove view source code
3228 https://bugs.webkit.org/show_bug.cgi?id=127233
3230 Reviewed by Antti Koivisto.
3232 * WebView/WebView.mm:
3233 * WebView/WebViewPrivate.h:
3235 2014-02-17 Sergio Correia <sergio.correia@openbossa.org>
3237 Replace uses of PassOwnPtr/OwnPtr with std::unique_ptr in WebCore/inspector
3238 https://bugs.webkit.org/show_bug.cgi?id=128681
3240 Reviewed by Timothy Hatcher.
3242 Another step towards getting rid of PassOwnPtr/OwnPtr, now targeting
3243 WebCore/inspector/*. Besides files in there, a few other files in
3244 JavaScriptCore/inspector, WebKit/, WebKit2/WebProcess/WebCoreSupport/
3245 and WebCore/testing were touched.
3247 * WebCoreSupport/WebInspectorClient.h:
3248 * WebCoreSupport/WebInspectorClient.mm:
3250 2014-02-15 Alexey Proskuryakov <ap@apple.com>
3252 [Mac] Remove WebSerializedJSValue SPI
3253 https://bugs.webkit.org/show_bug.cgi?id=128720
3255 Reviewed by Anders Carlsson.
3258 * WebView/WebSerializedJSValue.h: Removed.
3259 * WebView/WebSerializedJSValue.mm: Removed.
3260 * WebView/WebSerializedJSValuePrivate.h: Removed.
3262 2014-02-15 Alexey Proskuryakov <ap@apple.com>
3264 [Mac] All WebKit clients should encrypt WebCrypto keys automatically
3265 https://bugs.webkit.org/show_bug.cgi?id=128852
3267 Reviewed by Oliver Hunt.
3269 * WebCoreSupport/WebChromeClient.mm:
3270 (WebChromeClient::wrapCryptoKey):
3271 (WebChromeClient::unwrapCryptoKey):
3272 Call the default implementation if key is not provided by a client.
3274 2014-02-14 Anders Carlsson <andersca@apple.com>
3276 Control tints don't update inside WebViews
3277 https://bugs.webkit.org/show_bug.cgi?id=128862
3279 Reviewed by Ryosuke Niwa.
3281 * WebView/WebView.mm:
3282 (-[WebView _windowChangedKeyState]):
3283 Call [super _windowChangedKeyState].
3285 2014-02-13 Myles C. Maxfield <mmaxfield@apple.com>
3287 During a copy, position:fixed gets converted to position:absolute even if only part of the document is selected
3288 https://bugs.webkit.org/show_bug.cgi?id=128688
3290 Reviewed by Ryosuke Niwa.
3292 Renames the ConvertPositionStyleOnCopy setting to ShouldConvertPositionStyleOnCopy
3294 * WebView/WebPreferenceKeysPrivate.h:
3295 * WebView/WebPreferences.mm:
3296 (-[WebPreferences shouldConvertPositionStyleOnCopy]):
3297 (-[WebPreferences setShouldConvertPositionStyleOnCopy:]):
3298 * WebView/WebPreferencesPrivate.h:
3299 * WebView/WebView.mm:
3300 (-[WebView _preferencesChanged:]):
3302 2014-02-13 Alexey Proskuryakov <ap@apple.com>
3304 [Mac] Add a WebKit1 SPI to get WebCrypto master key from a client
3305 https://bugs.webkit.org/show_bug.cgi?id=128725
3307 Reviewed by Anders Carlsson.
3309 * WebCoreSupport/WebChromeClient.mm:
3310 (WebChromeClient::wrapCryptoKey):
3311 (WebChromeClient::unwrapCryptoKey):
3312 * WebView/WebUIDelegatePrivate.h:
3313 Looks like UIDelegate is the closest we have to a reasonable place.
3315 2014-02-13 Dan Bernstein <mitz@apple.com>
3319 * WebView/WebView.mm:
3320 (+[WebView registerForMemoryNotifications]):
3322 2014-02-12 Alexey Proskuryakov <ap@apple.com>
3324 Wrap WebCrypto keys in SerializedScriptValue
3325 https://bugs.webkit.org/show_bug.cgi?id=128680
3327 Reviewed by Anders Carlsson.
3329 Retrieve a master key (placeholder code for now), and use it to wrap key data.
3331 * WebCoreSupport/WebChromeClient.mm:
3332 (WebChromeClient::wrapCryptoKey):
3333 (WebChromeClient::unwrapCryptoKey):
3335 2014-02-11 Ryosuke Niwa <rniwa@webkit.org>
3337 Frame::rectForSelection shouldn't instantiate FrameSelection
3338 https://bugs.webkit.org/show_bug.cgi?id=128587
3340 Reviewed by Enrica Casucci.
3342 * WebCoreSupport/WebEditorClient.h:
3343 * WebCoreSupport/WebEditorClient.mm:
3344 (WebEditorClient::WebEditorClient):
3345 (WebEditorClient::respondToChangedSelection):
3347 2014-02-10 Myles C. Maxfield <mmaxfield@apple.com>
3349 Convert position:sticky and position:fixed properties to position:static and position:absolute upon copy
3350 https://bugs.webkit.org/show_bug.cgi?id=128194
3352 Reviewed by Simon Fraser.
3354 * WebView/WebPreferenceKeysPrivate.h:
3355 * WebView/WebPreferences.mm:
3356 (-[WebPreferences convertPositionStyleOnCopy]):
3357 (-[WebPreferences setConvertPositionStyleOnCopy:]):
3358 * WebView/WebPreferencesPrivate.h: Opt-in to new behavior
3359 * WebView/WebView.mm:
3360 (-[WebView _preferencesChanged:]):
3362 2014-02-11 Andy Estes <aestes@apple.com>
3364 [Mac] connection:willStopBufferingData: no longer exists in NSURLConnectionDelegate
3365 https://bugs.webkit.org/show_bug.cgi?id=128583
3367 Reviewed by Anders Carlsson.
3369 The delegate method was removed in Snow Leopard.
3371 * Misc/WebDownload.mm:
3373 2014-02-11 Alexey Proskuryakov <ap@apple.com>
3377 * WebCoreSupport/WebChromeClient.mm: Fixed incorrectly nested ifdefs.
3379 2014-02-10 Alexey Proskuryakov <ap@apple.com>
3381 Add hooks for wrapping CryptoKeys in SerializedScriptValue
3382 https://bugs.webkit.org/show_bug.cgi?id=128567
3384 Reviewed by Anders Carlsson.
3386 * WebCoreSupport/WebChromeClient.h:
3387 * WebCoreSupport/WebChromeClient.mm:
3388 (WebChromeClient::wrapCryptoKey):
3389 (WebChromeClient::unwrapCryptoKey):
3390 Dummy implementation, to be filled in later.
3392 2014-02-08 Ryosuke Niwa <rniwa@webkit.org>
3394 Cleanup the interface of FrameSelection
3395 https://bugs.webkit.org/show_bug.cgi?id=128481
3397 Reviewed by Andreas Kling.
3399 * WebView/WebHTMLView.mm:
3400 (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
3401 (-[WebHTMLView selectionRect]):
3402 (-[WebHTMLView selectionImageRect]):
3404 2014-02-08 Dan Bernstein <mitz@apple.com>
3406 Remove use of PLATFORM(MAC) from WebKit/mac
3407 https://bugs.webkit.org/show_bug.cgi?id=128476
3409 Reviewed by Anders Carlsson.
3411 * WebCoreSupport/WebFrameLoaderClient.h:
3412 * WebCoreSupport/WebSystemInterface.mm:
3413 (InitWebCoreSystemInterface):
3415 2014-02-08 Dan Bernstein <mitz@apple.com>
3417 Remove client-drawn highlights (-webkit-highlight, WebHTMLHighlighter)
3418 https://bugs.webkit.org/show_bug.cgi?id=128456
3420 Reviewed by Anders Carlsson.
3422 * WebCoreSupport/WebChromeClient.h:
3423 * WebCoreSupport/WebChromeClient.mm: Removed customHighlightRect and paintCustomHighlight.
3424 * WebView/WebHTMLView.mm:
3425 (-[WebHTMLViewPrivate dealloc]): Removed highlighters ivar.
3426 (-[WebHTMLViewPrivate clear]): Ditto.
3427 * WebView/WebHTMLViewInternal.h: Removed declaration.
3428 * WebView/WebHTMLViewPrivate.h: Removed WebHTMLHighlighter protocol and method declarations.
3430 2014-02-08 Dan Bernstein <mitz@apple.com>
3432 iOS build fix after r163712.
3434 * WebCoreSupport/WebEditorClient.h:
3435 * WebCoreSupport/WebEditorClient.mm:
3437 2014-02-08 Darin Adler <darin@apple.com>
3439 Change TextIterator to use StringView, preparing to wean it from deprecatedCharacters
3440 https://bugs.webkit.org/show_bug.cgi?id=128233
3442 Reviewed by Anders Carlsson.
3444 * WebCoreSupport/WebEditorClient.h: Made most data members private. Moved inlines
3445 for iOS out of the class definition. Fixed formatting. Added missing virtual keyword.
3446 Changed interfaces to use StringView.
3448 * WebCoreSupport/WebEditorClient.mm:
3449 (WebEditorClient::checkTextOfParagraph): Use the new StringView::createNSStringWithoutCopying
3450 function instead of a similar function that was local in this file.
3451 (WebEditorClient::ignoreWordInSpellDocument): Tweaked formatting.
3452 (WebEditorClient::checkSpellingOfString): Changed to take a StringView.
3453 (WebEditorClient::checkGrammarOfString): Ditto.
3455 * WebView/WebTextIterator.mm:
3456 (-[WebTextIterator currentTextPointer]): Call TextIterator::deprecatedTextIteratorCharacters.
3457 (-[WebTextIterator currentText]): Convert a the text to an NSString with TextIterator::text
3458 instead of with TextIterator::characters/length.
3460 2014-02-07 Gavin Barraclough <barraclough@apple.com>
3462 Remove isInitialState flag from Page::setViewState
3463 https://bugs.webkit.org/show_bug.cgi?id=128428
3465 Reviewed by Sam Weinig.
3467 * WebView/WebView.mm:
3468 (-[WebView _commonInitializationWithFrameName:groupName:]):
3469 (-[WebView _updateVisibilityState]):
3470 (-[WebView _setIsVisible:]):
3471 (-[WebView _setVisibilityState:isInitialState:]):
3472 (-[WebView _windowWillOrderOnScreen:]):
3473 (-[WebView _windowWillOrderOffScreen:]):
3474 - don't pass isInitialState to setViewState.
3476 2014-02-06 Filip Pizlo <fpizlo@apple.com>
3478 More FTL build scaffolding
3479 https://bugs.webkit.org/show_bug.cgi?id=128330
3481 Reviewed by Geoffrey Garen.
3483 * Configurations/FeatureDefines.xcconfig:
3485 2014-02-07 Dan Bernstein <mitz@apple.com>
3489 * Misc/WebElementDictionary.mm:
3490 (+[WebElementDictionary initializeLookupTable]):
3491 (-[WebElementDictionary _image]):
3492 (-[WebElementDictionary _imageRect]):
3494 2014-02-06 Joseph Pecoraro <pecoraro@apple.com>
3496 Web Inspector: Add Console support to JSContext Inspection
3497 https://bugs.webkit.org/show_bug.cgi?id=127941
3499 Reviewed by Geoffrey Garen.
3501 * WebCoreSupport/WebChromeClient.h:
3502 * WebCoreSupport/WebChromeClient.mm:
3503 (stringForMessageSource):
3504 (stringForMessageLevel):
3505 (WebChromeClient::addMessageToConsole):
3507 2014-02-05 Gavin Barraclough <barraclough@apple.com>
3509 Change Page, FocusController to use ViewState
3510 https://bugs.webkit.org/show_bug.cgi?id=126533
3512 Reviewed by Tim Horton.
3514 These classes currently maintain a set of separate fields to represent the view state;
3515 combine these into a single field, and allow WebPage to send the combined update rather
3516 than individual changes.
3518 Maintain existing interface for WebKit1 clients.
3520 * WebView/WebView.mm:
3521 (-[WebView _windowWillOrderOnScreen:]):
3522 (-[WebView _windowWillOrderOffScreen:]):
3523 - remove calls to FocusController::setContentIsVisible, these are redundant
3524 (this is handled when page visibility is set).
3526 2014-02-05 Andreas Kling <akling@apple.com>
3528 Remove ENABLE(DIRECTORY_UPLOAD).
3529 <https://webkit.org/b/128275>
3531 Rubber-stamped by Ryosuke Niwa.
3533 * Configurations/FeatureDefines.xcconfig:
3535 2014-02-05 Csaba Osztrogonác <ossy@webkit.org>
3537 Remove ENABLE(SVG) guards
3538 https://bugs.webkit.org/show_bug.cgi?id=127991
3540 Reviewed by Sam Weinig.
3542 * Configurations/FeatureDefines.xcconfig:
3544 2014-02-04 Andreas Kling <akling@apple.com>
3546 Remove <iframe seamless> support.
3547 <https://webkit.org/b/128213>
3549 Rubber-stamped by Antti Koivisto.
3551 * Configurations/FeatureDefines.xcconfig:
3552 * WebView/WebPreferenceKeysPrivate.h:
3553 * WebView/WebPreferences.mm:
3554 * WebView/WebPreferencesPrivate.h:
3555 * WebView/WebView.mm:
3556 (-[WebView _preferencesChanged:]):
3558 2014-02-03 Dean Jackson <dino@apple.com>
3560 Feature flag for shape-inside
3561 https://bugs.webkit.org/show_bug.cgi?id=128001
3563 Reviewed by Simon Fraser.
3565 Add CSS_SHAPE_INSIDE flag.
3567 * Configurations/FeatureDefines.xcconfig:
3569 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
3571 Remove inline member functions of FrameSelection that access m_selection
3572 https://bugs.webkit.org/show_bug.cgi?id=127986
3574 Reviewed by Enrica Casucci.
3576 * WebView/WebFrame.mm:
3577 (-[WebFrame hasEditableSelection]):
3578 (-[WebFrame selectionAffinity]):
3579 (-[WebFrame getDictationResultRanges:andMetadatas:]):
3580 (-[WebFrame hasRichlyEditableSelection]):
3581 (-[WebFrame focusedNodeHasContent]):
3582 * WebView/WebHTMLView.mm:
3583 (-[WebHTMLView readSelectionFromPasteboard:]):
3584 (-[WebHTMLView _hasSelection]):
3585 (-[WebHTMLView _hasSelectionOrInsertionPoint]):
3586 (-[WebHTMLView _hasInsertionPoint]):
3587 (-[WebHTMLView _isEditable]):
3588 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3589 (-[WebHTMLView maintainsInactiveSelection]):
3591 (isInPasswordField):
3592 * WebView/WebView.mm:
3593 (-[WebView selectionAffinity]):
3595 2014-01-31 Tim Horton <timothy_horton@apple.com>
3597 [wk2] PlatformCALayerRemoteCustom doesn't work on iOS
3598 https://bugs.webkit.org/show_bug.cgi?id=128025
3599 <rdar://problem/15950271>
3601 Reviewed by Simon Fraser.
3603 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3604 (-[WebHostedNetscapePluginView windowHostsLayersInWindowServer]):
3605 Use the new macro name.
3607 2014-01-30 David Kilzer <ddkilzer@apple.com>
3609 Add security-checked cast for WebCore::CachedImage
3610 <http://webkit.org/b/127967>
3612 Reviewed by Darin Adler.
3615 (+[WebCache imageForURL:]):
3616 - Use WebCore::toCachedImage().
3618 2014-01-30 David Kilzer <ddkilzer@apple.com>
3620 De-virtual-ize CachedResource::isImage()
3621 <http://webkit.org/b/127936>
3623 Reviewed by Andreas Kling.
3625 Also replace explicit type() checks with isImage().
3628 (+[WebCache imageForURL:]): Use !isImage().
3630 2014-01-30 Beth Dakin <bdakin@apple.com>
3632 https://bugs.webkit.org/show_bug.cgi?id=127371
3633 Explore new API that could be used to help build infinitely scrolling websites
3635 <rdar://problem/15244768>
3637 Reviewed by Sam Weinig.
3639 FrameView::scrollPositionChangedViaPlatformWidget() now take two parameters
3640 representing the old scroll position and the new position.
3641 * WebView/WebHTMLView.mm:
3642 (-[WebHTMLView _frameOrBoundsChanged]):
3644 2014-01-30 Andrei Bucur <abucur@adobe.com>
3646 Remove the ACCELERATED_COMPOSITING flag
3647 https://bugs.webkit.org/show_bug.cgi?id=127833
3649 Reviewed by Antti Koivisto.
3651 Remove the USE(ACCELERATED_COMPOSITING) conditionals from the code base and make AC
3654 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3655 (-[WebHostedNetscapePluginView createPlugin]):
3656 (-[WebHostedNetscapePluginView createPluginLayer]):
3657 * Plugins/WebNetscapePluginView.mm:
3658 (-[WebNetscapePluginView createPlugin]):
3659 (-[WebNetscapePluginView getVariable:value:]):
3660 * Plugins/WebPluginController.mm:
3661 (-[WebPluginController superlayerForPluginView:]):
3662 * WebCoreSupport/WebChromeClient.h:
3663 (WebChromeClient::allowedCompositingTriggers):
3664 * WebCoreSupport/WebChromeClient.mm:
3665 * WebCoreSupport/WebFrameLoaderClient.mm:
3666 (PluginWidgetIOS::detachPluginLayer):
3667 (NetscapePluginWidget::platformLayer):
3668 * WebView/WebClipView.mm:
3669 (-[WebClipView _immediateScrollToPoint:]):
3670 * WebView/WebHTMLView.mm:
3671 (setNeedsDisplayInRect):
3672 (+[WebHTMLViewPrivate initialize]):
3673 (-[WebHTMLViewPrivate clear]):
3674 (-[WebHTMLView _setAsideSubviews]):
3675 (-[WebHTMLView hitTest:]):
3676 (-[WebHTMLView _isUsingAcceleratedCompositing]):
3677 (-[WebHTMLView _compositingLayersHostingView]):
3678 (-[WebHTMLView viewDidMoveToSuperview]):
3679 (-[WebHTMLView drawRect:]):
3680 * WebView/WebHTMLViewInternal.h:
3681 * WebView/WebRenderLayer.mm:
3682 (+[WebRenderLayer compositingInfoForLayer:]):
3683 * WebView/WebView.mm:
3684 (-[WebView _close]):
3685 (-[WebView _setMediaLayer:forPluginView:]):
3686 (-[WebView _postsAcceleratedCompositingNotifications]):
3687 (-[WebView _setPostsAcceleratedCompositingNotifications:]):
3688 (-[WebView _isUsingAcceleratedCompositing]):
3689 (-[WebView _isSoftwareRenderable]):
3691 * WebView/WebViewData.h:
3692 * WebView/WebViewData.mm:
3693 (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
3694 * WebView/WebViewInternal.h:
3696 2014-01-29 Csaba Osztrogonác <ossy@webkit.org>
3698 Remove ENABLE(JAVASCRIPT_DEBUGGER) leftovers
3699 https://bugs.webkit.org/show_bug.cgi?id=127845
3701 Reviewed by Joseph Pecoraro.
3703 * Configurations/FeatureDefines.xcconfig:
3705 2014-01-29 Dan Bernstein <mitz@apple.com>
3707 Moved linking against common frameworks and a library from the .xcconfig file into the target.
3709 Reviewed by Tim Horton.
3711 * Configurations/WebKit.xcconfig:
3713 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
3715 checkTextOfParagraph releases NSString twice
3716 https://bugs.webkit.org/show_bug.cgi?id=127881
3717 <rdar://problem/15937446>
3719 Reviewed by Anders Carlsson.
3721 textString is released once by an explicit call to release and again by it going out of scope.
3722 Don't do the explicit release.
3724 The bug was spotted by Sam Weinig.
3726 * WebCoreSupport/WebEditorClient.mm:
3727 (WebEditorClient::checkTextOfParagraph):
3729 2014-01-29 Anders Carlsson <andersca@apple.com>
3733 * WebView/WebPDFView.mm:
3734 (_applicationInfoForMIMEType):
3736 2014-01-28 Mark Rowe <mrowe@apple.com>
3738 <https://webkit.org/b/127767> Disable some deprecation warnings to fix the build.
3740 Reviewed by Ryosuke Niwa.
3742 * WebCoreSupport/PopupMenuMac.mm:
3743 (PopupMenuMac::populate):
3745 2014-01-27 Joseph Pecoraro <pecoraro@apple.com>
3747 WebKit1: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
3748 https://bugs.webkit.org/show_bug.cgi?id=127664
3750 Reviewed by Darin Adler.
3752 * Configurations/Base.xcconfig:
3753 * History/BinaryPropertyList.cpp:
3754 (BinaryPropertyListSerializer::appendObjectReference):
3755 (BinaryPropertyListSerializer::startObject):
3756 (BinaryPropertyListSerializer::addAggregateObjectReference):
3757 * WebView/WebPDFView.mm:
3758 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3760 2014-01-27 Andy Estes <aestes@apple.com>
3762 Scrub WebKit API headers of WTF macros
3763 https://bugs.webkit.org/show_bug.cgi?id=127706
3765 Reviewed by David Kilzer.
3767 * Configurations/FeatureDefines.xcconfig: Added ENABLE_INSPECTOR.
3768 * WebView/WebPreferenceKeysPrivate.h: Changed ENABLE(REMOTE_INSPECTOR)
3769 to !defined(ENABLE_REMOTE_INSPECTOR) || ENABLE_REMOTE_INSPECTOR. We are
3770 in a TARGET_OS_IPHONE block, and ENABLE_REMOTE_INSPECTOR is enabled by
3771 default on iOS, so include this block unless the feature is explicitly
3773 * postprocess-headers.sh: Stopped processing ENABLE_IOS_TOUCH_EVENTS
3774 and ENABLE_IOS_GESTURE_EVENTS. These are now defined in DOMEvents.h.
3776 2014-01-27 Tim Horton <timothy_horton@apple.com>
3778 Another iOS build fix.
3780 * Misc/WebElementDictionary.mm:
3781 (-[WebElementDictionary _image]):
3782 We were apparently depending on Image::getNSImage() being defined
3783 (yet always returning nullptr) on iOS.
3785 2014-01-26 David Kilzer <ddkilzer@apple.com>
3787 Remove duplicate settings for ENABLE(DISK_IMAGE_CACHE)
3788 <http://webkit.org/b/127669>
3790 Reviewed by Joseph Pecoraro.
3792 * WebView/WebPreferences.mm:
3793 (+[WebPreferences initialize]): Remove duplicate code.
3795 2014-01-24 Andy Estes <aestes@apple.com>
3797 [iOS] Upstream changes in Tools/DumpRenderTree
3798 https://bugs.webkit.org/show_bug.cgi?id=127412
3800 Reviewed by Simon Fraser.
3802 * Misc/WebCoreStatistics.h: Included CGContext.h.
3804 2014-01-26 Anders Carlsson <andersca@apple.com>
3806 Move history item visit count handling to WebKit
3807 https://bugs.webkit.org/show_bug.cgi?id=127659
3809 Reviewed by Dan Bernstein.
3811 Move code to deal with visit count and visit dates here from WebCore.
3813 * History/HistoryPropertyList.mm:
3814 (HistoryPropertyListWriter::writeHistoryItem):
3815 * History/WebHistoryItem.mm:
3816 (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
3817 (-[WebHistoryItem copyWithZone:]):
3818 (-[WebHistoryItem lastVisitedTimeInterval]):
3819 (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
3820 (-[WebHistoryItem setVisitCount:]):
3821 (-[WebHistoryItem _mergeAutoCompleteHints:]):
3822 (-[WebHistoryItem initFromDictionaryRepresentation:]):
3823 (-[WebHistoryItem _visitedWithTitle:increaseVisitCount:]):
3824 (-[WebHistoryItem _recordInitialVisit]):
3826 (-[WebHistoryItem _padDailyCountsForNewVisit:]):
3827 (-[WebHistoryItem _collapseDailyVisitsToWeekly]):
3828 (-[WebHistoryItem _recordVisitAtTime:increaseVisitCount:]):
3829 (-[WebHistoryItem _setLastVisitedTimeInterval:]):
3830 * History/WebHistoryItemInternal.h:
3832 2014-01-26 Anders Carlsson <andersca@apple.com>
3836 Pass a WebHistoryItem to writeHistoryItem so we can extract _lastVisitWasHTTPNonGet from it.
3838 * History/HistoryPropertyList.h:
3839 * History/HistoryPropertyList.mm:
3840 (HistoryPropertyListWriter::HistoryPropertyListWriter):
3841 (HistoryPropertyListWriter::buffer):
3842 (HistoryPropertyListWriter::releaseData):
3843 (HistoryPropertyListWriter::writeObjects):
3844 (HistoryPropertyListWriter::writeHistoryItem):
3845 * History/WebHistory.mm:
3846 (WebHistoryWriter::writeHistoryItems):
3847 * History/WebHistoryItem.mm:
3849 2014-01-26 Anders Carlsson <andersca@apple.com>
3851 Move lastVisitWasHTTPNonGet out to WebHistoryItem
3852 https://bugs.webkit.org/show_bug.cgi?id=127657
3854 Reviewed by Dan Bernstein.
3856 Keep track of _lastVisitWasHTTPNonGet inside WebHistoryItem.
3858 * History/WebHistory.mm:
3859 (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
3860 Set entry->_private->_lastVisitWasHTTPNonGet.
3862 * History/WebHistoryItem.h:
3863 Change @private to @package so we can get at WebHistoryItemPrivate from WebHistory.
3865 * History/WebHistoryItem.mm:
3866 (-[WebHistoryItem copyWithZone:]):
3867 Assign _private->_lastVisitWasHTTPNonGet.
3869 (-[WebHistoryItem initFromDictionaryRepresentation:]):
3870 Set _private->_lastVisitWasHTTPNonGet.
3872 * History/WebHistoryItemInternal.h:
3873 Move WebHistoryItemPrivate interface here.
3875 2014-01-26 Anders Carlsson <andersca@apple.com>
3877 Turn WebHistoryItemPrivate back into a real Objective-C class
3878 https://bugs.webkit.org/show_bug.cgi?id=127653
3880 Reviewed by Sam Weinig.
3882 This is a first step towards moving some history specific code from WebCore::HistoryItem back into WebKit.
3884 * History/WebHistoryItem.mm:
3885 (-[WebHistoryItem dealloc]):
3886 (-[WebHistoryItem finalize]):
3887 (-[WebHistoryItem initWithWebCoreHistoryItem:]):
3889 2014-01-25 Sam Weinig <sam@webkit.org>
3891 Remove unused support for DRAGGABLE_REGION
3892 https://bugs.webkit.org/show_bug.cgi?id=127642
3894 Reviewed by Simon Fraser.
3896 * Configurations/FeatureDefines.xcconfig:
3898 2014-01-25 Anders Carlsson <andersca@apple.com>
3900 Remove an unused FrameLoaderClient function
3901 https://bugs.webkit.org/show_bug.cgi?id=127628
3903 Reviewed by Andreas Kling.
3905 * WebCoreSupport/WebFrameLoaderClient.h:
3906 * WebCoreSupport/WebFrameLoaderClient.mm:
3908 2014-01-25 Anders Carlsson <andersca@apple.com>
3912 * WebView/WebViewData.h:
3914 2014-01-25 Anders Carlsson <andersca@apple.com>
3916 Get rid of BackForwardController::isActive()
3917 https://bugs.webkit.org/show_bug.cgi?id=127604
3919 Reviewed by Sam Weinig.
3921 * WebCoreSupport/WebFrameLoaderClient.mm:
3922 (WebFrameLoaderClient::canCachePage):
3923 Move isActive logic here.
3925 2014-01-24 Anders Carlsson <andersca@apple.com>
3927 Remove back/forward list related functions from Page
3928 https://bugs.webkit.org/show_bug.cgi?id=127596
3930 Reviewed by Andreas Kling.
3932 * WebView/WebFrameView.mm:
3933 (-[WebFrameView keyDown:keyDown:]):
3934 * WebView/WebView.mm:
3935 (-[WebView _loadBackForwardListFromOtherView:]):
3936 (-[WebView initWithCoder:]):
3937 (-[WebView encodeWithCoder:]):
3938 (-[WebView backForwardList]):
3939 (-[WebView setMaintainsBackForwardList:]):
3940 (-[WebView goBack]):
3941 (-[WebView goForward]):
3942 (-[WebView canGoBack]):
3943 (-[WebView canGoForward]):
3945 2014-01-24 Anders Carlsson <andersca@apple.com>
3947 Get rid of monotonicallyIncreasingTimeMS and start using std::chrono instead
3948 https://bugs.webkit.org/show_bug.cgi?id=127571
3950 Reviewed by Antti Koivisto.
3952 * WebView/WebView.mm:
3953 (-[WebView _preferencesChanged:]):
3954 Convert the layout interval to std::chrono::milliseconds.
3956 2014-01-24 Zan Dobersek <zdobersek@igalia.com>
3958 Move HistoryItem to std::unique_ptr
3959 https://bugs.webkit.org/show_bug.cgi?id=127275
3961 Reviewed by Darin Adler.
3963 * History/WebHistoryItem.mm: The Vector object that's passed to HistoryItem::setRedirectURLs
3964 should now be handled by std::unique_ptr and passed on through move semantics.
3965 (-[WebHistoryItem initFromDictionaryRepresentation:]):
3967 2014-01-23 Joseph Pecoraro <pecoraro@apple.com>
3969 Move RegularExpression into JavaScriptCore for inspector
3970 https://bugs.webkit.org/show_bug.cgi?id=127526
3972 Reviewed by Geoffrey Garen.
3974 * WebView/WebHTMLRepresentation.mm:
3976 2014-01-23 Benjamin Poulain <bpoulain@apple.com>
3978 Remote Inspector uses the Page pointer before the page is created on iOS
3979 https://bugs.webkit.org/show_bug.cgi?id=127534
3981 Reviewed by Joseph Pecoraro.
3983 * WebView/WebView.mm:
3984 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3986 2014-01-23 Jon Honeycutt <jhoneycutt@apple.com>
3988 Assertion failure in WebCore::PseudoElement::didRecalcStyle()
3989 <https://bugs.webkit.org/show_bug.cgi?id=126761>
3990 <rdar://problem/15793540>
3992 Some areas of code were erroneously checking the value of
3993 RenderObject::isImage() rather than RenderObject::isRenderImage()
3994 before casting the object to RenderImage.
3996 This could lead to an assertion failure for RenderListMarkers, which
3997 may return true for isImage(), but are not RenderImages.
3999 Reviewed by Andy Estes.
4001 * Misc/WebNSPasteboardExtras.mm:
4002 (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
4003 Check isRenderImage() rather than isImage() before casting to
4006 2014-01-23 Joseph Pecoraro <pecoraro@apple.com>
4008 Web Inspector: Remove recompileAllJSFunctions timer in ScriptDebugServer
4009 https://bugs.webkit.org/show_bug.cgi?id=127409
4011 Reviewed by Geoffrey Garen.
4013 * WebCoreSupport/WebInspectorClient.mm:
4014 (-[WebInspectorWindowController destroyInspectorView:]):
4015 Include InspectorDisconnectReason.
4017 2014-01-23 Max Vujovic <mvujovic@adobe.com>
4019 Remove CSS Custom Filters code and tests
4020 https://bugs.webkit.org/show_bug.cgi?id=127382
4022 Reviewed by Simon Fraser.
4024 * Configurations/FeatureDefines.xcconfig:
4025 * WebView/WebPreferenceKeysPrivate.h:
4026 * WebView/WebPreferences.mm:
4027 (+[WebPreferences initialize]):
4028 * WebView/WebPreferencesPrivate.h:
4029 * WebView/WebView.mm:
4030 (-[WebView _preferencesChanged:]):
4032 2014-01-22 Myles C. Maxfield <mmaxfield@apple.com>
4034 Remove CSS3_TEXT_DECORATION define
4035 https://bugs.webkit.org/show_bug.cgi?id=127333
4037 Reviewed by Simon Fraser.
4039 This is required for unprefixing the text-decoration-* CSS properties.
4041 * Configurations/FeatureDefines.xcconfig:
4043 2014-01-22 Dan Bernstein <mitz@apple.com>
4045 Build fix for iOS clients of WebUIDelegatePrivate.h.
4047 * WebView/WebUIDelegatePrivate.h: Ensure that ENABLE_DASHBOARD_SUPPORT is defined on iOS.
4049 2014-01-21 Dan Bernstein <mitz@apple.com>
4051 Added a method declaration that was missed in r161185.
4053 Reviewed by Sam Weinig.
4055 * WebView/WebViewPrivate.h: Declared -removeVisitedLink:.
4057 2014-01-21 Commit Queue <commit-queue@webkit.org>
4059 Unreviewed, rolling out r162452.
4060 http://trac.webkit.org/changeset/162452
4061 https://bugs.webkit.org/show_bug.cgi?id=127366
4063 broke a few tests on all Mac WebKit1 bots (Requested by
4064 thorton on #webkit).
4066 * WebView/WebView.mm:
4067 (-[WebView _windowWillOrderOnScreen:]):
4068 (-[WebView _windowWillOrderOffScreen:]):
4070 2014-01-21 Gavin Barraclough <barraclough@apple.com>
4072 Change Page, FocusController to use ViewState
4073 https://bugs.webkit.org/show_bug.cgi?id=126533
4075 Reviewed by Tim Horton.
4077 These classes currently maintain a set of separate fields to represent the view state;
4078 combine these into a single field, and allow WebPage to send the combined update rather
4079 than individual changes.
4081 Maintain existing interface for WebKit1 clients.
4083 * WebView/WebView.mm:
4084 (-[WebView _windowWillOrderOnScreen:]):
4085 (-[WebView _windowWillOrderOffScreen:]):
4086 - remove calls to FocusController::setContentIsVisible, these are redundant
4087 (this is handled when page visibility is set).
4089 2014-01-20 Jeremy Jones <jeremyj@apple.com>
4091 Add AVKit fullscreen video interface.
4092 https://bugs.webkit.org/show_bug.cgi?id=126818
4094 Reviewed by Eric Carlson.
4096 * WebCoreSupport/WebChromeClient.h:
4097 * WebCoreSupport/WebChromeClient.mm:
4098 (WebChromeClient::supportsFullscreenForNode):
4099 Enable *FullscreenForNode for HTMLMediaElement for iOS
4101 * WebView/WebPreferenceKeysPrivate.h:
4102 * WebView/WebPreferences.mm:
4103 (+[WebPreferences initialize]):
4104 (-[WebPreferences mediaPlaybackFullscreenAVKit]):
4105 (-[WebPreferences setMediaPlaybackFullscreenAVKit:]):
4106 * WebView/WebPreferencesPrivate.h:
4107 * WebView/WebView.mm:
4108 (-[WebView _preferencesChanged:]):
4109 (-[WebView _enterFullscreenForNode:WebCore::]):
4110 * WebView/WebViewInternal.h:
4111 Add a disabled pref mediaPlaybackFullscreenAVKit.
4112 Use WebVideoFullscreenControllerAVKit on iOS
4114 2014-01-18 Brian Burg <bburg@apple.com>
4116 Web Inspector: Page should use std::unique_ptr for InspectorController
4117 https://bugs.webkit.org/show_bug.cgi?id=127068
4119 Reviewed by Joseph Pecoraro.
4121 Convert call sites to use a InspectorController reference.
4122 Convert instantiations of InspectorFrontendClient to use std::unique_ptr.
4124 * WebCoreSupport/WebInspectorClient.mm:
4125 (WebInspectorClient::openInspectorFrontend):
4126 (-[WebInspectorWindowController destroyInspectorView:]):
4127 * WebInspector/WebInspector.mm:
4128 (-[WebInspector showWindow]):
4129 (-[WebInspector isJavaScriptProfilingEnabled]):
4130 (-[WebInspector setJavaScriptProfilingEnabled:]):
4131 (-[WebInspector close:]):
4132 (-[WebInspector evaluateInFrontend:callId:script:]):
4133 * WebInspector/WebNodeHighlighter.mm:
4134 (-[WebNodeHighlighter highlight]):
4136 2014-01-18 Anders Carlsson <andersca@apple.com>
4138 Remove ENABLE_THREADED_HTML_PARSER defines everywhere
4139 https://bugs.webkit.org/show_bug.cgi?id=127225
4141 Reviewed by Andreas Kling.
4143 This concludes the removal of over 8.8 million lines of threaded parser code.
4145 * Configurations/FeatureDefines.xcconfig:
4147 2014-01-17 Anders Carlsson <andersca@apple.com>
4149 Clean up PageCache classes
4150 https://bugs.webkit.org/show_bug.cgi?id=127202
4152 Reviewed by Andreas Kling.
4154 * WebCoreSupport/WebFrameLoaderClient.mm:
4155 (WebFrameLoaderClient::savePlatformDataToCachedFrame):
4156 (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
4158 2014-01-17 Anders Carlsson <andersca@apple.com>
4160 Remove another unused FrameLoaderClient callback
4161 https://bugs.webkit.org/show_bug.cgi?id=127192
4163 Reviewed by Dan Bernstein.
4165 * WebCoreSupport/WebFrameLoaderClient.h:
4166 * WebCoreSupport/WebFrameLoaderClient.mm:
4168 2014-01-17 Anders Carlsson <andersca@apple.com>
4170 Move didPerformFirstNavigation() logic to -[WebView _didCommitLoadForFrame:]
4171 https://bugs.webkit.org/show_bug.cgi?id=127189
4173 Reviewed by Dan Bernstein.
4175 This is a first step towards completely eliminating the didPerformFirstNavigation() client callback.
4177 * WebCoreSupport/WebFrameLoaderClient.h:
4178 * WebCoreSupport/WebFrameLoaderClient.mm:
4179 Remove didPerformFirstNavigation() implementation.
4181 * WebView/WebView.mm:
4182 (-[WebView _checkDidPerformFirstNavigation]):
4183 Check if we have both a current item and a previous item which indicates that we've navigated once.
4184 The old code was called before there was a current item but since this is called from _didCommitLoadForFrame
4185 we have to check that there's a current item as well.
4187 (-[WebView _didCommitLoadForFrame:]):
4188 Call _didCommitLoadForFrame.
4190 * WebView/WebViewData.h:
4193 2014-01-17 Alexey Proskuryakov <ap@apple.com>
4197 * WebView/WebPreferences.mm: (-[WebPreferences _synchronizeWebStoragePolicyWithCookiePolicy]):
4198 NSHTTPCookieAcceptPolicyExclusivelyFromMainDocumentDomain is not part of NSHTTPCookieAcceptPolicy enum.
4200 2014-01-16 Daniel Bates <dabates@apple.com>
4202 [iOS] MobileSafari build fix. Declare iOS-specific method mainFrameIconURL
4204 For now, add mainFrameIconURL() to WebView.h. We should further investigate its
4205 usage and API/SPI status.
4207 * WebView/WebView.h:
4209 2014-01-16 Alexey Proskuryakov <ap@apple.com>
4211 [Mac] [iOS] Add support for CFHTTPCookieStorageAcceptPolicyExclusivelyFromMainDocumentDomain
4212 https://bugs.webkit.org/show_bug.cgi?id=127139
4214 Reviewed by Brady Eidson.
4216 * WebView/WebPreferences.mm: (-[WebPreferences _synchronizeWebStoragePolicyWithCookiePolicy]):
4217 Handle the new case.
4219 2014-01-16 Daniel Bates <dabates@apple.com>
4221 [iOS] Fix UIKit build warning about undefined macro ENABLE_NETSCAPE_PLUGIN_API
4223 * WebView/WebFramePrivate.h: Wrap use of ENABLE_NETSCAPE_PLUGIN_API in TARGET_OS_IPHONE.
4225 2014-01-16 Anders Carlsson <andersca@apple.com>
4227 Change all uses of FINAL to final now that all our compilers support it
4228 https://bugs.webkit.org/show_bug.cgi?id=127142
4230 Reviewed by Benjamin Poulain.
4232 * WebCoreSupport/WebUserMediaClient.h:
4233 * WebView/WebScriptDebugger.h:
4235 2014-01-16 Peter Molnar <pmolnar.u-szeged@partner.samsung.com>
4237 Remove workaround for compilers not supporting explicit override control
4238 https://bugs.webkit.org/show_bug.cgi?id=127111