Choose the compiler based on the Xcode version for Snow Leopard debug builds.
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2011-04-26  Dan Bernstein  <mitz@apple.com>
2
3         Reviewed by Mark Rowe.
4
5         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
6
7         * Configurations/Base.xcconfig:
8         * Configurations/CompilerVersion.xcconfig: Added.
9
10 2011-04-25  Adam Barth  <abarth@webkit.org>
11
12         Reviewed by David Levin.
13
14         WebKit2 should play nice with strict OwnPtrs
15         https://bugs.webkit.org/show_bug.cgi?id=59426
16
17         Fix include ordering.
18
19         * WebView/WebDeviceOrientationProviderMock.mm:
20
21 2011-04-25  Adam Barth  <abarth@webkit.org>
22
23         Reviewed by David Levin.
24
25         WebKit1 should build cleanly with strict OwnPtrs
26         https://bugs.webkit.org/show_bug.cgi?id=59424
27
28         * History/WebHistoryItem.mm:
29         (-[WebHistoryItem initFromDictionaryRepresentation:]):
30         * Plugins/WebNetscapePluginEventHandler.h:
31         * Plugins/WebNetscapePluginEventHandler.mm:
32         (WebNetscapePluginEventHandler::create):
33         * Plugins/WebNetscapePluginView.mm:
34         (-[WebNetscapePluginView createPlugin]):
35         * WebView/WebDeviceOrientationProviderMock.mm:
36         * WebView/WebTextIterator.mm:
37         (-[WebTextIterator initWithRange:]):
38
39 2011-04-25  Jon Lee  <jonlee@apple.com>
40
41         Reviewed by Maciej Stachowiak.
42
43         Overlay scroller hard to see on pages with dark background (59183)
44         https://bugs.webkit.org/show_bug.cgi?id=59183
45         <rdar://problem/8975367>
46         
47         * WebCoreSupport/WebSystemInterface.mm:
48         (InitWebCoreSystemInterface): adding method to allow changing style
49
50 2011-04-23  Sheriff Bot  <webkit.review.bot@gmail.com>
51
52         Unreviewed, rolling out r84740.
53         http://trac.webkit.org/changeset/84740
54         https://bugs.webkit.org/show_bug.cgi?id=59290
55
56         change breaks apple internal builds and is incorrect
57         (Requested by smfr on #webkit).
58
59         * WebCoreSupport/WebSystemInterface.mm:
60         (InitWebCoreSystemInterface):
61
62 2011-04-22  Jon Lee  <jonlee@apple.com>
63
64         Reviewed by Beth Dakin.
65
66         Overlay scroller hard to see on pages with dark background (59183)
67         https://bugs.webkit.org/show_bug.cgi?id=59183
68         <rdar://problem/8975367>
69         
70         * WebCoreSupport/WebSystemInterface.mm:
71         (InitWebCoreSystemInterface): adding method to allow changing style
72
73 2011-04-19  Jer Noble  <jer.noble@apple.com>
74
75         Reviewed by Daniel Bates.
76
77         Full Screen from within an <iframe> does not cause <iframe> to resize.
78         https://bugs.webkit.org/show_bug.cgi?id=58638
79
80         Tests: fullscreen/full-screen-frameset-allowed.html
81                fullscreen/full-screen-frameset-not-allowed.html
82
83         Return the _element's document instead of the WKView's document, which 
84         will be different in the case of elements within <iframe>s.
85
86         * WebView/WebFullScreenController.mm:
87         (-[WebFullScreenController _document]):
88
89 2011-04-22  Jer Noble  <jer.noble@apple.com>
90
91         Reviewed by Maciej Stachowiak.
92
93         Disable MediaPlayerPrivateAVFoundation when using old full screen mode.
94         https://bugs.webkit.org/show_bug.cgi?id=59147
95
96         Add a new user default preference, and plumb that preference down to WebCore
97         Settings. Allow the fullScreenEnabled preference to override the new 
98         isAVFoundationEnabled preference, so that clients of the legacy full screen
99         mode will continue to use that mode normally.
100
101         * WebView/WebPreferenceKeysPrivate.h: Add new preference key.
102         * WebView/WebPreferences.mm:
103         (+[WebPreferences initialize]): Set the default value of new
104             preference.
105         (-[WebPreferences setAVFoundationEnabled:]): Added.
106         (-[WebPreferences isAVFoundationEnabled]): Added.
107         * WebView/WebPreferencesPrivate.h:
108         * WebView/WebView.mm:
109         (-[WebView _preferencesChanged:]): Update the WebCore settings with the
110             new values from WebPreferences.
111
112 2011-04-22  Sam Weinig  <sam@webkit.org>
113
114         Reviewed by Gavin Barraclough.
115
116         Remove remaining uses of deprecated version of toJS
117         https://bugs.webkit.org/show_bug.cgi?id=59170
118
119         * DOM/WebDOMOperations.mm:
120         (-[DOMElement _shadowRoot:]):
121         (-[DOMElement _ensureShadowRoot:]):
122         Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
123
124 2011-04-21  Maciej Stachowiak  <mjs@apple.com>
125
126         Reviewed by Adam Roben.
127
128         Add a feature define to allow <details> and <summary> to be disabled
129         https://bugs.webkit.org/show_bug.cgi?id=59118
130         <rdar://problem/9257045>
131
132         * Configurations/FeatureDefines.xcconfig:
133
134 2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
135
136         Reviewed by Sam Weinig.
137
138         Add Frame* to the argument lists of canCopyCut and canPaste
139         https://bugs.webkit.org/show_bug.cgi?id=59153
140
141         * WebCoreSupport/WebEditorClient.h:
142         * WebCoreSupport/WebEditorClient.mm:
143         (WebEditorClient::canCopyCut):
144         (WebEditorClient::canPaste):
145
146 2011-04-21  Sheriff Bot  <webkit.review.bot@gmail.com>
147
148         Unreviewed, rolling out r82052.
149         http://trac.webkit.org/changeset/82052
150         https://bugs.webkit.org/show_bug.cgi?id=59135
151
152         New full screen api should be opt-in, not opt-out. (Requested
153         by jernoble on #webkit).
154
155         * WebView/WebPreferences.mm:
156         (+[WebPreferences initialize]):
157
158 2011-04-21  Beth Dakin  <bdakin@apple.com>
159
160         Reviewed by Dan Bernstein.
161
162         https://bugs.webkit.org/show_bug.cgi?id=59048
163         Need to track whether overlay scrollbar is currently visible and in lower-
164         righthand corner
165         -and corresponding-
166         <rdar://problem/9211232>
167
168         A new WebSystemInterface is needed for this.
169         * WebCoreSupport/WebSystemInterface.mm:
170         (InitWebCoreSystemInterface):
171
172 2011-04-21  Dirk Schulze  <krit@webkit.org>
173
174         Reviewed by Nikolas Zimmermann.
175
176         SVG feDropShadow implementation of SVG Filters 1.2
177         https://bugs.webkit.org/show_bug.cgi?id=52513
178
179         * MigrateHeaders.make:
180
181 2011-04-20  Dominic Cooney  <dominicc@chromium.org>
182
183         Reviewed by Dimitri Glazkov.
184
185         layoutTestController can create and destroy shadow DOM
186         https://bugs.webkit.org/show_bug.cgi?id=59058
187
188         Support for new methods in Mac DRT.
189
190         * DOM/WebDOMOperations.mm:
191         (-[DOMElement _ensureShadowRoot:]):
192         (-[DOMElement _removeShadowRoot]):
193         * DOM/WebDOMOperationsPrivate.h:
194
195 2011-04-20  Eric Carlson  <eric.carlson@apple.com>
196
197         Reviewed by Dan Bernstein.
198
199         Adopt QTKit API for listing and deleting file in its media cache.
200         <rdar://problem/9130029> 
201
202         * WebCoreSupport/WebSystemInterface.mm:
203         (InitWebCoreSystemInterface): Initialize new functions.
204
205 2011-04-19  Matthew Delaney  <mdelaney@apple.com>
206
207         Reviewed by Simon Fraser.
208
209         WebPreferences in WebKit1 should have CanvasUsesAcceleratedDrawing set to NO by default
210         https://bugs.webkit.org/show_bug.cgi?id=58936
211
212         * WebView/WebPreferences.mm:
213         (+[WebPreferences initialize]):
214
215 2011-04-19  Vsevolod Vlasov  <vsevik@chromium.org>
216
217         Reviewed by Pavel Feldman.
218
219         Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
220         https://bugs.webkit.org/show_bug.cgi?id=58883
221
222         * WebCoreSupport/WebFrameLoaderClient.h:
223         * WebCoreSupport/WebFrameLoaderClient.mm:
224         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
225
226 2011-04-18  Jia Pu  <jpu@apple.com>
227
228         Reviewed by Mark Rowe.
229
230         WebKit needs to stop importing <AppKit/NSTextChecker.h>
231         https://bugs.webkit.org/show_bug.cgi?id=58798
232         <rdar://problem/9294938>
233
234         Use public header <AppKit/NSSpellChecker.h> instead.
235
236         * WebCoreSupport/CorrectionPanel.h:
237         * WebCoreSupport/CorrectionPanel.mm:
238         (correctionIndicatorType):
239         (CorrectionPanel::show):
240         (CorrectionPanel::dismissInternal):
241         (CorrectionPanel::handleAcceptedReplacement):
242         * WebCoreSupport/WebEditorClient.mm:
243         * WebView/WebView.mm:
244
245 2011-04-17  Cameron Zwarich  <zwarich@apple.com>
246
247         Reviewed by Timothy Hatcher.
248
249         Stop using -[NSString initWithContentsOfFile:]
250         https://bugs.webkit.org/show_bug.cgi?id=58763
251
252         -[NSString initWithContentsOfFile:] was deprecated in 10.4, so we should stop using it.
253
254         * WebView/WebView.mm:
255         (leakMailQuirksUserScriptContents):
256         (leakOutlookQuirksUserScriptContents):
257
258 2011-04-17  David Kilzer  <ddkilzer@apple.com>
259
260         <http://webkit.org/b/58463> Switch HTTP pipelining from user default to private setting
261         <rdar://problem/9268729>
262
263         Reviewed by Dan Bernstein.
264
265         This replaces support for the WebKitEnableHTTPPipelining user
266         default with methods on the WebCore::ResourceRequest class in
267         WebCore, the WebView class in WebKit1, and the WebContext class
268         in WebKit2.  It also removes support for the
269         WebKitForceHTTPPipeliningPriorityHigh user default which was not
270         needed.
271
272         * WebView/WebView.mm:
273         (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added.
274         (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added.
275         * WebView/WebViewPrivate.h:
276         (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added declaration.
277         (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added declaration.
278
279 2011-04-17  Joseph Pecoraro  <joepeck@webkit.org>
280
281         Reviewed by Dan Bernstein.
282
283         Assign to self in WebInspectorWindowController constructors
284         https://bugs.webkit.org/show_bug.cgi?id=58749
285
286         * WebCoreSupport/WebInspectorClient.mm:
287         (-[WebInspectorWindowController init]):
288         (-[WebInspectorWindowController initWithInspectedWebView:]):
289
290 2011-04-17  Joseph Pecoraro  <joepeck@webkit.org>
291
292         Reviewed by Timothy Hatcher.
293
294         Move WebNodeHighlighter into its own file
295         https://bugs.webkit.org/show_bug.cgi?id=58746
296
297         Extract this class into its own file alongside the
298         other WebNodeHighlight files. In doing so do some
299         cleanup on WebInspectorClient removing some methods
300         that were never called.
301
302         * WebCoreSupport/WebInspectorClient.mm:
303         (WebInspectorClient::WebInspectorClient): style fix.
304         * WebInspector/WebNodeHighlighter.h: Added.
305         * WebInspector/WebNodeHighlighter.mm: Added.
306         (-[WebNodeHighlighter initWithInspectedWebView:]): call super init.
307         (-[WebNodeHighlighter dealloc]):
308         (-[WebNodeHighlighter highlightNode:]):
309         (-[WebNodeHighlighter hideHighlight]):
310         (-[WebNodeHighlighter didAttachWebNodeHighlight:]):
311         (-[WebNodeHighlighter willDetachWebNodeHighlight:]):
312
313 2011-04-15  Jia Pu  <jpu@apple.com>
314
315         Reviewed by Dan Bernstein.
316
317         [Mac] WebKit needs to convert the bounding box of autocorrected word to view coordinate.
318         https://bugs.webkit.org/show_bug.cgi?id=58717
319
320         Convert the bounding box from window coordinate to view coordinate, which is expected by NSCorrectionPanel.
321
322         * WebCoreSupport/CorrectionPanel.mm:
323         (CorrectionPanel::show):
324
325 2011-04-15  Shishir Agrawal  <shishir@chromium.org>
326
327         Reviewed by James Robinson.
328
329         Add a flag to guard Page Visibility API changes.
330         https://bugs.webkit.org/show_bug.cgi?id=58464
331
332         * Configurations/FeatureDefines.xcconfig:
333
334 2011-04-15  Oliver Hunt  <oliver@apple.com>
335
336         GC allocate Structure
337         https://bugs.webkit.org/show_bug.cgi?id=58483
338
339         Rolling r83894 r83827 r83810 r83809 r83808 back in with
340         a workaround for the gcc bug seen by the gtk bots
341
342         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
343         * Plugins/Hosted/ProxyInstance.mm:
344         (WebKit::ProxyRuntimeMethod::createStructure):
345         * Plugins/Hosted/ProxyRuntimeObject.h:
346         (WebKit::ProxyRuntimeObject::createStructure):
347
348 2011-04-14  Alexey Proskuryakov  <ap@apple.com>
349
350         Reviewed by Dan Bernstein.
351
352         WebKit2: Password field input does not switch to ASCII-compatible source
353         https://bugs.webkit.org/show_bug.cgi?id=58583
354         <rdar://problem/9059651>
355
356         Now that WebCore doesn't set secure input mode, WebKit has to. Happily, it already has the
357         necessary logic, needed to return a nil text input context when in password fields.
358
359         * WebView/WebHTMLView.mm:
360         (-[WebHTMLView close]): If the view is still enforcing secure event mode, stop.
361         (-[WebHTMLView windowDidBecomeKey:]): Call _updateSecureInputState.
362         (-[WebHTMLView windowDidResignKey:]): Ditto.
363         (-[WebHTMLView becomeFirstResponder]): Call _updateSecureInputState. It's a bit tricky
364         because the first responder is still different an this point, so set a boolean variable to
365         let _updateSecureInputState know what's going on.
366         (-[WebHTMLView resignFirstResponder]): Disable secure event mode if it's on.
367         (-[WebHTMLView _updateSecureInputState]): Update HIToolbox secure event input state and
368         allowed input sources accorsing to current selection.
369         (-[WebHTMLView _updateSelectionForInputManager]): Call _updateSecureInputState.
370
371 2011-04-15  Sam Weinig  <sam@webkit.org>
372
373         Reviewed by Maciej Stachowiak.
374
375         Make mac WebKit1 use the default localization strategy
376         https://bugs.webkit.org/show_bug.cgi?id=58628
377
378         * WebCoreSupport/WebPlatformStrategies.h:
379         * WebCoreSupport/WebPlatformStrategies.mm:
380         Remove the localization strategy code. The equivalent is now
381         in WebCore/platform/DefaultLocalizationStrategy.cpp.
382
383 2011-04-15  Anna Cavender  <annacc@chromium.org>
384
385         Reviewed by Eric Carlson.
386
387         Renaming TRACK feature define to VIDEO_TRACK
388         https://bugs.webkit.org/show_bug.cgi?id=53556
389
390         * Configurations/FeatureDefines.xcconfig:
391
392 2011-04-14  Pratik Solanki  <psolanki@apple.com>
393
394         Reviewed by David Kilzer.
395
396         Set minimum priority for fast lane connections
397         https://bugs.webkit.org/show_bug.cgi?id=58353
398
399         * WebCoreSupport/WebSystemInterface.mm:
400         (InitWebCoreSystemInterface): Support for new WKSI method WKSetHTTPPipeliningMinimumFastLanePriority.
401
402 2011-04-13  Sam Weinig  <sam@webkit.org>
403
404         Reviewed by Gavin Barraclough.
405
406         WebKit2 doesn't keep overlay scrollers shown while scroll gesture held
407         <rdar://problem/9260518>
408
409         * WebCoreSupport/WebSystemInterface.mm:
410         (InitWebCoreSystemInterface):
411         Initialize new WKSI functions.
412
413 2011-04-13  David Kilzer  <ddkilzer@apple.com>
414
415         <http://webkit.org/b/58172> Fix -Wcast-align warning in WebBasePluginPackage.mm
416
417         Reviewed by Anders Carlsson.
418
419         Fixes the following warning with -Wcast-align enabled:
420
421             Source/WebKit/mac/Plugins/WebBasePluginPackage.mm:402:21:{402:21-402:93}{402:39-402:93}: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'struct fat_arch *' increases required alignment from 1 to 4 [-Werror,-Wcast-align,3]
422                          archs = (struct fat_arch*)((uint8_t*)rawData.data() + sizeof(struct fat_header));
423                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
424
425         * Plugins/WebBasePluginPackage.mm:
426         (-[WebBasePluginPackage isNativeLibraryData:]): Added
427         COMPILE_ASSERT() to make sure our pointer math is valid.
428         Removed cast to (uint8_t*) and divide sizeof(struct fat_header)
429         by sizeof(uint32_t) to fix the pointer math.  Replaced C-style
430         casts with reinterpret_cast.
431
432 2011-04-12  Enrica Casucci  <enrica@apple.com>
433
434         Reviewed by Alexey Proskuryakov.
435
436         Infinite recursion in WebHTMLView executeSavedKeypressCommands.
437         https://bugs.webkit.org/show_bug.cgi?id=58382
438         <rdar://problem/9239370>
439
440         Execution of some editing commands could trigger a call to selectedRange that
441         internally calls executeSavedKeypressCommands creating an infinite recursion.
442
443         * WebView/WebHTMLView.mm:
444         (-[WebHTMLView _executeSavedKeypressCommands]): Added a flag to avoid recursion.
445         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added flag initialization.
446
447 2011-04-12  Alice Liu  <alice.liu@apple.com>
448
449         Reviewed by Sam Weinig.
450
451         https://bugs.webkit.org/show_bug.cgi?id=58292
452         Provide new setting to allow site icon loading despite disabling automatic image loading in general.
453
454         * WebView/WebPreferenceKeysPrivate.h: Add preference key.
455         * WebView/WebPreferences.mm:
456         (+[WebPreferences initialize]): Initialize to false.
457         (-[WebPreferences setLoadsSiteIconsIgnoringImageLoadingPreference:]): Added.
458         (-[WebPreferences loadsSiteIconsIgnoringImageLoadingPreference]): Added.
459         * WebView/WebPreferencesPrivate.h: Add setter/getter definitions.
460         * WebView/WebView.mm:
461         (-[WebView _preferencesChanged:]): Add to settings that get propagated upon changes. 
462
463 2011-04-11  Alexey Proskuryakov  <ap@apple.com>
464
465         Reviewed by Maciej Stachowiak.
466
467         WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
468         https://bugs.webkit.org/show_bug.cgi?id=58175
469         <rdar://problem/9060555>
470
471         * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
472         should be changed to match WebKit2.
473
474 2011-04-06  Timothy Hatcher  <timothy@apple.com>
475
476         Fix a bug where the context menu does not show in PDF documents if there is no
477         UI delegate or the UI delegate does not respond to the context menu selector.
478
479         https://webkit.org/b/57958
480
481         Reviewed by Darin Adler.
482
483         * WebView/WebView.mm:
484         (-[WebView _menuForElement:defaultItems:]): CallUIDelegate returns nil
485         if UIDelegate is nil or doesn't respond to the selector. So check that
486         here to distinguish between using defaultMenuItems or the delegate
487         really returning nil to say "no context menu".
488
489 2011-04-11  Jer Noble  <jer.noble@apple.com>
490
491         Unreviewed; roll out unintentional change to WebFullScreenController.mm.
492
493         * WebView/WebFullScreenController.mm:
494         (-[WebFullScreenController enterFullscreen:]):
495
496 2011-04-08  Geoffrey Garen  <ggaren@apple.com>
497
498         Reviewed by Oliver Hunt.
499
500         A few heap-related renames and file moves.
501         
502         WeakGCPtr<T> => Weak<T>
503         Global<T> => Strong<T>
504         collector/ => heap/
505         collector/* => heap/*
506         runtime/WeakGCPtr.h => heap/Weak.h
507         
508         (Eventually, even more files should move into the heap directory. Like
509         Heap.h and Heap.cpp, for example.)
510
511         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
512         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
513         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
514         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
515         (WebKit::NetscapePluginInstanceProxy::evaluate):
516         * WebView/WebScriptDebugger.h:
517
518 2011-04-08  Alexey Proskuryakov  <ap@apple.com>
519
520         Reviewed by Darin Adler.
521
522         WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
523         https://bugs.webkit.org/show_bug.cgi?id=58175
524         <rdar://problem/9060555>
525
526         * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
527         should be changed to match WebKit2.
528
529 2011-04-08  Alpha Lam  <hclam@chromium.org>
530
531         Unreviewed, rolling out r83335.
532         http://trac.webkit.org/changeset/83335
533         https://bugs.webkit.org/show_bug.cgi?id=53556
534
535         GTK and QT bots are broken
536
537         * Configurations/FeatureDefines.xcconfig:
538
539 2011-04-07  Anna Cavender  <annacc@chromium.org>
540
541         Reviewed by Eric Carlson.
542
543         Setup ENABLE(TRACK) feature define
544         https://bugs.webkit.org/show_bug.cgi?id=53556
545
546         * Configurations/FeatureDefines.xcconfig:
547
548 2011-04-08  Maciej Stachowiak  <mjs@apple.com>
549
550         Reviewed by Darin Adler.
551
552         -[WebView setPreferences:] can take a lot of time if loading lots of webviews at once
553         https://bugs.webkit.org/show_bug.cgi?id=58128
554         <rdar://problem/9244553>
555         
556         The root of the problem here was an O(N^2) issue - each WebView,
557         upon having its preferences initialized, would broadcast a
558         notification that was listened to by all other WebViews sharing
559         its preferences.
560         
561         To maintain the API contract, I split the notification into two,
562         one that is for public API consumption, and the other which is for
563         internal use only. Changes that don't need to be picked up by
564         other WebViews broadcast the public notification only. And we
565         avoid WebView broadcasting a notification just to get itself to
566         update.
567
568         * Misc/WebIconDatabase.mm:
569         (-[WebIconDatabase _startUpIconDatabase]):
570         (-[WebIconDatabase _shutDownIconDatabase]):
571         * Plugins/WebBaseNetscapePluginView.mm:
572         (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
573         (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]):
574         (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
575         (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]):
576         * WebView/WebPreferences.mm:
577         (-[WebPreferences initWithIdentifier:]):
578         (-[WebPreferences _setStringValue:forKey:]):
579         (-[WebPreferences _setIntegerValue:forKey:]):
580         (-[WebPreferences _setFloatValue:forKey:]):
581         (-[WebPreferences _setBoolValue:forKey:]):
582         (-[WebPreferences _setLongLongValue:forKey:]):
583         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
584         (-[WebPreferences _postPreferencesChangedNotification]):
585         (-[WebPreferences _postPreferencesChangedAPINotification]):
586         * WebView/WebPreferencesPrivate.h:
587         * WebView/WebView.mm:
588         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
589         (-[WebView _preferencesChangedNotification:]):
590         (-[WebView _preferencesChanged:]):
591         (-[WebView setUsesPageCache:]):
592         (+[WebView initialize]):
593         (-[WebView setPreferences:]):
594         (-[WebView _keyboardUIMode]):
595         * WebView/WebViewInternal.h:
596
597 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
598
599         Revert ENABLE_TRACK patch due to compile failures.
600
601         * Configurations/FeatureDefines.xcconfig:
602
603 2011-04-07  Alexey Proskuryakov  <ap@apple.com>
604
605         Reviewed by Anders Carlsson.
606
607         REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
608         https://bugs.webkit.org/show_bug.cgi?id=58066
609         <rdar://problem/8965302>
610
611         * WebView/WebHTMLRepresentation.mm:
612         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
613         * WebView/WebHTMLView.mm:
614         (-[WebHTMLView attributedSubstringFromRange:]):
615         (-[WebHTMLView attributedString]):
616         (-[WebHTMLView selectedAttributedString]):
617         Updated for editingAttributedStringFromRange: now taking a WebCore::Range instead of DOMRange.
618
619 2011-04-07  Andy Estes  <aestes@apple.com>
620
621         Reviewed by Darin Adler.
622
623         REGRESSION (r64712): Microsoft Outlook 2011: original message contents
624         not included when replying to an email.
625         https://bugs.webkit.org/show_bug.cgi?id=57794
626         
627         Outlook populates a reply message by creating an empty WebView and
628         using DOM API to populate the WebView's empty document with content
629         from the original message. It expects the initial empty document to
630         simply be "<html></html>", and it proceeds to dynamically create and
631         append a BODY node and add the original message content as a child of
632         that node. Outlook then takes the innerHTML of the frame's first body
633         element and copies it into a *new* document that is displayed and
634         edited in the reply message window.
635         
636         Due to implementing the HTML5 tree building algorithm in r64712,
637         initial empty documents went from being "<html></html>" to being
638         "<html><head></head><body></body></html>". Outlook still dynamically
639         creates a BODY node to parent the original message content, but this
640         BODY node duplicates the one created by the tree builder. When Outlook
641         then takes the innerHTML of the first body element to populate the
642         reply message window it gets the empty body element created by the
643         parser, not the one it created with the original message content.
644         
645         Fix this by injecting a user script into the initial empty document
646         that removes the HEAD and BODY nodes created by the parser. This
647         ensures that the BODY created by Outlook is the only BODY in the
648         document.
649
650         * Misc/OutlookQuirksUserScript.js: Added.
651         * WebView/WebView.mm:
652         (leakMailQuirksUserScriptContents):
653         (-[WebView _injectMailQuirksScript]):
654         (needsOutlookQuirksScript):
655         (leakOutlookQuirksUserScriptContents):
656         (-[WebView _injectOutlookQuirksScript]):
657         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
658
659 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
660
661         Reviewed by David Levin.
662
663         Add QUOTA build flag for unified quota API
664         https://bugs.webkit.org/show_bug.cgi?id=57918
665
666         * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
667
668 2011-04-06  Robert Sesek  <rsesek@chromium.org>
669
670         Reviewed by Alexey Proskuryakov.
671
672         Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
673         https://bugs.webkit.org/show_bug.cgi?id=54969
674
675         * WebView/WebFrame.mm:
676         (-[WebFrame _convertToNSRange:]): Moved duplicated code to WebCore
677         (-[WebFrame _characterRangeAtPoint:]): Moved duplicated code to WebCore
678
679 2011-04-05  Alexey Proskuryakov  <ap@apple.com>
680
681         Reviewed by Darin Adler.
682
683         Move attributedStringFromRange down to WebCore
684         https://bugs.webkit.org/show_bug.cgi?id=57905
685
686         * Misc/WebNSAttributedStringExtras.h: Removed.
687         * Misc/WebNSAttributedStringExtras.mm: Removed.
688         * WebView/WebHTMLRepresentation.mm:
689         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
690         * WebView/WebHTMLView.mm:
691         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
692         (-[WebHTMLView attributedSubstringFromRange:]):
693         (-[WebHTMLView attributedString]):
694         (-[WebHTMLView selectedAttributedString]):
695         * WebView/WebPDFView.mm:
696         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
697
698 2011-04-04  MORITA Hajime  <morrita@google.com>
699
700         Reviewed by Ryosuke Niwa.
701
702         [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
703         https://bugs.webkit.org/show_bug.cgi?id=56085
704
705         Removed NSTextCheckingResult to SpellCheckingResult convertion, and extracted
706         NSTextCheckingResult to TextCheckingResult convertio from checkTextOfParagraph method.
707         for requestCheckingOfString method.
708         
709         * WebCoreSupport/WebEditorClient.h:
710         * WebCoreSupport/WebEditorClient.mm:
711         (toCoreTextCheckingResults):
712         (WebEditorClient::checkTextOfParagraph):
713         (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:types:WebCore::results:]):
714         (-[WebEditorSpellCheckResponder perform]):
715         (WebEditorClient::requestCheckingOfString):
716         * WebView/WebFrame.mm:
717         (-[WebFrame markersForSelectionStartAsText]):
718         * WebView/WebFramePrivate.h:
719
720 2011-04-05  Anders Carlsson  <andersca@apple.com>
721
722         Didn't mean to land this.
723
724         * Plugins/WebNetscapePluginView.mm:
725         (-[WebNetscapePluginView getVariable:value:]):
726
727 2011-04-04  David Kilzer  <ddkilzer@apple.com>
728
729         <http://webkit.org/b/57384> CFNetwork and WebCore load priorities should match
730
731         Reviewed by Alexey Proskuryakov.
732
733         * WebCoreSupport/WebSystemInterface.mm:
734         (InitWebCoreSystemInterface): Added initialization for
735         wkSetHTTPPipeliningMaximumPriority().
736
737 2011-04-04  Alexey Proskuryakov  <ap@apple.com>
738
739         Reviewed by Dan Bernstein.
740
741         REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
742         https://bugs.webkit.org/show_bug.cgi?id=51230
743         <rdar://problem/8780989>
744
745         * WebView/WebHTMLView.mm: (-[WebHTMLView flagsChanged:]): Moved Caps Lock handling from
746         WebKits to WebCore, because WebKit shouldn't be smart.
747
748 2011-04-01  Alexey Proskuryakov  <ap@apple.com>
749
750         Reviewed by Darin Adler.
751
752         REGRESSION: Assertion failure when executing a complex custom key binding
753         https://bugs.webkit.org/show_bug.cgi?id=57681
754
755         * WebView/WebHTMLView.mm: (-[WebHTMLView hasMarkedText]): There is no need to execute saved
756         commands when they can't possibly change the result.
757
758 2011-04-01  Anders Carlsson  <andersca@apple.com>
759
760         Reviewed by Sam Weinig.
761
762         Shockwave plug-in doesn't accept mouse events
763         https://bugs.webkit.org/show_bug.cgi?id=57653
764         <rdar://problem/8483273>
765
766         Fix an unrelated bug found by the added test.
767
768         * Plugins/WebBaseNetscapePluginView.mm:
769         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
770         Make sure to always set destX and destY.
771
772 2011-04-01  Alexey Proskuryakov  <ap@apple.com>
773
774         Reviewed by Darin Adler.
775
776         Make WebKit2 text input handling more like WebKit1
777         https://bugs.webkit.org/show_bug.cgi?id=57649
778
779         * WebView/WebFrameInternal.h: Expose _convertToDOMRange for use in WebHTMLView.
780         * WebView/WebHTMLView.mm:
781         (-[WebHTMLView _executeSavedKeypressCommands]): Renamed, since these are not editor commands.
782         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for the renamed _executeSavedKeypressCommands.
783         (-[WebHTMLView characterIndexForPoint:]): Ditto.
784         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
785         (-[WebHTMLView selectedRange]): Ditto.
786         (-[WebHTMLView markedRange]): Ditto.
787         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
788         (-[WebHTMLView hasMarkedText]): Ditto.
789         (-[WebHTMLView unmarkText]): Ditto.
790         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. Changed the comment about the argument
791         type into an assertion. Removed resetting interpretKeyEventsParameters to 0, as we shouldn't
792         be able to call text input protocol methods from here (and we didn't even reset it back on
793         return). Changed to retrieve all data before starting to apply actions to better match WK2 code.
794         (-[WebHTMLView insertText:]): Ditto.
795
796 2011-04-01  Timothy Hatcher  <timothy@apple.com>
797
798         Make momentum scroll event latching work in WebKit2 on Mac.
799
800         <rdar://problem/8751861>
801
802         Reviewed by Darin Adler.
803
804         * WebCoreSupport/WebSystemInterface.mm:
805         (InitWebCoreSystemInterface): Remove IsLatchingWheelEvent, add GetNSEventMomentumPhase.
806         * WebView/WebDynamicScrollBarsView.mm:
807         (-[WebDynamicScrollBarsView scrollWheel:]): Use WKGetNSEventMomentumPhase to set isLatchingEvent.
808
809 2011-03-31  Darin Adler  <darin@apple.com>
810
811         Reviewed by Anders Carlsson.
812
813         Assertion failure in -[WebHTMLView _handleStyleKeyEquivalent:]
814         https://bugs.webkit.org/show_bug.cgi?id=26667
815
816         * WebView/WebHTMLView.mm:
817         (-[WebHTMLView _handleStyleKeyEquivalent:]): Handle the case where WebView is
818         nil rather than asserting that it is non-nil. One case where WebView will be nil
819         is when the frame is closed, but in any case where it is nil, the correct thing
820         to do is to not try to handle the style key.
821
822 2011-03-31  Alexey Proskuryakov  <ap@apple.com>
823
824         Patch by John Harvey, reviewed and tweaked by me.
825
826         <rdar://problem/8644403> Should notify TSM that plug-ins would show a bottom input window for marked text.
827
828         * Plugins/Hosted/WebTextInputWindowController.m:
829         (-[WebTextInputPanel _interpretKeyEvent:string:]):
830
831 2011-03-31  Evan Martin  <evan@chromium.org>
832
833         Reviewed by Eric Seidel.
834
835         <title> should support dir attribute
836         https://bugs.webkit.org/show_bug.cgi?id=50961
837
838         Update to new FrameLoaderClient interface.
839
840         * WebCoreSupport/WebFrameLoaderClient.h:
841         * WebCoreSupport/WebFrameLoaderClient.mm:
842         (WebFrameLoaderClient::dispatchDidReceiveTitle):
843         (WebFrameLoaderClient::setTitle):
844
845 2011-03-30  Dominic Cooney  <dominicc@google.com>
846
847         Reviewed by Dimitri Glazkov.
848
849         Adds layoutTestController.shadowRoot accessor to Mac DRT.
850         https://bugs.webkit.org/show_bug.cgi?id=57415
851
852         * DOM/WebDOMOperations.mm:
853         (-[DOMElement _shadowRoot:]):
854         * DOM/WebDOMOperationsPrivate.h:
855
856 2011-03-30  Alexey Proskuryakov  <ap@apple.com>
857
858         Reviewed by Darin Adler.
859
860         WebHTMLView shouldn't resend noop: commands
861         https://bugs.webkit.org/show_bug.cgi?id=57504
862         <rdar://problem/9209390>
863
864         * WebView/WebHTMLView.mm: (-[WebHTMLView _executeSavedEditingCommands]): Filter out NOOPs,
865         which we get e.g. when handling Cmd-key combos.
866
867 2011-03-30  Alexey Proskuryakov  <ap@apple.com>
868
869         Reviewed by Darin Adler.
870
871         REGRESSION (r82320): Spacebar no longer pages down
872         https://bugs.webkit.org/show_bug.cgi?id=57423
873         <rdar://problem/9207702>
874
875         Also includes some unrelated cleanup that I had in my tree.
876
877         * WebView/WebHTMLView.mm:
878         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added an assertion that the event is
879         being dispatched to the right frame.
880         (-[WebHTMLView setMarkedText:selectedRange:]): Use 0 for a pointer, not NULL.
881         (-[WebHTMLView doCommandBySelector:]): Update eventInterpretationHadSideEffects with "|=".
882         Even if this specific command hasn't been handled, that doesn't nullify side effects from
883         previous commands.
884         (-[WebHTMLView insertText:]): Besides looking at the return value of insertText() to fix the
885         bug, removed setting _private->interpretKeyEventsParameters to 0. I don't see any way for
886         another WebHTMLView NSTextInput method to be called from within insertText:, so no one is
887         going to look at it.
888
889 2011-03-30  Sam Weinig  <sam@webkit.org>
890
891         Reviewed by Brady Eidson.
892
893         WebKit2: Attempting to view css file from url causes it to download
894         <rdar://problem/9102611>
895         https://bugs.webkit.org/show_bug.cgi?id=57501
896
897         * WebView/WebHTMLRepresentation.h:
898         * WebView/WebHTMLRepresentation.mm:
899         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
900         * WebView/WebHTMLView.mm:
901         (+[WebHTMLView unsupportedTextMIMETypes]):
902         Re-factor unsupportedTextMIMETypes to pull from WebCore's
903         MIMETypeRegistry, so that the list can be shared with WebKit2.
904
905 2011-03-29  Beth Dakin  <bdakin@apple.com>
906
907         Reviewed by Maciej Stachowiak.
908
909         Fix for https://bugs.webkit.org/show_bug.cgi?id=57408 
910         webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard 
911         -and corresponding-
912         <rdar://problem/8665411>
913
914         * Misc/WebNSControlExtras.m:
915         (-[NSControl sizeToFitAndAdjustWindowHeight]):
916         * WebCoreSupport/WebChromeClient.mm:
917         (WebChromeClient::scaleFactor):
918         * WebView/WebHTMLView.mm:
919         (-[WebHTMLView viewDidMoveToWindow]):
920         (-[WebHTMLView attachRootLayer:]):
921
922 2011-03-29  Kent Tamura  <tkent@chromium.org>
923
924         Reviewed by Dimitri Glazkov.
925
926         Make validation message bubble testable
927         https://bugs.webkit.org/show_bug.cgi?id=57290
928
929         * WebView/WebView.mm:
930         (-[WebView _preferencesChangedNotification:]): Copy the private value of
931           the timer magnification to WebCore::Settings.
932         (-[WebView validationMessageTimerMagnification]): Added.
933         (-[WebView setValidationMessageTimerMagnification:]): Added.
934         * WebView/WebViewData.h: Declare a member for the timer magnification.
935         * WebView/WebViewData.mm:
936         (-[WebViewPrivate init]): Initialize the timer magnification.
937         * WebView/WebViewPrivate.h:
938           Declare a setter and a getter for the timer magnification.
939
940 2011-03-29  Kent Tamura  <tkent@chromium.org>
941
942         Reviewed by Dimitri Glazkov.
943
944         [Mac] Enable interactive-validation tests on Mac DRT
945         https://bugs.webkit.org/show_bug.cgi?id=57308
946
947         * WebView/WebView.mm:
948         (-[WebView _preferencesChangedNotification:]):
949           Convey a WebView flag for interactive validation to WebCore::Settings.
950         (-[WebView interactiveFormValidationEnabled]): Added.
951         (-[WebView setInteractiveFormValidationEnabled:]): Added.
952         * WebView/WebViewData.h: Add interactiveFormValidationEnabled.
953         * WebView/WebViewData.mm:
954         (-[WebViewPrivate init]): Initialize interactiveFormValidationEnabled.
955         * WebView/WebViewPrivate.h: Add setter and getter for interactiveFormValidationEnabled.
956
957 2011-03-29  Timothy Hatcher  <timothy@apple.com>
958
959         Update the order of the context menu to better match AppKit on Mac.
960
961         <rdar://problem/9054893>
962
963         Reviewed by John Sullivan.
964
965         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
966         (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Update the order of items.
967         * WebCoreSupport/WebPlatformStrategies.h:
968         * WebCoreSupport/WebPlatformStrategies.mm:
969         (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): Added argument for selected string.
970
971 2011-03-29  Alexey Proskuryakov  <ap@apple.com>
972
973         Reviewed by Darin Adler.
974
975         https://bugs.webkit.org/show_bug.cgi?id=57379
976         Clean up WK1 key event handling logic
977
978         No bugs knowingly fixed, but this makes the code more consistent.
979
980         * WebView/WebHTMLView.mm:
981         (struct WebHTMLViewInterpretKeyEventsParameters): Renamed eventWasHandled to
982         eventInterpretationHadSideEffects, because "handled" doesn't really mean much.
983         (-[WebHTMLView _executeSavedEditingCommands]): Factored out from _interpretKeyEvent for use
984         from other functions. We need to execute saved commands when an input method asks for current
985         state, because providing stale state could confuse it.
986         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Heavily commented, and updated for other
987         changes.
988         (-[WebHTMLView characterIndexForPoint:]): Call _executeSavedEditingCommands, because otherwise,
989         the answer would be stale.
990         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
991         (-[WebHTMLView selectedRange]): Ditto.
992         (-[WebHTMLView markedRange]): Ditto.
993         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
994         (-[WebHTMLView hasMarkedText]): Ditto.
995         (-[WebHTMLView unmarkText]): Call _executeSavedEditingCommands, because otherwise, we'd be
996         operating on stale data. Also, updated for eventWasHandled renaming.
997         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
998         (-[WebHTMLView doCommandBySelector:]): Removed special handling for noop:. I verified that
999         it's no longer needed for bug 14522, presumably due to WebCore level changes. It was also
1000         fragile, because there is no guarantee about when noop: is sent (also, a custom key binding
1001         could have a noop: as one of its commands, although that's hardly practical).
1002         Added the same "from input method" logic that we have in insertText: - I don't know of any
1003         IMs that call this method, but we clearly need to execute it as part of IM processing when
1004         there is marked text.
1005         (-[WebHTMLView insertText:]): Removed a confusing check for [text length]. Always set
1006         eventInterpretationHadSideEffects to true, becasue there is no reason to try multiple times
1007         if current selection isn't editable. This is different from doCommandBySelector:, where we
1008         need to give super class a chance to handle the event if our processing fails.
1009         Removed a nonsense "consumedByIM = true" assignment - we no longer need it now that the
1010         return value of _interpretKeyEvent is computed differently.
1011
1012 2011-03-28  Adele Peterson  <adele@apple.com>
1013
1014         Reviewed by Eric Seidel.
1015
1016         Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
1017         https://bugs.webkit.org/show_bug.cgi?id=57173
1018
1019         * WebView/WebFrame.mm:
1020         (-[WebFrame hasSpellingMarker:length:]): Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
1021         (-[WebFrame hasGrammarMarker:length:]): Call new selectionStartHasMarkerFor method.
1022         * WebView/WebFramePrivate.h: Add hasGrammarMarker so grammar marking can be tested.
1023
1024 2011-03-28  Alexey Proskuryakov  <ap@apple.com>
1025
1026         Reviewed by Darin Adler.
1027
1028         https://bugs.webkit.org/show_bug.cgi?id=57260
1029         Clean up text input code a little
1030
1031         * WebCoreSupport/WebEditorClient.mm:
1032         (WebEditorClient::handleKeyboardEvent):
1033         (WebEditorClient::handleInputMethodKeydown):
1034         * WebView/WebHTMLViewInternal.h:
1035         Renamed _interceptEditingKeyEvent:shouldSaveCommand:, becasue it doesn't really intercept
1036         anything. It's just a version it interpretKeyEvents: that tells us whether it was handled,
1037         and also possibly saves resulting commands for later execution.
1038
1039         * WebView/WebHTMLView.mm:
1040         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Changed to use early return. Changed
1041         return value in case platformEvent is null to be less mysterious. Moved receivedNOOP from
1042         WebHTMLViewPrivate to WebHTMLViewInterpretKeyEventsParameters, as this is just part of event
1043         handling state, like the other booleans there. Don't call interpretKeyEvents: again simply
1044         because the first call resulted in no saved commands, becasue it's confusing and apparently
1045         useless (I couldn't find any broken behavior).
1046         (-[WebHTMLView unmarkText]): Cleaned upo BOOL vs. bool constants.
1047         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
1048         (-[WebHTMLView doCommandBySelector:]): Ditto.
1049         (-[WebHTMLView insertText:]): Ditto.
1050
1051         * WebView/WebViewInternal.h: There was no _interceptEditingKeyEvent:shouldSaveCommand:
1052         method on WebView.
1053
1054 2011-03-27  Jer Noble  <jer.noble@apple.com>
1055
1056         Reviewed by Maciej Stachowiak.
1057
1058         Full Screen: disable keyboard access by default
1059         https://bugs.webkit.org/show_bug.cgi?id=56684
1060
1061         Take into account whether keyboard access was requested when deciding whether full
1062         screen mode is supported.
1063
1064         * WebCoreSupport/WebChromeClient.h:
1065         * WebCoreSupport/WebChromeClient.mm:
1066         (WebChromeClient::supportsFullScreenForElement):
1067         * WebView/WebView.mm:
1068         (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):
1069         * WebView/WebViewInternal.h:
1070
1071 2011-03-26  Jer Noble  <jer.noble@apple.com>
1072
1073         Reviewed by Eric Carlson.
1074
1075         Enable the Full Screen API by default in WebKit/mac and WebKit2
1076         https://bugs.webkit.org/show_bug.cgi?id=56956
1077
1078         * WebView/WebPreferences.mm:
1079         (+[WebPreferences initialize]): Default the WebKitFullScreenEnabled preference to true.
1080
1081 2011-03-25  Andy Estes  <aestes@apple.com>
1082
1083         Reviewed by Adele Peterson.
1084
1085         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
1086         https://bugs.webkit.org/show_bug.cgi?id=49016
1087
1088         Update objectContentType() implementation to handle the
1089         shouldPreferPlugInsForImages flag.
1090
1091         * WebCoreSupport/WebFrameLoaderClient.h:
1092         * WebCoreSupport/WebFrameLoaderClient.mm:
1093         (WebFrameLoaderClient::objectContentType):
1094
1095 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1096
1097         Unreviewed, rolling out r81939.
1098         http://trac.webkit.org/changeset/81939
1099         https://bugs.webkit.org/show_bug.cgi?id=57084
1100
1101         Rolling out 81939, as it's causing a number of app cache test
1102         failures. (Requested by jernoble on #webkit).
1103
1104         * WebView/WebView.mm:
1105         (-[WebView _preferencesChangedNotification:]):
1106
1107 2011-03-23  Jer Noble  <jer.noble@apple.com>
1108
1109         Reviewed by Maciej Stachowiak.
1110
1111         Application Cache should save audio/ and video/ mime types as flat files
1112         https://bugs.webkit.org/show_bug.cgi?id=53784
1113         <rdar://problem/8932473>
1114
1115         No new tests.
1116
1117         Initialize the AppCache Total size quotas with the values for WebKitPreferences
1118         upon startup.
1119
1120         * WebView/WebView.mm:
1121         (-[WebView _preferencesChangedNotification:]):
1122
1123 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1124
1125         Unreviewed, rolling out r81916 and r81917.
1126         http://trac.webkit.org/changeset/81916
1127         http://trac.webkit.org/changeset/81917
1128         https://bugs.webkit.org/show_bug.cgi?id=57071
1129
1130         broke a test on platforms that do not have QuickTime installed
1131         (Requested by estes on #webkit).
1132
1133         * WebCoreSupport/WebFrameLoaderClient.h:
1134         * WebCoreSupport/WebFrameLoaderClient.mm:
1135         (WebFrameLoaderClient::objectContentType):
1136
1137 2011-03-24  Andy Estes  <aestes@apple.com>
1138
1139         Reviewed by Darin Adler.
1140
1141         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
1142         https://bugs.webkit.org/show_bug.cgi?id=49016
1143
1144         Update objectContentType() implementation to handle the
1145         shouldPreferPlugInsForImages flag.
1146
1147         * WebCoreSupport/WebFrameLoaderClient.h:
1148         * WebCoreSupport/WebFrameLoaderClient.mm:
1149         (WebFrameLoaderClient::objectContentType):
1150
1151 2011-03-24  Geoffrey Garen  <ggaren@apple.com>
1152
1153         Reviewed by Oliver Hunt.
1154
1155         Ensure that all compilation takes place within a dynamic global object scope
1156         https://bugs.webkit.org/show_bug.cgi?id=57054
1157
1158         * WebView/WebScriptDebugDelegate.mm:
1159         (-[WebScriptCallFrame evaluateWebScript:]): Updated for signature change.
1160
1161 2011-03-24  Jia Pu  <jpu@apple.com>
1162
1163         Reviewed by Darin Adler.
1164
1165         Dismissed reversion suggestion is incorrectly learned.
1166         https://bugs.webkit.org/show_bug.cgi?id=57039
1167
1168         CorrectionPanel should always use [NSSpellChecker dismissCorrectionBubbleForView].
1169         [NSSpellChecker cancelCorrectionBubbleForView] is reserved for situation where correction panel
1170         is dismissed explicitly by ESC key or clicking the dimiss button. Misusing these causes
1171         incorrect automatic learning.
1172
1173         * WebCoreSupport/CorrectionPanel.mm:
1174         (CorrectionPanel::dismissInternal):
1175
1176 2011-03-24  David Kilzer  <ddkilzer@apple.com>
1177
1178         <http://webkit.org/b/56993> ENABLE_PLUGIN_PROXY_FOR_VIDEO should be defined to 0 on Mac OS X
1179
1180         Reviewed by Joseph Pecoraro.
1181
1182         * Plugins/WebPluginContainerPrivate.h: Changed value of
1183         ENABLE_PLUGIN_PROXY_FOR_VIDEO from 1 to 0.
1184
1185 2011-03-23  Jia Pu  <jpu@apple.com>
1186
1187         Reviewed by Darin Adler.
1188
1189         Hook up new AppKit autocorrection UI with WK2.
1190         https://bugs.webkit.org/show_bug.cgi?id=56055
1191         <rdar://problem/8947463>
1192
1193         Please see WebCore/ChangeLog for detail.
1194
1195         * WebCoreSupport/CorrectionPanel.h: Added.
1196         (CorrectionPanel::isShowing):
1197         * WebCoreSupport/CorrectionPanel.mm: Added.
1198         (correctionBubbleType):
1199         (CorrectionPanel::CorrectionPanel):
1200         (CorrectionPanel::~CorrectionPanel):
1201         (CorrectionPanel::show):
1202         (CorrectionPanel::dismiss):
1203         (CorrectionPanel::dismissSoon):
1204         (CorrectionPanel::dismissInternal):
1205         (CorrectionPanel::recordAutocorrectionResponse):
1206         * WebCoreSupport/WebEditorClient.h:
1207         * WebCoreSupport/WebEditorClient.mm:
1208         (WebEditorClient::WebEditorClient):
1209         (WebEditorClient::showCorrectionPanel):
1210         (WebEditorClient::dismissCorrectionPanel):
1211         (WebEditorClient::dismissCorrectionPanelSoon):
1212         (WebEditorClient::recordAutocorrectionResponse):
1213         * WebView/WebView.mm:
1214         (-[WebView handleCorrectionPanelResult:]):
1215         * WebView/WebViewPrivate.h:
1216
1217 2011-03-23  Enrica Casucci  <enrica@apple.com>
1218
1219         Reviewed by Alexey Proskuryakov.
1220
1221         Services menu item to convert selected Simplified/Traditional Chinese Text is not working.
1222         https://bugs.webkit.org/show_bug.cgi?id=56974
1223         <rdar://problem/8284642>
1224
1225         This fixes a regression introduced by http://trac.webkit.org/changeset/61794
1226         where readSelectionFromPasteboard was accidentally removed.
1227         This method and writeSelectionToPasteboard are needed to support Mac OS X
1228         services.
1229         
1230         * WebView/WebHTMLView.mm:
1231         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Added.
1232         (-[WebHTMLView readSelectionFromPasteboard:]): Added.
1233
1234 2011-03-23  Brady Eidson  <beidson@apple.com>
1235
1236         Reviewed by Sam Weinig.
1237
1238         Change IconDatabase opening to allow for arbitrary filenames
1239         https://bugs.webkit.org/show_bug.cgi?id=56977
1240
1241         * Misc/WebIconDatabase.mm:
1242         (-[WebIconDatabase _startUpIconDatabase]):
1243
1244 2011-03-22  Anton D'Auria  <adauria@apple.com>
1245
1246         Reviewed by Alexey Proskuryakov.
1247
1248         Add +[WebApplicationCache getOriginsWithCache]
1249         https://bugs.webkit.org/show_bug.cgi?id=56722
1250
1251         Call existing WebCore::ApplicationCacheStorage::getOriginsWithCache API.
1252
1253         * WebCoreSupport/WebApplicationCache.h:
1254         * WebCoreSupport/WebApplicationCache.mm:
1255         (+[WebApplicationCache originsWithCache]):
1256
1257 2011-03-22  Anders Carlsson  <andersca@apple.com>
1258
1259         Reviewed by Sam Weinig.
1260
1261         OBJECT element with DivX source is always downloaded
1262         https://bugs.webkit.org/show_bug.cgi?id=56879
1263
1264         * Plugins/WebBasePluginPackage.mm:
1265         (-[WebBasePluginPackage getPluginInfoFromPLists]):
1266         Always try to split every element in the "WebPluginExtensions" array, since the DivX plug-in
1267         specifies multiple file extensions in a single element.
1268
1269 2011-03-22  Brady Eidson  <beidson@apple.com>
1270
1271         Reviewed by Sam Weinig.
1272
1273         <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876
1274         WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread
1275
1276         Note that while the new client calls always come through on the main thread, our mechanisms to
1277         route dispatches to the main thread are still valid and will still work.
1278
1279         Update to the new IconDatabaseClient interface:
1280         * WebCoreSupport/WebIconDatabaseClient.h:
1281         * WebCoreSupport/WebIconDatabaseClient.mm:
1282         (WebIconDatabaseClient::didRemoveAllIcons):
1283         (WebIconDatabaseClient::didImportIconURLForPageURL):
1284         (WebIconDatabaseClient::didImportIconDataForPageURL):
1285         (WebIconDatabaseClient::didChangeIconForPageURL):
1286         (WebIconDatabaseClient::didFinishURLImport):
1287
1288 2011-03-22  Matthew Delaney  <mdelaney@apple.com>
1289
1290         Reviewed by Simon Fraser.
1291
1292         Have WebKit push acceleratedDrawing preferences to settings
1293         https://bugs.webkit.org/show_bug.cgi?id=56792
1294
1295         * WebView/WebView.mm:
1296
1297 2011-03-21  Nate Chapin  <japhet@chromium.org>
1298
1299         Reviewed by Brady Eidson.
1300
1301         Expose a preference to use caching quirks for QuickLook,
1302         and use it if the QuickLook framework is loaded.
1303
1304         https://bugs.webkit.org/show_bug.cgi?id=38690
1305
1306         * WebView/WebPreferenceKeysPrivate.h:
1307         * WebView/WebPreferences.mm:
1308         (useQuickLookQuirks):
1309         (+[WebPreferences initialize]):
1310         (-[WebPreferences useQuickLookResourceCachingQuirks]):
1311         * WebView/WebPreferencesPrivate.h:
1312         * WebView/WebView.mm:
1313         (-[WebView _preferencesChangedNotification:]):
1314
1315 2011-03-21  Chris Fleizach  <cfleizach@apple.com>
1316
1317         Reviewed by Darin Adler.
1318
1319         AX: showContextMenu not working in WK2
1320         https://bugs.webkit.org/show_bug.cgi?id=56734
1321
1322         Implement showContextMenu() so accessibility related code can call this
1323         independent of whether WK1 or WK2 is running.
1324
1325         * WebCoreSupport/WebChromeClient.h:
1326         * WebCoreSupport/WebChromeClient.mm:
1327         (WebChromeClient::showContextMenu):
1328
1329 2011-03-21  Chang Shu  <cshu@webkit.org>
1330
1331         Reviewed by Alexey Proskuryakov.
1332
1333         REGRESSION (r79953): Can't type in MS Outlook 2011
1334         https://bugs.webkit.org/show_bug.cgi?id=56665
1335
1336         r79953 removed the WebView level editablity which is persistent no matter whether
1337         underlying document itself is changed and editability gets lost. The resolution is to
1338         set this WebView editable value to WebCore. This avoids the callback from WebCore to
1339         WebKit which was the main goal in r79953 to improve performance.
1340
1341         * WebView/WebView.mm:
1342         (-[WebView setEditable:]):
1343         (-[WebView isEditable]):
1344
1345 2011-03-19  Anton D'Auria  <adauria@apple.com>
1346
1347         Reviewed by Alexey Proskuryakov.
1348
1349         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
1350         https://bugs.webkit.org/show_bug.cgi?id=56415
1351         
1352         Use new ApplicationCache API to delete all cache for an origin.
1353
1354         * WebCoreSupport/WebApplicationCache.h:
1355         * WebCoreSupport/WebApplicationCache.mm:
1356         (+[WebApplicationCache deleteOrigin:]):
1357
1358 2011-03-17  Brady Eidson  <beidson@apple.com>
1359
1360         Reviewed by Sam Weinig.
1361
1362         https://bugs.webkit.org/show_bug.cgi?id=56425
1363         More groundwork for WebKit2 IconDatabase
1364
1365         Update already-used function names:
1366         * Misc/WebIconDatabase.mm:
1367         (-[WebIconDatabase iconForURL:withSize:cache:]):
1368         (-[WebIconDatabase iconURLForURL:]):
1369         * WebView/WebView.mm:
1370         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
1371
1372 2011-03-18  Pavel Podivilov  <podivilov@chromium.org>
1373
1374         Reviewed by Yury Semikhatsky.
1375
1376         Web Inspector: implement inspector session storage.
1377         https://bugs.webkit.org/show_bug.cgi?id=56643
1378
1379         * WebCoreSupport/WebInspectorClient.h:
1380         * WebCoreSupport/WebInspectorClient.mm:
1381         (WebInspectorClient::saveSessionSetting):
1382         (WebInspectorClient::loadSessionSetting):
1383         (WebInspectorFrontendClient::saveSessionSetting):
1384         (WebInspectorFrontendClient::loadSessionSetting):
1385         (-[WebInspectorWindowController inspectorClient]):
1386
1387 2011-03-17  Geoffrey Garen  <ggaren@apple.com>
1388
1389         Reviewed by Oliver Hunt.
1390
1391         Fixed a leak seen on the buildbot.
1392
1393         * WebCoreSupport/WebInspectorClient.mm:
1394         (WebInspectorClient::openInspectorFrontend): Smart pointers are smart.
1395
1396 2011-03-16  Jeff Johnson  <github@lapcatsoftware.com>
1397
1398         Reviewed by Alexey Proskuryakov.
1399
1400         Logic error in -[WebHTMLView close]
1401         https://bugs.webkit.org/show_bug.cgi?id=56445
1402
1403         Page is always nil at this point, because [self _webView] is nil,
1404         so the conditional code is never run.
1405
1406         * WebView/WebHTMLView.mm:
1407         (-[WebHTMLView close]):
1408
1409 2011-03-16  Chris Fleizach  <cfleizach@apple.com>
1410
1411         Reviewed by Darin Adler.
1412
1413         WK2: Need to propagate enhanced accessibility flag from UI -> web process
1414         https://bugs.webkit.org/show_bug.cgi?id=56379
1415
1416         * WebView/WebFrame.mm:
1417         (-[WebFrame accessibilityRoot]):
1418
1419 2011-03-15  Oliver Hunt  <oliver@apple.com>
1420
1421         Reviewed by Geoffrey Garen.
1422
1423         Make Structure creation require a JSGlobalData
1424         https://bugs.webkit.org/show_bug.cgi?id=56438
1425
1426         Mechanical change to make all Structure creation use a JSGlobalData&
1427
1428         * Plugins/Hosted/ProxyInstance.mm:
1429         (WebKit::ProxyRuntimeMethod::createStructure):
1430         * Plugins/Hosted/ProxyRuntimeObject.h:
1431         (WebKit::ProxyRuntimeObject::createStructure):
1432
1433 2011-03-15  Alexey Proskuryakov  <ap@apple.com>
1434
1435         Forgot to save a modification to this file when committing.
1436
1437         * WebCoreSupport/WebKeyGenerator.mm: Changed "Apple Computer" to "Apple" in copyright header.
1438
1439 2011-03-15  Alexey Proskuryakov  <ap@apple.com>
1440
1441         Reviewed by Darin Adler.
1442
1443         REGRESSION (WebKit2): keygen element doesn't work
1444         https://bugs.webkit.org/show_bug.cgi?id=56402
1445         <rdar://problem/9006545>
1446
1447         * WebCoreSupport/WebKeyGenerator.h:
1448         * WebCoreSupport/WebKeyGenerator.m: Removed.
1449         * WebCoreSupport/WebKeyGenerator.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebKeyGenerator.m.
1450         (+[WebKeyGenerator sharedGenerator]):
1451         (toWebCertificateParseResult):
1452         WebCore no longer needs WebKeyGenerator. Safari still does need a part of it, so keeping
1453         this misnamed and misplaced code for now.
1454
1455         * WebCoreSupport/WebPlatformStrategies.h:
1456         * WebCoreSupport/WebPlatformStrategies.mm:
1457         (WebPlatformStrategies::keygenMenuItem512):
1458         (WebPlatformStrategies::keygenMenuItem1024):
1459         (WebPlatformStrategies::keygenMenuItem2048):
1460         (WebPlatformStrategies::keygenKeychainItemName):
1461         Added strings used by keygen.
1462
1463         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize a WebCore
1464         pointer to a function used by keygen.
1465
1466         * WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): WebKeyGenerator can be lazily
1467         initialized now.
1468
1469 2011-03-15  Beth Dakin  <bdakin@apple.com>
1470
1471         Reviewed by Simon Fraser.
1472
1473         WebKit part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%
1474
1475         New WebKitystemInterface function to force the scrollbars to flash
1476         * WebCoreSupport/WebSystemInterface.mm:
1477         (InitWebCoreSystemInterface):
1478
1479 2011-03-15  Ilya Sherman  <isherman@chromium.org>
1480
1481         Reviewed by Tony Chang.
1482
1483         Autofilled form elements are assigned fixed background color but not text color
1484         https://bugs.webkit.org/show_bug.cgi?id=48382
1485
1486         * DOM/WebDOMOperations.mm:
1487         (-[DOMHTMLInputElement _setAutofilled:]): Added (wrapper).
1488         * DOM/WebDOMOperationsPrivate.h:
1489
1490 2011-03-15  Adam Roben  <aroben@apple.com>
1491
1492         Fix a leak in WebStorageTrackerClient::dispatchDidModifyOrigin
1493
1494         Fixes <http://webkit.org/b/56385> SecurityOrigin leaks seen in
1495         WebStorageTrackerClient::dispatchDidModifyOrigin
1496
1497         Reviewed by Antti Koivisto.
1498
1499         * Storage/WebStorageTrackerClient.mm:
1500         (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): Adopt the reference passed
1501         to us by dispatchDidModifyOrigin.
1502         (WebStorageTrackerClient::dispatchDidModifyOrigin): Added a comment and removed an
1503         unnecessary cast.
1504
1505 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1506
1507         Reviewed by Darin Adler.
1508
1509         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
1510         info into the headers rather than in export symbol definition files, but disable it on 
1511         all platforms initially so we can deal with port build issues one port at a time.
1512         
1513         https://bugs.webkit.org/show_bug.cgi?id=27551
1514
1515         * WebKitPrefix.h:
1516
1517 2011-03-14  Brady Eidson  <beidson@apple.com>
1518
1519         Reviewed by Anders Carlsson.
1520
1521         https://bugs.webkit.org/show_bug.cgi?id=56320
1522         Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
1523
1524         * History/WebHistoryItem.mm:
1525         (-[WebHistoryItem icon]): This far-future FIXME is now irrelevant.
1526
1527 2011-03-13  Pratik Solanki  <psolanki@apple.com>
1528
1529         Reviewed by Brady Eidson.
1530
1531         Make adjustMIMETypeIfNecessary use CFNetwork directly
1532         https://bugs.webkit.org/show_bug.cgi?id=55912
1533
1534         * WebCoreSupport/WebSystemInterface.mm:
1535         (InitWebCoreSystemInterface): Support for new WKSI functions.
1536
1537 2011-03-12  Mark Rowe  <mrowe@apple.com>
1538
1539         Fix the 32-bit build.
1540
1541         * Carbon/CarbonWindowAdapter.mm:
1542         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier.
1543         (-[CarbonWindowAdapter _carbonWindowClass]): Ditto.
1544
1545 2011-03-11  Brady Eidson  <beidson@apple.com>
1546
1547         Reviewed by Anders Carlsson
1548
1549         <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56216
1550         Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation.
1551
1552         * Misc/WebIconDatabase.mm:
1553         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Call these static methods on IconDatabase::, not iconDatabase().
1554         (-[WebIconDatabase _startUpIconDatabase]): Ditto.
1555         (importToWebCoreFormat):
1556
1557 2011-03-11  Anton D'Auria  <adauria@apple.com>
1558
1559         Reviewed and landed by Brady Eidson.
1560
1561         https://bugs.webkit.org/show_bug.cgi?id=51878
1562         Add WebKit1 API to view and delete local storage
1563
1564         * Storage/WebStorageManager.mm: Added.
1565         (+[WebStorageManager sharedWebStorageManager]):
1566         (-[WebStorageManager origins]):
1567         (-[WebStorageManager deleteAllOrigins]):
1568         (-[WebStorageManager deleteOrigin:]):
1569         (-[WebStorageManager syncLocalStorage]):
1570         (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
1571         (storageDirectoryPath):
1572         (WebKitInitializeStorageIfNecessary):
1573         * Storage/WebStorageManagerInternal.h: Added.
1574         * Storage/WebStorageManagerPrivate.h: Added.
1575         * Storage/WebStorageTrackerClient.h: Added.
1576         * Storage/WebStorageTrackerClient.mm: Added.
1577         (WebStorageTrackerClient::sharedWebStorageTrackerClient):
1578         (WebStorageTrackerClient::WebStorageTrackerClient):
1579         (WebStorageTrackerClient::~WebStorageTrackerClient):
1580         (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread):
1581         (WebStorageTrackerClient::dispatchDidModifyOrigin):
1582         * WebCoreSupport/WebSecurityOrigin.mm:
1583         (-[WebSecurityOrigin protocol]):
1584         (-[WebSecurityOrigin host]):
1585         (-[WebSecurityOrigin databaseIdentifier]):
1586         (-[WebSecurityOrigin domain]):
1587         (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
1588         * WebCoreSupport/WebSecurityOriginPrivate.h:
1589         * WebKit.exp:
1590         * WebView/WebView.mm:
1591         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
1592
1593 2011-03-10  Anders Carlsson  <andersca@apple.com>
1594
1595         Reviewed by Sam Weinig.
1596
1597         <rdar://problem/9117047>
1598         Don't paint more than 60 times per second even when scrolling
1599
1600         * WebView/WebClipView.mm:
1601         (-[WebClipView _immediateScrollToPoint:]):
1602
1603 2011-03-09  Matthew Delaney  <mdelaney@apple.com>
1604
1605         Reviewed by Simon Fraser.
1606
1607         Plumb through settings for accelerated drawing for canvas
1608         https://bugs.webkit.org/show_bug.cgi?id=56039
1609
1610         * WebView/WebPreferenceKeysPrivate.h:
1611         * WebView/WebPreferences.mm:
1612         * WebView/WebPreferencesPrivate.h:
1613
1614 2011-03-10  Ryosuke Niwa  <rniwa@webkit.org>
1615
1616         Reviewed by Tony Chang.
1617
1618         VisiblePosition's next and previous should take an enum instead of a boolean
1619         https://bugs.webkit.org/show_bug.cgi?id=56135
1620
1621         SelectionController::isAll now takes EditingBoundaryCrossingRule instead of
1622         StayInEditableContent.
1623
1624         * WebView/WebView.mm:
1625         (-[WebView _selectionIsAll]):
1626
1627 2011-03-09  Jessie Berlin  <jberlin@apple.com>
1628
1629         Reviewed by Adam Roben.
1630
1631         Use the Cookie Storage from the Private Browsing Storage Session directly
1632         https://bugs.webkit.org/show_bug.cgi?id=55986
1633
1634         * WebCoreSupport/WebSystemInterface.mm:
1635         (InitWebCoreSystemInterface):
1636
1637 2011-03-08  Darin Adler  <darin@apple.com>
1638
1639         Reviewed by Timothy Hatcher.
1640
1641         Promote a method used outside WebKit from internal to private
1642         https://bugs.webkit.org/show_bug.cgi?id=55949
1643
1644         * Misc/WebNSPasteboardExtras.mm: Removed an unused category declaration.
1645         Minor tweak, not directly related to the rest of this patch.
1646
1647         * WebView/WebFrame.mm:
1648         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): Moved
1649         this method from the internal category into the private category.
1650         Streamlined the code a bit.
1651
1652         * WebView/WebFrameInternal.h: Removed _computePageRects method.
1653         * WebView/WebFramePrivate.h: Added _computePageRects method.
1654
1655 2011-03-07  Ryosuke Niwa  <rniwa@webkit.org>
1656
1657         Reviewed by Darin Adler.
1658
1659         selectionHasStyle and selectionStartHasStyle should use EditingStyle
1660         https://bugs.webkit.org/show_bug.cgi?id=55902
1661
1662         selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.
1663
1664         * WebView/WebHTMLView.mm: Removed unused selectionHasStyle.
1665         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Calls Editor::selectionHasStyle.
1666
1667 2011-03-07  Dan Bernstein  <mitz@apple.com>
1668
1669         LLVM Compiler build fix.
1670
1671         * WebCoreSupport/WebEditorClient.mm:
1672         (WebEditorClient::checkGrammarOfString):
1673
1674 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
1675
1676         Reviewed by Beth Dakin.
1677
1678         AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
1679         https://bugs.webkit.org/show_bug.cgi?id=55706
1680
1681         Make sure WebDynamicScrollBarsView appear in the AX tree in WK1 (since this object
1682         returns the scroll bar objects).
1683         Make the accessibilityRoot object be the web area in WK1 because WebDynamicScrollBarsView
1684         will expect that as its child, instead of the WebCore ScrollView object.
1685
1686         * WebView/WebDynamicScrollBarsView.mm:
1687         (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
1688         * WebView/WebFrame.mm:
1689         (-[WebFrame accessibilityRoot]):
1690
1691 2011-03-07  Sam Weinig  <sam@webkit.org>
1692
1693         Reviewed by Anders Carlsson.
1694
1695         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
1696         https://bugs.webkit.org/show_bug.cgi?id=55827
1697
1698         Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
1699         and pass the entire response, instead of just the MIMEType.
1700
1701         * WebCoreSupport/WebFrameLoaderClient.h:
1702         * WebCoreSupport/WebFrameLoaderClient.mm:
1703         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1704
1705 2011-03-06  Dan Bernstein  <mitz@apple.com>
1706
1707         LLVM Compiler build fix.
1708
1709         * DOM/WebDOMOperations.mm:
1710         (-[DOMHTMLInputElement _setValueForUser:]):
1711
1712 2011-03-06  Jessie Berlin  <jberlin@apple.com>
1713
1714         Reviewed by Sam Weinig.
1715
1716         WebKit2: Use CFNetwork Sessions API.
1717         https://bugs.webkit.org/show_bug.cgi?id=55435.
1718
1719         When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
1720         Private Browsing Storage Session.
1721
1722         * WebCoreSupport/WebSystemInterface.mm:
1723         (InitWebCoreSystemInterface):
1724         Add support for using the new WKSI functions in WebCore.
1725
1726 2011-03-05  Ilya Sherman  <isherman@chromium.org>
1727
1728         Reviewed by Darin Adler.
1729
1730         HTMLInputElement::setValue() should schedule change event when the element is focused
1731         In service of https://code.google.com/p/chromium/issues/detail?id=42716
1732         https://bugs.webkit.org/show_bug.cgi?id=53160
1733
1734         * DOM/WebDOMOperations.mm:
1735         (-[DOMHTMLInputElement _setValueForUser:]): Expose HTMLInputElement::setValueForUser() to tests
1736         * DOM/WebDOMOperationsPrivate.h:
1737         * WebView/WebViewInternal.h:
1738
1739 2011-03-04  Jia Pu  <jpu@apple.com>
1740
1741         Reviewed by Darin Adler.
1742
1743         On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
1744         https://bugs.webkit.org/show_bug.cgi?id=55717
1745         <rdar://problem/9018127>
1746
1747         With the change in WebCore, the bounding box passed into EditorClient::showCorrectionPanel()
1748         is already in window coordinate. We don't need to do further conversion anymore.
1749
1750         * WebCoreSupport/WebEditorClient.mm:
1751         (WebEditorClient::showCorrectionPanel):
1752
1753 2011-03-04  Jessie Berlin  <jberlin@apple.com>
1754
1755         Reviewed by Maciej Stachowiak.
1756
1757         WebKit2: Use CFNetwork Sessions API.
1758         https://bugs.webkit.org/show_bug.cgi?id=55435.
1759
1760         When Private Browsing is enabled, get the cached url response from the cache associated with
1761         the Private Browsing Storage Session.
1762
1763         * WebView/WebView.mm:
1764         (-[WebView _cachedResponseForURL:]):
1765
1766 2011-03-03  Anders Carlsson  <andersca@apple.com>
1767
1768         Reviewed by Sam Weinig.
1769
1770         Get rid of Page::globalHistoryItem
1771         https://bugs.webkit.org/show_bug.cgi?id=55738
1772
1773         * WebCoreSupport/WebFrameLoaderClient.h:
1774         * WebCoreSupport/WebFrameLoaderClient.mm:
1775         (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
1776         Get the current history item and update it using -[WebView _setGlobalHistoryItem:].
1777     
1778         * WebView/WebView.mm:
1779         (-[WebView _globalHistoryItem]):
1780         (-[WebView _setGlobalHistoryItem:]):
1781         Set _globalHistoryItem ivar.
1782
1783         * WebView/WebViewData.h:
1784         * WebView/WebViewData.mm:
1785         Add _globalHistoryItem ivar.
1786
1787 2011-03-03  Brady Eidson  <beidson@apple.com>
1788
1789         Reviewed by Darin Adler.
1790
1791         https://bugs.webkit.org/show_bug.cgi?id=55721
1792         Global IconDatabase should be returned by reference, not as a pointer
1793
1794         * Misc/WebCoreStatistics.mm:
1795         (+[WebCoreStatistics iconPageURLMappingCount]):
1796         (+[WebCoreStatistics iconRetainedPageURLCount]):
1797         (+[WebCoreStatistics iconRecordCount]):
1798         (+[WebCoreStatistics iconsWithDataCount]):
1799         * Misc/WebIconDatabase.mm:
1800         (-[WebIconDatabase init]):
1801         (-[WebIconDatabase iconForURL:withSize:cache:]):
1802         (-[WebIconDatabase iconURLForURL:]):
1803         (-[WebIconDatabase defaultIconWithSize:]):
1804         (-[WebIconDatabase retainIconForURL:]):
1805         (-[WebIconDatabase releaseIconForURL:]):
1806         (-[WebIconDatabase isEnabled]):
1807         (-[WebIconDatabase setEnabled:]):
1808         (-[WebIconDatabase removeAllIcons]):
1809         (+[WebIconDatabase _checkIntegrityBeforeOpening]):
1810         (-[WebIconDatabase _startUpIconDatabase]):
1811         (-[WebIconDatabase _applicationWillTerminate:]):
1812         (-[WebIconDatabase _resetCachedWebPreferences:]):
1813         (importToWebCoreFormat):
1814         * WebView/WebView.mm:
1815         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
1816
1817 2011-03-03  Jessie Berlin  <jberlin@apple.com>
1818
1819         Reviewed by Adam Roben.
1820
1821         WebKit2: Use CFNetwork Sessions API.
1822         https://bugs.webkit.org/show_bug.cgi?id=55435.
1823
1824         Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
1825
1826         * WebCoreSupport/WebSystemInterface.mm:
1827         (InitWebCoreSystemInterface):
1828         Support using WKCopyRequestWithStorageSession in WebCore.
1829
1830 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
1831
1832         Reviewed by Darin Adler.
1833
1834         REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
1835         https://bugs.webkit.org/show_bug.cgi?id=55633
1836         <rdar://problem/8963023>
1837
1838         * WebCoreSupport/WebChromeClient.h:
1839         * WebCoreSupport/WebChromeClient.mm:
1840         Removed tabsToLinks(). Mac WebKit already implements keyboardUIMode().
1841
1842         * WebView/WebView.mm: (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
1843         Removed an incorrect comment. We actually get a value of 2 on Snow Leopard, and we don't
1844         require both bits to be set. The rest of the comment might be wrong too, but I'm not sure,
1845         so I've preserved it.
1846
1847 2011-03-02  Jessie Berlin  <jberlin@apple.com>
1848
1849         Rubber-stamped by Dan Bernstein.
1850
1851         Fix crashes in private browsing tests in WK1 on Snow Leopard.
1852
1853         * WebCoreSupport/WebSystemInterface.mm:
1854         (InitWebCoreSystemInterface):
1855         Put the INIT call for wkCreatePrivateStorageSession outside of the
1856         #if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
1857         guards.
1858
1859 2011-03-02  Jessie Berlin  <jberlin@apple.com>
1860
1861         Reviewed by Adam Roben.
1862
1863         WebKit2: Use CFNetwork Sessions API.
1864         https://bugs.webkit.org/show_bug.cgi?id=55435.
1865
1866         Add the ability to create a Private Browsing Storage Session.
1867
1868         * WebCoreSupport/WebSystemInterface.mm:
1869         (InitWebCoreSystemInterface):
1870         Support calling wkCreatePrivateStorageSession from WebCore.
1871
1872 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
1873
1874         Reviewed by David Levin.
1875
1876         Add feature define for data transfer items
1877         https://bugs.webkit.org/show_bug.cgi?id=55510
1878
1879         * Configurations/FeatureDefines.xcconfig:
1880
1881 2011-03-02  Sam Weinig  <sam@webkit.org>
1882
1883         Reviewed by Anders Carlsson.
1884
1885         Fix remaining localization issues by piping all localized strings through WebCore's
1886         localization bottleneck.
1887         <rdar://problem/8728860>
1888
1889         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1890         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
1891         * Misc/WebKitErrors.m:
1892         * Misc/WebLocalizableStringsInternal.h: Added.
1893         * Misc/WebLocalizableStringsInternal.mm: Added.
1894         (WebLocalizedStringInternal):
1895         * Panels/WebAuthenticationPanel.m:
1896         (-[WebAuthenticationPanel setUpForChallenge:]):
1897         * Plugins/Hosted/NetscapePluginHostManager.mm:
1898         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1899         * WebCoreSupport/WebEditorClient.mm:
1900         (undoNameForEditAction):
1901         * WebCoreSupport/WebInspectorClient.mm:
1902         (WebInspectorFrontendClient::updateWindowTitle):
1903         (-[WebInspectorWindowController validateUserInterfaceItem:]):
1904         * WebCoreSupport/WebKeyGenerator.m:
1905         (-[WebKeyGenerator strengthMenuItemTitles]):
1906         (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]):
1907         * WebCoreSupport/WebPlatformStrategies.mm:
1908         * WebView/WebHTMLView.mm:
1909         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1910         * WebView/WebPDFView.mm:
1911         (-[WebPDFView menuForEvent:]):
1912
1913 2011-03-01  Brian Weinstein  <bweinstein@apple.com>
1914
1915         Reviewed by Adam Roben.
1916
1917         Part of WebKit2: Need a way to send notifications to client when cookies change
1918         https://bugs.webkit.org/show_bug.cgi?id=55427
1919         <rdar://problem/9056027>
1920         
1921         Add stubs for CookiesStrategy on Mac WebKit1.
1922
1923         * WebCoreSupport/WebPlatformStrategies.h:
1924         * WebCoreSupport/WebPlatformStrategies.mm:
1925         (WebPlatformStrategies::createCookiesStrategy):
1926         (WebPlatformStrategies::notifyCookiesChanged):
1927
1928 2011-03-01  Philippe Normand  <pnormand@igalia.com>
1929
1930         Reviewed by Eric Carlson.
1931
1932         [GStreamer] support in mac video fullscreen controller
1933         https://bugs.webkit.org/show_bug.cgi?id=52280
1934
1935         Factored the code to configure the video overlay in a new private
1936         method of the controller and added GStreamer support to it.
1937
1938         * WebView/WebVideoFullscreenController.h:
1939         * WebView/WebVideoFullscreenController.mm:
1940         (-[WebVideoFullscreenController setupVideoOverlay:]):
1941         (-[WebVideoFullscreenController windowDidLoad]):
1942         (-[WebVideoFullscreenController setMediaElement:WebCore::]):
1943         (-[WebVideoFullscreenController windowDidExitFullscreen]):
1944
1945 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
1946
1947         Reviewed by Timothy Hatcher.
1948
1949         All Console Messages should be passed to ChromeClients.
1950         https://bugs.webkit.org/show_bug.cgi?id=54926
1951
1952         Add a new private UIDelegate method, -webView:addMessageToConsole:withSource:,
1953         which supersedes -webView:addMessageToConsole if it exists. The new delegate
1954         does not filter to only JavaScript originated console messages. The old
1955         delegate is left around for clients that expect filtered messages, like
1956         DashCode and older versions of Safari.
1957
1958         The dictionary message passed to the delegate now includes more information
1959         about the message source, type, and level.
1960
1961         * WebCoreSupport/WebChromeClient.mm:
1962         (stringForMessageSource):
1963         (stringForMessageType):
1964         (stringForMessageLevel):
1965         (WebChromeClient::addMessageToConsole):
1966         * WebView/WebUIDelegatePrivate.h:
1967
1968 2011-03-01  Levi Weintraub  <leviw@chromium.org>
1969
1970         Reviewed by Ryosuke Niwa.
1971
1972         Stop instantiating legacy editing Positions in VisiblePosition
1973         https://bugs.webkit.org/show_bug.cgi?id=52919
1974
1975         Changing usage of legacy VisiblePosition constructor. Since we were dealing
1976         with positions from DOM Ranges, we're guaranteed a parent-anchored position.
1977
1978         * WebView/WebFrame.mm:
1979         (-[WebFrame _caretRectAtPosition:affinity:]):
1980         * WebView/WebFrameInternal.h:
1981         * WebView/WebTextCompletionController.mm:
1982         (-[WebTextCompletionController doCompletion]):
1983
1984 2011-03-01  Sam Weinig  <sam@webkit.org>
1985
1986         Reviewed by Timothy Hatcher.
1987
1988         WebKit2 needs to be made localizable
1989         https://bugs.webkit.org/show_bug.cgi?id=55483
1990
1991         * WebCoreSupport/WebPlatformStrategies.mm:
1992         Use WebCore's localizedString function instead of WebLocalizableStrings
1993         since WebCore is now responsible for localization.
1994
1995 2011-02-25 Steve Block <steveblock@google.com>
1996
1997         Reviewed by Jeremy Orlow.
1998
1999         Bridge.h should not include BridgeJSC.h
2000         https://bugs.webkit.org/show_bug.cgi?id=55212
2001
2002         Include BridgeJSC.h directly instead.
2003
2004         * Plugins/Hosted/ProxyInstance.h:
2005         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2006
2007 2011-02-28  Chang Shu  <cshu@webkit.org>
2008
2009         Reviewed by Ryosuke Niwa.
2010
2011         Remove the support of Frame::isContentEditable and its dependencies.
2012         https://bugs.webkit.org/show_bug.cgi?id=54292
2013
2014         Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
2015
2016         * WebCoreSupport/WebEditorClient.h:
2017         * WebCoreSupport/WebEditorClient.mm:
2018         * WebView/WebView.mm:
2019         (-[WebView setEditable:]):
2020         (-[WebView isEditable]):
2021         * WebView/WebViewData.h:
2022
2023 2011-02-28  Oliver Hunt  <oliver@apple.com>
2024
2025         Reviewed by Gavin Barraclough.
2026
2027         Make ScopeChainNode GC allocated
2028         https://bugs.webkit.org/show_bug.cgi?id=55283
2029
2030         More updates for the absence of the ScopeChain class
2031
2032         * WebView/WebScriptDebugDelegate.mm:
2033         (-[WebScriptCallFrame scopeChain]):
2034
2035 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
2036
2037         Reviewed by Pavel Feldman.
2038
2039         DumpRenderTree should reset frame opener between tests.
2040         https://bugs.webkit.org/show_bug.cgi?id=54874
2041
2042         Added clearOpener method to WebFramePrivate.
2043
2044         * WebView/WebFrame.mm:
2045         (-[WebFrame _clearOpener]):
2046         * WebView/WebFramePrivate.h:
2047
2048 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2049
2050         Unreviewed, rolling out r79764.
2051         http://trac.webkit.org/changeset/79764
2052         https://bugs.webkit.org/show_bug.cgi?id=55295
2053
2054         "broke Chromium builds" (Requested by rniwa on #webkit).
2055
2056         * WebView/WebFrame.mm:
2057         * WebView/WebFramePrivate.h:
2058
2059 2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>
2060
2061         Reviewed by David Kilzer.
2062
2063         https://bugs.webkit.org/show_bug.cgi?id=48781
2064
2065         Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
2066
2067         Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
2068         should paint the default broken image when an image fails to load or decode.  The method also passes the
2069         URL of the failed image.
2070
2071         * WebCoreSupport/WebFrameLoaderClient.h:
2072         * WebCoreSupport/WebFrameLoaderClient.mm:
2073         (WebFrameLoaderClient::shouldPaintBrokenImage):
2074         * WebView/WebDelegateImplementationCaching.h:
2075         * WebView/WebDelegateImplementationCaching.mm: Added case for passing one object.
2076         (CallResourceLoadDelegateReturningBoolean):
2077         * WebView/WebResourceLoadDelegatePrivate.h:
2078         * WebView/WebView.mm:
2079         (-[WebView _cacheResourceLoadDelegateImplementations]):
2080
2081 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
2082
2083         Reviewed by Pavel Feldman.
2084
2085         DumpRenderTree should reset frame opener between tests.
2086         https://bugs.webkit.org/show_bug.cgi?id=54874
2087
2088         Added clearOpener method to WebFramePrivate.
2089
2090         * WebView/WebFrame.mm:
2091         (-[WebFrame _clearOpener]):
2092         * WebView/WebFramePrivate.h:
2093
2094 2011-02-25  Mark Rowe  <mrowe@apple.com>
2095
2096         <rdar://problem/8902546> Build fix.
2097
2098         * Misc/QuickDrawCompatibility.h:
2099
2100 2011-02-24  Anders Carlsson  <andersca@apple.com>
2101
2102         Fix clang build.
2103
2104         * WebCoreSupport/WebKeyGenerator.m:
2105         (toWebCertificateParseResult):
2106         (-[WebKeyGenerator addCertificatesToKeychainFromData:]):
2107         * WebView/WebTextCompletionController.mm:
2108
2109 2011-02-24  Peter Kasting  <pkasting@google.com>
2110
2111         Reviewed by Eric Seidel.
2112
2113         Drop the "U; " encryption level from the User Agent string.
2114         https://bugs.webkit.org/show_bug.cgi?id=54566
2115
2116         * WebView/WebView.mm:
2117         (+[WebView _standardUserAgentWithApplicationName:]):
2118
2119 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
2120
2121         Unreviewed, rolling out r79570.
2122         http://trac.webkit.org/changeset/79570
2123         https://bugs.webkit.org/show_bug.cgi?id=54874
2124
2125         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
2126         was not updated
2127
2128         * WebView/WebFrame.mm:
2129         * WebView/WebFramePrivate.h:
2130
2131 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
2132
2133         Reviewed by Alexey Proskuryakov.
2134
2135         DumpRenderTree should reset frame opener between tests.
2136         https://bugs.webkit.org/show_bug.cgi?id=54874
2137
2138         Added clearOpener method to WebFramePrivate.
2139
2140         * WebView/WebFrame.mm:
2141         (-[WebFrame _clearOpener]):
2142         * WebView/WebFramePrivate.h:
2143
2144 2011-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2145
2146         Reviewed by Alexey Proskuryakov.
2147
2148         Drop the language tag part from the User Agent string
2149         https://bugs.webkit.org/show_bug.cgi?id=54560
2150
2151         * WebView/WebView.mm:
2152         (+[WebView _standardUserAgentWithApplicationName:]): Drop the
2153         language tag part.
2154
2155 2011-02-22  Brady Eidson  <beidson@apple.com>
2156
2157         Reviewed by Anders Carlsson.
2158
2159         Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
2160         API to view and delete Application Cache data by origin.
2161
2162         * WebCoreSupport/WebApplicationCache.mm:
2163         (+[WebApplicationCache deleteAllApplicationCaches]): Move this implementation into WebCore itself.
2164
2165 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
2166
2167         Reviewed by Kent Tamura.
2168
2169         Rename Position::node() to Position::deprecatedNode()
2170         https://bugs.webkit.org/show_bug.cgi?id=54622
2171
2172         * WebView/WebFrame.mm:
2173         (-[WebFrame _smartDeleteRangeForProposedRange:]):
2174
2175 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
2176
2177         Reviewed by Kent Tamura.
2178
2179         Rename Position::node() to Position::deprecatedNode()
2180         https://bugs.webkit.org/show_bug.cgi?id=54622
2181         
2182         Done the rename.
2183
2184         * WebView/WebFrame.mm:
2185         (-[WebFrame _smartDeleteRangeForProposedRange:]): Since newStart and newEnd are parent-anchored,
2186         use containerNode() and offsetInContainerNode() instead of deprecated member functions.
2187
2188 2011-02-18  Gavin Barraclough  <barraclough@apple.com>
2189
2190         Reviewed by Sam Weinig.
2191
2192         Bug 54786 - Devirtualize JSCell::classInfo()
2193
2194         Instead of making a virtual function call, add a pointer to the ClassInfo
2195         onto Structure.
2196
2197         This removes a virtual function call, and paves the way towards removing all
2198         the createStructure methods, and StructureFlags/AnonymousSlotCount properties
2199         (these should be able to move onto ClassInfo).
2200
2201         Calls to Structure::create must now pass a pointer to the ClassInfo for the
2202         structure. All objects now have a ClassInfo pointer, non-object cell types
2203         still do not.
2204
2205         Changes are most mechanical, involving three steps:
2206             * Remove virtual classInfo() methods.
2207             * Add &s_info parameter to calls to Structure::create.
2208             * Rename ClassInfo static members on classes from 'info' to 's_info',
2209               for consistency.
2210
2211         * Plugins/Hosted/ProxyInstance.mm:
2212         (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
2213         (WebKit::ProxyRuntimeMethod::createStructure):
2214         * Plugins/Hosted/ProxyRuntimeObject.h:
2215         (WebKit::ProxyRuntimeObject::createStructure):
2216         * Plugins/Hosted/ProxyRuntimeObject.mm:
2217         (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
2218         * WebView/WebView.mm:
2219         (aeDescFromJSValue):
2220
2221 2011-02-19  Brian Ryner  <bryner@chromium.org>
2222
2223         Reviewed by Adam Barth.
2224
2225         Add missing #include of DocumentLoader.h, needed since the transitive
2226         include through Document.h is removed.
2227         https://bugs.webkit.org/show_bug.cgi?id=50489
2228
2229         * WebView/WebFrame.mm:
2230
2231 2011-02-19  Charlie Reis  <creis@chromium.org>
2232
2233         Reviewed by Mihai Parparita.
2234
2235         Ensure loading has stopped in HistoryController::goToItem
2236         https://bugs.webkit.org/show_bug.cgi?id=54517
2237
2238         Add a FrameLoaderClient callback for whether to stop loading before goToItem.
2239
2240         Test: http/tests/navigation/forward-to-fragment-fires-onload.html
2241
2242         * WebCoreSupport/WebFrameLoaderClient.mm:
2243         (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
2244         * WebCoreSupport/WebFrameLoaderClient.h:
2245
2246 2011-02-16  David Hyatt  <hyatt@apple.com>
2247
2248         Reviewed by Dan Bernstein.
2249
2250         https://bugs.webkit.org/show_bug.cgi?id=54244
2251         
2252         Convert the line box tree to floating point and eliminate font rounding hacks.  This patch removes all of the rounding
2253         hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
2254         
2255         The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
2256         been changed as well.
2257         
2258         In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
2259         
2260         Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
2261         
2262         Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
2263         still have a precise floating point position.
2264
2265         Justification will now allow subpixel positioning to occur as well.  Platforms that don't support subpixel positioning should already
2266         be rounding justification spacing in their font code.
2267
2268         Many layout test results change on Mac, since rounding hacks were used there and are now gone.
2269
2270         * Misc/WebKitNSStringExtras.mm:
2271         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2272         (-[NSString _web_widthWithFont:]):
2273
2274 2011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
2275
2276         Reviewed by Adam Roben.
2277
2278         HTML5 <details> and <summary>: localized text
2279         https://bugs.webkit.org/show_bug.cgi?id=54260
2280
2281         The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
2282         provide the default label to be used by a <details> tag that has no <summary> child.
2283
2284         * WebCoreSupport/WebPlatformStrategies.h:
2285         * WebCoreSupport/WebPlatformStrategies.mm:
2286         (WebPlatformStrategies::defaultDetailsSummaryText):
2287
2288 2011-02-16  Matthew Delaney  <mdelaney@apple.com>
2289
2290         Reviewed by Simon Fraser.
2291
2292         Allow acceleratesDrawing for WebKit2
2293         https://bugs.webkit.org/show_bug.cgi?id=54511
2294
2295         Plumb through preference for accelerated drawing.
2296         
2297         * WebView/WebPreferenceKeysPrivate.h:
2298         * WebView/WebPreferences.mm:
2299         (+[WebPreferences initialize]):
2300         (-[WebPreferences acceleratedDrawingEnabled]):
2301         (-[WebPreferences setAcceleratedDrawingEnabled:]):
2302         * WebView/WebPreferencesPrivate.h:
2303
2304 2011-02-15  David Kilzer  <ddkilzer@apple.com>
2305
2306         <http://webkit.org/b/54505> Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h
2307
2308         Reviewed by Darin Adler.
2309
2310         * WebView/WebDynamicScrollBarsView.h:
2311         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Removed
2312         declaration.
2313         * WebView/WebDynamicScrollBarsView.mm:
2314         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Moved
2315         implementation into correct category.
2316         * WebView/WebDynamicScrollBarsViewInternal.h:
2317         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Added
2318         declaration.
2319         * WebView/WebHTMLView.mm: Included
2320         WebDynamicScrollBarsViewInternal.h instead of
2321         WebDynamicScrollBarsView.h.
2322
2323 2011-02-14  Oliver Hunt  <oliver@apple.com>
2324
2325         Reviewed by Gavin Barraclough and Geoff Garen.
2326
2327         Refactor handles and weak pointers to become nicer and more automatic
2328         https://bugs.webkit.org/show_bug.cgi?id=54415
2329
2330         Update to use Global<> instead of ProtectedPtr, and refactored slightly
2331         to get global data to places it's needed for when we're assigning to
2332         Global<>s
2333
2334         * ForwardingHeaders/collector/handles/Global.h: Added.
2335         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2336         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2337         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get):
2338         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
2339         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
2340         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2341         (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
2342         (WebKit::NetscapePluginInstanceProxy::evaluate):
2343         (WebKit::NetscapePluginInstanceProxy::invoke):
2344         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2345         (WebKit::NetscapePluginInstanceProxy::construct):
2346         (WebKit::NetscapePluginInstanceProxy::addValueToArray):
2347         * WebView/WebScriptDebugger.h:
2348         * WebView/WebScriptDebugger.mm:
2349         (WebScriptDebugger::WebScriptDebugger):
2350
2351 2011-02-15  Jia Pu  <jpu@apple.com>
2352
2353         Reviewed by Darin Adler.
2354
2355         Autocorrection should respect undo.
2356         https://bugs.webkit.org/show_bug.cgi?id=52221
2357         <rdar://problem/8663399>
2358
2359         Please see WebCore/ChangeLog for detailed description.
2360
2361         * WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
2362
2363         * WebCoreSupport/WebEditorClient.mm:
2364         (WebEditorClient::recordAutocorrectionResponse): Ditto.
2365
2366         * WebView/WebFrame.mm:
2367         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2368              Adopted new signature of ReplaceSelectionCommand::create().
2369
2370 2011-02-15  David Kilzer  <ddkilzer@apple.com>
2371
2372         <http://webkit.org/b/54485> Fix spelling of -inProgramaticScroll
2373
2374         Reviewed by Darin Adler.
2375
2376         * WebView/WebDynamicScrollBarsView.h:
2377         * WebView/WebDynamicScrollBarsView.mm:
2378         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from
2379         -inProgramaticScroll.
2380         * WebView/WebHTMLView.mm:
2381         (-[WebHTMLView _frameOrBoundsChanged]): Corrected method name.
2382
2383 2011-02-15  Kenneth Russell  <kbr@google.com>
2384
2385         Reviewed by Darin Fisher.
2386
2387         Allow controlling minimum DOMTimer interval on a per-page basis
2388         https://bugs.webkit.org/show_bug.cgi?id=54312
2389
2390         Added needed methods to implement LayoutTestController's new
2391         setMinimumTimerInterval method.
2392
2393         * WebView/WebView.mm:
2394         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2395         (+[WebView _defaultMinimumTimerInterval]):
2396         (-[WebView _setMinimumTimerInterval:]):
2397         * WebView/WebViewPrivate.h:
2398
2399 2011-02-11  Geoffrey Garen  <ggaren@apple.com>
2400
2401         Reviewed by Oliver Hunt.
2402
2403         A little more encapsulation for the heap: Removed CollectorHeapIterator
2404         https://bugs.webkit.org/show_bug.cgi?id=54298
2405
2406         * Misc/WebCoreStatistics.mm:
2407         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
2408         (+[WebCoreStatistics javaScriptObjectTypeCounts]): Updated for new typedef.
2409
2410 2011-02-10  Nate Chapin  <japhet@chromium.org>
2411
2412         Reviewed by Adam Barth.
2413
2414         Update calls to DocumentWriter.
2415         https://bugs.webkit.org/show_bug.cgi?id=50489
2416
2417         * WebView/WebFrame.mm:
2418         (-[WebFrame _canProvideDocumentSource]):
2419
2420 2011-02-10  Chris Fleizach  <cfleizach@apple.com>
2421
2422         Reviewed by Anders Carlsson.
2423
2424         AX: AX needs to stop using WebCoreViewFactory
2425         https://bugs.webkit.org/show_bug.cgi?id=54153
2426
2427         * WebCoreSupport/WebSystemInterface.mm:
2428         (InitWebCoreSystemInterface):
2429
2430 2011-02-10  Peter Varga  <pvarga@webkit.org>
2431
2432         Reviewed by Csaba Osztrogonác.
2433
2434         Remove PCRE source from trunk
2435         https://bugs.webkit.org/show_bug.cgi?id=54188
2436
2437         * ForwardingHeaders/pcre/pcre.h: Removed.
2438
2439 2011-02-09  Pavel Feldman  <pfeldman@chromium.org>
2440
2441         Reviewed by Yury Semikhatsky.
2442
2443         Web Inspector: follow up on InspectorAgent split -
2444         removing unnecessary methods from InspectorController.
2445         https://bugs.webkit.org/show_bug.cgi?id=54093
2446
2447         * WebInspector/WebInspector.mm:
2448         (-[WebInspector showConsole:]):
2449         (-[WebInspector stopProfilingJavaScript:]):
2450
2451 2011-02-08  Dan Bernstein  <mitz@apple.com>
2452
2453         Reviewed by Jon Honeycutt and Maciej Stachowiak.
2454
2455         <rdar://problem/8959420> Find in Mail no longer cycles around
2456
2457         * WebView/WebHTMLView.mm:
2458         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Set
2459         the wrap option according to the flag.
2460
2461 2011-02-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2462
2463         Unreviewed, rolling out r77980.
2464         http://trac.webkit.org/changeset/77980
2465         https://bugs.webkit.org/show_bug.cgi?id=54043
2466
2467         "Crashes on Windows and Linux..." (Requested by leviw on
2468         #webkit).
2469
2470         * WebView/WebFrame.mm:
2471         (-[WebFrame _caretRectAtNode:offset:affinity:]):
2472         * WebView/WebFrameInternal.h:
2473         * WebView/WebTextCompletionController.mm:
2474         (-[WebTextCompletionController doCompletion]):
2475
2476 2011-02-08  Levi Weintraub  <leviw@chromium.org>
2477
2478         Reviewed by Ryosuke Niwa.
2479
2480         Stop instantiating legacy editing Positions in VisiblePosition
2481         https://bugs.webkit.org/show_bug.cgi?id=52919
2482
2483         Changing usage of legacy VisiblePosition constructor. Since we were dealing
2484         with positions from DOM Ranges, we're guaranteed a parent-anchored position.
2485
2486         * WebView/WebFrame.mm:
2487         (-[WebFrame _caretRectAtPosition:affinity:]):
2488         * WebView/WebFrameInternal.h:
2489         * WebView/WebTextCompletionController.mm:
2490         (-[WebTextCompletionController doCompletion]):
2491
2492 2011-02-08  Adam Barth  <abarth@webkit.org>
2493
2494         Reviewed by Eric Seidel.
2495
2496         Remove orphan code from old parser
2497         https://bugs.webkit.org/show_bug.cgi?id=53984
2498
2499         * WebCoreSupport/WebChromeClient.h:
2500
2501 2011-02-02  Ilya Tikhonovsky  <loislo@chromium.org>
2502
2503         Reviewed by Yury Semikhatsky.
2504
2505         Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
2506
2507         https://bugs.webkit.org/show_bug.cgi?id=53169
2508
2509         Minor change enforced by major changes in WebCore/inspector/InspectorController.
2510
2511         * WebInspector/WebInspector.mm:
2512         (-[WebInspector isTimelineProfilingEnabled]):
2513
2514 2011-02-07  Enrica Casucci  <enrica@apple.com>
2515
2516         Reviewed Adam Roben and Darin Adler.
2517
2518         WebKit2: drag and drop support on Windows.
2519         https://bugs.webkit.org/show_bug.cgi?id=52775
2520
2521         Removed createDragImageForLink from DragClient.
2522
2523         * WebCoreSupport/WebDragClient.h:
2524         * WebCoreSupport/WebDragClient.mm:
2525         (WebDragClient::startDrag):
2526
2527 2011-02-03  Yury Semikhatsky  <yurys@chromium.org>
2528
2529         Reviewed by Pavel Feldman.
2530
2531         Web Inspector: remove settings related methods from InspectorClient
2532         https://bugs.webkit.org/show_bug.cgi?id=53686
2533
2534         * WebCoreSupport/WebInspectorClient.h:
2535         * WebCoreSupport/WebInspectorClient.mm:
2536         (WebInspectorClient::openInspectorFrontend):
2537         (WebInspectorFrontendClient::WebInspectorFrontendClient):
2538
2539 2011-02-03  James Kozianski  <koz@chromium.org>
2540
2541         Reviewed by Dimitri Glazkov.
2542
2543         Add navigator.registerProtocolHandler behind a flag.
2544         https://bugs.webkit.org/show_bug.cgi?id=52609
2545
2546         * Configurations/FeatureDefines.xcconfig:
2547
2548 2011-02-03  Adam Langley  <agl@chromium.org>
2549
2550         Reviewed by Adam Barth.
2551
2552         Plumb mixed script URL to FrameLoaderClient
2553         https://bugs.webkit.org/show_bug.cgi?id=52384
2554
2555         Regressions covered by http/tests/security/mixedContent/*
2556
2557         * WebCoreSupport/WebFrameLoaderClient.h:
2558         * WebCoreSupport/WebFrameLoaderClient.mm:
2559         (WebFrameLoaderClient::didRunInsecureContent):
2560
2561 2011-02-03  Beth Dakin  <bdakin@apple.com>
2562
2563         Reviewed by Sam Weinig.
2564
2565         Fix for <rdar://problem/8944544> Ability to animate track
2566         for WKPainter scrollers
2567
2568         * WebCoreSupport/WebSystemInterface.mm:
2569         (InitWebCoreSystemInterface):
2570
2571 2011-02-02  Mark Rowe  <mrowe@apple.com>
2572
2573         Reviewed by Beth Dakin.
2574
2575         <rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement::createImageBuffer().
2576
2577         * WebCoreSupport/WebSystemInterface.mm:
2578         (InitWebCoreSystemInterface): Add some missing initializers.
2579
2580 2011-02-02  Steve Lacey  <sjl@chromium.org>
2581
2582         Reviewed by Eric Carlson.
2583
2584         Implement basic media statistics on media elements.
2585         https://bugs.webkit.org/show_bug.cgi?id=53322
2586
2587         * Configurations/FeatureDefines.xcconfig:
2588
2589 2011-02-01  Sam Weinig  <sam@webkit.org>
2590
2591         Reviewed by Beth Dakin.
2592
2593         Part 2 for <rdar://problem/8492788>
2594         Adopt WKScrollbarPainterController
2595
2596         Use header detection to define scrollbar painting controller #define.
2597
2598         * WebCoreSupport/WebSystemInterface.mm:
2599         (InitWebCoreSystemInterface):
2600
2601 2011-02-01  David Hyatt  <hyatt@apple.com>
2602
2603         Reviewed by Oliver Hunt.
2604
2605         https://bugs.webkit.org/show_bug.cgi?id=53520
2606         
2607         Remove the physical terminology from IntRect and FloatRect.
2608         
2609         Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
2610         we need to update our terminology to be more accurate.
2611
2612         I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
2613         renaming right() and bottom() to maxX() and maxY().  These terms remain accurate
2614         even for flipped rectangles.
2615
2616         * WebView/WebHTMLView.mm:
2617         (setNeedsDisplayInRect):
2618
2619 2011-02-01  Beth Dakin  <bdakin@apple.com>
2620
2621         Reviewed by Sam Weinig.
2622
2623         Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController
2624
2625         * WebCoreSupport/WebSystemInterface.mm:
2626         (InitWebCoreSystemInterface):
2627
2628 2011-02-01  Dave Hyatt  <hyatt@apple.com>
2629
2630         Reviewed by Darin Adler.
2631
2632         https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work
2633         with vertical text.
2634
2635         Change printing functions to check writing-mode and properly swap width and height
2636         as needed.
2637
2638         * WebView/WebDynamicScrollBarsView.mm:
2639         (-[WebDynamicScrollBarsView setScrollOrigin:updatePositionAtAll:immediately:]):
2640         * WebView/WebFrame.mm:
2641         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
2642         * WebView/WebFrameInternal.h:
2643         * WebView/WebHTMLView.mm:
2644         (-[WebHTMLView _web_setPrintingModeRecursive]):
2645         (-[WebHTMLView _web_clearPrintingModeRecursive]):
2646         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
2647         (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]):
2648         (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
2649         (-[WebHTMLView _endPrintMode]):
2650         (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
2651         (-[WebHTMLView _endScreenPaginationMode]):
2652         (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
2653         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumPageLogicalWidth:adjustViewSize:paginateScreenContent:]):
2654         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
2655         (-[WebHTMLView _scaleFactorForPrintOperation:]):
2656         (-[WebHTMLView setPageWidthForPrinting:]):
2657         (-[WebHTMLView knowsPageRange:]):
2658
2659 2011-01-31  Oliver Hunt  <oliver@apple.com>
2660
2661         Convert markstack to a slot visitor API
2662         https://bugs.webkit.org/show_bug.cgi?id=53219
2663
2664         rolling r77098, r77099, r77100, r77109, and
2665         r77111 back in, along with a few more Qt fix attempts.
2666
2667         * WebView/WebScriptDebugDelegate.mm:
2668         (-[WebScriptCallFrame scopeChain]):
2669
2670 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
2671
2672         Unreviewed, rolling out r77098, r77099, r77100, r77109, and
2673         r77111.
2674         http://trac.webkit.org/changeset/77098
2675         http://trac.webkit.org/changeset/77099
2676         http://trac.webkit.org/changeset/77100
2677         http://trac.webkit.org/changeset/77109
2678         http://trac.webkit.org/changeset/77111
2679         https://bugs.webkit.org/show_bug.cgi?id=53219
2680
2681         Qt build is broken
2682
2683         * WebView/WebScriptDebugDelegate.mm:
2684         (-[WebScriptCallFrame scopeChain]):
2685
2686 2011-01-30  Oliver Hunt  <oliver@apple.com>
2687
2688         Convert markstack to a slot visitor API
2689         https://bugs.webkit.org/show_bug.cgi?id=53219
2690
2691         rolling r77006 and r77020 back in.
2692
2693         * WebView/WebScriptDebugDelegate.mm:
2694         (-[WebScriptCallFrame scopeChain]):
2695
2696 2011-01-28  Geoffrey Garen  <ggaren@apple.com>
2697
2698         Reviewed by Maciej Stachowiak.
2699
2700         Some more Heap cleanup.
2701         https://bugs.webkit.org/show_bug.cgi?id=53357
2702
2703         Updated for JavaScriptCore changes.
2704
2705         * Misc/WebCoreStatistics.mm:
2706         (+[WebCoreStatistics memoryStatistics]):
2707
2708 2011-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2709
2710         Unreviewed, rolling out r77006 and r77020.
2711         http://trac.webkit.org/changeset/77006
2712         http://trac.webkit.org/changeset/77020
2713         https://bugs.webkit.org/show_bug.cgi?id=53360
2714
2715         "Broke Windows tests" (Requested by rniwa on #webkit).
2716
2717         * WebView/WebScriptDebugDelegate.mm:
2718         (-[WebScriptCallFrame scopeChain]):
2719
2720 2011-01-27  Oliver Hunt  <oliver@apple.com>
2721
2722         Reviewed by Geoffrey Garen.
2723
2724         Convert markstack to a slot visitor API
2725         https://bugs.webkit.org/show_bug.cgi?id=53219
2726
2727         Update to new marking api
2728
2729         * WebView/WebScriptDebugDelegate.mm:
2730         (-[WebScriptCallFrame scopeChain]):
2731
2732 2011-01-28  Dan Bernstein  <mitz@apple.com>
2733
2734         Reviewed by Sam Weinig.
2735
2736         <select> can't display right-to-left (rtl) languages
2737         https://bugs.webkit.org/show_bug.cgi?id=19785
2738
2739         * WebCoreSupport/WebChromeClient.h:
2740         * WebCoreSupport/WebChromeClient.mm:
2741         (WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
2742         (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. Returns true.
2743
2744 2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2745
2746         Unreviewed, rolling out r76891.
2747         http://trac.webkit.org/changeset/76891
2748         https://bugs.webkit.org/show_bug.cgi?id=53280
2749
2750         Makes every layout test crash (Requested by othermaciej on
2751         #webkit).
2752
2753         * Misc/WebIconDatabase.mm:
2754         (-[ThreadEnabler threadEnablingSelector:]):
2755         (importToWebCoreFormat):
2756
2757 2011-01-27  Nate Chapin  <japhet@chromium.org>
2758
2759         Reviewed by Adam Barth.
2760
2761         Use Document::url() instead of FrameLoader::url().
2762         https://bugs.webkit.org/show_bug.cgi?id=41165
2763
2764         * WebView/WebView.mm:
2765         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
2766
2767 2011-01-27  Dan Bernstein  <mitz@apple.com>
2768
2769         Rubber-stamped by Anders Carlsson.
2770
2771         Reverted an accidental change in r76561.
2772
2773         * WebView/WebHTMLView.mm:
2774
2775 2011-01-26  David Kilzer  <ddkilzer@apple.com>
2776
2777         <http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork
2778         <rdar://problem/8821760>
2779
2780         Reviewed by Antti Koivisto.
2781
2782         * WebCoreSupport/WebSystemInterface.mm:
2783         (InitWebCoreSystemInterface): Added initialization for
2784         GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.
2785
2786 2011-01-26  Beth Dakin  <bdakin@apple.com>
2787
2788         Reviewed by Darin Adler.
2789
2790         Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics 
2791         when using WKScrollbars.
2792
2793         * WebCoreSupport/WebSystemInterface.mm:
2794         (InitWebCoreSystemInterface):
2795
2796 2011-01-25  Darin Adler  <darin@apple.com>
2797
2798         Reviewed by Anders Carlsson.
2799
2800         WebKit is using CSBackupSetItemExcluded incorrectly
2801         https://bugs.webkit.org/show_bug.cgi?id=53095
2802         rdar://problem/8790540
2803
2804         * Misc/WebIconDatabase.mm:
2805         (importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded.
2806         It was incorrect, and this responsibility has been moved to WebCore.
2807
2808 2011-01-24  Chris Marrin  <cmarrin@apple.com>
2809
2810         Reviewed by Eric Seidel.
2811
2812         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
2813         https://bugs.webkit.org/show_bug.cgi?id=53041
2814
2815         * Configurations/FeatureDefines.xcconfig:
2816
2817 2011-01-25  Yury Semikhatsky  <yurys@chromium.org>
2818
2819         Reviewed by Pavel Feldman.
2820
2821         Web Inspector: remove "attached" state related methods from InspectorAgent
2822         https://bugs.webkit.org/show_bug.cgi?id=53086
2823
2824         * WebCoreSupport/WebInspectorClient.h:
2825         * WebCoreSupport/WebInspectorClient.mm:
2826         (-[WebInspectorWindowController showWindow:]):
2827         (-[WebInspectorWindowController attach]):
2828         (-[WebInspectorWindowController detach]):
2829
2830 2011-01-23  Dan Bernstein  <mitz@apple.com>
2831
2832         Reviewed by John Sullivan.
2833
2834         <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter
2835
2836         * WebCoreSupport/WebChromeClient.mm:
2837         (WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.
2838
2839 2011-01-22  Alexey Proskuryakov  <ap@apple.com>
2840
2841         Reviewed by Darin Adler.
2842
2843         https://bugs.webkit.org/show_bug.cgi?id=52473
2844         Auto-scaling to avoid orphans is broken, remove dysfunctional code
2845
2846         * WebView/WebHTMLView.mm:
2847         (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
2848         (-[WebHTMLView _scaleFactorForPrintOperation:]):
2849         (-[WebHTMLView knowsPageRange:]):
2850
2851 2011-01-21  Mark Rowe  <mrowe@apple.com>
2852
2853         Rubber-stamped by Jon Honeycutt.
2854
2855         Fix the build when using Clang by removing some unused variables.
2856
2857         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2858         (-[WebHostedNetscapePluginView updateAndSetWindow]):
2859         * WebView/WebFullScreenController.mm:
2860         (-[WebFullScreenController enterFullscreen:]):
2861         (-[WebFullScreenController exitFullscreen]):
2862
2863 2011-01-21  Chris Rogers  <crogers@google.com>
2864
2865         Reviewed by Darin Fisher.
2866
2867         Add run-time enable support for the web audio API
2868         https://bugs.webkit.org/show_bug.cgi?id=52741
2869
2870         * WebView/WebPreferenceKeysPrivate.h:
2871         * WebView/WebPreferences.mm:
2872         (-[WebPreferences webAudioEnabled]):
2873         (-[WebPreferences setWebAudioEnabled:]):
2874         * WebView/WebPreferencesPrivate.h:
2875         * WebView/WebView.mm:
2876         (-[WebView _preferencesChangedNotification:]):
2877
2878 2011-01-20  John Sullivan  <sullivan@apple.com>
2879
2880         Reviewed by Mark Rowe.
2881
2882         Shift-tab doesn't cycle through fields in http authentication panel
2883         https://bugs.webkit.org/show_bug.cgi?id=52850
2884
2885         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
2886         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
2887         Re-wired the key loop so that there aren't two views with the same nextKeyView.
2888
2889 2011-01-20  Beth Dakin  <bdakin@apple.com>
2890
2891         Reviewed by Geoffrey Garen.
2892
2893         Fix for <rdar://problem/8890255>
2894
2895         Allow WebKitSystemInterface to draw scrollbars 
2896         when appropriate.
2897         * WebCoreSupport/WebSystemInterface.mm:
2898         (InitWebCoreSystemInterface):
2899
2900 2011-01-19  Simon Fraser  <simon.fraser@apple.com>
2901
2902         Reviewed by Sam Weinig.
2903
2904         GraphicsLayers in subframes can get sync'd multiple times
2905         https://bugs.webkit.org/show_bug.cgi?id=52489
2906
2907         * WebView/WebView.mm:
2908         (-[WebView _syncCompositingChanges]): syncCompositingStateRecursive()
2909         was renamed to syncCompositingStateIncludingSubframes().
2910
2911 2011-01-19  Darin Adler  <darin@apple.com>
2912
2913         Reviewed by Sam Weinig.
2914
2915         Would like script debugging protocol method to differentiate between caught and uncaught exceptions
2916         https://bugs.webkit.org/show_bug.cgi?id=52104
2917         rdar://problem/8704226
2918
2919         * WebView/WebDelegateImplementationCaching.h:
2920         Fix type of second integer in CallScriptDebugDelegate function overload
2921         to be int to match the actual Objective-C method. Added a new overload
2922         that includes a BOOL in the right place. Added a boolean named
2923         exceptionWasRaisedExpectsHasHandlerFlag.
2924
2925         * WebView/WebDelegateImplementationCaching.mm:
2926         (CallDelegate): Added overloads as above.
2927         (CallScriptDebugDelegate): Ditto.
2928
2929         * WebView/WebScriptDebugDelegate.h: Added new method with the additional
2930         boolean argument. Marked the old method informally deprecated.
2931
2932         * WebView/WebScriptDebugger.mm:
2933         (WebScriptDebugger::exception): Added code to call with or without the
2934         boolean depending on exceptionWasRaisedExpectsHasHandlerFlag.
2935
2936         * WebView/WebView.mm:
2937         (-[WebView _cacheScriptDebugDelegateImplementations]): Set up the
2938         exceptionWasRaisedExpectsHasHandlerFlag. Also fixed old code that was not
2939         guaranteed to set didParseSourceExpectsBaseLineNumber to NO.
2940
2941 2011-01-19  Tony Gentilcore  <tonyg@chromium.org>
2942
2943         Reviewed by Mihai Parparita.
2944
2945         Perform some forward declaration
2946         https://bugs.webkit.org/show_bug.cgi?id=52522
2947
2948         * Misc/WebKitNSStringExtras.mm:
2949
2950 2011-01-19  Pavel Podivilov  <podivilov@chromium.org>
2951
2952         Reviewed by Yury Semikhatsky.
2953
2954         Web Inspector: [JSC] scripts have incorrect starting line (always 1).
2955         https://bugs.webkit.org/show_bug.cgi?id=52721
2956
2957         * WebView/WebScriptDebugger.h:
2958         * WebView/WebScriptDebugger.mm:
2959         (toNSString):
2960         (WebScriptDebugger::sourceParsed):
2961
2962 2011-01-19  Levi Weintraub  <leviw@google.com>
2963
2964         Reviewed by Ryosuke Niwa.
2965
2966         Updating to use Position::parentAnchoredEquivalent instead of
2967         the old htmlediting rangeCompliantEquivalent.
2968
2969         remove rangeCompliantEquivalent and replace it with Position methods
2970         https://bugs.webkit.org/show_bug.cgi?id=25057
2971
2972         * WebView/WebFrame.mm:
2973         (-[WebFrame _smartDeleteRangeForProposedRange:]):
2974
2975 2011-01-18  Chris Fleizach  <cfleizach@apple.com>
2976
2977         Reviewed by Darin Adler.
2978
2979         REGRESSION: A problem with Voiceover and finding links
2980         https://bugs.webkit.org/show_bug.cgi?id=52324
2981
2982         * WebView/WebDynamicScrollBarsView.mm:
2983         (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
2984
2985 2011-01-17  David Kilzer  <ddkilzer@apple.com>
2986
2987         <http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project
2988
2989         Reviewed by Dan Bernstein.
2990
2991         * MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and
2992         DOMDocumentPrivate.h to the PrivateHeaders directory.
2993
2994 2011-01-17  Enrica Casucci  <enrica@apple.com>
2995
2996         Reviewed by Alexey Proskuryakov.
2997
2998         Drag and drop support: refactoring of image from link and image from selection
2999         https://bugs.webkit.org/show_bug.cgi?id=52496
3000
3001         This work cleans up the Mac code and makes it more similar to the Windows implementation,
3002         avoiding the use of an NSView when the FrameView can be used.
3003         The refactoring is a necessary step towards the complete support of drag and drop
3004         in WebKit2.
3005
3006         * WebCoreSupport/WebDragClient.mm:
3007         (WebDragClient::createDragImageForLink): Added.
3008         * WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL.
3009         * WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL.
3010
3011 2011-01-17  Pavel Feldman  <pfeldman@chromium.org>
3012
3013         Reviewed by Yury Semikhatsky.
3014
3015         Web Inspector: simplify debugger enabling routine.
3016         https://bugs.webkit.org/show_bug.cgi?id=52472
3017
3018         * WebInspector/WebInspector.mm:
3019         (-[WebInspector startDebuggingJavaScript:]):
3020
3021 2011-01-16  Dan Bernstein  <mitz@apple.com>
3022
3023         Reviewed by Simon Fraser.
3024
3025         Assertion failure (!inSetWindow) with in-process plug-in in plugins/destroy-on-setwindow.html
3026         https://bugs.webkit.org/show_bug.cgi?id=52550
3027
3028         * Plugins/WebNetscapePluginView.mm:
3029         (-[WebNetscapePluginView setWindowIfNecessary]): Removed the assertion, making sure
3030         that inSetWindow remains YES until we exit the top-level setWindowIfNecessary.
3031
3032 2011-01-16  Simon Fraser  <simon.fraser@apple.com>
3033
3034         Reviewed by Dan Bernstein.
3035
3036         Issues with iframes and plugins when the WebView is scaled.
3037         <rdar://problem/6213380>
3038         
3039         When _scaleWebView has been called on a WebView, iframes
3040         in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
3041         This is caused by AppKit NSViews not playing nicely with the scale
3042         applied through style.
3043         
3044         Work around most of these issues by adjusting the bounds size
3045         of widgets to allow iframe contents to paint with the correct scale,
3046         and fix various places in the code where we relied on coordinate
3047         transforms via NSViews (which ignore CSS transforms).
3048
3049         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3050         (-[WebHostedNetscapePluginView updateAndSetWindow]):
3051         * WebView/WebFrameView.mm:
3052         (-[WebFrameView setBoundsSize:]):
3053
3054 2011-01-16  Beth Dakin  <bdakin@apple.com>
3055
3056         Reviewed by Kevin Decker.
3057
3058         Fix for <rdar://problem/8871204>
3059
3060         Don't try to save elasticity state. Just rely on
3061         NSScrollElasticityAutomatic to restore the correct state.
3062         * WebCoreSupport/WebFrameLoaderClient.h:
3063         * WebCoreSupport/WebFrameLoaderClient.mm:
3064         (WebFrameLoaderClient::WebFrameLoaderClient):
3065         (WebFrameLoaderClient::dispatchDidFirstLayout):
3066         (WebFrameLoaderClient::provisionalLoadStarted):
3067
3068 2011-01-14  Simon Fraser  <simon.fraser@apple.com>
3069
3070         Reviewed by Dan Bernstein.
3071
3072         Plugins render incorrectly with transformed ancestors
3073         https://bugs.webkit.org/show_bug.cgi?id=52507
3074         
3075         -[NSView visibleRect] gives the wrong answer if there are CSS transforms
3076         in the ancestor chain of a plugin.
3077         
3078         So use of this method with calls to -actualVisibleRectInWindow, which
3079         maps rects through the render tree to compute the correct rect,
3080         clipping via windowClipRect() if necessary.
3081         
3082         Not testable, because doing so relies on the behavior of some
3083         plugins, which stop rendering if setWindow passes an empty rect.
3084
3085         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3086         (-[WebHostedNetscapePluginView updateAndSetWindow]):
3087         * Plugins/WebBaseNetscapePluginView.h:
3088         * Plugins/WebBaseNetscapePluginView.mm:
3089         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
3090         * Plugins/WebNetscapePluginView.mm:
3091         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3092
3093 2011-01-14  Yuzo Fujishima  <yuzo@google.com>
3094
3095         Reviewed by Antti Koivisto.
3096
3097         Rename cache() to memoryCache()
3098         https://bugs.webkit.org/show_bug.cgi?id=52433
3099
3100         * Misc/WebCache.mm:
3101         (+[WebCache statistics]):
3102         (+[WebCache setDisabled:]):
3103         (+[WebCache isDisabled]):
3104         * WebView/WebView.mm:
3105         (+[WebView _setCacheModel:]):
3106
3107 2011-01-13  Geoffrey Garen  <ggaren@apple.com>
3108
3109         Reviewed by Oliver Hunt.
3110
3111         Split out a MarkedSpace strategy object from Heap.
3112         https://bugs.webkit.org/show_bug.cgi?id=52421
3113
3114         * Misc/WebCoreStatistics.mm:
3115         (+[WebCoreStatistics memoryStatistics]): Updated for class move.
3116
3117 2011-01-14  Dan Bernstein  <mitz@apple.com>
3118
3119         Reviewed by Simon Fraser.
3120
3121         WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
3122
3123         * WebView/WebHTMLView.mm:
3124         (-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
3125         to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
3126         that the NSView tree doesn’t change from under AppKit as it traverses it.
3127
3128 2011-01-14  Beth Dakin  <bdakin@apple.com>
3129
3130         Reviewed by Mark Rowe.
3131
3132         Fix for <rdar://problem/7793902> Artifacts when scrolling
3133         page in Safari while page is loading
3134
3135         Call setDrawsBackground:YES on the scrollView in 
3136         dispatchDidFirstLayout() rather than waiting until
3137         frameLoadCompleted(). Also suspend scrolling elasticity
3138         between provisionalLoadStarted() and dispatchDidFirstLayout()
3139         * WebCoreSupport/WebFrameLoaderClient.h:
3140         * WebCoreSupport/WebFrameLoaderClient.mm:
3141         (WebFrameLoaderClient::WebFrameLoaderClient):
3142         (WebFrameLoaderClient::dispatchDidFirstLayout):
3143         (WebFrameLoaderClient::provisionalLoadStarted):
3144
3145 2011-01-12  Enrica Casucci  <enrica@apple.com>
3146
3147         Reviewed by Darin Adler.
3148
3149         WebKit2: Add support for drag and drop
3150         https://bugs.webkit.org/show_bug.cgi?id=52343
3151         <rdar://problem/7660558>
3152         
3153         The DragData class has been extended to provide
3154         additional context from the application (keyboard state, modal windows, etc.)
3155         as well as information of the drag pasteboard being used.
3156         These are the changes to align the behavior for WebKit.
3157
3158         * WebView/WebView.mm:
3159         (-[WebView applicationFlags:]): Added.
3160         (-[WebView draggingEntered:]): Added parameter to the DragData constructor.
3161         (-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
3162         (-[WebView draggingExited:]): Added parameter to the DragData constructor.
3163         (-[WebView performDragOperation:]): Added parameter to the DragData constructor.
3164
3165 2011-01-12  Beth Dakin  <bdakin@apple.com>
3166
3167         Reviewed by Anders Carlsson.
3168
3169         Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309 
3170         Expose fixed layout through WebKit SPI
3171         -and corresponding-
3172         <rdar://problem/8844464>
3173
3174         And now with getters!
3175         * WebView/WebView.mm:
3176         (-[WebView _useFixedLayout]):
3177         (-[WebView _fixedLayoutSize]):
3178         * WebView/WebViewPrivate.h:
3179
3180 2011-01-12  Beth Dakin  <bdakin@apple.com>
3181
3182         Reviewed by Anders Carlsson.
3183
3184         Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
3185         fixed layout through WebKit SPI
3186         -and corresponding-
3187         <rdar://problem/8844464>
3188
3189         * WebView/WebView.mm:
3190         (-[WebView _setUseFixedLayout:]):
3191         (-[WebView _setFixedLayoutSize:]):
3192         * WebView/WebViewPrivate.h:
3193
3194 2011-01-07  Enrica Casucci  <enrica@apple.com>
3195
3196         Reviewed by Alexey Proskuryakov.
3197
3198         Paste and drag and drop use different code paths to interact with the pasteboard.
3199         https://bugs.webkit.org/show_bug.cgi?id=52093
3200         The change consists in a refactoring of the code to have only one class that
3201         deals with the pasteboard on Mac.
3202
3203         * WebCoreSupport/WebEditorClient.h:
3204         * WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality
3205         exposed by NSURLExtras.
3206         (WebEditorClient::canonicalizeURL):
3207         (WebEditorClient::canonicalizeURLString):
3208         * WebCoreSupport/WebPasteboardHelper.h: Removed.
3209         * WebCoreSupport/WebPasteboardHelper.mm: Removed.
3210         * WebView/WebHTMLView.mm: Removed comment.
3211         * WebView/WebView.mm: The following methods have been changed to use the new DragData
3212         constructor that doesn't use the WebPasteboardHelper reference.
3213         (-[WebView draggingEntered:]):
3214         (-[WebView draggingUpdated:]):
3215         (-[WebView draggingExited:]):
3216         (-[WebView performDragOperation:]):
3217
3218 2011-01-09  Tony Gentilcore  <tonyg@chromium.org>
3219
3220         Reviewed by Alexey Proskuryakov.
3221
3222         Forward declare some headers where possible
3223         https://bugs.webkit.org/show_bug.cgi?id=52133
3224
3225         * WebView/WebFrame.mm:
3226
3227 2011-01-09  Xianzhu Wang <phnixwxz@gmail.com>
3228
3229         Reviewed by Darin Fisher.
3230
3231         https://bugs.webkit.org/show_bug.cgi?id=41441
3232         createWindow method should only do window-creating without URL navigation
3233
3234         * WebCoreSupport/WebChromeClient.mm:
3235         (WebChromeClient::createWindow):
3236
3237 2011-01-08  Dan Bernstein  <mitz@apple.com>
3238
3239         Try to fix the Leopard build.
3240
3241         * WebView/WebFullScreenController.mm:
3242
3243 2011-01-07  Jer Noble  <jer.noble@apple.com>
3244
3245         Yet another Leopard build fix: NSRect and CGRect are not inter-
3246         changable in 32-bit.  
3247         
3248         * WebView/WebFullScreenController.mm:
3249         (-[WebFullScreenController exitFullscreen]):
3250
3251 2011-01-07  Jer Noble  <jer.noble@apple.com>
3252
3253         Fix the Leopard build: Replace CoreAnimation SL-only functions
3254         with Leopard equivalents.
3255
3256         * WebView/WebFullScreenController.mm:
3257         (+[CATransaction setDisableActions:]):
3258         (+[CATransaction setAnimationDuration:]):
3259         (-[WebFullScreenController _animationDuration]):
3260         (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
3261
3262 2010-12-21  Jer Noble  <jer.noble@apple.com>
3263
3264         Reviewed by Simon Fraser.
3265
3266         Implement WebKit Full Screen support.
3267         https://bugs.webkit.org/show_bug.cgi?id=49481
3268         rdar://problem/8247444
3269
3270         Support the new fullscreen Chrome client requests.  WebView will pass
3271         through these requests to a WebFullscreenController.
3272
3273         * WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged().
3274         * WebView/WebView.mm:
3275         (-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled.
3276         (-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController.
3277         (-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen.
3278         (-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed.
3279         * WebView/WebViewData.h: Add ivar newFullscreenController.
3280
3281 2010-12-17  Jer Noble  <jer@kokode.apple.com>
3282
3283         Reviewed by Simon Fraser.
3284
3285         Implement WebKit Full Screen support.
3286         https://bugs.webkit.org/show_bug.cgi?id=49481
3287         rdar://problem/8247444
3288         
3289         This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new
3290         Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen
3291         window, and a custom CAAnimation animates that layer between the initial screen rect of the
3292         full screen element, to its final value. WebFullscreenController will swap the WebView out of
3293         its original window, and into the fullscreen window. The controller will replace the WebView
3294         with a placeholder view, so that if the placeholder moves or resized while the WebView is
3295         absent, the WebView will move back to the correct location when exiting fullscreen.
3296
3297         * WebView/WebFullscreenController.h: Added.
3298         * WebView/WebFullscreenController.mm: Added.
3299         (-[WebFullscreenController windowDidExitFullscreen:]):  Close the fullscreen window.
3300         (-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window. 
3301         (-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate.
3302         (-[WebFullscreenController applicationDidResignActive:]):
3303         (-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match
3304             the new screen parameters.
3305         (-[WebFullscreenController enterFullscreen:]):  Set up the animation that will take the fullscreen element
3306             from its original screen rect into fullscreen.
3307         (-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window.
3308             Set up the animation that will take the fullscreen element back into its original screen
3309             rect.
3310         (-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine 
3311             whether to disable screensaver and sleep.
3312         (-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element
3313             looking for HTMLVideoElements; returns whether any are found to be playing.
3314         (-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control
3315             and shift keys.
3316         (-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key.
3317         (-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key.
3318         (-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen.
3319         (-[WebFullscreenWindow rendererLayer]): Convenience accessor.
3320         (-[WebFullscreenWindow setRendererLayer:]): Ditto.
3321         (-[WebFullscreenWindow backgroundLayer]): Ditto.
3322         (-[WebFullscreenWindow animationView]): Ditto.
3323         (MediaEventListener::MediaEventListener): Implements the EventListener protocol.
3324         (MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions.
3325         
3326 2011-01-07  James Robinson  <jamesr@chromium.org>
3327
3328         Revert "Implement mozilla's animationTime property"
3329         https://bugs.webkit.org/show_bug.cgi?id=51952
3330
3331         This approach isn't quite right.
3332
3333         * WebView/WebHTMLView.mm:
3334         (-[WebHTMLView drawRect:]):
3335         * WebView/WebView.mm:
3336         (layerSyncRunLoopObserverCallBack):
3337
3338 2011-01-06  Gavin Barraclough  <barraclough@apple.com>
3339
3340         Reviewed by Geoff Garen.
3341
3342         Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
3343
3344         The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
3345         destructor early, in order to release wrappers once we know we no longer intend to use them.
3346         Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
3347         lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
3348         A sequence of events that triggers the bug would look like this:
3349
3350         (1) Create a DOMWrapperWorld.
3351         (2) Register a timer in the world.
3352         (3) Call unregisterWorld() on the world.
3353         (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
3354         (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
3355             called forgetWorld() none exists.
3356         (6) Attempt to add a wrapper to a NULL map.
3357
3358         Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
3359
3360         * WebView/WebScriptWorld.mm:
3361         (-[WebScriptWorld unregisterWorld]):
3362
3363 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3364
3365         Reviewed by Sam Weinig.
3366
3367         WK2: Support Accessibility
3368         https://bugs.webkit.org/show_bug.cgi?id=51859
3369
3370         Use rootObject() method to get top of AX tree.
3371
3372         * WebCoreSupport/WebFrameLoaderClient.h:
3373         (WebFrameLoaderClient::accessibilityRemoteObject):
3374         * WebView/WebFrame.mm:
3375         (-[WebFrame setAccessibleName:]):
3376         (-[WebFrame accessibilityRoot]):
3377         * WebView/WebFrameInternal.h:
3378         * WebView/WebFramePrivate.h:
3379         * WebView/WebHTMLView.mm:
3380         (-[WebHTMLView accessibilityAttributeValue:]):
3381         (-[WebHTMLView accessibilityFocusedUIElement]):
3382         (-[WebHTMLView accessibilityHitTest:]):
3383         (-[WebHTMLView _accessibilityParentForSubview:]):
3384
3385 2011-01-04  David Kilzer  <ddkilzer@apple.com>
3386
3387         <http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name
3388
3389         Reviewed by Eric Carlson.
3390
3391         This originally broke in r61581.  It is inside an
3392         ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
3393         build then.
3394
3395         * WebCoreSupport/WebFrameLoaderClient.mm: Call
3396         (WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
3397         use WebCore::PluginInfo.name instead of
3398         -[WebBasePluginPackage name].
3399
3400 2011-01-02  Dan Bernstein  <mitz@apple.com>
3401
3402         Rubber-stamped by Simon Fraser.
3403
3404         <rdar://problem/8812159> Update copyright strings
3405
3406         * Info.plist:
3407
3408 2010-12-29  Dan Bernstein  <mitz@apple.com>
3409
3410         Reviewed by Ada Chan.
3411
3412         <rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
3413         https://bugs.webkit.org/show_bug.cgi?id=51717
3414
3415         Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
3416         protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.
3417
3418         * WebView/WebDocumentInternal.h:
3419         * WebView/WebHTMLView.mm:
3420         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3421         (-[WebHTMLView _findString:options:]):
3422         * WebView/WebView.mm:
3423         (findString):
3424
3425 2010-12-28  Daniel Bates  <dbates@rim.com>
3426
3427         Reviewed by Sam Weinig.
3428
3429         Substitute // MARK: for compiler-specific #pragma mark
3430         https://bugs.webkit.org/show_bug.cgi?id=51657
3431
3432         For consistency, we should substitute "// MARK:" for compiler-
3433         specific "#pragma mark" in the source files for the Mac port.
3434
3435         * History/WebHistory.mm:
3436         * Plugins/WebBaseNetscapePluginView.mm:
3437         * Plugins/WebNetscapePluginView.mm:
3438         * WebCoreSupport/WebInspectorClient.mm:
3439         * WebCoreSupport/WebSecurityOrigin.mm:
3440         * WebView/WebPDFView.mm:
3441         * WebView/WebVideoFullscreenController.mm:
3442         * WebView/WebVideoFullscreenHUDWindowController.mm:
3443
3444 2010-12-23  Yongjun Zhang  <yongjun_zhang@apple.com>
3445
3446         Reviewed by Darin Adler.
3447
3448         WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
3449         https://bugs.webkit.org/show_bug.cgi?id=38535
3450
3451         WebScriptDebugger in WebKit has empty implementations for willExecuteProgram and didExecuteProgram.  As a result,
3452         if the top call frame is from a program, WebKitScriptDebugger doesn't record that callframe as the top frame, and
3453         WebScriptDebugger's callframe stack is wrong from this point.  That could cause crash if we trying to access the top
3454         call frame from this stack when an exception throws because the saved top frame could be invalid.
3455
3456         To fix that, we need to maintain the call frame stack in willExecuteProgram and didExecuteProgram, as we did in
3457         callEvent and returnEvent.
3458
3459         * WebView/WebScriptDebugger.mm:
3460         (WebScriptDebugger::willExecuteProgram):
3461         (WebScriptDebugger::didExecuteProgram):
3462
3463 2010-12-22  Sam Weinig  <sam@webkit.org>
3464
3465         Reviewed by Darin Adler.
3466
3467         WebKit2 needs to mirror the frame tree in the UIProcess
3468         https://bugs.webkit.org/show_bug.cgi?id=51546
3469
3470         - Add client functions to notify that a frame has been added or
3471           removed from the page cache.
3472
3473         * WebCoreSupport/WebFrameLoaderClient.h:
3474         * WebCoreSupport/WebFrameLoaderClient.mm:
3475         (WebFrameLoaderClient::didSaveToPageCache):
3476         (WebFrameLoaderClient::didRestoreFromPageCache):
3477
3478 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3479
3480         Reviewed by Eric Seidel.
3481
3482         Editor.h doesn't need to include SelectionController.h
3483         https://bugs.webkit.org/show_bug.cgi?id=51441
3484
3485         Renamed SelectionController::EDirection to SelectionDirection.
3486
3487         * WebView/WebFrame.mm:
3488         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]):
3489         Takes SelectionDirection instead of SelectionController::EDirection.
3490         * WebView/WebFrameInternal.h:
3491         * WebView/WebTextCompletionController.mm:
3492         (-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController.
3493
3494 2010-12-22  Simon Fraser  <simon.fraser@apple.com>
3495
3496         Reviewed by Darin Adler.
3497
3498         Cache snapshots of plug-ins before painting, to avoid script running during painting
3499         https://bugs.webkit.org/show_bug.cgi?id=51493
3500
3501         When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
3502         or when printing), plug-ins which otherwise use the CA rendering model
3503         are sent a paint event. Some plug-ins may run script while handling this event,
3504         or out of process plug-ins may process queued requests at this time. Running
3505         script while inside layout or painting can have bad consequences, because it
3506         can result in arbitrary changes to the render tree.
3507         
3508         This patch avoids sending plug-ins paint events inside of painting. Instead,
3509         we ask the plug-ins to cache a snapshot before we paint, and then the software
3510         paint simply draws that snapshot.
3511
3512         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3513         (-[WebHostedNetscapePluginView drawRect:]): If we have a cached snapshot,
3514         draw it. Also only send the snapshot message to the plugin proxy if we
3515         know we're snapshotting, since even if creating the snapshot image failed,
3516         we still don't want to call to the plug-in.
3517
3518         * Plugins/WebBaseNetscapePluginView.h: Add a retained NSImage member for the snapshot.
3519         * Plugins/WebBaseNetscapePluginView.mm:
3520         (-[WebBaseNetscapePluginView cacheSnapshot]): Create an image and draw the snapshot into it.
3521         (-[WebBaseNetscapePluginView clearCachedSnapshot]): Clear the snapshot.
3522
3523         * Plugins/WebNetscapePluginView.mm:
3524         (-[WebNetscapePluginView drawRect:]): If we have a cached snapshot, use it.
3525         * WebCoreSupport/WebFrameLoaderClient.mm:
3526         (NetscapePluginWidget::notifyWidget): Implement notifyWidget() and use it
3527         to cache and clear the snapshots.
3528
3529 2010-12-21  Cameron Zwarich  <zwarich@apple.com>
3530
3531         Reviewed by Darin Adler.
3532
3533         -[WebBasePluginPackage isNativeLibraryData:] integer underflows on zero-sized data
3534         https://bugs.webkit.org/show_bug.cgi?id=51431
3535         <rdar://problem/8791757>
3536
3537        &n