Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName...
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2014-12-05  Tim Horton  <timothy_horton@apple.com>
2
3         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
4         https://bugs.webkit.org/show_bug.cgi?id=139306
5         <rdar://problem/19157955>
6
7         Reviewed by Beth Dakin.
8
9         * WebView/WebView.mm:
10         (-[WebView _commonInitializationWithFrameName:groupName:]):
11         (-[WebView _initWithFrame:frameName:groupName:]):
12         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
13
14 2014-12-05  David Kilzer  <ddkilzer@apple.com>
15
16         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
17         <http://webkit.org/b/139286>
18
19         Reviewed by Daniel Bates.
20
21         * Configurations/FeatureDefines.xcconfig: Switch back to using
22         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
23
24 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
25
26         Fix the 32-bit build.
27
28         * WebView/WebView.mm:
29         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
30
31 2014-12-04  Tim Horton  <timothy_horton@apple.com>
32
33         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
34         https://bugs.webkit.org/show_bug.cgi?id=139252
35         <rdar://problem/19140827>
36
37         Reviewed by Anders Carlsson.
38
39         * WebView/WebView.mm:
40         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
41         Adjust to the WebCore changes.
42
43 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
44
45         Implement action menus for tel: URLs
46         https://bugs.webkit.org/show_bug.cgi?id=139240
47         <rdar://problem/19115662>
48
49         Reviewed by Anders Carlsson.
50
51         * WebView/WebActionMenuController.mm:
52         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
53         Make sure to use the newly created currentActionContext... everywhere.
54
55 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
56
57         Implement action menus for tel: URLs
58         https://bugs.webkit.org/show_bug.cgi?id=139240
59         <rdar://problem/19115662>
60
61         Reviewed by Anders Carlsson.
62
63         * WebView/WebActionMenuController.mm:
64         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
65         Make sure to use the newly created currentActionContext.
66
67 2014-12-03  Beth Dakin  <bdakin@apple.com>
68
69         <input> elements get whitespace action menu instead of editable text menu
70         https://bugs.webkit.org/show_bug.cgi?id=139241
71         -and corresponding-
72         rdar://problem/19072083
73
74         Reviewed by Sam Weinig.
75
76         We should disallow shadow content in the hit test. This is the default and it is 
77         how context menus behave. We originally wanted to text inside shadow content so 
78         that we could find the text, but the new function I added to HitTestResult will 
79         allow that.
80         * WebView/WebActionMenuController.mm:
81         (-[WebActionMenuController performHitTestAtPoint:]):
82
83         Adjust to the fact that we don’t hit test shadow content any more.
84         (-[WebActionMenuController focusAndSelectHitTestResult]):
85
86         Offer the text menus for text inside form controls.
87         (-[WebActionMenuController _defaultMenuItems]):
88
89 2014-12-03  Tim Horton  <timothy_horton@apple.com>
90
91         Implement action menus for tel: URLs
92         https://bugs.webkit.org/show_bug.cgi?id=139240
93         <rdar://problem/19115662>
94
95         Reviewed by Anders Carlsson.
96
97         * WebView/WebActionMenuController.mm:
98         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
99         Rename this function as it will work for both mailto and tel URLs.
100         Adjust it to use contextForView:.
101
102         (-[WebActionMenuController webView:willHandleMouseDown:]):
103         (-[WebActionMenuController prepareForMenu:withEvent:]):
104         (-[WebActionMenuController didCloseMenu:withEvent:]):
105         (-[WebActionMenuController _defaultMenuItems]):
106         Don't check the menu type when going to interact with _currentActionContext.
107         We'll only have a _currentActionContext if we have a data detected item,
108         and there are multiple menu types that end up using DDActionContext.
109
110         * WebView/WebUIDelegatePrivate.h:
111         Add a new type.
112
113 2014-12-03  Anders Carlsson  <andersca@apple.com>
114
115         Set a visited link store when creating a simple WebView
116         https://bugs.webkit.org/show_bug.cgi?id=139234
117         <rdar://problem/19132978>
118
119         Reviewed by Sam Weinig.
120
121         * WebView/WebView.mm:
122         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
123
124 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
125
126         Fix the build.
127
128         * WebCoreSupport/WebFrameLoaderClient.mm:
129
130 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
131
132         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
133         https://bugs.webkit.org/show_bug.cgi?id=139149
134
135         Reviewed by Anders Carlsson.
136
137         This changes API behavior. I think that it's OK, because existing behavior made no sense.
138         We used to delete caches from disk, but they were still active in memory. Now we also
139         obsolete them in memory, so documents that use a cache still work, but new ones don't
140         pick one up.
141
142         * WebCoreSupport/WebApplicationCache.mm:
143         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
144         need to delete in-momry caches too. Keep existing behavior.
145         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
146         that properly deletes caches.
147
148 2014-12-02  Tim Horton  <timothy_horton@apple.com>
149
150         Remove a SnowLeopard-era quirk for QuickLook
151         https://bugs.webkit.org/show_bug.cgi?id=139208
152         <rdar://problem/19121822>
153
154         Reviewed by Alexey Proskuryakov.
155
156         * WebCoreSupport/WebFrameLoaderClient.h:
157         * WebCoreSupport/WebFrameLoaderClient.mm:
158
159 2014-12-02  Tim Horton  <timothy_horton@apple.com>
160
161         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
162         https://bugs.webkit.org/show_bug.cgi?id=139204
163
164         Reviewed by Anders Carlsson.
165
166         * WebView/WebView.mm:
167         (-[WebView _commonInitializationWithFrameName:groupName:]):
168         (-[WebView _showDictionaryLookupPopup:]):
169         * WebView/WebViewData.h:
170         Work around this by delaying the softlinking (and setting up the notification
171         observer) until we actually need it. There's still an underlying bug, but
172         this will fix the test.
173
174 2014-12-02  Beth Dakin  <bdakin@apple.com>
175
176         Yet another build fix.
177
178         * WebView/WebActionMenuController.mm:
179         (-[WebActionMenuController _defaultMenuItemsForLink]):
180
181 2014-12-02  Beth Dakin  <bdakin@apple.com>
182
183         Build fix.
184
185         * WebView/WebActionMenuController.mm:
186         (-[WebActionMenuController _defaultMenuItemsForLink]):
187
188 2014-12-02  Beth Dakin  <bdakin@apple.com>
189
190         More build fixing.
191
192         * WebView/WebActionMenuController.mm:
193         (-[WebActionMenuController _defaultMenuItemsForLink]):
194
195 2014-12-02  Beth Dakin  <bdakin@apple.com>
196
197         Should use standardQuickLookMenuItem for apps that don't implement customizations
198         https://bugs.webkit.org/show_bug.cgi?id=139193
199         -and corresponding-
200         rdar://problem/18944696
201
202         Reviewed by Anders Carlsson.
203
204         Use [NSMenuItem standardQuickLookMenuItem].
205         * WebView/WebActionMenuController.mm:
206         (-[WebActionMenuController _defaultMenuItemsForLink]):
207
208         Delegate methods to set up the standardQuickLookMenuItem.
209         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
210         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
211         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
212
213         Remove all of the old QLPreviewBubble code.
214         (-[WebActionMenuController _createActionMenuItemForTag:]):
215         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
216
217 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
218
219         Fix the build.
220
221         * WebView/WebViewData.h:
222
223 2014-12-02  Tim Horton  <timothy_horton@apple.com>
224
225         Implement Lookup transition from selection for Legacy WebKit
226         https://bugs.webkit.org/show_bug.cgi?id=139180
227         <rdar://problem/19067172>
228
229         Reviewed by Beth Dakin.
230
231         * WebView/DictionaryPopupInfo.h: Added.
232         Split DictionaryPopupInfo out into its own file.
233
234         * WebView/WebActionMenuController.mm:
235         (-[WebActionMenuController _lookupText:]):
236         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
237
238         (performDictionaryLookupForSelection):
239         (performDictionaryLookupForRange):
240         Plumb the transition style through these helpers.
241         Create a TextIndicator from the selection range.
242
243         * WebView/WebHTMLView.mm:
244         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
245         Make use of TextIndicator (and DictionaryPopupInfo, and the new
246         _showDictionaryLookupPopup on WebView) to add a transition from blue
247         when performing Lookup from the context menu.
248
249         (-[WebHTMLView quickLookWithEvent:]):
250         Remove our TextIndicator whenever a normal three-finger-tap event
251         comes through, as it will have its own indication.
252
253         * WebView/WebView.mm:
254         (-[WebView _commonInitializationWithFrameName:groupName:]):
255         (-[WebView _dictionaryLookupPopoverWillClose:]):
256         Register for the LUNotificationPopoverWillClose notification and remove
257         our TextIndicator when it is called, just like in WebKit2.
258         Deregistration is already handled in _close.
259
260         (-[WebView _showDictionaryLookupPopup:]):
261         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
262         if the relevant API is available.
263
264         * WebView/WebViewInternal.h:
265
266 2014-12-02  Anders Carlsson  <andersca@apple.com>
267
268         Remove visited link handling from PageGroup
269         https://bugs.webkit.org/show_bug.cgi?id=139185
270
271         Reviewed by Sam Weinig.
272
273         * History/WebHistory.mm:
274         (-[WebHistoryPrivate removeItemForURLString:]):
275         (-[WebHistoryPrivate removeAllItems]):
276         (+[WebHistory setOptionalSharedHistory:]):
277         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
278         (+[WebHistory _removeAllVisitedLinks]):
279         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
280         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
281         * History/WebHistoryInternal.h:
282         * WebCoreSupport/WebChromeClient.h:
283         * WebCoreSupport/WebChromeClient.mm:
284         (WebChromeClient::populateVisitedLinks): Deleted.
285         * WebView/WebView.mm:
286         (-[WebView addVisitedLinks:]):
287         (-[WebView removeVisitedLink:]):
288
289 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
290
291         Try to fix the Mac build.
292
293         * WebView/WebView.mm:
294         (-[WebView _commonInitializationWithFrameName:groupName:]):
295         (-[WebView _close]):
296
297 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
298
299         Fix the iOS build.
300
301         * WebView/WebActionMenuController.h:
302         * WebView/WebActionMenuController.mm:
303         * WebView/WebHTMLView.mm:
304         (-[WebHTMLView scrollWheel:scrollWheel:]):
305         (-[WebHTMLView mouseDown:mouseDown:]):
306         * WebView/WebView.mm:
307         * WebView/WebViewData.h:
308         * WebView/WebViewData.mm:
309         (-[WebViewPrivate dealloc]):
310         * WebView/WebViewInternal.h:
311
312 2014-12-01  Tim Horton  <timothy_horton@apple.com>
313
314         Implement yellow highlight for WebKit1 data detectors
315         https://bugs.webkit.org/show_bug.cgi?id=138956
316         <rdar://problem/18992185>
317
318         Reviewed by Beth Dakin.
319
320         * WebView/WebActionMenuController.h:
321         * WebView/WebActionMenuController.mm:
322         (-[WebActionMenuController webView:willHandleMouseDown:]):
323         (-[WebActionMenuController webView:didHandleScrollWheel:]):
324         (-[WebActionMenuController prepareForMenu:withEvent:]):
325         (-[WebActionMenuController didCloseMenu:withEvent:]):
326         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
327         (-[WebActionMenuController _showTextIndicator]):
328         (-[WebActionMenuController _hideTextIndicator]):
329         (-[WebActionMenuController _dismissActionMenuPopovers]):
330         Copy the WebKit2 WKActionMenuController TextIndicator implementation
331         into WebActionMenuController. The only significant difference is
332         that we build the TextIndicator right at menu construction time
333         instead of in the Web process.
334
335         * WebView/WebHTMLView.mm:
336         (-[WebHTMLView scrollWheel:]):
337         Let the WebActionMenuController know that we're handling a scroll.
338
339         (-[WebHTMLView mouseDown:]):
340         Let the WebActionMenuController know that we're handling a mouseDown.
341
342         * WebView/WebView.mm:
343         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
344         (-[WebView _clearTextIndicator]):
345         (-[WebView _actionMenuController]):
346         (-[WebView _convertRectFromRootView:]): Deleted.
347         * WebView/WebViewData.h:
348         * WebView/WebViewData.mm:
349         * WebView/WebViewInternal.h:
350         Keep a TextIndicatorWindow on WebView, just like WKView does.
351         Expose the WebActionMenuController on WebView (internally).
352
353 2014-12-01  Anders Carlsson  <andersca@apple.com>
354
355         Remove old site specific quirks code that was added in 2009
356         https://bugs.webkit.org/show_bug.cgi?id=139141
357
358         Reviewed by Antti Koivisto.
359
360         * WebCoreSupport/WebFrameNetworkingContext.h:
361         * WebCoreSupport/WebFrameNetworkingContext.mm:
362         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
363
364 2014-11-30  Anders Carlsson  <andersca@apple.com>
365
366         Fix a test failure.
367
368         * History/WebHistory.mm:
369         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
370         Call through to the visited link store.
371
372         (+[WebHistory _removeAllVisitedLinks]):
373         Ditto.
374
375         * WebCoreSupport/WebVisitedLinkStore.mm:
376         (WebVisitedLinkStore::isLinkVisited):
377         Make sure to populate visited links.
378
379 2014-11-30  Anders Carlsson  <andersca@apple.com>
380
381         Switch over to the visited link store from the WebViewGroup
382         https://bugs.webkit.org/show_bug.cgi?id=139112
383
384         Reviewed by Sam Weinig.
385
386         * WebView/WebView.mm:
387         (-[WebView _commonInitializationWithFrameName:groupName:]):
388         (-[WebView setGroupName:]):
389
390 2014-11-30  Anders Carlsson  <andersca@apple.com>
391
392         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
393         https://bugs.webkit.org/show_bug.cgi?id=139111
394
395         Reviewed by Sam Weinig.
396
397         * WebCoreSupport/WebVisitedLinkStore.h:
398         * WebCoreSupport/WebVisitedLinkStore.mm:
399         (WebVisitedLinkStore::removeVisitedLink):
400         * WebView/WebView.mm:
401         (-[WebView removeVisitedLink:]):
402
403 2014-11-29  Anders Carlsson  <andersca@apple.com>
404
405         Populate visited links
406         https://bugs.webkit.org/show_bug.cgi?id=139101
407
408         Reviewed by Sam Weinig.
409
410         * History/WebHistory.mm:
411         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
412         Helper function that adds all visited link to the given store.
413
414         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
415         Call the private method.
416
417         * History/WebHistoryInternal.h:
418         * WebCoreSupport/WebVisitedLinkStore.h:
419         Add new members.
420
421         * WebCoreSupport/WebVisitedLinkStore.mm:
422         (WebVisitedLinkStore::addVisitedLink):
423         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
424
425         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
426         Implement this. First try the delegate, then try the shared history.
427
428         (WebVisitedLinkStore::addVisitedLinkHash):
429         Factor code that adds the link to the hash table into a separate function.
430
431         * WebView/WebView.mm:
432         (-[WebView addVisitedLinks:]):
433         Add the visited links to the store.
434
435 2014-11-29  Anders Carlsson  <andersca@apple.com>
436
437         More work on the legacy WebKit visited link store
438         https://bugs.webkit.org/show_bug.cgi?id=139100
439
440         Reviewed by Sam Weinig.
441
442         * History/WebHistory.mm:
443         (+[WebHistory setOptionalSharedHistory:]):
444         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
445
446         * WebCoreSupport/WebVisitedLinkStore.h:
447         * WebCoreSupport/WebVisitedLinkStore.mm:
448         (visitedLinkStores):
449         (WebVisitedLinkStore::WebVisitedLinkStore):
450         (WebVisitedLinkStore::~WebVisitedLinkStore):
451         Keep track of live visited link stores.
452
453         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
454         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
455
456         (WebVisitedLinkStore::removeAllVisitedLinks):
457         Iterate over all live link stores and remove their links.
458
459         (WebVisitedLinkStore::isLinkVisited):
460         Populate visited links and check if our hash table contains the link.
461
462         (WebVisitedLinkStore::addVisitedLink):
463         Add the link hash to the table.
464
465         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
466         Add stub.
467
468         (WebVisitedLinkStore::removeVisitedLinkHashes):
469         Clear out the hash table.
470
471 2014-11-27  Anders Carlsson  <andersca@apple.com>
472
473         Add a stubbed out WebVisitedLinkStore to WebViewGroup
474         https://bugs.webkit.org/show_bug.cgi?id=139066
475
476         Reviewed by Antti Koivisto.
477
478         * WebCoreSupport/WebViewGroup.h:
479         (WebViewGroup::visitedLinkStore):
480         * WebCoreSupport/WebViewGroup.mm:
481         (WebViewGroup::WebViewGroup):
482         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
483         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
484         (WebVisitedLinkStore::create):
485         (WebVisitedLinkStore::WebVisitedLinkStore):
486         (WebVisitedLinkStore::~WebVisitedLinkStore):
487         (WebVisitedLinkStore::isLinkVisited):
488         (WebVisitedLinkStore::addVisitedLink):
489
490 2014-11-25  Anders Carlsson  <andersca@apple.com>
491
492         Remove user content handling from PageGroup
493         https://bugs.webkit.org/show_bug.cgi?id=139051
494
495         Reviewed by Antti Koivisto.
496
497         Use the user content controller in the web view group.
498
499         * WebView/WebView.mm:
500         (-[WebView _injectOutlookQuirksScript]):
501
502 2014-11-25  Anders Carlsson  <andersca@apple.com>
503
504         Add a user content controller to WebViewGroup and use it for user content
505         https://bugs.webkit.org/show_bug.cgi?id=139043
506
507         Reviewed by Antti Koivisto.
508
509         This is another tiny step towards getting rid of user content handling inside PageGroup.
510
511         * WebCoreSupport/WebViewGroup.h:
512         (WebViewGroup::userContentController):
513         Add a UserContentController member and getter.
514
515         * WebCoreSupport/WebViewGroup.mm:
516         (WebViewGroup::get):
517         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
518
519         (WebViewGroup::WebViewGroup):
520         Create a user content controller.
521
522         * WebView/WebView.mm:
523         (-[WebView _commonInitializationWithFrameName:groupName:]):
524         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
525         set its user content controller in the PageConfiguration.
526
527         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
528         Ditto.
529
530         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
531         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
532         (+[WebView _removeUserScriptFromGroup:world:url:]):
533         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
534         (+[WebView _removeUserScriptsFromGroup:world:]):
535         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
536         (+[WebView _removeAllUserContentFromGroup:]):
537         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
538
539         (-[WebView setGroupName:]):
540         Set the user content controller to the new WebViewGroup's user content controller.
541
542 2014-11-21  Jer Noble  <jer.noble@apple.com>
543
544         Support multiple signatures of diagnostic logging.
545         https://bugs.webkit.org/show_bug.cgi?id=138690
546
547         Reviewed by Anders Carlsson.
548
549         Page::PageClients has been renamed PageConfiguration.
550
551         * WebView/WebView.mm:
552         (-[WebView _commonInitializationWithFrameName:groupName:]):
553         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
554
555 2014-11-21  Zalan Bujtas  <zalan@apple.com>
556
557         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
558         https://bugs.webkit.org/show_bug.cgi?id=138981
559
560         Reviewed by Simon Fraser.
561
562         * WebView/WebPreferenceKeysPrivate.h:
563         * WebView/WebPreferences.mm:
564         (+[WebPreferences initialize]):
565         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
566         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
567         * WebView/WebPreferencesPrivate.h:
568         * WebView/WebView.mm:
569         (-[WebView _preferencesChanged:]):
570
571 2014-11-21  Tim Horton  <timothy_horton@apple.com>
572
573         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
574         ​https://bugs.webkit.org/show_bug.cgi?id=138960
575         <rdar://problem/19056715>
576
577         Reviewed by Anders Carlsson.
578
579         * WebView/WebActionMenuController.mm:
580         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
581         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
582         Use DataDetectors SPI instead of an explicit blacklist.
583
584 2014-11-21  Tim Horton  <timothy_horton@apple.com>
585
586         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
587         https://bugs.webkit.org/show_bug.cgi?id=138960
588         <rdar://problem/19056715>
589
590         Reviewed by Beth Dakin.
591
592         * WebView/WebActionMenuController.mm:
593         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
594         Blacklist contact results, because they don't have useful menus. If we
595         bail before setting up _currentActionContext, we'll still allow fallthrough
596         to ordinary text actions, avoiding mysterious failure when a contact is detected.
597
598         This doesn't break the case that r176351 was intended to fix,
599         because in that case we were detecting e.g. addresses.
600
601 2014-11-21  Anders Carlsson  <andersca@apple.com>
602
603         Remove the Timer parameters from timer callbacks
604         https://bugs.webkit.org/show_bug.cgi?id=138974
605
606         Reviewed by Antti Koivisto.
607
608         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
609         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
610         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
611         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
612         * Plugins/WebNetscapePluginStream.h:
613         * Plugins/WebNetscapePluginStream.mm:
614         (WebNetscapePluginStream::WebNetscapePluginStream):
615         (WebNetscapePluginStream::deliverDataTimerFired):
616
617 2014-11-21  Anders Carlsson  <andersca@apple.com>
618
619         Make memoryCache() return a reference
620         https://bugs.webkit.org/show_bug.cgi?id=138939
621
622         Reviewed by Antti Koivisto.
623
624         * Misc/WebCache.mm:
625         (+[WebCache statistics]):
626         (+[WebCache emptyInMemoryResources]):
627         (+[WebCache sizeOfDeadResources:]):
628         (+[WebCache addImageToCache:forURL:forFrame:]):
629         (+[WebCache removeImageFromCacheForURL:forFrame:]):
630         (+[WebCache imageForURL:]):
631         (+[WebCache setDisabled:]):
632         (+[WebCache isDisabled]):
633         * WebView/WebView.mm:
634         (+[WebView _setCacheModel:]):
635
636 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
637
638         Remove the remaining vestiges of minimal-ui
639         https://bugs.webkit.org/show_bug.cgi?id=138890
640
641         Reviewed by Sam Weinig.
642
643         * History/WebHistoryItem.mm:
644         * History/WebHistoryItemPrivate.h:
645
646 2014-11-20  Tim Horton  <timothy_horton@apple.com>
647
648         Cancel DataDetectors menu earlier if we know it can't be presented
649         https://bugs.webkit.org/show_bug.cgi?id=138922
650         <rdar://problem/18950441>
651
652         Reviewed by Beth Dakin.
653
654         * WebView/WebActionMenuController.mm:
655         (-[WebActionMenuController prepareForMenu:withEvent:]):
656         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
657         and use a bigger hammer (removeAllItems).
658
659         (-[WebActionMenuController willOpenMenu:withEvent:]):
660         If we end up with a menu with no items, don't change selection or anything.
661
662 2014-11-20  Beth Dakin  <bdakin@apple.com>
663
664         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
665         https://bugs.webkit.org/show_bug.cgi?id=138568
666         -and corresponding-
667         rdar://problem/18904600
668
669         Reviewed by Tim Horton.
670
671         Skip images for lookup.
672         * WebView/WebActionMenuController.mm:
673         (performDictionaryLookupForRange):
674
675 2014-11-19  Beth Dakin  <bdakin@apple.com>
676
677         Invoking an action menu on a selection should result in the text menu
678         https://bugs.webkit.org/show_bug.cgi?id=138892
679         -and corresponding-
680         rdar://problem/18996776
681
682         Reviewed by Tim Horton.
683
684         * WebView/WebActionMenuController.mm:
685         (-[WebActionMenuController _defaultMenuItems]):
686
687 2014-11-19  Beth Dakin  <bdakin@apple.com>
688
689         Data detected results with no menu items should not fall through to regular text 
690         action menus
691         https://bugs.webkit.org/show_bug.cgi?id=138887
692         -and corresponding-
693         rdar://problem/18971616
694
695         Reviewed by Tim Horton.
696
697         * WebView/WebActionMenuController.mm:
698         (-[WebActionMenuController _defaultMenuItems]):
699
700 2014-11-19  Daniel Bates  <dabates@apple.com>
701
702         [iOS] Make WebKit build with public iOS SDK
703         https://bugs.webkit.org/show_bug.cgi?id=136863
704
705         Reviewed by David Kilzer.
706
707         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
708         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
709         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
710         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
711         may be used by Apple internal clients that do not include wtf/Platform.h.
712         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
713         private Foundation headers directly.
714         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
715         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
716         instead of including private CFNetwork headers directly. Also fixed up style and
717         ordering of header include directives.
718         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
719         CFNetwork headers directly. Also sort the #import directives.
720         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
721         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
722
723 2014-11-18  David Kilzer  <ddkilzer@apple.com>
724
725         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
726         <http://webkit.org/b/138813>
727
728         Reviewed by Mark Rowe.
729
730         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
731         selectors.
732
733 2014-11-18  Chris Dumez  <cdumez@apple.com>
734
735         Add a setting to toggle DOMTimer throttling support
736         https://bugs.webkit.org/show_bug.cgi?id=138844
737         <rdar://problem/19020874>
738
739         Reviewed by Andreas Kling.
740
741         Add a setting to disable DOM timers throttling, in order to help
742         developers determine if a specific issue is caused by timer
743         throttling.
744
745         * WebView/WebPreferenceKeysPrivate.h:
746         * WebView/WebPreferences.mm:
747         (+[WebPreferences initialize]):
748         (-[WebPreferences domTimersThrottlingEnabled]):
749         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
750         * WebView/WebPreferencesPrivate.h:
751         * WebView/WebView.mm:
752         (-[WebView _preferencesChanged:]):
753
754 2014-11-18  Tim Horton  <timothy_horton@apple.com>
755
756         Avoid re-encoding action menu image data
757         https://bugs.webkit.org/show_bug.cgi?id=138817
758         <rdar://problem/18840382>
759
760         Reviewed by Anders Carlsson.
761
762         * WebView/WebActionMenuController.mm:
763         (-[WebActionMenuController _defaultMenuItemsForImage:]):
764         (-[WebActionMenuController _addImageToPhotos:]):
765         Build a temporary filename from a UUID and the image's desired extension.
766         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
767         Build an image menu only if we have an image, URL, data, and extension.
768
769 2014-11-18  Daniel Bates  <dabates@apple.com>
770
771         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
772         SPI are not available in public SDK
773         https://bugs.webkit.org/show_bug.cgi?id=138802
774
775         Reviewed by David Kilzer.
776
777         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
778         libdispatch and MobileGestalt headers directly.
779
780         * WebView/WebView.mm:
781
782 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
783
784         Remove calls to deprecated NSMenu methods
785         https://bugs.webkit.org/show_bug.cgi?id=138808.
786
787         Reviewed by Anders Carlsson.
788
789         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
790
791         * WebCoreSupport/PopupMenuMac.mm:
792         (PopupMenuMac::populate):
793
794 2014-11-17  Daniel Bates  <dabates@apple.com>
795
796         Unreviewed, rolling out r176232.
797
798         Broke the Mac build. Will investigate offline.
799
800         Reverted changeset:
801
802         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
803         MobileGestalt"
804         https://bugs.webkit.org/show_bug.cgi?id=138802
805         http://trac.webkit.org/changeset/176232
806
807 2014-11-17  Daniel Bates  <dabates@apple.com>
808
809         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
810         SPI are not available in public SDK
811         https://bugs.webkit.org/show_bug.cgi?id=138802
812
813         Reviewed by David Kilzer.
814
815         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
816         libdispatch and MobileGestalt headers directly.
817
818         * WebView/WebView.mm:
819
820 2014-11-17  Beth Dakin  <bdakin@apple.com>
821
822         Whitespace action menus should focus the HitTestResult and create an insertion 
823         point
824         https://bugs.webkit.org/show_bug.cgi?id=138786
825         -and corresponding-
826         rdar://problem/18944893
827
828         Reviewed by Tim Horton.
829
830         Whitespace menus should cause the HitTestResult to be focused, and they should set 
831         the selection based on the HitTest location.
832
833         * WebView/WebActionMenuController.mm:
834         (-[WebActionMenuController isMenuForTextContent]):
835         (-[WebActionMenuController focusAndSelectHitTestResult]):
836         (-[WebActionMenuController willOpenMenu:withEvent:]):
837
838 2014-11-17  Daniel Bates  <dabates@apple.com>
839
840         [iOS] QuartzCore SPI not available in public SDK
841         https://bugs.webkit.org/show_bug.cgi?id=138751
842
843         Reviewed by David Kilzer.
844
845         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
846
847         * WebInspector/WebNodeHighlight.mm:
848         * WebView/WebIndicateLayer.mm:
849
850 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
851
852         [iOS] allow host application to opt-out of alternate fullscreen
853         https://bugs.webkit.org/show_bug.cgi?id=138787
854
855         Reviewed by Darin Adler.
856
857         * WebView/WebPreferenceKeysPrivate.h:
858         * WebView/WebPreferences.mm:
859         (+[WebPreferences initialize]):
860         (-[WebPreferences allowsAlternateFullscreen]):
861         (-[WebPreferences setAllowsAlternateFullscreen:]):
862         * WebView/WebPreferencesPrivate.h:
863         * WebView/WebView.mm:
864         (-[WebView _preferencesChanged:]):
865
866 2014-11-16  Tim Horton  <timothy_horton@apple.com>
867
868         Use TextIndicator instead of the built in Lookup highlight
869         https://bugs.webkit.org/show_bug.cgi?id=138775
870         <rdar://problem/18953982>
871
872         Reviewed by Anders Carlsson.
873
874         * WebCoreSupport/WebSystemInterface.mm:
875         (InitWebCoreSystemInterface):
876         Remove a WKSI import.
877
878         * WebView/WebActionMenuController.mm:
879         (-[WebActionMenuController _lookupText:]):
880         (-[WebActionMenuController _createActionMenuItemForTag:]):
881         Make use of the new Lookup SPI header.
882         Disable the Lookup item if lookup is not available.
883
884 2014-11-15  Tim Horton  <timothy_horton@apple.com>
885
886         Implement data detectors and mailto action menus for WebKit1
887         https://bugs.webkit.org/show_bug.cgi?id=138765
888         <rdar://problem/18877535>
889
890         Reviewed by Beth Dakin.
891
892         * WebView/WebActionMenuController.h:
893         * WebView/WebActionMenuController.mm:
894         (-[WebActionMenuController willOpenMenu:withEvent:]):
895         Tell DataDetectors that the menu is going to open.
896         Select the text (or not) based on the number of items in the menu, just like WebKit2.
897
898         (-[WebActionMenuController didCloseMenu:withEvent:]):
899         Tell DataDetectors that the menu closed.
900
901         (-[WebActionMenuController _defaultMenuItemsForLink]):
902         Move these checks out of _defaultMenuItemsForLink, because we expect this
903         to always return a complete link menu.
904
905         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
906         Implement. More or less copied from WebKit2.
907
908         (-[WebActionMenuController _selectDataDetectedText]):
909         Select the stashed range.
910
911         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
912         Implement. More or less copied from WebKit2.
913         The yellow highlight isn't hooked up yet.
914         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
915
916         (-[WebActionMenuController _selectLookupText]):
917         Remove an unnecessary return.
918
919         (-[WebActionMenuController _defaultMenuItems]):
920         Call into the two new menu types.
921
922         * WebView/WebUIDelegatePrivate.h:
923
924 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
925
926         Get rid of WebFontCache
927         https://bugs.webkit.org/show_bug.cgi?id=134752
928
929         Reviewed by Dave Hyatt.
930
931         * WebView/WebHTMLView.mm:
932
933 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
934
935         Update some artwork for the legacy WebKit action menu
936         https://bugs.webkit.org/show_bug.cgi?id=138758
937         <rdar://problem/18989840>
938
939         * WebView/WebActionMenuController.mm:
940         (webKitBundleImageNamed): Deleted.
941         Fix the build.
942
943 2014-11-14  Tim Horton  <timothy_horton@apple.com>
944
945         Update some artwork for the legacy WebKit action menu
946         https://bugs.webkit.org/show_bug.cgi?id=138758
947         <rdar://problem/18989840>
948
949         Reviewed by Simon Fraser.
950
951         * WebView/WebActionMenuController.mm:
952         (-[WebActionMenuController _createActionMenuItemForTag:]):
953
954 2014-11-14  Daniel Bates  <dabates@apple.com>
955
956         [iOS] NSFileManager and QuickLook SPI not available in public SDK
957         https://bugs.webkit.org/show_bug.cgi?id=138742
958
959         Reviewed by Pratik Solanki.
960
961         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
962
963         * WebCoreSupport/WebFrameLoaderClient.mm:
964
965 2014-11-14  Beth Dakin  <bdakin@apple.com>
966
967         WK1: Webpage preview can come up in wrong location
968         https://bugs.webkit.org/show_bug.cgi?id=138747
969         -and corresponding-
970         rdar://problem/18979004
971
972         Reviewed by Tim Horton.
973
974         Converting to window twice is bad.
975         * WebView/WebActionMenuController.mm:
976         (elementBoundingBoxInWindowCoordinatesFromNode):
977         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
978         (elementBoundingBoxFromNode): Deleted.
979
980 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
981
982         Move FontMac and FontCacheMac off of WKSI
983         https://bugs.webkit.org/show_bug.cgi?id=138633
984
985         Reviewed by Simon Fraser.
986
987         * WebCoreSupport/WebSystemInterface.mm:
988         (InitWebCoreSystemInterface):
989         * WebKit.order:
990
991 2014-11-13  Beth Dakin  <bdakin@apple.com>
992
993         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
994         https://bugs.webkit.org/show_bug.cgi?id=138716
995         -and corresponding-
996         rdar://problem/18977222
997
998         Reviewed by Tim Horton.
999
1000         It’s not necessary to use the WebElementDictionary for so many things now that we 
1001         are caching the HitTestResult. We should just use the HitTestResult.
1002
1003         * WebView/WebActionMenuController.mm:
1004         (-[WebActionMenuController prepareForMenu:withEvent:]):
1005         (-[WebActionMenuController _openURLFromActionMenu:]):
1006         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
1007         (elementBoundingBoxFromNode):
1008         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1009         (-[WebActionMenuController _defaultMenuItemsForLink]):
1010         (-[WebActionMenuController _defaultMenuItemsForImage]):
1011         (-[WebActionMenuController _defaultMenuItemsForVideo]):
1012         (-[WebActionMenuController _defaultMenuItemsForText]):
1013         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
1014         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
1015         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
1016         (-[WebActionMenuController _createActionMenuItemForTag:]):
1017         (-[WebActionMenuController _defaultMenuItems]):
1018         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
1019         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
1020         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
1021         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
1022         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
1023         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
1024         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
1025         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
1026         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
1027         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
1028
1029 2014-11-13  Daniel Bates  <dabates@apple.com>
1030
1031         [iOS] NSGeometry data types are not available in the public SDK
1032         https://bugs.webkit.org/show_bug.cgi?id=137536
1033
1034         Reviewed by David Kilzer.
1035
1036         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
1037         private header.
1038
1039         * DOM/WebDOMOperationsPrivate.h:
1040
1041 2014-11-13  Beth Dakin  <bdakin@apple.com>
1042
1043         WK1: Support default actions for video
1044         https://bugs.webkit.org/show_bug.cgi?id=138713
1045         -and corresponding-
1046         rdar://problem/18877520
1047
1048         Reviewed by Tim Horton.
1049
1050         Call setToNonShadowAncestor() for media HitTestResults.
1051         * WebView/WebActionMenuController.mm:
1052         (-[WebActionMenuController performHitTestAtPoint:]):
1053
1054         Default items and actions.
1055         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
1056         (-[WebActionMenuController _copyVideoURL:]):
1057         (-[WebActionMenuController _saveVideoToDownloads:]):
1058         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1059         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1060         * WebView/WebUIDelegatePrivate.h:
1061
1062 2014-11-13  Tim Horton  <timothy_horton@apple.com>
1063
1064         WK1: Update icon for Add to Reading List
1065         https://bugs.webkit.org/show_bug.cgi?id=138710
1066         <rdar://problem/18975774>
1067
1068         Reviewed by Beth Dakin.
1069
1070         * WebView/WebActionMenuController.mm:
1071         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1072         Use the right icon, matching WebKit2.
1073
1074 2014-11-12  Beth Dakin  <bdakin@apple.com>
1075
1076         WK1: Support default actions for images
1077         https://bugs.webkit.org/show_bug.cgi?id=138668
1078         -and corresponding-
1079         rdar://problem/18785434
1080
1081         Reviewed by Tim Horton.
1082
1083         * WebView/WebActionMenuController.h:
1084         * WebView/WebActionMenuController.mm:
1085         (-[WebActionMenuController didCloseMenu:withEvent:]):
1086         (-[WebActionMenuController _defaultMenuItemsForImage:]):
1087         (-[WebActionMenuController _copyImage:]):
1088         (temporaryPhotosDirectoryPath):
1089         (pathToPhotoOnDisk):
1090         (-[WebActionMenuController _canAddMediaToPhotos]):
1091         (-[WebActionMenuController _addImageToPhotos:]):
1092         (-[WebActionMenuController _saveImageToDownloads:]):
1093         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
1094         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
1095         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
1096         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1097         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1098         * WebView/WebUIDelegatePrivate.h:
1099
1100 2014-11-11  Beth Dakin  <bdakin@apple.com>
1101
1102         Action menu hit testing is not working properly with all WK1 apps
1103         https://bugs.webkit.org/show_bug.cgi?id=138643
1104         -and corresponding-
1105         rdar://problem/18949376
1106
1107         Reviewed by Tim Horton.
1108
1109         * WebView/WebActionMenuController.mm:
1110         (-[WebActionMenuController prepareForMenu:withEvent:]):
1111         (-[WebActionMenuController _lookupText:]):
1112
1113 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1114
1115         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
1116         https://bugs.webkit.org/show_bug.cgi?id=138623
1117
1118         Reviewed by Geoff Garen.
1119
1120         * WebCoreSupport/WebSystemInterface.mm:
1121         (InitWebCoreSystemInterface):
1122         * WebKit.order:
1123
1124 2014-11-11  Tim Horton  <timothy_horton@apple.com>
1125
1126         Localize strings for action menus
1127         https://bugs.webkit.org/show_bug.cgi?id=138591
1128         <rdar://problem/18815343>
1129
1130         Reviewed by Dan Bates.
1131
1132         * WebView/WebActionMenuController.mm:
1133         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1134         Make use of the new strings.
1135
1136 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1137
1138         Cleanup from r175379
1139         https://bugs.webkit.org/show_bug.cgi?id=138616
1140
1141         Reviewed by Simon Fraser.
1142
1143         * WebCoreSupport/WebSystemInterface.mm:
1144         (InitWebCoreSystemInterface):
1145         * WebKit.order:
1146
1147 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1148
1149         Move CTFontTransformGlyphs out from WKSI
1150         https://bugs.webkit.org/show_bug.cgi?id=138599
1151
1152         Reviewed by Simon Fraser.
1153
1154         * WebCoreSupport/WebSystemInterface.mm:
1155         (InitWebCoreSystemInterface):
1156         * WebKit.order:
1157
1158 2014-11-11  Dan Bernstein  <mitz@apple.com>
1159
1160         More iOS build fix.
1161
1162         * WebView/WebHTMLViewInternal.h:
1163
1164 2014-11-11  Dan Bernstein  <mitz@apple.com>
1165
1166         iOS build fix.
1167
1168         * WebView/WebHTMLView.mm:
1169
1170 2014-11-10  Beth Dakin  <bdakin@apple.com>
1171
1172         WK1: Support default actions for editable text with misspelled word
1173         https://bugs.webkit.org/show_bug.cgi?id=138590
1174         -and corresponding-
1175         rdar://problem/18877506
1176
1177         Reviewed by Tim Horton.
1178
1179         If there are misspelled word suggestions for editable text, create a new type of 
1180         menu with a spelling suggestion sub-menu.
1181
1182         * WebView/WebActionMenuController.mm:
1183         (-[WebActionMenuController isMenuForTextContent]):
1184         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
1185         (-[WebActionMenuController _changeSelectionToSuggestion:]):
1186         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1187         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1188         * WebView/WebHTMLView.mm:
1189         (-[WebHTMLView _changeSpellingToWord:]):
1190         * WebView/WebHTMLViewInternal.h:
1191         * WebView/WebUIDelegatePrivate.h:
1192
1193 2014-11-10  Beth Dakin  <bdakin@apple.com>
1194
1195         WK1: Support default actions for editable whitespace
1196         https://bugs.webkit.org/show_bug.cgi?id=138586
1197         -and corresponding-
1198         rdar://problem/18932048
1199
1200         Reviewed by Tim Horton.
1201
1202         New menu type. Just wants paste.
1203
1204         * WebView/WebActionMenuController.mm:
1205         (-[WebActionMenuController isMenuForTextContent]):
1206         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
1207         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1208         * WebView/WebUIDelegatePrivate.h:
1209
1210 2014-11-10  Beth Dakin  <bdakin@apple.com>
1211
1212         WK1: Support default actions for editable text
1213         https://bugs.webkit.org/show_bug.cgi?id=138580
1214         -and corresponding-
1215         rdar://problem/18877497
1216
1217         Reviewed by Tim Horton.
1218
1219         New menu type, and new action type for paste. 
1220
1221         * WebView/WebActionMenuController.mm:
1222         (-[WebActionMenuController isMenuForTextContent]):
1223         (-[WebActionMenuController willOpenMenu:withEvent:]):
1224         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
1225         (-[WebActionMenuController _paste:]):
1226         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1227         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1228         * WebView/WebUIDelegatePrivate.h:
1229
1230 2014-11-10  Beth Dakin  <bdakin@apple.com>
1231
1232         WK1: Text is getting selected even when an action menu fails to invoke
1233         https://bugs.webkit.org/show_bug.cgi?id=138576
1234         -and corresponding-
1235         rdar://problem/18931330
1236
1237         Reviewed by Tim Horton.
1238
1239         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
1240         * WebView/WebActionMenuController.h:
1241         * WebView/WebActionMenuController.mm:
1242         (-[WebActionMenuController prepareForMenu:withEvent:]):
1243         (-[WebActionMenuController willOpenMenu:withEvent:]):
1244
1245         _selectLookupText no longer needs to return a BOOL indicating success or failure.
1246         (-[WebActionMenuController _selectLookupText]):
1247         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1248
1249         Pass willOpenMenu: on to the controller.
1250         * WebView/WebView.mm:
1251         (-[WebView willOpenMenu:withEvent:]):
1252
1253 2014-11-10  Beth Dakin  <bdakin@apple.com>
1254
1255         Speculative build fix.
1256
1257         * WebView/WebActionMenuController.mm:
1258
1259 2014-11-10  Beth Dakin  <bdakin@apple.com>
1260
1261         Action menu initialization should be moved to _commonInitializationWithFrameName
1262         https://bugs.webkit.org/show_bug.cgi?id=138572
1263         -and corresponding-
1264         rdar://problem/18929733
1265
1266         Reviewed by Tim Horton.
1267
1268         * WebView/WebView.mm:
1269         (-[WebView _commonInitializationWithFrameName:groupName:]):
1270         (-[WebView _initWithFrame:frameName:groupName:]):
1271
1272 2014-11-10  Beth Dakin  <bdakin@apple.com>
1273
1274         WK1: Support default actions for read-only text
1275         https://bugs.webkit.org/show_bug.cgi?id=138552
1276         -and corresponding-
1277         rdar://problem/18877483
1278
1279         Reviewed by Tim Horton.
1280
1281         New WKSystemInterface functions that WebCore needs to use.
1282         * WebCoreSupport/WebSystemInterface.mm:
1283         (InitWebCoreSystemInterface):
1284
1285         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
1286         makes a lot of things easier.
1287         * WebView/WebActionMenuController.h:
1288         * WebView/WebActionMenuController.mm:
1289
1290         Perform the hit test ourselves instead of calling into WebView so that we can more 
1291         easily save the WebCore::HitTestResult for ourselves.
1292         (-[WebActionMenuController performHitTestAtPoint:]):
1293
1294         Clear selection for non-text menus.
1295         (-[WebActionMenuController prepareForMenu:withEvent:]):
1296
1297         Re-set the _type here just to be safe.
1298         (-[WebActionMenuController didCloseMenu:withEvent:]):
1299
1300         Moving this method to be next to the link actions so they can be within a pragma 
1301         mark.
1302         (-[WebActionMenuController _defaultMenuItemsForLink:]):
1303
1304         New method for default text actions — lookup and copy.
1305         (-[WebActionMenuController _defaultMenuItemsForText:]):
1306         (-[WebActionMenuController _copySelection:]):
1307         (-[WebActionMenuController _lookupText:]):
1308
1309         If there is not already a selection, invoking the action menu on text should 
1310         select the lookup text.
1311         (-[WebActionMenuController _selectLookupText]):
1312         (performDictionaryLookupForSelection):
1313         (performDictionaryLookupForRange):
1314
1315         Handle text now.
1316         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1317         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1318
1319         New enum values.
1320         * WebView/WebUIDelegatePrivate.h:
1321
1322         Pass didCloseMenu on to the controller.
1323         * WebView/WebView.mm:
1324         (-[WebView didCloseMenu:withEvent:]):
1325
1326 2014-11-09  Chris Dumez  <cdumez@apple.com>
1327
1328         Add a more correct way to compare floating point numbers and use it
1329         https://bugs.webkit.org/show_bug.cgi?id=138527
1330
1331         Reviewed by Darin Adler.
1332
1333         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
1334         to compare floating-point numbers.
1335
1336         * WebView/WebHTMLView.mm:
1337         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
1338
1339 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
1340
1341         Delete cookies between tests
1342         https://bugs.webkit.org/show_bug.cgi?id=138528
1343
1344         Reviewed by Sam Weinig.
1345
1346         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
1347         * WebView/WebPreferencesPrivate.h:
1348         Added an SPI for DumpRenderTree.
1349
1350 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
1351
1352         [iOS] Update optimized fullscreen media controls
1353         https://bugs.webkit.org/show_bug.cgi?id=138493
1354
1355         Reviewed by Brent Fulgham.
1356
1357         * WebCoreSupport/WebSystemInterface.mm:
1358         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
1359
1360 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
1361
1362         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
1363         https://bugs.webkit.org/show_bug.cgi?id=138443
1364
1365         Reviewed by Anders Carlsson.
1366
1367         Wrapping the dealloc method in its own autorelease pool avoids the problem of
1368         complex tear-downs leading to the WebView itself being added to an autorelease
1369         pool that is not drained until after the instance has been dealloc'd.
1370  
1371         * WebView/WebView.mm:
1372         (-[WebView dealloc]):
1373
1374 2014-11-05  Jer Noble  <jer.noble@apple.com>
1375
1376         De-templatize Timer
1377         https://bugs.webkit.org/show_bug.cgi?id=138450
1378
1379         Reviewed by Anders Carlsson.
1380
1381         Remove template specifiers from Timer.
1382
1383         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1384         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1385         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
1386         * Plugins/WebNetscapePluginStream.h:
1387         * Plugins/WebNetscapePluginStream.mm:
1388         (WebNetscapePluginStream::deliverDataTimerFired):
1389
1390 2014-11-05  Dan Bernstein  <mitz@apple.com>
1391
1392         Remove the unused deletion UI feature
1393         https://bugs.webkit.org/show_bug.cgi?id=138442
1394
1395         Rubber-stamped by Alexey Proskuryakov.
1396
1397         * DefaultDelegates/WebDefaultEditingDelegate.m:
1398         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
1399         * WebCoreSupport/WebEditorClient.h:
1400         * WebCoreSupport/WebEditorClient.mm:
1401         (WebEditorClient::shouldShowDeleteInterface): Deleted.
1402         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
1403         -webView:shouldShowDeleteInterfaceForElement:.
1404
1405 2014-11-03  Dean Jackson  <dino@apple.com>
1406
1407         Add ENABLE_FILTERS_LEVEL_2 feature guard.
1408         https://bugs.webkit.org/show_bug.cgi?id=138362
1409
1410         Reviewed by Tim Horton.
1411
1412         Add a new feature define for Level 2 of CSS Filters.
1413         http://dev.w3.org/fxtf/filters-2/
1414
1415         * Configurations/FeatureDefines.xcconfig:
1416
1417 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
1418
1419         Add button and enable optimized fullscreen.
1420         https://bugs.webkit.org/show_bug.cgi?id=138351
1421
1422         Reviewed by Eric Carlson.
1423
1424         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
1425
1426         * WebCoreSupport/WebSystemInterface.mm:
1427         (InitWebCoreSystemInterface): added
1428
1429 2014-11-04  Chris Dumez  <cdumez@apple.com>
1430
1431         Add ptr() method to Ref class
1432         https://bugs.webkit.org/show_bug.cgi?id=138361
1433
1434         Reviewed by Darin Adler.
1435
1436         Use the new Ref::ptr() method.
1437
1438         * WebView/WebFrame.mm:
1439         (-[WebFrame _setTypingStyle:withUndoAction:]):
1440         * WebView/WebHTMLView.mm:
1441         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
1442         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
1443         * WebView/WebView.mm:
1444         (-[WebView applyStyle:]):
1445
1446 2014-11-04  Darin Adler  <darin@apple.com>
1447
1448         Eliminate ResourceBuffer and use SharedBuffer directly instead
1449         https://bugs.webkit.org/show_bug.cgi?id=138174
1450
1451         Reviewed by Antti Koivisto.
1452
1453         * WebView/WebDataSource.mm:
1454         (-[WebDataSource data]): Use SharedBuffer directly.
1455         * WebView/WebHTMLView.mm:
1456         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1457
1458 2014-11-03  Commit Queue  <commit-queue@webkit.org>
1459
1460         Unreviewed, rolling out r175406, r175413, and r175423.
1461         https://bugs.webkit.org/show_bug.cgi?id=138327
1462
1463         Multipart tests are still broken (Requested by ap on #webkit).
1464
1465         Reverted changesets:
1466
1467         "Eliminate ResourceBuffer and use SharedBuffer directly
1468         instead"
1469         https://bugs.webkit.org/show_bug.cgi?id=138174
1470         http://trac.webkit.org/changeset/175406
1471
1472         "Unreviewed, iOS build fix since 175406."
1473         http://trac.webkit.org/changeset/175413
1474
1475         "Fix assertion in CachedResource::addDataBuffer"
1476         http://trac.webkit.org/changeset/175423
1477
1478 2014-10-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1479
1480         Use std::unique_ptr for TypeCountSet
1481         https://bugs.webkit.org/show_bug.cgi?id=138242
1482
1483         Reviewed by Andreas Kling.
1484
1485         * Misc/WebCoreStatistics.mm:
1486         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr.
1487         (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto.
1488
1489 2014-10-31  Beth Dakin  <bdakin@apple.com>
1490
1491         Use system art for action menus when possible
1492         https://bugs.webkit.org/show_bug.cgi?id=138260
1493
1494         Reviewed by Tim Horton.
1495
1496         * WebView/WebActionMenuController.mm:
1497         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1498
1499 2014-10-30  Darin Adler  <darin@apple.com>
1500
1501         Eliminate ResourceBuffer and use SharedBuffer directly instead
1502         https://bugs.webkit.org/show_bug.cgi?id=138174
1503
1504         Reviewed by Antti Koivisto.
1505
1506         * WebView/WebDataSource.mm:
1507         (-[WebDataSource data]): Use SharedBuffer directly.
1508         * WebView/WebHTMLView.mm:
1509         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1510
1511 2014-10-30  Jer Noble  <jer.noble@apple.com>
1512
1513         [EME] Add Setting for accessing storage location for MediaKeys data
1514         https://bugs.webkit.org/show_bug.cgi?id=138147
1515
1516         Reviewed by Brady Eidson.
1517
1518         * WebView/WebPreferenceKeysPrivate.h:
1519         * WebView/WebPreferences.mm:
1520         (+[WebPreferences initialize]): Set default location.
1521         (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor.
1522         (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter.
1523         * WebView/WebPreferencesPrivate.h:
1524         * WebView/WebView.mm:
1525         (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings.
1526
1527 2014-10-30  Dana Burkart  <dburkart@apple.com>
1528
1529         <rdar://problem/18821260> Prepare for the mysterious future
1530
1531         Reviewed by Lucas Forschler.
1532
1533         * Configurations/Base.xcconfig:
1534         * Configurations/DebugRelease.xcconfig:
1535         * Configurations/FeatureDefines.xcconfig:
1536         * Configurations/Version.xcconfig:
1537
1538 2014-10-28  Jeremy Jones  <jeremyj@apple.com>
1539
1540         Add optimized fullscreen mode.
1541         https://bugs.webkit.org/show_bug.cgi?id=138044
1542
1543         Reviewed by Jer Noble.
1544
1545         Enable different types of fullscreen video behavior.
1546         Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
1547
1548         * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
1549         * WebCoreSupport/WebChromeClient.mm:
1550         (WebChromeClient::enterVideoFullscreenForVideoElement): ditto
1551         * WebView/WebView.mm:
1552         (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
1553         (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.
1554         * WebView/WebViewInternal.h: ditto
1555
1556 2014-10-27  Beth Dakin  <bdakin@apple.com>
1557
1558         Provide a way for WebKit1 clients to override default action menu items
1559         https://bugs.webkit.org/show_bug.cgi?id=138066
1560         -and corresponding-
1561         rdar://problem/18451638
1562
1563         Reviewed by Anders Carlsson.
1564
1565         WebActionMenuController now has an ivar for the WebActionMenuType so that it can 
1566         send that along to clients customizing the menu.
1567         * WebView/WebActionMenuController.h:
1568         * WebView/WebActionMenuController.mm:
1569         (-[WebActionMenuController prepareForMenu:withEvent:]):
1570         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1571
1572         New enum and new SPI to customize menus.
1573         * WebView/WebUIDelegatePrivate.h:
1574
1575 2014-10-24  Benjamin Poulain  <bpoulain@apple.com>
1576
1577         Fix the iOS build
1578
1579         * Configurations/WebKitLegacy.xcconfig:
1580         * WebView/WebView.mm:
1581
1582 2014-10-24  Beth Dakin  <bdakin@apple.com>
1583
1584         Build fix.
1585
1586         * WebView/WebActionMenuController.mm:
1587         (-[WebActionMenuController _openURLFromActionMenu:]):
1588         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
1589         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1590
1591 2014-10-24  Beth Dakin  <bdakin@apple.com>
1592
1593         WebKit1 should support action menus
1594         https://bugs.webkit.org/show_bug.cgi?id=138032
1595
1596         Reviewed by Tim Horton.
1597
1598         This patch adds basic support for action menus and adds actions for links.
1599
1600         Helper class takes care of all of the action menu work. WebView will forward the 
1601         prepareForMenu: message, and then the helper class takes it from there.
1602         * WebView/WebActionMenuController.h: Added.
1603         * WebView/WebActionMenuController.mm: Added.
1604         (-[WebActionMenuController webViewClosed]):
1605         (-[WebActionMenuController prepareForMenu:withEvent:]):
1606
1607         Selectors for link actions.
1608         (-[WebActionMenuController _openURLFromActionMenu:]):
1609         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
1610         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
1611         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1612         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1613         (webKitBundleImageNamed):
1614         (-[WebActionMenuController _defaultMenuItemsForLink:]):
1615         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1616
1617         Tags for the action menu items.
1618         * WebView/WebUIDelegatePrivate.h:
1619         * WebView/WebView.mm:
1620
1621         Set the action menu if possible and create the controller.
1622         (-[WebView _initWithFrame:frameName:groupName:]):
1623         (-[WebView _close]):
1624         (-[WebView prepareForMenu:withEvent:]):
1625
1626         WebViewData stores the WebActionMenuHelper
1627         * WebView/WebViewData.h:
1628         * WebView/WebViewData.mm:
1629         (-[WebViewPrivate dealloc]):
1630
1631 2014-10-23  Joseph Pecoraro  <pecoraro@apple.com>
1632
1633         Web Inspector: Provide a way to have alternate inspector agents
1634         https://bugs.webkit.org/show_bug.cgi?id=137901
1635
1636         Reviewed by Brian Burg.
1637
1638         * Configurations/FeatureDefines.xcconfig:
1639
1640 2014-10-23  Tim Horton  <timothy_horton@apple.com>
1641
1642         Add some SPI headers for NSExtension and NSSharingService{Picker}
1643         https://bugs.webkit.org/show_bug.cgi?id=138027
1644
1645         Reviewed by Anders Carlsson.
1646
1647         * Misc/WebSharingServicePickerController.h:
1648         * Misc/WebSharingServicePickerController.mm:
1649         * WebCoreSupport/WebSelectionServiceController.mm:
1650         * WebCoreSupport/WebContextMenuClient.mm:
1651         Fix a sorting issue.
1652         Replace redefinitions with SPI header #imports.
1653
1654 2014-10-23  Tim Horton  <timothy_horton@apple.com>
1655
1656         Crashes under WebSelectionServiceController::hasRelevantSelectionServices
1657         https://bugs.webkit.org/show_bug.cgi?id=138013
1658
1659         Reviewed by Dan Bernstein.
1660
1661         * WebCoreSupport/WebSelectionServiceController.mm:
1662         (WebSelectionServiceController::hasRelevantSelectionServices):
1663         Don't adopt this autoreleased object.
1664
1665 2014-10-22  Chris Dumez  <cdumez@apple.com>
1666
1667         [Mac][WK2] Fix applicationIsSafari() detection
1668         https://bugs.webkit.org/show_bug.cgi?id=137893
1669
1670         Reviewed by Alexey Proskuryakov.
1671
1672         Provide an implementation for FrameLoaderClient's new
1673         needsQuickLookResourceCachingQuirks() that returns
1674         a static flag initialized using
1675         QuickLookMac::computeNeedsQuickLookResourceCachingQuirks().
1676
1677         * WebCoreSupport/WebFrameLoaderClient.h:
1678         * WebCoreSupport/WebFrameLoaderClient.mm:
1679
1680 2014-10-20  Chris Dumez  <cdumez@apple.com>
1681
1682         ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition
1683         https://bugs.webkit.org/show_bug.cgi?id=137797
1684
1685         Reviewed by Darin Adler.
1686
1687         Call ResourceRequest::setDomainForPartitionName() instead of
1688         setPartitionName() as the argument is a domain, not a valid
1689         partition name.
1690
1691         * Misc/WebCache.mm:
1692         (+[WebCache addImageToCache:forURL:forFrame:]):
1693         (+[WebCache removeImageFromCacheForURL:forFrame:]):
1694
1695 2014-10-20  Andy Estes  <aestes@apple.com>
1696
1697         Fix the iOS build.
1698
1699         * WebView/WebFrame.mm:
1700         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1701         (-[WebFrame dictationResultMetadataForRange:]):
1702
1703 2014-10-19  Chris Dumez  <cdumez@apple.com>
1704
1705         Use is<>() / downcast<>() for all remaining RenderObject subclasses
1706         https://bugs.webkit.org/show_bug.cgi?id=137845
1707
1708         Reviewed by Darin Adler.
1709
1710         Use is<>() / downcast<>() for all remaining RenderObject subclasses and 
1711         clean up the surrounding code.
1712
1713         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1714         (-[WebHostedNetscapePluginView pluginHostDied]):
1715         * Plugins/WebBaseNetscapePluginView.mm:
1716         (-[WebBaseNetscapePluginView _windowClipRect]):
1717         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
1718         * WebCoreSupport/WebFrameLoaderClient.mm:
1719         (WebFrameLoaderClient::createPlugin):
1720         (WebFrameLoaderClient::createJavaAppletWidget):
1721
1722 2014-10-17  Tim Horton  <timothy_horton@apple.com>
1723
1724         Build fix for 32-bit Yosemite
1725
1726         * WebCoreSupport/WebContextMenuClient.mm:
1727         (WebContextMenuClient::contextMenuForEvent):
1728         Avoid using NSItemProvider in 32-bit, because it doesn't exist.
1729
1730 2014-10-17  Chris Dumez  <cdumez@apple.com>
1731
1732         Use is<>() / downcast<>() for RenderBox
1733         https://bugs.webkit.org/show_bug.cgi?id=137804
1734
1735         Reviewed by Andreas Kling.
1736
1737         Use is<>() / downcast<>() for RenderBox and clean up the surrounding
1738         code.
1739
1740         * WebCoreSupport/WebContextMenuClient.mm:
1741         (WebContextMenuClient::clientFloatRectForNode):
1742         * WebView/WebFrame.mm:
1743         (-[WebFrame renderedSizeOfNode:constrainedToWidth:]):
1744
1745 2014-10-17  Tim Horton  <timothy_horton@apple.com>
1746
1747         Fix the build with the public SDK.
1748
1749         * WebCoreSupport/WebSelectionServiceController.mm:
1750         We should transition all this SPI to real SPI headers as soon as possible.
1751
1752 2014-10-16  Tim Horton  <timothy_horton@apple.com>
1753
1754         Implement selection services menu for Legacy WebKit
1755         https://bugs.webkit.org/show_bug.cgi?id=137582
1756         <rdar://problem/18604241>
1757
1758         Reviewed by Brady Eidson.
1759
1760         * Misc/WebSharingServicePickerController.h:
1761         Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
1762         Add WebSharingServicePickerClient, which other classes can implement
1763         instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
1764         Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.
1765
1766         * Misc/WebSharingServicePickerController.mm:
1767         Pass in NSSharingServicePickerStyle, so that clients can specify the style.
1768
1769         (-[WebSharingServicePickerController clear]):
1770         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
1771         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
1772         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
1773         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
1774         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
1775         Make use of WebSharingServicePickerClient.
1776
1777         (-[WebSharingServicePickerController sharingService:didShareItems:]):
1778         If we're returned a NSAttributedString, paste it on top of the current selection,
1779         similar to what the WebKit2 implementation currently does.
1780         
1781         * WebCoreSupport/WebChromeClient.h:
1782         * WebCoreSupport/WebChromeClient.mm:
1783         (WebChromeClient::handleTelephoneNumberClick):
1784         (WebChromeClient::handleSelectionServiceClick):
1785         (WebChromeClient::hasRelevantSelectionServices):
1786         Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.
1787
1788         * WebCoreSupport/WebContextMenuClient.h:
1789         * WebCoreSupport/WebContextMenuClient.mm:
1790         (WebContextMenuClient::sharingServicePickerWillBeDestroyed):
1791         (WebContextMenuClient::pageForSharingServicePicker):
1792         (WebContextMenuClient::windowForSharingServicePicker):
1793         (WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
1794         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1795         (WebContextMenuClient::contextMenuForEvent):
1796         (WebContextMenuClient::screenRectForHitTestNode): Deleted.
1797         (WebContextMenuClient::renderedImageForControlledImage): Deleted.
1798         (WebContextMenuClient::clearSharingServicePickerController): Deleted.
1799         Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
1800         having WebSharingServicePickerController tightly bound to it.
1801         Make an NSItemProvider array when instantiating WebSharingServicePickerController
1802         instead of handing it data directly.
1803
1804         * WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
1805         * WebCoreSupport/WebSelectionServiceController.mm: Added.
1806         (WebSelectionServiceController::WebSelectionServiceController):
1807         Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
1808         for selection services.
1809
1810         (WebSelectionServiceController::handleSelectionServiceClick):
1811         Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.
1812
1813         (hasCompatibleServicesForItems):
1814         (WebSelectionServiceController::hasRelevantSelectionServices):
1815         Determine whether or not services are available.
1816
1817         (WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
1818         (WebSelectionServiceController::pageForSharingServicePicker):
1819         (WebSelectionServiceController::windowForSharingServicePicker):
1820         Implement the rest of the WebSharingServicePickerClient overrides.
1821
1822         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
1823         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
1824         These are only useful for image sharing services, so we don't need to
1825         implement them (WebContextMenuClient does, on the other hand).
1826
1827         * WebView/WebView.mm:
1828         (-[WebView _selectionServiceController]):
1829         * WebView/WebViewData.h:
1830         * WebView/WebViewData.mm:
1831         * WebView/WebViewInternal.h:
1832         Keep a WebSelectionServiceController.
1833
1834 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
1835
1836         Improve debug description of WAKViews
1837         https://bugs.webkit.org/show_bug.cgi?id=137716
1838
1839         Reviewed by Simon Fraser.
1840
1841         * WebView/WebView.mm:
1842         (-[WebView _touchEventRegions]): Adding a comment.
1843
1844 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
1845
1846         Addressing post-review comment.
1847         https://bugs.webkit.org/show_bug.cgi?id=137550
1848
1849         Unreviewed.
1850
1851         * WebView/WebHTMLView.mm:
1852         (fontNameForDescription):
1853         (-[WebHTMLView _addToStyle:fontA:fontB:]):
1854
1855 2014-10-14  Chris Dumez  <cdumez@apple.com>
1856
1857         Use is<>() / downcast<>() for RenderImage
1858         https://bugs.webkit.org/show_bug.cgi?id=137683
1859
1860         Reviewed by Mihnea Ovidenie.
1861
1862         Use is<>() / downcast<>() for RenderImage.
1863
1864         * Misc/WebNSPasteboardExtras.mm:
1865         (imageFromElement):
1866         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1867
1868 2014-10-10  Daniel Bates  <dabates@apple.com>
1869
1870         Remove unused classes WebRender{Node, Layer}
1871         https://bugs.webkit.org/show_bug.cgi?id=137628
1872
1873         Reviewed by Simon Fraser.
1874
1875         We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
1876         For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.
1877
1878         * Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list
1879         of excluded source files when building for iOS.
1880         * WebKit.exp: Remove symbol for WebRenderLayer.
1881         * WebKit.mac.exp: Remove symbol for WebRenderNode.
1882         * WebView/WebRenderLayer.h: Removed.
1883         * WebView/WebRenderLayer.mm: Removed.
1884         * WebView/WebRenderNode.h: Removed.
1885         * WebView/WebRenderNode.mm: Removed.
1886
1887 2014-10-10  Chris Dumez  <cdumez@apple.com>
1888
1889         Use is<>() / downcast<>() for RenderBoxModelObject
1890         https://bugs.webkit.org/show_bug.cgi?id=137587
1891
1892         Reviewed by Mihnea Ovidenie.
1893
1894         Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
1895         surrounding code.
1896
1897         * Plugins/WebBaseNetscapePluginView.mm:
1898         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
1899         * WebView/WebRenderLayer.mm:
1900         (-[WebRenderLayer initWithWebFrame:]):
1901
1902 2014-10-09  Dean Jackson  <dino@apple.com>
1903
1904         Remove ENABLE_CSS3_CONDITIONAL_RULES
1905         https://bugs.webkit.org/show_bug.cgi?id=137571
1906
1907         Reviewed by Simon Fraser.
1908
1909         * Configurations/FeatureDefines.xcconfig:
1910
1911 2014-10-09  Tim Horton  <timothy_horton@apple.com>
1912
1913         Add a WebKit1 preference for selection services
1914         https://bugs.webkit.org/show_bug.cgi?id=137498
1915         <rdar://problem/18572699>
1916
1917         Reviewed by Simon Fraser.
1918
1919         * WebView/WebPreferenceKeysPrivate.h:
1920         * WebView/WebPreferences.mm:
1921         (+[WebPreferences initialize]):
1922         (-[WebPreferences serviceControlsEnabled]):
1923         (-[WebPreferences setServiceControlsEnabled:]):
1924         * WebView/WebPreferencesPrivate.h:
1925         * WebView/WebView.mm:
1926         (-[WebView _preferencesChanged:]):
1927         Add and plumb the preference.
1928
1929 2014-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
1930
1931         Remove second-to-last client of WebFontCache
1932         https://bugs.webkit.org/show_bug.cgi?id=137550
1933
1934         Reviewed by Darin Adler.
1935
1936         Use FontCache::getCachedFontData() instead of WebFontCache.
1937
1938         * WebView/WebHTMLView.mm:
1939         (-[WebHTMLView _addToStyle:fontA:fontB:]):
1940
1941 2014-10-09  Chris Dumez  <cdumez@apple.com>
1942
1943         Use is<>() / downcast<>() for Widget subclasses
1944         https://bugs.webkit.org/show_bug.cgi?id=137549
1945
1946         Reviewed by Darin Adler.
1947
1948         Use is<>() / downcast<>() for Widget subclasses and clean up the
1949         surrounding code.
1950
1951         * WebView/WebRenderNode.mm:
1952         (copyRenderNode):
1953         * WebView/WebView.mm:
1954         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
1955
1956 2014-10-07  Christophe Dumez  <cdumez@apple.com>
1957
1958         Use is<>() / downcast<>() for RenderText / RenderTextFragment
1959         https://bugs.webkit.org/show_bug.cgi?id=137476
1960
1961         Reviewed by Darin Adler.
1962
1963         * WebView/WebRenderNode.mm:
1964         (copyRenderNode):
1965
1966 2014-10-06  Dan Bernstein  <mitz@apple.com>
1967
1968         Build fix.
1969
1970         * Misc/WebCache.mm:
1971         (+[WebCache imageForURL:]):
1972
1973 2014-10-06  Chris Dumez  <cdumez@apple.com>
1974
1975         Unreviewed build fix after r174333.
1976
1977         Forgot explicit WebCore:: namespace.
1978
1979         * Misc/WebCache.mm:
1980         (+[WebCache imageForURL:]):
1981
1982 2014-10-05  Christophe Dumez  <cdumez@apple.com>
1983
1984         Use is<>() / downcast<>() for CachedResource subclasses
1985         https://bugs.webkit.org/show_bug.cgi?id=137431
1986
1987         Reviewed by Benjamin Poulain.
1988
1989         Use is<>() / downcast<>() for CachedResource subclasses.
1990
1991         * Misc/WebCache.mm:
1992         (+[WebCache imageForURL:]):
1993
1994 2014-10-02  Daniel Bates  <dabates@apple.com>
1995
1996         Use version number 101000 instead of 10100 for OS X Yosemite
1997         https://bugs.webkit.org/show_bug.cgi?id=137372
1998
1999         Reviewed by Mark Rowe.
2000
2001         The version number for OS X Yosemite is 101000.
2002
2003         * WebView/WebView.mm:
2004         (-[WebView _preferencesChanged:]):
2005
2006 2014-10-02  Tim Horton  <timothy_horton@apple.com>
2007
2008         Move PageOverlay[Controller] to WebCore
2009         https://bugs.webkit.org/show_bug.cgi?id=137164
2010         <rdar://problem/18508258>
2011
2012         Reviewed by Anders Carlsson.
2013
2014         * WebCoreSupport/WebChromeClient.h:
2015         * WebCoreSupport/WebChromeClient.mm:
2016         (WebChromeClient::attachViewOverlayGraphicsLayer):
2017         Add an empty ChromeClient override.
2018
2019 2014-10-01  Christophe Dumez  <cdumez@apple.com>
2020
2021         Have is<>(T*) function do a null check on the pointer argument
2022         https://bugs.webkit.org/show_bug.cgi?id=137333
2023
2024         Reviewed by Gavin Barraclough.
2025
2026         Have is<>(T*) function do a null check on the argument instead of a
2027         simple assertion. This makes sense for 2 reasons:
2028         1. It is more consistent with downcast<>(T*), which will succeed even
2029            if the argument is a nullptr.
2030         2. It simplifies the code a bit as it gets rid of a lot of explicit
2031            null checks.
2032
2033         * WebCoreSupport/WebChromeClient.mm:
2034         (WebChromeClient::focusedElementChanged):
2035         * WebCoreSupport/WebEditorClient.mm:
2036         (WebEditorClient::textFieldDidBeginEditing):
2037         (WebEditorClient::textFieldDidEndEditing):
2038         (WebEditorClient::textDidChangeInTextField):
2039         (WebEditorClient::doTextFieldCommandFromEvent):
2040         (WebEditorClient::textWillBeDeletedInTextField):
2041         (WebEditorClient::textDidChangeInTextArea):
2042         * WebView/WebHTMLRepresentation.mm:
2043         (inputElementFromDOMElement):
2044         (searchForLabelsBeforeElement):
2045         * WebView/WebRenderLayer.mm:
2046         (+[WebRenderLayer nameForLayer:]):
2047
2048 2014-10-01  Mark Rowe  <mrowe@apple.com>
2049
2050         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
2051
2052         Reviewed by Dan Bernstein.
2053
2054         * Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite.
2055
2056 2014-09-30  Chris Dumez  <cdumez@apple.com>
2057
2058         Use is<>() / downcast<>() for Element
2059         https://bugs.webkit.org/show_bug.cgi?id=137241
2060
2061         Reviewed by Andreas Kling.
2062
2063         Use is<>() / downcast<>() for Element instead of isElementNode() /
2064         toElement().
2065
2066         * WebView/WebRenderLayer.mm:
2067         (+[WebRenderLayer nameForLayer:]):
2068
2069 2014-09-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2070
2071         Move ColorInputType class to std::unique_ptr
2072         https://bugs.webkit.org/show_bug.cgi?id=137173
2073
2074         Reviewed by Darin Adler.
2075
2076         Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr.
2077         Child classes follow this change as well.
2078
2079         * WebCoreSupport/WebChromeClient.h:
2080         * WebCoreSupport/WebChromeClient.mm:
2081         (WebChromeClient::createColorChooser):
2082
2083 2014-09-24  Christophe Dumez  <cdumez@apple.com>
2084
2085         Add initial is<>() / downcast<>() support for any type of Nodes
2086         https://bugs.webkit.org/show_bug.cgi?id=137056
2087
2088         Reviewed by Benjamin Poulain.
2089
2090         Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
2091         instead of isFormControlElement() / toHTMLFormControlElement().
2092
2093         * WebView/WebHTMLRepresentation.mm:
2094         (searchForLabelsBeforeElement):
2095
2096 2014-09-24  Christophe Dumez  <cdumez@apple.com>
2097
2098         Use is<HTML*Element>() instead of isHTML*Element() - Part 1
2099         https://bugs.webkit.org/show_bug.cgi?id=137068
2100
2101         Reviewed by Ryosuke Niwa.
2102
2103         Start using is<HTML*Element>() instead of isHTML*Element().
2104         Remaining usages will be updated in a follow-up patch to
2105         reduce the size of the change.
2106
2107         * WebCoreSupport/WebChromeClient.mm:
2108         (WebChromeClient::focusedElementChanged):
2109         * WebCoreSupport/WebEditorClient.mm:
2110         (WebEditorClient::textFieldDidBeginEditing):
2111         (WebEditorClient::textFieldDidEndEditing):
2112         (WebEditorClient::textDidChangeInTextField):
2113         (WebEditorClient::doTextFieldCommandFromEvent):
2114         (WebEditorClient::textWillBeDeletedInTextField):
2115         (WebEditorClient::textDidChangeInTextArea):
2116         * WebView/WebHTMLRepresentation.mm:
2117         (inputElementFromDOMElement):
2118
2119 2014-09-21  Timothy Hatcher  <timothy@apple.com>
2120
2121         Make the Web Inspector use a separate web process.
2122
2123         https://bugs.webkit.org/show_bug.cgi?id=135120
2124
2125         Reviewed by Anders Carlsson.
2126
2127         * WebCoreSupport/WebInspectorClient.h:
2128         * WebCoreSupport/WebInspectorClient.mm:
2129         (WebInspectorClient::WebInspectorClient):
2130         (WebInspectorClient::openInspectorFrontend):
2131         (WebInspectorClient::releaseFrontend):
2132         Own WebInspectorFrontendClient instead of moving it.
2133
2134 2014-09-23  Chris Dumez  <cdumez@apple.com>
2135
2136         Use downcast<HTML*Element>() instead of toHTML*Element()
2137         https://bugs.webkit.org/show_bug.cgi?id=137007
2138
2139         Reviewed by Benjamin Poulain.
2140
2141         Use downcast<HTML*Element>() instead of toHTML*Element().
2142
2143         * DOM/WebDOMOperations.mm:
2144         (-[DOMHTMLInputElement _setAutofilled:]):
2145         * WebCoreSupport/WebChromeClient.mm:
2146         (WebChromeClient::focusedElementChanged):
2147         * WebCoreSupport/WebEditorClient.mm:
2148         (WebEditorClient::textFieldDidBeginEditing):
2149         (WebEditorClient::textFieldDidEndEditing):
2150         (WebEditorClient::textDidChangeInTextField):
2151         (WebEditorClient::doTextFieldCommandFromEvent):
2152         (WebEditorClient::textWillBeDeletedInTextField):
2153         (WebEditorClient::textDidChangeInTextArea):
2154         * WebView/WebHTMLRepresentation.mm:
2155         (inputElementFromDOMElement):
2156
2157 2014-09-21  Chris Dumez  <cdumez@apple.com>
2158
2159         Generate Element casting helper functions
2160         https://bugs.webkit.org/show_bug.cgi?id=136839
2161
2162         Reviewed by Darin Adler.
2163
2164         Use JSXXX::toWrapped() instead of toXXX() function.
2165
2166         * DOM/WebDOMOperations.mm:
2167         * WebView/WebView.mm:
2168         (-[WebView _notificationIDForTesting:]):
2169
2170 2014-09-21  Joseph Pecoraro  <pecoraro@apple.com>
2171
2172         Leak: WebNotificationPrivate ObjC leaks seen on leaks bot
2173         https://bugs.webkit.org/show_bug.cgi?id=136972
2174
2175         Reviewed by Darin Adler.
2176
2177         * WebView/WebNotification.h:
2178         * WebView/WebNotification.mm:
2179         (-[WebNotification initWithCoreNotification:notificationID:]):
2180         Switch to RetainPtr and adopt into _private to ensure when we are
2181         deallocated that _private will get deallocated.
2182
2183 2014-09-19  Dean Jackson  <dino@apple.com>
2184
2185         Multithreaded WebGL is a bad idea - remove it
2186         https://bugs.webkit.org/show_bug.cgi?id=136964
2187         <rdar://problem/18399858>
2188
2189         Reviewed by Brent Fulgham.
2190
2191         Remove the setting to allow multithreaded WebGL.
2192
2193         * WebView/WebPreferenceKeysPrivate.h:
2194         * WebView/WebPreferences.mm:
2195         (+[WebPreferences initialize]):
2196         (-[WebPreferences multithreadedWebGLEnabled]): Deleted.
2197         (-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted.
2198         * WebView/WebPreferencesPrivate.h:
2199         * WebView/WebView.mm:
2200         (-[WebView _preferencesChanged:]):
2201
2202 2014-09-19  Daniel Bates  <dabates@apple.com>
2203
2204         Always assume internal SDK when building configuration Production
2205         https://bugs.webkit.org/show_bug.cgi?id=136925
2206         <rdar://problem/18362399>
2207
2208         Reviewed by Dan Bernstein.
2209
2210         As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
2211         and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.
2212
2213         * Configurations/Base.xcconfig:
2214
2215 2014-09-17  Daniel Bates  <dabates@apple.com>
2216
2217         Unreviewed, rolling out r173695.
2218
2219         Broke building third-party Legacy WebKit apps; will
2220         investigate offline
2221
2222         Reverted changeset:
2223
2224         "[iOS] Make WebCore build with public iOS SDK"
2225         https://bugs.webkit.org/show_bug.cgi?id=136487
2226         http://trac.webkit.org/changeset/173695
2227
2228 2014-09-17  Daniel Bates  <dabates@apple.com>
2229
2230         [iOS] Make WebCore build with public iOS SDK
2231         https://bugs.webkit.org/show_bug.cgi?id=136487
2232
2233         Reviewed by David Kilzer.
2234
2235         Update WebKit1 source files to include the wrapper SPI headers instead of the corresponding
2236         actual SPI header(s).
2237
2238         * DOM/WebDOMOperationsPrivate.h:
2239         * MigrateHeaders.make: Modified to only modify the include path of a "<WebCore/"-prefixed header
2240         file if its filename doesn't end in "SPI.h" as an alternative to having MigrateHeaders.make copy
2241         such files into the WebKit framework as private headers.
2242         * WebCoreSupport/WebFrameLoaderClient.mm:
2243         * WebInspector/WebNodeHighlight.mm:
2244         * WebView/WebIndicateLayer.mm:
2245         * WebView/WebRenderLayer.h:
2246         * WebView/WebView.mm:
2247
2248 2014-09-16  Daniel Bates  <dabates@apple.com>
2249
2250         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
2251         https://bugs.webkit.org/show_bug.cgi?id=136862
2252
2253         Reviewed by David Kilzer.
2254
2255         * Configurations/DebugRelease.xcconfig:
2256
2257 2014-09-16  Enrica Casucci  <enrica@apple.com>
2258
2259         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
2260         https://bugs.webkit.org/show_bug.cgi?id=136474
2261
2262         Reviewed by Benjamin Poulain.
2263
2264         This is the updated version of the patch that was landed in r173340.
2265         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
2266         and removes the assumption that EAffinity values match NSSelectionAffinity
2267         values. It also removes the includes in TextAffinity.h, creating the need to
2268         include explicitly the files when necessary.
2269
2270         * WebCoreSupport/WebEditorClient.h:
2271         (kit):
2272         (core):
2273
2274 2014-09-14  Daniel Bates  <dabates@apple.com>
2275
2276         [iOS] Attempt to fix the iOS build after <http://trac.webkit.org/changeset/173606>
2277         (https://bugs.webkit.org/show_bug.cgi?id=136789)
2278
2279         Substitute Node::countChildNodes() for Node::childNodeCount() in more places.
2280
2281         * WebView/WebFrame.mm:
2282         (-[WebFrame focusedNodeHasContent]):
2283
2284 2014-09-14  Chris Dumez  <cdumez@apple.com>
2285
2286         Rename Node::childNodeCount() to countChildNodes() and avoid inefficient uses
2287         https://bugs.webkit.org/show_bug.cgi?id=136789
2288
2289         Reviewed by Darin Adler.
2290
2291         Rename childNodeCount() to countChildNodes().
2292
2293         * WebView/WebHTMLView.mm:
2294         (-[WebHTMLView attributedString]):
2295
2296 2014-09-10  Jon Honeycutt  <jhoneycutt@apple.com>
2297
2298         Re-add the request autocomplete feature
2299
2300         <https://bugs.webkit.org/show_bug.cgi?id=136730>
2301
2302         This feature was rolled out in r148731 because it was only used by
2303         Chromium. As we consider supporting this feature, roll it back in, but
2304         leave it disabled.
2305
2306         This rolls out r148731 (which removed the feature) with small changes
2307         needed to make the code build in ToT, to match modern style, to make
2308         the tests run, and to remove unused code.
2309
2310         Reviewed by Andy Estes.
2311
2312         * Configurations/FeatureDefines.xcconfig:
2313         * WebCoreSupport/WebFrameLoaderClient.h:
2314
2315 2014-09-12  Commit Queue  <commit-queue@webkit.org>
2316
2317         Unreviewed, rolling out r173575.
2318         https://bugs.webkit.org/show_bug.cgi?id=136790
2319
2320         Failing tests (Requested by enrica on #webkit).
2321
2322         Reverted changeset:
2323
2324         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
2325         https://bugs.webkit.org/show_bug.cgi?id=136474
2326         http://trac.webkit.org/changeset/173575
2327
2328 2014-09-12  Enrica Casucci  <enrica@apple.com>
2329
2330         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
2331         https://bugs.webkit.org/show_bug.cgi?id=136474
2332
2333         Reviewed by Benjamin Poulain.
2334
2335         This is the updated version of the patch that was landed in r173340.
2336         I changed the use of IntPoint to FloatPoint since it was causing tests
2337         to fail.
2338         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
2339         and removes the assumption that EAffinity values match NSSelectionAffinity
2340         values. It also removes the includes in TextAffinity.h, creating the need to
2341         include explicitly the files when necessary. It also removes the unnecessary
2342         use of platform specific types, replacing them with WebCore types.
2343
2344         * WebCoreSupport/WebEditorClient.h:
2345         (kit):
2346         (core):
2347         * WebView/WebFrameView.mm:
2348         (-[WebFrameView _scrollToBeginningOfDocument]):
2349         (-[WebFrameView _scrollToEndOfDocument]):
2350
2351 2014-09-11  Bear Travis  <betravis@adobe.com>
2352
2353         [CSS Font Loading] Enable CSS Font Loading on Mac
2354         https://bugs.webkit.org/show_bug.cgi?id=135473
2355
2356         Reviewed by Antti Koivisto.
2357
2358         Enable CSS Font Loading in FeatureDefines.
2359
2360         * Configurations/FeatureDefines.xcconfig:
2361
2362 2014-09-11  Beth Dakin  <bdakin@apple.com>
2363
2364         Support rubber-banding in sub-frames
2365         https://bugs.webkit.org/show_bug.cgi?id=136726
2366         -and corresponding-
2367         rdar://problem/10011924
2368
2369         Reviewed by Tim Horton.
2370
2371         rubberBandingForOverflowScrollEnabled is re-named to
2372         rubberBandingForSubScrollableRegionsEnabled
2373         * WebView/WebView.mm:
2374         (-[WebView _preferencesChanged:]):
2375
2376 2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
2377
2378         Disable the "unreachable-code" warning
2379         https://bugs.webkit.org/show_bug.cgi?id=136677
2380
2381         Reviewed by Darin Adler.
2382
2383         * Configurations/Base.xcconfig:
2384
2385 2014-09-08  Maciej Stachowiak  <mjs@apple.com>
2386
2387         Fix 32-bit Mac build for new warnings
2388         https://bugs.webkit.org/show_bug.cgi?id=136624
2389
2390         Reviewed by Darin Adler.
2391         
2392         (Jessie already fixed this but my version with typedefs seems a tiny bit cleaner.)
2393
2394         * Carbon/HIViewAdapter.m:
2395         (+[HIViewAdapter bindHIViewToNSView:nsView:]): Need to use explicit casting now.
2396
2397 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2398
2399         Remove FILTERS flag
2400         https://bugs.webkit.org/show_bug.cgi?id=136571
2401
2402         Reviewed by Darin Adler.
2403
2404         * Configurations/FeatureDefines.xcconfig:
2405
2406 2014-09-08  Jessie Berlin  <jberlin@apple.com>
2407
2408         32-bit build fix after r173364.
2409
2410         * Carbon/HIViewAdapter.m:
2411         (+[HIViewAdapter bindHIViewToNSView:nsView:]):
2412
2413 2014-09-08  Dan Bernstein  <mitz@apple.com>
2414
2415         Build fix.
2416
2417         Added back SPI that is still in use.
2418
2419         * Misc/WebNSURLExtras.h:
2420         * Misc/WebNSURLExtras.mm:
2421         (-[NSURL _webkit_URLByRemovingFragment]):
2422
2423 2014-09-08  Dan Bernstein  <mitz@apple.com>
2424
2425         iOS Simulator build fix.
2426
2427         * Misc/WebKitSystemBits.m:
2428         (WebMemorySize):
2429
2430 2014-09-07  Darin Adler  <darin@apple.com>
2431
2432         Fix build failure seen on Mountain Lion buildbot.
2433
2434         * Misc/WebNSDataExtras.h: Make WEB_GUESS_MIME_TYPE_PEEK_LENGTH an unsigned instead
2435         of an int, to avoid warning about mixing signs.
2436
2437 2014-09-06  Darin Adler  <darin@apple.com>
2438
2439         Make updates suggested by new version of Xcode
2440         https://bugs.webkit.org/show_bug.cgi?id=136603
2441
2442         Reviewed by Mark Rowe.
2443
2444         * Configurations/Base.xcconfig: Added CLANG_WARN_UNREACHABLE_CODE, COMBINE_HIDPI_IMAGES,
2445         and ENABLE_STRICT_OBJC_MSGSEND as suggested by Xcode upgrade check.
2446
2447         * History/WebURLsWithTitles.m:
2448         (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): Use NSUInteger instead of
2449         unsigned for correctness, and to quiet the 32-to-64-bit compiler warning (which is
2450         not turned on because it gives us too many false positives).
2451         * Misc/WebElementDictionary.mm:
2452         (-[WebElementDictionary objectForKey:]): Ditto.
2453         * Misc/WebNSDataExtras.m:
2454         (-[NSData _webkit_guessedMIMETypeForXML]): Ditto.
2455         (-[NSData _webkit_guessedMIMEType]): Ditto.
2456         (-[NSData _webkit_parseRFC822HeaderFields]): Ditto.
2457         (-[NSData _web_locationAfterFirstBlankLine]): Ditto.
2458
2459         * Misc/WebNSURLExtras.h: Removed unused _web_URLWithLowercasedScheme, _web_hostData,
2460         _webkit_URLByRemovingFragment, _webkit_URLByRemovingResourceSpecifier, _webkit_isFTPDirectoryURL,
2461         _webkit_shouldLoadAsEmptyDocument, _web_hostNameNeedsDecodingWithRange:,
2462         _web_hostNameNeedsEncodingWithRange:, _web_decodeHostNameWithRange:, _web_encodeHostNameWithRange:,
2463         and _webkit_URLFragment methods.
2464
2465         * Misc/WebNSURLExtras.mm:
2466         (-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): Deleted.
2467         (-[NSURL _webkit_URLByRemovingFragment]): Deleted.
2468         (-[NSURL _webkit_URLByRemovingResourceSpecifier]): Deleted.
2469         (-[NSURL _webkit_isFTPDirectoryURL]): Deleted.
2470         (-[NSURL _webkit_shouldLoadAsEmptyDocument]): Deleted.
2471         (-[NSURL _web_URLWithLowercasedScheme]): Deleted.
2472         (-[NSString _webkit_isFTPDirectoryURL]): Deleted.
2473         (-[NSString _web_hostNameNeedsDecodingWithRange:]): Deleted.
2474         (-[NSString _web_hostNameNeedsEncodingWithRange:]): Deleted.
2475         (-[NSString _web_decodeHostNameWithRange:]): Deleted.
2476         (-[NSString _web_encodeHostNameWithRange:]): Deleted.
2477         (-[NSString _webkit_URLFragment]): Deleted.
2478
2479         * Plugins/WebPluginDatabase.mm:
2480         (-[WebPluginDatabase removePluginInstanceViewsFor:]): Use a modern for loop
2481         to iterate an array instead of a loop using the type "unsigned int".
2482
2483         * WebCoreSupport/WebOpenPanelResultListener.mm:
2484         (-[WebOpenPanelResultListener chooseFilenames:]): Use NSUInteger instead of int.
2485
2486         * WebView/WebDelegateImplementationCaching.mm:
2487         (CallDelegate): Use wtfCallIMP in one overload that was instead just calling the
2488         directly without a proper type for the function pointer. This might have been causing
2489         an actual problem on 64-bit systems, and it was different from all the other CallDelegate
2490         functions that were already doing this correctly.
2491
2492         * WebView/WebTextCompletionController.mm:
2493         (-[WebTextCompletionController _placePopupWindow:]): Use NSUInteger instead of int.
2494
2495 2014-09-06  Brian J. Burg  <burg@cs.washington.edu>
2496
2497         Web Inspector: convert DockSide to an enum class
2498         https://bugs.webkit.org/show_bug.cgi?id=136601
2499
2500         Reviewed by Timothy Hatcher.
2501
2502         * WebCoreSupport/WebInspectorClient.mm:
2503         (WebInspectorFrontendClient::frontendLoaded):
2504         (-[WebInspectorWindowController attachWindow:]):
2505         (-[WebInspectorWindowController attach]):
2506         (-[WebInspectorWindowController detach]):
2507         * WebInspector/WebInspectorFrontend.mm:
2508         (-[WebInspectorFrontend attach]):
2509
2510 2014-09-05  Commit Queue  <commit-queue@webkit.org>
2511
2512         Unreviewed, rolling out r173340 and r173342.
2513         https://bugs.webkit.org/show_bug.cgi?id=136596
2514
2515         Broke many tests (Requested by ap on #webkit).
2516
2517         Reverted changesets:
2518
2519         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
2520         https://bugs.webkit.org/show_bug.cgi?id=136474
2521         http://trac.webkit.org/changeset/173340
2522
2523         "Build fix after r173340."
2524         http://trac.webkit.org/changeset/173342
2525
2526 2014-09-05  Enrica Casucci  <enrica@apple.com>
2527
2528         Build fix after r173340.
2529
2530         * WebCoreSupport/WebEditorClient.h:
2531         (kit):
2532         (core):
2533
2534 2014-09-05  Enrica Casucci  <enrica@apple.com>
2535
2536         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
2537         https://bugs.webkit.org/show_bug.cgi?id=136474
2538
2539         Reviewed by Benjamin Poulain.
2540
2541         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
2542         and removes the assumption that EAffinity values match NSSelectionAffinity
2543         values. It also removes the includes in TextAffinity.h, creating the need to
2544         include explicitly the files when necessary. It also removes the unnecessary
2545         use of platform specific types, replacing them with WebCore types.
2546
2547         * WebCoreSupport/WebEditorClient.h: Added kit and core for EAffinity.
2548         * WebView/WebFrameView.mm:
2549         (-[WebFrameView _scrollToBeginningOfDocument]):
2550         (-[WebFrameView _scrollToEndOfDocument]):
2551
2552 2014-09-05  Daniel Bates  <dabates@apple.com>
2553
2554         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
2555         (https://bugs.webkit.org/show_bug.cgi?id=136564)
2556
2557         Move #endif inside -viewDidMoveToWindow up one line such that the closing brace ('}') is after it.
2558
2559         * WebView/WebHTMLView.mm:
2560         (-[WebHTMLView viewDidMoveToWindow]):
2561
2562 2014-09-05  Daniel Bates  <dabates@apple.com>
2563
2564         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
2565         (https://bugs.webkit.org/show_bug.cgi?id=136564)
2566
2567         Add !PLATFORM(IOS)-guard in -viewDidMoveToWindow around code that references WebHTMLViewPrivate.flagsChangedEventMonitor.
2568         The instance variable WebHTMLViewPrivate.flagsChangedEventMonitor is guarded by !PLATFORM(IOS).
2569
2570         * WebView/WebHTMLView.mm:
2571         (-[WebHTMLView viewDidMoveToWindow]):
2572
2573 2014-09-05  Daniel Bates  <dabates@apple.com>
2574
2575         [iOS] Fix the iOS build after <http://trac.webkit.org/changeset/173309>
2576         (https://bugs.webkit.org/show_bug.cgi?id=136564)
2577
2578         Include more code inside the !PLATFORM(IOS)-guarded section in -setDataSource:.
2579
2580         * WebView/WebHTMLView.mm:
2581         (-[WebHTMLView setDataSource:]):
2582
2583 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
2584
2585         Use tracking areas instead of (SPI) mouse moved notifications, and follow flags changes with an event monitor
2586         https://bugs.webkit.org/show_bug.cgi?id=136564
2587
2588         Reviewed by Dan Bernstein.
2589         
2590         WebKit1 depended on mouse moved event notifications to track mouse
2591         moves, and on being specially called by Safari to track flags
2592         changes. WebKit2 does both these things better - it uses a tracking area
2593         and event monitors. Copy those approaches.
2594
2595         * WebKit.order: Remove reference to obsolete call.
2596         * WebView/WebHTMLView.mm:
2597         (-[WebHTMLViewPrivate dealloc]): No need to deallocate tracking
2598         area, since we now just always have one.
2599         (-[WebHTMLViewPrivate clear]): ditto
2600         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
2601         New method that posts a fake mouse move event in response to
2602         a flags change event, for use by the event monitor.
2603         (+[WebHTMLView _postFlagsChangedEvent:]): Empty this old call,
2604         still kept around for benefit of older Safari.
2605         (-[WebHTMLView _updateMouseoverWithEvent:]): Handle Dashboard's
2606         special mouseover mode (previously handled in a weird way).
2607         (-[WebHTMLView close]): No more need to mess with mouse moved observer.
2608         (-[WebHTMLView viewWillMoveToWindow:]): ditto
2609         (-[WebHTMLView viewDidMoveToWindow]): ditto; but now hook up a flags
2610         changed monitor.
2611         (-[WebHTMLView windowDidBecomeKey:]): No need to handle non-key window
2612         tracking area or mouse moved observer.
2613         (-[WebHTMLView windowDidResignKey:]): ditto
2614         (-[WebHTMLView windowWillOrderOnScreen:]): No need to mess with mouse
2615         moved observer.
2616         (-[WebHTMLView windowWillOrderOffScreen:]): ditto
2617         (-[WebHTMLView mouseMoved:]): Converted from the old mouseMovedNotification:
2618         (-[WebHTMLView setDataSource:]): Change if around body to early return. Hook
2619         up tracking area - we have to do it here, because before this point, the
2620         WebHTMLView does not know its WebView, which is where dashboard settings
2621         live.
2622         (-[WebHTMLView _removeMouseMovedObserverUnconditionally]): Deleted.
2623         (-[WebHTMLView addMouseMovedObserver]): Deleted.
2624         (-[WebHTMLView removeMouseMovedObserver]): Deleted.
2625
2626 2014-09-04  Pratik Solanki  <psolanki@apple.com>
2627
2628         Bring back [WebPreferences setDiskImageCacheEnabled:] for backwards compatibility
2629         https://bugs.webkit.org/show_bug.cgi?id=136560
2630
2631         Reviewed by Joseph Pecoraro.
2632
2633         I removed the disk image caching code in r173265. However, we still have clients that call
2634         setDiskImageCacheEnabled. Add in a stub method until we can wean the clients off this call.
2635
2636         * WebView/WebPreferences.mm:
2637         (-[WebPreferences setDiskImageCacheEnabled:]):
2638         * WebView/WebPreferencesPrivate.h:
2639
2640 2014-09-03  Andy Estes  <aestes@apple.com>
2641
2642         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
2643         https://bugs.webkit.org/show_bug.cgi?id=136521
2644
2645         Reviewed by Anders Carlsson.
2646
2647         Taught MigrateHeaders.make to remove WEBCORE_EXPORT from headers using this sed expression:
2648
2649             s/(^ *)WEBCORE_EXPORT /\1/g
2650
2651         This removes WEBCORE_EXPORT and a single following space character but preserves preceeding spaces.
2652
2653         * MigrateHeaders.make:
2654
2655 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
2656
2657         Remove WebCoreSystemInterface glue for otherwise unused WKSI calls
2658         https://bugs.webkit.org/show_bug.cgi?id=136527
2659
2660         Reviewed by Alexey Proskuryakov.
2661
2662         * WebCoreSupport/WebSystemInterface.mm:
2663         (InitWebCoreSystemInterface):
2664
2665 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2666
2667         Remove CSS_FILTERS flag
2668         https://bugs.webkit.org/show_bug.cgi?id=136529
2669
2670         Reviewed by Dirk Schulze.
2671
2672         * Configurations/FeatureDefines.xcconfig:
2673
2674 2014-09-04  Pratik Solanki  <psolanki@apple.com>
2675
2676         Remove iOS specific disk image cache
2677         https://bugs.webkit.org/show_bug.cgi?id=136517
2678
2679         Reviewed by Antti Koivisto.
2680
2681         Disk image cache code unnecessarily complicates SharedBuffer implementation. We can remove
2682         this now since we don't enable it in WebKit2 on iOS.
2683
2684         * Misc/WebCache.mm:
2685         (+[WebCache statistics]):
2686         * WebView/WebDataSource.mm:
2687         (-[WebDataSource _setAllowToBeMemoryMapped]):
2688         (-[WebDataSource setDataSourceDelegate:]):
2689         (-[WebDataSource dataSourceDelegate]):
2690         (-[WebDataSource dealloc]):
2691         (BufferMemoryMapped): Deleted.
2692         * WebView/WebPreferenceKeysPrivate.h:
2693         * WebView/WebPreferences.mm:
2694         (+[WebPreferences initialize]):
2695         (-[WebPreferences diskImageCacheEnabled]): Deleted.
2696         (-[WebPreferences setDiskImageCacheEnabled:]): Deleted.
2697         (-[WebPreferences diskImageCacheMinimumImageSize]): Deleted.
2698         (-[WebPreferences setDiskImageCacheMinimumImageSize:]): Deleted.
2699         (-[WebPreferences diskImageCacheMaximumCacheSize]): Deleted.
2700         (-[WebPreferences setDiskImageCacheMaximumCacheSize:]): Deleted.
2701         (-[WebPreferences _diskImageCacheSavedCacheDirectory]): Deleted.
2702         (-[WebPreferences _setDiskImageCacheSavedCacheDirectory:]): Deleted.
2703         * WebView/WebPreferencesPrivate.h:
2704         * WebView/WebView.mm:
2705         (-[WebView _commonInitializationWithFrameName:groupName:]):
2706         (+[WebView _handleMemoryWarning]):
2707         (-[WebView _preferencesChanged:]):
2708
2709 2014-09-04  Daniel Bates  <dabates@apple.com>
2710
2711         [iOS] Make iOS build when ENABLE_TOUCH_EVENT and ENABLE_IOS_TOUCH_EVENTS disabled
2712         https://bugs.webkit.org/show_bug.cgi?id=136494
2713
2714         Reviewed by Andy Estes.
2715
2716         * MigrateHeaders.make: Migrate header WebEventRegion.h only when ENABLE_IOS_TOUCH_EVENTS is defined.
2717         * WebView/WebView.mm: Substitute ENABLE(IOS_TOUCH_EVENTS) for ENABLE(TOUCH_EVENTS).
2718
2719 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
2720
2721         Web Inspector: fix prefixes for subclasses of JSC::ConsoleClient
2722         https://bugs.webkit.org/show_bug.cgi?id=136476
2723
2724         Reviewed by Timothy Hatcher.
2725
2726         * Misc/WebCoreStatistics.mm:
2727         (+[WebCoreStatistics shouldPrintExceptions]):
2728         (+[WebCoreStatistics setShouldPrintExceptions:]):
2729
2730 2014-09-03  Enrica Casucci  <enrica@apple.com>
2731
2732         Remove PLATFORM(IOS) from WebCore/editing (Part 1).
2733         https://bugs.webkit.org/show_bug.cgi?id=136474
2734
2735         Reviewed by Tim Horton.
2736
2737         * WebCoreSupport/WebEditorClient.mm:
2738         (undoNameForEditAction):
2739
2740 2014-09-02  Maciej Stachowiak  <mjs@apple.com>
2741
2742         Clean up naming for and slightly refactor legacy video fullscreen support
2743         https://bugs.webkit.org/show_bug.cgi?id=136446
2744
2745         Reviewed by Jer Noble.
2746
2747         Key changes:
2748         supportsFullscreenForNode(Node*) --> supportsVideoFullscreen()
2749         enterFullscreenForNode(Node*) --> enterVideoFullscreenForVideoElement(HTMLVideoElement*)
2750         exitFullscreenForNode(Node*) --> exitVideoFullscreen()
2751         
2752         The old versions had unnecessary parameters, did not clearly distinguish their purpose
2753         from enterFullscreenForElement and friends, and wrongly claimed generality to all Nodes.
2754         Also changed many other places to use HTMLVideoElement* instead of Node* or 
2755         HTMLMediaElement* when they were in fact only used for video elements and would only
2756         work for such.
2757
2758         * WebCoreSupport/WebChromeClient.h:
2759         * WebCoreSupport/WebChromeClient.mm:
2760         (WebChromeClient::supportsVideoFullscreen): Adjust for main refactoring.
2761         Also no more need to check for video elementness.
2762         (WebChromeClient::enterVideoFullscreenForVideoElement): Adjust for main refactoring.
2763         (WebChromeClient::exitVideoFullscreen): ditto
2764         * WebView/WebView.mm:
2765         (-[WebView _enterVideoFullscreenForVideoElement:]): Adjust for main
2766         refactoring.
2767         (-[WebView _exitVideoFullscreen]): ditto
2768         (-[WebView _close]): ditto
2769         * WebView/WebViewInternal.h:
2770
2771 2014-09-03  Dan Bernstein  <mitz@apple.com>
2772
2773         Get rid of HIGH_DPI_CANVAS leftovers
2774         https://bugs.webkit.org/show_bug.cgi?id=136491
2775
2776         Reviewed by Benjamin Poulain.
2777
2778         * Configurations/FeatureDefines.xcconfig: Removed definition of ENABLE_HIGH_DPI_CANVAS
2779         and removed it from FEATURE_DEFINES.
2780
2781 2014-08-31  Tim Horton  <timothy_horton@apple.com>
2782
2783         Remove unnecessary (and unnecessarily iOS-specific) setStrokeAndFillColor
2784         https://bugs.webkit.org/show_bug.cgi?id=136416
2785
2786         Reviewed by Dan Bernstein.
2787
2788         * WebView/WebFrameView.mm:
2789         (-[WebFrameView drawRect:]):
2790         We only end up filling, so only set the fill color.
2791
2792 2014-08-26  Maciej Stachowiak  <mjs@apple.com>
2793
2794         Use RetainPtr::autorelease in some places where it seems appropriate
2795         https://bugs.webkit.org/show_bug.cgi?id=136280
2796
2797         Reviewed by Darin Adler.
2798
2799         * WebView/WebHTMLView.mm:
2800         (imageFromRect): Use RetainPtr in this function.
2801         * WebView/WebPDFRepresentation.mm:
2802         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use RetainPtr
2803         in this method.
2804
2805 2014-08-29  Csaba Osztrogonác  <ossy@webkit.org>
2806
2807         Unreviwed, remove empty directories.
2808
2809         * ForwardingHeaders/wtf: Removed.
2810
2811 2014-08-27  Zalan Bujtas  <zalan@apple.com>
2812
2813         Subpixel layout: Rename LayoutRect's device pixel snapping functions.
2814         https://bugs.webkit.org/show_bug.cgi?id=136319
2815
2816         Reviewed by Simon Fraser.
2817
2818         From pixelSnappedForPainting() to snapRectToDevicePixels() and 
2819         pixelSnappedIntRect*() to snappedIntRect*().
2820
2821         No change in functionality.
2822
2823         * WebView/WebView.mm:
2824         (-[WebView _dashboardRegions]):
2825         (-[WebView trackedRepaintRects]):
2826
2827 2014-08-25  Maciej Stachowiak  <mjs@apple.com>
2828
2829         Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API
2830         https://bugs.webkit.org/show_bug.cgi?id=136082
2831
2832         Reviewed by Alexey Proskuryakov.
2833
2834         * Plugins/Hosted/NetscapePluginHostManager.mm:
2835         (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current
2836         localization name using WebCore helper instead of SPI.
2837         * Plugins/WebBasePluginPackage.mm: Fixed the include style for this 
2838         file.
2839         (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current
2840         localization name using WebCore helper instead of SPI.
2841         (+[WebBasePluginPackage preferredLocalizationName]): Deleted. This
2842         helper no longer pulls its weight.
2843         * WebCoreSupport/WebSystemInterface.mm: 
2844         (InitWebCoreSystemInterface): Remove mention of
2845         WKCopyCFLocalizationPreferredName.
2846         * WebKit.order: ditto
2847
2848 2014-08-25  Daniel Bates  <dabates@apple.com>
2849
2850         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/172889>
2851         (https://bugs.webkit.org/show_bug.cgi?id=109658)
2852
2853         Substitute GraphicsLayer::setContentsToPlatformLayer(..., GraphicsLayer::ContentsLayerForMedia)
2854         for GraphicsLayer::setContentsToMedia(...) because the latter was removed in <http://trac.webkit.org/changeset/172889>.
2855
2856         * WebView/WebView.mm:
2857         (-[WebView _setMediaLayer:forPluginView:]):
2858
2859 2014-08-22  Commit Queue  <commit-queue@webkit.org>
2860
2861         Unreviewed, rolling out r172866.
2862         https://bugs.webkit.org/show_bug.cgi?id=136177
2863
2864         Broke iOS build (Requested by othermaciej on #webkit).
2865
2866         Reverted changeset:
2867
2868         "Replace use of WKCopyCFLocalizationPreferredName with
2869         NSLocale public API"
2870         https://bugs.webkit.org/show_bug.cgi?id=136082
2871         http://trac.webkit.org/changeset/172866
2872
2873 2014-08-22  Simon Fraser  <simon.fraser@apple.com>
2874
2875         Implement paint flashing in the WK1 InspectorOverlay page
2876         https://bugs.webkit.org/show_bug.cgi?id=136138
2877
2878         Reviewed by Sam Weinig, Joseph Pecoraro.
2879
2880         Implement paint flashing for the WebKit1 InspectorOverlay via a second canvas in the overlay page.
2881         We avoid allocating backing store for this canvas until we have paint rects.
2882         
2883         Because this overlay page is weird and doesn't know how to paint itself, InspectorOverlay manages
2884         an array of rects, and pushes them to the page when they change, before forcing a paint.
2885         
2886         Because iOS doesn't use the InspectorOverlay page, stub out setShowPaintRects on its
2887         WebKit WebInspectorClient, but don't yet implement paint flashing there.
2888
2889         * WebCoreSupport/WebInspectorClient.h:
2890         * WebCoreSupport/WebInspectorClient.mm:
2891         (WebInspectorClient::WebInspectorClient):
2892
2893 2014-08-20  Maciej Stachowiak  <mjs@apple.com>
2894
2895         Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API
2896         https://bugs.webkit.org/show_bug.cgi?id=136082
2897
2898         Reviewed by Alexey Proskuryakov.
2899
2900         * Plugins/Hosted/NetscapePluginHostManager.mm:
2901         (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current
2902         localization name using WebCore helper instead of SPI.
2903         * Plugins/WebBasePluginPackage.mm: Fixed the include style for this 
2904         file.
2905         (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current
2906         localization name using WebCore helper instead of SPI.
2907         (+[WebBasePluginPackage preferredLocalizationName]): Deleted. This
2908         helper no longer pulls its weight.
2909         * WebCoreSupport/WebSystemInterface.mm: 
2910         (InitWebCoreSystemInterface): Remove mention of
2911         WKCopyCFLocalizationPreferredName.
2912         * WebKit.order: ditto
2913
2914 2014-08-22  Daniel Bates  <dabates@apple.com>
2915
2916         [iOS] Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, and temporarily disable ENABLE_TOUCH_EVENTS
2917         and ENABLE_XSLT when building with the iOS public SDK
2918         https://bugs.webkit.org/show_bug.cgi?id=135945
2919
2920         Reviewed by Andy Estes.
2921
2922         * Configurations/FeatureDefines.xcconfig: Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, ENABLE_TOUCH_EVENTS
2923         and ENABLE_XSLT when building with the public SDK.
2924         * MigrateHeaders.make: Conditionally migrate headers for touch and gesture events.
2925
2926 2014-08-22  Jon Lee  <jonlee@apple.com>
2927
2928         Fix iOS build due to r172832 and move RUBBER_BANDING out of FeatureDefines.h
2929         https://bugs.webkit.org/show_bug.cgi?id=136157
2930
2931         Reviewed by Simon Fraser.
2932
2933         * Configurations/FeatureDefines.xcconfig: Add ENABLE(RUBBER_BANDING).
2934         * WebView/WebView.mm:
2935         (-[WebView _preferencesChanged:]): Wrap in ENABLE(RUBBER_BANDING).
2936
2937 2014-08-21  Zalan Bujtas  <zalan@apple.com>
2938
2939         Enable SATURATED_LAYOUT_ARITHMETIC.
2940         https://bugs.webkit.org/show_bug.cgi?id=136106
2941
2942         Reviewed by Simon Fraser.
2943
2944         SATURATED_LAYOUT_ARITHMETIC protects LayoutUnit against arithmetic overflow.
2945         (No measurable performance regression on Mac.)
2946
2947         * Configurations/FeatureDefines.xcconfig:
2948
2949 2014-08-21  Beth Dakin  <bdakin@apple.com>
2950
2951         overflow:scroll elements should support rubber-banding
2952         https://bugs.webkit.org/show_bug.cgi?id=91655
2953
2954         Reviewed by Sam Weinig and Darin Adler.
2955
2956         Disable rubber-banding in overflow areas for now.
2957         * WebView/WebView.mm:
2958         (-[WebView _preferencesChanged:]):
2959
2960 2014-08-19  Pratik Solanki  <psolanki@apple.com>
2961
2962         Remove PurgeableBuffer since it is not very useful any more
2963         https://bugs.webkit.org/show_bug.cgi?id=135939
2964
2965         Reviewed by Andreas Kling.
2966
2967         * Misc/WebCache.mm:
2968         (+[WebCache statistics]):
2969
2970 2014-08-19  Zalan Bujtas  <zalan@apple.com>
2971
2972         Remove ENABLE(SUBPIXEL_LAYOUT).
2973         https://bugs.webkit.org/show_bug.cgi?id=136077
2974
2975         Reviewed by Simon Fraser.
2976
2977         Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.
2978
2979         * Configurations/FeatureDefines.xcconfig:
2980
2981 2014-08-18  Maciej Stachowiak  <mjs@apple.com>
2982
2983         Use NSURLFileTypeMappings directly instead of depending on WebKitSystemInterface wrappers for it
2984         https://bugs.webkit.org/show_bug.cgi?id=136035
2985
2986         Reviewed by Dan Bernstein.
2987
2988         * Misc/WebNSViewExtras.m:
2989         (-[NSView _web_DragImageForElement:rect:event:pasteboard:source:offset:]): Remove comment
2990         reference to obsolete WKSI function.
2991         * WebCoreSupport/WebSystemInterface.mm:
2992         (InitWebCoreSystemInterface): Don't initialize the no-longer-used WKGetExtensionsForMIMEType,
2993         WKGetPreferredExtensionForMIMEType, or WKGetMIMETypeForExtension
2994         * Plugins/WebPluginDatabase.mm:
2995         (-[WebPluginDatabase pluginForExtension:]): Include SPI header from WebCore; use
2996         NSURLFileTypeMappings directly instead of via WKSI wrapper.
2997         * WebCoreSupport/WebFrameLoaderClient.mm:
2998         (WebFrameLoaderClient::objectContentType): ditto
2999         * WebView/WebHTMLView.mm:
3000         (-[WebHTMLView _imageExistsAtPaths:]): ditto
3001         * WebView/WebView.mm:
3002         (+[WebView _supportedFileExtensions]): ditto
3003         (+[WebView suggestedFileExtensionForMIMEType:]): ditto
3004         (+[WebView _MIMETypeForFile:]): ditto
3005
3006 2014-08-18  Commit Queue  <commit-queue@webkit.org>
3007
3008         Unreviewed, rolling out r172736.
3009         https://bugs.webkit.org/show_bug.cgi?id=136060
3010
3011         Caused 14% PLT regressions (Requested by rniwa on #webkit).
3012
3013         Reverted changeset:
3014
3015         "Remove PurgeableBuffer since it is not very useful any more"
3016         https://bugs.webkit.org/show_bug.cgi?id=135939
3017         http://trac.webkit.org/changeset/172736
3018
3019 2014-08-18  Pratik Solanki  <psolanki@apple.com>
3020
3021         Remove PurgeableBuffer since it is not very useful any more
3022         https://bugs.webkit.org/show_bug.cgi?id=135939
3023
3024         Reviewed by Geoffrey Garen.
3025
3026         * Misc/WebCache.mm:
3027         (+[WebCache statistics]):
3028
3029 2014-08-18  Andy Estes  <aestes@apple.com>
3030
3031         REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
3032         https://bugs.webkit.org/show_bug.cgi?id=136010
3033
3034         Reviewed by Darin Adler.
3035
3036         * Misc/WebKitVersionChecks.h: Removed WEBKIT_FIRST_VERSION_WITH_NAVIGATION_URL_VALIDATION.
3037         * WebView/WebPDFView.mm:
3038         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Passed AllowNavigationToInvalidURL::Yes to FrameLoader::loadFrameRequest.
3039         * WebView/WebView.mm:
3040         (-[WebView _preferencesChanged:]): Reverted the linked-on-or-after check added in r170120 since it's no longer necessary.
3041
3042 2014-08-18  Andy Estes  <aestes@apple.com>
3043
3044         Revert r172697.
3045
3046         It made several webarchive layout tests flaky and didn't have the correct behavior for non-quick redirects.
3047
3048         * Misc/WebKitVersionChecks.h:
3049         * WebView/WebView.mm:
3050         (-[WebView _preferencesChanged:]):
3051
3052 2014-08-15  Andy Estes  <aestes@apple.com>
3053
3054         REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
3055         https://bugs.webkit.org/show_bug.cgi?id=136010
3056
3057         Reviewed by Darin Adler.
3058
3059         Reverted the linked-on-or-after check added in r170120 since it is no longer necessary.
3060
3061         * Misc/WebKitVersionChecks.h:
3062         * WebView/WebView.mm:
3063         (-[WebView _preferencesChanged:]):
3064
3065 2014-08-16  Maciej Stachowiak  <mjs@apple.com>
3066
3067         Remove the obsolete WebKitEnableCoalescedUpdatesPreferenceKey
3068         https://bugs.webkit.org/show_bug.cgi?id=136024
3069
3070         Reviewed by Filip Pizlo.
3071
3072         * WebView/WebFrameView.mm:
3073         (-[WebFrameView initWithFrame:]): Remove code that respects
3074         this key. It was SPI and is no longer used; also it was
3075         only relevant for versions of OS X that WebKit no longer supports.
3076         * WebView/WebPreferenceKeysPrivate.h: Remove declaration.
3077
3078 2014-08-15  Daniel Bates  <dabates@apple.com>
3079
3080         [iOS] Teach postprocess-headers.sh to remove code guarded by ENABLE_IOS_GESTURE_EVENTS
3081         and ENABLE_TOUCH_EVENTS if applicable
3082         https://bugs.webkit.org/show_bug.cgi?id=135993
3083
3084         Reviewed by Andy Estes.
3085
3086         Add support infrastructure to remove code from public and private API headers that is
3087         guarded by macro define ENABLE_{IOS_GESTURE, TOUCH}_EVENTS when these features are disabled.
3088
3089         We aren't using this functionality yet, but we will soon.
3090
3091         * postprocess-headers.sh:
3092
3093 2014-08-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3094
3095         Enable CSS_SCROLL_SNAP for iOS
3096         https://bugs.webkit.org/show_bug.cgi?id=135915
3097
3098         Turn on CSS_SCROLL_SNAP for iOS and the iOS simulator.
3099
3100         Reviewed by Tim Horton.
3101
3102         * Configurations/FeatureDefines.xcconfig:
3103
3104 2014-08-13  Mark Rowe  <mrowe@apple.com>
3105
3106         <https://webkit.org/b/135911> WebKit should build on Yosemite with the public SDK.
3107
3108         Reviewed by Darin Adler.
3109
3110         * Misc/WebSharingServicePickerController.mm: Forward-declare some details related to NSSharingServicePicker.
3111
3112 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3113
3114         Web Inspector: Workaround a NSWindow change to the title bar.
3115         https://bugs.webkit.org/show_bug.cgi?id=135880
3116
3117         Reviewed by Joseph Pecoraro.
3118
3119         * WebCoreSupport/WebInspectorClient.mm:
3120         (WebInspectorFrontendClient::setToolbarHeight): Only call setContentBorderThickness: on 10.9 and earlier.
3121         (-[WebInspectorWindowController init]): Only call setDrawsBackground: on 10.9 and earlier.
3122         (-[WebInspectorWindowController window]): Set titlebarAppearsTransparent on 10.10.
3123         Only call border thickness APIs on 10.9 and earlier.
3124
3125 2014-08-12  Peyton Randolph  <prandolph@apple.com>
3126
3127         Runtime switch for long mouse press gesture. Part of 135257 - Add long mouse press gesture.           
3128         https://bugs.webkit.org/show_bug.cgi?id=135682
3129
3130         Reviewed by Tim Horton.
3131
3132         * Configurations/FeatureDefines.xcconfig:
3133         Remove LONG_MOUSE_PRESS feature flag.
3134
3135 2014-08-11  Andy Estes  <aestes@apple.com>
3136
3137         [iOS] Get rid of iOS.xcconfig
3138         https://bugs.webkit.org/show_bug.cgi?id=135809
3139
3140         Reviewed by Joseph Pecoraro.
3141
3142         All iOS.xcconfig did was include AspenFamily.xcconfig, so there's no need for the indirection.
3143
3144         * Configurations/Base.xcconfig:
3145         * Configurations/iOS.xcconfig: Removed.
3146
3147 2014-08-10  Timothy Hatcher  <timothy@apple.com>
3148
3149         Web Inspector: new glyphs are visible on OS X 10.9 builds
3150         https://bugs.webkit.org/show_bug.cgi?id=135743
3151
3152         Reviewed by Joseph Pecoraro.
3153
3154         * WebCoreSupport/WebInspectorClient.mm:
3155         (-[WebInspectorWindowController window]): Use 10100 instead of 1090 for the version.
3156
3157 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
3158
3159         Get rid of SCRIPTED_SPEECH
3160         https://bugs.webkit.org/show_bug.cgi?id=135729
3161
3162         Reviewed by Brent Fulgham.
3163
3164         * Configurations/FeatureDefines.xcconfig:
3165
3166 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
3167
3168         Get rid of INPUT_SPEECH
3169         https://bugs.webkit.org/show_bug.cgi?id=135672
3170
3171         Reviewed by Andreas Kling.
3172
3173         * Configurations/FeatureDefines.xcconfig:
3174
3175 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3176
3177         Web Inspector: Update glyphs to be more like Xcode 6
3178         https://bugs.webkit.org/show_bug.cgi?id=135705
3179
3180         Reviewed by Joseph Pecoraro.
3181
3182         * Resources/Dock.pdf: Added.
3183         * Resources/DockLegacy.pdf: Copied from Source/WebKit/mac/Resources/Dock.pdf.
3184         * WebCoreSupport/WebInspectorClient.mm:
3185         (-[WebInspectorWindowController window]): Use new images.
3186
3187 2014-08-06  Dean Jackson  <dino@apple.com>
3188
3189         ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED is not used anywhere. Remove it.
3190         https://bugs.webkit.org/show_bug.cgi?id=135675
3191
3192         Reviewed by Sam Weinig.
3193
3194         * Configurations/FeatureDefines.xcconfig:
3195
3196 2014-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3197
3198         Implement parsing for CSS scroll snap points
3199         https://bugs.webkit.org/show_bug.cgi?id=134301
3200
3201         Reviewed by Dean Jackson.
3202
3203         * Configurations/FeatureDefines.xcconfig: Added ENABLE_CSS_SCROLL_SNAP
3204
3205 2014-08-06  Alexey Proskuryakov  <ap@apple.com>
3206
3207         REGRESSION (WebKit2): iOS Safari default encoding doesn't follow system language
3208         https://bugs.webkit.org/show_bug.cgi?id=135667
3209         <rdar://problem/17862892>
3210
3211         Reviewed by Anders Carlsson.
3212
3213         * WebView/WebPreferences.mm: (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]):
3214         Moved implementation to WebCore, so that it can be shared with WebKit2.
3215
3216         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
3217         We now use WKGetWebDefaultCFStringEncoding in WebCore, so it needs to be initialized.
3218
3219 2014-08-05  Peyton Randolph  <prandolph@apple.com>
3220
3221         Rename MAC_LONG_PRESS feature flag to LONG_MOUSE_PRESS.
3222         https://bugs.webkit.org/show_bug.cgi?id=135276
3223
3224         Reviewed by Beth Dakin.
3225
3226         * Configurations/FeatureDefines.xcconfig:
3227
3228 2014-08-04  Benjamin Poulain  <benjamin@webkit.org>
3229
3230         Add a flag for the CSS Selectors level 4 implementation
3231         https://bugs.webkit.org/show_bug.cgi?id=135535
3232
3233         Reviewed by Andreas Kling.
3234
3235         * Configurations/FeatureDefines.xcconfig:
3236
3237 2014-08-04  Benjamin Poulain  <bpoulain@apple.com>
3238
3239         Check for null frame when processing geolocation authorization request
3240         https://bugs.webkit.org/show_bug.cgi?id=135577
3241         <rdar://problem/17896295>
3242
3243         Reviewed by Geoffrey Garen.
3244
3245         * WebCoreSupport/WebGeolocationClient.mm:
3246         (WebGeolocationClient::requestPermission):
3247
3248 2014-08-02  Jeremy Jones  <jeremyj@apple.com>
3249
3250         Support both window and view based video fullscreen.
3251         https://bugs.webkit.org/show_bug.cgi?id=135525
3252
3253         Reviewed by Simon Fraser.
3254
3255         Parenting in the view instead of the window gives the fullscreen implementation more latitude 
3256         in how it implements the animation.
3257
3258         * WebView/WebView.mm:
3259         (-[WebView _enterFullscreenForNode:]): Use view instead of window.
3260
3261 2014-08-01  Dan Bernstein  <mitz@apple.com>
3262
3263         <rdar://problem/17891752> [iOS] WebKit links against libraries it doesn’t use
3264         https://bugs.webkit.org/show_bug.cgi?id=135536
3265
3266         Reviewed by Tim Horton.
3267
3268         * Configurations/WebKitLegacy.xcconfig: Removed -framework MobileAsset from
3269         OTHER_LDFLAGS_iphoneos.
3270
3271 2014-07-30  Andy Estes  <aestes@apple.com>
3272
3273         USE(CONTENT_FILTERING) should be ENABLE(CONTENT_FILTERING)
3274         https://bugs.webkit.org/show_bug.cgi?id=135439
3275
3276         Reviewed by Tim Horton.
3277
3278         We now support two different platform content filters, and will soon support a mock content filter (as part of
3279         webkit.org/b/128858). This makes content filtering a feature of WebKit, not just an adoption of a third-party
3280         library. ENABLE() is the correct macro to use for such a feature.
3281
3282         * Configurations/FeatureDefines.xcconfig:
3283
3284 2014-07-30  Andreas Kling  <akling@apple.com>
3285
3286         Static hash tables no longer need to be coupled with a VM.
3287         <https://webkit.org/b/135421>
3288
3289         Reviewed by Geoffrey Garen.
3290
3291         * Plugins/Hosted/ProxyInstance.mm:
3292         * Plugins/Hosted/ProxyRuntimeObject.mm:
3293
3294 2014-07-30  Dan Bernstein  <mitz@apple.com>
3295
3296         Updated for changes to the WebCore::Credential API.
3297         Work towards fixing https://bugs.webkit.org/show_bug.cgi?id=135327
3298
3299         Reviewed by Alexey Proskuryakov.
3300
3301         * Misc/WebDownload.mm:
3302         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): Use new nsCredential
3303         getter.
3304         * Plugins/WebBaseNetscapePluginView.mm:
3305         (WebKit::getAuthenticationInfo): Ditto.
3306
3307 2014-07-27  Pratik Solanki  <psolanki@apple.com>
3308
3309         Remove unused preference keys
3310         https://bugs.webkit.org/show_bug.cgi?id=135280
3311
3312         Reviewed by Darin Adler.
3313
3314         * WebView/WebPreferenceKeysPrivate.h:
3315         * WebView/WebPreferences.mm:
3316         (+[WebPreferences initialize]):
3317         (-[WebPreferences _setPageCacheSize:]): Deleted.
3318         (-[WebPreferences _pageCacheSize]): Deleted.
3319         (-[WebPreferences _setObjectCacheSize:]): Deleted.
3320         (-[WebPreferences _objectCacheSize]): Deleted.
3321         * WebView/WebPreferencesPrivate.h:
3322
3323 2014-07-27  Filip Pizlo  <fpizlo@apple.com>
3324
3325         Merge r170090, r170092, r170129, r170141, r170161, r170215, r170275, r170375, r170376, r170382, r170383, r170399, r170436, r170489, r170490, r170556 from ftlopt.
3326
3327     2014-07-25  Mark Lam  <mark.lam@apple.com>
3328     
3329             [ftlopt] Renamed DebuggerActivation to DebuggerScope.
3330             <https://webkit.org/b/134273>
3331     
3332             Reviewed by Michael Saboff.
3333     
3334             * WebView/WebScriptDebugDelegate.mm:
3335             - Removed unneeded #include.
3336     
3337 2014-07-26  Filip Pizlo  <fpizlo@apple.com>
3338
3339         Unreviewed, roll out r171641-r171644. It broke some tests; will investigate and
3340         reland later.
3341
3342         * WebView/WebScriptDebugDelegate.mm:
3343
3344 2014-07-25  Filip Pizlo  <fpizlo@apple.com>
3345
3346         Merge r170090, r170092, r170129, r170141, r170161, r170215, r170275, r170375, r170376, r170382, r170383, r170399, r170436, r170489, r170490, r170556 from ftlopt.
3347
3348     2014-07-25  Mark Lam  <mark.lam@apple.com>
3349     
3350             [ftlopt] Renamed DebuggerActivation to DebuggerScope.
3351             <https://webkit.org/b/134273>
3352     
3353             Reviewed by Michael Saboff.
3354     
3355             * WebView/WebScriptDebugDelegate.mm:
3356             - Removed unneeded #include.
3357     
3358 2014-07-25  Jeremy Jones  <jeremyj@apple.com>
3359
3360         Parent fullscreen from window instead of view
3361         https://bugs.webkit.org/show_bug.cgi?id=135310
3362
3363         Reviewed by Jer Noble.
3364
3365         Parenting in the view causes an incorrect animation to fullscreen, and can cause 
3366         fullscreen to only expand to the size of the view instead of the whole window.
3367
3368         * WebView/WebView.mm:
3369         (-[WebView _enterFullscreenForNode:]): Pass window instead of view.
3370
3371 2014-07-24  Pratik Solanki  <psolanki@apple.com>
3372
3373         [iOS] Remove prefs to tweak cache values
3374         https://bugs.webkit.org/show_bug.cgi?id=135274
3375         <rdar://problem/17784826>
3376
3377         Reviewed by Alexey Proskuryakov.
3378
3379         Remove iOS specific code that used to look up user defaults to see if any cache values were
3380         overridden. This was added for testing, is not used any more and is actually harmful now. It
3381         can cause unnecessary memory churn when under memory pressure since we call [WebView _setCacheModel]
3382         as a means to clear out memory cache.
3383
3384         * WebView/WebPreferenceKeysPrivate.h:
3385         * WebView/WebPreferences.mm:
3386         (+[WebPreferences initialize]):
3387         (-[WebPreferences _setNSURLMemoryCacheSize:]): Deleted.
3388         (-[WebPreferences _NSURLMemoryCacheSize]): Deleted.
3389         (-[WebPreferences _setNSURLDiskCacheSize:]): Deleted.
3390         (-[WebPreferences _NSURLDiskCacheSize]): Deleted.
3391         * WebView/WebPreferencesPrivate.h:
3392         * WebView/WebView.mm:
3393         (+[WebView _setCacheModel:]):
3394
3395 2014-07-24  Peyton Randolph  <prandolph@apple.com>
3396
3397         Rename feature flag for long-press gesture on Mac.                                                                   
3398         https://bugs.webkit.org/show_bug.cgi?id=135259                                                                 
3399
3400         Reviewed by Beth Dakin.
3401
3402         * Configurations/FeatureDefines.xcconfig:
3403         Rename LINK_LONG_PRESS to MAC_LONG_PRESS.
3404
3405 2014-07-24  Dan Bernstein  <mitz@apple.com>
3406
3407         WebKit part of <rdar://problem/17766348> [Cocoa] WebCore::ProtectionSpace doesn’t preserve all NSURLProtectionSpace properties, such as the distinguishedNames array
3408         https://bugs.webkit.org/show_bug.cgi?id=135229
3409
3410         Reviewed by Alexey Proskuryakov.
3411
3412         * Misc/WebDownload.mm:
3413         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): Chanegd to use the
3414         ProtectionSpace constructor that takes an NSURLProtectionSpace.
3415
3416         * Plugins/WebBaseNetscapePluginView.mm:
3417         (WebKit::getAuthenticationInfo): Ditto.
3418
3419         * WebCoreSupport/WebFrameLoaderClient.mm:
3420         (WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace): Changed to use
3421         ProtectionSpace::nsSpace.
3422
3423 2014-07-23  Bem Jones-Bey  <bjonesbe@adobe.com>
3424
3425         Remove CSS_EXCLUSIONS compile flag and leftover code
3426         https://bugs.webkit.org/show_bug.cgi?id=135175
3427
3428         Reviewed by Zoltan Horvath.
3429
3430         At this point, the CSS_EXCLUSIONS flag guards nothing but some useless
3431         stubs. This removes the flag and the useless code.
3432
3433         * Configurations/FeatureDefines.xcconfig:
3434
3435 2014-07-22  Enrica Casucci  <enrica@apple.com>
3436
3437         REGRESSION (WebKit2): Selection inside accelerated overflow:scroll doesn't track scrolling.
3438         https://bugs.webkit.org/show_bug.cgi?id=135180
3439         <rdar://problem/16721055>
3440
3441         Reviewed by Simon Fraser.
3442
3443         * WebCoreSupport/WebEditorClient.h:
3444
3445 2014-07-22  Jeremy Jones  <jeremyj@apple.com>
3446
3447         Don't create new UIWindow for video fullscreen.
3448         https://bugs.webkit.org/show_bug.cgi?id=135038
3449
3450         Reviewed by Darin Adler.
3451
3452         Provide UIView to WebVideoFullscreenController
3453
3454         * WebView/WebView.mm:
3455         (-[WebView _enterFullscreenForNode:]): pass UIView instead of nil
3456
3457 2014-07-21  Pratik Solanki  <psolanki@apple.com>
3458
3459         Unreviewed iOS build fix after r171321.
3460
3461         * WebView/WebView.mm:
3462         (-[WebView _preferencesChanged:]):
3463
3464 2014-07-21  Beth Dakin  <bdakin@apple.com>
3465
3466         WK1 should always setAcceleratedCompositingForFixedPositionEnabled(true) on 
3467         Yosemite
3468         https://bugs.webkit.org/show_bug.cgi?id=135135
3469
3470         Reviewed by Darin Adler.
3471
3472         Get rid of the ChromeClient function, and enable the Setting instead.
3473         * WebCoreSupport/WebChromeClient.h:
3474         * WebCoreSupport/WebChromeClient.mm:
3475         (WebChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition): Deleted.
3476         * WebView/WebView.mm:
3477         (-[WebView _preferencesChanged:]):
3478
3479 2014-07-21  Beth Dakin  <bdakin@apple.com>
3480
3481         Build fix.
3482
3483         * WebCoreSupport/WebChromeClient.mm:
3484         (WebChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition):
3485
3486 2014-07-21  Beth Dakin  <bdakin@apple.com>
3487
3488         Put position:fixed elements into layers when a WK1 view is layer-backed
3489         https://bugs.webkit.org/show_bug.cgi?id=135075
3490
3491         Reviewed by Darin Adler.
3492
3493         Returns true when the WebHTMLView has a layer.
3494
3495         * WebCoreSupport/WebChromeClient.h:
3496         * WebCoreSupport/WebChromeClient.mm:
3497         (WebChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition):
3498
3499 2014-07-18  Andy Estes  <aestes@apple.com>
3500
3501         [iOS] Tapping "Allow Website" on a restricted page does not bring up the keypad
3502         https://bugs.webkit.org/show_bug.cgi?id=135072
3503         <rdar://problem/17528188>
3504
3505         Reviewed by David Kilzer.
3506
3507         * WebCoreSupport/WebFrameLoaderClient.h: Override contentFilterDidBlockLoad().
3508         * WebCoreSupport/WebFrameLoaderClient.mm:
3509         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): Reset contentFilterForBlockedLoad to nullptr.
3510         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Check if this is navigation represents an
3511         unblock request and ignore if so.
3512         * WebView/WebFrame.mm:
3513         (-[WebFrame _contentFilterDidHandleNavigationAction:]): Called ContentFilter::handleUnblockRequestAndDispatchIfSuccessful().
3514         If the unblock is successful, reload the main frame.
3515         * WebView/WebFrameInternal.h:
3516
3517 2014-07-17  David Kilzer  <ddkilzer@apple.com>
3518
3519         SECTORDER_FLAGS should be defined in target's xcconfig file, not Base.xcconfig
3520         <http://webkit.org/b/135006>
3521
3522         Reviewed by Darin Adler.
3523
3524         * Configurations/Base.xcconfig: Move SECTORDER_FLAGS to
3525         WebKitLegacy.xcconfig.
3526         * Configurations/DebugRelease.xcconfig: Remove empty
3527         SECTORDER_FLAGS definition.
3528         * Configurations/WebKit.xcconfig: Removed.  Unused.
3529         * Configurations/WebKitLegacy.xcconfig: Use $(CONFIGURATION) so
3530         SECTORDER_FLAGS is only set on Production builds.
3531
3532 2014-07-17  Timothy Hatcher  <timothy@apple.com>
3533
3534         Make console.profile record to the Timeline.
3535
3536         https://bugs.webkit.org/show_bug.cgi?id=134643
3537
3538         Reviewed by Joseph Pecoraro.
3539
3540         * WebInspector/WebInspector.mm:
3541         (-[WebInspector isProfilingJavaScript]):
3542         (-[WebInspector toggleProfilingJavaScript:]):
3543         (-[WebInspector startProfilingJavaScript:]):
3544         (-[WebInspector stopProfilingJavaScript:]):
3545         (-[WebInspector isJavaScriptProfilingEnabled]):
3546         (-[WebInspector setJavaScriptProfilingEnabled:]):
3547
3548 2014-07-16  David Kilzer  <ddkilzer@apple.com>
3549
3550         [iOS] Update order file paths for WebKit and WebKit2
3551         <http://webkit.org/b/134993>
3552         <rdar://problem/17557776>
3553
3554         Reviewed by Darin Adler.
3555
3556         * Configurations/Base.xcconfig: Rename WebKit.order to
3557         WebKitLegacy.order.
3558
3559 2014-07-16  Brady Eidson  <beidson@apple.com>
3560
3561         Add WebSecurityOrigin "webSecurityOriginFromDatabaseIdentifier" SPI and change _websiteDataURLForContainerWithURL: SPI
3562         <rdar://problem/17454712> and https://bugs.webkit.org/show_bug.cgi?id=134984
3563
3564         Reviewed by Dan Bernstein.