Install a TextIndicator for link immediate actions
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2014-12-23  Timothy Horton  <timothy_horton@apple.com>
2
3         Install a TextIndicator for link immediate actions
4         https://bugs.webkit.org/show_bug.cgi?id=139897
5         <rdar://problem/19333076>
6
7         Reviewed by Anders Carlsson.
8
9         * WebView/WebImmediateActionController.h:
10         * WebView/WebImmediateActionController.mm:
11         (-[WebImmediateActionController _clearImmediateActionState]):
12         Tear down the TextIndicator, just like WebKit2.
13
14         (-[WebImmediateActionController _defaultAnimationController]):
15         Install a TextIndicator for links.
16
17         (-[WebImmediateActionController menuItemDidClose:]):
18         Tear down the TextIndicator when the QL preview closes.
19
20         (-[WebImmediateActionController _menuItemForDataDetectedText]):
21         Directly install and uninstall the TextIndicator for DataDetectors.
22
23         (-[WebImmediateActionController _showTextIndicator]): Deleted.
24         (-[WebImmediateActionController _hideTextIndicator]): Deleted.
25         Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
26
27 2014-12-20  Eric Carlson  <eric.carlson@apple.com>
28
29         [iOS] add optimized fullscreen API
30         https://bugs.webkit.org/show_bug.cgi?id=139833
31         <rdar://problem/18844486>
32
33         Reviewed by Simon Fraser.
34
35         * Configurations/FeatureDefines.xcconfig:  Add ENABLE_VIDEO_PRESENTATION_MODE.
36
37 2014-12-20  David Kilzer  <ddkilzer@apple.com>
38
39         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
40         <http://webkit.org/b/139463>
41
42         Reviewed by Mark Rowe.
43
44         * Configurations/Base.xcconfig:
45         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
46           on OS X.
47         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
48         * Configurations/DebugRelease.xcconfig:
49         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
50         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
51         * Configurations/Version.xcconfig:
52         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
53         * Configurations/WebKitLegacy.xcconfig:
54         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
55           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
56           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
57           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
58           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
59           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
60           WEBCORE_PRIVATE_HEADERS_DIR_Production and
61           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
62           based on SDK.
63         - Fix PRODUCTION_ROOT to actually be set properly.
64         - Simplify EXPORTED_SYMBOLS_FILE_i386.
65
66         * migrate-headers.sh:
67         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
68         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
69           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
70           WebKitLegacy.xcconfig.
71
72 2014-12-19  Simon Fraser  <simon.fraser@apple.com>
73
74         Fix pink background on CoreAnimation plug-ins in WebKit1
75         https://bugs.webkit.org/show_bug.cgi?id=139845
76         rdar://problem/19313075
77
78         Reviewed by Tim Horton.
79         
80         r154078 left in some debugging code that set a pink background on plug-in hosting
81         layers. Remove it.
82
83         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
84         (-[WebHostedNetscapePluginView createPluginLayer]):
85
86 2014-12-19  Andreas Kling  <akling@apple.com>
87
88         Ref-ify TextIterator API.
89         <https://webkit.org/b/139823>
90
91         Reviewed by Antti Koivisto.
92
93         * WebView/WebTextIterator.mm:
94         (-[WebTextIterator currentRange]):
95
96 2014-12-19  Joseph Pecoraro  <pecoraro@apple.com>
97
98         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
99         https://bugs.webkit.org/show_bug.cgi?id=139797
100
101         Reviewed by Mark Lam.
102
103         * WebView/WebScriptDebugger.h:
104         * WebView/WebScriptDebugger.mm:
105         (WebScriptDebugger::handlePause):
106         Standardize on passing JSGlobalObject parameter first.
107
108 2014-12-19  Commit Queue  <commit-queue@webkit.org>
109
110         Unreviewed, rolling out r177574.
111         https://bugs.webkit.org/show_bug.cgi?id=139821
112
113         "Broke Production builds by installing
114         libWebCoreTestSupport.dylib in the wrong directory" (Requested
115         by ddkilzer on #webkit).
116
117         Reverted changeset:
118
119         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
120         WebInspectorUI, WebKit, WebKit2"
121         https://bugs.webkit.org/show_bug.cgi?id=139463
122         http://trac.webkit.org/changeset/177574
123
124 2014-12-19  David Kilzer  <ddkilzer@apple.com>
125
126         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
127         <http://webkit.org/b/139463>
128
129         Reviewed by Mark Rowe.
130
131         * Configurations/Base.xcconfig:
132         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
133           on OS X.
134         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
135         * Configurations/DebugRelease.xcconfig:
136         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
137         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
138         * Configurations/Version.xcconfig:
139         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
140         * Configurations/WebKitLegacy.xcconfig:
141         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
142           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
143           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
144           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
145           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
146           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
147           WEBCORE_PRIVATE_HEADERS_DIR_Production and
148           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
149           based on SDK.
150         - Fix PRODUCTION_ROOT to actually be set properly.
151         - Simplify EXPORTED_SYMBOLS_FILE_i386.
152
153         * migrate-headers.sh:
154         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
155         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
156           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
157           WebKitLegacy.xcconfig.
158
159 2014-12-18  Andreas Kling  <akling@apple.com>
160
161         Ref-ify various Document-related things.
162         <https://webkit.org/b/139796>
163
164         Reviewed by Anders Carlsson.
165
166         * WebView/WebFrame.mm:
167         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
168
169 2014-12-18  Beth Dakin  <bdakin@apple.com>
170
171         Need to re-enable action menus
172         https://bugs.webkit.org/show_bug.cgi?id=139795
173         -and corresponding-
174         rdar://problem/19299367
175
176         Reviewed by Tim Horton.
177
178         Re-enable the menus by un-commenting the code to create the menu and controller.
179         * WebView/WebView.mm:
180         (-[WebView _commonInitializationWithFrameName:groupName:]):
181
182 2014-12-16  Sam Weinig  <sam@webkit.org>
183
184         Unify the Mac and iOS implementations of FontPlatformData a bit
185         https://bugs.webkit.org/show_bug.cgi?id=139721
186
187         Reviewed by Anders Carlsson.
188
189         * WebView/WebHTMLView.mm:
190         (fontNameForDescription):
191         Update for new function name.
192
193 2014-12-18  Antti Koivisto  <antti@apple.com>
194
195         Remove alwaysUseBaselineOfPrimaryFont setting
196         https://bugs.webkit.org/show_bug.cgi?id=139770
197
198         Reviewed by Anders Carlsson.
199
200         * WebView/WebPreferenceKeysPrivate.h:
201         * WebView/WebPreferences.mm:
202         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
203         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
204         * WebView/WebPreferencesPrivate.h:
205         * WebView/WebView.mm:
206         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
207         (-[WebView _preferencesChanged:]):
208
209 2014-12-17  Andreas Kling  <akling@apple.com>
210
211         Ref-ify Range::create().
212         <https://webkit.org/b/139755>
213
214         Reviewed by Anders Carlsson.
215
216         * WebView/WebHTMLRepresentation.mm:
217         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
218         * WebView/WebHTMLView.mm:
219         (-[WebHTMLView attributedString]):
220
221 2014-12-17  Anders Carlsson  <andersca@apple.com>
222
223         Unify -[WebResource description]
224         https://bugs.webkit.org/show_bug.cgi?id=139762
225
226         Reviewed by Dan Bernstein.
227
228         * WebView/WebResource.mm:
229         (-[WebResource description]):
230
231 2014-12-17  Anders Carlsson  <andersca@apple.com>
232
233         Get rid of an ugly #define hack in WebFrameLoaderClient
234         https://bugs.webkit.org/show_bug.cgi?id=139761
235
236         Reviewed by Dan Bernstein.
237
238         Also replace @private with @package in all public headers, for consistency.
239
240         * History/WebBackForwardList.h:
241         * History/WebHistory.h:
242         * Misc/WebDownload.h:
243         * WebCoreSupport/WebFrameLoaderClient.mm:
244         * WebView/WebArchive.h:
245         * WebView/WebDataSource.h:
246         * WebView/WebFrame.h:
247         * WebView/WebFrameView.h:
248         * WebView/WebPreferences.h:
249         * WebView/WebResource.h:
250
251 2014-12-17  Dan Bernstein  <mitz@apple.com>
252
253         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
254         https://bugs.webkit.org/show_bug.cgi?id=139760
255
256         Reviewed by Anders Carlsson.
257
258         * Configurations/WebKitLegacy.xcconfig:
259
260 2014-12-17  Andreas Kling  <akling@apple.com>
261
262         Purge PassRefPtr from Frame.
263         <https://webkit.org/b/139731>
264
265         Reviewed by Anders Carlsson.
266
267         * WebCoreSupport/WebFrameLoaderClient.mm:
268         (WebFrameLoaderClient::transitionToCommittedForNewPage):
269         * WebView/WebFrame.mm:
270         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
271         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
272         * WebView/WebFrameInternal.h:
273
274 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
275
276         Implement and adopt two new TextIndicator presentation animations
277         https://bugs.webkit.org/show_bug.cgi?id=139715
278         <rdar://problem/19237945>
279
280         Reviewed by Anders Carlsson.
281
282         * WebView/WebActionMenuController.mm:
283         (-[WebActionMenuController _showTextIndicator]):
284         * WebView/WebHTMLView.mm:
285         (-[WebHTMLView quickLookWithEvent:]):
286         Remove the completionHandler from text indicator presentation.
287
288         * WebView/WebImmediateActionController.mm:
289         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
290         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
291         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
292         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
293         (-[WebImmediateActionController _menuItemForDataDetectedText]):
294         (-[WebImmediateActionController _animationControllerForText]):
295         (-[WebImmediateActionController _showTextIndicator]):
296         Forward immediate action gesture recognizer animation progress
297         to TextIndicator. Force us to keep the selection when immediate
298         action popovers steal first responder status from the WebView.
299         If the Lookup range is equal to the selection range, use a Crossfade
300         animation; otherwise, use a FadeIn animation.
301
302         * WebView/WebView.mm:
303         (-[WebView _setMaintainsInactiveSelection:]):
304         (-[WebView maintainsInactiveSelection]):
305         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
306         (-[WebView _setTextIndicator:fadeOut:]):
307         (-[WebView _clearTextIndicator]):
308         (-[WebView _setTextIndicatorAnimationProgress:]):
309         (-[WebView _showDictionaryLookupPopup:]):
310         (-[WebView _dictionaryLookupPopoverWillClose:]):
311         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
312         Remove the completionHandler from text indicator presentation.
313         Add a _setMaintainsInactiveSelection, which allows WebKit internals
314         to change the return value of -maintainsInactiveSelection, allowing
315         us to keep the selection alive when the WebView loses first responder status.
316
317         * WebView/WebViewData.h:
318         * WebView/WebViewInternal.h:
319
320 2014-12-16  Andreas Kling  <akling@apple.com>
321
322         Use Ref for SecurityOrigin.
323         <https://webkit.org/b/139710>
324
325         Reviewed by Anders Carlsson.
326
327         * Storage/WebStorageTrackerClient.mm:
328         (WebStorageTrackerClient::dispatchDidModifyOrigin):
329         * WebView/WebView.mm:
330         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
331         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
332
333 2014-12-16  Beth Dakin  <bdakin@apple.com>
334
335         Crash getting default animation controller for some text
336         https://bugs.webkit.org/show_bug.cgi?id=139712
337         -and corresponding-
338         rdar://problem/19271707
339
340         Reviewed by Tim Horton.
341
342         Must null-check the range.
343         * WebView/WebImmediateActionController.mm:
344         (-[WebImmediateActionController _animationControllerForText]):
345
346 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
347
348         Immediate action popovers can get stuck open
349         https://bugs.webkit.org/show_bug.cgi?id=139709
350         <rdar://problem/19270279>
351
352         Reviewed by Beth Dakin.
353
354         * WebView/WebImmediateActionController.mm:
355         (-[WebImmediateActionController _clearImmediateActionState]):
356         Don't clear the animation controller; it breaks things and was unnecessary.
357
358 2014-12-16  Tim Horton  <timothy_horton@apple.com>
359
360         Disable TextIndication for Lookup immediate actions
361         https://bugs.webkit.org/show_bug.cgi?id=139684
362
363         Reviewed by Anders Carlsson.
364
365         * WebView/WebView.mm:
366         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
367
368 2014-12-15  Beth Dakin  <bdakin@apple.com>
369
370         Build fix.
371
372         * WebView/WebImmediateActionController.mm:
373
374 2014-12-15  Beth Dakin  <bdakin@apple.com>
375
376         Speculative build fix.
377
378         * WebView/WebView.mm:
379         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
380         * WebView/WebViewInternal.h:
381
382 2014-12-15  Beth Dakin  <bdakin@apple.com>
383
384         Make lookup an immediate action instead of an action menu item
385         https://bugs.webkit.org/show_bug.cgi?id=139661
386         -and corresponding-
387         rdar://problem/19198414
388
389         Reviewed by Tim Horton.
390
391         Remove the lookup menu items and non-unused static function associated with 
392         lookup.
393         * WebView/WebActionMenuController.mm:
394         (-[WebActionMenuController _defaultMenuItemsForText]):
395         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
396         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
397         (-[WebActionMenuController _createActionMenuItemForTag:]):
398         (-[WebActionMenuController _lookupText:]): Deleted.
399         (performDictionaryLookupForSelection): Deleted.
400         (performDictionaryLookupForRange): Deleted.
401
402         Set the defaultAnimationController to the lookup-provided animation controller 
403         when appropriate.
404         * WebView/WebImmediateActionController.mm:
405         (-[WebImmediateActionController _defaultAnimationController]):
406         (dictionaryPopupInfoForRange):
407         (-[WebImmediateActionController _animationControllerForText]):
408
409         New type.
410         * WebView/WebUIDelegatePrivate.h:
411
412         New function to get the lookup animation controller.
413         * WebView/WebView.mm:
414         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
415         * WebView/WebViewInternal.h:
416
417 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
418
419         Implement Data Detectors immediate actions for Legacy WebKit
420         https://bugs.webkit.org/show_bug.cgi?id=139619
421         <rdar://problem/19198539>
422
423         Reviewed by Beth Dakin.
424
425         * WebView/WebImmediateActionController.mm:
426         (-[WebImmediateActionController _menuItemForDataDetectedText]):
427         Note that this action context is only for immediate actions.
428
429 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
430
431         Addressing post-review comments in r177035
432         https://bugs.webkit.org/show_bug.cgi?id=139557
433
434         Reviewed by Darin Adler.
435
436         * WebView/WebActionMenuController.mm:
437         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
438
439 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
440
441         Implement Data Detectors immediate actions for Legacy WebKit
442         https://bugs.webkit.org/show_bug.cgi?id=139619
443         <rdar://problem/19198539>
444
445         Reviewed by Eric Carlson.
446
447         * WebView/WebHTMLView.mm:
448         (-[WebHTMLView mouseDown:mouseDown:]):
449         Send mouseDown along to the WebImmediateActionController too.
450
451         * WebView/WebImmediateActionController.h:
452         * WebView/WebImmediateActionController.mm:
453         (-[WebImmediateActionController webViewClosed]):
454         (-[WebImmediateActionController webView:willHandleMouseDown:]):
455         (-[WebImmediateActionController _cancelImmediateAction]):
456         (-[WebImmediateActionController _clearImmediateActionState]):
457         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
458         (-[WebImmediateActionController _defaultAnimationController]):
459         (-[WebImmediateActionController _updateImmediateActionItem]):
460         (-[WebImmediateActionController _menuItemForDataDetectedText]):
461         (-[WebImmediateActionController _showTextIndicator]):
462         (-[WebImmediateActionController _hideTextIndicator]):
463         Copy most of the DataDetectors implementation into WebImmediateActionController.
464
465         * WebView/WebUIDelegatePrivate.h:
466         Add a new type.
467
468         * WebView/WebView.mm:
469         (-[WebView _commonInitializationWithFrameName:groupName:]):
470         Temporarily disable action menus.
471
472         (-[WebView _immediateActionController]):
473         * WebView/WebViewInternal.h:
474
475 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
476
477         Delete Notation because we don't use it
478         https://bugs.webkit.org/show_bug.cgi?id=139171
479
480         Reviewed by Kent Tamura.
481
482         * MigrateHeaders.make:
483
484 2014-12-14  Andreas Kling  <akling@apple.com>
485
486         Replace PassRef with Ref/Ref&& across the board.
487         <https://webkit.org/b/139587>
488
489         Reviewed by Darin Adler.
490
491         * WebCoreSupport/WebEditorClient.mm:
492         (WebEditorClient::shouldApplyStyle):
493         * WebCoreSupport/WebVisitedLinkStore.h:
494         * WebCoreSupport/WebVisitedLinkStore.mm:
495         (WebVisitedLinkStore::create):
496
497 2014-12-11  Dan Bernstein  <mitz@apple.com>
498
499         Fix a leak introduced in r177199.
500
501         Reviewed by Anders Carlsson.
502
503         * WebView/WebImmediateActionController.mm:
504         (-[WebImmediateActionController _updateImmediateActionItem]):
505
506 2014-12-11  Beth Dakin  <bdakin@apple.com>
507
508         WK1: Need new SPI for Webkit clients to override default immediate action
509         https://bugs.webkit.org/show_bug.cgi?id=139568
510         -and corresponding-
511         rdar://problem/19225448
512
513         Reviewed by Dan Bernstein.
514
515         Call SPI giving clients a chance to override the default behavior.
516         * WebView/WebImmediateActionController.mm:
517         (-[WebImmediateActionController _updateImmediateActionItem]):
518
519         New SPI.
520         * WebView/WebUIDelegatePrivate.h:
521
522 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
523
524         Move the preview popover to WebImmediateActionController
525         https://bugs.webkit.org/show_bug.cgi?id=139563
526         <rdar://problem/19208291>
527
528         Reviewed by Beth Dakin.
529
530         * WebView/WebActionMenuController.mm:
531         (-[WebActionMenuController _defaultMenuItemsForLink]):
532         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
533         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
534         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
535         * WebView/WebImmediateActionController.h:
536         * WebView/WebImmediateActionController.mm:
537         (-[WebImmediateActionController webViewClosed]):
538         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
539         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
540         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
541         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
542         (-[WebImmediateActionController _updateImmediateActionItem]):
543         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
544         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
545         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
546         Move page preview popover related code to WebImmediateActionController.
547
548         * WebView/WebUIDelegatePrivate.h:
549         Add a link preview type.
550
551         * WebView/WebView.mm:
552         (-[WebView _commonInitializationWithFrameName:groupName:]):
553         Pass the gesture recognizer to the WebImmediateActionController.
554
555 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
556
557         Fix the build.
558
559         * WebView/WebImmediateActionController.h:
560         * WebView/WebImmediateActionController.mm:
561
562 2014-12-11  Anders Carlsson  <andersca@apple.com>
563
564         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
565         https://bugs.webkit.org/show_bug.cgi?id=139547
566
567         Reviewed by Sam Weinig.
568
569         * WebView/WebView.mm:
570         (+[WebView _handleMemoryWarning]):
571
572 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
573
574         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
575         https://bugs.webkit.org/show_bug.cgi?id=139504
576         rdar://problem/19034674
577
578         Reviewed by Enrica Casucci.
579
580         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
581
582         * WebCoreSupport/WebEditorClient.h:
583         * WebCoreSupport/WebEditorClient.mm:
584         (WebEditorClient::discardedComposition):
585
586 2014-12-10  Anders Carlsson  <andersca@apple.com>
587
588         Get rid of the storage strategy
589         https://bugs.webkit.org/show_bug.cgi?id=139519
590
591         Reviewed by Antti Koivisto.
592
593         * WebCoreSupport/WebPlatformStrategies.h:
594         * WebCoreSupport/WebPlatformStrategies.mm:
595         (WebPlatformStrategies::createStorageStrategy): Deleted.
596
597 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
598
599         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
600         https://bugs.webkit.org/show_bug.cgi?id=139529
601         <rdar://problem/19213620>
602
603         Reviewed by Beth Dakin.
604
605         * WebView/WebActionMenuController.mm:
606         (-[WebActionMenuController _copySelection:]):
607         (-[WebActionMenuController _paste:]):
608         Use the copy: and paste: methods on WebView so that we traverse subviews
609         when trying to respond, otherwise these actions don't work in subframes.
610
611 2014-12-10  Beth Dakin  <bdakin@apple.com>
612
613         WK1: Add initial support for immediate actions
614         https://bugs.webkit.org/show_bug.cgi?id=139522
615
616         Reviewed by Dan Bernstein.
617
618         This basic implementation of the controller will use the delegate methods to 
619         perform and cache a HitTest when relevant. Future patches will patch 
620         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
621         immediate action that should be taken.
622         * WebView/WebImmediateActionController.h: Added.
623         * WebView/WebImmediateActionController.mm: Added.
624         (-[WebImmediateActionController webViewClosed]):
625         (-[WebImmediateActionController _clearImmediateActionState]):
626         (-[WebImmediateActionController performHitTestAtPoint:]):
627         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
628         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
629         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
630         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
631         (-[WebImmediateActionController _updateImmediateActionItem]):
632
633         New enum for immediate action types.
634         * WebView/WebUIDelegatePrivate.h:
635
636         Create an NSImmediateActionGestureRecognizer if possible and a controller.
637         * WebView/WebView.mm:
638         (-[WebView _commonInitializationWithFrameName:groupName:]):
639         (-[WebView _close]):
640         * WebView/WebViewData.h:
641         * WebView/WebViewData.mm:
642         (-[WebViewPrivate dealloc]):
643
644 2014-12-08  Anders Carlsson  <andersca@apple.com>
645
646         Use the new storage namespace provider in WebKit1
647         https://bugs.webkit.org/show_bug.cgi?id=139425
648
649         Reviewed by Tim Horton.
650
651         * WebView/WebView.mm:
652         (-[WebView _commonInitializationWithFrameName:groupName:]):
653         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
654         Set the storage namespace provider from the web page group.
655
656 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
657
658         Should have copy and paste items in all text menus
659         https://bugs.webkit.org/show_bug.cgi?id=139510
660         <rdar://problem/19198388>
661
662         Reviewed by Beth Dakin.
663
664         * WebView/WebActionMenuController.mm:
665         (-[WebActionMenuController _defaultMenuItemsForText]):
666         Add a disabled paste menu item into the read-only text menu.
667
668         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
669         Add a disabled copy menu item into the editable whitespace text menu.
670
671 2014-12-10  Anders Carlsson  <andersca@apple.com>
672
673         Add WebStorageNamespaceProvider::closeLocalStorage
674         https://bugs.webkit.org/show_bug.cgi?id=139502
675
676         Reviewed by Tim Horton.
677
678         * WebView/WebView.mm:
679         (+[WebView _applicationWillTerminate]):
680         Call WebStorageNamespaceProvider::closeLocalStorage.
681
682 2014-12-09  Commit Queue  <commit-queue@webkit.org>
683
684         Unreviewed, rolling out r177037.
685         https://bugs.webkit.org/show_bug.cgi?id=139464
686
687         broke ~50 API tests (Requested by thorton on #webkit).
688
689         Reverted changeset:
690
691         "Use the new storage namespace provider in WebKit1"
692         https://bugs.webkit.org/show_bug.cgi?id=139425
693         http://trac.webkit.org/changeset/177037
694
695 2014-12-08  Anders Carlsson  <andersca@apple.com>
696
697         Use the new storage namespace provider in WebKit1
698         https://bugs.webkit.org/show_bug.cgi?id=139425
699
700         Reviewed by Tim Horton.
701
702         * WebView/WebView.mm:
703         (-[WebView _commonInitializationWithFrameName:groupName:]):
704         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
705         Set the storage namespace provider from the web page group.
706
707 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
708
709         Delete Node::boundingBox()
710         https://bugs.webkit.org/show_bug.cgi?id=139333
711
712         Reviewed by Zalan Bujtas.
713
714         * WebView/WebActionMenuController.mm:
715         (elementBoundingBoxInWindowCoordinatesFromNode): Use
716         RenderObject::absoluteBoundingBoxRect().
717
718 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
719
720         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
721         https://bugs.webkit.org/show_bug.cgi?id=138843
722         rdar://problem/18793695
723
724         Reviewed by Dan Bernstein.
725
726         * Panels/WebAuthenticationPanel.m:
727         (-[WebAuthenticationPanel cancel:]):
728         (-[WebAuthenticationPanel logIn:]):
729         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
730         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
731         that only when using an old NSWindow API.
732
733 2014-12-08  Beth Dakin  <bdakin@apple.com>
734
735         Copy and Lookup menu items should be disabled when something is not copyable
736         https://bugs.webkit.org/show_bug.cgi?id=139423
737
738         Reviewed by Tim Horton.
739
740         Disable both lookup and copy when a HitTestResult does not allow copy.
741         * WebView/WebActionMenuController.mm:
742
743         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
744         disable state otherwise.
745         * WebView/WebView.mm:
746         (-[WebView _commonInitializationWithFrameName:groupName:]):
747
748 2014-12-08  Anders Carlsson  <andersca@apple.com>
749
750         Adding user content to a group should force that group to be created
751         https://bugs.webkit.org/show_bug.cgi?id=139421
752         rdar://problem/19180108
753
754         Reviewed by Sam Weinig.
755
756         * WebCoreSupport/WebViewGroup.h:
757         Store the local storage database path in the group.
758
759         * WebCoreSupport/WebViewGroup.mm:
760         (WebViewGroup::getOrCreate):
761         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
762         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
763
764         (WebViewGroup::WebViewGroup):
765         Initialize the new member variable.
766
767         (WebViewGroup::storageNamespaceProvider):
768         Create the namespace provider lazily.
769
770         * WebView/WebView.mm:
771         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
772         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
773         Use getOrCreate instead of get.
774
775 2014-12-08  Anders Carlsson  <andersca@apple.com>
776
777         WebStorageNamespaceProvider should know about its local storage database path
778         https://bugs.webkit.org/show_bug.cgi?id=139413
779
780         Reviewed by Andreas Kling.
781
782         * WebCoreSupport/WebViewGroup.h:
783         * WebCoreSupport/WebViewGroup.mm:
784         (WebViewGroup::getOrCreate):
785         (WebViewGroup::WebViewGroup):
786         * WebView/WebView.mm:
787         (-[WebView _commonInitializationWithFrameName:groupName:]):
788         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
789         (-[WebView setGroupName:]):
790         (-[WebView groupName]): Deleted.
791
792 2014-12-08  Daniel Bates  <dabates@apple.com>
793
794         [iOS] Fix the WebKit build with the public SDK
795
796         Include header NSURLDownloadSPI.h.
797
798         * WebCoreSupport/WebFrameLoaderClient.mm:
799
800 2014-12-07  Dan Bernstein  <mitz@apple.com>
801
802         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
803         https://bugs.webkit.org/show_bug.cgi?id=139348
804
805         Reviewed by Anders Carlsson.
806
807         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
808         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
809         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
810         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
811         avoiding the ambiguity.
812
813         * WebView/WebActionMenuController.mm:
814         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
815
816 2014-12-06  Anders Carlsson  <andersca@apple.com>
817
818         Add a stubbed out version of WebStorageNamespaceProvider
819         https://bugs.webkit.org/show_bug.cgi?id=139213
820
821         Reviewed by Sam Weinig.
822
823         * WebCoreSupport/WebViewGroup.h:
824         (WebViewGroup::storageNamespaceProvider):
825         * WebCoreSupport/WebViewGroup.mm:
826         (WebViewGroup::getOrCreate):
827         (WebViewGroup::WebViewGroup):
828         Give WebViewGroup a storage namespace provider.
829
830 2014-12-06  Anders Carlsson  <andersca@apple.com>
831
832         Fix build with newer versions of clang.
833         rdar://problem/18978687
834
835         Add missing overrides and missing casts.
836
837         * Storage/WebDatabaseManagerClient.h:
838         * Storage/WebStorageTrackerClient.h:
839         * WebCoreSupport/WebChromeClient.h:
840         * WebCoreSupport/WebFrameLoaderClient.h:
841         * WebCoreSupport/WebInspectorClient.h:
842         * WebView/WebDataSource.mm:
843         (-[WebDataSource _makeRepresentation]):
844         * WebView/WebFrameView.mm:
845         (-[WebFrameView _makeDocumentViewForDataSource:]):
846
847 2014-12-05  Tim Horton  <timothy_horton@apple.com>
848
849         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
850         https://bugs.webkit.org/show_bug.cgi?id=139306
851         <rdar://problem/19157955>
852
853         Reviewed by Beth Dakin.
854
855         * WebView/WebView.mm:
856         (-[WebView _commonInitializationWithFrameName:groupName:]):
857         (-[WebView _initWithFrame:frameName:groupName:]):
858         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
859
860 2014-12-05  David Kilzer  <ddkilzer@apple.com>
861
862         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
863         <http://webkit.org/b/139286>
864
865         Reviewed by Daniel Bates.
866
867         * Configurations/FeatureDefines.xcconfig: Switch back to using
868         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
869
870 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
871
872         Fix the 32-bit build.
873
874         * WebView/WebView.mm:
875         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
876
877 2014-12-04  Tim Horton  <timothy_horton@apple.com>
878
879         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
880         https://bugs.webkit.org/show_bug.cgi?id=139252
881         <rdar://problem/19140827>
882
883         Reviewed by Anders Carlsson.
884
885         * WebView/WebView.mm:
886         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
887         Adjust to the WebCore changes.
888
889 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
890
891         Implement action menus for tel: URLs
892         https://bugs.webkit.org/show_bug.cgi?id=139240
893         <rdar://problem/19115662>
894
895         Reviewed by Anders Carlsson.
896
897         * WebView/WebActionMenuController.mm:
898         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
899         Make sure to use the newly created currentActionContext... everywhere.
900
901 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
902
903         Implement action menus for tel: URLs
904         https://bugs.webkit.org/show_bug.cgi?id=139240
905         <rdar://problem/19115662>
906
907         Reviewed by Anders Carlsson.
908
909         * WebView/WebActionMenuController.mm:
910         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
911         Make sure to use the newly created currentActionContext.
912
913 2014-12-03  Beth Dakin  <bdakin@apple.com>
914
915         <input> elements get whitespace action menu instead of editable text menu
916         https://bugs.webkit.org/show_bug.cgi?id=139241
917         -and corresponding-
918         rdar://problem/19072083
919
920         Reviewed by Sam Weinig.
921
922         We should disallow shadow content in the hit test. This is the default and it is 
923         how context menus behave. We originally wanted to text inside shadow content so 
924         that we could find the text, but the new function I added to HitTestResult will 
925         allow that.
926         * WebView/WebActionMenuController.mm:
927         (-[WebActionMenuController performHitTestAtPoint:]):
928
929         Adjust to the fact that we don’t hit test shadow content any more.
930         (-[WebActionMenuController focusAndSelectHitTestResult]):
931
932         Offer the text menus for text inside form controls.
933         (-[WebActionMenuController _defaultMenuItems]):
934
935 2014-12-03  Tim Horton  <timothy_horton@apple.com>
936
937         Implement action menus for tel: URLs
938         https://bugs.webkit.org/show_bug.cgi?id=139240
939         <rdar://problem/19115662>
940
941         Reviewed by Anders Carlsson.
942
943         * WebView/WebActionMenuController.mm:
944         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
945         Rename this function as it will work for both mailto and tel URLs.
946         Adjust it to use contextForView:.
947
948         (-[WebActionMenuController webView:willHandleMouseDown:]):
949         (-[WebActionMenuController prepareForMenu:withEvent:]):
950         (-[WebActionMenuController didCloseMenu:withEvent:]):
951         (-[WebActionMenuController _defaultMenuItems]):
952         Don't check the menu type when going to interact with _currentActionContext.
953         We'll only have a _currentActionContext if we have a data detected item,
954         and there are multiple menu types that end up using DDActionContext.
955
956         * WebView/WebUIDelegatePrivate.h:
957         Add a new type.
958
959 2014-12-03  Anders Carlsson  <andersca@apple.com>
960
961         Set a visited link store when creating a simple WebView
962         https://bugs.webkit.org/show_bug.cgi?id=139234
963         <rdar://problem/19132978>
964
965         Reviewed by Sam Weinig.
966
967         * WebView/WebView.mm:
968         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
969
970 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
971
972         Fix the build.
973
974         * WebCoreSupport/WebFrameLoaderClient.mm:
975
976 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
977
978         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
979         https://bugs.webkit.org/show_bug.cgi?id=139149
980
981         Reviewed by Anders Carlsson.
982
983         This changes API behavior. I think that it's OK, because existing behavior made no sense.
984         We used to delete caches from disk, but they were still active in memory. Now we also
985         obsolete them in memory, so documents that use a cache still work, but new ones don't
986         pick one up.
987
988         * WebCoreSupport/WebApplicationCache.mm:
989         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
990         need to delete in-momry caches too. Keep existing behavior.
991         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
992         that properly deletes caches.
993
994 2014-12-02  Tim Horton  <timothy_horton@apple.com>
995
996         Remove a SnowLeopard-era quirk for QuickLook
997         https://bugs.webkit.org/show_bug.cgi?id=139208
998         <rdar://problem/19121822>
999
1000         Reviewed by Alexey Proskuryakov.
1001
1002         * WebCoreSupport/WebFrameLoaderClient.h:
1003         * WebCoreSupport/WebFrameLoaderClient.mm:
1004
1005 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1006
1007         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
1008         https://bugs.webkit.org/show_bug.cgi?id=139204
1009
1010         Reviewed by Anders Carlsson.
1011
1012         * WebView/WebView.mm:
1013         (-[WebView _commonInitializationWithFrameName:groupName:]):
1014         (-[WebView _showDictionaryLookupPopup:]):
1015         * WebView/WebViewData.h:
1016         Work around this by delaying the softlinking (and setting up the notification
1017         observer) until we actually need it. There's still an underlying bug, but
1018         this will fix the test.
1019
1020 2014-12-02  Beth Dakin  <bdakin@apple.com>
1021
1022         Yet another build fix.
1023
1024         * WebView/WebActionMenuController.mm:
1025         (-[WebActionMenuController _defaultMenuItemsForLink]):
1026
1027 2014-12-02  Beth Dakin  <bdakin@apple.com>
1028
1029         Build fix.
1030
1031         * WebView/WebActionMenuController.mm:
1032         (-[WebActionMenuController _defaultMenuItemsForLink]):
1033
1034 2014-12-02  Beth Dakin  <bdakin@apple.com>
1035
1036         More build fixing.
1037
1038         * WebView/WebActionMenuController.mm:
1039         (-[WebActionMenuController _defaultMenuItemsForLink]):
1040
1041 2014-12-02  Beth Dakin  <bdakin@apple.com>
1042
1043         Should use standardQuickLookMenuItem for apps that don't implement customizations
1044         https://bugs.webkit.org/show_bug.cgi?id=139193
1045         -and corresponding-
1046         rdar://problem/18944696
1047
1048         Reviewed by Anders Carlsson.
1049
1050         Use [NSMenuItem standardQuickLookMenuItem].
1051         * WebView/WebActionMenuController.mm:
1052         (-[WebActionMenuController _defaultMenuItemsForLink]):
1053
1054         Delegate methods to set up the standardQuickLookMenuItem.
1055         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
1056         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
1057         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
1058
1059         Remove all of the old QLPreviewBubble code.
1060         (-[WebActionMenuController _createActionMenuItemForTag:]):
1061         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
1062
1063 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
1064
1065         Fix the build.
1066
1067         * WebView/WebViewData.h:
1068
1069 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1070
1071         Implement Lookup transition from selection for Legacy WebKit
1072         https://bugs.webkit.org/show_bug.cgi?id=139180
1073         <rdar://problem/19067172>
1074
1075         Reviewed by Beth Dakin.
1076
1077         * WebView/DictionaryPopupInfo.h: Added.
1078         Split DictionaryPopupInfo out into its own file.
1079
1080         * WebView/WebActionMenuController.mm:
1081         (-[WebActionMenuController _lookupText:]):
1082         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
1083
1084         (performDictionaryLookupForSelection):
1085         (performDictionaryLookupForRange):
1086         Plumb the transition style through these helpers.
1087         Create a TextIndicator from the selection range.
1088
1089         * WebView/WebHTMLView.mm:
1090         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
1091         Make use of TextIndicator (and DictionaryPopupInfo, and the new
1092         _showDictionaryLookupPopup on WebView) to add a transition from blue
1093         when performing Lookup from the context menu.
1094
1095         (-[WebHTMLView quickLookWithEvent:]):
1096         Remove our TextIndicator whenever a normal three-finger-tap event
1097         comes through, as it will have its own indication.
1098
1099         * WebView/WebView.mm:
1100         (-[WebView _commonInitializationWithFrameName:groupName:]):
1101         (-[WebView _dictionaryLookupPopoverWillClose:]):
1102         Register for the LUNotificationPopoverWillClose notification and remove
1103         our TextIndicator when it is called, just like in WebKit2.
1104         Deregistration is already handled in _close.
1105
1106         (-[WebView _showDictionaryLookupPopup:]):
1107         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
1108         if the relevant API is available.
1109
1110         * WebView/WebViewInternal.h:
1111
1112 2014-12-02  Anders Carlsson  <andersca@apple.com>
1113
1114         Remove visited link handling from PageGroup
1115         https://bugs.webkit.org/show_bug.cgi?id=139185
1116
1117         Reviewed by Sam Weinig.
1118
1119         * History/WebHistory.mm:
1120         (-[WebHistoryPrivate removeItemForURLString:]):
1121         (-[WebHistoryPrivate removeAllItems]):
1122         (+[WebHistory setOptionalSharedHistory:]):
1123         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1124         (+[WebHistory _removeAllVisitedLinks]):
1125         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
1126         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
1127         * History/WebHistoryInternal.h:
1128         * WebCoreSupport/WebChromeClient.h:
1129         * WebCoreSupport/WebChromeClient.mm:
1130         (WebChromeClient::populateVisitedLinks): Deleted.
1131         * WebView/WebView.mm:
1132         (-[WebView addVisitedLinks:]):
1133         (-[WebView removeVisitedLink:]):
1134
1135 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1136
1137         Try to fix the Mac build.
1138
1139         * WebView/WebView.mm:
1140         (-[WebView _commonInitializationWithFrameName:groupName:]):
1141         (-[WebView _close]):
1142
1143 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1144
1145         Fix the iOS build.
1146
1147         * WebView/WebActionMenuController.h:
1148         * WebView/WebActionMenuController.mm:
1149         * WebView/WebHTMLView.mm:
1150         (-[WebHTMLView scrollWheel:scrollWheel:]):
1151         (-[WebHTMLView mouseDown:mouseDown:]):
1152         * WebView/WebView.mm:
1153         * WebView/WebViewData.h:
1154         * WebView/WebViewData.mm:
1155         (-[WebViewPrivate dealloc]):
1156         * WebView/WebViewInternal.h:
1157
1158 2014-12-01  Tim Horton  <timothy_horton@apple.com>
1159
1160         Implement yellow highlight for WebKit1 data detectors
1161         https://bugs.webkit.org/show_bug.cgi?id=138956
1162         <rdar://problem/18992185>
1163
1164         Reviewed by Beth Dakin.
1165
1166         * WebView/WebActionMenuController.h:
1167         * WebView/WebActionMenuController.mm:
1168         (-[WebActionMenuController webView:willHandleMouseDown:]):
1169         (-[WebActionMenuController webView:didHandleScrollWheel:]):
1170         (-[WebActionMenuController prepareForMenu:withEvent:]):
1171         (-[WebActionMenuController didCloseMenu:withEvent:]):
1172         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1173         (-[WebActionMenuController _showTextIndicator]):
1174         (-[WebActionMenuController _hideTextIndicator]):
1175         (-[WebActionMenuController _dismissActionMenuPopovers]):
1176         Copy the WebKit2 WKActionMenuController TextIndicator implementation
1177         into WebActionMenuController. The only significant difference is
1178         that we build the TextIndicator right at menu construction time
1179         instead of in the Web process.
1180
1181         * WebView/WebHTMLView.mm:
1182         (-[WebHTMLView scrollWheel:]):
1183         Let the WebActionMenuController know that we're handling a scroll.
1184
1185         (-[WebHTMLView mouseDown:]):
1186         Let the WebActionMenuController know that we're handling a mouseDown.
1187
1188         * WebView/WebView.mm:
1189         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1190         (-[WebView _clearTextIndicator]):
1191         (-[WebView _actionMenuController]):
1192         (-[WebView _convertRectFromRootView:]): Deleted.
1193         * WebView/WebViewData.h:
1194         * WebView/WebViewData.mm:
1195         * WebView/WebViewInternal.h:
1196         Keep a TextIndicatorWindow on WebView, just like WKView does.
1197         Expose the WebActionMenuController on WebView (internally).
1198
1199 2014-12-01  Anders Carlsson  <andersca@apple.com>
1200
1201         Remove old site specific quirks code that was added in 2009
1202         https://bugs.webkit.org/show_bug.cgi?id=139141
1203
1204         Reviewed by Antti Koivisto.
1205
1206         * WebCoreSupport/WebFrameNetworkingContext.h:
1207         * WebCoreSupport/WebFrameNetworkingContext.mm:
1208         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
1209
1210 2014-11-30  Anders Carlsson  <andersca@apple.com>
1211
1212         Fix a test failure.
1213
1214         * History/WebHistory.mm:
1215         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1216         Call through to the visited link store.
1217
1218         (+[WebHistory _removeAllVisitedLinks]):
1219         Ditto.
1220
1221         * WebCoreSupport/WebVisitedLinkStore.mm:
1222         (WebVisitedLinkStore::isLinkVisited):
1223         Make sure to populate visited links.
1224
1225 2014-11-30  Anders Carlsson  <andersca@apple.com>
1226
1227         Switch over to the visited link store from the WebViewGroup
1228         https://bugs.webkit.org/show_bug.cgi?id=139112
1229
1230         Reviewed by Sam Weinig.
1231
1232         * WebView/WebView.mm:
1233         (-[WebView _commonInitializationWithFrameName:groupName:]):
1234         (-[WebView setGroupName:]):
1235
1236 2014-11-30  Anders Carlsson  <andersca@apple.com>
1237
1238         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
1239         https://bugs.webkit.org/show_bug.cgi?id=139111
1240
1241         Reviewed by Sam Weinig.
1242
1243         * WebCoreSupport/WebVisitedLinkStore.h:
1244         * WebCoreSupport/WebVisitedLinkStore.mm:
1245         (WebVisitedLinkStore::removeVisitedLink):
1246         * WebView/WebView.mm:
1247         (-[WebView removeVisitedLink:]):
1248
1249 2014-11-29  Anders Carlsson  <andersca@apple.com>
1250
1251         Populate visited links
1252         https://bugs.webkit.org/show_bug.cgi?id=139101
1253
1254         Reviewed by Sam Weinig.
1255
1256         * History/WebHistory.mm:
1257         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
1258         Helper function that adds all visited link to the given store.
1259
1260         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
1261         Call the private method.
1262
1263         * History/WebHistoryInternal.h:
1264         * WebCoreSupport/WebVisitedLinkStore.h:
1265         Add new members.
1266
1267         * WebCoreSupport/WebVisitedLinkStore.mm:
1268         (WebVisitedLinkStore::addVisitedLink):
1269         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
1270
1271         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1272         Implement this. First try the delegate, then try the shared history.
1273
1274         (WebVisitedLinkStore::addVisitedLinkHash):
1275         Factor code that adds the link to the hash table into a separate function.
1276
1277         * WebView/WebView.mm:
1278         (-[WebView addVisitedLinks:]):
1279         Add the visited links to the store.
1280
1281 2014-11-29  Anders Carlsson  <andersca@apple.com>
1282
1283         More work on the legacy WebKit visited link store
1284         https://bugs.webkit.org/show_bug.cgi?id=139100
1285
1286         Reviewed by Sam Weinig.
1287
1288         * History/WebHistory.mm:
1289         (+[WebHistory setOptionalSharedHistory:]):
1290         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
1291
1292         * WebCoreSupport/WebVisitedLinkStore.h:
1293         * WebCoreSupport/WebVisitedLinkStore.mm:
1294         (visitedLinkStores):
1295         (WebVisitedLinkStore::WebVisitedLinkStore):
1296         (WebVisitedLinkStore::~WebVisitedLinkStore):
1297         Keep track of live visited link stores.
1298
1299         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
1300         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
1301
1302         (WebVisitedLinkStore::removeAllVisitedLinks):
1303         Iterate over all live link stores and remove their links.
1304
1305         (WebVisitedLinkStore::isLinkVisited):
1306         Populate visited links and check if our hash table contains the link.
1307
1308         (WebVisitedLinkStore::addVisitedLink):
1309         Add the link hash to the table.
1310
1311         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1312         Add stub.
1313
1314         (WebVisitedLinkStore::removeVisitedLinkHashes):
1315         Clear out the hash table.
1316
1317 2014-11-27  Anders Carlsson  <andersca@apple.com>
1318
1319         Add a stubbed out WebVisitedLinkStore to WebViewGroup
1320         https://bugs.webkit.org/show_bug.cgi?id=139066
1321
1322         Reviewed by Antti Koivisto.
1323
1324         * WebCoreSupport/WebViewGroup.h:
1325         (WebViewGroup::visitedLinkStore):
1326         * WebCoreSupport/WebViewGroup.mm:
1327         (WebViewGroup::WebViewGroup):
1328         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1329         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1330         (WebVisitedLinkStore::create):
1331         (WebVisitedLinkStore::WebVisitedLinkStore):
1332         (WebVisitedLinkStore::~WebVisitedLinkStore):
1333         (WebVisitedLinkStore::isLinkVisited):
1334         (WebVisitedLinkStore::addVisitedLink):
1335
1336 2014-11-25  Anders Carlsson  <andersca@apple.com>
1337
1338         Remove user content handling from PageGroup
1339         https://bugs.webkit.org/show_bug.cgi?id=139051
1340
1341         Reviewed by Antti Koivisto.
1342
1343         Use the user content controller in the web view group.
1344
1345         * WebView/WebView.mm:
1346         (-[WebView _injectOutlookQuirksScript]):
1347
1348 2014-11-25  Anders Carlsson  <andersca@apple.com>
1349
1350         Add a user content controller to WebViewGroup and use it for user content
1351         https://bugs.webkit.org/show_bug.cgi?id=139043
1352
1353         Reviewed by Antti Koivisto.
1354
1355         This is another tiny step towards getting rid of user content handling inside PageGroup.
1356
1357         * WebCoreSupport/WebViewGroup.h:
1358         (WebViewGroup::userContentController):
1359         Add a UserContentController member and getter.
1360
1361         * WebCoreSupport/WebViewGroup.mm:
1362         (WebViewGroup::get):
1363         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
1364
1365         (WebViewGroup::WebViewGroup):
1366         Create a user content controller.
1367
1368         * WebView/WebView.mm:
1369         (-[WebView _commonInitializationWithFrameName:groupName:]):
1370         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
1371         set its user content controller in the PageConfiguration.
1372
1373         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1374         Ditto.
1375
1376         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1377         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1378         (+[WebView _removeUserScriptFromGroup:world:url:]):
1379         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
1380         (+[WebView _removeUserScriptsFromGroup:world:]):
1381         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
1382         (+[WebView _removeAllUserContentFromGroup:]):
1383         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
1384
1385         (-[WebView setGroupName:]):
1386         Set the user content controller to the new WebViewGroup's user content controller.
1387
1388 2014-11-21  Jer Noble  <jer.noble@apple.com>
1389
1390         Support multiple signatures of diagnostic logging.
1391         https://bugs.webkit.org/show_bug.cgi?id=138690
1392
1393         Reviewed by Anders Carlsson.
1394
1395         Page::PageClients has been renamed PageConfiguration.
1396
1397         * WebView/WebView.mm:
1398         (-[WebView _commonInitializationWithFrameName:groupName:]):
1399         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1400
1401 2014-11-21  Zalan Bujtas  <zalan@apple.com>
1402
1403         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
1404         https://bugs.webkit.org/show_bug.cgi?id=138981
1405
1406         Reviewed by Simon Fraser.
1407
1408         * WebView/WebPreferenceKeysPrivate.h:
1409         * WebView/WebPreferences.mm:
1410         (+[WebPreferences initialize]):
1411         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
1412         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
1413         * WebView/WebPreferencesPrivate.h:
1414         * WebView/WebView.mm:
1415         (-[WebView _preferencesChanged:]):
1416
1417 2014-11-21  Tim Horton  <timothy_horton@apple.com>
1418
1419         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
1420         ​https://bugs.webkit.org/show_bug.cgi?id=138960
1421         <rdar://problem/19056715>
1422
1423         Reviewed by Anders Carlsson.
1424
1425         * WebView/WebActionMenuController.mm:
1426         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
1427         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1428         Use DataDetectors SPI instead of an explicit blacklist.
1429
1430 2014-11-21  Tim Horton  <timothy_horton@apple.com>
1431
1432         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
1433         https://bugs.webkit.org/show_bug.cgi?id=138960
1434         <rdar://problem/19056715>
1435
1436         Reviewed by Beth Dakin.
1437
1438         * WebView/WebActionMenuController.mm:
1439         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1440         Blacklist contact results, because they don't have useful menus. If we
1441         bail before setting up _currentActionContext, we'll still allow fallthrough
1442         to ordinary text actions, avoiding mysterious failure when a contact is detected.
1443
1444         This doesn't break the case that r176351 was intended to fix,
1445         because in that case we were detecting e.g. addresses.
1446
1447 2014-11-21  Anders Carlsson  <andersca@apple.com>
1448
1449         Remove the Timer parameters from timer callbacks
1450         https://bugs.webkit.org/show_bug.cgi?id=138974
1451
1452         Reviewed by Antti Koivisto.
1453
1454         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1455         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1456         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
1457         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
1458         * Plugins/WebNetscapePluginStream.h:
1459         * Plugins/WebNetscapePluginStream.mm:
1460         (WebNetscapePluginStream::WebNetscapePluginStream):
1461         (WebNetscapePluginStream::deliverDataTimerFired):
1462
1463 2014-11-21  Anders Carlsson  <andersca@apple.com>
1464
1465         Make memoryCache() return a reference
1466         https://bugs.webkit.org/show_bug.cgi?id=138939
1467
1468         Reviewed by Antti Koivisto.
1469
1470         * Misc/WebCache.mm:
1471         (+[WebCache statistics]):
1472         (+[WebCache emptyInMemoryResources]):
1473         (+[WebCache sizeOfDeadResources:]):
1474         (+[WebCache addImageToCache:forURL:forFrame:]):
1475         (+[WebCache removeImageFromCacheForURL:forFrame:]):
1476         (+[WebCache imageForURL:]):
1477         (+[WebCache setDisabled:]):
1478         (+[WebCache isDisabled]):
1479         * WebView/WebView.mm:
1480         (+[WebView _setCacheModel:]):
1481
1482 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
1483
1484         Remove the remaining vestiges of minimal-ui
1485         https://bugs.webkit.org/show_bug.cgi?id=138890
1486
1487         Reviewed by Sam Weinig.
1488
1489         * History/WebHistoryItem.mm:
1490         * History/WebHistoryItemPrivate.h:
1491
1492 2014-11-20  Tim Horton  <timothy_horton@apple.com>
1493
1494         Cancel DataDetectors menu earlier if we know it can't be presented
1495         https://bugs.webkit.org/show_bug.cgi?id=138922
1496         <rdar://problem/18950441>
1497
1498         Reviewed by Beth Dakin.
1499
1500         * WebView/WebActionMenuController.mm:
1501         (-[WebActionMenuController prepareForMenu:withEvent:]):
1502         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
1503         and use a bigger hammer (removeAllItems).
1504
1505         (-[WebActionMenuController willOpenMenu:withEvent:]):
1506         If we end up with a menu with no items, don't change selection or anything.
1507
1508 2014-11-20  Beth Dakin  <bdakin@apple.com>
1509
1510         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
1511         https://bugs.webkit.org/show_bug.cgi?id=138568
1512         -and corresponding-
1513         rdar://problem/18904600
1514
1515         Reviewed by Tim Horton.
1516
1517         Skip images for lookup.
1518         * WebView/WebActionMenuController.mm:
1519         (performDictionaryLookupForRange):
1520
1521 2014-11-19  Beth Dakin  <bdakin@apple.com>
1522
1523         Invoking an action menu on a selection should result in the text menu
1524         https://bugs.webkit.org/show_bug.cgi?id=138892
1525         -and corresponding-
1526         rdar://problem/18996776
1527
1528         Reviewed by Tim Horton.
1529
1530         * WebView/WebActionMenuController.mm:
1531         (-[WebActionMenuController _defaultMenuItems]):
1532
1533 2014-11-19  Beth Dakin  <bdakin@apple.com>
1534
1535         Data detected results with no menu items should not fall through to regular text 
1536         action menus
1537         https://bugs.webkit.org/show_bug.cgi?id=138887
1538         -and corresponding-
1539         rdar://problem/18971616
1540
1541         Reviewed by Tim Horton.
1542
1543         * WebView/WebActionMenuController.mm:
1544         (-[WebActionMenuController _defaultMenuItems]):
1545
1546 2014-11-19  Daniel Bates  <dabates@apple.com>
1547
1548         [iOS] Make WebKit build with public iOS SDK
1549         https://bugs.webkit.org/show_bug.cgi?id=136863
1550
1551         Reviewed by David Kilzer.
1552
1553         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
1554         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
1555         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
1556         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
1557         may be used by Apple internal clients that do not include wtf/Platform.h.
1558         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
1559         private Foundation headers directly.
1560         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
1561         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
1562         instead of including private CFNetwork headers directly. Also fixed up style and
1563         ordering of header include directives.
1564         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
1565         CFNetwork headers directly. Also sort the #import directives.
1566         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
1567         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
1568
1569 2014-11-18  David Kilzer  <ddkilzer@apple.com>
1570
1571         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
1572         <http://webkit.org/b/138813>
1573
1574         Reviewed by Mark Rowe.
1575
1576         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
1577         selectors.
1578
1579 2014-11-18  Chris Dumez  <cdumez@apple.com>
1580
1581         Add a setting to toggle DOMTimer throttling support
1582         https://bugs.webkit.org/show_bug.cgi?id=138844
1583         <rdar://problem/19020874>
1584
1585         Reviewed by Andreas Kling.
1586
1587         Add a setting to disable DOM timers throttling, in order to help
1588         developers determine if a specific issue is caused by timer
1589         throttling.
1590
1591         * WebView/WebPreferenceKeysPrivate.h:
1592         * WebView/WebPreferences.mm:
1593         (+[WebPreferences initialize]):
1594         (-[WebPreferences domTimersThrottlingEnabled]):
1595         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
1596         * WebView/WebPreferencesPrivate.h:
1597         * WebView/WebView.mm:
1598         (-[WebView _preferencesChanged:]):
1599
1600 2014-11-18  Tim Horton  <timothy_horton@apple.com>
1601
1602         Avoid re-encoding action menu image data
1603         https://bugs.webkit.org/show_bug.cgi?id=138817
1604         <rdar://problem/18840382>
1605
1606         Reviewed by Anders Carlsson.
1607
1608         * WebView/WebActionMenuController.mm:
1609         (-[WebActionMenuController _defaultMenuItemsForImage:]):
1610         (-[WebActionMenuController _addImageToPhotos:]):
1611         Build a temporary filename from a UUID and the image's desired extension.
1612         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
1613         Build an image menu only if we have an image, URL, data, and extension.
1614
1615 2014-11-18  Daniel Bates  <dabates@apple.com>
1616
1617         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1618         SPI are not available in public SDK
1619         https://bugs.webkit.org/show_bug.cgi?id=138802
1620
1621         Reviewed by David Kilzer.
1622
1623         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
1624         libdispatch and MobileGestalt headers directly.
1625
1626         * WebView/WebView.mm:
1627
1628 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
1629
1630         Remove calls to deprecated NSMenu methods
1631         https://bugs.webkit.org/show_bug.cgi?id=138808.
1632
1633         Reviewed by Anders Carlsson.
1634
1635         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
1636
1637         * WebCoreSupport/PopupMenuMac.mm:
1638         (PopupMenuMac::populate):
1639
1640 2014-11-17  Daniel Bates  <dabates@apple.com>
1641
1642         Unreviewed, rolling out r176232.
1643
1644         Broke the Mac build. Will investigate offline.
1645
1646         Reverted changeset:
1647
1648         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
1649         MobileGestalt"
1650         https://bugs.webkit.org/show_bug.cgi?id=138802
1651         http://trac.webkit.org/changeset/176232
1652
1653 2014-11-17  Daniel Bates  <dabates@apple.com>
1654
1655         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1656         SPI are not available in public SDK
1657         https://bugs.webkit.org/show_bug.cgi?id=138802
1658
1659         Reviewed by David Kilzer.
1660
1661         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
1662         libdispatch and MobileGestalt headers directly.
1663
1664         * WebView/WebView.mm:
1665
1666 2014-11-17  Beth Dakin  <bdakin@apple.com>
1667
1668         Whitespace action menus should focus the HitTestResult and create an insertion 
1669         point
1670         https://bugs.webkit.org/show_bug.cgi?id=138786
1671         -and corresponding-
1672         rdar://problem/18944893
1673
1674         Reviewed by Tim Horton.
1675
1676         Whitespace menus should cause the HitTestResult to be focused, and they should set 
1677         the selection based on the HitTest location.
1678
1679         * WebView/WebActionMenuController.mm:
1680         (-[WebActionMenuController isMenuForTextContent]):
1681         (-[WebActionMenuController focusAndSelectHitTestResult]):
1682         (-[WebActionMenuController willOpenMenu:withEvent:]):
1683
1684 2014-11-17  Daniel Bates  <dabates@apple.com>
1685
1686         [iOS] QuartzCore SPI not available in public SDK
1687         https://bugs.webkit.org/show_bug.cgi?id=138751
1688
1689         Reviewed by David Kilzer.
1690
1691         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
1692
1693         * WebInspector/WebNodeHighlight.mm:
1694         * WebView/WebIndicateLayer.mm:
1695
1696 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
1697
1698         [iOS] allow host application to opt-out of alternate fullscreen
1699         https://bugs.webkit.org/show_bug.cgi?id=138787
1700
1701         Reviewed by Darin Adler.
1702
1703         * WebView/WebPreferenceKeysPrivate.h:
1704         * WebView/WebPreferences.mm:
1705         (+[WebPreferences initialize]):
1706         (-[WebPreferences allowsAlternateFullscreen]):
1707         (-[WebPreferences setAllowsAlternateFullscreen:]):
1708         * WebView/WebPreferencesPrivate.h:
1709         * WebView/WebView.mm:
1710         (-[WebView _preferencesChanged:]):
1711
1712 2014-11-16  Tim Horton  <timothy_horton@apple.com>
1713
1714         Use TextIndicator instead of the built in Lookup highlight
1715         https://bugs.webkit.org/show_bug.cgi?id=138775
1716         <rdar://problem/18953982>
1717
1718         Reviewed by Anders Carlsson.
1719
1720         * WebCoreSupport/WebSystemInterface.mm:
1721         (InitWebCoreSystemInterface):
1722         Remove a WKSI import.
1723
1724         * WebView/WebActionMenuController.mm:
1725         (-[WebActionMenuController _lookupText:]):
1726         (-[WebActionMenuController _createActionMenuItemForTag:]):
1727         Make use of the new Lookup SPI header.
1728         Disable the Lookup item if lookup is not available.
1729
1730 2014-11-15  Tim Horton  <timothy_horton@apple.com>
1731
1732         Implement data detectors and mailto action menus for WebKit1
1733         https://bugs.webkit.org/show_bug.cgi?id=138765
1734         <rdar://problem/18877535>
1735
1736         Reviewed by Beth Dakin.
1737
1738         * WebView/WebActionMenuController.h:
1739         * WebView/WebActionMenuController.mm:
1740         (-[WebActionMenuController willOpenMenu:withEvent:]):
1741         Tell DataDetectors that the menu is going to open.
1742         Select the text (or not) based on the number of items in the menu, just like WebKit2.
1743
1744         (-[WebActionMenuController didCloseMenu:withEvent:]):
1745         Tell DataDetectors that the menu closed.
1746
1747         (-[WebActionMenuController _defaultMenuItemsForLink]):
1748         Move these checks out of _defaultMenuItemsForLink, because we expect this
1749         to always return a complete link menu.
1750
1751         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
1752         Implement. More or less copied from WebKit2.
1753
1754         (-[WebActionMenuController _selectDataDetectedText]):
1755         Select the stashed range.
1756
1757         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1758         Implement. More or less copied from WebKit2.
1759         The yellow highlight isn't hooked up yet.
1760         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
1761
1762         (-[WebActionMenuController _selectLookupText]):
1763         Remove an unnecessary return.
1764
1765         (-[WebActionMenuController _defaultMenuItems]):
1766         Call into the two new menu types.
1767
1768         * WebView/WebUIDelegatePrivate.h:
1769
1770 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
1771
1772         Get rid of WebFontCache
1773         https://bugs.webkit.org/show_bug.cgi?id=134752
1774
1775         Reviewed by Dave Hyatt.
1776
1777         * WebView/WebHTMLView.mm:
1778
1779 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
1780
1781         Update some artwork for the legacy WebKit action menu
1782         https://bugs.webkit.org/show_bug.cgi?id=138758
1783         <rdar://problem/18989840>
1784
1785         * WebView/WebActionMenuController.mm:
1786         (webKitBundleImageNamed): Deleted.
1787         Fix the build.
1788
1789 2014-11-14  Tim Horton  <timothy_horton@apple.com>
1790
1791         Update some artwork for the legacy WebKit action menu
1792         https://bugs.webkit.org/show_bug.cgi?id=138758
1793         <rdar://problem/18989840>
1794
1795         Reviewed by Simon Fraser.
1796
1797         * WebView/WebActionMenuController.mm:
1798         (-[WebActionMenuController _createActionMenuItemForTag:]):
1799
1800 2014-11-14  Daniel Bates  <dabates@apple.com>
1801
1802         [iOS] NSFileManager and QuickLook SPI not available in public SDK
1803         https://bugs.webkit.org/show_bug.cgi?id=138742
1804
1805         Reviewed by Pratik Solanki.
1806
1807         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
1808
1809         * WebCoreSupport/WebFrameLoaderClient.mm:
1810
1811 2014-11-14  Beth Dakin  <bdakin@apple.com>
1812
1813         WK1: Webpage preview can come up in wrong location
1814         https://bugs.webkit.org/show_bug.cgi?id=138747
1815         -and corresponding-
1816         rdar://problem/18979004
1817
1818         Reviewed by Tim Horton.
1819
1820         Converting to window twice is bad.
1821         * WebView/WebActionMenuController.mm:
1822         (elementBoundingBoxInWindowCoordinatesFromNode):
1823         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1824         (elementBoundingBoxFromNode): Deleted.
1825
1826 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
1827
1828         Move FontMac and FontCacheMac off of WKSI
1829         https://bugs.webkit.org/show_bug.cgi?id=138633
1830
1831         Reviewed by Simon Fraser.
1832
1833         * WebCoreSupport/WebSystemInterface.mm:
1834         (InitWebCoreSystemInterface):
1835         * WebKit.order:
1836
1837 2014-11-13  Beth Dakin  <bdakin@apple.com>
1838
1839         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
1840         https://bugs.webkit.org/show_bug.cgi?id=138716
1841         -and corresponding-
1842         rdar://problem/18977222
1843
1844         Reviewed by Tim Horton.
1845
1846         It’s not necessary to use the WebElementDictionary for so many things now that we 
1847         are caching the HitTestResult. We should just use the HitTestResult.
1848
1849         * WebView/WebActionMenuController.mm:
1850         (-[WebActionMenuController prepareForMenu:withEvent:]):
1851         (-[WebActionMenuController _openURLFromActionMenu:]):
1852         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
1853         (elementBoundingBoxFromNode):
1854         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1855         (-[WebActionMenuController _defaultMenuItemsForLink]):
1856         (-[WebActionMenuController _defaultMenuItemsForImage]):
1857         (-[WebActionMenuController _defaultMenuItemsForVideo]):
1858         (-[WebActionMenuController _defaultMenuItemsForText]):
1859         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
1860         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
1861         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
1862         (-[WebActionMenuController _createActionMenuItemForTag:]):
1863         (-[WebActionMenuController _defaultMenuItems]):
1864         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
1865         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
1866         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
1867         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
1868         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
1869         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
1870         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
1871         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
1872         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
1873         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
1874
1875 2014-11-13  Daniel Bates  <dabates@apple.com>
1876
1877         [iOS] NSGeometry data types are not available in the public SDK
1878         https://bugs.webkit.org/show_bug.cgi?id=137536
1879
1880         Reviewed by David Kilzer.
1881
1882         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
1883         private header.
1884
1885         * DOM/WebDOMOperationsPrivate.h:
1886
1887 2014-11-13  Beth Dakin  <bdakin@apple.com>
1888
1889         WK1: Support default actions for video
1890         https://bugs.webkit.org/show_bug.cgi?id=138713
1891         -and corresponding-
1892         rdar://problem/18877520
1893
1894         Reviewed by Tim Horton.
1895
1896         Call setToNonShadowAncestor() for media HitTestResults.
1897         * WebView/WebActionMenuController.mm:
1898         (-[WebActionMenuController performHitTestAtPoint:]):
1899
1900         Default items and actions.
1901         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
1902         (-[WebActionMenuController _copyVideoURL:]):
1903         (-[WebActionMenuController _saveVideoToDownloads:]):
1904         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1905         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1906         * WebView/WebUIDelegatePrivate.h:
1907
1908 2014-11-13  Tim Horton  <timothy_horton@apple.com>
1909
1910         WK1: Update icon for Add to Reading List
1911         https://bugs.webkit.org/show_bug.cgi?id=138710
1912         <rdar://problem/18975774>
1913
1914         Reviewed by Beth Dakin.
1915
1916         * WebView/WebActionMenuController.mm:
1917         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1918         Use the right icon, matching WebKit2.
1919
1920 2014-11-12  Beth Dakin  <bdakin@apple.com>
1921
1922         WK1: Support default actions for images
1923         https://bugs.webkit.org/show_bug.cgi?id=138668
1924         -and corresponding-
1925         rdar://problem/18785434
1926
1927         Reviewed by Tim Horton.
1928
1929         * WebView/WebActionMenuController.h:
1930         * WebView/WebActionMenuController.mm:
1931         (-[WebActionMenuController didCloseMenu:withEvent:]):
1932         (-[WebActionMenuController _defaultMenuItemsForImage:]):
1933         (-[WebActionMenuController _copyImage:]):
1934         (temporaryPhotosDirectoryPath):
1935         (pathToPhotoOnDisk):
1936         (-[WebActionMenuController _canAddMediaToPhotos]):
1937         (-[WebActionMenuController _addImageToPhotos:]):
1938         (-[WebActionMenuController _saveImageToDownloads:]):
1939         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
1940         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
1941         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
1942         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1943         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1944         * WebView/WebUIDelegatePrivate.h:
1945
1946 2014-11-11  Beth Dakin  <bdakin@apple.com>
1947
1948         Action menu hit testing is not working properly with all WK1 apps
1949         https://bugs.webkit.org/show_bug.cgi?id=138643
1950         -and corresponding-
1951         rdar://problem/18949376
1952
1953         Reviewed by Tim Horton.
1954
1955         * WebView/WebActionMenuController.mm:
1956         (-[WebActionMenuController prepareForMenu:withEvent:]):
1957         (-[WebActionMenuController _lookupText:]):
1958
1959 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1960
1961         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
1962         https://bugs.webkit.org/show_bug.cgi?id=138623
1963
1964         Reviewed by Geoff Garen.
1965
1966         * WebCoreSupport/WebSystemInterface.mm:
1967         (InitWebCoreSystemInterface):
1968         * WebKit.order:
1969
1970 2014-11-11  Tim Horton  <timothy_horton@apple.com>
1971
1972         Localize strings for action menus
1973         https://bugs.webkit.org/show_bug.cgi?id=138591
1974         <rdar://problem/18815343>
1975
1976         Reviewed by Dan Bates.
1977
1978         * WebView/WebActionMenuController.mm:
1979         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1980         Make use of the new strings.
1981
1982 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1983
1984         Cleanup from r175379
1985         https://bugs.webkit.org/show_bug.cgi?id=138616
1986
1987         Reviewed by Simon Fraser.
1988
1989         * WebCoreSupport/WebSystemInterface.mm:
1990         (InitWebCoreSystemInterface):
1991         * WebKit.order:
1992
1993 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1994
1995         Move CTFontTransformGlyphs out from WKSI
1996         https://bugs.webkit.org/show_bug.cgi?id=138599
1997
1998         Reviewed by Simon Fraser.
1999
2000         * WebCoreSupport/WebSystemInterface.mm:
2001         (InitWebCoreSystemInterface):
2002         * WebKit.order:
2003
2004 2014-11-11  Dan Bernstein  <mitz@apple.com>
2005
2006         More iOS build fix.
2007
2008         * WebView/WebHTMLViewInternal.h:
2009
2010 2014-11-11  Dan Bernstein  <mitz@apple.com>
2011
2012         iOS build fix.
2013
2014         * WebView/WebHTMLView.mm:
2015
2016 2014-11-10  Beth Dakin  <bdakin@apple.com>
2017
2018         WK1: Support default actions for editable text with misspelled word
2019         https://bugs.webkit.org/show_bug.cgi?id=138590
2020         -and corresponding-
2021         rdar://problem/18877506
2022
2023         Reviewed by Tim Horton.
2024
2025         If there are misspelled word suggestions for editable text, create a new type of 
2026         menu with a spelling suggestion sub-menu.
2027
2028         * WebView/WebActionMenuController.mm:
2029         (-[WebActionMenuController isMenuForTextContent]):
2030         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
2031         (-[WebActionMenuController _changeSelectionToSuggestion:]):
2032         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2033         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2034         * WebView/WebHTMLView.mm:
2035         (-[WebHTMLView _changeSpellingToWord:]):
2036         * WebView/WebHTMLViewInternal.h:
2037         * WebView/WebUIDelegatePrivate.h:
2038
2039 2014-11-10  Beth Dakin  <bdakin@apple.com>
2040
2041         WK1: Support default actions for editable whitespace
2042         https://bugs.webkit.org/show_bug.cgi?id=138586
2043         -and corresponding-
2044         rdar://problem/18932048
2045
2046         Reviewed by Tim Horton.
2047
2048         New menu type. Just wants paste.
2049
2050         * WebView/WebActionMenuController.mm:
2051         (-[WebActionMenuController isMenuForTextContent]):
2052         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
2053         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2054         * WebView/WebUIDelegatePrivate.h:
2055
2056 2014-11-10  Beth Dakin  <bdakin@apple.com>
2057
2058         WK1: Support default actions for editable text
2059         https://bugs.webkit.org/show_bug.cgi?id=138580
2060         -and corresponding-
2061         rdar://problem/18877497
2062
2063         Reviewed by Tim Horton.
2064
2065         New menu type, and new action type for paste. 
2066
2067         * WebView/WebActionMenuController.mm:
2068         (-[WebActionMenuController isMenuForTextContent]):
2069         (-[WebActionMenuController willOpenMenu:withEvent:]):
2070         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
2071         (-[WebActionMenuController _paste:]):
2072         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2073         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2074         * WebView/WebUIDelegatePrivate.h:
2075
2076 2014-11-10  Beth Dakin  <bdakin@apple.com>
2077
2078         WK1: Text is getting selected even when an action menu fails to invoke
2079         https://bugs.webkit.org/show_bug.cgi?id=138576
2080         -and corresponding-
2081         rdar://problem/18931330
2082
2083         Reviewed by Tim Horton.
2084
2085         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
2086         * WebView/WebActionMenuController.h:
2087         * WebView/WebActionMenuController.mm:
2088         (-[WebActionMenuController prepareForMenu:withEvent:]):
2089         (-[WebActionMenuController willOpenMenu:withEvent:]):
2090
2091         _selectLookupText no longer needs to return a BOOL indicating success or failure.
2092         (-[WebActionMenuController _selectLookupText]):
2093         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2094
2095         Pass willOpenMenu: on to the controller.
2096         * WebView/WebView.mm:
2097         (-[WebView willOpenMenu:withEvent:]):
2098
2099 2014-11-10  Beth Dakin  <bdakin@apple.com>
2100
2101         Speculative build fix.
2102
2103         * WebView/WebActionMenuController.mm:
2104
2105 2014-11-10  Beth Dakin  <bdakin@apple.com>
2106
2107         Action menu initialization should be moved to _commonInitializationWithFrameName
2108         https://bugs.webkit.org/show_bug.cgi?id=138572
2109         -and corresponding-
2110         rdar://problem/18929733
2111
2112         Reviewed by Tim Horton.
2113
2114         * WebView/WebView.mm:
2115         (-[WebView _commonInitializationWithFrameName:groupName:]):
2116         (-[WebView _initWithFrame:frameName:groupName:]):
2117
2118 2014-11-10  Beth Dakin  <bdakin@apple.com>
2119
2120         WK1: Support default actions for read-only text
2121         https://bugs.webkit.org/show_bug.cgi?id=138552
2122         -and corresponding-
2123         rdar://problem/18877483
2124
2125         Reviewed by Tim Horton.
2126
2127         New WKSystemInterface functions that WebCore needs to use.
2128         * WebCoreSupport/WebSystemInterface.mm:
2129         (InitWebCoreSystemInterface):
2130
2131         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
2132         makes a lot of things easier.
2133         * WebView/WebActionMenuController.h:
2134         * WebView/WebActionMenuController.mm:
2135
2136         Perform the hit test ourselves instead of calling into WebView so that we can more 
2137         easily save the WebCore::HitTestResult for ourselves.
2138         (-[WebActionMenuController performHitTestAtPoint:]):
2139
2140         Clear selection for non-text menus.
2141         (-[WebActionMenuController prepareForMenu:withEvent:]):
2142
2143         Re-set the _type here just to be safe.
2144         (-[WebActionMenuController didCloseMenu:withEvent:]):
2145
2146         Moving this method to be next to the link actions so they can be within a pragma 
2147         mark.
2148         (-[WebActionMenuController _defaultMenuItemsForLink:]):
2149
2150         New method for default text actions — lookup and copy.
2151         (-[WebActionMenuController _defaultMenuItemsForText:]):
2152         (-[WebActionMenuController _copySelection:]):
2153         (-[WebActionMenuController _lookupText:]):
2154
2155         If there is not already a selection, invoking the action menu on text should 
2156         select the lookup text.
2157         (-[WebActionMenuController _selectLookupText]):
2158         (performDictionaryLookupForSelection):
2159         (performDictionaryLookupForRange):
2160
2161         Handle text now.
2162         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2163         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2164
2165         New enum values.
2166         * WebView/WebUIDelegatePrivate.h:
2167
2168         Pass didCloseMenu on to the controller.
2169         * WebView/WebView.mm:
2170         (-[WebView didCloseMenu:withEvent:]):
2171
2172 2014-11-09  Chris Dumez  <cdumez@apple.com>
2173
2174         Add a more correct way to compare floating point numbers and use it
2175         https://bugs.webkit.org/show_bug.cgi?id=138527
2176
2177         Reviewed by Darin Adler.
2178
2179         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
2180         to compare floating-point numbers.
2181
2182         * WebView/WebHTMLView.mm:
2183         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
2184
2185 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
2186
2187         Delete cookies between tests
2188         https://bugs.webkit.org/show_bug.cgi?id=138528
2189
2190         Reviewed by Sam Weinig.
2191
2192         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
2193         * WebView/WebPreferencesPrivate.h:
2194         Added an SPI for DumpRenderTree.
2195
2196 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
2197
2198         [iOS] Update optimized fullscreen media controls
2199         https://bugs.webkit.org/show_bug.cgi?id=138493
2200
2201         Reviewed by Brent Fulgham.
2202
2203         * WebCoreSupport/WebSystemInterface.mm:
2204         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
2205
2206 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
2207
2208         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
2209         https://bugs.webkit.org/show_bug.cgi?id=138443
2210
2211         Reviewed by Anders Carlsson.
2212
2213         Wrapping the dealloc method in its own autorelease pool avoids the problem of
2214         complex tear-downs leading to the WebView itself being added to an autorelease
2215         pool that is not drained until after the instance has been dealloc'd.
2216  
2217         * WebView/WebView.mm:
2218         (-[WebView dealloc]):
2219
2220 2014-11-05  Jer Noble  <jer.noble@apple.com>
2221
2222         De-templatize Timer
2223         https://bugs.webkit.org/show_bug.cgi?id=138450
2224
2225         Reviewed by Anders Carlsson.
2226
2227         Remove template specifiers from Timer.
2228
2229         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2230         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2231         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2232         * Plugins/WebNetscapePluginStream.h:
2233         * Plugins/WebNetscapePluginStream.mm:
2234         (WebNetscapePluginStream::deliverDataTimerFired):
2235
2236 2014-11-05  Dan Bernstein  <mitz@apple.com>
2237
2238         Remove the unused deletion UI feature
2239         https://bugs.webkit.org/show_bug.cgi?id=138442
2240
2241         Rubber-stamped by Alexey Proskuryakov.
2242
2243         * DefaultDelegates/WebDefaultEditingDelegate.m:
2244         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
2245         * WebCoreSupport/WebEditorClient.h:
2246         * WebCoreSupport/WebEditorClient.mm:
2247         (WebEditorClient::shouldShowDeleteInterface): Deleted.
2248         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
2249         -webView:shouldShowDeleteInterfaceForElement:.
2250
2251 2014-11-03  Dean Jackson  <dino@apple.com>
2252
2253         Add ENABLE_FILTERS_LEVEL_2 feature guard.
2254         https://bugs.webkit.org/show_bug.cgi?id=138362
2255
2256         Reviewed by Tim Horton.
2257
2258         Add a new feature define for Level 2 of CSS Filters.
2259         http://dev.w3.org/fxtf/filters-2/
2260
2261         * Configurations/FeatureDefines.xcconfig:
2262
2263 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
2264
2265         Add button and enable optimized fullscreen.
2266         https://bugs.webkit.org/show_bug.cgi?id=138351
2267
2268         Reviewed by Eric Carlson.
2269
2270         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
2271
2272         * WebCoreSupport/WebSystemInterface.mm:
2273         (InitWebCoreSystemInterface): added
2274
2275 2014-11-04  Chris Dumez  <cdumez@apple.com>
2276
2277         Add ptr() method to Ref class
2278         https://bugs.webkit.org/show_bug.cgi?id=138361
2279
2280         Reviewed by Darin Adler.
2281
2282         Use the new Ref::ptr() method.
2283
2284         * WebView/WebFrame.mm:
2285         (-[WebFrame _setTypingStyle:withUndoAction:]):
2286         * WebView/WebHTMLView.mm:
2287         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
2288         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
2289         * WebView/WebView.mm:
2290         (-[WebView applyStyle:]):
2291
2292 2014-11-04  Darin Adler  <darin@apple.com>
2293
2294         Eliminate ResourceBuffer and use SharedBuffer directly instead
2295         https://bugs.webkit.org/show_bug.cgi?id=138174
2296
2297         Reviewed by Antti Koivisto.
2298
2299         * WebView/WebDataSource.mm:
2300         (-[WebDataSource data]): Use SharedBuffer directly.
2301         * WebView/WebHTMLView.mm:
2302         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2303
2304 2014-11-03  Commit Queue  <commit-queue@webkit.org>
2305
2306         Unreviewed, rolling out r175406, r175413, and r175423.
2307         https://bugs.webkit.org/show_bug.cgi?id=138327
2308
2309         Multipart tests are still broken (Requested by ap on #webkit).
2310
2311         Reverted changesets:
2312
2313         "Eliminate ResourceBuffer and use SharedBuffer directly
2314         instead"
2315         https://bugs.webkit.org/show_bug.cgi?id=138174
2316         http://trac.webkit.org/changeset/175406
2317
2318         "Unreviewed, iOS build fix since 175406."
2319         http://trac.webkit.org/changeset/175413
2320
2321         "Fix assertion in CachedResource::addDataBuffer"
2322         http://trac.webkit.org/changeset/175423
2323
2324 2014-10-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2325
2326         Use std::unique_ptr for TypeCountSet
2327         https://bugs.webkit.org/show_bug.cgi?id=138242
2328
2329         Reviewed by Andreas Kling.
2330
2331         * Misc/WebCoreStatistics.mm:
2332         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr.
2333         (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto.
2334
2335 2014-10-31  Beth Dakin  <bdakin@apple.com>
2336
2337         Use system art for action menus when possible
2338         https://bugs.webkit.org/show_bug.cgi?id=138260
2339
2340         Reviewed by Tim Horton.
2341
2342         * WebView/WebActionMenuController.mm:
2343         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2344
2345 2014-10-30  Darin Adler  <darin@apple.com>
2346
2347         Eliminate ResourceBuffer and use SharedBuffer directly instead
2348         https://bugs.webkit.org/show_bug.cgi?id=138174
2349
2350         Reviewed by Antti Koivisto.
2351
2352         * WebView/WebDataSource.mm:
2353         (-[WebDataSource data]): Use SharedBuffer directly.
2354         * WebView/WebHTMLView.mm:
2355         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2356
2357 2014-10-30  Jer Noble  <jer.noble@apple.com>
2358
2359         [EME] Add Setting for accessing storage location for MediaKeys data
2360         https://bugs.webkit.org/show_bug.cgi?id=138147
2361
2362         Reviewed by Brady Eidson.
2363
2364         * WebView/WebPreferenceKeysPrivate.h:
2365         * WebView/WebPreferences.mm:
2366         (+[WebPreferences initialize]): Set default location.
2367         (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor.
2368         (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter.
2369         * WebView/WebPreferencesPrivate.h:
2370         * WebView/WebView.mm:
2371         (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings.
2372
2373 2014-10-30  Dana Burkart  <dburkart@apple.com>
2374
2375         <rdar://problem/18821260> Prepare for the mysterious future
2376
2377         Reviewed by Lucas Forschler.
2378
2379         * Configurations/Base.xcconfig:
2380         * Configurations/DebugRelease.xcconfig:
2381         * Configurations/FeatureDefines.xcconfig:
2382         * Configurations/Version.xcconfig:
2383
2384 2014-10-28  Jeremy Jones  <jeremyj@apple.com>
2385
2386         Add optimized fullscreen mode.
2387         https://bugs.webkit.org/show_bug.cgi?id=138044
2388
2389         Reviewed by Jer Noble.
2390
2391         Enable different types of fullscreen video behavior.
2392         Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
2393
2394         * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
2395         * WebCoreSupport/WebChromeClient.mm:
2396         (WebChromeClient::enterVideoFullscreenForVideoElement): ditto
2397         * WebView/WebView.mm:
2398         (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
2399         (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.
2400         * WebView/WebViewInternal.h: ditto
2401
2402 2014-10-27  Beth Dakin  <bdakin@apple.com>
2403
2404         Provide a way for WebKit1 clients to override default action menu items
2405         https://bugs.webkit.org/show_bug.cgi?id=138066
2406         -and corresponding-
2407         rdar://problem/18451638
2408
2409         Reviewed by Anders Carlsson.
2410
2411         WebActionMenuController now has an ivar for the WebActionMenuType so that it can 
2412         send that along to clients customizing the menu.
2413         * WebView/WebActionMenuController.h:
2414         * WebView/WebActionMenuController.mm:
2415         (-[WebActionMenuController prepareForMenu:withEvent:]):
2416         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2417
2418         New enum and new SPI to customize menus.
2419         * WebView/WebUIDelegatePrivate.h:
2420
2421 2014-10-24  Benjamin Poulain  <bpoulain@apple.com>
2422
2423         Fix the iOS build
2424
2425         * Configurations/WebKitLegacy.xcconfig:
2426         * WebView/WebView.mm:
2427
2428 2014-10-24  Beth Dakin  <bdakin@apple.com>
2429
2430         Build fix.
2431
2432         * WebView/WebActionMenuController.mm:
2433         (-[WebActionMenuController _openURLFromActionMenu:]):
2434         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2435         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2436
2437 2014-10-24  Beth Dakin  <bdakin@apple.com>
2438
2439         WebKit1 should support action menus
2440         https://bugs.webkit.org/show_bug.cgi?id=138032
2441
2442         Reviewed by Tim Horton.
2443
2444         This patch adds basic support for action menus and adds actions for links.
2445
2446         Helper class takes care of all of the action menu work. WebView will forward the 
2447         prepareForMenu: message, and then the helper class takes it from there.
2448         * WebView/WebActionMenuController.h: Added.
2449         * WebView/WebActionMenuController.mm: Added.
2450         (-[WebActionMenuController webViewClosed]):
2451         (-[WebActionMenuController prepareForMenu:withEvent:]):
2452
2453         Selectors for link actions.
2454         (-[WebActionMenuController _openURLFromActionMenu:]):
2455         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2456         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
2457         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2458         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2459         (webKitBundleImageNamed):
2460         (-[WebActionMenuController _defaultMenuItemsForLink:]):
2461         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2462
2463         Tags for the action menu items.
2464         * WebView/WebUIDelegatePrivate.h:
2465         * WebView/WebView.mm:
2466
2467         Set the action menu if possible and create the controller.
2468         (-[WebView _initWithFrame:frameName:groupName:]):
2469         (-[WebView _close]):
2470         (-[WebView prepareForMenu:withEvent:]):
2471
2472         WebViewData stores the WebActionMenuHelper
2473         * WebView/WebViewData.h:
2474         * WebView/WebViewData.mm:
2475         (-[WebViewPrivate dealloc]):
2476
2477 2014-10-23  Joseph Pecoraro  <pecoraro@apple.com>
2478
2479         Web Inspector: Provide a way to have alternate inspector agents
2480         https://bugs.webkit.org/show_bug.cgi?id=137901
2481
2482         Reviewed by Brian Burg.
2483
2484         * Configurations/FeatureDefines.xcconfig:
2485
2486 2014-10-23  Tim Horton  <timothy_horton@apple.com>
2487
2488         Add some SPI headers for NSExtension and NSSharingService{Picker}
2489         https://bugs.webkit.org/show_bug.cgi?id=138027
2490
2491         Reviewed by Anders Carlsson.
2492
2493         * Misc/WebSharingServicePickerController.h:
2494         * Misc/WebSharingServicePickerController.mm:
2495         * WebCoreSupport/WebSelectionServiceController.mm:
2496         * WebCoreSupport/WebContextMenuClient.mm:
2497         Fix a sorting issue.
2498         Replace redefinitions with SPI header #imports.
2499
2500 2014-10-23  Tim Horton  <timothy_horton@apple.com>
2501
2502         Crashes under WebSelectionServiceController::hasRelevantSelectionServices
2503         https://bugs.webkit.org/show_bug.cgi?id=138013
2504
2505         Reviewed by Dan Bernstein.
2506
2507         * WebCoreSupport/WebSelectionServiceController.mm:
2508         (WebSelectionServiceController::hasRelevantSelectionServices):
2509         Don't adopt this autoreleased object.
2510
2511 2014-10-22  Chris Dumez  <cdumez@apple.com>
2512
2513         [Mac][WK2] Fix applicationIsSafari() detection
2514         https://bugs.webkit.org/show_bug.cgi?id=137893
2515
2516         Reviewed by Alexey Proskuryakov.
2517
2518         Provide an implementation for FrameLoaderClient's new
2519         needsQuickLookResourceCachingQuirks() that returns
2520         a static flag initialized using
2521         QuickLookMac::computeNeedsQuickLookResourceCachingQuirks().
2522
2523         * WebCoreSupport/WebFrameLoaderClient.h:
2524         * WebCoreSupport/WebFrameLoaderClient.mm:
2525
2526 2014-10-20  Chris Dumez  <cdumez@apple.com>
2527
2528         ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition
2529         https://bugs.webkit.org/show_bug.cgi?id=137797
2530
2531         Reviewed by Darin Adler.
2532
2533         Call ResourceRequest::setDomainForPartitionName() instead of
2534         setPartitionName() as the argument is a domain, not a valid
2535         partition name.
2536
2537         * Misc/WebCache.mm:
2538         (+[WebCache addImageToCache:forURL:forFrame:]):
2539         (+[WebCache removeImageFromCacheForURL:forFrame:]):
2540
2541 2014-10-20  Andy Estes  <aestes@apple.com>
2542
2543         Fix the iOS build.
2544
2545         * WebView/WebFrame.mm:
2546         (-[WebFrame getDictationResultRanges:andMetadatas:]):
2547         (-[WebFrame dictationResultMetadataForRange:]):
2548
2549 2014-10-19  Chris Dumez  <cdumez@apple.com>
2550
2551         Use is<>() / downcast<>() for all remaining RenderObject subclasses
2552         https://bugs.webkit.org/show_bug.cgi?id=137845
2553
2554         Reviewed by Darin Adler.
2555
2556         Use is<>() / downcast<>() for all remaining RenderObject subclasses and 
2557         clean up the surrounding code.
2558
2559         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2560         (-[WebHostedNetscapePluginView pluginHostDied]):
2561         * Plugins/WebBaseNetscapePluginView.mm:
2562         (-[WebBaseNetscapePluginView _windowClipRect]):
2563         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
2564         * WebCoreSupport/WebFrameLoaderClient.mm:
2565         (WebFrameLoaderClient::createPlugin):
2566         (WebFrameLoaderClient::createJavaAppletWidget):
2567
2568 2014-10-17  Tim Horton  <timothy_horton@apple.com>
2569
2570         Build fix for 32-bit Yosemite
2571
2572         * WebCoreSupport/WebContextMenuClient.mm:
2573         (WebContextMenuClient::contextMenuForEvent):
2574         Avoid using NSItemProvider in 32-bit, because it doesn't exist.
2575
2576 2014-10-17  Chris Dumez  <cdumez@apple.com>
2577
2578         Use is<>() / downcast<>() for RenderBox
2579         https://bugs.webkit.org/show_bug.cgi?id=137804
2580
2581         Reviewed by Andreas Kling.
2582
2583         Use is<>() / downcast<>() for RenderBox and clean up the surrounding
2584         code.
2585
2586         * WebCoreSupport/WebContextMenuClient.mm:
2587         (WebContextMenuClient::clientFloatRectForNode):
2588         * WebView/WebFrame.mm:
2589         (-[WebFrame renderedSizeOfNode:constrainedToWidth:]):
2590
2591 2014-10-17  Tim Horton  <timothy_horton@apple.com>
2592
2593         Fix the build with the public SDK.
2594
2595         * WebCoreSupport/WebSelectionServiceController.mm:
2596         We should transition all this SPI to real SPI headers as soon as possible.
2597
2598 2014-10-16  Tim Horton  <timothy_horton@apple.com>
2599
2600         Implement selection services menu for Legacy WebKit
2601         https://bugs.webkit.org/show_bug.cgi?id=137582
2602         <rdar://problem/18604241>
2603
2604         Reviewed by Brady Eidson.
2605
2606         * Misc/WebSharingServicePickerController.h:
2607         Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
2608         Add WebSharingServicePickerClient, which other classes can implement
2609         instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
2610         Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.
2611
2612         * Misc/WebSharingServicePickerController.mm:
2613         Pass in NSSharingServicePickerStyle, so that clients can specify the style.
2614
2615         (-[WebSharingServicePickerController clear]):
2616         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
2617         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
2618         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
2619         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
2620         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2621         Make use of WebSharingServicePickerClient.
2622
2623         (-[WebSharingServicePickerController sharingService:didShareItems:]):
2624         If we're returned a NSAttributedString, paste it on top of the current selection,
2625         similar to what the WebKit2 implementation currently does.
2626         
2627         * WebCoreSupport/WebChromeClient.h:
2628         * WebCoreSupport/WebChromeClient.mm:
2629         (WebChromeClient::handleTelephoneNumberClick):
2630         (WebChromeClient::handleSelectionServiceClick):
2631         (WebChromeClient::hasRelevantSelectionServices):
2632         Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.
2633
2634         * WebCoreSupport/WebContextMenuClient.h:
2635         * WebCoreSupport/WebContextMenuClient.mm:
2636         (WebContextMenuClient::sharingServicePickerWillBeDestroyed):
2637         (WebContextMenuClient::pageForSharingServicePicker):
2638         (WebContextMenuClient::windowForSharingServicePicker):
2639         (WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
2640         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
2641         (WebContextMenuClient::contextMenuForEvent):
2642         (WebContextMenuClient::screenRectForHitTestNode): Deleted.
2643         (WebContextMenuClient::renderedImageForControlledImage): Deleted.
2644         (WebContextMenuClient::clearSharingServicePickerController): Deleted.
2645         Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
2646         having WebSharingServicePickerController tightly bound to it.
2647         Make an NSItemProvider array when instantiating WebSharingServicePickerController
2648         instead of handing it data directly.
2649
2650         * WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
2651         * WebCoreSupport/WebSelectionServiceController.mm: Added.
2652         (WebSelectionServiceController::WebSelectionServiceController):
2653         Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
2654         for selection services.
2655
2656         (WebSelectionServiceController::handleSelectionServiceClick):
2657         Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.
2658
2659         (hasCompatibleServicesForItems):
2660         (WebSelectionServiceController::hasRelevantSelectionServices):
2661         Determine whether or not services are available.
2662
2663         (WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
2664         (WebSelectionServiceController::pageForSharingServicePicker):
2665         (WebSelectionServiceController::windowForSharingServicePicker):
2666         Implement the rest of the WebSharingServicePickerClient overrides.
2667
2668         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
2669         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
2670         These are only useful for image sharing services, so we don't need to
2671         implement them (WebContextMenuClient does, on the other hand).
2672
2673         * WebView/WebView.mm:
2674         (-[WebView _selectionServiceController]):
2675         * WebView/WebViewData.h:
2676         * WebView/WebViewData.mm:
2677         * WebView/WebViewInternal.h:
2678         Keep a WebSelectionServiceController.
2679
2680 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2681
2682         Improve debug description of WAKViews
2683         https://bugs.webkit.org/show_bug.cgi?id=137716
2684
2685         Reviewed by Simon Fraser.
2686
2687         * WebView/WebView.mm:
2688         (-[WebView _touchEventRegions]): Adding a comment.
2689
2690 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2691
2692         Addressing post-review comment.
2693         https://bugs.webkit.org/show_bug.cgi?id=137550
2694
2695         Unreviewed.
2696
2697         * WebView/WebHTMLView.mm:
2698         (fontNameForDescription):
2699         (-[WebHTMLView _addToStyle:fontA:fontB:]):
2700
2701 2014-10-14  Chris Dumez  <cdumez@apple.com>
2702
2703         Use is<>() / downcast<>() for RenderImage
2704         https://bugs.webkit.org/show_bug.cgi?id=137683
2705
2706         Reviewed by Mihnea Ovidenie.
2707
2708         Use is<>() / downcast<>() for RenderImage.
2709
2710         * Misc/WebNSPasteboardExtras.mm:
2711         (imageFromElement):
2712         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2713
2714 2014-10-10  Daniel Bates  <dabates@apple.com>
2715
2716         Remove unused classes WebRender{Node, Layer}
2717         https://bugs.webkit.org/show_bug.cgi?id=137628
2718
2719         Reviewed by Simon Fraser.
2720
2721         We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
2722         For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.
2723
2724         * Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list
2725         of excluded source files when building for iOS.
2726         * WebKit.exp: Remove symbol for WebRenderLayer.
2727         * WebKit.mac.exp: Remove symbol for WebRenderNode.
2728         * WebView/WebRenderLayer.h: Removed.
2729         * WebView/WebRenderLayer.mm: Removed.
2730         * WebView/WebRenderNode.h: Removed.
2731         * WebView/WebRenderNode.mm: Removed.
2732
2733 2014-10-10  Chris Dumez  <cdumez@apple.com>
2734
2735         Use is<>() / downcast<>() for RenderBoxModelObject
2736         https://bugs.webkit.org/show_bug.cgi?id=137587
2737
2738         Reviewed by Mihnea Ovidenie.
2739
2740         Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
2741         surrounding code.
2742
2743         * Plugins/WebBaseNetscapePluginView.mm:
2744         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
2745         * WebView/WebRenderLayer.mm:
2746         (-[WebRenderLayer initWithWebFrame:]):
2747
2748 2014-10-09  Dean Jackson  <dino@apple.com>
2749
2750         Remove ENABLE_CSS3_CONDITIONAL_RULES
2751         https://bugs.webkit.org/show_bug.cgi?id=137571
2752
2753         Reviewed by Simon Fraser.
2754
2755         * Configurations/FeatureDefines.xcconfig:
2756
2757 2014-10-09  Tim Horton  <timothy_horton@apple.com>
2758
2759         Add a WebKit1 preference for selection services
2760         https://bugs.webkit.org/show_bug.cgi?id=137498
2761         <rdar://problem/18572699>
2762
2763         Reviewed by Simon Fraser.
2764
2765         * WebView/WebPreferenceKeysPrivate.h:
2766         * WebView/WebPreferences.mm:
2767         (+[WebPreferences initialize]):
2768         (-[WebPreferences serviceControlsEnabled]):
2769         (-[WebPreferences setServiceControlsEnabled:]):
2770         * WebView/WebPreferencesPrivate.h:
2771         * WebView/WebView.mm:
2772         (-[WebView _preferencesChanged:]):
2773         Add and plumb the preference.
2774
2775 2014-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
2776
2777         Remove second-to-last client of WebFontCache
2778         https://bugs.webkit.org/show_bug.cgi?id=137550
2779
2780         Reviewed by Darin Adler.
2781
2782         Use FontCache::getCachedFontData() instead of WebFontCache.
2783
2784         * WebView/WebHTMLView.mm:
2785         (-[WebHTMLView _addToStyle:fontA:fontB:]):
2786
2787 2014-10-09  Chris Dumez  <cdumez@apple.com>
2788
2789         Use is<>() / downcast<>() for Widget subclasses
2790         https://bugs.webkit.org/show_bug.cgi?id=137549
2791
2792         Reviewed by Darin Adler.
2793
2794         Use is<>() / downcast<>() for Widget subclasses and clean up the
2795         surrounding code.
2796
2797         * WebView/WebRenderNode.mm:
2798         (copyRenderNode):
2799         * WebView/WebView.mm:
2800         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
2801
2802 2014-10-07  Christophe Dumez  <cdumez@apple.com>
2803
2804         Use is<>() / downcast<>() for RenderText / RenderTextFragment
2805         https://bugs.webkit.org/show_bug.cgi?id=137476
2806
2807         Reviewed by Darin Adler.
2808
2809         * WebView/WebRenderNode.mm:
2810         (copyRenderNode):
2811
2812 2014-10-06  Dan Bernstein  <mitz@apple.com>
2813
2814         Build fix.
2815
2816         * Misc/WebCache.mm:
2817         (+[WebCache imageForURL:]):
2818
2819 2014-10-06  Chris Dumez  <cdumez@apple.com>
2820
2821         Unreviewed build fix after r174333.
2822
2823         Forgot explicit WebCore:: namespace.
2824
2825         * Misc/WebCache.mm:
2826         (+[WebCache imageForURL:]):
2827
2828 2014-10-05  Christophe Dumez  <cdumez@apple.com>
2829
2830         Use is<>() / downcast<>() for CachedResource subclasses
2831         https://bugs.webkit.org/show_bug.cgi?id=137431
2832
2833         Reviewed by Benjamin Poulain.
2834
2835         Use is<>() / downcast<>() for CachedResource subclasses.
2836
2837         * Misc/WebCache.mm:
2838         (+[WebCache imageForURL:]):
2839
2840 2014-10-02  Daniel Bates  <dabates@apple.com>
2841
2842         Use version number 101000 instead of 10100 for OS X Yosemite
2843         https://bugs.webkit.org/show_bug.cgi?id=137372
2844
2845         Reviewed by Mark Rowe.
2846
2847         The version number for OS X Yosemite is 101000.
2848
2849         * WebView/WebView.mm:
2850         (-[WebView _preferencesChanged:]):
2851
2852 2014-10-02  Tim Horton  <timothy_horton@apple.com>
2853
2854         Move PageOverlay[Controller] to WebCore
2855         https://bugs.webkit.org/show_bug.cgi?id=137164
2856         <rdar://problem/18508258>
2857
2858         Reviewed by Anders Carlsson.
2859
2860         * WebCoreSupport/WebChromeClient.h:
2861         * WebCoreSupport/WebChromeClient.mm:
2862         (WebChromeClient::attachViewOverlayGraphicsLayer):
2863         Add an empty ChromeClient override.
2864
2865 2014-10-01  Christophe Dumez  <cdumez@apple.com>
2866
2867         Have is<>(T*) function do a null check on the pointer argument
2868         https://bugs.webkit.org/show_bug.cgi?id=137333
2869
2870         Reviewed by Gavin Barraclough.
2871
2872         Have is<>(T*) function do a null check on the argument instead of a
2873         simple assertion. This makes sense for 2 reasons:
2874         1. It is more consistent with downcast<>(T*), which will succeed even
2875            if the argument is a nullptr.
2876         2. It simplifies the code a bit as it gets rid of a lot of explicit
2877            null checks.
2878
2879         * WebCoreSupport/WebChromeClient.mm:
2880         (WebChromeClient::focusedElementChanged):
2881         * WebCoreSupport/WebEditorClient.mm:
2882         (WebEditorClient::textFieldDidBeginEditing):
2883         (WebEditorClient::textFieldDidEndEditing):
2884         (WebEditorClient::textDidChangeInTextField):
2885         (WebEditorClient::doTextFieldCommandFromEvent):
2886         (WebEditorClient::textWillBeDeletedInTextField):
2887         (WebEditorClient::textDidChangeInTextArea):
2888         * WebView/WebHTMLRepresentation.mm:
2889         (inputElementFromDOMElement):
2890         (searchForLabelsBeforeElement):
2891         * WebView/WebRenderLayer.mm:
2892         (+[WebRenderLayer nameForLayer:]):
2893
2894 2014-10-01  Mark Rowe  <mrowe@apple.com>
2895
2896         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
2897
2898         Reviewed by Dan Bernstein.
2899
2900         * Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite.
2901
2902 2014-09-30  Chris Dumez  <cdumez@apple.com>
2903
2904         Use is<>() / downcast<>() for Element
2905         https://bugs.webkit.org/show_bug.cgi?id=137241
2906
2907         Reviewed by Andreas Kling.
2908
2909         Use is<>() / downcast<>() for Element instead of isElementNode() /
2910         toElement().
2911
2912         * WebView/WebRenderLayer.mm:
2913         (+[WebRenderLayer nameForLayer:]):
2914
2915 2014-09-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2916
2917         Move ColorInputType class to std::unique_ptr
2918         https://bugs.webkit.org/show_bug.cgi?id=137173
2919
2920         Reviewed by Darin Adler.
2921
2922         Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr.
2923         Child classes follow this change as well.
2924
2925         * WebCoreSupport/WebChromeClient.h:
2926         * WebCoreSupport/WebChromeClient.mm:
2927         (WebChromeClient::createColorChooser):
2928
2929 2014-09-24  Christophe Dumez  <cdumez@apple.com>
2930
2931         Add initial is<>() / downcast<>() support for any type of Nodes
2932         https://bugs.webkit.org/show_bug.cgi?id=137056
2933
2934         Reviewed by Benjamin Poulain.
2935
2936         Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
2937         instead of isFormControlElement() / toHTMLFormControlElement().
2938
2939         * WebView/WebHTMLRepresentation.mm:
2940         (searchForLabelsBeforeElement):
2941
2942 2014-09-24  Christophe Dumez  <cdumez@apple.com>
2943
2944         Use is<HTML*Element>() instead of isHTML*Element() - Part 1
2945         https://bugs.webkit.org/show_bug.cgi?id=137068
2946
2947         Reviewed by Ryosuke Niwa.
2948
2949         Start using is<HTML*Element>() instead of isHTML*Element().
2950         Remaining usages will be updated in a follow-up patch to
2951         reduce the size of the change.
2952
2953         * WebCoreSupport/WebChromeClient.mm:
2954         (WebChromeClient::focusedElementChanged):
2955         * WebCoreSupport/WebEditorClient.mm:
2956         (WebEditorClient::textFieldDidBeginEditing):
2957         (WebEditorClient::textFieldDidEndEditing):
2958         (WebEditorClient::textDidChangeInTextField):
2959         (WebEditorClient::doTextFieldCommandFromEvent):
2960         (WebEditorClient::textWillBeDeletedInTextField):
2961         (WebEditorClient::textDidChangeInTextArea):
2962         * WebView/WebHTMLRepresentation.mm:
2963         (inputElementFromDOMElement):
2964
2965 2014-09-21  Timothy Hatcher  <timothy@apple.com>
2966
2967         Make the Web Inspector use a separate web process.
2968
2969         https://bugs.webkit.org/show_bug.cgi?id=135120
2970
2971         Reviewed by Anders Carlsson.
2972
2973         * WebCoreSupport/WebInspectorClient.h:
2974         * WebCoreSupport/WebInspectorClient.mm:
2975         (WebInspectorClient::WebInspectorClient):
2976         (WebInspectorClient::openInspectorFrontend):
2977         (WebInspectorClient::releaseFrontend):
2978         Own WebInspectorFrontendClient instead of moving it.
2979
2980 2014-09-23  Chris Dumez  <cdumez@apple.com>
2981
2982         Use downcast<HTML*Element>() instead of toHTML*Element()
2983         https://bugs.webkit.org/show_bug.cgi?id=137007
2984
2985         Reviewed by Benjamin Poulain.
2986
2987         Use downcast<HTML*Element>() instead of toHTML*Element().
2988
2989         * DOM/WebDOMOperations.mm:
2990         (-[DOMHTMLInputElement _setAutofilled:]):
2991         * WebCoreSupport/WebChromeClient.mm:
2992         (WebChromeClient::focusedElementChanged):
2993         * WebCoreSupport/WebEditorClient.mm:
2994         (WebEditorClient::textFieldDidBeginEditing):
2995         (WebEditorClient::textFieldDidEndEditing):
2996         (WebEditorClient::textDidChangeInTextField):
2997         (WebEditorClient::doTextFieldCommandFromEvent):
2998         (WebEditorClient::textWillBeDeletedInTextField):
2999         (WebEditorClient::textDidChangeInTextArea):
3000         * WebView/WebHTMLRepresentation.mm:
3001         (inputElementFromDOMElement):
3002
3003 2014-09-21  Chris Dumez  <cdumez@apple.com>
3004
3005         Generate Element casting helper functions
3006         https://bugs.webkit.org/show_bug.cgi?id=136839
3007
3008         Reviewed by Darin Adler.
3009
3010         Use JSXXX::toWrapped() instead of toXXX() function.
3011
3012         * DOM/WebDOMOperations.mm:
3013         * WebView/WebView.mm:
3014         (-[WebView _notificationIDForTesting:]):
3015
3016 2014-09-21  Joseph Pecoraro  <pecoraro@apple.com>
3017
3018         Leak: WebNotificationPrivate ObjC leaks seen on leaks bot
3019         https://bugs.webkit.org/show_bug.cgi?id=136972
3020
3021         Reviewed by Darin Adler.
3022
3023         * WebView/WebNotification.h:
3024         * WebView/WebNotification.mm:
3025         (-[WebNotification initWithCoreNotification:notificationID:]):
3026         Switch to RetainPtr and adopt into _private to ensure when we are
3027         deallocated that _private will get deallocated.
3028
3029 2014-09-19  Dean Jackson  <dino@apple.com>
3030
3031         Multithreaded WebGL is a bad idea - remove it
3032         https://bugs.webkit.org/show_bug.cgi?id=136964
3033         <rdar://problem/18399858>
3034
3035         Reviewed by Brent Fulgham.
3036
3037         Remove the setting to allow multithreaded WebGL.
3038
3039         * WebView/WebPreferenceKeysPrivate.h:
3040         * WebView/WebPreferences.mm:
3041         (+[WebPreferences initialize]):
3042         (-[WebPreferences multithreadedWebGLEnabled]): Deleted.
3043         (-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted.
3044         * WebView/WebPreferencesPrivate.h:
3045         * WebView/WebView.mm:
3046         (-[WebView _preferencesChanged:]):
3047
3048 2014-09-19  Daniel Bates  <dabates@apple.com>
3049
3050         Always assume internal SDK when building configuration Production
3051         https://bugs.webkit.org/show_bug.cgi?id=136925
3052         <rdar://problem/18362399>
3053
3054         Reviewed by Dan Bernstein.
3055
3056         As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
3057         and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.
3058
3059         * Configurations/Base.xcconfig:
3060
3061 2014-09-17  Daniel Bates  <dabates@apple.com>
3062
3063         Unreviewed, rolling out r173695.
3064
3065         Broke building third-party Legacy WebKit apps; will
3066         investigate offline
3067
3068         Reverted changeset:
3069
3070         "[iOS] Make WebCore build with public iOS SDK"
3071         https://bugs.webkit.org/show_bug.cgi?id=136487
3072         http://trac.webkit.org/changeset/173695
3073
3074 2014-09-17  Daniel Bates  <dabates@apple.com>
3075
3076         [iOS] Make WebCore build with public iOS SDK
3077         https://bugs.webkit.org/show_bug.cgi?id=136487
3078
3079         Reviewed by David Kilzer.
3080
3081         Update WebKit1 source files to include the wrapper SPI headers instead of the corresponding
3082         actual SPI header(s).
3083
3084         * DOM/WebDOMOperationsPrivate.h:
3085         * MigrateHeaders.make: Modified to only modify the include path of a "<WebCore/"-prefixed header
3086         file if its filename doesn't end in "SPI.h" as an alternative to having MigrateHeaders.make copy
3087         such files into the WebKit framework as private headers.
3088         * WebCoreSupport/WebFrameLoaderClient.mm:
3089         * WebInspector/WebNodeHighlight.mm:
3090         * WebView/WebIndicateLayer.mm:
3091         * WebView/WebRenderLayer.h:
3092         * WebView/WebView.mm:
3093
3094 2014-09-16  Daniel Bates  <dabates@apple.com>
3095
3096         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
3097         https://bugs.webkit.org/show_bug.cgi?id=136862
3098
3099         Reviewed by David Kilzer.
3100
3101         * Configurations/DebugRelease.xcconfig:
3102
3103 2014-09-16  Enrica Casucci  <enrica@apple.com>
3104
3105         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
3106         https://bugs.webkit.org/show_bug.cgi?id=136474
3107
3108         Reviewed by Benjamin Poulain.
3109
3110         This is the updated version of the patch that was landed in r173340.
3111         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
3112         and removes the assumption that EAffinity values match NSSelectionAffinity
3113         values. It also removes the includes in TextAffinity.h, creating the need to
3114         include explicitly the files when necessary.
3115
3116         * WebCoreSupport/WebEditorClient.h:
3117         (kit):
3118         (core):
3119
3120 2014-09-14  Daniel Bates  <dabates@apple.com>
3121
3122         [iOS] Attempt to fix the iOS build after <http://trac.webkit.org/changeset/173606>
3123         (https://bugs.webkit.org/show_bug.cgi?id=136789)
3124
3125         Substitute Node::countChildNodes() for Node::childNodeCount() in more places.
3126
3127         * WebView/WebFrame.mm:
3128         (-[WebFrame focusedNodeHasContent]):
3129
3130 2014-09-14  Chris Dumez  <cdumez@apple.com>
3131
3132         Rename Node::childNodeCount() to countChildNodes() and avoid inefficient uses
3133         https://bugs.webkit.org/show_bug.cgi?id=136789
3134
3135         Reviewed by Darin Adler.
3136
3137         Rename childNodeCount() to countChildNodes().
3138
3139         * WebView/WebHTMLView.mm:
3140         (-[WebHTMLView attributedString]):
3141
3142 2014-09-10  Jon Honeycutt  <jhoneycutt@apple.com>
3143
3144         Re-add the request autocomplete feature
3145
3146         <https://bugs.webkit.org/show_bug.cgi?id=136730>
3147
3148         This feature was rolled out in r148731 because it was only used by
3149         Chromium. As we consider supporting this feature, roll it back in, but
3150         leave it disabled.
3151
3152         This rolls out r148731 (which removed the feature) with small changes
3153         needed to make the code build in ToT, to match modern style, to make
3154         the tests run, and to remove unused code.
3155
3156         Reviewed by Andy Estes.
3157
3158         * Configurations/FeatureDefines.xcconfig:
3159         * WebCoreSupport/WebFrameLoaderClient.h:
3160
3161 2014-09-12  Commit Queue  <commit-queue@webkit.org>
3162
3163         Unreviewed, rolling out r173575.
3164         https://bugs.webkit.org/show_bug.cgi?id=136790
3165
3166         Failing tests (Requested by enrica on #webkit).
3167
3168         Reverted changeset:
3169
3170         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
3171         https://bugs.webkit.org/show_bug.cgi?id=136474
3172         http://trac.webkit.org/changeset/173575
3173
3174 2014-09-12  Enrica Casucci  <enrica@apple.com>
3175
3176         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
3177         https://bugs.webkit.org/show_bug.cgi?id=136474
3178
3179         Reviewed by Benjamin Poulain.
3180
3181         This is the updated version of the patch that was landed in r173340.
3182         I changed the use of IntPoint to FloatPoint since it was causing tests
3183         to fail.
3184         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
3185         and removes the assumption that EAffinity values match NSSelectionAffinity
3186         values. It also removes the includes in TextAffinity.h, creating the need to
3187         include explicitly the files when necessary. It also removes the unnecessary
3188         use of platform specific types, replacing them with WebCore types.
3189
3190         * WebCoreSupport/WebEditorClient.h:
3191         (kit):
3192         (core):
3193         * WebView/WebFrameView.mm:
3194         (-[WebFrameView _scrollToBeginningOfDocument]):
3195         (-[WebFrameView _scrollToEndOfDocument]):
3196
3197 2014-09-11  Bear Travis  <betravis@adobe.com>
3198
3199         [CSS Font Loading] Enable CSS Font Loading on Mac
3200         https://bugs.webkit.org/show_bug.cgi?id=135473
3201
3202         Reviewed by Antti Koivisto.
3203
3204         Enable CSS Font Loading in FeatureDefines.
3205
3206         * Configurations/FeatureDefines.xcconfig:
3207
3208 2014-09-11  Beth Dakin  <bdakin@apple.com>
3209
3210         Support rubber-banding in sub-frames
3211         https://bugs.webkit.org/show_bug.cgi?id=136726
3212         -and corresponding-
3213         rdar://problem/10011924
3214
3215         Reviewed by Tim Horton.
3216
3217         rubberBandingForOverflowScrollEnabled is re-named to
3218         rubberBandingForSubScrollableRegionsEnabled
3219         * WebView/WebView.mm:
3220         (-[WebView _preferencesChanged:]):
3221
3222 2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
3223
3224         Disable the "unreachable-code" warning
3225         https://bugs.webkit.org/show_bug.cgi?id=136677
3226
3227         Reviewed by Darin Adler.
3228
3229         * Configurations/Base.xcconfig:
3230
3231 2014-09-08  Maciej Stachowiak  <mjs@apple.com>
3232
3233         Fix 32-bit Mac build for new warnings
3234         https://bugs.webkit.org/show_bug.cgi?id=136624
3235
3236         Reviewed by Darin Adler.
3237         
3238         (Jessie already fixed this but my version with typedefs seems a tiny bit cleaner.)
3239
3240         * Carbon/HIViewAdapter.m:
3241         (+[HIViewAdapter bindHIViewToNSView:nsView:]): Need to use explicit casting now.
3242
3243 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3244
3245         Remove FILTERS flag
3246         https://bugs.webkit.org/show_bug.cgi?id=136571
3247
3248         Reviewed by Darin Adler.
3249
3250         * Configurations/FeatureDefines.xcconfig:
3251
3252 2014-09-08  Jessie Berlin  <jberlin@apple.com>
3253
3254         32-bit build fix after r173364.
3255
3256         * Carbon/HIViewAdapter.m:
3257         (+[HIViewAdapter bindHIViewToNSView:nsView:]):
3258
3259 2014-09-08  Dan Bernstein  <mitz@apple.com>
3260
3261         Build fix.
3262
3263         Added back SPI that is still in use.
3264
3265         * Misc/WebNSURLExtras.h:
3266         * Misc/WebNSURLExtras.mm:
3267         (-[NSURL _webkit_URLByRemovingFragment]):
3268
3269 2014-09-08  Dan Bernstein  <mitz@apple.com>
3270
3271         iOS Simulator build fix.
3272
3273         * Misc/WebKitSystemBits.m:
3274         (WebMemorySize):
3275
3276 2014-09-07  Darin Adler  <darin@apple.com>
3277
3278         Fix build failure seen on Mountain Lion buildbot.
3279
3280         * Misc/WebNSDataExtras.h: Make WEB_GUESS_MIME_TYPE_PEEK_LENGTH an unsigned instead
3281         of an int, to avoid warning about mixing signs.
3282
3283 2014-09-06  Darin Adler  <darin@apple.com>
3284
3285         Make updates suggested by new version of Xcode
3286         https://bugs.webkit.org/show_bug.cgi?id=136603
3287
3288         Reviewed by Mark Rowe.
3289
3290         * Configurations/Base.xcconfig: Added CLANG_WARN_UNREACHABLE_CODE, COMBINE_HIDPI_IMAGES,
3291         and ENABLE_STRICT_OBJC_MSGSEND as suggested by Xcode upgrade check.
3292
3293         * History/WebURLsWithTitles.m:
3294         (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): Use NSUInteger instead of
3295         unsigned for correctness, and to quiet the 32-to-64-bit compiler warning (which is
3296         not turned on because it gives us too many false positives).
3297         * Misc/WebElementDictionary.mm:
3298         (-[WebElementDictionary objectForKey:]): Ditto.
3299         * Misc/WebNSDataExtras.m:
3300         (-[NSData _webkit_guessedMIMETypeForXML]): Ditto.
3301         (-[NSData _webkit_guessedMIMEType]): Ditto.
3302         (-[NSData _webkit_parseRFC822HeaderFields]): Ditto.
3303         (-[NSData _web_locationAfterFirstBlankLine]): Ditto.
3304
3305         * Misc/WebNSURLExtras.h: Removed unused _web_URLWithLowercasedScheme, _web_hostData,
3306         _webkit_URLByRemovingFragment, _webkit_URLByRemovingResourceSpecifier, _webkit_isFTPDirectoryURL,
3307         _webkit_shouldLoadAsEmptyDocument, _web_hostNameNeedsDecodingWithRange:,
3308         _web_hostNameNeedsEncodingWithRange:, _web_decodeHostNameWithRange:, _web_encodeHostNameWithRange:,
3309         and _webkit_URLFragment methods.
3310
3311         * Misc/WebNSURLExtras.mm:
3312         (-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): Deleted.
3313         (-[NSURL _webkit_URLByRemovingFragment]): Deleted.
3314         (-[NSURL _webkit_URLByRemovingResourceSpecifier]): Deleted.
3315         (-[NSURL _webkit_isFTPDirectoryURL]): Deleted.
3316         (-[NSURL _webkit_shouldLoadAsEmptyDocument]): Deleted.
3317         (-[NSURL _web_URLWithLowercasedScheme]): Deleted.
3318         (-[NSString _webkit_isFTPDirectoryURL]): Deleted.
3319         (-[NSString _web_hostNameNeedsDecodingWithRange:]): Deleted.
3320         (-[NSString _web_hostNameNeedsEncodingWithRange:]): Deleted.
3321         (-[NSString _web_decodeHostNameWithRange:]): Deleted.
3322         (-[NSString _web_encodeHostNameWithRange:]): Deleted.
3323         (-[NSString _webkit_URLFragment]): Deleted.
3324
3325         * Plugins/WebPluginDatabase.mm:
3326         (-[WebPluginDatabase removePluginInstanceViewsFor:]): Use a modern for loop
3327         to iterate an array instead of a loop using the type "unsigned int".
3328
3329         * WebCoreSupport/WebOpenPanelResultListener.mm:
3330         (-[WebOpenPanelResultListener chooseFilenames:]): Use NSUInteger instead of int.
3331
3332         * WebView/WebDelegateImplementationCaching.mm:
3333         (CallDelegate): Use wtfCallIMP in one overload that was instead just calling the
3334         directly without a proper type for the function pointer. This might have been causing
3335         an actual problem on 64-bit systems, and it was different from all the other CallDelegate
3336         functions that were already doing this correctly.
3337
3338         * WebView/WebTextCompletionController.mm:
3339         (-[WebTextCompletionController _placePopupWindow:]): Use NSUInteger instead of int.
3340
3341 2014-09-06  Brian J. Burg  <burg@cs.washington.edu>
3342
3343         Web Inspector: convert DockSide to an enum class
3344         https://bugs.webkit.org/show_bug.cgi?id=136601
3345
3346         Reviewed by Timothy Hatcher.
3347
3348         * WebCoreSupport/WebInspectorClient.mm:
3349         (WebInspectorFrontendClient::frontendLoaded):
3350         (-[WebInspectorWindowController attachWindow:]):
3351         (-[WebInspectorWindowController attach]):
3352         (-[WebInspectorWindowController detach]):
3353         * WebInspector/WebInspectorFrontend.mm:
3354         (-[WebInspectorFrontend attach]):
3355
3356 2014-09-05  Commit Queue  <commit-queue@webkit.org>
3357
3358         Unreviewed, rolling out r173340 and r173342.
3359         https://bugs.webkit.org/show_bug.cgi?id=136596
3360
3361         Broke many tests (Requested by ap on #webkit).
3362
3363         Reverted changesets:
3364
3365         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
3366         https://bugs.webkit.org/show_bug.cgi?id=136474
3367         http://trac.webkit.org/changeset/173340
3368
3369         "Build fix after r173340."
3370         http://trac.webkit.org/changeset/173342
3371
3372 2014-09-05  Enrica Casucci  <enrica@apple.com>
3373
3374         Build fix after r173340.
3375
3376         * WebCoreSupport/WebEditorClient.h:
3377         (kit):
3378         (core):
3379
3380 2014-09-05  Enrica Casucci  <enrica@apple.com>
3381
3382         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
3383         https://bugs.webkit.org/show_bug.cgi?id=136474
3384
3385         Reviewed by Benjamin Poulain.
3386
3387         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
3388         and removes the assumption that EAffinity values match NSSelectionAffinity
3389         values. It also removes the includes in TextAffinity.h, creating the need to
3390         include explicitly the files when necessary. It also removes the unnecessary
3391         use of platform specific types, replacing them with WebCore types.
3392
3393         * WebCoreSupport/WebEditorClient.h: Added kit and core for EAffinity.
3394         * WebView/WebFrameView.mm:
3395         (-[WebFrameView _scrollToBeginningOfDocument]):
3396         (-[WebFrameView _scrollToEndOfDocument]):
3397
3398 2014-09-05  Daniel Bates  <dabates@apple.com>
3399
3400         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
3401         (https://bugs.webkit.org/show_bug.cgi?id=136564)
3402
3403         Move #endif inside -viewDidMoveToWindow up one line such that the closing brace ('}') is after it.
3404
3405         * WebView/WebHTMLView.mm:
3406         (-[WebHTMLView viewDidMoveToWindow]):
3407
3408 2014-09-05  Daniel Bates  <dabates@apple.com>
3409
3410         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
3411         (https://bugs.webkit.org/show_bug.cgi?id=136564)
3412
3413         Add !PLATFORM(IOS)-guard in -viewDidMoveToWindow around code that references WebHTMLViewPrivate.flagsChangedEventMonitor.
3414         The instance variable WebHTMLViewPrivate.flagsChangedEventMonitor is guarded by !PLATFORM(IOS).
3415
3416         * WebView/WebHTMLView.mm:
3417         (-[WebHTMLView viewDidMoveToWindow]):
3418
3419 2014-09-05  Daniel Bates  <dabates@apple.com>
3420
3421         [iOS] Fix the iOS build after <http://trac.webkit.org/changeset/173309>
3422         (https://bugs.webkit.org/show_bug.cgi?id=136564)
3423
3424         Include more code inside the !PLATFORM(IOS)-guarded section in -setDataSource:.
3425
3426         * WebView/WebHTMLView.mm:
3427         (-[WebHTMLView setDataSource:]):
3428
3429 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
3430
3431         Use tracking areas instead of (SPI) mouse moved notifications, and follow flags changes with an event monitor
3432         https://bugs.webkit.org/show_bug.cgi?id=136564
3433
3434         Reviewed by Dan Bernstein.
3435         
3436         WebKit1 depended on mouse moved event notifications to track mouse
3437         moves, and on being specially called by Safari to track flags
3438         changes. WebKit2 does both these things better - it uses a tracking area
3439         and event monitors. Copy those approaches.
3440
3441         * WebKit.order: Remove reference to obsolete call.
3442         * WebView/WebHTMLView.mm:
3443         (-[WebHTMLViewPrivate dealloc]): No need to deallocate tracking
3444         area, since we now just always have one.
3445         (-[WebHTMLViewPrivate clear]): ditto
3446         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
3447         New method that posts a fake mouse move event in response to
3448         a flags change event, for use by the event monitor.
3449         (+[WebHTMLView _postFlagsChangedEvent:]): Empty this old call,
3450         still kept around for benefit of older Safari.
3451         (-[WebHTMLView _updateMouseoverWithEvent:]): Handle Dashboard's
3452         special mouseover mode (previously handled in a weird way).
3453         (-[WebHTMLView close]): No more need to mess with mouse moved observer.
3454         (-[WebHTMLView viewWillMoveToWindow:]): ditto
3455         (-[WebHTMLView viewDidMoveToWindow]): ditto; but now hook up a flags
3456         changed monitor.
3457         (-[WebHTMLView windowDidBecomeKey:]): No need to handle non-key window
3458         tracking area or mouse moved observer.
3459         (-[WebHTMLView windowDidResignKey:]): ditto
3460         (-[WebHTMLView windowWillOrderOnScreen:]): No need to mess with mouse
3461         moved observer.
3462         (-[WebHTMLView windowWillOrderOffScreen:]): ditto
3463         (-[WebHTMLView mouseMoved:]): Converted from the old mouseMovedNotification:
3464         (-[WebHTMLView setDataSource:]): Change if around body to early return. Hook
3465         up tracking area - we have to do it here, because before this point, the
3466         WebHTMLView does not know its WebView, which is where dashboard settings
3467         live.
3468         (-[WebHTMLView _removeMouseMovedObserverUnconditionally]): Deleted.
3469         (-[WebHTMLView addMouseMovedObserver]): Deleted.
3470         (-[WebHTMLView removeMouseMovedObserver]): Deleted.
3471
3472 2014-09-04  Pratik Solanki  <psolanki@apple.com>
3473
3474         Bring back [WebPreferences setDiskImageCacheEnabled:] for backwards compatibility
3475         https://bugs.webkit.org/show_bug.cgi?id=136560
3476
3477         Reviewed by Joseph Pecoraro.
3478
3479         I removed the disk image caching code in r173265. However, we still have clients that call
3480         setDiskImageCacheEnabled. Add in a stub method until we can wean the clients off this call.
3481
3482         * WebView/WebPreferences.mm:
3483         (-[WebPreferences setDiskImageCacheEnabled:]):
3484         * WebView/WebPreferencesPrivate.h:
3485
3486 2014-09-03  Andy Estes  <aestes@apple.com>
3487
3488         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
3489         https://bugs.webkit.org/show_bug.cgi?id=136521
3490
3491         Reviewed by Anders Carlsson.
3492
3493         Taught MigrateHeaders.make to remove WEBCORE_EXPORT from headers using this sed expression:
3494
3495             s/(^ *)WEBCORE_EXPORT /\1/g
3496
3497         This removes WEBCORE_EXPORT and a single following space character but preserves preceeding spaces.
3498
3499         * MigrateHeaders.make:
3500
3501 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
3502
3503         Remove WebCoreSystemInterface glue for otherwise unused WKSI calls
3504         https://bugs.webkit.org/show_bug.cgi?id=136527
3505
3506         Reviewed by Alexey Proskuryakov.
3507
3508         * WebCoreSupport/WebSystemInterface.mm:
3509         (InitWebCoreSystemInterface):
3510
3511 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3512
3513         Remove CSS_FILTERS flag
3514         https://bugs.webkit.org/show_bug.cgi?id=136529
3515
3516         Reviewed by Dirk Schulze.
3517
3518         * Configurations/FeatureDefines.xcconfig:
3519
3520 2014-09-04  Pratik Solanki  <psolanki@apple.com>
3521
3522         Remove iOS specific disk image cache
3523         https://bugs.webkit.org/show_bug.cgi?id=136517
3524
3525         Reviewed by Antti Koivisto.
3526
3527         Disk image cache code unnecessarily complicates SharedBuffer implementation. We can remove
3528         this now since we don't enable it in WebKit2 on iOS.
3529
3530         * Misc/WebCache.mm:
3531         (+[WebCache statistics]):
3532         * WebView/WebDataSource.mm:
3533         (-[WebDataSource _setAllowToBeMemoryMapped]):
3534         (-[WebDataSource setDataSourceDelegate:]):
3535         (-[WebDataSource dataSourceDelegate]):
3536         (-[WebDataSource dealloc]):
3537         (BufferMemoryMapped): Deleted.
3538         * WebView/WebPreferenceKeysPrivate.h:
3539         * WebView/WebPreferences.mm:
3540         (+[WebPreferences initialize]):
3541         (-[WebPreferences diskImageCacheEnabled]): Deleted.
3542         (-[WebPreferences setDiskImageCacheEnabled:]): Deleted.
3543         (-[WebPreferences diskImageCacheMinimumImageSize]): Deleted.
3544         (-[WebPreferences setDiskImageCacheMinimumImageSize:]): Deleted.
3545         (-[WebPreferences diskImageCacheMaximumCacheSize]): Deleted.
3546         (-[WebPreferences setDiskImageCacheMaximumCacheSize:]): Deleted.
3547         (-[WebPreferences _diskImageCacheSavedCacheDirectory]): Deleted.
3548         (-[WebPreferences _setDiskImageCacheSavedCacheDirectory:]): Deleted.
3549         * WebView/WebPreferencesPrivate.h:
3550         * WebView/WebView.mm:
3551         (-[WebView _commonInitializationWithFrameName:groupName:]):
3552         (+[WebView _handleMemoryWarning]):
3553         (-[WebView _preferencesChanged:]):
3554
3555 2014-09-04  Daniel Bates  <dabates@apple.com>
3556
3557         [iOS] Make iOS build when ENABLE_TOUCH_EVENT and ENABLE_IOS_TOUCH_EVENTS disabled
3558         https://bugs.webkit.org/show_bug.cgi?id=136494
3559
3560         Reviewed by Andy Estes.
3561
3562    &nbs