[GTK] Streamline wk1 documentation build
[WebKit-https.git] / Source / WebKit / gtk / ChangeLog
1 2011-10-19  Gustavo Noronha Silva  <gns@gnome.org>
2
3         [GTK] Streamline wk1 documentation build
4         https://bugs.webkit.org/show_bug.cgi?id=70447
5
6         Reviewed by Martin Robinson.
7
8         * GNUmakefile.am: move files pertaining to the docs build to the
9           docs GNUmakefile.am;
10         * GNUmakefile.gtk-doc.make: incorporate the gtk-doc makefile, and customize it
11           to our non-recursive build;
12         * docs/GNUmakefile.am: simplification and adaption to work with the
13           rest of the build system.
14
15 2011-10-19  Zan Dobersek  <zandobersek@gmail.com>
16
17         [Gtk][Geolocation] Build guards missing in geolocation clients
18         https://bugs.webkit.org/show_bug.cgi?id=70420
19
20         Reviewed by Gustavo Noronha Silva.
21
22         Adds build guards that were forgotten when client-based
23         geolocation was introduced in r97746. This should make builds
24         without geolocation support succeed again.
25
26         * WebCoreSupport/GeolocationClientGtk.cpp:
27         * WebCoreSupport/GeolocationClientGtk.h:
28         * webkit/webkitwebview.cpp:
29         (webkit_web_view_init):
30
31 2011-10-18  Zan Dobersek  <zandobersek@gmail.com>
32
33         [Gtk] Support for client-based geolocation
34         https://bugs.webkit.org/show_bug.cgi?id=64970
35
36         Reviewed by Martin Robinson.
37
38         Add DumpRenderTree support functions for client-based geolocation tests
39         and implement GeolocationClientGtk. The implementation is based on Zecke's
40         implementation of GeolocationService class in WebCore, which is now redundant
41         and subsequently removed.
42
43         * GNUmakefile.am: Add GeolocationClientGtk.* files to compilation.
44         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Add support functions to operate
45         with GeolocationClientMock.
46         (DumpRenderTreeSupportGtk::resetGeolocationClientMock):
47         (DumpRenderTreeSupportGtk::setMockGeolocationPermission):
48         (DumpRenderTreeSupportGtk::setMockGeolocationPosition):
49         (DumpRenderTreeSupportGtk::setMockGeolocationError):
50         (DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests):
51         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
52         * WebCoreSupport/GeolocationClientGtk.cpp: Added.
53         (WebKit::getPositionCallback):
54         (WebKit::positionChangedCallback):
55         (WebKit::GeolocationClient::GeolocationClient):
56         (WebKit::GeolocationClient::geolocationDestroyed):
57         (WebKit::GeolocationClient::startUpdating):
58         (WebKit::GeolocationClient::stopUpdating):
59         (WebKit::GeolocationClient::setEnableHighAccuracy):
60         (WebKit::GeolocationClient::lastPosition):
61         (WebKit::GeolocationClient::requestPermission):
62         (WebKit::GeolocationClient::cancelPermissionRequest):
63         (WebKit::GeolocationClient::positionChanged):
64         (WebKit::GeolocationClient::updatePosition):
65         (WebKit::GeolocationClient::errorOccured):
66         * WebCoreSupport/GeolocationClientGtk.h: Added.
67         * webkit/webkitwebview.cpp:
68         (webkit_web_view_init): Use GeolocationClientMock as geolocation client
69         when running in DumpRenderTree.
70
71 2011-10-12  Ryosuke Niwa  <rniwa@webkit.org>
72
73         Make the interface of locationAndLengthFromRange and rangeFromLocationAndLength consistent
74         https://bugs.webkit.org/show_bug.cgi?id=69964
75
76         Reviewed by Enrica Casucci.
77
78         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
79         (DumpRenderTreeSupportGtk::firstRectForCharacterRange):
80
81 2011-09-28  Martin Robinson  <mrobinson@igalia.com>
82
83         [GTK] Move drag-and-drop code which can be shared with WebKit2 to WebCore
84         https://bugs.webkit.org/show_bug.cgi?id=66890
85
86         Use the new GtkWidgetDragAndDropGlue class to hold the logic that will be
87         common between WebKit1 and WebKit2. Modify WebKitWebView to use this class.
88
89         Reviewed by Philippe Normand.
90
91         * WebCoreSupport/DragClientGtk.cpp:
92         (WebKit::DragClient::startDrag): Inform the drag-and-drop glue about the drag.
93         * webkit/webkitwebview.cpp: Use GtkWidgetDragAndDropGlue wherever this class was
94         maintaining drag-and-drop state itself.
95         * webkit/webkitwebviewprivate.h: Swap out the drag-and-drop state for an instance
96         of the glue class.
97
98 2011-09-28  Kaustubh Atrawalkar  <kaustubh@motorola.com>
99
100         [Gtk] Implement textInputController.doCommand
101         https://bugs.webkit.org/show_bug.cgi?id=66496
102
103         Reviewed by Martin Robinson.
104
105         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
106         (DumpRenderTreeSupportGtk::doCommand): Function definition for doCommand 
107         callback. Converted Incoming command to match with WebCore::Editor CommandMap.
108         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
109
110 2011-09-27  Carlos Garcia Campos  <cgarcia@igalia.com>
111
112         [GTK] Reorganize header files
113         https://bugs.webkit.org/show_bug.cgi?id=65616
114
115         Reviewed by Martin Robinson.
116
117         Install header files under $libwebkitgtkincludedir/webkit.
118
119         * GNUmakefile.am: Use $libwebkitgtkincludedir.
120         * webkit.pc.in: Use webkitgtk-<api-version> as include dir.
121
122 2011-09-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
123
124         Fix documentation generation by specifying the sources
125         directory with $(top_srcdir).
126
127         Reviewed by Xan Lopez.
128
129         * docs/GNUmakefile.am:
130
131 2011-09-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
132
133         REGRESSION: Empathy crashes when switching theme
134         https://bugs.webkit.org/show_bug.cgi?id=68600
135
136         Reviewed by Martin Robinson.
137
138         * webkit/webkitwebview.cpp:
139         (webkit_web_view_set_scroll_adjustments): use the existing
140         set{Horizontal,Vertical}Adjustment functions, so the code is not
141         duplicated
142         (webkit_web_view_dispose): unset the adjustments during dispose,
143         to avoid late adjustment change notifications hitting the
144         adjustment watcher
145
146 2011-09-24  Adam Barth  <abarth@webkit.org>
147
148         Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
149         https://bugs.webkit.org/show_bug.cgi?id=68767
150
151         Reviewed by Eric Seidel.
152
153         * WebCoreSupport/ChromeClientGtk.cpp:
154         (WebKit::ChromeClient::reachedApplicationCacheOriginQuota):
155         * WebCoreSupport/ChromeClientGtk.h:
156         * webkit/webkitapplicationcache.cpp:
157         (webkit_application_cache_get_maximum_size):
158         (webkit_application_cache_set_maximum_size):
159         (webkit_application_cache_get_database_directory_path):
160         * webkit/webkitglobals.cpp:
161         (webkitInit):
162
163 2011-09-22  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
164
165         Remove useless empty WebKit namespace.
166
167         Reviewed by Xan Lopez.
168
169         * webkit/webkitglobals.cpp:
170         (webkitInit):
171
172 2011-09-20  Carlos Garcia Campos  <cgarcia@igalia.com>
173
174         [GTK] WebProcess shouldn't use the GTK+ API
175         https://bugs.webkit.org/show_bug.cgi?id=68062
176
177         Reviewed by Martin Robinson.
178
179         Use WebCore API to create errors in frame loader.
180
181         * WebCoreSupport/AssertMatchingEnums.cpp:
182         * WebCoreSupport/FrameLoaderClientGtk.cpp:
183         (WebKit::FrameLoaderClient::cancelledError):
184         (WebKit::FrameLoaderClient::blockedError):
185         (WebKit::FrameLoaderClient::cannotShowURLError):
186         (WebKit::FrameLoaderClient::interruptedForPolicyChangeError):
187         (WebKit::FrameLoaderClient::cannotShowMIMETypeError):
188         (WebKit::FrameLoaderClient::fileDoesNotExistError):
189         (WebKit::FrameLoaderClient::pluginWillHandleLoadError):
190         * webkit/webkiterror.cpp:
191         (webkit_network_error_quark):
192         (webkit_policy_error_quark):
193         (webkit_plugin_error_quark):
194
195 2011-09-20  Philippe Normand  <pnormand@igalia.com>
196
197         [GTK] Update NEWS and configure.ac for 1.5.90 release
198
199         Reviewed by Martin Robinson.
200
201         * NEWS:
202
203 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
204
205         GTK DRT leaks memory while comparing history items
206         https://bugs.webkit.org/show_bug.cgi?id=68086
207
208         Reviewed by Martin Robinson.
209         
210         webkit_web_history_item_get_target() function returns a g_strdup()'d
211         string, so it should return "gchar*" instead of "const gchar*".
212
213         * webkit/webkitwebhistoryitem.cpp:
214         (webkit_web_history_item_get_target): Change return type to "gchar*".
215         * webkit/webkitwebhistoryitemprivate.h: Ditto.
216
217 2011-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
218
219         [GTK] Fix distcheck build
220         https://bugs.webkit.org/show_bug.cgi?id=68346
221
222         Reviewed by Philippe Normand.
223
224         * tests/testmimehandling.c: Remove ogg tests, since the behavious
225         has changed in libsoup (https://bugzilla.gnome.org/show_bug.cgi?id=648846#c8)
226         (server_callback):
227         (mime_type_policy_decision_requested_cb):
228         (main):
229         * webkit/webkitwebplugin.cpp: Fix introspection annotation.
230
231 2011-09-17  Mihai Parparita  <mihaip@chromium.org>
232
233         FrameLoaderClient BackForwardList-related methods are unsued
234         https://bugs.webkit.org/show_bug.cgi?id=68293
235
236         Reviewed by Darin Adler.
237
238         Remove FrameLoaderClient methods that were added by r51629, since only        
239         the old (since-deleted) Android port needed them.
240
241         * WebCoreSupport/FrameLoaderClientGtk.cpp:
242         * WebCoreSupport/FrameLoaderClientGtk.h:
243
244 2011-09-15  Adam Barth  <abarth@webkit.org>
245
246         Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
247         https://bugs.webkit.org/show_bug.cgi?id=68205
248
249         Reviewed by Eric Seidel.
250
251         * WebCoreSupport/ChromeClientGtk.cpp:
252         * WebCoreSupport/ChromeClientGtk.h:
253         * webkit/webkitsecurityorigin.cpp:
254         (webkit_security_origin_get_web_database_usage):
255         (webkit_security_origin_get_web_database_quota):
256         (webkit_security_origin_set_web_database_quota):
257         (webkit_security_origin_get_all_web_databases):
258         * webkit/webkitwebdatabase.cpp:
259         (webkit_web_database_get_display_name):
260         (webkit_web_database_get_expected_size):
261         (webkit_web_database_get_size):
262         (webkit_web_database_get_filename):
263         (webkit_web_database_remove):
264         (webkit_remove_all_web_databases):
265         (webkit_get_web_database_directory_path):
266         (webkit_set_web_database_directory_path):
267         * webkit/webkitwebview.cpp:
268         (webkit_web_view_update_settings):
269         (webkit_web_view_settings_notify):
270
271 2011-09-10  Adam Barth  <abarth@webkit.org>
272
273         Fix build break.
274
275         * webkit/webkitwebview.cpp:
276         (webkit_web_view_get_encoding):
277
278 2011-09-09  Fady Samuel  <fsamuel@chromium.org>
279
280         Move pageScaleFactor code from Frame.{h|cpp} to Page.{h|cpp}
281         https://bugs.webkit.org/show_bug.cgi?id=67250
282
283         Reviewed by Simon Fraser.
284
285         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
286         (DumpRenderTreeSupportGtk::scalePageBy):
287
288 2011-09-08  Daniel Bates  <dbates@webkit.org>
289
290         Fix the GTK build after <http://trac.webkit.org/changeset/94810>
291         (https://bugs.webkit.org/show_bug.cgi?id=67807).
292
293         * webkit/webkitwebview.cpp:
294         (webkit_web_view_get_encoding): Substitute DocumentWriter::deprecatedFrameEncoding() for
295         DocumentWriter::encoding().
296
297 2011-09-06  Ryosuke Niwa  <rniwa@webkit.org>
298
299         Rename confirmCompositionWithoutDisturbingSelection to cancelComposition
300         https://bugs.webkit.org/show_bug.cgi?id=67569
301
302         Reviewed by Antonio Gomes.
303
304         * WebCoreSupport/EditorClientGtk.cpp:
305         (WebKit::EditorClient::respondToChangedSelection):
306
307 2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
308
309         Unreviewed, rolling out r94142, r94144, r94145, and r94148.
310         http://trac.webkit.org/changeset/94142
311         http://trac.webkit.org/changeset/94144
312         http://trac.webkit.org/changeset/94145
313         http://trac.webkit.org/changeset/94148
314         https://bugs.webkit.org/show_bug.cgi?id=67262
315
316         Broke isindex element (Requested by rniwa on #webkit).
317
318         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
319         (DumpRenderTreeSupportGtk::setAutofilled):
320         (DumpRenderTreeSupportGtk::setValueForUser):
321
322 2011-08-30  Ryosuke Niwa  <rniwa@webkit.org>
323
324         GTK build fix after r94142.
325
326         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
327         (DumpRenderTreeSupportGtk::setAutofilled):
328         (DumpRenderTreeSupportGtk::setValueForUser):
329
330 2011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
331
332         The unused ScrollView* argument can and should be removed from
333         scrollRectIntoView.
334         https://bugs.webkit.org/show_bug.cgi?id=67117
335
336         Reviewed by Darin Adler.
337
338         * WebCoreSupport/ChromeClientGtk.h:
339         (WebKit::ChromeClient::scrollRectIntoView):
340
341 2011-08-26  Gustavo Noronha Silva  <gns@gnome.org>
342
343         Minor style fix in the sample code for WebKitWebFrame.
344
345         * webkit/webkitwebframe.cpp:
346
347 2011-08-17  Alejandro G. Castro  <alex@igalia.com>
348
349         [GTK] Fix compilation problems with deprecations in gtk+
350         https://bugs.webkit.org/show_bug.cgi?id=66073
351
352         Reviewed by Martin Robinson.
353
354         * WebCoreSupport/FullscreenVideoController.cpp:
355         (FullscreenVideoController::createHud): Added gtk_box_new
356         conditional compilation for gtk+-3.
357
358 2011-08-18  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
359
360         [GTK] Change webview API tests to use "load-status" signal instead of "load-progress"
361         https://bugs.webkit.org/show_bug.cgi?id=66243
362
363         Reviewed by Martin Robinson.
364
365         The idle_quit_loop_cb() already checks the "load-status" flag, so it is enough to
366         call it only when the "load-status" change.
367
368         This change is important in the context of bug 28851, which aims to change the
369         order in which "progress finished" and "load finished" callbacks are called. In
370         this new scenario, at the progress callback the load will never be finished.
371
372         * tests/testwebview.c:
373         (test_webkit_web_view_grab_focus):
374
375 2011-08-17  Adam Roben  <aroben@apple.com>
376
377         Make WebCore keep track of the current device scale factor
378
379         Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the
380         device scale factor
381
382         Reviewed by Darin Adler.
383
384         * WebCoreSupport/ChromeClientGtk.cpp:
385         * WebCoreSupport/ChromeClientGtk.h:
386         Removed deviceScaleFactor.
387
388 2011-08-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
389
390         Add javascriptcoregtk to the introspection build, to fix it.
391
392         Reviewed by Xan Lopez.
393
394         * GNUmakefile.am:
395
396 2011-08-15  Dmitry Titov  <dimich@chromium.org>
397
398         FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters
399         https://bugs.webkit.org/show_bug.cgi?id=66165
400
401         Reviewed by Darin Fisher.
402
403         * WebCoreSupport/FrameLoaderClientGtk.cpp:
404         (WebKit::FrameLoaderClient::transferLoadingResourceFromPage):
405         * WebCoreSupport/FrameLoaderClientGtk.h:
406
407 2011-08-10  Adam Roben  <aroben@apple.com>
408
409         Clear up scale factor terminology
410
411         WebKit by and large deals with two scale factors: one intrinsic to the device on which the
412         software is running, and one that is per-Page and can be controlled via API calls. This
413         patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the
414         code use those names. It should introduce no behavior changes.
415
416         Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the
417         device scale factor
418
419         Reviewed by Simon Fraser.
420
421         * WebCoreSupport/ChromeClientGtk.cpp:
422         * WebCoreSupport/ChromeClientGtk.h:
423
424 2011-08-11  Gustavo Noronha Silva  <gns@gnome.org>
425
426         Add the javascript core dynamic library for gtk-doc's introspection helper.
427
428         Reviewed by Xan Lopez.
429
430         * docs/GNUmakefile.am:
431
432 2011-08-11  Xan Lopez  <xlopez@igalia.com>
433
434         [GTK] Update NEWS and configure.ac for 1.5.2 release
435
436         Reviewed by Gustavo Noronha.
437
438         * NEWS: update for release.
439
440 2011-08-10  Gustavo Noronha Silva  <gns@gnome.org>
441
442         [GTK] wrong annotation for the return value of webkit_web_view_get_hit_test_results()
443         https://bugs.webkit.org/show_bug.cgi?id=65985
444
445         Reviewed by Xan Lopez.
446
447         * webkit/webkitwebview.cpp:
448
449 2011-08-03  Pavel Feldman  <pfeldman@google.com>
450
451         Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
452         https://bugs.webkit.org/show_bug.cgi?id=65510
453
454         Reviewed by Yury Semikhatsky.
455
456         * webkit/webkitwebview.cpp:
457         (paintWebView):
458
459 2011-08-03  Pavel Feldman  <pfeldman@chromium.org>
460
461         Web Inspector: remove Node parameter from the InspectorClient::highlight
462         https://bugs.webkit.org/show_bug.cgi?id=65549
463
464         Reviewed by Yury Semikhatsky.
465
466         * WebCoreSupport/InspectorClientGtk.cpp:
467         (WebKit::InspectorClient::highlight):
468         * WebCoreSupport/InspectorClientGtk.h:
469
470 2011-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
471
472         [GTK] Reorganize pkg-config files
473         https://bugs.webkit.org/show_bug.cgi?id=65548
474
475         Reviewed by Martin Robinson.
476
477         * GNUmakefile.am: Remove javascriptcore pc file references.
478
479 2011-07-30  Patrick Gansterer  <paroga@webkit.org>
480
481         Remove inclusion of MainThread.h from Threading.h
482         https://bugs.webkit.org/show_bug.cgi?id=65081
483
484         Reviewed by Darin Adler.
485
486         Add missing include statements for MainThread.
487
488         * webkit/webkitglobals.cpp:
489
490 2011-07-26  Sadrul Habib Chowdhury  <sadrul@chromium.org>
491
492         Add support for download='filename' attribute in anchors.
493         https://bugs.webkit.org/show_bug.cgi?id=64580
494
495         Reviewed by Adam Barth.
496
497         * WebCoreSupport/FrameLoaderClientGtk.cpp:
498         (WebKit::FrameLoaderClient::startDownload):
499         * WebCoreSupport/FrameLoaderClientGtk.h:
500
501 2011-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
502
503         [GTK] Remove header webkitwebviewcommon.h
504         https://bugs.webkit.org/show_bug.cgi?id=65177
505
506         Reviewed by Martin Robinson.
507
508         Move webkitwebviewcommon.h contents back to webkitwebview.h.
509
510         * GNUmakefile.am: Remove webkitwebviewcommon.h
511         * webkit/webkitwebview.h:
512         * webkit/webkitwebviewcommon.h: Removed.
513
514 2011-06-07  Martin Robinson  <mrobinson@igalia.com>
515
516         Reviewed by Gustavo Noronha Silva.
517
518         [GTK] Use WebCore scrollbars for the DRT instead of GtkScrolledWindow
519         https://bugs.webkit.org/show_bug.cgi?id=62252
520
521         Added an undocumented self-scrolling property to WebKitWebView which
522         communicates to WebCore whether or not this widget is expected to draw
523         its own main frame scrollbars or not.
524
525         * webkit/webkitwebview.cpp: Add the self-scrolling property.
526         * webkit/webkitwebviewprivate.h: Add the selfScrolling private member.
527
528 2011-07-11  Gustavo Noronha Silva  <gns@gnome.org>
529
530         [GTK] Google Calendar thinks we're mobile
531         https://bugs.webkit.org/show_bug.cgi?id=63994
532
533         Reviewed by Xan Lopez.
534
535         Further special-case Google Calendar, for it thinks WebKit+Linux
536         means mobile, so we also have to spoof the OS.
537
538         * WebCoreSupport/FrameLoaderClientGtk.cpp:
539         (WebKit::FrameLoaderClient::userAgent): use the new WebKitGTK+
540         private API that centralizes the logic now.
541         * tests/testwebsettings.c: Add tests to make sure the Google
542         special-cases only apply for the expected domains and when quirks
543         special-casing is enabled.
544         (test_non_quirky_user_agents):
545         (test_webkit_web_settings_user_agent):
546         * webkit/webkitwebsettings.cpp:
547         (webkitUserAgent): make it static.
548         (safariUserAgent): returns a fake Safari in Mac OS X User-Agent.
549         (initializeDomainsList): moved from FrameLoaderClientGtk.
550         (isGoogleDomain):ditto.
551         (isGoogleCalendar): ditto.
552         (userAgentForURL): ditto.
553         (webkitWebSettingsUserAgentForUri): centralize the whole
554         user agent spoofing logic in this new private API that can be used
555         by the browser to know what's going to happen for a specific URI
556         and also allows our API testing.
557         * webkit/webkitwebsettingsprivate.h:
558
559 2011-07-15  Dan Bernstein  <mitz@apple.com>
560
561         REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides
562         https://bugs.webkit.org/show_bug.cgi?id=64615
563
564         Reviewed by Anders Carlsson.
565
566         * WebCoreSupport/ChromeClientGtk.cpp:
567         (WebKit::ChromeClient::setCursorHiddenUntilMouseMoves): Added this stub.
568         * WebCoreSupport/ChromeClientGtk.h:
569
570 2011-07-15  Martin Robinson  <mrobinson@igalia.com>
571
572         Build fixes for WebKit2. Ensure that all generated sources are
573         on nodist primaries, that they are on forward declared variables
574         so that BUILT_SOURCES is calculated properly and that zlib is 
575         included during linking (for WOFF support).
576
577         * GNUmakefile.am:
578
579 2011-07-14  Lukasz Slachciak  <l.slachciak@samsung.com>
580
581         Reviewed by Gustavo Noronha.
582
583         [GTK] Fix GTK unit tests failures when WebKit is build outside repository directory.
584         https://bugs.webkit.org/show_bug.cgi?id=62935
585
586         WebKit can be build with WEBKITOUTPUTDIR env variable set using build-webkit script.
587         In this case WEBKITOUTPUDIR may be outside repository structure. This causes testmimehandling and testwebview
588         to fail because they use external test files in WebKit Source directory.
589         This bug fixes this issue introducing optional environment variable WEBKITREPODIR
590         Also coding style in existing functions is fixed.
591
592
593         * tests/test_utils.c: Coding style fixes.
594         (testutils_relative_chdir): If WEBKITREPODIR is set, change current directory to it.
595         * tests/test_utils.h: Coding style fixes.
596
597 2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>
598
599         ApplicationCache update should not immediately fail when reaching per-origin quota
600         https://bugs.webkit.org/show_bug.cgi?id=64177
601
602         Reviewed by Alexey Proskuryakov.
603
604         * WebCoreSupport/ChromeClientGtk.cpp:
605         (WebKit::ChromeClient::reachedApplicationCacheOriginQuota):
606         * WebCoreSupport/ChromeClientGtk.h:
607
608 2011-06-14  Mike Stegeman  <mrstegeman@gmail.com>
609
610         Add API to WebKit-GTK to allow setting localStorage database path
611         https://bugs.webkit.org/show_bug.cgi?id=62091
612
613         Reviewed by Martin Robinson and Gustavo Noronha.
614
615         Expose the path of the localStorage databases through a setting
616         to allow HTML5 localStorage to be persistent. New setting is:
617         html5-local-storage-database-path
618
619         * webkit/webkitwebsettings.cpp:
620         (webkit_web_settings_class_init):
621         (webkit_web_settings_set_property):
622         (webkit_web_settings_get_property):
623         * webkit/webkitwebsettingsprivate.h:
624         * webkit/webkitwebview.cpp:
625         (webkit_web_view_update_settings):
626         (webkit_web_view_settings_notify):
627
628 2011-07-08  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
629
630         [GTK] testwebview API test fails after http://trac.webkit.org/changeset/90471
631         https://bugs.webkit.org/show_bug.cgi?id=64159
632
633         Rework the icon-uri change test so that the condition for quitting
634         the mainloop is the icon-uri change itself, along with a timeout
635         to avoid taking too long in case of failure. Since the conditions
636         for considering a page loaded were changed we can't rely on that
637         for this test anymore.
638
639         Reviewed by Xan Lopez.
640
641         * tests/testwebview.c:
642         (timeout_cb): error out if it takes too long for the icon-uri
643         change to happen.
644         (icon_uri_changed_cb): quit the loop here instead of waiting on
645         the page being loaded.
646         (test_webkit_web_view_icon_uri):
647
648 2011-07-01  Joone Hur  <joone.hur@collabora.co.uk>
649
650         Reviewed by Martin Robinson.
651
652         [GTK] Add DeviceOrientation feature
653         https://bugs.webkit.org/show_bug.cgi?id=63720
654
655         Add empty implementation of DeviceMotionClient and DeviceOrientationClient callback methods.
656
657         * GNUmakefile.am:
658         * WebCoreSupport/DeviceMotionClientGtk.cpp: Added.
659         (WebCore::DeviceMotionClientGtk::DeviceMotionClientGtk):
660         (WebCore::DeviceMotionClientGtk::~DeviceMotionClientGtk):
661         (WebCore::DeviceMotionClientGtk::deviceMotionControllerDestroyed):
662         (WebCore::DeviceMotionClientGtk::setController):
663         (WebCore::DeviceMotionClientGtk::startUpdating):
664         (WebCore::DeviceMotionClientGtk::stopUpdating):
665         (WebCore::DeviceMotionClientGtk::currentDeviceMotion):
666         * WebCoreSupport/DeviceMotionClientGtk.h: Added.
667         * WebCoreSupport/DeviceOrientationClientGtk.cpp: Added.
668         (WebCore::DeviceOrientationClientGtk::DeviceOrientationClientGtk):
669         (WebCore::DeviceOrientationClientGtk::~DeviceOrientationClientGtk):
670         (WebCore::DeviceOrientationClientGtk::deviceOrientationControllerDestroyed):
671         (WebCore::DeviceOrientationClientGtk::setController):
672         (WebCore::DeviceOrientationClientGtk::startUpdating):
673         (WebCore::DeviceOrientationClientGtk::stopUpdating):
674         (WebCore::DeviceOrientationClientGtk::lastOrientation):
675         * WebCoreSupport/DeviceOrientationClientGtk.h: Added.
676         * webkit/webkitwebview.cpp:
677         (webkit_web_view_init):
678
679 2011-06-28  Joone Hur  <joone.hur@collabora.co.uk>
680
681         Reviewed by Martin Robinson.
682
683         [GTK] Allow to build WebKitGtk+ with accelerated compositing
684         https://bugs.webkit.org/show_bug.cgi?id=63404
685
686         WebKitGtk+ needs to implement accelerated compositing for running CSS3 3D transforms 
687         and animation through GPU acceleration. We could implement GraphicsLayer using Clutter.
688
689         * WebCoreSupport/ChromeClientGtk.cpp:
690         (WebKit::ChromeClient::attachRootGraphicsLayer): not implemented yet.
691         (WebKit::ChromeClient::setNeedsOneShotDrawingSynchronization): Ditto.
692         (WebKit::ChromeClient::scheduleCompositingLayerSync): Ditto.
693         (WebKit::ChromeClient::allowedCompositingTriggers): Ditto.
694         * WebCoreSupport/ChromeClientGtk.h:
695
696 2011-06-27  ChangSeok Oh  <shivamidow@gmail.com>
697
698         Reviewed by Martin Robinson.
699
700         [GTK] Fix build break to support webgl
701         https://bugs.webkit.org/show_bug.cgi?id=63425
702
703         A member variable enableWebGL in WebKitWebSettingsPrivate is changed to enableWebgl
704
705         * webkit/webkitwebview.cpp:
706         (webkit_web_view_update_settings):
707
708 2011-06-24  Dominic Cooney  <dominicc@chromium.org>
709
710         Reviewed by Dimitri Glazkov.
711
712         Convert shadow DOM-related tests to use window.internals
713         https://bugs.webkit.org/show_bug.cgi?id=61671
714
715         Remove shadow-DOM related methods from GTK DRT API. These are not
716         required any more.
717
718         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
719         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
720
721 2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
722
723         Reviewed by Kent Tamura.
724
725         FileChooser should be only created when we need to choose files.
726         https://bugs.webkit.org/show_bug.cgi?id=63039
727
728         * WebCoreSupport/ChromeClientGtk.cpp:
729         (WebKit::ChromeClient::runOpenPanel): Changed to use settings.
730
731 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
732
733         Reviewed by Xan Lopez.
734
735         [GTK] Make sure libsoup password manager macro is defined before including libsoup in webkitsoupauthdialog
736         https://bugs.webkit.org/show_bug.cgi?id=63124
737
738         Fixes a crash when building with --enable-debug.
739
740         * webkit/webkitsoupauthdialog.h: Define
741         LIBSOUP_I_HAVE_READ_BUG_594377_AND_KNOW_SOUP_PASSWORD_MANAGER_MIGHT_GO_AWAY
742         before including libsoup.h.
743
744 2011-06-10  Martin Robinson  <mrobinson@igalia.com>
745
746         Reviewed by Xan Lopez.
747
748         [GTK] webkit_web_settings_copy does not copy all settings
749         https://bugs.webkit.org/show_bug.cgi?id=62424
750
751         Instead of trying to keep webkit_web_settings_copy up to date with
752         property additions, create the object copy by dynamically initializing
753         all webkit_web_settings properties at once.
754
755         * tests/testwebsettings.c:
756         (test_webkit_web_settings_copy): Create a test for webkit_web_settings copy.
757         (main): Run the new test.
758         * webkit/webkitwebsettings.cpp:
759         (webkit_web_settings_copy): Dynamically initialize all properties of the copy.
760
761 2011-06-20  Martin Robinson  <mrobinson@igalia.com>
762
763         Reviewed by Eric Seidel.
764
765         [GTK] Clean up unecessary boilerplate from WebKitWebSettings and make private members meet WebKit style guidelines
766         https://bugs.webkit.org/show_bug.cgi?id=61972
767
768         Rename all private members of WebKitWebSettings to meet WebKit style guidelines and
769         put the private struct definition in webkitwebsettingsprivate.h so it can be
770         accessed from webkitwebview.cpp. This cuts down on the boilerplate immensely.
771
772         * webkit/webkitwebsettings.cpp: Rename private members to meet WebKit style guidelines
773         and allocate the private section with new/delete. This allows for using CString and removes
774         the need for manual string memory management.
775         * webkit/webkitwebsettingsprivate.h: Move the private struct definition here.
776         * webkit/webkitwebview.cpp: Update to reflect new struct names. Remove boilerplate
777         and other very small code cleanups.
778
779 2011-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
780
781         Reviewed by Xan Lopez.
782
783         [GTK] Split libWebCore into two libWebCore and libWebCoreGtk
784         https://bugs.webkit.org/show_bug.cgi?id=60539
785
786         * GNUmakefile.am: Link to libWebCoreGtk.la too.
787
788 2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
789
790         Reviewed by Darin Adler.
791
792         Separate concerns of loading file icons and choosing files.
793         https://bugs.webkit.org/show_bug.cgi?id=62931
794
795         * WebCoreSupport/ChromeClientGtk.cpp:
796         (WebKit::ChromeClient::loadIconForFiles): Renamed.
797         * WebCoreSupport/ChromeClientGtk.h:
798
799 2011-06-17  Joone Hur  <joone.hur@collabora.co.uk>
800
801         Reviewed by Martin Robinson.
802
803         [GTK] Replace GdkRectangle by cairo_rectangle_int_t
804         https://bugs.webkit.org/show_bug.cgi?id=60687
805
806         Replace GdkRectangle by cairo_rectangle_int_t.
807
808         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Replace GdkRectangle by cairo_rectangle_int_t.
809         (DumpRenderTreeSupportGtk::firstRectForCharacterRange):
810         (DumpRenderTreeSupportGtk::rectangleForSelection):
811         * WebCoreSupport/DumpRenderTreeSupportGtk.h: Ditto.
812
813 2011-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
814
815         Unreviewed, rolling out r89026.
816         http://trac.webkit.org/changeset/89026
817         https://bugs.webkit.org/show_bug.cgi?id=62804
818
819         These patches were likely correct.  I'll investigate the
820         browser_test failures. (Requested by abarth on #webkit).
821
822         * WebCoreSupport/FullscreenVideoController.cpp:
823         (FullscreenVideoController::play):
824         (FullscreenVideoController::pause):
825
826 2011-06-16  Vitaly Repeshko  <vitalyr@chromium.org>
827
828         Unreviewed.
829
830         Revert Adam's user gesture patch series r89002, r89005, r89007, r89018
831         https://bugs.webkit.org/show_bug.cgi?id=62796
832
833         The patches broke chromium browser tests.
834 2011-06-16  Adam Barth  <abarth@webkit.org>
835
836         Reviewed by Eric Seidel.
837
838         Remove HTMLVideoElement::processingUserGesture
839         https://bugs.webkit.org/show_bug.cgi?id=62784
840
841         * WebCoreSupport/FullscreenVideoController.cpp:
842         (FullscreenVideoController::play):
843         (FullscreenVideoController::pause):
844
845 2011-06-15  Claudio Saavedra  <csaavedra@igalia.com>
846
847         Reviewed by Xan Lopez.
848
849         [GTK] Fix the build with introspection enabled
850         https://bugs.webkit.org/show_bug.cgi?id=62705
851
852         * GNUmakefile.am: Remove include of *.c files, since
853         there are no such files anymore.
854
855 2011-06-14  Xan Lopez  <xlopez@igalia.com>
856
857         Reviewed by Martin Robinson.
858
859         [GTK] Remove G_CONST_RETURN usage
860         https://bugs.webkit.org/show_bug.cgi?id=62673
861
862         Change G_CONST_RETURN for a simple "const" throughout the
863         codebase, since G_CONST_RETURN is deprecated now. This should be
864         totally equivalent since for all practical purposes the macro is
865         always expanded to const.
866
867         * webkit/webkitapplicationcache.cpp:
868         (webkit_application_cache_get_database_directory_path): use const
869         instead of G_CONST_RETURN.
870         * webkit/webkitapplicationcache.h:
871         * webkit/webkiticondatabase.cpp:
872         (webkit_icon_database_get_path): ditto.
873         * webkit/webkiticondatabase.h:
874         * webkit/webkitnetworkrequest.cpp:
875         (webkit_network_request_get_uri): ditto.
876         * webkit/webkitnetworkrequest.h:
877         * webkit/webkitnetworkresponse.cpp:
878         (webkit_network_response_get_uri): ditto.
879         * webkit/webkitnetworkresponse.h:
880         * webkit/webkitsecurityorigin.cpp:
881         (webkit_security_origin_get_protocol): ditto.
882         (webkit_security_origin_get_host): ditto.
883         * webkit/webkitsecurityorigin.h:
884         * webkit/webkitwebdatabase.cpp:
885         (webkit_web_database_get_name): ditto.
886         (webkit_web_database_get_display_name): ditto.
887         (webkit_web_database_get_filename): ditto.
888         (webkit_get_web_database_directory_path): ditto.
889         * webkit/webkitwebdatabase.h:
890         * webkit/webkitwebdatasource.cpp:
891         (webkit_web_data_source_get_encoding): ditto.
892         (webkit_web_data_source_get_unreachable_uri): ditto.
893         * webkit/webkitwebdatasource.h:
894         * webkit/webkitwebframe.cpp:
895         (webkit_web_frame_get_title): ditto.
896         (webkit_web_frame_get_uri): ditto.
897         (webkit_web_frame_get_name): ditto.
898         * webkit/webkitwebframe.h:
899         * webkit/webkitwebhistoryitem.cpp:
900         (webkit_web_history_item_get_title): ditto.
901         (webkit_web_history_item_get_alternate_title): ditto.
902         (webkit_web_history_item_get_uri): ditto.
903         (webkit_web_history_item_get_original_uri): ditto.
904         (webkit_web_history_item_get_target): ditto.
905         * webkit/webkitwebhistoryitem.h:
906         * webkit/webkitwebhistoryitemprivate.h:
907         * webkit/webkitwebnavigationaction.cpp:
908         (webkit_web_navigation_action_get_target_frame): ditto.
909         * webkit/webkitwebnavigationaction.h:
910         * webkit/webkitwebresource.cpp:
911         (webkit_web_resource_get_uri): ditto.
912         (webkit_web_resource_get_mime_type): ditto.
913         (webkit_web_resource_get_encoding): ditto.
914         (webkit_web_resource_get_frame_name): ditto.
915         * webkit/webkitwebresource.h:
916         * webkit/webkitwebsettings.cpp:
917         (webkit_web_settings_get_user_agent): ditto.
918         * webkit/webkitwebsettings.h:
919         * webkit/webkitwebview.cpp:
920         (webkit_web_view_get_title): ditto.
921         (webkit_web_view_get_uri): ditto.
922         (webkit_web_view_get_icon_uri): ditto.
923         * webkit/webkitwebview.h:
924         * webkit/webkitwebviewcommon.h:
925
926 2011-06-14  Carlos Garcia Campos  <cgarcia@igalia.com>
927
928         Reviewed by Martin Robinson.
929
930         [GTK] Rename convertWidgetRectToScreenRect() to convertWidgetPointToScreenPoint()
931         https://bugs.webkit.org/show_bug.cgi?id=62626
932
933         * WebCoreSupport/ChromeClientGtk.cpp:
934         (WebKit::ChromeClient::windowToScreen): Update to use
935         convertWidgetPointToScreenPoint()
936         (WebKit::ChromeClient::screenToWindow): Ditto.
937         * webkit/webkitwebview.cpp: Remove globalPointForClientPoint()
938         since it does the same than convertWidgetPointToScreenPoint().
939         (webkit_web_view_popup_menu_handler): Use
940         convertWidgetPointToScreenPoint() instead of globalPointForClientPoint().
941         (doDragLeaveLater): Ditto.
942         (webkit_web_view_drag_motion): Ditto.
943         (webkit_web_view_drag_data_received): Ditto.
944         (webkit_web_view_drag_drop): Ditto.
945
946 2011-06-14  Carlos Garcia Campos  <cgarcia@igalia.com>
947
948         Reviewed by Martin Robinson.
949
950         [GTK] Support authentication dialogs in WebKit2
951         https://bugs.webkit.org/show_bug.cgi?id=62366
952
953         Move the common code of webkitsoupauthdialog to a common C++ class
954         in WebCore so that it can be used by WebKit2 too. The file has
955         been converted into a C++ file.
956
957         * GNUmakefile.am: Rename webkitsoupauthdialog.c to
958         webkitsoupauthdialog.cpp.
959         * webkit/webkitsoupauthdialog.c: Removed.
960         * webkit/webkitsoupauthdialog.cpp: Added.
961         (webkit_soup_auth_dialog_class_init):
962         (webkit_soup_auth_dialog_init):
963         (webkit_soup_auth_dialog_session_feature_init):
964         (sessionAuthenticate): Use GtkAuthenticationDialog object from
965         WebCore.
966         (attach):
967         (detach):
968         * webkit/webkitsoupauthdialog.h:
969
970 2011-06-13  Joone Hur  <joone.hur@collabora.co.uk>
971
972         Reviewed by Martin Robinson.
973
974         [GTK] Add configure option to enable/disable register protocol handler
975         https://bugs.webkit.org/show_bug.cgi?id=62534
976
977         * WebCoreSupport/ChromeClientGtk.cpp:
978         (WebKit::ChromeClient::registerProtocolHandler): Added.
979         * WebCoreSupport/ChromeClientGtk.h: Add the registerProtocolHandler method defintion.
980
981 2011-06-13  Martin Robinson  <mrobinson@igalia.com>
982
983         Reviewed by Gustavo Noronha Silva.
984
985         Update gtkdoc files and inline documentation to reduce gtkdoc errors
986         and ensure complete documentation output.
987
988         * docs/webkitgtk-sections.txt: Add missing sections to the list and remove
989         unneeded sections.
990         * docs/webkitgtk.types: Update the types list.
991         * webkit/webkithittestresult.cpp: Fix inline documentation errors.
992         (webkit_hit_test_result_class_init): Ditto.
993         * webkit/webkiticondatabase.cpp: Ditto.
994         * webkit/webkitwebsettings.cpp: Ditto.
995         (webkit_web_settings_class_init): Ditto.
996         * webkit/webkitwebview.cpp: Ditto.
997         (webkit_web_view_class_init): Ditto.
998
999 2011-06-13  Martin Robinson  <mrobinson@igalia.com>
1000
1001         Reviewed by Xan Lopez.
1002
1003         Update the list of ignored GTK+ header files for the documentation
1004         generation.
1005
1006         * docs/GNUmakefile.am: Update ignored header list.
1007
1008 2011-06-13  Xan Lopez  <xlopez@igalia.com>
1009
1010         Reviewed by Martin Robinson.
1011
1012         Update NEWS for 1.5.1 release.
1013
1014         * NEWS: update.
1015
1016 2011-06-13  Xan Lopez  <xlopez@igalia.com>
1017
1018         Reviewed by Martin Robinson.
1019
1020         Distcheck fixes.
1021
1022         * GNUmakefile.am:
1023
1024 2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1025
1026         Reviewed by Martin Robinson.
1027
1028         [GTK] Export an API similar to WebKit1
1029         https://bugs.webkit.org/show_bug.cgi?id=57820
1030
1031         * GNUmakefile.am: Add webkitwebviewcommon.h to public header list.
1032         * webkit/webkitwebview.h: Move declarations common to WebKit2 to
1033         webkitwebviewcommon.h.
1034         * webkit/webkitwebviewcommon.h: Added.
1035
1036 2011-06-12  Adam Barth  <abarth@webkit.org>
1037
1038         Reviewed by Alexey Proskuryakov.
1039
1040         Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
1041         https://bugs.webkit.org/show_bug.cgi?id=62516
1042
1043         * WebCoreSupport/FrameLoaderClientGtk.cpp:
1044         (WebKit::FrameLoaderClient::interruptedForPolicyChangeError):
1045         * WebCoreSupport/FrameLoaderClientGtk.h:
1046
1047 2011-06-12  Xan Lopez  <xlopez@igalia.com>
1048
1049         Reviewed by Martin Robinson.
1050
1051         [GTK] Remove webkit_web_view_get_selected_text
1052         https://bugs.webkit.org/show_bug.cgi?id=62512
1053
1054         It's no longer used and it's a private method, so it can be
1055         removed.
1056
1057         * webkit/webkitwebview.cpp: kill it.
1058         * webkit/webkitwebviewprivate.h: ditto.
1059
1060 2011-06-12  Adam Barth  <abarth@webkit.org>
1061
1062         Reviewed by Alexey Proskuryakov.
1063
1064         Remove trival "forward-to-client" member functions from FrameLoader
1065         https://bugs.webkit.org/show_bug.cgi?id=62510
1066
1067         Update to call the FrameLoaderClient directly.  Also, remove cargo-cult
1068         code that checks whether FrameLoader is null.
1069
1070         * webkit/webkitwebview.cpp:
1071         (webkit_web_view_stop_loading):
1072         (webkit_web_view_can_show_mime_type):
1073
1074 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
1075
1076         Reviewed by Eric Seidel.
1077
1078         [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
1079         https://bugs.webkit.org/show_bug.cgi?id=55603
1080
1081         Added DumpRenderTreeSupport methods to support hasMarkedText and markedRange.
1082
1083         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1084         (DumpRenderTreeSupportGtk::setComposition): Use start and length rather than start and
1085         end. This matches other ports. Only use GLib style early returns when checking the
1086         validity of GObjects.
1087         (DumpRenderTreeSupportGtk::hasComposition):  Added.
1088         (DumpRenderTreeSupportGtk::compositionRange): Added.
1089         (DumpRenderTreeSupportGtk::confirmComposition): Cleanup as described above.
1090         (DumpRenderTreeSupportGtk::firstRectForCharacterRange): Cleanup as described above.
1091         (DumpRenderTreeSupportGtk::selectedRange): Cleanup as described above.
1092         * WebCoreSupport/DumpRenderTreeSupportGtk.h: Added new declarations.
1093
1094 2011-06-08  Xan Lopez  <xlopez@igalia.com>
1095
1096         Reviewed by Martin Robinson.
1097
1098         [GTK] Add WebKitSpellChecker interface and implementations
1099         https://bugs.webkit.org/show_bug.cgi?id=61787
1100
1101         Expose the spell checking functionality to the UAs through a
1102         generic interface, and provide a default Enchant-based
1103         implementation. On top of allowing UAs to use this functionality
1104         this makes it possible to change the spell checking backend at
1105         runtime.
1106
1107         * GNUmakefile.am: add new files.
1108         * WebCoreSupport/EditorClientGtk.cpp:
1109         (WebKit::EditorClient::EditorClient): set the spell checker using
1110         the new classes.
1111         * WebCoreSupport/TextCheckerClientEnchant.cpp: Removed.
1112         * WebCoreSupport/TextCheckerClientGtk.cpp: Added
1113         (WebKit::TextCheckerClientGtk::TextCheckerClientGtk): just
1114         chain up to the WebKitSpellChecker.
1115         (WebKit::TextCheckerClientGtk::~TextCheckerClientGtk): ditto.
1116         (WebKit::TextCheckerClientGtk::ignoreWordInSpellDocument): ditto.
1117         (WebKit::TextCheckerClientGtk::learnWord): ditto.
1118         (WebKit::TextCheckerClientGtk::checkSpellingOfString): ditto.
1119         (WebKit::TextCheckerClientGtk::getAutoCorrectSuggestionForMisspelledWord): ditto.
1120         (WebKit::TextCheckerClientGtk::getGuessesForWord): ditto.
1121         (WebKit::TextCheckerClientGtk::updateSpellCheckingLanguage): ditto.
1122         * WebCoreSupport/TextCheckerClientGtk.h: store a reference to
1123         the WebKitSpellChecker.
1124         * webkit/webkit.h: the webkitspellchecker.h header is public.
1125         * webkit/webkitdefines.h: defines for spell checker interface.
1126         * webkit/webkitglobals.cpp: Add APIs to get and set the global
1127         spell checker.
1128         (webkit_get_spell_checker): get API.
1129         (webkit_set_spell_checker): set API.
1130         * webkit/webkitglobals.h:
1131         * webkit/webkitspellchecker.cpp: Added. Spell checking interface.
1132         * webkit/webkitspellchecker.h: Added.
1133         * webkit/webkitspellcheckerenchant.cpp: Added. Default
1134         implemention, uses Enchant library.
1135         * webkit/webkitspellcheckerenchant.h: Added.
1136
1137 2011-06-07  Xan Lopez  <xlopez@igalia.com>
1138
1139         Reviewed by Martin Robinson.
1140
1141         [GTK] "webkithittestresult.h" is malformed
1142         https://bugs.webkit.org/show_bug.cgi?id=62117
1143
1144         * webkit/webkithittestresult.h: fix typo in GET_CLASS macro.
1145
1146 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
1147
1148         Reviewed by Ryosuke Niwa.
1149
1150         [GTK] Support smart replace for the pasteboard
1151         https://bugs.webkit.org/show_bug.cgi?id=61734
1152
1153         Add the EditorClient and DumpRenderTreeSupportGtk hooks for enabling
1154         smart replace in the tests.
1155
1156         * WebCoreSupport/DragClientGtk.cpp:
1157         (WebKit::DragClient::startDrag): targeListForDataObject now takes another
1158         parameter determining whether or not to add smart paste support. Add it here.
1159         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1160         (DumpRenderTreeSupportGtk::setSmartInsertDeleteEnabled): Added.
1161         * WebCoreSupport/DumpRenderTreeSupportGtk.h: Add new method definition.
1162         * WebCoreSupport/EditorClientGtk.cpp:
1163         (WebKit::EditorClient::toggleSmartInsertDelete): Added implementation.
1164         (WebKit::EditorClient::smartInsertDeleteEnabled): Added.
1165         (WebKit::EditorClient::EditorClient):
1166         * WebCoreSupport/EditorClientGtk.h: Add new method definition.
1167
1168 2011-06-03  Sergio Villar Senin  <svillar@igalia.com>
1169
1170         Reviewed by Martin Robinson.
1171
1172         [GTK] Unref the SoupSession used by WebKitGtk+ at exit
1173         https://bugs.webkit.org/show_bug.cgi?id=60165
1174
1175         WebKitGtk+ creates a SoupSession instance to handle network stuff
1176         that is never freed. We should unref that object at exit time.
1177
1178         * webkit/webkitglobals.cpp:
1179         (webkitExit):
1180         (webkitInit):
1181
1182 2011-05-28  Martin Robinson  <mrobinson@igalia.com>
1183
1184         Reviewed by Gustavo Noronha Silva.
1185
1186         [GTK] Remove PastboardHelperGtk
1187         https://bugs.webkit.org/show_bug.cgi?id=61690
1188
1189         Remove PasteboardHelperGtk and talk directly to WebCore for pasteboard
1190         activity. This change moves the PasteboardHelper singleton from WebKit
1191         to WebCore.
1192
1193         * GNUmakefile.am: Remove PasteboardHelperGtk from the source list.
1194         * WebCoreSupport/AssertMatchingEnums.cpp: Added assertions verifying that the
1195         WebCore versions of the GtkClipboard enums match those in the WebKit API.
1196         * WebCoreSupport/DragClientGtk.cpp:
1197         (WebKit::DragClient::startDrag): Access the pasteboard helper via a static method.
1198         * WebCoreSupport/EditorClientGtk.cpp:
1199         (WebKit::setSelectionPrimaryClipboardIfNeeded): Ditto. Call into the helper to specify
1200         that the current clipboard is selection primary now.
1201         * WebCoreSupport/PasteboardHelperGtk.cpp: Removed.
1202         * webkit/webkitglobals.cpp: Remove function to set and get the pasteboard helper.
1203         * webkit/webkitglobalsprivate.h: Ditto.
1204         * webkit/webkitwebview.cpp:
1205         (webkit_web_view_button_press_event): Access the pasteboard helper via a static method.
1206         (webkit_web_view_drag_data_get): Ditto.
1207         (webkit_web_view_drag_motion): Ditto.
1208         (webkit_web_view_drag_data_received): Ditto.
1209         (webkit_web_view_init): Ditto.
1210         (webkit_web_view_get_copy_target_list): Ditto.
1211         (webkit_web_view_get_paste_target_list): Ditto.
1212         * webkit/webkitwebviewprivate.h: Ditto.
1213
1214 2011-06-02  Joone Hur  <joone.hur@collabora.co.uk>
1215
1216         Reviewed by Martin Robinson.
1217
1218         [GTK] Only load dictionaries if spell check is enabled
1219         https://bugs.webkit.org/show_bug.cgi?id=32879
1220
1221         We don't need to call enchant if enable-spell-checking is false.
1222
1223         * webkit/webkitwebview.cpp:
1224         (webkit_web_view_update_settings): Skip loading dictionaries when enable-spell-checking is false. 
1225         (webkit_web_view_settings_notify): Ditto.
1226
1227 2011-06-01  Xan Lopez  <xlopez@igalia.com>
1228
1229         Reviewed by Martin Robinson.
1230
1231         Explictly request the size of a pointer in malloc. Otherwise this
1232         explodes in 64bit architectures, at least.
1233
1234         * webkit/webkitwebplugin.cpp:
1235         (webkit_web_plugin_get_mimetypes): ditto.
1236
1237 2011-06-01  Xan Lopez  <xlopez@igalia.com>
1238
1239         Reviewed by Martin Robinson.
1240
1241         [GTK] Utility methods for UA spellchecking
1242         https://bugs.webkit.org/show_bug.cgi?id=61788
1243
1244         Adds a couple of utility methods needed to implement some aspects
1245         of spell checking support in a browser.
1246
1247         * webkit/webkitwebframe.cpp:
1248         (webkit_web_frame_replace_selection): method to replace the current
1249         selection with a string of text.
1250         (webkit_web_frame_get_range_for_word_around_caret): returns the DOM
1251         range for the word where the caret/selection currently is.
1252         * webkit/webkitwebframe.h: declare new methods.
1253
1254 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
1255
1256         Reviewed by Gustavo Noronha Silva.
1257
1258         [GTK] gtkdoc run produces many warnings about missing declarations
1259         https://bugs.webkit.org/show_bug.cgi?id=61797
1260
1261         * docs/webkitgtk-sections.txt: Remove inexistent symbols from this file
1262         to reduce the number of gtkdoc warnings.
1263
1264 2011-05-31  Xan Lopez  <xlopez@igalia.com>
1265
1266         Reviewed by Martin Robinson.
1267
1268         [GTK] Provide custom DOM bindings methods to check if input/textareas have been edited
1269         https://bugs.webkit.org/show_bug.cgi?id=61791
1270
1271         * GNUmakefile.am: add new files.
1272
1273 2011-05-27  Philippe Normand  <pnormand@igalia.com>
1274
1275         Reviewed by Martin Robinson.
1276
1277         [GTK] Data directory is webkitgtk-x.y not webkit-x.y
1278         https://bugs.webkit.org/show_bug.cgi?id=61642
1279
1280         * GNUmakefile.am: updated data directory.
1281
1282 2011-05-28  Adam Barth  <abarth@webkit.org>
1283
1284         Reviewed by Alexey Proskuryakov.
1285
1286         Audit all uses of KURL::prettyURL
1287         https://bugs.webkit.org/show_bug.cgi?id=61201
1288
1289         Update callers of prettyURL to just call string.
1290
1291         * WebCoreSupport/ChromeClientGtk.cpp:
1292         (WebKit::ChromeClient::mouseDidMoveOverElement):
1293         * WebCoreSupport/FrameLoaderClientGtk.cpp:
1294         (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage):
1295         (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
1296         * webkit/webkitwebview.cpp:
1297         (webkit_web_view_get_icon_uri):
1298
1299 2011-05-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1300
1301         Reviewed by Martin Robinson.
1302
1303         Cleanup postCommitFrameViewSetup parameters which are no longer
1304         necessary after the adjustments handling refactoring.
1305
1306         * WebCoreSupport/FrameLoaderClientGtk.cpp:
1307         (WebKit::postCommitFrameViewSetup):
1308         (WebKit::FrameLoaderClient::transitionToCommittedFromCachedFrame):
1309         (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
1310
1311 2011-05-22  Adam Barth  <abarth@webkit.org>
1312
1313         Build fix.  More public destructors needed to play nice with OwnPtr.
1314
1315         * WebCoreSupport/InspectorClientGtk.cpp:
1316
1317 2011-05-22  Adam Barth  <abarth@webkit.org>
1318
1319         Build fix.  InspectorFrontendClient needs a public destructor so that
1320         we can properly track ownership using OwnPtr.
1321
1322         * WebCoreSupport/InspectorClientGtk.h:
1323
1324 2011-05-22  Adam Barth  <abarth@webkit.org>
1325
1326         Strict PassOwnPtr build fix.
1327
1328         * WebCoreSupport/InspectorClientGtk.cpp:
1329         (WebKit::InspectorClient::openInspectorFrontend):
1330         (WebKit::InspectorFrontendClient::InspectorFrontendClient):
1331
1332 2011-05-22  Adam Barth  <abarth@webkit.org>
1333
1334         Strict PassOwnPtr build fix.
1335
1336         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1337         (DumpRenderTreeSupportGtk::addUserStyleSheet):
1338
1339 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
1340
1341         Reviewed by Sam Weinig.
1342
1343         numberOfActiveAnimations() can include animations from documents in the page cache
1344         https://bugs.webkit.org/show_bug.cgi?id=53641
1345
1346         Pass the Frame's document as the one to count animations on.
1347
1348         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1349         (DumpRenderTreeSupportGtk::numberOfActiveAnimations):
1350
1351 2011-05-16  Martin Robinson  <mrobinson@igalia.com>
1352
1353         Reviewed by Xan Lopez.
1354
1355         [GTK] Scrolling in Twitter is broken after r86102
1356         https://bugs.webkit.org/show_bug.cgi?id=60922
1357
1358         Fix adjustment handling for pages that trigger the slow scrolling path.
1359         The slow scrolling path is triggered by WebCore when it determines that
1360         doing a simple invalidation is quicker than doing a normal scroll. This
1361         typically happens when there are large elements with fixed positions.
1362
1363         * WebCoreSupport/ChromeClientGtk.cpp:
1364         (WebKit::ChromeClient::invalidateContentsForSlowScroll): Poke the adjustment
1365         watcher to update its adjustments when a page triggers the slow scrolling path.
1366
1367 2011-05-13  Jon Lee  <jonlee@apple.com>
1368
1369         Reviewed by Simon Fraser.
1370
1371         Can't horizontally scroll iframes and overflow because wheel events are always accepted
1372         https://bugs.webkit.org/show_bug.cgi?id=60779
1373
1374         * WebCoreSupport/ChromeClientGtk.h:
1375         (WebKit::ChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
1376         (WebKit::ChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method
1377
1378 2011-05-13  Sam Weinig  <sam@webkit.org>
1379
1380         Reviewed by Anders Carlsson.
1381
1382         Prune #includes from FrameView.h (Part 2)
1383         https://bugs.webkit.org/show_bug.cgi?id=60748
1384
1385         - Update files that were depending on FrameView.h #including Frame.h or
1386           Page.h.
1387
1388         * WebCoreSupport/GtkAdjustmentWatcher.cpp:
1389
1390 2011-05-13  Martin Robinson  <mrobinson@igalia.com>
1391
1392         Reviewed by Eric Seidel.
1393
1394         [GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
1395         https://bugs.webkit.org/show_bug.cgi?id=59765
1396
1397         Use the new KeyBindingTranslator class from WebCore/platform/gtk. With this utility
1398         class we can now share the code with WebKit2.
1399
1400         * WebCoreSupport/EditorClientGtk.cpp:
1401         (WebKit::EditorClient::executePendingEditorCommands): Updated to reflect the fact that
1402         the command vector now contains WTF::string.
1403         (WebKit::EditorClient::handleKeyboardEvent): Use the new helper utility class.
1404         (WebKit::EditorClient::EditorClient): 
1405         * WebCoreSupport/EditorClientGtk.h: Remove unnecessary member. Add the utility class.
1406
1407 2011-05-12  Martin Robinson  <mrobinson@igalia.com>
1408
1409         Attempt to fix the GTK+ unit test testwebview on the 32-bit Release
1410         bot which appears to be more sensitive to timing issues than the
1411         other bots.
1412
1413         * tests/testwebview.c: Add another short pause waiting for adjustments to update.
1414
1415 2011-05-09  Martin Robinson  <mrobinson@igalia.com>
1416
1417         Fix a test after r86102. Scrollbars update asynchronously, so we
1418         must check the adjustments after a short delay.
1419
1420         * tests/testwebview.c:
1421         (quit_after_short_delay_cb): Add a short delay before checking adjustments.
1422         (test_webkit_web_view_grab_focus): Ditto.
1423
1424 2011-05-09  Xan Lopez  <xlopez@igalia.com>
1425
1426         Unreviewed build fix.
1427
1428         Fix build, for real.
1429
1430         * webkit/webkitwebview.cpp:
1431         (getHorizontalAdjustment):
1432
1433 2011-05-09  Xan Lopez  <xlopez@igalia.com>
1434
1435         Unreviewed build fix..
1436
1437         Fix GTK+3.x build.
1438
1439         * webkit/webkitwebview.cpp:
1440         (getHorizontalAdjustment): the adjustment is in
1441         adjustmentWatcher() now.
1442         (getVerticalAdjustment): ditto.
1443
1444 2011-04-29  Martin Robinson  <mrobinson@igalia.com>
1445
1446         Reviewed by Gustavo Noronha Silva.
1447
1448         [GTK] Untangle GtkAdjustments from WebCore
1449         https://bugs.webkit.org/show_bug.cgi?id=59821
1450
1451         Have ChromeClient manage the GtkAdjustments of the parent widget instead of passing
1452         them to WebCore to manage. This simplifies the code quite a bit and should be less
1453         crash prone in the future.
1454
1455         * GNUmakefile.am: Added new GtkAdjustmentWatcher class to the sources list.
1456         * WebCoreSupport/ChromeClientGtk.cpp: Added new GtkAdjustmentWatcher member.
1457         (WebKit::ChromeClient::ChromeClient) Initialize the new member.
1458         (WebKit::ChromeClient::scroll): Poke the adjustment watcher to update the adjustments.
1459         (WebKit::ChromeClient::contentsSizeChanged): Ditto.
1460         (WebKit::ChromeClient::scrollbarsModeDidChange): This may now be called at a time when there
1461         is no main frame, so do an early return in that case.
1462         * WebCoreSupport/ChromeClientGtk.h: Add the new member.
1463         (WebKit::ChromeClient::adjustmentWatcher): Add this getter for WebKitWebView.
1464         * WebCoreSupport/FrameLoaderClientGtk.cpp: Remove calls which pushed the adjustments into
1465         WebCore.
1466         (WebKit::FrameLoaderClient::savePlatformDataToCachedFrame):
1467         (WebKit::postCommitFrameViewSetup):
1468         * WebCoreSupport/GtkAdjustmentWatcher.cpp: Added.
1469         (WebKit::GtkAdjustmentWatcher::GtkAdjustmentWatcher):
1470         (WebKit::updateAdjustmentFromScrollbar):
1471         (WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbars):
1472         (WebKit::updateAdjustmentCallback):
1473         (WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater):
1474         (WebKit::adjustmentValueChangedCallback):
1475         (WebKit::setAdjustment):
1476         (WebKit::GtkAdjustmentWatcher::setHorizontalAdjustment):
1477         (WebKit::GtkAdjustmentWatcher::setVerticalAdjustment):
1478         (WebKit::GtkAdjustmentWatcher::adjustmentValueChanged):
1479         * WebCoreSupport/GtkAdjustmentWatcher.h: Added.
1480         (WebKit::GtkAdjustmentWatcher::horizontalAdjustment):
1481         (WebKit::GtkAdjustmentWatcher::verticalAdjustment):
1482         * webkit/webkitwebview.cpp:
1483         (setHorizontalAdjustment):
1484         (setVerticalAdjustment): Remove the adjustment member. Call into the adjustment watcher.
1485         (getHorizontalAdjustment): Ditto.
1486         (getVerticalAdjustment): Ditto.
1487         (webkit_web_view_size_allocate): Ditto.
1488         (webkit_web_view_set_scroll_adjustments): Ditto.
1489         (webkit_web_view_dispose): Ditto.
1490         (webkit_web_view_init): Ditto.
1491         * webkit/webkitwebviewprivate.h: Ditto.
1492
1493 2011-05-06  Kent Tamura  <tkent@chromium.org>
1494
1495         Reviewed by Ryosuke Niwa.
1496
1497         Eliminate WebCore/dom/InputElement.{cpp,h}
1498         https://bugs.webkit.org/show_bug.cgi?id=60262
1499
1500         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1501         (DumpRenderTreeSupportGtk::setAutofilled):
1502           Follow the return type change of Node::toInputElement().
1503         (DumpRenderTreeSupportGtk::setValueForUser): ditto.
1504
1505 2011-05-06  Martin Robinson  <mrobinson@igalia.com>
1506
1507         Reviewed by Xan Lopez.
1508
1509         [GTK] [WebKit2] WebView::windowToScreen needs an implementation
1510         https://bugs.webkit.org/show_bug.cgi?id=55960
1511
1512         Abstract the code to translate from widget space to screen space into
1513         a helper method in WebCore.
1514
1515         * WebCoreSupport/ChromeClientGtk.cpp: Use the new helper method from GtkUtilities.
1516         (WebKit::ChromeClient::windowToScreen):
1517         (WebKit::ChromeClient::screenToWindow):
1518
1519 2011-05-04  Philippe Normand  <pnormand@igalia.com>
1520
1521         Reviewed by Dimitri Glazkov.
1522
1523         Implement LayoutTestController::pseudoShadowId()
1524         https://bugs.webkit.org/show_bug.cgi?id=60034
1525
1526         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1527         (DumpRenderTreeSupportGtk::shadowPseudoId):
1528         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
1529
1530 2011-05-05  Bharathwaaj Srinivasan  <bharathwaaj.s@gmail.com>
1531
1532         Reviewed by Holger Freyther.
1533
1534         Fix build-webkit --minimal.
1535         https://bugs.webkit.org/show_bug.cgi?id=60257
1536
1537         * webkit/webkitglobals.cpp:
1538         (webkitInit):
1539
1540 2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
1541
1542         Reviewed by Eric Seidel.
1543
1544         Rename SelectionController to FrameSelection
1545         https://bugs.webkit.org/show_bug.cgi?id=60234
1546
1547         * webkit/webkitwebview.cpp:
1548         (getLocationForKeyboardGeneratedContextMenu):
1549
1550 2011-05-04  Ryosuke Niwa  <rniwa@webkit.org>
1551
1552         GTK build fix attempt after r85823
1553
1554         * WebCoreSupport/ChromeClientGtk.h:
1555         (WebKit::ChromeClient::webView):
1556         * WebCoreSupport/EditorClientGtk.cpp:
1557         (WebKit::imContextCommitted):
1558         (WebKit::imContextPreeditChanged):
1559         * webkit/webkitwebview.cpp:
1560         (WebKit::kit):
1561
1562 2011-05-04  Cris Neckar  <cdn@chromium.org>
1563
1564         Reviewed by Adam Barth.
1565
1566         Expose WebView directly through ChromeClient.
1567         https://bugs.webkit.org/show_bug.cgi?id=49902
1568
1569         * WebCoreSupport/ChromeClientGtk.h:
1570         (WebKit::ChromeClient::webView):
1571
1572 2011-05-04  Tao Bai  <michaelbai@chromium.org>
1573
1574         Reviewed by David Kilzer.
1575
1576         Populate touch-icon url to FrameLoaderClient
1577         https://bugs.webkit.org/show_bug.cgi?id=59143
1578
1579         Respect the interface change in FrameLoaderClient.
1580
1581         * WebCoreSupport/FrameLoaderClientGtk.cpp:
1582         (WebKit::FrameLoaderClient::dispatchDidChangeIcons):
1583         * WebCoreSupport/FrameLoaderClientGtk.h:
1584
1585 2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>
1586
1587         Reviewed by Dimitri Glazkov.
1588
1589         Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
1590         https://bugs.webkit.org/show_bug.cgi?id=58703
1591
1592         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Added #include for ShadowRoot.h.
1593
1594 2011-04-29  Xan Lopez  <xlopez@igalia.com>
1595
1596         Reviewed by Martin Robinson.
1597
1598         [Gtk+] Crash when navigating back
1599         https://bugs.webkit.org/show_bug.cgi?id=59799
1600
1601         The innerNode management in WebKitHitTestResult was relying on the
1602         old DOM bindings behavior where every DOM objects had to be
1603         disposed by the caller. Now the objects are garbage collected by
1604         WebKit when either the parent frame or document dies, so this is
1605         not needed anymore. Update the code to simply take ownership of
1606         the node, which effectively correctly balances the reference
1607         count.
1608
1609         * webkit/webkithittestresult.cpp:
1610         (webkit_hit_test_result_dispose): call C++ dtors in private data.
1611         (webkit_hit_test_result_get_property): adatp to GRefPtr API.
1612         (webkit_hit_test_result_init): call C++ ctors in private data.
1613
1614 2011-04-28  Xan Lopez  <xlopez@igalia.com>
1615
1616         Unreviewed build fix.
1617
1618         * GNUmakefile.am:
1619
1620 2011-04-28  Xan Lopez  <xlopez@igalia.com>
1621
1622         Reviewed by Martin Robinson.
1623
1624         [Gtk] Split JSC and WebCore builds
1625         https://bugs.webkit.org/show_bug.cgi?id=19428
1626
1627         Add a pkg-config file for JavaScriptCoreGTK+.
1628
1629         * GNUmakefile.am: take care of the pkg-config file.
1630         * javascriptcoregtk.pc.in: Added.
1631
1632 2011-04-28  Xan Lopez  <xlopez@igalia.com>
1633
1634         Reviewed by Martin Robinson.
1635
1636         [Gtk] Split JSC and WebCore builds
1637         https://bugs.webkit.org/show_bug.cgi?id=19428
1638
1639         Build JavaScriptCore as a libtool shared library instead of a
1640         private convenience library.
1641
1642         * GNUmakefile.am: adapt to new name for javascriptcore target.
1643
1644 2011-04-28  ojab  <ojab@ojab.ru>
1645
1646         Reviewed by Martin Robinson.
1647
1648         Webkit-gtk build failure, no type/member 'Page' in namespace 'WebCore'
1649         https://bugs.webkit.org/show_bug.cgi?id=59585
1650
1651         * webkit/webkitwebviewprivate.h:
1652
1653 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
1654
1655         Reviewed by Xan Lopez.
1656
1657         [GTK] Click counting logic should be shared between WebKit1 and WebKit2
1658         https://bugs.webkit.org/show_bug.cgi?id=59715
1659
1660         Switch WebKit1 to use the new GtkClickCounter for counting > 3 clicks in a row.
1661         This allows the code to be shared between WebKit1 and WebKit2.
1662
1663         * WebCoreSupport/DragClientGtk.cpp:
1664         (WebKit::DragClient::startDrag): Call GtkClickCounter::reset instead of fiddling
1665         the WebView private data directly.
1666         * WebCoreSupport/FrameLoaderClientGtk.cpp:
1667         (WebKit::postCommitFrameViewSetup): Ditto.
1668         * webkit/webkitwebview.cpp:
1669         (webkit_web_view_button_press_event): Call into GtkClickCounter now.
1670         (webkit_web_view_init): Remove private member intialization.
1671         * webkit/webkitwebviewprivate.h: Remove unneeded private members.
1672
1673 2011-04-27  Martin Robinson  <mrobinson@igalia.com>
1674
1675         Reviewed by Eric Seidel.
1676
1677         [GTK] Menulists do not follow text direction when rendering options with right-to-left text
1678         https://bugs.webkit.org/show_bug.cgi?id=54038
1679
1680         Fix rendering of menulists that contain right-to-left text. Text direction
1681         inside a menulist now follows the alignment of its contents.
1682
1683         * WebCoreSupport/ChromeClientGtk.cpp:
1684         (WebKit::ChromeClient::selectItemWritingDirectionIsNatural): Return false instead of true.
1685         (WebKit::ChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Return true instead of false.
1686
1687 2011-04-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1688
1689         Unreviewed, rolling out r84987.
1690         http://trac.webkit.org/changeset/84987
1691         https://bugs.webkit.org/show_bug.cgi?id=59618
1692
1693         Caused crashes on the GTK+ debug bots. (Requested by mrobinson
1694         on #webkit).
1695
1696         * WebCoreSupport/ChromeClientGtk.cpp:
1697         (WebKit::ChromeClient::exceededDatabaseQuota):
1698
1699 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
1700
1701         Reviewed by Xan Lopez.
1702
1703         [GTK] flaky crash  storage/open-database-set-empty-version.html
1704         https://bugs.webkit.org/show_bug.cgi?id=58988
1705
1706         Construct the security origin directly instead of getting it from the WebKitWebFrame object.
1707         This prevents failing to create the WebKitSecurityOrigin in cases where the frame is in
1708         some inconsistent state.
1709
1710         * WebCoreSupport/ChromeClientGtk.cpp:
1711         (WebKit::ChromeClient::exceededDatabaseQuota): Construct the origin directly.
1712
1713 2011-04-22  Martin Robinson  <mrobinson@igalia.com>
1714
1715         Reviewed by Xan Lopez.
1716
1717         [GTK] fast/events/overflow-viewport-renderer-deleted.html crashes
1718         https://bugs.webkit.org/show_bug.cgi?id=58976
1719
1720         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1721         (DumpRenderTreeSupportGtk::getInnerText): Guard against situations when the documentElement
1722         method of the document returns null.
1723
1724 2011-04-22  Sam Weinig  <sam@webkit.org>
1725
1726         Reviewed by Gavin Barraclough.
1727
1728         Remove remaining uses of deprecated version of toJS
1729         https://bugs.webkit.org/show_bug.cgi?id=59170
1730
1731         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1732         (DumpRenderTreeSupportGtk::shadowRoot):
1733         (DumpRenderTreeSupportGtk::ensureShadowRoot):
1734         Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
1735
1736 2011-04-22  Philippe Normand  <pnormand@igalia.com>
1737
1738         Reviewed by Martin Robinson.
1739
1740         [GTK] DRT: implement eventSender.scalePageBy
1741         https://bugs.webkit.org/show_bug.cgi?id=59082
1742
1743         Added support in DRT for webview scaling.
1744
1745         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1746         (DumpRenderTreeSupportGtk::scale):
1747         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
1748
1749 2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
1750
1751         Reviewed by Sam Weinig.
1752
1753         Add Frame* to the argument lists of canCopyCut and canPaste
1754         https://bugs.webkit.org/show_bug.cgi?id=59153
1755
1756         * WebCoreSupport/EditorClientGtk.cpp:
1757         (WebKit::EditorClient::canCopyCut):
1758         (WebKit::EditorClient::canPaste):
1759         * WebCoreSupport/EditorClientGtk.h:
1760
1761 2011-04-21  Martin Robinson  <mrobinson@igalia.com>
1762
1763         [GTK] DRT: implement eventSender.scalePageBy
1764         https://bugs.webkit.org/show_bug.cgi?id=59082
1765
1766         Rolling out r84507 since it broke many GTK+ tests.
1767
1768         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1769         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
1770
1771 2011-04-21  Philippe Normand  <pnormand@igalia.com>
1772
1773         Reviewed by Martin Robinson.
1774
1775         [GTK] missing LayoutTestController::callShouldCloseOnWebView()
1776         https://bugs.webkit.org/show_bug.cgi?id=59086
1777
1778         DRT::shouldClose(), used by the LayoutController.
1779
1780         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1781         (DumpRenderTreeSupportGtk::shouldClose):
1782         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
1783
1784 2011-04-21  Philippe Normand  <pnormand@igalia.com>
1785
1786         Reviewed by Martin Robinson.
1787
1788         [GTK] DRT: implement eventSender.scalePageBy
1789         https://bugs.webkit.org/show_bug.cgi?id=59082
1790
1791         Added support in DRT for webview scaling.
1792
1793         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1794         (DumpRenderTreeSupportGtk::scalePageBy):
1795         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
1796
1797 2011-04-20  Dominic Cooney  <dominicc@chromium.org>
1798
1799         Reviewed by Dimitri Glazkov.
1800
1801         layoutTestController can create and destroy shadow DOM
1802         https://bugs.webkit.org/show_bug.cgi?id=59058
1803
1804         Support for new methods in GTK DRT.
1805
1806         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1807         (DumpRenderTreeSupportGtk::ensureShadowRoot):
1808         (DumpRenderTreeSupportGtk::removeShadowRoot):
1809         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
1810
1811 2011-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1812
1813         Reviewed by Martin Robinson.
1814
1815         [GTK] Build libWebCore with the gtk sources too
1816         https://bugs.webkit.org/show_bug.cgi?id=58968
1817
1818         In some cases webcore files are compiled twice, so it improves the
1819         build time.
1820
1821         * GNUmakefile.am: Remove webcore gtk sources from libwebkitgtk
1822         sources.
1823
1824 2011-04-19  Vsevolod Vlasov  <vsevik@chromium.org>
1825
1826         Reviewed by Pavel Feldman.
1827
1828         Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
1829         https://bugs.webkit.org/show_bug.cgi?id=58883
1830
1831         * WebCoreSupport/FrameLoaderClientGtk.cpp:
1832         (WebKit::FrameLoaderClient::dispatchDidReceiveContentLength):
1833         * WebCoreSupport/FrameLoaderClientGtk.h:
1834         * webkit/webkitdownload.cpp:
1835         (DownloadClient::didReceiveData):
1836
1837 2011-04-18  Zan Dobersek  <zandobersek@gmail.com>
1838
1839         Reviewed by Martin Robinson.
1840
1841         [GTK] Need support for dumping focus rectangles in pixel results
1842         https://bugs.webkit.org/show_bug.cgi?id=53647
1843
1844         Add a support function that returns the rectangle of the current
1845         selection in frame.
1846
1847         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1848         (DumpRenderTreeSupportGtk::rectangleForSelection):
1849         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
1850
1851 2011-04-12  Xan Lopez  <xlopez@igalia.com>
1852
1853         Unreviewed build fix.
1854
1855         * webkit/webkitwebhistoryitem.cpp:
1856
1857 2011-04-12  Stephanie Lewis  <slewis@apple.com>
1858
1859         Reviewed by Oliver Hunt.
1860
1861         https://bugs.webkit.org/show_bug.cgi?id=58280
1862         <rdar://problem/9252824> javascript in an inconsistent state due to serialization returning an un-handled exception.
1863
1864         Add a header include.  Fallout from untangling some header files in WebCore.
1865
1866         * webkit/webkitwebhistoryitem.cpp:
1867
1868 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
1869
1870         Reviewed by Eric Seidel.
1871
1872         [GTK] The GTK+ DRT needs an implementation of the PlainTextController
1873         https://bugs.webkit.org/show_bug.cgi?id=53605
1874
1875         Added jsValueToDOMRange to DumpRenderTreeSupportGtk. This static method can convert
1876         a JSValueRef to a WebKitDOMRange. When it's possible to do this with the public
1877         API, we can remove this method.
1878
1879         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1880         (DumpRenderTreeSupportGtk::jsValueToDOMRange): Added.
1881         * WebCoreSupport/DumpRenderTreeSupportGtk.h: Added declaration.
1882
1883 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
1884
1885         Reviewed by Chris Fleizach.
1886
1887         [Gtk] Implement support for Embedded Objects
1888         https://bugs.webkit.org/show_bug.cgi?id=52148
1889
1890         New accessibility unit test for embedded objects.
1891
1892         * tests/testatk.c:
1893         (testWebkitAtkEmbeddedObjects): New unit test.
1894         (main): Added the new unit test.
1895
1896 2011-04-08  Dominic Cooney  <dominicc@google.com>
1897
1898         Reviewed by Adam Roben.
1899
1900         Make layoutTestController.shadowRoot return null, not undefined,
1901         when its argument is invalid.
1902         https://bugs.webkit.org/show_bug.cgi?id=58121
1903
1904         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1905         (DumpRenderTreeSupportGtk::shadowRoot):
1906
1907 2011-04-08  Dominic Cooney  <dominicc@google.com>
1908
1909         Reviewed by Kent Tamura.
1910
1911         layoutTestController.shadowRoot should return undefined if its
1912         argument is not an element.
1913         https://bugs.webkit.org/show_bug.cgi?id=58119
1914
1915         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1916         (DumpRenderTreeSupportGtk::shadowRoot):
1917
1918 2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>
1919
1920         Reviewed by Martin Robinson.
1921
1922         [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
1923         https://bugs.webkit.org/show_bug.cgi?id=58039
1924
1925         Implemented missing functions in GTK's DRT.
1926
1927         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
1928         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1929         (modifyAccessibilityValue): Helper function to increment or decrement
1930         the current value for an object through the AccessibilityObject's API.
1931         (DumpRenderTreeSupportGtk::incrementAccessibilityValue): New function,
1932         to be used from GTK's DRT.
1933         (DumpRenderTreeSupportGtk::decrementAccessibilityValue): Ditto.
1934
1935 2011-04-06  Gustavo Noronha Silva  <gns@gnome.org>
1936
1937         Reviewed by Martin Robinson.
1938
1939         [GTK] Need a way to get the path to a WebKitWebPlugin
1940         https://bugs.webkit.org/show_bug.cgi?id=57968
1941
1942         Expose the path of the plugin through the WebKitWebPlugin object.
1943
1944         * webkit/webkitwebplugin.cpp:
1945         (webkit_web_plugin_get_path):
1946         * webkit/webkitwebplugin.h:
1947         * webkit/webkitwebpluginprivate.h:
1948
1949 2011-04-07  Alice Boxhall  <aboxhall@chromium.org>
1950
1951         Reviewed by Ryosuke Niwa.
1952
1953         Move the MouseEventWithHitTestResults::targetNode() method on to EventHandler.
1954         https://bugs.webkit.org/show_bug.cgi?id=57921
1955
1956         * webkit/webkitwebview.cpp:
1957         (webkit_web_view_forward_context_menu_event):
1958         Call subframeForHitTestResult rather than subframeForTargetNode as the targetNode()
1959         method has moved on to EventHandler.
1960
1961 2011-04-05  Martin Robinson  <mrobinson@igalia.com>
1962
1963         Reviewed by Eric Seidel.
1964
1965         [Cairo] Better separate the concerns of GraphicsContextCairo
1966         https://bugs.webkit.org/show_bug.cgi?id=55150
1967
1968         Add a PlatformContextCairo which right now stores the cairo_t* for a
1969         GraphicsContextCairo. Later patches will move logic for tracking ContextShadow
1970         and image masking layers into this PlatformContextCairo class.
1971
1972         * webkit/webkitwebframe.cpp:
1973         (draw_page_callback):
1974         * webkit/webkitwebview.cpp:
1975         (webkit_web_view_expose_event):
1976         (webkit_web_view_draw):
1977
1978 2011-04-04  MORITA Hajime  <morrita@google.com>
1979
1980         Reviewed by Ryosuke Niwa.
1981
1982         [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
1983         https://bugs.webkit.org/show_bug.cgi?id=56085
1984
1985         * WebCoreSupport/TextCheckerClientEnchant.h:
1986         (WebKit::TextCheckerClientEnchant::requestCheckingOfString):
1987
1988 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
1989
1990         Reviewed by Gustavo Noronha Silva.
1991
1992         [GTK] WebGL support
1993         https://bugs.webkit.org/show_bug.cgi?id=31517
1994
1995         Add support for toggling WebGL at runtime when it's enabled.
1996
1997         * webkit/webkitwebsettings.cpp: Add the enable-webgl property. When ENABLE_WEBGL
1998         is not enabled, it's a no-op.
1999         (webkit_web_settings_class_init): Update to support enable-webgl.
2000         (webkit_web_settings_set_property): Ditto.
2001         (webkit_web_settings_get_property): Ditto.
2002         * webkit/webkitwebview.cpp:
2003         (webkit_web_view_update_settings): Ditto.
2004
2005 2011-04-04  Alexey Proskuryakov  <ap@apple.com>
2006
2007         Reviewed by Dan Bernstein.
2008
2009         REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
2010         https://bugs.webkit.org/show_bug.cgi?id=51230
2011         <rdar://problem/8780989>
2012
2013         * webkit/webkitwebview.cpp: (webkit_web_view_key_release_event): Moved Caps Lock handling from
2014         WebKits to WebCore, because WebKit shouldn't be smart.
2015
2016 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
2017
2018         Reviewed by Xan Lopez.
2019
2020         [Gtk] webkit_web_view_popup_menu_handler should call SelectionController::localCaretRect
2021         https://bugs.webkit.org/show_bug.cgi?id=54633
2022
2023         Remove use of legacy editing positions when positioning keyboard-driven context
2024         menus. Simplify the code greatly.
2025
2026         * webkit/webkitwebview.cpp:
2027         (getLocationForKeyboardGeneratedContextMenu): Added this helper which calculates
2028         the context menu position.
2029         (webkit_web_view_popup_menu_handler): Simplify code preventing the menu from bumping
2030         into the edges of the view. Remove (0,-1) hack as it no longer seems to be important.
2031
2032 2011-04-02  Dominic Cooney  <dominicc@google.com>
2033
2034         Reviewed by Martin Robinson.
2035
2036         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
2037         https://bugs.webkit.org/show_bug.cgi?id=57551
2038
2039         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2040         (DumpRenderTreeSupportGtk::shadowRoot):
2041         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2042
2043 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2044
2045         Unreviewed, rolling out r82721.
2046         http://trac.webkit.org/changeset/82721
2047         https://bugs.webkit.org/show_bug.cgi?id=57687
2048
2049         This patch introduced assertion failures on the GTK+ bots.
2050         (Requested by mrobinson on #webkit).
2051
2052         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2053         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2054
2055 2011-04-01  Dominic Cooney  <dominicc@google.com>
2056
2057         Reviewed by Martin Robinson.
2058
2059         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
2060         https://bugs.webkit.org/show_bug.cgi?id=57551
2061
2062         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2063         (DumpRenderTreeSupportGtk::shadowRoot):
2064         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2065
2066 2011-03-31  Xan Lopez  <xlopez@igalia.com>
2067
2068         Reviewed by Martin Robinson.
2069
2070         [GTK] Link explicitly with XRender on Linux/Unix
2071         https://bugs.webkit.org/show_bug.cgi?id=57558
2072
2073         * GNUmakefile.am: add XRender LIBS.
2074
2075 2011-03-31  Evan Martin  <evan@chromium.org>
2076
2077         Build fix from previous change.
2078
2079         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2080         (WebKit::FrameLoaderClient::dispatchDidReceiveTitle):
2081
2082 2011-03-31  Evan Martin  <evan@chromium.org>
2083
2084         Reviewed by Eric Seidel.
2085
2086         <title> should support dir attribute
2087         https://bugs.webkit.org/show_bug.cgi?id=50961
2088
2089         Update to new FrameLoaderClient interface.
2090
2091         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2092         (WebKit::FrameLoaderClient::dispatchDidReceiveTitle):
2093         (WebKit::FrameLoaderClient::setTitle):
2094         * WebCoreSupport/FrameLoaderClientGtk.h:
2095
2096 2011-03-29  Philippe Normand  <pnormand@igalia.com>
2097
2098         Unreviewed, disable an assert in testwebview due to
2099         https://bugs.webkit.org/show_bug.cgi?id=57315
2100
2101         * tests/testwebview.c:
2102
2103 2011-03-28  Adele Peterson  <adele@apple.com>
2104
2105         Build fix.
2106
2107         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2108         (DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker):
2109
2110 2011-03-28  Sergio Villar Senin  <svillar@igalia.com>
2111
2112         Reviewed by Martin Robinson.
2113
2114         [GTK] Fullscreen tests failing after r82084
2115         https://bugs.webkit.org/show_bug.cgi?id=57219
2116
2117         Added the withKeyboard parameter to supportsFullScreenForElement
2118         method in ChromeClient. Fullscreen will be disabled for keyboard
2119         access by default.
2120
2121         * WebCoreSupport/ChromeClientGtk.cpp:
2122         (WebKit::ChromeClient::supportsFullScreenForElement):
2123         * WebCoreSupport/ChromeClientGtk.h:
2124
2125 2011-03-25  Andy Estes  <aestes@apple.com>
2126
2127         Reviewed by Adele Peterson.
2128
2129         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
2130         https://bugs.webkit.org/show_bug.cgi?id=49016
2131
2132         Update objectContentType() implementation to handle the
2133         shouldPreferPlugInsForImages flag.
2134
2135         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2136         (WebKit::FrameLoaderClient::objectContentType):
2137         * WebCoreSupport/FrameLoaderClientGtk.h:
2138
2139 2011-03-25  Priit Laes  <plaes@plaes.org>
2140
2141         Reviewed by Martin Robinson.
2142
2143         [GTK] [PATCH] Avoid critical warning when free-ing list of plugins
2144         https://bugs.webkit.org/show_bug.cgi?id=57025
2145
2146         * webkit/webkitwebplugindatabase.cpp:
2147         (webkit_web_plugin_database_plugins_list_free):
2148         Use regular check and return instead of g_return_if_fail.
2149
2150 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2151
2152         Unreviewed, rolling out r81916 and r81917.
2153         http://trac.webkit.org/changeset/81916
2154         http://trac.webkit.org/changeset/81917
2155         https://bugs.webkit.org/show_bug.cgi?id=57071
2156
2157         broke a test on platforms that do not have QuickTime installed
2158         (Requested by estes on #webkit).
2159
2160         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2161         (WebKit::FrameLoaderClient::objectContentType):
2162         * WebCoreSupport/FrameLoaderClientGtk.h:
2163
2164 2011-03-24  Andy Estes  <aestes@apple.com>
2165
2166         Reviewed by Darin Adler.
2167
2168         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
2169         https://bugs.webkit.org/show_bug.cgi?id=49016
2170
2171         Update objectContentType() implementation to handle the
2172         shouldPreferPlugInsForImages flag.
2173
2174         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2175         (WebKit::FrameLoaderClient::objectContentType):
2176         * WebCoreSupport/FrameLoaderClientGtk.h:
2177
2178 2011-03-23  Brady Eidson  <beidson@apple.com>
2179
2180         Reviewed by Sam Weinig.
2181
2182         Change IconDatabase opening to allow for arbitrary filenames
2183         https://bugs.webkit.org/show_bug.cgi?id=56977
2184
2185         * webkit/webkiticondatabase.cpp:
2186         (webkit_icon_database_set_path):
2187
2188 2011-03-22  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2189
2190         Rubber-stamped by Xan Lopez.
2191
2192         Applications that include WebKit headers fail to build when using strict warnings
2193         because the signature for webkit_application_cache_get_maximum_size is missing a
2194         'void' to make it explicit it takes no arguments.
2195
2196         * webkit/webkitapplicationcache.h:
2197
2198 2011-03-21  Alejandro G. Castro  <alex@igalia.com>
2199
2200         Reviewed by Martin Robinson.
2201
2202         [GTK] 1.3.13 release bump
2203         https://bugs.webkit.org/show_bug.cgi?id=56795
2204
2205         Version bump for 1.3.13 and updated NEWS file with release notes.
2206
2207         * NEWS:
2208
2209 2011-03-21  Chang Shu  <cshu@webkit.org>
2210
2211         Reviewed by Alexey Proskuryakov.
2212
2213         REGRESSION (r79953): Can't type in MS Outlook 2011
2214         https://bugs.webkit.org/show_bug.cgi?id=56665
2215
2216         r79953 removed the WebView level editablity which is persistent no matter whether
2217         underlying document itself is changed and editability gets lost. The resolution is to
2218         set this WebView editable value to WebCore. This avoids the callback from WebCore to
2219         WebKit which was the main goal in r79953 to improve performance.
2220
2221         * webkit/webkitwebview.cpp:
2222         (webkit_web_view_get_editable):
2223         (webkit_web_view_set_editable):
2224
2225 2011-03-21  Mario Sanchez Prada  <msanchez@igalia.com>
2226
2227         Reviewed by Martin Robinson.
2228
2229         [GTK] [Stable] AtkHypertext exposes wrong offsets for links placed inside <span> nodes
2230         https://bugs.webkit.org/show_bug.cgi?id=56737
2231
2232         * tests/testatk.c:
2233         (testWebkitAtkHypertextAndHyperlinks): Updated unit test to also
2234         check offsets for hyperlinks inside <span> nodes.
2235
2236 2011-03-18  David Keijser  <keijser@gmail.com> and Xan Lopez <xlopez@igalia.com>
2237
2238         Reviewed by Martin Robinson.
2239
2240         [GTK] On-demand event-listeners for DOM event signals
2241         https://bugs.webkit.org/show_bug.cgi?id=49649
2242
2243         * tests/testdomdomwindow.c: update unit tests for new APIs.
2244         (load_event_callback): ditto.
2245         (test_dom_domview_signals): ditto.
2246         (load_status_callback): ditto.
2247
2248 2011-03-17  Brady Eidson  <beidson@apple.com>
2249
2250         Reviewed by Sam Weinig.
2251
2252         https://bugs.webkit.org/show_bug.cgi?id=56425
2253         More groundwork for WebKit2 IconDatabase
2254
2255         Update already-used function names:
2256         * webkit/webkiticondatabase.cpp:
2257         (webkit_icon_database_get_icon_uri):
2258         (webkit_icon_database_get_icon_pixbuf):
2259         * webkit/webkitwebview.cpp:
2260         (webkit_web_view_get_icon_uri):
2261
2262 2011-03-16  Joseph Pecoraro  <joepeck@webkit.org>
2263
2264         Reviewed by Kenneth Rohde Christiansen.
2265
2266         Viewport no longer allows an auto value for "user-scalable"
2267         https://bugs.webkit.org/show_bug.cgi?id=55416
2268
2269         Make the default value for userScalable be true.
2270
2271         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2272         (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): update test output to include userScalable.
2273         * webkit/webkitviewportattributes.cpp:
2274         (webkitViewportAttributesRecompute):
2275
2276 2011-03-15  Ilya Sherman  <isherman@chromium.org>
2277
2278         Reviewed by Tony Chang.
2279
2280         Autofilled form elements are assigned fixed background color but not text color
2281         https://bugs.webkit.org/show_bug.cgi?id=48382
2282
2283         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2284         (DumpRenderTreeSupportGtk::setAutofilled): Added.
2285         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2286
2287 2011-03-14  Ryuan Choi  <ryuan.choi@samsung.com>
2288
2289         Reviewed by Martin Robinson.
2290
2291         [GTK] Possible leaks after splitting TextCheckerClientEnchant.
2292         https://bugs.webkit.org/show_bug.cgi?id=55989
2293
2294         Convert gchar* to GOwnPtr<gchar> and refactor the code.
2295
2296         * WebCoreSupport/TextCheckerClientEnchant.cpp:
2297         (WebKit::TextCheckerClientEnchant::checkSpellingOfString):
2298
2299 2011-03-11  Marco Peereboom  <marco@peereboom.us>
2300
2301         Reviewed by Gustavo Noronha Silva.
2302
2303         Provide a knob to enable/disable DNS prefetching.
2304         DNS prefetching is enabled by default.
2305         https://bugs.webkit.org/show_bug.cgi?id=55973
2306
2307         * webkit/webkitwebsettings.cpp:
2308         (webkit_web_settings_class_init):
2309         (webkit_web_settings_set_property):
2310         (webkit_web_settings_get_property):
2311         (webkit_web_settings_copy):
2312         * webkit/webkitwebview.cpp:
2313         (webkit_web_view_update_settings):
2314         (webkit_web_view_settings_notify):
2315
2316 2011-03-08  Philippe Normand  <pnormand@igalia.com>
2317
2318         Reviewed by Martin Robinson.
2319
2320         [GTK] close-web-view emitted on disposed WebView
2321         https://bugs.webkit.org/show_bug.cgi?id=55932
2322
2323         * WebCoreSupport/ChromeClientGtk.cpp:
2324         (ChromeClient::chromeDestroyed): Remove the closeSoonTimer glib
2325         source before destruction of the ChromeClient.
2326
2327 2011-03-11  Roland Steiner  <rolandsteiner@chromium.org>
2328
2329         Reviewed by Ryosuke Niwa.
2330
2331         Bug 55570 - Remove dependency of dom/InputElement.cpp on html/ and wml/
2332         https://bugs.webkit.org/show_bug.cgi?id=55570
2333
2334         Add a virtual function toInputElement() to Node that has a default
2335         implementation of returning 0.
2336         For HTMLInputElement and WMLInputElement (which derive from InputElement)
2337         override this to return the object.
2338         Change all calling sites of the old toInputElement to use the new member
2339         function. This also allows us to save some casts.
2340
2341         No new tests (refactoring).
2342
2343         * src/WebInputElement.cpp:
2344         (WebKit::toWebInputElement):
2345
2346         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2347         (DumpRenderTreeSupportGtk::setValueForUser):
2348
2349 2011-03-10  Philippe Normand  <pnormand@igalia.com>
2350
2351         Reviewed by Xan Lopez.
2352
2353         [GTK] unittests/testapplicationcache crashes
2354         https://bugs.webkit.org/show_bug.cgi?id=56083
2355
2356         Removed the webkit_application_cache_get_database_directory_path
2357         API as the underlying ApplicationCacheStorage doesn't allow
2358         setting the cache path multiple times.
2359
2360         * tests/testapplicationcache.c:
2361         (main):
2362         * webkit/webkitapplicationcache.cpp:
2363         (webkit_application_cache_get_database_directory_path):
2364         * webkit/webkitapplicationcache.h:
2365         * webkit/webkitglobals.cpp:
2366         (webkitInit):
2367
2368 2011-03-09  Peter Kasting  <pkasting@google.com>
2369
2370         Reviewed by Mihai Parparita.
2371
2372         Unify Windows version checks.
2373         https://bugs.webkit.org/show_bug.cgi?id=55979
2374
2375         * webkit/webkitwebsettings.cpp:
2376         (webkitOSVersion):
2377
2378 2011-03-08  Christian Dywan  <christian@lanedo.com>
2379
2380         Reviewed by Martin Robinson.
2381
2382         [GTK] provide an API to control the IconDatabase
2383         https://bugs.webkit.org/show_bug.cgi?id=32510
2384
2385         * GNUmakefile.am:
2386         * WebCoreSupport/FrameLoaderClientGtk.cpp: Emit signals on
2387             the icon database for new icons.
2388         * webkit/webkit.h:
2389         * webkit/webkitdefines.h:
2390         * webkit/webkitglobals.cpp:
2391         * webkit/webkitglobals.h: Add a function to obtain the global
2392             icon database.
2393         * webkit/webkiticondatabase.cpp:
2394         * webkit/webkiticondatabase.h: Implement public icon database
2395             object with methods for obtaining icon URLs, pixbufs, clearing
2396             waiting for new icons.
2397         * webkit/webkitwebview.cpp:
2398         * webkit/webkitwebview.h: Add a method to obtain an icon pixbuf
2399             for the web view.
2400 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2401
2402         Reviewed by Martin Robinson.
2403
2404         [GTK] Add layoutTestController.setValueForUser() after r80412
2405         https://bugs.webkit.org/show_bug.cgi?id=55862
2406
2407         Add setValueForUser method to DumpRenderTreeSupportGTK.
2408
2409         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2410         (DumpRenderTreeSupportGtk::setValueForUser):
2411         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2412
2413 2011-03-07  Sam Weinig  <sam@webkit.org>
2414
2415         Reviewed by Anders Carlsson.
2416
2417         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
2418         https://bugs.webkit.org/show_bug.cgi?id=55827
2419
2420         Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
2421         and pass the entire response, instead of just the MIMEType.
2422
2423         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2424         (WebKit::FrameLoaderClient::dispatchDecidePolicyForResponse):
2425         * WebCoreSupport/FrameLoaderClientGtk.h:
2426
2427 2011-03-01  Martin Robinson  <mrobinson@igalia.com>
2428
2429         Reviewed by Xan Lopez.
2430
2431         [GTK] Windowless plugins override the view cursor
2432         https://bugs.webkit.org/show_bug.cgi?id=55531
2433
2434         * WebCoreSupport/ChromeClientGtk.cpp:
2435         (WebKit::ChromeClient::setCursor): Moved the implementation of setCursor here
2436         which is more fitting since it sets the cursor for the entire window.
2437
2438 2011-03-03  Brady Eidson  <beidson@apple.com>
2439
2440         Reviewed by Darin Adler.
2441
2442         https://bugs.webkit.org/show_bug.cgi?id=55721
2443         Global IconDatabase should be returned by reference, not as a pointer
2444
2445         * webkit/webkitglobals.cpp:
2446         (closeIconDatabaseOnExit):
2447         (WebKit::setIconDatabaseEnabled):
2448         * webkit/webkitwebview.cpp:
2449         (webkit_web_view_get_icon_uri):
2450
2451 2011-03-03  Alexey Proskuryakov  <ap@apple.com>
2452
2453         Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included
2454         via ChromeClient.h
2455
2456         * WebCoreSupport/ChromeClientGtk.h:
2457
2458 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
2459
2460         Reviewed by Darin Adler.
2461
2462         REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
2463         https://bugs.webkit.org/show_bug.cgi?id=55633
2464         <rdar://problem/8963023>
2465
2466         * WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::keyboardUIMode):
2467         * WebCoreSupport/ChromeClientGtk.h:
2468         Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since
2469         this platform doesn't observe or have full keyboard access state.
2470
2471 2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>
2472
2473         Reviewed by Xan Lopez.
2474
2475         [GTK] Extended application cache database API and added unit tests file.
2476         https://bugs.webkit.org/show_bug.cgi?id=55335
2477
2478         * GNUmakefile.am: Add testapplicationcache.c and remove webkitapplicationcacheprivate.h.
2479         * tests/testapplicationcache.c: Added.
2480         (test_applicationcache_maximum_size): Tests if application cache storage is set/get correctly.
2481         (test_applicationcache_database_directory_path): Tests if application cache directory path is set/get correctly.
2482         (main):
2483         * webkit/webkitapplicationcache.cpp:
2484         (webkit_application_cache_get_maximum_size): New API for getting application cache maximum storage size.
2485         * webkit/webkitapplicationcache.h: Declaration of API for getting/setting application cache maximum storage size.
2486         * webkit/webkitapplicationcacheprivate.h: Removed.
2487 2011-03-03  Peter Kasting  <pkasting@google.com>
2488
2489         Reviewed by James Robinson.
2490
2491         Drop redundant "Windows; " from the Windows-specific User Agent string.
2492         https://bugs.webkit.org/show_bug.cgi?id=54567
2493
2494         * webkit/webkitwebsettings.cpp:
2495         (webkitPlatform):
2496         (webkitUserAgent):
2497
2498 2011-03-02  Martin Robinson  <mrobinson@igalia.com>
2499
2500         Reviewed by Xan Lopez.
2501
2502         Do a bit of cleanup in ChromeClientGtk. Instead of always fetching the
2503         WebKitWebView from the frame, simply get it from the member variable of
2504         the ChromeClientGtk instance itself.
2505
2506         * WebCoreSupport/ChromeClientGtk.cpp:
2507         (WebKit::ChromeClient::scrollbarsVisible):
2508         (WebKit::ChromeClient::exceededDatabaseQuota):
2509         (WebKit::ChromeClient::requestGeolocationPermissionForFrame):
2510         (WebKit::ChromeClient::cancelGeolocationPermissionRequestForFrame):
2511         (WebKit::ChromeClient::enterFullscreenForNode):
2512         (WebKit::ChromeClient::exitFullscreenForNode):
2513
2514 2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>
2515
2516         Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.
2517
2518         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2519         (DumpRenderTreeSupportGtk::dumpConfigurationForViewport):
2520         * webkit/webkitviewportattributes.cpp:
2521         (webkitViewportAttributesRecompute):
2522
2523 2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>
2524
2525         Reviewed by Kenneth Rohde Christiansen.
2526
2527         Viewport Warning/Error Messages Are Now Inaccurate
2528         https://bugs.webkit.org/show_bug.cgi?id=53707
2529
2530         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2531         (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): pass a Document into computeViewportAttributes for warnings to be reported to.
2532         * webkit/webkitviewportattributes.cpp:
2533         (webkitViewportAttributesRecompute): pass a Document into computeViewportAttributes for warnings to be reported to.
2534
2535 2011-03-01  Kamil Blank  <k.blank@samsung.com>
2536
2537         Reviewed by Martin Robinson.
2538
2539         [GTK] Fixing headers order in webkit.h.
2540         https://bugs.webkit.org/show_bug.cgi?id=55316
2541
2542         * webkit/webkit.h: Style fix.
2543
2544 2011-03-01  Joone Hur  <joone.hur@collabora.co.uk>
2545
2546         Reviewed by Martin Robinson.
2547
2548         [GTK] Convert use of cairo_t to RefPtr<cairo_t> in webkitwebiew.cpp
2549         https://bugs.webkit.org/show_bug.cgi?id=55437
2550
2551         * webkit/webkitwebview.cpp: Convert use of cairo_t to RefPtr<cairo_t>.
2552         (webkit_web_view_expose_event): 
2553
2554 2011-02-28  Chang Shu  <cshu@webkit.org>
2555
2556         Reviewed by Ryosuke Niwa.
2557
2558         Remove the support of Frame::isContentEditable and its dependencies.
2559         https://bugs.webkit.org/show_bug.cgi?id=54292
2560
2561         Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
2562
2563         * WebCoreSupport/EditorClientGtk.cpp:
2564         * WebCoreSupport/EditorClientGtk.h:
2565         * webkit/webkitwebview.cpp:
2566         (webkit_web_view_init):
2567         (webkit_web_view_get_editable):
2568         (webkit_web_view_set_editable):
2569         * webkit/webkitwebviewprivate.h:
2570
2571 2011-02-26  Lukasz Slachciak  <l.slachciak@samsung.com>
2572
2573         Reviewed by Xan Lopez.
2574
2575         [GTK] Implemented API to set/get web application cache directory path database.
2576
2577         * GNUmakefile.am: Add webkitapplicationcache.h file.
2578         * webkit/webkit.h: Add webkitapplicationcache.h file.
2579         * webkit/webkitapplicationcache.cpp: definition of API setting and getting
2580         web application cache directory path database.
2581         (webkit_application_cache_get_database_directory_path):
2582         (webkit_application_cache_set_database_directory_path):
2583         * webkit/webkitapplicationcache.h: Added new API file for setting and getting
2584         web application cache directory path database.
2585         * webkit/webkitglobals.cpp:
2586         (webkitInit): use webkit_application_cache_set_database_directory_path
2587         to set default web application cache directory path database.
2588
2589 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
2590
2591         Reviewed by Pavel Feldman.
2592
2593         DumpRenderTree should reset frame opener between tests.
2594         https://bugs.webkit.org/show_bug.cgi?id=54874
2595
2596         Added clearOpener method to DumpRenderTreeSupportGTK.
2597
2598         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2599         (DumpRenderTreeSupportGtk::clearOpener):
2600         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2601
2602 2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2603
2604         Reviewed by Andreas Kling.
2605
2606         Make it possible to test the targetdensity-dpi support
2607         https://bugs.webkit.org/show_bug.cgi?id=55142
2608
2609         Test the viewport meta tag feature targetdensity-dpi by
2610         adding extra arguments to dumpConfigurationForViewport
2611
2612         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2613         (DumpRenderTreeSupportGtk::dumpConfigurationForViewport):
2614         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2615
2616 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2617
2618         Unreviewed, rolling out r79764.
2619         http://trac.webkit.org/changeset/79764
2620         https://bugs.webkit.org/show_bug.cgi?id=55295
2621
2622         "broke Chromium builds" (Requested by rniwa on #webkit).
2623
2624         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2625         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2626
2627 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
2628
2629         Reviewed by Pavel Feldman.
2630
2631         DumpRenderTree should reset frame opener between tests.
2632         https://bugs.webkit.org/show_bug.cgi?id=54874
2633
2634         Added clearOpener method to DumpRenderTreeSupportGTK.
2635
2636         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2637         (DumpRenderTreeSupportGtk::clearOpener):
2638         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2639
2640 2011-02-24  Peter Kasting  <pkasting@google.com>
2641
2642         Reviewed by Eric Seidel.
2643
2644         Drop the "U; " encryption level from the User Agent string.
2645         https://bugs.webkit.org/show_bug.cgi?id=54566
2646
2647         * webkit/webkitwebsettings.cpp:
2648         (webkitUserAgent):
2649
2650 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
2651
2652         Unreviewed, rolling out r79570.
2653         http://trac.webkit.org/changeset/79570
2654         https://bugs.webkit.org/show_bug.cgi?id=54874
2655
2656         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
2657         was not updated
2658
2659         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2660         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2661
2662 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
2663
2664         Reviewed by Alexey Proskuryakov.
2665
2666         DumpRenderTree should reset frame opener between tests.
2667         https://bugs.webkit.org/show_bug.cgi?id=54874
2668
2669         Added clearOpener method to DumpRenderTreeSupportGTK.
2670
2671         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2672         (DumpRenderTreeSupportGtk::clearOpener):
2673         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2674
2675 2011-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2676
2677         Reviewed by Alexey Proskuryakov.
2678
2679         Drop the language tag part from the User Agent string
2680         https://bugs.webkit.org/show_bug.cgi?id=54560
2681
2682         * webkit/webkitwebsettings.cpp:
2683         (webkitUserAgent):
2684
2685 2011-02-22  Martin Robinson  <mrobinson@igalia.com>
2686
2687         Reviewed by Xan Lopez.
2688
2689         [GTK] position:fixed elements flicker while scrolling after r74196
2690         https://bugs.webkit.org/show_bug.cgi?id=54981
2691
2692         * WebCoreSupport/ChromeClientGtk.cpp:
2693         (WebKit::ChromeClient::ChromeClient): Initialize the new m_pendingScrollInvalidations
2694         boolean to false.
2695         (WebKit::ChromeClient::invalidateWindow): If this is an immediate invalidation and we
2696         having pending scrolling invalidations, instruct GDK to process updates now.
2697         (WebKit::ChromeClient::scroll): Remove the call to gdk_window_process_updates. Set
2698         m_pendingScrollInvalidations to true to force it to happen in invalidateWindow instead.
2699         * WebCoreSupport/ChromeClientGtk.h: Add new boolean member.
2700
2701 2011-02-02  Martin Robinson  <mrobinson@igalia.com>
2702
2703         Reviewed by Xan Lopez.
2704
2705         [GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
2706         https://bugs.webkit.org/show_bug.cgi?id=53603
2707
2708         Add setSelectTrailingWhitespaceEnabled and selectTrailingWhitespaceEnabled which allow
2709         setting and querying the selectTrailingWhitespaceEnabled setting. EditorClient just
2710         listens to this value during DRT runs. Perhaps later we can expose this to the public
2711         API.
2712
2713         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2714         (DumpRenderTreeSupportGtk::setSelectTrailingWhitespaceEnabled): Added
2715         (DumpRenderTreeSupportGtk::selectTrailingWhitespaceEnabled): Added
2716         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2717         * WebCoreSupport/EditorClientGtk.cpp:
2718         (WebKit::EditorClient::isSelectTrailingWhitespaceEnabled): Ask DRTSupportGtk
2719         for the appropriate return value.
2720
2721 2011-02-21  Alejandro G. Castro  <alex@igalia.com>
2722
2723         Reviewed by Xan Lopez.
2724
2725         [GTK] [REGRESSION] After r79130, spell tests did not work
2726         https://bugs.webkit.org/show_bug.cgi?id=54860
2727
2728         * WebCoreSupport/TextCheckerClientEnchant.cpp:
2729         (WebKit::TextCheckerClientEnchant::checkSpellingOfString): Avoided
2730         freeing the default PangoLanguage.
2731         * webkit/webkitwebview.cpp:
2732         (webkit_web_view_update_settings): Initialized list of dictionaries.
2733
2734 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
2735
2736         Reviewed by Kent Tamura.
2737
2738         Rename Position::node() to Position::deprecatedNode()
2739         https://bugs.webkit.org/show_bug.cgi?id=54622
2740
2741         Done the rename. All calls to node() are replaced by calls to deprecatedNode().
2742
2743         * webkit/webkitwebview.cpp:
2744         (webkit_web_view_popup_menu_handler):
2745
2746 2011-02-19  Ryuan Choi  <ryuan.choi@samsung.com>
2747
2748         Reviewed by Martin Robinson.
2749
2750         [GTK] Remove mandatory Enchant dependency
2751         https://bugs.webkit.org/show_bug.cgi?id=51587
2752
2753         Extract TextCheckerClientEnchant From EditorClientGtk and remove
2754         enchant dependency from other files.
2755
2756         * GNUmakefile.am:
2757         * WebCoreSupport/EditorClientGtk.cpp:
2758         (WebKit::EditorClient::EditorClient):
2759         * WebCoreSupport/EditorClientGtk.h:
2760         (WebKit::EditorClient::textChecker):
2761         * WebCoreSupport/TextCheckerClientEnchant.cpp: Added.
2762         (WebKit::TextCheckerClientEnchant::TextCheckerClientEnchant):
2763         (WebKit::TextCheckerClientEnchant::~TextCheckerClientEnchant):
2764         (WebKit::TextCheckerClientEnchant::ignoreWordInSpellDocument):
2765         (WebKit::TextCheckerClientEnchant::learnWord):
2766         (WebKit::TextCheckerClientEnchant::checkSpellingOfString):
2767         (WebKit::TextCheckerClientEnchant::getAutoCorrectSuggestionForMisspelledWord):
2768         (WebKit::TextCheckerClientEnchant::checkGrammarOfString):
2769         (WebKit::TextCheckerClientEnchant::getGuessesForWord):
2770         (WebKit::getAvailableDictionariesCallback):
2771         (WebKit::TextCheckerClientEnchant::updateSpellCheckingLanguage):
2772         (WebKit::TextCheckerClientEnchant::freeSpellCheckingLanguage):
2773         * WebCoreSupport/TextCheckerClientEnchant.h: Added.
2774         (WebKit::TextCheckerClientEnchant::requestCheckingOfString):
2775         * webkit/webkitwebsettings.cpp:
2776         (webkit_web_settings_finalize):
2777         (webkit_web_settings_set_property):
2778         * webkit/webkitwebview.cpp:
2779         (webkit_web_view_settings_notify):
2780
2781 2011-02-19  Charlie Reis  <creis@chromium.org>
2782
2783         Reviewed by Mihai Parparita.
2784
2785         Ensure loading has stopped in HistoryController::goToItem
2786         https://bugs.webkit.org/show_bug.cgi?id=54517
2787
2788         Add a FrameLoaderClient callback for whether to stop loading before goToItem.
2789
2790         Test: http/tests/navigation/forward-to-fragment-fires-onload.html
2791
2792         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2793         (WebKit::FrameLoaderClientGtk::shouldStopLoadingForHistoryItem): Added.
2794         * WebCoreSupport/FrameLoaderClientGtk.h:
2795
2796 2011-02-18  Mario Sanchez Prada  <msanchez@igalia.com>
2797
2798         Reviewed by Martin Robinson.
2799
2800         [Gtk] atk_text_get_selection/atk_text_set_selection fails for list items
2801         https://bugs.webkit.org/show_bug.cgi?id=53453
2802
2803         Update unit test to check the fix for this bug.
2804
2805         * tests/testatk.c:
2806         (testWebkitAtkTextSelections): Check that functions from AtkText
2807         interface to set and get text selections work with list items.
2808
2809 2011-02-17  Robert Ancell  <rober.ancell@gmail.com>
2810
2811         Reviewed by Martin Robinson.
2812
2813         [PATCH] GTK documentation fails to build due to changed paths
2814         https://bugs.webkit.org/show_bug.cgi?id=54600
2815
2816         * docs/GNUmakefile.am: Update the paths that have now moved the Source
2817         directory.
2818
2819 2011-02-16  Joone Hur  <joone.hur@collabora.co.uk>
2820
2821         Reviewed by Xan Lopez.
2822
2823         [GTK] Match more various WebKit API enum values with WebCore enum values
2824         https://bugs.webkit.org/show_bug.cgi?id=54352
2825
2826         AssertMatchingEnums.cpp was added to assert that various WebKit API enum values 
2827         continue matching WebCore defined enum values in the following changeset.
2828         http://trac.webkit.org/changeset/77868
2829         However, there are already enum values that have been asserted in other files, 
2830         so these assert macros defined need to be moved to AssertMatchingEnum.cpp.  
2831
2832         * WebCoreSupport/AssertMatchingEnums.cpp: Add more enum values to be asserted.
2833         * webkit/webkitwebnavigationaction.cpp:  
2834         (webkit_web_navigation_action_class_init): Move the assert macros of 
2835         WEBKIT_WEB_NAVIGATION_REASON_* to AssertMatchingEnums.cpp.
2836         * webkit/webkitwebsettings.cpp:
2837         (webkit_web_settings_class_init): Move the assert macros of WEBKIT_EDITING_BEHAVIOR_* 
2838         to AssertMatchingEnums.cpp.
2839
2840 2011-02-16  Mario Sanchez Prada  <msanchez@igalia.com>
2841
2842         Reviewed by Martin Robinson.
2843
2844         [GTK] events missing when a document is (re)loaded
2845         https://bugs.webkit.org/show_bug.cgi?id=25831
2846
2847         Emit the right signals when reloading a document.
2848
2849         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2850         (WebKit::notifyAccessibilityStatus): New function, to make sure
2851         the signals involved in reloading a document are properly emitted.
2852         (WebKit::notifyStatus): Also notify accessibility if enabled.
2853
2854 2011-02-15  Kenneth Russell  <kbr@google.com>
2855
2856         Reviewed by Darin Fisher.
2857
2858         Allow controlling minimum DOMTimer interval on a per-page basis
2859         https://bugs.webkit.org/show_bug.cgi?id=54312
2860
2861         Added needed methods to implement LayoutTestController's new
2862         setMinimumTimerInterval method.
2863
2864         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2865         (DumpRenderTreeSupportGtk::defaultMinimumTimerInterval):
2866         (DumpRenderTreeSupportGtk::setMinimumTimerInterval):
2867         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2868
2869 2011-02-15  Christian Dywan  <christian@lanedo.com>
2870
2871         Rubber-stamped by Gustavo Noronha Silva.
2872
2873         * webkit/webkitwebsettings.cpp: Correct a typo, it is
2874             acces*s*ibility with two s.
2875
2876 2011-01-26  MORITA Hajime  <morrita@google.com>
2877
2878         Reviewed by Ryosuke Niwa.
2879
2880         Refactoring: Extract TextCheckerClient from EditorClient
2881         https://bugs.webkit.org/show_bug.cgi?id=53213
2882
2883         * WebCoreSupport/EditorClientGtk.h:
2884         (WebKit::EditorClient::textChecker):
2885
2886 2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>
2887
2888         Reviewed by Adam Barth.
2889
2890         Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
2891         https://bugs.webkit.org/show_bug.cgi?id=52417
2892
2893         Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
2894         not implemented.
2895
2896         * WebCoreSupport/EditorClientGtk.cpp:
2897         (WebKit::EditorClient::canCopyCut): Added.
2898         (WebKit::EditorClient::canPaste): Added.
2899         * WebCoreSupport/EditorClientGtk.h:
2900
2901 2011-02-14  Alejandro G. Castro  <alex@igalia.com>
2902
2903         Reviewed by Xan Lopez.
2904
2905         [GTK] testwebdatasource test fails in the bots
2906         https://bugs.webkit.org/show_bug.cgi?id=54414
2907
2908         Changed the uri we check, added www to avoid the rewrite that we
2909         get when we as the uri to the request in case it finishes.
2910
2911         * tests/testwebdatasource.c:
2912         (notify_load_status_cb):
2913
2914 2011-02-11  Sheriff Bot  <webkit.review.bot@gmail.com>
2915
2916         Unreviewed, rolling out r78331.
2917         http://trac.webkit.org/changeset/78331
2918         https://bugs.webkit.org/show_bug.cgi?id=54295
2919
2920         This patch broke 11 tests in GTK bots (Requested by svillar on
2921         #webkit).
2922
2923         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2924         (WebKit::notifyStatus):
2925
2926 2011-02-10  Nate Chapin  <japhet@chromium.org>
2927
2928         Reviewed by Adam Barth.
2929
2930         Update calls to DocumentWriter.
2931         https://bugs.webkit.org/show_bug.cgi?id=50489
2932
2933         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2934         (WebKit::FrameLoaderClient::FrameLoaderClient):
2935         (WebKit::FrameLoaderClient::didRunInsecureContent):
2936         (WebKit::FrameLoaderClient::dispatchDidLoadMainResource):
2937         (WebKit::FrameLoaderClient::finishedLoading):
2938         * WebCoreSupport/FrameLoaderClientGtk.h:
2939         * webkit/webkitwebview.cpp:
2940         (webkit_web_view_get_encoding):
2941
2942 2011-02-11  Mario Sanchez Prada  <msanchez@igalia.com>
2943
2944         Reviewed by Xan Lopez.
2945
2946         [GTK] events missing when a document is (re)loaded
2947         https://bugs.webkit.org/show_bug.cgi?id=25831
2948
2949         Emit the right signals when reloading a document.
2950
2951         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2952         (WebKit::notifyAccessibilityStatus): New function, to make sure
2953         the signals involved in reloading a document are properly emitted.
2954         (WebKit::notifyStatus): Also notify accessibility if enabled.
2955
2956 2011-02-08  Martin Robinson  <mrobinson@igalia.com>
2957
2958         Reviewed by Xan Lopez.
2959
2960         [GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
2961         https://bugs.webkit.org/show_bug.cgi?id=54033
2962
2963         Add a DumpRenderTreeSupportGtk method for turning the icon database on and off.
2964         This is a likely candidate for a new API point.
2965
2966         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2967         (DumpRenderTreeSupportGtk::setIconDatabaseEnabled): Added.
2968         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2969         * webkit/webkitglobals.cpp:
2970         (webkitInit): Call setIconDatabaseEnabled(true) on startup, instead
2971         of initializing the database manually.
2972         (WebKit::setIconDatabaseEnabled): Added.
2973         * webkit/webkitglobalsprivate.h: Added declarations.
2974
2975 2011-02-08  Adam Barth  <abarth@webkit.org>
2976
2977         Reviewed by Eric Seidel.
2978
2979         Remove orphan code from old parser
2980         https://bugs.webkit.org/show_bug.cgi?id=53984
2981
2982         * WebCoreSupport/ChromeClientGtk.h:
2983
2984 2011-02-02  Ilya Tikhonovsky  <loislo@chromium.org>
2985
2986         Reviewed by Yury Semikhatsky.
2987
2988         Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
2989
2990         https://bugs.webkit.org/show_bug.cgi?id=53169
2991
2992         Minor change enforced by major changes in WebCore/inspector/InspectorController.
2993
2994         * WebCoreSupport/InspectorClientGtk.cpp:
2995         * webkit/webkitwebinspector.cpp:
2996         (webkit_web_inspector_get_property):
2997
2998 2011-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2999
3000         Reviewed by Martin Robinson.
3001
3002         [GTK] DRT's TextInputController is unimplemented on GTK
3003         https://bugs.webkit.org/show_bug.cgi?id=52997
3004
3005         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
3006         (DumpRenderTreeSupportGtk::setComposition):
3007         (DumpRenderTreeSupportGtk::confirmComposition):
3008         (DumpRenderTreeSupportGtk::firstRectForCharacterRange):
3009         (DumpRenderTreeSupportGtk::selectedRange): New methods needed by
3010         TextInputController.
3011         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
3012
3013 2011-02-07  Enrica Casucci  <enrica@apple.com>
3014
3015         Reviewed Adam Roben and Darin Adler.
3016
3017         WebKit2: drag and drop support on Windows.
3018         https://bugs.webkit.org/show_bug.cgi?id=52775
3019
3020         Removed createDragImageForLink from DragClient.
3021
3022         * WebCoreSupport/DragClientGtk.cpp:
3023         * WebCoreSupport/DragClientGtk.h:
3024
3025 2011-02-07  Joone Hur  <joone.hur@collabora.co.uk>
3026
3027         Reviewed by Martin Robinson.
3028
3029         [Gtk] Implement layoutTestController.findString
3030         https://bugs.webkit.org/show_bug.cgi?id=50237
3031
3032         * GNUmakefile.am: Add AssertMatchingEnums.cpp.
3033         * WebCoreSupport/AssertMatchingEnums.cpp: Add this file to assert that various 
3034         WebKit API enum values continue matching WebCore defined enum values.
3035         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
3036         (DumpRenderTreeSupportGtk::findString):
3037         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
3038
3039 2011-02-07  Martin Robinson  <mrobinson@igalia.com>
3040
3041         Reviewed by Daniel Bates.
3042
3043         [GTK] fast/history/history-subframe-with-name.html fails with GTK DRT
3044         https://bugs.webkit.org/show_bug.cgi?id=44784
3045
3046         Call FrameLoader::loadURLIntoChildFrame on the parent frame's loader, not the child's. 
3047
3048         * WebCoreSupport/FrameLoaderClientGtk.cpp:
3049         (WebKit::FrameLoaderClient::createFrame): Fix the call to FrameLoader::loadURLIntoChildFrame.
3050
3051 2011-02-07  Mario Sanchez Prada  <msanchez@igalia.com>
3052
3053         Reviewed by Xan Lopez.
3054
3055         [Gtk] atk_text_get_caret_offset fails for list items
3056         https://bugs.webkit.org/show_bug.cgi?id=53436
3057
3058         Update unit test to check the fix for this bug.
3059
3060         * tests/testatk.c:
3061         (testWebkitAtkCaretOffsets): Check that the caret offset returned
3062         match the value previously set.
3063
3064 2011-02-04  Joone Hur  <joone.hur@collabora.co.uk>
3065
3066         Unreviewed, Fix compilation warning.
3067
3068         Constructor initialization list should follow the declaration order.
3069
3070         * WebCoreSupport/FrameLoaderClientGtk.cpp:
3071         (WebKit::FrameLoaderClient::FrameLoaderClient): m_hasRepresentation is moved to 
3072         the last position in the initialization list.
3073
3074 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
3075
3076         Reviewed by Xan Lopez.
3077
3078         [GTK] WebKitWebFrame can return a stale frame name when calling webkit_web_frame_get_name
3079         https://bugs.webkit.org/show_bug.cgi?id=53797
3080
3081         When the frame name changes between different calls to webkit_web_frame_get_name
3082         on the same frame, return the new frame name instead of the one valid during the
3083         previous call.
3084
3085         * webkit/webkitwebframe.cpp:
3086         (webkit_web_frame_init): Initialize the frame name to 0.
3087         (webkit_web_frame_get_name): Check the current frame name first before
3088         returning the cached value.
3089
3090 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
3091
3092         Reviewed by Gustavo Noronha Silva.
3093
3094         [GTK] fast/events/pagehide-timeout.html fails
3095         https://bugs.webkit.org/show_bug.cgi?id=53771
3096
3097         Add the document browser cache model. This model is optimized for viewing
3098         a series of local files, while the document viewer is optimized for only
3099         viewing one local file. Improve the documentation on the mapping of these
3100         enum values to actual cache settings.
3101
3102         * webkit/webkitglobals.cpp:
3103         (webkit_set_cache_model): Add support for the document browser cache model and
3104         improve comments in this section better explaining where the magic numbers come from.
3105         * webkit/webkitglobals.h: Added an enum value for the document browser cache model.
3106
3107 2011-02-03  Yury Semikhatsky  <yurys@chromium.org>
3108
3109         Reviewed by Pavel Feldman.
3110
3111         Web Inspector: remove settings related methods from InspectorClient
3112         https://bugs.webkit.org/show_bug.cgi?id=53686
3113
3114         * WebCoreSupport/InspectorClientGtk.cpp:
3115         (WebKit::InspectorFrontendClient::InspectorFrontendClient):
3116         * WebCoreSupport/InspectorClientGtk.h:
3117
3118 2011-02-03  Adam Langley  <agl@chromium.org>
3119
3120         Reviewed by Adam Barth.
3121
3122         Plumb mixed script URL to FrameLoaderClient
3123         https://bugs.webkit.org/show_bug.cgi?id=52384
3124
3125         Regressions covered by http/tests/security/mixedContent/*
3126
3127         * WebCoreSupport/FrameLoaderClientGtk.cpp:
3128         (WebKit::FrameLoaderClient::didRunInsecureContent):
3129         * WebCoreSupport/FrameLoaderClientGtk.h:
3130
3131 2011-02-03  Joone Hur  <joone.hur@collabora.co.uk>
3132
3133         Reviewed by Martin Robinson.
3134
3135         [Gtk] No need to set text encoding in the provisional phase
3136         https://bugs.webkit.org/show_bug.cgi?id=53487
3137
3138         According to changeset 67253, setEncoding could be called multiple times from 
3139         committedLoad, finishedLoading, dispatchDidFailLoading, and setMainDocumentError 
3140         in FrameLoaderClient. To fix this, the relevant code was removed from 
3141         FrameLoaderClient and moved to DocumentLoader::commitData. However, that 
3142         code was not removed from FrameLoaderClient::finishedLoading in WebKitGtk+.
3143
3144         Due to this reason, after loading a html document, other ports initialize the 
3145         text encoding from FrameLoaderClient::finishedLoading, but WebKitGtk+ sets 
3146         the same encoding again, even tries to set encoding in the provisional phase. 
3147         This causes unnecessary encoding setting.
3148
3149         * WebCoreSupport/FrameLoaderClientGtk.cpp:
3150         (WebKit::FrameLoaderClient::FrameLoaderClient): Set m_hasRepresentation to false.
3151         (WebKit::FrameLoaderClient::makeRepresentation): Set m_hasRepresentation to true.
3152         (WebKit::FrameLoaderClient::revertToProvisionalState): Set m_hasRepresentation to true.
3153         (WebKit::FrameLoaderClient::finishedLoading): Skip the encoding setting when 
3154         m_hasRepresentation is false.
3155         * WebCoreSupport/FrameLoaderClientGtk.h: Added m_hasRepresentation.
3156
3157 2011-02-02  Alejandro G. Castro  <alex@igalia.com>
3158
3159         Reviewed by Martin Robinson.
3160
3161         Update the NEWS file in preparation for the 1.3.11 release.
3162
3163         * NEWS: Update the NEWS.
3164
3165 2011-02-02  Dan Winship  <danw@gnome.org>
3166
3167         Reviewed by Martin Robinson.
3168
3169         [GTK] drop soup cache stuff, which has been moved to libsoup
3170         https://bugs.webkit.org/show_bug.cgi?id=50747
3171
3172         * GNUmakefile.am: Remove old cache files.
3173
3174 2011-02-02  David Hyatt  <hyatt@apple.com>
3175
3176         Reviewed by Darin Adler.
3177
3178         Removal of right()/bottom(), converting to maxX()/maxY().
3179
3180         * webkit/webkitwebview.cpp:
3181         (webkit_web_view_popup_menu_handler):
3182
3183 2011-02-01  Mario Sanchez Prada  <msanchez@igalia.com>
3184
3185         Reviewed by Martin Robinson.
3186
3187         [Gtk] atk_text_set_caret_offset fails for list items
3188         https://bugs.webkit.org/show_bug.cgi?id=53388
3189
3190         Update unit test to check the fix for this bug.
3191
3192         * tests/testatk.c:
3193         (testWebkitAtkCaretOffsets): Ensure setting the caret in a list
3194         item through the AtkText interface is possible.
3195
3196 2011-02-01  Mario Sanchez Prada  <msanchez@igalia.com>
3197
3198         Reviewed by Martin Robinson.
3199
3200         [GTK] character range extents is off when the end of a wrapped line is included
3201         https://bugs.webkit.org/show_bug.cgi?id=53323
3202
3203         Update unit test to check the fix for this bug.
3204
3205         * tests/testatk.c:
3206         (testWebkitAtkGetExtents): Check that the extent for a full line
3207         are the same height than for a partial section of the same line.
3208
3209 2011-02-01  Mario Sanchez Prada  <msanchez@igalia.com>
3210
3211         Reviewed by Martin Robinson.
3212
3213         [GTK] Caret Offset is one off at the end of wrapped lines
3214         https://bugs.webkit.org/show_bug.cgi?id=53300
3215
3216         Update unit test to check the fix for this bug.
3217
3218         * tests/testatk.c:
3219         (testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces): Set and get
3220         the caret offset at the edge of the line.
3221
3222 2011-01-31  Mario Sanchez Prada  <msanchez@igalia.com>
3223
3224         Reviewed by Martin Robinson.
3225
3226         [Gtk] atk_text_set_caret_offset returns True even when it is unsuccessful
3227         https://bugs.webkit.org/show_bug.cgi?id=53389
3228
3229         New unit test to check the fix for this bug.
3230
3231         * tests/testatk.c:
3232         (testWebkitAtkCaretOffsets): New.
3233         (main): Add new test.
3234
3235 2011-01-29  Dan Winship  <danw@gnome.org>
3236
3237         Reviewed by Xan Lopez.
3238
3239         [GTK] Remove HAVE_LIBSOUP_2_29_90 and HAVE_GSETTINGS conditionals;
3240         we depend on glib 2.27.4 and libsoup 2.33.1 now.
3241         https://bugs.webkit.org/show_bug.cgi?id=50675
3242
3243         * GNUmakefile.am:
3244         * WebCoreSupport/InspectorClientGtk.cpp:
3245         (WebKit::InspectorClient::storeSetting):
3246         * webkit/webkitprivate.cpp:
3247         (inspectorGSettings):
3248         * webkit/webkitprivate.h:
3249
3250 2011-01-28  Dan Bernstein  <mitz@apple.com>
3251
3252         Reviewed by Sam Weinig.
3253
3254         <select> can't display right-to-left (rtl) languages
3255         https://bugs.webkit.org/show_bug.cgi?id=19785
3256
3257         * WebCoreSupport/ChromeClientGtk.cpp:
3258         (WebKit::ChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.
3259         * WebCoreSupport/ChromeClientGtk.h:
3260
3261 2011-01-28  Alejandro G. Castro  <alex@igalia.com>
3262
3263         Reviewed by Xan Lopez.
3264
3265         [GTK] Fix compilation warning
3266         https://bugs.webkit.org/show_bug.cgi?id=53292
3267
3268         * webkit/webkitwebframe.cpp:
3269         (draw_page_callback): Cast the pageCount from size_t to int, it
3270         should be safe considering page_nr is the number of pages,
3271         0-based.
3272
3273 2011-01-27  Nate Chapin  <japhet@chromium.org>
3274
3275         Reviewed by Adam Barth.
3276
3277         Use Document::url() instead of FrameLoader::url().
3278         https://bugs.webkit.org/show_bug.cgi?id=41165
3279
3280         * webkit/webkitwebview.cpp:
3281         (webkit_web_view_get_icon_uri):
3282
3283 2011-01-27  Mario Sanchez Prada  <msanchez@igalia.com>
3284
3285         Reviewed by Martin Robinson.
3286
3287         [GTK] Space characters in source document interfere with reported caret offset
3288         https://bugs.webkit.org/show_bug.cgi?id=53033
3289
3290         New unit test to check the fix for this bug.
3291
3292         * tests/testatk.c:
3293         (testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces): New.
3294         (main): Add new unit test.
3295
3296 2011-01-26  Mario Sanchez Prada  <msanchez@igalia.com>
3297
3298         Reviewed by Martin Robinson.
3299
3300         [GTK] Reliable crash with getTextAtOffset()
3301         https://bugs.webkit.org/show_bug.cgi?id=53131
3302
3303         New unit test to check the fix for this bug.
3304
3305         * tests/testatk.c:
3306         (testWebkitAtkGetTextAtOffsetWithSpecialCharacters): New.
3307         (main): Add new unit test.
3308
3309 2011-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3310
3311         Reviewed by Martin Robinson.
3312
3313         [GTK] Show caps lock indicator in password fields
3314         https://bugs.webkit.org/show_bug.cgi?id=52878
3315
3316         Test: manual-tests/password-caps-lock.html
3317
3318         * webkit/webkitwebview.cpp:
3319         (webkit_web_view_key_release_event): Call
3320         capsLockStateMayHaveChanged() when caps lock key is pressed.
3321
3322 2011-01-19  Joone Hur  <joone.hur@collabora.co.uk>
3323
3324         Reviewed by Andreas Kling.
3325
3326         [GTK] No need to invalidate empty areas in ChromeClient::invalidateContentsAndWindow
3327         https://bugs.webkit.org/show_bug.cgi?id=52702
3328
3329         Don't call gdk_window_invalidate_rect if an updated rectangle is empty.
3330
3331         * WebCoreSupport/ChromeClientGtk.cpp:
3332         (WebKit::ChromeClient::invalidateContentsAndWindow): 
3333
3334 2011-01-17  Philippe Normand  <pnormand@igalia.com>
3335
3336         Unreviewed, build fix for 2 GTK tests html file paths.
3337
3338         * tests/testmimehandling.c:
3339         (main):
3340         * tests/testwebview.c:
3341
3342 2011-01-16  Adam Barth  <abarth@webkit.org>
3343
3344         Rubber-stamped by Eric Seidel.
3345
3346         Move WebKit into Source
3347         https://bugs.webkit.org/show_bug.cgi?id=52530
3348
3349         * GNUmakefile.am:
3350
3351 2011-01-14  Yuzo Fujishima  <yuzo@google.com>
3352
3353         Reviewed by Antti Koivisto.
3354
3355         Rename cache() to memoryCache()
3356         https://bugs.webkit.org/show_bug.cgi?id=52433
3357
3358         * webkit/webkitglobals.cpp:
3359         (webkit_set_cache_model):
3360
3361 2011-01-14  Pavel Feldman  <pfeldman@chromium.org>
3362
3363         Not reviewed: gtk build fix (2).
3364
3365         * webkit/webkitwebview.cpp:
3366
3367 2011-01-14  Pavel Feldman  <pfeldman@chromium.org>
3368
3369         Not reviewed: gtk build fix.
3370
3371         * webkit/webkitwebinspector.cpp:
3372
3373 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
3374
3375         Reviewed by Martin Robinson.
3376
3377         [gtk] Zero-sized font does not yet work
3378         https://bugs.webkit.org/show_bug.cgi?id=49793
3379
3380         Allow 0 as a minimum-font-size value for the settings.
3381
3382         * webkit/webkitwebsettings.cpp:
3383         (webkit_web_settings_class_init):
3384
3385 2011-01-12  Philippe Normand  <pnormand@igalia.com>
3386
3387         Unreviewed build fix for 32-bits Release. Include GRefPtrGtk.h so
3388         the GdkCursor templates are found and used at runtime.
3389
3390         * WebCoreSupport/FullscreenVideoController.cpp:
3391
3392 2011-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3393
3394         Reviewed by Martin Robinson.
3395
3396         [GTK] GRefPtr should not be used with Gtk widgets
3397         https://bugs.webkit.org/show_bug.cgi?id=51241
3398
3399         GRefPtr breaks the widget life-cycle, the main problem is
3400         that GRefPtr calls g_object_unref() when it's destroyed,
3401         which is undesirable for widgets. In gtk+ widgets are created with
3402         a floating reference and when added to a container, the container
3403         takes the ownership of the widget consuming the floating
3404         reference. So you don't usually need to call g_object_ref/unref on
3405         widgets (only for some operations like reparent a widget) and
3406         toplevel widgets are destroyed with gtk_widget_destroy().
3407
3408         * WebCoreSupport/DragClientGtk.cpp:
3409         (WebKit::DragClient::DragClient):
3410         (WebKit::DragClient::~DragClient):
3411         (WebKit::DragClient::startDrag):
3412         * WebCoreSupport/DragClientGtk.h:
3413         * WebCoreSupport/FrameLoaderClientGtk.cpp:
3414         (WebKit::postCommitFrameViewSetup):
3415         * webkit/webkitwebview.cpp:
3416         (webkit_web_view_dispose):
3417         * webkit/webkitwebviewprivate.h:
3418
3419 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3420
3421         Reviewed by Xan Lopez.
3422
3423         Update the NEWS file in preparation for the 1.3.10 release.
3424
3425         * NEWS: Update the NEWS.
3426
3427 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3428
3429         Reviewed by Xan Lopez.
3430
3431         [GTK] Remove use of deprecated GTK+ methods before the 1.3.10 release
3432         https://bugs.webkit.org/show_bug.cgi?id=52173
3433
3434         * WebCoreSupport/FullscreenVideoController.cpp:
3435         (FullscreenVideoController::enterFullscreen): Use a GRefPtr here to avoid having to
3436         call either g_object_unref or gdk_cursor_unref.
3437         * webkit/webkitwebview.cpp: Guard use of deprecated methods.
3438         (webkit_web_view_realize): Ditto.
3439         (webkit_web_view_drag_end): Ditto.
3440
3441 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3442
3443         Reviewed by Xan Lopez.
3444
3445         [GTK] Fix gtk2 compilation for master
3446         https://bugs.webkit.org/show_bug.cgi?id=51885
3447
3448         * webkit/webkitsoupauthdialog.c:
3449         (show_auth_dialog): Removed the call to
3450         gtk_dialog_set_has_separator API to remove a warning.
3451
3452 2011-01-10  Xan Lopez  <xlopez@igalia.com>
3453
3454         Reviewed by Martin Robinson.
3455
3456         [GTK] Create intermediate libWebCore library
3457         https://bugs.webkit.org/show_bug.cgi?id=52116
3458
3459         * GNUmakefile.am: add libWebCore.la to LIBADD and remove webcore
3460         sources from the libwebkit library SOURCES.
3461
3462 2011-01-09  Xianzhu Wang <phnixwxz@gmail.com>
3463
3464         Reviewed by Darin Fisher.
3465
3466         https://bugs.webkit.org/show_bug.cgi?id=41441
3467         createWindow method should only do window-creating without URL navigation
3468
3469         * WebCoreSupport/ChromeClientGtk.cpp:
3470         (WebKit::ChromeClient::createWindow):
3471
3472 2011-01-08  Martin Robinson  <mrobinson@igalia.com>
3473
3474         GTK+ build fix. Adding missing headers to the source list, fixing make dist.
3475
3476         * GNUmakefile.am: Fix make dist.
3477
3478 2011-01-07  Adam Barth  <abarth@webkit.org>
3479
3480         Rubber-stamped by Eric Seidel.
3481
3482         Move WebCore to Source
3483         https://bugs.webkit.org/show_bug.cgi?id=52050
3484
3485         * GNUmakefile.am:
3486
3487 2011-01-07  Mario Sanchez Prada  <msanchez@igalia.com>
3488
3489         Reviewed by Chris Fleizach.
3490
3491         GTK: AX: atk tests need to be updated after recent changes
3492         https://bugs.webkit.org/show_bug.cgi?id=51932
3493
3494         Fix gtk_widget_get_accessible() in WebKitWebView to keep returning
3495         the AtkObject of role ATK_ROLE_DOCUMENT_FRAME.
3496
3497         With the change to support WK2 accessibility, the root object of
3498         the AX hierarchy is different from what GTK expects as the current
3499         hirarchy right now includes a new accessible object as the parent
3500         of the accessible web area (AXScrollView).
3501
3502         * webkit/webkitwebview.cpp:
3503         (webkit_web_view_get_accessible): Return the first child of the
3504         wrapper associated to the root accessible object in the document,
3505         to keep everything in the GTK port working as it used to be.
3506
3507         Re-enable skipped ATK unit tests now they are passing again.
3508
3509         * tests/testatk.c:
3510         (main): Re-enable skipped tests.
3511         * tests/testatkroles.c:
3512         (main): Ditto.
3513
3514 2011-01-06  Martin Robinson  <mrobinson@igalia.com>
3515
3516         Reviewed by Xan Lopez.
3517
3518         GTK: AX: atk tests need to be updated after recent changes
3519         https://bugs.webkit.org/show_bug.cgi?id=51932
3520
3521         Skip ATK unit tests until we can look into what is causing these failures.
3522
3523         * tests/testatk.c:
3524         (main): Skip all tests.
3525         * tests/testatkroles.c:
3526         (main): Ditto.
3527
3528 2011-01-06  Martin Robinson  <mrobinson@igalia.com>
3529
3530         Reviewed by Xan Lopez.
3531
3532         Include a new header in the static headers list. This is necessary
3533         so that "make install" installs the header.
3534
3535         * GNUmakefile.am: Include webkitglobals.h in the header list.
3536
3537 2011-01-05  Martin Robinson  <mrobinson@igalia.com>
3538
3539         Reviewed by Gustavo Noronha.
3540
3541         Build fix for GTK+ 3.x. Remove the call to gtk_range_set_update_policy.
3542         GTK+ 3.x has removed this method and the default in GTK+ 2.x is continuous,
3543         so this call is unnecessary.
3544
3545         * WebCoreSupport/FullscreenVideoController.cpp:
3546         (FullscreenVideoController::createHud): Remove call to gtk_range_set_update_policy().
3547
3548 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3549
3550         Reviewed by Martin Robinson.
3551
3552         GTK: AX: DRT needs to use correct root object method.
3553         https://bugs.webkit.org/show_bug.cgi?id=51911
3554
3555         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
3556         (DumpRenderTreeSupportGtk::getRootAccessibleElement):
3557         (DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
3558         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
3559
3560 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3561
3562         Reviewed by Sam Weinig.
3563
3564         WK2: Support Accessibility
3565         https://bugs.webkit.org/show_bug.cgi?id=51859
3566
3567         Use rootObject() method to get top of ax tree.
3568
3569         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
3570         (DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
3571         * webkit/webkitwebview.cpp:
3572         (webkit_web_view_get_accessible):
3573
3574 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
3575
3576         Reviewed by Darin Adler.
3577
3578         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
3579         https://bugs.webkit.org/show_bug.cgi?id=51846
3580
3581         Changed all reference