1 2013-02-11 Rouslan Solomakhin <rouslan@chromium.org>
3 [Chromium] Replace correct misspelled range in WebKit::WebFrameImpl::replaceMisspelledRange
4 https://bugs.webkit.org/show_bug.cgi?id=108513
6 Reviewed by Tony Chang.
8 WebKit::WebFrameImpl::replaceMisspelledRange is going to be used by Chromium instead of
9 WebKit::WebFrameImpl::replaceSelection for correcting misspellings. The current implementation
10 of WebKit::WebFrameImpl::replaceMisspelledRange sometimes replaces the wrong range. This change
11 uses Range::create instead of TextIterator::rangeFromLocationAndLength to select the correct
12 range. This change also disables smart replace in WebKit::WebFrameImpl::replaceMisspelledRange
13 to avoid introducing spaces around misspellings.
15 * src/WebFrameImpl.cpp:
16 (WebKit::WebFrameImpl::replaceMisspelledRange): Replace correct misspelled range.
17 * tests/WebFrameTest.cpp: Add unit test for WebKit::WebFrameImpl::replaceMisspelledRange method.
19 2013-02-11 Alexei Filippov <alph@chromium.org>
21 Web Inspector: Split Profiler domain in protocol into Profiler and HeapProfiler
22 https://bugs.webkit.org/show_bug.cgi?id=108653
24 Reviewed by Yury Semikhatsky.
26 Currently CPU and heap profilers share the same domain 'Profiler' in the protocol.
27 In fact these two profile types have not too much in common. So put each into its own domain.
28 It should also help when Profiles panel gets split into several tools.
29 This is the phase 1 which adds InspectorHeapProfilerAgent but doesn't
30 change the original InspectorProfilerAgent.
32 * src/WebDevToolsAgentImpl.cpp:
33 (WebKit::WebDevToolsAgent::shouldInterruptForMessage):
35 2013-02-11 Abhishek Arya <inferno@chromium.org>
37 Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
38 https://bugs.webkit.org/show_bug.cgi?id=108981
40 Reviewed by Eric Seidel.
42 * src/AutofillPopupMenuClient.cpp:
43 (WebKit::AutofillPopupMenuClient::getSuggestion):
44 (WebKit::AutofillPopupMenuClient::getLabel):
45 (WebKit::AutofillPopupMenuClient::getIcon):
46 (WebKit::AutofillPopupMenuClient::removeSuggestionAtIndex):
47 (WebKit::AutofillPopupMenuClient::valueChanged):
48 (WebKit::AutofillPopupMenuClient::selectionChanged):
49 * src/ChromeClientImpl.cpp:
50 (WebKit::ChromeClientImpl::shouldRunModalDialogDuringPageDismissal):
52 2013-02-10 James Robinson <jamesr@chromium.org>
54 [chromium] Enable more of webkit_unit_tests in component builds
55 https://bugs.webkit.org/show_bug.cgi?id=109369
57 Reviewed by Darin Fisher.
59 Updates all webkit_unit_tests (except for LevelDBTest) to go through the Platform API instead of directly
60 calling into webkit_support so they work in component builds.
63 * tests/AssociatedURLLoaderTest.cpp:
64 * tests/EventListenerTest.cpp:
65 * tests/FrameTestHelpers.cpp:
66 (WebKit::FrameTestHelpers::createWebViewAndLoad):
68 (WebKit::FrameTestHelpers::QuitTask::run):
70 (WebKit::FrameTestHelpers::runPendingTasks):
71 * tests/FrameTestHelpers.h:
73 * tests/ListenerLeakTest.cpp:
74 * tests/PopupMenuTest.cpp:
75 * tests/PrerenderingTest.cpp:
76 * tests/ScrollingCoordinatorChromiumTest.cpp:
77 (WebKit::ScrollingCoordinatorChromiumTest::~ScrollingCoordinatorChromiumTest):
78 (WebKit::ScrollingCoordinatorChromiumTest::navigateTo):
79 * tests/URLTestHelpers.cpp:
80 (WebKit::URLTestHelpers::registerMockedURLLoad):
81 * tests/WebFrameTest.cpp:
82 * tests/WebImageTest.cpp:
84 * tests/WebPageNewSerializerTest.cpp:
85 * tests/WebPageSerializerTest.cpp:
86 * tests/WebPluginContainerTest.cpp:
87 (WebKit::WebPluginContainerTest::TearDown):
89 * tests/WebViewTest.cpp:
91 2013-02-10 Sheriff Bot <webkit.review.bot@gmail.com>
93 Unreviewed. Rolled Chromium DEPS to r181645. Requested by
94 "James Robinson" <jamesr@chromium.org> via sheriffbot.
98 2013-02-09 Stephen Chenney <schenney@chromium.org>
100 Unreviewed. Rolled Chromium DEPS to last-known good revision. Really this time.
104 2013-02-09 Sheriff Bot <webkit.review.bot@gmail.com>
106 Unreviewed. Rolled Chromium DEPS to last-known good revision.
107 Requested by "Stephen Chenney" <schenney@chromium.org> via
112 2013-02-08 Kent Tamura <tkent@chromium.org>
114 [Chromium] Disable ENABLE_INPUT_TYPE_DATETIME
115 https://bugs.webkit.org/show_bug.cgi?id=109272
117 Reviewed by Kentaro Hara.
119 We enabled this flag for desktop Chromium, but disabled the feature by a
120 runtime flag. We disables the compile flag too because we have no plan
121 to ship it in near future.
123 * features.gypi: Remove ENABLE_INPUT_TYPE_DATETIME.
125 2013-02-08 Stephen Chenney <schenney@chromium.org>
127 Remove Skia code suppressions
129 Unreviewed enabling of existing optimizations
131 Removing all skia_webkit.gyp code suppressions and adding expectations
136 2013-02-08 Dan Carney <dcarney@google.com>
138 [v8] isolate parameter added to all v8::peristent calls
139 https://bugs.webkit.org/show_bug.cgi?id=109268
141 Reviewed by Kentaro Hara.
143 * tests/WebFrameTest.cpp:
145 2013-02-07 Kent Tamura <tkent@chromium.org>
147 [Chromium-Android] Disable input[type=datetime]
148 https://bugs.webkit.org/show_bug.cgi?id=107614
150 Reviewed by Kentaro Hara.
153 http://lists.webkit.org/pipermail/webkit-dev/2013-January/023404.html
156 Disable ENABLE_INPUT_TYPE_DATETIME because of a wrong UI.
157 We enable it for non-Android ports but the runtime flag for it is
158 disabled by default. The runtime flag is enabled only in DumpRenderTree.
160 2013-02-07 Terry Anderson <tdanderson@chromium.org>
162 [chromium] Flings should not bubble up to enclosing scrollables when main-thread touch scrolling
163 https://bugs.webkit.org/show_bug.cgi?id=108719
165 Reviewed by Eric Seidel.
167 In the event of a main-thread touch fling, dispatch a series of
168 GestureScrollUpdateWithoutPropagation events defined in
169 https://bugs.webkit.org/show_bug.cgi?id=108849 (instead of
170 GestureScrollUpdate events) so that the fling does not
171 propagate to enclosing scrollables.
173 * src/WebViewImpl.cpp:
174 (WebKit::WebViewImpl::scrollBy):
176 2013-02-07 Kent Tamura <tkent@chromium.org>
178 [Chromium] Add a flag to enable native form validation message
179 https://bugs.webkit.org/show_bug.cgi?id=109134
181 Reviewed by Adam Barth.
183 * public/WebRuntimeFeatures.h:
184 (WebRuntimeFeatures): Add enableNativeValidationMessage and
185 isNativeValidationMessageEnabled.
186 * src/WebRuntimeFeatures.cpp:
187 (WebKit): Add nativeValidationMessageEnabled.
188 (WebKit::WebRuntimeFeatures::enableNativeValidationMessage): Added.
189 (WebKit::WebRuntimeFeatures::isNativeValidationMessageEnabled): Addedd.
190 * src/WebViewImpl.cpp:
191 (WebKit::WebViewImpl::WebViewImpl):
192 Fill Page::PageClients::validationMessageClient if the flag is true.
194 2013-02-07 Eberhard Graether <egraether@google.com>
196 Web Inspector: Add settings checkbox for composited layer borders
197 https://bugs.webkit.org/show_bug.cgi?id=109096
199 Reviewed by Pavel Feldman.
201 This change adds a checkbox to show composited layer borders to the WebInspector's
202 rendering settings and plumbs the setting to Chromium's WebLayerTreeView. The setting
203 is visible if InspectorClient::canShowDebugBorders() returns true.
205 * src/InspectorClientImpl.cpp:
206 (WebKit::InspectorClientImpl::canShowDebugBorders):
208 (WebKit::InspectorClientImpl::setShowDebugBorders):
209 * src/InspectorClientImpl.h:
210 (InspectorClientImpl):
211 * src/WebViewImpl.cpp:
212 (WebKit::WebViewImpl::WebViewImpl):
213 (WebKit::WebViewImpl::setShowDebugBorders):
215 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
218 2013-02-07 Stephen White <senorblanco@chromium.org>
220 Unreviewed. Rolled DEPS.
224 2013-02-07 David Trainor <dtrainor@chromium.org>
226 Add null check to editable in moveCaretSelectionTowardsWindowPoint
227 https://bugs.webkit.org/show_bug.cgi?id=108962
229 Reviewed by Eric Seidel.
231 * src/WebFrameImpl.cpp:
232 (WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):
233 * tests/WebFrameTest.cpp:
235 2013-02-07 Sheriff Bot <webkit.review.bot@gmail.com>
237 Unreviewed. Rolled Chromium DEPS to r180752. Requested by
238 thakis_ via sheriffbot.
242 2013-02-06 Terry Anderson <tdanderson@chromium.org>
244 Add support for gesture scroll events that do not propagate to enclosing scrollables
245 https://bugs.webkit.org/show_bug.cgi?id=108849
247 Reviewed by Antonio Gomes.
249 Define the new event type GestureScrollUpdateWithoutPropagation.
251 * public/WebInputEvent.h:
252 (WebKit::WebInputEvent::isGestureEventType):
253 * src/PageWidgetDelegate.cpp:
254 (WebKit::PageWidgetDelegate::handleInputEvent):
255 * src/WebInputEventConversion.cpp:
256 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
257 * src/WebPluginContainerImpl.cpp:
258 * src/WebPopupMenuImpl.cpp:
259 (WebKit::WebPopupMenuImpl::handleInputEvent):
260 * src/WebViewImpl.cpp:
261 (WebKit::WebViewImpl::handleGestureEvent):
263 2013-02-06 Alexandre Elias <aelias@chromium.org>
265 Make ScrollView::paint() clip by visibleContentRect
266 https://bugs.webkit.org/show_bug.cgi?id=108888
268 Reviewed by Levi Weintraub.
270 When applyPageScaleFactorInCompositor or fixedVisibleContentRect
271 are used, frameRect() and visibleContentRect(true).size() are
272 no longer synonyms, and the latter is the one that should be
273 used for clipping paints.
275 New WebFrameTest: pageScaleFactorScalesPaintClip.
277 * tests/WebFrameTest.cpp:
279 2013-02-06 Sheriff Bot <webkit.review.bot@gmail.com>
281 Unreviewed, rolling out r142025.
282 http://trac.webkit.org/changeset/142025
283 https://bugs.webkit.org/show_bug.cgi?id=109091
285 broke the build (Requested by tdanderson on #webkit).
287 * public/WebInputEvent.h:
288 (WebKit::WebInputEvent::isGestureEventType):
289 * src/PageWidgetDelegate.cpp:
290 (WebKit::PageWidgetDelegate::handleInputEvent):
291 * src/WebInputEventConversion.cpp:
292 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
293 * src/WebPluginContainerImpl.cpp:
294 * src/WebPopupMenuImpl.cpp:
295 (WebKit::WebPopupMenuImpl::handleInputEvent):
296 * src/WebViewImpl.cpp:
297 (WebKit::WebViewImpl::handleGestureEvent):
299 2013-02-06 Daniel Cheng <dcheng@google.com>
301 [chromium] Remove "config.h" header from WebUnitTests.cpp
302 https://bugs.webkit.org/show_bug.cgi?id=108966
304 Reviewed by Tony Chang.
306 This file includes headers from base/ in Chromium, and config.h
307 conflicts with base/logging.h. Rather than teaching certain files in
308 base/ not to #include base/logging.h, remove the config.h include
309 here. The ASSERT isn't really necessary, as attempting to run a null
310 test suite won't go very far anyway.
312 * tests/WebUnitTests.cpp:
313 (WebKit::RunAllUnitTests):
315 2013-02-06 Terry Anderson <tdanderson@chromium.org>
317 Add support for gesture scroll events that do not propagate to enclosing scrollables
318 https://bugs.webkit.org/show_bug.cgi?id=108849
320 Reviewed by Antonio Gomes.
322 Define the new event type GestureScrollUpdateWithoutPropagation.
324 * public/WebInputEvent.h:
325 (WebKit::WebInputEvent::isGestureEventType):
326 * src/PageWidgetDelegate.cpp:
327 (WebKit::PageWidgetDelegate::handleInputEvent):
328 * src/WebInputEventConversion.cpp:
329 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
330 * src/WebPluginContainerImpl.cpp:
331 * src/WebPopupMenuImpl.cpp:
332 (WebKit::WebPopupMenuImpl::handleInputEvent):
333 * src/WebViewImpl.cpp:
334 (WebKit::WebViewImpl::handleGestureEvent):
336 2013-02-06 Chris Hopman <cjhopman@chromium.org>
338 [Chromium] WebWidget should expose a way to determine the start/end of the selection bounds
339 https://bugs.webkit.org/show_bug.cgi?id=108667
341 Reviewed by Darin Fisher.
343 WebWidget::selectionBounds() returns the anchor and focus of the
344 selection. This matches the arguments to WebFrame::selectRange().
345 Add WebWidget::isSelectionAnchorFirst so that a caller can convert the
346 anchor/focus to start/end.
348 * public/WebWidget.h:
350 (WebKit::WebWidget::isSelectionAnchorFirst):
351 * src/WebViewImpl.cpp:
352 (WebKit::WebViewImpl::isSelectionAnchorFirst):
355 * tests/WebViewTest.cpp:
357 2013-02-06 Alec Flett <alecflett@chromium.org>
359 IndexedDB: Stub out SharedBuffer version of put()
360 https://bugs.webkit.org/show_bug.cgi?id=108986
362 Reviewed by Darin Fisher.
364 This is part 1 of 3 to replace Vector<uint8_t> with SharedBuffer.
366 * public/WebIDBDatabase.h:
368 (WebKit::WebIDBDatabase::put):
370 2013-02-06 Stephen Chenney <schenney@chromium.org>
372 Add Skia code suppression flags to WebKit skia.gyp
376 This is step one in removing these flags. First we get them into
377 WebKit, then we can remove them from Chrome.
381 2013-02-06 Mike West <mkwst@chromium.org>
383 Add an ENABLE_NOSNIFF feature flag.
384 https://bugs.webkit.org/show_bug.cgi?id=109029
386 Reviewed by Jochen Eisinger.
388 This new flag will control the behavior of 'X-Content-Type-Options: nosniff'
389 when processing script and other resource types.
393 2013-02-05 David Dorwin <ddorwin@chromium.org>
395 [chromium] Explicitly destroy the WebMediaPlayer in WebMediaPlayerClientImpl's destructor
396 https://bugs.webkit.org/show_bug.cgi?id=108989
398 Reviewed by Kent Tamura.
400 * src/WebMediaPlayerClientImpl.cpp:
401 (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
403 2013-02-04 Kentaro Hara <haraken@chromium.org>
405 [V8] Reduce usage of deprecatedString() and deprecatedInteger()
406 https://bugs.webkit.org/show_bug.cgi?id=108909
408 Reviewed by Adam Barth.
410 No tests. No change in behavior.
412 * src/WebBindings.cpp:
413 (WebKit::WebBindings::toV8Value):
415 2013-02-05 Kentaro Hara <haraken@chromium.org>
417 [V8] Make an Isolate parameter mandatory in HasInstance()
418 https://bugs.webkit.org/show_bug.cgi?id=108917
420 Reviewed by Adam Barth.
422 Because these methods do not have an Isolate, we have to call
423 v8::Isolate::GetCurrent().
425 No tests. No change in behavior.
427 * src/WebArrayBuffer.cpp:
428 (WebKit::WebArrayBuffer::createFromV8Value):
429 * src/WebArrayBufferView.cpp:
430 (WebKit::WebArrayBufferView::createFromV8Value):
431 * src/WebBindings.cpp:
432 (WebKit::getRangeImpl):
433 (WebKit::getNodeImpl):
434 (WebKit::getElementImpl):
435 (WebKit::getArrayBufferImpl):
436 (WebKit::getArrayBufferViewImpl):
437 (WebKit::WebBindings::getRange):
438 (WebKit::WebBindings::getArrayBuffer):
439 (WebKit::WebBindings::getArrayBufferView):
440 (WebKit::WebBindings::getNode):
441 (WebKit::WebBindings::getElement):
443 2013-02-05 Dana Jansens <danakj@chromium.org>
445 [chromium] Provide compositor offscreen context through the WebLayerTreeViewClient interface
446 https://bugs.webkit.org/show_bug.cgi?id=107776
448 Reviewed by James Robinson.
451 * src/WebGraphicsContext3D.cpp: Removed.
453 2013-02-05 Mark Lam <mark.lam@apple.com>
455 Introduced back-end database classes + a few small fixes.
456 https://bugs.webkit.org/show_bug.cgi?id=108759.
458 Reviewed by Brady Eidson.
460 * src/DatabaseObserver.cpp:
461 (WebCore::DatabaseObserver::databaseOpened):
462 (WebCore::DatabaseObserver::databaseModified):
463 (WebCore::DatabaseObserver::databaseClosed):
465 2013-02-05 Adam Barth <abarth@webkit.org>
467 DumpRenderTree should be able to enable the threaded parser
468 https://bugs.webkit.org/show_bug.cgi?id=108970
470 Reviewed by Eric Seidel.
472 * public/WebSettings.h:
473 * src/WebSettingsImpl.cpp:
474 (WebKit::WebSettingsImpl::setThreadedHTMLParser):
476 * src/WebSettingsImpl.h:
479 2013-02-05 Sami Kyostila <skyostil@chromium.org>
481 [chromium] Make overlay layers slow-scrolling
482 https://bugs.webkit.org/show_bug.cgi?id=108957
484 Reviewed by James Robinson.
486 Since overlay layers get inserted on top of everything else, we must
487 mark them slow-scrolling to prevent all scroll input events to the rest
488 of the page from getting blocked. This is also more correct because
489 generally the overlay contents need to be repainted whenever the scroll
490 offset changes, and with this patch the painting happens in sync with
493 2013-02-05 Sheriff Bot <webkit.review.bot@gmail.com>
495 Unreviewed, rolling out r141896.
496 http://trac.webkit.org/changeset/141896
497 https://bugs.webkit.org/show_bug.cgi?id=108956
499 crashes indexdb security tests (Requested by gavinp on
502 * public/platform/WebKitPlatformSupport.h:
504 (WebKitPlatformSupport):
505 (WebKit::WebKitPlatformSupport::idbFactory):
506 * src/IDBFactoryBackendProxy.cpp:
507 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
509 2013-02-05 Mark Pilgrim <pilgrim@chromium.org>
511 [Chromium] Remove idbFactory from WebKitPlatformSupport
512 https://bugs.webkit.org/show_bug.cgi?id=106457
514 Reviewed by Adam Barth.
516 Now that https://codereview.chromium.org/12181010/ has landed, the
517 idbFactory method is no longer needed. (Embedders must now call
518 the new setIDBFactory method upon initialization.) Part of a
519 larger refactoring series; see tracking bug 82948.
521 * public/platform/WebKitPlatformSupport.h:
523 * src/IDBFactoryBackendProxy.cpp:
524 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
526 2013-02-05 Kentaro Hara <haraken@chromium.org>
528 Unreviewed, rolling out r141865.
529 http://trac.webkit.org/changeset/141865
530 https://bugs.webkit.org/show_bug.cgi?id=108909
532 webkit unit tests are broken
534 * src/WebBindings.cpp:
535 (WebKit::WebBindings::toV8Value):
537 2013-02-05 Kentaro Hara <haraken@chromium.org>
539 [V8] Reduce usage of deprecatedString() and deprecatedInteger()
540 https://bugs.webkit.org/show_bug.cgi?id=108909
542 Reviewed by Adam Barth.
544 No tests. No change in behavior.
546 * src/WebBindings.cpp:
547 (WebKit::WebBindings::toV8Value):
549 2013-02-04 Sheriff Bot <webkit.review.bot@gmail.com>
551 Unreviewed. Rolled Chromium DEPS to r180583. Requested by
552 "Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.
556 2013-02-04 James Simonsen <simonjam@chromium.org>
558 [Chromium] Add a signal for when the body is inserted in the document
559 https://bugs.webkit.org/show_bug.cgi?id=108725
561 Reviewed by Adam Barth.
563 * public/WebFrameClient.h:
565 (WebKit::WebFrameClient::willInsertBody):
566 * src/FrameLoaderClientImpl.cpp:
567 (WebKit::FrameLoaderClientImpl::dispatchWillInsertBody):
569 * src/FrameLoaderClientImpl.h:
570 (FrameLoaderClientImpl):
571 * tests/WebFrameTest.cpp:
573 2013-02-04 Chris Hopman <cjhopman@chromium.org>
575 Make moveCaretTowardsWindowPoint not snap to the beginning/end when moved above/below editable
576 https://bugs.webkit.org/show_bug.cgi?id=107850
578 Reviewed by Ojan Vafai.
580 On Android, EditingBehavior::shouldMoveCaret[...] controls the
581 behavior of insertion handles. This change adds a new Android specific
582 editing behavior type so that we can change these settings independent
583 of behavior for other platforms.
585 * public/WebSettings.h:
586 * src/AssertMatchingEnums.cpp:
587 Just add the corresponding assertion for the new editing behavior.
589 * public/WebSettings.h:
590 * src/AssertMatchingEnums.cpp:
592 * tests/WebFrameTest.cpp:
593 * tests/data/move_caret.html: Added.
594 Add a test that moveCaretTowardsWindowPoint works as expected on
597 2013-01-31 Kentaro Hara <haraken@chromium.org>
599 Implement WheelEvent::deltaMode
600 https://bugs.webkit.org/show_bug.cgi?id=108455
602 Reviewed by Adam Barth.
604 * src/WebInputEventConversion.cpp:
605 (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
607 2013-02-04 Mark Pilgrim <pilgrim@chromium.org>
609 [Chromium] Move WorkerContextProxy to WebCore
610 https://bugs.webkit.org/show_bug.cgi?id=108847
612 Reviewed by Adam Barth.
614 Part of a larger refactoring series; see tracking bug 106829.
618 (WebKit::initializeWithoutV8):
619 * src/WorkerContextProxy.cpp: Removed.
621 2013-02-04 Abhishek Arya <inferno@chromium.org>
623 Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
624 https://bugs.webkit.org/show_bug.cgi?id=108668
626 Reviewed by Eric Seidel.
628 * src/ContextFeaturesClientImpl.cpp:
629 (WebKit::ContextFeaturesCache::entryFor):
630 * src/WebFrameImpl.cpp:
631 (WebKit::WebFrameImpl::selectFindMatch):
633 2013-02-04 Mark Pilgrim <pilgrim@chromium.org>
635 [Chromium] Move IDBFactoryBackendInterface to WebCore
636 https://bugs.webkit.org/show_bug.cgi?id=108638
638 Reviewed by Adam Barth.
640 Part of a larger refactoring series; see tracking bug 106829.
643 * src/AssertMatchingEnums.cpp:
644 * src/IDBFactoryBackendInterface.cpp: Removed.
645 * src/IDBFactoryBackendProxy.h:
647 (WebKit::initializeWithoutV8):
649 2013-02-04 Abhishek Arya <inferno@chromium.org>
651 Add ASSERT_WITH_SECURITY_IMPLICATION to detect bad cast in DOM, CSS, etc.
652 https://bugs.webkit.org/show_bug.cgi?id=108688
654 Reviewed by Eric Seidel.
656 * src/IDBFactoryBackendProxy.cpp:
657 (WebKit::IDBFactoryBackendProxy::allowIndexedDB):
658 (WebKit::getWebFrame):
659 * src/LocalFileSystemChromium.cpp:
660 (WebCore::LocalFileSystem::deleteFileSystem):
661 * src/WebSharedWorkerImpl.cpp:
662 (WebKit::WebSharedWorkerImpl::connectTask):
663 (WebKit::resumeWorkerContextTask):
664 (WebKit::connectToWorkerContextInspectorTask):
665 (WebKit::reconnectToWorkerContextInspectorTask):
666 (WebKit::disconnectFromWorkerContextInspectorTask):
667 (WebKit::dispatchOnInspectorBackendTask):
669 2013-02-04 Sami Kyostila <skyostil@chromium.org>
671 Disable -webkit-overflow-scrolling CSS attribute on Chromium
672 https://bugs.webkit.org/show_bug.cgi?id=108020
674 Reviewed by James Robinson.
676 Now that we can automatically promote overflow elements to accelerated
677 scrolling layers there is no use for the -webkit-overflow-scrolling CSS
678 attribute any longer on Chromium.
680 This patch enables composited overflow scrolling in
681 ScrollingCoordinatorChromiumTest. Because this also causes the overflow div
682 in non-fast-scrollable.html to become composited, we also need to modify that
683 test to opt it out of composited scrolling.
686 * tests/ScrollingCoordinatorChromiumTest.cpp:
687 (WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
689 * tests/data/non-fast-scrollable.html:
690 * tests/data/overflow-scrolling.html: Renamed from Source/WebKit/chromium/tests/data/touch-overflow-scrolling.html.
692 2013-02-03 KwangYong Choi <ky0.choi@samsung.com>
694 Fix build warning after r141473
695 https://bugs.webkit.org/show_bug.cgi?id=108782
697 Reviewed by Kentaro Hara.
699 Fix -Wunused-parameter build warning.
701 * src/EditorClientImpl.cpp:
702 (WebKit::EditorClientImpl::getClientPasteboardDataForRange):
704 2013-02-03 David Dorwin <ddorwin@chromium.org>
706 [chromium] Do not call m_widgetClient->show() for WebHelperPlugin.
707 https://bugs.webkit.org/show_bug.cgi?id=108740
709 Reviewed by Kent Tamura.
711 The calls to m_widgetClient->show() and setFocus() do not appear to be
712 necessary, and the former causes problems on at least on platform.
714 * src/WebHelperPluginImpl.cpp:
715 (WebKit::WebHelperPluginImpl::initialize): Removed calls to m_widgetClient->show() and setFocus().
716 (WebKit::WebHelperPluginImpl::setFocus): Should never be called.
718 2013-02-02 Michael Nordman <michaeln@google.com>
720 [chromium] FileSystem mods: Changes to snapshot file creation to reduce dependencies on blobs.
721 This patch just alters the WebKitAPI in advance of coding to the new API in chromium and webkit
722 sources, defining two new virtual methods (unimplemented and uncalled). The existing API remains
724 https://bugs.webkit.org/show_bug.cgi?id=108736
726 Reviewed by Darin Fisher.
728 * public/WebFileSystemCallbacks.h:
729 (WebFileSystemCallbacks):
730 (WebKit::WebFileSystemCallbacks::didCreateSnapshotFile):
732 2013-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
734 Unreviewed. Rolled Chromium DEPS to r180221. Requested by
735 "Nico Weber" <thakis@chromium.org> via sheriffbot.
739 2013-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
741 Unreviewed. Rolled Chromium DEPS to r180186. Requested by
742 "Nico Weber" <thakis@chromium.org> via sheriffbot.
746 2013-02-01 Chris Hopman <cjhopman@chromium.org>
748 [Chromium] WebWidget::selectionBounds should return the bounds in document space
749 https://bugs.webkit.org/show_bug.cgi?id=108386
751 Reviewed by James Robinson.
753 When in applyPageScaleFactorInCompositor mode, selectionBounds needs
754 to scale the anchor/focus window points by the pageScaleFactor.
756 * src/WebViewImpl.cpp:
757 (WebKit::WebViewImpl::selectionBounds):
758 (WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode):
760 2013-02-01 Dominic Mazzoni <dmazzoni@google.com>
762 AX: memoize expensive computation during blocks where tree doesn't change
763 https://bugs.webkit.org/show_bug.cgi?id=106497
765 Reviewed by Ryosuke Niwa.
767 Expose two methods to enable and disable caching of
768 computed WebAccessibilityObject attributes, to speed up
769 batch read-only operations.
771 * public/WebAccessibilityObject.h:
772 (WebAccessibilityObject):
773 * src/WebAccessibilityObject.cpp:
774 (WebKit::WebAccessibilityObject::startCachingComputedObjectAttributesUntilTreeMutates):
776 (WebKit::WebAccessibilityObject::stopCachingComputedObjectAttributes):
778 2013-02-01 Fady Samuel <fsamuel@chromium.org>
780 [Chromium] Expose WebNode::shadowHost()
781 https://bugs.webkit.org/show_bug.cgi?id=108681
783 Reviewed by Dimitri Glazkov.
785 BrowserPlugin needs to be able to check the event listeners attached to
786 <webview> and so we expose shadowHost to permit it to poke at the webview
791 (WebKit::WebNode::shadowHost):
794 2013-02-01 Rouslan Solomakhin <rouslan@chromium.org>
796 [Chromium] Ignore punctuation in spellcheck
797 https://bugs.webkit.org/show_bug.cgi?id=108511
799 Reviewed by Tony Chang.
801 * src/ContextMenuClientImpl.cpp:
802 (WebKit::IsWhiteSpaceOrPunctuation): Added utility function to detect whitespace or punctuation.
803 (WebKit::selectMisspellingAsync): Ignore punctuation when selecting the misspelling.
805 2013-02-01 Philip Rogers <pdr@google.com>
807 Change hasAlpha to isKnownToBeOpaque and correct the return value for SVG images.
808 https://bugs.webkit.org/show_bug.cgi?id=106966
810 Reviewed by Stephen White.
812 * tests/DragImageTest.cpp:
813 (WebCore::TestImage::currentFrameKnownToBeOpaque):
815 * tests/ImageLayerChromiumTest.cpp:
816 (WebCore::TestImage::currentFrameKnownToBeOpaque):
817 * tests/PlatformContextSkiaTest.cpp:
820 2013-02-01 Nico Weber <thakis@chromium.org>
822 [chromium] Build webkit with enable_web_intents set to 0.
823 https://bugs.webkit.org/show_bug.cgi?id=108408
825 Reviewed by Tony Chang.
827 I'll then make chromium build fine with that, then switch
828 enable_web_intents to 0, roll that into webkit, and then
829 actually remove the code hidden behind this flag.
831 The features.gypi bit depends on https://codereview.chromium.org/12143002/
832 and will disable web intents support on android. Since common.gypi
833 sets enable_web_intents to 0 explicitly, it seems this is currently on
836 While it looks like this CL just removes ENABLE_WEB_INTENTS=1 from
837 features.gypi completely, it's still set further down the file if
838 enable_web_intents is on.
842 * src/WebFrameImpl.cpp:
844 2013-02-01 Rouslan Solomakhin <rouslan@chromium.org>
846 [Chromium] Ignore whitespace in spellcheck
847 https://bugs.webkit.org/show_bug.cgi?id=108510
849 Reviewed by Ryosuke Niwa.
851 * src/ContextMenuClientImpl.cpp:
852 (WebKit::selectMisspellingAsync): Ignore whitespace when selecting the misspelling.
854 2013-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
856 Unreviewed. Rolled Chromium DEPS to r180131. Requested by
857 "Florin Malita" <fmalita@chromium.org> via sheriffbot.
861 2013-02-01 Alexis Menard <alexis@webkit.org>
863 Enable unprefixed CSS transitions by default.
864 https://bugs.webkit.org/show_bug.cgi?id=108216
866 Reviewed by Dean Jackson.
868 Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
869 to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
870 guard the unprefixing work for CSS Transforms and animations.
874 2013-02-01 Ken Kania <kkania@chromium.org>
876 Web Inspector: Add support for handling modal dialogs
877 https://bugs.webkit.org/show_bug.cgi?id=107883
879 Reviewed by Pavel Feldman.
881 Introduce support for being notified when a JavaScript modal dialog
882 is opening and closing, as well as a new command for accepting or
883 dismissing the dialog.
885 * public/WebDevToolsAgent.h:
886 * src/InspectorClientImpl.cpp:
887 (WebKit::InspectorClientImpl::handleJavaScriptDialog):
889 * src/InspectorClientImpl.h:
890 (InspectorClientImpl):
891 * src/WebDevToolsAgentImpl.cpp:
892 (BrowserDataHintStringValues):
893 (WebKit::WebDevToolsAgentImpl::captureScreenshot):
894 (WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
896 (WebKit::browserHintToString):
897 (WebKit::browserHintFromString):
898 (WebKit::WebDevToolsAgent::patchWithBrowserData):
899 * src/WebDevToolsAgentImpl.h:
900 (WebDevToolsAgentImpl):
902 2013-02-01 Dan Alcantara <dfalcantara@chromium.org>
904 Touch disambiguation blacklist is not being queried properly
905 https://bugs.webkit.org/show_bug.cgi?id=108222
907 Reviewed by Adam Barth.
909 TEST=WebFrameTest::DisambiguationPopupBlacklist
911 Fix the blacklist so that we check it for the right nodes.
912 Add a test to check that the blacklist is being built and used
913 correctly. Also update the other DisambiguationPopup tests to
914 use the new page scale method.
916 * tests/WebFrameTest.cpp:
917 * tests/data/disambiguation_popup_blacklist.html: Added.
919 2013-02-01 Eberhard Graether <egraether@google.com>
921 [chromium] only show checkboxes for FPS meter and continuous painting when compositing mode is forced
922 https://bugs.webkit.org/show_bug.cgi?id=108236
924 Reviewed by Pavel Feldman.
926 This change hides the checkboxes for FPS meter and continuous painting if compositing mode is not forced.
927 This way the checkboxes only show up for users that can make use of these features.
929 * src/InspectorClientImpl.cpp:
930 (WebKit::InspectorClientImpl::canShowFPSCounter):
931 (WebKit::InspectorClientImpl::canContinuouslyPaint):
933 2013-01-31 Aurimas Liutikas <aurimas@chromium.org>
935 Editor::m_compositionNode not updated on HTMLInputElement::setValue()
936 https://bugs.webkit.org/show_bug.cgi?id=107737
938 Reviewed by Ryosuke Niwa.
940 * public/WebViewClient.h:
941 (WebKit::WebViewClient::didCancelCompositionOnSelectionChange):
942 Adding a callback to let the WebViewClient know that the composition has been cancelled.
943 * src/EditorClientImpl.cpp:
944 (WebKit::EditorClientImpl::respondToChangedSelection):
945 Adding a call composition if it is no longer valid.
947 2013-01-31 Aurimas Liutikas <aurimas@chromium.org>
949 [Chromium] WebViewTest.SetCompositionFromExistingText failing after r141479
950 https://bugs.webkit.org/show_bug.cgi?id=108543
952 Reviewed by Ryosuke Niwa.
954 Fixing a bug that was uncovered after fixing http://trac.webkit.org/changeset/141479
956 * src/WebViewImpl.cpp:
957 (WebKit::WebViewImpl::setCompositionFromExistingText):
958 * tests/WebViewTest.cpp:
961 2013-01-31 Hajime Morrita <morrita@google.com>
963 Unreviewed, followup fix for r141535.
965 * tests/WebFrameTest.cpp:
967 2013-01-31 Sheriff Bot <webkit.review.bot@gmail.com>
969 Unreviewed. Rolled Chromium DEPS to r180023. Requested by
970 thakis_ via sheriffbot.
974 2013-01-31 Hajime Morrita <morrita@google.com>
976 Unreviewed, disabling failing test.
978 * tests/WebFrameTest.cpp:
980 2013-01-31 Sheriff Bot <webkit.review.bot@gmail.com>
982 Unreviewed, rolling out r141479.
983 http://trac.webkit.org/changeset/141479
984 https://bugs.webkit.org/show_bug.cgi?id=108564
986 breaks chromium test (Requested by morrita on #webkit).
988 * public/WebViewClient.h:
989 * src/EditorClientImpl.cpp:
990 (WebKit::EditorClientImpl::respondToChangedSelection):
992 2013-01-31 Alec Flett <alecflett@chromium.org>
994 IndexedDB: remove old transaction backend bootstrap code
995 https://bugs.webkit.org/show_bug.cgi?id=103923
997 Reviewed by Dimitri Glazkov.
999 Remove all deprecated WebKit APIs from
1003 * public/WebIDBCallbacks.h:
1005 * public/WebIDBDatabase.h:
1007 * public/WebIDBTransaction.h: Removed.
1008 * public/WebIDBTransactionCallbacks.h: Removed.
1009 * src/AssertMatchingEnums.cpp:
1010 * src/IDBCallbacksProxy.cpp:
1011 * src/IDBDatabaseBackendProxy.cpp:
1012 * src/IDBDatabaseBackendProxy.h:
1013 (IDBDatabaseBackendProxy):
1014 * src/IDBTransactionBackendProxy.cpp: Removed.
1015 * src/IDBTransactionBackendProxy.h: Removed.
1016 * src/IDBTransactionCallbacksProxy.cpp: Removed.
1017 * src/IDBTransactionCallbacksProxy.h: Removed.
1018 * src/WebIDBCallbacksImpl.cpp:
1019 * src/WebIDBDatabaseImpl.cpp:
1021 * src/WebIDBDatabaseImpl.h:
1023 (WebIDBDatabaseImpl):
1024 * src/WebIDBTransactionCallbacksImpl.cpp: Removed.
1025 * src/WebIDBTransactionCallbacksImpl.h: Removed.
1026 * src/WebIDBTransactionImpl.cpp: Removed.
1027 * src/WebIDBTransactionImpl.h: Removed.
1028 * tests/IDBAbortOnCorruptTest.cpp:
1029 * tests/IDBDatabaseBackendTest.cpp:
1031 2013-01-31 Rouslan Solomakhin <rouslan@chromium.org>
1033 [Chromium] Select multi-word misspelling on context click
1034 https://bugs.webkit.org/show_bug.cgi?id=108509
1036 Reviewed by Tony Chang.
1038 * src/ContextMenuClientImpl.cpp:
1040 (WebKit::selectMisspellingAsync): Added utility function to get the misspelling for asynchronous spellcheck.
1041 (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Select multi-word misspelling on context click.
1043 2013-01-31 Florin Malita <fmalita@chromium.org>
1045 [Chromium] Unreviewed gardening.
1047 WebViewTest.SetCompositionFromExistingText failing after r141479.
1049 * tests/WebViewTest.cpp:
1051 2013-01-31 Alexandre Elias <aelias@chromium.org>
1053 [chromium] Rework page scale factor limits initialization
1054 https://bugs.webkit.org/show_bug.cgi?id=108446
1056 Reviewed by James Robinson.
1058 When loading a page with viewportEnabled, both the limits
1059 specified by the viewport tag and the content width need to be
1060 considered before we initialize the minimum page scale (and
1061 pageScaleFactor itself usually to the same value). The timing has
1062 proven tricky to get correct.
1064 This patch simplifies the flow by computing the
1065 limits only at the end of layouts and at no other time. In combination
1066 with https://bugs.webkit.org/show_bug.cgi?id=107922 which sets
1067 needsLayout() appropriately, this results in a more robust and easy
1068 to understand sequence.
1070 Fixes FixedLayoutInitializeAtMinimumPageScale test.
1072 * src/ChromeClientImpl.cpp:
1073 (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
1074 * src/WebViewImpl.cpp:
1075 (WebKit::WebViewImpl::WebViewImpl):
1076 (WebKit::WebViewImpl::resize):
1077 (WebKit::WebViewImpl::setPageScaleFactorLimits):
1078 (WebKit::WebViewImpl::computePageScaleFactorLimits):
1079 (WebKit::WebViewImpl::layoutUpdated):
1080 (WebKit::WebViewImpl::didChangeContentsSize):
1081 * src/WebViewImpl.h:
1082 (WebKit::WebViewImpl::setInitialPageScaleFactor):
1084 * tests/WebFrameTest.cpp:
1086 2013-01-31 Aurimas Liutikas <aurimas@chromium.org>
1088 Editor::m_compositionNode not updated on HTMLInputElement::setValue()
1089 https://bugs.webkit.org/show_bug.cgi?id=107737
1091 Reviewed by Ryosuke Niwa.
1093 * public/WebViewClient.h:
1094 (WebKit::WebViewClient::didCancelCompositionOnSelectionChange):
1095 Adding a callback to let the WebViewClient know that the composition has been cancelled.
1096 * src/EditorClientImpl.cpp:
1097 (WebKit::EditorClientImpl::respondToChangedSelection):
1098 Adding a call composition if it is no longer valid.
1100 2013-01-31 Mark Pilgrim <pilgrim@chromium.org>
1102 [Chromium] Move LocalizedStrings to WebCore
1103 https://bugs.webkit.org/show_bug.cgi?id=108488
1105 Reviewed by Adam Barth.
1107 Part of a larger refactoring series; see tracking bug 106829.
1110 * src/LocalizedStrings.cpp: Removed.
1112 2013-01-31 Enrica Casucci <enrica@apple.com>
1114 WebKit2: provide new bundle APIs to allow bundle clients to be notified of pasteboard access.
1115 https://bugs.webkit.org/show_bug.cgi?id=108396.
1116 <rdar://problem/12920461>
1118 Reviewed by Alexey Proskuryakov.
1120 Adds stub implementation for WebKit of the new EditorClient methods.
1122 * src/EditorClientImpl.cpp:
1123 (WebKit::EditorClientImpl::willWriteSelectionToPasteboard):
1124 (WebKit::EditorClientImpl::getClientPasteboardDataForRange):
1125 * src/EditorClientImpl.h:
1127 2013-01-31 Chris Hopman <cjhopman@chromium.org>
1129 [chromium] Make selection handling work in applyPageScaleInCompositor mode
1130 https://bugs.webkit.org/show_bug.cgi?id=107831
1132 Reviewed by Ryosuke Niwa.
1134 These functions expect a window point. When in
1135 applyPageScaleFactorInCompositor mode, the points need to be unscaled
1136 by the page scale factor.
1138 * src/WebFrameImpl.cpp:
1139 (WebKit::WebFrameImpl::selectRange):
1140 (WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):
1142 2013-01-31 Tom Sepez <tsepez@chromium.org>
1144 [v8] Enable binding integrity on mac
1145 https://bugs.webkit.org/show_bug.cgi?id=108500
1147 Reviewed by Adam Barth.
1149 Patch is correct if existing tests pass without new crashes.
1152 Set ENABLE_BINDING_INTEGRITY=1 when OS=="mac"
1154 2013-01-31 Dan Alcantara <dfalcantara@chromium.org>
1156 WebFrameTest.DisambiguationPopup is failing
1157 https://bugs.webkit.org/show_bug.cgi?id=108160
1159 Reviewed by Adam Barth.
1161 Fix the unit test so that it is using the right HTML file.
1163 * tests/WebFrameTest.cpp:
1165 2013-01-31 Tony Chang <tony@chromium.org>
1167 [Chromium] webkit_unit_tests should depend on base/allocator for ASAN
1168 https://bugs.webkit.org/show_bug.cgi?id=108497
1170 Reviewed by James Robinson.
1172 * WebKitUnitTests.gyp:
1174 2013-01-31 Alexandre Elias <aelias@chromium.org>
1176 Call FrameView::contentsResized() when setting fixed layout size
1177 https://bugs.webkit.org/show_bug.cgi?id=107922
1179 Reviewed by James Robinson.
1181 In fixed layout mode, we should be calling contentsResized() when the
1182 fixed layout size is changed, but not laying out when the visible
1183 content rect changes.
1185 Previously landed as r140869 but was reverted due to a bug in bundled
1186 Chromium-specific code. This patch includes just the minimum needed in
1189 New WebFrameTest: FrameViewNeedsLayoutOnFixedLayoutResize. Some
1190 flaky and obsolete tests for the old page scale mode are also deleted.
1192 * tests/WebFrameTest.cpp:
1194 2013-01-31 Tommy Widenflycht <tommyw@google.com>
1196 [chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStreamComponent to WebMediaStream and WebMediaStreamTrack
1197 https://bugs.webkit.org/show_bug.cgi?id=108458
1199 Reviewed by Adam Barth.
1201 Only renames, no other code changes.
1203 * public/WebMediaStreamRegistry.h:
1205 (WebMediaStreamRegistry):
1206 * public/WebUserMediaRequest.h:
1208 (WebUserMediaRequest):
1209 * src/WebMediaStreamRegistry.cpp:
1210 (WebKit::WebMediaStreamRegistry::lookupMediaStreamDescriptor):
1211 * src/WebUserMediaRequest.cpp:
1212 (WebKit::WebUserMediaRequest::requestSucceeded):
1214 2013-01-31 Alec Flett <alecflett@chromium.org>
1216 IndexedDB: Remove WebKit API for old onSuccess/onUpgradeNeeded
1217 https://bugs.webkit.org/show_bug.cgi?id=108399
1219 Reviewed by Dimitri Glazkov.
1221 Cleanup now that chromium proxies the new signatures through.
1223 * src/IDBCallbacksProxy.cpp:
1224 (WebKit::IDBCallbacksProxy::onSuccess):
1225 (WebKit::IDBCallbacksProxy::onUpgradeNeeded):
1226 * src/IDBCallbacksProxy.h:
1227 (IDBCallbacksProxy):
1228 * src/WebIDBCallbacksImpl.cpp:
1229 * src/WebIDBCallbacksImpl.h:
1230 (WebIDBCallbacksImpl):
1232 2013-01-31 James Robinson <jamesr@chromium.org>
1234 [chromium] Remove dead transitional code from WebViewImpl
1235 https://bugs.webkit.org/show_bug.cgi?id=107889
1237 Reviewed by Adam Barth.
1239 The chromium side of this landed at r178256 and seems stable.
1241 * public/WebWidget.h:
1242 (WebKit::WebWidget::setCompositorSurfaceReady):
1243 * src/WebViewImpl.cpp:
1244 (WebKit::WebViewImpl::WebViewImpl):
1245 (WebKit::WebViewImpl::~WebViewImpl):
1247 (WebKit::WebViewImpl::setIsTransparent):
1248 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
1249 * src/WebViewImpl.h:
1250 * tests/ScrollingCoordinatorChromiumTest.cpp:
1251 (WebKit::FakeWebViewClient::initializeLayerTreeView):
1252 (FakeWebViewClient):
1253 (WebKit::FakeWebViewClient::layerTreeView):
1254 (WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
1255 (ScrollingCoordinatorChromiumTest):
1257 2013-01-31 Kentaro Hara <haraken@chromium.org>
1259 Rename WheelEvent::Granularity to WheelEvent::DeltaMode
1260 https://bugs.webkit.org/show_bug.cgi?id=108434
1262 Reviewed by Ryosuke Niwa.
1264 Per the spec, WheelEvent::Granularity should be renamed to WheelEvent::DeltaMode.
1266 Spec: http://www.w3.org/TR/DOM-Level-3-Events/#events-WheelEvent
1267 https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-wheelevent
1269 No tests. No change in behavior.
1271 * src/WebInputEventConversion.cpp:
1272 (WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
1273 (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
1275 2013-01-31 Yury Semikhatsky <yurys@chromium.org>
1277 Unreviewed. Bump Chromium dependency to 179332
1281 2013-01-31 Mark Pilgrim <pilgrim@chromium.org>
1283 [Chromium] Move MediaPlayerPrivateChromium to WebCore
1284 https://bugs.webkit.org/show_bug.cgi?id=108415
1286 Reviewed by Adam Barth.
1288 Part of a larger refactoring series; see tracking bug 106829.
1291 * src/MediaPlayerPrivateChromium.cpp: Removed.
1293 (WebKit::initializeWithoutV8): call new setter function in
1294 WebCore::MediaPlayerPrivate
1296 2013-01-30 Sheriff Bot <webkit.review.bot@gmail.com>
1298 Unreviewed, rolling out r141358.
1299 http://trac.webkit.org/changeset/141358
1300 https://bugs.webkit.org/show_bug.cgi?id=108421
1302 breaks android builder (Requested by morrita on #webkit).
1306 * src/WebFrameImpl.cpp:
1308 2013-01-30 Nico Weber <thakis@chromium.org>
1310 [chromium] Build webkit with enable_web_intents set to 0.
1311 https://bugs.webkit.org/show_bug.cgi?id=108408
1313 Reviewed by Kentaro Hara.
1315 I'll then make chromium build fine with that, then switch
1316 enable_web_intents to 0, roll that into webkit, and then
1317 actually remove the code hidden behind this flag.
1321 * src/WebFrameImpl.cpp:
1323 2013-01-30 Levi Weintraub <leviw@chromium.org>
1325 [Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
1326 https://bugs.webkit.org/show_bug.cgi?id=108381
1328 Reviewed by James Robinson.
1330 WebPluginContainerImpl would call Document::didAddTouchEventHandler every time the plugin requested
1331 touch events. Some plugins make this request more than once, leading to an imbalance in Document's
1332 touch event handler map, and a stale node pointer when the plugin is destroyed. This change
1333 has WebPluginContainerImpl only add one ref for the plugin at a time.
1335 * src/WebPluginContainerImpl.cpp:
1336 (WebKit::WebPluginContainerImpl::requestTouchEventType):
1338 2013-01-30 Yusuf Ozuysal <yusufo@google.com>
1340 Start sending scrollType as NonBubblingGesture for flings
1341 https://bugs.webkit.org/show_bug.cgi?id=108372
1343 Reviewed by James Robinson.
1345 * src/WebCompositorInputHandlerImpl.cpp:
1346 (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
1348 2013-01-30 Tien-Ren Chen <trchen@chromium.org>
1350 [chromium] Add WebFrame::visibleContentRect()
1351 https://bugs.webkit.org/show_bug.cgi?id=108311
1353 Reviewed by James Robinson.
1355 * public/WebFrame.h:
1356 * src/WebFrameImpl.cpp:
1357 (WebKit::WebFrameImpl::visibleContentRect):
1359 * src/WebFrameImpl.h:
1362 2013-01-30 Kentaro Hara <haraken@chromium.org>
1364 Implement KeyboardEvent constructor
1365 https://bugs.webkit.org/show_bug.cgi?id=108320
1367 Reviewed by Adam Barth.
1369 Renamed keyboard event constant variables to avoid style errors.
1371 * src/WebInputEventConversion.cpp:
1372 (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
1373 * tests/WebInputEventConversionTest.cpp:
1374 * tests/WebInputEventFactoryTestGtk.cpp:
1376 2013-01-30 Kentaro Hara <haraken@chromium.org>
1378 Implement WheelEvent constructor
1379 https://bugs.webkit.org/show_bug.cgi?id=108303
1381 Reviewed by Adam Barth.
1383 This patch just renames an enum value to avoid style check error.
1385 * src/WebViewImpl.cpp:
1386 (WebKit::WebViewImpl::scrollBy):
1388 2013-01-30 Dana Jansens <danakj@chromium.org>
1390 [chromium] Add recordRenderingStats to WebSettings
1391 https://bugs.webkit.org/show_bug.cgi?id=108358
1393 Reviewed by James Robinson.
1395 * public/WebSettings.h:
1396 * src/WebSettingsImpl.cpp:
1397 (WebKit::WebSettingsImpl::setRecordRenderingStats):
1399 * src/WebSettingsImpl.h:
1401 (WebKit::WebSettingsImpl::recordRenderingStats):
1402 * src/WebViewImpl.cpp:
1403 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
1405 2013-01-30 Tony Gentilcore <tonyg@chromium.org>
1407 Fix compile error in WebFrameTest
1408 https://bugs.webkit.org/show_bug.cgi?id=108360
1410 Unreviewed build fix.
1412 Fixes compile error:
1413 ../../Source/WebKit/chromium/tests/WebFrameTest.cpp:330:5: error: converting false to pointer type for argument 1 of char testing::internal::IsNullLiteralHelper(testing::internal::Secret*) [-Werror=conversion-null]
1415 * tests/WebFrameTest.cpp:
1417 2013-01-30 John Knottenbelt <jknotten@chromium.org>
1419 [Chromium] Fix find in page rects for overflowing content.
1420 https://bugs.webkit.org/show_bug.cgi?id=104924
1422 Reviewed by Julien Chaffraix.
1424 If a div has overflowing content, we should only normalise its
1425 coordinates against the renderview or the containing scrollable block.
1427 TEST=WebFrameTest.FindInPageMatchRects
1429 * src/FindInPageCoordinates.cpp:
1430 (WebKit::enclosingScrollableAncestor):
1431 Helper function to find the enclosing containing block with an overflow clip.
1432 (WebKit::toNormalizedRect):
1433 Pass in the container as an argument.
1434 (WebKit::findInPageRectFromAbsoluteRect):
1435 Compute the container for toNormalizedRect using enclosingScrollableAncestor.
1436 * tests/WebFrameTest.cpp:
1437 Add expectations for new tests in WebFrameTest::FindInPageMatchRects and WebFrameTest::FindInPage.
1438 * tests/data/find.html:
1439 Add test case for <select> element.
1440 * tests/data/find_in_page_frame.html:
1442 - Result 15, 16 tests that containing <div> with style float:left and
1443 height:0px does not impact coordinate normalization.
1444 - Result 17, 18 tests that matches with absolute positioning are normalized containing
1445 relative positioned block, even if there is a closer parent block with overflow clip.
1446 - Result 19 adds a test case for <select> element.
1448 2013-01-30 Dominik Röttsches <dominik.rottsches@intel.com>
1450 [HarfBuzz] Remove the HarfBuzz-old code
1451 https://bugs.webkit.org/show_bug.cgi?id=108077
1453 Reviewed by Benjamin Poulain.
1455 Rename WTF_USE_HARFBUZZ_NG to WTF_USE_HARFBUZZ since there
1456 won't be a distinction between ng and non-ng HarfBuzz after
1457 removing the old code.
1461 2013-01-30 Jochen Eisinger <jochen@chromium.org>
1463 [chromium] WebConsoleMessage is missing LevelDebug (chromium bug 172416)
1464 https://bugs.webkit.org/show_bug.cgi?id=108004
1465 http://code.google.com/p/chromium/issues/detail?id=172416
1467 console.debug triggers a NOTREACHED() assertation in Chromium. This
1468 is because WebCore::MessageLevel contains 5 levels, including debug,
1469 where WebConsoleMessage::Level is missing a "debug" level. Add a
1470 WebConsoleMessage::LevelDebug so that it can get passed up to the
1471 renderer even if it doesn't make use of that now.
1473 Requires another patch to chromium itself to fix chromium bug 172416
1474 but this is a prerequisite.
1476 Also add an enum compile time check to AssertMatchingEnums.cpp,
1478 Patch by Kevin Day <kevinday@gmail.com> on 2013-01-28
1479 Reviewed by Jochen Eisinger.
1481 * public/WebConsoleMessage.h:
1482 * src/AssertMatchingEnums.cpp:
1483 * src/WebFrameImpl.cpp:
1484 (WebKit::WebFrameImpl::addMessageToConsole):
1486 2013-01-30 Xianzhu Wang <wangxianzhu@chromium.org>
1488 [Chromium] Correct zoom for focused node when using compositor scaling
1489 https://bugs.webkit.org/show_bug.cgi?id=107599
1491 Reviewed by Adam Barth.
1493 When applyDeviceScaleFactorInCompositor, targetScale should exclude device scale factor.
1494 When applyPageScaleFactorInCompositor, caret size and content sizes are in css pixels and they should be in the viewport of the new scale.
1496 Reapply r141153. Added font-size in html to ensure same caret size across platforms.
1498 * src/WebViewImpl.cpp:
1499 (WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
1501 (WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode): Extracted from scrollFocusedNodeIntoRect() to ease testing.
1502 * src/WebViewImpl.h:
1504 * tests/WebFrameTest.cpp: Updated test DivScrollEditableTest
1505 * tests/data/get_scale_for_zoom_into_editable_test.html: Moved the logic of onload script (which seems not to work) into WebFrameTest.cpp.
1507 2013-01-29 Mark Lam <mark.lam@apple.com>
1509 Rename AbstractDatabase to DatabaseBackend.
1510 https://bugs.webkit.org/show_bug.cgi?id=108275.
1512 Reviewed by Sam Weinig.
1514 This is a pure rename operation as part of the webdatabase refactoring
1515 effort. There is no semantic change in this patch.
1517 * public/WebDatabase.h:
1519 * src/DatabaseObserver.cpp:
1520 (WebCore::DatabaseObserver::databaseOpened):
1521 (WebCore::DatabaseObserver::databaseModified):
1522 (WebCore::DatabaseObserver::databaseClosed):
1523 (WebCore::DatabaseObserver::reportOpenDatabaseResult):
1524 (WebCore::DatabaseObserver::reportChangeVersionResult):
1525 (WebCore::DatabaseObserver::reportStartTransactionResult):
1526 (WebCore::DatabaseObserver::reportCommitTransactionResult):
1527 (WebCore::DatabaseObserver::reportExecuteStatementResult):
1528 (WebCore::DatabaseObserver::reportVacuumDatabaseResult):
1529 * src/WebDatabase.cpp:
1530 (WebKit::WebDatabase::WebDatabase):
1532 2013-01-29 Sheriff Bot <webkit.review.bot@gmail.com>
1534 Unreviewed, rolling out r141153.
1535 http://trac.webkit.org/changeset/141153
1536 https://bugs.webkit.org/show_bug.cgi?id=108280
1538 Caused WebFrameTest.DivScrollIntoEditableTest to fail on Mac.
1539 (Requested by keishi on #webkit).
1541 * src/WebViewImpl.cpp:
1542 (WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
1543 * src/WebViewImpl.h:
1545 * tests/WebFrameTest.cpp:
1546 * tests/data/get_scale_for_zoom_into_editable_test.html:
1548 2013-01-29 Sheriff Bot <webkit.review.bot@gmail.com>
1550 Unreviewed, rolling out r140983.
1551 http://trac.webkit.org/changeset/140983
1552 https://bugs.webkit.org/show_bug.cgi?id=108277
1554 Unfortunately, this API has one last client (Requested by
1557 * src/WebNotification.cpp:
1558 (WebKit::WebNotification::isHTML):
1559 (WebKit::WebNotification::url):
1560 (WebKit::WebNotification::iconURL):
1561 (WebKit::WebNotification::title):
1562 (WebKit::WebNotification::body):
1564 2013-01-29 Shinya Kawanaka <shinyak@chromium.org>
1566 [Chromium] Cannot copy text when selecting readonly (or disabled) input elements
1567 https://bugs.webkit.org/show_bug.cgi?id=106287
1569 Reviewed by Hajime Morita.
1571 When an input element is disabled or readonly, its inner element is not editable. So its rootEditableElement
1572 does not exist. In WebViewImpl::caretOrSelectionRange, if rootEditableElement does not exist, it uses
1573 a document element. However, the inner element and document element have a different tree scope, selection range
1574 cannot be gotten correctly.
1576 We should use ShadowRoot instead of document so that we can stay in the same tree scope.
1578 * src/WebViewImpl.cpp:
1579 (WebKit::WebViewImpl::caretOrSelectionRange):
1580 * tests/WebViewTest.cpp:
1581 * tests/data/selection_disabled.html: Added.
1582 * tests/data/selection_readonly.html: Added.
1584 2013-01-29 Tom Sepez <tsepez@chromium.org>
1586 [v8] Enable binding integrity on linux
1587 https://bugs.webkit.org/show_bug.cgi?id=108242
1589 Reviewed by Adam Barth.
1593 2013-01-29 Xianzhu Wang <wangxianzhu@chromium.org>
1595 [Chromium] Correct zoom for focused node when using compositor scaling
1596 https://bugs.webkit.org/show_bug.cgi?id=107599
1598 Reviewed by Adam Barth.
1600 When applyDeviceScaleFactorInCompositor, targetScale should exclude device scale factor.
1601 When applyPageScaleFactorInCompositor, caret size and content sizes are in css pixels and they should be in the viewport of the new scale.
1603 * src/WebViewImpl.cpp:
1604 (WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
1606 (WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode): Extracted from scrollFocusedNodeIntoRect() to ease testing.
1607 * src/WebViewImpl.h:
1609 * tests/WebFrameTest.cpp: Updated test DivScrollEditableTest
1610 * tests/data/get_scale_for_zoom_into_editable_test.html: Moved the logic of onload script (which seems not to work) into WebFrameTest.cpp.
1612 2013-01-29 Alec Flett <alecflett@chromium.org>
1614 IndexedDB: Pass metadata in to IDBOpenDBRequest.onUpgradeNeeded/onSuccess
1615 https://bugs.webkit.org/show_bug.cgi?id=103920
1617 Reviewed by Dimitri Glazkov.
1619 Support the new IDBCallbacks::onSuccess and IDBCallbacks::onUpgradeNeeded
1620 while maintaining chromium compatibility by shimming in the old API
1621 in the WebKit side. Future code will clean this up so that it is just a
1622 pass-through as it was before.
1624 * public/WebIDBCallbacks.h:
1626 (WebKit::WebIDBCallbacks::onSuccess): new method signature.
1627 (WebKit::WebIDBCallbacks::onUpgradeNeeded): new method signature.
1628 * src/IDBCallbacksProxy.cpp:
1629 (WebKit::IDBCallbacksProxy::onSuccess): call on new method signature proxies through old API.
1631 (WebKit::IDBCallbacksProxy::onUpgradeNeeded): call on new method signature proxies through old API.
1632 * src/IDBCallbacksProxy.h:
1633 (IDBCallbacksProxy):
1634 * src/WebIDBCallbacksImpl.cpp:
1635 (WebKit::WebIDBCallbacksImpl::onSuccess): call on old WebKit proxy signature calls new API.
1637 (WebKit::WebIDBCallbacksImpl::onUpgradeNeeded): call on old WebKit proxy signature calls new API.
1638 * src/WebIDBCallbacksImpl.h:
1639 (WebIDBCallbacksImpl):
1640 * tests/IDBAbortOnCorruptTest.cpp: new method signature.
1641 (WebCore::MockIDBCallbacks::onSuccess):
1642 * tests/IDBDatabaseBackendTest.cpp: new method signature.
1644 2013-01-29 Alexandre Elias <aelias@chromium.org>
1646 [chromium] Fix contents size calculation for page scale initialization
1647 https://bugs.webkit.org/show_bug.cgi?id=108204
1651 My previous patch http://webk.it/107424 had a few issues that are
1652 blocking WebKit roll.
1654 - We still need the layout in resize() given that
1655 http://webk.it/107922 was reverted.
1657 - I deleted code used only for the old page-scale mode in
1658 contentsSize(), but this needs to wait until WebKit roll since it's
1659 making bots fail in this short term.
1661 * src/WebViewImpl.cpp:
1662 (WebKit::WebViewImpl::resize):
1663 (WebKit::WebViewImpl::contentsSize):
1665 2013-01-29 Alpha Lam <hclam@chromium.org>
1667 [chromium] Unreviewed DEPS roll.
1669 Roll Chromium DEPS to 179332.
1673 2013-01-29 Joshua Bell <jsbell@chromium.org>
1675 [Chromium] IndexedDB: Let callers specify reason (error) for aborting transaction
1676 https://bugs.webkit.org/show_bug.cgi?id=107851
1678 Reviewed by Tony Chang.
1680 Let Chromium call abort() on a transaction and specify a reason, specifically for
1683 * public/WebIDBDatabase.h:
1684 (WebKit::WebIDBDatabase::abort): New overload for abort() that takes an error.
1685 * public/WebIDBDatabaseError.h:
1686 (WebKit::WebIDBDatabaseError::WebIDBDatabaseError): Overloaded constructor/assign that takes error.
1687 * src/IDBDatabaseBackendProxy.cpp:
1688 (WebKit::IDBDatabaseBackendProxy::abort): New overload for abort() that takes an error.
1689 * src/IDBDatabaseBackendProxy.h:
1690 (IDBDatabaseBackendProxy): Ditto.
1691 * src/WebIDBDatabaseError.cpp: Implementation of overload ctor/assign.
1692 * src/WebIDBDatabaseImpl.cpp:
1693 (WebKit::WebIDBDatabaseImpl::abort): New overload for abort() that takes an error.
1694 * src/WebIDBDatabaseImpl.h: Ditto.
1695 * tests/IDBDatabaseBackendTest.cpp: Overload stubs for Mock class.
1697 2013-01-29 Florin Malita <fmalita@chromium.org>
1699 [Chromium] Unreviewed gardening.
1701 Disable WebFrameTest.pageScaleFactorShrinksViewport (pending investigation after r141053).
1703 * tests/WebFrameTest.cpp:
1705 2013-01-29 Keishi Hattori <keishi@webkit.org>
1707 [Chromium] Disabling WebFrameTest.DisambiguationPopupMobileSite because WebFrameTest is still failing after r141073.
1709 Unreviewed. Gardening.
1711 * tests/WebFrameTest.cpp:
1713 2013-01-29 Sheriff Bot <webkit.review.bot@gmail.com>
1715 Unreviewed, rolling out r141064.
1716 http://trac.webkit.org/changeset/141064
1717 https://bugs.webkit.org/show_bug.cgi?id=108166
1719 [Chromium] WebFrameTest.DivScrollIntoEditableTest is failing
1720 on WinXP. (Requested by keishi on #webkit).
1722 * tests/WebFrameTest.cpp:
1723 * tests/data/get_scale_for_zoom_into_editable_test.html:
1725 2013-01-29 Keishi Hattori <keishi@webkit.org>
1727 [Chromium] Disabling WebFrameTest.DisambiguationPopup because it is failing.
1729 Unreviewed. Gardening.
1731 * tests/WebFrameTest.cpp:
1733 2013-01-28 Xianzhu Wang <wangxianzhu@chromium.org>
1735 Re-enable WebFrameTest.DivScrollIntoEditableTest
1736 https://bugs.webkit.org/show_bug.cgi?id=98558
1738 Reviewed by Adam Barth.
1740 * tests/WebFrameTest.cpp: Fixed several issues (onload script, the maximum scale factor, etc.) of WebFrameTest.DivScrollIntoEditableTest and enable it.
1741 * tests/data/get_scale_for_zoom_into_editable_test.html: Moved the logic of onload script (which seems not to work) into WebFrameTest.cpp.
1743 2013-01-28 Tien-Ren Chen <trchen@chromium.org>
1745 Fix disambiguation popup for new-style page scale
1746 https://bugs.webkit.org/show_bug.cgi?id=107391
1748 Reviewed by Adam Barth.
1750 This patch corrects various coordinate conversion for disambiguation
1751 popup for the new-style page scale mode.
1753 * src/WebViewImpl.cpp:
1754 (WebKit::WebViewImpl::handleGestureEvent):
1755 (WebKit::WebViewImpl::handleInputEvent):
1756 * tests/WebFrameTest.cpp:
1757 * tests/data/disambiguation_popup_page_scale.html: Added.
1759 2013-01-28 Sheriff Bot <webkit.review.bot@gmail.com>
1761 Unreviewed, rolling out r141049.
1762 http://trac.webkit.org/changeset/141049
1763 https://bugs.webkit.org/show_bug.cgi?id=108151
1765 Caused some indexed tests to crash. (Requested by keishi on
1768 * public/WebIDBCallbacks.h:
1770 * src/IDBCallbacksProxy.cpp:
1771 (WebKit::IDBCallbacksProxy::onUpgradeNeeded):
1772 * src/IDBCallbacksProxy.h:
1773 (IDBCallbacksProxy):
1774 * src/WebIDBCallbacksImpl.cpp:
1775 (WebKit::WebIDBCallbacksImpl::onSuccess):
1776 (WebKit::WebIDBCallbacksImpl::onUpgradeNeeded):
1777 * src/WebIDBCallbacksImpl.h:
1778 (WebIDBCallbacksImpl):
1779 * tests/IDBAbortOnCorruptTest.cpp:
1780 (WebCore::MockIDBCallbacks::onSuccess):
1781 * tests/IDBDatabaseBackendTest.cpp:
1783 2013-01-28 Raman Kumar <ramankk@chromium.org>
1785 Expose isRadioButton and isCheckbox API in chromium-webkit glue layer.
1786 https://bugs.webkit.org/show_bug.cgi?id=108031
1788 Reviewed by Adam Barth.
1790 In chromium, to know if an InputElement is radiobutton or a checkbox,
1791 we are checking for formControlType (a string comparision), which is
1792 very slow. Exposing these API to chromium will make them faster.
1794 * public/WebInputElement.h:
1796 * src/WebInputElement.cpp:
1797 (WebKit::WebInputElement::isRadioButton):
1799 (WebKit::WebInputElement::isCheckbox):
1801 2013-01-28 Alexandre Elias <aelias@chromium.org>
1803 Make page scale shrink FrameView in applyPageScaleInCompositor mode
1804 https://bugs.webkit.org/show_bug.cgi?id=107424
1806 Reviewed by Levi Weintraub.
1808 If applyPageScaleFactorInCompositor is enabled (Chromium-only setting),
1809 instead of the entire document expanding as the user pinch zooms, the
1810 viewport shrinks instead. This patch applies the pageScaleFactor to
1811 visibleContentRect to get this behavior, and simplifies Chromium's
1812 resize logic to stop hiding the true viewport size from WebCore.
1814 I verified that the scaling makes sense for all the callers of
1815 visibleContentRect. The exceptions are clip-layer size,
1816 layout size in non-fixed-layout mode, and text autosizing, which need
1817 the original unscaled size. Therefore I added a new method
1818 unscaledVisibleContentSize() to ScrollView/FrameView.
1820 This patch also modifies Page::setPageScaleFactor to perform no
1821 invalidates or layout when applyPageScaleFactorInCompositor is true,
1822 and also writes pageScaleFactor into HistoryItems instead of using
1825 Since all behavior changes are tied to applyPageScaleFactorInCompositor,
1826 this patch should be a no-op for non-Chromium ports.
1828 * src/WebViewImpl.cpp:
1829 (WebKit::WebViewImpl::scaledSize): Returns the post page-scale size
1830 similar to what visibleContentRect() now returns, except that it may
1831 be at a different scale than the current one.
1832 (WebKit::WebViewImpl::size): Back to returning density-independent
1833 size without any tricks, not the "layoutSize()" fake viewport.
1834 (WebKit::WebViewImpl::resize):
1835 (WebKit::WebViewImpl::handleInputEvent): No need to apply
1836 implTransform anymore as WebKit knows the true scroll offset; just
1837 divide event coords by pageScaleFactor.
1838 (WebKit::WebViewImpl::clampOffsetAtScale): Make this method support
1839 applyPageScaleFactorInCompositor. This is used to pre-clamp scroll
1840 offsets at a given viewport size.
1841 (WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset): Make
1842 this method support applyPageScaleFactorInCompositor (don't scale
1843 scroll offsets as they are now scale-independent).
1844 (WebKit::WebViewImpl::setPageScaleFactor): Make this method always use
1845 clampOffsetAtScale instead of bypassing it, since it's now supported.
1846 Also notify the compositor to update its state.
1847 (WebKit::WebViewImpl::contentsSize): Convenience method, removed
1848 difference between scaled and unscaled.
1849 (WebKit::WebViewImpl::layoutSize): This method returned the "fake"
1850 size we used to give FrameView. Now no longer used for much.
1851 (WebKit::WebViewImpl::computePageScaleFactorLimits):
1852 (WebKit::WebViewImpl::didChangeContentsSize): Remove unnecessary
1853 resize() now that we can give the true size to FrameView.
1854 (WebKit::WebViewImpl::updateLayerTreeViewport): Use layoutSize()
1855 directly now that FrameView no longer uses it.
1856 * src/WebViewImpl.h:
1858 * tests/WebFrameTest.cpp:
1860 2013-01-28 Alec Flett <alecflett@chromium.org>
1862 IndexedDB: Pass metadata in to IDBOpenDBRequest.onUpgradeNeeded/onSuccess
1863 https://bugs.webkit.org/show_bug.cgi?id=103920
1865 Reviewed by Dimitri Glazkov.
1867 Support the new IDBCallbacks::onSuccess and IDBCallbacks::onUpgradeNeeded
1868 while maintaining chromium compatibility by shimming in the old API
1869 in the WebKit side. Future code will clean this up so that it is just a
1870 pass-through as it was before.
1872 * public/WebIDBCallbacks.h:
1874 (WebKit::WebIDBCallbacks::onSuccess): new method signature.
1875 (WebKit::WebIDBCallbacks::onUpgradeNeeded): new method signature.
1876 * src/IDBCallbacksProxy.cpp:
1877 (WebKit::IDBCallbacksProxy::onSuccess): call on new method signature proxies through old API.
1879 (WebKit::IDBCallbacksProxy::onUpgradeNeeded): call on new method signature proxies through old API.
1880 * src/IDBCallbacksProxy.h:
1881 (IDBCallbacksProxy):
1882 * src/WebIDBCallbacksImpl.cpp:
1883 (WebKit::WebIDBCallbacksImpl::onSuccess): call on old WebKit proxy signature calls new API.
1885 (WebKit::WebIDBCallbacksImpl::onUpgradeNeeded): call on old WebKit proxy signature calls new API.
1886 * src/WebIDBCallbacksImpl.h:
1887 (WebIDBCallbacksImpl):
1888 * tests/IDBAbortOnCorruptTest.cpp: new method signature.
1889 (WebCore::MockIDBCallbacks::onSuccess):
1890 * tests/IDBDatabaseBackendTest.cpp: new method signature.
1892 2013-01-28 Tom Sepez <tsepez@chromium.org>
1894 [v8] Security feature: JavaScript Bindings hardening
1895 https://bugs.webkit.org/show_bug.cgi?id=106608
1897 Reviewed by Adam Barth.
1900 Added ENABLE_BINDING_INTEGRITY option.
1902 2013-01-28 Sheriff Bot <webkit.review.bot@gmail.com>
1904 Unreviewed, rolling out r141006.
1905 http://trac.webkit.org/changeset/141006
1906 https://bugs.webkit.org/show_bug.cgi?id=108123
1908 Broke chromium build (Requested by arv on #webkit).
1910 * public/WebConsoleMessage.h:
1911 * src/AssertMatchingEnums.cpp:
1912 * src/WebFrameImpl.cpp:
1913 (WebKit::WebFrameImpl::addMessageToConsole):
1915 2013-01-28 Min Qin <qinmin@chromium.org>
1917 adding support for DiscardablePixelRef for caching lazily decoded images
1918 https://bugs.webkit.org/show_bug.cgi?id=106842
1920 Reviewed by Stephen White.
1922 Adding new tests for ImageDecodingStore
1925 * tests/ImageDecodingStoreTest.cpp:
1926 (WebCore::ImageDecodingStoreTest::createCompleteImage):
1927 (WebCore::ImageDecodingStoreTest::createIncompleteImage):
1930 * tests/MockDiscardablePixelRef.h: Added.
1932 (MockDiscardablePixelRef):
1933 (WebCore::MockDiscardablePixelRef::MockDiscardablePixelRef):
1934 (WebCore::MockDiscardablePixelRef::~MockDiscardablePixelRef):
1935 (WebCore::MockDiscardablePixelRef::discard):
1936 (WebCore::MockDiscardablePixelRef::onLockPixels):
1937 (WebCore::MockDiscardablePixelRef::onUnlockPixels):
1939 2013-01-28 Stephen Chenney <schenney@chromium.org>
1941 [Chromium] Fix the build.
1943 Unreviewed build fix.
1945 * src/AssertMatchingEnums.cpp: Move the include to the right place and remove the bad directory prefix.
1947 2013-01-28 Dan Alcantara <dfalcantara@chromium.org>
1949 [Chromium, Mobile] Do not show disambiguation pop up in mobile sites
1950 https://bugs.webkit.org/show_bug.cgi?id=107607
1952 Reviewed by Adam Barth.
1954 Add a check before showing the disambiguation popup to prevent it from appearing
1955 on mobile sites. Makes a similar test to the current disambiguation popup test
1956 that expects the popup to never appear.
1958 * src/WebViewImpl.cpp:
1959 (WebKit::WebViewImpl::handleGestureEvent):
1961 (WebKit::WebViewImpl::isLikelyMobileSite):
1962 * src/WebViewImpl.h:
1964 * tests/WebFrameTest.cpp:
1965 * tests/data/disambiguation_popup_mobile_site.html: Added.
1967 * src/WebViewImpl.cpp:
1968 (WebKit::WebViewImpl::handleGestureEvent):
1970 (WebKit::WebViewImpl::shouldDisableDesktopWorkarounds):
1971 * src/WebViewImpl.h:
1973 * tests/WebFrameTest.cpp:
1974 * tests/data/disambiguation_popup_mobile_site.html: Added.
1976 2013-01-28 Stephen Chenney <schenney@chromium.org>
1978 [Chromium] Fix the build.
1980 Unreviewed build fix.
1982 * src/AssertMatchingEnums.cpp: Move the include to the right place and remove the bad directory prefix.
1984 2013-01-28 Sheriff Bot <webkit.review.bot@gmail.com>
1986 Unreviewed, rolling out r140869.
1987 http://trac.webkit.org/changeset/140869
1988 https://bugs.webkit.org/show_bug.cgi?id=108120
1990 "Crashes on http://en.wikipedia.org/wiki/Wikipedia" (Requested
1991 by tonyg-cr on #webkit).
1993 * src/WebViewImpl.cpp:
1994 (WebKit::WebViewImpl::resize):
1995 (WebKit::WebViewImpl::computePageScaleFactorLimits):
1996 * tests/WebFrameTest.cpp:
1998 2013-01-28 Sheriff Bot <webkit.review.bot@gmail.com>
2000 Unreviewed, rolling out r140934, r140935, and r140937.
2001 http://trac.webkit.org/changeset/140934
2002 http://trac.webkit.org/changeset/140935
2003 http://trac.webkit.org/changeset/140937
2004 https://bugs.webkit.org/show_bug.cgi?id=108117
2006 Re-land some speculative rollouts - see wkbug.com/108048 for
2007 context (Requested by jsbell on #webkit).
2009 * public/WebIDBCallbacks.h:
2011 * src/AssertMatchingEnums.cpp:
2012 * src/IDBCallbacksProxy.cpp:
2013 * src/IDBCallbacksProxy.h:
2014 (IDBCallbacksProxy):
2015 * src/WebIDBCallbacksImpl.cpp:
2016 * src/WebIDBCallbacksImpl.h:
2017 (WebIDBCallbacksImpl):
2018 * tests/IDBAbortOnCorruptTest.cpp:
2019 * tests/IDBDatabaseBackendTest.cpp:
2021 2013-01-28 Kevin Day <kevinday@gmail.com>
2023 [chromium] WebConsoleMessage is missing LevelDebug (chromium bug 172416)
2024 https://bugs.webkit.org/show_bug.cgi?id=108004
2025 http://code.google.com/p/chromium/issues/detail?id=172416
2027 console.debug triggers a NOTREACHED() assertation in Chromium. This
2028 is because WebCore::MessageLevel contains 5 levels, including debug,
2029 where WebConsoleMessage::Level is missing a "debug" level. Add a
2030 WebConsoleMessage::LevelDebug so that it can get passed up to the
2031 renderer even if it doesn't make use of that now.
2033 Requires another patch to chromium itself to fix chromium bug 172416
2034 but this is a prerequisite.
2036 Also add an enum compile time check to AssertMatchingEnums.cpp,
2038 Reviewed by Jochen Eisinger.
2040 * public/WebConsoleMessage.h:
2041 * src/AssertMatchingEnums.cpp:
2042 * src/WebFrameImpl.cpp:
2043 (WebKit::WebFrameImpl::addMessageToConsole):
2045 2013-01-28 Xianzhu Wang <wangxianzhu@chromium.org>
2047 [Chromium] Correct auto-zoom when using compositor scaling
2048 https://bugs.webkit.org/show_bug.cgi?id=107592
2050 Reviewed by Adam Barth.
2052 1. The scale of auto-zoom should exclude deviceScaleFactor because the compositor will handle the scaling;
2053 2. Scroll location needs to be calculated differently when pageScaleFactor is handled by the compositor.
2055 * src/WebViewImpl.cpp:
2056 (WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
2057 * tests/WebFrameTest.cpp: Updated tests DivAutoZoomParamsTest, DivAutoZoomMultipleDivsTest, DivAutoZoomScaleBoundsTest and DivAutoZoomScaleFontScaleFactorTest, to make two versions of them (WebKitScaling and CompositorScaling).
2059 2013-01-28 Laszlo Gombos <l.gombos@samsung.com>
2061 Collapse OS(UNIX)||OS(ANDROID) to OS(UNIX)
2062 https://bugs.webkit.org/show_bug.cgi?id=108091
2064 Reviewed by Adam Barth.
2066 OS(UNIX) is defined when OS(ANDROID) is defined.
2068 * src/WebViewImpl.cpp:
2069 (WebKit::WebViewImpl::handleMouseDown):
2071 2013-01-28 Adam Barth <abarth@webkit.org>
2073 Remove webkitNotifications.createHTMLNotification
2074 https://bugs.webkit.org/show_bug.cgi?id=107598
2076 Reviewed by Benjamin Poulain.
2078 We can remove these stubs once we've removed the Chromium-side code
2079 that depends on them.
2081 * src/WebNotification.cpp:
2082 (WebKit::WebNotification::isHTML):
2083 (WebKit::WebNotification::url):
2084 (WebKit::WebNotification::iconURL):
2085 (WebKit::WebNotification::title):
2086 (WebKit::WebNotification::body):
2088 2013-01-28 James Craig <james@cookiecrook.com>
2090 HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match.
2091 https://bugs.webkit.org/show_bug.cgi?id=107650
2093 Reviewed by Chris Fleizach.
2095 Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).
2097 * public/WebAccessibilityRole.h:
2098 * src/AssertMatchingEnums.cpp:
2099 * src/LocalizedStrings.cpp:
2100 (WebCore::AXDefinitionText):
2102 (WebCore::AXDescriptionListTermText):
2103 (WebCore::AXDescriptionListDetailText):
2105 2013-01-28 Mike West <mkwst@chromium.org>
2107 [chromium] Unreviewed build fix, missing include in AssertMatchingEnums.cpp
2108 https://bugs.webkit.org/show_bug.cgi?id=108086
2110 Disabling SVG exposed a missing include in AssertMatchingEnums. This
2113 * src/AssertMatchingEnums.cpp:
2114 Include 'ResourceLoadPriority.h'.
2116 2013-01-28 Marja Hölttä <marja@chromium.org>
2118 Add an API for retrieving native memory information without going through the remote inspecting protocol
2119 https://bugs.webkit.org/show_bug.cgi?id=107651
2121 Reviewed by Adam Barth.
2124 * public/WebDevToolsAgent.h:
2127 * public/WebMemoryUsageInfo.h: Added.
2129 (WebKit::WebMemoryUsageInfo::WebMemoryUsageInfo):
2130 (WebMemoryUsageInfo):
2131 * src/WebDevToolsAgentImpl.cpp:
2132 (WebKit::WebDevToolsAgentImpl::processMemoryDistribution):
2134 * src/WebDevToolsAgentImpl.h:
2136 (WebDevToolsAgentImpl):
2138 2013-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
2140 Unreviewed, rolling out r140602.
2141 http://trac.webkit.org/changeset/140602
2142 https://bugs.webkit.org/show_bug.cgi?id=108045
2144 Caused 8 indexed tests to crash. (Requested by keishi on
2147 * public/WebIDBCallbacks.h:
2148 * src/IDBCallbacksProxy.cpp:
2149 (WebKit::IDBCallbacksProxy::onBlocked):
2151 * src/IDBCallbacksProxy.h:
2152 (IDBCallbacksProxy):
2153 * src/WebIDBCallbacksImpl.cpp:
2154 (WebKit::WebIDBCallbacksImpl::onBlocked):
2156 * src/WebIDBCallbacksImpl.h:
2157 (WebIDBCallbacksImpl):
2158 * tests/IDBAbortOnCorruptTest.cpp:
2159 (WebCore::MockIDBCallbacks::onBlocked):
2160 * tests/IDBDatabaseBackendTest.cpp:
2162 2013-01-27 Keishi Hattori <keishi@webkit.org>
2164 Unreviewed, rolling out r140850.
2165 http://trac.webkit.org/changeset/140850
2166 https://bugs.webkit.org/show_bug.cgi?id=107960
2168 r14602 caused 8 indexed tests to crash.
2170 * src/AssertMatchingEnums.cpp:
2172 2013-01-27 Jochen Eisinger <jochen@chromium.org>
2174 [chromium] add missing plumbing for Notification.requestPermission
2175 https://bugs.webkit.org/show_bug.cgi?id=108012
2177 Reviewed by Adam Barth.
2179 * src/NotificationPresenterImpl.cpp:
2181 (WebKit::VoidCallbackClient::VoidCallbackClient):
2182 (NotificationPermissionCallbackClient):
2183 (WebKit::NotificationPermissionCallbackClient::NotificationPermissionCallbackClient):
2184 (WebKit::NotificationPermissionCallbackClient::permissionRequestComplete):
2185 (WebKit::NotificationPermissionCallbackClient::~NotificationPermissionCallbackClient):
2186 (WebKit::NotificationPresenterImpl::requestPermission):
2187 * src/NotificationPresenterImpl.h:
2188 (NotificationPresenterImpl):
2190 2013-01-26 James Simonsen <simonjam@chromium.org>
2192 [chromium] Export ResourceRequest's priority through WebURLRequest
2193 https://bugs.webkit.org/show_bug.cgi?id=107985
2195 Reviewed by Adam Barth.
2197 * src/AssertMatchingEnums.cpp:
2199 2013-01-25 Alexandre Elias <aelias@chromium.org>
2201 Call FrameView::contentsResized() when setting fixed layout size
2202 https://bugs.webkit.org/show_bug.cgi?id=107922
2204 Reviewed by James Robinson.
2206 In fixed layout mode, we should be calling contentsResized() when the
2207 fixed layout size is changed; on the other hand, we don't need to layout
2208 when the visible contents size changes.
2210 This fixes test WebFrameTest::FixedLayoutInitializeAtMinimumPageScale.
2212 * src/WebViewImpl.cpp:
2213 (WebKit::WebViewImpl::resize):
2214 (WebKit::WebViewImpl::computePageScaleFactorLimits):
2215 * tests/WebFrameTest.cpp:
2217 2013-01-25 Alec Flett <alecflett@chromium.org>
2219 IndexedDB: Move TaskType enum to IDBDatabaseBackendInterface
2220 https://bugs.webkit.org/show_bug.cgi?id=107960
2222 Reviewed by Tony Chang.
2224 Update asserts to reflect new enum location.
2226 * src/AssertMatchingEnums.cpp:
2228 2013-01-25 Sheriff Bot <webkit.review.bot@gmail.com>
2230 Unreviewed, rolling out r140774.
2231 http://trac.webkit.org/changeset/140774
2232 https://bugs.webkit.org/show_bug.cgi?id=107932
2234 Tests ScrollingCoordinatorChromiumTest.fastScrollingByDefault
2235 and fastScrollingForFixedPosition are failing (Requested by
2238 * public/WebWidget.h:
2240 (WebKit::WebWidget::isInputThrottled):
2241 (WebKit::WebWidget::renderingStats):
2242 * src/WebViewImpl.cpp:
2243 (WebKit::WebViewImpl::WebViewImpl):
2244 (WebKit::WebViewImpl::~WebViewImpl):
2245 (WebKit::WebViewImpl::renderingStats):
2247 (WebKit::WebViewImpl::setCompositorSurfaceReady):
2248 (WebKit::WebViewImpl::isInputThrottled):
2249 (WebKit::WebViewImpl::setIsTransparent):
2250 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2251 * src/WebViewImpl.h:
2253 2013-01-25 Eberhard Graether <egraether@google.com>
2255 Web Inspector: add checkbox for continuous painting to the inspector's settings
2256 https://bugs.webkit.org/show_bug.cgi?id=107352
2258 Reviewed by Pavel Feldman.
2260 This change adds a checkbox to activate continuous painting to the WebInspector's
2261 rendering settings and plumbs the setting to Chromium's WebLayerTreeView. The
2262 setting is visible if InspectorClient::canContinuouslyPaint() returns true.
2266 * src/InspectorClientImpl.cpp:
2267 (WebKit::InspectorClientImpl::canContinuouslyPaint):
2269 (WebKit::InspectorClientImpl::setContinuousPaintingEnabled):
2270 * src/InspectorClientImpl.h:
2271 (InspectorClientImpl):
2272 * src/WebViewImpl.cpp:
2273 (WebKit::WebViewImpl::setContinuousPaintingEnabled):
2275 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2276 * src/WebViewImpl.h:
2278 2013-01-24 Keishi Hattori <keishi@webkit.org>
2280 Adjust design of the Calendar Picker
2281 https://bugs.webkit.org/show_bug.cgi?id=107507
2283 Reviewed by Kent Tamura.
2285 * src/DateTimeChooserImpl.cpp:
2286 (WebKit::DateTimeChooserImpl::writeDocument): Include pickerCommonChromium.css and calendarPickerChromium.css.
2288 2013-01-24 James Robinson <jamesr@chromium.org>
2290 [chromium] Remove dead transitional code from WebViewImpl
2291 https://bugs.webkit.org/show_bug.cgi?id=107889
2293 Reviewed by Adrienne Walker.
2295 The chromium side of this landed at r178256 and seems stable.
2297 * public/WebWidget.h:
2298 (WebKit::WebWidget::setCompositorSurfaceReady):
2299 * src/WebViewImpl.cpp:
2300 (WebKit::WebViewImpl::WebViewImpl):
2301 (WebKit::WebViewImpl::~WebViewImpl):
2303 (WebKit::WebViewImpl::setIsTransparent):
2304 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2305 * src/WebViewImpl.h:
2307 2013-01-24 James Robinson <jamesr@chromium.org>
2309 [chromium] Null check WebLayerTreeView before dereffing in WebViewImpl::invalidateRect
2310 https://bugs.webkit.org/show_bug.cgi?id=107855
2312 Reviewed by Adrienne Walker.
2314 During frame shutdown, WebViewImpl::m_layerTreeView may become 0 while commits are deferred but we still
2315 may get invalidateRect() calls before shutdown completes.
2317 * src/WebViewImpl.cpp:
2318 (WebKit::WebViewImpl::invalidateRect):
2320 2013-01-24 Mihai Maerean <mmaerean@adobe.com>
2322 [CSSRegions] remove setExperimentalCSSRegionsEnabled deprecated API in Source/WebKit/chromium/public/WebSettings.h
2323 https://bugs.webkit.org/show_bug.cgi?id=104564
2325 Reviewed by Adam Barth.
2327 Fixing bug 101192 has deprecated the use of setExperimentalCSSRegionsEnabled.
2328 After http://code.google.com/p/chromium/issues/detail?id=164162 , setExperimentalCSSRegionsEnabled is no longer used anywhere.
2330 * public/WebSettings.h:
2331 removed setExperimentalCSSRegionsEnabled.
2333 2013-01-23 Sheriff Bot <webkit.review.bot@gmail.com>
2335 Unreviewed. Rolled Chromium DEPS to r178434. Requested by
2336 "Yoshifumi Inoue" <yosin@chromium.org> via sheriffbot.
2340 2013-01-23 Mark Pilgrim <pilgrim@chromium.org>
2342 [Chromium] Remove unused header files in chromium/public/platform/
2343 https://bugs.webkit.org/show_bug.cgi?id=107741
2345 Reviewed by James Robinson.
2347 These header files have migrated to the new Platform directory.
2348 This patch updates the remaining #include references and removes
2349 the old files that did nothing but redirect to the new ones.
2352 * public/WebAccessibilityObject.h:
2353 * public/WebAccessibilityRole.h:
2354 * public/WebActiveWheelFlingParameters.h:
2355 * public/WebAnimationController.h:
2356 * public/WebApplicationCacheHost.h:
2357 * public/WebApplicationCacheHostClient.h:
2358 * public/WebArrayBuffer.h:
2359 * public/WebArrayBufferView.h:
2360 * public/WebAudioSourceProvider.h:
2361 * public/WebBatteryStatus.h:
2362 * public/WebBindings.h:
2364 * public/WebCache.h:
2365 * public/WebCachedURLRequest.h:
2366 * public/WebColorChooser.h:
2367 * public/WebColorChooserClient.h:
2368 * public/WebColorName.h:
2369 * public/WebCommonWorkerClient.h:
2370 * public/WebCompositionUnderline.h:
2371 * public/WebCompositorInputHandler.h:
2372 * public/WebConsoleMessage.h:
2373 * public/WebContentDetectionResult.h:
2374 * public/WebContextMenuData.h:
2375 * public/WebCrossOriginPreflightResultCache.h:
2376 * public/WebCursorInfo.h:
2377 * public/WebDOMEvent.h:
2378 * public/WebDOMEventListener.h:
2379 * public/WebDOMStringList.h:
2380 * public/WebDataSource.h:
2381 * public/WebDatabase.h:
2382 * public/WebDateTimeChooserCompletion.h:
2383 * public/WebDateTimeChooserParams.h:
2384 * public/WebDeliveredIntentClient.h:
2385 * public/WebDevToolsAgent.h:
2386 * public/WebDevToolsAgentClient.h:
2387 * public/WebDevToolsFrontend.h:
2388 * public/WebDeviceOrientationClient.h:
2389 * public/WebDeviceOrientationClientMock.h:
2390 * public/WebDeviceOrientationController.h:
2391 * public/WebDocument.h:
2392 * public/WebDraggableRegion.h:
2393 * public/WebExternalPopupMenuClient.h:
2394 * public/WebFileChooserCompletion.h:
2395 * public/WebFileChooserParams.h:
2396 * public/WebFileSystemCallbacks.h:
2397 * public/WebFileSystemEntry.h:
2398 * public/WebFileWriter.h:
2399 * public/WebFileWriterClient.h:
2400 * public/WebFindOptions.h:
2402 * public/WebFontCache.h:
2403 * public/WebFontDescription.h:
2404 * public/WebFormControlElement.h:
2405 * public/WebFormElement.h:
2406 * public/WebFrame.h:
2407 * public/WebFrameClient.h:
2408 * public/WebGeolocationClientMock.h:
2409 * public/WebGeolocationController.h:
2410 * public/WebGeolocationError.h:
2411 * public/WebGeolocationPermissionRequest.h:
2412 * public/WebGeolocationPermissionRequestManager.h:
2413 * public/WebGeolocationPosition.h:
2414 * public/WebGlyphCache.h:
2415 * public/WebHelperPlugin.h:
2416 * public/WebHistoryItem.h:
2417 * public/WebHitTestResult.h:
2418 * public/WebIDBCallbacks.h:
2419 * public/WebIDBCursor.h:
2420 * public/WebIDBDatabase.h:
2421 * public/WebIDBDatabaseCallbacks.h:
2422 * public/WebIDBDatabaseError.h:
2423 * public/WebIDBFactory.h:
2424 * public/WebIDBKey.h:
2425 * public/WebIDBKeyPath.h:
2426 * public/WebIDBKeyRange.h:
2427 * public/WebIDBMetadata.h:
2428 * public/WebIDBTransaction.h:
2429 * public/WebIDBTransactionCallbacks.h:
2430 * public/WebIconURL.h:
2431 * public/WebImageDecoder.h:
2432 * public/WebInputEvent.h:
2433 * public/WebIntent.h:
2434 * public/WebIntentRequest.h:
2435 * public/WebIntentServiceInfo.h:
2437 * public/WebMediaPlayer.h:
2438 * public/WebMediaStreamRegistry.h:
2439 * public/WebMenuItemInfo.h:
2440 * public/WebNetworkStateNotifier.h:
2442 * public/WebNodeCollection.h:
2443 * public/WebNodeList.h:
2444 * public/WebNotification.h:
2445 * public/WebNotificationPresenter.h:
2446 * public/WebOptionElement.h:
2447 * public/WebPageOverlay.h:
2448 * public/WebPagePopup.h:
2449 * public/WebPageSerializer.h:
2450 * public/WebPasswordFormData.h:
2451 * public/WebPerformance.h:
2452 * public/WebPlugin.h:
2453 * public/WebPluginContainer.h:
2454 * public/WebPluginParams.h:
2455 * public/WebPopupMenu.h:
2456 * public/WebPopupMenuInfo.h:
2457 * public/WebPrerendererClient.h:
2458 * public/WebPrintParams.h:
2459 * public/WebRange.h:
2460 * public/WebRegularExpression.h:
2461 * public/WebRuntimeFeatures.h:
2462 * public/WebScopedMicrotaskSuppression.h:
2463 * public/WebScopedUserGesture.h:
2464 * public/WebScriptController.h:
2465 * public/WebScriptSource.h:
2466 * public/WebSearchableFormData.h:
2467 * public/WebSecurityOrigin.h:
2468 * public/WebSecurityPolicy.h:
2469 * public/WebSelectElement.h:
2470 * public/WebSerializedScriptValue.h:
2471 * public/WebSettings.h:
2472 * public/WebSharedWorker.h:
2473 * public/WebSharedWorkerRepository.h:
2474 * public/WebSocket.h:
2475 * public/WebSocketClient.h:
2476 * public/WebSpeechGrammar.h:
2477 * public/WebSpeechInputController.h:
2478 * public/WebSpeechInputResult.h:
2479 * public/WebSpeechRecognitionHandle.h:
2480 * public/WebSpeechRecognitionParams.h:
2481 * public/WebSpeechRecognitionResult.h:
2482 * public/WebSpeechRecognizer.h:
2483 * public/WebSpeechRecognizerClient.h:
2484 * public/WebSpellCheckClient.h:
2485 * public/WebStorageEventDispatcher.h:
2486 * public/WebSurroundingText.h:
2487 * public/WebTestingSupport.h:
2488 * public/WebTextCheckingCompletion.h:
2489 * public/WebTextCheckingResult.h:
2490 * public/WebTextFieldDecoratorClient.h:
2491 * public/WebTextInputInfo.h:
2492 * public/WebTextRun.h:
2493 * public/WebTimeRange.h:
2494 * public/WebTouchPoint.h:
2495 * public/WebUserMediaRequest.h:
2497 * public/WebViewBenchmarkSupport.h:
2498 * public/WebViewClient.h:
2499 * public/WebWidget.h:
2500 * public/WebWidgetClient.h:
2501 * public/WebWindowFeatures.h:
2502 * public/WebWorkerInfo.h:
2503 * public/android/WebInputEventFactory.h:
2504 * public/android/WebSandboxSupport.h:
2505 * public/default/WebRenderTheme.h:
2506 * public/gtk/WebInputEventFactory.h:
2507 * public/linux/WebFontRendering.h:
2508 * public/linux/WebSandboxSupport.h:
2509 * public/mac/WebInputEventFactory.h:
2510 * public/mac/WebSandboxSupport.h:
2511 * public/mac/WebScreenInfoFactory.h:
2512 * public/mac/WebSubstringUtil.h:
2513 * public/platform/WebAudioBus.h: Removed.
2514 * public/platform/WebAudioDevice.h: Removed.
2515 * public/platform/WebBlobData.h: Removed.
2516 * public/platform/WebBlobRegistry.h: Removed.
2517 * public/platform/WebCString.h: Removed.
2518 * public/platform/WebCanvas.h: Removed.
2519 * public/platform/WebClipboard.h: Removed.
2520 * public/platform/WebColor.h: Removed.
2521 * public/platform/WebCommon.h: Removed.
2522 * public/platform/WebCookie.h: Removed.
2523 * public/platform/WebCookieJar.h: Removed.
2524 * public/platform/WebData.h: Removed.
2525 * public/platform/WebDragData.h: Removed.
2526 * public/platform/WebFileSystem.h: Removed.
2527 * public/platform/WebFloatPoint.h: Removed.
2528 * public/platform/WebFloatQuad.h: Removed.
2529 * public/platform/WebFloatRect.h: Removed.
2530 * public/platform/WebGamepad.h: Removed.
2531 * public/platform/WebGamepads.h: Removed.
2532 * public/platform/WebGraphicsContext3D.h: Removed.
2533 * public/platform/WebHTTPBody.h: Removed.
2534 * public/platform/WebHTTPHeaderVisitor.h: Removed.
2535 * public/platform/WebHTTPLoadInfo.h: Removed.
2536 * public/platform/WebImage.h: Removed.
2537 * public/platform/WebLocalizedString.h: Removed.
2538 * public/platform/WebMediaStreamCenter.h: Removed.
2539 * public/platform/WebMediaStreamCenterClient.h: Removed.
2540 * public/platform/WebMediaStreamComponent.h: Removed.
2541 * public/platform/WebMediaStreamDescriptor.h: Removed.
2542 * public/platform/WebMediaStreamSource.h: Removed.
2543 * public/platform/WebMediaStreamSourcesRequest.h: Removed.
2544 * public/platform/WebNonCopyable.h: Removed.
2545 * public/platform/WebPoint.h: Removed.
2546 * public/platform/WebPrivateOwnPtr.h: Removed.
2547 * public/platform/WebPrivatePtr.h: Removed.
2548 * public/platform/WebRect.h: Removed.
2549 * public/platform/WebReferrerPolicy.h: Removed.
2550 * public/platform/WebSize.h: Removed.
2551 * public/platform/WebSocketStreamError.h: Removed.
2552 * public/platform/WebSocketStreamHandle.h: Removed.
2553 * public/platform/WebSocketStreamHandleClient.h: Removed.
2554 * public/platform/WebString.h: Removed.
2555 * public/platform/WebThread.h: Removed.
2556 * public/platform/WebThreadSafeData.h: Removed.
2557 * public/platform/WebURL.h: Removed.
2558 * public/platform/WebURLError.h: Removed.
2559 * public/platform/WebURLLoadTiming.h: Removed.
2560 * public/platform/WebURLLoader.h: Removed.
2561 * public/platform/WebURLLoaderClient.h: Removed.
2562 * public/platform/WebURLRequest.h: Removed.
2563 * public/platform/WebURLResponse.h: Removed.
2564 * public/platform/WebVector.h: Removed.
2565 * public/platform/android/WebSandboxSupport.h: Removed.
2566 * public/platform/android/WebThemeEngine.h: Removed.
2567 * public/platform/default/WebThemeEngine.h: Removed.
2568 * public/platform/linux/WebFontFamily.h: Removed.
2569 * public/platform/linux/WebSandboxSupport.h: Removed.
2570 * public/platform/mac/WebSandboxSupport.h: Removed.
2571 * public/platform/mac/WebThemeEngine.h: Removed.
2572 * public/platform/win/WebSandboxSupport.h: Removed.
2573 * public/platform/win/WebThemeEngine.h: Removed.
2574 * public/win/WebInputEventFactory.h:
2575 * public/win/WebSandboxSupport.h:
2576 * public/win/WebScreenInfoFactory.h:
2577 * public/x11/WebScreenInfoFactory.h:
2579 2013-01-23 Joshua Bell <jsbell@chromium.org>
2581 IndexedDB: Remove IDBVersionChangeRequest
2582 https://bugs.webkit.org/show_bug.cgi?id=107711
2584 Reviewed by Tony Chang.
2586 * public/WebIDBCallbacks.h: Note to delete onBlocked() once Chromium is cleaned up.
2587 * src/IDBCallbacksProxy.cpp: Remove unused onBlocked() overload.
2588 * src/IDBCallbacksProxy.h: Ditto.
2589 * src/WebIDBCallbacksImpl.cpp: Ditto.
2590 * src/WebIDBCallbacksImpl.h: Ditto.
2591 * tests/IDBAbortOnCorruptTest.cpp: Ditto.
2592 * tests/IDBDatabaseBackendTest.cpp: Ditto.
2594 2013-01-23 Tien-Ren Chen <trchen@chromium.org>
2596 Partially revert 104427, change WebWidgetClient::didHandleGestureEvent semantics.
2597 https://bugs.webkit.org/show_bug.cgi?id=107605
2599 Reviewed by Darin Fisher.
2601 Per discussion in https://codereview.chromium.org/11473027/ we decided
2602 not to introduce an enum to WebWidgetClient::didHandleGestureEvent().
2603 Instead, change the semantics of the bool flag to indicate whether the
2604 gesture event is cancelled for disambiguation.
2606 * public/WebWidgetClient.h:
2607 (WebKit::WebWidgetClient::didHandleGestureEvent):
2608 * src/WebViewImpl.cpp:
2609 (WebKit::WebViewImpl::handleGestureEvent):
2610 * tests/WebViewTest.cpp:
2612 2013-01-23 Mark Pilgrim <pilgrim@chromium.org>
2614 [Chromium] Remove WebArrayBufferView and WebSerializedScriptValue from chromium/public/platform/
2615 https://bugs.webkit.org/show_bug.cgi?id=107720
2617 Reviewed by Darin Fisher.
2619 These headers have been moved to chromium/public/ and all
2620 references downstream were changed in
2621 https://codereview.chromium.org/11946050/.
2622 No DEPS roll necessary because it's already above 177695.
2625 * public/platform/WebArrayBufferView.h: Removed.
2626 * public/platform/WebSerializedScriptValue.h: Removed.
2627 * src/DeliveredIntentClientImpl.cpp:
2628 * src/IDBCallbacksProxy.cpp:
2629 * src/IDBCursorBackendProxy.cpp:
2630 * src/WebArrayBufferView.cpp:
2631 * src/WebBindings.cpp:
2632 * src/WebDOMCustomEvent.cpp:
2633 * src/WebDOMMessageEvent.cpp:
2634 * src/WebFrameImpl.cpp:
2635 * src/WebHistoryItem.cpp:
2636 * src/WebIDBCallbacksImpl.cpp:
2637 * src/WebIntent.cpp:
2638 * src/WebIntentRequest.cpp:
2639 * src/WebSerializedScriptValue.cpp:
2641 2013-01-23 Mark Pilgrim <pilgrim@chromium.org>
2643 [Chromium] Fix some #includes to headers in chromium/public/platform/ that have been moved to the new Platform directory
2644 https://bugs.webkit.org/show_bug.cgi?id=107722
2646 Reviewed by Darin Fisher.
2648 These headers just redirect to the new versions, so call the new
2651 * src/linux/WebFontInfo.cpp:
2652 * src/mac/WebSubstringUtil.mm:
2654 2013-01-23 Mark Pilgrim <pilgrim@chromium.org>
2656 [Chromium] Fix some #includes for WebSerializedScriptValue
2657 https://bugs.webkit.org/show_bug.cgi?id=107697
2659 Reviewed by Adam Barth.
2661 WebSerializedScriptValue has been moved to chromium/public/.
2663 * public/WebDOMCustomEvent.h:
2664 * public/WebDOMMessageEvent.h:
2665 * public/WebIDBCursor.h:
2667 2013-01-23 Dmitry Gozman <dgozman@chromium.org>
2669 Added changeAttachedWindowHeight method to inspector frontend API, which
2670 allows to change inspector window height from inside.
2671 https://bugs.webkit.org/show_bug.cgi?id=107648
2673 Reviewed by Pavel Feldman.
2675 * public/WebDevToolsFrontendClient.h:
2676 (WebKit::WebDevToolsFrontendClient::changeAttachedWindowHeight):
2677 * src/InspectorFrontendClientImpl.cpp:
2678 (WebKit::InspectorFrontendClientImpl::changeAttachedWindowHeight):
2680 2013-01-23 Shinya Kawanaka <shinyak@chromium.org>
2682 shadowAncestorNode() should be renamed to deprecatedShadowAncestorNode()
2683 https://bugs.webkit.org/show_bug.cgi?id=107624
2685 Reviewed by Dimitri Glazkov.
2687 Since Node::shadowAncestorNode() is deprecated, we would like to rename it to prevent from further use.
2689 * src/WebFrameImpl.cpp:
2690 (WebKit::WebFrameImpl::scopeStringMatches):
2691 (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
2693 2013-01-22 Pavel Feldman <pfeldman@chromium.org>
2695 Web Inspector: only allow evaluateForTestInFrontend for front-ends under test.
2696 https://bugs.webkit.org/show_bug.cgi?id=107523
2698 Reviewed by Yury Semikhatsky.
2700 * public/WebDevToolsFrontendClient.h:
2701 (WebKit::WebDevToolsFrontendClient::isUnderTest):
2702 (WebDevToolsFrontendClient):
2703 * src/InspectorFrontendClientImpl.cpp:
2704 (WebKit::InspectorFrontendClientImpl::isUnderTest):
2705 * src/InspectorFrontendClientImpl.h:
2706 (InspectorFrontendClientImpl):
2708 2013-01-22 Mark Lam <mark.lam@apple.com>
2710 Change the Supplementable class to not use AtomicString.
2711 https://bugs.webkit.org/show_bug.cgi?id=107535.
2713 Reviewed by Adam Barth.
2715 Replaced the use of AtomicString keys with literal const char* keys.
2716 This simplifies the SupplementMap and makes it slightly leaner and faster.
2718 * src/ContextFeaturesClientImpl.cpp:
2719 (ContextFeaturesCache):
2720 (WebKit::ContextFeaturesCache::supplementName):
2722 2013-01-22 Leandro Gracia Gil <leandrogracia@chromium.org>
2724 [Chromium] Expose didCommitCompositorFrame in WebWidgetClient.
2725 https://bugs.webkit.org/show_bug.cgi?id=107325
2727 Reviewed by James Robinson.
2729 Add a notification on WebWidgetClient called when the compositor commits a frame.
2731 * public/WebWidgetClient.h:
2733 (WebKit::WebWidgetClient::didCommitCompositorFrame):
2734 * src/WebViewImpl.cpp:
2735 (WebKit::WebViewImpl::didCommit):
2737 2013-01-21 Kentaro Hara <haraken@chromium.org>
2739 Implement UIEvent constructor
2740 https://bugs.webkit.org/show_bug.cgi?id=107430
2742 Reviewed by Adam Barth.
2744 Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
2746 UIEvent constructor is implemented under a DOM4_EVENTS_CONSTRUCTOR flag,
2747 which is enabled on Safari and Chromium for now.
2751 2013-01-22 Alpha Lam <hclam@chromium.org>
2753 REGRESSION(r140392): InjectIDBKeyTest.TopLevelPropertyStringValue is crashing
2754 https://bugs.webkit.org/show_bug.cgi?id=107578
2756 Unreviewed build fix. Disabled 2 tests that are crashing after r140392.
2758 * tests/IDBBindingUtilitiesTest.cpp:
2761 2013-01-22 Eric Seidel <eric@webkit.org>
2763 Turn on ENABLE_THREADED_HTML_PARSER for Chromium (it's still disabled at runtime)
2764 https://bugs.webkit.org/show_bug.cgi?id=107519
2766 Reviewed by Adam Barth.
2768 This makes our development lives easier, and makes it possible for the bots
2769 to run threaded-parser-only tests by toggling the runtime enable
2770 via window.internals.settings.
2774 2013-01-22 Kentaro Hara <haraken@chromium.org>
2776 [V8] Make an Isolate parameter mandatory in toV8()
2777 https://bugs.webkit.org/show_bug.cgi?id=107520
2779 Reviewed by Adam Barth.
2781 Now it's safe to remove an optional Isolate parameter.
2783 No tests. No change in behavior.
2785 * src/InspectorFrontendClientImpl.cpp:
2786 (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
2787 * src/WebArrayBuffer.cpp:
2788 (WebKit::WebArrayBuffer::toV8Value):
2790 (WebKit::WebBlob::toV8Value):
2791 * src/WebFrameImpl.cpp:
2792 (WebKit::WebFrameImpl::createFileSystem):
2793 (WebKit::WebFrameImpl::createSerializableFileSystem):
2794 (WebKit::WebFrameImpl::createFileEntry):
2796 2013-01-21 Sheriff Bot <webkit.review.bot@gmail.com>
2798 Unreviewed. Rolled Chromium DEPS to r177962. Requested by
2799 "Yoshifumi Inoue" <yosin@chromium.org> via sheriffbot.
2803 2013-01-21 Noel Gordon <noel.gordon@gmail.com>
2805 [chromium] REGRESSION(r139347) roll chromium deps broke webkit-unit-tests
2806 https://bugs.webkit.org/show_bug.cgi?id=106631
2808 Reviewed by Kent Tamura.
2810 Fixed in http://crrev.com/177931 and rolled. Renable these tests.
2812 * tests/WebImageTest.cpp:
2814 2013-01-21 Dirk Schulze <dschulze@adobe.com>
2816 Add build flag for Canvas's Path object (disabled by default)
2817 https://bugs.webkit.org/show_bug.cgi?id=107473
2819 Reviewed by Dean Jackson.
2821 Add CANVAS_PATH build flag to build systems.
2825 2013-01-21 Sheriff Bot <webkit.review.bot@gmail.com>
2827 Unreviewed. Rolled Chromium DEPS to r177956. Requested by
2828 thakis_ via sheriffbot.
2832 2013-01-21 Sheriff Bot <webkit.review.bot@gmail.com>
2834 Unreviewed. Rolled Chromium DEPS to r177953. Requested by
2835 thakis_ via sheriffbot.
2839 2013-01-21 Tommy Widenflycht <tommyw@google.com>
2841 MediaStream API: Update the RTCPeerConnection states to match the latest specification
2842 https://bugs.webkit.org/show_bug.cgi?id=107120
2844 Reviewed by Adam Barth.
2846 * src/AssertMatchingEnums.cpp:
2848 2013-01-20 Dominic Mazzoni <dmazzoni@google.com>
2850 Make SpeechSynthesis compile in the Chromium port
2851 https://bugs.webkit.org/show_bug.cgi?id=107382
2853 Reviewed by Adam Barth.
2855 Add ENABLE_SPEECH_SYNTHESIS to features.gypi, off by default.
2859 2013-01-20 Yoshifumi Inoue <yosin@chromium.org>
2861 Dragging over an element with scrollbars should scroll the element when dragging near edges
2862 https://bugs.webkit.org/show_bug.cgi?id=39725
2864 Reviewed by Hajime Morita.
2866 This patch removes DragScrollTimer used for automatic scrolling of main
2867 frame drag-and-drop which is now implemented in EventHandler.
2869 Another patch will remove DragScrollTimer.{cpp,h} and update GYP files to
2870 make patch size small.
2872 No tests. Existing test covers this change.
2874 * src/ChromeClientImpl.cpp:
2875 (WebKit::ChromeClientImpl::shouldAutoscrollForDragAndDrop): Added.
2876 * src/ChromeClientImpl.h:
2877 (ChromeClientImpl): Changed to add shouldAutoscrollForDragAndDrop().
2878 * src/WebViewImpl.cpp:
2879 (WebKit::WebViewImpl::WebViewImpl): Changed to remove m_dragScrollTimer.
2880 (WebKit::WebViewImpl::dragSourceEndedAt): ditto
2881 (WebKit::WebViewImpl::dragSourceMovedTo): ditto
2882 (WebKit::WebViewImpl::dragTargetDrop): ditto
2883 (WebKit::WebViewImpl::dragTargetDragEnterOrOver): ditto
2884 * src/WebViewImpl.h:
2885 (WebKit): Chagned to remove DragScrollTimer.
2887 2013-01-18 Alec Flett <alecflett@chromium.org>
2889 IndexedDB: Switch to new createTransaction call
2890 https://bugs.webkit.org/show_bug.cgi?id=107311
2892 Reviewed by Tony Chang.
2894 * public/WebIDBTransaction.h:
2896 Remove an old method that nobody calls.
2898 2013-01-18 Alpha Lam <hclam@chromium.org>
2900 [chromium] Roll Chromium DEPS to 177676
2902 Unreviewed DEPS roll.
2906 2013-01-18 Robert Kroeger <rjkroege@chromium.org>
2908 [chromium] Use new-style gesture scrolling events for fling and
2909 for plugin scrolling: https://bugs.webkit.org/show_bug.cgi?id=106589
2911 Reviewed by James Robinson.
2913 https://bugs.webkit.org/show_bug.cgi?id=103952 modified touchscreen
2914 scrolling to not use synthetic mouse wheel events. Update the fling facility
2915 in WebViewImpl to use these events for touchscreen-initiated flings. Also
2916 modify the WebPluginContainerImpl to scroll in response to touchscreen
2917 scroll gestures if the plugin does not itself implement gesture events.
2919 * src/WebPluginContainerImpl.cpp:
2920 * src/WebViewImpl.cpp:
2921 (WebKit::WebViewImpl::WebViewImpl):
2922 (WebKit::WebViewImpl::scrollBy): Handle fling callback conditionally based
2923 on initiating device. Touchpad flings generate wheels. Touchscreen flings
2925 (WebKit::WebViewImpl::handleGestureEvent):
2926 (WebKit::WebViewImpl::transferActiveWheelFlingAnimation):
2927 * src/WebViewImpl.h:
2929 2013-01-18 Seokju Kwon <seokju.kwon@gmail.com>
2931 Add explicit keyword to constructors in platform-specific InspectorClient
2932 https://bugs.webkit.org/show_bug.cgi?id=107255
2934 Reviewed by Kentaro Hara.
2936 Add explicit keyword to constructors that take one argument
2937 in platform-specific implementation of InspectorClient.
2939 * src/InspectorClientImpl.h:
2940 (InspectorClientImpl):
2942 2013-01-17 Dominic Cooney <dominicc@chromium.org>
2944 [Chromium] Unreviewed gardening.
2946 Roll Chromium to 177561.
2950 2013-01-17 Alpha Lam <hclam@chromium.org>
2952 [chromium] Disable a unit test
2953 https://bugs.webkit.org/show_bug.cgi?id=107206
2955 Unreviewed. Disable a failing test due to 140025.
2957 * tests/WebFrameTest.cpp:
2959 2013-01-17 Sheriff Bot <webkit.review.bot@gmail.com>
2961 Unreviewed, rolling out r140023.
2962 http://trac.webkit.org/changeset/140023
2963 https://bugs.webkit.org/show_bug.cgi?id=107176
2965 Broke some tests (Requested by anttik on #webkit).
2967 * tests/RenderTableCellTest.cpp:
2968 * tests/RenderTableRowTest.cpp:
2970 2013-01-17 John Mellor <johnme@chromium.org>
2972 [chromium] Double-tap zoom should take into account accessibility fontScaleFactor
2973 https://bugs.webkit.org/show_bug.cgi?id=107123
2975 Reviewed by Adam Barth.
2977 Platforms which support Text Autosizing (currently just Chrome for
2978 Android) may provide a textAutosizingFontScaleFactor (defaults to 1.0).
2980 This value is intended to be chosen by the user to indicate how large
2981 they want text to appear, for example Chrome for Android has a "Text
2982 scaling" slider in Settings > Accessibility that lets you choose a value
2983 in the range 50% - 200% (defaults to 100%*).
2985 For text in wide columns that typically gets autosized, this value is
2986 applied by multiplying the textAutosizingMultiplier computed for each
2987 cluster by the textAutosizingFontScaleFactor. Double-tap zoom will fit
2988 the column to the screen (ignoring the textAutosizingFontScaleFactor)
2989 since the column is wide. This part already works.
2991 For text in narrow columns that doesn't get autosized, the
2992 textAutosizingFontScaleFactor is not applied through Text Autosizing,
2993 and instead needs to be applied by adjusting the double-tap zoom level.
2994 When double-tapping on narrow columns, instead of fitting the column to
2995 the screen (which would often zoom in excessively far), the existing
2996 logic in computeScaleAndScrollForHitRect applies a maximum zoom level
2997 called the legibleScale. This value needs to be multiplied by the
2998 textAutosizingFontScaleFactor, so that we zoom in proportionately
2999 further on non-autosized narrow columns, hence the effective text size
3000 (taking into account zoom) will have increased in proportion to the
3001 textAutosizingFontScaleFactor as expected.
3003 * src/WebViewImpl.cpp:
3004 (WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
3005 Multiplies legibleScale (the maximum zoom level) by the
3006 textAutosizingFontScaleFactor.
3007 * tests/WebFrameTest.cpp:
3008 Added WebFrameTest.DivAutoZoomScaleFontScaleFactorTest based on
3009 WebFrameTest.DivAutoZoomScaleBoundsTest to test the interaction
3010 between textAutosizingFontScaleFactor and the double-tap zoom logic.
3011 Also did minor cleanup to WebFrameTest.DivAutoZoomScaleBoundsTest.
3013 2013-01-17 Alexandre Elias <aelias@chromium.org>
3015 [chromium] Make new-style page scale work with fixed layout
3016 https://bugs.webkit.org/show_bug.cgi?id=106951
3018 Reviewed by Adam Barth.
3020 This makes non-CSS-transform page scaling work with fixed-layout mode,
3021 including viewport tag support.
3023 - dispatchViewportPropertiesDidChange() now works entirely with DIP
3024 pixels instead of physical pixels, and is made compatible with
3025 separating deviceScaleFactor from pageScaleFactor.
3027 - In this mode, the "layout viewport" size in the pinch-zoom model is
3028 made a first-class concept separate from the device size. This
3029 is a viewport with the same aspect ratio as the device but with the
3030 layout width of the page. This viewport is used:
3031 - As FrameView::visibleContentRect.
3032 - Returned from WebView::size().
3033 - Given to the compositor as layoutViewportSize.
3035 - m_deviceScaleInCompositor is deleted as it's clearer to use the
3036 applyDeviceScaleInCompositor setting directly.
3038 * src/ChromeClientImpl.cpp:
3039 (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
3040 * src/WebViewImpl.cpp:
3041 (WebKit::WebViewImpl::WebViewImpl):
3042 (WebKit::WebViewImpl::size):
3044 (WebKit::WebViewImpl::resize):
3045 (WebKit::WebViewImpl::setPageScaleFactor):
3046 (WebKit::WebViewImpl::setDeviceScaleFactor):
3047 (WebKit::WebViewImpl::layoutSize):
3048 (WebKit::WebViewImpl::computePageScaleFactorLimits):
3049 (WebKit::WebViewImpl::dipSize):
3050 (WebKit::WebViewImpl::didChangeContentsSize):
3051 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
3052 (WebKit::WebViewImpl::updateLayerTreeViewport):
3053 * src/WebViewImpl.h:
3056 2013-01-17 Sheriff Bot <webkit.review.bot@gmail.com>
3058 Unreviewed. Rolled Chromium DEPS to r177369. Requested by
3059 ajuma via sheriffbot.
3063 2013-01-17 Eugene Klyuchnikov <eustas@chromium.org>
3065 Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
3066 https://bugs.webkit.org/show_bug.cgi?id=104545
3068 Reviewed by Yury Semikhatsky.
3070 Adopt changes: mimic old behavior.
3072 * src/WebDevToolsAgentImpl.cpp: Adopt signature changes.
3074 2013-01-17 Yury Semikhatsky <yurys@chromium.org>
3076 Web Inspector: add WebDeToolsAgentImpl as task observer on reattach
3077 https://bugs.webkit.org/show_bug.cgi?id=107106
3079 Reviewed by Pavel Feldman.
3081 Register WebDevToolsAgentImpl as task observer when it client is reattached.
3083 * src/WebDevToolsAgentImpl.cpp:
3084 (WebKit::WebDevToolsAgentImpl::reattach):
3086 2013-01-16 Dominic Cooney <dominicc@chromium.org>
3088 [Chromium] Unreviewed gardening.
3090 Roll Chromium to 177350.
3094 2013-01-16 Kristian Monsen <kristianm@google.com>
3096 Fix build break for Android webview.
3097 https://bugs.webkit.org/show_bug.cgi?id=107072
3099 Reviewed by Steve Block.
3101 Add extra guards when checking for OS=="Android" to make sure it is not included
3104 * WebKitUnitTests.gyp:
3106 2013-01-16 Dominic Cooney <dominicc@chromium.org>
3108 [Chromium] Unreviewed gardening.
3110 Roll Chromium to 177310.
3114 2013-01-16 W. James MacLean <wjmaclean@chromium.org>
3116 LinkHighlight should use touch adjustment to match active state on GestureTapDown.
3117 https://bugs.webkit.org/show_bug.cgi?id=107032
3119 Reviewed by Adam Barth.
3121 LinkHighlight node selection should produce results that match the node marked
3122 active during GestureTapDown.
3124 * src/WebViewImpl.cpp:
3125 (WebKit::WebViewImpl::bestTouchLinkNode):
3126 * tests/LinkHighlightTest.cpp:
3129 2013-01-16 Kentaro Hara <haraken@chromium.org>
3131 [V8] Make a creationContext parameter of toV8() mandatory
3132 https://bugs.webkit.org/show_bug.cgi?id=107020
3134 Reviewed by Adam Barth.
3136 We pass Handle<Object>() to a creationContext parameter of
3137 toV8() when we do not have a creationContext.
3139 No tests. No change in behavior.
3141 * src/InspectorFrontendClientImpl.cpp:
3142 (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
3143 * src/WebArrayBuffer.cpp:
3144 (WebKit::WebArrayBuffer::toV8Value):
3146 (WebKit::WebBlob::toV8Value):
3147 * src/WebFrameImpl.cpp:
3148 (WebKit::WebFrameImpl::createFileSystem):
3149 (WebKit::WebFrameImpl::createSerializableFileSystem):
3150 (WebKit::WebFrameImpl::createFileEntry):
3152 2013-01-16 Mark Pilgrim <pilgrim@chromium.org>
3154 [Chromium] Move WebArrayBufferView and WebSerializedScriptValue out of public/platform/
3155 https://bugs.webkit.org/show_bug.cgi?id=106863
3157 Reviewed by Adam Barth.
3159 These are not being moved into the new top-level Platform
3160 directory, so into public they go.
3163 * public/WebArrayBufferView.h: Added.
3166 (WebArrayBufferView):
3167 (WebKit::WebArrayBufferView::~WebArrayBufferView):
3168 (WebKit::WebArrayBufferView::WebArrayBufferView):
3169 * public/WebSerializedScriptValue.h: Added.
3172 (WebSerializedScriptValue):
3173 (WebKit::WebSerializedScriptValue::~WebSerializedScriptValue):
3174 (WebKit::WebSerializedScriptValue::WebSerializedScriptValue):
3175 (WebKit::WebSerializedScriptValue::operator=):
3176 (WebKit::WebSerializedScriptValue::isNull):
3177 * public/platform/WebArrayBufferView.h:
3178 * public/platform/WebSerializedScriptValue.h:
3180 2013-01-16 Chris Hopman <cjhopman@chromium.org>
3182 [Chromium] Remove hardcoded chromium_*.jar in gyp files
3183 https://bugs.webkit.org/show_bug.cgi?id=104049
3185 Reviewed by Eric Seidel.
3187 Targets with dependencies (direct/indirect) on a java target receive
3188 the chromium_*.jar paths in the variable input_jars_paths. Targets
3189 should use that rather than hardcoding where they think the jar will
3190 be. These can be passed directly to ant as INPUT_JARS_PATHS rather
3191 than as --jars to generate_native_test.py.
3193 * WebKitUnitTests.gyp:
3195 2013-01-16 Dominic Cooney <dominicc@chromium.org>
3197 [Chromium] Unreviewed gardening.
3199 Roll Chromium to 177117.
3203 2013-01-16 Dominic Cooney <dominicc@chromium.org>
3205 [Chromium] Unreviewed gardening.
3207 Roll Chromium to r177080.
3211 2013-01-15 Ian Vollick <vollick@chromium.org>
3213 [chromium] Create GraphicsLayerChromiums using a factory
3214 https://bugs.webkit.org/show_bug.cgi?id=103635
3216 Reviewed by James Robinson.
3218 Refactor graphics layer creation for chromium to go through a factory.
3220 * src/ChromeClientImpl.cpp:
3222 (GraphicsLayerFactoryChromium):
3223 (WebCore::GraphicsLayerFactoryChromium::~GraphicsLayerFactoryChromium):
3224 (WebKit::ChromeClientImpl::ChromeClientImpl):
3225 (WebKit::ChromeClientImpl::graphicsLayerFactory):
3227 * src/ChromeClientImpl.h:
3230 * src/NonCompositedContentHost.cpp:
3231 (WebKit::NonCompositedContentHost::NonCompositedContentHost):
3232 * src/NonCompositedContentHost.h:
3234 (WebKit::NonCompositedContentHost::create):
3235 (NonCompositedContentHost):
3236 * src/PageOverlay.cpp:
3237 (WebKit::PageOverlay::update):
3238 * src/WebViewImpl.cpp:
3239 (WebKit::WebViewImpl::graphicsLayerFactory):
3241 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
3242 * src/WebViewImpl.h:
3245 * tests/GraphicsLayerChromiumTest.cpp:
3246 (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
3247 * tests/ImageLayerChromiumTest.cpp:
3250 2013-01-15 Mark Pilgrim <pilgrim@chromium.org>
3252 [Chromium] Move SocketStreamHandle and SocketStreamHandleInternal to WebCore/platform
3253 https://bugs.webkit.org/show_bug.cgi?id=106899
3255 Reviewed by Adam Barth.
3257 Part of a larger refactoring series; see tracking bug 106829.
3260 * src/SocketStreamHandle.cpp: Removed.
3261 * src/SocketStreamHandleInternal.h: Removed.
3263 2013-01-15 Florin Malita <fmalita@chromium.org>
3265 [Chromium] Incorrect opaque region tracking for PlatformContextSkia::drawRRect
3266 https://bugs.webkit.org/show_bug.cgi?id=106898
3268 Reviewed by Stephen White.
3270 * tests/PlatformContextSkiaTest.cpp:
3274 2012-12-28 Vsevolod Vlasov <vsevik@chromium.org>
3276 Web Inspector: Support inspector file system access with isolated file system through InspectorFrontendHost.
3277 https://bugs.webkit.org/show_bug.cgi?id=105727
3279 Reviewed by Pavel Feldman.
3281 File system access methods plumbing made for Chromium.
3283 * public/WebDevToolsFrontendClient.h:
3284 (WebKit::WebDevToolsFrontendClient::requestFileSystems):
3285 (WebKit::WebDevToolsFrontendClient::addFileSystem):
3286 (WebKit::WebDevToolsFrontendClient::removeFileSystem):
3287 (WebDevToolsFrontendClient):
3288 * src/InspectorFrontendClientImpl.cpp:
3289 (WebKit::InspectorFrontendClientImpl::supportsFileSystems):
3291 (WebKit::InspectorFrontendClientImpl::requestFileSystems):
3292 (WebKit::InspectorFrontendClientImpl::addFileSystem):
3293 (WebKit::InspectorFrontendClientImpl::removeFileSystem):
3294 * src/InspectorFrontendClientImpl.h:
3295 (InspectorFrontendClientImpl):
3297 2013-01-14 Dominic Cooney <dominicc@chromium.org>
3299 [Chromium] Unreviewed gardening.
3301 Roll Chromium to r176801.
3303 * DEPS: Rollin' on the river.
3305 2013-01-14 Mark Pilgrim <pilgrim@chromium.org>
3307 [Chromium] Remove unused public/platform/WebColorName.h
3308 https://bugs.webkit.org/show_bug.cgi?id=106865
3310 Reviewed by Adam Barth.
3312 This file is no longer referenced anywhere in WebKit or Chromium.
3314 * public/platform/WebColorName.h: Removed.
3316 2013-01-14 Mark Pilgrim <pilgrim@chromium.org>
3318 [Chromium] Move BlobRegistryProxy into WebCore
3319 https://bugs.webkit.org/show_bug.cgi?id=106831
3321 Reviewed by Adam Barth.
3323 Part of a larger refactoring series to remove layering violations
3324 in Chromium. See tracking bug 106829.
3327 * src/BlobRegistryProxy.cpp: Removed.
3328 * src/BlobRegistryProxy.h: Removed.
3330 2013-01-14 Alec Flett <alecflett@chromium.org>
3332 IndexedDB: Remove IDBObjectStore/IndexBackendImpl and support functions
3333 https://bugs.webkit.org/show_bug.cgi?id=106605
3335 Remove all references to IDBObjectStoreBackend* and IDBIndexBackend*
3336 as they no longer exist in WebCore.
3338 Reviewed by Darin Fisher.
3341 * public/WebIDBCallbacks.h:
3343 * public/WebIDBDatabase.h:
3345 (WebKit::WebIDBDatabase::metadata):
3346 * public/WebIDBFactory.h:
3348 * public/WebIDBIndex.h: Removed.
3349 * public/WebIDBObjectStore.h: Removed.
3350 * public/WebIDBTransaction.h:
3351 * src/IDBCallbacksProxy.cpp:
3352 * src/IDBDatabaseBackendProxy.cpp:
3353 * src/IDBDatabaseBackendProxy.h:
3354 (IDBDatabaseBackendProxy):
3355 * src/IDBFactoryBackendProxy.cpp:
3356 * src/IDBFactoryBackendProxy.h:
3357 (IDBFactoryBackendProxy):
3358 * src/IDBIndexBackendProxy.cpp: Removed.
3359 * src/IDBIndexBackendProxy.h: Removed.
3360 * src/IDBObjectStoreBackendProxy.cpp: Removed.
3361 * src/IDBObjectStoreBackendProxy.h: Removed.
3362 * src/IDBTransactionBackendProxy.cpp:
3363 * src/IDBTransactionBackendProxy.h:
3364 (IDBTransactionBackendProxy):
3365 * src/WebIDBDatabaseImpl.cpp:
3366 (WebKit::WebIDBDatabaseImpl::put):
3367 (WebKit::WebIDBDatabaseImpl::setIndexKeys):
3368 * src/WebIDBDatabaseImpl.h:
3370 (WebIDBDatabaseImpl):
3371 * src/WebIDBFactoryImpl.cpp:
3372 (WebKit::WebIDBFactoryImpl::getDatabaseNames):
3373 * src/WebIDBFactoryImpl.h:
3374 (WebIDBFactoryImpl):
3375 * src/WebIDBIndexImpl.cpp: Removed.
3376 * src/WebIDBIndexImpl.h: Removed.
3377 * src/WebIDBObjectStoreImpl.cpp: Removed.
3378 * src/WebIDBObjectStoreImpl.h: Removed.
3379 * src/WebIDBTransactionImpl.cpp:
3380 * src/WebIDBTransactionImpl.h:
3381 * tests/IDBAbortOnCorruptTest.cpp:
3383 * tests/IDBDatabaseBackendTest.cpp:
3385 2013-01-14 Dominic Mazzoni <dmazzoni@google.com>
3387 AX: Need to implement ColorWellRole
3388 https://bugs.webkit.org/show_bug.cgi?id=106756
3390 Reviewed by Chris Fleizach.
3392 Adds an accessibility interface to access the value of a
3395 * public/WebAccessibilityObject.h:
3396 (WebAccessibilityObject):
3397 * src/WebAccessibilityObject.cpp:
3398 (WebKit::WebAccessibilityObject::colorValue):
3401 2013-01-14 Mark Pilgrim <pilgrim@chromium.org>
3403 [Chromium] Move AudioDestinationChromium into WebCore
3404 https://bugs.webkit.org/show_bug.cgi?id=106803
3406 Reviewed by Adam Barth.
3408 This doesn't really belong in WebKit/chromium/src since it defines
3409 things directly in the WebCore namespace.
3412 * src/AudioDestinationChromium.cpp: Removed.
3413 * src/AudioDestinationChromium.h: Removed.
3415 2013-01-14 Stephen Chenney <schenney@chromium.org>
3417 Re-enabling the SK_DISABLE_DASHING_OPTIMIZATION flag for Skia
3419 Unreviewed build fix.
3421 It turns out that the change behind this flag causes crashes and image errors.
3425 2013-01-14 Kentaro Hara <haraken@chromium.org>
3427 [V8] Make an Isolate parameter mandatory in ScriptDebugServer::interruptAndRun()
3428 https://bugs.webkit.org/show_bug.cgi?id=106779
3430 Reviewed by Adam Barth.
3432 This is one of steps to make an Isolate parameter mandatory.
3434 No tests. No change in behavior.
3436 * src/WebDevToolsAgentImpl.cpp:
3437 (WebKit::WebDevToolsAgent::interruptAndDispatch):
3439 2013-01-13 Vsevolod Vlasov <vsevik@chromium.org>
3441 Web Inspector: [Chromium] DevToolsSanityTest.TestNoScriptDuplicatesOnPanelSwitch fails
3442 https://bugs.webkit.org/show_bug.cgi?id=106755
3444 Reviewed by Alexander Pavlov.
3447 (.TestSuite.prototype.nonAnonymousUISourceCodes_.filterOutService):
3448 (.TestSuite.prototype.nonAnonymousUISourceCodes_):
3450 2013-01-12 David Grogan <dgrogan@chromium.org>
3452 Unreviewed. Roll chromium DEPS to 176595.
3453 https://bugs.webkit.org/show_bug.cgi?id=106730
3457 2013-01-11 Dan Beam <dbeam@chromium.org>
3459 [clean up] Remove HTMLFormElement::AutocompleteResultError in favor of more specific Error reasons
3460 https://bugs.webkit.org/show_bug.cgi?id=106610
3462 Reviewed by Darin Fisher.
3464 * public/WebFormElement.h: Removed WebFormElement::AutocompleteResultError in favor of more specific error reasons.
3465 * src/AssertMatchingEnums.cpp: Removed enum value from compile-time asserts.
3467 2013-01-11 Tien-Ren Chen <trchen@chromium.org>
3469 WebWidgetClient::didHandleGestureEvent needs to distinguish the case if the event is processed or swallowed
3470 https://bugs.webkit.org/show_bug.cgi?id=104427
3472 Reviewed by Adam Barth.
3474 When a gesture needs to be disambiguated, WebKit doesn't update cursor focus.
3475 We added an extra status for didHandleGestureEvent(), so we can distinguish
3476 the case whether the event is actually delivered to the web page or cancelled.
3478 * public/WebViewClient.h:
3479 * public/WebWidgetClient.h:
3482 (WebKit::WebWidgetClient::didHandleGestureEvent):
3483 * src/WebViewImpl.cpp:
3484 (WebKit::WebViewImpl::handleGestureEvent):
3485 * tests/WebViewTest.cpp:
3487 2013-01-11 Eberhard Graether <egraether@google.com>
3489 [chromium] Add ContinuousPainter to call setNeedsDisplay on all layers recursively in continuous painting mode
3490 https://bugs.webkit.org/show_bug.cgi?id=105458
3492 Reviewed by James Robinson.
3494 In continuous painting mode all layers are constantly repainted to allow for life measurements of page paint time,
3495 while changing HTML and CSS using the WebInspector. This change adds the ContinuousPainter helper object, which
3496 calls setNeedsDisplay() on all GraphicsLayers recursively in order to force all layers to repaint. PageOverlay