[chromium] Push culled tiles that are prepainted
[WebKit-https.git] / Source / WebKit / chromium / ChangeLog
1 2012-03-19  Dana Jansens  <danakj@chromium.org>
2
3         [chromium] Push culled tiles that are prepainted
4         https://bugs.webkit.org/show_bug.cgi?id=81552
5
6         Reviewed by Adrienne Walker.
7
8         * tests/TiledLayerChromiumTest.cpp:
9         (WTF::TEST):
10         (WTF):
11
12 2012-03-19  James Robinson  <jamesr@chromium.org>
13
14         Unreviewed chromium compile fix - put all TRACE_*s in their own scope explicitly.
15
16         * src/WebCompositorInputHandlerImpl.cpp:
17         (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
18         (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
19
20 2012-03-19  Robert Kroeger  <rjkroege@chromium.org>
21
22         [chromium] return true/false on GestureFlingCancel if a fling was stopped
23         https://bugs.webkit.org/show_bug.cgi?id=81563
24
25         Reviewed by James Robinson.
26
27         * src/WebViewImpl.cpp:
28         (WebKit::WebViewImpl::gestureEvent):
29
30 2012-03-19  Michal Mocny  <mmocny@google.com>
31
32         [chromium] Adding support for GL_EXT_discard_framebuffer.
33         https://bugs.webkit.org/show_bug.cgi?id=81383
34
35         Reviewed by James Robinson.
36
37         * src/Extensions3DChromium.cpp:
38         (WebCore::Extensions3DChromium::discardFramebufferEXT):
39         (WebCore):
40         (WebCore::Extensions3DChromium::ensureFramebufferCHROMIUM):
41         * src/GraphicsContext3DChromium.cpp:
42         (WebCore):
43         * src/GraphicsContext3DPrivate.h:
44         (GraphicsContext3DPrivate):
45         * tests/FakeWebGraphicsContext3D.h:
46         (WebKit::FakeWebGraphicsContext3D::discardFramebufferEXT):
47         (WebKit::FakeWebGraphicsContext3D::ensureFramebufferCHROMIUM):
48         (FakeWebGraphicsContext3D):
49
50 2012-03-19  Ian Vollick  <vollick@chromium.org>
51
52         [chromium] Times in the cc should be expressed in seconds.
53         https://bugs.webkit.org/show_bug.cgi?id=80514
54
55         Reviewed by James Robinson.
56
57         * tests/CCDelayBasedTimeSourceTest.cpp:
58         (WebKitTests::TEST):
59         * tests/CCFrameRateControllerTest.cpp:
60         (WebKitTests::TEST):
61         * tests/CCSchedulerTestCommon.h:
62         (WebKitTests::FakeCCThread::pendingDelayMs):
63         (WebKitTests::FakeCCDelayBasedTimeSource::create):
64         (WebKitTests::FakeCCDelayBasedTimeSource::setMonotonicallyIncreasingTime):
65         (WebKitTests::FakeCCDelayBasedTimeSource::monotonicallyIncreasingTime):
66         (WebKitTests::FakeCCDelayBasedTimeSource::FakeCCDelayBasedTimeSource):
67         (FakeCCDelayBasedTimeSource):
68         * tests/CCTimerTest.cpp:
69         (WebKitTests::TEST_F):
70
71 2012-03-19  Nat Duca  <nduca@chromium.org>
72
73         [chromium] Stop deriving WebCompositor from WebCompositorInputHandler
74         https://bugs.webkit.org/show_bug.cgi?id=80586
75
76         Reviewed by Darin Fisher.
77
78         * public/WebCompositor.h:
79         (WebKit):
80         * public/WebCompositorInputHandler.h:
81         (WebCompositorInputHandler):
82         * public/WebWidgetClient.h:
83         (WebWidgetClient):
84         (WebKit::WebWidgetClient::didActivateCompositor):
85         * src/WebCompositorInputHandlerImpl.cpp:
86         (WebKit::WebCompositorInputHandler::fromIdentifier):
87         * src/WebCompositorInputHandlerImpl.h:
88         (WebCompositorInputHandlerImpl):
89
90 2012-03-18  James Robinson  <jamesr@chromium.org>
91
92         [chromium] Implement fling-by-wheel on compositor thread
93         https://bugs.webkit.org/show_bug.cgi?id=81462
94
95         Reviewed by Adrienne Walker.
96
97         Implement fling-by-wheel and beef up existing unit test coverage considerably by using gmock instead of mocking
98         by hand.
99
100         * src/WebCompositorInputHandlerImpl.cpp:
101         (WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
102         (WebKit):
103         (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
104         (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
105         (WebKit::WebCompositorInputHandlerImpl::animate):
106         (WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):
107         (WebKit::WebCompositorInputHandlerImpl::scrollBy):
108         * src/WebCompositorInputHandlerImpl.h:
109         (WebCompositorInputHandlerImpl):
110         * tests/WebCompositorInputHandlerImplTest.cpp:
111
112 2012-03-19  Emil A Eklund  <eae@chromium.org>
113
114         [mac/chromium] Change platform code to use pixelSnappedRect methods
115         https://bugs.webkit.org/show_bug.cgi?id=81016
116
117         Reviewed by Eric Seidel.
118
119         * src/WebViewImpl.cpp:
120         (WebKit::WebViewImpl::computeBlockBounds):
121         (WebKit::WebViewImpl::applyAutofillSuggestions):
122         (WebKit::WebViewImpl::refreshAutofillPopup):
123
124 2012-03-19  Eric Seidel  <eric@webkit.org>
125
126         Fix WTF header include discipline in Chromium WebKit
127         https://bugs.webkit.org/show_bug.cgi?id=81281
128
129         Reviewed by James Robinson.
130
131         * src/CompositionUnderlineBuilder.h:
132         * src/CompositionUnderlineVectorBuilder.h:
133         * src/FrameLoaderClientImpl.cpp:
134         * src/WebArrayBuffer.cpp:
135         * src/WebArrayBufferView.cpp:
136         * src/WebBindings.cpp:
137         * src/WebColorName.cpp:
138         * src/WebGeolocationClientMock.cpp:
139         * src/WebPageSerializer.cpp:
140         * src/WebSocketImpl.cpp:
141         * src/WebViewImpl.cpp:
142         * tests/FrameTestHelpers.cpp:
143
144 2012-03-19  Dana Jansens  <danakj@chromium.org>
145
146         [chromium] Invalidate/update evicted tiles during commit
147         https://bugs.webkit.org/show_bug.cgi?id=81529
148
149         Reviewed by Adrienne Walker.
150
151         * tests/TiledLayerChromiumTest.cpp:
152         (WTF::TEST):
153         (WTF):
154
155 2012-03-19  Sheriff Bot  <webkit.review.bot@gmail.com>
156
157         Unreviewed, rolling out r111207.
158         http://trac.webkit.org/changeset/111207
159         https://bugs.webkit.org/show_bug.cgi?id=81561
160
161         Causing chromium unit test failure (Requested by reveman on
162         #webkit).
163
164         * src/Extensions3DChromium.cpp:
165         * src/GraphicsContext3DChromium.cpp:
166         (WebCore):
167         * src/GraphicsContext3DPrivate.h:
168         (GraphicsContext3DPrivate):
169         * tests/FakeWebGraphicsContext3D.h:
170
171 2012-03-19  Tommy Widenflycht  <tommyw@google.com>
172
173         [chromium] MediaStream API (JSEP): Introducing WebMediaHints and WebIceOptions
174         https://bugs.webkit.org/show_bug.cgi?id=81341
175
176         Reviewed by Darin Fisher.
177
178         Simple WebKit representations of the WebCore/platform versions.
179
180         * WebKit.gyp:
181         * public/platform/WebICEOptions.h: Added.
182         (WebCore):
183         (WebKit):
184         (WebICEOptions):
185         (WebKit::WebICEOptions::WebICEOptions):
186         (WebKit::WebICEOptions::~WebICEOptions):
187         (WebKit::WebICEOptions::operator=):
188         (WebKit::WebICEOptions::isNull):
189         * public/platform/WebMediaHints.h: Added.
190         (WebCore):
191         (WebKit):
192         (WebMediaHints):
193         (WebKit::WebMediaHints::WebMediaHints):
194         (WebKit::WebMediaHints::~WebMediaHints):
195         (WebKit::WebMediaHints::operator=):
196         (WebKit::WebMediaHints::isNull):
197         * src/WebICEOptions.cpp: Added.
198         (WebKit):
199         (WebKit::WebICEOptions::WebICEOptions):
200         (WebKit::WebICEOptions::assign):
201         (WebKit::WebICEOptions::reset):
202         (WebKit::WebICEOptions::candidateTypeToUse):
203         * src/WebMediaHints.cpp: Added.
204         (WebKit):
205         (WebKit::WebMediaHints::WebMediaHints):
206         (WebKit::WebMediaHints::assign):
207         (WebKit::WebMediaHints::reset):
208         (WebKit::WebMediaHints::audio):
209         (WebKit::WebMediaHints::video):
210
211 2012-03-19  Michal Mocny  <mmocny@google.com>
212
213         [chromium] Updating WebGraphicsContext3D MemoryAllocation callback to accept a struct with have backbuffer suggestion.
214         https://bugs.webkit.org/show_bug.cgi?id=81279
215
216         Reviewed by James Robinson.
217
218         * src/GraphicsContext3DChromium.cpp:
219         (WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
220         (WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
221         (GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
222
223 2012-03-19  David Reveman  <reveman@chromium.org>
224
225         [Chromium] GL_EXT_occlusion_query_boolean and GL_CHROMIUM_command_buffer_query support.
226         https://bugs.webkit.org/show_bug.cgi?id=80988
227
228         Reviewed by Adrienne Walker.
229
230         Expose EXT_occlusion_query API to WebKit compositor.
231
232         * src/Extensions3DChromium.cpp:
233         (WebCore::Extensions3DChromium::createQueryEXT):
234         (WebCore):
235         (WebCore::Extensions3DChromium::deleteQueryEXT):
236         (WebCore::Extensions3DChromium::isQueryEXT):
237         (WebCore::Extensions3DChromium::beginQueryEXT):
238         (WebCore::Extensions3DChromium::endQueryEXT):
239         (WebCore::Extensions3DChromium::getQueryivEXT):
240         (WebCore::Extensions3DChromium::getQueryObjectuivEXT):
241         * src/GraphicsContext3DChromium.cpp:
242         (WebCore):
243         * src/GraphicsContext3DPrivate.h:
244         (GraphicsContext3DPrivate):
245         * tests/FakeWebGraphicsContext3D.h:
246         (WebKit::FakeWebGraphicsContext3D::createQueryEXT):
247         (WebKit::FakeWebGraphicsContext3D::deleteQueryEXT):
248         (WebKit::FakeWebGraphicsContext3D::isQueryEXT):
249         (WebKit::FakeWebGraphicsContext3D::beginQueryEXT):
250         (WebKit::FakeWebGraphicsContext3D::endQueryEXT):
251         (WebKit::FakeWebGraphicsContext3D::getQueryivEXT):
252         (WebKit::FakeWebGraphicsContext3D::getQueryObjectuivEXT):
253         (FakeWebGraphicsContext3D):
254
255 2012-03-19  Dana Jansens  <danakj@chromium.org>
256
257         [chromium] Unit test fix, save the sharedQuadState while the quads hold a pointer to it
258         https://bugs.webkit.org/show_bug.cgi?id=81476
259
260         Reviewed by Adrienne Walker.
261
262         * tests/CCQuadCullerTest.cpp:
263         (WebCore::appendQuads):
264         (WebCore):
265         (WebCore::TEST):
266
267 2012-03-19  Sheriff Bot  <webkit.review.bot@gmail.com>
268
269         Unreviewed.  Rolled DEPS.
270
271         * DEPS:
272
273 2012-03-19  Robert Kroeger  <rjkroege@chromium.org>
274
275         [chromium] synthesize wheel events for fling on main thread
276         https://bugs.webkit.org/show_bug.cgi?id=81458
277
278         Support track pad fling by generating a sequence of wheel events.
279
280         Reviewed by James Robinson.
281
282         * src/WebViewImpl.cpp:
283         (WebKit::WebViewImpl::WebViewImpl):
284         (WebKit::WebViewImpl::scrollBy): Call-back from PlatformGestureCurve to dispatch wheel event.
285         (WebKit):
286         (WebKit::WebViewImpl::gestureEvent): Handle GestureFlingStart and GestureFlingCancel.
287         (WebKit::WebViewImpl::updateAnimations): Requests a PlatformGestureCurve to animate forward.
288         (WebKit::WebViewImpl::didCommitLoad): Halt flings on navigations.
289         * src/WebViewImpl.h:
290         (WebCore):
291         (WebViewImpl):
292
293 2012-03-19  Keishi Hattori  <keishi@webkit.org>
294
295         [chromium] Fix build that was broken by r111137
296
297         Fixed was ambiguous because of MacTypes.h
298
299         * tests/CCLayerTreeHostCommonTest.cpp:
300         (WebCore::addTransformAnimationToLayer):
301         * tests/CCOcclusionTrackerTest.cpp:
302         (WebCore::addTransformAnimationToLayer):
303
304 2012-03-18  Keishi Hattori  <keishi@webkit.org>
305
306         [chromium] Fix test that was broken by r111128
307
308         * tests/ScrollAnimatorNoneTest.cpp:
309         (TEST): ScrollByPixel no longer animates.
310
311 2012-03-18  Dana Jansens  <danakj@chromium.org>
312
313         [chromium] Don't occlude on main-thread behind layers/surfaces with impl-thread animations
314         https://bugs.webkit.org/show_bug.cgi?id=81354
315
316         Reviewed by Adrienne Walker.
317
318         * tests/CCOcclusionTrackerTest.cpp:
319         (WebCore):
320         (WebCore::addOpacityAnimationToLayer):
321         (WebCore::addTransformAnimationToLayer):
322         (CCOcclusionTrackerTestAnimationOpacity1OnMainThread):
323         (WebCore::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
324         (CCOcclusionTrackerTestAnimationOpacity0OnMainThread):
325         (WebCore::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
326         (CCOcclusionTrackerTestAnimationTranslateOnMainThread):
327         (WebCore::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
328
329 2012-03-18  Dana Jansens  <danakj@chromium.org>
330
331         [chromium] Animating opacity is not opaque and should create a render surface on main thread
332         https://bugs.webkit.org/show_bug.cgi?id=81401
333
334         Reviewed by James Robinson.
335
336         * tests/CCLayerTreeHostCommonTest.cpp:
337         (WebCore::TEST):
338
339 2012-03-18  Dana Jansens  <danakj@chromium.org>
340
341         [chromium] Transform animation state should be inherited from parents
342         https://bugs.webkit.org/show_bug.cgi?id=81363
343
344         Reviewed by Adrienne Walker.
345
346         * tests/CCLayerTreeHostCommonTest.cpp:
347         (WebCore::addOpacityAnimationToLayer):
348         (WebCore):
349         (WebCore::addTransformAnimationToLayer):
350         (WebCore::TEST):
351
352 2012-03-16  James Robinson  <jamesr@chromium.org>
353
354         [chromium] Unify the drawing logic for different layer types that output textures to the compositor
355         https://bugs.webkit.org/show_bug.cgi?id=81286
356
357         Reviewed by Adrienne Walker.
358
359         * tests/Canvas2DLayerChromiumTest.cpp:
360
361 2012-03-15  Daniel Cheng  <dcheng@chromium.org>
362
363         [chromium] Refactor ClipboardChromium and DataTransferItemList/DataTransferItem to support HTML spec
364         https://bugs.webkit.org/show_bug.cgi?id=76598
365
366         Reviewed by Tony Chang.
367
368         * src/WebDragData.cpp:
369         (WebKit::WebDragData::items):
370         (WebKit::WebDragData::addItem):
371         (WebKit::WebDragData::assign):
372
373 2012-03-16  Dana Jansens  <danakj@chromium.org>
374
375         [chromium] Add overdraw metrics for texture uploads
376         https://bugs.webkit.org/show_bug.cgi?id=81175
377
378         Reviewed by Adrienne Walker.
379
380         * tests/TiledLayerChromiumTest.cpp:
381         (WTF::TEST):
382
383 2012-03-16  Dana Jansens  <danakj@chromium.org>
384
385         [chromium] Remove surface damage client from occlusion tracker
386         https://bugs.webkit.org/show_bug.cgi?id=81242
387
388         Reviewed by Adrienne Walker.
389
390         * tests/CCOcclusionTrackerTest.cpp:
391         (WebCore):
392
393 2012-03-16  Ian Vollick  <vollick@chromium.org>
394
395         [chromium] Threaded opacity animation jump to opacity of 0
396         https://bugs.webkit.org/show_bug.cgi?id=80744
397
398         Reviewed by James Robinson.
399
400         * tests/CCLayerTreeHostTest.cpp:
401         (WTF):
402         (CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity):
403         (WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity):
404         (WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::beginTest):
405         (WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::animateLayers):
406         (WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::commitCompleteOnCCThread):
407         (WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::afterTest):
408         (WTF::TEST_F):
409
410 2012-03-16  Dana Jansens  <danakj@chromium.org>
411
412         [chromium] Changes to overdraw metrics to allow upload tracking
413         https://bugs.webkit.org/show_bug.cgi?id=81222
414
415         Reviewed by Adrienne Walker.
416
417         * tests/CCQuadCullerTest.cpp:
418         (WebCore::appendQuads):
419         (WebCore):
420         (WebCore::TEST):
421         * tests/MockCCQuadCuller.h:
422         (WebCore::MockCCQuadCuller::MockCCQuadCuller):
423
424 2012-03-16  Dana Jansens  <danakj@chromium.org>
425
426         [chromium] Quads that become fully opaque after culling should not use blending
427         https://bugs.webkit.org/show_bug.cgi?id=81235
428
429         Reviewed by Adrienne Walker.
430
431         * tests/CCLayerTreeHostImplTest.cpp:
432         (WebKit::BlendStateCheckLayer::appendQuads):
433         (WebKit::BlendStateCheckLayer::setQuadRect):
434         (WebKit::BlendStateCheckLayer::setQuadVisibleRect):
435         (WebKit::BlendStateCheckLayer::setOpaqueContents):
436         (WebKit::BlendStateCheckLayer::setOpaqueContentRect):
437         (WebKit::BlendStateCheckLayer::BlendStateCheckLayer):
438         (BlendStateCheckLayer):
439         (WebKit::TEST_F):
440
441 2012-03-15  Hans Wennborg  <hans@chromium.org>
442
443         Speech JavaScript API: SpeechRecognition, Controller and Client
444         https://bugs.webkit.org/show_bug.cgi?id=81096
445
446         Reviewed by Adam Barth.
447
448         Provide a SpeechRecognitionController to Page, with a NULL client for
449         now.
450
451         * src/WebViewImpl.cpp:
452         (WebKit::WebViewImpl::WebViewImpl):
453
454 2012-03-15  Dana Jansens  <danakj@chromium.org>
455
456         [chromium] Fix some assertions in occlusion tracker unit tests
457         https://bugs.webkit.org/show_bug.cgi?id=81308
458
459         Reviewed by James Robinson.
460
461         * tests/CCOcclusionTrackerTest.cpp:
462         (WebCore::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
463         (WebCore::CCOcclusionTrackerTestDamageRectOutsideChild::runMyTest):
464         (WebCore::CCOcclusionTrackerTest3dTransform::runMyTest):
465         (WebCore::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
466
467 2012-03-15  Sheriff Bot  <webkit.review.bot@gmail.com>
468
469         Unreviewed, rolling out r110941.
470         http://trac.webkit.org/changeset/110941
471         https://bugs.webkit.org/show_bug.cgi?id=81307
472
473         the revert looks innocent. (Requested by morrita on #webkit).
474
475         * tests/CCLayerTreeHostTest.cpp:
476         (WTF::ContentLayerChromiumWithUpdateTracking::paintContentsIfDirty):
477         (WTF::ContentLayerChromiumWithUpdateTracking::idlePaintContentsIfDirty):
478         (WTF::TestLayerChromium::paintContentsIfDirty):
479         * tests/Canvas2DLayerChromiumTest.cpp:
480         * tests/TiledLayerChromiumTest.cpp:
481         (TestCCOcclusionTracker):
482         (WTF::TestCCOcclusionTracker::TestCCOcclusionTracker):
483         (WTF::TestCCOcclusionTracker::setOcclusion):
484         (WTF::TestCCOcclusionTracker::layerScissorRectInTargetSurface):
485         (WTF):
486         (WTF::FakeTiledLayerChromium::prepareToUpdate):
487         (WTF::FakeTiledLayerChromium::prepareToUpdateIdle):
488         (WTF::FakeTiledLayerChromium::paintContentsIfDirty):
489         (WTF::TEST):
490
491 2012-03-15  Sheriff Bot  <webkit.review.bot@gmail.com>
492
493         Unreviewed, rolling out r110929.
494         http://trac.webkit.org/changeset/110929
495         https://bugs.webkit.org/show_bug.cgi?id=81306
496
497         breaking webkit_unit_tests (Requested by morrita on #webkit).
498
499         * tests/CCLayerTreeHostTest.cpp:
500         (WTF::ContentLayerChromiumWithUpdateTracking::paintContentsIfDirty):
501         (WTF::ContentLayerChromiumWithUpdateTracking::idlePaintContentsIfDirty):
502         (WTF::TestLayerChromium::paintContentsIfDirty):
503         * tests/Canvas2DLayerChromiumTest.cpp:
504         * tests/TiledLayerChromiumTest.cpp:
505         (WTF::FakeTiledLayerChromium::prepareToUpdate):
506         (WTF::FakeTiledLayerChromium::prepareToUpdateIdle):
507         (WTF::FakeTiledLayerChromium::paintContentsIfDirty):
508         (WTF::TEST):
509
510 2012-03-15  Dana Jansens  <danakj@chromium.org>
511
512         [chromium] Decide occlusion in paint culling with CCOcclusionTracker
513         https://bugs.webkit.org/show_bug.cgi?id=81181
514
515         Reviewed by Adrienne Walker.
516
517         * tests/CCLayerTreeHostTest.cpp:
518         (WTF::ContentLayerChromiumWithUpdateTracking::paintContentsIfDirty):
519         (WTF::ContentLayerChromiumWithUpdateTracking::idlePaintContentsIfDirty):
520         (WTF::TestLayerChromium::paintContentsIfDirty):
521         * tests/Canvas2DLayerChromiumTest.cpp:
522         * tests/TiledLayerChromiumTest.cpp:
523         (TestCCOcclusionTracker):
524         (WTF::TestCCOcclusionTracker::TestCCOcclusionTracker):
525         (WTF::TestCCOcclusionTracker::setOcclusion):
526         (WTF::TestCCOcclusionTracker::layerScissorRectInTargetSurface):
527         (WTF):
528         (WTF::FakeTiledLayerChromium::prepareToUpdate):
529         (WTF::FakeTiledLayerChromium::prepareToUpdateIdle):
530         (WTF::FakeTiledLayerChromium::paintContentsIfDirty):
531         (WTF::TEST):
532
533 2012-03-15  Dana Jansens  <danakj@chromium.org>
534
535         [chromium] Move overdraw metrics into a templated class for both paint and draw metrics.
536         https://bugs.webkit.org/show_bug.cgi?id=81156
537
538         Reviewed by Adrienne Walker.
539
540         * tests/CCQuadCullerTest.cpp:
541         (WebCore::appendQuads):
542         (WebCore):
543         (WebCore::TEST):
544
545 2012-03-07  Jon Lee  <jonlee@apple.com>
546
547         Move NotificationContents into Notification
548         https://bugs.webkit.org/show_bug.cgi?id=80487
549         <rdar://problem/10965519>
550
551         Reviewed by Jian Li.
552
553         Refactor to use accessor methods on Notification.
554         * src/WebNotification.cpp:
555         (WebKit::WebNotification::title):
556         (WebKit::WebNotification::body):
557
558 2012-03-13  Jon Lee  <jonlee@apple.com>
559
560         Deprecate ondisplay()
561         https://bugs.webkit.org/show_bug.cgi?id=80483
562         <rdar://problem/10912432>
563
564         Reviewed by Jian Li.
565
566         * src/WebNotification.cpp:
567         (WebKit::WebNotification::dispatchDisplayEvent): Dispatch the show event.
568
569 2012-03-14  W. James MacLean  <wjmaclean@chromium.org>
570
571         [chromium] Wire up PlatformGestureCurves for CC, ScrollAnimatorNone.
572         https://bugs.webkit.org/show_bug.cgi?id=80607
573
574         Reviewed by James Robinson.
575
576         * public/WebInputEvent.h:
577         (WebKit::WebInputEvent::isScrollGestureEventType):
578         * src/WebCompositorInputHandlerImpl.cpp:
579         (PlatformGestureToCCGestureAdapter):
580         (WebCore::PlatformGestureToCCGestureAdapter::create):
581         (WebCore::PlatformGestureToCCGestureAdapter::apply):
582         (WebCore::PlatformGestureToCCGestureAdapter::scrollBy):
583         (WebCore::PlatformGestureToCCGestureAdapter::PlatformGestureToCCGestureAdapter):
584         (WebCore):
585         (WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
586         (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
587         (WebKit):
588         (WebKit::WebCompositorInputHandlerImpl::scrollBy):
589         * src/WebCompositorInputHandlerImpl.h:
590         (WebCore):
591         (WebCompositorInputHandlerImpl):
592         * tests/PlatformGestureCurveTest.cpp:
593         * tests/WebCompositorInputHandlerImplTest.cpp:
594
595 2012-03-15  Dana Jansens  <danakj@chromium.org>
596
597         [Chromium] REGRESSION(r110596) CCQuadCullerTest.verifyCullChildLinesUpTopLeft fails on Windows
598         https://bugs.webkit.org/show_bug.cgi?id=81083
599
600         Reviewed by Adrienne Walker.
601
602         * tests/CCQuadCullerTest.cpp:
603         (WebCore::TEST):
604
605 2012-03-15  David Levin  <levin@chromium.org>
606
607         Various autoresize fixes.
608         https://bugs.webkit.org/show_bug.cgi?id=81199
609
610         Reviewed by Darin Fisher.
611
612         * public/WebView.h:
613         (WebView): Remove a deprecated api.
614         * src/WebViewImpl.cpp: Ditto.
615         * src/WebViewImpl.h: Ditto.
616         * tests/FrameTestHelpers.cpp:
617         (WebKit::FrameTestHelpers::registerMockedURLLoad): Added an overload with more flexibility.
618         The previous api didn't allow one to request a url with a search string.
619         (FrameTestHelpers):
620         * tests/FrameTestHelpers.h:
621         (FrameTestHelpers): Ditto.
622         * tests/WebViewTest.cpp: Fix the test because calling javascript:
623         was working. Make the test generic and added a lot more tests to cover
624         various possibilities. I avoided using a layout test because there wasn't
625         a way to get the scrollbar state, so I just generalized a test that was already there.
626         * tests/data/specify_size.html: Allow the test to take its size from the search string.
627
628 2012-03-15  Peter Beverloo  <peter@chromium.org>
629
630         Unreviewed.  Rolled DEPS.
631
632         * DEPS:
633
634 2012-03-14  Chris Fleizach  <cfleizach@apple.com>
635
636         AXDescription for HTML5 footer and ARIA role contentinfo incorrect
637         https://bugs.webkit.org/show_bug.cgi?id=78967
638
639         Reviewed by Beth Dakin.
640
641         * src/LocalizedStrings.cpp:
642
643 2012-03-13  Jon Lee  <jonlee@apple.com>
644
645         Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
646         https://bugs.webkit.org/show_bug.cgi?id=80922
647         <rdar://problem/11035082>
648
649         Reviewed by Jian Li.
650
651         You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
652         LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
653         new API. Therefore, APIs that are common between the two will have:
654         #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
655
656         This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
657         the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
658
659         Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
660         * src/AssertMatchingEnums.cpp:
661         * src/NotificationPresenterImpl.cpp:
662         * src/NotificationPresenterImpl.h:
663         * src/WebNotification.cpp:
664         * src/WebRuntimeFeatures.cpp:
665         (WebKit::WebRuntimeFeatures::enableNotifications):
666         (WebKit::WebRuntimeFeatures::isNotificationsEnabled):
667         * src/WebViewImpl.cpp:
668         (WebKit::WebViewImpl::WebViewImpl):
669         (WebKit):
670         * src/WebViewImpl.h:
671         (WebViewImpl):
672
673 2012-03-14  James Robinson  <jamesr@chromium.org>
674
675         [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
676         https://bugs.webkit.org/show_bug.cgi?id=80523
677
678         Reviewed by Darin Fisher.
679
680         * public/WebViewClient.h:
681         (WebViewClient):
682         (WebKit::WebViewClient::createGraphicsContext3D):
683         * public/platform/WebKitPlatformSupport.h:
684         (WebKit):
685         * src/WebViewImpl.cpp:
686         (WebKit::WebViewImpl::createCompositorGraphicsContext3D):
687
688 2012-03-14  James Robinson  <jamesr@chromium.org>
689
690         [chromium] Remove canRecoverFromContextLoss attribute, it's unused
691         https://bugs.webkit.org/show_bug.cgi?id=81158
692
693         Reviewed by Stephen White.
694
695         Deletes the canRecoverFromContextLoss attribute from WebCore::GraphicsContext3D::Attributes. This is still left in
696         WebGraphicsContext3D::Attributes, since chromium-side code still references it.
697
698         * src/GraphicsContext3DChromium.cpp:
699         (WebCore::GraphicsContext3D::create):
700
701 2012-03-14  Stephen White  <senorblanco@chromium.org>
702
703         [chromium] Fix accelerated Canvas2D with threaded compositing.
704         https://bugs.webkit.org/show_bug.cgi?id=80998
705
706         Reviewed by James Robinson.
707
708         * tests/Canvas2DLayerChromiumTest.cpp:
709         Instantiate a CCLayerTreeHost, so that Canvas2DLayerChromium can
710         retrieve its texture manager.  Also move the test into the unnamed
711         namespace -- since it's already using WebCore, there's little reason for
712         it to also be in the namespace.
713         * tests/TreeSynchronizerTest.cpp:
714         (WebKitTests):
715         (WebKitTests::TEST):
716         Add a new test for trying to synchronize NULL tree.
717
718 2012-03-14  James Robinson  <jamesr@chromium.org>
719
720         [chromium] Provide explicit polling API to check if the platform is capable of accelerated 2d canvas
721         https://bugs.webkit.org/show_bug.cgi?id=80667
722
723         Reviewed by Darin Fisher.
724
725         * public/platform/WebKitPlatformSupport.h:
726         (WebKit::WebKitPlatformSupport::canAccelerate2dCanvas):
727         (WebKitPlatformSupport):
728         * src/PlatformSupport.cpp:
729         (WebCore::PlatformSupport::canAccelerate2dCanvas):
730         (WebCore):
731
732 2012-03-14  Andrey Kosyakov  <caseq@chromium.org>
733
734         Web Inspector: add didCancelFrame timeline event
735         https://bugs.webkit.org/show_bug.cgi?id=80994
736
737         Reviewed by Pavel Feldman.
738
739         - add intrumentCanceFrame(), called when renderer decides not to
740             render frame after instrumentBeginFrame() was called.
741
742         * public/WebWidget.h:
743         (WebWidget):
744         (WebKit::WebWidget::instrumentCancelFrame):
745         * src/WebViewImpl.cpp:
746         (WebKit::WebViewImpl::instrumentCancelFrame):
747         (WebKit):
748         * src/WebViewImpl.h:
749         (WebViewImpl):
750
751 2012-03-14  Dana Jansens  <danakj@chromium.org>
752
753         Region can acquire an empty span by subtracting an empty Region
754         https://bugs.webkit.org/show_bug.cgi?id=81074
755
756         Reviewed by Anders Carlsson.
757
758         * tests/RegionTest.cpp:
759         (WebCore::TEST):
760         (WebCore):
761
762 2012-03-13  Hajime Morrita  <morrita@chromium.org>
763
764         Unreviewed, mark verifyCullChildLinesUpTopLeft() as failed.
765
766         * tests/CCQuadCullerTest.cpp:
767         (WebCore):
768         (WebCore::TEST):
769
770 2012-03-14  Marja Hölttä  <marja@google.com>
771
772         WebHTTPBody: Keep track of whether the data includes passwords.
773         https://bugs.webkit.org/show_bug.cgi?id=81003
774
775         Reviewed by Darin Fisher.
776
777         This change enables Chrome to save HTTP bodies selectively, only
778         if they don't contain passwords.
779
780         * public/platform/WebHTTPBody.h:
781         (WebHTTPBody): Added containsPasswordData, setContainsPasswordData.
782         * src/WebHTTPBody.cpp:
783         (WebKit::WebHTTPBody::containsPasswordData): Added.
784         (WebKit):
785         (WebKit::WebHTTPBody::setContainsPasswordData): Added.
786
787 2012-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
788
789         Unreviewed.  Rolled DEPS.
790
791         * DEPS:
792
793 2012-03-13  Hajime Morrita  <morrita@chromium.org>
794
795         Unreviewed, mark verifyCullChildLinesUpTopLeft() as failed.
796
797         * tests/CCQuadCullerTest.cpp:
798         (WebCore):
799         (WebCore::TEST):
800
801 2012-03-13  Shawn Singh  <shawnsingh@chromium.org>
802
803         [chromium] wrong transform causing incorrect culling
804         https://bugs.webkit.org/show_bug.cgi?id=80471
805
806         Reviewed by James Robinson.
807
808         * tests/CCRenderSurfaceTest.cpp:
809         (WebCore::TEST):
810         (WebCore):
811
812 2012-03-13  Nat Duca  <nduca@chromium.org>
813
814         [chromium] vsync ticks are needed in invisible tabs when we are still updating resources
815         https://bugs.webkit.org/show_bug.cgi?id=80910
816
817         Reviewed by James Robinson.
818
819         * tests/CCSchedulerStateMachineTest.cpp:
820         (WebCore::TEST):
821         (WebCore):
822
823 2012-03-13  Dana Jansens  <danakj@chromium.org>
824
825         Region::contains(IntPoint) is slow
826         https://bugs.webkit.org/show_bug.cgi?id=81008
827
828         Reviewed by Anders Carlsson.
829
830         * WebKit.gypi:
831         * tests/RegionTest.cpp: Added.
832         (WebCore):
833         (WebCore::TEST):
834
835 2012-03-13  Gavin Peters  <gavinp@chromium.org>
836
837         Implement ApplicationCacheHost::canCacheInPageCache() for chromium.
838         https://bugs.webkit.org/show_bug.cgi?id=80905
839
840         Reviewed by Eric Seidel.
841
842         This won't cause chrome to use the PageCache, but it will cause our histogram statistics
843         describing PageCache use to be more accurate.
844
845         * src/ApplicationCacheHost.cpp:
846         (WebCore::ApplicationCacheHost::canCacheInPageCache):
847
848 2012-03-13  Dana Jansens  <danakj@chromium.org>
849
850         [chromium] Use CCOcclusionTracker for draw culling
851         https://bugs.webkit.org/show_bug.cgi?id=80743
852
853         Reviewed by Adrienne Walker.
854
855         * WebKit.gypi:
856         * tests/CCLayerTreeHostImplTest.cpp:
857         (WebKit::BlendStateCheckLayer::appendQuads):
858         * tests/CCQuadCullerTest.cpp:
859         (TestCCOcclusionTrackerImpl):
860         (WebCore::TestCCOcclusionTrackerImpl::TestCCOcclusionTrackerImpl):
861         (WebCore::TestCCOcclusionTrackerImpl::layerScissorRectInTargetSurface):
862         (WebCore::makeLayer):
863         (WebCore::appendQuads):
864         (WebCore):
865         (WebCore::TEST):
866         * tests/CCSolidColorLayerImplTest.cpp:
867         (CCLayerTestCommon::TEST):
868         * tests/CCTiledLayerImplTest.cpp:
869         (CCLayerTestCommon::TEST):
870         (CCLayerTestCommon::getQuads):
871         * tests/MockCCQuadCuller.h: Added.
872         (WebCore):
873         (MockCCQuadCuller):
874         (WebCore::MockCCQuadCuller::MockCCQuadCuller):
875         (WebCore::MockCCQuadCuller::append):
876         (WebCore::MockCCQuadCuller::quadList):
877
878 2012-03-13  Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>
879
880         Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
881         https://bugs.webkit.org/show_bug.cgi?id=78853
882
883         Reviewed by Adam Barth.
884
885         * features.gypi:
886         * src/ChromeClientImpl.cpp:
887         * src/ChromeClientImpl.h:
888         (ChromeClientImpl):
889
890 2012-03-13  Tommy Widenflycht  <tommyw@google.com>
891
892         MediaStream API: Rename PeerConnection to DeprecatedPeerConnection
893         https://bugs.webkit.org/show_bug.cgi?id=80692
894
895         Reviewed by Adam Barth.
896
897         First patch in a series of patches to change the PeerConnection from ROAP to JSEP,
898         see bug 80589 for more information.
899
900         * WebKit.gyp:
901         * bridge/DeprecatedPeerConnectionHandler.cpp: Renamed from Source/WebKit/chromium/bridge/PeerConnectionHandler.cpp.
902         (WebCore):
903         (WebCore::DeprecatedPeerConnectionHandler::create):
904         (WebCore::DeprecatedPeerConnectionHandler::DeprecatedPeerConnectionHandler):
905         (WebCore::DeprecatedPeerConnectionHandler::~DeprecatedPeerConnectionHandler):
906         (WebCore::DeprecatedPeerConnectionHandler::produceInitialOffer):
907         (WebCore::DeprecatedPeerConnectionHandler::handleInitialOffer):
908         (WebCore::DeprecatedPeerConnectionHandler::processSDP):
909         (WebCore::DeprecatedPeerConnectionHandler::processPendingStreams):
910         (WebCore::DeprecatedPeerConnectionHandler::sendDataStreamMessage):
911         (WebCore::DeprecatedPeerConnectionHandler::stop):
912         * bridge/DeprecatedPeerConnectionHandlerInternal.cpp: Renamed from Source/WebKit/chromium/bridge/PeerConnectionHandlerInternal.cpp.
913         (WebCore):
914         (WebCore::DeprecatedPeerConnectionHandlerInternal::DeprecatedPeerConnectionHandlerInternal):
915         (WebCore::DeprecatedPeerConnectionHandlerInternal::~DeprecatedPeerConnectionHandlerInternal):
916         (WebCore::DeprecatedPeerConnectionHandlerInternal::produceInitialOffer):
917         (WebCore::DeprecatedPeerConnectionHandlerInternal::handleInitialOffer):
918         (WebCore::DeprecatedPeerConnectionHandlerInternal::processSDP):
919         (WebCore::DeprecatedPeerConnectionHandlerInternal::processPendingStreams):
920         (WebCore::DeprecatedPeerConnectionHandlerInternal::sendDataStreamMessage):
921         (WebCore::DeprecatedPeerConnectionHandlerInternal::stop):
922         (WebCore::DeprecatedPeerConnectionHandlerInternal::didCompleteICEProcessing):
923         (WebCore::DeprecatedPeerConnectionHandlerInternal::didGenerateSDP):
924         (WebCore::DeprecatedPeerConnectionHandlerInternal::didReceiveDataStreamMessage):
925         (WebCore::DeprecatedPeerConnectionHandlerInternal::didAddRemoteStream):
926         (WebCore::DeprecatedPeerConnectionHandlerInternal::didRemoveRemoteStream):
927         * bridge/DeprecatedPeerConnectionHandlerInternal.h: Renamed from Source/WebKit/chromium/bridge/PeerConnectionHandlerInternal.h.
928         (WebKit):
929         (WebCore):
930         (DeprecatedPeerConnectionHandlerInternal):
931
932 2012-03-13  Dana Jansens  <danakj@chromium.org>
933
934         [chromium] Use projectQuad to apply inverse mapRect
935         https://bugs.webkit.org/show_bug.cgi?id=80741
936
937         Reviewed by Adrienne Walker.
938
939         * tests/CCOcclusionTrackerTest.cpp:
940         (WebCore):
941         (CCOcclusionTrackerTest3dTransform):
942         (WebCore::CCOcclusionTrackerTest3dTransform::runMyTest):
943         (CCOcclusionTrackerTestPerspectiveTransform):
944         (WebCore::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
945         (CCOcclusionTrackerTestPerspectiveTransformBehindCamera):
946         (WebCore::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):
947
948 2012-03-13  Gavin Peters  <gavinp@chromium.org>
949
950         Make ApplicationCacheHost::canCacheInPageCache() non-const.
951         https://bugs.webkit.org/show_bug.cgi?id=80904
952
953         Reviewed by Alexey Proskuryakov.
954
955         A const pointer to a large object like ApplicationCacheHost is not our standard
956         practice; so remove this (implicit) one.  See also https://bugs.webkit.org/show_bug.cgi?id=80898
957
958         * src/ApplicationCacheHost.cpp:
959         (WebCore::ApplicationCacheHost::canCacheInPageCache):
960
961 2012-03-13  Kinuko Yasuda  <kinuko@chromium.org>
962
963         Allow WebFileChooser to return extra file info (like displayName) in addition to mere file paths
964         https://bugs.webkit.org/show_bug.cgi?id=80719
965
966         Reviewed by Kent Tamura.
967
968         * public/WebFileChooserCompletion.h:
969         (SelectedFileInfo): Added.
970         (WebFileChooserCompletion):
971         (WebKit::WebFileChooserCompletion::didChooseFile): Added an overloaded
972         method that takes SelectedFileInfo.
973         * src/WebFileChooserCompletionImpl.cpp:
974         (WebKit::WebFileChooserCompletionImpl::didChooseFile): Ditto.
975         (WebKit):
976         * src/WebFileChooserCompletionImpl.h:
977         (WebFileChooserCompletionImpl):
978
979 2012-03-12  Sheriff Bot  <webkit.review.bot@gmail.com>
980
981         Unreviewed, rolling out r110529.
982         http://trac.webkit.org/changeset/110529
983         https://bugs.webkit.org/show_bug.cgi?id=80969
984
985         breaks mac build (Requested by morrita on #webkit).
986
987         * tests/CCOcclusionTrackerTest.cpp:
988         (WebCore):
989
990 2012-03-12  Hajime Morrita  <morrita@chromium.org>
991
992         Unreviewed Windows build fix.
993
994         * src/WebViewImpl.cpp:
995
996 2012-03-12  Dana Jansens  <danakj@chromium.org>
997
998         [chromium] Use projectQuad to apply inverse mapRect
999         https://bugs.webkit.org/show_bug.cgi?id=80741
1000
1001         Reviewed by Adrienne Walker.
1002
1003         * tests/CCOcclusionTrackerTest.cpp:
1004         (WebCore):
1005         (CCOcclusionTrackerTest3dTransform):
1006         (WebCore::CCOcclusionTrackerTest3dTransform::runMyTest):
1007         (CCOcclusionTrackerTestPerspectiveTransform):
1008         (WebCore::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
1009         (CCOcclusionTrackerTestPerspectiveTransformBehindCamera):
1010         (WebCore::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):
1011
1012 2012-03-12  Dana Jansens  <danakj@chromium.org>
1013
1014         [chromium] Fix clang build for CCOcclusionTracker tests
1015         https://bugs.webkit.org/show_bug.cgi?id=80891
1016
1017         Reviewed by Adam Barth.
1018
1019         * tests/CCOcclusionTrackerTest.cpp:
1020         (WebCore::CCOcclusionTrackerTest::createRoot):
1021         (WebCore::CCOcclusionTrackerTest::createLayer):
1022         (WebCore::CCOcclusionTrackerTest::createDrawingLayer):
1023
1024 2012-03-12  Stephen White  <senorblanco@chromium.org>
1025
1026         [chromium] Restore canvas2D acceleration after context loss.
1027         https://bugs.webkit.org/show_bug.cgi?id=80629
1028
1029         Reviewed by James Robinson.
1030
1031         Covered by existing canvas tests, and manual testing (killing the GPU
1032         process).
1033
1034         * src/WebViewImpl.cpp:
1035         (WebKit::WebViewImpl::sharedGraphicsContext3D):
1036
1037 2012-03-12  Nat Duca  <nduca@chromium.org>
1038
1039         [Chromium] Force compositeAndReadback through regular scheduling flow
1040         https://bugs.webkit.org/show_bug.cgi?id=77049
1041
1042         Reviewed by James Robinson.
1043
1044         * tests/CCFrameRateControllerTest.cpp:
1045         (WebKitTests::FakeCCFrameRateControllerClient::reset):
1046         (WebKitTests::FakeCCFrameRateControllerClient::vsyncTicked):
1047         (WebKitTests::FakeCCFrameRateControllerClient::vsyncTick):
1048         (FakeCCFrameRateControllerClient):
1049         (WebKitTests::TEST):
1050         * tests/CCLayerTreeHostTest.cpp:
1051         (WTF):
1052         (CCLayerTreeHostTestCompositeAndReadbackWhileInvisible):
1053         (WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible):
1054         (WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::beginTest):
1055         (WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::didCommitAndDrawFrame):
1056         (WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::afterTest):
1057         (WTF::TEST_F):
1058         * tests/CCSchedulerStateMachineTest.cpp:
1059         (WebCore::StateMachine::setNeedsForcedCommit):
1060         (WebCore::StateMachine::needsForcedCommit):
1061         (StateMachine):
1062         (WebCore::TEST):
1063         (WebCore):
1064
1065 2012-03-12  Joshua Bell  <jsbell@chromium.org>
1066
1067         IndexedDB: Handle LevelDB database corruption
1068         https://bugs.webkit.org/show_bug.cgi?id=79413
1069
1070         Reviewed by Tony Chang.
1071
1072         * WebKit.gyp: Skip LevelDBTest.cpp in shared component builds due to webkit_support dependency
1073         * WebKit.gypi: Add LevelDBTest.cpp
1074         * tests/LevelDBTest.cpp: Added.
1075         (WebCore):
1076         (SimpleComparator):
1077         (WebCore::SimpleComparator::compare):
1078         (WebCore::SimpleComparator::name):
1079         (WebCore::encodeString):
1080         (WebCore::TEST):
1081
1082 2012-03-12  Dana Jansens  <danakj@chromium.org>
1083
1084         [chromium] Clean up culling tests and templatize to test impl constructs
1085         https://bugs.webkit.org/show_bug.cgi?id=80613
1086
1087         Reviewed by Adrienne Walker.
1088
1089         * tests/CCOcclusionTrackerTest.cpp:
1090         (WebCore::TestContentLayerChromium::TestContentLayerChromium):
1091         (WebCore::TestContentLayerChromium::opaqueContentsRegion):
1092         (WebCore::TestContentLayerChromium::setOpaqueContentsRect):
1093         (TestContentLayerChromium):
1094         (TestContentLayerImpl):
1095         (WebCore::TestContentLayerImpl::TestContentLayerImpl):
1096         (WebCore::TestContentLayerImpl::opaqueContentsRegion):
1097         (WebCore::TestContentLayerImpl::setOpaqueContentsRect):
1098         (WebCore):
1099         (WebCore::TestCCOcclusionTrackerBase::TestCCOcclusionTrackerBase):
1100         (WebCore::TestCCOcclusionTrackerBase::occlusionInScreenSpace):
1101         (WebCore::TestCCOcclusionTrackerBase::occlusionInTargetSurface):
1102         (WebCore::TestCCOcclusionTrackerBase::setOcclusionInScreenSpace):
1103         (WebCore::TestCCOcclusionTrackerBase::setOcclusionInTargetSurface):
1104         (WebCore::TestCCOcclusionTrackerBase::layerScissorRectInTargetSurface):
1105         (WebCore::TestDamageClient::damageRect):
1106         (CCOcclusionTrackerTestMainThreadTypes):
1107         (WebCore::CCOcclusionTrackerTestMainThreadTypes::createLayer):
1108         (WebCore::CCOcclusionTrackerTestMainThreadTypes::createContentLayer):
1109         (CCOcclusionTrackerTestImplThreadTypes):
1110         (WebCore::CCOcclusionTrackerTestImplThreadTypes::createLayer):
1111         (WebCore::CCOcclusionTrackerTestImplThreadTypes::createContentLayer):
1112         (CCOcclusionTrackerTest):
1113         (WebCore::CCOcclusionTrackerTest::TearDown):
1114         (WebCore::CCOcclusionTrackerTest::createRoot):
1115         (WebCore::CCOcclusionTrackerTest::createLayer):
1116         (WebCore::CCOcclusionTrackerTest::createSurface):
1117         (WebCore::CCOcclusionTrackerTest::createDrawingLayer):
1118         (WebCore::CCOcclusionTrackerTest::createDrawingSurface):
1119         (WebCore::CCOcclusionTrackerTest::calcDrawEtc):
1120         (WebCore::CCOcclusionTrackerTest::setBaseProperties):
1121         (WebCore::CCOcclusionTrackerTest::setProperties):
1122         (CCOcclusionTrackerTestIdentityTransforms):
1123         (WebCore::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
1124         (CCOcclusionTrackerTestRotatedChild):
1125         (WebCore::CCOcclusionTrackerTestRotatedChild::runMyTest):
1126         (CCOcclusionTrackerTestTranslatedChild):
1127         (WebCore::CCOcclusionTrackerTestTranslatedChild::runMyTest):
1128         (CCOcclusionTrackerTestChildInRotatedChild):
1129         (WebCore::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
1130         (CCOcclusionTrackerTestVisitTargetTwoTimes):
1131         (WebCore::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
1132         (CCOcclusionTrackerTestSurfaceRotatedOffAxis):
1133         (WebCore::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
1134         (CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren):
1135         (WebCore::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
1136         (CCOcclusionTrackerTestOverlappingSurfaceSiblings):
1137         (WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
1138         (CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms):
1139         (WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
1140         (CCOcclusionTrackerTestFilters):
1141         (WebCore::CCOcclusionTrackerTestFilters::runMyTest):
1142         (CCOcclusionTrackerTestLayerScissorRectOutsideChild):
1143         (WebCore::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
1144         (CCOcclusionTrackerTestScreenScissorRectOutsideChild):
1145         (WebCore::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
1146         (CCOcclusionTrackerTestDamageRectOutsideChild):
1147         (WebCore::CCOcclusionTrackerTestDamageRectOutsideChild::runMyTest):
1148         (CCOcclusionTrackerTestLayerScissorRectOverChild):
1149         (WebCore::CCOcclusionTrackerTestLayerScissorRectOverChild::runMyTest):
1150         (CCOcclusionTrackerTestScreenScissorRectOverChild):
1151         (WebCore::CCOcclusionTrackerTestScreenScissorRectOverChild::runMyTest):
1152         (CCOcclusionTrackerTestDamageRectOverChild):
1153         (WebCore::CCOcclusionTrackerTestDamageRectOverChild::runMyTest):
1154         (CCOcclusionTrackerTestLayerScissorRectPartlyOverChild):
1155         (WebCore::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
1156         (CCOcclusionTrackerTestScreenScissorRectPartlyOverChild):
1157         (WebCore::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
1158         (CCOcclusionTrackerTestDamageRectPartlyOverChild):
1159         (WebCore::CCOcclusionTrackerTestDamageRectPartlyOverChild::runMyTest):
1160         (CCOcclusionTrackerTestLayerScissorRectOverNothing):
1161         (WebCore::CCOcclusionTrackerTestLayerScissorRectOverNothing::runMyTest):
1162         (CCOcclusionTrackerTestScreenScissorRectOverNothing):
1163         (WebCore::CCOcclusionTrackerTestScreenScissorRectOverNothing::runMyTest):
1164         (CCOcclusionTrackerTestDamageRectOverNothing):
1165         (WebCore::CCOcclusionTrackerTestDamageRectOverNothing::runMyTest):
1166         (CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin):
1167         (WebCore::CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin::runMyTest):
1168         (CCOcclusionTrackerTestOpaqueContentsRegionEmpty):
1169         (WebCore::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
1170         (CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty):
1171         (WebCore::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):
1172
1173 2012-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
1174
1175         Unreviewed, rolling out r110359.
1176         http://trac.webkit.org/changeset/110359
1177         https://bugs.webkit.org/show_bug.cgi?id=80799
1178
1179         SelectPopupMenuTest.ClickItem failure (Requested by ukai on
1180         #webkit).
1181
1182         * src/WebViewImpl.cpp:
1183         (WebKit::WebViewImpl::gestureEvent):
1184         (WebKit::WebViewImpl::applyAutofillSuggestions):
1185
1186 2012-03-11  Pavel Feldman  <pfeldman@chromium.org>
1187
1188         Web Inspector: [chromium] add provisional test for the downstream sanity test.
1189         https://bugs.webkit.org/show_bug.cgi?id=80784
1190
1191         Reviewed by Yury Semikhatsky.
1192
1193         * src/js/Tests.js:
1194         (.TestSuite.prototype.checkLogAndErrorMessages.validMessage):
1195         (.TestSuite.prototype.checkLogAndErrorMessages.onConsoleMessage):
1196         (.TestSuite.prototype.checkLogAndErrorMessages):
1197
1198 2012-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1199
1200         Unreviewed, rolling out r110384.
1201         http://trac.webkit.org/changeset/110384
1202         https://bugs.webkit.org/show_bug.cgi?id=80774
1203
1204         compile failed on Chromium Win Release (Requested by ukai_home
1205         on #webkit).
1206
1207         * tests/CCOcclusionTrackerTest.cpp:
1208         (WebCore::LayerChromiumWithForcedDrawsContent::LayerChromiumWithForcedDrawsContent):
1209         (WebCore::LayerChromiumWithForcedDrawsContent::opaqueContentsRegion):
1210         (WebCore::LayerChromiumWithForcedDrawsContent::setOpaquePaintRect):
1211         (LayerChromiumWithForcedDrawsContent):
1212         (WebCore::setLayerPropertiesForTesting):
1213         (WebCore):
1214         (WebCore::TestCCOcclusionTracker::TestCCOcclusionTracker):
1215         (WebCore::TestCCOcclusionTracker::occlusionInScreenSpace):
1216         (WebCore::TestCCOcclusionTracker::occlusionInTargetSurface):
1217         (WebCore::TestCCOcclusionTracker::setOcclusionInScreenSpace):
1218         (WebCore::TestCCOcclusionTracker::setOcclusionInTargetSurface):
1219         (WebCore::TestCCOcclusionTracker::layerScissorRectInTargetSurface):
1220         (WebCore::TestDamageClient::damageRect):
1221         (WebCore::layerAddedToOccludedRegion):
1222         (WebCore::layerAddedToOccludedRegionWithRotation):
1223         (WebCore::layerAddedToOccludedRegionWithTranslation):
1224         (WebCore::layerAddedToOccludedRegionWithRotatedSurface):
1225         (WebCore::layerAddedToOccludedRegionWithSurfaceAlreadyOnStack):
1226         (WebCore::layerAddedToOccludedRegionWithRotatedOffAxisSurface):
1227         (WebCore::layerAddedToOccludedRegionWithMultipleOpaqueLayers):
1228         (WebCore::surfaceOcclusionWithOverlappingSiblingSurfaces):
1229         (WebCore::surfaceOcclusionInScreenSpace):
1230         (WebCore::surfaceOcclusionInScreenSpaceDifferentTransforms):
1231         (WebCore::occlusionInteractionWithFilters):
1232         (WebCore::layerScissorRectOverTile):
1233         (WebCore::screenScissorRectOverTile):
1234         (WebCore::layerScissorRectOverCulledTile):
1235         (WebCore::screenScissorRectOverCulledTile):
1236         (WebCore::layerScissorRectOverPartialTiles):
1237         (WebCore::screenScissorRectOverPartialTiles):
1238         (WebCore::layerScissorRectOverNoTiles):
1239         (WebCore::screenScissorRectOverNoTiles):
1240         (WebCore::layerScissorRectForLayerOffOrigin):
1241         (WebCore::damageRectOverTile):
1242         (WebCore::damageRectOverCulledTile):
1243         (WebCore::damageRectOverPartialTiles):
1244         (WebCore::damageRectOverNoTiles):
1245         (WebCore::TEST):
1246
1247 2012-03-10  Dana Jansens  <danakj@chromium.org>
1248
1249         [chromium] Clean up culling tests and templatize to test impl constructs
1250         https://bugs.webkit.org/show_bug.cgi?id=80613
1251
1252         Reviewed by Adrienne Walker.
1253
1254         * tests/CCOcclusionTrackerTest.cpp:
1255         (WebCore::TestContentLayerChromium::TestContentLayerChromium):
1256         (WebCore::TestContentLayerChromium::opaqueContentsRegion):
1257         (WebCore::TestContentLayerChromium::setOpaqueContentsRect):
1258         (TestContentLayerChromium):
1259         (TestContentLayerImpl):
1260         (WebCore::TestContentLayerImpl::TestContentLayerImpl):
1261         (WebCore::TestContentLayerImpl::opaqueContentsRegion):
1262         (WebCore::TestContentLayerImpl::setOpaqueContentsRect):
1263         (WebCore):
1264         (WebCore::TestCCOcclusionTrackerBase::TestCCOcclusionTrackerBase):
1265         (WebCore::TestCCOcclusionTrackerBase::occlusionInScreenSpace):
1266         (WebCore::TestCCOcclusionTrackerBase::occlusionInTargetSurface):
1267         (WebCore::TestCCOcclusionTrackerBase::setOcclusionInScreenSpace):
1268         (WebCore::TestCCOcclusionTrackerBase::setOcclusionInTargetSurface):
1269         (WebCore::TestCCOcclusionTrackerBase::layerScissorRectInTargetSurface):
1270         (WebCore::TestDamageClient::damageRect):
1271         (CCOcclusionTrackerTestMainThreadTypes):
1272         (WebCore::CCOcclusionTrackerTestMainThreadTypes::createLayer):
1273         (WebCore::CCOcclusionTrackerTestMainThreadTypes::createContentLayer):
1274         (CCOcclusionTrackerTestImplThreadTypes):
1275         (WebCore::CCOcclusionTrackerTestImplThreadTypes::createLayer):
1276         (WebCore::CCOcclusionTrackerTestImplThreadTypes::createContentLayer):
1277         (CCOcclusionTrackerTest):
1278         (WebCore::CCOcclusionTrackerTest::TearDown):
1279         (WebCore::CCOcclusionTrackerTest::createRoot):
1280         (WebCore::CCOcclusionTrackerTest::createLayer):
1281         (WebCore::CCOcclusionTrackerTest::createSurface):
1282         (WebCore::CCOcclusionTrackerTest::createDrawingLayer):
1283         (WebCore::CCOcclusionTrackerTest::createDrawingSurface):
1284         (WebCore::CCOcclusionTrackerTest::calcDrawEtc):
1285         (WebCore::CCOcclusionTrackerTest::setBaseProperties):
1286         (WebCore::CCOcclusionTrackerTest::setProperties):
1287         (CCOcclusionTrackerTestIdentityTransforms):
1288         (WebCore::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
1289         (CCOcclusionTrackerTestRotatedChild):
1290         (WebCore::CCOcclusionTrackerTestRotatedChild::runMyTest):
1291         (CCOcclusionTrackerTestTranslatedChild):
1292         (WebCore::CCOcclusionTrackerTestTranslatedChild::runMyTest):
1293         (CCOcclusionTrackerTestChildInRotatedChild):
1294         (WebCore::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
1295         (CCOcclusionTrackerTestVisitTargetTwoTimes):
1296         (WebCore::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
1297         (CCOcclusionTrackerTestSurfaceRotatedOffAxis):
1298         (WebCore::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
1299         (CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren):
1300         (WebCore::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
1301         (CCOcclusionTrackerTestOverlappingSurfaceSiblings):
1302         (WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
1303         (CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms):
1304         (WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
1305         (CCOcclusionTrackerTestFilters):
1306         (WebCore::CCOcclusionTrackerTestFilters::runMyTest):
1307         (CCOcclusionTrackerTestLayerScissorRectOutsideChild):
1308         (WebCore::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
1309         (CCOcclusionTrackerTestScreenScissorRectOutsideChild):
1310         (WebCore::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
1311         (CCOcclusionTrackerTestDamageRectOutsideChild):
1312         (WebCore::CCOcclusionTrackerTestDamageRectOutsideChild::runMyTest):
1313         (CCOcclusionTrackerTestLayerScissorRectOverChild):
1314         (WebCore::CCOcclusionTrackerTestLayerScissorRectOverChild::runMyTest):
1315         (CCOcclusionTrackerTestScreenScissorRectOverChild):
1316         (WebCore::CCOcclusionTrackerTestScreenScissorRectOverChild::runMyTest):
1317         (CCOcclusionTrackerTestDamageRectOverChild):
1318         (WebCore::CCOcclusionTrackerTestDamageRectOverChild::runMyTest):
1319         (CCOcclusionTrackerTestLayerScissorRectPartlyOverChild):
1320         (WebCore::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
1321         (CCOcclusionTrackerTestScreenScissorRectPartlyOverChild):
1322         (WebCore::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
1323         (CCOcclusionTrackerTestDamageRectPartlyOverChild):
1324         (WebCore::CCOcclusionTrackerTestDamageRectPartlyOverChild::runMyTest):
1325         (CCOcclusionTrackerTestLayerScissorRectOverNothing):
1326         (WebCore::CCOcclusionTrackerTestLayerScissorRectOverNothing::runMyTest):
1327         (CCOcclusionTrackerTestScreenScissorRectOverNothing):
1328         (WebCore::CCOcclusionTrackerTestScreenScissorRectOverNothing::runMyTest):
1329         (CCOcclusionTrackerTestDamageRectOverNothing):
1330         (WebCore::CCOcclusionTrackerTestDamageRectOverNothing::runMyTest):
1331         (CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin):
1332         (WebCore::CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin::runMyTest):
1333         (CCOcclusionTrackerTestOpaqueContentsRegionEmpty):
1334         (WebCore::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
1335         (CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty):
1336         (WebCore::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):
1337
1338 2012-03-09  Jon Lee  <jonlee@apple.com>
1339
1340         Rename NotificationPresenter to NotificationClient
1341         https://bugs.webkit.org/show_bug.cgi?id=80488
1342         <rdar://problem/10965558>
1343
1344         Reviewed by Kentaro Hara.
1345
1346         Refactor to use renamed WebCore::NotificationClient.
1347         * src/AssertMatchingEnums.cpp:
1348         * src/NotificationPresenterImpl.cpp:
1349         (WebKit::NotificationPresenterImpl::checkPermission):
1350         * src/NotificationPresenterImpl.h:
1351         (NotificationPresenterImpl):
1352
1353 2012-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1354
1355         Unreviewed, rolling out r110363.
1356         http://trac.webkit.org/changeset/110363
1357         https://bugs.webkit.org/show_bug.cgi?id=80757
1358
1359         link error in chromium: unresolved external symbol
1360         webkit_support::CreateScopedTempDirectory(void) (Requested by
1361         ukai_home on #webkit).
1362
1363         * WebKit.gypi:
1364         * tests/LevelDBTest.cpp: Removed.
1365
1366 2012-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1367
1368         Unreviewed, rolling out r110353.
1369         http://trac.webkit.org/changeset/110353
1370         https://bugs.webkit.org/show_bug.cgi?id=80752
1371
1372         copmile failed on Chromium (Requested by ukai_home on
1373         #webkit).
1374
1375         * tests/CCOcclusionTrackerTest.cpp:
1376         (WebCore::LayerChromiumWithForcedDrawsContent::LayerChromiumWithForcedDrawsContent):
1377         (WebCore::LayerChromiumWithForcedDrawsContent::opaqueContentsRegion):
1378         (WebCore::LayerChromiumWithForcedDrawsContent::setOpaquePaintRect):
1379         (LayerChromiumWithForcedDrawsContent):
1380         (WebCore::setLayerPropertiesForTesting):
1381         (WebCore):
1382         (WebCore::TestCCOcclusionTracker::TestCCOcclusionTracker):
1383         (WebCore::TestCCOcclusionTracker::occlusionInScreenSpace):
1384         (WebCore::TestCCOcclusionTracker::occlusionInTargetSurface):
1385         (WebCore::TestCCOcclusionTracker::setOcclusionInScreenSpace):
1386         (WebCore::TestCCOcclusionTracker::setOcclusionInTargetSurface):
1387         (WebCore::TestCCOcclusionTracker::layerScissorRectInTargetSurface):
1388         (WebCore::TestDamageClient::damageRect):
1389         (WebCore::layerAddedToOccludedRegion):
1390         (WebCore::layerAddedToOccludedRegionWithRotation):
1391         (WebCore::layerAddedToOccludedRegionWithTranslation):
1392         (WebCore::layerAddedToOccludedRegionWithRotatedSurface):
1393         (WebCore::layerAddedToOccludedRegionWithSurfaceAlreadyOnStack):
1394         (WebCore::layerAddedToOccludedRegionWithRotatedOffAxisSurface):
1395         (WebCore::layerAddedToOccludedRegionWithMultipleOpaqueLayers):
1396         (WebCore::surfaceOcclusionWithOverlappingSiblingSurfaces):
1397         (WebCore::surfaceOcclusionInScreenSpace):
1398         (WebCore::surfaceOcclusionInScreenSpaceDifferentTransforms):
1399         (WebCore::occlusionInteractionWithFilters):
1400         (WebCore::layerScissorRectOverTile):
1401         (WebCore::screenScissorRectOverTile):
1402         (WebCore::layerScissorRectOverCulledTile):
1403         (WebCore::screenScissorRectOverCulledTile):
1404         (WebCore::layerScissorRectOverPartialTiles):
1405         (WebCore::screenScissorRectOverPartialTiles):
1406         (WebCore::layerScissorRectOverNoTiles):
1407         (WebCore::screenScissorRectOverNoTiles):
1408         (WebCore::layerScissorRectForLayerOffOrigin):
1409         (WebCore::damageRectOverTile):
1410         (WebCore::damageRectOverCulledTile):
1411         (WebCore::damageRectOverPartialTiles):
1412         (WebCore::damageRectOverNoTiles):
1413         (WebCore::TEST):
1414
1415 2012-03-09  Robert Kroeger  <rjkroege@chromium.org>
1416
1417         Handle more Gesture* events by performing scrolls on the correct target ScrollableArea 
1418         https://bugs.webkit.org/show_bug.cgi?id=80311
1419
1420         Added a unit test for the changes to ScrollAnimatorNone to make sure that the two-call
1421         transport of fling parameters is correctly delivered.
1422
1423         Reviewed by James Robinson.
1424
1425         * tests/ScrollAnimatorNoneTest.cpp:
1426         (MockScrollAnimatorNone):
1427         (MockScrollAnimatorNone::reset):
1428         (MockScrollAnimatorNone::fireUpAnAnimation):
1429         (TEST):
1430
1431 2012-03-07  James Robinson  <jamesr@chromium.org>
1432
1433         [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
1434         https://bugs.webkit.org/show_bug.cgi?id=80523
1435
1436         Reviewed by Darin Fisher.
1437
1438         * public/WebViewClient.h:
1439         (WebViewClient):
1440         (WebKit::WebViewClient::createGraphicsContext3D):
1441         * public/platform/WebKitPlatformSupport.h:
1442         (WebKit):
1443         * src/WebViewImpl.cpp:
1444         (WebKit::WebViewImpl::createCompositorGraphicsContext3D):
1445
1446 2012-03-09  Joshua Bell  <jsbell@chromium.org>
1447
1448         IndexedDB: Handle LevelDB database corruption
1449         https://bugs.webkit.org/show_bug.cgi?id=79413
1450
1451         Reviewed by Tony Chang.
1452
1453         * WebKit.gypi:
1454         * tests/LevelDBTest.cpp: Added.
1455         (WebCore):
1456         (SimpleComparator):
1457         (WebCore::SimpleComparator::compare):
1458         (WebCore::SimpleComparator::name):
1459         (WebCore::encodeString):
1460         (WebCore::TEST):
1461
1462 2012-03-09  Tim Dresser  <tdresser@chromium.org>
1463
1464         [chromium] Increase size of Combo Box Options for touch and high DPI devices
1465         https://bugs.webkit.org/show_bug.cgi?id=80027
1466
1467         Reviewed by Darin Fisher.
1468
1469         * src/WebViewImpl.cpp:
1470         (WebKit::WebViewImpl::gestureEvent):
1471         (WebKit::WebViewImpl::applyAutofillSuggestions):
1472
1473 2012-03-09  James Robinson  <jamesr@chromium.org>
1474
1475         [chromium] Roll chromium DEPS to r125600
1476         https://bugs.webkit.org/show_bug.cgi?id=80722
1477
1478         Unreviewed
1479
1480         * DEPS:
1481
1482 2012-03-09  Dana Jansens  <danakj@chromium.org>
1483
1484         [chromium] Clean up culling tests and templatize to test impl constructs
1485         https://bugs.webkit.org/show_bug.cgi?id=80613
1486
1487         Reviewed by Adrienne Walker.
1488
1489         * tests/CCOcclusionTrackerTest.cpp:
1490         (WebCore::TestContentLayerChromium::TestContentLayerChromium):
1491         (WebCore::TestContentLayerChromium::opaqueContentsRegion):
1492         (WebCore::TestContentLayerChromium::setOpaqueContentsRect):
1493         (TestContentLayerChromium):
1494         (TestContentLayerImpl):
1495         (WebCore::TestContentLayerImpl::TestContentLayerImpl):
1496         (WebCore::TestContentLayerImpl::opaqueContentsRegion):
1497         (WebCore::TestContentLayerImpl::setOpaqueContentsRect):
1498         (WebCore):
1499         (WebCore::TestCCOcclusionTrackerBase::TestCCOcclusionTrackerBase):
1500         (WebCore::TestCCOcclusionTrackerBase::occlusionInScreenSpace):
1501         (WebCore::TestCCOcclusionTrackerBase::occlusionInTargetSurface):
1502         (WebCore::TestCCOcclusionTrackerBase::setOcclusionInScreenSpace):
1503         (WebCore::TestCCOcclusionTrackerBase::setOcclusionInTargetSurface):
1504         (WebCore::TestCCOcclusionTrackerBase::layerScissorRectInTargetSurface):
1505         (WebCore::TestDamageClient::damageRect):
1506         (CCOcclusionTrackerTestMainThreadTypes):
1507         (WebCore::CCOcclusionTrackerTestMainThreadTypes::createLayer):
1508         (WebCore::CCOcclusionTrackerTestMainThreadTypes::createContentLayer):
1509         (CCOcclusionTrackerTestImplThreadTypes):
1510         (WebCore::CCOcclusionTrackerTestImplThreadTypes::createLayer):
1511         (WebCore::CCOcclusionTrackerTestImplThreadTypes::createContentLayer):
1512         (CCOcclusionTrackerTest):
1513         (WebCore::CCOcclusionTrackerTest::TearDown):
1514         (WebCore::CCOcclusionTrackerTest::createRoot):
1515         (WebCore::CCOcclusionTrackerTest::createLayer):
1516         (WebCore::CCOcclusionTrackerTest::createSurface):
1517         (WebCore::CCOcclusionTrackerTest::createDrawingLayer):
1518         (WebCore::CCOcclusionTrackerTest::createDrawingSurface):
1519         (WebCore::CCOcclusionTrackerTest::calcDrawEtc):
1520         (WebCore::CCOcclusionTrackerTest::setBaseProperties):
1521         (WebCore::CCOcclusionTrackerTest::setProperties):
1522         (CCOcclusionTrackerTestIdentityTransforms):
1523         (WebCore::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
1524         (CCOcclusionTrackerTestRotatedChild):
1525         (WebCore::CCOcclusionTrackerTestRotatedChild::runMyTest):
1526         (CCOcclusionTrackerTestTranslatedChild):
1527         (WebCore::CCOcclusionTrackerTestTranslatedChild::runMyTest):
1528         (CCOcclusionTrackerTestChildInRotatedChild):
1529         (WebCore::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
1530         (CCOcclusionTrackerTestVisitTargetTwoTimes):
1531         (WebCore::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
1532         (CCOcclusionTrackerTestSurfaceRotatedOffAxis):
1533         (WebCore::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
1534         (CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren):
1535         (WebCore::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
1536         (CCOcclusionTrackerTestOverlappingSurfaceSiblings):
1537         (WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
1538         (CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms):
1539         (WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
1540         (CCOcclusionTrackerTestFilters):
1541         (WebCore::CCOcclusionTrackerTestFilters::runMyTest):
1542         (CCOcclusionTrackerTestLayerScissorRectOutsideChild):
1543         (WebCore::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
1544         (CCOcclusionTrackerTestScreenScissorRectOutsideChild):
1545         (WebCore::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
1546         (CCOcclusionTrackerTestDamageRectOutsideChild):
1547         (WebCore::CCOcclusionTrackerTestDamageRectOutsideChild::runMyTest):
1548         (CCOcclusionTrackerTestLayerScissorRectOverChild):
1549         (WebCore::CCOcclusionTrackerTestLayerScissorRectOverChild::runMyTest):
1550         (CCOcclusionTrackerTestScreenScissorRectOverChild):
1551         (WebCore::CCOcclusionTrackerTestScreenScissorRectOverChild::runMyTest):
1552         (CCOcclusionTrackerTestDamageRectOverChild):
1553         (WebCore::CCOcclusionTrackerTestDamageRectOverChild::runMyTest):
1554         (CCOcclusionTrackerTestLayerScissorRectPartlyOverChild):
1555         (WebCore::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
1556         (CCOcclusionTrackerTestScreenScissorRectPartlyOverChild):
1557         (WebCore::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
1558         (CCOcclusionTrackerTestDamageRectPartlyOverChild):
1559         (WebCore::CCOcclusionTrackerTestDamageRectPartlyOverChild::runMyTest):
1560         (CCOcclusionTrackerTestLayerScissorRectOverNothing):
1561         (WebCore::CCOcclusionTrackerTestLayerScissorRectOverNothing::runMyTest):
1562         (CCOcclusionTrackerTestScreenScissorRectOverNothing):
1563         (WebCore::CCOcclusionTrackerTestScreenScissorRectOverNothing::runMyTest):
1564         (CCOcclusionTrackerTestDamageRectOverNothing):
1565         (WebCore::CCOcclusionTrackerTestDamageRectOverNothing::runMyTest):
1566         (CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin):
1567         (WebCore::CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin::runMyTest):
1568         (CCOcclusionTrackerTestOpaqueContentsRegionEmpty):
1569         (WebCore::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
1570         (CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty):
1571         (WebCore::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):
1572
1573 2012-03-09  Emil A Eklund  <eae@chromium.org>
1574
1575         Add roundedPoint to HitTestResult and change platform code to use it
1576         https://bugs.webkit.org/show_bug.cgi?id=80715
1577
1578         Reviewed by James Robinson.
1579
1580         Change ports to use roundedPoint to avoid exposing subpixel types to
1581         platform code.
1582
1583         * src/ChromeClientImpl.cpp:
1584         (WebKit::ChromeClientImpl::mouseDidMoveOverElement):
1585         * src/ContextMenuClientImpl.cpp:
1586         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
1587
1588 2012-03-09  W. James MacLean  <wjmaclean@chromium.org>
1589
1590         [chromium] Implement scroll physics architecture for impl/main thread
1591         https://bugs.webkit.org/show_bug.cgi?id=79827
1592
1593         Reviewed by James Robinson.
1594
1595         * WebKit.gypi:
1596         * tests/PlatformGestureCurveTest.cpp: Added.
1597
1598 2012-03-09  Tien-Ren Chen  <trchen@chromium.org>
1599
1600         [chromium] ScrollbarLayerChromium/CCScrollbarLayerImpl for CC-side scrollbar painting
1601         https://bugs.webkit.org/show_bug.cgi?id=78872
1602
1603         Reviewed by James Robinson.
1604
1605         * WebKit.gypi:
1606         * tests/ScrollbarLayerChromiumTest.cpp: Added.
1607         (WebCore):
1608         (MockScrollbar):
1609         (WebCore::MockScrollbar::x):
1610         (WebCore::MockScrollbar::y):
1611         (WebCore::MockScrollbar::width):
1612         (WebCore::MockScrollbar::height):
1613         (WebCore::MockScrollbar::size):
1614         (WebCore::MockScrollbar::location):
1615         (WebCore::MockScrollbar::parent):
1616         (WebCore::MockScrollbar::root):
1617         (WebCore::MockScrollbar::setFrameRect):
1618         (WebCore::MockScrollbar::frameRect):
1619         (WebCore::MockScrollbar::invalidate):
1620         (WebCore::MockScrollbar::invalidateRect):
1621         (WebCore::MockScrollbar::scrollbarOverlayStyle):
1622         (WebCore::MockScrollbar::getTickmarks):
1623         (WebCore::MockScrollbar::isScrollableAreaActive):
1624         (WebCore::MockScrollbar::isScrollViewScrollbar):
1625         (WebCore::MockScrollbar::convertFromContainingWindow):
1626         (WebCore::MockScrollbar::isCustomScrollbar):
1627         (WebCore::MockScrollbar::orientation):
1628         (WebCore::MockScrollbar::value):
1629         (WebCore::MockScrollbar::currentPos):
1630         (WebCore::MockScrollbar::visibleSize):
1631         (WebCore::MockScrollbar::totalSize):
1632         (WebCore::MockScrollbar::maximum):
1633         (WebCore::MockScrollbar::controlSize):
1634         (WebCore::MockScrollbar::lineStep):
1635         (WebCore::MockScrollbar::pageStep):
1636         (WebCore::MockScrollbar::pressedPart):
1637         (WebCore::MockScrollbar::hoveredPart):
1638         (WebCore::MockScrollbar::styleChanged):
1639         (WebCore::MockScrollbar::enabled):
1640         (WebCore::MockScrollbar::setEnabled):
1641         (WebCore::MockScrollbar::MockScrollbar):
1642         (WebCore::MockScrollbar::~MockScrollbar):
1643         (WebCore::TEST):
1644
1645 2012-03-08  James Robinson  <jamesr@chromium.org>
1646
1647         [chromium] Expose the shared graphics context on WebView so callers can allocate resources on the main thread for the compositor to use
1648         https://bugs.webkit.org/show_bug.cgi?id=80670
1649
1650         Reviewed by Stephen White.
1651
1652         This exposes a context on WebView that is in the compositor's share group and can be used directly from the main
1653         thread. This is useful for content that needs to allocate resources for the compositor to use, but cannot
1654         directly use the compositor's context either because it cannot access the correct thread or because it needs to
1655         initialize in situations where we cannot initialize a compositor (view) context - for instance before the native
1656         window is created.
1657
1658         * public/WebView.h:
1659         (WebView):
1660         * src/WebViewImpl.cpp:
1661         (WebKit::WebViewImpl::sharedGraphicsContext3D):
1662         (WebKit):
1663         * src/WebViewImpl.h:
1664         (WebViewImpl):
1665
1666 2012-03-09  Dana Jansens  <danakj@chromium.org>
1667
1668         [chromium] Use opaque paints in CCOcclusionTracker
1669         https://bugs.webkit.org/show_bug.cgi?id=80173
1670
1671         Reviewed by Adrienne Walker.
1672
1673         * tests/CCOcclusionTrackerTest.cpp:
1674         (WebCore::LayerChromiumWithForcedDrawsContent::opaqueContentsRegion):
1675         (LayerChromiumWithForcedDrawsContent):
1676         (WebCore::LayerChromiumWithForcedDrawsContent::setOpaquePaintRect):
1677         (WebCore::setLayerPropertiesForTesting):
1678         (WebCore):
1679         (WebCore::layerAddedToOccludedRegion):
1680         (WebCore::layerAddedToOccludedRegionWithRotation):
1681         (WebCore::layerAddedToOccludedRegionWithTranslation):
1682         (WebCore::layerAddedToOccludedRegionWithRotatedSurface):
1683         (WebCore::layerAddedToOccludedRegionWithSurfaceAlreadyOnStack):
1684         (WebCore::layerAddedToOccludedRegionWithRotatedOffAxisSurface):
1685         (WebCore::layerAddedToOccludedRegionWithMultipleOpaqueLayers):
1686         (WebCore::surfaceOcclusionWithOverlappingSiblingSurfaces):
1687         (WebCore::surfaceOcclusionInScreenSpace):
1688         (WebCore::surfaceOcclusionInScreenSpaceDifferentTransforms):
1689         (WebCore::occlusionInteractionWithFilters):
1690         (WebCore::layerScissorRectOverTile):
1691         (WebCore::screenScissorRectOverTile):
1692         (WebCore::layerScissorRectOverCulledTile):
1693         (WebCore::screenScissorRectOverCulledTile):
1694         (WebCore::layerScissorRectOverPartialTiles):
1695         (WebCore::screenScissorRectOverPartialTiles):
1696         (WebCore::layerScissorRectOverNoTiles):
1697         (WebCore::screenScissorRectOverNoTiles):
1698         (WebCore::layerScissorRectForLayerOffOrigin):
1699         (WebCore::damageRectOverTile):
1700         (WebCore::damageRectOverCulledTile):
1701         (WebCore::damageRectOverPartialTiles):
1702         (WebCore::damageRectOverNoTiles):
1703         (WebCore::TEST):
1704         * tests/TiledLayerChromiumTest.cpp:
1705         (WTF::TEST):
1706         (WTF):
1707
1708 2012-03-09  Jon Lee  <jonlee@apple.com>
1709
1710         Add support for ENABLE(LEGACY_NOTIFICATIONS)
1711         https://bugs.webkit.org/show_bug.cgi?id=80497
1712
1713         Reviewed by Adam Barth.
1714
1715         Prep for b80472: Update API for Web Notifications
1716         * features.gypi:
1717
1718 2012-03-09  Ian Vollick  <vollick@chromium.org>
1719
1720         [chromium] Ensure we use the correct time when notifying animation started
1721         https://bugs.webkit.org/show_bug.cgi?id=79537
1722
1723         Reviewed by James Robinson
1724
1725         * src/WebCompositorInputHandlerImpl.cpp:
1726         (WebKit::WebCompositorInputHandlerImpl::willDraw):
1727         * src/WebCompositorInputHandlerImpl.h:
1728         (WebCompositorInputHandlerImpl):
1729         * tests/CCLayerTreeHostImplTest.cpp:
1730         (WebKit::CCLayerTreeHostImplTest::postAnimationEventsToMainThreadOnImplThread):
1731         (WebKit::TEST_F):
1732         * tests/CCLayerTreeHostTest.cpp:
1733         (WTF::TestHooks::animateLayers):
1734         (WTF::TestHooks::updateAnimations):
1735         (WTF::MockLayerTreeHostImpl::animateLayers):
1736         (WTF::MockLayerTreeHostClient::updateAnimations):
1737         (WTF::CCLayerTreeHostTestAddAnimation::CCLayerTreeHostTestAddAnimation):
1738         (WTF::CCLayerTreeHostTestAddAnimation::animateLayers):
1739         (WTF::CCLayerTreeHostTestAddAnimation::notifyAnimationStarted):
1740         (CCLayerTreeHostTestAddAnimation):
1741
1742 2012-03-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1743
1744         Unreviewed, rolling out r110191, r110202, and r110279.
1745         http://trac.webkit.org/changeset/110191
1746         http://trac.webkit.org/changeset/110202
1747         http://trac.webkit.org/changeset/110279
1748         https://bugs.webkit.org/show_bug.cgi?id=80694
1749
1750         They broke !ENABLE(INSPECTOR) builds (Requested by Ossy on
1751         #webkit).
1752
1753         * features.gypi:
1754
1755 2012-03-09  Alexander Pavlov  <apavlov@chromium.org>
1756
1757         [chromium] Unreviewed, build fix after r110191
1758
1759         * features.gypi:
1760
1761 2012-03-08  Ian Vollick  <vollick@chromium.org>
1762
1763         [chromium] Ensure that the cc thread animation framework continues to tick when the tab is backgrounded
1764         https://bugs.webkit.org/show_bug.cgi?id=77668
1765
1766         Reviewed by James Robinson.
1767
1768         * tests/CCLayerTreeHostTest.cpp:
1769         (WTF::CCLayerTreeHostTest::postAddInstantAnimationToMainThread):
1770         (CCLayerTreeHostTest):
1771         (WTF::CCLayerTreeHostTest::dispatchAddInstantAnimation):
1772         (WTF::CCLayerTreeHostTest::dispatchAddAnimation):
1773         (WTF::CCLayerTreeHostTestAddAnimation::beginTest):
1774         (WTF):
1775         (CCLayerTreeHostTestTickAnimationWhileBackgrounded):
1776         (WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::CCLayerTreeHostTestTickAnimationWhileBackgrounded):
1777         (WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::beginTest):
1778         (WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::animateLayers):
1779         (WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::afterTest):
1780         (WTF::TEST_F):
1781
1782 2012-03-08  Jeff Timanus  <twiz@chromium.org>
1783
1784         [chromium] Force the Canvas2D GPU texture cache to 0 bytes for backgrounded tabs.
1785         https://bugs.webkit.org/show_bug.cgi?id=79948
1786
1787         Reviewed by Stephen White.
1788
1789         * src/GraphicsContext3DChromium.cpp:
1790         (WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
1791         (WebCore::GraphicsContext3DPrivate::grContext):
1792         (WebCore::GraphicsContext3DPrivate::setVisibilityCHROMIUM):
1793
1794 2012-03-08  Dana Jansens  <danakj@chromium.org>
1795
1796         [chromium] Replace completelyContains with Region::contains()
1797         https://bugs.webkit.org/show_bug.cgi?id=80617
1798
1799         Reviewed by James Robinson.
1800
1801         * tests/CCLayerTestCommon.cpp:
1802         (CCLayerTestCommon):
1803         (CCLayerTestCommon::verifyQuadsExactlyCoverRect):
1804         * tests/CCLayerTestCommon.h:
1805         (CCLayerTestCommon):
1806
1807 2012-03-08  James Robinson  <jamesr@chromium.org>
1808
1809         Use an explicit attribute to signal that a context prefers to use a discrete GPU
1810         https://bugs.webkit.org/show_bug.cgi?id=80639
1811
1812         Reviewed by Stephen White.
1813
1814         * src/GraphicsContext3DChromium.cpp:
1815         (WebCore::GraphicsContext3DPrivate::getContextAttributes):
1816         (WebCore::GraphicsContext3D::create):
1817         * src/WebViewImpl.cpp:
1818         (WebKit::WebViewImpl::createCompositorGraphicsContext3D):
1819
1820 2012-03-08  Scott Byer  <scottbyer@chromium.org>
1821
1822         Have ScrollAnimatorNone use requestAnimationFrame
1823         https://bugs.webkit.org/show_bug.cgi?id=78938
1824
1825         Reviewed by James Robinson.
1826
1827         * src/ScrollbarGroup.h:
1828         (WebCore):
1829         (WebKit::ScrollbarGroup::hostWindow):
1830         (ScrollbarGroup):
1831         * tests/ScrollAnimatorNoneTest.cpp:
1832         (MockScrollableArea::hostWindow):
1833
1834 2012-03-08  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1835
1836         Make elements with attributes smaller by eliminating the m_element back pointer in NamedNodeMap
1837         https://bugs.webkit.org/show_bug.cgi?id=75069
1838
1839         Reviewed by Ryosuke Niwa.
1840
1841         * src/WebElement.cpp: Include NamedNodeMap.h since Element.h doesn't include it anymore.
1842
1843 2012-03-07  Kent Tamura  <tkent@chromium.org>
1844
1845         Remove meaningless code in RenderTextControlSingleLine::preferredContentWidth()
1846         https://bugs.webkit.org/show_bug.cgi?id=80493
1847
1848         Reviewed by Hajime Morita.
1849
1850         * src/WebInputElement.cpp:
1851         RenderTextControlSingleLine::speechButtonElement() is removed. The
1852         following functions get it from HTMLInputElement.
1853         (WebKit::WebInputElement::getSpeechInputState):
1854         (WebKit::WebInputElement::startSpeechInput):
1855         (WebKit::WebInputElement::stopSpeechInput):
1856
1857 2012-03-07  Adam Barth  <abarth@webkit.org>
1858
1859         Remove #define private public from WebCache.cpp
1860         https://bugs.webkit.org/show_bug.cgi?id=80520
1861
1862         Reviewed by Eric Seidel.
1863
1864         This patch removes a hack we added long ago when Chromium used a forked
1865         copy of WebKit and editing WebCore caused merge pain.  Now that we're
1866         on trunk, we can unwind this hack.
1867
1868         * src/WebCache.cpp:
1869         (WebKit::WebCache::getUsageStats):
1870
1871 2012-03-07  Joshua Bell  <jsbell@chromium.org>
1872
1873         [Chromium] IndexedDB: V8LocalContext creation in IDBKey extraction/injection is slow
1874         https://bugs.webkit.org/show_bug.cgi?id=80358
1875
1876         Reviewed by Tony Chang.
1877
1878         * tests/IDBBindingUtilitiesTest.cpp:
1879         (WebCore::TEST):
1880
1881 2012-03-07  Scott Byer  <scottbyer@chromium.org>
1882
1883         Get ScrollAnimatorNone to handle the stop and reverse cases.
1884         https://bugs.webkit.org/show_bug.cgi?id=80455
1885
1886         Reviewed by James Robinson.
1887
1888         * tests/ScrollAnimatorNoneTest.cpp:
1889         (ScrollAnimatorNoneTest::updateDataFromParameters):
1890         (TEST_F):
1891
1892 2012-03-07  Dana Jansens  <danakj@chromium.org>
1893
1894         [chromium] Cull occluded tiles during paint
1895         https://bugs.webkit.org/show_bug.cgi?id=76838
1896
1897         Reviewed by Adrienne Walker.
1898
1899         * tests/CCLayerTreeHostTest.cpp:
1900         (WTF::ContentLayerChromiumWithUpdateTracking::idlePaintContentsIfDirty):
1901         * tests/TiledLayerChromiumTest.cpp:
1902         (WTF::FakeLayerTextureUpdater::Texture::prepareRect):
1903         (WTF::FakeLayerTextureUpdater::FakeLayerTextureUpdater):
1904         (FakeLayerTextureUpdater):
1905         (WTF::FakeLayerTextureUpdater::prepareRectCount):
1906         (WTF::FakeLayerTextureUpdater::clearPrepareRectCount):
1907         (WTF::FakeLayerTextureUpdater::prepareRect):
1908         (WTF::FakeTiledLayerChromium::prepareToUpdate):
1909         (WTF::FakeTiledLayerChromium::prepareToUpdateIdle):
1910         (WTF::FakeTiledLayerChromium::paintContentsIfDirty):
1911         (WTF::TEST):
1912         (WTF):
1913
1914 2012-03-07  Elliot Poger  <epoger@google.com>
1915
1916         [Chromium] Remove use_skia option from GYP
1917         https://bugs.webkit.org/show_bug.cgi?id=75811
1918
1919         Reviewed by Tony Chang.
1920
1921         * WebKit.gyp:
1922         * WebKit.gypi:
1923         * features.gypi:
1924
1925 2012-03-06  Dana Jansens  <danakj@chromium.org>
1926
1927         [chromium] Add clipping to scissor rect to CCOcclusionTracker
1928         https://bugs.webkit.org/show_bug.cgi?id=79927
1929
1930         Reviewed by Adrienne Walker.
1931
1932         * tests/CCOcclusionTrackerTest.cpp:
1933         (WebCore::TestCCOcclusionTracker::TestCCOcclusionTracker):
1934         (TestCCOcclusionTracker):
1935         (WebCore::TestCCOcclusionTracker::setLayerScissorRect):
1936         (WebCore::TestCCOcclusionTracker::useDefaultLayerScissorRect):
1937         (WebCore::TestCCOcclusionTracker::layerScissorRect):
1938         (WebCore):
1939         (TestDamageClient):
1940         (WebCore::TestDamageClient::damageRect):
1941         (WebCore::TestDamageClient::TestDamageClient):
1942         (WebCore::TestDamageClient::setDamageRect):
1943         (WebCore::TEST):
1944
1945 2012-03-06  Kenichi Ishibashi  <bashi@chromium.org>
1946
1947         [WebSocket] Introduce ThreadableWebSocketChannel::SendResult
1948         https://bugs.webkit.org/show_bug.cgi?id=80356
1949
1950         Reviewed by Kent Tamura.
1951
1952         * src/WebSocketImpl.cpp:
1953         (WebKit::WebSocketImpl::sendText): Checks whether the return value of send() is ThreadableWebSocketChannel::SendSuccess.
1954         (WebKit::WebSocketImpl::sendArrayBuffer): Ditto.
1955
1956 2012-03-06  Nat Duca  <nduca@chromium.org>
1957
1958         [chromium] CCThreadProxy context lost support
1959         https://bugs.webkit.org/show_bug.cgi?id=80100
1960
1961         Reviewed by James Robinson.
1962
1963         * tests/CCSchedulerStateMachineTest.cpp:
1964         * tests/CCSchedulerTest.cpp:
1965         (WebKitTests::FakeCCSchedulerClient::scheduledActionBeginContextRecreation):
1966         (WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionBeginContextRecreation):
1967         (WebKitTests::SchedulerClientThatSetNeedsCommitInsideDraw::scheduledActionBeginContextRecreation):
1968
1969 2012-03-06  James Robinson  <jamesr@chromium.org>
1970
1971         [chromium] Null-check m_layerRenderer in CCLayerTreeHostImpl::finishAllRendering()
1972         https://bugs.webkit.org/show_bug.cgi?id=80445
1973
1974         Reviewed by Adrienne Walker.
1975
1976         * tests/CCLayerTreeHostImplTest.cpp:
1977         (FakeWebGraphicsContext3DMakeCurrentFails):
1978         (WebKit::FakeWebGraphicsContext3DMakeCurrentFails::makeContextCurrent):
1979         (WebKit):
1980         (WebKit::TEST_F):
1981
1982 2012-03-06  David Grogan  <dgrogan@chromium.org>
1983
1984         [Chromium] Add OVERRIDEs to WebWorkerClientImpl.h
1985         https://bugs.webkit.org/show_bug.cgi?id=80434
1986
1987         Reviewed by Tony Chang.
1988
1989         Tests: just that it compiles.
1990
1991         * src/WebWorkerClientImpl.h:
1992         (WebWorkerClientImpl):
1993
1994 2012-03-06  David Grogan  <dgrogan@chromium.org>
1995
1996         IndexedDB: Check WebCommonWorkerClient::allowIndexedDB before proceeding from a shared worker
1997         https://bugs.webkit.org/show_bug.cgi?id=79954
1998
1999         Tests: The 'allow' case will be tested once the patch at
2000         http://webkit.org/b/80189 and
2001         https://chromiumcodereview.appspot.com/9585031/ both land. Bug for
2002         testing the 'deny' case is http://crbug.com/113738.
2003
2004         Reviewed by Tony Chang.
2005
2006         * public/WebCommonWorkerClient.h:
2007         (WebKit::WebCommonWorkerClient::allowDatabase):
2008         (WebKit::WebCommonWorkerClient::allowFileSystem):
2009         (WebKit::WebCommonWorkerClient::openFileSystem):
2010         (WebCommonWorkerClient):
2011         (WebKit::WebCommonWorkerClient::allowIndexedDB):
2012         * public/WebSharedWorkerClient.h:
2013         (WebSharedWorkerClient):
2014         * src/IDBFactoryBackendProxy.cpp:
2015         (WebKit::AllowIndexedDBMainThreadBridge::create):
2016         (WebKit::AllowIndexedDBMainThreadBridge::cancel):
2017         (WebKit::AllowIndexedDBMainThreadBridge::signalCompleted):
2018         (WebKit::AllowIndexedDBMainThreadBridge::AllowIndexedDBMainThreadBridge):
2019         (WebKit::AllowIndexedDBMainThreadBridge::allowIndexedDBTask):
2020         (AllowIndexedDBMainThreadBridge):
2021         (WebKit::IDBFactoryBackendProxy::allowIDBFromWorkerThread):
2022         * src/WebWorkerClientImpl.cpp:
2023         (WebKit):
2024         (WebKit::WebWorkerClientImpl::allowIndexedDB):
2025         * src/WebWorkerClientImpl.h:
2026         (WebWorkerClientImpl):
2027
2028 2012-03-06  Stephen White  <senorblanco@chromium.org>
2029
2030         Unreviewed, rolling out r109825.
2031         http://trac.webkit.org/changeset/109825
2032         https://bugs.webkit.org/show_bug.cgi?id=79413
2033
2034         Broke webkit_unit_tests on Chromium Win
2035
2036         * WebKit.gypi:
2037         * tests/LevelDBTest.cpp: Removed.
2038
2039 2012-03-06  Takashi Toyoshima  <toyoshim@chromium.org>
2040
2041         [Chromium] [WebSocket] Add WebSocket extensions query WebKit API
2042         https://bugs.webkit.org/show_bug.cgi?id=80190
2043
2044         Reviewed by Darin Fisher.
2045
2046         * public/WebSocket.h: Add extensions() declaration.
2047         (WebSocket):
2048         * src/WebSocketImpl.cpp: Implement extensions() bridge.
2049         (WebKit::WebSocketImpl::extensions):
2050         (WebKit):
2051         * src/WebSocketImpl.h: Add extensions() declaration.
2052         (WebSocketImpl):
2053
2054 2012-03-05  Kent Tamura  <tkent@chromium.org>
2055
2056         Do not reformat strings in <input type=number> on platforms using LocalizedNumberICU.
2057         https://bugs.webkit.org/show_bug.cgi?id=78326
2058
2059         Reviewed by Hajime Morita.
2060
2061         Add a test for WebCore/platform/text/LocalizedNumberICU.
2062
2063         * WebKit.gypi: Added LocalizedNumberICUTest.cpp
2064         * tests/LocalizedNumberICUTest.cpp: Added.
2065
2066 2012-03-05  Kenneth Russell  <kbr@google.com>
2067
2068         [chromium] Notify CCLayerImpl tree of context loss and restoration
2069         https://bugs.webkit.org/show_bug.cgi?id=80339
2070
2071         Reviewed by James Robinson.
2072
2073         Unit test for notification of context loss and restoration.
2074
2075         * tests/CCLayerTreeHostImplTest.cpp:
2076         (WebKit):
2077         (ContextLostNotificationCheckLayer):
2078         (WebKit::ContextLostNotificationCheckLayer::create):
2079         (WebKit::ContextLostNotificationCheckLayer::didLoseAndRecreateGraphicsContext):
2080         (WebKit::ContextLostNotificationCheckLayer::didLoseAndRecreateGraphicsContextCalled):
2081         (WebKit::ContextLostNotificationCheckLayer::ContextLostNotificationCheckLayer):
2082         (WebKit::TEST_F):
2083
2084 2012-03-05  Changhun Kang  <temoochin@company100.net>
2085
2086         Change the argument orders to match OpenGL's in GraphicsContext3D functions
2087         https://bugs.webkit.org/show_bug.cgi?id=80120
2088
2089         Reviewed by Kenneth Russell.
2090
2091         No new tests because this patch just change the order of arguments.
2092
2093         * src/GraphicsContext3DChromium.cpp:
2094         (WebCore::GraphicsContext3DPrivate::uniform1fv):
2095         (WebCore::GraphicsContext3DPrivate::uniform1iv):
2096         (WebCore::GraphicsContext3DPrivate::uniform2fv):
2097         (WebCore::GraphicsContext3DPrivate::uniform2iv):
2098         (WebCore::GraphicsContext3DPrivate::uniform3fv):
2099         (WebCore::GraphicsContext3DPrivate::uniform3iv):
2100         (WebCore::GraphicsContext3DPrivate::uniform4fv):
2101         (WebCore::GraphicsContext3DPrivate::uniform4iv):
2102         (WebCore::GraphicsContext3DPrivate::uniformMatrix2fv):
2103         (WebCore::GraphicsContext3DPrivate::uniformMatrix3fv):
2104         (WebCore::GraphicsContext3DPrivate::uniformMatrix4fv):
2105         (WebCore):
2106         * src/GraphicsContext3DPrivate.h:
2107         (GraphicsContext3DPrivate):
2108
2109 2012-03-05  Yoshifumi Inoue  <yosin@chromium.org>
2110
2111         [Chromium] WebOptionElement should inherit WebElement instead of WebFormControlElement
2112         https://bugs.webkit.org/show_bug.cgi?id=80089
2113
2114         Change class hierarchy of WebOptionElement to match with specification.
2115
2116         Reviewed by Darin Fisher.
2117
2118         * public/WebOptionElement.h: Replace to WebElement from WebFormControlElement 
2119         (WebKit::WebOptionElement::WebOptionElement):
2120         (WebKit::WebOptionElement::operator=):
2121         (WebKit::WebOptionElement::assign):
2122         * src/WebOptionElement.cpp:
2123         (WebKit::WebOptionElement::WebOptionElement):
2124
2125 2012-03-05  Joshua Bell  <jsbell@chromium.org>
2126
2127         IndexedDB: Handle LevelDB database corruption
2128         https://bugs.webkit.org/show_bug.cgi?id=79413
2129
2130         Reviewed by Tony Chang.
2131
2132         * WebKit.gypi:
2133         * tests/LevelDBTest.cpp: Added.
2134         (WebCore):
2135         (SimpleComparator):
2136         (WebCore::SimpleComparator::compare):
2137         (WebCore::SimpleComparator::name):
2138         (WebCore::encodeString):
2139         (WebCore::TEST):
2140
2141 2012-03-05  Min Qin  <qinmin@google.com>
2142
2143         Enable context menu on android
2144
2145         For android, long press is converted into a right mouse down event
2146         So we will use that to invoke the context menu
2147         https://bugs.webkit.org/show_bug.cgi?id=80332
2148
2149         Reviewed by Adam Barth.
2150
2151         * src/WebViewImpl.cpp:
2152         (WebKit::WebViewImpl::mouseDown):
2153
2154 2012-03-05  Kent Tamura  <tkent@chromium.org>
2155
2156         [Chromium] Add new popup type: PagePopup
2157         https://bugs.webkit.org/show_bug.cgi?id=80106
2158
2159         Reviewed by Darin Fisher.
2160
2161         This is a preparation of implementing ChromeClient::openPagePopup and
2162         closePagePopup.
2163
2164         * WebKit.gyp: Add WebPagePopup.h and WebPagePopupImpl.cpp.
2165         * public/WebPagePopup.h:
2166         (WebPagePopup): Add WebPagePopup interface.
2167         * public/WebPopupType.h: Add WebPopupTypePage.
2168         * src/WebPagePopupImpl.cpp:
2169         (WebKit::WebPagePopup::create): Temprary implementation which just returns 0.
2170
2171 2012-03-05  Charlie Reis  <creis@chromium.org>
2172
2173         [chromium] Pass WebNavigationPolicy to WebViewClient::createView
2174         https://bugs.webkit.org/show_bug.cgi?id=80057
2175
2176         Reviewed by Darin Fisher.
2177
2178         * public/WebViewClient.h:
2179         (WebViewClient):
2180         (WebKit::WebViewClient::createView):
2181         * src/ChromeClientImpl.cpp:
2182         (WebKit::ChromeClientImpl::ChromeClientImpl):
2183         (WebKit::ChromeClientImpl::createWindow):
2184         (WebKit::ChromeClientImpl::getNavigationPolicy):
2185         (WebKit):
2186         (WebKit::ChromeClientImpl::show):
2187         (WebKit::ChromeClientImpl::setNewWindowNavigationPolicy):
2188         * src/ChromeClientImpl.h:
2189         (ChromeClientImpl):
2190         * src/FrameLoaderClientImpl.cpp:
2191         (WebKit::FrameLoaderClientImpl::dispatchCreatePage):
2192         (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNewWindowAction):
2193
2194 2012-03-05  James Robinson  <jamesr@chromium.org>
2195
2196         [chromium] Initialize CCOverdrawCounts struct to zero
2197         https://bugs.webkit.org/show_bug.cgi?id=80204
2198
2199         Reviewed by Adrienne Walker.
2200
2201         Update test to use c'tor instead of {} struct initialization.
2202
2203         * tests/CCQuadCullerTest.cpp:
2204         (WebCore):
2205
2206 2012-03-05  Takashi Toyoshima  <toyoshim@chromium.org>
2207
2208         [Chromium] [WebSocket] use OVERRIDE in WebSocketImpl.h
2209         https://bugs.webkit.org/show_bug.cgi?id=80192
2210
2211         Reviewed by Kent Tamura.
2212
2213         * src/WebSocketImpl.h: use OVERRIDE macro.
2214         (WebSocketImpl):
2215
2216 2012-03-05  Adam Barth  <abarth@webkit.org>
2217
2218         Geolocation should use a ScriptExecutionContext as its context object
2219         https://bugs.webkit.org/show_bug.cgi?id=80248
2220
2221         Reviewed by Kentaro Hara.
2222
2223         Rather than indirecting through the Frame to get the SecurityOrigin, we
2224         should get the SecurityOrigin directly from ScriptExecutionContext.
2225
2226         * src/WebGeolocationPermissionRequest.cpp:
2227         (WebKit::WebGeolocationPermissionRequest::securityOrigin):
2228
2229 2012-03-02  Andrey Kosyakov  <caseq@chromium.org>
2230
2231         Add instrumentation for frame start/end on timeline.
2232
2233         Web Inspector: add timeline instrumentation for frame events
2234         https://bugs.webkit.org/show_bug.cgi?id=80127
2235
2236         Reviewed by Pavel Feldman.
2237
2238         - expose an instrumentation method from WebWidget to mark frame update start
2239
2240         * public/WebWidget.h:
2241         (WebWidget):
2242         (WebKit::WebWidget::instrumentBeginFrame):
2243         * src/WebViewImpl.cpp:
2244         (WebKit::WebViewImpl::instrumentBeginFrame):
2245         (WebKit):
2246         * src/WebViewImpl.h:
2247         (WebViewImpl):
2248
2249 2012-03-03  Benjamin Poulain  <benjamin@webkit.org>
2250
2251         Remove the redundant method KURL::protocolInHTTPFamily()
2252         https://bugs.webkit.org/show_bug.cgi?id=80216
2253
2254         Reviewed by Anders Carlsson.
2255
2256         * src/FrameLoaderClientImpl.cpp:
2257         (WebKit::FrameLoaderClientImpl::dispatchWillPerformClientRedirect):
2258         * src/WebPageSerializer.cpp:
2259         (WebCore::retrieveResourcesForElement):
2260
2261 2012-03-03  Hans Wennborg  <hans@chromium.org>
2262
2263         Implement Speech JavaScript API
2264         https://bugs.webkit.org/show_bug.cgi?id=80019
2265
2266         Reviewed by Adam Barth.
2267
2268         Add ENABLE_SCRIPTED_SPEECH and runtime flag.
2269
2270         * features.gypi:
2271         * public/WebRuntimeFeatures.h:
2272         (WebRuntimeFeatures):
2273         * src/WebRuntimeFeatures.cpp:
2274         (WebKit::WebRuntimeFeatures::enableScriptedSpeech):
2275         (WebKit):
2276         (WebKit::WebRuntimeFeatures::isScriptedSpeechEnabled):
2277
2278 2012-03-03  Bill Budge  <bbudge@chromium.org>
2279
2280         Fixes AssociatedURLLoader support for Access-Control-Expose-Headers field in response.
2281         https://bugs.webkit.org/show_bug.cgi?id=80198
2282
2283         Reviewed by Adam Barth.
2284
2285         * src/AssociatedURLLoader.cpp:
2286         * tests/AssociatedURLLoaderTest.cpp:
2287
2288 2012-03-02  Dana Jansens  <danakj@chromium.org>
2289
2290         [Chromium] Allow plugins to set opaque() on their platform layer
2291         https://bugs.webkit.org/show_bug.cgi?id=80171
2292
2293         Reviewed by James Robinson.
2294
2295         * public/WebPluginContainer.h:
2296         (WebPluginContainer):
2297         * src/WebPluginContainerImpl.cpp:
2298         (WebKit::WebPluginContainerImpl::setOpaque):
2299         (WebKit):
2300         * src/WebPluginContainerImpl.h:
2301         (WebPluginContainerImpl):
2302
2303 2012-03-01  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2304
2305         Make parser code not depend on NamedNodeMap
2306         https://bugs.webkit.org/show_bug.cgi?id=79963
2307
2308         Reviewed by Adam Barth.
2309
2310         * src/WebNamedNodeMap.cpp:
2311         (WebKit::WebNamedNodeMap::attributeItem):
2312
2313 2012-03-01  Dana Jansens  <danakj@chromium.org>
2314
2315         [chromium] Make opaque paint tracker aware of SkCanvas layers
2316         https://bugs.webkit.org/show_bug.cgi?id=79145
2317
2318         Reviewed by Stephen White.
2319
2320         * tests/PlatformContextSkiaTest.cpp:
2321         (WebCore::TEST):
2322         (WebCore):
2323
2324 2012-03-01  Hironori Bono  <hbono@chromium.org>
2325
2326         Render overflow controls of an RTL element to its left-side.
2327         https://bugs.webkit.org/show_bug.cgi?id=54623
2328
2329         This change adds a new flag WTF_USE_RTL_SCROLLBAR and render the
2330         vertical scrollbars and resizers of RTL elements to their left side if
2331         this new flag is enabled.
2332
2333         Reviewed by Ryosuke Niwa.
2334
2335         * features.gypi: Set WTF_USE_RTL_SCROLLBAR to 1 on Chromium.
2336
2337 2012-03-01  James Robinson  <jamesr@chromium.org>
2338
2339         [chromium] Rename LayerChromium::name to debugName to be more consistent with other debug properties, make threadsafe
2340         https://bugs.webkit.org/show_bug.cgi?id=79723
2341
2342         Reviewed by Adrienne Walker.
2343
2344         * tests/LayerChromiumTest.cpp:
2345
2346 2012-03-01  Dale Curtis  <dalecurtis@chromium.org>
2347
2348         Remove deprecated FFmpeg build directories.
2349         https://bugs.webkit.org/show_bug.cgi?id=79282
2350
2351         We've switched the layout of the FFmpeg repo in Chrome and these paths
2352         are no longer needed or valid.
2353
2354         Reviewed by Dirk Pranke.
2355
2356         * DEPS:
2357
2358 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
2359
2360         Roll chromium DEPS to 124511
2361
2362         Unreviewed, DEPS change.
2363
2364         * DEPS:
2365
2366 2012-02-29  Nat Duca  <nduca@chromium.org>
2367
2368         [chromium] Move context lost control code from CCSingleThreadProxy to CCLayerTreeHost
2369         https://bugs.webkit.org/show_bug.cgi?id=79964
2370
2371         Reviewed by James Robinson.
2372
2373         * src/WebLayerTreeView.cpp:
2374         (WebKit::WebLayerTreeView::loseCompositorContext):
2375         * src/WebLayerTreeViewImpl.cpp:
2376         (WebKit::WebLayerTreeViewImpl::createContext):
2377         (WebKit::WebLayerTreeViewImpl::didRecreateContext):
2378         * src/WebLayerTreeViewImpl.h:
2379         (WebLayerTreeViewImpl):
2380         * tests/CCLayerTreeHostTest.cpp:
2381         (WTF::MockLayerTreeHostClient::createContext):
2382         (WTF::MockLayerTreeHostClient::didRecreateContext):
2383         * tests/FakeCCLayerTreeHostClient.h:
2384         (WebCore::FakeCCLayerTreeHostClient::createContext):
2385         (WebCore::FakeCCLayerTreeHostClient::didRecreateContext):
2386
2387 2012-03-01  Kentaro Hara  <haraken@chromium.org>
2388
2389         REGRESSION(r109288): WebViewImpl::enableAutoResizeMode loops infinitely
2390         https://bugs.webkit.org/show_bug.cgi?id=77452
2391
2392         Reviewed by Hajime Morita.
2393
2394         WebViewImpl::enableAutoResizeMode loops infinitely.
2395         This patch fixes the following line:
2396
2397             enableAutoResizeMode(enable, minSize, maxSize);
2398
2399         to
2400             enableAutoResizeMode(minSize, maxSize);
2401
2402         to avoid the infinite loop. I guess this is the change originally intended.
2403
2404         Test: webkit_unit_tests.WebViewTest.AutoResizeMinimumSize
2405
2406         * src/WebViewImpl.cpp:
2407         (WebKit::WebViewImpl::enableAutoResizeMode):
2408
2409 2012-02-29  Kinuko Yasuda  <kinuko@chromium.org>
2410
2411         Use the new createSnapshotFileAndReadMetadata API for FileEntry.file()
2412         https://bugs.webkit.org/show_bug.cgi?id=79928
2413
2414         Reviewed by David Levin.
2415
2416         In the new flow we first create an internal Blob URL for the
2417         snapshot file and call the new createSnapshotFileAndReadMetadata()
2418         WebKit API with the Blob URL.
2419
2420         The implementor of createSnapshotFileAndReadMetadata() (i.e. chromium)
2421         registers the created snapshot file with the given internal Blob URL.
2422
2423         In the callback chain we call File::createWithName() to create a
2424         new File using the returned platform path, and then call
2425         unregisterBlobURL() to clean up the internal Blob URL.
2426
2427         * src/AsyncFileSystemChromium.cpp:
2428         (WebCore::AsyncFileSystemChromium::createSnapshotFileAndReadMetadata): Added.
2429         (WebCore::AsyncFileSystemChromium::createSnapshotFileCallback): Added.
2430         * src/AsyncFileSystemChromium.h:
2431         * src/WorkerAsyncFileSystemChromium.cpp:
2432         (WebCore::WorkerAsyncFileSystemChromium::createSnapshotFileAndReadMetadata): Added.
2433         * src/WorkerAsyncFileSystemChromium.h:
2434         * src/WorkerFileSystemCallbacksBridge.cpp:
2435         (WebKit::WorkerFileSystemCallbacksBridge::postCreateSnapshotFileToMainThread): Added.
2436         (WebKit::WorkerFileSystemCallbacksBridge::createSnapshotFileOnMainThread): Added.
2437         * src/WorkerFileSystemCallbacksBridge.h:
2438         (WorkerFileSystemCallbacksBridge):
2439
2440 2012-02-29  Kinuko Yasuda  <kinuko@chromium.org>
2441
2442         Unreviewed.  Rolled DEPS.
2443
2444         * DEPS:
2445
2446 2012-02-29  W. James MacLean  <wjmaclean@chromium.org>
2447
2448         [chromium] Estimate pixel count for frame rate control
2449         https://bugs.webkit.org/show_bug.cgi?id=74982
2450
2451         Reviewed by James Robinson.
2452
2453         Adds mechanism to compute and collect statistics on pixel overdraw for selected frames.
2454
2455         * tests/CCQuadCullerTest.cpp:
2456         (WebCore):
2457         (WebCore::TEST):
2458
2459 2012-02-29  James Simonsen  <simonjam@chromium.org>
2460
2461         [chromium] Fix navigation start time on cross-renderer navigation
2462         https://bugs.webkit.org/show_bug.cgi?id=75922
2463
2464         Reviewed by Darin Fisher.
2465
2466         * public/WebDataSource.h:
2467         * src/WebDataSource.cpp:
2468         (WebKit::WebDataSource::setNavigationStartTime): Added.
2469         * src/WebDataSource.h:
2470
2471 2012-02-29  Ian Vollick  <vollick@chromium.org>
2472
2473         [chromium] Add impl-thread support for animation-timing-function
2474         https://bugs.webkit.org/show_bug.cgi?id=79819
2475
2476         Reviewed by James Robinson.
2477
2478         * tests/CCKeyframedAnimationCurveTest.cpp:
2479         (WebCore::TEST):
2480         (WebCore):
2481
2482 2012-02-29  David Levin  <levin@chromium.org>
2483
2484         [chromium] Add the ability to turn off autoresize.
2485         https://bugs.webkit.org/show_bug.cgi?id=77452
2486
2487         Reviewed by Darin Fisher.
2488
2489         * public/WebView.h:
2490         (WebKit::WebViewImpl::enableAutoResizeMode): Cleaned up the api.
2491         (WebKit::WebViewImpl::disableAutoResizeMode): Added the ability to disable auto-resize.
2492         (WebKit::WebViewImpl::enableAutoResizeMode): Deprecated it.
2493         * src/WebViewImpl.cpp:
2494         (WebKit::WebViewImpl::enableAutoResizeMode): Adjust for new api.
2495         (WebKit::WebViewImpl::disableAutoResizeMode): Allow turning off autoresize.
2496         (WebKit::WebViewImpl::enableAutoResizeMode): Call the other two apis, but
2497         this api will be deleted shortly.
2498         (WebKit::WebViewImpl::configureAutoResizeMode): Common code.
2499         * src/WebViewImpl.h:
2500         (WebViewImpl): Adjust to new public api.
2501
2502 2012-02-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2503
2504         Unreviewed.  Rolled DEPS.
2505
2506         * DEPS:
2507
2508 2012-02-29  Dana Jansens  <danakj@chromium.org>
2509
2510         [chromium] Don't let invalidation for next frame prevent tile upload
2511         https://bugs.webkit.org/show_bug.cgi?id=79841
2512
2513         Reviewed by James Robinson.
2514
2515         * tests/TiledLayerChromiumTest.cpp:
2516         (WTF::TEST):
2517
2518 2012-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2519
2520         Unreviewed, rolling out r107917 and r109188.
2521         http://trac.webkit.org/changeset/107917
2522         http://trac.webkit.org/changeset/109188
2523         https://bugs.webkit.org/show_bug.cgi?id=79865
2524
2525         Fix the chromium build. (Requested by dcheng on #webkit).
2526
2527         * src/WebDragData.cpp:
2528         (WebKit::WebDragData::items):
2529
2530 2012-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2531
2532         Chromium build fix attempt.
2533
2534         * src/WebDragData.cpp:
2535
2536 2012-02-28  Jonathan Backer  <backer@chromium.org>
2537
2538         [chromium] Reset damage tracker on visibility change.
2539         https://bugs.webkit.org/show_bug.cgi?id=79267
2540
2541         Reviewed by James Robinson.
2542
2543         * tests/CCLayerTreeHostImplTest.cpp:
2544         (WebKit::PartialSwapTrackerContext::getString):
2545         (WebKit):
2546         (WebKit::TEST_F):
2547
2548 2012-02-28  Tim Dresser  <tdresser@chromium.org>
2549
2550         Provide DefaultDeviceScaleFactor though WebSettings
2551         https://bugs.webkit.org/show_bug.cgi?id=79534
2552
2553         Reviewed by Darin Fisher.
2554
2555         * public/WebSettings.h:
2556         * src/WebSettingsImpl.cpp:
2557         (WebKit::WebSettingsImpl::setDefaultDeviceScaleFactor):
2558         (WebKit):
2559         * src/WebSettingsImpl.h:
2560         (WebSettingsImpl):
2561
2562 2012-02-28  Gary Kacmarcik  <garykac@chromium.org>
2563
2564         [chromium] Set nativeKeyCode to include Windows scan code
2565         https://bugs.webkit.org/show_bug.cgi?id=79289
2566
2567         Reviewed by Ryosuke Niwa.
2568
2569         Set the key event's nativeKeyCode on Windows Chromium so that it
2570         actually includes the native scancode and other context bits.
2571         Currently on Windows, the nativeKeyCode is set to be the same value as
2572         the windowsKeyCode, which is redundant.
2573
2574         The actual native key information is required so that components (like
2575         plugins) can reconstruct the original key event. The value stored in
2576         the windowsKeyCode is a Windows virtual key code which does not provide
2577         sufficient info to disambiguate the actual key being pressed (for
2578         example, it cannot distinguish between the left and right shift keys).
2579
2580         All platforms except Windows currently send native key event info, so
2581         this change will bring Windows in line with other platforms.
2582
2583         This change is part of our effort to send enhanced keycode information
2584         to Pepper plugins in Chromium.
2585
2586         * src/win/WebInputEventFactory.cpp:
2587         (WebKit::WebInputEventFactory::keyboardEvent):
2588
2589 2012-02-28  Adam Klein  <adamk@chromium.org>
2590
2591         Unreviewed, speculative test fix after r109016.
2592
2593         * tests/TransparencyWinTest.cpp:
2594         (WebCore::TEST): Update all ImageBuffer::create calls to include a scale of 1.
2595
2596 2012-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2597
2598         Unreviewed.  Rolled DEPS.
2599
2600         * DEPS:
2601
2602 2012-02-27  James Kozianski  <koz@chromium.org>
2603
2604         Add missing parameter to didCreateScriptContext() so it overrides base class again.
2605         https://bugs.webkit.org/show_bug.cgi?id=79742
2606
2607         Reviewed by Kent Tamura.
2608
2609         * tests/WebFrameTest.cpp:
2610
2611 2012-02-27  Kenichi Ishibashi  <bashi@chromium.org>
2612
2613         [Chromium] Unreviewed gardening, Disable TransparencyWin.OpaqueCompositeLayerPixel
2614
2615         * tests/TransparencyWinTest.cpp:
2616         (WebCore::TEST):
2617
2618 2012-02-27  Kinuko Yasuda  <kinuko@chromium.org>
2619
2620         [chromium] Add createSnapshotFile API to WebFileSystem to create File snapshots for filesystem files
2621         https://bugs.webkit.org/show_bug.cgi?id=79394
2622
2623         Reviewed by Darin Fisher.
2624
2625         * public/platform/WebFileSystem.h:
2626         (WebKit::WebFileSystem::createSnapshotFileAndReadMetadata): Added.
2627
2628 2012-02-27  James Kozianski  <koz@chromium.org>
2629
2630         [chromium] Plumb extensionGroup into didCreateScriptContext().
2631         https://bugs.webkit.org/show_bug.cgi?id=79072
2632
2633         Reviewed by Darin Fisher.
2634
2635         * public/WebFrameClient.h:
2636         (WebKit::WebFrameClient::didCreateScriptContext):
2637         * src/FrameLoaderClientImpl.cpp:
2638         (WebKit::FrameLoaderClientImpl::didCreateScriptContext):
2639         * src/FrameLoaderClientImpl.h:
2640         (FrameLoaderClientImpl):
2641
2642 2012-02-27  Adrienne Walker  <enne@google.com>
2643
2644         [chromium] Unreviewed gardening, disable TransparencyWinTest unit tests
2645         https://bugs.webkit.org/show_bug.cgi?id=79718
2646
2647         * tests/TransparencyWinTest.cpp:
2648
2649 2012-02-26  Hajime Morrita  <morrita@chromium.org>
2650
2651         Move ChromeClient::showContextMenu() to ContextMenuClient
2652         https://bugs.webkit.org/show_bug.cgi?id=79427
2653
2654         Reviewed by Adam Barth.
2655
2656         * src/ChromeClientImpl.h:
2657         (ChromeClientImpl):
2658
2659 2012-02-26  James Robinson  <jamesr@chromium.org>
2660
2661         Take 2 build fix.
2662
2663         * tests/CCLayerTreeHostImplTest.cpp:
2664         (WebKit::TEST_F):
2665
2666 2012-02-26  James Robinson  <jamesr@chromium.org>
2667
2668         Compile fix for CCLayerTreeHostImpl test.
2669
2670         * tests/CCLayerTreeHostImplTest.cpp:
2671         (WebKit::TEST_F):
2672
2673 2012-02-26  James Robinson  <jamesr@chromium.org>
2674
2675         [chromium] Wire up shouldUpdateScrollPositionOnMainThread and nonFastScrollableRegion to compositor
2676         https://bugs.webkit.org/show_bug.cgi?id=79155
2677
2678         Reviewed by Adam Barth.
2679
2680         Add new tests for shouldScrollOnMainThread and nonFastScrollableRegion properties.
2681
2682         * tests/CCLayerTreeHostImplTest.cpp:
2683         (WebKit::TEST_F):
2684         (WebKit):
2685         * tests/LayerChromiumTest.cpp:
2686
2687 2012-02-25  Adrienne Walker  <enne@google.com>
2688
2689         [chromium] Unreviewed gardening, fix Linux Clang OwnPtr breakage
2690         https://bugs.webkit.org/show_bug.cgi?id=78404
2691
2692         r108886 doesn't compile on Linux Clang due to OwnPtr's public copy
2693         constructor (i.e. "has internal linkage but is not defined"). Fixed
2694         locally by changing copy initialization to direct initialization.
2695
2696         * tests/TiledLayerChromiumTest.cpp:
2697         (WTF::TEST):
2698
2699 2012-02-24  Tien-Ren Chen  <trchen@chromium.org>
2700
2701         [chromium] Replace RefPtr with OwnPtr for CCLayerImpl tree structure
2702         https://bugs.webkit.org/show_bug.cgi?id=78404
2703
2704         Reviewed by James Robinson.
2705
2706         * tests/CCDamageTrackerTest.cpp:
2707         (WebKitTests::executeCalculateDrawTransformsAndVisibility):
2708         (WebKitTests::emulateDrawingOneFrame):
2709         (WebKitTests::createTestTreeWithOneSurface):
2710         (WebKitTests::createTestTreeWithTwoSurfaces):
2711         (WebKitTests::createAndSetUpTestTreeWithOneSurface):
2712         (WebKitTests::createAndSetUpTestTreeWithTwoSurfaces):
2713         (WebKitTests::TEST_F):
2714         * tests/CCLayerImplTest.cpp:
2715         (WebCore::TEST):
2716         * tests/CCLayerIteratorTest.cpp:
2717         * tests/CCLayerSorterTest.cpp:
2718         (WebCore::TEST):
2719         * tests/CCLayerTreeHostCommonTest.cpp:
2720         (WebCore::TEST):
2721         * tests/CCLayerTreeHostImplTest.cpp:
2722         (WebKit::CCLayerTreeHostImplTest::setupScrollAndContentsLayers):
2723         (WebKit::TEST_F):
2724         (WebKit::DidDrawCheckLayer::create):
2725         (WebKit::BlendStateCheckLayer::create):
2726         * tests/CCRenderSurfaceTest.cpp:
2727         (WebCore::TEST):
2728         * tests/CCSolidColorLayerImplTest.cpp:
2729         (CCLayerTestCommon::TEST):
2730         * tests/CCTiledLayerImplTest.cpp:
2731         (CCLayerTestCommon::createLayer):
2732         (CCLayerTestCommon::TEST):
2733         (CCLayerTestCommon::getQuads):
2734         * tests/Canvas2DLayerChromiumTest.cpp:
2735         (WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):
2736         * tests/TiledLayerChromiumTest.cpp:
2737         (WTF::TEST):
2738         * tests/TreeSynchronizerTest.cpp:
2739         (WebKitTests::MockCCLayerImpl::create):
2740         (WebKitTests::MockLayerChromium::createCCLayerImpl):
2741         (WebKitTests::expectTreesAreIdentical):
2742         (WebKitTests::TEST):
2743
2744 2012-02-08  James Robinson  <jamesr@chromium.org>
2745
2746         [chromium] Make WebViewImpl depend on WebLayerTreeView instead of CCLayerTreeHost
2747         https://bugs.webkit.org/show_bug.cgi?id=75591
2748
2749         Reviewed by Kenneth Russell.
2750
2751         This converts WebViewImpl from depending on CCLayerTreeHost to WebLayerTreeView in order to provide better
2752         isolation and allow for future refactorings. The changes to WebViewImpl are mostly mechanical. The
2753         WebLayerTreeView and WebLayerTreeViewClient interfaces have both grown and changed slightly:
2754
2755         - Setup path for WebLayerTreeView changed to expose an initialize() function instead of a create() factory
2756         function. The new model is that a WebLayerTreeView when constructed is in a null state. Calling initialize()
2757         attempts to re-initialize the WLTV, which can either fail or succeed.  All other functions must be called on a
2758         successfully initialized view.
2759
2760         - WebLayerTreeView expanded to include functionality that CCLayerTreeHost exposes but WebLayerTreeView did not.
2761         Some of this is only valid for the single thread case and will be removed when we invert the scheduling control
2762         logic, these bits are commented.
2763
2764         - WebLayerTreeViewClient expanded with some flow-control related APIs.
2765
2766         Refactor only, no change in behavior.
2767
2768         * public/platform/WebLayerTreeView.h:
2769         (WebKit::WebLayerTreeView::Settings::Settings):
2770         (WebKit::WebLayerTreeView::isNull):
2771         * public/platform/WebLayerTreeViewClient.h:
2772         * src/ChromeClientImpl.cpp:
2773         (WebKit::ChromeClientImpl::scheduleCompositingLayerSync):
2774         * src/WebLayerTreeView.cpp:
2775         (WebKit::WebLayerTreeView::initialize):
2776         (WebKit::WebLayerTreeView::compositorIdentifier):
2777         (WebKit::WebLayerTreeView::setVisible):
2778         (WebKit::WebLayerTreeView::setNeedsAnimate):
2779         (WebKit::WebLayerTreeView::updateAnimations):
2780         (WebKit::WebLayerTreeView::setNeedsRedraw):
2781         (WebKit::WebLayerTreeView::setPageScaleFactorAndLimits):
2782         (WebKit::WebLayerTreeView::startPageScaleAnimation):
2783         (WebKit::WebLayerTreeView::finishAllRendering):
2784         (WebKit::WebLayerTreeView::context):
2785         (WebKit::WebLayerTreeView::loseCompositorContext):
2786         * src/WebLayerTreeViewImpl.cpp:
2787         (WebKit::WebLayerTreeViewImpl::didRecreateGraphicsContext):
2788         (WebKit::WebLayerTreeViewImpl::didCommitAndDrawFrame):
2789         (WebKit::WebLayerTreeViewImpl::didCompleteSwapBuffers):
2790         * src/WebViewImpl.cpp:
2791         (WebKit::WebViewImpl::animate):
2792         (WebKit::WebViewImpl::doPixelReadbackToCanvas):
2793         (WebKit::WebViewImpl::paint):
2794         (WebKit::WebViewImpl::composite):
2795         (WebKit::WebViewImpl::loseCompositorContext):
2796         (WebKit::WebViewImpl::computePageScaleFactorLimits):
2797         (WebKit::WebViewImpl::addPageOverlay):
2798         (WebKit::WebViewImpl::removePageOverlay):
2799         (WebKit::WebViewImpl::setRootGraphicsLayer):
2800         (WebKit::WebViewImpl::scheduleCompositingLayerSync):
2801         (WebKit::WebViewImpl::scrollRootLayerRect):
2802         (WebKit::WebViewImpl::invalidateRootLayerRect):
2803         (WebKit::WebViewImpl::scheduleAnimation):
2804         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2805         (WebKit::WebViewImpl::createContext3D):
2806         (WebKit::WebViewImpl::applyScrollAndScale):
2807         (WebKit::WebViewImpl::didRebindGraphicsContext):
2808         (WebKit::WebViewImpl::updateLayerTreeViewport):
2809         (WebKit::WebViewImpl::graphicsContext3D):
2810         (WebKit::WebViewImpl::setVisibilityState):
2811         * src/WebViewImpl.h:
2812         * tests/WebLayerTest.cpp:
2813
2814 2012-02-24  Ian Vollick  <vollick@chromium.org>
2815
2816         [chromium] Plumb animation started notifications from CCLayerTreeHost to GraphicsLayerChromium
2817         https://bugs.webkit.org/show_bug.cgi?id=77646
2818
2819         Reviewed by James Robinson.
2820
2821         * tests/CCLayerTreeHostTest.cpp:
2822         (TestHooks):
2823         (WTF::TestHooks::notifyAnimationStarted):
2824         (WTF::TestHooks::notifyAnimationFinished):
2825         (WTF::MockLayerTreeHost::create):
2826         (WTF::CCLayerTreeHostTestAddAnimation::CCLayerTreeHostTestAddAnimation):
2827         (WTF::CCLayerTreeHostTestAddAnimation::animateLayers):
2828         (WTF::CCLayerTreeHostTestAddAnimation::notifyAnimationStarted):
2829         (CCLayerTreeHostTestAddAnimation):
2830         (WTF::CCLayerTreeHostTestAddAnimation::notifyAnimationFinished):
2831
2832 2012-02-24  James Robinson  <jamesr@chromium.org>
2833
2834         [chromium] WebKit::setColorNames is a client API
2835         https://bugs.webkit.org/show_bug.cgi?id=79539
2836
2837         Reviewed by Darin Fisher.
2838
2839         * WebKit.gyp:
2840         * public/WebColorName.h: Renamed from Source/Platform/chromium/public/WebColorName.h.
2841         (WebKit):
2842         * public/platform/WebColorName.h:
2843         * src/WebColor.cpp:
2844
2845 2012-02-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2846
2847         Unreviewed, rolling out r108860.
2848         http://trac.webkit.org/changeset/108860
2849         https://bugs.webkit.org/show_bug.cgi?id=79544
2850
2851         "Breaks Linux compile" (Requested by enne on #webkit).
2852
2853         * WebKit.gyp:
2854         * public/platform/WebColorName.h:
2855         * src/WebColor.cpp: Renamed from Source/WebKit/chromium/src/WebColorName.cpp.
2856         (WebKit):
2857         (WebKit::toCSSValueKeyword):
2858         (WebKit::setNamedColors):
2859
2860 2012-02-24  James Robinson  <jamesr@chromium.org>
2861
2862         [chromium] WebKit::setColorNames is a client API
2863         https://bugs.webkit.org/show_bug.cgi?id=79539
2864
2865         Reviewed by Darin Fisher.
2866
2867         * WebKit.gyp:
2868         * public/WebColorName.h: Renamed from Source/Platform/chromium/public/WebColorName.h.
2869         (WebKit):
2870         * public/platform/WebColorName.h:
2871         * src/WebColor.cpp:
2872
2873 2012-02-22  James Robinson  <jamesr@chromium.org>
2874
2875         [chromium] Move WebGraphicsContext3D header into the Platform directory
2876         https://bugs.webkit.org/show_bug.cgi?id=79301
2877
2878         Reviewed by Adam Barth.
2879
2880         Moves WebGraphicsContext3D and WebNonCopyable (which WGC3D depends on).
2881
2882         * public/platform/WebGraphicsContext3D.h:
2883         * public/platform/WebNonCopyable.h:
2884
2885 2012-02-24  Michal Mocny  <mmocny@google.com>
2886
2887         [chromium] Purge Skia's GPU texture cache using GL_CHROMIUM_gpu_memory_manager
2888         https://bugs.webkit.org/show_bug.cgi?id=78265
2889
2890         Reviewed by Stephen White.
2891
2892         * src/GraphicsContext3DChromium.cpp:
2893         (GrMemoryAllocationChangedCallback):
2894         (WebCore::GrMemoryAllocationChangedCallback::GrMemoryAllocationChangedCallback):
2895         (WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
2896         (WebCore):
2897         (WebCore::GraphicsContext3DPrivate::grContext):
2898
2899 2012-02-24  James Robinson  <jamesr@chromium.org>
2900
2901         [chromium] Remove deprecated and unused WebGraphicsContext3D::initialize call
2902         https://bugs.webkit.org/show_bug.cgi?id=79296
2903
2904         Reviewed by Kenneth Russell.
2905
2906         The old way to initialize a WebGraphicsContext3D from inside WebKit was to call initialize() on it with a
2907         WebView*. The new way to do this is via the WebViewClient interface. This deletes the old, unused path.
2908
2909         * public/platform/WebGraphicsContext3D.h:
2910         (WebKit):
2911         * tests/CCLayerTreeHostImplTest.cpp:
2912         * tests/FakeWebGraphicsContext3D.h:
2913
2914 2012-02-23  James Robinson  <jamesr@chromium.org>
2915
2916         [chromium] Move Web*Layer* headers into Platform
2917         https://bugs.webkit.org/show_bug.cgi?id=79425
2918
2919         Reviewed by Adam Barth.
2920
2921         Adds forwarding headers for Web*Layer* APIs and their dependencies.  The forwarding headers for the Web*Layer*
2922         APIs are temporary since Web*Layer* is not exposed in the client interface.  The other headers (such as
2923         WebColor) are exposed in both the client and platform APIs, so the forwarding headers are permanent, although we
2924         might move them back down to public/ at some point.
2925
2926         * public/platform/WebCanvas.h:
2927         * public/platform/WebColor.h:
2928         * public/platform/WebColorName.h:
2929         * public/platform/WebContentLayer.h:
2930         * public/platform/WebContentLayerClient.h:
2931         * public/platform/WebExternalTextureLayer.h:
2932         * public/platform/WebLayer.h:
2933         * public/platform/WebLayerTreeView.h:
2934         * public/platform/WebLayerTreeViewClient.h:
2935         * public/platform/WebPrivatePtr.h:
2936         * public/platform/WebSolidColorLayer.h:
2937
2938 2012-02-24  Peter Collingbourne  <peter@pcc.me.uk>
2939
2940         [chromium] Have WebFrameImpl::selectionAsMarkup create interchange markup.
2941         https://bugs.webkit.org/show_bug.cgi?id=77307
2942
2943         Reviewed by Tony Chang.
2944
2945         This function is currently used to build markup in order to
2946         print the selection, and will also be used to build markup for
2947         the clipboard.  Without this change, the markup will refer to
2948         (for example) nonexistent CSS classes and invalid relative
2949         paths and therefore will not be interpreted correctly.
2950
2951         Chromium bug: http://crbug.com/23329
2952
2953         * src/WebFrameImpl.cpp:
2954         (WebKit::WebFrameImpl::selectionAsMarkup):
2955
2956 2012-02-24  Pavel Feldman  <pfeldman@chromium.org>
2957
2958         Not reviewed: chromium image for inspector status bar button updated.
2959
2960         * src/js/Images/segmentSelectedEndChromium.png:
2961
2962 2012-02-24  Shinya Kawanaka  <shinyak@chromium.org>
2963
2964         SpellCheckRequest needs to know the context where the spellcheck happened.
2965         https://bugs.webkit.org/show_bug.cgi?id=79320
2966
2967         Reviewed by Hajime Morita.
2968
2969         * src/EditorClientImpl.cpp:
2970         (WebKit::EditorClientImpl::requestCheckingOfString):
2971         * src/EditorClientImpl.h:
2972         (EditorClientImpl):
2973         * src/WebFrameImpl.cpp:
2974         (WebKit::WebFrameImpl::requestTextChecking):
2975
2976 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2977
2978         Unreviewed.  Rolled DEPS.
2979
2980         * DEPS:
2981
2982 2012-02-23  Ian Vollick  <vollick@chromium.org>
2983
2984         [chromium] Implement keyframed animations for the cc thread.
2985         https://bugs.webkit.org/show_bug.cgi?id=77229
2986
2987         Reviewed by James Robinson.
2988
2989         * WebKit.gypi:
2990         * tests/CCAnimationTestCommon.cpp:
2991         (WebCore):
2992         (WebCore::addOpacityTransition):
2993         (WebKitTests::addOpacityTransitionToController):
2994         (WebKitTests::addOpacityTransitionToLayer):
2995         * tests/CCAnimationTestCommon.h:
2996         (WebCore):
2997         (WebKitTests):
2998         * tests/CCKeyframedAnimationCurveTest.cpp: Added.
2999         (WebCore):
3000         (WebCore::expectTranslateX):
3001         (WebCore::TEST):
3002         * tests/CCLayerAnimationControllerTest.cpp:
3003         (WebKitTests::expectTranslateX):
3004         (WebKitTests):
3005         (WebKitTests::TEST):
3006         * tests/CCLayerTreeHostTest.cpp:
3007         (WTF::CCLayerTreeHostTest::dispatchAddAnimation):
3008         (WTF::CCLayerTreeHostTest::doBeginTest):
3009
3010 2012-02-23  James Robinson  <jamesr@chromium.org>
3011
3012         [chromium] Clean up GraphicsContext3D initialization paths
3013         https://bugs.webkit.org/show_bug.cgi?id=79321
3014
3015         Reviewed by Kenneth Russell.
3016
3017         This simplifies the GraphicsContext3D initialization paths down to two simple codepaths, one for offscreen
3018         contexts initialized from WebCore and one for onscreen (compositor) contexts initialized by WebViewImpl or
3019         WebLayerTreeViewImpl.
3020
3021         Offscreen initialization path:
3022         1) WebCore code calls WebCore::GraphicsContext3D::create(), implemented in GraphicsContext3DChromium.cpp
3023         2) GraphicsContext3D::create() instantiates a WebGraphicsContext3D via the static WebKitPlatformSupport interface
3024         3) GraphicsContext3DPrivate::createGraphicsContextFromWebContext() wraps the WebGraphicsContext3D in a
3025         GraphicsContext3D's m_private pointer.
3026
3027         Onscreen initialization path:
3028         1) WebViewImpl or WebLayerTreeViewImpl request an onscreen WebGraphicsContext3D from either their WebViewClient
3029         or WebLayerTreeViewClient, respectively
3030         2) GraphicsContext3DPrivate::createGraphicsContextFromWebContext() wraps the WebGraphicsContext3D in a
3031         GraphicsContext3D's m_private pointer.
3032
3033         There are no other initialization paths. Specifically, we do not support instantiating onscreen contexts from
3034         within WebCore.
3035
3036         * src/GraphicsContext3DChromium.cpp:
3037         (WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
3038         (WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
3039         (WebCore):
3040         (WebCore::GraphicsContext3DPrivate::platformTexture):
3041         (WebCore::GraphicsContext3D::create):
3042         * src/GraphicsContext3DPrivate.h:
3043         (GraphicsContext3DPrivate):
3044         * src/WebLayerTreeViewImpl.cpp:
3045         (WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):
3046         * src/WebViewImpl.cpp:
3047         (std::getCompositorContextAttributes):
3048         (WebKit::WebViewImpl::createCompositorGraphicsContext3D):
3049         (WebKit):
3050         (WebKit::WebViewImpl::createLayerTreeHostContext3D):
3051         (WebKit::WebViewImpl::graphicsContext3D):
3052         * src/WebViewImpl.h:
3053         (WebViewImpl):
3054         * tests/CCLayerTreeHostImplTest.cpp:
3055         (WebKit::CCLayerTreeHostImplTest::createContext):
3056         (CCLayerTreeHostImplTest):
3057         (WebKit::TEST_F):
3058         * tests/CCLayerTreeHostTest.cpp:
3059         (WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
3060         * tests/Canvas2DLayerChromiumTest.cpp:
3061         (WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):
3062         * tests/CompositorFakeGraphicsContext3D.h:
3063         (WebCore::createCompositorMockGraphicsContext3D):
3064         * tests/FakeGraphicsContext3DTest.cpp:
3065         (TEST):
3066
3067 2012-02-23  Jonathan Backer  <backer@chromium.org>
3068
3069         [chromium] Plumb video damage to the damage tracker.
3070         https://bugs.webkit.org/show_bug.cgi?id=79373
3071
3072         Reviewed by James Robinson.
3073
3074         * src/WebMediaPlayerClientImpl.cpp:
3075         (WebKit::WebMediaPlayerClientImpl::repaint):
3076
3077 2012-02-21  James Robinson  <jamesr@chromium.org>
3078
3079         [chromium] Notify compositor of wheel event registration via ScrollingCoordinator
3080         https://bugs.webkit.org/show_bug.cgi?id=79133
3081
3082         Reviewed by Dimitri Glazkov.
3083
3084         Rips out old wheel event notification and adds unit tests for new LayerChromium property.
3085
3086         * src/NonCompositedContentHost.cpp:
3087         (WebKit::NonCompositedContentHost::setViewport):
3088         * src/WebCompositorInputHandlerImpl.cpp:
3089         (WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
3090         * src/WebViewImpl.cpp:
3091         (WebKit::WebViewImpl::numberOfWheelEventHandlersChanged):
3092         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
3093         * src/WebViewImpl.h:
3094         * tests/CCLayerTreeHostImplTest.cpp:
3095         (WebKit::TEST_F):
3096         (WebKit):
3097         * tests/LayerChromiumTest.cpp:
3098         * tests/WebCompositorInputHandlerImplTest.cpp:
3099
3100 2012-02-23  Adrienne Walker  <enne@google.com>
3101
3102         Unreviewed, rolling out r108666.
3103         http://trac.webkit.org/changeset/108666
3104         https://bugs.webkit.org/show_bug.cgi?id=79321
3105
3106         Breaks webplugin tests: http://goo.gl/CoHIi
3107
3108         * src/GraphicsContext3DChromium.cpp:
3109         (WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
3110         (WebCore):
3111         (WebCore::GraphicsContext3DPrivate::create):
3112         (WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
3113         (WebCore::GraphicsContext3DPrivate::createGraphicsContextForAnotherThread):
3114         (WebCore::GraphicsContext3DPrivate::platformTexture):
3115         (WebCore::GraphicsContext3D::create):
3116         * src/GraphicsContext3DPrivate.h:
3117         (WebKit):
3118         (GraphicsContext3DPrivate):
3119         * src/WebLayerTreeViewImpl.cpp:
3120         (WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):
3121         * src/WebViewImpl.cpp:
3122         (std::getCompositorContextAttributes):
3123         (WebKit::WebViewImpl::createLayerTreeHostContext3D):
3124         (WebKit::WebViewImpl::graphicsContext3D):
3125         * tests/CCLayerTreeHostImplTest.cpp:
3126         (CCLayerTreeHostImplTest):
3127         (WebKit::TEST_F):
3128         * tests/CCLayerTreeHostTest.cpp:
3129         (WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
3130         * tests/Canvas2DLayerChromiumTest.cpp:
3131         (WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):
3132         * tests/CompositorFakeGraphicsContext3D.h:
3133         (WebCore::createCompositorMockGraphicsContext3D):
3134         * tests/FakeGraphicsContext3DTest.cpp:
3135         (TEST):
3136
3137 2012-02-23  Daniel Sievers  <sievers@chromium.org>
3138
3139         [Chromium] Add video stream texture support
3140         https://bugs.webkit.org/show_bug.cgi?id=78398
3141
3142         This upstreams the abstraction used on Android for
3143         hardware video decoding with the compositor.
3144
3145         Most of the interfaces are kept generic and the core
3146         of this change is to allow texturing from an external
3147         texture while receiving notifications (on the compositor
3148         thread if we are running it) when there are new frames to
3149         be displayed.
3150
3151         Reviewed by James Robinson.
3152
3153         * WebKit.gyp:
3154         * public/WebMediaPlayer.h:
3155         (WebKit):
3156         (WebKit::WebMediaPlayer::setStreamTextureClient):
3157         (WebMediaPlayer):
3158         * public/WebStreamTextureClient.h: Copied from Source/WebKit/chromium/public/WebVideoFrame.h.
3159         (WebKit):
3160         (WebStreamTextureClient):
3161         (WebKit::WebStreamTextureClient::~WebStreamTextureClient):
3162         * public/WebVideoFrame.h:
3163         * src/WebMediaPlayerClientImpl.cpp:
3164         (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
3165         (WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):
3166         (WebKit::WebMediaPlayerClientImpl::didReceiveFrame):
3167         (WebKit):
3168         (WebKit::WebMediaPlayerClientImpl::didUpdateMatrix):
3169         * src/WebMediaPlayerClientImpl.h:
3170         (WebMediaPlayerClientImpl):
3171
3172 2012-02-22  James Robinson  <jamesr@chromium.org>
3173
3174         [chromium] Clean up GraphicsContext3D initialization paths
3175         https://bugs.webkit.org/show_bug.cgi?id=79321
3176
3177         Reviewed by Kenneth Russell.
3178
3179         This simplifies the GraphicsContext3D initialization paths down to two simple codepaths, one for offscreen
3180         contexts initialized from WebCore and one for onscreen (compositor) contexts initialized by WebViewImpl or
3181         WebLayerTreeViewImpl.
3182
3183         Offscreen initialization path:
3184         1) WebCore code calls WebCore::GraphicsContext3D::create(), implemented in GraphicsContext3DChromium.cpp
3185         2) GraphicsContext3D::create() instantiates a WebGraphicsContext3D via the static WebKitPlatformSupport interface
3186         3) GraphicsContext3DPrivate::createGraphicsContextFromWebContext() wraps the WebGraphicsContext3D in a
3187         GraphicsContext3D's m_private pointer.
3188
3189         Onscreen initialization path:
3190         1) WebViewImpl or WebLayerTreeViewImpl request an onscreen WebGraphicsContext3D from either their WebViewClient
3191         or WebLayerTreeViewClient, respectively
3192         2) GraphicsContext3DPrivate::createGraphicsContextFromWebContext() wraps the WebGraphicsContext3D in a
3193         GraphicsContext3D's m_private pointer.
3194
3195         There are no other initialization paths. Specifically, we do not support instantiating onscreen contexts from
3196         within WebCore.
3197
3198         * src/GraphicsContext3DChromium.cpp:
3199         (WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
3200         (WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
3201         (WebCore):
3202         (WebCore::GraphicsContext3DPrivate::platformTexture):
3203         (WebCore::GraphicsContext3D::create):
3204         * src/GraphicsContext3DPrivate.h:
3205         (GraphicsContext3DPrivate):
3206         * src/WebLayerTreeViewImpl.cpp:
3207         (WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):
3208         * src/WebViewImpl.cpp:
3209         (std::getCompositorContextAttributes):
3210         (WebKit::WebViewImpl::createLayerTreeHostContext3D):
3211         (WebKit::WebViewImpl::graphicsContext3D):
3212         * tests/CCLayerTreeHostImplTest.cpp:
3213         (WebKit::CCLayerTreeHostImplTest::createContext):
3214         (CCLayerTreeHostImplTest):
3215         (WebKit::TEST_F):
3216         * tests/CCLayerTreeHostTest.cpp:
3217         (WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
3218         * tests/Canvas2DLayerChromiumTest.cpp:
3219         (WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):
3220         * tests/CompositorFakeGraphicsContext3D.h:
3221         (WebCore::createCompositorMockGraphicsContext3D):
3222         * tests/FakeGraphicsContext3DTest.cpp:
3223         (TEST):
3224
3225 2012-02-23  Greg Billock  <gbillock@google.com>
3226
3227         Add UserGestureIndicator capability to Chromium API.
3228         https://bugs.webkit.org/show_bug.cgi?id=77690
3229
3230         Reviewed by Darin Fisher.
3231
3232         * WebKit.gyp:
3233         * public/WebScopedUserGesture.h: Added.
3234         * src/WebScopedUserGesture.cpp: Added.
3235
3236 2012-02-23  Peter Beverloo  <peter@chromium.org>
3237
3238         Unreviewed, rolling out r108627 and r108630.
3239         https://bugs.webkit.org/show_bug.cgi?id=79367
3240
3241         ffmpeg is creating issues and was just reverted upstream as well.
3242
3243         * DEPS:
3244
3245 2012-02-23  Peter Beverloo  <peter@chromium.org>
3246
3247         Unreviewed build fix. Remove the ffmpeg binary directory from the
3248         Chromium-Windows DEPS file, following the commit done in the
3249         Chromium repository:
3250         http://src.chromium.org/viewvc/chrome?view=rev&revision=123123
3251
3252         * DEPS:
3253
3254 2012-02-23  Peter Beverloo  <peter@chromium.org>
3255
3256         Unreviewed.  Rolled DEPS.
3257
3258         * DEPS:
3259
3260 2012-02-22  Hajime Morrita  <morrita@chromium.org>
3261
3262         NOTIFICATIONS should be implemented as PageSupplement
3263         https://bugs.webkit.org/show_bug.cgi?id=79052
3264
3265         Reviewed by Adam Barth.
3266
3267         * src/WebViewImpl.cpp:
3268         (WebKit::WebViewImpl::WebViewImpl):
3269
3270 2012-02-22  Dana Jansens  <danakj@chromium.org>
3271
3272         [chromium] Add unit test for surface occlusion
3273         https://bugs.webkit.org/show_bug.cgi?id=79302
3274
3275         Reviewed by James Robinson.
3276
3277         * tests/CCOcclusionTrackerTest.cpp:
3278         (WebCore::TEST):
3279         (WebCore):
3280
3281 2012-02-22  James Robinson  <jamesr@chromium.org>
3282
3283         Remove GraphicsContext3D::paintsIntoCanvasBuffer and unify WebGL and canvas 2d logic
3284         https://bugs.webkit.org/show_bug.cgi?id=79317
3285
3286         Reviewed by Kenneth Russell.
3287
3288         Remove paintsIntoCanvasBuffer() implementations.
3289
3290         * src/GraphicsContext3DChromium.cpp:
3291         (WebCore):
3292         * src/GraphicsContext3DPrivate.h:
3293
3294 2012-02-22  Yuta Kitamura  <yutak@chromium.org>
3295
3296         Unreviewed, rolling out r108590.
3297         http://trac.webkit.org/changeset/108590
3298
3299         I mistakenly disabled tests even though the fix was already
3300         in.
3301
3302         * tests/CCOcclusionTrackerTest.cpp:
3303         (WebCore::TEST):
3304
3305 2012-02-22  Yuta Kitamura  <yutak@chromium.org>
3306
3307         [Chromium] Unreviewed. Disable two tests from CCOcclusionTrackerTest
3308         which cause assertion failures.
3309
3310         * tests/CCOcclusionTrackerTest.cpp:
3311         (WebCore):
3312         (WebCore::TEST):
3313
3314 2012-02-22  Dana Jansens  <danakj@chromium.org>
3315
3316         [chromium] Fix CCOcclusionTracker unit test assertion
3317         https://bugs.webkit.org/show_bug.cgi?id=79275
3318
3319         Reviewed by James Robinson.
3320
3321         * tests/CCOcclusionTrackerTest.cpp:
3322         (WebCore::TEST):
3323
3324 2012-02-22  Ian Vollick  <vollick@chromium.org>
3325
3326         [chromium] Plumb from GraphicsLayer to the cc thread animation code
3327         https://bugs.webkit.org/show_bug.cgi?id=75874
3328
3329         Reviewed by James Robinson.
3330
3331         * WebKit.gypi:
3332         * public/WebSettings.h:
3333         * public/platform/WebLayerTreeView.h:
3334         (WebKit::WebLayerTreeView::Settings::Settings):
3335         (Settings):
3336         * src/WebLayerTreeView.cpp:
3337         (WebKit::WebLayerTreeView::Settings::operator CCSettings):
3338         * src/WebSettingsImpl.cpp:
3339         (WebKit::WebSettingsImpl::setThreadedAnimationEnabled):
3340         (WebKit):
3341         * src/WebSettingsImpl.h:
3342         (WebSettingsImpl):
3343         * src/WebViewImpl.cpp:
3344         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
3345         * tests/CCActiveAnimationTest.cpp:
3346         (WebCore::createActiveAnimation):
3347         * tests/CCAnimationTestCommon.cpp: Added.
3348         (WebKitTests):
3349         (WebKitTests::FakeFloatAnimationCurve::FakeFloatAnimationCurve):
3350         (WebKitTests::FakeFloatAnimationCurve::~FakeFloatAnimationCurve):
3351         (WebKitTests::FakeFloatAnimationCurve::clone):
3352         (WebKitTests::FakeTransformTransition::FakeTransformTransition):
3353         (WebKitTests::FakeTransformTransition::~FakeTransformTransition):
3354         (WebKitTests::FakeTransformTransition::getValue):
3355         (WebKitTests::FakeTransformTransition::clone):
3356         (WebKitTests::FakeFloatTransition::FakeFloatTransition):
3357         (WebKitTests::FakeFloatTransition::~FakeFloatTransition):
3358         (WebKitTests::FakeFloatTransition::getValue):
3359         (WebKitTests::FakeLayerAnimationControllerImplClient::FakeLayerAnimationControllerImplClient):
3360         (WebKitTests::FakeLayerAnimationControllerImplClient::~FakeLayerAnimationControllerImplClient):
3361         (WebKitTests::FakeFloatTransition::clone):
3362         (WebKitTests::addOpacityTransition):
3363         * tests/CCAnimationTestCommon.h: Added.
3364         (WebCore):
3365         (WebKitTests):
3366         (FakeFloatAnimationCurve):
3367         (WebKitTests::FakeFloatAnimationCurve::duration):
3368         (WebKitTests::FakeFloatAnimationCurve::getValue):
3369         (FakeTransformTransition):
3370         (WebKitTests::FakeTransformTransition::duration):
3371         (FakeFloatTransition):
3372         (WebKitTests::FakeFloatTransition::duration):
3373         (FakeLayerAnimationControllerImplClient):
3374         (WebKitTests::FakeLayerAnimationControllerImplClient::id):
3375         (WebKitTests::FakeLayerAnimationControllerImplClient::opacity):
3376         (WebKitTests::FakeLayerAnimationControllerImplClient::setOpacity):
3377         (WebKitTests::FakeLayerAnimationControllerImplClient::transform):
3378         (WebKitTests::FakeLayerAnimationControllerImplClient::setTransform):
3379         (WebKitTests::FakeLayerAnimationControllerImplClient::bounds):
3380         * tests/CCLayerAnimationControllerImplTest.cpp:
3381         (WebKitTests::createActiveAnimation):
3382         (WebKitTests::TEST):
3383         * tests/CCLayerAnimationControllerTest.cpp: Added.
3384         (WebKitTests):
3385         (WebKitTests::createActiveAnimation):
3386         (WebKitTests::TEST):
3387         * tests/CCLayerTreeHostImplTest.cpp:
3388         (WebKit::CCLayerTreeHostImplTest::postAnimationEventsToMainThreadOnImplThread):
3389         * tests/CCLayerTreeHostTest.cpp:
3390         (WTF::TestHooks::animateLayers):
3391         (MockLayerTreeHostImpl):
3392         (WTF::MockLayerTreeHostImpl::animateLayers):
3393         (WTF::MockLayerTreeHost::create):
3394         (WTF::MockLayerTreeHost::createLayerTreeHostImpl):
3395         (WTF):
3396         (MockLayerAnimationController):
3397         (WTF::MockLayerAnimationController::create):
3398         (WTF::MockLayerAnimationController::addAnimation):
3399         (WTF::MockLayerTreeHostClient::scheduleComposite):
3400         (WTF::CCLayerTreeHostTest::postAddAnimationToMainThread):
3401         (CCLayerTreeHostTest):
3402         (WTF::CCLayerTreeHostTest::dispatchAddAnimation):
3403         (WTF::CCLayerTreeHostTest::doBeginTest):
3404         (CCLayerTreeHostTestAddAnimation):
3405         (WTF::CCLayerTreeHostTestAddAnimation::CCLayerTreeHostTestAddAnimation):
3406         (WTF::CCLayerTreeHostTestAddAnimation::beginTest):
3407         (WTF::CCLayerTreeHostTestAddAnimation::animateLayers):
3408         (WTF::CCLayerTreeHostTestAddAnimation::afterTest):
3409         (WTF::TEST_F):
3410         * tests/TreeSynchronizerTest.cpp:
3411         (FakeLayerAnimationController):
3412         (WebKitTests::FakeLayerAnimationController::create):
3413         (WebKitTests::FakeLayerAnimationController::synchronizedAnimations):
3414         (WebKitTests::FakeLayerAnimationController::FakeLayerAnimationController):
3415         (WebKitTests::FakeLayerAnimationController::synchronizeAnimations):
3416         (WebKitTests):
3417         (WebKitTests::TEST):
3418
3419 2012-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3420
3421         Remove the remaining uses of CSSStyleDeclaration in Editor
3422         https://bugs.webkit.org/show_bug.cgi?id=78939
3423
3424         Reviewed by Enrica Casucci.
3425
3426         * src/EditorClientImpl.cpp:
3427         (WebKit::EditorClientImpl::shouldApplyStyle):
3428         * src/EditorClientImpl.h:
3429         (EditorClientImpl):
3430
3431 2012-02-22  Daniel Cheng  <dcheng@chromium.org>
3432
3433         [chromium] Cleanup unused WebDragData methods after r107846
3434         https://bugs.webkit.org/show_bug.cgi?id=78837
3435
3436         Reviewed by Tony Chang.
3437
3438         The deleted methods have been replaced by items() and setItems().
3439
3440         * public/platform/WebDragData.h:
3441         (WebDragData):
3442         * src/WebDragData.cpp:
3443         (WebKit::WebDragData::addItem): Add ensureMutable() call to verify preconditions for
3444                                         mutating the item store.
3445
3446 2012-02-22  Tim Dresser  <tdresser@chromium.org>
3447
3448         CCLayerTreeHostImpl calls didDraw more frequently than willDraw
3449         https://bugs.webkit.org/show_bug.cgi?id=79139
3450
3451         Reviewed by James Robinson.
3452
3453         * tests/CCLayerTreeHostImplTest.cpp:
3454         (WebKit::DidDrawCheckLayer::willDraw):
3455         (DidDrawCheckLayer):
3456         (WebKit::DidDrawCheckLayer::willDrawCalled):
3457         (WebKit::DidDrawCheckLayer::DidDrawCheckLayer):
3458         (WebKit::TEST_F):
3459         (WebKit):
3460
3461 2012-02-22  Dana Jansens  <danakj@chromium.org>
3462
3463         [Chromium] New CCOcclusionTracker class with tests
3464         https://bugs.webkit.org/show_bug.cgi?id=78549
3465
3466         Reviewed by James Robinson.
3467
3468         * WebKit.gypi:
3469         * tests/CCLayerTreeHostCommonTest.cpp:
3470         (WebCore):
3471         * tests/CCOcclusionTrackerTest.cpp: Added.
3472         (WebCore):
3473         (WebCore::setLayerPropertiesForTesting):
3474         (LayerChromiumWithForcedDrawsContent):
3475         (WebCore::LayerChromiumWithForcedDrawsContent::LayerChromiumWithForcedDrawsContent):
3476         (WebCore::LayerChromiumWithForcedDrawsContent::drawsContent):
3477         (TestCCOcclusionTracker):
3478         (WebCore::TestCCOcclusionTracker::occlusionInScreenSpace):
3479         (WebCore::TestCCOcclusionTracker::occlusionInTargetSurface):
3480         (WebCore::TestCCOcclusionTracker::setOcclusionInScreenSpace):
3481         (WebCore::TestCCOcclusionTracker::setOcclusionInTargetSurface):
3482         (WebCore::TEST):
3483
3484 2012-02-22  Hao Zheng  <zhenghao@chromium.org>
3485
3486         [chromium] Build WebKit with MEDIA_STREAM disabled.
3487         https://bugs.webkit.org/show_bug.cgi?id=79214
3488
3489         Reviewed by Kent Tamura.
3490
3491         * src/UserMediaClientImpl.h:
3492
3493