9c0ff1b60df7cd8f0fcd32f87da7feb256bec20a
[WebKit-https.git] / Source / WebKit / chromium / ChangeLog
1 2013-02-14  Alexandre Elias  <aelias@chromium.org>
2
3         [chromium] Fix scaling in WebViewImpl::handleGestureEvent, second try
4         https://bugs.webkit.org/show_bug.cgi?id=109671
5
6         Reviewed by James Robinson.
7
8         My patch 142571 broke a bunch of things in handleGestureEvent that
9         assumed the event came in scaled, most notably tap highlight and
10         double-tap zoom. Switch those to PlatformGestureEvent.
11
12         142808 was an earlier version of this patch that was reverted
13         due to fling events asserting they can't be converted to
14         PlatformGestureEvent. This version moves fling earlier in the
15         function to avoid that.
16
17         * src/WebViewImpl.cpp:
18         (WebKit::WebViewImpl::handleGestureEvent):
19         (WebKit::WebViewImpl::bestTapNode):
20         (WebKit::WebViewImpl::enableTapHighlight):
21         * src/WebViewImpl.h:
22         (WebViewImpl):
23         * tests/LinkHighlightTest.cpp:
24         (WebCore::TEST):
25
26 2013-02-14  Dirk Pranke  <dpranke@chromium.org>
27
28         Unreviewed, rolling out r142901.
29         http://trac.webkit.org/changeset/142901
30
31         r182258 introduces a dependency on chrome.gyp that breaks the win
32         build. Rolling back to r182150 until I can work up a workaround.
33
34         * DEPS:
35
36 2013-02-14  Dirk Pranke  <dpranke@chromium.org>
37
38         Unreviewed, chromium roll 182150 -> 182448
39
40         * DEPS:
41
42 2013-02-14  Mark Pilgrim  <pilgrim@chromium.org>
43
44         [Chromium] Move PlatformMessagePortChannel to WebCore
45         https://bugs.webkit.org/show_bug.cgi?id=109845
46
47         Reviewed by Adam Barth.
48
49         Part of a larger refactoring series; see tracking bug 106829.
50
51         * WebKit.gyp:
52         * src/PlatformMessagePortChannel.cpp: Removed.
53         * src/PlatformMessagePortChannel.h: Removed.
54         * src/SharedWorkerRepository.cpp:
55         * src/WebDOMMessageEvent.cpp:
56         * src/WebFrameImpl.cpp:
57         * src/WebSharedWorkerImpl.cpp:
58         * src/WebWorkerClientImpl.cpp:
59
60 2013-02-14  Min Qin  <qinmin@chromium.org>
61
62         Passing alpha to DeferredImageDecoder once decoding completes
63         https://bugs.webkit.org/show_bug.cgi?id=108892
64
65         Reviewed by Stephen White.
66
67         Add test to check that alpha value is passed from the decoder to ImageFrameGenerator.
68
69         * tests/ImageFrameGeneratorTest.cpp:
70         (WebCore::MockImageDecoderFactory::create):
71         (WebCore::TEST_F):
72         * tests/MockImageDecoder.h:
73         (WebCore::MockImageDecoder::MockImageDecoder):
74         (WebCore::MockImageDecoder::setFrameHasAlpha):
75         (MockImageDecoder):
76         (WebCore::MockImageDecoder::frameHasAlphaAtIndex):
77
78 2013-02-08  Andrey Kosyakov  <caseq@chromium.org>
79
80         Web Inspector: expose did{Begin,Cancel}Frame() and {will,did}Composite() on WebDebToolsAgent
81         https://bugs.webkit.org/show_bug.cgi?id=109192
82
83         Reviewed by Pavel Feldman.
84
85         - expose frame and compositing insturmentation methods on WebDevToolsAgent;
86         - temporarily route them from WebViewImpl to WebDevToolsAgent;
87
88         * public/WebDevToolsAgent.h:
89         (WebDevToolsAgent):
90         * src/WebDevToolsAgentImpl.cpp:
91         (WebKit::WebDevToolsAgentImpl::didBeginFrame):
92         (WebKit):
93         (WebKit::WebDevToolsAgentImpl::didCancelFrame):
94         (WebKit::WebDevToolsAgentImpl::willComposite):
95         (WebKit::WebDevToolsAgentImpl::didComposite):
96         * src/WebDevToolsAgentImpl.h:
97         (WebDevToolsAgentImpl):
98         * src/WebViewImpl.cpp:
99         (WebKit::WebViewImpl::instrumentBeginFrame):
100         (WebKit::WebViewImpl::instrumentCancelFrame):
101         (WebKit::WebViewImpl::didBeginFrame):
102         (WebKit::WebViewImpl::willCommit):
103
104 2013-02-14  Mikhail Naganov  <mnaganov@chromium.org>
105
106         [Chromium] Add a setting to control scaling content to fit viewport
107         https://bugs.webkit.org/show_bug.cgi?id=109584
108
109         Adds a setting called 'initializeAtMinimumPageScale'. By default,
110         it is set to 'true' which corresponds to Chrome on Android behavior--
111         adjust the page scale to make the content fit into the viewport
112         by width. When set to false, the setting instructs ChromeClientImpl to
113         set page scale to 1.0, unless the scale value is set by the page
114         in the viewport meta-tag.
115
116         Reviewed by Adam Barth.
117
118         * public/WebSettings.h:
119         * src/ChromeClientImpl.cpp:
120         (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
121         * src/WebSettingsImpl.cpp:
122         (WebKit::WebSettingsImpl::WebSettingsImpl):
123         (WebKit::WebSettingsImpl::setInitializeAtMinimumPageScale):
124         (WebKit):
125         * src/WebSettingsImpl.h:
126         (WebSettingsImpl):
127         (WebKit::WebSettingsImpl::initializeAtMinimumPageScale):
128         * tests/WebFrameTest.cpp:
129         * tests/data/viewport-2x-initial-scale.html: Added.
130         * tests/data/viewport-auto-initial-scale.html: Added.
131
132 2013-02-14  Sheriff Bot  <webkit.review.bot@gmail.com>
133
134         Unreviewed, rolling out r142808.
135         http://trac.webkit.org/changeset/142808
136         https://bugs.webkit.org/show_bug.cgi?id=109816
137
138         Crashes on chromium webkit canary bots (Requested by atwilson_
139         on #webkit).
140
141         * src/WebViewImpl.cpp:
142         (WebKit::WebViewImpl::handleGestureEvent):
143         (WebKit::WebViewImpl::bestTouchLinkNode):
144         (WebKit::WebViewImpl::enableTouchHighlight):
145         * src/WebViewImpl.h:
146         (WebViewImpl):
147         * tests/LinkHighlightTest.cpp:
148         (WebCore::TEST):
149
150 2013-02-14  Sheriff Bot  <webkit.review.bot@gmail.com>
151
152         Unreviewed, rolling out r142841.
153         http://trac.webkit.org/changeset/142841
154         https://bugs.webkit.org/show_bug.cgi?id=109791
155
156         Caused webkit_unit_tests to crash on chromium bots. (Requested
157         by atwilson_ on #webkit).
158
159         * tests/GraphicsLayerChromiumTest.cpp:
160         (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
161         * tests/ScrollingCoordinatorChromiumTest.cpp:
162         (WebKit::FakeWebViewClient::initializeLayerTreeView):
163
164 2013-02-13  Max Vujovic  <mvujovic@adobe.com>
165
166         [CSS Filters] Refactor filter outsets into a class
167         https://bugs.webkit.org/show_bug.cgi?id=109330
168
169         Update FilterOperations unit tests to use new interface for getting filter outsets.
170
171         Reviewed by Dean Jackson.
172
173         * tests/FilterOperationsTest.cpp:
174         (WebKit::TEST):
175
176 2013-02-13  Zan Dobersek  <zdobersek@igalia.com>
177
178         The 'global isinf/isnan' compiler quirk required when using clang with libstdc++
179         https://bugs.webkit.org/show_bug.cgi?id=109325
180
181         Reviewed by Anders Carlsson.
182
183         Prefix calls to the isinf and isnan methods with std::, declaring we want to use the
184         two methods as they're provided by the C++ standard library being used.
185
186         * tests/DecimalTest.cpp:
187         (TEST_F):
188
189 2013-02-13  Alexandre Elias  <aelias@chromium.org>
190
191         [chromium] Fix scaling in WebViewImpl::handleGestureEvent
192         https://bugs.webkit.org/show_bug.cgi?id=109671
193
194         Reviewed by James Robinson.
195
196         My last patch broke a bunch of things in handleGestureEvent that
197         assumed the event came in scaled, most notably tap highlight and
198         double-tap zoom. Switch those to PlatformGestureEvent.
199
200         * src/WebViewImpl.cpp:
201         (WebKit::WebViewImpl::handleGestureEvent):
202         (WebKit::WebViewImpl::bestTapNode):
203         (WebKit::WebViewImpl::enableTapHighlight):
204         * src/WebViewImpl.h:
205         (WebViewImpl):
206         * tests/LinkHighlightTest.cpp:
207         (WebCore::TEST):
208
209 2013-02-13  Eberhard Graether  <egraether@google.com>
210
211         chromium: remove CompositorHUDFontAtlas
212         https://bugs.webkit.org/show_bug.cgi?id=109328
213
214         Reviewed by James Robinson.
215
216         After switching the HudLayer to use skia's font rendering the
217         CompositorHUDFontAtlas has become obsolete. This change removes
218         this class and the related WebLayerTreeView API.
219
220         * src/WebViewImpl.cpp:
221         * src/WebViewImpl.h:
222
223 2013-02-13  Sheriff Bot  <webkit.review.bot@gmail.com>
224
225         Unreviewed.  Rolled Chromium DEPS to r182150.  Requested by
226         jamesr_ via sheriffbot.
227
228         * DEPS:
229
230 2013-02-13  Sadrul Habib Chowdhury  <sadrul@chromium.org>
231
232         [chromium] Add acceleration ratios for the deltas to WebMouseWheelEvents.
233         https://bugs.webkit.org/show_bug.cgi?id=109611
234
235         The deltas in mousewheel events generated by track can be accelerated (e.g. when
236         scrolling repeatedly). Keep track of the ratio of the acceleration since that is
237         useful for some tasks (e.g. overflow navigation gesture).
238
239         Reviewed by Adam Barth.
240
241         * public/WebInputEvent.h:
242         (WebKit::WebMouseWheelEvent::WebMouseWheelEvent):
243         * src/WebInputEvent.cpp:
244         (SameSizeAsWebMouseWheelEvent):
245
246 2013-02-12  Yoshifumi Inoue  <yosin@chromium.org>
247
248         Unreviewed. Build fix for Chromium-Win.
249         Add #include <functional> for std::bind1st.
250
251         * tests/PrerenderingTest.cpp:
252
253 2013-02-12  Joshua Bell  <jsbell@chromium.org>
254
255         [Chromium] IndexedDB/Worker crash during shutdown
256         https://bugs.webkit.org/show_bug.cgi?id=109467
257
258         Reviewed by Tony Chang.
259
260         If the message queue has already been terminated, don't bother scheduling
261         a new error event that will never be delivered. Speculative fix for the
262         issue, which only repros in multiprocess ports and so far only on some
263         platforms.
264
265         * src/IDBFactoryBackendProxy.cpp:
266         (WebKit::IDBFactoryBackendProxy::allowIndexedDB): Early exit.
267
268 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
269
270         Remove ENABLE_XHR_RESPONSE_BLOB handling from various build systems
271         https://bugs.webkit.org/show_bug.cgi?id=109481
272
273         Reviewed by Daniel Bates.
274
275         The ENABLE_XHR_RESPONSE_BLOB feature define was removed from the code
276         back in r120574. There are still occurrences of it in various build systems
277         which should all be removed as they are useless.
278
279         * features.gypi:
280
281 2013-02-12  Jochen Eisinger  <jochen@chromium.org>
282
283         Disabling WebFrameTest.ReplaceMisspelledRange on Android because it crashes
284         https://bugs.webkit.org/show_bug.cgi?id=109548
285
286         Unreviewed gardening.
287
288         * tests/WebFrameTest.cpp:
289
290 2013-02-11  James Robinson  <jamesr@chromium.org>
291
292         [Chromium] Get rid of WebAnimationController
293         https://bugs.webkit.org/show_bug.cgi?id=109235
294
295         Reviewed by Benjamin Poulain.
296
297         * public/WebAnimationController.h: Removed.
298         * public/WebFrame.h:
299         (WebFrame):
300         * src/WebAnimationControllerImpl.cpp: Removed.
301         * src/WebAnimationControllerImpl.h: Removed.
302         * src/WebFrameImpl.cpp:
303         * src/WebFrameImpl.h:
304         (WebFrameImpl):
305
306 2013-02-11  James Robinson  <jamesr@chromium.org>
307
308         [chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
309         https://bugs.webkit.org/show_bug.cgi?id=109403
310
311         Reviewed by Adam Barth.
312
313         * tests/GraphicsLayerChromiumTest.cpp:
314         (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
315         * tests/ScrollingCoordinatorChromiumTest.cpp:
316         (WebKit::FakeWebViewClient::initializeLayerTreeView):
317
318 2013-02-11  Ryosuke Niwa  <rniwa@webkit.org>
319
320         Disable delete button controller on non-Mac ports and delete EditorClient::shouldShowDeleteInterface
321         https://bugs.webkit.org/show_bug.cgi?id=109534
322
323         Reviewed by Anders Carlsson.
324
325         * src/EditorClientImpl.cpp:
326         (WebKit):
327         * src/EditorClientImpl.h:
328         (EditorClientImpl):
329
330 2013-02-11  Alexandre Elias  <aelias@chromium.org>
331
332         [chromium] Apply page scale to all WebInputEvent types
333         https://bugs.webkit.org/show_bug.cgi?id=109370
334
335         Reviewed by James Robinson.
336
337         Previously we only adjusted a few common input event types by page
338         scale, but in fact almost every position and size in WebInputEvents
339         requires it.
340
341         I also took the opportunity to change some WebGestureEvent members to
342         floats (which I checked causes no warnings in Chromium-side code with
343         GCC or Clang).
344
345         New WebInputEventConversionTest: InputEventsScaling
346
347         * public/WebInputEvent.h:
348         (WebKit::WebGestureEvent::WebGestureEvent):
349         * src/WebInputEventConversion.cpp:
350         (WebKit::widgetScaleFactor):
351         (WebKit):
352         (WebKit::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
353         (WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
354         (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
355         (WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder):
356         (WebKit::updateWebMouseEventFromWebCoreMouseEvent):
357         (WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
358         (WebKit::addTouchPoints):
359         (WebKit::WebTouchEventBuilder::WebTouchEventBuilder):
360         (WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
361         * src/WebViewImpl.cpp:
362         (WebKit::WebViewImpl::handleGestureEvent):
363         (WebKit::WebViewImpl::hasTouchEventHandlersAt):
364         (WebKit::WebViewImpl::handleInputEvent):
365         * tests/WebInputEventConversionTest.cpp:
366         (WebCore::TEST):
367         (WebCore):
368
369 2013-02-11  Sheriff Bot  <webkit.review.bot@gmail.com>
370
371         Unreviewed, rolling out r142568.
372         http://trac.webkit.org/changeset/142568
373         https://bugs.webkit.org/show_bug.cgi?id=109541
374
375         Broke the build, won't compile. (Requested by alancutter on
376         #webkit).
377
378         * tests/GraphicsLayerChromiumTest.cpp:
379         (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
380         * tests/ScrollingCoordinatorChromiumTest.cpp:
381         (WebKit::FakeWebViewClient::initializeLayerTreeView):
382
383 2013-02-11  James Robinson  <jamesr@chromium.org>
384
385         [chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
386         https://bugs.webkit.org/show_bug.cgi?id=109403
387
388         Reviewed by Adam Barth.
389
390         * tests/GraphicsLayerChromiumTest.cpp:
391         (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
392         * tests/ScrollingCoordinatorChromiumTest.cpp:
393         (WebKit::FakeWebViewClient::initializeLayerTreeView):
394
395 2013-02-11  Sheriff Bot  <webkit.review.bot@gmail.com>
396
397         Unreviewed.  Rolled Chromium DEPS to r181817.  Requested by
398         "James Robinson" <jamesr@chromium.org> via sheriffbot.
399
400         * DEPS:
401
402 2013-02-11  David Grogan  <dgrogan@chromium.org>
403
404         IndexedDB: Add UnknownError to WebIDBDatabaseException
405         https://bugs.webkit.org/show_bug.cgi?id=109519
406
407         Reviewed by Adam Barth.
408
409         * public/WebIDBDatabaseException.h:
410         * src/AssertMatchingEnums.cpp:
411
412 2013-02-11  Sheriff Bot  <webkit.review.bot@gmail.com>
413
414         Unreviewed.  Rolled Chromium DEPS to r181787.  Requested by
415         thakis_ via sheriffbot.
416
417         * DEPS:
418
419 2013-02-11  Nico Weber  <thakis@chromium.org>
420
421         Remove web intents code
422         https://bugs.webkit.org/show_bug.cgi?id=109501
423
424         Reviewed by Eric Seidel.
425
426         See thread "Removing ENABLE(WEB_INTENTS) code" on webkit-dev.
427
428         * WebKit.gyp:
429         * features.gypi:
430         * public/WebDeliveredIntentClient.h: Removed.
431         * public/WebFrame.h:
432         (WebKit):
433         (WebFrame):
434         * public/WebFrameClient.h:
435         (WebKit):
436         * public/WebIntent.h: Removed.
437         * public/WebIntentRequest.h: Removed.
438         * public/WebIntentServiceInfo.h: Removed.
439         * public/WebRuntimeFeatures.h:
440         (WebRuntimeFeatures):
441         * src/DeliveredIntentClientImpl.cpp: Removed.
442         * src/DeliveredIntentClientImpl.h: Removed.
443         * src/FrameLoaderClientImpl.cpp:
444         * src/FrameLoaderClientImpl.h:
445         (FrameLoaderClientImpl):
446         * src/WebFrameImpl.cpp:
447         * src/WebFrameImpl.h:
448         (WebKit):
449         (WebFrameImpl):
450         * src/WebIntent.cpp: Removed.
451         * src/WebIntentRequest.cpp: Removed.
452         * src/WebIntentServiceInfo.cpp: Removed.
453         * src/WebRuntimeFeatures.cpp:
454
455 2013-02-11  Florin Malita  <fmalita@chromium.org>
456
457         Unreviewed.  Rolled Chromium DEPS to r181770.
458
459         * DEPS:
460
461 2013-02-11  Sheriff Bot  <webkit.review.bot@gmail.com>
462
463         Unreviewed.  Rolled Chromium DEPS to r181742.  Requested by
464         fmalita_ via sheriffbot.
465
466         * DEPS:
467
468 2013-02-11  Rouslan Solomakhin  <rouslan@chromium.org>
469
470         [Chromium] Replace correct misspelled range in WebKit::WebFrameImpl::replaceMisspelledRange
471         https://bugs.webkit.org/show_bug.cgi?id=108513
472
473         Reviewed by Tony Chang.
474
475         WebKit::WebFrameImpl::replaceMisspelledRange is going to be used by Chromium instead of
476         WebKit::WebFrameImpl::replaceSelection for correcting misspellings. The current implementation
477         of WebKit::WebFrameImpl::replaceMisspelledRange sometimes replaces the wrong range. This change
478         uses Range::create instead of TextIterator::rangeFromLocationAndLength to select the correct
479         range. This change also disables smart replace in WebKit::WebFrameImpl::replaceMisspelledRange
480         to avoid introducing spaces around misspellings.
481
482         * src/WebFrameImpl.cpp:
483         (WebKit::WebFrameImpl::replaceMisspelledRange): Replace correct misspelled range.
484         * tests/WebFrameTest.cpp: Add unit test for WebKit::WebFrameImpl::replaceMisspelledRange method.
485
486 2013-02-11  Alexei Filippov  <alph@chromium.org>
487
488         Web Inspector: Split Profiler domain in protocol into Profiler and HeapProfiler
489         https://bugs.webkit.org/show_bug.cgi?id=108653
490
491         Reviewed by Yury Semikhatsky.
492
493         Currently CPU and heap profilers share the same domain 'Profiler' in the protocol.
494         In fact these two profile types have not too much in common. So put each into its own domain.
495         It should also help when Profiles panel gets split into several tools.
496         This is the phase 1 which adds InspectorHeapProfilerAgent but doesn't
497         change the original InspectorProfilerAgent.
498
499         * src/WebDevToolsAgentImpl.cpp:
500         (WebKit::WebDevToolsAgent::shouldInterruptForMessage):
501
502 2013-02-11  Abhishek Arya  <inferno@chromium.org>
503
504         Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
505         https://bugs.webkit.org/show_bug.cgi?id=108981
506
507         Reviewed by Eric Seidel.
508
509         * src/AutofillPopupMenuClient.cpp:
510         (WebKit::AutofillPopupMenuClient::getSuggestion):
511         (WebKit::AutofillPopupMenuClient::getLabel):
512         (WebKit::AutofillPopupMenuClient::getIcon):
513         (WebKit::AutofillPopupMenuClient::removeSuggestionAtIndex):
514         (WebKit::AutofillPopupMenuClient::valueChanged):
515         (WebKit::AutofillPopupMenuClient::selectionChanged):
516         * src/ChromeClientImpl.cpp:
517         (WebKit::ChromeClientImpl::shouldRunModalDialogDuringPageDismissal):
518
519 2013-02-10  James Robinson  <jamesr@chromium.org>
520
521         [chromium] Enable more of webkit_unit_tests in component builds
522         https://bugs.webkit.org/show_bug.cgi?id=109369
523
524         Reviewed by Darin Fisher.
525
526         Updates all webkit_unit_tests (except for LevelDBTest) to go through the Platform API instead of directly
527         calling into webkit_support so they work in component builds.
528
529         * WebKit.gyp:
530         * tests/AssociatedURLLoaderTest.cpp:
531         * tests/EventListenerTest.cpp:
532         * tests/FrameTestHelpers.cpp:
533         (WebKit::FrameTestHelpers::createWebViewAndLoad):
534         (QuitTask):
535         (WebKit::FrameTestHelpers::QuitTask::run):
536         (FrameTestHelpers):
537         (WebKit::FrameTestHelpers::runPendingTasks):
538         * tests/FrameTestHelpers.h:
539         (FrameTestHelpers):
540         * tests/ListenerLeakTest.cpp:
541         * tests/PopupMenuTest.cpp:
542         * tests/PrerenderingTest.cpp:
543         * tests/ScrollingCoordinatorChromiumTest.cpp:
544         (WebKit::ScrollingCoordinatorChromiumTest::~ScrollingCoordinatorChromiumTest):
545         (WebKit::ScrollingCoordinatorChromiumTest::navigateTo):
546         * tests/URLTestHelpers.cpp:
547         (WebKit::URLTestHelpers::registerMockedURLLoad):
548         * tests/WebFrameTest.cpp:
549         * tests/WebImageTest.cpp:
550         (WebKit::readFile):
551         * tests/WebPageNewSerializerTest.cpp:
552         * tests/WebPageSerializerTest.cpp:
553         * tests/WebPluginContainerTest.cpp:
554         (WebKit::WebPluginContainerTest::TearDown):
555         (WebKit::TEST_F):
556         * tests/WebViewTest.cpp:
557
558 2013-02-10  Sheriff Bot  <webkit.review.bot@gmail.com>
559
560         Unreviewed.  Rolled Chromium DEPS to r181645.  Requested by
561         "James Robinson" <jamesr@chromium.org> via sheriffbot.
562
563         * DEPS:
564
565 2013-02-09  Stephen Chenney  <schenney@chromium.org>
566
567         Unreviewed.  Rolled Chromium DEPS to last-known good revision. Really this time.
568
569         * DEPS: 181594
570
571 2013-02-09  Sheriff Bot  <webkit.review.bot@gmail.com>
572
573         Unreviewed.  Rolled Chromium DEPS to last-known good revision.
574         Requested by "Stephen Chenney" <schenney@chromium.org> via
575         sheriffbot.
576
577         * DEPS:
578
579 2013-02-08  Kent Tamura  <tkent@chromium.org>
580
581         [Chromium] Disable ENABLE_INPUT_TYPE_DATETIME
582         https://bugs.webkit.org/show_bug.cgi?id=109272
583
584         Reviewed by Kentaro Hara.
585
586         We enabled this flag for desktop Chromium, but disabled the feature by a
587         runtime flag. We disables the compile flag too because we have no plan
588         to ship it in near future.
589
590         * features.gypi: Remove ENABLE_INPUT_TYPE_DATETIME.
591
592 2013-02-08  Stephen Chenney  <schenney@chromium.org>
593
594         Remove Skia code suppressions
595
596         Unreviewed enabling of existing optimizations
597
598         Removing all skia_webkit.gyp code suppressions and adding expectations
599         for the failures.
600
601         * skia_webkit.gyp:
602
603 2013-02-08  Dan Carney  <dcarney@google.com>
604
605         [v8] isolate parameter added to all v8::peristent calls
606         https://bugs.webkit.org/show_bug.cgi?id=109268
607
608         Reviewed by Kentaro Hara.
609
610         * tests/WebFrameTest.cpp:
611
612 2013-02-07  Kent Tamura  <tkent@chromium.org>
613
614         [Chromium-Android] Disable input[type=datetime]
615         https://bugs.webkit.org/show_bug.cgi?id=107614
616
617         Reviewed by Kentaro Hara.
618
619         Reason:
620         http://lists.webkit.org/pipermail/webkit-dev/2013-January/023404.html
621
622         * features.gypi:
623         Disable ENABLE_INPUT_TYPE_DATETIME because of a wrong UI.
624         We enable it for non-Android ports but the runtime flag for it is
625         disabled by default. The runtime flag is enabled only in DumpRenderTree.
626
627 2013-02-07  Terry Anderson  <tdanderson@chromium.org>
628
629         [chromium] Flings should not bubble up to enclosing scrollables when main-thread touch scrolling
630         https://bugs.webkit.org/show_bug.cgi?id=108719
631
632         Reviewed by Eric Seidel.
633
634         In the event of a main-thread touch fling, dispatch a series of
635         GestureScrollUpdateWithoutPropagation events defined in
636         https://bugs.webkit.org/show_bug.cgi?id=108849 (instead of
637         GestureScrollUpdate events) so that the fling does not
638         propagate to enclosing scrollables.
639
640         * src/WebViewImpl.cpp:
641         (WebKit::WebViewImpl::scrollBy):
642
643 2013-02-07  Kent Tamura  <tkent@chromium.org>
644
645         [Chromium] Add a flag to enable native form validation message
646         https://bugs.webkit.org/show_bug.cgi?id=109134
647
648         Reviewed by Adam Barth.
649
650         * public/WebRuntimeFeatures.h:
651         (WebRuntimeFeatures): Add enableNativeValidationMessage and
652         isNativeValidationMessageEnabled.
653         * src/WebRuntimeFeatures.cpp:
654         (WebKit): Add nativeValidationMessageEnabled.
655         (WebKit::WebRuntimeFeatures::enableNativeValidationMessage): Added.
656         (WebKit::WebRuntimeFeatures::isNativeValidationMessageEnabled): Addedd.
657         * src/WebViewImpl.cpp:
658         (WebKit::WebViewImpl::WebViewImpl):
659         Fill Page::PageClients::validationMessageClient if the flag is true.
660
661 2013-02-07  Eberhard Graether  <egraether@google.com>
662
663         Web Inspector: Add settings checkbox for composited layer borders
664         https://bugs.webkit.org/show_bug.cgi?id=109096
665
666         Reviewed by Pavel Feldman.
667
668         This change adds a checkbox to show composited layer borders to the WebInspector's
669         rendering settings and plumbs the setting to Chromium's WebLayerTreeView. The setting
670         is visible if InspectorClient::canShowDebugBorders() returns true.
671
672         * src/InspectorClientImpl.cpp:
673         (WebKit::InspectorClientImpl::canShowDebugBorders):
674         (WebKit):
675         (WebKit::InspectorClientImpl::setShowDebugBorders):
676         * src/InspectorClientImpl.h:
677         (InspectorClientImpl):
678         * src/WebViewImpl.cpp:
679         (WebKit::WebViewImpl::WebViewImpl):
680         (WebKit::WebViewImpl::setShowDebugBorders):
681         (WebKit):
682         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
683         * src/WebViewImpl.h:
684
685 2013-02-07  Stephen White  <senorblanco@chromium.org>
686
687         Unreviewed.  Rolled DEPS.
688
689         * DEPS:
690
691 2013-02-07  David Trainor  <dtrainor@chromium.org>
692
693         Add null check to editable in moveCaretSelectionTowardsWindowPoint
694         https://bugs.webkit.org/show_bug.cgi?id=108962
695
696         Reviewed by Eric Seidel.
697
698         * src/WebFrameImpl.cpp:
699         (WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):
700         * tests/WebFrameTest.cpp:
701
702 2013-02-07  Sheriff Bot  <webkit.review.bot@gmail.com>
703
704         Unreviewed.  Rolled Chromium DEPS to r180752.  Requested by
705         thakis_ via sheriffbot.
706
707         * DEPS:
708
709 2013-02-06  Terry Anderson  <tdanderson@chromium.org>
710
711         Add support for gesture scroll events that do not propagate to enclosing scrollables
712         https://bugs.webkit.org/show_bug.cgi?id=108849
713
714         Reviewed by Antonio Gomes.
715
716         Define the new event type GestureScrollUpdateWithoutPropagation.
717
718         * public/WebInputEvent.h:
719         (WebKit::WebInputEvent::isGestureEventType):
720         * src/PageWidgetDelegate.cpp:
721         (WebKit::PageWidgetDelegate::handleInputEvent):
722         * src/WebInputEventConversion.cpp:
723         (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
724         * src/WebPluginContainerImpl.cpp:
725         * src/WebPopupMenuImpl.cpp:
726         (WebKit::WebPopupMenuImpl::handleInputEvent):
727         * src/WebViewImpl.cpp:
728         (WebKit::WebViewImpl::handleGestureEvent):
729
730 2013-02-06  Alexandre Elias  <aelias@chromium.org>
731
732         Make ScrollView::paint() clip by visibleContentRect
733         https://bugs.webkit.org/show_bug.cgi?id=108888
734
735         Reviewed by Levi Weintraub.
736
737         When applyPageScaleFactorInCompositor or fixedVisibleContentRect
738         are used, frameRect() and visibleContentRect(true).size() are
739         no longer synonyms, and the latter is the one that should be
740         used for clipping paints.
741
742         New WebFrameTest: pageScaleFactorScalesPaintClip.
743
744         * tests/WebFrameTest.cpp:
745
746 2013-02-06  Sheriff Bot  <webkit.review.bot@gmail.com>
747
748         Unreviewed, rolling out r142025.
749         http://trac.webkit.org/changeset/142025
750         https://bugs.webkit.org/show_bug.cgi?id=109091
751
752         broke the build (Requested by tdanderson on #webkit).
753
754         * public/WebInputEvent.h:
755         (WebKit::WebInputEvent::isGestureEventType):
756         * src/PageWidgetDelegate.cpp:
757         (WebKit::PageWidgetDelegate::handleInputEvent):
758         * src/WebInputEventConversion.cpp:
759         (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
760         * src/WebPluginContainerImpl.cpp:
761         * src/WebPopupMenuImpl.cpp:
762         (WebKit::WebPopupMenuImpl::handleInputEvent):
763         * src/WebViewImpl.cpp:
764         (WebKit::WebViewImpl::handleGestureEvent):
765
766 2013-02-06  Daniel Cheng  <dcheng@google.com>
767
768         [chromium] Remove "config.h" header from WebUnitTests.cpp
769         https://bugs.webkit.org/show_bug.cgi?id=108966
770
771         Reviewed by Tony Chang.
772
773         This file includes headers from base/ in Chromium, and config.h
774         conflicts with base/logging.h. Rather than teaching certain files in
775         base/ not to #include base/logging.h, remove the config.h include
776         here. The ASSERT isn't really necessary, as attempting to run a null
777         test suite won't go very far anyway.
778
779         * tests/WebUnitTests.cpp:
780         (WebKit::RunAllUnitTests):
781
782 2013-02-06  Terry Anderson  <tdanderson@chromium.org>
783
784         Add support for gesture scroll events that do not propagate to enclosing scrollables
785         https://bugs.webkit.org/show_bug.cgi?id=108849
786
787         Reviewed by Antonio Gomes.
788
789         Define the new event type GestureScrollUpdateWithoutPropagation.
790
791         * public/WebInputEvent.h:
792         (WebKit::WebInputEvent::isGestureEventType):
793         * src/PageWidgetDelegate.cpp:
794         (WebKit::PageWidgetDelegate::handleInputEvent):
795         * src/WebInputEventConversion.cpp:
796         (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
797         * src/WebPluginContainerImpl.cpp:
798         * src/WebPopupMenuImpl.cpp:
799         (WebKit::WebPopupMenuImpl::handleInputEvent):
800         * src/WebViewImpl.cpp:
801         (WebKit::WebViewImpl::handleGestureEvent):
802
803 2013-02-06  Chris Hopman  <cjhopman@chromium.org>
804
805         [Chromium] WebWidget should expose a way to determine the start/end of the selection bounds
806         https://bugs.webkit.org/show_bug.cgi?id=108667
807
808         Reviewed by Darin Fisher.
809
810         WebWidget::selectionBounds() returns the anchor and focus of the
811         selection. This matches the arguments to WebFrame::selectRange().
812         Add WebWidget::isSelectionAnchorFirst so that a caller can convert the
813         anchor/focus to start/end.
814
815         * public/WebWidget.h:
816         (WebWidget):
817         (WebKit::WebWidget::isSelectionAnchorFirst):
818         * src/WebViewImpl.cpp:
819         (WebKit::WebViewImpl::isSelectionAnchorFirst):
820         (WebKit):
821         * src/WebViewImpl.h:
822         * tests/WebViewTest.cpp:
823
824 2013-02-06  Alec Flett  <alecflett@chromium.org>
825
826         IndexedDB: Stub out SharedBuffer version of put()
827         https://bugs.webkit.org/show_bug.cgi?id=108986
828
829         Reviewed by Darin Fisher.
830
831         This is part 1 of 3 to replace Vector<uint8_t> with SharedBuffer.
832
833         * public/WebIDBDatabase.h:
834         (WebKit):
835         (WebKit::WebIDBDatabase::put):
836
837 2013-02-06  Stephen Chenney  <schenney@chromium.org>
838
839         Add Skia code suppression flags to WebKit skia.gyp
840
841         Unreviewed.
842
843         This is step one in removing these flags. First we get them into
844         WebKit, then we can remove them from Chrome.
845
846         * skia_webkit.gyp:
847
848 2013-02-06  Mike West  <mkwst@chromium.org>
849
850         Add an ENABLE_NOSNIFF feature flag.
851         https://bugs.webkit.org/show_bug.cgi?id=109029
852
853         Reviewed by Jochen Eisinger.
854
855         This new flag will control the behavior of 'X-Content-Type-Options: nosniff'
856         when processing script and other resource types.
857
858         * features.gypi:
859
860 2013-02-05  David Dorwin  <ddorwin@chromium.org>
861
862         [chromium] Explicitly destroy the WebMediaPlayer in WebMediaPlayerClientImpl's destructor
863         https://bugs.webkit.org/show_bug.cgi?id=108989
864
865         Reviewed by Kent Tamura.
866
867         * src/WebMediaPlayerClientImpl.cpp:
868         (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
869
870 2013-02-04  Kentaro Hara  <haraken@chromium.org>
871
872         [V8] Reduce usage of deprecatedString() and deprecatedInteger()
873         https://bugs.webkit.org/show_bug.cgi?id=108909
874
875         Reviewed by Adam Barth.
876
877         No tests. No change in behavior.
878
879         * src/WebBindings.cpp:
880         (WebKit::WebBindings::toV8Value):
881
882 2013-02-05  Kentaro Hara  <haraken@chromium.org>
883
884         [V8] Make an Isolate parameter mandatory in HasInstance()
885         https://bugs.webkit.org/show_bug.cgi?id=108917
886
887         Reviewed by Adam Barth.
888
889         Because these methods do not have an Isolate, we have to call
890         v8::Isolate::GetCurrent().
891
892         No tests. No change in behavior.
893
894         * src/WebArrayBuffer.cpp:
895         (WebKit::WebArrayBuffer::createFromV8Value):
896         * src/WebArrayBufferView.cpp:
897         (WebKit::WebArrayBufferView::createFromV8Value):
898         * src/WebBindings.cpp:
899         (WebKit::getRangeImpl):
900         (WebKit::getNodeImpl):
901         (WebKit::getElementImpl):
902         (WebKit::getArrayBufferImpl):
903         (WebKit::getArrayBufferViewImpl):
904         (WebKit::WebBindings::getRange):
905         (WebKit::WebBindings::getArrayBuffer):
906         (WebKit::WebBindings::getArrayBufferView):
907         (WebKit::WebBindings::getNode):
908         (WebKit::WebBindings::getElement):
909
910 2013-02-05  Dana Jansens  <danakj@chromium.org>
911
912         [chromium] Provide compositor offscreen context through the WebLayerTreeViewClient interface
913         https://bugs.webkit.org/show_bug.cgi?id=107776
914
915         Reviewed by James Robinson.
916
917         * WebKit.gyp:
918         * src/WebGraphicsContext3D.cpp: Removed.
919
920 2013-02-05  Mark Lam  <mark.lam@apple.com>
921
922         Introduced back-end database classes + a few small fixes.
923         https://bugs.webkit.org/show_bug.cgi?id=108759.
924
925         Reviewed by Brady Eidson.
926
927         * src/DatabaseObserver.cpp:
928         (WebCore::DatabaseObserver::databaseOpened):
929         (WebCore::DatabaseObserver::databaseModified):
930         (WebCore::DatabaseObserver::databaseClosed):
931
932 2013-02-05  Adam Barth  <abarth@webkit.org>
933
934         DumpRenderTree should be able to enable the threaded parser
935         https://bugs.webkit.org/show_bug.cgi?id=108970
936
937         Reviewed by Eric Seidel.
938
939         * public/WebSettings.h:
940         * src/WebSettingsImpl.cpp:
941         (WebKit::WebSettingsImpl::setThreadedHTMLParser):
942         (WebKit):
943         * src/WebSettingsImpl.h:
944         (WebSettingsImpl):
945
946 2013-02-05  Sami Kyostila  <skyostil@chromium.org>
947
948         [chromium] Make overlay layers slow-scrolling
949         https://bugs.webkit.org/show_bug.cgi?id=108957
950
951         Reviewed by James Robinson.
952
953         Since overlay layers get inserted on top of everything else, we must
954         mark them slow-scrolling to prevent all scroll input events to the rest
955         of the page from getting blocked. This is also more correct because
956         generally the overlay contents need to be repainted whenever the scroll
957         offset changes, and with this patch the painting happens in sync with
958         page scrolling.
959
960 2013-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
961
962         Unreviewed, rolling out r141896.
963         http://trac.webkit.org/changeset/141896
964         https://bugs.webkit.org/show_bug.cgi?id=108956
965
966         crashes indexdb security tests (Requested by gavinp on
967         #webkit).
968
969         * public/platform/WebKitPlatformSupport.h:
970         (WebKit):
971         (WebKitPlatformSupport):
972         (WebKit::WebKitPlatformSupport::idbFactory):
973         * src/IDBFactoryBackendProxy.cpp:
974         (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
975
976 2013-02-05  Mark Pilgrim  <pilgrim@chromium.org>
977
978         [Chromium] Remove idbFactory from WebKitPlatformSupport
979         https://bugs.webkit.org/show_bug.cgi?id=106457
980
981         Reviewed by Adam Barth.
982
983         Now that https://codereview.chromium.org/12181010/ has landed, the
984         idbFactory method is no longer needed. (Embedders must now call
985         the new setIDBFactory method upon initialization.) Part of a
986         larger refactoring series; see tracking bug 82948.
987
988         * public/platform/WebKitPlatformSupport.h:
989         (WebKit):
990         * src/IDBFactoryBackendProxy.cpp:
991         (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
992
993 2013-02-05  Kentaro Hara  <haraken@chromium.org>
994
995         Unreviewed, rolling out r141865.
996         http://trac.webkit.org/changeset/141865
997         https://bugs.webkit.org/show_bug.cgi?id=108909
998
999         webkit unit tests are broken
1000
1001         * src/WebBindings.cpp:
1002         (WebKit::WebBindings::toV8Value):
1003
1004 2013-02-05  Kentaro Hara  <haraken@chromium.org>
1005
1006         [V8] Reduce usage of deprecatedString() and deprecatedInteger()
1007         https://bugs.webkit.org/show_bug.cgi?id=108909
1008
1009         Reviewed by Adam Barth.
1010
1011         No tests. No change in behavior.
1012
1013         * src/WebBindings.cpp:
1014         (WebKit::WebBindings::toV8Value):
1015
1016 2013-02-04  Sheriff Bot  <webkit.review.bot@gmail.com>
1017
1018         Unreviewed.  Rolled Chromium DEPS to r180583.  Requested by
1019         "Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.
1020
1021         * DEPS:
1022
1023 2013-02-04  James Simonsen  <simonjam@chromium.org>
1024
1025         [Chromium] Add a signal for when the body is inserted in the document
1026         https://bugs.webkit.org/show_bug.cgi?id=108725
1027
1028         Reviewed by Adam Barth.
1029
1030         * public/WebFrameClient.h:
1031         (WebFrameClient):
1032         (WebKit::WebFrameClient::willInsertBody):
1033         * src/FrameLoaderClientImpl.cpp:
1034         (WebKit::FrameLoaderClientImpl::dispatchWillInsertBody):
1035         (WebKit):
1036         * src/FrameLoaderClientImpl.h:
1037         (FrameLoaderClientImpl):
1038         * tests/WebFrameTest.cpp:
1039
1040 2013-02-04  Chris Hopman  <cjhopman@chromium.org>
1041
1042         Make moveCaretTowardsWindowPoint not snap to the beginning/end when moved above/below editable
1043         https://bugs.webkit.org/show_bug.cgi?id=107850
1044
1045         Reviewed by Ojan Vafai.
1046
1047         On Android, EditingBehavior::shouldMoveCaret[...] controls the
1048         behavior of insertion handles. This change adds a new Android specific
1049         editing behavior type so that we can change these settings independent
1050         of behavior for other platforms.
1051
1052         * public/WebSettings.h:
1053         * src/AssertMatchingEnums.cpp:
1054         Just add the corresponding assertion for the new editing behavior.
1055
1056         * public/WebSettings.h:
1057         * src/AssertMatchingEnums.cpp:
1058
1059         * tests/WebFrameTest.cpp:
1060         * tests/data/move_caret.html: Added.
1061         Add a test that moveCaretTowardsWindowPoint works as expected on
1062         Android.
1063
1064 2013-01-31  Kentaro Hara  <haraken@chromium.org>
1065
1066         Implement WheelEvent::deltaMode
1067         https://bugs.webkit.org/show_bug.cgi?id=108455
1068
1069         Reviewed by Adam Barth.
1070
1071         * src/WebInputEventConversion.cpp:
1072         (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
1073
1074 2013-02-04  Mark Pilgrim  <pilgrim@chromium.org>
1075
1076         [Chromium] Move WorkerContextProxy to WebCore
1077         https://bugs.webkit.org/show_bug.cgi?id=108847
1078
1079         Reviewed by Adam Barth.
1080
1081         Part of a larger refactoring series; see tracking bug 106829.
1082
1083         * WebKit.gyp:
1084         * src/WebKit.cpp:
1085         (WebKit::initializeWithoutV8):
1086         * src/WorkerContextProxy.cpp: Removed.
1087
1088 2013-02-04  Abhishek Arya  <inferno@chromium.org>
1089
1090         Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
1091         https://bugs.webkit.org/show_bug.cgi?id=108668
1092
1093         Reviewed by Eric Seidel.
1094
1095         * src/ContextFeaturesClientImpl.cpp:
1096         (WebKit::ContextFeaturesCache::entryFor):
1097         * src/WebFrameImpl.cpp:
1098         (WebKit::WebFrameImpl::selectFindMatch):
1099
1100 2013-02-04  Mark Pilgrim  <pilgrim@chromium.org>
1101
1102         [Chromium] Move IDBFactoryBackendInterface to WebCore
1103         https://bugs.webkit.org/show_bug.cgi?id=108638
1104
1105         Reviewed by Adam Barth.
1106
1107         Part of a larger refactoring series; see tracking bug 106829.
1108
1109         * WebKit.gyp:
1110         * src/AssertMatchingEnums.cpp:
1111         * src/IDBFactoryBackendInterface.cpp: Removed.
1112         * src/IDBFactoryBackendProxy.h:
1113         * src/WebKit.cpp:
1114         (WebKit::initializeWithoutV8):
1115
1116 2013-02-04  Abhishek Arya  <inferno@chromium.org>
1117
1118         Add ASSERT_WITH_SECURITY_IMPLICATION to detect bad cast in DOM, CSS, etc.
1119         https://bugs.webkit.org/show_bug.cgi?id=108688
1120
1121         Reviewed by Eric Seidel.
1122
1123         * src/IDBFactoryBackendProxy.cpp:
1124         (WebKit::IDBFactoryBackendProxy::allowIndexedDB):
1125         (WebKit::getWebFrame):
1126         * src/LocalFileSystemChromium.cpp:
1127         (WebCore::LocalFileSystem::deleteFileSystem):
1128         * src/WebSharedWorkerImpl.cpp:
1129         (WebKit::WebSharedWorkerImpl::connectTask):
1130         (WebKit::resumeWorkerContextTask):
1131         (WebKit::connectToWorkerContextInspectorTask):
1132         (WebKit::reconnectToWorkerContextInspectorTask):
1133         (WebKit::disconnectFromWorkerContextInspectorTask):
1134         (WebKit::dispatchOnInspectorBackendTask):
1135
1136 2013-02-04  Sami Kyostila  <skyostil@chromium.org>
1137
1138         Disable -webkit-overflow-scrolling CSS attribute on Chromium
1139         https://bugs.webkit.org/show_bug.cgi?id=108020
1140
1141         Reviewed by James Robinson.
1142
1143         Now that we can automatically promote overflow elements to accelerated
1144         scrolling layers there is no use for the -webkit-overflow-scrolling CSS
1145         attribute any longer on Chromium.
1146
1147         This patch enables composited overflow scrolling in
1148         ScrollingCoordinatorChromiumTest. Because this also causes the overflow div
1149         in non-fast-scrollable.html to become composited, we also need to modify that
1150         test to opt it out of composited scrolling.
1151
1152         * features.gypi:
1153         * tests/ScrollingCoordinatorChromiumTest.cpp:
1154         (WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
1155         (WebKit::TEST_F):
1156         * tests/data/non-fast-scrollable.html:
1157         * tests/data/overflow-scrolling.html: Renamed from Source/WebKit/chromium/tests/data/touch-overflow-scrolling.html.
1158
1159 2013-02-03  KwangYong Choi  <ky0.choi@samsung.com>
1160
1161         Fix build warning after r141473
1162         https://bugs.webkit.org/show_bug.cgi?id=108782
1163
1164         Reviewed by Kentaro Hara.
1165
1166         Fix -Wunused-parameter build warning.
1167
1168         * src/EditorClientImpl.cpp:
1169         (WebKit::EditorClientImpl::getClientPasteboardDataForRange):
1170
1171 2013-02-03  David Dorwin  <ddorwin@chromium.org>
1172
1173         [chromium] Do not call m_widgetClient->show() for WebHelperPlugin.
1174         https://bugs.webkit.org/show_bug.cgi?id=108740
1175
1176         Reviewed by Kent Tamura.
1177
1178         The calls to m_widgetClient->show() and setFocus() do not appear to be
1179         necessary, and the former causes problems on at least on platform.
1180
1181         * src/WebHelperPluginImpl.cpp:
1182         (WebKit::WebHelperPluginImpl::initialize): Removed calls to m_widgetClient->show() and setFocus().
1183         (WebKit::WebHelperPluginImpl::setFocus): Should never be called.
1184
1185 2013-02-02  Michael Nordman  <michaeln@google.com>
1186
1187         [chromium] FileSystem mods: Changes to snapshot file creation to reduce dependencies on blobs.
1188         This patch just alters the WebKitAPI in advance of coding to the new API in chromium and webkit
1189         sources, defining two new virtual methods (unimplemented and uncalled). The existing API remains
1190         in place and in use.
1191         https://bugs.webkit.org/show_bug.cgi?id=108736
1192
1193         Reviewed by Darin Fisher.
1194
1195         * public/WebFileSystemCallbacks.h:
1196         (WebFileSystemCallbacks):
1197         (WebKit::WebFileSystemCallbacks::didCreateSnapshotFile):
1198
1199 2013-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1200
1201         Unreviewed.  Rolled Chromium DEPS to r180221.  Requested by
1202         "Nico Weber" <thakis@chromium.org> via sheriffbot.
1203
1204         * DEPS:
1205
1206 2013-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1207
1208         Unreviewed.  Rolled Chromium DEPS to r180186.  Requested by
1209         "Nico Weber" <thakis@chromium.org> via sheriffbot.
1210
1211         * DEPS:
1212
1213 2013-02-01  Chris Hopman  <cjhopman@chromium.org>
1214
1215         [Chromium] WebWidget::selectionBounds should return the bounds in document space
1216         https://bugs.webkit.org/show_bug.cgi?id=108386
1217
1218         Reviewed by James Robinson.
1219
1220         When in applyPageScaleFactorInCompositor mode, selectionBounds needs
1221         to scale the anchor/focus window points by the pageScaleFactor.
1222
1223         * src/WebViewImpl.cpp:
1224         (WebKit::WebViewImpl::selectionBounds):
1225         (WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode):
1226
1227 2013-02-01  Dominic Mazzoni  <dmazzoni@google.com>
1228
1229         AX: memoize expensive computation during blocks where tree doesn't change
1230         https://bugs.webkit.org/show_bug.cgi?id=106497
1231
1232         Reviewed by Ryosuke Niwa.
1233
1234         Expose two methods to enable and disable caching of
1235         computed WebAccessibilityObject attributes, to speed up
1236         batch read-only operations.
1237
1238         * public/WebAccessibilityObject.h:
1239         (WebAccessibilityObject):
1240         * src/WebAccessibilityObject.cpp:
1241         (WebKit::WebAccessibilityObject::startCachingComputedObjectAttributesUntilTreeMutates):
1242         (WebKit):
1243         (WebKit::WebAccessibilityObject::stopCachingComputedObjectAttributes):
1244
1245 2013-02-01  Fady Samuel  <fsamuel@chromium.org>
1246
1247         [Chromium] Expose WebNode::shadowHost()
1248         https://bugs.webkit.org/show_bug.cgi?id=108681
1249
1250         Reviewed by Dimitri Glazkov.
1251
1252         BrowserPlugin needs to be able to check the event listeners attached to
1253         <webview> and so we expose shadowHost to permit it to poke at the webview
1254         node.
1255
1256         * public/WebNode.h:
1257         * src/WebNode.cpp:
1258         (WebKit::WebNode::shadowHost):
1259         (WebKit):
1260
1261 2013-02-01  Rouslan Solomakhin  <rouslan@chromium.org>
1262
1263         [Chromium] Ignore punctuation in spellcheck
1264         https://bugs.webkit.org/show_bug.cgi?id=108511
1265
1266         Reviewed by Tony Chang.
1267
1268         * src/ContextMenuClientImpl.cpp:
1269         (WebKit::IsWhiteSpaceOrPunctuation): Added utility function to detect whitespace or punctuation.
1270         (WebKit::selectMisspellingAsync): Ignore punctuation when selecting the misspelling.
1271
1272 2013-02-01  Philip Rogers  <pdr@google.com>
1273
1274         Change hasAlpha to isKnownToBeOpaque and correct the return value for SVG images.
1275         https://bugs.webkit.org/show_bug.cgi?id=106966
1276
1277         Reviewed by Stephen White.
1278
1279         * tests/DragImageTest.cpp:
1280         (WebCore::TestImage::currentFrameKnownToBeOpaque):
1281         (TestImage):
1282         * tests/ImageLayerChromiumTest.cpp:
1283         (WebCore::TestImage::currentFrameKnownToBeOpaque):
1284         * tests/PlatformContextSkiaTest.cpp:
1285         (WebCore::TEST):
1286
1287 2013-02-01  Nico Weber  <thakis@chromium.org>
1288
1289         [chromium] Build webkit with enable_web_intents set to 0.
1290         https://bugs.webkit.org/show_bug.cgi?id=108408
1291
1292         Reviewed by Tony Chang.
1293
1294         I'll then make chromium build fine with that, then switch
1295         enable_web_intents to 0, roll that into webkit, and then
1296         actually remove the code hidden behind this flag.
1297
1298         The features.gypi bit depends on https://codereview.chromium.org/12143002/
1299         and will disable web intents support on android. Since common.gypi
1300         sets enable_web_intents to 0 explicitly, it seems this is currently on
1301         by accident anyway.
1302
1303         While it looks like this CL just removes ENABLE_WEB_INTENTS=1 from
1304         features.gypi completely, it's still set further down the file if
1305         enable_web_intents is on.
1306
1307         * WebKit.gyp:
1308         * features.gypi:
1309         * src/WebFrameImpl.cpp:
1310
1311 2013-02-01  Rouslan Solomakhin  <rouslan@chromium.org>
1312
1313         [Chromium] Ignore whitespace in spellcheck
1314         https://bugs.webkit.org/show_bug.cgi?id=108510
1315
1316         Reviewed by Ryosuke Niwa.
1317
1318         * src/ContextMenuClientImpl.cpp:
1319         (WebKit::selectMisspellingAsync): Ignore whitespace when selecting the misspelling.
1320
1321 2013-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1322
1323         Unreviewed.  Rolled Chromium DEPS to r180131.  Requested by
1324         "Florin Malita" <fmalita@chromium.org> via sheriffbot.
1325
1326         * DEPS:
1327
1328 2013-02-01  Alexis Menard  <alexis@webkit.org>
1329
1330         Enable unprefixed CSS transitions by default.
1331         https://bugs.webkit.org/show_bug.cgi?id=108216
1332
1333         Reviewed by Dean Jackson.
1334
1335         Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
1336         to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to 
1337         guard the unprefixing work for CSS Transforms and animations.
1338
1339         * features.gypi:
1340
1341 2013-02-01  Ken Kania  <kkania@chromium.org>
1342
1343         Web Inspector: Add support for handling modal dialogs
1344         https://bugs.webkit.org/show_bug.cgi?id=107883
1345
1346         Reviewed by Pavel Feldman.
1347
1348         Introduce support for being notified when a JavaScript modal dialog
1349         is opening and closing, as well as a new command for accepting or
1350         dismissing the dialog.
1351
1352         * public/WebDevToolsAgent.h:
1353         * src/InspectorClientImpl.cpp:
1354         (WebKit::InspectorClientImpl::handleJavaScriptDialog):
1355         (WebKit):
1356         * src/InspectorClientImpl.h:
1357         (InspectorClientImpl):
1358         * src/WebDevToolsAgentImpl.cpp:
1359         (BrowserDataHintStringValues):
1360         (WebKit::WebDevToolsAgentImpl::captureScreenshot):
1361         (WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
1362         (WebKit):
1363         (WebKit::browserHintToString):
1364         (WebKit::browserHintFromString):
1365         (WebKit::WebDevToolsAgent::patchWithBrowserData):
1366         * src/WebDevToolsAgentImpl.h:
1367         (WebDevToolsAgentImpl):
1368
1369 2013-02-01  Dan Alcantara  <dfalcantara@chromium.org>
1370
1371         Touch disambiguation blacklist is not being queried properly
1372         https://bugs.webkit.org/show_bug.cgi?id=108222
1373
1374         Reviewed by Adam Barth.
1375
1376         TEST=WebFrameTest::DisambiguationPopupBlacklist
1377
1378         Fix the blacklist so that we check it for the right nodes.
1379         Add a test to check that the blacklist is being built and used
1380         correctly.  Also update the other DisambiguationPopup tests to
1381         use the new page scale method.
1382
1383         * tests/WebFrameTest.cpp:
1384         * tests/data/disambiguation_popup_blacklist.html: Added.
1385
1386 2013-02-01  Eberhard Graether  <egraether@google.com>
1387
1388         [chromium] only show checkboxes for FPS meter and continuous painting when compositing mode is forced
1389         https://bugs.webkit.org/show_bug.cgi?id=108236
1390
1391         Reviewed by Pavel Feldman.
1392
1393         This change hides the checkboxes for FPS meter and continuous painting if compositing mode is not forced.
1394         This way the checkboxes only show up for users that can make use of these features.
1395
1396         * src/InspectorClientImpl.cpp:
1397         (WebKit::InspectorClientImpl::canShowFPSCounter):
1398         (WebKit::InspectorClientImpl::canContinuouslyPaint):
1399
1400 2013-01-31  Aurimas Liutikas  <aurimas@chromium.org>
1401
1402         Editor::m_compositionNode not updated on HTMLInputElement::setValue()
1403         https://bugs.webkit.org/show_bug.cgi?id=107737
1404
1405         Reviewed by Ryosuke Niwa.
1406
1407         * public/WebViewClient.h:
1408         (WebKit::WebViewClient::didCancelCompositionOnSelectionChange):
1409             Adding a callback to let the WebViewClient know that the composition has been cancelled.
1410         * src/EditorClientImpl.cpp:
1411         (WebKit::EditorClientImpl::respondToChangedSelection):
1412             Adding a call composition if it is no longer valid.
1413
1414 2013-01-31  Aurimas Liutikas  <aurimas@chromium.org>
1415
1416         [Chromium] WebViewTest.SetCompositionFromExistingText failing after r141479
1417         https://bugs.webkit.org/show_bug.cgi?id=108543
1418
1419         Reviewed by Ryosuke Niwa.
1420
1421         Fixing a bug that was uncovered after fixing http://trac.webkit.org/changeset/141479
1422
1423         * src/WebViewImpl.cpp:
1424         (WebKit::WebViewImpl::setCompositionFromExistingText):
1425         * tests/WebViewTest.cpp:
1426             Re-enabling the test
1427
1428 2013-01-31  Hajime Morrita  <morrita@google.com> 
1429
1430         Unreviewed, followup fix for r141535.
1431
1432         * tests/WebFrameTest.cpp:
1433
1434 2013-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1435
1436         Unreviewed.  Rolled Chromium DEPS to r180023.  Requested by
1437         thakis_ via sheriffbot.
1438
1439         * DEPS:
1440
1441 2013-01-31  Hajime Morrita  <morrita@google.com>
1442
1443         Unreviewed, disabling failing test.
1444
1445         * tests/WebFrameTest.cpp:
1446
1447 2013-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1448
1449         Unreviewed, rolling out r141479.
1450         http://trac.webkit.org/changeset/141479
1451         https://bugs.webkit.org/show_bug.cgi?id=108564
1452
1453         breaks chromium test (Requested by morrita on #webkit).
1454
1455         * public/WebViewClient.h:
1456         * src/EditorClientImpl.cpp:
1457         (WebKit::EditorClientImpl::respondToChangedSelection):
1458
1459 2013-01-31  Alec Flett  <alecflett@chromium.org>
1460
1461         IndexedDB: remove old transaction backend bootstrap code
1462         https://bugs.webkit.org/show_bug.cgi?id=103923
1463
1464         Reviewed by Dimitri Glazkov.
1465
1466         Remove all deprecated WebKit APIs from
1467         the IDB backend.
1468
1469         * WebKit.gyp:
1470         * public/WebIDBCallbacks.h:
1471         (WebKit):
1472         * public/WebIDBDatabase.h:
1473         (WebKit):
1474         * public/WebIDBTransaction.h: Removed.
1475         * public/WebIDBTransactionCallbacks.h: Removed.
1476         * src/AssertMatchingEnums.cpp:
1477         * src/IDBCallbacksProxy.cpp:
1478         * src/IDBDatabaseBackendProxy.cpp:
1479         * src/IDBDatabaseBackendProxy.h:
1480         (IDBDatabaseBackendProxy):
1481         * src/IDBTransactionBackendProxy.cpp: Removed.
1482         * src/IDBTransactionBackendProxy.h: Removed.
1483         * src/IDBTransactionCallbacksProxy.cpp: Removed.
1484         * src/IDBTransactionCallbacksProxy.h: Removed.
1485         * src/WebIDBCallbacksImpl.cpp:
1486         * src/WebIDBDatabaseImpl.cpp:
1487         (WebKit):
1488         * src/WebIDBDatabaseImpl.h:
1489         (WebKit):
1490         (WebIDBDatabaseImpl):
1491         * src/WebIDBTransactionCallbacksImpl.cpp: Removed.
1492         * src/WebIDBTransactionCallbacksImpl.h: Removed.
1493         * src/WebIDBTransactionImpl.cpp: Removed.
1494         * src/WebIDBTransactionImpl.h: Removed.
1495         * tests/IDBAbortOnCorruptTest.cpp:
1496         * tests/IDBDatabaseBackendTest.cpp:
1497
1498 2013-01-31  Rouslan Solomakhin  <rouslan@chromium.org>
1499
1500         [Chromium] Select multi-word misspelling on context click
1501         https://bugs.webkit.org/show_bug.cgi?id=108509
1502
1503         Reviewed by Tony Chang.
1504
1505         * src/ContextMenuClientImpl.cpp:
1506         (WebKit):
1507         (WebKit::selectMisspellingAsync): Added utility function to get the misspelling for asynchronous spellcheck.
1508         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Select multi-word misspelling on context click.
1509
1510 2013-01-31  Florin Malita  <fmalita@chromium.org>
1511
1512         [Chromium] Unreviewed gardening.
1513
1514         WebViewTest.SetCompositionFromExistingText failing after r141479.
1515
1516         * tests/WebViewTest.cpp:
1517
1518 2013-01-31  Alexandre Elias  <aelias@chromium.org>
1519
1520         [chromium] Rework page scale factor limits initialization
1521         https://bugs.webkit.org/show_bug.cgi?id=108446
1522
1523         Reviewed by James Robinson.
1524
1525         When loading a page with viewportEnabled, both the limits
1526         specified by the viewport tag and the content width need to be
1527         considered before we initialize the minimum page scale (and
1528         pageScaleFactor itself usually to the same value). The timing has
1529         proven tricky to get correct.
1530
1531         This patch simplifies the flow by computing the
1532         limits only at the end of layouts and at no other time. In combination
1533         with https://bugs.webkit.org/show_bug.cgi?id=107922 which sets
1534         needsLayout() appropriately, this results in a more robust and easy
1535         to understand sequence.
1536
1537         Fixes FixedLayoutInitializeAtMinimumPageScale test.
1538
1539         * src/ChromeClientImpl.cpp:
1540         (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
1541         * src/WebViewImpl.cpp:
1542         (WebKit::WebViewImpl::WebViewImpl):
1543         (WebKit::WebViewImpl::resize):
1544         (WebKit::WebViewImpl::setPageScaleFactorLimits):
1545         (WebKit::WebViewImpl::computePageScaleFactorLimits):
1546         (WebKit::WebViewImpl::layoutUpdated):
1547         (WebKit::WebViewImpl::didChangeContentsSize):
1548         * src/WebViewImpl.h:
1549         (WebKit::WebViewImpl::setInitialPageScaleFactor):
1550         (WebViewImpl):
1551         * tests/WebFrameTest.cpp:
1552
1553 2013-01-31  Aurimas Liutikas  <aurimas@chromium.org>
1554
1555         Editor::m_compositionNode not updated on HTMLInputElement::setValue()
1556         https://bugs.webkit.org/show_bug.cgi?id=107737
1557
1558         Reviewed by Ryosuke Niwa.
1559
1560         * public/WebViewClient.h:
1561         (WebKit::WebViewClient::didCancelCompositionOnSelectionChange):
1562             Adding a callback to let the WebViewClient know that the composition has been cancelled.
1563         * src/EditorClientImpl.cpp:
1564         (WebKit::EditorClientImpl::respondToChangedSelection):
1565             Adding a call composition if it is no longer valid.
1566
1567 2013-01-31  Mark Pilgrim  <pilgrim@chromium.org>
1568
1569         [Chromium] Move LocalizedStrings to WebCore
1570         https://bugs.webkit.org/show_bug.cgi?id=108488
1571
1572         Reviewed by Adam Barth.
1573
1574         Part of a larger refactoring series; see tracking bug 106829.
1575
1576         * WebKit.gyp:
1577         * src/LocalizedStrings.cpp: Removed.
1578
1579 2013-01-31  Enrica Casucci  <enrica@apple.com>
1580
1581         WebKit2: provide new bundle APIs to allow bundle clients to be notified of pasteboard access.
1582         https://bugs.webkit.org/show_bug.cgi?id=108396.
1583         <rdar://problem/12920461>
1584
1585         Reviewed by Alexey Proskuryakov.
1586
1587         Adds stub implementation for WebKit of the new EditorClient methods.
1588
1589         * src/EditorClientImpl.cpp:
1590         (WebKit::EditorClientImpl::willWriteSelectionToPasteboard):
1591         (WebKit::EditorClientImpl::getClientPasteboardDataForRange):
1592         * src/EditorClientImpl.h:
1593
1594 2013-01-31  Chris Hopman  <cjhopman@chromium.org>
1595
1596         [chromium] Make selection handling work in applyPageScaleInCompositor mode
1597         https://bugs.webkit.org/show_bug.cgi?id=107831
1598
1599         Reviewed by Ryosuke Niwa.
1600
1601         These functions expect a window point. When in
1602         applyPageScaleFactorInCompositor mode, the points need to be unscaled
1603         by the page scale factor.
1604
1605         * src/WebFrameImpl.cpp:
1606         (WebKit::WebFrameImpl::selectRange):
1607         (WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):
1608
1609 2013-01-31  Tom Sepez  <tsepez@chromium.org>
1610
1611         [v8] Enable binding integrity on mac
1612         https://bugs.webkit.org/show_bug.cgi?id=108500
1613
1614         Reviewed by Adam Barth.
1615
1616         Patch is correct if existing tests pass without new crashes.
1617         
1618         * features.gypi:
1619         Set ENABLE_BINDING_INTEGRITY=1 when OS=="mac"
1620
1621 2013-01-31  Dan Alcantara  <dfalcantara@chromium.org>
1622
1623         WebFrameTest.DisambiguationPopup is failing
1624         https://bugs.webkit.org/show_bug.cgi?id=108160
1625
1626         Reviewed by Adam Barth.
1627
1628         Fix the unit test so that it is using the right HTML file.
1629
1630         * tests/WebFrameTest.cpp:
1631
1632 2013-01-31  Tony Chang  <tony@chromium.org>
1633
1634         [Chromium] webkit_unit_tests should depend on base/allocator for ASAN
1635         https://bugs.webkit.org/show_bug.cgi?id=108497
1636
1637         Reviewed by James Robinson.
1638
1639         * WebKitUnitTests.gyp:
1640
1641 2013-01-31  Alexandre Elias  <aelias@chromium.org>
1642
1643         Call FrameView::contentsResized() when setting fixed layout size
1644         https://bugs.webkit.org/show_bug.cgi?id=107922
1645
1646         Reviewed by James Robinson.
1647
1648         In fixed layout mode, we should be calling contentsResized() when the
1649         fixed layout size is changed, but not laying out when the visible
1650         content rect changes.
1651
1652         Previously landed as r140869 but was reverted due to a bug in bundled
1653         Chromium-specific code. This patch includes just the minimum needed in
1654         WebCore.
1655
1656         New WebFrameTest: FrameViewNeedsLayoutOnFixedLayoutResize.  Some
1657         flaky and obsolete tests for the old page scale mode are also deleted.
1658
1659         * tests/WebFrameTest.cpp:
1660
1661 2013-01-31  Tommy Widenflycht  <tommyw@google.com>
1662
1663         [chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStreamComponent to WebMediaStream and WebMediaStreamTrack
1664         https://bugs.webkit.org/show_bug.cgi?id=108458
1665
1666         Reviewed by Adam Barth.
1667
1668         Only renames, no other code changes.
1669
1670         * public/WebMediaStreamRegistry.h:
1671         (WebKit):
1672         (WebMediaStreamRegistry):
1673         * public/WebUserMediaRequest.h:
1674         (WebKit):
1675         (WebUserMediaRequest):
1676         * src/WebMediaStreamRegistry.cpp:
1677         (WebKit::WebMediaStreamRegistry::lookupMediaStreamDescriptor):
1678         * src/WebUserMediaRequest.cpp:
1679         (WebKit::WebUserMediaRequest::requestSucceeded):
1680
1681 2013-01-31  Alec Flett  <alecflett@chromium.org>
1682
1683         IndexedDB: Remove WebKit API for old onSuccess/onUpgradeNeeded
1684         https://bugs.webkit.org/show_bug.cgi?id=108399
1685
1686         Reviewed by Dimitri Glazkov.
1687
1688         Cleanup now that chromium proxies the new signatures through.
1689
1690         * src/IDBCallbacksProxy.cpp:
1691         (WebKit::IDBCallbacksProxy::onSuccess):
1692         (WebKit::IDBCallbacksProxy::onUpgradeNeeded):
1693         * src/IDBCallbacksProxy.h:
1694         (IDBCallbacksProxy):
1695         * src/WebIDBCallbacksImpl.cpp:
1696         * src/WebIDBCallbacksImpl.h:
1697         (WebIDBCallbacksImpl):
1698
1699 2013-01-31  James Robinson  <jamesr@chromium.org>
1700
1701         [chromium] Remove dead transitional code from WebViewImpl
1702         https://bugs.webkit.org/show_bug.cgi?id=107889
1703
1704         Reviewed by Adam Barth.
1705
1706         The chromium side of this landed at r178256 and seems stable.
1707
1708         * public/WebWidget.h:
1709         (WebKit::WebWidget::setCompositorSurfaceReady):
1710         * src/WebViewImpl.cpp:
1711         (WebKit::WebViewImpl::WebViewImpl):
1712         (WebKit::WebViewImpl::~WebViewImpl):
1713         (WebKit):
1714         (WebKit::WebViewImpl::setIsTransparent):
1715         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
1716         * src/WebViewImpl.h:
1717         * tests/ScrollingCoordinatorChromiumTest.cpp:
1718         (WebKit::FakeWebViewClient::initializeLayerTreeView):
1719         (FakeWebViewClient):
1720         (WebKit::FakeWebViewClient::layerTreeView):
1721         (WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
1722         (ScrollingCoordinatorChromiumTest):
1723
1724 2013-01-31  Kentaro Hara  <haraken@chromium.org>
1725
1726         Rename WheelEvent::Granularity to WheelEvent::DeltaMode
1727         https://bugs.webkit.org/show_bug.cgi?id=108434
1728
1729         Reviewed by Ryosuke Niwa.
1730
1731         Per the spec, WheelEvent::Granularity should be renamed to WheelEvent::DeltaMode.
1732
1733         Spec: http://www.w3.org/TR/DOM-Level-3-Events/#events-WheelEvent
1734         https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-wheelevent
1735
1736         No tests. No change in behavior.
1737
1738         * src/WebInputEventConversion.cpp:
1739         (WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
1740         (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
1741
1742 2013-01-31  Yury Semikhatsky  <yurys@chromium.org>
1743
1744         Unreviewed. Bump Chromium dependency to 179332
1745
1746         * DEPS:
1747
1748 2013-01-31  Mark Pilgrim  <pilgrim@chromium.org>
1749
1750         [Chromium] Move MediaPlayerPrivateChromium to WebCore
1751         https://bugs.webkit.org/show_bug.cgi?id=108415
1752
1753         Reviewed by Adam Barth.
1754
1755         Part of a larger refactoring series; see tracking bug 106829.
1756
1757         * WebKit.gyp:
1758         * src/MediaPlayerPrivateChromium.cpp: Removed.
1759         * src/WebKit.cpp:
1760         (WebKit::initializeWithoutV8): call new setter function in
1761         WebCore::MediaPlayerPrivate
1762
1763 2013-01-30  Sheriff Bot  <webkit.review.bot@gmail.com>
1764
1765         Unreviewed, rolling out r141358.
1766         http://trac.webkit.org/changeset/141358
1767         https://bugs.webkit.org/show_bug.cgi?id=108421
1768
1769         breaks android builder (Requested by morrita on #webkit).
1770
1771         * WebKit.gyp:
1772         * features.gypi:
1773         * src/WebFrameImpl.cpp:
1774
1775 2013-01-30  Nico Weber  <thakis@chromium.org>
1776
1777         [chromium] Build webkit with enable_web_intents set to 0.
1778         https://bugs.webkit.org/show_bug.cgi?id=108408
1779
1780         Reviewed by Kentaro Hara.
1781
1782         I'll then make chromium build fine with that, then switch
1783         enable_web_intents to 0, roll that into webkit, and then
1784         actually remove the code hidden behind this flag.
1785
1786         * WebKit.gyp:
1787         * features.gypi:
1788         * src/WebFrameImpl.cpp:
1789
1790 2013-01-30  Levi Weintraub  <leviw@chromium.org>
1791
1792         [Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
1793         https://bugs.webkit.org/show_bug.cgi?id=108381
1794
1795         Reviewed by James Robinson.
1796
1797         WebPluginContainerImpl would call Document::didAddTouchEventHandler every time the plugin requested
1798         touch events. Some plugins make this request more than once, leading to an imbalance in Document's
1799         touch event handler map, and a stale node pointer when the plugin is destroyed. This change
1800         has WebPluginContainerImpl only add one ref for the plugin at a time.
1801
1802         * src/WebPluginContainerImpl.cpp:
1803         (WebKit::WebPluginContainerImpl::requestTouchEventType):
1804
1805 2013-01-30  Yusuf Ozuysal  <yusufo@google.com>
1806
1807         Start sending scrollType as NonBubblingGesture for flings
1808         https://bugs.webkit.org/show_bug.cgi?id=108372
1809
1810         Reviewed by James Robinson.
1811
1812         * src/WebCompositorInputHandlerImpl.cpp:
1813         (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
1814
1815 2013-01-30  Tien-Ren Chen  <trchen@chromium.org>
1816
1817         [chromium] Add WebFrame::visibleContentRect()
1818         https://bugs.webkit.org/show_bug.cgi?id=108311
1819
1820         Reviewed by James Robinson.
1821
1822         * public/WebFrame.h:
1823         * src/WebFrameImpl.cpp:
1824         (WebKit::WebFrameImpl::visibleContentRect):
1825         (WebKit):
1826         * src/WebFrameImpl.h:
1827         (WebFrameImpl):
1828
1829 2013-01-30  Kentaro Hara  <haraken@chromium.org>
1830
1831         Implement KeyboardEvent constructor
1832         https://bugs.webkit.org/show_bug.cgi?id=108320
1833
1834         Reviewed by Adam Barth.
1835
1836         Renamed keyboard event constant variables to avoid style errors.
1837
1838         * src/WebInputEventConversion.cpp:
1839         (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
1840         * tests/WebInputEventConversionTest.cpp:
1841         * tests/WebInputEventFactoryTestGtk.cpp:
1842
1843 2013-01-30  Kentaro Hara  <haraken@chromium.org>
1844
1845         Implement WheelEvent constructor
1846         https://bugs.webkit.org/show_bug.cgi?id=108303
1847
1848         Reviewed by Adam Barth.
1849
1850         This patch just renames an enum value to avoid style check error.
1851
1852         * src/WebViewImpl.cpp:
1853         (WebKit::WebViewImpl::scrollBy):
1854
1855 2013-01-30  Dana Jansens  <danakj@chromium.org>
1856
1857         [chromium] Add recordRenderingStats to WebSettings
1858         https://bugs.webkit.org/show_bug.cgi?id=108358
1859
1860         Reviewed by James Robinson.
1861
1862         * public/WebSettings.h:
1863         * src/WebSettingsImpl.cpp:
1864         (WebKit::WebSettingsImpl::setRecordRenderingStats):
1865         (WebKit):
1866         * src/WebSettingsImpl.h:
1867         (WebSettingsImpl):
1868         (WebKit::WebSettingsImpl::recordRenderingStats):
1869         * src/WebViewImpl.cpp:
1870         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
1871
1872 2013-01-30  Tony Gentilcore  <tonyg@chromium.org>
1873
1874         Fix compile error in WebFrameTest
1875         https://bugs.webkit.org/show_bug.cgi?id=108360
1876
1877         Unreviewed build fix.
1878
1879         Fixes compile error:
1880         ../../Source/WebKit/chromium/tests/WebFrameTest.cpp:330:5: error: converting false to pointer type for argument 1 of char testing::internal::IsNullLiteralHelper(testing::internal::Secret*) [-Werror=conversion-null]
1881
1882         * tests/WebFrameTest.cpp:
1883
1884 2013-01-30  John Knottenbelt  <jknotten@chromium.org>
1885
1886         [Chromium] Fix find in page rects for overflowing content.
1887         https://bugs.webkit.org/show_bug.cgi?id=104924
1888
1889         Reviewed by Julien Chaffraix.
1890
1891         If a div has overflowing content, we should only normalise its
1892         coordinates against the renderview or the containing scrollable block.
1893
1894         TEST=WebFrameTest.FindInPageMatchRects
1895
1896         * src/FindInPageCoordinates.cpp:
1897         (WebKit::enclosingScrollableAncestor):
1898             Helper function to find the enclosing containing block with an overflow clip.
1899         (WebKit::toNormalizedRect):
1900             Pass in the container as an argument.
1901         (WebKit::findInPageRectFromAbsoluteRect):
1902             Compute the container for toNormalizedRect using enclosingScrollableAncestor.
1903         * tests/WebFrameTest.cpp:
1904             Add expectations for new tests in WebFrameTest::FindInPageMatchRects and WebFrameTest::FindInPage.
1905         * tests/data/find.html:
1906             Add test case for <select> element.
1907         * tests/data/find_in_page_frame.html:
1908             Add test cases:
1909               - Result 15, 16 tests that containing <div> with style float:left and
1910                 height:0px does not impact coordinate normalization.
1911               - Result 17, 18 tests that matches with absolute positioning are normalized containing
1912                 relative positioned block, even if there is a closer parent block with overflow clip.
1913               - Result 19 adds a test case for <select> element.
1914
1915 2013-01-30  Dominik Röttsches  <dominik.rottsches@intel.com>
1916
1917         [HarfBuzz] Remove the HarfBuzz-old code
1918         https://bugs.webkit.org/show_bug.cgi?id=108077
1919
1920         Reviewed by Benjamin Poulain.
1921
1922         Rename WTF_USE_HARFBUZZ_NG to WTF_USE_HARFBUZZ since there
1923         won't be a distinction between ng and non-ng HarfBuzz after
1924         removing the old code.
1925
1926         * features.gypi:
1927
1928 2013-01-30  Jochen Eisinger  <jochen@chromium.org>
1929
1930         [chromium] WebConsoleMessage is missing LevelDebug (chromium bug 172416)
1931         https://bugs.webkit.org/show_bug.cgi?id=108004
1932         http://code.google.com/p/chromium/issues/detail?id=172416
1933
1934         console.debug triggers a NOTREACHED() assertation in Chromium. This
1935         is because WebCore::MessageLevel contains 5 levels, including debug,
1936         where WebConsoleMessage::Level is missing a "debug" level. Add a
1937         WebConsoleMessage::LevelDebug so that it can get passed up to the
1938         renderer even if it doesn't make use of that now.
1939
1940         Requires another patch to chromium itself to fix chromium bug 172416
1941         but this is a prerequisite.
1942
1943         Also add an enum compile time check to AssertMatchingEnums.cpp,
1944
1945         Patch by Kevin Day <kevinday@gmail.com> on 2013-01-28
1946         Reviewed by Jochen Eisinger.
1947
1948         * public/WebConsoleMessage.h:
1949         * src/AssertMatchingEnums.cpp:
1950         * src/WebFrameImpl.cpp:
1951         (WebKit::WebFrameImpl::addMessageToConsole):
1952
1953 2013-01-30  Xianzhu Wang  <wangxianzhu@chromium.org>
1954
1955         [Chromium] Correct zoom for focused node when using compositor scaling
1956         https://bugs.webkit.org/show_bug.cgi?id=107599
1957
1958         Reviewed by Adam Barth.
1959
1960         When applyDeviceScaleFactorInCompositor, targetScale should exclude device scale factor.
1961         When applyPageScaleFactorInCompositor, caret size and content sizes are in css pixels and they should be in the viewport of the new scale.
1962
1963         Reapply r141153. Added font-size in html to ensure same caret size across platforms.
1964
1965         * src/WebViewImpl.cpp:
1966         (WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
1967         (WebKit):
1968         (WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode): Extracted from scrollFocusedNodeIntoRect() to ease testing.
1969         * src/WebViewImpl.h:
1970         (WebViewImpl):
1971         * tests/WebFrameTest.cpp: Updated test DivScrollEditableTest
1972         * tests/data/get_scale_for_zoom_into_editable_test.html: Moved the logic of onload script (which seems not to work) into WebFrameTest.cpp.
1973
1974 2013-01-29  Mark Lam  <mark.lam@apple.com>
1975
1976         Rename AbstractDatabase to DatabaseBackend.
1977         https://bugs.webkit.org/show_bug.cgi?id=108275.
1978
1979         Reviewed by Sam Weinig.
1980
1981         This is a pure rename operation as part of the webdatabase refactoring
1982         effort. There is no semantic change in this patch.
1983
1984         * public/WebDatabase.h:
1985         (WebDatabase):
1986         * src/DatabaseObserver.cpp:
1987         (WebCore::DatabaseObserver::databaseOpened):
1988         (WebCore::DatabaseObserver::databaseModified):
1989         (WebCore::DatabaseObserver::databaseClosed):
1990         (WebCore::DatabaseObserver::reportOpenDatabaseResult):
1991         (WebCore::DatabaseObserver::reportChangeVersionResult):
1992         (WebCore::DatabaseObserver::reportStartTransactionResult):
1993         (WebCore::DatabaseObserver::reportCommitTransactionResult):
1994         (WebCore::DatabaseObserver::reportExecuteStatementResult):
1995         (WebCore::DatabaseObserver::reportVacuumDatabaseResult):
1996         * src/WebDatabase.cpp:
1997         (WebKit::WebDatabase::WebDatabase):
1998
1999 2013-01-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2000
2001         Unreviewed, rolling out r141153.
2002         http://trac.webkit.org/changeset/141153
2003         https://bugs.webkit.org/show_bug.cgi?id=108280
2004
2005         Caused WebFrameTest.DivScrollIntoEditableTest to fail on Mac.
2006         (Requested by keishi on #webkit).
2007
2008         * src/WebViewImpl.cpp:
2009         (WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
2010         * src/WebViewImpl.h:
2011         (WebViewImpl):
2012         * tests/WebFrameTest.cpp:
2013         * tests/data/get_scale_for_zoom_into_editable_test.html:
2014
2015 2013-01-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2016
2017         Unreviewed, rolling out r140983.
2018         http://trac.webkit.org/changeset/140983
2019         https://bugs.webkit.org/show_bug.cgi?id=108277
2020
2021         Unfortunately, this API has one last client (Requested by
2022         abarth on #webkit).
2023
2024         * src/WebNotification.cpp:
2025         (WebKit::WebNotification::isHTML):
2026         (WebKit::WebNotification::url):
2027         (WebKit::WebNotification::iconURL):
2028         (WebKit::WebNotification::title):
2029         (WebKit::WebNotification::body):
2030
2031 2013-01-29  Shinya Kawanaka  <shinyak@chromium.org>
2032
2033         [Chromium] Cannot copy text when selecting readonly (or disabled) input elements
2034         https://bugs.webkit.org/show_bug.cgi?id=106287
2035
2036         Reviewed by Hajime Morita.
2037
2038         When an input element is disabled or readonly, its inner element is not editable. So its rootEditableElement
2039         does not exist. In WebViewImpl::caretOrSelectionRange, if rootEditableElement does not exist, it uses
2040         a document element. However, the inner element and document element have a different tree scope, selection range
2041         cannot be gotten correctly.
2042
2043         We should use ShadowRoot instead of document so that we can stay in the same tree scope.
2044
2045         * src/WebViewImpl.cpp:
2046         (WebKit::WebViewImpl::caretOrSelectionRange):
2047         * tests/WebViewTest.cpp:
2048         * tests/data/selection_disabled.html: Added.
2049         * tests/data/selection_readonly.html: Added.
2050
2051 2013-01-29  Tom Sepez  <tsepez@chromium.org>
2052
2053         [v8] Enable binding integrity on linux
2054         https://bugs.webkit.org/show_bug.cgi?id=108242
2055
2056         Reviewed by Adam Barth.
2057
2058         * features.gypi:
2059
2060 2013-01-29  Xianzhu Wang  <wangxianzhu@chromium.org>
2061
2062         [Chromium] Correct zoom for focused node when using compositor scaling
2063         https://bugs.webkit.org/show_bug.cgi?id=107599
2064
2065         Reviewed by Adam Barth.
2066
2067         When applyDeviceScaleFactorInCompositor, targetScale should exclude device scale factor.
2068         When applyPageScaleFactorInCompositor, caret size and content sizes are in css pixels and they should be in the viewport of the new scale.
2069
2070         * src/WebViewImpl.cpp:
2071         (WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
2072         (WebKit):
2073         (WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode): Extracted from scrollFocusedNodeIntoRect() to ease testing.
2074         * src/WebViewImpl.h:
2075         (WebViewImpl):
2076         * tests/WebFrameTest.cpp: Updated test DivScrollEditableTest
2077         * tests/data/get_scale_for_zoom_into_editable_test.html: Moved the logic of onload script (which seems not to work) into WebFrameTest.cpp.
2078
2079 2013-01-29  Alec Flett  <alecflett@chromium.org>
2080
2081         IndexedDB: Pass metadata in to IDBOpenDBRequest.onUpgradeNeeded/onSuccess
2082         https://bugs.webkit.org/show_bug.cgi?id=103920
2083
2084         Reviewed by Dimitri Glazkov.
2085
2086         Support the new IDBCallbacks::onSuccess and IDBCallbacks::onUpgradeNeeded
2087         while maintaining chromium compatibility by shimming in the old API
2088         in the WebKit side. Future code will clean this up so that it is just a
2089         pass-through as it was before.
2090
2091         * public/WebIDBCallbacks.h:
2092         (WebKit):
2093         (WebKit::WebIDBCallbacks::onSuccess): new method signature.
2094         (WebKit::WebIDBCallbacks::onUpgradeNeeded): new method signature.
2095         * src/IDBCallbacksProxy.cpp:
2096         (WebKit::IDBCallbacksProxy::onSuccess): call on new method signature proxies through old API.
2097         (WebKit):
2098         (WebKit::IDBCallbacksProxy::onUpgradeNeeded): call on new method signature proxies through old API.
2099         * src/IDBCallbacksProxy.h:
2100         (IDBCallbacksProxy):
2101         * src/WebIDBCallbacksImpl.cpp:
2102         (WebKit::WebIDBCallbacksImpl::onSuccess): call on old WebKit proxy signature calls new API.
2103         (WebKit):
2104         (WebKit::WebIDBCallbacksImpl::onUpgradeNeeded): call on old WebKit proxy signature calls new API.
2105         * src/WebIDBCallbacksImpl.h:
2106         (WebIDBCallbacksImpl):
2107         * tests/IDBAbortOnCorruptTest.cpp: new method signature.
2108         (WebCore::MockIDBCallbacks::onSuccess):
2109         * tests/IDBDatabaseBackendTest.cpp: new method signature.
2110
2111 2013-01-29  Alexandre Elias  <aelias@chromium.org>
2112
2113         [chromium] Fix contents size calculation for page scale initialization
2114         https://bugs.webkit.org/show_bug.cgi?id=108204
2115
2116         Reviewed by enne.
2117
2118         My previous patch http://webk.it/107424 had a few issues that are
2119         blocking WebKit roll.
2120
2121         - We still need the layout in resize() given that
2122         http://webk.it/107922 was reverted.
2123
2124         - I deleted code used only for the old page-scale mode in
2125         contentsSize(), but this needs to wait until WebKit roll since it's
2126         making bots fail in this short term.
2127
2128         * src/WebViewImpl.cpp:
2129         (WebKit::WebViewImpl::resize):
2130         (WebKit::WebViewImpl::contentsSize):
2131
2132 2013-01-29  Alpha Lam  <hclam@chromium.org>
2133
2134         [chromium] Unreviewed DEPS roll.
2135
2136         Roll Chromium DEPS to 179332.
2137
2138         * DEPS:
2139
2140 2013-01-29  Joshua Bell  <jsbell@chromium.org>
2141
2142         [Chromium] IndexedDB: Let callers specify reason (error) for aborting transaction
2143         https://bugs.webkit.org/show_bug.cgi?id=107851
2144
2145         Reviewed by Tony Chang.
2146
2147         Let Chromium call abort() on a transaction and specify a reason, specifically for
2148         QuotaExceededError.
2149
2150         * public/WebIDBDatabase.h:
2151         (WebKit::WebIDBDatabase::abort): New overload for abort() that takes an error.
2152         * public/WebIDBDatabaseError.h:
2153         (WebKit::WebIDBDatabaseError::WebIDBDatabaseError): Overloaded constructor/assign that takes error.
2154         * src/IDBDatabaseBackendProxy.cpp:
2155         (WebKit::IDBDatabaseBackendProxy::abort): New overload for abort() that takes an error.
2156         * src/IDBDatabaseBackendProxy.h:
2157         (IDBDatabaseBackendProxy): Ditto.
2158         * src/WebIDBDatabaseError.cpp: Implementation of overload ctor/assign.
2159         * src/WebIDBDatabaseImpl.cpp:
2160         (WebKit::WebIDBDatabaseImpl::abort): New overload for abort() that takes an error.
2161         * src/WebIDBDatabaseImpl.h: Ditto.
2162         * tests/IDBDatabaseBackendTest.cpp: Overload stubs for Mock class.
2163
2164 2013-01-29  Florin Malita  <fmalita@chromium.org>
2165
2166         [Chromium] Unreviewed gardening.
2167
2168         Disable WebFrameTest.pageScaleFactorShrinksViewport (pending investigation after r141053).
2169
2170         * tests/WebFrameTest.cpp:
2171
2172 2013-01-29  Keishi Hattori  <keishi@webkit.org>
2173
2174         [Chromium] Disabling WebFrameTest.DisambiguationPopupMobileSite because WebFrameTest is still failing after r141073.
2175
2176         Unreviewed. Gardening.
2177
2178         * tests/WebFrameTest.cpp:
2179
2180 2013-01-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2181
2182         Unreviewed, rolling out r141064.
2183         http://trac.webkit.org/changeset/141064
2184         https://bugs.webkit.org/show_bug.cgi?id=108166
2185
2186         [Chromium] WebFrameTest.DivScrollIntoEditableTest is failing
2187         on WinXP. (Requested by keishi on #webkit).
2188
2189         * tests/WebFrameTest.cpp:
2190         * tests/data/get_scale_for_zoom_into_editable_test.html:
2191
2192 2013-01-29  Keishi Hattori  <keishi@webkit.org>
2193
2194         [Chromium] Disabling WebFrameTest.DisambiguationPopup because it is failing.
2195
2196         Unreviewed. Gardening.
2197
2198         * tests/WebFrameTest.cpp:
2199
2200 2013-01-28  Xianzhu Wang  <wangxianzhu@chromium.org>
2201
2202         Re-enable WebFrameTest.DivScrollIntoEditableTest
2203         https://bugs.webkit.org/show_bug.cgi?id=98558
2204
2205         Reviewed by Adam Barth.
2206
2207         * tests/WebFrameTest.cpp: Fixed several issues (onload script, the maximum scale factor, etc.) of WebFrameTest.DivScrollIntoEditableTest and enable it.
2208         * tests/data/get_scale_for_zoom_into_editable_test.html: Moved the logic of onload script (which seems not to work) into WebFrameTest.cpp.
2209
2210 2013-01-28  Tien-Ren Chen  <trchen@chromium.org>
2211
2212         Fix disambiguation popup for new-style page scale
2213         https://bugs.webkit.org/show_bug.cgi?id=107391
2214
2215         Reviewed by Adam Barth.
2216
2217         This patch corrects various coordinate conversion for disambiguation
2218         popup for the new-style page scale mode.
2219
2220         * src/WebViewImpl.cpp:
2221         (WebKit::WebViewImpl::handleGestureEvent):
2222         (WebKit::WebViewImpl::handleInputEvent):
2223         * tests/WebFrameTest.cpp:
2224         * tests/data/disambiguation_popup_page_scale.html: Added.
2225
2226 2013-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2227
2228         Unreviewed, rolling out r141049.
2229         http://trac.webkit.org/changeset/141049
2230         https://bugs.webkit.org/show_bug.cgi?id=108151
2231
2232         Caused some indexed tests to crash. (Requested by keishi on
2233         #webkit).
2234
2235         * public/WebIDBCallbacks.h:
2236         (WebKit):
2237         * src/IDBCallbacksProxy.cpp:
2238         (WebKit::IDBCallbacksProxy::onUpgradeNeeded):
2239         * src/IDBCallbacksProxy.h:
2240         (IDBCallbacksProxy):
2241         * src/WebIDBCallbacksImpl.cpp:
2242         (WebKit::WebIDBCallbacksImpl::onSuccess):
2243         (WebKit::WebIDBCallbacksImpl::onUpgradeNeeded):
2244         * src/WebIDBCallbacksImpl.h:
2245         (WebIDBCallbacksImpl):
2246         * tests/IDBAbortOnCorruptTest.cpp:
2247         (WebCore::MockIDBCallbacks::onSuccess):
2248         * tests/IDBDatabaseBackendTest.cpp:
2249
2250 2013-01-28  Raman Kumar  <ramankk@chromium.org>
2251
2252         Expose isRadioButton and isCheckbox API in chromium-webkit glue layer.
2253         https://bugs.webkit.org/show_bug.cgi?id=108031
2254
2255         Reviewed by Adam Barth.
2256
2257         In chromium, to know if an InputElement is radiobutton or a checkbox,
2258         we are checking for formControlType (a string comparision), which is
2259         very slow. Exposing these API to chromium will make them faster.
2260
2261         * public/WebInputElement.h:
2262         (WebInputElement):
2263         * src/WebInputElement.cpp:
2264         (WebKit::WebInputElement::isRadioButton):
2265         (WebKit):
2266         (WebKit::WebInputElement::isCheckbox):
2267
2268 2013-01-28  Alexandre Elias  <aelias@chromium.org>
2269
2270         Make page scale shrink FrameView in applyPageScaleInCompositor mode
2271         https://bugs.webkit.org/show_bug.cgi?id=107424
2272
2273         Reviewed by Levi Weintraub.
2274
2275         If applyPageScaleFactorInCompositor is enabled (Chromium-only setting),
2276         instead of the entire document expanding as the user pinch zooms, the
2277         viewport shrinks instead. This patch applies the pageScaleFactor to
2278         visibleContentRect to get this behavior, and simplifies Chromium's
2279         resize logic to stop hiding the true viewport size from WebCore.
2280
2281         I verified that the scaling makes sense for all the callers of
2282         visibleContentRect. The exceptions are clip-layer size,
2283         layout size in non-fixed-layout mode, and text autosizing, which need
2284         the original unscaled size. Therefore I added a new method
2285         unscaledVisibleContentSize() to ScrollView/FrameView.
2286
2287         This patch also modifies Page::setPageScaleFactor to perform no
2288         invalidates or layout when applyPageScaleFactorInCompositor is true,
2289         and also writes pageScaleFactor into HistoryItems instead of using
2290         frameScaleFactor.
2291
2292         Since all behavior changes are tied to applyPageScaleFactorInCompositor,
2293         this patch should be a no-op for non-Chromium ports.
2294
2295         * src/WebViewImpl.cpp:
2296         (WebKit::WebViewImpl::scaledSize): Returns the post page-scale size
2297         similar to what visibleContentRect() now returns, except that it may
2298         be at a different scale than the current one.
2299         (WebKit::WebViewImpl::size): Back to returning density-independent
2300         size without any tricks, not the "layoutSize()" fake viewport.
2301         (WebKit::WebViewImpl::resize):
2302         (WebKit::WebViewImpl::handleInputEvent): No need to apply
2303         implTransform anymore as WebKit knows the true scroll offset; just
2304         divide event coords by pageScaleFactor.
2305         (WebKit::WebViewImpl::clampOffsetAtScale): Make this method support
2306         applyPageScaleFactorInCompositor.  This is used to pre-clamp scroll
2307         offsets at a given viewport size.
2308         (WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset): Make
2309         this method support applyPageScaleFactorInCompositor (don't scale
2310         scroll offsets as they are now scale-independent).
2311         (WebKit::WebViewImpl::setPageScaleFactor): Make this method always use
2312         clampOffsetAtScale instead of bypassing it, since it's now supported.
2313         Also notify the compositor to update its state.
2314         (WebKit::WebViewImpl::contentsSize): Convenience method, removed
2315         difference between scaled and unscaled.
2316         (WebKit::WebViewImpl::layoutSize): This method returned the "fake"
2317         size we used to give FrameView.  Now no longer used for much.
2318         (WebKit::WebViewImpl::computePageScaleFactorLimits):
2319         (WebKit::WebViewImpl::didChangeContentsSize): Remove unnecessary
2320         resize() now that we can give the true size to FrameView.
2321         (WebKit::WebViewImpl::updateLayerTreeViewport): Use layoutSize()
2322         directly now that FrameView no longer uses it.
2323         * src/WebViewImpl.h:
2324         (WebViewImpl):
2325         * tests/WebFrameTest.cpp:
2326
2327 2013-01-28  Alec Flett  <alecflett@chromium.org>
2328
2329         IndexedDB: Pass metadata in to IDBOpenDBRequest.onUpgradeNeeded/onSuccess
2330         https://bugs.webkit.org/show_bug.cgi?id=103920
2331
2332         Reviewed by Dimitri Glazkov.
2333
2334         Support the new IDBCallbacks::onSuccess and IDBCallbacks::onUpgradeNeeded
2335         while maintaining chromium compatibility by shimming in the old API
2336         in the WebKit side. Future code will clean this up so that it is just a
2337         pass-through as it was before.
2338
2339         * public/WebIDBCallbacks.h:
2340         (WebKit):
2341         (WebKit::WebIDBCallbacks::onSuccess): new method signature.
2342         (WebKit::WebIDBCallbacks::onUpgradeNeeded): new method signature.
2343         * src/IDBCallbacksProxy.cpp:
2344         (WebKit::IDBCallbacksProxy::onSuccess): call on new method signature proxies through old API.
2345         (WebKit):
2346         (WebKit::IDBCallbacksProxy::onUpgradeNeeded): call on new method signature proxies through old API.
2347         * src/IDBCallbacksProxy.h:
2348         (IDBCallbacksProxy):
2349         * src/WebIDBCallbacksImpl.cpp:
2350         (WebKit::WebIDBCallbacksImpl::onSuccess): call on old WebKit proxy signature calls new API.
2351         (WebKit):
2352         (WebKit::WebIDBCallbacksImpl::onUpgradeNeeded): call on old WebKit proxy signature calls new API.
2353         * src/WebIDBCallbacksImpl.h:
2354         (WebIDBCallbacksImpl):
2355         * tests/IDBAbortOnCorruptTest.cpp: new method signature.
2356         (WebCore::MockIDBCallbacks::onSuccess):
2357         * tests/IDBDatabaseBackendTest.cpp: new method signature.
2358
2359 2013-01-28  Tom Sepez  <tsepez@chromium.org>
2360
2361         [v8] Security feature: JavaScript Bindings hardening
2362         https://bugs.webkit.org/show_bug.cgi?id=106608
2363
2364         Reviewed by Adam Barth.
2365
2366         * features.gypi:
2367         Added ENABLE_BINDING_INTEGRITY option.
2368
2369 2013-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2370
2371         Unreviewed, rolling out r141006.
2372         http://trac.webkit.org/changeset/141006
2373         https://bugs.webkit.org/show_bug.cgi?id=108123
2374
2375         Broke chromium build (Requested by arv on #webkit).
2376
2377         * public/WebConsoleMessage.h:
2378         * src/AssertMatchingEnums.cpp:
2379         * src/WebFrameImpl.cpp:
2380         (WebKit::WebFrameImpl::addMessageToConsole):
2381
2382 2013-01-28  Min Qin  <qinmin@chromium.org>
2383
2384         adding support for DiscardablePixelRef for caching lazily decoded images
2385         https://bugs.webkit.org/show_bug.cgi?id=106842
2386
2387         Reviewed by Stephen White.
2388
2389         Adding new tests for ImageDecodingStore
2390
2391         * WebKit.gypi:
2392         * tests/ImageDecodingStoreTest.cpp:
2393         (WebCore::ImageDecodingStoreTest::createCompleteImage):
2394         (WebCore::ImageDecodingStoreTest::createIncompleteImage):
2395         (WebCore::TEST_F):
2396         (WebCore):
2397         * tests/MockDiscardablePixelRef.h: Added.
2398         (WebCore):
2399         (MockDiscardablePixelRef):
2400         (WebCore::MockDiscardablePixelRef::MockDiscardablePixelRef):
2401         (WebCore::MockDiscardablePixelRef::~MockDiscardablePixelRef):
2402         (WebCore::MockDiscardablePixelRef::discard):
2403         (WebCore::MockDiscardablePixelRef::onLockPixels):
2404         (WebCore::MockDiscardablePixelRef::onUnlockPixels):
2405
2406 2013-01-28  Stephen Chenney  <schenney@chromium.org>
2407
2408         [Chromium] Fix the build.
2409
2410         Unreviewed build fix.
2411
2412         * src/AssertMatchingEnums.cpp: Move the include to the right place and remove the bad directory prefix.
2413
2414 2013-01-28  Dan Alcantara  <dfalcantara@chromium.org>
2415
2416         [Chromium, Mobile] Do not show disambiguation pop up in mobile sites
2417         https://bugs.webkit.org/show_bug.cgi?id=107607
2418
2419         Reviewed by Adam Barth.
2420
2421         Add a check before showing the disambiguation popup to prevent it from appearing
2422         on mobile sites.  Makes a similar test to the current disambiguation popup test
2423         that expects the popup to never appear.
2424
2425         * src/WebViewImpl.cpp:
2426         (WebKit::WebViewImpl::handleGestureEvent):
2427         (WebKit):
2428         (WebKit::WebViewImpl::isLikelyMobileSite):
2429         * src/WebViewImpl.h:
2430         (WebViewImpl):
2431         * tests/WebFrameTest.cpp:
2432         * tests/data/disambiguation_popup_mobile_site.html: Added.
2433
2434         * src/WebViewImpl.cpp:
2435         (WebKit::WebViewImpl::handleGestureEvent):
2436         (WebKit):
2437         (WebKit::WebViewImpl::shouldDisableDesktopWorkarounds):
2438         * src/WebViewImpl.h:
2439         (WebViewImpl):
2440         * tests/WebFrameTest.cpp:
2441         * tests/data/disambiguation_popup_mobile_site.html: Added.
2442
2443 2013-01-28  Stephen Chenney  <schenney@chromium.org>
2444
2445         [Chromium] Fix the build.
2446
2447         Unreviewed build fix.
2448
2449         * src/AssertMatchingEnums.cpp: Move the include to the right place and remove the bad directory prefix.
2450
2451 2013-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2452
2453         Unreviewed, rolling out r140869.
2454         http://trac.webkit.org/changeset/140869
2455         https://bugs.webkit.org/show_bug.cgi?id=108120
2456
2457         "Crashes on http://en.wikipedia.org/wiki/Wikipedia" (Requested
2458         by tonyg-cr on #webkit).
2459
2460         * src/WebViewImpl.cpp:
2461         (WebKit::WebViewImpl::resize):
2462         (WebKit::WebViewImpl::computePageScaleFactorLimits):
2463         * tests/WebFrameTest.cpp:
2464
2465 2013-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2466
2467         Unreviewed, rolling out r140934, r140935, and r140937.
2468         http://trac.webkit.org/changeset/140934
2469         http://trac.webkit.org/changeset/140935
2470         http://trac.webkit.org/changeset/140937
2471         https://bugs.webkit.org/show_bug.cgi?id=108117
2472
2473         Re-land some speculative rollouts - see wkbug.com/108048 for
2474         context (Requested by jsbell on #webkit).
2475
2476         * public/WebIDBCallbacks.h:
2477         (WebIDBCallbacks):
2478         * src/AssertMatchingEnums.cpp:
2479         * src/IDBCallbacksProxy.cpp:
2480         * src/IDBCallbacksProxy.h:
2481         (IDBCallbacksProxy):
2482         * src/WebIDBCallbacksImpl.cpp:
2483         * src/WebIDBCallbacksImpl.h:
2484         (WebIDBCallbacksImpl):
2485         * tests/IDBAbortOnCorruptTest.cpp:
2486         * tests/IDBDatabaseBackendTest.cpp:
2487
2488 2013-01-28  Kevin Day  <kevinday@gmail.com>
2489
2490         [chromium] WebConsoleMessage is missing LevelDebug (chromium bug 172416)
2491         https://bugs.webkit.org/show_bug.cgi?id=108004
2492         http://code.google.com/p/chromium/issues/detail?id=172416
2493
2494         console.debug triggers a NOTREACHED() assertation in Chromium. This
2495         is because WebCore::MessageLevel contains 5 levels, including debug,
2496         where WebConsoleMessage::Level is missing a "debug" level. Add a
2497         WebConsoleMessage::LevelDebug so that it can get passed up to the
2498         renderer even if it doesn't make use of that now.
2499
2500         Requires another patch to chromium itself to fix chromium bug 172416
2501         but this is a prerequisite.
2502
2503         Also add an enum compile time check to AssertMatchingEnums.cpp,
2504
2505         Reviewed by Jochen Eisinger.
2506
2507         * public/WebConsoleMessage.h:
2508         * src/AssertMatchingEnums.cpp:
2509         * src/WebFrameImpl.cpp:
2510         (WebKit::WebFrameImpl::addMessageToConsole):
2511
2512 2013-01-28  Xianzhu Wang  <wangxianzhu@chromium.org>
2513
2514         [Chromium] Correct auto-zoom when using compositor scaling
2515         https://bugs.webkit.org/show_bug.cgi?id=107592
2516
2517         Reviewed by Adam Barth.
2518
2519         1. The scale of auto-zoom should exclude deviceScaleFactor because the compositor will handle the scaling;
2520         2. Scroll location needs to be calculated differently when pageScaleFactor is handled by the compositor.
2521
2522         * src/WebViewImpl.cpp:
2523         (WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
2524         * tests/WebFrameTest.cpp: Updated tests DivAutoZoomParamsTest, DivAutoZoomMultipleDivsTest, DivAutoZoomScaleBoundsTest and DivAutoZoomScaleFontScaleFactorTest, to make two versions of them (WebKitScaling and CompositorScaling).
2525
2526 2013-01-28  Laszlo Gombos  <l.gombos@samsung.com>
2527
2528         Collapse OS(UNIX)||OS(ANDROID) to OS(UNIX)
2529         https://bugs.webkit.org/show_bug.cgi?id=108091
2530
2531         Reviewed by Adam Barth.
2532
2533         OS(UNIX) is defined when OS(ANDROID) is defined.
2534
2535         * src/WebViewImpl.cpp:
2536         (WebKit::WebViewImpl::handleMouseDown):
2537
2538 2013-01-28  Adam Barth  <abarth@webkit.org>
2539
2540         Remove webkitNotifications.createHTMLNotification
2541         https://bugs.webkit.org/show_bug.cgi?id=107598
2542
2543         Reviewed by Benjamin Poulain.
2544
2545         We can remove these stubs once we've removed the Chromium-side code
2546         that depends on them.
2547
2548         * src/WebNotification.cpp:
2549         (WebKit::WebNotification::isHTML):
2550         (WebKit::WebNotification::url):
2551         (WebKit::WebNotification::iconURL):
2552         (WebKit::WebNotification::title):
2553         (WebKit::WebNotification::body):
2554
2555 2013-01-28  James Craig  <james@cookiecrook.com>
2556
2557         HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match.
2558         https://bugs.webkit.org/show_bug.cgi?id=107650
2559
2560         Reviewed by Chris Fleizach.
2561
2562         Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).
2563
2564         * public/WebAccessibilityRole.h:
2565         * src/AssertMatchingEnums.cpp:
2566         * src/LocalizedStrings.cpp:
2567         (WebCore::AXDefinitionText):
2568         (WebCore):
2569         (WebCore::AXDescriptionListTermText):
2570         (WebCore::AXDescriptionListDetailText):
2571
2572 2013-01-28  Mike West  <mkwst@chromium.org>
2573
2574         [chromium] Unreviewed build fix, missing include in AssertMatchingEnums.cpp
2575         https://bugs.webkit.org/show_bug.cgi?id=108086
2576
2577         Disabling SVG exposed a missing include in AssertMatchingEnums. This
2578         patch adds it in.
2579
2580         * src/AssertMatchingEnums.cpp:
2581             Include 'ResourceLoadPriority.h'.
2582
2583 2013-01-28  Marja Hölttä  <marja@chromium.org>
2584
2585         Add an API for retrieving native memory information without going through the remote inspecting protocol
2586         https://bugs.webkit.org/show_bug.cgi?id=107651
2587
2588         Reviewed by Adam Barth.
2589
2590         * WebKit.gyp:
2591         * public/WebDevToolsAgent.h:
2592         (WebKit):
2593         (WebDevToolsAgent):
2594         * public/WebMemoryUsageInfo.h: Added.
2595         (WebKit):
2596         (WebKit::WebMemoryUsageInfo::WebMemoryUsageInfo):
2597         (WebMemoryUsageInfo):
2598         * src/WebDevToolsAgentImpl.cpp:
2599         (WebKit::WebDevToolsAgentImpl::processMemoryDistribution):
2600         (WebKit):
2601         * src/WebDevToolsAgentImpl.h:
2602         (WebKit):
2603         (WebDevToolsAgentImpl):
2604
2605 2013-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2606
2607         Unreviewed, rolling out r140602.
2608         http://trac.webkit.org/changeset/140602
2609         https://bugs.webkit.org/show_bug.cgi?id=108045
2610
2611         Caused 8 indexed tests to crash. (Requested by keishi on
2612         #webkit).
2613
2614         * public/WebIDBCallbacks.h:
2615         * src/IDBCallbacksProxy.cpp:
2616         (WebKit::IDBCallbacksProxy::onBlocked):
2617         (WebKit):
2618         * src/IDBCallbacksProxy.h:
2619         (IDBCallbacksProxy):
2620         * src/WebIDBCallbacksImpl.cpp:
2621         (WebKit::WebIDBCallbacksImpl::onBlocked):
2622         (WebKit):
2623         * src/WebIDBCallbacksImpl.h:
2624         (WebIDBCallbacksImpl):
2625         * tests/IDBAbortOnCorruptTest.cpp:
2626         (WebCore::MockIDBCallbacks::onBlocked):
2627         * tests/IDBDatabaseBackendTest.cpp:
2628
2629 2013-01-27  Keishi Hattori  <keishi@webkit.org>
2630
2631         Unreviewed, rolling out r140850.
2632         http://trac.webkit.org/changeset/140850
2633         https://bugs.webkit.org/show_bug.cgi?id=107960
2634
2635         r14602 caused 8 indexed tests to crash.
2636
2637         * src/AssertMatchingEnums.cpp:
2638
2639 2013-01-27  Jochen Eisinger  <jochen@chromium.org>
2640
2641         [chromium] add missing plumbing for Notification.requestPermission
2642         https://bugs.webkit.org/show_bug.cgi?id=108012
2643
2644         Reviewed by Adam Barth.
2645
2646         * src/NotificationPresenterImpl.cpp:
2647         (WebKit):
2648         (WebKit::VoidCallbackClient::VoidCallbackClient):
2649         (NotificationPermissionCallbackClient):
2650         (WebKit::NotificationPermissionCallbackClient::NotificationPermissionCallbackClient):
2651         (WebKit::NotificationPermissionCallbackClient::permissionRequestComplete):
2652         (WebKit::NotificationPermissionCallbackClient::~NotificationPermissionCallbackClient):
2653         (WebKit::NotificationPresenterImpl::requestPermission):
2654         * src/NotificationPresenterImpl.h:
2655         (NotificationPresenterImpl):
2656
2657 2013-01-26  James Simonsen  <simonjam@chromium.org>
2658
2659         [chromium] Export ResourceRequest's priority through WebURLRequest
2660         https://bugs.webkit.org/show_bug.cgi?id=107985
2661
2662         Reviewed by Adam Barth.
2663
2664         * src/AssertMatchingEnums.cpp:
2665
2666 2013-01-25  Alexandre Elias  <aelias@chromium.org>
2667
2668         Call FrameView::contentsResized() when setting fixed layout size
2669         https://bugs.webkit.org/show_bug.cgi?id=107922
2670
2671         Reviewed by James Robinson.
2672
2673         In fixed layout mode, we should be calling contentsResized() when the
2674         fixed layout size is changed; on the other hand, we don't need to layout
2675         when the visible contents size changes.
2676
2677         This fixes test WebFrameTest::FixedLayoutInitializeAtMinimumPageScale.
2678
2679         * src/WebViewImpl.cpp:
2680         (WebKit::WebViewImpl::resize):
2681         (WebKit::WebViewImpl::computePageScaleFactorLimits):
2682         * tests/WebFrameTest.cpp:
2683
2684 2013-01-25  Alec Flett  <alecflett@chromium.org>
2685
2686         IndexedDB: Move TaskType enum to IDBDatabaseBackendInterface
2687         https://bugs.webkit.org/show_bug.cgi?id=107960
2688
2689         Reviewed by Tony Chang.
2690
2691         Update asserts to reflect new enum location.
2692
2693         * src/AssertMatchingEnums.cpp:
2694
2695 2013-01-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2696
2697         Unreviewed, rolling out r140774.
2698         http://trac.webkit.org/changeset/140774
2699         https://bugs.webkit.org/show_bug.cgi?id=107932
2700
2701          Tests ScrollingCoordinatorChromiumTest.fastScrollingByDefault
2702         and fastScrollingForFixedPosition are failing (Requested by
2703         keishi on #webkit).
2704
2705         * public/WebWidget.h:
2706         (WebWidget):
2707         (WebKit::WebWidget::isInputThrottled):
2708         (WebKit::WebWidget::renderingStats):
2709         * src/WebViewImpl.cpp:
2710         (WebKit::WebViewImpl::WebViewImpl):
2711         (WebKit::WebViewImpl::~WebViewImpl):
2712         (WebKit::WebViewImpl::renderingStats):
2713         (WebKit):
2714         (WebKit::WebViewImpl::setCompositorSurfaceReady):
2715         (WebKit::WebViewImpl::isInputThrottled):
2716         (WebKit::WebViewImpl::setIsTransparent):
2717         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2718         * src/WebViewImpl.h:
2719
2720 2013-01-25  Eberhard Graether  <egraether@google.com>
2721
2722         Web Inspector: add checkbox for continuous painting to the inspector's settings
2723         https://bugs.webkit.org/show_bug.cgi?id=107352
2724
2725         Reviewed by Pavel Feldman.
2726
2727         This change adds a checkbox to activate continuous painting to the WebInspector's
2728         rendering settings and plumbs the setting to Chromium's WebLayerTreeView. The
2729         setting is visible if InspectorClient::canContinuouslyPaint() returns true.
2730
2731         * public/WebView.h:
2732         (WebView):
2733         * src/InspectorClientImpl.cpp:
2734         (WebKit::InspectorClientImpl::canContinuouslyPaint):
2735         (WebKit):
2736         (WebKit::InspectorClientImpl::setContinuousPaintingEnabled):
2737         * src/InspectorClientImpl.h:
2738         (InspectorClientImpl):
2739         * src/WebViewImpl.cpp:
2740         (WebKit::WebViewImpl::setContinuousPaintingEnabled):
2741         (WebKit):
2742         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2743         * src/WebViewImpl.h:
2744
2745 2013-01-24  Keishi Hattori  <keishi@webkit.org>
2746
2747         Adjust design of the Calendar Picker
2748         https://bugs.webkit.org/show_bug.cgi?id=107507
2749
2750         Reviewed by Kent Tamura.
2751
2752         * src/DateTimeChooserImpl.cpp:
2753         (WebKit::DateTimeChooserImpl::writeDocument):  Include pickerCommonChromium.css and calendarPickerChromium.css.
2754
2755 2013-01-24  James Robinson  <jamesr@chromium.org>
2756
2757         [chromium] Remove dead transitional code from WebViewImpl
2758         https://bugs.webkit.org/show_bug.cgi?id=107889
2759
2760         Reviewed by Adrienne Walker.
2761
2762         The chromium side of this landed at r178256 and seems stable.
2763
2764         * public/WebWidget.h:
2765         (WebKit::WebWidget::setCompositorSurfaceReady):
2766         * src/WebViewImpl.cpp:
2767         (WebKit::WebViewImpl::WebViewImpl):
2768         (WebKit::WebViewImpl::~WebViewImpl):
2769         (WebKit):
2770         (WebKit::WebViewImpl::setIsTransparent):
2771         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2772         * src/WebViewImpl.h:
2773
2774 2013-01-24  James Robinson  <jamesr@chromium.org>
2775
2776         [chromium] Null check WebLayerTreeView before dereffing in WebViewImpl::invalidateRect
2777         https://bugs.webkit.org/show_bug.cgi?id=107855
2778
2779         Reviewed by Adrienne Walker.
2780
2781         During frame shutdown, WebViewImpl::m_layerTreeView may become 0 while commits are deferred but we still
2782         may get invalidateRect() calls before shutdown completes.
2783
2784         * src/WebViewImpl.cpp:
2785         (WebKit::WebViewImpl::invalidateRect):
2786
2787 2013-01-24  Mihai Maerean  <mmaerean@adobe.com>
2788
2789         [CSSRegions] remove setExperimentalCSSRegionsEnabled deprecated API in Source/WebKit/chromium/public/WebSettings.h
2790         https://bugs.webkit.org/show_bug.cgi?id=104564
2791
2792         Reviewed by Adam Barth.
2793
2794         Fixing bug 101192 has deprecated the use of setExperimentalCSSRegionsEnabled.
2795         After http://code.google.com/p/chromium/issues/detail?id=164162 , setExperimentalCSSRegionsEnabled is no longer used anywhere.
2796
2797         * public/WebSettings.h:
2798         removed setExperimentalCSSRegionsEnabled.
2799
2800 2013-01-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2801
2802         Unreviewed.  Rolled Chromium DEPS to r178434.  Requested by
2803         "Yoshifumi Inoue" <yosin@chromium.org> via sheriffbot.
2804
2805         * DEPS:
2806
2807 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
2808
2809         [Chromium] Remove unused header files in chromium/public/platform/
2810         https://bugs.webkit.org/show_bug.cgi?id=107741
2811
2812         Reviewed by James Robinson.
2813
2814         These header files have migrated to the new Platform directory.
2815         This patch updates the remaining #include references and removes
2816         the old files that did nothing but redirect to the new ones.
2817
2818         * WebKit.gyp:
2819         * public/WebAccessibilityObject.h:
2820         * public/WebAccessibilityRole.h:
2821         * public/WebActiveWheelFlingParameters.h:
2822         * public/WebAnimationController.h:
2823         * public/WebApplicationCacheHost.h:
2824         * public/WebApplicationCacheHostClient.h:
2825         * public/WebArrayBuffer.h:
2826         * public/WebArrayBufferView.h:
2827         * public/WebAudioSourceProvider.h:
2828         * public/WebBatteryStatus.h:
2829         * public/WebBindings.h:
2830         * public/WebBlob.h:
2831         * public/WebCache.h:
2832         * public/WebCachedURLRequest.h:
2833         * public/WebColorChooser.h:
2834         * public/WebColorChooserClient.h:
2835         * public/WebColorName.h:
2836         * public/WebCommonWorkerClient.h:
2837         * public/WebCompositionUnderline.h:
2838         * public/WebCompositorInputHandler.h:
2839         * public/WebConsoleMessage.h:
2840         * public/WebContentDetectionResult.h:
2841         * public/WebContextMenuData.h:
2842         * public/WebCrossOriginPreflightResultCache.h:
2843         * public/WebCursorInfo.h:
2844         * public/WebDOMEvent.h:
2845         * public/WebDOMEventListener.h:
2846         * public/WebDOMStringList.h:
2847         * public/WebDataSource.h:
2848         * public/WebDatabase.h:
2849         * public/WebDateTimeChooserCompletion.h:
2850         * public/WebDateTimeChooserParams.h:
2851         * public/WebDeliveredIntentClient.h:
2852         * public/WebDevToolsAgent.h:
2853         * public/WebDevToolsAgentClient.h:
2854         * public/WebDevToolsFrontend.h:
2855         * public/WebDeviceOrientationClient.h:
2856         * public/WebDeviceOrientationClientMock.h:
2857         * public/WebDeviceOrientationController.h:
2858         * public/WebDocument.h:
2859         * public/WebDraggableRegion.h:
2860         * public/WebExternalPopupMenuClient.h:
2861         * public/WebFileChooserCompletion.h:
2862         * public/WebFileChooserParams.h:
2863         * public/WebFileSystemCallbacks.h:
2864         * public/WebFileSystemEntry.h:
2865         * public/WebFileWriter.h:
2866         * public/WebFileWriterClient.h:
2867         * public/WebFindOptions.h:
2868         * public/WebFont.h:
2869         * public/WebFontCache.h:
2870         * public/WebFontDescription.h:
2871         * public/WebFormControlElement.h:
2872         * public/WebFormElement.h:
2873         * public/WebFrame.h:
2874         * public/WebFrameClient.h:
2875         * public/WebGeolocationClientMock.h:
2876         * public/WebGeolocationController.h:
2877         * public/WebGeolocationError.h:
2878         * public/WebGeolocationPermissionRequest.h:
2879         * public/WebGeolocationPermissionRequestManager.h:
2880         * public/WebGeolocationPosition.h:
2881         * public/WebGlyphCache.h:
2882         * public/WebHelperPlugin.h:
2883         * public/WebHistoryItem.h:
2884         * public/WebHitTestResult.h:
2885         * public/WebIDBCallbacks.h:
2886         * public/WebIDBCursor.h:
2887         * public/WebIDBDatabase.h:
2888         * public/WebIDBDatabaseCallbacks.h:
2889         * public/WebIDBDatabaseError.h:
2890         * public/WebIDBFactory.h:
2891         * public/WebIDBKey.h:
2892         * public/WebIDBKeyPath.h:
2893         * public/WebIDBKeyRange.h:
2894         * public/WebIDBMetadata.h:
2895         * public/WebIDBTransaction.h:
2896         * public/WebIDBTransactionCallbacks.h:
2897         * public/WebIconURL.h:
2898         * public/WebImageDecoder.h:
2899         * public/WebInputEvent.h:
2900         * public/WebIntent.h:
2901         * public/WebIntentRequest.h:
2902         * public/WebIntentServiceInfo.h:
2903         * public/WebKit.h:
2904         * public/WebMediaPlayer.h:
2905         * public/WebMediaStreamRegistry.h:
2906         * public/WebMenuItemInfo.h:
2907         * public/WebNetworkStateNotifier.h:
2908         * public/WebNode.h:
2909         * public/WebNodeCollection.h:
2910         * public/WebNodeList.h:
2911         * public/WebNotification.h:
2912         * public/WebNotificationPresenter.h:
2913         * public/WebOptionElement.h:
2914         * public/WebPageOverlay.h:
2915         * public/WebPagePopup.h:
2916         * public/WebPageSerializer.h:
2917         * public/WebPasswordFormData.h:
2918         * public/WebPerformance.h:
2919         * public/WebPlugin.h:
2920         * public/WebPluginContainer.h:
2921         * public/WebPluginParams.h:
2922         * public/WebPopupMenu.h:
2923         * public/WebPopupMenuInfo.h:
2924         * public/WebPrerendererClient.h:
2925         * public/WebPrintParams.h:
2926         * public/WebRange.h:
2927         * public/WebRegularExpression.h:
2928         * public/WebRuntimeFeatures.h:
2929         * public/WebScopedMicrotaskSuppression.h:
2930         * public/WebScopedUserGesture.h:
2931         * public/WebScriptController.h:
2932         * public/WebScriptSource.h:
2933         * public/WebSearchableFormData.h:
2934         * public/WebSecurityOrigin.h:
2935         * public/WebSecurityPolicy.h:
2936         * public/WebSelectElement.h:
2937         * public/WebSerializedScriptValue.h:
2938         * public/WebSettings.h:
2939         * public/WebSharedWorker.h:
2940         * public/WebSharedWorkerRepository.h:
2941         * public/WebSocket.h:
2942         * public/WebSocketClient.h:
2943         * public/WebSpeechGrammar.h:
2944         * public/WebSpeechInputController.h:
2945         * public/WebSpeechInputResult.h:
2946         * public/WebSpeechRecognitionHandle.h:
2947         * public/WebSpeechRecognitionParams.h:
2948         * public/WebSpeechRecognitionResult.h:
2949         * public/WebSpeechRecognizer.h:
2950         * public/WebSpeechRecognizerClient.h:
2951         * public/WebSpellCheckClient.h:
2952         * public/WebStorageEventDispatcher.h:
2953         * public/WebSurroundingText.h:
2954         * public/WebTestingSupport.h:
2955         * public/WebTextCheckingCompletion.h:
2956         * public/WebTextCheckingResult.h:
2957         * public/WebTextFieldDecoratorClient.h:
2958         * public/WebTextInputInfo.h:
2959         * public/WebTextRun.h:
2960         * public/WebTimeRange.h:
2961         * public/WebTouchPoint.h:
2962         * public/WebUserMediaRequest.h:
2963         * public/WebView.h:
2964         * public/WebViewBenchmarkSupport.h:
2965         * public/WebViewClient.h:
2966         * public/WebWidget.h:
2967         * public/WebWidgetClient.h:
2968         * public/WebWindowFeatures.h:
2969         * public/WebWorkerInfo.h:
2970         * public/android/WebInputEventFactory.h:
2971         * public/android/WebSandboxSupport.h:
2972         * public/default/WebRenderTheme.h:
2973         * public/gtk/WebInputEventFactory.h:
2974         * public/linux/WebFontRendering.h:
2975         * public/linux/WebSandboxSupport.h:
2976         * public/mac/WebInputEventFactory.h:
2977         * public/mac/WebSandboxSupport.h:
2978         * public/mac/WebScreenInfoFactory.h:
2979         * public/mac/WebSubstringUtil.h:
2980         * public/platform/WebAudioBus.h: Removed.
2981         * public/platform/WebAudioDevice.h: Removed.
2982         * public/platform/WebBlobData.h: Removed.
2983         * public/platform/WebBlobRegistry.h: Removed.
2984         * public/platform/WebCString.h: Removed.
2985         * public/platform/WebCanvas.h: Removed.
2986         * public/platform/WebClipboard.h: Removed.
2987         * public/platform/WebColor.h: Removed.
2988         * public/platform/WebCommon.h: Removed.
2989         * public/platform/WebCookie.h: Removed.
2990         * public/platform/WebCookieJar.h: Removed.
2991         * public/platform/WebData.h: Removed.
2992         * public/platform/WebDragData.h: Removed.
2993         * public/platform/WebFileSystem.h: Removed.
2994         * public/platform/WebFloatPoint.h: Removed.
2995         * public/platform/WebFloatQuad.h: Removed.
2996         * public/platform/WebFloatRect.h: Removed.
2997         * public/platform/WebGamepad.h: Removed.
2998         * public/platform/WebGamepads.h: Removed.
2999         * public/platform/WebGraphicsContext3D.h: Removed.
3000         * public/platform/WebHTTPBody.h: Removed.
3001         * public/platform/WebHTTPHeaderVisitor.h: Removed.
3002         * public/platform/WebHTTPLoadInfo.h: Removed.
3003         * public/platform/WebImage.h: Removed.
3004         * public/platform/WebLocalizedString.h: Removed.
3005         * public/platform/WebMediaStreamCenter.h: Removed.
3006         * public/platform/WebMediaStreamCenterClient.h: Removed.
3007         * public/platform/WebMediaStreamComponent.h: Removed.
3008         * public/platform/WebMediaStreamDescriptor.h: Removed.
3009         * public/platform/WebMediaStreamSource.h: Removed.
3010         * public/platform/WebMediaStreamSourcesRequest.h: Removed.
3011         * public/platform/WebNonCopyable.h: Removed.
3012         * public/platform/WebPoint.h: Removed.
3013         * public/platform/WebPrivateOwnPtr.h: Removed.
3014         * public/platform/WebPrivatePtr.h: Removed.
3015         * public/platform/WebRect.h: Removed.
3016         * public/platform/WebReferrerPolicy.h: Removed.
3017         * public/platform/WebSize.h: Removed.
3018         * public/platform/WebSocketStreamError.h: Removed.
3019         * public/platform/WebSocketStreamHandle.h: Removed.
3020         * public/platform/WebSocketStreamHandleClient.h: Removed.
3021         * public/platform/WebString.h: Removed.
3022         * public/platform/WebThread.h: Removed.
3023         * public/platform/WebThreadSafeData.h: Removed.
3024         * public/platform/WebURL.h: Removed.
3025         * public/platform/WebURLError.h: Removed.
3026         * public/platform/WebURLLoadTiming.h: Removed.
3027         * public/platform/WebURLLoader.h: Removed.
3028         * public/platform/WebURLLoaderClient.h: Removed.
3029         * public/platform/WebURLRequest.h: Removed.
3030         * public/platform/WebURLResponse.h: Removed.
3031         * public/platform/WebVector.h: Removed.
3032         * public/platform/android/WebSandboxSupport.h: Removed.
3033         * public/platform/android/WebThemeEngine.h: Removed.
3034         * public/platform/default/WebThemeEngine.h: Removed.
3035         * public/platform/linux/WebFontFamily.h: Removed.
3036         * public/platform/linux/WebSandboxSupport.h: Removed.
3037         * public/platform/mac/WebSandboxSupport.h: Removed.
3038         * public/platform/mac/WebThemeEngine.h: Removed.
3039         * public/platform/win/WebSandboxSupport.h: Removed.
3040         * public/platform/win/WebThemeEngine.h: Removed.
3041         * public/win/WebInputEventFactory.h:
3042         * public/win/WebSandboxSupport.h:
3043         * public/win/WebScreenInfoFactory.h:
3044         * public/x11/WebScreenInfoFactory.h:
3045
3046 2013-01-23  Joshua Bell  <jsbell@chromium.org>
3047
3048         IndexedDB: Remove IDBVersionChangeRequest
3049         https://bugs.webkit.org/show_bug.cgi?id=107711
3050
3051         Reviewed by Tony Chang.
3052
3053         * public/WebIDBCallbacks.h: Note to delete onBlocked() once Chromium is cleaned up.
3054         * src/IDBCallbacksProxy.cpp: Remove unused onBlocked() overload.
3055         * src/IDBCallbacksProxy.h: Ditto.
3056         * src/WebIDBCallbacksImpl.cpp: Ditto.
3057         * src/WebIDBCallbacksImpl.h: Ditto.
3058         * tests/IDBAbortOnCorruptTest.cpp: Ditto.
3059         * tests/IDBDatabaseBackendTest.cpp: Ditto.
3060
3061 2013-01-23  Tien-Ren Chen  <trchen@chromium.org>
3062
3063         Partially revert 104427, change WebWidgetClient::didHandleGestureEvent semantics.
3064         https://bugs.webkit.org/show_bug.cgi?id=107605
3065
3066         Reviewed by Darin Fisher.
3067
3068         Per discussion in https://codereview.chromium.org/11473027/ we decided
3069         not to introduce an enum to WebWidgetClient::didHandleGestureEvent().
3070         Instead, change the semantics of the bool flag to indicate whether the
3071         gesture event is cancelled for disambiguation.
3072
3073         * public/WebWidgetClient.h:
3074         (WebKit::WebWidgetClient::didHandleGestureEvent):
3075         * src/WebViewImpl.cpp:
3076         (WebKit::WebViewImpl::handleGestureEvent):
3077         * tests/WebViewTest.cpp:
3078
3079 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
3080
3081         [Chromium] Remove WebArrayBufferView and WebSerializedScriptValue from chromium/public/platform/
3082         https://bugs.webkit.org/show_bug.cgi?id=107720
3083
3084         Reviewed by Darin Fisher.
3085
3086         These headers have been moved to chromium/public/ and all
3087         references downstream were changed in
3088         https://codereview.chromium.org/11946050/.
3089         No DEPS roll necessary because it's already above 177695.
3090
3091         * WebKit.gyp:
3092         * public/platform/WebArrayBufferView.h: Removed.
3093         * public/platform/WebSerializedScriptValue.h: Removed.
3094         * src/DeliveredIntentClientImpl.cpp:
3095         * src/IDBCallbacksProxy.cpp:
3096         * src/IDBCursorBackendProxy.cpp:
3097         * src/WebArrayBufferView.cpp:
3098         * src/WebBindings.cpp:
3099         * src/WebDOMCustomEvent.cpp:
3100         * src/WebDOMMessageEvent.cpp:
3101         * src/WebFrameImpl.cpp:
3102         * src/WebHistoryItem.cpp:
3103         * src/WebIDBCallbacksImpl.cpp:
3104         * src/WebIntent.cpp:
3105         * src/WebIntentRequest.cpp:
3106         * src/WebSerializedScriptValue.cpp:
3107
3108 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
3109
3110         [Chromium] Fix some #includes to headers in chromium/public/platform/ that have been moved to the new Platform directory
3111         https://bugs.webkit.org/show_bug.cgi?id=107722
3112
3113         Reviewed by Darin Fisher.
3114
3115         These headers just redirect to the new versions, so call the new
3116         versions directly.
3117
3118         * src/linux/WebFontInfo.cpp:
3119         * src/mac/WebSubstringUtil.mm:
3120
3121 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
3122
3123         [Chromium] Fix some #includes for WebSerializedScriptValue
3124         https://bugs.webkit.org/show_bug.cgi?id=107697
3125
3126         Reviewed by Adam Barth.
3127
3128         WebSerializedScriptValue has been moved to chromium/public/.
3129
3130         * public/WebDOMCustomEvent.h:
3131         * public/WebDOMMessageEvent.h:
3132         * public/WebIDBCursor.h:
3133
3134 2013-01-23  Dmitry Gozman  <dgozman@chromium.org>
3135
3136         Added changeAttachedWindowHeight method to inspector frontend API, which
3137         allows to change inspector window height from inside.
3138         https://bugs.webkit.org/show_bug.cgi?id=107648
3139
3140         Reviewed by Pavel Feldman.
3141
3142         * public/WebDevToolsFrontendClient.h:
3143         (WebKit::WebDevToolsFrontendClient::changeAttachedWindowHeight):
3144         * src/InspectorFrontendClientImpl.cpp:
3145         (WebKit::InspectorFrontendClientImpl::changeAttachedWindowHeight):
3146
3147 2013-01-23  Shinya Kawanaka  <shinyak@chromium.org>
3148
3149         shadowAncestorNode() should be renamed to deprecatedShadowAncestorNode()
3150         https://bugs.webkit.org/show_bug.cgi?id=107624
3151
3152         Reviewed by Dimitri Glazkov.
3153
3154         Since Node::shadowAncestorNode() is deprecated, we would like to rename it to prevent from further use.
3155
3156         * src/WebFrameImpl.cpp:
3157         (WebKit::WebFrameImpl::scopeStringMatches):
3158         (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
3159
3160 2013-01-22  Pavel Feldman  <pfeldman@chromium.org>
3161
3162         Web Inspector: only allow evaluateForTestInFrontend for front-ends under test.
3163         https://bugs.webkit.org/show_bug.cgi?id=107523
3164
3165         Reviewed by Yury Semikhatsky.
3166
3167         * public/WebDevToolsFrontendClient.h:
3168         (WebKit::WebDevToolsFrontendClient::isUnderTest):
3169         (WebDevToolsFrontendClient):
3170         * src/InspectorFrontendClientImpl.cpp:
3171         (WebKit::InspectorFrontendClientImpl::isUnderTest):
3172         * src/InspectorFrontendClientImpl.h:
3173         (InspectorFrontendClientImpl):
3174
3175 2013-01-22  Mark Lam  <mark.lam@apple.com>
3176
3177         Change the Supplementable class to not use AtomicString.
3178         https://bugs.webkit.org/show_bug.cgi?id=107535.
3179
3180         Reviewed by Adam Barth.
3181
3182         Replaced the use of AtomicString keys with literal const char* keys.
3183         This simplifies the SupplementMap and makes it slightly leaner and faster.
3184
3185         * src/ContextFeaturesClientImpl.cpp:
3186         (ContextFeaturesCache):
3187         (WebKit::ContextFeaturesCache::supplementName):
3188
3189 2013-01-22  Leandro Gracia Gil  <leandrogracia@chromium.org>
3190
3191         [Chromium] Expose didCommitCompositorFrame in WebWidgetClient.
3192         https://bugs.webkit.org/show_bug.cgi?id=107325
3193
3194         Reviewed by James Robinson.
3195
3196         Add a notification on WebWidgetClient called when the compositor commits a frame.
3197
3198         * public/WebWidgetClient.h:
3199         (WebWidgetClient):
3200         (WebKit::WebWidgetClient::didCommitCompositorFrame):
3201         * src/WebViewImpl.cpp:
3202         (WebKit::WebViewImpl::didCommit):
3203
3204 2013-01-21  Kentaro Hara  <haraken@chromium.org>
3205
3206         Implement UIEvent constructor
3207         https://bugs.webkit.org/show_bug.cgi?id=107430
3208
3209         Reviewed by Adam Barth.
3210
3211         Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
3212
3213         UIEvent constructor is implemented under a DOM4_EVENTS_CONSTRUCTOR flag,
3214         which is enabled on Safari and Chromium for now.
3215
3216         * features.gypi:
3217
3218 2013-01-22  Alpha Lam  <hclam@chromium.org>
3219
3220         REGRESSION(r140392): InjectIDBKeyTest.TopLevelPropertyStringValue is crashing
3221         https://bugs.webkit.org/show_bug.cgi?id=107578
3222
3223         Unreviewed build fix. Disabled 2 tests that are crashing after r140392.
3224
3225         * tests/IDBBindingUtilitiesTest.cpp:
3226         (WebKit::TEST_F):
3227
3228 2013-01-22  Eric Seidel  <eric@webkit.org>
3229
3230         Turn on ENABLE_THREADED_HTML_PARSER for Chromium (it's still disabled at runtime)
3231         https://bugs.webkit.org/show_bug.cgi?id=107519
3232
3233         Reviewed by Adam Barth.
3234
3235         This makes our development lives easier, and makes it possible for the bots
3236         to run threaded-parser-only tests by toggling the runtime enable
3237         via window.internals.settings.
3238
3239         * features.gypi:
3240
3241 2013-01-22  Kentaro Hara  <haraken@chromium.org>
3242
3243         [V8] Make an Isolate parameter mandatory in toV8()
3244         https://bugs.webkit.org/show_bug.cgi?id=107520
3245
3246         Reviewed by Adam Barth.
3247
3248         Now it's safe to remove an optional Isolate parameter.
3249
3250         No tests. No change in behavior.
3251
3252         * src/InspectorFrontendClientImpl.cpp:
3253         (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
3254         * src/WebArrayBuffer.cpp:
3255         (WebKit::WebArrayBuffer::toV8Value):
3256         * src/WebBlob.cpp:
3257         (WebKit::WebBlob::toV8Value):
3258         * src/WebFrameImpl.cpp:
3259         (WebKit::WebFrameImpl::createFileSystem):
3260         (WebKit::WebFrameImpl::createSerializableFileSystem):
3261         (WebKit::WebFrameImpl::createFileEntry):
3262
3263 2013-01-21  Sheriff Bot  <webkit.review.bot@gmail.com>
3264
3265         Unreviewed.  Rolled Chromium DEPS to r177962.  Requested by
3266         "Yoshifumi Inoue" <yosin@chromium.org> via sheriffbot.
3267
3268         * DEPS:
3269
3270 2013-01-21  Noel Gordon  <noel.gordon@gmail.com>
3271
3272         [chromium] REGRESSION(r139347) roll chromium deps broke webkit-unit-tests
3273         https://bugs.webkit.org/show_bug.cgi?id=106631
3274
3275         Reviewed by Kent Tamura.
3276
3277         Fixed in http://crrev.com/177931 and rolled. Renable these tests.
3278
3279         * tests/WebImageTest.cpp:
3280
3281 2013-01-21  Dirk Schulze  <dschulze@adobe.com>
3282
3283         Add build flag for Canvas's Path object (disabled by default)
3284         https://bugs.webkit.org/show_bug.cgi?id=107473
3285
3286         Reviewed by Dean Jackson.
3287
3288         Add CANVAS_PATH build flag to build systems.
3289
3290         * features.gypi:
3291
3292 2013-01-21  Sheriff Bot  <webkit.review.bot@gmail.com>
3293
3294         Unreviewed.  Rolled Chromium DEPS to r177956.  Requested by
3295         thakis_ via sheriffbot.
3296
3297         * DEPS:
3298
3299 2013-01-21  Sheriff Bot  <webkit.review.bot@gmail.com>
3300
3301         Unreviewed.  Rolled Chromium DEPS to r177953.  Requested by
3302         thakis_ via sheriffbot.
3303
3304         * DEPS:
3305
3306 2013-01-21  Tommy Widenflycht  <tommyw@google.com>
3307
3308         MediaStream API: Update the RTCPeerConnection states to match the latest specification
3309         https://bugs.webkit.org/show_bug.cgi?id=107120
3310
3311         Reviewed by Adam Barth.
3312
3313         * src/AssertMatchingEnums.cpp:
3314
3315 2013-01-20  Dominic Mazzoni  <dmazzoni@google.com>
3316
3317         Make SpeechSynthesis compile in the Chromium port
3318         https://bugs.webkit.org/show_bug.cgi?id=107382
3319
3320         Reviewed by Adam Barth.
3321
3322         Add ENABLE_SPEECH_SYNTHESIS to features.gypi, off by default.
3323
3324         * features.gypi:
3325
3326 2013-01-20  Yoshifumi Inoue  <yosin@chromium.org>
3327
3328         Dragging over an element with scrollbars should scroll the element when dragging near edges
3329         https://bugs.webkit.org/show_bug.cgi?id=39725
3330
3331         Reviewed by Hajime Morita.
3332
3333         This patch removes DragScrollTimer used for automatic scrolling of main
3334         frame drag-and-drop which is now implemented in EventHandler.
3335
3336         Another patch will remove DragScrollTimer.{cpp,h} and update GYP files to
3337         make patch size small.
3338
3339         No tests. Existing test covers this change.
3340
3341         * src/ChromeClientImpl.cpp:
3342         (WebKit::ChromeClientImpl::shouldAutoscrollForDragAndDrop): Added.
3343         * src/ChromeClientImpl.h:
3344         (ChromeClientImpl): Changed to add shouldAutoscrollForDragAndDrop().
3345         * src/WebViewImpl.cpp:
3346         (WebKit::WebViewImpl::WebViewImpl): Changed to remove m_dragScrollTimer.
3347         (WebKit::WebViewImpl::dragSourceEndedAt): ditto
3348         (WebKit::WebViewImpl::dragSourceMovedTo): ditto
3349         (WebKit::WebViewImpl::dragTargetDrop): ditto
3350         (WebKit::WebViewImpl::dragTargetDragEnterOrOver): ditto
3351         * src/WebViewImpl.h:
3352         (WebKit): Chagned to remove DragScrollTimer.
3353
3354 2013-01-18  Alec Flett  <alecflett@chromium.org>
3355
3356         IndexedDB: Switch to new createTransaction call
3357         https://bugs.webkit.org/show_bug.cgi?id=107311
3358
3359         Reviewed by Tony Chang.
3360
3361         * public/WebIDBTransaction.h:
3362
3363         Remove an old method that nobody calls.
3364
3365 2013-01-18  Alpha Lam  <hclam@chromium.org>
3366
3367         [chromium] Roll Chromium DEPS to 177676
3368
3369         Unreviewed DEPS roll.
3370
3371         * DEPS:
3372
3373 2013-01-18  Robert Kroeger  <rjkroege@chromium.org>
3374
3375         [chromium] Use new-style gesture scrolling events for fling and
3376         for plugin scrolling: https://bugs.webkit.org/show_bug.cgi?id=106589
3377
3378         Reviewed by James Robinson.
3379
3380         https://bugs.webkit.org/show_bug.cgi?id=103952 modified touchscreen
3381         scrolling to not use synthetic mouse wheel events. Update the fling facility
3382         in WebViewImpl to use these events for touchscreen-initiated flings. Also
3383         modify the WebPluginContainerImpl to scroll in response to touchscreen
3384         scroll gestures if the plugin does not itself implement gesture events. 
3385
3386         * src/WebPluginContainerImpl.cpp:
3387         * src/WebViewImpl.cpp:
3388         (WebKit::WebViewImpl::WebViewImpl):
3389         (WebKit::WebViewImpl::scrollBy): Handle fling callback conditionally based
3390         on initiating device. Touchpad flings generate wheels. Touchscreen flings
3391         use gesture events.
3392         (WebKit::WebViewImpl::handleGestureEvent):
3393         (WebKit::WebViewImpl::transferActiveWheelFlingAnimation):
3394         * src/WebViewImpl.h:
3395
3396 2013-01-18  Seokju Kwon  <seokju.kwon@gmail.com>
3397
3398         Add explicit keyword to constructors in platform-specific InspectorClient
3399         https://bugs.webkit.org/show_bug.cgi?id=107255
3400
3401         Reviewed by Kentaro Hara.
3402
3403         Add explicit keyword to constructors that take one argument
3404         in platform-specific implementation of InspectorClient.
3405
3406         * src/InspectorClientImpl.h:
3407         (InspectorClientImpl):
3408
3409 2013-01-17  Dominic Cooney  <dominicc@chromium.org>
3410
3411         [Chromium] Unreviewed gardening.
3412
3413         Roll Chromium to 177561.
3414
3415         * DEPS:
3416
3417 2013-01-17  Alpha Lam  <hclam@chromium.org>
3418
3419         [chromium] Disable a unit test
3420         https://bugs.webkit.org/show_bug.cgi?id=107206
3421
3422         Unreviewed. Disable a failing test due to 140025.
3423
3424         * tests/WebFrameTest.cpp:
3425
3426 2013-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3427
3428         Unreviewed, rolling out r140023.
3429         http://trac.webkit.org/changeset/140023
3430         https://bugs.webkit.org/show_bug.cgi?id=107176
3431
3432         Broke some tests (Requested by anttik on #webkit).
3433
3434         * tests/RenderTableCellTest.cpp:
3435         * tests/RenderTableRowTest.cpp:
3436
3437 2013-01-17  John Mellor  <johnme@chromium.org>
3438
3439         [chromium] Double-tap zoom should take into account accessibility fontScaleFactor
3440         https://bugs.webkit.org/show_bug.cgi?id=107123
3441
3442         Reviewed by Adam Barth.
3443
3444         Platforms which support Text Autosizing (currently just Chrome for
3445         Android) may provide a textAutosizingFontScaleFactor (defaults to 1.0).
3446
3447         This value is intended to be chosen by the user to indicate how large
3448         they want text to appear, for example Chrome for Android has a "Text
3449         scaling" slider in Settings > Accessibility that lets you choose a value
3450         in the range 50% - 200% (defaults to 100%*).
3451
3452         For text in wide columns that typically gets autosized, this value is
3453         applied by multiplying the textAutosizingMultiplier computed for each
3454         cluster by the textAutosizingFontScaleFactor. Double-tap zoom will fit
3455         the column to the screen (ignoring the textAutosizingFontScaleFactor)
3456         since the column is wide. This part already works.
3457
3458         For text in narrow columns that doesn't get autosized, the
3459         textAutosizingFontScaleFactor is not applied through Text Autosizing,
3460         and instead needs to be applied by adjusting the double-tap zoom level.
3461         When double-tapping on narrow columns, instead of fitting the column to
3462         the screen (which would often zoom in excessively far), the existing
3463         logic in computeScaleAndScrollForHitRect applies a maximum zoom level
3464         called the legibleScale. This value needs to be multiplied by the
3465         textAutosizingFontScaleFactor, so that we zoom in proportionately
3466         further on non-autosized narrow columns, hence the effective text size
3467         (taking into account zoom) will have increased in proportion to the
3468         textAutosizingFontScaleFactor as expected.
3469
3470         * src/WebViewImpl.cpp:
3471         (WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
3472             Multiplies legibleScale (the maximum zoom level) by the
3473             textAutosizingFontScaleFactor.
3474         * tests/WebFrameTest.cpp:
3475             Added WebFrameTest.DivAutoZoomScaleFontScaleFactorTest based on
3476             WebFrameTest.DivAutoZoomScaleBoundsTest to test the interaction
3477             between textAutosizingFontScaleFactor and the double-tap zoom logic.
3478             Also did minor cleanup to WebFrameTest.DivAutoZoomScaleBoundsTest.
3479
3480 2013-01-17  Alexandre Elias  <aelias@chromium.org>
3481
3482         [chromium] Make new-style page scale work with fixed layout
3483         https://bugs.webkit.org/show_bug.cgi?id=106951
3484
3485         Reviewed by Adam Barth.
3486
3487         This makes non-CSS-transform page scaling work with fixed-layout mode,
3488         including viewport tag support.
3489
3490         - dispatchViewportPropertiesDidChange() now works entirely with DIP
3491         pixels instead of physical pixels, and is made compatible with
3492         separating deviceScaleFactor from pageScaleFactor.
3493
3494         - In this mode, the "layout viewport" size in the pinch-zoom model is
3495         made a first-class concept separate from the device size.  This
3496         is a viewport with the same aspect ratio as the device but with the
3497         layout width of the page.  This viewport is used:
3498           - As FrameView::visibleContentRect.
3499           - Returned from WebView::size().
3500           - Given to the compositor as layoutViewportSize.
3501
3502         - m_deviceScaleInCompositor is deleted as it's clearer to use the
3503         applyDeviceScaleInCompositor setting directly.
3504
3505         * src/ChromeClientImpl.cpp:
3506         (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
3507         * src/WebViewImpl.cpp:
3508         (WebKit::WebViewImpl::WebViewImpl):
3509         (WebKit::WebViewImpl::size):
3510         (WebKit):
3511         (WebKit::WebViewImpl::resize):
3512         (WebKit::WebViewImpl::setPageScaleFactor):
3513         (WebKit::WebViewImpl::setDeviceScaleFactor):
3514         (WebKit::WebViewImpl::layoutSize):
3515         (WebKit::WebViewImpl::computePageScaleFactorLimits):
3516         (WebKit::WebViewImpl::dipSize):
3517         (WebKit::WebViewImpl::didChangeContentsSize):
3518         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
3519         (WebKit::WebViewImpl::updateLayerTreeViewport):
3520         * src/WebViewImpl.h:
3521         (WebViewImpl):
3522
3523 2013-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3524
3525         Unreviewed.  Rolled Chromium DEPS to r177369.  Requested by
3526         ajuma via sheriffbot.
3527
3528         * DEPS:
3529
3530 2013-01-17  Eugene Klyuchnikov  <eustas@chromium.org>
3531
3532         Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
3533         https://bugs.webkit.org/show_bug.cgi?id=104545
3534
3535         Reviewed by Yury Semikhatsky.
3536
3537         Adopt changes: mimic old behavior.
3538
3539         * src/WebDevToolsAgentImpl.cpp: Adopt signature changes.
3540
3541 2013-01-17  Yury Semikhatsky  <yurys@chromium.org>
3542
3543         Web Inspector: add WebDeToolsAgentImpl as task observer on reattach
3544         https://bugs.webkit.org/show_bug.cgi?id=107106
3545
3546         Reviewed by Pavel Feldman.
3547
3548         Register WebDevToolsAgentImpl as task observer when it client is reattached.
3549
3550         * src/WebDevToolsAgentImpl.cpp:
3551         (WebKit::WebDevToolsAgentImpl::reattach):
3552
3553 2013-01-16  Dominic Cooney   <dominicc@chromium.org>
3554
3555         [Chromium] Unreviewed gardening.
3556
3557         Roll Chromium to 177350.
3558
3559         * DEPS:
3560
3561 2013-01-16  Kristian Monsen  <kristianm@google.com>
3562
3563         Fix build break for Android webview.
3564         https://bugs.webkit.org/show_bug.cgi?id=107072
3565
3566         Reviewed by Steve Block.
3567
3568         Add extra guards when checking for OS=="Android" to make sure it is not included
3569         for webview.
3570
3571         * WebKitUnitTests.gyp:
3572
3573 2013-01-16  Dominic Cooney  <dominicc@chromium.org>
3574
3575         [Chromium] Unreviewed gardening.
3576
3577         Roll Chromium to 177310.
3578
3579         * DEPS:
3580
3581 2013-01-16  W. James MacLean  <wjmaclean@chromium.org>
3582
3583         LinkHighlight should use touch adjustment to match active state on GestureTapDown.
3584         https://bugs.webkit.org/show_bug.cgi?id=107032
3585
3586         Reviewed by Adam Barth.
3587
3588         LinkHighlight node selection should produce results that match the node marked
3589         active during GestureTapDown.
3590
3591         * src/WebViewImpl.cpp:
3592         (WebKit::WebViewImpl::bestTouchLinkNode):
3593         * tests/LinkHighlightTest.cpp:
3594         (WebCore::TEST):
3595
3596 2013-01-16  Kentaro Hara  <haraken@chromium.org>
3597
3598         [V8] Make a creationContext parameter of toV8() mandatory
3599         https://bugs.webkit.org/show_bug.cgi?id=107020
3600
3601         Reviewed by Adam Barth.
3602
3603         We pass Handle<Object>() to a creationContext parameter of
3604         toV8() when we do not have a creationContext.
3605
3606         No tests. No change in behavior.
3607
3608         * src/InspectorFrontendClientImpl.cpp:
3609         (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
3610         * src/WebArrayBuffer.cpp:
3611         (WebKit::WebArrayBuffer::toV8Value):
3612         * src/WebBlob.cpp:
3613         (WebKit::WebBlob::toV8Value):
3614         * src/WebFrameImpl.cpp:
3615         (WebKit::WebFrameImpl::createFileSystem):
3616         (WebKit::WebFrameImpl::createSerializableFileSystem):
3617         (WebKit::WebFrameImpl::createFileEntry):
3618
3619 2013-01-16  Mark Pilgrim  <pilgrim@chromium.org>
3620
3621         [Chromium] Move WebArrayBufferView and WebSerializedScriptValue out of public/platform/
3622         https://bugs.webkit.org/show_bug.cgi?id=106863
3623
3624         Reviewed by Adam Barth.
3625
3626         These are not being moved into the new top-level Platform
3627         directory, so into public they go.
3628
3629         * WebKit.gyp:
3630         * public/WebArrayBufferView.h: Added.
3631         (v8):
3632         (WebKit):
3633         (WebArrayBufferView):
3634         (WebKit::WebArrayBufferView::~WebArrayBufferView):
3635         (WebKit::WebArrayBufferView::WebArrayBufferView):
3636         * public/WebSerializedScriptValue.h: Added.
3637         (v8):
3638         (WebKit):
3639         (WebSerializedScriptValue):
3640         (WebKit::WebSerializedScriptValue::~WebSerializedScriptValue):
3641         (WebKit::WebSerializedScriptValue::WebSerializedScriptValue):
3642         (WebKit::WebSerializedScriptValue::operator=):
3643         (WebKit::WebSerializedScriptValue::isNull):
3644         * public/platform/WebArrayBufferView.h:
3645         * public/platform/WebSerializedScriptValue.h:
3646
3647 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
3648
3649         [Chromium] Remove hardcoded chromium_*.jar in gyp files
3650         https://bugs.webkit.org/show_bug.cgi?id=104049
3651
3652         Reviewed by Eric Seidel.
3653
3654         Targets with dependencies (direct/indirect) on a java target receive
3655         the chromium_*.jar paths in the variable input_jars_paths. Targets
3656         should use that rather than hardcoding where they think the jar will
3657         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
3658         than as --jars to generate_native_test.py.
3659
3660         * WebKitUnitTests.gyp:
3661
3662 2013-01-16  Dominic Cooney   <dominicc@chromium.org>
3663
3664         [Chromium] Unreviewed gardening.
3665
3666         Roll Chromium to 177117.
3667
3668         * DEPS:
3669
3670 2013-01-16  Dominic Cooney  <dominicc@chromium.org>
3671
3672         [Chromium] Unreviewed gardening.
3673
3674         Roll Chromium to r177080.
3675
3676         * DEPS:
3677
3678 2013-01-15  Ian Vollick  <vollick@chromium.org>
3679
3680         [chromium] Create GraphicsLayerChromiums using a factory
3681         https://bugs.webkit.org/show_bug.cgi?id=103635
3682
3683         Reviewed by James Robinson.
3684
3685         Refactor graphics layer creation for chromium to go through a factory.
3686
3687         * src/ChromeClientImpl.cpp:
3688         (WebCore):
3689         (GraphicsLayerFactoryChromium):
3690         (WebCore::GraphicsLayerFactoryChromium::~GraphicsLayerFactoryChromium):
3691         (WebKit::ChromeClientImpl::ChromeClientImpl):
3692         (WebKit::ChromeClientImpl::graphicsLayerFactory):
3693         (WebKit):
3694         * src/ChromeClientImpl.h:
3695         (WebCore):
3696         (ChromeClientImpl):
3697         * src/NonCompositedContentHost.cpp:
3698         (WebKit::NonCompositedContentHost::NonCompositedContentHost):
3699         * src/NonCompositedContentHost.h:
3700         (WebCore):
3701         (WebKit::NonCompositedContentHost::create):
3702         (NonCompositedContentHost):
3703         * src/PageOverlay.cpp:
3704         (WebKit::PageOverlay::update):
3705         * src/WebViewImpl.cpp:
3706         (WebKit::WebViewImpl::graphicsLayerFactory):
3707         (WebKit):
3708         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
3709         * src/WebViewImpl.h:
3710         (WebCore):
3711         (WebViewImpl):
3712         * tests/GraphicsLayerChromiumTest.cpp:
3713         (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
3714         * tests/ImageLayerChromiumTest.cpp:
3715         (WebCore::TEST):
3716
3717 2013-01-15  Mark Pilgrim  <pilgrim@chromium.org>
3718
3719         [Chromium] Move SocketStreamHandle and SocketStreamHandleInternal to WebCore/platform
3720         https://bugs.webkit.org/show_bug.cgi?id=106899
3721
3722         Reviewed by Adam Barth.
3723
3724         Part of a larger refactoring series; see tracking bug 106829.
3725
3726         * WebKit.gyp:
3727         * src/SocketStreamHandle.cpp: Removed.
3728         * src/SocketStreamHandleInternal.h: Removed.
3729
3730 2013-01-15  Florin Malita  <fmalita@chromium.org>
3731
3732         [Chromium] Incorrect opaque region tracking for PlatformContextSkia::drawRRect
3733         https://bugs.webkit.org/show_bug.cgi?id=106898
3734
3735         Reviewed by Stephen White.
3736
3737         * tests/PlatformContextSkiaTest.cpp:
3738         (WebCore::TEST):
3739         (WebCore):
3740
3741 2012-12-28  Vsevolod Vlasov  <vsevik@chromium.org>
3742
3743         Web Inspector: Support inspector file system access with isolated file system through InspectorFrontendHost.
3744         https://bugs.webkit.org/show_bug.cgi?id=105727
3745
3746         Reviewed by Pavel Feldman.
3747
3748         File system access methods plumbing made for Chromium.
3749
3750         * public/WebDevToolsFrontendClient.h:
3751         (WebKit::WebDevToolsFrontendClient::requestFileSystems):
3752         (WebKit::WebDevToolsFrontendClient::addFileSystem):
3753         (WebKit::WebDevToolsFrontendClient::removeFileSystem):
3754         (WebDevToolsFrontendClient):
3755         * src/InspectorFrontendClientImpl.cpp:
3756         (WebKit::InspectorFrontendClientImpl::supportsFileSystems):
3757         (WebKit):
3758         (WebKit::InspectorFrontendClientImpl::requestFileSystems):
3759         (WebKit::InspectorFrontendClientImpl::addFileSystem):
3760         (WebKit::InspectorFrontendClientImpl::removeFileSystem):
3761         * src/InspectorFrontendClientImpl.h:
3762         (InspectorFrontendClientImpl):
3763
3764 2013-01-14  Dominic Cooney  <dominicc@chromium.org>
3765
3766         [Chromium] Unreviewed gardening.
3767
3768         Roll Chromium to r176801.
3769
3770         * DEPS: Rollin' on the river.
3771
3772 2013-01-14  Mark Pilgrim  <pilgrim@chromium.org>
3773
3774         [Chromium] Remove unused public/platform/WebColorName.h
3775         https://bugs.webkit.org/show_bug.cgi?id=106865
3776
3777         Reviewed by Adam Barth.
3778
3779         This file is no longer referenced anywhere in WebKit or Chromium.
3780
3781         * public/platform/WebColorName.h: Removed.
3782
3783 2013-01-14  Mark Pilgrim  <pilgrim@chromium.org>
3784
3785         [Chromium] Move BlobRegistryProxy into WebCore
3786         https://bugs.webkit.org/show_bug.cgi?id=106831
3787
3788         Reviewed by Adam Barth.
3789
3790         Part of a larger refactoring series to remove layering violations
3791         in Chromium. See tracking bug 106829.
3792
3793         * WebKit.gyp:
3794         * src/BlobRegistryProxy.cpp: Removed.
3795         * src/BlobRegistryProxy.h: Removed.
3796
3797 2013-01-14  Alec Flett  <alecflett@chromium.org>
3798
3799         IndexedDB: Remove IDBObjectStore/IndexBackendImpl and support functions
3800         https://bugs.webkit.org/show_bug.cgi?id=106605
3801
3802         Remove all references to IDBObjectStoreBackend* and IDBIndexBackend*
3803         as they no longer exist in WebCore.
3804
3805         Reviewed by Darin Fisher.
3806
3807         * WebKit.gyp:
3808         * public/WebIDBCallbacks.h:
3809         (WebKit):
3810         * public/WebIDBDatabase.h:
3811         (WebKit):
3812         (WebKit::WebIDBDatabase::metadata):
3813         * public/WebIDBFactory.h:
3814         (WebIDBFactory):
3815         * public/WebIDBIndex.h: Removed.
3816         * public/WebIDBObjectStore.h: Removed.
3817         * public/WebIDBTransaction.h:
3818         * src/IDBCallbacksProxy.cpp:
3819         * src/IDBDatabaseBackendProxy.cpp:
3820         * src/IDBDatabaseBackendProxy.h:
3821         (IDBDatabaseBackendProxy):
3822         * src/IDBFactoryBackendProxy.cpp:
3823         * src/IDBFactoryBackendProxy.h:
3824         (IDBFactoryBackendProxy):
3825         * src/IDBIndexBackendProxy.cpp: Removed.
3826         * src/IDBIndexBackendProxy.h: Removed.
3827         * src/IDBObjectStoreBackendProxy.cpp: Removed.
3828         * src/IDBObjectStoreBackendProxy.h: Removed.
3829         * src/IDBTransactionBackendProxy.cpp:
3830         * src/IDBTransactionBackendProxy.h:
3831         (IDBTransactionBackendProxy):
3832         * src/WebIDBDatabaseImpl.cpp:
3833         (WebKit::WebIDBDatabaseImpl::put):
3834         (WebKit::WebIDBDatabaseImpl::setIndexKeys):
3835         * src/WebIDBDatabaseImpl.h:
3836         (WebKit):
3837         (WebIDBDatabaseImpl):
3838         * src/WebIDBFactoryImpl.cpp:
3839         (WebKit::WebIDBFactoryImpl::getDatabaseNames):
3840         * src/WebIDBFactoryImpl.h:
3841         (WebIDBFactoryImpl):
3842         * src/WebIDBIndexImpl.cpp: Removed.
3843         * src/WebIDBIndexImpl.h: Removed.
3844         * src/WebIDBObjectStoreImpl.cpp: Removed.
3845         * src/WebIDBObjectStoreImpl.h: Removed.
3846         * src/WebIDBTransactionImpl.cpp:
3847         * src/WebIDBTransactionImpl.h:
3848         * tests/IDBAbortOnCorruptTest.cpp:
3849         (WebCore::TEST):
3850         * tests/IDBDatabaseBackendTest.cpp:
3851
3852 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
3853
3854         AX: Need to implement ColorWellRole
3855         https://bugs.webkit.org/show_bug.cgi?id=106756
3856
3857         Reviewed by Chris Fleizach.
3858
3859         Adds an accessibility interface to access the value of a
3860         color control.
3861
3862         * public/WebAccessibilityObject.h:
3863         (WebAccessibilityObject):
3864         * src/WebAccessibilityObject.cpp:
3865         (WebKit::WebAccessibilityObject::colorValue):
3866         (WebKit):
3867
3868 2013-01-14  Mark Pilgrim  <pilgrim@chromium.org>
3869
3870         [Chromium] Move AudioDestinationChromium into WebCore
3871         https://bugs.webkit.org/show_bug.cgi?id=106803
3872
3873         Reviewed by Adam Barth.
3874
3875         This doesn't really belong in WebKit/chromium/src since it defines
3876         things directly in the WebCore namespace.
3877
3878         * WebKit.gyp:
3879         * src/AudioDestinationChromium.cpp: Removed.
3880         * src/AudioDestinationChromium.h: Removed.
3881
3882 2013-01-14  Stephen Chenney  <schenney@chromium.org>
3883
3884         Re-enabling the SK_DISABLE_DASHING_OPTIMIZATION flag for Skia
3885
3886         Unreviewed build fix.
3887
3888         It turns out that the change behind this flag causes crashes and image errors.
3889
3890         * skia_webkit.gyp:
3891
3892 2013-01-14  Kentaro Hara  <haraken@chromium.org>
3893
3894         [V8] Make an Isolate parameter mandatory in ScriptDebugServer::interruptAndRun()
3895         https://bugs.webkit.org/show_bug.cgi?id=106779
3896
3897         Reviewed by Adam Barth.
3898
3899         This is one of steps to make an Isolate parameter mandatory.
3900
3901         No tests. No change in behavior.
3902
3903         * src/WebDevToolsAgentImpl.cpp:
3904         (WebKit::WebDevToolsAgent::interruptAndDispatch):
3905
3906 2013-01-13  Vsevolod Vlasov  <vsevik@chromium.org>
3907
3908         Web Inspector: [Chromium] DevToolsSanityTest.TestNoScriptDuplicatesOnPanelSwitch fails
3909         https://bugs.webkit.org/show_bug.cgi?id=106755
3910
3911         Reviewed by Alexander Pavlov.
3912
3913         * src/js/Tests.js:
3914         (.TestSuite.prototype.nonAnonymousUISourceCodes_.filterOutService):
3915         (.TestSuite.prototype.nonAnonymousUISourceCodes_):
3916
3917 2013-01-12  David Grogan  <dgrogan@chromium.org>
3918
3919         Unreviewed.  Roll chromium DEPS to 176595.
3920         https://bugs.webkit.org/show_bug.cgi?id=106730
3921
3922         * DEPS:
3923
3924 2013-01-11  Dan Beam  <dbeam@chromium.org>
3925
3926         [clean up] Remove HTMLFormElement::AutocompleteResultError in favor of more specific Error reasons
3927         https://bugs.webkit.org/show_bug.cgi?id=106610
3928
3929         Reviewed by Darin Fisher.
3930
3931         * public/WebFormElement.h: Removed WebFormElement::AutocompleteResultError in favor of more specific error reasons.
3932         * src/AssertMatchingEnums.cpp: Removed enum value from compile-time asserts.
3933
3934 2013-01-11  Tien-Ren Chen  <trchen@chromium.org>
3935
3936         WebWidgetClient::didHandleGestureEvent needs to distinguish the case if the event is processed or swallowed
3937         https://bugs.webkit.org/show_bug.cgi?id=104427
3938
3939         Reviewed by Adam Barth.
3940
3941         When a gesture needs to be disambiguated, WebKit doesn't update cursor focus.
3942         We added an extra status for didHandleGestureEvent(), so we can distinguish
3943         the case whether the event is actually delivered to the web page or cancelled.
3944
3945         * public/WebViewClient.h:
3946         * public/WebWidgetClient.h:
3947         (WebKit):
3948         (WebWidgetClient):
3949         (WebKit::WebWidgetClient::didHandleGestureEvent):
3950         * src/WebViewImpl.cpp:
3951         (WebKit::WebViewImpl::handleGestureEvent):
3952         * tests/WebViewTest.cpp:
3953
3954 2013-01-11  Eberhard Graether  <egraether@google.com>
3955
3956         [chromium] Add ContinuousPainter to call setNeedsDisplay on all layers recursively in continuous painting mode
3957         https://bugs.webkit.org/show_bug.cgi?id=105458
3958
3959         Reviewed by James Robinson.
3960
3961         In continuous painting mode all layers are constantly repainted to allow for life measurements of page paint time,
3962         while changing HTML and CSS using the WebInspector. This change adds the ContinuousPainter helper object, which
3963         calls setNeedsDisplay() on all GraphicsLayers recursively in order to force all layers to repaint. PageOverlay
3964         layers get excluded from being repainted, because their extra paint time is altering the page paint time metric.
3965
3966         * WebKit.gyp:
3967         * src/PageOverlay.h:
3968         (WebKit::PageOverlay::graphicsLayer):
3969         (PageOverlay):
3970         * src/PageOverlayList.cpp:
3971         (WebKit::PageOverlayList::findGraphicsLayer):
3972         (WebKit):
3973         * src/PageOverlayList.h:
3974         (WebCore):
3975         (PageOverlayList):
3976         * src/WebViewImpl.cpp:
3977         (WebKit::WebViewImpl::WebViewImpl):
3978         (WebKit::WebViewImpl::didBeginFrame):
3979         * src/WebViewImpl.h:
3980         * src/painting/ContinuousPainter.cpp: Copied from Source/WebKit/chromium/src/PageOverlay.h.
3981         (WebKit):
3982         (WebKit::ContinuousPainter::setNeedsDisplayRecursive):
3983         * src/painting/ContinuousPainter.h: Copied from Source/WebKit/chromium/src/PageOverlay.h.
3984         (WebCore):
3985         (WebKit):
3986         (ContinuousPainter):
3987
3988 2013-01-11  Tony Chang  <tony@chromium.org>
3989
3990         Unreviewed, revert r139157 to fix the chromium build.
3991         These files were deleted in a follow up and since r139044 was reverted, we need to
3992         add back these files.
3993
3994         * WebKit.gyp:
3995         * src/DragScrollTimer.cpp: Added.
3996         (WebKit):
3997         (WebKit::distanceToRect):
3998         (WebKit::DragScrollTimer::DragScrollTimer):
3999         (WebKit::DragScrollTimer::~DragScrollTimer):
4000         (WebKit::DragScrollTimer::stop):
4001         (WebKit::DragScrollTimer::scroll):
4002         (WebKit::DragScrollTimer::update):
4003         (WebKit::DragScrollTimer::triggerScroll):
4004         (WebKit::DragScrollTimer::scrollDistanceFor):
4005         * src/DragScrollTimer.h: Added.
4006         (WebKit):
4007         (DragScrollTimer):
4008         (WebKit::DragScrollTimer::fired):
4009         (WebKit::DragScrollTimer::shouldScroll):
4010
4011 2013-01-11  Sheriff Bot  <webkit.review.bot@gmail.com>
4012
4013         Unreviewed, rolling out r139044.
4014         http://trac.webkit.org/changeset/139044
4015         https://bugs.webkit.org/show_bug.cgi?id=106702
4016
4017         Caused various scrolling anomolies on Mac with drag and drop
4018         (Requested by smfr on #webkit).
4019
4020         * src/WebViewImpl.cpp:
4021         (WebKit::WebViewImpl::WebViewImpl):
4022         (WebKit::WebViewImpl::dragSourceEndedAt):
4023         (WebKit::WebViewImpl::dragSourceMovedTo):
4024         (WebKit::WebViewImpl::dragTargetDrop):
4025         (WebKit::WebViewImpl::dragTargetDragEnterOrOver):
4026         * src/WebViewImpl.h:
4027         (WebKit):
4028
4029 2013-01-11  Tony Chang  <tony@chromium.org>
4030
4031         [chromium] Don't regenerate all bindings when any idl file changes
4032         https://bugs.webkit.org/show_bug.cgi?id=106604
4033
4034         Reviewed by Kentaro Hara.
4035
4036         * gyp_webkit: Add Source/WebCore/WebCore.gyp/scripts to the python import search path
4037         so we can generate idl dependencies at gyp time.
4038
4039 2013-01-11  Stephen Chenney  <schenney@chromium.org>
4040
4041         Removing Skia flags that have been disabling oprtimizations and other improvements.
4042
4043         Unreviewed build fix.
4044
4045         These changes have been extensively tested by the Skia team, and
4046         WebKit test result changes will be monitored.
4047
4048         * skia_webkit.gyp:
4049
4050 2013-01-11  Pavel Feldman  <pfeldman@chromium.org>
4051
4052         Web Inspector [chromium]: toolbar border is missing on non-Mac in docked-to-bottom mode
4053         https://bugs.webkit.org/show_bug.cgi?id=106560
4054
4055         Reviewed by Vsevolod Vlasov.
4056
4057         * src/js/devTools.css:
4058         (body.dock-to-bottom.platform-mac #toolbar):
4059
4060 2013-01-10  Noel Gordon  <noel.gordon@gmail.com>
4061
4062         [chromium] Disable PNG and ICO image webkit-unit-tests after r139347
4063         https://bugs.webkit.org/show_bug.cgi?id=106631
4064
4065         Reviewed by Eric Seidel.
4066
4067         * tests/WebImageTest.cpp:
4068         (WebKit::TEST): Disable ICOImage and PNGImage tests on WIN and MAC to
4069         green their respective webkit-unit-test bots. The tests still pass on
4070         LINUX so keep test coverage there for now.
4071
4072 2013-01-10  Dan Beam  <dbeam@chromium.org>
4073
4074         Implement AutocompleteErrorEvent#reason
4075         https://bugs.webkit.org/show_bug.cgi?id=105568
4076
4077         Reviewed by Adam Barth.
4078
4079         * public/WebFormElement.h: Added matching enum values for public chromium WebKit API.
4080         * src/AssertMatchingEnums.cpp: Updated compile assert that WebKit and WebCore enums match.
4081
4082 2013-01-10  Adam Barth  <abarth@webkit.org>
4083
4084         Add an ENABLE macro and a WebCore::Setting for the threaded parser
4085         https://bugs.webkit.org/show_bug.cgi?id=106595
4086
4087         Reviewed by Benjamin Poulain.
4088
4089         Explicitly disable THREADED_HTML_PARSER for Chromium so that we can
4090         more easily enable it locally.
4091
4092         * features.gypi:
4093
4094 2013-01-10  John Mellor  <johnme@chromium.org>
4095
4096         Fix scale of screen.width, window.outerWidth and @media device-width when page scale not applied in compositor.
4097         https://bugs.webkit.org/show_bug.cgi?id=106460
4098
4099         Reviewed by Kenneth Rohde Christiansen.
4100
4101         1. Exposes the existing applyDeviceScaleFactorInCompositor from
4102         WebSettings on Settings (and stores the value there instead), so it can
4103         be accessed from WebCore.
4104
4105         2. Changes ChromeClientImpl::windowRect to return values in density
4106         independent (UI) pixels pixels instead of physical screen pixels (see
4107         explanation in Source/WebCore/ChangeLog).
4108
4109         * src/ChromeClientImpl.cpp:
4110         (WebKit::ChromeClientImpl::windowRect):
4111             Normalizes window rect sc