1 2013-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
3 Unreviewed, rolling out r142568.
4 http://trac.webkit.org/changeset/142568
5 https://bugs.webkit.org/show_bug.cgi?id=109541
7 Broke the build, won't compile. (Requested by alancutter on
10 * tests/GraphicsLayerChromiumTest.cpp:
11 (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
12 * tests/ScrollingCoordinatorChromiumTest.cpp:
13 (WebKit::FakeWebViewClient::initializeLayerTreeView):
15 2013-02-11 James Robinson <jamesr@chromium.org>
17 [chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
18 https://bugs.webkit.org/show_bug.cgi?id=109403
20 Reviewed by Adam Barth.
22 * tests/GraphicsLayerChromiumTest.cpp:
23 (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
24 * tests/ScrollingCoordinatorChromiumTest.cpp:
25 (WebKit::FakeWebViewClient::initializeLayerTreeView):
27 2013-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
29 Unreviewed. Rolled Chromium DEPS to r181817. Requested by
30 "James Robinson" <jamesr@chromium.org> via sheriffbot.
34 2013-02-11 David Grogan <dgrogan@chromium.org>
36 IndexedDB: Add UnknownError to WebIDBDatabaseException
37 https://bugs.webkit.org/show_bug.cgi?id=109519
39 Reviewed by Adam Barth.
41 * public/WebIDBDatabaseException.h:
42 * src/AssertMatchingEnums.cpp:
44 2013-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
46 Unreviewed. Rolled Chromium DEPS to r181787. Requested by
47 thakis_ via sheriffbot.
51 2013-02-11 Nico Weber <thakis@chromium.org>
53 Remove web intents code
54 https://bugs.webkit.org/show_bug.cgi?id=109501
56 Reviewed by Eric Seidel.
58 See thread "Removing ENABLE(WEB_INTENTS) code" on webkit-dev.
62 * public/WebDeliveredIntentClient.h: Removed.
66 * public/WebFrameClient.h:
68 * public/WebIntent.h: Removed.
69 * public/WebIntentRequest.h: Removed.
70 * public/WebIntentServiceInfo.h: Removed.
71 * public/WebRuntimeFeatures.h:
73 * src/DeliveredIntentClientImpl.cpp: Removed.
74 * src/DeliveredIntentClientImpl.h: Removed.
75 * src/FrameLoaderClientImpl.cpp:
76 * src/FrameLoaderClientImpl.h:
77 (FrameLoaderClientImpl):
78 * src/WebFrameImpl.cpp:
82 * src/WebIntent.cpp: Removed.
83 * src/WebIntentRequest.cpp: Removed.
84 * src/WebIntentServiceInfo.cpp: Removed.
85 * src/WebRuntimeFeatures.cpp:
87 2013-02-11 Florin Malita <fmalita@chromium.org>
89 Unreviewed. Rolled Chromium DEPS to r181770.
93 2013-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
95 Unreviewed. Rolled Chromium DEPS to r181742. Requested by
96 fmalita_ via sheriffbot.
100 2013-02-11 Rouslan Solomakhin <rouslan@chromium.org>
102 [Chromium] Replace correct misspelled range in WebKit::WebFrameImpl::replaceMisspelledRange
103 https://bugs.webkit.org/show_bug.cgi?id=108513
105 Reviewed by Tony Chang.
107 WebKit::WebFrameImpl::replaceMisspelledRange is going to be used by Chromium instead of
108 WebKit::WebFrameImpl::replaceSelection for correcting misspellings. The current implementation
109 of WebKit::WebFrameImpl::replaceMisspelledRange sometimes replaces the wrong range. This change
110 uses Range::create instead of TextIterator::rangeFromLocationAndLength to select the correct
111 range. This change also disables smart replace in WebKit::WebFrameImpl::replaceMisspelledRange
112 to avoid introducing spaces around misspellings.
114 * src/WebFrameImpl.cpp:
115 (WebKit::WebFrameImpl::replaceMisspelledRange): Replace correct misspelled range.
116 * tests/WebFrameTest.cpp: Add unit test for WebKit::WebFrameImpl::replaceMisspelledRange method.
118 2013-02-11 Alexei Filippov <alph@chromium.org>
120 Web Inspector: Split Profiler domain in protocol into Profiler and HeapProfiler
121 https://bugs.webkit.org/show_bug.cgi?id=108653
123 Reviewed by Yury Semikhatsky.
125 Currently CPU and heap profilers share the same domain 'Profiler' in the protocol.
126 In fact these two profile types have not too much in common. So put each into its own domain.
127 It should also help when Profiles panel gets split into several tools.
128 This is the phase 1 which adds InspectorHeapProfilerAgent but doesn't
129 change the original InspectorProfilerAgent.
131 * src/WebDevToolsAgentImpl.cpp:
132 (WebKit::WebDevToolsAgent::shouldInterruptForMessage):
134 2013-02-11 Abhishek Arya <inferno@chromium.org>
136 Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
137 https://bugs.webkit.org/show_bug.cgi?id=108981
139 Reviewed by Eric Seidel.
141 * src/AutofillPopupMenuClient.cpp:
142 (WebKit::AutofillPopupMenuClient::getSuggestion):
143 (WebKit::AutofillPopupMenuClient::getLabel):
144 (WebKit::AutofillPopupMenuClient::getIcon):
145 (WebKit::AutofillPopupMenuClient::removeSuggestionAtIndex):
146 (WebKit::AutofillPopupMenuClient::valueChanged):
147 (WebKit::AutofillPopupMenuClient::selectionChanged):
148 * src/ChromeClientImpl.cpp:
149 (WebKit::ChromeClientImpl::shouldRunModalDialogDuringPageDismissal):
151 2013-02-10 James Robinson <jamesr@chromium.org>
153 [chromium] Enable more of webkit_unit_tests in component builds
154 https://bugs.webkit.org/show_bug.cgi?id=109369
156 Reviewed by Darin Fisher.
158 Updates all webkit_unit_tests (except for LevelDBTest) to go through the Platform API instead of directly
159 calling into webkit_support so they work in component builds.
162 * tests/AssociatedURLLoaderTest.cpp:
163 * tests/EventListenerTest.cpp:
164 * tests/FrameTestHelpers.cpp:
165 (WebKit::FrameTestHelpers::createWebViewAndLoad):
167 (WebKit::FrameTestHelpers::QuitTask::run):
169 (WebKit::FrameTestHelpers::runPendingTasks):
170 * tests/FrameTestHelpers.h:
172 * tests/ListenerLeakTest.cpp:
173 * tests/PopupMenuTest.cpp:
174 * tests/PrerenderingTest.cpp:
175 * tests/ScrollingCoordinatorChromiumTest.cpp:
176 (WebKit::ScrollingCoordinatorChromiumTest::~ScrollingCoordinatorChromiumTest):
177 (WebKit::ScrollingCoordinatorChromiumTest::navigateTo):
178 * tests/URLTestHelpers.cpp:
179 (WebKit::URLTestHelpers::registerMockedURLLoad):
180 * tests/WebFrameTest.cpp:
181 * tests/WebImageTest.cpp:
183 * tests/WebPageNewSerializerTest.cpp:
184 * tests/WebPageSerializerTest.cpp:
185 * tests/WebPluginContainerTest.cpp:
186 (WebKit::WebPluginContainerTest::TearDown):
188 * tests/WebViewTest.cpp:
190 2013-02-10 Sheriff Bot <webkit.review.bot@gmail.com>
192 Unreviewed. Rolled Chromium DEPS to r181645. Requested by
193 "James Robinson" <jamesr@chromium.org> via sheriffbot.
197 2013-02-09 Stephen Chenney <schenney@chromium.org>
199 Unreviewed. Rolled Chromium DEPS to last-known good revision. Really this time.
203 2013-02-09 Sheriff Bot <webkit.review.bot@gmail.com>
205 Unreviewed. Rolled Chromium DEPS to last-known good revision.
206 Requested by "Stephen Chenney" <schenney@chromium.org> via
211 2013-02-08 Kent Tamura <tkent@chromium.org>
213 [Chromium] Disable ENABLE_INPUT_TYPE_DATETIME
214 https://bugs.webkit.org/show_bug.cgi?id=109272
216 Reviewed by Kentaro Hara.
218 We enabled this flag for desktop Chromium, but disabled the feature by a
219 runtime flag. We disables the compile flag too because we have no plan
220 to ship it in near future.
222 * features.gypi: Remove ENABLE_INPUT_TYPE_DATETIME.
224 2013-02-08 Stephen Chenney <schenney@chromium.org>
226 Remove Skia code suppressions
228 Unreviewed enabling of existing optimizations
230 Removing all skia_webkit.gyp code suppressions and adding expectations
235 2013-02-08 Dan Carney <dcarney@google.com>
237 [v8] isolate parameter added to all v8::peristent calls
238 https://bugs.webkit.org/show_bug.cgi?id=109268
240 Reviewed by Kentaro Hara.
242 * tests/WebFrameTest.cpp:
244 2013-02-07 Kent Tamura <tkent@chromium.org>
246 [Chromium-Android] Disable input[type=datetime]
247 https://bugs.webkit.org/show_bug.cgi?id=107614
249 Reviewed by Kentaro Hara.
252 http://lists.webkit.org/pipermail/webkit-dev/2013-January/023404.html
255 Disable ENABLE_INPUT_TYPE_DATETIME because of a wrong UI.
256 We enable it for non-Android ports but the runtime flag for it is
257 disabled by default. The runtime flag is enabled only in DumpRenderTree.
259 2013-02-07 Terry Anderson <tdanderson@chromium.org>
261 [chromium] Flings should not bubble up to enclosing scrollables when main-thread touch scrolling
262 https://bugs.webkit.org/show_bug.cgi?id=108719
264 Reviewed by Eric Seidel.
266 In the event of a main-thread touch fling, dispatch a series of
267 GestureScrollUpdateWithoutPropagation events defined in
268 https://bugs.webkit.org/show_bug.cgi?id=108849 (instead of
269 GestureScrollUpdate events) so that the fling does not
270 propagate to enclosing scrollables.
272 * src/WebViewImpl.cpp:
273 (WebKit::WebViewImpl::scrollBy):
275 2013-02-07 Kent Tamura <tkent@chromium.org>
277 [Chromium] Add a flag to enable native form validation message
278 https://bugs.webkit.org/show_bug.cgi?id=109134
280 Reviewed by Adam Barth.
282 * public/WebRuntimeFeatures.h:
283 (WebRuntimeFeatures): Add enableNativeValidationMessage and
284 isNativeValidationMessageEnabled.
285 * src/WebRuntimeFeatures.cpp:
286 (WebKit): Add nativeValidationMessageEnabled.
287 (WebKit::WebRuntimeFeatures::enableNativeValidationMessage): Added.
288 (WebKit::WebRuntimeFeatures::isNativeValidationMessageEnabled): Addedd.
289 * src/WebViewImpl.cpp:
290 (WebKit::WebViewImpl::WebViewImpl):
291 Fill Page::PageClients::validationMessageClient if the flag is true.
293 2013-02-07 Eberhard Graether <egraether@google.com>
295 Web Inspector: Add settings checkbox for composited layer borders
296 https://bugs.webkit.org/show_bug.cgi?id=109096
298 Reviewed by Pavel Feldman.
300 This change adds a checkbox to show composited layer borders to the WebInspector's
301 rendering settings and plumbs the setting to Chromium's WebLayerTreeView. The setting
302 is visible if InspectorClient::canShowDebugBorders() returns true.
304 * src/InspectorClientImpl.cpp:
305 (WebKit::InspectorClientImpl::canShowDebugBorders):
307 (WebKit::InspectorClientImpl::setShowDebugBorders):
308 * src/InspectorClientImpl.h:
309 (InspectorClientImpl):
310 * src/WebViewImpl.cpp:
311 (WebKit::WebViewImpl::WebViewImpl):
312 (WebKit::WebViewImpl::setShowDebugBorders):
314 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
317 2013-02-07 Stephen White <senorblanco@chromium.org>
319 Unreviewed. Rolled DEPS.
323 2013-02-07 David Trainor <dtrainor@chromium.org>
325 Add null check to editable in moveCaretSelectionTowardsWindowPoint
326 https://bugs.webkit.org/show_bug.cgi?id=108962
328 Reviewed by Eric Seidel.
330 * src/WebFrameImpl.cpp:
331 (WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):
332 * tests/WebFrameTest.cpp:
334 2013-02-07 Sheriff Bot <webkit.review.bot@gmail.com>
336 Unreviewed. Rolled Chromium DEPS to r180752. Requested by
337 thakis_ via sheriffbot.
341 2013-02-06 Terry Anderson <tdanderson@chromium.org>
343 Add support for gesture scroll events that do not propagate to enclosing scrollables
344 https://bugs.webkit.org/show_bug.cgi?id=108849
346 Reviewed by Antonio Gomes.
348 Define the new event type GestureScrollUpdateWithoutPropagation.
350 * public/WebInputEvent.h:
351 (WebKit::WebInputEvent::isGestureEventType):
352 * src/PageWidgetDelegate.cpp:
353 (WebKit::PageWidgetDelegate::handleInputEvent):
354 * src/WebInputEventConversion.cpp:
355 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
356 * src/WebPluginContainerImpl.cpp:
357 * src/WebPopupMenuImpl.cpp:
358 (WebKit::WebPopupMenuImpl::handleInputEvent):
359 * src/WebViewImpl.cpp:
360 (WebKit::WebViewImpl::handleGestureEvent):
362 2013-02-06 Alexandre Elias <aelias@chromium.org>
364 Make ScrollView::paint() clip by visibleContentRect
365 https://bugs.webkit.org/show_bug.cgi?id=108888
367 Reviewed by Levi Weintraub.
369 When applyPageScaleFactorInCompositor or fixedVisibleContentRect
370 are used, frameRect() and visibleContentRect(true).size() are
371 no longer synonyms, and the latter is the one that should be
372 used for clipping paints.
374 New WebFrameTest: pageScaleFactorScalesPaintClip.
376 * tests/WebFrameTest.cpp:
378 2013-02-06 Sheriff Bot <webkit.review.bot@gmail.com>
380 Unreviewed, rolling out r142025.
381 http://trac.webkit.org/changeset/142025
382 https://bugs.webkit.org/show_bug.cgi?id=109091
384 broke the build (Requested by tdanderson on #webkit).
386 * public/WebInputEvent.h:
387 (WebKit::WebInputEvent::isGestureEventType):
388 * src/PageWidgetDelegate.cpp:
389 (WebKit::PageWidgetDelegate::handleInputEvent):
390 * src/WebInputEventConversion.cpp:
391 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
392 * src/WebPluginContainerImpl.cpp:
393 * src/WebPopupMenuImpl.cpp:
394 (WebKit::WebPopupMenuImpl::handleInputEvent):
395 * src/WebViewImpl.cpp:
396 (WebKit::WebViewImpl::handleGestureEvent):
398 2013-02-06 Daniel Cheng <dcheng@google.com>
400 [chromium] Remove "config.h" header from WebUnitTests.cpp
401 https://bugs.webkit.org/show_bug.cgi?id=108966
403 Reviewed by Tony Chang.
405 This file includes headers from base/ in Chromium, and config.h
406 conflicts with base/logging.h. Rather than teaching certain files in
407 base/ not to #include base/logging.h, remove the config.h include
408 here. The ASSERT isn't really necessary, as attempting to run a null
409 test suite won't go very far anyway.
411 * tests/WebUnitTests.cpp:
412 (WebKit::RunAllUnitTests):
414 2013-02-06 Terry Anderson <tdanderson@chromium.org>
416 Add support for gesture scroll events that do not propagate to enclosing scrollables
417 https://bugs.webkit.org/show_bug.cgi?id=108849
419 Reviewed by Antonio Gomes.
421 Define the new event type GestureScrollUpdateWithoutPropagation.
423 * public/WebInputEvent.h:
424 (WebKit::WebInputEvent::isGestureEventType):
425 * src/PageWidgetDelegate.cpp:
426 (WebKit::PageWidgetDelegate::handleInputEvent):
427 * src/WebInputEventConversion.cpp:
428 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
429 * src/WebPluginContainerImpl.cpp:
430 * src/WebPopupMenuImpl.cpp:
431 (WebKit::WebPopupMenuImpl::handleInputEvent):
432 * src/WebViewImpl.cpp:
433 (WebKit::WebViewImpl::handleGestureEvent):
435 2013-02-06 Chris Hopman <cjhopman@chromium.org>
437 [Chromium] WebWidget should expose a way to determine the start/end of the selection bounds
438 https://bugs.webkit.org/show_bug.cgi?id=108667
440 Reviewed by Darin Fisher.
442 WebWidget::selectionBounds() returns the anchor and focus of the
443 selection. This matches the arguments to WebFrame::selectRange().
444 Add WebWidget::isSelectionAnchorFirst so that a caller can convert the
445 anchor/focus to start/end.
447 * public/WebWidget.h:
449 (WebKit::WebWidget::isSelectionAnchorFirst):
450 * src/WebViewImpl.cpp:
451 (WebKit::WebViewImpl::isSelectionAnchorFirst):
454 * tests/WebViewTest.cpp:
456 2013-02-06 Alec Flett <alecflett@chromium.org>
458 IndexedDB: Stub out SharedBuffer version of put()
459 https://bugs.webkit.org/show_bug.cgi?id=108986
461 Reviewed by Darin Fisher.
463 This is part 1 of 3 to replace Vector<uint8_t> with SharedBuffer.
465 * public/WebIDBDatabase.h:
467 (WebKit::WebIDBDatabase::put):
469 2013-02-06 Stephen Chenney <schenney@chromium.org>
471 Add Skia code suppression flags to WebKit skia.gyp
475 This is step one in removing these flags. First we get them into
476 WebKit, then we can remove them from Chrome.
480 2013-02-06 Mike West <mkwst@chromium.org>
482 Add an ENABLE_NOSNIFF feature flag.
483 https://bugs.webkit.org/show_bug.cgi?id=109029
485 Reviewed by Jochen Eisinger.
487 This new flag will control the behavior of 'X-Content-Type-Options: nosniff'
488 when processing script and other resource types.
492 2013-02-05 David Dorwin <ddorwin@chromium.org>
494 [chromium] Explicitly destroy the WebMediaPlayer in WebMediaPlayerClientImpl's destructor
495 https://bugs.webkit.org/show_bug.cgi?id=108989
497 Reviewed by Kent Tamura.
499 * src/WebMediaPlayerClientImpl.cpp:
500 (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
502 2013-02-04 Kentaro Hara <haraken@chromium.org>
504 [V8] Reduce usage of deprecatedString() and deprecatedInteger()
505 https://bugs.webkit.org/show_bug.cgi?id=108909
507 Reviewed by Adam Barth.
509 No tests. No change in behavior.
511 * src/WebBindings.cpp:
512 (WebKit::WebBindings::toV8Value):
514 2013-02-05 Kentaro Hara <haraken@chromium.org>
516 [V8] Make an Isolate parameter mandatory in HasInstance()
517 https://bugs.webkit.org/show_bug.cgi?id=108917
519 Reviewed by Adam Barth.
521 Because these methods do not have an Isolate, we have to call
522 v8::Isolate::GetCurrent().
524 No tests. No change in behavior.
526 * src/WebArrayBuffer.cpp:
527 (WebKit::WebArrayBuffer::createFromV8Value):
528 * src/WebArrayBufferView.cpp:
529 (WebKit::WebArrayBufferView::createFromV8Value):
530 * src/WebBindings.cpp:
531 (WebKit::getRangeImpl):
532 (WebKit::getNodeImpl):
533 (WebKit::getElementImpl):
534 (WebKit::getArrayBufferImpl):
535 (WebKit::getArrayBufferViewImpl):
536 (WebKit::WebBindings::getRange):
537 (WebKit::WebBindings::getArrayBuffer):
538 (WebKit::WebBindings::getArrayBufferView):
539 (WebKit::WebBindings::getNode):
540 (WebKit::WebBindings::getElement):
542 2013-02-05 Dana Jansens <danakj@chromium.org>
544 [chromium] Provide compositor offscreen context through the WebLayerTreeViewClient interface
545 https://bugs.webkit.org/show_bug.cgi?id=107776
547 Reviewed by James Robinson.
550 * src/WebGraphicsContext3D.cpp: Removed.
552 2013-02-05 Mark Lam <mark.lam@apple.com>
554 Introduced back-end database classes + a few small fixes.
555 https://bugs.webkit.org/show_bug.cgi?id=108759.
557 Reviewed by Brady Eidson.
559 * src/DatabaseObserver.cpp:
560 (WebCore::DatabaseObserver::databaseOpened):
561 (WebCore::DatabaseObserver::databaseModified):
562 (WebCore::DatabaseObserver::databaseClosed):
564 2013-02-05 Adam Barth <abarth@webkit.org>
566 DumpRenderTree should be able to enable the threaded parser
567 https://bugs.webkit.org/show_bug.cgi?id=108970
569 Reviewed by Eric Seidel.
571 * public/WebSettings.h:
572 * src/WebSettingsImpl.cpp:
573 (WebKit::WebSettingsImpl::setThreadedHTMLParser):
575 * src/WebSettingsImpl.h:
578 2013-02-05 Sami Kyostila <skyostil@chromium.org>
580 [chromium] Make overlay layers slow-scrolling
581 https://bugs.webkit.org/show_bug.cgi?id=108957
583 Reviewed by James Robinson.
585 Since overlay layers get inserted on top of everything else, we must
586 mark them slow-scrolling to prevent all scroll input events to the rest
587 of the page from getting blocked. This is also more correct because
588 generally the overlay contents need to be repainted whenever the scroll
589 offset changes, and with this patch the painting happens in sync with
592 2013-02-05 Sheriff Bot <webkit.review.bot@gmail.com>
594 Unreviewed, rolling out r141896.
595 http://trac.webkit.org/changeset/141896
596 https://bugs.webkit.org/show_bug.cgi?id=108956
598 crashes indexdb security tests (Requested by gavinp on
601 * public/platform/WebKitPlatformSupport.h:
603 (WebKitPlatformSupport):
604 (WebKit::WebKitPlatformSupport::idbFactory):
605 * src/IDBFactoryBackendProxy.cpp:
606 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
608 2013-02-05 Mark Pilgrim <pilgrim@chromium.org>
610 [Chromium] Remove idbFactory from WebKitPlatformSupport
611 https://bugs.webkit.org/show_bug.cgi?id=106457
613 Reviewed by Adam Barth.
615 Now that https://codereview.chromium.org/12181010/ has landed, the
616 idbFactory method is no longer needed. (Embedders must now call
617 the new setIDBFactory method upon initialization.) Part of a
618 larger refactoring series; see tracking bug 82948.
620 * public/platform/WebKitPlatformSupport.h:
622 * src/IDBFactoryBackendProxy.cpp:
623 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
625 2013-02-05 Kentaro Hara <haraken@chromium.org>
627 Unreviewed, rolling out r141865.
628 http://trac.webkit.org/changeset/141865
629 https://bugs.webkit.org/show_bug.cgi?id=108909
631 webkit unit tests are broken
633 * src/WebBindings.cpp:
634 (WebKit::WebBindings::toV8Value):
636 2013-02-05 Kentaro Hara <haraken@chromium.org>
638 [V8] Reduce usage of deprecatedString() and deprecatedInteger()
639 https://bugs.webkit.org/show_bug.cgi?id=108909
641 Reviewed by Adam Barth.
643 No tests. No change in behavior.
645 * src/WebBindings.cpp:
646 (WebKit::WebBindings::toV8Value):
648 2013-02-04 Sheriff Bot <webkit.review.bot@gmail.com>
650 Unreviewed. Rolled Chromium DEPS to r180583. Requested by
651 "Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.
655 2013-02-04 James Simonsen <simonjam@chromium.org>
657 [Chromium] Add a signal for when the body is inserted in the document
658 https://bugs.webkit.org/show_bug.cgi?id=108725
660 Reviewed by Adam Barth.
662 * public/WebFrameClient.h:
664 (WebKit::WebFrameClient::willInsertBody):
665 * src/FrameLoaderClientImpl.cpp:
666 (WebKit::FrameLoaderClientImpl::dispatchWillInsertBody):
668 * src/FrameLoaderClientImpl.h:
669 (FrameLoaderClientImpl):
670 * tests/WebFrameTest.cpp:
672 2013-02-04 Chris Hopman <cjhopman@chromium.org>
674 Make moveCaretTowardsWindowPoint not snap to the beginning/end when moved above/below editable
675 https://bugs.webkit.org/show_bug.cgi?id=107850
677 Reviewed by Ojan Vafai.
679 On Android, EditingBehavior::shouldMoveCaret[...] controls the
680 behavior of insertion handles. This change adds a new Android specific
681 editing behavior type so that we can change these settings independent
682 of behavior for other platforms.
684 * public/WebSettings.h:
685 * src/AssertMatchingEnums.cpp:
686 Just add the corresponding assertion for the new editing behavior.
688 * public/WebSettings.h:
689 * src/AssertMatchingEnums.cpp:
691 * tests/WebFrameTest.cpp:
692 * tests/data/move_caret.html: Added.
693 Add a test that moveCaretTowardsWindowPoint works as expected on
696 2013-01-31 Kentaro Hara <haraken@chromium.org>
698 Implement WheelEvent::deltaMode
699 https://bugs.webkit.org/show_bug.cgi?id=108455
701 Reviewed by Adam Barth.
703 * src/WebInputEventConversion.cpp:
704 (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
706 2013-02-04 Mark Pilgrim <pilgrim@chromium.org>
708 [Chromium] Move WorkerContextProxy to WebCore
709 https://bugs.webkit.org/show_bug.cgi?id=108847
711 Reviewed by Adam Barth.
713 Part of a larger refactoring series; see tracking bug 106829.
717 (WebKit::initializeWithoutV8):
718 * src/WorkerContextProxy.cpp: Removed.
720 2013-02-04 Abhishek Arya <inferno@chromium.org>
722 Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
723 https://bugs.webkit.org/show_bug.cgi?id=108668
725 Reviewed by Eric Seidel.
727 * src/ContextFeaturesClientImpl.cpp:
728 (WebKit::ContextFeaturesCache::entryFor):
729 * src/WebFrameImpl.cpp:
730 (WebKit::WebFrameImpl::selectFindMatch):
732 2013-02-04 Mark Pilgrim <pilgrim@chromium.org>
734 [Chromium] Move IDBFactoryBackendInterface to WebCore
735 https://bugs.webkit.org/show_bug.cgi?id=108638
737 Reviewed by Adam Barth.
739 Part of a larger refactoring series; see tracking bug 106829.
742 * src/AssertMatchingEnums.cpp:
743 * src/IDBFactoryBackendInterface.cpp: Removed.
744 * src/IDBFactoryBackendProxy.h:
746 (WebKit::initializeWithoutV8):
748 2013-02-04 Abhishek Arya <inferno@chromium.org>
750 Add ASSERT_WITH_SECURITY_IMPLICATION to detect bad cast in DOM, CSS, etc.
751 https://bugs.webkit.org/show_bug.cgi?id=108688
753 Reviewed by Eric Seidel.
755 * src/IDBFactoryBackendProxy.cpp:
756 (WebKit::IDBFactoryBackendProxy::allowIndexedDB):
757 (WebKit::getWebFrame):
758 * src/LocalFileSystemChromium.cpp:
759 (WebCore::LocalFileSystem::deleteFileSystem):
760 * src/WebSharedWorkerImpl.cpp:
761 (WebKit::WebSharedWorkerImpl::connectTask):
762 (WebKit::resumeWorkerContextTask):
763 (WebKit::connectToWorkerContextInspectorTask):
764 (WebKit::reconnectToWorkerContextInspectorTask):
765 (WebKit::disconnectFromWorkerContextInspectorTask):
766 (WebKit::dispatchOnInspectorBackendTask):
768 2013-02-04 Sami Kyostila <skyostil@chromium.org>
770 Disable -webkit-overflow-scrolling CSS attribute on Chromium
771 https://bugs.webkit.org/show_bug.cgi?id=108020
773 Reviewed by James Robinson.
775 Now that we can automatically promote overflow elements to accelerated
776 scrolling layers there is no use for the -webkit-overflow-scrolling CSS
777 attribute any longer on Chromium.
779 This patch enables composited overflow scrolling in
780 ScrollingCoordinatorChromiumTest. Because this also causes the overflow div
781 in non-fast-scrollable.html to become composited, we also need to modify that
782 test to opt it out of composited scrolling.
785 * tests/ScrollingCoordinatorChromiumTest.cpp:
786 (WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
788 * tests/data/non-fast-scrollable.html:
789 * tests/data/overflow-scrolling.html: Renamed from Source/WebKit/chromium/tests/data/touch-overflow-scrolling.html.
791 2013-02-03 KwangYong Choi <ky0.choi@samsung.com>
793 Fix build warning after r141473
794 https://bugs.webkit.org/show_bug.cgi?id=108782
796 Reviewed by Kentaro Hara.
798 Fix -Wunused-parameter build warning.
800 * src/EditorClientImpl.cpp:
801 (WebKit::EditorClientImpl::getClientPasteboardDataForRange):
803 2013-02-03 David Dorwin <ddorwin@chromium.org>
805 [chromium] Do not call m_widgetClient->show() for WebHelperPlugin.
806 https://bugs.webkit.org/show_bug.cgi?id=108740
808 Reviewed by Kent Tamura.
810 The calls to m_widgetClient->show() and setFocus() do not appear to be
811 necessary, and the former causes problems on at least on platform.
813 * src/WebHelperPluginImpl.cpp:
814 (WebKit::WebHelperPluginImpl::initialize): Removed calls to m_widgetClient->show() and setFocus().
815 (WebKit::WebHelperPluginImpl::setFocus): Should never be called.
817 2013-02-02 Michael Nordman <michaeln@google.com>
819 [chromium] FileSystem mods: Changes to snapshot file creation to reduce dependencies on blobs.
820 This patch just alters the WebKitAPI in advance of coding to the new API in chromium and webkit
821 sources, defining two new virtual methods (unimplemented and uncalled). The existing API remains
823 https://bugs.webkit.org/show_bug.cgi?id=108736
825 Reviewed by Darin Fisher.
827 * public/WebFileSystemCallbacks.h:
828 (WebFileSystemCallbacks):
829 (WebKit::WebFileSystemCallbacks::didCreateSnapshotFile):
831 2013-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
833 Unreviewed. Rolled Chromium DEPS to r180221. Requested by
834 "Nico Weber" <thakis@chromium.org> via sheriffbot.
838 2013-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
840 Unreviewed. Rolled Chromium DEPS to r180186. Requested by
841 "Nico Weber" <thakis@chromium.org> via sheriffbot.
845 2013-02-01 Chris Hopman <cjhopman@chromium.org>
847 [Chromium] WebWidget::selectionBounds should return the bounds in document space
848 https://bugs.webkit.org/show_bug.cgi?id=108386
850 Reviewed by James Robinson.
852 When in applyPageScaleFactorInCompositor mode, selectionBounds needs
853 to scale the anchor/focus window points by the pageScaleFactor.
855 * src/WebViewImpl.cpp:
856 (WebKit::WebViewImpl::selectionBounds):
857 (WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode):
859 2013-02-01 Dominic Mazzoni <dmazzoni@google.com>
861 AX: memoize expensive computation during blocks where tree doesn't change
862 https://bugs.webkit.org/show_bug.cgi?id=106497
864 Reviewed by Ryosuke Niwa.
866 Expose two methods to enable and disable caching of
867 computed WebAccessibilityObject attributes, to speed up
868 batch read-only operations.
870 * public/WebAccessibilityObject.h:
871 (WebAccessibilityObject):
872 * src/WebAccessibilityObject.cpp:
873 (WebKit::WebAccessibilityObject::startCachingComputedObjectAttributesUntilTreeMutates):
875 (WebKit::WebAccessibilityObject::stopCachingComputedObjectAttributes):
877 2013-02-01 Fady Samuel <fsamuel@chromium.org>
879 [Chromium] Expose WebNode::shadowHost()
880 https://bugs.webkit.org/show_bug.cgi?id=108681
882 Reviewed by Dimitri Glazkov.
884 BrowserPlugin needs to be able to check the event listeners attached to
885 <webview> and so we expose shadowHost to permit it to poke at the webview
890 (WebKit::WebNode::shadowHost):
893 2013-02-01 Rouslan Solomakhin <rouslan@chromium.org>
895 [Chromium] Ignore punctuation in spellcheck
896 https://bugs.webkit.org/show_bug.cgi?id=108511
898 Reviewed by Tony Chang.
900 * src/ContextMenuClientImpl.cpp:
901 (WebKit::IsWhiteSpaceOrPunctuation): Added utility function to detect whitespace or punctuation.
902 (WebKit::selectMisspellingAsync): Ignore punctuation when selecting the misspelling.
904 2013-02-01 Philip Rogers <pdr@google.com>
906 Change hasAlpha to isKnownToBeOpaque and correct the return value for SVG images.
907 https://bugs.webkit.org/show_bug.cgi?id=106966
909 Reviewed by Stephen White.
911 * tests/DragImageTest.cpp:
912 (WebCore::TestImage::currentFrameKnownToBeOpaque):
914 * tests/ImageLayerChromiumTest.cpp:
915 (WebCore::TestImage::currentFrameKnownToBeOpaque):
916 * tests/PlatformContextSkiaTest.cpp:
919 2013-02-01 Nico Weber <thakis@chromium.org>
921 [chromium] Build webkit with enable_web_intents set to 0.
922 https://bugs.webkit.org/show_bug.cgi?id=108408
924 Reviewed by Tony Chang.
926 I'll then make chromium build fine with that, then switch
927 enable_web_intents to 0, roll that into webkit, and then
928 actually remove the code hidden behind this flag.
930 The features.gypi bit depends on https://codereview.chromium.org/12143002/
931 and will disable web intents support on android. Since common.gypi
932 sets enable_web_intents to 0 explicitly, it seems this is currently on
935 While it looks like this CL just removes ENABLE_WEB_INTENTS=1 from
936 features.gypi completely, it's still set further down the file if
937 enable_web_intents is on.
941 * src/WebFrameImpl.cpp:
943 2013-02-01 Rouslan Solomakhin <rouslan@chromium.org>
945 [Chromium] Ignore whitespace in spellcheck
946 https://bugs.webkit.org/show_bug.cgi?id=108510
948 Reviewed by Ryosuke Niwa.
950 * src/ContextMenuClientImpl.cpp:
951 (WebKit::selectMisspellingAsync): Ignore whitespace when selecting the misspelling.
953 2013-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
955 Unreviewed. Rolled Chromium DEPS to r180131. Requested by
956 "Florin Malita" <fmalita@chromium.org> via sheriffbot.
960 2013-02-01 Alexis Menard <alexis@webkit.org>
962 Enable unprefixed CSS transitions by default.
963 https://bugs.webkit.org/show_bug.cgi?id=108216
965 Reviewed by Dean Jackson.
967 Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
968 to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
969 guard the unprefixing work for CSS Transforms and animations.
973 2013-02-01 Ken Kania <kkania@chromium.org>
975 Web Inspector: Add support for handling modal dialogs
976 https://bugs.webkit.org/show_bug.cgi?id=107883
978 Reviewed by Pavel Feldman.
980 Introduce support for being notified when a JavaScript modal dialog
981 is opening and closing, as well as a new command for accepting or
982 dismissing the dialog.
984 * public/WebDevToolsAgent.h:
985 * src/InspectorClientImpl.cpp:
986 (WebKit::InspectorClientImpl::handleJavaScriptDialog):
988 * src/InspectorClientImpl.h:
989 (InspectorClientImpl):
990 * src/WebDevToolsAgentImpl.cpp:
991 (BrowserDataHintStringValues):
992 (WebKit::WebDevToolsAgentImpl::captureScreenshot):
993 (WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
995 (WebKit::browserHintToString):
996 (WebKit::browserHintFromString):
997 (WebKit::WebDevToolsAgent::patchWithBrowserData):
998 * src/WebDevToolsAgentImpl.h:
999 (WebDevToolsAgentImpl):
1001 2013-02-01 Dan Alcantara <dfalcantara@chromium.org>
1003 Touch disambiguation blacklist is not being queried properly
1004 https://bugs.webkit.org/show_bug.cgi?id=108222
1006 Reviewed by Adam Barth.
1008 TEST=WebFrameTest::DisambiguationPopupBlacklist
1010 Fix the blacklist so that we check it for the right nodes.
1011 Add a test to check that the blacklist is being built and used
1012 correctly. Also update the other DisambiguationPopup tests to
1013 use the new page scale method.
1015 * tests/WebFrameTest.cpp:
1016 * tests/data/disambiguation_popup_blacklist.html: Added.
1018 2013-02-01 Eberhard Graether <egraether@google.com>
1020 [chromium] only show checkboxes for FPS meter and continuous painting when compositing mode is forced
1021 https://bugs.webkit.org/show_bug.cgi?id=108236
1023 Reviewed by Pavel Feldman.
1025 This change hides the checkboxes for FPS meter and continuous painting if compositing mode is not forced.
1026 This way the checkboxes only show up for users that can make use of these features.
1028 * src/InspectorClientImpl.cpp:
1029 (WebKit::InspectorClientImpl::canShowFPSCounter):
1030 (WebKit::InspectorClientImpl::canContinuouslyPaint):
1032 2013-01-31 Aurimas Liutikas <aurimas@chromium.org>
1034 Editor::m_compositionNode not updated on HTMLInputElement::setValue()
1035 https://bugs.webkit.org/show_bug.cgi?id=107737
1037 Reviewed by Ryosuke Niwa.
1039 * public/WebViewClient.h:
1040 (WebKit::WebViewClient::didCancelCompositionOnSelectionChange):
1041 Adding a callback to let the WebViewClient know that the composition has been cancelled.
1042 * src/EditorClientImpl.cpp:
1043 (WebKit::EditorClientImpl::respondToChangedSelection):
1044 Adding a call composition if it is no longer valid.
1046 2013-01-31 Aurimas Liutikas <aurimas@chromium.org>
1048 [Chromium] WebViewTest.SetCompositionFromExistingText failing after r141479
1049 https://bugs.webkit.org/show_bug.cgi?id=108543
1051 Reviewed by Ryosuke Niwa.
1053 Fixing a bug that was uncovered after fixing http://trac.webkit.org/changeset/141479
1055 * src/WebViewImpl.cpp:
1056 (WebKit::WebViewImpl::setCompositionFromExistingText):
1057 * tests/WebViewTest.cpp:
1058 Re-enabling the test
1060 2013-01-31 Hajime Morrita <morrita@google.com>
1062 Unreviewed, followup fix for r141535.
1064 * tests/WebFrameTest.cpp:
1066 2013-01-31 Sheriff Bot <webkit.review.bot@gmail.com>
1068 Unreviewed. Rolled Chromium DEPS to r180023. Requested by
1069 thakis_ via sheriffbot.
1073 2013-01-31 Hajime Morrita <morrita@google.com>
1075 Unreviewed, disabling failing test.
1077 * tests/WebFrameTest.cpp:
1079 2013-01-31 Sheriff Bot <webkit.review.bot@gmail.com>
1081 Unreviewed, rolling out r141479.
1082 http://trac.webkit.org/changeset/141479
1083 https://bugs.webkit.org/show_bug.cgi?id=108564
1085 breaks chromium test (Requested by morrita on #webkit).
1087 * public/WebViewClient.h:
1088 * src/EditorClientImpl.cpp:
1089 (WebKit::EditorClientImpl::respondToChangedSelection):
1091 2013-01-31 Alec Flett <alecflett@chromium.org>
1093 IndexedDB: remove old transaction backend bootstrap code
1094 https://bugs.webkit.org/show_bug.cgi?id=103923
1096 Reviewed by Dimitri Glazkov.
1098 Remove all deprecated WebKit APIs from
1102 * public/WebIDBCallbacks.h:
1104 * public/WebIDBDatabase.h:
1106 * public/WebIDBTransaction.h: Removed.
1107 * public/WebIDBTransactionCallbacks.h: Removed.
1108 * src/AssertMatchingEnums.cpp:
1109 * src/IDBCallbacksProxy.cpp:
1110 * src/IDBDatabaseBackendProxy.cpp:
1111 * src/IDBDatabaseBackendProxy.h:
1112 (IDBDatabaseBackendProxy):
1113 * src/IDBTransactionBackendProxy.cpp: Removed.
1114 * src/IDBTransactionBackendProxy.h: Removed.
1115 * src/IDBTransactionCallbacksProxy.cpp: Removed.
1116 * src/IDBTransactionCallbacksProxy.h: Removed.
1117 * src/WebIDBCallbacksImpl.cpp:
1118 * src/WebIDBDatabaseImpl.cpp:
1120 * src/WebIDBDatabaseImpl.h:
1122 (WebIDBDatabaseImpl):
1123 * src/WebIDBTransactionCallbacksImpl.cpp: Removed.
1124 * src/WebIDBTransactionCallbacksImpl.h: Removed.
1125 * src/WebIDBTransactionImpl.cpp: Removed.
1126 * src/WebIDBTransactionImpl.h: Removed.
1127 * tests/IDBAbortOnCorruptTest.cpp:
1128 * tests/IDBDatabaseBackendTest.cpp:
1130 2013-01-31 Rouslan Solomakhin <rouslan@chromium.org>
1132 [Chromium] Select multi-word misspelling on context click
1133 https://bugs.webkit.org/show_bug.cgi?id=108509
1135 Reviewed by Tony Chang.
1137 * src/ContextMenuClientImpl.cpp:
1139 (WebKit::selectMisspellingAsync): Added utility function to get the misspelling for asynchronous spellcheck.
1140 (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Select multi-word misspelling on context click.
1142 2013-01-31 Florin Malita <fmalita@chromium.org>
1144 [Chromium] Unreviewed gardening.
1146 WebViewTest.SetCompositionFromExistingText failing after r141479.
1148 * tests/WebViewTest.cpp:
1150 2013-01-31 Alexandre Elias <aelias@chromium.org>
1152 [chromium] Rework page scale factor limits initialization
1153 https://bugs.webkit.org/show_bug.cgi?id=108446
1155 Reviewed by James Robinson.
1157 When loading a page with viewportEnabled, both the limits
1158 specified by the viewport tag and the content width need to be
1159 considered before we initialize the minimum page scale (and
1160 pageScaleFactor itself usually to the same value). The timing has
1161 proven tricky to get correct.
1163 This patch simplifies the flow by computing the
1164 limits only at the end of layouts and at no other time. In combination
1165 with https://bugs.webkit.org/show_bug.cgi?id=107922 which sets
1166 needsLayout() appropriately, this results in a more robust and easy
1167 to understand sequence.
1169 Fixes FixedLayoutInitializeAtMinimumPageScale test.
1171 * src/ChromeClientImpl.cpp:
1172 (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
1173 * src/WebViewImpl.cpp:
1174 (WebKit::WebViewImpl::WebViewImpl):
1175 (WebKit::WebViewImpl::resize):
1176 (WebKit::WebViewImpl::setPageScaleFactorLimits):
1177 (WebKit::WebViewImpl::computePageScaleFactorLimits):
1178 (WebKit::WebViewImpl::layoutUpdated):
1179 (WebKit::WebViewImpl::didChangeContentsSize):
1180 * src/WebViewImpl.h:
1181 (WebKit::WebViewImpl::setInitialPageScaleFactor):
1183 * tests/WebFrameTest.cpp:
1185 2013-01-31 Aurimas Liutikas <aurimas@chromium.org>
1187 Editor::m_compositionNode not updated on HTMLInputElement::setValue()
1188 https://bugs.webkit.org/show_bug.cgi?id=107737
1190 Reviewed by Ryosuke Niwa.
1192 * public/WebViewClient.h:
1193 (WebKit::WebViewClient::didCancelCompositionOnSelectionChange):
1194 Adding a callback to let the WebViewClient know that the composition has been cancelled.
1195 * src/EditorClientImpl.cpp:
1196 (WebKit::EditorClientImpl::respondToChangedSelection):
1197 Adding a call composition if it is no longer valid.
1199 2013-01-31 Mark Pilgrim <pilgrim@chromium.org>
1201 [Chromium] Move LocalizedStrings to WebCore
1202 https://bugs.webkit.org/show_bug.cgi?id=108488
1204 Reviewed by Adam Barth.
1206 Part of a larger refactoring series; see tracking bug 106829.
1209 * src/LocalizedStrings.cpp: Removed.
1211 2013-01-31 Enrica Casucci <enrica@apple.com>
1213 WebKit2: provide new bundle APIs to allow bundle clients to be notified of pasteboard access.
1214 https://bugs.webkit.org/show_bug.cgi?id=108396.
1215 <rdar://problem/12920461>
1217 Reviewed by Alexey Proskuryakov.
1219 Adds stub implementation for WebKit of the new EditorClient methods.
1221 * src/EditorClientImpl.cpp:
1222 (WebKit::EditorClientImpl::willWriteSelectionToPasteboard):
1223 (WebKit::EditorClientImpl::getClientPasteboardDataForRange):
1224 * src/EditorClientImpl.h:
1226 2013-01-31 Chris Hopman <cjhopman@chromium.org>
1228 [chromium] Make selection handling work in applyPageScaleInCompositor mode
1229 https://bugs.webkit.org/show_bug.cgi?id=107831
1231 Reviewed by Ryosuke Niwa.
1233 These functions expect a window point. When in
1234 applyPageScaleFactorInCompositor mode, the points need to be unscaled
1235 by the page scale factor.
1237 * src/WebFrameImpl.cpp:
1238 (WebKit::WebFrameImpl::selectRange):
1239 (WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):
1241 2013-01-31 Tom Sepez <tsepez@chromium.org>
1243 [v8] Enable binding integrity on mac
1244 https://bugs.webkit.org/show_bug.cgi?id=108500
1246 Reviewed by Adam Barth.
1248 Patch is correct if existing tests pass without new crashes.
1251 Set ENABLE_BINDING_INTEGRITY=1 when OS=="mac"
1253 2013-01-31 Dan Alcantara <dfalcantara@chromium.org>
1255 WebFrameTest.DisambiguationPopup is failing
1256 https://bugs.webkit.org/show_bug.cgi?id=108160
1258 Reviewed by Adam Barth.
1260 Fix the unit test so that it is using the right HTML file.
1262 * tests/WebFrameTest.cpp:
1264 2013-01-31 Tony Chang <tony@chromium.org>
1266 [Chromium] webkit_unit_tests should depend on base/allocator for ASAN
1267 https://bugs.webkit.org/show_bug.cgi?id=108497
1269 Reviewed by James Robinson.
1271 * WebKitUnitTests.gyp:
1273 2013-01-31 Alexandre Elias <aelias@chromium.org>
1275 Call FrameView::contentsResized() when setting fixed layout size
1276 https://bugs.webkit.org/show_bug.cgi?id=107922
1278 Reviewed by James Robinson.
1280 In fixed layout mode, we should be calling contentsResized() when the
1281 fixed layout size is changed, but not laying out when the visible
1282 content rect changes.
1284 Previously landed as r140869 but was reverted due to a bug in bundled
1285 Chromium-specific code. This patch includes just the minimum needed in
1288 New WebFrameTest: FrameViewNeedsLayoutOnFixedLayoutResize. Some
1289 flaky and obsolete tests for the old page scale mode are also deleted.
1291 * tests/WebFrameTest.cpp:
1293 2013-01-31 Tommy Widenflycht <tommyw@google.com>
1295 [chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStreamComponent to WebMediaStream and WebMediaStreamTrack
1296 https://bugs.webkit.org/show_bug.cgi?id=108458
1298 Reviewed by Adam Barth.
1300 Only renames, no other code changes.
1302 * public/WebMediaStreamRegistry.h:
1304 (WebMediaStreamRegistry):
1305 * public/WebUserMediaRequest.h:
1307 (WebUserMediaRequest):
1308 * src/WebMediaStreamRegistry.cpp:
1309 (WebKit::WebMediaStreamRegistry::lookupMediaStreamDescriptor):
1310 * src/WebUserMediaRequest.cpp:
1311 (WebKit::WebUserMediaRequest::requestSucceeded):
1313 2013-01-31 Alec Flett <alecflett@chromium.org>
1315 IndexedDB: Remove WebKit API for old onSuccess/onUpgradeNeeded
1316 https://bugs.webkit.org/show_bug.cgi?id=108399
1318 Reviewed by Dimitri Glazkov.
1320 Cleanup now that chromium proxies the new signatures through.
1322 * src/IDBCallbacksProxy.cpp:
1323 (WebKit::IDBCallbacksProxy::onSuccess):
1324 (WebKit::IDBCallbacksProxy::onUpgradeNeeded):
1325 * src/IDBCallbacksProxy.h:
1326 (IDBCallbacksProxy):
1327 * src/WebIDBCallbacksImpl.cpp:
1328 * src/WebIDBCallbacksImpl.h:
1329 (WebIDBCallbacksImpl):
1331 2013-01-31 James Robinson <jamesr@chromium.org>
1333 [chromium] Remove dead transitional code from WebViewImpl
1334 https://bugs.webkit.org/show_bug.cgi?id=107889
1336 Reviewed by Adam Barth.
1338 The chromium side of this landed at r178256 and seems stable.
1340 * public/WebWidget.h:
1341 (WebKit::WebWidget::setCompositorSurfaceReady):
1342 * src/WebViewImpl.cpp:
1343 (WebKit::WebViewImpl::WebViewImpl):
1344 (WebKit::WebViewImpl::~WebViewImpl):
1346 (WebKit::WebViewImpl::setIsTransparent):
1347 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
1348 * src/WebViewImpl.h:
1349 * tests/ScrollingCoordinatorChromiumTest.cpp:
1350 (WebKit::FakeWebViewClient::initializeLayerTreeView):
1351 (FakeWebViewClient):
1352 (WebKit::FakeWebViewClient::layerTreeView):
1353 (WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
1354 (ScrollingCoordinatorChromiumTest):
1356 2013-01-31 Kentaro Hara <haraken@chromium.org>
1358 Rename WheelEvent::Granularity to WheelEvent::DeltaMode
1359 https://bugs.webkit.org/show_bug.cgi?id=108434
1361 Reviewed by Ryosuke Niwa.
1363 Per the spec, WheelEvent::Granularity should be renamed to WheelEvent::DeltaMode.
1365 Spec: http://www.w3.org/TR/DOM-Level-3-Events/#events-WheelEvent
1366 https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-wheelevent
1368 No tests. No change in behavior.
1370 * src/WebInputEventConversion.cpp:
1371 (WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
1372 (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
1374 2013-01-31 Yury Semikhatsky <yurys@chromium.org>
1376 Unreviewed. Bump Chromium dependency to 179332
1380 2013-01-31 Mark Pilgrim <pilgrim@chromium.org>
1382 [Chromium] Move MediaPlayerPrivateChromium to WebCore
1383 https://bugs.webkit.org/show_bug.cgi?id=108415
1385 Reviewed by Adam Barth.
1387 Part of a larger refactoring series; see tracking bug 106829.
1390 * src/MediaPlayerPrivateChromium.cpp: Removed.
1392 (WebKit::initializeWithoutV8): call new setter function in
1393 WebCore::MediaPlayerPrivate
1395 2013-01-30 Sheriff Bot <webkit.review.bot@gmail.com>
1397 Unreviewed, rolling out r141358.
1398 http://trac.webkit.org/changeset/141358
1399 https://bugs.webkit.org/show_bug.cgi?id=108421
1401 breaks android builder (Requested by morrita on #webkit).
1405 * src/WebFrameImpl.cpp:
1407 2013-01-30 Nico Weber <thakis@chromium.org>
1409 [chromium] Build webkit with enable_web_intents set to 0.
1410 https://bugs.webkit.org/show_bug.cgi?id=108408
1412 Reviewed by Kentaro Hara.
1414 I'll then make chromium build fine with that, then switch
1415 enable_web_intents to 0, roll that into webkit, and then
1416 actually remove the code hidden behind this flag.
1420 * src/WebFrameImpl.cpp:
1422 2013-01-30 Levi Weintraub <leviw@chromium.org>
1424 [Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
1425 https://bugs.webkit.org/show_bug.cgi?id=108381
1427 Reviewed by James Robinson.
1429 WebPluginContainerImpl would call Document::didAddTouchEventHandler every time the plugin requested
1430 touch events. Some plugins make this request more than once, leading to an imbalance in Document's
1431 touch event handler map, and a stale node pointer when the plugin is destroyed. This change
1432 has WebPluginContainerImpl only add one ref for the plugin at a time.
1434 * src/WebPluginContainerImpl.cpp:
1435 (WebKit::WebPluginContainerImpl::requestTouchEventType):
1437 2013-01-30 Yusuf Ozuysal <yusufo@google.com>
1439 Start sending scrollType as NonBubblingGesture for flings
1440 https://bugs.webkit.org/show_bug.cgi?id=108372
1442 Reviewed by James Robinson.
1444 * src/WebCompositorInputHandlerImpl.cpp:
1445 (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
1447 2013-01-30 Tien-Ren Chen <trchen@chromium.org>
1449 [chromium] Add WebFrame::visibleContentRect()
1450 https://bugs.webkit.org/show_bug.cgi?id=108311
1452 Reviewed by James Robinson.
1454 * public/WebFrame.h:
1455 * src/WebFrameImpl.cpp:
1456 (WebKit::WebFrameImpl::visibleContentRect):
1458 * src/WebFrameImpl.h:
1461 2013-01-30 Kentaro Hara <haraken@chromium.org>
1463 Implement KeyboardEvent constructor
1464 https://bugs.webkit.org/show_bug.cgi?id=108320
1466 Reviewed by Adam Barth.
1468 Renamed keyboard event constant variables to avoid style errors.
1470 * src/WebInputEventConversion.cpp:
1471 (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
1472 * tests/WebInputEventConversionTest.cpp:
1473 * tests/WebInputEventFactoryTestGtk.cpp:
1475 2013-01-30 Kentaro Hara <haraken@chromium.org>
1477 Implement WheelEvent constructor
1478 https://bugs.webkit.org/show_bug.cgi?id=108303
1480 Reviewed by Adam Barth.
1482 This patch just renames an enum value to avoid style check error.
1484 * src/WebViewImpl.cpp:
1485 (WebKit::WebViewImpl::scrollBy):
1487 2013-01-30 Dana Jansens <danakj@chromium.org>
1489 [chromium] Add recordRenderingStats to WebSettings
1490 https://bugs.webkit.org/show_bug.cgi?id=108358
1492 Reviewed by James Robinson.
1494 * public/WebSettings.h:
1495 * src/WebSettingsImpl.cpp:
1496 (WebKit::WebSettingsImpl::setRecordRenderingStats):
1498 * src/WebSettingsImpl.h:
1500 (WebKit::WebSettingsImpl::recordRenderingStats):
1501 * src/WebViewImpl.cpp:
1502 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
1504 2013-01-30 Tony Gentilcore <tonyg@chromium.org>
1506 Fix compile error in WebFrameTest
1507 https://bugs.webkit.org/show_bug.cgi?id=108360
1509 Unreviewed build fix.
1511 Fixes compile error:
1512 ../../Source/WebKit/chromium/tests/WebFrameTest.cpp:330:5: error: converting false to pointer type for argument 1 of char testing::internal::IsNullLiteralHelper(testing::internal::Secret*) [-Werror=conversion-null]
1514 * tests/WebFrameTest.cpp:
1516 2013-01-30 John Knottenbelt <jknotten@chromium.org>
1518 [Chromium] Fix find in page rects for overflowing content.
1519 https://bugs.webkit.org/show_bug.cgi?id=104924
1521 Reviewed by Julien Chaffraix.
1523 If a div has overflowing content, we should only normalise its
1524 coordinates against the renderview or the containing scrollable block.
1526 TEST=WebFrameTest.FindInPageMatchRects
1528 * src/FindInPageCoordinates.cpp:
1529 (WebKit::enclosingScrollableAncestor):
1530 Helper function to find the enclosing containing block with an overflow clip.
1531 (WebKit::toNormalizedRect):
1532 Pass in the container as an argument.
1533 (WebKit::findInPageRectFromAbsoluteRect):
1534 Compute the container for toNormalizedRect using enclosingScrollableAncestor.
1535 * tests/WebFrameTest.cpp:
1536 Add expectations for new tests in WebFrameTest::FindInPageMatchRects and WebFrameTest::FindInPage.
1537 * tests/data/find.html:
1538 Add test case for <select> element.
1539 * tests/data/find_in_page_frame.html:
1541 - Result 15, 16 tests that containing <div> with style float:left and
1542 height:0px does not impact coordinate normalization.
1543 - Result 17, 18 tests that matches with absolute positioning are normalized containing
1544 relative positioned block, even if there is a closer parent block with overflow clip.
1545 - Result 19 adds a test case for <select> element.
1547 2013-01-30 Dominik Röttsches <dominik.rottsches@intel.com>
1549 [HarfBuzz] Remove the HarfBuzz-old code
1550 https://bugs.webkit.org/show_bug.cgi?id=108077
1552 Reviewed by Benjamin Poulain.
1554 Rename WTF_USE_HARFBUZZ_NG to WTF_USE_HARFBUZZ since there
1555 won't be a distinction between ng and non-ng HarfBuzz after
1556 removing the old code.
1560 2013-01-30 Jochen Eisinger <jochen@chromium.org>
1562 [chromium] WebConsoleMessage is missing LevelDebug (chromium bug 172416)
1563 https://bugs.webkit.org/show_bug.cgi?id=108004
1564 http://code.google.com/p/chromium/issues/detail?id=172416
1566 console.debug triggers a NOTREACHED() assertation in Chromium. This
1567 is because WebCore::MessageLevel contains 5 levels, including debug,
1568 where WebConsoleMessage::Level is missing a "debug" level. Add a
1569 WebConsoleMessage::LevelDebug so that it can get passed up to the
1570 renderer even if it doesn't make use of that now.
1572 Requires another patch to chromium itself to fix chromium bug 172416
1573 but this is a prerequisite.
1575 Also add an enum compile time check to AssertMatchingEnums.cpp,
1577 Patch by Kevin Day <kevinday@gmail.com> on 2013-01-28
1578 Reviewed by Jochen Eisinger.
1580 * public/WebConsoleMessage.h:
1581 * src/AssertMatchingEnums.cpp:
1582 * src/WebFrameImpl.cpp:
1583 (WebKit::WebFrameImpl::addMessageToConsole):
1585 2013-01-30 Xianzhu Wang <wangxianzhu@chromium.org>
1587 [Chromium] Correct zoom for focused node when using compositor scaling
1588 https://bugs.webkit.org/show_bug.cgi?id=107599
1590 Reviewed by Adam Barth.
1592 When applyDeviceScaleFactorInCompositor, targetScale should exclude device scale factor.
1593 When applyPageScaleFactorInCompositor, caret size and content sizes are in css pixels and they should be in the viewport of the new scale.
1595 Reapply r141153. Added font-size in html to ensure same caret size across platforms.
1597 * src/WebViewImpl.cpp:
1598 (WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
1600 (WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode): Extracted from scrollFocusedNodeIntoRect() to ease testing.
1601 * src/WebViewImpl.h:
1603 * tests/WebFrameTest.cpp: Updated test DivScrollEditableTest
1604 * tests/data/get_scale_for_zoom_into_editable_test.html: Moved the logic of onload script (which seems not to work) into WebFrameTest.cpp.
1606 2013-01-29 Mark Lam <mark.lam@apple.com>
1608 Rename AbstractDatabase to DatabaseBackend.
1609 https://bugs.webkit.org/show_bug.cgi?id=108275.
1611 Reviewed by Sam Weinig.
1613 This is a pure rename operation as part of the webdatabase refactoring
1614 effort. There is no semantic change in this patch.
1616 * public/WebDatabase.h:
1618 * src/DatabaseObserver.cpp:
1619 (WebCore::DatabaseObserver::databaseOpened):
1620 (WebCore::DatabaseObserver::databaseModified):
1621 (WebCore::DatabaseObserver::databaseClosed):
1622 (WebCore::DatabaseObserver::reportOpenDatabaseResult):
1623 (WebCore::DatabaseObserver::reportChangeVersionResult):
1624 (WebCore::DatabaseObserver::reportStartTransactionResult):
1625 (WebCore::DatabaseObserver::reportCommitTransactionResult):
1626 (WebCore::DatabaseObserver::reportExecuteStatementResult):
1627 (WebCore::DatabaseObserver::reportVacuumDatabaseResult):
1628 * src/WebDatabase.cpp:
1629 (WebKit::WebDatabase::WebDatabase):
1631 2013-01-29 Sheriff Bot <webkit.review.bot@gmail.com>
1633 Unreviewed, rolling out r141153.
1634 http://trac.webkit.org/changeset/141153
1635 https://bugs.webkit.org/show_bug.cgi?id=108280
1637 Caused WebFrameTest.DivScrollIntoEditableTest to fail on Mac.
1638 (Requested by keishi on #webkit).
1640 * src/WebViewImpl.cpp:
1641 (WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
1642 * src/WebViewImpl.h:
1644 * tests/WebFrameTest.cpp:
1645 * tests/data/get_scale_for_zoom_into_editable_test.html:
1647 2013-01-29 Sheriff Bot <webkit.review.bot@gmail.com>
1649 Unreviewed, rolling out r140983.
1650 http://trac.webkit.org/changeset/140983
1651 https://bugs.webkit.org/show_bug.cgi?id=108277
1653 Unfortunately, this API has one last client (Requested by
1656 * src/WebNotification.cpp:
1657 (WebKit::WebNotification::isHTML):
1658 (WebKit::WebNotification::url):
1659 (WebKit::WebNotification::iconURL):
1660 (WebKit::WebNotification::title):
1661 (WebKit::WebNotification::body):
1663 2013-01-29 Shinya Kawanaka <shinyak@chromium.org>
1665 [Chromium] Cannot copy text when selecting readonly (or disabled) input elements
1666 https://bugs.webkit.org/show_bug.cgi?id=106287
1668 Reviewed by Hajime Morita.
1670 When an input element is disabled or readonly, its inner element is not editable. So its rootEditableElement
1671 does not exist. In WebViewImpl::caretOrSelectionRange, if rootEditableElement does not exist, it uses
1672 a document element. However, the inner element and document element have a different tree scope, selection range
1673 cannot be gotten correctly.
1675 We should use ShadowRoot instead of document so that we can stay in the same tree scope.
1677 * src/WebViewImpl.cpp:
1678 (WebKit::WebViewImpl::caretOrSelectionRange):
1679 * tests/WebViewTest.cpp:
1680 * tests/data/selection_disabled.html: Added.
1681 * tests/data/selection_readonly.html: Added.
1683 2013-01-29 Tom Sepez <tsepez@chromium.org>
1685 [v8] Enable binding integrity on linux
1686 https://bugs.webkit.org/show_bug.cgi?id=108242
1688 Reviewed by Adam Barth.
1692 2013-01-29 Xianzhu Wang <wangxianzhu@chromium.org>
1694 [Chromium] Correct zoom for focused node when using compositor scaling
1695 https://bugs.webkit.org/show_bug.cgi?id=107599
1697 Reviewed by Adam Barth.
1699 When applyDeviceScaleFactorInCompositor, targetScale should exclude device scale factor.
1700 When applyPageScaleFactorInCompositor, caret size and content sizes are in css pixels and they should be in the viewport of the new scale.
1702 * src/WebViewImpl.cpp:
1703 (WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
1705 (WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode): Extracted from scrollFocusedNodeIntoRect() to ease testing.
1706 * src/WebViewImpl.h:
1708 * tests/WebFrameTest.cpp: Updated test DivScrollEditableTest
1709 * tests/data/get_scale_for_zoom_into_editable_test.html: Moved the logic of onload script (which seems not to work) into WebFrameTest.cpp.
1711 2013-01-29 Alec Flett <alecflett@chromium.org>
1713 IndexedDB: Pass metadata in to IDBOpenDBRequest.onUpgradeNeeded/onSuccess
1714 https://bugs.webkit.org/show_bug.cgi?id=103920
1716 Reviewed by Dimitri Glazkov.
1718 Support the new IDBCallbacks::onSuccess and IDBCallbacks::onUpgradeNeeded
1719 while maintaining chromium compatibility by shimming in the old API
1720 in the WebKit side. Future code will clean this up so that it is just a
1721 pass-through as it was before.
1723 * public/WebIDBCallbacks.h:
1725 (WebKit::WebIDBCallbacks::onSuccess): new method signature.
1726 (WebKit::WebIDBCallbacks::onUpgradeNeeded): new method signature.
1727 * src/IDBCallbacksProxy.cpp:
1728 (WebKit::IDBCallbacksProxy::onSuccess): call on new method signature proxies through old API.
1730 (WebKit::IDBCallbacksProxy::onUpgradeNeeded): call on new method signature proxies through old API.
1731 * src/IDBCallbacksProxy.h:
1732 (IDBCallbacksProxy):
1733 * src/WebIDBCallbacksImpl.cpp:
1734 (WebKit::WebIDBCallbacksImpl::onSuccess): call on old WebKit proxy signature calls new API.
1736 (WebKit::WebIDBCallbacksImpl::onUpgradeNeeded): call on old WebKit proxy signature calls new API.
1737 * src/WebIDBCallbacksImpl.h:
1738 (WebIDBCallbacksImpl):
1739 * tests/IDBAbortOnCorruptTest.cpp: new method signature.
1740 (WebCore::MockIDBCallbacks::onSuccess):
1741 * tests/IDBDatabaseBackendTest.cpp: new method signature.
1743 2013-01-29 Alexandre Elias <aelias@chromium.org>
1745 [chromium] Fix contents size calculation for page scale initialization
1746 https://bugs.webkit.org/show_bug.cgi?id=108204
1750 My previous patch http://webk.it/107424 had a few issues that are
1751 blocking WebKit roll.
1753 - We still need the layout in resize() given that
1754 http://webk.it/107922 was reverted.
1756 - I deleted code used only for the old page-scale mode in
1757 contentsSize(), but this needs to wait until WebKit roll since it's
1758 making bots fail in this short term.
1760 * src/WebViewImpl.cpp:
1761 (WebKit::WebViewImpl::resize):
1762 (WebKit::WebViewImpl::contentsSize):
1764 2013-01-29 Alpha Lam <hclam@chromium.org>
1766 [chromium] Unreviewed DEPS roll.
1768 Roll Chromium DEPS to 179332.
1772 2013-01-29 Joshua Bell <jsbell@chromium.org>
1774 [Chromium] IndexedDB: Let callers specify reason (error) for aborting transaction
1775 https://bugs.webkit.org/show_bug.cgi?id=107851
1777 Reviewed by Tony Chang.
1779 Let Chromium call abort() on a transaction and specify a reason, specifically for
1782 * public/WebIDBDatabase.h:
1783 (WebKit::WebIDBDatabase::abort): New overload for abort() that takes an error.
1784 * public/WebIDBDatabaseError.h:
1785 (WebKit::WebIDBDatabaseError::WebIDBDatabaseError): Overloaded constructor/assign that takes error.
1786 * src/IDBDatabaseBackendProxy.cpp:
1787 (WebKit::IDBDatabaseBackendProxy::abort): New overload for abort() that takes an error.
1788 * src/IDBDatabaseBackendProxy.h:
1789 (IDBDatabaseBackendProxy): Ditto.
1790 * src/WebIDBDatabaseError.cpp: Implementation of overload ctor/assign.
1791 * src/WebIDBDatabaseImpl.cpp:
1792 (WebKit::WebIDBDatabaseImpl::abort): New overload for abort() that takes an error.
1793 * src/WebIDBDatabaseImpl.h: Ditto.
1794 * tests/IDBDatabaseBackendTest.cpp: Overload stubs for Mock class.
1796 2013-01-29 Florin Malita <fmalita@chromium.org>
1798 [Chromium] Unreviewed gardening.
1800 Disable WebFrameTest.pageScaleFactorShrinksViewport (pending investigation after r141053).
1802 * tests/WebFrameTest.cpp:
1804 2013-01-29 Keishi Hattori <keishi@webkit.org>
1806 [Chromium] Disabling WebFrameTest.DisambiguationPopupMobileSite because WebFrameTest is still failing after r141073.
1808 Unreviewed. Gardening.
1810 * tests/WebFrameTest.cpp:
1812 2013-01-29 Sheriff Bot <webkit.review.bot@gmail.com>
1814 Unreviewed, rolling out r141064.
1815 http://trac.webkit.org/changeset/141064
1816 https://bugs.webkit.org/show_bug.cgi?id=108166
1818 [Chromium] WebFrameTest.DivScrollIntoEditableTest is failing
1819 on WinXP. (Requested by keishi on #webkit).
1821 * tests/WebFrameTest.cpp:
1822 * tests/data/get_scale_for_zoom_into_editable_test.html:
1824 2013-01-29 Keishi Hattori <keishi@webkit.org>
1826 [Chromium] Disabling WebFrameTest.DisambiguationPopup because it is failing.
1828 Unreviewed. Gardening.
1830 * tests/WebFrameTest.cpp:
1832 2013-01-28 Xianzhu Wang <wangxianzhu@chromium.org>
1834 Re-enable WebFrameTest.DivScrollIntoEditableTest
1835 https://bugs.webkit.org/show_bug.cgi?id=98558
1837 Reviewed by Adam Barth.
1839 * tests/WebFrameTest.cpp: Fixed several issues (onload script, the maximum scale factor, etc.) of WebFrameTest.DivScrollIntoEditableTest and enable it.
1840 * tests/data/get_scale_for_zoom_into_editable_test.html: Moved the logic of onload script (which seems not to work) into WebFrameTest.cpp.
1842 2013-01-28 Tien-Ren Chen <trchen@chromium.org>
1844 Fix disambiguation popup for new-style page scale
1845 https://bugs.webkit.org/show_bug.cgi?id=107391
1847 Reviewed by Adam Barth.
1849 This patch corrects various coordinate conversion for disambiguation
1850 popup for the new-style page scale mode.
1852 * src/WebViewImpl.cpp:
1853 (WebKit::WebViewImpl::handleGestureEvent):
1854 (WebKit::WebViewImpl::handleInputEvent):
1855 * tests/WebFrameTest.cpp:
1856 * tests/data/disambiguation_popup_page_scale.html: Added.
1858 2013-01-28 Sheriff Bot <webkit.review.bot@gmail.com>
1860 Unreviewed, rolling out r141049.
1861 http://trac.webkit.org/changeset/141049
1862 https://bugs.webkit.org/show_bug.cgi?id=108151
1864 Caused some indexed tests to crash. (Requested by keishi on
1867 * public/WebIDBCallbacks.h:
1869 * src/IDBCallbacksProxy.cpp:
1870 (WebKit::IDBCallbacksProxy::onUpgradeNeeded):
1871 * src/IDBCallbacksProxy.h:
1872 (IDBCallbacksProxy):
1873 * src/WebIDBCallbacksImpl.cpp:
1874 (WebKit::WebIDBCallbacksImpl::onSuccess):
1875 (WebKit::WebIDBCallbacksImpl::onUpgradeNeeded):
1876 * src/WebIDBCallbacksImpl.h:
1877 (WebIDBCallbacksImpl):
1878 * tests/IDBAbortOnCorruptTest.cpp:
1879 (WebCore::MockIDBCallbacks::onSuccess):
1880 * tests/IDBDatabaseBackendTest.cpp:
1882 2013-01-28 Raman Kumar <ramankk@chromium.org>
1884 Expose isRadioButton and isCheckbox API in chromium-webkit glue layer.
1885 https://bugs.webkit.org/show_bug.cgi?id=108031
1887 Reviewed by Adam Barth.
1889 In chromium, to know if an InputElement is radiobutton or a checkbox,
1890 we are checking for formControlType (a string comparision), which is
1891 very slow. Exposing these API to chromium will make them faster.
1893 * public/WebInputElement.h:
1895 * src/WebInputElement.cpp:
1896 (WebKit::WebInputElement::isRadioButton):
1898 (WebKit::WebInputElement::isCheckbox):
1900 2013-01-28 Alexandre Elias <aelias@chromium.org>
1902 Make page scale shrink FrameView in applyPageScaleInCompositor mode
1903 https://bugs.webkit.org/show_bug.cgi?id=107424
1905 Reviewed by Levi Weintraub.
1907 If applyPageScaleFactorInCompositor is enabled (Chromium-only setting),
1908 instead of the entire document expanding as the user pinch zooms, the
1909 viewport shrinks instead. This patch applies the pageScaleFactor to
1910 visibleContentRect to get this behavior, and simplifies Chromium's
1911 resize logic to stop hiding the true viewport size from WebCore.
1913 I verified that the scaling makes sense for all the callers of
1914 visibleContentRect. The exceptions are clip-layer size,
1915 layout size in non-fixed-layout mode, and text autosizing, which need
1916 the original unscaled size. Therefore I added a new method
1917 unscaledVisibleContentSize() to ScrollView/FrameView.
1919 This patch also modifies Page::setPageScaleFactor to perform no
1920 invalidates or layout when applyPageScaleFactorInCompositor is true,
1921 and also writes pageScaleFactor into HistoryItems instead of using
1924 Since all behavior changes are tied to applyPageScaleFactorInCompositor,
1925 this patch should be a no-op for non-Chromium ports.
1927 * src/WebViewImpl.cpp:
1928 (WebKit::WebViewImpl::scaledSize): Returns the post page-scale size
1929 similar to what visibleContentRect() now returns, except that it may
1930 be at a different scale than the current one.
1931 (WebKit::WebViewImpl::size): Back to returning density-independent
1932 size without any tricks, not the "layoutSize()" fake viewport.
1933 (WebKit::WebViewImpl::resize):
1934 (WebKit::WebViewImpl::handleInputEvent): No need to apply
1935 implTransform anymore as WebKit knows the true scroll offset; just
1936 divide event coords by pageScaleFactor.
1937 (WebKit::WebViewImpl::clampOffsetAtScale): Make this method support
1938 applyPageScaleFactorInCompositor. This is used to pre-clamp scroll
1939 offsets at a given viewport size.
1940 (WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset): Make
1941 this method support applyPageScaleFactorInCompositor (don't scale
1942 scroll offsets as they are now scale-independent).
1943 (WebKit::WebViewImpl::setPageScaleFactor): Make this method always use
1944 clampOffsetAtScale instead of bypassing it, since it's now supported.
1945 Also notify the compositor to update its state.
1946 (WebKit::WebViewImpl::contentsSize): Convenience method, removed
1947 difference between scaled and unscaled.
1948 (WebKit::WebViewImpl::layoutSize): This method returned the "fake"
1949 size we used to give FrameView. Now no longer used for much.
1950 (WebKit::WebViewImpl::computePageScaleFactorLimits):
1951 (WebKit::WebViewImpl::didChangeContentsSize): Remove unnecessary
1952 resize() now that we can give the true size to FrameView.
1953 (WebKit::WebViewImpl::updateLayerTreeViewport): Use layoutSize()
1954 directly now that FrameView no longer uses it.
1955 * src/WebViewImpl.h:
1957 * tests/WebFrameTest.cpp:
1959 2013-01-28 Alec Flett <alecflett@chromium.org>
1961 IndexedDB: Pass metadata in to IDBOpenDBRequest.onUpgradeNeeded/onSuccess
1962 https://bugs.webkit.org/show_bug.cgi?id=103920
1964 Reviewed by Dimitri Glazkov.
1966 Support the new IDBCallbacks::onSuccess and IDBCallbacks::onUpgradeNeeded
1967 while maintaining chromium compatibility by shimming in the old API
1968 in the WebKit side. Future code will clean this up so that it is just a
1969 pass-through as it was before.
1971 * public/WebIDBCallbacks.h:
1973 (WebKit::WebIDBCallbacks::onSuccess): new method signature.
1974 (WebKit::WebIDBCallbacks::onUpgradeNeeded): new method signature.
1975 * src/IDBCallbacksProxy.cpp:
1976 (WebKit::IDBCallbacksProxy::onSuccess): call on new method signature proxies through old API.
1978 (WebKit::IDBCallbacksProxy::onUpgradeNeeded): call on new method signature proxies through old API.
1979 * src/IDBCallbacksProxy.h:
1980 (IDBCallbacksProxy):
1981 * src/WebIDBCallbacksImpl.cpp:
1982 (WebKit::WebIDBCallbacksImpl::onSuccess): call on old WebKit proxy signature calls new API.
1984 (WebKit::WebIDBCallbacksImpl::onUpgradeNeeded): call on old WebKit proxy signature calls new API.
1985 * src/WebIDBCallbacksImpl.h:
1986 (WebIDBCallbacksImpl):
1987 * tests/IDBAbortOnCorruptTest.cpp: new method signature.
1988 (WebCore::MockIDBCallbacks::onSuccess):
1989 * tests/IDBDatabaseBackendTest.cpp: new method signature.
1991 2013-01-28 Tom Sepez <tsepez@chromium.org>
1993 [v8] Security feature: JavaScript Bindings hardening
1994 https://bugs.webkit.org/show_bug.cgi?id=106608
1996 Reviewed by Adam Barth.
1999 Added ENABLE_BINDING_INTEGRITY option.
2001 2013-01-28 Sheriff Bot <webkit.review.bot@gmail.com>
2003 Unreviewed, rolling out r141006.
2004 http://trac.webkit.org/changeset/141006
2005 https://bugs.webkit.org/show_bug.cgi?id=108123
2007 Broke chromium build (Requested by arv on #webkit).
2009 * public/WebConsoleMessage.h:
2010 * src/AssertMatchingEnums.cpp:
2011 * src/WebFrameImpl.cpp:
2012 (WebKit::WebFrameImpl::addMessageToConsole):
2014 2013-01-28 Min Qin <qinmin@chromium.org>
2016 adding support for DiscardablePixelRef for caching lazily decoded images
2017 https://bugs.webkit.org/show_bug.cgi?id=106842
2019 Reviewed by Stephen White.
2021 Adding new tests for ImageDecodingStore
2024 * tests/ImageDecodingStoreTest.cpp:
2025 (WebCore::ImageDecodingStoreTest::createCompleteImage):
2026 (WebCore::ImageDecodingStoreTest::createIncompleteImage):
2029 * tests/MockDiscardablePixelRef.h: Added.
2031 (MockDiscardablePixelRef):
2032 (WebCore::MockDiscardablePixelRef::MockDiscardablePixelRef):
2033 (WebCore::MockDiscardablePixelRef::~MockDiscardablePixelRef):
2034 (WebCore::MockDiscardablePixelRef::discard):
2035 (WebCore::MockDiscardablePixelRef::onLockPixels):
2036 (WebCore::MockDiscardablePixelRef::onUnlockPixels):
2038 2013-01-28 Stephen Chenney <schenney@chromium.org>
2040 [Chromium] Fix the build.
2042 Unreviewed build fix.
2044 * src/AssertMatchingEnums.cpp: Move the include to the right place and remove the bad directory prefix.
2046 2013-01-28 Dan Alcantara <dfalcantara@chromium.org>
2048 [Chromium, Mobile] Do not show disambiguation pop up in mobile sites
2049 https://bugs.webkit.org/show_bug.cgi?id=107607
2051 Reviewed by Adam Barth.
2053 Add a check before showing the disambiguation popup to prevent it from appearing
2054 on mobile sites. Makes a similar test to the current disambiguation popup test
2055 that expects the popup to never appear.
2057 * src/WebViewImpl.cpp:
2058 (WebKit::WebViewImpl::handleGestureEvent):
2060 (WebKit::WebViewImpl::isLikelyMobileSite):
2061 * src/WebViewImpl.h:
2063 * tests/WebFrameTest.cpp:
2064 * tests/data/disambiguation_popup_mobile_site.html: Added.
2066 * src/WebViewImpl.cpp:
2067 (WebKit::WebViewImpl::handleGestureEvent):
2069 (WebKit::WebViewImpl::shouldDisableDesktopWorkarounds):
2070 * src/WebViewImpl.h:
2072 * tests/WebFrameTest.cpp:
2073 * tests/data/disambiguation_popup_mobile_site.html: Added.
2075 2013-01-28 Stephen Chenney <schenney@chromium.org>
2077 [Chromium] Fix the build.
2079 Unreviewed build fix.
2081 * src/AssertMatchingEnums.cpp: Move the include to the right place and remove the bad directory prefix.
2083 2013-01-28 Sheriff Bot <webkit.review.bot@gmail.com>
2085 Unreviewed, rolling out r140869.
2086 http://trac.webkit.org/changeset/140869
2087 https://bugs.webkit.org/show_bug.cgi?id=108120
2089 "Crashes on http://en.wikipedia.org/wiki/Wikipedia" (Requested
2090 by tonyg-cr on #webkit).
2092 * src/WebViewImpl.cpp:
2093 (WebKit::WebViewImpl::resize):
2094 (WebKit::WebViewImpl::computePageScaleFactorLimits):
2095 * tests/WebFrameTest.cpp:
2097 2013-01-28 Sheriff Bot <webkit.review.bot@gmail.com>
2099 Unreviewed, rolling out r140934, r140935, and r140937.
2100 http://trac.webkit.org/changeset/140934
2101 http://trac.webkit.org/changeset/140935
2102 http://trac.webkit.org/changeset/140937
2103 https://bugs.webkit.org/show_bug.cgi?id=108117
2105 Re-land some speculative rollouts - see wkbug.com/108048 for
2106 context (Requested by jsbell on #webkit).
2108 * public/WebIDBCallbacks.h:
2110 * src/AssertMatchingEnums.cpp:
2111 * src/IDBCallbacksProxy.cpp:
2112 * src/IDBCallbacksProxy.h:
2113 (IDBCallbacksProxy):
2114 * src/WebIDBCallbacksImpl.cpp:
2115 * src/WebIDBCallbacksImpl.h:
2116 (WebIDBCallbacksImpl):
2117 * tests/IDBAbortOnCorruptTest.cpp:
2118 * tests/IDBDatabaseBackendTest.cpp:
2120 2013-01-28 Kevin Day <kevinday@gmail.com>
2122 [chromium] WebConsoleMessage is missing LevelDebug (chromium bug 172416)
2123 https://bugs.webkit.org/show_bug.cgi?id=108004
2124 http://code.google.com/p/chromium/issues/detail?id=172416
2126 console.debug triggers a NOTREACHED() assertation in Chromium. This
2127 is because WebCore::MessageLevel contains 5 levels, including debug,
2128 where WebConsoleMessage::Level is missing a "debug" level. Add a
2129 WebConsoleMessage::LevelDebug so that it can get passed up to the
2130 renderer even if it doesn't make use of that now.
2132 Requires another patch to chromium itself to fix chromium bug 172416
2133 but this is a prerequisite.
2135 Also add an enum compile time check to AssertMatchingEnums.cpp,
2137 Reviewed by Jochen Eisinger.
2139 * public/WebConsoleMessage.h:
2140 * src/AssertMatchingEnums.cpp:
2141 * src/WebFrameImpl.cpp:
2142 (WebKit::WebFrameImpl::addMessageToConsole):
2144 2013-01-28 Xianzhu Wang <wangxianzhu@chromium.org>
2146 [Chromium] Correct auto-zoom when using compositor scaling
2147 https://bugs.webkit.org/show_bug.cgi?id=107592
2149 Reviewed by Adam Barth.
2151 1. The scale of auto-zoom should exclude deviceScaleFactor because the compositor will handle the scaling;
2152 2. Scroll location needs to be calculated differently when pageScaleFactor is handled by the compositor.
2154 * src/WebViewImpl.cpp:
2155 (WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
2156 * tests/WebFrameTest.cpp: Updated tests DivAutoZoomParamsTest, DivAutoZoomMultipleDivsTest, DivAutoZoomScaleBoundsTest and DivAutoZoomScaleFontScaleFactorTest, to make two versions of them (WebKitScaling and CompositorScaling).
2158 2013-01-28 Laszlo Gombos <l.gombos@samsung.com>
2160 Collapse OS(UNIX)||OS(ANDROID) to OS(UNIX)
2161 https://bugs.webkit.org/show_bug.cgi?id=108091
2163 Reviewed by Adam Barth.
2165 OS(UNIX) is defined when OS(ANDROID) is defined.
2167 * src/WebViewImpl.cpp:
2168 (WebKit::WebViewImpl::handleMouseDown):
2170 2013-01-28 Adam Barth <abarth@webkit.org>
2172 Remove webkitNotifications.createHTMLNotification
2173 https://bugs.webkit.org/show_bug.cgi?id=107598
2175 Reviewed by Benjamin Poulain.
2177 We can remove these stubs once we've removed the Chromium-side code
2178 that depends on them.
2180 * src/WebNotification.cpp:
2181 (WebKit::WebNotification::isHTML):
2182 (WebKit::WebNotification::url):
2183 (WebKit::WebNotification::iconURL):
2184 (WebKit::WebNotification::title):
2185 (WebKit::WebNotification::body):
2187 2013-01-28 James Craig <james@cookiecrook.com>
2189 HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match.
2190 https://bugs.webkit.org/show_bug.cgi?id=107650
2192 Reviewed by Chris Fleizach.
2194 Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).
2196 * public/WebAccessibilityRole.h:
2197 * src/AssertMatchingEnums.cpp:
2198 * src/LocalizedStrings.cpp:
2199 (WebCore::AXDefinitionText):
2201 (WebCore::AXDescriptionListTermText):
2202 (WebCore::AXDescriptionListDetailText):
2204 2013-01-28 Mike West <mkwst@chromium.org>
2206 [chromium] Unreviewed build fix, missing include in AssertMatchingEnums.cpp
2207 https://bugs.webkit.org/show_bug.cgi?id=108086
2209 Disabling SVG exposed a missing include in AssertMatchingEnums. This
2212 * src/AssertMatchingEnums.cpp:
2213 Include 'ResourceLoadPriority.h'.
2215 2013-01-28 Marja Hölttä <marja@chromium.org>
2217 Add an API for retrieving native memory information without going through the remote inspecting protocol
2218 https://bugs.webkit.org/show_bug.cgi?id=107651
2220 Reviewed by Adam Barth.
2223 * public/WebDevToolsAgent.h:
2226 * public/WebMemoryUsageInfo.h: Added.
2228 (WebKit::WebMemoryUsageInfo::WebMemoryUsageInfo):
2229 (WebMemoryUsageInfo):
2230 * src/WebDevToolsAgentImpl.cpp:
2231 (WebKit::WebDevToolsAgentImpl::processMemoryDistribution):
2233 * src/WebDevToolsAgentImpl.h:
2235 (WebDevToolsAgentImpl):
2237 2013-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
2239 Unreviewed, rolling out r140602.
2240 http://trac.webkit.org/changeset/140602
2241 https://bugs.webkit.org/show_bug.cgi?id=108045
2243 Caused 8 indexed tests to crash. (Requested by keishi on
2246 * public/WebIDBCallbacks.h:
2247 * src/IDBCallbacksProxy.cpp:
2248 (WebKit::IDBCallbacksProxy::onBlocked):
2250 * src/IDBCallbacksProxy.h:
2251 (IDBCallbacksProxy):
2252 * src/WebIDBCallbacksImpl.cpp:
2253 (WebKit::WebIDBCallbacksImpl::onBlocked):
2255 * src/WebIDBCallbacksImpl.h:
2256 (WebIDBCallbacksImpl):
2257 * tests/IDBAbortOnCorruptTest.cpp:
2258 (WebCore::MockIDBCallbacks::onBlocked):
2259 * tests/IDBDatabaseBackendTest.cpp:
2261 2013-01-27 Keishi Hattori <keishi@webkit.org>
2263 Unreviewed, rolling out r140850.
2264 http://trac.webkit.org/changeset/140850
2265 https://bugs.webkit.org/show_bug.cgi?id=107960
2267 r14602 caused 8 indexed tests to crash.
2269 * src/AssertMatchingEnums.cpp:
2271 2013-01-27 Jochen Eisinger <jochen@chromium.org>
2273 [chromium] add missing plumbing for Notification.requestPermission
2274 https://bugs.webkit.org/show_bug.cgi?id=108012
2276 Reviewed by Adam Barth.
2278 * src/NotificationPresenterImpl.cpp:
2280 (WebKit::VoidCallbackClient::VoidCallbackClient):
2281 (NotificationPermissionCallbackClient):
2282 (WebKit::NotificationPermissionCallbackClient::NotificationPermissionCallbackClient):
2283 (WebKit::NotificationPermissionCallbackClient::permissionRequestComplete):
2284 (WebKit::NotificationPermissionCallbackClient::~NotificationPermissionCallbackClient):
2285 (WebKit::NotificationPresenterImpl::requestPermission):
2286 * src/NotificationPresenterImpl.h:
2287 (NotificationPresenterImpl):
2289 2013-01-26 James Simonsen <simonjam@chromium.org>
2291 [chromium] Export ResourceRequest's priority through WebURLRequest
2292 https://bugs.webkit.org/show_bug.cgi?id=107985
2294 Reviewed by Adam Barth.
2296 * src/AssertMatchingEnums.cpp:
2298 2013-01-25 Alexandre Elias <aelias@chromium.org>
2300 Call FrameView::contentsResized() when setting fixed layout size
2301 https://bugs.webkit.org/show_bug.cgi?id=107922
2303 Reviewed by James Robinson.
2305 In fixed layout mode, we should be calling contentsResized() when the
2306 fixed layout size is changed; on the other hand, we don't need to layout
2307 when the visible contents size changes.
2309 This fixes test WebFrameTest::FixedLayoutInitializeAtMinimumPageScale.
2311 * src/WebViewImpl.cpp:
2312 (WebKit::WebViewImpl::resize):
2313 (WebKit::WebViewImpl::computePageScaleFactorLimits):
2314 * tests/WebFrameTest.cpp:
2316 2013-01-25 Alec Flett <alecflett@chromium.org>
2318 IndexedDB: Move TaskType enum to IDBDatabaseBackendInterface
2319 https://bugs.webkit.org/show_bug.cgi?id=107960
2321 Reviewed by Tony Chang.
2323 Update asserts to reflect new enum location.
2325 * src/AssertMatchingEnums.cpp:
2327 2013-01-25 Sheriff Bot <webkit.review.bot@gmail.com>
2329 Unreviewed, rolling out r140774.
2330 http://trac.webkit.org/changeset/140774
2331 https://bugs.webkit.org/show_bug.cgi?id=107932
2333 Tests ScrollingCoordinatorChromiumTest.fastScrollingByDefault
2334 and fastScrollingForFixedPosition are failing (Requested by
2337 * public/WebWidget.h:
2339 (WebKit::WebWidget::isInputThrottled):
2340 (WebKit::WebWidget::renderingStats):
2341 * src/WebViewImpl.cpp:
2342 (WebKit::WebViewImpl::WebViewImpl):
2343 (WebKit::WebViewImpl::~WebViewImpl):
2344 (WebKit::WebViewImpl::renderingStats):
2346 (WebKit::WebViewImpl::setCompositorSurfaceReady):
2347 (WebKit::WebViewImpl::isInputThrottled):
2348 (WebKit::WebViewImpl::setIsTransparent):
2349 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2350 * src/WebViewImpl.h:
2352 2013-01-25 Eberhard Graether <egraether@google.com>
2354 Web Inspector: add checkbox for continuous painting to the inspector's settings
2355 https://bugs.webkit.org/show_bug.cgi?id=107352
2357 Reviewed by Pavel Feldman.
2359 This change adds a checkbox to activate continuous painting to the WebInspector's
2360 rendering settings and plumbs the setting to Chromium's WebLayerTreeView. The
2361 setting is visible if InspectorClient::canContinuouslyPaint() returns true.
2365 * src/InspectorClientImpl.cpp:
2366 (WebKit::InspectorClientImpl::canContinuouslyPaint):
2368 (WebKit::InspectorClientImpl::setContinuousPaintingEnabled):
2369 * src/InspectorClientImpl.h:
2370 (InspectorClientImpl):
2371 * src/WebViewImpl.cpp:
2372 (WebKit::WebViewImpl::setContinuousPaintingEnabled):
2374 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2375 * src/WebViewImpl.h:
2377 2013-01-24 Keishi Hattori <keishi@webkit.org>
2379 Adjust design of the Calendar Picker
2380 https://bugs.webkit.org/show_bug.cgi?id=107507
2382 Reviewed by Kent Tamura.
2384 * src/DateTimeChooserImpl.cpp:
2385 (WebKit::DateTimeChooserImpl::writeDocument): Include pickerCommonChromium.css and calendarPickerChromium.css.
2387 2013-01-24 James Robinson <jamesr@chromium.org>
2389 [chromium] Remove dead transitional code from WebViewImpl
2390 https://bugs.webkit.org/show_bug.cgi?id=107889
2392 Reviewed by Adrienne Walker.
2394 The chromium side of this landed at r178256 and seems stable.
2396 * public/WebWidget.h:
2397 (WebKit::WebWidget::setCompositorSurfaceReady):
2398 * src/WebViewImpl.cpp:
2399 (WebKit::WebViewImpl::WebViewImpl):
2400 (WebKit::WebViewImpl::~WebViewImpl):
2402 (WebKit::WebViewImpl::setIsTransparent):
2403 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2404 * src/WebViewImpl.h:
2406 2013-01-24 James Robinson <jamesr@chromium.org>
2408 [chromium] Null check WebLayerTreeView before dereffing in WebViewImpl::invalidateRect
2409 https://bugs.webkit.org/show_bug.cgi?id=107855
2411 Reviewed by Adrienne Walker.
2413 During frame shutdown, WebViewImpl::m_layerTreeView may become 0 while commits are deferred but we still
2414 may get invalidateRect() calls before shutdown completes.
2416 * src/WebViewImpl.cpp:
2417 (WebKit::WebViewImpl::invalidateRect):
2419 2013-01-24 Mihai Maerean <mmaerean@adobe.com>
2421 [CSSRegions] remove setExperimentalCSSRegionsEnabled deprecated API in Source/WebKit/chromium/public/WebSettings.h
2422 https://bugs.webkit.org/show_bug.cgi?id=104564
2424 Reviewed by Adam Barth.
2426 Fixing bug 101192 has deprecated the use of setExperimentalCSSRegionsEnabled.
2427 After http://code.google.com/p/chromium/issues/detail?id=164162 , setExperimentalCSSRegionsEnabled is no longer used anywhere.
2429 * public/WebSettings.h:
2430 removed setExperimentalCSSRegionsEnabled.
2432 2013-01-23 Sheriff Bot <webkit.review.bot@gmail.com>
2434 Unreviewed. Rolled Chromium DEPS to r178434. Requested by
2435 "Yoshifumi Inoue" <yosin@chromium.org> via sheriffbot.
2439 2013-01-23 Mark Pilgrim <pilgrim@chromium.org>
2441 [Chromium] Remove unused header files in chromium/public/platform/
2442 https://bugs.webkit.org/show_bug.cgi?id=107741
2444 Reviewed by James Robinson.
2446 These header files have migrated to the new Platform directory.
2447 This patch updates the remaining #include references and removes
2448 the old files that did nothing but redirect to the new ones.
2451 * public/WebAccessibilityObject.h:
2452 * public/WebAccessibilityRole.h:
2453 * public/WebActiveWheelFlingParameters.h:
2454 * public/WebAnimationController.h:
2455 * public/WebApplicationCacheHost.h:
2456 * public/WebApplicationCacheHostClient.h:
2457 * public/WebArrayBuffer.h:
2458 * public/WebArrayBufferView.h:
2459 * public/WebAudioSourceProvider.h:
2460 * public/WebBatteryStatus.h:
2461 * public/WebBindings.h:
2463 * public/WebCache.h:
2464 * public/WebCachedURLRequest.h:
2465 * public/WebColorChooser.h:
2466 * public/WebColorChooserClient.h:
2467 * public/WebColorName.h:
2468 * public/WebCommonWorkerClient.h:
2469 * public/WebCompositionUnderline.h:
2470 * public/WebCompositorInputHandler.h:
2471 * public/WebConsoleMessage.h:
2472 * public/WebContentDetectionResult.h:
2473 * public/WebContextMenuData.h:
2474 * public/WebCrossOriginPreflightResultCache.h:
2475 * public/WebCursorInfo.h:
2476 * public/WebDOMEvent.h:
2477 * public/WebDOMEventListener.h:
2478 * public/WebDOMStringList.h:
2479 * public/WebDataSource.h:
2480 * public/WebDatabase.h:
2481 * public/WebDateTimeChooserCompletion.h:
2482 * public/WebDateTimeChooserParams.h:
2483 * public/WebDeliveredIntentClient.h:
2484 * public/WebDevToolsAgent.h:
2485 * public/WebDevToolsAgentClient.h:
2486 * public/WebDevToolsFrontend.h:
2487 * public/WebDeviceOrientationClient.h:
2488 * public/WebDeviceOrientationClientMock.h:
2489 * public/WebDeviceOrientationController.h:
2490 * public/WebDocument.h:
2491 * public/WebDraggableRegion.h:
2492 * public/WebExternalPopupMenuClient.h:
2493 * public/WebFileChooserCompletion.h:
2494 * public/WebFileChooserParams.h:
2495 * public/WebFileSystemCallbacks.h:
2496 * public/WebFileSystemEntry.h:
2497 * public/WebFileWriter.h:
2498 * public/WebFileWriterClient.h:
2499 * public/WebFindOptions.h:
2501 * public/WebFontCache.h:
2502 * public/WebFontDescription.h:
2503 * public/WebFormControlElement.h:
2504 * public/WebFormElement.h:
2505 * public/WebFrame.h:
2506 * public/WebFrameClient.h:
2507 * public/WebGeolocationClientMock.h:
2508 * public/WebGeolocationController.h:
2509 * public/WebGeolocationError.h:
2510 * public/WebGeolocationPermissionRequest.h:
2511 * public/WebGeolocationPermissionRequestManager.h:
2512 * public/WebGeolocationPosition.h:
2513 * public/WebGlyphCache.h:
2514 * public/WebHelperPlugin.h:
2515 * public/WebHistoryItem.h:
2516 * public/WebHitTestResult.h:
2517 * public/WebIDBCallbacks.h:
2518 * public/WebIDBCursor.h:
2519 * public/WebIDBDatabase.h:
2520 * public/WebIDBDatabaseCallbacks.h:
2521 * public/WebIDBDatabaseError.h:
2522 * public/WebIDBFactory.h:
2523 * public/WebIDBKey.h:
2524 * public/WebIDBKeyPath.h:
2525 * public/WebIDBKeyRange.h:
2526 * public/WebIDBMetadata.h:
2527 * public/WebIDBTransaction.h:
2528 * public/WebIDBTransactionCallbacks.h:
2529 * public/WebIconURL.h:
2530 * public/WebImageDecoder.h:
2531 * public/WebInputEvent.h:
2532 * public/WebIntent.h:
2533 * public/WebIntentRequest.h:
2534 * public/WebIntentServiceInfo.h:
2536 * public/WebMediaPlayer.h:
2537 * public/WebMediaStreamRegistry.h:
2538 * public/WebMenuItemInfo.h:
2539 * public/WebNetworkStateNotifier.h:
2541 * public/WebNodeCollection.h:
2542 * public/WebNodeList.h:
2543 * public/WebNotification.h:
2544 * public/WebNotificationPresenter.h:
2545 * public/WebOptionElement.h:
2546 * public/WebPageOverlay.h:
2547 * public/WebPagePopup.h:
2548 * public/WebPageSerializer.h:
2549 * public/WebPasswordFormData.h:
2550 * public/WebPerformance.h:
2551 * public/WebPlugin.h:
2552 * public/WebPluginContainer.h:
2553 * public/WebPluginParams.h:
2554 * public/WebPopupMenu.h:
2555 * public/WebPopupMenuInfo.h:
2556 * public/WebPrerendererClient.h:
2557 * public/WebPrintParams.h:
2558 * public/WebRange.h:
2559 * public/WebRegularExpression.h:
2560 * public/WebRuntimeFeatures.h:
2561 * public/WebScopedMicrotaskSuppression.h:
2562 * public/WebScopedUserGesture.h:
2563 * public/WebScriptController.h:
2564 * public/WebScriptSource.h:
2565 * public/WebSearchableFormData.h:
2566 * public/WebSecurityOrigin.h:
2567 * public/WebSecurityPolicy.h:
2568 * public/WebSelectElement.h:
2569 * public/WebSerializedScriptValue.h:
2570 * public/WebSettings.h:
2571 * public/WebSharedWorker.h:
2572 * public/WebSharedWorkerRepository.h:
2573 * public/WebSocket.h:
2574 * public/WebSocketClient.h:
2575 * public/WebSpeechGrammar.h:
2576 * public/WebSpeechInputController.h:
2577 * public/WebSpeechInputResult.h:
2578 * public/WebSpeechRecognitionHandle.h:
2579 * public/WebSpeechRecognitionParams.h:
2580 * public/WebSpeechRecognitionResult.h:
2581 * public/WebSpeechRecognizer.h:
2582 * public/WebSpeechRecognizerClient.h:
2583 * public/WebSpellCheckClient.h:
2584 * public/WebStorageEventDispatcher.h:
2585 * public/WebSurroundingText.h:
2586 * public/WebTestingSupport.h:
2587 * public/WebTextCheckingCompletion.h:
2588 * public/WebTextCheckingResult.h:
2589 * public/WebTextFieldDecoratorClient.h:
2590 * public/WebTextInputInfo.h:
2591 * public/WebTextRun.h:
2592 * public/WebTimeRange.h:
2593 * public/WebTouchPoint.h:
2594 * public/WebUserMediaRequest.h:
2596 * public/WebViewBenchmarkSupport.h:
2597 * public/WebViewClient.h:
2598 * public/WebWidget.h:
2599 * public/WebWidgetClient.h:
2600 * public/WebWindowFeatures.h:
2601 * public/WebWorkerInfo.h:
2602 * public/android/WebInputEventFactory.h:
2603 * public/android/WebSandboxSupport.h:
2604 * public/default/WebRenderTheme.h:
2605 * public/gtk/WebInputEventFactory.h:
2606 * public/linux/WebFontRendering.h:
2607 * public/linux/WebSandboxSupport.h:
2608 * public/mac/WebInputEventFactory.h:
2609 * public/mac/WebSandboxSupport.h:
2610 * public/mac/WebScreenInfoFactory.h:
2611 * public/mac/WebSubstringUtil.h:
2612 * public/platform/WebAudioBus.h: Removed.
2613 * public/platform/WebAudioDevice.h: Removed.
2614 * public/platform/WebBlobData.h: Removed.
2615 * public/platform/WebBlobRegistry.h: Removed.
2616 * public/platform/WebCString.h: Removed.
2617 * public/platform/WebCanvas.h: Removed.
2618 * public/platform/WebClipboard.h: Removed.
2619 * public/platform/WebColor.h: Removed.
2620 * public/platform/WebCommon.h: Removed.
2621 * public/platform/WebCookie.h: Removed.
2622 * public/platform/WebCookieJar.h: Removed.
2623 * public/platform/WebData.h: Removed.
2624 * public/platform/WebDragData.h: Removed.
2625 * public/platform/WebFileSystem.h: Removed.
2626 * public/platform/WebFloatPoint.h: Removed.
2627 * public/platform/WebFloatQuad.h: Removed.
2628 * public/platform/WebFloatRect.h: Removed.
2629 * public/platform/WebGamepad.h: Removed.
2630 * public/platform/WebGamepads.h: Removed.
2631 * public/platform/WebGraphicsContext3D.h: Removed.
2632 * public/platform/WebHTTPBody.h: Removed.
2633 * public/platform/WebHTTPHeaderVisitor.h: Removed.
2634 * public/platform/WebHTTPLoadInfo.h: Removed.
2635 * public/platform/WebImage.h: Removed.
2636 * public/platform/WebLocalizedString.h: Removed.
2637 * public/platform/WebMediaStreamCenter.h: Removed.
2638 * public/platform/WebMediaStreamCenterClient.h: Removed.
2639 * public/platform/WebMediaStreamComponent.h: Removed.
2640 * public/platform/WebMediaStreamDescriptor.h: Removed.
2641 * public/platform/WebMediaStreamSource.h: Removed.
2642 * public/platform/WebMediaStreamSourcesRequest.h: Removed.
2643 * public/platform/WebNonCopyable.h: Removed.
2644 * public/platform/WebPoint.h: Removed.
2645 * public/platform/WebPrivateOwnPtr.h: Removed.
2646 * public/platform/WebPrivatePtr.h: Removed.
2647 * public/platform/WebRect.h: Removed.
2648 * public/platform/WebReferrerPolicy.h: Removed.
2649 * public/platform/WebSize.h: Removed.
2650 * public/platform/WebSocketStreamError.h: Removed.
2651 * public/platform/WebSocketStreamHandle.h: Removed.
2652 * public/platform/WebSocketStreamHandleClient.h: Removed.
2653 * public/platform/WebString.h: Removed.
2654 * public/platform/WebThread.h: Removed.
2655 * public/platform/WebThreadSafeData.h: Removed.
2656 * public/platform/WebURL.h: Removed.
2657 * public/platform/WebURLError.h: Removed.
2658 * public/platform/WebURLLoadTiming.h: Removed.
2659 * public/platform/WebURLLoader.h: Removed.
2660 * public/platform/WebURLLoaderClient.h: Removed.
2661 * public/platform/WebURLRequest.h: Removed.
2662 * public/platform/WebURLResponse.h: Removed.
2663 * public/platform/WebVector.h: Removed.
2664 * public/platform/android/WebSandboxSupport.h: Removed.
2665 * public/platform/android/WebThemeEngine.h: Removed.
2666 * public/platform/default/WebThemeEngine.h: Removed.
2667 * public/platform/linux/WebFontFamily.h: Removed.
2668 * public/platform/linux/WebSandboxSupport.h: Removed.
2669 * public/platform/mac/WebSandboxSupport.h: Removed.
2670 * public/platform/mac/WebThemeEngine.h: Removed.
2671 * public/platform/win/WebSandboxSupport.h: Removed.
2672 * public/platform/win/WebThemeEngine.h: Removed.
2673 * public/win/WebInputEventFactory.h:
2674 * public/win/WebSandboxSupport.h:
2675 * public/win/WebScreenInfoFactory.h:
2676 * public/x11/WebScreenInfoFactory.h:
2678 2013-01-23 Joshua Bell <jsbell@chromium.org>
2680 IndexedDB: Remove IDBVersionChangeRequest
2681 https://bugs.webkit.org/show_bug.cgi?id=107711
2683 Reviewed by Tony Chang.
2685 * public/WebIDBCallbacks.h: Note to delete onBlocked() once Chromium is cleaned up.
2686 * src/IDBCallbacksProxy.cpp: Remove unused onBlocked() overload.
2687 * src/IDBCallbacksProxy.h: Ditto.
2688 * src/WebIDBCallbacksImpl.cpp: Ditto.
2689 * src/WebIDBCallbacksImpl.h: Ditto.
2690 * tests/IDBAbortOnCorruptTest.cpp: Ditto.
2691 * tests/IDBDatabaseBackendTest.cpp: Ditto.
2693 2013-01-23 Tien-Ren Chen <trchen@chromium.org>
2695 Partially revert 104427, change WebWidgetClient::didHandleGestureEvent semantics.
2696 https://bugs.webkit.org/show_bug.cgi?id=107605
2698 Reviewed by Darin Fisher.
2700 Per discussion in https://codereview.chromium.org/11473027/ we decided
2701 not to introduce an enum to WebWidgetClient::didHandleGestureEvent().
2702 Instead, change the semantics of the bool flag to indicate whether the
2703 gesture event is cancelled for disambiguation.
2705 * public/WebWidgetClient.h:
2706 (WebKit::WebWidgetClient::didHandleGestureEvent):
2707 * src/WebViewImpl.cpp:
2708 (WebKit::WebViewImpl::handleGestureEvent):
2709 * tests/WebViewTest.cpp:
2711 2013-01-23 Mark Pilgrim <pilgrim@chromium.org>
2713 [Chromium] Remove WebArrayBufferView and WebSerializedScriptValue from chromium/public/platform/
2714 https://bugs.webkit.org/show_bug.cgi?id=107720
2716 Reviewed by Darin Fisher.
2718 These headers have been moved to chromium/public/ and all
2719 references downstream were changed in
2720 https://codereview.chromium.org/11946050/.
2721 No DEPS roll necessary because it's already above 177695.
2724 * public/platform/WebArrayBufferView.h: Removed.
2725 * public/platform/WebSerializedScriptValue.h: Removed.
2726 * src/DeliveredIntentClientImpl.cpp:
2727 * src/IDBCallbacksProxy.cpp:
2728 * src/IDBCursorBackendProxy.cpp:
2729 * src/WebArrayBufferView.cpp:
2730 * src/WebBindings.cpp:
2731 * src/WebDOMCustomEvent.cpp:
2732 * src/WebDOMMessageEvent.cpp:
2733 * src/WebFrameImpl.cpp:
2734 * src/WebHistoryItem.cpp:
2735 * src/WebIDBCallbacksImpl.cpp:
2736 * src/WebIntent.cpp:
2737 * src/WebIntentRequest.cpp:
2738 * src/WebSerializedScriptValue.cpp:
2740 2013-01-23 Mark Pilgrim <pilgrim@chromium.org>
2742 [Chromium] Fix some #includes to headers in chromium/public/platform/ that have been moved to the new Platform directory
2743 https://bugs.webkit.org/show_bug.cgi?id=107722
2745 Reviewed by Darin Fisher.
2747 These headers just redirect to the new versions, so call the new
2750 * src/linux/WebFontInfo.cpp:
2751 * src/mac/WebSubstringUtil.mm:
2753 2013-01-23 Mark Pilgrim <pilgrim@chromium.org>
2755 [Chromium] Fix some #includes for WebSerializedScriptValue
2756 https://bugs.webkit.org/show_bug.cgi?id=107697
2758 Reviewed by Adam Barth.
2760 WebSerializedScriptValue has been moved to chromium/public/.
2762 * public/WebDOMCustomEvent.h:
2763 * public/WebDOMMessageEvent.h:
2764 * public/WebIDBCursor.h:
2766 2013-01-23 Dmitry Gozman <dgozman@chromium.org>
2768 Added changeAttachedWindowHeight method to inspector frontend API, which
2769 allows to change inspector window height from inside.
2770 https://bugs.webkit.org/show_bug.cgi?id=107648
2772 Reviewed by Pavel Feldman.
2774 * public/WebDevToolsFrontendClient.h:
2775 (WebKit::WebDevToolsFrontendClient::changeAttachedWindowHeight):
2776 * src/InspectorFrontendClientImpl.cpp:
2777 (WebKit::InspectorFrontendClientImpl::changeAttachedWindowHeight):
2779 2013-01-23 Shinya Kawanaka <shinyak@chromium.org>
2781 shadowAncestorNode() should be renamed to deprecatedShadowAncestorNode()
2782 https://bugs.webkit.org/show_bug.cgi?id=107624
2784 Reviewed by Dimitri Glazkov.
2786 Since Node::shadowAncestorNode() is deprecated, we would like to rename it to prevent from further use.
2788 * src/WebFrameImpl.cpp:
2789 (WebKit::WebFrameImpl::scopeStringMatches):
2790 (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
2792 2013-01-22 Pavel Feldman <pfeldman@chromium.org>
2794 Web Inspector: only allow evaluateForTestInFrontend for front-ends under test.
2795 https://bugs.webkit.org/show_bug.cgi?id=107523
2797 Reviewed by Yury Semikhatsky.
2799 * public/WebDevToolsFrontendClient.h:
2800 (WebKit::WebDevToolsFrontendClient::isUnderTest):
2801 (WebDevToolsFrontendClient):
2802 * src/InspectorFrontendClientImpl.cpp:
2803 (WebKit::InspectorFrontendClientImpl::isUnderTest):
2804 * src/InspectorFrontendClientImpl.h:
2805 (InspectorFrontendClientImpl):
2807 2013-01-22 Mark Lam <mark.lam@apple.com>
2809 Change the Supplementable class to not use AtomicString.
2810 https://bugs.webkit.org/show_bug.cgi?id=107535.
2812 Reviewed by Adam Barth.
2814 Replaced the use of AtomicString keys with literal const char* keys.
2815 This simplifies the SupplementMap and makes it slightly leaner and faster.
2817 * src/ContextFeaturesClientImpl.cpp:
2818 (ContextFeaturesCache):
2819 (WebKit::ContextFeaturesCache::supplementName):
2821 2013-01-22 Leandro Gracia Gil <leandrogracia@chromium.org>
2823 [Chromium] Expose didCommitCompositorFrame in WebWidgetClient.
2824 https://bugs.webkit.org/show_bug.cgi?id=107325
2826 Reviewed by James Robinson.
2828 Add a notification on WebWidgetClient called when the compositor commits a frame.
2830 * public/WebWidgetClient.h:
2832 (WebKit::WebWidgetClient::didCommitCompositorFrame):
2833 * src/WebViewImpl.cpp:
2834 (WebKit::WebViewImpl::didCommit):
2836 2013-01-21 Kentaro Hara <haraken@chromium.org>
2838 Implement UIEvent constructor
2839 https://bugs.webkit.org/show_bug.cgi?id=107430
2841 Reviewed by Adam Barth.
2843 Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
2845 UIEvent constructor is implemented under a DOM4_EVENTS_CONSTRUCTOR flag,
2846 which is enabled on Safari and Chromium for now.
2850 2013-01-22 Alpha Lam <hclam@chromium.org>
2852 REGRESSION(r140392): InjectIDBKeyTest.TopLevelPropertyStringValue is crashing
2853 https://bugs.webkit.org/show_bug.cgi?id=107578
2855 Unreviewed build fix. Disabled 2 tests that are crashing after r140392.
2857 * tests/IDBBindingUtilitiesTest.cpp:
2860 2013-01-22 Eric Seidel <eric@webkit.org>
2862 Turn on ENABLE_THREADED_HTML_PARSER for Chromium (it's still disabled at runtime)
2863 https://bugs.webkit.org/show_bug.cgi?id=107519
2865 Reviewed by Adam Barth.
2867 This makes our development lives easier, and makes it possible for the bots
2868 to run threaded-parser-only tests by toggling the runtime enable
2869 via window.internals.settings.
2873 2013-01-22 Kentaro Hara <haraken@chromium.org>
2875 [V8] Make an Isolate parameter mandatory in toV8()
2876 https://bugs.webkit.org/show_bug.cgi?id=107520
2878 Reviewed by Adam Barth.
2880 Now it's safe to remove an optional Isolate parameter.
2882 No tests. No change in behavior.
2884 * src/InspectorFrontendClientImpl.cpp:
2885 (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
2886 * src/WebArrayBuffer.cpp:
2887 (WebKit::WebArrayBuffer::toV8Value):
2889 (WebKit::WebBlob::toV8Value):
2890 * src/WebFrameImpl.cpp:
2891 (WebKit::WebFrameImpl::createFileSystem):
2892 (WebKit::WebFrameImpl::createSerializableFileSystem):
2893 (WebKit::WebFrameImpl::createFileEntry):
2895 2013-01-21 Sheriff Bot <webkit.review.bot@gmail.com>
2897 Unreviewed. Rolled Chromium DEPS to r177962. Requested by
2898 "Yoshifumi Inoue" <yosin@chromium.org> via sheriffbot.
2902 2013-01-21 Noel Gordon <noel.gordon@gmail.com>
2904 [chromium] REGRESSION(r139347) roll chromium deps broke webkit-unit-tests
2905 https://bugs.webkit.org/show_bug.cgi?id=106631
2907 Reviewed by Kent Tamura.
2909 Fixed in http://crrev.com/177931 and rolled. Renable these tests.
2911 * tests/WebImageTest.cpp:
2913 2013-01-21 Dirk Schulze <dschulze@adobe.com>
2915 Add build flag for Canvas's Path object (disabled by default)
2916 https://bugs.webkit.org/show_bug.cgi?id=107473
2918 Reviewed by Dean Jackson.
2920 Add CANVAS_PATH build flag to build systems.
2924 2013-01-21 Sheriff Bot <webkit.review.bot@gmail.com>
2926 Unreviewed. Rolled Chromium DEPS to r177956. Requested by
2927 thakis_ via sheriffbot.
2931 2013-01-21 Sheriff Bot <webkit.review.bot@gmail.com>
2933 Unreviewed. Rolled Chromium DEPS to r177953. Requested by
2934 thakis_ via sheriffbot.
2938 2013-01-21 Tommy Widenflycht <tommyw@google.com>
2940 MediaStream API: Update the RTCPeerConnection states to match the latest specification
2941 https://bugs.webkit.org/show_bug.cgi?id=107120
2943 Reviewed by Adam Barth.
2945 * src/AssertMatchingEnums.cpp:
2947 2013-01-20 Dominic Mazzoni <dmazzoni@google.com>
2949 Make SpeechSynthesis compile in the Chromium port
2950 https://bugs.webkit.org/show_bug.cgi?id=107382
2952 Reviewed by Adam Barth.
2954 Add ENABLE_SPEECH_SYNTHESIS to features.gypi, off by default.
2958 2013-01-20 Yoshifumi Inoue <yosin@chromium.org>
2960 Dragging over an element with scrollbars should scroll the element when dragging near edges
2961 https://bugs.webkit.org/show_bug.cgi?id=39725
2963 Reviewed by Hajime Morita.
2965 This patch removes DragScrollTimer used for automatic scrolling of main
2966 frame drag-and-drop which is now implemented in EventHandler.
2968 Another patch will remove DragScrollTimer.{cpp,h} and update GYP files to
2969 make patch size small.
2971 No tests. Existing test covers this change.
2973 * src/ChromeClientImpl.cpp:
2974 (WebKit::ChromeClientImpl::shouldAutoscrollForDragAndDrop): Added.
2975 * src/ChromeClientImpl.h:
2976 (ChromeClientImpl): Changed to add shouldAutoscrollForDragAndDrop().
2977 * src/WebViewImpl.cpp:
2978 (WebKit::WebViewImpl::WebViewImpl): Changed to remove m_dragScrollTimer.
2979 (WebKit::WebViewImpl::dragSourceEndedAt): ditto
2980 (WebKit::WebViewImpl::dragSourceMovedTo): ditto
2981 (WebKit::WebViewImpl::dragTargetDrop): ditto
2982 (WebKit::WebViewImpl::dragTargetDragEnterOrOver): ditto
2983 * src/WebViewImpl.h:
2984 (WebKit): Chagned to remove DragScrollTimer.
2986 2013-01-18 Alec Flett <alecflett@chromium.org>
2988 IndexedDB: Switch to new createTransaction call
2989 https://bugs.webkit.org/show_bug.cgi?id=107311
2991 Reviewed by Tony Chang.
2993 * public/WebIDBTransaction.h:
2995 Remove an old method that nobody calls.
2997 2013-01-18 Alpha Lam <hclam@chromium.org>
2999 [chromium] Roll Chromium DEPS to 177676
3001 Unreviewed DEPS roll.
3005 2013-01-18 Robert Kroeger <rjkroege@chromium.org>
3007 [chromium] Use new-style gesture scrolling events for fling and
3008 for plugin scrolling: https://bugs.webkit.org/show_bug.cgi?id=106589
3010 Reviewed by James Robinson.
3012 https://bugs.webkit.org/show_bug.cgi?id=103952 modified touchscreen
3013 scrolling to not use synthetic mouse wheel events. Update the fling facility
3014 in WebViewImpl to use these events for touchscreen-initiated flings. Also
3015 modify the WebPluginContainerImpl to scroll in response to touchscreen
3016 scroll gestures if the plugin does not itself implement gesture events.
3018 * src/WebPluginContainerImpl.cpp:
3019 * src/WebViewImpl.cpp:
3020 (WebKit::WebViewImpl::WebViewImpl):
3021 (WebKit::WebViewImpl::scrollBy): Handle fling callback conditionally based
3022 on initiating device. Touchpad flings generate wheels. Touchscreen flings
3024 (WebKit::WebViewImpl::handleGestureEvent):
3025 (WebKit::WebViewImpl::transferActiveWheelFlingAnimation):
3026 * src/WebViewImpl.h:
3028 2013-01-18 Seokju Kwon <seokju.kwon@gmail.com>
3030 Add explicit keyword to constructors in platform-specific InspectorClient
3031 https://bugs.webkit.org/show_bug.cgi?id=107255
3033 Reviewed by Kentaro Hara.
3035 Add explicit keyword to constructors that take one argument
3036 in platform-specific implementation of InspectorClient.
3038 * src/InspectorClientImpl.h:
3039 (InspectorClientImpl):
3041 2013-01-17 Dominic Cooney <dominicc@chromium.org>
3043 [Chromium] Unreviewed gardening.
3045 Roll Chromium to 177561.
3049 2013-01-17 Alpha Lam <hclam@chromium.org>
3051 [chromium] Disable a unit test
3052 https://bugs.webkit.org/show_bug.cgi?id=107206
3054 Unreviewed. Disable a failing test due to 140025.
3056 * tests/WebFrameTest.cpp:
3058 2013-01-17 Sheriff Bot <webkit.review.bot@gmail.com>
3060 Unreviewed, rolling out r140023.
3061 http://trac.webkit.org/changeset/140023
3062 https://bugs.webkit.org/show_bug.cgi?id=107176
3064 Broke some tests (Requested by anttik on #webkit).
3066 * tests/RenderTableCellTest.cpp:
3067 * tests/RenderTableRowTest.cpp:
3069 2013-01-17 John Mellor <johnme@chromium.org>
3071 [chromium] Double-tap zoom should take into account accessibility fontScaleFactor
3072 https://bugs.webkit.org/show_bug.cgi?id=107123
3074 Reviewed by Adam Barth.
3076 Platforms which support Text Autosizing (currently just Chrome for
3077 Android) may provide a textAutosizingFontScaleFactor (defaults to 1.0).
3079 This value is intended to be chosen by the user to indicate how large
3080 they want text to appear, for example Chrome for Android has a "Text
3081 scaling" slider in Settings > Accessibility that lets you choose a value
3082 in the range 50% - 200% (defaults to 100%*).
3084 For text in wide columns that typically gets autosized, this value is
3085 applied by multiplying the textAutosizingMultiplier computed for each
3086 cluster by the textAutosizingFontScaleFactor. Double-tap zoom will fit
3087 the column to the screen (ignoring the textAutosizingFontScaleFactor)
3088 since the column is wide. This part already works.
3090 For text in narrow columns that doesn't get autosized, the
3091 textAutosizingFontScaleFactor is not applied through Text Autosizing,
3092 and instead needs to be applied by adjusting the double-tap zoom level.
3093 When double-tapping on narrow columns, instead of fitting the column to
3094 the screen (which would often zoom in excessively far), the existing
3095 logic in computeScaleAndScrollForHitRect applies a maximum zoom level
3096 called the legibleScale. This value needs to be multiplied by the
3097 textAutosizingFontScaleFactor, so that we zoom in proportionately
3098 further on non-autosized narrow columns, hence the effective text size
3099 (taking into account zoom) will have increased in proportion to the
3100 textAutosizingFontScaleFactor as expected.
3102 * src/WebViewImpl.cpp:
3103 (WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
3104 Multiplies legibleScale (the maximum zoom level) by the
3105 textAutosizingFontScaleFactor.
3106 * tests/WebFrameTest.cpp:
3107 Added WebFrameTest.DivAutoZoomScaleFontScaleFactorTest based on
3108 WebFrameTest.DivAutoZoomScaleBoundsTest to test the interaction
3109 between textAutosizingFontScaleFactor and the double-tap zoom logic.
3110 Also did minor cleanup to WebFrameTest.DivAutoZoomScaleBoundsTest.
3112 2013-01-17 Alexandre Elias <aelias@chromium.org>
3114 [chromium] Make new-style page scale work with fixed layout
3115 https://bugs.webkit.org/show_bug.cgi?id=106951
3117 Reviewed by Adam Barth.
3119 This makes non-CSS-transform page scaling work with fixed-layout mode,
3120 including viewport tag support.
3122 - dispatchViewportPropertiesDidChange() now works entirely with DIP
3123 pixels instead of physical pixels, and is made compatible with
3124 separating deviceScaleFactor from pageScaleFactor.
3126 - In this mode, the "layout viewport" size in the pinch-zoom model is
3127 made a first-class concept separate from the device size. This
3128 is a viewport with the same aspect ratio as the device but with the
3129 layout width of the page. This viewport is used:
3130 - As FrameView::visibleContentRect.
3131 - Returned from WebView::size().
3132 - Given to the compositor as layoutViewportSize.
3134 - m_deviceScaleInCompositor is deleted as it's clearer to use the
3135 applyDeviceScaleInCompositor setting directly.
3137 * src/ChromeClientImpl.cpp:
3138 (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
3139 * src/WebViewImpl.cpp:
3140 (WebKit::WebViewImpl::WebViewImpl):
3141 (WebKit::WebViewImpl::size):
3143 (WebKit::WebViewImpl::resize):
3144 (WebKit::WebViewImpl::setPageScaleFactor):
3145 (WebKit::WebViewImpl::setDeviceScaleFactor):
3146 (WebKit::WebViewImpl::layoutSize):
3147 (WebKit::WebViewImpl::computePageScaleFactorLimits):
3148 (WebKit::WebViewImpl::dipSize):
3149 (WebKit::WebViewImpl::didChangeContentsSize):
3150 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
3151 (WebKit::WebViewImpl::updateLayerTreeViewport):
3152 * src/WebViewImpl.h:
3155 2013-01-17 Sheriff Bot <webkit.review.bot@gmail.com>
3157 Unreviewed. Rolled Chromium DEPS to r177369. Requested by
3158 ajuma via sheriffbot.
3162 2013-01-17 Eugene Klyuchnikov <eustas@chromium.org>
3164 Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
3165 https://bugs.webkit.org/show_bug.cgi?id=104545
3167 Reviewed by Yury Semikhatsky.
3169 Adopt changes: mimic old behavior.
3171 * src/WebDevToolsAgentImpl.cpp: Adopt signature changes.
3173 2013-01-17 Yury Semikhatsky <yurys@chromium.org>
3175 Web Inspector: add WebDeToolsAgentImpl as task observer on reattach
3176 https://bugs.webkit.org/show_bug.cgi?id=107106
3178 Reviewed by Pavel Feldman.
3180 Register WebDevToolsAgentImpl as task observer when it client is reattached.
3182 * src/WebDevToolsAgentImpl.cpp:
3183 (WebKit::WebDevToolsAgentImpl::reattach):
3185 2013-01-16 Dominic Cooney <dominicc@chromium.org>
3187 [Chromium] Unreviewed gardening.
3189 Roll Chromium to 177350.
3193 2013-01-16 Kristian Monsen <kristianm@google.com>
3195 Fix build break for Android webview.
3196 https://bugs.webkit.org/show_bug.cgi?id=107072
3198 Reviewed by Steve Block.
3200 Add extra guards when checking for OS=="Android" to make sure it is not included
3203 * WebKitUnitTests.gyp:
3205 2013-01-16 Dominic Cooney <dominicc@chromium.org>
3207 [Chromium] Unreviewed gardening.
3209 Roll Chromium to 177310.
3213 2013-01-16 W. James MacLean <wjmaclean@chromium.org>
3215 LinkHighlight should use touch adjustment to match active state on GestureTapDown.
3216 https://bugs.webkit.org/show_bug.cgi?id=107032
3218 Reviewed by Adam Barth.
3220 LinkHighlight node selection should produce results that match the node marked
3221 active during GestureTapDown.
3223 * src/WebViewImpl.cpp:
3224 (WebKit::WebViewImpl::bestTouchLinkNode):
3225 * tests/LinkHighlightTest.cpp:
3228 2013-01-16 Kentaro Hara <haraken@chromium.org>
3230 [V8] Make a creationContext parameter of toV8() mandatory
3231 https://bugs.webkit.org/show_bug.cgi?id=107020
3233 Reviewed by Adam Barth.
3235 We pass Handle<Object>() to a creationContext parameter of
3236 toV8() when we do not have a creationContext.
3238 No tests. No change in behavior.
3240 * src/InspectorFrontendClientImpl.cpp:
3241 (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
3242 * src/WebArrayBuffer.cpp:
3243 (WebKit::WebArrayBuffer::toV8Value):
3245 (WebKit::WebBlob::toV8Value):
3246 * src/WebFrameImpl.cpp:
3247 (WebKit::WebFrameImpl::createFileSystem):
3248 (WebKit::WebFrameImpl::createSerializableFileSystem):
3249 (WebKit::WebFrameImpl::createFileEntry):
3251 2013-01-16 Mark Pilgrim <pilgrim@chromium.org>
3253 [Chromium] Move WebArrayBufferView and WebSerializedScriptValue out of public/platform/
3254 https://bugs.webkit.org/show_bug.cgi?id=106863
3256 Reviewed by Adam Barth.
3258 These are not being moved into the new top-level Platform
3259 directory, so into public they go.
3262 * public/WebArrayBufferView.h: Added.
3265 (WebArrayBufferView):
3266 (WebKit::WebArrayBufferView::~WebArrayBufferView):
3267 (WebKit::WebArrayBufferView::WebArrayBufferView):
3268 * public/WebSerializedScriptValue.h: Added.
3271 (WebSerializedScriptValue):
3272 (WebKit::WebSerializedScriptValue::~WebSerializedScriptValue):
3273 (WebKit::WebSerializedScriptValue::WebSerializedScriptValue):
3274 (WebKit::WebSerializedScriptValue::operator=):
3275 (WebKit::WebSerializedScriptValue::isNull):
3276 * public/platform/WebArrayBufferView.h:
3277 * public/platform/WebSerializedScriptValue.h:
3279 2013-01-16 Chris Hopman <cjhopman@chromium.org>
3281 [Chromium] Remove hardcoded chromium_*.jar in gyp files
3282 https://bugs.webkit.org/show_bug.cgi?id=104049
3284 Reviewed by Eric Seidel.
3286 Targets with dependencies (direct/indirect) on a java target receive
3287 the chromium_*.jar paths in the variable input_jars_paths. Targets
3288 should use that rather than hardcoding where they think the jar will
3289 be. These can be passed directly to ant as INPUT_JARS_PATHS rather
3290 than as --jars to generate_native_test.py.
3292 * WebKitUnitTests.gyp:
3294 2013-01-16 Dominic Cooney <dominicc@chromium.org>
3296 [Chromium] Unreviewed gardening.
3298 Roll Chromium to 177117.
3302 2013-01-16 Dominic Cooney <dominicc@chromium.org>
3304 [Chromium] Unreviewed gardening.
3306 Roll Chromium to r177080.
3310 2013-01-15 Ian Vollick <vollick@chromium.org>
3312 [chromium] Create GraphicsLayerChromiums using a factory
3313 https://bugs.webkit.org/show_bug.cgi?id=103635
3315 Reviewed by James Robinson.
3317 Refactor graphics layer creation for chromium to go through a factory.
3319 * src/ChromeClientImpl.cpp:
3321 (GraphicsLayerFactoryChromium):
3322 (WebCore::GraphicsLayerFactoryChromium::~GraphicsLayerFactoryChromium):
3323 (WebKit::ChromeClientImpl::ChromeClientImpl):
3324 (WebKit::ChromeClientImpl::graphicsLayerFactory):
3326 * src/ChromeClientImpl.h:
3329 * src/NonCompositedContentHost.cpp:
3330 (WebKit::NonCompositedContentHost::NonCompositedContentHost):
3331 * src/NonCompositedContentHost.h:
3333 (WebKit::NonCompositedContentHost::create):
3334 (NonCompositedContentHost):
3335 * src/PageOverlay.cpp:
3336 (WebKit::PageOverlay::update):
3337 * src/WebViewImpl.cpp:
3338 (WebKit::WebViewImpl::graphicsLayerFactory):
3340 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
3341 * src/WebViewImpl.h:
3344 * tests/GraphicsLayerChromiumTest.cpp:
3345 (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
3346 * tests/ImageLayerChromiumTest.cpp:
3349 2013-01-15 Mark Pilgrim <pilgrim@chromium.org>
3351 [Chromium] Move SocketStreamHandle and SocketStreamHandleInternal to WebCore/platform
3352 https://bugs.webkit.org/show_bug.cgi?id=106899
3354 Reviewed by Adam Barth.
3356 Part of a larger refactoring series; see tracking bug 106829.
3359 * src/SocketStreamHandle.cpp: Removed.
3360 * src/SocketStreamHandleInternal.h: Removed.
3362 2013-01-15 Florin Malita <fmalita@chromium.org>
3364 [Chromium] Incorrect opaque region tracking for PlatformContextSkia::drawRRect
3365 https://bugs.webkit.org/show_bug.cgi?id=106898
3367 Reviewed by Stephen White.
3369 * tests/PlatformContextSkiaTest.cpp:
3373 2012-12-28 Vsevolod Vlasov <vsevik@chromium.org>
3375 Web Inspector: Support inspector file system access with isolated file system through InspectorFrontendHost.
3376 https://bugs.webkit.org/show_bug.cgi?id=105727
3378 Reviewed by Pavel Feldman.
3380 File system access methods plumbing made for Chromium.
3382 * public/WebDevToolsFrontendClient.h:
3383 (WebKit::WebDevToolsFrontendClient::requestFileSystems):
3384 (WebKit::WebDevToolsFrontendClient::addFileSystem):
3385 (WebKit::WebDevToolsFrontendClient::removeFileSystem):
3386 (WebDevToolsFrontendClient):
3387 * src/InspectorFrontendClientImpl.cpp:
3388 (WebKit::InspectorFrontendClientImpl::supportsFileSystems):
3390 (WebKit::InspectorFrontendClientImpl::requestFileSystems):
3391 (WebKit::InspectorFrontendClientImpl::addFileSystem):
3392 (WebKit::InspectorFrontendClientImpl::removeFileSystem):
3393 * src/InspectorFrontendClientImpl.h:
3394 (InspectorFrontendClientImpl):
3396 2013-01-14 Dominic Cooney <dominicc@chromium.org>
3398 [Chromium] Unreviewed gardening.
3400 Roll Chromium to r176801.
3402 * DEPS: Rollin' on the river.
3404 2013-01-14 Mark Pilgrim <pilgrim@chromium.org>
3406 [Chromium] Remove unused public/platform/WebColorName.h
3407 https://bugs.webkit.org/show_bug.cgi?id=106865
3409 Reviewed by Adam Barth.
3411 This file is no longer referenced anywhere in WebKit or Chromium.
3413 * public/platform/WebColorName.h: Removed.
3415 2013-01-14 Mark Pilgrim <pilgrim@chromium.org>
3417 [Chromium] Move BlobRegistryProxy into WebCore
3418 https://bugs.webkit.org/show_bug.cgi?id=106831
3420 Reviewed by Adam Barth.
3422 Part of a larger refactoring series to remove layering violations
3423 in Chromium. See tracking bug 106829.
3426 * src/BlobRegistryProxy.cpp: Removed.
3427 * src/BlobRegistryProxy.h: Removed.
3429 2013-01-14 Alec Flett <alecflett@chromium.org>
3431 IndexedDB: Remove IDBObjectStore/IndexBackendImpl and support functions
3432 https://bugs.webkit.org/show_bug.cgi?id=106605
3434 Remove all references to IDBObjectStoreBackend* and IDBIndexBackend*
3435 as they no longer exist in WebCore.
3437 Reviewed by Darin Fisher.
3440 * public/WebIDBCallbacks.h:
3442 * public/WebIDBDatabase.h:
3444 (WebKit::WebIDBDatabase::metadata):
3445 * public/WebIDBFactory.h:
3447 * public/WebIDBIndex.h: Removed.
3448 * public/WebIDBObjectStore.h: Removed.
3449 * public/WebIDBTransaction.h:
3450 * src/IDBCallbacksProxy.cpp:
3451 * src/IDBDatabaseBackendProxy.cpp:
3452 * src/IDBDatabaseBackendProxy.h:
3453 (IDBDatabaseBackendProxy):
3454 * src/IDBFactoryBackendProxy.cpp:
3455 * src/IDBFactoryBackendProxy.h:
3456 (IDBFactoryBackendProxy):
3457 * src/IDBIndexBackendProxy.cpp: Removed.
3458 * src/IDBIndexBackendProxy.h: Removed.
3459 * src/IDBObjectStoreBackendProxy.cpp: Removed.
3460 * src/IDBObjectStoreBackendProxy.h: Removed.
3461 * src/IDBTransactionBackendProxy.cpp:
3462 * src/IDBTransactionBackendProxy.h:
3463 (IDBTransactionBackendProxy):
3464 * src/WebIDBDatabaseImpl.cpp:
3465 (WebKit::WebIDBDatabaseImpl::put):
3466 (WebKit::WebIDBDatabaseImpl::setIndexKeys):
3467 * src/WebIDBDatabaseImpl.h:
3469 (WebIDBDatabaseImpl):
3470 * src/WebIDBFactoryImpl.cpp:
3471 (WebKit::WebIDBFactoryImpl::getDatabaseNames):
3472 * src/WebIDBFactoryImpl.h:
3473 (WebIDBFactoryImpl):
3474 * src/WebIDBIndexImpl.cpp: Removed.
3475 * src/WebIDBIndexImpl.h: Removed.
3476 * src/WebIDBObjectStoreImpl.cpp: Removed.
3477 * src/WebIDBObjectStoreImpl.h: Removed.
3478 * src/WebIDBTransactionImpl.cpp:
3479 * src/WebIDBTransactionImpl.h:
3480 * tests/IDBAbortOnCorruptTest.cpp:
3482 * tests/IDBDatabaseBackendTest.cpp:
3484 2013-01-14 Dominic Mazzoni <dmazzoni@google.com>
3486 AX: Need to implement ColorWellRole
3487 https://bugs.webkit.org/show_bug.cgi?id=106756
3489 Reviewed by Chris Fleizach.
3491 Adds an accessibility interface to access the value of a
3494 * public/WebAccessibilityObject.h:
3495 (WebAccessibilityObject):
3496 * src/WebAccessibilityObject.cpp:
3497 (WebKit::WebAccessibilityObject::colorValue):
3500 2013-01-14 Mark Pilgrim <pilgrim@chromium.org>