1 2012-05-22 Daniel Sievers <sievers@chromium.org>
3 [Chromium] Fix tests being flaky when multiple draws occur in between commits
4 https://bugs.webkit.org/show_bug.cgi?id=83935
6 Tests that are verifying events in a commit/draw lock-step pattern, should use
7 sourceFrameNumber() not frameNumber() on the impl side.
8 Otherwise they will fail if the same frame is drawn more than once in
9 between commits (which is perfectly legal and could happen for example
10 because we draw without a new commit because we are still in BEGIN_FRAME
11 or updating resources).
13 Reviewed by Adrienne Walker.
15 * tests/CCLayerTreeHostTest.cpp:
16 (WTF::CCLayerTreeHostTestScrollSimple::drawLayersOnCCThread):
17 (WTF::CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread):
18 (WTF::CCLayerTreeHostTestStartPageScaleAnimation::commitCompleteOnCCThread):
19 (WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
20 (WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread):
21 (WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
22 (WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread):
23 (WTF::CCLayerTreeHostTestFractionalScroll::drawLayersOnCCThread):
25 2012-05-22 Ian Vollick <vollick@chromium.org>
27 [chromium] Move asserts in CCLayerTreeHostTest::dispatch*
28 https://bugs.webkit.org/show_bug.cgi?id=87134
30 Reviewed by Adrienne Walker.
32 * tests/CCLayerTreeHostTest.cpp:
33 (WTF::CCLayerTreeHostTest::dispatchSetNeedsAnimate):
34 (WTF::CCLayerTreeHostTest::dispatchAddInstantAnimation):
35 (WTF::CCLayerTreeHostTest::dispatchAddAnimation):
36 (WTF::CCLayerTreeHostTest::dispatchSetNeedsAnimateAndCommit):
37 (WTF::CCLayerTreeHostTest::dispatchSetNeedsCommit):
38 (WTF::CCLayerTreeHostTest::dispatchAcquireLayerTextures):
39 (WTF::CCLayerTreeHostTest::dispatchSetNeedsRedraw):
40 (WTF::CCLayerTreeHostTest::dispatchSetVisible):
41 (WTF::CCLayerTreeHostTest::dispatchSetInvisible):
43 2012-05-22 Dana Jansens <danakj@chromium.org>
45 [chromium] Expand damage from the background-blurred layer to ensure readback is only including pixels below that layer
46 https://bugs.webkit.org/show_bug.cgi?id=86884
48 Reviewed by Adrienne Walker.
50 * tests/CCDamageTrackerTest.cpp:
51 (WebKitTests::TEST_F):
53 2012-05-22 David Grogan <dgrogan@chromium.org>
55 IndexedDB: Fire error when there are problems opening a DB
56 https://bugs.webkit.org/show_bug.cgi?id=85579
58 Reviewed by Tony Chang.
61 * tests/IDBAbortOnCorruptTest.cpp: Added.
64 (WebCore::MockIDBCallbacks::MockIDBCallbacks):
65 (WebCore::MockIDBCallbacks::~MockIDBCallbacks):
66 (WebCore::MockIDBCallbacks::onError):
67 (WebCore::MockIDBCallbacks::onSuccess):
68 (WebCore::MockIDBCallbacks::onSuccessWithContinuation):
69 (WebCore::MockIDBCallbacks::onSuccessWithPrefetch):
70 (WebCore::MockIDBCallbacks::onBlocked):
71 (FailingBackingStore):
72 (WebCore::FailingBackingStore::~FailingBackingStore):
73 (WebCore::FailingBackingStore::open):
74 (WebCore::FailingBackingStore::createIDBDatabaseMetaData):
75 (FailingIDBFactoryBackendImpl):
76 (WebCore::FailingIDBFactoryBackendImpl::~FailingIDBFactoryBackendImpl):
77 (WebCore::FailingIDBFactoryBackendImpl::create):
78 (WebCore::FailingIDBFactoryBackendImpl::removeIDBDatabaseBackend):
79 (WebCore::FailingIDBFactoryBackendImpl::openBackingStore):
81 * tests/IDBFakeBackingStore.h: Copied from Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h.
83 (IDBFakeBackingStore):
85 2012-05-22 Alexander Pavlov <apavlov@chromium.org>
87 [Chromium] Implement the ContextMenuItem SubMenu type
88 https://bugs.webkit.org/show_bug.cgi?id=86625
90 Reviewed by Pavel Feldman.
92 * public/WebMenuItemInfo.h:
93 (WebMenuItemInfo): Add the SubMenu type and a vector of subMenuItems.
94 * src/ContextMenuClientImpl.cpp:
95 (WebKit::populateSubMenuItems): A recursive implementation that populates submenu items as well as other item types.
97 (WebKit::ContextMenuClientImpl::populateCustomMenuItems): Consider submenus when populating WebMenuItemInfos.
99 2012-05-22 Ian Vollick <vollick@chromium.org>
101 [chromium] Speed up CCLayerTreeHostTestTickAnimationWhileBackgrounded
102 https://bugs.webkit.org/show_bug.cgi?id=86871
104 Reviewed by James Robinson.
106 Use a shorter time interval for background animation ticking so that
107 unit tests can run faster.
109 * tests/CCLayerTreeHostTest.cpp:
110 (WTF::MockLayerTreeHostImpl::lowFrequencyAnimationInterval):
111 (MockLayerTreeHostImpl):
113 2012-05-21 Alexandre Elias <aelias@google.com>
115 [chromium] Simplify RTL root layer adjustment
116 https://bugs.webkit.org/show_bug.cgi?id=85672
118 Reviewed by Adrienne Walker.
120 The compositor needs a translation to compensate for a nonzero
121 scrollOrigin to avoid painting at negative coordinates on RTL pages.
122 Previously, we were recomputing it from first principles; this change
123 directly reads it off the actual scrollOrigin.
125 * src/WebViewImpl.cpp:
126 (WebKit::WebViewImpl::updateLayerTreeViewport):
130 2012-05-21 James Robinson <jamesr@chromium.org>
132 Chromium compile fix, unreviewed.
134 Fixed is defined in WebCore and is a typedef in the OS X 10.5 SDK headers, so it needs an explicit WebCore::
135 prefix to be unambiguous on mac.
137 * tests/FilterOperationsTest.cpp:
140 2012-05-21 James Robinson <jamesr@chromium.org>
142 [chromium] Port chromium compositor to use WebFilterOperation(s)
143 https://bugs.webkit.org/show_bug.cgi?id=87046
145 Reviewed by Adrienne Walker.
148 * src/AssertMatchingEnums.cpp:
150 (WebKit::WebLayer::setFilters):
151 (WebKit::WebLayer::setBackgroundFilters):
152 * tests/CCDamageTrackerTest.cpp:
153 (WebKitTests::TEST_F):
154 * tests/CCLayerImplTest.cpp:
156 * tests/CCLayerTreeHostTest.cpp:
157 (WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
158 * tests/CCOcclusionTrackerTest.cpp:
159 (WebKitTests::CCOcclusionTrackerTest::createSurface):
160 (WebKitTests::CCOcclusionTrackerTest::createDrawingSurface):
161 (WebKitTests::CCOcclusionTrackerTestFilters::runMyTest):
162 (WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter::runMyTest):
163 (WebKitTests::CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice::runMyTest):
164 (WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilterWithClip::runMyTest):
165 (WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionBelowBackgroundFilter::runMyTest):
166 (WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionIfBackgroundFilterIsOccluded::runMyTest):
167 (WebKitTests::CCOcclusionTrackerTestReduceOcclusionWhenBackgroundFilterIsPartiallyOccluded::runMyTest):
168 * tests/FilterOperationsTest.cpp: Added.
169 Tests the existing behavior of WebCore::FilterOperations::getOutsets and makes sure WebFilterOperations'
173 * tests/GraphicsLayerChromiumTest.cpp:
175 2012-05-21 Joshua Bell <jsbell@chromium.org>
177 IndexedDB: Store key paths in IDBKeyPath type instead of String
178 https://bugs.webkit.org/show_bug.cgi?id=85298
180 Reviewed by Tony Chang, Kentaro Hara and James Robinson.
182 No functional changes, just finish migration from String to IDBKeyPath
183 for storing key paths, for eventual array support http://webkit.org/b/84207
185 * public/WebIDBDatabase.h: Remove temporary overload.
187 (WebKit::WebIDBDatabase::objectStoreNames):
188 * public/WebIDBIndex.h: Remove temporary method.
189 (WebKit::WebIDBIndex::keyPath):
190 * public/WebIDBKeyPath.h: Remove obsolete methods, wrap WebCore::IDBKeyPath
192 (WebKit::WebIDBKeyPath::WebIDBKeyPath):
193 * public/WebIDBObjectStore.h: Remove temporary method and overload.
194 (WebKit::WebIDBObjectStore::keyPath):
195 * public/platform/WebKitPlatformSupport.h: Remove temporary overloads.
197 * src/AssertMatchingEnums.cpp: WebIDBKeyPath vs. IDBKeyPath enums.
198 * src/IDBDatabaseBackendProxy.cpp: Switch from String to IDBKeyPath.
199 (WebKit::IDBDatabaseBackendProxy::createObjectStore):
200 * src/IDBDatabaseBackendProxy.h: Switch from String to IDBKeyPath.
201 (IDBDatabaseBackendProxy):
202 * src/IDBIndexBackendProxy.cpp: Switch from String to IDBKeyPath.
203 (WebKit::IDBIndexBackendProxy::keyPath):
204 * src/IDBIndexBackendProxy.h: Switch from String to IDBKeyPath.
205 (IDBIndexBackendProxy):
206 * src/IDBObjectStoreBackendProxy.cpp: Switch from String to IDBKeyPath.
207 (WebKit::IDBObjectStoreBackendProxy::keyPath):
208 (WebKit::IDBObjectStoreBackendProxy::createIndex):
209 * src/IDBObjectStoreBackendProxy.h: Switch from String to IDBKeyPath.
210 (IDBObjectStoreBackendProxy):
211 * src/PlatformSupport.cpp: Switch from String to IDBKeyPath.
212 (WebCore::PlatformSupport::createIDBKeysFromSerializedValuesAndKeyPath):
213 (WebCore::PlatformSupport::injectIDBKeyIntoSerializedValue):
214 * src/WebIDBDatabaseImpl.cpp: Switch from String to IDBKeyPath.
215 (WebKit::WebIDBDatabaseImpl::createObjectStore):
216 * src/WebIDBDatabaseImpl.h: Remove temporary overload.
217 (WebIDBDatabaseImpl):
218 * src/WebIDBIndexImpl.cpp: Remove temporary method.
219 * src/WebIDBIndexImpl.h: Remove temporary method.
221 * src/WebIDBKeyPath.cpp: Remove most logic; just a wrapper for WebCore::IDBKeyPath.
222 (WebKit::WebIDBKeyPath::~WebIDBKeyPath):
223 (WebKit::WebIDBKeyPath::create):
224 (WebKit::WebIDBKeyPath::createNull):
225 (WebKit::WebIDBKeyPath::isValid):
226 (WebKit::WebIDBKeyPath::type):
228 (WebKit::WebIDBKeyPath::array):
229 (WebKit::WebIDBKeyPath::string):
230 (WebKit::WebIDBKeyPath::WebIDBKeyPath):
231 (WebKit::WebIDBKeyPath::operator=):
232 (WebKit::WebIDBKeyPath::operator const WebCore::IDBKeyPath&):
233 * src/WebIDBObjectStoreImpl.cpp: Remove temporary method and overload.
234 (WebKit::WebIDBObjectStoreImpl::keyPath):
235 (WebKit::WebIDBObjectStoreImpl::createIndex):
236 * src/WebIDBObjectStoreImpl.h: Remove temporary method and overload.
237 (WebIDBObjectStoreImpl):
238 * tests/IDBBindingUtilitiesTest.cpp: Use IDBKeyPath.
239 (WebCore::checkKeyFromValueAndKeyPathInternal):
240 (WebCore::injectKey):
241 * tests/IDBLevelDBCodingTest.cpp: Added EncodeIDBKeyPath and DecodeIDBKeyPath tests.
242 (IDBLevelDBCoding::TEST):
244 * tests/IDBKeyPathTest.cpp:
245 (WebCore::checkKeyPath): Test IDBKeyPath validity.
247 2012-05-18 Michael Nordman <michaeln@google.com>
249 [chromium] DomStorage events handling needs TLC (2)
250 https://bugs.webkit.org/show_bug.cgi?id=85221
251 Alter the WebStorageArea virtual interface such that the mutators no longer
252 return old values. This is to allow implementations of the interface to operate
255 Also clean up from a previous patch, remove support for the DEPRECATED event
258 Reviewed by Adam Barth.
260 * WebKit.gyp: delete three files indicated below
261 * public/WebStorageArea.h:
262 (WebKit::WebStorageArea::setItem): no longer returns the old value
263 (WebKit::WebStorageArea::removeItem): no longer returns the old value
264 (WebKit::WebStorageArea::clear): no longer returns a bool indicated if something was cleared
265 * public/WebStorageEventDispatcher.h: removed the DEPRECATED instance methods
266 * public/WebStorageNamespace.h: removed the DEPRECATED close() method
267 * public/platform/WebKitPlatformSupport.h: removed the DEPRECATED dispatchStorageEvent() method
268 * src/StorageAreaProxy.cpp: removed the DEPREACTED storageEvent() method
269 (WebCore::StorageAreaProxy::setItem): no return value
270 (WebCore::StorageAreaProxy::removeItem): no return value
271 (WebCore::StorageAreaProxy::clear): no return value
272 (WebCore::StorageAreaProxy::dispatchLocalStorageEvent): remove an early return thats no longer needed
273 (WebCore::findPageWithSessionStorageNamespace): switched to passing pageGroup by ptr value instead of by name
274 (WebCore::StorageAreaProxy::dispatchSessionStorageEvent): remove an early return thats no longer needed
275 * src/StorageAreaProxy.h:
278 * src/StorageEventDispatcherImpl.cpp: Deleted the file.
279 * src/StorageEventDispatcherImpl.h: Deleted the file.
280 * src/WebStorageEventDispatcherImpl.cpp: Deleted the DEPRECATED instance methods.
281 (WebKit::WebStorageEventDispatcher::dispatchLocalStorageEvent): use WebViewImpl::defaultPageGroup
282 (WebKit::WebStorageEventDispatcher::dispatchSessionStorageEvent): use WebViewImpl::defaultPageGroup
283 * src/WebStorageEventDispatcherImpl.h: Deleted the file.
284 * src/WebViewImpl.cpp: added a static method to retrieve a ptr to the default page group,
285 (WebKit::WebViewImpl::defaultPageGroup):
288 2012-05-21 Greg Billock <gbillock@google.com>
290 Add suggestions field to web intents API.
291 https://bugs.webkit.org/show_bug.cgi?id=86791
293 Reviewed by Adam Barth.
295 * public/WebIntent.h:
298 (WebKit::WebIntent::suggestions):
301 2012-05-20 Kinuko Yasuda <kinuko@chromium.org>
303 Cleanup: Remove WebCore::revealFolderInOS() which is no longer used anywhere
304 https://bugs.webkit.org/show_bug.cgi?id=86993
306 Reviewed by Adam Barth.
308 * public/WebFileUtilities.h:
310 * src/PlatformSupport.cpp:
312 2012-05-21 Adam Barth <abarth@webkit.org>
314 [Chromium] Implement WebViewImpl::textInputInfo() for Android
315 https://bugs.webkit.org/show_bug.cgi?id=86440
317 Reviewed by Darin Fisher.
319 This patch adds WebView::textInputInfo(), which describes the text
320 input that currently has focus. Android is planning to use this to
321 determine what sort of keyboard or text entry UI to show. This API
322 subsumes the textInputType() API, which will be removed once the
323 clients have been updated.
326 * public/WebTextInputInfo.h: Added.
329 (WebKit::WebTextInputInfo::WebTextInputInfo):
330 (WebKit::operator==):
331 (WebKit::operator!=):
332 * public/WebTextInputType.h:
333 * public/WebWidget.h:
335 (WebKit::WebWidget::textInputInfo):
336 (WebKit::WebWidget::textInputType):
337 * src/WebViewImpl.cpp:
338 (WebKit::WebViewImpl::textInputInfo):
340 (WebKit::WebViewImpl::textInputType):
344 2012-05-21 Sheriff Bot <webkit.review.bot@gmail.com>
346 Unreviewed. Rolled DEPS.
350 2012-05-20 Joshua Bell <jsbell@chromium.org>
352 IndexedDB: Delete obsolete Chromium WebKit API method
353 https://bugs.webkit.org/show_bug.cgi?id=86933
355 Implementation was previously removed in r17512 and callers are updated.
357 Reviewed by Adam Barth.
359 * public/WebIDBIndex.h: Delete storeName()
360 (WebKit::WebIDBIndex::name):
362 2012-05-19 Sheriff Bot <webkit.review.bot@gmail.com>
364 Unreviewed, rolling out r117675.
365 http://trac.webkit.org/changeset/117675
366 https://bugs.webkit.org/show_bug.cgi?id=86938
368 Broke builds. You can't initialize members by members
369 themselves (Requested by rniwa on #webkit).
373 * public/WebPlugin.h:
375 (WebKit::WebPlugin::printBegin):
376 * public/WebPrintParams.h:
377 * src/WebFrameImpl.cpp:
379 (WebKit::WebFrameImpl::printBegin):
380 * src/WebFrameImpl.h:
382 * src/WebPluginContainerImpl.cpp:
383 (WebKit::WebPluginContainerImpl::printBegin):
385 2012-05-18 Jochen Eisinger <jochen@chromium.org>
387 [chromium] remove obsolete WebViewClient::startDragging version
388 https://bugs.webkit.org/show_bug.cgi?id=86887
390 Reviewed by Adam Barth.
392 * public/WebViewClient.h:
393 (WebKit::WebViewClient::startDragging):
395 2012-05-18 Kausalya Madhusudhanan <kmadhusu@chromium.org>
397 [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
398 https://bugs.webkit.org/show_bug.cgi?id=86684
400 Reviewed by Darin Fisher.
404 * public/WebPlugin.h:
406 * public/WebPrintParams.h:
407 (WebKit::WebPrintParams::WebPrintParams):
409 * src/WebFrameImpl.cpp:
411 * src/WebFrameImpl.h:
413 * src/WebPluginContainerImpl.cpp:
414 (WebKit::WebPluginContainerImpl::printBegin):
416 2012-05-18 Ryosuke Niwa <rniwa@webkit.org>
418 Roll Chromium DEPS from r136942 to r137976.
422 2012-05-18 Aaron Colwell <acolwell@chromium.org>
424 Update Media Source implementation to reflect changes in 0.5 spec.
425 https://bugs.webkit.org/show_bug.cgi?id=83607
427 Reviewed by Darin Fisher.
429 * public/WebMediaPlayer.h:
430 (WebKit::WebMediaPlayer::sourceAddId): Update the signature to take the parsed type and codecs vector.
431 (WebKit::WebMediaPlayer::sourceBuffered): Add default implementation for new method.
432 (WebKit::WebMediaPlayer::sourceAppend): Update signature to include id parameter.
433 (WebKit::WebMediaPlayer::sourceAbort): Add default implementation for new method.
434 * src/WebMediaPlayerClientImpl.cpp:
435 (WebKit::WebMediaPlayerClientImpl::sourceAddId): Update the signature to take the parsed type and codecs vector.
436 (WebKit::WebMediaPlayerClientImpl::sourceBuffered): Added implementation for new method. Converts WebKit::WebTimeRanges to WebCore::TimeRanges.
438 (WebKit::WebMediaPlayerClientImpl::sourceAppend): Update signature to include id parameter.
439 (WebKit::WebMediaPlayerClientImpl::sourceAbort): Implementation for new method.
440 * src/WebMediaPlayerClientImpl.h:
441 (WebMediaPlayerClientImpl): Added declarations for new methods and updated signatures for existing ones.
443 2012-05-18 Shawn Singh <shawnsingh@chromium.org>
445 [chromium] add back-face visibility check for renderSurfaces
446 https://bugs.webkit.org/show_bug.cgi?id=86870
448 Reviewed by Adrienne Walker.
450 * tests/CCLayerTreeHostCommonTest.cpp:
454 2012-05-18 Greg Billock <gbillock@google.com>
456 Enable web intents flag for chromium build
457 https://bugs.webkit.org/show_bug.cgi?id=86762
459 Reviewed by Adam Barth.
461 This flag is enabled in the Chromium-side build.
465 2012-05-18 Tony Chang <tony@chromium.org>
467 remove the CSS_GRID_LAYOUT compiler define, but default grid layout to off
468 https://bugs.webkit.org/show_bug.cgi?id=86767
470 Reviewed by Ojan Vafai.
472 * public/WebSettings.h:
473 * src/WebSettingsImpl.cpp:
474 (WebKit::WebSettingsImpl::setExperimentalCSSGridLayoutEnabled):
476 * src/WebSettingsImpl.h:
479 2012-05-18 Ian Vollick <vollick@chromium.org>
481 [chromium] Multithreaded compositor unit tests intermittently failing
482 https://bugs.webkit.org/show_bug.cgi?id=74623
484 Reviewed by Adrienne Walker.
486 The flakiness of the CCLayerTreeHost tests stem from processing tasks after the
487 tests finish. To fix this, I've disabled the dispatch* methods after endTest is
488 called, effectively preventing any further tasks scheduled by the tests from
489 being processed. I have also reworked the checks in
490 CCLayerTreeHostTestWriteLayersRedraw to make the test more robust.
492 * tests/CCLayerTreeHostTest.cpp:
493 (WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
494 (WTF::CCLayerTreeHostTest::dispatchSetNeedsAnimate):
495 (WTF::CCLayerTreeHostTest::dispatchAddInstantAnimation):
496 (WTF::CCLayerTreeHostTest::dispatchAddAnimation):
497 (WTF::CCLayerTreeHostTest::dispatchSetNeedsAnimateAndCommit):
498 (WTF::CCLayerTreeHostTest::dispatchSetNeedsCommit):
499 (WTF::CCLayerTreeHostTest::dispatchAcquireLayerTextures):
500 (WTF::CCLayerTreeHostTest::dispatchSetNeedsRedraw):
501 (WTF::CCLayerTreeHostTest::dispatchSetVisible):
502 (WTF::CCLayerTreeHostTest::dispatchSetInvisible):
503 (CCLayerTreeHostTest):
504 (WTF::CCLayerTreeHostTest::endTest):
505 (WTF::CCLayerTreeHostTestWriteLayersRedraw::drawLayersOnCCThread):
506 (WTF::CCLayerTreeHostTestWriteLayersRedraw::afterTest):
508 2012-05-18 MORITA Hajime <morrita@google.com>
510 https://bugs.webkit.org/show_bug.cgi?id=85515
511 Stale frame in WebCore::SpellChecker::didCheckSucceeded
513 Added WebTextCheckingCompletionImpl::invalidate() to mark
514 pending spellcheck request as invalid, and added frameWillDetachPage()
517 Reviewed by Ryosuke Niwa.
519 * src/EditorClientImpl.cpp:
520 (WebKit::EditorClientImpl::frameWillDetachPage):
522 (WebKit::EditorClientImpl::requestCheckingOfString):
523 (WebKit::EditorClientImpl::didCheckString):
524 * src/EditorClientImpl.h:
527 * src/WebTextCheckingCompletionImpl.cpp:
528 (WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
529 (WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):
530 (WebKit::WebTextCheckingCompletionImpl::invalidate):
532 * src/WebTextCheckingCompletionImpl.h:
534 (WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl):
535 (WebTextCheckingCompletionImpl):
536 (WebKit::WebTextCheckingCompletionImpl::spellChecker):
538 2012-05-18 Jochen Eisinger <jochen@chromium.org>
540 [chromium] plumb the frame for which a drag was initiated to the WebViewClient
541 https://bugs.webkit.org/show_bug.cgi?id=86670
543 Reviewed by Kent Tamura.
545 * public/WebViewClient.h:
546 (WebKit::WebViewClient::startDragging):
548 * src/DragClientImpl.cpp:
549 (WebKit::DragClientImpl::startDrag):
550 * src/WebViewImpl.cpp:
551 (WebKit::WebViewImpl::startDragging):
555 2012-05-17 Mark Pilgrim <pilgrim@chromium.org>
557 [Chromium] Move Web Workers methods to Platform.h
558 https://bugs.webkit.org/show_bug.cgi?id=86799
560 Reviewed by Adam Barth.
562 Part of a refactoring series. See tracking bug 82948.
565 * public/WebWorkerRunLoop.h:
566 * public/platform/WebKitPlatformSupport.h:
568 (WebKitPlatformSupport):
569 * src/PlatformSupport.cpp:
570 (WebCore::PlatformSupport::didStartWorkerRunLoop):
571 (WebCore::PlatformSupport::didStopWorkerRunLoop):
573 2012-05-17 Dana Jansens <danakj@chromium.org>
575 [chromium] Scale all compositor output by the defaultDeviceScaleFactor
576 https://bugs.webkit.org/show_bug.cgi?id=86051
578 Reviewed by James Robinson.
580 Add the applyDefaultDeviceScaleInCompositor setting. When enabled, we
581 apply the scale factor during compositing instead of applying it through
584 NonCompositedContentHost is the GraphicLayerClient for the GraphicsLayer
585 containing the document's body. It needs to report the page/device scale
586 that should be used when scaling the contents of the GraphicsLayer, and
587 when changes occur to them such that its contentsSize or contentsScale
590 Store the deviceScaleFactor being used in the compositor. The remainder
591 of the deviceScaleFactor() is being applied to the pageScale.
593 * public/WebSettings.h:
594 * src/NonCompositedContentHost.cpp:
595 (WebKit::NonCompositedContentHost::NonCompositedContentHost):
596 (WebKit::NonCompositedContentHost::setViewport):
597 * src/NonCompositedContentHost.h:
598 (NonCompositedContentHost):
599 * src/WebLayerTreeView.cpp:
600 (WebKit::WebLayerTreeView::Settings::operator CCSettings):
601 * src/WebSettingsImpl.cpp:
602 (WebKit::WebSettingsImpl::setApplyDefaultDeviceScaleFactorInCompositor):
604 * src/WebSettingsImpl.h:
606 (WebKit::WebSettingsImpl::applyDefaultDeviceScaleFactorInCompositor):
607 * src/WebViewImpl.cpp:
608 (WebKit::WebViewImpl::WebViewImpl):
609 (WebKit::WebViewImpl::setPageScaleFactor):
610 (WebKit::WebViewImpl::setDeviceScaleFactor):
611 (WebKit::WebViewImpl::enableFixedLayoutMode):
612 (WebKit::WebViewImpl::computePageScaleFactorLimits):
613 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
614 (WebKit::WebViewImpl::updateLayerTreeViewport):
616 * tests/CCLayerTreeHostTest.cpp:
617 (MockLayerTreeHostImpl):
618 (WTF::MockLayerTreeHost::createLayerTreeHostImpl):
619 (CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
620 (WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
621 (WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::beginTest):
622 (WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread):
623 (WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::afterTest):
626 * tests/LayerRendererChromiumTest.cpp:
627 * tests/WebFrameTest.cpp:
630 2012-05-17 Vangelis Kokkevis <vangelis@chromium.org>
632 Expose layer tiling size options to WebSettings.
633 https://bugs.webkit.org/show_bug.cgi?id=86425
635 This will allow tiling parameters to be set via command line flags
636 passed to the Renderer.
638 Reviewed by Adrienne Walker.
640 * public/WebSettings.h:
641 * src/WebLayerTreeView.cpp:
642 (WebKit::WebLayerTreeView::Settings::operator CCSettings):
643 * src/WebSettingsImpl.cpp:
644 (WebKit::WebSettingsImpl::WebSettingsImpl):
645 (WebKit::WebSettingsImpl::setDefaultTileSize):
647 (WebKit::WebSettingsImpl::setMaxUntiledLayerSize):
648 * src/WebSettingsImpl.h:
650 (WebKit::WebSettingsImpl::defaultTileSize):
651 (WebKit::WebSettingsImpl::maxUntiledLayerSize):
652 * src/WebViewImpl.cpp:
653 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
655 2012-05-17 Mark Pilgrim <pilgrim@chromium.org>
657 [Chromium] Move fileUtilities to Platform.h
658 https://bugs.webkit.org/show_bug.cgi?id=86777
660 Reviewed by Adam Barth.
662 Part of a refactoring series. See tracking bug 82948.
665 * public/WebFileUtilities.h:
666 * public/platform/WebKitPlatformSupport.h:
668 (WebKitPlatformSupport):
669 * src/PlatformSupport.cpp:
670 (WebCore::PlatformSupport::fileExists):
671 (WebCore::PlatformSupport::deleteFile):
672 (WebCore::PlatformSupport::deleteEmptyDirectory):
673 (WebCore::PlatformSupport::getFileSize):
674 (WebCore::PlatformSupport::revealFolderInOS):
675 (WebCore::PlatformSupport::getFileModificationTime):
676 (WebCore::PlatformSupport::directoryName):
677 (WebCore::PlatformSupport::pathByAppendingComponent):
678 (WebCore::PlatformSupport::makeAllDirectories):
679 (WebCore::PlatformSupport::getAbsolutePath):
680 (WebCore::PlatformSupport::isDirectory):
681 (WebCore::PlatformSupport::filePathToURL):
682 (WebCore::PlatformSupport::openFile):
683 (WebCore::PlatformSupport::closeFile):
684 (WebCore::PlatformSupport::seekFile):
685 (WebCore::PlatformSupport::truncateFile):
686 (WebCore::PlatformSupport::readFromFile):
687 (WebCore::PlatformSupport::writeToFile):
689 2012-05-17 Joshua Bell <jsbell@chromium.org>
691 IndexedDB: Remove IDBIndex.storeName
692 https://bugs.webkit.org/show_bug.cgi?id=86676
694 Reviewed by Tony Chang.
696 * public/WebIDBIndex.h:
697 (WebIDBIndex): Can't remove from here until Chromium is updated
698 * src/IDBIndexBackendProxy.cpp: Removed storeName()
699 * src/IDBIndexBackendProxy.h: Removed storeName()
700 (IDBIndexBackendProxy):
701 * src/WebIDBIndexImpl.cpp: Removed storeName()
702 * src/WebIDBIndexImpl.h: Removed storeName()
705 2012-05-17 Joshua Bell <jsbell@chromium.org>
707 IndexedDB: Implement IDBObjectStore.autoIncrement
708 https://bugs.webkit.org/show_bug.cgi?id=86662
710 Reviewed by Dimitri Glazkov.
712 * src/IDBObjectStoreBackendProxy.cpp:
713 (WebKit::IDBObjectStoreBackendProxy::autoIncrement):
715 * src/IDBObjectStoreBackendProxy.h:
716 (IDBObjectStoreBackendProxy):
717 * src/WebIDBObjectStoreImpl.cpp:
718 (WebKit::WebIDBObjectStoreImpl::autoIncrement):
720 * src/WebIDBObjectStoreImpl.h:
721 (WebIDBObjectStoreImpl):
723 2012-05-17 Mikhail Naganov <mnaganov@chromium.org>
725 Support Copy ... actions for the Web Inspector remote debugging mode.
726 https://bugs.webkit.org/show_bug.cgi?id=86621
728 Reviewed by Pavel Feldman.
730 * src/js/DevTools.js:
731 (WebInspector.clipboardAccessDeniedMessage):
733 2012-05-17 Hironori Bono <hbono@chromium.org>
735 [Refactoring] Move platform-specific code in Editor::respondToChangedSelection to the WebKit layer
736 https://bugs.webkit.org/show_bug.cgi?id=86591
738 Reviewed by Ryosuke Niwa.
740 This change adds a TextCheckerClient::shouldEraseMarkersAfterChangeSelection
741 function to remove platform-specific code from Editor::respondToChangedSelection
744 No new tests, no change in behavior.
746 * src/EditorClientImpl.cpp:
747 (WebKit::EditorClientImpl::shouldEraseMarkersAfterChangeSelection):
749 * src/EditorClientImpl.h:
752 2012-05-11 James Robinson <jamesr@chromium.org>
754 [chromium] Convert GraphicsLayerChromium to use WebLayer types
755 https://bugs.webkit.org/show_bug.cgi?id=86269
757 Reviewed by Adrienne Walker.
760 * src/WebContentLayer.cpp:
761 (WebKit::WebContentLayer::clearClient):
763 (WebKit::WebContentLayer::setDrawsContent):
764 (WebKit::WebContentLayer::drawsContent):
765 (WebKit::WebContentLayer::WebContentLayer):
766 (WebKit::WebContentLayer::operator=):
767 (WebKit::WebContentLayer::operator PassRefPtr<ContentLayerChromium>):
768 * src/WebContentLayerImpl.cpp:
769 * src/WebContentLayerImpl.h:
770 (WebContentLayerImpl):
772 (WebKit::WebLayer::setSublayerTransform):
774 (WebKit::WebLayer::setTransform):
775 (WebKit::WebLayer::setIsDrawable):
776 (WebKit::WebLayer::setPreserves3D):
777 (WebKit::WebLayer::setDoubleSided):
778 (WebKit::WebLayer::setBackgroundColor):
779 (WebKit::WebLayer::setContentsScale):
780 * tests/ImageLayerChromiumTest.cpp:
783 2012-05-17 Dan Bernstein <mitz@apple.com>
785 REGRESSION (r117428): WebKit API/SPI was removed
786 https://bugs.webkit.org/show_bug.cgi?id=86748
791 * src/WebViewImpl.cpp:
792 (WebKit::WebViewImpl::setDomainRelaxationForbidden):
797 2012-05-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
799 Convert setDomainRelaxationForbiddenForURLScheme to use InternalSettings interface
800 https://bugs.webkit.org/show_bug.cgi?id=86704
802 Reviewed by Eric Seidel.
804 Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
805 cross-port way through the InternalSettings interface.
808 * src/WebViewImpl.cpp:
812 2012-05-17 MORITA Hajime <morrita@google.com>
814 Unreviewed attempt to fix a Windows build breakage.
816 * public/WebIntent.h:
819 2012-05-16 Sheriff Bot <webkit.review.bot@gmail.com>
821 Unreviewed, rolling out r117396.
822 http://trac.webkit.org/changeset/117396
823 https://bugs.webkit.org/show_bug.cgi?id=86709
825 "breaks chromium tree" (Requested by morrita on #webkit).
828 * public/WebTextInputInfo.h: Removed.
829 * public/WebTextInputType.h:
830 * public/WebWidget.h:
831 (WebKit::WebWidget::textInputType):
832 * src/WebTextInputInfo.cpp: Removed.
833 * src/WebViewImpl.cpp:
834 (WebKit::WebViewImpl::textInputType):
838 2012-05-16 Hao Zheng <zhenghao@chromium.org>
840 [chromium] Get text direction at the start and end of selection.
841 https://bugs.webkit.org/show_bug.cgi?id=86573
843 Reviewed by Adam Barth.
845 Add an interface to get text direction at the start and end of
846 selection for Android, as on Android different selection delimiters
847 are needed for RTL text. Unlike other platforms, the start and end
848 delimiters of selection are different, so we need determine the shape
849 of delimiter based on text direction.
851 * public/WebWidget.h:
853 (WebKit::WebWidget::selectionTextDirection):
854 * src/WebViewImpl.cpp:
856 (WebKit::WebViewImpl::selectionTextDirection):
860 2012-05-16 Adam Barth <abarth@webkit.org>
862 [Chromium] Implement WebViewImpl::textInputInfo() for Android
863 https://bugs.webkit.org/show_bug.cgi?id=86440
865 Reviewed by Darin Fisher.
867 This patch adds WebView::textInputInfo(), which describes the text
868 input that currently has focus. Android is planning to use this to
869 determine what sort of keyboard or text entry UI to show. This API
870 subsumes the textInputType() API, which will be removed once the
871 clients have been updated.
874 * public/WebTextInputInfo.h: Added.
877 (WebKit::WebTextInputInfo::WebTextInputInfo):
878 (WebKit::operator==):
879 (WebKit::operator!=):
880 * public/WebTextInputType.h:
881 * public/WebWidget.h:
883 (WebKit::WebWidget::textInputInfo):
884 (WebKit::WebWidget::textInputType):
885 * src/WebViewImpl.cpp:
886 (WebKit::WebViewImpl::textInputInfo):
888 (WebKit::WebViewImpl::textInputType):
892 2012-05-16 Greg Billock <gbillock@google.com>
894 IDL and implementation for Web Intents delivery
895 https://bugs.webkit.org/show_bug.cgi?id=83634
897 Reviewed by Adam Barth.
899 The embedder will implement the WebDeliveredIntentClient interface, which
900 will get notifications of postResult/postFailure from the service page.
902 * public/WebDeliveredIntentClient.h:
906 * src/WebDeliveredIntentClient.cpp:
907 * src/WebFrameImpl.cpp:
908 (WebKit::WebFrameImpl::deliverIntent):
910 * src/WebFrameImpl.h:
913 2012-05-16 James Robinson <jamesr@chromium.org>
915 GraphicsContext3D interface should not be aware of CanvasRenderingContext
916 https://bugs.webkit.org/show_bug.cgi?id=86550
918 Reviewed by Darin Adler.
920 Updates chromium implementation of GraphicsContext3D for API change and removes a bunch of unnecessary
923 * src/GraphicsContext3DChromium.cpp:
924 (WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
925 (WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
926 (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
927 * src/GraphicsContext3DPrivate.h:
928 (GraphicsContext3DPrivate):
930 2012-05-16 Joshua Bell <jsbell@chromium.org>
932 [Chromium] IndexedDB: WebKit API for IDBObjectStore.autoIncrement property
933 https://bugs.webkit.org/show_bug.cgi?id=86661
935 Reviewed by Dimitri Glazkov.
937 * public/WebIDBObjectStore.h:
938 (WebKit::WebIDBObjectStore::autoIncrement):
940 2012-05-16 Varun Jain <varunjain@google.com>
942 [chromium] No modifier flags (shift/ctrl/alt) in drag&drop events on chromium linux
943 https://bugs.webkit.org/show_bug.cgi?id=86236
945 Reviewed by Tony Chang.
949 * src/WebViewImpl.cpp:
950 (WebKit::webInputEventKeyStateToPlatformEventKeyState):
952 (WebKit::WebViewImpl::dragTargetDragEnter):
953 (WebKit::WebViewImpl::dragTargetDragOver):
954 (WebKit::WebViewImpl::dragTargetDrop):
955 (WebKit::WebViewImpl::dragTargetDragEnterOrOver):
959 2012-05-16 Yury Semikhatsky <yurys@chromium.org>
961 [Chromium] Web Inspector: DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh is broken
962 https://bugs.webkit.org/show_bug.cgi?id=86629
964 Reviewed by Pavel Feldman.
966 Listen to DebuggerModel instead of DebuggerPresentationModel which is gone.
969 (.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh.waitUntilScriptIsParsed):
971 2012-05-16 Yury Semikhatsky <yurys@chromium.org>
973 [Chromium] Web Inspector: debugger browser tests are broken
974 https://bugs.webkit.org/show_bug.cgi?id=86624
976 Reviewed by Vsevolod Vlasov.
978 Use WebInspector.panels.scripts._scriptMapping instead of
979 WebInspector.panels.scripts._presentationModel as the latter
983 (.TestSuite.prototype.nonAnonymousUISourceCodes_):
985 2012-05-16 Keishi Hattori <keishi@webkit.org>
987 [chromium] Add WebKit API to access inner text value of input element
988 https://bugs.webkit.org/show_bug.cgi?id=85353
990 Reviewed by Kent Tamura.
992 * public/WebInputElement.h:
994 * src/WebInputElement.cpp:
995 (WebKit::WebInputElement::editingValue):
997 (WebKit::WebInputElement::setEditingValue):
999 2012-05-16 Hans Wennborg <hans@chromium.org>
1001 Speech JavaScript API: pass WebSecurityOrigin to embedder
1002 https://bugs.webkit.org/show_bug.cgi?id=86348
1004 Reviewed by Adam Barth.
1006 Pass the WebSecurityOrigin of the SpeecReco object to the embedder when calling
1007 start(). The origin will be used to determine whether speech recognition is
1010 * public/WebSpeechRecognitionParams.h:
1011 (WebKit::WebSpeechRecognitionParams::WebSpeechRecognitionParams):
1012 (WebKit::WebSpeechRecognitionParams::origin):
1013 (WebSpeechRecognitionParams):
1014 * src/SpeechRecognitionClientProxy.cpp:
1015 (WebKit::SpeechRecognitionClientProxy::start):
1017 2012-05-15 Tien-Ren Chen <trchen@chromium.org>
1019 [Chromium] CCTimer::isActive() is incorrect inside tick callback
1020 https://bugs.webkit.org/show_bug.cgi?id=86513
1022 Update test cases to verify CCTimer::isActive() values.
1024 Reviewed by James Robinson.
1026 * tests/CCTimerTest.cpp:
1027 (WebKitTests::TEST_F):
1029 2012-05-15 Sheriff Bot <webkit.review.bot@gmail.com>
1031 Unreviewed, rolling out r117204.
1032 http://trac.webkit.org/changeset/117204
1033 https://bugs.webkit.org/show_bug.cgi?id=86559
1035 causing win compilation failures (Requested by pilgrim_google_
1039 * public/WebMessagePortChannel.h:
1041 (WebMessagePortChannel):
1042 (WebKit::WebMessagePortChannel::~WebMessagePortChannel):
1043 * public/platform/WebKitPlatformSupport.h:
1045 (WebKitPlatformSupport):
1046 (WebKit::WebKitPlatformSupport::createMessagePortChannel):
1047 * src/PlatformMessagePortChannel.cpp:
1048 (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):
1049 * src/PlatformMessagePortChannel.h:
1050 * src/SharedWorkerRepository.cpp:
1051 * src/WebSharedWorkerImpl.cpp:
1052 * src/WebWorkerClientImpl.cpp:
1054 2012-05-15 Shinya Kawanaka <shinyak@chromium.org>
1056 Rename Node::shadowTreeRootNode() to Node::shadowRoot()
1057 https://bugs.webkit.org/show_bug.cgi?id=86449
1059 Reviewed by Darin Adler.
1061 * src/WebFrameImpl.cpp:
1062 (WebKit::WebFrameImpl::scopeStringMatches):
1064 2012-05-15 Mark Pilgrim <pilgrim@chromium.org>
1066 [Chromium] Move createMessagePortChannel to Platform.h
1067 https://bugs.webkit.org/show_bug.cgi?id=85764
1069 Reviewed by Adam Barth.
1071 Part of a refactoring series. See tracking bug 82948.
1074 * public/WebMessagePortChannel.h:
1075 * public/platform/WebKitPlatformSupport.h:
1077 (WebKit::WebKitPlatformSupport::injectIDBKeyIntoSerializedValue):
1078 * src/PlatformMessagePortChannel.cpp:
1079 (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):
1080 * src/PlatformMessagePortChannel.h:
1081 * src/SharedWorkerRepository.cpp:
1082 * src/WebSharedWorkerImpl.cpp:
1083 * src/WebWorkerClientImpl.cpp:
1085 2012-05-15 Fady Samuel <fsamuel@chromium.org>
1087 [Chromium] Reset ScriptInstance in HTMLPlugInElement on WebPluginContainerImpl::setPlugin
1088 https://bugs.webkit.org/show_bug.cgi?id=86535
1090 Reviewed by Darin Fisher.
1092 * src/WebPluginContainerImpl.cpp:
1093 (WebKit::WebPluginContainerImpl::setPlugin):
1095 * src/WebPluginContainerImpl.h:
1096 (WebPluginContainerImpl):
1098 2012-05-15 Mark Pilgrim <pilgrim@chromium.org>
1100 [Chromium] Move blobRegistry to Platform.h
1101 https://bugs.webkit.org/show_bug.cgi?id=85765
1103 Reviewed by Adam Barth.
1105 Part of a refactoring series. See tracking bug 82948.
1108 * public/platform/WebBlobData.h:
1109 * public/platform/WebBlobRegistry.h:
1110 * public/platform/WebKitPlatformSupport.h:
1112 (WebKit::WebKitPlatformSupport::cookieJar):
1113 * src/BlobRegistryProxy.cpp:
1114 (WebCore::BlobRegistryProxy::BlobRegistryProxy):
1115 * src/WebBlobData.cpp:
1117 2012-05-15 Kausalya Madhusudhanan <kmadhusu@chromium.org>
1119 [chromium] Overloaded printBegin() function to support auto fit to page functionality.
1120 https://bugs.webkit.org/show_bug.cgi?id=84312
1122 Reviewed by Darin Fisher.
1125 * public/WebFrame.h:
1128 * public/WebPlugin.h:
1131 (WebKit::WebPlugin::printBegin):
1132 * public/WebPrintParams.h: Added.
1135 (WebKit::WebPrintParams::WebPrintParams):
1136 * src/WebFrameImpl.cpp:
1137 (WebKit::ChromePluginPrintContext::ChromePluginPrintContext):
1138 (WebKit::ChromePluginPrintContext::computePageRects):
1139 (ChromePluginPrintContext):
1141 (WebKit::WebFrameImpl::printBegin):
1142 * src/WebFrameImpl.h:
1145 * src/WebPluginContainerImpl.cpp:
1146 (WebKit::WebPluginContainerImpl::printBegin):
1147 * src/WebPluginContainerImpl.h:
1149 (WebPluginContainerImpl):
1151 2012-05-15 Shawn Singh <shawnsingh@chromium.org>
1153 [chromium] Add unit testing to WebTransformationMatrix
1154 https://bugs.webkit.org/show_bug.cgi?id=86421
1156 Reviewed by Adrienne Walker.
1159 * tests/WebTransformationMatrixTest.cpp: Added.
1161 (WebKit::printTransform):
1162 (WebKit::initializeTestMatrix):
1163 (WebKit::initializeTestMatrix2):
1166 2012-05-15 James Robinson <jamesr@chromium.org>
1168 [chromium] Chromium port never sets USE(CG) so code behind it is dead
1169 https://bugs.webkit.org/show_bug.cgi?id=86537
1171 Reviewed by Adrienne Walker.
1173 Deletes code behind USE(CG) in chromium-specific code and removes unneeded USE(SKIA) guards.
1175 * src/GraphicsContext3DChromium.cpp:
1176 (WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
1177 (WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
1178 (WebCore::GraphicsContext3DPrivate::grContext):
1179 (WebCore::GraphicsContext3DPrivate::paintFramebufferToCanvas):
1180 (WebCore::GraphicsContext3D::grContext):
1181 * src/GraphicsContext3DPrivate.h:
1182 (GraphicsContext3DPrivate):
1183 * src/PlatformSupport.cpp:
1184 * src/WebViewImpl.cpp:
1185 (WebKit::WebViewImpl::doPixelReadbackToCanvas):
1187 2012-05-15 Anders Carlsson <andersca@apple.com>
1189 Set the new PlatformWheelEvent member variables to sane defaults
1190 https://bugs.webkit.org/show_bug.cgi?id=86542
1192 Reviewed by Andreas Kling.
1194 * src/WebInputEventConversion.cpp:
1195 (WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
1197 2012-05-15 Ian Vollick <vollick@chromium.org>
1199 [chromium] Ensure animations get ticked at least once when added.
1200 https://bugs.webkit.org/show_bug.cgi?id=86013
1202 Reviewed by James Robinson.
1204 * tests/CCLayerTreeHostTest.cpp:
1205 (WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::animateLayers):
1208 2012-05-15 Alexandre Elias <aelias@google.com>
1210 [chromium] Fix unsafe viewport tag dispatch
1211 https://bugs.webkit.org/show_bug.cgi?id=80554
1213 Reviewed by Adam Barth.
1215 In some uncommon situations (such as window.open() new tab on
1216 Android), dispatchViewportPropertiesDidChange may early-return without
1217 setting the page scale because the window size is not yet
1218 available from the embedder. At that point, the previous behavior was
1219 to call it again in layoutUpdated(), but this is unsafe since it
1220 leaves a pending needsLayout.
1222 I moved the dispatch call into WebViewImpl::didChangeContentsSize and
1223 WebViewImpl::resize() instead -- these represent more explicitly the
1224 situations where the inputs to the viewport tag calculation change. I
1225 removed the other dispatch call from setFrameRect as it's now
1228 Covered by FixedLayoutInitializeAtMinimumPageScale test introduced
1229 in http://webk.it/82949 (an assertion will fire there without
1232 * src/ChromeClientImpl.cpp:
1233 (WebKit::ChromeClientImpl::layoutUpdated):
1234 (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
1235 * src/WebViewImpl.cpp:
1236 (WebKit::WebViewImpl::resize):
1237 (WebKit::WebViewImpl::didChangeContentsSize):
1239 2012-05-15 James Robinson <jamesr@chromium.org>
1241 [chromium] Move createOffscreenGraphicsContext3D() from WebKitPlatformSupport to Platform
1242 https://bugs.webkit.org/show_bug.cgi?id=86524
1244 Reviewed by Adam Barth.
1246 Moves createOffscreenGraphicsContext3D() out (to WebKit::Platform) and updates GraphicsContext3DChromium to use
1247 the new location. Also removes a few unnecessary includes from GraphicsContext3DChromium.cpp.
1249 * public/platform/WebKitPlatformSupport.h:
1250 (WebKitPlatformSupport):
1251 * src/GraphicsContext3DChromium.cpp:
1252 (WebCore::GraphicsContext3D::create):
1254 2012-05-15 Terry Anderson <tdanderson@chromium.org>
1256 [chromium] Compute the best target node on a GestureTap event
1257 https://bugs.webkit.org/show_bug.cgi?id=85101
1259 Reviewed by Adam Barth.
1262 Enable the touch adjustment code by default.
1263 * src/WebInputEventConversion.cpp:
1264 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
1265 In the case of a GestureTap, deltaX represents the horizontal padding of the touch
1266 area and deltaY represents the vertical padding of the touch area.
1268 2012-05-15 James Robinson <jamesr@chromium.org>
1270 Unreviewed, rolling out r116811.
1271 http://trac.webkit.org/changeset/116811
1272 https://bugs.webkit.org/show_bug.cgi?id=86257
1274 Introduced layering violation
1277 * src/Extensions3DChromium.cpp: Renamed from Source/WebCore/platform/chromium/support/Extensions3DChromium.cpp.
1279 (WebCore::Extensions3DChromium::Extensions3DChromium):
1280 (WebCore::Extensions3DChromium::~Extensions3DChromium):
1281 (WebCore::Extensions3DChromium::supports):
1282 (WebCore::Extensions3DChromium::ensureEnabled):
1283 (WebCore::Extensions3DChromium::isEnabled):
1284 (WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
1285 (WebCore::Extensions3DChromium::blitFramebuffer):
1286 (WebCore::Extensions3DChromium::renderbufferStorageMultisample):
1287 (WebCore::Extensions3DChromium::postSubBufferCHROMIUM):
1288 (WebCore::Extensions3DChromium::mapBufferSubDataCHROMIUM):
1289 (WebCore::Extensions3DChromium::unmapBufferSubDataCHROMIUM):
1290 (WebCore::Extensions3DChromium::mapTexSubImage2DCHROMIUM):
1291 (WebCore::Extensions3DChromium::unmapTexSubImage2DCHROMIUM):
1292 (WebCore::Extensions3DChromium::setVisibilityCHROMIUM):
1293 (WebCore::Extensions3DChromium::discardFramebufferEXT):
1294 (WebCore::Extensions3DChromium::ensureFramebufferCHROMIUM):
1295 (WebCore::Extensions3DChromium::setGpuMemoryAllocationChangedCallbackCHROMIUM):
1296 (WebCore::Extensions3DChromium::createVertexArrayOES):
1297 (WebCore::Extensions3DChromium::deleteVertexArrayOES):
1298 (WebCore::Extensions3DChromium::isVertexArrayOES):
1299 (WebCore::Extensions3DChromium::bindVertexArrayOES):
1300 (WebCore::Extensions3DChromium::getTranslatedShaderSourceANGLE):
1301 (WebCore::Extensions3DChromium::setSwapBuffersCompleteCallbackCHROMIUM):
1302 (WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM):
1303 (WebCore::Extensions3DChromium::paintFramebufferToCanvas):
1304 (WebCore::Extensions3DChromium::texImageIOSurface2DCHROMIUM):
1305 (WebCore::Extensions3DChromium::texStorage2DEXT):
1306 (WebCore::Extensions3DChromium::createQueryEXT):
1307 (WebCore::Extensions3DChromium::deleteQueryEXT):
1308 (WebCore::Extensions3DChromium::isQueryEXT):
1309 (WebCore::Extensions3DChromium::beginQueryEXT):
1310 (WebCore::Extensions3DChromium::endQueryEXT):
1311 (WebCore::Extensions3DChromium::getQueryivEXT):
1312 (WebCore::Extensions3DChromium::getQueryObjectuivEXT):
1313 * src/GraphicsContext3DChromium.cpp: Renamed from Source/WebCore/platform/chromium/support/GraphicsContext3DChromium.cpp.
1315 (WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
1316 (WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
1317 (WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
1318 (WebCore::GraphicsContext3DPrivate::extractWebGraphicsContext3D):
1319 (WebCore::GraphicsContext3DPrivate::platformGraphicsContext3D):
1320 (WebCore::GraphicsContext3DPrivate::platformTexture):
1321 (GrMemoryAllocationChangedCallback):
1322 (WebCore::GrMemoryAllocationChangedCallback::GrMemoryAllocationChangedCallback):
1323 (WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
1324 (WebCore::GraphicsContext3DPrivate::grContext):
1325 (WebCore::GraphicsContext3DPrivate::prepareTexture):
1326 (WebCore::GraphicsContext3DPrivate::markContextChanged):
1327 (WebCore::GraphicsContext3DPrivate::markLayerComposited):
1328 (WebCore::GraphicsContext3DPrivate::layerComposited):
1329 (WebCore::GraphicsContext3DPrivate::paintFramebufferToCanvas):
1330 (WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
1331 (WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
1332 (WebCore::GraphicsContext3DPrivate::paintRenderingResultsToImageData):
1333 (WebCore::GraphicsContext3DPrivate::reshape):
1334 (WebCore::GraphicsContext3DPrivate::getInternalFramebufferSize):
1335 (WebCore::GraphicsContext3DPrivate::isContextLost):
1336 (WebCore::GraphicsContext3DPrivate::isGLES2Compliant):
1337 (WebCore::GraphicsContext3DPrivate::bindAttribLocation):
1338 (WebCore::GraphicsContext3DPrivate::bufferData):
1339 (WebCore::GraphicsContext3DPrivate::bufferSubData):
1340 (WebCore::GraphicsContext3DPrivate::getActiveAttrib):
1341 (WebCore::GraphicsContext3DPrivate::getActiveUniform):
1342 (WebCore::GraphicsContext3DPrivate::getAttribLocation):
1343 (WebCore::GraphicsContext3DPrivate::getContextAttributes):
1344 (WebCore::GraphicsContext3DPrivate::getProgramInfoLog):
1345 (WebCore::GraphicsContext3DPrivate::getShaderInfoLog):
1346 (WebCore::GraphicsContext3DPrivate::getShaderSource):
1347 (WebCore::GraphicsContext3DPrivate::getString):
1348 (WebCore::GraphicsContext3DPrivate::getUniformLocation):
1349 (WebCore::GraphicsContext3DPrivate::shaderSource):
1350 (WebCore::GraphicsContext3DPrivate::texImage2D):
1351 (WebCore::GraphicsContext3DPrivate::texSubImage2D):
1352 (WebCore::GraphicsContext3DPrivate::uniform1fv):
1353 (WebCore::GraphicsContext3DPrivate::uniform1iv):
1354 (WebCore::GraphicsContext3DPrivate::uniform2fv):
1355 (WebCore::GraphicsContext3DPrivate::uniform2iv):
1356 (WebCore::GraphicsContext3DPrivate::uniform3fv):
1357 (WebCore::GraphicsContext3DPrivate::uniform3iv):
1358 (WebCore::GraphicsContext3DPrivate::uniform4fv):
1359 (WebCore::GraphicsContext3DPrivate::uniform4iv):
1360 (WebCore::GraphicsContext3DPrivate::uniformMatrix2fv):
1361 (WebCore::GraphicsContext3DPrivate::uniformMatrix3fv):
1362 (WebCore::GraphicsContext3DPrivate::uniformMatrix4fv):
1363 (WebCore::GraphicsContext3DPrivate::getExtensions):
1364 (WebCore::GraphicsContext3DPrivate::isResourceSafe):
1365 (WebCore::GraphicsContext3DPrivate::initializeExtensions):
1366 (WebCore::GraphicsContext3DPrivate::supportsExtension):
1367 (WebCore::GraphicsContext3DPrivate::ensureExtensionEnabled):
1368 (WebCore::GraphicsContext3DPrivate::isExtensionEnabled):
1369 (WebCore::GraphicsContext3D::GraphicsContext3D):
1370 (WebCore::GraphicsContext3D::~GraphicsContext3D):
1371 (WebCore::GraphicsContext3D::create):
1372 (WebCore::GraphicsContext3D::platformGraphicsContext3D):
1373 (WebCore::GraphicsContext3D::platformTexture):
1374 (WebCore::GraphicsContext3D::grContext):
1375 (WebCore::GraphicsContext3D::prepareTexture):
1376 (WebCore::GraphicsContext3D::getInternalFramebufferSize):
1377 (WebCore::GraphicsContext3D::isResourceSafe):
1378 (WebCore::GraphicsContext3D::platformLayer):
1379 (WebCore::GraphicsContext3D::layerComposited):
1380 (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
1381 (WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
1382 (GraphicsContextLostCallbackAdapter):
1383 (WebCore::GraphicsContextLostCallbackAdapter::~GraphicsContextLostCallbackAdapter):
1384 (WebCore::GraphicsContextLostCallbackAdapter::GraphicsContextLostCallbackAdapter):
1385 (WebCore::GraphicsContextLostCallbackAdapter::onContextLost):
1386 (WebCore::GraphicsContextLostCallbackAdapter::create):
1387 (WebCore::GraphicsContext3DPrivate::setContextLostCallback):
1388 (GraphicsErrorMessageCallbackAdapter):
1389 (WebCore::GraphicsErrorMessageCallbackAdapter::~GraphicsErrorMessageCallbackAdapter):
1390 (WebCore::GraphicsErrorMessageCallbackAdapter::GraphicsErrorMessageCallbackAdapter):
1391 (WebCore::GraphicsErrorMessageCallbackAdapter::onErrorMessage):
1392 (WebCore::GraphicsErrorMessageCallbackAdapter::create):
1393 (WebCore::GraphicsContext3DPrivate::setErrorMessageCallback):
1394 (WebCore::GraphicsContext3D::isGLES2Compliant):
1395 (GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
1396 (WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::~GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
1397 (WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
1398 (WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::onSwapBuffersComplete):
1399 (WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::create):
1400 (WebCore::GraphicsContext3DPrivate::setSwapBuffersCompleteCallbackCHROMIUM):
1401 (GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
1402 (WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
1403 (WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
1404 (WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
1405 (WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM):
1406 * src/GraphicsContext3DPrivate.h: Renamed from Source/WebCore/platform/chromium/support/GraphicsContext3DPrivate.h.
1409 (GraphicsContext3DPrivate):
1411 2012-05-15 Sheriff Bot <webkit.review.bot@gmail.com>
1413 Unreviewed, rolling out r116712.
1414 http://trac.webkit.org/changeset/116712
1415 https://bugs.webkit.org/show_bug.cgi?id=86484
1417 This patch is causing crashes in Chromium Canary builds
1418 (Requested by pilgrim_google__ on #webkit).
1421 * public/WebStorageArea.h:
1423 * public/WebStorageEventDispatcher.h:
1424 (WebStorageEventDispatcher):
1425 (WebKit::WebStorageEventDispatcher::~WebStorageEventDispatcher):
1426 * public/WebStorageNamespace.h:
1427 (WebStorageNamespace):
1428 (WebKit::WebStorageNamespace::close):
1429 * public/platform/WebKitPlatformSupport.h:
1430 (WebKitPlatformSupport):
1431 (WebKit::WebKitPlatformSupport::dispatchStorageEvent):
1432 * src/StorageAreaProxy.cpp:
1433 (WebCore::StorageAreaProxy::setItem):
1434 (WebCore::StorageAreaProxy::removeItem):
1435 (WebCore::StorageAreaProxy::clear):
1437 (WebCore::StorageAreaProxy::storageEvent):
1438 (WebCore::StorageAreaProxy::dispatchLocalStorageEvent):
1439 (WebCore::findPageWithSessionStorageNamespace):
1440 (WebCore::StorageAreaProxy::dispatchSessionStorageEvent):
1441 * src/StorageAreaProxy.h:
1444 * src/StorageEventDispatcherImpl.cpp: Added.
1446 (WebCore::StorageEventDispatcherImpl::StorageEventDispatcherImpl):
1447 (WebCore::StorageEventDispatcherImpl::dispatchStorageEvent):
1448 * src/StorageEventDispatcherImpl.h: Copied from Source/WebKit/chromium/public/WebStorageEventDispatcher.h.
1450 (StorageEventDispatcherImpl):
1451 * src/WebStorageEventDispatcherImpl.cpp:
1453 (WebKit::WebStorageEventDispatcher::dispatchLocalStorageEvent):
1454 (WebKit::WebStorageEventDispatcher::dispatchSessionStorageEvent):
1455 (WebKit::WebStorageEventDispatcher::create):
1456 (WebKit::WebStorageEventDispatcherImpl::WebStorageEventDispatcherImpl):
1457 (WebKit::WebStorageEventDispatcherImpl::dispatchStorageEvent):
1458 * src/WebStorageEventDispatcherImpl.h: Copied from Source/WebKit/chromium/public/WebStorageEventDispatcher.h.
1460 (WebStorageEventDispatcherImpl):
1461 * src/WebViewImpl.cpp:
1462 * src/WebViewImpl.h:
1466 2012-05-15 Terry Anderson <tdanderson@chromium.org>
1468 [chromium] Remove unused code for tap target fuzzing
1469 https://bugs.webkit.org/show_bug.cgi?id=86252
1471 Reviewed by Adam Barth.
1473 * public/WebInputEvent.h:
1475 (WebKit::WebGestureEvent::WebGestureEvent):
1476 * src/WebInputEvent.cpp:
1477 (SameSizeAsWebGestureEvent):
1478 * src/WebInputEventConversion.cpp:
1479 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
1480 A rectangular touch region is defined by the touch center and the
1481 delta values only, so gammaX and gammaY are not needed.
1483 2012-05-15 Hans Wennborg <hans@chromium.org>
1485 Speech JavaScript API: Introduce error code enum in Chromium plumbing
1486 https://bugs.webkit.org/show_bug.cgi?id=86353
1488 Reviewed by Adam Barth.
1490 Introduce an enum for receiving error codes from the embedder.
1491 This enum matches the enum in SpeechRecognitionError.
1493 * public/WebSpeechRecognizerClient.h:
1494 * src/AssertMatchingEnums.cpp:
1495 * src/SpeechRecognitionClientProxy.cpp:
1496 (WebKit::SpeechRecognitionClientProxy::didReceiveError):
1497 * src/SpeechRecognitionClientProxy.h:
1498 (SpeechRecognitionClientProxy):
1500 2012-05-14 Shinya Kawanaka <shinyak@chromium.org>
1502 document.execCommand('Indent') in the direct child of ShadowRoot causes a crash.
1503 https://bugs.webkit.org/show_bug.cgi?id=86341
1505 Reviewed by Ryosuke Niwa.
1508 (WebKit::WebRange::fromDocumentRange):
1510 2012-05-14 Shinya Kawanaka <shinyak@chromium.org>
1512 Node::shadowTreeRootNode() should return ShadowRoot instead of Node.
1513 https://bugs.webkit.org/show_bug.cgi?id=86428
1515 Reviewed by Hajime Morita.
1517 Adds include directive to build.
1519 * src/WebFrameImpl.cpp:
1521 2012-05-14 Gavin Peters <gavinp@chromium.org>
1523 Add Prerenderer, PrerenderHandle and a chromium interface for Prerendering.
1524 https://bugs.webkit.org/show_bug.cgi?id=85005
1526 Reviewed by Adam Barth.
1528 The prerender case isn't quite a resource load, and using resource loading to
1529 retrieve them has constrained the API, and unnecessarily complicated the loader.
1531 The new Prerenderer and PrerenderHandle let <link rel=prerender...> elements signal
1532 removal and unload to their platform.
1536 * src/PrerendererClientImpl.cpp: Copied from Source/WebCore/html/LinkRelAttribute.h.
1538 (WebKit::PrerendererClientImpl::PrerendererClientImpl):
1539 (WebKit::PrerendererClientImpl::willAddPrerender):
1540 * src/PrerendererClientImpl.h: Copied from Source/WebCore/html/LinkRelAttribute.h.
1543 (PrerendererClientImpl):
1546 * src/WebViewImpl.cpp:
1547 (WebKit::WebViewImpl::setPrerendererClient):
1549 * src/WebViewImpl.h:
1553 2012-05-14 Luke Macpherson <macpherson@chromium.org>
1555 Introduce ENABLE_CSS_VARIABLES compile flag.
1556 https://bugs.webkit.org/show_bug.cgi?id=86338
1558 Reviewed by Dimitri Glazkov.
1560 Add a configuration option for CSS Variables support, disabling it by default.
1564 2012-05-14 Gavin Peters <gavinp@chromium.org>
1566 [Chromium] remove skia/third_party/glu from DEPS
1567 https://bugs.webkit.org/show_bug.cgi?id=86431
1569 Chromium rev 136872 removed skia/third_party/glu, but nobody updated it in WebKit. This
1572 Unreviewed, remove bad Chromium repo.
1576 2012-05-14 Dirk Pranke <dpranke@chromium.org>
1578 Unreviewed, roll Chromium DEPS to r136942.
1580 2012-05-14 Adam Barth <abarth@webkit.org>
1582 [Chromium] android/WebInputEventFactory should handle wheel events and gesture events
1583 https://bugs.webkit.org/show_bug.cgi?id=86270
1585 Reviewed by Eric Seidel.
1587 * public/android/WebInputEventFactory.h:
1588 * src/android/WebInputEventFactory.cpp:
1589 (WebKit::WebInputEventFactory::keyboardEvent):
1590 (WebKit::WebInputEventFactory::mouseEvent):
1592 (WebKit::WebInputEventFactory::mouseWheelEvent):
1593 (WebKit::WebInputEventFactory::gestureEvent):
1595 2012-05-14 Sheriff Bot <webkit.review.bot@gmail.com>
1597 Unreviewed, rolling out r116983.
1598 http://trac.webkit.org/changeset/116983
1599 https://bugs.webkit.org/show_bug.cgi?id=86397
1601 Does not compile on chromium-win (Requested by abarth on
1605 * src/WebInputEventConversion.cpp:
1606 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
1608 2012-05-14 Terry Anderson <tdanderson@chromium.org>
1610 [chromium] Compute the best target node on a GestureTap event
1611 https://bugs.webkit.org/show_bug.cgi?id=85101
1613 Reviewed by Adam Barth.
1616 Enable the touch adjustment code by default.
1617 * src/WebInputEventConversion.cpp:
1618 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
1619 In the case of a GestureTap, deltaX represents the horizontal padding of the touch
1620 area and deltaY represents the vertical padding of the touch area.
1622 2012-05-14 Adrienne Walker <enne@google.com>
1624 [chromium] Add compositor debug asserts for blocked main thread
1625 https://bugs.webkit.org/show_bug.cgi?id=86384
1627 Reviewed by James Robinson.
1629 For tests that are just on the impl tree, pretend that the main thread
1632 * tests/CCLayerTreeHostImplTest.cpp:
1633 (CCLayerTreeHostImplTest):
1635 2012-05-12 Sheriff Bot <webkit.review.bot@gmail.com>
1637 Unreviewed, rolling out r116812.
1638 http://trac.webkit.org/changeset/116812
1639 https://bugs.webkit.org/show_bug.cgi?id=86313
1641 Appears to be causing a top crash (Requested by abarth on
1645 * public/WebStorageArea.h:
1648 (WebKit::WebStorageArea::~WebStorageArea):
1649 (WebKit::WebStorageArea::setItem):
1650 (WebKit::WebStorageArea::removeItem):
1651 (WebKit::WebStorageArea::clear):
1652 * public/WebStorageNamespace.h:
1654 (WebStorageNamespace):
1655 (WebKit::WebStorageNamespace::~WebStorageNamespace):
1656 (WebKit::WebStorageNamespace::isSameNamespace):
1657 * public/platform/WebKitPlatformSupport.h:
1659 (WebKitPlatformSupport):
1660 (WebKit::WebKitPlatformSupport::createLocalStorageNamespace):
1661 * src/StorageAreaProxy.cpp:
1662 * src/StorageNamespaceProxy.cpp:
1663 (WebCore::StorageNamespace::localStorageNamespace):
1665 2012-05-11 Mark Pilgrim <pilgrim@chromium.org>
1667 [Chromium] Call isLinkVisited directly
1668 https://bugs.webkit.org/show_bug.cgi?id=85412
1670 Reviewed by Adam Barth.
1672 Part of a refactoring series. See tracking bug 82948.
1674 * src/PlatformSupport.cpp:
1677 2012-05-11 Tony Chang <tony@chromium.org>
1679 [chromium] Port gtest WebViewTest.ActiveState from test_shell_tests to webkit_unit_tests
1680 https://bugs.webkit.org/show_bug.cgi?id=86271
1682 Reviewed by James Robinson.
1684 The original test is in src/webkit/glue/webview_unittest.cc.
1686 * tests/WebViewTest.cpp:
1690 2012-05-11 Shawn Singh <shawnsingh@chromium.org>
1692 [chromium] Plumb --show-paint-rects to accelerated compositor
1693 https://bugs.webkit.org/show_bug.cgi?id=86255
1695 Reviewed by James Robinson.
1697 * public/WebSettings.h:
1698 * src/WebLayerTreeView.cpp:
1699 (WebKit::WebLayerTreeView::Settings::operator CCSettings):
1700 * src/WebSettingsImpl.cpp:
1701 (WebKit::WebSettingsImpl::WebSettingsImpl):
1702 (WebKit::WebSettingsImpl::setShowPaintRects):
1704 * src/WebSettingsImpl.h:
1706 (WebKit::WebSettingsImpl::showFPSCounter):
1707 (WebKit::WebSettingsImpl::showPlatformLayerTree):
1708 (WebKit::WebSettingsImpl::showPaintRects):
1709 * src/WebViewImpl.cpp:
1710 (WebKit::WebViewImpl::settingsImpl):
1711 (WebKit::WebViewImpl::settings):
1713 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
1714 * src/WebViewImpl.h:
1716 2012-05-11 Ryosuke Niwa <rniwa@webkit.org>
1718 Do a DEPS roll per build failure caused by r116810.
1720 See http://webkitmemes.tumblr.com/post/21734202168/the-solution-to-any-chromium-problem for the rationale.
1724 2012-05-11 Sheriff Bot <webkit.review.bot@gmail.com>
1726 Unreviewed, rolling out r116802.
1727 http://trac.webkit.org/changeset/116802
1728 https://bugs.webkit.org/show_bug.cgi?id=86260
1730 This patch causes compiling error to chromium builds
1731 (Requested by jianli_ on #webkit).
1734 * src/WebInputEventConversion.cpp:
1735 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
1737 2012-05-11 Mark Pilgrim <pilgrim@chromium.org>
1739 [Chromium] Move createLocalStorageNamespace to Platform.h
1740 https://bugs.webkit.org/show_bug.cgi?id=85766
1742 Reviewed by Adam Barth.
1744 Part of a refactoring series. See tracking bug 82948.
1747 * public/WebStorageArea.h:
1748 * public/WebStorageNamespace.h:
1749 * public/platform/WebKitPlatformSupport.h:
1751 (WebKit::WebKitPlatformSupport::blobRegistry):
1752 * src/StorageAreaProxy.cpp:
1753 * src/StorageNamespaceProxy.cpp:
1754 (WebCore::StorageNamespace::localStorageNamespace):
1756 2012-05-11 James Robinson <jamesr@chromium.org>
1758 [chromium] Move implementation of WebCore::GraphicsContext3D and related from WebKit/chromium/src to WebCore/platform/chromium/support
1759 https://bugs.webkit.org/show_bug.cgi?id=86257
1761 Reviewed by Adam Barth.
1765 2012-05-11 Fady Samuel <fsamuel@chromium.org>
1767 [Chromium] Expose WebPluginContainer of WebPlugin to embedder
1768 https://bugs.webkit.org/show_bug.cgi?id=85916
1770 Reviewed by Darin Fisher.
1772 The browser plugin needs to access its current guest's WebPluginContainer
1773 so that it can replace the guest with another guest WebPlugin when navigating
1776 * public/WebPlugin.h:
1778 (WebKit::WebPlugin::container):
1780 2012-05-11 Terry Anderson <tdanderson@chromium.org>
1782 [chromium] Compute the best target node on a GestureTap event
1783 https://bugs.webkit.org/show_bug.cgi?id=85101
1785 Reviewed by Adam Barth.
1788 Enable the touch adjustment code by default.
1789 * src/WebInputEventConversion.cpp:
1790 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
1791 In the case of a GestureTap, deltaX represents the horizontal padding of the touch
1792 area and deltaY represents the vertical padding of the touch area.
1794 2012-05-11 Ian Vollick <vollick@chromium.org>
1796 [chromium] Ensure that animations continue to run when transform-style is changed
1797 https://bugs.webkit.org/show_bug.cgi?id=83283
1799 Reviewed by James Robinson.
1802 * tests/GraphicsLayerChromiumTest.cpp: Added.
1804 (MockGraphicsLayerClient):
1805 (WebKitTests::MockGraphicsLayerClient::notifyAnimationStarted):
1806 (WebKitTests::MockGraphicsLayerClient::notifySyncRequired):
1807 (WebKitTests::MockGraphicsLayerClient::paintContents):
1808 (WebKitTests::MockGraphicsLayerClient::showDebugBorders):
1809 (WebKitTests::MockGraphicsLayerClient::showRepaintCounter):
1810 (WebKitTests::TEST):
1812 2012-05-11 Min Qin <qinmin@google.com>
1814 split MediaPlayer::enterFullscreen into 2 seperate functions
1815 https://bugs.webkit.org/show_bug.cgi?id=86052
1817 Reviewed by Adam Barth.
1819 In WebCore, we splitted bool enterFullscreen() into two seperate calls:
1820 void enterFullscreen() and bool canEnterFullscreen()
1821 This is the change in the chromium part that we needed to support the WebCore change
1822 No behavior change, just refactoring.
1824 * public/WebMediaPlayer.h:
1826 (WebKit::WebMediaPlayer::enterFullscreen):
1827 (WebKit::WebMediaPlayer::canEnterFullscreen):
1828 * src/WebMediaPlayerClientImpl.cpp:
1829 (WebKit::WebMediaPlayerClientImpl::enterFullscreen):
1831 (WebKit::WebMediaPlayerClientImpl::exitFullscreen):
1832 * src/WebMediaPlayerClientImpl.h:
1833 (WebMediaPlayerClientImpl):
1834 * src/WebViewImpl.cpp:
1835 (WebKit::WebViewImpl::enterFullScreenForElement):
1837 2012-05-11 David Reveman <reveman@chromium.org>
1839 [Chromium] Move instantiation of texture uploader to LayerRendererChromium.
1840 https://bugs.webkit.org/show_bug.cgi?id=85893
1842 Reviewed by Adrienne Walker.
1844 * tests/CCLayerTreeHostImplTest.cpp:
1845 (WebKitTests::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
1846 (WebKitTests::TEST_F):
1847 * tests/LayerRendererChromiumTest.cpp:
1848 (FakeLayerRendererChromium::FakeLayerRendererChromium):
1849 (LayerRendererChromiumTest::LayerRendererChromiumTest):
1852 2012-05-11 Sheriff Bot <webkit.review.bot@gmail.com>
1854 Unreviewed, rolling out r116727.
1855 http://trac.webkit.org/changeset/116727
1856 https://bugs.webkit.org/show_bug.cgi?id=86181
1858 Build error on Chromium-Android (Requested by tkent on
1861 * public/WebMediaPlayer.h:
1863 (WebKit::WebMediaPlayer::enterFullscreen):
1864 (WebKit::WebMediaPlayer::exitFullscreen):
1865 * src/WebMediaPlayerClientImpl.cpp:
1866 (WebKit::WebMediaPlayerClientImpl::enterFullscreen):
1867 (WebKit::WebMediaPlayerClientImpl::exitFullscreen):
1868 * src/WebMediaPlayerClientImpl.h:
1869 (WebMediaPlayerClientImpl):
1870 * src/WebViewImpl.cpp:
1871 (WebKit::WebViewImpl::enterFullScreenForElement):
1873 2012-05-11 Sheriff Bot <webkit.review.bot@gmail.com>
1875 Unreviewed, rolling out r116731.
1876 http://trac.webkit.org/changeset/116731
1877 https://bugs.webkit.org/show_bug.cgi?id=86178
1879 Build failure on Chromium-mac (Requested by tkent on #webkit).
1881 * tests/CCLayerTreeHostImplTest.cpp:
1882 (WebKitTests::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
1883 (WebKitTests::TEST_F):
1884 * tests/LayerRendererChromiumTest.cpp:
1885 (FakeLayerRendererChromium::FakeLayerRendererChromium):
1886 (LayerRendererChromiumTest::LayerRendererChromiumTest):
1889 2012-05-10 David Reveman <reveman@chromium.org>
1891 [Chromium] Move instantiation of texture uploader to LayerRendererChromium.
1892 https://bugs.webkit.org/show_bug.cgi?id=85893
1894 Reviewed by Adrienne Walker.
1896 * tests/CCLayerTreeHostImplTest.cpp:
1897 (WebKitTests::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
1898 (WebKitTests::TEST_F):
1899 * tests/LayerRendererChromiumTest.cpp:
1900 (FakeLayerRendererChromium::FakeLayerRendererChromium):
1901 (LayerRendererChromiumTest::LayerRendererChromiumTest):
1904 2012-05-10 Min Qin <qinmin@google.com>
1906 split MediaPlayer::enterFullscreen into 2 seperate functions
1907 https://bugs.webkit.org/show_bug.cgi?id=86052
1909 Reviewed by Benjamin Poulain.
1911 It is confusing that enterFullscreen returns a boolean while exitFullscreen does
1912 not do the same. And ios does not need the return value.
1913 So remove the return value on enterFullscreen and make a seperate canEnterFullscreen()
1914 function for android.
1915 No behavior change, just refactoring.
1917 * public/WebMediaPlayer.h:
1919 (WebKit::WebMediaPlayer::enterFullscreen):
1920 (WebKit::WebMediaPlayer::canEnterFullscreen):
1921 * src/WebMediaPlayerClientImpl.cpp:
1922 (WebKit::WebMediaPlayerClientImpl::enterFullscreen):
1924 (WebKit::WebMediaPlayerClientImpl::exitFullscreen):
1925 * src/WebMediaPlayerClientImpl.h:
1926 (WebMediaPlayerClientImpl):
1927 * src/WebViewImpl.cpp:
1928 (WebKit::WebViewImpl::enterFullScreenForElement):
1930 2012-05-10 Hajime Morrita <morrita@google.com>
1932 WebKit should support tab-size.
1933 https://bugs.webkit.org/show_bug.cgi?id=52994
1935 Reviewed by Simon Fraser.
1937 * src/WebTextRun.cpp:
1938 (WebKit::WebTextRun::operator WebCore::TextRun):
1940 2012-05-10 Kent Tamura <tkent@chromium.org>
1942 Unreviewed, rolling out r116594.
1943 http://trac.webkit.org/changeset/116594
1944 https://bugs.webkit.org/show_bug.cgi?id=86013
1946 r116594 might have made some composition tests flaky.
1948 * tests/CCLayerTreeHostTest.cpp:
1949 (WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::animateLayers):
1953 2012-05-10 Jian Li <jianli@chromium.org>
1955 Unreviewed. Fix chromium build break.
1957 * src/LocalizedStrings.cpp:
1958 (WebCore::insecurePluginVersionText):
1960 2012-05-10 Michael Nordman <michaeln@google.com>
1962 [chromium] DomStorage events handling needs TLC (2)
1963 https://bugs.webkit.org/show_bug.cgi?id=85221
1964 Alter the WebStorageArea virtual interface such that the mutators no longer
1965 return old values. This is to allow implementations of the interface to operate
1966 more asynchronously.
1968 Also clean up from the last patch, remove support for the DEPRECATED event
1971 Reviewed by Adam Barth.
1973 * WebKit.gyp: delete three files indicated below
1974 * public/WebStorageArea.h:
1975 (WebKit::WebStorageArea::setItem): no longer returns the old value
1976 (WebKit::WebStorageArea::removeItem): no longer returns the old value
1977 (WebKit::WebStorageArea::clear): no longer returns a bool indicated if something was cleared
1978 * public/WebStorageEventDispatcher.h: removed the DEPRECATED instance methods
1979 * public/WebStorageNamespace.h: removed the DEPRECATED close() method
1980 * public/platform/WebKitPlatformSupport.h: removed the DEPRECATED dispatchStorageEvent() method
1981 * src/StorageAreaProxy.cpp: removed the DEPREACTED storageEvent() method
1982 (WebCore::StorageAreaProxy::setItem): no return value
1983 (WebCore::StorageAreaProxy::removeItem): no return value
1984 (WebCore::StorageAreaProxy::clear): no return value
1985 (WebCore::StorageAreaProxy::dispatchLocalStorageEvent): remove an early return thats no longer needed
1986 (WebCore::findPageWithSessionStorageNamespace): switched to passing pageGroup by ptr value instead of by name
1987 (WebCore::StorageAreaProxy::dispatchSessionStorageEvent): remove an early return thats no longer needed
1988 * src/StorageAreaProxy.h:
1991 * src/StorageEventDispatcherImpl.cpp: Deleted the file.
1992 * src/StorageEventDispatcherImpl.h: Deleted the file.
1993 * src/WebStorageEventDispatcherImpl.cpp: Deleted the DEPRECATED instance methods.
1994 (WebKit::WebStorageEventDispatcher::dispatchLocalStorageEvent): use WebViewImpl::defaultPageGroup
1995 (WebKit::WebStorageEventDispatcher::dispatchSessionStorageEvent): use WebViewImpl::defaultPageGroup
1996 * src/WebStorageEventDispatcherImpl.h: Deleted the file.
1997 * src/WebViewImpl.cpp: added a static method to retrieve a ptr to the default page group,
1998 (WebKit::WebViewImpl::defaultPageGroup):
1999 * src/WebViewImpl.h:
2002 2012-05-10 Anders Carlsson <andersca@apple.com>
2004 Add insecurePluginVersionText stub here too.
2006 * src/LocalizedStrings.cpp:
2008 2012-05-10 Mark Pilgrim <pilgrim@chromium.org>
2010 [Chromium] Call addTraceEvent and getTraceCategoryEnabledFlag directly
2011 https://bugs.webkit.org/show_bug.cgi?id=85399
2013 Reviewed by Adam Barth.
2015 Part of a refactoring series. See tracking bug 82948.
2017 * src/PlatformSupport.cpp:
2020 2012-05-10 Mark Pilgrim <pilgrim@chromium.org>
2022 [Chromium] Remove WEBKIT_USING_SKIA ifdefs that are always true
2023 https://bugs.webkit.org/show_bug.cgi?id=86121
2025 Reviewed by Adam Barth.
2027 Chromium always uses Skia now, so this just removes the barriers
2028 around code that was previously #if'd.
2031 * src/DragClientImpl.cpp:
2032 (WebKit::DragClientImpl::startDrag):
2033 * src/PageOverlay.cpp:
2034 * src/PlatformSupport.cpp:
2035 (WebCore::PlatformSupport::clipboardWriteImage):
2036 (WebCore::PlatformSupport::paintScrollbarThumb):
2037 * src/WebContentLayerImpl.cpp:
2038 (WebKit::WebContentLayerImpl::paintContents):
2039 * src/WebFontImpl.cpp:
2040 (WebKit::WebFontImpl::drawText):
2041 * src/WebFrameImpl.cpp:
2042 (WebKit::WebFrameImpl::printPage):
2043 (WebKit::WebFrameImpl::printPagesWithBoundaries):
2044 * src/WebGraphicsContext3D.cpp:
2045 (WebKit::WebGraphicsContext3D::createGrGLInterface):
2046 * src/WebImageDecoder.cpp:
2047 (WebKit::WebImageDecoder::getFrameAtIndex):
2048 * src/WebPluginContainerImpl.cpp:
2049 (WebKit::WebPluginContainerImpl::paint):
2050 (WebKit::WebPluginContainerImpl::printPage):
2051 * src/painting/GraphicsContextBuilder.h:
2054 2012-05-10 Tom Sepez <tsepez@chromium.org>
2056 [Chromium] WebFrameTest.ChromePageNoJavascript isn't catching regressions
2057 https://bugs.webkit.org/show_bug.cgi?id=86046
2059 Reviewed by Adam Barth.
2061 Test both cases for registerURLSchemeAsNotAllowingJavascriptURLs. Also add
2062 a call to layout() to ensure the javascript result is seen.
2064 * tests/WebFrameTest.cpp:
2068 2012-05-10 Varun Jain <varunjain@google.com>
2070 [chromium] Trigger context menu for long press gesture
2071 https://bugs.webkit.org/show_bug.cgi?id=85919
2073 Reviewed by Adam Barth.
2075 * src/PageWidgetDelegate.cpp:
2076 (WebKit::PageWidgetDelegate::handleInputEvent):
2077 * src/WebViewImpl.cpp:
2078 (WebKit::WebViewImpl::handleGestureEvent):
2080 2012-05-10 Mark Pilgrim <pilgrim@chromium.org>
2082 [Chromium] Remove dead code behind unused WEBKIT_USING_CG
2083 https://bugs.webkit.org/show_bug.cgi?id=86018
2085 Reviewed by Adam Barth.
2087 We never use CoreGraphics as the backend for GraphicsContext in
2088 Chromium, so this is all dead code.
2091 * src/PageOverlay.cpp:
2092 * src/WebContentLayerImpl.cpp:
2093 (WebKit::WebContentLayerImpl::paintContents):
2094 * src/WebFontImpl.cpp:
2095 (WebKit::WebFontImpl::drawText):
2096 * src/WebImageDecoder.cpp:
2097 (WebKit::WebImageDecoder::getFrameAtIndex):
2098 * src/WebPluginContainerImpl.cpp:
2099 (WebKit::WebPluginContainerImpl::paint):
2100 (WebKit::WebPluginContainerImpl::printPage):
2101 * src/painting/GraphicsContextBuilder.h:
2104 2012-05-10 Sam D <dsam2912@gmail.com>
2106 Web Inspector: rename InspectorBackendStub.js to InspectorBackendCommands.js
2107 https://bugs.webkit.org/show_bug.cgi?id=72306
2109 Changed name for InspectorBackendStub.js to InspectorBackendCommands.js
2111 Reviewed by Yury Semikhatsky.
2115 2012-05-09 Kent Tamura <tkent@chromium.org>
2117 [Chromium] Mark CCLayerTreeHostTestSetNeedsCommit2.runMultiThread and
2118 CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity.runMultiThread flaky.
2120 * tests/CCLayerTreeHostTest.cpp:
2122 2012-05-09 Dan Alcantara <dfalcantara@chromium.org>
2124 [chromium] Add ability to override user agent string per-WebFrameClient
2125 https://bugs.webkit.org/show_bug.cgi?id=83959
2127 Reviewed by Adam Barth.
2129 Adds a method that can be used to override the normal user agent in
2130 chromium. Also adds a unit test to check if the override is taking effect.
2133 * public/WebFrameClient.h:
2135 (WebKit::WebFrameClient::userAgent):
2136 * src/FrameLoaderClientImpl.cpp:
2137 (WebKit::FrameLoaderClientImpl::userAgent):
2138 * tests/FrameLoaderClientImplTest.cpp: Added.
2140 (TestWebFrameClient):
2141 (WebKit::TestWebFrameClient::setUserAgentOverride):
2142 (FrameLoaderClientImplTest):
2143 (WebKit::FrameLoaderClientImplTest::SetUp):
2144 (WebKit::FrameLoaderClientImplTest::TearDown):
2145 (WebKit::FrameLoaderClientImplTest::setUserAgentOverride):
2146 (WebKit::FrameLoaderClientImplTest::userAgent):
2149 2012-05-09 Charlie Reis <creis@chromium.org>
2151 Add dispatchMessageEventWithOriginCheck to WebFrame
2152 https://bugs.webkit.org/show_bug.cgi?id=85815
2154 Reviewed by Adam Barth.
2156 Tested by WebFrameTest.DispatchMessageEventWithOriginCheck.
2157 Also fixes source frame bug in willCheckAndDispatchMessageEvent.
2159 * public/WebFrame.h:
2161 * src/FrameLoaderClientImpl.cpp:
2162 (WebKit::FrameLoaderClientImpl::willCheckAndDispatchMessageEvent):
2163 * src/WebFrameImpl.cpp:
2164 (WebKit::WebFrameImpl::checkAndDispatchMessageEvent):
2166 * src/WebFrameImpl.h:
2169 2012-05-09 Hironori Bono <hbono@chromium.org>
2171 Fix a crash in ContextMenuClientImpl::getCustomMenuFromDefaultItems
2172 https://bugs.webkit.org/show_bug.cgi?id=85866
2174 Reviewed by Ryosuke Niwa.
2176 DocumentMarkerController::markersInRange crashes if the input range is NULL.
2177 This change adds a NULL check before getCustomMenuFromDefaultItems() calls this
2178 function to avoid this crash.
2180 * src/ContextMenuClientImpl.cpp:
2181 (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Added a NULL check.
2183 2012-05-09 Sheriff Bot <webkit.review.bot@gmail.com>
2185 Unreviewed, rolling out r116602.
2186 http://trac.webkit.org/changeset/116602
2187 https://bugs.webkit.org/show_bug.cgi?id=86057
2189 Build error on Windows (Requested by tkent on #webkit).
2192 * public/WebFrameClient.h:
2193 * src/FrameLoaderClientImpl.cpp:
2194 (WebKit::FrameLoaderClientImpl::userAgent):
2195 * tests/FrameLoaderClientImplTest.cpp: Removed.
2197 2012-05-09 Kent Tamura <tkent@chromium.org>
2199 [Chromium] Fix compilation warning on Android.
2200 https://bugs.webkit.org/show_bug.cgi?id=85958
2202 * features.gypi: Move ENABLE_MEDIA_CAPTURE=0 to non-Android block.
2204 2012-05-09 Dan Alcantara <dfalcantara@chromium.org>
2206 [chromium] Add ability to override user agent string per-WebFrameClient
2207 https://bugs.webkit.org/show_bug.cgi?id=83959
2209 Reviewed by Adam Barth.
2211 Adds a method that can be used to override the normal user agent in
2212 chromium. Also adds a unit test to check if the override is taking effect.
2215 * public/WebFrameClient.h:
2217 (WebKit::WebFrameClient::userAgent):
2218 * src/FrameLoaderClientImpl.cpp:
2219 (WebKit::FrameLoaderClientImpl::userAgent):
2220 * tests/FrameLoaderClientImplTest.cpp: Added.
2222 (TestWebFrameClient):
2223 (WebKit::TestWebFrameClient::setUserAgentOverride):
2224 (FrameLoaderClientImplTest):
2225 (WebKit::FrameLoaderClientImplTest::SetUp):
2226 (WebKit::FrameLoaderClientImplTest::TearDown):
2227 (WebKit::FrameLoaderClientImplTest::setUserAgentOverride):
2228 (WebKit::FrameLoaderClientImplTest::userAgent):
2231 2012-05-09 Ian Vollick <vollick@chromium.org>
2233 [chromium] Ensure animations get ticked at least once when added.
2234 https://bugs.webkit.org/show_bug.cgi?id=86013
2236 Reviewed by James Robinson.
2238 * tests/CCLayerTreeHostTest.cpp:
2239 (WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::animateLayers):
2242 2012-05-09 Adam Barth <abarth@webkit.org>
2244 Implement HTML Media Capture
2245 https://bugs.webkit.org/show_bug.cgi?id=85958
2247 Reviewed by Eric Seidel.
2250 * public/WebFileChooserParams.h:
2251 (WebFileChooserParams):
2252 * src/ChromeClientImpl.cpp:
2253 (WebKit::ChromeClientImpl::runOpenPanel):
2255 2012-05-09 Dana Jansens <danakj@chromium.org>
2257 [chromium] Don't draw when canDraw() is false
2258 https://bugs.webkit.org/show_bug.cgi?id=85829
2260 Reviewed by Adrienne Walker.
2262 * tests/CCLayerTreeHostImplTest.cpp:
2263 (WebKitTests::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
2264 (WebKitTests::TEST_F):
2265 * tests/CCLayerTreeHostTest.cpp:
2267 (CCLayerTreeHostTestCanDrawBlocksDrawing):
2268 (WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::CCLayerTreeHostTestCanDrawBlocksDrawing):
2269 (WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::beginTest):
2270 (WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::commitCompleteOnCCThread):
2271 (WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::drawLayersOnCCThread):
2272 (WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::didCommitAndDrawFrame):
2273 (WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::afterTest):
2276 2012-05-09 Sheriff Bot <webkit.review.bot@gmail.com>
2278 Unreviewed, rolling out r116573.
2279 http://trac.webkit.org/changeset/116573
2280 https://bugs.webkit.org/show_bug.cgi?id=86038
2282 Broke the Chromium Mac compile (Requested by ojan_gardening on
2285 * public/WebPlugin.h:
2288 2012-05-09 Fady Samuel <fsamuel@chromium.org>
2290 [Chromium] Expose WebPluginContainer of WebPlugin to embedder
2291 https://bugs.webkit.org/show_bug.cgi?id=85916
2293 Reviewed by Darin Fisher.
2295 The browser plugin needs to access its current guest's WebPluginContainer
2296 so that it can replace the guest with another guest WebPlugin when navigating
2299 * public/WebPlugin.h:
2301 (WebKit::WebPlugin::container):
2303 2012-05-09 Mark Pilgrim <pilgrim@chromium.org>
2305 [Chromium] Move clipboard to Platform.h
2306 https://bugs.webkit.org/show_bug.cgi?id=85758
2308 Reviewed by Adam Barth.
2310 Part of a refactoring series. See tracking bug 82948.
2313 * public/platform/WebClipboard.h:
2314 * public/platform/WebDragData.h:
2315 * public/platform/WebImage.h:
2316 * public/platform/WebKitPlatformSupport.h:
2318 (WebKitPlatformSupport):
2319 * src/AssertMatchingEnums.cpp:
2320 * src/DragClientImpl.cpp:
2321 * src/PlatformSupport.cpp:
2322 * src/WebDragData.cpp:
2323 * src/WebImageCG.cpp:
2324 * src/WebImageDecoder.cpp:
2325 * src/WebImageSkia.cpp:
2326 * src/WebPluginContainerImpl.cpp:
2327 (WebKit::WebPluginContainerImpl::copy):
2328 * src/WebViewImpl.cpp:
2330 2012-05-09 Mark Pilgrim <pilgrim@chromium.org>
2332 [Chromium] Remove PlatformSupport::loadPlatformImageResource, call loadResource directly
2333 https://bugs.webkit.org/show_bug.cgi?id=84417
2335 Reviewed by Adam Barth.
2337 Part of a refactoring series. See tracking bug 82948.
2339 * src/PlatformSupport.cpp:
2342 2012-05-09 Jochen Eisinger <jochen@chromium.org>
2344 [chromium] remove the obsolete WebFrame::referrerPolicy method
2345 https://bugs.webkit.org/show_bug.cgi?id=86003
2347 Reviewed by Adam Barth.
2349 * public/WebFrame.h:
2350 * src/WebFrameImpl.cpp:
2351 * src/WebFrameImpl.h:
2354 2012-05-09 Jochen Eisinger <jochen@chromium.org>
2356 [chromium] Check whether an active document loader exists before accessing it
2357 https://bugs.webkit.org/show_bug.cgi?id=85892
2359 Reviewed by Eric Seidel.
2361 Although FrameLoader::loadInSameDocument which invokes this
2362 method does not have a provisional document loader, we're seeing crashes
2363 where the FrameLoader is in provisional state, and thus
2364 activeDocumentLoader returns 0. Lacking any understanding of how this
2365 can happen, we do this check here to avoid crashing.
2367 * src/FrameLoaderClientImpl.cpp:
2368 (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
2370 2012-05-09 Ian Vollick <vollick@chromium.org>
2372 [chromium] Add impl-thread support for fill-mode and direction css animation properties
2373 https://bugs.webkit.org/show_bug.cgi?id=77662
2375 Reviewed by James Robinson.
2377 * tests/CCActiveAnimationTest.cpp:
2380 * tests/CCLayerAnimationControllerTest.cpp:
2381 (WebKitTests::TEST):
2384 2012-05-09 Ojan Vafai <ojan@chromium.org>
2386 Unreviewed. Rolled DEPS.
2390 2012-05-09 Marcus Bulach <bulach@chromium.org>
2392 [chromium] Exposes OrientationChangeEvent.
2393 https://bugs.webkit.org/show_bug.cgi?id=85976
2395 Reviewed by Adam Barth.
2397 This is used by the android port, we need to expose the existing
2400 * public/WebFrame.h:
2402 * src/WebFrameImpl.cpp:
2403 (WebKit::WebFrameImpl::sendOrientationChangeEvent):
2405 * src/WebFrameImpl.h:
2408 2012-05-09 Dana Jansens <danakj@chromium.org>
2410 Early-out and avoid any copying when possible for Region operations
2411 https://bugs.webkit.org/show_bug.cgi?id=85260
2413 Reviewed by Anders Carlsson.
2415 * tests/RegionTest.cpp:
2419 2012-05-09 Tommy Widenflycht <tommyw@google.com>
2421 [chromium] MediaStream API: Fixing a memory leak in WebUserMediaRequest
2422 https://bugs.webkit.org/show_bug.cgi?id=85992
2424 Reviewed by Adam Barth.
2426 * src/WebUserMediaRequest.cpp:
2427 (WebKit::WebUserMediaRequest::assign):
2429 2012-05-09 Kent Tamura <tkent@chromium.org>
2431 [Chromium] Disable WebViewTest.TextInputType because the test is incomplete.
2433 * tests/WebViewTest.cpp:
2435 2012-05-09 Kent Tamura <tkent@chromium.org>
2437 [Chromium] Some of *.runMultiThread tests intermittently crash.
2440 * tests/CCLayerTreeHostTest.cpp:
2442 2012-05-09 Oli Lan <olilan@chromium.org>
2444 Adds date/time input types to WebTextInputType, and adds support for these
2445 to WebViewImpl.textInputType().
2447 Adds a new test WebViewTest.TextInputType to test WebViewImpl.textInputType(),
2448 including the new types.
2450 https://bugs.webkit.org/show_bug.cgi?id=78746
2452 Reviewed by Kent Tamura.
2454 * public/WebTextInputType.h:
2455 * src/WebViewImpl.cpp:
2456 (WebKit::WebViewImpl::textInputType):
2457 * tests/WebViewTest.cpp:
2459 (WebKit::WebViewTest::testTextInputType):
2462 * tests/data/input_field_date.html: Added.
2463 * tests/data/input_field_datetime.html: Added.
2464 * tests/data/input_field_default.html: Added.
2465 * tests/data/input_field_email.html: Added.
2466 * tests/data/input_field_number.html: Added.
2467 * tests/data/input_field_search.html: Added.
2468 * tests/data/input_field_time.html: Added.
2469 * tests/data/input_field_week.html: Added.
2471 2012-05-08 Jochen Eisinger <jochen@chromium.org>
2473 Unreviewed. Rolled DEPS.
2477 2012-05-08 Dana Jansens <danakj@chromium.org>
2479 [chromium] Show borders for partial-draw-culled quads to visualize culling behaviour
2480 https://bugs.webkit.org/show_bug.cgi?id=85414
2482 Reviewed by Adrienne Walker.
2484 * tests/CCQuadCullerTest.cpp:
2485 (WebCore::appendQuads):
2486 * tests/MockCCQuadCuller.h:
2487 (WebCore::MockCCQuadCuller::MockCCQuadCuller):
2489 2012-05-08 Tony Chang <tony@chromium.org>
2491 [chromium] force ENABLE_REGISTER_PROTOCOL_HANDLER=1 in features.gypi
2492 https://bugs.webkit.org/show_bug.cgi?id=85924
2494 Reviewed by Adam Barth.
2496 This has been enabled for a few months on Chromium trunk so remove the
2497 ability to turn it off via a gyp flag. This simplifies features.gypi.
2501 2012-05-08 Dana Jansens <danakj@chromium.org>
2503 [chromium] Reflections with masks should not occlude
2504 https://bugs.webkit.org/show_bug.cgi?id=85927
2506 Reviewed by James Robinson.
2508 * tests/CCOcclusionTrackerTest.cpp:
2509 (WebKitTests::CCOcclusionTrackerTest::TearDown):
2510 (WebKitTests::CCOcclusionTrackerTest::createMaskLayer):
2511 (CCOcclusionTrackerTest):
2512 (WebKitTests::CCOcclusionTrackerTest::setMask):
2513 (CCOcclusionTrackerTestReplicaWithMask):
2514 (WebKitTests::CCOcclusionTrackerTestReplicaWithMask::runMyTest):
2517 2012-05-08 Dana Jansens <danakj@chromium.org>
2519 Region reads past end of spans
2520 https://bugs.webkit.org/show_bug.cgi?id=85909
2522 Reviewed by Anders Carlsson.
2524 * tests/RegionTest.cpp:
2528 2012-05-08 Tony Chang <tony@chromium.org>
2530 move listener_leak_test to webkit_unit_tests
2531 https://bugs.webkit.org/show_bug.cgi?id=85922
2533 Reviewed by Ojan Vafai.
2535 Porting the test from src/webkit/tools/test_shell/listener_leak_test.cc.
2536 All I did was change the style and use the FrameTestHelper to load the file.
2538 * WebKit.gyp: Exclude file in components build.
2539 * WebKit.gypi: Add new file.
2540 * tests/ListenerLeakTest.cpp: Added.
2542 (WebKit::GetProperty):
2543 (WebKit::GetNumObjects):
2545 (WebKit::ListenerLeakTest::ListenerLeakTest):
2546 (WebKit::ListenerLeakTest::RunTest):
2548 * tests/data/listener/listener_leak1.html: Added.
2549 * tests/data/listener/listener_leak2.html: Added.
2551 2012-05-08 W. James MacLean <wjmaclean@chromium.org>
2553 [chromium] Create LinkHighlightLayerChromium class to provide link-highlight preview animations for GraphicsLayerChromium.
2554 https://bugs.webkit.org/show_bug.cgi?id=85084
2556 Reviewed by James Robinson.
2559 * tests/LinkHighlightTest.cpp: Added.
2561 (MockGraphicsLayerClient):
2562 (WebCore::MockGraphicsLayerClient::notifyAnimationStarted):
2563 (WebCore::MockGraphicsLayerClient::notifySyncRequired):
2564 (WebCore::MockGraphicsLayerClient::paintContents):
2565 (WebCore::MockGraphicsLayerClient::showDebugBorders):
2566 (WebCore::MockGraphicsLayerClient::showRepaintCounter):
2569 2012-05-08 Tony Chang <tony@chromium.org>
2571 [chromium] move event_listener_unittest to webkit_unit_tests
2572 https://bugs.webkit.org/show_bug.cgi?id=85836
2574 Reviewed by James Robinson.
2576 Porting the test from src/webkit/tools/test_shell/event_listener_unittest.cc.
2577 All I did was change the style and use the FrameTestHelper to load the file.
2579 * WebKit.gyp: Exclude file in components build.
2580 * WebKit.gypi: Add new file.
2581 * tests/EventListenerTest.cpp: Added.
2583 (TestWebDOMEventListener):
2584 (WebKit::TestWebDOMEventListener::TestWebDOMEventListener):
2585 (WebKit::TestWebDOMEventListener::~TestWebDOMEventListener):
2586 (WebKit::TestWebDOMEventListener::eventCount):
2587 (WebKit::TestWebDOMEventListener::eventAt):
2588 (WebKit::TestWebDOMEventListener::clearEvents):
2589 (WebDOMEventListenerTest):
2590 (WebKit::WebDOMEventListenerTest::WebDOMEventListenerTest):
2591 (WebKit::WebDOMEventListenerTest::SetUp):
2592 (WebKit::WebDOMEventListenerTest::TearDown):
2593 (WebKit::WebDOMEventListenerTest::mainFrame):
2594 (WebKit::WebDOMEventListenerTest::document):
2595 (WebKit::WebDOMEventListenerTest::executeScript):
2596 (WebKit::WebDOMEventListenerTest::GetNodeID):
2598 * tests/data/listener/mutation_event_listener.html: Added.
2600 2012-05-07 Kinuko Yasuda <kinuko@chromium.org>
2602 Unreviewed build fix: didOpenFileSystem hides overloaded virtual function
2604 * src/WorkerAsyncFileSystemChromium.cpp:
2606 2012-05-07 Kinuko Yasuda <kinuko@chromium.org>
2608 Unreviewed build fix: adding missing include.
2610 * src/AsyncFileSystemChromium.cpp:
2612 2012-05-07 Kinuko Yasuda <kinuko@chromium.org>
2614 Support cross-filesystem operations in FileSystem API
2615 https://bugs.webkit.org/show_bug.cgi?id=84135
2617 Reviewed by David Levin.
2619 Currently we pass Entry's fullPath to AsyncFileSystem layer where
2620 we convert the given path to filesystem URL which includes origin and
2621 filesystem type information, but in that way we cannot handle
2622 cross-filesystem operations (e.g. cross-filesystem copy and move)
2623 well since we end up with always attaching the source filesystem's
2624 origin and type information for argument paths.
2627 - move filesystem-type related code out of AsyncFileSystemChromium.cpp
2628 (moving into DOMFileSystemChromium.cpp)
2629 - change AsyncFileSystemChromium's methods implementation not to take
2630 entry paths but complete filesystem URLs.
2632 * src/AsyncFileSystemChromium.cpp:
2633 (WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium):
2634 (WebCore::AsyncFileSystemChromium::move):
2635 (WebCore::AsyncFileSystemChromium::copy):
2636 (WebCore::AsyncFileSystemChromium::remove):
2637 (WebCore::AsyncFileSystemChromium::removeRecursively):
2638 (WebCore::AsyncFileSystemChromium::readMetadata):
2639 (WebCore::AsyncFileSystemChromium::createFile):
2640 (WebCore::AsyncFileSystemChromium::createDirectory):
2641 (WebCore::AsyncFileSystemChromium::fileExists):
2642 (WebCore::AsyncFileSystemChromium::directoryExists):
2643 (WebCore::AsyncFileSystemChromium::readDirectory):
2644 (WebCore::AsyncFileSystemChromium::createWriter):
2645 (WebCore::AsyncFileSystemChromium::createSnapshotFileAndReadMetadata):
2646 * src/AsyncFileSystemChromium.h:
2647 (WebCore::AsyncFileSystemChromium::create):
2648 (AsyncFileSystemChromium):
2649 * src/LocalFileSystemChromium.cpp:
2650 (WebCore::openFileSystemHelper):
2651 * src/PlatformSupport.cpp:
2652 (WebCore::PlatformSupport::createAsyncFileSystem):
2653 * src/WebFileSystemCallbacksImpl.cpp:
2654 (WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl):
2655 (WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem):
2656 * src/WebFileSystemCallbacksImpl.h:
2657 (WebFileSystemCallbacksImpl):
2658 * src/WebFrameImpl.cpp:
2659 (WebKit::WebFrameImpl::createFileSystem):
2660 (WebKit::WebFrameImpl::createFileEntry):
2661 * src/WorkerAsyncFileSystemChromium.cpp:
2662 (WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):
2663 (WebCore::WorkerAsyncFileSystemChromium::move):
2664 (WebCore::WorkerAsyncFileSystemChromium::copy):
2665 (WebCore::WorkerAsyncFileSystemChromium::remove):
2666 (WebCore::WorkerAsyncFileSystemChromium::removeRecursively):
2667 (WebCore::WorkerAsyncFileSystemChromium::readMetadata):
2668 (WebCore::WorkerAsyncFileSystemChromium::createFile):
2669 (WebCore::WorkerAsyncFileSystemChromium::createDirectory):
2670 (WebCore::WorkerAsyncFileSystemChromium::fileExists):
2671 (WebCore::WorkerAsyncFileSystemChromium::directoryExists):
2672 (WebCore::WorkerAsyncFileSystemChromium::readDirectory):
2673 (WebCore::WorkerAsyncFileSystemChromium::createWriter):
2674 (WebCore::WorkerAsyncFileSystemChromium::createSnapshotFileAndReadMetadata):
2675 * src/WorkerAsyncFileSystemChromium.h:
2676 (WebCore::WorkerAsyncFileSystemChromium::create):
2677 (WorkerAsyncFileSystemChromium):
2679 2012-05-07 Greg Billock <gbillock@google.com>
2681 [Web Intents] Flagged-off implementation of an intent tag for registration.
2682 https://bugs.webkit.org/show_bug.cgi?id=73039
2684 Reviewed by Adam Barth.
2686 The intent tag allows web pages to mark themselves declaratively as accepting
2687 web intent delivery of particular characteristics (action/type).
2689 http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html
2692 * src/FrameLoaderClientImpl.cpp:
2693 (WebKit::FrameLoaderClientImpl::registerIntentService):
2694 * src/FrameLoaderClientImpl.h:
2696 2012-05-07 Sheriff Bot <webkit.review.bot@gmail.com>
2698 Unreviewed, rolling out r116375.
2699 http://trac.webkit.org/changeset/116375
2700 https://bugs.webkit.org/show_bug.cgi?id=85850
2702 Build break on Chromium-win and Chromium-mac. (Requested by
2707 * tests/EventListenerTest.cpp: Removed.
2708 * tests/data/listener/mutation_event_listener.html: Removed.
2710 2012-05-07 Dana Jansens <danakj@chromium.org>
2712 Region::intersects() and Region::contains() are slow due to copy overhead
2713 https://bugs.webkit.org/show_bug.cgi?id=81076
2715 Reviewed by Anders Carlsson.
2717 * tests/RegionTest.cpp:
2721 2012-05-07 Tony Chang <tony@chromium.org>
2723 [chromium] move event_listener_unittest to webkit_unit_tests
2724 https://bugs.webkit.org/show_bug.cgi?id=85836
2726 Reviewed by James Robinson.
2728 Porting the test from src/webkit/tools/test_shell/event_listener_unittest.cc.
2729 All I did was change the style and use the FrameTestHelper to load the file.
2731 * WebKit.gyp: Exclude file in components build.
2732 * WebKit.gypi: Add new file.
2733 * tests/EventListenerTest.cpp: Added.
2735 (TestWebDOMEventListener):
2736 (WebKit::TestWebDOMEventListener::TestWebDOMEventListener):
2737 (WebKit::TestWebDOMEventListener::~TestWebDOMEventListener):
2738 (WebKit::TestWebDOMEventListener::eventCount):
2739 (WebKit::TestWebDOMEventListener::eventAt):
2740 (WebKit::TestWebDOMEventListener::clearEvents):
2741 (WebDOMEventListenerTest):
2742 (WebKit::WebDOMEventListenerTest::WebDOMEventListenerTest):
2743 (WebKit::WebDOMEventListenerTest::SetUp):
2744 (WebKit::WebDOMEventListenerTest::TearDown):
2745 (WebKit::WebDOMEventListenerTest::mainFrame):
2746 (WebKit::WebDOMEventListenerTest::document):
2747 (WebKit::WebDOMEventListenerTest::executeScript):
2748 (WebKit::WebDOMEventListenerTest::GetNodeID):
2750 * tests/data/listener/mutation_event_listener.html: Added.
2752 2012-05-07 Julien Chaffraix <jchaffraix@webkit.org>
2754 Refactor windowClipRectForLayer to remove the explicit RenderLayer dependency
2755 https://bugs.webkit.org/show_bug.cgi?id=84090
2757 Reviewed by David Hyatt.
2759 * src/WebPluginContainerImpl.cpp:
2760 Updated after windowClipRectForLayer name and signature change.
2762 2012-05-07 Dana Jansens <danakj@chromium.org>
2764 [chromium] Ensure synchronization in threaded unit tests by checking the sourceFrameNumber() to count commits
2765 https://bugs.webkit.org/show_bug.cgi?id=85390
2767 Reviewed by Adrienne Walker.
2769 * tests/CCLayerTreeHostTest.cpp:
2770 (WTF::CCLayerTreeHostTestScrollMultipleRedraw::beginCommitOnCCThread):
2771 (WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
2772 (WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
2773 (WTF::CCLayerTreeHostTestScrollChildLayer::beginCommitOnCCThread):
2775 2012-05-07 Adrienne Walker <enne@google.com>
2777 [chromium] Allow for asymmetric tile sizes on composited tiled layers
2778 https://bugs.webkit.org/show_bug.cgi?id=85687
2780 Reviewed by James Robinson.
2782 Update tests for new constructor and function args. Add a few more
2783 tests that use non-square tile sizes.
2785 * tests/TilingDataTest.cpp:
2786 (WebCore::TestTiling::TestTiling):
2790 2012-05-07 David Reveman <reveman@chromium.org>
2792 [Chromium] Use GL_CHROMIUM_command_buffer_query to throttle texture uploads.
2793 https://bugs.webkit.org/show_bug.cgi?id=81004
2795 Reviewed by Adrienne Walker.
2798 * tests/CCLayerTreeHostImplTest.cpp:
2799 (WebKitTests::TEST_F):
2800 * tests/CCTiledLayerTestCommon.h:
2801 (WebKitTests::FakeTextureUploader::isBusy):
2802 (WebKitTests::FakeTextureUploader::beginUploads):
2803 (WebKitTests::FakeTextureUploader::endUploads):
2804 * tests/Canvas2DLayerChromiumTest.cpp:
2805 * tests/LayerRendererChromiumTest.cpp:
2806 (FakeLayerRendererChromium::FakeLayerRendererChromium):
2807 (LayerRendererChromiumTest::LayerRendererChromiumTest):
2809 * tests/ThrottledTextureUploaderTest.cpp: Added.
2811 (FakeWebGraphicsContext3DWithQueryTesting):
2812 (WebKit::FakeWebGraphicsContext3DWithQueryTesting::FakeWebGraphicsContext3DWithQueryTesting):
2813 (WebKit::FakeWebGraphicsContext3DWithQueryTesting::getQueryObjectuivEXT):
2814 (WebKit::FakeWebGraphicsContext3DWithQueryTesting::setResultAvailable):
2816 * tests/TiledLayerChromiumTest.cpp:
2819 2012-05-07 Sheriff Bot <webkit.review.bot@gmail.com>
2821 Unreviewed, rolling out r116334.
2822 http://trac.webkit.org/changeset/116334
2823 https://bugs.webkit.org/show_bug.cgi?id=85816
2825 Broke the Chromium Win/Mac compile (Requested by
2826 ojan_gardening on #webkit).
2829 * tests/LinkHighlightLayerDelegateTest.cpp: Removed.
2831 2012-05-07 Mark Pilgrim <pilgrim@chromium.org>
2833 [Chromium] Move fileSystem to Platform.h
2834 https://bugs.webkit.org/show_bug.cgi?id=85760
2836 Reviewed by Adam Barth.
2838 Part of a refactoring series. See tracking bug 82948.
2841 * public/platform/WebFileSystem.h:
2842 * public/platform/WebKitPlatformSupport.h:
2844 (WebKitPlatformSupport):
2845 * src/AssertMatchingEnums.cpp:
2846 * src/AsyncFileSystemChromium.cpp:
2847 (WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium):
2848 * src/LocalFileSystemChromium.cpp:
2849 * src/WebFileSystemCallbacksImpl.cpp:
2850 * src/WebFileSystemCallbacksImpl.h:
2851 * src/WebFrameImpl.cpp:
2852 * src/WebWorkerClientImpl.h:
2853 * src/WorkerAsyncFileSystemChromium.cpp:
2854 * src/WorkerAsyncFileWriterChromium.cpp:
2855 * src/WorkerFileSystemCallbacksBridge.h:
2856 * src/WorkerFileWriterCallbacksBridge.cpp:
2857 (WebKit::WorkerFileWriterCallbacksBridge::initOnMainThread):
2859 2012-05-07 W. James MacLean <wjmaclean@chromium.org>
2861 [chromium] Create LinkHighlightLayerChromium class to provide link-highlight preview animations for GraphicsLayerChromium.
2862 https://bugs.webkit.org/show_bug.cgi?id=85084
2864 Reviewed by Adrienne Walker.
2867 * tests/LinkHighlightLayerDelegateTest.cpp: Added.
2869 (MockGraphicsLayerClient):
2870 (WebCore::MockGraphicsLayerClient::notifyAnimationStarted):
2871 (WebCore::MockGraphicsLayerClient::notifySyncRequired):
2872 (WebCore::MockGraphicsLayerClient::paintContents):
2873 (WebCore::MockGraphicsLayerClient::showDebugBorders):
2874 (WebCore::MockGraphicsLayerClient::showRepaintCounter):
2877 2012-05-07 Joshua Bell <jsbell@chromium.org>
2879 IndexedDB: LevelDB coding for bools is broken
2880 https://bugs.webkit.org/show_bug.cgi?id=85810
2882 Reviewed by Tony Chang.
2884 Added tests for encodeBool/decodeBool.
2886 * tests/IDBLevelDBCodingTest.cpp:
2887 (IDBLevelDBCoding::TEST):
2890 2012-05-07 Shawn Singh <shawnsingh@chromium.org>
2892 [chromium] CCMathUtil projectPoint needs to avoid divide-by-zero
2893 https://bugs.webkit.org/show_bug.cgi?id=85560
2895 Reviewed by Adrienne Walker.
2897 * tests/CCLayerTreeHostCommonTest.cpp:
2898 (WebKitTests::TEST):
2899 * tests/CCMathUtilTest.cpp:
2903 2012-05-07 Nat Duca <nduca@chromium.org>
2905 Unreviewed, rolling out r115525.
2906 http://trac.webkit.org/changeset/115525
2907 https://bugs.webkit.org/show_bug.cgi?id=66683
2909 Too many pages rely on DOMTimeStamp as first argument.
2910 Reverting while we consider next steps.
2912 * src/PageWidgetDelegate.cpp:
2913 (WebKit::PageWidgetDelegate::animate):
2914 * src/WebViewImpl.cpp:
2915 (WebKit::WebViewImpl::updateAnimations):
2917 2012-05-07 Tommy Widenflycht <tommyw@google.com>
2919 MediaStream API: Allow UserMediaRequest::succeed to take an MediaStreamDescriptor
2920 https://bugs.webkit.org/show_bug.cgi?id=85798
2922 Reviewed by Adam Barth.
2924 Adding another WebUserMediaRequest::requestSucceed function that takes an
2925 WebMediaStreamDescriptor instead of the two WebMediaStreamSource arrays.
2927 * public/WebUserMediaRequest.h:
2929 (WebUserMediaRequest):
2930 * src/WebUserMediaRequest.cpp:
2931 (WebKit::WebUserMediaRequest::requestSucceeded):
2933 2012-05-07 Kinuko Yasuda <kinuko@chromium.org>
2935 Unreviewed: the same fix in another file for chromium win build. Adding WebCore namespace to FileSystemTypes.
2937 * src/WebFrameImpl.cpp:
2938 (WebKit::WebFrameImpl::createFileSystem):
2939 (WebKit::WebFrameImpl::createFileEntry):
2941 2012-05-07 Kinuko Yasuda <kinuko@chromium.org>
2943 Not reviewed: chromium win build fix attempt; adding WebCore namespace to ambiguous type name.
2945 * src/WebFileSystemCallbacksImpl.cpp:
2946 (WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl):
2948 2012-05-06 Kinuko Yasuda <kinuko@chromium.org>
2950 Cleanup: Change boolean synchronous flag argument into enum in FileSystem API code
2951 https://bugs.webkit.org/show_bug.cgi?id=85741
2953 Reviewed by David Levin.
2955 * src/LocalFileSystemChromium.cpp:
2956 (WebCore::openFileSystemHelper):
2957 (WebCore::LocalFileSystem::readFileSystem):
2958 (WebCore::LocalFileSystem::requestFileSystem):
2959 * src/WebFileSystemCallbacksImpl.cpp:
2960 (WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl):
2961 (WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem):
2962 * src/WebFileSystemCallbacksImpl.h:
2963 (WebFileSystemCallbacksImpl):
2964 * src/WorkerAsyncFileSystemChromium.cpp:
2965 (WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):
2966 (WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge):
2967 * src/WorkerAsyncFileSystemChromium.h:
2968 (WebCore::WorkerAsyncFileSystemChromium::create):
2969 (WorkerAsyncFileSystemChromium):
2971 2012-05-06 Kinuko Yasuda <kinuko@chromium.org>
2973 Cleanup: Move FileSystem API type definitions into a separate header file
2974 https://bugs.webkit.org/show_bug.cgi?id=85738
2976 Reviewed by David Levin.
2978 Move FileSystem API type definitions from AsyncFileSystem.h and
2979 AsyncFileSystemChromium.cpp for chromium port into a single separate
2980 header file: FileSystemType.h
2982 By doing this we make it clearer that every filesystem type can be
2983 found in the header file and also can save including entire
2984 AsyncFileSystem definition just for referring type enum value.
2986 * src/AssertMatchingEnums.cpp:
2987 * src/AsyncFileSystemChromium.cpp:
2988 (WebCore::AsyncFileSystem::crackFileSystemURL):
2989 (WebCore::AsyncFileSystem::isValidType):
2990 (WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium):
2991 (WebCore::AsyncFileSystemChromium::createIsolatedFileSystem):
2992 (WebCore::AsyncFileSystemChromium::toURL):
2993 * src/AsyncFileSystemChromium.h:
2994 (WebCore::AsyncFileSystemChromium::create):
2995 (AsyncFileSystemChromium):
2996 * src/LocalFileSystemChromium.cpp:
2997 (WebCore::openFileSystemHelper):
2998 (WebCore::LocalFileSystem::readFileSystem):
2999 (WebCore::LocalFileSystem::requestFileSystem):
3000 * src/WebFileSystemCallbacksImpl.cpp:
3001 (WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl):
3002 * src/WebFileSystemCallbacksImpl.h:
3003 (WebFileSystemCallbacksImpl):
3004 * src/WebFrameImpl.cpp:
3005 (WebKit::WebFrameImpl::createFileSystem):
3006 (WebKit::WebFrameImpl::createFileEntry):
3007 * src/WorkerAsyncFileSystemChromium.cpp:
3008 (WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):
3009 * src/WorkerAsyncFileSystemChromium.h:
3010 (WebCore::WorkerAsyncFileSystemChromium::create):
3011 (WorkerAsyncFileSystemChromium):
3013 2012-05-06 Kinuko Yasuda <kinuko@chromium.org>
3015 Cleanup: FileSystem API's Entry.toURL() impl should return KURL instead of String
3016 https://bugs.webkit.org/show_bug.cgi?id=85736
3018 Reviewed by David Levin.
3020 Change AsyncFileSystemChromium::toURL()'s return type from String to KURL.
3022 * src/AsyncFileSystemChromium.cpp:
3023 (WebCore::AsyncFileSystemChromium::toURL):
3025 * src/AsyncFileSystemChromium.h:
3026 (AsyncFileSystemChromium):
3028 2012-05-06 Mark Pilgrim <pilgrim@chromium.org>
3030 [Chromium] Call currentThread through Platform.h directly
3031 https://bugs.webkit.org/show_bug.cgi?id=85769
3033 Reviewed by Kentaro Hara.
3035 Part of a refactoring series. See tracking bug 82948.
3037 * tests/CCLayerTreeHostTest.cpp:
3038 (WTF::CCLayerTreeHostTest::onEndTest):
3039 (WTF::CCLayerTreeHostTest::runTest):
3041 2012-05-06 Mark Pilgrim <pilgrim@chromium.org>
3043 [Chromium] Call cryptographicallyRandomValues through Platform.h
3044 https://bugs.webkit.org/show_bug.cgi?id=85763
3046 Reviewed by Adam Barth.
3048 Part of a refactoring series. See tracking bug 82948.
3050 * src/ChromiumOSRandomSource.cpp:
3051 (WTF::cryptographicallyRandomValuesFromOS):
3053 2012-05-06 Keishi Hattori <keishi@webkit.org>
3055 [chromium] Add WebKit API to access multiple attribute of input element
3056 https://bugs.webkit.org/show_bug.cgi?id=85355
3058 Reviewed by Kent Tamura.
3060 We need this to implement the datalist UI for <input type=email multiple>.
3062 * public/WebInputElement.h:
3064 * src/WebInputElement.cpp:
3065 (WebKit::WebInputElement::isMultiple):
3068 2012-05-06 Adam Barth <abarth@webkit.org>
3070 CSP should let sites both enforce one policy and monitor another
3071 https://bugs.webkit.org/show_bug.cgi?id=85561
3073 Reviewed by Eric Seidel.
3075 * src/SharedWorkerRepository.cpp:
3076 (WebCore::SharedWorkerScriptLoader::notifyFinished):
3077 * src/WebWorkerClientImpl.cpp:
3078 (WebKit::WebWorkerClientImpl::startWorkerContext):
3080 2012-05-06 Kent Tamura <tkent@chromium.org>
3082 Rename ICULocale to LocaleICU, part 2
3083 https://bugs.webkit.org/show_bug.cgi?id=85695
3085 Reviewed by Kentaro Hara.
3087 * tests/LocalizedNumberICUTest.cpp:
3088 (testNumberIsReversible): Rename ICULocale to LocaleICU.
3090 2012-05-06 Adrienne Walker <enne@google.com>
3092 [chromium] Allow WebMediaPlayerClientImpl to switch clients
3093 https://bugs.webkit.org/show_bug.cgi?id=85093
3095 Reviewed by James Robinson.
3097 WebVideoFrameProviderClient has a 1:1 relationship with a
3098 WebVideoFrameProvider. The client here is CCVideoLayerImpl and the
3099 provider is WebMediaPlayerClientImpl. If the provider gets a new
3100 client, then the old client needs to be informed to stop using the
3103 If this doesn't happen, then the old client will have an unsafe
3104 pointer to the provider, will not get informed if the provider gets
3105 deleted, and the client will crash when it dereferences the provider
3106 pointer trying to tell the provider that its client is going away.
3108 Test: WebMediaPlayerClientImplTest.InitialNullVideoClient
3109 WebMediaPlayerClientImplTest.SetAndUnsetVideoClient
3110 WebMediaPlayerClientImplTest.DestroyProvider
3111 WebMediaPlayerClientImplTest.SetMultipleVideoClients
3114 * src/WebMediaPlayerClientImpl.cpp:
3115 (WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):
3116 * src/WebMediaPlayerClientImpl.h:
3117 (WebMediaPlayerClientImpl):
3118 * tests/WebMediaPlayerClientImplTest.cpp: Added.
3120 (FakeWebMediaPlayerClientImpl):
3121 (WebKit::FakeWebMediaPlayerClientImpl::create):
3122 (WebKit::FakeWebMediaPlayerClientImpl::FakeWebMediaPlayerClientImpl):
3123 (FakeVideoFrameProviderClient):
3124 (WebKit::FakeVideoFrameProviderClient::create):
3125 (WebKit::FakeVideoFrameProviderClient::~FakeVideoFrameProviderClient):
3126 (WebKit::FakeVideoFrameProviderClient::didReceiveFrame):
3127 (WebKit::FakeVideoFrameProviderClient::didUpdateMatrix):
3128 (WebKit::FakeVideoFrameProviderClient::stopUsingProvider):
3129 (WebKit::FakeVideoFrameProviderClient::provider):
3130 (WebKit::FakeVideoFrameProviderClient::FakeVideoFrameProviderClient):
3133 2012-05-06 Sheriff Bot <webkit.review.bot@gmail.com>
3135 Unreviewed. Rolled DEPS.
3139 2012-05-06 Andrey Kosyakov <caseq@chromium.org>
3141 Web Inspector: take timeline frame mode out of experimental
3142 https://bugs.webkit.org/show_bug.cgi?id=85707
3144 Reviewed by Pavel Feldman.
3146 - exposed supportFrameInstrumentation method to InspectorClient. Client must return true iff the platform will call
3147 InspectorInstrumentation::instrumentBeginFrame() upon beginning of frame rendering;
3149 * src/InspectorClientImpl.cpp:
3150 (WebKit::InspectorClientImpl::supportsFrameInstrumentation):
3152 * src/InspectorClientImpl.h:
3153 (InspectorClientImpl):
3155 2012-05-04 Kent Tamura <tkent@chromium.org>
3157 Rename ICULocale to LocaleICU, part 1
3158 https://bugs.webkit.org/show_bug.cgi?id=85688
3160 Reviewed by Kentaro Hara.
3162 * tests/LocalizedNumberICUTest.cpp: Rename ICULocale.h to LocaleICU.h.
3164 2012-05-04 Shawn Singh <shawnsingh@chromium.org>
3166 [chromium] Changes to layer tree structure need to be tracked properly
3167 https://bugs.webkit.org/show_bug.cgi?id=85421
3169 Reviewed by Adrienne Walker.
3171 Unit test added: TreeSynchronizerTest.syncSimpleTreeAndTrackStackingOrderChange
3173 * tests/TreeSynchronizerTest.cpp:
3175 (WebKitTests::TEST):
3177 2012-05-04 Tony Chang <tony@chromium.org>
3179 [chromium] enable msvs_error_on_missing_sources at gyp time
3180 https://bugs.webkit.org/show_bug.cgi?id=85683
3182 Reviewed by Adam Barth.
3184 This flag checks for missing files, which cause compile times to be
3185 slow on Windows. Since this flag is on by default for the
3186 build.chromium.org bots, we should add it here too so everyone can fix
3189 * DEPS: Roll to a chromium version that has no missing files.
3190 * gyp_webkit: Add the flag.
3192 2012-05-04 Satoru Takabayashi <satorux@chromium.org>
3194 [chromium] Add plumbing for file display names for drag and drop
3195 https://bugs.webkit.org/show_bug.cgi?id=85673
3197 Reviewed by Darin Fisher.
3199 * public/platform/WebDragData.h:
3200 * src/WebDragData.cpp:
3201 (WebKit::WebDragData::items):
3202 (WebKit::WebDragData::addItem):
3204 2012-05-04 Adam Barth <abarth@webkit.org>
3206 Refactor CSP state to prepare for having both a ReportOnly and an Enforced policy
3207 https://bugs.webkit.org/show_bug.cgi?id=85662
3209 Reviewed by Eric Seidel.
3211 Update callers to the new function name.
3213 * src/SharedWorkerRepository.cpp:
3214 (WebCore::SharedWorkerScriptLoader::notifyFinished):
3215 * src/WebWorkerClientImpl.cpp:
3216 (WebKit::WebWorkerClientImpl::startWorkerContext):
3218 2012-05-04 Sami Kyostila <skyostil@chromium.org>
3220 [chromium] Revert compositor layer scrolling
3221 https://bugs.webkit.org/show_bug.cgi?id=85644
3223 Reviewed by Steve Block.
3225 * src/WebContentLayerImpl.cpp:
3226 * src/WebContentLayerImpl.h:
3227 (WebContentLayerImpl):
3228 * tests/CCLayerTreeHostCommonTest.cpp:
3229 * tests/CCLayerTreeHostImplTest.cpp:
3230 (WebKitTests::TEST_F):
3231 * tests/CCLayerTreeHostTest.cpp:
3232 (WTF::MockContentLayerDelegate::paintContents):
3234 2012-05-04 Tommy Widenflycht <tommyw@google.com>
3236 MediaStream API: Make PeerConnection00's API fully compliant with the draft
3237 https://bugs.webkit.org/show_bug.cgi?id=85491
3239 Reviewed by Adam Barth.
3241 * src/AssertMatchingEnums.cpp:
3243 2012-05-04 Nate Chapin <japhet@chromium.org>
3245 Don't require FrameLoaderClient to manufacture a commitData() call for empty documents.
3246 https://bugs.webkit.org/show_bug.cgi?id=85533
3248 Reviewed by Alexey Proskuryakov.
3250 * src/FrameLoaderClientImpl.cpp:
3251 (WebKit::FrameLoaderClientImpl::FrameLoaderClientImpl):
3253 (WebKit::FrameLoaderClientImpl::finishedLoading):
3254 * src/FrameLoaderClientImpl.h:
3255 (WebKit::FrameLoaderClientImpl::makeRepresentation):
3256 (WebKit::FrameLoaderClientImpl::revertToProvisionalState):
3257 (FrameLoaderClientImpl):
3259 2012-05-04 Alexander Pavlov <apavlov@chromium.org>
3261 Web Inspector: [Device Metrics] With "Fit window" option on, page contents are downscaled incorrectly
3262 https://bugs.webkit.org/show_bug.cgi?id=85510
3264 Reviewed by Pavel Feldman.
3266 Use the RenderView width rather than FrameView contents width whenever possible.
3267 Drive-by: add protection from division-by-zero (for some weird rendering states).
3269 Test: inspector/styles/device-metrics-fit-window.html
3271 * src/WebDevToolsAgentImpl.cpp:
3272 (WebKit::DeviceMetricsSupport::ensureOriginalZoomFactor):
3273 (WebKit::DeviceMetricsSupport::scaledEmulatedFrameSize):
3275 2012-05-03 W. James MacLean <wjmaclean@chromium.org>
3277 [chromium] Revise touchpad fling curve to use exponential curve, to improve feel and small fling performance.
3278 https://bugs.webkit.org/show_bug.cgi?id=85530
3280 Reviewed by Kenneth Russell.
3282 * tests/PlatformGestureCurveTest.cpp:
3284 2012-05-03 Dimitri Glazkov <dglazkov@chromium.org>
3286 [Chromium] Use correct define in the features.gypi
3287 https://bugs.webkit.org/show_bug.cgi?id=85520
3289 Patch by Ben Goodger.
3291 Reviewed by Tony Chang.
3293 * features.gypi: Replaced use_aura with a more appropriate chromeos
3295 2012-05-03 Antony Sargent <asargent@chromium.org>
3297 Add methods to create WebArrayBuffer/WebArrayBufferView from v8 objects
3298 https://bugs.webkit.org/show_bug.cgi?id=84899
3300 Reviewed by Adam Barth.
3302 * public/WebArrayBuffer.h:
3304 * public/platform/WebArrayBufferView.h:
3306 (WebArrayBufferView):
3307 * src/WebArrayBuffer.cpp:
3309 (WebKit::WebArrayBuffer::createFromV8Value):
3310 * src/WebArrayBufferView.cpp:
3312 (WebKit::WebArrayBufferView::createFromV8Value):
3314 2012-05-03 Dana Jansens <danakj@chromium.org>
3316 [chromium] Don't add small opaque areas to the occlusion tracker's Region
3317 https://bugs.webkit.org/show_bug.cgi?id=85297
3319 Reviewed by Adrienne Walker.
3321 * tests/CCOcclusionTrackerTest.cpp:
3323 (CCOcclusionTrackerTestMinimumTrackingSize):
3324 (WebKitTests::CCOcclusionTrackerTestMinimumTrackingSize::runMyTest):
3326 2012-05-02 Jon Lee <jonlee@apple.com>
3328 Migrate permission functions to Notification from NotificationCenter
3329 https://bugs.webkit.org/show_bug.cgi?id=80485
3330 <rdar://problem/10965458>
3332 Reviewed by Jian Li.
3334 * src/NotificationPresenterImpl.h:
3335 (NotificationPresenterImpl): Add stub implementation of requestPermission.
3336 (WebKit::NotificationPresenterImpl::requestPermission):
3338 2012-05-02 Dana Jansens <danakj@chromium.org>
3340 [chromium] Don't occlude pixels in a surface that are needed for a background filter blur
3341 https://bugs.webkit.org/show_bug.cgi?id=84317
3343 Reviewed by Adrienne Walker.
3345 * tests/CCOcclusionTrackerTest.cpp:
3346 (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
3347 (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
3348 (WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
3349 (WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
3350 (WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
3351 (WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest):
3352 (WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest):
3353 (WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest):
3354 (WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):
3355 (WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest):
3357 (CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter):
3358 (WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter::runMyTest):
3359 (CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice):
3360 (WebKitTests::CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice::runMyTest):
3361 (CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilterWithClip):