[BlackBerry] Syncing up left over bits in Api from our local branch to upstream
[WebKit-https.git] / Source / WebKit / blackberry / ChangeLog
1 2012-03-16  Nima Ghanavatian  <nghanavatian@rim.com>
2
3         [BlackBerry] Syncing up left over bits in Api from our local branch to upstream
4         https://bugs.webkit.org/show_bug.cgi?id=81105
5
6         Reviewed by Rob Buis.
7
8         This patches fixes up a previous sync done in this directory and adds some new bits
9         as well.  This is accurate as of ddea1528b37b29925638fe1183318b3c3994f1f8 in our
10         local repo.
11
12         * Api/BackingStore.cpp:
13         (BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
14         (WebKit):
15         (BlackBerry::WebKit::BackingStorePrivate::drawLayersOnCommitIfNeeded):
16         * Api/WebPage.cpp:
17         (BlackBerry::WebKit::WebPagePrivate::webContext):
18         (BlackBerry::WebKit::WebPage::webContext):
19         (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
20         * Api/WebPage.h:
21         * Api/WebPage_p.h:
22         (WebPagePrivate):
23
24 2012-03-16  Mike Fenton  <mifenton@rim.com>
25
26         [BlackBerry] Input processing mode should be cancelled when processing hot keys
27         https://bugs.webkit.org/show_bug.cgi?id=81348
28
29         Reviewed by Rob Buis.
30
31         Don't suppress IMF notifications if we are handling
32         the event as a hotkey.
33
34         Reviewed Internally by Nima Ghanavatian.
35
36         * WebCoreSupport/EditorClientBlackBerry.cpp:
37         (WebCore::EditorClientBlackBerry::handleKeyboardEvent):
38
39 2012-03-16  Robin Cao  <robin.cao@torchmobile.com.cn>
40
41         [BlackBerry] Can not open certain links from bridge applications
42         https://bugs.webkit.org/show_bug.cgi?id=81197
43
44         Reviewed by Rob Buis.
45
46         Currently, the engine asks the client to handle some type of requests externally.
47         But WebPageClient::handleStringPattern is not yet implemented and exposed to
48         the client. Before that, we still need to give the client a chance to decide
49         how to handle requests such as 'mailto:'.
50
51         To address this problem, r108763 introduced a change that ask the client to
52         decide how to handle the navigation in dispatchDecidePolicyForNewWindowAction().
53         This is not intuitive and will bring troubles, because this navigation will
54         happen in the new page. So the new page client is to decide how to handle
55         the navigation, not the old one.
56
57         This patch reverts r108763 and skips calling WebPageClient::handleStringPattern
58         since it's not implemented.
59
60         This way the new window action will continue, and the logic in
61         dispatchDecidePolicyForNavigationAction() will handle the navigation correctly.
62
63         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
64         (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
65         (WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):
66
67 2012-03-16  Leo Yang  <leo.yang@torchmobile.com.cn>
68
69         [BlackBerry] Crash when going back from an xhtml document containing <img>
70         https://bugs.webkit.org/show_bug.cgi?id=81297
71
72         Reviewed by Rob Buis.
73
74         This is manually reverting the offending internal commit which checked-in before upstreaming.
75
76         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
77         (WebCore::FrameLoaderClientBlackBerry::canCachePage):
78
79 2012-03-16  Genevieve Mak  <gmak@rim.com>
80
81         [BlackBerry] viewportRect has changed to viewportSize
82         https://bugs.webkit.org/show_bug.cgi?id=81262
83
84         Reviewed by Antonio Gomes.
85
86         Set size instead of rect in constructor.
87         * WebKitSupport/InRegionScrollableArea.cpp:
88         (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
89
90 2012-03-16  Andrew Lo  <anlo@rim.com>
91
92         [BlackBerry] Enable PAGE_VISIBILITY_API
93         https://bugs.webkit.org/show_bug.cgi?id=81257
94
95         Set Page visibility state for BlackBerry port.
96
97         Reviewed by Rob Buis.
98
99         * Api/WebPage.cpp:
100         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
101         (WebKit):
102         (BlackBerry::WebKit::WebPagePrivate::setPageVisibilityState):
103         (BlackBerry::WebKit::WebPagePrivate::setVisible):
104         (BlackBerry::WebKit::WebPage::setVisible):
105         (BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
106         (BlackBerry::WebKit::WebPage::notifyAppActivationStateChange):
107         * Api/WebPage_p.h:
108         (WebPagePrivate):
109
110 2012-03-14  Arvid Nilsson  <anilsson@rim.com>
111
112         [BlackBerry] Make sure WebPage and BackingStore don't crash without a Window
113         https://bugs.webkit.org/show_bug.cgi?id=81099
114
115         Reviewed by Rob Buis.
116
117         Also rename the "compositing/blitting to main window" variables to
118         instead refer to OpenGL compositing. The code paths it triggers are
119         related to the BackingStore using OpenGL compositing, and can be useful
120         even when there's no window.
121
122         * Api/BackingStore.cpp:
123         (BlackBerry::WebKit::BackingStorePrivate::isOpenGLCompositing):
124         (BlackBerry::WebKit::BackingStorePrivate::render):
125         (BlackBerry::WebKit::BackingStorePrivate::copyPreviousContentsToBackSurfaceOfWindow):
126         (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
127         (BlackBerry::WebKit::BackingStorePrivate::blitContents):
128         (BlackBerry::WebKit::BackingStorePrivate::blitTileRect):
129         (BlackBerry::WebKit::BackingStorePrivate::blendCompositingSurface):
130         (BlackBerry::WebKit::BackingStorePrivate::renderContents):
131         (BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
132         (BlackBerry::WebKit::BackingStorePrivate::checkerWindow):
133         (BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
134         (BlackBerry::WebKit::BackingStorePrivate::clearWindow):
135         (BlackBerry::WebKit::BackingStorePrivate::drawSubLayers):
136         (BlackBerry::WebKit::BackingStorePrivate::surfaceSize):
137         (BlackBerry::WebKit::BackingStorePrivate::buffer):
138         * Api/BackingStore_p.h:
139         * Api/WebPage.cpp:
140         (BlackBerry::WebKit::WebPagePrivate::didPluginEnterFullScreen):
141         (BlackBerry::WebKit::WebPagePrivate::didPluginExitFullScreen):
142         (BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):
143         (BlackBerry::WebKit::WebPagePrivate::drawSubLayers):
144         (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
145         * WebCoreSupport/ChromeClientBlackBerry.cpp:
146         (WebCore::ChromeClientBlackBerry::windowRect):
147         (WebCore::ChromeClientBlackBerry::screenToWindow):
148         (WebCore::ChromeClientBlackBerry::windowToScreen):
149         * WebKitSupport/GLES2Context.cpp:
150         (BlackBerry::WebKit::GLES2Context::GLES2Context):
151         * WebKitSupport/TouchEventHandler.h:
152         * WebKitSupport/WebPageCompositor.cpp:
153         (BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
154         (BlackBerry::WebKit::WebPageCompositor::setBackingStoreUsesOpenGL):
155         (BlackBerry::WebKit::WebPageCompositor::drawLayers):
156         * WebKitSupport/WebPageCompositor.h:
157
158 2012-03-13  Jon Lee  <jonlee@apple.com>
159
160         Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
161         https://bugs.webkit.org/show_bug.cgi?id=80922
162         <rdar://problem/11035082>
163
164         Reviewed by Jian Li.
165
166         You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
167         LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
168         new API. Therefore, APIs that are common between the two will have:
169         #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
170
171         This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
172         the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
173
174         Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
175         * Api/WebPage.cpp:
176         (BlackBerry::WebKit::WebPagePrivate::init):
177         * WebCoreSupport/NotificationPresenterImpl.cpp:
178         * WebCoreSupport/NotificationPresenterImpl.h:
179
180 2012-03-14  Nima Ghanavatian  <nghanavatian@rim.com>
181
182         [BlackBerry] Syncing up left over bits in Api from our local branch to upstream
183         https://bugs.webkit.org/show_bug.cgi?id=81105
184
185         Reviewed by Rob Buis.
186
187         * Api/BackingStore.cpp:
188         (BlackBerry::WebKit::BackingStorePrivate::renderContents):
189         (BlackBerry::WebKit::BackingStorePrivate::isActive):
190         (BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
191         (WebKit):
192         (BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):
193         * Api/BackingStore.h:
194         * Api/WebPage.cpp:
195         (BlackBerry::WebKit::toWebCoreMouseEventType):
196         (BlackBerry::WebKit::WebPagePrivate::init):
197         (BlackBerry::WebKit::WebPagePrivate::setLoadState):
198         (BlackBerry::WebKit::WebPagePrivate::activeNodeContext):
199         (BlackBerry::WebKit::WebPage::activeNodeContext):
200         (BlackBerry::WebKit::WebPagePrivate::updateCursor):
201         (BlackBerry::WebKit::WebPagePrivate::contextNode):
202         (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
203         * Api/WebPage.h:
204         * Api/WebPage_p.h:
205         (WebPagePrivate):
206
207 2012-03-14  Andrew Lo  <anlo@rim.com>
208
209         [BlackBerry] Implement REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR using AnimationFrameRateController
210         https://bugs.webkit.org/show_bug.cgi?id=81000
211
212         Set the platform display ID, needed for DisplayRefreshMonitor.
213
214         Reviewed by Antonio Gomes.
215
216         * Api/WebPage.cpp:
217         (BlackBerry::WebKit::WebPagePrivate::init):
218
219 2012-03-14  Leo Yang  <leo.yang@torchmobile.com.cn>
220
221         [BlackBerry] Upstream the BlackBerry change to platform/Cursor.h
222         https://bugs.webkit.org/show_bug.cgi?id=81086
223
224         Reviewed by Rob Buis.
225
226         There was an alias named PlatformCursorHandle for PlatformCursor
227         in the internal version of Cursor.h. But it's not necessary so it's
228         not included in the upstreaming version of Cursor.h. As a result,
229         use PlatformCursor directly.
230
231         * Api/WebPage.cpp:
232         (BlackBerry::WebKit::WebPagePrivate::setCursor):
233         * Api/WebPage_p.h:
234         (WebPagePrivate):
235
236 2012-03-13  Mike Fenton  <mifenton@rim.com>
237
238         [BlackBerry] Input focus state should unfocus the frame selection instead of the field.
239         https://bugs.webkit.org/show_bug.cgi?id=81023
240
241         Reviewed by Antonio Gomes.
242
243         PR 137400.
244
245         Prevent cursor drawing by unfocusing the frame selection
246         when input mode is not ready.
247
248         Greatly simplify the decision to focus input fields by removing
249         all ties to the page load state and base it on input.  Input mode
250         is disabled when a page load begins and enabled on any user input.
251
252         The field is focused and ready for input immediately, only the
253         frame selection (or cursor) is unfocused.
254
255         Reviewed Internally by Gen Mak, Antonio Gomes and Nima Ghanavatian.
256
257         * Api/WebPage.cpp:
258         (BlackBerry::WebKit::WebPagePrivate::setLoadState):
259         (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
260         * Api/WebPageClient.h:
261         * WebCoreSupport/EditorClientBlackBerry.cpp:
262         (WebCore::EditorClientBlackBerry::shouldBeginEditing):
263         * WebKitSupport/InputHandler.cpp:
264         (BlackBerry::WebKit::InputHandler::InputHandler):
265         (BlackBerry::WebKit::InputHandler::setElementUnfocused):
266         (BlackBerry::WebKit::InputHandler::enableInputMode):
267         (BlackBerry::WebKit::InputHandler::setElementFocused):
268         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
269         (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
270         (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
271         (BlackBerry::WebKit::InputHandler::setComposingText):
272         * WebKitSupport/InputHandler.h:
273         (InputHandler):
274         * WebKitSupport/TouchEventHandler.cpp:
275         (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
276
277 2012-03-13  Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>
278
279         Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
280         https://bugs.webkit.org/show_bug.cgi?id=78853
281
282         Reviewed by Adam Barth.
283
284         * Api/WebPage.cpp:
285         (BlackBerry::WebKit::WebPagePrivate::init):
286         * WebCoreSupport/AboutDataEnableFeatures.in:
287         * WebCoreSupport/ChromeClientBlackBerry.cpp:
288         * WebCoreSupport/ChromeClientBlackBerry.h:
289         (ChromeClientBlackBerry):
290         * WebKitSupport/DumpRenderTreeSupport.cpp:
291         (toGeolocationClientMock):
292         (DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
293         (DumpRenderTreeSupport::resetGeolocationMock):
294         (DumpRenderTreeSupport::setMockGeolocationError):
295         (DumpRenderTreeSupport::setMockGeolocationPermission):
296         (DumpRenderTreeSupport::setMockGeolocationPosition):
297
298 2012-03-13  Mike Lattanzio  <mlattanzio@rim.com>
299
300         Remove ActiveNodeContext in favour of BlackBerry::Platform::WebContext
301         https://bugs.webkit.org/show_bug.cgi?id=80984
302
303         Remove ActiveNodeContext, and switch the implementation to
304         provide a BlackBerry::Platform::WebContext. The new object
305         adds an explicit IsImage flag, as well as IsAudio and IsVideo
306         for the HTML5 elements.
307
308         Note that for many videos both IsVideo and IsAudio will be true,
309         as videos typically have audio streams as well.
310
311         Reviewed by George Staikos.
312
313         * Api/ActiveNodeContext.h: Removed.
314         * Api/WebPage.cpp:
315         (BlackBerry::WebKit::WebPagePrivate::webContext):
316         (BlackBerry::WebKit::WebPage::webContext):
317         * Api/WebPage.h:
318         * Api/WebPage_p.h:
319
320 2012-03-12  Andy Chen  <andchen@rim.com>
321
322         [Blackberry] Make the process of marking all matches interruptible and asynchronous for find-in-page
323         https://bugs.webkit.org/show_bug.cgi?id=80831
324
325         Reviewed by Antonio Gomes.
326
327         * WebKitSupport/InPageSearchManager.cpp:
328         (BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::DeferredScopeStringMatches):
329         (BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::doTimeout):
330         (BlackBerry::WebKit::InPageSearchManager::InPageSearchManager):
331         (BlackBerry::WebKit::InPageSearchManager::~InPageSearchManager):
332         (BlackBerry::WebKit::InPageSearchManager::findNextString):
333         (BlackBerry::WebKit::InPageSearchManager::shouldSearchForText):
334         (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
335         (BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
336         (BlackBerry::WebKit::InPageSearchManager::frameUnloaded):
337         (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
338         (BlackBerry::WebKit::InPageSearchManager::scopeStringMatchesSoon):
339         (BlackBerry::WebKit::InPageSearchManager::callScopeStringMatches):
340         (BlackBerry::WebKit::InPageSearchManager::cancelPendingScopingEffort):
341         * WebKitSupport/InPageSearchManager.h:
342
343 2012-03-09  Jon Lee  <jonlee@apple.com>
344
345         Rename NotificationPresenter to NotificationClient
346         https://bugs.webkit.org/show_bug.cgi?id=80488
347         <rdar://problem/10965558>
348
349         Reviewed by Kentaro Hara.
350
351         Refactor to use renamed WebCore::NotificationClient.
352         * WebCoreSupport/NotificationPresenterImpl.cpp:
353         (WebCore::NotificationPresenterImpl::instance):
354         (WebCore::NotificationPresenterImpl::show):
355         (WebCore::NotificationPresenterImpl::checkPermission):
356         * WebCoreSupport/NotificationPresenterImpl.h:
357         (NotificationPresenterImpl):
358
359 2012-03-09  Charles Wei  <charles.wei@torchmobile.com.cn>
360
361         [BlackBerry] Web Notification not working after rebase
362         https://bugs.webkit.org/show_bug.cgi?id=80690
363
364         Reviewed by George Staikos.
365
366         1. NotificationPresenterImpl should be in namespace WebCore
367         2. Need to connect NotificationPresenterImpl to webcore the new way:
368            WebCore::provideNotification(Page*, NotificationPresenter*)
369         3. Remove the old way of connecting the Notification:
370            ChromeClientBlackBerry::notificationPresenter()
371
372         * Api/WebPage.cpp:
373         (BlackBerry::WebKit::WebPagePrivate::init):
374         * WebCoreSupport/ChromeClientBlackBerry.cpp:
375         (WebCore):
376         * WebCoreSupport/ChromeClientBlackBerry.h:
377         (ChromeClientBlackBerry):
378         * WebCoreSupport/NotificationPresenterImpl.cpp:
379         * WebCoreSupport/NotificationPresenterImpl.h:
380
381 2012-03-08  Mike Fenton  <mifenton@rim.com>
382
383         [BlackBerry] Always use the current focused node when processing focus changes
384         https://bugs.webkit.org/show_bug.cgi?id=80594
385
386         Reviewed by Antonio Gomes.
387
388         Guard against toRange or fromRange being null when called
389         as part of a clear event.
390
391         * WebCoreSupport/EditorClientBlackBerry.cpp:
392         (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
393
394 2012-03-08  Yong Li  <yoli@rim.com>
395
396         [BlackBerry] Block file-to-file access by default
397         https://bugs.webkit.org/show_bug.cgi?id=80605
398
399         Reviewed by Rob Buis.
400
401         Turn off allowFileAccessFromFileURLs() by default.
402
403         * Api/WebPage.cpp:
404         (BlackBerry::WebKit::WebPagePrivate::init):
405
406 2012-03-08  Mike Fenton  <mifenton@rim.com>
407
408         [BlackBerry] Always use the current focused node when processing focus changes
409         https://bugs.webkit.org/show_bug.cgi?id=80594
410
411         Reviewed by Antonio Gomes.
412
413         Update InputHandler focused node handling to strictly use
414         the currently focused node.  This prevents a handling loop
415         when JS is modifying the focus and we get a late notification
416         of a past change from ChromeClientBlackBerry with the previously
417         unfocused node.
418
419         * WebCoreSupport/ChromeClientBlackBerry.cpp:
420         (WebCore::ChromeClientBlackBerry::focusedNodeChanged):
421         * WebCoreSupport/EditorClientBlackBerry.cpp:
422         (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
423         (WebCore::EditorClientBlackBerry::setInputMethodState):
424         * WebKitSupport/InputHandler.cpp:
425         (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
426         * WebKitSupport/InputHandler.h:
427
428 2012-03-07  Jacky Jiang  <zhajiang@rim.com>
429
430         [BlackBerry] WebKit rendering problem when show/hide VKB
431         https://bugs.webkit.org/show_bug.cgi?id=80448
432         RIM PR: 141727
433
434         Reviewed by Antonio Gomes.
435
436         When setting viewport size, layout happens inside
437         WebPagePrivate::setDefaultLayoutSize(), in this way, the layout is
438         outside of the code path of "needsLayout" so that the contents are
439         not rendered into the backing store. This is a regression of r108718,
440         switch back to do the layout inside the public API
441         WebPage::setDefaultLayoutSize().
442
443         We haven't upstreamed the manual tests directory yet, therefore,
444         the new manual test case will be upstreamed later.
445
446         * Api/WebPage.cpp:
447         (BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
448         (BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
449
450 2012-03-06  Lianghui Chen  <liachen@rim.com>
451
452         [BlackBerry] Set correct ResourceRequest target type.
453         https://bugs.webkit.org/show_bug.cgi?id=80430
454
455         Reviewed by Rob Buis.
456
457         Removed unused code in dispatchWillSendRequest(). These codes are too
458         late as the target type has already been referred to when calling
459         ResourceRequest::initializePlatformRequest().
460
461         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
462         (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
463
464 2012-03-06  Lianghui Chen  <liachen@rim.com>
465
466         [BlackBerry] Remove unused and unneeded WebPageClient::downloadRequested(NetworkRequest&)
467         https://bugs.webkit.org/show_bug.cgi?id=80438
468
469         Reviewed by Antonio Gomes.
470
471         * Api/WebPageClient.h:
472
473 2012-03-06  Jakob Petsovits  <jpetsovits@rim.com>
474
475         [BlackBerry] Don't suspend accel comp when backgrounding a page.
476         https://bugs.webkit.org/show_bug.cgi?id=80369
477         RIM PR: 137609
478
479         Reviewed by Adam Treat.
480
481         Just because the page is in the background doesn't mean
482         it's invisible, doesn't mean it won't have to be redrawn
483         at some point - on rotation, for instance.
484
485         We still suspend accelerated compositing on setVisible(false).
486
487         * Api/WebPage.cpp:
488         (BlackBerry::WebKit::WebPage::notifyPageBackground):
489         (BlackBerry::WebKit::WebPage::notifyPageForeground):
490
491 2012-03-06  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
492
493         [BlackBerry] function rename issue after MediaPlayerPrivateBlackBerry.[cpp\h] upstream
494         https://bugs.webkit.org/show_bug.cgi?id=80377
495
496         Reviewed by Rob Buis.
497
498         As some of the function names changed in class MediaPlayerPrivate
499         with the upstream of MediaPlayerPrivateBlackBerry.[cpp|h], we
500         should update WebKit/blackberry/Api/WebPage.cpp which uses these
501         functions accordingly.
502         Renamed functions in class MediaPlayerPrivate:
503         windowGet() -> getWindow()
504         windowPositionGet() -> getWindowPosition()
505         mmrContextNameGet() -> mmrContextName()
506
507         * Api/WebPage.cpp:
508         (BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):
509
510 2012-03-05  Eli Fidler  <efidler@rim.com>
511
512         The minimum font size WebSetting should actually change the LOGICAL font size in WebCore.
513         https://bugs.webkit.org/show_bug.cgi?id=80312
514         RIM PR: 139874
515
516         Reviewed by George Staikos.
517
518         * Api/WebPage.cpp:
519         (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
520
521 2012-03-05  Jakob Petsovits  <jpetsovits@rim.com>
522
523         Make accelerated compositing work again with direct rendering.
524         https://bugs.webkit.org/show_bug.cgi?id=80181
525         RIM PR: 139110
526
527         Reviewed by Antonio Gomes.
528         Internally reviewed by Arvid Nilsson.
529
530         The significant amount of refactoring and optimization work
531         that has gone into accelerated compositing missed out on
532         some of the code paths that are being used in direct rendering.
533
534         Animations were relying on blitVisibleContents() only (which
535         is a no-op in direct rendering mode). There were early returns
536         which are suitable to determine whether screen contents need
537         to be updated at all; however, when we're already forcing a
538         re-render then those checks would cause the composition surface
539         not to appear at all, or avoid drawing new animation frames.
540
541         We went through dispatchMessage(), potentially causing
542         mismatches between rendered (but not yet posted) back content
543         and layers composited on top of it. As we're rendering onto
544         the sole target surface (the window) directly and posting
545         from the same thread, we have to wait for compositing on the
546         UI thread to finish before posting the window.
547
548         In turn, this patch combines both drawSubLayers() and
549         blendCompositingSurface() calls into one method, reducing
550         the number of messages to the UI thread within
551         renderDirectToWindow() to one.
552
553         blendCompositingMessage() in renderDirectToScreen() was called
554         with contents coordinates rather than viewport coordinates.
555         That caused some of the composited content to be cut off when
556         the scroll position wasn't (0, 0).
557
558         We called copyPreviousContentsToBackSurfaceOfWindow() twice for
559         one frame, in both renderDirectToWindow() and invalidateWindow().
560         Only one of those (the latter one) is necessary.
561
562         * Api/BackingStore.cpp:
563         (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
564         (BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
565         (BlackBerry::WebKit::BackingStorePrivate::drawSubLayers):
566         (WebKit):
567         (BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
568         * Api/BackingStore.h:
569         (WebKit):
570         * Api/BackingStore_p.h:
571         (BackingStorePrivate):
572         (BlackBerry::WebKit::BackingStorePrivate::isDirectRenderingAnimationMessageScheduled):
573         (BlackBerry::WebKit::BackingStorePrivate::setDirectRenderingAnimationMessageScheduled):
574         * Api/WebPage_p.h:
575         (BlackBerry::WebKit::WebPagePrivate::isAcceleratedCompositingActive):
576         (WebPagePrivate):
577         * WebKitSupport/WebPageCompositor.cpp:
578         (BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
579         (BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
580         (BlackBerry::WebKit::WebPageCompositor::drawLayers):
581         (BlackBerry::WebKit::WebPageCompositor::animationTimerFired):
582         * WebKitSupport/WebPageCompositor.h:
583         (WebPageCompositor):
584
585 2012-03-05  George Staikos  <gstaikos@rim.com>
586
587         [BlackBerry] DOMSupport visibleSelectionForRangeInputElement incorrectly dereferences a null range.
588         https://bugs.webkit.org/show_bug.cgi?id=80274
589
590         Reviewed by Antonio Gomes.
591
592         A null range can be returned so we should not blindly deref it.
593         Reviewed Internally by Mike Fenton.
594
595         * WebKitSupport/DOMSupport.cpp:
596         (BlackBerry::WebKit::DOMSupport::visibleSelectionForRangeInputElement):
597
598 2012-03-04  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
599
600         [BlackBerry] upstream CredentialManager and CredentialTransformData implementation
601         https://bugs.webkit.org/show_bug.cgi?id=80107
602
603         Reviewed by Antonio Gomes.
604
605         Initial upstream of CredentialManager.[h|cpp] and
606         CredentialTransformData.[h|cpp].
607         No new test.
608
609         * WebCoreSupport/CredentialManager.cpp: Added.
610         (WebCore):
611         (WebCore::CredentialManager::CredentialManager):
612         (WebCore::CredentialManager::autofillAuthenticationChallenge):
613         (WebCore::CredentialManager::autofillPasswordForms):
614         (WebCore::CredentialManager::saveCredentialIfConfirmed):
615         * WebCoreSupport/CredentialManager.h: Added.
616         (WebKit):
617         (WebCore):
618         (CredentialManager):
619         * WebCoreSupport/CredentialTransformData.cpp: Added.
620         (WebCore::CredentialTransformData::CredentialTransformData):
621         (WebCore):
622         (WebCore::CredentialTransformData::url):
623         (WebCore::CredentialTransformData::credential):
624         (WebCore::CredentialTransformData::setCredential):
625         (WebCore::CredentialTransformData::findPasswordFormFields):
626         * WebCoreSupport/CredentialTransformData.h: Added.
627         (WebCore):
628         (CredentialTransformData):
629         (WebCore::CredentialTransformData::isValid):
630         (WebCore::CredentialTransformData::protectionSpace):
631
632 2012-03-04  Antonio Gomes  <agomes@rim.com>
633
634         [BlackBerry] Fixed positioned element not correctly positioned after orientation change, when viewport metatag is used
635         https://bugs.webkit.org/show_bug.cgi?id=80228
636         PR #138865
637
638         Reviewed by George Staikos.
639
640         Viewport size changes in two main scenarios:
641         - orientation changes;
642         - virtual keyboard pop up/hide.
643
644         When we are setting a new viewport size, we need to
645         update the FixedReportedSize of the mainframe. This size
646         is used to return innerWidth|Heigth as well as to calculate
647         the fixed position elements height relative to the RenderView [1].
648
649         [1] RenderBox::containingBlockLogicalHeightForPositioned.
650
651         When we are rotating, we need to delay setting the new FixedReportedSize
652         till we layout and are able to figure out the new contents size. At this
653         time we call setFixedReportedSize, but we do not reposition the fixed elemts
654         afterwards.
655
656         Patch adds a call to FrameView::repaintFixedElementsAfterScrolling, after
657         setting the new size.
658
659         Source/WebKit/blackberry:
660         * Api/WebPage.cpp:
661         (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
662
663 2012-03-02  Mike Fenton  <mifenton@rim.com>
664
665         [BlackBerry] Expose WebInspector state to client and clean up WebSettings
666         https://bugs.webkit.org/show_bug.cgi?id=80177
667
668         Reviewed by Antonio Gomes.
669
670         Expose the Web Inspector state to WebPage client's and
671         re-order initialization of WebSettings to be alphabetical
672         matching their definitions.
673
674         * Api/WebPage.cpp:
675         (BlackBerry::WebKit::WebPage::isWebInspectorEnabled):
676         * Api/WebPage.h:
677         * Api/WebSettings.cpp:
678         (BlackBerry::WebKit::WebSettings::standardSettings):
679
680 2012-03-02  Arvid Nilsson  <anilsson@rim.com>
681
682         Accelerated compositing: Checkerboard never goes away
683         https://bugs.webkit.org/show_bug.cgi?id=79020
684         RIM PR #134164
685
686         Reviewed by Adam Treat.
687
688         Checkerboard appears in accelerated compositing layers when there's no
689         texture for (part of) a layer. The layer renderer queues up some render
690         jobs and schedules a commit to make the WebKit thread process those
691         jobs. Render jobs performed during commit cause texture upload jobs to
692         be scheduled on the UI thread. Texture uploads are performed when next
693         drawing the layers.
694
695         Unfortunately, sometimes commit operation happens without a subsequent
696         call draw the layers.
697
698         In order to implement one-shot drawing sync, I added a call to
699         commitRootLayerIfNeeded() in BackingStore::renderContents(), and
700         I was lucky that most of the time, renderContents() is followed by
701         blit(Visible)Contents() which in turn draws the layers.
702         However, render is not always followed by a blit, for example when
703         rendering offscreen tiles in BackingStore::renderOnIdle(), and in
704         direct rendering mode.
705
706         Fixed by making sure that every call to commitRootLayerIfNeeded() that
707         returns true is followed by a call to drawLayersOnCommit(), unless a
708         blit was requested already.
709
710         Also tweak the logic for one-shot drawing sync to make the code in
711         drawLayersOnCommit() reusable outside of rootLayerCommitTimerFired().
712
713         * Api/BackingStore.cpp:
714         (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
715         (BlackBerry::WebKit::BackingStorePrivate::renderOnTimer):
716         (BlackBerry::WebKit::BackingStorePrivate::renderOnIdle):
717         (BlackBerry::WebKit::BackingStorePrivate::willFireTimer):
718         (BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
719         (BlackBerry::WebKit::BackingStorePrivate::render):
720         (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
721         (BlackBerry::WebKit::BackingStorePrivate::blitContents):
722         (BlackBerry::WebKit::BackingStorePrivate::renderContents):
723         (WebKit):
724         (BlackBerry::WebKit::BackingStorePrivate::drawLayersOnCommitIfNeeded):
725         * Api/BackingStore_p.h:
726         (BackingStorePrivate):
727         (BlackBerry::WebKit::BackingStorePrivate::willDrawLayersOnCommit):
728
729 2012-03-02  Adam Treat  <atreat@rim.com>
730
731         https://bugs.webkit.org/show_bug.cgi?id=80161
732         PR: 141157
733
734         BlackBerryPlatformScreen.h API has been updated.  Reflect those
735         changes in our usage.
736
737         Reviewed by Antonio Gomes.
738         Internally reviewed by Jakob Petsovits.
739
740         * Api/BackingStore.cpp:
741         (BlackBerry::WebKit::BackingStorePrivate::tileWidth):
742         (BlackBerry::WebKit::BackingStorePrivate::tileHeight):
743         * Api/WebPage.cpp:
744         (BlackBerry::WebKit::WebPagePrivate::init):
745         (BlackBerry::WebKit::WebPagePrivate::transformedViewportSize):
746         (BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
747         (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
748         (BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
749         (BlackBerry::WebKit::WebPagePrivate::defaultMaxLayoutSize):
750         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
751         (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
752         * WebKitSupport/SurfacePool.cpp:
753         (BlackBerry::WebKit::createCompositingSurface):
754
755 2012-03-02  Konrad Piascik  <kpiascik@rim.com>
756
757         [BlackBerry] Set the devicePixelRatio from the results of computeViewportAttributes
758         https://bugs.webkit.org/show_bug.cgi?id=80160
759
760         Reviewed by Antonio Gomes.
761
762         Tested by going to layout test fast/viewport/viewport-95.html and viewport-93.html
763         Previously when executing window.devicePixelRatio these two pages returned 1 now
764         they report the devicePixelRatio returned by computeViewportAttributes.
765
766         * Api/WebPage.cpp:
767         (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
768
769 2012-03-02  Jacky Jiang  <zhajiang@rim.com>
770
771         Fix a warning in InputHandler::learnText()
772         https://bugs.webkit.org/show_bug.cgi?id=80049
773
774         Reviewed by Antonio Gomes.
775
776         Fix a warning of the comparison "textInField.length() <=
777         MaxLearnTextDataSize" in InputHandler::learnText().
778
779         Rubber-stamped internally by Mike Fenton.
780
781         * WebKitSupport/InputHandler.cpp:
782         (BlackBerry::WebKit::InputHandler::learnText):
783
784 2012-03-01  Andy Chen  <andchen@rim.com>
785
786         [BlackBerry] Implement features for find-in-page
787         https://bugs.webkit.org/show_bug.cgi?id=79820
788
789         Reviewed by Antonio Gomes.
790
791         - Make it be able to search text around the whole page instead of single frame.
792         - Make it be able to start new search from active selection and last active match.
793
794         No new tests as this patch doesn't change behavior.
795
796         * Api/WebPage.cpp:
797         (BlackBerry::WebKit::WebPagePrivate::frameUnloaded):
798         * Api/WebPage_p.h:
799         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
800         (WebCore::FrameLoaderClientBlackBerry::dispatchWillClose):
801         (WebCore::FrameLoaderClientBlackBerry::detachedFromParent2):
802         * WebKitSupport/DOMSupport.cpp:
803         (BlackBerry::WebKit::DOMSupport::incrementFrame):
804         * WebKitSupport/DOMSupport.h:
805         * WebKitSupport/InPageSearchManager.cpp:
806         (BlackBerry::WebKit::InPageSearchManager::findNextString):
807         (BlackBerry::WebKit::InPageSearchManager::shouldSearchForText):
808         (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
809         (BlackBerry::WebKit::InPageSearchManager::setMarkerActive):
810         (BlackBerry::WebKit::InPageSearchManager::frameUnloaded):
811         * WebKitSupport/InPageSearchManager.h:
812         * WebKitSupport/InputHandler.cpp:
813         (BlackBerry::WebKit::InputHandler::frameUnloaded):
814         * WebKitSupport/InputHandler.h:
815
816 2012-03-01  Charles Wei  <charles.wei@torchmobile.com.cn>
817
818         [BlackBerry] Web Notification crashes the browser.
819         https://bugs.webkit.org/show_bug.cgi?id=79897
820
821         Reviewed by Antonio Gomes.
822
823         The reason of the crash is that it still uses the iterator
824         after been removed from the container, which invalidates the
825         iterator. 
826         We should stop processing after we have found the element
827         and removed from the container through the iterator.
828
829         This patch only fixes the crash issue, but not any notification
830         functionality issue, which is tracked seperatly.
831
832         Test case: http://sandbox.gtaero.net/chrome/notifications.php
833
834         * WebCoreSupport/NotificationPresenterImpl.cpp:
835         (WebKit::NotificationPresenterImpl::onPermission):
836         (WebKit::NotificationPresenterImpl::notificationClicked):
837
838 2012-03-01  Mike Fenton  <mifenton@rim.com>
839
840         Autocomplete attribute should apply to textarea's.
841         https://bugs.webkit.org/show_bug.cgi?id=79929
842
843         Reviewed by Antonio Gomes.
844
845         Add local static Qualified name for autocorrect attribute.
846
847         * WebKitSupport/DOMSupport.cpp:
848         (BlackBerry::WebKit::DOMSupport::elementSupportsAutocorrect):
849
850 2012-02-29  Mike Fenton  <mifenton@rim.com>
851
852         Autocomplete attribute should apply to textarea's.
853         https://bugs.webkit.org/show_bug.cgi?id=79929
854
855         Reviewed by Antonio Gomes.
856
857         Allow the autocomplete attribute to bubble back to the form setting.
858
859         Expand support to include checking autocorrect, autocomplete and
860         name/id matching to text areas.
861
862         Reviewed internally by Nima Ghanavatian and Gen Mak.
863
864         * WebKitSupport/DOMSupport.cpp:
865         (BlackBerry::WebKit::DOMSupport::elementSupportsAutocorrect):
866         (BlackBerry::WebKit::DOMSupport::elementSupportsAutocomplete):
867         (BlackBerry::WebKit::DOMSupport::elementAttributeState):
868         * WebKitSupport/DOMSupport.h:
869         * WebKitSupport/InputHandler.cpp:
870         (BlackBerry::WebKit::inputStyle):
871
872 2012-02-29  Max Feil  <mfeil@rim.com>
873
874         [BlackBerry] Add support for FLAC audio and OGG/Vorbis audio
875         https://bugs.webkit.org/show_bug.cgi?id=79519
876
877         Reviewed by Antonio Gomes.
878
879         * Api/WebSettings.cpp:
880         (BlackBerry::WebKit::mimeTypeAssociationMap):
881
882 2012-02-28  Konrad Piascik  <kpiascik@rim.com>
883
884         [BlackBerry] Change the API to use std::string
885         https://bugs.webkit.org/show_bug.cgi?id=79818
886
887         Reviewed by Antonio Gomes.
888
889         * Api/WebPage.cpp:
890         (BlackBerry::WebKit::WebPage::dispatchInspectorMessage):
891         * Api/WebPage.h:
892
893 2012-02-28  Jacky Jiang  <zhajiang@rim.com>
894
895         [BlackBerry] x86 build fix after cleaning up WebPage.cpp
896         https://bugs.webkit.org/show_bug.cgi?id=79814
897
898         Reviewed by Antonio Gomes.
899
900         x86 build fix, keep WebPage::destroyWebPageCompositor() method where it
901         was which was outside of USE(ACCELERATED_COMPOSITING).
902
903         * Api/WebPage.cpp:
904         (BlackBerry::WebKit::WebPage::destroyWebPageCompositor):
905         (WebKit):
906
907 2012-02-28  Mike Fenton  <mifenton@rim.com>
908
909         [BlackBerry] Remove unused focusedNodeChange notifications from the Chrome client.
910         https://bugs.webkit.org/show_bug.cgi?id=79794
911
912         Reviewed by Rob Buis.
913
914         Remove unused notification for focusedNodeChanged.
915
916         Internally reviewed by Gen Mak.
917
918         * Api/WebPageClient.h:
919         * WebCoreSupport/ChromeClientBlackBerry.cpp:
920         (WebCore::ChromeClientBlackBerry::focusedNodeChanged):
921
922 2012-02-27  Jacky Jiang  <zhajiang@rim.com>
923
924         [BlackBerry] Upstream BlackBerry API web page related files
925         https://bugs.webkit.org/show_bug.cgi?id=74380
926
927         Reviewed by Antonio Gomes.
928
929         Clean up WebPage.{h, cpp} and WebPage_p.h.
930         - Remove WebPage::mainFrame() as it is bad to expose WebCore::Frame in
931           the public API, adapt to the change by adding a new method
932           WebPagePrivate::core(Const WebPage*) and expose it to
933           DumpRenderTreeSupport.
934         - Rename WebPage::spellCheckingEnabled to
935           WebPage::setSpellCheckingEnabled.
936         - Remove unused WebPage::focusNodeRect().
937         - Remove extra blank lines.
938         - Put WebPage methods and their associated WebPagePrivate methods
939           together.
940
941         No new tests as this patch doesn't change behavior.
942
943         * Api/WebPage.cpp:
944         (BlackBerry::WebKit::WebPage::WebPage):
945         (WebKit):
946         (BlackBerry::WebKit::WebPage::~WebPage):
947         (BlackBerry::WebKit::WebPagePrivate::core):
948         (BlackBerry::WebKit::WebPage::load):
949         (BlackBerry::WebKit::WebPage::loadExtended):
950         (BlackBerry::WebKit::WebPage::loadFile):
951         (BlackBerry::WebKit::WebPage::download):
952         (BlackBerry::WebKit::WebPage::loadString):
953         (BlackBerry::WebKit::WebPage::executeJavaScript):
954         (BlackBerry::WebKit::WebPage::executeJavaScriptInIsolatedWorld):
955         (BlackBerry::WebKit::WebPage::stopLoading):
956         (BlackBerry::WebKit::WebPage::prepareToDestroy):
957         (BlackBerry::WebKit::WebPage::setScrollPosition):
958         (BlackBerry::WebKit::WebPage::scrollBy):
959         (BlackBerry::WebKit::WebPage::notifyInRegionScrollStatusChanged):
960         (BlackBerry::WebKit::WebPage::zoomToFitScale):
961         (BlackBerry::WebKit::WebPage::initialScale):
962         (BlackBerry::WebKit::WebPage::maximumScale):
963         (BlackBerry::WebKit::WebPage::scrollPosition):
964         (BlackBerry::WebKit::WebPage::viewportSize):
965         (BlackBerry::WebKit::WebPage::activeNodeContext):
966         (BlackBerry::WebKit::WebPage::assignFocus):
967         (BlackBerry::WebKit::WebPage::blockZoomAnimationFinished):
968         (BlackBerry::WebKit::WebPage::onInputLocaleChanged):
969         (BlackBerry::WebKit::WebPage::setScreenOrientation):
970         (BlackBerry::WebKit::WebPage::applyPendingOrientationIfNeeded):
971         (BlackBerry::WebKit::WebPage::setViewportSize):
972         (BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
973         (BlackBerry::WebKit::WebPage::setScrollOriginPoint):
974         (BlackBerry::WebKit::WebPage::textEncoding):
975         (BlackBerry::WebKit::WebPage::forcedTextEncoding):
976         (BlackBerry::WebKit::WebPage::setForcedTextEncoding):
977         (BlackBerry::WebKit::WebPage::setSpellCheckingEnabled):
978         (BlackBerry::WebKit::parentLayer):
979         (BlackBerry::WebKit::WebPagePrivate::inRegionScrollableAreasForPoint):
980         (BlackBerry::WebKit::WebPage::destroyWebPageCompositor):
981         * Api/WebPage.h:
982         (WebCore):
983         (WebKit):
984         * Api/WebPage_p.h:
985         (WebCore):
986         (WebKit):
987         * WebKitSupport/DumpRenderTreeSupport.cpp:
988         (DumpRenderTreeSupport::corePage):
989         (DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
990         (DumpRenderTreeSupport::resetGeolocationMock):
991         (DumpRenderTreeSupport::setMockGeolocationError):
992         (DumpRenderTreeSupport::setMockGeolocationPermission):
993         (DumpRenderTreeSupport::setMockGeolocationPosition):
994         (DumpRenderTreeSupport::scalePageBy):
995         * WebKitSupport/DumpRenderTreeSupport.h:
996         (WebCore):
997         (DumpRenderTreeSupport):
998
999 2012-02-27  Mike Fenton  <mifenton@rim.com>
1000
1001         [BlackBerry] Selection handling should be entirely directional
1002         https://bugs.webkit.org/show_bug.cgi?id=79692
1003
1004         Reviewed by Antonio Gomes.
1005
1006         Make all VisibleSelections directional.
1007
1008         * WebKitSupport/SelectionHandler.cpp:
1009         (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
1010         (BlackBerry::WebKit::SelectionHandler::setSelection):
1011
1012 2012-02-27  Ed Baker  <edbaker@rim.com>
1013
1014         [BlackBerry] Dragging a selection handle outside of the content bounding box does not update the selection range correctly
1015         https://bugs.webkit.org/show_bug.cgi?id=78608
1016
1017         Ensure that when selection handles leave the content bounding box that
1018         the handle not being dragged remains fixed. Do not apply padding to a
1019         direction that would cause the selection to shrink when performing the
1020         handle direction detection.
1021
1022         Reviewed by Antonio Gomes.
1023
1024         * WebKitSupport/DOMSupport.cpp:
1025         (BlackBerry::WebKit::DOMSupport::convertPointToFrame):
1026         * WebKitSupport/DOMSupport.h:
1027         * WebKitSupport/SelectionHandler.cpp:
1028         (BlackBerry::WebKit::clamp):
1029         (BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
1030         (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
1031         (BlackBerry::WebKit::SelectionHandler::setSelection):
1032         (BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
1033         * WebKitSupport/SelectionHandler.h:
1034
1035 2012-02-27  Leo Yang  <leo.yang@torchmobile.com.cn>
1036
1037         [BlackBerry] Upstream accelerated compositing helper class
1038         https://bugs.webkit.org/show_bug.cgi?id=78448
1039
1040         Reviewed by Antonio Gomes.
1041
1042         Initial upstream, no new tests.
1043
1044         * WebKitSupport/FrameLayers.cpp: Added.
1045         * WebKitSupport/FrameLayers.h: Added.
1046
1047 2012-02-26  Hajime Morrita  <morrita@chromium.org>
1048
1049         Move ChromeClient::showContextMenu() to ContextMenuClient
1050         https://bugs.webkit.org/show_bug.cgi?id=79427
1051
1052         Reviewed by Adam Barth.
1053
1054         * WebCoreSupport/ChromeClientBlackBerry.h:
1055         (ChromeClientBlackBerry):
1056
1057 2012-02-24  Mike Fenton  <mifenton@rim.com>
1058
1059         [BlackBerry] Eliminate excessive BlackBerry::Platform use in InputHandler
1060         https://bugs.webkit.org/show_bug.cgi?id=79393
1061
1062         Reviewed by Antonio Gomes.
1063
1064         Cleanup usage of BlackBerry::Platform in InputHandler.
1065
1066         * WebKitSupport/InputHandler.cpp:
1067         (BlackBerry::WebKit::convertStringToWchar):
1068         (BlackBerry::WebKit::convertStringToWcharVector):
1069         (BlackBerry::WebKit::convertSpannableStringToString):
1070         (BlackBerry::WebKit::InputHandler::learnText):
1071         (BlackBerry::WebKit::InputHandler::setElementUnfocused):
1072         (BlackBerry::WebKit::InputHandler::shouldAcceptInputFocus):
1073         (BlackBerry::WebKit::InputHandler::setElementFocused):
1074         (BlackBerry::WebKit::InputHandler::nodeTextChanged):
1075         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
1076         (BlackBerry::WebKit::InputHandler::frameUnloaded):
1077         (BlackBerry::WebKit::InputHandler::selectionChanged):
1078         (BlackBerry::WebKit::InputHandler::setSelection):
1079         (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
1080         (BlackBerry::WebKit::InputHandler::deleteTextRelativeToCursor):
1081         (BlackBerry::WebKit::InputHandler::deleteText):
1082         (BlackBerry::WebKit::InputHandler::spannableTextInRange):
1083         (BlackBerry::WebKit::InputHandler::setComposingRegion):
1084         (BlackBerry::WebKit::InputHandler::finishComposition):
1085         (BlackBerry::WebKit::InputHandler::setText):
1086         (BlackBerry::WebKit::InputHandler::setTextAttributes):
1087         (BlackBerry::WebKit::InputHandler::setRelativeCursorPosition):
1088         (BlackBerry::WebKit::InputHandler::setSpannableTextAndRelativeCursor):
1089         (BlackBerry::WebKit::InputHandler::setComposingText):
1090         (BlackBerry::WebKit::InputHandler::commitText):
1091
1092 2012-02-24  Mike Fenton  <mifenton@rim.com>
1093
1094         [BlackBerry] Eliminate excessive BlackBerry::Platform use in SelectionHandler.
1095         https://bugs.webkit.org/show_bug.cgi?id=79391
1096
1097         Reviewed by Antonio Gomes.
1098
1099         Clean up usage of BlackBerry::Platform in SelectionHandler and
1100         explicitly define what namespace to use for ambiguous objects like
1101         IntRect and IntPoint.
1102
1103         * WebKitSupport/SelectionHandler.cpp:
1104         (BlackBerry::WebKit::SelectionHandler::cancelSelection):
1105         (BlackBerry::WebKit::SelectionHandler::getConsolidatedRegionOfTextQuadsForSelection):
1106         (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
1107         (BlackBerry::WebKit::directionOfPointRelativeToRect):
1108         (BlackBerry::WebKit::SelectionHandler::shouldUpdateSelectionOrCaretForPoint):
1109         (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
1110         (BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
1111         (BlackBerry::WebKit::pointIsOutsideOfBoundingBoxInDirection):
1112         (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
1113         (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
1114         (BlackBerry::WebKit::SelectionHandler::clipPointToFocusNode):
1115         (BlackBerry::WebKit::SelectionHandler::setSelection):
1116         (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
1117         (BlackBerry::WebKit::SelectionHandler::selectObject):
1118         (BlackBerry::WebKit::comparePointsToReferencePoint):
1119         (BlackBerry::WebKit::minXMinYCorner):
1120         (BlackBerry::WebKit::maxXMinYCorner):
1121         (BlackBerry::WebKit::minXMaxYCorner):
1122         (BlackBerry::WebKit::maxXMaxYCorner):
1123         (BlackBerry::WebKit::caretLocationForRect):
1124         (BlackBerry::WebKit::caretComparisonPointForRect):
1125         (BlackBerry::WebKit::adjustCaretRects):
1126         (BlackBerry::WebKit::SelectionHandler::clipRegionToVisibleContainer):
1127         (BlackBerry::WebKit::referencePoint):
1128         (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
1129         (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
1130         (BlackBerry::WebKit::SelectionHandler::selectionContains):
1131
1132 2012-02-24  Shinya Kawanaka  <shinyak@chromium.org>
1133
1134         SpellCheckRequest needs to know the context where the spellcheck happened.
1135         https://bugs.webkit.org/show_bug.cgi?id=79320
1136
1137         Reviewed by Hajime Morita.
1138
1139         * WebCoreSupport/EditorClientBlackBerry.cpp:
1140         (WebCore::EditorClientBlackBerry::requestCheckingOfString):
1141         * WebCoreSupport/EditorClientBlackBerry.h:
1142         (EditorClientBlackBerry):
1143
1144 2012-02-24  Charles Wei  <charles.wei@torchmobile.com.cn>
1145
1146         [BlackBerry] Anchor mailto: with target set won't launch Messaging application when clicked
1147         https://bugs.webkit.org/show_bug.cgi?id=79318
1148
1149         Need to give the client a chance to decide how to handle the new window request.
1150
1151         Reviewed by Rob Buis.
1152
1153         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1154         (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
1155
1156 2012-02-23  Mike Fenton  <mifenton@rim.com>
1157
1158         [BlackBerry] Selection handler has compile failure with logs enabled.
1159         https://bugs.webkit.org/show_bug.cgi?id=79392
1160
1161         Reviewed by Antonio Gomes.
1162
1163         Build Fix.  Update log to avoid usage of toString which was removed.
1164
1165         * WebKitSupport/SelectionHandler.cpp:
1166         (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
1167
1168 2012-02-19  Antonio Gomes  <agomes@rim.com>
1169
1170         Fat fingers - Add a clearer way to distinguish the node we want (shadow or non-shadow)
1171         https://bugs.webkit.org/show_bug.cgi?id=79256
1172         PR #127814 / MKS_2587410
1173
1174         Reviewed by Rob Buis.
1175
1176         Patch adds a cleaner way for call sites of FatFingersResult to
1177         query for the appropriated target node: shadow or non-shadow DOM nodes.
1178
1179         It also renames FatFingersResults::validNode to ::node, assuming
1180         that "invalid" nodes are not applicable in any context.
1181
1182         * Api/WebPage.cpp:
1183         (BlackBerry::WebKit::WebPagePrivate::clearDocumentData):
1184         (BlackBerry::WebKit::WebPagePrivate::contextNode):
1185         (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
1186         * WebKitSupport/FatFingers.h:
1187         (FatFingersResult):
1188         (BlackBerry::WebKit::FatFingersResult::node):
1189         (BlackBerry::WebKit::FatFingersResult::nodeAsElementIfApplicable):
1190         * WebKitSupport/SelectionHandler.cpp:
1191         (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
1192         * WebKitSupport/TouchEventHandler.cpp:
1193         (BlackBerry::WebKit::TouchEventHandler::touchHoldEvent):
1194         (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
1195
1196 2012-02-23  Jacky Jiang  <zhajiang@rim.com>
1197
1198         [BlackBerry] Upstream BlackBerry API web page related files
1199         https://bugs.webkit.org/show_bug.cgi?id=74380
1200
1201         Reviewed by Antonio Gomes.
1202
1203         Initial upstream, no new tests.
1204
1205         * Api/WebPage.cpp: Added.
1206         * Api/WebPage.h: Added.
1207         * Api/WebPage_p.h: Added.
1208
1209 2012-02-23  Leo Yang  <leo.yang@torchmobile.com.cn>
1210
1211         [BlackBerry] Remove unused ChromeClientBlackBerry::platformCompositingWindow(), platformWindow() and WebPageClient::compositingWindow()
1212         https://bugs.webkit.org/show_bug.cgi?id=78681
1213
1214         Reviewed by Antonio Gomes.
1215
1216         * Api/WebPageClient.h:
1217         * WebCoreSupport/ChromeClientBlackBerry.cpp:
1218         (WebCore):
1219         * WebCoreSupport/ChromeClientBlackBerry.h:
1220         (ChromeClientBlackBerry):
1221
1222 2012-02-23  Leo Yang  <leo.yang@torchmobile.com.cn>
1223
1224         [BlackBerry] Upstream GLES2Context.{h, cpp}
1225         https://bugs.webkit.org/show_bug.cgi?id=79196
1226
1227         Reviewed by Rob Buis.
1228
1229         Initial upstream, no new tests.
1230
1231         * WebKitSupport/GLES2Context.cpp: Added.
1232         * WebKitSupport/GLES2Context.h: Added.
1233
1234 2012-02-23  Mike Fenton  <mifenton@rim.com>
1235
1236         [BlackBerry] InputHandler requires cleanup of Navigation Mode handling.
1237         https://bugs.webkit.org/show_bug.cgi?id=79366
1238
1239         Reviewed by Rob Buis.
1240
1241         Cleanup InputHandler navigation based code.
1242
1243         1) Remove the concept of NavigationMode and replace it
1244            with simple showKeyboard calls.
1245
1246         2) Remove navigation move events and replace with standard
1247            key events.
1248
1249         3) Standardize function/variable names and remove obsolete
1250            functions.
1251
1252         * Api/WebPageClient.h:
1253         * WebKitSupport/InputHandler.cpp:
1254         (BlackBerry::WebKit::InputHandler::InputHandler):
1255         (BlackBerry::WebKit::InputHandler::nodeFocused):
1256         (BlackBerry::WebKit::InputHandler::setElementUnfocused):
1257         (BlackBerry::WebKit::InputHandler::setElementFocused):
1258         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
1259         (BlackBerry::WebKit::InputHandler::setDelayKeyboardVisibilityChange):
1260         (BlackBerry::WebKit::InputHandler::processPendingKeyboardVisibilityChange):
1261         (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
1262         * WebKitSupport/InputHandler.h:
1263         (InputHandler):
1264         * WebKitSupport/SelectionHandler.cpp:
1265         (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
1266         (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
1267         * WebKitSupport/TouchEventHandler.cpp:
1268         (BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
1269         (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
1270
1271 2012-02-21  Ryosuke Niwa  <rniwa@webkit.org>
1272
1273         Remove the remaining uses of CSSStyleDeclaration in Editor
1274         https://bugs.webkit.org/show_bug.cgi?id=78939
1275
1276         Reviewed by Enrica Casucci.
1277
1278         * WebCoreSupport/EditorClientBlackBerry.cpp:
1279         (WebCore::EditorClientBlackBerry::shouldApplyStyle):
1280         * WebCoreSupport/EditorClientBlackBerry.h:
1281         (EditorClientBlackBerry):
1282
1283 2012-02-22  Mike Fenton  <mifenton@rim.com>
1284
1285         [BlackBerry] InputHandler has signed vs unsigned comparison.
1286         https://bugs.webkit.org/show_bug.cgi?id=79261
1287
1288         Fix warning by casting the unsigned int to an int.
1289
1290         Reviewed by Rob Buis.
1291
1292         * WebKitSupport/InputHandler.cpp:
1293         (BlackBerry::WebKit::InputHandler::rectForCaret):
1294
1295 2012-02-22  Ryosuke Niwa  <rniwa@webkit.org>
1296
1297         Remove the remaining uses of CSSStyleDeclaration in Editor
1298         https://bugs.webkit.org/show_bug.cgi?id=78939
1299
1300         Reviewed by Enrica Casucci.
1301
1302         * WebCoreSupport/EditorClientBlackBerry.cpp:
1303         (WebCore::EditorClientBlackBerry::shouldApplyStyle):
1304         * WebCoreSupport/EditorClientBlackBerry.h:
1305         (EditorClientBlackBerry):
1306
1307 2012-02-18  Antonio Gomes  <agomes@rim.com>
1308
1309         Fat fingers - cache the first rect-based hit test so we do not need to do it again
1310         https://bugs.webkit.org/show_bug.cgi?id=79115
1311
1312         Reviewed by Adam Treat.
1313
1314         Our FatFingers implementation runs currently in two phases:
1315         the first checks for the elements intrinsically clickable;
1316         the second checks for elements made clickable by the page
1317         (for example, a div with a onclick event listener attached to it).
1318         For each phase, we perform a rect hittest, which is not needed since
1319         the result of each is the same.
1320
1321         Patch introduces a caching mechanism so we avoid on rect hittest:
1322         when the first phase runs, it caches each nodeset per document in
1323         a hashmap. This second phase works with the cached results.
1324
1325         No behavioral change, but performance is better since we
1326         avoid one (possibly expensive) rect hittest.
1327
1328         I measured the performance gain on https://www.kvd.se/, and we
1329         save up to 0.04 seconds, by caching and re-using the results.
1330
1331         * WebKitSupport/FatFingers.cpp:
1332         (BlackBerry::WebKit::dumpHitTestResult):
1333         (BlackBerry::WebKit::FatFingers::findBestPoint):
1334         (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
1335         (BlackBerry::WebKit::FatFingers::cachingStrategy):
1336         (WebKit):
1337         (BlackBerry::WebKit::FatFingers::getNodesFromRect):
1338         * WebKitSupport/FatFingers.h:
1339
1340 2012-02-20  Antonio Gomes  <agomes@rim.com>
1341
1342         All default video/audio control elements should be rect-hit testable (Part II)
1343         PR #139518 / MKS_3005538
1344
1345         Reviewed by George Staikos.
1346
1347         Add HTMLInputElement::isMediaControlElement as a criteria
1348         to consider a element as clickable.
1349
1350         Note that is should be only used while in the "ClickableByDefault"
1351         phase of FatFingers.
1352
1353         * WebKitSupport/FatFingers.cpp:
1354         (BlackBerry::WebKit::FatFingers::isElementClickable):
1355
1356 2012-02-16  Antonio Gomes  <agomes@rim.com>
1357
1358         [BlackBerry] Implemented a way to defer client navigation change client notifications
1359         https://bugs.webkit.org/show_bug.cgi?id=78848
1360
1361         Reviewed by Rob Buis.
1362
1363         Currently we postpone touch_down till touch_up if user touches
1364         the screen and an input field has the WebKit focus. This is done
1365         so we can scroll the page without hidding the vkb needlessly.
1366
1367         However, it breaks the conversion of touch to mouse events
1368         if an input field has the focus in the following scenario:
1369         an <input type=text> is focused and an user grab and-drag
1370         a <input type=range> knob/slide. It does not work until the
1371         user unfocuses the currently focused edit field.
1372
1373         Patch introduces a way to unfocus a currently focused input field,
1374         without requesting the client to show or hide the virtual keyboard
1375         right way. Instead it gets a delayed notification of the vkb mode requested
1376         at either touch_released/mouse_up or touch_cancel time.
1377
1378         For now, due to content side issues with major web sites,
1379         only delay navigation mode notification changes if we are not dealing with
1380         input modes.
1381
1382         * WebKitSupport/InputHandler.cpp:
1383         (BlackBerry::WebKit::InputHandler::InputHandler):
1384         (BlackBerry::WebKit::InputHandler::nodeFocused):
1385         (BlackBerry::WebKit::InputHandler::setElementFocused):
1386         (BlackBerry::WebKit::InputHandler::setNavigationMode):
1387         (WebKit):
1388         (BlackBerry::WebKit::InputHandler::setDelayClientNotificationOfNavigationModeChange):
1389         (BlackBerry::WebKit::InputHandler::processPendingClientNavigationModeChangeNotification):
1390         (BlackBerry::WebKit::InputHandler::notifyClientOfNavigationModeChange):
1391         (BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
1392         (BlackBerry::WebKit::InputHandler::setPopupListIndexes):
1393         (BlackBerry::WebKit::InputHandler::spannableTextInRange):
1394         (BlackBerry::WebKit::InputHandler::removeComposedText):
1395         (BlackBerry::WebKit::InputHandler::firstSpanInString):
1396         (BlackBerry::WebKit::InputHandler::setText):
1397         (BlackBerry::WebKit::InputHandler::setRelativeCursorPosition):
1398         * WebKitSupport/InputHandler.h:
1399         (InputHandler):
1400
1401 2012-02-16  Antonio Gomes  <agomes@rim.com>
1402
1403         Crash @WebPagePrivate::enqueueRenderingOfClippedContentOfScrollableNodeAfterInRegionScrolling MKS_2986818
1404         https://bugs.webkit.org/show_bug.cgi?id=78845
1405
1406         Reviewed by Rob Buis.
1407
1408         We were trying to operate on a cached Node when its page/frame/document
1409         were gone to PageCache already. To avoid such problems, lets clean up
1410         any document data we have cached when the Frame goes into the cache.
1411
1412         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1413         (WebCore::FrameLoaderClientBlackBerry::didSaveToPageCache):
1414         (WebCore):
1415         * WebCoreSupport/FrameLoaderClientBlackBerry.h:
1416         (FrameLoaderClientBlackBerry):
1417
1418 2012-02-16  Antonio Gomes  <agomes@rim.com>
1419
1420         [BlackBerry] Upstream touch handling related classes
1421         https://bugs.webkit.org/show_bug.cgi?id=78509
1422
1423         Reviewed by Adam Treat and Rob Buis.
1424
1425         FatFingers is the class responsible to the whole touch
1426         accuracy of the BlackBerry port. Initial upstream.
1427
1428         * WebKitSupport/FatFingers.cpp: Added.
1429         (WebKit):
1430         (BlackBerry::WebKit::FatFingers::fingerRectForPoint):
1431         (BlackBerry::WebKit::hasMousePressListener):
1432         (BlackBerry::WebKit::FatFingers::isElementClickable):
1433         (BlackBerry::WebKit::isFieldWithText):
1434         (BlackBerry::WebKit::distanceBetweenPoints):
1435         (BlackBerry::WebKit::compareDistanceBetweenPoints):
1436         (BlackBerry::WebKit::isValidFrameOwner):
1437         (BlackBerry::WebKit::FatFingers::FatFingers):
1438         (BlackBerry::WebKit::FatFingers::~FatFingers):
1439         (BlackBerry::WebKit::FatFingers::findBestPoint):
1440         (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
1441         (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
1442         (BlackBerry::WebKit::FatFingers::checkForClickableElement):
1443         (BlackBerry::WebKit::FatFingers::checkForText):
1444         (BlackBerry::WebKit::FatFingers::getPaddings):
1445         (BlackBerry::WebKit::FatFingers::nodesFromRect):
1446         (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
1447         (BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):
1448         * WebKitSupport/FatFingers.h: Added.
1449         (WebCore):
1450         (WebKit):
1451         (FatFingersResult):
1452         (BlackBerry::WebKit::FatFingersResult::FatFingersResult):
1453         (BlackBerry::WebKit::FatFingersResult::reset):
1454         (BlackBerry::WebKit::FatFingersResult::originPosition):
1455         (BlackBerry::WebKit::FatFingersResult::adjustedPosition):
1456         (BlackBerry::WebKit::FatFingersResult::positionWasAdjusted):
1457         (BlackBerry::WebKit::FatFingersResult::isTextInput):
1458         (BlackBerry::WebKit::FatFingersResult::isValid):
1459         (BlackBerry::WebKit::FatFingersResult::validNode):
1460         (BlackBerry::WebKit::FatFingersResult::nodeAsElementIfApplicable):
1461         (FatFingers):
1462
1463 2012-02-16  Antonio Gomes  <agomes@rim.com>
1464
1465         [BlackBerry] Upstream touch handling related classes
1466         https://bugs.webkit.org/show_bug.cgi?id=78509
1467
1468         Reviewed by Adam Treat.
1469
1470         Initial upstream of the Blackberry specific single touch event
1471         handler class.
1472
1473         * blackberry/WebKitSupport/TouchEventHandler.cpp: Added.
1474         (WebKit):
1475         (BlackBerry::WebKit::hasMouseMoveListener):
1476         (BlackBerry::WebKit::hasTouchListener):
1477         (BlackBerry::WebKit::elementExpectsMouseEvents):
1478         (BlackBerry::WebKit::shouldConvertTouchToMouse):
1479         (BlackBerry::WebKit::TouchEventHandler::TouchEventHandler):
1480         (BlackBerry::WebKit::TouchEventHandler::~TouchEventHandler):
1481         (BlackBerry::WebKit::TouchEventHandler::shouldSuppressMouseDownOnTouchDown):
1482         [BlackBerry] Upstream touch handling related classes
1483         https://bugs.webkit.org/show_bug.cgi?id=78509
1484
1485         Reviewed by Rob Buis.
1486
1487         InRegionScrollableArea specializes the BlackBerry specific ScrollViewBase,
1488         working as a read-only wrapper object for a scrollable areas in the page.
1489         It is used in our client side to control in-region scrolling (scrollable boxes,
1490         inner frames, etc).
1491
1492         Initial upstream.
1493
1494         * WebKitSupport/InRegionScrollableArea.cpp: Added.
1495         (WebKit):
1496         (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
1497         (BlackBerry::WebKit::InRegionScrollableArea::calculateMinimumScrollPosition):
1498         (BlackBerry::WebKit::InRegionScrollableArea::calculateMaximumScrollPosition):
1499         (BlackBerry::WebKit::InRegionScrollableArea::layer):
1500         (BlackBerry):
1501         * WebKitSupport/InRegionScrollableArea.h: Added.
1502         (WebCore):
1503         (WebKit):
1504         (InRegionScrollableArea):
1505
1506 2012-02-16  Antonio Gomes  <agomes@rim.com>
1507
1508         (BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
1509         (BlackBerry::WebKit::TouchEventHandler::touchHoldEvent):
1510         (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
1511         (BlackBerry::WebKit::TouchEventHandler::spellCheck):
1512         (BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):
1513         (BlackBerry::WebKit::elementForTapHighlight):
1514         (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
1515         * blackberry/WebKitSupport/TouchEventHandler.h: Added.
1516         (WebCore):
1517         (WebKit):
1518         (TouchEventHandler):
1519         (BlackBerry::WebKit::TouchEventHandler::lastFatFingersResult):
1520         (BlackBerry::WebKit::TouchEventHandler::resetLastFatFingersResult):
1521