bb888ba1b79ce9af3699dde5046108ca346cd3e9
[WebKit-https.git] / Source / WebKit / blackberry / ChangeLog
1 2012-11-06  Genevieve Mak  <gmak@rim.com>
2
3         [BlackBerry] Crash in InRegionScrollerPrivate.
4         https://bugs.webkit.org/show_bug.cgi?id=101399
5
6         Reviewed by Rob Buis.
7
8         Add a pointer to the enclosing document as the pointer to layer
9         or node along the way may become invalid.
10         Use document pointer in clearDocumentData.
11         PR #238469
12
13         * Api/InRegionScroller.cpp:
14         (BlackBerry::WebKit::InRegionScrollerPrivate::clearDocumentData):
15         * WebKitSupport/InRegionScrollableArea.cpp:
16         (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
17         (BlackBerry::WebKit::InRegionScrollableArea::document):
18         (WebKit):
19         * WebKitSupport/InRegionScrollableArea.h:
20         (WebCore):
21         (InRegionScrollableArea):
22
23 2012-11-06  Otto Derek Cheung  <otcheung@rim.com>
24
25         [BlackBerry] Pushing window.external.* events to webplatform
26         https://bugs.webkit.org/show_bug.cgi?id=101386
27
28         Reviewed by Rob Buis.
29
30         Adding calls to trigger window.external events so we can handle them on the
31         browser side.
32
33         PR 170059
34
35         * Api/WebPageClient.h:
36         * WebCoreSupport/ChromeClientBlackBerry.cpp:
37         (WebCore::ChromeClientBlackBerry::addSearchProvider):
38         (WebCore::ChromeClientBlackBerry::isSearchProviderInstalled):
39
40 2012-11-06  Otto Derek Cheung  <otcheung@rim.com>
41
42         [BlackBerry] Adding window.external to our port
43         https://bugs.webkit.org/show_bug.cgi?id=100868
44
45         Reviewed by Rob Buis.
46
47         Patching the method names to match the ones in the spec.
48
49         * WebCoreSupport/ExternalExtension.cpp:
50
51 2012-11-06  Jacky Jiang  <zhajiang@rim.com>
52
53         [BlackBerry] Page can't back to whole screen after zoom out and orientation change
54         https://bugs.webkit.org/show_bug.cgi?id=101350
55
56         Reviewed by Rob Buis.
57         Internally reviewed by Arvid Nilsson.
58
59         PR: 229321
60         When rotating device during touch interaction, bitmap zooming was
61         unexpected ended by resetBitmapZoomScale() so that it couldn't bounce
62         back. The call resetBitmapZoomScale() is ancient, which just resets the
63         scale of the bitmap before. Right now it only ends the bitmap zooming
64         which caused the issue. As UI viewport will be updated by zoomChanged()
65         right after that, we can remove this trouble maker.
66         Update the interaction views if the rotation is being changed so that
67         ZoomHandler can get the updated views.
68
69         * Api/WebPage.cpp:
70         (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
71         * Api/WebPageClient.h:
72
73 2012-11-05  Lianghui Chen  <liachen@rim.com>
74
75         [BlackBerry] Do not show error page for main loads denied by client application
76         https://bugs.webkit.org/show_bug.cgi?id=101287
77
78         Internal PR: 237574.
79         Internally reviewed by Arvid Nilsson, Joe Mason.
80         Reviewed by George Staikos.
81
82         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
83         (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
84
85 2012-11-05  Lianghui Chen  <liachen@rim.com>
86
87         [BlackBerry] Do not display error page for failed downloads
88         https://bugs.webkit.org/show_bug.cgi?id=101246
89
90         Internal PR: 236318
91         Internal reviewed by Joe Mason, Leo Yang.
92         Reviewed by Rob Buis.
93
94         Right now when a main load, including all downloads, failed, it will
95         display an error page. This is not very user friendly, especially for
96         WebWorks application, which want to use its own user interface to info
97         user about the failure.
98         So we just stop displaying error page for downloads.
99
100         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
101         (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
102
103 2012-11-05  Simon Fraser  <simon.fraser@apple.com>
104
105         Fix layer borders to cleaning appear and disappear on switching
106         https://bugs.webkit.org/show_bug.cgi?id=101136
107
108         Reviewed by Sam Weinig.
109
110         Remove the GraphicsLayerClient methods showDebugBorders() and
111         showRepaintCounter().
112
113         * Api/WebOverlay_p.h:
114         (WebOverlayPrivateWebKitThread):
115         * Api/WebPage.cpp:
116         (BlackBerry::WebKit::WebPagePrivate::notifyFlushRequired):
117         * Api/WebPage_p.h:
118         * WebKitSupport/DefaultTapHighlight.cpp:
119         * WebKitSupport/DefaultTapHighlight.h:
120         (DefaultTapHighlight):
121         * WebKitSupport/InspectorOverlayBlackBerry.cpp:
122         * WebKitSupport/InspectorOverlayBlackBerry.h:
123         (InspectorOverlay):
124         * WebKitSupport/SelectionOverlay.cpp:
125         * WebKitSupport/SelectionOverlay.h:
126         (SelectionOverlay):
127
128 2012-11-05  Rob Buis  <rbuis@rim.com>
129
130         [BlackBerry] screenX/Y gives wrong values
131         https://bugs.webkit.org/show_bug.cgi?id=101259
132
133         Reviewed by Yong Li.
134
135         PR 237071
136
137         Reviewed internally by Gen Mak.
138
139         Do not transform screenPos coordinates.
140
141         * Api/WebPage.cpp:
142         (BlackBerry::WebKit::WebPage::mouseEvent):
143         (BlackBerry::WebKit::WebPage::touchEvent):
144         (BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
145
146 2012-11-05  Rob Buis  <rbuis@rim.com>
147
148         [BlackBerry] Input date should not popup dialog when readonly is set
149         https://bugs.webkit.org/show_bug.cgi?id=101234
150
151         Reviewed by Yong Li.
152
153         PR 236114
154
155         Reviewed internally by Mike Fenton.
156
157         Suppress popup dialog if the input element has readonly attribute set.
158
159         * WebKitSupport/InputHandler.cpp:
160         (BlackBerry::WebKit::InputHandler::openDatePopup):
161         (BlackBerry::WebKit::InputHandler::openColorPopup):
162
163 2012-11-05  Genevieve Mak  <gmak@rim.com>
164
165         [BLACKBERRY] Update touch code to reflect touch refactor
166         https://bugs.webkit.org/show_bug.cgi?id=101227
167
168         Reviewed by Rob Buis.
169
170         PR #2706785
171         Reviewed Internally by: Mike Lattanzio
172
173         * Api/WebPage.cpp:
174         (BlackBerry::WebKit::WebPage::touchEvent):
175         (BlackBerry::WebKit::WebPagePrivate::dispatchTouchEventToFullScreenPlugin):
176
177 2012-11-05  Konrad Piascik  <kpiascik@rim.com>
178
179         [BlackBerry] Web Inspector: Add InspectorInstrumentaiton calls for timeline compositing.
180         https://bugs.webkit.org/show_bug.cgi?id=101213
181         RIM PR 178131
182
183         Reviewed by Rob Buis.
184
185         Internally Reviewed by Arvid Nilsson.
186
187         Added compositing events to the timeline for BlackBerry.
188
189         * Api/WebPage.cpp:
190         (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
191         (BlackBerry::WebKit::WebPagePrivate::willComposite):
192         (WebKit):
193         (BlackBerry::WebKit::WebPagePrivate::didComposite):
194         * Api/WebPage_p.h:
195         (WebPagePrivate):
196
197 2012-11-03  Alexey Proskuryakov  <ap@apple.com>
198
199         Get rid of USE(CFURLSTORAGESESSIONS)
200         https://bugs.webkit.org/show_bug.cgi?id=101131
201
202         Reviewed by Sam Weinig.
203
204         * WebCoreSupport/AboutDataUseFeatures.in: Not sure what this list is about, but
205         CFURLSTORAGESESSIONS probably doesn't need to stay here.
206
207 2012-11-02  Nima Ghanavatian  <nghanavatian@rim.com>
208
209         [BlackBerry] Fix compile-time warning of a possible empty-body if statement
210         https://bugs.webkit.org/show_bug.cgi?id=101095
211
212         Reviewed by Yong Li.
213         Internally reviewed by Jeff Rogers.
214
215         BBLOG might be compiled out leaving an if statement with an empty
216         body. This is giving us a warning at the moment. Simply putting braces
217         around it will fail as well because then we'd have braces around a
218         single-line if. So, in following with the style observed in other parts
219         of BackingStore.cpp, break up the log message and add braces.
220
221         * Api/BackingStore.cpp:
222         (BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
223         (BlackBerry::WebKit::BackingStorePrivate::fillWindow):
224         (BlackBerry::WebKit::BackingStorePrivate::clearWindow):
225
226 2012-11-02  Nima Ghanavatian  <nghanavatian@rim.com>
227
228         [BlackBerry] Optimize backspace key handling
229         https://bugs.webkit.org/show_bug.cgi?id=101083
230
231         PR233591
232         Optimize backspace key handling. Some of these calls are not
233         required by IMF since the input_service already processes the backspace key
234         and updates the state before passing us the key.
235
236         Internally reviewed by Mike Fenton.
237
238         Reviewed by Yong Li.
239
240         Blocking calls with a flag that we clear immediately after
241         processing a backspace keydown.
242
243         * WebKitSupport/InputHandler.cpp:
244         (BlackBerry::WebKit::InputHandler::nodeTextChanged):
245         (BlackBerry::WebKit::InputHandler::selectionChanged):
246         (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
247         * WebKitSupport/InputHandler.h:
248         (InputHandler):
249
250 2012-11-02  Otto Derek Cheung  <otcheung@rim.com>
251
252         [BlackBerry] Adding window.external to our port
253         https://bugs.webkit.org/show_bug.cgi?id=100868
254
255         Reviewed by Rob Buis.
256         PR 158809
257
258         Patch up an error where we were dereferencing a null pointer.
259
260         * WebCoreSupport/ExternalExtension.cpp:
261         (addSearchProviderMethod):
262         (IsSearchProviderInstalledMethod):
263
264 2012-11-01  Peter Wang  <peter.wang@torchmobile.com.cn>
265
266         [BlackBerry] Simplify the code of returning JSValue in "BlackBerry::WebKit::WebPagePrivate::executeJavaScript"
267         https://bugs.webkit.org/show_bug.cgi?id=100941
268
269         Reviewed by Yong Li.
270
271         Remove the unnecessary steps, just directly deal with returned JSValue.
272
273         * Api/WebPage.cpp:
274         (BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
275         (BlackBerry::WebKit::WebPagePrivate::executeJavaScriptInIsolatedWorld):
276
277 2012-11-01  Otto Derek Cheung  <otcheung@rim.com>
278
279         [BlackBerry] Add a prompt to enable global location services
280         https://bugs.webkit.org/show_bug.cgi?id=100992
281         
282         PR 227897
283
284         Reviewed by Rob Buis.
285
286         Adding a dialog to let the user know location services isn't enabled.
287         Currently, the browser app does not check whether the global setting for
288         location service is enabled. This patch adds a dialog to allow the user
289         to open the settings app and change that setting. This infobar will only
290         show once per session. If the user fails to turn on location services after
291         the first prompt, all geolocation requests will automatically fail.
292
293         Also, adapting GeolocationClientBlackBerry to the removal of GeoTracker.
294         The class now talks directly to the geo handler singleton.
295
296         * Api/WebPageClient.h:
297         * WebCoreSupport/GeolocationClientBlackBerry.cpp:
298         (GeolocationClientBlackBerry::GeolocationClientBlackBerry):
299         (GeolocationClientBlackBerry::geolocationDestroyed):
300         (GeolocationClientBlackBerry::startUpdating):
301         (GeolocationClientBlackBerry::stopUpdating):
302         (GeolocationClientBlackBerry::requestPermission):
303         (GeolocationClientBlackBerry::setEnableHighAccuracy):
304         * WebCoreSupport/GeolocationClientBlackBerry.h:
305         (WebCore::GeolocationClientBlackBerry::requiresHighAccuracy):
306         (GeolocationClientBlackBerry):
307
308 2012-11-01  Michael Matovsky  <mmatovsky@rim.com>
309
310         [BlackBerry] Web page view state should be preserved for pages loaded from page cache
311         https://bugs.webkit.org/show_bug.cgi?id=100694
312         Internal PR: 220488
313
314         Internally reviewed by Lianghui Chen, Joe Mason
315         Reviewed by Rob Buis.
316
317         The web page view specific metadata should be preserved for web pages loaded from page cache (by using back/forward).
318         This requires web page view state to be saved in and restored from the corresponding page cache history item.
319
320         * Api/WebPageClient.h:
321         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
322         (WebCore::FrameLoaderClientBlackBerry::saveViewStateToItem):
323         (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
324
325 2012-11-01  Leo Yang  <leoyang@rim.com>
326
327         [BlackBerry] Use clipped background rect in backing store
328         https://bugs.webkit.org/show_bug.cgi?id=100960
329
330         Reviewed by Yong Li.
331         Reviewed internally by Arvid Nilsson.
332
333         We calculated clipped background rect but didn't really use it when painting
334         the background. Use the correct rect to avoid ASSERT failure in platform code.
335
336         * Api/BackingStore.cpp:
337         (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
338
339 2012-10-31  George Staikos  <staikos@webkit.org>
340
341         [BlackBerry] Crash on html popup form control when element is deleted
342         https://bugs.webkit.org/show_bug.cgi?id=100869
343
344         Reviewed by Yong Li.
345
346         Make the element pointers RefPtr so they don't go away before the popup
347         is closed.
348
349         * WebCoreSupport/ColorPickerClient.h:
350         (ColorPickerClient):
351         * WebCoreSupport/DatePickerClient.h:
352         (DatePickerClient):
353         * WebCoreSupport/SelectPopupClient.h:
354         (SelectPopupClient):
355
356 2012-10-31  Genevieve Mak  <gmak@rim.com>
357
358         [BLACKBERRY] Custom WebWorks context menus don't always work.
359         https://bugs.webkit.org/show_bug.cgi?id=100891
360
361         Reviewed by Rob Buis.
362
363         Walk up the dom tree until we find the webworks attribute or run out
364         of parent nodes.
365         PR# 227732
366
367         * Api/WebPage.cpp:
368         (BlackBerry::WebKit::WebPagePrivate::webContext):
369
370 2012-10-31  Otto Derek Cheung  <otcheung@rim.com>
371
372         [BlackBerry] Adding window.external to our port
373         https://bugs.webkit.org/show_bug.cgi?id=100868
374
375         Reviewed by Rob Buis.
376
377         Attaching the window.external interface to the frame when
378         it loads up.
379
380         When called, the external interface methods call stubs declared
381         in ChromeClientBlackBerry. The method passes in the url of the search
382         provider and the url of the frame. Cross-site check has to be done in the
383         implementation PR.
384
385         * WebCoreSupport/ChromeClientBlackBerry.cpp:
386         (WebCore::ChromeClientBlackBerry::addSearchProvider):
387         (WebCore):
388         (WebCore::ChromeClientBlackBerry::isSearchProviderInstalled):
389         * WebCoreSupport/ChromeClientBlackBerry.h:
390         (ChromeClientBlackBerry):
391         * WebCoreSupport/ExternalExtension.cpp: Added.
392         (addSearchProviderMethod):
393         (IsSearchProviderInstalledMethod):
394         (externalExtensionInitialize):
395         (externalExtensionFinalize):
396         * WebCoreSupport/ExternalExtension.h: Added.
397         (WebCore):
398         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
399         (WebCore::FrameLoaderClientBlackBerry::dispatchDidClearWindowObjectInWorld):
400
401 2012-10-30  Peter Wang  <peter.wang@torchmobile.com.cn>
402
403         [BlackBerry] Clean the code of "JavaScriptDebuggerBlackBerry"
404         https://bugs.webkit.org/show_bug.cgi?id=100724
405
406         Reviewed by Rob Buis.
407
408         Remove the code of JavaScriptDebuggerBlackBerry.
409
410         * Api/WebPage.cpp:
411         * Api/WebPage.h:
412         * Api/WebPage_p.h:
413         (WebCore):
414         (WebPagePrivate):
415         * WebCoreSupport/JavaScriptDebuggerBlackBerry.cpp: Removed.
416         * WebCoreSupport/JavaScriptDebuggerBlackBerry.h: Removed.
417
418 2012-10-29  Rob Buis  <rbuis@rim.com>
419
420         [BlackBerry] Simplify AuthenticationChallengeManager::instance
421         https://bugs.webkit.org/show_bug.cgi?id=100614
422
423         Reviewed by Yong Li.
424         Internally reviewed by Lyon Chen.
425
426         No need to call AuthenticationChallengeManager::init anymore.
427
428         * Api/BlackBerryGlobal.cpp:
429         (BlackBerry::WebKit::globalInitialize):
430
431 2012-10-29  Mike Lattanzio  <mlattanzio@rim.com>
432
433         [BlackBerry] Typo in WebPagePrivate::postponeDocumentRecalcStyle()
434         https://bugs.webkit.org/show_bug.cgi?id=100377
435
436         Reviewed by Adam Treat.
437
438         Should be void, not bool.
439
440         * Api/WebPage.cpp:
441         (BlackBerry::WebKit::WebPagePrivate::postponeDocumentStyleRecalc):
442         * Api/WebPage_p.h:
443         (WebPagePrivate):
444
445 2012-10-29  Robin Cao  <robin.cao@torchmobile.com.cn>
446
447         [BlackBerry] Fix a build error
448         https://bugs.webkit.org/show_bug.cgi?id=100649
449
450         Reviewed by Kentaro Hara.
451
452         r127876 changed the signature of WebCore::EventHandler::hitTestResultAtPoint()
453         and this commit was later reverted. We need to update a call site in the
454         BlackBerry port to make it build.
455
456         * Api/WebPage.cpp:
457         (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
458
459 2012-10-26  Jacky Jiang  <zhajiang@rim.com>
460
461         [BlackBerry][FullScreen] entering/leaving fullscreen results in temporary glitches on the screen
462         https://bugs.webkit.org/show_bug.cgi?id=100421
463
464         Reviewed by Yong Li.
465
466         PR: 231173
467         When leaving fullscreen, we need to suspend screen and backing store
468         updates before setting scroll position and changing transformation and
469         resume after they are done. In which way, we can get rid of a noticeable
470         glitch during the transition.
471
472         * Api/WebPage.cpp:
473         (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
474
475 2012-10-26  Sean Wang  <Xuewen.Wang@torchmobile.com.cn>
476
477         [BlackBerry] ASSERT currentThreadIsHoldingLock() failed in MarkedAllocator::allocateSlowCase()
478         https://bugs.webkit.org/show_bug.cgi?id=100504
479
480         Reviewed by Yong Li.
481
482         PR #232038 The similar PR # 200724.
483         Reviewed internally by Petter Wang.
484
485         This issue is same as bug 95492, and this patch is same as its patch.
486         Hold the JSLock for the current thread before we call toRef to avoid
487         the ASSERT failure.
488
489         * Api/WebPage.cpp:
490         (BlackBerry::WebKit::WebPagePrivate::executeJavaScriptInIsolatedWorld):
491         (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
492
493 2012-10-25  Sean Wang  <Xuewen.Wang@torchmobile.com.cn>
494
495         [BlackBerry] WebView process crashed at AuthenticationChallengeManager::pageVisibilityChanged()
496         https://bugs.webkit.org/show_bug.cgi?id=100330
497
498         Reviewed by Rob Buis.
499
500         Reviewed internally by Charles Wei.
501         PR #231232
502
503         Since AuthenticationChallengeManager keeps a map of WebPages, WebPage setting
504         visible needs AuthenticationChallengeManager to update its records, deleting
505         webpage from AuthenticationChallengeManager's map should be done after setting
506         webpage visibility.
507
508         * Api/WebPage.cpp:
509         (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
510
511 2012-10-24  Sean Wang  <Xuewen.Wang@torchmobile.com.cn>
512
513         [BlackBerry] ASSERT(!needsOneShotDrawingSynchronization()) failed in commitRootLayerIfNeeded()
514         https://bugs.webkit.org/show_bug.cgi?id=100214
515
516         Reviewed by Rob Buis.
517
518         ViewportSize has been changed before committing root layer, it asserts
519         that it needs relayout and render if needed before committing if it
520         Needs One Shot Drawing Synchronization.
521         This patch calls requestLayoutIfNeeded() when resumeScreenAndBackingStoreUpdates().
522
523         Fix a coding style in the BackingStore.cpp as well.
524
525         Reviewed internally by Arvid Nilsson.
526         PR #230253
527
528         * Api/BackingStore.cpp:
529         (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
530
531 2012-10-24  Otto Derek Cheung  <otcheung@rim.com>
532
533         [BlackBerry] Geolocation is segfaulting
534         https://bugs.webkit.org/show_bug.cgi?id=100305
535
536         Reviewed by Rob Buis.
537
538         We weren't wrapping the Geolocation object in a RefPtr when we call setIsAllowed in
539         GeolocationClientBlackBerry::onPermission.
540
541         This patch also removes all references of the Geolocation object in WebPageClientImpl.
542         One RefPtr<Geolocation> is used to store the reference of the WebCore object on our port.
543
544         We don't need a mapping between origin -> context of Geolocation because in our port,
545         one WebPage.cpp contains one GeolocationController only. 
546
547         * Api/WebPageClient.h:
548         * WebCoreSupport/GeolocationClientBlackBerry.cpp:
549         (frameOrigin):
550         (GeolocationClientBlackBerry::requestPermission):
551         (GeolocationClientBlackBerry::cancelPermissionRequest):
552         (GeolocationClientBlackBerry::onPermission):
553         * WebCoreSupport/GeolocationClientBlackBerry.h:
554         (GeolocationClientBlackBerry):
555
556 2012-10-24  Jacky Jiang  <zhajiang@rim.com>
557
558         [BlackBerry][Fullscreen] Roll out changes to fullscreen which rely on viewport size change [Part II]
559         https://bugs.webkit.org/show_bug.cgi?id=100259
560
561         Reviewed by Rob Buis.
562
563         PR: 219666
564         Revert "[BlackBerry] [FullScreen] entering/leaving fullscreen results in temporary glitches on the screen"
565         This rolls out r128772.
566         The patches relies on the viewport size change of the client side to
567         resume the screen and backing store updates. However, some client
568         sides don't need or wish to resize the WebKit viewport at all which
569         will result in upexpected screen and backing store suspensions.
570
571         * Api/WebPage.cpp:
572         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
573         (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
574         * Api/WebPage_p.h:
575         (WebPagePrivate):
576         * WebCoreSupport/ChromeClientBlackBerry.cpp:
577         (WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
578         (WebCore::ChromeClientBlackBerry::exitFullScreenForElement):
579
580 2012-10-24  Jacky Jiang  <zhajiang@rim.com>
581
582         [BlackBerry][Fullscreen] Roll out changes to fullscreen which rely on viewport size change
583         https://bugs.webkit.org/show_bug.cgi?id=100259
584
585         Reviewed by Rob Buis.
586
587         PR: 219666
588         Roll out r130392 and r129909.
589         The patches rely on the viewport size change of the client side to
590         update the scale and scroll position of the video. However, some client
591         sides don't need or wish to resize the WebKit viewport at all.
592
593         * Api/WebPage.cpp:
594         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
595         (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
596         (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
597         (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
598         * Api/WebPage_p.h:
599         (WebPagePrivate):
600
601 2012-10-24  Otto Derek Cheung  <otcheung@rim.com>
602
603         [BlackBerry] Rename GeolocationControllerClientBlackBerry to GeolocationClientBlackBerry
604         https://bugs.webkit.org/show_bug.cgi?id=100250
605
606         Reviewed by Rob Buis.
607
608         Rename GeolocationControllerClientBlackBerry to GeolocationClientBlackBerry
609         to prevent confusion.
610         PR 230196
611
612         * Api/WebPage.cpp:
613         (BlackBerry::WebKit::WebPagePrivate::init):
614         * Api/WebPage_p.h:
615         (WebCore):
616         * WebCoreSupport/ChromeClientBlackBerry.cpp:
617         * WebCoreSupport/GeolocationClientBlackBerry.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.cpp.
618         (frameOrigin):
619         (GeolocationClientBlackBerry::GeolocationClientBlackBerry):
620         (GeolocationClientBlackBerry::geolocationDestroyed):
621         (GeolocationClientBlackBerry::startUpdating):
622         (GeolocationClientBlackBerry::stopUpdating):
623         (GeolocationClientBlackBerry::lastPosition):
624         (GeolocationClientBlackBerry::requestPermission):
625         (GeolocationClientBlackBerry::cancelPermissionRequest):
626         (GeolocationClientBlackBerry::onLocationUpdate):
627         (GeolocationClientBlackBerry::onLocationError):
628         (GeolocationClientBlackBerry::onPermission):
629         (GeolocationClientBlackBerry::setEnableHighAccuracy):
630         * WebCoreSupport/GeolocationClientBlackBerry.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.h.
631         (WebKit):
632         (WebCore):
633         (GeolocationClientBlackBerry):
634         (WebCore::GeolocationClientBlackBerry::tracker):
635
636 2012-10-24  Parth Patel  <parpatel@rim.com>
637
638         [BlackBerry] Extending existing ThreadUnsafe singletons in webkit to
639         Generic ThreadUnsafe Singleton
640         https://bugs.webkit.org/show_bug.cgi?id=100145
641
642         Reviewed by Rob Buis.
643
644         Extending the singletons to generic singleton and changing
645         getInstance() in IconDatabaseClientBlackBerry to instance()
646         to match the generic singleton template.
647
648         Reviewed Internally by Yong Li.
649
650         * Api/WebPage.cpp:
651         (BlackBerry::WebKit::WebPage::initializeIconDataBase):
652         * WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
653         (WebCore):
654         * WebCoreSupport/IconDatabaseClientBlackBerry.h:
655         (IconDatabaseClientBlackBerry):
656
657 2012-10-23  Robin Cao  <robin.cao@torchmobile.com.cn>
658
659         [BlackBerry] Web page renders at the wrong zoom level after viewport changes
660         https://bugs.webkit.org/show_bug.cgi?id=100096
661
662         Reviewed by Rob Buis.
663
664         Notify the client of the zoom level change before resuming screen updates.
665         Otherwise, the user interface thread may blit the content at the wrong
666         zoom level in some cases. This can also prevent potential flickering.
667
668         Reviewed internally by Arvid Nilsson.
669
670         PR #225741
671
672         * Api/WebPage.cpp:
673         (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
674         (BlackBerry::WebKit::WebPagePrivate::zoomBlock):
675
676 2012-10-23  Mike Lattanzio  <mlattanzio@rim.com>
677
678         [BlackBerry] Cache TouchDown HitTestResult to avoid calling RenderLayer::hitTest unnecessarily
679         https://bugs.webkit.org/show_bug.cgi?id=99649
680
681         Reviewed by George Staikos.
682
683         Random latency before scroll starts on sites like http://pintrest.com
684         Internal PR225398
685
686         The chief problem here is the all the hit testing that we do for
687         touch events and simulated mouse events. If the render tree is dirty
688         hit tests can take a long time in Document::recalcStyle(). Masking
689         the flags that force style recalculations will make them fast, at the
690         expense that they might be happening on stale data.
691
692         Since we are only using these hit tests to look for event handlers -
693         we're not actually modifying anything, it is better to skip the
694         Document::recalcStyle() and save ourselves tons of time.
695
696         * Api/InRegionScroller.cpp:
697         (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
698         * Api/WebPage.cpp:
699         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
700         (BlackBerry::WebKit::WebPage::touchEvent):
701         (BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):
702         (BlackBerry::WebKit::WebPagePrivate::postponeDocumentStyleRecalc):
703         (WebKit):
704         (BlackBerry::WebKit::WebPagePrivate::resumeDocumentStyleRecalc):
705         (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
706         (BlackBerry::WebKit::WebPagePrivate::clearCachedHitTestResult):
707         * Api/WebPage_p.h:
708         (WebPagePrivate):
709         * WebKitSupport/FatFingers.cpp:
710         (BlackBerry::WebKit::FatFingers::findBestPoint):
711         (BlackBerry::WebKit::FatFingers::getRelevantInfoFromCachedHitTest):
712         * WebKitSupport/FatFingers.h:
713         * WebKitSupport/TouchEventHandler.cpp:
714         (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
715
716 2012-10-23  Rob Buis  <rbuis@rim.com>
717
718         [BlackBerry] Make selection in search input box not overlap cancel button
719         https://bugs.webkit.org/show_bug.cgi?id=100130
720
721         Reviewed by Antonio Gomes.
722
723         This ensures that even when selection is active, the user can still press 'cancel'.
724
725         * WebKitSupport/InputHandler.cpp:
726         (BlackBerry::WebKit::InputHandler::boundingBoxForInputField):
727
728 2012-10-23  Arvid Nilsson  <anilsson@rim.com>
729
730         [BlackBerry] Let WebKit manage the SelectionOverlay
731         https://bugs.webkit.org/show_bug.cgi?id=99585
732
733         Reviewed by Rob Buis.
734
735         The SelectionOverlay was exposed to clients of the BlackBerry::WebKit
736         API. However, all the information and notifications necessary to manage
737         the SelectionOverlay are available within WebKit, so the client does
738         not have to shoulder this responsibility.
739
740         Remove WebSelection and all the related plumbing. Now that nobody is
741         using the class from the user interface thread, remove the message
742         related code in SelectionOverlay.
743
744         Add two calls to SelectionOverlay::hide() that are necessary now that
745         the client is no longer responsible for hiding it.
746
747         RIM PR: 225789
748
749         Reviewed internally by Mike Fenton.
750
751         * Api/WebPage.cpp:
752         (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
753         * Api/WebPage.h:
754         (WebKit):
755         * Api/WebPage_p.h:
756         (WebPagePrivate):
757         * Api/WebSelectionOverlay.h: Removed.
758         * WebKitSupport/SelectionHandler.cpp:
759         (BlackBerry::WebKit::SelectionHandler::cancelSelection): Hide the overlay here, because state is reset and selection mode is no longer active
760         (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged): Also hide overlay here, to go with the call to cancelSelectionVisuals
761         * WebKitSupport/SelectionOverlay.cpp:
762         (BlackBerry::WebKit::SelectionOverlay::SelectionOverlay):
763         * WebKitSupport/SelectionOverlay.h:
764         (BlackBerry::WebKit::SelectionOverlay::create):
765         (SelectionOverlay):
766
767 2012-10-22  Mike Fenton  <mifenton@rim.com>
768
769         [BlackBerry] Remove specialized handling for isIndex fields.
770         https://bugs.webkit.org/show_bug.cgi?id=100004
771
772         Reviewed by Rob Buis.
773
774         PR 214342.
775
776         Remove special handling for isIndex field as the tag
777         is rewritten.
778
779         Reviewed Internally by Yongxin Dai and Nima Ghanavatian.
780
781         * WebKitSupport/InputHandler.cpp:
782         (BlackBerry::WebKit::inputStyle):
783         (BlackBerry::WebKit::InputHandler::elementType):
784
785 2012-10-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
786
787         [Qt] Fix "ASSERTION FAILED: !document->inPageCache()" when loading a page
788         https://bugs.webkit.org/show_bug.cgi?id=98514
789
790         Reviewed by Kenneth Rohde Christiansen.
791
792         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
793         (WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):
794
795 2012-10-20  Andrew Lo  <anlo@rim.com>
796
797         [BlackBerry] m_mainFrame should be null checked before use in WebPagePrivate destructor
798         https://bugs.webkit.org/show_bug.cgi?id=99916
799
800         Reviewed by George Staikos.
801         Internally reviewed by Arvid Nilsson.
802
803         Internal PR228029
804         Add null checks for m_mainFrame for things that happen during
805         WebPage destruction.
806
807         * Api/WebPage.cpp:
808         (BlackBerry::WebKit::WebPagePrivate::setVisible):
809         (BlackBerry::WebKit::WebPagePrivate::setCompositorDrawsRootLayer):
810
811 2012-10-19  Mike Fenton  <mifenton@rim.com>
812
813         [BlackBerry] Convert input style to int64_t
814         https://bugs.webkit.org/show_bug.cgi?id=99848
815
816         Reviewed by Yong Li.
817
818         PR 227381.
819
820         Switch input style mask to int64_t to match the the updated definition.
821
822         Reviewed Internally by Nima Ghanavatian.
823
824         * Api/WebPageClient.h:
825         * WebKitSupport/InputHandler.cpp:
826         (BlackBerry::WebKit::inputStyle):
827         * WebKitSupport/InputHandler.h:
828         (InputHandler):
829
830 2012-10-19  Mike Fenton  <mifenton@rim.com>
831
832         [BlackBerry] Move all keyboard type calculations into InputHandler.
833         https://bugs.webkit.org/show_bug.cgi?id=99847
834
835         Reviewed by Yong Li.
836
837         PR 227381.
838
839         Move all keyboard type calculations into webkit and avoid passing type
840         information to the webview.
841
842         Reviewed Internally by Nima Ghanavatian.
843
844         * Api/WebPageClient.h:
845         * WebKitSupport/InputHandler.cpp:
846         (BlackBerry::WebKit::convertInputTypeToVKBType):
847         (WebKit):
848         (BlackBerry::WebKit::InputHandler::setElementFocused):
849
850 2012-10-19  Jacky Jiang  <zhajiang@rim.com>
851
852         [BlackBerry] Page viewport aspect ratio not kept on navigating back
853         https://bugs.webkit.org/show_bug.cgi?id=99760
854
855         Reviewed by Yong Li.
856         Internally reviewed by Konrad Piascik
857
858         PR: 222437
859         This is to fix the second issue on PR222437 that the viewport not kept
860         when navigating back from google after rotation to bloomberg.
861         We were trying to restore the history contents size and scale of
862         bloomberg which has virtual viewport. The scale would be recalculated
863         based on the new screen size. However, we would still use the current
864         contents size if it was greater than the history contents size in
865         FrameView::setContentsSize which made the contents seem to be scaled
866         too much.
867         Actually when we relayout the contents after rotation change, the
868         current contents size which is based on the virtual viewport has taken
869         the screen size into account. Shrinking the contents size will be
870         expensive. So we can ignore screen size based scale calculation here.
871
872         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
873         (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
874
875 2012-10-19  Mike Fenton  <mifenton@rim.com>
876
877         [BlackBerry] Add input logs to InputHandler::ensureFocusTextElementVisible.
878         https://bugs.webkit.org/show_bug.cgi?id=99837
879
880         Reviewed by Antonio Gomes.
881
882         Add input logs for InputHandler::ensureFocusTextElementVisible.
883
884         Reviewed Internally by Nima Ghanavatian.
885
886         * WebKitSupport/InputHandler.cpp:
887         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
888
889 2012-10-19  Andrew Lo  <anlo@rim.com>
890
891         [BlackBerry] Should suspend AnimationController when WebPage becomes invisible.
892         https://bugs.webkit.org/show_bug.cgi?id=99844
893
894         Reviewed by Yong Li.
895         Internally reviewed by Arvid Nilsson & Yong Li.
896
897         Suspend animation controller when the tab becomes invisible,
898         in addition to suspending scripted animations.
899
900         * Api/WebPage.cpp:
901         (BlackBerry::WebKit::WebPagePrivate::setVisible):
902
903 2012-10-19  Mike Fenton  <mifenton@rim.com>
904
905         [BlackBerry] Don't attempt to auto scroll on input for Fixed Position elements.
906         https://bugs.webkit.org/show_bug.cgi?id=99833
907
908         Reviewed by Antonio Gomes.
909
910         PR 195024.
911
912         Don't attempt to scroll fixed position elements.
913
914         Reviewed Internally by Arvid Nilsson.
915
916         * WebKitSupport/DOMSupport.cpp:
917         (BlackBerry::WebKit::DOMSupport::isFixedPositionOrHasFixedPositionAncestor):
918         (DOMSupport):
919         * WebKitSupport/DOMSupport.h:
920         (WebCore):
921         * WebKitSupport/InputHandler.cpp:
922         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
923
924 2012-10-18  Jacky Jiang  <zhajiang@rim.com>
925
926         [BlackBerry] Page viewport aspect ratio not kept on navigating back
927         https://bugs.webkit.org/show_bug.cgi?id=99760
928
929         Reviewed by Rob Buis.
930         Internally reviewed by Konrad Piascik.
931
932         PR: 190469
933         This was added in r127628 which was trying to fix some rendering
934         defects on maps.google.com and news.qq.com, however it was very harmful
935         and caused regressions.
936         zoomToFitScale() depends on the current contents size. During history
937         navigation and device rotation, if zoomToFitScale() is based on the
938         final contents size which is expected, there will still be a scale
939         calculation like this afterwards
940         screenSize.width()/screenSize.height()*zoomToFitScale() which will
941         result in a wrong scale. During the history navigation, if
942         zoomToFitScale() isn't based on the final contents size, then we will
943         get the wrong scale as well for sure.
944         This issue will be fixed by removing the wrong calculation.
945         The original issue of r127628 was fixed by the patch of PR225981.
946
947         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
948         (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
949
950 2012-10-18  John Griggs  <jgriggs@rim.com>
951
952         2012-10-18  John Griggs  <jgriggs@rim.com>
953
954         Crash in InRegionScrollableArea constructor while loading page
955         https://bugs.webkit.org/show_bug.cgi?id=99733
956
957         Reviewed by Antonio Gomes.
958
959         Check scrollLayer and avoid constructing InRegionScrollableArea when it is NULL.
960
961         * Api/InRegionScroller.cpp:
962         (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
963
964 2012-10-17  Jacky Jiang  <zhajiang@rim.com>
965
966         [BlackBerry] Possible redundant zoomToInitialScaleOnLoad() in WebPagePrivate::setLoadState
967         https://bugs.webkit.org/show_bug.cgi?id=99624
968
969         Reviewed by Rob Buis.
970         Internally reviewed by Arvid Nilsson
971
972         PR: 225981
973         Several reasons to eliminate the ancient unnecessary
974         zoomToInitialScaleOnLoad() in WebPagePrivate::setLoadState committed:
975         - At this point, we have only committed the data we received.
976         - For the new load, we haven't started parsing the tokens and building
977           the DOM tree and the first layout will happen after that.
978         - For the load restored from cache, the first layout will happen after
979           setLoadState committed which is called by
980           FrameLoader::dispatchDidCommitLoad().
981         - zoomToInitialScaleOnLoad() can still be called after the first
982           layout finished.
983         - zoomToInitialScaleOnLoad() is expensive and it will boost the load
984           performance after the removal.
985         - Removal of this can fix some weird rendering defects on yahoo.com,
986           maps.google.com, news.qq.com and so on during load and rotation
987           mentioned on the PR.
988
989         * Api/WebPage.cpp:
990         (BlackBerry::WebKit::WebPagePrivate::setLoadState):
991
992 2012-10-17  Mike Fenton  <mifenton@rim.com>
993
994         [BlackBerry] Prevent focus zoom on non-userscalable pages.
995         https://bugs.webkit.org/show_bug.cgi?id=99608
996
997         Reviewed by Rob Buis.
998
999         PR 222378.
1000
1001         Disable focus zoom when the page is non-user scalable.
1002
1003         Reviewed Internally by Nima Ghanavatian.
1004
1005         * WebKitSupport/InputHandler.cpp:
1006         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
1007
1008 2012-10-16  Mike Lattanzio  <mlattanzio@rim.com>
1009
1010         2012-10-16  Mike Lattanzio  <mlattanzio@rim.com>
1011
1012         [BlackBerry] calculateInRegionScrollableAreasForPoint should use a ReadOnly HitTest
1013         https://bugs.webkit.org/show_bug.cgi?id=99497
1014
1015         Reviewed by Antonio Gomes.
1016
1017         Fix calculateInRegionScrollableAreasForPoint to use a ReadOnly
1018         hit test to improve its performance.
1019
1020         * Api/InRegionScroller.cpp:
1021         (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
1022
1023 2012-10-15  Peter Wang  <peter.wang@torchmobile.com.cn>
1024
1025         [BlackBerry] Web Inspector: Remove the useless preferences items in "inspectorBB.js"
1026         https://bugs.webkit.org/show_bug.cgi?id=99404
1027
1028         Reviewed by George Staikos.
1029
1030         In "inspectorBB.js", remove the useless preferences items to catch up the new code of frontend.
1031
1032         * WebCoreSupport/inspectorBB.js:
1033
1034 2012-10-15  Jakob Petsovits  <jpetsovits@rim.com>
1035
1036         [BlackBerry] Only reallocate buffers that were allocated before suspending
1037         https://bugs.webkit.org/show_bug.cgi?id=99205
1038         RIM PR 99395
1039
1040         Reviewed by Antonio Gomes.
1041
1042         When we call releaseBuffers(), not all of the backingstore
1043         tile buffers might have been allocated yet. Still we try
1044         to release all of them, which causes us to lazy-initialize
1045         the tile buffers so we can release them again.
1046
1047         This is stupid and we should just ignore buffers that
1048         haven't been initialized yet. This patch makes that change.
1049
1050         * WebKitSupport/BackingStoreTile.cpp:
1051         (BlackBerry::WebKit::TileBuffer::wasNativeBufferCreated):
1052         (WebKit):
1053         * WebKitSupport/BackingStoreTile.h:
1054         (TileBuffer):
1055         * WebKitSupport/SurfacePool.cpp:
1056         (BlackBerry::WebKit::SurfacePool::createBuffers):
1057         (BlackBerry::WebKit::SurfacePool::releaseBuffers):
1058
1059 2012-10-15  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
1060
1061         [BlackBerry] replace BlackBerry::Platform::log() with BBLOG()
1062         https://bugs.webkit.org/show_bug.cgi?id=99302
1063
1064         Reviewed by Rob Buis.
1065
1066         RIM PR: 210884
1067         The marco BBLOG() is defined as a no-op in release mode which will
1068         save a function call in the release build.
1069         Internally reviewed by Charles Wei.
1070
1071         * Api/BackingStore.cpp:
1072         (BlackBerry::WebKit::bestDivisor):
1073         (BlackBerry::WebKit::BackingStorePrivate::suspendScreenAndBackingStoreUpdates):
1074         (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
1075         (BlackBerry::WebKit::BackingStorePrivate::repaint):
1076         (BlackBerry::WebKit::BackingStorePrivate::slowScroll):
1077         (BlackBerry::WebKit::BackingStorePrivate::scroll):
1078         (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
1079         (BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
1080         (BlackBerry::WebKit::BackingStorePrivate::render):
1081         (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
1082         (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
1083         (BlackBerry::WebKit::BackingStorePrivate::renderContents):
1084         (BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
1085         (BlackBerry::WebKit::BackingStorePrivate::fillWindow):
1086         (BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
1087         (BlackBerry::WebKit::BackingStorePrivate::clearWindow):
1088         * Api/WebPage.cpp:
1089         (BlackBerry::WebKit::WebPagePrivate::setLoadState):
1090         (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
1091         (BlackBerry::WebKit::WebPagePrivate::contentsSizeChanged):
1092         (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
1093         (BlackBerry::WebKit::WebPagePrivate::scheduleRootLayerCommit):
1094         (BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
1095         (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
1096         (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
1097         * WebCoreSupport/ChromeClientBlackBerry.cpp:
1098         (WebCore::ChromeClientBlackBerry::overflowExceedsContentsSize):
1099         (WebCore::ChromeClientBlackBerry::didDiscoverFrameSet):
1100         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1101         (WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):
1102         * WebKitSupport/FatFingers.cpp:
1103         (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
1104         (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
1105         (BlackBerry::WebKit::FatFingers::checkForText):
1106         * WebKitSupport/RenderQueue.cpp:
1107         (BlackBerry::WebKit::RenderQueue::addToRegularQueue):
1108         (BlackBerry::WebKit::RenderQueue::addToScrollZoomQueue):
1109         (BlackBerry::WebKit::RenderQueue::render):
1110         (BlackBerry::WebKit::RenderQueue::renderAllCurrentRegularRenderJobs):
1111         (BlackBerry::WebKit::RenderQueue::startRegularRenderJobBatchIfNeeded):
1112         (BlackBerry::WebKit::RenderQueue::renderVisibleZoomJob):
1113         (BlackBerry::WebKit::RenderQueue::renderVisibleScrollJob):
1114         (BlackBerry::WebKit::RenderQueue::renderRegularRenderJob):
1115         (BlackBerry::WebKit::RenderQueue::renderNonVisibleScrollJob):
1116         * WebKitSupport/SurfacePool.cpp:
1117         (BlackBerry::WebKit::SurfacePool::initialize):
1118
1119 2012-10-15  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1120
1121         [BlackBerry] [DRT] Skip region of interest zooming when running DRT
1122         https://bugs.webkit.org/show_bug.cgi?id=97663
1123
1124         Reviewed by Rob Buis.
1125
1126         This patch fixes test fast/forms/textarea-scrolled-endline-caret.html, and
1127         1. Add a global function isRunningDrt to check if we're currently running DRT.
1128         2. Use the new function in places where getenv("drtRun") is used.
1129
1130         * Api/BlackBerryGlobal.cpp:
1131         (BlackBerry::WebKit::isRunningDrt):
1132         (WebKit):
1133         * Api/BlackBerryGlobal.h:
1134         (WebKit):
1135         * Api/WebPage.cpp:
1136         (BlackBerry::WebKit::WebPagePrivate::init):
1137         * WebKitSupport/DumpRenderTreeSupport.cpp:
1138         (toGeolocationClientMock):
1139         * WebKitSupport/InputHandler.cpp:
1140         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
1141
1142 2012-10-15  George Staikos  <staikos@webkit.org>
1143
1144         [BlackBerry] Adapt to Platform API changes in string handling
1145         https://bugs.webkit.org/show_bug.cgi?id=99248
1146
1147         Reviewed by Yong Li.
1148
1149         Convert usage of WebString, char* and std::string to BlackBerry::Platform::String.
1150
1151         * Api/BlackBerryGlobal.cpp:
1152         (BlackBerry::WebKit::clearAppCache):
1153         (BlackBerry::WebKit::clearDatabase):
1154         * Api/BlackBerryGlobal.h:
1155         (Platform):
1156         (WebKit):
1157         * Api/JavaScriptVariant.cpp:
1158         (BlackBerry::WebKit::JSValueRefToBlackBerryJavaScriptVariant):
1159         (BlackBerry::WebKit::BlackBerryJavaScriptVariantToJSValueRef):
1160         (BlackBerry::WebKit::JavaScriptVariant::JavaScriptVariant):
1161         (WebKit):
1162         (BlackBerry::WebKit::JavaScriptVariant::~JavaScriptVariant):
1163         (BlackBerry::WebKit::JavaScriptVariant::setType):
1164         (BlackBerry::WebKit::JavaScriptVariant::setString):
1165         (BlackBerry::WebKit::JavaScriptVariant::stringValue):
1166         * Api/JavaScriptVariant.h:
1167         * Api/WebAnimation.cpp:
1168         (BlackBerry::WebKit::WebAnimation::fadeAnimation):
1169         (BlackBerry::WebKit::WebAnimation::name):
1170         * Api/WebAnimation.h:
1171         * Api/WebCookieJar.cpp:
1172         (BlackBerry::WebKit::WebCookieJar::cookies):
1173         (BlackBerry::WebKit::WebCookieJar::setCookies):
1174         * Api/WebCookieJar.h:
1175         (Platform):
1176         (BlackBerry):
1177         (WebKit):
1178         * Api/WebKitMIMETypeConverter.cpp:
1179         (BlackBerry::WebKit::getExtensionForMimeType):
1180         (BlackBerry::WebKit::getMimeTypeForExtension):
1181         * Api/WebKitMIMETypeConverter.h:
1182         (Platform):
1183         (BlackBerry):
1184         (WebKit):
1185         * Api/WebKitTextCodec.cpp:
1186         (BlackBerry::WebKit::base64Decode):
1187         (BlackBerry::WebKit::base64Encode):
1188         (BlackBerry::WebKit::unescapeURL):
1189         (BlackBerry::WebKit::escapeURL):
1190         * Api/WebKitTextCodec.h:
1191         (Platform):
1192         (BlackBerry):
1193         * Api/WebOverlay.cpp:
1194         (BlackBerry::WebKit::WebOverlay::removeAnimation):
1195         * Api/WebOverlay.h:
1196         (Platform):
1197         (BlackBerry):
1198         (WebKit):
1199         * Api/WebOverlayOverride.cpp:
1200         (BlackBerry::WebKit::WebOverlayOverride::removeAnimation):
1201         * Api/WebOverlayOverride.h:
1202         (Platform):
1203         (BlackBerry):
1204         (WebKit):
1205         * Api/WebPage.cpp:
1206         (BlackBerry::WebKit::WebPage::autofillTextField):
1207         (BlackBerry::WebKit::WebPage::renderTreeAsText):
1208         (BlackBerry::WebKit::WebPage::WebPage):
1209         (BlackBerry::WebKit::WebPagePrivate::init):
1210         (BlackBerry::WebKit::WebPagePrivate::load):
1211         (BlackBerry::WebKit::WebPage::load):
1212         (BlackBerry::WebKit::WebPage::loadFile):
1213         (BlackBerry::WebKit::WebPage::download):
1214         (BlackBerry::WebKit::WebPagePrivate::loadString):
1215         (BlackBerry::WebKit::WebPage::loadString):
1216         (BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
1217         (BlackBerry::WebKit::WebPage::executeJavaScript):
1218         (BlackBerry::WebKit::WebPagePrivate::executeJavaScriptInIsolatedWorld):
1219         (BlackBerry::WebKit::WebPage::executeJavaScriptInIsolatedWorld):
1220         (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
1221         (BlackBerry::WebKit::WebPagePrivate::addOriginAccessWhitelistEntry):
1222         (BlackBerry::WebKit::WebPage::addOriginAccessWhitelistEntry):
1223         (BlackBerry::WebKit::WebPagePrivate::removeOriginAccessWhitelistEntry):
1224         (BlackBerry::WebKit::WebPage::removeOriginAccessWhitelistEntry):
1225         (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
1226         (BlackBerry::WebKit::WebPagePrivate::syncProxyCredential):
1227         (BlackBerry::WebKit::WebPagePrivate::notifyPopupAutofillDialog):
1228         (BlackBerry::WebKit::WebPagePrivate::webContext):
1229         (BlackBerry::WebKit::WebPage::setDateTimeInput):
1230         (BlackBerry::WebKit::WebPage::setColorInput):
1231         (BlackBerry::WebKit::WebPage::textEncoding):
1232         (BlackBerry::WebKit::WebPage::forcedTextEncoding):
1233         (BlackBerry::WebKit::WebPage::setForcedTextEncoding):
1234         (BlackBerry::WebKit::WebPage::title):
1235         (BlackBerry::WebKit::WebPage::selectedText):
1236         (BlackBerry::WebKit::WebPage::cutSelectedText):
1237         (BlackBerry::WebKit::WebPage::insertText):
1238         (BlackBerry::WebKit::WebPage::getBackForwardList):
1239         (BlackBerry::WebKit::WebPage::onCertificateStoreLocationSet):
1240         (BlackBerry::WebKit::WebPage::dispatchInspectorMessage):
1241         (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
1242         (BlackBerry::WebKit::WebPage::textHasAttribute):
1243         (BlackBerry::WebKit::WebPage::setAllowNotification):
1244         (BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):
1245         * Api/WebPage.h:
1246         * Api/WebPageClient.h:
1247         * Api/WebPage_p.h:
1248         (WebPagePrivate):
1249         * Api/WebSettings.cpp:
1250         (BlackBerry::WebKit::WebSettings::standardSettings):
1251         (BlackBerry::WebKit::WebSettings::addSupportedObjectPluginMIMEType):
1252         (BlackBerry::WebKit::WebSettings::isSupportedObjectMIMEType):
1253         (BlackBerry::WebKit::WebSettings::serifFontFamily):
1254         (BlackBerry::WebKit::WebSettings::setSerifFontFamily):
1255         (BlackBerry::WebKit::WebSettings::fixedFontFamily):
1256         (BlackBerry::WebKit::WebSettings::setFixedFontFamily):
1257         (BlackBerry::WebKit::WebSettings::sansSerifFontFamily):
1258         (BlackBerry::WebKit::WebSettings::setSansSerifFontFamily):
1259         (BlackBerry::WebKit::WebSettings::standardFontFamily):
1260         (BlackBerry::WebKit::WebSettings::setStandardFontFamily):
1261         (BlackBerry::WebKit::WebSettings::userAgentString):
1262         (BlackBerry::WebKit::WebSettings::setUserAgentString):
1263         (BlackBerry::WebKit::WebSettings::defaultTextEncodingName):
1264         (BlackBerry::WebKit::WebSettings::setDefaultTextEncodingName):
1265         (BlackBerry::WebKit::WebSettings::userStyleSheetString):
1266         (BlackBerry::WebKit::WebSettings::setUserStyleSheetString):
1267         (BlackBerry::WebKit::WebSettings::userStyleSheetLocation):
1268         (BlackBerry::WebKit::WebSettings::setUserStyleSheetLocation):
1269         (BlackBerry::WebKit::WebSettings::localStoragePath):
1270         (BlackBerry::WebKit::WebSettings::setLocalStoragePath):
1271         (BlackBerry::WebKit::WebSettings::indexedDataBasePath):
1272         (BlackBerry::WebKit::WebSettings::setIndexedDataBasePath):
1273         (BlackBerry::WebKit::WebSettings::databasePath):
1274         (BlackBerry::WebKit::WebSettings::setDatabasePath):
1275         (BlackBerry::WebKit::WebSettings::appCachePath):
1276         (BlackBerry::WebKit::WebSettings::setAppCachePath):
1277         (BlackBerry::WebKit::WebSettings::pageGroupName):
1278         (BlackBerry::WebKit::WebSettings::setPageGroupName):
1279         * Api/WebSettings.h:
1280         * Api/WebString.cpp: Removed.
1281         * Api/WebString.h: Removed.
1282         * WebCoreSupport/ChromeClientBlackBerry.cpp:
1283         (WebCore::ChromeClientBlackBerry::runJavaScriptPrompt):
1284         (WebCore::ChromeClientBlackBerry::createWindow):
1285         (WebCore::ChromeClientBlackBerry::runOpenPanel):
1286         (WebCore):
1287         * WebCoreSupport/ChromeClientBlackBerry.h:
1288         (ChromeClientBlackBerry):
1289         * WebCoreSupport/ClientExtension.cpp:
1290         (clientExtensionMethod):
1291         * WebCoreSupport/ColorPickerClient.cpp:
1292         (WebCore::ColorPickerClient::ColorPickerClient):
1293         (WebCore::ColorPickerClient::generateHTML):
1294         * WebCoreSupport/ColorPickerClient.h:
1295         (Platform):
1296         (BlackBerry):
1297         (WebKit):
1298         (ColorPickerClient):
1299         * WebCoreSupport/CredentialManager.cpp:
1300         (WebCore::CredentialManager::autofillAuthenticationChallenge):
1301         * WebCoreSupport/CredentialManager.h:
1302         (Platform):
1303         (CredentialManager):
1304         * WebCoreSupport/DatePickerClient.cpp:
1305         (WebCore::DatePickerClient::DatePickerClient):
1306         (WebCore::DatePickerClient::generateHTML):
1307         * WebCoreSupport/DatePickerClient.h:
1308         (Platform):
1309         (BlackBerry):
1310         (WebKit):
1311         (DatePickerClient):
1312         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1313         (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForResponse):
1314         (WebCore::FrameLoaderClientBlackBerry::createDocumentLoader):
1315         (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
1316         (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
1317         (WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
1318         (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
1319         (WebCore::FrameLoaderClientBlackBerry::loadIconExternally):
1320         (WebCore::FrameLoaderClientBlackBerry::startDownload):
1321         (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
1322         * WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
1323         * WebCoreSupport/NotificationPresenterImpl.cpp:
1324         (WebCore::NotificationPresenterImpl::show):
1325         (WebCore::NotificationPresenterImpl::cancel):
1326         (WebCore::NotificationPresenterImpl::requestPermission):
1327         (WebCore::NotificationPresenterImpl::onPermission):
1328         (WebCore::NotificationPresenterImpl::notificationClicked):
1329         * WebCoreSupport/NotificationPresenterImpl.h:
1330         (Platform):
1331         (NotificationPresenterImpl):
1332         * WebCoreSupport/SelectPopupClient.cpp:
1333         (WebCore::SelectPopupClient::SelectPopupClient):
1334         (WebCore::SelectPopupClient::update):
1335         (WebCore::SelectPopupClient::generateHTML):
1336         * WebCoreSupport/SelectPopupClient.h:
1337         (Platform):
1338         (BlackBerry):
1339         (SelectPopupClient):
1340         * WebCoreSupport/UserMediaClientImpl.cpp:
1341         (WebCore::toMediaStreamSource):
1342         (WebCore::toMediaStreamDescriptor):
1343         (WebCore::UserMediaClientImpl::requestUserMedia):
1344         (WebCore::UserMediaClientImpl::cancelUserMediaRequest):
1345         * WebKitSupport/AboutData.cpp:
1346         (BlackBerry::WebKit::cachePage):
1347         * WebKitSupport/InputHandler.cpp:
1348         (BlackBerry::WebKit::convertStringToWchar):
1349         (BlackBerry::WebKit::convertStringToWcharVector):
1350         (BlackBerry::WebKit::convertSpannableStringToString):
1351         (BlackBerry::WebKit::InputHandler::learnText):
1352         (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
1353         (BlackBerry::WebKit::InputHandler::openDatePopup):
1354         (BlackBerry::WebKit::InputHandler::openSelectPopup):
1355         (BlackBerry::WebKit::InputHandler::setText):
1356         * WebKitSupport/SelectionHandler.cpp:
1357         (BlackBerry::WebKit::SelectionHandler::selectedText):
1358         * WebKitSupport/SelectionHandler.h:
1359         (Platform):
1360         (WebKit):
1361         (SelectionHandler):
1362         * WebKitSupport/SurfacePool.cpp:
1363         (BlackBerry::WebKit::SurfacePool::sharedPixmapGroup):
1364         * WebKitSupport/SurfacePool.h:
1365         (SurfacePool):
1366
1367 2012-10-15  Antonio Gomes  <agomes@rim.com>
1368
1369         [BlackBerry] Clean up BackingStoreClient (part II)
1370         https://bugs.webkit.org/show_bug.cgi?id=99327
1371
1372         Reviewed by Yong Li.
1373
1374         Remove more unneeded BackingStoreClient <-> WebPageClient integration
1375         methods:
1376         - BackingStoreClient* backingStoreClientForFrame(...)
1377         - void addBackingStoreClientForFrame(...)
1378         - void removeBackingStoreClientForFrame(...)
1379
1380         Change places calling WPPriv::backingStoreClientForFrame to directly
1381         access WPPriv::backingStoreClient instead, since only the main frame will
1382         have a BackingStoreClient instance associated with it, and it is owned by
1383         the WKPriv.
1384
1385         Remove non-mainframe only references to BackingStoreClient completely,
1386         since it is dead code now.
1387
1388         * Api/InRegionScroller.cpp:
1389         (BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
1390         * Api/WebPage.cpp:
1391         (BlackBerry::WebKit::WebPagePrivate::backingStoreClient):
1392         (BlackBerry::WebKit::WebPage::destroy):
1393         * Api/WebPage_p.h:
1394         (WebPagePrivate):
1395         * WebCoreSupport/ChromeClientBlackBerry.cpp:
1396         (WebCore::ChromeClientBlackBerry::invalidateContentsForSlowScroll):
1397         (WebCore::ChromeClientBlackBerry::scroll):
1398         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1399         (WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):
1400         (WebCore::FrameLoaderClientBlackBerry::createFrame):
1401         (WebCore::FrameLoaderClientBlackBerry::detachedFromParent2):
1402         * WebKitSupport/BackingStoreClient.cpp:
1403         (BlackBerry::WebKit::BackingStoreClient::create):
1404         (BlackBerry::WebKit::BackingStoreClient::BackingStoreClient):
1405         (BlackBerry::WebKit::BackingStoreClient::~BackingStoreClient):
1406         * WebKitSupport/BackingStoreClient.h:
1407         (BackingStoreClient):
1408         * WebKitSupport/InputHandler.cpp:
1409         (BlackBerry::WebKit::InputHandler::setBatchEditingActive):
1410
1411 2012-10-15  Antonio Gomes  <agomes@rim.com>
1412
1413         [BlackBerry] Clean up BackingStoreClient (part I)
1414         https://bugs.webkit.org/show_bug.cgi?id=99327
1415
1416         Reviewed by Yong Li.
1417
1418         Now that we won't use the BackingStoreClient code path to scroll inner frames at all
1419         (instead we use AC layers!), we can remove all "!isMainFrame" code paths.
1420
1421         No behavior change, since the code path being removed was not in use.
1422
1423         * WebKitSupport/BackingStoreClient.cpp:
1424         (BlackBerry::WebKit::BackingStoreClient::absoluteRect):
1425         (BlackBerry::WebKit::BackingStoreClient::transformedActualVisibleSize):
1426         (BlackBerry::WebKit::BackingStoreClient::viewportSize):
1427         (BlackBerry::WebKit::BackingStoreClient::transformedViewportSize):
1428         (BlackBerry::WebKit::BackingStoreClient::visibleContentsRect):
1429         (BlackBerry::WebKit::BackingStoreClient::transformedVisibleContentsRect):
1430         (BlackBerry::WebKit::BackingStoreClient::checkOriginOfCurrentScrollOperation):
1431
1432 2012-10-13  Jakob Petsovits  <jpetsovits@rim.com>
1433
1434         [BlackBerry] Fetch blit rects from a viewport accessor
1435         https://bugs.webkit.org/show_bug.cgi?id=98581
1436         RIM PR 173292
1437
1438         Reviewed by George Staikos.
1439         Internally reviewed by Arvid Nilsson.
1440
1441         The long-standing userInterfaceBlittedVisibleContentsRect()
1442         method in WebPageClient has long been a major annoyance,
1443         as it returns the source rect for WebKit contents but in
1444         backingstore pixel coordinates. This makes it not only
1445         unwieldy but also terribly fragile, especially when
1446         both pinch zoom and a backingstore re-render both deal
1447         with the same rectangle. On different threads, even.
1448
1449         BlackBerry::Platform now exposes a ViewportAccessor
1450         interface, which can be used to get the various rects
1451         in document coordinates or target pixel coordinates,
1452         both being a better choice than the ones dependent
1453         on an implentation detail.
1454
1455         This commit makes use of this new functionality.
1456         Instead of relying on the passed rectangle to contain
1457         implicit information about the scale factor, we now
1458         track the scale of each backingstore geometry by making
1459         a snapshot of the current WebKit-thread scale when the
1460         geometry is generated. Once the geometry is swapped to
1461         the front, we can then calculate the remaining
1462         backingstore-to-viewport transformation in a threadsafe
1463         way. We now only calculate this if we actually blit from
1464         backingstore tiles and don't go through a configuration
1465         of pure accelerated compositing.
1466
1467         As a result, we are now a lot more robust against
1468         synchonization issues related to backingstore
1469         geometry changes. As an additional gimmick, the scale
1470         is also stored with each tile buffer to doubly secure
1471         that a tile rendered in one scale is not transferred
1472         to a different geometry and then rendered there without
1473         being rerendered at the new scale, even if the rendered
1474         pixel coordinates are still the same.
1475
1476         Having per-geometry scale information also opens up
1477         opportunities to further improve backingstore rendering
1478         later. For instance, we could pre-render a low-res
1479         version of the page onto one buffer and combine that one
1480         with a higher-res array of tiles covering a smaller area.
1481         Or we could steal some tiles from the front geometry to
1482         render them at a new scale while a pinch-zoom operation
1483         is in progress.
1484
1485         No such thing is implemented in this patch though.
1486
1487         In adapting/fixing the backingstore visualization
1488         debug mode and the default background painting in
1489         renderDirectToWindow(), we also introduce new
1490         ViewportAccessor subclasses that can subsequently
1491         be used to replace methods from WebPage and elsewhere.
1492
1493         * Api/BackingStore.cpp:
1494         (BlackBerry::WebKit::BackingStorePrivate::slowScroll):
1495         (BlackBerry::WebKit::BackingStorePrivate::scroll):
1496         (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
1497         (BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
1498         (BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
1499         (BlackBerry::WebKit::BackingStorePrivate::render):
1500         (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
1501         (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
1502         (BlackBerry::WebKit::BackingStorePrivate::blitHorizontalScrollbar):
1503         (BlackBerry::WebKit::BackingStorePrivate::blitVerticalScrollbar):
1504         (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
1505         (BlackBerry::WebKit::BackingStorePrivate::updateTileMatrixIfNeeded):
1506         (BlackBerry::WebKit::BackingStorePrivate::orientationChanged):
1507         (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
1508         (BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
1509         * Api/BackingStore_p.h:
1510         (BlackBerry):
1511         (Platform):
1512         (BlackBerry::WebKit::BackingStoreGeometry::BackingStoreGeometry):
1513         (BlackBerry::WebKit::BackingStoreGeometry::scale):
1514         (BlackBerry::WebKit::BackingStoreGeometry::setScale):
1515         (BackingStoreGeometry):
1516         (BackingStorePrivate):
1517         * Api/WebPage.cpp:
1518         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
1519         (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
1520         (BlackBerry::WebKit::WebPagePrivate::init):
1521         (BlackBerry::WebKit::WebPage::webkitThreadViewportAccessor):
1522         (WebKit):
1523         * Api/WebPage.h:
1524         (Platform):
1525         * Api/WebPageClient.h:
1526         (Platform):
1527         * Api/WebPageCompositor.cpp:
1528         (BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):
1529         * Api/WebPage_p.h:
1530         (WebKit):
1531         (WebPagePrivate):
1532         * WebKitSupport/BackingStoreTile.cpp:
1533         (BlackBerry::WebKit::TileBuffer::TileBuffer):
1534         (BlackBerry::WebKit::TileBuffer::isRendered):
1535         * WebKitSupport/BackingStoreTile.h:
1536         (TileBuffer):
1537         (BlackBerry::WebKit::TileBuffer::scale):
1538         (BlackBerry::WebKit::TileBuffer::setScale):
1539         * WebKitSupport/BackingStoreVisualizationViewportAccessor.cpp: Added.
1540         (WebKit):
1541         (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::BackingStoreVisualizationViewportAccessor):
1542         (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::pixelContentsSize):
1543         (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::documentContentsSize):
1544         (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::pixelScrollPosition):
1545         (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::documentScrollPosition):
1546         (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::pixelViewportSize):
1547         (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::documentViewportSize):
1548         (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::destinationSurfaceOffset):
1549         (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::scale):
1550         (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::state):
1551         * WebKitSupport/BackingStoreVisualizationViewportAccessor.h: Added.
1552         (BlackBerry):
1553         (Platform):
1554         (WebKit):
1555         (BackingStoreVisualizationViewportAccessor):
1556         (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::~BackingStoreVisualizationViewportAccessor):
1557         * WebKitSupport/WebKitThreadViewportAccessor.cpp: Added.
1558         (WebKit):
1559         (BlackBerry::WebKit::WebKitThreadViewportAccessor::WebKitThreadViewportAccessor):
1560         (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelContentsSize):
1561         (BlackBerry::WebKit::WebKitThreadViewportAccessor::documentContentsSize):
1562         (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelScrollPosition):
1563         (BlackBerry::WebKit::WebKitThreadViewportAccessor::documentScrollPosition):
1564         (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelViewportSize):
1565         (BlackBerry::WebKit::WebKitThreadViewportAccessor::documentViewportSize):
1566         (BlackBerry::WebKit::WebKitThreadViewportAccessor::destinationSurfaceOffset):
1567         (BlackBerry::WebKit::WebKitThreadViewportAccessor::scale):
1568         * WebKitSupport/WebKitThreadViewportAccessor.h: Added.
1569         (BlackBerry):
1570         (Platform):
1571         (WebKit):
1572         (WebKitThreadViewportAccessor):
1573         (BlackBerry::WebKit::WebKitThreadViewportAccessor::~WebKitThreadViewportAccessor):
1574
1575 2012-10-11  Peter Wang  <peter.wang@torchmobile.com.cn>
1576
1577         [BlackBerry] Paused in Inspector, Browser doesn't exit cleanly
1578         https://bugs.webkit.org/show_bug.cgi?id=97962
1579
1580         Reviewed by George Staikos.
1581
1582         Before destroying webpage, close the inspector, so if the JSC is paused it will be resumed.
1583
1584         * Api/WebPage.cpp:
1585         (BlackBerry::WebKit::WebPage::destroy):
1586
1587 2012-10-11  Konrad Piascik  <kpiascik@rim.com>
1588
1589         Web Inspector: node search does not work with elements on touch start listener
1590         https://bugs.webkit.org/show_bug.cgi?id=95252
1591
1592         Reviewed by Pavel Feldman.
1593
1594         Removed calls to InspectorInstrumentation that no didn't work anyway.
1595
1596         * Api/WebPage.cpp:
1597         (BlackBerry::WebKit::WebPage::touchEvent):
1598
1599 2012-10-11  Chris Guan  <chris.guan@torchmobile.com.cn>
1600
1601         [Blackberry] makes NavigatorContentUtils work
1602         https://bugs.webkit.org/show_bug.cgi?id=99022
1603
1604         Reviewed by Rob Buis.
1605
1606         Because r126735 renamed RegisterProtocolHandler API to NavigatorContentUtils and 
1607         r122810 added RegisterProtocolHandlerClient to the Modules/protocolhandler,
1608         we need sync up code:
1609         1. Add NavigatorContentUtilsClientBlackBerry class.
1610         2. use new API provideNavigatorContentUtilsTo.
1611
1612         No new tests. Covered by existing tests.
1613
1614         * Api/WebPage.cpp:
1615         (BlackBerry::WebKit::WebPagePrivate::init):
1616         * WebCoreSupport/NavigatorContentUtilsClientBlackBerry.cpp: Added.
1617         (WebCore):
1618         (WebCore::NavigatorContentUtilsClientBlackBerry::NavigatorContentUtilsClientBlackBerry):
1619         (WebCore::NavigatorContentUtilsClientBlackBerry::registerProtocolHandler):
1620         (WebCore::NavigatorContentUtilsClientBlackBerry::isProtocolHandlerRegistered):
1621         (WebCore::NavigatorContentUtilsClientBlackBerry::unregisterProtocolHandler):
1622         * WebCoreSupport/NavigatorContentUtilsClientBlackBerry.h: Added.
1623         (WebKit):
1624         (NavigatorContentUtilsClientBlackBerry):
1625         (WebCore::NavigatorContentUtilsClientBlackBerry::~NavigatorContentUtilsClientBlackBerry):
1626
1627 2012-10-10  Lianghui Chen  <liachen@rim.com>
1628
1629         [BlackBerry] Fix assertion in NetworkJob::notifyChallengeResult.
1630         https://bugs.webkit.org/show_bug.cgi?id=97397
1631         Internal PR: 186597.
1632
1633         Internally reviewed by Yong Li, Joe Mason.
1634         Reviewed by George Staikos.
1635
1636         Update WebPage to use new AuthenticationChallengeManager.
1637         Register page creation/deletion and visibility change to the new
1638             AuthenticationChallengeManager.
1639         Initialize AuthenticationChallengeManager in GlobalInitialize() function.
1640
1641         * Api/BlackBerryGlobal.cpp:
1642         (BlackBerry::WebKit::globalInitialize):
1643         * Api/WebPage.cpp:
1644         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
1645         (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
1646         (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
1647         (BlackBerry::WebKit::WebPage::setVisible):
1648         * Api/WebPage_p.h:
1649         (WebPagePrivate):
1650
1651 2012-10-10  Andrew Lo  <anlo@rim.com>
1652
1653         [BlackBerry] Do not perform backing store blit for animations during one-shot drawing synchronization
1654         https://bugs.webkit.org/show_bug.cgi?id=98944
1655
1656         Reviewed by Rob Buis.
1657
1658         Internally reviewed by: Arvid Nilsson.
1659         Internal PR 220014
1660         Prevent animations from causing a backing store blit during a
1661         one-shot drawing synchronization.
1662
1663         * Api/WebPageCompositor.cpp:
1664         (BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):
1665
1666 2012-10-10  Mike Fenton  <mifenton@rim.com>
1667
1668         [BlackBerry] Fix crash for detached node when validating selection change.
1669         https://bugs.webkit.org/show_bug.cgi?id=98926
1670
1671         Reviewed by Rob Buis.
1672
1673         PR 220628.
1674
1675         Guard against detached nodes when generating selection rect.
1676
1677         * WebKitSupport/DOMSupport.cpp:
1678         (BlackBerry::WebKit::DOMSupport::visibleTextQuads):
1679
1680 2012-10-10  Mike Fenton  <mifenton@rim.com>
1681
1682         [BlackBerry] Adjust spell checking location to update after the cursor position is set.
1683         https://bugs.webkit.org/show_bug.cgi?id=98904
1684
1685         Reviewed by Rob Buis.
1686
1687         PR 215172.
1688
1689         Delay calculation of caret position until it is updated on mouse release
1690         handling.
1691
1692         Reviewed Internally by Nima Ghanavatian.
1693
1694         * WebKitSupport/InputHandler.cpp:
1695         (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
1696         (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
1697
1698 2012-10-10  Mike Fenton  <mifenton@rim.com>
1699
1700         [BlackBerry] Suppress keyboard requests while processing spell checking suggestions unless focus change is occurring..
1701         https://bugs.webkit.org/show_bug.cgi?id=98903
1702
1703         Reviewed by Rob Buis.
1704
1705         PR 221143.
1706
1707         Suppress keyboard state changes when they are not triggered by
1708         focus changes.
1709
1710         Reviewed Internally by Nima Ghanavatian.
1711
1712         * WebKitSupport/InputHandler.cpp:
1713         (BlackBerry::WebKit::InputHandler::setElementUnfocused):
1714         (BlackBerry::WebKit::InputHandler::setElementFocused):
1715         (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
1716         * WebKitSupport/InputHandler.h:
1717
1718 2012-10-09  Rob Buis  <rbuis@rim.com>
1719
1720         [BlackBerry] Cleanup FatFingers.cpp
1721         https://bugs.webkit.org/show_bug.cgi?id=98806
1722
1723         Reviewed by Antonio Gomes.
1724
1725         Cleanup namespace usage and sync up FatFingers.cpp.
1726
1727         * WebKitSupport/FatFingers.cpp:
1728         (BlackBerry::WebKit::compareDistanceBetweenPoints):
1729         (BlackBerry::WebKit::FatFingers::findBestPoint):
1730         (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
1731         (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
1732         (BlackBerry::WebKit::FatFingers::checkForClickableElement):
1733         (BlackBerry::WebKit::FatFingers::checkForText):
1734         (BlackBerry::WebKit::FatFingers::getNodesFromRect):
1735         (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
1736
1737 2012-10-09  Antonio Gomes  <agomes@rim.com>
1738
1739         Get rid of FIXED_POSITION_CREATES_STACKING_CONTEXT in favor of Settings::fixedPositionCreatesStackingContext()
1740         https://bugs.webkit.org/show_bug.cgi?id=98756
1741
1742         Reviewed by Rob Buis.
1743
1744         * Api/WebPage.cpp:
1745         (BlackBerry::WebKit::WebPagePrivate::init):
1746
1747 2012-10-09  Charles Wei  <charles.wei@torchmobile.com.cn>
1748
1749         [BlackBerry] Need API to control the DNS Prefetching
1750         https://bugs.webkit.org/show_bug.cgi?id=98713
1751
1752         Reviewed by George Staikos.
1753
1754         * Api/WebPage.cpp:
1755         (BlackBerry::WebKit::WebPagePrivate::init):
1756         (BlackBerry::WebKit::WebPage::enableDNSPrefetch):
1757         (WebKit):
1758         (BlackBerry::WebKit::WebPage::disableDNSPrefetch):
1759         (BlackBerry::WebKit::WebPage::isDNSPrefetchEnabled):
1760         * Api/WebPage.h:
1761
1762 2012-10-07  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1763
1764         Rename first/second to key/value in HashMap iterators
1765         https://bugs.webkit.org/show_bug.cgi?id=82784
1766
1767         Reviewed by Eric Seidel.
1768
1769         * Api/BackingStore.cpp:
1770         (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
1771         (BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect):
1772         (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
1773         (BlackBerry::WebKit::BackingStorePrivate::updateTiles):
1774         (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
1775         (BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles):
1776         * WebCoreSupport/NotificationPresenterImpl.cpp:
1777         (WebCore::NotificationPresenterImpl::cancel):
1778         (WebCore::NotificationPresenterImpl::onPermission):
1779         (WebCore::NotificationPresenterImpl::notificationClicked):
1780         * WebCoreSupport/UserMediaClientImpl.cpp:
1781         (WebCore::UserMediaClientImpl::cancelUserMediaRequest):
1782         * WebKitSupport/AboutData.cpp:
1783         (BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
1784         * WebKitSupport/FrameLayers.cpp:
1785         (BlackBerry::WebKit::FrameLayers::removeLayerByFrame):
1786         (BlackBerry::WebKit::FrameLayers::commitOnWebKitThread):
1787         (BlackBerry::WebKit::FrameLayers::calculateRootLayer):
1788
1789 2012-10-05  Rob Buis  <rbuis@rim.com>
1790
1791         [BlackBerry] Implement TestRunner.setMockDeviceOrientation
1792         https://bugs.webkit.org/show_bug.cgi?id=98542
1793
1794         Reviewed by Antonio Gomes.
1795
1796         PR 120681
1797
1798         Provide framework for mock device motion.
1799
1800         * Api/WebPage.cpp:
1801         (BlackBerry::WebKit::WebPagePrivate::init):
1802         * WebKitSupport/DumpRenderTreeSupport.cpp:
1803         (toDeviceOrientationClientMock):
1804         (DumpRenderTreeSupport::setMockDeviceOrientation):
1805         * WebKitSupport/DumpRenderTreeSupport.h:
1806         (DumpRenderTreeSupport):
1807
1808 2012-10-05  Konrad Piascik  <kpiascik@rim.com>
1809
1810         [BlackBerry] Remove unnecessary html file.
1811         https://bugs.webkit.org/show_bug.cgi?id=98531
1812
1813         Reviewed by Yong Li.
1814
1815         We now just use Source/WebCore/inspector/front-end/inspector.html
1816         instead.
1817
1818         * WebCoreSupport/inspectorBB.html: Removed.
1819
1820 2012-10-05  Antonio Gomes  <agomes@rim.com>
1821
1822         [BlackBerry] Find a proper fix for the WebPagePrivate::enqueueRenderingOfClippedContentOfScrollableNodeAfterInRegionScrolling hack
1823         https://bugs.webkit.org/show_bug.cgi?id=98517
1824         PR #137382
1825
1826         Reviewed by Yong Li.
1827
1828         We've generalized composited in-region scrolling, originally only applicable
1829         to block elements, to inner frames (see PR #197093). Past that, we no longer
1830         need to force repaints of offscreen areas when we finish scrolling, since translating
1831         the Layer takes care of properly invalidating it. Thus, remove this method.
1832
1833         * Api/WebPage.cpp:
1834         (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
1835         * Api/WebPage_p.h:
1836         (WebPagePrivate):
1837
1838 2012-10-05  Mike Fenton  <mifenton@rim.com>
1839
1840         [BlackBerry] Update default input support style for single line inputs.
1841         https://bugs.webkit.org/show_bug.cgi?id=98510
1842
1843         Reviewed by Antonio Gomes.
1844
1845         PR 219588.
1846
1847         Update style calculations to eliminate automatic changes
1848         by default on single line input fields.
1849
1850         Reviewed Internally by Gen Mak.
1851
1852         * WebKitSupport/InputHandler.cpp:
1853         (BlackBerry::WebKit::inputStyle):
1854
1855 2012-10-04  Simon Fraser  <simon.fraser@apple.com>
1856
1857         Final part of "sync" to "flush" renaming
1858         https://bugs.webkit.org/show_bug.cgi?id=98430
1859
1860         Reviewed by Tim Horton.
1861
1862         Change method names on GraphicsLayer and GraphicsLayerClient that
1863         refer to "sync" to use the term "flush" instead, to be consistent
1864         with the rest of the code.
1865
1866         * Api/WebOverlay.cpp:
1867         (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyFlushRequired):
1868         * Api/WebOverlay_p.h:
1869         (WebOverlayPrivateWebKitThread):
1870         * Api/WebPage.cpp:
1871         (BlackBerry::WebKit::WebPagePrivate::notifyFlushRequired):
1872         * Api/WebPage_p.h:
1873         (WebPagePrivate):
1874         * WebKitSupport/DefaultTapHighlight.cpp:
1875         (BlackBerry::WebKit::DefaultTapHighlight::notifyFlushRequired):
1876         * WebKitSupport/DefaultTapHighlight.h:
1877         (DefaultTapHighlight):
1878         * WebKitSupport/InspectorOverlayBlackBerry.cpp:
1879         (BlackBerry::WebKit::InspectorOverlay::notifyFlushRequired):
1880         * WebKitSupport/InspectorOverlayBlackBerry.h:
1881         (InspectorOverlay):
1882         * WebKitSupport/SelectionOverlay.cpp:
1883         (BlackBerry::WebKit::SelectionOverlay::notifyFlushRequired):
1884         * WebKitSupport/SelectionOverlay.h:
1885         (SelectionOverlay):
1886
1887 2012-10-04  Simon Fraser  <simon.fraser@apple.com>
1888
1889         Standardize on "flush" terminology for compositing layer flushing/syncing
1890         https://bugs.webkit.org/show_bug.cgi?id=98321
1891
1892         Reviewed by Simon Fraser.
1893
1894         Rename compositing-related methods that refer to "syncing" to instead
1895         refer to "flushing".
1896
1897         * WebCoreSupport/ChromeClientBlackBerry.cpp:
1898         (WebCore::ChromeClientBlackBerry::scheduleCompositingLayerFlush):
1899         * WebCoreSupport/ChromeClientBlackBerry.h:
1900         (ChromeClientBlackBerry):
1901
1902 2012-10-03  Antonio Gomes  <agomes@rim.com>
1903
1904         [BlackBerry] Exiting fullscreen does not set the correct scroll position (Part II)
1905         https://bugs.webkit.org/show_bug.cgi?id=97917
1906         PR #212920
1907
1908         Reviewed by Yong Li.
1909         Internally reviewed by Jacky Jiang.
1910
1911         Inform the client of transform change so that we avoid
1912         getting stuck on overscroll.
1913
1914         * Api/WebPage.cpp:
1915         (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
1916
1917 2012-10-03  Otto Derek Cheung  <otcheung@rim.com>
1918
1919         [BlackBerry] Implementing the NetworkInfo API for BB port
1920         https://bugs.webkit.org/show_bug.cgi?id=98273
1921
1922         Reviewed by Rob Buis.
1923
1924         Adding new class NetworkInfoClientBlackBerry to implement
1925         NetworkInfoClient for the BlackBerry port.
1926
1927         * Api/WebPage.cpp:
1928         (BlackBerry::WebKit::WebPagePrivate::init):
1929         * WebCoreSupport/NetworkInfoClientBlackBerry.cpp: Added.
1930         (WebCore):
1931         (WebCore::NetworkInfoClientBlackBerry::NetworkInfoClientBlackBerry):
1932         (WebCore::NetworkInfoClientBlackBerry::startUpdating):
1933         (WebCore::NetworkInfoClientBlackBerry::stopUpdating):
1934         (WebCore::NetworkInfoClientBlackBerry::bandwidth):
1935         (WebCore::NetworkInfoClientBlackBerry::metered):
1936         (WebCore::NetworkInfoClientBlackBerry::onCurrentNetworkChange):
1937         (WebCore::NetworkInfoClientBlackBerry::onCurrentCellularTypeChange):
1938         * WebCoreSupport/NetworkInfoClientBlackBerry.h: Added.
1939         (WebKit):
1940         (WebCore):
1941         (NetworkInfoClientBlackBerry):
1942         (WebCore::NetworkInfoClientBlackBerry::~NetworkInfoClientBlackBerry):
1943
1944 2012-10-02  Anders Carlsson  <andersca@apple.com>
1945
1946         Change most GraphicsLayer::create calls to use the version that takes a GraphicsLayerFactory
1947         https://bugs.webkit.org/show_bug.cgi?id=98217
1948
1949         Reviewed by Andreas Kling.
1950
1951         * Api/WebPage.cpp:
1952         (BlackBerry::WebKit::WebPagePrivate::overlayLayer):
1953
1954 2012-10-02  Yong Li  <yoli@rim.com>
1955
1956         [BlackBerry] Prevent window.close() from closing pages that are not opened by JS
1957         https://bugs.webkit.org/show_bug.cgi?id=98190
1958
1959         Reviewed by Antonio Gomes.
1960
1961         RIM PR# 217812.
1962         Only pages opened by JS can be closed by JS.
1963
1964         * WebCoreSupport/ChromeClientBlackBerry.cpp:
1965         (WebCore::ChromeClientBlackBerry::closeWindowSoon):
1966
1967 2012-10-01  Brady Eidson  <beidson@apple.com>
1968
1969         Remove the Safari 2 -> Safari 3 icon database import code.
1970         https://bugs.webkit.org/show_bug.cgi?id=98113
1971
1972         Reviewed by Maciej Stachowiak.
1973
1974         Nuke the performImport() IconDatabaseClient method.
1975
1976         * WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
1977         * WebCoreSupport/IconDatabaseClientBlackBerry.h:
1978         (IconDatabaseClientBlackBerry):
1979
1980 2012-10-01  Jakob Petsovits  <jpetsovits@rim.com>
1981
1982         [BlackBerry] Remove unused hasPendingScrollOrZoomEvent() interface.
1983         https://bugs.webkit.org/show_bug.cgi?id=98107
1984         RIM PR 173292
1985
1986         Reviewed by George Staikos.
1987
1988         This method is not referenced anywhere anymore,
1989         so we should stop requiring it from WebPageClient
1990         implementations.
1991
1992         * Api/WebPageClient.h:
1993
1994 2012-10-01  Mike Fenton  <mifenton@rim.com>
1995
1996         [BlackBerry] Remove suppressing of VKB hiding when processing changes.
1997         https://bugs.webkit.org/show_bug.cgi?id=98023
1998
1999         Reviewed by Rob Buis.
2000
2001         PR 215881.
2002
2003         Allow JS to blur the input field while processing key handling.
2004
2005         Reviewed Internally by Chris Hutten-Czapski
2006
2007         * WebKitSupport/InputHandler.cpp:
2008         (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
2009
2010 2012-09-28  Konrad Piascik  <kpiascik@rim.com>
2011
2012         [BlackBerry] Update the value of window.devicePixelRation when it is set programmatically
2013         https://bugs.webkit.org/show_bug.cgi?id=97512
2014
2015         Reviewed by Rob Buis.
2016
2017         RIM PR 213984
2018         Set the deviceScaleFactor of the page explicity when the
2019         devicePixelRatio is changed.
2020
2021         * Api/WebPage.cpp:
2022         (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
2023         (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
2024
2025 2012-09-28  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2026
2027         Code inside FrameLoaderClient::canShowMIMEType() implementations can be shared among different WK ports
2028         https://bugs.webkit.org/show_bug.cgi?id=97547
2029
2030         Reviewed by Adam Barth.
2031
2032         Newly added WebCore::MIMETypeRegistry::canShowMIMEType() function is used
2033         inside WebCore::FrameLoaderClientBlackBerry::canShowMIMEType().
2034
2035         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
2036         (WebCore::FrameLoaderClientBlackBerry::canShowMIMEType):
2037
2038 2012-09-28  Rob Buis  <rbuis@rim.com>
2039
2040         [BlackBerry] Hard to tap on x to clear a text field
2041         https://bugs.webkit.org/show_bug.cgi?id=97923
2042
2043         Reviewed by Antonio Gomes.
2044
2045         Allow the shadow element for 'X' to be clickable and do not prefer
2046         shadow content-editable div's over the 'X'.
2047
2048         * WebKitSupport/FatFingers.cpp:
2049         (BlackBerry::WebKit::FatFingers::isElementClickable):
2050
2051 2012-09-28  Antonio Gomes  <agomes@rim.com>
2052
2053         [BlackBerry] Extend composited  in-region scrolling to iframes/frames
2054         https://bugs.webkit.org/show_bug.cgi?id=97922
2055         PR #197093
2056
2057         Reviewed by Yong Li.
2058         Internaly reviewed by Arvid Nilsson.
2059
2060         Add support for composited scrolling in a inner frame level:
2061
2062         1) When creating an InRegionScrollableArea, for a inner scrollable frame,
2063         cache and camouflag the appropriated scroll layer (i.e. RenderLayerCompositor::scrollLayer);
2064
2065         2) Differentiate what type of scroll target we are at: BlockElement or
2066         InnerFrame;
2067
2068         3) Change the signature of the public methods to support and newly passed
2069         in ScrollTarget parameter;
2070         As a side note, this parameter is needed in order to know what class to static_cast
2071         the GraphicsLayer::client to: in the case of a composited scrollable inner frame, the client
2072         is a RenderLayerCompositor; in case of a composited scrollable block element, the client
2073         is a RenderLayerBacking.
2074
2075         * Api/InRegionScroller.cpp:
2076         (BlackBerry::WebKit::InRegionScroller::setScrollPositionWebKitThread):
2077         (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread):
2078         * Api/InRegionScroller.h:
2079         * Api/InRegionScroller_p.h:
2080         (InRegionScrollerPrivate):
2081         * WebCoreSupport/ChromeClientBlackBerry.h:
2082         (WebCore::ChromeClientBlackBerry::allowedCompositingTriggers):
2083         * WebKitSupport/InRegionScrollableArea.cpp:
2084         (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
2085
2086 2012-09-28  Antonio Gomes  <agomes@rim.com>
2087
2088         [BlackBerry] Exiting fullscreen does not set the correct scroll position
2089         https://bugs.webkit.org/show_bug.cgi?id=97917
2090         PR #212920
2091
2092         Reviewed by Yong Li.
2093         Internally reviewed by Jacky Jiang.
2094
2095         Restore the zoom level and scroll position at the time when know
2096         the fullscreen exit routine has ended (i.e. in ::setViewportSize
2097         instead of ::exitFullScreenForElement).
2098
2099         Also patch caches now the scroll position instead of only the
2100         "x scroll position.
2101
2102         * Api/WebPage.cpp:
2103         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
2104         (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
2105         (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
2106         (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
2107         * Api/WebPage_p.h:
2108         (WebPagePrivate):
2109
2110 2012-09-28  Kent Tamura  <tkent@chromium.org>
2111
2112         Clean up Localizer-related functions
2113         https://bugs.webkit.org/show_bug.cgi?id=97899
2114
2115         Reviewed by Kentaro Hara.
2116
2117         * WebCoreSupport/ColorPickerClient.cpp:
2118         (WebCore::ColorPickerClient::localizer): Follow Document::getLocalizer renaming.
2119         * WebCoreSupport/DatePickerClient.cpp:
2120         (WebCore::SelectPopupClient::localizer): ditto.
2121         * WebCoreSupport/SelectPopupClient.cpp:
2122         (WebCore::SelectPopupClient::localizer): ditto.
2123
2124 2012-09-28  Genevieve Mak  <gmak@rim.com>
2125
2126         [BLACKBERRY] Add isVisible method to WebTapHighlight
2127         https://bugs.webkit.org/show_bug.cgi?id=97915
2128
2129         Reviewed by Rob Buis.
2130
2131         Reviewed Internally By Andrew Lo
2132         The isVisible() method lets us avoid dispatching to the webkit thread
2133         if the tap highlight isn't visible.
2134         Always clear tap highlight on Touch up when converting Touch Events
2135         to Mouse Events.
2136
2137         * Api/WebTapHighlight.h:
2138         * WebKitSupport/DefaultTapHighlight.h:
2139         (BlackBerry::WebKit::DefaultTapHighlight::isVisible):
2140         * WebKitSupport/TouchEventHandler.cpp:
2141         (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
2142
2143 2012-09-28  Andrew Lo  <anlo@rim.com>
2144
2145         [BlackBerry] Should suspend page's scripted animations when WebPage is invisible
2146         https://bugs.webkit.org/show_bug.cgi?id=97856
2147
2148         Reviewed by Antonio Gomes.
2149
2150         Suspend page animations when setting WebPage invisible, resume when visible.
2151         Internal PR212788.
2152
2153         * Api/WebPage.cpp:
2154         (BlackBerry::WebKit::WebPagePrivate::setVisible):
2155
2156 2012-09-28  Arvid Nilsson  <anilsson@rim.com>
2157
2158         [BlackBerry] Destroy thread-specific data for Platform::Graphics::Buffer on the right thread
2159         https://bugs.webkit.org/show_bug.cgi?id=97674
2160
2161         Reviewed by Rob Buis.
2162
2163         A new API was added to BlackBerry::Platform::Graphics for destroying
2164         thread-specific data generated on the compositing thread when we blit
2165         buffers. The buffers are otherwise created and destroyed on the WebKit
2166         thread, which doesn't give platform any opportunity to destroy the
2167         thread-specific data.
2168
2169         This patch adds calls to the new API to avoid leaking resources.
2170
2171         Reviewed internally by Jakob Petsovits and Filip Spacek.
2172
2173         PR 214644
2174
2175         * WebKitSupport/SurfacePool.cpp:
2176         (BlackBerry::WebKit::SurfacePool::initialize):
2177         (BlackBerry::WebKit::SurfacePool::createPlatformGraphicsContext):
2178         (BlackBerry::WebKit::SurfacePool::lockTileRenderingSurface):
2179         (BlackBerry::WebKit::SurfacePool::releaseTileRenderingSurface):
2180         (BlackBerry::WebKit::SurfacePool::initializeVisibleTileBuffer):
2181         (BlackBerry::WebKit::SurfacePool::createBuffers):
2182         (BlackBerry::WebKit::SurfacePool::releaseBuffers):
2183
2184 2012-09-27  Kent Tamura  <tkent@chromium.org>
2185
2186         Use Localizer in PagePopupController
2187         https://bugs.webkit.org/show_bug.cgi?id=97862
2188
2189         Reviewed by Hajime Morita.
2190
2191         We need to implement PagePopupClient::localizer. These clients know the
2192         host elements. Localizer implementations get Localizer objects from the
2193         owner documents of the elements for the browser locale.
2194
2195         * WebCoreSupport/ColorPickerClient.cpp:
2196         (WebCore::ColorPickerClient::localizer): Added.
2197         * WebCoreSupport/ColorPickerClient.h:
2198         (ColorPickerClient): Declare "localizer."
2199         * WebCoreSupport/DatePickerClient.cpp:
2200         (WebCore::SelectPopupClient::localizer): Added.
2201         * WebCoreSupport/DatePickerClient.h:
2202         (DatePickerClient): Declare "localizer."
2203         * WebCoreSupport/SelectPopupClient.cpp:
2204         (WebCore::SelectPopupClient::localizer): Added.
2205         * WebCoreSupport/SelectPopupClient.h:
2206         (SelectPopupClient): Declare "localizer."
2207
2208 2012-09-27  Charles Wei  <charles.wei@torchmobile.com.cn>
2209
2210         Empty URL gets through to acceptNavigationRequest()
2211         https://bugs.webkit.org/show_bug.cgi?id=97076
2212
2213         Reviewed by George Staikos.
2214
2215         Invalid URLs in iframe src results in an empty URL in platform request, we should reject
2216         such URL as early as we identify it.
2217
2218         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
2219         (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
2220
2221 2012-09-26  Jakob Petsovits  <jpetsovits@rim.com>
2222
2223         [BlackBerry] Remove blitContents() in favor of blitVisibleContents().
2224         https://bugs.webkit.org/show_bug.cgi?id=97718
2225
2226         Reviewed by Antonio Gomes.
2227
2228         After the last calling sites of blitContents() have
2229         been removed or reworked, the actual method itself
2230         can now retire. All blits now go through
2231         blitVisibleContents(). The knowledge that we always
2232         blit the full visible surface can facilitate further
2233         optimizations; we will get to that in time.
2234
2235         * Api/BackingStore.cpp:
2236         (BlackBerry::WebKit::BackingStorePrivate::suspendScreenAndBackingStoreUpdates):
2237         (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
2238         (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
2239         * Api/BackingStore.h:
2240         * Api/BackingStore_p.h:
2241         (BackingStorePrivate):
2242         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
2243         (WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):
2244
2245 2012-09-26  Mike Fenton  <mifenton@rim.com>
2246
2247         [BlackBerry] Update padding in ensureFocusTextElementVisible to be DPI independent.
2248         https://bugs.webkit.org/show_bug.cgi?id=97684
2249
2250         Reviewed by Rob Buis.
2251
2252         Update padding in ensureFocusTextElementVisible to be DPI
2253         independent and relative to the current zoom level.
2254
2255         Reviewed Internally by Gen Mak.
2256
2257         * WebKitSupport/InputHandler.cpp:
2258         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
2259
2260 2012-09-25  Genevieve Mak  <gmak@rim.com>
2261
2262         Fat Fingers doesn't work on non-scrollable pages.
2263         PR #209609
2264         https://bugs.webkit.org/show_bug.cgi?id=97607
2265
2266         Reviewed by Antonio Gomes.
2267
2268         Only bypass Fat Fingers and use the actual touch point if its specifically
2269         requested and the page has a mouse move listener or if using the Touch Event
2270         Mode meta-tag.
2271
2272         * WebKitSupport/TouchEventHandler.cpp:
2273         (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
2274
2275 2012-09-25  Rob Buis  <rbuis@rim.com>
2276
2277         [BlackBerry] Make COMPUTED_GOTO part of the HAVE section
2278         https://bugs.webkit.org/show_bug.cgi?id=97600
2279
2280         Reviewed by Yong Li.
2281
2282         Also get rid of COMPUTED_GOTO_INTERPRETER and add COMPUTED_GOTO_OPCODES.
2283
2284         * WebCoreSupport/AboutDataEnableFeatures.in:
2285         * WebCoreSupport/AboutDataHaveFeatures.in:
2286
2287 2012-09-25  Mike Fenton  <mifenton@rim.com>
2288
2289         [BlackBerry] Suspend the backingstore while adjusting the view on input field focus.
2290         https://bugs.webkit.org/show_bug.cgi?id=97595
2291
2292         Reviewed by Antonio Gomes.
2293
2294         PR 188751.
2295
2296         Avoid jumpiness when both a scroll and zoom are required to
2297         move an input field into focus by suspending the backingstore.
2298
2299         * WebKitSupport/InputHandler.cpp:
2300         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
2301
2302 2012-09-25  Pratik Solanki  <psolanki@apple.com>
2303
2304         Remove HAVE_SBRK since we never set use_sbrk to true
2305         https://bugs.webkit.org/show_bug.cgi?id=97525
2306         <rdar://problem/12363601>
2307
2308         Reviewed by Geoffrey Garen.
2309
2310         * WebCoreSupport/AboutDataHaveFeatures.in: Remove SBRK from list.
2311
2312 2012-09-25  Beth Dakin  <bdakin@apple.com>
2313
2314         https://bugs.webkit.org/show_bug.cgi?id=95397
2315         Need to merge didFirstVisuallyNonEmptyLayout and 
2316         didNewFirstVisuallyNonEmptyLayout
2317         -and corresponding-
2318         <rdar://problem/10791680>
2319
2320         Reviewed by Sam Weinig.
2321
2322         Remove dispatchDidFirstLayout, 
2323         dispatchDidFirstVisuallyNonEmptyLayout, and 
2324         dispatchDidNewFirstVisuallyNonEmptyLayout. Their functionality 
2325         is now replaced by dispatchDidLayout(LayoutMilestoneOptions)
2326         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
2327         (WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):
2328         * WebCoreSupport/FrameLoaderClientBlackBerry.h:
2329         (FrameLoaderClientBlackBerry):
2330
2331         It is now necessary to opt into getting any of the 
2332         "layout milestone" notifications.
2333         * Api/WebPage.cpp:
2334         (BlackBerry::WebKit::WebPagePrivate::init):
2335
2336 2012-09-25  Mike Fenton  <mifenton@rim.com>
2337
2338         [BlackBerry] When zooming into an input field take the current zoom level into account.
2339         https://bugs.webkit.org/show_bug.cgi?id=97594
2340
2341         Reviewed by Antonio Gomes.
2342
2343         PR 188751.
2344
2345         Perform the zoom action prior to scroll to avoid breaking scrolling
2346         rules.  Take the current scale into account when calculating the
2347         zoom factor.
2348
2349         * WebKitSupport/InputHandler.cpp:
2350         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
2351
2352 2012-09-25  Nima Ghanavatian  <nghanavatian@rim.com>
2353
2354         [BlackBerry] Handling required for multiple consecutive whitespace
2355         https://bugs.webkit.org/show_bug.cgi?id=97575
2356
2357         Reviewed by Rob Buis.
2358
2359         PR211670
2360         Need specific handling in the case where we have multiple
2361         consecutive whitespaces which exceeds our character limit. This
2362         breaks some of the functionality employed with the visible_units
2363         methods used here to tranverse the text.
2364
2365         Internally reviewed by Mike Fenton.
2366
2367         * WebKitSupport/DOMSupport.cpp:
2368         (BlackBerry::WebKit::DOMSupport::trimWhitespaceFromRange):
2369         (DOMSupport):
2370         (BlackBerry::WebKit::DOMSupport::isEmptyRangeOrAllSpaces):
2371         * WebKitSupport/DOMSupport.h:
2372         (WebCore):
2373         * WebKitSupport/InputHandler.cpp:
2374         (BlackBerry::WebKit::InputHandler::spellCheckBlock):
2375         (BlackBerry::WebKit::InputHandler::getRangeForSpellCheckWithFineGranularity):
2376
2377 2012-09-24  Mark Lam  <mark.lam@apple.com>
2378
2379         Deleting the classic interpreter and cleaning up some build options.
2380         https://bugs.webkit.org/show_bug.cgi?id=96969.
2381
2382         Reviewed by Geoffrey Garen.
2383
2384         * WebCoreSupport/AboutDataEnableFeatures.in:
2385
2386 2012-09-24  Benjamin Poulain  <bpoulain@apple.com>
2387
2388         Fix Geolocation error reporting in the test support
2389         https://bugs.webkit.org/show_bug.cgi?id=97386
2390
2391         Reviewed by Sam Weinig.
2392
2393         * WebKitSupport/DumpRenderTreeSupport.cpp:
2394         (DumpRenderTreeSupport::setMockGeolocationPositionUnavailableError):
2395         * WebKitSupport/DumpRenderTreeSupport.h:
2396         (DumpRenderTreeSupport):
2397
2398 2012-09-24  Otto Derek Cheung  <otcheung@rim.com>
2399
2400         [BlackBerry] Reverting implementation for 407 error pages
2401         https://bugs.webkit.org/show_bug.cgi?id=97455
2402
2403         Reviewed by Rob Buis.
2404
2405         Revert "[BlackBerry] Really fix bug 95488 that user can get the 
2406         authentication challenge dialog while the other tab has focus."
2407         https://bugs.webkit.org/show_bug.cgi?id=97348
2408
2409         This reverts commit 0cffe01961fb80204138505bcec29a83818efb73.
2410
2411         * Api/BlackBerryGlobal.cpp:
2412         (BlackBerry::WebKit::globalInitialize):
2413         * Api/WebPage.cpp:
2414         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
2415         (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
2416         (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
2417         (BlackBerry::WebKit::WebPage::setVisible):
2418         * Api/WebPage_p.h:
2419         (WebPagePrivate):
2420
2421 2012-09-24  Arvid Nilsson  <anilsson@rim.com>
2422
2423         [BlackBerry] Add cookie database API
2424         https://bugs.webkit.org/show_bug.cgi?id=97102
2425
2426         Reviewed by Antonio Gomes.
2427
2428         The cookie database is exposed through WebCookieJar, which has only two
2429         methods: cookies() and setCookies().
2430
2431         Also add a new WebString::fromUTF8 overload that takes a const char*
2432         and a length, in order to avoid a strlen call when converting from
2433         other string classes to WebString. This is useful for callers of the
2434         new cookie API when converting cookies to WebString.
2435
2436         Reviewed internally by Otto D. Cheung.
2437
2438         PR 209282
2439
2440         * Api/WebCookieJar.cpp: Added.
2441         (WebKit):
2442         (BlackBerry::WebKit::WebCookieJar::WebCookieJar):
2443         (BlackBerry::WebKit::WebCookieJar::cookies):
2444         (BlackBerry::WebKit::WebCookieJar::setCookies):
2445         * Api/WebCookieJar.h: Added.
2446         (WebKit):
2447         * Api/WebPage.cpp:
2448         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
2449         (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
2450         (BlackBerry::WebKit::WebPage::cookieJar):
2451         (WebKit):
2452         * Api/WebPage.h:
2453         (WebKit):
2454         * Api/WebPage_p.h:
2455         (WebKit):
2456         (WebPagePrivate):
2457         * Api/WebString.cpp:
2458         (BlackBerry::WebKit::WebString::fromUtf8):
2459         (WebKit):
2460         * Api/WebString.h:
2461
2462 2012-09-21  Lianghui Chen  <liachen@rim.com>
2463
2464         [BlackBerry] Really fix bug 95488 that user can get the authentication challenge dialog while the other tab has focus.
2465         https://bugs.webkit.org/show_bug.cgi?id=97348
2466         Internal PR: 186597.
2467
2468         Internally reviewed by Yong Li, Joe Mason.
2469         Reviewed by Yong Li.
2470
2471         Update WebPage to use new AuthenticationChallengeManager.
2472         Register page creation/deletion and visibility change to the new
2473             AuthenticationChallengeManager.
2474         Initialize AuthenticationChallengeManager in GlobalInitialize() function.
2475
2476         * Api/BlackBerryGlobal.cpp:
2477         (BlackBerry::WebKit::globalInitialize):
2478         * Api/WebPage.cpp:
2479         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
2480         (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
2481         (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
2482         (BlackBerry::WebKit::WebPage::setVisible):
2483         * Api/WebPage_p.h:
2484         (WebPagePrivate):
2485
2486 2012-09-21  Charles Wei  <charles.wei@torchmobile.com.cn>
2487
2488         Wrong seperator for viewport meta in Popup scripts
2489         https://bugs.webkit.org/show_bug.cgi?id=97313
2490
2491         Reviewed by Yong Li.
2492
2493         The valid seperator for viewport meta is ',' instead of ';'.
2494
2495         * WebCoreSupport/PagePopupBlackBerry.cpp:
2496         (WebCore::PagePopupBlackBerry::generateHTML):
2497
2498 2012-09-21  Arvid Nilsson  <anilsson@rim.com>
2499
2500         [BlackBerry] Remove obsolete compositing surface code
2501         https://bugs.webkit.org/show_bug.cgi?id=97314
2502
2503         Reviewed by Antonio Gomes.
2504
2505         The removed code allowed rendering of sublayers to a separate offscreen
2506         surface.
2507
2508         Now that we composite root layer and all sublayers to the window
2509         surface, this code is not needed anymore. In addition, we save some
2510         memory by not allocating the unused offscreen surface.
2511
2512         PR 208038.
2513
2514         * Api/BackingStore.cpp:
2515         (BlackBerry::WebKit::BackingStorePrivate::suspendScreenAndBackingStoreUpdates):
2516         (BlackBerry::WebKit::BackingStorePrivate::blitContents):
2517         (BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
2518         * Api/BackingStore_p.h:
2519         (BackingStorePrivate):
2520         * Api/WebPage.cpp:
2521         (BlackBerry::WebKit::WebPagePrivate::setLoadState):
2522         (BlackBerry::WebKit::WebPagePrivate::suspendBackingStore):
2523         (BlackBerry::WebKit::WebPagePrivate::resizeSurfaceIfNeeded):
2524         (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
2525         (BlackBerry::WebKit::WebPagePrivate::setRootLayerCompositingThread):
2526         * Api/WebPage_p.h:
2527         (WebPagePrivate):
2528         * WebKitSupport/BackingStoreCompositingSurface.cpp: Removed.
2529         * WebKitSupport/BackingStoreCompositingSurface.h: Removed.
2530         * WebKitSupport/GLES2Context.cpp:
2531         (BlackBerry::WebKit::GLES2Context::buffer):
2532         (BlackBerry::WebKit::GLES2Context::surfaceSize):
2533         (BlackBerry::WebKit::GLES2Context::swapBuffers):
2534         * WebKitSupport/GLES2Context.h:
2535         (GLES2Context):
2536         * WebKitSupport/SurfacePool.cpp:
2537         (WebKit):
2538         (BlackBerry::WebKit::SurfacePool::SurfacePool):
2539         (BlackBerry::WebKit::SurfacePool::initialize):
2540         * WebKitSupport/SurfacePool.h:
2541         (SurfacePool):
2542
2543 2012-09-20  Peter Wang  <peter.wang@torchmobile.com.cn>
2544
2545         [BlackBerry] To support "Frames View" of "TimeLine" panel  in Inspector
2546         https://bugs.webkit.org/show_bug.cgi?id=96077
2547
2548         Reviewed by Pavel Feldman.
2549
2550         A minor modification to make the inspecting results more accurate.
2551         Internally reviewd by Arvid, Robin.C, and Konrad.
2552
2553         * Api/BackingStore.cpp:
2554         (BlackBerry::WebKit::BackingStorePrivate::renderJob):
2555         * Api/WebPage.cpp:
2556         (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
2557         * WebKitSupport/RenderQueue.cpp:
2558         (BlackBerry::WebKit::RenderQueue::render):
2559
2560 2012-09-19  Sean Wang  <Xuewen.Wang@torchmobile.com.cn>
2561
2562         [BlackBerry] Basic authentication challenge credentials for stored credentials again after restarting browser
2563         https://bugs.webkit.org/show_bug.cgi?id=96362
2564
2565         Reviewed by Rob Buis.
2566
2567         Make the FrameLoaderClient use credential storage according to the macro
2568         BLACKBERRY_CREDENTIAL_PERSIST
2569
2570         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
2571         (WebCore::FrameLoaderClientBlackBerry::shouldUseCredentialStorage):
2572         (WebCore):
2573         * WebCoreSupport/FrameLoaderClientBlackBerry.h:
2574         (FrameLoaderClientBlackBerry):
2575
2576 2012-09-19  Mike Fenton  <mifenton@rim.com>
2577
2578         [BlackBerry] After zooming into an input field, zoom out when focus is lost.
2579         https://bugs.webkit.org/show_bug.cgi?id=97128
2580
2581         Reviewed by Rob Buis.
2582
2583         When the page has automatically zoomed in for input
2584         focus, unzoom it when input focus is lost or keyboard hidden.
2585
2586         Reviewed Internally by Gen Mak.
2587
2588         * WebKitSupport/InputHandler.cpp:
2589         (BlackBerry::WebKit::InputHandler::InputHandler):
2590         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
2591         * WebKitSupport/InputHandler.h:
2592         (InputHandler):
2593
2594 2012-09-19  Nima Ghanavatian  <nghanavatian@rim.com>
2595
2596         [BlackBerry] Clean up the SpellingLog output
2597         https://bugs.webkit.org/show_bug.cgi?id=97129
2598
2599         Reviewed by Rob Buis.
2600
2601         Internally reviewed by Mike Fenton.
2602
2603         * WebKitSupport/InputHandler.cpp:
2604         (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
2605         (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
2606
2607 2012-09-19  Mike Fenton  <mifenton@rim.com>
2608
2609         [BlackBerry] Add SpellingLog for spell checking options request.
2610         https://bugs.webkit.org/show_bug.cgi?id=97125
2611
2612         Reviewed by Rob Buis.
2613
2614         Add spell checking log to indicate the calculated
2615         text position for spell checking option requests.
2616
2617         Reviewed Internally by Nima Ghanavatian.
2618
2619         * WebKitSupport/InputHandler.cpp:
2620         (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
2621
2622 2012-09-19  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
2623
2624         [BlackBerry] Add function playerId() in class PageClientBlackBerry
2625         https://bugs.webkit.org/show_bug.cgi?id=97099
2626
2627         Reviewed by Yong Li.
2628
2629         Implemented PageClientBlackBerry::playerID() in class WebPagePrivate,
2630         and replaced the implementation of FrameLoaderClientBlackBerry::playerId().
2631
2632         Internally reviewed by Charles Wei.
2633
2634         * Api/WebPage.cpp:
2635         (BlackBerry::WebKit::WebPagePrivate::playerID):
2636         (WebKit):
2637         * Api/WebPage_p.h:
2638         (WebPagePrivate):
2639         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
2640         (WebCore::FrameLoaderClientBlackBerry::playerId):
2641
2642 2012-09-19  Abbas Sherawala  <asherawala@rim.com>
2643
2644         [BlackBerry] BackingStorePrivate::resumeScreenAndBackingStoreUpdates more atomic
2645         Added a missing 'if' statement.
2646         https://bugs.webkit.org/show_bug.cgi?id=96925
2647
2648         PR #180866
2649
2650         Internally Reviewed by Antonio Gomes.
2651
2652         Adding an 'if' statement which should have been in PR # 180866 (SHA:b9c06af395c22e)
2653
2654         Reviewed by Antonio Gomes.
2655
2656         * Api/BackingStore.cpp:
2657         (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
2658
2659 2012-09-18  Nima Ghanavatian  <nghanavatian@rim.com>
2660
2661         [BlackBerry] Use didCancel and didSucceed instead of didCheckCancel and didCheckSucceed
2662         https://bugs.webkit.org/show_bug.cgi?id=97033
2663
2664         Reviewed by Rob Buis.
2665
2666         Using these preferred public methods (the latter has a note to be made private) ensures that
2667         the right SpellChecker object is being called during the callback in spellCheckingRequestProcessed
2668         and spellCheckingRequestCancelled.
2669
2670         Internally reviewed by Mike Fenton.
2671
2672         By referencing the TextCheckingRequest object's methods, we don't need to keep track of the associated
2673         SpellChecker for each request. Removing much of the code that was put in place incorrectly to achieve this.
2674
2675         * WebKitSupport/InputHandler.cpp:
2676         (BlackBerry::WebKit::InputHandler::InputHandler):
2677         (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
2678         (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
2679         (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
2680         (BlackBerry::WebKit::InputHandler::getSpellChecker):
2681         * WebKitSupport/InputHandler.h:
2682         (InputHandler):
2683
2684 2012-09-18  Jessica Cao  <jecao@rim.com>
2685
2686         [BlackBerry] Date picker isn't inputting after 'OK'
2687         https://bugs.webkit.org/show_bug.cgi?id=97031
2688
2689         PR208052
2690
2691         Reviewed by Rob Buis
2692
2693         Checking for !values.contains("-1") will match valid strings like "2012-09-18". Use value != "-1" instead.
2694
2695         * WebCoreSupport/DatePickerClient.cpp:
2696         (WebCore::DatePickerClient::setValueAndClosePopup):
2697
2698 2012-09-18  Yong Li  <yoli@rim.com>
2699
2700         [BlackBerry] Popup page should reference the client with a weak pointer
2701         https://bugs.webkit.org/show_bug.cgi?id=97028
2702
2703         Reviewed by Rob Buis.
2704
2705         RIM PR# 209847.
2706         Internally reviewed by Mike Fenton.
2707
2708         Store the pointer in a ref-coutned shared object, and clear the pointer 
2709         when the client is going to be destroyed, so it won't be accessed by
2710         the JS function afterwards.
2711
2712         * WebCoreSupport/PagePopupBlackBerry.cpp:
2713         (WebCore::PagePopupBlackBerry::PagePopupBlackBerry):
2714         (WebCore::PagePopupBlackBerry::~PagePopupBlackBerry):
2715         (WebCore::PagePopupBlackBerry::init):
2716         (WebCore::setValueAndClosePopupCallback):
2717         (WebCore::popUpExtensionFinalize):
2718         (WebCore::PagePopupBlackBerry::installDOMFunction):
2719         (WebCore::PagePopupBlackBerry::closePopup):
2720         * WebCoreSupport/PagePopupBlackBerry.h:
2721         (PagePopupBlackBerry):
2722         (SharedClientPointer):
2723         (WebCore::PagePopupBlackBerry::SharedClientPointer::SharedClientPointer):
2724         (WebCore::PagePopupBlackBerry::SharedClientPointer::clear):
2725         (WebCore::PagePopupBlackBerry::SharedClientPointer::get):
2726
2727 2012-09-18  Arvid Nilsson  <anilsson@rim.com>
2728
2729         [BlackBerry] Prevent scroll adjustment of input fields when region of interest mechanism active
2730         https://bugs.webkit.org/show_bug.cgi?id=96750
2731
2732         Reviewed by Antonio Gomes.
2733
2734         The region of interest mechanism replaces the scrolling/zooming
2735         functionality in InputHandler::ensureFocusTextElementVisible().
2736
2737         We introduce a new fine-grained setting for the various adjustment
2738         modes. The WebKit embedder can disable all scroll types in favor of the
2739         region of interest mechanism by using the new setting.
2740
2741         PR #208387
2742
2743         Reviewed internally by Mike Fenton.
2744
2745         * WebKitSupport/AboutData.cpp:
2746         (BlackBerry::WebKit::configPage):
2747         * WebKitSupport/InputHandler.cpp:
2748         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
2749         * WebKitSupport/InputHandler.h:
2750
2751 2012-09-17  Jakob Petsovits  <jpetsovits@rim.com>
2752
2753         [BlackBerry] Remove dysfunctional zoom blit in setViewportSize().
2754         https://bugs.webkit.org/show_bug.cgi?id=96954
2755         PR 178411
2756
2757         Reviewed by Antonio Gomes.
2758
2759         The blitContents() call removed by this patch used to
2760         be part of scheduleZoomAboutPoint(). Its goal was to
2761         display a preview of the zoomed contents, primarily
2762         when auto-zoomed after rotation. Nested inside a pair
2763         of screen suspend/resume calls, it has been a pointless
2764         no-op for a while.
2765
2766         Antonio's recent change to remove scheduleZoomAboutPoint()
2767         and call zoomAboutPoint() from setViewportSize() directly
2768         (the only call site) obsoletes the call completely.
2769         The zoomAboutPoint() call itself will cause a re-render
2770         and blit right away, so we don't care about any preview.
2771         zoomAboutPoint() will also take care of the necessary
2772         screen/backingstore suspension.
2773
2774         The result is a vastly simplified block of code.
2775
2776         * Api/WebPage.cpp:
2777         (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
2778
2779 2012-09-17  Antonio Gomes  <agomes@rim.com>
2780
2781         [BlackBerry] [FullScreen] entering/leaving fullscreen results in temporary glitches on the screen
2782         https://bugs.webkit.org/show_bug.cgi?id=96927
2783         PR #180866
2784
2785         Reviewed by Yong Li.
2786
2787         Suspend backing store and screen updates while entering fullscreen,
2788         and only resume at the end, when viewport is resized.
2789
2790         * Api/WebPage.cpp:
2791         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
2792         (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
2793         * Api/WebPage_p.h:
2794         (WebPagePrivate):
2795         * WebCoreSupport/ChromeClientBlackBerry.cpp:
2796         (WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
2797         (WebCore::ChromeClientBlackBerry::exitFullScreenForElement):
2798
2799 2012-09-17  Rob Buis  <rbuis@rim.com>
2800
2801         [BlackBerry] Fix compile problems in WebKit/blackberry
2802         https://bugs.webkit.org/show_bug.cgi?id=96926
2803
2804         Reviewed by Antonio Gomes.
2805
2806         This code is slightly out of date and so will not compile, fix it.
2807
2808         * WebCoreSupport/BatteryClientBlackBerry.cpp:
2809         (WebCore::BatteryClientBlackBerry::BatteryClientBlackBerry):
2810         * WebCoreSupport/BatteryClientBlackBerry.h:
2811         (WebKit):
2812         * WebCoreSupport/CredentialTransformData.h:
2813         * WebCoreSupport/DeviceOrientationClientBlackBerry.cpp:
2814         (DeviceOrientationClientBlackBerry::onOrientation):
2815         * WebCoreSupport/InspectorClientBlackBerry.h:
2816         * WebCoreSupport/PagePopupBlackBerry.cpp:
2817         * WebKitSupport/DOMSupport.cpp:
2818         (BlackBerry::WebKit::DOMSupport::isDateTimeInputField):
2819         (BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
2820         * WebKitSupport/DumpRenderTreeSupport.cpp:
2821         (DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
2822         * WebKitSupport/InPageSearchManager.cpp:
2823         (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
2824
2825 2012-09-17  Antonio Gomes  <agomes@rim.com>
2826
2827         [BlackBerry] BackingStorePrivate::resumeScreenAndBackingStoreUpdates more atomic
2828         https://bugs.webkit.org/show_bug.cgi?id=96925
2829
2830         [FullScreen] entering/leaving fullscreen results in temporary glitches on the screen (part 2/3)
2831         PR #180866
2832
2833         Reviewed by Rob Buis.
2834         Internally reviewed by Arvid Nilsson.
2835
2836         Paraphrasing Arvid "resumeBackingStore will be a truly atomic operation.
2837         Well more atomic than it was before, with regards to a mix of accelerated and
2838         non-accelerated compositing content".
2839
2840         I.e. by committing the root layer (if needed) when resuming the Backing
2841         Store, we call blitVisibleContents right way, so we are actually shortcutting when
2842         AC content will get on screen.
2843
2844         * Api/BackingStore.cpp:
2845         (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
2846
2847 2012-09-17  Peter Wang  <peter.wang@torchmobile.com.cn>
2848
2849         [BlackBerry] To support "Frames View" of "TimeLine" panel in Inspector
2850         https://bugs.webkit.org/show_bug.cgi?id=96077
2851
2852         Reviewed by Rob Buis.
2853
2854         Invoke the "instrumentBeginFrame" and "instrumentCancelFrame" at the start and end of processing
2855         render message to record one time of page's update.
2856
2857         * Api/BackingStore.cpp:
2858         (BlackBerry::WebKit::BackingStorePrivate::instrumentBeginFrame):
2859         (WebKit):
2860         (BlackBerry::WebKit::BackingStorePrivate::instrumentCancelFrame):
2861         * Api/BackingStore_p.h:
2862         * WebKitSupport/RenderQueue.cpp:
2863         (BlackBerry::WebKit::RenderQueue::render):
2864
2865 2012-09-17  Jakob Petsovits  <jpetsovits@rim.com>
2866
2867         [BlackBerry] Support copying image data in WebOverlay.
2868         https://bugs.webkit.org/show_bug.cgi?id=96684
2869         RIM PR 195444
2870
2871         Reviewed by Rob Buis.
2872         Internally reviewed by Arvid Nilsson.
2873
2874         The publicly exposed WebOverlay class provides a method
2875         setContentsToImage() to assign a pointer to pixel data,
2876         which is later used to provide texture data for the
2877         underlying compositing layer. This works well for static
2878         images that stay in memory and never change, but not
2879         so well for images with changing contents or where the
2880         image data is being reassigned from different image
2881         sources that are not constantly kept around in memory.
2882
2883         Due to the delayed upload and delayed fetching of
2884         EGLImage data by the GPU, we shouldn't assume the caller
2885         to know how long the image should be retained. Instead,
2886         we should offer another method of setting image data
2887         that takes ownership of the pixel data.
2888
2889         This patch adds an option to setContentsToImage() that
2890         copies the passed pixel data and doesn't destroy it
2891         until both the texture is destroyed and the image
2892         contents are changed. Using this method, the caller can
2893         withdraw the passed pixel array right after the
2894         setContentsToImage() call without consequences.
2895
2896         * Api/WebOverlay.cpp:
2897         (BlackBerry::WebKit::WebOverlay::setContentsToImage):
2898         (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setContentsToImage):
2899         (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
2900         (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::invalidate):
2901         (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContents):
2902         (WebKit):
2903         (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::clearUploadedContents):
2904         (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToColor):
2905         (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
2906         (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::deleteTextures):
2907         (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
2908         * Api/WebOverlay.h:
2909         * Api/WebOverlay_p.h:
2910         (WebOverlayPrivate):
2911         (WebOverlayPrivateWebKitThread):
2912         (WebOverlayLayerCompositingThreadClient):
2913         (WebOverlayPrivateCompositingThread):
2914
2915 2012-09-14  Dana Jansens  <danakj@chromium.org>
2916
2917         Minimize collisions when hashing pairs
2918         https://bugs.webkit.org/show_bug.cgi?id=96022
2919
2920         Reviewed by Adrienne Walker.
2921
2922         Use WTF::pairIntHash() to hash a pair of integers.
2923
2924         * WebKitSupport/TileIndexHash.h:
2925
2926 2012-09-14  Genevieve Mak  <gmak@rim.com>
2927
2928         Always send mouse events on pages that don't scroll even if there
2929         is no mouse move listener attatched.
2930         PR #208228
2931         https://bugs.webkit.org/show_bug.cgi?id=96800
2932
2933         Reviewed by Antonio Gomes.
2934
2935         Reviewed Internally By Antonio Gomes.
2936
2937         * WebKitSupport/TouchEventHandler.cpp:
2938         (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
2939
2940 2012-09-14  Mike Fenton  <mifenton@rim.com>
2941
2942         [BlackBerry] Update the minimum zoom scale when focusing an input field.
2943         https://bugs.webkit.org/show_bug.cgi?id=96789
2944
2945         Reviewed by Antonio Gomes.
2946
2947         PR 188751.
2948
2949         Increase the minimum font fix and base it on mm instead of pixels.
2950
2951         Reviewed Internally by Gen Mak.
2952
2953         * WebKitSupport/InputHandler.cpp:
2954         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
2955
2956 2012-09-13  Antonio Gomes  <agomes@rim.com>
2957
2958         [BlackBerry]  Remove the ability to schedule a zoom about point call.
2959         https://bugs.webkit.org/show_bug.cgi?id=96696
2960
2961         [FullScreen] entering/leaving fullscreen results in temporary glitches on the screen (Part I)
2962         PR #180866
2963
2964         Reviewed by Rob Buis.
2965
2966         Internally reviewed by Jacky Jiang and Arvid Nilsson.
2967
2968         Patch replaces the async call to zoomAboutPoint (via scheduling it with a one-shot-0-timer).
2969         Instead, at its single call site, we inline most of the previous scheduleZoomAboutPoint code,
2970         and in the end call zoomAboutPoint directly.
2971
2972         Change was estimulated by Arvid's comment on PRzilla: "There is no longer any reason to have
2973         zoom about point be async.. That was a hack I did for BB6, back when we were doing everything on the WK
2974         thread and needed manual time slicing betwren rendering and user interaction."
2975
2976         The bigger goal though is to be able to remove screen glitches while entering/leaving
2977         fullscreen mode: since we could accurately use the count-based suspend/resume backing
2978         store mechanism to prevent it.
2979
2980         * Api/WebPage.cpp:
2981         (WebKit):
2982         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
2983         (BlackBerry::WebKit::WebPagePrivate::setLoadState):
2984         (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
2985         * Api/WebPage_p.h:
2986         (WebPagePrivate):
2987
2988 2012-09-14  Arvid Nilsson  <anilsson@rim.com>
2989
2990         [BlackBerry] Add renderTreeAsText API to WebPage
2991         https://bugs.webkit.org/show_bug.cgi?id=96629
2992
2993         Reviewed by Antonio Gomes.
2994
2995         This will be used for automated testing.
2996
2997         PR #198595
2998
2999         * Api/WebPage.cpp:
3000         (BlackBerry::WebKit::WebPage::renderTreeAsText):
3001         (WebKit):
3002         * Api/WebPage.h:
3003
3004 2012-09-13  Rob Buis  <rbuis@rim.com>
3005
3006         [BlackBerry] Cleanup AboutDataEnableFeatures.in
3007         https://bugs.webkit.org/show_bug.cgi?id=96695
3008
3009         Reviewed by Antonio Gomes.
3010
3011         Remove unused features.
3012
3013         * WebCoreSupport/AboutDataEnableFeatures.in:
3014
3015 2012-09-13  Rob Buis  <rbuis@rim.com>
3016
3017         [BlackBerry] Rename InspectorOverlay in blackberry/WebKitSupport
3018         https://bugs.webkit.org/show_bug.cgi?id=96689
3019
3020         Reviewed by Antonio Gomes.
3021
3022         Rename to InspectorClientBlackBerry to avoid include problems.
3023
3024         * WebCoreSupport/InspectorClientBlackBerry.h:
3025         * WebKitSupport/InspectorOverlayBlackBerry.cpp: Renamed from Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.cpp.
3026         (WebKit):
3027         (BlackBerry::WebKit::InspectorOverlay::create):
3028         (BlackBerry::WebKit::InspectorOverlay::InspectorOverlay):
3029         (BlackBerry::WebKit::InspectorOverlay::notifySyncRequired):
3030         (BlackBerry::WebKit::InspectorOverlay::paintContents):
3031         (BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
3032         (BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
3033         (BlackBerry::WebKit::InspectorOverlay::~InspectorOverlay):
3034         (BlackBerry::WebKit::InspectorOverlay::clear):
3035         (BlackBerry::WebKit::InspectorOverlay::update):
3036         * WebKitSupport/InspectorOverlayBlackBerry.h: Renamed from Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.h.
3037         (WebCore):
3038         (WebKit):
3039         (InspectorOverlay):
3040         (InspectorOverlayClient):
3041         (BlackBerry::WebKit::InspectorOverlay::setClient):
3042         (BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
3043
3044 2012-09-13  Antonio Gomes  <agomes@rim.com>
3045
3046         Unreviewed, warning fix left over from r128456 (bug 96645)
3047
3048         * Api/InRegionScroller.cpp:
3049         (WebKit):
3050
3051 2012-09-13  Genevieve Mak  <gmak@rim.com>
3052
3053         Continue to send mouse move events to a non-scrollable page
3054         even if they are not consumed.
3055         PR #207024
3056         https://bugs.webkit.org/show_bug.cgi?id=96655
3057
3058         Reviewed by Antonio Gomes.
3059
3060         * WebKitSupport/TouchEventHandler.cpp:
3061         (BlackBerry::WebKit::isMainFrameScrollable):
3062         (WebKit):
3063         (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
3064
3065 2012-09-13  Jacky Jiang  <zhajiang@rim.com>
3066
3067         [BlackBerry] Missing conditions in InRegionScrollerPrivate::canScrollRenderBox
3068         https://bugs.webkit.org/show_bug.cgi?id=96660
3069
3070         Reviewed by Antonio Gomes.
3071
3072         PR: 207884
3073         According to RenderBox::canBeScrolledAndHasScrollableArea(), we should
3074         bail out early in InRegionScrollerPrivate::canScrollRenderBox() if the
3075         RenderBox's scroll height equals the client height and the scroll width
3076         equals the client width. Otherwise, we will miss the conditions.
3077
3078         * Api/InRegionScroller.cpp:
3079         (BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
3080
3081 2012-09-13  Jessica Cao  <jecao@rim.com>
3082
3083         [BlackBerry] Page Popup for Month is non-functional.
3084         https://bugs.webkit.org/show_bug.cgi?id=96651
3085
3086         Reviewed by Rob Buis.
3087
3088         Hook up support for Month popup.
3089
3090         * WebCoreSupport/DatePickerClient.cpp:
3091         (WebCore::DatePickerClient::generateHTML):
3092         * WebKitSupport/InputHandler.cpp:
3093         (BlackBerry::WebKit::InputHandler::openDatePopup):
3094
3095 2012-09-13  Antonio Gomes  <agomes@rim.com>
3096
3097         [BlackBerry] ASSERT failure in InRegionScrollableArea::InRegionScrollableArea
3098         https://bugs.webkit.org/show_bug.cgi?id=96645
3099         PR #207307
3100
3101         Reviewed by George Staikos.
3102
3103         We use canScrollRenderBox to promote the layer as scrollable instead
3104         of RenderBox::canScrollAndHasScrollableArea (see comment above the former).
3105         We should assert against the former as well.
3106
3107         * Api/InRegionScroller.cpp:
3108         (BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
3109         * Api/InRegionScroller_p.h:
3110         (WebCore):
3111         (InRegionScrollerPrivate):
3112         * WebKitSupport/InRegionScrollableArea.cpp:
3113         (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
3114
3115 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
3116
3117         Unreviewed, rolling out r127876.
3118         http://trac.webkit.org/changeset/127876
3119         https://bugs.webkit.org/show_bug.cgi?id=96600
3120
3121         mouse click doesn't work for spin button if spin button in
3122         iframe (Requested by yosin on #webkit).
3123
3124         * Api/WebPage.cpp:
3125         (BlackBerry::WebKit::WebPagePrivate::contextNode):
3126         (BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
3127         (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
3128         (BlackBerry::WebKit::WebPage::nodeAtPoint):
3129         * WebKitSupport/FatFingers.cpp:
3130         (BlackBerry::WebKit::FatFingers::getNodesFromRect):
3131         (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
3132         * WebKitSupport/SelectionHandler.cpp:
3133         (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
3134
3135 2012-09-12  Sami Kyostila  <skyostil@google.com>
3136
3137         Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING
3138         https://bugs.webkit.org/show_bug.cgi?id=96251
3139
3140         Reviewed by Simon Fraser.
3141
3142         Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING to better describe
3143         the feature it controls.
3144
3145         * WebCoreSupport/AboutDataEnableFeatures.in:
3146
3147 2012-09-11  Antonio Gomes  <agomes@rim.com>
3148
3149         [BlackBerry] add a way to overscroll non-overflown content
3150         https://bugs.webkit.org/show_bug.cgi?id=96331
3151         PR #195305
3152
3153         Reviewed by Yong Li.
3154
3155         Check -webkit-overflow-scrolling value for '-blackberry-touch' instead
3156         of checking a custom HTML5 attribute.
3157
3158         No behavioural change. Mostly a rework of r128142.
3159
3160         * Api/InRegionScroller.cpp:
3161         (BlackBerry::WebKit::canScrollRenderBox):
3162
3163 2012-09-11  Rob Buis  <rbuis@rim.com>
3164
3165         [BlackBerry] make pickers/dialogs use appendLiteral
3166         https://bugs.webkit.org/show_bug.cgi?id=96424
3167
3168         Reviewed by Antonio Gomes.
3169
3170         PR 204032
3171
3172         Other pickers were updated in r128204.
3173
3174         * WebCoreSupport/ColorPickerClient.cpp:
3175         (WebCore::ColorPickerClient::generateHTML):
3176         * WebCoreSupport/PagePopupBlackBerry.cpp:
3177         (WebCore::PagePopupBlackBerry::generateHTML):
3178
3179 2012-09-11  Konrad Piascik  <kpiascik@rim.com>
3180
3181         [BlackBerry] Fix history navigation for error pages.
3182         https://bugs.webkit.org/show_bug.cgi?id=96410
3183
3184         Reviewed by Rob Buis.
3185
3186         Fix how history navigation handles restoring view state when navigating between error pages.
3187
3188         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
3189         (WebCore::FrameLoaderClientBlackBerry::FrameLoaderClientBlackBerry):
3190         (WebCore::FrameLoaderClientBlackBerry::saveViewStateToItem):
3191         (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
3192         * WebCoreSupport/FrameLoaderClientBlackBerry.h:
3193         (FrameLoaderClientBlackBerry):
3194
3195 2012-09-11  Jinwoo Song  <jinwoo7.song@samsung.com>
3196
3197         Deploy StringBuilder::appendNumber() and StringBuilder::appendLiteral() in more places
3198         https://bugs.webkit.org/show_bug.cgi?id=96344
3199
3200         Reviewed by Benjamin Poulain.
3201
3202         Use StringBuilder::appendNumber() instead of String::number(). Also deploy 
3203         StringBuilder::appendLiteral() instead of String::append() in the surrounding code.
3204
3205         * WebCoreSupport/DatePickerClient.cpp:
3206         (WebCore::DatePickerClient::generateHTML):
3207         * WebCoreSupport/SelectPopupClient.cpp:
3208         (WebCore::SelectPopupClient::generateHTML):
3209
3210 2012-09-11  Jacky Jiang  <zhajiang@rim.com>
3211
3212         [BlackBerry] InRegion scrollable area dangling pointers were accessed in UI thread
3213         https://bugs.webkit.org/show_bug.cgi?id=96318
3214
3215         Reviewed by Antonio Gomes.
3216
3217         PR: 204066
3218         Dangling pointers were accessed in UI thread, as the actual InRegion
3219         scrollable areas of WebKit side had been destroyed before that in
3220         WebKit thread after UI thread set scrolling to false.
3221         Notify the client side to clear InRegion scrollable areas before we
3222         destroy them in WebKit side.
3223
3224         Internally reviewed by Gen Mak and George Staikos.
3225
3226         * Api/WebPage.cpp:
3227         (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
3228         (BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):
3229         * Api/WebPageClient.h:
3230
3231 2012-09-11  Mike Fenton  <mifenton@rim.com>
3232
3233         [BlackBerry] Suppress keyboard requests while processing spell checking suggestions.
3234         https://bugs.webkit.org/show_bug.cgi?id=96394
3235
3236         Reviewed by Rob Buis.
3237
3238         Suppress the VKB notification when the touch event
3239         is a spell checking request.
3240
3241         PR 192925.
3242
3243         Reviewed Internally by Gen Mak.
3244
3245         * WebKitSupport/TouchEventHandler.cpp:
3246         (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
3247
3248 2012-09-11  Mike Fenton  <mifenton@rim.com>
3249
3250         [BlackBerry] Colour Dialog popup request should return proper state.
3251         https://bugs.webkit.org/show_bug.cgi?id=96392
3252
3253         Reviewed by Rob Buis.
3254
3255         Return proper state from openColorPopup dependent on
3256         whether the popup actually opened.
3257
3258         Reviewed Internally by Chris Hutten-Czapski
3259
3260         * WebKitSupport/InputHandler.cpp:
3261         (BlackBerry::WebKit::InputHandler::openColorPopup):
3262
3263 2012-09-11  Nima Ghanavatian  <nghanavatian@rim.com>
3264
3265         [BlackBerry] Take account for single words that exceed our client character limit
3266         https://bugs.webkit.org/show_bug.cgi?id=96389
3267
3268         Fix to the processing of long single-line text using getRangeForSpellCheckWithFineGranularity.
3269         This was failing if a single word was longer than our maximum allowed limit.
3270
3271         Internally reviewed by Mike Fenton.
3272
3273         Reviewed by Rob Buis.
3274
3275         * WebKitSupport/InputHandler.cpp:
3276         (WebKit):
3277         (BlackBerry::WebKit::InputHandler::getRangeForSpellCheckWithFineGranularity):
3278
3279 2012-09-11  Arvid Nilsson  <anilsson@rim.com>
3280
3281         [BlackBerry] SelectionHandler drops caret change notifications
3282         https://bugs.webkit.org/show_bug.cgi?id=96378
3283
3284         Reviewed by Antonio Gomes.
3285
3286         The selection handler deliberately drops caret change notifications
3287         while the input handler is processing changes, to avoid displaying
3288         intermediate state during a complex change.
3289
3290         However, this meant that the client was never informed of the final
3291         caret position.
3292
3293         Fixed by notifying client about caret change after processing ends, if
3294         one or more caret change notifications were dropped during processing.
3295
3296         PR #205073
3297
3298         Reviewed internally by Mike Fenton.
3299
3300         * WebKitSupport/InputHandler.cpp:
3301         (BlackBerry::WebKit::InputHandler::setProcessingChange):
3302         (WebKit):
3303         * WebKitSupport/InputHandler.h:
3304         (InputHandler):
3305         * WebKitSupport/SelectionHandler.cpp:
3306         (BlackBerry::WebKit::SelectionHandler::SelectionHandler):
3307         (BlackBerry::WebKit::SelectionHandler::inputHandlerDidFinishProcessingChange):
3308         (WebKit):
3309         (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
3310         (BlackBerry::WebKit::SelectionHandler::notifyCaretPositionChangedIfNeeded):
3311         * WebKitSupport/SelectionHandler.h:
3312         (SelectionHandler):
3313
3314 2012-09-10  Antonio Gomes  <agomes@rim.com>
3315
3316         [BlackBerry] add a way to overscroll non-overflown content
3317         https://bugs.webkit.org/show_bug.cgi?id=96331
3318         [UxD] Vertical lists should always be scrollable
3319         PR #195305
3320
3321         Reviewed by Yong Li.
3322         Internally reviewed by Gen Mak.
3323
3324         Check if the RenderLayer is composited / hardware acceleratable prior to
3325         check if its contents overflows. If that is the case, check if
3326         our custom data-blackberry-force-overscroll is present.
3327
3328         That makes it possible for us to align to UX requirements: settings
3329         and CCM panels should be always scrollable.
3330
3331         * Api/InRegionScroller.cpp:
3332         (BlackBerry::WebKit::canScrollRenderBox):
3333         * WebKitSupport/InRegionScrollableArea.cpp:
3334         (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
3335
3336 2012-09-10  Genevieve Mak  <gmak@rim.com>
3337
3338         Change -data-blackberry-webworks-context to -data-webworks-context
3339         because not all webworks apps are blackberry apps.
3340         https://bugs.webkit.org/show_bug.cgi?id=96297
3341
3342         Reviewed by Antonio Gomes.
3343
3344         PR #193726
3345         Rubber Stamped interally by Mike Fenton.
3346
3347         * WebKitSupport/DOMSupport.cpp:
3348         (BlackBerry::WebKit::DOMSupport::webWorksContext):
3349
3350 2012-09-09  Arvid Nilsson  <anilsson@rim.com>
3351
3352         [BlackBerry] Fix flicker due to introduction of the fence extension.
3353         https://bugs.webkit.org/show_bug.cgi?id=96207
3354
3355         Reviewed by George Staikos.
3356
3357         Don't immediately add fence to garbage list, so it is destroyed
3358         after only one swap, for a set of tiles just because one tile in
3359         the set gets a new fence, the old fence may still not be signalled
3360         and before rendering the other tiles in the set we have to wait for it.
3361
3362         * WebKitSupport/BackingStoreTile.cpp:
3363         (BlackBerry::WebKit::Fence::~Fence):
3364         (WebKit):
3365         * WebKitSupport/BackingStoreTile.h:
3366         (WebKit):
3367         (Fence):
3368         * WebKitSupport/SurfacePool.cpp:
3369         (BlackBerry::WebKit::SurfacePool::initialize):
3370         (BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
3371         (WebKit):
3372         (BlackBerry::WebKit::SurfacePool::destroyPlatformSync):
3373         * WebKitSupport/SurfacePool.h:
3374         (SurfacePool):
3375
3376 2012-09-08  Max Feil  <mfeil@rim.com>
3377
3378         [BlackBerry] Exiting fullscreen mode can leave user stuck without Browser menus
3379         https://bugs.webkit.org/show_bug.cgi?id=96027
3380
3381         Reviewed by Antonio Gomes.
3382
3383         The changes for bug 87337 (landed as trunk svn revision 119119)
3384         introduced a bug. The same conditions are not checked on enter
3385         fullscreen vs. exit. Web sites such as http://videojs.com
3386         and youtube's mobile HTML5 player make the div container
3387         of the video element go fullscreen. This is allowed in
3388         WebPagePrivate::enterFullScreenForElement() but disallowed in
3389         WebPagePrivate::exitFullScreenForElement(). I am fixing this by
3390         allowing containers of video elements to exit fullscreen.
3391
3392         * Api/WebPage.cpp:
3393         (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
3394
3395 2012-09-07  Ming Xie  <mxie@rim.com>
3396
3397
3398         [BlackBerry] Remove browser from the build info page
3399         https://bugs.webkit.org/show_bug.cgi?id=96162
3400
3401         Reviewed by George Staikos.
3402         Internal reviewed by Jeff Rogers.
3403
3404         WebKit build should not have the build info for browser which is
3405         built on top of webkit.
3406
3407         * WebKitSupport/AboutData.cpp:
3408         (BlackBerry::WebKit::buildPage):
3409
3410 2012-09-07  Yongxin Dai  <yodai@rim.com>
3411
3412         [BlackBerry] Initialize caret rectangle with invalid location
3413         https://bugs.webkit.org/show_bug.cgi?id=96011
3414
3415         Reviewed by Rob Buis.
3416
3417         In SelectionHandler::selectionPositionChanged() method, startCaret and
3418         endCaret are used to notify clients about new caret positions. This patch
3419         initializes startCaret and endCaret with location(-1. -1), and keeps them
3420         empty before they are assigned to valid values. This would help for other
3421         classes to check validity of the caret correctly.
3422
3423         Internal reviewed by Mike Fenton.
3424
3425         * WebKitSupport/SelectionHandler.cpp:
3426         (BlackBerry::WebKit::adjustCaretRects):
3427         (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
3428
3429 2012-09-07  Lianghui Chen  <liachen@rim.com>
3430
3431         [BlackBerry] when one of multiple tabs uses authentication, user can get the auth dialog while the other tab has focus.
3432         https://bugs.webkit.org/show_bug.cgi?id=95488
3433         PR: 186597.
3434
3435         Internally reviewed by Joe Mason.
3436         Reviewed by Yong Li.
3437
3438         Use new AuthenticationChallengeClient interface to make authentication
3439         challenge asynchronous to NetworkJob, MediaPlayerPrivateBlackBerry, and
3440         other module that will use HTTP authentication. WebPage itself still use
3441         synchronous authentication though. Switching to asynchronous authentication
3442         in WebPage will require bigger platform layer change and not very necessary
3443         at the moment for this bug.
3444
3445         * Api/WebPage.cpp:
3446         (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
3447         * Api/WebPage_p.h:
3448         (WebCore):
3449         (WebPagePrivate):
3450
3451 2012-09-07  Rob Buis  <rbuis@rim.com>
3452
3453         [BlackBerry] Remove feature about:cache/disable and about:cache/enable
3454         https://bugs.webkit.org/show_bug.cgi?id=95820
3455
3456         Reviewed by Yong Li.
3457
3458         Fix warning that was caused by r127680.
3459
3460         * WebKitSupport/AboutData.cpp:
3461         (BlackBerry::WebKit::cachePage):
3462
3463 2012-09-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3464
3465         Simplify hitTestResultAtPoint and nodesFromRect APIs
3466         https://bugs.webkit.org/show_bug.cgi?id=95720
3467
3468         Reviewed by Antonio Gomes.
3469
3470         Update calls to new API.
3471
3472         * Api/WebPage.cpp:
3473         (BlackBerry::WebKit::WebPagePrivate::contextNode):
3474         (BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
3475         (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
3476         (BlackBerry::WebKit::WebPage::nodeAtPoint):
3477         * WebKitSupport/FatFingers.cpp:
3478         (BlackBerry::WebKit::FatFingers::getNodesFromRect):
3479         (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
3480         * WebKitSupport/SelectionHandler.cpp:
3481         (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
3482
3483 2012-09-07  Robin Cao  <robin.cao@torchmobile.com.cn>
3484
3485         [BlackBerry] Rendering issue after rotation
3486         https://bugs.webkit.org/show_bug.cgi?id=96094
3487         PR #201930
3488
3489         Reviewed by George Staikos.
3490
3491         The cause of the rendering issue is that the BackingStore tiles
3492         are not reset after layout. This is a regression of r125680, which
3493         overwrites a local variable that are used later in the function.
3494
3495         * Api/WebPage.cpp:
3496         (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
3497
3498 2012-09-06  Crystal Zhang  <haizhang@rim.com>
3499
3500         [BlackBerry]  Implement a color picker
3501         https://bugs.webkit.org/show_bug.cgi?id=96001
3502
3503         Reviewed by Rob Buis.
3504
3505         Add files for color picker, replace old hook to AIR color picker.
3506
3507         * WebCoreSupport/ColorPickerClient.cpp: Added.
3508         (WebCore):
3509         (WebCore::ColorPickerClient::ColorPickerClient):
3510         (WebCore::ColorPickerClient::~ColorPickerClient):
3511         (WebCore::ColorPickerClient::generateHTML):
3512         (WebCore::ColorPickerClient::closePopup):
3513         (WebCore::ColorPickerClient::contentSize):
3514         (WebCore::ColorPickerClient::htmlSource):
3515         (WebCore::ColorPickerClient::setValueAndClosePopup):
3516         (WebCore::ColorPickerClient::didClosePopup):
3517         (WebCore::ColorPickerClient::writeDocument):
3518         * WebCoreSupport/ColorPickerClient.h: Added.
3519         (WebKit):
3520         (WebCore):
3521         (ColorPickerClient):
3522         * WebKitSupport/InputHandler.cpp:
3523         (BlackBerry::WebKit::InputHandler::openColorPopup):
3524
3525 2012-09-06  Genevieve Mak  <gmak@rim.com>
3526
3527         Add data-blackberry-webworks-context attribute and set the custom context when
3528         getting context.
3529         https://bugs.webkit.org/show_bug.cgi?id=95993
3530
3531         Reviewed by Antonio Gomes.
3532
3533         PR #193726
3534         Reviewed Internally by Mike Fenton.
3535
3536         * Api/WebPage.cpp:
3537         (BlackBerry::WebKit::WebPagePrivate::webContext):
3538             - Check for custom WebWorks context and add it if there.
3539         * WebKitSupport/DOMSupport.cpp:
3540         (BlackBerry::WebKit::DOMSupport::webWorksContext):
3541         (DOMSupport):
3542         * WebKitSupport/DOMSupport.h:
3543             - Add a method that checks a given element for the data-webworks-context
3544               attribute and returns its value if present.
3545
3546 2012-09-06  Antonio Gomes  <agomes@rim.com>
3547
3548         [BlackBerry] Allow overscroll to composited scroll layers
3549         https://bugs.webkit.org/show_bug.cgi?id=95998
3550         PR #195305
3551
3552         Reviewed by Rob Buis.
3553         Internally reviewed by Gen Mak.
3554
3555         No need to reset the overscroll limit factor at creation to 0.
3556         It is already 0 by default, and later on the client sets the
3557         appropriated value.
3558
3559         * WebKitSupport/InRegionScrollableArea.cpp:
3560         (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
3561
3562 2012-09-05  Sam Weinig  <sam@webkit.org>
3563
3564         Part 2 of removing PlatformString.h, remove PlatformString.h
3565         https://bugs.webkit.org/show_bug.cgi?id=95931
3566
3567         Reviewed by Adam Barth.
3568
3569         Remove PlatformString.h
3570
3571         * Api/DumpRenderTreeClient.h:
3572         * WebCoreSupport/ChromeClientBlackBerry.cpp:
3573         * WebCoreSupport/InspectorClientBlackBerry.h:
3574         * WebCoreSupport/JavaScriptDebuggerBlackBerry.cpp:
3575         * WebKitSupport/AboutData.h:
3576
3577 2012-09-05  Jason Liu  <jason.liu@torchmobile.com.cn>
3578
3579         [BlackBerry] Remove feature about:cache/disable and about:cache/enable
3580         https://bugs.webkit.org/show_bug.cgi?id=95820
3581
3582         Reviewed by Rob Buis.
3583
3584         Remove this feature since we need to add a button in settings.
3585
3586         * WebKitSupport/AboutData.cpp:
3587         (BlackBerry::WebKit::cachePage):
3588
3589 2012-09-05  Mike Fenton  <mifenton@rim.com>
3590
3591         [BlackBerry] Remove deprecated dialog connections.
3592         https://bugs.webkit.org/show_bug.cgi?id=95868
3593
3594         Reviewed by Rob Buis.
3595
3596         PR 187481.
3597         Remove deprecated logic for unsupported
3598         Dialog types.
3599
3600         * Api/WebPageClient.h:
3601         * WebKitSupport/InputHandler.cpp:
3602         (BlackBerry::WebKit::InputHandler::openDatePopup):
3603         (BlackBerry::WebKit::InputHandler::openColorPopup):
3604
3605 2012-09-05  George Staikos  <staikos@webkit.org>
3606
3607         [BlackBerry] Assignment operators missing self-check
3608         https://bugs.webkit.org/show_bug.cgi?id=95774
3609
3610         Reviewed by Rob Buis.
3611
3612         Add a test for self-assignment.
3613
3614         * Api/WebAnimation.cpp:
3615         (BlackBerry::WebKit::WebAnimation::operator=):
3616         * Api/WebString.cpp:
3617         (BlackBerry::WebKit::WebString::operator=):
3618
3619 2012-09-05  Leo Yang  <leoyang@rim.com>
3620
3621         [BlackBerry] Optimize BackingStorePrivate::isCurrentVisibleJob
3622         https://bugs.webkit.org/show_bug.cgi?id=95897
3623
3624         Reviewed by Antonio Gomes.
3625
3626         Bail out the loop early if one of the not-rendered rectangle is
3627         not current regular render job.
3628
3629         No behavior change, just code optimization.
3630
3631         * Api/BackingStore.cpp:
3632         (BlackBerry::WebKit::BackingStorePrivate::isCurrentVisibleJob):
3633
3634 2012-09-05  Benjamin C Meyer  <bmeyer@rim.com>
3635
3636         [BlackBerry] JavaScriptVariant can crash when operator= is called with itself
3637         https://bugs.webkit.org/show_bug.cgi?id=95859
3638
3639         Reviewed by George Staikos.
3640
3641         * Api/JavaScriptVariant.cpp:
3642         (BlackBerry::WebKit::JavaScriptVariant::operator=):
3643         When JavaScriptVariant contains a string and operator= is
3644         called with itself the memory will be free'd in 'this' and
3645         then a copy will be attempted from 'that' resulting in a crash.
3646
3647 2012-09-05  Leo Yang  <leoyang@rim.com>
3648
3649         [BlackBerry] Rotation and then reload causes less sized webpage (PR 190469)
3650         https://bugs.webkit.org/show_bug.cgi?id=95870
3651
3652         Reviewed by George Staikos.
3653         Reviewed internally by Jacky Jiang.
3654
3655         Use the new zoom to fit scale if the page was zoomed to fit initial scale
3656         When a page is reloaded the layout size may be changed. So the contents
3657         size on which the initial scale depends may be changed. Use the new initial
3658         scale in this case to make sure the page will be zoomed to correct scale.
3659
3660         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
3661         (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
3662
3663 2012-09-05  Robin Cao  <robin.cao@torchmobile.com.cn>
3664
3665         [BlackBerry] Do not release shared backingstore memory prematurely
3666         https://bugs.webkit.org/show_bug.cgi?id=95841
3667         PR #202517
3668
3669         Reviewed by George Staikos.
3670
3671         The BackingStore memory is shared by all web pages. We should check if
3672         the current backingStore is active before create/release this shared memory.
3673
3674         * Api/BackingStore.cpp:
3675         (BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
3676         (BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):
3677
3678 2012-09-05  Andy Chen  <andchen@rim.com>
3679
3680         [BlackBerry] Implement number of matches and current active match index for find-on-page
3681         https://bugs.webkit.org/show_bug.cgi?id=95801
3682
3683         Reviewed by Antonio Gomes.
3684
3685         - Calculate current match index for find-on-page
3686         - Notify client when number of matches and current match index update.
3687         PR 162090 162091.
3688         Internally reviewed by Mike Fenton and Joe Mason
3689
3690         * Api/WebPageClient.h:
3691         * WebKitSupport/InPageSearchManager.cpp:
3692         (BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::DeferredScopeStringMatches):
3693         (BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::doTimeout):
3694         (InPageSearchManager::DeferredScopeStringMatches):
3695         (BlackBerry::WebKit::InPageSearchManager::findNextString):
3696         (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
3697         (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
3698         (BlackBerry::WebKit::InPageSearchManager::scopeStringMatchesSoon):
3699         (BlackBerry::WebKit::InPageSearchManager::callScopeStringMatches):
3700         * WebKitSupport/InPageSearchManager.h:
3701         (InPageSearchManager):
3702
3703 2012-09-04  Rob Buis  <rbuis@rim.com>
3704
3705         [BlackBerry] FatFingers::cachingStrategy uses incorrect enum value
3706         https://bugs.webkit.org/show_bug.cgi?id=95783
3707
3708         Reviewed by Antonio Gomes.
3709
3710         Use the correct enum values.
3711
3712         * WebKitSupport/FatFingers.cpp:
3713         (BlackBerry::WebKit::FatFingers::cachingStrategy):
3714
3715 2012-09-04  Antonio Gomes  <agomes@rim.com>
3716
3717         [BlackBerry] Use child/ScrollableContent layer's position instead of parent/ScrollLayer's boundsOrigin
3718         https://bugs.webkit.org/show_bug.cgi?id=95778
3719         PR #202252
3720
3721         Reviewed by Rob Buis.
3722         Internally reviewed by Arvid Nilsson.
3723
3724         Upstream has switch away from using the parent scroll layer's bounds origin
3725         in order to translate contents of all its child layers. Instead now, it directly
3726         sets the scroll position of the child scrollable contents layer.
3727
3728         Source/WebKit/blackberry:
3729         * Api/InRegionScroller.cpp:
3730         (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
3731         * WebKitSupport/InRegionScrollableArea.cpp:
3732         (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
3733
3734         No new tests, since it is a catch-up with upstreaming code.
3735
3736 2012-09-04  George Staikos  <staikos@webkit.org>
3737
3738         [BlackBerry] Fix memory leak in InputHandler
3739         https://bugs.webkit.org/show_bug.cgi?id=95771
3740
3741         Reviewed by Rob Buis.
3742
3743         Simply delete the arrays at function exit.
3744
3745         * WebKitSupport/InputHandler.cpp:
3746         (BlackBerry::WebKit::InputHandler::openSelectPopup):
3747
3748 2012-09-04  George Staikos  <staikos@webkit.org>
3749
3750         [BlackBerry] pass isMainFrame() through to notifyDocumentOnLoad()
3751         https://bugs.webkit.org/show_bug.cgi?id=95766
3752
3753         Reviewed by Rob Buis.
3754
3755         Passing the frame status through will allow the client to make better
3756         decisions about how to act on the onload.
3757
3758         * Api/WebPageClient.h:
3759         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
3760         (WebCore::FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents):
3761
3762 2012-09-04  Rob Buis  <rbuis@rim.com>
3763
3764         [BlackBerry] Provide virtual dtor for DumpRenderTreeClient
3765         https://bugs.webkit.org/show_bug.cgi?id=95769
3766
3767         Reviewed by Yong Li.
3768
3769         Also remove WTF prefixes.
3770
3771         * Api/DumpRenderTreeClient.h:
3772
3773 2012-09-04  Mary Wu  <mary.wu@torchmobile.com.cn>
3774
3775         [BlackBerry] Add webplatform and browser to build info
3776         https://bugs.webkit.org/show_bug.cgi?id=95715
3777
3778         Reviewed by George Staikos.
3779
3780         PR# 202102
3781
3782         * WebKitSupport/AboutData.cpp:
3783         (BlackBerry::WebKit::buildPage):
3784
3785 2012-08-31  Jacky Jiang  <zhajiang@rim.com>
3786
3787         [BlackBerry] ASSERT failure in RenderBlock::checkPositionedObjectsNeedLayout
3788         https://bugs.webkit.org/show_bug.cgi?id=95611
3789
3790         Reviewed by Antonio Gomes.
3791
3792         PR:200127
3793         Remove r118405 now as we already have a new fix webkit/43f8394b for
3794         that issue and it is not reproducible anymore after the removal.
3795         In this way, we can get rid of this ASSERT failure as well.
3796         Thanks Antonio for the suggestion.
3797
3798         * Api/WebPage.cpp:
3799         (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
3800
3801 2012-08-31  Joshua Netterfield  <jnetterfield@rim.com>
3802
3803         [BlackBerry] Eliminate WebGL IT policy
3804         https://bugs.webkit.org/show_bug.cgi?id=95604
3805         Internal RIM PR #198764
3806
3807         Reviewed by Rob Buis.
3808
3809         This is no longer a requirement for the BlackBerry port.
3810
3811         * Api/WebPage.cpp:
3812         (BlackBerry::WebKit::WebPagePrivate::init):
3813         (BlackBerry::WebKit::WebPage::setWebGLEnabled):
3814         * WebKitSupport/AboutData.cpp:
3815         (BlackBerry::WebKit::configPage):
3816
3817 2012-08-30  Benjamin Poulain  <bpoulain@apple.com>
3818
3819         Replace JSC::UString by WTF::String
3820         https://bugs.webkit.org/show_bug.cgi?id=95271
3821
3822         Reviewed by Geoffrey Garen.
3823
3824         Replace UString by String.
3825
3826         * WebCoreSupport/ClientExtension.cpp:
3827         * WebCoreSupport/PagePopupBlackBerry.cpp:
3828         (WebCore::PagePopupBlackBerry::installDomFunction):
3829
3830 2012-08-30  Jacky Jiang  <zhajiang@rim.com>
3831
3832         [BlackBerry] ASSERT failure in JSC::MarkedAllocator::allocateSlowCase
3833         https://bugs.webkit.org/show_bug.cgi?id=95492
3834
3835         Reviewed by Yong Li.
3836
3837         PR: 200724
3838         Hold the JSLock for the current thread before we call toRef to avoid
3839         the ASSERT failure.
3840
3841         * Api/WebPage.cpp:
3842         (BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
3843
3844 2012-08-30  Antonio Gomes  <agomes@rim.com>
3845
3846         [BlackBerry] Remove unneeded force-immediate-repaint from InRegionScroller::setLayerScrollPosition
3847         https://bugs.webkit.org/show_bug.cgi?id=95476
3848         PR #200704
3849
3850         Reviewed by Yong Li.
3851
3852         This code is not needed at this point for neither the fast nor slow in-region
3853         scroll codepaths, and it is a huge performance beast as it forces all
3854         containers to get full-repainted per scroll call (in webkit thread).
3855
3856         Patch also take this opportunity to remove an early-return we
3857         have in the {i}frame slow scrolling code path so that we can
3858         adjust the selection handles in this case as well.
3859
3860         * Api/InRegionScroller.cpp:
3861         (BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
3862
3863 2012-08-30  Hanna Ma  <Hanma@rim.com>
3864
3865         [BlackBerry] node search does not work with elements on touch start listener
3866         https://bugs.webkit.org/show_bug.cgi?id=95252
3867
3868         Reviewed by Antonio Gomes.
3869
3870         Fix the node search function of web insepctor on elements with touch start listener.
3871         Add methods from webPage to check if the node search functionality is enabled before handling touch events.
3872         PR194107
3873
3874         * Api/WebPage.cpp:
3875         (BlackBerry::WebKit::WebPage::touchEvent):
3876
3877 2012-08-30  Arvid Nilsson  <anilsson@rim.com>
3878
3879         [BlackBerry] One shot drawing sync flag never cleared when there's no layers
3880         https://bugs.webkit.org/show_bug.cgi?id=95447
3881
3882         Reviewed by Antonio Gomes.
3883
3884         PR 199866
3885         When we remove the layers, WebKit could tell us we need a one shot
3886         drawing sync to repaint the BackingStore with the content that was
3887         previously drawn by layers. We also sometimes set the one shot drawing
3888         sync flag manually.
3889
3890         We would bail from commit if there were no layers and not actually
3891         perform the osds, so it left the osds flag set forever and the
3892         situation prevails, because nobody will ever clear the osds flag.
3893
3894         The BackingStore surrenders the responsibility of blitting to the AC
3895         commit mechanism when a one shot drawing sync is pending, because we
3896         want the operations render, commit and blit to happen in the correct
3897         order with no intermediate blits.
3898
3899         So, no commit means no blit, and the result of regular rendering did
3900         not show up on screen.
3901
3902         Fixed by not bailing from commit if there's no layers, instead clearing
3903         the "needs commit" and osds flags and performing a blit.
3904
3905         Reviewed internally by Andrew Lo.
3906
3907         * Api/WebPage.cpp:
3908         (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
3909
3910 2012-08-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3911
3912         Use ASCIILiteral for DEFINE_STATIC_LOCAL string
3913         https://bugs.webkit.org/show_bug.cgi?id=95420
3914
3915         Reviewed by Benjamin Poulain.
3916
3917         As recommended by http://trac.webkit.org/wiki/EfficientStrings,
3918         WebKit needs to use ASCIILiteral for the string of DEFINE_STATIC_LOCAL.
3919
3920         * Api/WebSettings.cpp:
3921         (WebKit):
3922
3923 2012-08-29  Nima Ghanavatian  <nghanavatian@rim.com>
3924
3925         [BlackBerry] Do not use the shadow tree when retrieving the underlying element for FatFinger.
3926         https://bugs.webkit.org/show_bug.cgi?id=95372
3927
3928         By using the shadow tree we were getting a mismatch between elements of the
3929         current element under focus and the one return to us from FatFingers.
3930         Passing ShadowContentNotAllowed to get the right handle.
3931
3932         Reviewed by Antonio Gomes.
3933
3934         * WebKitSupport/TouchEventHandler.cpp:
3935         (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
3936
3937 2012-08-29  Robin Cao  <robin.cao@torchmobile.com.cn>
3938
3939         [BlackBerry] Move the handling of UserMedia requests to the client
3940         https://bugs.webkit.org/show_bug.cgi?id=95317
3941         PR #197283
3942
3943         Reviewed by George Staikos.
3944
3945         Internally reviewed by George Staikos.
3946
3947         Move the logic for user media requests handling to the client, as it requires
3948         inputs from users. Also adds a origin field to WebUserMediaRequest.
3949
3950         * Api/WebPageClient.h:
3951         (Platform):
3952         * WebCoreSupport/UserMediaClientImpl.cpp:
3953         (WebCore::UserMediaClientImpl::UserMediaClientImpl):
3954         (WebCore::UserMediaClientImpl::~UserMediaClientImpl):
3955         (WebCore::UserMediaClientImpl::requestUserMedia):
3956         (WebCore::UserMediaClientImpl::cancelUserMediaRequest):
3957         * WebCoreSupport/UserMediaClientImpl.h:
3958         (UserMediaClientImpl):
3959
3960 2012-08-29  Antonio Gomes  <agomes@rim.com>
3961
3962         [BlackBerry] Replace blackberry specific HitTestRequest::FingerUp by TouchEvent + Release
3963         https://bugs.webkit.org/show_bug.cgi?id=95383
3964
3965         Reviewed by Rob Buis.
3966
3967         * WebKitSupport/TouchEventHandler.cpp:
3968         (BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
3969
3970 2012-08-29  Rob Buis  <rbuis@rim.com>
3971
3972         [BlackBerry] Adjust wtf include header style
3973         https://bugs.webkit.org/show_bug.cgi?id=95368
3974
3975         Reviewed by Yong Li.
3976
3977         Switch to #include <wtf/...> like the other ports.
3978
3979         * Api/BlackBerryGlobal.cpp:
3980         * Api/WebPage.cpp:
3981         * WebCoreSupport/ChromeClientBlackBerry.cpp:
3982         * WebCoreSupport/GeolocationControllerClientBlackBerry.h:
3983         * WebCoreSupport/SelectPopupClient.h:
3984         * WebKitSupport/AboutData.cpp:
3985         * WebKitSupport/DOMSupport.cpp:
3986         * WebKitSupport/GLES2Context.cpp:
3987         * WebKitSupport/InPageSearchManager.h:
3988         * WebKitSupport/InputHandler.cpp:
3989
3990 2012-08-29  Jacky Jiang  <zhajiang@rim.com>
3991
3992         [BlackBerry] Remove unused tapGesture in WebPage.cpp
3993         https://bugs.webkit.org/show_bug.cgi?id=95357
3994
3995         Reviewed by Rob Buis.
3996
3997         Remove unused variable tapGesture in WebPage.cpp.
3998         Internally reviewed by Gen Mak.
3999
4000         * Api/WebPage.cpp:
4001         (BlackBerry::WebKit::WebPage::touchEvent):
4002
4003 2012-08-28  Antonio Gomes  <agomes@rim.com>
4004
4005         [BlackBerry] crash while trying to scroll any inner frame
4006         https://bugs.webkit.org/show_bug.cgi?id=95287
4007         PR #198510
4008
4009         Reviewed by George Staikos.
4010
4011         Set the starting point of scrolling (slow path only still)
4012         for inner frames. It was left over as set to 0 by r126474.
4013
4014         In practice, patch fixes a crash on gmail.com desktop edition.
4015
4016         * WebKitSupport/InRegionScrollableArea.cpp:
4017         (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
4018
4019 2012-08-28  Sheriff Bot  <webkit.review.bot@gmail.com>
4020
4021         Unreviewed, rolling out r126914.
4022         http://trac.webkit.org/changeset/126914
4023         https://bugs.webkit.org/show_bug.cgi?id=95239
4024
4025         it breaks everything and fixes nothing (Requested by pizlo on
4026         #webkit).
4027