9e65272c932e9081f3471190d8b90818f53d28a2
[WebKit-https.git] / Source / WebKit / blackberry / ChangeLog
1 2013-05-27  Andy Chen  <andchen@blackberry.com>
2
3         [BlackBerry] Find-on-page should be able to convert the active match to selection when clearing all matches
4         https://bugs.webkit.org/show_bug.cgi?id=116837
5
6         Reviewed by Rob Buis.
7
8         PR 291903
9         Internally reviewed by Mike Fenton.
10
11         * Api/WebPage.cpp:
12         (BlackBerry::WebKit::WebPage::findNextString):
13         * Api/WebPage.h:
14         * WebKitSupport/InPageSearchManager.cpp:
15         (BlackBerry::WebKit::InPageSearchManager::findNextString):
16         (BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
17         * WebKitSupport/InPageSearchManager.h:
18         (InPageSearchManager):
19
20 2013-05-27  Eli Fidler  <efidler@rim.com>
21
22         [BlackBerry] Fix subframe target added to new requests
23         https://bugs.webkit.org/show_bug.cgi?id=116602
24
25         Reviewed by Rob Buis.
26
27         In some cases we might be adding TargetIsMainFrame to a subframe
28         request causing an isMainFrame assert.
29
30         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
31         (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
32         Check we are actually loading the main frame before setting
33         ResourceRequest::TargetIsMainFrame target.
34
35 2013-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
36
37         [BlackBerry] REGRESSION(r150071): Animation performance issues in some websites with CSS transforms
38         https://bugs.webkit.org/show_bug.cgi?id=116724
39
40         Reviewed by Rob Buis.
41
42         Add another bool variable m_previousFrameDone to make sure we
43         don't start a new frame until the previous one has been done. Also
44         make sure we pass the animation start time to
45         serviceScriptedAnimations().
46
47         * Api/WebPage.cpp:
48         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Initialize
49         m_previousFrameDone and m_monotonicAnimationStartTime.
50         (BlackBerry::WebKit::WebPagePrivate::animationFrameChanged):
51         Return early if previous frame is not done. Otherwise set
52         m_previousFrameDone to false and save the animation start time.
53         (BlackBerry::WebKit::WebPagePrivate::serviceAnimations): Call
54         serviceScriptedAnimations() passing the saved animation start time
55         and reset m_animationScheduled and m_previousFrameDone.
56         (BlackBerry::WebKit::WebPagePrivate::handleServiceScriptedAnimationsOnMainThread):
57         Call WebPagePrivate::serviceAnimations().
58         * Api/WebPage_p.h:
59         (WebPagePrivate):
60
61 2013-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
62
63         [BlackBerry] Remove encoding parameter from FrameLoaderClientBlackBerry::receivedData()
64         https://bugs.webkit.org/show_bug.cgi?id=116598
65
66         Reviewed by Rob Buis.
67
68         It's no longer needed since the encoder now checks the override encoding.
69
70         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
71         (WebCore::FrameLoaderClientBlackBerry::committedLoad): Call
72         receivedData() passing the DocumentLoader instead of the text
73         encoding.
74         (WebCore::FrameLoaderClientBlackBerry::receivedData): Call
75         DocumentLoader::commitData() directly.
76         * WebCoreSupport/FrameLoaderClientBlackBerry.h:
77         (FrameLoaderClientBlackBerry):
78
79 2013-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
80
81         [BlackBerry] Move PagePopup implementation to WebKitSupport
82         https://bugs.webkit.org/show_bug.cgi?id=116824
83
84         Reviewed by Rob Buis.
85
86         After r150434 PagePopup implementation in BlackBerry port is
87         independent from WebCore. The classes are now in the
88         BlackBerry::WebKit namespace so they can be moved from
89         WebCoresupport to WebKitSupport and renamed to remove the
90         BlackBerry suffix which is now redundant. Also, now that the
91         implementation is not shared, it can be simplified a bit more.
92
93         * Api/WebPage.cpp:
94         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Update to
95         API changes.
96         (BlackBerry::WebKit::WebPage::initPopupWebView): Ditto.
97         (BlackBerry::WebKit::WebPagePrivate::openPagePopup): Ditto.
98         (BlackBerry::WebKit::WebPagePrivate::closePagePopup): Ditto.
99         (BlackBerry::WebKit::WebPagePrivate::hasOpenedPopup): Ditto.
100         * Api/WebPage.h:
101         (WebKit): Ditto.
102         * Api/WebPage_p.h:
103         (WebKit): Ditto.
104         (WebPagePrivate): Rename m_selectPopup as m_pagePopup, since it
105         can also point to a color picker or date picker page popup. Also
106         use RefPtr instead of raw pointer.
107         * WebKitSupport/ColorPickerClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp.
108         (BlackBerry::WebKit::ColorPickerClient::ColorPickerClient):
109         (BlackBerry::WebKit::ColorPickerClient::generateHTML):
110         (BlackBerry::WebKit::ColorPickerClient::setValueAndClosePopup):
111         Return early if popup has been closed already.
112         (BlackBerry::WebKit::ColorPickerClient::didClosePopup):
113         * WebKitSupport/ColorPickerClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.h.
114         * WebKitSupport/DatePickerClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp.
115         (BlackBerry::WebKit::DatePickerClient::DatePickerClient):
116         (BlackBerry::WebKit::DatePickerClient::~DatePickerClient):
117         (BlackBerry::WebKit::DatePickerClient::generateHTML):
118         (BlackBerry::WebKit::DatePickerClient::setValueAndClosePopup):
119         Return early if popup has been closed already.
120         (BlackBerry::WebKit::DatePickerClient::didClosePopup):
121         (BlackBerry::WebKit::DatePickerClient::generateDateLabels):
122         * WebKitSupport/DatePickerClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.h.
123         * WebKitSupport/PagePopup.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.cpp.
124         (BlackBerry::WebKit::PagePopup::PagePopup):
125         (BlackBerry::WebKit::PagePopup::~PagePopup):
126         (BlackBerry::WebKit::PagePopup::initialize): Renamed as initialize
127         and made void, since it always returned true and the callers
128         ignored the return value.
129         (BlackBerry::WebKit::PagePopup::writeDocument): Renamed from
130         generateHTML for consistency with PagePopupClient::writeDocument()
131         and to avoid confusion with generateHTML method in the clients
132         that create the HTML contents but they don't write the document.
133         (BlackBerry::WebKit::PagePopup::setValueAndClosePopupCallback):
134         Make it static member of PagePopup since the JS object now holds a
135         reference of PagePopup instance as private data.
136         (BlackBerry::WebKit::popUpExtensionInitialize): Take a reference
137         of the PagePopup instance saved as private data of the JS object.
138         (BlackBerry::WebKit::popUpExtensionFinalize): Unref the PagePopup
139         instance saved as private data of the JS object.
140         (BlackBerry::WebKit::PagePopup::installDOMFunction): Instead of
141         saving the client as private data of the JS object using a wrapper
142         refcounted object, save the PagePopup instance that is now
143         refcounted and access the client from the PagePopup instance in
144         the callback.
145         (BlackBerry::WebKit::PagePopup::close): Renamed from closePagePopup
146         since PagePopup::closePagePopup was a bit redundant.
147         * WebKitSupport/PagePopup.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.h.
148         (BlackBerry::WebKit::PagePopup::create): Static member to create
149         instances of PagePopup now that it's refcounted.
150         * WebKitSupport/PagePopupClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerryClient.cpp.
151         (BlackBerry::WebKit::PagePopupClient::PagePopupClient):
152         (BlackBerry::WebKit::PagePopupClient::closePopup):
153         (BlackBerry::WebKit::PagePopupClient::didClosePopup):
154         (BlackBerry::WebKit::PagePopupClient::contentSize):
155         (BlackBerry::WebKit::PagePopupClient::writeDocument):
156         * WebKitSupport/PagePopupClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerryClient.h.
157         * WebKitSupport/SelectPopupClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp.
158         (BlackBerry::WebKit::SelectPopupClient::SelectPopupClient):
159         (BlackBerry::WebKit::SelectPopupClient::~SelectPopupClient):
160         (BlackBerry::WebKit::SelectPopupClient::generateHTML):
161         (BlackBerry::WebKit::SelectPopupClient::setValueAndClosePopup):
162         Return early if popup has been closed already.
163         (BlackBerry::WebKit::SelectPopupClient::didClosePopup):
164         (BlackBerry::WebKit::SelectPopupClient::notifySelectionChange):
165         * WebKitSupport/SelectPopupClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.h.
166
167 2013-05-26  Jakob Petsovits  <jpetsovits@blackberry.com>
168
169         [BlackBerry] Make screen updates dependent on the existence of a drawing buffer.
170         https://bugs.webkit.org/show_bug.cgi?id=116539
171         Internal PR 330917
172
173         Reviewed by Carlos Garcia Campos.
174         Internally reviewed by Xiaobo Wang and Arvid Nilsson.
175
176         This reduces complexity by relying on the current state,
177         rather than the suspend counter, which in turn makes it
178         possible to simplify the code in setCompositor().
179
180         * Api/BackingStore.cpp:
181         (BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
182         (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
183         * Api/WebPage.cpp:
184         (BlackBerry::WebKit::WebPagePrivate::setCompositor):
185
186 2013-05-26  Kent Tamura  <tkent@chromium.org>
187
188         Remove ENABLE_CALENDAR_PICKER
189         https://bugs.webkit.org/show_bug.cgi?id=116795
190
191         Reviewed by Ryosuke Niwa.
192
193         * WebCoreSupport/AboutDataEnableFeatures.in:
194         The list was wrong. Blackberry port doesn't use CALENDAR_PICKER code.
195
196 2013-05-26  Andreas Kling  <akling@apple.com>
197
198         FocusController::setFocusedNode() should be setFocusedElement().
199         <http://webkit.org/b/116780>
200
201         Reviewed by Antti Koivisto.
202
203         * Api/WebPage.cpp:
204         (BlackBerry::WebKit::WebPagePrivate::clearFocusNode):
205         (BlackBerry::WebKit::WebPage::setNodeFocus):
206         * WebKitSupport/SelectionHandler.cpp:
207         (BlackBerry::WebKit::SelectionHandler::selectObject):
208
209 2013-05-24  Anders Carlsson  <andersca@apple.com>
210
211         Remove PagePopup code
212         https://bugs.webkit.org/show_bug.cgi?id=116732
213
214         Reviewed by Andreas Kling.
215
216         * WebCoreSupport/AboutDataEnableFeatures.in:
217         Remove PAGE_POPUP.
218
219 2013-05-24  Mike Fenton  <mifenton@rim.com>
220
221         [BlackBerry] Fix bad type warning in InputHandler log.
222         https://bugs.webkit.org/show_bug.cgi?id=116720
223
224         Reviewed by Carlos Garcia Campos.
225
226         Fix warning in inputLog string.
227
228         * WebKitSupport/InputHandler.cpp:
229         (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
230
231 2013-05-24  Mike Fenton  <mifenton@rim.com>
232
233         [BlackBerry] Respect tabindex when using form controls.
234         https://bugs.webkit.org/show_bug.cgi?id=116676
235
236         Reviewed by Xan Lopez.
237
238         PR 337419.
239
240         Update form control navigation tracking to take tabindex
241         order into account when calculating next and previous nodes.
242
243         The order to follow is tab index 1 - N, followed by all items
244         without a tab index or tab index 0 in rendering order to match
245         with standard desktop behavior.
246
247         Internally Reviewed by Genevieve Mak and Nima Ghanavatian.
248
249         * WebKitSupport/InputHandler.cpp:
250         (BlackBerry::WebKit::InputHandler::updateFormState):
251
252 2013-05-24  Jeff Rogers  <jrogers@rim.com>
253
254         [BlackBerry] Remove SKIA leftovers from WebPage.cpp
255         https://bugs.webkit.org/show_bug.cgi?id=116656
256
257         Reviewed by Rob Buis.
258
259         * Api/WebPage.cpp:
260         (BlackBerry::WebKit::WebPagePrivate::setLoadState):
261
262 2013-05-23  Xiaobo Wang  <xiaobwang@blackberry.com>
263
264         [BlackBerry] Need to suspend/resume RootLayerCommit when the application becomes inactive/active
265         https://bugs.webkit.org/show_bug.cgi?id=115245
266
267         Reviewed by Rob Buis.
268
269         PR 330917.
270         Internally reviewed by Arvid Nilsson.
271
272         1. Suspend/resumeRootLayerCommit when notified app activation state
273         change.
274         2. Schedule root layer commit in resumeRootLayerCommit() to explicitly
275         start root layer commit timer, so that there's a commit even if
276         BackingStore got disabled/removed.
277
278         * Api/WebPage.cpp:
279         (BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
280         (BlackBerry::WebKit::WebPagePrivate::resumeRootLayerCommit):
281
282 2013-05-23  Andy Chen  <andchen@blackberry.com>
283
284         [BlackBerry] Need to forward the opener frame url to client when creating a new window
285         https://bugs.webkit.org/show_bug.cgi?id=116566
286
287         Reviewed by Rob Buis.
288
289         PR 337935
290         Internally reviewed by Arvid Nilsson.
291         When creating a new window, forward the opener frame url to client.
292
293         * Api/WebPageClient.h:
294         * WebCoreSupport/ChromeClientBlackBerry.cpp:
295         (WebCore::ChromeClientBlackBerry::createWindow):
296         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
297         (WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
298
299 2013-05-23  Jakob Petsovits  <jpetsovits@blackberry.com>
300
301         [BlackBerry] Compositor API change: Don't pass the unused "viewport" parameter.
302         https://bugs.webkit.org/show_bug.cgi?id=116545
303         Internal PR 189775
304
305         Reviewed by Rob Buis.
306
307         Also change the name of the "documentContents" parameter
308         to the more descriptive "documentSrcRect".
309
310         * Api/WebPageCompositor.cpp:
311         (BlackBerry::WebKit::WebPageCompositorPrivate::render):
312         (BlackBerry::WebKit::WebPageCompositor::render):
313         * Api/WebPageCompositor.h:
314         * Api/WebPageCompositor_p.h:
315         (WebPageCompositorPrivate):
316
317 2013-05-23  Ed Baker  <edbaker@blackberry.com>
318
319         [BlackBerry] The web context does not contain any link properties if the context node is an image enclosed by a link node
320         https://bugs.webkit.org/show_bug.cgi?id=116627
321
322         Reviewed by Xan Lopez.
323
324         PR #341084
325
326         If the context node has an image tag and an enclosing link node was detected then add the link properties to the context.
327
328         Internally Reviewed by Gen Mak.
329
330         * Api/WebPage.cpp:
331         (BlackBerry::WebKit::WebPagePrivate::webContext):
332
333 2013-05-23  Mike Fenton  <mifenton@rim.com>
334
335         [BlackBerry] Validate form data before doing direct submission.
336         https://bugs.webkit.org/show_bug.cgi?id=116674
337
338         Reviewed by Xan Lopez.
339
340         PR 314202.
341
342         Check validation of the input form before triggering direct submission.
343
344         Internally Reviewed by Nima Ghanavatian.
345
346         * WebKitSupport/InputHandler.cpp:
347         (BlackBerry::WebKit::InputHandler::submitForm):
348
349 2013-05-23  Rob Buis  <rbuis@rim.com>
350
351         [BlackBerry] Properly fill the ResourceError in FrameLoaderClientBlackBerry::cannotShowURLError
352         https://bugs.webkit.org/show_bug.cgi?id=116603
353
354         Reviewed by Xan Lopez.
355
356         PR 119789
357         Internally reviewed by Yong Li.
358
359         Provide a domain value for this ResourceError instance. Note that
360         this does not change behavior.
361
362         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
363         (WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):
364
365 2013-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
366
367         [BlackBerry] Make PagePopup implementation independent from WebCore
368         https://bugs.webkit.org/show_bug.cgi?id=116448
369
370         Reviewed by Anders Carlsson.
371
372         Add our own implementation of PagePopupClient and make all the
373         pickers inherit from it. Unused methods have been removed and
374         common implementation have been moved from the pickers to the
375         parent class.
376
377         * Api/WebPage.cpp:
378         (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate): Destroy the
379         popup if there's one active.
380         (BlackBerry::WebKit::WebPagePrivate::setVisible): Call
381         closePagePopup() directly.
382         (BlackBerry::WebKit::WebPagePrivate::openPagePopup): Create a new
383         PagePopupBlackBerry for the given client.
384         (BlackBerry::WebKit::WebPagePrivate::closePagePopup): Close the
385         active popup if there's one.
386         (BlackBerry::WebKit::WebPagePrivate::hasOpenedPopup): Return
387         whether there's an active popup.
388         * Api/WebPage.h:
389         * Api/WebPage_p.h:
390         * WebCoreSupport/ChromeClientBlackBerry.cpp:
391         (WebCore::ChromeClientBlackBerry::chromeDestroyed): Remove
392         closePagePopup() call since this is now handled by
393         WebPagePrivate.
394         (WebCore::ChromeClientBlackBerry::hasOpenedPopup): Call
395         WebPagePrivate::hasOpenedPopup().
396         * WebCoreSupport/ChromeClientBlackBerry.h:
397         (ChromeClientBlackBerry):
398         * WebCoreSupport/ColorPickerClient.cpp:
399         (BlackBerry::WebKit::ColorPickerClient::ColorPickerClient):
400         (BlackBerry::WebKit::ColorPickerClient::didClosePopup):
401         * WebCoreSupport/ColorPickerClient.h:
402         (ColorPickerClient):
403         * WebCoreSupport/DatePickerClient.cpp:
404         (BlackBerry::WebKit::DatePickerClient::DatePickerClient):
405         (BlackBerry::WebKit::DatePickerClient::didClosePopup):
406         * WebCoreSupport/DatePickerClient.h:
407         (DatePickerClient):
408         * WebCoreSupport/PagePopupBlackBerry.cpp:
409         (BlackBerry::WebKit::PagePopupBlackBerry::PagePopupBlackBerry):
410         (BlackBerry::WebKit::PagePopupBlackBerry::closePopup):
411         * WebCoreSupport/PagePopupBlackBerry.h:
412         (PagePopupBlackBerry):
413         (BlackBerry::WebKit::PagePopupBlackBerry::SharedClientPointer::SharedClientPointer):
414         (BlackBerry::WebKit::PagePopupBlackBerry::SharedClientPointer::get):
415         (SharedClientPointer):
416         * WebCoreSupport/PagePopupBlackBerryClient.cpp: Added.
417         (BlackBerry::WebKit::PagePopupBlackBerryClient::PagePopupBlackBerryClient):
418         (BlackBerry::WebKit::PagePopupBlackBerryClient::closePopup):
419         (BlackBerry::WebKit::PagePopupBlackBerryClient::didClosePopup):
420         (BlackBerry::WebKit::PagePopupBlackBerryClient::contentSize):
421         (BlackBerry::WebKit::PagePopupBlackBerryClient::writeDocument):
422         * WebCoreSupport/PagePopupBlackBerryClient.h: Added.
423         (PagePopupBlackBerryClient):
424         (BlackBerry::WebKit::PagePopupBlackBerryClient::~PagePopupBlackBerryClient):
425         * WebCoreSupport/SelectPopupClient.cpp:
426         (BlackBerry::WebKit::SelectPopupClient::SelectPopupClient):
427         (BlackBerry::WebKit::SelectPopupClient::didClosePopup):
428         * WebCoreSupport/SelectPopupClient.h:
429         (SelectPopupClient):
430         * WebKitSupport/InputHandler.cpp:
431         (BlackBerry::WebKit::InputHandler::openDatePopup): Do not call
432         closePagePopup() since this is already done by openPagePopup() and
433         use openPagePopup() from WebPagePrivate directly.
434         (BlackBerry::WebKit::InputHandler::openColorPopup): Ditto.
435         (BlackBerry::WebKit::InputHandler::openSelectPopup): Ditto.
436
437 2013-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
438
439         [BlackBerry] Do not use skia in FrameLoaderClientBlackBerry::dispatchDidReceiveIcon()
440         https://bugs.webkit.org/show_bug.cgi?id=116302
441
442         Reviewed by Rob Buis.
443
444         TiledImage is now the NativeImage of the BlackBerry port.
445
446         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
447         (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
448
449 2013-05-19  Anders Carlsson  <andersca@apple.com>
450
451         Remove link prerendering code
452         https://bugs.webkit.org/show_bug.cgi?id=116415
453
454         Reviewed by Darin Adler.
455
456         This code was only used by Chromium and is dead now.
457
458         * WebCoreSupport/AboutDataEnableFeatures.in:
459
460 2013-05-19  Anders Carlsson  <andersca@apple.com>
461
462         Remove ChromeClient::webView()
463         https://bugs.webkit.org/show_bug.cgi?id=116054
464
465         Reviewed by Andreas Kling.
466
467         This blatantly horrible layer violation was only used by the Chromium port; get rid of it.
468
469         * WebCoreSupport/ChromeClientBlackBerry.h:
470         (ChromeClientBlackBerry):
471
472 2013-05-17  Carlos Garcia Campos  <cgarcia@igalia.com>
473
474         [BlackBerry] REGRESSION(r150060): Crash in LayerWebKitThread::updateTextureContents
475         https://bugs.webkit.org/show_bug.cgi?id=116305
476
477         Reviewed by Rob Buis.
478
479         PR 340537.
480         Internally reviewed by Arvid Nilsson.
481
482         Use updateLayoutAndStyleIfNeededRecursive() instead of
483         layoutIfNeeded() since we are about to draw in
484         rootLayerCommitTimerFired().
485
486         * Api/WebPage.cpp:
487         (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
488
489 2013-05-17  Mike Fenton  <mifenton@rim.com>
490
491         [BlackBerry] Remove stale comment for select mouse handling.
492         https://bugs.webkit.org/show_bug.cgi?id=116309
493
494         Reviewed by Rob Buis.
495
496         PR 135935.
497
498         Remove a FIXME that has been invalidated by a change
499         to our touch -> mouse model.
500
501         Internally Rubberstamped by Genevieve Mak.
502
503         * Api/WebPage.cpp:
504         (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
505
506 2013-05-17  Alberto Garcia  <agarcia@igalia.com>
507
508         [BlackBerry] DumpRenderTreeSupport: fix build in setMockDeviceOrientation()
509         https://bugs.webkit.org/show_bug.cgi?id=116298
510
511         Reviewed by Carlos Garcia Campos.
512
513         Pass the correct parameter to toDeviceOrientationClientMock()
514
515         * WebKitSupport/DumpRenderTreeSupport.cpp:
516         (DumpRenderTreeSupport::setMockDeviceOrientation):
517
518 2013-05-16  Mike Fenton  <mifenton@rim.com>
519
520         [BlackBerry] Optimize caret bounds calculation when leaving an input field.
521         https://bugs.webkit.org/show_bug.cgi?id=116224
522
523         Reviewed by Rob Buis.
524
525         PR 340132.
526
527         If the caret is no longer active in the field, do not allow it
528         to go into the single line input logic and calculate the node
529         bounding box.
530
531         Internally Reviewed By Gen Mak
532
533         * WebKitSupport/SelectionHandler.cpp:
534         (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
535
536 2013-05-16  Mary Wu  <mary.wu@torchmobile.com.cn>
537
538         [BlackBerry] Unable to download blob resource
539         https://bugs.webkit.org/show_bug.cgi?id=115888
540
541         Reviewed by Benjamin Poulain.
542
543         For blob resource (blob:http....), it's not suitable to go to NetworkStream
544         which don't handle "blob" protocol at all. since blob data already handled
545         in BlobResourceHandle, simply get the data out to download stream.
546
547         RIM bug 331086, internally reviewed by Charles Wei and Leo Yang.
548
549         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
550         (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
551
552 2013-05-16  Andreas Kling  <akling@apple.com>
553
554         Page::chrome() should return a reference.
555         <http://webkit.org/b/116185>
556
557         Reviewed by Anders Carlsson.
558
559 2013-05-13  Anders Carlsson  <andersca@apple.com>
560
561         Frame::editor() should return a reference
562         https://bugs.webkit.org/show_bug.cgi?id=116037
563
564         Reviewed by Darin Adler.
565
566         * WebCoreSupport/EditorClientBlackBerry.cpp:
567         (WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
568         (WebCore::EditorClientBlackBerry::handleKeyboardEvent):
569         * WebKitSupport/DOMSupport.cpp:
570         (BlackBerry::WebKit::DOMSupport::elementHasContinuousSpellCheckingEnabled):
571         * WebKitSupport/InPageSearchManager.cpp:
572         (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
573         (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
574         * WebKitSupport/SelectionHandler.cpp:
575         (BlackBerry::WebKit::SelectionHandler::selectedText):
576
577 2013-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
578
579         Remove WTF_USE_PLATFORM_STRATEGIES
580         https://bugs.webkit.org/show_bug.cgi?id=114431
581
582         Reviewed by Darin Adler.
583
584         * WebCoreSupport/AboutDataUseFeatures.in:
585
586 2013-05-14  Tiancheng Jiang  <tijiang@rim.com>
587
588         [BlackBerry] Improve Fatfinger phase.
589         https://bugs.webkit.org/show_bug.cgi?id=107403
590
591         Reviewed by Rob Buis.
592
593         Internally reviewed by Genevieve Mak.
594         BlackBerry PR 324965.
595
596         Cache and reuse intersected nodes as long as hit position has not been
597         changed.
598
599         * Api/WebPage.cpp:
600         (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
601         * Api/WebPage_p.h:
602         (WebPagePrivate):
603         * WebKitSupport/FatFingers.cpp:
604         (BlackBerry::WebKit::FatFingers::findBestPoint):
605         (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
606         (BlackBerry::WebKit::FatFingers::getNodesFromRect):
607         * WebKitSupport/FatFingers.h:
608
609 2013-05-14  Andrew Lo  <anlo@rim.com>
610
611         [BlackBerry] Hook up frame render begin/end in PerformanceMonitor
612         https://bugs.webkit.org/show_bug.cgi?id=116110
613
614         Reviewed by Rob Buis.
615
616         Internally reviewed by Jeff Rogers, Jonathan Jiang.
617         Internal PR 299155.
618
619         Mark frame render begin & end for BlackBerry performance monitoring
620         in blitVisibleContents.
621
622         * Api/BackingStore.cpp:
623         (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
624
625 2013-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
626
627         [BlackBerry] Use requestAnimationFrame for animations
628         https://bugs.webkit.org/show_bug.cgi?id=115896
629
630         Reviewed by Rob Buis.
631
632         Make WebPagePrivate a
633         BlackBerry::Platform::AnimationFrameRateClient and use it to
634         schedule animations.
635
636         * Api/WebPage.cpp:
637         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
638         (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
639         (WebKit):
640         (BlackBerry::WebKit::WebPagePrivate::animationFrameChanged):
641         (BlackBerry::WebKit::WebPagePrivate::scheduleAnimation):
642         (BlackBerry::WebKit::WebPagePrivate::startRefreshAnimationClient):
643         (BlackBerry::WebKit::WebPagePrivate::stopRefreshAnimationClient):
644         (BlackBerry::WebKit::WebPagePrivate::handleServiceScriptedAnimationsOnMainThread):
645         * Api/WebPage_p.h:
646         (WebPagePrivate):
647         * WebCoreSupport/ChromeClientBlackBerry.cpp:
648         (WebCore):
649         (WebCore::ChromeClientBlackBerry::scheduleAnimation):
650         * WebCoreSupport/ChromeClientBlackBerry.h:
651         (ChromeClientBlackBerry):
652
653 2013-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
654
655         [BlackBerry] Implement platform strategies
656         https://bugs.webkit.org/show_bug.cgi?id=112162
657
658         Reviewed by Rob Buis.
659
660         * Api/BlackBerryGlobal.cpp:
661         (BlackBerry::WebKit::globalInitialize): Initialize platform
662         strategies.
663         * WebCoreSupport/PlatformStrategiesBlackBerry.cpp: Added.
664         (PlatformStrategiesBlackBerry::initialize):
665         (PlatformStrategiesBlackBerry::PlatformStrategiesBlackBerry):
666         (PlatformStrategiesBlackBerry::createCookiesStrategy):
667         (PlatformStrategiesBlackBerry::createDatabaseStrategy):
668         (PlatformStrategiesBlackBerry::createLoaderStrategy):
669         (PlatformStrategiesBlackBerry::createPasteboardStrategy):
670         (PlatformStrategiesBlackBerry::createPluginStrategy):
671         (PlatformStrategiesBlackBerry::createSharedWorkerStrategy):
672         (PlatformStrategiesBlackBerry::createStorageStrategy):
673         (PlatformStrategiesBlackBerry::createVisitedLinkStrategy):
674         (PlatformStrategiesBlackBerry::cookiesForDOM):
675         (PlatformStrategiesBlackBerry::setCookiesFromDOM):
676         (PlatformStrategiesBlackBerry::cookiesEnabled):
677         (PlatformStrategiesBlackBerry::cookieRequestHeaderFieldValue):
678         (PlatformStrategiesBlackBerry::getRawCookies):
679         (PlatformStrategiesBlackBerry::deleteCookie):
680         (PlatformStrategiesBlackBerry::refreshPlugins):
681         (PlatformStrategiesBlackBerry::getPluginInfo):
682         (PlatformStrategiesBlackBerry::isLinkVisited):
683         (PlatformStrategiesBlackBerry::addVisitedLink):
684         * WebCoreSupport/PlatformStrategiesBlackBerry.h: Added.
685         (PlatformStrategiesBlackBerry):
686
687 2013-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
688
689         [BlackBerry] Crash due to an assert in FrameView::doDeferredRepaints
690         https://bugs.webkit.org/show_bug.cgi?id=115412
691
692         Reviewed by Rob Buis.
693
694         PR 115412
695
696         The problem is that we are calling
697         updateLayoutAndStyleIfNeededRecursive() (because of
698         zoomToInitialScaleOnLoad) from ChomeClient::layoutUpdated()
699         callback which is not expected. It's expected to be called right
700         before painting, and not right after painting. Even if a new
701         layout is not done, updateLayoutAndStyleIfNeededRecursive() calls
702         flushDeferredRepaints() and it's possible that this is called in
703         the middle of a beginDeferredRepaints() and endDeferredRepaints()
704         apparently.
705         In general only BackingStore should call
706         updateLayoutAndStyleIfNeededRecursive before painting, and a simple
707         layout is enough in all other cases like resizing. This patch renames
708         requestLayoutIfNeeded as updateLayoutAndStyleIfNeededRecursive to
709         make more obvious what it does, and adds layoutIfNeeded that calls
710         layout. The former is used by the BackingStore and the latter by
711         WebPage.
712
713         * Api/BackingStore.cpp:
714         (BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
715         (BlackBerry::WebKit::BackingStorePrivate::requestLayoutIfNeeded):
716         * Api/WebPage.cpp:
717         (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
718         (BlackBerry::WebKit::WebPagePrivate::updateLayoutAndStyleIfNeededRecursive):
719         (BlackBerry::WebKit::WebPagePrivate::layoutIfNeeded):
720         (WebKit):
721         (BlackBerry::WebKit::WebPagePrivate::overflowExceedsContentsSize):
722         (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
723         (BlackBerry::WebKit::WebPagePrivate::webContext):
724         (BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
725         (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
726         (BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
727         (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
728         * Api/WebPage_p.h:
729         (WebPagePrivate):
730
731 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
732
733         Remove USE(OS_RANDOMNESS)
734         https://bugs.webkit.org/show_bug.cgi?id=108095
735
736         Reviewed by Darin Adler.
737
738         Remove the USE(OS_RANDOMNESS) guard as it is turned on for all
739         ports.
740
741         * WebCoreSupport/AboutDataUseFeatures.in:
742
743 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
744
745         Fix some compiler warnings (miscellaneous)
746         https://bugs.webkit.org/show_bug.cgi?id=80790
747
748         Reviewed by Rob Buis.
749
750         Fix the following warnings for BlackBerry:
751         BackingStore.cpp:852:60: warning: suggest parentheses around '&&' within
752         '||' [-Wparentheses].
753         WebPage.cpp:2858:40: warning: suggest parentheses around assignment used
754         as truth value [-Wparentheses].
755         WebPage.cpp:2880:42: warning: suggest parentheses around assignment used
756         as truth value [-Wparentheses]
757
758         * Api/BackingStore.cpp:
759         (BlackBerry::WebKit::BackingStorePrivate::updateTilesAfterBackingStoreRectChange):
760         * Api/WebPage.cpp:
761         (BlackBerry::WebKit::WebPagePrivate::adjustRectOffsetForFrameOffset):
762         (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
763
764 2013-05-09  Mike Fenton  <mifenton@rim.com>
765
766         [BlackBerry] Style updates required based on new check-webkit-style
767         https://bugs.webkit.org/show_bug.cgi?id=115857
768
769         Reviewed by Rob Buis.
770
771         Update iInRegionScroller, WebKitTextCodec and WebPageCompositor
772         to match check-webkit-style updates.
773
774         * Api/InRegionScroller.cpp:
775         (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
776         * Api/InRegionScroller_p.h:
777         * Api/WebKitTextCodec.cpp:
778         (BlackBerry::WebKit::transcode):
779         * Api/WebPageCompositor.cpp:
780         (BlackBerry::WebKit::WebPageCompositor::render):
781         * Api/WebPageCompositor.h:
782         * Api/WebPageCompositor_p.h:
783         (WebPageCompositorPrivate):
784         * Api/WebSettings_p.h:
785
786 2013-05-09  Max Feil  <mfeil@rim.com>
787
788         shouldUsePluginDocument() needs to be respected when a document is created
789         https://bugs.webkit.org/show_bug.cgi?id=110308
790
791         Reviewed by Rob Buis.
792
793         This patch implements shouldAlwaysUsePluginDocument() in the
794         BlackBerry frame loader client. It is called in several places
795         within WebCore to determine whether a PluginDocument should
796         be created.
797
798         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
799         (WebCore::FrameLoaderClientBlackBerry::shouldAlwaysUsePluginDocument):
800         (WebCore):
801         (WebCore::FrameLoaderClientBlackBerry::createPlugin):
802         * WebCoreSupport/FrameLoaderClientBlackBerry.h:
803         (FrameLoaderClientBlackBerry):
804
805 2013-05-09  Mike Fenton <mifenton@rim.com>
806
807         [BlackBerry] Style updates required based on new check-webkit-style
808         https://bugs.webkit.org/show_bug.cgi?id=115857
809
810         Reviewed by Rob Buis.
811
812         Update SelectionHandler to match check-webkit-style updates.
813
814         * WebKitSupport/SelectionHandler.cpp:
815         (BlackBerry::WebKit::shouldExtendSelectionInDirection):
816         (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
817         (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
818         (BlackBerry::WebKit::adjustCaretRects):
819         (BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
820         (BlackBerry::WebKit::regionRectListContainsPoint):
821         * WebKitSupport/SelectionHandler.h:
822         (SelectionHandler):
823
824 2013-05-09  Mike Fenton  <mifenton@rim.com>
825
826         [BlackBerry] Style updates required based on new check-webkit-style
827         https://bugs.webkit.org/show_bug.cgi?id=115857
828
829         Reviewed by Rob Buis.
830
831         Update WebPage and WebPageClient to match check-webkit-style updates.
832
833         * Api/WebPage.cpp:
834         (BlackBerry::WebKit::WebPagePrivate::init):
835         (BlackBerry::WebKit::WebPage::executeJavaScriptInIsolatedWorld):
836         (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
837         (BlackBerry::WebKit::WebPagePrivate::calculateReflowedScrollPosition):
838         (BlackBerry::WebKit::WebPagePrivate::centerOfVisibleContentsRect):
839         (BlackBerry::WebKit::WebPage::assignFocus):
840         (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
841         (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
842         (BlackBerry::WebKit::WebPage::deleteTextRelativeToCursor):
843         (BlackBerry::WebKit::WebPage::addVisitedLink):
844         (BlackBerry::WebKit::WebPagePrivate::findPatternStringForUrl):
845         (BlackBerry::WebKit::WebPage::notifySwipeEvent):
846         (BlackBerry::WebKit::WebPage::notifyScreenPowerStateChanged):
847         (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
848         (BlackBerry::WebKit::WebPagePrivate::setRootLayerWebKitThread):
849         (BlackBerry::WebKit::WebPagePrivate::releaseLayerResourcesCompositingThread):
850         * Api/WebPageClient.h:
851         * Api/WebPage_p.h:
852
853 2013-05-09  Mike Fenton  <mifenton@rim.com>
854
855
856         [BlackBerry] Style updates required based on new check-webkit-style
857         https://bugs.webkit.org/show_bug.cgi?id=115857
858
859         Reviewed by Rob Buis.
860
861         Update BackingStore to match check-webkit-style updates.
862
863         Internally reviewed by Jakob Petsovits.
864
865         * Api/BackingStore.cpp:
866         (BlackBerry::WebKit::bestDivisor):
867         (BlackBerry::WebKit::BackingStorePrivate::repaint):
868         (BlackBerry::WebKit::BackingStorePrivate::shouldMoveLeft):
869         (BlackBerry::WebKit::BackingStorePrivate::shouldMoveRight):
870         (BlackBerry::WebKit::BackingStorePrivate::shouldMoveUp):
871         (BlackBerry::WebKit::BackingStorePrivate::shouldMoveDown):
872         (BlackBerry::WebKit::BackingStorePrivate::canMoveLeft):
873         (BlackBerry::WebKit::BackingStorePrivate::canMoveRight):
874         (BlackBerry::WebKit::BackingStorePrivate::canMoveUp):
875         (BlackBerry::WebKit::BackingStorePrivate::canMoveDown):
876         (BlackBerry::WebKit::BackingStorePrivate::indexOfTile):
877         (BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
878         (BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
879         (BlackBerry::WebKit::BackingStoreGeometry::originOfTile):
880         (BlackBerry::WebKit::BackingStore::repaint):
881         * Api/BackingStore_p.h:
882         (BackingStoreGeometry):
883
884 2013-05-09  Mike Fenton  <mifenton@rim.com>
885
886         [BlackBerry] Style updates required based on new check-webkit-style
887         https://bugs.webkit.org/show_bug.cgi?id=115857
888
889         Reviewed by Rob Buis.
890
891         Update ChromeClientBlackBerry, CredentialManager, FrameLoaderClientBlackBerry,
892         GeolocationClientBlackBerry and IconDatabaseClientBlackberry to
893         match check-webkit-style updates.
894
895         * WebCoreSupport/ChromeClientBlackBerry.h:
896         (ChromeClientBlackBerry):
897         * WebCoreSupport/CredentialManager.h:
898         (CredentialManager):
899         * WebCoreSupport/CredentialTransformData.cpp:
900         * WebCoreSupport/FrameLoaderClientBlackBerry.h:
901         (WebCore::FrameLoaderClientBlackBerry::assignIdentifierToInitialRequest):
902         (FrameLoaderClientBlackBerry):
903         (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveAuthenticationChallenge):
904         (WebCore::FrameLoaderClientBlackBerry::dispatchDidCancelAuthenticationChallenge):
905         (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveContentLength):
906         (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoading):
907         (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailLoading):
908         * WebCoreSupport/GeolocationClientBlackBerry.cpp:
909         (GeolocationClientBlackBerry::onLocationUpdate):
910         * WebCoreSupport/GeolocationClientBlackBerry.h:
911         (GeolocationClientBlackBerry):
912         * WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
913         (WebCore::IconDatabaseClientBlackBerry::initIconDatabase):
914
915 2013-05-09  Jacky Jiang  <zhajiang@blackberry.com>
916
917         Fix some compiler warnings (miscellaneous)
918         https://bugs.webkit.org/show_bug.cgi?id=80790
919
920         Reviewed by Rob Buis.
921
922         Fix the following warnings for BlackBerry:
923         InRegionScroller.cpp:286:39: warning: suggest parentheses around
924         assignment used as truth value [-Wparentheses].
925         InRegionScroller.cpp:349:39: warning: suggest parentheses around
926         assignment used as truth value [-Wparentheses].
927         InRegionScroller.cpp:456:82: warning: suggest parentheses around '&&'
928         within '||' [-Wparentheses].
929         InRegionScrollableArea.cpp:134:16: warning: suggest explicit braces to
930         avoid ambiguous 'else' [-Wparentheses].
931         SelectionHandler.cpp:390:109: warning: suggest parentheses around '&&'
932         within '||' [-Wparentheses].
933         SelectionOverlay.cpp:56:47: warning: comparison between signed and
934         unsigned integer expressions [-Wsign-compare].
935
936
937         * Api/InRegionScroller.cpp:
938         (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
939         (BlackBerry::WebKit::InRegionScrollerPrivate::firstScrollableInRegionForNode):
940         (BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
941         * WebKitSupport/InRegionScrollableArea.cpp:
942         (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
943         * WebKitSupport/SelectionHandler.cpp:
944         (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
945         * WebKitSupport/SelectionOverlay.cpp:
946         (BlackBerry::WebKit::SelectionOverlay::draw):
947
948 2013-05-09  Mike Fenton  <mifenton@rim.com>
949
950         [BlackBerry] Style updates required based on new check-webkit-style
951         https://bugs.webkit.org/show_bug.cgi?id=115857
952
953         Reviewed by Rob Buis.
954
955         Update ColorPickerClient and PagePopupBlackBerry
956         to match check-webkit-style updates.
957
958         * WebCoreSupport/ColorPickerClient.cpp:
959         (WebCore::ColorPickerClient::generateHTML):
960         * WebCoreSupport/PagePopupBlackBerry.cpp:
961         (WebCore::setValueAndClosePopupCallback):
962         (WebCore::PagePopupBlackBerry::installDOMFunction):
963
964 2013-05-09  Alberto Garcia  <agarcia@igalia.com>
965
966         [BlackBerry] Upstream the input popups
967         https://bugs.webkit.org/show_bug.cgi?id=114608
968
969         Reviewed by Rob Buis.
970
971         This patch contains contributions from many members of the
972         BlackBerry WebKit team, including:
973
974         Chris Hutten-Czapski
975         David Hoon
976         Jessica Cao
977         Rob Buis
978         Tiancheng Jiang
979
980         * WebCoreSupport/ColorPickerClient.cpp:
981         (WebCore):
982         (WebCore::ColorPickerClient::generateHTML):
983         * WebCoreSupport/DatePickerClient.cpp:
984         (WebCore):
985         (WebCore::DatePickerClient::generateHTML):
986         (WebCore::DatePickerClient::generateDateLabels):
987         * WebCoreSupport/DatePickerClient.h:
988         (DatePickerClient):
989         * WebCoreSupport/SelectPopupClient.cpp:
990         (WebCore):
991         (WebCore::SelectPopupClient::generateHTML):
992
993 2013-05-09  Mike Fenton  <mifenton@rim.com>
994
995         [BlackBerry] Style updates required based on new check-webkit-style
996         https://bugs.webkit.org/show_bug.cgi?id=115857
997
998         Reviewed by Rob Buis.
999
1000         Update DOMSupport to match check-webkit-style updates.
1001
1002         * WebKitSupport/DOMSupport.cpp:
1003         (BlackBerry::WebKit::DOMSupport::isTextInputElement):
1004         (BlackBerry::WebKit::DOMSupport::isPasswordElement):
1005         (BlackBerry::WebKit::DOMSupport::convertPointToFrame):
1006
1007 2013-05-09  Xuefei Ren  <xren@blackberry.com>
1008
1009         [BLACKBERRY]fix regression in Webpage
1010         and FrameLoaderClientBlackberry
1011         https://bugs.webkit.org/show_bug.cgi?id=115843
1012
1013         Reviewed by Rob Buis.
1014
1015         Internally reviewed by Mary Wu.
1016
1017         * Api/WebPage.cpp:
1018         (BlackBerry::WebKit::WebPage::loadFile):
1019         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1020         (WebCore::FrameLoaderClientBlackBerry::startDownload):
1021
1022 2013-05-09  Mike Fenton  <mifenton@rim.com>
1023
1024         [BlackBerry] Style updates required based on new check-webkit-style
1025         https://bugs.webkit.org/show_bug.cgi?id=115857
1026
1027         Reviewed by Rob Buis.
1028
1029         Update FatFingers to match check-webkit-style updates.
1030
1031         * WebKitSupport/FatFingers.cpp:
1032         (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
1033         (BlackBerry::WebKit::FatFingers::checkForClickableElement):
1034         * WebKitSupport/FatFingers.h:
1035         (FatFingersResult):
1036
1037 2013-05-09  Mike Fenton  <mifenton@rim.com>
1038
1039         [BlackBerry] Style updates required based on new check-webkit-style
1040         https://bugs.webkit.org/show_bug.cgi?id=115857
1041
1042         Reviewed by Rob Buis.
1043
1044         Update InRegionScrollableArea, TileIndexHash
1045         and TouchEventHandler to match check-webkit-style updates.
1046
1047         * WebKitSupport/InRegionScrollableArea.cpp:
1048         * WebKitSupport/TileIndexHash.h:
1049         * WebKitSupport/TouchEventHandler.cpp:
1050         (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
1051
1052 2013-05-09  Mike Fenton  <mifenton@rim.com>
1053
1054         [BlackBerry] Style updates required based on new check-webkit-style
1055         https://bugs.webkit.org/show_bug.cgi?id=115857
1056
1057         Reviewed by Rob Buis.
1058
1059         Styles fixes required for InputHandler based on updated
1060         check-webkit-style.
1061
1062         * WebKitSupport/InputHandler.cpp:
1063         (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
1064         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
1065         (BlackBerry::WebKit::InputHandler::ensureFocusPluginElementVisible):
1066         (BlackBerry::WebKit::InputHandler::setPopupListIndexes):
1067         (BlackBerry::WebKit::InputHandler::firstSpanInString):
1068         (BlackBerry::WebKit::InputHandler::setTextAttributes):
1069         * WebKitSupport/InputHandler.h:
1070
1071 2013-05-08  Eli Fidler  <efidler@blackberry.com>
1072
1073         [BlackBerry] Fix usage of BlackBerry::Platform::String
1074         https://bugs.webkit.org/show_bug.cgi?id=115781
1075
1076         Reviewed by Rob Buis.
1077
1078         BlackBerry PRs 304193 and 327181
1079         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
1080
1081         We currently have a problem where we're passing UTF-8 encoded data into
1082         the char* constructors of BlackBerry::Platform::String. This means the string
1083         thinks its data is not UTF-8.
1084
1085         * Api/JavaScriptVariant.cpp:
1086         (BlackBerry::WebKit::JSValueRefToBlackBerryJavaScriptVariant):
1087         * Api/WebKitTextCodec.cpp:
1088         (BlackBerry::WebKit::base64Encode):
1089         * Api/WebPage.cpp:
1090         (BlackBerry::WebKit::WebPage::loadFile):
1091         (BlackBerry::WebKit::WebPage::textEncoding):
1092         (BlackBerry::WebKit::WebPage::textHasAttribute):
1093         (BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):
1094         * Api/WebPage.h:
1095         * Api/WebSettings.cpp:
1096         (BlackBerry::WebKit::WebSettings::standardSettings):
1097         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1098         (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
1099         (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
1100         * WebKitSupport/DefaultTapHighlight.cpp:
1101         (WebKit):
1102         (BlackBerry::WebKit::DefaultTapHighlight::draw):
1103         (BlackBerry::WebKit::DefaultTapHighlight::hide):
1104
1105 2013-05-08  Rob Buis  <rbuis@rim.com>
1106
1107         Fix some compiler warnings (miscellaneous)
1108         https://bugs.webkit.org/show_bug.cgi?id=80790
1109
1110         Reviewed by Philip Rogers.
1111
1112         Get rid of the following warning for BlackBerry:
1113
1114         BackingStoreClient.cpp:54:21: warning: unused parameter 'parentFrame' [-Wunused-parameter]
1115
1116         by using ASSERT_UNUSED instead of ASSERT.
1117
1118         * WebKitSupport/BackingStoreClient.cpp:
1119         (BlackBerry::WebKit::BackingStoreClient::create):
1120
1121 2013-05-07  Xuefei Ren  <xren@blackberry.com>
1122
1123         Clean up load interface in WebPage
1124         https://bugs.webkit.org/show_bug.cgi?id=115622
1125         Reviewed by Rob Buis.
1126
1127         Internal PR:315535
1128         Internal reviewed by  Mary Wu
1129
1130         * Api/WebPage.cpp:
1131         (BlackBerry::WebKit::WebPagePrivate::load):
1132         (BlackBerry::WebKit::WebPage::loadFile):
1133         (BlackBerry::WebKit::WebPage::load):
1134         * Api/WebPage.h:
1135         * Api/WebPage_p.h:
1136         (WebPagePrivate):
1137         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1138         (WebCore::FrameLoaderClientBlackBerry::startDownload):
1139
1140 2013-05-07  Mike Fenton  <mifenton@rim.com>
1141
1142         [BlackBerry] Increase the padding size for caret based scrolling.
1143         https://bugs.webkit.org/show_bug.cgi?id=115749
1144
1145         Reviewed by Rob Buis.
1146
1147         PR 322670.
1148
1149         Increasing the padding size for scrolling in order to optimize the
1150         number of scrolls required during typing.
1151
1152         * WebKitSupport/InputHandler.cpp:
1153         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
1154
1155 2013-05-07  Nima Ghanavatian  <nghanavatian@blackberry.com>
1156
1157         [BlackBerry] Maintain touch event state throughout processing
1158         https://bugs.webkit.org/show_bug.cgi?id=115663
1159
1160         Reviewed by Rob Buis.
1161
1162         Internally reviewed by Otto Cheung and Genevieve Mak.
1163
1164         PR 297691
1165         By maintaining our touch event state, we can get a better idea
1166         of what triggered an update to selection and respond appropriately.
1167         On touch press we set userTouchTriggered to give the UI thread
1168         some context.
1169
1170         * Api/WebPage.cpp:
1171         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
1172         (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
1173         (BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
1174         * Api/WebPage_p.h:
1175         (WebPagePrivate):
1176         * WebKitSupport/SelectionHandler.cpp:
1177         (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
1178
1179 2013-05-07  Nima Ghanavatian  <nghanavatian@blackberry.com>
1180
1181         [BlackBerry] Read-only fields should not get keyboard focus
1182         https://bugs.webkit.org/show_bug.cgi?id=115725
1183
1184         Reviewed by Rob Buis.
1185
1186         Internally reviewed by Mike Fenton.
1187
1188         PR332887
1189         Prevent keyboard focus and FCC from displaying when the user taps on a
1190         read-only field. Further, ensure form controls skip over these fields
1191         with the next/previous buttons.
1192
1193         * WebKitSupport/DOMSupport.cpp:
1194         (BlackBerry::WebKit::DOMSupport::elementIsReadOnly):
1195         (DOMSupport):
1196         * WebKitSupport/DOMSupport.h:
1197         * WebKitSupport/InputHandler.cpp:
1198         (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
1199         (BlackBerry::WebKit::InputHandler::setInputModeEnabled):
1200         (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
1201         (BlackBerry::WebKit::InputHandler::isActiveTextEdit):
1202         (WebKit):
1203         * WebKitSupport/InputHandler.h:
1204
1205 2013-05-07  Nima Ghanavatian  <nghanavatian@blackberry.com>
1206
1207         [BlackBerry] Expand spellcheck logging
1208         https://bugs.webkit.org/show_bug.cgi?id=115482
1209
1210         Reviewed by Rob Buis.
1211
1212         Internally reviewed by Mike Fenton.
1213
1214         Fix some build errors when SpellingLog was turned on and expand on the debug
1215         statements to be more verbose. Set up timers and print the duration of each
1216         iteration as we traverse the text to create a range to send out for checking.
1217
1218         * WebKitSupport/InputHandler.cpp:
1219         (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
1220         (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
1221         (BlackBerry::WebKit::InputHandler::setElementFocused):
1222         (WebKit):
1223         (BlackBerry::WebKit::InputHandler::spellCheckTextBlock):
1224         * WebKitSupport/SpellingHandler.cpp:
1225         (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
1226         (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
1227
1228 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
1229
1230         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
1231         https://bugs.webkit.org/show_bug.cgi?id=113808
1232
1233         Reviewed by Rob Buis.
1234
1235         Create a WebSetting for text autosizing. The default is off.
1236
1237         * Api/WebPage.cpp:
1238         (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
1239         * Api/WebSettings.cpp:
1240         (WebKit):
1241         (BlackBerry::WebKit::WebSettings::standardSettings):
1242         (BlackBerry::WebKit::WebSettings::isTextAutosizingEnabled):
1243         (BlackBerry::WebKit::WebSettings::setTextAutosizingEnabled):
1244         * Api/WebSettings.h:
1245
1246 2013-05-06  Nima Ghanavatian  <nghanavatian@blackberry.com>
1247
1248         [BlackBerry] Ensure document is attached before accessing its FrameSelection
1249         https://bugs.webkit.org/show_bug.cgi?id=115565
1250
1251         Reviewed by Rob Buis.
1252
1253         Internally reviewed by Mike Fenton.
1254
1255         PR 312101
1256         We need to make sure that the node and document
1257         are attached before accessing the FrameSelection. This was
1258         handled earlier but not all call paths were covered.
1259
1260         * WebKitSupport/InputHandler.cpp:
1261         (BlackBerry::WebKit::InputHandler::setElementUnfocused):
1262         (BlackBerry::WebKit::InputHandler::isActiveTextEdit):
1263         (WebKit):
1264         * WebKitSupport/InputHandler.h:
1265
1266 2013-05-06  Nima Ghanavatian  <nghanavatian@blackberry.com>
1267
1268         [BlackBerry] Do not spellcheck when composition is active.
1269         https://bugs.webkit.org/show_bug.cgi?id=115562
1270
1271         Reviewed by Rob Buis.
1272
1273         Internally reviewed by Mike Fenton.
1274
1275         PR331344
1276         Typing can trigger rechecking since layout changes. Ensure
1277         extra work is only done when we need it, and that it won't
1278         be triggered when composition is active. If the user hasn't
1279         finished a word yet, it is likely future key events will be
1280         arriving, so checking the string at this point is extraneous.
1281
1282         * WebKitSupport/InputHandler.cpp:
1283         (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
1284
1285 2013-05-06  Nima Ghanavatian  <nghanavatian@blackberry.com>
1286
1287         [BlackBerry] Reduce the spellcheck checking range
1288         https://bugs.webkit.org/show_bug.cgi?id=115479
1289
1290         Reviewed by Rob Buis.
1291
1292         Internally reviewed by Mike Fenton.
1293
1294         PR332773
1295         Previously we were spellchecking the entire field on focus. If relayouting
1296         occurred we rechecked this region, which is very costly. Switch to check
1297         only a small region around the caret in both cases, which should alleviate
1298         much of the delays experienced in very large contenteditable fields. This
1299         allows for faster key input response and less time processing these requests
1300         on the WebKit thread.
1301
1302         * WebKitSupport/InputHandler.cpp:
1303         (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
1304         (BlackBerry::WebKit::InputHandler::spellCheckTextBlock):
1305         * WebKitSupport/SpellingHandler.cpp:
1306         (WebKit):
1307         (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
1308         * WebKitSupport/SpellingHandler.h:
1309         (SpellingHandler):
1310
1311 2013-05-06  Nima Ghanavatian  <nghanavatian@blackberry.com>
1312
1313         [BlackBerry] Use a more descriptive timer name
1314         https://bugs.webkit.org/show_bug.cgi?id=115481
1315
1316         Reviewed by Rob Buis.
1317
1318         Internally reviewed by Mike Fenton.
1319
1320         Changing m_timer to m_iterationDelayTimer.
1321
1322         * WebKitSupport/SpellingHandler.cpp:
1323         (BlackBerry::WebKit::SpellingHandler::SpellingHandler):
1324         (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
1325         (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
1326         * WebKitSupport/SpellingHandler.h:
1327         (SpellingHandler):
1328
1329 2013-05-04  Nima Ghanavatian  <nghanavatian@blackberry.com>
1330
1331         [BlackBerry] Clean up unused spellcheck code
1332         https://bugs.webkit.org/show_bug.cgi?id=115560
1333
1334         Reviewed by Benjamin Poulain.
1335         Internally reviewed by Mike Lattanzio
1336
1337         * Api/WebPage.cpp:
1338         (BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
1339         * Api/WebPage.h:
1340         * WebKitSupport/InputHandler.cpp:
1341         * WebKitSupport/InputHandler.h:
1342         (InputHandler):
1343
1344 2013-05-03  Jacky Jiang  <zhajiang@blackberry.com>
1345
1346         [BlackBerry] Page rendering scale is changed after go back and forward
1347         https://bugs.webkit.org/show_bug.cgi?id=115573
1348
1349         Reviewed by Rob Buis.
1350         Internally reviewed by Jeff Rogers.
1351
1352         PR: 326886
1353         When navigating back from page A with viewport to page B without
1354         viewport, we didn't call setViewMode(); therefore, we didn't change
1355         the fixed layout size which was set by page A. In that case, WebCore
1356         would just pick up page A's fixed layout size to layout page B which
1357         caused this issue.
1358         Expecting zoomToInitialScaleOnLoad() or other functions to setViewMode()
1359         later is not a good way, because zoomToInitialScaleOnLoad() has never
1360         been called in this case. So we should always call setViewMode() to set
1361         fixed layout size when a new page is committed.
1362
1363         * Api/WebPage.cpp:
1364         (BlackBerry::WebKit::WebPagePrivate::setLoadState):
1365
1366 2013-05-02  Genevieve Mak  <gmak@rim.com>
1367
1368         [BlackBerry] Cannot touch scroll readonly text input.
1369         https://bugs.webkit.org/show_bug.cgi?id=115378
1370
1371         Reviewed by Rob Buis.
1372
1373         PR #332902
1374         Reviewed Internally by Mike Fenton.
1375         Forgot half the patch.
1376         Node::rendererIsEditable() returns false if the input element has the readonly tag set.
1377         Check the node type instead.
1378
1379         * Api/InRegionScroller.cpp:
1380         (BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
1381
1382 2013-05-02  Iris Wu  <shuwu@blackberry.com>
1383
1384         [BlackBerry] Make scroll position adjustment work with pages with fixed position elements.
1385         https://bugs.webkit.org/show_bug.cgi?id=115178
1386
1387         Reviewed by Rob Buis.
1388
1389         PR 308796
1390         Debug build fix.
1391
1392         * Api/WebPage.cpp:
1393         (BlackBerry::WebKit::WebPage::fixedElementSizeDelta):
1394
1395 2013-05-01  Iris Wu  <shuwu@blackberry.com>
1396
1397          [BlackBerry] Upstream smart selection
1398          https://bugs.webkit.org/show_bug.cgi?id=111226
1399
1400         Reviewed by Rob Buis.
1401
1402         Calling userInterfaceViewportAccessor()->documentViewportRect() on WK thread
1403         caused crash.
1404         But viewport from webkitThreadViewportAccessor uses unadjusted size which is
1405         wrong for email.
1406         The solution here is to get actual viewport size on UI thread and then pass it
1407         to WebKit::SelectionHandler.
1408
1409         PR 333763
1410         Reviewed Internally By Jakob Petsovits.
1411
1412         * Api/InRegionScroller.cpp:
1413         (BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
1414         * Api/WebPage.cpp:
1415         (BlackBerry::WebKit::WebPage::setSelectionDocumentViewportSize):
1416         (WebKit):
1417         * Api/WebPage.h:
1418         * WebKitSupport/SelectionHandler.cpp:
1419         (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
1420         (BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
1421         (BlackBerry::WebKit::SelectionHandler::selectionViewportRect):
1422         * WebKitSupport/SelectionHandler.h:
1423         (BlackBerry::WebKit::SelectionHandler::setSelectionViewportSize):
1424         (BlackBerry::WebKit::SelectionHandler::setSelectionSubframeViewportRect):
1425         (SelectionHandler):
1426
1427 2013-04-30  Genevieve Mak  <gmak@rim.com>
1428
1429         [BlackBerry] Cannot touch scroll readonly text input.
1430         https://bugs.webkit.org/show_bug.cgi?id=115378
1431
1432         Reviewed by Rob Buis.
1433
1434         PR #332902
1435         Reviewed Internally by Mike Fenton.
1436         Node::rendererIsEditable() returns false if the input element has the readonly tag set.
1437         Check the node type instead.
1438
1439         * WebKitSupport/DOMSupport.cpp:
1440         (BlackBerry::WebKit::DOMSupport::isShadowHostTextInputElement):
1441         (DOMSupport):
1442         * WebKitSupport/DOMSupport.h:
1443         * WebKitSupport/InRegionScrollableArea.cpp:
1444         (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
1445
1446 2013-04-29  Jakob Petsovits  <jpetsovits@blackberry.com>
1447
1448         [BlackBerry] Replace disappearing fillBuffer() API with graphics context drawing
1449         https://bugs.webkit.org/show_bug.cgi?id=115360
1450         Internal PR 303048.
1451
1452         Reviewed by Rob Buis.
1453
1454         Instead of using fillBuffer() to draw directly to the
1455         target buffer, we now lock a Drawable on it and fill it
1456         with PlatformGraphicsContext::addPredefinedPattern().
1457
1458         As a bonus, this also includes related clean-ups -
1459         simpler checkerboard painting code, removal of
1460         fillWindow(), clearWindow() and paintDefaultBackground(),
1461         as well as getting rid of the DEBUG_CHECKERBOARD define
1462         which has been useless for performance tracing purposes
1463         for a while now.
1464
1465         * Api/BackingStore.cpp:
1466         (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
1467         * Api/BackingStore_p.h:
1468
1469 2013-04-26  Nima Ghanavatian  <nghanavatian@blackberry.com>
1470
1471         [BlackBerry] Check for valid element in elementTouched
1472         https://bugs.webkit.org/show_bug.cgi?id=115205
1473
1474         Reviewed by Rob Buis.
1475
1476         Internally reviewed by Genevieve Mak.
1477
1478         PR 331546
1479         We might receive a null ptr from nodeAsElementIfApplicable which
1480         is passed in here. Check to make sure it's valid before using.
1481
1482         * WebKitSupport/InputHandler.cpp:
1483         (BlackBerry::WebKit::InputHandler::elementTouched):
1484
1485 2013-04-26  Martin Robinson  <mrobinson@igalia.com>
1486
1487         Remove the remaining Skia #ifdefs
1488         https://bugs.webkit.org/show_bug.cgi?id=114886
1489
1490         Reviewed by Benjamin Poulain.
1491
1492         * Api/WebPage.cpp: Remove Skia #ifdef references.
1493         * WebCoreSupport/AboutDataUseFeatures.in: Ditto.
1494
1495 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
1496
1497         [BlackBerry] Should check if it's cached resource before download
1498         https://bugs.webkit.org/show_bug.cgi?id=115101
1499
1500         Reviewed by Rob Buis.
1501
1502         Since main resource maybe cached, if user want to save the resource, we first check
1503         if it's cached. If yes, don't need to initiate a fresh load again, but get the
1504         cached resource data out to save.
1505
1506         RIM bug# 324003, internally reviewed by Charles Wei.
1507
1508         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1509         (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
1510
1511 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
1512
1513         [BlackBerry] Clean up load interface in WebPage
1514         https://bugs.webkit.org/show_bug.cgi?id=113267
1515
1516         Reviewed by Rob Buis.
1517
1518         Remove unused loadExtended(), combine load() and download() api in WebPage.
1519         RIM Bug# 315535, internally reviewed by Joe Mason.
1520
1521         * Api/WebPage.cpp:
1522         (BlackBerry::WebKit::WebPage::load):
1523         * Api/WebPage.h:
1524
1525 2013-04-25  Andrew Lo  <anlo@rim.com>
1526
1527         [BlackBerry] Selection overlay on non-composited iframes are incorrectly positioned.
1528         https://bugs.webkit.org/show_bug.cgi?id=115197
1529
1530         Reviewed by Rob Buis.
1531
1532         When drawing the selection overlay, the rects to
1533         paint when selecting text on non-composited sub-frames
1534         need to be adjusted by the frame position.
1535
1536         * WebKitSupport/SelectionOverlay.cpp:
1537         (BlackBerry::WebKit::SelectionOverlay::paintContents):
1538
1539 2013-04-25  Andreas Kling  <akling@apple.com>
1540
1541         Remove ENABLE(PARSED_STYLE_SHEET_CACHING) and make it always-on.
1542
1543         Rubber-stamped by Anders Koivisto.
1544
1545         * WebCoreSupport/AboutDataEnableFeatures.in:
1546
1547 2013-04-25  Iris Wu  <shuwu@blackberry.com>
1548
1549         [BlackBerry] Make scroll position adjustment work with pages with fixed position elements.
1550         https://bugs.webkit.org/show_bug.cgi?id=115178
1551
1552         Reviewed by Rob Buis.
1553
1554         PR 308796
1555
1556         Currently the position WebPage::adjustDocumentScrollPosition adjusts is the top
1557         left point of the viewport.
1558         On the page with fixed position elements, we want it to adjust the position beneath
1559         the fixed elements so it can be always visible.
1560
1561         The basic idea is:
1562         1.  Detect if there are fixed position elements before going through ProximityDetector.
1563         2.  If the fixed element exists, calculate its the size and the actual visible position
1564             beneath it.
1565         3.  Pass the position to ProximityDetector. Then according to the new position we get,
1566             calculate the top left position of the viewport (final scroll position).
1567
1568         * Api/WebPage.cpp:
1569         (BlackBerry::WebKit::WebPage::fixedElementSizeDelta):
1570         (WebKit):
1571         * Api/WebPage.h:
1572         * Api/WebPageCompositor.cpp:
1573         (BlackBerry::WebKit::WebPageCompositorPrivate::findFixedElementRect):
1574         (WebKit):
1575         * Api/WebPageCompositor_p.h:
1576         (WebPageCompositorPrivate):
1577
1578 2013-04-25  Mike Lattanzio  <mlattanzio@blackberry.com>
1579
1580         [BlackBerry] Enable balanced page group load deferrer behaviour.
1581         https://bugs.webkit.org/show_bug.cgi?id=115189
1582
1583         Reviewed by Rob Buis.
1584
1585         Prevent a possible deadlock by enabling balanced deferrers.
1586         Internally reviewed by: Joe Mason
1587         PR 329986
1588
1589         * Api/WebPage.cpp:
1590         (BlackBerry::WebKit::WebPagePrivate::init):
1591
1592 2013-04-25  Joseph Pecoraro  <pecoraro@apple.com>
1593
1594         Web Inspector: ConsoleMessage should include line and column number where possible
1595         https://bugs.webkit.org/show_bug.cgi?id=114929
1596
1597         Reviewed by Timothy Hatcher.
1598
1599         * Api/DumpRenderTreeClient.h:
1600         * Api/WebPageClient.h:
1601         * WebCoreSupport/ChromeClientBlackBerry.cpp:
1602         (WebCore::ChromeClientBlackBerry::addMessageToConsole):
1603         * WebCoreSupport/ChromeClientBlackBerry.h:
1604         (ChromeClientBlackBerry):
1605
1606 2013-04-25  Konrad Piascik  <kpiascik@blackberry.com>
1607
1608         [BlackBerry] Get rid of return in void method
1609         https://bugs.webkit.org/show_bug.cgi?id=115186
1610
1611         Reviewed by Rob Buis.
1612
1613         * Api/WebPage.cpp:
1614         (BlackBerry::WebKit::WebPage::setForcedTextEncoding):
1615
1616 2013-04-24  Nima Ghanavatian  <nghanavatian@blackberry.com>
1617
1618         [BlackBerry] Do not clear focus on a node when tapping on form controls
1619         https://bugs.webkit.org/show_bug.cgi?id=115055
1620
1621         Reviewed by Rob Buis.
1622
1623         Internally reviewed by Genevieve Mak.
1624
1625         PR316069
1626         To allow for rich text editors to apply styles on an input field
1627         or highlighted text, we must maintain focus on the current element
1628         when tapping on form elements. Moving the code that clears this
1629         context to trigger off TouchHold instead of TouchPress.
1630
1631         * WebKitSupport/TouchEventHandler.cpp:
1632         (BlackBerry::WebKit::TouchEventHandler::doFatFingers):
1633
1634 == Rolled over to ChangeLog-2013-04-24 ==