[BlackBerry] Clear supression flag when caret changes aren't propogated through
[WebKit-https.git] / Source / WebKit / blackberry / ChangeLog
1 2013-05-27  Nima Ghanavatian  <nghanavatian@blackberry.com>
2
3         [BlackBerry] Clear supression flag when caret changes aren't propogated through
4         https://bugs.webkit.org/show_bug.cgi?id=116840
5
6         Reviewed by Rob Buis.
7
8         Internally reviewed by Mike Fenton.
9
10         PR339965
11         We set and clear the flag upon every use. This leaves us vulnerable if
12         1. midway through processing the selection change event is dismissed and
13         2. we don't receive a TouchRelease event
14         One example of this is while dragging the FCC handle we start typing. To
15         safeguard against this, if the process change guard is set during a
16         selection change event, we send out to clear the flag status before returning.
17
18         * Api/WebPageClient.h:
19         * WebKitSupport/InputHandler.cpp:
20         (BlackBerry::WebKit::InputHandler::selectionChanged):
21
22 2013-05-27  Andy Chen  <andchen@blackberry.com>
23
24         [BlackBerry] Find-on-page should be able to convert the active match to selection when clearing all matches
25         https://bugs.webkit.org/show_bug.cgi?id=116837
26
27         Reviewed by Rob Buis.
28
29         PR 291903
30         Internally reviewed by Mike Fenton.
31
32         * Api/WebPage.cpp:
33         (BlackBerry::WebKit::WebPage::findNextString):
34         * Api/WebPage.h:
35         * WebKitSupport/InPageSearchManager.cpp:
36         (BlackBerry::WebKit::InPageSearchManager::findNextString):
37         (BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
38         * WebKitSupport/InPageSearchManager.h:
39         (InPageSearchManager):
40
41 2013-05-27  Eli Fidler  <efidler@rim.com>
42
43         [BlackBerry] Fix subframe target added to new requests
44         https://bugs.webkit.org/show_bug.cgi?id=116602
45
46         Reviewed by Rob Buis.
47
48         In some cases we might be adding TargetIsMainFrame to a subframe
49         request causing an isMainFrame assert.
50
51         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
52         (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
53         Check we are actually loading the main frame before setting
54         ResourceRequest::TargetIsMainFrame target.
55
56 2013-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
57
58         [BlackBerry] REGRESSION(r150071): Animation performance issues in some websites with CSS transforms
59         https://bugs.webkit.org/show_bug.cgi?id=116724
60
61         Reviewed by Rob Buis.
62
63         Add another bool variable m_previousFrameDone to make sure we
64         don't start a new frame until the previous one has been done. Also
65         make sure we pass the animation start time to
66         serviceScriptedAnimations().
67
68         * Api/WebPage.cpp:
69         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Initialize
70         m_previousFrameDone and m_monotonicAnimationStartTime.
71         (BlackBerry::WebKit::WebPagePrivate::animationFrameChanged):
72         Return early if previous frame is not done. Otherwise set
73         m_previousFrameDone to false and save the animation start time.
74         (BlackBerry::WebKit::WebPagePrivate::serviceAnimations): Call
75         serviceScriptedAnimations() passing the saved animation start time
76         and reset m_animationScheduled and m_previousFrameDone.
77         (BlackBerry::WebKit::WebPagePrivate::handleServiceScriptedAnimationsOnMainThread):
78         Call WebPagePrivate::serviceAnimations().
79         * Api/WebPage_p.h:
80         (WebPagePrivate):
81
82 2013-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
83
84         [BlackBerry] Remove encoding parameter from FrameLoaderClientBlackBerry::receivedData()
85         https://bugs.webkit.org/show_bug.cgi?id=116598
86
87         Reviewed by Rob Buis.
88
89         It's no longer needed since the encoder now checks the override encoding.
90
91         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
92         (WebCore::FrameLoaderClientBlackBerry::committedLoad): Call
93         receivedData() passing the DocumentLoader instead of the text
94         encoding.
95         (WebCore::FrameLoaderClientBlackBerry::receivedData): Call
96         DocumentLoader::commitData() directly.
97         * WebCoreSupport/FrameLoaderClientBlackBerry.h:
98         (FrameLoaderClientBlackBerry):
99
100 2013-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
101
102         [BlackBerry] Move PagePopup implementation to WebKitSupport
103         https://bugs.webkit.org/show_bug.cgi?id=116824
104
105         Reviewed by Rob Buis.
106
107         After r150434 PagePopup implementation in BlackBerry port is
108         independent from WebCore. The classes are now in the
109         BlackBerry::WebKit namespace so they can be moved from
110         WebCoresupport to WebKitSupport and renamed to remove the
111         BlackBerry suffix which is now redundant. Also, now that the
112         implementation is not shared, it can be simplified a bit more.
113
114         * Api/WebPage.cpp:
115         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Update to
116         API changes.
117         (BlackBerry::WebKit::WebPage::initPopupWebView): Ditto.
118         (BlackBerry::WebKit::WebPagePrivate::openPagePopup): Ditto.
119         (BlackBerry::WebKit::WebPagePrivate::closePagePopup): Ditto.
120         (BlackBerry::WebKit::WebPagePrivate::hasOpenedPopup): Ditto.
121         * Api/WebPage.h:
122         (WebKit): Ditto.
123         * Api/WebPage_p.h:
124         (WebKit): Ditto.
125         (WebPagePrivate): Rename m_selectPopup as m_pagePopup, since it
126         can also point to a color picker or date picker page popup. Also
127         use RefPtr instead of raw pointer.
128         * WebKitSupport/ColorPickerClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp.
129         (BlackBerry::WebKit::ColorPickerClient::ColorPickerClient):
130         (BlackBerry::WebKit::ColorPickerClient::generateHTML):
131         (BlackBerry::WebKit::ColorPickerClient::setValueAndClosePopup):
132         Return early if popup has been closed already.
133         (BlackBerry::WebKit::ColorPickerClient::didClosePopup):
134         * WebKitSupport/ColorPickerClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.h.
135         * WebKitSupport/DatePickerClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp.
136         (BlackBerry::WebKit::DatePickerClient::DatePickerClient):
137         (BlackBerry::WebKit::DatePickerClient::~DatePickerClient):
138         (BlackBerry::WebKit::DatePickerClient::generateHTML):
139         (BlackBerry::WebKit::DatePickerClient::setValueAndClosePopup):
140         Return early if popup has been closed already.
141         (BlackBerry::WebKit::DatePickerClient::didClosePopup):
142         (BlackBerry::WebKit::DatePickerClient::generateDateLabels):
143         * WebKitSupport/DatePickerClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.h.
144         * WebKitSupport/PagePopup.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.cpp.
145         (BlackBerry::WebKit::PagePopup::PagePopup):
146         (BlackBerry::WebKit::PagePopup::~PagePopup):
147         (BlackBerry::WebKit::PagePopup::initialize): Renamed as initialize
148         and made void, since it always returned true and the callers
149         ignored the return value.
150         (BlackBerry::WebKit::PagePopup::writeDocument): Renamed from
151         generateHTML for consistency with PagePopupClient::writeDocument()
152         and to avoid confusion with generateHTML method in the clients
153         that create the HTML contents but they don't write the document.
154         (BlackBerry::WebKit::PagePopup::setValueAndClosePopupCallback):
155         Make it static member of PagePopup since the JS object now holds a
156         reference of PagePopup instance as private data.
157         (BlackBerry::WebKit::popUpExtensionInitialize): Take a reference
158         of the PagePopup instance saved as private data of the JS object.
159         (BlackBerry::WebKit::popUpExtensionFinalize): Unref the PagePopup
160         instance saved as private data of the JS object.
161         (BlackBerry::WebKit::PagePopup::installDOMFunction): Instead of
162         saving the client as private data of the JS object using a wrapper
163         refcounted object, save the PagePopup instance that is now
164         refcounted and access the client from the PagePopup instance in
165         the callback.
166         (BlackBerry::WebKit::PagePopup::close): Renamed from closePagePopup
167         since PagePopup::closePagePopup was a bit redundant.
168         * WebKitSupport/PagePopup.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.h.
169         (BlackBerry::WebKit::PagePopup::create): Static member to create
170         instances of PagePopup now that it's refcounted.
171         * WebKitSupport/PagePopupClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerryClient.cpp.
172         (BlackBerry::WebKit::PagePopupClient::PagePopupClient):
173         (BlackBerry::WebKit::PagePopupClient::closePopup):
174         (BlackBerry::WebKit::PagePopupClient::didClosePopup):
175         (BlackBerry::WebKit::PagePopupClient::contentSize):
176         (BlackBerry::WebKit::PagePopupClient::writeDocument):
177         * WebKitSupport/PagePopupClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerryClient.h.
178         * WebKitSupport/SelectPopupClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp.
179         (BlackBerry::WebKit::SelectPopupClient::SelectPopupClient):
180         (BlackBerry::WebKit::SelectPopupClient::~SelectPopupClient):
181         (BlackBerry::WebKit::SelectPopupClient::generateHTML):
182         (BlackBerry::WebKit::SelectPopupClient::setValueAndClosePopup):
183         Return early if popup has been closed already.
184         (BlackBerry::WebKit::SelectPopupClient::didClosePopup):
185         (BlackBerry::WebKit::SelectPopupClient::notifySelectionChange):
186         * WebKitSupport/SelectPopupClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.h.
187
188 2013-05-26  Jakob Petsovits  <jpetsovits@blackberry.com>
189
190         [BlackBerry] Make screen updates dependent on the existence of a drawing buffer.
191         https://bugs.webkit.org/show_bug.cgi?id=116539
192         Internal PR 330917
193
194         Reviewed by Carlos Garcia Campos.
195         Internally reviewed by Xiaobo Wang and Arvid Nilsson.
196
197         This reduces complexity by relying on the current state,
198         rather than the suspend counter, which in turn makes it
199         possible to simplify the code in setCompositor().
200
201         * Api/BackingStore.cpp:
202         (BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
203         (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
204         * Api/WebPage.cpp:
205         (BlackBerry::WebKit::WebPagePrivate::setCompositor):
206
207 2013-05-26  Kent Tamura  <tkent@chromium.org>
208
209         Remove ENABLE_CALENDAR_PICKER
210         https://bugs.webkit.org/show_bug.cgi?id=116795
211
212         Reviewed by Ryosuke Niwa.
213
214         * WebCoreSupport/AboutDataEnableFeatures.in:
215         The list was wrong. Blackberry port doesn't use CALENDAR_PICKER code.
216
217 2013-05-26  Andreas Kling  <akling@apple.com>
218
219         FocusController::setFocusedNode() should be setFocusedElement().
220         <http://webkit.org/b/116780>
221
222         Reviewed by Antti Koivisto.
223
224         * Api/WebPage.cpp:
225         (BlackBerry::WebKit::WebPagePrivate::clearFocusNode):
226         (BlackBerry::WebKit::WebPage::setNodeFocus):
227         * WebKitSupport/SelectionHandler.cpp:
228         (BlackBerry::WebKit::SelectionHandler::selectObject):
229
230 2013-05-24  Anders Carlsson  <andersca@apple.com>
231
232         Remove PagePopup code
233         https://bugs.webkit.org/show_bug.cgi?id=116732
234
235         Reviewed by Andreas Kling.
236
237         * WebCoreSupport/AboutDataEnableFeatures.in:
238         Remove PAGE_POPUP.
239
240 2013-05-24  Mike Fenton  <mifenton@rim.com>
241
242         [BlackBerry] Fix bad type warning in InputHandler log.
243         https://bugs.webkit.org/show_bug.cgi?id=116720
244
245         Reviewed by Carlos Garcia Campos.
246
247         Fix warning in inputLog string.
248
249         * WebKitSupport/InputHandler.cpp:
250         (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
251
252 2013-05-24  Mike Fenton  <mifenton@rim.com>
253
254         [BlackBerry] Respect tabindex when using form controls.
255         https://bugs.webkit.org/show_bug.cgi?id=116676
256
257         Reviewed by Xan Lopez.
258
259         PR 337419.
260
261         Update form control navigation tracking to take tabindex
262         order into account when calculating next and previous nodes.
263
264         The order to follow is tab index 1 - N, followed by all items
265         without a tab index or tab index 0 in rendering order to match
266         with standard desktop behavior.
267
268         Internally Reviewed by Genevieve Mak and Nima Ghanavatian.
269
270         * WebKitSupport/InputHandler.cpp:
271         (BlackBerry::WebKit::InputHandler::updateFormState):
272
273 2013-05-24  Jeff Rogers  <jrogers@rim.com>
274
275         [BlackBerry] Remove SKIA leftovers from WebPage.cpp
276         https://bugs.webkit.org/show_bug.cgi?id=116656
277
278         Reviewed by Rob Buis.
279
280         * Api/WebPage.cpp:
281         (BlackBerry::WebKit::WebPagePrivate::setLoadState):
282
283 2013-05-23  Xiaobo Wang  <xiaobwang@blackberry.com>
284
285         [BlackBerry] Need to suspend/resume RootLayerCommit when the application becomes inactive/active
286         https://bugs.webkit.org/show_bug.cgi?id=115245
287
288         Reviewed by Rob Buis.
289
290         PR 330917.
291         Internally reviewed by Arvid Nilsson.
292
293         1. Suspend/resumeRootLayerCommit when notified app activation state
294         change.
295         2. Schedule root layer commit in resumeRootLayerCommit() to explicitly
296         start root layer commit timer, so that there's a commit even if
297         BackingStore got disabled/removed.
298
299         * Api/WebPage.cpp:
300         (BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
301         (BlackBerry::WebKit::WebPagePrivate::resumeRootLayerCommit):
302
303 2013-05-23  Andy Chen  <andchen@blackberry.com>
304
305         [BlackBerry] Need to forward the opener frame url to client when creating a new window
306         https://bugs.webkit.org/show_bug.cgi?id=116566
307
308         Reviewed by Rob Buis.
309
310         PR 337935
311         Internally reviewed by Arvid Nilsson.
312         When creating a new window, forward the opener frame url to client.
313
314         * Api/WebPageClient.h:
315         * WebCoreSupport/ChromeClientBlackBerry.cpp:
316         (WebCore::ChromeClientBlackBerry::createWindow):
317         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
318         (WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
319
320 2013-05-23  Jakob Petsovits  <jpetsovits@blackberry.com>
321
322         [BlackBerry] Compositor API change: Don't pass the unused "viewport" parameter.
323         https://bugs.webkit.org/show_bug.cgi?id=116545
324         Internal PR 189775
325
326         Reviewed by Rob Buis.
327
328         Also change the name of the "documentContents" parameter
329         to the more descriptive "documentSrcRect".
330
331         * Api/WebPageCompositor.cpp:
332         (BlackBerry::WebKit::WebPageCompositorPrivate::render):
333         (BlackBerry::WebKit::WebPageCompositor::render):
334         * Api/WebPageCompositor.h:
335         * Api/WebPageCompositor_p.h:
336         (WebPageCompositorPrivate):
337
338 2013-05-23  Ed Baker  <edbaker@blackberry.com>
339
340         [BlackBerry] The web context does not contain any link properties if the context node is an image enclosed by a link node
341         https://bugs.webkit.org/show_bug.cgi?id=116627
342
343         Reviewed by Xan Lopez.
344
345         PR #341084
346
347         If the context node has an image tag and an enclosing link node was detected then add the link properties to the context.
348
349         Internally Reviewed by Gen Mak.
350
351         * Api/WebPage.cpp:
352         (BlackBerry::WebKit::WebPagePrivate::webContext):
353
354 2013-05-23  Mike Fenton  <mifenton@rim.com>
355
356         [BlackBerry] Validate form data before doing direct submission.
357         https://bugs.webkit.org/show_bug.cgi?id=116674
358
359         Reviewed by Xan Lopez.
360
361         PR 314202.
362
363         Check validation of the input form before triggering direct submission.
364
365         Internally Reviewed by Nima Ghanavatian.
366
367         * WebKitSupport/InputHandler.cpp:
368         (BlackBerry::WebKit::InputHandler::submitForm):
369
370 2013-05-23  Rob Buis  <rbuis@rim.com>
371
372         [BlackBerry] Properly fill the ResourceError in FrameLoaderClientBlackBerry::cannotShowURLError
373         https://bugs.webkit.org/show_bug.cgi?id=116603
374
375         Reviewed by Xan Lopez.
376
377         PR 119789
378         Internally reviewed by Yong Li.
379
380         Provide a domain value for this ResourceError instance. Note that
381         this does not change behavior.
382
383         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
384         (WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):
385
386 2013-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
387
388         [BlackBerry] Make PagePopup implementation independent from WebCore
389         https://bugs.webkit.org/show_bug.cgi?id=116448
390
391         Reviewed by Anders Carlsson.
392
393         Add our own implementation of PagePopupClient and make all the
394         pickers inherit from it. Unused methods have been removed and
395         common implementation have been moved from the pickers to the
396         parent class.
397
398         * Api/WebPage.cpp:
399         (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate): Destroy the
400         popup if there's one active.
401         (BlackBerry::WebKit::WebPagePrivate::setVisible): Call
402         closePagePopup() directly.
403         (BlackBerry::WebKit::WebPagePrivate::openPagePopup): Create a new
404         PagePopupBlackBerry for the given client.
405         (BlackBerry::WebKit::WebPagePrivate::closePagePopup): Close the
406         active popup if there's one.
407         (BlackBerry::WebKit::WebPagePrivate::hasOpenedPopup): Return
408         whether there's an active popup.
409         * Api/WebPage.h:
410         * Api/WebPage_p.h:
411         * WebCoreSupport/ChromeClientBlackBerry.cpp:
412         (WebCore::ChromeClientBlackBerry::chromeDestroyed): Remove
413         closePagePopup() call since this is now handled by
414         WebPagePrivate.
415         (WebCore::ChromeClientBlackBerry::hasOpenedPopup): Call
416         WebPagePrivate::hasOpenedPopup().
417         * WebCoreSupport/ChromeClientBlackBerry.h:
418         (ChromeClientBlackBerry):
419         * WebCoreSupport/ColorPickerClient.cpp:
420         (BlackBerry::WebKit::ColorPickerClient::ColorPickerClient):
421         (BlackBerry::WebKit::ColorPickerClient::didClosePopup):
422         * WebCoreSupport/ColorPickerClient.h:
423         (ColorPickerClient):
424         * WebCoreSupport/DatePickerClient.cpp:
425         (BlackBerry::WebKit::DatePickerClient::DatePickerClient):
426         (BlackBerry::WebKit::DatePickerClient::didClosePopup):
427         * WebCoreSupport/DatePickerClient.h:
428         (DatePickerClient):
429         * WebCoreSupport/PagePopupBlackBerry.cpp:
430         (BlackBerry::WebKit::PagePopupBlackBerry::PagePopupBlackBerry):
431         (BlackBerry::WebKit::PagePopupBlackBerry::closePopup):
432         * WebCoreSupport/PagePopupBlackBerry.h:
433         (PagePopupBlackBerry):
434         (BlackBerry::WebKit::PagePopupBlackBerry::SharedClientPointer::SharedClientPointer):
435         (BlackBerry::WebKit::PagePopupBlackBerry::SharedClientPointer::get):
436         (SharedClientPointer):
437         * WebCoreSupport/PagePopupBlackBerryClient.cpp: Added.
438         (BlackBerry::WebKit::PagePopupBlackBerryClient::PagePopupBlackBerryClient):
439         (BlackBerry::WebKit::PagePopupBlackBerryClient::closePopup):
440         (BlackBerry::WebKit::PagePopupBlackBerryClient::didClosePopup):
441         (BlackBerry::WebKit::PagePopupBlackBerryClient::contentSize):
442         (BlackBerry::WebKit::PagePopupBlackBerryClient::writeDocument):
443         * WebCoreSupport/PagePopupBlackBerryClient.h: Added.
444         (PagePopupBlackBerryClient):
445         (BlackBerry::WebKit::PagePopupBlackBerryClient::~PagePopupBlackBerryClient):
446         * WebCoreSupport/SelectPopupClient.cpp:
447         (BlackBerry::WebKit::SelectPopupClient::SelectPopupClient):
448         (BlackBerry::WebKit::SelectPopupClient::didClosePopup):
449         * WebCoreSupport/SelectPopupClient.h:
450         (SelectPopupClient):
451         * WebKitSupport/InputHandler.cpp:
452         (BlackBerry::WebKit::InputHandler::openDatePopup): Do not call
453         closePagePopup() since this is already done by openPagePopup() and
454         use openPagePopup() from WebPagePrivate directly.
455         (BlackBerry::WebKit::InputHandler::openColorPopup): Ditto.
456         (BlackBerry::WebKit::InputHandler::openSelectPopup): Ditto.
457
458 2013-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
459
460         [BlackBerry] Do not use skia in FrameLoaderClientBlackBerry::dispatchDidReceiveIcon()
461         https://bugs.webkit.org/show_bug.cgi?id=116302
462
463         Reviewed by Rob Buis.
464
465         TiledImage is now the NativeImage of the BlackBerry port.
466
467         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
468         (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
469
470 2013-05-19  Anders Carlsson  <andersca@apple.com>
471
472         Remove link prerendering code
473         https://bugs.webkit.org/show_bug.cgi?id=116415
474
475         Reviewed by Darin Adler.
476
477         This code was only used by Chromium and is dead now.
478
479         * WebCoreSupport/AboutDataEnableFeatures.in:
480
481 2013-05-19  Anders Carlsson  <andersca@apple.com>
482
483         Remove ChromeClient::webView()
484         https://bugs.webkit.org/show_bug.cgi?id=116054
485
486         Reviewed by Andreas Kling.
487
488         This blatantly horrible layer violation was only used by the Chromium port; get rid of it.
489
490         * WebCoreSupport/ChromeClientBlackBerry.h:
491         (ChromeClientBlackBerry):
492
493 2013-05-17  Carlos Garcia Campos  <cgarcia@igalia.com>
494
495         [BlackBerry] REGRESSION(r150060): Crash in LayerWebKitThread::updateTextureContents
496         https://bugs.webkit.org/show_bug.cgi?id=116305
497
498         Reviewed by Rob Buis.
499
500         PR 340537.
501         Internally reviewed by Arvid Nilsson.
502
503         Use updateLayoutAndStyleIfNeededRecursive() instead of
504         layoutIfNeeded() since we are about to draw in
505         rootLayerCommitTimerFired().
506
507         * Api/WebPage.cpp:
508         (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
509
510 2013-05-17  Mike Fenton  <mifenton@rim.com>
511
512         [BlackBerry] Remove stale comment for select mouse handling.
513         https://bugs.webkit.org/show_bug.cgi?id=116309
514
515         Reviewed by Rob Buis.
516
517         PR 135935.
518
519         Remove a FIXME that has been invalidated by a change
520         to our touch -> mouse model.
521
522         Internally Rubberstamped by Genevieve Mak.
523
524         * Api/WebPage.cpp:
525         (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
526
527 2013-05-17  Alberto Garcia  <agarcia@igalia.com>
528
529         [BlackBerry] DumpRenderTreeSupport: fix build in setMockDeviceOrientation()
530         https://bugs.webkit.org/show_bug.cgi?id=116298
531
532         Reviewed by Carlos Garcia Campos.
533
534         Pass the correct parameter to toDeviceOrientationClientMock()
535
536         * WebKitSupport/DumpRenderTreeSupport.cpp:
537         (DumpRenderTreeSupport::setMockDeviceOrientation):
538
539 2013-05-16  Mike Fenton  <mifenton@rim.com>
540
541         [BlackBerry] Optimize caret bounds calculation when leaving an input field.
542         https://bugs.webkit.org/show_bug.cgi?id=116224
543
544         Reviewed by Rob Buis.
545
546         PR 340132.
547
548         If the caret is no longer active in the field, do not allow it
549         to go into the single line input logic and calculate the node
550         bounding box.
551
552         Internally Reviewed By Gen Mak
553
554         * WebKitSupport/SelectionHandler.cpp:
555         (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
556
557 2013-05-16  Mary Wu  <mary.wu@torchmobile.com.cn>
558
559         [BlackBerry] Unable to download blob resource
560         https://bugs.webkit.org/show_bug.cgi?id=115888
561
562         Reviewed by Benjamin Poulain.
563
564         For blob resource (blob:http....), it's not suitable to go to NetworkStream
565         which don't handle "blob" protocol at all. since blob data already handled
566         in BlobResourceHandle, simply get the data out to download stream.
567
568         RIM bug 331086, internally reviewed by Charles Wei and Leo Yang.
569
570         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
571         (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
572
573 2013-05-16  Andreas Kling  <akling@apple.com>
574
575         Page::chrome() should return a reference.
576         <http://webkit.org/b/116185>
577
578         Reviewed by Anders Carlsson.
579
580 2013-05-13  Anders Carlsson  <andersca@apple.com>
581
582         Frame::editor() should return a reference
583         https://bugs.webkit.org/show_bug.cgi?id=116037
584
585         Reviewed by Darin Adler.
586
587         * WebCoreSupport/EditorClientBlackBerry.cpp:
588         (WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
589         (WebCore::EditorClientBlackBerry::handleKeyboardEvent):
590         * WebKitSupport/DOMSupport.cpp:
591         (BlackBerry::WebKit::DOMSupport::elementHasContinuousSpellCheckingEnabled):
592         * WebKitSupport/InPageSearchManager.cpp:
593         (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
594         (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
595         * WebKitSupport/SelectionHandler.cpp:
596         (BlackBerry::WebKit::SelectionHandler::selectedText):
597
598 2013-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
599
600         Remove WTF_USE_PLATFORM_STRATEGIES
601         https://bugs.webkit.org/show_bug.cgi?id=114431
602
603         Reviewed by Darin Adler.
604
605         * WebCoreSupport/AboutDataUseFeatures.in:
606
607 2013-05-14  Tiancheng Jiang  <tijiang@rim.com>
608
609         [BlackBerry] Improve Fatfinger phase.
610         https://bugs.webkit.org/show_bug.cgi?id=107403
611
612         Reviewed by Rob Buis.
613
614         Internally reviewed by Genevieve Mak.
615         BlackBerry PR 324965.
616
617         Cache and reuse intersected nodes as long as hit position has not been
618         changed.
619
620         * Api/WebPage.cpp:
621         (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
622         * Api/WebPage_p.h:
623         (WebPagePrivate):
624         * WebKitSupport/FatFingers.cpp:
625         (BlackBerry::WebKit::FatFingers::findBestPoint):
626         (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
627         (BlackBerry::WebKit::FatFingers::getNodesFromRect):
628         * WebKitSupport/FatFingers.h:
629
630 2013-05-14  Andrew Lo  <anlo@rim.com>
631
632         [BlackBerry] Hook up frame render begin/end in PerformanceMonitor
633         https://bugs.webkit.org/show_bug.cgi?id=116110
634
635         Reviewed by Rob Buis.
636
637         Internally reviewed by Jeff Rogers, Jonathan Jiang.
638         Internal PR 299155.
639
640         Mark frame render begin & end for BlackBerry performance monitoring
641         in blitVisibleContents.
642
643         * Api/BackingStore.cpp:
644         (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
645
646 2013-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
647
648         [BlackBerry] Use requestAnimationFrame for animations
649         https://bugs.webkit.org/show_bug.cgi?id=115896
650
651         Reviewed by Rob Buis.
652
653         Make WebPagePrivate a
654         BlackBerry::Platform::AnimationFrameRateClient and use it to
655         schedule animations.
656
657         * Api/WebPage.cpp:
658         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
659         (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
660         (WebKit):
661         (BlackBerry::WebKit::WebPagePrivate::animationFrameChanged):
662         (BlackBerry::WebKit::WebPagePrivate::scheduleAnimation):
663         (BlackBerry::WebKit::WebPagePrivate::startRefreshAnimationClient):
664         (BlackBerry::WebKit::WebPagePrivate::stopRefreshAnimationClient):
665         (BlackBerry::WebKit::WebPagePrivate::handleServiceScriptedAnimationsOnMainThread):
666         * Api/WebPage_p.h:
667         (WebPagePrivate):
668         * WebCoreSupport/ChromeClientBlackBerry.cpp:
669         (WebCore):
670         (WebCore::ChromeClientBlackBerry::scheduleAnimation):
671         * WebCoreSupport/ChromeClientBlackBerry.h:
672         (ChromeClientBlackBerry):
673
674 2013-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
675
676         [BlackBerry] Implement platform strategies
677         https://bugs.webkit.org/show_bug.cgi?id=112162
678
679         Reviewed by Rob Buis.
680
681         * Api/BlackBerryGlobal.cpp:
682         (BlackBerry::WebKit::globalInitialize): Initialize platform
683         strategies.
684         * WebCoreSupport/PlatformStrategiesBlackBerry.cpp: Added.
685         (PlatformStrategiesBlackBerry::initialize):
686         (PlatformStrategiesBlackBerry::PlatformStrategiesBlackBerry):
687         (PlatformStrategiesBlackBerry::createCookiesStrategy):
688         (PlatformStrategiesBlackBerry::createDatabaseStrategy):
689         (PlatformStrategiesBlackBerry::createLoaderStrategy):
690         (PlatformStrategiesBlackBerry::createPasteboardStrategy):
691         (PlatformStrategiesBlackBerry::createPluginStrategy):
692         (PlatformStrategiesBlackBerry::createSharedWorkerStrategy):
693         (PlatformStrategiesBlackBerry::createStorageStrategy):
694         (PlatformStrategiesBlackBerry::createVisitedLinkStrategy):
695         (PlatformStrategiesBlackBerry::cookiesForDOM):
696         (PlatformStrategiesBlackBerry::setCookiesFromDOM):
697         (PlatformStrategiesBlackBerry::cookiesEnabled):
698         (PlatformStrategiesBlackBerry::cookieRequestHeaderFieldValue):
699         (PlatformStrategiesBlackBerry::getRawCookies):
700         (PlatformStrategiesBlackBerry::deleteCookie):
701         (PlatformStrategiesBlackBerry::refreshPlugins):
702         (PlatformStrategiesBlackBerry::getPluginInfo):
703         (PlatformStrategiesBlackBerry::isLinkVisited):
704         (PlatformStrategiesBlackBerry::addVisitedLink):
705         * WebCoreSupport/PlatformStrategiesBlackBerry.h: Added.
706         (PlatformStrategiesBlackBerry):
707
708 2013-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
709
710         [BlackBerry] Crash due to an assert in FrameView::doDeferredRepaints
711         https://bugs.webkit.org/show_bug.cgi?id=115412
712
713         Reviewed by Rob Buis.
714
715         PR 115412
716
717         The problem is that we are calling
718         updateLayoutAndStyleIfNeededRecursive() (because of
719         zoomToInitialScaleOnLoad) from ChomeClient::layoutUpdated()
720         callback which is not expected. It's expected to be called right
721         before painting, and not right after painting. Even if a new
722         layout is not done, updateLayoutAndStyleIfNeededRecursive() calls
723         flushDeferredRepaints() and it's possible that this is called in
724         the middle of a beginDeferredRepaints() and endDeferredRepaints()
725         apparently.
726         In general only BackingStore should call
727         updateLayoutAndStyleIfNeededRecursive before painting, and a simple
728         layout is enough in all other cases like resizing. This patch renames
729         requestLayoutIfNeeded as updateLayoutAndStyleIfNeededRecursive to
730         make more obvious what it does, and adds layoutIfNeeded that calls
731         layout. The former is used by the BackingStore and the latter by
732         WebPage.
733
734         * Api/BackingStore.cpp:
735         (BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
736         (BlackBerry::WebKit::BackingStorePrivate::requestLayoutIfNeeded):
737         * Api/WebPage.cpp:
738         (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
739         (BlackBerry::WebKit::WebPagePrivate::updateLayoutAndStyleIfNeededRecursive):
740         (BlackBerry::WebKit::WebPagePrivate::layoutIfNeeded):
741         (WebKit):
742         (BlackBerry::WebKit::WebPagePrivate::overflowExceedsContentsSize):
743         (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
744         (BlackBerry::WebKit::WebPagePrivate::webContext):
745         (BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
746         (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
747         (BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
748         (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
749         * Api/WebPage_p.h:
750         (WebPagePrivate):
751
752 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
753
754         Remove USE(OS_RANDOMNESS)
755         https://bugs.webkit.org/show_bug.cgi?id=108095
756
757         Reviewed by Darin Adler.
758
759         Remove the USE(OS_RANDOMNESS) guard as it is turned on for all
760         ports.
761
762         * WebCoreSupport/AboutDataUseFeatures.in:
763
764 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
765
766         Fix some compiler warnings (miscellaneous)
767         https://bugs.webkit.org/show_bug.cgi?id=80790
768
769         Reviewed by Rob Buis.
770
771         Fix the following warnings for BlackBerry:
772         BackingStore.cpp:852:60: warning: suggest parentheses around '&&' within
773         '||' [-Wparentheses].
774         WebPage.cpp:2858:40: warning: suggest parentheses around assignment used
775         as truth value [-Wparentheses].
776         WebPage.cpp:2880:42: warning: suggest parentheses around assignment used
777         as truth value [-Wparentheses]
778
779         * Api/BackingStore.cpp:
780         (BlackBerry::WebKit::BackingStorePrivate::updateTilesAfterBackingStoreRectChange):
781         * Api/WebPage.cpp:
782         (BlackBerry::WebKit::WebPagePrivate::adjustRectOffsetForFrameOffset):
783         (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
784
785 2013-05-09  Mike Fenton  <mifenton@rim.com>
786
787         [BlackBerry] Style updates required based on new check-webkit-style
788         https://bugs.webkit.org/show_bug.cgi?id=115857
789
790         Reviewed by Rob Buis.
791
792         Update iInRegionScroller, WebKitTextCodec and WebPageCompositor
793         to match check-webkit-style updates.
794
795         * Api/InRegionScroller.cpp:
796         (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
797         * Api/InRegionScroller_p.h:
798         * Api/WebKitTextCodec.cpp:
799         (BlackBerry::WebKit::transcode):
800         * Api/WebPageCompositor.cpp:
801         (BlackBerry::WebKit::WebPageCompositor::render):
802         * Api/WebPageCompositor.h:
803         * Api/WebPageCompositor_p.h:
804         (WebPageCompositorPrivate):
805         * Api/WebSettings_p.h:
806
807 2013-05-09  Max Feil  <mfeil@rim.com>
808
809         shouldUsePluginDocument() needs to be respected when a document is created
810         https://bugs.webkit.org/show_bug.cgi?id=110308
811
812         Reviewed by Rob Buis.
813
814         This patch implements shouldAlwaysUsePluginDocument() in the
815         BlackBerry frame loader client. It is called in several places
816         within WebCore to determine whether a PluginDocument should
817         be created.
818
819         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
820         (WebCore::FrameLoaderClientBlackBerry::shouldAlwaysUsePluginDocument):
821         (WebCore):
822         (WebCore::FrameLoaderClientBlackBerry::createPlugin):
823         * WebCoreSupport/FrameLoaderClientBlackBerry.h:
824         (FrameLoaderClientBlackBerry):
825
826 2013-05-09  Mike Fenton <mifenton@rim.com>
827
828         [BlackBerry] Style updates required based on new check-webkit-style
829         https://bugs.webkit.org/show_bug.cgi?id=115857
830
831         Reviewed by Rob Buis.
832
833         Update SelectionHandler to match check-webkit-style updates.
834
835         * WebKitSupport/SelectionHandler.cpp:
836         (BlackBerry::WebKit::shouldExtendSelectionInDirection):
837         (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
838         (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
839         (BlackBerry::WebKit::adjustCaretRects):
840         (BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
841         (BlackBerry::WebKit::regionRectListContainsPoint):
842         * WebKitSupport/SelectionHandler.h:
843         (SelectionHandler):
844
845 2013-05-09  Mike Fenton  <mifenton@rim.com>
846
847         [BlackBerry] Style updates required based on new check-webkit-style
848         https://bugs.webkit.org/show_bug.cgi?id=115857
849
850         Reviewed by Rob Buis.
851
852         Update WebPage and WebPageClient to match check-webkit-style updates.
853
854         * Api/WebPage.cpp:
855         (BlackBerry::WebKit::WebPagePrivate::init):
856         (BlackBerry::WebKit::WebPage::executeJavaScriptInIsolatedWorld):
857         (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
858         (BlackBerry::WebKit::WebPagePrivate::calculateReflowedScrollPosition):
859         (BlackBerry::WebKit::WebPagePrivate::centerOfVisibleContentsRect):
860         (BlackBerry::WebKit::WebPage::assignFocus):
861         (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
862         (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
863         (BlackBerry::WebKit::WebPage::deleteTextRelativeToCursor):
864         (BlackBerry::WebKit::WebPage::addVisitedLink):
865         (BlackBerry::WebKit::WebPagePrivate::findPatternStringForUrl):
866         (BlackBerry::WebKit::WebPage::notifySwipeEvent):
867         (BlackBerry::WebKit::WebPage::notifyScreenPowerStateChanged):
868         (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
869         (BlackBerry::WebKit::WebPagePrivate::setRootLayerWebKitThread):
870         (BlackBerry::WebKit::WebPagePrivate::releaseLayerResourcesCompositingThread):
871         * Api/WebPageClient.h:
872         * Api/WebPage_p.h:
873
874 2013-05-09  Mike Fenton  <mifenton@rim.com>
875
876
877         [BlackBerry] Style updates required based on new check-webkit-style
878         https://bugs.webkit.org/show_bug.cgi?id=115857
879
880         Reviewed by Rob Buis.
881
882         Update BackingStore to match check-webkit-style updates.
883
884         Internally reviewed by Jakob Petsovits.
885
886         * Api/BackingStore.cpp:
887         (BlackBerry::WebKit::bestDivisor):
888         (BlackBerry::WebKit::BackingStorePrivate::repaint):
889         (BlackBerry::WebKit::BackingStorePrivate::shouldMoveLeft):
890         (BlackBerry::WebKit::BackingStorePrivate::shouldMoveRight):
891         (BlackBerry::WebKit::BackingStorePrivate::shouldMoveUp):
892         (BlackBerry::WebKit::BackingStorePrivate::shouldMoveDown):
893         (BlackBerry::WebKit::BackingStorePrivate::canMoveLeft):
894         (BlackBerry::WebKit::BackingStorePrivate::canMoveRight):
895         (BlackBerry::WebKit::BackingStorePrivate::canMoveUp):
896         (BlackBerry::WebKit::BackingStorePrivate::canMoveDown):
897         (BlackBerry::WebKit::BackingStorePrivate::indexOfTile):
898         (BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
899         (BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
900         (BlackBerry::WebKit::BackingStoreGeometry::originOfTile):
901         (BlackBerry::WebKit::BackingStore::repaint):
902         * Api/BackingStore_p.h:
903         (BackingStoreGeometry):
904
905 2013-05-09  Mike Fenton  <mifenton@rim.com>
906
907         [BlackBerry] Style updates required based on new check-webkit-style
908         https://bugs.webkit.org/show_bug.cgi?id=115857
909
910         Reviewed by Rob Buis.
911
912         Update ChromeClientBlackBerry, CredentialManager, FrameLoaderClientBlackBerry,
913         GeolocationClientBlackBerry and IconDatabaseClientBlackberry to
914         match check-webkit-style updates.
915
916         * WebCoreSupport/ChromeClientBlackBerry.h:
917         (ChromeClientBlackBerry):
918         * WebCoreSupport/CredentialManager.h:
919         (CredentialManager):
920         * WebCoreSupport/CredentialTransformData.cpp:
921         * WebCoreSupport/FrameLoaderClientBlackBerry.h:
922         (WebCore::FrameLoaderClientBlackBerry::assignIdentifierToInitialRequest):
923         (FrameLoaderClientBlackBerry):
924         (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveAuthenticationChallenge):
925         (WebCore::FrameLoaderClientBlackBerry::dispatchDidCancelAuthenticationChallenge):
926         (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveContentLength):
927         (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoading):
928         (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailLoading):
929         * WebCoreSupport/GeolocationClientBlackBerry.cpp:
930         (GeolocationClientBlackBerry::onLocationUpdate):
931         * WebCoreSupport/GeolocationClientBlackBerry.h:
932         (GeolocationClientBlackBerry):
933         * WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
934         (WebCore::IconDatabaseClientBlackBerry::initIconDatabase):
935
936 2013-05-09  Jacky Jiang  <zhajiang@blackberry.com>
937
938         Fix some compiler warnings (miscellaneous)
939         https://bugs.webkit.org/show_bug.cgi?id=80790
940
941         Reviewed by Rob Buis.
942
943         Fix the following warnings for BlackBerry:
944         InRegionScroller.cpp:286:39: warning: suggest parentheses around
945         assignment used as truth value [-Wparentheses].
946         InRegionScroller.cpp:349:39: warning: suggest parentheses around
947         assignment used as truth value [-Wparentheses].
948         InRegionScroller.cpp:456:82: warning: suggest parentheses around '&&'
949         within '||' [-Wparentheses].
950         InRegionScrollableArea.cpp:134:16: warning: suggest explicit braces to
951         avoid ambiguous 'else' [-Wparentheses].
952         SelectionHandler.cpp:390:109: warning: suggest parentheses around '&&'
953         within '||' [-Wparentheses].
954         SelectionOverlay.cpp:56:47: warning: comparison between signed and
955         unsigned integer expressions [-Wsign-compare].
956
957
958         * Api/InRegionScroller.cpp:
959         (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
960         (BlackBerry::WebKit::InRegionScrollerPrivate::firstScrollableInRegionForNode):
961         (BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
962         * WebKitSupport/InRegionScrollableArea.cpp:
963         (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
964         * WebKitSupport/SelectionHandler.cpp:
965         (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
966         * WebKitSupport/SelectionOverlay.cpp:
967         (BlackBerry::WebKit::SelectionOverlay::draw):
968
969 2013-05-09  Mike Fenton  <mifenton@rim.com>
970
971         [BlackBerry] Style updates required based on new check-webkit-style
972         https://bugs.webkit.org/show_bug.cgi?id=115857
973
974         Reviewed by Rob Buis.
975
976         Update ColorPickerClient and PagePopupBlackBerry
977         to match check-webkit-style updates.
978
979         * WebCoreSupport/ColorPickerClient.cpp:
980         (WebCore::ColorPickerClient::generateHTML):
981         * WebCoreSupport/PagePopupBlackBerry.cpp:
982         (WebCore::setValueAndClosePopupCallback):
983         (WebCore::PagePopupBlackBerry::installDOMFunction):
984
985 2013-05-09  Alberto Garcia  <agarcia@igalia.com>
986
987         [BlackBerry] Upstream the input popups
988         https://bugs.webkit.org/show_bug.cgi?id=114608
989
990         Reviewed by Rob Buis.
991
992         This patch contains contributions from many members of the
993         BlackBerry WebKit team, including:
994
995         Chris Hutten-Czapski
996         David Hoon
997         Jessica Cao
998         Rob Buis
999         Tiancheng Jiang
1000
1001         * WebCoreSupport/ColorPickerClient.cpp:
1002         (WebCore):
1003         (WebCore::ColorPickerClient::generateHTML):
1004         * WebCoreSupport/DatePickerClient.cpp:
1005         (WebCore):
1006         (WebCore::DatePickerClient::generateHTML):
1007         (WebCore::DatePickerClient::generateDateLabels):
1008         * WebCoreSupport/DatePickerClient.h:
1009         (DatePickerClient):
1010         * WebCoreSupport/SelectPopupClient.cpp:
1011         (WebCore):
1012         (WebCore::SelectPopupClient::generateHTML):
1013
1014 2013-05-09  Mike Fenton  <mifenton@rim.com>
1015
1016         [BlackBerry] Style updates required based on new check-webkit-style
1017         https://bugs.webkit.org/show_bug.cgi?id=115857
1018
1019         Reviewed by Rob Buis.
1020
1021         Update DOMSupport to match check-webkit-style updates.
1022
1023         * WebKitSupport/DOMSupport.cpp:
1024         (BlackBerry::WebKit::DOMSupport::isTextInputElement):
1025         (BlackBerry::WebKit::DOMSupport::isPasswordElement):
1026         (BlackBerry::WebKit::DOMSupport::convertPointToFrame):
1027
1028 2013-05-09  Xuefei Ren  <xren@blackberry.com>
1029
1030         [BLACKBERRY]fix regression in Webpage
1031         and FrameLoaderClientBlackberry
1032         https://bugs.webkit.org/show_bug.cgi?id=115843
1033
1034         Reviewed by Rob Buis.
1035
1036         Internally reviewed by Mary Wu.
1037
1038         * Api/WebPage.cpp:
1039         (BlackBerry::WebKit::WebPage::loadFile):
1040         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1041         (WebCore::FrameLoaderClientBlackBerry::startDownload):
1042
1043 2013-05-09  Mike Fenton  <mifenton@rim.com>
1044
1045         [BlackBerry] Style updates required based on new check-webkit-style
1046         https://bugs.webkit.org/show_bug.cgi?id=115857
1047
1048         Reviewed by Rob Buis.
1049
1050         Update FatFingers to match check-webkit-style updates.
1051
1052         * WebKitSupport/FatFingers.cpp:
1053         (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
1054         (BlackBerry::WebKit::FatFingers::checkForClickableElement):
1055         * WebKitSupport/FatFingers.h:
1056         (FatFingersResult):
1057
1058 2013-05-09  Mike Fenton  <mifenton@rim.com>
1059
1060         [BlackBerry] Style updates required based on new check-webkit-style
1061         https://bugs.webkit.org/show_bug.cgi?id=115857
1062
1063         Reviewed by Rob Buis.
1064
1065         Update InRegionScrollableArea, TileIndexHash
1066         and TouchEventHandler to match check-webkit-style updates.
1067
1068         * WebKitSupport/InRegionScrollableArea.cpp:
1069         * WebKitSupport/TileIndexHash.h:
1070         * WebKitSupport/TouchEventHandler.cpp:
1071         (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
1072
1073 2013-05-09  Mike Fenton  <mifenton@rim.com>
1074
1075         [BlackBerry] Style updates required based on new check-webkit-style
1076         https://bugs.webkit.org/show_bug.cgi?id=115857
1077
1078         Reviewed by Rob Buis.
1079
1080         Styles fixes required for InputHandler based on updated
1081         check-webkit-style.
1082
1083         * WebKitSupport/InputHandler.cpp:
1084         (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
1085         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
1086         (BlackBerry::WebKit::InputHandler::ensureFocusPluginElementVisible):
1087         (BlackBerry::WebKit::InputHandler::setPopupListIndexes):
1088         (BlackBerry::WebKit::InputHandler::firstSpanInString):
1089         (BlackBerry::WebKit::InputHandler::setTextAttributes):
1090         * WebKitSupport/InputHandler.h:
1091
1092 2013-05-08  Eli Fidler  <efidler@blackberry.com>
1093
1094         [BlackBerry] Fix usage of BlackBerry::Platform::String
1095         https://bugs.webkit.org/show_bug.cgi?id=115781
1096
1097         Reviewed by Rob Buis.
1098
1099         BlackBerry PRs 304193 and 327181
1100         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
1101
1102         We currently have a problem where we're passing UTF-8 encoded data into
1103         the char* constructors of BlackBerry::Platform::String. This means the string
1104         thinks its data is not UTF-8.
1105
1106         * Api/JavaScriptVariant.cpp:
1107         (BlackBerry::WebKit::JSValueRefToBlackBerryJavaScriptVariant):
1108         * Api/WebKitTextCodec.cpp:
1109         (BlackBerry::WebKit::base64Encode):
1110         * Api/WebPage.cpp:
1111         (BlackBerry::WebKit::WebPage::loadFile):
1112         (BlackBerry::WebKit::WebPage::textEncoding):
1113         (BlackBerry::WebKit::WebPage::textHasAttribute):
1114         (BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):
1115         * Api/WebPage.h:
1116         * Api/WebSettings.cpp:
1117         (BlackBerry::WebKit::WebSettings::standardSettings):
1118         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1119         (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
1120         (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
1121         * WebKitSupport/DefaultTapHighlight.cpp:
1122         (WebKit):
1123         (BlackBerry::WebKit::DefaultTapHighlight::draw):
1124         (BlackBerry::WebKit::DefaultTapHighlight::hide):
1125
1126 2013-05-08  Rob Buis  <rbuis@rim.com>
1127
1128         Fix some compiler warnings (miscellaneous)
1129         https://bugs.webkit.org/show_bug.cgi?id=80790
1130
1131         Reviewed by Philip Rogers.
1132
1133         Get rid of the following warning for BlackBerry:
1134
1135         BackingStoreClient.cpp:54:21: warning: unused parameter 'parentFrame' [-Wunused-parameter]
1136
1137         by using ASSERT_UNUSED instead of ASSERT.
1138
1139         * WebKitSupport/BackingStoreClient.cpp:
1140         (BlackBerry::WebKit::BackingStoreClient::create):
1141
1142 2013-05-07  Xuefei Ren  <xren@blackberry.com>
1143
1144         Clean up load interface in WebPage
1145         https://bugs.webkit.org/show_bug.cgi?id=115622
1146         Reviewed by Rob Buis.
1147
1148         Internal PR:315535
1149         Internal reviewed by  Mary Wu
1150
1151         * Api/WebPage.cpp:
1152         (BlackBerry::WebKit::WebPagePrivate::load):
1153         (BlackBerry::WebKit::WebPage::loadFile):
1154         (BlackBerry::WebKit::WebPage::load):
1155         * Api/WebPage.h:
1156         * Api/WebPage_p.h:
1157         (WebPagePrivate):
1158         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1159         (WebCore::FrameLoaderClientBlackBerry::startDownload):
1160
1161 2013-05-07  Mike Fenton  <mifenton@rim.com>
1162
1163         [BlackBerry] Increase the padding size for caret based scrolling.
1164         https://bugs.webkit.org/show_bug.cgi?id=115749
1165
1166         Reviewed by Rob Buis.
1167
1168         PR 322670.
1169
1170         Increasing the padding size for scrolling in order to optimize the
1171         number of scrolls required during typing.
1172
1173         * WebKitSupport/InputHandler.cpp:
1174         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
1175
1176 2013-05-07  Nima Ghanavatian  <nghanavatian@blackberry.com>
1177
1178         [BlackBerry] Maintain touch event state throughout processing
1179         https://bugs.webkit.org/show_bug.cgi?id=115663
1180
1181         Reviewed by Rob Buis.
1182
1183         Internally reviewed by Otto Cheung and Genevieve Mak.
1184
1185         PR 297691
1186         By maintaining our touch event state, we can get a better idea
1187         of what triggered an update to selection and respond appropriately.
1188         On touch press we set userTouchTriggered to give the UI thread
1189         some context.
1190
1191         * Api/WebPage.cpp:
1192         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
1193         (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
1194         (BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
1195         * Api/WebPage_p.h:
1196         (WebPagePrivate):
1197         * WebKitSupport/SelectionHandler.cpp:
1198         (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
1199
1200 2013-05-07  Nima Ghanavatian  <nghanavatian@blackberry.com>
1201
1202         [BlackBerry] Read-only fields should not get keyboard focus
1203         https://bugs.webkit.org/show_bug.cgi?id=115725
1204
1205         Reviewed by Rob Buis.
1206
1207         Internally reviewed by Mike Fenton.
1208
1209         PR332887
1210         Prevent keyboard focus and FCC from displaying when the user taps on a
1211         read-only field. Further, ensure form controls skip over these fields
1212         with the next/previous buttons.
1213
1214         * WebKitSupport/DOMSupport.cpp:
1215         (BlackBerry::WebKit::DOMSupport::elementIsReadOnly):
1216         (DOMSupport):
1217         * WebKitSupport/DOMSupport.h:
1218         * WebKitSupport/InputHandler.cpp:
1219         (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
1220         (BlackBerry::WebKit::InputHandler::setInputModeEnabled):
1221         (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
1222         (BlackBerry::WebKit::InputHandler::isActiveTextEdit):
1223         (WebKit):
1224         * WebKitSupport/InputHandler.h:
1225
1226 2013-05-07  Nima Ghanavatian  <nghanavatian@blackberry.com>
1227
1228         [BlackBerry] Expand spellcheck logging
1229         https://bugs.webkit.org/show_bug.cgi?id=115482
1230
1231         Reviewed by Rob Buis.
1232
1233         Internally reviewed by Mike Fenton.
1234
1235         Fix some build errors when SpellingLog was turned on and expand on the debug
1236         statements to be more verbose. Set up timers and print the duration of each
1237         iteration as we traverse the text to create a range to send out for checking.
1238
1239         * WebKitSupport/InputHandler.cpp:
1240         (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
1241         (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
1242         (BlackBerry::WebKit::InputHandler::setElementFocused):
1243         (WebKit):
1244         (BlackBerry::WebKit::InputHandler::spellCheckTextBlock):
1245         * WebKitSupport/SpellingHandler.cpp:
1246         (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
1247         (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
1248
1249 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
1250
1251         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
1252         https://bugs.webkit.org/show_bug.cgi?id=113808
1253
1254         Reviewed by Rob Buis.
1255
1256         Create a WebSetting for text autosizing. The default is off.
1257
1258         * Api/WebPage.cpp:
1259         (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
1260         * Api/WebSettings.cpp:
1261         (WebKit):
1262         (BlackBerry::WebKit::WebSettings::standardSettings):
1263         (BlackBerry::WebKit::WebSettings::isTextAutosizingEnabled):
1264         (BlackBerry::WebKit::WebSettings::setTextAutosizingEnabled):
1265         * Api/WebSettings.h:
1266
1267 2013-05-06  Nima Ghanavatian  <nghanavatian@blackberry.com>
1268
1269         [BlackBerry] Ensure document is attached before accessing its FrameSelection
1270         https://bugs.webkit.org/show_bug.cgi?id=115565
1271
1272         Reviewed by Rob Buis.
1273
1274         Internally reviewed by Mike Fenton.
1275
1276         PR 312101
1277         We need to make sure that the node and document
1278         are attached before accessing the FrameSelection. This was
1279         handled earlier but not all call paths were covered.
1280
1281         * WebKitSupport/InputHandler.cpp:
1282         (BlackBerry::WebKit::InputHandler::setElementUnfocused):
1283         (BlackBerry::WebKit::InputHandler::isActiveTextEdit):
1284         (WebKit):
1285         * WebKitSupport/InputHandler.h:
1286
1287 2013-05-06  Nima Ghanavatian  <nghanavatian@blackberry.com>
1288
1289         [BlackBerry] Do not spellcheck when composition is active.
1290         https://bugs.webkit.org/show_bug.cgi?id=115562
1291
1292         Reviewed by Rob Buis.
1293
1294         Internally reviewed by Mike Fenton.
1295
1296         PR331344
1297         Typing can trigger rechecking since layout changes. Ensure
1298         extra work is only done when we need it, and that it won't
1299         be triggered when composition is active. If the user hasn't
1300         finished a word yet, it is likely future key events will be
1301         arriving, so checking the string at this point is extraneous.
1302
1303         * WebKitSupport/InputHandler.cpp:
1304         (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
1305
1306 2013-05-06  Nima Ghanavatian  <nghanavatian@blackberry.com>
1307
1308         [BlackBerry] Reduce the spellcheck checking range
1309         https://bugs.webkit.org/show_bug.cgi?id=115479
1310
1311         Reviewed by Rob Buis.
1312
1313         Internally reviewed by Mike Fenton.
1314
1315         PR332773
1316         Previously we were spellchecking the entire field on focus. If relayouting
1317         occurred we rechecked this region, which is very costly. Switch to check
1318         only a small region around the caret in both cases, which should alleviate
1319         much of the delays experienced in very large contenteditable fields. This
1320         allows for faster key input response and less time processing these requests
1321         on the WebKit thread.
1322
1323         * WebKitSupport/InputHandler.cpp:
1324         (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
1325         (BlackBerry::WebKit::InputHandler::spellCheckTextBlock):
1326         * WebKitSupport/SpellingHandler.cpp:
1327         (WebKit):
1328         (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
1329         * WebKitSupport/SpellingHandler.h:
1330         (SpellingHandler):
1331
1332 2013-05-06  Nima Ghanavatian  <nghanavatian@blackberry.com>
1333
1334         [BlackBerry] Use a more descriptive timer name
1335         https://bugs.webkit.org/show_bug.cgi?id=115481
1336
1337         Reviewed by Rob Buis.
1338
1339         Internally reviewed by Mike Fenton.
1340
1341         Changing m_timer to m_iterationDelayTimer.
1342
1343         * WebKitSupport/SpellingHandler.cpp:
1344         (BlackBerry::WebKit::SpellingHandler::SpellingHandler):
1345         (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
1346         (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
1347         * WebKitSupport/SpellingHandler.h:
1348         (SpellingHandler):
1349
1350 2013-05-04  Nima Ghanavatian  <nghanavatian@blackberry.com>
1351
1352         [BlackBerry] Clean up unused spellcheck code
1353         https://bugs.webkit.org/show_bug.cgi?id=115560
1354
1355         Reviewed by Benjamin Poulain.
1356         Internally reviewed by Mike Lattanzio
1357
1358         * Api/WebPage.cpp:
1359         (BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
1360         * Api/WebPage.h:
1361         * WebKitSupport/InputHandler.cpp:
1362         * WebKitSupport/InputHandler.h:
1363         (InputHandler):
1364
1365 2013-05-03  Jacky Jiang  <zhajiang@blackberry.com>
1366
1367         [BlackBerry] Page rendering scale is changed after go back and forward
1368         https://bugs.webkit.org/show_bug.cgi?id=115573
1369
1370         Reviewed by Rob Buis.
1371         Internally reviewed by Jeff Rogers.
1372
1373         PR: 326886
1374         When navigating back from page A with viewport to page B without
1375         viewport, we didn't call setViewMode(); therefore, we didn't change
1376         the fixed layout size which was set by page A. In that case, WebCore
1377         would just pick up page A's fixed layout size to layout page B which
1378         caused this issue.
1379         Expecting zoomToInitialScaleOnLoad() or other functions to setViewMode()
1380         later is not a good way, because zoomToInitialScaleOnLoad() has never
1381         been called in this case. So we should always call setViewMode() to set
1382         fixed layout size when a new page is committed.
1383
1384         * Api/WebPage.cpp:
1385         (BlackBerry::WebKit::WebPagePrivate::setLoadState):
1386
1387 2013-05-02  Genevieve Mak  <gmak@rim.com>
1388
1389         [BlackBerry] Cannot touch scroll readonly text input.
1390         https://bugs.webkit.org/show_bug.cgi?id=115378
1391
1392         Reviewed by Rob Buis.
1393
1394         PR #332902
1395         Reviewed Internally by Mike Fenton.
1396         Forgot half the patch.
1397         Node::rendererIsEditable() returns false if the input element has the readonly tag set.
1398         Check the node type instead.
1399
1400         * Api/InRegionScroller.cpp:
1401         (BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
1402
1403 2013-05-02  Iris Wu  <shuwu@blackberry.com>
1404
1405         [BlackBerry] Make scroll position adjustment work with pages with fixed position elements.
1406         https://bugs.webkit.org/show_bug.cgi?id=115178
1407
1408         Reviewed by Rob Buis.
1409
1410         PR 308796
1411         Debug build fix.
1412
1413         * Api/WebPage.cpp:
1414         (BlackBerry::WebKit::WebPage::fixedElementSizeDelta):
1415
1416 2013-05-01  Iris Wu  <shuwu@blackberry.com>
1417
1418          [BlackBerry] Upstream smart selection
1419          https://bugs.webkit.org/show_bug.cgi?id=111226
1420
1421         Reviewed by Rob Buis.
1422
1423         Calling userInterfaceViewportAccessor()->documentViewportRect() on WK thread
1424         caused crash.
1425         But viewport from webkitThreadViewportAccessor uses unadjusted size which is
1426         wrong for email.
1427         The solution here is to get actual viewport size on UI thread and then pass it
1428         to WebKit::SelectionHandler.
1429
1430         PR 333763
1431         Reviewed Internally By Jakob Petsovits.
1432
1433         * Api/InRegionScroller.cpp:
1434         (BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
1435         * Api/WebPage.cpp:
1436         (BlackBerry::WebKit::WebPage::setSelectionDocumentViewportSize):
1437         (WebKit):
1438         * Api/WebPage.h:
1439         * WebKitSupport/SelectionHandler.cpp:
1440         (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
1441         (BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
1442         (BlackBerry::WebKit::SelectionHandler::selectionViewportRect):
1443         * WebKitSupport/SelectionHandler.h:
1444         (BlackBerry::WebKit::SelectionHandler::setSelectionViewportSize):
1445         (BlackBerry::WebKit::SelectionHandler::setSelectionSubframeViewportRect):
1446         (SelectionHandler):
1447
1448 2013-04-30  Genevieve Mak  <gmak@rim.com>
1449
1450         [BlackBerry] Cannot touch scroll readonly text input.
1451         https://bugs.webkit.org/show_bug.cgi?id=115378
1452
1453         Reviewed by Rob Buis.
1454
1455         PR #332902
1456         Reviewed Internally by Mike Fenton.
1457         Node::rendererIsEditable() returns false if the input element has the readonly tag set.
1458         Check the node type instead.
1459
1460         * WebKitSupport/DOMSupport.cpp:
1461         (BlackBerry::WebKit::DOMSupport::isShadowHostTextInputElement):
1462         (DOMSupport):
1463         * WebKitSupport/DOMSupport.h:
1464         * WebKitSupport/InRegionScrollableArea.cpp:
1465         (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
1466
1467 2013-04-29  Jakob Petsovits  <jpetsovits@blackberry.com>
1468
1469         [BlackBerry] Replace disappearing fillBuffer() API with graphics context drawing
1470         https://bugs.webkit.org/show_bug.cgi?id=115360
1471         Internal PR 303048.
1472
1473         Reviewed by Rob Buis.
1474
1475         Instead of using fillBuffer() to draw directly to the
1476         target buffer, we now lock a Drawable on it and fill it
1477         with PlatformGraphicsContext::addPredefinedPattern().
1478
1479         As a bonus, this also includes related clean-ups -
1480         simpler checkerboard painting code, removal of
1481         fillWindow(), clearWindow() and paintDefaultBackground(),
1482         as well as getting rid of the DEBUG_CHECKERBOARD define
1483         which has been useless for performance tracing purposes
1484         for a while now.
1485
1486         * Api/BackingStore.cpp:
1487         (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
1488         * Api/BackingStore_p.h:
1489
1490 2013-04-26  Nima Ghanavatian  <nghanavatian@blackberry.com>
1491
1492         [BlackBerry] Check for valid element in elementTouched
1493         https://bugs.webkit.org/show_bug.cgi?id=115205
1494
1495         Reviewed by Rob Buis.
1496
1497         Internally reviewed by Genevieve Mak.
1498
1499         PR 331546
1500         We might receive a null ptr from nodeAsElementIfApplicable which
1501         is passed in here. Check to make sure it's valid before using.
1502
1503         * WebKitSupport/InputHandler.cpp:
1504         (BlackBerry::WebKit::InputHandler::elementTouched):
1505
1506 2013-04-26  Martin Robinson  <mrobinson@igalia.com>
1507
1508         Remove the remaining Skia #ifdefs
1509         https://bugs.webkit.org/show_bug.cgi?id=114886
1510
1511         Reviewed by Benjamin Poulain.
1512
1513         * Api/WebPage.cpp: Remove Skia #ifdef references.
1514         * WebCoreSupport/AboutDataUseFeatures.in: Ditto.
1515
1516 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
1517
1518         [BlackBerry] Should check if it's cached resource before download
1519         https://bugs.webkit.org/show_bug.cgi?id=115101
1520
1521         Reviewed by Rob Buis.
1522
1523         Since main resource maybe cached, if user want to save the resource, we first check
1524         if it's cached. If yes, don't need to initiate a fresh load again, but get the
1525         cached resource data out to save.
1526
1527         RIM bug# 324003, internally reviewed by Charles Wei.
1528
1529         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1530         (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
1531
1532 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
1533
1534         [BlackBerry] Clean up load interface in WebPage
1535         https://bugs.webkit.org/show_bug.cgi?id=113267
1536
1537         Reviewed by Rob Buis.
1538
1539         Remove unused loadExtended(), combine load() and download() api in WebPage.
1540         RIM Bug# 315535, internally reviewed by Joe Mason.
1541
1542         * Api/WebPage.cpp:
1543         (BlackBerry::WebKit::WebPage::load):
1544         * Api/WebPage.h:
1545
1546 2013-04-25  Andrew Lo  <anlo@rim.com>
1547
1548         [BlackBerry] Selection overlay on non-composited iframes are incorrectly positioned.
1549         https://bugs.webkit.org/show_bug.cgi?id=115197
1550
1551         Reviewed by Rob Buis.
1552
1553         When drawing the selection overlay, the rects to
1554         paint when selecting text on non-composited sub-frames
1555         need to be adjusted by the frame position.
1556
1557         * WebKitSupport/SelectionOverlay.cpp:
1558         (BlackBerry::WebKit::SelectionOverlay::paintContents):
1559
1560 2013-04-25  Andreas Kling  <akling@apple.com>
1561
1562         Remove ENABLE(PARSED_STYLE_SHEET_CACHING) and make it always-on.
1563
1564         Rubber-stamped by Anders Koivisto.
1565
1566         * WebCoreSupport/AboutDataEnableFeatures.in:
1567
1568 2013-04-25  Iris Wu  <shuwu@blackberry.com>
1569
1570         [BlackBerry] Make scroll position adjustment work with pages with fixed position elements.
1571         https://bugs.webkit.org/show_bug.cgi?id=115178
1572
1573         Reviewed by Rob Buis.
1574
1575         PR 308796
1576
1577         Currently the position WebPage::adjustDocumentScrollPosition adjusts is the top
1578         left point of the viewport.
1579         On the page with fixed position elements, we want it to adjust the position beneath
1580         the fixed elements so it can be always visible.
1581
1582         The basic idea is:
1583         1.  Detect if there are fixed position elements before going through ProximityDetector.
1584         2.  If the fixed element exists, calculate its the size and the actual visible position
1585             beneath it.
1586         3.  Pass the position to ProximityDetector. Then according to the new position we get,
1587             calculate the top left position of the viewport (final scroll position).
1588
1589         * Api/WebPage.cpp:
1590         (BlackBerry::WebKit::WebPage::fixedElementSizeDelta):
1591         (WebKit):
1592         * Api/WebPage.h:
1593         * Api/WebPageCompositor.cpp:
1594         (BlackBerry::WebKit::WebPageCompositorPrivate::findFixedElementRect):
1595         (WebKit):
1596         * Api/WebPageCompositor_p.h:
1597         (WebPageCompositorPrivate):
1598
1599 2013-04-25  Mike Lattanzio  <mlattanzio@blackberry.com>
1600
1601         [BlackBerry] Enable balanced page group load deferrer behaviour.
1602         https://bugs.webkit.org/show_bug.cgi?id=115189
1603
1604         Reviewed by Rob Buis.
1605
1606         Prevent a possible deadlock by enabling balanced deferrers.
1607         Internally reviewed by: Joe Mason
1608         PR 329986
1609
1610         * Api/WebPage.cpp:
1611         (BlackBerry::WebKit::WebPagePrivate::init):
1612
1613 2013-04-25  Joseph Pecoraro  <pecoraro@apple.com>
1614
1615         Web Inspector: ConsoleMessage should include line and column number where possible
1616         https://bugs.webkit.org/show_bug.cgi?id=114929
1617
1618         Reviewed by Timothy Hatcher.
1619
1620         * Api/DumpRenderTreeClient.h:
1621         * Api/WebPageClient.h:
1622         * WebCoreSupport/ChromeClientBlackBerry.cpp:
1623         (WebCore::ChromeClientBlackBerry::addMessageToConsole):
1624         * WebCoreSupport/ChromeClientBlackBerry.h:
1625         (ChromeClientBlackBerry):
1626
1627 2013-04-25  Konrad Piascik  <kpiascik@blackberry.com>
1628
1629         [BlackBerry] Get rid of return in void method
1630         https://bugs.webkit.org/show_bug.cgi?id=115186
1631
1632         Reviewed by Rob Buis.
1633
1634         * Api/WebPage.cpp:
1635         (BlackBerry::WebKit::WebPage::setForcedTextEncoding):
1636
1637 2013-04-24  Nima Ghanavatian  <nghanavatian@blackberry.com>
1638
1639         [BlackBerry] Do not clear focus on a node when tapping on form controls
1640         https://bugs.webkit.org/show_bug.cgi?id=115055
1641
1642         Reviewed by Rob Buis.
1643
1644         Internally reviewed by Genevieve Mak.
1645
1646         PR316069
1647         To allow for rich text editors to apply styles on an input field
1648         or highlighted text, we must maintain focus on the current element
1649         when tapping on form elements. Moving the code that clears this
1650         context to trigger off TouchHold instead of TouchPress.
1651
1652         * WebKitSupport/TouchEventHandler.cpp:
1653         (BlackBerry::WebKit::TouchEventHandler::doFatFingers):
1654
1655 == Rolled over to ChangeLog-2013-04-24 ==