Web Inspector: ResourceContentView.js incorrectly contains call to WebInspector.UIStr...
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2015-01-22  Jonathan Wells  <jonowells@apple.com>
2
3         Web Inspector: ResourceContentView.js incorrectly contains call to WebInspector.UIString with a variable parameter
4         https://bugs.webkit.org/show_bug.cgi?id=140268
5
6         Reviewed by Timothy Hatcher.
7
8         UIString no longer incorrectly used around variables. Drive-by fixes to prototype inheritance style.
9         Use of Promises corrected such that requesting content for a resource resolves rather than rejects if
10         a resource can't be found or has another error that isn't a web inspector error.
11
12         * Localizations/en.lproj/localizedStrings.js: Updated.
13         * UserInterface/Models/Resource.js: Change reject to resolve.
14         * UserInterface/Models/Script.js:
15         (WebInspector.Script.prototype.requestContentFromBackend): Proper use of Error object.
16         * UserInterface/Models/SourceCode.js: Use correct inheritance style.
17         * UserInterface/Views/ResourceContentView.js:
18         (WebInspector.ResourceContentView.prototype._contentAvailable): Handle error now that promise resolves.
19         (WebInspector.ResourceContentView.prototype._contentError): Remove incorrect use of UIString.
20         * UserInterface/Views/SourceCodeTextEditor.js:
21         (WebInspector.SourceCodeTextEditor.prototype._contentAvailable): Handle error now that promise resolves.
22
23 2015-01-22  Nikita Vasilyev  <nvasilyev@apple.com>
24
25         Web Inspector: Expected gutter highlight when selecting console input line, just like output line
26         https://bugs.webkit.org/show_bug.cgi?id=140696
27
28         Reviewed by Timothy Hatcher.
29
30         * UserInterface/Views/LogContentView.css:
31
32 2015-01-21  Saam Barati  <saambarati1@gmail.com>
33
34         Web Inspector: Change Annotator's isActive getter into an isActive() function.
35         https://bugs.webkit.org/show_bug.cgi?id=140729
36
37         Reviewed by Timothy Hatcher.
38
39         This patch also makes the child classes of Annotator use
40         the function instead of accessing the property directly.
41
42         * UserInterface/Controllers/Annotator.js:
43         (WebInspector.Annotator.prototype.isActive):
44         (WebInspector.Annotator.prototype.get isActive): Deleted.
45         * UserInterface/Controllers/BasicBlockAnnotator.js:
46         (WebInspector.BasicBlockAnnotator.prototype.insertAnnotations):
47         * UserInterface/Controllers/TypeTokenAnnotator.js:
48         (WebInspector.TypeTokenAnnotator.prototype.toggleTypeAnnotations):
49         * UserInterface/Views/SourceCodeTextEditor.js:
50         (WebInspector.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
51         (WebInspector.SourceCodeTextEditor.prototype.prettyPrint):
52         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidPause):
53         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidResume):
54         (WebInspector.SourceCodeTextEditor.prototype._updateTokenTrackingControllerState):
55
56 2015-01-21  Saam Barati  <saambarati1@gmail.com>
57
58         Web Inspector: Don't allow the BasicBlockAnnotator to highlight a section if it's only a closing brace
59         https://bugs.webkit.org/show_bug.cgi?id=140727
60
61         Reviewed by Timothy Hatcher.
62
63         * UserInterface/Controllers/BasicBlockAnnotator.js:
64         (WebInspector.BasicBlockAnnotator.prototype.set _highlightTextForBasicBlock):
65         (WebInspector.BasicBlockAnnotator.prototype._isTextRangeOnlyClosingBrace):
66         BasicBlockAnnotator tries to no longer highlight a basic block if it is only
67         whitespace and a closing brace. These ranges are often after statements
68         that make these basic blocks unreachable, such as a return/break/continue
69         statement occurring inside a if/else/while/for block. This check won't
70         match every highlighted empty closing brace, but catches most of them 
71         because it only does intra block analysis instead of inter block analysis.
72
73 2015-01-20  Joseph Pecoraro  <pecoraro@apple.com>
74
75         Web Inspector: Use spread operator in a few places
76         https://bugs.webkit.org/show_bug.cgi?id=140699
77
78         Reviewed by Geoffrey Garen.
79
80         * UserInterface/Controllers/ProbeManager.js:
81         (WebInspector.ProbeManager.prototype.get probeSets):
82         Simplify by using the spread operator.
83
84         * UserInterface/Models/TimelineRecording.js:
85         This actually fixes an issue. The one place this was used was expecting
86         an array and called ".length" on the result. However, the iterator being
87         returned does not have a ".length" property so it was always undefined.
88
89 2015-01-20  Joseph Pecoraro  <pecoraro@apple.com>
90
91         Web Inspector: Expanding event objects in console shows undefined for most values, it should have real values
92         https://bugs.webkit.org/show_bug.cgi?id=137306
93
94         Reviewed by Timothy Hatcher.
95
96         When first expanding an object, show all the object's own properties and any
97         getter properties that may be on its prototype chain. Now, we only fetch
98         own properties, for __proto__ properties.
99
100         * UserInterface/Protocol/RemoteObject.js:
101         (WebInspector.RemoteObject.prototype.getOwnProperties):
102         (WebInspector.RemoteObject.prototype.getOwnAndGetterProperties):
103         (WebInspector.RemoteObject.prototype.getAllProperties):
104         (WebInspector.RemoteObject.prototype.get hasChildren): Deleted.
105         * UserInterface/Views/ObjectPropertiesSection.js:
106         (WebInspector.ObjectPropertiesSection):
107         (WebInspector.ObjectPropertiesSection.prototype.update):
108         (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
109
110 2015-01-20  Joseph Pecoraro  <pecoraro@apple.com>
111
112         Web Inspector: Should show dynamic specificity values
113         https://bugs.webkit.org/show_bug.cgi?id=140647
114
115         Reviewed by Benjamin Poulain.
116
117         For dynamic selectors, provide text in the tooltip describing that the
118         specificity is dynamic and may change, and pointing out the element
119         the current value was calculated against.
120
121         * Localizations/en.lproj/localizedStrings.js:
122         * UserInterface/Models/CSSSelector.js:
123         (WebInspector.CSSSelector):
124         (WebInspector.CSSSelector.prototype.get specificity):
125         (WebInspector.CSSSelector.prototype.get dynamic):
126         * UserInterface/Models/DOMNodeStyles.js:
127         (WebInspector.DOMNodeStyles.prototype._parseSelectorListPayload.return):
128         (WebInspector.DOMNodeStyles.prototype._parseSelectorListPayload):
129         * UserInterface/Views/CSSStyleDeclarationSection.js:
130         (WebInspector.CSSStyleDeclarationSection.prototype.refresh.appendSelector):
131
132 2015-01-19  Saam Barati  <saambarati1@gmail.com>
133
134         Web Inspector: Provide a front end for JSC's Control Flow Profiler
135         https://bugs.webkit.org/show_bug.cgi?id=138454
136
137         Reviewed by Timothy Hatcher.
138
139         This patch creates a user interface for JSC's control flow profiler.
140         The Web Inspector gets basic block ranges from JSC, and displays
141         basic blocks that have not executed as having a gray background.
142         
143         BasicBlockAnnotator is the class responsible for this UI logic.
144         It also does a few nifty things when presenting a UI for this gray
145         background color: if an entire line of code is within the basic 
146         block's boundary, the annotator will not just highlight the background 
147         behind the text, but the background of the entire line itself. This
148         provides a nicer experience when glancing through large JavaScript files.
149
150         This patch also adds some necessary wrapper methods inside TextEditor
151         for accessing CodeMirror's text highlighting functionality. It also
152         creates a way for TextEditor and SourceCodeTextEditor to listen
153         for focus events inside CodeMirror.
154
155         * UserInterface/Controllers/AnnotatorManager.js: Removed.
156         * UserInterface/Controllers/BasicBlockAnnotator.js: Added.
157         (WebInspector.BasicBlockAnnotator):
158         (WebInspector.BasicBlockAnnotator.prototype.clearAnnotations):
159         (WebInspector.BasicBlockAnnotator.prototype.insertAnnotations):
160         (WebInspector.BasicBlockAnnotator.prototype._annotateBasicBlockExecutionRanges.):
161         (WebInspector.BasicBlockAnnotator.prototype._annotateBasicBlockExecutionRanges):
162         (WebInspector.BasicBlockAnnotator.prototype.set _highlightTextForBasicBlock):
163         (WebInspector.BasicBlockAnnotator.prototype._isTextRangeOnlyWhitespace):
164         (WebInspector.BasicBlockAnnotator.prototype._canGrayOutEntireLine):
165         (WebInspector.BasicBlockAnnotator.prototype._grayOutLine):
166         (WebInspector.BasicBlockAnnotator.prototype._clearRangeForBasicBlockMarker.get marker):
167         (WebInspector.BasicBlockAnnotator.prototype._clearRangeForBasicBlockMarker):
168         * UserInterface/Main.html:
169         * UserInterface/Views/SourceCodeTextEditor.css:
170         (.basic-block-has-not-executed):
171         (.basic-block-has-not-executed-prepend::before):
172         * UserInterface/Views/SourceCodeTextEditor.js:
173         (WebInspector.SourceCodeTextEditor):
174         (WebInspector.SourceCodeTextEditor.prototype.shown):
175         (WebInspector.SourceCodeTextEditor.prototype.hidden):
176         (WebInspector.SourceCodeTextEditor.prototype.canShowTypeAnnotations):
177         (WebInspector.SourceCodeTextEditor.prototype.contentDidChange):
178         (WebInspector.SourceCodeTextEditor.prototype.gainedFocus):
179         (WebInspector.SourceCodeTextEditor.prototype.lostFocus):
180         (WebInspector.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
181         (WebInspector.SourceCodeTextEditor.prototype.prettyPrint):
182         (WebInspector.SourceCodeTextEditor.prototype._populateWithContent):
183         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidPause):
184         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidResume):
185         (WebInspector.SourceCodeTextEditor.prototype._updateTokenTrackingControllerState):
186         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenAnnotator):
187         (WebInspector.SourceCodeTextEditor.prototype._makeBasicBlockAnnotator):
188         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler.scrollHandler):
189         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler):
190         * UserInterface/Views/TextEditor.js:
191         (WebInspector.TextEditor):
192         (WebInspector.TextEditor.prototype.getTextInRange):
193         (WebInspector.TextEditor.prototype.addStyleToTextRange):
194         (WebInspector.TextEditor.prototype.gainedFocus):
195         (WebInspector.TextEditor.prototype.lostFocus):
196
197 2015-01-16  Nikita Vasilyev  <nvasilyev@apple.com>
198
199         Web Inspector: Make message selection in the console more readable
200         https://bugs.webkit.org/show_bug.cgi?id=140385
201
202         Reviewed by Timothy Hatcher.
203
204         * UserInterface/Views/LogContentView.css:
205         (.console-item.selected):
206         (.console-messages:focus .console-item.selected):
207         (.console-item.selected .console-message::after):
208         (.console-messages:focus .console-item.selected .console-message::after):
209         (.console-messages:focus .console-item.selected .go-to-link):
210         * UserInterface/Views/Main.css:
211         (.go-to-link):
212         !important statements seem to be unnecessary, remove them.
213
214 2015-01-16  Joseph Pecoraro  <pecoraro@apple.com>
215
216         Web Inspector: Remove unused WebInspector.LocalJSONObject
217         https://bugs.webkit.org/show_bug.cgi?id=140570
218
219         Reviewed by Timothy Hatcher.
220
221         * UserInterface/Protocol/RemoteObject.js:
222         (WebInspector.RemoteObject.fromLocalObject): Deleted.
223         (WebInspector.LocalJSONObject): Deleted.
224         (WebInspector.LocalJSONObject.prototype.get description.switch.case.string_appeared_here): Deleted.
225         (WebInspector.LocalJSONObject.prototype.get description.switch.default): Deleted.
226         (WebInspector.LocalJSONObject.prototype.get description): Deleted.
227         (WebInspector.LocalJSONObject.prototype._concatenate): Deleted.
228         (WebInspector.LocalJSONObject.prototype.get type): Deleted.
229         (WebInspector.LocalJSONObject.prototype.get subtype): Deleted.
230         (WebInspector.LocalJSONObject.prototype.get hasChildren): Deleted.
231         (WebInspector.LocalJSONObject.prototype.getOwnProperties): Deleted.
232         (WebInspector.LocalJSONObject.prototype.getAllProperties): Deleted.
233         (WebInspector.LocalJSONObject.prototype._children.buildProperty): Deleted.
234         (WebInspector.LocalJSONObject.prototype._children): Deleted.
235         (WebInspector.LocalJSONObject.prototype.isError): Deleted.
236
237 2015-01-15  Joseph Pecoraro  <pecoraro@apple.com>
238
239         Web Inspector: Uncaught exceptions, attempting to dispatch unimplemented Network WebSocket methods
240         https://bugs.webkit.org/show_bug.cgi?id=140532
241
242         Reviewed by Timothy Hatcher.
243
244         * UserInterface/Protocol/NetworkObserver.js:
245         (WebInspector.NetworkObserver.prototype.webSocketFrameReceived):
246         (WebInspector.NetworkObserver.prototype.webSocketFrameError):
247         (WebInspector.NetworkObserver.prototype.webSocketFrameSent):
248         Add stubs to prevent an exception when trying to dispatch the event.
249
250 2015-01-15  Joseph Pecoraro  <pecoraro@apple.com>
251
252         Web Inspector: Reopening the inspector can selects a sub-frame instead of the Main Frame's DOM
253         https://bugs.webkit.org/show_bug.cgi?id=140513
254
255         Reviewed by Timothy Hatcher.
256
257         * UserInterface/Models/Frame.js:
258         (WebInspector.Frame.prototype.saveIdentityToCookie):
259         Specifically identify the main frame, so that any sub-frames with the same
260         URL, don't get choosen over the main frame when restoring state from cookie.
261
262 2015-01-15  Joseph Pecoraro  <pecoraro@apple.com>
263
264         Web Inspector: selecting Paint timeline records from sidebar does not trigger preview of paint quad
265         https://bugs.webkit.org/show_bug.cgi?id=139151
266
267         Reviewed by Brian Burg.
268
269         * UserInterface/Views/LayoutTimelineDataGrid.js:
270         (WebInspector.LayoutTimelineDataGrid):
271         (WebInspector.LayoutTimelineDataGrid.prototype.callFramePopoverAnchorElement):
272         (WebInspector.LayoutTimelineDataGrid.prototype.reset): Deleted.
273         (WebInspector.LayoutTimelineDataGrid.prototype.hidden): Deleted.
274         (WebInspector.LayoutTimelineDataGrid.prototype._layoutDataGridSelectedNodeChanged): Deleted.
275         (WebInspector.LayoutTimelineDataGrid.prototype._hideHighlightIfNeeded): Deleted.
276         Move the node highlight from the datagrid to the timeline view because
277         we want this to happen on both the Navigation sidebar and the datagrid.
278
279         * UserInterface/Views/LayoutTimelineView.js:
280         (WebInspector.LayoutTimelineView.prototype.shown):
281         (WebInspector.LayoutTimelineView.prototype.hidden):
282         (WebInspector.LayoutTimelineView.prototype.filterDidChange):
283         (WebInspector.LayoutTimelineView.prototype.reset):
284         (WebInspector.LayoutTimelineView.prototype._treeElementDeselected):
285         (WebInspector.LayoutTimelineView.prototype._treeElementSelected):
286         Update the highlight for major view updates.
287
288         (WebInspector.LayoutTimelineView.prototype._updateHighlight):
289         (WebInspector.LayoutTimelineView.prototype._showHighlightForRecord):
290         (WebInspector.LayoutTimelineView.prototype._hideHighlightIfNeeded):
291         (WebInspector.LayoutTimelineView.prototype._hoveredOrSelectedRecord):
292         Show a highlight for what we are hovering, or what is selected.
293         Note the selected node may not be visible due to filtering.
294
295         (WebInspector.LayoutTimelineView.prototype._mouseOverDataGrid):
296         (WebInspector.LayoutTimelineView.prototype._mouseLeaveDataGrid):
297         (WebInspector.LayoutTimelineView.prototype._mouseOverTreeOutline):
298         (WebInspector.LayoutTimelineView.prototype._mouseLeaveTreeOutline):
299         Update hovered information mousing over the datagrid and tree outline.
300
301         * UserInterface/Views/TimelineContentView.js:
302         (WebInspector.TimelineContentView.prototype.filterDidChange):
303         * UserInterface/Views/TimelineSidebarPanel.js:
304         (WebInspector.TimelineSidebarPanel.prototype.updateFilter):
305         * UserInterface/Views/TimelineView.js:
306         (WebInspector.TimelineView.prototype.filterDidChange):
307         Include a "filterDidChange" TimelineView method that gets called after
308         updateFilter (things like the filter bar or timeline range changes).
309
310         * UserInterface/Views/TreeOutline.js:
311         (TreeOutline.prototype.treeElementFromNode):
312         (TreeOutline.prototype.treeElementFromPoint):
313         Provide a helper to get a tree element from an event target.
314
315 2015-01-13  Joseph Pecoraro  <pecoraro@apple.com>
316
317         Web Inspector: TextEditor doesn't update when resizing console, white space instead of content
318         https://bugs.webkit.org/show_bug.cgi?id=140240
319
320         Reviewed by Timothy Hatcher.
321
322         * UserInterface/Base/Main.js:
323         (WebInspector._consoleResizerMouseDown.dockedResizerDrag):
324         Dispatch the event that signals the console has changed size.
325
326 2015-01-13  Joseph Pecoraro  <pecoraro@apple.com>
327
328         Web Inspector: I do not expect to see the same rule multiple times in styles sidebar
329         https://bugs.webkit.org/show_bug.cgi?id=138185
330
331         Reviewed by Timothy Hatcher.
332
333         In the styles sidebar, don't show a duplicate, lesser-specificity rule even
334         if it matches the selected element multiple times with different selectors
335         in the list.
336
337         * UserInterface/Models/CSSRule.js:
338         (WebInspector.CSSRule.prototype.isEqualTo):
339         CSSRule identifiers are objects.
340
341         * UserInterface/Views/RulesStyleDetailsPanel.js:
342         (WebInspector.RulesStyleDetailsPanel.prototype.refresh):
343         Remove duplicates from the ordered list of style declarations.
344
345 2015-01-12  Jonathan Wells  <jonowells@apple.com>
346
347         Web Inspector: Timeline: when Network Requests view is selected, in progress requests are absent.
348         https://bugs.webkit.org/show_bug.cgi?id=140090
349
350         Reviewed by Timothy Hatcher.
351
352         TimelineContentView#_updateTimes() changed to call WebInspector.timelineSidebarPanel.updateFilter() in addition
353         to updating the layout of the current timeline view. TimelineSidebarPanel.updateFilter() now responsible for
354         updating filtered resources in a TimelineView.
355
356         * UserInterface/Views/NavigationSidebarPanel.js:
357         (WebInspector.NavigationSidebarPanel.prototype._updateFilter):
358         Now handles updating the UI associated with filtering of navigation sidebar tree elements.
359
360         * UserInterface/Views/OverviewTimelineView.js:
361         (WebInspector.OverviewTimelineView.prototype.updateLayout):
362         No longer handles updating other UI along with the navigation sidebar tree elements. That is now handled by
363         WebInspector.TimelineView.prototype.filterUpdated.
364         (WebInspector.OverviewTimelineView.prototype._compareTreeElementsByDetails): Drive-by fix. Missing vars.
365
366         * UserInterface/Views/TimelineContentView.js:
367         (WebInspector.TimelineContentView.prototype._updateTimes): Add call to updateFilter().
368
369         * UserInterface/Views/TimelineView.js:
370         (WebInspector.TimelineView.prototype.filterUpdated):
371         Function added to dispatch a SelectionPathComponentsDidChange event.
372
373 2015-01-09  Enrica Casucci  <enrica@apple.com>
374
375         [iOS] Support additional text styles.
376         https://bugs.webkit.org/show_bug.cgi?id=140310
377         rdar://problem/18568864
378
379         Reviewed by Joseph Pecoraro.
380
381         Add support for three new text styles.
382
383         * UserInterface/Models/CSSKeywordCompletions.js:
384
385 2015-01-09  Timothy Hatcher  <timothy@apple.com>
386
387         Web Inspector: REGRESSION: Navigation sidebar can show blank next to the Console view
388         https://bugs.webkit.org/show_bug.cgi?id=140291
389
390         Reviewed by Joseph Pecoraro.
391
392         * UserInterface/Base/Main.js:
393         (WebInspector.contentLoaded): Don't restore collapsed false if selectedSidebarPanel is null.
394         (WebInspector._sidebarCollapsedStateDidChange): Support a _ignoreNavigationSidebarPanelCollapsedEvent flag
395         to avoid setting _navigationSidebarCollapsedSetting.
396         (WebInspector._navigationSidebarPanelSelected): Force collapsed if selectedSidebarPanel is null.
397         (WebInspector._contentBrowserCurrentContentViewDidChange): Set _ignoreNavigationSidebarPanelCollapsedEvent
398         when forcing the collapsed state to avoid setting _navigationSidebarCollapsedSetting and calling
399         _updateContentViewForCurrentNavigationSidebar.
400
401 2015-01-08  Nikita Vasilyev  <nvasilyev@apple.com>
402
403         Web Inspector: REGRESSION Showing debugger sidebar shouldn't change selected JS file
404         https://bugs.webkit.org/show_bug.cgi?id=139526
405
406         Reviewed by Timothy Hatcher.
407
408         * UserInterface/Base/Main.js:
409         (WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar):
410         When switching to Debugger, show last selected JS or HTML resource.
411
412         (WebInspector.showSplitConsole):
413         (WebInspector.showFullHeightConsole):
414         (WebInspector.toggleConsoleView):
415         (WebInspector._sidebarCollapsedStateDidChange):
416         (WebInspector._updateContentViewForCurrentNavigationSidebar):
417         (WebInspector._navigationSidebarPanelSelected):
418         (WebInspector._contentBrowserCurrentContentViewDidChange):
419         (WebInspector._updateNavigationSidebarForCurrentContentView): Deleted.
420         * UserInterface/Views/ApplicationCacheFrameContentView.js:
421         (WebInspector.ApplicationCacheFrameContentView.prototype.get allowedNavigationSidebarPanels):
422         * UserInterface/Views/CookieStorageContentView.js:
423         (WebInspector.CookieStorageContentView.prototype.get allowedNavigationSidebarPanels):
424         * UserInterface/Views/DOMStorageContentView.js:
425         (WebInspector.DOMStorageContentView.prototype.get allowedNavigationSidebarPanels):
426         * UserInterface/Views/DOMTreeContentView.js:
427         (WebInspector.DOMTreeContentView.prototype.get allowedNavigationSidebarPanels):
428         * UserInterface/Views/DatabaseContentView.js:
429         (WebInspector.DatabaseContentView.prototype.get allowedNavigationSidebarPanels):
430         * UserInterface/Views/DatabaseTableContentView.js:
431         (WebInspector.DatabaseTableContentView.prototype.get allowedNavigationSidebarPanels):
432         * UserInterface/Views/FontResourceContentView.js:
433         (WebInspector.FontResourceContentView.prototype.get allowedNavigationSidebarPanels):
434         * UserInterface/Views/FrameDOMTreeContentView.js:
435         (WebInspector.FrameDOMTreeContentView.prototype.get allowedNavigationSidebarPanels):
436         * UserInterface/Views/LogContentView.js:
437         (WebInspector.LogContentView.prototype.get allowedNavigationSidebarPanels):
438         * UserInterface/Views/ResourceClusterContentView.js:
439         (WebInspector.ResourceClusterContentView.prototype.get allowedNavigationSidebarPanels):
440         * UserInterface/Views/ResourceSidebarPanel.js:
441         (WebInspector.ResourceSidebarPanel.prototype.showDefaultContentView):
442         (WebInspector.ResourceSidebarPanel.prototype.showMainFrame):
443         * UserInterface/Views/Sidebar.js:
444         (WebInspector.Sidebar.prototype.removeSidebarPanel):
445         * UserInterface/Views/TimelineContentView.js:
446         (WebInspector.TimelineContentView.prototype.get allowedNavigationSidebarPanels):
447
448 2015-01-08  Joseph Pecoraro  <pecoraro@apple.com>
449
450         Web Inspector: Phantom breakpoint appears on empty line after reload of minified file with a breakpoint
451         https://bugs.webkit.org/show_bug.cgi?id=140276
452
453         Reviewed by Timothy Hatcher.
454
455         Styles being set on lines (e.g. breakpoint styles) before content loaded can
456         carry forward with the empty line. It is safe for us to just remove all
457         the styles from the intial empty line before we load the initial content.
458
459         * UserInterface/Views/TextEditor.js:
460         (WebInspector.TextEditor.prototype.set string.update):
461         (WebInspector.TextEditor.prototype.set string):
462
463 2015-01-08  Joseph Pecoraro  <pecoraro@apple.com>
464
465         Web Inspector: Pause Reason Improvements (Breakpoint, Debugger Statement, Pause on Next Statement)
466         https://bugs.webkit.org/show_bug.cgi?id=138991
467
468         Reviewed by Timothy Hatcher.
469
470         * Localizations/en.lproj/localizedStrings.js:
471         New UI strings for Pause Reasons.
472
473         * UserInterface/Controllers/DebuggerManager.js:
474         (WebInspector.DebuggerManager.prototype.breakpointForIdentifier):
475         Provide a way to get the breakpoint with an identifier.
476
477         * UserInterface/Images/PausedBreakpoint.svg: Added.
478         * UserInterface/Images/gtk/PausedBreakpoint.svg: Added.
479         Copy PseudoElement.svg icon and give it a new name.
480
481         * UserInterface/Views/BreakpointTreeElement.css:
482         (.breakpoint-paused-icon .icon):
483         New icon for a breakpoint causing a pause.
484
485         * UserInterface/Views/BreakpointTreeElement.js:
486         (WebInspector.BreakpointTreeElement.prototype.removeStatusImage):
487         (WebInspector.BreakpointTreeElement.prototype._updateStatus):
488         Give API to remove the breakpoint status icon from a BreakpointTreeElement.
489
490         * UserInterface/Views/DebuggerSidebarPanel.js:
491         (WebInspector.DebuggerSidebarPanel):
492         (WebInspector.DebuggerSidebarPanel.prototype.get hasSelectedElement):
493         (WebInspector.DebuggerSidebarPanel.prototype.deselectBreakpointContentTreeElements):
494         (WebInspector.DebuggerSidebarPanel.prototype.deselectPauseReasonContentTreeElements):
495         (WebInspector.DebuggerSidebarPanel.prototype._treeElementSelected):
496         Give DebuggerSidebarPanel an optional pause reason tree outline. When available
497         include it in the pattern of ensuring a single exclusive selection.
498
499         (WebInspector.DebuggerSidebarPanel.prototype._breakpointRemoved):
500         When a breakpoint is removed, check if we should update the pause reason tree outline.
501
502         (WebInspector.DebuggerSidebarPanel.prototype._updatePauseReason):
503         (WebInspector.DebuggerSidebarPanel.prototype._updatePauseReasonSection):
504         Update Pause Reason section contents depending on the reason.
505
506         (WebInspector.DebuggerSidebarPanel.prototype._updatePauseReasonGotoArrow):
507         Always try to include a goto arrow to jump to the original pause location
508         if it is available at the time of pausing.
509
510 2015-01-08  Joseph Pecoraro  <pecoraro@apple.com>
511
512         Web Inspector: Expected UserAgent styles to be crossed-out if overridden
513         https://bugs.webkit.org/show_bug.cgi?id=140154
514
515         Reviewed by Timothy Hatcher.
516
517         * UserInterface/Models/DOMNodeStyles.js:
518         (WebInspector.DOMNodeStyles.prototype._parseStylePropertyPayload):
519         Add a comment about anonymous styles. The getter is no longer used, and it is not
520         clear if we really care about this state, or if "anonymous" is an appropriate name.
521
522         (WebInspector.DOMNodeStyles.prototype._markOverriddenProperties):
523         Allow browser styles (user agent / html attributes) to be overridden.
524
525         (WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
526         When refreshing styles after changes, the Style object backing HTML attributes
527         was being completely replaced. Allow it to be remembered by a unique key.
528
529 2015-01-07  Joseph Pecoraro  <pecoraro@apple.com>
530
531         Web Inspector: Do not create rulesMap entries for rules without identifiers
532         https://bugs.webkit.org/show_bug.cgi?id=140237
533
534         Reviewed by Timothy Hatcher.
535
536         * UserInterface/Models/DOMNodeStyles.js:
537         (WebInspector.DOMNodeStyles.prototype._parseRulePayload):
538         We were accidentally converting a null into a string with a loose string
539         concatenation. Only do this if the mapKey is not-null.
540
541 2015-01-07  Saam Barati  <saambarati1@gmail.com>
542
543         Web Inspector: Abstract common functions from TypeTokenAnnotator into a parent class and introduce an AnnotatorManager
544         https://bugs.webkit.org/show_bug.cgi?id=139426
545
546         Reviewed by Timothy Hatcher.
547
548         This patch creates a parent class, Annotator, that TypeTokenAnnotator
549         inherits from. Annotator defines a common set of functionality
550         that a text editor annotator can use to mark up UI. This 
551         is in preparation other classes that will inherit from Annotator.
552         
553         This patch also introduces AnnotatorManager which controls a
554         set of Annotators and provides a single interface for
555         controlling them.
556
557         * UserInterface/Controllers/Annotator.js: Added.
558         (WebInspector.Annotator):
559         (WebInspector.Annotator.prototype.get sourceCodeTextEditor):
560         (WebInspector.Annotator.prototype.get isActive):
561         (WebInspector.Annotator.prototype.pause):
562         (WebInspector.Annotator.prototype.resume):
563         (WebInspector.Annotator.prototype.refresh):
564         (WebInspector.Annotator.prototype.reset):
565         (WebInspector.Annotator.prototype.clear):
566         (WebInspector.Annotator.prototype.insertAnnotations):
567         (WebInspector.Annotator.prototype.clearAnnotations):
568         (WebInspector.Annotator.prototype._clearTimeoutIfNeeded):
569         * UserInterface/Controllers/AnnotatorManager.js: Added.
570         (WebInspector.AnnotatorManager):
571         (WebInspector.AnnotatorManager.prototype.addAnnotator):
572         (WebInspector.AnnotatorManager.prototype.isAnnotatorActive):
573         (WebInspector.AnnotatorManager.prototype.pauseAll):
574         (WebInspector.AnnotatorManager.prototype.resumeAll):
575         (WebInspector.AnnotatorManager.prototype.refreshAllIfActive):
576         (WebInspector.AnnotatorManager.prototype.resetAllIfActive):
577         (WebInspector.AnnotatorManager.prototype.clearAll):
578         (WebInspector.AnnotatorManager.prototype.removeAllAnnotators):
579         (WebInspector.AnnotatorManager.prototype._getAnnotators):
580         * UserInterface/Controllers/TypeTokenAnnotator.js:
581         (WebInspector.TypeTokenAnnotator):
582         (WebInspector.TypeTokenAnnotator.prototype.insertAnnotations.):
583         (WebInspector.TypeTokenAnnotator.prototype.clearAnnotations):
584         (WebInspector.TypeTokenAnnotator.prototype._insertToken):
585         (WebInspector.TypeTokenAnnotator.prototype.get isActive): Deleted.
586         (WebInspector.TypeTokenAnnotator.prototype.get sourceCodeTextEditor): Deleted.
587         (WebInspector.TypeTokenAnnotator.prototype.pause): Deleted.
588         (WebInspector.TypeTokenAnnotator.prototype.resume): Deleted.
589         (WebInspector.TypeTokenAnnotator.prototype.refresh): Deleted.
590         (WebInspector.TypeTokenAnnotator.prototype.reset): Deleted.
591         (WebInspector.TypeTokenAnnotator.prototype._insertAnnotations.): Deleted.
592         (WebInspector.TypeTokenAnnotator.prototype._clearTimeoutIfNeeded): Deleted.
593         * UserInterface/Main.html:
594         * UserInterface/Views/SourceCodeTextEditor.js:
595         (WebInspector.SourceCodeTextEditor):
596         (WebInspector.SourceCodeTextEditor.prototype.shown):
597         (WebInspector.SourceCodeTextEditor.prototype.hidden):
598         (WebInspector.SourceCodeTextEditor.prototype.canShowTypeAnnotations):
599         (WebInspector.SourceCodeTextEditor.prototype.contentDidChange):
600         (WebInspector.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
601         (WebInspector.SourceCodeTextEditor.prototype.prettyPrint):
602         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidPause):
603         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidResume):
604         (WebInspector.SourceCodeTextEditor.prototype._updateTokenTrackingControllerState):
605         (WebInspector.SourceCodeTextEditor.prototype._getAssociatedScript):
606         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenAnnotator):
607         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler.scrollHandler):
608         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler):
609
610 2015-01-06  Joseph Pecoraro  <pecoraro@apple.com>
611
612         Web Inspector: Do not style implicit CSS properties in the Style Rules section
613         https://bugs.webkit.org/show_bug.cgi?id=140161
614
615         Reviewed by Timothy Hatcher.
616
617         Previously, implicit properties being transparent in the Rules section
618         was confusing and not useful. Lets simplify what transparency means:
619
620             - Rules:  transparency means a non-inheritable property in an inherited rule
621             - Computed: transparency means an implicit value
622
623         * UserInterface/Views/CSSStyleDeclarationTextEditor.css:
624         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property.not-inherited):
625         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property:matches(.implicit, .not-inherited)): Deleted.
626
627 2015-01-06  Joseph Pecoraro  <pecoraro@apple.com>
628
629         Web Inspector: Uncaught Exception when dismissing Go To Line dialog
630         https://bugs.webkit.org/show_bug.cgi?id=139663
631
632         Reviewed by Timothy Hatcher.
633
634         Calling removeChild would trigger the blur event handler and do a
635         nested call of dismiss(), re-entering and removing while in the middle
636         of removing. Avoid re-entrancy to avoid the exception.
637
638         * UserInterface/Views/GoToLineDialog.js:
639         (WebInspector.GoToLineDialog):
640         (WebInspector.GoToLineDialog.prototype.dismiss):
641
642 2015-01-01  Darin Adler  <darin@apple.com>
643
644         We often misspell identifier as "identifer"
645         https://bugs.webkit.org/show_bug.cgi?id=140025
646
647         Reviewed by Michael Saboff.
648
649         * UserInterface/Base/Main.js:
650         (WebInspector._updateNavigationSidebarForCurrentContentView):
651         (WebInspector._contentBrowserCurrentContentViewDidChange):
652         Fix misspellings.
653
654 2014-12-29  Jonathan Wells  <jonowells@apple.com>
655
656         Web Inspector: SourceCode.requestContent should return a promise
657         https://bugs.webkit.org/show_bug.cgi?id=135777
658
659         Reviewed by Brian Burg.
660
661         Change SourceCode.js to request content from the backend using Promises. Change Resource.js to use this new
662         approach when determining whether a resource load has finished. Change all calls to the older
663         SourceCode#requestContentFromBackendIfNeeded to simply use requestContent and use a catch function
664         if a content request error needs to be handled. Fix a bug where the appropriate error message for an
665         invalid resource wasn't showing in the resource content view.
666
667         * UserInterface/Controllers/AnalyzerManager.js:
668         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode.):
669         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode):
670         * UserInterface/Controllers/CSSStyleManager.js:
671         (WebInspector.CSSStyleManager.prototype._updateResourceContent.fetchedStyleSheetContent):
672         (WebInspector.CSSStyleManager.prototype._updateResourceContent.styleSheetReady):
673         * UserInterface/Models/CSSStyleSheet.js:
674         (WebInspector.CSSStyleSheet.prototype.requestContentFromBackend):
675         (WebInspector.CSSStyleSheet.prototype.canRequestContentFromBackend): Deleted.
676         * UserInterface/Models/DOMNodeStyles.js:
677         (WebInspector.DOMNodeStyles.prototype.changeStyleText):
678         * UserInterface/Models/Resource.js:
679         (WebInspector.Resource.prototype.canRequestContent):
680         (WebInspector.Resource.prototype.requestContentFromBackend):
681         (WebInspector.Resource.prototype.markAsFinished):
682         (WebInspector.Resource.prototype.markAsFailed):
683         (WebInspector.Resource.prototype.getImageSize):
684         (WebInspector.Resource.prototype.canRequestContentFromBackend): Deleted.
685         * UserInterface/Models/Script.js:
686         (WebInspector.Script.prototype.requestContentFromBackend):
687         (WebInspector.Script.prototype.requestScriptSyntaxTree.catch):
688         (WebInspector.Script.prototype.canRequestContentFromBackend): Deleted.
689         * UserInterface/Models/SourceCode.js:
690         (WebInspector.SourceCode):
691         (WebInspector.SourceCode.prototype.requestContent):
692         (WebInspector.SourceCode.prototype.requestContentFromBackend):
693         (WebInspector.SourceCode.prototype._processContent):
694         (WebInspector.SourceCode.prototype.canRequestContentFromBackend): Deleted.
695         (WebInspector.SourceCode.prototype.requestContentFromBackendIfNeeded): Deleted.
696         (WebInspector.SourceCode.prototype.servicePendingContentRequests): Deleted.
697         * UserInterface/Models/SourceMapResource.js:
698         (WebInspector.SourceMapResource):
699         (WebInspector.SourceMapResource.prototype.requestContentFromBackend.sourceMapResourceLoadError):
700         (WebInspector.SourceMapResource.prototype.requestContentFromBackend):
701         (WebInspector.SourceMapResource.prototype.canRequestContentFromBackend): Deleted.
702         (WebInspector.SourceMapResource.prototype.requestContentFromBackend.sourceMapResourceLoaded): Deleted.
703         * UserInterface/Views/ResourceContentView.js:
704         (WebInspector.ResourceContentView):
705         (WebInspector.ResourceContentView.prototype._contentAvailable):
706         (WebInspector.ResourceContentView.prototype._contentError):
707         * UserInterface/Views/SourceCodeTextEditor.js:
708         (WebInspector.SourceCodeTextEditor):
709         (WebInspector.SourceCodeTextEditor.prototype._contentAvailable):
710         (WebInspector.SourceCodeTextEditor.prototype._populateWithInlineScriptContent.scriptContentAvailable):
711         (WebInspector.SourceCodeTextEditor.prototype._populateWithInlineScriptContent):
712         (WebInspector.SourceCodeTextEditor.prototype._populateWithScriptContent):
713
714 2014-12-26  Dan Bernstein  <mitz@apple.com>
715
716         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
717         https://bugs.webkit.org/show_bug.cgi?id=139950
718
719         Reviewed by David Kilzer.
720
721         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
722         in a manner that works with Xcode 5.1.1.
723
724 2014-12-20  David Kilzer  <ddkilzer@apple.com>
725
726         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
727         <http://webkit.org/b/139463>
728
729         Reviewed by Mark Rowe.
730
731         * Configurations/Base.xcconfig:
732         - Only set TOOLCHAINS on OS X.
733         * Configurations/DebugRelease.xcconfig:
734         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
735         * Configurations/Version.xcconfig:
736         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
737         * Configurations/WebInspectorUIFramework.xcconfig:
738         - Set NORMAL_PRODUCTION_FRAMEWORKS_DIR,
739           PRODUCTION_FRAMEWORKS_DIR and
740           JAVASCRIPTCORE_PRIVATE_HEADERS_DIR_Production by SDK.
741
742 2014-12-19  Commit Queue  <commit-queue@webkit.org>
743
744         Unreviewed, rolling out r177574.
745         https://bugs.webkit.org/show_bug.cgi?id=139821
746
747         "Broke Production builds by installing
748         libWebCoreTestSupport.dylib in the wrong directory" (Requested
749         by ddkilzer on #webkit).
750
751         Reverted changeset:
752
753         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
754         WebInspectorUI, WebKit, WebKit2"
755         https://bugs.webkit.org/show_bug.cgi?id=139463
756         http://trac.webkit.org/changeset/177574
757
758 2014-12-19  David Kilzer  <ddkilzer@apple.com>
759
760         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
761         <http://webkit.org/b/139463>
762
763         Reviewed by Mark Rowe.
764
765         * Configurations/Base.xcconfig:
766         - Only set TOOLCHAINS on OS X.
767         * Configurations/DebugRelease.xcconfig:
768         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
769         * Configurations/Version.xcconfig:
770         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
771         * Configurations/WebInspectorUIFramework.xcconfig:
772         - Set NORMAL_PRODUCTION_FRAMEWORKS_DIR,
773           PRODUCTION_FRAMEWORKS_DIR and
774           JAVASCRIPTCORE_PRIVATE_HEADERS_DIR_Production by SDK.
775
776 2014-12-16  Matt Baker  <mattbaker@apple.com>
777
778         Web Inspector: REGRESSION: Dragging undocked web inspector causes mouse to change from pointer to i-bar cursor over window title
779         https://bugs.webkit.org/show_bug.cgi?id=139720
780
781         Reviewed by Timothy Hatcher.
782
783         * UserInterface/Base/Main.js:
784         Prevent default handling of the mouse event when clicking in the titlebar area. WebCore won't continue handling the event,
785         but docking buttons/context menu still function.
786
787 2014-12-15  Nikita Vasilyev  <nvasilyev@apple.com>
788
789         Web Inspector: Clicking on the expand object arrow should always expand an object
790         https://bugs.webkit.org/show_bug.cgi?id=139382
791
792         Reviewed by Joseph Pecoraro.
793
794         * UserInterface/Views/LogContentView.js:
795         (WebInspector.LogContentView):
796         (WebInspector.LogContentView.prototype._click): Deleted.
797         stopPropagation was preventing the object expansion from happening as expecting.
798
799 2014-12-15  Joseph Pecoraro  <pecoraro@apple.com>
800
801         Web Inspector: CSSStyleDeclarationTextEditor fails to update if computed properties changed from empty to non-empty
802         https://bugs.webkit.org/show_bug.cgi?id=139610
803
804         Reviewed by Timothy Hatcher.
805
806         The CSSStyleDeclarationTextEditor for Computed Style Properties always has
807         empty DOMNodeStyles text. However we would not reset contents if properties
808         changed and the actualy content was empty. So once empty, we could never
809         recover. In fact, we should always refresh for Computed Styles.
810
811         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
812         (WebInspector.CSSStyleDeclarationTextEditor.prototype._propertiesChanged):
813
814 2014-12-08  Joseph Pecoraro  <pecoraro@apple.com>
815
816         Web Inspector: Hide Compositing Borders Button if backend returns an error that it is unsupported
817         https://bugs.webkit.org/show_bug.cgi?id=139307
818
819         Reviewed by Darin Adler.
820
821         * UserInterface/Views/DOMTreeContentView.js:
822         (WebInspector.DOMTreeContentView.prototype._updateCompositingBordersButtonToMatchPageSettings):
823
824 2014-12-05  Joseph Pecoraro  <pecoraro@apple.com>
825
826         Web Inspector: Uncaught Exceptions when attempting to show Content Flow
827         https://bugs.webkit.org/show_bug.cgi?id=139276
828
829         Reviewed by Brian Burg.
830
831         * UserInterface/Views/ContentView.js:
832         (WebInspector.ContentView):
833         (WebInspector.ContentView.isViewable):
834         LegacyJavaScriptProfileObject no longer exists, these references should be removed.
835
836         * UserInterface/Views/FolderizedTreeElement.js:
837         (WebInspector.FolderizedTreeElement.prototype._insertChildTreeElement):
838         This sort function references "this" and needed to be bound.
839
840 2014-12-04  Joseph Pecoraro  <pecoraro@apple.com>
841
842         Web Inspector: Network Timeline Filter Bar only has "All", missing Resource Type filters
843         https://bugs.webkit.org/show_bug.cgi?id=139268
844
845         Reviewed by Brian Burg.
846
847         * UserInterface/Views/TimelineDataGrid.js:
848         (WebInspector.TimelineDataGrid.createColumnScopeBar):
849         Users of createColumnScopeBar pass a Map object now instead of a dictionary.
850         Iterate over the map appropriately.
851
852 2014-12-04  Joseph Pecoraro  <pecoraro@apple.com>
853
854         Web Inspector: LayoutTests/inspector tests fail in Production builds due to missing test resources
855         https://bugs.webkit.org/show_bug.cgi?id=138898
856
857         Reviewed by Mark Rowe.
858
859         In Production builds, if FORCE_TOOL_INSTALL=YES is in the environment
860         we will copy all resources (for Tests) and still do the combine and
861         optimize phase for normal Production inspection resources.
862
863         * Scripts/copy-user-interface-resources.pl:
864
865 2014-12-03  Joseph Pecoraro  <pecoraro@apple.com>
866
867         Web Inspector: Missing getter, clients never see DragToAdjustController is enabled
868         https://bugs.webkit.org/show_bug.cgi?id=139228
869
870         Reviewed by Simon Fraser.
871
872         * UserInterface/Controllers/DragToAdjustController.js:
873         (WebInspector.DragToAdjustController.prototype.get enabled):
874
875 2014-12-02  Joseph Pecoraro  <pecoraro@apple.com>
876
877         Web Inspector: CSS Minification breaks some selectors with colons
878         https://bugs.webkit.org/show_bug.cgi?id=139206
879
880         Reviewed by Simon Fraser.
881
882         Do not remove spaces preceeding colons, as they may change the semantics
883         of selectors with colon prefixes (e.g. "a :not(b)").
884
885         At the same time, we can strip spaces around "!" characters, for example
886         a space is not required before "!important" priority.
887
888         * Scripts/cssmin.py:
889         (cssminify):
890
891 2014-12-01  Benjamin Poulain  <benjamin@webkit.org>
892
893         Web Inspector: add more :not() and :matches() awesomeness
894         https://bugs.webkit.org/show_bug.cgi?id=138997
895
896         Reviewed by Joseph Pecoraro.
897
898         Simplify the Inspector's CSS when possible.
899
900         * UserInterface/Views/DatabaseContentView.css:
901         (:matches(.database-user-query, .database-query-prompt, .database-query-result)::before):
902         (.database-user-query::before, .database-query-prompt::before, .database-query-result::before): Deleted.
903         * UserInterface/Views/GradientSlider.css:
904         (.gradient-slider-knob > :matches(img, div)):
905         (.gradient-slider-knob > div): Deleted.
906         * UserInterface/Views/HoverMenu.css:
907         (.hover-menu > svg > :matches(path, rect)):
908         (.hover-menu > svg > rect): Deleted.
909         * UserInterface/Views/LayerTreeDetailsSidebarPanel.css:
910         (.panel.details.layer-tree .name-column :matches(.pseudo-element, .reflection)):
911         (.panel.details.layer-tree tr.selected .name-column :matches(.pseudo-element, .reflection)):
912         (.panel.details.layer-tree .name-column .reflection): Deleted.
913         (.panel.details.layer-tree tr.selected .name-column .reflection): Deleted.
914         * UserInterface/Views/ProbeDetailsSidebarPanel.css:
915         (.details-section.probe-set .options > :matches(.probe-remove, .probe-clear-samples, .probe-add)):
916         (.details-section.probe-set .options > .probe-add): Deleted.
917         * UserInterface/Views/ResourceSidebarPanel.css:
918         (.sidebar > .panel.navigation.resource > :matches(.content, .empty-content-placeholder)):
919         (body.mac-platform.legacy .sidebar > .panel.navigation.resource > :matches(.content, .empty-content-placeholder)):
920         (.sidebar > .panel.navigation.resource > .empty-content-placeholder): Deleted.
921         (body.mac-platform.legacy .sidebar > .panel.navigation.resource > .empty-content-placeholder): Deleted.
922         * UserInterface/Views/ScopeBar.css:
923         (.scope-bar > li:matches(.selected, :active)):
924         (.scope-bar > li:active): Deleted.
925         * UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
926         (.syntax-highlighted :matches(.css-comment, .javascript-comment, .html-comment)):
927         (.syntax-highlighted :matches(.css-keyword, .css-tag, .css-at-rule, .css-important, .javascript-keyword, .html-tag)):
928         (.syntax-highlighted :matches(.css-number, .javascript-number)):
929         (.syntax-highlighted :matches(.css-property, .css-selector, .javascript-ident)):
930         (.syntax-highlighted :matches(.css-string, .javascript-string, .javascript-regexp, .html-attribute-value)):
931         (.syntax-highlighted :matches(.html-doctype, .html-processing-instruction)):
932         (.syntax-highlighted .html-comment): Deleted.
933         (.syntax-highlighted .html-tag): Deleted.
934         (.syntax-highlighted .javascript-number): Deleted.
935         (.syntax-highlighted .javascript-ident): Deleted.
936         (.syntax-highlighted .html-attribute-value): Deleted.
937         (.syntax-highlighted .html-processing-instruction): Deleted.
938         It looks like ".cm-tag.cm-bracket" was there only to override the rule below.
939         From basic testing, it looks like "cm-tag" and "cm-bracket" always appear together. I removed the "cm-bracket" rule
940         from the second rule, and simplified the first rule.
941
942         * UserInterface/Views/TimelineSidebarPanel.css:
943         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > :matches(.content, .empty-content-placeholder)):
944         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .empty-content-placeholder): Deleted.
945         * UserInterface/Views/Toolbar.css:
946         (body.mac-platform:not(.legacy, .docked) .toolbar):
947         (body.mac-platform:not(.legacy, .docked) .toolbar.icon-and-label-vertical):
948         (body.mac-platform:not(.legacy, .docked) .toolbar.icon-and-label-vertical.small-size):
949         (body.mac-platform:not(.legacy, .docked) .toolbar:matches(.icon-and-label-horizontal, .icon-only)):
950         (body.mac-platform:not(.legacy, .docked) .toolbar:matches(.icon-and-label-horizontal.small-size, .icon-only.small-size, .label-only)):
951         (.toolbar:matches(.icon-and-label-horizontal.small-size, .icon-only.small-size, .label-only) .control-section):
952         (body.mac-platform:not(.legacy):not(.docked) .toolbar): Deleted.
953         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical): Deleted.
954         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical.small-size): Deleted.
955         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-only): Deleted.
956         (body.mac-platform:not(.legacy):not(.docked) .toolbar.label-only): Deleted.
957         (.toolbar.label-only .control-section): Deleted.
958
959 2014-11-27  Andres Gomez  <agomez@igalia.com>
960
961         Web Inspector: Update NavigationItemProbes icon for the GTK+ port
962         https://bugs.webkit.org/show_bug.cgi?id=139074
963
964         Reviewed by Carlos Garcia Campos.
965
966         NavigationItemProbes was updated for the Mac port and we are now
967         having a similar ideogram in GTK+.
968
969         * UserInterface/Images/gtk/NavigationItemProbes.svg: Updated.
970
971 2014-11-21  Benjamin Poulain  <bpoulain@apple.com>
972
973         Start using the new :not() and :matches() in the Web Inspector
974         https://bugs.webkit.org/show_bug.cgi?id=138978
975
976         Reviewed by Joseph Pecoraro.
977
978         Start simpifying some definitions by using modern CSS.
979
980         * UserInterface/Views/CSSStyleDeclarationSection.css:
981         (body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:matches(.last-in-group, :last-child)):
982         (.style-declaration-section:matches(.locked, .selector-locked) > .header > .selector):
983         (body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:last-child): Deleted.
984         (.style-declaration-section.selector-locked > .header > .selector): Deleted.
985         * UserInterface/Views/CSSStyleDeclarationTextEditor.css:
986         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property:matches(.disabled, .invalid, .other-vendor, .not-inherited, .overridden)):
987         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property:matches(.implicit, .not-inherited)):
988         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .editing-line .css-style-declaration-property:matches(.disabled, .other-vendor, .not-inherited, .overridden)):
989         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property.overridden): Deleted.
990         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property.not-inherited): Deleted.
991         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .editing-line .css-style-declaration-property.overridden): Deleted.
992         * UserInterface/Views/ControlToolbarItem.css:
993         (.toolbar:matches(.icon-and-label-horizontal, .toolbar.icon-only) .item.control):
994         (.toolbar.icon-only .item.control): Deleted.
995         * UserInterface/Views/DOMStorageContentView.css:
996         * UserInterface/Views/DashboardContainerView.css:
997         (.toolbar.icon-and-label-vertical:matches(.small-size, .normal-size) .dashboard-container):
998         (.toolbar:matches(.label-only, .small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal)) .dashboard-container):
999         (.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard-container):
1000         (.toolbar.normal-size.icon-and-label-vertical .dashboard-container): Deleted.
1001         (.toolbar.small-size.icon-and-label-horizontal .dashboard-container): Deleted.
1002         (.toolbar.normal-size.icon-and-label-horizontal .dashboard-container): Deleted.
1003         * UserInterface/Views/DataGrid.css:
1004         (.data-grid :matches(th, td):not(:last-child)):
1005         (.data-grid th:matches(.sort-ascending, .sort-descending)):
1006         (.data-grid :matches(th, td) > div):
1007         (.data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child):
1008         (.data-grid tr:matches(.selected, :hover) .go-to-arrow):
1009         (.data-grid :-webkit-any(th, td):not(:last-child)): Deleted.
1010         (.data-grid th:-webkit-any(.sort-ascending, .sort-descending)): Deleted.
1011         (.data-grid :-webkit-any(th, td) > div): Deleted.
1012         (.data-grid th:-webkit-any(.sort-ascending, .sort-descending) > div:first-child): Deleted.
1013         (.data-grid tr:-webkit-any(.selected, :hover) .go-to-arrow): Deleted.
1014         * UserInterface/Views/DebuggerDashboardView.css:
1015         (.toolbar.collapsed .dashboard.debugger > :not(.message, .navigation-bar )):
1016         (.toolbar.collapsed .dashboard.debugger > :not(.message):not(.navigation-bar )): Deleted.
1017         * UserInterface/Views/DefaultDashboardView.css:
1018         (body.web .toolbar.collapsed .dashboard.default > :matches(.time, .resourcesSize, .logs)):
1019         (body.javascript .toolbar .dashboard.default > :matches(.time, .resourcesSize, .resourcesCount)):
1020         (.toolbar:matches(.label-only, .small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal)) .dashboard.default > .item):
1021         (.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard.default > .item):
1022         (body.web .toolbar.collapsed .dashboard.default > .logs): Deleted.
1023         (body.javascript .toolbar .dashboard.default > .resourcesCount): Deleted.
1024         (.toolbar.small-size.icon-and-label-horizontal .dashboard.default > .item): Deleted.
1025         (.toolbar.normal-size.icon-and-label-horizontal .dashboard.default > .item): Deleted.
1026         * UserInterface/Views/DetailsSection.css:
1027         (.details-section > .header > :matches(.node-link, .go-to-arrow)):
1028         (.details-section > .content > .group:nth-child(even) > .row:matches(.simple:first-child > *, :not(.simple):first-child)):
1029         (body.mac-platform.legacy .details-section > .content > .group:matches(:nth-child(even), :last-child) > .row.simple:last-child > *):
1030         (.details-section > .content > .group > .row:matches(.empty, .text)):
1031         (body.mac-platform.legacy .details-section > .content > .group > .row:matches(.empty, .text)):
1032         (.details-section > .header > .go-to-arrow): Deleted.
1033         (.details-section > .content > .group:nth-child(even) > .row.simple:first-child > *): Deleted.
1034         (body.mac-platform.legacy .details-section > .content > .group:last-child > .row.simple:last-child > *): Deleted.
1035         (.details-section > .content > .group > .row.text): Deleted.
1036         (body.mac-platform.legacy .details-section > .content > .group > .row.text): Deleted.
1037         * UserInterface/Views/FindBanner.css:
1038         (:matches(.find-banner, .supports-find-banner).no-find-banner-transition):
1039         (.supports-find-banner.no-find-banner-transition): Deleted.
1040         * UserInterface/Views/FlexibleSpaceNavigationItem.css:
1041         (:matches(.navigation-bar, .toolbar) .item.flexible-space):
1042         (.toolbar .item.flexible-space): Deleted.
1043
1044 2014-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1045
1046         Web Inspector: LayoutTests/inspector should not have localStorage side effects
1047         https://bugs.webkit.org/show_bug.cgi?id=138895
1048
1049         Reviewed by Brian Burg.
1050
1051         When running inspector tests, do not restore/save WebInspector.Settings
1052         to localStorage, as that will cause side effects. Instead each Setting
1053         will be initialized with its default value and can be modified during
1054         the run of the test.
1055
1056         * UserInterface/Base/Test.js:
1057         (WebInspector.loaded):
1058         Name the setting to match the normal setting name now that persistence
1059         is not an issue.
1060
1061         * UserInterface/Models/Setting.js:
1062         (WebInspector.Setting.prototype.get value):
1063         (WebInspector.Setting.prototype.set value):
1064         Do not restore/save when in tests.
1065
1066 2014-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1067
1068         Web Inspector: JSContext inspection Resource search does not work
1069         https://bugs.webkit.org/show_bug.cgi?id=131252
1070
1071         Reviewed by Timothy Hatcher.
1072
1073         * UserInterface/Views/ResourceSidebarPanel.js:
1074         (WebInspector.ResourceSidebarPanel.prototype.performSearch.resourceCallback):
1075         (WebInspector.ResourceSidebarPanel.prototype.performSearch.resourcesCallback):
1076         Cleanup by reordering things a bit.
1077
1078         (WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts.scriptCallback):
1079         (WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts):
1080         (WebInspector.ResourceSidebarPanel.prototype.performSearch):
1081         Search non-resource scripts individually.
1082
1083         (WebInspector.ResourceSidebarPanel.prototype._searchTreeElementForScript):
1084         Lazily create a ScriptTreeElement for the search tree outline as needed.
1085
1086         (WebInspector.ResourceSidebarPanel.prototype._scriptsToSearch):
1087         When searching scripts, just perform a shallow walk of the tree outline to find
1088         Script resources that are not also Resources. Scripts are always guarenteed to
1089         be in a folder when inspecting a web resource. For JSContext inspection, scripts
1090         are promoted to the top level.
1091
1092         * UserInterface/Main.html:
1093         * UserInterface/Models/SourceCodeSearchMatchObject.js: Renamed from Source/WebInspectorUI/UserInterface/Models/ResourceSearchMatchObject.js.
1094         (WebInspector.SourceCodeSearchMatchObject):
1095         * UserInterface/Views/SearchIcons.css:
1096         (.source-code-match-icon .icon):
1097         (.resource-match-icon .icon): Deleted.
1098         * UserInterface/Views/SearchResultTreeElement.js:
1099         (WebInspector.SearchResultTreeElement):
1100         Rename ResourceSearchMatchObject to SourceCodeSearchMatchObject.
1101
1102 2014-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1103
1104         Web Inspector: Provide $exception in the console for the thrown exception value
1105         https://bugs.webkit.org/show_bug.cgi?id=138726
1106
1107         Reviewed by Timothy Hatcher.
1108
1109         * UserInterface/Base/Test.js:
1110         (WebInspector.loaded):
1111         In order to use RuntimeManager to execute in the global context or on the
1112         active debugger call frame, we need to expose the quickConsole controller.
1113
1114         * UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
1115         Expose $exception to completion when we paused because of an exception.
1116
1117 2014-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1118
1119         Web Inspector: Debugger should not mutate variable when hovering mouse over ++n expression
1120         https://bugs.webkit.org/show_bug.cgi?id=138839
1121
1122         Reviewed by Timothy Hatcher.
1123
1124         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
1125         (WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
1126
1127 2014-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1128
1129         Web Inspector: Improve basic JavaScript completion in inline <script>s
1130         https://bugs.webkit.org/show_bug.cgi?id=138845
1131
1132         Reviewed by Timothy Hatcher.
1133
1134         * UserInterface/Controllers/CodeMirrorCompletionController.js:
1135         (WebInspector.CodeMirrorCompletionController.prototype._generateJavaScriptCompletions):
1136         Fix up CodeMirror mode handling for JavaScript completion when inside of mixed mode
1137         input (html). Also add completion for CodeMirror's localVars list.
1138
1139 == Rolled over to ChangeLog-2014-11-19 ==